Fix back link on check your answers page

This updates the back link on the "Check your answers page" so that it takes you back to the right page. This could be one of:

The upload image (for the product) page
The pH radio-button question for the last component
The min and max pH for the last component

Review app: https://cosmetics-pr-1471-submit-web.london.cloudapps.digital

@nasirkhanbeis I've updated this now so that for multi-item kits, the back link goes to the right page.

@frankieroberto
Multi-item journey looks good with the new fix. good stuff.
Just a minor issue around single item journey -
Steps to replicate
1.On check your answer page, click back button,
2.It will take to pH previous question, suppose if they entered range min max then its okay,
3. Click back and on pH selection page, select "no it doesn't have pH" and continue
4. Now click back on check your answer page - It is expected to take back to pH selection page but not to range min max page which was in step 2.

@nasirkhanbeis good spot! I think this is actually a separate bug, which is that if you change your answer from having an explicit pH range to not needing a pH range (eg selecting between 3 - 10 or "it does not have a pH") then the previous explicit pH range isn't removed. I think I'll fix this as a separate ticket, and then that should make the back link work here too.

@nasirkhanbeis bug fixed as part of #1474. Could you review that? Once that's merged, I'll update this branch and the back button link should fix itself.

Possible scenario on back button in check your answer page

Single item manual journey pre-bexit - should return to pH question page - Passed( further back button breaks the journey- will be fixed in separate ticket)
Single Item manual journey post brexit- should return to Image upload page - Passed
Multi-item manual pre/post brexit -  should to component list page - Passed
Bulk upload pre brexit- single item  - should return to dashboard page  - Passed
Bulk upload  pre brexit - single item frame formulation upload  then check your answer page - should return to frame formulation page - Failed ( returning to pH question page)
Bulk upload pre-brexit - multi-item  frame formulation - should return to frame formulation page of last item - Failed  (returns to component list page)
Bulk upload pre-brexit - single item nano material - should return to nano-material question - Failed( returning to pH question)

@frankieroberto  I summarised list of possible scenarios in my comment above, can you pls fix the failures mainly around bulk-upload  pls? thanks.


Name change proposal for "Device" class to "Drone" or "Vehicle"

This is regarding name change proposal of the class Device, DeviceImpl, etc.
We've named the library & API after drone, as in DroneCore, it makes sense to name its core service class to be class Drone, or at least class Vehicle (in QGroundControl) rather than class Device.
Cons of having Device name is that it is likely to be used for Ground Control Station, Mobile device also.
In other words, GCS is a device as well;
When we say Vehicle, there is room of confusion whether it is Drone or Ground Control Station.
If DroneCore is also intended for general Robotics application, then probably Device might sound good.
Kindly share your thoughts, opinions.
Thanks.

I chose device initially because DroneCore can also be used for a land robot or a (mavlink enabled) camera only.

Device works for me given the camera-support aspect - and indeed there is no reason we couldn't do antenna trackers or any other mavlink controlled thingy.

Alright, if its used for standalone devices like camera, then Device is fine.
Thanks @julianoes @hamishwillee .


How could I get route.description in app.routes or somewhere?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
@app.get("/",description='test')
async def index():
    return RedirectResponse("/sign_in")

for route in app.routes:
    print(route.name,route.path) # something like route.description?

Description
I can get name,path,method of a route, but i don't know how to get the description.
Operating System
Linux
Operating System Details
20.04
FastAPI Version
0.66.1
Python Version
3.9.5
Additional Context
No response

@skk294
Basic routes(OpenApi) have a class Route in which there is no "description" field
You can write like this
from fastapi.routing import APIRoute
app = FastApi()
@app.get("/",description='test')
async def index():
return RedirectResponse("/sign_in")
for route in app.routes:
if isinstance(route, APIRoute):
print(route.name, route.path, route.description)

@skk294
Basic routes(OpenApi) have a class Route in which there is no "description" field
You can write like this

from fastapi.routing import APIRoute

app = FastApi()

@app.get("/",description='test')
async def index():
    return RedirectResponse("/sign_in")

for route in app.routes:
    if isinstance(route, APIRoute):
        print(route.name, route.path, route.description)

Thanks.(￣▽￣)/


[Question] Reflecting the called function from the middleware

I'm trying to figure out if the called function code can be reflected or not.
The passed into middleware FunctionContext has a FunctionDefinition property. The property contains a string that represents the class and the function in the code. But I cannot use reflection to gain access to the type/method to reflect custom attributes.
My question is does middleware suppose to be able to access the type hosting the function and if yes, would it be possible to break out the type and the method into two properties under FunctionDefinition instead of a single context.FunctionDefinition.EntryPoint.

@SeanFeldman wanted to add a comment here. This is something we do intend to expose. We're hoping we can prioritize this work soon and will share the design/experience for feedback ahead of implementation.

Any progress on this?

Thanks you BenjaBobs
We will use your code and this lib https://github.com/madelson/DistributedLock/blob/master/docs/Semaphores.md
to replace this missing SingletonAttribute

@laurentAstonIf / @BenjaBobs - I believe this may not give you the existing experience you are looking for. For me, I am using a ServiceBusTrigger and I want singleton-like behavior so that the messages are processed absolutely in order; therefore, only a single function instance should process the queue, which the existing Singleton attributed enabled.
The code above is implemented as middleware, which will get invoked once a message has been peek+lock, so will either semaphore lock that message, or wait until it can, either way the message is peeked. Any additional process in running in parallel will peek+lock the next regardless. If the semaphore lock time is greater than max for message the lock will be released and another process can get it. Please correct me if I am wrong?
Therefore, there is a need for a worker-based Singleton that ensures single execution before a lock dequeue/lock occurs. Maybe, it could be added as a property on the ServiceBusTrigger (and others) if a generic Singleton is not possible?
Finally, @fabiocav is there any progress? 🙏

To add to what @chullybun said, it will negatively impact all triggers. This approach is buffering requests/messages/etc, which will drive functions to scale out, translating into cost increase and errors. Also, for triggers such as ASB, for some it will result in unnecessary message dead-lettering.
This is not a problem for middleware but for the host.

@laurentAstonIf @BenjaBobs FYI we're using the same solution and hope there will be a solid solution in the host in the near future.

I'm add a point where I'm avoiding azure functions where I can, and use MassTransit and Quartz.net instead to fill the same role.
We mostly use timer triggers and queue triggers, so it was an easy jump for us.

We've implemented a singleton functions middleware like above (https://github.com/Azure/azure-functions-dotnet-worker/issues/938#issuecomment-1167329390). As chullybun and SeanFeldman stated this doesn't play nice with existing triggers and in the end only works on a servicebustrigger with a NewBatchThreshhold of 0.
@fabiocav is there any progress or guidance how to solve this? Is it possible to implement a custom servicebustrigger?

Also looking for a singleton implementation as the last piece of our Azure function migration

This item is for behavior within the middleware pipeline and accessing function metadata. Please track #274 for singleton discussions.


Use default PlatformToolset and latest WinSDK version.

As long as the WindowsTargetPlatformMinVersion is set, it shouldn't be necessary to install a specific WinSDK version.
MSVC allows using a shortcut to use the "latest installed": 10.0. This way, any SDK version greater or equal than the minimum required will work without forcing the user to install or retarget.
Also, the PlatformToolset property is not that tightly bound to the VS version. Both v141 and v142 can be installed with VS2019.
This change uses the default toolset for the given VS version, so no explicit version handling needs to be done.

The platform toolset is actually quite important. We have recently seen that sometimes the toolset is buggy and produces unexpected behaviour.

The platform toolset is actually quite important. We have recently seen that sometimes the toolset is buggy and produces unexpected behaviour.

Agreed, but I think this should be still easily settable.
I'm adding a revamped build script that will resolve this.
By the way, I'm trying to build with the latest SDK (Win1903-equivalent).
I'll let you know how well it works.

Suggestions have been addressed.
Please also take a look at Build-FFmpeg.ps1, which should make the process much more simple.

The platform toolset is actually quite important. We have recently seen that sometimes the toolset is buggy and produces unexpected behaviour.

Agreed. Because of this, the PS1 script is defaulting to v141.

@JunielKatarn The ffmpeg include folder is already added in FFmpegInteropLibs.prop. Is there a reason why you add it a second time directly in vcxproj file? Also, we include it based on $(ProjectDir) not $(SolutionDir), so people can include the FFmpegInterop project in their app solution, and it builds successfully no matter where the app solution file is.

@JunielKatarn The ffmpeg include folder is already added in FFmpegInteropLibs.prop. Is there a reason why you add it a second time directly in vcxproj file? Also, we include it based on $(ProjectDir) not $(SolutionDir), so people can include the FFmpegInterop project in their app solution, and it builds successfully no matter where the app solution file is.

I hadn't noticed the PROPS file. Reverting that part of the change.

I have also sent you a Collaborator invitation. So if you like, you can work directly on this repo.


SRS as RTSP Server

Note: Please read FAQ before file an issue, see #2716

Description
How can I modify the configuration to support RTSP output?
Also, I notice the issue : https://github.com/ossrs/srs/issues/2304. I want to ask how can I recover the RTSP out by recompiling SRS.

SRS Version: 6.0

SRS Log:

Could not write header for output file #0 (incorrect codec parameters ?): Connection refused
Error initializing output stream 0:0 --
Replay
Please describe how to replay the bug?
Step 1:
ffmpeg -i<EMAIL_ADDRESS>-c copy -f rtsp rtsp://<IP_ADDRESS>/live/stream

Expect
I can push RTSP to SRS and run SRS as RTSP server.
TRANS_BY_GPT4

SRS removed RTSP's code, no support now.
See this issue.


Removing Repository Release

Totally my fault.  New to using GitHub and didn't not read your FAQ before messing with my Repository at https://github.com/InqOnThat/InqPortal.  This is what I did...

deleted 5.1.1
created 5.1.2 - I think on 3/11
Although I see 5.1.2 in the log:  http://downloads.arduino.cc/libraries/logs/github.com/InqOnThat/InqPortal/
It never showed up in the Arduino IDE Library Manager
This is when I found the FAQ
I could not find a way to delete the tag as described in the FAQ at https://github.com/InqOnThat/InqPortal/tags
So I tried to re-create a 5.1.1 release, hoping that your system would detect it, but see that 5.1.2 now available.

Can you help me fix my problem?

Hi @InqOnThat
Problem
The problem is shown here in the logs:
2022/03/15 07:22:32 Checking out tag: v5.1.2
2022/03/15 07:22:32 Release InqPortal:5.1.1 already loaded, skipping

Unfortunately, the logs don't communicate about this particular thing very well, but what this tells us is that the version value in the library.properties metadata file was not updated before creating the v5.1.2 tag (note that the indexer checked out tag v5.1.2, only to find the release version was 5.1.1).
You can see it here:
https://github.com/InqOnThat/InqPortal/blob/v5.1.2/library.properties#L2
version=5.1.1

Even though Git tags are the unit of release for the Arduino Library Manager, all versioning is done according to the  version field of the library.properties file. For this reason, the indexer will reject any tag that has the same value in its version field as a release already in the index.
Solution
The solution is to make another release of the library which meets the requirements:

Update the version value in library.properties to the version that will be used for the new release.
Create a new release or tag in the library repository.

The indexer system will pick up that new release and it will be available from Library Manager within a day. The non-compliant release will still be missing, but since the newer release will be available, that is no problem.
Please let me know if you have any questions or concerns.
Regards, Per


Remove "app" directory

For custom applications it is useful to use Wegue as git submodule and symlink the app directory into Wegue. This is for example done here: https://github.com/meggsimum/wegue-demos This works in general, but the upgrading Wegue to a new commit is a bit cumbersome, because the template app directory overwrites the appsymlink. Moreover git assumes that the Wegue git submodule is "dirty".
This pull request removes the app directory, in order to make Wegue upgrade easier in custom applications.
I already tested npm run init:app and it works without problem.
Things to check:

[ ] make sure this works with Docker

TODO:

[ ] keep README.md

Thanks for this @JakobMiksch. I have to check in detail and if the Docker image is still working.
One first question: Is there a reason why you delete app-starter/README.md ?

I deleted app-starter/README.md because it would be copied to app as well, which might be confusing. Otherwise we can modify the init-app.js script to exlude the README.md

I'd vote for modification of the init-app.js script to exclude the README.md from copying.

Thinking with you: I see the need for easier use of Wegue in applications. Up to now a fork/clone of the Wegue repo was assumed, but that is not very flexible, e.g. when having multiple app-repos. I think in the end we should aim for Wegue as an NPM module with a Wegue CLI "wegue create app" etc . Maybe this is easier than we think: e.g. https://zellwk.com/blog/publish-to-npm/.
Wegue as submodule can be useful as well. Not sure if using a symlink for app is a flexible way to go. Thinking of alternatives for using submodule...Also https://github.com/meggsimum/wegue-demos/blob/master/create-wegue-app.sh assumes a bash-environment...(shouldn't line 71 be ln -s app wegue/app?) Would be nice if we could run something like npm run init:app ../app from within the Wegue submodule dir and let the JS script figure out. In first instance it is mainly the imports that need wegue/src i.s.o. ..src/ from the app-template. But I foresee issues with build and Docker in this case...How does the symlink play with GitHub? It is within the submodule, what happens on commit/push and if someone else clones the app repo?

Hi @justb4. Thanks for you feedback! Having a npm module would indeed be great. I try to be pragmatic for the moment and try to use wegue as git submodule. This is an attempt to make upgrading exisiting wegue-based apps easier. Because ideally an upgrade to the latest commit should not be more than a git pull inside the submodule.
But I agree, that there are still some open questions how this symlink-approach works in production. Currently I am moving an old Wegue-app with this method and try to get some experience. The first thing I noticed was that Wegue also indexes the app directory. Hence, if the app directory could be removed from the Wegue repo, my upgrade process would be much easier.
My current directory structure looks like below. The app directory is located outside of Wegue. That's why I think ln -s app wegue/app should be okay.
.
├── app
│   ├── components
│   ├── static
│   ├── WguAppTemplate.vue
│   └── WguApp.vue
└── wegue
    ├── app -> ../app
    ├── app-starter
    ├── build
    ├── ci
    ├── config
    ├── Dockerfile
    ├── docs
    ├── embedded.html
    ├── index.html
    ├── LICENSE.md
    ├── node_modules
    ├── package.json
    ├── package-lock.json
    ├── README.md
    ├── screenshots
    ├── src
    ├── test
    └── util

@JakobMiksch Ok, let's aim for the submodule scenario (you still need to look at line 71 of create-wegue-app.sh.
Think leaving out the app dir could work but you only can have one app (symlink) per repo. Two things on submodule usage, (IMHO) best to try out:

git submodules need to be maintained for versioning as well: they represent not just a repo but also a commit-level (hash), optionally (I think) a branch from the original repo. Just doing git pull within your submodule dir only makes your local copy uptodate with Wegue master. You also need to add/commit/push those changes to increase your submodule's commit level.
thinking of that I think that Wegue (or your repo) should then have a .gitignore for Wegue's app dir. Otherwise it will try to update the original Wegue repo with the symlink (which will fail for most users).

I noticed a bug with this symlink apporach: https://github.com/meggsimum/wegue-demos/issues/1
Currently I am not sure if this a systematic problem of symlinks

I noticed a bug with this symlink apporach: https://github.com/meggsimum/wegue-demos/issues/1
Currently I am not sure if this a systematic problem of symlinks

closing, because it seems that meggsimum/wegue-demos#1 cannot be fixed easily


Add support of aarch64

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi @tartansandal, thanks a lot for this great forge. I need this to support for my aarch64 machine, but the build failed since the conda-bash-completion which is also maintained by you. Are you considering to also put that on conda-forge and having aarch64 supported? Thanks!

Hi @unkcpz :wave: I'll definitely have a look at extending support to include aarch64. I am a little pressed for time at the moment, so I not get around to looking into this till next weekend. :smile:

@tartansandal Thanks a lot for looking at it. No hush on it 😄

Hi @tartansandal, any update on this? We may need this for one of our docker container builds to support arm64.

Sorry for the delay @unkcpz :pray:  I'm actually not entirely sure why conda-bash-completion is not being built for aarch64. The only arch we skip  is Windows. Maybe I need to trigger a rebuild somehow.

thanks @tartansandal. You mean https://github.com/tartansandal/conda-bash-completion correct? I am a bit confused that the repo seems not a standard conda-forge recipe? You need to trigger the rebuild by hand I assume.

If memory serves, there's a global file for condaforge that lists all
packages that support aarch64, where the package's name needs to be added.
I believe I did it for another repo.
Found it:
https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/osx_arm64.txt
Uh, weird, I had already added it in commit
51bfbe23f4573712ed4fc5f6bc7c5f2e8f78266e .
Maybe remove it, then readd it, and wait a few hours?

Thanks @jucor. So I re-render the build of this PR and see if it works?

Not yet, I think you need to add the package's name to the arch migration file in conda-forge-pinning, then the udpate should be automatic but can take a little while -- so monitor the status page, to see if it is pending, done, or failed.

To be clearer: my experience from adding OSX support to conda-bash-completion via https://github.com/tartansandal/conda-bash-completion/issues/18 is that, upon adding the  package name to the right fine in conda-forge-pinning repo, a bot automatically made a PR in this current repo with the correct modifications to this feedstock repo. I did not have to do any manual modifications.
So you might want to try that :)

Okay thanks, I know how to add support to aarch64, we did that for other packages before. I just didn't find the correct feedstock where it is in https://github.com/conda-forge/conda-bash-completion-feedstock ;)
I open a PR to rebuild https://github.com/conda-forge/conda-bash-completion-feedstock/pull/7 Let's see if that works.

@jucor Thanks so much for the refresher course on updating the arch. Its been such a long time. :smile: :heart:

With pleasure! I'm referring to it from memory and reading my own PRs, so I hope I'm not saying too much bullsh*t 😂 Hope this helps!

@jucor Yes it is very helpful, I can not find the feedstock repo if I did not follow the link of your PR :smile:

@conda-forge-admin, please rerender

@unkcpz I just manually triggered a re-run of the failed check to kick things along.

@conda-forge-admin, please rerender

@unkcpz It looks like we'll have to wait for the conda-forge bots to build and distribute the new version before these checks will pass.

Maybe a rerender is required? I find the conda-bash-completion just has a new release published (after you retrigger it.)

Maybe a rerender is required?

There is nothing to rerender.  We may have to wait for all the mirrors to be updated so that Azure can find the new version.  To kick of a fresh test, click on "Details" in the above failed check, then click on "Re-run failed jobs".  I've just done this. Best not to do too often or you will run out of you Azure quota.

I'm off to bed now. I'll merge in the morning if the checks pass.

@conda-forge-admin, please rerender

Okay no problem, have a good evening.
I don't have permission to trigger the build manually. I add myself to the recipe maintainer, I hope this is okay for you.
I also did a re-trigger by force push, hope it works.

Everything is good now! :confetti_ball:

@unkcpz All done. Best of luck with your docker stack! :smile:


Optional flags in ProposalStoreCodeCmd are not being used

Summary
In ProposalStoreCodeCmd, optional flags such as flagInstantiateByEverybody, flagInstantiateNobody, flagInstantiateByAddress, and flagInstantiateByAnyOfAddress are not being used in the command. Is this intended?
Version
v0.29.2

are not being used in the command

They are registered with the command (wasmd tx gov submit-proposal wasm-store -h) and read via parseStoreCodeArgs in parseAccessConfigFlags. I hope this answers the question.
Please note that v0.30.0. was released already


[Question/Feedback]: Deploy non-pattern with custom services selected only

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
Hey team,
A sort of follow on from: https://github.com/Azure/azure-monitor-baseline-alerts/issues/233 except, I am looking to adopt only -some- of the AMBA policies and assign these to a singular management group or two of choice rather than deploying as part of a pattern.
Essentially, I want to have health/maintenance/service and then hand select services from: https://github.com/Azure/azure-monitor-baseline-alerts/tree/main/services that we utilise as core approved services and ignore all the rest.
I have taken a look at the Monitoring Packs for PaaS which seems promising but we don't need the additional overhead of the function as our VMs are covered by another monitoring solution for now and it doesn't look like it covers the service health aspect.
I was thinking I could modify: https://github.com/Azure/azure-monitor-baseline-alerts/blob/main/patterns/alz/templates/policies.bicep and exclude all policies I do not wish and build these to .json and then just deploy the definitions and group to an initiative for web etc.
Any thoughts on this would be appreciated!

Hello @riosengineer ,
thanks for your question, The approach you would like to follow looks definitely correct. Cloning the repo and making the necessary changes to restructure the current policy assignments to your need  should work. Of course, depending on the file you will change, this can break the sync capability between your fork and the official one when new version are released. There's a guidance you can check which does something similar at Deploy only Service Health Alerts | Custom deployment.
Hope that helps,
Bruno.

Hello @riosengineer , thanks for your question, The approach you would like to follow looks definitely correct. Cloning the repo and making the necessary changes to restructure the current policy assignments to your need should work. Of course, depending on the file you will change, this can break the sync capability between your fork and the official one when new version are released. There's a guidance you can check which does something similar at Deploy only Service Health Alerts | Custom deployment.
Hope that helps, Bruno.

Thanks Bruno. I think as long as I keep a mechanism that works my side to keep an eye on updates, it should hopefully be fairly straight forward for me to update my definitions folders and subsequent bicep file for the generations.

Hey @Brunoga-MS ,
Just looking at this again, apologies. I'm editing the policyDefinitions like below, where I've added some sql definitions from services folder, and excluded all alerts we do not wish to have like:
var loadPolicyDefinitions = {
  All: [
    // Used in Connectivity policy definitions only
    // loadTextContent('../../../services/Network/azureFirewalls/Deploy-ActivityLog-AzureFirewall-Del.json')
    // loadTextContent('../../../services/Network/networkSecurityGroups/Deploy-ActivityLog-NSG-Del.json')
    // loadTextContent('../../../services/Network/routeTables/Deploy-ActivityLog-RouteTable-Update.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-ActivityLog-VPNG-Del.json')
    // loadTextContent('../../../services/Network/azureFirewalls/Deploy-AFW-FirewallHealth-Alert.json')
    // loadTextContent('../../../services/Network/azureFirewalls/Deploy-AFW-SNATPortUtilization-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteCircuits/Deploy-ERCIR-ARPAvailability-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteCircuits/Deploy-ERCIR-BGPAvailability-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteCircuits/Deploy-ERCIR-QOSDropsBitsIn-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteCircuits/Deploy-ERCIR-QOSDropsBitsOut-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteGateways/Deploy-ERG-BitsInPerSecond-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteGateways/Deploy-ERG-BitsOutPerSecond-Alert.json')
    // loadTextContent('../../../services/Network/expressRouteGateways/Deploy-ERG-CPUUtilization-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-BitsInPerSecond-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-BitsOutPerSecond-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-LineProtocol-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-RxLightLevelHigh-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-RxLightLevelLow-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-TxLightLevelHigh-Alert.json')
    // loadTextContent('../../../services/Network/expressRoutePorts/Deploy-ERP-TxLightLevelLow-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-ERGBitsPerSecond-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-ERGCPUUtilization-Alert.json')
    // loadTextContent('../../../services/Network/privateDnsZones/Deploy-PDNSZ-CapacityUtilization-Alert.json')
    // loadTextContent('../../../services/Network/privateDnsZones/Deploy-PDNSZ-QueryVolume-Alert.json')
    // loadTextContent('../../../services/Network/privateDnsZones/Deploy-PDNSZ-RecordSetCapacity-Alert.json')
    // loadTextContent('../../../services/Network/privateDnsZones/Deploy-PDNSZ-RegistrationCapacityUtilization-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-BandwidthUtilization-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-Egress-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-EgressPacketDropCount-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-EgressPacketDropMismatch-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-Ingress-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-IngressPacketDropCount-Alert.json')
    // loadTextContent('../../../services/Network/virtualNetworkGateways/Deploy-VNETG-IngressPacketDropMismatch-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-BandwidthUtilization-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-BGPPeerStatus-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-Egress-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-EgressPacketDropCount-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-EgressPacketDropMismatch-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-Ingress-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-IngressPacketDropCount-Alert.json')
    // loadTextContent('../../../services/Network/vpnGateways/Deploy-VPNG-IngressPacketDropMismatch-Alert.json')

    // Used in LandingZone policy definitions only
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-ApplicationGatewayTotalTime-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-BackendLastByteResponseTime-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-CapacityUnits-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-ComputeUnits-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-CPUUtil-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-FailedRequests-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-ResponseStatus-Alert.json')
    loadTextContent('../../../services/Network/applicationGateways/Deploy-AGW-UnhealthyHostCount-Alert.json')
    loadTextContent('../../../services/Web/serverFarms/Deploy-WSF-CPUPercentage-Alert.json')
    loadTextContent('../../../services/Web/serverFarms/Deploy-WSF-DiskQueueLength-Alert.json')
    loadTextContent('../../../services/Web/serverFarms/Deploy-WSF-HttpQueueLength-Alert.json')
    loadTextContent('../../../services/Web/serverFarms/Deploy-WSF-MemoryPercentage-Alert.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-appcpupercent_05591510-5fe2-454a-96d8-bbda8201c6a4.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-appmemorypercent_c5c95fe9-a4b4-4afa-a07a-a0d18804d416.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-blockedbyfirewall_2cda2f3a-8657-431a-a50f-56835aea9a81.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-connectionfailed_7157dc17-9d5a-4835-a122-1d0d904d61ff.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-connectionfailedusererror_d528ffcb-3a99-4356-96d1-981499139ffb.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-connectionsuccessful_460b6b29-a602-4409-b748-6b47b232a984.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-cpuused_3ddd3f95-989c-4777-b6b8-728439aae1df.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-deadlock_ce44fc81-3610-4165-a107-9dd4b8ab3972.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-dtulimit_50124594-a291-4183-a8e3-195f5e6f5204.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-dtuused_d26f4c8b-0461-4c57-b230-cbd1a5424db1.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-dwuconsumptionpercent_70f88865-7a8b-4e03-9252-a9369df503ef.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-memoryusagepercent_f5c13b49-8528-457d-9d7d-083b8433bf96.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-sessionscount_07eeae07-010e-47ca-ad90-fa7adb5a6c52.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-sqlinstancecpupercent_1a8132b9-fbd2-4ac5-9e08-96358e16b7f7.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-sqlinstancememorypercent_f44a3cb0-6e99-4a5e-a691-c5d7d5bf7e64.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-storage_86922a27-41bb-4834-bc54-0b602b275597.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/databases-tempdbdatasize_0fe27fd1-e4f7-48c1-bbd2-a6953755d5e8.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-allocateddatastorage_3743016a-a056-43fe-b53a-36dd9a17626d.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-allocateddatastoragepercent_7e9d0710-3243-4cf2-8b73-6be1539b8545.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-cpupercent_805c4ae5-a852-43bd-ad1c-0f7f381d8f32.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-dtuconsumptionpercent_5d9075b5-3c19-4cf6-9c2e-50ba4c175691.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-eDTUused_16a64053-1905-4d8e-8198-810584cad108.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-logwritepercent_47cd814e-1991-437e-8feb-e589a250d2a3.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-physicaldatareadpercent_92efc2ea-b6ed-41aa-921c-6d40e7b58c27.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-sessionspercent_6b2e0ce9-d1b8-4061-b3ce-c39f9c5c1763.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-sqlserverprocesscorepercent_73ec4301-872a-4bea-928e-420255aae8cb.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-sqlserverprocessmemorypercent_fa056aaf-57c4-4abe-9bc5-23ba413a1f5b.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-storagepercent_88f3cbc0-bcfb-482f-b6f4-709a335afcad.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-tempdblogusedpercent_af66de51-079c-4d34-af92-f52f887642dc.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-workerspercent_1b37038e-6e5c-4463-97d4-8a632251d70e.json')
    loadTextContent('../../../services/Sql/servers/templates/policy/elasticpools-xtpstoragepercent_db517009-30ad-4cbc-b282-7f212052c3b4.json')
    // loadTextContent('../../../services/Cdn/profiles/Deploy-CDNP-OriginHealthPercentage-Alert.json')
    // loadTextContent('../../../services/Cdn/profiles/Deploy-CDNP-OriginLatency-Alert.json')
    // loadTextContent('../../../services/Cdn/profiles/Deploy-CDNP-Percentage4XX-Alert.json')
    // loadTextContent('../../../services/Cdn/profiles/Deploy-CDNP-Percentage5XX-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-AvailableMemory-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-DataDiskReadLatency-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-DataDiskSpace-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-DataDiskWriteLatency-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-HeartBeat-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-HeartBeatAlertRG.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-NetworkIn-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-NetworkOut-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-OSDiskReadLatency-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-OSDiskSpace-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-OSDiskWriteLatency-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-PercentCPU-Alert.json')
    // loadTextContent('../../../services/Compute/virtualMachines/Deploy-VM-PercentMemory-Alert.json')
    // loadTextContent('../../../services/Network/trafficmanagerprofiles/Deploy-TM-EndpointHealth-Alert.json')
    // loadTextContent('../../../services/Network/frontdoors/Deploy-FD-BackendHealth-Alert.json')
    // loadTextContent('../../../services/Network/frontdoors/Deploy-FD-BackendRequestLatency-Alert.json')

    // Used in both Identity and LandingZone policy definitions
    // loadTextContent('../../../services/KeyVault/vaults/Deploy-KV-Availability-Alert.json')
    // loadTextContent('../../../services/KeyVault/vaults/Deploy-KV-Capacity-Alert.json')
    // loadTextContent('../../../services/KeyVault/vaults/Deploy-KV-Latency-Alert.json')
    // loadTextContent('../../../services/KeyVault/vaults/Deploy-KV-Requests-Alert.json')
    // loadTextContent('../../../services/KeyVault/vaults/Deploy-ActivityLog-KeyVault-Del.json')

    // Used in both LandingZone and Connectivity policy definitions
    /*
      loadTextContent('../../../services/Network/loadBalancers/Deploy-LB-DatapathAvailability-Alert.json')
      loadTextContent('../../../services/Network/loadBalancers/Deploy-LB-GlobalBackendAvailability-Alert.json')
      loadTextContent('../../../services/Network/loadBalancers/Deploy-LB-HealthProbeStatus-Alert.json')
      loadTextContent('../../../services/Network/loadBalancers/Deploy-LB-UsedSNATPorts-Alert.json')
      loadTextContent('../../../services/Network/publicIPAddresses/Deploy-PIP-BytesInDDOSAttack-Alert.json')
      loadTextContent('../../../services/Network/publicIPAddresses/Deploy-PIP-DDOSAttack-Alert.json')
      loadTextContent('../../../services/Network/publicIPAddresses/Deploy-PIP-PacketsInDDOS-Alert.json')
      loadTextContent('../../../services/Network/publicIPAddresses/Deploy-PIP-VIPAvailability-Alert.json')
      loadTextContent('../../../services/Network/virtualNetworks/Deploy-VNET-DDOSAttack-Alert.json')
    */

    // Used in Management policy definitions only
    // loadTextContent('../../../services/Automation/automationAccounts/Deploy-AA-TotalJob-Alert.json')
    // loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-ActivityLog-LAWorkspace-Del.json')
    // loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-ActivityLog-LAWorkspace-KeyRegen.json')
    // loadTextContent('../../../services/OperationalInsights/workspaces/Deploy-LAWorkspace-DailyCapLimitReached-Alert.json')

    // Used in both LandingZone and Management policy definitions
    // loadTextContent('../../../services/storage/storageAccounts/Deploy-SA-Availability-Alert.json')
    // loadTextContent('../../../services/storage/storageAccounts/Deploy-ActivityLog-SA-Delete-Alert.json')
    // loadTextContent('../../../services/RecoveryServices/vaults/Modify-RSV-BackupHealth-Alert.json')

    // Used in Notification-Assets policy definitions only
    // loadTextContent('../../../services/AlertsManagement/actionRules/Deploy-AlertProcessingRule-Deploy.json')
    // loadTextContent('../../../services/AlertsManagement/actionRules/Deploy-AlertProcessingRule-Suppression.json')

    // Used in ServiceHealth policy definitions only
    loadTextContent('../../../services/Resources/subscriptions/Deploy-ServiceHealth-ActionGroups.json')
    loadTextContent('../../../services/Resources/subscriptions/Deploy-ActivityLog-ResourceHealth-UnHealthly-Alert.json')
    loadTextContent('../../../services/Resources/subscriptions/Deploy-ActivityLog-ServiceHealth-Health.json')
    loadTextContent('../../../services/Resources/subscriptions/Deploy-ActivityLog-ServiceHealth-Incident.json')
    loadTextContent('../../../services/Resources/subscriptions/Deploy-ActivityLog-ServiceHealth-Maintenance.json')
    loadTextContent('../../../services/Resources/subscriptions/Deploy-ActivityLog-ServiceHealth-Security.json')
  ]
  AzureCloud: []
  AzureChinaCloud: []
  AzureUSGovernment: []
}

And then blocking off initiatives that we don't need:
var loadPolicySetDefinitions = {
  All: [
    // string(loadJsonContent('../policySetDefinitions/Deploy-Connectivity-Alerts.json'))
    // string(loadJsonContent('../policySetDefinitions/Deploy-Identity-Alerts.json'))
    string(loadJsonContent('../policySetDefinitions/Deploy-LandingZone-Alerts.json'))
    // string(loadJsonContent('../policySetDefinitions/Deploy-Management-Alerts.json'))
    string(loadJsonContent('../policySetDefinitions/Deploy-ServiceHealth-Alerts.json'))
    // string(loadJsonContent('../policySetDefinitions/Deploy-Notification-Assets.json'))
  ]
  AzureCloud: []
  AzureChinaCloud: []
  AzureUSGovernment: []
}

However, this means the landing zone alerts initiative includes Key Vault and other alerts, so it won't deploy correctly, unless I edit the policyDefinitions. I did try this and uncomment some of the LZ definitions, however it seems it just wants more and more definitions when deploying (e.g. The policy set definition 'Alerting-LandingZone' request is invalid. The following policy definition could not be found: '/providers/Microsoft.Management/managementGroups/mg-huki-epac-dev-root/providers/Microsoft.Authorization/policyDefinitions/Deploy_activitylog_NSG_Delete'. (Code: PolicyDefinitionNotFound)).
Any thoughts would be appreciated.


Github Copilot not working - requires to sign-in to github (buttons don't work)

Copilot Chat Extension Version: v-0.22.2
VS Code Version: 1.95.2
OS Version: Win 11
Steps to Reproduce:

Open VSCode
Try to type something to trigger Copilot or ctrl + alt + i to open chat

Is showing me I need to log in, even though on github tab I am logged in...
If I try to click on the buttons or links to login, nothing happens
have this issue only on this repo (even though I am logged in with my personal account where I pay)... it was not working for couple of days... yesterday for a reason it was, and today not working again (don't know what changed).

I have the same problem

Do you still see this?

No, it solve for me now, thanks


new function returning nr bytes read from socket or -1 if none

#45 @mstanichenko @penberg please review

int fix_session_recv(fix_session *self, fix_message **msg, int flags)

int fix_session_recv(fix_session *self, fix_message **msg, int flags)

Agreed int fix_session_recv(fix_session *self, fix_message **msg, int flags) is better (can be interpreted as receiving array of messages though). Will do it this way and will try to not break the compatibility.

Regarding error codes - basically len = 0 is not an error it just indicated connection is closed. But there could be really OS level error as well. What's your view on reporting the following situations:

Nothing was read, just a message was parsed from already received buffers
Zero bytes received (connection closed)
OS level error (recv returns -1) with errno

What shall fix_session_recv return in three cases above?

fix_session_recv() possible errors are not just about OS. It could be a garbled message or potential libtrading internal problems. So, I believe fix_session_recv() should return the number of successfully decoded messages (0 or 1 in current setup) or -1 in case of any special situation (including closed connection). If one needs a real reason behind, he should address fix_session structure for details. We can implement some interface between a user and a session structure which will help to get fine grained information about the error (OS level error, connection is closed or library specific one). The same applies for fix_session_send().
As to compatibility, I personally do not see any problem if you break some. Library API has quite some room for improvement and missing functionality has to be filled eventually. Feel free to implement things which are convenient for your needs and make sense in general. I believe, we will have a chance to discuss details then.

@mstanichenko thanks, got it

@mstanichenko @penberg here you go, better?

Hi Denis, sorry for delay. I had a limited Internet access.
Perfect!
Changes look OK to me. Just a few observations:
a) There is a trailing whitespace lib/proto/fix_session.c:214
b) Is there a difference between 'res' and 'msg' here? Why do we call it differently?
int fix_session_send(struct fix_session *self, struct fix_message *msg, int flags);
int fix_session_recv(struct fix_session *self, struct fix_message **res, int flags);

c) We are not using fix_message_parse() return value right now (lib/proto/fix_session.c:217)
At some point in the future we probably need to adjust that.
@penberg, do you have any comments? Could you please merge these changes?

@mstanichenko I've renamed **res to **msg in .h file but left it as is .c as I need another variable called msg. thanks guys, I like your code review a lot ) no space character would left unnoticed!

@mstanichenko @divaykin I'm fine with the changes but I'd like to see them squashed in one commit to keep the history clean. You can force push to the Github remote branch and the pull request is automatically updated.

@penberg thanks, here you go

Pulled, thanks a lot!


chore: update bank-vaults deps

Overview

Fixes #(issue)
Notes for reviewer

Just noticed that testing dependencies are part of the package. Created an issue to address this in #131


Add ResNet50 to DeepImageFeaturizer

Adding support for ResNet50 model in DeepImageFeaturizer. It should be pretty trivial to add VGG16 and VGG19 after this (though I am running into heap space problems on my laptop).
To test:
$ build/sbt assembly
$ SPARK_HOME=/usr/local/lib/spark-2.1.1-bin-hadoop2.7 PYSPARK_PYTHON=python2 SCALA_VERSION=2.11.8 SPARK_VERSION=2.1.1  python/run-tests.sh python/tests/transformers/named_image_Resnet50_test.py

Codecov Report

Merging #57 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   82.82%   83.06%   +0.23%
==========================================
  Files          23       23
  Lines        1217     1234      +17
  Branches        5        5
==========================================
+ Hits         1008     1025      +17
  Misses        209      209

Impacted Files
Coverage Δ

python/sparkdl/transformers/named_image.py
93.51% <100%> (ø)
:arrow_up:

python/sparkdl/transformers/keras_applications.py
93.93% <100%> (+2.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f668d9...a8f4469. Read the comment docs.


wow error: Unknown unicode error

such traceback:
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/doge/core.py", line 465, in main
    shibe.setup()
  File "/usr/lib/python3.4/site-packages/doge/core.py", line 40, in setup
    doge = self.load_doge()
  File "/usr/lib/python3.4/site-packages/doge/core.py", line 153, in load_doge
    doge_lines = [l for l in f.readlines()]
  File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 29: ordinal not in range(128)

wow /usr/bin/locale:
[nemo@Jolla software]$ /usr/bin/locale
/usr/bin/locale: Cannot set LC_CTYPE to default locale: No such file or directory
/usr/bin/locale: Cannot set LC_MESSAGES to default locale: No such file or directory
/usr/bin/locale: Cannot set LC_ALL to default locale: No such file or directory
LANG=cs_CZ.UTF-8
LANGUAGE=
LC_CTYPE="cs_CZ.UTF-8"
LC_NUMERIC="cs_CZ.UTF-8"
LC_TIME="cs_CZ.UTF-8"
LC_COLLATE="cs_CZ.UTF-8"
LC_MONETARY="cs_CZ.UTF-8"
LC_MESSAGES="cs_CZ.UTF-8"
LC_PAPER="cs_CZ.UTF-8"
LC_NAME="cs_CZ.UTF-8"
LC_ADDRESS="cs_CZ.UTF-8"
LC_TELEPHONE="cs_CZ.UTF-8"
LC_MEASUREMENT="cs_CZ.UTF-8"
LC_IDENTIFICATION="cs_CZ.UTF-8"
LC_ALL=
``

BTW, this happened when I tried running doge 3.5 on my Jolla with Sailfish OS from a self-made package[0] based on the Fedora spec file.
[0] https://build.merproject.org/package/show/home:MartinK:sailfish/doge

I was just searching for the unicode decode error for an unrelated server install, but I thought I would mention that I have doge running on the latest Jolla Sailfish OS (<IP_ADDRESS> - Xperia X). Works great with FingerTerm & ToeTerm (landscape or small doge error + Python 3.7.2). This ancient bug could probably be closed.


web_voyager's add_conditional_edges lacks of conditional_edge_mapping

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
it seems that "graph_builder.add_conditional_edges("agent", select_tool)" missed one argument, and caused this error when putting in code (not notebook)
graph_builder.add_conditional_edges("agent", select_tool)
TypeError: Graph.add_conditional_edges() missing 1 required positional argument: 'conditional_edge_mapping'

original code is like following
graph_builder = StateGraph(AgentState)
graph_builder.add_node("agent", agent)
graph_builder.set_entry_point("agent")
graph_builder.add_node("update_scratchpad", update_scratchpad)
graph_builder.add_edge("update_scratchpad", "agent")
tools = {
"Click": click,
"Type": type_text,
"Scroll": scroll,
"Wait": wait,
"GoBack": go_back,
"Google": to_google,
}
for node_name, tool in tools.items():
graph_builder.add_node(
node_name,
# The lambda ensures the function's string output is mapped to the "observation"
# key in the AgentState
RunnableLambda(tool) | (lambda observation: {"observation": observation}),
)
# Always return to the agent (by means of the update-scratchpad node)
graph_builder.add_edge(node_name, "update_scratchpad")
def select_tool(state: AgentState):
# Any time the agent completes, this function
# is called to route the output to a tool or
# to the end user.
action = state["prediction"]["action"]
if action == "ANSWER":
return END
if action == "retry":
return "agent"
return action
graph_builder.add_conditional_edges("agent", select_tool) <----------- here
graph = graph_builder.compile()
Error Message and Stack Trace (if applicable)
TypeError: Graph.add_conditional_edges() missing 1 required positional argument: 'conditional_edge_mapping'
Description
it seems that "graph_builder.add_conditional_edges("agent", select_tool)" missed one argument, and caused this error when putting in code (not notebook)
graph_builder.add_conditional_edges("agent", select_tool)
TypeError: Graph.add_conditional_edges() missing 1 required positional argument: 'conditional_edge_mapping'
System Info
Package Information

langchain_core: 0.1.22
langchain: 0.1.6
langchain_community: 0.0.19
langsmith: 0.0.87
langchain_cli: 0.0.20
langchain_experimental: 0.0.50
langchain_google_genai: 0.0.8
langchain_google_vertexai: 0.0.5
langchain_openai: 0.0.5
langchainhub: 0.1.14
langgraph: 0.0.24
langserve: 0.0.37

@roboticsocialism , have you upgraded your local version of langgraph?

Going to close, as this is a version issue

Going to close, as this is a version issue

yes, thanks a lot!


[TorchServe Model] Connection refused

/kind bug
What steps did you take and what happened:
I've created an InferenceService from PyTorch model with torchserve-kfs runtime version 0.7.0 (see .yaml file below). Then I've made a request to the model with
    inference_request = {
        "name": "predict",
        "shape": [1, 64, 48],
        "datatype": "FP32",
        "data": im.tolist()
    }
    url = "http://<IP_ADDRESS>/v2/models/vit_cifar/infer"
    resp = requests.post(url, json=inference_request)

Inference Service responded with 500 error and kserve-controller logged a message:
[I 230504 07:27:59 TorchserveModel:76] PREDICTOR_HOST : <IP_ADDRESS>:8085
[E 230504 07:27:59 web:1798] Uncaught exception POST /v2/models/vit_cifar/infer (<IP_ADDRESS>)
    HTTPServerRequest(protocol='http', host='<IP_ADDRESS>', method='POST', uri='/v2/models/vit_cifar/infer', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/dist-packages/tornado/web.py", line 1713, in _execute
        result = await result
      File "/usr/local/lib/python3.8/dist-packages/kserve/handlers/predict.py", line 70, in post
        response = await model(body)
      File "/usr/local/lib/python3.8/dist-packages/kserve/model.py", line 86, in __call__
        response = (await self.predict(request)) if inspect.iscoroutinefunction(self.predict) \
      File "/home/model-server/kserve_wrapper/TorchserveModel.py", line 78, in predict
        response = await self._http_client.fetch(
    ConnectionRefusedError: [Errno 111] Connection refused
[E 230504 07:27:59 web:2271] 500 POST /v2/models/vit_cifar/infer (<IP_ADDRESS>) 55.08ms

What did you expect to happen:
TorchserveModel passes request to a handler that runs the model.
What's the InferenceService yaml:
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: pytorch-vit
  namespace: default
spec:
  predictor:
    serviceAccountName: sa
    model:
      modelFormat:
        name: pytorch
      protocolVersion: v2
      storageUri: "s3://bucket/vit/model-store"
      runtimeVersion: 0.7.0

Anything else you would like to add:
If it helps here is the config.properties file
inference_address=http://<IP_ADDRESS>:8085
management_address=http://<IP_ADDRESS>:8081
metrics_address=http://<IP_ADDRESS>:8082
grpc_inference_port=7070
grpc_management_port=7071
enable_metrics_api=true
metrics_format=prometheus
number_of_netty_threads=4
job_queue_size=10
enable_envvars_config=true
install_py_dep_per_model=true
model_store=/mnt/models/model-store
model_snapshot={"name": "startup.cfg", "modelCount": 1, "models": {"vit_cifar": {"1.0": {"defaultVersion": true, "marName": "vit_cifar.mar", "minWorkers": 1, "maxWorkers": 3, "batchSize": 1, "maxBatchDelay": 300, "responseTimeout": 420}}}}

Environment:

Istio Version:
Knative Version:
KServe Version: 0.10.0
Kubeflow version:
Cloud Environment:
Minikube version: v1.30.1
Kubernetes version: (use kubectl version): 1.17.2
OS (e.g. from /etc/os-release):

@andyi2it , sorry this is some wrong number. Here is version of
kubectl: v1.25.4
Kubernetes: v1.26.3

@MikhailKravets Can you try with the kserve 0.11.1 and torchserve 0.8.2. Kserve moved from tornado web server to uvicorn. There are many things fixed after torchserve 0.7.


Feature request: Add support for Opera browser

Currently there is no extension available for opera. Opera has almost same extension api as of chrome's. https://dev.opera.com/extensions/apis/ and support devtools extension api so please make extension for Opera. It's the only thing keeping me moving to opera, all other extension I use, has alternatives.

dup of #241


Fix stdProcess structure issue with ProcessEntry32

See this issue for quotation:
https://github.com/twinbasic/twinbasic/issues/1031#issuecomment-1196277353
Ultimately pcPriClassBase should be a Single not a Long type
Private Type PROCESSENTRY32
    dwSize As Long
    cntUsage As Long
    th32ProcessID As Long
    'pack1 As Long
    th32DefaultHeapID As LongPtr
    th32ModuleID As Long
    cntThreads As Long
    th32ParentProcessID As Long
    pcPriClassBase As Single         'Bugfix
    dwFlags As Long
    szExeFile As String * 260
    'pack2 As Long
End Type

I appear to have misunderstood what FAFALONE was indicating, it is correct that ClassName should be a long, not a single. Instead fafalone indicated the examples they'd found in VBA had padded pcPriClassBase with a long e.g.
  pcPriClassName as long
  padding as long
  ...

This likely came about because people know MAX_PATH is actually 256, however the MAX_PATH constant = 260. So an extra 4 bytes were added about the place.

While it doesn't error because a Single is a 4-byte data type, officially it's a Long,
typedef struct tagPROCESSENTRY32 {
  DWORD     dwSize;
  DWORD     cntUsage;
  DWORD     th32ProcessID;
  ULONG_PTR th32DefaultHeapID;
  DWORD     th32ModuleID;
  DWORD     cntThreads;
  DWORD     th32ParentProcessID;
  LONG      pcPriClassBase;
  DWORD     dwFlags;
  CHAR      szExeFile[MAX_PATH];
} PROCESSENTRY32;

and it will have one of the following values,
    NORMAL_PRIORITY_CLASS = &H20
    IDLE_PRIORITY_CLASS = &H40
    HIGH_PRIORITY_CLASS = &H80
    REALTIME_PRIORITY_CLASS = &H100
    BELOW_NORMAL_PRIORITY_CLASS = &H4000
    ABOVE_NORMAL_PRIORITY_CLASS = &H8000

never a decimal.

Thanks, I had initially used long as I usually go direct from the structs anyhow, but saw the issue in your vbforums post, so figured I might have got it wrong also 😅
Thanks for the increased information! 👍

No problem, I obviously got it wrong a few times too.
But yeah a Single will result in lots of trouble if you ever did anything with the data WIndows copies in thinking it's a Long. :)


LAB_10

English:
Image and diagrams components should be localized
Current Translation:
Image and diagrams components should be localized
Suggested Translation:
Image and diagrams components should be localized
Description:
Key Vault diagram is not translated

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

This is an image issue, I can't fix it.

This image in Web URL, can't fix.
https://user-images.githubusercontent.com/91347931/157532938-c724cc40-f64f-4d69-9e91-d75344c5e0a2.png


When selecting another colour, canvas is getting cleared.

When selecting a colour other than the already selected colour, the canvas is getting cleared. @BlackHeart786
Steps to reproduce:

Draw a rectangle on the canvas with a colour (e.g. red)
Now select another colour (e.g. green)
Watch all the shapes and strokes are disappeared.

Already fixedly @BlackHeart786


Erasure-coding library research

There is a need to research library for erasure encoding.
Something similar to the Rust one:
https://github.com/paritytech/erasure-coding/blob/main/src/subshard.rs
Ensure the library is aligned with GP Appendix H.
Test vectors from Gavin:
https://gist.github.com/gavofyork/4cde92327cd91eff3e2ab91d316cb83a
Test vectors in the official repo (PRed):
https://github.com/w3f/jamtestvectors/pull/4

After more research I think we should wrap and use this lib via FFI. Other reed solomon GF16 libraries seem to require the shard size to be a multiple of 64 bytes, this one doesn't.


Change from connectivity to connectivity_plus

Change the connectivity plugin to the brand new connectivity_plus.

Leave it to me


Add link with games

Update readme

I'm sure the developer doesn't condone piracy. Please, at least, create a disclaimer to "check your local laws" on downloading these games from [specified site].

Yeah this is illegal


Move away from Travis CI

I suggest to use GitHub CI.
@pipobscure you'll need to sign up here: https://github.com/features/actions (pick fsevents from the dropdown)

✅

Sounds like a plan. Are you doing the actual change-over?

@pipobscure yes, i'll delete travis-ci.yml and add github config file, once we'll receive beta access

I did the signup and I think we should have it now.

Done: https://github.com/fsevents/fsevents/actions


Add release process info to README

I was searching for this again like ten minutes: https://github.com/scala/sbt-scala-module/issues/16
The easiest would be to add a link to this info to README.md

https://github.com/scala/sbt-scala-module/issues/16


GRRLIB_ttf.c optimization

Removed duplicated code: GRRLIB_WidthTTF* and GRRLIB_PrintfTTF* now call a common subroutine.
Optimized memory allocation: allocated buffer is keept and reallocated only if space is not sufficient.
Changed return value type for GRRLIB_PrintfTTFW and GRRLIB_PrintfTTF: now they return the width of the printed text in pixel, so you can use this value to change the x coordinate of the next printf.

I like the idea of removing the duplicate code, but I don't like having a "global" memory buffer for the temporary UTF32 string. This may be a problem if using thread or it can also be problematic because the maximum string length used at any time during the run time will persist for ever.
My proposition for the memory allocation problem can be found here: https://github.com/GRRLIB/GRRLIB/compare/master...ttf#diff-ab2e4c805ce84fa97fd9c346a818b0c52cd60ab54f09b9b5bd0936557713889c
I have completely removed the need for mbstowcs and malloc. Of course this code is worst than before considering the DRY principle. But I wanted to know your opinion. If you like it, I can merge it and than you or I, can changed it to remove duplicate code.

Really you want add a double mbstowcs "in site" code?
Why does not adopt my solution replacing malloc() with alloca()?
Threads compatible, no global, no static allocation, no free needed.
`/**

Common code for GRRLIB_PrintfTTF() and GRRLIB_WidthTTF()
*/
static u32 _PrintfTTF(int x, int y, GRRLIB_ttfFont *myFont, const char *string, unsigned int fontSize,
const u32 color, bool noprint)
{
wchar_t *utf32;
if (myFont == NULL || string == NULL) {
return 0;
}
u32 penX = 0;
size_t length;
length = mbstowcs(NULL, string, 0);
if(length == (size_t) -1) {
return 0;
}
length++;
utf32 = alloca(length * sizeof(wchar_t));
if(mbstowcs(utf32, string, length) > 0) {
utf32[length-1] = L'\0';
penX = _PrintfTTFW(x, y, myFont, utf32, fontSize, color, noprint);
}
return penX;
}`


Public encoding functions?

Sometimes I have already e.g. nodes: Vec<Node> in the application state where Node is like
struct Node {
   url: String,
   requests: AtomicU64,
}

(When you are already working with a &Node, bumping the requests counter is just an atomic inc. It's much more efficient than get_or_create(...).inc().)
And I'd like to expose the requests counter of all nodes as a metric family. It might be possible with the collector API, but it would still require quite some boxing, cloning and iterator mapping.
Instead I'd like to encode the metrics myself, e.g.:
encode_descriptor(&mut buf, ...);
for n in &ctx.nodes {
    encode_counter_with_labels(&mut buf, [("node", &n.url)], n.requests.load(...));
}
encode_eof(&mut buf);

This will not require any extra allocation or cloning. By fusing the collecting and encoding phase, metrics can be encoded very efficiently.

@blckngm this will be possible with the new Collector trait. It would not require any boxing, i.e. you can encode your custom metrics into a MetricEncoder right away.
https://github.com/prometheus/client_rust/pull/149
Let me know if this would solve your use-case.

Thanks for considering this. I'll try it.

It's definitely a big improvement for my use case.
I have to a clone an Arc and define a wrapper struct to make my collector impl struct Debug and 'static, which wouldn't be necessary if e.g. Collector has more loose bounds or if DescriptorEncoder have a public constructor (then I'd probably still skip the collector).
But it's pretty good so if it's released I'll probably use it instead of my current hacky solution where I'm creating a new registry and register metrics on each scraping.

I have to a clone an Arc and define a wrapper struct to make my collector impl struct Debug and 'static

I don't see how we can implement Collector without 'static, given that, when registering, we need ownership in order to store it in Registry.
As for Debug, I would consider implementing Debug for all externally used structs a best practice. I am assuming this is not too painful for you.
As for Arc, given that you want to access the Node struct in order to increase the counter and given that Registry needs access in order to encode the metrics, I don't see a way to do without it.

But it's pretty good so if it's released I'll probably use it instead of my current hacky solution where I'm creating a new registry and register metrics on each scraping.

Glad it can improve your use-case.


Refactoring RedHat inventory refresher and parser

This is a preparation for using the new ovirt-engine-sdk
for providers that support v4 of the api, while using the
old Ovirt gem for those that do not.
Most of the changes are just moving some files around.

@masayag plesae review

@miq-bot assign @durandom

@miq-bot assign @durandom
The rubocops are all from the old files being moved.

@blomquisg can this be merged?

@agrare maybe you can merge?

re-tagging since miq-bot is back to work
@miq-bot assign @blomquisg
@miq-bot assign label euwe/no
@blomquisg see https://github.com/ManageIQ/manageiq/pull/12915#pullrequestreview-11414893

@durandom can this please be merged?


SSE in background app

I have a question how the SSE work when the app is background ?
I am trying getting messages from the server when the app is in background but it doesn't work properly, anyone knows if this is possible or what other technology should a use.

You can try Push Notifications they works fine in background.

It depends on what you want to achieve. Due to the significant limitations on background app activity on iOS, an app that operates in this way will be quickly terminated by the system. With Android, the situation is slightly better, but the app will still be put to sleep after a while and stop functioning in the background. As mentioned by @karaushu above, I recommend configuring Push Notifications and handling user action.


Uninitialized constant RSpec::Core::CommandLine

RSpec::Core::CommandLine was merged into RSpec::Core::Runner in 3.0.0.rc1.  I poked around and added some code that fixed the uninitialized constant error.
Please note: I was unable run the test suite (even before modifying any code) because I kept getting this error:
forker.rb:29:in 'write': not opened for writing (IOError).  I tried but now I need to move on to other things.  Hope this helps!

@timcharper Perhaps spork-rails could benefit from a release including this changeset.


Spinning wheel on connections page (admin panel)

webui log: GET /openai/urls HTTP/1.1 404 Not Found
Aphrodite engine log: GET /v1/urls HTTP/1.1 404 Not Found
The page is stuck with a spinning wheel so I cannot switch connections or edit any setting on the connections page.

fixed, forgot to run npm run build after git pull update


run prettier command against all files

Description
cherry pick this commit from main branch -<PHONE_NUMBER>103ac87fc7c037015784b6fe193b45
Issues Resolved
N/A
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #446 (9a20518) into featureAnywhere (553cbdd) will increase coverage by 0.01%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@                 Coverage Diff                 @@
##           featureAnywhere     #446      +/-   ##
===================================================
+ Coverage            51.97%   51.98%   +0.01%
===================================================
  Files                  149      149
  Lines                 5031     5030       -1
  Branches               968      967       -1
===================================================
  Hits                  2615     2615
+ Misses                2157     2156       -1
  Partials               259      259

see 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Error compiling SCSS in linked Angular-CLI

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Ubuntu 16.10
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

master at 0664beb76da87cb0c8b39c0029dffb3959faadcc using npm link
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

Start angular-cli in serve mode ng serve --env local. It all builds normally.
Modify a scss file linked to a component and save: build fails.
Remove reference to the scss file from the component and save: builds fine.
Add the reference to the scss file again: builds.
Go to step 2

The log given by the failure.

Normally this include a stack trace and some more information.

ERROR in ./src/app/pro-solution/pro-solution.component.scss
Module build failed: Error
    at WebpackCompilerHost.populateWebpackResolver (/.../angular-cli/packages/@ngtools/webpack/src/compiler_host.ts:218:51)
    at /.../angular-cli/packages/@ngtools/webpack/src/plugin.ts:326:37
    at process._tickCallback (internal/process/next_tick.js:103:7)
 @ ./src/app/some.component.ts 24:21-61
 @ ./src/app/some.module.ts
 @ ./src async
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS> @ ./src/main.ts
 @ multi webpack-dev-server/client?http://localhost:4200/ ./src/main.ts

Mention any other details that might be useful.
This was probably caused by #4188 which modified the populateWebpackResolver method in<EMAIL_ADDRESS>but I didn't dig much further than that.

Thanks! We'll be in touch soon.

I just tried this while testing something else and it seemed fine. Was able to add in @import '~bootstrap/scss/bootstrap' and remove it with no such errors.
Can you test again with latest master and deleted/reinstalled node_modules?

@filipesilva will try again tomorrow morning with the latest master and see if the error persists.

I am having the same problem.  All I did was removed and re-written it and hit Ctrl-S, and suddenly webpack couldn't compile it anymore.
webpack: Compiling...
Hash: ce5db0545f15cbbde03f
Time: 2809ms
chunk    {0} main.bundle.js, main.bundle.map (main) 4.1 kB {2} [initial] [rendered]
chunk    {1} styles.bundle.js, styles.bundle.map (styles) 9.96 kB {3} [initial]
chunk    {2} vendor.bundle.js, vendor.bundle.map (vendor) 2.85 MB [initial] [rendered]
chunk    {3} inline.bundle.js, inline.bundle.map (inline) 0 bytes [entry]

ERROR in ./src/app/app.component.ts
Module build failed: Error
    at WebpackCompilerHost.populateWebpackResolver (D:\MyApps\angular-apps\angular-demo\node_modules\@ngtools\webpack\src\compiler_host.js:218:51)
    at D:\MyApps\angular-apps\angular-demo\node_modules\@ngtools\webpack\src\plugin.js:352:33
    at tryCatch (D:\MyApps\angular-apps\angular-demo\node_modules\es6-promise\dist\es6-promise.js:410:12)
    at invokeCallback (D:\MyApps\angular-apps\angular-demo\node_modules\es6-promise\dist\es6-promise.js:425:13)
    at publish (D:\MyApps\angular-apps\angular-demo\node_modules\es6-promise\dist\es6-promise.js:393:7)
    at flush (D:\MyApps\angular-apps\angular-demo\node_modules\es6-promise\dist\es6-promise.js:121:5)
    at doNTCallback0 (node.js:407:9)
    at process._tickCallback (node.js:336:13)
 @ ./src/app/app.module.ts 14:0-47
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://localhost:4200/ ./src/main.ts
webpack: Failed to compile.

👍

I'm having a similar error on a project just started with the angular-cli.
If I trigger a build from the app.component.html, I get the following error. If I trigger a build from any other file the bundling is successful.
NG version
➜  botstats git:(master) ✗ ng --version

                             _                           _  _
  __ _  _ __    __ _  _   _ | |  __ _  _ __         ___ | |(_)
 / _` || '_ \  / _` || | | || | / _` || '__|_____  / __|| || |
| (_| || | | || (_| || |_| || || (_| || |  |_____|| (__ | || |
 \__,_||_| |_| \__, | \__,_||_| \__,_||_|          \___||_||_|
               |___/
angular-cli: 1.0.0-beta.26
node: 4.4.7
os: darwin x64
@angular/common: 2.4.5
@angular/compiler: 2.4.5
@angular/core: 2.4.5
@angular/forms: 2.4.5
@angular/http: 2.4.5
@angular/platform-browser: 2.4.5
@angular/platform-browser-dynamic: 2.4.5
@angular/router: 3.4.5
@angular/compiler-cli: 2.4.5

Error
ERROR in ./src/app/app.component.html
Module build failed: Error
    at WebpackCompilerHost.populateWebpackResolver (/Users/antoniwan/Sites/m8/botstats/node_modules/@ngtools/webpack/src/compiler_host.js:218:51)
    at /Users/antoniwan/Sites/m8/botstats/node_modules/@ngtools/webpack/src/plugin.js:352:33
    at tryCatch (/Users/antoniwan/Sites/m8/botstats/node_modules/es6-promise/dist/es6-promise.js:410:12)
    at invokeCallback (/Users/antoniwan/Sites/m8/botstats/node_modules/es6-promise/dist/es6-promise.js:425:13)
    at publish (/Users/antoniwan/Sites/m8/botstats/node_modules/es6-promise/dist/es6-promise.js:393:7)
    at flush (/Users/antoniwan/Sites/m8/botstats/node_modules/es6-promise/dist/es6-promise.js:121:5)
    at nextTickCallbackWith0Args (node.js:420:9)
    at process._tickCallback (node.js:349:13)
 @ ./src/app/app.component.ts 18:22-53
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://localhost:4200/ ./src/main.ts
webpack: Failed to compile.

Contents of app.component.html

hi

Was getting the same error with beta 26. Downgraded to beta 25 and was getting an error that ../models/config was not found so, downgraded to beta 24 and everything works as expected.

Ran into the same bug, trashed my node modules and yarn.lock and reinstalled and now its gone.

I delete the files of type yarm.lock in the project and I work without problems.

I delete the files of type yarm.lock in the project and I work without problems.

Seems like it was a dependency problem at some point, and it's gone now.


about updater the AnnotatedAdapter

Hello, the developer of the library, can this library be updated to the latest version?

Hello,
Im sorry, but I dont maintain this peoject anymore. Feel free to fork it.
CJEEP<EMAIL_ADDRESS>schrieb am Fr., 19. Apr. 2019, 04:11:

Hello, the developer of the library, can this library be updated to the
latest version?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sockeqwe/AnnotatedAdapter/issues/24, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAEOPLRVEFRWP6ANGCMDFETPRES5JANCNFSM4HHBPO5Q
.

Ok, thanks very much, this library is very simple, I like it very much, take the liberty to ask, how do you write the recycleView adapter now, I want to know it.


Openssl on windows

Hi,
I'm trying to use openssl in my project on windows.
When I launch my application I have the following error:
OPENSSL_Uplink(00007FF8C8EAE000,08): no OPENSSL_Applink
I installed openssl and I copied the dlls in c:\Windows\System32
do you know how I can solve this issue?
Thanks

ARCH ?

x64,
I included <openssl/applink.c> (.c and not .h) in my project.
I compiled without vspkg openssl and I don't have this problem.
But I think that with this include is ok.
Thanks


Fix handshake for echo test

In  case where multiple sync packet are send from host If first sync packet is missed by device and its still in buffer.  when sync packet is received by device, it will ask for echo_count.
As we have more then one sync packet the subsequent sync packet will be considered as echo_count, and will be parsed wrong.

/morph test

Result: SUCCESS
Build number : 60
Build artifacts/logs :http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8/60

/morph test

Result: SUCCESS
Build number : 61
Build artifacts/logs :http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8/61

/morph test

Build : SUCCESS
Build number : 1
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8/

Result: SUCCESS
Build number : 355
Build artifacts/logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8/355

Test : SUCCESS
Build number : 356
Build artifacts/logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8/356

/morph build

/morph test

Build : SUCCESS
Build number : 2
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8/


Do necessary changes on Frontend Components for Timeline Feature

@SWE574-Fall2023-Group1/frontend
You should do the necessary changes in below component to make location info clickable.
StoryDetails.js
You should do the necessary changes in below component to diferentiate different search type to show results as timeline.

We can add a tickbox to select show results as timeline. But in this type user still can fill other fields but they will not effect the search by location feature.
Make a new search page that can only allow selection for location so that it shows results in timeline.
Similar to second option we can make a button so that it only changes the search form. So that search page form part changes but in the same component. So we do not need to create a new component for only search selection. (@ckertam suggests that for clarity on user interface)

StorySearch.js
Also, whether the choices we should make a new component for timeline results.
We can work on some mock ups so that we can see which search type will work better.

We selecteed third option. And #46 is related with this issue now.
@oguzsenna developing it Timeline Frontend Branch


core: Add clang-tidy

This adds a nice clang-tidy config. Partially stolen from @outfoxxed.
Also fixes a lot of style issues with old MRd code.  These might be up to either ignoring or fixing.
Probably should be done gradually, a lot of work all at once.

some "can be made const" stuff isn't correct I believe, so we might nuke that.


Add TO Go monitoring route prepared statements

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/60/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/62/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/100/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/64/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/62/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/102/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/63/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/65/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/103/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/140/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/101/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-whatchanged/6/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/235/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/193/

Closing this, as I did performance testing and am not seeing a significant speed improvement. Which surprises me, but I don't have time to investigate further.


Update title for single views

Fixes #84138

@sandy081 I think this change is safe, and it works, but since you last touched the title here I wanted to get your opinion on the change before merging it.

LGTM

Thanks for taking a look!


[IDEA] Introduce consistent formatting

Is your feature request related to a problem? Please describe.
Code style is inconsistent across the code base. This drastically reduces the readability and, therefore, maintainability.
Describe the solution you'd like
Lint with Prettifier.
Describe alternatives you've considered
We can also use ESLint or any other solution. Either way I am eager to work on this.

This sounds like a great idea- I'm going to look into doing this using our CI/CD pipeline so that it's all automated.


Mobile context: offline events not being recorded as such

Hey @jbeemster!
We've just implemented 0.6.1 and noticed an odd behaviour with offline events. I switched to airplane mode on the phone, then generated some events; when connection was resumed, networkType was passed as wifi rather then offline or null as I would expect.
Is this the intended behaviour?

Hey @bernardosrulzon!
The mobile and geolocation contexts have always been cached when the Tracker gets created.  The change with this release however is that the Tracker is a singleton and these contexts no longer get refreshed.
There are tickets to address this in 0.7.0 to put them both on configurable timers to ensure they get refreshed at intervals.  https://github.com/snowplow/snowplow-android-tracker/issues/220
On thinking about this though really we just need to re-get any information that could have changed and cache the rest - I was a bit too greedy caching everything!
Will see what I can do about getting a patch out for this.

@jbeemster Ah, that would be awesome! I hadn't noticed that geolocation was also cached - this will be cool to see how users interact with the app while they're on the go!

@jbeemster Thanks!!! Does this also solve the issue with geolocation you mentioned?

Ah, nevermind! Just seen your post on discourse