[release-1.6] use external name when remote pilot addr is hostname

Manual cherrypick required.
#24219 failed to apply on top of branch "release-1.6":
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/endpoints.yaml
M	operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/services.yaml
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/services.yaml
Auto-merging operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/endpoints.yaml
CONFLICT (content): Merge conflict in operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/endpoints.yaml
Patch failed at 0001 use external name when remote pilot addr is hostname

Manually cherrypicked in https://github.com/istio/istio/pull/24273


CLI scan exit code 1

I may have missed it somewhere but I do not see an easy way to exit with a code 1 when a secret is detected using scan. Is there a CLI flag or another method (even if it is hacky) to force this?
I am attempting to integrate detect-secrets into a CI/CD pipeline that has source coming in from CodeCommit and want it to exit with a code 1 to fail my build so the pipeline doesn't progress.
EDIT: To clarify, when I say hacky, I mean less hacky than running this Python script in CI:
import json

try:
    with open('secret-results.json') as json_file:
        data = json.load(json_file)
        if str(data['results']) != '{}':
            exit(1)
        else:
            pass
except Exception as e:
    print(e)

Have you tried using detect-secrets-hook? Not sure your current invocation, but it certainly returns appropriate error codes.

Hey @domanchi sorry for the delay, was up late burning oil on this.
My source code repo is AWS CodeCommit, it doesn't support pre-commit hooks, at least not yet.
I am using detect-secrets in CI by running detect-secrets scan . --all-files > secret-results.json in CI, and using that above script to force fail the build if there is any detection at all. I am fine with continuing it that way, that small .py script doesn't bloat my source too much, it would be ideal if there was a way to force an exit 1 on scan finding anything via a flag or by default though.

You don't necessarily need to use the pre-commit framework, in order to use the hook. For example, does this work for you?
detect-secrets-hook --use-all-plugins $(git ls-files) 2> /dev/null

I am not against a PR for this, I can't think of a case wherein it'd be unwanted to return a exit code of 1 for the non-pre-commit console script.

Closing as "Won't Fix" due to inactivity from OP. Will add a distinction in the README between the different tools detect-secrets offers to help with different use cases.


Filter selectable attributes in AttributeCombo by a filter function

Title says it all.

Should fix https://github.com/terrestris/geostyler/issues/135


verbose command command does not report LuckPerms' own permission checks

Description

Running a LuckPerms command through the verbose command command does not report any permission checks for LP.
Reproduction steps

Run /lp verbose command <whomst'd've> lp info
Observe

Expected behaviour

It should appear on my screen/in console report checks for luckperms. permissions.
Environment details

Server type/version: Paper running version 1.16.4 build 288
LuckPerms version: v5.2.40

https://gist.github.com/Fefo6644/05b688865f856c6c7dc4e99e6c256eda
Any other relevant details

Nothing else, no

This is a side effect of the fact that /lp verbose command does not support commands which execute async (therefore including LP itself).
There's no easy way to fix this unfortunately.

If it can't be fixed, then a message warning the user that it won't work is probably a good idea.


Renaming Nuget.org feed key name to Nuget.

fixes https://github.com/aspnet/Universe/issues/174

:shipit:

This is merged. https://github.com/aspnet/Mvc/commit/4e9e33fc07044c768f8c82a2ed88888a206af953


Add additional changelog entry to mgmt-core

In an effort to prevent the core build from melting.

This comment will be deleted to check visibility of deleted comments by different users.


Add checks for macOS version

This PR adds checks to the tasks that use account and signin subcommands, for the ones are no longer supported by mas on the recent versions of macOS

https://github.com/mas-cli/mas/issues/164
https://github.com/mas-cli/mas/issues/417
https://github.com/mas-cli/mas#-known-issues

Thank you!


START Internet Browser

START Internet Browser - https://github.com/WhichBrowser/Parser-PHP/issues/190

Coverage remained the same at 100.0% when pulling 99be31ceaa80628881cb27fe0a4922af09a24504 on ayumi-cloud:START-Internet into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.

@NielsLeenheer Please can you merge this pr.


Fix uint32 overflow in fill_empty_gamma_table on Icelake platform

Because of the larger gamma table on Icelake platforms, there is a 32 bit overflow leading to the issue https://github.com/swaywm/sway/issues/4826
Closes https://github.com/swaywm/sway/issues/4826

Hi, not sure if it is immensely relevant, but perhaps the macro for integer constant expression UINT64_C(0xffff) from stdint.h is better style/suited than the cast (uint64_t)0xffff.

Would would that macro be better than a cast?


April 2024 CPU - JDK21 Triage

Release Summary Report for release-openjdk21-pipeline
Warning: The release summary report is not yet complete. Currently, it only contains partial results.
Report generated at: Wed, 17 Apr 2024 12:19:30 GMT
TRSS Build and TRSS Grid View
Jenkins Build URL https://ci.adoptium.net/job/build-scripts/job/release-openjdk21-pipeline/32/
Started by upstream project "build-scripts/utils/releaseTrigger_jdk21u" build number 2460 at 4/17/2024, 2:42:20 AM

✔ results in these Tables means the activity has successfully completed.
⏳ results means that we are actively working on closing off the runs needed for this version, platform, binaryType.
⛔ means there is no build planned for that version/platform combination.
⏸ means activity not yet started.

Platform
Status
Results

x86-64_mac
⏸
comment

x86-64_linux
⏸
comment

x86-64_windows
⏳
comment

aarch64_linux
⏳
comment

aarch64_mac
✔
comment

x86-64_alpine-linux
⏸
comment

ppc64le_linux
⏳
comment

s390x_linux
⏸
comment

ppc64_aix
✔
all pass

aarch64_alpine-Linux
⏳
comment

aarch64_mac
Test_openjdk21_hs_extended.openjdk_aarch64_mac ⚠ UNSTABLE ⚠
Test_openjdk21_hs_extended.openjdk_aarch64_mac_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode)

Test_openjdk21_hs_extended.openjdk_aarch64_mac_testList_0 ⚠ UNSTABLE ⚠
jdk_nio_0 => deep history 15/17 passed | possible issues
jdk_net_0 => deep history 14/15 passed | possible issues
Test_openjdk21_hs_extended.openjdk_aarch64_mac_testList_1 ⚠ UNSTABLE ⚠
jdk_jfr_1 => deep history 5/15 passed | possible issues

aarch64_alpine-Linux

aarch64_linux

ppc64le_linux

x86-64_windows
Test_openjdk21_hs_extended.openjdk_x86-64_windows ⚠ UNSTABLE ⚠
Test_openjdk21_hs_extended.openjdk_x86-64_windows_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)

Test_openjdk21_hs_extended.openjdk_x86-64_windows_testList_0 ⚠ UNSTABLE ⚠
jdk_tools_0 => deep history 0/10 passed | possible issues
jdk_tools_1 => deep history 0/11 passed | possible issues
Test_openjdk21_hs_extended.openjdk_x86-64_windows_testList_1 ⚠ UNSTABLE ⚠
jdk_security3_1 => deep history 8/11 passed | possible issues
jdk_instrument_1 => deep history 16/17 passed | possible issues
jdk_imageio_0 => deep history 16/17 passed | possible issues

x86-64_linux
Test_openjdk21_hs_extended.openjdk_x86-64_linux ⚠ UNSTABLE ⚠
Test_openjdk21_hs_extended.openjdk_x86-64_linux_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)

Test_openjdk21_hs_extended.openjdk_x86-64_linux_testList_0 ⚠ UNSTABLE ⚠
jdk_build_0 => deep history 13/15 passed | possible issues
Test_openjdk21_hs_extended.openjdk_x86-64_linux_testList_1 ⚠ UNSTABLE ⚠
jdk_management_0 => deep history 9/10 passed | possible issues
jdk_management_1 => deep history 9/10 passed | possible issues
jdk_jfr_1 => deep history 5/10 passed | possible issues
Test_openjdk21_hs_extended.openjdk_x86-64_linux_testList_2 ⚠ UNSTABLE ⚠
jdk_build_1 => deep history 4/6 passed | possible issues

x86-64_mac
Test_openjdk21_hs_extended.openjdk_x86-64_mac ⚠ UNSTABLE ⚠
Test_openjdk21_hs_extended.openjdk_x86-64_mac_rerun ✅ SUCCESS ✅
Rerun all
java -version

x86-64_alpine-linux
https://ci.adoptium.net/view/Test_grinder/job/AQA_Test_Pipeline/235/

riscv64_linux
Test_openjdk21_hs_extended.openjdk_riscv64_linux ⚠ UNSTABLE ⚠
Test_openjdk21_hs_extended.openjdk_riscv64_linux_rerun ✅ SUCCESS ✅
Rerun all
java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)

Test_openjdk21_hs_extended.openjdk_riscv64_linux_testList_2 ⚠ UNSTABLE ⚠
jdk_jmx_0 => deep history 1/2 passed | possible issues
Test_openjdk21_hs_sanity.openjdk_riscv64_linux ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)

jdk_lang_0 => deep history 3/7 passed | possible issues
Test_openjdk21_hs_sanity.openjdk_riscv64_linux_rerun ⚠ UNSTABLE ⚠
Rerun failed
java -version
openjdk version "21.0.3" 2024-04-16 LTS
OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)


feat(datetime picker): hide time inputs

Closes #1235
Summary

Added new "hasTimeInput" prop to show/hide time input fields in relative and absolute range selection boxes.

Change List (commits, features, bugs, etc)

https://github.com/IBM/carbon-addons-iot-react/commit/54a38b1d2a40b3f6858ddbe4bb20eb1c2496281d

Acceptance Test (how to verify the PR)

Tested the fix with Predict Asset Timeline widget which uses DateTime Picker component.

Could you please update the default DateTimePicker story with a knob for this new prop so we can test it functionally in the storybook?

Done

:tada: This PR is included in version 2.83.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Set utf-8 encoding in the MIMEText constructor

Description
Pass the e-mail encoding into the MIMEText constructor rather than
Motivation and Context
If this is not set during the constructor, an exception is thrown in Python 2 when the e-mail body contains unicode.
Have you tested this? If so, how?
Added a unit test, deployed to production but it'll take a while before I see any unicode e-mails.

This is now tested in production, and I'm getting e-mails with unicode in them. Turns out R scripts use unicode single quotes around package names in error messages.

@daveFNbuck Feeling good about this? Ready to merge?

Yes, it was ready.

Oh, forgot to say. Thanks for this PR @daveFNbuck  :)


Improve OSSA instructions handling in EscapeAnalysis

copy_value/destroy_value/begin_borrow were not handled in EscapeAnalysis::analyzeInstruction.
As a result EscapeState of the values were set to Global leading to very conservative results
for queries like CGNode::escapes.

Performance (x86_64): -O

Improvement
OLD
NEW
DELTA
RATIO

ObjectiveCBridgeStubFromNSDate
7140
6370
-10.8%
1.12x (?)

StringBuilderLong
1320
1210
-8.3%
1.09x (?)

Code size: -O
Performance (x86_64): -Osize

Regression
OLD
NEW
DELTA
RATIO

ArrayAppendGenericStructs
1330
2150
+61.7%
0.62x (?)

ObjectiveCBridgeFromNSString
1180
1285
+8.9%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

FlattenListLoop
2556
1634
-36.1%
1.56x (?)

FlattenListFlatMap
6822
5197
-23.8%
1.31x (?)

Code size: -Osize
Performance (x86_64): -Onone
Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@swift-ci Please Test Source Compatibility


Cost details: Add month over month change

This adds the month over month change to the cost details page. The following scenarios are handled per the mocks.

Cost increase shows red text & arrow with "increase since " text
Cost decrease shows green text & arrow with "decrease since " text
When delta value is 0, the "no change since " text is shown
When the date is 31, the "since last month" text is shown

Note that start:dev / Insights proxy currently returns 0 for all delta_percent values; although, I believe this is just a matter of populating the data manually? I had to hard code the percentages to get the screenshots.
Fixes https://github.com/project-koku/koku-ui/issues/168
Cost decrease:

Cost Increase:

Deploy preview for project-koku ready!
Built with commit a31142f0763621630dff65e85c887af83df7528a
https://deploy-preview-177--project-koku.netlify.com

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   91.77%   91.77%
=======================================
  Files         116      116
  Lines        1240     1240
  Branches      148      148
=======================================
  Hits         1138     1138
  Misses         93       93
  Partials        9        9

Impacted Files
Coverage Δ

src/api/reports.ts
100% <ø> (ø)
:arrow_up:

src/api/query.ts
100% <ø> (ø)
:arrow_up:

src/utils/getComputedReportItems.ts
97.5% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f31c9...a31142f. Read the comment docs.


refactor : image size and alignment  in readme

Center aligned and resized images to have almost the same height.
Fixes issue - README.md: Fix inconsistent image widths DevoLearn#12

Hi  @rtharungowda, thanks for the PR. I'll review it soon :+1:


Update Storage and picture command portion of DG

Update Storage portion of DG by adding in

Profile Picture related classes into UML diagram
Renaming everything related to address book to contacts list

Added Picture Command portion in Implementation section

Added sequence diagram

Didn't really know what to write for the picture command part under implementation, if anyone has any ideas on how to beef it up please let me know :')
Also for the sequence diagram i left out the braces and parameters in some methods as it was too long. Do let me know if it is acceptable or if there's a better way of writing it
Thanks!

Codecov Report

Merging #158 (f61ce0e) into master (492384c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #158   +/-   ##
=========================================
  Coverage     74.28%   74.28%
  Complexity      691      691
=========================================
  Files            95       95
  Lines          2154     2154
  Branches        256      256
=========================================
  Hits           1600     1600
  Misses          425      425
  Partials        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492384c...f61ce0e. Read the comment docs.


Where is the packaged version?

I read the install file, and there's supposed to be a packaged version available on the epel repo.
I've enabled the epel repo on my rhel 8 vm, but and tried installing the podman exporter, but it can't find the package.
[root@vm-local-1 prometheus-podman-exporter-1.11.0]# sudo dnf -y install prometheus-podman-exporter
Last metadata expiration check: 0:14:20 ago on Sat 23 Mar 2024 11:37:35 AM UTC.
No match for argument: prometheus-podman-exporter
Error: Unable to find a match: prometheus-podman-exporte

I also took a look at the repo files itself, but the package isn't present.

Hi @csuka
Exporter only supports podman v4, v5 therefore its only available for RHEL 9. RHEL 8 is using podman v3.
I will update the install.md as well.
Regards


Intermittent KeyError when writing to S3

Still experiencing intermittent Access Denied errors see #218.
However today a new one has popped up when writing to_parquet. In this case:
df.to_parquet(
    'path/to/20190719.parquet',
    engine='fastparquet',
    compression='snappy',
    times='int96',  # spark supported timestamps
    storage_options={'s3_additional_kwargs': server_side_encryption_args},
)

occasionally (with a similar freq to access denied so far) is giving:
'path/to/20190719.parquet'
Traceback (most recent call last):
  File "<ipython-input-50-e89c9bf2fe97>", line 16, in <module>
    storage_options={'s3_additional_kwargs': sse_args},
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/dask/dataframe/core.py", line 3618, in to_parquet
    return to_parquet(self, path, *args, **kwargs)
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/dask/dataframe/io/parquet.py", line 1496, in to_parquet
    out.compute()
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/dask/base.py", line 175, in compute
    (result,) = compute(self, traverse=False, **kwargs)
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/dask/base.py", line 446, in compute
    results = schedule(dsk, keys, **kwargs)
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/distributed/client.py", line 2527, in get
    results = self.gather(packed, asynchronous=asynchronous, direct=direct)
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/distributed/client.py", line 1823, in gather
    asynchronous=asynchronous,
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/distributed/client.py", line 763, in sync
    self.loop, func, *args, callback_timeout=callback_timeout, **kwargs
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/distributed/utils.py", line 332, in sync
    six.reraise(*error[0])
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/six.py", line 693, in reraise
    raise value
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/distributed/utils.py", line 317, in f
    result[0] = yield future
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/tornado/gen.py", line 735, in run
    value = future.result()
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/tornado/gen.py", line 742, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/distributed/client.py", line 1680, in _gather
    six.reraise(type(exception), exception, traceback)
  File "/mnt/miniconda/envs/jestr-etl/lib/python3.7/site-packages/six.py", line 692, in reraise
    raise value.with_traceback(tb)
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/dask/dataframe/io/parquet.py", line 617, in _read_parquet_row_group
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/fastparquet/core.py", line 302, in read_row_group_file
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/fsspec/spec.py", line 689, in open
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/s3fs/core.py", line 303, in _open
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/s3fs/core.py", line 920, in __init__
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/fsspec/spec.py", line 884, in __init__
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/s3fs/core.py", line 479, in info
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/fsspec/spec.py", line 495, in info
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/s3fs/core.py", line 497, in ls
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/s3fs/core.py", line 430, in _ls
  File "/mnt1/yarn/usercache/hadoop/appcache/application_1566335097751_3990/container_1566335097751_3990_01_000015/environment/lib/python3.7/site-packages/s3fs/core.py", line 339, in _lsdir
KeyError: 'path/to/20190719.parquet'

environment is:

dask 2.1.0
distributed 2.1.0
s3fs 3.3.0
fsspec 0.4.3

You may have said this elsewhere, but roughly how many

Partitions are you writing?
Cores do you have in your cluster?
Number of machines are in your cluster?

partitions - ~3000 per day for ~20 days of data.
10 c3.4xlarge nodes.
1 c3.4x is 30.0 GiB RAM, 16 vCPUs


fusion provider tries to use parallels

On OSX 10.9 with VMWare Fusion and Parallels installed
When running "veewee fusion build 'u12043'" Parellels launches and gets into a mess.
if you run with -n "veewee fusion build 'bowdenbox-u12043' -n" everything works as expected.

closing as there was no feedback in three months, please let me know if you can provide more details and I will reopen


The -coverprofile flag does not work

When run gb test with the  -coverprofile flag, it failed.
$ gb test -coverprofile=coverage.out
... ...
testing: cannot use -test.coverprofile because test binary was not built with coverage enabled
FATAL command "test" failed: exit status 2
Any workaroud? Is there any plan to support this flag in the near future?

I'm sorry, test flags are not well implemented at the moment. This is second on the road map (after the current 0.1 series, which focuses on cross compilation).

:+1:

I'm sorry that in have not added cover support.
It is certainly on my list, but when added it will probably not be a flag,
but a high level command, ie
gb cover $pkg
On Mon, 9 Nov 2015, 15:09 Adam Clark<EMAIL_ADDRESS>wrote:

[image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/367#issuecomment-154914686.

In he mean time I've modified the coverage script published here...
https://mlafeldt.github.io/blog/test-coverage-in-go/
for use with gb
https://gist.github.com/adamclerk/132b8e7a01e419dc3f47

Thanks @adamclerk! Works like a charm.

Any update on this?

I'm sorry I have no update on this issue.
On Thu, Jun 9, 2016 at 8:15 PM, Kegsay<EMAIL_ADDRESS>wrote:

Any update on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/367#issuecomment-224854751,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA4BGknESPS1Lz19Tz5-RV5E2rDY2ks5qJ-fLgaJpZM4F9f1B
.

@davecheney : Is this just simply passing through the flags to go test? If so, I'm sure I can send you a PR for it.

Sadly not, gb is not a shell around go test. The work needed to be done is
to pass the source code to the cover tool to prepare it, then run the
prepared version.
On Fri, Jun 10, 2016 at 8:52 PM, Kegsay<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney : Is this just simply passing
through the flags to go test? If so, I'm sure I can send you a PR for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/367#issuecomment-225152711,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA5SN06yyJU8TzyHAosMBsbbKKaOnks5qKUH-gaJpZM4F9f1B
.

Right now I'm doing this to check my module coverage:
GOPATH=`pwd`:`pwd`/vendor go test api/controllers -coverprofile=cover.out

I know this isn't the best option, but works.

Hello,
I wanted to say that I hear all the comments and I understand that coverage
is important.
Ideally I'd like coverage to be a new top level command for gb. It looks
straight forward, a week or two work I estimate.
Sadly I cannot commit to a timeline of when it would be done. If someone
else wants to take it on that would be amazing, but  please remember this
projects policy of discussing design before coding begins.
On Wed, 29 Jun 2016, 09:20 Jairo Luiz<EMAIL_ADDRESS>wrote:

Right now I'm doing this to check my module coverage:
GOPATH=pwd:pwd/vendor go test api/controllers -coverprofile=cover.out
I know this isn't the best option, but works.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/367#issuecomment-229213218,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA5r-C0Dsqsu8o3GdrwcznX2zJAREks5qQaxAgaJpZM4F9f1B
.


Create the issues view for the jira plugin

I extended this plugin like this

Hey @riginoommen, that looks useful. Could you please share how you achieved that?

I took this code and extended this. i will open a pull request to this repo soon

I have created the pull request along with this feature


Negative Healing ability name not changed, also possible damage resistance bug discovered

The text for the ability was changed correctly to reflect the changes in the remaster, but the name of the ability itself was not changed, despite being clearly called "void healing" inside of the text. Searching for Negative Healing in the compendium finds the ability, but searching for "Void Healing" does not.

Out of curiosity I tested whether a creature with Negative Healing could take Void damage and it could. I was using the Lich creature to test this, as it has a Void damage attack. It took the damage.

Out of further curiosity, I tested the Lich's Cold resistance by having it take damage from it's own Cone of Cold spell. It took the full damage despite having Resistance 10 to Cold. (I healed the creature to full before testing)

I then searched for a creature with immunity to test out on and found the Ice Golem. I then had it take damage from the Cone of Cold. It took full damage despite being immune.

Initially I wondered if the trait Negative Healing didn't negate Void damage because of the renaming of the damage, because I vaguely remember creatures with this ability not being able to take Negative damage. But after testing it with resistances (which I clearly remember working before) and immunities (which I did not try before the remaster) I believe there might be an issue with the way damage interacts with resistances/immunities.

Hi there,
Try enabling immunities, resistances, and weaknesses in system settings.

I see, my bad, that did it. Thank you very much.


Switch ApacheConf to maintained upstream

Description

Discussed in #7135.
Checklist:

[x] I am changing the source of a syntax highlighting grammar

Old: https://github.com/textmate/apache.tmbundle
New: https://github.com/mrmlnc/vscode-apache

Oooof. Looks like @michidk has renamed the typst grammar repo. I've opened https://github.com/github-linguist/linguist/issues/7145 to track this.

Oooof. Looks like @michidk has renamed the typst grammar repo. I've opened #7145 to track this.

Resolved now. The test failures are legit. Looks like you may not have used the script/add-grammar command as documented. Please use that script to replace the grammar.

That's exactly what I did. What else is missing?

See the test failures. They indicate the grammar may not have been swapped using the script as it should have prevented all of those issues as it updates all the files reported in those errors.


How can i make scrcpy open on another screen, in fullscreen mode?

i have seen the window size and location parameters but i cannot find a parameter like "--screen 1"

This is not implemented.
Ref to implement it: https://stackoverflow.com/questions/41745492/sdl2-how-to-position-a-window-on-a-second-monitor

it would help me so much if a workaround was discovered for now.

A workaround: open scrcpy while your target screen has focus (for example execute while the terminal is on that screen).
If that does not work, run scrcpy, move it to the target screen, and press MOD+f.

Refer https://github.com/Genymobile/scrcpy/blob/master/doc/window.md#position-and-size
scrcpy --window-x=100 --window-y=100 --window-width=800 --window-height=600


Move manifest nodes to dbt/artifacts

resolves #9388
Problem
As part of the initiative to make a package to handle artifact generation, serializing and validation we are moving things to a separate dbt/artifacts directory. This PR is to move the nodes/resources in the ManifestNodes union.
Solution
Move the nodes in the ManifestNodes union to the artifacts package.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
[x] This PR includes type annotations for new and modified functions

Questions:
There's some validation logic in the configs that I'm not sure should be in artifacts. Should we attempt to move that out someplace else?
I put all of the "resources" into a manifest_nodes.py file, because a number of them were pretty small and it seemed like overkill to give each one separate files, but I don't have strong feelings about that.
Anything in the "base" resources dictionary will not be versioned, so we should be sure that it makes sense to put things there.
I did not put UnitTestNode into artifacts because right now that resource is never written out into json artifacts, it's only used internally in constructing the temporary unit testing manifest.
None of the embedded objects (i.e. Configs and things like RefArgs) can use the pattern of putting the fields and methods in different classes, because then there are different types in the artifacts and the nodes and mypy complains.  It works fine for top-level resources though.

There's a couple of failing unit tests that I need to chase down, but wanted to give people on opportunity to review.


Add and enforce optional expectedChainId in ChainConnector

If we know the chainId ahead of time, we can pass it to addChain for extra security

Let's see what the CI has to say. I think this is done.


Can't save the ASTC to KTX with mip maps levels

Hello!
How to reproduce

Open image in some format (tga)
generate mip maps
Select ASTC format in Destination options
Select KTX in Destination options
Process Selected images
We can see in output window:

Error(0): KTX Plugin ID(1) saving file = some_correct_path/Bush_02_1.KTX
Error: saving image or format is unsupported
Note:

If select *.ASTC file extension with mip maps is working fine
Without mip maps ASTC to *.ktx  is working fine

hi! is this issue observed in the latest master branch? i can't reproduce the issue. Can you provide the image that you used to reproduce this issue?
Thanks.

Hello xooiamd!
Yes, i'm trying the master branch(Compressonator_2.3.2953.exe)
It can be any image png, tga. I attached image:

hi @Andreyogld3d , Compressonator_2.3.2953.exe is a binary released on july, after that we have made a few changes including adding in ktx support for mipmap generation. You can refer to the readme "Recent additions and changes since v2.3 release" for the changes we committed in master branch.  So i would recommend you clone the latest master branch with the common lib submodules and build the Compressonator\Applications\CompressonatorGUI in release_md configuration to get the latest Compressonator.exe . Let me know if you have issue in building it. Thanks!

Hi, xooiamd. Ok,Thanks.

Hello xooiamd,
i'm trying build the full project CompressonatorGUI, but i have compilation error. I attached
output.log:
I can't attach zip format via git hub.

Hi @Andreyogld3d , seems like the compilation failed due to invalid \Common\Lib\ path. Can you check if your common lib folders content is not empty? please note that recently we have moved all our shared common libraries for GPUOpen-Tools (the folders content under Common\Lib*) to git submodules, the folders content of git submodules will not be downloaded by downloading the zip folder from compressonator repo. You will have to download submodules content from their own repo (for example amd app sdk is in this repo https://github.com/GPUOpen-Tools/common-lib-amd-APPSDK-3.0) or you can do a "git clone --recursive https://github.com/GPUOpen-Tools/Compressonator.git" to get all compressonator content with the submodules content.  Please let me know if you have any further issues. Thanks.

Hi xooiamd,
I compiled compressonator, now i can save ASCT textures to the KTX with mip maps.
Thanks!


feat: Ctx everywhere

Ctx everywhere
References

https://pkg.go.dev/context
Ctx is the key, by Samuel Davidson

Why
Having context along with requests allows the client to control, check for timeouts, and cancel requests. This is especially important for brokers that have a message deadline before requeueing and for parallel processing.
How

Added context to all requests from every module: Domains, ApiKeys, Emails
Added one test for the Request module to check if the context is canceled to return an error
Updated examples to show how to use context

Cons

This is a huge breaking change, so it's a good idea to release a new major version.

Non-related changes that can be reverted

Refactored the request factory to be more readable and don't have to declare the same variables twice.

thanks a lot for the contribution @jorgejr568 and @gabrielcipriano , this is definitely a great improvement for the SDK.
I'll spend sometime playing with the PR and running some local tests, overall it LGTM, should have it merged soon.


v2.0.0 breadcrumbs missing on section and category pages

Looks like I missed something when updating navs to use friendly urls.

This is an issue in the template, opened ticket there (https://github.com/queue-bit/template-txt/issues/5)


[intel] Remove ExpOpConversionApprox

Removed in upstream commit https://github.com/triton-lang/triton/commit/84fe9dadad9633421d020b3fa5dea14367b19ea8.

This PR would make exp call to change from llvm.exp2.f32 to _Z15__spirv_ocl_expf, and performance to drop from 96.948203 to 67.610663 TFlops.

It is reverted upstream in https://github.com/triton-lang/triton/commit/3a647f01c16530e9ec644b034d0b07f09a78e913.


removed unnecessary methods _initMeta()

Latest version has used defineReactive directly in for directive
(And how to deal with the test case? No better idea...)

I kept it there because it is used in vue-router. It's a bit weird if upgrading a minor version of Vue requires upgrading vue-router as well, so I'll keep this PR open until 1.1.
For the tests we can simply remove them.

We'll just keep this in v1 for compatibility. v2 already got rid of it.


Feature request: unlock keyboard (word suggestions) to use seed in other languages

Hi,
I am using a multisig scheme with 3 seeds in different languages. It works on electrum wallet. For example: one seed in portuguese, another seed in italian and other seed in czech.... But in my SeedSigner just seeds in english are available...
Thank you!

I'm not sure what it means to have a seed in other languages exactly. English is the only officially supported language of BIP39, no? Are there broadly accepted word lists that correspond 1:1 with the English list?

All languages bip39
https://github.com/bitcoin/bips/tree/master/bip-0039

Other source to see all mmemonic languages:
https://iancoleman.io/bip39/

Thanks for those links.
Your feature request is probably better suited for the actual seedsigner repo. This repo is only the OS underlying the seed interaction software.


Exception. Quotation marks in the font name of text styles

I have a dxf file in which the font name of text styles is enclosed in quotation marks. Autocad works successfully with this text style.
However, NetDxf generates an exception when reading this file at method DxfReader.ReadTextStyle in the string:
ShapeStyle shapeStyle = new ShapeStyle(Path.GetFileNameWithoutExtension(file), file, height, widthFactor, obliqueAngle);
There is a suggestion to pre-trim the quotation marks in the font file name of text style.
Link to the DXF file

How do you end up with a Style that points to a file with quotation marks when those characters are not allowed as part of the file name by Windows?

Unfortunately, I do not know how this font was added to the dxf file.
I will try to clarify the script how this font name was added. But in the end, DXF is a test file and the font name could be written in a text editor, because this is not prohibited.
The sad thing is that our users have a DXF file template that they use to create their drawings. There are thousands of these drawings and they cannot be processed in NetDxf.

(+) Not observed in version 2.4.1 release

A little late, I studied the solution proposed in 2.4.1 release. It seemed doubtful to me.
The solution was that if incorrect characters were found in the file name, the entire file name was replaced with a certain constant string "FILE_NOT_VALID".
This is really a better solution than throwing an exception. It is suitable for general cases.
But in my original scenario, the file name is correct. It is only framed with quotation marks. This is what the Windows operating system does in some cases. I don't expect "FILE_NOT_VALID" to be used instead of my file name.
I suggest adding a line file = file.Trim(new[] { '"' });
// basic check if file is a file path
file = file.Trim(new[] { '"' });
Debug.Assert(file.IndexOfAny(Path.GetInvalidPathChars()) == -1, "File path contains invalid characters: " + file);
if (file.IndexOfAny(Path.GetInvalidPathChars()) != -1)
{
    file = FileNotValid;
}

A little late, I studied the solution proposed in 2.4.1 release. It seemed doubtful to me.
The solution was that if incorrect characters were found in the file name, the entire file name was replaced with a certain constant string "FILE_NOT_VALID".
This is really a better solution than throwing an exception. It is suitable for general cases.
But in my original scenario, the file name is correct. It is only framed with quotation marks. This is what the Windows operating system does in some cases. I don't expect "FILE_NOT_VALID" to be used instead of my file name.
I suggest adding a line file = file.Trim(new[] { '"' });
// basic check if file is a file path
file = file.Trim(new[] { '"' });
Debug.Assert(file.IndexOfAny(Path.GetInvalidPathChars()) == -1, "File path contains invalid characters: " + file);
if (file.IndexOfAny(Path.GetInvalidPathChars()) != -1)
{
    file = FileNotValid;
}

As some other characters the quotation marks are not allowed as part of a file name, sometimes they are used by search engines as the characters * and ? but never as part of the name. What I forgot to do is to allow changing the File property of a ShapeStyle.

As some other characters the quotation marks are not allowed as part of a file name, sometimes they are used by search engines as the characters * and ? but never as part of the name. What I forgot to do is to allow changing the File property of a ShapeStyle.


Subscription module startup changes

This PR makes a few minor changes to how the subscription registry works in HAPI FHIR.
The main change is that subscription interceptors are now marked @Lazy and are only explicitly loaded by SubscriptionInterceptorLoader.registerInterceptors().  This method first checks DaoConfig to see if any types of Subscriptions are supported and then loads all active subscriptions into the SubscriptionRegistry before loading the interceptors.
Also I changed the SubscribableChannelFactory interface so that it more naturally supports the different kinds of channel factories that need to be supported.

Also this PR adds support for R4 subscriptions

Coverage decreased (-0.04%) to 74.509% when pulling 6ac2eafaf935594afeb86867c0b631ae747b1aa8 on fil512:sub-mod-2 into 1311ef4157c79d0e9ad9dea169dbc2fa46cf675c on jamesagnew:master.


TCA Example fails to build when "iosapp" minimum_os_version is set to 17+

TCA has a Perception library that is a backport of Observation to iOS 13. It has some @available checks like this:
@available(iOS, introduced: 13, obsoleted: 17, message: "Use @Bindable without the 'Perception.' prefix.")

When I change the minimum_os_version of the "iosapp" example target to "17.0" in the "tca_example", the build fails with the following errors (among many other like this):
external/rules_swift_package_manager~~swift_deps~swiftpkg_swift_perception/Sources/Perception/Bindable.swift:26:32: error: 'Bindable' is unavailable in iOS: Use @Bindable without the 'Perception.' prefix.
    public var projectedValue: Bindable<Value> {
                               ^~~~~~~~
external/rules_swift_package_manager~~swift_deps~swiftpkg_swift_perception/Sources/Perception/Bindable.swift:15:17: note: 'Bindable' was obsoleted in iOS 17
  public struct Bindable<Value> {

This indicates that we are hitting this availability check.
When I download TCA directly and open up the Xcode project and update the deployment to 17.0, there are expected errors and once I fix those, the example app builds successfully. Looking at the .swiftmodule and .swiftsourceinfo output from Xcode, I see that these modules (Perception and its direct dependency XCTestOerlay) are built with the flag: -target arm64-apple-ios13.0-simulator while the rest of the app's modules are built with the flag: -target arm64-apple-ios17.0-simulator. Simply adding the flag in copts like so:
    copts = [
        "-target",
        "arm64-apple-ios13.0-simulator",
    ]

in the generated BUILD.bazel files gets farther (Perception builds fine), but the app build still eventually fails with very similar errors in the TCA library itself.

Sorry, duplicate of: https://github.com/cgrindel/rules_swift_package_manager/issues/892


Refactor reverse engineering API

This splits reverse engineering at several levels. The entry point for provider writers is MetadataModelProvider.GetModel().
The framework provides some implementation helpers.

MetadataModelProvider has a protected method AddNavigationProperties which should be called on a mostly-ready IModel. This will add navprops for all foreign keys.
Providers can implement RelationalMetadataModelProvider. If given SchemaInfo and a type mapper, it will build and IModel.
Providers can override methods in RelationalMetadataModelProvider to get specific control over how metadata is build, if the default is unsuitable.

Closes #3404, #3077, #3288, #3247 and #3329.
TODO
[ ] also update how a provider passes their UseProvider() method name to the code gen step.
[ ] move everything to M.D.E.Scaffolding (.Internal)

:shipit: with agreed changes.


add contact-information

Add contact information to ServiceDetails.js

@andresdaguilar @nciampechini:
The code for this has been added to the the other PR as well. Does it work with the current backend api? Will deploying this without deploying the changes to the backend break the application?


Packets aren't routed to tunnel on ChromeOS devices based on Android 9

ChromeOS devices use an Android compatibility layer to run Android apps. On devices using the Android 9 compatibility layer, this is achieved via a VM running inside the ChromeOS host.
The VM's network is bridged to the host using virtual interfaces with names like vetharc0 and arcbr0. These interfaces have addresses in the CGNAT range.
ChromeOS devices using Android 11 or newer don't seem to exhibit the issue.

Closing as Android 9 is only getting older.


npm install error 404

Part of ES5 does not support ie8, do you test it in ie8?

ie8 will very likely not be a supported browser.

@davidfowl In aspnet signalr, support IE8 +, including IE8.This might not have anything to do with the service, it's the signalr-client relationship.I still want to support IE8 +

Install msgpack5 first or add .npmrc with the following line:
@aspnet:registry=https://dotnet.myget.org/f/aspnetcore-ci-dev/npm/

@leehavin original SignalR was built ~5 years ago when IE8 support was more important. If it just works I think that's fine but I wouldn't state it as something we test (it's too old at this point).

https://github.com/aspnet/SignalR/pull/786

@davidfowl Thank you.I believe the community will be improved. In China, many enterprises still stay in older versions.But thank you very much.


path/filepath: no-op path.filepath.EvalSymLinks on Windows

What version of Go are Windows users using (go version)?

$ go version
go version * windows/*

Does this issue reproduce with the latest release?
Yes, it is due to architectural differences between Windows and other operating systems.
What did Windows people do?
Nothing.

What did you expect to see?
That software written in go continues to work after disaster recovery or changing a sub directory from being physically present to being a reparse point to a large fresh volume, without hunting down configuration issues with go software because it persisted paths after calling EvalSymLinks, assuming that the path would be more stable than the path configured explicitly by the system administrator after calling EvalSymLinks.
Why should EvalSymLinks no-op on Windows?
On Windows, the path that EvalSymLinks returns is not more stable, rather it is in very common situations random due to the GPT volume identifier being random and is hence the path returned by this API is also not under control of the administrator. The administrator might be forced to change reparse points or hard links due to disk failure, disaster recovery, resolving disk full problems, and similar. Hence, the use of EvalSymLinks for the purposes it is designed for is wrong on Windows, even if its use is justified in the same software on other operating systems.
What did you see instead?
Docker services stop being able to start, even though they should have run and should continue to run from C:\Docker, regardless of the fact that this directory resolves now to a Windows path on a different volume with a different GPT unique identifer and hence a different volume path in the form \\?\Volume{guid}.

Thanks for raising this. It's a proposal (I think) so doesn't have to follow the standard issue template. It's also rather long and a bit grumpy.
Could you thin it down to a list of specific problems (with examples) in the current API, and possible solutions?
Note that the Windows port has long depended on contributions from outside the team at Google.

Well sorry for being grumpy, but leaving Windows end users like me with a myriad of problems that they should wholeheartedly own as stewards of go is ... more grumpiness. Notice that I was explicitly mentioning Google and not the well-meaning community, but they are limited to playing whack-a-mole and naturally everybody cares about just their own little issues.
As I said, I have no experience with Go. I just counted them and I only ever wrote 54 lines in 2 files and just 20 lines that actually do something.
So, although I might shorten this post and make it less grumpy, making this specific I feel first of all doesn't truly reflect the fact I find issues in about every function in path_windows.go and file_windows.go and probably other *_windows.go files. I mean from palmface issues like the VolumeName API not returning or intending even to return any kind of volume name but a root path to hacking strings and finding ':' where you might also in fact be looking for '\?\Volume{GUID}' to stripping '\?' from a path after 'GetFinalPathNameByHandle' returns that, breaking long paths and special paths in the process, to suspecting that happens in perhaps every file API in go by looking at the issues in this repository, on Stack Overflow and in the docker repository, etc.
I mean how did they get that name so wrong? Was that API proposal not reviewed or did they like the confusion that would result but which they could hope would go unnoticed?

What Go app has been giving you trouble, Docker? Have you filed an issue there? If so, can you point it out?
It's the app's responsibility to work correctly on platforms it supports. I patch the Go stdlib on Windows where needed.

@ericwj I'm sorry that you are frustrated but this issue doesn't seem to give us a useful way forward.
I doubt this will make you feel any better but pretty much all the Windows path support was written and contributed by Windows experts who do not work at Google.
It seems to me that filepath.EvalSymlinks is well defined, and it is clearly useful on Unix systems.  Perhaps programs that run on Windows shouldn't be calling it, but that doesn't mean that we should remove it.
CC @alexbrainman @mattn

Are you saying Google isn't involved? They are at least reviewing every single change - or they appear to be.

It's the app's responsibility to work correctly on platforms it supports.

If you personally wrote a new language, I would agree. Imho Google has a larger responsibility. But hey, the fact the first thing Microsoft does contributing to chromium is to add features for people with disabilities speaks to the company culture at Google refusing to do anything of the sort for 12 whole years.
@ianlancetaylor I am not asking for the API to be removed if it is 'normal' to use that on *nix, although I think overruling an administrator is about always wrong by principle regardless of the operating system. But go knows whether you are on Windows or cross building for it and if it has infrastructure to give warnings or suggest fixes for this API on Windows then that would be step 1.
I didn't personally file issues with Docker, but the are legion links to be found in their issues and on Stack Overflow with people stumbling on error messages like unable to prepare context: unable to evaluate symlinks in context path and similar.
I did file issues with Microsoft about this Visual Studio behavior, but since these errors do not reside in actual Microsoft code they de-prioritized.
About Git I am honestly just unaware of the components that make up the system. Visual Studio Code works quite allright, but Visual Studio has some go somewhere in its Git extension or I don't know where such that these problems magically appear in recent versions of Visual Studio.

Are you saying Google isn't involved? They are at least reviewing every single change - or they appear to be.

Google is a huge company.  I'm not sure what it means to say that Google is involved.  Certainly Google employees are heavily involved with the development of Go.  But it's not accurate to say that Google employees are reviewing every single change.  Go is an open source project.  Many changes to Go are written, reviewed, and submitted by people who are not Google employees, without anybody employed by Google being involved at all.

Well, Eric, since you learned Go, maybe you could fix some of those Docker issues (perhaps by replacing EvalSymlinks in their codebase), and then file an issue or two here about how Go could support them better :-)
But we need specific bug reports to make progress.

Go is an open source project.

So is .NET. And .NET actually works even with Windows-isms on a long list of *nix variants, because Microsoft as primary steward of the ecosystem is taking its proper responsibility. The downside is they have so much tests that it is hard to find any actual code if you look for a definition of something in /dotnet/runtime say.
Look, let's talk solutions. I am fed up hitting brick walls every time someone chooses go over another language and then shoves it onto my system as part of some software that I use - that's why I'm here. I identified very concrete issues and I can probably write code from plain primitives that uses the Windows API properly to fill in go API surface -- I just can't realistically write it in go. Would I help writing plain C# implementing some of the broken API's in go?
I could perhaps even write tests that will show how to break go, but I'd have to do that mostly in PowerShell and C#.

PowerShell to create .vhdx files and mount/unmount them - system administration stuff, which I don't think go can do today at all.

Scripts in Powershell or programs in C demonstrating Go bugs would be fine. C# programs might not be as widely accessible, and you can't necessarily tell by reading them which winapi calls they make.
But it sounds like part of the solution is for certain Go programs not to call EvalSymlinks on Windows.

you can't necessarily tell by reading them which winapi calls they make

You can if I use only primitives - if I exclusively P/Invoke directly. You just get code that is more or less C++ but cleaner.
I actually found this microsoft/DockerTools#235 and why don't I also link this.

Many Go devs won't be set up to compile C#.

BTW you can use this Go package to invoke most of the winapi directly: https://godoc.org/golang.org/x/sys/windows

you can use this Go package

Yes, I've used it in #40095 it must be. But it will take me too much time I do think. To get that single line of error handling proper in the pull took me...I don't remember, an hour?

Many Go devs won't be set up to compile C#.

My idea is to make a repo for this which serves to show how to use the Windows API to say implement IsAbs, which won't be part of the go repo ever but will be ported. All you need to do is read that to port it. Does that fit your expectation?
I might ask you to write a go program which accepts standard input with a switch statement to run public go API with varying arguments and write error codes and maybe messages back to standard input. Can I ask you for such a thing?

A complex issue over which I have no overview whatsoever is how to incorporate tests in this repo and whether it would be acceptible to download and install PowerShell 7 or higher into a local installation folder upon building or running tests on Windows.
If not then it would be needed to port a significant Windows API surface dealing with virtual disks to that x/sys/windows package just to be able to run tests in go.

Then there is the fact I have no idea what the test capabilities are of this repo prior to proper public releases.
Long Paths is a global registry setting, although it can be enabled per process by changing that global setting temporarily.
VirtDisk.dll API's may not be available on all editions of Windows and requires privileges.
Storage Spaces afaik is on all editions of Windows but is certainly different between various Server and non-Server editions.
And these are just the issues from the top of my head.

We run tests on various different builders, seen on https://golang.org/build.  We're currently doing four different versions of Windows.  In principle we can run on any version of Windows that can run in a container.

write a go program which accepts standard input with a switch statement to run public go API with varying arguments

If that's as easy as it sounds, I can do that. I won't be able to port your C# IsAbs() logic, as I haven't signed the Go CLA. However it sounds like anyone else could do that. @bcmills might be a candidate :-)

port a significant Windows API surface dealing with virtual disks to that x/sys/windows package

Right, the VirtualDisk API isn't there. But it's easy to add calls to x/sys/windows.
https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/dd323699(v=vs.85)
You can adjust the configuration of the container that runs tests as needed, I believe.

it's easy to add calls

Luckily I don't need all the API's on that list and yet more luckily I think I already have those that I need in C#, but the snake in the grass is a long list of structs and unions that go with these API's - not sure how many would strictly speaking be absolutely required. Also Setup API is not there afaik. That would be some of these.

we can run on any version of Windows that can run in a container

That means Windows Server exclusively if I'm not mistaken, maybe that's not a problem. Can't see whether these are nano servers or server core though. That could be relevant if there are API's that nanoserver might not have. At least VirtDisk will definitely work on server at least after configuring the container with Hyper-V, no need for enabled virtualization extensions.

If that's as easy as it sounds,

It will probably be for functions that take and return strings and numbers. For path/filepath most arguments are plain strings, so that seems easy enough. Delegates, yeah, WalkFunc. Well, I guess one or several hardcoded very basic ones will suffice. If the errors are actual Windows error numbers or HRESULTs, those are just numbers but trying to match them by name or if go errors are complex objects and I would need to know, that could be a source of difficulty depending on how well go does on getting names of definitions and the reverse operation (reflection).

In principle we can run on any version of Windows that can run in a container.

Does that include local docker on Windows 10 stable latest with Windows Containers? Does anyone of you have experience with that for running go tests?

Go errors stemming from the OS include the system error code, so I can return that with the Go error string.
Some info on the Windows builder environment (not certain it's current): https://github.com/golang/go/wiki/WindowsBuild

I just hacked a driver together - it hasn't even run yet but it gives the idea and it mirrors path/filepath already. You should have some kind of message about that from GitHub.

Found this. Is it a template for the Go app you need, or would it call the Go app?
https://github.com/ericwj/GoWindows/blob/master/src/GoWindows.CSharp/Program.cs

I just wrote that down to see if I can map the API really. This is yeah then a template for go code that I would call.
Would have to change that as you see fit to e.g. include integral error codes if present and to fix the bugs that I already spotted.
Can you add that in go in a subfolder of src? I will probably start with the simplified way of doing it from my perspective that is to make Program.cs accept a few arguments and then call that after hacking the system configuration with PowerShell to create various kinds of paths to test against.

If that is not too hard, can you create an indirection like I did? With two implementations, one that only echo's to test the infrastructure and one that actually calls go API?

I was hoping for a spec to code against, instead of a partial implementation in a language I don't know :-)
I've opened an issue there for discussion of the spec:
https://github.com/ericwj/GoWindows/issues/1

So testing go in a container appears convenient, but I have a hard time trying to get it configured nearly resembling a normal machine.
Get-Disk # returns nothing
Get-Vhd # get-vhd: The term 'get-vhd' is not recognized as the name of a cmdlet, function, script file, or operable program.
Install-WindowsFeature Hyper-V-PowerShell
Get-Vhd .\Empty.vhdx # Get-VHD: The Hyper-V Management Tools could not access an expected WMI class on computer 'B7C6804F4C70'.
Install-WindowsFeature Hyper-V # 1. Hyper-V cannot be installed: The processor does not have required virtualization capabilities.

MyHack.exe # Uses `OpenVirtualDisk` and `AttachVirtualDisk` since VirtDisk.dll is right there
'OpenVirtualDisk' failed with hr 0xC03A0014: A virtual disk support provider for the specified file was not found.

Get-PhysicalDisk # Go through Storage Spaces - again, returns nothing

So no way in a container to get any path with a volume GUID.

According to this (which I linked previously) the Go builder for Windows runs on a VM:
https://github.com/golang/go/wiki/WindowsBuild
@ianlancetaylor when you wrote "we can run on any version of Windows that can run in a container" did you mean a GCE VM? Can you elaborate?

Oh I have just seen the term "container" above and not "virtual machine"... Also I understood that winstrao as a bootstrapper and not something that runs on the actual test environment.

Eric, an easy way to trial your test battery might be to post a pull request with that code (without stdlib patches). Then any Go team member can trigger a build pass to run it.
You'll need some advice on how to make it run a powershell script.

That would involve building your code and adding it to the path I would say, unless I could start by including the executable which would then be built against 1.14.4. If I can get at it via the path I could write the test code as a PowerShell module.
Or write a Pester script.

@networkimprov Yes, the Windows builders run in a GCE VM.  See https://farmer.golang.org/builders.

Eric, drop a note on golang-dev asking for advice on creating a CL (Gerrit term for pull request) that includes
a) a testing powershell script which runs
b) a Go command-line program from the same CL.
I suspect it's trivial :-)

BTW, the title of this issue should now be something like "path/filepath: validate all functions on Windows"

I don't think I need Docker when running on a VM. Docker has issues yeah.
My 43-line hello.go was able to run
import (
	"github.com/docker/cli/cli/command/image/build"
)
...
	res, err = build.ResolveAndValidateContextPath(path)
	fmt.Printf("%v [%v] %v => %v\n", "ResolveAndValidateContextPath", err, path, res)

	res, rel, err := build.GetContextFromLocalDir(path, dock)
	fmt.Printf("%v [%v] %v => (%v, %v)\n", "GetContextFromLocalDir", err, path, res, rel)

You mean I test that in the same PR?
There is no repo golang-dev, where do you mean I drop a note?

Mailing list https://groups.google.com/forum/#!forum/golang-dev
The "Go command line program from the same CL" refers to the filepath API tester.
I didn't follow your last Q. Please elaborate. What is that code snippet from?

Those are one-liners copied from [docker/cli] which produce the dreaded errors.Errorf("unable to evaluate symlinks in context path: %v", err) (context.go#L292) after Visual Studio gave them a very neat C:\Users\Eric\Source\Dockerfile and which are amongst the 56 lines of go code that I ever wrote.

Well, now it is 59, obviously.

You could test that Docker code in the same CL, via a separate .go file. But maybe the filepath API tests already cover that problem.

And erm, pls change the issue title: https://github.com/golang/go/issues/40104#issuecomment-656351658

Let's first focus on go. My opinion is still that they shouldn't use EvalSymLinks and use whatever path I gave them with no translation.
Does anyone see my post in golang-dev? I posted and poof, gone?

Your first post is reviewed by a moderator, I believe.

@ericwj
I don't understand what this issue is about.
I don't see any bug reports. If you found some bug in Go, please, provide steps to reproduce. Or at least some details.
If you are proposing to discontinue use of filepath.EvalSymlinks, then I disagree with your proposal. filepath.EvalSymlinks has been used in many Go programs. Whatever the function does is useful to these programs. If it does not work for your use case, do not use it. Write whatever function you need.
Sorry.
Alex

@alexbrainman I found a number of issues, some of which are mentioned in this thread. Although it is the world upside down, as an end user that has written now 59 lines of go out of frustration with go and is not intending to add to that, I am spending days to get tests setup on a clean Windows machine that will proof a series of issues.
I am being advised to file new issues for those, tbd how exactly.
Sure EvalSymLinks has been used a lot, because go has it and doesn't point at any issues with it. It might also be perfectly valid to always default to evaluating all symlinks on Linux, although I might disagree with that too in the case where these resolved paths might be persisted to disk, as outlined. But all programs using it on Windows today give people like me headaches, until it at least works properly in all system configurations.
I have no use case other than to setup my systems the way I used to when it had no go programs on it and to continue doing so now that go software is being forced on me.
So my frustration with go is about for example Docker using this API, substituting perfectly good paths for unreadable ones for imho no good reason - the Windows API calls that Docker uses should do the translation - and on top of that until 40095 is part of go, substituting perfectly good paths for errors which pretty much completely break Docker depending on where it is configured to run.
Same for Git or whatever components make up the combination of Visual Studio and Git.

Whatever the function does is useful to these programs.

" If a stable result is needed, path/filepath.EvalSymlinks might help." Wrong. The stable path is the path configured by the administrator. The path that was given to EvalSymLinks. The path returned by EvalSymLinks might change due to disaster recovery, moving all or part of a parent directory wholly to another disk e.g. becausee the disk is filling up, due to any responsibility of the system administrator that software should be unaware of unless explicitly directed.
This just took me another ten minutes to clarify, so I will leave it at one example, but I'm sure I can find more.
Also, I just don't want to see resolved paths in the console or pretty much anywhere.  They completely forget the path that I gave them. It is inappropriate and wrong. I should be in control of the path that they hit.
They try to be smart and do it wrong. And they are very smart people. Imho that is why this is a go issue on Windows and why I consider EvalSymLinks a trap.

Let me make this again about where it began before I started reading go code.

See the "Go 1 compatibility" policy. There is zero chance that a stdlib API will be disabled, even if most uses of it are incorrect. Propose a new API in a new issue, or submit documentation fixes re Windows.

Same probably holds for #40158 but it is the low hanging fruit. Well I suppose this one isn't even trying to be looking like hanging at all.
Be perfect reviewing stuff or I guess go would have to rev a bit faster in major version numbers and obsolete some mistakes. Nobody expects anyone to be that perfect.

We are far from perfect, but we try as hard we can to not break existing code.  We consider stability of the language and libraries to be extremely important.

That is fine. But if you seriously do the review process should match that seriousness in the first place.

Like I hinted at, the common thing to do is rev a bit faster in major versions and obsolete stuff without any functional change in the next major version, then remove it in the major version after that.
I don't know the roadmap but if go 2 would be fairly soon and I would know that go 3 would be at most a year or maximum two after that, that would give me some peace of mind looking at logfiles with horrible paths etc that it is not endless.
And just hurry with #40095 if at all possible because that is not just wrong that is a showstopper.

There is no announced plan for a Go 2.0. The term "Go 2" refers rather unfortunately to new language features in Go 1.x.
You are wasting time grumbling about Go's flaws & policies. You can document some bugs; that will help a lot.

@ericwj I'm sorry you find our approach to be annoying.  As @networkimprov says, there is no Go 2, and there is no Go 3.  There may be a path/filepath/v2 some day, but we aren't in a hurry about it.  Our general long-term transition plans are outlined at https://go.googlesource.com/proposal/+/refs/heads/master/design/28221-go2-transitions.md .

Please provide a small repro-steps to fix the problem (if this is clearly problem). We have not yet shared the information. Thanks.

Ah that's why I come across grumpy.
Just to clarify, I just talk from basic assumptions, not to criticize whatever policies go has adopted for whatever reasons or with which languages they compare themselves and which ones not.
I am still an end user. I don't care about go 1, how would I care about go 2? How can I criticize what I haven't even tried to learn the first thing about? I just assumed that part of designing a language and a large API surface is to device some means or another to fix issues with it that will inevitably build over time and that that would involve revving at some point.
So sorry for assuming that.
It just makes that review process more important. And my opinion of it travels with the inverse.

@ianlancetaylor @mattn I think Eric is working on a CL that will demonstrate some filepath bugs. He posted a note in golang-dev requesting advice on assembling it, but hasn't received any responses.

@alexbrainman I found a number of issues, some of which are mentioned in this thread.

Sorry, but I cannot find them. Perhaps this thread is too long. Why don't you create new issue for every bug you found? Please, do not ignore the issue template, but fill in as much details as you can.
Please, be aware that Go issue tracker is only used to track real bugs / problems, and submit change proposals.
Thank you.
Alex

Yes just leave this one to be about no-op ing EvalSymLinks and nothing else.
Even the way to do that without breaking anyone is a separate discussion about alternatives and what they look like.
Perhaps this issue could be about changing documentation, or at least adding a few lines of text to make people aware of why this API could bite them on Windows and about expectations by Windows foaks that they shall not use it.

You can just submit a CL with documentation fix clarifying what happens for certain paths.
BTW English folk is spelled like the German volk :-)

From Old Frisian *foks, from Proto-Germanic *fuhsaz. More at English fox.
Hmm, what did I call myself? ;)

I think messed this up. This patch was supposed to be just against ericwj/go for a new pull request. Did it get added to #40095? How do I fix that?

It was added to the CL, yes. Just revert. Then make a new branch, and cherrypick the docs commits to that, and file a new PR.
Also, it should describe EvalSymlinks problems on Windows, not make blanket statements.

That is explained in the commit message, but I'm not sure that is visible. Just revert? How? Commit after getting the old file from history?

git revert <commit> is a common op; it creates new commits. Alternatively make a new commit by hand that removes the docs change.

Best to close this issue, and make a new one for the docs change. Should post the new docs there for discussion before filing PR/CL.


Make MetaDataRegistry internal again

The MetaDataRegistry is an internal cache of EntityMetaData.  The getMetaData method is the appropriate public method to get or load EntityMetaData as needed.

Please update description to indicate why you want this to be internal.

Please update description to indicate why you want this to be internal.

Done


Preparing 1.7.7

Main changes:

Replace debug_binning arg to False in binning_2d_data() #896
Many bug fixes, more robust inversions, ref_vector, load, save_to_stp(), verbosity, error msg... #898 and #907
Improved naming #901
plot_diagnostic_geometrical_coverage() operational #904
save_to_stp() for optics #909

Hello @Didou09! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tofu/data/_class02_save2stp.py:

Line 572:16: E225 missing whitespace around operator

In the file tofu/data/_class08_save2stp.py:

Line 54:5: E303 too many blank lines (2)
Line 513:80: E501 line too long (81 > 79 characters)
Line 532:80: E501 line too long (87 > 79 characters)
Line 533:80: E501 line too long (108 > 79 characters)
Line 543:80: E501 line too long (111 > 79 characters)
Line 554:80: E501 line too long (105 > 79 characters)
Line 565:80: E501 line too long (122 > 79 characters)
Line 576:80: E501 line too long (105 > 79 characters)
Line 585:80: E501 line too long (147 > 79 characters)
Line 595:80: E501 line too long (176 > 79 characters)
Line 605:80: E501 line too long (119 > 79 characters)
Line 616:80: E501 line too long (90 > 79 characters)
Line 627:80: E501 line too long (118 > 79 characters)
Line 638:80: E501 line too long (85 > 79 characters)
Line 649:80: E501 line too long (91 > 79 characters)
Line 661:80: E501 line too long (88 > 79 characters)
Line 672:80: E501 line too long (93 > 79 characters)
Line 683:80: E501 line too long (125 > 79 characters)
Line 694:80: E501 line too long (90 > 79 characters)
Line 705:80: E501 line too long (87 > 79 characters)
Line 715:80: E501 line too long (98 > 79 characters)
Line 725:80: E501 line too long (83 > 79 characters)
Line 735:80: E501 line too long (97 > 79 characters)
Line 755:80: E501 line too long (98 > 79 characters)
Line 765:80: E501 line too long (85 > 79 characters)
Line 775:80: E501 line too long (81 > 79 characters)
Line 787:80: E501 line too long (154 > 79 characters)
Line 796:80: E501 line too long (82 > 79 characters)
Line 813:5: E303 too many blank lines (2)
Line 824:80: E501 line too long (83 > 79 characters)
Line 827:1: E122 continuation line missing indentation or outdented
Line 837:80: E501 line too long (111 > 79 characters)
Line 843:80: E501 line too long (81 > 79 characters)
Line 847:80: E501 line too long (91 > 79 characters)
Line 848:80: E501 line too long (80 > 79 characters)
Line 858:1: E122 continuation line missing indentation or outdented
Line 865:80: E501 line too long (137 > 79 characters)
Line 877:80: E501 line too long (86 > 79 characters)
Line 898:15: W292 no newline at end of file

In the file tofu/data/_class09_GeometryMatrix.py:

Line 152:10: W292 no newline at end of file

In the file tofu/data/_class09_compute_broadband.py:

Line 284:13: E731 do not assign a lambda expression, use a def
Line 286:13: E731 do not assign a lambda expression, use a def
Line 359:80: E501 line too long (80 > 79 characters)
Line 393:22: W292 no newline at end of file

In the file tofu/data/_class10_Inversion.py:

Line 194:10: W292 no newline at end of file

In the file tofu/data/_class10_checks.py:

Line 1265:28: E225 missing whitespace around operator

In the file tofu/data/_class10_compute.py:

Line 134:42: E225 missing whitespace around operator
Line 135:46: E225 missing whitespace around operator
Line 347:1: E303 too many blank lines (3)
Line 375:80: E501 line too long (83 > 79 characters)
Line 1441:6: W292 no newline at end of file

In the file tofu/data/_class10_refs.py:

Line 104:80: E501 line too long (133 > 79 characters)

In the file tofu/data/_class8_compute.py:

Line 1973:6: W292 no newline at end of file

In the file tofu/data/_class8_compute_signal.py:

Line 1128:80: E501 line too long (83 > 79 characters)

In the file tofu/data/_class8_plot_coverage.py:

Line 159:32: E228 missing whitespace around modulo operator
Line 375:33: E261 at least two spaces before inline comment
Line 411:15: W292 no newline at end of file

In the file tofu/tests/tests07_inversions/test_01_isotropic.py:

Line 254:29: E228 missing whitespace around modulo operator


Compilation Error in C language and Output Not Correct

#include<stdio.h>
#define POUNDSTOKG 2.20462
#define TEST_LBSKG 2.20462
double convertLbsKg(const double *pounds, double *conversionResultToKg)
{
double poundsToKg;
poundsToKg = (*pounds) / POUNDSTOKG;
//*conversionResultToKg = (*pounds)/ POUNDSTOKG;
if (conversionResultToKg != NULL)
{
	*conversionResultToKg = poundsToKg;
    printf("This\n");
}

return poundsToKg;

}
int main(int argc, char const *argv[])
{
int fail =0;
double a =0.0, b;
b = 0.0;
double lbs = 5.5;
b = convertLbsKg(&lbs,&a);
printf("%lf\n", b);
printf("%lf\n", a);
if (a == b && a == lbs / TEST_LBSKG)
{
printf("\n");
}
else
{
printf("<!!! FAILED !!!>\n");
fail++;
}
return 0;

}
This is a C code which I run in the VS studio IDE. The correct output of the code should be Passed but the VS IDE prints as Failed. While in the other compiler this code works perfectly fine. I believe there is something wrong in the VS Studio IDE or with the C extensions. I hope the VS studio members will fix this bug with the C language programs.

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Overlapping elements in responsive layout of cloud credentials input page

** Environment **
This was reproduced in a docker-installed image, commit from v2.6-head 10588ab.
Steps to Reproduce:
While entering credentials, it is possible to resize the browser until the "Add New" button overlaps with the drop-down to select a cloud credential. See screencap.

Another Oracle maintainer issue - https://github.com/rancher/dashboard/issues/3660#issuecomment-893105294

We don't maintain this driver


[CLOSED] Remove complexity from wiring

 Issue by kalleth
Tuesday 17 June 2014 at 13:04 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/121

Using simpler patterns (i.e. dependency injection) and by moving inline several definitions that were only used once, we can simplify the Specialist Publisher Wiring class.

kalleth included the following code: https://github.com/alphagov/specialist-publisher/pull/121/commits

 Comment by evilstreak
Thursday 19 June 2014 at 08:31 GMT

Closing for now


[WIP] Added --include and --exclude options to format tool

Solves #3267 by adding --include and --exclude options to ´tool format. exclude is by default populated with lib, so that files in ./lib folder will not be formatted. This can be enabled by providing --include lib as commandline option.

There are still a few questions about this:

Should it be possible to specify absolute paths? Like crystal tool format --exclude /path/to/pwd/exclude_dir. If yes, normalization should turn every path into an absolute one with File.real_path
Should globs be supported? This would enable e.g. to exclude all lib files from samples (which might be using their own shard dependencies) with samples/*/lib.

I like the idea, this is good improvement over what we have. Let's KISS and have another PR for the remaining questions.


As a dev, I want to fix the swagger on the deployment

Description
Bug Summary:
On the deployed fertiscan-backend, the swagger is not functional
Steps to Reproduce:
https://fertiscan.inspection.alpha.canada.ca/api/apidocs
Expected Behavior:
Should display the swagger doc.
Actual Behavior:
Doesn't load the swagger.
Suggested Fix:
Check the root path where swagger is mounted.

https://stackoverflow.com/questions/61479914/swagger-change-base-url-in-python-using-flasgger-library
might be a solution


Support user defined field names

Add the argument for the object to set UseDefinedNamesInVariables to YES

Supported in v1.3.5. Test will be added in 1.4.0.


Ordering/Searching related model - WRONG DB TABLE

Summary of problem (with code snippets of problem)
I have User model which has the following relationship with the SupportLevel model:
    public function activeSupportLevel()
    {
        return $this->belongsTo(SupportLevel::class, 'support_level_id');
    }

In SupportLevel model I have specified DB table name and relationship with the User model:
protected $table = 'support_levels';

...

    public function users()
    {
        return $this->hasMany(User::class, 'support_level_id');
    }

In jQuery Datatables setup (in blade view) there is:
                columns: [
                    . . .
                    { data: 'active_support_level.name', name: 'active_support_level.name', responsivePriority: 1},
                    . . .
                ],

Finally, there is UserController@process:
    public function process()
    {
        $users = User::select('users.*')->with(['activeSupportLevel', 'status', 'market']);

        return Datatables::of($users)
            ->editColumn('username', function ($user) {
                return "id}'>{$user->username}";
            })
            ->editColumn('created_at', function ($user) {
                return format_datetime($user->created_at);
            })
            ->rawColumns(['username'])
            ->make(true);
    }

Everything is loaded and displayed OK, without any errors but when I try to "order" by the "Active Support Level" column - I am getting the following error:

As you can see - it tries to order by active_support_level.name, but that table does not exists. The table should be support_levels as it is specified in the SupportLevel model:
protected $table = 'support_levels';

... but it is ignored.
System details

Operating System: Ubuntu 16.04 (Laravel Homestead)
PHP Version PHP 7.1 (Laravel Homestead)
Laravel Version 5.4
Laravel-Datatables Version 8.4.1

I think on columns, you should use the function name of the relation.
 { data: 'active_support_level.name', name: 'activeSupportLevel.name', responsivePriority: 1},


NPM with GeoLite2 not working

Hello,
I am new on GoAccess. I need it for control my geoblocking with NPM.
I have installed NPM like here https://www.reddit.com/r/nginxproxymanager/comments/sjf1hw/tutorial_nginx_proxy_manager_together_with_geoip2/
The log is
log_format proxy_geo escape=json '[$time_local] [Client $remote_addr] [$allowed_country $geoip2_data_country_code $geoip2_data_country_name $geoip2_data_region_name $geoip2_data_city_name] "$http_user_agent" '
                             '$upstream_cache_status $upstream_status $status - $request_method $scheme $host "$request_uri" [Length $body_bytes_sent] [Gzip $gzip_ratio] [Sent-to $server] "$http_referer"';

In NPM I have following logs:
108 -rw-r--r-- 1 root root 105663 Mär  6 08:50 proxy-host-1_access-geo.log
728 -rw-r--r-- 1 root root 741086 Mär  6 08:50 proxy-host-1_access.log
  4 -rw-r--r-- 1 root root    630 Mär  6 07:31 proxy-host-1_error.log
 12 -rw-r--r-- 1 root root  11002 Mär  6 08:28 proxy-host-2_access.log
  8 -rw-r--r-- 1 root root   6169 Mär  6 08:28 proxy-host-2_error.log
  0 -rw-r--r-- 1 root root      0 Jan 22 10:16 proxy-host-3_access.log
  0 -rw-r--r-- 1 root root      0 Jan 22 10:16 proxy-host-3_error.log

I have installed your docker - but the log say following:
==26== FILE: /opt/log/proxy-host-1_access-geo.log
==26== Parsed 10 lines producing the following errors:
==26==
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26== Token '[yes' doesn't match specifier '%s'
==26==
==26== Format Errors - Verify your log/date/time format

How can I use it?
proxy-host-1_access-geo.log
proxy-host-1_access.log

Thanks for the information. I'll take a look at it.

Here my Solution - now it works
docker-compose.yml
version: '3.3'
services:
    goaccess:
        image: 'xavierh/goaccess-for-nginxproxymanager:latest'
        container_name: goaccess
        restart: always
        ports:
            - '7890:7890'
        environment:
            - TZ=Europe/Berlin
            - SKIP_ARCHIVED_LOGS=False #optional
            - DEBUG=False #optional
            - BASIC_AUTH=False #optional
            - BASIC_AUTH_USERNAME=user #optional
            - BASIC_AUTH_PASSWORD=pass #optional
            - EXCLUDE_IPS=<IP_ADDRESS> #optional - comma delimited
            - LOG_TYPE=CUSTOM #optional - more information below
        volumes:
        - ~/npm/data/logs:/opt/log
        - ./custom:/opt/custom #optional, required if using log_type = CUSTOM

custom/goaccess.conf
real-time-html true
log-file /opt/log/proxy-host-1_access-geo.log
output /var/www/html/index.html

date-format %d/%b/%Y
time-format %T
log-format [%d:%t %^] [%^ %h] [%^ %e] "%u"  %^ %s %^ %m %^ %v "%U" [%^ %b] [%^] [%^] [%^] "%R"


Bug: Code block breaks list

Description
When inserting a code block within a list item, the code block is treated as a separate element, breaking the list. The expectation is for the code block to be part of the list item, allowing the list to continue seamlessly after the code block.
It may be an intentional behavior. Is there a way to work it around?
Lexical version: 0.11.3
Steps to Reproduce

Open the RTE.
Start a numbered or bullet list.
Insert a code block within a list item.

Link to code example:
Please see the behavior by trying it in the Lexical playground: Lexical Playground
The current behavior
Inserting a code block while editing a list item causes the list to break. The code block appears as a separate block element outside of the list context.

Expected Behavior
When a code block is inserted into a list item, it should be displayed as part of that item, indented accordingly, and not disrupt the list flow. The list numbering or bullets should continue after the code block as if it were part of the text in the list item.

There are plans to support custom schemas in the future, but for now there's no way to support the behaviour that you want.

@moy2010, thanks for the answer!

yes, I have a similar problem

Has anyone found workarounds? It's a crucial functionality for my users.


Improve the way login errors are generated

This way of displaying errors means that 1) every error will be displayed if there are mulitple and
2) the errors that are generated have links

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   99.55%   99.55%
=======================================
  Files          24       24
  Lines         446      446
=======================================
  Hits          444      444
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d698e...61acac5. Read the comment docs.


Spelling correction in comment

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Pester test is included
[X] Help & other text grammar, spelling & style cleanup

Purpose

Just fixing spelling in the PR template

Looks like the appveyor environment is wonky.

yeah, we're working on it, you can ignore - i check manually for unexpected fails


update recipes for deepstream 6.4

Add the following line into conf/local.conf

CORE_IMAGE_BASE_INSTALL:append = " deepstream-tests deepstream-6.4 deepstream-6.4-pyds"

I've merged this manually, after a couple of tweaks to get rid of the mdns dependency and to clean up the Azure IOT bits.


[TASK] Move longhorn/spdk to rancher/spdk before v1.7.0-rc2

What's the task? Please describe
To follow the CNCF license policy, we need to move longhorn/spdk to rancher/spdk before v1.7.0-rc2.
The task is currently blocked by https://github.com/rancherlabs/eio/issues/2460.
After the migration, the longhorn/spdk will be removed. All Longhorn components using longhorn/spdk need updates.
Describe the sub-tasks

Additional context

cc @innobead @DamiaSan @shuo-wu

SPDK should be fine. Let's move out samba and nfs-ganesha as per CNCf suggested.

Close because the task is finished.


[FormControl] Integrate FormControl with input components

Motivation
To be able to easily compose different kinds of (higher level) form fields with consistent interaction states using Base components/hooks,
Currently, only the Input component is supported (doc).
<FormControlUnstyled defaultValue="" required>
  <Label>Name</Label>
  <Input />
  <HelperText />
</FormControlUnstyled>

But that <Input /> could just as well be an Autocomplete or a Switch.
Requirements
1. Consistent interface for getting a value from any form component

Currently FormControl accepts an onChange prop that gets an event as the sole argument
This works for getting the value from a basic Input using event.target.value, but doesn't work for cases like multi-select or Autocomplete with multiple options
It could updated to provide the latest value as a second argument like: onChange: (event: React.SyntheticEvent, newValue: any) => void

Some components already have this second argument:

useAutocomplete: onChange?: (event: React.SyntheticEvent, value: AutocompleteValue<T, Multiple, DisableClearable, FreeSolo>, reason: AutocompleteChangeReason, details?: AutocompleteChangeDetails<T>) => void
useSlider: onChange?: (event: Event, value: number | number[], activeThumb: number) => void
useSelect: onChange?: (   event: React.MouseEvent | React.KeyboardEvent | React.FocusEvent | null,   value: SelectValue<OptionValue, Multiple>, ) => void
useNumberInput

2. Additional metadata
Some components call onChange with "metadata" arguments:

Autocomplete: reason, details
Slider: activeThumb

Perhaps a general metadata object can be used as the third argument, e.g. onChange: (event, newValue, metadata).
Components

[ ] Input
[ ] Select https://github.com/mui/base-ui/issues/12
[ ] Slider
[ ] Switch https://github.com/mui/base-ui/issues/13
[ ] Autocomplete
[ ] TextareaAutosize
[ ] NumberInput

The FormControl has been superseded by Form and Field components.


Warnings in tests

Sometimes there is devide by zero warnings in the tests, which is as intended. I will take a closer look at all of them and silence them with care.

@malmans2 If the code is running correctly, there should be divide by zero warnings from place to place. Do you think it is acceptable to silence all of them in the tests?

I would avoid it. You have a few of that warnings, but they are not that many.
Use assert as much as possible for warnings that you fully understand, filter the other warnings but not globally (e.g., use the decorator).
Assert is better because if you expect the warning but it won't show up in the future, you know that something is not right. And if you'll get the zero division warning in a function where you don't expect it, you'll notice right away.

close with #58


Coderodent/multiple attack

Added the multiple attack control panel: leverages the Action-Maneuver-Attack code
select multiple targets and choose the multiple attack option.
Includes ending multiple attacks on cancel or miss.
TODO: end cost on miss not implemented yet

I just realized there's a bunch of console.log in here; I better pull them out

You have reminded me that there is still the DCV adjust to take care of and some other odd-n-ends that I should look at before merge.

I'm going to remove the logs and put in the 1/2 DCV before this can be considered finished.


C3D training from scratch met RuntimeError: CUDNN_STATUS_EXECUTION_FAILED

Hello @jfzhang95 , thanks for your code firstly.
I'm trying to train C3D from scratch on my own ucf101 style dataset.
I changed ucf101 config from 101 to 2 & num_workers=1 in train.py and dataset path in mypath.py, except mentioned above I didn't change any other settings.
When I run 'python train.py', I got this runtime error and don't know what happened.
Traceback (most recent call last):
File "C:/Users/google/Desktop/pytorch-video-recognition-master/train.py", line 203, in
train_model()
File "C:/Users/google/Desktop/pytorch-video-recognition-master/train.py", line 131, in train_model
outputs = model(inputs)
File "D:\Anaconda3\envs\video\lib\site-packages\torch\nn\modules\module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "C:\Users\google\Desktop\pytorch-video-recognition-master\network\C3D_model.py", line 46, in forward
x = self.relu(self.conv1(x))
File "D:\Anaconda3\envs\video\lib\site-packages\torch\nn\modules\module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "D:\Anaconda3\envs\video\lib\site-packages\torch\nn\modules\conv.py", line 421, in forward
self.padding, self.dilation, self.groups)
RuntimeError: CUDNN_STATUS_EXECUTION_FAILED

The env is win10 cuda9 torch0.4.0, I'm not sure if I should run this under linux.
Thanks if anyone can help.

cudann 7.6.1

Hi magsun,
Hope you have solved the error, but if not this might help you.
This error usually occurs when there is compatibility issue with the driver or with the cudnn and the pytorch.
Please refer here : https://discuss.pytorch.org/t/cudnn-error-cudnn-status-mapping-error/69079
for me by adding the line torch.backends.cudnn.enabled = False worked.
Thanks.

Hi magsun,
Hope you have solved the error, but if not this might help you.
This error usually occurs when there is compatibility issue with the driver or with the cudnn and the pytorch.
Please refer here : https://discuss.pytorch.org/t/cudnn-error-cudnn-status-mapping-error/69079
for me by adding the line torch.backends.cudnn.enabled = False worked.
Thanks.

Oh, thanks for your help, I tried another version of pytorch and it works.
I just use torch=0.4.1 instead of 0.4.0. I'll try it your way.
Thanks again!


Energizer Energy E12 !!! keymap not found

I was able to watch as mentioned in the readme. But no keys worked.
A firmware dump can be found here
Request: Is there a chance you can provide a small guide on how to extract the keymap for those who are interested in learning how this is done ?

Try unpacking the firmware using bzpwork or uniflash. And look in kern.bin for an array (40 16-bit values for SC6531) containing the characters "0123456789#*" and some others or 0xffff. That's a keymap.
I found it at offset 0x4bee8, the first value is the boot key. I added it to releases as keymap_energizer_e12.bin.

There is a filter to automatically find the keymap, but it only works if the layout is in the uncompressed part of the firmware (kern.bin is in the compressed part). Also, some firmwares contain malformed keymaps with duplicate or junk values, so this filter cannot find them in such cases.

Is the LCD detected on your phone? LCD: id = 0x in the log.

Something I noticed is in common in all of the keymaps in releases is that they all end with 8 sets of ffff (in hex). Is that a rule ?

This isn't a rule, but a common situation.

Try unpacking the firmware using bzpwork or uniflash. And look in kern.bin for an array (40 16-bit values for SC6531E) containing the characters<PHONE_NUMBER>#* and some others or 0xffff. That's a keymap.
I found it at offset 0x4bee8, the first value is the boot key. I added it to releases as keymap_energizer_e12.bin.

Thank you !!

Is the LCD detected on your phone? LCD: id = 0x in the log.

It is detected.

I found it at offset 0x4bee8, the first value is the boot key. I added it to releases as keymap_energizer_e12.bin.

The readme does not provide instructions on how to use a keymap file though.

I recommend that you use the following options:
--rotate 3 --scaler 3 --keymap keymap_energizer_e12.bin
Or 1 for --rotate if you prefer keys on the left.

Can you provide a number for the list in the readme?

The boot key is number 1.
LCD: id = 0x009106
Chip: SC6531DA

If you want the entire log. You can find it here

Hmm, yes, but I wrote this in Releases:

Yes, I'm sorry.

I recommend that you use the following options:
--rotate 3 --scaler 3 --keymap keymap_energizer_e12.bin
Or 1 for --rotate if you prefer keys on the left.

The defaults worked perfectly fine. But I will try those in a sec.

Also, Thank you!

Well, somehow. The boot key only works when the battery is not plugged in. And it does not work without a battery. I had to follow your instructions in this related issue.
Welp, I guess some variations of the same chip can make a difference.

Then this is the first case of the SC6531E that won't boot without a battery.

I found it at offset 0x4bee8, the first value is the boot key. I added it to releases as keymap_energizer_e12.bin.

Can I ask you about that 0A at the end ? it did not appear in the kern.bin. I'm assuming that it does not matter what you put at the end. But I'm asking to make sure.


[Auto] Upgrade to twilio 6.9.0

This is an automated PR

Coverage remained the same at 100.0% when pulling a483cbe5e4c449b86f7424df4c4ffcbf6e79eee0 on auto into f983d76969d1782ab09ff75384eb75a51120acd4 on master.


[Playwright] desktop-layout-component.spec.ts test fails on mobile devices

Describe the bug
The playwright e2e test desktop-layout-component.spec.ts fails on mobile browsers such as Chrome and Safari. We don't see this failure in CI since mobile tests aren't run on CI yet.
To Reproduce
Steps to reproduce the behavior:

Run npx playwright test desktop-layout-component.spec.ts locally.
See error.

Expected behavior
The test should verify the correct conditions on mobile devices and pass accordingly.
Screenshots

Additional context
Parent issue: https://github.com/freeCodeCamp/freeCodeCamp/issues/52198

Creating this issue for documentation.
This issue has been resolved in PR https://github.com/freeCodeCamp/freeCodeCamp/pull/52439.