Code changes needed for initial release

Regarding the support for empty sgl, shouldn't we make a similar change to the postSend side too?

Regarding the support to register raw addresses.  Can you describe your use case briefly?

Thanks for reviewing, Patrick
Re "Regarding the support for empty sgl, shouldn't we make a similar change to the postSend side too?"
I agree, it is a valid use case for postSend(), we just didn't have the need for it. we can add it later.
Re "Regarding the support to register raw addresses.  Can you describe your use case briefly?"
The reason we had to introduce this change, is that so we can register addresses for mmap() files, which are intentionally not wrapped in ByteBuffers to reduce overhead.
Please note that this change doesn't expose any new vulnerability - the ability to register non-GC'ed addresses is still there. E.g. user calls regMr with a proper ByteBuffer. regMr doesn't hold a ref to that ByteBuffer, and so if all refs are eliminated from that ByteBuffer, then at any minute the GC might release it.
That will result in seg fault or access violation.
In my opinion this is ok, whatever we decide to do, still this sort of issues can occur. Even if we take a ref on the ByteBuffer in regMr, then the user can cheat and provide a ByteBuffer with a wrong address that is set using reflection. Since this is a low-level library, I suppose it is ok to expose such vulnerabilities for the sake of performance.

Thanks for the comments:
Re "I agree, it is a valid use case for postSend(), we just didn't have the need for it. we can add it later."
Would prefer to add this to the send side rather sooner than later to keep things in sync. If you have time to add it that'd be great, otherwise let me know and I can also do it.
Re "addresses for mmap() .." We also pretty much work only with mmaped buffers in anything we implement on top of DiSNI because we want control over the page size (huge pages). We use MappedByteBuffer for this, which is extends ByteBuffer, that was no option for you?

Re "Since this is a low-level library, I suppose it is ok to expose such vulnerabilities "
Agree. On the other if we can avoid vulnerabilities without functionality loss that'd be even better. I'm wondering if it would make sense to keep a reference for every registered Buffer in DiSNI and then delete the ref again when unregistering. Wouldn't that solve the GC/seg fault issue?

Re postSend() - I agree that for completeness we should add that too, but that has to be tested first before suggesting the change, and that requires quite amount of work
Re MappedByteBuffer - we found that mapping the file with a raw pointer, rather than through MappedByteBuffer gives a slight performance improvement due to less overhead in GC, etc. In particular - it takes ages for GC to get the file unmapped once all refs are gone

Re MappedByteBuffer - Ok, I see. Here is what I suggest. We can add the the raw virtual address regMr feature to the DiSNI verbs level API, that is RdmaVerbs, IbvPd (with the corresponding Nat classes), but I'd prefer not to add this to the DiSNI RDMA Endpoint API (e.g., RdmaEndpoint). Going forward if we can maintain the philosophy where the raw DiSNI verbs API can have all sorts of performance features -- and possibly expose vulnerabilities -- but we keep the Endpoint API strict, then that's something that will work for me. Assuming you guys are not using the Endpoint API anyway, that might be ok I hope. What do you think?

Yes, I agree with this approach.
On Fri, May 19, 2017 at 11:32 PM, Patrick Stuedi<EMAIL_ADDRESS>wrote:

Re MappedByteBuffer - Ok, I see. Here is what I suggest. We can add the
the raw virtual address regMr feature to the DiSNI verbs level API, that is
RdmaVerbs, IbvPd (with the corresponding Nat classes), but I'd prefer not
to add this to the DiSNI RDMA Endpoint API (e.g., RdmaEndpoint). Going
forward if we can maintain the philosophy where the raw DiSNI verbs API can
have all sorts of performance features -- and possibly expose
vulnerabilities -- but we keep the Endpoint API strict, then that's
something that will work for me. Assuming you guys are not using the
Endpoint API anyway, that might be ok I hope. What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zrlio/disni/pull/4#issuecomment-302854576, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATIiBdD1QXo0tksEoFqhUf25OjaIBTAGks5r7okIgaJpZM4Nenk2
.


What do you do with RTTR?

I am curious to see where RTTR is used and what task are you solving with it?
Please post in which projects you are using it, closed or open source doesn't matter.
On which platform are you using it? What do you like about RTTR? What could be improved? What feature is missing?

I use it for general reflection in my project that I call Firestorm (repo is up on my github if anyone wants to take a look), where I modified the registration macros to make the registration logic scoped to each object I'm tying to the system. The downside is that I have to manually call the registration functions, but I've worked around it so that it's not as much of an issue. This arose because I separate my project into discrete static libraries that contain classes for each purpose (libUI will contain IMGUI integration, libIO wraps physics FS for file IO, libHarnessed has the test harness classes, etc...). Because the Visual Studio compiler likes to discard symbols and code that aren't actively used by the program, I was having problems with ensuring that objects were being registered when I needed their rttr::type to do some object construction.
One of the things I would like to see is the ability to pass construction policies into the rttr::type::make function so that I can decide at runtime how I want an object to be constructed and returned, rather than defining the policy in the reflection definition. It would be a huge boon and increase code clarity when so.eone goes to look at it, because the factory capabilities of rttr are very good. They could be even better this way.
Another potential issue I have is memory footprint. I did some memory profiling and a snapshot shows that there are some classes that could have their footprint reduced and in a library that relies on defining static data, care should definitely be taken when it comes to this. I'm going to be making a separate issue about this in particular, but I thought I'd mention it here.
All in all, it's a great multi-purpose reflection library that you can do a lot with. There are just a lot of rough edges and quirks that need to be worked around. I'll make issues about those quirks as I encounter them.

My plan is to use RTTR for some game tech as well. In particular to expose variables for tweaking, serialization and potentially exposing to script. At current, I am using imgui for the UI and cereal for serialization; and I need to manually expose my variables.
My current project is in production, so I would not jump on RTTR till the next one. For me, it needs to compile and work on consoles, which can be challenge. Adding attributes to variables, a bit like C#'s attributes would be fantastic, but I assume it could bloat the library quickly.

I took a deeper look and it the attributes (metadata) work well for me already. RTTR builds on both consoles that I am developing for. It also plays ok with cereal, but I would not mind having serialization straight in RTTR. Other than that, great job and I hope it stays alive for long time.

@enci If I may, which console platforms did you build for?

I would like to use rttr as reflection library for my game engine, my plan is to have loading/saving and usage into my ECS system (https://github.com/amerkoleci/alimer), will provide more info later.

Used throughout our 300K line application

wraps C++attribs/methods to expose to our internal scripting language
used to automate QT, around 90 panels and graphs
Called via python C API interface to run machine learning programs and user scripts
used in plugin dls

This Game Engine use RTTR
https://github.com/volcoma/EtherealEngine.git

Used throughout our 3,000 class, 300K line application

expose C++ ctors/attribs/methods and conversions to our scripting language
used to automate QT, around 90 panels and graphs
Called via python C API interface to run machine learning programs and user scripts
extend the python "c extension" via plugin dlls - load new C++ dls, and use RTTR instrumented C++ classes from python (no need for swig, boost python, C wrappers, etc)
"redirect" C++ wrapper classes to call RTTR instrumented "has a" member without any wrapper code (just a few lines)

The Python interface, python C extension for plugins, QT converter, and scripting lex/yacc/stack machine VM might be useful to upstream to RTTR.
Used in windows 32/64 with Visual Studio, and gcc/clang on Linux.
I like that we don't have to maintain our own ctor/prop/method wrappers any longer.
The type engine/inference is very useful, better than what we did - clever. RTTR type conversions were very necessary for our code base.
Compile times decline if too much RTTR is used. We had to remove ctors because the objects grew too large.
A clear way to associate "dirty" state with data would be useful.

Similar usage. Everything works. Just one drawback: building whole project on 4 cores takes 30 min.


Actions: More powerful macOS runners are now available for GitHub-hosted runners

Summary
GitHub-hosted macOS runners now provide more power and choice with the availability of larger macOS runners. Apple developers who need more power to reduce build times and increase velocity will have the hardware required to efficiently build, test, and deploy their software.

How will it work?
To get started using more powerful GitHub-hosted macOS runners, update the runs-on: key in your Actions workflow YAML to have those jobs target your larger runner. These larger mac instances are based on our current Intel powered machines. For more information about when Apple silicon will be made available in our GitHub-hosted mac runners see the related item elsewhere on the roadmap.

🚢 This has shipped: https://github.blog/changelog/2023-03-01-github-actions-introducing-the-new-more-powerful-github-hosted-x64-macos-runners


[WFLY-19036] Remove duplicated org.apache.kerby:kerb-server-api-all d…

…ependency
Jira issue: https://issues.redhat.com/browse/WFLY-19036

Thanks @yersan and @fjuma


rust 1.54.0 build error with isahc version 1.4.0

~ cargo build
error[E0124]: field `timeout` is already declared
  --> /Users/baoyachi/.cargo/registry/src/github.com-1ecc6299db9ec823/isahc-1.4.0/src/config/request.rs:30:17
   |
30 |                   pub(crate) $field: $t,
   |                   ^^^^^^^^^^^^^^^^^^^^^
   |                   |
   |                   field already declared
   |                   `timeout` first declared here
...
64 | / define_request_config! {
65 | |     // Used by curl
66 | |     timeout: Option<Duration>,
67 | |     timeout: Option<Duration>,
...  |
94 | |     title_case_headers: Option<bool>,
95 | | }
   | |_- in this macro invocation
   |
   = note: this error originates in the macro `define_request_config` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0025]: field `timeout` bound multiple times in the pattern
  --> /Users/baoyachi/.cargo/registry/src/github.com-1ecc6299db9ec823/isahc-1.4.0/src/config/request.rs:30:17
   |
30 |                   pub(crate) $field: $t,
   |                   ^^^^^^^^^^^^^^^^^^^^^
   |                   |
   |                   multiple uses of `timeout` in pattern
   |                   first use of `timeout`
...
64 | / define_request_config! {
65 | |     // Used by curl
66 | |     timeout: Option<Duration>,
67 | |     timeout: Option<Duration>,
...  |
94 | |     title_case_headers: Option<bool>,
95 | | }
   | |_- in this macro invocation
   |
   = note: this error originates in the derive macro `Clone` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0062]: field `timeout` specified more than once
  --> /Users/baoyachi/.cargo/registry/src/github.com-1ecc6299db9ec823/isahc-1.4.0/src/config/request.rs:30:17
   |
30 |                 pub(crate) $field: $t,
   |                 ^^^^^^^^^^^^^^^^^^^^^
   |                 |
   |                 used more than once
   |                 first use of `timeout`

error[E0025]: field `timeout` bound multiple times in the pattern
  --> /Users/baoyachi/.cargo/registry/src/github.com-1ecc6299db9ec823/isahc-1.4.0/src/config/request.rs:30:17
   |
30 |                   pub(crate) $field: $t,
   |                   ^^^^^^^^^^^^^^^^^^^^^
   |                   |
   |                   multiple uses of `timeout` in pattern
   |                   first use of `timeout`
...
64 | / define_request_config! {
65 | |     // Used by curl
66 | |     timeout: Option<Duration>,
67 | |     timeout: Option<Duration>,
...  |
94 | |     title_case_headers: Option<bool>,
95 | | }
   | |_- in this macro invocation
   |
   = note: this error originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0062]: field `timeout` specified more than once
  --> /Users/baoyachi/.cargo/registry/src/github.com-1ecc6299db9ec823/isahc-1.4.0/src/config/request.rs:30:17
   |
30 |                 pub(crate) $field: $t,
   |                 ^^^^^^^^^^^^^^^^^^^^^
   |                 |
   |                 used more than once
   |                 first use of `timeout`

error: aborting due to 5 previous errors

Some errors have detailed explanations: E0025, E0062, E0124.
For more information about an error, try `rustc --explain E0025`.
error: could not compile `isahc`

Hmm, I can't reproduce this with Isahc 1.4.0, using Rust 1.54.0. This part of the error message is curious:
64 | / define_request_config! {
65 | |     // Used by curl
66 | |     timeout: Option<Duration>,
67 | |     timeout: Option<Duration>,
...  |
94 | |     title_case_headers: Option<bool>,
95 | | }
   | |_- in this macro invocation

because that is not what the source code of request.rs lines 64-67 look like: https://github.com/sagebind/isahc/blob/1.4.0/src/config/request.rs#L64-L67
define_request_config! {
    // Used by curl
    timeout: Option<Duration>,
    connect_timeout: Option<Duration>,

Can you try running cargo clean and trying the build again? It seems like maybe connect_timeout got replaced with timeout somewhere between downloading the crate and building it.


Errors & Omissions

This article has the following flaws:

It does not state anything about the all important CEF Header, “CEF:Version|Device Vendor|Device Product|Device Version|SignatureID|Name|Severity|Extension”. So it of course fails to make the point that the header is hierarchal from left to right.
It then fails to state what the CEF header “SignatureID” field maps to. In figure 1 the mapping table calls out CEF Standard Key “DeviceEventClassID” which does not seem to exist in the CEF standard. It does correctly map CEF Standard Key “Name” to Activity.

This is the link to the CEF standard: https://kc.mcafee.com/resources/sites/MCAFEE/content/live/CORP_KNOWLEDGEBASE/78000/KB78712/en_US/CEF_White_Paper_20100722.pdf
I can only guess that this misunderstanding has lead to directions in Sentinel that call for the hierarchal order of the header to be disregarded when implementing the Microsoft Azure Sentinel - Palo Alto NGFW data connector.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 34e19f18-b108-2702-eac9-86ed2f1b0e82
Version Independent ID: b2d206e7-61cf-781b-1d8a-6ff4e6116233
Content: Common Event Format (CEF) key and CommonSecurityLog field mapping
Content Source: articles/sentinel/cef-name-mapping.md
Service: microsoft-sentinel
Sub-service: microsoft-sentinel
GitHub Login: @batamig
Microsoft Alias: bagol

Hi @lospinoj, thanks for writing into docs!
I'm tagging a current content owner. @yelevin, can you address this item? Thanks

Thanks All.

#please-close


[pulsar-io] Specify the RabbitMQSink type as Bytes by default

Motivation
This PR is similar to #3972.
Modifications
Modify RabbitMQSink to use Bytes instead of no specific type.

run cpp tests


Fork Notice - Non-Issue

Hey! Just wanted to let you know since this had an MIT License that I forked this repository and created an Alexa Skill that delivers Shannonisms. I gave credit to the web page for the quotes in the Skill description. If you want to check it out, you can search for "Moon Man STL" in the Alexa companion app or if you have an Alexa/Echo device, just say "Open Moon Man".
I'd appreciate any feedback you have to provide, and I'll put up my Skill code on my fork as soon as I can. The skill went live (Today) a lot faster than I anticipated so I apologize I didn't inform you sooner. If you have an issue with this just let me know and I'll work it out with you as I did this just as a fun project and don't expect any monetization to come out of it. I'm incredibly grateful for the data you provided here.

Thanks for the heads up! I'm excited to add the skill to my Alexa. No issues from my side. Glad the data came in useful.

👍 👍 👍


Include referrer from posted params if present

For: https://trello.com/c/I6aN5mDJ/230-add-full-referrer-value-in-feedex
The forms in frontend that are used to submit service feedback have the
referrer stored in a hidden field added by JS with the name referrer.
It is not present in the service_feedback params which all our existing
tests assumed.  The outcome of this is that none of the submitted service
feedback has a useful referrer value stored; it's either nil, or since
we merged #206, filled in with the request referer value which will be the
page that the service feedback form was presented on.  That's not a useful
value for the referrer in these cases because we know what page the form
is on, it's the /done page - we want to know where they came from before
they got to the /done page.
We change the contact controller to fetch the referrer from either the
service_feedback hash, or the posted params, or the request.referer (in
that order of preference).

@elenatanasoiu - yup it's a fallback which will be /done/whatever for service feedback tickets, but not all the tickets that are submitted to feedback are from done pages, so sometimes the request.referrer is going to be useful.  For example the form for problem reports is on every page (living under the Is there anything wrong with this page? link), so the request.referrer is a valuable thing in those cases (and that form doesn't submit a referrer param either in the problem_reports hash, or as a "bare" param).


update for latest nightly that changes integer_atomics

Looks like integer_atomics was stabilized, and the feature was removed. Also, there is a newly-preferred way of initializing an atomic integer, so I changed it to that.

Thanks!


Enable gemv schedule for adreno

Enabled new gemv schedule for opencl target, which effectively improves decode performance of mlc-llm LLM models with q4f16_0 format.
Few LLM models Decode performance on Snapdragon Gen-3 android.
Models         Baseline       Latest improved
Llama-2-7B       10 tok/sec       12.5 tok/sec
Qwen-7b          8.5 tok/sec      11 tok/sec

@srkreddy1238 @tqchen : Can you please take a look in this PR

Thanks @krishnaraj36 for the great PR and significant perf improvement.
However, q4f16_0 should be outer_reduction as the layout is KN. I wonder why the rule is named as sch_adreno_inner_reduction

Thanks @krishnaraj36 for the great PR and significant perf improvement.
However, q4f16_0 should be outer_reduction as the layout is KN. I wonder why the rule is named as sch_adreno_inner_reduction
If it's a naming issue, we can replace the current rule of sch_outer_reduction as it is specially designed for android only

Thanks for your review.
Yes, Its naming issue, I have made changes to func naming to make sense.


error decoding JSON

Hello i have done all the steps that you mention on the readme.
I receive something (i see this on discover kibana)

but it was like a json problem (log sent from my server (modsecurity_log)??

Hello,
From logs it seems that you must enable JSON output for logs at first.
e.g.
SecAuditLogFormat       JSON


added X.diag(k, ...) where type(X) in {Vector, Matrix}

Fixes #158
Feel free to edit code in this PR if anything is amiss.

Cool, thanks for working on this @ParticularMiner!
Could you edit your initial comment to say e.g. "Fixes #158"?  With such a comment, GitHub is smart enough that it will close that issue when we merge this PR (it's also good practice to link PRs to existing issues if appropriate).
Also, I would expect this to call GrB_Matrix_diag.  This shouldn't call functions in .ss namespaces.
Apparently, the GraphBLAS spec only added the ability to assign a vector to the diagonal of a matrix.  I don't see any function to go the other way around.  Weird.
We currently have the following (which also have k=0 optional argument):

my_vector.ss.diag(matrix): extract the diagonal of a matrix and assign it to my_vector discarding existing entries.
my_matrix.ss.diag(vector): assign values of vector to the diagonal of my_matrix and discard existing entries.
grblas.ss.diag(x): create a new vector or matrix depending on input type; "just works".

So, in typical GraphBLAS style, it's kind of weird that the API needs an already existing output object.  The third option above, grblas.ss.diag(x) is the most natural for most use cases.  So, for "GrB diag", I propose the following:

my_matrix.build_diag(vector): like the existing my_matrix.ss.diag(vector)
my_vector.diag(): creates a new Matrix with the diagonal set with my_vector.

This should probably accept optional name=, dtype=, nrows=, and ncols= arguments (where min(nrows, ncols) == my_vector.size)

If we do this, then it probably makes sense to rename my_matrix.ss.diag to my_matrix.ss.build_diag to match, and add my_matrix.ss.diag that creates a new Vector.  We should do the same for my_vector.ss as well.

Oh man, I should look at docs before I write.  So, looking at the C API spec here https://graphblas.org/docs/GraphBLAS_API_C_v2.0.0.pdf it appears there are two main differences between GrB_Matrix_diag and GxB_Matrix_diag:

GrB_Matrix_diag creates a new, square matrix (if a non-square result is desired, I guess do resize afterwards)
GxB_Matrix_diag accepts a descriptor

Surprisingly, SuiteSparse:GraphBLAS doesn't currently do the first.  The first argument is supposed to be a pointer to a GrB_Matrix, but SuiteSparse:GraphBLAS doesn't pass a pointer.  Hmph.  I guess this changes the API we should target.
Also, CC @jim22k for API review of GrB functions.  So, I guess we have a single function that accepts a Vector and creates a square Matrix.  Three options:

A = my_vector.diag(k)
A = Matrix.diag(v, k)
A = grblas.diag(v, k)

I vote for 1.

Thank you @eriknw for your attention to detail!  I've removed the spec: A.diag(...) for Matrix A and put an informative error in its place.
We can sort out the issues with GrB_Matrix_diag() vs. GxB_Matrix_diag() later when we get more information.

Three options:

A = my_vector.diag(k)
A = Matrix.diag(v, k)
A = grblas.diag(v, k)

I like 1 and 3. 2 is definitely out. I would instead change 2 to be A = Matrix.from_diag(v, k). That would be acceptable to me.
As far as the spec only covering Vector->Matrix diagonals, I think we should also handle Matrix->Vector. grblas should always be a superset of the existing functionality declared in the spec, as long as there are extension methods or recipes that we can target. We already do this with extract_row, which is just extract_column with a transpose bit set. For the Matrix->Vector recipe, we could select with GrB_DIAG, then reduce to vector with any monoid.

Thanks for the feedback @jim22k !  Yeah, good point about being able to make a GrB-only recipe for taking the diagonal of a Matrix (once we have select).  This is probably why it's not in the spec as a separate method.
So, +1 for:

my_matrix.diag(k) -> Vector
my_vector.diag(k) -> Matrix

These should both call self.ss.diag for now (probably).
Regarding grblas.diag, we don't yet have any top-level functions like this.  I'm hesitant to put it in the top-level namespace, because there's likely going to be pressure to add even more functions similar to this, and I don't like things getting too cluttered.  Like gb.ss.diag, I think we could have other namespace(s) for e.g. gb.xxx.diag.  I don't know what we would call it.  gb.grb.diag? gb.utils.diag? gb.funcs.diag? gb.core.diag?  We already put gb.io functions in their own namespace.  On the other hand, maybe there won't be that many top-level functions such as this.  gb.ss only has two: diag and concat.  concat is pretty handy--we could make grb-only recipes for it too.

All this code is already part of PR #188, so closing.


allow scikit-image 0.20 as well

closes #531
Given that scikit-image 0.20 has now been released and we have updated to match its API, we need to remove the version constraint preventing it from being installed.

corresponding integration repository PR has been merged: https://github.com/rapidsai/integration/pull/634

/merge

Do I need an ops override to merge since the branch check fails?

Thanks all! 🙏


feat: deprecate watchExclude

Description
We had to disable fs cached checks when custom server.watch.ignored patterns are present because Vitest has watchExclude with a default of **/dist/** (not using outDir from the project but harcoded dist):

https://github.com/vitejs/vite/pull/15828

This gets in the way of some e2e SSR setups in Vite core and the main vite plugins (react, vue, svelte). My take is that these setups shouldn't have worked and we should enable fs cached checks all the time at one point. But it was a bit too breaking for Vite 5.1
We should align watchExclude with Vite core server.watch.ignored. We already started to ignore outDir for example, and node_modules should already be ignored before.
This PR deprecates the option for now, so later on it can be removed. Users are instructed to use server.watch.ignored.
We were wondering why this option was added in the first place and maybe the reason is DX of the options as server.watch.ignored may not be as clear as watchExclude. I think maybe it will depend on how much this feature is used. If it isn't extremely common, I think aligning with Vite is better here. If not, we would need to device a way to change the default to be undefined so the regular ignored values in Vite core kicks in.

I think it's not common enough to justify its existence. Since it's just an alias for server.watch.ignored, I think it's safe to remove it in the next major after the depreciation period.

Lint is failing 👀

Running pnpm run lint locally gives me nothing. No idea why it is complaining.

Running pnpm run lint locally gives me nothing. No idea why it is complaining.

You probably have a space at the end of the line that you added


Many JUnit 4 tests not executed

Current 'master' branch contains many tests that should fail, but don't because they are not executed:
:pact-jvm-server:test
:pact-specification-test:test
:provider:pact-jvm-provider-scalatest_2.12:test
:provider:pact-jvm-provider-scalasupport_2.12:test
:provider:pact-jvm-provider-specs2_2.12:test

This is because the code mixes JUnit 4 and JUnit 5 but not all subprojects have a dependency on JUnit Vintage runner.
To see the problem add
testRuntime "org.junit.vintage:junit-vintage-engine:${project.junit5Version}"

to dependencies in root build.gradle and execute gradle test --continue. Alternatively, update junit5Version to 5.4.2 in gradle.properties.
Something weird happens with pact-specification-test: it already has a dependency on junit-vintage-engine, tests are executed but nothing happens (the test report is empty). The problem is only visible after updating JUnit 5. I suppose old JUnit has a bug where an exception during test initialization does not fail the test. Tests in pact-specification-test would not even compile in a static language: they try to invoke a method that no longer exists in Message class.
I haven't checked which subprojects contain tests that are never executed currently but pass once they are executed - this would require more work than just running a Gradle build.

Well this is annoying. Thanks for reporting it. I've got all the tests passing expect for the Scala ones that don't work. I've just ignored those for now.


Remove region from url when computing url prefix

Overview
This PR fixes the url_prefix to remove the region from the URL when it's available, because a main use-case of this property is to prefix match against child stacks gathered from update events, where they arrive without the region in their URLs.
Testing/Steps taken to ensure quality
No tests added.
Notes
Solves #487
Testing Instructions
Testing the fix requires using doubly nested stacks to reproduce #487. Stacks that don't have nesting shouldn't see different behavior.

/do-e2e-tests


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Terraform
Module Classification?
Pattern Module
Module Name
terraform-azurerm-avm-ptn-hpc-slurm-ai
Module Details
Pattern module adapting code found in Jesse's blog entry - https://techcommunity.microsoft.com/t5/azure-high-performance-computing/training-large-ai-models-on-azure-using-cyclecloud-slurm/ba-p/3775454.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
jchancellor-ms
(Optional) Secondary Module Owner's GitHub Username (handle)
hannah-leland

@jchancellor-ms, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon.

Hi @jchancellor-ms,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

@mbilalamjad - I'm working with the HPC workloads team to see if they still want this module as they determine some functionality is already covered by AzHop project.

As per offline discussion, closing as @jchancellor-ms won't be proceeding forward on this for now and will re-open later as and when he is ready to proceed.


Override config file arguments from CLI

Hello and thank you for this wonderful product! I'm facing a problem, that i need to override at least the --directory from a command line even if this is already configured via the config file. Could you please make a CLI arguments a higher precedence over the config file?
Thanks and kind regards, Gena

Hi, yes this looks like a bug.. if you set the --config flag you can inspect the config that ws is using, e.g.
$ ws --port 8030 --config
{
  port: 8030,
  stack: MiddlewareStack(3) [ LwsAuth, Static ],
  view: CliView {}
}

Do you find that the --config output is correct but is not being respected? I imagine this is a quick fix, will look into it..

Fixed and released in local-web-server v5.4.0


[Automated] Updates for JSON payload

Automated changes by create-pull-request GitHub action

Testing PR


References to max clustered columstore rowgroup size of 1,024,576 rows is incorrect.

This page references a maximum rowgroup size of 1,024,576 rows. This is incorrect. The maximum rowgroup size for a clustered columnstore is 1,048,576 rows. It appears that this typo occurred because the minimum compressed rowgroup size is 102,400.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 773ed159-a586-0660-729b-c9b4cb249e48
Version Independent ID: 8a27afa6-4e12-2a63-b272-123108808479
Content: ALTER INDEX (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/alter-index-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @pmasl
Microsoft Alias: carlrab

Thanks for catching this.

@mortgagemetrix -- Tom, thank you again for your feedback.  I am looking into this topic as well.

@pmasl -- Pedro, please review private PR 14811.

This had already been fixed.


Add support for saswell sea801-z01

This device "_TZE200_c88teujp", "TS0601" was classified under MoesHY368 quirk wrongly, as the attributes are different. Added new classes for saswell, Note device does not report whether valve is open or closed, similar to other Tuya battery reporting is good or bad no in between. Also not nasty hack of SASWELL_STATE_ATTR and SASWELL_MODE_ATTR to same value to get buttons working on HA thermostat interface. Basic functionallity added here, turn on device to manual, off to off you can also set temperature setpoint, device also reports room temperature. More to add here later, possible to set to auto mode and remotely programme the schedule.

Pull Request Test Coverage Report for Build 513428693

22 of 60 (36.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 82.395%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/tuya/valve.py
22
60
36.67%

Totals

Change from base Build 512410068:
-0.7%

Covered Lines:
3309

Relevant Lines:
4016

💛  - Coveralls

Pull Request Test Coverage Report for Build 513428693

22 of 60 (36.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 82.395%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/tuya/valve.py
22
60
36.67%

Totals

Change from base Build 512410068:
-0.7%

Covered Lines:
3309

Relevant Lines:
4016

💛  - Coveralls

Codecov Report

Merging #751 (69a9ff2) into dev (9d9d6e7) will decrease coverage by 0.69%.
The diff coverage is 36.66%.

@@            Coverage Diff             @@
##              dev     #751      +/-   ##
==========================================
- Coverage   83.08%   82.39%   -0.70%
==========================================
  Files         176      176
  Lines        3956     4016      +60
==========================================
+ Hits         3287     3309      +22
- Misses        669      707      +38

Impacted Files
Coverage Δ

zhaquirks/tuya/valve.py
63.28% <36.66%> (-23.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9d6e7...69a9ff2. Read the comment docs.

Codecov Report

Merging #751 (69a9ff2) into dev (9d9d6e7) will decrease coverage by 0.69%.
The diff coverage is 36.66%.

@@            Coverage Diff             @@
##              dev     #751      +/-   ##
==========================================
- Coverage   83.08%   82.39%   -0.70%
==========================================
  Files         176      176
  Lines        3956     4016      +60
==========================================
+ Hits         3287     3309      +22
- Misses        669      707      +38

Impacted Files
Coverage Δ

zhaquirks/tuya/valve.py
63.28% <36.66%> (-23.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9d6e7...69a9ff2. Read the comment docs.

@ha-zig can you post your device signature for posterity here?
@fastcolors seems like you've added the same model in #710 Do we have two different devices with the exactly same model/manufacturer or does this new PR works good with your device?

@ha-zig can you post your device signature for posterity here?
@fastcolors seems like you've added the same model in #710 Do we have two different devices with the exactly same model/manufacturer or does this new PR works good with your device?

@fastcolors that patch does not work for me on, debug shows different attribs, device sig:
{
"node_descriptor": "NodeDescriptor(byte1=2, byte2=64, mac_capability_flags=128, manufacturer_code=4098, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=0)",
"endpoints": {
"1": {
"profile_id": 260,
"device_type": "0x0301",
"in_clusters": [
"0x0000",
"0x0001",
"0x0004",
"0x0005",
"0x0201",
"0x0204",
"0xef00"
],
"out_clusters": [
"0x000a",
"0x0019"
]
}
},
"manufacturer": "_TZE200_c88teujp",
"model": "TS0601",
"class": "zhaquirks.tuya.valve.SaswellSEA801"
}
example of valve
https://www.aliexpress.com/item/1005001774162057.html
changes work for me for basic functionality, device is slow to send updates after mode change (it will change straight away but wont send the mode change back often for upto a minute)

@fastcolors that patch does not work for me on, debug shows different attribs, device sig:
{
"node_descriptor": "NodeDescriptor(byte1=2, byte2=64, mac_capability_flags=128, manufacturer_code=4098, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=0)",
"endpoints": {
"1": {
"profile_id": 260,
"device_type": "0x0301",
"in_clusters": [
"0x0000",
"0x0001",
"0x0004",
"0x0005",
"0x0201",
"0x0204",
"0xef00"
],
"out_clusters": [
"0x000a",
"0x0019"
]
}
},
"manufacturer": "_TZE200_c88teujp",
"model": "TS0601",
"class": "zhaquirks.tuya.valve.SaswellSEA801"
}
example of valve
https://www.aliexpress.com/item/1005001774162057.html
changes work for me for basic functionality, device is slow to send updates after mode change (it will change straight away but wont send the mode change back often for upto a minute)

The timing problem you can very likely fixing with this: https://github.com/zigpy/zha-device-handlers/pull/726#issuecomment-767589485 and the comment a above it.

The timing problem you can very likely fixing with this: https://github.com/zigpy/zha-device-handlers/pull/726#issuecomment-767589485 and the comment a above it.

@Adminiuga I have trying doing one matrix in the Wiki https://github.com/zigpy/zigpy/discussions/653#discussioncomment-314395 and its looks being OK then following the commits backwards. I think  its easier than having pictures for the user saying its right or not (some is working OK with wrong quirk and can throwing errors but working).

@Adminiuga I have trying doing one matrix in the Wiki https://github.com/zigpy/zigpy/discussions/653#discussioncomment-314395 and its looks being OK then following the commits backwards. I think  its easier than having pictures for the user saying its right or not (some is working OK with wrong quirk and can throwing errors but working).

Unless there are different models with the same model/manufacturer and two users report conflicting data.

Unless there are different models with the same model/manufacturer and two users report conflicting data.

@Adminiuga     This is being one big MESS !!
The MoesHY368 was working but luck of futures and being updated PR #726  is waiting and ("_TZE200_ckud7u2l", "TS0601"), is one true MoesHY368 and being moved to the "new MoesHY368" in the PR #726 .
("_TZE200_kfvq6avy", "TS0601"), Revolt NX-4911 II and ("_TZE200_zivfvd7h", "TS0601"), Siterwell GS361A II was in the MoesHY368 because new zigbee module and was working but cant being moved to the "new MoesHY368" then its dont have all the extras the new inplanting so its being renamed in the same PR to Siterwell  II in the PR and the "old MoesHY368" away PR #726 .
This devises looks working but can complaining of time setting is not working.
("_TZE200_c88teujp", "TS0601"), Saswell SEA801 1 was also in the MoesHY368 but was working
bad PR #710 .
One new PR #751 is made and shall moving the fingerprint from the "old MoesHY368".
I have verified all IDs with deCONZ and Z2M and also with photos of devices that is verified by users having the devices.
Sorry for all the problems but then the "descrambling" is made all shall being in the right place.
That is missing is updating the original Siterwell that only having basic functions (not urgent but need being done).
And its also one or 2 uncommon models that i shall putting in the matrix with picture and information of providing issues for adding them with device signature that was the large problem then users have adding them without no information at all in the PRs (#710).
Mvh  Mattias

@Adminiuga     This is being one big MESS !!
The MoesHY368 was working but luck of futures and being updated PR #726  is waiting and ("_TZE200_ckud7u2l", "TS0601"), is one true MoesHY368 and being moved to the "new MoesHY368" in the PR #726 .
("_TZE200_kfvq6avy", "TS0601"), Revolt NX-4911 II and ("_TZE200_zivfvd7h", "TS0601"), Siterwell GS361A II was in the MoesHY368 because new zigbee module and was working but cant being moved to the "new MoesHY368" then its dont have all the extras the new inplanting so its being renamed in the same PR to Siterwell  II in the PR and the "old MoesHY368" away PR #726 .
This devises looks working but can complaining of time setting is not working.
("_TZE200_c88teujp", "TS0601"), Saswell SEA801 1 was also in the MoesHY368 but was working
bad PR #710 .
One new PR #751 is made and shall moving the fingerprint from the "old MoesHY368".
I have verified all IDs with deCONZ and Z2M and also with photos of devices that is verified by users having the devices.
Sorry for all the problems but then the "descrambling" is made all shall being in the right place.
That is missing is updating the original Siterwell that only having basic functions (not urgent but need being done).
And its also one or 2 uncommon models that i shall putting in the matrix with picture and information of providing issues for adding them with device signature that was the large problem then users have adding them without no information at all in the PRs (#710).
Mvh  Mattias

Needs a rebase

#576`removes need for this


L1/threadsafe GPIO

This may seem weird, but the idea behind this is that the GPIO would lock (or take a mutex) on a particular condition, like take mutex on LOW or take mutex on HIGH. This makes it a good candidate for being used for SPI transfers on the same bus. Then a threadsafe GPIO could be constructable within a L1/threadsafe-SPI object.

I'm on it.


Security

I want to configure a couple of users to run this.   What are the roles/duties/privileges required to create and post the new statement?
I cannot create the statement with the following roles assigned:

Accountant
Inventory Accountant
Logistics manager
Purchasing manager
Retail Catalog manager
Retail Service
Retail Store IT
Retail Store manager
Retail warehouse clerk
Sales manager
Shipping clerk
Shop supervisor

Am I missing something?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fac94d7-62cb-1f7b-de54-0694351d9a84
Version Independent ID: 31d65da1-60aa-3160-12a0-b080e4a439a7
Content: Create, calculate, and post statements for a retail store - Retail | Dynamics 365
Content Source: articles/retail/tasks/create-calculate-post-statement-retail-store.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @jashanno
Microsoft Alias: jashanno

Please use the "Retail operations manager" role to create & post Statements


Refactor make receipt control flow

What was wrong?
In fork.py's make_receipt, multiple if/return blocks are followed by an else
Related to Issue #
#874
How was it fixed?
Simple refactoring. Use if/elif/else flow
Cute Animal Picture

@richardgreg This needs to eventually be merged into master. So you could point the PR to master instead of cancun


Node TTL is way too long

Why does it store node data so long?
Do you have an opt out process?
Really is limited value to anything more than a day old.

Why does it store node data so long?

I was asked to open source it, so it was open sourced as is. Improvements will come over time :)
The reason it stores data for so long, or forever in this case, is that I hadn't implemented purging/clean up yet, and wanted all data as is during local dev/testing.

Do you have an opt out process?

Not yet, but I plan to add a dropdown or config so people can make their own mind up on what cut off is good for them in the UI.
I will probably also have a hard limit in the database, maybe 30 days or so, that way the db doesn't grow too large, but again, this could be in a config if you host the server yourself.

Really is limited value to anything more than a day old.

Some others may disagree, but the config idea is probably the best option to keep everyone happy.

The concern is privacy, when storing data that long you open yourself up to the GDPR and the project gets accused of leaking personal info to your map.

Privacy regulations such as GDPR are not actually relevant in this case as this is public data.
Meshtastic users have willingly, and by their own actions, set up a device that transmits data publicly. If those users don't want the data to be public, or wish the data to be treated in a specific manner, they should turn off their Meshtastic device and stop transmitting data publicly.
You can't broadcast data to someone without their consent, and then expect them to treat it in a certain manner. They haven't signed a privacy agreement with you.
Anyone can set up a device and record publicly available Meshtastic data. How long they store that data and what they do with it is up to them.
See GDPR Article 9(2)(e), sensitive personal data may be processed without consent if the data is manifestly made public by the data subject.
You may not see value in data older than 1 or 2 days, others may. The only way to please everyone is to provide this as a config option and you can configure it as you desire.

You are storing the data, I would check with a lawyer on both California and the GDPR when you are storing everything since you turned on the map.
Not one user has explicitly agreed to push their data to your map.
The project is asking you to not store data more than a couple of days.

There's also the difference between consenting to transmitting your data to the public in your own city where just users within say 100km can see it versus it being collected by a single person with MQTT enabled in region and making it accessible to the world. One single user at minimum shouldnt act as a gateway for the whole internet when there are benefits to making yourself visible to the your own community, whether it be helping to place your own nodes to fill in dead zones are just meeting local meshtastic users. Surely if someone hasn't flagged their packet for MQTT it shouldnt be relayed to the general internet.

Good points from all of you.
I will implement this as per my previous comment. There will be a configuration option available, and the publicly hosted version of the map will have a sane default, set to purge nodes etc that haven't been updated within that time frame.

The project is asking you to not store data more than a couple of days.

If the Meshtastic project is officially asking me to have the public map set to a couple of days, that can be done. However, for others that are running their own MQTT server to collect node information, such as node positions, waypoints and text messages, they should be able to retain this data for as long as they like. Hence this should be a configuration option.
I could set up hundreds of nodes all over the city, see them on the map, and if one of them were to have an issue and go offline for several days, it would be near impossible to know which node went offline and where it is, if the node just disappears from the map. Having the UI show a different colour icon for nodes that aren't heard from in a while would be a good indication of "this node needs attention, and here it is on the map".

Not one user has explicitly agreed to push their data to your map.

I think @b8b8 makes a good point on this in the quoted comment below;

If someone hasn't flagged their packet for MQTT it shouldnt be relayed to the general internet. That would be the explicit consent.

I guess it's the same thing, some users have not explicitly agreed to have their packets collected and transmitted to the public MQTT server on the internet if MQTT uplink is not enabled on the node that transmitted it. So I would say this should be updated in the firmware as well...
Anyway, I'll update the public map to purge older records automatically :)

The project is probably going to choose 24 or 48 hours.  There will be guidance coming soon.


NULL currently authenticated user in handle method of the queue

Laravel Version: 9.19
PHP Version: ^8.0.2
Database Driver & Version: phpMyAdmin 5.1.1

Description:
I noticed that when I try accessing the currently authenticated user in the __construct magic method everything goes well but, when trying to access it in the handle method, it returns NULL.

Are you sure user logged in?

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

@milwad-dev Yup, the currently authenticated user data returned on the __construct  method

@driesvints Sir, it's not a question, it's an issue because I've logged in and the authenticated user's data is back from the __construct method, but it returns NULL when trying to access it from the handle method.

You can make property in __construct and send auth user to property & use in handle :)!

@milwad-dev I know, I already do it but, it's still an issue.


(PUP-10021) Allow password change for disabled users

This commit enables puppet to change the passwords of disabled, locked
out and expired users.
Before this commit puppet will not change the password of
disabled,locked or expired users, even is this operation is supported in
windows.

Waiting for CLA signature by @Dorin-Pleava
@Dorin-Pleava - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

Agreed on Puppet.info. Seems more logical this way.


Defining Create with Typescript

First of all, thanks for creating this repo! I'm trying it out now.
I was wondering, how do you define "set" in typescript when creating the store? My original Zustand code used to look like this:
const useRoomState = create((set: SetState, get: GetState) => ({
...
But 'SetState' is not assignable with Zustand-addon's new create function. Any suggestions for what type to define set as?

You're welcome Paul, I'm glad you are trying this out.
The addons setState uses a union type. I forgot to export the types but you can do the following:
import { GetState, PartialState, SetState, State } from "zustand"
import create from "zustand-store-addons";

interface SetStateSettings {
  excludeFromLogs?: boolean | undefined;
  replace?: boolean | undefined;
}

declare type SetStateAddons<T extends State> = (
  partial: PartialState<T>,
  setSettings?: SetStateSettings
) => void;

type AppStore = {
  num: number;
  generate: () => void;
}

const useAppStore = create(
  (
    set: SetStateAddons<AppStore> | SetState<AppStore>,
    get: GetState<AppStore>
  ) => ({
    num:  0,
    generate: () =>
      set({
        num: Math.ceil(Math.random() * 100)
      })
  })
)

You can take a look at this example: https://codesandbox.io/s/zustand-store-addons-ts-example-4e6nc


[ISSUE #1664] add rabbitmq cloudevent and cloudevent writer

Fixes #1664.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mroccyen good job, do you have a test?

@mroccyen good job, do you have a test?

@qqeasonchen I am doing it.


Nunit3

Here are some changes for NUnit 3.0.1 (not backwards compatible).

NUnit 3 is pretty new and the change would break things for users of NUnit 2.x, right?
I think it would be better to provide two separate constraints assemblies.  Maybe make the constraints assembly use NUnit3 and add a new XMLUnit.NUnit2.Constraints assembly.
What do you think?

Sounds reasonable.

Do you want to modify the PR?

I can do so - just give me some time, not sure if I can do it tomorrow.


macOS: Sync actual window state after window show, and fix integration tests on macOS 13.1

What does the pull request do?
A customer was reporting a very hard to repro crash in their app on macOS that resulted in an error saying:
NSWindowStyleMaskFullScreen cleared on a window outside of a full screen transition.

Turns out that a native dependency of their app somehow changed macOS's behavior around fullscreen spaces, making any WindowState.Normal window be shown in a new fullscreen space. I have no idea what the mechanism for this behavior is. The fix however is simple, make sure _actualWindowState is read from the window after the window is shown.
Also had to fix the integration tests because it looks like on macOS 13.1 when a window becomes fullscreen, all other windows report an empty string as their window title via appium.

You can test this PR using the following package version. 11.0.999-cibuild0029398-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0029401-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Seems to have caused a problem whereby when a window has CanResize == false then showing the window causes it to be shown on the bottom left of the screen instead of the normal/requested position.


various stories & appbar adjustments

not ready

~not ready~ ok, please test with website also before merge

not able to test bcs the changes are on ur fork


Sort Dates via Selection Sort Algorithm

I am creating a pull request for...

[ ] New algorithm
[ ] Update to an algorithm
[ ] Fix an error
[ ] Other - Describe below

Sort Date via selection sort algorithm.


Added More Struct Info

thought id take a little time and label members in some classes
Affected Classes Were

HashedString: Changed Unkown to mLastMatch and set the type to a const HashedString*
MultiplayerServiceObserver: Changed Unknown to mpSubject  and added comments to hint at type
XboxLiveUserObserver: Changed Unkown to mpSubject and added comments to hint at type
CommandOriginIdentity: Changed Unknown1 to mXuid changed Unknown2 to mPlatformOnlineId
Packet

New Packet Structure:
class Packet {
public:
    virtual ~Packet() = default;

private:
    PacketPriority mPriority;                           // + 8
    NetworkPeer::Reliability mReliability;              // + 12
    SubClientId mSubClientId;                           // + 16
    bool mIsHandled;                                    // + 17
    NetworkPeer::PacketRecvTimepoint mReceiveTimepoint; // + 24
    void* mHandler;                                     // + 32
    Compressibility mCompressible;                      // + 40
};

Old Packet Structure:
class Packet {
public:
    virtual ~Packet() = default;

private:
    int unknown1_{2};           // +8
    int unknown2_{1};           // +12
    int unknown3_{0};           // +16
    std::int64_t unknown4_{0};  // +24
    std::int64_t unknown5_{0};  // +32
    int unknown6_{0};           // +40
};

New Types:

PacketPriority
NetworkPeer
NetworkPeer::Reliability
NetworkPeer::PacketRecvTimepoint
Compressibility

Great stuff! Thank you!

no problem. Wanted to do more but ran outta time


Multi entries bug when useRelativePath

Env

file-loader 1.1.5
Node.js 8.6.0
Webpack 3.8.1
macOS 10.12.6

Description
If multi entries imports the same file, and if their issuer contexts are different, and if useRelativePath is true, the compiled urls are wrong
Here's a test repo https://github.com/Cap32/file-loader-relative-path-bug

This is likely to be not fixable within file-loader, since the assets are deduped by webpack and whatever asset is being outputted may have the wrong path for an entry

@michael-ciniawsky let's leave open for tracking, i think it is fixable in loader

It is not fixable on file-loader side, sorry, avoid using useRelativePath it is not safe (and will be removed in next major release).


Fix bug where ECSTask could fail to stream logs

We were using the incorrect format for the log stream name. This worked by default since the value we were using (family name of "prefect") matched the value we should have been using (container name of "prefect"). When the family name differed, the log stream would be missing.
This fixes the key and adds best-effort testing around this case. Moto does not appear to support log events and I could not get a full test working. However, I did reproduce the previous failure so we at least have test coverage of that.
Closes https://github.com/PrefectHQ/prefect-aws/issues/177
Needs QA against a live service.
Checklist

[x] References any related issue by including "Closes #" or "Closes ".

If no issue exists and your change is not a small fix, please create an issue first.

[x] Includes tests or only affects documentation.
[x] Passes pre-commit checks.

Run pre-commit install && pre-commit run --all locally for formatting and linting.

[ ] Includes screenshots of documentation updates.

Run mkdocs serve view documentation locally.

[ ] Summarizes PR's changes in CHANGELOG.md

@anna-geller this should be reproducible by using a non-default family name — would you be willing to give it a QA? :)

Works and CloudWatch logs are there


Translating deploy-your-hello-world-api, initialize-the-backend-repo

Translating deploy-your-hello-world-api, initialize-the-backend-repo to ES

Thank you!

Thank you!


Photon support for code review

Enable the persistent volume usage for kubernetes running on Photon platform.
A following check-in for test files will be checked-in later.
a. Photon Controller is supported as cloud provider.
When choosing to use photon controller as a cloud provider, "--cloud-provider=photon --cloud-config=[path_to_config_file]" is required for kubelet/kube-controller-manager/kube-apiserver. The config file of Photon Controller should follow the following usage:
[Global]
target = http://[photon_controller_endpoint_IP]
ignoreCertificate = true
tenant = [tenant_name]
project = [project_name]
overrideIP = true

b. Photon persistent disk is supported as volume source/persistent volume source.
yaml usage:
volumes:
  - name: photon-storage-1
    photonPersistentDisk:
        pdID: "643ed4e2-3fcc-482b-96d0-12ff6cab2a69"

pdID is the persistent disk ID from Photon Controller.
c. Enable Photon Controller as volume provisioner.
yaml usage:
kind: StorageClass
apiVersion: storage.k8s.io/v1beta1
metadata:
  name: gold_sc
provisioner: kubernetes.io/photon-pd
parameters:
  flavor: persistent-disk-gold

The flavor "persistent-disk-gold" needs to be created by Photon platform admin before hand.

What is the authentication model followed here?
nit/nits:

We can split bringing in the vendor stuff as a separate commit, the other 2 breakdowns are perfect (cloud provider, generated code). I have in the past seen folks create a separate PR for just the vendor code, followed by the real code that depends on the vendor code. Alteast splitting the commits will reduce the effort needed for PR.
Question:
Where does the provisioner API get invoked? Via the node or the master?

@kerneltime
"Where does the provisioner API get invoked? Via the node or the master?"
It's via the master.

Updated to: https://github.com/vmware/kubernetes/pull/21


 However, it doesn't provide a way to create new processes inside the virtual desktop window. I hope you add the powertoy run bar to the original virtual desktop window. By using it, I can create processes or open my files in a more elegant way.
Thanks.

I just want to clarify, when you say virtual desktops, are you talking about https://support.microsoft.com/en-us/help/4028538/windows-10-multiple-desktops ?

exactly.

hi @dentistfrankchen, can you explain what you mean a little more. By create new processes, do you mean launching an app in a specific desktop?  are you not seeing PT Run on certain virtual desktops and only on the original?
Please share any screenshots / gifs that can further clarify

i have a pic in my attachment

i hope you can have a bar at the place of the orange box...when i type word in the bar and press enter, i will get a new window with that desktop...so i can preview all my windows and create new process at the same time.

hi @dentistfrankchen, can you explain what you mean a little more. By create new processes, do you mean launching an app in a specific desktop? are you not seeing PT Run on certain virtual desktops and only on the original?
Please share any screenshots / gifs that can further clarify

to your first question, yes. the second question...what does"PT" mean? i am little confused.

i suggest this because now i can not find a way to launch app under that view...i have to exit that view to launch apps, which is, to be frank, really dumb...

@dentistfrankchen i read this and trying to unpack the ask.  I swapped to a new VD and launched a process and it worked so i know this scenario currently works.
Is this the ask "PT Run search results, allow me to launch processes to targeted virtual desktops, or a new VD"?

Well now i use another way to switch between windows instead of by using task view, so this is currently not bothering me. However, I really appreciate your attention to my issue, and I hope the powertoy project would be better in the future.


the UI does not connect to the server

Hi everyone,
I am wondering, is there any way to check if the sockets on the server/UI receives and send the data, because when i run the server it's receive and send the just for one time and it's disconnect. And i do not know the reason behind this.
Thanks in advance for helping.

The progress i got so far is that the server catches the sockets for the interface and the chatbot returns the answers, but there's some thing prevent the server to send these answers to the interface.

Hi, I think your issue here is server side and not rasa webchat related. But please open a new issue if I'm wrong


Import page not working

Import page no longer works for me with most recent code.
If I click the import button I get this error & don't get to the bit where I can choose projects / pages:
Uncaught SyntaxError: Unexpected token in JSON at position 9637

Sorry i hadn't noticed Ron having the same error.
I think it may be caused by a project where some of the page titles have line breaks in them. I'll send you the json

Possible fix commited.


Add description how to rerun liccheck

Goals: why merge this PR?
The error message was not so clear after the liccheck failed.
I had to search first, who to run liccheck locally to identify the issue.
This PR should help to avoid the "search time".

closing this as change is outdated. we don't use pipenv anymore


Multi interface health

What does this PR (Pull Request) do?

[x] This PR fixes #4618

This removes the temporary shim "aggregate" interface used by Traffic Monitor - and Traffic Ops to a much lesser degree - and adds the ability to truly monitor cache servers according to both aggregate statistics as well as network interface thresholds.
Because interface stats now appear in cache stats TM API responses, this also introduces an equivalent to the stats query parameter used to filter general cache stats called interfaceStats.
This PR also properly wraps use of the Traffic Ops Go client in Traffic Monitor - for tasks requiring APIv3-format data (there are still some places where APIv2 is used explicitly) - such that if login fails with the current API version (3), login will be tried with the older version (2.0) and, if successful, all future requests will use API v2.0, coercing legacy data into modern structures as necessary - and there are unit tests for those coercions.
It also consolidates double-definitions of cache server interface information and IP address structures into one, and consequently moved some functionality between files as appropriate.
It also adds support for signed and unsigned integral values of cache statistics, which previously only allowed floating point-type numbers.
It also adds some table styling to the TM UI to fix error rows not highlighted in red - that's just a temporary, small workaround to ease testing of this PR, and a better fix is coming in #4746.
It also fixes a bug in a "CRConfig" Snapshot API unit test where the test was using servers without any IP addresses - it wasn't failing, but was merely not actually testing as much as it ought to have been.
It also fixes a bug when converting server interface data to the legacy format which would cause them to report an incorrect interface name under certain circumstances, adding a test.
It also fixes a bug parsing lib/go-tc.TMParameters structures from JSON with certain comparators in health thresholds, adding a test.
Finally, it also adds a load of GoDoc comments to objects that previously did not have them, and several tests for things that did not previously have those.
Which Traffic Control components are affected by this PR?

Documentation
Traffic Monitor
Traffic Ops

What is the best way to verify this PR?
Run all unit tests - for /lib, Traffic Monitor, and Traffic Ops. Also ensure all of the Traffic Ops API tests - versions 1-3 - work and pass.
To test the interface monitoring behavior, given some set of cache servers monitored by the Traffic Monitor instance being tested, add dummy interfaces you're sure won't be in the returned health data from the cache servers' health polling endpoints. Ensure that when "monitor" is not true for this/these interface(s) that they don't affect health status setting for the cache servers. Ensure that when this changes ("monitor" is true) the Traffic Monitor marks the cache servers as unhealthy because it can't find any data for the interfaces in the polling data. Also, check that "maxBandwidth" limits on each actually poll-able interface is respected, by setting it to something lower than the interface is actually serving (I use zero, because that's nearly impossible to reach) such that cache servers are marked unavailable when they are exceeded, and are not - at least not for that reason - when they are not exceeded. Finally, check that there is no setting of "maxBandwidth" on any interface with "monitor" set to false that will result in the cache server being marked unavailable (again, I use zero).
If this is a bug fix, what versions of Traffic Control are affected?

master

The following criteria are ALL met by this PR

[x] This PR includes tests
[x] This PR includes documentation
[x] This PR includes an update to CHANGELOG.md
[x] This PR includes any and all required license headers
[x] This PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

Looks really close to me. TO and TM unit tests pass, API tests pass, docs build and look good, manual testing works as expected.
only thing ive noticed is that all interfaces in /cache-statuses have the same bandwidth, making the total bandwidth off too. i think its a bug in cachestate.go lines 181-187.  should use health[0].InterfaceVitals[inf.Name] data instead of lastStat?

LGTM
There are still a couple issues, specifically with upgrading ATC (#5001), but those will be resolved in a separate PR.


⚠ Bofrost.de has degraded performance

In 780b0f0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 830 ms

Resolved: Bofrost.de performance has improved in 7989a9a after 8 minutes.


feat(Vue): add Vue mutator

Adds a new stryker plugin: stryker-vue-mutator. This plugin requires additional mutator plugins to function, as specified in the package's README. When using this plugin, you should set your mutator property to 'vue'.
Fixes #579

Is this ready to be reviewed?

Allright, one integration test is done. Do we also want a project with jest and typescript @nicojs ?

Hmm. What do you think? Couldn't hurt of course, but does it test something new?

It redirects the code to a different path because all the Vue mutator does is send code to the correct mutator.

The package itself does have tests to see if the code works though.

@nicojs Thanks for the review! I've refactored the code.

I'll try to make them less flakey later this week 👍

I have updated the tests with my latest commit.

I see you mocked away the mutators for unittests. Great. Unittests are a little wet (vs dry) for my taste, but ok to merge

Wet as opposite of DRY indeed. I like my unit tests a little DAMP


Automatically add "hacktoberfest" to repository topic

https://hacktoberfest.digitalocean.com/hacktoberfest-update

Hi @TiagoDanin, I would like to work on this. Could you assign it to me?
Thanks

Each time an issues to create check if the repo has the topic "hacktoberfest", if not:
Add new topic "hacktoberfest" via API (https://developer.github.com/v3/repos/#replace-all-repository-topics)


Allow service types to be configured

Currently, all services are created as ClusterIP type services.  This is adequate if everything is run inside the kubernetes cluster.  For our use case, we need to deploy the collector on a kube cluster but we have a variety of ways to deploy agents, e.g., directly on a VM outside of the cluster.
This means we need to expose the agent GRPC service so it can be reached by the agents outside of the cluster.  Since it's the GRPC service, we can't use ingress.  It'd be nice if we can configure the service for each individual component which allows us to specify serviceType: NodePort or even LoadBalancer.
Thanks,

We've had a PR adding this to the query service. Exposing the collector to outside of the cluster should never be the default option, but I think it might be reasonable to align the collector's service with the query.

This might be related as well: #1048

This might be related as well: #1048

For HTTP thrift services, sure, but the GRPC service cannot be exposed by way of ingress, since ingresses are HTTP only.


Add dependsOnContainerEnd opt: load next page if content's bottom reached

If you have no any nav/next elements, infinitescroll can't detect when you need to load next page.
So now you can specify next options:
navSelector: false, // false allowed now
nextSelector: false, // false allowed now
dependsOnContainerEnd: true // new option

and next page will be loaded when you scroll to the end of the container's element.

Infinite Scroll v3 is out!. It's an all new re-write, so take a look at how to upgrade from v2. With the brand new release, this contribution is no longer applicable.
Thank you for your interest and effort in Infinite Scroll. Sorry I had to pass on this one. 🌈🐻


Added more tags and attributes to check in VarScoper

Code looks good.  Got a couple failing tests to reconcile:
https://travis-ci.org/cflint/CFLint/builds/318843106?utm_source=github_status&utm_medium=notification

Instead of having those values in com.cflint.plugins.core.VarScoper, do you think it would be better to utilize com.cflint.tools.CFMLTagInfo? From what I can tell, isAssignmentAttribute() should return true for any attribute that should be checked for local scoping.

@KamasamaK ,  Yes that is what CFMLTagInfo.isAssignmentAttribute is for.  Though it isn't currently in use and would take some testing.
The three failing tests:
TestCFBugs_VarScoper_Names.java
remove:  new String[] { "CFStoredProc" },
TestCFBugs_VarScoper_TagAttr.java
remove : retval.add(new String[] { "CFMail", "Query" });
cfloop_index_413.cfc
Accept new result:  column 33 is more correct than 2,  should really be 37

I had changed the first 2 locally already as it looked easy enough. I was trying to figure out how that integration test was even finding idx when I came across CFMLTagInfo.isAssignmentAttribute but wasn't really sure how it was working.
Regarding the column, yes it does look like the column is more correct now, so however it found it before must not be reporting that correctly. If we take column to be number of characters, then 33 is correct. It would only be 37 if the tab counted as 4 columns. Although the other one in that file for xxx seems to be wrong.
Anyway, the tests are fixed now.

Thanks @KamasamaK


Inspection VPC: appliance_mode_support?

Does the ec2_transit_gateway_vpc_attachment in the inspection_vpc need appliance_mode_support set to enable?
https://github.com/aws-samples/aws-network-hub-for-terraform/blob/main/modules/network_firewall_vpc/vpc.tf#L103
per https://aws.amazon.com/blogs/networking-and-content-delivery/centralized-inspection-architecture-with-aws-gateway-load-balancer-and-aws-transit-gateway/

Hi,
I don't believe so, If/when i include GWLB into the pattern we will definitely.
That being said i haven't found any documentation stating it doesn't need it either.

NFW uses GWLB which is why I was wondering.

I’m wondering too, I’ve reached out to a specialist SA to ask the question.

I have the answer, we should enable appliance mode support, I’ll get it added shortly.
thank you for the spot.

appliance mode support added to inspection VPC - closing issue. Many thanks

👍


Does dl streamer support yolov4-tiny model?

we trained a yolov4-tiny model and used model_proc of yolo-v3-tiny-tf.json from https://github.com/openvinotoolkit/dlstreamer_gst/wiki/Supported-Models. But the location bbox width is pretty wider.
Does dl streamer support yolov4-tiny, how can we write the model_proc file?

Hello, I have the same issue. I tested with the yolo-v4-tiny-tf.json file example at https://github.com/openvinotoolkit/dlstreamer_gst/wiki/How-to-create-model-proc-file#output_postproc- but I dont obtain any detection. Thanks in advance for any suggestion. Best regards!

@IvanZhangDoIt , did you manage to write model_proc file for used model?

@adranit , thanks, now it works well.


Update pyproject.toml

as far as I can tell this file is not coming from our monorepo.
I am assuming the email I used is the correct one, @wvalori should I use a different one?
We probably want to use a different license than MIT, no ?
@stgarrity @james-uc

yeah I think<EMAIL_ADDRESS>is good. vlad, steve and I are on that. I don't know how the MIT license got in there - might be an @stgarrity question?

yeah I think<EMAIL_ADDRESS>is good. vlad, steve and I are on that. I don't know how the MIT license got in there - might be an @stgarrity question?

I think we just chose a simple, non-restrictive one since the SDK code isn't really something we need to protect? Eg. if people want to mimic our APIs that's a good thing, and any friction that prevents someone from using it (even just a license they don't recognize) is a bad thing? Absolutely open to changing it, but I believe those are the right principles?

great. makes sense - I don't know anything about licenses


TAP interface doesn't work as expected

The flags should be set to TAP instead of TUN, then resolve my issue at  https://github.com/songgao/water/issues/28.

Thanks for the PR! Good catch. This was introduced in a recent PR that added multi-queue support. Sorry I didn't catch that earlier.
Please add you name to CONTRIBUTORS file and I'll merge it.

I have updated the CONTRIBUTORS,
Thanks

Thanks!


Follow button doesn't open the social links overview

Expected behavior
When I click the follow button on my mobile phone I expect to see the buttons for the different social account opening up.
However nothing happens onclick.
Environment
Tried on newest iOS - iPhone 8 Plus
Don't know if android has the same issue.
I tried it with three different minimalmistakes blogs, including datagoodie.com

You sure you don't have a content blocker installed?
That link above works fine for me on iOS.

As does the themes demo site.
https://mmistakes.github.io/minimal-mistakes/year-archive/

You are totally right.
It is this option "Block Windows" option in the iPhone Safari settings that blocks the popup:


Feature: kill a background process

A common pattern in bash is to start a long-running process in the background, do something, then kill it:
foo &
FOO_PID=$!
# do other stuff
kill $FOO_PID

It'd be nice to have an API for this. (Currently there is no way to get the PID of a background_process.)

Yes that would be great to have. I guess a val kill : 'a background_process -> unit or something along those lines.


getETag() and getTimestamp() - APIs - Add doc

To all getETag() and getTimestamp() APIs, Add doc -> these APIs are only relevant on response from the server.

This is done.


Support latest samael

Please ignore this. It was raised by mistake and was not intended to be merged into the base repository. Sorry for all the inconvenience.


#37 - Environment based permission class for views

Closes #37
This PR does the following:

Sets the drf DEFAULT_PERMISSION_CLASSES to isAuthenticated.  Any views that intend to use that as their permission class no longer have it explicitly defined.
Adds a HasEnvironmentPermissionForAction permission class for use on viewsets that inherit build off of the EnvironmentViewMixin mixin in some way.  This class determines the permission needed for the request and then grants or denies access based on the user's permissions.
The ExecuteView remains untouched for now.  Although it falls into the same category as PublishView, that is going to change soon as we move that logic over to a TaskViewSet.  The permissions enforcement will be added then.

Testing Instructions

Create a non-admin user.  Do not assign it any user roles.
Hitting the functions, builds, or packages endpoints as that user should result in a 403.
Assign the user the read only role for some environment.
Now doing a GET against endpoints should work, but trying to POST (such as the /publish endpoint) should still 403.
Feel free to play around with other things.

Works as described. I was able to publish to one environment that I had developer access to and was prevented from publishing to the default readonly environment for the team.
My only observation, which is probably for the future, is that before I assigned the user to the team, I was able to see all the environments for the teams. I'm not sure if we want to restrict that, I'm on board with seeing which teams are available and allowing a request to join team, but wasn't sure if the user should see all environments in teams they aren't members of.

The Team endpoint and the User endpoint I was planning on tackling separately, since the implementation of the data filtering on those is going to be different than what's been added here.


add support for play-pause, next track & previous track buttons

I added global shortcuts tied to the media keys for Play/Pause and Next/Previous Track buttons.  I also did work for volume up/down/mute but didn't include it in this PR because I'm not sure it makes sense.  Do you think it should be supported or not (In VLC, they don't tie the volume control to those buttons)?

Volume keys are usually left to the OS to handle.

@feross yeah, thought so.  I really like when you can control chromecast with volume buttons though (usually on Android).

Oh, that's actually a neat idea. But I think users would find it very
surprising on OS X.
On Thu, 14 Apr 2016 at 16:05 Blaine Bublitz<EMAIL_ADDRESS>wrote:

@feross https://github.com/feross yeah, thought so. I really like when
you can control chromecast with volume buttons though (usually on Android).
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mafintosh/playback/pull/102#issuecomment-210196598

@feross yeah, I'm currently thinking about a "preferences" menu option and maybe it could contain an option for that.

That's amusing -- we're working on the same thing in WebTorrent Desktop right now.

I don't know any programs (at least in osx) that override volume up/down behaviour. But the rest are neat.
And a jumbo :+1: for controlling volume in Chromecast. I very often have that need.


Update module compatibility for Puppet 6

This mainly updates some documentation and spec tests to ensure Puppet 5 and 6 compatibility. This also spruces up the spec tests and adds webmocks to eliminate the need to make actual API calls to a logicmonitor account.

This also fixes #24


How can I update CORS configuration dynamically?

I wanted to change my CORS configuration dynamically. So I used spring cloud config and stored config in git repo. Then I used /actuator/refresh but it was not getting updated. Is it possible to update CORS config using actuator or is there any other way.
 See here.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


change format input avoid key in validate avoid

I need to put String which can be split by specific character into the Array (validate avoid function)

Sorry, i made wrong pull request. Please ignore this.


iPhone Sync time out

On iPhone, for the first sync, i have a "Exception message : the request has expired"...so i can't sync my password...
On my computer, it work but very long for the first authentification but no time out.

If you force a sync on your pc, then attempt a sync with your iPhone, does it behave any differently?


Multi-product flavor and build variant support?

merge multiple source set and create one flavor/variant at one time.

Generate multiple android_binary rules at the same time, with different flavor names.

Manifest, jniLibs still not supported.


Add instructions on how to add videos and embedded files to getting_started.md

This includes adds to two places:

adding a getting_started section for how to include videos and embedded files to the chapters
Add to the checklist items in the .github/PULL_REQUEST_TEMPLATE about checking these.

Originally posted by @carriewright11 in https://github.com/jhudsl/DaSL_Course_Template_Bookdown/issues/126#issuecomment-900459233

Looks like this was accomplished by #128! 🎉


Patch 5

Pull Request Type

[ ] ✨ feat
[ ] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues

resolves #xxx
What is in this change?

Additional Information

Developer Validations

[ ] I ran yarn lint from the root of the repo & committed changes
[ ] Relevant documentation has been updated
[ ] I have tested my code functionality
[ ] Docker build succeeds locally

If you are going to rip off the entire repo and just change the name please dont try to merge the PR back into our main repo


[PLG-321] Multiple Aqua plugins per AWS base account

Now within single AWS base account multiple customer can have aqua.
Fixes # (issue)

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
NOT TESTED YET! (Not sure if we have anything set up for this yet)

I've already merged all changes related to this task via PR #1707
Closing this one.


Install broken with SWI-Prolog 8.1.15

SWI-Prolog 8.1.15 has moved configuration and library files. This seems to have broken the install:
$ swipl
Welcome to SWI-Prolog (threaded, 64 bits, version 8.1.15)
SWI-Prolog comes with ABSOLUTELY NO WARRANTY. This is free software.
Please run ?- license. for legal details.

For online help and background, visit http://www.swi-prolog.org
For built-in help, use ?- help(Topic). or ?- apropos(Word).

?- pack_install(rdet).
% Contacting server at https://www.swi-prolog.org/pack/query ... ok
Install<EMAIL_ADDRESS>from GIT at https://github.com/rla/rdet.git Y/n?
% Cloning into '/home/peter/.local/share/swi-prolog/pack/rdet'...
% Contacting server at https://www.swi-prolog.org/pack/query ... ok
% "rdet.git" was downloaded 19 times
Package:                rdet
Title:                  Runtime determinacy checker
Installed version:      0.0.2
Author:                 Raivo Laanemets <http://rlaanemets.com/>
Home page:              https://github.com/rla/rdet
Run post installation scripts for pack "rdet" Y/n?
% make: *** No rule to make target 'all'.  Stop.
ERROR: Process "process(path(make),[all])": exit status: 2
ERROR: In:
ERROR:   [20] throw(error(process_error(...,...),_46062))
ERROR:   [18] '$apply':forall(prolog_pack:member(all,...),prolog_pack:run_process(...,...,...)) at /usr/lib/swi-prolog/boot/apply.pl:52
ERROR:   [14] prolog_pack:pack_post_install(rdet,'/home/peter/.local/share/swi-prolog/pack/rdet',[git(true),...|...]) at /usr/lib/swi-prolog/library/prolog_pack.pl:1017
ERROR:    [9] <user>
ERROR:
ERROR: Note: some frames are missing due to last-call optimization.
ERROR: Re-run your program in debug mode (:- debug.) to get more detail.

@kamahen, seems like it tries to run make all. I do have a Makefile in pack but only to help publish the pack. I think that previously it only ran Makefile if it had postinstall target (not sure how it figured that out tho).
I will come up with something that does not involve Makefile and I will try to bring it up in SWI Discourse. Maybe we will get something like postinstall(make(target)) in pack.pl that would clarify post-install commands or actions.
It likely means I have to go over all my packs as all of them use Makefile.

@kamahen, I published a new version (1.0.0) of the pack that now comes from HTTP host again. I see that this error is coming because version 0.0.2 was installed from GitHub. It requires further research why pack installation from a web server vs git differs.

I was unable to upgrade the pack (pack_install(rdet, [upgrad(true)]). -- the response was that version 0.0.2 was already installed); I had to manually delete the files and then I could install 1.0.0. Maybe this is a bug in pack_install? Maybe because of the different repositories? (I don't know enough about pack_install to do anything other than wild speculation.)

I ended up doing pack_remove(rdet). and then it installed fine. (I had to make quite a few changes to my code, but that wasn't difficult.)

I added empty all, check, and install targets to the Makefile. Installing from git now works without error. I have no idea how upgrade is supposed to work.
If you want to be sure, then just use git submodules and attach_packs. For example, I have all packs in /home/raivo/pack and this is in my ~/.config/swi-prolog/init.pl:
:- attach_packs('/home/raivo/pack', _{duplicate: replace}).

My suspicion is that "upgrade" is partially broken. I have a few questions pending in the main SWI-Prolog list, but I don't have time (or desire) to dig into this. For now, my solution is to just do a pack_remove followed by pack_install to ensure I get the latest version.


Not able to center a custom-checkbox

Hello,
I want to use a custom-checkbox without a label in a table.
The custom-checkbox should get centered in the table-cell as it does correctly with a normal checkbox, but it is not correctly aligned.
Please have a look at the following screenshot:

I want to provide a live example at JSFiddle to reproduce it easily: https://jsfiddle.net/3wqovfbd/1/
I was not able to find a solution to get it correctly centered.
Thank you very much!

Operating system and version (Windows, macOS, Android, iOS) - Windows 10 20H2
Browser and version (Chrome, Firefox, Safari, Microsoft Edge, Opera, Android Browser) - Microsoft Edge 89.0.774.45

I think you are using this in a way that was unintended. They come out much better when you have text inside of the label elements. Regardless, here is a solution: https://jsfiddle.net/blakej115/gvro5s47/69/
I added the pl-0 class to your custom-checkbox to get rid of the left-padding.
I created a .center-label class that will center the pseudo elements used to create the custom label.
.center-label::before,
.center-label::after {
  left: 50%;
  transform: translateX(-50%);
}

@blakej115
As I see in the JSFiddle-versioning you had some work and you made a good job of it.
Thank you for your effort. :heartpulse: :ok_hand:
@mdo
Thank you for the confirmation. :thumbsup:
I feel OK using custom css.


v1.2 DEX initContainers missing resource definition

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

upgrade to 1.2
allow the Dex rs to run
pods fail
Error creating: pods "openshift-gitops-dex-server-..." is forbidden: failed quota: openshift-gitops-compute-resources: must specify cpu,limits.cpu,limits.memory,memory

Expected behavior
Resources need to be defined for initcontainers
Screenshots
incorrect:
initContainers:
- name: copyutil
image: >-
registry.redhat.io/openshift-gitops-1/argocd-rhel8@sha256:df4b11a78ab8f8a3ee758a1a2b549c190ce1467cdd098a1c10468bbf6e76a596
command:
- cp
- '-n'
- /usr/local/bin/argocd
- /shared/argocd-dex
resources: {}
working:
spec:
restartPolicy: Always
initContainers:
- name: copyutil
image: >-
registry.redhat.io/openshift-gitops-1/argocd-rhel8@sha256:3e6521a3610b23dce99f4eb643171ac9172808e86f3ca4154f5d548a286bb95f
command:
- cp
- '-n'
- /usr/local/bin/argocd
- /shared/argocd-dex
resources:
limits:
cpu: 500m
memory: 256Mi
requests:
cpu: 250m
memory: 128Mi
Additional context

Hi @pbmoses , Thanks for raising issue with us.
Did you add resource requests/limits manually to fix the issue? Looking at the code, upgrade for Dex should work as expected.
https://github.com/argoproj-labs/argocd-operator/blob/c5a3e0d1496f01a4786b81e478d796ff1e970c5b/pkg/controller/argocd/deployment.go#L418
However, the easy workaround for this issue is to remove the resourcequota on the openshift-gitops namespace using the below command.
oc delete resourcequota openshift-gitops-compute-resources -n openshift-gitops

I did fix this manually by adding resources limits to the initContainers. As you mentioned, removing the resourcequota on the namespace would also work.
I do believe, based on what I saw, that without manual intervention, the existing dex-server pods would remain while the new deployment/replicaset would fail (as well as future  which would create an issue unless manually resolved. )
**
failing-deployment-openshift-gitops-dex-server.txt
- type: ReplicaFailure
  status: 'True'
  lastTransitionTime: '2021-07-30T12:08:57Z'
  reason: FailedCreate
  message: >-
    pods "openshift-gitops-dex-server-58985bc68f-jl28w" is forbidden: failed
    quota: openshift-gitops-compute-resources: must specify
    cpu,limits.cpu,limits.memory,memory

@pbmoses Thanks for the information, I will take a look at this :)

The bug is fixed in latest. Please feel free to re-open incase you notice any issues.


Fix confusion in RetrieverConf's struct tag declaration

Description

In the struct tag declaration of RetrieverConf's Object field, which is being mistaken for bucket, the correct value should be object.
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #1265
Checklist

[x] I have tested this code
[x] I have added unit test to cover this code
[x] I have updated the documentation (README.md and /website/docs)
[x] I have followed the contributing guide

@imhuytq the version v1.18.2 is fixing the issue.

@thomaspoignant thank bro!


Question: Is it works with elm 0.19

Hi,
In your example you use programWithFlags that does not exist in Elm 0.19
But flags concept yet exist with Browser.application & Browser.document.
So is it works for elm 0.19 ?

You have at least to change https://github.com/gege251/elm-react-redux/blob/master/src/index.js#L13 to call init instead of embed.
If we make a PR is there any chance to push to npm registry ?

Or use https://github.com/cultureamp/react-elm-components


Tabnine disables autocomplete-paths

Cross issues to https://github.com/atom-community/autocomplete-paths/issues/246
Description
I was wondering why autocomplete-paths does not work for me today until I found out that the Tabnine package disables autocomplete-paths!
Steps to Reproduce

Install Tabnine and restart
Try to use autocomplete-paths

Reproduces how often: Always
Versions
❯ apm --version
apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.53.0
python 3.6.8
git 2.29.2.windows.3
visual studio

As far as I know, we do not block other extensions from operating on imports, but we certainly are "competing" with them. Not sure what a fix would behave like.


google_huawei_availability namespace missing causing app to be unable to build

So, with the new gradle versioning which i was forced to upgrade, and since this package is using google_huawei_availability and its extremely outdated, and I cannot use a fork since its forming me to use it from hosted, the app is unable to launch.
is there any plans to upgrade this or should i find another package?
much appreciated.

I have submitted https://github.com/devdoxconnect/google_huawei_availability/pull/2 for this, although the google_huawei_availability project looks pretty abandoned...
Version can be overwritten with this btw:
dependency_overrides:
  # Waiting for https://github.com/WissamALSbenaty/Ultra-Map-Place-Picker/issues/7
  google_huawei_availability:
    git: https://github.com/easyhour/date_range_picker.git

And this is also needed for huawei_map, take from https://github.com/HMS-Core/hms-flutter-plugin/issues/379#issuecomment-2478997449
  # Waiting for https://github.com/HMS-Core/hms-flutter-plugin/issues/379
  huawei_map:
    git:
      url: https://github.com/HMS-Core/hms-flutter-plugin
      path: flutter-hms-map
      ref: 9d47f5aaa11d4474b37b83e42d073f05ebaa2e24

Hi , thanks for sharing
Yes for sure , I will publish the new version today inshallah
Sorry for interupting your busniss again

@mauriziopinotti
@tiltmaster
I replaced the google huawei availabilty library but for huawei map I cant publish the new version if i changed the dependencies for git path version of the library
The only thing i can do is waiting for the auther to change

@tiltmaster
@mauriziopinotti
I have downgraded the dependencies , you can now continue as usuall

Not sure what's the difference between 0.3.0+2 and 0.4.0, with both I need to use the huawei_map fix though.

@mauriziopinotti
Downgrade to the flutter version directly before 3.27.0
I tested and it did work fot me

@mauriziopinotti Downgrade to the flutter version directly before 3.27.0
I tested and it did work fot me

Actually, I prefer going forwards then backwards and the map picker is not a core feature for my app.
I'll stick to the fork of huawei_map for a while and see if it gets fixed upstream.


[ddc] remove all uses of __proto__

The old __proto__ has been under support only for legacy reasons, the new recommendation is to convert all uses of __proto__ to getPrototypeOf and setPrototypeOf

related: https://github.com/dart-lang/webdev/issues/2118

@nshahan - seems like all of your changes landed. Do we have any remaining work here, or is it fair to close this issue now?

I still have one more use I want to cleanup before I mark it as complete but I got sidetracked when I started trying to figure out how to resolve the diffs between multiple versions. I'll finish it up soon.


add symbol callback

I would like to propose a PR that adds support for setting the symbol using a callback function, as described in the ECharts documentation regarding symbol. Currently, the Symbol structure in the code does not support this method. Therefore, I have introduced a Callback enum to accommodate this functionality.

Can you provide an example of a callback function?

Can you provide an example of a callback function?

Certainly. I have added an example to the line chart gallery (different_symbols.rs) to demonstrate the functionality of the symbol callback.

Thank you very much. LGTM


Why not keep the virt-launcher pod running after stopping the VM

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement
What happened:
The virt-launcher pod was deleted after the VM stopped.
If the VM binds to a specific node, the VMI will stay in pending after stopping and starting if the node has no enough resources.
What you expected to happen:
I just want to know why not keep the virt-launcher pod running. Thank you.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): v0.42.1
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

The virt-launcher pod was deleted after the VM stopped.
If the VM binds to a specific node, the VMI will stay in pending after stopping and starting if the node has no enough resources.

@LLLLLBJ thank you for your report. If we would keep the pod running, the resources would not be released. This  would not work very well with k8s. If you to keep your workload on a node but stop the VM temporarily, would it work for you if you just use virtctl pause or an in-guest reboot?


Theme Check Bug with AppBlockValidTags

Overview
During a bughunt for theme-tools, a bug was encountered with the "AppBlockValidTags" check. This check notifies about code issues with 'error' level severity.
AppBlockValidTags Documentation
Tested against

VSCode

Expected Behavior
In a theme, the use of forbidden tags is allowed and only applies to theme app extensions
Actual Behavior
In a theme, the use of forbidden tags triggers a theme check error
Repro steps:

Start debugging with theme-tools
Open Dawn
Open templates/gift_card.liquid
See theme check error for layout

Fixed this is no longer a recommended check