MgetResponseItem documentation inaccurate

<EMAIL_ADDRESS>Documentation says:
MgetResponseItem holds the union for the following types:

GetResult
MultiGetError

but the type is declared as interface{} so when the json.Decode is called the underlying type becomes map[string]interface{}, which is not very helpful in the "typed" API and makes using a mget.Response rather difficult.

Agreed that map[string]interface{} is not ideal and lives as a default for now.
The MgetResponseItem union lacks a type to switch upon to identify its kind. The current plan for the client is to have some lookahead within the deserialization to identify exclusive fields and use that to determine which type to deserialize into.

Fixed in the aforementioned PR, this will be part of the next release!


refactor: use a game loop for Interface

Currently Interface does not use a "game loop" but rather recursive functions.
This might cause problems for power users, but also adds a layer of complexity.
Therefore I have changed it to use a simple while (True) loop.
Further more I started a refactor of Interface in a way which makes it reusable throughout the entire codebase.
Oh, also I added a new function clear_terminal for the sake of Windows support :rofl:.

I think should be ready now @winstonallo
I have added basic a go back feature, so we can nest modules like this:
class SomeModule(BaseModule):
    def run():
        interface = Interface("Nested Interface", { "option1": SomeOption, "option2", SomeOption }, can_go_back=True)
        interface.loop()


Pieces not doing what they are supposed to.

In my online games page, the pieces are acting weird when dragged.
https://github.com/user-attachments/assets/62a4faf6-bf73-44ba-83a8-12a3b32d2016
no sure why this is happening.
  <Chessboard
                    onSquareClick={onSquareClick}
                    customSquareStyles={memoizedHighlightSquares}
                    position={gameState.fen}
                    customDarkSquareStyle={{ backgroundColor: theme[1] }}
                    customLightSquareStyle={{ backgroundColor: theme[0] }}
                    onPieceDrop={onDrop}
                    boardOrientation={gameState.playerColor || "white"}
                    animationDuration={animationDuration}
                    arePremovesAllowed={true}
                    showPromotionDialog={promotionDialogue}
                    arePiecesDraggable={!gameFull}
                    promotionToSquare={promotionToSquare}
                    onPromotionPieceSelect={handlePromotion}
                    customBoardStyle={{
                      borderRadius: '0.75rem',
                      overflow: 'hidden',
                      boxShadow: '0 25px 50px -12px rgba(0, 0, 0, 0.5)',
                    }}
                  />```

If I had to make a guess, I think you might have adjusted the size or positioning of the board in some parent container and it is messing with the CustomDragLayer component. To confirm, can you also provide the styling to the container/Chessboard component as well? In the meantime, you can try using the boardWidth parameter for Chessboard instead to see if that fixes anything.

Just came across this issue as well, haven't touched any lib code nor experimented yet, but it seems to be related to the underlying react dnd having a bug as reported here: #3641 react-dnd and #267 react-dnd.


Add "About" Section on Falco website

/area documentation
What would you like to be added:
A section in the website (falco.org) called About. In this section we should present a gentle introduction to runtime security and Falco in general.
The About section should address several questions that a prospective user might have about Falco. For example:

What is Falco?
What are the main use cases of Falco?
Why do we need runtime security tooling?
Other frequently asked questions

Why is this needed:
A gentle, use-case-driven introduction to Falco will help prospective Falco users understand the capabilities, benefits and main features of Falco before digging into the documentation and its technical characteristics.
Subtasks

#820
#821
#822

Hi all,
Below is the proposed design for "About" page on falco.org.

This page has a new styling that we will continue to apply to the rest of the site.
The purpose of this page is to introduce User to the high level concept in Falco and its components like "Falco Sidekick"
This page also highlights/refers to other important existing content (docs, blogs, GH repos) and easy to navigate
This page provides multiple graphs to enhance user's understanding of complex concepts in Falco
This page includes breadcrumbs to other pieces of content that is good to read after completing this page

The PDF has notes/annotations with extra explanation for clarity. The current text uses some placeholder texts that will be fixed when we create a PR.
ABOUT (2).pdf

This page provides multiple graphs to enhance user's understanding of complex concepts in Falco

I love it :heart:

As we were working on the content for "About" page, we realized we want to provide more complete story about Falco and reasons to adopt Falco and Falco use cases without making the page overwhelmingly long. Therefore, we decided to split out certain topics into separate pages. Specifically:

Why Falco
Falco use cases
These pages will all live under "About" section and are tracked as separate issues:

#https://github.com/falcosecurity/falco-website/issues/846
#https://github.com/falcosecurity/falco-website/issues/847

Closing this issue as it is complete: https://github.com/falcosecurity/falco-website/pull/837


iterating over a schema tree

Using the C API, one might do this:
 LY_TREE_FOR(module->data, root) {
 LY_TREE_FOR_DFS_BEGIN(root, next, elem) {
   /* do work with elem */
 LY_TREE_DFS_END(root, next, elem);
}

What is the equivalent in libyang-cffi?
Thanks!

figured it out:  dump_dfs(yang_module)
def dump_dfs(node):
    # the top-level 'module' isn't a normal node...
    if type(node) != libyang.schema.Module:
        print("data-path: " + node.data_path())

    # not all nodes (e.g., 'leaf') have children...
    try:
        children = node.children()
    except:
        pass
    else:
        for child in children:
            dump_dfs(child)


[FIX] carepoint: Fix sequence generation

Call execute directly on connection to allow params

Before:
>>> cp = Carepoint(
...     server='<IP_ADDRESS>',
...     user='test_odoo',
...     passwd='',
... )
>>> cp.get_next_sequence('pat_id')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "carepoint/db/carepoint.py", line 338, in get_next_sequence
    seq_name=sequence_name,
  File "/root/_venv/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py", line 1104, in execute
    bind = self.get_bind(mapper, clause=clause, **kw)
TypeError: get_bind() got an unexpected keyword argument 'seq_name'

After:
>>> cp = Carepoint(
...     server='<IP_ADDRESS>',
...     user='test_odoo',
...     passwd='',
... )
>>> cp.get_next_sequence('pat_id')
1103

Current coverage is 97.63% (diff: 100%)

Merging #21 into release/0.1 will not change coverage

@@           release/0.1        #21   diff @@
=============================================
  Files               59         59
  Lines             1562       1562
  Methods              0          0
  Messages             0          0
  Branches            38         38
=============================================
  Hits              1525       1525
  Misses              19         19
  Partials            18         18

Powered by Codecov. Last update d70b452...7d8164c


Fix #191

#191
Fix remove file issue on windows, when compact blocks(block count > 1)
Need find a better way to handle windows file operations! It's hard to find which file must be closed!

after this patch, it work on my windows server now.
@fabxc

@beorn7
On Thu, Nov 2, 2017, 17:42 ranbochen<EMAIL_ADDRESS>wrote:

after this patch, it work on my windows server now.
@fabxc https://github.com/fabxc
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/tsdb/pull/193#issuecomment-341483341, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAANaOmpJY7VnM0pF6MStkrLJcMTDve5ks5syfDogaJpZM4QOd_w
.

Do we have a qualified reviewer for this? @fabxc @Gouthamve ?
This looks like it should go into rc3 . (I assume we don't want to release something that doesn't work on MS Windows?)

I'll merge this now – maybe we can find an alternative way for the described problem in the future.


Report: Advanced filters not working

Working as intended: advanced filters do not remove rows of genus that still have child species.


Any plans to add remainder of JS promise interface to this implementation?

The specification for javascript promises has evolved by a couple of methods since this library was created and was just wondering if we should start hacking up the remaining JS promise methods into the lib?
MDN reference:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise

Also I started hacking them up here: https://github.com/elycruz/promise/tree/issue-%23-js_promise_interface (for my own benefit :-D).
Thanks 👍

K, great, will take the issue then 👍
(thanks 👍)

Thanks for the work you've already done.
I think we should add the following methods:

All
AllSettled
Race

You have already implemented 1 and 3 👍
Let's try 2 as well

Sure, it's not a problem, it's my pleasure :+1:
Agreed!  Will clean up the implementations of All and Race and then give AllSettled some thought jehjeh :+1:.

This is mainly done and merged into master!
There are a couple of other methods we can think about implementing (borrowed from other languages), but other than that it's the ES6 implementation is done

Agreed.


Updating Tutorials to new notebook format

IPython 3.0 has now been out for quite a while and I expect most people will have upgraded. Now that Jupyter has been released we should therefore definitely consider upgrading the Tutorials to the newer notebook format, IPython 3 and Jupyter users are always confronted with the conversion notice. Also even if someone is stuck with IPython 2, they backported an automatic conversion functionality so they will still be able to use it. Therefore my vote is to upgrade the Tutorials asap.

Also even if someone is stuck with IPython 2, they backported an automatic conversion functionality so they will still be able to use it. Therefore my vote is to upgrade the Tutorials asap.

This was definitely true between IPython 2 and 3 - each version could open notebooks generated in the other. I may be mistaken but when trying Jupyter recently, I do think I saw some notebooks that would not open properly in one of the two versions I was testing (IPython 2 vs Jupyter).
Although it is probably worth double checking,  it matters too much as I agree that we should be switching to the new format regardless.

There are definitely many combinations of versions that won't work; it's only the latest IPython 2 that works, which doesn't help people who have IPython from a canned distribution without a new enough IPython 2.  In any case, we tell everyone to use Anaconda now, and so should have it set up to work smoothly with what they'll get from that (Jupyter).

This has been done as of commit https://github.com/ioam/holoviews/commit/9cc09d0f637dc9d240421bd964397efbe97850df. Closing.


build fail in android

Version of react-native-audio-recorder-player
"^3.0.2"
Platforms you faced the error (IOS or Android or both?)
Android (physical device)
Actual behavior
build keep failing with their error, also when I try gradlew clean I get the same error
"react-native": "0.64.0"

A problem occurred configuring project ':react-native-audio-recorder-player'.
> Could not resolve all artifacts for configuration ':react-native-audio-recorder-player:classpath'.
   > Could not find builder-3.3.1.jar (com.android.tools.build:builder:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/3.3.1/builder-3.3.1.jar
   > Could not find tracker-26.3.1.jar (com.android.tools.analytics-library:tracker:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/analytics-library/tracker/26.3.1/tracker-26.3.1.jar
   > Could not find manifest-merger-26.3.1.jar (com.android.tools.build:manifest-merger:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/manifest-merger/26.3.1/manifest-merger-26.3.1.jar
   > Could not find sdk-common-26.3.1.jar (com.android.tools:sdk-common:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/sdk-common/26.3.1/sdk-common-26.3.1.jar
   > Could not find builder-test-api-3.3.1.jar (com.android.tools.build:builder-test-api:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/builder-test-api/3.3.1/builder-test-api-3.3.1.jar
   > Could not find ddmlib-26.3.1.jar (com.android.tools.ddms:ddmlib:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/ddms/ddmlib/26.3.1/ddmlib-26.3.1.jar
   > Could not find sdklib-26.3.1.jar (com.android.tools:sdklib:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/sdklib/26.3.1/sdklib-26.3.1.jar
   > Could not find layoutlib-api-26.3.1.jar (com.android.tools.layoutlib:layoutlib-api:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/layoutlib/layoutlib-api/26.3.1/layoutlib-api-26.3.1.jar
   > Could not find dvlib-26.3.1.jar (com.android.tools:dvlib:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/dvlib/26.3.1/dvlib-26.3.1.jar
   > Could not find repository-26.3.1.jar (com.android.tools:repository:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/repository/26.3.1/repository-26.3.1.jar
   > Could not find common-26.3.1.jar (com.android.tools:common:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/common/26.3.1/common-26.3.1.jar
   > Could not find jetifier-processor-1.0.0-beta02.jar (com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta02).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/jetifier/jetifier-processor/1.0.0-beta02/jetifier-processor-1.0.0-beta02.jar
   > Could not find bundletool-0.6.0.jar (com.android.tools.build:bundletool:0.6.0).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/bundletool/0.6.0/bundletool-0.6.0.jar
   > Could not find jetifier-core-1.0.0-beta02.jar (com.android.tools.build.jetifier:jetifier-core:1.0.0-beta02).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/jetifier/jetifier-core/1.0.0-beta02/jetifier-core-1.0.0-beta02.jar
   > Could not find builder-model-3.3.1.jar (com.android.tools.build:builder-model:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/builder-model/3.3.1/builder-model-3.3.1.jar
   > Could not find protos-26.3.1.jar (com.android.tools.analytics-library:protos:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/analytics-library/protos/26.3.1/protos-26.3.1.jar
   > Could not find apkzlib-3.3.1.jar (com.android.tools.build:apkzlib:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/apkzlib/3.3.1/apkzlib-3.3.1.jar
   > Could not find apksig-3.3.1.jar (com.android.tools.build:apksig:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/apksig/3.3.1/apksig-3.3.1.jar
   > Could not find annotations-26.3.1.jar (com.android.tools:annotations:26.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/annotations/26.3.1/annotations-26.3.1.jar
   > Could not find databinding-common-3.3.1.jar (androidx.databinding:databinding-common:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/androidx/databinding/databinding-common/3.3.1/databinding-common-3.3.1.jar
   > Could not find baseLibrary-3.3.1.jar (com.android.databinding:baseLibrary:3.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/databinding/baseLibrary/3.3.1/baseLibrary-3.3.1.jar
   > Could not find aapt2-proto-0.3.1.jar (com.android.tools.build:aapt2-proto:0.3.1).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/aapt2-proto/0.3.1/aapt2-proto-0.3.1.jar

I've just tried this in Example and the project and building fine. Have you followed the readme?
This most likely looks like an issue on your build and not related to the package.

I've just tried this in Example and the project and building fine. Have you followed the readme?
This most likely looks like an issue on your build and not related to the package.
Yes I have. and even though my react native version is over 0.63 the auto-linking didn't work, so I add everything mentioned in the Readme file
My package manager is npm, not yarn, Could it cause the problem?


Is there a way to specify what databricks workspace to target?

Currently the only parameter that may indicate what databricks workspace would be targeted is the Azure Region field, however, what would happen if there were multiple workspaces on the same subscription in the same region? Would it try to copy files to every workspace found?
Any information regarding this would be appreciated! Thanks

Found the service principal option :)


[24321] Large amounts are no longer cut off on smaller widths.

 Reduced the fontSize depending on the device width & the amount value.
Fixed Issues
$ https://github.com/Expensify/App/issues/24321
PROPOSAL: https://github.com/Expensify/App/issues/24321#issuecomment-1671635913
Tests
Same as QA Steps.

[X] Verify that no errors appear in the JS console

Offline tests
Same as QA Steps.
QA Steps

Choose the narrowest phone you have;
Click on + icon -> click on Split bill;
Enter a 10 digits amount(also counting those after .) such as "88888888.88";
Select at least 5 other participants -> click on Split;
Verify that the split bill preview does not have the amount cut off inside the chat which opens after clicking on "Split".

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@eVoloshchak @Julesssss
As seen in the web video, I've tested with custom resolutions and everything looks good down to 320px. One can't manually resize browsers to be narrower than 500px, but the Desktop app on iOS may be narrowed more than 500px, and for some reason, in the interval: 350-360px, the 10 digit amounts get the last digit cropped:

Should I add more login only for the Desktop app and only for the 350-360px interval? The above screenshot is taken for the worst case at 350px width. My mobile phone, while testing on the Chrome app, prints a width of 350px and look good as in the attached PR Screenshot. Also, from the developer tools, using custom resolutions in the 350-360px interval looks good.
I would personally say to leave it as is as this is a very very edge case, happens only in the Desktop app and only in the 350-360px interval which is very low for the Desktop app. Would you agree?

Hi @eVoloshchak, I saw that you might not be working temporarily? If so could you confirm so I can reassign in the meantime?

@eVoloshchak I think this one is ready to merge too, if you get the chance.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

On web the font size is reduced even though it wasn't cut off before
Before - After

Same with the mobile phone (Pixel 6), the text was barely cut off, font size is too small
Before - After

I think this is due to screens having different pixel density

I know we already agreed on the approach, but it seems like this way of determining font size is not precise. It does not account for different screen resolution/pixel densities (screenshots above)
Can we use something like react-scale-text to make the text dynamically size? I did some basic tests and it seems to be working properly (there might be a better alternative)

I am reluctant to get a new package for such a small small, is there a way not to reduce the font that much?

@eVoloshchak @pecanoro @Julesssss

On web the font size is reduced even though it wasn't cut off before

We have tabletResponsiveWidthBreakpoint: 1024, so above that we may consider devices as web. Font reduction on any size only happens for amounts equal or larger than "1,000,000.00". This is how it looks like with this PR changes on large screen devices with many amounts combined:

We have mobileResponsiveWidthBreakpoint: 800, so above that we may consider devices as tablets. Here, if I manually narrow the window to 802px without PR changes, the widest amount is barely cut:

A. If you want, I could move the if (requestAmount >= 100000000) toSubtract = 2 inside the if (isSmallScreenWidth) and leave the amounts untouched for wider than 800px devices. For reference, this is how it would look like on various device sizes under 800px:

500px
450px

400px
350px
320px

Is there any room to reduce the amount of font sizing jumps in the switch case, perhaps?

Those in the switch case should be ok, as they reduce all amounts depending on the device width. I think the jumps are coming from extra reducing the size of large amounts only.
B. I know it was initially desired in the issue discussion, but, if you want, we may give up on the idea of reducing the amount size depending on the amount value, and just reduce it depending on the device width, i.e., I'll remove the if (requestAmount >= 100000000) toSubtract = 2 and just increase with 2 already existing values inside the switch statement. For reference, this is how it would look like after:

500px
450px

400px
350px
320px

C. Keep calculation as is, i.e., reduce all amount sizes for smaller width devices and extra reduce a little bit large amounts for any width.
I find "B." pretty good looking. What would you say?

we may give up on the idea of reducing the amount size depending on the amount value, and just reduce it depending on the device width

Option B looks good on my devices too
I'd say it looks even better than the current implementation, the font size is the same for different amount lengths, looks more consistent

I'd say it looks even better than the current implementation, the font size is the same for different amount lengths, looks more consistent

I agree! Maybe it's a little bit small on my phone, but I'd say it's not too small. The last thing to consider when deciding between options is to also think about how many users will actually have amount values of over 1 million in their currencies. If not many, maybe we could keep the extra reduction for values over 1 mil in order to have larger sizes below that.
@eVoloshchak @Julesssss When you agree over any of the options, I'll update the PR.

Yeah, I agree with @eVoloshchak, what do you think @Julesssss?

Wow, thorough examples. Thanks.
Yeah I also agree 👍

@eVoloshchak Sorry for the delay, I was out of town over the week-end and just recently got back home. Updated the PR as per latest discussions.

We have a merge hold temporarily

@Julesssss

We have a merge hold temporarily

Ok, no problem. I've updated my Screenshots/Videos with the updated code meanwhile.

@DanutGavrus up to you whether you want to resolve conflicts now or on Monday.

@Julesssss Ok, no problem! I've fixed them now in order to have it smooth on Monday and I've also updated my function from StyleUtils to ts.

@Julesssss @pecanoro Fixed conflicts again.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.67-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.67-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.68-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Make yarn clean purge node_modules, too

... since it's recreated as part of the installation anyway.

build task is broken

Build is now fixed, but re-installing the npm packages takes an extra 41 secs, so it will slow down the CI a little bit. I don't know if it's acceptable. If it's not, then instead of purging the node_modules in yarn clean, I will just add another target called 'clean:deep", which does all that the original clean did, plus the node_modules.

As discussed, this is no longer necessary. (I will just use my custom Makefile)


Differentiate between P4P and Community Contribution

Revise "code with us" page content so that the community understands both p4p and "love" work/community collaboration is available.
DOD:

updated page content
add the love/community work in the open/closed opportunities list if it exists.

Will work with @mark-a-wilson to revise this content. Will then need technical implementation of the content changes.

assigned to @lmullane and @paulroberts68 as per sprint 21 planning session.

@paulroberts68  could you please send me the content. Cheers,


Facebook Calendar is missing

Hello today realized that my Facebook Calendar which already linked to Google calendar is not seenable in gcalcli calw even if it exist in gcalcli list

If you can give steps to reproduce it might be helpful.  I have no idea how to link my facebook calendar to google calendar and didn't find instructions quickly googling.   You could try a gcalcli --refresh calw to see if that helps.  Also make sure your .gcalclirc isn't limiting the calendars with --defaultCalendar options.

Closing because we don't have repro steps.  @ghost if this is still an issue please follow up here.


Figure 8 and Eq.2 are difficult to understand for me.

Thanks for the nice work.
I understand the mean of CLIP+fixmatch, but what is the mean of CLIP + DebiasPL in tabel 6, is it the CLIP + fixmatch+DebiasPL? In addition, the implementation of CLIP+fixmatch is not to fine tune the CLIP, but only using the pseudo-labels from CLIP on unlabeled data. Do I understand correctly? Thanks.
I read the paper carefully. But I cannot understand the figure 8 and Eq.2, if there any relevant material to refer to? Thanks,

Thanks for your interest in our work.
For your first question, yes, CLIP + DebiasPL means we use CLIP plus DebiasPL (w/ FixMatch). All the experiments of DebiasPL are based on DebiasPL w/ FixMatch, unless otherwise noted. For zero-shot experiments, we have never used any human annotations. For semi-supervised learning learning experiments,  we use the pseudo-labels from CLIP on unlabeled data for a higher label-efficiency.
For your second question, you can check references (paper 17, 21, 42, 54) in our CVPR paper to better understand the concept of causal inference.
I hope these answers will be helpful!

Thanks for your interest in our work.
For your first question, yes, CLIP + DebiasPL means we use CLIP plus DebiasPL (w/ FixMatch). All the experiments of DebiasPL are based on DebiasPL w/ FixMatch, unless otherwise noted. For zero-shot experiments, we have never used any human annotations. For semi-supervised learning learning experiments, we use the pseudo-labels from CLIP on unlabeled data for a higher label-efficiency.
For your second question, you can check references (paper 17, 21, 42, 54) in our CVPR paper to better understand the concept of causal inference.
I hope these answers will be helpful!

Thanks for you quickly reply. This would be helpful to me.

Nice! Closing this issue for now. Feel free to reopen it if you have more questions.


Open Source Expectations

I'd like to give this one last look over sometime tomorrow, but I feel good about it.
Interested if people can think of other questions that are regularly asked?

:100: You're good to merge form my perspective.

Alright, got one anecdote, and need to think of a call-to-action too

This is :+1: - shipping.


Wrong detect Python path

Suppose should using /usr/local/bin/python
but pipenv alway using /bin/python
Describe your environment

Docker container
3.6
9.0.1

Expected result
My python installed path is /usr/local/bin/python
Actual result
While executing pipenv install --system
I get following error
Pipfile.lock (ab249c) out of date, updating to (fe9971)…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
CRITICAL:pip.utils:Error [Errno 2] No such file or directory: '/bin/python' while executing command python setup.py egg_info
Traceback (most recent call last):
  File "/usr/local/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/pipenv/cli.py", line 1866, in install
    do_init(dev=dev, allow_global=system, ignore_pipfile=ignore_pipfile, system=system, skip_lock=skip_lock, verbose=verbose, concurrent=concurrent, deploy=deploy, pre=pre)
  File "/usr/local/lib/python3.6/site-packages/pipenv/cli.py", line 1325, in do_init
    do_lock(system=system, pre=pre)
  File "/usr/local/lib/python3.6/site-packages/pipenv/cli.py", line 1121, in do_lock
    pre=pre
  File "/usr/local/lib/python3.6/site-packages/pipenv/utils.py", line 461, in resolve_deps
    resolved_tree.update(resolver.resolve(max_rounds=PIPENV_MAX_ROUNDS))
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/piptools/resolver.py", line 102, in resolve
    has_changed, best_matches = self._resolve_one_round()
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/piptools/resolver.py", line 200, in _resolve_one_round
    for dep in self._iter_dependencies(best_match):
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/piptools/resolver.py", line 296, in _iter_dependencies
    dependencies = self.repository.get_dependencies(ireq)
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/piptools/repositories/pypi.py", line 153, in get_dependencies
    result = reqset._prepare_file(self.finder, ireq)
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/pip/req/req_set.py", line 639, in _prepare_file
    abstract_dist.prep_for_dist()
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/pip/req/req_set.py", line 134, in prep_for_dist
    self.req_to_install.run_egg_info()
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/pip/req/req_install.py", line 438, in run_egg_info
    command_desc='python setup.py egg_info')
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/pip/utils/__init__.py", line 667, in call_subprocess
    cwd=cwd, env=env)
  File "/usr/local/lib/python3.6/subprocess.py", line 707, in __init__
    restore_signals, start_new_session)
  File "/usr/local/lib/python3.6/subprocess.py", line 1333, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: '/bin/python'
The command '/bin/sh -c cd /tmp && pipenv install --system' returned a non-zero code: 1

Steps to replicate
Remove line 11 in my docker file
https://github.com/davidNHK/import-google-sheet/blob/master/Dockerfile#L11

how did you install pipenv?

@kennethreitz @davidNHK this actually will be fixed by #1005 (technically would be a duplicate of #1002)

@kennethreitz I install pipenv though pip install pipenv
@techalchemy So what is the right thing to do for me? I am using the latest version of pipenv.
Suppose #1005 is already merged and publish?


Unable to move blind to 'my' position

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
Hello,
I am using the latest version of the custom component via the Mini Tahoma box. I can control my RTS
blinds correctly but can't get the my position to work. If I use the Tahoma app on my phone, it works fine.
I've tried:

calling the service cover.stop_cover
using the service tahoma.set_cover_my_position as per the documentation but it is not listed

What am I missing?
Thank you
What version of this integration (ha-tahoma) has the issue?
2.13.0
What version of Home Assistant Core has the issue?
2022.7.2
Which gateway / hub do you use?
Tahoma Mini
Device model
No response
Home Assistant log
Logs
Copy/paste any log here, between the starting and ending backticks. The first log line must start with "Added device (Device...".

Additional information
No response

@boutch is there a reason why you use the custom component, instead of the Overkiz integration from core? (remove the custom component first).
The my functionality is not exposed via a service anymore, but via a button. You should see this button on your integrations page.

Thank you @iMicknl. I've tried both Overkiz as a custom component and also in HA core. I can't see any button in the integration.

Thank you.
That's done, please refer to https://github.com/home-assistant/core/issues/75067


New term request: Biomineralization

This is a follow-on from #17209
The current GO term for biomineralization (GO:0031214, biomineral tissue development) does not work for entries outside of animals. It is a child of GO:0048513, animal organ development and of GO:0009888 tissue development, and the definition speaks of "hard tissues". I need a process term suitable for bacteria, that could probably be a parent to GO:0031214, please.
I suggest the following definition, which is based on the UniProtKB keyword. I can't find a single review that covers everything from vertebrate tissue to marine animals to bacterial biomineralization, sorry. Bacteria were recently shown to make a cement-like material, see PMID     24395694, so there is more than one kind of biomineralization in bacteria.
Thanks, Andrea
Biomineralization.
The process where mineral crystals are deposited in an organized fashion in a matrix (either cellular or extracellular) by living organisms. This gives rise to inorganic compound-based structures such as skeleton, teeth, ivory, shells, cuticle, corals as well as bacterial biomineralization products.

Note there is a wikipedia entry that covers everything, so a grouping term is probably reasonable.

@AndreaAuchincloss
Do you think we should include formation in the definition, as well?
The process where mineral crystals are formed and deposited in an organized fashion in a matrix (either cellular or extracellular) by living organisms. This gives rise to inorganic compound-based structures such as skeleton, teeth, ivory, shells, cuticle, corals as well as bacterial biomineralization products.

@vanaukenk
Good idea, yes that is better.


Sorting issues

Hi there,
thanks for your nice app.
Could you sort issues on level so criticals and warnings are on top?

Hi, you see all warnings and errors in the first tab. The other tabs are sorted by hostname on purpose. I might consider this for a future update though, feel free to send in a PR if you want to take this over.


Fixed a comment on line 2347 of ...material/scaffold.dart

It says to use "ScaffoldMessenger.hideCurrentSnackBar" instead of "hideCurrentSnackBar", but this errors. The suggestion actually needs to be: "ScaffoldMessenger.of(context).hideCurrentSnackBar"
Fixes #78865

We may update "Use ScaffoldMessenger.showSnackBar." message in ScaffoldState().showSnackBar(...) deprecation message.

This has failing checks and merge conflicts now, and has not been updated in a while. I am going to close this as it appears to be a misconception concerning the deprecation notice. Thanks for contributing!


Extract shared popover logic to popover component

Update the options menu and dropdown components to use new shared API provided by the popover componet
Add a story for the popover component

I'm hoping I didn't break the dropdowns, but I've played around with them a bunch and it looks good.

Sure I can just fix stuff if I managed to break it 🙂


bookstack support

https://www.bookstackapp.com/

Boy spamming so much he can't keep track

Blocked the user


(PE-15587) Set noop flag on a report to true only if all its resource events are noop

This commit improves the algorithm which tries to recognize that puppet run was started with --noop param. Originally, any noop resource event caused that the whole report was marked as noop. However, a noop puppet run would have all resource events in noop state. With this commit, all resource events need to be noop to mark the whole report as noop.
The current implementation is not able to recognize an unchanged noop puppet run since it doesn't contain any events. So, this improvement is just a workaround. To be able to recognize noop puppet runs properly, puppet needs to report in which mode was the run started. This problem is logged as PUP-6294.

ping @kbarber @senior


Update Export-SPWeb.md

Update switch parameter. Fill in placeholder text.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Export-SPWeb.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[$1000] IOU - Currency input has several . entering big amount and clearing all the digits

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open web
Click the global + icon
Split Bill (or Send Monday, or Request Money - happens in all flows)
Change currency to currency that has three letters (i.e AED)
Enter large amount and clear (eg 8 digits)

Expected Result:
dots . should not appear
Actual Result:
There are several dots ……
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] MacOS / Safari

Version Number: 1.2.56-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/213556964-05f6092d-90b0-4c81-99fe-96f6ed68dcc8.mov
https://user-images.githubusercontent.com/43996225/213557211-c8e148d6-3c4c-4dbe-b955-802ec5f355e8.mp4
Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674153979209299
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a45e6916504d6da4
Upwork Job ID:<PHONE_NUMBER>995597312
Last Price Increase: 2023-01-24

Wow sorry for the delay. I totally missed this last week. Checking the report now.

Huh that's super weird. It actually looks like it only happens for currency abbreviations that are all letters. Doesn't occur for MX$.
https://user-images.githubusercontent.com/1127863/214397623-03499f2b-5fd7-4ca3-a021-2399f25788e6.mov
Also this isn't limited to the Split Bill. Flow I can also reproduce in Send/Request Money as well.

Opening up to external

Proposal
The issue ONLY happens for the currencies starting with letter A. This is because the downward stroke of the letter A is out of the symbol boundary. That causes this rendering issue on Safari.
We have 3 options to fix this.

Change the font to one without overflowing letters or fix this one so that letters don't overlap (specifically letter 'A').
Add padding to the Text as suggested by @Ollyws.
Cut the letter A's leg by adding overflow: hidden to the Text Element of the CurrencySymbolButton component.

Options 2 and 3 are sort of workarounds. I think we should fix this font and make sure that the letters stay within there bound. cc @shawnborton

I'll take a look at these proposals tomorrow!

Hmm, I don't think @allroundexperts is right here. This is a very strange bug, even after you delete the input you still see the remaining three dots:

And then as soon as you resize your window, the dots go away.
Also, this only happens in Safari too which is strange...

Proposal
RCA
This issue occurs when the text is rendered in a lower frame rate than the text's animation rate, causing the previous text frames to linger on the screen. This can create an effect where the text appears to be leaving a trail behind it.

For performance reasons, WebKit only repaints those part of a page that it thinks might have changed.

Reference:

https://stackoverflow.com/a/17822836/18007080

index e30b5f77b5..92c5dcdceb 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -2181,6 +2181,9 @@ const styles = {
         fontSize: variables.iouAmountTextSize,
         color: themeColors.heading,
         lineHeight: variables.inputHeight,
+        outlineWidth: 1,
+        outlineStyle: 'solid',
+        outlineColor: 'transparent'
     },

     iouAmountTextInput: addOutlineWidth({

I agree with @allroundexperts here. This does seem to stem from the fact that some letters overflow their boundary and webkit leaves the artifacts when animating them. It seems to happen for the letters A, V, W and Y.
@shawnborton is it possible to fix the font itself so it doesn't overflow? If not, I think we should go with option 3 and hide the overflow.

Oh wow, that's super interesting. I don't think modifying the font is a good option here, so hopefully we can fix this another way. That being said, if we "hide the overflow" - will the font appear to be cut off?

Also, why not try one of the solutions provided by @getusha here? Take a look at the StackOverflow that was linked.

@shawnborton The font appears fine but I've noticed that it lags for a moment. option 2 seems to work the best without any noticeable lag.

Thanks for confirming @shawnborton! I'd imagine we want to avoid the extra padding and shifting the layout by 1px. In that case the best option would be to add an outline as described here.

Fair points, I would be fine with doing nothing for now.

I believe that this issue should be addressed, as it appears to be affecting all currency inputs.

@shawnborton every currency name that starts with "A" is affected

That makes sense, I'm just curious how many real users are sending money requests in currencies that start with A right now.

Also currency that starts with "Y", "W" and "V"  affected

@rushatgabhane IMO, this link https://stackoverflow.com/questions/17575624/how-can-i-avoid-animation-artifacts-on-my-touch-draggable-border-radius-element/17723401#17723401 is not relevant to our error. It does not explain why this happens for a particular font only.

@rushatgabhane The WebKit rendering engine utilizes an optimization technique to improve performance by only redrawing parts of the webpage that have been modified. since the font is out of the box it doesn't move the rendered clipped text with the main text

Proposal 2
index e30b5f77b5..d19656b3c0 100644
--- a/src/styles/styles.js
+++ b/src/styles/styles.js
@@ -2181,6 +2181,7 @@ const styles = {
         fontSize: variables.iouAmountTextSize,
         color: themeColors.heading,
         lineHeight: variables.inputHeight,
+        willChange: "transform",
     },

     iouAmountTextInput: addOutlineWidth({

Result
https://user-images.githubusercontent.com/75031127/214922240-a179f374-be4a-4736-8ea9-c7214dc5a593.mov

It's worth noting that will-change is mostly used to deal with performance issues and not visual effects issues, there is a bunch of warnings that this property must be used with caution.
https://developer.mozilla.org/en-US/docs/Web/CSS/will-change

Despite having tested and triaged this, it's hard to find a major currency in this list aside from AUD and maybe AED. Here's the full list of affected.
A: AED, AFN, ALL, AMD, ANG, AOA, ARS, AWG, AZN, AUD
V: VEB, VEF, VES, VUV
Y: YER
W: None
If we're not going to change the font, then I favor the doing nothing.

Sounds like we are ok with doing nothing here. I'll close the issue. Thanks for the input everyone!


Neo4j docs community drivers

Hi.
Will you add this project to official Neo4j documentation site with community drivers?
https://neo4j.com/developer/php/

I've discovered this repository is many years without support. Propably that is a reason why is not included there.


win64-4b8-editor-console.exe fails to open Godot

win64-4b8-editor-console.exe should open Godot plus a console window, win64-4b8-editor.exe is opening fine.
Godot_v4.0-beta8_win64_console.exe does open Godot plus a console window.
Opening it via a command prompt shows
"D:\win64-g4b8-s155-gs415>win64-4b8-editor-console.exe
Main executable D:\win64-g4b8-s155-gs415\win64-4b8-editor-.exe not found."
Not a big issue but it is a thing I noticed so making this report.

Huh, yeah, I didn't think about that console won't open the exported editor.  I will stop putting them in the releases since I don't think there is any way to change where it is looking or what file.  Thanks for mentioning it!


docs(material/core): Add a brief overview that refers users to the API docs

This will allow us to publish a section on the docs site for @angular/material/core.

We have an exception for the ripples. I assume we want to keep that so that we can continue displaying it as a dedicated entry in the docs site?
One thing to acknowledge is that the ripple API would now also show up in the core entry. Though this might not be a problem.. just raising it here for awareness/discussion.

We currently generate API docs for @angular/material/core but don't link to them anywhere. My plan was to create this overview doc just to have something to put in the overview tab so I can create an entry in the docs site for @angular/material/core. Here's what that would look like: https://material2-docs-dev.web.app/components/core/api, it doesn't seem to include the ripple docs, I guess those are extracted.
It's far from an ideal solution, but I think its better to show this information in a non-ideal format than just not show it at all. We can do future passes to organize it better

Here's what that would look like: https://material2-docs-dev.web.app/components/core/api, it doesn't seem to include the ripple docs, I guess those are extracted

Aha! you're right. Looks like our Dgeni entry point grouper doesn't add them to the core entry-point group, so they only end up in the ripple group.
And yeah, agreed. Showing the core API docs sounds great to me.


doing diff on same node - 2 different environments?

How would I go about using this for diff'ing catalog for the same node - for 2 different catalogs?
I'd like to use this in CI - and generate catalog for "X" nodes - on both "master" and "merge-request-xxx" environment and see diffs..

See https://dev.to/camptocamp-ops/diffing-puppet-environments-1fno#ci-integration for the options I use for that need.

See https://dev.to/camptocamp-ops/diffing-puppet-environments-1fno#ci-integration for the options I use for that need.


add apache rewrite rule to ansible for migrated media

I think the apache rewrite rule we want should be something like this:
RewriteEngine On
RewriteCond "%{REQUEST_URI}"  "^/media/uploads"
RewriteRule "/(.*\.(jpg|jpeg|gif|png))$" "/media/original_images/$1" [L,R=301]

It's not working in an online regex tester but I'm not sure why, and this is pretty close to some of the examples in the apache documentation, so hopefully it will work with a little testing and tweaking.
@thatbudakguy how/where should we track adding this to our deploy apache conf? We can't add it yet or because will break cdhweb 2.8.1.
Originally posted by @rlskoeser in https://github.com/Princeton-CDH/cdh-web/issues/248#issuecomment-748313736

confirmed working by testing two different images at their old URLs, which successfully redirected with a 301 (embedded in blogpost and featured on project page).


[Feature request] Support for rebalancing and heartbeat

[ ] Support for group joining (dunno if it's implemented, but I could not see it within protocol module)
[ ] Fix polling (add heartbeat), so the consumer can be visible for the kafka
[ ] Support rebalancing (only one consumer reads from the group)

Relates to #159

Thank you for your comments, I will look into these.

Joining group structures. Currently not preparing any PR, just recoginizing in the subject
use bytes::Bytes;

struct Member {
    member_id: String,
    member_metadata: Bytes
}

struct Protocol {
    protocol_name: String,
    protocol_metadata: Bytes
}

pub enum JoinResponseSchema {
    V0V1 {
        error_code: i16,
        generation_id: i32,
        group_protocol: String,
        leader_id: String,
        member_id: String,
        members: Vec<Member>
    },
    V2 {
        throttle_time_ms: i32,
        error_code: i16,
        generation_id: i32,
        group_protocol: String,
        leader_id: String,
        member_id: String,
        members: Vec<Member>
    }
}

pub enum JoinRequestSchema {
    V0 {
        group: String,
        session_timeout: i32,
        member_id: String,
        protocol_type: String,
        group_protocols: Vec<Protocol>
    },
    V1V2 {
        group: String,
        session_timeout: i32,
        rebalance_timeout: i32,
        member_id: String,
        protocol_type: String,
        group_protocols: Vec<Protocol>
    }
}

@johnward I would like to know (I has been already looking for it - but no success) how version handling is done within library? I managed to find a python implementation of the version check, but could not see anything similar here

Looked at the python code again. It seems to support version detection for the kafka<0.10.0. This version has not been maintained at least for 2 years. After 0.10.0 there is official API to get version.
So, we can easily assume, that rust library can just skip the "hacking" way of getting versions, and use official API call that will provide an actual value.
Also, as I've sifted through the rust code, some of the api calls base on the preceding bytes. Maybe we should also reconsider opening a new issue that will cover rewriting that part of code?

FWIW, the reason I'm trying this library is that I can't seem to control/prevent rebalancing with rdkafka (for which I have a working version already). Hence, my feedback regarding this particular issue: rebalancing should be optional.

Thank you, it would be great to use this information to aid development. thanks


Request: Warn about floating comments

Floating comments are removed when you introspect:
model User {

// I float!

}

Would be good to have a warning in VS Code so that users aren't confused when certain comments disappear.

This feels like a bandaid to me. My preference would be to fix the AST with a specific "Floating Comment" node.
Free-floating comments are useful for documenting what the datamodel does or who's the primary owner of the datamodel.
// This datamodel powers our recommendation engine.
//
// Owners:
//   Mark<EMAIL_ADDRESS>//   Alice<EMAIL_ADDRESS>//   Nicole<EMAIL_ADDRESS>
model User {

}

Since our Schema language is rather simple, we'd need "Floating Comment" nodes in two places: outside the blocks and inside.


how move to page after page reloading

After reloading page, it`s default starts on first page, but how to scroll to the page on which the user reloaded the page. I had a solution with a cookie, but its doesnt work..
mounted() {
     this.$refs.fullpage.$fullpage.moveTo(2);
}

that doesnt work..

options.start = 2 options

scroll works inversively, and after options.start = 2 , scroll doesnt work at all

check your demo, scroll works inversively, i scroll down, but page moves up, and after page loaded, scroll with mouse doesnt work at all, only buttons scroll

Fiexd. Try again!

why scroll work inversively? i scroll my mouse up, but they switch to next page, i scroll my mouse down and they switch to prev page

? please inverse this

https://jsfiddle.net/e23jiang/6jc3okaq/1/
compare with this..

https://jsfiddle.net/6jc3okaq/98/

its inverse, they shouldn`t work like this!
there is correct scrolling https://jsfiddle.net/e23jiang/6jc3okaq/1/

What should it be?

look at this
https://jsfiddle.net/e23jiang/6jc3okaq/1/
it should work like this!
in your fix it works inversively, and its not correct

wait for fix?

Look at my video.  Is there any problem here?

I am seeing an issue in your live demo. If you go to page 2 and resize the browser height, the pages don't resize and it leaves the layout showing multiple pages. Is there a known workaround to this issue?

I have added this feature to the new version. Please update 1.8.0.


Fix obsolete build warning

re: https://github.com/aspnet/Coherence-Signed/issues/985

@javiercn approved this pull request


Test Discovery Stalling for Large Workspaces

Details: Currently test discovery will "hang" with version 2024.22.1 if you have >30 tests in your workspace due to a buffer overflow issue. This should only occur for Mac and Linux machines.
Workaround: Downgrade your python extension version to 2024.20.*.

If you don't have more than 30 tests in your workspace, are you even testing 🤪.
Merry Christmas, Happy Holidays, thanks for all you do, we'll survive till you fix it.
The way to downgrade: on the Extension page, click the drop down arrow on the Uninstall Button and you can "Install Specific Version..."
2024.22.0  seems to be working for me.

Just ran into this bug this AM. Confirming that downgrading is the correct interim solution for this.

The codebase that I encountered this with and reported in #24655 is pretty small, only 16 tests and (per cov) 258 total statements. Downgrading to 2024.22.0, or disabling the pythonTestAdapter experiment in 2024.22.1, fixed the issue for me (but disabling the experiment also took away the neat little coverage indicators 😔).

Same problem here, there is not error logs, never ends finding tests, but in the python test logs pytest collect almost finished
this is the image of the hanging

this is the logs when it collects successfully
[1m============================= test session starts ==============================
platform darwin -- Python 3.11.3, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/teste/projetos/pessoal/python/fastapi-todo-list
configfile: pytest.ini
plugins: asyncio-0.24.0, cov-6.0.0, anyio-4.7.0, xdist-3.6.1
asyncio: mode=Mode.AUTO, default_loop_scope=None
collected 1 item

<Dir fastapi-todo-list>
  <Package tests>
    <Module test_first.py>
      <Function test_first_test>

========================== 1 test collected in 0.01s ===========================
Starting now, all test run output will be sent to the Test Result panel, while test discovery output will be sent to the "Python" output channel instead of the "Python Test Log" channel. The "Python Test Log" channel will be deprecated within the next month. See https://github.com/microsoft/vscode-python/wiki/New-Method-for-Output-Handling-in-Python-Testing for details.

this is the log for that project that does hang when collecting
you can notice there is a log missing at the end that exists in the above log: test collected
============================= test session starts ==============================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0 -- /Users/teste/projetos/pessoal/python/fastapi-todo_list/.venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/teste/projetos/pessoal/python/fastapi-todo_list
configfile: pytest.ini
plugins: asyncio-0.24.0, cov-6.0.0, anyio-4.7.0, xdist-3.6.1
asyncio: mode=Mode.AUTO, default_loop_scope=None
collecting ... collected 17 items

<Dir fastapi-todo_list>
  <Package tests>
    <Dir auth>
      <Module test_auth_api.py>
        <Coroutine test_signup>
        <Coroutine test_login>
        <Coroutine test_me_with_todos>
        <Coroutine test_me_without_todos>
        <Coroutine test_logout_on_get_and_post>
    <Dir main>
      <Module test_main.py>
        <Coroutine test_healthy>
    <Dir todo>
      <Module test_todo_api.py>
        <Coroutine test_get_user_todos_security>
        <Coroutine test_get_user_todos>
        <Coroutine test_create_todo_security>
        <Coroutine test_create_todo>
        <Coroutine test_create_todo_title_validation>
        <Coroutine test_update_todo_security>
        <Coroutine test_update_todo>
        <Coroutine test_delete_todo_security>
        <Coroutine test_delete_todo>
        <Coroutine test_count_user_todos>
        <Coroutine test_get_todos_full>

I tried both with same python version and it does not work as well, both projects have the same dependencies, the only difference are the tests. In my Django projects the tests stopped working too, they were working just fine yesterday(2024/12/23), the same problem occurs, hangs when collecting the tests.
what I already tried:

fresh install
new user with totally fresh install and only the needed extensions(I thought it was gonna work)
different python versions

I'm currently using macOS, latest version with m3 pro chip, I also made sure I'm using the correct build version for apple silicon.
update
inside devcontainer it finds the tests and also run, but I was not able to debug them like yesterday, the debug menu appears, I can even set the breakpoints but the code never pauses(and yes, I'm did debug tests inside dev container before and it was working).
I have just a few extensions inside dev container, more than when I tested with fresh instalation with new user, for me it looks like something maybe related to macos
what worked
I downgraded python, and debugpy extension version, the tests were found, for all projects, but I still was not able to debug them, accidentaly I noticed it worked for a new project that I created just to test this case, so I cloned my repo into a new folder and everything worked again, so I also tried to update the python extensions again and It broke again, :(

I also had this issue with 2024.22.1 - same symptoms and output panel contents - and downgrading to 2024.22.0 fixes it for me. I am reproducing it by adding additional test cases or longer test case names like the following snippet which suggests a buffer overflow to me. Sometimes it freezes at different buffer lengths but usually within 100 chars of the example in the snippet:
def test_one():
    pass

def test_two():
    pass

def test_three():
    pass

def test_four():
    pass

def test_five():
    pass

def test_six():
    pass

def test_seven():
    pass

def test_eight():
    pass

def test_nine():
    pass

def test_ten():
    pass

def test_eleven():
    pass

def test_twelve():
    pass

def test_thirteen():
    pass

def test_fourteen():
    pass

def test_fifteen():
    pass

def test_sixteen():
    pass

def test_seventeen():
    pass

def test_eighteen():
    pass

def test_nineteen():
    pass

def test_twenty():
    pass

def test_twenty_one():
    pass

def test_twenty_two():
    pass

def test_twenty_three():
    pass

def test_twenty_four():
    pass

def test_twenty_five():
    pass

def test_twenty_six():
    pass

## Uncomment only one of the below examples at a time to reproduce the problem, at least on my machine.

## SUCCEEDS

# def test_twenty_seven():
#     pass

## SUCCEEDS

# def test_twenty_1234567891234567890123456789012345():
#     pass

## FREEZES

# def test_twenty_12345678912345678901234567890123456():
#     pass

## FREEZES

# def test_twenty_seven():
#     pass

# def test_twenty_nine():
#     pass

Probably redundant since it's been identified as a buffer overflow issue, but the specific place it hangs in the plugin is line 943 in __init__.py :
            request = f"""content-length: {len(data)}\ncontent-type: application/json\n\n{data}"""
            __writer.write(request) # HANGS HERE 😞

            __writer.flush()

This may be a repeat bug? I've had discovery suddenly start hanging like this in the past, but didn't suspect an update, and never got to track it this far. It may be worth a warning in the code on the other end, and a test case.

Maybe one symptom of a larger problem? I'm seeing similar hangs elsewhere:

Markdown Preview
Markdown Preview Enhanced
Source Control

Source Control involves a large number of pending changes.
Markdown fails even with a small .md file, but perhaps prepended CSS, etc. makes it start off large?

Any chance for a fix here soon?

Details

I can confirm that the latest version is hanging on multiple repos using pytest (eg: https://github.com/ansys/pyansys-units), and that downgrading to v2024.22.0 makes it go away.

I can confirm that v2024.22.1 is hanging on multiple repos using pytest (eg: https://github.com/ansys/pyansys-units), and that downgrading to v2024.22.0 makes it go away.

Can confirm this works as well.

Same issue, downgrading to v2024.22.0 fixed it for me

This happens with 'experiments' enabled in settings. Don't know why that is enabled by default...

I tried downgrading the python extension progressively but it did not resolve my error. However, when I switched to the pre-release version my test was discovered 🎉
Returning to the release version and disabling A/B experiments in the settings also seems to work.


services/horizon: Use offers table to load account offers.

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
Load account offers from the offers table if experimental ingestion is enabled (#1694).
Goal and scope

Use offers table to load the account's offers page /accounts/{account_id}/offers
Add streaming support using the new action handling approach.

Summary of changes

Load account offers from offers table.
Add streaming for account offers.
Add tests for both SSE and non-SSE scenarios.

Known limitations & issues

N/A

What shouldn't be reviewed

N/A

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-horizon-v0.21.0@6c97083). Click here to learn what that means.
The diff coverage is 70.9%.

@@                    Coverage Diff                    @@
##             release-horizon-v0.21.0   #1699   +/-   ##
=========================================================
  Coverage                           ?   45.4%
=========================================================
  Files                              ?     381
  Lines                              ?   26148
  Branches                           ?       0
=========================================================
  Hits                               ?   11872
  Misses                             ?   13052
  Partials                           ?    1224

Impacted Files
Coverage Δ

services/horizon/internal/web.go
84.78% <100%> (ø)

services/horizon/internal/stream_handler.go
55.76% <55.76%> (ø)

services/horizon/internal/actions_offer.go
78.28% <70.73%> (ø)

services/horizon/internal/middleware.go
86.76% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c97083...9dcce33. Read the comment docs.

@bartekn I think this is ready for a first pass, however we might have found a bug in our current implementation when using cursor=now


Foundation 5 support

Note, this is is:

based on the patches from https://github.com/borisyankov/DefinitelyTyped/pull/1928
fixes the issues addressed in those patches
adds support for the latest Foundation version

@borisyankov @rangelier could you review this PR?
@jfilip http://definitelytyped.org/guides/best-practices.html#ghost-modules please check this best practice.

@vvakame @borisyankov any chance of getting this looked at?

@jfilip sorry, It merged! thanks :+1:


Trimming artifacts on the right side of small images

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
System:
OS: Windows 11 10.0.22631
CPU: (20) x64 13th Gen Intel(R) Core(TM) i7-13700H
Memory: 20.07 GB / 31.53 GB
Binaries:
Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
npmPackages:
sharp: ^0.33.4 => 0.33.4

Does this problem relate to file caching?
The default behaviour of libvips is to cache input files, which can lead to EBUSY or EPERM errors on Windows.

[x] Adding sharp.cache(false) does not fix this problem.

Does this problem relate to images appearing to have been rotated by 90 degrees?
Images that contain EXIF Orientation metadata are not auto-oriented. By default, EXIF metadata is removed.

To auto-orient pixel values use the parameter-less rotate() operation.

To retain EXIF Orientation use keepExif().

[x] Using rotate() or keepExif() does not fix this problem.

What are the steps to reproduce?

Import a 32x32 PNG image with some whitespace into sharp
Attempt to crop the image to only the opaque pixels with .trim()
The resulting image will sometimes have stretched pixels on the right side, or may have trimed any opaque floating pixels entirely

What is the expected behaviour?
The image should be trimmed to remove whitespace from all edges, only containing the unmodified opaque area without removing floating pixels or stretching the right edge.

Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
const sharp = require("sharp");

sharp("input.png")
  .trim({
    threshold: 10,
    background: { r: 0, g: 0, b: 0, alpha: 0 },
    lineArt: true,
  })
  .png({
    colours: 16,
    palette: true,
  })
  .toFile("output.png");

Please provide sample image(s) that help explain this problem

Original image

Trimmed image, with edge artifact

Expected output

After testing some more, it only seems to occur when specifying max colours between 9 and 129 when using .png(). If a number of colours isn't specified at all, it seems to output the expected result consistently.

These look like dithering artefacts when mapping pixel values to a palette-based PNG. For line art you can usually reduce/remove these via .png({ dither: 0 }).
https://sharp.pixelplumbing.com/api-output#png

I hope this information helped. Please feel free to re-open with more details if further assistance is required.


gd script dependencies

I looked around and couldn't figure out where scripts/apply_version.gd is sourced from. Also, is this a stand-alone script or should this be in my godot project's scripts folder? because my project is inside a folder named src, so unless there is a way to tell the Apply version to export information step to change its working directory, there are file path assumptions that won't work with my project being inside a folder instead of the root of the repo.

Created PR #3 to address the path concern. I referenced https://github.com/CapsCollective/rng-stronghold/tree/develop to get the dependent scripts. I have concerns that this action has gd script dependencies. It might make sense to pull them out of the build step and note that the build action assumes those 4 application/*version parameters need to be set. The extract version is its own action, maybe that should be as well?

Thanks for submitting the PR for the base path changes - that is a definite improvement. Yes, the apply_version.gd  script inclusion was an oversight when splitting out of the game repos. I may just move that particular line into the project workflow and remove it from here. I will let you know the result.

The solution above has been applied and will be part of the changes included in v1.2.


new MCT item: DATADISPLAYLIST

@rudraya, Currently, MCT includes PARAMETERDISPLAYLIST which, out of necessity is required to include the parameters to return for a virtual compute call (i.e. parameterset argument == "PARAMETERDISPLAYLIST") AS WELL AS any data items from the input dataset needed to display in the KEL parameter results pane in the Application Analysis module.
In order to separate the DATA items from the computation engine PARAMETER result items being displayed in the Application Analysis Module a new MCT entry is being introduced with openNCA 2.0.1, the DATADISPLAYLIST.
DATADISPLAYLIST will contain data field names from the input dataset required to display in the KEL parameter results pane in the application and now the PARAMETERDISPLAYLIST will only have names of the parameters required.
It is considered that the virtual compute call wrapper script can be updated to manage changes in openNCA 2.0.1 that are required for this without modification to the compute engine code itself but this issue is entered for awareness and to consider the implications in more depth as development proceeds with openNCA CE 2.0.1. If modifications are required to the wrapper script that calls the compute engine for virtual compute calls, these will be done separately from the work being pursued by @rudraya .

As discussed at the 2019-12-19 Checkpoint session, the following behavior is what is required for incorporation of "DATADISPLAYLIST" in the MCT

If parameterset == "PARAMETERDISPLAYLIST" (virtual compute call in openNCA application)

PARAMETERDISPLAYLIST  is the list of parameter names representing the parameters to be computed and delivered to the output results from run_computation
DATADISPLAYLIST is a list of input concentration column names to be merged into the output results from run_computation

If parameterset == "PARAMETERLIST" (non-virtual or save analysis compute call in openNCA application)

PARAMETERLIST is the list of parameter names representing the parameters to be computed and delivered to the output results from run_computation
RETURNCOLS is a list of input concentration column names to be merged into the output results from run_computation


Store executable compilation/configuration options, if possible

Imported from Bitbucket issue 15,  created by apdavison on 06-26-2010 at 21:17, last modified: 04-04-2013 at 09:40

I do not think this is possible in the general case, at least not without major reverse-engineering skills.
.NET executables apparently store a lot of metadata, so that could be useful, if anyone is interested in running Sumatra using IronPython.
For Python, there is a lot of information available in distutils.sysconfig. I guess other programs might have their own equivalents.
For systems using package management, there might be information available.
It might be possible to allow people who have compiled from source to register their configure script/Makefile, etc. with Sumatra.
In summary, this is a big job.
Trac comment by apdavison on 07-20-2010 at 08:00


tests succeed locally, failing on travis

see Esri/arcgis-to-geojson-utils#5 for more info.

Fixed!


[SPARK-44292][SQL][FOLLOWUP] Make TYPE_CHECK_FAILURE_WITH_HINT use correct name

What changes were proposed in this pull request?
https://github.com/apache/spark/pull/41850 uses TYPE_CHECK_FAILURE_WITH_HINT, it should be DATATYPE_MISMATCH.TYPE_CHECK_FAILURE_WITH_HINT.
The first commit come from https://github.com/apache/spark/pull/34747.
Why are the changes needed?
Fix a bug.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
N/A

ping @cloud-fan cc @MaxGekk

The CI failure is unrelated to this PR.

thanks, merging to master/3.5!

@cloud-fan Thank you.


⚠ Bofrost.be has degraded performance

In 31a39e9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2770 ms

Resolved: Bofrost.be performance has improved in 32224cd.


Allow providing a custom ErrorHandler

This will allow providing a custom Jetty error handler in Trino that always returns a JSON-encoded error message that can be interpreted correctly by internal http clients.
Improves error reporting in cases like: https://github.com/trinodb/trino/issues/18843

Ptal @martint @electrum

Closing this PR because of the lack of interest from project maintainers.


Added PyTorch version to Dockerfile

Hi there fellow AM parser,
Thanks for making a Dockerfile! It makes my life so much easier. It did, however, throw a RuntimeError during training (see https://github.com/coli-saar/am-parser/issues/100)
I took at look at pip freeze and realised that it was using the latest version of PyTorch. So I added a line that installs a specific version before it installs allennlp. I used the instructions on https://pypi.org/project/allennlp/#installing-via-pip (documented in comments in the Dockerfile)
It now works with the toy AMR corpus in the example directory but I haven't tried it on anything else. I'm assuming it's fine since this is the recommended PyTorch version (1.1), and I can see that it does correctly install it.
I found docker exec didn't work for me, but docker attach did, so I updated the README.
This is my Very First Pull Request, so I hope I did it right!
Commit message: "Added PyTorch version to Dockerfile; added TODO to cle.py and tidied up the style slightly because PyCharm was sad; small update to README docker instructions"
cheers,
Meaghan Fowlie

Fyi, I included the pytorch-version part of this pull request manually in the master branch of the coli-saar am-parser repo.


Import path changed

After update from 1.0.0.-beta.3 to 1.0.0.-beta.4 something changed.
After update the
import {ElasticModule} from "ng-elastic";

is not working, but
import {ElasticModule} from "ng-elastic/dist/src";

is the working way.
Not a big problem, but had to change the every import.

Apologies, this must have been introduced with using Angular 5 to compile the code for AOT. I will see if I can fix later. If you happen to come across the root cause in the meantime please let me know.

I reverted back to the Angular 4 compiler. Could you try installing beta.5 and see if the issue is resolved?

Now it has the old directory structure:
import {ElasticModule} from "ng-elastic";

node_modules
  ng-elastic
    dist
      dist-files
    package.json

Great, so it's working as described in the README.
Thanks again for reporting this, I'll close out now!


Change the dataWindow property to dateWindow

The Dygraphs option is called dateWindow, not dataWindow. This fixes the inability to change the x range using properties.
http://dygraphs.com/options.html#dateWindow

Can you please accept this pull request 👍


Pod connectivity goes down when any node moves to NotReady state

What happened:
Pod connectivity went down when one node moved to NotReady state .
Was unable to ping pod IP across the cluster .
However, subct diagnose all and subctl show all commands ran successfult and showed that there was 1 connection established between the clusters
[root@hci-dev1 .kube]# subctl show all --kubeconfig=/root/.kube/racki
Cluster "api-isf-racki-rtp-raleigh-ibm-com:6443"
 ✓ Detecting broker(s)
NAMESPACE                NAME                     COMPONENTS
submariner-k8s-broker    submariner-broker        service-discovery, connectivity

 ✓ Showing Connections
GATEWAY                          CLUSTER  REMOTE IP     NAT  CABLE DRIVER  SUBNETS                       STATUS     RTT avg.
control-1.isf-rackk.rtp.raleigh  site2    <IP_ADDRESS>  no   libreswan     <IP_ADDRESS>/16, <IP_ADDRESS>/14  connected  335.682µs

What you expected to happen:
Connectivity should have remained intact
How to reproduce it (as minimally and precisely as possible):
Install submariner across 2 clusters . Move one of the nodes on any cluster to NotReady state
Anything else we need to know?:
Once the node moves back to Ready  state , we need to reinstall submariner to get back the connectivity
Environment:

Diagnose information (use subctl diagnose all):
Gather information (use subctl gather):
Cloud provider or hardware configuration:
Install tools:
Others:
subctl gather_logs.zip

@dirajag1 I see that you are running with OVNKubernetes in an HA mode where the three control nodes are labelled as Gateway nodes.
Couple of questions

Is this an OpenShift deployment. If so, what is the OCP version?
You mentioned that moving one of the nodes on any cluster to NotReady state is creating issue. May I know which node did you move? Is it the active Gateway node or a worker node?
Is this behaviour consistent?

Hi @sridhargaddam

OC version

[root@hci-dev1 ~]# oc version
Client Version: 4.8.13
Server Version: 4.10.27
Kubernetes Version: v1.23.5+012e945

A worker node compute-2 went to NotReady state , it was not the active gateway node
Yes we have observed this issue across 2 clusters

Thanks @dirajag1 for the details. Submariner supports OVNKubernetes in 0.13 release and the minimum OCP version is 4.11+
This is captured in the third bullet point of release-0.13 notes.
https://github.com/submariner-io/releases/releases/tag/v0.13.0
Added more robust support for connecting clusters that use the OVNKubernetes CNI plugin in non-Globalnet deployments. Note that OVNKubernetes requires the OVN NorthBound DB version to be 6.1.0 or above and older versions are not supported. Also note that the minimum supported OpenShift Container Platform (OCP) version is 4.11.

Can you try upgrading to Submariner 0.13 and OCP4.11+ clusters.

Thanks @sridhargaddam

https://submariner.io/getting-started/
Could you please share more information on why this worked on OCP 4.8 .
We have a working submariner  installation (version 0.12.0) on OCP 4.8 where the pod and service network connections were working fine

With OVN Kubernetes this was working on OCP 4.8

Yes @dirajag1, we had a POC support for OVNKubernetes on OCP4.8 and there were some changes in OVNK due to which Submariner does not support OVN on OCP 4.9 and 4.10, and only supports OVN with OCP 4.11+ in version 0.13 or later as mentioned in the release notes.


Migrate to a new netapp

Hi All,
I just want to know if anyone tried to migrate the persistent volumes to a new netapp device?
If yes, can you please share the steps you did? Thank you!
Regards,
Merrell

I did by moving the entire SVM from ClusterA to ClusterB.
That was the easiest way I could find (moving away from an EVAL license).
Sent from my phone

De:Merrell Vineza<EMAIL_ADDRESS>Enviado:jueves, 21 de febrero de 2019 17:15
Para:NetApp/trident
Cc: Subscribed
Asunto: [NetApp/trident] Migrate to a new netapp (#214)
Hi All,
I just want to know if anyone tried to migrate the persistent volumes to a new netapp device?
If yes, can you please share the steps you did? Thank you!
Regards,
Merrell
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ToroNZ Thank you for sharing! I'll discuss and sahre this with our storage team if it is possible on our end.


Collaborators

I've added a few collaborators to this staging site - if you think you should have collaborator access, please contact me. It may make sense to have the same 'owners & collaborators' as the main LearnOSM repository, but I can't see who has those accesses. Please just ask, I'm not trying to exclude anyone.

Closing. Just ask!


Upgrade .NET 6 and func runtime v4

Description

Upgrade to .net 6
Upgrade function to v4
Removed unused nugetpackages
Related Issue(s)

#6

Verification

[x] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)

Waiting to merge untill we have the deployment scripts up and running ok


V1.2 ui refactor

fixes #201

Codecov Report

Merging #204 into master will increase coverage by 0.41%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf52958...b041aab. Read the comment docs.

Unused PR, delete if possible. Did not merge!


ModuleNotFoundError: No module named 'openvino.runtime'

After following the installation steps
pip install -U openvino-dev

   git clone https://github.com/openvinotoolkit/model_analyzer

and try to run the example
python model_analyzer.py  --model ../public/mobilenet-v2/FP16/mobilenet-v2.xml --ignore-unknown-layers
if got the following error
Traceback (most recent call last):
File "model_analyzer.py", line 16, in
from model_analyzer import main, parse_arguments
File "/private/tmp/ovino/model_analyzer/model_analyzer/init.py", line 16, in
from model_analyzer.uncounted_layers import *
File "/private/tmp/ovino/model_analyzer/model_analyzer/uncounted_layers.py", line 22, in
from openvino.runtime import Node
ModuleNotFoundError: No module named 'openvino.runtime'
my openvino version is
openvino                  2021.4.2                 pypi_0    pypi
any ideas?

Hello @betogulliver,
Thank you for using Model Analyzer.
The master branch of the tool is working with the master branch of the OpenVINO repository and Model Analyzer on the latest master uses OpenVINO 2.0 API and does not support OpenVINO from the previous releases.
As I understand you use openvino 2021.4.2 and we suggest using Model Analyzer from the releases/2021/4.2 branch. So, you need to change the branch after cloning the Model Analyzer repo:
git checkout releases/2021/4.2

The releases/2021/4.2 should work with OpenVINO 2021.4.2.
Let me know if you will have any problems with the tool.

The master branch of the tool is working with the master branch of the OpenVINO repository and Model Analyzer on the latest master uses OpenVINO 2.0 API and does not support OpenVINO from the previous releases.

Could you, please, specify this in the requirements on the main page of the repo or something (preferably in the header of the readme), this is not obvious at all. I had to change some lines of the code to make it able to be run, and a couple of my colleagues also fell into this trap.

Hello @morkovka1337 ,
Sure, will create a PR

@morkovka1337 we added the disclaimer about compatibility with the OpenVINO repository to the DEVELOPER.md