DO NOT MERGE! Fast Forward stable to cbc7fd2dcf63f995c2608ca1d9fbca364ce2a8be.

This PR will be merged automatically once checks are successful.

Jenkins job manager/postsubmit passed


just dropping a note to say thanks!

found this repo (after react-d3; which was clearly a non-starter) and instantly worked as described.  Love it when then happens. cheers

Well thank you for the thanks :smile:
I hope it's working well for you, I presume you have a stateless usecase for it? Most of the issues I get are people trying to do mutative D3 things and still trying to use this. In the case of D3 based mutation / animations, the old style of dropping out of React-land for a little while is basically always the answer.

cool, yeah the chart is stateless... i'm able to control state with a parent component as i don't have to worry about animations at the moment.. simple use case


Adding vulnerability description alongside CVE

Is your feature request related to a problem? Please describe.
When looking for nuclei templates to write, it is frustrating to scour through the list to read the description of each CVE to identify if there's value in writing a nuclei template.
Describe the solution you'd like
I want to append the description of the CVE to the output so I can read through the output and determine which CVEs I can write nuclei templates for.
Describe alternatives you've considered
There is no alternate solution, but I have an edited script that appends the CVE description below the output. This can also be output to a different folder for reference instead of overriding the current file format.
For example:
[ CVE-2024-37763 ] [ cross-site scripting ] [ https://github.com/trickest/cve/blob/main/2024/CVE-2024-37763.md ]
MachForm up to version 19 is affected by an unauthenticated stored cross-site scripting which affects users with valid sessions whom can view compiled forms results.

Additional context
I understand doing this would cause issues with the categories' counts. We can add filters to ensure that the lines we are counting is of a specific format ([ CVE ] [ CATEGORY ] GITHUB_LINK) before counting the CVE.

Hi @bernard-yip ! Thanks for your contribution.
Maybe the best thing to insert this would be adding a different folder? Like raw or something like this?
let me know what you think

@edoardottt appreciate your reply! The script I have now is a python script. Will do some testing and create the folders if you're interested. If you'd like, I could format them as a json so it addresses #4 . I'll spin up a PR soon!


Python samples: proactive messages are sent to only the first user

To Reproduce
Steps to reproduce the behavior:

Run proactive messages python sample
Open two chats
Call the GET endpoint http://localhost:3978/api/notify
The message will be sent only to the first chat user

Expected behavior
Expect that all chat will receive the proactive message
[bug]

@khaelys Thanks!  This is because the person who wrote it (me) clearly didn't have enough coffee that morning.
In the app.py, in the _send_proactive_message function, remove the "return" on the "ADAPTER.continue_conversation" call.
Should look like this:
async def _send_proactive_message():
    for conversation_reference in CONVERSATION_REFERENCES.values():
        await ADAPTER.continue_conversation(
            conversation_reference,
            lambda turn_context: turn_context.send_activity("proactive hello"),
            APP_ID,
        )

I will submit a real fix for this shortly.


add export SHA line in greenbuild.VERSION

add export SHA line in greenbuild.VERSION

/lgtm

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-perf-tests.sh
54edec8ba8c1770cc30a2a2e39fe8415a867da29
link
/test daily-perf-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-perf-tests.sh
54edec8ba8c1770cc30a2a2e39fe8415a867da29
link
/test daily-perf-tests

prow/daily-upgrade-tests.sh
54edec8ba8c1770cc30a2a2e39fe8415a867da29
link
/test daily-upgrade-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-perf-tests.sh
54edec8ba8c1770cc30a2a2e39fe8415a867da29
link
/test daily-perf-tests

prow/daily-upgrade-tests.sh
54edec8ba8c1770cc30a2a2e39fe8415a867da29
link
/test daily-upgrade-tests

prow/daily-e2e-pilot-no_auth.sh
54edec8ba8c1770cc30a2a2e39fe8415a867da29
link
/test daily-e2e-pilot-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


blog post page

create a page for a blog post, on the page should be full of post text, title, date, and information about author.
/ai:go

/ai:go(variants=2)


modeling_xlnet.py lines 798  torch.eisum('i,d->id', pos_seq, inv_freq)

hi  I run position embedding in modeling_xlnet.py , but it not work  , why not torch.eisum('i,d->id', [pos_seq, inv_freq])  ?i use pytorch 0.4.1

I don't understand your question.
Can you give more details and point to the exact code lines you are referring to?
You cannot provide specific position indices to XLNet if that's what you are trying to do. You have to use the built-in relative embeddings.

For new PyTorch 1.0, the syntax should be torch.eisum('i,d->id', pos_seq, inv_freq)


Functionality Specific to Unified Interface?

This should be clarified to identify the expected functionality in the Web Client vs Unified Interface.
In testing two different v9.1 (v<IP_ADDRESS>3 and v<IP_ADDRESS>8) organizations, each within a separate tenant, results within Unified Interface closely match this documentation.  (Exceptions: LogicalCollectionName property was not included in the response, OwnershipTypeCode property value is number (not string), and response included 3 properties not mentioned in the documentation.)  The results in the Web Client are substantially different: in the Web Client, the attributes parameter appears to be ignored (the response includes data for the statecode and statuscode attributes only, regardless of parameters passed), and the Privileges property is missing altogether from the response.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077710d0-3468-abe1-4ca3-21eb96dd461a
Version Independent ID: 810e543b-b26d-01ac-fe87-9de2176f3fa6
Content: getEntityMetadata (Client API reference) in Dynamics 365 Customer Engagement
Content Source: ce/developer/clientapi/reference/Xrm-Utility/getEntityMetadata.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

This is a known problem (#81) and it really needs to be either documented or fixed.

Closing this issue as its tracked through https://github.com/MicrosoftDocs/dynamics-365-customer-engagement/issues/81.


Public container images: Use ECR public, not private where appropriate

Following the Docker Hub rate limit changes breaking automated builds, we moved to using ECR to store our container images - these are now pushed into private ECR repos in the platform account.
Now that ECR Public is available we should move to pushing out images into public repositories.
We should define these infrastructure to host these common images and their builds in the platform-infrastructure repository.

We should also use ECR Public for our weco-deploy images.
Should we use ECR Public for everything? 🤔

It looks like ECR public might only be available in us-east-1, which sucks if true: https://github.com/hashicorp/terraform-provider-aws/issues/18047

Hi @alexwlchan
ECR public are created and hosted in us-east-1 but available globally without issue.
See details in my other comment: https://github.com/hashicorp/terraform-provider-aws/issues/18047#issuecomment-815542537

Done.


Replace 'long' with 'int64_t' in public core headers

This fixes #4852, and (hopefully), #4573.

Looks like some further tweaks are needed to some tests on mac

I undid the AVL code changes. That was a deeper rabbit hole than I originally anticipated, and tangential to the original purpose here.

And now, the Mac build is successful.


Builtin support for requiring resource files (css, jpg, etc)

Often, people require resource files from their JavaScript. Until now, this has
mainly been handled by using the module.name_mapper option in the
./flowconfig like so:
module.name_mapper='^(.*).css$' -> 'flow/css'
module.name_mapper='^(.*).(jpg\|png\|gif\|eot\|svg\|ttf\|woff\|woff2\|mp4\|webm)$' -> 'flow/file'

Where flow/css.js would export a css mock and flow/file.js would export
string. This would let you write
const myCSS = require('./myCSS.css');
const myJPG = require('./myJPG.jpg');

This change teaches Flow that it's ok to import and require these resource
files. By default, requiring a resource file returns a string, except for css
which returns void. This hopefully will let code that requires resource files
to work with Flow without the need for configuration.

@facebook-github-bot import

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

cc @gaearon


File missing from google drive

mediapipe_in_bfm53201.npy is missing from the google drive

Hi, that a typo in README, and the mediapipe_in_bfm53201.npy is not needed.


Added example for the url server parameter

I have this example running against a current carto instance, but was hesitant to use a real one since that carto instance can disappear anytime. I think it's worth adding that example to make clear that the URL needs the /user/username, even the console error is meaningful enough to be easy to fix, so not really strong on this suggestion :smile:

I tweaked your suggestion, @jsanz . Can you take a look and tell me if you find it well explained?

Yep, looks good to me


CI: Conformance AKS workflow broken due to az tooling issue

CI failure
Example failure: https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540
Run # Create group
  # Create group
  az group create \
    --name cilium-cilium-873023[1](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:1)562-1-3 \
    --location eastus[2](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:2) \
    --tags usage=cilium-cilium owner=[3](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:3)2036

  # Create AKS cluster
  az aks create \
    --resource-group cilium-cilium-8730231562-1-3 \
    --name cilium-cilium-8730231562-1-3 \
    --location eastus2 \
    --kubernetes-version 1.28 \
    --network-plugin none \
    --node-count 2 \
    --node-vm-size Standard_B2s --node-osdisk-size 30 \
    --generate-ssh-keys
  shell: /usr/bin/bash -e {0}
  env:
    name: cilium-cilium-8730231562-1-3
    cost_reduction: --node-vm-size Standard_B2s --node-osdisk-size 30
    cilium_cli_ci_version:
    job_name: Installation and Connectivity Test
    QUAY_ORGANIZATION: cilium
    QUAY_ORGANIZATION_DEV: cilium
    QUAY_CHARTS_ORGANIZATION_DEV: cilium-charts-dev
    EGRESS_GATEWAY_HELM_VALUES: --helm-set=egressGateway.enabled=true
    CILIUM_CLI_RELEASE_REPO: cilium/cilium-cli
    CILIUM_CLI_VERSION: v0.16.[4](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:4)
    PUSH_TO_DOCKER_HUB: true
    GCP_PERF_RESULTS_BUCKET: gs://cilium-scale-results
    KIND_VERSION: v0.22.0
    KIND_K8S_IMAGE: kindest/node:v1.29.2@sha2[5](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:5)6:51a1434a5397193442f0be2a297b488b[6](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:6)c919ce8a3931be0ce822606ea5ca245
    KIND_K8S_VERSION: v1.29.2
{
  "id": "/subscriptions/986ec55c-1e[7](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:7)7-4e2e-9ca5-dcbb34c7a110/resourceGroups/cilium-cilium-[8](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:8)730231562-1-3",
  "location": "eastus2",
  "managedBy": null,
  "name": "cilium-cilium-8730231562-1-3",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": {
    "owner": "32036",
    "usage": "cilium-cilium"
  },
  "type": "Microsoft.Resources/resourceGroups"
}
WARNING: The behavior of this command has been altered by the following extension: aks-preview
WARNING: SSH key files '/home/runner/.ssh/id_rsa' and '/home/runner/.ssh/id_rsa.pub' have been generated under ~/.ssh to allow SSH access to the VM. If using machines without permanent storage like Azure Cloud Shell without an attached file share, back up your keys to a safe location
ERROR: The command failed with an unexpected error. Here is the traceback:
ERROR: Invalid HTTP date
Traceback (most recent call last):
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_utils.py", line 57, in parse_retry_after
    delay = int(retry_after)
            ^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '15[9](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:9),120'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/az/lib/python3.11/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 664, in execute
    raise ex
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 731, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 701, in _run_job
    result = cmd_copy(params)
             ^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/__init__.py", line 334, in __call__
    return self.handler(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
           ^^^^^^^^^^^^^^^^^^
  File "/opt/az/azcliextensions/aks-preview/azext_aks_preview/custom.py", line 680, in aks_create
    return aks_create_decorator.create_mc(mc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/command_modules/acs/managed_cluster_decorator.py", line 6818, in create_mc
    cluster = self.put_mc(mc)
              ^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/command_modules/acs/managed_cluster_decorator.py", line 6796, in put_mc
    cluster = sdk_no_wait(
              ^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/cli/core/util.py", line 7[10](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:10), in sdk_no_wait
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.[11](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:11)/site-packages/azure/core/tracing/decorator.py", line 76, in wrapper_use_tracer
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/azcliextensions/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/v2024_02_02_preview/operations/_managed_clusters_operations.py", line 2110, in begin_create_or_update
    raw_result = self._create_or_update_initial(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/azcliextensions/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/v2024_02_02_preview/operations/_managed_clusters_operations.py", line 1988, in _create_or_update_initial
    pipeline_response: PipelineResponse = self._client._pipeline.run(  # pylint: disable=protected-access
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/_base.py", line 2[13](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:13), in run
    return first_node.send(pipeline_request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/_base.py", line 70, in send
    response = self.next.send(request)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/_base.py", line 70, in send
    response = self.next.send(request)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/_base.py", line 70, in send
    response = self.next.send(request)
               ^^^^^^^^^^^^^^^^^^^^^^^
  [Previous line repeated 2 more times]
  File "/opt/az/lib/python3.11/site-packages/azure/mgmt/core/policies/_base.py", line 47, in send
    response = self.next.send(request)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_redirect.py", line 181, in send
    response = self.next.send(request)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_retry.py", line 471, in send
    self.sleep(retry_settings, request.context.transport, response=response)
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_retry.py", line 440, in sleep
    slept = self._sleep_for_retry(response, transport)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_retry.py", line 407, in _sleep_for_retry
    retry_after = self.get_retry_after(response)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_retry.py", line [14](https://github.com/cilium/cilium/actions/runs/8730231562/job/23953682540#step:12:14)1, in get_retry_after
    return _utils.get_retry_after(response)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_utils.py", line 76, in get_retry_after
    return parse_retry_after(retry_after)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_utils.py", line 60, in parse_retry_after
    retry_date = _parse_http_date(retry_after)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/az/lib/python3.11/site-packages/azure/core/pipeline/policies/_utils.py", line 43, in _parse_http_date
    raise ValueError("Invalid HTTP date")
ValueError: Invalid HTTP date
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
Error: Process completed with exit code 1.

Fixed by https://github.com/cilium/cilium/pull/32118

It seems like CI failures are around the same time always. I also observed a similar issue in cilium-cli github action, but with a bit different error.:
Client assertion is not within its valid time range. Current time: 2024-04-20T18:29:43.3183451Z, assertion valid from 2024-04-20T18:02:11.0000000Z, expiry time of assertion **2024-04-20T18:07:11.0000000Z.**

This led me to find this issue: https://github.com/Azure/login/issues/372#issuecomment-2056289617

Okay, I was trying to figure out if it's possible to increase the quota in Azure for such requests, but apparently, it's not possible.
Anyway, spreading workflows worked like a charm.


Plan on switch to 64-bit for checked-in SDKs

At some point, our internal checked-in & downloaded version of the Dart SDK that we run our internal tools on should switch from 32-bit to 64-bit.  Maybe we don't want to do this until we actually deprecate 32-bit versions,

The checked-in SDK is currently 64-bit.


[REVIEW] PleasantWeb

Project link
https://github.com/imkrishnasarathi/pleasantweb/

you can take a look here: https://github.com/imkrishnasarathi/PleasantWeb/community


KTLS: SSL_sendfile does not work

I used this configuration witl latest ubuntu 20.4:
./config -d enable-ktls
while KTLS does work, the SSL_sendfile does not work:
start the server in one terminal like this:
$ ../util/shlib_wrap.sh ./openssl s_server -ktls -sendfile -WWW
FILE:s_server.c

start the client in another terminal like this:
$ ../util/shlib_wrap.sh ./openssl s_client -connect localhost
Connecting to <IP_ADDRESS>
CONNECTED(00000003)
Can't use SSL_get_servername
depth=0 CN=server.example
verify error:num=20:unable to get local issuer certificate
verify return:1
depth=0 CN=server.example
verify error:num=21:unable to verify the first certificate
verify return:1
depth=0 CN=server.example
verify return:1
---
Certificate chain
 0 s:CN=server.example
   i:CN=Root CA
   a:PKEY: rsaEncryption, 2048 (bit); sigalg: RSA-SHA256
   v:NotBefore: Jan 14 22:29:46 2016 GMT; NotAfter: Jan 15 22:29:46 2116 GMT
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIDJTCCAg2gAwIBAgIBAjANBgkqhkiG9w0BAQsFADASMRAwDgYDVQQDDAdSb290
IENBMCAXDTE2MDExNDIyMjk0NloYDzIxMTYwMTE1MjIyOTQ2WjAZMRcwFQYDVQQD
DA5zZXJ2ZXIuZXhhbXBsZTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEB
ANVdYGrf/GHuSKqMEUhDpW22Ul2qmEmxYZI1sfw6BCUMbXn/tNXJ6VwcO+Crs7h9
o95tveDd11q/FEcRQl6mgtBhwX/dE0bmCYUHDvLU/Bpk0gqtIKsga5bwrczEGVNV
3AEdpLPvirRJU12KBRzx3OFEv8XX4ncZV1yXC3XuiENxD8pswbSyUKd3RmxYDxG/
8XYkWq45QrdRZynh0FUwbxfkkeqt+CjCQ2+iZKn7nZiSYkg+6w1PgkqK/z9y7pa1
rqHBmLrvfZB1bf9aUp6r9cB+0IdD24UHBw99OHr90dPuZR3T6jlqhzfuStPgDW71
cKzCvfFu85KVXqnwoWWVk40CAwEAAaN9MHswHQYDVR0OBBYEFMDnhL/oWSczELBS
T1FSLwbWwHrNMB8GA1UdIwQYMBaAFHB/Lq6DaFmYBCMqzes+F80k3QFJMAkGA1Ud
EwQCMAAwEwYDVR0lBAwwCgYIKwYBBQUHAwEwGQYDVR0RBBIwEIIOc2VydmVyLmV4
YW1wbGUwDQYJKoZIhvcNAQELBQADggEBAHvTBEN1ig8RrsT716Ginv4gGNX0LzGI
RrZ1jO7lm5emuaPNYJpGw0iX5Zdo91qGNXPZaZ75X3S55pQTActq3OPEBOll2pyk
iyjz+Zp/v5cfRZLlBbFW5gv2R94eibYr4U3fSn4B0yPcl4xH/l/HzJhGDsSDW8qK
8VIJvmvsPwmL0JMCv+FR59F+NFYZdND/KCXet59WUpF9ICmFCoBEX3EyJXEPwhbi
X2sdPzJbCjx0HLli8e0HUKNttLQxCsBTRGo6iISLLamwN47mGDa9miBADwGSiz2q
YeeuLO02zToHhnQ6KbPXOrQAqcL1kngO4g+j/ru+4AZThFkdkGnltvk=
-----END CERTIFICATE-----
subject=CN=server.example
issuer=CN=Root CA
---
No client certificate CA names sent
Peer signing digest: SHA256
Peer signature type: RSA-PSS
Server Temp Key: X25519, 253 bits
---
SSL handshake has read 1365 bytes and written 383 bytes
Verification error: unable to verify the first certificate
---
New, TLSv1.3, Cipher is TLS_AES_256_GCM_SHA384
Server public key is 2048 bit
This TLS version forbids renegotiation.
Compression: NONE
Expansion: NONE
No ALPN negotiated
Early data was not sent
Verify return code: 21 (unable to verify the first certificate)
---
---
Post-Handshake New Session Ticket arrived:
SSL-Session:
    Protocol  : TLSv1.3
    Cipher    : TLS_AES_256_GCM_SHA384
    Session-ID: F8E50E16FCF354FADACA68D3604AB7910A0578D63F8BEA4853178B1925837B27
    Session-ID-ctx:
    Resumption PSK: 5A06BEC0D718D8A341FDFCFFFB5A81623AE0D1876831FB60710DCFC95CE22040FD07DCB53888A2CD79B7BFF122AC07C6
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    TLS session ticket lifetime hint: 7200 (seconds)
    TLS session ticket:
    0000 - 2e 18 77 d1 a1 f4 fa aa-f1 4c a2 b2 07 32 43 ff   ..w......L...2C.
    0010 - 96 e3 6b 1a 95 10 69 06-80 e7 47 b7 cc 30 a6 ec   ..k...i...G..0..
    0020 - 2b 6c 38 5b 1d 69 b1 ac-5f b2 bb fc 64 e7 76 12   +l8[.i.._...d.v.
    0030 - 91 ca 54 64 7b 45 8c 60-43 42 fe bb 1a d4 2c 35   ..Td{E.`CB....,5
    0040 - 8a db 86 34 22 20 89 61-82 bc 44 74 3e 85 f6 20   ...4" .a..Dt>..
    0050 - dc f2 fc 1f 9e 85 28 63-4b e8 80 0b be 99 c5 a0   ......(cK.......
    0060 - 35 e0 85 86 bd 28 62 8c-f5 36 d1 e0 68 9c 7d 02   5....(b..6..h.}.
    0070 - b9 f2 22 2b 78 38 37 f9-a6 bf 89 ed 7e 52 e4 af   .."+x87.....~R..
    0080 - 55 71 dc 9b 1c fb 8c a2-de 40 04 95 03 85 1c fc<EMAIL_ADDRESS>    0090 - c3 05 80 4f ff 2a 20 49-f2 ef d1 8e 6e e4 09 b6   ...O.* I....n...
    00a0 - 72 13 87 9f 0f f5 88 06-5b 9b 84 72 c2 83 fc 9f   r.......[..r....
    00b0 - f8 9f 59 04 2c 02 7d fd-f9 0e 62 f8 f4 42 ff 65   ..Y.,.}...b..B.e
    00c0 - 18 38 8b 41 3b 6d ab 0b-c1 b6 cb 43 70 b0 e2 98   .8.A;m.....Cp...

    Start Time:<PHONE_NUMBER>
    Timeout   : 7200 (sec)
    Verify return code: 21 (unable to verify the first certificate)
    Extended master secret: no
    Max Early Data: 0
---
read R BLOCK
---
Post-Handshake New Session Ticket arrived:
SSL-Session:
    Protocol  : TLSv1.3
    Cipher    : TLS_AES_256_GCM_SHA384
    Session-ID: 3AEB37A1F1CD9C89438ECA679EB61B3A5218FF0C68B96E564A31B756FBEB691D
    Session-ID-ctx:
    Resumption PSK: 1705E7C85427AF8FA90CC5EDCE59ACC81C75B5107667D6EB4D441BE9121A8EA448FFCD595E454EC0BBEA57918F065C0A
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    TLS session ticket lifetime hint: 7200 (seconds)
    TLS session ticket:
    0000 - 2e 18 77 d1 a1 f4 fa aa-f1 4c a2 b2 07 32 43 ff   ..w......L...2C.
    0010 - c0 3c f4 01 99 52 a2 0c-4d a9 38 59 cb ea 0f 3e   .<...R..M.8Y...>
    0020 - fa 22 37 9f 69 f9 b6 49-22 53 39 4e da e1 4d 69   ."7.i..I"S9N..Mi
    0030 - 9d a3 3c e1 66 99 f3 d1-4b 37 b9 01 bd c0 d9 fe   ..<.f...K7......
    0040 - d0 a6 17 1b fd ba 98 00-6a 04 db 8a a1 26 3a 7a   ........j....&:z
    0050 - b1 49 2d 24 59 82 cf 3a-97 bf f5 a2 f2 75 8e 06   .I-$Y..:.....u..
    0060 - 28 08 76 c3 55 12 f3 95-7b a7 f4 8a ca dc 9a 2d   (.v.U...{......-
    0070 - 96 b0 a4 5b f5 b9 97 98-ac a4 69 ca c6 d8 27 68   ...[......i...'h
    0080 - 6f d9 4c cb aa b9 84 f7-ff 78 eb 6d c5 23 6b f1   o.L......x.m.#k.
    0090 - 11 04 a7 13 c6 a0 98 28-5a b1 e2 06 14 4e 15 df   .......(Z....N..
    00a0 - 7f 73 47 a3 dc f5 1e fa-4f ee 50 9b 80 1e 49 86   .sG.....O.P...I.
    00b0 - eb f0 48 23 9a 08 41 56-79 da 5a 6c 2d b1 2a 02   ..H#..AVy.Zl-.*.
    00c0 - 91 4b 58 40 9a 9e 7f 04-6b 13 10 4c 93 bf 08 5b<EMAIL_ADDRESS>
    Start Time:<PHONE_NUMBER>
    Timeout   : 7200 (sec)
    Verify return code: 21 (unable to verify the first certificate)
    Extended master secret: no
    Max Early Data: 0
---
read R BLOCK
GET /s_server.c please
HTTP/1.0 200 ok
Content-type: text/plain

Error SSL_sendfile 's_server.c'
80B287854F7F0000:error:0A000114:SSL routines:SSL_sendfile:uninitialized:ssl/ssl_lib.c:2067:
closed

although the error message is printed in the client terminal, the error happens actually in the server.
The reason is unfortunately not obvious.

I found out, what was wrong: when I did that I forgot to load the kernel module.
after I did sudo modprobe tls the SSL_sendfile started to work.
So I think if that kernel module is not loaded, there should be a message, and the
SSL_sendfile should not be used.

So I think if that kernel module is not loaded,

Or basically any scenario which results in KTLS not being used. The man3 pages document that this functionality is only available if KTLS is, and describes how to test for that. We just don't do that test in s_server.

Ah, yeah, we learned that if the client uses RFC 6066 that will also make the KTLS not usable.

Ah, yeah, we learned that if the client uses RFC 6066 that will also make the KTLS not usable.

Can also happen if KTLS doesn't support the ciphersuite, or if compression is negotiated.

Ah, yeah, we learned that if the client uses RFC 6066 that will also make the KTLS not usable.

This point was already clarified on #17504 , but for the archives: RFC 6066 is the (current) generic "extensions for TLS"  RFC, that documents a large handful of different extensions.  The relevant one here is "max_fragment_length".

To rectify this I'm looking for a canonical function to determine if KTLS is enabled on a connection.
SSL_sendfile uses BIO_get_ktls_send(s->wbio), which requires access to s->wbio. However, SSL_get_wbio may return s->bbio instead of s->wbio, and I'm uncertain whether this is an issue (anyone care to confirm?)
Possibly worth also pointing out that bio_ssl doesn't implement BIO_CTRL_GET_KTLS_{SEND,RECV}, so BIO_get_ktls_{send,recv} won't work on SSL BIOs. Is this intended behaviour?
Broadly speaking:

If there is a canonical way to test whether KTLS is enabled on a SSL object, let me know.
If there isn't, we should probably have one as otherwise it's hard for a consumer of the API to tell if SSL_sendfile will work.
Maybe consider implementing BIO_CTRL_GET_KTLS_{SEND,RECV} via the above API.


Test_mdgraph fails on gfx1030 due to unsupported fused kernels

test_mdgraph fails with unsupported fused kernels for gfx1030 - miopenConvolutionWinogradBiasActiv and miopenConvolutionDirectBiasActivAsm

./bin/test_mdgraph --all
FAILED: krn_name == "miopenSp3AsmConvRxSU_CBA": /dockerx/MIOpen/test/mdgraph.cpp: 118
Aborted (core dumped)

@zjing14 Well, I would generalize the description of the issue. test_mdgraph is a unit test that should be aware of the implementation. Specifically, it must "know" which fused algorithms and kernel names are supported on which GPUs. And that knowledge should be used in the test to avoid testing of unsupported algorithms/kernels. Do you agree?

@atamazov But the logic of test_mdgraph is to make sure fused algorithms supported on all GPUs.

@atamazov Let us refactor the test_mdgraph as you suggested in a separate PR.

Test refactored in #813


Attempt to read property "name" on null

Hello!
I just installed Tablar on a fresh laravel 10.x project. This project was empty except my Model classes. Looks like all default behaivour is working (login redirect, register, etc..)
Anyway, I want work with a public page, then created a "test.blade.php" with the example snippet in my views directory.
@extends('tablar::page')
@section('content')

                        Empty page

            @if(config('tablar','display_alert'))
                @include('tablar::common.alert')
            @endif

@endsection

I have my HomeController with the next content:
use Illuminate\Http\Request;

class HomeController extends Controller
{
    public function __construct()
    {
        /*
         $this
            ->middleware('auth')
            ->except(['index']);
        */
    }
    public function index()
    {
        return view('test');
    }
}

And my web.php file with this content:
use Illuminate\Support\Facades\Route;
use App\Http\Controllers\HomeController;

Auth::routes();

Route::get('/',
    [HomeController::class, 'index']
);

Route::get('/home',
    [HomeController::class, 'index']
);

When I try enter on my homeController route I get this error:
Attempt to read property "name" on null
this error point in the "@endsection" line on my test.blade.php
I am missing some to config to use this page? When I sign in the app with a user, the template works fine. Maybe it's at the time loading my username on the navbar or something. Can I use this tablar to add some public pages?

@juanla @extends('tablar::page') was designed to work only with Auth users. Did you get this error before login?

Yes, the error only happens when I am not logged :)
I though that I can make some public pages with this package, my fault! Thanks a lot for the quick help @takielias


fix broken links and typos on nd4j documents

fixed on those pages like below

backend
documentation
matrixwise
functions

We can't merge this as-is obviously. Can you clean it up and open a new PR?


Latest version broke my config

Hi,
Just uploaded latest version to test french char, done through Arduino IDE OTA, worked fine but looks like my config has gone
The web interface does not allow me to change config anymore

did I missed something ?

That comes from exhausting heap while building the config web page. Make sure you are using updated libraries and that you are using the 'development' branch of WiFiManager. The current update.sh script will update each required library, and the latest version will also checkout the development branch of WiFiManager.

Interesting,
I pulled all latest and got the same thing,
Looks like we pushed the ESP8266 to it's limit. I forked the project and I will create a new branch and try the excellent ESPAsyncWebserver version that I used to have on all of my boards, it's really nice, fast and efficient (it's async). I'll put the web file and config on the SPIFFS and these file can be edited on the fly with a browser, trust me this library is just awesome.

If you are already using the 'development' tree of WiFiManager then make sure you are using the Debug level "NoAssert-NDEBUG" instead of none, as that will strip out a ton of strings. Using the 'update.sh' script and the 'build.sh' scripts will do those automatically. It is tight on memory, which I working to address, but it should work. There are current binaries in the 'bin' directory you can test, too.
It should have plenty of ram for this relatively simple function, but something is either fragmenting or wasting heap. I'm going to add some additional debug messages for ram usage to see if I can track down the problem. I will also look at the lib you linked, to see if it may help. I like sticking with core stuff when possible, as they get updated with the core and are generally more integrated and tested with SDK changes and new versions.

@dragondaud thanks for your answer,
I've published an async version, check the async branch from my fork
It's far from perfect and missing some features, but works fine.
First time setup, you need to upload SPIFFS file system from Arduino IDE to place HTML file and config file. Also copy file from config-sample.json to config.json in data folder, change as your configuration before uploading sketch using IDE menu.

After that upload sketch as usual
Working features:

edit SPIFFS file (http://ip_of_wemos/edit) so you can change config on the fly editing config.json file or even the htm file and css files
current web interface
clock of course
heap memory is no more an issue, no warning at compile time

Sketch uses 392160 bytes (37%) of program storage space. Maximum is 1044464 bytes.
Global variables use 59168 bytes (72%) of dynamic memory, leaving 22752 bytes for local variables. Maximum is 81920 bytes.

Missing features:

http update from web interface not yet handled from webserver.ino, but should be easy to do from aSync library
removed WifiManager, now you can setup directly WiFi SSID and password from config.json file

Also I'll add n option to disable splash screen (draw too much power) so I can test with USB WeMos connected from my computer directly
Let me know if any questions or if you want me to create the PR so you can start to work with

The purpose of WiFiManager is to allow configuration on a new WiFi network without reprogramming, and you cannot /edit without a network connection that already works.


Doubleclicking on passphrase to copy string is buggy

Yosemite Darwin 0.5.1
Passphrase Generation dialog:
If you double-click on the passphrase, here is what you get back as a copied string:
"password": "balding motherly roles pram lodge knuckle different haunted salads drowning tell alpine rejoices potato intended sleepless jeers cedar optical upgrade stunning tubes tissue hedgehog rumble moon razor jolted against I've recorded this in a safe place!"
The "I've recorded this in a safe place!" button label sneaks into the selection area.
Fix: Make sure doubleclicking the string does not select the button label as well

hmm. I can't reproduce this on Linux. @VoidingWarranties?

I can't reproduce either on El Capitan. Maybe it's Yosemite specific?

This seems to have been fixed in the latest silent update that happened yesterday.


Fix IndexOutOfBoundsError in TeX logging

Overview: What does this pull request change?

Fixed bug where an IndexOutOfBoundsError could be thrown while trying to display a TeX compilation failure.

Motivation and Explanation: Why and how do your changes improve the library?

Fixes a bug where if a TeX compilation error occurs on a line not in
the TeX source -- which can happen because of LaTeX post-processing --
then an IndexOutOfBoundsError would be raised as the logging was
formatted.
Adds a test for the above situation
Fixes a situation where too many unrelated lines would be shown
Refactors the involved code

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

@behackl that is everything addressed now


Community ：Add Colossal-AI Integration

Patch Description
Update README to link OPT with Colossal-AI, which is related to the issue #228. Thanks.
I have completed the Meta Open Source CLA.
Testing steps
No need for Metaseq.

Hi @suchenzang , I submit this integration for issue #228. Please let me know if you require any further information or update.

@binmakeswell I meant more like what was actually integrated into Colossal-AI wrt OPT. I currently can't seem to find any technical work to point to for that.

Hi @suchenzang , I have updated related content.
The link in this PR clearly points to Integration part now, which also includes the corresponding example code.
Does it make sense now? Please let me know if you require any further information or update.


Remove accessibility policies page

As of #178, the "Accessibility" top-level page was removed. This left a subpage "Accessibility Policies" no longer linked to, but it still exists in the site:
https://design.login.gov/accessibility/policies/
The proposed changes here adapt the content of this page to a new "Images" page, to include guidance on how login.gov uses illustration, how those illustrations should often be considered decorative, and accessibility recommendations for marking up those images accordingly.
Live preview URL: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-remove-a11y-policies/images/
Screenshot:

Login.gov uses illustration to help guide users and it would be good to provide guidance on how to make those accessible.

That makes sense in the context of how we apply decorative images specifically in our products. I was originally considering removal mostly in treating existing resources like the W3C Decorative Images article as more canonical and up-to-date.

Would love to hear your ideas of where you think this content should live.

I recall a suggestion that we may still have reason to have an "Accessibility" top-level page in the design system website, but tailored more specifically to these sorts of practical guidance.
Maybe we could restore the "Accessibility" page, with a short introduction pointing to the brochure site's accessibility statement, and with the remainder of sections devoted to practical guidance like this?

Login.gov uses illustration to help guide users and it would be good to provide guidance on how to make those accessible.

That makes sense in the context of how we apply decorative images specifically in our products. I was originally considering removal mostly in treating existing resources like the W3C Decorative Images article as more canonical and up-to-date.

Would love to hear your ideas of where you think this content should live.

I recall a suggestion that we may still have reason to have an "Accessibility" top-level page in the design system website, but tailored more specifically to these sorts of practical guidance.
Maybe we could restore the "Accessibility" page, with a short introduction pointing to the brochure site's accessibility statement, and with the remainder of sections devoted to practical guidance like this?

Login.gov uses illustration to help guide users and it would be good to provide guidance on how to make those accessible.

That makes sense in the context of how we apply decorative images specifically in our products. I was originally considering removal mostly in treating existing resources like the W3C Decorative Images article as more canonical and up-to-date.

Would love to hear your ideas of where you think this content should live.

I recall a suggestion that we may still have reason to have an "Accessibility" top-level page in the design system website, but tailored more specifically to these sorts of practical guidance.
Maybe we could restore the "Accessibility" page, with a short introduction pointing to the brochure site's accessibility statement, and with the remainder of sections devoted to practical guidance like this?

🤔 the direction we discussed heading was to have more inline, contextual guidance around accessibility when it comes to the design system. for example, i could see us creating an "illustration" or "images" section and have guidance under there.
@nickttng @anniehirshman-gsa would love your thoughts too!

Login.gov uses illustration to help guide users and it would be good to provide guidance on how to make those accessible.

That makes sense in the context of how we apply decorative images specifically in our products. I was originally considering removal mostly in treating existing resources like the W3C Decorative Images article as more canonical and up-to-date.

Would love to hear your ideas of where you think this content should live.

I recall a suggestion that we may still have reason to have an "Accessibility" top-level page in the design system website, but tailored more specifically to these sorts of practical guidance.
Maybe we could restore the "Accessibility" page, with a short introduction pointing to the brochure site's accessibility statement, and with the remainder of sections devoted to practical guidance like this?

🤔 the direction we discussed heading was to have more inline, contextual guidance around accessibility when it comes to the design system. for example, i could see us creating an "illustration" or "images" section and have guidance under there.
@nickttng @anniehirshman-gsa would love your thoughts too!

Sounds like we need to raise the communication bandwidth on this 🤔 I'll add to the agenda for an upcoming UX Huddle so we can have a sync conversation with everyone instead of in GH comments 😄 (more inclusive)

Sounds like we need to raise the communication bandwidth on this 🤔 I'll add to the agenda for an upcoming UX Huddle so we can have a sync conversation with everyone instead of in GH comments 😄 (more inclusive)

Discussed in our huddle. @aduth is going to update this PR (or create a new PR, whatever you think makes more sense!) so that this content lives within our system to include image accessibility guidance.

Discussed in our huddle. @aduth is going to update this PR (or create a new PR, whatever you think makes more sense!) so that this content lives within our system to include image accessibility guidance.

I pushed an update which introduces a new "Images" top-level page:
https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-remove-a11y-policies/images/
From the updated pull request description:

The proposed changes here adapt the content of this page to a new "Images" page, to include guidance on how login.gov uses illustration, how those illustrations should often be considered decorative, and accessibility recommendations for marking up those images accordingly.

I'd welcome any feedback on the content or structure of the page (cc @Danielle-Lee @cannandev).
Live preview URL: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-remove-a11y-policies/images/

I pushed an update which introduces a new "Images" top-level page:
https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-remove-a11y-policies/images/
From the updated pull request description:

The proposed changes here adapt the content of this page to a new "Images" page, to include guidance on how login.gov uses illustration, how those illustrations should often be considered decorative, and accessibility recommendations for marking up those images accordingly.

I'd welcome any feedback on the content or structure of the page (cc @Danielle-Lee @cannandev).
Live preview URL: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-remove-a11y-policies/images/

Looks great as a top level item!
Seeing it now, as a top level item, makes it stand out as one of our principles. I prefer this approach than  listing Images under Components, which are really samples of code -- not principles.

Looks great as a top level item!
Seeing it now, as a top level item, makes it stand out as one of our principles. I prefer this approach than  listing Images under Components, which are really samples of code -- not principles.

Can we make a content edit to this sentence? (last sentence, first paragraph under Accessibility Guidance)
Current: To help prevent confusing, redundant and/or tedious experience, we at Login.gov have set decorative images to be hidden from screen readers.
Proposed change:  We set decorative images as "hidden" from screen readers to help prevent a confusing, redundant and/or a tedious experience.

Can we make a content edit to this sentence? (last sentence, first paragraph under Accessibility Guidance)
Current: To help prevent confusing, redundant and/or tedious experience, we at Login.gov have set decorative images to be hidden from screen readers.
Proposed change:  We set decorative images as "hidden" from screen readers to help prevent a confusing, redundant and/or a tedious experience.

Thanks @cannandev @Danielle-Lee ! I updated the text in 3916b23. I agree it reads much better this way. Thanks.

Thanks @cannandev @Danielle-Lee ! I updated the text in 3916b23. I agree it reads much better this way. Thanks.

@aduth great work. What do you think about moving the content here to our new "Images" section: https://design.login.gov/brand/#illustration
And then removing it from the Brand section completely.

@aduth great work. What do you think about moving the content here to our new "Images" section: https://design.login.gov/brand/#illustration
And then removing it from the Brand section completely.

@aduth great work. What do you think about moving the content here to our new "Images" section: https://design.login.gov/brand/#illustration
And then removing it from the Brand section completely.

@juliaelman Yeah, I think it could make sense, at least as far as avoiding fragmentation of guidance around illustration. If I recall correctly, was there also some desire to do away with the "Brand" page entirely as well? The only reservation I might have is that the use of illustration as it relates to brand could still be relevant. But if we plan to move out more of the Brand content, it does feel like Images would be the best spot for this illustration guidance.

@aduth great work. What do you think about moving the content here to our new "Images" section: https://design.login.gov/brand/#illustration
And then removing it from the Brand section completely.

@juliaelman Yeah, I think it could make sense, at least as far as avoiding fragmentation of guidance around illustration. If I recall correctly, was there also some desire to do away with the "Brand" page entirely as well? The only reservation I might have is that the use of illustration as it relates to brand could still be relevant. But if we plan to move out more of the Brand content, it does feel like Images would be the best spot for this illustration guidance.

@aduth @cannandev I've updated the images page to include some introductory content (71f041d), as well as removed an image we are no longer using in the product (0ff6281).

@aduth @cannandev I've updated the images page to include some introductory content (71f041d), as well as removed an image we are no longer using in the product (0ff6281).

@juliaelman Yeah, I think it could make sense, at least as far as avoiding fragmentation of guidance around illustration. If I recall correctly, was there also some desire to do away with the "Brand" page entirely as well? The only reservation I might have is that the use of illustration as it relates to brand could still be relevant. But if we plan to move out more of the Brand content, it does feel like Images would be the best spot for this illustration guidance.

Following up here. We talked about leaving Brand in the design system for now and that we will create a press kit section on login.gov (footer). I'll create a ticket for that so we can track that work.

@juliaelman Yeah, I think it could make sense, at least as far as avoiding fragmentation of guidance around illustration. If I recall correctly, was there also some desire to do away with the "Brand" page entirely as well? The only reservation I might have is that the use of illustration as it relates to brand could still be relevant. But if we plan to move out more of the Brand content, it does feel like Images would be the best spot for this illustration guidance.

Following up here. We talked about leaving Brand in the design system for now and that we will create a press kit section on login.gov (footer). I'll create a ticket for that so we can track that work.

Looks good and reads well to me 👍

Looks good and reads well to me 👍

@juliaelman LGTM! What do you think about changing Accessibility Guidelines to Be accessible? Am I going overboard with the alliterations?

@juliaelman LGTM! What do you think about changing Accessibility Guidelines to Be accessible? Am I going overboard with the alliterations?

@cannandev I think that is a great idea! Updated here 17f7c17

@cannandev I think that is a great idea! Updated here 17f7c17


Update http links

@NextTurn : Thanks for your contribution! The author, @rohinkoul, has been notified to review your proposed change.

#sign-off

@KumudD: I'm sorry - only the author of this article, @rohinkoul, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Update README.md

To check Git update feature from ADE side updated this file.

Just I wanted to merge these changes to verify ADE functionality.


Update go.mods to use latest version of k8s.io/client-go

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/ok-to-test

@tingrui-AWS-EKS-auth I think you are missing a corresponding change in a go.sum file:
go<EMAIL_ADDRESS>missing go.sum entry for go.mod file; to add it:
	go mod download k8s.io/api
go: downloading k8s.io/kubernetes v1.26.1
go<EMAIL_ADDRESS>missing go.sum entry for go.mod file; to add it:
	go mod download k8s.io/api
Cleaning up test role aws-iam-authenticator-test-role-6394
make: *** [Makefile:119: integration] Error 1
+ EXIT_VALUE=2
+ set +o xtrace

/retest


[BUG]: TTS voice on macOS sounds too whispy when using a Siri based voice.

How are you running AnythingLLM?
AnythingLLM desktop app
What happened?
I'm running AnythingLLM on an intel-based MacBook Pro (2019) running Sonoma 14.5.  If I select any Siri based voice, like English (US) Voice 3, it sounds very airy and it's very difficult to understand.
Are there known steps to reproduce?
No response

Also, it doesn't seem to honor the speed setting under: Settings > Accessibility > Spoken Content.

We use the Electron/Chromium-based TTS provider engine. The voice is rendered via that process and is not something we directly control. We simply pass the text to the TTS provider and it is read. It is essentially an accesibility tool


Crash in FIRAAppDelegateProxy application:openURL

[REQUIRED] Step 2: Describe your environment

Xcode version: 9.3
Firebase SDK version: Firebase/Core 4.10.1
Firebase Component: Core
Component versions:

    - FirebaseAnalytics (= 4.1.0)
    - FirebaseCore (= 4.0.17)
  - FirebaseAnalytics (4.1.0):
    - FirebaseCore (~> 4.0)
    - FirebaseInstanceID (~> 2.0)
    - GoogleToolboxForMac/NSData+zlib (~> 2.1)
    - nanopb (~> 0.3)
  - FirebaseCore (4.0.17):
    - GoogleToolboxForMac/NSData+zlib (~> 2.1)
  - FirebaseInstanceID (2.0.9):
    - FirebaseCore (~> 4.0)

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
Crash report received on Bugsnag.  I can't repro the issue.
Relevant Code:
      FirebaseApp.configure()

Stacktrace:

0  libswiftCore.dylib swift_getObjectType
1  Recharge           application (AppDelegate.swift)
2  Recharge           -[FIRAAppDelegateProxy application:openURL:sourceApplication:annotation:] (Recharge)
3  UIKit              ___58-[UIApplication _applicationOpenURLAction:payload:origin:]_block_invoke
4  UIKit              -[UIApplication _applicationOpenURLAction:payload:origin:]
5  UIKit              -[UIApplication _handleNonLaunchSpecificActions:forScene:withTransitionContext:completion:]
6  UIKit              -[__UICanvasLifecycleMonitor_Compatability activateEventsOnly:withContext:completion:]
7  UIKit              ___82-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]_block_invoke
8  UIKit              -[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]
9  UIKit              ___125-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]_block_invoke
10 UIKit              __performActionsWithDelayForTransitionContext
11 UIKit              -[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]
12 UIKit              -[_UICanvas scene:didUpdateWithDiff:transitionContext:completion:]
13 UIKit              -[UIApplicationSceneClientAgent scene:handleEvent:withCompletion:]
14 FrontBoardServices ___80-[FBSSceneImpl updater:didUpdateSettings:withDiff:transitionContext:completion:]_block_invoke.362

I do have an implementation of func application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) but I don't see a call to it, which makes me think it's something in the FIRAAppDelegateProxy that's blowing up.

Maybe worth noting: I just released the version of our app that upgrades to Firebase/Core 4.10.1 this morning.  The crash has happened three times, to two separate users.  I tried testing out our deep link support and it works fine, so there's something I'm not seeing about the cause here.

I got same issue.
xcode 9.2 is fine
xcode 9.3 build is ok, when i run my app, got crash
my podfile.
pod 'Firebase/Core'
pod 'Firebase/Crash'
pod 'Firebase/DynamicLinks'
I installed
Installing Firebase (4.11.0)
Installing FirebaseAnalytics (4.1.0)
Installing FirebaseCore (4.0.18)
Installing FirebaseCrash (2.0.2)
Installing FirebaseDynamicLinks (2.3.2)
Installing FirebaseInstanceID (2.0.10)
same relevant code
FirebaseApp.configure()
I think firebase sdk not support for xcode9.3(swfit4.1).

I can confirm this issue.
Crash when running xcode 9.3.
 FirebaseApp.configure()
Went and grabbed xcode 9.2 from Apple and there the code runs just fine without any changes.
However, when setting up a new target inside 9.3 and creating a new project in Firebase, it runs fine.
Existing targets crash, while new once work fine. Same code for all targets.
Running latest Firebase SDK

Thanks for the info. Perhaps it's something related to Xcode options.
We haven't yet been able to reproduce. Is anyone able to share a reproducible example?

4.12.0 fixed the issue

Got the same thing in my app:
These are crashreports from Crashlytics:
0 libswiftCore.dylib | swift_getObjectType + 60
1 | <app> | AppDelegate.swift line 0@objc AppDelegate.application(UIApplication, open : URL, sourceApplication : String?, annotation : Any) -> Bool
2 | <app> | -[FIRAAppDelegateProxy application:openURL:sourceApplication:annotation:] +<PHONE_NUMBER>
3 | UIKit | __58-[UIApplication _applicationOpenURLAction:payload:origin:]_block_invoke + 876
4 | UIKit | -[UIApplication _applicationOpenURLAction:payload:origin:] + 640

Haven't been able to reproduce. This happened on both iOS 11.3 and 11.2.6 on all kinds of devices. A common thing for them all is that the device is low on RAM.

I'm seeing the same issue after building my app from Xcode 9.3. My app authenticates with Spotify and when my app's URLScheme is opened from Safari, the app crashes. It never makes it to application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) -> Bool where I handle the login.

We just had a very similar issue at our end. 100% reproducible as well.
Our issue happened due to authentication with the Facebook SDK (so probably similar to @jkmartin19's issue). When logging in with the Facebook App (note: doesn't happen when logging in through the Facebook website), the Facebook callback is most likely calling application(_:open:sourceApplication:annotation:), which then leads to the crash.
Our solution was simple: Just don't implement application(_:open:sourceApplication:annotation:). It has been deprecated since iOS9 anyway. The Facebook SDK luckily has a replacement callback to application(_:open:options:).
Here's our stack trace of the crash:
Thread 1 Queue : com.apple.main-thread (serial)
#0	0x0000000106c1faa4 in swift_getObjectType ()
#1	0x00000001028a86dc in @objc AppDelegate.application(_:open:sourceApplication:annotation:) ()
#2	0x0000000102edb068 in -[FIRAAppDelegateProxy application:openURL:sourceApplication:annotation:] ()
#3	0x000000018c770acc in __58-[UIApplication _applicationOpenURLAction:payload:origin:]_block_invoke ()
#4	0x000000018c770440 in -[UIApplication _applicationOpenURLAction:payload:origin:] ()
#5	0x000000018c38ce20 in -[UIApplication _handleNonLaunchSpecificActions:forScene:withTransitionContext:completion:] ()
#6	0x000000018c355f04 in -[__UICanvasLifecycleMonitor_Compatability activateEventsOnly:withContext:completion:] ()
#7	0x000000018cfeb72c in __82-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]_block_invoke ()
#8	0x000000018c355268 in -[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:] ()
#9	0x000000018cdd09b8 in __125-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]_block_invoke ()
#10	0x000000018cf1eae8 in _performActionsWithDelayForTransitionContext ()
#11	0x000000018c354c88 in -[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:] ()
#12	0x000000018c354624 in -[_UICanvas scene:didUpdateWithDiff:transitionContext:completion:] ()
#13	0x000000018c3923b0 in -[UIApplicationSceneClientAgent scene:handleEvent:withCompletion:] ()
#14	0x0000000184fb8f24 in __80-[FBSSceneImpl updater:didUpdateSettings:withDiff:transitionContext:completion:]_block_invoke.362 ()
#15	0x00000001074c5220 in _dispatch_client_callout ()
#16	0x00000001074d1850 in _dispatch_block_invoke_direct ()
#17	0x0000000184fec878 in __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ ()
#18	0x0000000184fec51c in -[FBSSerialQueue _performNext] ()
#19	0x0000000184fecab8 in -[FBSSerialQueue _performNextFromRunLoopSource] ()
#20	0x0000000182763404 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ()
#21	0x0000000182762c2c in __CFRunLoopDoSources0 ()
#22	0x000000018276079c in __CFRunLoopRun ()
#23	0x0000000182680da8 in CFRunLoopRunSpecific ()
#24	0x0000000184663020 in GSEventRunModal ()
#25	0x000000018c66178c in UIApplicationMain ()
#26	0x00000001028ab624 in main at /FooBar/AppDelegate.swift:27
#27	0x0000000182111fc0 in start ()

We had the same crashes and it's related to a bug in swift 4.1 / XCode 9.3 reported here :
https://bugs.swift.org/browse/SR-7240?focusedCommentId=33771&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-33771
Our crashes were reproducible when opening a deep link.
And as @EmDee it was because we had implemented :
   func application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) -> Bool
We just replaced it with :
   func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool
That fixed our crashes. Hope it helps others.

Please note for those that can’t just remove that delegate call: In @LaurentLK’s link there is a very simple workaround fix, which I’ve seen in other people’s code as well, where you only have to change the annotation type from Any to Any?.

I had suspected the upgrade from Firebase 4.10.0 to 4.10.1 as the issue, so I downgraded back to 4.10.0, but the issue is still happening.  Definitely doesn't seem like an actual issue with Firebase SDK at this point, I'm just gonna upgrade to 4.12.0 and make a release with the above workaround.  @paulb777 feel free to close this if you want?  Thanks all!

Thanks everyone for the research, analysis and shares! 💯

Had the same bug using Xcode 9.3 when updating from Firebase 3.11.0 (I know!!) to 4.13.0. So the issue (in Swift?) persists.  @LaurentLK 's fix crushed it.  Thanks!  🙏

This is not fixed.
I am still getting this error using the following versions:
pod 'Firebase/Core', '~> 4.13.0'
pod 'Firebase/AdMob', '~> 4.13.0'
Xcode: 9.3.1
the stacktrace:

0
libswiftCore.dylib
swift_getObjectType + 60

1
Eu Sei
MyDelegate.swift line 0@objc MyDelegate.application(UIApplication, open : URL, sourceApplication : String?, annotation : Any) -> Bool

2
Eu Sei
-[FIRAAppDelegateProxy application:openURL:sourceApplication:annotation:] + 3093356

3
UIKit
__58-[UIApplication _applicationOpenURLAction:payload:origin:]_block_invoke + 880

4
UIKit
-[UIApplication _applicationOpenURLAction:payload:origin:] + 596

5
UIKit
-[UIApplication _handleNonLaunchSpecificActions:forScene:withTransitionContext:completion:] + 5468

6
UIKit
-[__UICanvasLifecycleMonitor_Compatability activateEventsOnly:withContext:completion:] + 1632

7
UIKit
__82-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]_block_invoke + 296

8
UIKit
-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:] + 432

9
UIKit
__125-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]_block_invoke + 220

10
UIKit
_performActionsWithDelayForTransitionContext + 112

11
UIKit
-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:] + 248

12
UIKit
-[_UICanvas scene:didUpdateWithDiff:transitionContext:completion:] + 368

13
UIKit
-[UIApplicationSceneClientAgent scene:handleEvent:withCompletion:] + 468

14
FrontBoardServices
__80-[FBSSceneImpl updater:didUpdateSettings:withDiff:transitionContext:completion:]_block_invoke.362 + 212

15
libdispatch.dylib
_dispatch_client_callout + 16

16
libdispatch.dylib
_dispatch_block_invoke_direct$VARIANT$mp + 224

17
FrontBoardServices
FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK + 36

18
FrontBoardServices
-[FBSSerialQueue _performNext] + 404

19
FrontBoardServices
-[FBSSerialQueue _performNextFromRunLoopSource] + 56

20
CoreFoundation
CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 24

21
CoreFoundation
__CFRunLoopDoSources0 + 276

22
CoreFoundation
__CFRunLoopRun + 1204

23
CoreFoundation
CFRunLoopRunSpecific + 552

24
GraphicsServices
GSEventRunModal + 100

25
UIKit
UIApplicationMain + 236

26
Eu Sei
MyDelegate.swift line 18main

27
libdyld.dylib
start + 4

@deguilardi did you take a look at @LaurentLK'x fix here?
Also, please note that Firebase is currently on version 5.0.1. If you are able to reproduce there, please let me know and I'll take a look.

@ryanwilson I need the parameters sourceApplication and annotation. The proposed solution requires not using these parameters.
I am currently using the version 4.13.0. The changelog doesn't point to any fix related to this issue.
Changelog link: https://firebase.google.com/support/release-notes/ios

@deguilardi As mentioned previously this issue is not related to Firebase at all.
You need to replace:
func application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) -> Bool
By:
func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool
If you need source and annotation you just need to get them from the options dictionary with the following keys UIApplicationOpenURLOptionsKey.sourceApplication and UIApplicationOpenURLOptionsKey.sourceApplication. annotation

How can this error not be related to Firebase if it breaks on
[FIRAAppDelegateProxy application:openURL:sourceApplication:annotation:]
???
Firebase manual itself is teaching to do the "wrong" way:
https://firebase.google.com/docs/dynamic-links/ios/receive

@deguilardi As pointed out above, there is a Swift issue.
@dmandar would you review the Dynamic Links documentation link above.

The [FIRAAppDelegateProxy application:openURL:sourceApplication:annotation:] should only be used on iOS8 and older as stated in the documentation. @deguilardi what iOS version is this breaking at for you?

You can prevent Firebase from swizzling the methods in your AppDelegate by adding FirebaseAppDelegateProxyEnabled set to NO in your app's info.plist

@chetandobariya : Keep in mind that if you decide to turn off FirebaseAppDelegateProxy, you will lose all automatic campaign events which are important to Analytics. So please follow the instructions at FIRAnalytics+AppDelegate.h to avoid missing campaign events.

@baolocdo  Thanks for the sharing information. I will have a look. but for my case, I am only using remote configuration from Firebase SDK.


Set ulimit number by default

I think the default value for the ulimit should be set by default.
After days of crashes, and various conversations in the IRC chanel, I discovered that kafka was exceeding the maximum number of open files.
Someone pointed out that this cookbook can set the ulimit right inside of the upstart file.
https://github.com/bmhatfield/chef-ulimit/issues/38
Even users with simple configurations will run out of open files. Should the limit be set by default?

My opinion is that the limit shouldn't be set by default. Personally I prefer when cookbooks makes as little decisions as possible on their own, and where things are as configurable as possible (to an extent when it just becomes cumbersome to use).
Furthermore, I believe that it's pretty difficult to set a reasonable default limit as it depends on what kind of infrastructure we're talking about (i.e. shared resources using something like Mesos or a system where Kafka is the only thing running). Why would 64k be better than for example 32k for example?

Agreed that the cookbook shouldn't set a system wide limit. But since this limit is only for the kafka user, the influence should be minimal.
Perhaps there is some middle ground? Not setting a default leads to a bad out of the box user experience because kafka will work for a short period and then crash. It took me a long time to figure out why the cookbook wasn't just working out of the box. Maybe a warning in the README would be appropriate?

A heads up section in the README would definitely be appropriate.


Update dropzone version

Please keep package updatet to latest dependencies. it is 5.7.0 now

You're free to open a pull request with the required changes.


Core dump on Ubuntu if tests are run when MySQL service is stopped

vagrant@vagrant-ubuntu-trusty-64:~$ node --version
v4.2.1
vagrant@vagrant-ubuntu-trusty-64:~$ npm --version
2.14.8
vagrant@vagrant-ubuntu-trusty-64:~$ git clone https://github.com/mscdex/node-mariasql.git
Cloning into 'node-mariasql'...
remote: Counting objects: 2986, done.
remote: Compressing objects: 100% (4/4), done.
Receiving objects: 100% (2986/2986), 6.46 MiB | 3.77 MiB/s, done.
remote: Total 2986 (delta 0), reused 0 (delta 0), pack-reused 2982
Resolving deltas: 100% (1358/1358), done.

Aborted (core dumped)
npm ERR! Test failed.  See above for more details.
vagrant@vagrant-ubuntu-trusty-64:~/node-mariasql$ sudo service mysql start
mysql start/running, process 13096
vagrant@vagrant-ubuntu-trusty-64:~/node-mariasql$ npm test

><EMAIL_ADDRESS>test /home/vagrant/node-mariasql
> node test/test.js

Executing "Client::version()"
Finished "Client::version()"
Executing "Client::escape()"
Finished "Client::escape()"
Executing "prepare()"
Finished "prepare()"
Executing "Non-empty threadId"
Finished "Non-empty threadId"
Executing "Empty threadId (explicit disable)"
Finished "Empty threadId (explicit disable)"
Executing "escape()"
Finished "escape()"
Executing "isMariaDB()"
Finished "isMariaDB()"
Executing "serverVersion()"
Finished "serverVersion()"
Executing "Buffered result (defaults)"
Finished "Buffered result (defaults)"
Executing "Buffered result (useArray)"
Finished "Buffered result (useArray)"
Executing "Buffered result (metadata)"
Finished "Buffered result (metadata)"
Executing "Streamed result (defaults)"
Finished "Streamed result (defaults)"
Executing "Streamed result (useArray)"
Finished "Streamed result (useArray)"
Executing "Streamed result (metadata)"
Finished "Streamed result (metadata)"
Executing "Streamed result (INSERT)"
Finished "Streamed result (INSERT)"
Executing "Streamed result (START TRANSACTION, no data listener)"
Finished "Streamed result (START TRANSACTION, no data listener)"
Executing "lastInsertId()"
Finished "lastInsertId()"
Executing "multiStatements"
Finished "multiStatements"
Executing "Process queue before connection close"
Finished "Process queue before connection close"
Executing "Abort long running query"
Finished "Abort long running query"
Executing "Abort connection"
Finished "Abort connection"
Executing "clean up pending queries on close"
Finished "clean up pending queries on close"
Executing "keep pending queries on close"
Finished "keep pending queries on close"
vagrant@vagrant-ubuntu-trusty-64:~/node-mariasql$

Seems similar to https://github.com/mscdex/node-mariasql/issues/22

For reference here is the line in question: https://github.com/mscdex/node-mariasql/blob/1dd932281d7800f1fb0100883e43f64fc1c06f56/src/binding.cc#L924

@blah238 A better version of the original fix has now been landed in f77b0c4de and 9cc00486d3. Let me know if it works for you too.

@mscdex Yep that looks like it's working, thanks!


How to make a default active/focused field?

I'm struggling to make the field focused by default. According to the docs http://erikras.github.io/redux-form/#/api/props?_k=0xp7pg there is an active prop to be passed, but it doesn't work. I also tried dispatching focus action on mounting the form, but still no success.
<MyForm initialValues={ { token, content, id } }
        formKey={ id.toString() }
        active="content"
        onCancel={ this._handleCancelForm } />

I'm using v3.0.6

No, the active prop is readonly and informational to the wrapped component. Nor does the FOCUS action affect the DOM.
You'll have to manipulate the DOM yourself.
componentDidMount() {
  this.refs.contentInput.focus();
}

@erikras thank you for quick response!


Fix/bad fork config merge2

Fixup broken merge from https://github.com/MinaProtocol/mina/pull/14864.

!ci-build-me

!approved-for-mainnet


Create new test packages that reference internal packages

This PR makes new definitions in test/ for functions and types that are internal in hcsshim. The goal of this PR is to make cri-containerd tests no longer rely on internal definitions.
This PR is the first part in a move to take the cri-containerd tests out of the hcsshim repository.
Note: this does not include a change for internal/memory since the only type referenced is that for megabyte size which is well known and can just be redefined as needed.

Linter seems to be referencing a package that no longer exists and is no longer referenced anywhere in the code. May be an issue with the CI's mod cache.

can we rename common/ to pkg/, and then move definitions/ under it to be hcsshim/test/pkg/definitions?
That way we can consolidate all the things we expose?

my only nit would be to add a test/pkg/doc.go that says something to the effect of:

@helsaawy Added. Will merge on CI passing.


use application insights in net core 6.0 with azure ad

Hello,i am using Application insights in net core 6.0, and the nuget packages are below:

my sample is below:

But i can not get any log message in my portal, is there anything wrong with my code?
Thanks a lot.

Here is my configuration of azure portal,and i have set the Local authentication to disabled

Hello @TimothyMothra ,I have checked my configuration and found a new question:
When i connect to the application by azure ad ClientSecretCredential, the exception was thrown:

my code is below:

i set the authorityHost to AzureAuthorityHosts.AzureChina but it always tried to connect to https://monitor.azure.com/.
Is there any other configuration for the ClientSecretCredential in China?
Thanks a lot.

Hello @TimothyMothra
I find the source code of SetAzureTokenCredential and the scope is set to https://monitor.azure.com//.default.

So how can i config the the  scope of azure monitor in Azure China?

Hello @JorinZhu, to the best of my knowledge AAD is not yet available in Azure China.
Our teams are currently working on this, but I don't know the exact timeline.
You've found the exact issue in the SDK, the scope will need to be changed to support additional AAD Environments.
I just created a PR to share the Proof of Concept of how this may work: #2623.


👌 IMPROVE: Add comments, bit refactoring, docs, test for latex

@mmcky Adding a picture of a latex output alongside directives was looking a bit weird. Should I go ahead and add it? or if you have a better idea of highlighting this feature properly. At present just added here: https://github.com/executablebooks/sphinx-exercise/pull/34/files#diff-fe2f3439fff0648f2185e11c2a7fc6c0be3109e06acdcf9a5ed16bf73bdc2198R19

Codecov Report

Merging #34 (5d957e6) into master (ee0f065) will increase coverage by 7.11%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   88.71%   95.83%   +7.11%
==========================================
  Files           4        4
  Lines         381      384       +3
==========================================
+ Hits          338      368      +30
+ Misses         43       16      -27

Flag
Coverage Δ

pytests
95.83% <96.29%> (+7.11%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sphinx_exercise/utils.py
86.48% <80.00%> (+20.86%)
:arrow_up:

sphinx_exercise/__init__.py
95.65% <93.33%> (+0.09%)
:arrow_up:

sphinx_exercise/directive.py
98.73% <100.00%> (-0.02%)
:arrow_down:

sphinx_exercise/nodes.py
97.61% <100.00%> (+23.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0f065...5d957e6. Read the comment docs.

@AakashGfude any chance #29 is fixed by this refactoring work?

#29

Yes, I think it should. I will verify it.


Change deprecations from 6.0 to 5.8

1. Why is this change necessary?
This project will never reach version 6.0 in favor of shopware/platform. That means, these deprecations will never be removed unless the target version for their removal is reduced. Without this change these deprecations are meaningless.
2. What does this change do, exactly?
Change the target version of deprecations from 6.0 to 5.8.
3. Describe each step to reproduce the issue or behaviour.
None.
4. Please link to the relevant issues (if any).
None.
5. Which documentation changes (if any) need to be made because of this PR?
None.
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hey @jkrzefski,
we had an internal discussion about this PR.
We think the overall benefit of actually fixing those deprecations with 5.8 is not worth the time.
Also, this would ultimately lead to a huge amount of inevitable breaks for pleeeenty of plugins.
Thus we'd be more happy if you could just remove those deprecation comments instead.

So deprecation comments regarding 6.0 are not worth anything?
We see deprecation marks since 5.2 (3+ years). Believe in it. And now we just get ditched with a shopware 6?
So there is no intention to improve the overall quality of the product at these points anymore?
Is shopware 5 itself now deprecated?!

I think it would be ok, if there is a deprecation change to SW5.8 and in the same step changing all code to the alternative.
Another PR for the 5.8 branch, which removes the old code.
Maybe not all at once, which was done here, but maybe step by step
what do you think @shopwareBot ?

Hey,
on the last scd we said we want to focus on compatibility and stability. With the deprecations inside this PR we don't win any benefit. It looks better, but makes work for plugin developers. So in our limited time we want to focus on that and break things only if it's really necessary.
These deprecations are still in use (searched in all plugins in store)
In the next minor version the breaks are only from dependencies we had to update to ensure the compatibility in the support time.
So I hope I could explain our point of view. This all does not mean that Shopware 5 is deprecated. It's still in development, but we are focusing on compatibility and stability.
That's the whole reason why we decided to remove the deprecation.

@shopwareBot @shyim I now have removed the deprecation comments.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25194
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:


Add TypeScript type definitions

Hey 👋
First of all, great project!
I would like to use this in one of my TypeScript projects to help with debugging but I have had to write my own TypeScript types.
I thought I may as well push them up for anyone else who wants to use this library with TS :rocket:

Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?

@sindresorhus
I have updated the definitions to match the style guide now :+1:

Any update on this @sindresorhus? :eyes:

Hey, sorry for the slow reply. I just had way too many PRs to review. I'm getting it down to a more manageable number now. I've manually merged in your changes and released: https://github.com/sindresorhus/unstated-debug/releases/tag/v0.4.0


⚠ Fortnite has degraded performance

In e599388, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1518 ms

Resolved: Fortnite performance has improved in 0a80235.


worker: Refactor many components

I want to begins with: Sorry, big patch here, got taken away when I started cleaning a few thing to get from a topic message to a pipeline executed.
Anyway, overall this clean things up, remove a few interdependancies and create a few meaning lifecycle for message.
This now look like:

Proof this thing works!
DEBUG:asyncio:Using selector: KqueueSelector
INFO:saturn_engine.worker.broker.Broker:Starting worker
INFO:saturn_engine.worker.broker.Broker:Worker sync: WorkSync(queues=ItemsSync(add=[SchedulableQueue(iterable=<async_generator object ExecutableQueue.run at 0x10ebe8280>), SchedulableQueue(iterable=<async_generator object ExecutableQueue.run at 0x10ebe83a0>)], drop=[]), tasks=ItemsSync(add=[], drop=[]))
INFO:saturn_engine.worker.queues.rabbitmq.RabbitMQQueue:Starting queue q2
INFO:saturn_engine.worker.queues.rabbitmq.RabbitMQQueue:Starting queue q1
DEBUG:aio_pika.connection:Creating AMQP channel for connection: <RobustConnection: "amqp://<IP_ADDRESS>/" 0 channels>
DEBUG:aio_pika.connection:Channel created: <RobustChannel "None#Not initialized channel">
DEBUG:aio_pika.connection:Creating AMQP channel for connection: <RobustConnection: "amqp://<IP_ADDRESS>/" 0 channels>
DEBUG:aio_pika.connection:Channel created: <RobustChannel "None#Not initialized channel">
DEBUG:aio_pika.queue:Declaring queue: <Queue(q2): auto_delete=False, durable=None, exclusive=False, arguments=None>
DEBUG:aio_pika.queue:Declaring queue: <Queue(q1): auto_delete=False, durable=None, exclusive=False, arguments=None>
INFO:saturn_engine.worker.queues.rabbitmq.RabbitMQQueue:Processing queue q2
DEBUG:aio_pika.queue:Start to consuming queue: <Queue(q2): auto_delete=False, durable=None, exclusive=False, arguments=None>
INFO:saturn_engine.worker.queues.rabbitmq.RabbitMQQueue:Processing queue q1
DEBUG:aio_pika.queue:Start to consuming queue: <Queue(q1): auto_delete=False, durable=None, exclusive=False, arguments=None>
DEBUG:saturn_engine.worker.scheduler.Scheduler:task ready: {<Task finished name='Task-7' coro=<<async_generator_asend without __name__>()> result=<saturn_engin...t 0x10ec5e2e0>>}
DEBUG:saturn_engine.worker.broker.Broker:Processing message: <saturn_engine.worker.executable_message.ExecutableMessage object at 0x10ec5e2e0>
DEBUG:saturn_engine.worker.executors.ProcessExecutor:locking resources: set()
hello world!

yolo lgtm


Make bootstrap folder if not present for proxyless

This mirrors the logic in standard envoy bootstrap. Ran into it running
locally, may happen in other non-k8s environments as well
Please provide a description of this PR:

/retest


Navbar Menu Overlapping on the text on Home Section.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When the hamburger menu appears when the screen is shrunk and the navbar menu is opened, the text in the home area is obscured. The poor user experience is to blame.
Steps To Reproduce

Go To Home Section.
Reduce The Window Size Below 990px.
Click Hamburger Option.
Open Navbar Menu.

Expected Behavior
When the navbar menu is opened, the portion should move down, and when it is closed, the section should slide back up to the original position.
Screenshots

Device Information [optional]
- OS: Windows 11
- Browser: Google Chrome
- version: 111.0.5563.65

Additional context
No response
Are you working on this issue?
No

I'm working on this.
@B1TSH3LL

@KIET7UKE Please Explain what changes will you make and what Your PR will do.

Sure,  I plan to adjust the layout to ensure that the home area content remains visible even when the navbar menu is open on smaller screens. I believe this will improve the user experience and prevent the content from being obscured. To achieve this, I plan to modify the CSS of the website and/or add responsive design elements to ensure that the layout adjusts appropriately for different screen sizes.

Hey, @B1TSH3LL I have solve these issue, please assign these issue to me, so I can make a pull request. Here is the video sample:
cinnamon-2023-05-10T200019+0530.webm

Hey @B1TSH3LL is this issue is still open ,I would like to work on this issue , can you please assign it to me?

Hey, Can I work on this issue ?

@tanmoysrt @vedant-jain03 @VaibhavUpreti Can I work on this issue?
Before:
https://github.com/CircuitVerse/CircuitVerse/assets/77102885/87b2870c-e0bb-475b-a129-714fec8300fe
After:
https://github.com/CircuitVerse/CircuitVerse/assets/77102885/d561cf7e-5396-438e-9ab7-6e3399be8e80

@tanmoysrt @vedant-jain03 @VaibhavUpreti Can I work on this issue?
Before:
CV-navbar-before.mp4
After:
CV-navbar-after.mp4

This approach looks very good!
Make sure to keep the desktop navbar the same as before.
You have been assigned!


TRG 7.05: Docker image must contain distribution information

Current Behavior

The container image contains only the code artifacts.
Expected Behavior

Per TRG 7.05, distributables MUST contain legal information. Please note that the information MUST be in the folder containing the application - else it could be confused with legal information for the container.
Sidenote: Currently in puris we have DEPENDENCIES files duplicated which is not recommended, but we started fixing that in this PR. There you can see how you can adapt your Dockerfile to copy files if present. The trick is that the first file in the COPY directive exists while the others are marked as optional with the *. Within workflow you then need to copy the files needed.

@tom-rm-meyer-ISST thank you for performing the Quality Gate Review for the 24.05 release!
The TRG is actually fulfilled: The files are not only added when building the container image, but simply at every build and therefore also when building the container images:
https://github.com/eclipse-tractusx/policy-hub/blob/v1.0.0-rc.2/src/hub/PolicyHub.Service/PolicyHub.Service.csproj#L49
https://github.com/eclipse-tractusx/policy-hub/blob/v1.0.0-rc.2/src/database/PolicyHub.Migrations/PolicyHub.Migrations.csproj#L67
Could you please close the issue?

Oh dear, I was blind during performing a ls -la in the app directory. Thanks for pointing out. Issue is not present :)


Getting 500 when trying to edit an imported person's funding information, changing the year value

@danblah What person and what value to change. Will test and see if I can replicate this issue on live. On my local env it seems to work.

This is from bugs in the migration of content from the old site. Needs to be fixed on a case by case basis. I think most if not all cases have been fixed now.


GeoJSON source issues with viz updates

How to reproduce:

Create a Visualization that uses a GeoJSON source, add a ramp on a property. It should work.
Blend to a new Viz that uses a different property for the color ramp, the ramp will assign the same values to all the elements.

I've noticed that if you specify that second property on the first Viz, the ramp will work fine. I'm guessing VL only keeps the minimum GeoJSON properties it requires, so if you have the property the second update requires, everything works fine.
Here's a codepen that shows the issue, uncomment the variable on the Viz string and everything will work as expected: https://codepen.io/rjimenezda/pen/RwbGbYN

I have encountered the same issue with filters here.


[TACHYON-1027] Log warn message and exception when write fails. Also, change getCurr…

https://tachyon.atlassian.net/browse/TACHYON-1027

LGTM.

Thanks for the log improvement.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5215/
Test PASSed.


Liker bounces out of log in before the first like

Hi Huaying,
Thanks for the amazing crawler, its been working well recently but today when I tried to use the liker it logs in and then it bounces out (returns to the log in screen). This happens right after it opens an image and before it does the first like.
Thank you for your help again!

Hi, the login issue should be fixed.


1.20.4, Bombs and BuyPermissions

Huge thanks to Technofied and @ItsKROKX11

@GomorrhaDev I see you've changed the config.yml, please change the configVersion in Main.java and in supersecretsettings.txt to your new version (when updating, this leads to creating a new config file with the new options). I can't merge till its done.
Also, I'd greatly appreciate if you added explanation for the new permissions to README.md ;)


Avoid repeated calculations of default SwiftUI view name

Goal
Prior to this change, BugsnagTracedView reevaluates getViewName(content:) each time it is initialized without the viewName parameter.
After this change, the default view name is calculated only once for each specialization of the BugsnagTracedView generic type (and is still calculated lazily due to the lazy behavior or static let).
Testing
CI only.

Hi @square-tomb
Thank you for opening this PR with us. The change you have suggested seems reasonable and as I have added it to our backlog to review when priorities allow. We'll be sure to let you know of any updates.

Hi @square-tomb
Unfortunately, this won't work because static stored properties are not supported in generic types. This was a language policy decision in order to avoid requiring separate property storage per parametric type. There's a good explanation of the issue here: https://stackoverflow.com/questions/45467329/extension-may-not-contain-stored-property-but-why-is-static-allowed
If you try to run the unit tests, you should see the Xcode error pop up.

Ah, thank you for pointing that out! I should have attempted to compile the entire type before opening this PR 🙈


create mac address function

this function work get client MAC address by a access on a website or project.
This function call $agent->macAddress();
This function add  src/Agent.php and this function simple call $agent->macAddress(); it show mack address for client . it is 100% work i check .
please check and add this code .
Thanks
karim

i can not change read me file all time edit then it show some check were not successful


exceptions: allow automerge for com.fightcade.Fightcade

The Fightcade client needs to be in sync with the current server version to function. If an update causes breakages the end result is identical to having an outdated Flatpak (the client will not work in either case.)
Allow Flathubbot automerging to keep the client in sync even when a developer with merge access is unavailable.

Note: automerge was removed from the repo in https://github.com/flathub/com.fightcade.Fightcade/commit/71fb933f68e3ff0c6f36656d10275c75eb46d76c to facilitate a Fightcade update (since it was blocking all pull requests due to the linter), but I would preferably like to restore that if an exception is granted.

The Fightcade client needs to be in sync with the current server version to function. I

Do you have a source for this? FAQ or bug reports etc. when it goes out of sync

If you don't have it's fine, I can merge this on the basis of the description.

Do you have a source for this? FAQ or bug reports etc. when it goes out of sync

It's the same as the other exception. Fightcade is a service that allows people to play with each other, once your client is out of sync (e.g. a new Fightcade releases, which is what we use the flathubbot PRs for) you will get an error like this (see attached image)

It should be up in some time https://docs.flathub.org/docs/for-app-authors/linter#check-currently-published-exceptions

Thanks. Most bug reports for this client come through the Fightcade Discord, which tends to be a black hole for actually sourcing any issues. I'd prefer if people used the Github issue tracker, but it is what it is.


Issue: Unable to Execute Command in Justfile with Nested Quoted Strings

When I run this simple command on windows cmd:
>cat sb.json | jp "testResults[].assertionResults[].{duration:duration}[].duration | sum(@)"
1301213

It works, as soon as I try to wrap it on a Justfile recipe like:
set windows-shell := ["cmd", "/c"]

sb-total-duration:
    cat sb.json | jp "testResults[].assertionResults[].{duration:duration}[].duration | sum(@)"

It'll fail:
>just sb-total-duration
cat sb.json | jp "testResults[].assertionResults[].{duration:duration}[].duration | sum(@)"
SyntaxError: Unclosed delimiter: "
"testResults[].assertionResults[].{duration:duration}[].duration
                                                                ^

error: Recipe `sb-total-duration` failed on line 74 with exit code 1

What's the proper cross-platform solution for this problem? I've already tried many different approaches such as escaping double quotes, single quotes, escaping curly braces, dry-run, verbose... I'm still unsure what's the proper way to pass full strings to commands like jp
Thanks in advance!
>just --version
just 1.22.1

ran into this issue on bash, was able to find a workaround by declaring a variable as quotation marks, may be of use to you?
q := '"'

recipe param:
	command {{q}}{{param}}{{q}}

something like:
q := '"'

sb-total-duration:
	cat sb.json | jp {{q}}testResults[].assertionResults[].{duration:duration}[].duration | sum(@){{q}}

might work


Update peer dependencies pls.

I just runned into "Two Reacts Won’t Be Friends" issue just by removing import React from 'react' from component using react-document-title.
Btw, isn't better to remove peerDependencies at all?

And for https://github.com/gaearon/react-side-effect as well.

There is no problem with peer dependencies in this project. It specifies >= 0.11.0 which includes 0.13.
If install is failing, some other project is blocking it. NPM is unhelpful in that it lists all peerdeps, not just the one that failed.