T001: ChEMBL HttpApplicationError

Describe the bug
Our nightly CI run shows the following error when querying ChEMBL (all OS); see below.
Seems to be random, at first I could reproduce the error locally but now it works without problems; so not a problem on our end. Still, fails now every time in our CI - I do not have a solution, yet.

---------------------------------------------------------------------------
HttpApplicationError                      Traceback (most recent call last)
Input In [10], in <cell line: 17>()
      1 bioactivities = bioactivities_api.filter(
      2     target_chembl_id=chembl_id, type="IC50", relation="=", assay_type="B"
      3 ).only(
   (...)
     14     "target_organism",
     15 )
---> 17 print(f"Length and type of bioactivities object: {len(bioactivities)}, {type(bioactivities)}")

File ~/mambaforge/envs/toc-dev/lib/python3.9/site-packages/chembl_webresource_client/query_set.py:97, in QuerySet.__len__(self)
     95 if not self.can_filter:
     96     return 1
---> 97 return len(self.query)

File ~/mambaforge/envs/toc-dev/lib/python3.9/site-packages/chembl_webresource_client/url_query.py:144, in UrlQuery.__len__(self)
    142     return
    143 if not self.api_total_count:
--> 144     self.get_page()
    145 return self.api_total_count

File ~/mambaforge/envs/toc-dev/lib/python3.9/site-packages/chembl_webresource_client/url_query.py:394, in UrlQuery.get_page(self)
    392 self.logger.info('From cache: {0}'.format(res.from_cache if hasattr(res, 'from_cache') else False))
    393 if not res.ok:
--> 394     handle_http_error(res)
    395 if self.frmt == 'json':
    396     json_data = res.json()

File ~/mambaforge/envs/toc-dev/lib/python3.9/site-packages/chembl_webresource_client/http_errors.py:113, in handle_http_error(request)
    111 exception_class = status_to_exception.get(request.status_code, BaseHttpException)
    112 if request.text:
--> 113     raise exception_class(request.url, request.text)
    114 raise exception_class(request.url, request.content)

HttpApplicationError: Error for url https://www.ebi.ac.uk/chembl/api/data/activity.json, server response: <!doctype html>
<!-- paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/ -->
<!--[if lt IE 7]> <html class="no-js ie6 oldie" lang="en"> <![endif]-->
<!--[if IE 7]>    <html class="no-js ie7 oldie" lang="en"> <![endif]-->

Hi, any update on this issue?
Thanks,
Faraz

This issue seems to be related to an 500 Server error from EBI and is already raised on chembl_webresource_client's side, see discussion here: https://github.com/chembl/chembl_webresource_client/issues/120.
This is a minimum example of the error (same error as in my first post but location where it happens differs (now?)):
from chembl_webresource_client.new_client import new_client
import pandas as pd

def chembl_bioactivities(target_chembl_id):

    bioactivities_api = new_client.activity
    bioactivities = bioactivities_api.filter(
        target_chembl_id=target_chembl_id, type="IC50", relation="=", assay_type="B"
    ).only(
        "activity_id",
        "molecule_chembl_id",
        "target_chembl_id",
    )
    print(len(bioactivities))
    bioactivities_df = pd.DataFrame.from_records(bioactivities)
    return bioactivities_df

chembl_bioactivities("CHEMBL203")

with the error
---------------------------------------------------------------------------
HttpApplicationError                      Traceback (most recent call last)
Input In [5], in <cell line: 18>()
     15     bioactivities_df = pd.DataFrame.from_records(bioactivities)
     16     return bioactivities_df
---> 18 chembl_bioactivities("CHEMBL203")

Input In [5], in chembl_bioactivities(target_chembl_id)
      7 bioactivities = bioactivities_api.filter(
      8     target_chembl_id=target_chembl_id, type="IC50", relation="=", assay_type="B"
      9 ).only(
   (...)
     12     "target_chembl_id",
     13 )
     14 print(len(bioactivities))
---> 15 bioactivities_df = pd.DataFrame.from_records(bioactivities)
     16 return bioactivities_df

...

HttpApplicationError: Error for url https://www.ebi.ac.uk/chembl/api/data/activity.json, server response: <!doctype HTML>

...

The site https://www.ebi.ac.uk/chembl/api/data/activity.json is reachable but loading the QuerySet into pandas seems to not work; maybe because it takes too long and the site is not stable throughout that time?
I am waiting to see how the discussion in the chembl_webresource_client issue continues - I am afraid I have no fix for T001 today, sorry.

Good news! This issue has been resolved by the EBI/chembl_webresource_client team (see update here).
T001 is running again, hence closing this issue!


[Bug]:

What happened?
Login Page Full On Sunset Theme

How to reproduce the bug
?
Package Version
3
PHP Version
8.2
Laravel Version
10
Notes
No response

this issue been resolved by a1f1255


slow execution on nexted closures

// Check that this can be compiled in a reasonable time.

// build-pass

fn main() {
    // 96 nested closures
    let x = ();
    || || || || || || || ||
    || || || || || || || ||
    || || || || || || || ||
    || || || || || || || ||

    || || || || || || || ||
    || || || || || || || ||
    || || || || || || || ||
    || || || || || || || ||

    || || || || || || || ||
    || || || || || || || ||
    || || || || || || || ||
    || || || || || || || ||
    [&(), &x];
}

this file took more than 4 hours (it's still running) to --check on my system.

That seems like a fairly pathological input, but for what it's worth this has already been addressed in source (takes ~20 seconds on the machine I'm on at the moment, and it has some very old and weak specs).
There's some paths that have existed historically in rustfmt that can hit some unfortunately exponential runtimes in exceptionally nested expression cases, though that was also something that only generated code would ever hit in practice since humans wouldn't typically write code that way.
The fix is fairly recent and hasn't been released yet, but should be in the next one. As such I'm going to close, but feel free to build rustfmt from source and run it locally if you'd like to confirm yourself.


[ColdStart] Explore NET7 AOT / Placeholders

Try NET7 AOT publishing & measure cold start impact.
Explore placeholder option.

Work for this is in progress and will span across a few sprints as validation happens.

Most of the AOT work/validation here has been completed.
Currently working on placeholder options.

Investigation here is done. Validation on different approaches is in progress and concrete work items will be opened as needed.


[C++][Parquet] Throw more informative exception when user writes too many values to a column in a row group

In https://github.com/apache/parquet-cpp/blob/5e59bc5c6491a7505585c08fd62aa52f9a6c9afc/src/parquet/column/writer.cc#L159 if the user writes more values than the size of the row group, the message in the exception raised is misleading
Reporter: Wes McKinney / @wesm
Assignee: YE](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=advancedxy) / @advancedxy
Note: This issue was originally created as PARQUET-914. Please see the migration documentation for further details.

Uwe Korn / @xhochy:
Issue resolved by pull request 317
https://github.com/apache/parquet-cpp/pull/317


config: fix cannot set two-way-merge via pdctl

Signed-off-by: nolouch<EMAIL_ADDRESS>
What problem does this PR solve?
./bin/pd-ctl config set enable-two-way-merge true
Failed to set config: [500] "json: cannot unmarshal string into Go struct field ScheduleConfig.enable-two-way-merge of type bool"
What is changed and how it works?
support it
Check List
Tests

Unit test
Manual test
I do manual test and set sucess.

/ok-to-test


[github] Add github-actions to dependabot

Pull Request Test Coverage Report for Build #78

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.237%

Totals

Change from base Build #77:
0.0%

Covered Lines:
193

Relevant Lines:
207

💛  - Coveralls


Change ts module configuration

Move module option in cli to tsconfig.json

Coverage remained the same at 100.0% when pulling 3cfb1b6103fa449f101db827309ec8e1e012392e on dplusic:change_ts_module_config into cd2ce6c05084caf75c63d912e4f04e1dbce5e6e6 on alexjoverm:master.


No way to give an existing variable type hint.

Godot version
4.0.beta.16
System information
N/A
Issue description
func get_variant():
	return call("get_scene") # which is Node

# Called when the script is executed (using File -> Run in Script Editor).
func _run() -> void:
	var a = get_variant()
	if a is Node:
		assert(a is Node)
		a = a as Node
		var must_be_node := a # Error

I know assert won't work in exported version. I read somewhere a few years ago that someone said this worked, so I tried it
Steps to reproduce
N/A
Minimal reproduction project
godot.4.0.beta15.bugs.0.zip

var t = get_variant()
var a := t as Node if t is Object else null # `as` works with objects only.
assert(a)
if a:
    var must_be_node := a # OK

var b := get_object() as Node
assert(b)
if b:
    var must_be_node := b # OK

var t = get_variant()
var a := t as Node if t is Object else null # `as` works with objects only.
assert(a)
if a:
    var must_be_node := a # OK

var b := get_object() as Node
assert(b)
if b:
    var must_be_node := b # OK

var a := t as Node if t is Object else null defines a new variable and giving it a type hint with as,
it's internally the same as var a: Node = t, right?
Also since Object in GDScript is "nullable", can't I just do var a := t as Node ?
If I did't give a a type hint upon defining, but want to give it later...
I know type hint is "static" by definition, but from a practical perspectives, there are such cases, for example:
for key in {a=1,b=2}:
	var cant_infer_type := key

Is it possible to give key a type hint, without defining a new variable?
related to https://github.com/godotengine/godot-proposals/issues/632#issue-587836828

I checked. This used to be possible:
https://github.com/godotengine/godot-proposals/issues/632#issuecomment-869000807
for button in buttons:
    if button is Button:
        button.align = ALIGN_CENTER

for button in buttons:
    assert(button is Button)
    button.align = ALIGN_CENTER

for button in buttons:
    button = button as Button
    button.align = ALIGN_CENTER

According to comments, these codes used to work, but I tried them all in 3.5.1 and they all errors.

Is it possible to give key a type hint, without defining a new variable?

You can use as in expressions, for example:
var name := (get_object() as Node).name

But I wouldn't recommend doing that, since get_object() as Node will be null if get_object() returns a non-Node.

If I did't give a a type hint upon defining, but want to give it later...
I know type hint is "static" by definition

You cannot change the static type of a variable at runtime.

No that I think about it, shouldn't be able to change the static type.


Replace deprecated grpc functions

grpc.ErrorDesc(err) and grpc.Code(err) were deprecated in favor of the "status" package in https://github.com/grpc/grpc-go/commit/b5071124392bfd416c713e6595ac149b387f7186
Replacing these with their equivalent, in case the deprecated methods are removed in future

@cyli @anshulpundir I fixed the linting issue; this is green now PTAL


feat(client): esm support

Continuing https://github.com/prisma/prisma/pull/4178
Closes prisma/prisma-client-js#539

@muxahuk I tried to integrate your PR here, but it looks like it would be a bit more work.
The important special requirement for Prisma Client that you need to keep in mind:
Prisma Client bundles everything and has not dependencies.
That's why we use esbuild and rollup to both bundle the JavaScript and TypeScript.
Feel free to continue in this branch or merge this one into your original one.
I need to work on other things now, but I'm happy to review anything you work on 🙏 .

Hey @timsuchanek i had some issues pushing to this branch, so i pushed to my https://github.com/prisma/prisma/pull/4178 some tests seem to be passing fine there..

hey all, are there any progress on this task, and if not, do you need any help to pass this pull request?

Hey @anonrig! I started working on this again, so soon this will probably be merged :)

Closing in favor of https://github.com/prisma/prisma/pull/4920

Closing in favor of https://github.com/prisma/prisma/pull/4920


Add broker name column in cf marketplace

The table displayed by cf marketplace now has an extra column showing
the name of the broker providing the service.
More information here:
https://www.pivotaltracker.com/story/show/160751597
Best:
@nmaslarski
on Behalf of SAPI Team

@tjvman @Ema93sh @jenspinney: would be great if we could get this reviewed and merged soon, it unblocks a few stories for us. Thanks! If you're on vacation already, ignore this, happy holidays :)


Database file is missing

Can you share this project with the database file?

Sorry I forget credential this account repo ,  try this
all-backup-on-07-05-2020.zip


Feature request: configuration option to disable logo in notification

Hi, i would like to request a small feature in which it is a boolean to disable the logo when sending D-Bus notifications.
The logo is ugly.

Which logo? The icon?

The notification sent by gopass has a icon attached to it - that one.

That is an oddly specific feature request, but I have no fundamental concerns.
I'm just wondering if we need to cater for such niche requests at the expense of having more maintenance overhead.

I'll do it then.


Bug: Windows Chrome 50 keyboard input text node not work

Lexical version: 0.3.6
Steps To Reproduce

window Chrome 50 keyboard input text node not work

<LexicalComposer initialConfig={initialConfig}>
  <PlainTextPlugin
    contentEditable={<ContentEditable className="content-editable-root" />}
    placeholder={<Placeholder>{placeholder}</Placeholder>}
  />
  <AutoFocusPlugin />
</LexicalComposer>

https://user-images.githubusercontent.com/22701565/176819760-72e151c7-4537-4158-b82a-847dbcd8b099.mp4
Link to code example:

The current behavior
The expected behavior

@gauseen Are you still experiencing this issue? I know we fixed a load of bugs with international composition a while ago.

Closing this as I wasn't able to replicate the bug on a Window laptop.


Merged latest DMS SDK and updated code to accordingly

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

View a preview at https://prompt.ws/r/Azure/azure-cli/6323
This is an experimental preview for @microsoft users.

@vchske this PR is nearly three months old and is not in a shape to be reviewed or merged. I will close this for now. Please feel free to update your changes and create new PR after you rebase your branch on top of the dev.


Use CommonJS with rollup

Pretty much the same thing as #364 and gets similar size/load time reductions except it doesn't require changing all of the internal modules to ES6.

This change is

Reviewed 1 of 160 files at r1, 82 of 245 files at r2.
Review status: 83 of 161 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 23 of 245 files at r2.
Review status: 106 of 161 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 245 files at r2.
Review status: 107 of 161 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 7 of 160 files at r1, 48 of 245 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


How to create new data attributes in menu item?

Creating a new data-attribute in menu item to use in my controls.
Example:
['header' => 'account_settings'],
[
'text' => 'profile',
'url'  => 'admin/settings',
'icon' => 'fas fa-fw fa-user',
'my-data' => 'new-data-attribute'
],

There is actually no way to add custom data attributes.

I am altering the menu-item.blade.php file to this.
But, the better would be on config file of adminlte.

There is actually no way to add custom data attributes.

I don't understand, no possible to add input or change menu ?  Thank you

@REJack we can add this as a new feature to the menu 👍

@lacodimizer sure :D assign me on it, I'll create a PR for it and may other issues too.

@lacodimizer I wait until #558 is merged and then I implement my prebuild code 😄.
I build a Menu Filter called DataFilter and it generate from this code
[
    'text'        => 'pages',
    'url'         => 'admin/pages',
    'icon'        => 'far fa-fw fa-file',
    'label'       => 4,
    'label_color' => 'success',
    'data'        => [
        'test' => 'tesa',
        'fest' => 'fesa',
    ],
],

this data tags 😄
data-test="tesa" data-fest="fesa"

@REJack done. :D


Having issues with more complex templates (e.g. !Ref, FindInMap, !If )

I have installed this extension on Visual Studio Code. Although it is installed properly, the plugin does not recognize more advanced templates. Is that correct or I am missing some part of the installation?
For example, every tag starts with "!" is unknown including the following tags:
!Ref
!FindInMap
!If

@mraliagha when cfn-lint provides errors it will do so by prefixing them with cfn-lint.  Can you provide the full error so I can validate its cfn-lint thats causing it.  Usually we see this issue when people are using the generic yaml plugin is as well as it doesn't know about the CloudFormation tags.  One thing you could do is configure that plugin to know what the CloudFormation Tags are.  In settings just do this.
"yaml.customTags": [
        "!And",
        "!If",
        "!Not",
        "!Equals",
        "!Or",
        "!FindInMap",
        "!Base64",
        "!Cidr",
        "!Ref",
        "!Sub",
        "!GetAtt",
        "!GetAZs",
        "!ImportValue",
        "!Select",
        "!Split",
        "!Join"
    ],

I've also just installed the package and seem to have similar issues.
A more complete example, which is providing a bad indentation of mapping entry error on the closing square-bracket after the AvailabilityZone: !Select [0, !GetAZs ""].
This template deploys fine and I can't see why there would be an error.
Resources:
  PublicSubnet1:
    Type: AWS::EC2::Subnet
    Properties:
      VpcId: !Ref VPC
      AvailabilityZone: !Select [0, !GetAZs ""]
      CidrBlock: !Ref PublicSubnet1CIDR
      MapPublicIpOnLaunch: true
      Tags:
        - Key: Name
          Value: !Sub ${EnvironmentName} Public Subnet (AZ1)

My settings.json:
    // Custom tags for the parser to use
    "yaml.customTags": [
        "!And",
        "!If",
        "!Not",
        "!Equals",
        "!Or",
        "!FindInMap",
        "!Base64",
        "!Cidr",
        "!Ref",
        "!Sub",
        "!GetAtt",
        "!GetAZs",
        "!ImportValue",
        "!Select",
        "!Split",
        "!Join"
    ],

    // Enable/disable default YAML formatter (requires restart)
    "yaml.format.enable": true,

    "cfnLint.path": "/usr/local/bin/cfn-lint"

The version of cfn-lint is 0.18.1.
When I run it against the YAML file directly it doens't raise these errors.

Replacing the
AvailabilityZone: !Select [0, !GetAZs ""]
with
AvailabilityZone:
  Fn::Select: [0, !GetAZs ""]

Fixes the issue with the error being raised in the IDE, but both are valid syntaxes (and I would vastly prefer to use the shortened version).

OK, my fix so far after further research. I have adjusted my yaml.customTags config to specify if each tag's parameter is a scalar or a sequence (or in some case, like !GetAtt a definition for both).
I'm sure I'll probably have to make further changes to this over time, but it appears the value suggested for configuring CloudFormation plugins is incorrect.
Here is my current settings:
    "yaml.customTags": [
        "!And",
        "!If",
        "!Not",
        "!Equals",
        "!Or",
        "!FindInMap sequence",
        "!Base64",
        "!Cidr",
        "!Ref",
        "!Sub",
        "!GetAtt scalar",
        "!GetAtt sequence",
        "!GetAZs",
        "!ImportValue",
        "!Select sequence",
        "!Split",
        "!Join sequence"
    ]

Thanks @waynerobinson I'm actually going to update my settings to match this as well.  Since this is all related to this plugin https://github.com/redhat-developer/vscode-yaml are you or @mraliagha  ok with me closing this issue?

Yes. Mine is fixed as well. Thank you.

Thanks.


stable/traefik: Not possible to use with SSL disabled on 1.8 cluster

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug Report
Version of Helm and Kubernetes:
latest Helm, Kubernetes 1.8
Which chart:
traefik
What happened:
It fails to deploy if ssl is disabled, due to this issue and the fix: https://github.com/kubernetes/kubernetes/issues/47222. If SSL is not enabled the chart currently targets 443 to 80, which is affected by that change.

We're seeing the same issue. Our use case is an ELB with an AMC, so SSL termination is happening at the ELB level. If we patch the service yml to remove the 80 listener from the ELB then our site works on https, but we can't take advantage of traefik performing the http => https redirect for us.

#2644 is a duplicate of this issue. Even though this one came first, I propose we close this one because #2644 already has a PR associated with it.

I'll add my comments to that issue...


Rayon 0.7.1 is broken

Rayon 0.7.1 compilation fails with the following error:
error[E0432]: unresolved import `rayon_core::spawn_async`
  --> /home/benjamin/.cargo/registry/src/github.com-1ecc6299db9ec823/rayon-0.7.1/src/lib.rs:41:9
   |
41 | pub use rayon_core::spawn_async;
   |         ^^^^^^^^^^^^^^^^^^^^^^^ no `spawn_async` in the root

error[E0432]: unresolved import `rayon_core::spawn_future_async`
  --> /home/benjamin/.cargo/registry/src/github.com-1ecc6299db9ec823/rayon-0.7.1/src/lib.rs:43:9
   |
43 | pub use rayon_core::spawn_future_async;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `spawn_future_async` in the root. Did you mean to use `spawn_future`?

I assume that this is a dependency specification issue, as rayon-core was recently updated to change the name of spawn_async.

To be clear, stable rayon 0.7.1 still builds fine with the new rayon-core 1.1.
We don't have a really good story for how we change unstable features.  We could make rayon pin a tilde requirement on rayon-core, and make sure we always bump minor versions for unstable changes, but that goes against our desire to make sure there's only one rayon-core everywhere.  i.e. if there are multiple rayons in your project, we still want exactly one rayon-core.
If you can't upgrade, then you could also manually pin rayon-core = "~1.0" yourself.  After all, you're the one relying on unstable features here.  😉
We should probably think about stabilizing those features, and avoid adding new features this way, because it won't fly well long term...

Oh, that makes sense. The issue was actually not in my library, but in the specs library, so I might go open an pull request there to have them update instead.

Yes, Servo was also encountering a similar problem. This just serves to reinforce the reason that the Rust project has always drawn a big, bright line around unstable features. I guess we have to do the same.

Closing this issue, as I don't think this is a bug itself. But I opened https://github.com/nikomatsakis/rayon/issues/369, which is a proposal for a new way to handle unstable APIs.


Avoid scrobbling advertisements

Google Play Music Radio now inserts ads every 2-5 songs.  It would be nice to not scrobble these fake tracks during the ads, as otherwise it quickly becomes the top listened to track.

There's already a fix of this issue. See #951 for details. You can wait for next Web scrobbler release or install it as unpacked extension from @Paszt repository.

Closed by #951


Update populated db - replace sales with promotions, create example rules

Part of https://github.com/saleor/saleor/issues/12539

Done in https://github.com/saleor/saleor/pull/13518


Start the process to support Laravel 7

All the tests except for DatabaseProviderTest::auth_attempts_fallback_using_config_option work and I've resolved the warnings around @expectedException annotations. I can't quite tell what's going on. I think it's because AdLdap2 is throwing exceptions when before it only returned null or something? I wouldn't mind taking it on, but could use some direction on how you want to handle it.
This would close #852 and probably mean a new version? Again, some direction would be helpful if you want some help on it. I've set the adldap2/adldap2 dependency to be dev-master because I saw you did some work on supporting 7 today.
Let me know!

Laravel 6.0 is an LTS version. It would be nice if the LTS version would still be supported.

Yeah I agree supporting 6 would be ideal as well. orchestra/testbench v5 supports 7 but not 6. I don't know if that would hold it back from supporting both versions of Laravel?

@rimace There should be no issues supporting Laravel 5.5 and greater (up to Laravel 7.0).

Can't merge this due to requiring dev-master I need to finish cleaning some things in the core Adldap2 package and make a new release so Laravel 7.0 is supported properly.


GitHub integration: How about linking sender?

For the issue #25672
I have made the following changes.

@sbansal1999  I have done the changes !

@dhruv302003 Thanks for working on this one.
The changes made in the commits are good. But the commit messages themselves are not according to our Commit Discipline. I would recommend you give it a good read and then formulate the commit messages accordingly.

The commit message should not only tell what is being changed but also tell where the change is being made -- in this case, it is the GitHub Integration. I would highly recommend you read some of the other commits that are related to integrations and see how they are written.

@dhruv302003 Our commit discipline says:

When you fix a GitHub issue, mark that you have fixed the issue in your commit message so that the issue is automatically closed when your code is merged, and the commit has a permanent reference to the issue(s) that it resolves. Zulip’s preferred style for this is to have the final paragraph of the commit message read, e.g., Fixes #123..

nit: integrations : -> integrations:

@sbansal1999 There is no option of linking the issue

So should I add  "fixes:#25672" in the Commit message after  "Github Integration" or in the commit description?

@sbansal1999 I have made the changes

@kou  I think the code is ready to be merged.

@dhruv302003 The first commit message looks alright -- just make sure there is a space after : in it (see these examples).
nit: fixes #25672 -> Fixes #25672.
The second commit message is not correct as it suggests that the username is being added to the star event -- which is not the case. Also, the second commit is not related to the issue hence there is no need for the fixes ... in the commit description.

@sbansal1999  For the second commit message which  will be good?

integrations: Update user assignment in Github Integrations. OR
integrations: Improve readability by using get_sender_name() for user assignment in GitHub Integrations.
integrations: Replace direct login extraction with get_sender_name() in GitHub Integrations.

@dhruv302003  You can maybe use integrations: Refactor GitHub Integration to use "get_sender_name". as the commit message for the second commit.
Also while you are on this can you change the following instance of payload["sender"]["login"] to use the same function?
https://github.com/zulip/zulip/blob/f3684e842a87145871ef3e8e6509ad862e24be0b/zerver/webhooks/github/view.py#L367
You can add this in the second commit itself.

@sbansal1999  Done with the changes.

@sbansal1999  Done with the changes.

Thanks @dhruv302003 for working on this one. This looks good to me. Marking this for integration review.

@zulipbot add "integration review"

Thanks @dhruv302003 for working on this one. This looks good to me. Marking this for integration review.
BTW for the next time, you can also add details about the changes in the PR description to make it more reviewable.

Thank you @sbansal1999 @kou  for reviewing my code. Will remember all these things next time !!

How about changing "How about linking sender?" in the pull request title to Link sender in star event or something?

Changed the Title.

@timabbott  The code has been reviewed and ready to be merged.

This is great, merged, thanks everyone!


[Outlook] (on send) Feature enabled by default on modern OWA

Docs Build status updates of commit ac127be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/outlook-on-send-addins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added the possibility to do custom user validation on ticket validation

https://www.pivotaltracker.com/story/show/130768973

Approved.

@oleduc This validation is done on every request, when pyramid checks for the validity of the cookie ticket. It allows us to block users immediately, before logout-login


[tool_crash] FileSystemException: Creation failed, OS Error: Permission denied, errno = 13

Command
flutter run

Steps to Reproduce

...
...
...

Logs
FileSystemException: Creation failed, OS Error: Permission denied, errno = 13
#0      _Directory.createSync (dart:io/directory_impl.dart:133:7)
#1      ForwardingDirectory.createSync (package:file/src/forwarding/forwarding_directory.dart:22:16)
#2      FlutterBuildSystem.buildIncremental (package:flutter_tools/src/build_system/build_system.dart:615:26)
#3      ResidentRunner.runSourceGenerators (package:flutter_tools/src/resident_runner.dart:928:44)
#4      HotRunner.run (package:flutter_tools/src/run_hot.dart:322:13)
<asynchronous suspension>
#5      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:602:37)
<asynchronous suspension>
#6      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:977:18)
#7      _rootRunUnary (dart:async/zone.dart:1198:47)
#8      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#9      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#10     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#11     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#12     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#13     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#14     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#15     RunCommand.usageValues (package:flutter_tools/src/commands/run.dart)
#16     _rootRunUnary (dart:async/zone.dart:1198:47)
#17     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#18     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#19     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#20     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#21     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#22     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)

[✓] Flutter (Channel stable, 1.22.6, on Linux, locale en_GB.UTF-8)
    • Flutter version 1.22.6 at /home/pritish/snap/flutter/common/flutter
    • Framework revision 9b2d32b605 (4 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /usr/lib/android-sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /usr/lib/jvm/java-15-oracle/bin/java
    • Java version Java(TM) SE Runtime Environment (build 15.0.1+9-18)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/linux#android-setup for more details.

[!] Android Studio
    • Android Studio at /path/to/android/studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    ✗ android-studio-dir = /path/to/android/studio
    ✗ Android Studio not found at /path/to/android/studio
    • Try updating or re-installing Android Studio.
    • Consider removing your android-studio-dir setting by running:
      flutter config --android-studio-dir=

[✓] Connected device (1 available)
    • SM A260G (mobile) • 52006d2442475623 • android-arm • Android 8.1.0 (API 27)

! Doctor found issues in 2 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: bbfbf1770cca2da7c82e887e4e4af910034800b6
Plugins
cloud_firestore-0.16.0
cloud_firestore_web-0.3.0+1
firebase_auth-0.20.0+1
firebase_auth_web-0.3.2+6
firebase_core-0.7.0
firebase_core_web-0.2.1+3
firebase_storage-7.0.0
firebase_storage_web-0.1.1+3

@pritish1990
Check this comment and confirm if you have proper permissions and access and then try again to see if it works.
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


closes #41

Current coverage is 93.13% (diff: 100%)

Merging #180 into master will not change coverage

@@             master       #180   diff @@
==========================================
  Files            26         26
  Lines          2942       2942
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2740       2740
  Misses          202        202
  Partials          0          0

Powered by Codecov. Last update b826595...3e76bf9


Previous page support?

Thank you for creating this package! It's very handy for paginating to the next page, but it seems to lack support for the previous page.
I'm using drizzle pagination with tRPC.
My code works, but it's still a bit tedious even with the help of drizzle-pagination. Do you have any plans to support generating hasNext, hasPrev, nextCursor, and prevCursor directly or through helper functions?
Here's what my code looks like:
const cursorMessageSchema = z.object({
  id: z.string(),
  createdAt: z.date(),
});

const parseCursor = cursorMessageSchema.strip();

export const messages = publicProcedure
  .input(
    z.object({
      chatroomId: z.string(),
      cursor: z.optional(cursorMessageSchema),
      direction: z.enum(["forward", "backward"]),
      limit: z.number().min(1).max(100).nullish(),
    }),
  )
  .query(async ({ ctx, input }) => {
    const { cursor, direction } = input;
    const limit = input.limit ?? 10;

    const items = await ctx.db.query.Message.findMany({
      ...withCursorPagination({
        where: eq(Message.chatroomId, input.chatroomId),
        limit: limit + 1,
        cursors: [
          [Message.createdAt, toOrder(direction), cursor?.createdAt],
          [Message.id, toOrder(direction), cursor?.id],
        ],
      }),
      with: {
        // ...
      },
    });
    const firstItem = items[0];

    const prevItems = await ctx.db.query.Message.findMany({
      ...withCursorPagination({
        where: eq(Message.chatroomId, input.chatroomId),
        limit: 1,
        cursors: [
          [Message.createdAt, toOrder(direction, true), firstItem?.createdAt],
          [Message.id, toOrder(direction, true), firstItem?.id],
        ],
      }),
    });

    const hasNext = items.length === limit ? false : (items.pop(), true);
    const hasPrev = prevItems.length !== 0;

    return {
      items,
      hasNext,
      hasPrev,
      nextCursor: items[items.length - 1]
        ? parseCursor.parse(items[items.length - 1])
        : undefined,
      prevCursor: items[0] ? parseCursor.parse(items[0]) : undefined,
    };
    // Next/prev cursors always exist (if not empty) even if there's no next/prev page available at the time of querying
  });

function toOrder(direction: "forward" | "backward", reverse = false) {
  return (direction === "forward") === !reverse ? "desc" : "asc";
}

I don't have plans right now, but my quick reaction is:

hasPrev - can be inferred client-side by simply storing a prevCursor in client-side memory (won't work with a stateless client, but in most cases we're talking about a web app...)
prevCursor - delegate to client (see above)
hasNext - allow the client to always assume that there is a next page of results UNLESS they get back a batch of results which is smaller than the supplied limit - at which point the client can assume that it has reached the end of the list.
nextCursor - your approach is fine, or you can easily delegate this to client of course. Either way

I tend to dislike the approach you are taking here (making an additional query to generate the hasPrev value server-side) and suggest delegating this to the client to infer for itself (as described in the first bullet point above).


"failed to deserialize parent hashtree: unsupported HashTreeProto version 0"

The issue seems to stem from this code: https://github.com/pachyderm/pachyderm/blob/master/src/server/worker/api_server.go#L369-L371
Notice how, if an error is encountered, we don't exit and instead proceed with the empty buffer.

@jdoliner whats the status of this issue? You marked it as 1.7 and it'd be good to have more details about what we want to fix here. There's easy ways to make the error go away, but is there a bigger problem that needs to be figured out too?

There's easy ways to make the error go away

Are there?
The status is that this comes up if there's an object that Pachyderm thinks it's written to s3 which turns out not to be there. That type of situation can cause all sorts of bugs, none of which are particularly fixable. It's possible we're doing something dumb which causes this particular issue but it's also possible that it's just a general corruption issue. Perhaps this should be moved out of 1.7 since there's no concrete thing we know of to fix.

Sounds like I was misunderstanding this issue.
With regard to Derek's initial submission:

Notice how, if an error is encountered, we don't exit and instead proceed with the empty buffer.

Have we changed our code to exit here instead of proceeding? Should we be doing that?

Have we changed our code to exit here instead of proceeding? Should we be doing that?
Yes

But all that means is that you'll get a nicer error here.

stale


error of keras.utils.multi_gpu_model

If I don't use multi_gpus, everything is ok.
When I use multi_gpus of keras (keras.utils.multi_gpu_model(model, gpus=None)
), it shows:
TypeError: Expected int32 passed to parameter 'size' of op 'ResizeBilinear', got (Dimension(None), Dimension(None)) of type 'tuple' instead.
It seems the line 77 in model.py doesn't fit multi_gpus of keras.

I tested it and everything works for me. My Keras version is 2.1.5. Maybe you should update to this version

@bonlime Hi, may I ask you what version of tf u use?

1.6.0

I was struggling to get it working with tf==1.4.0.
I upgraded to tf 1.12.0 and confirmed that it works with Keras 2.1.5 so I assume any tf >=1.6.0 works.


Documentation error

Crate

ibc-relayer-cli

Summary of Bug
First of all, pretty well done documentation. I think there are a couple of wrong command in Channel handshake and Packet relaying on existing path. Basically most of them are missing FLAGS.
For example:
hermes tx raw chan-open-ack ibc-0 ibc-1 connection-0 transfer transfer channel-0 channel-1
should be hermes tx raw chan-open-ack ibc-0 ibc-1 connection-0 transfer transfer -d channel-0 -s channel-1 (it throws an error otherwise)
Also, I have another question about hermes and the Connect the chains using raw transactions.
Let's say I want to create a client. Following the documentation I use:
hermes tx raw create-client ibc-0 ibc-1.
Now, I need to to the same for ibc-1. Using the following command
hermes tx raw create-client ibc-1 ibc-0
I receive, as output, a json containing the same client_id as the previous command, i.e: 07-tendermint-0, but with revision_number is equal to 1.
The same happens for channel and connection, they are always the same. Instead, reading the documentation, they always differ.
Is this okay or am I making something wrong?
Version

hermes: building from master branch (25c4da14c86ffcf0c7f1e191eb259b74666d48a0)
rustc: 1.50.0 (cb75ad5db 2021-02-10)
cargo: 1.50.0 (f04e7fab7 2021-02-04)
gaiad: 4.0.0

Steps to Reproduce
I just followed the command as in here

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Hey @Fraccaman, thanks for creating the issue. I am happy to see you are around. Can I ask you if you are following this for fun or you are working on some related project?

Hi @milosevic ! Happy to hear from you too! I'm testing stuff out as I'm working on some projects with heliax :) (the company I'm working atm)

The same happens for channel and connection, they are always the same. Instead, reading the documentation, they always differ.
Is this okay or am I making something wrong?

That's totally okay, but it is possible to set things up so that the identifiers line up with the documentation. We address this in the "Identifiers" section of the tutorial: https://hermes.informal.systems/tutorial_raw.html#identifiers

For clarity, the tutorials run on a setup where the identifiers allocated to the client, connection and channel on ibc-0 are 07-tendermint-0, connection-0 and channel-0 respectively. Identifiers allocated to the client, connection and channel on ibc-1 are 07-tendermint-1, connection-1 and channel-1 respectively.
If you want to ensure you get the same identifiers while following the tutorial, run the above three commands once on ibc-1 before going over the next sections.

Okay, I'll try again but somehow I wasn't able to match the documentation.

Closing this as outdated.


Review: Communication Services, NetworkTraversal REST

Review with the Azure Board.
Key contact<EMAIL_ADDRESS>Swagger definition
Scenarios:

Several object renames (e.g. "Turn" to "Relay" and "TurnServer" to "IceServer")
Path replacement from "/turn/{id}/:issueCredentials" to "/networktraversal/:issueRelayConfiguration"
Adds a CommunicationRelayConfigurationRequest, making the identity optional - Adds a RouteType to IceServers to be requested

API Stewardship Rewview 18-Oct-21
@ajpeacock0 & @jorgegarchirota all looks good. Minor stuff to fix...

Parameter should have a description. (line 26)
The body parameter is not marked as required. (line 26)
Error response should contain a x-ms-error-code header. (line 41)

API Stewardship Rewview 18-Oct-21
@ajpeacock0 & @jorgegarchirota all looks good. Minor stuff to fix...

Parameter should have a description. (line 26)
The body parameter is not marked as required. (line 26)
Error response should contain a x-ms-error-code header. (line 41)

@markweitzel For "The body parameter is not marked as required.  (line 26)" this was done since the two properties in CommunicationRelayConfigurationRequest are optional, so in the case the caller does not want to provide on, they wouldn't be forced to give an empty json object.
Are you saying this optional request must be required, thus making the caller inclide a {} body?

Regarding the optional request body, if it is truly optional then this is fine. This is often an oversight and that's why we flag it.  But I wonder -- in the even that the body properties are not provided, what is the behavior of the API?  There is no "default" value for these properties, so how will users know what to expect if they don't specify them?

There is no "default" value for these properties, so how will users know what to expect if they don't specify them?

That's a good point. Having no default was also intentional, since for id that doesn't make sense and for routeType we have the behavior or returning all if nothing is specified, but we don't indicate this. I'll add to the description for both to explain behavior


Mapperly does not work on .NET Framework 4.x.

See https://mapperly.riok.app/docs/intro/#requirements
It says that it works on .NET Framework 4.x., but also says that it requires C# language version 9 or later. The problem is, C# version 9 is not available on .NET Framework 4.x. See https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version#defaults. You can't have the required partial methods without v9.
Somebody on my team proved this by creating a standalone .Net 4.8 application and trying to get Mapperly to compile. Even tried to hardcode the language to 9 by editing the project file directly. The same code worked on .Net 5.
I think you need to change requirements from 4.x to 5.x

Hey, while your link states that .NET framework uses the language version 7.3 by default, it is possible and very common to use more recent version of the C# with older versions of .NET.
Simply go to your csproj file and add <LangVersion>12.0</LangVersion> to use C# 12

Hey, sorry to hear about that. Mapperly should definitely work with .NET Framework as it's part of the integration tests. You will need to manually set the LangVersion to something greater than or equal to C# 9.0. Try restarting your ide and rebuilding.

Somebody on my team proved this by creating a standalone .Net 4.8 application and trying to get Mapperly to compile. Even tried to hardcode the language to 9 by editing the project file directly. The same code worked on .Net 5.

I created a new .NET 8 project, manually downgraded to .NET 4.8 and set the langversion and it was able to build. Perhaps projects that are originally .NET Framework are different

I also confirm that newly created .NET Framework 4.7.2 project won't build with CS8795 error "partial method must have an implementation part because it has accessibility modifiers"

I cant reproduce either...
If you add #error version in a .cs file in your solution and build it, what does the output error show?
Could you push a minimal reproducible in a GitHub repository and add the link here?

#error version shows this: "Compiler version: '4.8.0-7.23572.1 (7b75981c)'. Language version: 9.0."
Here's the reproducible example: https://github.com/julianpetriv/TestMapperlyNetFramework (be aware that for some reason VS doesn't want to find Riot package on freshly cloned project, but unloading and reloading the project helps).
Thanks in advance!

@julianpetriv Your example project isn't an SDK style project and so therefore will not work. You should create an SDK-style csproj instead, and then add the following to it:
<PropertyGroup>
  <LangVersion>latest</LangVersion>
</PropertyGroup>

Thanks for sugestion! I will try and let you know if it worked

Your example project isn't an SDK style project and so therefore will not work.

Is it worth updating the docs?

Closing this as no more updates were provided. Looks like it works with a sdk-style projects. Feel free to reopen if the issue persists or new information can be provided.
@TimothyMakkison I think this is a general requirement for source generators. We can add it to the documentation if it comes up again...


Dark Crashed Tab Page

When a firefox tab crashes the page is white themed.

Do you have any screenshots or steps to reproduce by chance?


Should be able to render a template without views

For instance, if I wanted to just load up a standard template out of JST:
var main = new Backbone.LayoutManager({
template: "login",
});
I should be able to render main but this currently does not work.

I was unable to reproduce this with the latest build from master.  Could you get this a try and reopen with a test case if it doesn't work for you?


[tokenizers] Make Huggingface tokenizers translator factory serializable

Description
Brief description of what this PR is about
Make Huggingface tokenizers translator factory serializable

Codecov Report
Patch coverage: 73.75% and project coverage change: +1.97 :tada:

Comparison is base (bb5073f) 72.08% compared to head (4cfd252) 74.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2442      +/-   ##
============================================
+ Coverage     72.08%   74.05%   +1.97%
- Complexity     5126     6795    +1669
============================================
  Files           473      669     +196
  Lines         21970    29610    +7640
  Branches       2351     3058     +707
============================================
+ Hits          15838    21929    +6091
- Misses         4925     6195    +1270
- Partials       1207     1486     +279

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
67.10% <0.00%> (+7.89%)
:arrow_up:

api/src/main/java/ai/djl/modality/nlp/Decoder.java
63.63% <ø> (ø)

... and 635 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Crash on launch

I'm seeing a crash on launch; here's the stack trace: https://gist.github.com/anonymous/b1669ad6389d3e987317
After clearing all browsing data in Safari and running find ~/Library -name *oofy* -delete I can launch goofy and get to the login screen, but then goofy crashes after I successfully authenticate.

Looks like you are on a old version. Can you try downloading the latest version?

Yep, sorry! Works now. I filed https://github.com/caskroom/homebrew-cask/pull/11818 to fix homebrew-cask's download URL.


Is volumes should not be purged since 1.2?

Rancher Version: 1.2
Docker Version: 1.12.3
OS and where are the hosts located? (cloud, bare metal, etc): Ubuntu 16.04
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB) single node
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
Steps to Reproduce:
Delete volume from storage tab
Results:
Volume removed from ui
Expected:
Volume exists in state Deleted.
A still can purge it from api. Is it new behavior?

@clicman - the previous behavior where removed volumes where still able to be seen in the UI was a bug.  Once you remove any volume, container, service, host it should not remain in the UI.  Also we will do an automatic purge of any removed (deleted) items.  It's time based so it can take up to 10 minutes for the purge to happen.  If this is not automatically happening after 10 minutes, please reopen issue as Volumes not automatically purging.


Save info doesn't work after sign in.

@sbertix There should be a setting to allow the web view to save the cookies. I look into and submit a PR if it is possible.

What are you referring to? 🤔
We already have a cache for authentication responses…

I am referring to LoginWebViewController. after you sign in it offer to save info. However we don't seem to save the cookies.

What cookies should we save?
We already save all .instagram.com-session related cookies: that's exactly how we can then use them to call the endpoints…
You should persist them once they're returned and then fetch them instead of presenting LoginWebViewController if they're still valid.
Please check out the README.md with the implementation details.

LoginWebViewController is provided out of the box and for security reason it should never be provided with stored cookies.
We store all cookies needed for the API to operate. Cookies related to browsing itself, e.g. the language selected in LoginWebViewController, are not saved, as they only pertain to LoginWebViewController.\
The authentication flow is pretty solid:

do I have an Authentication.Response persisted?

if I do, login with that, without even showing LoginWebViewController.
if I don't, show LoginWebViewController, so LoginWebViewController should never be provided with cookies, and always return a clean slate.

I double-checked... if you login on Instagram from a web browser and tap Save Info after signing in... then if you sign out and try to sign in again you don't need a password for that account to log back in.

The issue is that the end user of a SwiftyInsta app will expect the above behaviour after tapping Save Info. I did and one of my friends did too.

I'm saying it again… you're friend should only be presented with LoginWebViewController after they log out, meaning their Authentication.Response gets unpersisted.
In that case, there's no saving your login info that matters. Cause you're log out, and they wouldn't be saved either way: you just deleted them (that's what happens from the browser too).
So again, if your friend get shown the LoginWebViewController and requires that feature it means that they haven't implemented this properly: for all intents and purposes LoginWebViewController should only be presented once, when you first load the app, and then forgotten about it.

They are only presented LoginWebViewController after they log out already.
However when they were presented the LoginWebViewController, instagram is offering  to "Save Info" which means that you won't need to type your password next time you are presented with that sign in page.
People who are familiar with the web version of instagram are familiar with this feature as I have shown in the screenshots above and it is natural for them to expect not to have to type their password again.

Cause you're log out, and they wouldn't be saved either way: you just deleted them (that's what happens from the browser too).

@sbertix that's not true at all: on the web version of Instagram... if you tap Save Info after login in and then log out, you will not be prompted for a password:

It works also that in the Instagram app and the Facebook app and web.

You won't be asked to log in again, but if you decide to log out, then it will pop again after logging back in.
Same thing here, as LoginVebViewController should only be displayed after logging out.

It works this way in the official instagram app and web... to delete the save info you have to log out and then click for Remove account on the login page. I can have 'Remove account' in my settings page to make it clear to the user.

Please actually try it for yourself in both www.instagram.com and the official app.

Or if you insist on not allowing that... then the login web view controller shouldn't show the Save Info page because it won't make any sense to the user.

You're right, I meant to say "when you delete your cookies", not just "logging out" (as in "all cookies").
Genuinely bringing this to SwiftyInsta seems to me more like we would be adding one more step instead of removing one (multi account support? You still need to present them that "continue as..." but they would just skip it, etc).
It makes sense for Insta, the way the people use the website, definitely not for an API client.
Anyway, I'm not here to fight hahaha.
I'm not convinced it's a good idea but you're more than welcome to implement it and push a PR for it, and I'd be more than happy to merge it.


Counter double registrations

A member should be unique on a (club, ugentnr) basis

Better to go for unique on a (club, ugentnr, academicyear) basis? no?

Ah, yes, ofcourse.


test: add test for list partition table

What problem does this PR solve?
This PR add test for https://github.com/pingcap/tidb/issues/20678.
What is changed and how it works?
N/A
Check List
Tests

Integration test

Code changes

N/A

Side effects

N/A

Related changes

N/A

Release note

N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/run-all-tests

/run-integration-test

/run-integration-test

/run-integration-test

/run-integration-test

Will this feature be picked to TiDB 4.0, or it is 5.0 only?

Will this feature be picked to TiDB 4.0, or it is 5.0 only?

This feature is 5.0 only.

Will this feature be picked to TiDB 4.0, or it is 5.0 only?

This feature is 5.0 only.

/run-integration-test

/run-integration-test

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-integration-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/assign
I will continue to move it forward.

I have no time to work on this. So I am going to close this PR. Thanks!


Merge updates from ocm-plus repo

Brings in commits up to the current "release-2.4" branch from the other repo.

/hold t o merge manually


Crashed when remove font data in Label3D

Godot version
v3.5.2.stable.official [170ba337a]
System information
openSUSE Tumbleweed
Issue description
godot crashed when remove font data using DynamicFont type.
I just test with .ttf and .otf
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.5.2.stable.official (170ba337a5d9e4c1e40d63b89dc1ba297b71860b)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib64/libc.so.6(+0x3f1f0) [0x7f5bff83f1f0] ()
[2] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0x3219373] ()
[3] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0x141321e] ()
[4] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0x2b0eb06] ()
[5] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0x31de87a] ()
[6] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0x2b1f959] ()
[7] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0x2a9a31e] ()
[8] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0xa947e1] ()
[9] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0xa03f85] ()
[10] /lib64/libc.so.6(+0x281f0) [0x7f5bff8281f0] ()
[11] /lib64/libc.so.6(__libc_start_main+0x8b) [0x7f5bff8282b9] ()
[12] /home/mylaptop/Applications/Godot_v3.5.2-stable_x11.64() [0xa168ce] ()
-- END OF BACKTRACE --
================================================================

Steps to reproduce
N/A
Minimal reproduction project
N/A

Can't reproduce in 3.x, probably already fixed.


Fix compute_record_batch_statistics wrong with projection

Which issue does this PR close?

Closes #8406.
Rationale for this change

Projection size is not calculated correctly
What changes are included in this PR?
Select the correct columns, not all
Are these changes tested?
test_compute_record_batch_statistics

Are there any user-facing changes?

Thanks again @Asura7969 @

Thanks @Asura7969 and @alamb @jackwener for the review


✨[Feature] Enable debug logging with a context

Is your feature request related to a problem? Please describe.

Right now seems like users don't know how or don't enable debug logging. We can probably add some syntax to make this easier.
Describe the solution you'd like

I would love to see something like:
import torch_tensorrt as torchtrt

with torchtrt.debug:
    torchtrt.ts.compile(....)

under the hood this would be equivalent to:
import torch_tensorrt as torchtrt

torchtrt.logging.set_reportable_log_level(torchtrt.logging.Level.Debug)
torchtrt.ts.compile(....)
torchtrt.logging.set_reportable_log_level(torchtrt.logging.Level.Error)

Describe alternatives you've considered

Additional context

In some other libraries, I've seen python functions accepting verbose=True as argument. Maybe one other option is to have
torchtrt.ts.compile(....,, log_level = 'debug') defaulting it to info.

Agreed with the above... as compile is the primary entry point into torchtrt for most use cases, it would be highly ergonomic to enable verbosity through the same interface via an optional argument.

Yeah I would agree except that, the logger covers not just the compilation step but also the execution step. Especially for the execution step there isn't a great access point to provide this argument. No reason we cant look at adding both.


Bumped to<EMAIL_ADDRESS>to fix npm install

I actually can't even npm install this project right now as-is because v0.0.40 contained an expresss typo found here.
npm ERR! 404 Not Found: expresss
npm ERR! 404
npm ERR! 404 'expresss' is not in the npm registry.

It also doesn't hurt to bump it too :trophy:

:+1:

Thank you!


isinstanceof(t, *Tensor) broken

File lib/python3.8/site-packages/torchvision/transforms/functional.py exposed a but with isinstanceof. It has this code:
    img = img.permute((2, 0, 1)).contiguous()
    if isinstance(img, torch.ByteTensor):
        return img.to(dtype=default_float_dtype).div(255)
    else:
        return img

It always returns false with Torchy, and then it crashes.
Simple repro:
x = torch.zeros([4, 3], dtype=torch.uint8)
print(isinstance(x, torch.ByteTensor))
print(x.dtype)

I've no idea where ByteTensor is defined or zeros() ends up creating a ByteTensor obj.

Found the code in torch/csrc/tensor/python_tensor.cpp:
static PyObject* Tensor_instancecheck(PyObject* _self, PyObject* arg) {
  HANDLE_TH_ERRORS
  auto self = (PyTensorType*)_self;
  if (THPVariable_Check(arg)) {
    const auto& var = THPVariable_Unpack(arg);
    if (legacyExtractDispatchKey(var.key_set()) == self->get_dispatch_key() &&
        var.scalar_type() == static_cast<ScalarType>(self->scalar_type)) {
      Py_RETURN_TRUE;
    }
  }
  Py_RETURN_FALSE;
  END_HANDLE_TH_ERRORS
}

Note the check for the dispatch key, which makes some sense as PyTorch has different subclasses for CPU & CUDA tensors.
Gah!

Longer term maybe we want to remove Lazy from the comparison in legacyExtractDispatchKey (c10/core/DispatchKeySet.h)?


Enh/tutorial

Just a side comment - I see there are images added to the repository (though this branch was not merged), and some of the image sizes are tens of MB. GitHub is not good at managing binary files like images. If images will indeed be needed in the future, I would suggest releasing them in an OSF repository (it's free!) with options of DataLad tracking.

Thank you for flagging this! We will find another place for the images!


Start Room Boost

Checklist

[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
Hi
Thank you for this great integration.
I attempted to adjust the fan level for one of the rooms but was unsuccessful. Could you please guide me on how to add it as a card to the dashboard? Additionally, changing the state in the Developer Tools doesn't seem to be working.

API output
No response
Debug logs
No response
Diagnostics dump
No response

Hi @matt7py,
If you want to boost a specific room you have to call a service with the correct properties.
You can test this by using the Developer Tools and using the Services tab as shown below.
Just select the room, choose to what percentage you want to boost (or slow down) and for how long.

If you want to do this through a card it's basically dealer's choice on how you want to pass those parameters. You can use helpers, use fixed values etc but in the end it all comes down to having a button call a service.
Let me know if this helps

Hi @matt7py
Can you copy the code from your entire card configuration so that I can view it in it's entirety?
(I only need the specific card, not the entire stack)

type: horizontal-stack
cards:
  - type: custom:mushroom-fan-card
    icon_animation: true
    fill_container: false
    layout: horizontal
    secondary_info: state
    primary_info: name
    icon_type: icon
    show_percentage_control: true
    show_oscillate_control: false
    collapsible_controls: false
    tap_action:
      action: call-service
      service: healthbox.start_room_boost
      target: {}
      data:
        device_id: 258e93df914e790b39dbf3deaf2ed7be
        boost_level: '{{ states(''input_number.fan_slider'') | int }}'
        boost_timeout: 180
    name: 'Ventilation '
    double_tap_action:
      action: none
    hold_action:
      action: none
    entity: sensor.keuken_open_boost_level_2

I'll try to do something similar and let you know how it goes.
Might take a while since my healthbox currently doesn't want to authenticate to Renson's API at the moment.
I'll keep you posted!

Hi @matt7py
I checked how I did this and instead of calling the state in my service I used a script. For some reason the cards had an issue passing the state as an integer.
Besides that, you can't really use a tap action on a fan card since the tap account is basically for the "fan icon" and not the slider. (I hope this makes sense) I looked into making the boost an actual fan but it's not possible due to limitations in the fan model and the Healthbox not behaving like an actual fan
Below are some snippets I used for my dashboard
Script:
alias: Boost Healthbox Room
sequence:
  - service: healthbox.start_room_boost
    data:
      device_id: "{{ device_id }}"
      boost_level: "{{ states('input_number.hb3_boost_level') | int }}"
      boost_timeout: "{{ states('input_select.hb3_boost_tijd') | int }}"
mode: queued
icon: mdi:fan-alert

Card:
      - type: custom:mushroom-entity-card
        entity: sensor.keuken_open_airflow_ventilation_rate
        name: Keuken
        icon: mdi:food
        icon_color: grey
        tap_action:
          confirmation:
            text: Ben je zeker dat je wil boosten?
          action: call-service
          service: script.boost_healthbox_room
          target: {}
          data:
            device_id: 852c9849c0a77702dfb99bde74e89c77
        hold_action:
          confirmation:
            text: Ben je zeker dat je de boost wil stoppen?
          action: call-service
          service: healthbox.stop_room_boost
          data:
            device_id: 852c9849c0a77702dfb99bde74e89c77
          target: {}

Let me know if this helps

I am not an expert in the script, but I followed the steps and there is still a problem that it does not work properly!!
Add script

Card:
change the  device_id number to my Keuken device_id

Error :

@matt7py
I think there's an error in your yaml code.
Device_id needs to be on a new line under "data" and indented.

Now I got different error

Failed to call service script/boost_healthbox_room. Error rendering data template: ValueError: Template error: int got invalid input 'unknown' when rendering template '{{ states('input_number.hb3_boost_level') | int }}' but no default was specified

Did you create both these input helpers?

For example, the input select I use for having presets of amount of minutes

I created the 2 input helpers but still I got problem!!

error :
Failed to call service script/boost_healthbox_room. Error rendering data template: ValueError: Template error: int got invalid input 'unknown' when rendering template '{{ states('input_number.hb3_boost_level') | int }}' but no default was specified

I think I see what the problem is.
So in Home Assistant you have 2 "names" for an object.
The first is the name (display/friendly name) and the other is the entity id.
If you use code to find a device, in 99.9% of the use cases you'll use the entity id.
In your screenshot I can see you copied my entity id into your name field but Home Assistant automatically adds the object type to the front of the name as the entity id and because of that you end up with the wrong entity id .

So rename the entity id's to this:
input_select.hb3_boost_tijd
and
input_number.hb3_boost_level

Different error :(
Failed to call service script/boost_healthbox_room. value must be at least 10 for dictionary value @ data['boost_level']

Now it works, thank you.
The question here is how can I control the speed through the slider? Because now become as toggle, I can't control the speed or the time!!

Glad that it's working. We are making progress!
I basically have the input selector and slider in the same vertical stack as my room boosts like in the snippet below.
That way I can select for how long and how hard I want the boost to be. After that I just pick the room I want to boost and off it goes.

Code:
type: vertical-stack
cards:
  - type: entities
    entities:
      - entity: input_select.hb3_boost_tijd
        name: Boost Tijd
      - entity: input_number.hb3_boost_level
        name: Boost Level
  - type: horizontal-stack
    cards:
      - type: custom:mushroom-entity-card
        entity: sensor.slaapkamer_r_en_d_airflow_ventilation_rate
        name: Slaapkamer R&D
        icon: mdi:bed
        icon_color: green
        tap_action:
          confirmation:
            text: Ben je zeker dat je wil boosten?
          action: call-service
          service: script.boost_healthbox_room
          target: {}
          data:
            device_id: 4a4f6a693c7e620ca7005766a4657451
        hold_action:
          confirmation:
            text: Ben je zeker dat je de boost wil stoppen?
          action: call-service
          service: healthbox.stop_room_boost
          data:
            device_id: 4a4f6a693c7e620ca7005766a4657451
          target: {}
      - type: custom:mushroom-entity-card
        entity: sensor.bureau_airflow_ventilation_rate
        name: Bureau
        icon: mdi:desk
        icon_color: purple
        tap_action:
          confirmation:
            text: Ben je zeker dat je wil boosten?
          action: call-service
          service: script.boost_healthbox_room
          target: {}
          data:
            device_id: 41cb4196636ded6558c009dcc5b0d037
        hold_action:
          confirmation:
            text: Ben je zeker dat je de boost wil stoppen?
          action: call-service
          service: healthbox.stop_room_boost
          data:
            device_id: 41cb4196636ded6558c009dcc5b0d037
          target: {}

Thank you, now work perfect

I need to add some animation and different color's based on speed to make it cool :)
I think better to add this update to the repository code so that everyone get it as default

Glad to hear we got there in the end.
While I am appreciative of you proposing to add the code to the repository it is kind of outside the scope of the integration.
The beauty of Home Assistant is that people can "integrate" these things as they see fit. I for example did it this way while I'm sure others did it some other way.


getCalendarYear should allow Intl.DateTimeFormatOptions as options for date output

getCalendarYear(year: number, locale?: string, options?: Intl.DateTimeFormatOptions)

these options should dictate the response in the [month].collection field

this was completed at some point 🤷


Fixed README.md and CONTRIBUTING.md

Closes #207

Once Travis-CI passes it's :+1: for me

Merged!


Add packet sending benchmarks

So it's really important to benchmark the package sending and probably have a lot of bots, so I might try to actually benchmark it with SwarmBot and have that in one of the benches

closed by https://github.com/andrewgazelka/hyperion/pull/145


chore: Update Go, Alpine, and various Golang packages

Docker image had several high and critical vulnerabilities reported. Upgraded:

alpine 3.15.4 -> 3.19.0
go 1.20.7 -> 1.21.5
k8s.io/kubernetes 1.24.15 -> 1.26.12

Also replaced unmaintained github.com/satori/go.uuid with github.com/google/uuid in service.go

@moensch the go module dependencies were pinned the way they were because of compatibility issues with Argo CD modules, iirc. (Since Kargo Render uses Argo CD repo server as a library.) fwiw, it was quite a chore for Kargo proper to get untangled from all of that -- and it's why Kargo proper now invokes Kargo Render as a subprocess -- it's avoiding getting re-entangled with Argo CD modules and an "ancient" Kubernetes version.
This is probably ok, but I want to vet go mod changes more carefully first.
If you wanted to separate this into two PRs, I would happily merge the rest of the changes right away.

Some of this and more made it into #257.
I remain reluctant to bump k8s version at this time.


HDFS-15737. Don't remove datanodes from outOfServiceNodeBlocks while checking in DatanodeAdminManager

https://issues.apache.org/jira/browse/HDFS-15737
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
11m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
16m  8s
branch-2.10 passed

+1 :green_heart:
compile
0m 58s
branch-2.10 passed

+1 :green_heart:
checkstyle
0m 38s
branch-2.10 passed

+1 :green_heart:
mvnsite
1m 12s
branch-2.10 passed

+1 :green_heart:
javadoc
1m 15s
branch-2.10 passed

+0 :ok:
spotbugs
2m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 56s
branch-2.10 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
checkstyle
0m 29s
the patch passed

+1 :green_heart:
mvnsite
1m  2s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
1m 10s
the patch passed

+1 :green_heart:
findbugs
3m  0s
the patch passed

_ Other Tests _

-1 :x:
unit
62m 34s
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

108m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2562

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8cd430b18ff7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 2c45e93

Default Java
Oracle Corporation-1.7.0_95-b00

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/testReport/

Max. process+thread count
2255 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2562/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

It looks like this same logic also exists in trunk - could you submit a trunk PR / patch and then we can backport the change across all active branches?
I am also a little confused about this problem. The map outOfServiceNodeBlocks is modified in a few places in the middle of the Cyclic Iteration. If it threw an ConcurrentModificationException on modification, then I would expect us to be seeing this a lot. Probably anytime there is more than 1 node added to decommission / maintenance.
Eg, from trunk DatanodeAdminDefaultMonitor.java, here it is a CyclicIterator over outOfServiceNodeBlocks
    while (it.hasNext() && !exceededNumBlocksPerCheck() && namesystem
        .isRunning()) {
      numNodesChecked++;
      final Map.Entry<DatanodeDescriptor, AbstractList<BlockInfo>>
          entry = it.next();
      final DatanodeDescriptor dn = entry.getKey();
      try {
        AbstractList<BlockInfo> blocks = entry.getValue();
        boolean fullScan = false;
        if (dn.isMaintenance() && dn.maintenanceExpired()) {
          // If maintenance expires, stop tracking it.
          dnAdmin.stopMaintenance(dn);
          toRemove.add(dn);
          continue;
        }
        if (dn.isInMaintenance()) {
          // The dn is IN_MAINTENANCE and the maintenance hasn't expired yet.
          continue;
        }
        if (blocks == null) {
          // This is a newly added datanode, run through its list to schedule
          // under-replicated blocks for replication and collect the blocks
          // that are insufficiently replicated for further tracking
          LOG.debug("Newly-added node {}, doing full scan to find " +
              "insufficiently-replicated blocks.", dn);
          blocks = handleInsufficientlyStored(dn);
          outOfServiceNodeBlocks.put(dn, blocks);  // **** Modifies outOfServiceNodeBlocks
         ...

Note that outOfServiceNodeBlocks is modified on the first pass, and so it.next() should throw an exception on the next iteration.
Have you seen the ConcurrentModificationException logged due to this problem?

ConcurrentModificationException

Thanks for looking. If there are only 2 datanodes in outOfServiceNodeBlocks and the first one is removed, then it will be a dead loop on the second datanode. If there are more than 2 datanodes and the first one is removed, there will be a ConcurrentModificationException. I see both two cases in our prod very often.
This issue only happens when remove (dnAdmin.stopMaintenance(dn);). By outOfServiceNodeBlocks.put(dn, blocks), it only updates the value, so Cyclic Iteration won't be affected

Thanks for the information - this may explain why HDFS-12703 was needed, as some exceptions which were not logged at that time, caused the decommission thread to stop running until the NN was restarted. The change there was to catch the exception.
The change here looks correct to me, but as the issue exists on the trunk branch, we should fix it there first, and then backport to 3.3, 3.2, 3.1 and 2.10 so the fix is in place across all branches.

Thanks for the information - this may explain why HDFS-12703 was needed, as some exceptions which were not logged at that time, caused the decommission thread to stop running until the NN was restarted. The change there was to catch the exception.
The change here looks correct to me, but as the issue exists on the trunk branch, we should fix it there first, and then backport to 3.3, 3.2, 3.1 and 2.10 so the fix is in place across all branches.

Due to HDFS-14854, the fix on trunk could be a very different one, since it doesn't make sense to change the new interface with a boolean parameter to stopTrackingNode while DatanodeAdminBackoffMonitor does't need.
Looks a better fix would be introduce a cancelledNodes to DatanodeAdminDefaultMonitor, just like DatanodeAdminBackoffMonitor . Then in stopTrackingNode, don't remove dn from outOfServiceNodeBlocks, but add it to cancelledNodes for further process.
However, the change would be a little bit bigger.


Add action indicators to section headers to indicate that attention is needed

Add ability to show icons in the TreeSection headers
Show warning icons in headers when that section has a warning

Like a missing package file

Confirmed that:

having no requirements.txt (package file) when Python is configured shows a warning codicon
having no renv.lock (package file) when R is configured shows a warning codicon
having no credential for the selected deployment shows a warning codicon


Signing in not working

Hi,
After registering a new user I'm signed in automatically and I can create some tasks. However, after signing out, it's not possible to sign in anymore. Can someone confirm this or am I doing something wrong?
Great app btw!

Create user with a min of 8 char password. Sorry if not clear
From: Achim<EMAIL_ADDRESS>Sent: Saturday, November 01, 2014 9:18 AM
To: SharePointOscar/MEANS
Subject: [MEANS] Signing in not working (#13)
Hi,
After registering a new user I'm signed in automatically and I can create some tasks. However, after signing out, it's not possible to sign in anymore. Can someone confirm this or am I doing something wrong?
Great app btw!
—
Reply to this email directly or view it on GitHub https://github.com/SharePointOscar/MEANS/issues/13 . https://github.com/notifications/beacon/ABylgPygMcAV_zDSvgYaZGYS6x_yV16Uks5nJNTqgaJpZM4C14Vb.gif

No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4765 / Virus Database: 4040/8445 - Release Date: 10/24/14
Internal Virus Database is out of date.


Support deleting namespaced Workers in DeleteWorker

Description
Support a new DispatchNamespace option in DeleteWorker params just like we do for the other APIs (UploadWorker, UpdateWorkersScriptContent, etc.).
Has your change been tested?
TestDeleteNamespacedWorker test passes. Test script also passes:
func main() {
	api, err := cloudflare.New(os.Getenv("CLOUDFLARE_API_KEY"), os.Getenv("CLOUDFLARE_API_EMAIL"))
	if err != nil {
		log.Fatal(err)
	}

	ctx := context.Background()

	accountId := os.Getenv("ACCOUNT_ID")
	err = api.DeleteWorker(ctx, cloudflare.AccountIdentifier(accountId), cloudflare.DeleteWorkerParams{
		ScriptName:        "user-worker-1",
		DispatchNamespace: &[]string{"test"}[0],
	})
	if err != nil {
		log.Fatal(err)
	}
}

Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

lgtm!


fix: set proper ttl in createsnapshot

fix: set proper ttl in createsnapshot
ttl was not added to the expiration time and the Now ts was sent to the server. This leads to errors like "Expire time must be at least 6h from the time the backup was started, which should be XXX, but got XXXX"

@triplequark @igorbernstein2 @telpirion ~friendly ping~ mind taking a look at this one-liner PR? Thanks!


For a conceptually clear start/launch/open user experience, provide dedicated Start-* cmdlets

A follow-up from #5715:
Start/launch/open-something tasks can be categorized as follows:

(a) Start executables, using a variety of options (asynchronous or not, different credentials, hidden, ...).

(b) Start (open) documents (including directories), asynchronously, using whatever GUI application is registered to handle them by default.

(c) Start (open) URIs, asynchronously, using whatever using whatever GUI application is registered to handle them by default.

For technical and historical reasons, in Windows PowerShell it is Start-Process that handles all 3 categories, with category (b) also handled by Invoke-Item.
As of PowerShell Core v6.1.0-preview.3, Start-Process cannot handle (b) and (c), but Invoke-Item covers (b), as in Windows PowerShell.
.NET Core has since made the previously full-framework-only .UseShellExecute property available, so that #5715 can be resolved by integrating (b) and (c) functionality to Start-Process too, for symmetry with Windows PowerShell.
However, going forward I suggest (also) reflecting the categories in distinct cmdlets, so as to:

make them easier to discover.

have clear separation of purpose.

have simpler syntax (no need to figure out which of the many Start-Process parameters make sense / are compatible with (b) and (c) functionality).

In practice this means:

Leave Start-Process as-is (after integrating (b) and (c)), but deemphasize (b) and (c) in the documentation and instead point to Start-Item and Start-Uri (see below).

Introduce alias Start-Item for Invoke-Item - given the asynchronous nature of Invoke-Item (at least in the filesystem - it isn't currently implemented for other providers), it should always have been named Start-Item.

On a side note: the reverse goes for Start-Sleep, which should have been named Invoke-Sleep - see #3990

Introduce a simple new Start-Uri cmdlet whose sole purpose is to cover (c).

Environment data
Written as of:
PowerShell Core v6.1.0-preview.3

Nice analysis but not quite complete as PowerShell natively handles category a).e.g. PS > netstat.exe just works.  My intention when I added Start-Process was to handle the exceptional case where Invoke-Item and native commands were insufficient e.g. starting a background console process without relying on ShellExecute or jobs. It's a relatively thin layer on top of the Process class and that shows through (to the detriment of the cmdlet). IMHO, the fact that Invoke-Item doesn't handle URIs should be fixed first before we do anything with Start-Process. I'm OK with adding a specific discoverable command for URIs but should probably be Invoke-URI rather than Start since you can't stop it.

Thanks, @BrucePay.

as PowerShell natively handles category a).e.g. PS > netstat.exe just works.

Yes, but the focus of my analysis were all the other scenarios where an external program / resource is executed / opened : asynchronously (at least by default), with no (direct) connection to the standard streams.
(Leaving aside that it's a common beginner mistake to think that Start-Process is needed for the it-just-works-with-direct-invocation scenario: synchronous execution with the standard streams connected.)

before we do anything with Start-Process

Aside from completing the work to bring Start-Process on (near-)par with the way it works in Windows PowerShell (now that .UseShellExecute is available), I wasn't suggesting any changes to Start-Process - those who are used to how it works in Windows PowerShell and know that (b) and (c) functionality are built in can continue to use it as they're used to.
My suggestion was to additionally give (c) (URI launching) a distinct cmdlet (Start-Uri), and to provide an alias for the already (b)-focused Invoke-Item, so as to make its name comply with PowerShell's naming rules (see below).
The net effect would be that each category would have a distinct cmdlet (despite the fact that Start-Process can do it all).

the fact that Invoke-Item doesn't handle URIs should be fixed first

My concern is that the Item noun suggests too strongly that the cmdlet acts on PS provider items only, which URIs are not, hence the suggestion to add a URI-focused cmdlet.
Here too we could take the same approach however: add URI support to Invoke-Item as well, in addition to providing a dedicated Start-Uri cmdlet.

should probably be Invoke-URI rather than Start since you can't stop it.

I was thinking Start in order to reflect the asynchronous nature of the operation.
That said, not being able to stop the operation is unusual in this case, so we could consider a "non-committal" alternative such as Open (a verb that is commonly applied to documents and URIs even outside of PowerShell).
By contrast, Invoke strikes me as not appropriate, based on what the documentation tells us (emphasis added):

Invoke vs. Start: The Invoke verb is used to perform an operation that is generally a synchronous operation, such as running a command. The Start verb is used to begin an operation that is generally an asynchronous operation, such as starting a process.


[Request] shift hover over an item and drag'n drop a nugget from it

I saw https://github.com/raoulvdberge/refinedstorage/issues/288 and thought it would be very cool if you can shift hover over an item(in the grid) and drag'n drop a nugget from it.
See this: http://i.imgur.com/PmFtl5Zg.png

Idea seems cool initially, but:

you can autocraft them already in whatever form you want
wouldn't work with ingots from other mods


Bug: Form Yugoslavia decision is redundant and broken

Please dump form_yugoslavia from NationalUnions.txt, as form_union_nation covers it already, and YUG is defined in cultures as cultural union tag.

Fixed in #318.


Delete object(s)

TODO: Limitation w/ Google API. Queries do not return location of an object, so would need to query and then fetch all to compute location.

[x]  From Query
[ ] A specific object

delete from query finished. Decided not to do specific object for now


clang: error: no such file or directory: './maro/backends/backend.c'

Description
Mac:    python setup.py build
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/include -I/usr/local/opt/openssl/include -I/usr/local/opt/sqlite/include -I/Users/yewang/.virtualenvs/maro/include -I/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/include/python3.6m -c ./maro/backends/backend.c -o build/temp.macosx-10.12-x86_64-3.6/./maro/backends/backend.o
clang: error: no such file or directory: './maro/backends/backend.c'
clang: error: no input files
error: command 'clang' failed with exit status 1
Screenshots

To Reproduce
Steps to reproduce the behavior:

Expected Behavior

Environment

MARO version (e.g., v0.1.1a1):
MARO scenario (CIM, Citi Bike):
MARO component (Simulation, RL, Distributed Training):
Orchestration platform (GraSS on Azure, AKS on Azure):
How you installed MARO (pip, source):
OS (Linux, Windows, macOS):
Python version (3.6, 3.7):
Docker image (e.g., arthursjiang/maro:cpu[5f36ed]):
CPU/GPU:
Any other relevant information:

Additional Context

Seems like cython files not compiled into c, please have a try with 'bash scripts/build_maro.sh' instead of build it manually.

Seems like cython files not compiled into c, please have a try with 'bash scripts/build_maro.sh' instead of build it manually.

(maro) ali-6c96cfd90593:maro yewang$ sh scripts/build_maro.sh
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Requirement already satisfied: Cython==0.29.14 in /Users/yewang/.virtualenvs/maro/lib/python3.6/site-packages (from -r ./maro/requirements.build.txt (line 1)) (0.29.14)
Requirement already satisfied: numpy==1.19.1 in /Users/yewang/.virtualenvs/maro/lib/python3.6/site-packages (from -r ./maro/requirements.build.txt (line 2)) (1.19.1)
running build_ext
error: each element of 'ext_modules' option must be an Extension instance or 2-tuple

@ArthurJiang @Jinyu-W Seems like we have sorted the import order in setup.py, it will cause the this issue, conflict between setuptools and cython, we have to keep original import order, we should ignore setup.py for isort. I will create a PR to fix it.

@clm971910 What's the version of setuptools package your are using? Would you please help to try with PR #208 to see if it can fix   your issue, it would work according to https://github.com/pypa/setuptools/issues/309.

@chaosddp I think we can ignore the setup.py for a quick fix, please follow up it, merge back to master.

@clm971910 What's the version of setuptools package your are using? I have tried with several old versions (17, 18, 45) of setuptools, cannot reproduce the issue on mac. And would you please help to try with PR #208 to see if it can fix your issue, it would work according to pypa/setuptools#309.

(maro) ali-6c96cfd90593:maro yewang$ pip show setuptools
Name: setuptools
Version: 50.3.2
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: /Users/yewang/.virtualenvs/maro/lib/python3.6/site-packages
Requires:
Required-by: Sphinx, kiwisolver

@clm971910  This problem is fixed in PR https://github.com/microsoft/maro/pull/208. Since we cannot reproduce this issue, please try the newest version again. Thanks!

@Jinyu-W thank you

python setup.py build
is successed , thanks

Thank you to confirm, I will close this issue.


[stable/newrelic-infrastructure] Set the namespace in all the resources

Signed-off-by: Alejandro Do Nascimento<EMAIL_ADDRESS>
What this PR does / why we need it:
Sets the namespace for all the resources to the release namespace. This allows users to customize were the resources are going to be created.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

cc @douglascamata

/ok-to-test

There is no need for this - helm does this automatically.

/close


omeroweb docker - add local app

See discussion at: https://github.com/ome/ome-documentation/pull/2134#discussion_r444705436
Nice to find a more user-friendly way to add local app to PYTHONPATH in docker omeroweb.

@will-moore Does the recent work for omero-figure (cf. https://github.com/ome/omero-figure/pull/469) a good compromise we could promote?

yes - good idea - would we tell users to create their own DockerFile, as in
https://github.com/ome/omero-figure/pull/469/files?


Improvement: Generating Views, Controllers in ts-app like in generator-ui5-project

Generating Views, Controllers etc. like in generator-ui5-project would be a big improvement for generator-ui5-ts-app.

Yes, indeed. I even think further whether we can't harmonize the different generators. Right now, the project generator is the most advanced providing many sub generators and all others (ts-app, app, library, ...) are very simple self-contained ones.

I just wanted to open a issue for exactly this issue :) I'm glad the conversation has already started and, hopefully, I can relive it a bit.
A similar question has already been asked in the issue about 18 month ago ui5-community/generator-ui5-project#17
I noticed ui5-community/generator-ui5-project#58 already brings some TS-support to the default generator. But it is tightly bound to the "SAP Fiori elements flexible programming model"-option. @tobiasqueck Do you know if @sap-ux/fe-fpm-writer, @sap-ux/fiori-freestyle-writer, or @sap-ux/ui5-application-writer provide the capability to generate a "plain TS project"?

@IObert yes, @sap-ux/ui5-application-writer allows generating a plain UI5 TS project. The corresponding test cases using the required flag are https://github.com/SAP/open-ux-tools/blob/main/packages/ui5-application-writer/test/options.test.ts#L86-L131


Add partial_fit to scikit-learn wrappers of creme estimators #267

Also fix the Creme2SKLClassifier so it passes scikit-learn's checks.
Ensure SKL2CremeRegressor -> Creme2SKLRegressor is still a proper
estimator. Not ensured for classifiers at the moment due to discrepancy
in how classes are discovered (at first partial_fit for scikit-learn and
at init for creme if prediction classes are to be consistent).

Thanks for the review.
My bad, I got it right for the classifier as it was a bit tricky but went too fast on the other 3. Actually fit was idempotent but so was partial_fit, which it shouldn't.

No worries @brcharron! I just want to check that _partial_fit is necessary instead of partial_fit. You've done good work :)

Everything looks good to me! Thank you very much for doing this.


WalletConnect : More Improvements #2

Should show progress spinner when connecting to WC Dex,  Currently showing a white screen in the connecting process.

Appbar title to Wallet Connect.

Physical device back button not responsive

Oh damn, shouldn't be here.
https://github.com/TrustWallet/trust-wallet-android/issues/1432


Improve developer onboarding experience

Goals:

[x] Setting up and running AntAlmanac should be an extremely easy and fast process for new developers.
[x] Any developer should be able to run the project and work on the frontend without the backend .env file.
[x] Documentation should be publicly available

Know Issues:

Backend server fails and throws many errors without AA_MONGODB_URI .env value

We shouldn't provide this key to everyone.
Should gracefully fail when missing, so terminal output doesn't become a warzone.

Open source developers will not be able to access backend data like news, loadUserData, users, or banners.

These endpoints aren't necessary for most frontend development. However It may be annoying that they cannot save a schedule for local dev though.
For now, won't fix

Open source developers can't access informational endpoints like enrollmentData and websocapi

This data can come from the PeterPortal API (#181 and #182)

Notion pages are not publicly available

Other potential areas of improvement:

[x] Simplify npm commands to install and run the project
[ ] Create a /scripts directory so we can have better start and deploy processes
[ ] Reduce # of npm packages [?]
[ ] Make some notion docs public

#187 fixed an issue that prevented classes from loading due to the /news endpoint failing

All the known issues are fixed now, besides the notion thing. I think by now a lot of the stuff on Notion is outdated or not useful for open-source developers so I'm just gonna close this issue.