Support for per-database primary on different nodes (regions)?

Would it be possible for litefs to manage primary status on a per-database rather than per-node basis to enable different databases within the same application (e.g. one database per SaaS tenant) to prefer their primary in the region that is closest to their primary users but still allow replication/failover if that region fails?
AFAICT from a quick skim of the code the "node is primary" concept seems pretty heavily baked into a lot of the code, so I suspect the answer is not easily - but I also don't see any fundamental reason or constraint on why it should be at the node level, rather than the database level (maybe # of consul leases is a consideration at some scale, but not for a while) - given how useful this type of functionality could be vs the alternative of having to run multiple different litefs instances/clusters for each "primary" region otherwise.
Thoughts?

Yes, per-database primaries is something we are implementing. That's how we have LiteVFS working and we'll port similar functionality over to LiteFS.
I'm always curious about use cases though. Are you thinking you'd want to configure which databases are primary in each region at startup? Or do you have a more complex use case?

Excellent news, thanks!
Ideally it would be tunable at runtime (e.g. app server can make RPC to lifefs server in preferred region to say "take primary now if you can please") rather than needing to be specified at startup, but even having to configure it at start-up would be feasible.
The main use-case for the more dynamic configuration that I see is optimising write-latency for the currently awake users of the app - e.g. imagine 3 different tenants with differing users, tenant a has a team in SYD and LON, tenant b has a team in SFO and NYC, tenant c has a team in ORD. Tenant C is obviously the easy case, app server/primary runs in ORD all the time, but for Tenants A and B, there's clear times of the day where having the primary in one of the locations is going to significantly improve the experience for the users of the app, so I'd like to have a simple layer that for each tenant watches where writes are primarily coming from (e.g. via the Fly-Region header) averages that over some period and then has the app server in whichever of my serving regions is "closest" to that location become primary.
With a handful of tenants configuration at start-up would be OK to manage, but with hundreds/thousands+ of tenants, each with different write patterns, it would be far more optimal to just run a single pool of appservers with common litefs configuration, but be able to hint/trigger a primary handover for a specific DB from within the app as desired.
This is admittedly all a prototype/early idea at the moment, so maybe there's a giant issue/loophole I haven't spotted yet :)

Came here to open an issue to request exactly this functionality. Somewhat different use case though.
Imagine a blogging platform with a built-in CMS. You want fast reads globally, but generally writes are going to be coming from a single region close to the author. If I could have a single sqlite db per author, and dynamically select the primary for that db based on where writes are coming from, it would optimize the author's experience.
Note that for a lot of blogging you can just host static pages on a CDN. I'm wanting to build something that supports protocols like ActivityPub (Fediverse), atproto, WebFinger, WebMention, etc which require a server component.


Maybe fixes Python stuff. I dislike Cython immensely.

Probably fixes #2392. Who knows.

@nicolasnoble - if this works, then merge it, if it doesn't, then don't.
It looks like it should, but I think my Cython install is broken.
I can't tell because Cython is awful.

https://github.com/grpc/grpc/issues/2392#issuecomment-120683176


[Component Proposal] Marketplace FeaturedProductTile

From @lukefirth via Internal Watson-IoT/pal-tracking#133

Is this an extension to an existing component, pattern, or a brand new asset?
Item from the EDS.
What is the rationale for this contribution.
A compound component for showing a single 'featured' resource inside a tile catalog pattern.
Alone, it looks like one white tile, with title, subtitle, description, link (read more), primary button, custom footer content (in this case $100) and a large left aligned image thumbnail:

It can be found as the first example in this link:
https://ibm.invisionapp.com/share/U2NYW8D7DFV#/screens/319196743

@lukefirth - what application needs this? Just trying to understand priority.

@ajnaddell If it wasn't tagged with a team that needs it, then no teams do as far as I am aware. It's here because we were directed to track and eventually implement everything that was an item from the original EDS. Many of them like this have sat on the shelf since that time, until a team raises that a need for it. 👍

no longer valid. closing.


Organization-level agreements

This branch adds support for creating agreements that cover all the repos in an organization account. This adds a new $ORGANIZATION/@ALL entry to the repo drop-down menu that, when selected, allows users to create agreements for all the repositories in an organization they are administrators of.

@jasonm I haven't thought of that usecase, I think the creator of the CLA should create it for any new repository, I'm not a lawyer, but it seems that legally speaking you can't create agreeements beforehand.

Actually this is quite normal in CLA's that you (or the company you work on) can sign a CLA towards another company (so full organization in github speak) with no limitations. So shouldn't be any need to track it by repo if CLA is signed towards the org.

It looks like GitHub have recently added Organization webhooks.
It will notify you when a new repository is created within the GH organization. Have a look in the Webhooks API and scroll down to repository in the Events section.

We are really keen to use this organization-based feature!
Let us know if we can help in any way.

+1 on the value of this use case.  We have too many repositories to process CLA for every one.  It would be much easier to do it once for the organization.

Hi @esteve, I'm one of the new maintainers from the Berkman Center I just wanted to check in since it's been a year since it was put in this pull request no longer cleanly merges after a refactor and ask whether you want to update it to do so (in which case I'll accept the update) or if I should close this out and consider this a template for potentially adding this feature in the future. The same question also applies to https://github.com/clahub/clahub/pull/84. Let me know and I'm happy to proceed with whatever way makes the most sense. Thanks so much for contributing these.

Going to close this and leave #82 open as a feature request.


Update links in README

Update links in README to use 'cloud.ibm.com' URLs.  Update CLI
commands to latest naming convention.

@loafyloaf did you want this merged now? or are you still working on it?

@stevemart should be good, now!

thanks for keeping it up to date @loafyloaf


Functions Cleanup

Removed dateFormatter from FunctionsSerializer as it wasn’t used anywhere
Redeclared FunctionsSerializer as a native Swift class
Updated Functions’s callFunction(url:withObject:options:timeout:context:completion:) to reduce mutability

Nice cleanup– thanks!


Define CMake/CTest tests

In #241 @ChrisKitching described that tests on out of source builds fail because the test executable can't find the JSON files it needs. It's great that he noticed this and provided a fix for it, I totally missed this issue when I rewrote the CMake lists file.
In #242 the issue is fixed by installing the test executable and test files. There are two problems with this approach:

The test executable is used only once by the users of the library. It's executed only after a successful build and never used again, so there is no need to install it on the system level.
For executing the tests in out of source builds we don't need to copy any files at all. In CMake we can define tests with the source directory as their working directory, so tests will be able to find the JSON files no matter where the project is built.

In this PR I defined two CMake/CTest test configurations.

json_unit_default for running the default tests by executing
json_unit without any arguments
json_unit_all for running all the tests by executing json_unit
with the "*" argument

So the tests can be now executed by building the test target:
make test

or by running ctest in the build directory.
The tests can be selectively executed as well with ctest:
ctest -R json_unit_default

or
ctest -R json_unit_all

Coverage remained the same at 99.954% when pulling 639d63217e8d1e1d1b2ced521fd9971466f0091e on robertmrk:feature/cmake-cleanup into 0a393b8374fa92ce17476d0bee2056fc6515805f on nlohmann:develop.

Thanks a lot! I am lacking Cmake experience, so I am happy about any contributions.

You're welcome. I'm glad I could help.


egeria website doesn't render fully on mobile

The egeria website at http://egeria.odpi.org has some issues on mobile
a) Although the page layout changes going down to a smaller device (like iPhone XS Max - which is still large), the navigation capability is nowhere to be seen - I believe it used to appear in a drop down menu
b) Pictures such as architecture diagrams are severely chopped. This is always going to be a challenge on a small device, but perhaps bringing up in a new page, or having scroll bars could be an improvement
One useful suggestion - in Safari, with develop mode enabled, there is an option 'Develop->Enter responsive design mode' which allows the viewer to select different device types for testing.
We should go through the website and ensure they render sensibly. I have actually used the website with friends/at conference to show egeria so would be good to 'look good' -- visitors to a conference may also well follow such a link to find out about the project.

still broken 2020-03-27

This still occurs.
The top level egeria page no longer includes navigation.
However the link to 'tutorials' does display a left nav bar on desktop.
This does not appear on mobile (iOS 13.5, iPhone XS Max)

On mobile it's still tricky to find content. The nav bar on desktop gives a top level list of information which is quite useful - it I want to use, or contribute, or learn. This is lost on mobile where we only see the detailed text.

Still seems odd on mobile, but if no-one is concerned we can close

@cmgrote - FYI given you are looking at updated formatting of these pages

Assuming we go for the change to the suggested MkDocs approach that @davidradl and I are using in our repos it should render great on mobile -- including adaptive / reactive changing of the menus and table of contents to not take up any of the page but be collapsed menu bars instead, etc.
Hope to have a prototype of some of the main areas of the site up in early August on my fork for us to review.
(I'm seeing areas for what I think will be significant improvements to consumability, but they need some rework to some of the existing pages to achieve, so TBD...)

@planetf1 is this fixed?

@mandy-chessell yes, we are much better now with the new docs site, and I can generally navigate.
The only confusion is if one goes to 'learn more' on the front screen, the left nav no longer works adequately - and only contains the challenge/our solution / key concepts / patterns. Different to on the web where the main nav bar remains. This is slight confusion, though a 'back' in the nav panel gets one back to the main menu. A minor usability glitch. May just be me who normally goes via that route on the web page.
Much easier to go straight to the (hamburger) menu which has the full navigation.
I think we can close for now

The only confusion is if one goes to 'learn more' on the front screen, the left nav no longer works adequately - and only contains the challenge/our solution / key concepts / patterns.

This is probably more a less-than-intuitive way that the theme works rather than it not being possible...  Basically on a mobile device all the navigation structure is collapsed into the hamburger menu, but since it is many levels deep there is a back arrow in the hamburger menu itself that allows you to jump up a level in the nav structure -- what's shown there the first time you open it is the nav structure at the level of the page you're viewing, rather than the top-level nav structure (you need to use that back arrow to go "back" up to a higher-level in the overall nav structure).

Yes - it was just confusion over where 'learn more' took me to. Probably just me. I had no problem finding the content with the back menu, it was just that difference with my particular navigation on the web. hence agreeing it should be closed :-)


Set up the VS Code experimentation framework in Bicep Extension

To allow A/B testing of incremental changes, the VS Code experimentation framework helps us know the features/ideas we add or augment have the desired outcome towards our goals.
Once this is set up, we are able to test our features in a tested rollout 10% -> 50% before making the feature 100%. We are able to set up metrics before a feature is created to understand the impact of the changes we make (perf, increase in usage of specific features). We'd also be able to rollback any unintended regressions if they were to happen.

Waiting on 2day usage to catch up so we'll be able to reach statistical significance

Update, we have reached statistical significance due to our 2day usage growth. We would be able to set this up if there is ever a clear need for us.


Translation to Elm

Hi, I translated your awesome icons to Elm: https://github.com/arnau/elm-feather
Thanks for all the work!

Awesome 🎉 Nice work!


Saved dashboards currently available to anyone to view

Until full permissions are implemented in #27  this should be considered an urgent bug to fix.

This was a deliberate design decision but I've changed my mind on it: https://github.com/simonw/django-sql-dashboard/blob/831bd769ab7b702e9570988d10113a583236e92d/test_project/test_dashboard.py#L23-L36


useTabs seems to not be respected

With the following .prettierrc.json configuration, I get proper tabs on all ts files, but not prisma, where I get 4 spaces instead.
{
	"useTabs": true,
	"tabWidth": 4,
	"semi": true,
	"singleQuote": true,
	"trailingComma": "all",
	"printWidth": 120
}

Am I missing something?
Steps to reproduce the behavior:

Using this config, make a prisma file with fucked up indent
Use prettier ./file.prisma

Expected behavior
Formatting would end up as tabs
Tools (please provide the output of the following commands):

Node version: v17.9.0
OS name: Arch-linux
Installed prettier versions: 2.6.2
Installed plugin versions: 3.13.0

Hey @Arteneko ! prisma-fmt only supports tab_width parameter and therefore Supported Options are limited

Do you intend to support tabs at some point?


Error: Unable to allocate 30.9 TiB for an array with shape

Hi,
I tried to run your workflow on a dataset that was maybe a bit huge: 2x100Go of reads and 29Go of contigs.
The job fails with the following error message:
2024-09-13 03:37:18 bigben SemiBin[2634920] INFO Binning for short_read
2024-09-13 03:37:24 bigben SemiBin[2634920] INFO Did not detect GPU, using CPU.
2024-09-13 03:38:23 bigben SemiBin[2634920] INFO Generating training data...
2024-09-13 03:38:38 bigben SemiBin[2634920] INFO Calculating coverage for every sample.
2024-09-13 03:38:38 bigben SemiBin[2635078] DEBUG Processing `/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/2-bam/salade_I_longreads.bam`
2024-09-13 06:05:53 bigben SemiBin[2634920] INFO Processed:/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/2-bam/salade_I_longreads.bam
2024-09-13 06:05:54 bigben SemiBin[2634920] DEBUG Start generating kmer features from fasta file.
2024-09-13 09:06:14 bigben SemiBin[2634920] INFO Start binning.
2024-09-13 10:45:24 bigben SemiBin[2634920] DEBUG Calculating depth matrix.
Traceback (most recent call last):
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/bin/SemiBin", line 12, in <module>
    sys.exit(main1())
             ^^^^^^^
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/main.py", line 1482, in main1
    main2(args, is_semibin2=False)
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/main.py", line 1455, in main2
    single_easy_binning(
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/main.py", line 1181, in single_easy_binning
    binning(**binning_kwargs)
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/main.py", line 1089, in binning
    cluster(
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/cluster.py", line 271, in cluster
    embedding, contig_labels = run_embed_infomap(logger, model, data,
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/cluster.py", line 147, in run_embed_infomap
    kl = cal_kl(depth[:,2*k], depth[:, 2*k + 1])
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/SemiBin/cluster.py", line 54, in cal_kl
    res = ne.evaluate(
          ^^^^^^^^^^^^
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/numexpr/necompiler.py", line 974, in evaluate
    return re_evaluate(local_dict=local_dict, global_dict=global_dict, _frame_depth=_frame_depth)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/kwak/hub/25_cbelliardo/MetaNema_LRmg/HiFi-MAG-Pipeline_vSR/.snakemake/conda/43e6297b5052c3e5d1df94ac7f19edd3_/lib/python3.12/site-packages/numexpr/necompiler.py", line 1006, in re_evaluate
    return compiled_ex(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
numpy.core._exceptions._ArrayMemoryError: Unable to allocate 30.9 TiB for an array with shape (2912965, 2912965) and data type float32

The problem is raised with the memory usage of semibin, but it is impossible to tune this parameter.
I hope you have an idea of how I can manage this issue.
I appreciate your help.
Carole

Hi @CaroleBelliardo,
I'm not sure this would be feasible with the pipeline - 30 Tb of memory is extraordinary.
Is this a metagenomic dataset? Is it all from a single sample, or are you combining many samples?
We've been able to run large datasets successfully before, including the following:

human gut: 2.7 Gbp contigs (n= 66,952), 256 Gbp HiFi reads (n= 34.7 million reads)
wetland soil: 17 Gbp contigs (n= 248,320), 195 Gbp HiFi reads (n= 20.6 million reads)
grassland soil: 19 Gbp contigs (n= 1,577,250), 151 Gbp HiFi reads (n= 17.3 million reads)
grassland soil: 37 Gbp contigs (n= 3,762,649), 283 Gbp HiFi reads (n= 30.4 million reads)

No response, closing for now.


Update AudioWorklet article for M66 launch

PTAL: @petele, @cwilso
What's changed, or what was fixed?

Updated the content to prepare for the stable launch of AudioWorklet in M66.

Target Live Date: 2018-03-15 (or later)

[ ] This has been reviewed and approved by (NAME)
[x] I have run gulp test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

Thanks for the review and the merge, @petele!

:tada: This has been pushed live to https://developers.google.com/web/


Labeled of asciidoc is not parsed.

The labeled of single-line is not parsed correctly. When I use labeled of multi-line, The label is not parsed.
Labeled, single-line
asciidoc
first term:: definition of first term

section term:: definition of second term

Validator
function validateSentence(sentence) {
  console = {
      log:print
  };
  console.log(sentence.content)
}

Result
first term1:: definition of first term1
section term1:: definition of second term1

Labeled, multi-line
asciidoc
first term::
definition of first term

section term::
definition of second term

Validator
function validateSentence(sentence) {
  console = {
      log:print
  };
  console.log(sentence.content)
}

Result
definition of first term
definition of second term

Thank you very much for the report @kongou-ae! I will look into this issue.

I fixed this issue in #685. Hopefully this fix works for you. I will close this issue but please let me know  if you still have the problem.

Thanks. I tested this. But Labeled is not parsed. Specific examples are as follows.
hogehoge::
ほげほげー

hogehoge::
* ほげほげー
* ほげほげー
* ほげほげー

ほげほげ is parsed to ListElement. But  hogehoge is not parsed to ListElement.

I think the current RedPen coverers first example, however I have not seen the second example (labeled list containing standard list elements). If AsciiDoc supports the second, we will fix the parser to handle the following sample.
hogehoge::
* foo
* bar
* baz


tests: interrupt: add test cases of offloading job from isr

Add 3 test cases to test offload job from isr, include:

test_isr_offload_job_multiple()
Validate the offloaded work executes immediately or not depends on its priority, and it offloads to different k_work.

test_isr_offload_job_identi()
Validate the offloaded work executes immediately or not depends on its priority, and it offloads to the identical k_work.

test_isr_offload_job()
Use dynamic interrupt instead of irq_offload() to verify the offloaded work.

Ps: These test cases are not to improve the code coverage, and we treat them as integration test cases.
Signed-off-by: Enjia Mai<EMAIL_ADDRESS>

@maksimmasalski Thanks for your review, I have addressed the typo you mentioned.^^

@andyross, could you take a look at the PR?

Hi @maksimmasalski , thanks for point out the error in line 270 (the false shall be true), I have corrected it, thank you so much!


question : how to handle "per environment" clusters ?

We handle several clusters, in different environments (dev, staging, production) and we have a question about CI/CD in such context :
ns4kafka is able to handle namespaces related to different clusters, but namespace names must be unique.
Thus, if I want to deliver "myNamespace" topics in my development cluster, and topics in another "myNamespace" for production cluster, how should I do ?
Is it better to use one ns4kafka server per environment, or should I prefix namespaces name by environment name ?

@piif

Thus, if I want to deliver "myNamespace" topics in my development cluster, and topics in another "myNamespace" for production cluster, how should I do

You can manage different contexts using kafkactl:
kafkactl:
  contexts:
    - name: dev
      context:
        api: https://ns4kafka-dev-api.domain.com
        user-token: my_gitlab_token
        namespace: my_namespace
    - name: staging
      context:
        api: https://ns4kafka-dev-api.domain.com
        user-token: my_gitlab_token
        namespace: my_namespace
    - name: production
      context:
        api: https://ns4kafka-prod-api.domain.com
        user-token: my_gitlab_token
        namespace: my_namespace

and set your CI/CD jobs on the desired context before running actions:
kafkactl config use-context dev


JAVA-2552: RequestHandlerTestHarness improvements

When rebasing onto 4.x, please keep the 2 commits separate.


Update troubleshooting-ci.md

Add troubleshooting for harnessImage connector in older accounts

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Mouse crashes

Log 1: https://pastebin.com/npFwQZ4S
Log 2: https://pastebin.com/GF4kGwBt
I have Architectury API installed if that causes any issues.

Does the same crash occur if you remove Sodium and Indium? This looks like an issue with Kibe or Architectury, not Sodium or Indium.

Does the same crash occur if you remove Sodium and Indium? This looks like an issue with Kibe or Architectury, not Sodium or Indium.

Oh, yeah, it seems to not be because of Indium.
Sorry about this.


Add Linux with SQL Instances

This all looks good locally, pricing appears in the right areas and manually checking against the pricing on the AWS pricing page shows they are correct. It does make the list quite long but wasn't sure of a nice way around that.
Fixes #335.

Thanks!


docs: readme

docs: environment variables
docs: typegen
chore: add inline todos
fix: use Hydrogen caching strategy type
docs: update README
fix(deps): upgrade non-major

Closes #100

Resolves #86

Resolves #75

Resolves #99


Using CreateWICTextureFromMemory() or CreateWICTextureFromMemoryEx() with PNG loaded in memory

ID3D11Resource** texture always created in DXGI_FORMAT_B8G8R8A8_UNORM pixel format.
How to force create resource in DXGI_FORMAT_R8G8B8A8_UNORM pixel format ?

The WIC codec for PNG is returning the data as BGR, so it maps to DXGI_FORMAT_B8G8R8A8_UNORM. See MSDN for the WIC pixel formats supported by the WIC PNG codec.
If you want a different format, you should use Convert after loading the image before creating it the texture.
Of course, the question is (A) why does it matter if it's BGR or RGB, and (B) do you really need to use the DirectXTex library to load your DDS or would you be better served by the light-weight WICTextureLoader module?

A ) I experementing with DirectX 11. SwapChain and all stuff  in my project are in DXGI_FORMAT_R8G8B8A8_UNORM. So, when i use CopySubresourceRegion() i get debugger error about different formats, and i found that PNG textures was created in DXGI_FORMAT_B8G8R8A8_UNORM.
B ) I prefere to use WICTextureLoader module and CreateWICTextureFromMemoryEx() function
I just add into WIC_LOADER_FLAGS enum new value
    enum WIC_LOADER_FLAGS
    {
        WIC_LOADER_DEFAULT      = 0,
        WIC_LOADER_FORCE_SRGB   = 0x1,
        WIC_LOADER_IGNORE_SRGB  = 0x2,
	WIC_LOADER_FORCE_R8G8B8A8_UNORM	= 0x4,
    };

and modify CreateTextureFromWIC() function at line 491 WICTextureLoader.cpp  like that :         if (FAILED(hr) || !(support & D3D11_FORMAT_SUPPORT_TEXTURE2D) || (loadFlags & WIC_LOADER_FORCE_R8G8B8A8_UNORM ) )
thats work for me.
Thanks

Trying to do all your drawing with the copy engine on the hardware is probably the most efficient use of the silicon.  A much better solution is to actually render your textures on the render target, which is much more powerful and flexible. If you are mostly concerned with 2D rendering, take a look at SpriteBatch in the DirectX Tool Kit.


Sometime when plotting a graph and closing MagPy, pyton is still running

Problem occurs e.g.: Open File, Select keys, Quit

Soveld by properly including the close events and close method (see b4dd20fe5ec6fd8cda3400315a7feed93cdee2ba)


WIP: add Alpaca API to momentum scanner

@riven314 I will merge the PR now, @riven314 I think we need to create documentation that explains how the new momentum scanner is working how to extend it?
@sigmantium thank you for the comments. Pls, take a look when you have time.

@riven314 Actually I can't merge it due to conflicts. Can you pls merge from the master, fix conflicts, and push? I'll merge once done.

@amor71 I have resolved the conflict, once the test is fine. Its ready to be merged


URL decode passwords for storage

Closes https://github.com/astral-sh/uv/issues/2822
Same idea as https://github.com/astral-sh/uv/pull/2592
Needs a test plan still.

I think the problem is roughly that we use set_username and set_password to apply the credentials
https://github.com/astral-sh/uv/blob/43ded54bd3f53d6ce9bab815cf2098a1814885af/crates/uv-auth/src/store.rs#L47-L55
but those percent-encode the credentials which should already be percent encoded since we pulled from from url.username() and url.password() which do not perform decoding.
I want to make some changes to the documentation and structs here to clarify this.

Implemented in https://github.com/astral-sh/uv/pull/2976


Correct first header text "GCP" to "AWS" ;-)

Modify the document first line from "Google Cloud Platform" to "AWS" as this the AWS guide ;-)

Description
I modified the first line to AWS because it is the AWS installation guide

Motivation and Context

The guide title does not correspond to the content.
It does not really solve any problem but avoid possible confusion to newbies (like me)

How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[X] Have not tested

Not need to test because is a change in the documentation, not the executing code.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

@juangascon Please sign your commit. Thanks.

@haido Could you please tell me how I should sign my commit? The checks not succesful are because of me?
Sorry for not coming around before :-(

Hey, @juangascon You can signoff your commit by doing git commit --amend --signoff and then force push to your branch by git push -f

@rdimitrov I did this change online, directly in GitHub. So I did not sign the commit anywhere :-( Sorry. It is a so simple change that I did not think I should have to download all NSM.
I understand that I have to clone the repo in my PC and make the modifications there, then push to my branch in the forked repo and launch a new pull request from there?
Or just pushing to my forked repo will do the job?

@juangascon Oh, I see. You're right, in that case you should clone the branch that was created -
git clone https://github.com/juangascon/networkservicemesh.git -b doc/guide-aws/title
and then follow the commands from above 👍

@rdimitrov Hello. I have just followed the steps you told me.
I saw my name in the commit log. Hope all is OK. :-)
Sorry for not doing it sooner.
Take care.


[HOLD for payment 2021-11-04] Log in - Add country code information in login - @parasharrajat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to log in
Try to enter a non-number

Expected Result:
There should be some information about the need to add a country code for a phone number.
Actual Result:
There's no information about the need to add a country code for non-US numbers.
Workaround:
N/A, visual issue
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.7-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634061841202800
View all open jobs on GitHub

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Not sure if this is a daily or not, did we ever had a message about needing country code and this is a regression? if it's a regression then daily is probably good but if we just need to tweak the messaging then weekly is probably fine too 🤷♂

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Just closed the job and paid out your fee and bonus @parasharrajat!

@parasharrajat I'm double checking but I believe if a bonus was applicable @kadiealexander commented on each issue to highlight it, I'll look through the notes again and will issue you a bonus if it applies.

OK. Here are a few points to help you determine:

you removed the label https://github.com/Expensify/App/issues/5821#issuecomment-947864892.
I submitted the PR during the hold.
PR got merged after N6 was lifted.
I see that a few issues are applicable for the N6 bonus even if the PR was created after the N6 hold was removed.

@adelekennedy I think Rajat is right here, see my comment in the PR, where the PR was on hold and I have waited with reviewing.

Perfect (that's my mistake) I just hired you @parasharrajat, once you accept I'll pay out the $250 N6 hold bonus, thank you for your patience!

@adelekennedy Done.


IllegalArgumentException when replacing strings in series

First of all, koalas is awesome :)
I'm trying to extract substrings from a Series of text. However, these substrings aren't always present, resulting in "NaN" (the string not the float). I would like to convert these to np.nan or None so that I can use ks.fillna. However I get an IllegalArgumentException

Py4JJavaError: An error occurred while calling o410.select.
: java.lang.IllegalArgumentException: requirement failed: All input types must be the same except nullable, containsNull, valueContainsNull flags. The input types found are
StringType
DoubleType

Here is a minimal example to reproduce the error:
import databricks.koalas as ks

titles = ks.Series(['The Duck Goes Here', 'The Tower Commission Report', 'US royalties (USD)', 'UK royalties (GBP)'])
titles_parsed = titles.where(titles.str.endswith(')')).str.split().str.get(-1).str.strip('()')

# titles_parsed is
# 0    NaN
# 1    NaN
# 2    USD
# 3    GBP
# Name: 0, dtype: object

print(type(titles_parsed.loc[0])) # <class 'str'>

replaced = titles_parsed.replace('NaN', None)
print(replaced)

# This gives the error above

Do you have any suggestions on how I can work around this?
I've also attached the full stack trace below (please let me know if you need me to run any tests). I'm also using
Python version: 3.7.6
Koalas version: 1.0.0
koalas_nan_replace_stack_trace.txt

Let me close this since it works well in latest Koalas.
>>> replaced = titles_parsed.replace('NaN', None)
>>> print(replaced)
0    None
1    None
2     USD
3     GBP
dtype: object


Upgrade to Spring Boot 3.4.0

Spring Boot 3.4.0 has some backward-incompatible changes that require upgrading
some other dependencies at the same time, as well as a change to one of the test
assertion APIs, so Renovate can't handle the update automatically.

#2658  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 4, 6:57 PM EST: A user merged this pull request with Graphite.


Linker errors when forgetting #[no_link] on a plugin

Not sure if this is a Cargo or rustc issue, but my first inclination is to think that Cargo is passing some wrong paths or something.
I've been debugging this linker error in the json_macros crate. I narrowed the reproduction down to this: https://github.com/tomjakubowski/json_macros/tree/repro
Here are the errors on cargo clean && cargo run --verbose --example kitchen-sink:
http://sprunge.us/UTCT
If I add #[no_link] to the extern crate json_macros; in the example, it works just as expected. It looks to me like the example and json_macros are somehow linking to different versions of the rustc-serialize crate, but I'm not sure.
[tom@hannibal json_macros]$ cargo --version
cargo 0.0.1-pre (1a1868b 2014-12-31 21:39:41 +0000)

Ah, I think this will be just fixed by rust-lang/rust#21043

Yeah unfortunately plugins currently require #[no_link] to be placed on them and aren't too useful otherwise! I'm going to close this in favor of https://github.com/rust-lang/rust/issues/21043 as it will likely be smoothed over with that.


[IOTDB-2604] batch size is invalid in import-csv tool

Coverage increased (+0.003%) to 67.795% when pulling d02e4fff38ceae095f34725cc3980c42a0eedd67 on xuanronaldo:fix_2604 into 45c679b7ebcf49389720d47bc0d680ed50c4f68b on apache:master.


Backport bugfixes for 0.12.2

#6419 is the last PR that I want to include in this release. Once that's merged, I'll cherry pick it to this and we can talk about if we're going to merge this for a 0.12.

👍

@jwilder just committed the last of the changes that should be 0.12.2. Are there any others I might be missing before I merge this?


Feature/pizzeria

Scraper, Routes and Cache for Uni Pizzeria.
Views are missing.

Augmented to return day-wise menus and merged into develop


Can we cherry pick LTS change into a 4.4.4 release

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.4.3 after finding regression in 4.5.0 and testing main for fix.
Please ask your question
Can we cherry pick this commit into a point release based on 4.4.3 (E.g. 4.4.4)
https://github.com/shaka-project/shaka-player/pull/5602/files
Reason why:
We found and filed an issue after we upgraded to 4.5 (to pick up our fix for LTS Event).  We are unable to update to this version until we PR a fix for this issue
This may take a couple weeks and we are in need of this change asap. We can do the work to PR this cherry pick if you all think you could do the point release?

Shaka is following a semserver versioning, this change is of type feat. So it should not be migrated to 4.4. But he left the final decision to @theodab or @joeyparrish . Sorry!

@dsparacio If you want to mix and match releases, may I suggest creating a custom build for the time being. That lets you do the custom stuff you need, without shaka-player having to break versioning standards. Seems like a win-win to me.
The instructions and scripts to do so are here: https://github.com/shaka-project/shaka-player/tree/main/build


Fixing entities to include all defaults

as per title.

While looking at this also:

Fixed use of 'type' as varname when its a python reserved word (changed to etype)
Removed unnecessary if/else statement when default entity type is already specified in the init function for a MaltegoEntity.

Another fix that might be worth doing at the same time, in handler.py:
print("Command not recognised. Available commands are: \n 'runserver'")
Should be:
print("Command not recognised. Available commands are: {0}".format("\r\n".join(commands)))```


Switch rafx-shader-processor to spirv-cross2

Hi, reaching out because I've noticed that like I have, y'all have also forked spirv_cross to get some new features in since the original crate has pretty much been abandoned in favor of naga.
I got tired of dealing with unsoundness in spirv_cross and decided to wrap the SPIRV-Cross C API and wrote a new set of bindings that I'm using in my projects now instead:
https://github.com/SnowflakePowered/spirv-cross2-rs
It seems like rafx-shader-processor is a relatively stable part but I thought I'd leave this here in case it's of any help.

Thanks for the note. I’m in the process of switching to DXC and apple’s shader converter. This will remove the usage of spirv_cross entirely.


Use govendor to manage dependencies

https://github.com/AsynkronIT/protoactor-go/issues/89

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks for the pull request. We are very interested in locking dependencies to specific versions in order to ensure repeatable builds. dep is emerging as the standard for vendoring dependencies in Go, and therefore we are following this project closely in anticipation of its availability. Once generally available, we'll consider it as the official tool to vendoring.

Ok。But govendor just use go's vendor dir to manage dependency, it should be compatible with the official dep tools. So, It can be a easy and temporary solution for dependency now.


com.beardedhen.androidbootstrap.BootstrapDropDown is not showing Selected Value

Please provide a minimal, complete, and verifiable example to help reproduce the issue.


Import VTS Landscape Streaming Plugin in unity and can't work

I download VTS Landscape Streaming Plugin package in unity.
When I open every scene in Vts/Demo,and press play ,it always pop up error messages.
I've Followed the command to set up the link, but still can’t run.

Hi,
Did you download it from unity store or from github?


Make breathe function more flexible

Thanks for the great library! Here is a change I find useful:
Instead of just a period argument, breathe function now accepts fade-on, on and fade-off durations for more a more flexible breathe animation.
As this causes a breaking change, we could add this as a separate function instead. Open for suggestions.

Any comments on this? I will adapt the tests too if accepted.

Coverage increased (+0.1%) to 96.985% when pulling 10cef3e313fa16aedad05515bb39485469b20bb7 on boraozgen:feature/advanced-breathe into 5a6f48c4f1d8b83925954f8267fbc90f93875909 on jandelgado:master.


Select text in integrated terminal with keyboard and not using the mouse

Being able to to use similar features as "mark mode" (Windows terminal) or "copy mode" (tmux) to be able to select text in the integrated terminal without the need of using the mouse. For example, "mark mode" uses ctrl+shift+m to enter the mode where you will be able to navigate the terminal with keyboard and select text to yank/copy. tmux for example uses ctrl+b [ to enter selection mode.

You can now do this by running Terminal: focus accessible buffer and then use editor shortcuts to copy parts of the text via keyboard


enable dependabot for this repo

There's a critical security vulnerability for axios: https://github.com/axios/axios/releases/tag/v1.6.0
It would be nice if the http-api-proxy-server would come with an up-to-date axios version and it's verified that all tests are passing against the newer axios version.

0.0.11 will include this and other security updates. Also dependabot is enabled from now on.
Unit tests will still be improved.
The Playwight tests we have should ensure everything keeps running.


Settings fixes

Port relevant fixes from #173 to v2_devel.

@1337-server this branch looks much nicer! Are there any known issues holding up adding a Dockerfile?

It's been a while since I checked it fully but, the docker_udev branch is pretty much just the v2_devel branch with the added Dockerfile. I can't remember any major issues with it, just small annoyances getting it started (the user, group id, etc.)


Fix compatibility with latest psutil version

get_cpu_percent is now cpu_percent

Just a reminder about this issue which just hit me and looks like it shouldn't be too bad to fix!

@astrofrog  - I fixed that on my local copy last week, to be able to use psutil, but I forgot to open a PR ! I can push that later today.

It seems to work for me with the latest dev version, and was going to do another release now.
@saimn - what kind of changes did you have to make?

@astrofrog  - https://github.com/saimn/psrecord/commit/b6d2720992c8edc5897d969a112552bae65b2333
I pushed very quickly as I have to go. I had to use children instead of get_children and changes to get cpu/mem from subprocesses.

Thanks!

@saimn - thanks, I've included your fixes in https://github.com/astrofrog/psrecord/pull/19, and added some tests for better coverage.

@joezuntz - the latest developer version should now work correctly (thanks to @saimn's fix). Can you confirm that this is the case? I'm planning on doing a release once the Travis OSX builds work again and I'm able to confirm that this all works fine from a CI point of view.

@astrofrog - thanks !

Yep, works for me now - thanks!

@joezuntz - thanks for confirming! psrecord 1.0 is now out, so closing this.


Add parser for tb.dat

Some other people seem interested in this, so let's push this to upstream repo :-)
fix #33

Sorry for the late reply, finally have some time to add a pytest.
Unfortunately, I cannot generate a tb.dat file that is fully consistent with the current hr.dat file in the pytest regression data, because

the Hamiltonian depends on the gauge (from Wannierization)
and most importantly, it seems the current W90 v3.1 generates a different set of R vectors (use_ws_distance = .true.) than the current wsvec.dat in regression data, see the new file here
https://github.com/Z2PackDev/TBmodels/blob/130bf4f98d49d2c812b4f152fbaa0b815a17815e/tests/samples/silicontb_wsvec.dat#L139-L141
and the old file
https://github.com/Z2PackDev/TBmodels/blob/130bf4f98d49d2c812b4f152fbaa0b815a17815e/tests/samples/silicon_wsvec.dat#L139-L142

So in the end I added new regression data for the tb.dat pytest, instead of comparing it with the existing regression data for hr dat.
Also, it seems the pre-commit has some version incompatibilities between black and click, and pylint. Not sure what are the versions you were using?

If we generate a hr.dat, tb.dat and wsvec from the same Wannier90 run, can we add a test that compares the two method for loading the data?
IMO we could also replace the previous regression data, since the load from hr.dat hasn't changed in this PR.
The pre-commit issue is due to https://github.com/psf/black/issues/2964; the easiest change is changing the click requirement to click>=7.0, !=7.1.0, <8.1 for the time being; I will update the pre-commit dependencies (and probably switch to poetry so we get consistent CI runs) in a separate PR.
The pre-commit is fairly outdated though, and FMPOV it's fine if we just ignore it for this PR. I can upgrade and fix it in a separate PR.

If we generate a hr.dat, tb.dat and wsvec from the same Wannier90 run, can we add a test that compares the two method for loading the data? IMO we could also replace the previous regression data, since the load from hr.dat hasn't changed in this PR.

Yes this is the best solution!

The pre-commit issue is due to psf/black#2964; the easiest change is changing the click requirement to click>=7.0, !=7.1.0, <8.1 for the time being; I will update the pre-commit dependencies (and probably switch to poetry so we get consistent CI runs) in a separate PR. The pre-commit is fairly outdated though, and FMPOV it's fine if we just ignore it for this PR. I can upgrade and fix it in a separate PR.

That would be great!
So, to proceed, maybe you could first update the pre-commit and poetry stuff, then I will make sure this PR doesn't break any of these checks. For the tb.dat file, either you regenerate the test data (tb.dat, and the hdf5 test files...), or I can regenerate and replace the old files, which one do you prefer?

So, to proceed, maybe you could first update the pre-commit and poetry stuff

This is done, but produces a merge conflict because I switched to a src/ layout. Let me know if I should help out in rebasing / merging that.

can regenerate and replace the old files

If you could regenerate them with the latest Wannier90 would be great, thanks!


[CP3.0] reimplement operandrequest mutating webhook

How to test:
Setting up dev cs-operator image on your cluster:

ensure you have future catalogsource on your cluster
export REGISTRY=quay.io/yuchen_li1
run make build-dev-image
edit manager.yaml image: quay.io/yuchen_li1/common-service-operator-amd64:dev
run make build-bundle-image
run make run-bundle

Testing:

search for service ibm-common-service-webhook
search for mutating webhook ibm-common-service-webhook-configuration
create an operandrequest, mutating webhook will set the correct namespace for it.

The MutatingWebhookConfiguration can be created now, but this expected pointer, but got invalid kindError setting up webhook server error still exists...
It happened on this function https://github.com/IBM/ibm-common-service-operator/pull/1023/files#diff-6242436e174eb22954722f8360a791a30d570d828b7ead1ec4708816ed34238cR139, still investigating on why it reports this error
I even can see the same error in the cs-webhook in CP2.0... and it works well for a long time, maybe it is at low risk.
BTW not sure if we need to keep this env var check in cs-operator: https://github.com/IBM/ibm-common-service-webhook/blob/master/cmd/manager/main.go#L143

BTW not sure if we need to keep this env var check in cs-operator: https://github.com/IBM/ibm-common-service-webhook/blob/master/cmd/manager/main.go#L143

I think we could keep this env variable available in cs-operator.
It is only for debugging purpose or we could easily disable the webhook deployment when something goes wrong.
If there is no env variable set, we should enable the webhook by default.

The MutatingWebhookConfiguration can be created now, but this expected pointer, but got invalid kindError setting up webhook server error still exists...

Trying to explore where this error comes from

It returns from blder.Complete()
blder.Complete() returns blder.registerWebhooks()
blder.registerWebhooks() is possible to return an error from two functions

blder.gvk, err = apiutil.GVKForObject(blder.apiType, blder.mgr.GetScheme())
err = blder.registerConversionWebhook()

Both functions have a call on scheme.ObjectKinds(obj) from apimachinery package
Function ObjectKinds(obj Object) will return an error on v, err := conversion.EnforcePtr(obj)
Function func EnforcePtr(obj interface{}) ensures that obj is a pointer of some sort. Returns a reflect.Value of the dereferenced pointer, ensuring that it is settable/addressable. Returns an error if this is not possible.
And finally we will get an similar error msg expected pointer, but got invalid kind

Also there is a relative issue for DELETE operations on Mutating Webhook, not sure if it is what we could avoid. Currently I did not observe any deletion operation for OperandRequest mutating webhook
https://github.com/kubernetes/kubernetes/issues/66412

I even can see the same error in the cs-webhook in CP2.0... and it works well for a long time, maybe it is at low risk.

Personally, I think we could ignore this error for now, given it exists in previous webhook deployment and we did not hit any issues. Instead we could more focus on whether its functionality is working properly.

2023-02-16T19:34:14.162Z ERROR controller.commonservice Reconciler error {"reconciler group": "operator.ibm.com", "reconciler kind": "CommonService", "name": "common-service", "namespace": "ibm-common-services", "error": "unable to get: /ibm-operandrequest-webhook-configuration because of unknown namespace for the cache"}

The error is due to the uncached webhook-configuration in cs's manager.
Add a customized Cache to store cluster-scoped webhook configurations.

The test looks good so far.
But as Henry stated, we will need to support multiple webhook configurations in the same cluster, per tenant.

change webhookconfiguration name unblock the multi-wehook test
two issues still in testing:

not sure if we need to change the webhook name as well
https://github.com/IBM/ibm-common-service-operator/pull/1023/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R261
not sure if we should keep the rule of webhook as namespaceScoped
https://github.com/IBM/ibm-common-service-operator/pull/1023/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R266

not sure if we need to change the webhook name as well
https://github.com/IBM/ibm-common-service-operator/pull/1023/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R261

I think we could keep this as is for now.

not sure if we should keep the rule of webhook as namespaceScoped
https://github.com/IBM/ibm-common-service-operator/pull/1023/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R266

We could keep its NamespaceScoped given OperandRequest is a namespace-scoped resources


[stable/drone] added the ability to override DRONE_RPC_SERVER

Signed-off-by: Davíð Örn Jóhannsson @davideagle<EMAIL_ADDRESS>
What this PR does / why we need it:
Adding the ability to overwrite DRONE_RPC_SERVER environment variable. We use an ingress to for the RPC server in order to allow EC2 build agents to access the RPC server running in kubernetes.
Values.agent.rpcServerOverride: http://server
@zakkg3 @christian-roggia @paulczar
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[x] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @zakkg3

/ok-to-test

/lgtm


Use tarsafe instead of built-in tarfile to extract archives

Had to bump down the Semgrep version due to https://github.com/returntocorp/semgrep/issues/6631


fix changelog

What this PR does:
fix changelog update script
Which issue(s) this PR fixes:
Fixes 430
Checklist

[x] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Looks like CI stuck? Will close, re-open to try to get unstuck.

@Yuqi-Du yeah, forgot to mention that close/re-open did not work. Not sure what is going on.

This PR doesn't change any files that match the trigger for the CI workflow, that's why the required checks don't run. @tatu-at-datastax @Yuqi-Du
  pull_request:
    branches: [ "main" ]
    paths:
      - 'src/**'
      - 'pom.xml'
      - '.github/workflows/continuous-integration.yaml'

You should be able to trigger the workflow manually for this branch. I think GH will pick up that the checks have run after that. If that doesn't work you might have to make a trivial change to some file that will trigger the run.

@jeffreyscarpenter I should have realized this is the case, thank you for pointing this out.
Then again, this change won't be tested by any of the checks anyway so I guess it all evens out.


Enable search of resources, type, kind, etc. in the global search feature

observed on 2.6-head (4def656):
Request:
Allow the global search feature to have a nested search option, which when enabled would have the ability to search in each resource's search function.  i.e. the global search option would have a checkbox nested search, which would show results from this search function from each respective resource in rancher (top right of each resource page, see screenshot)

there are several options to display results with this option toggled in the global search. Here's my top pick:

show only the parent resource, then when user clicks the parent resource with a match, it would bring them to the resource with the nested search already displayed (like the screenshot above)

Example:  for secrets, there are the following options on a create:

If a user searches for registry, Secret should show up in the list (this does not currently happen when using the global search).  When the user selects this item, the search should close and bring the user to the resource on the specified resource page (think of how slack search function works; search for something, some matches come up, then when you select the match you want, you're brought to that exact spot in the thread/channel.  this would be great to emulate here, or something similar.)

This would require a 'full-text-search' type of API in steve to search all the things, the UI can't really do anything beyond loading individual types you're looking at and searching them in the client without that.


Correct shutdown sequence

Which is the correct shutdown sequence to do when closing application?
I'm currently call
send_query(td_api::make_object<td_api::close>(),{});
So after that what I should do to ensure tdlib client is correctly shutted down?

You need to handle updateAuthorizationState updates for that. You will receive the update with authorizationStateClosed eventually.

ok thanks


Error when trying to bump package version: "git: 'switch' is not a git command."

When publishing the package with docker-compose run --rm bump minor (per the docs), I get this error:
git: 'switch' is not a git command.

This is because the docker container has git version 2.20.1 while git switch was added in 2.23.0 (https://git-scm.com/docs/git-switch/2.23.0).

Have you pulled latest to pull in this change? #94

Yes, I have.

Oh, I see now. It is a different git command that is failing now.


Digest-less images always re-download after last-modified time changes on server

Description
When downloading cached image, if the last modified time from the server is different from the cached timed, we download the image again (good), but the cached time is not updated, so we download the image again for every new instance.
Example:
% limactl create --tty=0 test.yaml
...
INFO[0000] Re-downloading digest-less image: last-modified mismatch (cached: "Wed, 09 Oct 2024 00:31:27 GMT", remote: "Thu, 07 Nov 2024 14:31:23 GMT")
Downloading the image (ubuntu-24.04-server-cloudimg-arm64.img)
571.32 MiB / 571.32 MiB [----------------------------------] 100.00% 60.94 MiB/s
...

% limactl create --tty=0 test.yaml --name test2
...
INFO[0000] Re-downloading digest-less image: last-modified mismatch (cached: "Wed, 09 Oct 2024 00:31:27 GMT", remote: "Thu, 07 Nov 2024 14:31:23 GMT")
Downloading the image (ubuntu-24.04-server-cloudimg-arm64.img)
571.32 MiB / 571.32 MiB [----------------------------------] 100.00% 50.72 MiB/s

% limactl create --tty=0 test.yaml --name test3
...
INFO[0000] Re-downloading digest-less image: last-modified mismatch (cached: "Wed, 09 Oct 2024 00:31:27 GMT", remote: "Thu, 07 Nov 2024 14:31:23 GMT")
Downloading the image (ubuntu-24.04-server-cloudimg-arm64.img)
571.32 MiB / 571.32 MiB [----------------------------------] 100.00% 58.23 MiB/s

I think this is caused by the change to fix concurrent downloads - we store the new time once. If the file exists, we don't replace it. We probably need to replace the file when we know that the old time is stale.
Can be reproduced with:
images:
  - location: "https://cloud-images.ubuntu.com/releases/24.04/release/ubuntu-24.04-server-cloudimg-arm64.img"
    arch: "aarch64"
  - location: "https://cloud-images.ubuntu.com/releases/24.04/release/ubuntu-24.04-server-cloudimg-amd64.img"
    arch: "x86_64"
vmType: vz
plain: true

Workaround
Pruning the cache will fix this until the next last-modifed time change on the server:
limactl prune

Previously any cached image would remain until deleted, might need a "imagePullPolicy" some day?
images:
# Try to use release-yyyyMMdd image if available. Note that release-yyyyMMdd will be removed after several months.
- location: "https://cloud-images.ubuntu.com/releases/24.10/release-20241023/ubuntu-24.10-server-cloudimg-amd64.img"
  arch: "x86_64"
  digest: "sha256:ee070d95a2ba5a1500264e75b3e14aa85518220c24d25f1535407c55f0e33e4d"
# Fallback to the latest release image.
# Hint: run `limactl prune` to invalidate the cache
- location: "https://cloud-images.ubuntu.com/releases/24.10/release/ubuntu-24.10-server-cloudimg-amd64.img"
  arch: "x86_64"

But if it does decide to download a new file, then the "timestamp" (file) should be updated as well...

But if it does decide to download a new file, then the "timestamp" (file) should be updated as well...

Indeed, fixed in #2903


How to get SVG path of my logo?

How to get SVG path of my logo? Any tutorial available?

Open the image in gimp... Trace the path of your logo... Save it externally on hard drive... Then you would need to open this file in a text viewer... Here you'd find the path you previously extracted..

http://www.useragentman.com/blog/2013/04/26/how-to-create-svg-paths-easily-using-the-gimp/
This will make it easy to understand :)

Thank you so much


How to make different projects run [deploy] at the same time?

Hi all, I'm new to strider.
I have many projects which are crawler scripts. I want to make all projects run at the same time.
But now one project can only start to run after another project ends.
How to make many projects run at the same time? Or where can I find some clues to realize this target?

You can set CONCURRENT_JOBS to something other than 1. It's documented here: https://github.com/Strider-CD/strider#configuring

Thanks a lot. I @knownasilya . I did add CONCURRENT_JOBS in [.striderrc] file. It did not work at all.

@RephoneYin  you can find here more help http://strider-cd.github.io/guides/configuration.html
I hope this helps.
Could you paste the content of the file? Is the file created into the strider's directory? Version of strider and nodejs?

See the guides for details on striderrc


”Nufăru”, ”Ilganii de Jos”, ”Malcoci”, ”Victoria” are listed in the drop-down menu

Description:
When user writes ”Nufăru”, ”Ilganii de Jos”, ”Malcoci”, ”Victoria” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Nufăru"

Expected results
The location appears in the drop-down menu as "Sat Nufăru, TULCEA (Nufăru)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Ilganii de Jos"

Expected results
The location appears in the drop-down menu as "Sat Ilganii de Jos, TULCEA (Nufăru)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Malcoci"

Expected results
The location appears in the drop-down menu as "Sat Malcoci, TULCEA (Nufăru)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Victoria"

Expected results
The location appears in the drop-down menu as "Sat Victoria, TULCEA (Nufăru)".


Add Whitehall asset endpoint

This endpoint allows us to find a Whitehall asset using its legacy_url_path. We're going to use this in Whitehall to update/delete assets stored in Asset Manager.

Thanks for reviewing, @floehopper. I've addressed your feedback, rebased and force pushed in preparation for merging.


New version release

@AlfredoSequeida There have been a lot of changes since the last release (nearly all within 3 weeks of 0.02), and I was wondering if you could publish a new release to PyPi? It would have to be 1.0.0, as this new release would have passwords, and therefore break backwards compatibility.

Definitely, I'll do it by the end of today. Thank you for letting me know.

Definitely, I'll do it by the end of today. Thank you for letting me know.

Thanks! It might help to build wheels for Mac/windows/Linux also because of the C extensions.

Thanks! It might help to build wheels for Mac/windows/Linux also because of the C extensions.

@Theelgirl After testing the latest git version it looks like decode is not outputting a file for me unless I specify the -o option on Linux. Does the same happen for you?

@Theelgirl After testing the latest git version it looks like decode is not outputting a file for me unless I specify the -o option on Linux. Does the same happen for you?

It works fine for me on Ubuntu 20.04. Do you have the ffmpeg package installed?

It works fine for me on Ubuntu 20.04. Do you have the ffmpeg package installed?

Ohhhhh I misread your question, you're using decode. I'll try that now.

Ohhhhh I misread your question, you're using decode. I'll try that now.

@Theelgirl What! That's really cool, I'm guessing that is encoded into the file itself. I will definitely have to look into the code to check that out. Thank you for your work on that @dobrosketchkun.

@Theelgirl What! That's really cool, I'm guessing that is encoded into the file itself. I will definitely have to look into the code to check that out. Thank you for your work on that @dobrosketchkun.

@Theelgirl I notice that the latest version is 1.0.1 is that the correct one that you want me to publish to PyPi?

@Theelgirl I notice that the latest version is 1.0.1 is that the correct one that you want me to publish to PyPi?

@AlfredoSequeida Yes!

@AlfredoSequeida Yes!

@AlfredoSequeida Can you actually publish it as 1.0.0? I realized that SemVer doesn't allow for skipping publishing of major versions like 1.0.0, so I changed the changelog to reflect that the most recent version is 1.0.0

@AlfredoSequeida Can you actually publish it as 1.0.0? I realized that SemVer doesn't allow for skipping publishing of major versions like 1.0.0, so I changed the changelog to reflect that the most recent version is 1.0.0

Got it, I'll get that done by the end of today.

Got it, I'll get that done by the end of today.

Sounds good, thanks!

Sounds good, thanks!

@Theelgirl version 1.0.0 has been published! Thank you for your work you seem to be doing a great job maintaining the repo. If you need me for anything else feel free to ping me.

@Theelgirl version 1.0.0 has been published! Thank you for your work you seem to be doing a great job maintaining the repo. If you need me for anything else feel free to ping me.


React peer dependencies on react-konva and react-konva-utils

First of all, thank you for such an amazing library!
I'm seeing that this library has a different React peer dependency version than react-konva:
react-konva-utils:
"react": "^17.0.2",
"react-dom": "^17.0.2"

react-konva:
"react": ">=16.8.0",
"react-dom": ">=16.8.0"

Is it an issue for you?


Allow for Backup and Restore of Extension Repos

Currently Working

[x] Backup
[ ] Restore

To-Do:

[ ] Refactor ExtensionRepoCreator to  ExtensionRepoBackupCreator to match the rest?
[ ] Make it toggleable while backing up

Raw Protoc Decode

Shouldn't this be a draft of it is still being worked on?

I thought I opened this as draft my bad


Dropdown Menu-Triggered Modal Input Doesn't Allow Space

Bug Report
User cannot enter space on input that is on a control triggered from the Dropdown.
This bug seems similar to #3768 but my use-case is different (I'm not using the Input directly as a trigger to the Dropdown itself).
This is still an issue in Semantic UI React 0.88.1, so it seems the fix documented in PR #3766 doesn't fix this particular issue.
I have tried to create a new Dropdown that extends the regular Dropdown and overrides the openOnSpace function as described here: https://github.com/Semantic-Org/Semantic-UI-React/issues/2229
That almost works, but the result is that the first time a user enters a 'space' for any given Input, the space key is ignored.  Subsequent spaces work as expected on the Input.
Steps
Create a Dropdown component with a Dropdown.Menu.  Inside of the Dropdown.Menu, place a Modal with a trigger as a Dropdown.Item.  Inside of the Modal is a Form with Form.Input.  The user will not be able to press the Space bar when typing inside of the Input.  Instead, the Dropdown will open and close from behind the modal.
Setting autoFocus on the input almost seems to fix it, but if you have multiple Inputs in the Modal, switching between them causes the spacebar issue to re-appear.  It seems as though the Dropdown steals focus from the modal somehow.
Here is a CodeSandbox with a minimum example showcasing the issue:
https://codesandbox.io/s/semantic-ui-example-wqyf1
Expected Result
User can enter text freely in the Input without triggering the Dropdown.
Actual Result
Dropdown opens and closes when the user presses space inside of the Input
Version
0.88.1
Testcase:
https://codesandbox.io/s/semantic-ui-example-wqyf1

This might be a duplicate of #3689.  I'll give the suggestion in the comments of that issue a shot and report back.

The workaround documented in #3689 works, so I'm closing this as a dupe.


mysqli::real_connect(): (HY000/2006): MySQL server has gone away

Description:

I use mariadb but when login to phpmyadmin get error

Packets out of order. Expected 0 received 1. Packet size=69
mysqli::real_connect(): Error while reading greeting packet. PID=41
mysqli::real_connect(): (HY000/2006): MySQL server has gone away

Expected Behavior:

Logged in to phpmyadmin
Context information:
Output of git rev-parse HEAD
6a92eb0d589c66ef1ccd8945de1d07a6e35861e1

Output of docker version
Docker version 19.03.6, build 369ce74a3c

Output of docker-compose version
docker-compose version 1.25.4, build 8d51620a

System info: Mac, Windows or Linux. Include which disto/version
MX Linux 19.1 x86_64
Kernel: 4.19.0-6-amd64
MARIADB_VERSION=latest (10.4.12-MariaDB-1:10.4.12+maria~bionic)

Steps to reproduce the issue:

change .env PMA_DB_ENGINE=mariadb
docker-compose up -d nginx mariadb phpmyadmin workspace

Stacktrace & Additional info:
$ docker-compose up mariadb
Starting laradock_mariadb_1 ... done
Attaching to laradock_mariadb_1
mariadb_1              | 2020-02-23 09:15:48+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:10.4.12+maria~bionic started.
mariadb_1              | 2020-02-23 09:15:48+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'
mariadb_1              | 2020-02-23 09:15:48+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 1:10.4.12+maria~bionic started.
mariadb_1              | 2020-02-23  9:15:49 0 [Note] mysqld (mysqld 10.4.12-MariaDB-1:10.4.12+maria~bionic) starting as process 1 ...
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Using Linux native AIO
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Mutexes and rw_locks use GCC atomic builtins
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Uses event mutexes
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Compressed tables use zlib 1.2.11
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Number of pools: 1
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Using SSE2 crc32 instructions
mariadb_1              | 2020-02-23  9:15:49 0 [Note] mysqld: O_TMPFILE is not supported on /tmp (disabling future attempts)
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Initializing buffer pool, total size = 256M, instances = 1, chunk size = 128M
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Completed initialization of buffer pool
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: 128 out of 128 rollback segments are active.
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Creating shared tablespace for temporary tables
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Setting file './ibtmp1' size to 12 MB. Physically writing the file full; Please wait ...
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: File './ibtmp1' size is now 12 MB.
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Waiting for purge to start
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: 10.4.12 started; log sequence number 62494; transaction id 21
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Loading buffer pool(s) from /var/lib/mysql/ib_buffer_pool
mariadb_1              | 2020-02-23  9:15:49 0 [Note] Plugin 'FEEDBACK' is disabled.
mariadb_1              | 2020-02-23  9:15:49 0 [Note] Server socket created on IP: '::'.
mariadb_1              | 2020-02-23  9:15:49 0 [Warning] 'user' entry 'root@015fbb62d38b' ignored in --skip-name-resolve mode.
mariadb_1              | 2020-02-23  9:15:49 0 [Warning] 'user' entry '@015fbb62d38b' ignored in --skip-name-resolve mode.
mariadb_1              | 2020-02-23  9:15:49 0 [Warning] 'proxies_priv' entry '@% root@015fbb62d38b' ignored in --skip-name-resolve mode.
mariadb_1              | 2020-02-23  9:15:49 0 [Note] InnoDB: Buffer pool(s) load completed at 200223  9:15:49
mariadb_1              | 2020-02-23  9:15:49 0 [Note] Reading of all Master_info entries succeeded
mariadb_1              | 2020-02-23  9:15:49 0 [Note] Added new Master_info '' to hash table
mariadb_1              | 2020-02-23  9:15:49 0 [Note] mysqld: ready for connections.
mariadb_1              | Version: '10.4.12-MariaDB-1:10.4.12+maria~bionic'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306  mariadb.org binary distribution

how long that stale period take time.


severity type missmatch

What version of textlint are you using?

14.0.3
What file type (Markdown, plain text, etc.) are you using?
html
What did you do? Please include the actual source code causing the issue.
textlintKernel's  lintText option type missmatch
following code's Type is valid but runtime error
Error: Please set following value to severity: "rule-key": {     "severity": "<warning|error>" }
const kernel = new TextlintKernel();
kernel.lintText("text", {
  rules: [
    {
      ruleId: "sample",
      rule: ruleObject,
      options: { severity: 2 },
    },
  ],
  ext: ".html",
  plugins: [{ pluginId: "html", plugin: htmlPlugin }],
});

following code's Type is invalid but no error
const kernel = new TextlintKernel();
kernel.lintText("text", {
  rules: [
    {
      ruleId: "sample",
      rule: ruleObject,
      options: { severity: "error" },
    },
  ],
  ext: ".html",
  plugins: [{ pluginId: "html", plugin: htmlPlugin }],
});

rules require SeverityLevel 0|1|2
but getSeverity require "none"|"info"|"error"|"warn"
What did you expect to happen?
What actually happened? Please include the actual, raw output from textlint.

Error: Please set following value to severity:
"rule-key": {
    "severity": "<warning|error>"
}

I think the type information is wrong because it should be the same as the option of .textlinrc.json.
Next, we should fix the types so that we can compile the code.
const kernel = new TextlintKernel();
kernel.lintText("text", {
  rules: [
    {
      ruleId: "sample",
      rule: ruleObject,
      options: { severity: "error" },
    },
  ],
  ext: ".html",
  plugins: [{ pluginId: "html", plugin: htmlPlugin }],
});

Fixed in https://github.com/textlint/textlint/releases/tag/v14.0.4
Thanks!


Is root property

There's more places where IsRoot can be used (do a search for multitenancyconstants.root.id)...
I think IsRootTenant would be a better name actually.
And if we were to keep the HasRootEmailAddress, I would rename it to IsRootAdmin.

Also: with a new PR, I meant one without all the intermediary commits... Can you maybe squash your commits?
(Or otherwise @iammukeshm can also do that when accepting the PR apparently.)

functionality not considered useful.


voice ID enrollment

We are evaluating Voice ID preview to see how it can be implemented. The contact flows are working fine. It's able to detect that a call is not enrolled. However, In the Agent UI, when I call enrollSpeakerVoiceId() method, it returns "enrollSpeaker failed". I make sure there's at least 30 seconds of audio before making the call as well. Here's the sample code:

voiceConnection = new connect.VoiceConnection(contactId, connectionId);
voiceConnection.enrollSpeakerInVoiceId()
.then((response) => {
console.log(response);
})
.catch((error) => {
console.log(error);
});

I'm using the latest release version of amazon-connect-streams. I'm setting the correct contactId and connectionId when the call is connected. Anything else I might be missing?

As far as I've tried, I'm getting a 403 error when call VoiceID APIs.
at ConnectSharedWorker(https://foobar.my.connect.aws/connect/ccp-naws/static/shared-worker.0a85fe34-b3ddf7d4.js)
I could not find a security profile or a screen to assign VoiceID permissions to the console.
Response {type: "basic", url: "https://foobar.my.connect.aws/agent-app/api", redirected: false, status: 403, ok: false, …}
body: (...)
bodyUsed: false
headers: Headers
__proto__: Headers
ok: false
redirected: false
status: 403
statusText: ""
type: "basic"
url: "https://foobar.my.connect.aws/agent-app/api"
__proto__: Response

@intptr-t
I don't know what you did there how did you manage to get a 403 response?. can you share your javascript codes? I'm always getting enrollSpeaker failed

Here is the code I am using for the evaluation.
evaluation code
_onclick will be called when the button is pressed after onConnected.
function _onclick(_ev, contact) {
  const connect = window.connect;
  const logger = connect.getLog();
  if (!contact) {
    return;
  }

   if(contact.getType() === connect.ContactType.VOICE) {
    const connections = contact.getConnections();
    for (const baseConnection of connections) {
      /** @type {connect.VoiceConnection} */
      const voiceConnection = (baseConnection);
      voiceConnection.enrollSpeakerInVoiceId()
        .then((response) => {
          logger.info(`enrollSpeakerInVoiceId success`).withObject(response);
        })
        .catch((err) => {
          logger.error(`enrollSpeakerInVoiceId failed`).withException(err);
        });
    }
  }
}

Points to check for 403 error occurrence

Enter chrome://inspect/#workers in the URL bar of Google Chrome where CCP is running.
In the Shared Worker menu, there is a ConnectSharedWorker, click on inspect.

In the current minified version of CCP, I figured out that the API for VoiceID is called at line 17995.
So, I set a breakpoint at the point of the failure callback (line 18001) to check.

Then I ran To get started in the approval email.

Have you take look at this page https://aws.amazon.com/connect/voice-id/ and sign up for preview?

yes we already signed up for preview

Hi guys, were you able to solve this issue. I pretty much got the same issue as well :(

Hi, @renjith171  no were are in talk with the AWS team who handle this Voice ID and we have a session Monday next week.

Great thanks for your prompt response !! please do let me know how it goes :)

@renjith171  sure will update you once we solve it. been working for this since Febuary

@renjith171  @intptr-t  we manage to fix the issue they need to whitelist your connect instance internally that's why we are getting 403  unauthorized maybe to try to email the person in charge thank you<EMAIL_ADDRESS>

Related issue: We are getting log full of errors..for certain users... get_speaker_id_failed.
We don't have voiceID turned on in this instance and we don't see it enabled in our flows(it happens in a simple outbound call) nor in the Salesforce CTI flows. Any thoughts?


Erubi and erubi_rails benchmarks

I've added two Erubi benchmarks. The one called "erubi" uses an Erb template from the "gem server" command with real gemspec data from my local Ruby install.
The erubi_rails benchmark uses an Erb template from Discourse's topics/show view, stubbed with fake data. It's rendered via a tiny Rails test app.

It depends on Rails, much as Railsbench does. It doesn't actually run Rails' HTTP handling, though - we're rendering a single template outside the normal HTTP loop. It doesn't even run a controller action, nor hook up its only controller to any routes.
It has a lot of files, of course, since it's a Rails app. But the amount of code that isn't from "rails new" is very small.
That specific Discourse template won't work well outside Rails because it uses Rails-specific template functionality like content_for. I expect I could find some smaller Discourse template that rendered correctly outside Rails.

Ok. We can merge it as-is, if you feel comfortable maintaining it.

Definitely. This is much easier than Railsbench :-)


Plans on improving poor syntax highlighting?

I've read some pull request why syntax highlighting is like that, but can't you just take reason grammar or something?
Just look at these two screenshots:
Rescript:

Reason:

See? It feels like half of code is just uncolored, variable names, record type fields etc.
Is it that hard to take reason grammar and tweak it for rescript slightly different syntax?
I would very like to stick to rescript. But the way things are now makes me feel like I should wait a year or two, not to demoralize.

Hello. I guess you've seen this. Additionally, the Reason grammar isn't the same, and is pretty unmaintainable and has some pathological regex problems.
I'll close this as there are other more specific issues on this subject we can consider.

I've saw recommendation. And? Dark+ theme, one dark, etc it's all the same! JSX uncolored, types uncolored, variables uncolored, record field names uncolored, nearly everything uncolored except keywords and some other stuff.
Please just answer a question do you plan to improve syntax highlighting?
If not I'll try to get used to work without syntax highlighting at all. ascetically.
Just answer please.

We plan to improve it but only if it doesn't affect correctness.

Thank you


Saving PDF with image fails

Create a ticket with an image, it will fail on the following line:
var datauri = ('' + type).substr(0, 6) === 'dataur'
                    ? 'data:application/pdf;base64,' + btoa(buildDocument()) : 0;

With the error:
Error: Error in function Error (native): Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.
    at Console.$window.console.error (http://localhost:3333/App/Business/AngularErrorHandler.js:43:23)
    at Object.__safeCallWrapper [as output] (http://localhost:3333/Scripts/jsPDF/jspdf.js:471:44)

Can you try get an example – http://jsbin.com/rilace/edit?html,js,output

Yes, here it is:
http://jsbin.com/genutubuza/1/edit?html,js,output

Strangely, that works for me on mobile Safari, but not on desktop

Odd thing is that .save() works, but .output() doesn't

Thanks for that. Yeah that is odd. git-bisect time!

I'm seeing the same thing on Windows with latest Chrome and Firefox.  Any word on a fix?

Same problem here. Only fails on png's for me.

I've reverted to 1.0.272 until this is addressed.

Same problem too. Fail with canvas having a drawn image then masked by a rounded rectangle.

Some progress with this issue?
If you replaced in the jspdf.min.js file:
btoa(vt())
to:
btoa(unescape(encodeURIComponent(vt())))
The file is generated correctly, but the images are not seen.

trying to render charts and pies here, same problem.
I could've live with save() if only png was better than jpeg, in the rendered pdf document

Same issue here.

I have images (logos) saved on an external domain.  Some are png, some are jpeg.  To work around this issue, I wrote the following function.  It takes an image url and converts it to jpeg data uri.
    getDataUri(imgUrl, function(dataUri) {
        logo = dataUri;
        console.log("logo=" + logo);
    });

    getDataUri(url, cb)
     {
            var image = new Image();
            image.setAttribute('crossOrigin', 'anonymous'); //getting images from external domain

            image.onload = function () {
                var canvas = document.createElement('canvas');
                canvas.width = this.naturalWidth;
                canvas.height = this.naturalHeight;

                //next three lines for white background in case png has a transparent background
                var ctx = canvas.getContext('2d');
                ctx.fillStyle = '#fff';  /// set white fill style
                ctx.fillRect(0, 0, canvas.width, canvas.height);

                canvas.getContext('2d').drawImage(this, 0, 0);

                cb(canvas.toDataURL('image/jpeg'));
            };

            image.src = url;
       }

@MrRio any update on this?  I'm getting similar errors.  Doesn't occur in 1.0.272 but does in 1.2.61.

This is now fixed in https://github.com/MrRio/jsPDF/pull/852


Fixed mispell in doc Actvity -> Activity

Fixed misspell in react native doc

By analyzing the blame information on this pull request, we identified @satya164 and @alvinthen to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Please sign the CLA so we can accept your PR.

Done
On Wed, Jul 13, 2016 at 3:25 PM, Satyajit Sahoo<EMAIL_ADDRESS>wrote:

Please sign the CLA so we can accept your PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/8736#issuecomment-232339170,
or mute the thread
https://github.com/notifications/unsubscribe/ACBjegRrKRZcWBqO34irLcjtZhqwAiJqks5qVNlLgaJpZM4JLQtp
.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


TypeScript Improvements

Recently started using the library in a TypeScript project and noticed a few things that could be improved. Thanks for a great library!
Here are some examples of the improvements seen from VS Code:

I haven't had time to type up the response for validateReceiptAndroid yet, but hopefully there will be another pull request soon™ 🚀

I removed RNVersion from here as well, my reasoning is that passing in undefined will actually work since undefined < 54 evaluates to false. Anyhow, when we merge #238 that parameter will be gone forever 🎉

@cometkim @LinusU  Thank for your work!

Hey @dooboolab and @LinusU, I was noticed about "Mapped types on tuples" support in TypeScript 3.1
It looks like we can make this declaration be exact and short, but should drop support below versions of TS.
export function getProducts<A extends string, B extends string, C extends string, D extends string, E extends string, F extends string>(skus: [A, B, C, D, E, F]): Promise<[Product<A>, Product<B>, Product<C>, Product<D>, Product<E>, Product<F>]>;
export function getProducts<A extends string, B extends string, C extends string, D extends string, E extends string>(skus: [A, B, C, D, E]): Promise<[Product<A>, Product<B>, Product<C>, Product<D>, Product<E>]>;
export function getProducts<A extends string, B extends string, C extends string, D extends string>(skus: [A, B, C, D]): Promise<[Product<A>, Product<B>, Product<C>, Product<D>]>;
export function getProducts<A extends string, B extends string, C extends string>(skus: [A, B, C]): Promise<[Product<A>, Product<B>, Product<C>]>;
export function getProducts<A extends string, B extends string>(skus: [A, B]): Promise<[Product<A>, Product<B>]>;
export function getProducts<A extends string>(skus: [A]): Promise<[Product<A>]>;
export function getProducts(skus: string[]): Promise<Product<string>[]>;

How do you think about?

[...] but should drop support below versions of TS.

works for me 👍

@cometkim @LinusU Actually, I don't know how to manage this one since it isn't downward compatible. Would this be ok to just drop the lower version support?

@dooboolab It's not that important while it is not a dependency or peer dependency.

@LinusU I just tried to use tuple mapping, but keyof does not support explicit inference of arrays or tuple entries.. it looks always string | number | symbol and the number is incompatible with Product<ID extends string>.
Closed this topic..


Remove DeviceCheck and SafetyNet

Fixes GH-93

/lgtm
/approve

@mikehelmick just removed platform. Please re-review.

@mikehelmick just removed platform. Please re-review.

thanks!
/lgtm
/approve

Hi, I am just wondering why you decided to drop these to resolve GH-93, instead of fixing the issue? I was planning some changes in this area that I wanted to suggest. Surely SafetyNet and DeviceCheck still add valuable protections here?

We're moving verification to third-party PHA servers. PHAs are free to use DC/SN to verify devices, but the server will soon move to using the verificationPayload. See https://github.com/google/exposure-notifications-server/blob/master/docs/design/verification_protocol.md and #508

OK, thanks. That makes a lot of sense. As a follow up question: is there a plan to open source a reference PHA implementation?

I can't discuss future plans, but that's definitely a possibility.

Thanks again, my last comment on this point. For my day job, I help to develop Approov(approov.io) a service for verifying communications are coming from authentic untampered apps (includes DC and SN options as well as other checks) with a simple flow. My changes were going to offer a generic JWT verification alternative alongside the DC/SN flow to support 3rd party app-verification flows like ours. If you do release a reference PHA implementation in the future, would you be open to including changes to this area?

@mikehelmick is owning the PHA verification, so I'll let him comment.

The plan is to open source a reference PHA implementation.
At this time, I can't comment on what technologies we may use / not use for that service. It will likely be up to individual operators (governments / public health authorities) when the time comes.
Another motivation for removing device check / safetynet is to avoid communication with Google and Apple servers for purposes of exposure notifications. It eliminates the perception that Google and or Apple could be identifying devices that are reporting infections.


LOL LMAO ROFL XD XD XP XP XP

XP

Can you add doc for these functions ? (so we don't have to add lot and lot of docs later)

Oh well, I kind of failed my merge, but all the commits are in master now.

@rom1504, we should really start thinking about a way to store all of this stuff like a function that stores key-values? It would be good to start saving info on players.

@mhsjlw yes, but we probably want to start by using the vanilla storage format

Do we really need to do that? I think it would make more sense maybe just making a wrapper around an sqlite3 server that starts when flying-squid does, then just make methods for storing data in the database. Then, if we wanted to we could make a converter that converts the database to world format and so on so forth. Also, we could add abilities to add different databases other than sqlite3 like PostgreSQL and MongoDB and MySQL

@mhsjlw I think we should be able to use different backend, but the default should be vanilla.
But if you want to start working on a non-vanilla backend, feel free to ;)

also see https://github.com/PrismarineJS/prismarine-world/issues/11


Un-revert FS changes.

FTR, #9170 introduced some failures in the functional tests on OSX and Windows.  I'm going to temporarily disable those tests on the respective platforms.


Not working in CD builds

Describe the bug
As per the blog post I enabled the plugin for one of my sites and change the netlify.toml to run for desktop.
The result CD build showed the plugin was enabled but it's post build step is 9ms and there are no results in the feed and I cannot find any in the control panel (but I've not idea where to look.
It works locally - took some
To Reproduce

install plugin
configure toml locally
push changes

Expected behavior
A lighthous score in the build output and somewhere in the control panel
Screenshots
netlify.toml
[build]
# with debugging: command = "git submodule update --init --remote && bundle exec jekyll build --verbose --trace --config '_config.yml,_config_staging.yml'"
command = "git submodule update --init --remote && npm install && bundle exec jekyll build --trace --config '_config.yml,_config_staging.yml'"
publish = "_site"

[build.environment]
RUBY_VERSION = "2.6.2"

[[redirects]]
from = "/wai-website"
to = "/"
status = 404

[dev]
command = "bundle exec jekyll serve -w --livereload --config _config.yml,_config_staging.yml"

[functions]
directory = "_functions"
node_bundler = "esbuild"

[[plugins]]
package = "@netlify/plugin-functions-install-core"

[[plugins]]
# See https://github.com/netlify/netlify-plugin-lighthouse#readme
package = "@netlify/plugin-lighthouse"
[plugins.inputs.settings]
preset = "desktop" # default is mobile
locale = "en"
# to audit an HTML file other than index.html in a sub path of the build directory
#[[plugins.inputs.audits]]
#path = "pages/contact.html"

Additional context
partial build Log
6:08:25 PM: ❯ Loading plugins
6:08:25 PM:    -<EMAIL_ADDRESS>from netlify.toml and package.json
6:08:27 PM:
6:08:27 PM: ────────────────────────────────────────────────────────────────
6:08:27 PM:   1. @netlify/plugin-functions-install-core (onPreBuild event)
6:08:27 PM: ────────────────────────────────────────────────────────────────
6:08:27 PM:
6:08:27 PM:
6:08:27 PM: (@netlify/plugin-functions-install-core onPreBuild completed in 10ms)

────────────────────────────────────────────────────────────────
6:10:03 PM:   4. @netlify/plugin-lighthouse (onPostBuild event)
6:10:03 PM: ────────────────────────────────────────────────────────────────
6:10:03 PM:
6:10:03 PM:
6:10:03 PM: (@netlify/plugin-lighthouse onPostBuild completed in 9ms)
6:10:03 PM:
6:10:03 PM: ────────────────────────────────────────────────────────────────
6:10:03 PM:   5. Deploy site
6:10:03 PM: ────────────────────────────────────────────────────────────────
6:10:03 PM:

Does this plugin exist, I'm not seeing it in npm?
[[plugins]]
package = "@netlify/plugin-functions-install-core"

Few things to help look:

What node version are you using for the site? any defined in the environment variables or package.json?
are you using a specific build image version. This should be visible in site settings. Or maybe share the siteID or link to site? Thanks

@kevinsamoei here's the repo = https://github.com/w3c/wai-website

Thanks @SteveALee we think this is related to the node version being used to build the site. We are working to make this better, however in the meantime could you test by setting NODE_VERSION env var in your toml or site settings to 16 and retrigger the build?
This will help us confirm if this is related to the node version.

hey @kevinsamoei  I set it in the web app settings and yes it works! eg
4:17:07 PM: ────────────────────────────────────────────────────────────────
4:17:07 PM:   4. @netlify/plugin-lighthouse (onPostBuild event)
4:17:07 PM: ────────────────────────────────────────────────────────────────
4:17:07 PM:
4:17:07 PM: Serving and scanning site from directory _site
4:17:07 PM: Mon, 17 Oct 2022 15:17:07 GMT LH:ChromeLauncher Waiting for browser.
4:17:07 PM: Mon, 17 Oct 2022 15:17:07 GMT LH:ChromeLauncher Waiting for browser...
4:17:08 PM: Mon, 17 Oct 2022 15:17:08 GMT LH:ChromeLauncher Waiting for browser.....
4:17:08 PM: Mon, 17 Oct 2022 15:17:08 GMT LH:ChromeLauncher Waiting for browser.....✓

{
4:17:22 PM:   results: [
4:17:22 PM:     { title: 'Performance', score: 0.99, id: 'performance' },
4:17:22 PM:     { title: 'Accessibility', score: 1, id: 'accessibility' },
4:17:22 PM:     { title: 'Best Practices', score: 0.83, id: 'best-practices' },
4:17:22 PM:     { title: 'SEO', score: 1, id: 'seo' },
4:17:22 PM:     { title: 'PWA', score: 0.22, id: 'pwa' }
4:17:22 PM:   ]
4:17:22 PM: }
4:17:22 PM: Report collected: audited_uri: '_site/', html_report_size:<PHONE_NUMBER>625 KiB
4:17:22 PM:
4:17:22 PM: (@netlify/plugin-lighthouse onPostBuild completed in 15.1s)

So how do I get to see the pretty graphical output in the the web app?
FYI My local node version is v16.14.2 so it seems your hunch is correct  Though the [build image docs[(https://github.com/netlify/build-image/blob/focal/included_software.md) state node 16 for Focal

Nice! We know that the lighthouse version we have for the plugin only works with node 14 and above. We think there is something going on with the build settings for build plugins which we will dig into
When you go the the deploys page of your website you should now see the graphical output and can also see the full lighthouse report when you open the deploy
I can see them in https://app.netlify.com/sites/wai-website/deploys/634d7078f31dcd4d2de7965c 🎉

I ran into this node issue on an older site this weekend. The default node version doesn't get updated for existing sites, so it needs to be set manually for now.

@kevinsamoei ahah, yes I see. Neat thanks. At least we get 1 for a11y lol.
@brittneypostma oh, I can sort of see that. Thanks.


Add score calculation

Describe Your Changes
Add post route to allow us to add scores for the correct score at the end of a round.
Non-Obvious Technical Information
Checklist Before Requesting a Review

[x] The code runs successfully.

 % curl -X PUT http://localhost:8000/games/1/player/4/update_score
 % curl -X GET http://localhost:8000/games/current_score/4
{"created_at":"2023-11-25T15:31:26.223195+00:00","id":4,"created_by":1,"ready":false,"correct_answers":2,"user_id":5,"session_id":1,"points":200}%

% curl -X PUT http://localhost:8000/games/1/player/4/update_score
% curl -X GET http://localhost:8000/games/current_score/4
{"created_at":"2023-11-25T15:31:26.223195+00:00","id":4,"created_by":1,"ready":false,"correct_answers":3,"user_id":5,"session_id":1,"points":300}%

The route is unprotected in that calling the PUT call twice will add the points twice.  I've created a future issue to address this.

@michplunkett I've addressed the small concerns -- the larger one we can talk about tomorrow.


[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 2)

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG
DocuTune v<IP_ADDRESS>
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db
#docutune

#docutune-review

LGTM


Update bottom_sheet.dart

Add support of backgroundColor、barrierDismissible、enabledrag、evalution  for showModalBottomSheet and BottomSheet.
Now you can easily use it.

@While1true Any chance you can sign the CLA as described above? We would love to consider your contribution but can't do so before the CLA is signed. Thanks!

/cc @dnfield

I think this is probably an improvement over what we have right now, but it would still leave some problems.  In particular, a user would not be able to scroll the content up to the top and continue scrolling with a single gesture, and if you put scrolling content (e.g. a ListView or SingleChildScrollView) in the BottomSheet the drag behavior won't work.
@While1true - do you have any thoughts on that?  It would be helpful to see some sample code for how you want to use this.  It would also be good to see tests for this, but I think a lot of that work would end up being undone by a planned BottomSheet refactor anyway.

Since the CLA wasn't signed, we can't take this patch. @While1true Please don't hesitate to submit a new PR if you have the opportunity to sign the CLA. Thanks!