[Bug]: Uploads added in limited connection mode did not start when entering normal mode

Summary
I added 10 images today in the limited connection mode.
These images didn't immediately upload as expected, but appeared in the list.
The upload bar was animating though, rather than displaying the text "queued" anywhere.
When setting to normal connection mode nothing happened, no images started uploading.
Instead I had to hit pause on each of the uploads, and then hit the play button again, where it would then either upload or show as queued.
Steps to reproduce
Set limited connection mode
Add images
Set normal connection mode
Expected behaviour
Images added in limited connection mode would start uploading
Actual behaviour
No images started uploading
Device name
Motorola G9 plus
Android version
Android 11
Commons app version
4.0.3~23c474b06
Device logs
No response
Screen-shots
No response
Would you like to work on the issue?
No response

I can confirm that with Commons app 4.0.3~cf35307d9 (latest f-droid) on Android 10 (EMUI 12, Huawei P30 Pro).
Here is a video example:
https://github.com/commons-app/apps-android-commons/assets/156656/3361bc1b-7ea1-4f7d-bc75-9734ef590d64

I can confirm that this bug is still present in latest f-droid release (4.1.0~1649d1e2c) on Android 10 (EMUI 12), Huawei P30 Pro.

I can confirm that "Uploads added in limited connection mode did not start when entering normal mode" bug is still present in latest f-droid release (5.0.1~af028cbdd) on Android 14 (OneUI 6.1), Samsung Galaxy S23+
I need to manually press pause and then play button for each and every picture that was taken in "Limited connection mode" in order to get them to upload. That is not only annoying, but also sometimes results in forgetting to pause/resume some or all of them, so they never get uploaded :cry:
Video:
https://github.com/commons-app/apps-android-commons/assets/156656/82948b2b-38c0-4cfe-9adc-24c028867395
and associated log:
CommonsAppLogs-5038.log
Does that help? Has anyone got an idea how to fix it?
I assume in worst case, on exiting "Limited connection mode" we could have app automatically simulate clicking pause and then resume on every not-yet-uploaded picture?


Composer

Please, consider delivering your package via composer! In this way it would be easier to keep track of changes and updates!
Thank you!

Definitely would like to add this. Will look into it.


chore: update repository template to 4e15ccda

Updated repository templates to https://github.com/ory/meta/commit/4e15ccda08d71fe6a955a2e0ddd629c5393fac05.

Coverage remained the same at 43.429% when pulling 2f88e510e2d7b9f66e349887a97dc3021cb23c86 on meta-11-16-20-16-31-28 into 6ca73fce478c23047feb6c63b377512a3d1bb9d4 on master.


feat: Wiring announcements block on Homepage

Summary of Changes
Adds the announcements block into the homepage
Wires the cards to the announcements list
Updates maximum container to match designs

Tests
Updated tests
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

Codecov Report

Merging #551 into feature/announcements will increase coverage by 2.68%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##           feature/announcements     #551      +/-   ##
=========================================================
+ Coverage                  81.77%   84.45%   +2.68%
=========================================================
  Files                        234      192      -42
  Lines                       5843     4015    -1828
  Branches                     703      524     -179
=========================================================
- Hits                        4778     3391    -1387
+ Misses                       995      604     -391
+ Partials                      70       20      -50

Impacted Files
Coverage Δ

...tatic/js/components/common/Announcements/index.tsx
80.00% <ø> (ø)

...pplication/static/js/components/HomePage/index.tsx
94.73% <100.00%> (+0.29%)
:arrow_up:

...s/common/Announcements/AnnouncementsList/index.tsx
100.00% <100.00%> (ø)

...ication/static/js/components/common/Card/index.tsx
95.23% <100.00%> (+0.23%)
:arrow_up:

amundsen_application/base/base_preview_client.py

amundsen_application/api/utils/metadata_utils.py

amundsen_application/api/mail/v0.py

...undsen_application/api/utils/notification_utils.py

amundsen_application/api/v0.py

...n_application/base/examples/example_mail_client.py

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a57cb1...b90ca88. Read the comment docs.


Resolve #4598 documentation review comments

This just does small and quick resolutions to the comments made in #4598 . I left out the ones which need furthermore  consideration from the author of the initial PR.

Automated message from Dropbox CLA bot
@CestDiego, it looks like you've already signed the Dropbox CLA. Thanks!

I resolved the comment made on this PR. Ready to re-review or merge

Great, merged, thanks @CestDiego!


PiT 23.3: cannot find reference documentation about the NonNullApi

go to https://hilla.dev/docs/ and search for NonNullApi

https://hilla.dev/docs/advanced/endpoints-generator/#type-nullability
Also, nullability criteria should be reviewed for multi-module generator. For example, custom annotations must now be declared in pom.xml, they are not picked up automatically just by having nonnull in their name.

ping @cromoteca @platosha


Cannot leave fullscreen on windows

When calling windowManager.setFullScreen(false); the app stays in fullcreen.

This problem is fixed in #24, please update to 0.1.2.


Page sort order with sort_by = "order"

Same section as in #94 with following order entry in the front matter:
_index.md:sort_by = "order"
setup.md:order = 1
serve.md:order = 2
generate.md:order = 3
configuration.md:order = 4

section.pages returns the pages in order 4, 3, 2, 1, but page.previous of page 2 is 1 and page.next of page 2 is 3. Looking at the commend of the order field I read:

Integer to use to order content. Lowest is at the bottom, highest first

I would expect that lowest is first and highest is last, which matches previous and next. For now I have to filter the pages with reverse to emit a section toc.

You want sorting by weight, i've added it in https://github.com/Keats/gutenberg/pull/88/commits/c7bea0bc54629d45127d253e0b8fb2781c36b694 and it will be there in 0.0.8

Great, thanks!


protocol: fix packet validation

Currently, we will try the to process the packet on invalid report IDs.
Signed-off-by: Filipe Laíns<EMAIL_ADDRESS>

Aghh, this is still broken, I forgot the else if.


Enable AVX-enabled builds

Comment:
MuJoCo PyPI builds use AVX, and so it may be confusing for users not to get have these optimization in the conda package. Thanks to https://github.com/conda-forge/conda-forge.github.io/pull/2091, we should be able to have AVX-enabled packages for MuJoCo.

Once https://github.com/conda-forge/mujoco-feedstock/pull/41, we can easily use the mujoco-testspeed to roughly compare the different package variants performances.

Just to give an idea why this is worth, my quick&dirty benchmark is the following, run testspeed (mujoco-testspeed in conda packages) with the model https://github.com/google-deepmind/mujoco/blob/3.1.3/model/humanoid/humanoid.xml , i.e. mujoco-testspeed ./humanoid.xml 100000 . The current results are (this is simulation time, so less is better):

~1.81 for the upstream build
~2.45 for the conda-forge build


Doc updates for HIS Designer for Logic Apps and other tools

Also updates to remove some unsupported Link Services from the HIS docs.
#assign:ecfan

Resolves AB#171690
Resolves AB#25540409


Need of Cube traineddata files for other languages like por, spa, etc.,

Hi ,
Anyone please help me in finding / Creating lang.cube.* files for all the other languages in tessdata folder. like eng language has. Please help me out in training data for cube. Or anyone already have those cube files please share with me.
Thanks and Regards,
Merlin

Please use tesseract user forum for asking support.

can i know the forum insite details

See https://github.com/tesseract-ocr/tesseract/wiki#support.


Access properties without opening modal?

For a feature I'm trying to create I'd like to access some elements of the Project Comments. They are only accessible if I click and make the project comments visible via the modal. Is there a way to click it and prevent it from being visible so I can access the properties?

Hi!  You could probably use addStyle to hide the modal from the user
temporarily.  This is kinda tricky, though, because the code needs to be
very sure to remove the CSS once the property retrieval is done.
Another issue is that if this needs to be open for any longer than an
instant, it could interfere with user interaction
On Wed, Jan 19, 2022 at 5:21 AM Maarten den Braber @.***>
wrote:

For a feature I'm trying to create I'd like to access some elements of the
Project Comments. They are only accessible if I click and make the project
comments visible via the modal. Is there a way to click it and prevent it
from being visible so I can access the properties?
—
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/197, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKWSUIUACOZBA372G5DUW2UFRANCNFSM5MJZEDVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'll investigate, but doesn't sound indeed like a tricky option. I'll let you know if I had any success.

Closing as wontfix


Bump ledger and network dependencies

The changes here come from a few areas:

Refactoring of the ledger code to move the protocol concerns into their own package.
Some additional errors for Plutus scripts (not yet enabled).
Additional ledger events.
Remove ToJSON instances which have now migrated to the ledger codebase.
Change TxIx to be a Word16, which is its new bound in Shelley+ eras.

This also incorporates @bolt12's changes from #3561.

With the latest update, I can now sync past that point:
[lorien:cardano.node.ChainDB:Info:5] [2022-02-16 15:48:16.03 UTC] Replayed block: slot 43523999 out of 50390030. Progress: 86.37%
[lorien:cardano.node.ChainDB:Info:5] [2022-02-16 15:48:24.70 UTC] Replayed block: slot 43545598 out of 50390030. Progress: 86.42%

bors merge

bors r+

bors r+

bors r+

bors r-

bors r+


Maven 3.6.2 build fails

It looks like Maven 3.6.2 is not compatible with polyglot-maven. see: https://github.com/takari/polyglot-maven/issues/200
I get almost immediate failure with any mvn command with lots of errors similar to:

[FATAL] Non-readable POM (…)/archi/com.archimatetool.canvas/.polyglot.build.properties: input contained no data @

I doubt there's anything to be done on Archi side. Creating issue so other people could find it

OK, thanks for the heads up. We're using Travis CI for unit tests so let's hope that they don't update to 3.6.2. Do you know if Apache are aware of this?

They are: https://issues.apache.org/jira/projects/MNG/issues/MNG-6765

Thanks. So I wonder who need to fix it? Maven or polyglot?

It's on polyglot's table until they can prove it's maven's issue :)

Looks like Apache is fixing this in Maven 3.6.3.
https://github.com/takari/polyglot-maven/issues/200#issuecomment-547086494

I've tested with Maven 3.6.3 and it all seems to work now:
https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/
3.6.1 has a bug that leads to the "Missing requirement" error
3.6.2 fixed the bug in 3.6.1 but broke polyglot support
So, use either 3.6.0 or 3.6.3.
Unfortunately both Travis CI and GitHub CI Actions are using Maven 3.6.2. With Travis CI I am able to download and use 3.6.0 but I can't see how to do this with GitHub CI Actions.


Change to check boxes in model covariance matrix

Should automatically check the corresponding symmetry

After cc875d, the values in the matrix are changed to "X". We want to be able to use checkboxes, but this is not implemented in dash yet. Possible workarounds could be to change cell if currently being selected, but this comes with flaws as well.

I think it is close enough now.


Any tool to explore pdf like F12 in chrome?

Hi @playgithub,
This would definitely be a nice tool to have. It would make understanding the pdf data a lot easier. I don't know of its existence so if you find a tool like this, let us know.
Best spot to do so is the gitter.


Update all translations of README.md

NOTE: This repository is no longer supported or updated by @gomzyakov . If you wish to continue to develop this code yourself, we recommend you fork it.

NOTE: This repository is no longer supported or updated by @gomzyakov . If you wish to continue to develop this code yourself, we recommend you fork it.

hi are you talking about the attached translations ??

I can take it up if you want ??

@ElephantRohck Hi!
Yes, these are the files that are meant. If you have time and opportunity, you can bring the translations into line with https://github.com/good-first-issues/good-first-issues.github.io/blob/main/README.md

Hi @gomzyakov,
Please review.

@gomzyakov please review and let me know if it's fine or not

@ElephantRohck
This does not mean updating the titles of links to English, but updating the files with translations themselves, updating them.


Missing file utils.utils

Hello, this code reports an error: from utils.utils import idx2onehot. Is it convenient to provide the utils.utils file? Thank you very much.

Thank you for pointing out the missing file. We've now uploaded it.


Jira Service Management Alert Plugin

Repository URL
https://github.com/atlassian-labs/jsm-integration-jenkins-plugin
New Repository Name
jsm-alert-plugin
Description
We are introducing a new alert management plugin for Jira Service Management. Jira Service Management is built for IT teams and service desks, providing an efficient tool to receive, track, manage, and resolve requests from your team's customers. It is part of the Jira product family developed by Atlassian.
Now we are adding Opsgenie alert and on-call features into Jira Service Management. Opsgenie, also developed by Atlassian, is an advanced incident, alert, and on-call management platform. It is designed to alert the right people at the right time with powerful alerting, on-call management, and escalation policies.
We already have the Opsgenie plugin to integrate with Jenkins: https://github.com/jenkinsci/opsgenie-plugin
But we also need a Jira Service Management alert plugin since both products will have their own users. the
GitHub users to have commit permission
@akyuznurettin
Jenkins project users to have release permission
jsm_alert_plugin
Issue tracker
GitHub issues

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.
Commands
The bot will parse all comments, and it will check if any line start with a command.
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.17)

:x: Jenkins Security Scan failed.
The Security team was notified about this.

I suggest you re-init your plugin based off on:
https://github.com/jenkinsci/archetypes

/hosting re-check

/hosting re-check

/hosting re-check

The Jenkins Security Scan discovered 1 finding(s) :mag:.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.
Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

Jenkins: Plaintext password storage
You can find detailed information about this finding here.
JSMNotificationRequest.java#7
Field should be reviewed whether it stores a password and is serialized to disk: apiKey

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-infra/board is it allowed for plugins to have their own CLAs?
https://github.com/atlassian-labs/jsm-integration-jenkins-plugin/blob/master/CONTRIBUTING.md
I don't believe I've came across it before in any hosted plugins.

This doesn't look like it's been rebased correctly.

The Jenkinsfile is old:
https://github.com/atlassian-labs/jsm-integration-jenkins-plugin/blob/master/Jenkinsfile
Your BOM version doesn't match your jenkins.version
Jackson API version should be used instead of bundling jackson libraries yourself: https://plugins.jenkins.io/jackson2-api/
Same with http client: https://plugins.jenkins.io/apache-httpcomponents-client-4-api
Not recommended to add developers to the pom it'll be done based on who is a maintainer in this repo
extensions.xml incrementals version is really old - https://github.com/jenkinsci/incrementals-tools

I haven't looked at the code much or tried to run the plugin.

@jenkins-infra/board is it allowed for plugins to have their own CLAs? https://github.com/atlassian-labs/jsm-integration-jenkins-plugin/blob/master/CONTRIBUTING.md
I don't believe I've came across it before in any hosted plugins.

I've not encountered it either, but I don't see anything that prevents a plugin from requiring a contributor license agreement if the maintainers of that plugin wish to require it.  The plugin must be licensed under an OSI approved open source license.
Jenkins core maintainers must sign a contributor license agreement, but there is no requirement from the Jenkins project for a CLA from plugin maintainers or from contributors to core as far as I can tell.

jenkins-infra/board is it allowed for plugins to have their own CLAs<EMAIL_ADDRESS>I don't believe I've came across it before in any hosted plugins.

We have no rule against that, but CLAs for plugins are pretty uncommon.
If maintainers choose to harden the way to contribute with legal nightmares, they can surely do that, but shouldn't be surprised if someone refuses to contribute when breaking changes occur in core/APIs 🤷

Thank you for looking into it @timja

The Jenkins file got created by following the instructions here. Can you please suggest us a new file to use or tell us which options are we missing in the current one?

Generating from the archetype should have got you a working one, the expected base one is https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

I have corrected this in the latest PR
I have updated this
I have updated this as well
I have removed the developers from the pom
This too was produced by following the instructions here. However, I have updated it to match it with the link you suggested

Did you follow it verbatim and use an old version? as newer archetypes should have newer versions?

/hosting host


Remove obsolete --strict argument from bazel_to_cmake.

Depends on https://github.com/google/iree/pull/1549

The diff is confusing, since this doesn't branch off of #1549, but assuming you'll clean that up :-)

Oh, doesn't it? The first commit should be the same - the second commit here removes the argument.

The diff is confusing, since this doesn't branch off of #1549, but assuming you'll clean that up :-)

Oh, doesn't it? The first commit should be the same - the second commit here removes the argument.

Oh whoops, you're right. uhh... I'm going to sign off and eat something now :-P


GEODE-9980: Improve error handling around GlobalSerialFilter

Prevent unnecessary errors when enableGlobalSerialFilter is false.
Ensure that error handling is consistent. If setting up a process-wide
filter for Geode fails in anyway when geode.enableGlobalSerialFilter=true
then startup of the Geode process should fail.
Handle "java.lang.ClassNotFoundException sun.misc.ObjectInputFilter",
which is thrown by Java 8 prior to 8u121.
Fix other minor details in LocatorLauncher, InternalDataSerializer and
tests that interact with classes touched by this PR.

Pushed several fixes and marked those comments as fixed and resolved.
I still need to resolve:

fixing log statements and log levels in GlobalSerialFilterConfiguration
testing implementation details instead of behavior in ReflectiveFacadeGlobalSerialFilterFactoryTest

I have one local commit that I believe should be pushed before merging this PR. Startup of a Locator or Server should fail rather than just log a message if the user specifies -Dgeode.enableGlobalSerialFilter but a global serialization filter cannot be configured for any reason.

AnalyzeSerializationSerializablesIntegrationTest failed because I need to update the sanctioned serializables for geode-serialization.

This new unit test failure seems to indicate that something in unit tests set a process-wide filter which I've been very careful to avoid. The test that fails is asserting that the process-wide filter is null which then fails because toString is not implemented on the JDK's filter that gets returned. I think it would be safest to change the reflective API wrapper to return boolean that either there is a filter or it's null.

Rename Geode's ObjectInputFilter to StreamSerialFilter to avoid name collision with JDK

Changes on the invocation handler (168c701) looks good to me.


[Feature]: Deploy from image docker

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
currently my build is done directly by github actions, I already need this for the api, which I host on google cloud run, but I would like to use the same image and deploy the bot.
Why should this be worked on?
currently my build is done directly by github actions, I already need this for the api, which I host on google cloud run, but I would like to use the same image and deploy the bot.

+1

Same here, I want to compile my heavy app locally, push it to an image, then have the VPS pull from it, so that I don't need to have a compilation server and deployment server be the same thing.

Months passed. How to deploy Docker

Months passed. How to deploy Docker

Now is possible you implement from direct a image docker, using a Docker File on deploy, now you don't need of a Github Project.
 Personally I'm still waiting on Docker image support.

Months passed. How to deploy Docker

Now is possible you implement from direct a image docker, using a Docker File on deploy, now you don't need of a Github Project.
 It supports gitea as the git data source. You just install gitea as a service, and then close the bug. Then deploy from the docker. You just add the docker file and close the bug!


SCB-1440 Removed the dependencies of Kamon

Coverage increased (+0.06%) to 82.948% when pulling 960cec45188ae6c354558d0dc66ea70770f0e01c on SCB-1440 into 7b3eb4671aa440cc261e365075ae885660c1cc3a on master.


Create general breadcrumbs root to resolve the confusion about "Virtual Machines" Breadcrumbs root

The old breadcrumbs root was "Virtual machines" and it was a little bit confusing since the settings not related only to virtual machines.
In this PR I changed the old root to home icon instead of "Virtual Machines" and I added a special case for vmListPage that adds the "Virtual Machines" to the breadcrumbs path:

Fixes: #1388 .

Before drilling into the code, a general comment regarding VM details hirarchy:
I think that it should be located under "Virtual machines" as originaly designed i.e.
Home icon->Virtual Machines->__a

Changed :)

LGTM


PhotoPost by using URL

Image posting is not working. Take look at my question in stackoverflow.
http://stackoverflow.com/questions/28087464/tumblr-photo-posting-by-using-jumblr/28087551#28087551

The main problem might be this:
'''01-22 16:25:44.929: E/AndroidRuntime(10082): Caused by: org.scribe.exceptions.OAuthConnectionException: There was a problem while creating a connection to the remote service.'''
And I found something related:
http://stackoverflow.com/questions/17865468/scribe-java-and-async-request-in-android-4
As said, jumblr uses scribe library for their task (I suppose, please fix), which should happen on the main thread. Meanwhile, you are execute your task by an Asynctask which suppose to happen in background (your call to PublishPicture.doInBackground())
Please consider to post your url from inside the onPostExecute method, or something that will happen on main thread. For example, return the url from doInBackground, and inside onPostExecute, use that url to post to tumblr.

I changed below code from doInBackground to onPostExecute.
                            String imgUrl = "http://dummyimage.com/300.png/09f/fff";
			photoPost1.setCaption("sample");
			photoPost1.setSource(imgUrl);
			//photoPost1.setPhoto(new Photo(imgUrl));
			//photoPost1.setLinkUrl(imgUrl);
			photoPost1.save();

Still i am getting same error.

What is the difference between setSource and setLinkUrl?
Furthermore,　there are 2 things you may want to confirm: is your Oauth process success and your use of asyntask. If they are all Ok,  I would like to have a test and will continue this discussion in Stackoverflow question.

I am sure that my Oauth process getting success. Because i tested to post images as FILE.
PhotoPost photoPost = client.newPost(client.user().getName(),
PhotoPost.class);
File file = new File(picturePath);
photoPost.setPhoto(new Photo(file));
photoPost.save();
This is working fine in doInBackground as well as in  onPostExecute.

@selvakottur, I was able to create & save a new PhotoPost with the following code once I authenticated.
    final String source = "<YOUR IMAGE URL HERE>";
    final PhotoPost post = client.newPost("<AUTHENTICATED BLOG NAME>", PhotoPost.class);
    post.setSource(source);
    post.save();

Are you still having this issue?

Closing as I was unable to reproduce the issue and have not heard back.

I am facing the same issue. pls help me with this.

@mittalharsh54 can you share the code that you're having the issue with?

hey @KevinTCoughlin  thanks for reply, I executed the photo upload code in async task and then it did the work. I  think i was executing it directly so it was showing error. Thanks


Add Community Documentation

[x] Code of Conduct Document
[x] Contributing Document
[x] Readme Document enhancement

I updated the readme with links to the other two docs


[Question] What's the best practice to use Factory in a multi-modules project?

First, thanks for releasing awesome DI library. 👍
I have one question.
I thought as below, but this way seems to have some disadvantages of always having to specify the type as optional since it cannot give an initial value.
If you have feature modules, what do you think is the best way to inject dependencies into each module?
In a feature module,
class AFeatureContainer: SharedContainer {
    static let optionalService = Factory<ServiceType?> { nil }
}

In a main module,
AFeatureContainer.optionalService.register { Service() }

This does seem to be a significant problem. The project I'm working in has a strict hierarchy defined for the various modules where some are only accessible in the main application module. This is done so that we may define a resolver at the top level that can be passed to each module for concrete registration of the various private types we want access to.
The problem I've encountered emerges when we want to begin resolving more complex types with resources from multiple modules.
Going the simplest route: If I attempted to define the Factory instances within the main application module, I would be required to make the types from the other modules public in order to fulfill the container registration. This, in theory, would work and allow us to construct these more complex instances within a register call - but I can't sacrifice the usage of private access modifiers to enable this.
Alternatively, I could choose to create stub Factory instances at the main application level (as optional wrappers around public protocols) and then pass the factory to the target module to provide the concrete instances of the private types. This strategy would be fine if I was only resolving types within the target module but in most cases I am going to need registered private types from multiple modules. Passing only a factory makes this not feasible - I'd need the container with a public static func which would produce the side effect of having the types produced by that Factory also need to be public
This practice does work in a framework like Swinject due to the fact that the registration closure is passed a resolver argument where I am able to resolve concrete instances of private types from other modules via their public interface.
import OtherModule

func registerModule(container: Container) {
  container.register(LocalModuleType.self) { resolver in
    let service = resolver.forceResolve(OtherModuleServiceProtocol.self)
    return LocalModuleType(service: service)
  }
}

It seems that there is no clear path to achieving the above example without importing whichever module built out the Container, which will likely blow up any sort of isolation within the module hierarchy.
Finally, this issue appears again for the same reason when attempting to use the @Injected property wrapper, where I need to directly reference the public static func defined on the container.
// Forces importing Container from the main app module, producing circular dependency
@Injected(Container.widgetFactory) private var factory: WidgetFactoryProvider!

So I went into an app with several framework modules (Common, Networking) and added Factory as a package to it, and then did the same with the individual modules.
I then did the following, starting with common...
// Common+Injections.swift

import Foundation
import Factory

public protocol CommonType {}

extension Container {
    public static var commonType = Factory<CommonType> { Common() }
}

private class Common: CommonType {
    public init() {
        print("Common")
    }
}

CommonType is a public protocol, and the factory defines an instance of it based on an internal, private type.
Here's the networking module...
// Networking+Injections.swift

import Foundation
import Common
import Factory

public protocol NetworkType {}

extension Container {
    public static var networkType = Factory<NetworkType> { Network() }
}

private class Network: NetworkType {
    @Injected(Container.commonType) private var commonType
    public init() {
        print("Network")
    }
}

NetworkType is a public protocol, and the factory defines an instance of it also based on an internal, private type. It also uses an instance of CommonType.
Then in the app...
    class CustomCommonType: CommonType {
        init() {
            print("CustomCommonType")
        }
    }

    func testFactory() {
        Container.commonType.register {
            CustomCommonType()
        }
//        Container.Registrations.reset()
        let network = Container.networkType()
    }

Running the app logs...
CustomCommonType
Network

And uncommenting the reset line gives...
Common
Network

Effectively, any module exporting a protocol service type publishes a public Factory of that type.
The Networking module shown above imports Common to get a dependency of CommonType.... which it would have to do anyway to even know about CommonType.
As near as I can see it all hangs together, even to the point of being able to change behavior from outside of the module with  a registration in the main app itself.

This does seem to be a significant problem. The project I'm working in has a strict hierarchy defined for the various modules where some are only accessible in the main application module. This is done so that we may define a resolver at the top level that can be passed to each module for concrete registration of the various private types we want access to.

I haven't fully committed to this yet, but checkout the "unsafe" branch of the project which has a few more options.
Here we define an "unsafe" Factory with a type. Attempt to use it before you've registered a valid factory and things will go boom.
extension Container {
    static let unsafeService = Factory(unsafe: MyServiceType.self)
}

// elsewhere
Container.unsafeService.register { MyService() }

You can also approach it from the @Injected side.
class MyViewModel {
    @Injected(unsafe: MyServiceType.self) var service
}

// elsewhere
Container.shared.register { MyService() as MyServiceType }

Here you provide a type and not a path to a container. If you haven't provided a registration in the shared container prior to construction things will also go badly for you.... ;)
Note that shared is now an instance variable that can be passed around, and has a register and a resolve function, so the following is also valid.
class MyViewModel {
    var version1: MyServiceType? = Container.shared.resolve()
    var version2: MyServiceType = Container.shared.resolve()!
    static func register(_ container: SharedContainer) {
        container.register { MyService() as MyServiceType }
    }
}

Note that in version 1 resolve() returns an optional. If you don't like optionals you can unwrap it as shown in version 2, but you have to do it explicitly in the code.
Bottom line is with these changes you can effectively operate Factory in "Resolver" mode where you promise the code that it will have have what it needs when it needs it. But the various "unsafe" parameter tags make it clear that you're doing just that, and that you're taking responsibility for the consequences.
Once you step outside of Factories and go under the hood you're also losing access to scopes and decorators.
Thoughts?

Been working with this a bit more and I'm starting to be convinced that you really shouldn't need much more than the original "optional" example or the later public protocol /private implementation mechanism shown below.
If a module exports a service protocol then it should be able to provide a public definition of the factory needed to provide it. That can be nil and optional as shown in the first reply if you really can't expose a type, or by providing a public protocol type back by a private, internal implementation.
// Common+Injections.swift

import Foundation
import Factory

public protocol CommonType {}

extension Container {
    public static var commonType = Factory<CommonType> { Common() }
}

private class Common: CommonType {
    public init() {
        print("Common")
    }
}

I may also provide the "unsafe" factory initializer.
extension Container {
    public static var unsafeType = Factory(unsafe: CommonType.self)
}

But really, if a module can "see" the type/protocol of a service then the code can be structured such that it can see the factory that provides it.
And by all rights it should be optional if the best you can do is "I promise that someone, somewhere, will register something before you actually try to use it! Really! I promise!"
I don't think Factory needs a "Resolver" mode after all.

Now i have a clear idea of how to use Factory in multi-modules. Thank you so much for replying in detail with examples. :)

Thank you for the thoughtful response! I will take a look at the changes in the unsafe branch and let you know if that helps to solve some of the issues I had outlined in my first post.

@sethroot You're welcome. This library is in the early stages and I want to make sure I get it right and that things are working as expected.
I'm still not sure if I want to provide the unsafe factory initializer. The primary rationale behind Factory is avoiding the whole "I promise I've provided a registration" approach that Resolver uses.
If the developer can't do the public/private mechanism shown above and must provide some hidden registration, then I think the optional mechanism should be the one preferred.
protocol FeatureAInterface {
    ...
}
extension Container {
    static var featureA = Factory<FeatureAInterface?> { nil }
}

Yes, the end result is optional and a bit of a pain to use. But at least it's guaranteed to be safe.
That said, some sneaky developer could still explicitly unwrap the factory...
let featureA: FeatureAInterface = Container.featureA()!

class WithWrapper {
    @Injected(Container.featureA) var featureA: FeatureAInterface!
}

But at least then they're the ones that would be doing it, and it wouldn't be something encouraged by Factory.


🐛 BUG: SyntaxError: Named export 'compileModuleRules' not found. error when using pnpm create cloudflare then pnpm test

Which Cloudflare product(s) does this pertain to?
C3
What version(s) of the tool(s) are you using?
2.15.0 [C3], 3.0.0 [Wrangler]
What version of Node are you using?
21.6.2
What operating system and version are you using?
Mac Sonoma 14.3.1
Describe the Bug
Observed behavior
Unhandled error occurs when running test on repository created via C3 using pnpm
Expected behavior
Tests should run without errors, same as when the repository is created using npm create cloudflare.
Steps to reproduce
pnpm create cloudflare@latest repro-pnpm-c3-test-issue --type=hello-world --deploy=false --ts --git
cd repro-pnpm-c3-test-issue
pnpm test

Please provide a link to a minimal reproduction
https://github.com/Xvezda/repro-pnpm-c3-test-issue
Please provide any relevant error logs
Vitest caught 1 unhandled error during the test run.
This might cause false positive tests. Resolve unhandled errors to make sure your tests are not affected.

SyntaxError: Named export 'compileModuleRules' not found. The requested module 'miniflare' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'miniflare';

 ❯ ModuleJob._instantiate node:internal/modules/esm/module_job:132:21
 ❯ ModuleJob.run node:internal/modules/esm/module_job:214:5
 ❯ ModuleLoader.import node:internal/modules/esm/loader:323:24
 ❯ ViteNodeRunner.interopedImport node_modules/.pnpm/vite-node@1.3.0/node_modules/vite-node/dist/client.mjs:383:28
 ❯ ViteNodeRunner.directRequest node_modules/.pnpm/vite-node@1.3.0/node_modules/vite-node/dist/client.mjs:253:24
 ❯ ViteNodeRunner.cachedRequest node_modules/.pnpm/vite-node@1.3.0/node_modules/vite-node/dist/client.mjs:189:14
 ❯ ViteNodeRunner.executeId node_modules/.pnpm/vite-node@1.3.0/node_modules/vite-node/dist/client.mjs:165:12
 ❯ resolveCustomPool node_modules/.pnpm/vitest@1.3.0/node_modules/vitest/dist/vendor/cli-api.RIYLcWhB.js:4033:20
 ❯ async file:/[REDACTED]/repro-pnpm-c3-test-issue/node_modules/.pnpm/vitest@1.3.0/node_modules/vitest/dist/vendor/cli-api.RIYLcWhB.js:4083:27

bump

I am trying to add vitest to an existing monorepo project and same error occurred for me. Apparently this is originating from vitest-pool-workers package which exposes ESM while miniflare exposes CommonJS. The error is regarding named import as stated in the issue description. Strangely enough this did not happen for me when I bootstrapped my new repo using the command: npm create cloudflare@latest <repo-name> -- --type=hello-world
I am using similar versions of packages as well.

Thanks. I updated wrangler, @cloudflare/vitest-pool-workers and @cloudflare/workers-types and it  worked like a charm.

Runs pnpm update wrangler @cloudflare/vitest-pool-workers @cloudflare/workers-types seems resolving the issue.
Thanks alot.


Sync up labels/milestones in other repos

[x] cmd
[x] revel.github.io

We need the labels and milestones to be consistent with this repo. Can we version the cmd the same as the framework?

@anonx I agree that the separate repos need their own version, but we should think about how we could ensure the samples have the exact version their expect. Short of adopting a package management approach, we could discuss runtime version checks such as a value specified in config/app.conf.

@anonx I agree that the separate repos need their own version, but we should think about how we could ensure the samples have the exact version their expect. Short of adopting a package management approach, we could discuss runtime version checks such as a value specified in config/app.conf.

FYI we just released this at Piwik: https://github.com/piwik/github-sync
Still in beta, testers welcome :)

@mnapoli that would have been useful. I'll keep it mind, thanks!
I've applied labels to all current repos except for category labels, which we can add as we go.


fix: send button is available though attachment is being loaded (Issue #398)

Issue: https://github.com/epam/ai-dial-chat/issues/398

/deploy-review


Error complining on kernel version 5.15.5-76051505

OS: Pop!_OS 21.04 hirsute (x86-64)
Kernel: 5.15.5-76051505-generic
Xorg: 2:1.20.11-1ubuntu1.1
DE: Cinnamon 4.8.6

I just updated my kernel, and it seams to have broken evdi. As far as I can tell this is due to the latest kernel removing the drm/irq.h file. I tried compiling from source and got this message.
In file included from /home/weeryan17/git/evdi/module/evdi_platform_dev.c:30:
/home/weeryan17/git/evdi/module/evdi_drm_drv.h:23:10: fatal error: drm/drm_irq.h: No such file or directory
   23 | #include <drm/drm_irq.h>
      |          ^~~~~~~~~~~~~~~

I don't know if this is due to the kernel being broken, or if that file will just no longer exist.
I saw there was issue #6 and the solution to that was to install libdrm-dev however I allready have that installed, and up to date so I'm fairly sure it's not that.

This is a duplicate of #308

See #322
On Wed, 2021-12-01 at 03:47 -0800, weeryan17 wrote:

OS: Pop!_OS 21.04 hirsute (x86-64)
Kernel: 5.15.5-76051505-generic
Xorg: 2:1.20.11-1ubuntu1.1
DE: Cinnamon 4.8.6
I just updated my kernel, and it seams to have broken evdi. As far as
I can tell this is due to the latest kernel removing the drm/irq.h
file. I tried compiling from source and got this message.
In file included from /home/weeryan17/git/evdi/module/evdi_platform_dev.c:30: /home/weeryan17/git/evdi/module/evdi_drm_drv.h:23:10: fatal error: drm/drm_irq.h: No such file or directory 23 | #include <drm/drm_irq.h> | ^~~~~~~~~~~~~~~
I don't know if this is due to the kernel being broken, or if that
file will just no longer exist.
I saw there was issue #6 and the solution to that was to install
libdrm-dev however I allready have that installed, and up to date so
I'm fairly sure it's not that.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Didn't see that, sorry!


Update readme.md

Update global tag for GA SDK generation
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[x] Other, please clarify:
We are trying to generate our SDKs for our GA version. We are not able to generate them unless the global tag in the readme matches the GA version we are releasing. Will revert to the newest preview version after GA release completes.

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/pr RequestMerge


Firefox - copy paste don't work

Thank you for filing this issue!
I just published a new version of the extension which fixes this issue. Should be available in a few hours.


🐛 Bug Report — Runtime APIs: Get an incorrect Location param when using Response.redirect

When I use wrangler dev --host localhost:3343 for local development, I want to get a redirect response. But my port number was mishandled and I can’t get the redirect address I’m hoping for. I'm sure it's not the browser's behavior.
wrangler version: ^3.32.0
Example

Im experimenting the same issue
From what I found, seem to have been introduced in
https://github.com/cloudflare/workers-sdk/pull/4950
packages/wrangler/templates/startDevWorker/ProxyWorker.ts
function rewriteUrlRelatedHeaders(headers: Headers, from: URL, to: URL) { 	headers.forEach((value, key) => { 		if (typeof value === "string" && value.includes(from.host)) { 			headers.set( 				key, 				value.replaceAll(from.origin, to.origin).replaceAll(from.host, to.host) 			); 		} 	}); }
I start the worker like this:
npx wrangler dev --env dev --assets assets --host devsite.localg --local-upstream devsite.localg:33667
devsite.localg:33667: is my origin, a node express server
--host devsite.localg: I access my worker from same domain devsite.localg:8787
Behavior:
Url: devsite.localg:8787/to-redirect
with the script above is converted to:
http://devsite.localg:8787:8787:8787/destination
this is because of:
value.replaceAll(from.origin, to.origin).replaceAll(from.host, to.host)
there is the value I have for (from , to)
{
'from.origin': 'http://devsite.localg',
'to.origin': 'devsite.localg:8787',
'from.host': 'devsite.localg',
'to.host': 'devsite.localg:8787'
}
"http://devsite.localg:8787/destination"
.replaceAll("devsite.localg", "devsite.localg:8787")
.replaceAll("devsite.localg", "devsite.localg:8787")

Fixed by #4950.
@h11g and @jfnault-seedbox - please could you try out the beta version of Wrangler with:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7843359492/npm-package-wrangler-4950 dev path/to/script.js


Set shm-size for Triton in yaml

I want to set shm-size=1g while running Triton. For local test it works like docker run --shm-size=1g ...
Where can I set this in the yaml to deploy on GKE? As this is an argument that has to be passed to docker run command.
@yuzisun

I tried this solution, but had to change Knative version to 0.26.0 as earlier versions don't allow usage of emptyDir. config-features has a flag which can be enabled to use emptyDir as volume.
But now I'm getting this error in Triton logs and not sure how to solve it:
'boost::interprocess::interprocess_exception' what():  Read-only file system

yaml
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "triton-mms"
  annotations:
    cluster-autoscaler.kubernetes.io/safe-to-evict: 'true'
spec:
  predictor:
    volumes:
    - name: dshm
      emptyDir:
        medium: Memory
        sizeLimit: "1024Mi"
    triton:
      ports:
        - containerPort: 9000
          name: h2c
          protocol: TCP
      storageUri: <model repo>
      image: <triton iamge>
      imagePullPolicy: IfNotPresent
      args:
      - --allow-sagemaker=false
      env:
      - name: OMP_NUM_THREADS
        value: "1"
      volumeMounts:
      - mountPath: /dev/shm
        name: dshm
        readOnly: false
      resources:
        limits:
          nvidia.com/gpu: 1
          memory: "5Gi"
        requests:
          nvidia.com/gpu: 1
          memory: "5Gi"

https://github.com/knative/serving/issues/4417#issuecomment-987972384
Works on the Knative side (v0.26).
Need help here, not sure why I'm getting the 'boost::interprocess::interprocess_exception' what():  Read-only file system
@yuzisun @animeshsingh @ellistarn

@swapkh91 do you have any update for that issue?
I now also got same problem with triton backend
│ terminate called after throwing an instance of 'boost::interprocess::interprocess_exception'                                                                                │
│   what():  Read-only file system

@swapkh91 do you have any update for that issue? I now also got same problem with triton server
│ terminate called after throwing an instance of 'boost::interprocess::interprocess_exception'                                                                                │
│   what():  Read-only file system

@Phelan164 this issue still exists
Are you trying to increase shm-size?

@swapkh91 yes, I increased shm-size to 2GB but still happening
btw, with that model when I run triton server without kserve, It could run when I set shm-size 1 GB.
and other trying, I increase Triton python backend setting
--backend-config=python,shm-growth-byte-size=1000000000 --backend-config=python,shm-default-byte-size=1000000000
but not working. There error is Read-only mod so I think that it not cause from limit size.
I do not know the error come from kserve or triton but when try with older triton server 21.03-py3 (currently I use 21.11-py3), it could load that model but other issue is that also could not load all my models (~10 models)

btw, it is my logging

@Phelan164 yeah it wont work on kserve as of now, even some issues with normal kubernetes deployment. I raised this issue, yet to be fixed
If you are just using docker, then setting --backend-config=python,shm-default-byte-size=16777216 (16MB) works for python backend

@swapkh91 yes, just try to increase that but it not working.
btw, I also deploy into kubernetes but when I run triton server in container I just add setting --backend-config=python,shm-default-byte-size=16777216
I tried with old version 21.03-py3  it could load some models but also could not load all my models

@swapkh91 yes, just try to increase that but it not working. btw, I also deploy into kubernetes but when I run triton server in container I just add setting --backend-config=python,shm-default-byte-size=<PHONE_NUMBER>  (1GB) I tried with old version 21.03-py3 it could load some models but also could not load all my models

@Phelan164 you have to set shm-default-byte-size between 0-64MB as the total shm-size is 64MB (which can be increased only through emptyDir), shm-default-byte-size sets the shm for 1 model. So if you have 4 python models, you can set shm-default-byte-size=16777216 (16*4)

@swapkh91 yes, I see. I just want to confirm that there is no problem with lack of shm-default-byte-size for my model. So I tried to load a single model with shm 1GB and I have emptyDir 2GB. But it got same error

@swapkh91 I found out that. mount volums mode is always readOnly from knative here.  I also see that, they already have PR for updating that.

@swapkh91 I found out that. mount volums mode is always readOnly from knative here. I also see that, they already have PR for updating that.

it is fixed for knative version 0.26.0. I asked the team here. But its read-only on Kserve side right now

@swapkh91 humm, I think it not fixed readOnly mode. You could src here and you could refer recently discussion here

Hi rw is allowed for emptydir only at the moment but full pvc support is coming.

@skonto thanks for your info,
Just want to confirm, my setting for empty now is using memory not disk, is this support write?
    - name: dshm
      emptyDir:
        medium: Memory
        sizeLimit: "1Gi"

@swapkh91 did you try older version of kfserving? did it have same problem or just new version?

@skonto thanks for your info

@swapkh91 did you try older version of kfserving? did it have same problem or just new version?

@Phelan164 just the latest version

I tried this solution, but had to change Knative version to 0.26.0 as earlier versions don't allow usage of emptyDir. config-features has a flag which can be enabled to use emptyDir as volume.
But now I'm getting this error in Triton logs and not sure how to solve it:
'boost::interprocess::interprocess_exception' what():  Read-only file system

yaml
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "triton-mms"
  annotations:
    cluster-autoscaler.kubernetes.io/safe-to-evict: 'true'
spec:
  predictor:
    volumes:
    - name: dshm
      emptyDir:
        medium: Memory
        sizeLimit: "1024Mi"
    triton:
      ports:
        - containerPort: 9000
          name: h2c
          protocol: TCP
      storageUri: <model repo>
      image: <triton iamge>
      imagePullPolicy: IfNotPresent
      args:
      - --allow-sagemaker=false
      env:
      - name: OMP_NUM_THREADS
        value: "1"
      volumeMounts:
      - mountPath: /dev/shm
        name: dshm
        readOnly: false
      resources:
        limits:
          nvidia.com/gpu: 1
          memory: "5Gi"
        requests:
          nvidia.com/gpu: 1
          memory: "5Gi"

We have tested the above yaml which works with triton 21.09, kserve v0.8.0-rc0 and knative 1.0, but with kserve v0.7.0 you get what():  Read-only file system error in triton inference server.

0.8 has been released.


[Performance]: Profile & optimize the BlockManagerV2

Proposal to improve performance
We've recently rewritten the block management subsystem for better testability. We need to profile it under real load to make sure it is performant enough to replace the block manager V1, and fix any issues.
We should do this once the block manager v2 is feature complete (still missing a few items).
Known issue:

Prefix caching num_total_tokens is O(N^2) instead of O(N) (see https://github.com/vllm-project/vllm/pull/4142#discussion_r1585245813)

What we want to profile:
For low-latency use case:

Batch size of 8-16 range
Various block sizes (16, 32, 128)
Sequence length (long context, 1.5k). Can set num_output_tokens=50.
For spec decode, also num_lookahead_tokens > 0. Try num_lookahead_tokens=5 (what is lookahead scheduling)

For high-throughput use-case:

Batch size up to 256
Various block sizes (16, 32, 128)
Sequence length (long context, 1.5k). Can set num_output_tokens=50.

Other cases that are important (perhaps we make separate tasks):

P0 prefix caching
P1 Beam search
P1 swapping
P1 sliding window

In terms of how to profile, use benchmark_latency + torch profiling (or can use CPU profiler of your choosing) https://github.com/vllm-project/vllm/blob/c3c2903e72c6e85a81ff6de8b879f4c82e8ad364/benchmarks/benchmark_latency.py#L178-L187

@robertgshaw2-neuralmagic can you assign Alex


Is there an example of how to edit the user password and email.?

That's better left to a User model. AngularDevise is just mean to handle authentication with Devise, not manage the user's details.


PropertySettersContextExtension Binding, MultiBinding and DynamicResource support

PropertySettersContextExtension Binding, MultiBinding and DynamicResource support

8.8.4 published


Error: Unable to decode using the supplied passphrase Polkadot.js wallet

Hi, I wanted to make a transfer using my polkadot Wallet - but It just wont accept my password. And I am pretty sure its the right one. So I recovered everything with JSON File.. and seed words several times.. in order to change my password. But it still doesnt accept my password when doing a transaction. I updated the metadata also. I keep on getting this error in the browser extention: Unable to decode using the supplied passphrase.
Can someone help me? Thx!

Have you stored the password w/o a line break? e.g. echo -n "mySupersecretPassword" > password

I managed to solve it.. had this issue a month ago...
Best
Nathalie
Am Fr., 3. Dez. 2021 um 14:41 Uhr schrieb Philipp D. <
@.***>:

Have you stored the password w/o a line break? e.g. echo -n
"mySupersecretPassword" > password
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/w3f/polkadot-payouts/issues/46#issuecomment-985529931,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVA5PGNDROI7SZ7Z6ERRSUDUPDCHVANCNFSM5GNTDTQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Label not shown or incorrect while Gauge.X is set higher than 0

g = termui.NewGauge()
g.Width = 30
g.Height = 3
g.X = 30
termui.Render(g)
The percent label display incorrectly.
According to gaugo.go, pos of label is not play with g.innerX, that's issue.

:+1:


Add option to remove and not manage status bar completely

It may be useful using SafeAreaView or when managing status bar manually.

When you use SafeAreaView with hidden status bar, do you have any freezes?

@damikdk I use SafeAreaView with visible status bar. So I want ability to disable status bar setup by react-native-navbar at all.


Support the latest Ruby version on Travis CI

Travis CI against the latest Ruby 2.4.1.
I added it.

Thanks @yensaki that's brilliant. I've merged. Won't deploy a new gem version for now. (Unless you think I should?)


Bottom sheet height

An adjustable height of the modal bottom sheet would be nice

Range selector with Theme Roller


[feature request] Add caching capabilities to cache successful links for some time

hi,
I use markdown-link-check and thanks for it 👍
This would be nice to add a caching capabilities in order to cache successful links for some time.
This will make the checking faster and also more reliable (as some links could timeout sometimes).

Doesn't it cancel the interest of testing links? What if the link is broken and your cache says it's not? How long would you like your cache to be retained?
If it's about links being used in the same project in multiple places, a unicity check at the site level would be probably better and would be ok as only for a run. In this case, having this done at marksdown-link-checker level seems better to me.
Let me know if I misunderstand your need.

I will explicit my use-case.
I have a wiki on gitlab, and I want to check that links are not broken after each page update to detect this as soon as possible.
I would say that 50 pages are updated per day.
One link-check run of the whole wiki lasts about 5 min.
Using a cache of working links for 1 day (or more) would save a lot of time.

A working link is broken if the website is down or if the page has moved (not so often)
A new link could be broken for lot of reason, but mainly because it's simply wrong

Using a cache will speed up detection of new link that are wrong, whereas all links could be check only once a day.

Hum interesting. Let me sleep on it a bit, I have to run the scenarios in my head...
@tcort any opinion on this one?

@tcort any opinion on this one?

I'm open to a pull request which would implement some form of RFC 7234 compliant HTTP caching.

I'm considering switching from needle to got which supports caching and a ton of other features.


[Documentation Update]: SNFR17 - Semantic Versioning - version.json

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Description
I believe we should enhance the clarity of the section on semantic versioning at https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-snfr17---category-release---semantic-versioning. Currently, it outlines the versioning mechanism broadly. We should specify, particularly for Bicep modules, the need for a version.json file, include a template for contributors, and clarify versioning practices. For instance, if the initial module version in the version.json is 0.1.0, contributors should record it as 0.1. This distinction was initially unclear and could lead to confusion.
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.1",
"pathFilters": [
"./main.json"
]
}

Hi @jbinko,
From a spec perspective (generic for both DSLs) I see we already specify that Bicep only requires to update major and minor, since patch is automatically updated.
However, from a contribution flow point of view, I agree we can better highlight version update as a dedicated step in the process.
I'd suggest to cover the How in the contribution guide rather then the specs.
What's your take on that?

For contributors in Bicep - let's point them into this: https://azure.github.io/Azure-Verified-Modules/specs/bicep/#id-bcpnfr14---category-composition---versioning
This is clear one step that they should include one file and with specific content


Add .codecov.yml

Our codecov.io status no longer blocks PRs with less than 100% code coverage. Trying to fix that.

@vprithvi  So this build is still not failing, even though codecov/project — 99.96%
It might be because strict_yaml_branch: master  # only use the latest copy on master branch, not sure.
Actually, this file is invalid, doh...
$ curl --data-binary @.codecov.yml https://codecov.io/validate
mapping values are not allowed here
  in "<string>", line 13, column 14:
          default:


Desktop app

Hallo,
I wanna ask, how to get font size bigger?
https://s12.postimg.org/bcz3phbnx/Screenshot_09_03.png
Thx

If you dont want it to look a bit weird, you'd have to adjust all of the font-size properties.

I'm just gonna close this, cause it's not something concerning the theme, but rather a general question about Discord's CSS.


Comodo Secure DNS add

https://www.comodo.com/secure-dns/
<IP_ADDRESS>
<IP_ADDRESS>

I will not add any DNS provider which does NXDOMAIN hijacking.

Also, the commit is incomplete and wouldn't have worked anyway.


Bind to IP does not fully work

I love the application and created an account here just to post this, thank you for an awesome app!
I start my VPN then set the Listen Interface to my VPN IP.  I check the connection to ensure it is using the VPN by using an ip leak testing magnet link (another issue, sometimes ip leak testing magnet links do not load) and checking the connected IP.
If I disconnect the VPN connection, the torrents slow to a stop as expected, but then they start back up on my unprotected connection.
Expected action is application uses VPN connection, if the selected connection drops, application does not jump connections and the data transfer stops to prevent leaks.

I think I fixed this issue by proxy when doing #899. Can you download the latest build from AppVeyor and check? Available here https://ci.appveyor.com/project/picotorrent/picotorrent/builds/35224502/job/nwcqkyi0acn32hme/artifacts

Looks like that version fixed it!
Though if I go to:
Preferences>Connection>Click old IP>Edit  The popup shows Network Adapter box as empty, if I click OK without changing anything, it crashes the application.  If I choose a working IP/Adapter, it works fine.  Just a heads up!

Great - can confirm the network adapter issue you found. I'll open a new issue for that :)


Fix ansible test failure and missing make cmd

Signed off by @jnpacker

Fix broken ansible test
Include Ansible test in make unit-tests

/cc @hanqiuzh @leena-jawale @itdove

/approve
/lgtm


How to build?

CMake Error at CMakeLists.txt:17 (target_link_libraries):
Cannot specify link libraries for target "BLEScout" which is not built by
this project.

Have you modified the CmakeLists.txt? Mine is just 10 lines, so not sure about line 17.
I confess, I need to add some build instructions. Will do that along with the upcoming new release, which will fix some issues and should be available on all three platforms then.
You need to create a folder lib in the blescout root and inside that folder you have to clone the nappgui_src repo and SimpleBLE repo. I'm going to add those as recursive git submodules with the next release.

Then build NAppGUI:
// Windows
mkdir build & cd build
cmake .. -DCMAKE_INSTALL_PREFIX=C:/nappgui
cmake --build . --config Debug

// macOS
mkdir build ; cd build
cmake .. -G Xcode -DCMAKE_INSTALL_PREFIX=/usr/local/nappgui
cmake --build . --config Debug

// Linux
mkdir build ; cd build
cmake .. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/usr/local/nappgui
cmake --build .

And finally build blescout:
cmake --build build --config Release

let me see.
`cmake_minimum_required(VERSION 3.5)
project(BLE-Scout)
find_package(nappgui REQUIRED)
SET(NAPPGUI_ROOT_PATH,"E:/works_napp/nappgui")
include("${NAPPGUI_ROOT_PATH}/prj/NAppCompilers.cmake")
nap_config_compiler()
Remove WIN32 in Linux and macOS
add_executable(BLEScout WIN32 blescout.c util.c logwin.c ble.c connect.c help.c)
target_link_libraries(BLEScout ${NAPPGUI_LIBRARIES})
simpleble
add_subdirectory(simpleble/simpleble ${CMAKE_BINARY_DIR}/simpleble)
target_link_libraries(BLEScout simpleble::simpleble-c)`
I am new Programmer.


[Doc] Tabs in the user guides are misleading

The tabs in the documentation Working with Product Observability seems to be confusing. There is high possibility to miss configuration steps since the tabs are hidden by defualt.

+1
We can add general topics for Configuring Product Observability, Enabling Observability, etc. And use tabs for Log Patterns and other optional stuff. WDYT?

Restructured the content in the following pages accordingly:

https://docs.wso2.com/display/IS540/Working+with+Product+Observability
https://docs.wso2.com/display/IS541/Working+with+Product+Observability
https://docs.wso2.com/display/IS550/Working+with+Product+Observability
https://docs.wso2.com/display/IS560/Working+with+Product+Observability
https://docs.wso2.com/display/IS570/Working+with+Product+Observability
https://docs.wso2.com/display/IS580/Working+with+Product+Observability

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Restrict access to planning applications for inactive councils

Description of change
We do not want assessors or reviewers to see the index page containing planning applications before the local authority is activated, because missing information will lead to broken views.
We discussed simply redirecting users to the administrator pages on login, but this does not work as the user is stuck in a redirect loop when the existing method tries to send them back to the root path.
Instead, I have gone for the simpler option of allowing them to see the index page (so they still have access to navigation and can log out) but with a custom message explaining why it is blank.
We do not need to worry about planners accessing other pages, as we are not going to allow active councils to be edited to be inactive, so this only applies to newly configured councils who are in the process of being activated.
Story Link
https://trello.com/c/8NN0YtXu/2378-do-not-allow-assessors-and-reviewers-to-access-the-system-when-a-local-authority-is-inactive

Closing because the POs inform us that this would not be a likely scenario (council admins would not create users before the local authority is active)


format python code in demo, doc, doc_cn and paddle directories

use pep8 code style to format python code in demo, doc, doc_cn and paddle directories
except for paddle/scripts/cpplint.py
#254

Coverage remained the same at 62.905% when pulling 319742c641d32d64113655c0b0129f10b7ca42b6 on QiJune:format_py_code_1st into ef5e483ca408d29b25969633e1e65c862e17b751 on baidu:develop.


Add scroll mechanism to scrollToError

Discussed in https://github.com/ciscoheat/sveltekit-superforms/discussions/198

Originally posted by AntonPavlenkov June 21, 2023

I encountered an issue where the window does not have a scroll, while its children do. As a result, scrolling to an error does not work since the window itself lacks a scroll functionality.

In order to address this, I propose the following enhancements to improve the functionality:

Add an option in the configuration to specify the element for scrolling.
Utilize the Element.scrollIntoView() function.
The second option seems preferable as it reduces the amount of code required for calculations such as getBoundingClientRect(), centering the element, and removing the sticky header, among other things.

That's just an extra option for scrollToError, so that should be no problem.

Same here using Skeleton UI's AppShell, which scrolls an element instead of the entire window.
For now, I'm doing customized scrolling in onUpdated() event callback.
const { form, errors, enhance } = superForm(data.form, {
    scrollToError: 'off',
    onUpdated({ form }) {
        if (!form.valid) {
            document.querySelector('[data-invalid]')?.scrollIntoView({ behavior: 'smooth' })
        }
    },
})

Hope this is useful to anyone running into the same issue before official solution is landed.

Added now in 1.2.0: https://github.com/ciscoheat/sveltekit-superforms/releases/tag/v1.2.0

Closing this, the tests are passing.


ci: Filter supported versions of AKS

Whenever AKS stopped supporting a particular version of AKS, we had to
manually remove it from all stable branches. Now instead of that, we
will dynamically check if it's supported and only then run the test.
Followup on https://github.com/cilium/cilium/pull/32302

/test

/ci-aks

Example run: https://github.com/cilium/cilium/actions/runs/8922573954/job/24504996845
Version 1.27 is valid for zone
Version 1.28 is valid for zone
Version 1.29 is valid for zone
Filtered matrix:
{
  "include": [
    {
      "version": "1.[27](https://github.com/cilium/cilium/actions/runs/8922573954/job/24504996845#step:7:28)",
      "location": "westus2",
      "index": 2
    },
    {
      "version": "1.[28](https://github.com/cilium/cilium/actions/runs/8922573954/job/24504996845#step:7:29)",
      "location": "eastus2",
      "index": 3
    },
    {
      "version": "1.[29](https://github.com/cilium/cilium/actions/runs/8922573954/job/24504996845#step:7:30)",
      "location": "eastus",
      "index": 4,
      "default": true
    }
  ]
}```

/test

This is cool, and very debuggable since we can compare the "Generate Matrix" vs. "Filter Matrix" steps to validate whether which targets we're skipping, but this does raise the question: Who watches the watcher? Previously it would be pretty obvious that we've lost coverage, because the tests would fail. Now it seems like we will silently lose coverage so we really need to be on top of keeping the matrices up-to-date or we'll just skip the testing entirely(?)

Now it seems like we will silently lose coverage so we really need to be on top of keeping the matrices up-to-date or we'll just skip the testing entirely(?)

This is exactly the intent that we were doing manually. Once Cilium version is released, we "freeze" supported versions and only remove no longer supported versions AFAIK.


docs: Add instructions to migrate to Mbed CLI 2

Starting with version 6.5, Mbed OS  uses Mbed CLI 2. It uses Ninja as a build system, and CMake to generate the build environment and manage the build process in a compiler-independent manner.

I'll merge this as it contains docs update to support new Mbed CLI 2.

I'll merge this as it contains docs update to support new Mbed CLI 2.

@0xc0170 I'll close this PR and open another one for development.

@0xc0170 I'll close this PR and open another one for development.


Add typescript typings

Please add typescript typings to bump-regex as bump-regex/index.d.ts.
An initial working first stab at this would be
/// <reference types="node"/>

declare function BumpRegex(opts : string|BumpRegex.Options, cb : BumpRegex.Callback) : any|null;

declare namespace BumpRegex {

  declare function Callback(err : string|Error|null, opts?: Result) : any|null;

  interface Options {
    type? : 'major' | 'minor' | 'patch' | 'prerelease';
    version?: string;
    str?: string;
    key?: string;
    keys?: Array<string>;
    case?: boolean;
    global?: boolean;
    preid?: string;
    regex?: Regex;
  }

  interface Result extends Options {
    prev: string;
    new: string;
  }
}

export = BumpRegex;

Of course this would also require some typescript based tests, adding additional dev dependencies to the project.

@stevelacy I have made a PR for this over at DefinitelyTyped. See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22104

Closing since the PR was merged


Reduced allowed line max length to 100

As discussed in one of our NinJS guild meeting, the allowed max length
for a single line of code is now 100 characters.
See the issue here: https://github.com/samsao/guilds/issues/106
Additionally, I added some rules that were not defined in our config but
were new to the eslint-react-plugin. I tried to update the airbnb config
we use before doing so but the changes aren't published yet. (The last
npm publish was two months ago and the changes to add the rules were
commited a month ago). We need to keep an eye on the next
eslint-config-airbnb release.

Seems we going to keep at 120 since prettier is set up to 120. Closing.


Diligent-free-kookaburra: update search icon to point opposite direction

Ticket: https://app.clubhouse.io/glitch/story/10482/replace-search-icon-in-shared-components-with-magnifying-glass-handle-facing-other-way
Looks like this now:

Not like this:

:rocket: PR was released in v0.19.0 :rocket:


Unexpected issue: float division by zero

When I start to train fisrtly, it says it divided float by 0. What is going on?
The tensorboard extension is already loaded. To reload it, use:
  %reload_ext tensorboard
Reusing TensorBoard on port 6006 (pid 7752), started 0:15:04 ago. (Use '!kill 7752' to kill it.)
2023-12-05 00:47:05.105294: E tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:9342] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2023-12-05 00:47:05.105367: E tensorflow/compiler/xla/stream_executor/cuda/cuda_fft.cc:609] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2023-12-05 00:47:05.105405: E tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:1518] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-12-05 00:47:05.117685: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-12-05 00:47:07.518213: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Batch size per GPU : 8
/usr/local/lib/python3.10/dist-packages/torch/nn/utils/weight_norm.py:30: UserWarning: torch.nn.utils.weight_norm is deprecated in favor of torch.nn.utils.parametrizations.weight_norm.
  warnings.warn("torch.nn.utils.weight_norm is deprecated in favor of torch.nn.utils.parametrizations.weight_norm.")
----------0----------
2023-12-05 00:47:17,370 - INFO - Start from 32k pretrain model: ./vits_pretrain/sovits5.0.pretrain.pth
2023-12-05 00:47:18,418 - INFO - Starting new training run.
----------0----------
/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py:557: UserWarning: This DataLoader will create 4 worker processes in total. Our suggested max number of worker in current system is 2, which is smaller than what this DataLoader is going to create. Please be aware that excessive worker creation might get DataLoader running slow or even freeze, lower the worker number to avoid potential slowness/freeze if necessary.
  warnings.warn(_create_warning_msg(
Validation loop: 0it [00:00, ?it/s]
Traceback (most recent call last):
  File "/content/so-vits-svc-5.0/svc_trainer.py", line 41, in <module>
    train(0, args, args.checkpoint_path, hp, hp_str)
  File "/content/so-vits-svc-5.0/vits_extend/train.py", line 160, in train
    validate(hp, args, model_g, model_d, valloader, stft, writer, step, device)
  File "/content/so-vits-svc-5.0/vits_extend/validation.py", line 44, in validate
    mel_loss = mel_loss / len(valloader.dataset)
ZeroDivisionError: float division by zero

It seems that there is no validation dataset.
if you don't want to add validation dataset, just disable validation phase.
in line 160 in content/so-vits-svc-5.0/vits_extend/train.py
# validate(hp, args, model_g, model_d, valloader, stft, writer, step, device)

Thank you for your answer, but how can I make or add validation dataset?

um, I did running it in official Colab. And it just says 0/0 0it/s. What is going on?

Exactly, validation set is for the validation not for training.
So if you can train your model well, you can skip the validation phase.
(but its result isn't guaranteed)
I can't answer what exact problem is because there could be a lot of reasons for that.
it may be due to preprocess, dataset path, or other problems.
I hope you find the cause well.

um, I think I figure out the way. I didn't zipped dataset in correct way.
Thanks @Gabibing for supporting me.
For someone looking for answer for this problem:
You must create folders called speaker0 - speakerxxx in dataset_raw folder. In speakerxxx, you should put dataset file (audio file). I think most of popular format of audio files are accepted in this repository.


Remove frame-size block-length restriction

While we may need to support non-stream ciphers at some point, currently our only bulk cipher is AES-GCM which has no block size restrictions.  Thus, we can (and should) remove the restriction that our frame-sizes be a multiple of 16.
https://github.com/awslabs/aws-encryption-sdk-java/blob/master/src/main/java/com/amazonaws/encryptionsdk/AwsCrypto.java#L140
This change should be completely backwards compatible as this restriction is only enforced on the encrypt path and not the decrypt path.  As part of this change, backwards compatibility will be manually tested.
Additionally, this task will also be completed in aws-encryption-sdk-python

See issue aws-encryption-sdk-python#30

Base64 encoded ciphertext using a 15 byte block-size. This has been confirmed as decryptable via the aws-encryption-sdk-cli which using the python implementation internally.
AYADeM4hjbiamPp3iXnwZoz+IkQAXwABABVhd3MtY3J5cHRvLXB1YmxpYy1rZXkAREExdUJoUW0yc1hZWTk5S1NkYXJVcjRDN0x5WTlxd1o5L0JrOFhuMjdwYzdUODVMTTdtM2RaalBPZzVVV2Y5YW5WZz09AAIAB2F3cy1rbXMAS2Fybjphd3M6a21zOnVzLXdlc3QtMjo2NTg5NTY2MDA4MzM6a2V5L2IzNTM3ZWYxLWQ4ZGMtNDc4MC05ZjVhLTU1Nzc2Y2JiMmY3ZgCnAQEBAHhA84wnXjEJdBbBBylRUFcZZK2j7xwh6UyLoL28nQ+0FAAAAH4wfAYJKoZIhvcNAQcGoG8wbQIBADBoBgkqhkiG9w0BBwEwHgYJYIZIAWUDBAEuMBEEDCZX1wU5fDCyX+Am9wIBEIA7RpItoEBOjhQzvyp3zDvJTXLLX0Z+TqroeiqC2ypiSvp3qAHPcbjCUPm3otYAwf+XdaN8wmmM6Y+R25sAB2F3cy1rbXMATmFybjphd3M6a21zOmV1LWNlbnRyYWwtMTo2NTg5NTY2MDA4MzM6a2V5Lzc1NDE0YzkzLTUyODUtNGI1Ny05OWM5LTMwYzFjZjBhMjJjMgCnAQECAHhpJnHNhxTb+pGIUToV1eANxoxSoEUMxxMR4xlifYIGHQAAAH4wfAYJKoZIhvcNAQcGoG8wbQIBADBoBgkqhkiG9w0BBwEwHgYJYIZIAWUDBAEuMBEEDIbGweY+2sPfj1maeQIBEIA7Z2JiAspOWHA9TXJ9/4mpjdWzYBqQUQvC0qNGixH5CsgElkYAT94s/KBBakcuUiwqW7VNoKOyHqgyrjECAAAAAAwAAAAPAAAAAAAAAAAAAAAA24jZ+wTt58UvuUtFva6fngAAAAEAAAAAAAAAAAAAAAFfrxCiBAdIEO/fwZJvd02JIH817tj2etlH795oFlP1AAAAAgAAAAAAAAAAAAAAAnyatX/b6BJBeoqeyyo8Q+GDu8eCUo8O0xLNBuRR4Y4AAAADAAAAAAAAAAAAAAADHTAAkSsWx28tQhfv7tkPCGV33OtuV0opiXJxmHFuBgAAAAQAAAAAAAAAAAAAAARS4DUGlWVT/bCUoT9qdg9tmPOSDWhdCUvlDA/yMpabAAAABQAAAAAAAAAAAAAABaxoKhWQtMcFpX9a5GrwCFL8qabwGqH3+QERUxCUcG4AAAAGAAAAAAAAAAAAAAAGC9ALLMhdAn0dBtcWjrhAMHmeVOgfU404Dszn1Uj1qgAAAAcAAAAAAAAAAAAAAAekOpjIt2XJ0Sp01gJfrDJrmUVKps8IrliAn7SVdDSI/////wAAAAgAAAAAAAAAAAAAAAgAAAAF0R67cEXsmac8RNBnAiBILbAANmd1AGcwZQIxAMnVDGW4C9dp5NbYqz9pCqAyXfpiovB2GdsfWmivFvkGeWI2CrN8S7Sk/s+EplUS+QIwMxg7l6hVlQ+jpR/raHsYgYPPVlKUyby9DbGtzuWLLI71+iTCzC5XaLrKBPlmMpHJ


inject whole head in header and footer

The change allow the following imporvements:

Use link elements defined in the head also into the header and footer
Use multiple style tags. right now the selector would only take the first style tag and ignore the others

I am using it right now and I can't see any downside of this approach

Thanks
While this is a good solution for most cases, this creates invalid html in the head & footer elements.
I'd rather use something like this:
styles = document.querySelectorAll('link,script')
styles = Array.prototype.reduce.call(styles, function(string, node){return string+node.outerHTML;},'')

Definitely a much better solution! Also, how do you build it? I don't see the instructions on the readme :)

npm test also builds the coffeescript.
I've pushed v1.2.0 to github & npm

Great! let's close this PR then :)


feat: perform "back" actions througout the app using centralized hook (hl-1276)

Description :sparkles:
Handler side changes. Back buttons each had custom function calls to next router. Use centralized hook to perform these actions with different logic and use cases.

Use one function to invoke when Back buttons are pressed

Usually, go back from application to corresponding tab with matching status
Go to archive if the application is archived

One special case where similar applications were searched for with ?appNo=123456 param

Go to alterations if it was previously visited
If no other means is provided, route back to root of the app

Browsing is now recorded to window.sessionStorage to allow for history tracking and usage where needed
Fix one key prop issue

API branch is deployed to platta: https://kesaseteli-pr3394.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja :rocket::rocket::rocket:

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

API branch is deployed to platta: https://helsinkilisa-pr3394.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja :rocket::rocket::rocket:

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

API branch is deployed to platta: https://helsinkilisa-pr3394.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja :rocket::rocket::rocket:

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe youth result is failed for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

TestCafe admin result is failed for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

API branch is deployed to platta: https://kesaseteli-pr3394.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja :rocket::rocket::rocket:

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe youth result is failed for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

TestCafe admin result is failed for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe employer result is failed for https://kesaseteli-employer-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr3394.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

TestCafe applicant result is failed for https://helsinkilisa-ui-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3394.dev.hel.ninja :crying_cat_face::anger::boom::boom:

YJDH-TET-API branch is deployed to platta: https://yjdh-tet-pr3394.api.dev.hel.ninja :rocket::rocket::rocket:

ADMIN is deployed to platta: https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

YOUTH branch is deployed to platta: https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://yjdh-tet-admin-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://yjdh-tet-youth-ui-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-employer-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-handler-pr3394.dev.hel.ninja :laughing::tada::tada::tada:

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr3394.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-youth-pr3394.dev.hel.ninja :laughing::tada::tada::tada:


userns-remap=default causes command '/bin/bash' could not be invoked

Output of docker version:
Client:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:45:32 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:45:32 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 6
 Running: 2
 Paused: 0
 Stopped: 4
Images: 23
Server Version: 1.11.1
Storage Driver: devicemapper
 Pool Name: docker-252:1-384279-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: ext4
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 2.277 GB
 Data Space Total: 107.4 GB
 Data Space Available: 11.71 GB
 Metadata Space Used: 3.486 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.144 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/100000.100000/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
 Metadata loop file: /var/lib/docker/100000.100000/devicemapper/devicemapper/metadata
 Library Version: 1.02.93 (2015-01-30)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge
Kernel Version: 4.4.3-201.fc22.x86_64
Operating System: Fedora 22 (Twenty Two)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 489.2 MiB
Name: fedora-512mb-nyc3-01
ID: T73W:C4T2:ELB3:OYAS:V34F:7JV4:F66H:QHRI:QKU2:6ZZL:YUPU:VGON
Docker Root Dir: /var/lib/docker/100000.100000
Debug mode (client): false
Debug mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled

Additional environment details (AWS, VirtualBox, physical, etc.):
digitalocean droplet
Steps to reproduce the issue:

set userns-remap=default flag for the docker daemon
rebuild with docker-compose build
3 .docker-compose up

Describe the results you received:
ERROR: Container command '/bin/bash' could not be invoked.
Describe the results you expected:
This dockerfiles + compose works without the userns-remap flag
Additional information you deem important (e.g. issue happens only occasionally):
dummy project I'm testing with https://github.com/zunayed/movie_db

Looks like when I mount a a volume
    volumes:
        - .:/code

it doesn't work. If I removed that bit the bash command runs. I also noticed on this box the ubuntu image was recently updated whereas I have it working on another box with a ubuntu image from a few days ago. Hmm

You're bind-mounting a directory from your host inside the container. Any files in that directory may have a different owner than the user inside the container (i.e., the uid/gid on the host no longer match the uid/gid inside the container), making them inaccessible by the process in the container.
If I understand your case correctly, then this is exactly where userns-remap was designed for; if a process inside the container "breaks out" (in this case through a bind-mounted directory), it doesn't have permissions to do any harm, as the "root" user inside the container is not "root" outside.
I don't think there's a bug here, but let me know if there's something I misinterpreted 👍

@thaJeztah Thanks for the reply! I'm just trying to execute bash in the container though. Even when I give compose command: bash -c "ls -la"  I get the same error. I don't really understand why mounting a volume would cause the containers bash not to work.

@zunayed which container is failing? the db service is also using that volume, so possibly that one tries to access the files? https://github.com/zunayed/movie_db/blob/master/docker-compose.yml#L9-L13

@thaJeztah The  web worker is failing
https://github.com/zunayed/movie_db/blob/master/docker-compose.yml#L26
The celery worker however seems to work fine and is using the same dockerfile build
https://github.com/zunayed/movie_db/blob/master/docker-compose.yml#L37

Any chance this is the same issue as #22633?

closing as #22633 contains even more detailed description


driver logic to interface between CLI TopicModelFactories as well as logic to execute the algorithms in question and record the results

TODO :

Testing for :
NLLPCLI.run
NLLPCLI._process_responses

DataLoader.prompt_yes_no
Menu.prompt_numeric
Menu.prompt_string
Menu.handle_choice
Session.set_data
Session.set_config*
Driver.run_menu
Driver.process_response

Sync Factory with CLI logic

Parse session.logs['data'] and build BERTopic object using TopicModelFactory
call build_model function in factory object

Implement run model and plotting logic
run model :

basically just calling fit transform on the bertopic object and passing correct values to plotting functions

Plotting :

Specify directory for plots
Also generate clickable links to render plotly figures in browser

Testing for configmenu


[FEATURE] Integrate Signifyd's fulfillment API for payments

Feature Description
Fulfillment API is used for providing updates to Signifyd about a order. In case it was returned, a refund would've been initiated, this needs to be informed to Signifyd which helps them strengthen their fraud model, which in turn helps in better fraudulent detection.
Possible Implementation

Identify the triggers for having to process a transaction once it has reached terminal state (refunds etc.)
Invoke fulfillment API (if enabled) for any such triggers

Possible triggers

Disputes won
Refunds
Partial refunds
...

Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to submit a PR?
Yes, I am willing to submit a PR!

This was added @srujanchikke


Add some package management unit tests for JupyterServerInstallation

There's a lot of code in JupyterServerInstallation, so these tests only increased the code coverage by 10-20%. Unit testing the python installation would require a lot of mocking, so I'll try to tackle that next week.

Coverage increased (+2.6%) to 40.574% when pulling 02558dc3518a2e0dca1b01bd1afe14ec72922ec4 on corivera/installationTest into 8cbf73dff677f18d6b8d7f8f7cac279b96becd9c on main.


Add Passport Instagram Strategy

i have added passport-instgarm authentication , you can accept pull request

@atuljain I'll look at this over the weekend. Thanks for putting this together!


changes to run against version=4 models

Using the instructions to install and run in a docker container, I was not able to run the sample shell scripts.
Also, for the vehicle-attributes-recognition-barrier-0039.json, the json array of vehicles labels was a single string instead of json array.

Hi @klonikar ,
Can you align with our master? We just uploaded new changes and there are some conflicts.

Resolved. But merge this pull request only if your new changes do not support models version > 4. I had to make these changes as the docker created could not support models with version=6.

Hi @umed ,
Can you merge or close this pull request? Its a small change for downloading and running version 4 models as the docker image created using instructions to create docker image does not install openvino version capable of running version 6 models.
But if you have updated the instructions or going to do so, please close the pull request.
Kiran

hi @klonikar ,
We migrated to latest version of OpenVINO. Probably, it supports latest version of models.
By the way, don't see reasons to hardcode models version in scripts/path_extractor.sh.

hi @umed ,
Thats fine. Hopefully the version of openvino that your new Dockerfile and build script installs does support latest version models.
I too did not want to hardcode  model version in scripts/path_extractor.sh but did that only after finding that higher version models are not supported by the openvino installed in the docker.

Anyway, thank you @klonikar for your efforts! You are welcome to come with new contributions!


create 0735-asteroid-collision.go

File(s) Modified: 0735-asteroid-collision.go
Language(s) Used: Go
Submission URL: https://leetcode.com/problems/asteroid-collision/submissions/957161109/

@JSOD11 Thanks for your contributions 👍. Next time, make sure to add all submission links if submitting more than one solution in a PR


PreUpdate is called with an empty ChangeSet after translatable onFlush

I am using Gedmo/Translatable with PersonalTranslation objects.
When only a translatable field of an entity is changed, the PreUpdate listener catches the event but the change set with the changed fields in the entity is empty.

Problem: this is’nt following the specification: preUpdate should only be called with a changeset.
Problem: The issue is not that preUpdate is called without any change of a field in the entity; also when only a translatable field is changed I expect preUpdate is triggered.
Problem: Inside the doctrine package I could trace that on the update event the changeset is correctly detected and stored but then

on flush is triggered: inside this event the translatable listener is called which is ‘changing’ the entity object. This result in a different hash of the entity object
then the pre update listeners are called like mine registered listener. But for this event no changeset is found anymore, because the hash of the object changed, but the changeset is stored in the doctrine package with the objects hash as key.

Maybe this just happens when using the Personal Translation alternative for the respective entity. Because then the translations are a component of the entity and therefore any change in the onFlush event does also change the objects hash.
Suggestion for a solution: why not the id is used as the key inside the collection of change sets?
Thanks for any help and ideas!

This is not the gedmo package but knplabs, so we can't help with this