records.yaml validation on loading

RecordElement has a member for validation of value called regex, it's used when a config is given through traffic_ctl config set command. However, it looks like it's not used when the records.yaml (records.config for 9.2.x) is loaded.
https://github.com/apache/trafficserver/blob/master/src/records/RecordsConfig.cc#L39C14-L39C27
Link: #11110

@masaori335  I can look at this is none else is already looking at it.


Added a draft Integration Guide

The Integration Guide included in this PR provides technical guidelines to our collaborators to link their databases with the DTS.
Closes #56

And I guess we need to wipe JAMO's mouth again! Maybe I'll fix this in the other PR when it makes sense.

Is there anything else that we should do before merging this PR?


Linking failed with cdylib crate

Hello everyone, I am trying to create a cdylib crate to be used as a python library using (pyo3) that has a function that reads from a pinned map.
However, I cannot build giving this error:
note: /"path"/target/release/deps/libbpf_sys-5ebb6e925d9bf342.rlib(libbpf.o): warning: relocation against stderr@@GLIBC_2.2.5' in read-only section .text'
/"path"/target/release/deps/libbpf_sys-5ebb6e925d9bf342.rlib(libbpf.o): relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
So I created a .cargo folder with a config file in it with the following line:
rustflags = ["-C", "link-args=-fPIC"]
This seems to add the flag:
"/home/sebas/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/home/sebas/tese/kollaps-private/communication/target/release/deps/libcommunication.so" "-Wl,--gc-sections" "-shared" "-Wl,-zrelro" "-Wl,-znow" "-Wl,-O1" "-nodefaultlibs" "-fPIC"
But still, the same error appears does anyone know why this might be happening and how to solve it?
Thanks in advance.

@sebastiaoamaro Is there a way you could publish a minimum reproducible example for this? Also, please take a look if the main branch solves your issue, as #183 could be a show stopper here.

Hello, I solved the problem by adding the -fPIC flag to this file https://github.com/foniod/redbpf/blob/main/bpf-sys/build.rs (line 51) and using the dependency locally.

Wow @sebastiaoamaro
You made it!
It guess that you are make something great with cutting edge technologies. I have never used pyo3 to create a python library written in rust. Maybe very few people can achieve what you are trying to create because BPF & rust & python & pyo3 is so rare combination.
And if you have enough time and if you don't mind, please send a PR for this. Perhaps some people in the future would be in trouble with the problem you just fixed.


ImportError: numpy.core.multiarray --- Numpy 2.0.0

Expected behaviour
I am currently using NumPy 2.0.0rc2 in conjunction with the recently released OpenCV <IP_ADDRESS> and have encountered the following error:
Actual behaviour
A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.0rc2 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Traceback (most recent call last):  File "heuristic.py", line 4, in <module>
    import cv2
  File "AppData\Local\Programs\Python\Python312\Lib\site-packages\cv2\__init__.py", line 181, in <module>
    bootstrap()
  File "AppData\Local\Programs\Python\Python312\Lib\site-packages\cv2\__init__.py", line 153, in bootstrap
    native_module = importlib.import_module("cv2")
  File "AppData\Local\Programs\Python\Python312\Lib\importlib\__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
AttributeError: _ARRAY_API not found
Traceback (most recent call last):
  File "heuristic.py", line 4, in <module>
    import cv2
  File "AppData\Local\Programs\Python\Python312\Lib\site-packages\cv2\__init__.py", line 181, in <module>
    bootstrap()
  File "AppData\Local\Programs\Python\Python312\Lib\site-packages\cv2\__init__.py", line 153, in bootstrap
    native_module = importlib.import_module("cv2")
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "AppData\Local\Programs\Python\Python312\Lib\importlib\__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: numpy.core.multiarray failed to import

Steps to reproduce

Windows 11
Python 3.12.3
opencv-python==<IP_ADDRESS>
numpy==2.0.0rc2

Issue submission checklist

[x] This is not a generic OpenCV usage question (looking for help for coding, other usage questions, homework etc.)

[x] I have read the README of this repository and understand that this repository provides only an automated build toolchain for OpenCV Python packages (there is no actual OpenCV code here)

[x] The issue is related to the build scripts in this repository, to the pre-built binaries or is a feature request (such as "please enable this additional dependency")

[x] I'm using the latest version of opencv-python

Kind regards,
Julius Bairaktaris

There is already issue about numpy2 support: #943


FAQ: update information on returning closures

This replaces https://github.com/rust-lang/rust/issues/51289
The closure must also be wrapped in a Box, so that it is allocated on the heap.

at https://www.rust-lang.org/en-US/faq.html#how-do-i-return-a-closure-from-a-function is no longer correct because now it is possible to return a closure without boxing it thanks to the ability to return impl Trait as of https://github.com/rust-lang/rust/pull/49255

now it is possible to return a closure without boxing it thanks to the ability to return impl Trait

But is not possible:
trait MyTrait {
    fn return_closure() -> impl Fn() {
        || { }
    }
}

gives
error[E0562]: `impl Trait` not allowed outside of function and inherent method return types
 --> src/main.rs:2:28
  |
2 |     fn return_closure() -> impl Fn() {
  |                            ^^^^^^^^^


added missing typescript definition

This PR changes : TypeScript Defs
Describe the changes below:
added missing method definition for Phaser.Group.GetAll()

please delete this duplicate PR.


CDP-8328: Add normandie status and knox statuses to Host Details page

Description
Add normandie status and knox statuses to HostBean and hostDAO.getHosts
Associated PRs

deploy-service changes:

https://github.com/pinterest/teletraan/pull/1760
https://github.com/pinterest/teletraan/pull/1763

There might be more places to display status. Worth checking

I had a cursory glance through the code and UI but I couldn't find anything obvious.
Any proposal?


no-buttons appearance does not work with select multiple

https://forum.getodk.org/t/relevance-from-select-multiple-answers-not-triggering-while-inside-field-list-group/43627/13?u=ln

Related: https://github.com/enketo/enketo/issues/164


adding secret validation feature

Is your feature request related to a problem? Please describe.
Gitleaks is actually a great tool and has good options to identify general API keys and passwords with entropy, and I think it will be great if Gitleaks contains secret validations as well, In my opinion, it will be very useful to reduce false positives by eliminating expired and invalid keys. Actually trufflehog has validation feature
Describe the solution you'd like
I think we can add an additional method to do validation of the key at the rule file as trufflehog, And in output, we can add verified: bool value.
It is my opinion that came into my mind, Could you please let me know if you have any plans to include a secret verification feature in your roadmap?
Thanks
cc @zricethezav

This appears to be a duplicate of https://github.com/zricethezav/gitleaks/issues/932 which was closed.
@zricethezav do you have plans to implement something like this? You mentioned in #932 I have some other ideas, but I don't see any open issues tracking your other ideas. Would you care to share them?
I have been using trufflehog scanner for awhile now and in my experience having secret validation is very nice because it reduces the number of false positives, but I think there is still value in reporting on secrets that are not validated to ensure that people know that secrets should not be committed into code. Having the attribute that indicates whether a secret is validated or not does help to prioritize rotating secrets if many secrets are identified.
I think my biggest concern with adding secret validation would be how long it takes. The gitleaks CLI runs significantly faster than trufflehog currently. Adding secret validation could cause significant slow downs. If validation is an optional opt-in feature then that would address that concern.


Home Assistant Add-on

This PR adds home assistant add-on support. It is functional, but still a work in progress.
Adresses https://github.com/DennisOSRM/hms-mqtt-publisher/issues/17
Todo:

update URLs in repository.json and config.yaml
publish data with home assistant discovery support (separate PR for this?)
get mqtt user, pw via bashio
? (Happy to accept feedback)

The pull request looks great. Is there a chance we can add a test or two to verify we don't break it by accident with future changes?

Do you have anything in particular in mind? I'm not sure how to do automatic testing with home assistant add-ons. As long as the rust application runs in the docker image which is referenced in the Dockerfile of the addon, the addon should work as well (given non breaking changes in the CLI). Also, the addon Dockerfile references a specific version of the docker image from this repo, so even with breaking changes in the rust code, the addon keeps working until we manually upgrade it.
I suggest whoever makes changes to the add-on does some manual testing first to ensure everything works as expected. Maybe long term we can also come up with some means of automatic testing. For this we would need:

a docker service emulating a HMS
a docker service running an mqtt server
a docker service running some tests and validates mqtt messages against some predefined schema
Such a test framework would of course also be useful for testing the rest of the codebase

That makes sense. I'll add an issue into the backlog that we add testing. In the meantime we can move ahead here and merge the PR. Once again, great work. Thanks so much.

As mentioned, there are still some other todos. But I  can also address them in a separate PR


P0414R2 Merging shared_ptr changes from Library Fundamentals to C++17

https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0414r2.html

完了


Split CoNLL lines at single tabs

CoNLL should be separated by a single tab.
Some CoNLL files (like the Hamburg Dependency Treebank) are treating words like "New York" as a single form with a space!
The CoNLLReader couldn't read those files.
CoNLL-X Specification defines TAB as the separator:
http://anthology.aclweb.org/W/W06/W06-2920.pdf
References:
HDT: https://corpora.uni-hamburg.de/hzsk/de/islandora/object/treebank:hdt

Looks good. Could you add a test case and add references to the documentation.

[CI: retest]

[CI: retest]

The latest changes removed the need for regression test on the constructor in the corpus.doctest.

@MrOerni Sorry the automated test took some time to fix. Now it's all cleared up.
It LGTM now.

Thanks @MrOerni, @alvations, @jnothman, @dimazest


Adding cpuallocatedwithoverprovisoning to host and hostsformigrationresponse

Description
Fixes https://github.com/apache/cloudstack/issues/4488
Reverts cpuallocated to not consider overprovisioning and adds a new field cpuallocatedwithoverprovisoning which does
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

How Has This Been Tested?
(localhost) 🐱 > list hosts filter=cpuallocated,cpuallocatedwithoverprovisioning, clusterid=56d84816-7594-49ba-99fd-d5c647fb4890 type=Routing
{
  "count": 2,
  "host": [
    {
      "cpuallocated": "1.56%",
      "cpuallocatedwithoverprovisioning": "0.78%"
    },
    {
      "cpuallocated": "3.12%",
      "cpuallocatedwithoverprovisioning": "1.56%"
    }
  ]
}

(localhost) 🐱 > find hostsformigration filter=cpuallocated,cpuallocatedwithoverprovisioning, virtualmachineid=a4dfcf94-76b5-41fc-9ceb-424f0eff5427
{
  "count": 2,
  "host": [
    {
      "cpuallocated": "1.56%",
      "cpuallocatedwithoverprovisioning": "0.78%"
    }
  ]
}

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2426

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2429

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3274)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31320 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4499-t3274-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Mushi123 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Merging code-workflow to master


Submodule depends on Node only package and packager can't find it

In order to avoid code duplication, I have inserted my React/Redux web application inside my React Native directory. This way, I should be able to import the Redux store and use it in my React Native application.
The packager doesn't seem to like the submodule and it's complaining with the following message.

Additional Information

React Native version: 0.44.0
Platform: Both
Development Operating System: MacOS

You can also find the same question (and a couple more details) in the following Stack Overflow link: https://stackoverflow.com/questions/44499428/react-native-submodule-depends-on-node-only-package

The packager is no longer bundled with React Native as of 0.45. Can you open the issue against https://github.com/facebook/metro-bundler instead?


Max negative value on 1st read for accelerometer and gyroscope

Upon reading where it is scaled or not, the data the device on first read is max negative values which is not seen in the Bosch C driver.
Issue is most likely in the below code.
    fn read_register(&mut self, register: u8) -> Result<u8, Self::Error> {
        let mut temp_data = [0u8; 128];
        let mut data = [0u8; 2];
        self.i2c
            .write_read(self.address, &[register], &mut temp_data)
            .map_err(Error::Comm)?;
        for i in 0..data.len() {
            data[i] = temp_data[i + 2];
        }
        Ok(data[0])
    }

    fn read_data<'a>(&mut self, payload: &'a mut [u8]) -> Result<&'a [u8], Self::Error> {
        let mut temp_data = [0u8; 128];
        let address = payload[0];
        let len = payload.len();
        let data = &mut payload[1..len];
        self.i2c
            .write_read(self.address, &[address], &mut temp_data)
            .map_err(Error::Comm)?;
        for i in 0..data.len() {
            data[i] = temp_data[i + 2];
        }
        Ok(data)
    }

Issue resolved by adding in waiting for device to be ready to send data. Added the wait_for_data_ready function to end of the of the configuration setting so that it only has to wait once and is done by the library and not the user.
fn wait_for_data_ready(&mut self, sensor_type: SensorType) -> Result<(), Error<E>> {
    const MAX_RETRIES: u8 = 100;
    let mut retries = 0;

    while !self.is_data_ready(sensor_type)? {
        if retries >= MAX_RETRIES {
            return Err(Error::Timeout);
        }
        self.delay.delay_ms(1);
        retries += 1;
    }

    Ok(())
}

fn is_data_ready(&mut self, sensor_type: SensorType) -> Result<bool, Error<E>> {
    let status = self.read_register(Register::STATUS)?;
    match sensor_type {
        SensorType::Accelerometer => Ok((status & 0b1000_0000) != 0), // Check bit 7 (drdy_acc)
        SensorType::Gyroscope => Ok((status & 0b0100_0000) != 0),     // Check bit 6 (drdy_gyr)
    }
}


#2997: Tools: add questionnaire on package creation

The usual user experience while creating a new package is ask different questions like 'do you want to use eslint?'.
So, we'd want to keep all the existing flags in order not to break things for users, add a --silent flag for people who do not want interactive mode, and ask questions for flags not being specified. So, if one says --eslint - do not ask a question, just use it, otherwise, ask it.

Also, package/folder name should be a question as well. Option chosen by default should 'create  <package_name> folder'.

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16509

Suggest to use https://www.npmjs.com/package/prompts

I don't think we need these options. Why not just use eslint always?

Closing this as not important. Feel free to reopen


typography tsx demos

[x] I have followed (at least) the PR section of the contributing guide.

Typography Part of #36367

@hbjORbj kindly review thanks


hrefmean vs. s4gempak use case broken

The QPF example using conf file hrefmean-vs-s4gempak.conf is now broken. Need to get this use case working again.

Fixed daily file mode in pcp_combine_wrapper.py and updated conf file for this use case.


[Low] Inheritance in constraint blocks

Hello,
The same example used in readthedocs for inheritance gives an error.
I request you to look into this aspect.
Thank you
@vsc.randobj
class my_base_s(object):

    def __init__(self):
        self.a = vsc.rand_bit_t(8)
        self.b = vsc.rand_bit_t(8)
        self.c = vsc.rand_bit_t(8)
        self.d = vsc.rand_bit_t(8)

    @vsc.constraint
    def ab_c(self):
       self.a < self.b

@vsc.randobj
class my_ext_s(my_base_s):

    def __init__(self):
        super().__init__()
        self.a = vsc.rand_bit_t(8)
        self.b = vsc.rand_bit_t(8)
        self.c = vsc.rand_bit_t(8)
        self.d = vsc.rand_bit_t(8)

    @vsc.constraint
    def ab_c(self):
       self.a > self.b

inst = my_ext_s()
inst.randomize()
print(inst.a)

Output is:
int() argument must be a string, a bytes-like object or a number, not 'rand_bit_t'

This example highlights an interesting case, since the inheriting class is re-defining fields that were previously defined by the base class. I've corrected the operator overloading logic to support re-assigning.


Cannot have two HTML5 backends at the same time

I'm trying to use my own component that has react-dnd as a dependency, and meanwhile, I also use ory-editor as the rich-text editor in my app. In this case, there are two HTML5 backends at the same time and I got the problem. Maybe I need to define DragDropContext on common parent of my own component  and ory-editor, but how can I get the ory-editor without DragDropContext? What would be the best way to fix this?

The best way to fix this would be to pass the backend via the config array during instantiation, and if nothing is passed, use the htmlbackend as default. This is currently not supported and would require a PR. The soonest I can look at it is in 3-4 weeks unfortunately. :(

Am 18.07.2017 um 06:51 schrieb EthanWong<EMAIL_ADDRESS>I'm trying to use my own component that hasreact-dnd as a dependency, and meanwhile, I also use ory-editor as the rich-text editor in my app. In this case, there are two HTML5 backends at the same time and I got the problem. Maybe I need to define DragDropContext on common parent of my own component andory-editor, but how can I get the ory-editor without DragDropContext? What would be the best way to fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

+1 for this also

how can i pass the backend via config? can you please give me an example? thanks

Pass it to new Editor: https://github.com/ory/editor/blob/master/packages/core/src/index.js#L64

Hi @arekkas, I am using Ory and React-Source-Tree in my app, and if possible, I would love a little bit more context on your solution and how to apply it, because I'm still getting the multiple backend error.
gcorne's solution makes sense to me (https://github.com/react-dnd/react-dnd/issues/186) because he's creating one instance of the dragAndDrop Context export default DragDropContext(HTML5Backend) and uses that HOC to decorate his components and pass the context.
When I look at Ory's source code for the editor, the backend is passed to the constructor as so     this.dragDropContext = dragDropContext(dragDropBackend || dndBackend)
.So this is the implementation I understand that is possible (and please let me know if I'm making a mistake).
  plugins: editorPlugin,
  editables: [createEmptyState()],
  dragDropBackend: HTML5Backend,
})

However, does that solve the issue? It seems to me that no matter what, we are still creating a new context for dnd? Or perhaps there is something about the backend that I pass that I'm misunderstanding (because in this example, I'm strictly repeating dndBackend, the fallback dragDropBacken).
Thanks for your help!

When you import the backend, it creates a new instance which is probably causing your error. Make sure you import HTML5Backend only once.

Internally, ory-editor is importing the backend. Isn't it causing the "Cannot have two HTML5 backends at the same time" error?
Is there any other way so that we can implement reactdnd for our other feature, along with ory-editor?

I used editor with react-sortable-tree. Any suggestions?

I have the same problem? How to resolve it?

When you import the backend, it creates a new instance which is probably causing your error. Make sure you import HTML5Backend only once.

actually, it exports a function that creates a new backend. Maybe you refering to an older version? Also the version used in ory editor looks quite old, maybe an upgrade would help?


Add Environment Key for Read-only member does nothing (no warning)

Version: Master 0506
Steps to Reproduce:

Authenticate
Create environment and add a user in read-only mode
Log in as that user and try to add an environment API key

Results:
Nothing happens
Expected:
Should get a error/warning message saying it's not allowed

#1990


Enable source generators in Sandbox.

What does the pull request do?
Enables source generators in Sandbox for easier development.

You can test this PR using the following package version. 11.0.999-cibuild0033802-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Added group_config.yaml into Dockerfile

Description
The resulting image should contain group_config.yaml.
Fixes #59
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing steps
Built locally with buildah

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   78.89%   78.89%
=======================================
  Files           7        7
  Lines         199      199
=======================================
  Hits          157      157
  Misses         35       35
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c031127...62c84bb. Read the comment docs.


File collection-object.model.ts is not a module

Now i'm having an other error at step 4.14 :

both/models/party.model.ts (1, 34): File 'both/models/collection-object.model.ts
' is not a module.

Any reason why i have that error ? and how to resolve it ? I'm following the tuto step by step !

It usually means that you don't export anything from this module (export ...).
Also please post issue related to the tutorial here https://github.com/Urigo/meteor-angular2.0-socially


Add instructions for CoAP CLI

ENHANCEMENT

Describe the enhancement you are requesting.
Currently our documentation recommends using Copper for CoAP testing. Add the information about coap-cli and give the usage example.

Indicate the importance of this enhancement to you (must-have, should-have, nice-to-have).
Must have

@fbugarski any update on this issue? I still see Copper references here instead of our CoAP CLI.


packages are not published on CI build

Executing: "C:/ProgramData/Chocolatey/bin/NuGet.exe" push "D:/a/GitHubMilestoneCleaner/GitHubMilestoneCleaner/BuildArtifacts/Packages/NuGet/GitHubMilestoneCleaner.0.1.0-alpha0004.nupkg" "[REDACTED]" -NonInteractive -Source "https://nuget.pkg.github.com/nils-org/index.json"
MSBuild auto-detection: using msbuild version '<IP_ADDRESS>804' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin'.
WARNING: The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for dotnet, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for NuGet
Unable to load the service index for source https://nuget.pkg.github.com/nils-org/index.json.
Response status code does not indicate success: 401 (Unauthorized).
An error occurred when executing task 'Publish-PreRelease-Packages'.
NuGet: Process returned an error (exit code 1).Publish-PreRelease-Packages Task failed, but continuing with next Task...

re-entering GPR-related secrets fixed this.


In the event of a tie, the compiler should choose the defcal block that appeared last in the circuit, not the first

From the paper:
"At compile-time, specialized defcal declarations are greedily matched with qubit specializations selected before instruction arguments. If not all parameters are specialized, the declaration with the largest number of specialized parameters is matched first. In the event of a tie the compiler will choose the defcal block that appeared first in the circuit."
The tie language is not in the spec, so we should add it. Also with our approach to backend.inc from https://github.com/Qiskit/openqasm/pull/184 we should switch to prioritizing the last block that appeared in the circuit. That way users can override definitions provided by the backend.

👍


Structs and shallow copy

Structs are copied on assignment. When a struct is assigned to a new variable, all the data is copied, and any modification to the new copy does not change the data for the original copy. This is important to remember when working with collections of value types such as Dictionary<string, myStruct>.
I found this line confusing since it does not mention anything about shallow copy and when we use List or Dictionary inside structs they will indeed be shallow copied. Maybe rephrasing the above mentioned paragraph would be better. Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b58203aa-f1ff-0741-72a7-dd865a69b08a
Version Independent ID: 35ebe8a9-4465-280e-082c-b3f74d031ac0
Content: Structs - C# Programming Guide
Content Source: docs/csharp/programming-guide/classes-and-structs/structs.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for writing this @tchawla8 We should add more clarification here.
I've added it to our backlog to update when we next update this article.


Fix the Helm exporter blogpost

I'm not so sure of the second post, it removes the step of helm dep build but introduces the step of helm init -c (i-e two invocations of helm init in the same doc). We could avoid that if we move the instructions for setting up helm before exporter command but that's a big change and I'm not sure if Chef folks will be good with that.

PTALA.


Error in the machine learning pipeline illustration?

I just reviewed your illustration of the classical ML pipeline, and I was surprised that you have put the splitting into training- validation- and testing-set so far at the end. My experience is that one always would like to "hide" the test set as soon as possible, ensuring that it never influences any decisions up until the final testing and scoring of your model(s). Scaling and feature engineering should definitely be done without access to the test set, and arguably even the EDA-step.

Thanks for sharing your experience and the insightful comments. You are correct that Test data should be created and curated independently so that it is representative of what you would observe during deployment. The Train and Validation data sets certainly belong near the end just prior to the learning algorithms. The Test data would need to have the same scaling as the training sets. The Test data also has some type of gross error detection and cleansing to eliminate outliers. If additional features are created for the Training and Validation then they will also need to be created for the Test set. A more correct chart would have a reduced data preparation flow chart after the Learning to curate the Test data.


Since Yammer is changed to Viva Engage, The content in learning pathways is still referring to Yammer.

Learning Pathways version number : <IP_ADDRESS>
Yammer is changed to Viva Engage, but still there are references and content about Yammer in learning pathways.
Since the solution is being used in prod many users are raising concerns about the confusion between Yammer and Viva Engage.
Please refer the screenshot below.

Please provide a solution for this.

Hi @PanchamiM ,
Thanks for bringing this to our attention.
@dcashpeterson
Can you please check with the content team regarding this content update? Thanks!

Is there any communication link or POC for that. It would be helpful

@jhwang-ms is this something that we can add to the next round of content updates?

@dcashpeterson yes, we can definitely look at updating this in our next round. Thank you!

@PanchamiM Thanks for info on this. I have relayed it to the content team. We will look at getting this updated in the next round of updates.

Thanks

@dcashpeterson May I know how long will it take to reflect the changes.

Any update on this?

We plan on updating this in our August update, planned for the end of the month.

done


Authenticated Request

For some usecases, it is good to have a simple check if a user us authenticated or not. The request should take the standard Authentication Object as request Object and return a Standard Response Object, as the return information (Code + Message) suffices to verify the response.
This change will include an API update !

With the last commit, this new feature should be complete. Closing issue.


Check return value of getpwuid_r.

This adds a check for the return value when calling getpwuid_r.
There are situations where getpwuid_r returns non-zero on error, and also situations where it returns 0 but sets the result pointer to NULL. The former case was not being handled, but the latter case was. However if you're (un)lucky, getpwuid_r will return non-zero, but the pointer still happens to be null, in which case this issue won't be noticed.
This situation came up when running a statically linked binary inside a FROM scratch Docker container, where there's no /etc/passwd file.
Here's a repo that demonstrates the bug and the fix: https://github.com/adeschamps/whoami-bug

@adeschamps Thanks, this looks good!

@adeschamps @bowlofeggs I just released whoami 1.1.3 with this bug fix.


Feature request: table name color in editor

Hey, like on TOAD for exemple, when I type a table name in the schema it changes is color. It's very good when I have a very long query with many joins

Agreed, this would be handy.
Although it is not so easy because we'll need to cache all database table names when opening a SQL editor.

So TOAD caches all database table names?!That seems to be 'a big price to pay' just to have the color

@jpina10 that would explain why TOAD is so freaking slow :)

Potentially this could be implemented without full table list load. Property SQL semantic analysis + table name cache might solve this.
We have SQL analysis improvement in plans. But it is much bigger feature than just table name highlighting.
TOAD needs to know only PL/SQL while DBeaver will need to understand all existing SQL dialects.

@jpina10 that would explain why TOAD is so freaking slow :)

I have the 10.1 version and it's really fast. Dbeaver has a lot more features that is why I'm willing to change

Really? I have used versions from 9 to 12, and opening a new editor or worse, a new object explorer, to not talk about a new connection, the whole ui is locked for seconds while dbeaver is almost istantaneous. Moreover, TOAD excels in how it is able to crash or go in a deadly freeze from which it never wakes up.
I still miss some of TOAD dbadmin features (there are open issues for most of them, but I understand those are not priority goals for dbeaver since those would be features tied to a single database), but I strongly prefer dbeaver because it feels way faster and it's amazingly more user-friendly when querying and editing data :smile: .

This would be tremendously helpful in a project I'm running right now. So much so that I'm actually considering finding a new IDE, even though I love DBeaver.

Seriously that there is no evolution on this since 2018?
This is VERY useful and a common feature on many other SQL tools.
It shoud have more traction than that...

It's done in https://github.com/dbeaver/dbeaver/pull/21788 and will be available in the next release (DBeaver 23.2.5)
The feature is turned off by default, you can enable it here

Done in scope of this issue #10831


Circos error within bakta

As part or testing the pipeline with a larger dataset and more realistic files. It seems like one of the samples produced an assembly with lots of contigs. Based on the issue here: https://github.com/oschwengers/bakta/issues/174 this could cause circos to clog.  I am testing if adding the --skip-plot flag actually helps.
Oct-11 20:03:40.398 [Task monitor] ERROR nextflow.processor.TaskProcessor - Error executing process > 'NFCORE_PATHOGENSURVEILLANCE:PATHOGENSURVEILLANCE:GENOME_ASSEMBLY:BAKTA_BAKTA (H1_10_30-2_S99)'

Caused by:
  Process `NFCORE_PATHOGENSURVEILLANCE:PATHOGENSURVEILLANCE:GENOME_ASSEMBLY:BAKTA_BAKTA (H1_10_30-2_S99)` terminated with an error exit status (1)

Command executed:

  bakta \
      H1_10_30-2_S99_filtered.fasta \
      --force \
      --threads 4 \
      --prefix H1_10_30-2_S99 \
       \
       \
      --db db-light

  cat <<-END_VERSIONS > versions.yml
  "NFCORE_PATHOGENSURVEILLANCE:PATHOGENSURVEILLANCE:GENOME_ASSEMBLY:BAKTA_BAKTA":
      bakta: $(echo $(bakta --version) 2>&1 | cut -f '2' -d ' ')
  END_VERSIONS

Command exit status:
  1

Command output:
        discarded spurious: 15
        detected IPSs: 0
        found PSCCs: 0
        lookup annotations...
        filter and combine annotations...
        filtered sORFs: 0
  detect gaps...
        found: 115
  detect oriCs/oriVs...
        found: 1
  detect oriTs...
        found: 0
  apply feature overlap filters...
  select features and create locus tags...
  selected: 14391
  improve annotations...
        revised gene symbols: 0

  genome statistics:
        Genome size: 13,369,953 bp
        Contigs/replicons: 20891
        GC: 64.2 %
        N50: 1,121
        N ratio: 0.1 %
        coding density: 50.6 %

  annotation summary:
        tRNAs: 106
        tmRNAs: 1
        rRNAs: 3
        ncRNAs: 27
        ncRNA regions: 22
        CRISPR arrays: 0
        CDSs: 14116
                hypotheticals: 9749
                pseudogenes: 0
                signal peptides: 0
        sORFs: 0
        gaps: 115
        oriCs/oriVs: 1
        oriTs: 0

  export annotation results to: /nfs1/BPP/Grunwald_Lab/home/paradarc/pathogensurveillance/work/c0/b4330e92b8805ce2508a106c25313e
        human readable TSV...
        GFF3...
        INSDC GenBank & EMBL...
        genome sequences...
        feature nucleotide sequences...
        translated CDS sequences...
        circular genome plot...

Command error:
        found: 1
  detect oriTs...
        found: 0
  apply feature overlap filters...
  select features and create locus tags...
  selected: 14391
  improve annotations...
        revised gene symbols: 0

  genome statistics:
        Genome size: 13,369,953 bp
        Contigs/replicons: 20891
        GC: 64.2 %
        N50: 1,121
        N ratio: 0.1 %
        coding density: 50.6 %

  annotation summary:
        tRNAs: 106
        tmRNAs: 1
        rRNAs: 3
        ncRNAs: 27
        ncRNA regions: 22
        CRISPR arrays: 0
        CDSs: 14116
                hypotheticals: 9749
                pseudogenes: 0
                signal peptides: 0
        sORFs: 0
        gaps: 115
        oriCs/oriVs: 1
        oriTs: 0

  export annotation results to: /nfs1/BPP/Grunwald_Lab/home/paradarc/pathogensurveillance/work/c0/b4330e92b8805ce2508a106c25313e
        human readable TSV...
        GFF3...
        INSDC GenBank & EMBL...
        genome sequences...
        feature nucleotide sequences...
        translated CDS sequences...
        circular genome plot...
  Traceback (most recent call last):
    File "/nfs1/BPP/Grunwald_Lab/home/paradarc/pathogensurveillance/work/conda/env-a426d411c02c15e446ce4ad992ac0c99/bin/bakta", line 10, in <module>
      sys.exit(main())
               ^^^^^^
    File "/nfs1/BPP/Grunwald_Lab/home/paradarc/pathogensurveillance/work/conda/env-a426d411c02c15e446ce4ad992ac0c99/lib/python3.11/site-packages/bakta/main.py", line 562, in main
      plot.write_plot(features, contigs, cfg.output_path)
    File "/nfs1/BPP/Grunwald_Lab/home/paradarc/pathogensurveillance/work/conda/env-a426d411c02c15e446ce4ad992ac0c99/lib/python3.11/site-packages/bakta/plot.py", line 259, in write_plot
      raise Exception(f'circos error! error code: {proc.returncode}')
  Exception: circos error! error code: 255

Work dir:
  /nfs1/BPP/Grunwald_Lab/home/paradarc/pathogensurveillance/work/c0/b4330e92b8805ce2508a106c25313e

Tip: view the complete command output by changing to the process work dir and entering the command `cat .command.out`

I disabled the plotting for now. We should try running bakta with the --debug option to see what the circos error is in case it is an easy fix.

I reran this with --debug and indeed the issue is that there are more than 10,000 contigs, and circos is made to throw an error when that happens. I dont see a way to change that limit using bakta commands, so I think just disabling the plot, like has already been done, should be good enough. If we need a circos plot, we can make our own when the report is made.
debuggroup summary 1.98s karyotype has 20891 chromosomes of total size 13,390,844

  *** CIRCOS ERROR ***

      cwd: /tmp/tmp1e0sf6lf

      command: /home/fosterz/miniconda3/envs/bakta/bin/circos -conf
      /tmp/tmp1e0sf6lf/circos/main.conf

  You have asked to draw [20891] ideograms, but the maximum is currently set at
  [10000]. To increase this number change max_ideograms in
  etc/housekeeping.conf. Keep in mind that drawing that many ideograms may
  create an image that is too busy and uninterpretable.

  If you are having trouble debugging this error, first read the best practices
  tutorial for helpful tips that address many common problems

      http://www.circos.ca/documentation/tutorials/reference/best_practices

  The debugging facility is helpful to figure out what's happening under the
  hood

      http://www.circos.ca/documentation/tutorials/configuration/debugging

  If you're still stumped, get support in the Circos Google Group.

      http://groups.google.com/group/circos-data-visualization

  Please include this error, all your configuration, data files and the version
  of Circos you're running (circos -v). Do not email me directly -- please use
  the group.

  Stack trace:
', stderr=' at /home/fosterz/miniconda3/envs/bakta/bin/../lib/Circos/Error.pm line 425, <F> line 20891.
        Circos::Error::fatal_error("ideogram", "max_number", 20891, 10000) called at /home/fosterz/miniconda3/envs/bakta/bin/>
        Circos::run("Circos", "_argv", "-conf /tmp/tmp1e0sf6lf/circos/main.conf", "configfile", "/tmp/tmp1e0sf6lf/circos/main>
'
19:21:43.377 - WARNING - PLOT - Circos failed! circos-error-code=255

done


Build script: no local biblio, use only Specref ids

no localBiblio
all external references use Specref IDs
Fix for "normally" indented ## Version x.y.z - no longer expect #### Version x.y.z

Note: this needs to be merged before we can publish the cleaned-up 3.0.4.md

We agreed that we need a bit more context in the code comment about why this section is special.

@handrews Please tell me if I need to add comments or explain more


Checkboxes broken on mobile

Originally created by Tom Smyth at 2015-08-16 20:43, migrated from redmine-#2861

Priority changed from 4 to 3

By Tom Smyth at 2015-08-19 07:19

Status changed from New to Closed

By Tom Smyth at 2015-08-23 07:57


literal_as_bytes in backend does not account for struct default values => crash

struct Foo {
   x: u8 = 10,
}

static F: Foo = Foo {};

proc main() {
   print(int_to_string(F.x as i64));
}

Fixed by removing struct default values for now


Some character looks values aren't split correctly

Originally reported on:
https://github.com/chenasraf/dungeon-paper-app/issues/5
Some looks options are a single option rather than multiple. The JSON source data needs to be updated.

Fixed in dde9bca3abbde9be0bbe189ed767edada0478a8c


Add Google-Keep

This is unofficial Google Keep client
They have a deb available from their website.
https://github.com/andrepolischuk/keep/releases/download/v0.1.10/keep_0.1.10_amd64.deb

Sorry, we are only accepting software that is actively maintained/released. Please see:

Add guidelines for what packages are acceptable for inclusion


Show compressed file content, like Understand does for the Java standard library

Replicate:

Open the sample project TheAlgorithms
Open the file DataStructures/DynamicArray/DynamicArray.java
Go to the definition of Iterable
A file opens which VS Code doesn't find \Program Files\Java\jdk-17.0.2\lib\src.zip{java.base\java\lang\Iterable.java}

Possible fix:

Add a URI handler into the language server which will unzip the file and show the contents as read-only

See https://github.com/microsoft/vscode/issues/75559


adds secondary_parent=... to parent.config

does not yet provide ability to add secondary parent cachegroups thru UI


feat(gateway): support for docker secrets

Addition to #5031

Fixed SC2155 and SC2046 warnings in docker-init.sh from static-analysis / global-linter.

@Taner314 Thanks for the contrib! Thanks also for using the contrib branch, that allows us to test / inspect any contributions before they hit main.


PI: Itars doesn't have automatic 1pw?

?
If you're referring to the autoleech, randomboolean (rdk) made the remark that sometimes they want to keep tokens in area 2 in order to be able to burn them, so that they land in the gaia area and they can gain tech tiles.

I see. Line 366 in engine.ts. Why round<6 ?

Because there's no gaia phase after round 6, so it's useless to put tokens in gaia area.


[6.1.1] Missing getFormSyncErrors in index.js

Hy guys ! Good job for the awesome work !!!
Just a little mistake in the release 6.1.1. I think, getFormSyncErrors is missing in index.js

Fixed in v6.2.0.


get_parent_terragrunt_dir is broken with multiple include blocks

With the addition of multiple include blocks, the get_parent_terragrunt_dir function stops working.
Example terragrunt.hcl:
terraform {
  source = "git@github.com:xxxxxxxxxx//eks-cluster?ref=eks-cluster_v1.1.15"
}

prevent_destroy = true

dependency "vpc_peering_1" {
  config_path = "${get_parent_terragrunt_dir()}/account/us-east-1/_global/devops/vpc-peering/my-peering"

  skip_outputs = true
}

include "root" {
  path           = find_in_parent_folders()
  merge_strategy = "deep"
}

include "module" {
  path           = "${dirname(find_in_parent_folders())}/_common/eks-cluster.hcl"
  merge_strategy = "deep"
}

Error:
$ terragrunt plan
ERRO[0000] /account/us-east-1/dev/devops/eks-cluster/main/terragrunt.hcl:8,20-46: Error in function call; Call to function "get_parent_terragrunt_dir" failed: Expected 1 params for function path_relative_from_include, but got 0., and 1 other diagnostic(s)
ERRO[0000] Unable to determine underlying exit code, so Terragrunt will exit with error code 1

Ah this is because when using multiple include blocks, which parent dir you are referring to is ambiguous. You need to pass in the include block name you want the parent dir of, either root or module in your example. E.g., get_parent_terragrunt_dir("root").
Side note: I thought this was mentioned in the docs, but I just checked and noticed it is missing... Will be opening a PR to address that.

@yorinasub17 that solved the issue, thanks!


doc: Update Zephyr SDK install instructions to use code-blocks

I was going through the getting started documentation and noticed that some commands for installing the Zephyr SDK were not being shown correctly.
I created this commit to fix that.
I tested this by generating the HTML documentation locally.

See https://github.com/zephyrproject-rtos/zephyr/pull/67603#discussion_r1455043627 for more context. It would be awesome if you find a solution though, as it definitely bothers me too that these blocks render differently and don't have the handy "copy" button.

That's a good point. I hadn't seen the substitution part working.
From searching a bit, I found a different project that supports substitutions in code-block directives (https://github.com/adamtheturtle/sphinx-substitution-extensions).
But before I explore that direction, maybe it would be a good idea to update doc/conf.py to do SDK version related substitutions using python.

I am not sure if I am going in a good direction with this. So, I made a work-in-progress commit. Please feel free to provide feedback if you get a chance. Thanks! :v:

Thanks for letting me know! I do not have any other ideas beyond this for the time being. Should I move this pull request to draft or close it?

Closing, as current solution is good enough and we don't want Python hackery into the build pipe.


deploy: add README, fix typos

The csi-hostpath-snapshotter.yaml was misspelled when creating the
file. The upstream driver-registrar RBAC file uses
"csi-driver-registrar" as service account name and therefore the
hostpath plugin should also use that instead of the (now obsolete)
"csi-node-sa" name from the Kubernetes E2E testing.
This dependency on the upstream RBAC rules should be mentioned. For
the sake of avoiding yet another copy of URLs the new README just
refers to other documentation.
/cc @vladimirvivien

This blocks the merging of https://github.com/kubernetes/kubernetes/pull/71703 because I need an upstream copy of the hostpathplugin .yaml that works with the upstream driver-registrar RBAC .yaml.

/lgtm

@saad-ali, @lpabon can one of you approve, please?


Improve documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
82

Relevant Lines:
82

💛  - Coveralls


Integrate build process into scaffolded applications

Utilize esri-wab-build to enable the npm run build command on applications scaffolded using the generator.

Completed.


Json schema for vendir spec

Describe the problem/challenge you have
It would be convenient to have coding assistance from IDE when reading/editing a vendir.yaml file
Describe the solution you'd like
Formatting the https://carvel.dev/vendir/docs/v0.34.x/vendir-spec/ as a https://json-schema.org/ and registering it into https://www.schemastore.org/json/ would automatically enable most recent IDEs (e.g. intellij, vscode) to automatically provide:

inline doc
completion
static analysis

Anything else you would like to add:
[Additional information that will assist in solving the issue.]

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

@gberche-orange Thank you for raising this request. Sounds good to have this.

Going to accept this issue.
We can add this directly into schemastore or host it in carvel.dev. My first inclination would be to host it in carvel.dev and just register that URL.
Another thing that could be interesting is to find a way to do this automatically. I saw there are a couple of libraries that generate the jsonschema directly from go structs maybe that is something that can be explored, we might need to add some docs on our structs to help with this but apart from that, it should be pretty simple.
In the first iteration, we can just add the schema manually, but it would be great if we find a way to do this automatically with our release process.


Linear and Binary Search in Java Data Structures and Algorithms.

Linear and Binary Search in Java Data Structures and Algorithms
Introduction
In the world of programming languages, data structures and algorithms are key problem-solving skills that all engineers must-have. Linear and Binary Search are required when there is a problem with sorted arrays in Java or any other language. So, in this article, I will be sharing the ways of utilizing the methods in interview questions.
Key takeaways:
In the end, readers would have knowledge of the following concepts;

what are data structures and algorithms in Java.
when and how to use linear search.
concepts of binary search in sorted java arrays problems.
solutions to interview questions provided from Leetcode.

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Yes sir.

Hi @Horlawhumy-dev
This sounds like a good DSA article and I have no doubt it would be super helpful. Please make sure to provide more content that is original. There are many DSA articles on the web like this one so please keep that in mind. Also check that it does not conflict with content already on section.

Sure and I am promising to make it quite a helpful DSA article.


How to center screen on a specific hex?

I assume the Layout.origin should be used, but I can't seem to figure out the correct units to set it to. I currently have
const [hexagons, setHexagons] = useState(GridGenerator.hexagon(3));
...
<HexGrid width={windowWidth} height={windowHeight}>
  <Layout
    size={{ x: hexSize, y: hexSize }}
    flat={true}
    origin={{ x: -10, y: 0 }}
  >
    {hexagons.map((hex, i) => (
      <Hexagon key={i} q={hex.q} r={hex.r} s={hex.s} fill={'black'} />
    ))}
  </Layout>
</HexGrid>

Any help would be appreciated!

try to use the viewBox prop on the HexGrid. The HexGrid is basically a svg component and the following default props
  width = 800,
  height = 600,
  viewBox = "-50 -50 100 100",

the first two values of the viewBox should allow you to "position" your element. I dont yet understand svg enough to explain it properly, but hope this helps


crypto channel: curveCP

CurveCP is similar to TCP but uses high-speed high-security elliptic-curve cryptography to protect every packet against espionage, corruption, and sabotage. The cryptographic tools used in CurveCP are the same as the cryptographic tools used in DNSCurve. CurveCP was announced at the 27th Chaos Communication Congress on 28 December 2010.

I've been researching and learning about CurveCP and I'm currently trying the actual state of the project. The Alpha was released on Fev 2011 and since then, I haven't find any more updates on it. Is there anyone watching very familiar with the state of the project and who is currently actively contributing to it?
Reference Links:

http://curvecp.org/
1st announcement (with DNSSec intro) http://cr.yp.to/talks/2010.12.28/slides.pdf

Closing due to (extreme) staleness.  If this is still relevant perhaps it can be picked up by ResNetLab.


Changed results horizontal table schema to vertical table schema.

クエリの結果ウィンドウで表示されるスキーマを横から縦に変更してみました。

First of all, thank you for sending me the PR 🚀
The code itself in this PR is good.
I would appreciate it if you could explain in the PR why horizontal table is not good or why vertical table is necessary, which cannot be expressed in the code.
Because after merging this PR, if a PR comes in that says, for example, "Changed the schema table from vertical to horizontal", I will not be able to decide whether I should merge that PR or not.

For example, but one reason I can think of is something like, "If we add a description column to the schema in the future, the vertical table should be easier to read".

Thank you for your explanation.
The purpose of this addition was to improve visibility even when there were many rows.
Also, as you say, I implemented it because I thought it would be easier to see if I added a description column.

Thank you for your review
I understood what you meant, so I fixed it.

Released as v1.12.0 🎉
FYI, there was another feature released at the same time that allowed multiple tables handled in child jobs to be displayed as separate table tabs, and the schema tab was merged into the table tab because of that.


[TRANSLATION FIX] Cabinet des murmures

Adjusted a tag issue in the translation system

Character Sheet Info Roll20 Internal Use only.


fork

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 97.561%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
1000

Relevant Lines:
1025

💛  - Coveralls


No such file or directory ReactAndroid/TEST_DEFS

IOError: [Errno 2] No such file or directory: '/xxx/yyy/zzz/react-native/ReactAndroid/TEST_DEFS'

Steps to Reproduce / Code Snippets
buck test ReactCommon/cxxreact/tests
Additional Information

React Native version: master
Platform(s) (iOS, Android, or both?): Android
Operating System (macOS, Linux, or Windows?): Mac

Bucks tests are generally working now so I think I should close this issue.


Custom framerate not applying

Known bug. I think I found the issue.
Thanks Namco.

Attempt 1 is on Release 1.1.1

Attempt 1 is on Release 1.1.1

still not working with 1.1.1

still not working with 1.1.1

I am aware, I did found what is the actual cause, from what I see.

Fixed in 1.2.0


Cannon.js Imported Terrain

Is there a way to have the vehicle raycast on an imported 3d terrain rather than creating a matrix of random numbers?

Instead of random numbers, i did the following:
I created a height field in blender then extracted the height values as an array of arrays (with the help of a python script) in a way that i was able to paste it into my js function.
https://github.com/tomo0613/offroadJS

open Blender
create a plane [square]
add some loop cuts (maintain an evenly divided grid)
align the heights of vertices (to form a terrain)
execute the python script, copy the output to your JS

@baronwatts
If still interested here's a function that basically does that:
I did some experiments (same repo)
note:

the blender part from above is still relevant except the .py script
not 100% accurate (check the comments)
avoid negative heights (otherwise you might face this issue)

function meshToHeightField(mesh) {
    const geometry = findGeometry(mesh);
    // positions coordinates are stored in a THREE.Float32BufferAttribute (array buffer [c0.x,c0.y,c0.z,c1.x, ...])
    const vertices = mapPositionBufferToVertices(geometry.getAttribute('position'));
    // if the the plane width equals to its length
    const rowCount = Math.sqrt(vertices.length);
    const columnCount = rowCount;

    geometry.computeBoundingBox();

    const minX = geometry.boundingBox.min.x;
    const maxX = geometry.boundingBox.max.x;
    const minZ = geometry.boundingBox.min.z;
    const maxZ = geometry.boundingBox.max.z;
    const gridWidth = maxX - minX;
    const gridLength = maxZ - minZ;
    // the scale is bit off, so it needs some adjustment (+ 0.1585)
    const gridElementSize = gridWidth / columnCount + 0.1585;

    // create grid
    const grid = [];
    for (let rowIndex = 0; rowIndex < rowCount; rowIndex++) {
        const row = [];

        for (let columnIndex = 0; columnIndex < columnCount; columnIndex++) {
            const vertexIndex = rowIndex * rowCount + columnIndex;
            const vertex = vertices[vertexIndex];

            row.push(vertex.y);
        }

        grid.push(row);
    }

    // create heightField from grid
    const heightFieldShape = new CANNON.Heightfield(grid, {elementSize: gridElementSize});
    const heightField = new CANNON.Body({mass: 0, shape: heightFieldShape});

    const q1 = new THREE.Quaternion();
    q1.setFromAxisAngle(new CANNON.Vec3(0, 0, 1), -Math.PI / 2);
    const q = new THREE.Quaternion();
    q.setFromAxisAngle(new CANNON.Vec3(1, 0, 0), -Math.PI / 2);
    q.multiply(q1);

    heightField.quaternion.copy(q);
    heightField.position.set(
        -gridWidth / 2,
        0,
        gridLength / 2 - gridLength,
    );

    return heightField;

    function findGeometry(mesh) {
        let geometry;

        mesh.traverse((child) => {
            if (!geometry && child.type === 'Mesh' && child.geometry) {
                geometry = child.geometry;
            }
        });

        return geometry;
    }

    function mapPositionBufferToVertices(positionBuffer) {
        const vertexArray = [];
        const vertexCount = positionBuffer.count;

        for (let i = 0; i < vertexCount; i++) {
            vertexArray.push(new THREE.Vector3(
                positionBuffer.getX(i),
                positionBuffer.getY(i),
                positionBuffer.getZ(i),
            ));
        }
        // vertices in a mesh are not in order, sort them by x & z position
        vertexArray.sort((a, b) => {
            if (a.z === b.z) {
                return (a.x < b.x) ? -1 : (a.x > b.x) ? 1 : 0;
            } else {
                return (a.z < b.z) ? -1 : 1;
            }
        });
        // filter duplicated vertices
        return vertexArray.filter((vertex, index) => {
            const nextVertex = vertexArray[index + 1];
            const duplicated = nextVertex
                && vertex.x === nextVertex.x
                && vertex.y === nextVertex.y
                && vertex.z === nextVertex.z;

            return !duplicated;
        });
    }
}

this is the way:

how it works?: cast rays upwards from below the mesh to calculate the height values
why async?: ray casting can be slow, if used with a large {mesh}, or low {pointDistance} it will block the browser (i tried to use it from a worker but neither the mesh can be passed to the worker. nor it can be imported in the worker)
how to use?: (as you want) in general you only want to calculate the height values if the mesh was edited, then print the value of {heightMap} and copy to a variable or store it as JSON, than use that like a static value to create your Heightfield().

async function generateHeightfieldFromMesh(mesh/*: Mesh*/, pointDistance/*: number*/) {
    // https://threejs.org/docs/index.html#api/en/core/Raycaster
    const rayCaster = new THREE.Raycaster();
    const rayCasterPosition = new THREE.Vector3();
    const upAxis = new THREE.Vector3(0, 1, 0);

    const heightMap = [];

    const geometry = findGeometry(mesh);
    geometry.computeBoundingBox();
    const {
        min: {x: minX, y: minY, z: minZ},
        max: {x: maxX, z: maxZ},
    } = geometry.boundingBox;

    const width = maxX - minX;
    const length = maxZ - minZ;

    const totalX = width / pointDistance + 1;
    const totalZ = length / pointDistance + 1;
    const totalSteps = totalX * totalZ;
    let currentStep = 0;

    for (let x = minX; x <= maxX; x += pointDistance) {
        const heightDataRow = [];
        heightMap.push(heightDataRow);

        for (let z = maxZ; z >= minZ; z -= pointDistance) {
            rayCasterPosition.set(x, minY, z);
            rayCaster.set(rayCasterPosition, upAxis);

            const y = await calculateMeshSurfaceDistanceByRayCast();

            heightDataRow.push(y);
        }
    }

    const terrainShape = new CANNON.Heightfield(heightMap, {elementSize: pointDistance});
    const heightfield = new CANNON.Body({ mass: 0, shape: terrainShape });
    heightfield.quaternion.setFromAxisAngle(new CANNON.Vec3(1, 0, 0), -Math.PI / 2);
    heightfield.position.set(
        -width / 2,
        0,
        length / 2,
    );

    return heightfield;

    function calculateMeshSurfaceDistanceByRayCast() {
        return new Promise((resolve) => {
            window.setTimeout(() => {
                currentStep++;

                console.log(`generating height field... ${Math.floor(100 / totalSteps * currentStep)}%`);

                const [result] = rayCaster.intersectObject(mesh, true);

                resolve(result.distance);
            });
        });
    }
}

https://github.com/Loryhoof/Mesh2Heightfield
I hope this can help someone, its based on @tomo0613 's OffroadJS


PEP 517 interface (build_meta) should not specify wheel and setuptools in build dependencies

From pypa/pep517#15.
Quoting @takluyver’s comment:

I think that what you hit is a bug in the setuptools build backend: I don't think it should be returning the values from build-system.requires at all. The spec says that the get_requires_for_build_* hooks should return:

an additional list of strings containing PEP 508 dependency specifications, above and beyond those specified in the pyproject.toml file

To me, that means that the backend shouldn't include the build-system.requires values, because the frontend should have already found those before calling the hook.

Setuptools at the moment does not have a TOML parser. To resolve this though we would need to vendor one into it though.

I don't think this needs setuptools to parse TOML. The frontend gets the build-system.requires from the TOML file and installs those. Then it calls the build system to ask for additional build requirements. In setuptools' case, that should be whatever is specified in setup_requires.

(Though if setuptools isn't currently reading the TOML file, I must have misunderstood where this issue is coming from)

setuptools does not read the file, so always responds with setuptools and wheel. It's hardcoded. To be able to know what additional it needs to specify it would need to do so though.

What happens if setup_requires lists setuptools itself? Does setuptools automatically drop it? What happens if the currently-installed setuptools does not match it?

Wasn't this effectively fixed by #1594? It removed setuptools from the list of build dependencies, and while it didn't remove wheel, I don't think wheel should be removed anyway, as it is a requirement for building wheels.


Sawtooth SDK for .NET Core

This is a full implementation of the SDK for .NET Core 2.0.
The SDK provides complete Signer, Processor and State Delta support.
An implementation for IntKey example is also provided as Processor as well a Client tool that can be run to make sample transaction calls.
I've added docker images and build scripts accordingly following the standard syntax, taking example from the existing scripts and languages.
Docker image uses microsoft/dotnet image.
I will be submitting README.md's for the SDK as well as the IntKey processor and cli tool to complement the SDK.

Closing to resubmit with DCO


update nix-shell for flakes

copies the changes from 2b4b2e31d1b180d924a88100ff8967eced932903
should fix the the failing cron.
Probably want to disable hercules for this repo as well?
https://hercules-ci.com/github/nix-community/nixpkgs-terraform-providers-bin

@zimbatm Do you mind if I get commit access to this repo?

with pleasure, thanks for the fix and all of the other work you're doing. It's funny how much overlap there is between our works. Feel free to DM me as well if you want.


Check for mixed use of ndarrays

Checks input/output array types of forward operations.
This PR may be unsafe to backport, because existing functions may be mixing cupy and numpy arrays.
Also, some builtin functions will fail to pass this check. They need to be fixed before this PR.

#4030 needs to be merged before this PR.

jenkins, test this please.

jenkins, test this please.

LGTM!

Note: Not backported due to the fact that e.g. user-defined functions that are using mixed input/output backends will start to fail.


Support calendar properties

Adds the following properties:

name
description
timezone
ttl

Added this to make calendar titles work with Apple Calendar.

I cannot approve, but this looks good. I was actually about to add support for these myself, I have the same need.

Given usefulness of this, a Changelog entry could be worth it.

Thank you @hadronzoo for the contribution. I took the liberty to add conventional commit prefixes to your commits to be able to generate the changelog.

@hoodie I apologize for the late reply. Thank you for merging!


[DESIGN ONLY] Explore ways to make the on-boarding buttons locked at the bottom

Some challenges:

Screen two, where there are three action buttons (primary, secondary and skip)
iPhone SE where much of the screen may be chrome and not much content

I'll park this for now. I discussed with Paul and we now have a task to handle iPhone SE intro screen so it does not require a scroll by default.
https://github.com/project-vagabond/covid-green-app/issues/418


be community build friendly

scalaBinaryVersion isn't always something short like '2.12'

(if this is merged, I can do a followup to https://github.com/scala/community-builds/pull/415 that uses your master branch instead of my fork)

btw maybe this can be done automatically, after https://github.com/sbt/sbt/pull/1799, and custom code for this isn't needed anymore...? you might be able to do better than I've done here, I just did the quick fix.

@alexandru ?

@SethTisue sorry, it's the Holiday season effect :-)

thx. unforked in community build: https://github.com/scala/community-builds/commit/8dccdb09a0f19f8cc1088eaab8ad648362e100e7


Gateway (JSON-API) connections via Tor

Please add support for direct Tor connections into the Gateway (JSON-API).
I tried to set my Gateway as /onion/xxxxxxxxxxxxxxxx:4002 but OB failed at start with the following error:

protocol not found in multiaddr

My temporary solution was to revert to the default Gateway, /ip4/<IP_ADDRESS>/tcp/4002, and point a HiddenService into it on torrc. Does the job, but connecting through OB's dedicated hidden service seems a better solution.
openbazaar-desktop already supports .onion addresses on the "Server IP" field if "Use Tor" is selected.

Hmm. I'm trying to think of the best way to do this. I suppose it could be made to spin up the gateway server as a hidden service but it might require some significant tinkering because the gateway is actually part of the IPFS library.
Maybe an easier way would be to leave the gateway on /ip4/<IP_ADDRESS>/tcp/4002 and then create a hidden service in your torrc file?
HiddenServiceDir /Library/Tor/var/lib/tor/hidden_service/
HiddenServicePort 4002 <IP_ADDRESS>:4002

I think that should work.

Hi @cpacia
Thanks for looking into it.

Maybe an easier way would be to [...] create a hidden service in your torrc file?

As you can read on my post above, that's exactly what I am doing. But IMO it is a workaround and not a definitive solution. As I said, it:

Does the job, but connecting through OB's dedicated hidden service seems a better solution.


FinalizeOverride Test runs despite being excluded

Describe the bug
FinalizeOverride is in the ProblemList exclude file for this release+jvm, but it is still being run.
See here for test run.
See [here}(https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/openjdk/ProblemList_openjdk14-openj9.txt) for the relevant problem list.
To Reproduce
Run nightly sanity.openjdk job like the one here:
https://ci.adoptopenjdk.net/job/Test_openjdk14_j9_sanity.openjdk_ppc64le_linux/123/
Expected behavior
This test is not meant to run at all.
Additional context
The test has been excluded for 2 days, and yet it is still being run.

Excluding the test, and then continuing to run the test in a separate target (jdk_lang_ref_FinalizeOverride_j9) with different options (see https://github.com/AdoptOpenJDK/openjdk-tests/pull/1845) was purposefully done by @pshipton
We can repurpose this issue as jdk_lang_ref_FinalizeOverride_j9 fails issue, @pshipton we would normally exclude non-green tests, is this one intermittent and you are trying to gather data, or shall we also disable jdk_lang_ref_FinalizeOverride_j9 ?

It's a trade off. Although the test fails intermittently, it could still catch another real problem if it started failing more frequently or always. Although it shouldn't, excluding might have the side affect of de-prioritizing the work to fix it.

Maybe we could move it to special category? So it could run daily and not block the sanity?

good plan @sophia-guo - let's do that!

Closing this as it is intended to continue to run the test and it has been moved to special.openjdk via https://github.com/AdoptOpenJDK/openjdk-tests/pull/1863


Missing docs for IntoParam

#1081 implemented IntoParam<'_, PWSTR> for &OsStr, but when I tried to use one as the first argument for GetFullPathNameW I got an error saying it's not implemented. The IntoParam trait is also not a link in the docs for that function, so I had to dig through the source to figure out that the std feature is needed to enable this implementation.

Thanks for the feedback. #1343 should simplify this.

It looks like IntoParam used to have docs, but they've since been moved/removed?
https://github.com/microsoft/windows-rs/pull/690

This should no longer be an issue as the std feature has been removed from the windows crate.

It seems like IntoParam is still undocumented.

The source of this issue was what I fixed here. For docs you can track this issue: #1499


Mark the MiqTask as finished if GenericMailer fails due to missing notifier role

If there is no notifier role and the MiqTask tracking the GenericMailer.deliver call fails mark the state as finished.

Updates to the Workflows specs following this change https://github.com/ManageIQ/manageiq-providers-workflows/pull/93


[SMALLFIX]javadoc for AbstractAlluxioShellTest.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14565/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14657/
Test PASSed.


Analytic tools added through GTM accumulating on navigation

Environment
System:
OS: macOS 13.2.1
CPU: (8) arm64 Apple M2
Memory: 455.17 MB / 8.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 14.21.3 - /opt/homebrew/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 6.14.18 - /opt/homebrew/bin/npm
Browsers:
Chrome: 114.0.5735.133
Safari: 16.3
npmPackages:
nuxt: ^2.15.8 => 2.17.0
Reproduction
https://stackblitz.com/edit/github-i8scez

Make sure you add a proper GTM id in nuxt.config file and that some other analytic tools are in included as well (tiktok.analytics, criteo, marketing1by1, snap, adloop etc ).
Run in terminal npm run build && npm run start
Navigate through the pages with the NuxtLink component.
Inspect head element and see it keep growing and duplicating scripts, iframes.

Describe the bug
Every time that a user navigates to another page through NuxtLink a new script from the tools that intergraded through GTM is added. I can see scripts/iframes duplicating from the following list:

Criteo
Marketing1by1
snap.licdn
tiktok.analytics
adloop
etc

Additional context
I already use https://github.com/nuxt-community/gtm-module and at the beginning i though this is the problem but i'm able to reproduce the exact same behaviour without the module.
Anyone seen this is before? I think this is quite important, because if you navigate in 20 different pages, you gonna end up with a bunch of duplicated scripts that might lead to a browser crash or slow performance etc.
Logs
No response

Are you sure you've configured GTM properly, and don't have a trigger that is re-adding the tags on navigation?

@danielroe Thanks a lot for your quick response.
I'll try to see with my colleagues who are responsible for GTM and come back to update the ticket accordingly.

I will close this ticket as nuxt is not the problem here, but instead certain tools that don't handle this case correctly. Specifically adloop, marketing1by1 are the ones that creating this problem.


Add trailer 1: Tiger3

@mitchiemt11 Please review this PR when you have a chance."

@mitchiemt11 Please review this PR when you have a chance."

@devNenyasha please resolve conflicts.

done with conflicts


Fixing create store docs tutorial

What docs page needs to be fixed?

Section: Store
Page: redux/docs/tutorials/essentials/part-1-overview-concepts.md

What is the problem?
The overview concept tutorial follows a pure redux explanation from the beginning only when creating store it uses
import { configureStore } from '@reduxjs/toolkit'

const store = configureStore({ reducer: counterReducer })

which creates confusion for people not familiar with redux. The tutorial should follow "a single source of truth".
What should be changed to fix the problem?
import { createStore } from 'redux'

const store = createStore(todos, ['Use Redux'])

Nope, we specifically built this guide around using Redux Toolkit. It's mentioned in the "What you learned" section:

Redux Toolkit is the recommended way to write Redux logic

I just stumbled on the same problem. Now that you point it out @timdorr, I can see that the tutorial was written with Redux-Toolkit in mind, as you say, but I wonder if there might be a way to highlight this a little more?
Perhaps it would help to explicitly state the npm install commands at the top of the page, to make the requirements copy-pastable?

Part of the issue here is that the tutorial specifically gives you a pre-configured repository that already has Redux Toolkit added to it (which is in turn based off of the Redux+JS template for Create-React-App, which also has RTK already configured):
https://redux.js.org/tutorials/essentials/part-3-data-flow#project-setup
So, in both those cases there isn't even anything to install.  The tutorial does have a "Detailed Explanation" section that explains how to add Redux to an existing project.
Given that structure, I'm not immediately sure where an NPM installation command would fit into page 1, but I"m open to suggestions.


ToListAsync() is not handling cancellation correctly.

With Sqlite database provider and QueryTrackingBehavior set to NoTracking, ToListAsync() does not handle cancellation correctly. On cancellation, it should either throw TaskCanceledException or complete the operation (i.e., ignore cancellation). But, it instead succeeds returning a partial list of records.
Test code attached.
NoTrackingTests.zip

Updated test code.
NoTrackingTests.zip


gamma, alpha are supposed to be floats, delete lines with [0] subscripts   #1013

Fixes #1013
It appeared in this commit https://github.com/chengyangfu/maskrcnn-benchmark/commit/26c707e798d830bbf048380eaf78adad60873c8a#diff-10a14e932c16f4c03e825ff3f60720f0
This is the only place of initialization of alpha and gamma.  https://github.com/facebookresearch/maskrcnn-benchmark/blob/24c8c90efdb7cc51381af5ce0205b23567c3cd21/maskrcnn_benchmark/modeling/rpn/retinanet/loss.py#L94
If I understand correctly they are supposed to be only as floats according to configs
cfg.MODEL.RETINANET.LOSS_GAMMA,
cfg.MODEL.RETINANET.LOSS_ALPHA

[unittests OK]

I tried to run this for configs/retinanet/retinanet_R-50-FPN_P5_1x.yaml

[train_net.py, test_net.py with GPU]
[test_net.py with CPU]

Hi @Dorozhko-Anton,
Thanks for spotting this!


[TS] Aztec Noir functions should be able to read pending commitments from new list maintained in ACIR Simulator

ACIR Simulator should maintain a single list of pending commitments across all nested instances.

Closing this, but unfortunately it won't be particularly useful until Noir/ACVM does stepwise execution of ACIR.


fix: Remove restic config from master branch

Fixes https://github.com/openshift/oadp-operator/issues/1176

@mpryc I think I need to add an error like we did with feature.datamover to 1.4 updates not break. Will test this later

/hold

@mpryc tested upgrade from 1.3 to master (1.4) using make catalog-test-upgrade and it did not break the upgrade if I use resticConfig in 1.3 (do not know why, maybe because of this https://github.com/openshift/oadp-operator/blob/oadp-1.3/api/v1alpha1/oadp_types.go#L165 ?)
But it does remove resticConfig from DPA after upgrade, removing nodeAgent pods as well, for example. Is this ok? We have added deprecated notice in 1.3 about this field, so user may have seen it, or may not. If user does not check things after upgrade, it may get an error trying to do a restic backup afterwards, as his DPA is not confugured for filesystem backup anymore.
@shawn-hurley you helped us with similar problem about upgrading from 1.2 to 1.3 last time, what you think?

@shawn-hurley the deprecation warning should've already been added in oadp-1.3 per design, this PR is for 1.4 removal.
See also: https://github.com/openshift/oadp-operator/pull/1174#discussion_r1347374829

warning implemented in https://github.com/openshift/oadp-operator/pull/1102/files#diff-e186f96e971d9f53a2614ad247e98c7313a2fcc086cb9f6243d776e1e540fe73R173

Going to undo removal of fields from yaml
we have something similar to old datamover in 1.3: restic field is available in 1.4, but DPA does not reconcile if it is present, so upgrades are safe, and in 1.5, we do remove the field from yaml
everyone alright with this approach?

I don't know if it is ever safe to remove fields, but you can make them useless.
I usually try to follow these guides as these folks have lots of experience making api changes:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md#incompatible-api-changes

One other way to make this is adding some CEL validation that will make it so that Rustic Config must always be nil.

Had to look up CEL.. I think you mean https://kubernetes.io/docs/reference/using-api/cel/

/unhold

/remove-lifecycle stale
We need this in 1.4, otherwise upgrades may break

/remove-lifecycle stale
discuss in next scrum

In the last scrum we all agreed on this PR.  Let's rebase and get it merged.  @mateusoliveira43 @shubham-pampattiwar.   Thank you at @mateusoliveira43


ng e2e --watch

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.0.4
macOS -Sierra
When trying to use ng e2e --watch, the tests run once.
I've seen a post here about this issue, but it was closed and it still keep happening.

We still don't support that, but it's being tracked on https://github.com/angular/angular-cli/issues/2861, which has been reopened.


How to compile and configure BoringSSL with nginx to support TLSv1.3 draft18

I saw a blog on your site showig that Cloudflare is using BoringSSL and issue #78 also prove the usage of BoringSSL.

As it happens, BoringSSL has supported TLS 1.3 for quite a long time (it was one the first open source SSL implementations to work on this feature), so now all of our edge SSL traffic (including TLS 1.3 connections) is handled by the same system, with no duplication, no added complexity, and no increased latency. Yay!

However I compiled BoringSSL with nginx 1.13.7  using configuration --with-openssl=/path/to/boringssl --with-openssl-opt=enable-tls1_3 and it could not support TLSv1.3 Draft18 (like Cloudflare does).
BoringSSL supported TLSv1.3 draft18 since this commit but I could not find an wiki or an explanation about how to compile and configure BoringSSL with nginx to support TLSv1.3 draft18.

@railjty  it's not worked

For draft-18, you need branch 2987,because
their master branch is using draft 23

You can get it like this: git clone -b 2987 https://github.com/google/boringssl

Also there is some wrong filename in the command ,I will put a file that is ok for me

Ok! Gei it from this:https://cdn.jintaiyang123.org/static/boringssl.tar.gz

just compile it

Cloudflare now is using draft 22 and 23, not draft 18!

yes, with openssl I think, because I can’t find worked solution for boringssl +nginx with draft 22/23

@railjty Test successfully with tlsv1.3 draft 18 using boringssl version 2987
However, as you said

Cloudflare now is using draft 22 and 23, not draft 18!
Which version of boringssl Cloudflare are using? Do you have any ideals?

They are using master branch(Sorry, but I am busy with my studying now. I can't answer this at all.)

I was looking for the same solution and came across this post.
Because I have found a solution, it is neat to share it with you guys.
I found this patch: https://gitlab.com/buik/boringssl/blob/boringssl-patch/Enable-TLS13-BoringSSL.patch
It will enable BoringSSL's TLS 1.3 draft 22 and 23 (Chrome stable) and the final TLS 1.3 standard (BoringSSL master only).
It is quite simple.

Compile it against Nginx and you are done.
--with-openssl-opt=enable-tls1_3 is not necessary.
That is an OpenSSL parameter and does not work at BoringSSL.

@xetorixik Excellent Patch! Problem solved. It seems that tls 1.3 draft 28 will be the final version and both openssl and boringssl are working on it and will be enabled by default in the future.

That very good ! I follow it and reconfigure boringssl and nginx . And it worked .

FYI: https://github.com/kn007/patch/issues/4

Hello.
This is my patch files (OpenSSL 1.1.1-pre8-dev) : https://github.com/hakasenyang/openssl-patch/blob/master/openssl-equal-pre8_ciphers.patch
This patch file includes draft 23, 28 support and Equal Preference patches.
Result testssl.sh : https://ssl.hakase.io/ssltest/hakase.io.html
I do not speak English well. Sorry.

@hakasenyang Thanks for your work, this is a super useful patch.

Thanks all for these great patches!
I cloned many useful patches for openssl, boringssl and nginx and made it into a bundle.
https://github.com/S8Cloud/sslpatch

Patch code seems to be updated.
Latest bits available via: https://link.buikdaanser.nl/enabletls13boringssl

Because I am subscribed to the channel of Buik.
There seems to be another patch-update to enable TLS 1.3 on BoringSSL.
Latest bits available via: https://link.buikdaanser.nl/enabletls13boringssl

Update: nginx officially support enabled TLSv1.3 with BoringSSL in this commit
Just compile mster version of nginx and boringssl and add TLSv1.3 to ssl_protocols configuration to enable it.

Is there a patch for boringssl to support multiple drafts? Would be similar to what @hakasenyang did with openssl earlier, except for boringssl.
Compiling with the recent patch mentioned by @xetorixik works for the final draft only (nginx stable), which currently has limited support (Chrome developer channel).

BoringSSL now changed to TLS1.3 RFC
See: https://github.com/google/boringssl/commit/6855e0a470791f6536bae04a54fbe2456d69f91c
and you can enable the draft version by yourself

Thank you @railjty, interesting.

@JSkier21 @railjty Problem is that Google removed TLS 1.3 draft28 2 days ago (googlesource.com) and it seems logical that draft23 will follow soon in favor of TLS 1.3 RFC only. (Before draft 23,28 and RFC).
As Chrome and Firefox production version only supports TLS 1.3 draft and won't work yet on TLS 1.3 RFC. You will be faced with a choice in this interim phase.
In my opinion there are 3 options for now:

Use for example BoringSSL git clone of Aug 25 2018 so the production version of both Chrome and Firefox are working fine with your BoringSSL draft/RFC based TLS 1.3 enabled site.

Wait a little bit till Chrome and Firefox could offer support to TLS 1.3 RFC.
As could be seen above it is already available in the Chromium master git. So this should not be long before it appears in the production version of Chrome.

Don't do anything yet and jump in when everything is ready.

@xetorixik, I just modified the 25 patch and defined tls13_all instead of _rfc. I now get final, draft 28, and draft 23 presented as options. Works great in Firefox and Chrome.

seems i managed to re-enable all TLS 1.3 drafts via
        sed -i 's|tls13_rfc = 0|tls13_all = 0|' /opt/boringssl/include/openssl/ssl.h
        sed -i 's|  tls13_all,|  tls13_rfc,|' /opt/boringssl/include/openssl/ssl.h
        sed -i 's|tls13_variant_t tls13_variant = tls13_rfc;|tls13_variant_t tls13_variant = tls13_all;|g' /opt/boringssl/ssl/internal.h

but wondering if i missed anything ?
testssl check
 Testing protocols via sockets except NPN+ALPN

 SSLv2      not offered (OK)
 SSLv3      not offered (OK)
 TLS 1      offered
 TLS 1.1    offered
 TLS 1.2    offered (OK)
 TLS 1.3    offered (OK): draft 28, draft 23, final
 NPN/SPDY   not offered
 ALPN/HTTP2 h2, http/1.1 (offered)

@centminmod, I just diffed my new internal.h file containing the two new instances defining the tls13_variant_t tls13_variant = tls13_all, added those lines to the existing patch.
Our testssl results look the same for tls 1.3 report.
You did more than me on the ssl.h files. Should work fine with only you're last sed. Is there any reason why you're changing ssl.h file? I ask out of curiosity (maybe I'm missing something).

I am just winging it heh. Will try just editing internal.h

@JSkier21 Seems as Github is not u-to-date and not synced yet with googlesource.com as Github still offers draft 23,28 and RFC. Draft 28 is removed from googlesource.com and it is It seems logical that the removal of draft 23 follows.
After that both Chrome and Firefox won't work with TLS 1.3 anymore, until both browsers support TLS 1.3 RFC. As of today both won't support TLS 1.3 RFC.

@xetorixik It seems github & googlesource version of boringssl was exactly the same and it removed draft 28 as well.
BTW boringssl was always good at deleting codes that google thoughts unnecessary e.g. CBC-SHA2 ciphers which are often used in safari browsers.

https://boringssl.googlesource.com/boringssl/+/6cacb472c42ddbe1553a1263d651ae64a29efc5f
This commit has not been combined to master version of boringssl (but it will). Maybe its time to preserve a fork :)

@S8Cloud Draft 28 is not removed yet as can be viewed here , diff to remove TLS 1.3 draft 28 is present but not yet merged.

@xetorixik Maybe github version is just a mirror of googlesource so it doesn't include unmerged commit.

I think Chrome and Firefox browsers will be out with final support in October on their respective stable channels. That said, a fork will help carry over my testing with this.
I was planning on forking enabletls13boringssl to submit my additions, should be able to do that soon hopefully. I'll give him a heads up as well.

@JSkier21 if so in october. That means you have to:

Fork BoringSSL
Use an old git copy of BoringSSL with the draft code
Do nothing, don't use TLS 1.3 and wait before all the fog has settled and everything (browser final and BoringSSL) is TLS 1.3 RFC supported.


Udeler  v1.6.3 - Subtitle Problem

Hi! I update my udeler version days ago and I downloaded a course video with subtitles options ON. However, when I tried open the file to convert from vtt to srt, I came across with this text:
`
<TITLE>401 Authorization Required</TITLE>

Authorization Required

This server could not verify that you
are authorized to access the document you
requested.  Either you supplied the wrong
credentials (e.g., bad password), or your
browser doesn't understand how to supply
the credentials required.

Also, I can't play the subtitiles on my video. I use VLC player to watch my videos.

Same with me,
Udeler v1.6.3 running on win 10 x64
but not all subtitles like these, there is some good subtitles I see about 50% subtitles with "401 Authorization Required"
It good if Udeler give us option for download subtitles only for specific videos

+1


Meal page init

Create meal page with necessary elements, add servlet for loading meal data and process it.

I updated some files.
I don't really understand what to do with servlets 'cause I don't understand how to separate my and Polina's parts in different files (to be able to code parallel). So I think next step is to describe everything in Design Doc and after that continue with coding. But still, how do we supposed to write one servlet (/meal/*) at the same time?
Also we got confused because we both needed Meal class, so we both added them in our branches, but I will ask Polina to use mine after merge. I changed Id to id (I suppose code style says not to name variables with first upper letter) and changed type of id from int into Long 'cause it supports null.

I don't really understand what to do with servlets 'cause I don't understand how to separate my and Polina's parts in different files (to be able to code parallel). So I think next step is to describe everything in Design Doc and after that continue with coding. But still, how do we supposed to write one servlet (/meal/*) at the same time?

In general, it's often best to have small files for this very reason, but I guess we won't be able to do it with servlets. It's possible to work on the same file, as long as it exists, so for now let's commit one version and iterate on that. It'll get better over time. The first commits are the trickiest ones.

Also we got confused because we both needed Meal class, so we both added them in our branches, but I will ask Polina to use mine after merge.

This would actually make a good candidate to be pushed in a separate PR. Let's not split it now, but in the future, we can try to separate those independent pieces to separate, smaller PRs. Adding a new class is usually a good candidate for a standalone PR, that can be followed up by another PR actually using the new class in the existing code.

I changed Id to id (I suppose code style says not to name variables with first upper letter) and changed type of id from int into Long 'cause it supports null.

True about upper letters. In general, those things vary across languages (each language has it's own style guide / parser restrictions), but I believe that capital letters are reserved for class names here.
I think that each Java POD (plain old type) has a capital case equivalent that handles nulls (here Integer). Either way, Long will do, too.

@bprusak I left /meal-info just because I actually plan to use Polina's servlet instead in the future.
But in such case I will probably rename it and ask Polina to rewrite servlet file with her implementation.


Implement macros to improve codebase

Code in setup directory has lots of duplication, we can add few macros(decl or proc whichever suits) to reduce the duplication and make future maintenance easier.

Addressing @shekohex's review comment:
One thing to improve the readability a bit is to add names parameters to the macro itself, for example
Prefer:
impl_setup_tree!(name: Tree_x5, config: TreeConfig_x5, parms: PoseidonParameters);

or maybe, we enforce the code convention here by just something like:
impl_setup_tree!(poseidon_width: 5);

that would just be good to go, that way we know it generates the Tree_x{poseidon_width} for example.
also we could get a better name here.


⚠ Thumbnails API Endpoint has degraded performance

In 15e6e03, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1203 ms

Resolved: Thumbnails API Endpoint performance has improved in f99ff24.


Support ansible provision mode for remote playbook

Closes #2282
Needs docs.

lima.yaml (based on debian.yaml)
...

provision:
- mode: ansible
  playbook: playbook.yaml

inventory.yaml (auto-generated)
lima:
  hosts:
    ansible:
      ansible_connection: ssh
      ansible_host: lima-ansible
      ansible_ssh_common_args: -F /home/anders/.lima/ansible/ssh.config

playbook.yaml
- name: My first play
  hosts: all
  tasks:
   - name: Ping my hosts
     ansible.builtin.ping:

   - name: Print message
     ansible.builtin.debug:
      msg: Hello world

https://docs.ansible.com/ansible/latest/getting_started/get_started_playbook.html
INFO[0021] [hostagent] The final requirement 1 of 1 is satisfied
INFO[0022] Waiting for ansible playbook "playbook.yaml"
 ______________________
< PLAY [My first play] >
 ----------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

 ________________________
< TASK [Gathering Facts] >
 ------------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

[WARNING]: Platform linux on host ansible is using the discovered Python
interpreter at /usr/bin/python3, but future installation of another Python
interpreter could change this. See https://docs.ansible.com/ansible/2.9/referen
ce_appendices/interpreter_discovery.html for more information.
ok: [ansible]
 ______________________
< TASK [Ping my hosts] >
 ----------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

ok: [ansible]
 ______________________
< TASK [Print message] >
 ----------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

ok: [ansible] => {
    "changed": false,
    "msg": "Hello world"
}
 ____________
< PLAY RECAP >
 ------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

ansible                    : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

INFO[0024] READY. Run `limactl shell ansible` to open the shell.

Is this feature officially supported? Coverage in docs seems to be minimal and couldn't find anything in the release notes. Cheers.


feat: Add empty enum variants with brackets

Add empty enum variants with brackets

hey unless there is something else coming i'll probably reassign this issue

as nothing is pushed unassigning the issue

closing this to have a clearer view of what's remaining


Implement OpenSearch core branching strategy

Description
Ensure MAJOR_VERSION.x branch exists, the main branch acts as source of truth effectively working on 2 versions at the same time.
Related META issue
https://github.com/opensearch-project/opensearch-plugins/issues/142
Current Behavior
Currently plugins follow a branching strategy where they work on main for the next development iteration, effectively working on 2 versions at the same time. This is not always true for all plugins, the release branch or branch pattern is not consistent, the lack of this standardization would limit multiple automation workflows and alignment with core repo. More details on META ISSUE
Proposed solution
Follow OpenSearch core branching. Create 1.x and 2.x branches, do not create 2.0 as a branch of main, instead create main -> 2.x -> 2.0. Maintain working CI for 3 releases at any given time.

Hey @praveensameneni can you please post an update on this branching strategy?
Thank you
@dblock @bbarani @CEHENKLE

Created 2.x branch from main branch.
Will bump the main branch to 3.0 once IM backend bumps successfully https://github.com/opensearch-project/index-management/issues/416

There should be nothing blocking this rn. To close this issue:

[ ] main is building 3.0
[ ] 2.x is building next 2.x, which is currently 2.4.0
[ ] 2.3 is building next 2.3, which is 2.3.1
[ ] manifests in https://github.com/opensearch-project/opensearch-build/tree/main/manifests include all 3

@bowenlan-amzn re-tagging this issue for 2.4.0 release.

Will continue once IM backend bump 3.0 PR merged https://github.com/opensearch-project/index-management/pull/585

@bowenlan-amzn @qreshi Can you provide updated status of this issue?

Will work on this once backend 3.0 PR finished https://github.com/opensearch-project/index-management/pull/585

Done!