Fixie 3 fails test that passes in Fixie 2

Steps to Reproduce
I created a couple of test projects for this. They use the same library for code, aptly named "ClassLibrary1" and then two different solutions for testing this using Fixie 2.2.2 or Fixie 3.1.0.
Try running the test using both the Fixie2 and Fixie3 solutions.
FixieHtmlTests.zip
The test currently fails using Fixie3 but passes with Fixie2.

Thanks for such a minimal repo. The behavior is, of course, the same for me as for you.
I took the relevant bits, then, and moved them into the Fixie repo locally, so that I could be debugging through your sample test and the Test Explorer "TestAdapter" code with its use of AssemblyLoadContext.
I was hoping that stepping through, I'd see calls entering the AssemblyLoadContext with a surprising (generated/dynamic) assembly name and that I'd then watch it fail to find it on disk or something similar. Surprisingly that never happened. Every invocation of the ALC was for unsurprising assembly names and the behavior seemed right for those.
I found that the code generated does live on disk, as well as a dll for it. They happen to wind up under C:\Users\yourusername\AppData\Local\Temp\RazorEngine_randomcharactershere\ and within that we see a cs/dll/pdb triplet with names like: CompiledRazorTemplates.Dynamic.RazorEngine_e6a2c7eba66745c7b7f331bd1febbb44.cs
The code generated is unsurprising:
// <auto-generated/>
#pragma warning disable 1591
namespace CompiledRazorTemplates.Dynamic
{
    #line hidden
    using System.Threading.Tasks;
    using System;
    using System.Collections.Generic;
    using System.Linq;
    internal class RazorEngine_e6a2c7eba66745c7b7f331bd1febbb44 : RazorEngine.Templating.TemplateBase<TheExampleTestProject.ViewModel>
    {
        #pragma warning disable 1998
        public async override global::System.Threading.Tasks.Task ExecuteAsync()
        {
            WriteLiteral("<div>");
            Write(Model.Value);
            WriteLiteral("</div>");
        }
        #pragma warning restore 1998
    }
}
#pragma warning restore 1591

Digging into the stack trace isn't helping. I think the root cause is far away from the moment where it results in an exception.
So, this is all very helpful confirmation that I'm not going to spot a quick win in my AssemblyLoadContext code. Since things actually run fine running with dotnet fixie at the command line, the only substantive difference here is that v3's Test Adapter loads the test assembly in-process using ALC and v2's instead kicks off the test assembly just like a dotnet fixie run.
In other words, the flows that work all just let the test project run as a normal console console app that is free to load all its dependencies itself through perfectly normal means. That's what happens for v2 from the console, v2 from Test Explorer, and v3 from the console.
The most likely solution (as I was speculating in our earlier discussion outside of this thread), will be for me to:

Using the v2 code as a guide, drop the use of the AssemblyLoadContext and reintroduce the older interprocess communication trickery that works.
Confirm that if I do that, the test starts passing.
If that all works, I'll need to further adjust the interprocess communication as the old way relied on a Windows-only named pipe mode ("Message" mode) and I think I will be able to use the cross-platform modes with a little extra care that messages arrive in full between the two processes.

Fixed by #260 and released in https://github.com/fixie/fixie/releases/tag/3.2.0


Renew JWT token automatically

Some additional context:
Every api request returns a new token in the response header (this is done by the checkJWT middleware).
So we need an interceptor which saves the new token in the authenticationService.


Allow providing custom selector instead of lablel for actions

TODO:

export 4 types: the main action type and three sub action types (selector, label, and elementId)
export a generic performAction that calls three sub performActions{selector/label/elementId} based on action type.
refactor available actions

Test and Release:

change npm package version (beta) in package.lib.json
run the build lib script to generate dist-lib
run npm publish --tag beta2 in dist-lib
now the new version is published. use that in wingmate to test
if things are working properly, publish the official version (remove beta tag)


Tiles keep loading when useCanvas is set to false

Hello,
I'm going to give a bit of context first before explaining my issue.
I'm working on a project where I'm trying to set OpenSeadragon as an alternative to a basic image viewer. We use an  element inside a  element to display the image and we are also able to draw things on top of it, zoom, and drag the image across the screen but we have big performance issues when the images are bigger, that's why we thought of using a tiled image, but we still want to use our implementation of zoom, etc...
So I got some good results by placing the OpenSeadragon div inside a  so we can directly replace . I can draw on top of the image and all but for resizing purposes I had to set useCanvas to false.
Now the issue is that when we display the image with OpenSeadragon, it starts loading tiles from level 8 and doesn't stop until everything above is loaded.
I have tried to modify some parameters like maxImageCacheCount but it didn't work, I'd really appreciate some help on this topic

Interesting. And if you change useCanvas back to true, it doesn't load those extra tiles?
I tried this with our basic.html demo (https://github.com/openseadragon/openseadragon/blob/master/test/demo/basic.html) with both true and false for useCanvas, and both times it loaded the same number of tiles. Presumably there's more to your set up than that... any thoughts about how your viewer differs? I don't quite understand how you are using your own zooming on the OSD viewer. Is there something you can link to?

Oh I just noticed I skipped quite a few words from my previous post.
We are actually not able to use our own zoom instead of OSD's, do you think that will be doable ?
We use an svg element to display our image and we are trying to use OSD instead of the image :
<svg
        ... some parameters ...
        viewBox={`${viewBox.x} ${viewBox.y} ${viewBox.width} ${viewBox.height}`}
>
        <image
          className={className}
          href={getImageUrl(image.id)}
          x="0"
          y="0"
          width={width}
          height={height}
        />
        ... other options ...
</svg>

I am currently trying to replace image with OSD :
<svg
   viewBox={`${viewBox.x} ${viewBox.y} ${viewBox.width} ${viewBox.height}`}
>
   <foreignObject
       x={this.props.x} // ViewBox's position
       y={this.props.y} // ViewBox's position
       style={{ position: 'relative', width: this.props.width, height: this.props.height }}
   >
       <div
          id={this.id}
          style={{ width: this.props.width, height: this.props.height }}
          className={this.props.className}
       />
   </foreignObject>
</svg>

I need foreignObject to put a div into the svg element, but when I use the canvas it seems to break the resizing ability, probably because of that foreignObject because OSD resize just fine in other projects.  When I don't use the canvas the resizing works so I tried going that way.
If I enable the canvas it also loads all the images, but the image displayed at start is super zoomed in.

Wow, sounds like you're really pushing the envelope here. I've never tried to do something like that.
Is it possible to not have the OSD viewer inside the SVG? It might be better to have them separate and just synchronize them. You might also look at https://github.com/openseadragon/svg-overlay as an option.
Otherwise I think you are in uncharted territory, though I'm happy to be a sounding board if you want.


Downloaded file corrupted

Hello!
Trying to download file using this code:
$.sendDocumentFromUrl(film.downloadlink, {filename: 'test.torrent', contentType: "application/octet-stream"});
Also tried with different names and different contentTypes.
But when I receive file and open in torrent I have an error that file is corrupted.
Here is the link of file whitch I want to download (http://kino-torrent.net/load/0-0-0-1446-20). Using browser downloading is complete.

Hi!
This site have redirect, so whet you trying to download torrent file from that url you will have this:

So you need to find direct url and then send your file.

hmmm... yes.
I was cofused by module 'request'. It can handle redirect situation.
So now I use request with $.sendDocument.
Maybe think how handle redirect situation ?

Also consider to checking for callback in method sendDocument just as for 'caption'.
callback = callback ? callback : () => {}

Thanks, i will add checking for callback.


Fix memory leaks.

Memory leaks are occurring in almost all fragments because of having non-nullable members.

@AnuragThePathak i got this, assign to me

Done.

I'm interested in the discussion as well. Want to learn where I went wrong

I'm interested in the discussion as well. Want to learn where I went wrong

You went wrong means?

Using the Leak Canary library, I found there were some memory leaks in the app. But I was unable to fix them, so I mentioned  that if in my newly added code, if there is anything wrong that is causing memory leak, then I want to understand it well

Well. Have you noticed how we are using the property binding and _binding in case of fragments? If you try to know why so you'll get to know reason behind memory leak.

the way how we use this _bindings and all were guided on official docs of ViewBinding in Fragments. So, official docs won't be giving examples that contain a memory leak

the way how we use this _bindings and all were guided on official docs of ViewBinding in Fragments. So, official docs won't be giving examples that contain a memory leak

But google is not a search engine which only shows results from official doc only.

@dhruvnagarajan I have fixed the memory leak because of CustomTabsIntent.Builder().build()
Now you just fix the leak because of adapter property. Btw I as a part of learning thought of implementing what I learnt and hence made some changes and CustomTabsIntent.Builder().build() got fixed. If you have any improvement suggestions then it's always welcomed.

@Devendra34 are clear why memory leak is occurring.


Closes #2501-general-issue-make-subject-keys-flexible-in-all-functions

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

I had an issue when doing pkgdown::build_site() with the bds_exposure script giving an error for line 365. Tried to update that too but its still throwing back an error. I'm pushing the changes for now while I sort out review errors.

I figured it out. I just had to update Rtools, and finding where errors in the test scripts used the updated functions was easier.

Sorry, I'll get this fixed by the weekend. Work got hectic and preparing for an interview!

I just noticed that after I run styler is misaligns the tables in the test scripts again. I can correct and we can just accept the failed styler check?

I just noticed that after I run styler it misaligns the tables in the test scripts again. I can correct and we can just accept the failed styler check?

Usually styler preserves alignment in tables if

all columns including the header are left or right aligned and
the first column is left aligned.

I think when you aligned the tables you centered most of the columns. This is not considered as aligned by styler.

I fixed the news here - noticed something else got messed up from another PR with the news.
@bundfussr was there anything else that we needed to fix here?

I fixed the news here - noticed something else got messed up from another PR with the news.
@bundfussr was there anything else that we needed to fix here?

@bms63 , the news are fine now.
Just the alignment of the tribble() calls is pending.

@bundfussr I think I am confused by styler request.  I have run styler and no changes are implemented for alignment

I think styler wants to put in a space after the comma so we can't align the data to the header anyways.  Let me know what I am missing, but if you have the time can you just fix this how you want it as I guess I am not following.

@bundfussr I think I am confused by styler request. I have run styler and no changes are implemented for alignment

I think styler wants to put in a space after the comma so we can't align the data to the header anyways as the studyid takes up more room now. Let me know what I am missing, but if you have the time can you just fix this how you want it as I guess I am not following.

@bms63 , I've aligned the tribble() calls.

So you want character values manually left aligned and numeric values right aligned?

That would be ideal for readability.

Wondering if we automate this as I am never going to remember to do this?

This would be really helpful but would require some work. An addin which aligns a selected tribble() call would be nice.

So you want character values manually left aligned and numeric values right aligned?

That would be ideal for readability.

Wondering if we automate this as I am never going to remember to do this?

This would be really helpful but would require some work. An addin which aligns a selected tribble() call would be nice.

@sadchla-codes sounds like a great candidate for https://github.com/pharmaverse/pharmaverse4devs


fix: remove ability to call env and expandenv in webhook

This PR removes the ability to call env and expandenv from the webhook provider.
It shouldn't be possible to use env or expandenv in any template function due to security concerns. eso-controller potentially has sensitive environment variables set and it shouldn't be possible to read/exfiltrate them using the webhook provider.
This is technically a breaking change but i'd classify this as a bug - it's unintentional behaviour that is being removed and poses a security threat to our users.

/approve

Completely agree - it’s a bug.


Create Structure for Parsing Step Implementations

The key here will be to create a structure that we can extend with new languages down the road. Javascript is an obvious reference implementation, and I think Ruby would be another quick step.

Also Python will be great


Activating Open Collective

Hi, I'm making updates for Open Collective. Either you or another core contributor signed this repository up for Open Collective. This pull request adds financial contributors from your Open Collective https://opencollective.com/nanoexpress ❤
What it does:

adds a badge to show the latest number of financial contributors
adds a banner displaying contributors to the project on GitHub
adds a banner displaying all individuals contributing financially on Open Collective
adds a section displaying all organizations contributing financially on Open Collective, with their logo and a link to their website

P.S: As with any pull request, feel free to comment or suggest changes.
Thank you for your great contribution to the Open Source community. You are awesome! 🙌
And welcome to the Open Collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other Open Source sustainers!

Thank you


Allow custom Port

Hi thanks for the example earlier, I finally saw the culprint to my problem its mIsSecurePort allows only predefined secure ports in my case Im using a custom port like 5353 or 5443, I added my custom port on the ESP_SSLClient_Const.h _secure_ports and finally it worked!!. Maybe you can provide a flag or method to turn off the checking?, THank you.

Your request ports are not standard secure port.
It needs more works to support user defined port more than allowing connection but the types of ports (Plain, SSL, TLS, STARTTLS) should be defined by user together with the port number.
The email client library that uses this ssl client allows user to connect to custom IMAP and SMTP ports.
This is not hard to implement but it needs the time, and I will update here when it becomes available.

I think that I don't have to allow non-standard secure ports as you can connect in plain text mode then upgrade as in this example.

You don't have to modify the source when your port does not in the list, you can upgrade as example above.
This should be done in user code or application that use this library to manually upgrade to secure connection in case non-standard secure port as implemented in my email client app that does not touch the ssl client library source.

I close this issue now as the alternate option is available.

I test with any non-standard secure port e.g. 5443 by upgrading with ssl_client.connectSSL() and it works as expected.

Amazing!! Im now using it with my custom port without touching the source code, thank you for this awesome trick :)


By the way, cost in the pretraining process are decreasing which is reasonable.

I just found an error in the softmax layer initialization. I didn't specify the standard deviation in the weights initialization, and the default is 1, which is too big. I just changed it to 0.01, now it should work better. Try first with a smaller network, like the 512,128 you tried!

Try with this:
python command_line/run_stacked_autoencoder_supervised.py --layers 1024,256 --verbose 1 --finetune_learning_rate 0.001 --finetune_opt momentum --momentum 0.8 --finetune_num_epochs 10 --finetune_act_func tanh --dropout 0.7 --finetune_batch_size 64 --finetune_loss_func mean_squared --do_pretrain true --seed 0 --batch_size 64  --num_epochs 3 --enc_act_func sigmoid --dec_act_func sigmoid --loss_func cross_entropy

You should get an accuracy of about 86%.

@blackecho  The latest code works really well ~  classifying MNIST using Stacked Denoising Autoencoder ends with an accuracy of 0.9374 for validation set  after 25 epochs and 0.93400 for test set. :）
P.S. saw you update your document :+1:   :)

Perfect, I'll close the issue :) :+1:


An endpoint to get a single known address name

Description
For #2817, we need an endpoint that would return an AddressEx for a given address.
E.g. request: /contracts/0x35457547457563478657
Response: {"value": "0x35457547457563478657", "name": "CowSwap Exchange"}
Note
As per @jpalvarezl's comment in #2817, this is for situations like Outgoing Transaction Form, where we don't have any backend context around an address.

Duplicates already implemented issue: https://github.com/gnosis/safe-client-gateway/issues/700


Ensuring running Help returns an exit code of 0

Request to have Help command return zero when executed
https://github.com/chef/chef/issues/4268

:+1:

:+1:

:+1:


Switch to rn-fetch-blob

Prep for updating to RN 0.57, switch from react-native-fetch-blob to rn-fetch-blob

this is on top of the flow stuff so going to wait till thats in


libressl: remove vulnerable libressl_3_1

Fix https://github.com/NixOS/nixpkgs/issues/132137.
Apologies... github.dev did not apply the standard PR template.

Apologies... github.dev did not apply the standard PR template.

I don't care the slightest. It is a guide for newbies.


python3Packages.nototools: make compatible with python3, unblock channel

Motivation for this change
The latest version of the Python package fonttools is no longer Python 2 compatible, breaking nototools and thus certain font generation.
By updating nototools and applying patches it is now (mostly) Python 3 compatible.
Note we could also add an older Python 2 version of fonttools, but longer-term we should get rid of Python 2.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build noto-fonts-emoji


Reduce ImmutableList duplication

When Guava is available, list properties are now initially ImmutableList instances in builders, optimistically avoiding unnecessary array allocation and ImmutableList duplication. If an object is cloned and modified using Builder.from without changing the list property, no ArrayList will be allocated: a single ImmutableList instance will be used throughout.
Once an ArrayList has been allocated, it will be used until the builder is discarded. While it might potentially be a memory saving to replace it with an ImmutableList once build() is called, in case multiple instances are minted without further modification, it would be difficult to retain the "live view" contract of the builder's getter method, which is currently done by returning an unmodifiable wrapper around the ArrayList.
This PR is part of issue #169.

:+1:

Note: This has been reverted.


Add feature to execute command in the specified directory

There are some bins that are put in a directory with lot of config files and other directories which are needed during execution so it's easier to execute the command on that directory rather than soft linking them all. I.e
Some java jars I've dealt with are like this.
Std os/exec has this cmd.Dir() function for exactly this job.

Closing as for #112.


Double tap zoom on a picture zooms in too much

Describe the bug
In the app, when you double tap on a picture to zoom in, the zoom is too important and you often have to zoom out to see better.
Example (on my Android with 720p display) :
A picture when you display it in the app :

After double tap : it's zoomed in far too much, to the point it's useless.

To Reproduce
Steps to reproduce the behavior:

Tap on a post's picture to display it in fullscreen
Double tap on the picture

Expected behavior
A less important zoom would be better in my opinion, so that a landscape picture would fill about the encore screen. So when you double tap, it would display like this for example :

Details

Operating system: Android
App version: 1.47.0

Additional context

Yeah I've noticed this too. Goes in way too far on android only

https://github.com/

https://github.com/bluesky-social/social-app/pull/1482


[feature request] add support for inventoryprofilesnext favorite

could you please add support to use inventoryprofilesnext's favorite system so we dont have to use multiple mods with a favorite system.

I've been looking at implementing that feature myself as having to use multiple slot locking systems bothers me a lot, and have gotten very far (it already works in Single Player), there is just one issue:
While ItemFavorites keeps track of the state on the server side, InventoryProfilesNext does this on the client instead.
This is a good thing as it allows for using the mod on servers that do not have it, but it also makes it impossible to get the locked slots on the server side (which is responsible for quick stacking the items in this mod) as it stands now.
There is a way to achieve this, but it requires changing the C2SPacketDepositRequest signature.
I'd be happy to do it, but I will wait for @2Retr0's approval first as I do not want to spend my time on something that will never be added.

is there no way to transfer the stacking to the client? it would be very useful to have this on vanilla servers.


change Default port

hash("farcaster")

@h4sh3d, could you propose a port number?

21337 is not an iana reserved port :)


Api/GitHub profile

Add axios for fetch data
use github api (get my own information with the api)
create component that concern my github profile
add new env variable
add secret on github repo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (05296e6) 100.00% compared to head (1aece29) 100.00%.
Report is 3 commits behind head on development.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##           development       #54   +/-   ##
=============================================
  Coverage       100.00%   100.00%
=============================================
  Files                2         2
  Lines                5         5
=============================================
  Hits                 5         5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


eks module upgrade guidance on 1.7.0 to 2.2.0

I am still using v1.7.0 to manage my module, I just saw the latest version v2.2.0 (looks like there is no major version bump). I wonder what would be the upgrade path?

Nothing specific. Just change the module version and see the terraform plan output to see what will happen. Feel free to open a specific issue if you have some problem 🙂


Update styles.scss to handle bad position of crosshair

This way crosshairs will be handled in nested elements which are way deep down in the DOM and will not affect the behavior for simple single page component. Give it a try.
For me its treating the parent element as the main browser window and when I got to 10px clientX 10px clientY it goes to the pixels of the parent element hosting ScreenCapture

please approve this, it does help with the styling of the crosshair! although there still needs to be another fix for actually screen capturing the correct region

@lyqht It has been approved. Please get a try with version 1.0.1. Thank you so much!

@Bunlong thanks for the quick response :D
I'll try the package again when issue #3 is fixed


'Save Branch as Scene' doesn't mark original scene as modified

Godot version:
3.1.1-stable_win64
OS/device including version:
Windows 10 v1903
Issue description:
Right clicking on a node in the editor and selecting 'Save Branch as Scene' creates a new scene and replaces the existing branch with the new scene, but does not mark the original scene as modified ((*) does not appear next to scene name). It does not save the change to the original scene either.
Steps to reproduce:

Create a scene with a branch of nodes.
Save the scene.
Right click on the node branch and select 'Save Branch as Scene'.
Closing and reopening the scene will show no prompts, but the merged branch will no longer be merged in the node tree.

Minimal reproduction project:
Save As Scene.zip

I'm having a go at fixing this myself, and I've modified SceneTreeDock::_replace_with_branch_scene() to save the original scene after it's been modified. Is that an acceptable solution or would that be too unexpected?
Unless there's a way to just mark the scene as modified that I've missed, the only other option I've thought of is adding a step to the undo history, but that would mean choosing between leftovers after an undo or giving Ctrl+Z the power to delete files and I'm not really comfortable with either of those.


Add autocompletion option

There it is, the autocompletion function for our very own aica-docker hehe!
The completion scripts need to be sourced in bashrc/zshrc so this is the only point I'm not totally sure how to do it. Maybe there should be an option for the install where the user can decide if he wants to install the auto completion or not...And then we need to make sure it works for at least bash/zsh on linux and mac...

Quick update on what I did in the last commit:

The install checks for an existing symlink and updates the old one, if applicable.
The install asks the user for permission (yes no input) to add a line to the bashrc/zshrc
Due to the fact that (at least on my computer) the default shell of the sudo user is bash whilst mine is zshrc, you don't have to run the script with sudo permissions but rather the script has two sudo commands where the user will need to provide the password. This ensures that the auto completion script is written to the correct rc file.
The uninstall only removes something if it exists.

All in all, much cleaner installing/uninstalling procedure to give the user clear messages and full control over the install.

Nice work! Install and uninstall script works great.
The only thing that is needed in zshrc to support autocompletion are the lines:
autoload bashcompinit
bashcompinit

So, if you could install and remove those lines if the shell is zsh, that would be perfect. It's very satisfying to use the scripts now with the autocompletion, thank you

That's a Darwin thing then ;) I have zsh and its not needed


Make defining LS_COLORS configurable

Here's why this is needed:
I use a custom provider for LS_COLORS which adds a lot more colors, so I don't want to use the LS_COLORS from this theme. However this theme overrides my definition.
You might ask, why don't I simply define my LS_COLORS after this theme is applied? The reason is, it is useful to define proper LS_COLORS in the very beginning of your zshrc, before plugins and themes are loaded, so that for example autocompletion plugin can use this variable and show suggestions in color. I use antigen, which defines both plugins and themes in one place, so I can't really put my own definition of LS_COLORS in between those lines.
I preserved the default value of true, so nobody will be affected by this change.

Closing in favor of #273


Reimplement/fix/complete implementation of scrollbars

This PR overhauls how scrollbars are implemented, fixing all known issues and implementing the features that were forgotten/missing.

As before, scrollbars have:

Two visibility styles:

AlwaysVisible, where the scrollbars are always visible and have always the same thickness. This is the most similar to Win/Linux behavior on macOS but doesn't 100% match it.
WhenScrolling, scrollbars are only visible while scrolling

Two track click behaviors:

NextPage, clicking moves the viewport by a whole page, but not more
JumpToSpot, moves the viewport to the point that was clicked (may be more than a page)

In standalone, the scrollbars use the defaults for each platform (macOS: WhenScrolling + JumpToPoint, Win/Linux: AlwaysVisible + JumpToPoint)
In the bridge, we have lifted some platform logic in ScrollbarHelper to react to macOS system prefs changes, like Swing does. On Win/Linux it's always using the defaults, like in standalone.
TabStrip scrollbars require a lot of special handling, we'll take care of them separately (#553)
Scrollbars remain "active"/"visible" as long as the mouse moves over the content, like in Swing, if you set it up correctly
ScrollableContainer API makes it all super easy for you, and handles overlaying or not the scroll bars over the scrollable content, like Swing does
The scrollbarContentSafePadding function provides an optional padding to apply to scrollable content important parts to avoid them being overlapped by WhenScrolling scrollbars.

TODO

[x] Fix WhenScrolling style on macOS standalone/bridge

Visibility does not animate in/out (today's regression)
Horizontal scrollbars not appearing?

[x] Fix/implement lingering when the mouse moves in all ScrollableContainer variants
[x] Fix stuff broken in the standalone sample (if any — Markdown editor?)
[x] Fix ScrollableContainer issues (layout bugs & crashes)
[x] File issues for minor/separate issues (tabStrip, text area, etc.)
[x] Investigate native crash in Swing Comparison tab in IDE sample — split out to #556
[x] Test on Windows/Linux standalone, fix issues there
[x] Test on Windows/Linux bridge, fix issues there
[x] Do the last round of holistic testing
[x] Decide whether we should revisit and clean up more in the future

Split out #558 #559 and #560

@hamen @devkanro I am sorry this ended up being huge, I had to rewrite ~95% of everything scrollbars as the previous implementation was simply not working well, and/or not flexible enough.
Once this is merged we can ship 0.23.0, finally!
PS: there are some minor inconsistencies with Swing tracked in the linked issues in the description — they're all P2/P3 for what I am concerned, though.

No worries. We will take care of it on Monday 🙏🏻


Moving the ultrasound meta information tag names from PLUS to igtlio.

After this is merged, the pull request for PlusLib where this is removed can be performed.

One small item is that right now igtlio is application agnostic. Anything to discuss or just add this as it hurts nothing?


serde_json::value::Value set_value

I found the get() and get_mut() methods on serde_json::value::Value.
I miss a set_value(key, value) method.
Now I have to write:
record["entry"] = v.clone();

But this is confusing. What happens if this entry does not exist?
Does it panic? Or does it create a new entry?
Also annoyingly Clippy continues to warn me "indexing may panic".

That does the right thing. Indexing in Value does not panic. This seems like a Clippy lint being too aggressive.

Doesn't set_value(key, value) look more Rust idiomatic?
So we can chain the functions call like:
set_value(key, value).do_something()...
With the assignment style record["entry"] = v.clone(); this is not possible.


Omit error state for network agent only

WIP as I want to examine test results to make sure nothing is broken

Can be merged


[Kyuubi #2071] Using while-loop instead of map/range to improve performance in RowSet

Why are the changes needed?

Using while-loop instead of map/range to improve performance in RowSet
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #2107 (b6d70b3) into master (7d66e9a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2107      +/-   ##
============================================
+ Coverage     60.70%   60.73%   +0.02%
  Complexity      108      108
============================================
  Files           320      320
  Lines         15468    15481      +13
  Branches       1989     1991       +2
============================================
+ Hits           9390     9402      +12
- Misses         5273     5275       +2
+ Partials        805      804       -1

Impacted Files
Coverage Δ

...org/apache/kyuubi/engine/spark/schema/RowSet.scala
91.21% <100.00%> (+1.58%)
:arrow_up:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
61.33% <0.00%> (-1.34%)
:arrow_down:

...ala/org/apache/kyuubi/session/SessionManager.scala
85.12% <0.00%> (-0.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d66e9a...b6d70b3. Read the comment docs.

great improvement, thanks @zhaomin1423 merged to master


Modifying tasks

Work in progress

Codecov Report
Base: 59.95% // Head: 56.53% // Decreases project coverage by -3.41% :warning:

Coverage data is based on head (76f78e8) compared to base (114ec46).
Patch coverage: 17.58% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
- Coverage     59.95%   56.53%   -3.42%
- Complexity      573      575       +2
============================================
  Files           123      125       +2
  Lines          2110     2271     +161
  Branches        247      276      +29
============================================
+ Hits           1265     1284      +19
- Misses          776      913     +137
- Partials         69       74       +5

Impacted Files
Coverage Δ

.../seedu/address/logic/commands/EditTaskCommand.java
0.00% <0.00%> (ø)

...ress/logic/commands/RandomlyAssignTaskCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
55.88% <0.00%> (-1.70%)
:arrow_down:

...ain/java/seedu/address/logic/parser/CliSyntax.java
0.00% <ø> (ø)

...du/address/logic/parser/EditTaskCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
80.70% <0.00%> (-4.49%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
77.77% <0.00%> (-2.23%)
:arrow_down:

...c/main/java/seedu/address/model/team/TaskList.java
42.55% <0.00%> (ø)

src/main/java/seedu/address/model/team/Team.java
64.86% <0.00%> (-2.75%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to get authentication success/failure events?

We have an authentication service using spring-security-oauth using Spring Boot. This application is the OAuth authorization server as well as an OAuth resource server. We rely on auto configuration as much as possible only overriding where we need it. We've had this issue for a while but with a recent need to for better auditing, we now need to resolve it.
We noticed that for user based login, the ProviderManager used is configured with a default event publisher that publishes authentication success and failure events which we use for various tasks (locking accounts, audit trail, etc.). However, there does not seem to be any such event publisher associated with the ProviderManager used for the BasicAuth filter being used for obtaining access tokens. I've been digging around for a while now and I am not seeing any way of configuring one w/o replacing everything that gets created for me through the use of the @EnableAuthorizationServer annotation. Specifically, the created ProviderManager appears to be created in org.springframework.security.oauth2.config.annotation.web.configurers.AuthorizationServerEndpointsConfigurer#addUserDetailsService.
Having these events is critical for a lot of features (account lockout, audit logging, etc) so i would presume what i'm trying to do is possible with little effort but I just cannot seem to figure this out. Any help is appreciated.
I am currently using spring-security-oauth version 2.0.11.RELEASE

Were you able to find any solution for this?

You can implement an AuthenticationSuccessHandler and am
AuthenticationFailureHandler Bean and add them to your security config with:
...
login()
.successHandler(successHandler)
.failureHandler(failureHandler);
I made a couple of example projects at mjohns39/demo-stateless and
mjohns39/demo-oauth that should help you get started.
On Mon, Apr 16, 2018, 10:36 AM happygoud<EMAIL_ADDRESS>wrote:

Were you able to find any solution for this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/spring-security-oauth/issues/1317#issuecomment-381621022,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF3RqGRC4hyGBx64q8zBXlP8kURO8Vhzks5tpKyCgaJpZM4Sw95T
.

Apologies.  It's mjohns39/oauth-demo
On Tue, Apr 17, 2018, 7:07 AM Michael Johnson<EMAIL_ADDRESS>wrote:

You can implement an AuthenticationSuccessHandler and am
AuthenticationFailureHandler Bean and add them to your security config with:
...
login()
.successHandler(successHandler)
.failureHandler(failureHandler);
I made a couple of example projects at mjohns39/demo-stateless and
mjohns39/demo-oauth that should help you get started.
On Mon, Apr 16, 2018, 10:36 AM happygoud<EMAIL_ADDRESS>wrote:

Were you able to find any solution for this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/spring-security-oauth/issues/1317#issuecomment-381621022,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF3RqGRC4hyGBx64q8zBXlP8kURO8Vhzks5tpKyCgaJpZM4Sw95T
.

Having the same issue. Any solution or workaround for this?


Can not run the project with Godot 3.1 alpha or the master branch

Version: 3.1.alpha.official
System: Fedora 28 x86_64

Also can not run with 3.0.6 stable, with the output:
OpenGL ES 3.0 Renderer: Mesa DRI Intel(R) HD Graphics 5500 (Broadwell GT2)
OPENING: /home/liangdi/git/godot/make-pro-2d-games-with-godot (::home::liangdi::git::godot::make-pro-2d-games-with-godot)
ERROR: _load_settings_text: Condition ' config_version > 3 ' is true. returned: ERR_FILE_CANT_OPEN
   At: core/project_settings.cpp:495.
ERROR: _load_settings_text_or_binary: Couldn't load file '/home/liangdi/git/godot/make-pro-2d-games-with-godot/project.godot', error code 12.
   At: core/project_settings.cpp:519.
OpenGL ES 3.0 Renderer: Mesa DRI Intel(R) HD Graphics 5500 (Broadwell GT2)

Did you try running it with 3.1 first? In that case, 3.0.6 won't open it.

Did you try running it with 3.1 first? In that case, 3.0.6 won't open it.

yes ...  i try again , it is the reason , so , it is not a issue now ... thanks


Accept system test sha in test pipeline

The task is very similar to https://github.com/adoptium/aqa-tests/issues/2680. We need to update ant, so we can set sha, tag, or branch in ADOPTOPENJDK_SYSTEMTEST_OWNER_BRANCH and OPENJ9_SYSTEMTEST_OWNER_BRANCH.
Code needs to be updated in:
https://github.com/adoptium/aqa-tests/blob/master/system/common.xml#L87
https://github.com/adoptium/aqa-tests/blob/master/system/common.xml#L122

Can I take this issue thanks


Multi factor authentication is not supported

Using Passbolt 4.3.0, I have the following error when Multi factor authentication is turned on ("TOTP authenticator : Enabled"):
Traceback (most recent call last):
  File "/Users/gjherbiet/Development/Restena/ansible-passbolt/example.py", line 8, in <module>
    p = PassboltAPI(dict_config=dict_config)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/ansible/8.4.0/libexec/lib/python3.11/site-packages/passbolt/__init__.py", line 47, in __init__
    self.login()
  File "/opt/homebrew/Cellar/ansible/8.4.0/libexec/lib/python3.11/site-packages/passbolt/__init__.py", line 160, in login
    self.get_cookie()
  File "/opt/homebrew/Cellar/ansible/8.4.0/libexec/lib/python3.11/site-packages/passbolt/__init__.py", line 142, in get_cookie
    user_id = json.loads(response.text)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Further analysis revealed that in login, self.stage2(str(self.nonce)) returns True at line 177 but further in call to get_cookie() :

response has HTTP status 302
token is empty
response.text is empty

Probably because the actual user is not found/properly authenticated due to 2FA being enabled.
Turning Multi factor authentication off on the web UI solves the issue.

Hi @gjherbiet
Yes, TOTP is currently not implemented as you noticed :cry:
I have no ETA for now about this implementation. Patches are welcome :slightly_smiling_face:


fix: update nginx ssl ciphers to get TLSv1.2 working again

Reference: https://cipherlist.eu/

How to verify:
$ curl -I -v --tlsv1.2 --tls-max 1.2 https://example.org

So far we mostly configured the servers according to https://ssl-config.mozilla.org/#server=nginx&version=1.18.0&config=intermediate&openssl=3.0.2&ocsp=false&guideline=5.7. Not entirely sure about the differences though. We could stick to this to be in line with our other services. What do you think?


How to send Reply of the message?

How can i send reply of message like in Whatsap?

Long press the message in Chat SDK v5 then click reply.

Can you send me link of  "Chat SDK v5"?
On Thu, Jun 11, 2020 at 4:33 PM Ben Smiley<EMAIL_ADDRESS>wrote:

Closed #618 https://github.com/chat-sdk/chat-sdk-android/issues/618.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chat-sdk/chat-sdk-android/issues/618#event-3433734928,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFLC2XI2HGHRDSER2OJUSD3RWC6JJANCNFSM4MOZM4PA
.

https://github.com/chat-sdk/chat-sdk-android

For saving data to the database, are you using Firebase or Firestore?
On Thu, Jun 11, 2020 at 5:19 PM Ben Smiley<EMAIL_ADDRESS>wrote:

https://github.com/chat-sdk/chat-sdk-android
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chat-sdk/chat-sdk-android/issues/618#issuecomment-642607652,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFLC2XLHUMPLXDJOC73PNFDRWDDVPANCNFSM4MOZM4PA
.


Search in menu & submenu with JQuery Searchable plugin - multilevel

I want to search in menu title and submenu, but in JQuery Searchable Plugin can't find this option. When I type characters, I can find menu but can't find submenu. Searchable plugin has childSelector option but this option is searching just the first level.
http://stackoverflow.com/questions/29799273/search-in-menu-submenu-with-jquery-searchable-plugin-multilevel

Posted a solution on SO
Let me know if that works

It seems that this issue has been resolved on StackOverflow, so closing this now.


Building for android fails

Summary
I understand this may not be the appropriate place to file this issue, however I'm hoping someone may be able to provide some guidance on how I should proceed.
I'm trying to cross compile the libwebsockets project for android. That project provides some build instructions for getting mbedtls cross compiled as well. Those instructions are obviously out of date and no longer work.
Unfortunately, the libwebsockets developers appear unwilling to investigate further since mbedtls isn't part of their library.
I don't expect anyone here to try and fix their instructions, but was hoping someone could take a look at the toolchain file they provide and see if anything stands out.
Otherwise any suggestions on how to proceed with debugging this would be appreciated!
System information
Mbed TLS version (number or commit id): master (v2.26.0)
Operating system and version: Ubuntu 19.10 (5.3.0-64-generic)
Configuration (if not default, please attach config.h): see below
Compiler and options (if you used a pre-built binary, please indicate how you obtained it): cross compiling with android NDK
Additional environment information:
Following build instructions provided by the libwebsockets project: https://libwebsockets.org/git/libwebsockets/tree/READMEs/README.build-android.md
Of particular note is the inclusion of:
-DCMAKE_TOOLCHAIN_FILE=../libwebsockets/contrib/cross-aarch64-android.cmake

The source for which can be found here: https://github.com/warmcat/libwebsockets/blob/main/contrib/cross-aarch64-android.cmake
Expected behavior
I would expect the build to succeed. Although I understand that the toolchain file is likely the source of the problem.
Actual behavior
Build fails with the following:
[ 32%] Building C object library/CMakeFiles/mbedcrypto_static.dir/rsa_internal.c.o
[ 32%] Building C object library/CMakeFiles/mbedcrypto_static.dir/sha1.c.o
[ 32%] Building C object library/CMakeFiles/mbedcrypto_static.dir/sha256.c.o
[ 32%] Building C object library/CMakeFiles/mbedcrypto_static.dir/sha512.c.o
[ 33%] Building C object library/CMakeFiles/mbedcrypto_static.dir/threading.c.o
[ 33%] Building C object library/CMakeFiles/mbedcrypto_static.dir/timing.c.o
[ 33%] Building C object library/CMakeFiles/mbedcrypto_static.dir/version.c.o
[ 33%] Building C object library/CMakeFiles/mbedcrypto_static.dir/version_features.c.o
[ 33%] Building C object library/CMakeFiles/mbedcrypto_static.dir/xtea.c.o
[ 34%] Linking C static library libmbedcrypto.a
Error running link command: No such file or directory
make[2]: *** [library/CMakeFiles/mbedcrypto_static.dir/build.make:1105: library/libmbedcrypto.a] Error 2
make[1]: *** [CMakeFiles/Makefile2:490: library/CMakeFiles/mbedcrypto_static.dir/all] Error 2
make: *** [Makefile:129: all] Error 2

Additional information
Using android NDK version 21.1.6352462.

@fougere-mike the issue seems to be related to this one: https://github.com/ARMmbed/mbedtls/issues/4270.
For a quicker, temporary fix you could try taking the question to the mailing list and see if someone else has run into the same issue too: https://lists.trustedfirmware.org/mailman/listinfo/mbed-tls


Cache warmup doesn't work for transitive path patterns

Query is relatively simple but takes really really long time to compute (~7 seconds):
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
SELECT * WHERE {
  <http://artresearch.net/resource/E13/203420c0f7333112943e97f8c59ce712cc8d28e7dd6d709655e888f65d27ac7a> crm:P134_continued* ?att2 .
}

Warmup output:
Pin: crm:P134_continued* ordered by subject only
SELECT ?x ?y WHERE { ?x crm:P134_continued* ?y } INTERNAL SORT BY ?x
Result size: 16,101,577

Here is a query plan:

Maybe I'm missing something, or is that a known bug?

Hi Artem,
In the combination of warmup queries + transitive paths  and for the query planning of the transitive paths in general there are various known bugs (but only known since a few days). We'll keep you posted (for some of them the solution is known and only has to be written and merged, and the other things bother us as well so we'll also analyze them).

Thank you Johannes!

Tried with the latest master, still get the same behavior. Cache warmup for transitive path query has no effect on the query execution and query plan.


Implement --no-pin option.

See #94.

Coverage decreased (-0.6%) to 71.548% when pulling 8d0c3559bf6ff999f2c678bb055cdea75d8b8559 on dxsh:master into 755e20196a1da202d5231fc659be3eed87161d2c on bndr:master.


Docker run doesn't find my certificates

Hi,
I put my Let's Encrypt certificates in /etc/cert and link to them in "docker run"
docker run  --net=host --name host-ldap --env LDAP_ORGANISATION="hawaiian" --env LDAP_DOMAIN="<blank>" --env LDAP_ADMIN_PASSWORD="<blank>"  --env LDAP_TLS_CRT_FILENAME=cert7.pem  --env LDAP_TLS_KEY_FILENAME=privkey7.pem --env LDAP_TLS_CA_CRT_FILENAME=fullchain7.pem --env LDAP_TLS_VERIFY_CLIENT=try --volume /docker-data2/slapd/database:/var/lib/ldap --volume /docker-data2/slapd/config:/etc/ldap/slapd.d  --volume /etc/cert:/container/service/slapd/assets/certs   --detach osixia/openldap:latest
but from docker logs, it just doesn't find them and makes a mess of the /etc/cert directory, changing permsisions and users. The log says;
*** CONTAINER_LOG_LEVEL = 3 (info)
*** Search service in CONTAINER_SERVICE_DIR = /container/service :
*** link /container/service/:ssl-tools/startup.sh to /container/run/startup/:ssl-tools
*** link /container/service/slapd/startup.sh to /container/run/startup/slapd
*** link /container/service/slapd/process.sh to /container/run/process/slapd/run
*** Set environment for startup files
*** Environment files will be proccessed in this order :
Caution: previously defined variables will not be overriden.
/container/environment/99-default/default.startup.yaml
/container/environment/99-default/default.yaml

To see how this files are processed and environment variables values,
run this container with '--loglevel debug'
*** Running /container/run/startup/:ssl-tools...
*** Running /container/run/startup/slapd...
No certificate file and certificate key provided, generate:
/container/service/slapd/assets/certs/pass1.crt and /container/service/slapd/assets/certs/privkey7.crt
2019/10/26 21:44:55 [INFO] generate received request
2019/10/26 21:44:55 [INFO] received CSR
2019/10/26 21:44:55 [INFO] generating key: ecdsa-384
2019/10/26 21:44:55 [INFO] encoded CSR
2019/10/26 21:44:55 [INFO] signed certificate with serial number<PHONE_NUMBER>18165793005416985332240949707663262459
Link /container/service/:ssl-tools/assets/default-ca/default-ca.pem to /container/service/slapd/assets/certs/pass2.crt
Generating DH parameters, 2048 bit long safe prime, generator 2
This is going to take a long time

Is there anyway around this?

@EthicsGradient not sure if this could be the reason, but most of the time, your certificates/key files/directory on the host, might have "bad" permissions, preventing the container to read informations and potentially run into fallback mechanism
You can also try to run your command above, adding --loglevel debug so that you have more insights on what is going on.
Knowing your host&OS type/versions and the docker version you are using might also help diagostics in this channel

Hi,
Yes Permissions is a tricky one, you want to keep them as tight as possible for security and the fact that some apps reject them if too loosely set. My OS is Debian Buster (stable atm) and docker version is as follows;
Docker version 19.03.4, build 9013bf583a
Installed from the docker repository.
Thanks,

@EthicsGradient did you succeed to get more traces by adding the --loglevel debug arguments to your docker run command ?
If you are running your Debian machine with SELinux enable, may be adding :Z to some/every volume mount might help. See this link which also refers to the docker-run man page but I personally find this page much clearer

Did you solve this @EthicsGradient ? I have the same problem.


Add documentation for the pending 0.9.10-incubating release.

This is the generated API documentation and HTML manual build from the "0.9.10-incubating-RC1" tag of incubator-guacamole-client (guacamole-ext, guacamole-common, and guacamole-common-js), incubator-guacamole-server (libguac), and incubator-guacamole-manual (gug). The symbolic links have not yet been updated, as the release has not yet occurred.
I've also added a Perl script which automatically adds the Google Analytics tracking code to given HTML files. This script has already been applied to the HTML for the documentation described above.
Beware that the diff displayed within the PR will only be partial. The massive number of files makes GitHub sad:

Ok, I've had a look through this as well as I can, and I think it looks alright.


feat: add prerender:route hook

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add a new hook prerender:route that is called when a single page has been successfully prerendered.
This hook can be used externally to create specific logic tied to route generation, such as editing output of a route.
generateRoute now returns { contents, route, filePath } instead of nothing, in order to:

Access the saved file directly by its filePath.
Read the contents that have been generated.

I can see more potential for SSG (fully static).
A quick example usage could be to dynamically download and replace static assets, stored on an API server, that you don't want to use in production (parse HTML content, download image, replace image path with the one downloaded locally).
Please, let me know if this change is not intended for nitro.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks! This also resolves https://github.com/unjs/nitro/issues/88

❤


Forbid unnecessary parenthesis in IntelliJ

This is an error in Checkstyle so we should call it out in IntelliJ as well.

Enabling the inspection marks a lot of things that should not be considered a problem, let's abandon doing so.


keyup keyboard events

Would be super nice to have key released events to be published

Unfortunately, unix-based terminals don’t send any data when keys are released. This may be possible in Windows (see #140) however if we can’t offer release events in a cross-platform manner, we’re unlikely to offer them in a Windows-only fashion.

Ah I wasn't aware of this, no worries then


[Bug] nvm is asking its user to install "N/A"

$ nvm ls
            N/A
default -> 4 (-> N/A)
node -> stable (-> N/A) (default)
iojs -> N/A (default)
lts/* -> lts/boron (-> N/A)
lts/argon -> v4.6.2 (-> N/A)
lts/boron -> v6.9.1 (-> N/A)
$ echo "4" > .nvmrc
$ nvm use
Found '/home/peter/.nvm/.nvmrc' with version <4>
N/A: version "N/A" is not yet installed.

You need to run "nvm install N/A" to install it before using it.

@PeterDaveHello should this not appear in nvm 0.32.1? Just pasted this on a fresh server:
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.32.1/install.sh | bash

Restarted the shell, and got the same thing.
[zlatko@droplet ~]$ nvm use 6
N/A: version "N/A" is not yet installed.

You need to run "nvm install N/A" to install it before using it.

Not a big deal, just wanted to let you know.

@zladuric it'll be after v0.32.1, @ljharb says he'll bump the version this month.

This happens because nvm doesn't know which node version to be loaded when nvm.sh script is run.
To use latest installation of nodejs, type this in command line : nvm alias default node. This removed the error for me


Proof sketch that CSJ control logic minimizes itself on approach to Praos

We desire a single set of CSJ rules that automatically incur less frequent ledger peer interactions during Praos than they do during Genesis (ie during bulk fetch).

@nfrisby, is this issue still relevant?


council_demand property is missing from cwt tools config

This is from the vanilla inline paragon/global_faction_demands.txt

https://github.com/DragonKnightOfBreeze/cwtools-stellaris-config/commit/d861d78293f568dea46ec996df7e7e46f86d8bb0


Clarify next-gen auto_attribs inference rules

The next-gen auto_attribs api documentation does not clearly describe
cases where (a) only a subset of attributes are annotated and (b)
field definitions are provided for a subset of fields. Update
docstring to reflect current, desirable, behavior.
Add tests to clarify .define behavior focused on fully-annotated
classes with partially-defined fields, which is commonly used to add
non-default behavior to a subset of a classes fields. For example:

@attr.define
class NewSchool:
    x: int
    y: list = attr.field()

    @y.validator
    def _validate_y(self, attribute, value):
        if value < 0:
            raise ValueError("y must be positive")

The previous docstring could be read to imply that:

The new-school API will not infer auto_attribs if there are any
unannotated attributes.
The new-school API will not infer auto_attribs if any attr.ib are
defined, even if those attr.ibs are type annotated.

Pull Request Check List
This is just a friendly reminder about the most common mistakes.  Please make sure that you tick all boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.  If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.

[x] Added tests for changed code.
[x] New features have been added to our Hypothesis testing strategy.
[x] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[x] ...and used in the stub test file tests/typing_example.py.

[x] Updated documentation for changed code.

[x] New functions/classes have to be added to docs/api.rst by hand.
[x] Changes to the signature of @attr.s() have to be added by hand too.
[x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.  Find the appropriate next version in our __init__.py file.

[x] Documentation in .rst files is written using semantic newlines.
[x] Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

Follow-up to #676
Maybe relevant to #668
I had a few free moments to begin reading on the very nice next-gen APIs, but found the main documentation somewhat confusing. My read of the behavior "as documented" was somewhat dismayed, as I often define extra behavior for annotated classes with a small number of annotated attr.ibs. The behavior "as tested" was, gladly, what I expected.

thanks!


Using typescript in .js

I want to know more about the inner workings of hygen for learning purposes. That's why I cloned the repository, installed the dependencies and opened the project with vscode. To my dismay there are a lot of error messages in the source code, because typescript syntax is used in a .js file.
I have also noticed this in other open source projects on github and I am wondering what the reason for this is (I assume so that it can be run without having to compile it to js first), and how you people develop this program further without being annoyed by constant error messages? Am I missing something?

(example of index.js)

Hi, Hygen actually uses Flow, not typescript; the errors are actually because something is causing your editor to think everything is Typescript. Flow is the gradual typing system that Facebook uses in production (and made by Facebook).
At some point in time Flow was a much better alternative to Typescript, and over a rather long period of time, it's now starting to be a consensus that Typescript is the better choice for projects looking forward; but I guess this is the kind of thing people can argue about forever.
In summary, not directly related to your experience, Hygen will be ported into Typescript in the immediate future.
For your learning purposes -- Flow and Typescript are virtually similar, so you can still learn how Hygen works. Of course, you have myself and the fantastic Hygen committers to help in every question, so feel free.

Thanks for the quick reply! I have now installed flow and all the errors are gone! But if I install the flow extension (https://marketplace.visualstudio.com/items?itemName=gcazaciuc.vscode-flow-ide) a bunch of errors return because for instance the required return types aren't met properly. Is this intentional? Can I help with the conversion to typescript?

Closing since we moved to Typescript! 😄


Remove the tritonclient importorskip from conftest.py

This causes all tests to be skipped in environments without Triton, but we do have tests that should run fine on CPU without Triton.

I'm going to add tritonclient to the test dependencies instead

Once #187 is merged. We could then follow-up with a PR to remove all the tritonclient importorskip lines from the tests, switching to a regular import. It seems like this PR may still be relevant? Unless we want to maintain the ability to run the tests in a test environment where tritonclient isn't installed?

Yeah, that's a good thought. I'll put together a PR like that.


This is test

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Ohh the DCO error can be kinda trick to solve! Let me know if you need help.


License

I don't see a license file, can you add it?

Hi,
The license file has been added, thanks!
Best,
Youmin


Create Pool management API

A rustful server allows people to add, read and remove backends from a
pool.
The Pool was refactored so it could be used between multiple threads.
I also changed the Pool interface so that it accepted sockets intead
of a ip and port string.
There main proxy now runs off the main thread.

Travis having problems again. Merging as I am confident the tests are passing.


how to add another peer?

how to add another peer?

run the script, it'll say Wireguard is already installed and ask you what you want to do. select add a user (peer).

Easy


clickhouse: <IP_ADDRESS> -> <IP_ADDRESS>

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/clickhouse/versions.
meta.description for clickhouse is: '"Column-oriented database management system"'.
meta.homepage for clickhouse is: '"https://clickhouse.yandex/"
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found <IP_ADDRESS> with grep in /nix/store/z8935raywhngmajmwl6f2b6pblisf8rc-clickhouse-<IP_ADDRESS>
directory tree listing: https://gist.github.com/1948b1a68d7d9187e1b1b1c80fa783b3
du listing: https://gist.github.com/fe4da601f049ffac3c37d28adaaaa72b

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
clickhouse

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z8935raywhngmajmwl6f2b6pblisf8rc-clickhouse-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A clickhouse https://github.com/r-ryantm/nixpkgs/archive/422c7fe2f611ce03e82853594ee8ca125c923dd4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z8935raywhngmajmwl6f2b6pblisf8rc-clickhouse-<IP_ADDRESS>
ls -la /nix/store/z8935raywhngmajmwl6f2b6pblisf8rc-clickhouse-<IP_ADDRESS>/bin

cc @orivej for testing.

@GrahamcOfBorg build clickhouse

@GrahamcOfBorg build clickhouse

@GrahamcOfBorg build clickhouse


Mapping query builder

Replaces #1272.
Integrates the new document manager features currently in develop.

Metadata mapping: The subscribers that were previously simply mapping values now only have to provide some metadata (which will eventually be cached -- so they won't even be called in the future).
Query Builder: Adds DI configuration for the query builder.

Rebased and reviewed, need to do the above fixes but seems OK. Feel free to review @danrot @wachterjohannes
We also need a new tag of PHPCR-ODM either before merging or before the next Sulu release, I created: https://github.com/doctrine/phpcr-odm/issues/645

Is this PR still valid? Or do you have to make a new one?

I will adapt this PR.

Replaced by #1863


fix: git commit allows empty message despite useEditorAsCommitInput is enable

This PR fixes #152702

@susiwen8, thank you very much for your contribution. I have tested out the code and the problem is that if you always add the  --allow-empty-message argument, than you will not be able to "cancel" the commit flow if you use the editor as a commit input and you close the editor without entering any text. I am working on a fix right now, and I hope to have something checked in tomorrow.


[FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation

What is the purpose of the change
Currently, submitting a job starts with storing the JobGraph (in HA setups) in the JobGraphStore. This includes writing the file to S3 (or some other remote file system). The job submission is done in the Dispatcher's main thread. If writing the JobGraph is slow, it would block any other operation on the Dispatcher.
Brief change log

The dispatcher put JobGraph asynchronously in ioExecutor
The dispatcher write To ExecutionGraphInfoStore asynchronously in ioExecutor
The JobGraphWriter interface class adds a putJobGraphAsync method for asynchronous write operations
Implementation class DefaultJobGraphStore adds the putJobGraphAsync method for asynchronous write operations

Verifying this change
This change added tests and can be verified as follows:

Added  the Dispatcher JobSubmission test, use ZooKeeperStateHandleStore as JobGraphStore
Added  the Dispatcher JobSubmission test, use KubernetesStateHandleStore as JobGraphStore

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thank you for your suggestion, I have modified that interface and also corrected the point you mentioned earlier.

@XComp  I created a new pr，https://github.com/apache/flink/pull/24366  Please review it when you have time.


Withdrawn sanity check should log error, not halt process

Couldn't generate an acceptance report due to a single user's mis-filed QNRs.
Generate an error log, don't halt the process via exception.

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/models/qb_status.py:

Line 146:68: W291 trailing whitespace
Line 147:21: E131 continuation line unaligned for hanging indent


Is anyone able to install label-maker on osx ? It requires a specific version of rasterio which can't seem to be installed.

Label-maker requires rasterio==1.0a12. However every time i try to install that version with python3 i get 20 errors. Any of the other more recent versions of rasterio install fine. But label-maker always uninstalls those and tries to install 1.0a12 unfortunately.
257 warnings and 20 errors generated.     error: command 'clang' failed with exit status 1     ---------------------------------------- ERROR: Command errored out with exit status 1:
Just wanted to see if there are osx users who have been able to install label-maker and the specific version of it's dependency rasterio that it requires.

What python version are you using @kunal732? I also get a clang build error on 3.7 against the pyclipper dependency; on 3.6.8 I was able to install correctly. At the same time, I would like to eventually update all the dependencies as have some automated builds to test for this as well

@drewbo Currently on 3.7.4. I'll try a different version.

@drewbo switching over to 3.6.8 solved the issue. Thank you

I'll try to improve the install + build in the future with better testing + wheels but glad you have it working for now


Beta branch

Updated pleco to 0.2.3. This is mostly just better documentation.
pleco_engine has a complete redo of the multi-threading approach, with finer tuned controls.

Coverage decreased (-0.3%) to 83.044% when pulling a0e7adc65c29c4f0129c7652a9689ec9771a6ccb on Beta-Branch into 7b686cb0151f57548d1349accafd340faafc9546 on master.


Fix MdTable.vue numberOfRows bug

Bug
It happened when I removed one or more rows from the table and clicked on the "select all" checkbox. The number shown was the original data array size, not the new one (after deleting some itens). Example:
nutrition = [1,2,3,4,5];
numberOfRows = 5;

nutrition.splice(1,1);

nutrition = [1,3,4,5];
numberOfRows = 5; // this is the bug. it should be 4, not 5.

Fix
File: mdTable.vue
  watch: {
    data() {
      this.numberOfRows = this.data.length;
    }
  },

This will guarantee the numberOfRows is always up to date.

Cool. Sounds good! Merged!


Split README into user and developer files

There's a lot of detail for developers in the main readme that users don't care about. The main readme should talk about high-level things the user cares about, as well as demos and how to use it.
A later section can link to a document with how to build it, since there's so much.

done in wiki


🐛 BUG: wrangler dev still sometimes fails to exit cleanly after Ctl-C

What version of Wrangler are you using?
2.0.2
What operating system are you using?
Mac
Describe the Bug
Occasionally, hitting Ctrl-C when running wrangler dev does not result in the process exiting. Instead it just hangs.
Previously we had this problem but thought we had fixed it with #732. But it seems to have reappeared.

cc @d3lm

Oh no, how often does it still happen?

I think it only happens if you have made a request to the Worker and there is a connection being held open somewhere.


Available on CDN?

I was trying to find stackframe and error-stack-parser on a CDN somewhere, I found stacktrace on cdnjs but not the others. Have I missed them somewhere?

This is an omission on our part. We'll get these posted soon!


Path does not contain permissions information. Does not seem to be documented anywhere

[[Describe the bug
When I try to post to this URL:
https://graph.microsoft.com/beta/deviceManagement/reports/getAppStatusOverviewReport
With this body:
{
"filter": "(ApplicationId eq 'efd328e8-c746-4b70-ad10-38594c1f0e09')"
}
I get this error:
{
"error": {
"code": "UnknownError",
"message": "{"ErrorCode":"Forbidden","Message":"{\  \"_version\": 3,\  \"Message\": \"An error has occurred - Operation ID (for customer support): 00000000-0000-0000-0000-000000000000 - Activity ID: 820c8b70-fa74-0303-b6b3-0166b70e2b10 - Url: https://fef.msua08.manage.microsoft.com/AppLifecycle_2211/StatelessAppMetadataFEService/deviceManagement/reports/microsoft.management.services.api.getAppStatusOverviewReport?api-version=5022-09-01\",\  \"CustomApiErrorPhrase\": \"\",\  \"RetryAfter\": null,\  \"ErrorSourceService\": \"\",\  \"HttpHeaders\": \"{\\\"WWW-Authenticate\\\":\\\"Bearer realm=\\\\\\\"urn:intune:service,9225b241-44e1-44a8-8bfe-c10e39177505,f0f3c450-59bf-4f0d-b1b2-0ef84ddfe3c7,3e9c57b9-808d-4aa0-9500-4b2d369279e7\\\\\\\"\\\"}\"\}","Target":null,"Details":null,"InnerError":null,"InstanceAnnotations":[]}",
"innerError": {
"date": "2022-11-17T14:53:00",
"request-id": "0a7d8080-29c0-43bc-816a-c7893a19f73e",
"client-request-id": "820c8b70-fa74-0303-b6b3-0166b70e2b10"
}
}
}
This query works on my admin account. I must be missing a permission, but it does not tell me which.
To Reproduce
Steps to reproduce the behavior:

In graph explorer, execute above query

Expected behavior
Should show which permission is missing
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser: Edge

Smartphone (please complete the following information):
N/A
Additional context
Add any other context about the problem here.
](https://graph.microsoft.com/beta/deviceManagement/reports/getAppStatusOverviewReport)](https://graph.microsoft.com/beta/deviceManagement/reports/getAppStatusOverviewReport)

Hi @garport ,
This seems like an issue with the Graph API and the API Documentation.
We only handle Graph Explorer-related queries.
For help with this issue, please post this question here: https://learn.microsoft.com/en-us/answers/products/graph where the appropriate team shall be able to offer more assistance.


Example for HTML output

Someone posted an example for an HTML report generated by grunt-cucumberjs  at cucumber/cucumber-html. It looks good, but I'm sure if this is the direction where we are heading, but since this is kind of user input I posted it here.

Personally I would not use 3D diagrams because the representation can be misleading: http://blog.visual.ly/2ds-company-3ds-a-crowd/.

I don't think this is relevant here. The pretty formatter is for the console. HTML output would be done by another tool in another repo.

I think you're right, then we should change this line, shouldn't wee? https://github.com/cucumber/cucumber-pretty-formatter/blame/master/README.md#L9

yup


Workarounds for Reflection.Execution

We don't support Delegate.Combine yet, or delegates to valuetypes.
I'm not bothering with CORERT-TODOs because Reflection.Execution was
forked for CoreRT and none of this code is meant to stay around long
term. The only thing we need to keep track of is blob format changes.

LGTM


Adding several stations: When adding several modules, they all use the same config

Living in the proximity of two stations and with two frequent destinations, I want to add this splendid module twice. This works, kind of, but all the modules are using the config from the module first defined.
Of course, this might be the wrong approach. Maybe being able to add several stations to one module would be the preferred way of achieving this.

Hi there! Sorry for the extremely late reply.
That's a good point and your use-case is very realistic; this module does not work very well when adding it multiple times to a single MagicMirror!
An idea I had in mind was to implement the feature you are requesting (letting you specify multiple from/to station ID's) and make the module iterate over the from/to station ID pairs by fading them in/out after a certain time interval (e.g. iterate to next from/to pair every 10 seconds). I will look into this asap 😊

I have now added support for adding several stations to one module See README for more information. Thank you for the issue!


add Native Debug to image for Rust debugging

https://github.com/saviorisdead/RustyCode/issues/37#issuecomment-218968530
https://marketplace.visualstudio.com/items?itemName=webfreak.debug
current version is 0.8.1

shows it working, but setup issues with .gdbinit.
https://github.com/saviorisdead/RustyCode/issues/143

https://packages.debian.org/jessie/gdb
Debian Jessie packages 7.7.1
sudo apt-get install -y gdb

Debug Console
fwarning: Missing auto-load scripts referenced in section .debug_gdb_scripts
of file /home/vscode/demo/target/debug/demo
Use `info auto-load python-scripts [REGEXP]' to list them.
Running executable
warning: Error disabling address space randomization: Operation not permitted
Hello, world!

Literally run it in the VSCode Debug Console:
info auto-load python-scripts

not available
info auto-load python-scripts
Loaded  Script
No      gdb_load_rust_pretty_printers.py

About the pretty printers:
http://michaelwoerister.github.io/2015/03/27/rust-xxdb.html

#12 added the extension

I'm testing this with #18 and https://github.com/nickel-org/nickel.rs/issues/346. I'd like to be able to break for http requests. The key to removing the pretty printer warnings was to use rust-gdb wrapper script which can be set with "gdbpath": "rust-gdb",.
Here is the full launch.json where gdbpath has been added and target modified:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Debug",
            "type": "gdb",
            "gdbpath": "rust-gdb",
            "request": "launch",
            "target": "./target/debug/demo",
            "cwd": "${workspaceRoot}"
        }
    ]
}

It is able to hit breakpoints.


Deserialize to sequence of enum types

The patch deals with repeated top level sections. For example,
[person]
name = "Ana"

[person]
name = "Box"

It enables the deserialization into a sequence of enum types. The code below will work out of box.
#[derive(Debug, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
enum Person {
    pub name: String
}

let people: Vec<Person> = serde_ini::from_str(ini_text)?;

The patch has an extra commit that runs rustfmt on the whole repo.

Sorry this took so long to get to - merged as 53fe15c4de8b415661b9697f48870fea079b436b without the formatting changes. I still need to mull over how to use rustfmt...


Syntax highlight code blocks in docs

Any code block which does not have an explicit tag or is tagged as zig is highlighted as Zig code. This also includes a small tweak to source code rendering to properly highlight (non-doc) comments as such.

Points of interest:

#std.log
#std.Thread.Condition
#std.testing.checkAllAllocationFailures (contains several occurrences)

Hmmmmm perhaps should the zig code be fully parsed and linkified, as if it were a snippet of code within the context of whatever namespace the code snippet appears in? That's how we would want guides to work, right?

I'm not sure if this is a good idea or not, but one thing to try would be to parse markdown up front, then the code snippets would be evaluated within the scope they appear in.

That would be an interesting idea to pursue. The first thing that comes to mind as a potential issue for doing that for all code blocks in doc comments is that the Zig code represented is less likely to be consistently parseable than, say, a doctest, since there's no enforced structure.
Here's a list of all the code blocks in the standard library today which are either untagged or tagged as Zig, categorized by what they contain:

https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/Thread/Semaphore.zig#L7-L19 (mixture of container-scope and block-scope content)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/Thread/Mutex.zig#L7-L20 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/Thread/Condition.zig#L6-L32 (mixture of container-scope and block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/Thread/Condition.zig#L36-L43 (explanatory content, not valid Zig code)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/Build/Cache.zig#L388-L390 (either container-scope or block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/log.zig#L18-L68 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/log.zig#L70-L73 (log output, not Zig code)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/fmt.zig#L70-L72 (incomplete, partially invalid Zig code)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/testing.zig#L990-L1000 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/testing.zig#L1005-L1019 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/testing.zig#L1024-L1031 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/unicode.zig#L356-L361 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/unicode.zig#L1611-L1617 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/crypto/kyber_d00.zig#L28-L32 (ASCII diagram, not Zig code)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/math.zig#L432-L440 (ASCII diagram)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/math.zig#L516-L524 (ASCII diagram)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/crypto/hkdf.zig#L29-L35 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/json/stringify.zig#L152-L161 (grammar description, not Zig code)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/json/scanner.zig#L74-L88 (ditto)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/json/scanner.zig#L92-L114 (ditto)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/json/scanner.zig#L432-L436 (block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/os/linux/seccomp.zig#L56-L64 (container-scope or block-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/heap/general_purpose_allocator.zig#L53-L67 (table, not Zig code)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/bounded_array.zig#L12-L17 (block-scope, although technically should be parseable at container-scope)
https://github.com/ziglang/zig/blob/9cf28d1e9bc940b13cd47efb778fd42a4b3b88de/lib/std/bounded_array.zig#L28-L34 (ditto)

Arguably, of these examples, the ones which aren't Zig code at all should be tagged as something else or represented using a different structure (such as a table). But of the ones which are, it's potentially context-dependent as to how they're meant to be read, which could complicate processing them. (And although the current standard library doc comments don't form a standard as-is, I think both types of code blocks are reasonable)
With that said, even if parsing the code in full isn't attempted, we could still try to linkify identifiers and dotted paths of identifiers, but doing that without parsing would be much less accurate.
As far as guides go, the same general comments apply, but I think there's also a third category of Zig code that would be useful to explore for guides, which is full, runnable/testable Zig files or even projects included in the docs, as currently implemented on the ziglang.org website via zig-doctest. I could see this being done either inline with a special code block (e.g. ```zig test to indicate that the code should be executed as a test case), or by including the content of external files via some directive (what ziglang.org's build does), or both. Such content would be unambiguous in how it's intended to be parsed.
Anyway, without taking this long comment even further off topic, those are my general thoughts on the state and potential of Zig code blocks in doc comments. I'll definitely think about it more; there may be a natural way to distinguish how a code block is meant to be interpreted, or at least a clear direction that could be given to documentation writers to make sure their code blocks are handled optimally by Autodoc (e.g. "write your code blocks as normal block-scope Zig code, or you're only going to get basic syntax highlighting").

Reading this writeup has convinced me that zig code does not belong in doc comments. We have doctests, tests, and potentially new kinds of ways to actually run the zig code and have it be part of the compilation rather than part of a comment.
In order to encourage this, I think it is better to not syntax highlight code blocks in doc comments.

That sounds reasonable to me. The nice things about Zig doctests for me are that 1. they are actually tested and 2. they integrate well with editor tooling, syntax highlighting, zig fmt, etc., so it makes sense to ensure new forms of "example" content also share those benefits.


Whether the sound is processed using DSP for an external sound card?

The DSP for macbook's builtin speakers is great and it really sound good, but i wonder whether the DSP applied to all sound out of asahi.
I connected headphones using external USB sound card and it sounds compressed and really strange. Is the sound processed using DSP for an external sound card? How can I find out?
And if yes how to disable any DSP for an external sound card?
My env:
OS: Fedora Linux Asahi Remix 40 (Forty) aarch64
Host: Apple MacBook Pro (14-inch, M2 Pro, 2023)
Kernel: 6.11.0-400.asahi.fc40.aarch64+16k

The DSP should not be applied to your external sound card. Please confirm the routing using something like Helvum or qpwgraph and post the results.

@chadmed I installed qpwgraph.
There is internal speakers playback:

And with external dac connected:

Tomorrow i will try the same with desktop sound card with which i heard strange effects.
If i can somehow observe my sound chain please let me know. I'm noob at linux audio

That looks fine to me. Could you try setting the Q3 to a digital profile or something? It is possible that the headphone amp is just swamping whatever you've got plugged into it

I tested it today, looks like something cuts volume, and when i am rising volume after small delay (about 0.5 sec) it cuts it again. Maybe it's the only DSP that i am hearing because after several cycles of increasing volume and something limiting it, sound feels compressed which is reasonable. And i think it revert's to starting level only after reboot.
[speakersafetyd](https://github.com/AsahiLinux/speakersafetyd) is the only thing i know that could do this, but there is no any weird things in logs:

Also today it does not sounds as awful as at the time i found out an issue.
And at the end it may be firefox that compresses sound or something web-related because my reference sound on macos is desktop apple music and qobuz applications with same hardware, so if i can figure out how to install desktop applications for this music services then i test it.

Looks like it was an issue with web players or firefox. I installed hifi-rs tui client for qobuz with support for HI-res playback and it works fine, without compression


Add API to entrypoint to expose deletion time

What
Add API to entrypoint to expose deletion time.
And fix pod sweeper.
How

Remove RBAC for runner pods.
https://github.com/cybozu-go/github-actions-controller/blob/58d9042f99d643f3e7af18a59afc62d5de6f53bd/config/samples/manifests.yaml#L21-L52
Add API to entrypoint to expose deletion time and remove this logic.
Fix the pod sweeper.
Fix runner pool reconciler.
https://github.com/cybozu-go/github-actions-controller/blob/af39f46e3f0f19e76b89b9a26f695cc45b6f9a3a/controllers/runnerpool_controller.go#L180

Checklist

[ ] Finish implementation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions

If it returns an error before specifying the time to delete the Pod, the Pod will be restarted.
At this time, if the GitHub registration token has expired, it cannot be registered as a runner and the restart is repeated.
https://github.com/cybozu-go/github-actions-controller/blob/b8d1471a9c356ecbb997fd9bfe6b94fcd6a5220c/cmd/entrypoint/cmd/root.go#L74
https://github.com/cybozu-go/github-actions-controller/blob/b8d1471a9c356ecbb997fd9bfe6b94fcd6a5220c/cmd/entrypoint/cmd/root.go#L79
Set the deletion time before returning an error.


Lack of mangling for non-identifier properties

I encountered a crd in the wild that contains the following snippet:
              jvmOptions:
                description: JVM Options for pods.
                properties:
                  -XX:
                    description: A map of -XX options to the JVM.
                    type: object
                    x-kubernetes-preserve-unknown-fields: true
                  -Xms:
                    description: -Xms option to to the JVM.
                    pattern: ^[0-9]+[mMgG]?$
                    type: string

(Read with care, Github's highlighter is wrong here. This is not a list.)
which results in the following panic:
thread 'main' panicked at '"-XX" is not a valid Ident', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/fallback.rs:708:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/1.59.0/library/std/src/panicking.rs:498:5
   1: core::panicking::panic_fmt
             at /rustc/1.59.0/library/core/src/panicking.rs:116:14
   2: proc_macro2::fallback::validate_ident
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/fallback.rs:708:9
   3: proc_macro2::fallback::Ident::_new
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/fallback.rs:642:9
   4: proc_macro2::fallback::Ident::new
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/fallback.rs:652:9
   5: proc_macro2::imp::Ident::new
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/wrapper.rs:691:50
   6: proc_macro2::Ident::new
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.36/src/lib.rs:952:21
   7: quote::__private::mk_ident
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/quote-1.0.15/src/runtime.rs:404:17
   8: kopium::Kopium::generate::{{closure}}
             at ./src/main.rs:189:29
   9: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/1.59.0/library/core/src/future/mod.rs:84:19
  10: kopium::Kopium::dispatch::{{closure}}
             at ./src/main.rs:116:41
  11: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/1.59.0/library/core/src/future/mod.rs:84:19
  12: kopium::main::{{closure}}
             at ./src/main.rs:106:35
[…tokio cruft…]

I think, in general, it would be nice to have some kind of name mangling that converts all identifiers to nice camel_case. Might require #[serde(rename = "…")] on all fields.

Ahh, wtf. You can put dashes in key names there!
Thank you. Yeah, we should do some handling here.
We could do:

serde(rename) attr on members with illegal characters
rawstring keys like we do for keywords

I'm personally leaning towards using rawstrings here if it works. We already do it in:
https://github.com/kube-rs/kopium/blob/b309292071dfe8cf027bfd5182e857f57b8b48f6/src/main.rs#L181-L192
and it won't clash with future initiatives for solving #22

Rawstrings won't do the trick:
struct Foo {
    r#-XX: (),
}

error: found invalid character; only `#` is allowed in raw string delimitation: -
 [--> src/lib.rs:2:5
](https://play.rust-lang.org/#)  |
2 |     r#-XX: ()
  |     ^^^

error: could not compile `playground` due to previous error

Damnit. Yep :(
Updating. Guess we have to do special case serde renames for them.

This now seems to be resolved by some of the other rename standardisation we did earlier. Not sure when, but it's resolved now.
Checked the crd referenced above and am now passing generation and generate this struct:
#[derive(Serialize, Deserialize, Clone, Debug)]
pub struct KafkaZookeeperJvmOptions {
    #[serde(default, skip_serializing_if = "Option::is_none", rename = "-XX")]
    pub xx: Option<BTreeMap<String, serde_json::Value>>,
    #[serde(default, skip_serializing_if = "Option::is_none", rename = "-Xms")]
    pub xms: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none", rename = "-Xmx")]
    pub xmx: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none", rename = "gcLoggingEnabled")]
    pub gc_logging_enabled: Option<bool>,
    #[serde(default, skip_serializing_if = "Option::is_none", rename = "javaSystemProperties")]
    pub java_system_properties: Option<Vec<KafkaZookeeperJvmOptionsJavaSystemProperties>>,
}

from the same output


Version updates + TOML 1.0

The previous version of the toml library only supported TOML 0.4, smol-toml support TOML 1.0.
In order to support that change a whole bunch of version updates for tooling made.

dependencies updated
use smol-toml instead of toml
migrate to function as a module
some lint updates due to typescript + eslint/airbnb updates
added a case to the cargo.toml which is valid but previously through parse error due to old parsing format.
updated the node version for the action, since node12 is deperecated.

Hi, thank you so much for this PR!
All of this looks great to me, merging.

The new version can be used in an action with the v2 tag.


Validator for DataArray shapes

Currently, we are using the wx_shape validator to ensure that certain dimensions have a specific size. For example, in the SpatialData scheme we want the last dimension that represents space (by definition) to always have the size 3.
This requires us to reorder the internal data of a DataArray during serialization or before to meet the requirements of the validator. This somehow ignores the benefit of a DataArray that all dimensions are named and directly accessible. So we should either expand the functionality of the wx_shape validator or (better I guess) introduce a new one that can handle dimension names too. The syntax can be close to the wx_shape validator just with added dimension names like this:  [..., c=3]. This would express "any number of dimensions with arbitrary shape, but the dimension c must have shape (3,)".  This would also mean that there has to be a dimension c. [..., (c=3)] would mean that the dimension c  is optional, but if present, it has to be of size 3.

I think implementing this should be really simple if we do it just for DataArray with a mapping like
wx_array:
  c: 3
  n: [5,~]
  time: [2,20]

In the end we should probably just find a nice serialization format to use for our xr_check_coords function inputs (which we basically already have)