fix(overlays): hide overlays before hydration

Codecov Report
Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (448811a) 95.96%.
Report is 69 commits behind head on master.

Files
Patch %
Lines

...nents/core/common-behaviors/slot-child-observer.ts
93.33%
5 Missing :warning:

src/components/core/dom/breakpoint.ts
42.85%
4 Missing :warning:

src/components/card/card-action/card-action.ts
70.00%
3 Missing :warning:

src/components/core/dom/dataset.ts
25.00%
3 Missing :warning:

src/components/core/dom/host-context.ts
40.00%
3 Missing :warning:

src/components/header/header/header.ts
50.00%
3 Missing :warning:

src/components/tooltip/tooltip/tooltip.ts
25.00%
3 Missing :warning:

src/components/calendar/calendar.ts
86.66%
2 Missing :warning:

src/components/core/dom/find-referenced-element.ts
60.00%
2 Missing :warning:

src/components/menu/menu/menu.ts
75.00%
2 Missing :warning:

... and 25 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
+ Coverage   92.61%   95.96%   +3.35%
==========================================
  Files          53      329     +276
  Lines        2409    39096   +36687
  Branches      254     2183    +1929
==========================================
+ Hits         2231    37519   +35288
- Misses        176     1531    +1355
- Partials        2       46      +44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


vimPlugins.magma-nvim-goose: migrate to magma-nvim

The vimPlugins.magma-nvim-goose package should be deprecated in favor of a new vimPlugins.magma-nvim package, as its current src (https://github.com/WhiteBlackGoose/magma-nvim-goose) was archived on 2023/07/03 in favor of its upstream repository.
This deprecation also affects the programs.nixvim.plugings.magma-nvim NixVim plugin.

Cc: @GaetanLepage

Thanks for reporting this.
I opened a PR.


Corner radius changing

Hello,
Can we please make "cornerRadius" property in "ScalingCarouselCell"  class public?
It will allow updating view for user needs and design and should not break anything.
The fix is pretty easy in ScalingCarouselCell.swift:
open var cornerRadius: CGFloat = 20.0
...
mainView.layer.cornerRadius = 20

Thanks!

@XFactorus PR opened and linked

Sorry for the long reply.
Looks great, thanks


Test suite can ends with panic when one test case is failing

Test can fail with t.Fail(which is like return here) before process ends with child.Wait(). After few returns in rkt test suite(also after t.Fail) we are running defer Cleanup. This defer is trying to remove temporary directory and it could end with panic, because rkt binary is still running.

Could you point towards a particular test that exhibits this behaviour? is there any way to reliably reproduce?

I found one such place in rkt_api_service_test.go. Will file a PR to fix.

Hmm, actually there are multiple places where we tell the container to exit by child.SendLine()


css: Change mention text and background colors.

Implements the mention pill part of #22022
before:

after:

why @everyone and @stream aren't highlighted as a group mention in my case?

background is green but color for a pill is used like direct mention
Also I somehow managed to self mention 2 people  (I'm aaron here)

Mentions of "my name" or "my group" should be bold (600):

I suggest we change text color for not self pill to be 80% transparent white in the dark theme color: hsl(0deg 0% 100% / 80%);
Light theme color tunes:
--color-background-text-direct-mention: hsl(240deg 70% 70% / 20%);
    --color-background-text-hover-direct-mention: hsla(240, 70%, 70%, 0.3);
    --color-background-text-group-mention: hsla(183, 60%, 45%, 0.18);
    --color-background-text-hover-group-mention: hsla(183, 60%, 45%, 0.3);

Dark theme colors:
--color-background-text-direct-mention: hsla(240, 52%, 60%, 0.25);
    --color-background-text-hover-direct-mention: hsla(240, 52%, 60%, 0.45);
    --color-background-text-group-mention: hsla(183, 52%, 40%, 0.2);
    --color-background-text-hover-group-mention: hsla(183, 52%, 40%, 0.3);

@terpimost updated based on your suggestions.

why https://github.com/everyone and @stream aren't highlighted as a group mention in my case?
Opened https://chat.zulip.org/#narrow/stream/6-frontend/topic/mention.20everyone.20and.20stream to discuss it before changing them to group mentions.

Thanks! Assuming the above screenshot is for Desdemona, all those cases look right to me.

Playing with the PR, I think we should not have a hover effect for wildcard mentions. Clicking on them just opens the compose box, like clicking anywhere else on the message.

Looks good to me otherwise!

One thing I notice visually about these changes is that the mention pills no longer look centered within the line of text they're a part of:

I'm not sure which of the changes in rendered_markdown.css is responsible for that effect, but I think it's important that we avoid it.

Text and the mention pills are vertically aligned correctly.

Playing with the PR, I think we should not have a hover effect for wildcard mentions. Clicking on them just opens the compose box, like clicking anywhere else on the message.

Fixed.

OK, merged, but I think there is still an alignment issue. We seem to have 4px of top padding for messages, with 1px of bottom padding, and for me at least, changing those to be 2.5px on each side seems to fix the visual effect of the text not being centered within the message row without obvious ill effects. I'll post in #design.
diff --git a/web/styles/message_row.css b/web/styles/message_row.css
index de852d5f91..2a82bb110e 100644
--- a/web/styles/message_row.css
+++ b/web/styles/message_row.css
@@ -111,7 +111,7 @@ $time_column_max_width: 150px;
         .message_content {
             grid-row-start: 1;
             grid-column-start: 2;
-            padding: 4px 0 1px;
+            padding: 2.5px 0 2.5px;
         }

         .message_reactions {


Can't download blob: 000 : File Creation Error destination file has no known flags that could cause issue (current set: 0) and azcopy was unable to clear the flag(s), so access will be denied: The filename, directory name, or volume label syntax is incorrect.

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.34.0
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20240523.2
Platform
Windows
OS Version
Windows Server 2016 Datacenter
Bug Description
Can't download blob. Apparently something with the local file name. I can create a file in that location with that name using Notepad.
This is the log file of azcopy
2024/07/24 09:37:00 AzcopyVersion  10.23.0
2024/07/24 09:37:00 OS-Environment  windows
2024/07/24 09:37:00 OS-Architecture  amd64
2024/07/24 09:37:00 Log times are in UTC. Local time is 24 Jul 2024 11:37:00
2024/07/24 09:37:01 ISO 8601 START TIME: to copy files that changed before or after this job started, use the parameter --include-before=2024-07-24T09:36:55Z or --include-after=2024-07-24T09:36:55Z
2024/07/24 09:37:01 Any empty folders will not be processed, because source and/or destination doesn't have full folder support
2024/07/24 09:37:01 Job-Command copy https://gsia001itweup01ltssts01.blob.core.windows.net/aaaingestfailure/4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz?se=2024-08-23t09%3A36%3A59z&sig=-REDACTED-&sp=rl&sr=c&sv=2023-01-03 C:\Users\ad062685\AppData\Local\Temp\2\17218138199254\4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz --output-type=json --cancel-from-stdin --overwrite=prompt --check-md5 FailIfDifferent --from-to=BlobLocal --blob-type BlockBlob --recursive --log-level=INFO
2024/07/24 09:37:01 Number of CPUs: 4
2024/07/24 09:37:01 Max file buffer RAM 2.000 GB
2024/07/24 09:37:01 Max concurrent network operations:  will be dynamically tuned up to 3000 (Based on auto-tuning limit. Set AZCOPY_CONCURRENCY_VALUE environment variable to override)
2024/07/24 09:37:01 Check CPU usage when dynamically tuning concurrency: true (Based on hard-coded default. Set AZCOPY_TUNE_TO_CPU environment variable to true or false override)
2024/07/24 09:37:01 Max concurrent transfer initiation routines: 64 (Based on hard-coded default. Set AZCOPY_CONCURRENT_FILES environment variable to override)
2024/07/24 09:37:01 Max enumeration routines: 16 (Based on hard-coded default. Set AZCOPY_CONCURRENT_SCAN environment variable to override)
2024/07/24 09:37:01 Parallelize getting file properties (file.Stat): false (Based on AZCOPY_PARALLEL_STAT_FILES environment variable)
2024/07/24 09:37:01 Max open files when downloading:<PHONE_NUMBER> (auto-computed)
2024/07/24 09:37:01 Final job part has been created
2024/07/24 09:37:01 Final job part has been scheduled
2024/07/24 09:37:01 Trying 4 concurrent connections (initial starting point)
2024/07/24 09:37:01 ERR: [P#0-T#0] DOWNLOADFAILED: https://gsia001itweup01ltssts01.blob.core.windows.net/aaaingestfailure/4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz : 000 : File Creation Error destination file has no known flags that could cause issue (current set: 0) and azcopy was unable to clear the flag(s), so access will be denied: The filename, directory name, or volume label syntax is incorrect.
Dst: \?\C:\Users\ad062685\AppData\Local\Temp\2\17218138199254\4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz
2024/07/24 09:37:01 INFO: [P#0-T#0] https://gsia001itweup01ltssts01.blob.core.windows.net/aaaingestfailure/4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz Deleting incomplete destination file Dst: \?\C:\Users\ad062685\AppData\Local\Temp\2\17218138199254\4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz
2024/07/24 09:37:01 ERR: [P#0-T#0] \?\C:\Users\ad062685\AppData\Local\Temp\2\17218138199254\4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz: 0: Delete File Error -remove \?\C:\Users\ad062685\AppData\Local\Temp\2\17218138199254.azDownload-b1dd3689-27f4-8844-7fca-1d942de0118c-4f31b30eb5c4435189a85858cdab61eb-httpsvk8kd001jm9eq5xecp9but4r.blob.core.windows.net20240723-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-0-seq-285606464-285606509-count-46-y0m.multijson.gz: The filename, directory name, or volume label syntax is incorrect.. X-Ms-Request-Id:
2024/07/24 09:37:01 JobID=b1dd3689-27f4-8844-7fca-1d942de0118c, Part#=0, TransfersDone=1 of 1
2024/07/24 09:37:01 all parts of entire Job b1dd3689-27f4-8844-7fca-1d942de0118c successfully completed, cancelled or paused
2024/07/24 09:37:01 is part of Job which 1 total number of parts done
2024/07/24 09:37:03 PERF: primary performance constraint is Unknown. States: C:  0, R:  0, W:  0, F:  0, H:  0, B:  0, S:  0, P:  0, Q:  0, D:  0, E:  0, T:  0, GRs:  4
2024/07/24 09:37:03 0.0 %, 0 Done, 1 Failed, 0 Pending, 0 Skipped, 1 Total,
2024/07/24 09:37:03 Closing Log
Steps to Reproduce
Open Storage Explorer,
browse to Blob container,
select blob,
double click or select Download
I can download other blobs fine

Actual Experience
Error message
Expected Experience
Download successful
Additional Context
No response

@andrePKI That blob name is pretty long all on its own (more than 220 characters). Unless the path of the parent directory is very short, it seems like you could be hitting the Windows path character limit. What happens if you shorten the blob name? Or enable long paths?

Well, I  can create a file with the same name from Notepad in the same
location as stated.
So I'm afraid it is something else.
Otherwise, maybe it is the full path - can I control where (what folder)
the blob is downloaded to?
KR,
André
Op do 25 jul 2024 19:49 schreef Craig Alvord @.***>:

@andrePKI https://github.com/andrePKI That blob name is pretty long all
on its own (more than 220 characters). Unless the path of the parent
directory is very short, it seems like you could be hitting the Windows
path character limit. What happens if you shorten the blob name? Or enable
long paths?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/AzureStorageExplorer/issues/8082#issuecomment-2251074463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFTL2FSJY4K6V4MKATIVLCLZOE3BRAVCNFSM6AAAAABLMEAG46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJRGA3TINBWGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

You most certainly can control the download location. When selecting Download, a system dialog opens and allows you to select the destination folder.
@JasonYeMSFT I think the key issue is highlighted by the message: "The filename, directory name, or volume label syntax is incorrect." The destination begins with "?". Shouldn't this be "\?"?

Hi, I still have the issue woth Storage Explorere 1.35.0 (100). But I think the issue is with azcopy (10.26.0)
I have enabled long file name support (HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\ControlFileSystem\LongPathsEnabled=1 and rebooted)
and I can create files with those long names
   Directory: C:\temp\piep\aabbingestfailure

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        8/28/2024  12:17 PM              0 8d6d4cf709304396bdd9a11d7b5c6d64-https4yrkd000th7bt9pnd37khz5p.blob.core.windows.net20240827-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-2-seq
                                                 -345346010-345346151-count-142-aqp.multijson.gz
[...]
[...]
PS C:\temp\piep\aabbingestfailure> $f=dir *.gz

PS C:\temp\piep\aabbingestfailure> $f.FullName.Length
254

But still I get errors from azcopy
$env:AZCOPY_CRED_TYPE = "Anonymous";
$env:AZCOPY_CONCURRENCY_VALUE = "AUTO";
#& 'C:\Program Files\azcopy\azcopy.exe' copy "https://gsia001itweup01ltssts01.blob.core.windows.net/aabbingestfailure/*?sv=2023-01-03&se=2024-09-27T09%3A37%3A43Z&sr=c&sp=rl&sig=apCP8KCpqX%2BBTf2tDMV6YIHRsKfL207yQEHstmgtboY%3D" "C:\Temp\piep" --overwrite=prompt --check-md5 FailIfDifferent --from-to=BlobLocal --list-of-files "C:\Users\ad062685\AppData\Local\Temp\5\stg-exp-azcopy-eb03c51c-a391-4d1b-b314-76d41608c562.txt" --recursive --log-level=INFO;
& 'C:\Program Files\azcopy\azcopy.exe' copy "https://gsia001itweup01ltssts01.blob.core.windows.net/aabbingestfailure/?sv=<REDACTED>" "C:\Temp\piep" --overwrite=prompt --check-md5 FailIfDifferent --from-to=BlobLocal --recursive=true
$env:AZCOPY_CRED_TYPE = "";
$env:AZCOPY_CONCURRENCY_VALUE = "";

with errors
2024/08/28 10:15:20 ERR: [P#0-T#17] DOWNLOADFAILED: https://gsia001itweup01ltssts01.blob.core.windows.net/aabbingestfailure/8d6d4cf709304396bdd9a11d7b5c6d64-https4yrkd000th7bt9pnd37khz5p.blob.core.windows.net20240827-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-2-seq-345346010-345346151-count-142-aqp.multijson.gz : 000 : File Creation Error destination file has no known flags that could cause issue (current set: 0) and azcopy was unable to clear the flag(s), so access will be denied: The filename, directory name, or volume label syntax is incorrect.
   Dst: \\?\C:\Temp\piep\aabbingestfailure\8d6d4cf709304396bdd9a11d7b5c6d64-https4yrkd000th7bt9pnd37khz5p.blob.core.windows.net20240827-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-2-seq-345346010-345346151-count-142-aqp.multijson.gz
[...]
2024/08/28 10:15:20 INFO: [P#0-T#17] https://gsia001itweup01ltssts01.blob.core.windows.net/aabbingestfailure/8d6d4cf709304396bdd9a11d7b5c6d64-https4yrkd000th7bt9pnd37khz5p.blob.core.windows.net20240827-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-2-seq-345346010-345346151-count-142-aqp.multijson.gz Deleting incomplete destination file Dst: \\?\C:\Temp\piep\aabbingestfailure\8d6d4cf709304396bdd9a11d7b5c6d64-https4yrkd000th7bt9pnd37khz5p.blob.core.windows.net20240827-dc-dc-azurediagnosticssiemAzureDiagnosticsRaweh-am-azurediagnostics-partition-2-seq-345346010-345346151-count-142-aqp.multijson.gz

I can ofcourse copy 1 by 1 and specify the (shorter) target file name. But that defeats the purpose of automation.
Meanwhile I have fixed it by first do azcopy list, then copy blobs one by one, replacing the file name with a shorter one.

@JasonYeMSFT Can you provide any insight? The user here is getting the error "The filename, directory name, or volume label syntax is incorrect."

@andrePKI File systems have length limits for each segment in the file path, which is different from the length limit of the total path. Enabling long file path support in Windows doesn't make it possible to create files whose segments exceed the length limit. It's hard for us to know what that limit is because it's file system dependent.
Your best action is to try to stop giving such long names to your blobs. By default, when AzCopy downloads a file, it writes to a temporary file with a .azDownload-<36 char jobid>-<your_real_file_name> which makes it easier to exceed the segment length limit. If that's the case, you may be able to work around the issue by adding an environment variable AZCOPY_DOWNLOAD_TO_TEMP_PATH:false in the process that executes AzCopy command but that won't work if you blob name itself exceeds the segment length limit.

@JasonYeMSFT Fair enough. I was able to create files with such long names in the location, so the download to temp path could still break things.
Problem is that I don't control the blob name, it is a result of a troubleshooting step when ingestion into Azure Data Explorer fails. I could ask the ADX team, but I would not think they will change it.
Anyway, my workaround is in place, I now first list the blobs, and download 1 by 1, substituting the long name with a shorter one for the target.
Thanks for your time and effort.


Update virtual-address-space-and-physical-storage.md

The limit in Windows Server 2016 is 24T

@isaac-k : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Allow all file types to be downloaded from a container through the shell.

LGTM in general. I feel there is some security issues here. For examples, it seems that you can use ../../../../.. to access files else where. This is not allowed in Twitter internal environment since info sec team has program which keeps doing such HTTP request to search for such security hole. And I guess if they find it they will ping our team.

The tornado web server will take care of that it. The following request
http://localhost:9999/../../../../../../../../../../etc/passwd. will be converted to /etc/pass and then fail because there is no handler to handle that route. This works the same as the file FileDataHandler in the shell (https://github.com/twitter/heron/blob/master/heron/shell/src/python/handlers/filedatahandler.py)

ok sounds good.


Merge refs/heads/master into alpha

Merge refs/heads/master into alpha

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308181241. Thanks for your contribution!


Get HTML from

How can I get from EasyMDE the render HTML?
I have this code that raises a call to Blazor for every change.
easyMDE.codemirror.on("change", function () {
    dotNetObjectRef.invokeMethodAsync("UpdateInternalValue", easyMDE.value());
});

The value is the Markdown text. How can I get the rendered HTML code?
Thank you again,
Enrico

The editor isn't really designed to output HTML, the markdown text is the content you want to save.
But if you really want to convert that to HTML you can use the marked package: marked.parse(easyMDE.value());


Integration test failures

I've found these integration tests fail on master at 6ef2a04ac:

discovery
ec2
elastictranscoder (related to S3?)
fms
mturk
s3

Reproduction: cargo test --features SERVICENAME in the integration_tests directory.
For example: cargo test --features discovery.

Ah, these appear to be related to our better handing of errors from AWS.

In a good or bad way? :/

The errors are now typed so there's a little more legwork to get at the error message our tests relied on. https://github.com/rusoto/rusoto/pull/1182 has the changes showing the difference. We've wanted better error messages for a while, the integration tests just slipped when we accepted the PR. 🤷♀

I'll take a closer look tomorrow as well

Done


Remove a few more cases of mem::uninitialized in the tests

Somehow I didn't noticed these in PR #1158, probably because they're
only built on Linux.

bors r+


DXVK HUD applies to the EVE Online launcher rather than the game

When launching EVE from flatpak Steam with DXVK_HUD=1 the hud is applied to the launcher process but not the subsequent game clients that the launcher spawns. See screenshot below for details.
Is there some way to exclude evelauncher.exe from HUD hooking and instead hook the exefile.exe game clients?
Software information
EVE Online via flatpak Steam, any settings
System information
ryzen 6000 series integrated GPU + nvidia 3060
nvidia-dkms 520.56.06 - all versions affected, I've also tested 530.xx and 535.xx
whatever Wine+DXVK ship with Proton-GE 8.4

It should still show ingame as it should apply to each window that uses dxvk. You aren't using the DirectX 12 in the game itself?

I believe the game is currently using d3d12 FL11_0, whereas the launcher may still be using d3d9 (or d3d11). Which explains the behavior above.

The HUD is applied to everything that renders with DXVK.
Like the others here have already said, the game itself is likely using D3D12.

Ah, thanks. I double checked and you're absolutely right, the game is using DX12.

There have been requests for a similar debug hud for vkd3d-proton, but it isn't a thing at the moment.


feat: Rewrite query API responses from url_path_id to url_path

#9

Thanks for putting in the time to make this PR!
I am having an issue.
When i try to access the url http://localhost:1337/api/url-alias/get?path=/ I get an error.
Sorry I do not have the logs right now, I was just trying it out earlier. But it was something like a forbidden error.


"Cornești", "Bujoreanca" are listed in the drop-down menu

Description:
When user writes ” Cornești” and "Bujoreanca" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cornești"

Expected results
The location appears in the drop-down menu as "Sat Cornești, DÂMBOVIȚA (Cornești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Bujoreanca"

Expected results
The location appears in the drop-down menu as "Sat Bujoreanca, DÂMBOVIȚA (Cornești)".


When using the host mount namespace, we should not pivot_root

Scary things will happen if we run pivot_root without entering into a mount namespace. According to runc, we want to use chroot instead.

Wow... Can you give me some runc reference in that area?

Wow... Can you give me some runc reference in that area?

https://github.com/opencontainers/runc/blob/4d26c4a0a14e55fb71a3f7be2d3cd9f228523fff/libcontainer/rootfs_linux.go#L127


libvirt/kcli: defaults to Ubuntu 22.04

Ubuntu 22.04 packages containerd 1.7 that is the mininum required version as of CoCo 0.8.0. Updated the libvirt/kcli_cluster.sh to install Ubuntu 22.04 instead of 20.04.
There is needed to use a kcli version newer than the build of today (2023/11/21) that contains the fix to [1].
[1] https://github.com/karmab/kcli/issues/619
Fixes #1593
Signed-off-by: Wainer dos Santos Moschetta<EMAIL_ADDRESS>

I tested it locally and all the tests passed! \o/ But unfortunately I lost results, so you will need to trust me :)

Added the test_e2e_libvirt  label just to check the current status of CI, I don't expect it to pass (podvm build for CentOS should fail).

Thanks @wainersm , I notice failure when push the podvm image in  https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/6949012011/job/18906372542?pr=1594 ,  looks it's not related with the PR but an token expiration?
#16 ERROR: failed to push ghcr.io/confidential-containers/podvm-binaries-centos-amd64:ci-pr1594: failed commit on ref "manifest-sha256:ed67e98f5404a3e264206af8411d22195acd5fc8c08cd0254ce9ef2a63af3491": unexpected status from PUT request to https://ghcr.io/v2/confidential-containers/podvm-binaries-centos-amd64/manifests/sha256:ed67e98f5404a3e264206af8411d22195acd5fc8c08cd0254ce9ef2a63af3491: 403 Forbidden

I tested this locally - it was a bit slow, so a couple of times it timed out, but that's probably my VM. The tests all passed though once I had it set-up including nydus:
=== RUN   TestLibvirtCreateSimplePodWithNydusAnnotation/SimplePeerPod_test/PodVM_is_created
    assessment_helpers_test.go:159: Pulled with nydus-snapshotter driver:2023/11/22 10:48:20 [adaptor/proxy]         mount_point:/run/kata-containers/bf6013f46756ca54aa6179c1c34a3cce1eb4df441860a21d1081e2b002301f45/rootfs source:docker.io/library/alpine:latest fstype:overlay driver:image_guest_pull
time="2023-11-22T02:48:24-08:00" level=info msg="Deleting pod alpine..."
time="2023-11-22T02:48:29-08:00" level=info msg="Pod alpine has been successfully deleted within 60s"
--- PASS: TestLibvirtCreateSimplePodWithNydusAnnotation (115.19s)
    --- PASS: TestLibvirtCreateSimplePodWithNydusAnnotation/SimplePeerPod_test (115.19s)
        --- PASS: TestLibvirtCreateSimplePodWithNydusAnnotation/SimplePeerPod_test/PodVM_is_created (0.11s)

Thanks @wainersm , I notice failure when push the podvm image in PR check in https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/6949012011/job/18906372542?pr=1594 , looks it's not related with the PR but a token expiration? or it's expected as the PR check is running in a fork without right token?
#16 ERROR: failed to push ghcr.io/confidential-containers/podvm-binaries-centos-amd64:ci-pr1594: failed commit on ref "manifest-sha256:ed67e98f5404a3e264206af8411d22195acd5fc8c08cd0254ce9ef2a63af3491": unexpected status from PUT request to https://ghcr.io/v2/confidential-containers/podvm-binaries-centos-amd64/manifests/sha256:ed67e98f5404a3e264206af8411d22195acd5fc8c08cd0254ce9ef2a63af3491: 403 Forbidden

hmmm... interesting that the builder workflow was able to publish the container on quay.io. I might have introduced a bug on recent changes I made to the workflows or it might be an intermittent issue. Let me re-run the jobs to see what happens.

Sending an updated version where I bumped the mininum kcli build date to 2023/11/22 to pick up @liudalibj's fixes.
I re-ran the tests with kcli-99.0.0.git.202311221027.841a950-0 on x86_64, all passed, including nydus:
=== RUN   TestLibvirtCreateSimplePodWithNydusAnnotation/SimplePeerPod_test/PodVM_is_created
    assessment_helpers_test.go:159: Pulled with nydus-snapshotter driver:2023/11/22 13:18:53 [adaptor/proxy]         mount_point:/run/kata-containers/456b020f20ce57ae8003a57c1b719b0ce24fd2d86c862eb58e9bdad5da247f73/rootfs source:docker.io/library/alpine:latest fstype:overlay driver:image_guest_pull
time="2023-11-22T10:18:59-03:00" level=info msg="Deleting pod alpine..."
time="2023-11-22T10:19:04-03:00" level=info msg="Pod alpine has been successfully deleted within 60s"
--- PASS: TestLibvirtCreateSimplePodWithNydusAnnotation (45.15s)
    --- PASS: TestLibvirtCreateSimplePodWithNydusAnnotation/SimplePeerPod_test (45.15s)
        --- PASS: TestLibvirtCreateSimplePodWithNydusAnnotation/SimplePeerPod_test/PodVM_is_created (0


refact: Handle temporary directories entirely within core

Type of Change

[x] Refactoring

Description
Move all logic for handling temporary directories into linutil core. Return a struct containing the vector of tabs along with the private tempdir variable, which is held so that the destructor can be called once tabs are out of scope. Also add back temporary directory prefix ("linutil_scripts") to improve clarity.
Impact
UIs do not need to manually hold onto a tempdir object they have no use for, improving maintainability (resolving regression in #749).
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no errors/warnings/merge conflicts.

/label rust refactor

/label rust

You've got some conflicts in state.rs

update docgen.rs as well


WIP DNM esp32: add flash cache support

Needs option CONFIG_BOOTLOADER_ESP_IDF
Closes #3722
todo:

[x]  Add option in Kconfig
[x] Add #ifdef around  changes in pinmux_esp32.c

@lpereira: an option like CONFIG_ESP32_FLASH_CACHE will be introduced. Two linker scripts will exist then: one with data cache, one without data cache. Will it be ok for you?

@GautierAtWork This PR seems to have been getting stale for very long.
It would seem you were waiting for some re-reviews(?) If so could you ping those?
Otherwise if you are not planning to continue working on this would you want to close it?


Debug draw

Some ways to draw debug primitive informations in screen space. This doesn't have to be necessarily in master, I just needed this feature so now that it's done it can be used later for any debugging purposes.

Debug drawing is a good thing to have available. If we find ourselves needing more functionality later we can refactor this for better resource management, but I like that it's simple for now.


Add basic Yul verification capability

Add verification of Yul contracts which do not have constructor arguments.
Breaking: make ABI field in verification response optional, and return 'null' if Yul contract was verified

Close #128


generated doc/tags makes git think my vim-test submodule has been modified

I use vim-test as a submodule of my 'dot' repo so that I can install it easily when I clone my 'dot' repo via git submodule update --init.
However, the auto-generated doc/tags file makes git constantly think there are uncommitted changes in git repo.
Maybe this file should be added to the .gitignore in doc/tags?

@janko-m thanks!


Reinstate CM 0.19 upgrade

Further work needed to fix the scrolling issue this upgrade introduces.

https://discuss.codemirror.net/t/codemirror-next-0-19-0/3435
I think this is just a trivial CSS fix required. Branch rebuilding now.

I think the review branch looks good now. I'll have a fresh look after lunch before merging.
Then it would be good to rebase errors-lsp on this as that uses far more CM API so there could be breakage or relevant improvements there.


[tool_crash] ClientException

Command
flutter run

Steps to Reproduce

...
...
...

Logs
ClientException
#0      IOClient.send.<anonymous closure> (package:http/src/io_client.dart:49:13)
#1      _invokeErrorHandler (dart:async/async_error.dart:45:24)
#2      _HandleErrorStream._handleError (dart:async/stream_pipe.dart:272:9)
#3      _ForwardingStreamSubscription._handleError (dart:async/stream_pipe.dart:157:13)
#4      _HttpClientResponse.listen.<anonymous closure> (dart:_http/http_impl.dart:712:16)
#5      _rootRunBinary (dart:async/zone.dart:1378:47)
#6      _CustomZone.runBinary (dart:async/zone.dart:1272:19)
#7      _CustomZone.runBinaryGuarded (dart:async/zone.dart:1178:7)
#8      _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:360:15)
#9      _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:378:16)
#10     _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)
#11     _ForwardingStreamSubscription._addError (dart:async/stream_pipe.dart:128:11)
#12     _addErrorWithReplacement (dart:async/stream_pipe.dart:176:8)
#13     _HandleErrorStream._handleError (dart:async/stream_pipe.dart:277:11)
#14     _ForwardingStreamSubscription._handleError (dart:async/stream_pipe.dart:157:13)
#15     _rootRunBinary (dart:async/zone.dart:1378:47)
#16     _CustomZone.runBinary (dart:async/zone.dart:1272:19)
#17     _CustomZone.runBinaryGuarded (dart:async/zone.dart:1178:7)
#18     _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:360:15)
#19     _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:378:16)
#20     _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)
#21     _SyncStreamControllerDispatch._sendError (dart:async/stream_controller.dart:737:19)
#22     _StreamController._addError (dart:async

@tundachef
Since you didn't provide flutter doctor -v, so not sure on which version you are getting this error, but this was already fixed  last year : https://github.com/flutter/flutter/issues/73356, so if you are not on latest master or stable, please upgrade to them first and try again and see if you again get this error not.
I am going ahead and closing this as duplicate of linked issue. If you are seeing this on latest master too, write in comments and I'll reopen this.


Add kpointlist

Codecov Report

Merging #185 (e0a93f1) into develop (d0704ee) will decrease coverage by 0.60%.
The diff coverage is 95.65%.

:exclamation: Current head e0a93f1 differs from pull request most recent head 28f6620. Consider uploading reports for the commit 28f6620 to get more accurate results

@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
- Coverage    47.94%   47.34%   -0.61%
===========================================
  Files          111      111
  Lines        17454    17255     -199
===========================================
- Hits          8369     8169     -200
- Misses        9085     9086       +1

Impacted Files
Coverage Δ

phonopy/interface/vasp.py
53.43% <95.65%> (+0.04%)
:arrow_up:

phonopy/api_qha.py
57.79% <0.00%> (-3.22%)
:arrow_down:

phonopy/phonon/mesh.py
58.46% <0.00%> (-2.36%)
:arrow_down:

phonopy/api_phonopy.py
46.48% <0.00%> (-2.08%)
:arrow_down:

phonopy/structure/atoms.py
71.15% <0.00%> (-1.95%)
:arrow_down:

phonopy/phonon/qpoints.py
58.87% <0.00%> (-1.60%)
:arrow_down:

phonopy/phonon/thermal_properties.py
50.20% <0.00%> (-1.38%)
:arrow_down:

phonopy/qha/core.py
35.47% <0.00%> (-1.29%)
:arrow_down:

phonopy/phonon/band_structure.py
38.04% <0.00%> (-1.06%)
:arrow_down:

phonopy/harmonic/dynamical_matrix.py
66.58% <0.00%> (-1.01%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0704ee...28f6620. Read the comment docs.


Error "creation-failed" and detail "failed to retrieve scanner stack"

I've used those ARM templates to create Terraform manifests for both scanner and storage stacks.
After creating scanner resources, when I try to add the scanner to TM FSS Portal, I get this error:
{
"stackID": "***",
"status": "creation-failed",
"statusDetail": "failed to retrieve scanner stack",
"details": {}
}

Hi @ayelencasamassa,
When adding the stacks to TM FSS, TM FSS retrieves the required information from ARM deployment outputs. Stacks deployed through Terraform would make FSS unable to get those information, so the requests would fail.

Can you tell me which info is looking for? TM FSS will always look for a ARM deployment object?

Can you tell me which info is looking for? TM FSS will always look for a ARM deployment object?

Yes, TM FSS looks for the latest resource group's deployment whose outputs contain the key scannerStackResourceGroupID. Then FSS retrieves all the deployment's outputs, when receiving the creating stack request of that particular resource group (FSS stack). In theory, FSS might be able to accept an ARM deployment that provides all the outputs defined in the official ARM templates, but it's not tested and not guaranteed.

I'm afraid you're correct. The product's strategy has been evolved to integrate with Trend Micro Vision One. For Vision One FSS it'll be a brand new deployment model that integrates with a central cloud account management feature. Vision One FSS supports AWS only now. Azure is under planning and might use Terraform as IaC AFAIK.


Allow for installation

So I wanted to use ksQlient (1.0.1) on nodejs 18.14, but stumbled upon the following error:
node:internal/modules/cjs/loader:361
      throw err;
      ^

Error: Cannot find module '/Users/me/GP-pi-code/testproducer/node_modules/ksqlient/ksqldb'. Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:353:19)
    at Function.Module._findPath (node:internal/modules/cjs/loader:566:18)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/me/GP-pi-code/testproducer/produce.js:2:16)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1155:10)
    at Module.load (node:internal/modules/cjs/loader:981:32) {
  code: 'MODULE_NOT_FOUND',
  path: '/Users/me/GP-pi-code/testproducer/node_modules/ksqlient/package.json',
  requestPath: 'ksqlient'
}

For this snippet:
const ksqldb = require("ksqlient");
const client = new ksqldb({ ksqldbURL: "http://localhost:8088" });

(async () => {
    const respones = await client.pull("SELECT * FROM WHITELIST;");
    console.log(respones);
})().catch(e => {
    console.log(e);
});

The tests are still passing and now I do get a successful response in my code.

Hi Menkeld, sorry for the late response. Let me take a look into this tomorrow and Rattanachai's commit, thank you so much

Thanks so much Rattanachai-W for your contribution!


Swap order of Retry and Error http client plugins

The ErrorPlugin is responsible for filtering out requests that returned http
error codes. In the original order this filtering would happen only after a
failing request to the sentry endpoint was retried some number of times, as
configured by getSendAttempts.
This meant that when sentry rate limits the requests from this client the
requests would be retried before resulting in a ClientErrorException.
This patch reorders the ErrorPlugin and the RetryPlugin so the
ClientErrorException is thrown before the sdk attempts to retry the request.
Fixes #1204
Some extra context: this only happens when you have php-http/client-common
version 1.x installed.

As mentioned in the issue, this is not the right solution: the order of the plugins matter, so swapping them will make php-http/client-common:<2.0 work as expected and will break the app of all people using newer versions. Instead, we should bump the minimum required version of the package to ensure that noone can use one not behaving as expected

As mentioned in the issue, this is not the right solution: the order of the plugins matter, so swapping them will make php-http/client-common:<2.0 work as expected and will break the app of all people using newer versions. Instead, we should bump the minimum required version of the package to ensure that noone can use one not behaving as expected

That should be done targeting develop though.

I'm not sure, the bump is to solve an issue and as such it falls under a patch version

Yes but, if you have issues to fix on the previous patch, there's no way to fix them for people stuck on http/client-common 1.x
IMHO we could even do the reverse on the old minor, restricting to http/client-common ^1.x and fixing it there as suggested here.
WDYT?

Yeah I agree with @Jean85 here, I made this before the discussion on the issue happened. I don't really expect this to break people who use client-common >= 2 but I can't be sure. Anyway, I'll close this PR until we have a good solution.


ktop: 0.3.6 -> 0.3.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/vladimirvivien/ktop/releases.
meta.description for ktop is: Top-like tool for your Kubernetes cluster
meta.homepage for ktop is: https://github.com/vladimirvivien/ktop/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.7 with grep in /nix/store/100jznh0c217c1v0z4lskcmihqd7cgzn-ktop-0.3.7
found 0.3.7 in filename of file in /nix/store/100jznh0c217c1v0z4lskcmihqd7cgzn-ktop-0.3.7

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

ktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/100jznh0c217c1v0z4lskcmihqd7cgzn-ktop-0.3.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ktop https://github.com/r-ryantm/nixpkgs/archive/b0e17d66b1c15d1fdd5f52923af1ac9a7e0ce951.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b0e17d66b1c15d1fdd5f52923af1ac9a7e0ce951#ktop

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/100jznh0c217c1v0z4lskcmihqd7cgzn-ktop-0.3.7
ls -la /nix/store/100jznh0c217c1v0z4lskcmihqd7cgzn-ktop-0.3.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ktop

Maintainer pings
cc @qjoly for testing.

Result of nixpkgs-review pr 330147 run on x86_64-linux 1

1 package built:

ktop


docs(resource-detector-aws): update readme for aws resource detector

Which problem is this PR solving?

Part Of #2055
Part Of #2025

Short description of the changes

Update README of AWS Resource Detector to clarify the source of the data and add Semantic Conventions.

updates made and also remove the notes column


teamviewer: Add post_install to set nosave to 0 for user preferences

This installs the portable Teamviewer meaning that nosave defaults to 1. This means user preferences are not maintained between uses. Setting this to 0 with a regex replace on that line in the .ini file fixes this.

Where did you get this information?

Had to Google around because it was frustrating me why I kept losing Partner IDs on close. Found this first:
https://community.teamviewer.com/t5/Knowledge-Base/Getting-Started-with-TeamViewer-Portable/ta-p/4799
and then after seeing "nosave=1" on that page,  I searched that up and saw this result:
https://portableapps.com/node/24854
Seeing it twice, I just tested it out locally and it worked. It's worth noting that changing this causes a UAC prompt, because apparently the way Teamviewer stores its preferences is the Registry (sigh). But there isn't a way around this.

Closing as robmonte:master has been deleted.


Unknow error on sending/reading mail

Versions:

Rainloop: 1.11.3
Browser: Chrome 67.0.3379.0 (Canary) and Firefox 58.0.2
OS: Debian 9.1
Webserver: Caddy 0.10.7
PHP: 7.0.27

Expected behavior: Email should be sent and readable
Actual behavior: When clicking "Send" button or when trying reading a mail, an "Unknown error" message appear.
Steps to reproduce the problem: Send or read (click) a mail
Logs or screenshots:

Chrome dev tools Network errors:

Chrome dev tools Console error:

Read error screenshot:

Read error video: https://files.triinoxys.fr/rainloop_issue_1.mp4 (we see the email infos one second, then the error shows up)
Send error screenshot:

Additional useful (or not) infos:

Rainloop worked when I did first tests (I tested PGP support and Google integration), then it stopped working
I tried disabling Contacts, no change
Emails are received fine
Problem is Error 500 (php, ajax, permissions ?)
Permissions are set well (755 folders, 644 files), user is www-data
Used PDO is SQLite (php7.0-sqlite3)
"data" folder is secured by caddy's "http.internal" directive
All neededd PHP extensions are installed

Thanks for you help :)

UPDATE: I installed a second instance from scratch, it works... I will re-do all the actions I did to find out what caused the problem.


LR crashes when some fields in the configuration file are left empty

If Lightning-rod is run with a configuration file in which field "url_wamp" is left empty, then it crashes with the following error:
 var wampIP = wampUrl.split("//")[1].split(":")[0];
                                               ^

TypeError: Cannot read property 'split' of undefined
    at Object.<anonymous> (/storage/emulated/0/s4t-root/s4t-lightning-rod-master/lightning-rod.js:109:41)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Function.Module.runMain (module.js:575:10)
    at startup (node.js:159:18)
    at node.js:444:3

Same happens if other fields are left empty. This errors should be managed.

Bug fixed: introduced new configuration checking system.


Remove Outermost Parentheses

Description
This code removes outermost parentheses of every primitive string in the primitive decomposition of string.
Domain
CPP
Type of Contribution
Addition, Enhancement, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


Remove extra indexer objects in indexer list page

Under "contributors" section on the navigation bar, the list of indexers is longer on the new cantus. Extra indexers should be removed/hidden.

fixed in 56ddcb14a72d6ab1bf06291252beb3c6a786396c
Public version only displays indexers who have at least one public source.


need a consistent visualization of cu1, crz, rzz

What is the expected enhancement?
Let's make sure the text, mpl and latex drawer have a consistent representation for these.
There are some bugs, for example the latex doesn't draw rzz at all.
And there are some inconsistencies, for example mpl draws rzz as a line and text draws it as a box.
After discussions with @jaygambetta, let's do it like this:
circuit.cu1(0.8, q[0], q[1])
circuit.crz(0.7, q[0], q[1])
circuit.rzz(0.6, q[0], q[1])

q0_0: |0>─■─────────■──────■────
          │0.8 ┌────┴────┐ │zz(0.6)
q0_1: |0>─■────┤ Rz(0.7) ├─■────
               └─────────┘
q0_2: |0>───────────────────────

 c0_0: 0 ═══════════════════════

 c0_1: 0 ═══════════════════════

This just signifies that the 1st and 3rd gates are symmetric gates.

https://github.com/Qiskit/qiskit-terra/pull/1960 fixes the text drawer.

At this point, this issue only affects the latex drawer. Renaming.

@1ucian0 I am going to try to deep on this issue . OK?

Sure! Let me know if you need any pointers!
On Fri, Aug 2, 2019, 3:08 PM Elisa Martin<EMAIL_ADDRESS>wrote:

@1ucian0 https://github.com/1ucian0 I am going to try to deep on this
issue . OK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Qiskit/qiskit-terra/issues/1957?email_source=notifications&email_token=AAF3FZLCEDP7MHWCXIJTNVTQCSA2ZA5CNFSM4G5H4D4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OTEAA#issuecomment-517812736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF3FZKV7MXJP3ZYTCA4R3TQCSA2ZANCNFSM4G5H4D4A
.

any progress @ElisaGarijo ? Let me know!


PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported

Hello!
Describe the bug
When I press the GO button in order to check my theme I get the error:

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /opt/lampp/htdocs/my.site/wp-content/plugins/theme-sniffer/vendor/squizlabs/php_codesniffer/src/Config.php on line 420

To Reproduce
Steps to reproduce the behavior:

Go to '/wp-admin/admin.php?page=theme-sniffer'
Chose any theme, for example, 'Twenty Twenty' one.
Click on 'GO'.
Wait a while.
See the error in debug.log (define( 'WP_DEBUG', true ); required in wp-config.php).

Expected behavior
Result of the theme check.
Screenshots
No required.
Environment (please complete the following information):

OS: Linux
Browser: Chrome
Version: 87.0.4280.88 (Official Build) (64-bit)
PHP Version: 8.0.0
WP Version 5.6

Additional context
Local web server XAMPP.

After 3 years nobody has a solution? I still have this problem...

This project is not maintained.

WordPress.org theme review told me to download it to check my developed theme before upload it on wordpress directory.... it also mentioned on wordpress guidlines...


Feature_Request   remove bubble background

Is your feature request related to a problem? Please describe.

remove bubble background from website to look good classic
Describe the solution you'd like

Describe alternatives you've considered

Demo Video/Screenshot (Mandatory )
Current home page

new

Are you contributing under any open-source program ?

jwoc

@AftabMankapure Your proposal is good But Can you use a background theme maybe instead of the solid color can you use maybe  some animation or some image

https://github.com/apu52/Travel_Website/assets/125949765/5542e657-5700-463a-b0f6-7231da864007
it is ok

I think it it good
pls change label medium to
HARD

I think it it good pls change label medium to
HARD

OK please submit your PR .


Ensure we validate credentials correctly

Fixes: #1995
Currently the creds validation is broken:

New code:
With AWS_PROFILE:

With default creds:

With Environment Vars for AWS_ACCESS_KEY_ID && AWS_SECRET_ACCESS_KEY

Using an AWS AssumeRole:

How do I run pulumi with the aws provider from an ec2 instance using an instance role? This no longer works now

We're hitting the exact same thing as @mdop-wh is (literally word-for-word 😅)
Reading the code in this PR, I'm surprised to see that the default value of aws:skipCredentialsValidation before was true... I'm not clear why having this value set to false is failing in AWS, particularly since we use the STS service to get credentials to use in the first place. Is there some specific IAM permission (or some other configuration) that is needed for validation to occur that I'm missing?


bgpv2: Including service options to advertisement CRD

Why change is required
Advertisement CRD currently uses two fields to identify what needs to be advertised - BGPAdvertisementType + LabelSelector. This is fine for most cases, but there are cases where some more metadata must be added to advertisement CRD.
For eg, in case of Service advertisement, specification of addresses such as ClusterIP, LoadBalancerIP or ExternalIP need to be added in the advertisement metadata.
One other use cases which is not yet implemented is advertisement of connected routes. Which will need interface name as metadata field.
Currently, BGPv1 has ongoing work related to ExternaIP, ClusterIP. It will be good to make sure BGPv2 CRDs have similar configuration options.
Additionally, this change also fixes some typos and renaming exported fields with consistent prefix of BGP in bgp_advert_types.go file.
Proposed change
New optional field ServiceOptions is added to Advertisement struct. This will be used to add metadata regarding Service advertisement - in this case list of service address types - LoadBalancerIP, ExternalIP and ClusterIP.
Backwards compatibility

BGPAdvertisementType had enum CiliumLoadBalancerIP, this is now removed and new enum Service is added.
Fixed typo in Attributes field community, changed it to communities.

BGPv2 API development is in progress. Service advertisements are not implemented in BGP control plane, so there is no consumer of these APIs in Cilium. Moreover, BGPv2 functionality is gated behind feature flag as this is still work in progress.
I think changing this API is fine, but if anyone disagree, please let me know we can look at the alternative approaches.
bgpv2: Add service options to advertisement CRD

/test


Mangohud handle configuration file

This is the initial setup to handle MangoHud configuration via ~/.config/MangoHud/MangoHud.conf file;
In this initial state it will:

Check if a ManagoHud.conf file exists and if not, create it with minimal configuration (currently only sets the no_display option)
If MangoHud.conf file exists it will try to read toggle_hud keycode, if not, will be set to the ManguHud default Shift_R+F12.

For this to work this line should be removed in steamos-compositor-plus
This fixes https://github.com/gamer-os/gamer-os/issues/206
Edit:
Added a few commits to enable the configuration to be edited by the user. Currently it does not validate the content but it's intelligent enough to catch the new toggle key if set.

The code looks good. I finally had a chance to test it and it works great.
Except that when toggling mangohud visibility, Steam is still taking screenshots :facepalm:
I think we should add toggle_hud=F3 to the default config, like we have it currently.

One other thing I noticed, after saving the configuration in Steam Buddy, nothing seems to happen. We should probably redirect back to the main page after you hit save.

Except that when toggling mangohud visibility, Steam is still taking screenshots 🤦
I think we should add toggle_hud=F3 to the default config, like we have it currently.

Weird. Maybe a keyboard stuff going on? Works on my laptop, but changing to F3 by default should not be a problem.

One other thing I noticed, after saving the configuration in Steam Buddy, nothing seems to happen. We should probably redirect back to the main page after you hit save.

It is deliberate like this. It redirects to the same page so you can actually see the thing you just edited. We currently don't have any sort of confirmation to the user, so maybe add that in the near future? Changing redirect to the root is not an issue.

@alkazar All done. Should be ready for testing.


chore: updated reader for dependentProperties

Fixes
Changes made in reader of dependentProperties in accordance to
https://code.hq.twilio.com/twilio/yps/pull/169/files
Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[ ] Run make test-docker
[ ] Verify affected language:

[ ] Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
[ ] Run make test in twilio-go
[ ] Create a pull request in twilio-go
[ ] Provide a link below to the pull request

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the Contribution Guidelines and my PR follows them
[ ] I have titled the PR appropriately
[ ] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Merge when https://code.hq.twilio.com/twilio/yps/pull/169 is merged.


Fix name of the config_src variable in neutron_sriov role

Please add the new variable into argspec.

done

/lgtm

        "TASK [edpm_neutron_sriov : discover secrets in /var/lib/openstack/configs/neutron-sriov] ***",
Warning: [WARNING]: Skipped '/var/lib/openstack/configs/neutron-sriov' path due to this",
        "access issue: '/var/lib/openstack/configs/neutron-sriov' is not a directory",
        "ok: [fake-sriov-compute-1 -> localhost]",

recheck

        "TASK [edpm_neutron_sriov : discover secrets in /var/lib/openstack/configs/neutron-sriov] ***",
Warning: [WARNING]: Skipped '/var/lib/openstack/configs/neutron-sriov' path due to this",
        "access issue: '/var/lib/openstack/configs/neutron-sriov' is not a directory",
        "ok: [fake-sriov-compute-1 -> localhost]",

isn't it like that because there is no actually /var/lib/openstack/configs/neutron-sriov there during the molecule test?

OK I know the reason why your config file with transport_url was not properly loaded. You need this fix to point molecule to the directory with the config that mimics the one from Secret prepared by neutron-operator:
diff --git a/roles/edpm_neutron_sriov/molecule/default/converge.yml b/roles/edpm_neutron_sriov/molecule/default/converge.yml
index 08d27ef..5746332 100644
--- a/roles/edpm_neutron_sriov/molecule/default/converge.yml
+++ b/roles/edpm_neutron_sriov/molecule/default/converge.yml
@@ -19,4 +19,4 @@
   roles:
     - role: "edpm_neutron_sriov"
       vars:
-        edpm_ovn_config_src: "{{lookup('env', 'MOLECULE_SCENARIO_DIRECTORY')}}/test-data"
+        edpm_neutron_sriov_agent_config_src: "{{lookup('env', 'MOLECULE_SCENARIO_DIRECTORY')}}/test-data"

With that, you should be able to:

revert the patch that moves log-file from config file to command.
revert the switch from neutron.conf.d to /etc/neutron/conf.d path.

Please fix roles/edpm_neutron_sriov/molecule/default/converge.yml to point to the right test-data path. Then revert the switch to /etc/neutron/conf.d and the move of the log-dir.

Done, thx a lot :)

/lgtm

error: unable to default to a user name: the server is currently unable to handle the request (get users.user.openshift.io ~)

recheck

recheck

recheck

recheck

recheck


cmd/link: issues with Xcode 16 beta [freeze exception]

Xcode 16 beta is released recently. I downloaded it and tested against Go (running all.bash). There are a number of failures. Filing this issue to track.
On ARM64, when external linking, it seems to cause code sign error, where binaries from go build have invalid code signature and get killed.
% go build ~/go/c.go
% codesign -v ./c
./c: invalid signature (code or signature have been modified)
In architecture: arm64

Besides, there are a few failures below.
A number of failures seems to be DWARF related
--- FAIL: TestDWARF (0.00s)
    --- FAIL: TestDWARF/testprogcgo (3.89s)
        dwarf_test.go:155: decoding dwarf section info at offset 0x0: too short
FAIL
FAIL	cmd/link	27.419s

--- FAIL: TestRuntimeTypeAttrExternal (9.12s)
    dwarf_test.go:110: ## build output:
        # command-line-arguments
        ld: warning: no platform load command found in '/private/var/folders/hn/13ch8f612p7_6sr0h3wzf_9r00bkwx/T/go-link-3081649599/go.o', assuming: macOS
    dwarf_test.go:942: error reading DWARF: decoding dwarf section info at offset 0x0: too short
FAIL
FAIL	cmd/link/internal/ld	37.212s

--- FAIL: TestDWARFSections (0.40s)
    plugin_test.go:210: /Users/cherryyz/src/go/bin/go run -gcflags  ./checkdwarf/main.go plugin2.so plugin2.UnexportedNameReuse: exit status 1
        plugin2.so: error opening DWARF: decoding dwarf section info at offset 0x0: too short
        exit status 1
FAIL
FAIL	cmd/cgo/internal/testplugin	70.410s

And there is also one that seems not DWARF related
--- FAIL: TestExtLinkCmdlineDeterminism (12.92s)
    link_test.go:1216: build failed: exit status 1, output:
        # command-line-arguments
        build mode: pie, symbol table: on, DWARF: on
        HEADER = -H1 -T0x1001000 -R0x1000
        /Users/cherryyz/src/go/pkg/tool/darwin_amd64/link: cannot create /var/folders/hn/13ch8f612p7_6sr0h3wzf_9r00bkwx/T/TestExtLinkCmdlineDeterminism2689331464/001/linktmp/go.o: open /var/folders/hn/13ch8f612p7_6sr0h3wzf_9r00bkwx/T/TestExtLinkCmdlineDeterminism2689331464/001/linktmp/go.o: no such file or directory

They are failing with ld-1115.5.3. I haven't investigated them and I'm not sure they are bugs in Go or Apple's linker. I'll look into them.

Similar Issues

cmd/link: TestDWARF failing under all.bash on OSX 10.13.6 #30236
cmd/link: TestDWARF fails with the latest tip version #25392
cmd/link: issues with Apple's new linker in Xcode 15 beta #61229
cmd/link:  no room to add dwarf info #41967
cmd/link: testDWARF in c-archive mode fails on Linux (but not Darwin) #31363
cmd/link: revisit dwarf in executable files on OS X #11994
cmd/link: vmsize of __DWARF should not be zero on darwin #21647
plugin: test fails for debug sections on Darwin #27502
debug/dwarf: cgo produces malformed DWARF data #32673
cmd/link: Darwin build fails with "unknown load command" #25908

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

To work around #59026, where dsymutil may not clean up its temp directory at exit, we set DSYMUTIL_REPRODUCER_PATH to our temp directory. The problem is that in Xcode 16 beta, dsymutil deletes the DSYMUTIL_REPRODUCER_PATH directory even if it is not empty. In particular, that's where our DWARF file (the output of dsymutil) locates. That causes all the DWARF missing failures.
When the linker is invoked with -tmpdir set explicitly, that also causes the temp dir being deleted (by dsymutil), which causes the TestExtLinkCmdlineDeterminism failure.
CL 593659 fixes this, by giving dsymutil a subdirectory. This makes all.bash pass with Xcode 16 beta on both Intel and ARM64.
The code sign failure is also related. As dsymutil deletes the directory, which contains its own output DWARF file, which makes the Go linker not be able to find the file and exit too early. With the fix, this should not happen. But even if this happens (dsymutil didn't generate an output), we should not skip code sign. CL 593660 addresses this.

@golang/release I'm requesting a freeze exception for this. Xcode 16 beta doesn't work well with Go currently, with the most significant problem being the code sign error on ARM64, which makes almost all cgo binaries fail to run. This is caused by dsymutil unexpectedly (but arguable) deleting the temp directory (details above). Xcode 16 is still in beta, and Apple might change this before the final release, or not. Xcode 16 will probably be released later this year, well before Go 1.24. Instead of waiting for Apple to fix, we can do a simple workaround in Go 1.23. This ensures Go 1.23 works well when Xcode 16 is released, and also make users who want to use Apple's beta toolchain happy. The fix is simple and low risk, just changing the temp directory to pass to dsymutil. Thanks.

@gopherbot please backport this to Go 1.22. Thanks.
Reason is similar to the freeze exception above. Xcode 16 will probably be released while Go 1.22 is still in support.

Thanks!

Fixed by the CLs above.


Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field": A11y_Visual Studio Code Client_Customizations and settings_Keyboard Shortcuts_Screen Reader.

GIT Hub Tags:
#A11yWCAG2.1; #A11yTCS; #A11ySev2; #Visual Studio Code Client; #BM_Visual Studio Code Client_MAC_JULY2024; #DesktopApp; #WCAG4.1.3; #FTP; #A11yMAS; #Status Message;
Environment and OS details:
MAC Book Pro
MAC OS Sonoma Version 14.5
Visual Studio code Insider version 1.92.0
Reproduction Steps:

Open Visual Studio Code Insiders editor
Tab Navigate to setting icon.
Select "Keyboard shortcuts options" and press enter or Press keyboard shortcut as command K, Command S
Keyboard shortcut table gets opened.
Tab till "Keyboard Shortcut Edit field".
Type any Text or Key and Observe that Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".

Actual behavior:
Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".
Expected behavior:
Voiceover should be announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".
User Impact:
Screen reader users will face difficulty if Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".
Attachments:
https://github.com/user-attachments/assets/00b8d197-5447-4c44-ab81-f814ad889caa

@sandy081 do you know if we have ever had support for this?

#Rev:poojanamde;

Decreasing to Sev4 according to Review of Indu Priya Setty.
Thanks!!


Fix #166 - Add docs for validating default values

Closes #166.
Add documentation for how the validating default default values in BaseSettings differs from those in pydantic.BaseModel.

Thanks @stinovlas for this PR 🙏
I've just simplified the examples.

Thanks @stinovlas for this PR 🙏
I've just simplified the examples.

I think the new examples do illustrate the technical aspect of not validating the default value, but lack the illustration of why would you do such a thing. I think my original examples illustrate that quite well and I took care to select example from Python standard library that exists in all Python versions supported by pydantic.
But if you think that the technical aspect is the most important and illustration of the issue is unnecessary, I can't force that on you.


CLID-270: Implement catalog rebuild based on go-containerregistry

PS: this implementation doesn't rebuild the cache
Tests:

by MirrorToDisk + DiskToMirror using the following ISC

apiVersion: mirror.openshift.io/v2alpha1
kind: ImageSetConfiguration
mirror:
  operators:
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
      packages:
      - name: aws-load-balancer-operator
    - catalog: registry.redhat.io/redhat/certified-operator-index:v4.16
      targetCatalog: other/certified-operator-index
      packages:
      - name: gitlab-operator-kubernetes
    - catalog: registry.redhat.io/redhat/certified-operator-index:v4.15
      targetCatalog: other/certified-operator-index
      targetTag: v4.15.0
      packages:
      - name: gitlab-operator-kubernetes
    - catalog: registry.redhat.io/redhat/community-operator-index:v4.15
      targetTag: v4.15.0-c
      packages:
      - name: cert-utils-operator

verify all catalog images were copied using

podman pull docker://sherinefedora:5000/clid270/redhat/redhat-operator-index:v4.14
podman pull docker://sherinefedora:5000/clid270/other/certified-operator-index:v4.16
podman pull docker://sherinefedora:5000/clid270/other/certified-operator-index:v4.15.0
podman pull docker://sherinefedora:5000/clid270/redhat/community-operator-index:v4.15.0-c

verify all catalog images are runnable using: (repeat for 3 other catalogs)

podman run docker://sherinefedora:5000/clid270/redhat/redhat-operator-index:v4.14

verify all mirrored catalogs are the filtered ones using :  (repeat for 3 other catalogs)

$ podman ps
CONTAINER ID  IMAGE                                                          COMMAND         CREATED        STATUS        PORTS       NAMES
fd50d103a6a4  sherinefedora:5000/clid270/redhat/redhat-operator-index:v4.14  serve /configs  6 seconds ago  Up 6 seconds  50051/tcp   beautiful_thompson
$ podman exec -it beautiful_thompson bash
bash-4.4$ cd /configs/
bash-4.4$ ls
aws-load-balancer-operator
bash-4.4$ exit
exit

Known issues:

OCI catalogs aren' t covered
Mirror to mirror isn' t covered

/test sanity

/test images

I'm happy to give looks good to me - @aguidirh - I'll wait for you response. Then lets merge asap

/retest

/retest

/lgtm

/retest

/retest


fix(transformer/nullish-coalescing): use correct scope id for binding

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8053  👈 (View in Graphite)
#8051
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 21, 2:02 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Added rsplit() for String class

Script used for testing:
...
var some_string = "Milk, Chicken, Bread, Butter"

#var t0 = some_string.rsplit(", ", false, 0)  # ['Milk', ' Chicken', ' Bread', ' Butter']
#var t1 = some_string.rsplit(", ", false, 2)  # ['Milk, Chicken', 'Bread', 'Butter']

var t0 = some_string.rsplit(" ", false, 0)  # ['Milk,', 'Chicken,', 'Bread,', 'Butter']
var t1 = some_string.rsplit(" ", false, 2)  # ['Milk, Chicken,', 'Bread,', 'Butter']

print("source: " + some_string)
print("====")

for word in t0:
	print("t0: " + word)

print("====")

for word in t1:
	print("t1: " + word)

...

",amet sit dolor ipsum lorem"

Why are words in a reversed order? I don't think that's how it is in Python.

Why does the comma switch from being after the word amet to being in front of the word?
Why don't you use ["one", "two", "three", ...] for showcases like this. I think this would make it easier to see what happens exactly and to spot mistakes.

@Noshyaar correction done. First message is edited with updated script test example. Should be fine now, I suppose

var t0 = some_string.rsplit(", ", false, 0)
['Milk', ' Chicken', ' Bread', ' Butter']

A space in front of the last three words is not actually there? It could be unexpected for users.

@Noshyaar agree. Corrected. Check, now it is ok?

@Noshyaar corrected.

@akien-mga
Replaced with #14715 to solve merge conflicts.


Fix accidental regression in 4.14.1 Clflags

https://github.com/ocaml/ocaml/pull/11661 was cherry-picked to the 4.14.1 release, which causes an accidental regression for ocaml-jupyter.
This PR restores support for 4.14.1.

@dra27 Thank you!


Make sure we save the type of mutation fuinction as well when we save the simulation

solved through #120


Cleanup webrequestpscmdlet.common.cs

PR Summary

Small cleanup for better readibility

Should I remove redundant brackets ? (example: if (PassThru && (OutFile == null)))

@CarloToso You could look CodeFactor issues reported for the file and fix some ones.

Squashed


Resolved issue #755[closure calls its own deprecated installStyles method] and loremipsum.js setHtml() changed to setSafeHtml()

Trying to allow plovr 6.0.0 to compile my code which use goog.editor.field, seamlessfield, etc.
   [java] /closure/goog/editor/field.js:2298: ERROR - Property installStyles of type goog.style has been deprecated: Use {@link #installSafeStyleSheet} instead.
    [java]     goog.style.installStyles(this.cssStyles, this.getElement());
    [java]     ^
    [java]
    [java] /closure/goog/editor/plugins/loremipsum.js:142: ERROR - Property setHtml of type goog.editor.Field has been deprecated: Use setSafeHtml instead.
    [java]       fieldObj.setHtml(true, this.message_, true);
    [java]       ^
    [java]
    [java] /closure/goog/editor/plugins/loremipsum.js:176: ERROR - Property setHtml of type goog.editor.Field has been deprecated: Use setSafeHtml instead.
    [java]     fieldObj.setHtml(true, null, true);
    [java]     ^
    [java]
    [java] /closure/goog/editor/seamlessfield.js:433: ERROR - Property installStyles of type goog.style has been deprecated: Use {@link #installSafeStyleSheet} instead.
    [java]   goog.style.installStyles(newCSS, field);
    [java]   ^
    [java]
    [java] /closure/goog/editor/seamlessfield.js:561: ERROR - Property installStyles of type goog.style has been deprecated: Use {@link #installSafeStyleSheet} instead.
    [java]         goog.style.installStyles(this.cssStyles, this.getElement());
    [java]         ^
    [java]
    [java] 5 error(s), 0 warning(s), 95.7% typed

Travis look stuck at: Exception happened during processing of request from ('<IP_ADDRESS>', 46362)

@mashedcode should be ok now, thanks!

Travis CI build failed due to what a appear to be protactor test The command "travis_wait 30 ./scripts/ci/run_all_tests.sh" exited with 1.. Is there an acceptable way to re-trigger the build? From what I've found on SO closing and re-opening the PR will trigger the build, but I doubt this is acceptable here.

If you rebase your commit without changing anything and push force again it should trigger a new Travis build.

Rebase worked fine, thank you!


[QUERY] Add example Event Hubs namespace hostname in Schema Registry client creation example

Library name and version
Azure.Data.SchemaRegistry 1.3.0
Query/Question
In the Getting Started example for using Azure.Data.SchemaRegistry, there is a guide to create a SchemaRegistryClient for interacting with the schema registry service in the README.md file. In that example, there is no sample value given for the fullyQualifiedNamespace that is required to construct a client. This can cause confusion on the format of the Host name from the Event Hubs service itself, especially regarding fact that the scheme ("https://") part of the Host name should not be included as a parameter. Doing so causes a parsing error when trying to register a schema after the client is created.
An example can be formatted similar to {hostname}.servicebus.windows.net.
Environment
No response

I'd like to help out (although as a beginner) :)
Could you assign this bug to me?


PARCELS v2.2.0, Developers Install on HPC w/ Intel C & Fortran compilers, particleset.ctypes_struct produces boolean

Due to the configuration of the HPC (CINES OCCIGEN, system details at https://www.cines.fr/en/supercomputing-2/faq-hpc/) I'm using (using Python 3.6.3, Intel C and Fortran compliers v17.2 and OpenMPI v2.0.4 built with intel compilers, all implemented as modules pre-built by the admins) I have been forced to install Parcel v2.2.0 following the 'Installation for developers' outlined on the main parcels website (yes, before you ask I did make sure all dependencies were present and up to date before running the install script), rather than via Conda (I can get Miniconda working on the HPC but I've been allocated a stupidly low limit on the number of files in my home directory...).
When running any of the examples or my own code I got an error:
Traceback (most recent call last):
File "example_nemo_curvilinear.py", line 127, in
run_nemo_curvilinear(args.mode, outfile)
File "example_nemo_curvilinear.py", line 58, in run_nemo_curvilinear
output_file=pfile)
File "/home/croach/.local/lib/python3.6/site-packages/parcels/particleset.py", line 642, in execute
execute_once=execute_once)
File "/home/croach/.local/lib/python3.6/site-packages/parcels/kernel.py", line 399, in execute
self.execute_jit(pset, endtime, dt)
File "/home/croach/.local/lib/python3.6/site-packages/parcels/kernel.py", line 265, in execute_jit
particle_data = byref(pset.ctypes_struct)
TypeError: byref() argument must be a ctypes instance, not 'bool'
When I added a few print() statements to my code or to example_nemo_curvilinear.py to examine what's happening with the particle set I found that printing out pset produces what you'd expected but printing out pset.ctypes_struct resulted in a boolean False.
I have previously installed Parcels v2.2.0 on my laptop (Windows, using Conda with Python 3.6.11 and GNU C & Fortran compilers) without issue and I have previously installed one of the early versions of Python v2 (unsure if v2.1 or 2.1.2) on OCCIGEN using the 'Installation for developers' (with Intel C and Fortran compilers and Python 3.6.3), again without issue.
EDIT: And just got Miniconda working on the HPC, and installed PARCELS 2.2.0 through it... It works fine, so the above error must be due to either the compilers or the details of the 'Installation for developers'.

Thanks for reporting, @croachutas. I really have no idea what is going on here; we have not experienced this before. And we have limited expertise in installing on HPCs, so not sure we can be of much help
Perhaps trying to install under python3.8 could help? The latest master fully supports Python3.8
Good luck with trying to install Parcels on your system

Looking at this issue, there must have been something going wrong with the installation of your Python (the ctypes version and functions are bound to the Python version). Also, it would be good to compare both environments (non-conda and conda) by printing out the CC environment variable. I assume that your miniconda does not use the Fortran C-compiler icc but x86_64-conda_cos6-linux-gnu-cc, which is Conda's cross-platform GCC derivative. As ctypes is dependent on the C compiler, this is a potential caveat or hazard in HPC setups.
I can understand that HPC maintainers are not overly happy about Conda solutions - it is a sub-optimal work-around, as it side-lines the computer-collective setup that has been installed and maintained for maximum efficiency and performance. Still and that-being-said, the Conda-version is the only means we officially support for running OceanParcels. It would otherwise not be attainable to enable OceanParcels across different hardware setups and operating system installations.
Hoc concludere:

It's nice you got the miniconda setup running. It's the go-to way to run OceanParcels - locally as well as on clusters.
Using the pre-defined/preset HPC environment (without conda) is not something that can be done in general terms, and it would require in-depth installation and fine-tuning from your IT department to achieve this.


Question: folder structure

Would suggest such folder structure. Any thoughts?
src
  |_ components
      |_ Button.tsx
      |_ ...
      |_ form
        |_ index.tsx
        |_ TextInput.tsx
        |_ ...
   |_ utils (or internals?)
       |_ ...
   |_ index.tsx

As long as imports work the same, I don't have a strong opinion. eg:
import { Button, FormActions, TextInput } from 'react-nim';


[3.x] When Camera2D enters tree, ensure first update is not lost

3.x version of #63580.

How safe do you think this would be for 3.5? Given that IIUC it fixes a regression so might be important to have in 3.5-stable.
I just released 3.5 RC 8 and there might not be a RC 9 so it's a bit risky to merge further fixes at this stage, but if you're confident that it's safe it might be worth it.

I think it's safe. I also think it's better to have it than not to have it.

Thanks!


Characters are not escaped in LaTeX, leading to render errors

Describe the bug
Some characters commonly used in resumes are not escaped in LaTeX, leading to render errors, or inaccurate results.
For example,

"|" converts to "---"

"$" leads to render errors (need to manually escape it with"\"in the YAML file)

To Reproduce
Please provide a minimal YAML input as a code block for us to produce the same error.

    Skills:
      - >-
        Skill A | skill B | skill C

Screenshots
If applicable, add screenshots to help explain your problem.

Thank you!
I couldn't reproduce the "|" converts to "---" issue. In my case, it prints "|" successfully. Could you please provide a full YAML file to reproduce?
RenderCV doesn't escape the $ sign by default to allow users to add math. Do you think it would be better if it were escaped by default?

I'm using the sb2nov theme with Latin Modern Sans Serif. You can reproduce it by just adding the pipe character "|" to any yaml element using the sb2nov theme

Perhaps it is because of this: \usepackage[T1]{fontenc} as outlined here:
https://texblog.net/latex-archive/uncategorized/symbols/

Thank you!
I couldn't reproduce the "|" converts to "---" issue. In my case, it prints "|" successfully. Could you please provide a full YAML file to reproduce?
RenderCV doesn't escape the $ sign by default to allow users to add math. Do you think it would be better if it were escaped by default?

FWIW I like the non-escaped $ by default (but do admit finding this issue from searching 'escaping in rendercv')

As discussed in #154, we will escape $ but still allow users to use math with  $$. So if you are using math, you will be able to use it like $$\frac{3}{4}$$. @peteza33 You like non-escaped $ because you're using math, right?

yessir

This issue has been fixed. It will be released soon. Thank you!


update Mokelumne baseline habitat

LMR_HSI_2015conditions.xlsx
Update the Mokelumne baseline habitat using this file from Michelle Workman in an e-mail Monday, July 8th:
"Please find attached the updated HSI curves for the Mokelumne using our 2015 lidar as baseline, and the HR&L suitability criteria. These are the most up to date for use in the SIT and in the HR&L modeling for the Mokelumne River."

update existing in branch: mok-updates
scale HRL in branch: hrl-curves

PR here: https://github.com/Reorienting-to-Recovery/DSMhabitat/pull/45


DNS Tracking Issue for Guardian API Endpoint Rotation

Tracking Issue for roadmap to remove the DNS dependency created by including the guardian endpoints in the federation config, hashed into the federationId.
We're going to remove that dependency and allow guardians to rotate their endpoints, announce the api rotation, other guardians start using the new endpoint, then when clients reconnect to an unchanged guardian they'll get a signed update from the changed guardian forwarded that they can authenticate and switch to for that guardian specifically.
Building this based off discussions across devs and @elsirion's response in https://github.com/fedimint/fedimint/issues/5482#issuecomment-2189671747 , feel free to modify and update as this progresses. Tasks below are just stubs, will fill in with implementation details as those get finalized.

[ ] #5526
[x] #5527
[x] #5528
[x] #5529
[x] #5530
[x] ~#5531~
[x] #5532

I was wondering, could DIDs be of use here, given they provide dynamic routing capabilities and do not suffer from the same centralization risks DNS domains do?
Here's an example of a DID implementation, for reference: https://developer.tbd.website/blog/did-dht/

I think potentially for clients to find and ack announcements, but for now not part of the core fedimint repo. This issue is for tracking specifically DNS rotation options as part of 0.4 which is the minimal near term target to address the issue of a single guardian needing to change its DNS endpoint.
We've got PRs up adding TOR that are close to landing which are another near term option if people want to use/deploy with the associated tradeoffs. Then there's longer term (0.6) discussions about other solutions and protocols where arguments for DIDs might fit.

This was mostly implemented in #5570, the one outstanding issue is moving to FederattionIdV2, which will commit to the guardian keys instead of the API endpoints.


[Wave 6: Worksapce Chat] When a report is submitted on NewDot, we’re sending two emails to the approver. One from OldDot, one from NewDot

Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1703192299970489?thread_ts=1703187017.215259&cid=C02MW39LT9N
Note, to test this you must follow these steps to have a collect workspace on newdot.
Action Performed:

As the member, go to NewDot
Go to global create (+) > Request money > enter an amount > confirm
Navigate to the expense report view
Tap the Submit button
Notice an email is sent from OldExpensify and NewExpensify

cc @puneetlath
Expected Result:
You get one email - but this might be expected and it could be something we change with our Wave 7 migration plans.
Actual Result:
You get two emails.
Screenshots/Videos

View all open jobs on GitHub

I wasn't able to reproduce this one:

Have asked about the repro steps here.
Just noting that I'm on leave from tomorrow until Jan 8th and will check in on my return, but please reassign if this needs to move before then!

Holding for @greg-schroeder to review as discussed here.

Not overdue.

@0xmiroslav could you please take a look and see if this could be worked on externally?

Haven't worked on this yet, I'll pick it up in the asap

Started looking into this, but I think we first have to decide what the Expected Outcome should be:

You get one email - but this might be expected and it could be something we change with our Wave 7 migration plans.

Asking here: https://expensify.slack.com/archives/C02MW39LT9N/p1705440821021659?thread_ts=1703187017.215259&cid=C02MW39LT9N

I think there is something missing in the testing steps. I only got one email "test-collect-email-wp-admin owes $23.00"

PR: https://github.com/Expensify/Web-Expensify/pull/40602

PR under review

Removed @0xmiroslav as C+, I think automation failed and they weren't requested to the review the PR that just hit staging.

Adjusting the priority of this to fit migration plan

Looks like this is finished up though!

The PR was merged and deployed a while ago. Have in mind that the OldDot notification will only be skipped if the manager has an account that is being redirected to NewDot.


colon character prevents output

Smart.Format("{N:Weight: {} lbs.|}", new { N = "20" })
Expected:  Weight: 20 lbs.
Result: empty string
Removing colon character works
Smart.Format("{N:Weight {} lbs.|}", new { N = "20" })
outputs  Weight 20 lbs.
Version: 1.61

This is because of the "named formatter" syntax, which thinks you're trying to use a formatter called "Weight".
You should escape the 2nd colon, like `@"{N:Weight: {} lbs.|}

I didn't understand the escape sequence usage.
Moreover this takes away the simplicity of the previous versions.  How about after piping through all  formats from all the extensions and falling back to treating "Weight" as a literal text?

Sorry, I fixed the escape code, it should've been  @"{N:Weight\: {} lbs.|}".

Regarding alternative options, other than escaping it...
Currently, parsing happens before formatting, so it's not too easy to "fall back".  And currently, if the formatter isn't found, it's a formatting error.  (In Release mode, the ErrorAction is set to Ignore, so that's why you get an empty output.  If you set ErrorAction to Throw, you'd see the error).
I like the fact that an "unrecognized" formatter will throw an error instead of just output the text.  So I think I like the escape sequence.
However, I'm thinking about an alternative way to escape.  What if we did double-colon at the beginning, which would essentially say "don't use a named formatter", so that way you'd be free to use colons in your output.  Here's an example:
"{N::Weight: {} lbs.|}" The double-colon would avoid the ambiguity.  You could also do something like "{N::plural(s): {}|}"because normally, this would get parsed as Selector: "N", FormatterName: "plural", FormatterOptions: "s", format: " {}|"

@"{N:Weight: {} lbs.|}". This escape sequence is not working.
{N::Weight: {} lbs.|} Double colon works.
That makes me think why not use double colon as the default for named formats?  Because while learning the named formats user already need to know what the formats are and learning about extra colon is not a complicated thing.

Hmm, interesting. Maybe better than double colon would be a different char. I'll put some thought into it.

Ok, I have an idea.  With String.Format, there's a feature called "alignment" with the following syntax:
{0,-16:N2}
So I'm thinking, perhaps named formatters could use this same syntax - using a comma instead of the colon or double-colon:
{Value,choose(1|2|3):one|two|three}

Hello, any fix or workaround for this problem ? I'm using SmartFormat with a HTML template, so I can't escape the colon... If I use double colon, it works but I have a colon at the beginning of the output  that I don't need. Example :
With :
{MyListOf2Values:: Value: {MyValue} |}
I get :
": Value: 12 : Value: 12 "
Thanks.

As a workaround, you could probably intentionally use the named formatter:
{MyListOf2Values:list: Value: {MyValue} |}

I'm still considering what the long-term fix will be, because the current syntax is certainly causing some conflicts.  But for now, hopefully that works.

Should be solved with #65

Will be solved in upcoming version 1.7.x shortly:
When the parser comes across a formatter name, this does not exist in the registered extensions, it will treat this part as a format, which will be processed by DefaultFormatter.

Updated version committed, where test with the issues mentioned have passed: https://github.com/scottrippey/SmartFormat.NET/commit/46bbae26b6c34582887b60fc0488cd134514fde7


⚠ AsianCinema has degraded performance

In 3ccc334, AsianCinema ($ACM) experienced degraded performance:

HTTP code: 200
Response time: 3770 ms

Resolved: AsianCinema performance has improved in ec3e2b9 after 5 minutes.


Change Screen Recorder

Is your feature request related to a problem? Please describe.
No problems.
Describe the solution you'd like
I would like to be able to change the command and icon for screen recorder in the hyprpanel dashboard settings the same as the color picker or screenshot shortcuts.

+1 for this. I only have an integrated intel cpu on my laptop and the current command just doesn't work atm.

I need to pass the -encoder cpu argument here, else it doesn't work at all for me.
As a side feature, it would be cool if the screen_record.sh could detect if a dedicated GPU is present and execute the command appropriately.

As a side feature, it would be cool if the screen_record.sh could detect if a dedicated GPU is present and execute the command appropriately.

Just added this in a PR. I do think though we should still have the option to change screen recorder as OP said.


How to manage migrations in different branches?

Here's the situation:  I have two release branches, release/1.0 and release/1.1.  Release 1.0 is the version being QA'd for the next release, while 1.2 is for later release.  All Db migrations created for 1.0 automatically get pushed up to 1.1, and there are several migrations that are only on 1.1.  Let's say:

Migration 1 is on 1.0
Migration 2 is on 1.1
Migration 3 is on 1.0
Migration 4 is on 1.1

On the QA server, therefore, only migrations 1 and 3 have been run.
Now the QA version (1.0) is approved and pushed to Production.  Time to promote 1.1 to QA so they can start testing it.  Oops, problem: when we pushed 1.1 to QA, it ran Migration 4 as we expected, but it omitted Migration 2, because the QA database was already holding at Migration 3.
What's the proper way of dealing with this situation?  Perhaps EF should check for all new migrations, not just the ones that appear alphabetically after the last one?

Perhaps EF should check for all new migrations, not just the ones that appear alphabetically after the last one?

This is how Migrations is expected to work. Not applying Migration 2 is a bug. Could you share a repro?

Oh, my bad.  The scripts were failing to execute because of a schema conflict, but they were trying to run at least.  I fixed the scripts and now we're in sync again.  Thanks!