Just can't get REX-Ray working with this!

Hi,
I've been trying to get this script working to the way it's supposed to for over two weeks now (don't laugh, please) with little success. Initially it was things like vagrant missing the correct plugins and certificate errors blocking files from being downloaded, but now that I've jumped those hurdles problems with REX-Ray are starting to pop up. When I ssh into mdm1 and try running REX-Ray CLIs, two distinct things will come out of it:

Any rexray input will have mdm1 just hang until it complains about "fatal runtime error: out of memory"
The CLIs will work but they don't work as expected. "rexray help" works fine, but "rexray get-instance" returns nothing and "rexray new-volume" shows all the inputs as being null (i.e. size=0, name = "", etc) and doesn't actually create a volume.

I'm certain I've followed the instructions to a T, so I don't know what could be wrong. Have you experienced these issues before?

Can you paste the REXRAY_DEBUG=true rexray get-instance output here?  Are you sure that the ScaleIO instance is functioning?  In most cases where this doesn't work as expected it has to do with memory requirements not being met which overall results in the SIO gateway not working as expected.

Here's the error I'm getting. I believe the ScaleIO instance is functioning, since scli commands are working fine - I can log in, check the volumes, that sort of thing.

During the discovery phase of ScaleIO, there is an error reported as "systemid or systemname not found".  Check your GOSCALEIO_SYSTEMNAME or GOSCALEIO_SYSTEMID env variable to ensure it is valid.

@mcmast2 try this
systemctl restart rexray
REXRAY_DEBUG=true rexray get-instance

Thanks for the tips guys. There's no GOSCALEIO_SYSTEMNAME/SYSTEMID, and I think I've identified the problem - here's a big error report I get when building the VMs with "vagrant up":

Seems like it has a coronary and times out when it tries to run the command to switch to cluster mode, and that makes the ScaleIO cluster not function properly (or at all) because it's missing the right dependencies. I'm poking through the Vagrantfile to try and give it more time before it times out but I'm not finding anything like that. Any advice at this point?

@mcmast2 I've felt your frustration. Here's what I did so could demo REXray.
git clone https://github.com/clintonskitson/vagrant-scaleio
cd vagrant-scaleio
git checkout rexray_updates
vagrant up
I took atleast 2-3 tries for it to come up correctly in my Mac with 8gb.
After that, the directions for using rexray for a demo of showing persistent data stores are found in a different repo.
https://github.com/emccode/vagrant-puppet-scaleio/tree/docker_1.7rc3_experimental_rexray
Sorry about all that. Once @clintonskitson is back from vacation it will get cleaned up

Thanks very much - after some fair amount of trial and error I got it working, just like you said. Can't wait to see the whole thing get cleaned up. Case closed!

great.  :(
Kenny
On Mon, Jul 27, 2015 at 11:03 PM, mcmast2<EMAIL_ADDRESS>wrote:

Closed #8 https://github.com/emccode/puppet-scaleio/issues/8.
—
Reply to this email directly or view it on GitHub
https://github.com/emccode/puppet-scaleio/issues/8#event-366772052.

Actually, I've tried it twice after restarting my computer both times and it worked fine both times! I have no idea what the difference is but I figured I'd mention that

how much RAM do you have running on your system?

6 gigs. It's Windows 7, if that helps.

thanks. everyone on our team has 8GB or more and things seem to really get sluggish on 8GB

It's also worth noting that I halved the size of each virtual machine's RAM by editing the Vagrantfile so that they'd work on my machine. If it's so sluggish then that seems like a valid option


Change email subject prefix variable name in settings

Description
As I was working with cookiecutter django on a personal project I encountered an issue with one of the variables handling the email details.

I've made a small change in production.py file regarding the name of EMAIL_SUBJECT_PREFIX.
I've NOT updated the documentation, because I didn't want to mess up the srt file (new var name was a bit long).

You can read more on this stackoverflow answer.

That will only work for accounts related email though? The current setting is for all emails sent by Django. Does Django-allauth has their own custom logic to send email? Seems a bit surprising that they wouldn't default to Django's setting.

In my project I used mailgun in production, but I tested with mailpit locally as well. I think is an allauth related variable and not a django one.

Thanks!


Flatten sponsorLastUpdateTimestamp

Currently, the sponsorLastUpdateTimestamp is part of gas prices, but it is not really related to that field and could be abstracted to its own field in the state.

Could be done as part of https://github.com/api3dao/airseeker-v2/issues/53


Update for latest challenge

A new form field was added by Cloudflare. We could check for and add these form fields automatically and log a warning that we've done so to keep things working until we have a chance to update.
Fixes #148

Omg! Blazingly fast! Thank you!


dynamic-import-chunkname does not allow additional comments

eslint: v7.3.1
eslint-plugin-import: v2.22.0
Eslint rule:
"rules": {
	"import/dynamic-import-chunkname": "error",
}

Code:
import(
	/* webpackInclude: /\.json$/ */
	/* webpackChunkName: "module" */
	"./module.js"
);

Produces error:
  1:1  error  dynamic imports require a leading comment in the form /* webpackChunkName: "[0-9a-zA-Z-_/.]+",? */  import/dynamic-import-chunkname

Version 2.21.2 works well

Looks like a duplicate of #1407; i'm not sure tho why it would have worked in v2.21.


Add HeightMapShape3D update with Image data

Adds HeightMapShape3D update with Image data.
Populating height values in a heightmap collision from an image file is a common use.
It shouldnt be required that users need to read large image data arrays with slow scripts to achieve this basic thing.
So what this pr does is add update_map_data_from_image() as a new function to HeightMapShape3D.
The function allows a single component black&white Image in format  FORMAT_RF (32 bit) or FORMAT_RH  (16 bit) or FORMAT_R8 (8 bit) as input and to define a minimum and maximum height range. The image pixel values read in 0.0 to 1.0 range are then remapped to those values.
The code for this was actually found in part on the PhysicsServer3D as more or less dead-code not reachable by users. It also makes far more sense to have this functionality on the collision shape directly to update the map_data. This data array is commonly used for other related stuff, like creating procedual meshes from the heightmap data.
Full usage example to create heightmap collision from an image file:
extends Node3D

func _ready() -> void:
    var heightmap_texture: Texture = ResourceLoader.load("res://heightmap_image.exr")
    var heightmap_image: Image = heightmap_texture.get_image()
    heightmap_image.convert(Image.FORMAT_RF)

    var heightmap_shape: HeightMapShape3D = HeightMapShape3D.new()
    var height_min: float = 0.0
    var height_max: float = 10.0
    heightmap_shape.update_map_data_from_image(heightmap_image, height_min, height_max)

    var static_body: StaticBody3D = StaticBody3D.new()
    var collision_shape: CollisionShape3D = CollisionShape3D.new()
    collision_shape.shape = heightmap_shape
    static_body.add_child(collision_shape)
    add_child(static_body)

Great feature, it would be even better if the HeightMapShape3D could be updated partially from the height map image.

Added error msgs and support for the lower precision formats Image::FORMAT_RH and Image::FORMAT_R8.
@Redwarx008 Partial updates (and reads) should be also made available, not only for the image but also for the normal byte array. I will see what I can do but that deserves its own pr.

Thanks!


verify contract failed

ghcr.io/blockscout/smart-contract-verifier:v1.3.0
I tried New Smart Contract Verification via Standard input JSON and hardhat also got the same error:
invalid argument: Initialization(
    Empty,
)

It's my bad


Accreditation for ICES Data Management

Aspect
Description

Opportunities
 Recognition through an internationally recognised accreditation body Greater confidence in ICES Data management and advice outputs

legacy entry

Likelihood: ICES is accredited following CoreTrustSeal
Impact: Being accredited brings with it a set of opportunities with regards to collaboration. It also shows that ICES follows best practices and gives data provides a sense of trust in the work being put into data managmenet at ICES.

ICES DC submitted a new application for a 3 year accreditation with CTS 31 JANUARY 2024. Awaiting appraisal.


GOD EATER 2 [PCSG00240]

App summary

App name: GOD EATER 2
App serial: PCSG00240
App version: 1.00

Vita3K summary

Version: v0.1.6
Build number: 2830
Commit hash: https://github.com/vita3k/vita3k/commit/38adaa75
CPU backend: Dynarmic

Test environment summary

Tested by: nishinji
OS: Windows 10
CPU: Ryzen 9 3950x
GPU: RTX 3060ti
RAM: 32 GB

Issues
Screenshots
Log
vita3k.log
Recommended labels
Nothing
Crash

Vita3K summary

Version: v0.1.6
Build number: 2934
Commit hash: https://github.com/vita3k/vita3k/commit/dc5a7ae2
CPU backend: Dynarmic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:
Game goes ingame but hangs at a loading screen after the first cutscene
Screenshots:

Log
vita3k.log
Recommended labels

Ingame-

App summary
App name: GOD EATER 2
App serial: PCSG00240
App version: 1.41

Vita3K summary
Version: v0.2.0
Build number: 3688
CPU backend: Dynarmic

Issue:
Except for the screen, everything is normal.
Screenshots:


Question: how to overwrite api setState ?

I'm trying to use immer in api setState, but unable to overwrite it
This doesn't seems to work:
  config(fn => set(produce(fn)), get, {
    ...api,
    setState: fn => api.setState(produce(fn)),
  });

this should work:
const immer = config => (set, get, api) => config(fn => set(produce(fn)), get, api)

const [useStore] = create(immer(set => ({
  text: "hello",
  setText: input => set(state => void state.text = input)
})))

api.setState(produce((s) => { s.a = 'b'; })) should work.
You can also create a function wrapper for it:
const setState = fn => api.setState(produce(fn));
setState((s) => { s.a = 'b'; });


Tuning clean up

Integrating with the latest lightray update which now exposes most of the tune.Tuner API. This will allow users to configure things like the TrialScheduler, SearchAlg etc.
Adds TuneLocal task which works the same way as TrainLocal vs TrainRemote: If AFRAME_TRAIN_RUN_DIR is an s3:// path will tune remotely.
Removes TraceModel callback, which was unnecessary to do at the end of every epoch for every trial, and was contributing to some bottlenecks. Don't yet have a cleaner solution for automatically tracing the best model, so will have to do it by hand for now.

Looks good, I think there's just a typo in bbh.yaml and bns.yaml

What was the typo in bbh.yaml?

I thought it was also "progres" instead of "progress", but it looks like I misread it, or just looked at bns.yaml twice

@wbenoit26 can I get an approval when you get a chance?


Investigate session data storage

What
Look at different session storage methods. Ideally the would be able to store an arbitrary amount of session data between server restarts, both locally and when hosted online. Ideally we would have one method that would work both for production and development, but prioritise having a method for local development that keeps session data between restarts, and won't emit warnings in production.
Why
See comment from @joelanman:

https://github.com/alphagov/govuk-prototype-kit/pull/1648#issuecomment-1268367384

Who needs to work on this
Developer
Who needs to review this
Developer, UCD
Done when

[ ] An arbitrary amount of data can be stored in user sessions
[ ] User session data is not lost between server restarts in local development
[ ] The kit does not emit warnings about session storage when running in production

Interesting point from discussion including Ed Horsford and Frankie Roberto, session data includes defaults, so users can start their session with a lot of data already (over 20 MiB in Ed's case). https://ukgovernmentdigital.slack.com/archives/C0E1063DW/p1664973477189429?thread_ts=1664972908.131459&cid=C0E1063DW


Fix for v8 bulbs MAC address type set to public instead of random

Fixes connection issues

Issue #30


MoPub 4.1.0

They now require Activity instead of Context

Thank you @talklittle, for commit the changes for supporting mopub 4.1


GitHub Sensor

Description:
Adds a GitHub sensor with a bunch of data with help from the PyGithub library. Sensors are added from a list of repository paths and optional names.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7942
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: github
    access_token: !secret github_access_token
    repositories:
      - path: 'timmo001/home-panel'
        name: 'Home Panel'
      - path: 'timmo001/home-panel-api'
        name: 'Home Panel API'
      - path: 'hassio-addons/addon-matrix'
        name: 'Matrix Add-on'
      - path: 'home-assistant/home-assistant'
      - path: 'home-assistant/home-assistant.io'

Example Data Screenshot

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Would it be possible to add an attribute for that showed the version number for the most recent release?  This could then be used to fire an automation whenever a new release was posted on a particular GitHub repository.  That would be really handy for tracking new versions of GitHub hosted software

Would it be possible to add an attribute for that showed the version number for the most recent release? This could then be used to fire an automation whenever a new release was posted on a particular GitHub repository. That would be really handy for tracking new versions of GitHub hosted software

Good idea! I'll take a look at implementing this after the festivities 🎅 👍

Added latest release as JSON object:

👍👍👍👍 thanks.  This is great but seems like a lot of information to be held in an attribute.  I think only the version number and maybe the date is relevant

OK. I think that's everything. The sensor now works with the entity registry and the attributes are a lot easier to use now. I also uncovered a bug in the frontend :smile:

Found bug with setting unique_id on init. On restarts, the id will change every time :confused:

I'm happy to merge now @amelchio :+1:  :smiley:

I'm happy to merge now @amelchio :+1:  :smiley:


Addding heroku_will_terminate?

Added docs to explain the purpose
Used a global variable. I hate global variables, but storing this state in the worker seemed like a bad idea. A reference to the worker would need to be passed around to every object which wanted to see if the process would die.
A process dying soon feels like global state, so it didn't seem like a horrible idea to use a global variable

@pjambet would you mind taking a look here and offering some feedback?

@pjambet Merging this in, but feel free to submit a post-merge review.


[Support Testing] Add missing DELETEAsync,PATCHAsync  method for testing

Add support from Issue #100

@nghiepvo fyi github now automatically closes PRs if you delete your fork before the PR is merged :-(

or did you close it on purpose? i you've gotten rid of the GETAsync method. which is not good. there shouldn't be any breaking changes. is this a bad PR?


Activate only on NETFLIX's domain

The same behavior found at Chrome Matcher

Firefox supports chrome extension's structure


Fix #138 (dir entries getting droped due to race condition)

Okay, so ignore my previous description - there's a bit more here than I had initially.
First, I've removed the setImmediate() call to fix the issue I reported in #138.  However this re-broke the asyncIterator behavior.  I'm pretty sure the problem there was in the _read() implementation, which was ignoring the return value of push().  Per the Node docs, when _read() is called you're supposed to push() data until push() returns false, then wait for _read() to be called again.    Because the code was blindly push()ing with no regard for the return value,  I think that caused the stream to drop out of "flowing" mode,  effectively hanging the async iterator.  (Admittedly, this at the limit of my understanding of how streams work, so I may not have that exactly right, but I that's my best guess at the issue.  Also, I'm not sure how to explain the various tests people reported, mine included, just cleanly exiting rather than hanging. :-/ )
I'm pretty sure this misbehaving _read() is what was causing #91 and #97.
To fix this, I rewrote _read() to have a while-true loop that does two thngs: 1) "explore" the filesystem until it gets some entries to push, and 2) push() entries until it sees false.  It only drops out of that loop when push() == false (or we run out of things to explore).
Other changes of note:

Use Promise.all to parallelize getting dirent stats
Use _reading mutex in _read rather than the more complicated filesToRead logic.
_exploreDirectory() returns entries to main _read loop, rather than pushing them.
added check in readdirp#promise's 'error' event handler so errors after promise resolves won't be silently swallowed.
Removed the "missing file" test.  I think that test relied on the fact that exploring of the directory was deferred until after the "readable" event fired (due to the setImmediate() call).  But that's no longer the case in this PR - the directory is pushed before "readable" fires now.... and I don't really see how to replicate that test easily.
Remove highWaterMark option - it's just a hint passed into _read(), which is ignored anyhow.

Can you measure RAM and CPU impact of your changes? Pick a directory with 100,000 files and more for this.

Added "examples/perf.js", which basically does the same thing as "examples/list.js", but logs process.memoryUsage() info every 500ms.  Here's what I get when running 3x with this PR:
$ node perf.js
 37000 rss=44.2M   heapTotal=25.8M   heapUsed=7.4M    external=0.7M
 78000 rss=45.0M   heapTotal=26.2M   heapUsed=13.7M   external=0.8M
124000 rss=45.6M   heapTotal=26.2M   heapUsed=9.3M    external=0.8M
165000 rss=45.6M   heapTotal=26.2M   heapUsed=11.7M   external=0.8M
194467 rss=62.8M   heapTotal=43.2M   heapUsed=20.1M   external=0.8M
Processed 194467 files in 2357 msecs

$ node perf.js
 37000 rss=44.2M   heapTotal=25.0M   heapUsed=8.1M    external=0.7M
 84000 rss=45.3M   heapTotal=26.2M   heapUsed=10.2M   external=0.8M
130000 rss=45.5M   heapTotal=26.2M   heapUsed=12.0M   external=0.8M
171000 rss=45.6M   heapTotal=26.2M   heapUsed=8.4M    external=0.8M
194467 rss=45.7M   heapTotal=26.2M   heapUsed=12.9M   external=0.8M
Processed 194467 files in 2341 msecs

$ node perf.js
 34000 rss=43.7M   heapTotal=25.0M   heapUsed=12.4M   external=0.7M
 82000 rss=44.5M   heapTotal=25.4M   heapUsed=11.4M   external=0.8M
128000 rss=45.0M   heapTotal=25.9M   heapUsed=10.6M   external=0.8M
166000 rss=45.0M   heapTotal=25.9M   heapUsed=8.2M    external=0.8M
194467 rss=45.2M   heapTotal=25.9M   heapUsed=11.8M   external=0.8M
Processed 194467 files in 2340 msecs

And here's what I get with that same test, running against the current master:
$ node perf.js
 29000 rss=78.1M   heapTotal=50.9M   heapUsed=26.1M   external=0.7M
 97000 rss=87.4M   heapTotal=58.5M   heapUsed=17.5M   external=0.8M
176000 rss=97.6M   heapTotal=69.0M   heapUsed=46.6M   external=0.8M
194467 rss=103.2M  heapTotal=74.3M   heapUsed=41.0M   external=0.8M
Processed 194467 files in 1706 msecs

$ node perf.js
 33000 rss=80.7M   heapTotal=53.8M   heapUsed=28.4M   external=0.7M
108000 rss=84.9M   heapTotal=55.9M   heapUsed=24.4M   external=0.8M
185000 rss=102.0M  heapTotal=73.7M   heapUsed=44.2M   external=0.8M
194467 rss=104.2M  heapTotal=75.3M   heapUsed=54.6M   external=0.8M
Processed 194467 files in 1613 msecs

$ node perf.js
 20000 rss=71.0M   heapTotal=46.7M   heapUsed=21.4M   external=0.7M
 74000 rss=97.4M   heapTotal=69.3M   heapUsed=40.0M   external=0.8M
143000 rss=89.3M   heapTotal=60.6M   heapUsed=28.8M   external=0.8M
194467 rss=102.2M  heapTotal=73.5M   heapUsed=45.7M   external=0.8M
Processed 194467 files in 1929 msecs

So... looks like this PR is more memory efficient, but slightly less performant.

@ronag what are your thoughts on that?

when _read() is called you're supposed to push() data until push() returns false, then wait for _read() to be called again. Because the code was blindly push()ing with no regard for the return value, I think that caused the stream to drop out of "flowing" mode, effectively hanging the async iterator.

I don't think this is correct. You should stop pushing if it it returns false, but it's just a hint. Also you can just push once and then _read will be called again.
What is the actual problem here?

Ah, didn't see the referred issues. That's going to take some time to dig into.

@ronag the main issue here was https://github.com/paulmillr/readdirp/issues/138: while using setInterval, readdirp was giving different results sometimes.

@paulmillr @ronag To clarify, the issue isn't the use of setInterval, per se.  The issue is the race condition that arises from push()'ing to the Readable stream asynchronously (and ignoring the return value of push()).  But, because it's a race condition, the issue manifests sporadically.  So demonstrating the problem requires running multiple times until the behavior manifests.  At least, on my laptop it does.


Add Tailwind CSS to administration module

Is your feature request related to a problem? Please describe.
I have a suggestion to use tailwind css classes instead of separate react components that only contain styling.
For example, this component:
const UnFocusedDiv = styled.div`
  display: flex;
  align-items: center;
  flex: 1;
  :focus {
    outline: none;
  }
  height: 25px;
`

could be turned into:

...

Maybe it's a matter of personal preference, but IMO looks leaner and less code is easier to maintain.
Feel free to object.
Describe the solution you'd like
Add a new dependency, replace style-only-components with tailwind classes
Describe alternatives you've considered
Leave as is
Additional context
https://tailwindcss.com/docs/installation

Before i joined digitalfabrik, i was also using different css framework and styled components were quite new and not common.
I think the biggest pro argument for us was that we can use it in React and React Native more or less equally (except of that some css features don't exist in react native and won't be translated)
I think styled components are quite strong and easy to understand and we use it in several projects.
I don't see the big benefit to refactor the whole project.
You can even create base components and make inheritance and everything. It's just a matter of usage


cross platform: fix runtest.sh start path and force build flavor

Similar to Windows runtests.cmd, runtests.py asks for a build flavor instead of forcing release build.

So enabled path discovery and transferring the command line parameter for future update on CI.
At the moment we have the CI at least testing basic stuff for us.

Only one comment about variable name, LGTM otherwise.


incorrect relevant span mapping

Hi,
Thank you for the great work,
There are some problems with the dataset and the extracted relevant spans.
For example in Bmr023.json#L39
for the query "What was decided on DARPA?" the relevant spans is annotated as turn 32-35 but actually it is 36-39.
Is there problem with mapping? or should I count the turns in another way?

Thank you for your interest in our work!
I looked at the example you gave, and I'm sorry that this is indeed a relatively poor-quality answer. There are many annotators involved in the construction of QMSum, it is inevitable that the quality of a few answers may be relatively poor. But based on the relevant text span, this answer can actually be obtained, because the main information is in Turn 35 (Turn's index starts from 0). Have you found more examples of mismatches? I will take a closer look at them to find out if some annotators have misunderstood the index of the utterance.

okay! makes more sense now.
Thank you for the clarification


Added => Maths and Stats => Geometry => Vector Product => TS

Cross product or Vector product is a binary operation on two vectors in three-dimensional space.
Assigned Issue Number ?
#408
Language Opted ?
TypeScript
Number of files added or updated ?
1
Name of these files ?
Maths and Stats => Geometry => Vector Product => TS
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Test and proof of work


Pip 20.1 breaks pipchecker

When upgrading to pip==20.1, the following exception appears:
Traceback (most recent call last):
  File "./manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "./lib/python3.8/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "./lib/python3.8/site-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "./lib/python3.8/site-packages/django/core/management/base.py", line 323, in run_from_argv
    self.execute(*args, **cmd_options)
  File "./lib/python3.8/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "./lib/python3.8/site-packages/django_extensions/management/utils.py", line 62, in inner
    ret = func(self, *args, **kwargs)
  File "./lib/python3.8/site-packages/django_extensions/management/commands/pipchecker.py", line 92, in handle
    name = req.name if req.name else req.link.filename
AttributeError: 'ParsedRequirement' object has no attribute 'name'

It's working fine when downgrading to pip 20.0.1.
django-extensions==2.2.9

I tried to be helpful here but it appears the internals of pip changed quite a bit, so I won't be able to help much, except by saying the commit that changes everything is:
https://github.com/pypa/pip/commit/90e4eb3eedc7c550c2dd036b7a535cdec50a93d5#diff-851cc85103a872db421c81afadd4fee5
They changed the signature of the function and it now returns a different class. (see L176)

I modified this code before. Let me solve this problem. :)


Merging is broken

Describe the bug
Merging two config trees is broken.
the following unit test in scala hocon shows that two config trees with the same keys should override each other
https://github.com/lightbend/config/blob/d279841c425e70645feacbdc03e41b3b022ad1f9/config/src/test/scala/com/typesafe/config/impl/ConfigTest.scala#L114
the following snippet in pyhocon shows the same
>>> c = pyhocon.ConfigFactory.parse_string('''{"test": {"test_topic": "a"}}''')
>>> c2 = pyhocon.ConfigFactory.parse_string('''{"test": {"test_topic": "c"}}''')
>>> pyhocon.ConfigTree.merge_configs(c, c2)
ConfigTree({'test': ConfigTree({'test_topic': 'c'})})

the same cannot be said for akka.net hocon
linqpad snippet:
void Main()
{
	string a = @"
	{'test': {'topic_one': 'a'}}
	";
	string b = @"
	{'test': {'topic_one': 'c'}}
	";

	Config configone = HoconConfigurationFactory.ParseString(a);
	Config configtwo = HoconConfigurationFactory.ParseString(b);

	//configone.Dump();

	Config three = new Config(configone, configtwo);
	//three.Dump();

	configone.GetString("test.topic_one").Dump("one");
	configtwo.GetString("test.topic_one").Dump("two");
	three.GetString("test.topic_one").Dump("merged");

}
// You can define other methods, fields, classes and namespaces here

result:

closing this as invalid, it seems as a common problem with all hocon projects is they just ship HOCON.md as the readme file and have no other documentation, a friendly suggestion for this project
but reading the docs and how scala hocon works, the order seems "backwards" at least to me. in scala hocon, you parse the -D jvm parameter first, then system properties, then application.conf, and then reference.conf files. For me at least, i thought you would apply the 'least significant' config first then merge stuff ontop of
when you reverse the LINQPAD snippet i posted, it works as expected


List supported pretraining model names

Right now, it's pretty tedious to find out which model architectures are supported for pretraining. A user has to look that up in the config.py. I think it would be convenient to print a list of supported model names. E.g.,
litgpt pretrain

which prints
stablelm-base-alpha-3b
stablelm-base-alpha-7b
stablelm-tuned-alpha-3b
stablelm-tuned-alpha-7b
stablelm-3b-4e1t
stablelm-zephyr-3b
stablecode-completion-alpha-3b
stablecode-completion-alpha-3b-4k
stablecode-instruct-alpha-3b
stable-code-3b
pythia-14m
pythia-31m
pythia-70m
pythia-160m
pythia-410m
pythia-1b
pythia-1.4b
pythia-2.8b
pythia-6.9b
pythia-12b
pythia-70m-deduped
pythia-160m-deduped
pythia-410m-deduped
pythia-1b-deduped
pythia-1.4b-deduped
pythia-2.8b-deduped
pythia-6.9b-deduped
pythia-12b-deduped
dolly-v2-3b
dolly-v2-7b
dolly-v2-12b
RedPajama-INCITE-Base-3B-v1
RedPajama-INCITE-Chat-3B-v1
RedPajama-INCITE-Instruct-3B-v1
RedPajama-INCITE-7B-Base
RedPajama-INCITE-7B-Chat
RedPajama-INCITE-7B-Instruct
RedPajama-INCITE-Base-7B-v0.1
RedPajama-INCITE-Chat-7B-v0.1
RedPajama-INCITE-Instruct-7B-v0.1
falcon-7b
falcon-7b-instruct
falcon-40b
falcon-40b-instruct
falcon-180B
falcon-180B-chat
open_llama_3b
open_llama_7b
open_llama_13b
vicuna-7b-v1.3
vicuna-13b-v1.3
vicuna-33b-v1.3
vicuna-7b-v1.5
vicuna-7b-v1.5-16k
vicuna-13b-v1.5
vicuna-13b-v1.5-16k
longchat-7b-16k
longchat-13b-16k
Nous-Hermes-llama-2-7b
Nous-Hermes-13b
Nous-Hermes-Llama2-13b
Llama-2-7b-hf
Llama-2-7b-chat-hf
Llama-2-13b-hf
Llama-2-13b-chat-hf
Llama-2-70b-hf
Llama-2-70b-chat-hf
Gemma-2b
Gemma-7b
Gemma-2b-it
Gemma-7b-it
FreeWilly2
CodeLlama-7b-hf
CodeLlama-13b-hf
CodeLlama-34b-hf
CodeLlama-70b-hf
CodeLlama-7b-Python-hf
CodeLlama-13b-Python-hf
CodeLlama-34b-Python-hf
CodeLlama-70b-Python-hf
CodeLlama-7b-Instruct-hf
CodeLlama-13b-Instruct-hf
CodeLlama-34b-Instruct-hf
CodeLlama-70b-Instruct-hf
Platypus-30B
Platypus2-7B
Platypus2-13B
Platypus2-70B
Camel-Platypus2-13B
Camel-Platypus2-70B
Stable-Platypus2-13B
Platypus2-70B-instruct
LLaMA-2-7B-32K
phi-1_5
phi-2
Mistral-7B-v0.1
Mistral-7B-Instruct-v0.1
Mixtral-8x7B-v0.1
Mixtral-8x7B-Instruct-v0.1
Mistral-7B-Instruct-v0.2
tiny-llama-1.1b
tiny-llama-1.1b-chat
Llama-2-7b-chat-hf-function-calling-v2

So a user can then copy the name & specify a model via
litgpt pretrain --model_name tiny-llama-1.1b

What do you think?

PS: If you like this idea, before merging, I probably should scan the docs to make sure we don't use litgpt pretrain without a --config or --model_name anywhere.

@rasbt I like the initiative to make it easier to discover the model names. The PR currently lists all models, but my concern is that wouldn't it be confusing to list models that aren't meant for pretraining? Many of them are instruct/chat models that we have included in the config list with the intention that they be downloaded to chat or perhaps be further finetuned. For pretraining, I think it is confusing to list these, and it makes the list very long.
Perhaps we could come up with a way to filter them out, but I wonder if it's worth it. We also need to be careful not to grow the number of boilerplate code in the scripts, so if we decide to add this, perhaps it could move to a utility that we import and add as a one-liner.

I agree that the list seems long, i.e., if we take
falcon-7b
falcon-7b-instruct
falcon-40b
falcon-40b-instruct
falcon-180B
falcon-180B-chat

then the instruct and chat variants are redundant since they are the same architecture as the other ones.
On the other hand, it may make sense to pretrain e.g., falcon-7b-instruct in certain cases, i.e., if we start with an initial checkpoint. I.e., suppose I have a falcon-7b-instruct model and I want to update it with medical knowledge or so. But that would only apply if one used --initial_checkpoint_dir. So in this case for --model_name, I agree we should shorten the list.
Right now, I think we can catch all instruction-finetuned model by filtering our strings that contain "instruct", "chat", and "-it" (gemma). I can add that if you agree.

Updated it to filter out chat and instruction models as suggested.

I find this too ugly in the code for little added value.

Do you mean the filtering or the listing of the models in general?

I mean the filtering in the pretraining script. If anything this should be an utility function. But I still worry about the reliability of filtering by "it", "chat" etc

If we have cases where we don't filter enough, I'd say no harm done.
However, I can see your concern. If we filter out models that are not instruction finetuned, that could be a problem. Let's maybe undo that then.


[$125] [Search v1.2] - Hold expense modal appears on the top left when expense is held in Search

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to DM.
Submit two expenses.
Go to Search.
Click on the submitted expense.
Click on the header > Hold.
Enter reason and save it.

Expected Result:
Hold expense modal will open as RHP.
Actual Result:
Hold expense modal appears on the top left when expense is held in Search.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/bcaf246b-fb4c-40f8-89da-d4f12bc4be8f

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021835782276333225172
Upwork Job ID:<PHONE_NUMBER>333225172
Last Price Increase: 2024-09-23

Issue OwnerCurrent Issue Owner: @rojiphil

@sakluger  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Hold expense modal appears on the top left when expense is held in Search.
What is the root cause of that problem?
In here we are passing down the prop shouldUseNarrowLayout, and in web screen, its value will be true when we are in RHP on the Search page logic here. As a result, it will show this popover instead of redirecting to the route PROCESS_MONEY_REQUEST_HOLD.
https://github.com/Expensify/App/blob/84793c85836be656255230985dc68e12e37d6268/src/components/MoneyReportHeader.tsx#L255-L262
What changes do you think we should make in order to solve the problem?

We should pass isSmallScreenWidth instead of shouldUseNarrowLayout in this case like we did here and here. And do the same  with MoneyRequestHeader
          <MoneyReportHeader
              report={report}
              policy={policy}
              transactionThreadReportID={transactionThreadReportID}
              reportActions={reportActions}
              shouldUseNarrowLayout={isSmallScreenWidth}
              onBackButtonPress={onBackButtonPress}
          />

https://github.com/Expensify/App/blob/84793c85836be656255230985dc68e12e37d6268/src/hooks/useResponsiveLayout/index.ts#L68
What alternative solutions did you explore? (Optional)
NA
https://github.com/user-attachments/assets/2f365f40-ad45-4d92-a88f-a286b77eb5c6

This feels like a fairly minor issue and change, so I will set the price at $125. Feel free to leave a note if you disagree.

@luacmartins will you be fixing this one yourself? If so, we can remove the help wanted and external labels.

Thanks for the proposals.
@Krishna2323 I have a couple of questions for you:

We also need to update the shouldUseNarrowLayout in the useEffect in both components.

What code changes are you suggesting here and what would be the benefit of making these changes?

•	In MoneyReportHeader & MoneyRequestHeader we should get isSmallScreenWidth from useResponsiveLayout hook and use that instead of shouldUseNarrowLayout.

passing isSmallScreenWidth to shouldUseNarrowLayout will cause issues as it is being also used for showing back button and money request buttons according to the IOU report layout size.

Both the above statements seem to contradict to each other. Are you not suggesting to pass isSmallScreenWidth to shouldUseNarrowLayout?

@Krishna2323

instead we should get isSmallScreenWidth from useResponsiveLayout hook directly in MoneyReportHeader&MoneyRequestHeader ` and use that to show the modal.

Hmm.. Isn’t this what @nkdengineer proposed earlier?

You can check this PR, I think the author of the PR mistakenly replaced isSmallScreenWidth  with shouldUseNarrowLayout . We should also look for similar cases in these changed files.

Ah! I see. So, you are referring to replacing shouldUseNarrowLayout with isSmallScreenWidth. But what additional value does it bring since the proposal already includes assigning isSmallScreenWidth to shouldUseNarrowLayout?

Thanks. I get what you are saying now. I also think it is better to use isSmallScreenWidth from useResponsiveLayout hook directly in MoneyReportHeader & MoneyRequestHeader and fix the navigation issue here.
@Krishna2323 proposal LGTM.
🎀👀🎀 C+ reviewed

@Krishna2323 do you have a PR for this one yet?

Bump @Krishna2323.

this issue has been fixed in this PR

Oh! Then, let's close this issue and move on. cc @sakluger


[e2e]: go release main config-ldflags-assets slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v16.0.25
Run: https://github.com/slsa-framework/example-package/actions/runs/2573747164
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Trigger: release
Branch: v16.0.25
Date: Tue Jun 28 04:37:26 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v16.0.26
Run: https://github.com/slsa-framework/example-package/actions/runs/2580712497
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Trigger: release
Branch: v16.0.26
Date: Wed Jun 29 04:40:42 UTC 2022
Tests are passing now. Closing this issue.


exporting path using ~ might not work on certain systems

Hey there, thanks for this awesome tool, I struggled setting up the symbolic link and exporting my path using
'export PATH=~/bin:$PATH'
instead I had to use $HOME/bin
just my two cents.

I agree using ${HOME} is more portable and not dependent on the shell functionality.
Will change this in my fork at https://github.com/maddes-b/ssh-ident

I agree using ${HOME} is more portable and not dependent on the shell functionality.
Will change this in my fork at https://github.com/maddes-b/ssh-ident

It's been a while :)

It's been a while :)

Fork moved to https://github.com/ssh-ident/ssh-ident1


Restyle logo width to make translations easier

Currently, the width of the logo is fixed at calc(100% / 6) so that the nav links are flush with the search bar:

Unfortunately, this leads to cut-offs in some translations with longer words in the nav bar:

We're currently solving this by just adjusting the width of the logo, but it would be nice to have a solution that doesn't require hard-coding the logo width (e.g. just making the nav bar flush against the search bar)
I'll probably fix it myself when I have time but I figured I'd put this up here in case anyone wants to take a look.

Hi, I would be interested in taking a look at this issue. Thanks!

Added PR #1860 for review, thank you!

same issues repo vi.reactjs.org
Text current

After translate to vietnamese

@tesseralis @tuantvk
Hello, I would like to work on this issue. This will be my first contribution to oss.
@kevjin
You have worked on this issue before, would you mind if I took over?

Thank you. I try it!

is this issue resolved i ? I would like to work on this issue

is this issue resolved ? . Can i please know the status of the issue so that i can take over it?

Please note that we're going to replace this site with https://beta.reactjs.org/ soon so we don't really plan to make changes to the old one.


Simplify build setup

Ideally we want to run this as one step - probably a Python script to generate context, tasks, and build with webpack.
Then a separate script to deploy (calling all pbs commands)?

:+1:


Upgrade sinatra_auth_github to v2.0.0

This allows us to use Sinatra v2.0.
https://github.com/atmos/sinatra_auth_github/compare/v1.2.0...v2.0.0
The driving reason is that Sinatra 1.x depends on Rack 1.x and Rack 1.x has unpatched CVE's.

@benbalter If you wouldn't mind taking a look at this when you have time. Thank you! ❤

CI failures appear unrelated. I think it's just because this repo hasn't been touched in a while.


Update grid behavior

Synchronize the grid implementation with the Design. See the grid analysis issue for details and the history of the discussion.
Design: https://www.figma.com/file/ojCcgC5Zd12eUSzq6V5m24/Foundations?t=S9MdGWrTM9E4Kyob-0
Gutter width comparison

Viewport
Design
Implementation1

XXS (<400)
Gutter: 12  Margin: 12
Gutter: 30  Margin: 12

XS (400-600)
Gutter: 12  Margin: 16
Gutter: 30  Margin: 16

S (600-800)
Gutter: 16  Margin: 32
Gutter: 30  Margin: 32

M (800-1024)
Gutter: 16  Margin: 32
Gutter: 30  Margin: 32

L (1024-1280)
Gutter: 16  Margin: 40
Gutter: 30  Margin: 40

XL (>1280)
Gutter: 16  Margin: 0  Fixed column width of 84
Gutter: 30  Margin: 128  Container max width: 1440

### Tasks
- [ ] Make gutter widths responsive and update values

Discuss with Design again, when going from 1023 to 1024 content shrinks as well. Could we use vw padding?

Final adjunstments

Element
Property
XS
SM
RG
MD
LG
XL
XXL

.container
padding-inline
12px
16px
16px
32px
32px
40px
120px

.container-fluid
padding-inline
12px
16px
16px
32px
32px
32px
32px

.row / .col
gutter
12px
16px
16px
16px
16px
16px
16px


Support for iOS SDK V5

Hi @danielsGit
Thanks for this amazing library and I loved to use that.
Please update the repo to support iOS SDK v5.
Here are the changes I did to make it work with iOS SDK v5.1.

Thanks.

Hello @n-nitchevski. Actually I have no time to maintain this library and if you can create a PR with your changes, I will try to merge it with master.
Thanks

Hi @danielsGit
I hope you are safe.
Could you please update your library so that it is compatible with iOS 13 & Xcode 11?
I can't build the app with your current module because it is not working with iOS 13.
I hope to do it myself but I'm not familiar with native Objective C and Java.
Please let me know if you have a plan to update this library.
Kind Regards,
Georgi

Hello @g-malinov . Thanks for using my library.
But actually I am no longer maintain this library and I don't have a plan to update this library.
Sorry.


Microsoft.VisualStudio.2022.Professional.Preview version 17.7.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @edwardskrod,
This package installed normally but errored when launched:

Activation context generation failed for "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\devenv.exe". Dependent Assembly Automation,processorArchitecture="*",type="win32",version="<IP_ADDRESS>" could not be found. Please use sxstrace.exe for detailed diagnosis.

Hi @edwardskrod,
This package installed normally but errored when launched:

Activation context generation failed for "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\devenv.exe". Dependent Assembly Automation,processorArchitecture="*",type="win32",version="<IP_ADDRESS>" could not be found. Please use sxstrace.exe for detailed diagnosis.

This error is apparently unique to the Manual Validation pipeline.


Add files via upload

Profile not showing in preview. I believe it is because file name should be _index.md not _index.txt.

Fixed and PR from another branch.


chore: bdd-spring-1580821947 to 0.0.1

chore: Promote bdd-spring-1580821947 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Is there a guide for modal interface?

I've started to create a modal windows - inventory, dialogue - and I'm creating a separate game state for each.
I guess this is not the best design, because even with a simple UI there will be a lot of modal windows.
Is there an official perspective - how to best handle a modal windows? Maybe a recommended UI library?

I haven't written a guide for that. There's a primitive modal window (no inputs) in my upcoming 7-day roguelike tutorial - in this section. That covers putting up a basic message box that triggers a game state change. It's not very flexible, but it's all I needed for that particular game.
There isn't really a good bracket-lib friendly UI library to help with that yet. I've actually started on one, but haven't had much time between the book release and the day job. I've been using egui and imgui in a few projects that take direct control over the render pipeline - they work really well, but the mismatch between text-mode and the UI library would be pretty jarring.
For handling modal states, you can improve on the enum system a bit with a state stack. Basically, you define a trait to be implemented by game states rather than a big enum. For example (I haven't tested this code):
pub trait GameMode {
    fn on_tick() -> StateTransition;
}

StateTransition defines the places to which a state can go. You could also have the state handle it, but that gets messy fast - especially with the borrow checker.
Then you have a state manager that holds a structure of Box<dyn GameMode> - probably a deque for quick push/pop. When the game starts, you'd push a starting menu state onto the stack. Begin play, push a playing state. Pop up a window? Push that state. Then each tick runs on_tick of the current top-most stack entry, and responds to any transition requests (they could be as simple as "close window" or complex as you need). If a state exits - closing the window - you can pop the old state off of the stack and be right where you were before. A lot of the time, you'll find the trait offers things like "on_init" and "on_exit" for any tearup/cleanup that needs to be done on transition.
Hope that helps!

Got it, thank you very much. Indeed, I also didn’t find an immediate mode UI that can draw into console, they prefer to have a surface.
Implementing a state stack didn’t occur to me for some reason. It sounds like the rift thing to do. I’ll do it, thanks!

@thebracket this is offtopic, but since you mentioned egui/imgui, can you share an example on integrating it with bracket lib? I would imagine it being helpful in debug build to display egui controls to control game state directly.


CXF-8885: Eliminate references to HttpClient via HTTPClientPolicy

There are additional potential references to the HttpClientFacade hidden in the property change listeners of HTTPClientPolicy. To prevent those from keeping the SelectorManager thread alive, we have store a copy of the policy with no listeners attached.

Closing in favor of https://github.com/apache/cxf/pull/1381


R U READY 4 ZE NEW TIDE ORDER

About the PR
tiders now have a hivemind radio
this can be used without a headset
Why / Balance

Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
:cl: Yakub, Starch

add: Tiders now have a intrinsic hivemind radio channel.


feat: print x/y progress to the stdout

What this PR does / why we need it:
print a counter to show progress while pushing images and embedded cluster artifacts to the registry. we want this output so we can show a better feedback to the user when installing a kots application on an embedded cluster instance.
output sample:
root@ec:~#  /var/lib/embedded-cluster/bin/kubectl-kots \
        install \
        embedded-cluster-smoke-test-staging-app/ci-airgap \
        --license-file ./license.yaml \
        --namespace kotsadm \
        --app-version-label appver-dev-7976976 \
        --exclude-admin-console \
        --airgap-bundle ./embedded-cluster-smoke-test-staging-app.airgap
  • Validating registry information ✓
  • Deploying application
Pushing image 1/1
Pushing image <IP_ADDRESS>:5000/embedded-cluster-smoke-test-staging-app/nginx:latest
Copying blob<PHONE_NUMBER>03 skipped: already exists
Copying blob c5cdd1ce752d skipped: already exists
Copying blob 8a1e25ce7c4f skipped: already exists
Copying blob 87c3fb37cbf2 skipped: already exists
Copying blob 39fc875bd2b2 skipped: already exists
Copying blob e78b137be355 skipped: already exists
Copying blob 33952c599532 skipped: already exists
Copying config 92b11f6764 done   |
Writing manifest to image destination
Pushing embedded cluster artifact 1/4
Pushing embedded cluster artifact 2/4
Pushing embedded cluster artifact 3/4
Pushing embedded cluster artifact 4/4
  • Waiting for Admin Console to be ready ✓
  • Uploading app archive
  • Waiting for installation to complete ✗
Error: failed to validate installation: license already exists for app embedded-cluster-smoke-test-staging-app
root@ec:~#

Which issue(s) this PR fixes:
Relates #102373
Does this PR introduce a user-facing change?
Add more feedback to the user while pushing Images and Embedded Cluster artifacts.

Proxying a comment from slack. Can we just show "Pushing Image 1/1" and update that line until all of the images are pushed, and then move on to showing "Pushing Embedded Cluster Artifact 1/4". The rest can be filtered, and of course it would be nice if we could put it back in the bullet point like the other lines.


Get error in ubuntu 18 and python 3.6

Traceback (most recent call last):   File "/home/fred/Github/game-dogfight/source/main.py", line 13, in <module>     import harfang as hg   File "/home/fred/.local/lib/python3.6/site-packages/harfang/__init__.py", line 1, in <module>     from .harfang import * ImportError: libpython3.5m.so.1.0: cannot open shared object file: No such file or directory
Is it only compatible python 3.5?

Have you solved it?

Hi, thanks for your interest!
Please note this project is not maintained anymore as it was replaced by a new version that can be found here:
https://github.com/harfang3d/dogfight-sandbox-hg2
If you have any question, feel free to contact us on<EMAIL_ADDRESS>


Add packages for providing stable interfaces

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
See https://github.com/orgs/autowarefoundation/discussions/3922.
Purpose
Clarify interfaces.
Provide a transition period for interfaces.
Possible approaches
Create a wrapper library for rclcpp/rclpy.

Use type adaption feature for rclcpp topics.
Create wrapper class for rclcpp services because type adaption is not implemented yet.
Create wrapper class for rclpy.

Definition of done

[ ] Add rclcpp wrapper library.
[ ] Add rclpy wrapper library.
[ ] Merge and remove component_interface_utils package.
[ ] Merge and remove tier4_api_utils package.

Hi @isamu-takagi, I am interested in this proposal as a third-party verification tool developer, which needs a well-defined interface specification for Autoware and simulators.
Would this proposal include a machine-readable declarative specification format for interfaces? Is there any pointer for any work done in that direction?
Do you prefer this issue for further discussion or the original discussion thread?

@doganulus Are you talking about a file listing topics and services such as following? If so, that is not the goal of this task. But I want that too, so let's create a new discussion.
{ type: subscription, name: /diagnostics }
{ type: publisher, name: /diagnostics_agg }

Yes @isamu-takagi, such a file is what I meant. I thought it may be used for a config for third-party tools that interact with Autoware. I have a few technical concerns, like how to address dynamic topic names and the overhead in this case. But maybe your proposal will allow us to see better the landscape.
Finally, in the current form, you do require a third-party client tool to use rclcpp to communicate with Autoware and get the benefits in this proposal? Can a DDS client based on corresponding IDLs be equally good or not?

Finally, in the current form, you do require a third-party client tool to use rclcpp to communicate with Autoware and get the benefits in this proposal?

@doganulus I've added a diagram about the implementation to this task description. As shown in the diagram, to use versioned message you need to use the wrapper class that will be added in this task.

Can a DDS client based on corresponding IDLs be equally good or not?

I don't think it can provide the same functionality. The problem is that ROS topics and services only have one layer of data structures. This means that when the data structure is changed due to implementation reasons, the interface is also affected. So at least two data structures are required: an implementation and an interface.
It may be possible if you can customize serialization and deserialization of DDS client, but it would be difficult.

I cannot say for sure without measuring but the overhead of all these conversions seems to be the weakest point of the proposal. Maybe your example implementation can give any hint on how serious it could be. Have you considered publishing twice for old and new interfaces? (this has the overhead of bandwidth but is limited to the transition period.)

@doganulus  I considered it again here https://github.com/orgs/autowarefoundation/discussions/3922#discussioncomment-8886781. In conclusion, it seems better to provide an accessor class. This method is simpler and does not require copying the message.
I will create a new discussion about interface definition files later.

@isamu-takagi Thank you very much for letting me know!
For interface definitions files, I have something in my mind similar to Zenoh's use of configuration files as here:
https://github.com/eclipse-zenoh/zenoh-plugin-dds/blob/2cd1424c1b15d1bf730b01c0c9110a3031dd5119/DEFAULT_CONFIG.json5#L44C1-L67C38
I like to configure our apps to listen to some specific subset of Autoware topics (possibly determined dynamically) so having stable interfaces is quite important.


buildlib: wait before re-submitting brew tasks

On immediate re-submit, brew seems to either do nothing and return success, or complain that the task is still open. Wait for it to get sorted out before re-submitting.

@adammhaile @tbielawa PTAL


Reduce default orbit inertia value

The old default (0.15) caused the freelook camera to drift for way too long when rotated (over a second before coming to a stop...) The new value (0.05) is a lot more sober.

cc @Zylann @toger5 @n-pigeon etc. :)

I'm ok with that, note that it's a shared setting across freelook and orbit though

@Zylann Yeah, it impacts all non-middle-mouse orbiting, such as switching between Top/Side/etc. views. In that case I think it's a change for the better, as it suffered from the same problem as freelook. The interpolation when switching between scene tabs got a little worse, but that's the only negative repercussion I've seen.
This isn't a perfect solution, but it seems to benefit everything but the inter-scene interpolation, which I've always been really skeptical about. I may have missed something though...

I'm also ok with this.


Comments: React Native, 2 years later

@alloy first mentioned React Native as an option for Artsy back in March 2015, and in February 2016 he made our first commit to get the ball rolling. Since then, we've grown a new codebase, Emission, which has slowly taken over the responsibility for creating the UIViewControllers presented inside our iOS app.
We've come quite far from where we started, and I was asked if I could give a talk to summerize what we've learned in the last 2 years as a set of native developers using React Native.

http://artsy.github.io/blog/2018/03/17/two-years-of-react-native/

@orta Thanks for the awesome talk. It's really cool to see an overview of the ups and downs of react native.
In the video you mention that there is no mobile team at Artsy anymore. I'm curious what that means for eidolon. Are there plans to introduce react native there as well? Additionally, something else I'm curious about is if there were any worries you had about introducing react native initially. You mention that for the most part you're just parsing json and showing the data in different ways, but are there any screens/features that do more than that? I suppose you always have the option of developing a particular screen in native code if need be, which may quell any worries.
Thanks again for the awesome talk!

In the video you mention that there is no mobile team at Artsy anymore. I'm curious what that means for eidolon.

For context, Eidolon is a medium-sized Swift app, which lets people bid at a live event. We used Eidolon to safely experiment with Swift while Swift was still in an early stage of its lifecycle. We also have a small Swift app called Emergence, which is our Apple TV app. On the non-Swift side, we also have Energy - a partner portfolio app.
All of these need to be maintained, ideally they all need to be running on the current major version of Xcode - so that if there needs to make a release, it will be pretty trivial. The responsibility for the maintenance and feature work used to live inside the mobile team - but now that team doesn't exist.
What happened is that each app was given to certain business groups inside Artsy. We aimed to spread the developers with mobile experience throughout the engineering org and that meant the knowledge would spread. Realistically though, today, only me or @ashfurrow can contribute to Eidolon without considerable on-boarding because of the RxSwift + Swift choice. So if something critical needs to happen, one of us are the ones to do that. We can make time without our respective teams to make that work.
The same thing for Energy where I've not actually needed to do serious work in a year (though one day this'll be ready)
We all are a part of a front-end group in Artsy where we can try to handle some of the more meta issues (deployment, consistency etc) which we share with web devs, but there's also a smaller iOS-front-end that is basically the old mobile team in a slack new channel - but without reporting structure or product management etc.

Are there plans to introduce react native there as well?

For all of these projects, we have little to no plans to add React Native. React Native fits amazingly with an API driven app. The tvOS app side (which is "done") the rest of our Apps are not this. Most of the complexity in Eidolon is around what screen to show when, and we use storyboards a lot as screens are not dynamic. Energy is a "sync once, use offline" experience. Nearly all of our focus is on the main Artsy app, Eigen, where its usually about building the little web-pages inside the app - where React Native excels.

are there any screens/features that do more than that?

Yep, I have spent most of my time in our React Native components building out things that are not pretty JSON parsers, the consignments submission process being the biggest. I think there's a trade-off of complexity here, some of these screens became quite extensive and for me the decision to use React Native for the feature was about whether it would be re-used on android someday, or could I start by copy & pasting from the web. I felt like it would be useful on android, so we went with it. It's not as perfect a fit as an JSON->UI screen, but it was still a pretty 👍 experience.
After that I worked on AR for Artsy, using ARKit, which I skipped React Native completely - it's quite far from what I think React Native is good for. It was also quite an exploratory project so potentially needing to build a middle layer for ARKit and RN wasn't something I was interested in doing.
Falling back to native was easy in cases like this, we didn't de-skill ourselves, just gave new options to build the things we do out of the time better.

@orta Thanks for your talk. Really interesting 🥇
I've spent some time inspecting the codebase of both Eigen and Emission. I need some time to digest it since it's involves a lot of configuration. Do you have a sort of starter template? I'm working on a personal project and I would like to experiment your same approach.
That said, I would like to ask your opinion about React Native and its usage in business projects. As you explained in the talk, you've followed a brownfield approach. The app skeleton is native and, on top of it, you've started to integrate RN components (I like the clean separation between Emission and Eigen). This approach allows you to reuse UI elements and business logic (especially if you have also an Android app). A different approach is to use RN as a whole. Maybe you can also take advantage of Redux in order manage the state of the app.
Between the two I would prefer the former approach (I'm a iOS developer ;)). Even if the second approach can bring advantages in the short term, I think it has a lot of drawbacks, like:

Taking advantage of availability of specific API available in the native world
Impossibility to refactor / re-engineer a code developed only in RN if something goes wrong
Maintainability of native modules due to API changes
Be unaware of the internal behavior of the framework (it could requires some time to digest it)
Spend time to add animations, sticky behavior or complex layout
Managing several dependencies (the ones included in RN and the ones imported in order to integrate modules not included already, e.g. push notifications, WKWebView, etc.)

What's your opinion?
Thanks, Lorenzo

I don't have a starter template, I have this post where you can do the entire thing by hand though.
I think you need to use native code to make React Native apps without compromising on quality. If you're willing to compromise on design or feel of an app then going 100% JS can work fine. Using create-react-native-app you can iterate faster, deploy easier and rely on JS dependencies instead of native one. That's fine for many projects. It's not really something I really see Artsy, or myself doing though.

@orta Thank you for the useful info ;)

This talk along with all of your other resources for React Native and Javascript have bene really helpful for my team at vibemap.com. Thanks so much!


Split at Word

Able to split at word in block mode.  Can only enter simple split although formatting will recognize indented split.

Add ability to add indented split


Ability to add attachments by filename and content

BACKGROUND:
Currently the library supports attachments with filePaths only. We should have ability to add attachments if we have filename and its content.
APPROACH:

Add a property "attachmentsByContent" in Email instance
Add function addAttachmentsByContent which accepts fileName, content and cid (optional)
Retrieve added attachments and adjust function toWebFormat accordingly to support the http request

USAGES Example:
$Email = new Email();
<EMAIL_ADDRESS>->Text('Test text')
->Attach('hello.text','Hello, this text will be written to file hello.txt and that will be an attachment of this email')))

Hi @pankaj-garg,
Thanks for the pull request!
We have revamped attachments in the new version of our Mail Send endpoint and in our library, check it out: https://github.com/sendgrid/sendgrid-php/blob/v3beta/examples/helpers/mail/example.php#L83
With Best Regards,
Elmer


Rainfall today does not much web interface

Home Assistant Version?
2023.8.4
Add-On or Self Hosted?
Self managed Container
Weatherflow2MQTT version?
3.2
What happened?
The rainfall totals do not seem to match the web interface.  I wonder if these is a problem with the conversion from metric to imperial? I have everything set to imperial
From web interface

From MQTT

What HA shows

Thank you
Relevant log output
No response

I believe the discrepancy is due to the "raincheck" implementation. https://community.weatherflow.com/t/introducing-raincheck/3699

@mccabery I don't believe that is the case.  This is not related to the average but the accumulated for the current day.
It sounds like raincheck is focused on the previous day.
"We’re launching “RainCheck” starting with all owners in the Continental USA. Every day, between midnight and 8am (depending on weather conditions),"

@mccabery Thanks - I turned it off just to see if that corrects for the next storm.
The question is wouldn't this interface still pull the updated numbers so that what is pulled would match the web interface?

The thing is, that the UDP API, only reports the Rain amount over previous minute. So this integration has to summarize this and then reset again when hitting midnight. If you restart, for some reason during the day, the counter may get reset too, and the numbers in the WeatherFlow database might not fit with the numbers here.
All data coming from the UDP API are in Metric format, so a conversion has to take place, but this should not create that discrepancy.

Sounds like this is just something we have to live with if we want a truly local interface?

Yes unfortunately. I live in Europe, so we don't have the NearCast option, so it is also hard to test. Anyway, as you said, if you want a truly local system, this is how it is.
I will close this now.


Support branch is a snapshot version

Branch support/0.3 has version 0.4.0-SNAPSHOT and as such it depends on divolte-schema 0.4.0-SNAPSHOT. Because snapshot versions are not on mvn central it is not possible to install divolte-collector.
I would expect that the 0.3 branch has version 0.3 and would depend on divolte-schema 0.3.

Downloading the release does work, but then I don't have it in a git repo.

The support/0.3 branch is supposed to have 0.3.1-SNAPSHOT as version, as that is the next release version if we release from the support branch (the support branch is for back porting fixes against master into older releases; it's a bug fix branch). So the 0.4-SNAPSHOT was wrong. It's fixed now.
A SNAPSHOT version of Divolte never builds from source without first building and locally installing (as in mvn install) the schema, since we don't publish snapshot releases to Maven central. To get a working build from source either first mvn clean install the matching schema version or use a release source version (you can obtain one from checking out a release tag).

:+1:


Feat/nested params

This PR adds support for nested parameters
TODO list:

[x] Support validation of nested parameters
[ ] Update the help message to show nested parameters
[ ] Update the params summary map to show nested parameters

The help message will look like this now:
Input/output options
  --input                      [string]  Path to comma-separated file containing information about the samples in the experiment.
  --nested                     [string]  Path to comma-separated file containing information about the samples in the experiment.
  --no_header                  [string]  Path to comma-separated file containing information about the samples in the experiment.
  --outdir                     [string]  The output directory where the results will be saved. You have to use absolute paths to storage on Cloud infrastructure.
  --email                      [string]  Email address for completion summary.
  --multiqc_title              [string]  MultiQC report title. Printed as page header, used for filename if not otherwise specified.
  --nested_params              [object]  This is a nested parameter (This parameter has sub-parameters. Use '--help nested_params' to see all sub-parameters)

The help message will look like this when you give the --help nested_params option in this case:
--nested_params
    description: This is a nested parameter
    options    :
      .deep         [object]  This a very deep an thorough description (This parameter has sub-parameters. Use '--help nested_params.deep' to see all sub-parameters)
      .bye          [string]  This is goodbye

You can go as deep as you want. e.g. --help nested_params.deep will show the help message from that nested parameter:
--nested_params.deep
    description: This a very deep an thorough description
    options    :
      .hello        [string]  hi
      .bool         [boolean] boolean value


[stable/fluent-bit] add ignore_older and time_key options, fix parsers.conf handling

What this PR does / why we need it:
This PR adds 2 config options of fluent-bit and makes it possible to set them in the chart.
It also will fix the parser.conf handling. The file is currently added in the configmap, but never mounted in the container, i discovered this while testing the 2 new options.
@kfox1111 @edsiper

@kfox1111 I am not sure if adding Yaml support to Fluent Bit is the right thing to make easier the configuration in a Helm chart...


make check fails on alpine edge

Please provide as much of the following information as you can, as applicable to the issue being reported.  Naturally, not all information is relevant to every issue, but the more information we have to start, the better!

Environment Information
docker 1.13.0
alpine edge (~2018-08-08)
hdf5 (from alpine repository)
netcdf-c-4.6.1 (from source)

Feel free to skip this if the issue is related to documentation, a feature request, or general discussion.

What platform are you using? (please provide specific distribution/version in summary)

[X] Linux
[ ] Windows
[ ] OSX
[ ] Other
[ ] NA

32 and/or 64 bit?

[ ] 32-bit
[X] 64-bit

What build system are you using?

[X] autotools (configure)
[ ] cmake

Can you provide a sample netCDF file or C code to recreate the issue?

[ ] Yes (please attach to this issue, thank you!)
[X] No
[ ] Not at this time

Summary of Issue
"make check" reports several test failures due to not finding /bin/bash, alpine uses busybox with /bin/sh only.
Steps to reproduce the behavior
Create a Dockerfile:
FROM alpine:edge
RUN apk [install hdf5]
RUN wget [the netcdf-c library]
RUN tar -zxvf [the netcdf-c library]
WORKDIR [the dir]
RUN ./configure
RUN make && make check
docker build .
(EDIT: added configure step and hdf5 info)

Unfortunately, using 'sh' is unreliable across other platforms (including OSX), as the 'sh' shell isn't guaranteed to contain the functionality the scripts use, but bash (to date) is.  Is it possible to install bash in alpine linux?

According to autotools practice, we should be using only sh and not bash.
There should be nothing that we can do in bash that cannot be done in sh.

When I find/replace 'bash' with 'sh' before the make check, at least some of the tests passed, something like this:
find . -name "tst*sh" -exec sed -i 's/bash/sh/g' "{}" \+
For example the tests in ncdump will pass under alpine after replacement.

Agree that an easy workaround is to install bash in alpine. Also understand that if the find/replace above causes tests to fail on OSX then this suggestion can be closed.

I think there are two issues. The automake tools and ./configure restrict themselves
to sh. But I think our test cases long ago gave up and use bash features (functions?).
So, I think having bash is the proper thing for our tests.

I am a little skeptical that the tests truly depend on bash. Again, many of the tests pass when I do a find of "bash" and replace with "sh".

I thing I do not know is: does sh have functions,, or is that bash only?

Also remember that on many systems sh is a hard/soft link to bash.

I’ll give it a test so that I can at least be specific about the failure we saw. I’m more than happy to switch to sh if workarounds are identified :)

Ok, I had conflated this with a similar issue we saw on OSX, the issue here was Ubuntu.  I've made some changes which should address make check on Alpine linux.  I'll test this, and see about working Alpine into our CI rotation.  Thanks for bringing this to our attention!


Clickable tags

At the moment tags are not clickable, it would be good to have them list rants with those tags.

@tahnik Also, clicking on the comments icon should open the comments page

@DRSDavidSoft Might be an idea to make a separate issue for that.

@nblackburn You're right, #137 seems to fix the clicking on comments icon issue.
I might work on #116 to make clickable tags working, though I first should study RantScript by @RekkyRek.


Feat/editor component comment write

can upload file in comment-form at page

now, css for dropzone don't appear when file drag & drop


Mark as read as you scroll the list

This is not a bug, it is a new feature request for iOS/iPadOS, is it possible to have an option to Mark as Read while you scroll the list? To have in iOS and iPadOS the same behavior as in macOS
Sometimes I scroll through some of them, if  leave the app and come back , I will have to scroll through all of them again, the ones I already read.
The app Newsify has this capability, but I want to move to NetNewsReader, thanks

Duplicate of #1844


libopenaptx: 0.1.0 → 0.2.0

Motivation for this change
https://github.com/pali/libopenaptx/releases/tag/0.2.0
Will be used by upcoming pipewire release.
cc @orivej @gebner @jansol
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 105866 run on x86_64-linux 1

2 packages built:

libopenaptx
pulseaudio-hsphfpd

Result of nixpkgs-review pr 105866 run on x86_64-darwin 1

1 package marked as broken and skipped:

pulseaudio-hsphfpd


size_ < capacity_' failed. error trying to install chromium package

Describe the bug
Trying to run nix-env --install chromium in an Ubuntu 20.04 docker container, we get the error nix-env: src/libexpr/attr-set.hh:54: void nix::Bindings::push_back(const nix::Attr&): Assertion size_ < capacity_' failed.`
To Reproduce
Steps to reproduce the behavior:

Create a Dockerfile like this:

FROM ubuntu:20.04

ENV USER=cukebot
ENV UID=1000
ENV GID=2000

RUN addgroup --gid "$GID" "$USER" \
    && adduser \
    --disabled-password \
    --gecos "" \
    --ingroup "$USER" \
    --uid "$UID" \
    --shell /bin/bash \
    "$USER"

RUN mkdir /nix && chown -R $USER /nix

USER $USER

RUN (curl -L https://nixos.org/nix/install | sh)
RUN . /home/$USER/.nix-profile/etc/profile.d/nix.sh && nix-env --install chromium
RUN cp ~/.nix-profile/bin/chromium-browser /usr/bin/

Try to build the container with docker build .

Expected behavior
Chromium installs
Additional context
I'm sure this has worked at some point, but it's stopped working.
Notify maintainers

Metadata

system: "aarch64-linux"
host os: Linux 5.10.25-linuxkit, Ubuntu, 20.04.2 LTS (Focal Fossa)
multi-user?: no
sandbox: no
version: nix-env (Nix) 2.3.10
channels(cukebot): "nixpkgs-21.05pre288317.357e6b3560f"
nixpkgs: /home/cukebot/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

hitting this after upgrading to NixOS 21.05

installing 'chromium-91.0.4472.101'
nix-env: src/libexpr/attr-set.hh:54: void nix::Bindings::push_back(const nix::Attr&): Assertion `size_ < capacity_' failed.
Aborted (core dumped)

nix-env update helped though :thinking:

replacing old 'nix-2.3.6'
installing 'nix-2.3.12'


[fix] ss-preview-part in head tag

Coverage decreased (-3.5%) to 81.174% when pulling bda69b32b0b4eec7218a9bbe3534a48cc1188a13 on ShinjiTanimoto:part into d89912b6b11d83cd12ddc78fb771da19b22b0289 on shirasagi:master.


Couple of Things

Ability to use YAML Configs
Fixed browser reset issues
Removed hard-coded Jira config, now passed in via param

Closing due to missed version bump and example config updates.


Docker related paths are incorrect on Windows environments

Hi!
I noticed that docker paths resolved by the environment plugin are incorrect on Windows. They are not converted from Windows to POSIX style. I use Docker Desktop <IP_ADDRESS>.
In my case the issue leads to AEM Multi-Project Example setup failure. The template from docker-compose.yml.peb file:
    volumes:
      - "{{ environment.dockerRootPath }}/distributions/mod_dispatcher.so:/usr/local/apache2/modules/mod_dispatcher.so"
      - "{{ environment.dockerRootPath }}/httpd/cache:/opt/aem/dispatcher/cache"
      - "{{ environment.dockerRootPath }}/httpd/logs:/usr/local/apache2/logs"
      - "{{ environment.dockerConfigPath }}/httpd/conf:/usr/local/apache2/conf"

Gets resolved to:
    volumes:
      - "C:\testwindows\aem\.environment/distributions/mod_dispatcher.so:/usr/local/apache2/modules/mod_dispatcher.so"
      - "C:\testwindows\aem\.environment/httpd/cache:/opt/aem/dispatcher/cache"
      - "C:\testwindows\aem\.environment/httpd/logs:/usr/local/apache2/logs"
      - "C:\testwindows\aem\gradle\environment/httpd/conf:/usr/local/apache2/conf"

Which causes "unknown escape character" error while running docker compose.
I think the problem might be caused by me using Docker Desktop instead of Docker Toolbox. It looks like Win to POSIX conversion is happening only for Docker Toolbox (code).

Thx for reporting this. Will be fixed probably tomorrow or within next few days.
Greetings

ready to review: https://github.com/Cognifide/gradle-aem-plugin/pull/402

Released in 7.0.4


Dependabot does not scan for versions in versions.properties

Is your feature request related to a problem? Please describe.
Coming from: https://github.com/opensearch-project/OpenSearch/pull/3772#issuecomment-1175484840
Dependabot does a great job of automatically upgrading dependent libraries while checking CVE databases.
For OpenSearch we use versions.properties[1] as a version catalog for all gradle projects within the repository.
Dependabot workflow does not support scanning through this catalog file of versions.
Describe the solution you'd like
Dependabot support for dependencies listed in versions.properties.
[1] https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/version.properties

Related discussions:

https://github.com/dependabot/dependabot-core/issues/1618
https://github.com/dependabot/dependabot-core/issues/1164


Script to figure out limits

This script is used to find the limits required by the window service

Can we make this a scenario that we run officially (kind of like a unit test) rather than a one-off script?

Sure, I could look into that. Fox now, since @yifanmai  needs this (I think) to fix the canary runs. Should we keep it as a script and then I could make it into a scenario in a different PR?

This can't be a scenario because scenarios cannot access the tokenizer. synthetic_efficiency has the same issue; we have to manually generate a static file for each tokenizer.


Support secrets for plugin configuration

What this PR does / why we need it:
Add a configFrom field to KongPlugin and KongClusterPlugin. This contains a secretKeyRef (and namespace, for KongClusterPlugin) pointing to a secret key containing a JSON or YAML plugin configuration.
Plugins that either reference an invalid secret/key, reference a key that does not contain JSON or YAML, or contain both config and configFrom are rejected.
Special notes for your reviewer:
Rebased to a single commit since our discussion on the WIP. For reference, the type split is handled with https://github.com/Kong/kubernetes-ingress-controller/compare/next...feat/plugin-conf-secret?expand=1#diff-b1c61ff32890f6c8189e0ff5be6e4cc8R1665-R1689 and the YAML/JSON dual support is at https://github.com/Kong/kubernetes-ingress-controller/compare/next...feat/plugin-conf-secret?expand=1#diff-b1c61ff32890f6c8189e0ff5be6e4cc8R1677-R1682

Force push after PR was to fix a vet issue. Originally:
internal/ingress/controller/parser/parser.go:1687:19: github.com/kong/kubernetes-ingress-controller/internal/apis/configuration/v1.SecretValueFromSource composite literal uses unkeyed fields

Not sure why that's not caught by my editor's vet on save, but whatever.

Big mess of things to squash since there were a lot of requests to keep track of and mark done.
Should be all complete other than the requests that require a new type. Merge conflict is quite thorny in the test, so leaving that for the end.

Something weird happened and 8a439d59787e3921c9c67551d6eb9b33ae50c6ac is somehow here despite being something from a badly-done merge that I reverted to an earlier point in the reflog. Not sure how it got pushed as it's no longer in local history, but end result looks the same as the clean merge, so whatever, it'll get squashed anyway.

I cannot comment on https://github.com/Kong/kubernetes-ingress-controller/pull/618#discussion_r418637971 for some reason, but I think this should remain as is: we don't necessarily have a namespaced value and always have to obtain the namepsace from somewhere.
In the case of a KongPlugin, we have a SecretValueFromSource and the  namespace of the plugin itself. In the case of a KongClusterPlugin, we have a NamespacedSecretValueFromSource, and use namespacedSecretToConfiguration() to extract its namespace, create a SecretValueFromSource from the rest, return the result of secretToConfiguration().
This could be flipped around, such that we instead construct a NamespacedSecretValueFromSource from a KongPlugin, but I don't think that makes any meaningful difference--we still have one type we can pass directly and one that we have to transform.

This is hopefully good to go code-wise, but I'd still like to do a last manual practical test to confirm that I haven't missed something that testing doesn't cover properly, since this has changed quite a bit since my initial check.

Manual test run, everything looks good there.


flashmq: 1.8.4 → 1.9.1

Description of changes
https://github.com/halfgaar/FlashMQ/compare/v1.8.4...v1.9.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 288594 run on x86_64-linux 1

1 package built:

flashmq


s3:GetObject policy applied on bucket level

I have see a policy from line 730, I don't understand why it works.
{
    "Effect": "Allow",
    "Action": [
        "s3:GetObject",
        "s3:PutObject",
        "s3:ListBucket"
    ],
    "Resource": [
        "arn:aws:s3:::*"
    ]
}

I see from the policy, the s3:GetObject and s3:PutObject apply on resource arn:aws:s3:::*. These two actions apply on the object level, not bucket level. Thus, I think it should be
{
    "Effect": "Allow",
    "Action": [
        "s3:ListBucket"
    ],
    "Resource": [
        "arn:aws:s3:::*"
    ]
},
{
    "Effect": "Allow",
    "Action": [
        "s3:GetObject",
        "s3:PutObject"
    ],
    "Resource": [
        "arn:aws:s3:::*/*"
    ]
}

However, the template does works.

@JoeShi You can refer to Amazon S3 Resources document Wildcards section.


Javet 2.1.1 crashes on closing the runtime

I see in the changelog that javet no longer stores callback contexts in the global reference table since 2.1.1, which is good, I was having trouble with excessive references.
But the latest version of javet will JNI crash the app if you bind a JavetCallbackContext when the close() method of the V8Runtime gets invoked:
A/ample.javettest: runtime.cc:689] JNI DETECTED ERROR IN APPLICATION: JNI ERROR (app bug): jobject is an invalid JNI transition frame reference or invalid reference: 0x7589859eb0 (use of invalid jobject)

Here is sample code that reproduces this:
package com.example.javettest;

import android.os.Bundle;
import android.widget.TextView;

import androidx.annotation.Nullable;
import androidx.appcompat.app.AppCompatActivity;

import com.caoccao.javet.interop.V8Host;
import com.caoccao.javet.interop.V8Runtime;
import com.caoccao.javet.interop.callback.JavetCallbackContext;
import com.caoccao.javet.interop.executors.IV8Executor;
import com.caoccao.javet.values.reference.V8ValueGlobalObject;

public class ActivityTest extends AppCompatActivity {

    private TextView vText;

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_layout);
        vText = findViewById(R.id.script_result);
        try (V8Runtime v8Runtime = V8Host.getV8Instance().createV8Runtime()) {
            V8ValueGlobalObject globalObject = v8Runtime.getGlobalObject();
            globalObject.bindFunction("aaa", new JavetCallbackContext(this, getClass().getMethod("hello")));
            IV8Executor executor = v8Runtime.getExecutor("'Hello Javet'");
            String sResult = executor.executeString();
            vText.setText(sResult);
        } catch (Exception ex) {
            ex.printStackTrace();
        }
    }

    public void hello() {
        if (vText == null) {
            return;
        }
        vText.post(new Runnable() {
            @Override
            public void run() {
                vText.setText("world");
            }
        });
    }
}

I believe the problem lies around here, in V8Runtime.java:
/**
 * Remove callback contexts.
 *
 * @since 0.8.3
 */
void removeCallbackContexts() {
    synchronized (callbackContextLock) {
        if (!callbackContextMap.isEmpty()) {
            final int callbackContextCount = callbackContextMap.size();
            for (long handle : callbackContextMap.keySet()) {
                removeJNIGlobalRef(handle);
            }
            logger.logWarn("{0} V8 callback context object(s) not recycled.",
                    Integer.toString(callbackContextCount));
            callbackContextMap.clear();
        }
    }
}

Update: Yes, that is a bug which is muted on PC but causes crash on Android. It's fixed by this commit. Please wait for the next release. Thank you.

Thank you for your efforts. JNI is definitely way more strict in Android.
The log message warning there makes me wonder. Am I supposed to release/free those callbacks in some other way?

There is a workaround. Remove that function and call GC before closing the runtime.


WSL enabled but not visible, cannot install Ubuntu

Windows 10 Enterprise
Windows build number:
Build 19042.685
Your Distribution version:
Version 20H2
Whether the issue is on WSL 2 and/or WSL 1: [run cat /proc/version in WSL]
WSL 1
Enabled WSL 1 by running the following command in PowerShell 64 (run as Admin):
     dism.exe /online /enable-feature /featurename:Microsoft-Windows-Subsystem-Linux /all /norestart

Then rebooted device.
After reboot, get the following results from PowerShell 64 (run as Admin):

-- Get-WindowsOptionalFeature command shows Microsoft-Windows-Subsystem-Linux as enabled.
-- wsl -l -v command returns "wsl: The term 'wsl' is not recognized as the name of a cmdlet, function, ..."
I have disabled WSL 1 via PowerShell 64 and rebooted, then reinstalled & rebooted.  Same result.
I have turned Windows Subsystem for Linux off via Programs and Features/Turn Windows features on/off followed by reboot, then turned on again via same method followed by reboot.  Same result as above (enabled, not recognized).
When I attempt to install Ubuntu in this state, Ubuntu returns:
"WslRegisterDistribution failed with error: 0x8007019e

The Windows Subsystem for Linux optional component is not enabled.  Please enable it and try again."
wsl_1_ubuntu_fail.zip
Expected behavior:
Expect WSL 1 enabled and recognized by system; allow Ubuntu install.
According to Microsoft WSL docs, should be able to enable WSL 1 feature & install Ubuntu.
Actual behavior
WSL 1 is enabled but not recognized by PowerShell or Ubuntu for install.

After reboot, get the following results from PowerShell 64 (run as Admin):

From a non-admin CMD prompt (sic) what is the output of where wsl (like this):

After reboot, get the following results from PowerShell 64 (run as Admin):

From a non-admin CMD prompt (sic) what is the output of where wsl (like this):

Try to run in-place upgrade first with lastest iso
https://www.tenforums.com/tutorials/16397-repair-install-windows-10-place-upgrade.html
That should help.

Also have this problem, tried reinstalling - no luck.

Running in Windows 10 Pro 19043.1023 (21H1), I was able to run wsl distros after running cd C:\Windows\System32 and calling WSL.exe as a locally available executable (.\wsl.exe) from Powershell 7.1.3 while running as Administrator.
This was tested with WSL2 and Ubuntu 20.10, however trying to invoke the command by itself (wsl --foo -bar) from anywhere else still seems to fail, leading me to believe it might be a PATH-related issue. I'm not quite sure which logs would be needed to confirm this, so if anyone knows let me know and I'll send them this way.
PS C:\Users\ToasterDEV> wsl
wsl: The term 'wsl' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
PS C:\Users\ToasterDEV> where wsl
PS C:\Users\ToasterDEV> cd C:\Windows\System32
PS C:\Windows\System32> .\wsl
Welcome to Ubuntu 20.10 (GNU/Linux 5.4.72-microsoft-standard-WSL2 x86_64)


Feat/rns mainnet

What

RIF Marketplace - Deployment to Mainnet information

Why

Once we deploy to the Mainnet the RNS Marketplace functionality we need to update the Testnet and Mainnet contract addresses, guides, and links.

DO NOT MERGE UNTIL CHANGES GET DEPLOYED TO MAINNET

Thanks @owans ! all recommendations implemented. This is ready to approve and Merge. Thanks!


KAFKA-17546: Admin.listGroups and kafka-groups.sh

This implements the kafka-groups.sh tool and Admin.listGroups method defined in KIP-1043.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

The failing test has just been marked as flaky: https://github.com/apache/kafka/pull/17649. I suspect an intermittent problem in a recently merged PR and we are working on a fix. It is unrelated to this admin change.


Accept limit / offset as BindVar

This should fix #509

I need to take a closer look at this tomorrow. We have engine tests for exactly the problem being described, and I don't understand why your change would fix it.


Add Relationship fields in client side fragments

What
Client-side generated fragments would only include expanded fields for 1:M types, whereas we need to have expanded fields for M:1 and 1:1.

We haven't verified that before and even now it will be hard to verify those without actuall app implementing this or integration tests.
I would be cool to see app copied (prefferable) or integrations tests for this and then merge

Needs rebase as we have merged previous changeset


QRCodeProps.size? is typed as number but this doesn't allow to use auto

I would like to pass auto as size, but size is typed as number. If I try auto, it just works so shouldn't auto also be allowed?
https://github.com/rosskhanas/react-qr-code/blob/8adcd9ce7b564b2daab082aee7700f7fb8a6a02d/types/index.d.ts#L6
it's passed here from what I understand to width and height, so it should just work:
https://github.com/rosskhanas/react-qr-code/blob/8adcd9ce7b564b2daab082aee7700f7fb8a6a02d/src/QRCodeSvg/index.js#L21
src/components/dashboard/layout.tsx:23:13 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: QRCodeProps | Readonly<QRCodeProps>): QRCode', gave the following error.
    Type 'string' is not assignable to type 'number'.
  Overload 2 of 2, '(props: QRCodeProps, context: any): QRCode', gave the following error.
    Type 'string' is not assignable to type 'number'.

23             size='auto'

So I guess it should be typed as number | 'auto'?

@evroon It may work on the web, but unfortunately not with react-native https://github.com/software-mansion/react-native-svg/issues/1429

Ahh okay haha that sounds like quite a shortcoming, but then I will just ignore the error in my own code.
Thanks for the response.