Use a two step process on fork: render manually using a pr comment

This should close #65
Issue is that pr-* action won't work for pull request triggered from fork.
What I suggest here is to use them as pr command - the action would fail with a message on fork, and then a render could be trigger using /render comment on a PR comment. I believe this will work as this is how the pr-* actions are used usually (as issue comment)
This involves a manual step but it is a simple addition to the current workflow.
Does it seems ok ?
I tested quickly in a fork but it is not easy to test. If it seems ok to you, I'll merge and tweak live with the current opened PRs.

I think this should do it. I am going to merge anyway and we could revise later.

Sounds good to me — feel free to just fix anything you find that's broken. I'll try to review if I can but (a) I'm deep in another project right now and (b) I clearly never understood the process very well anyway 😆.


Failed to pull image "docker.io/openpai/drivers:latest": rpc error: code = Canceled desc = context canceled

Step to reproduce:

Setup dev-box, and prepare config, bootup k8s cluster.

Remove all docker images on the k8s nodes.

Start PAI services:
./paictl.py service start -p /YOUR_CONFIG_PATH

The output will looping:
drivers-one-shot is not ready yet. Please wait for a moment!
drivers-one-shot is not ready yet. Please wait for a moment!
drivers-one-shot is not ready yet. Please wait for a moment!
...

In the mean time, got some kubectl logs for pod 'drivers-one-shot-5xk9w'.

root@k8s-eastus-head:/# kubectl logs -f drivers-one-shot-5xk9w
Error from server (BadRequest): container "nvidia-drivers" in pod "drivers-one-shot-5xk9w" is waiting to start: trying and failing to pull image
root@k8s-eastus-head:/# kubectl logs -f drivers-one-shot-5xk9w
Error from server (BadRequest): container "nvidia-drivers" in pod "drivers-one-shot-5xk9w" is waiting to start: image can't be pulled
root@k8s-eastus-head:/# kubectl logs -f drivers-one-shot-5xk9w
Error from server (BadRequest): container "nvidia-drivers" in pod "drivers-one-shot-5xk9w" is waiting to start: trying and failing to pull image
root@k8s-eastus-head:/#

And check the k8s dashboard, here's some below.

@ydye ,
We can reproduce this issue. Only need to remove images on nodes.
And it won't finished until at least 30 minutes.
We can work around via pulling the images manually on the node.

It's network issues.


[VLM] Minor update on initializing MultiModalConfig

Previously we initialize MultiModalConfig for all models regardless of whether or not the model itself is multi-modal. This can cause some developer confusion, especially since we're going to use this class for multimodal models starting #7126.
This PR updates the logic to make it cleaner.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@DarkLight1337 I realized this won't work in the way I wanted since currently there isn't a clean way to check at engine init time whether a model supports multi-modal. Going to modify this one and just change raise to assert

@DarkLight1337 I realized this won't work in the way I wanted since currently there isn't a clean way to check at engine init time whether a model supports multi-modal. Going to revert my changes from commit 814c2bc and just change raise to assert.

I think it should be possible to add a new function ModelRegistry.is_multimodal_model, similar to ModelRegistry.is_embedding_model.

@DarkLight1337 I realized this won't work in the way I wanted since currently there isn't a clean way to check at engine init time whether a model supports multi-modal. Going to revert my changes from commit 814c2bc and just change raise to assert.

I think it should be possible to add a new function ModelRegistry.is_multimodal_model, similar to ModelRegistry.is_embedding_model. Then we can initialize MultiModalConfig inside ModelConfig only when the model is indeed multi-modal.

Yea the more I think about it, the more I feel like it makes more sense to have a ModelRegistry.is_multimodal_model function for us to easily differentiate the models. Will update my code accordingly.

Since MultiModalConfig is contained in ModelConfig, it is redundant to pass MultiModalConfig separately from ModelConfig to the various classes (executor, model runner, model loader and model classes).


[backport] DCOS-42504: connect to the Mesos Stream on all pages

Closes DCOS-42504
Testing
Check the Network tab on the Dashboard page. UI should be connected to the v1?subscribe endpoint

:tada: This PR is included in version 1.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to only generate types without clients or the other stuff?

Discussed in https://github.com/orgs/hey-api/discussions/871

Originally posted by nahasco August  5, 2024
I just need types from my openapi yaml. No clients or the other features that i dint currently need.

How can I use this?
npx @hey-api/openapi-ts -i ../backend/schema.yaml -o ./schema

Running this command results in the follwoing error:
🔥 Unexpected error occurred. Log saved to /Users/nahasco/Tibian/tibian/frontend/openapi-ts-error-1723673994037.log
🔥 Unexpected error occurred. 🚫 client needs to be set to generate services - which HTTP client do you want to use?

@nahasco You need to disable services, they're enabled by default currently. I'd also recommend creating a config file, easier to do it there with type hints

Got it, thanks!


Removed Readme file as it breaking publish.file is not required.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for the PR. Please provide details of the problem this PR fixes, specifically the steps to reproduce it.

@vgribok - Solution file references README.jQuery.vsdoc.txt but the file is not available in source code and was causing the build failure when publishing to beanstalk.
@vikasgali  - thanks for the PR.


support for multiple github access tokens to avoid rate limits

Please add support for multiple github access tokens to avoid rate limits

@ajaykulal
How would this avoid rate limits. Even you cycle through tokens, you will still hit network limits. Honestly, using this tool to the extent it can be used will present itself as a DOS attack long before you hit limits.
I am not against this thought, just not sure it is worth the effort to solve as we will simply hit another wall.


Update to Redmine 3.4.2

@stgeneral  May I please ask you to update the plugin for Redmine 3.4.2 as currently it cannot be installed on Rm 3.4.2-Stable?
Thank you.

Thank you for a report. What error do you get?

Fixed in #90.


utils/github/actions: support notices and new annotation parameters

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

GitHub Actions annotations also suport a "notice" annotation type. You
can also set the title of an annotion, and the set endLine and
endColumn parameters.
See https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions
I plan to use title and end_line in particular in test-bot.

Review period will end on 2021-11-17 at 06:46:43 UTC.

Review period skipped due to critical label.


[otbn/ecdsa] Add capture support for ECDSA-256/384

Initial support to capture side-channel traces from
OTBN ECDSA-256 and ECDSA-384 applications.
New capture commands ecdsa-simple and ecdsa-stream.
Supports only CW-Husky as the capture device.

New files:

cw/capture_ecdsa_cw310.yaml: config file for ECDSA experiments

Modified files:

cw/capture.py

Add new command ecdsa-simple to collect long ECDSA traces without using CW-Husky's streaming mode
Add new command ecdsa-stream to collect long ECDSA traces using CW-Husky's streaming mode

cw/device.py

Changes to handle PLL frequencies other than 100MHZ
Add program_target() for programming the firmware during ECDSA
experiments.

Notes:

Tested on CW-310 with a CW-Husky

Signed-off-by: Bilgiday Yuce<EMAIL_ADDRESS>

Thanks @bilgiday for opening this PR and for making the changes.
Capturing works well when using binary objs/ecc_serial_fpga_cw310.bin
I tested it using:
./capture.py --cfg-file capture_ecdsa_cw310.yaml capture ecdsa-simple --num-traces 10
and
./capture.py --cfg-file capture_ecdsa_cw310.yaml capture ecdsa-stream --num-traces 10
In both cases, the traces look correct.
However, when I try testing objs/ecc384_serial_fpga_cw310.bin, I get the timeout warnings
Timeout in OpenADC capture(), no trigger seen! and the capturing doesn't complete. Does this binary work in your setup?

Thanks @vrozic for testing them.

I think the problem is related to the following lines of cw/capture_ecdsa_cw310.yaml:
key_len_bytes: 32
plain_text_len_bytes: 32
output_len_bytes: 32

ECDSA-256 driver works with 32-B input/output while ECDSA-384 works with 48-B input/output.
To make things easier for the user we can use a separate yaml file for each application such as  capture_ecdsa256_cw310.yaml and capture_ecdsa384_cw310.yaml. Would it be okay?

ECDSA-256 driver works with 32-B input/output while ECDSA-384 works with 48-B input/output.
To make things easier for the user we can use a separate yaml file for each application such as capture_ecdsa256_cw310.yaml and capture_ecdsa384_cw310.yaml. I can create these new files, would it be okay?

Ooops, of course. It is working well now. :)
Yes, having separate .yaml files is a good idea. It will help avoid any confusion in future.


feat: custom secret keys

Currently our publishing scripts have either hard coded secret keys, or don't support keys at all and assume the value is the entire secret string. This blocks us from being able to consolidate values in a single secret.
This PR adds keys support for all our publishing scripts.
Still WIP since it hasn't been thoroughly tested.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Lol github actions bot being extra aggressive these days...


Add any_sender and unique_any_sender

Adds type-erased senders, any_sender and unique_any_sender (of which the latter is move-only). I'd appreciate feedback on this as it's the first time I do any serious type-erasing. The type-erasure mechanisms don't have to stay this way if the techniques used elsewhere are preferable.
The senders are currently templated on the value types that the wrapped senders send, and only on that. The wrapped senders must send only one set of values (i.e. no multiple variants in value_types). The senders are currently not templated on the error type at all, and assume std::exception_ptr. This could easily be changed if needed.
The buffers used for SBO are quite big right now and may be self-defeating. I guess experience will show what are good sizes for the buffers. It can of course also become a template parameter but I'd prefer not putting it there unless there's a strong need for it.
There are still a few TODOs in the code, but the overall structure is there, and the tests pass.

I want to add that a complementary option to this (in some situations) would be a "variant_sender" when the set of possible sender types is known ahead of time. It may lead to better code generation and is a lot simpler in implementation. However, I'm leaving that out for the moment (if someone is interested please comment, I have a somewhat working version of that as well).

Interestingly there seems to be a trade-off between eager and lazy execution.
Laziness helps avoid allocations in the non-type-erased case. However, in the type-erased case (as implemented here right now) in the worst case there are more allocations than with async/then/dataflow (potentially one for each of the type-erased sender, receiver, and operation state).
I haven't tried this yet, but I think eagerly submitting the work wrapped in an any_sender would help remove at least some of those allocations. I'm not sure how this would play with any laziness/eagerness guarantees that P2300 might make (currently there's no type-erasure in it).
It's also possible that my implementation here is just dumb and it would be possible to keep the laziness and reduce potential allocations, but I don't see how to do that right now.

I'd like to keep this in its current v0.1 state, and explore the performance implications (if any) of those allocations and the branching when dispatching separately inside DLA-Future.
I currently don't see any way to avoid that branch when dispatching, though I'm most likely missing something clever.


omniauth-github does not return a token with access to organization repository

https://github.com/intridea/omniauth-github/issues/60

To help me debug this issue can you explain:

What you were trying to do (and why)
What happened
What you expected to happen
Step-by-step reproduction instructions (with as minimal input data as possible)

tried to clone a github repository from an organization I belong to
repository was not cloned due to an error (not found/no access)
i expected the repo to be cloned
run strap.sh, clone a repo from a github organization the user belongs to

the token that strap uses does not have access to all the organizations and their repos.

@isamuelson does the organization have application policies enabled? If so, has the organization approved your strap oauth application?

I don't see the app at all or was there any email about approving it
On Thursday, March 17, 2016, Matt Burke<EMAIL_ADDRESS>wrote:

@isamuelson https://github.com/isamuelson does the organization have application
policies
https://developer.github.com/changes/2015-01-19-an-integrators-guide-to-organization-application-policies/
enabled? If so, has the organization approved your strap oauth application?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mikemcquaid/strap/issues/57#issuecomment-197998945

--
Ido Samuelson
Phone (US): +1-415-562-8582
Email<EMAIL_ADDRESS>LinkedIn: http://www.linkedin.com/in/isamuelson
Skype: ido_samuelson

@isamuelson unless you are an organisation administrator you may not have the ability to give Strap access to that repository. It may make more sense instead to create your own Personal Access Token. Let's keep talking about this but it doesn't seem to be a Strap bug.

I M an admin and I had not option to do that...strap was never on the list
On Thursday, March 17, 2016, Mike McQuaid<EMAIL_ADDRESS>wrote:

Closed #57 https://github.com/mikemcquaid/strap/issues/57.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mikemcquaid/strap/issues/57#event-594281669

--
Ido Samuelson
Phone (US): +1-415-562-8582
Email<EMAIL_ADDRESS>LinkedIn: http://www.linkedin.com/in/isamuelson
Skype: ido_samuelson

@isamuelson Does the organization have application policies enabled?

Yes. I have other apps there
On Friday, March 18, 2016, Mike McQuaid<EMAIL_ADDRESS>wrote:

@isamuelson https://github.com/isamuelson Does the organization have application
policies
https://developer.github.com/changes/2015-01-19-an-integrators-guide-to-organization-application-policies/
enabled?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mikemcquaid/strap/issues/57#issuecomment-198212107

--
Ido Samuelson
Phone (US): +1-415-562-8582
Email<EMAIL_ADDRESS>LinkedIn: http://www.linkedin.com/in/isamuelson
Skype: ido_samuelson

If you've enabled application policies check the list of apps enabled or disabled for the org.

closing the issue...token was cached...once i cleared the cache i was able to approve the organization

Thanks for letting me know @isamuelson!


[Feature Request]: Proposal for Environment Management Improvement in Apache Hop

What would you like to happen?
Aqui está o conteúdo completo com a adição da sua sugestão:
Proposal for Environment Management Improvement in Apache Hop
Currently, it seems there is no way (or I haven't found one) to reuse the environment configuration file across multiple projects in Apache Hop. This requires creating environments manually for each new project, which can lead to inconsistencies and increase the maintenance effort.
Thus, I am proposing a feature to decouple environment management from individual project contexts. The idea is to allow environments to be created in a centralized manner and reused across various projects. Each project would then be able to select the environments it needs.
Proposal Details:
Environments should be created only once, independently from specific projects.
Projects will be able to associate themselves with existing environments based on their requirements.
With these parameters, a new config file should be generated.
Additionally, the environment configuration file can reside in an isolated folder, managed through a special variable, similar to HOP_CONFIG.
The table below illustrates how projects could share environments flexibly:

Projects
database_prd
database_prod
api

project a
x
x

project b

x
x

project c

x

Expected Benefits:
Environment reuse: Reduces the effort and time required for configuration by avoiding duplication of environments across projects.
Consistency: Ensures the same environments are used consistently across multiple projects.
Easier maintenance: Any changes made to a centralized environment will automatically reflect across all associated projects, reducing the need for repetitive updates.
This proposal aims to improve scalability and efficiency in managing environments within Apache Hop, particularly for organizations managing multiple projects and shared environments.
Issue Priority
Priority: 3
Issue Component
Component: Hop Config, Component: Hop Gui

OK. thanks for the feedback.


Update name on README

Testing "Shared Repository Model" or "GitHub Flow" model for collaboration on git projects.

Nice.


Incorrect result while using >=, because of PDO::PARAM_INT for type binding

Can you please provide more detail and information with your code example about this issue in English?


Remove/update the output is in ... message at the end of compilation

Compilation completed successfully, output files are in <project-root>/temp/abc

this message is obsolete with the emitter independent output-dir config. We should either:

just remove it
say where each emitter is emitting their files(emitter-output-dir)
list every single emitted file (TS compiler has this with --listFiles flag)

est: 1

for now, do (1).  File an issue for emitter file logging

Related to https://github.com/Azure/typespec-azure/issues/1717.
I'd like the default level of logging to provide more information what files were created and copied. Currently I have to rely on git diff to see what has changed.

#1961 now tracks a better logging. I don't think it should be on by default because it could be quite verbose and it's not typical for compilers to write this out by default. We could support a configuration option in tspconfig.yaml to turn it on without typing a switch every time, though. I'll add a note on that.


:bug: fixed js

Codecov Report

Merging #141 (b451ce1) into master (f72fe15) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   29.00%   28.83%   -0.18%
==========================================
  Files          46       46
  Lines        2341     2341
==========================================
- Hits          679      675       -4
- Misses       1662     1666       +4

Impacted Files
Coverage Δ

mighty/src/state.rs
61.17% <0.00%> (-0.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72fe15...b451ce1. Read the comment docs.


Add conditional build tag to generated files

Added a -t option for specifying conditional go build tags. Was useful to me when testing back and forth between production and dev builds because I could use the conditional flags to switch between using disk files and pkged.go files very easily.

Thanks, I think the approach that Packr uses would work better here.
If we add the following build tag to the generated file, then by default it would be included in any go build command, but to skip it you could just do go build -tags skippkger and then they won't be included.
// +build !skippkger

Hi, anything else you would like to see done prior to merging this?


[jsoncpp] Build failure on x64-linux

Package<EMAIL_ADDRESS>Host Environment

Host: x64-linux
Compiler: GNU 11.4.0
vcpkg-tool version: 2024-10-18-e392d7347fe72dff56e7857f7571c22301237ae6
vcpkg-scripts version: e60236ee0 2024-10-26 (2 days ago)

To Reproduce
vcpkg install jsoncpp:x64-linux
Failure logs
-- Using cached open-source-parsers-jsoncpp-1.9.6.tar.gz.
-- Cleaning sources at /home/akhil/dev-tools/vcpkg/buildtrees/jsoncpp/src/1.9.6-29ceffc35f.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/akhil/dev-tools/vcpkg/downloads/open-source-parsers-jsoncpp-1.9.6.tar.gz
-- Using source at /home/akhil/dev-tools/vcpkg/buildtrees/jsoncpp/src/1.9.6-29ceffc35f.clean
-- Configuring x64-linux
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Fixing pkgconfig file: /home/akhil/dev-tools/vcpkg/packages/jsoncpp_x64-linux/lib/pkgconfig/jsoncpp.pc
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:166 (message):
  Could not find pkg-config.  Please install it via your package manager:

      sudo apt-get install pkg-config
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:193 (vcpkg_find_acquire_program)
  ports/jsoncpp/portfile.cmake:32 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:192 (include)

@akhiltiwarietawah Please run command sudo apt-get install pkg-config and try again.

Thank you for your assistance! I followed your advice and installed jsoncpp successfully using vcpkg. I also created a simple project to test it, and everything is working perfectly. I appreciate your help!


MODULES-1857 - Fixing test failures

The Gemfile is now pulling in rspec-core 3.2.2 & rspec-puppet 2.0.1.
This fix has updated the tests to ensure they pass using these versions.

Any particular reason why you changed from expect to should ?
http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/

Hi @tphoney I tried the following:
expect { subject }.to raise_error(Puppet::Error, /not supported on an Unsupported/)
but the test still failed:

rabbitmq on unsupported distributions we fail
Failure/Error: expect { subject }.to raise_error(Puppet::Error, /not supported on an Unsupported/)
expected Puppet::Error with message matching /not supported on an Unsupported/ but nothing was raised
./spec/classes/rabbitmq_spec.rb:9:in `block (3 levels) in <top (required)>'

After reading these this morning:
https://github.com/rodjek/rspec-puppet/issues/257
https://github.com/rodjek/rspec-puppet/issues/173
I have now got the test working with the following syntax:
expect { should compile }.to raise_error(RSpec::Expectations::ExpectationNotMetError, /not supported on an Unsupported/)
Is this syntax ok to use? If so I will make the change
Note: I am new to the world of rspec

the expect syntax is preferred. Thanks for the effort you are putting in.

Have committed the tests I amended to use the expect syntax

@tphoney if the should syntax still works in rspec 3 and allows us to test for Puppet::Error instead of RSpec::Expectations::ExpectationNotMetError I would have a preference for that. @hunner @mhaskel what do you think?

@jaxim awesome. One last thing, could you squash these three commits into one?

@cmurphy Hopefully I have done the squash correctly. I have learnt something new with that :smile:

@jaxim thanks for working on this, we're going to follow the same approach for our other modules.


Switch to LTS Python versioning

See the the Python branch status page for up to date information.
2024-12-27 As of this issues creation, Python 3.12 and 3.13 are the current versions with bugfix support, and 3.13 is relatively new to this period.
PEP-602 Updated the bugfix support timeline to two years from versions 3.13 onward instead of 1.5 years from version 3.12.
This issue is to decide on a minor version and keep up with the latest Python patches.

3.12.x Bugfix period is ending sometime around April 2025 based on the 18 month timeline.
3.13.x Bugfix period is ending October 2026 based on the two new year timeline.

Arguments for 3.12.x:

Dependency package support will likely be better as this has had more time to bake
Less (but not 0) chance of encountering bugs

Arguments for 3.13.x:

Longer remaining Bugfix/Security Update period
Less work to upgrade in the future

I am open to either, but I would vote towards just using the latest 3.13.x and falling back to 3.12.x if we encounter issues.

I say 3.12 and would even suggest using 3.11. We can run our tests across multiple versions of python, but developing on a more stable version of python will ensure less issues occur.

@lesniakt this is a great explanation! Thank you very much!
I am fine with either one you guys prefer. Since, Scott suggested 3.11 and Thomas 3.13, do you guys want to do 3.12? If we do 3.12, we should just change to another patch, since 3.12.5 has problems in black. Maybe 3.12.4?
As I said before, I am fine with either.

@lesniakt I just talked to @smturro2 and we thought that 3.12 without a patch would be good. What do you think?
If you are fine with it, I will change the README.

What does "without a patch" mean? 3.12.0? I'd prefer to stick with the 3.12.x series over 3.11.x. Generally, python support for the major packages we use is pretty good, so I'm not worried about package issues with 3.11.


feat: [GH-177] forward all cache options to key value cache

To be able to support custom key value caches that have additional cache options, ensure to forward all cache options to the key value cache when setting a entry into the cache.

@HishamAli81: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Closing as stale but still open to this change.

Closing as stale but still open to this change.

@trevor-scheer Apologies for the delay, just circling back to this. I'll close this PR and will create the apollo-utils PR like you suggested first, then will create a new PR for this repo.

@HishamAli81 no worries. I'm going to reopen this one in case you want to pick up here - that would be my preference. Feel free to close it if you'd rather just open a new one still.

@trevor-scheer I've updated this PR with the latest version of @apollo/utils.keyvaluecache for better type support when customizing CacheOptions

@trevor-scheer Thanks for the review, I've just pushed out the minor updates you suggested.

@HishamAli81 Thanks for all of your efforts on this! Kicking off a release shortly.


Unsaved Files Deleted Randomly

I just had 4 source files that I was working on completely erased. They were all untitled files because I hadn't saved yet. I switched to a file I HAD saved to change something, and when I went back, I looked in the first untitled tab, only to find it empty. I quickly discovered the other untitled tabs were empty as well. Long-story short, I just lost four source files and thought you may want to look into the cause of this/see if anyone else has this issue.

Thanks for the submission.
We haven't received any other reports of untitled files being wiped of their contents while Atom is running. We do have https://github.com/atom/atom/issues/13318 which describes how untitled files aren't silently saved when Atom exits without a project folder, though you are now prompted to save them on exit.
While losing work is somewhere between annoying and catastrophic, without the information that was requested in the issue template, we don't have enough information to do any real investigation here. We would be happy (and highly motivated) to look into what went wrong if you open a new issue and fill in the details requested in the issue template.
Thanks for understanding and meeting us halfway.


Black border around terminal area

Which operating system does the issue occur on? Linux
If on linux, are you using X11 or Wayland? X11
Ever since commit d76bb0c69793eda42d0e46d4a7c7218b8a3a4a37, after resizing the window, I have a black bar around the terminal area within the terminal window. Also text rendering is kind of fuzzy (and smaller) compared to previous versions.

Here is a screenshot of make menuconfig from the Linux kernel to show what I mean, this is supposed to take up the entire termina:


github login failed every time

Type: Bug
The login step in browser is good, and successfull, but when redirect to vscode, vscode can also recive the redirect request, because it will pop up a window to ask me if allow it, but after that, it stuck until timeout
VS Code version: Code 1.71.0 (784b0177c56c607789f9638da7b6bf3230d47a8c, 2022-09-01T07:36:10.600Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: No
Remote OS version: Linux x64 3.10.0-1127.19.1.el7.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz (4 x 3300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.91GB (24.16GB free)

Process Argv
--crash-reporter-id a72f7270-60dd-4eec-8d30-1feb1135c48c

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: 阿里云

OS
Linux x64 3.10.0-1127.19.1.el7.x86_64

CPUs
Intel(R) Xeon(R) Platinum 8163 CPU @ 2.50GHz (2 x 2499)

Memory (System)
7.64GB (4.40GB free)

VM
25%

Extensions (11)

Extension
Author (truncated)
Version

vscode-docker
ms-
1.22.1

vscode-language-pack-zh-hans
MS-
1.71.9070915

python
ms-
2022.14.0

vscode-pylance
ms-
2022.9.10

jupyter
ms-
2022.8.1002431955

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.9

remote-ssh
ms-
0.84.0

remote-ssh-edit
ms-
0.80.0

remote-wsl
ms-
0.66.3

vim
vsc
1.23.2

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vscaat:30438848
pylanb8912:30545647
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012:30540252
azure-dev_surveyone:30548225
i497e931:30553904

And I have tried win11, win10, MACOS, also with proxy or not with proxy, nothing helped

Any update ?

Sorry could you attach a video or a gif? That would really help me understand what you're seeing.
/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette).
Happy coding!

How do I make y'all stop sending me emails. I don't even do git hub
On Fri, Sep 16, 2022, 10:28 PM VSCode Triage Bot @.***>
wrote:

Thanks for reporting this issue! Unfortunately, it's hard for us to
understand what issue you're seeing. Please help us out by providing a
screen recording showing exactly what isn't working as expected. While we
can work with most standard formats, .gif files are preferred as they are
displayed inline on GitHub. You may find https://gifcap.dev helpful as a
browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling
screencast mode for the recording (Developer: Toggle Screencast Mode in
the command palette).
Happy coding!
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/160649#issuecomment-1249988436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXGLKFLPWU64DHSPYDGR2A3V6U3FTANCNFSM6AAAAAAQJZIYBE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

/gif

sorry for the gif delay

can you provide the contents of the GitHub Authentication output pane:

And also anything that shows up in Dev Tools:

ctrl + shift + P
"Dev Tools"

can you provide the contents of the GitHub Authentication output pane:
And also anything that shows up in Dev Tools:

ctrl + shift + P
"Dev Tools"

Nothing else

Very interesting... you see the spinning sign in to github.com... in your status bar... can you click on that and click cancel and then it'll ask you via a notification if you want to try logging in a different way... can you try that? Let me know if you need a video to understand what I'm talking about.

Very interesting... you see the spinning sign in to github.com... in your status bar... can you click on that and click cancel and then it'll ask you via a notification if you want to try logging in a different way... can you try that? Let me know if you need a video to understand wh

at I'm talking about.
Already tried so many times， here is the result

Very interesting... you see the spinning sign in to github.com... in your status bar... can you click on that and click cancel and then it'll ask you via a notification if you want to try logging in a different way... can you try that? Let me know if you need a video to understand what I'm talking about.

Already tried so many times， here is the result

Hi, is there any update?

@tsgsz let's try to get you unblocked first... can you open up Windows Credential Manager and go to Windows Credentials

Then look for any credentials that start with vscode and delete them. Then try logging in again.

@tsgsz let's try to get you unblocked first... can you open up Windows Credential Manager and go to Windows Credentials
Then look for any credentials that start with vscode and delete them. Then try logging in again

There is no  credentials that start with vscode, I delete all of the rest credentials and loggin again, the result is all the same.
I really don't think it's the credential problem, because couple of days ago, I try it in my mac, didn't work either, and my windows also resinstalled once, nerver work.

Let's see if this is a keytar issue then... first log in in vscode (even though it fails)
if you have nodejs installed, you can run this simple one-liner to see if the problem is how your keychain is setup:
npx @emacs-grammarly/keytar-cli find-creds -s vscodevscode.github-authentication

or if you're on Insiders:
npx @emacs-grammarly/keytar-cli find-creds -s vscode-insidersvscode.github-authentication

This is using the following open source package: https://github.com/emacs-grammarly/keytar-cli
What you should get is something like this:
[
  {
    account: 'github.auth',
    password: '....... longggg string ......'
  }
]

NOTE: on macOS I got a system prompt to allow this process to access the keychain... that may or may not be the case for you

Additionally, we can see if we can properly set passwords:
npx @emacs-grammarly/keytar-cli set-pass testingvscode testingvscode testingvscode

and then
npx @emacs-grammarly/keytar-cli find-creds -s testingvscode

should give us that newly created password.

Let's see if this is a keytar issue then... first log in in vscode (even though it fails)
if you have nodejs installed, you can run this simple one-liner to see if the problem is how your keychain is setup:
npx @emacs-grammarly/keytar-cli find-creds -s vscodevscode.github-authentication

or if you're on Insiders:
npx @emacs-grammarly/keytar-cli find-creds -s vscode-insidersvscode.github-authentication

This is using the following open source package: https://github.com/emacs-grammarly/keytar-cli
What you should get is something like this:
[
  {
    account: 'github.auth',
    password: '....... longggg string ......'
  }
]

NOTE: on macOS I got a system prompt to allow this process to access the keychain... that may or may not be the case for you

Additionally, we can see if we can properly set passwords:
npx @emacs-grammarly/keytar-cli set-pass testingvscode testingvscode testingvscode

and then
npx @emacs-grammarly/keytar-cli find-creds -s testingvscode

should give us that newly created password.

npx @emacs-grammarly/keytar-cli find-creds -s vscodevscode.github-authentication this return "[]"
npx @emacs-grammarly/keytar-cli set-pass testingvscode testingvscode testingvscode this is normal
and I manually set vscodevscode.github-authentication using the set-pass command, the output keytar is ok, just vsocde still can't login

My friend, any clue?

Hi， is there anyone still working on this issue？

I just got back from vacation and am juggling multiple items. This issue hasn't been forgotten

I just got back from vacation and am juggling multiple items. This issue hasn't been forgotten

thanks

@tsgsz can you run these two lines in PowerShell and tell me what you get?
Invoke-RestMethod -Method Post https://vscode.dev/codeExchangeProxyEndpoints/github/login/oauth/access_token
Invoke-RestMethod -Method Post https://vscode.dev/codeExchangeProxyEndpoints/github/login/oauth/access_token -Body 'code=123'

They will fail, but I want to make sure you at least get a response from the server

result as follow:

the text version:
Invoke-RestMethod : No code property provided in body

Invoke-RestMethod -Method Post https://vscode.dev/codeExchangeProxyEn ...

  + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod]，WebException
  + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand

Invoke-RestMethod : bad_verification_code: The code passed is incorrect or expired. (https://docs.github.com/apps/managing-oauth-apps/troubleshooting-oauth-app-access-token-request-errors/#bad-verification-code)

Invoke-RestMethod -Method Post https://vscode.dev/codeExchangeProxyEn ...

  + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod]，WebException
  + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand

knock knock

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Hi,
I've just read the full issue and I have the exact same issue.
I'm using ssh keys to login to github, this works everywhere except in vscode. It does popup the browser login window

But clicking signing with browser just goes to a blank localhost page most of the time, once it did show me a successfully login you can go back to the app, but in vscode it was still complaining.
npx @emacs-grammarly/keytar-cli find-creds -s vscode-insidersvscode.github-authentication
Returns
[
  {
    account: 'github.auth',
    password: 'AQxlmzCMdedeFgtEgtjogfetgwt/lfsAefgAgteagt3geugtYerSgetOYrDD\n' +
      'Blablablabal(removed)'
  }
]

And this is Github Auth Log:

This only happens on my windows machine and funny to note that while trying to solve this, every single commits had a different user... not sure why but it might be related:

That doesn't seem to be related. VS Code does not open those popups. I got a new issue going for you.

I've got a new condition, my last computer naturally ok for days ago(I've done nothing, and no update), but my new mac can't login, exactly the same behavior, which remind me maybe there is some token or other thing time related?

Hey @tsgsz, hope you're feeling better.  For macOS, how did you install it. Could you record a video of you going through the flows? I'd love it if you could try the fallback flows to see if any work for you.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

I have 2 macs, one is new, so I can't use setting sync and code pilot, but one is old, it use to login successfully in setting sync, but now can't login with pilot,  which looks like this

This is interesting now, I have 3 computers, 2 mac, 1 pc,  pc now can do everything(I did nothing actually, it just became fine one day), one mac can sync settings but no code pilot, one mac can do nothing...

the video you want is exactly like this except it's in mac

Very interesting... you see the spinning sign in to github.com... in your status bar... can you click on that and click cancel and then it'll ask you via a notification if you want to try logging in a different way... can you try that? Let me know if you need a video to understand what I'm talking about.

Already tried so many times， here is the result

The video you want is exaclty the same with this, but in mac

I check the "can do nothing" mac's key chain, compare to the "can do one thing" mac, the result like below

same issue

same issue

same issue

The "same issue" comments... please just use the +1 reaction feature of GitHub. We call this out in our wiki:
https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions#before-submitting-an-issue
A new version of VS Code will be going out today that has a fix that might help in this space. Can you get it and tell me how it goes?

The "same issue" comments... please just use the +1 reaction feature of GitHub. We call this out in our wiki: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions#before-submitting-an-issue
A new version of VS Code will be going out today that has a fix that might help in this space. Can you get it and tell me how it goes?

just tried, nothing changed

same issue on windows

Any update? or any clue?

I have one pc, and one mac to be good now,  only one mac(but my mac in company doesn't work), hope before it became ok, I can help u find the bug...

I had another idea. My goal is the try to understand where you get stuck.
Run vscode in a terminal with the flag --disable-keytar.
If you are able to complete the login flow, then the issue is talking to the keychain on your OS.
This disables persistent auth sessions so reloading the window will throw out your login session but at least we'll have more information.

I had another idea. My goal is the try to understand where you get stuck.
Run vscode in a terminal with the flag --disable-keytar.
If you are able to complete the login flow, then the issue is talking to the keychain on your OS.
This disables persistent auth sessions so reloading the window will throw out your login session but at least we'll have more information.

got this:

Now that's unusual. I don't repro that. Also, my error is different when I run with a command that isn't real:

This is the one on your Mac, yes? My code comes from /usr/local/bin/code (running which code)... what does yours say? Also what does code --help and code --version output.

Now that's unusual. I don't repro that. Also, my error is different when I run with a command that isn't real:

This is the one on your Mac, yes? My code comes from /usr/local/bin/code (running which code)... what does yours say? Also what does code --help and code --version output.

my vscode is the latest version in office website, mac osx intel, is  that the same?

Now that's unusual. I don't repro that. Also, my error is different when I run with a command that isn't real:

This is the one on your Mac, yes? My code comes from /usr/local/bin/code (running which code)... what does yours say? Also what does code --help and code --version output.

yes, this is the one on my mac

Apparently, this flag is not available in the standalone CLI but is in the normal CLI... anyway, another way to do this is to run:
Preferences: Configure Runtime Arguments

and add a "disable-keytar": true
it will say it's not allowed, but it is. Ignore the warning and restart (kill and start) VS Code.

Apparently, this flag is not available in the standalone CLI but is in the normal CLI... anyway, another way to do this is to run:
Preferences: Configure Runtime Arguments

and add a "disable-keytar": true
it will say it's not allowed, but it is. Ignore the warning and restart (kill and start) VS Code.

find a way to do it anyway, disable succeed, like this:

But the problem still the same, nothing changed, like this:

After disable the keytar,  everything is exactly the same like before

@tsgsz just to be perfectly sure... with keytar disabled, can you share the contents of the Main output channel?

@tsgsz just to be perfectly sure... with keytar disabled, can you share the contents of the Main output channel?

like this

I have a similar issue with windows. I am getting back what you expected from curl. In vs code output, I am getting Got 0 sessions for ...

here is the result:

And the outputs of gitauth and main:

Ok so clearly we have a situation where the request to exchange the code for a token isn't working... So the best way to debug this is to see if the request actually goes to us...
In other words, we've back up to #160649 (comment) but this time with your mac instead of your windows machine.
Can you run:
curl -X POST https://vscode.dev/codeExchangeProxyEndpoints/github/login/oauth/access_token -d 'code=2345'

If it's working it should come back with bad_verification_code: The code passed is incorrect or expired. (https://docs.github.com/apps/managing-oauth-apps/troubleshooting-oauth-app-access-token-request-errors/#bad-verification-code).

Guess what, Funny thing happend, I launched vscode from anaconda navigator in windows, and my login state are erased, so, My windows can't work again. LOL....

Ok so clearly we have a situation where the request to exchange the code for a token isn't working... So the best way to debug this is to see if the request actually goes to us...
In other words, we've back up to #160649 (comment) but this time with your mac instead of your windows machine.
Can you run:
curl -X POST https://vscode.dev/codeExchangeProxyEndpoints/github/login/oauth/access_token -d 'code=2345'

If it's working it should come back with bad_verification_code: The code passed is incorrect or expired. (https://docs.github.com/apps/managing-oauth-apps/troubleshooting-oauth-app-access-token-request-errors/#bad-verification-code).

Guess what, Funny thing happend, I launched vscode from anaconda navigator in windows, and my login state are erased, so, My windows can't work again. LOL....

there has something new：

I have a thought, is there any chance that the code for exchange token has some special character will cause this problem?
here is the url:
https://github.com/login/oauth/authorize?client_id=01ab8ac9400c4e429b23&redirect_uri=https://vscode.dev/redirect&scope=user:email&state=vscode%253A%252F%252Fvscode.github-authentication%252Fdid-authenticate%253Fnonce%253Daf2553cae834a1bd%2526windowId%253D1

Having the exact same issue, so annoying

@everdrone
I finally got to the bottom of this after using the Inspector Dev Tools in VSCode.
It was due to a previous installation of DOCKER which set some Windows System Variables, notably this:

And an entry setting a <IP_ADDRESS>:XXXX entry (sorry,I did not get a screenshot of that).
I removed both these entries and GitHub was able to authenticate.
So, check your system's environment variables, especially if you've used VM software like Docker! Hope this helps! 🙂

@cheestudio Thanks! I'll check it out asap!

Not sure about all of your issues exactly, what solved my issue was adding "http.proxySupport": "off" to vs code settings I believe for extensions.

I did this, succeed, thanks

same issue on mac

Not sure about all of your issues exactly, what solved my issue was adding "http.proxySupport": "off" to vs code settings I believe for extensions.

I did this, succeed, thanks

also succeed on windows. I think this is the anwser @TylerLeonhardt

@tsgsz I'm so glad! I've felt really bad that we haven't made much progress before. This is an eye opening discovery!

@tsgsz do you have a corporate proxy applied on these machines?

I don't think so, the system variable is empty, and a new mac also has the problem.

Having the same problem on macos 13.3

Can you try out @chrmarti's Proxy debugging extension here: https://github.com/microsoft/vscode-remote-release/issues/8248#issuecomment-1494127068
and let me know how it goes?

I guess that it maybe dns pollution, can you try to write the ip into the hosts file?

Try going to settings/Application/Proxy:
Http: Proxy Strict SSL

[x] Controls whether the proxy server certificate should be verified against the list of supplied CAs.

Uncheck that box!
You can see that expired certificates can lead to this problem in this thread: https://github.com/microsoft/vscode/issues/97434

Hello all,
I set it this option from override to off :

And after it had worked.
Code version : 1.77.3
Thanks to all for your help :)
Best regards

Not sure about all of your issues exactly, what solved my issue was adding "http.proxySupport": "off" to vs code settings I believe for extensions.

This solved for me as well. However @TylerLeonhardt, will we have any problem to turn-off http.proxySupport?

@chrmarti is the best person to answer that.

Not sure about all of your issues exactly, what solved my issue was adding "http.proxySupport": "off" to vs code settings I believe for extensions.

This solved for me as well. However @TylerLeonhardt, will we have any problem to turn-off http.proxySupport?

You won't see any issues if you are not behind a network proxy. This still suggests that there is a bug on our side.
Could you install the Network Proxy Test extension (https://marketplace.visualstudio.com/items?itemName=chrmarti.network-proxy-test) and check the output of F1 > Network Proxy Test: Test Connection in VS Code?

@chrmarti You want me to send the output of the above run with or without "http.proxySupport":"off" ?

@sumanth-lingappa Without "http.proxySupport":"off" is the important one. Thanks.

Not sure about all of your issues exactly, what solved my issue was adding "http.proxySupport": "off" to vs code settings I believe for extensions.

This solved for me as well. However @TylerLeonhardt, will we have any problem to turn-off http.proxySupport?

You won't see any issues if you are not behind a network proxy. This still suggests that there is a bug on our side.
Could you install the Network Proxy Test extension (https://marketplace.visualstudio.com/items?itemName=chrmarti.network-proxy-test) and check the output of F1 > Network Proxy Test: Test Connection in VS Code?

Note: Make sure to replace all sensitive information with dummy values before sharing this output.

VS Code 1.77.3 (704ed70d4fd1c6bd6342c436f1ede30d1cff4710)
Network Proxy Test 0.0.6
darwin 22.1.0 x64

Settings:
- http.proxy:
- http.proxyAuthorization: null
- http.proxyStrictSSL: true
- http.proxySupport: override
- http.systemCertificates: true

Environment variables:

Sending GET request to https://example.com...
vscode-proxy-agent: PROXY <IP_ADDRESS>:8009
Received error: certificate has expired (CERT_HAS_EXPIRED)
Retrying while ignoring certificate issues to collect information on the certificate chain.

Sending GET request to https://example.com (allowing unauthorized)...
vscode-proxy-agent: PROXY <IP_ADDRESS>:8009
Received response:
- Status: 200 OK
Certificate chain:
- Subject: www.example.org (Internet Corporation for Assigned Names and Numbers)
  Subject alt: DNS:www.example.org, DNS:example.net, DNS:example.edu, DNS:example.com, DNS:example.org, DNS:www.example.com, DNS:www.example.edu, DNS:www.example.net
  Validity: Jan 13 00:00:00 2023 GMT - Feb 13 23:59:59 2024 GMT
  Fingerprint: 80:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:44
- Subject: Network Security (iboss Network Security)
  Validity: Nov 23 06:51:30 2022 GMT - Dec 25 06:51:30 2023 GMT
  Fingerprint: 23:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:FA
  Self-signed

@sumanth-lingappa There is a proxy configured in your OS running on your local machine at <IP_ADDRESS>:8009. It issues its own certificates and has the CA certificate "Network Security (iboss Network Security)" registered in your OS as a root certificate. That root certificate has expired and is causing the request to fail.
You could uninstall that proxy or update its root certificate in your OS if you want to keep it running.

@sumanth-lingappa Does searching for extensions in VS Code's Extensions viewlet work? I would expect that to use the OS setting and fail too ("http.proxySupport":"off" won't affect that). 🤔

@sumanth-lingappa I misread the end date of the "Network Security (iboss Network Security)" certificate. It has not expired, but the first connection attempt failed with "certificate has expired". Not sure which certificate has expired. Is your system's clock set correctly (taking a guess)?

@chrmarti, yes the system clock is correct.

@sumanth-lingappa Could you use F1 > Network Proxy Test: Show OS Certificates and check if that has the same "Network Security (iboss Network Security)" entry as we have seen above? Please post it here if it is different.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Use gradle kotlin script in examples

This would be great for the Definitely Kotlin people, or those who wish to use more static build scripts.

This is the one thing blocking us from using the front end plugin instead of manually running command line command ourselves. Can't seem to get this to work with the Gradle Kotlin DSL.

Can't seem to get this to work with the Gradle Kotlin DSL.

What is your problem exactly? Maybe I can help... (I use it successfully with Kotlin DSL.)

I can't seem to get the syntax right, especially around the dsl within the kotlinFrontend {} lambda. Specifically, I'm trying to make the webpackBundle {}, resolve or work in anyways, but I can't seem to get it to work. So I have tried digging through the source to figure out what I should be putting, but end up not getting very far. An example of a kotlinFrontend {} lambda in Gradle Kotlin DSL would be immensely useful.

An example of a kotlinFrontend {} lambda in Gradle Kotlin DSL would be immensely useful.

An extract of my build.gradle.kts, I hope it helps:
val kotlinFrontend: KotlinFrontendExtension by project
kotlinFrontend.apply {
    downloadNodeJsVersion = "..."

    bundle("webpack") {
        this as WebPackExtension
        bundleName = "main"
        sourceMapEnabled = true
        ...
    }
}

Thank you, that is really helpful, and identifies what I was doing wrong.

extensions.findByType<KotlinFrontendExtension>()?.apply{
...
}

This one is equivalent to groovy closure. One can write an extension to make it shorter like
inline fun <reified T: Any> Project.withExtension(block : T.()->Unit){
  extensions.findByType<T>()?.run(block)
}

I wander, why gradle does not have it.
Still, translating inner parts from Groovy is not always obvious. For example I am currently searching for a way to represent npm block.

I am currently searching for a way to represent npm block.

I use simply:
val npm: NpmExtension by project.extensions
npm.apply { ... }

Thanks. I've been searching in the wrong place, I though that it should be a part of  KotlinFrontendExtension.

Reading the above, I managed to simplify my code to the<KotlinFrontendExtension>().apply { … }. It is nice to see this as WebPackExtension confirmed as a pattern. I agree that a complete example might be instructive to have as part of this repository.
Do you folks import all the relevant classes, or is there some magic to avoid that?

Among those already using this gradle plugin with Kotlin DSL successfully, does anyone want to edit the README.md to add such examples?


Support explode in Query

Support of:
@route("/c1/here") op c1(@query(#{ explode: true }) foo: string[]): void;

to mean that the url should explode the query parameter, for instance here foo=a&foo=b if we pass ["a","b"] at the SDK level.
### TypeSpec
- [ ] https://github.com/microsoft/typespec/issues/3736

### Spec
- [ ] https://github.com/Azure/cadl-ranch/issues/666
- [ ] https://github.com/Azure/typespec-azure/issues/1319

### Implementation
- [ ] https://github.com/Azure/typespec-azure/issues/1320
- [ ] https://github.com/Azure/autorest.python/issues/2755
- [ ] https://github.com/Azure/autorest.java/issues/2897
- [ ] https://github.com/Azure/autorest.typescript/issues/2735
- [ ] https://github.com/Azure/autorest.csharp/issues/4967
- [ ] https://github.com/Azure/autorest.go/issues/1423
- [ ] https://github.com/Azure/autorest.cpp/issues/374
- [ ] https://github.com/Azure/autorest.rust/issues/83

also this feature could cover the following uri template case:
@route("/action{?name*}") op action(name: string[]): void;

@lmazuel I want to clarify the scopes for this feature. According to uri temlate design, Can I understand below cases are in scope?

explode: true/false
serialized object: array/object/primitive
optionality: optional/required

Also there are some legacy cases which will be moved from format to encode, we have some cadl-ranch cases to cover array's serliazation, but for object I guest it is not ready yet(at least for JS). Do we need to care about these cases?

"explode" just means this:

explode: true => a=1&a=2
explode: false => a=1,2

This is orthogonale to how you serialize an array, an object, or a primitive. You should already have those scenarios covered, independently of "explode"
As of today, TypeSpec implies CSV (comma separated), it's not in scope to discuss pipe or space. DeepObject is not in scope either.
Optionality or required has nothing to do with the feature (the query parameter can be optional or required, it doesn't impact the value). Explode is about the value, not the optionality or not of the query key.

Additional note about after a comment I saw on the cadl-ranch PR, if "explode" is used on a non-array parameter, it's just ignored. The way url template RFC is written, given people could use a union like string | string[] and therefore there are scenario when it may be possible that a primitive type is associated with "explode". This is ok, just the explode should be ignored (not a failure)


Updates to LIS/NCS pages

Updated Get-CsOnlineLisCivicAddress
Updated Get/Set-CsOnlineLisLocation

Docs Build status updates of commit 4e43865:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisCivicAddress.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineLisLocation.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisLocation.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@JohanFreelancer9

@get-itips @dariomws @tseward

Docs Build status updates of commit 73d85db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisCivicAddress.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineLisLocation.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisLocation.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Translation not found

Describe your issue here

Useful
Info

Versions
Rancher v2.3.3 UI: v2.3.25

Route
global-admin.clusters.index

It's easy to reproduce by switching to uk-ua language. Not sure why it will not fallback to English. cc @westlywright

@loganhz its because there were new translations path's added for this key, a new label child key was added which causes this bug. Basically if the key path does not terminate at that level is used to it doesn't know how to fallback. I've fixed that and also have a PR open for syncing the translations from crowdin.

The bug is reproduced with Rancher server rancher\rancher:v2.3.3
Change language to ru-ru language.

In Rancher server rancher\rancher:master-head version f3fbe1449
The fix does not work for zh-hant

@aaronRancher This was my bad, we typically no not maintain translations outside of the en-us & zh-hans, other translations are maintained by the community in crowdin. I made this fix as it was fast and easy but this is exactly why we don't take care of core maintained languages, it opens a large can of worms which we lack the time to wrangle. In the future we should only open and validate issues for translations in the maintained languages. Regardless I've made a fix to the zh-hant file as well since it was pretty easy and it should be available in latest2 shortly.

The bug fix is verified with Rancher server rancher\rancher:master-head version 88fcc20ad
The fix works with zh-hant:

The fix works with uk-ua:


Make CImageData a template class and take its backing memory from an ICPUBuffer

Turn CImageData into
template <class BufferType>
CSubImageData

where BufferType can either be IGPUBuffer or ICPUBuffer.
Then the CSubImageData can be backed by refcounted cpu memory or driver memory, then it has the necessary  features to not require the stupid dataAllocatedWithMallocAndCanTake as well carry out the GPU texture uploads (which are now only possible from a buffer thanks to vkCmdCopyBufferToImage).
And obviously API consistency.
This magically solves #35 as staged uploads from buffers will be the only way to update textures.
Possibly #34 will not be needed as the input CSubImageDatas will have all the parameters needed.

https://dashboard.genmymodel.com/projectProperties/_0uat8F4YEemkzeedQvutWw
We could add to E_FORMAT a new enum for the compatibility classes.

Note https://github.com/buildaworldnet/IrrlichtBAW/issues/79#issuecomment-487249613

Cannot be done yet as need Descriptor Sets to be done

Have a draft done


Fix db index and query

@JehandadKhan "ignoring instead of replacing" looks good. Does this PR change only binary cache's behavior?

@atamazov That is correct, only sql based binary cache

How was this tested?


The issue of not using point cloud sharing。

Can spatial anchor data be stored in a private cloud and shared with other users? I mean point cloud sharing without Oculus

This is not possible with our current SDKs. Is there a use case you would need that capability for?

Yes, due to the project, we can only use the LAN server to do multi-party collaborative MR, and we cannot access the external network. However, we have purchased more than 20 sets of quest3, which is very annoying, and I hope it can be changed

Unfortunately, we do not support that scenario with the current SDK. Thanks for letting us know this would be useful.


[OnlineMeeting&DEC.20]SeaTunnel community meeting Topic collect

CalvinKirs invites you to a meeting on Tencent Meeting
Meeting Topic: SeaTunnel Community Meeting
Time: 2022/12/20 20:00-20:30 (GMT+08:00) China Standard Time - Beijing
Click the link to join the meeting or to add it to your meeting list:
https://meeting.tencent.com/dm/8ugwruZHW2gk
#TencentMeeting：942-685-635
Copy this invitation and open in Tencent Meeting app (V2.13 or later) to join the meeting
Community user are very welcome to participate, if you have any issues wanna discuss, please leave the issue number:

Sync the process of 2.3.0 release prepare

Pull request sumit standard

ST-Engine test work

Refactor the starter mode

what's the plan of v2 sink hudi connector?


[DRAFT] Adding Save and Load logic skeletons

👍

This PR wasn't ready for review! 😝
(I forgot to mark it as a Draft in github, although the title does say [DRAFT])
This is a pretty unideal PR from me actually, that I wouldn't approve myself 🥇
Next time, here are some things you may ask:

To separate this into smaller PRs (Here, I do at least 5 things which should be their own PR: a tangential .gitignore adjustment, adding buttons to the UI, adding logic to handle saving for players, adding an end-of-level checkpoint AND adding support for new levels).
For me to explain the changes in detail.
For me to explain what inspired the changes as well!

Letting ya know because I will hold you to my unfair standards 😈 👹
I'll merge this anyway though because I'm sleepy, and we've had some slow progress on development otherwise 🦐

Still, thank you for checking it out with alacrity and approving so I can move fast ❤


SVG and Canvas have different results for "Candlestick shanghai index" chart in echarts example

I test "Candlestick shanghai index" chart in echarts example. This is the url "https://ecomfe.github.io/echarts-examples/public/editor.html?c=candlestick-sh". I click the "Download" button to save the html file into local. Then I compare the chart to render on canvas and svg.
The first result is the default html. It looks good.

I only make below changes to support svg in the html.
var myChart = echarts.init(dom, null, {renderer: 'svg'});

The svg chart has three issues different to canvas chart.
(1) Title "上证指数" is out of top range.
(2) The text data for xAxis are shown in the xAxis line. And the text data are not same in both results.
(3) The value "2445" is out of the ball.
Can anyone give some suggestions? Thanks.

Hi. What's the version of your SVG ECharts? I tried with the latest version and it's the same as canvas result.

      Hi. What's the version of your SVG ECharts? I tried with the latest version and it's the same as canvas result.

I just download the example from "https://ecomfe.github.io/echarts-examples/public/editor.html?c=candlestick-sh". It is using "".
I only make below changes to support svg in the html.
var myChart = echarts.init(dom, null, {renderer: 'svg'});
It still has these issues.


Always syntax only

Fixes #

@typescript-bot pack this

@mjbvz @minestarks @uniqueiniquity @amcasey @DanielRosenwasser @RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/38564#issuecomment-628309011 is build where syntaxOnly server can accept semantic commands as tsserver without --syntaxOnly also works as if it was passed in. This is on top of  #38561

This is pretty cool.

Maybe we should disable semantic diagnostics, since a lot of identifiers won't bind?

F12 is showing me entries from lib.es2015.*.d.ts - were we expecting those to get pulled in?

I'm having trouble wrapping my head around exactly how this will work if VS continues to send openExternalProjects, but I think I've convinced myself it's not a problem.

I'm excited - I think this will be a great experience during project load.  My main concern is that we might regress the syntax server during normal operation.  I think it's worth moving ahead and making targeted fixes if that turns out to be a problem.

My main concern is that we might regress the syntax server during normal operation.
Wont cancellation tokens help with that

Maybe we should disable semantic diagnostics, since a lot of identifiers won't bind?

Yes i didnt do that here intentionally here till we get some feedback .
I think other potential as compile on save and and similar.. Infact I think enabling selected ones is better approach than disabling few.. Eg completions, quickInfo, goto def,  questionably: find all refs

My main concern is that we might regress the syntax server during normal operation.

Wont cancellation tokens help with that

I expect the memory usage to increase, which could be poorly received by the division (and users, if they notice).  The effectiveness of cancellation is harder to predict because VS has (so far) limited usage of the syntax server to things that need to be "instantaneous" and cancellation may not be fast enough to retain that performance.

@typescript-bot pack this

@typescript-bot pack this


Heasarc speedup

Following this sciserver tutorial, and with much help from @zoghbi-a, I have changed the HEASARC_get_lightcurves function.  The old method was a for loop over an astroquery.heasarc search for each individual object.  The new method uses a pyvo tap query which cross matches a catalog of our targets with each HEASARC catalog of interest.
This is a much faster method when running at scale, and probably preferred by HEASARC rather than sending them 500K individual requests.
I do not know if this method will translate well to other archive searches:

Other archives may not allow table uploads to their tap queries (ZTF??).
It may not scale as well with much larger catalogs.  The HEASARC GRB catalogs we are querying are only a few hundred to a few thousand lines long, and therefore not representative of other light curve datasets.
other archives may require a login (Gaia??)

Thanks for the comments, I cleaned up the VOTable -> astropy table.  I agree it is much cleaner to not write output.


Add conceptual model #1952

Summary of the discussion
See #1952
Type of change (CHANGELOG.md)
Add

conceptual model

Workflow checklist
Automation
Closes #1952
PR-Assignee

[x] 🐙 Follow the Pull Request Workflow
[x] 📝 Update the CHANGELOG.md
[x] 📙 Add #'s to term tracker annotation

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

I'm sorry this commit message isn't particularly expressive, but I forgot to push my changes before pulling the merge and my programm did push and pull at the same time. So this last merge also contains the move and definition change you requested


Adding the swipe gesture

Adding proxy finger_swipe methods in the backends, only really implemented in Speculos for now (need >= v0.9.0)

GUI-specific implementations still need to be done (in another PR?)

Added an Center(Element) (position-only class, not tied to a layout or a use case).
The thing is, a "swipe" is a bit like a "touch", it is not attached to a specific layout or use case. Still, I feel like basic swipe should be usable from anywhere.
So I added a basic swipe like the touch, but also 2 more specific instructions: SWIPE_CENTER_TO_LEFT and SWIPE_CENTER_TO_RIGHT which I hope will embed 90% (100%? :crossed_fingers: ) of current use cases.
Changed the UseCase.TX_REVIEW scenario to use the swipe instead of the tap.

This may need some thinking, as this specific use case may be better having a "next" method rather than a "tap" one. And it would be our responsibility to implement either a swipe or a tap inside it, directly into the firmare module (it should be managed there afterall). But I don't had time to think of it more.

Tested on

monero tests

+++ b/tests/monero_client/monero_cmd.py
@@ -229,7 +229,7 @@ class MoneroCmd(MoneroCryptoCmd):
            instructions = get_nano_review_instructions(1)
        else:
            instructions = [
-                NavIns(NavInsID.USE_CASE_REVIEW_TAP)
+                NavInsID.SWIPE_CENTER_TO_LEFT
            ]

Ethereum tests - no changes as it is abstracted into the UseCase.TX_REVIEW scenario

This PR highlighted a bug in Speculos which will be fixed by this PR.

@xchapron-ledger that may be interesting yes, but as for the implementation that would require adding / updates in the navigators, scenarios and firmware positions. This PR seems good enough as it is, I'd prefer having additional features in another one.


Vue 3 datepicker with CDN

Hello! I'm new to vue and i'm trying to use the datepicker with CDN.
Currently i only got it working by using a template in the main js file.
Is this the right way? Is there a better way to use it?
Thanks in advance!
Codesandbox

@lefterisgiannaros Hello, if you use some bundler, using it as a npm package is recommended way.
What you want to check is local installation. You can check the tabs, depending on your needs.

@Jasenkoo Thank you for your fast reply!
I used the resources above but multiCalendars :multiStatic="false" isn't working.
Codesandbox


Implement the public methods in Object for dynamic proxy

Motivation:
The InvocationHandler implementation in ClientBuilder does not handle
the public methods in Object class: toString(), hashCode() and equals()
Whenever a user or a debugger attempts to call one of those methods, the
caller will observe an unexpected behavior from the InvocationHandler.
Modifications:

Extract the InvocationHandler implementation to a dedicated class:

ClientInvocationHandler

Implement the public methods in Object
Miscellaneous

Fix NPE in SimpleHttpRequest.toString() when content is null, which
can happen when a debugger tries to call toString() before
construction is finished
Fix NPE when the proxied method has no argument

Result:
Application does not fall apart even when it calls a public method
declared in java.lang.Object.

/cc @inch772 who might be interested in this change.


Use total ordering for floats?

In https://github.com/dada-lang/dada/pull/115 @nikomatsakis suggested dada might use a total ordering for floats.
The standard behavior of nans is a big source of frustration without much benefit. It would be convenient to get rid of it.
I myself don't understand the implications of defining floats to have a total ordering.

https://github.com/dada-lang/dada/pull/115

Implications I can think of:

Huge source of bugs and confusion gone

But:

Inconsistent with virtually every other language
Have to use somewhat slower hardware operations or compile things in somewhat slower way
May affect ability to SIMD-parallelize operations like [float] < [float]? Not sure

The last two points seem important.
There is one final unknown:

Does anybody want the IEEE behavior? I imagine that it was defined this way for a reason, that if you're doing dense numerical computation, it is useful to have NaN <= NaN (etc) be false, but I've only heard one person "stick up" for it to me in conversation, and quite frankly their argument was unconvincing. It seems to me that you very well might want NaN <= NaN to be false, but you equally well might want the opposite, it will very much depend on what you are doing with the result of that comparison. And if you have to think about NaN anyway than I suspect you could as well account for total ordering.


Office-ui-fabric-react version with drop 1.2

Category

[x] Question

The SPFx docs says to take an explicit dependency on office-ui-fabric-react v2.x. Drop v1.2 comes with v4.32.0 after running the yeoman generator.
Does that mean for drop v1.2 we should take a dependency on v4.x?

Also, if you take a dependency on 2.x with drop 1.2, it won't build.

I think the docs are behind. Drop v1.2 works fine for me with office-ui-react 4.32. As it is the new package version, I would update my dependencies to that. I updated my project with npm and it went sweet. I created a new "HelloWorld" with yo @microsoft/sharepoint to compare dependencies and stuff.

I can make it work as well, but it's important to keep docs up to date with drops, especially when static linking is recommended together with adding an explicit version of UI fabric. Ideally I would like the old way, where I didn't have to bundle in UI fabric as it was pre-loaded with SPFx.

@VesaJuvonen

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”


tar: Optimise memory usage

The previous untar logic would take into memory each tar file entry,
causing large files to increase the likelihood of concurrent
reconciliations to cause OOM.
This change forces the untar process to use a buffer when processing
tar file entries, causing the memory profile per operation to be
reduced. On benchmarks below, the memory consumption per operation
was reduced from 10mb to 0.24mb:
Benchmark_Untar-16        6  188662186 ns/op  10962682 B/op  19836 allocs/op
Benchmark_Untar_Limit-16  8  131385484 ns/op   1964667 B/op  19274 allocs/op

The biggest file within the tar file was 95mb in size.
Testing the changes on kustomize-controller by tracking memory consumption, the instances with the new changes (blue and green) peak at 29mb whilst the existing code (yellow) peaks at 75mb:

This PR also decommissions the untar package, so that the code does not need to be duplicated.
Should decrease the likelihood of: https://github.com/fluxcd/kustomize-controller/issues/725

We have the same issue in https://github.com/fluxcd/pkg/blob/main/http/fetch/archive_fetcher.go for large tarballs it runs into OOM during checksum before untar is called.


Different ContextMenu for children #23

Fixes issue #23
Event was bubbling up from child to the ancestor, causing the ancestral menu to display instead of the more relevant menu on the child.

Does this cause any side effects?

Not to my knowledge.
I guess if people have made components that make us of the event bubbling then it could.

Then this could cause severe disruptions like left-pad 😄

You can make it optional by passing a prop
something like
if (this.props.stopPropagation) {
   event.stopPropagation();
}

doen't this problem solved? I have the same question.child and parent both should show context menu, and they have different context menus,so I give the child and the parent component different identifier.But it always show the parent's context menu even if I right click on the child component.How can I stop propagation?

Apparently it does. Can you make this change in your local machine and please confirm? I'll merge this at once then.

It does't  work after I add the code event.stopPropagation();

Sorry, I write it in the file of src folder, so it does't work.It works when I write it in the file of modules.It works!

Awesome! I'll put it in next release