Upgrade library to net4.5

Forked over from https://github.com/morelinq/MoreLINQ/issues/128#issuecomment-173109354.
@atifaziz said:

I think we should move to .NET 4.5 but post 2.0 release

I'm not sure I fully understood, but that would break backwards compatibility for projects still targeting .net 3.5. Or was the issue really to add a new version targeting 4.5? I wonder if this issue has become moot due to netstandard1.0 is targeted? (at least IReadonlyCollection is present there).

If multi-targeting from a single project is easy then do we still need to make a call here? It was super easy with project.json and the dotnet CLI previews. It's not so smooth with VS 2017 but we're over that bump now, no?

If multi-targeting from a single project is easy then do we still need to make a call here?

I don't think so, but I was not sure. The only question is then if the netstandard1.0 targeting is sufficient or we should add a net45 target.

@fsateler Ah, I see what you're asking now. Since netstandard1.0 supports net45, I'd say we don't need to target net45 specifically or have a separate build for it.

Ah, I see what you're asking now.

Sorry for being unclear. I should have included more context. Reason is to start adding optimizations for IReadonlyCollection<T>

Since netstandard1.0 supports net45, I'd say we don't need to target net45 specifically or have a separate build for it.

Excellent. I'm closing this as 'already-implemented' then.

@fsateler Oh and note that the test project targets net451 (and should ideally even target .NET 4.5.2 since 4.0-4.5.1 are zombies), which is a completely arbitrary decision. We build for .NET 3.5 but test on CLR 4. I think we can question that if ever some one comes kicking and screaming about behavioral differences observed between the two CLR versions.

Oh and note that the test project targets net451 (and should ideally even target .NET 4.5.2 since 4.0-4.5.1 are zombies), which is a completely arbitrary decision.

I have created a PR to migrate to 4.5.2. (#271, lets see if tests pass on all platforms)

We build for .NET 3.5 but test on CLR 4. I think we can question that if ever some one comes kicking and screaming about behavioral differences observed between the two CLR versions.

Yes, I agree. However, it appears that the .net framework build of the test project links against the .net 3.5 version of the library. What is the process for selecting the correct build to link against?

What is the process for selecting the correct build to link against?

The decision is different for apps and libraries. Libraries get hosted in apps so the whole end-of-life of .NET versions affects apps the most. Libraries target based on API availability, so for example, System.ValueTuple requires 4.5 and if we ever want to benefit from C# tuples in MoreLINQ then we'd have to add or set the base target to 4.5. The test project used to be a library that was run by an NUnit runner. It had to be turned into a self-hosted executable test runner as part of #261 but I'm hoping that's just temporary. As a simple test runner, I'm less concerned about .NET Framework lifetimes as I expect CLR 2 & 4 to be fairly compatible for the kind of project that is MoreLINQ. That's why the decision there was somewhat arbitrary (why even 4.5.1?). The test project links against the library that targets 3.5 but eventually the library is being hosted by CLR 4 so not sure what the concern there is about alignment. Do you think we need a more formal process?

The test project links against the library that targets 3.5 but eventually the library is being hosted by CLR 4 so not sure what the concern there is about alignment. Do you think we need a more formal process?

The problem is that because the full framework test variant is linked against the library built for .net 3.5, and thus it lacks the IReadonlyCollection optimizations (which I'm currently working on). This suggests to me that projects targeting the full framework will similarly lack such optimizations.

@fsateler You said it clearly in the beginning:

Reason is to start adding optimizations for IReadonlyCollection<T>

Somehow I lost that and digressed into just reiterating the current state of affairs. My bad. So it seems we'll have to add net45 as a target for the library. I guess the question is then do we leave the net35 target untested? Should we drop net35 altogether? We can always add it back if it turns out to be a bad call. 🤔


[Bug] Navigate back from deployments

Steps

Kubectl get deployments
Navigate to the pod

Expectation
I should be able to navigate back to the deployment view, but right now, I can't.

I looked at your fork and it seems to be missing this: https://github.com/Ramilito/kubectl.nvim/blob/4bd00fd6778bdf3fe1664adc800d791acefb0ae5/ftplugin/k8s_pods.lua#L54

Isn't backspace working for that? I just tried it and worked fine, could it be a binding issue?

You're correct. I just didn't know there was a keybinding for that


Look into flaky test

Integration test fails randomly. Here is an example of a failed test output
Setting up Datastore Emulator...
[datastore] The health check endpoint for this emulator instance is http://localhost:8081/Jul 17, 2020 5:15:23 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:15:23 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
[datastore] Jul 17, 2020 5:15:25 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:15:25 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
FAIL tests/integration/commits.test.ts
  ● Commits endpoints › GET /commits › Should filter by listingId query param
    expect(received).toEqual(expected) // deep equality
    - Expected  - 7
    + Received  + 0
    @@ -4,13 +4,6 @@
          "createdAt": "2020-06-23T03:34:00.000Z",
          "customerId": 1,
          "id": 1,
          "listingId": 1,
        },
    -   Object {
    -     "commitStatus": "ongoing",
    -     "createdAt": "2020-06-29T03:34:00.000Z",
    -     "customerId": 2,
    -     "id": 2,
    -     "listingId": 1,
    -   },
      ]
      41 |
      42 |       expect(res.status).toBe(200);
    > 43 |       expect(res.body).toEqual(expectedCommitData);
         |                        ^
      44 |     });
      45 |
      46 |     test('Should filter by customerId query param', async () => {
      at tests/integration/commits.test.ts:43:24
      at fulfilled (tests/integration/commits.test.ts:20:58)
[datastore] Jul 17, 2020 5:15:26 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:15:26 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
PASS tests/integration/customers.test.ts
Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 6 passed, 7 total
Snapshots:   0 total
Time:        2.515 s
Ran all test suites.
Tearing down Datastore Emulator...
[datastore] Jul 17, 2020 5:15:26 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:15:26 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected non-HTTP/2 connection.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
error Command failed with exit code 1.

Here is an example of a passing test output:
Setting up Datastore Emulator...
[datastore] The health check endpoint for this emulator instance is http://localhost:8081/Jul 17, 2020 5:22:14 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:22:14 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
[datastore] Jul 17, 2020 5:22:16 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:22:16 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
PASS tests/integration/commits.test.ts
[datastore] Jul 17, 2020 5:22:17 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:22:17 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
PASS tests/integration/customers.test.ts
Test Suites: 2 passed, 2 total
Tests:       7 passed, 7 total
Snapshots:   0 total
Time:        2.666 s
Ran all test suites.
Tearing down Datastore Emulator...
[datastore] Jul 17, 2020 5:22:17 AM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Jul 17, 2020 5:22:17 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected non-HTTP/2 connection.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?

Looks like this is not happening anymore, closing this!


Add slash command support

Summary
Adds slash command support.
Ticket Link
https://mattermost.atlassian.net/browse/RN-272
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Added or updated unit tests (required for all new features)
[ ] All new/modified APIs include changes to mattermost-redux (please link)
[x] Has UI changes
[x] Includes text changes and localization file updates

Device Information
This PR was tested on:
iPhone 8 iOS 11
Galaxy s7 - Android 6.0 API 23
Screenshots

@enahum changes made

@enahum @hmhealey @mkraft once approved, don't merge. I'll update yarn to latest redux and merge.

@enahum @mkraft changes made.


sync master with develop

Pull Request Test Coverage Report for Build 186

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 0.0%

Files with Coverage Reduction
New Missed Lines
%

eventmanager/urls.py
5
0.0%

eventmanager/settings.py
6
0.0%

Totals

Change from base Build 159:
0.0%

Covered Lines:
0

Relevant Lines:
38

💛  - Coveralls


real life ci example

Hello! Thanks for this great tool. I just got here by reading the excellent article on medium. I am considering setting up this project into our ci integration, but I could not figure out how to get a previous stats.json from a previous build to compare with the current stats.json? Do you have a real-world example with Github actions, for instance?
I can think of many possibilities, but I wonder if you already have a GitHub workflow ready to go?
Thank you.

Hi, sorry for the big delay on response. I'll have to get back to you on it as I'm on holiday at present and only thought to look at the repo now.
Off the top of my head it's more that you would need a way to pull the build artifact in yourself into the PR branch and then compare it. I would have to do some investigating to see how to best write a GitHub action that would take care of this for you as it isn't present functionality.

hi, sorry i haven't gotten back sooner. the reason i didn't originally build a github action for this is because it would require a fair amount of setup and present actions like the upload-artifact action don't support working across branches. in essence you'd need to work out how to store the stats and fetch it back again. in a corporate/enterprise environment where you have your own way of storing artifacts, it becomes a lot easier, but there is still a bunch of know how per individual project setup (such as where does the output of the stats end up to then upload it to somewhere).


Add dead-letter queue for c7n-s3-encrypt?

Add a dead-letter queue for the c7n-s3-encrypt lambda.
See https://github.com/capitalone/cloud-custodian/pull/1564.

Since the c7n-s3-encrypt lambda gets created per bucket region and it looks like the DLQ SNS topic or SQS queue has to be in the same region as the lambda we would need a way of configuring the DLQ per-region.
For example:
  - name: s3-attach-encrypt
    resource: s3
    filters:
      - type: value
        key: Name
        value: "test-bucket"
        op: eq
    actions:
      - type: attach-encrypt
        dlq-arn:
          us-east-1: "arn:aws:sns:us-east-1:0000000000:encryptdlq"
          us-west-2: "arn:aws:sqs:us-west-2:0000000000:encryptdlq"

Closing this as S3 default encryption should deprecate the need for c7n-s3-encrypt.


[PR] - Issue-#119 :  Design and Integrate Custom Logo Across Website

name: Pull Request Template
description: Template for submitting a pull request
title: "[PR] - Design and Integrate Logo across Website"
labels:  #119
assignees: Swati-bs

Description
This pull request adds a newly designed logo to the website, enhancing brand identity and consistency across all pages. The logo is integrated in the header and footer sections, as well as any other relevant areas for a cohesive user experience.
Related Issue
Resolves Issue    #119
Type of Change

[ ] Bug fix
[x] New feature
[ ] Enhancement
[x] Documentation update

Checklist

[x] I have read the contributing guidelines.
[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have updated the documentation (if applicable).

Additional Context
The logo implementation includes responsive design, cross-browser compatibility checks, and accessibility improvements with alt text for screen readers.
https://github.com/user-attachments/assets/846a4438-3e0b-488d-85bb-5e53f1febf4a

Can you please assign a level to Issue #119? The issue has already been fixed, and my changes have been successfully merged via PR #144. However, the level hasn’t been assigned yet, and my name is not visible on the leaderboard. Please assign the appropriate level so my contribution is properly recognized.

add labels please @thestuti


Exec implementation

This also has some other minor refactoring related to that. Commits are well split up for reviewing ease.

Manually tested after merging https://github.com/kubernetes/kubernetes/pull/36020 and https://github.com/kubernetes/kubernetes/issues/34987 into my Kubernetes.

Rebased on top of #48 and #57 and should only be merged after those two are.
Works with upstream k8s with https://github.com/kubernetes/kubernetes/pull/36253 merged (which is currently LGTM).
cc @squeed, afaik this is good to go.

rebased now that all dependencies are merged

Overall seems good, thanks @euank !

Replied/addressed your comments, LGTY?

LGTM


Update cats-effect-std to 3.0.0-RC2

Updates org.typelevel:cats-effect-std from 3.0.0-M5 to 3.0.0-RC2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.0.0-M5).
You might want to review and update them manually.
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect-std" } ]

labels: library-update, semver-pre-release, old-version-remains

#4471


Fix Android replay check so we can record from APKs.

A couple of specific comments above. I'm not sure what the purposes of the first commit is, the second one could probably be simplified to a common path using existing functions.
Also for commits - please stick to the commit message format so that the history remains easy to read. Apart from any other changes, you'll also need to make sure that clang-format is applied so that the failing travis build above turns green.

Lets just merge this 1 commit for now.


Ignore set_time_limit() errors

We have a customer whose hosting environment has a custom PHP module installed, which doesn’t allow set_time_limit(0) to be called, even though the function exists. Ignoring the error with @ has proven to work for them.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

That is a bit controversial. Any function could be "checked" like that. We can not add checks everywhere. In addition, there is a standard disable_functions and there is already a check for it.

Since it's very non-standard environment, I wonder if there is a workaround for it?

For some context, it's a custom PHP extension called "phplimiter" on a shared hosting environment.
It does allow set_time_limit to be called, but it has a range restriction on what the values could be - in this case, between 1-180.
Since 0 is out of that range, a Yii ErrorException is raised.

@rob006 have you encountered such restrictions as well?

@rob006 have you encountered such restrictions as well?

No, but since we already have check for unavailable set_time_limit(), we could extend it to more cases.

@rob006 All good here?

Merged. Thanks!


Updating tutorial-your-first-web-api.md to use VS 2017

This PR is a part of WIP of task list in #3474 to update some ASP.NET Classic related pages to use Visual Studio 2017, as agreed in proposal #3452 (closed).
This PR is focusing on the updating MD page of tutorial-your-first-web-api.md.
This is the original published docs page:
https://docs.microsoft.com/en-us/aspnet/web-api/overview/getting-started-with-aspnet-web-api/tutorial-your-first-web-api
I also have updated screenshots of ASP.NET Web API 2 in VS 2017, and updated the sample code to point to my sample code in MSDN Code.
Some images are left, especially the screenshots of the IE browser displaying the running app of the Web API sample.
Please review.

@eriawan,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@RickAndMSFT @tdykstra could you please review?

@eriawan  wow, looks great!


Incorporate Familiarisation Tutorials

Subject of the issue
The cookiecutter tool suite is very complex and some features are not obvious at first glance.
Your environment

N/A

Steps to reproduce
Directly connect to the bokeh application.
Expected behaviour
The features of the tool and their purposes ought to be described.
Actual behaviour
Users are not able to expliot the toolset.

see above commit


Feat/custom generator

:tada: This PR is included in version 1.19.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


error calling pack_padded_sequence when using pytorch 1.7

Hi,
I ran the tools/train.py using python 3.7 and torch 1.7, and the program throws the following exception:
 ......
  File "/home/self-critical.pytorch-master/captioning/models/AttModel.py", line 34, in sort_pack_padded_sequence
    tmp = pack_padded_sequence(input[indices], sorted_lengths, batch_first=True)
  File "/home/library/miniconda3/envs/py3.7/lib/python3.7/site-packages/torch/nn/utils/rnn.py", line 244, in pack_padded_sequence
    _VF._pack_padded_sequence(input, lengths, batch_first)
RuntimeError: 'lengths' argument should be a 1D CPU int64 tensor, but got 1D cuda:0 Long tensor

I searched about this exception and found that it is related to this issue: https://github.com/pytorch/pytorch/issues/43227
It seems that PyTorch 1.7 requires the lengths to be a CPU tensor when calling pack_padded_sequence, and I think that is controversial, too.
Though this is caused by the new version of PyTorch (this weird behavior is not even documented), would you consider adding some workaround to improve the compatibility of the code?

Thanks for the notice. For now you can simply add .cpu() I believe.


[BUG] The browser displays two loading bars when opening web page "in app "

When opening an url "in app" the browser shows two loading bars
The browse should display only one loading bar .

Device: Realme x7 Max
Android Version : A11
Kiwi Browser Version 90.0.4577.18

Duplicate of #79 . Please close this issue @edward5375


Download/Installation Fail Integration: 500 Internal Server Error Server got itself in trouble

What version of Music Assistant has the issue?
2023.2.2
The problem
Downloadet via HACS and tryed to install the Integration and got this error:
Der Konfigurationsfluss konnte nicht geladen werden: 500 Internal Server Error Server got itself in trouble
(It says like the configuration flow could not be loadet)
I read that its solved by now on that thread: https://github.com/music-assistant/hass-music-assistant/issues/1143
Idk am i stupid or is that a bug
How to reproduce
Downloadet via HACS and tryed to install the Integration and got this error
Relevant log output
idk where do i get further logs than the error message?
Additional information
thanks for your work :)
What version of Home Assistant Core are your running
2023.9.3
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Raspberry Pi

As per that thread that you linked make sure you are installing the BETA version of the integration

Im dumb im sorry thanks a lot :)


apparently blows up with just-released PhpStorm 2916.2

Had just started the fresh JetBrains IDE. Also pushed Migrations button newly showing. Maybe  that was yours?  Yii 1 is involved in this project. Yes, that appears to be the point -- restarted PhpStorm and got the stack trace again.
class com.yiistorm.elements.MigrationsToolWindow$1$1 overrides final method cancel.()V
java.lang.VerifyError: class com.yiistorm.elements.MigrationsToolWindow$1$1 overrides final method cancel.()V
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at java.lang.ClassLoader.defineClass(ClassLoader.java:642)
at com.intellij.util.lang.UrlClassLoader._defineClass(UrlClassLoader.java:268)
at com.intellij.util.lang.UrlClassLoader.defineClass(UrlClassLoader.java:264)
at com.intellij.util.lang.UrlClassLoader._findClass(UrlClassLoader.java:233)
at com.intellij.ide.plugins.cl.PluginClassLoader.a(PluginClassLoader.java:119)
at com.intellij.ide.plugins.cl.PluginClassLoader.a(PluginClassLoader.java:73)
at com.intellij.ide.plugins.cl.PluginClassLoader.loadClass(PluginClassLoader.java:62)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at com.yiistorm.elements.MigrationsToolWindow$1.run(MigrationsToolWindow.java:223)
at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:635)
at com.intellij.openapi.progress.impl.CoreProgressManager$3.run(CoreProgressManager.java:170)
at com.intellij.openapi.progress.impl.CoreProgressManager.a(CoreProgressManager.java:494)
at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:443)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:54)
at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:155)
at com.intellij.openapi.progress.impl.ProgressManagerImpl$1.run(ProgressManagerImpl.java:128)
at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:308)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

on wich OS?

Eh, do you install plugin from repository?

I will fix this, as soon as i can

Actually there is a lot of extensions which are crashed after this update so I still didn't do it and I think I will not ;)

Thanks, Mazx - appreciate to hear.
An additional clue is that I started PhpStorm this evening, and did not push the unusual new Migrations button. The same stack trace occurred a moment after starting, so I think that is the actual instigator.
Just a quick look at the trace seems to suggest JetBrains may have newly declared a cancel method final which you want to override -- it's been a long time since I did Java, but this is kind of generic. So it may be their fault, but talking to them ought to turn up a middle way, one that works for both.
Best fortune  on it,
Clive


Close multiple screens

Description
Is there any way to check did i already opened the window?
When we close second window by clicking x, in our app we don't have that event happened and that window is closed. So we can't predict do we need to update or open the window in that case.
Steps to reproduce
/
React Native Version
0.73.5
Affected Platforms
Runtime - Android, Runtime - iOS
Output of npx react-native info
/

Stacktrace or Logs
/

Reproducer
/
Screenshots and Videos
No response

Hey, thanks for opening the issue.
It's a valid feature request to add an event listener on a given window to know when its state changes. Let's keep this issue open until it gets implemented


Move OSSF Checks to OSP

Similar to #214

Codecov Report

Merging #222 (3d14f52) into main (7edf704) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   93.03%   93.03%
=======================================
  Files          42       42
  Lines        3386     3386
  Branches      374      374
=======================================
  Hits         3150     3150
  Misses        236      236

Components
Coverage Δ

protocol
93.32% <ø> (ø)

http-client
95.27% <ø> (ø)

http-server
90.87% <ø> (ø)


Fix bug in install script

If exporting CXX=hipcc and then calling the install script, this will result in googletest being built with CXX compiler (in this case hipcc) but hipsparse will be built with whatever c++ compiler cmake finds (the install script changes what CXX is). This means then that if googletest is built with hipcc it will generate a position dependent static library for googletest. Then when running the install script cmake will likely pick up either g++ or c++ compiler to build hipsparse. This is fine except that these compilers will build the hipsparse-test executable using position independent code. SInce our googletest static library is not position independent then this causes an error saying we must compile googtest with fPIC flag when linking. This proposed change makes it so that the compiler defaults to whatever is set by CXX so that everything is built with the same compiler. Additionally it adds the option to explicitly set the compiler used (useful for example if you are not exporting CXX variables outside the install script but still want to choose what c++ compiler you use)

Curious @daineAMD if you have seen this on hipBLAS?   We should probably have a standard default compiler for hip libs if CXX env is not set.   Not sure if we build googletest won't your cmake find it and then you could still get the mismatch?   I'm leaning toward dependencies that don't need hipcc get built without it so they are more "standard" whatever that means.   Another item for the library standardization table.

Curious @daineAMD if you have seen this on hipBLAS? We should probably have a standard default compiler for hip libs if CXX env is not set. Not sure if we build googletest won't your cmake find it and then you could still get the mismatch? I'm leaning toward dependencies that don't need hipcc get built without it so they are more "standard" whatever that means. Another item for the library standardization table.

In the case of hipsparse we dont need hipcc at all as we dont have kernel code (it is important though that it is still an option as I was told Gibraltar does not have gcc available and they are expecting to use hipcc). For example when I build hipsparse from source, I don't export CXX first. Instead I just run the install script. Doing so results in cmake using /usr/bin/c++ compiler for both googletest and hipsparse. My thinking here is that using one compiler for googletest and another for hipsparse can risk running  into bugs because of how the different compilers were configured. For example g++/c++ I think have PIE code turned on by default, but I think one could build these compilers so that it is turned off. What I am trying to achieve in this PR is have whatever compiler the user has chosen be the compiler used for both googletest and hipsparse in the hopes it avoids any possible configuration issues when linking. Not sure if this is the best direction or not though so open to suggestions. I suspect hipblas has not had a bug filed about this possibly because QA is using your --compiler flag to set hipcc to be the compiler used for both googletest and hipblas so there is no inconsistency.

Good catch :+1:


mortgage support multiple dataset formats

change mortgage sample class to support datasets format csv/orc/parquet
In the mortgage ETL sample test class, there are interfaces supporting the datasets format csv/orc/parquet.
The main entry only ran with parquet format before.
As we need to run mortgage ETL with the csv dataset, related issue: https://github.com/NVIDIA/spark-rapids/issues/1659, so extend it for the datasets format csv/orc/parquet.
The mortgage ETL test sample, seems do not need unit tests against it.

build

build

build

build

build

build

Let's move it to 0.5.

change to target branch-0.5

build


Errors out when trying to run migrate command on an actual server

https://www.dropbox.com/s/3ojtcqs691yp4zg/Screenshot 2015-08-06 15.36.15.png?dl=0

Would love to use this software, but having a terrible time getting it running on our domain. Sort of got it running locally, but there seems to be some issues with mongo permissions.

When I try and actually run the site, I hit this error:
[gulp] [nodemon] starting node app.js
Server started, listening on <IP_ADDRESS>:8123
MongoError: not authorized for query on ucros_development.sessions
at Function.MongoError.create (/home/friendsllc/bff.co/pulse/node_modules/express-session-mongo/node_modules/mongodb/node_modules/mongodb-core/lib/error.js:31:11)
at queryCallback (/home/friendsllc/bff.co/pulse/node_modules/express-session-mongo/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:267:34)
at Callbacks.emit (/home/friendsllc/bff.co/pulse/node_modules/express-session-mongo/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:95:3)
at null.messageHandler (/home/friendsllc/bff.co/pulse/node_modules/express-session-mongo/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:243:23)
at Socket. (/home/friendsllc/bff.co/pulse/node_modules/express-session-mongo/node_modules/mongodb/node_modules/mongodb-core/lib/connection/connection.js:262:22)
at Socket.emit (events.js:107:17)
at readableAddChunk (_stream_readable.js:163:16)
at Socket.Readable.push (_stream_readable.js:126:10)
at TCP.onread (net.js:529:20)

I've actually figured this part out on my own.


For JedisPool should add constructor method like default db index

In my project ,we need to add a future like  select default db index,
but in Jedis I can't find a method or constructor method to config my db index,
for Jedis select() method , it means always select zero db index
so , I will add a constructor method to config default db index :D

sorry for my poor English  not my motherlanguage -_-!!

The constructor already exists
https://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/JedisPool.java#L23-L26

@marcosnils but I can't find a pram to set default  redis database index


[CS2103T-T12-1] Sellah

Sellah displays a list of products bought by clients, which helps online sellers on Shopee to keep track of the products sold. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.

Codecov Report

Merging #30 (fd5af46) into master (ba53b8c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/Main.java
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba53b8c...fd5af46. Read the comment docs.


Project Meeting 4:30pm @ Patrick's Office, Mar 20

Meeting will likely be in the same location as the talk on Wednesday!

David will handle #11 and #12 for this next part.  I'll take care of #24 as well as continue on #10.


Slow startup in version 1.82

Type: Performance Issue
At some point with VS Code version 1.82 introduced a regression, a visibly slow startup 3-5s even with an empty workspace. Initially noticed with VS Codium, checked with VS Code OSS build as provided by Arch linux package.
VS Code version: Code - OSS 1.82.2 (abd2f3db4bdb28f9e95536dfa84d8479f1eb312d, 2023-09-19T15:11:58.113Z)
OS version: Linux x64 6.1.55-1-lts
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz (8 x 3300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
31.11GB (25.66GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Process Info
CPU %	Mem MB	   PID	Process
    1	   159	  5306	code-oss main
    0	    64	  5309	   zygote
    0	   191	  5339	     gpu-process
    0	    64	  5310	   zygote
    0	     0	  5312	     zygote
    0	   191	  5366	window [1] (Welcome - Code - OSS)
    1	    96	  5716	window [2] (Issue Reporter)
    0	    64	  5348	   utility-network-service
    0	    96	  5416	shared-process
    0	    96	  5417	fileWatcher [1]
    0	   127	  5438	extensionHost [1]
    0	    64	  5467	     /usr/lib/electron25/electron /usr/lib/code/extensions/markdown-language-features/server/dist/node/workerMain --node-ipc --clientProcessId=5438

Workspace Info
;

Extensions: none

Startup Performance as reported by VS Code.
Startup Performance.md

Thanks for the perf marks, can you also provide the following trace

Closing all running instances of VSCode
Start a new instance with the following arguments code --trace --trace-category-filter="base,benchmark,browser,ipc,latency,mojom,content,startup,toplevel,v8,navigation,disabled-by-default-base,disabled-by-default-lifecycles,disabled-by-default-mojom,disabled-by-default-network"
Once the editor is fully loaded, open command palette  and run Developer: Stop Tracing, this will generate a trace and provide you the path at which the trace was saved. Attach it to this issue thread.

Attaching trace as per @deepak1556 request/instructions.
code-oss-64RbRvVq.trace.txt.gz

Thanks for the logs, it shows a similar case to https://github.com/microsoft/vscode/issues/192493#issuecomment-1731229132

Try this:
code --disable-gpu --disable-software-rasterizer


Use random song?

Do you know if it is possible to have the alarm select a random file from the sounds folder when the alarm goes off?
I have been looking into the code but I know very little with regards to javascript so I haven't been able to find a way.
Thanks for making such an awesome module!

you would have to scan for all files and then choose a random one or provide a list with all files and then choose a random one


Create 404 page

Create page element for 404 page.  Designs coming from Kimmy.

Design Assets: https://drive.google.com/drive/folders/1aNLrRaRiW4eZVz7jcxImRyvTt0WNN5-u?usp=sharing
Text:
Oh no! This page has bolted away! Don’t worry, we’ll get you home.

Desktop Design (481px+)
Specs

Mobile Design
Specs

I am reopening this issue for Kimmy to review. It looks fine to me.

Horse image breaks the frame on mobile and allows side to side scrolling beyond edge of website. This should not happen. Need to fix that before I can sign off on this.


Stub of spec for header accumulator within the history network

We support the following functionality:

retrieval of an individual "full" epoch accumulator addressed by it's SSZ hash
retrieval of a snapshot of the latest "master" accumulator.

For retrieval of an individual epoch accumulator, lets use this as the content key and serialization format.
selector = 0x03
content-key  = Container(epoch-hash: Bytes32)
content      = ssz_encode(epoch_accumulator)

For retrieval of "master" accumulator lets use this as the content key.  The accumulator is optionally referenced by its hash.  The value null is used to request the "latest" version of the accumulator.
selector = 0x04
content-key  = Container(master-hash: Union[null, Bytes32])
content      = ssz_encode(master_accumulator)

re: master acc
Is a node supposed to be aware of the "latest" version of the accumulator (i.e. the mapping of "latest" to some master-hash)? If a node receives a FindContent request for the "latest" accumulator, does the node immediately return the latest version of the accumulator that it itself holds, or what is the lookup for "latest"?

Is a node supposed to be aware of the "latest" version of the accumulator (i.e. the mapping of "latest" to some master-hash)?

Yeah, I think that is how it is supposed to work. Each node should be able to access its latest master accumulator without the need for the hash. As the requesting node just wants "some" recent accumulator, not knowing the hashes (It might have figured it out though through information from ping/pongs).

return the latest version of the accumulator that it itself holds, or what is the lookup for "latest"

It returns the latest version of the accumulator that it holds. If it has none, it should probably return empty? Lookup does not make much sense imo, as every node will potentially have this data. The originally requesting node can just ask any other node in the network itself.
Regarding the proposed content-key definitions. I'd suggest to drop the Container for the master accumulator content key and have directly the Union. If Container is needed eventually for some reason, it should probably go inside the Union. We should also call it None instead of null as that is the naming in SSZ.

I agree that we should be consistent, and thus if the chainId is in there for header/body/receipt, it should be in there for the accumulators also.
However, I remember there was a discussion about having mainnet and testnet data always provided through separated networks (we don't even need testnet data for now). So maybe we can get rid of the chainId field because of this and the separation could be made elsewhere. Haven't thought this through yet though. (Ideally the portal protocol layers would not be polluted with nodes from different networks).
I like less the idea of using an all zeroes hash for latest accumulator. Using an SSZ Union is  more clean and more clear imo (and it also results in a smaller key, but that matters less).


Provide peer information in Port properties

The following peer information should be made available for various transports, using the Port GetProp() API that was integrated with #66 and #68.
remote IP & port number :  tcp, tcp+tls, ws, wss
remote cert if present: tcp+tls, wss
peer credentials (UNIX only): ipc
remote supplied Origin header: ws, wss
These will be very very useful in fleshing out the use case(s) for the Port API.

So UNIX creds is hard.  Because Go doesn't expose getpeerucred() (or whatever the equivalents are on various platforms.)  There does seem to be something there for Linux, but only for Linux.  That's disappointing actually.  With illumos/Solaris we have rich APIs for this at the C layer.


Can't mock Seata Server normally under Seata 1.6.1

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

I noticed a unit test related issue in https://github.com/apache/shardingsphere/issues/21347 while trying to collect GraalVM reachability metadata for seata-all. Can't mock Seata Server normally under Seata 1.6.1.

Minimal reproducible unit tests and reproduction steps are at https://github.com/linghengqian/mock-seata-sever-test . At the same time, mock-seata-v142 is the unit test of seata-all:1.4.2, and mock-seata-v161 is the unit test of seata-all:1.6.1.

Ⅱ. Describe what happened
If there is an exception, please attach the exception trace:
[ERROR] 2023-02-15 12:44:06.866 [main] i.s.c.r.netty.AbstractNettyRemoting - wait response error:null ,cost: 30001 ms,ip:/<IP_ADDRESS>:8891,request:timeout=30000,transactionName=default

io.seata.core.exception.TmTransactionException: RPC timeout

	at io.seata.tm.DefaultTransactionManager.syncCall(DefaultTransactionManager.java:97)
	at io.seata.tm.DefaultTransactionManager.begin(DefaultTransactionManager.java:53)
	at io.seata.tm.api.DefaultGlobalTransaction.begin(DefaultGlobalTransaction.java:114)
	at io.seata.tm.api.DefaultGlobalTransaction.begin(DefaultGlobalTransaction.java:95)
	at com.lingh.SeataATShardingSphereTransactionManager.begin(SeataATShardingSphereTransactionManager.java:85)
	at com.lingh.SeataATShardingSphereTransactionManagerTest.assertBeginTimeout(SeataATShardingSphereTransactionManagerTest.java:96)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: java.util.concurrent.TimeoutException: null ,cost: 30001 ms
	at io.seata.core.protocol.MessageFuture.get(MessageFuture.java:65)
	at io.seata.core.rpc.netty.AbstractNettyRemoting.sendSync(AbstractNettyRemoting.java:199)
	at io.seata.core.rpc.netty.AbstractNettyRemotingClient.sendSyncRequest(AbstractNettyRemotingClient.java:187)
	at io.seata.tm.DefaultTransactionManager.syncCall(DefaultTransactionManager.java:95)
	... 36 more

Ⅲ. Describe what you expected to happen

All unit tests should be fine.

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Execute the following commands for comparison in Ubuntu 22.04.

sudo apt install unzip zip curl sed -y
curl -s "https://get.sdkman.io" | bash
source "$HOME/.sdkman/bin/sdkman-init.sh"
sdk install java 22.3.1.r17-grl
sdk use java 22.3.1.r17-grl
sdk install maven

git clone git@github.com:linghengqian/mock-seata-sever-test.git
cd ./mock-seata-sever-test/

cd ./mock-seata-v142/
mvn clean test

cd ..
cd ./mock-seata-v161/
mvn clean test

Ⅴ. Anything else we need to know?

I'm not sure if there's anything that needs to be changed as I don't see a particularly prominent PR for the Seata 1.5.1 milestone. In fact, this part of the unit test of ShardingSphere has failed since Seata 1.5.1. The unit tests for Seata 1.4.2 are fine, but the unit tests for Seata 1.6.1 are failing.

Ⅵ. Environment:

JDK version : 17
Seata version:  1.6.1
OS : Ubuntu
Others: null

The above information can not see the problem, because 1.4.2 to 1.6 did not make major adjustments to the rpc module, and your error is rpc timeout, you should check whether your network can connect to tc

@a364176773 I would like to know what information I can refer to? I didn't see any special configuration for RPC in the https://github.com/linghengqian/mock-seata-sever-test I provided. I just mocked a Seata Server using netty classes, did any big changes happen between Seata 1.4.2 and Seata 1.5.1?

No, this can be proven by running a sample from 1.4.2 to 1.5.1 without mock

No, this can be proven by running a sample from 1.4.2 to 1.5.1 without mock

If you are referring to https://github.com/seata/seata-samples/tree/4e4a579aa7d7866b1a786f5d347c2b333e1bb0ec , then I am even more confused, the latest commit is using Seata 1.4.2 for the example, not seata 1.6.1. I previously manually update seata-example to seata-all 1.6.1 and see errors similar to RPC Timeout.

@linghengqian I have repeated this question, and I will give you the conclusion later.

@linghengqian In the past TM and RM messages were sent to TC by default using merged MergedWarpMessage messages.In version 1.6.x, TM messages are no longer merged by default for performance reasons, including: GlobalBeginRequest, GlobalCommitRequest, and GlobalRollbackRequest.
Of course, there is another way to solve the problem without changing the code at all, by adding a single line of configuration.
seata.transport.enable-tm-client-batch-send-request=true

@slievrly  Thank you very much for your reply! Can I close the current issue now?

@linghengqian Through this question, I realized that we needed to maintain our own mock-server to ensure version compatibility. I've had a quick look at the mock-server code you've written, and I think  you  can contribute an original version of mock-server if you want. Are you interested ？

@linghengqian I noticed that you are doing something related to GraalVM, and Seata is also doing it. We can communicate with each other about the progress. #5234

@linghengqian Through this question, I realized that we needed to maintain our own mock-server to ensure version compatibility. I've had a quick look at the mock-server code you've written, and I think you can contribute an original version of mock-server if you want. Are you interested ？

This MockServer class comes entirely from Apache ShardingSphere's unit tests, so I don't really feel like I have experience perfecting this class. If possible, I would like it to be done by other friends.

@linghengqian I noticed that you are doing something related to GraalVM, and Seata is also doing it. We can communicate with each other about the progress. #5234

I browsed #5234 and realized I might not be able to help.

#5234 involves Spring Framework classes, which I tried my best to avoid when submitting GraalVM reachability metadata at https://github.com/oracle/graalvm-reachability-metadata , because Spring's Maven Plugin/Gradle Plugin added Task prevents users from collecting the GraalVM reachability metadata subset of the Conditional form.

I've never directly observed Spring's handling of AOT. #5234 doesn't seem to have fully passed CI, nor is nativeTest executed during the CI phase. If it is necessary for the library maintainer to actively maintain GraalVM's nativeTest, the example of this piece can refer to the processing contributed by OracleLabs to the main branch of netty/netty, refer to https://github.com/netty/netty/pulls?q=is%3Apr+is%3Aclosed+author%3A"gradinac"+ .

As a subtask of https://github.com/apache/shardingsphere/issues/21347, submitting GraalVM reachability metadata for io.seata:seata-all:1.6.1 at https://github.com/oracle/graalvm-reachability-metadata is indeed in my plan. But OracleLabs review and merge PR is too slow, I still have 7 PRs waiting for their review.

In any case, the content related to GraalVM is not suitable for discussion in this issue.

@linghengqian Through this question, I realized that we needed to maintain our own mock-server to ensure version compatibility. I've had a quick look at the mock-server code you've written, and I think you can contribute an original version of mock-server if you want. Are you interested ？

This MockServer class comes entirely from Apache ShardingSphere's unit tests, so I don't really feel like I have experience perfecting this class. If possible, I would like it to be done by other friends.

OK, anyone willing to contribute is welcome.

@wangliang181230  Pls take a look at suggestions for using metadata configuration and Spring code.

@wangliang181230 Pls take a look at suggestions for using metadata configuration and Spring code.

@slievrly OK.

@linghengqian https://github.com/seata/seata/pull/5234 has been put on hold for the time, because of some other PRs merged, resulting in some code incompatibilities.
At present, I am making some changes on the native branch of seata.

feature: First support native-image for seata-client #5234 involves Spring Framework classes, which I tried my best to avoid when submitting GraalVM reachability metadata at https://github.com/oracle/graalvm-reachability-metadata , because Spring's Maven Plugin/Gradle Plugin added Task prevents users from collecting the GraalVM reachability metadata subset of the Conditional form.

On the native branch, I have changed most of the reachability-metadata to use the <feature>-config.json, except for the optional components, and I have passed the local test.
Later, I will release 1.7.0-native-rc1 to the OSSRH for intergrated-test with SCA.
After the intergrated-test is passed, I will submit a PR to https://github.com/oracle/graalvm-reachability-metadata.

I've never directly observed Spring's handling of AOT. feature: First support native-image for seata-client #5234 doesn't seem to have fully passed CI, nor is nativeTest executed during the CI phase. If it is necessary for the library maintainer to actively maintain GraalVM's nativeTest, the example of this piece can refer to the processing contributed by OracleLabs to the main branch of netty/netty, refer to https://github.com/netty/netty/pulls?q=is%3Apr+is%3Aclosed+author%3A"gradinac"+ .

At present, seata-server is not compatible with springroot3 and native-image, so CI of nativeTest cannot be added temporarily.

This issue is superseded by #6212 and #6205.


Added basic authentication

This PR adds optional Basic Authentication to the Solace Prometheus Exporter.
To handle multiple users and passwords, a new file must be provided with users and hashed passwords. The hashes can be created with a convenient cli flag directly from the exporter binary.
./solace_exporter --hash-password <your-password>

The readme has been extended with (hopefully) all details.
Again this PR is in draft mode. Open topics are

[ ] more testing
[x] merge fix from PR #41

@andreas-habel Any updates here?

@andreas-habel ping

@andreas-habel ping, do you still work an this?

@andreas-habel ping, do you still work an this?
PR will be rejected in 2 weeks

Once again, sorry for the long silence. Please reject this PR for now.
After the splitting of the single code file in the new distributed code layout this PR must be redone anyways.


Add an asynchronous single GPU dataloader example

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
Address #1454 #1404 #1316
This was the simplest way without adding an any extra complexity to pytorch-lightning itself. It's only possible to asynchronously load for single GPU training anyway. MultiGPU uses PyTorch's DataParallel.scatter() which seems to have synchronisation constraints
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @HenryJia! Thanks for opening this PR.

In the file pl_examples/basic_examples/async_gpu_template.py:

Line 18:1: E302 expected 2 blank lines, found 1

In the file pl_examples/utils/loaders.py:

Line 1:10: E401 multiple imports on one line
Line 13:1: E303 too many blank lines (3)
Line 29:111: E501 line too long (117 > 110 characters)
Line 39:5: E303 too many blank lines (2)
Line 39:25: E261 at least two spaces before inline comment
Line 44:5: E303 too many blank lines (2)
Line 44:37: E261 at least two spaces before inline comment
Line 44:111: E501 line too long (116 > 110 characters)
Line 47:59: E251 unexpected spaces around keyword / parameter equals
Line 47:61: E251 unexpected spaces around keyword / parameter equals
Line 52:5: E303 too many blank lines (2)
Line 53:111: E501 line too long (143 > 110 characters)
Line 55:36: E251 unexpected spaces around keyword / parameter equals
Line 55:38: E251 unexpected spaces around keyword / parameter equals
Line 56:9: E265 block comment should start with '# '
Line 61:5: E303 too many blank lines (2)
Line 62:111: E501 line too long (113 > 110 characters)
Line 63:111: E501 line too long (120 > 110 characters)
Line 68:14: E261 at least two spaces before inline comment
Line 75:5: E303 too many blank lines (2)

Do see the Hitchhiker's guide to code style

@HenryJia The len attribute seems to be wrong. To the best of my knowledge, DataLoaders do not have len. To access the length, you should use DataLoader.Dataset to access the dataset of the data loader.

@veritas9872 That's not correct. The pytorch data loader does have a length that computes the number of samples based on batch size and dataset/sampler length. It's the dataset that does not necessarily have a length.

@justusschock I thought about adding it in to lightning itself instead of just as an example, but I'm not sure where exactly to stick it. It's not very generalisable as well as it's only single GPU compatible. To get it to work with infinite dataloaders would add a bit of complexity as I'd need to add in thread stopping conditions. I figured sticking with the PyTorch/PyTorch lightning philosophy of modularity, I'd keep it as an wrapper example with dataloader

@HenryJia this is awesome, but i think this belongs in bolts?
@PyTorchLightning/core-contributors thoughts?

Could be a good place for these kind of examples

maybe could go to bolts.dataloaders?

Following some discussions with William, we agreed that this would be best added to the datamodules section of bolts instead. As such, I'm closing this PR for now unless anyone else has something to object about it. I will open a new PR with this for bolts soon once I get around my final year university exams.


Allow context aware config for edit dialogs

Given I am a content author in US
Then all my /content/company/locales in all components are pre-filtered to US
Given I am a content author in Japan
Then all my /content/company/locales in all components are pre-filtered to Japan
Currently, we need to overlay dialog to have different starting path. Which is kind of inefficient as we end up with lots of overlays that all do the same thing, change paths.
It would be much more efficient to define context aware configs for dialogs.

It would be great to include this feature as I am facing the same issue: white label components reused in specific regions need to overlay component's dialog merely to customise the rootpath of pathbrowser, etc.

+1! Customizing the root paths for example would be very nice.

(CQ-4247363)

Closing this issue for now as it is inactive.


python3Packages.pytile: init at 5.1.0

Motivation for this change
pytile is a simple Python library for retrieving information on Tile® Bluetooth trackers (including last location and more).
https://github.com/bachya/pytile
This is a Home Assistant dependency.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 108883 1

2 packages built:

python37Packages.pytile
python38Packages.pytile

Result of nixpkgs-review pr 108883 1

2 packages built:

python37Packages.pytile
python38Packages.pytile

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108883 run on x86_64-linux 1

2 packages built:

python37Packages.pytile
python38Packages.pytile

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108883 run on x86_64-linux 1

2 packages built:

python37Packages.pytile
python38Packages.pytile

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108883 run on x86_64-darwin 1

2 packages failed to build and are new build failures:

python37Packages.pytile: log https://termbin.com/wmne
python38Packages.pytile: log https://termbin.com/6tdr

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108883 run on x86_64-darwin 1

2 packages failed to build and are new build failures:

python37Packages.pytile: log https://termbin.com/wmne
python38Packages.pytile: log https://termbin.com/6tdr


Winds is unable to add a feed

Prerequisites

[ X ] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed: https://github.com/GetStream/Winds/issues

Description
I'm unable to add the Intoxi Anime feed, it's a feed generated by Wordpress.
Steps to Reproduce

Try to add this RSS: https://www.intoxianime.com/feed/
Winds is unable to add it, "Oops, something went wrong..."

NOTE: There are some 500 erros on the console, not sure if it's related.
Expected behavior: The field is added and populated on Winds
Actual behavior: The "Oops" message is shown on the "Add RSS" dialog.
Reproduces how often: 100%
Versions
Winds 2.3.4 (3.0.0 isn't available to install on the website at this time)
Additional Information
--

If you change the protocol from HTTPS to HTTP it will pass this step. However, it won't parse any episode of the feed.


⚠ Bofrost.de has degraded performance

In 1e8b3d1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1567 ms

Resolved: Bofrost.de performance has improved in d5a42a2.


feat: use range when adding requirement

Implements the behavior described in #285 .
When running pixi add python we would previously look at all platforms, add the requirement, and solve the environment. We would then take the lowest version between all platforms and pin that. So currently for python that would result in the requirement:
python = "3.12.0.*"

This is a very strict requirement. And would also fail to resolve if this version (or a higher version) is not available for all platforms (see #526 ).
This PR changes the behavior by instead adding a range requirement that allows change in the last segment of the version. And allowing for multiple versions if a version is not available for all platforms.
For python this would become:
python = ">=3.12.0,<3.13"

For the issue described in #526, this becomes:
ros-humble-rosbridge-server = ">=1.2.0,<1.4"

Note that 1.4 is selected instead of 1.3. This is because 1.2 is not available for all platforms.
Fix #526
Fix #285

While testing this i got this situation. Not sure if this has anything to do with this pr yet. Just putting it here.
I get this error:
❯ pixi add python --build -p linux-64
  × Cannot solve the request because of: The following packages are incompatible
  │ |-- ros-humble-rosbridge-server >=1.2.0,<1.4 can be installed with any of the following options:
  │     |-- ros-humble-rosbridge-server 1.2.0 | 1.2.0 would require
  │         |-- python_abi 3.9.*, which can be installed with any of the following options:
  │             |-- python_abi 3.9
  │             |-- python_abi 3.9
  │ |-- python >=3.12.0,<3.13 cannot be installed because there are no viable options:
  │     |-- python 3.12.0 would constrain
  │         |-- python_abi 3.12.* *_cp312 , which conflicts with any installable versions previously reported
  │

On this initial pixi.toml file:
[project]
name = "range"
channels = ["conda-forge", "robostack-humble"]
platforms = ["linux-64", "osx-arm64", "osx-64"]

[tasks]

[dependencies]
ros-humble-rosbridge-server = ">=1.2.0,<1.4"
python = ">=3.9.15,<3.10"

It does add the following part to the pixi.toml but then fails the solve. Which is a known issue.
[target.linux-64.build-dependencies]
python = ">=3.12.0,<3.13"

But the version seems weird as that will not match with the ros-humble requirement

Found it, this has nothing to do with this PR. But sits in the way we deal with the --build and --host in the fn add_specs_to_project:
let current_specs = match spec_type {
            SpecType::Host => project.host_dependencies(platform)?,
            SpecType::Build => project.build_dependencies(platform)?,
            SpecType::Run => project.dependencies(platform)?,
        };

This should not be done as we are solving them together. Will make a different PR to fix this.


Defining Prediction length by product

Supposing I have a timeseries of many products, like this:
{'start': Timestamp('2019-04-01 00:00:00', freq='D'), 'target': array([ 0., 10.,  2.,  2., 21.,  6.,  5.,  3.,  5.,  4., 10.,  8.,  1.,
      ...
        1.,  1.,  1.,  0.,  2.,  0.], dtype=float32), 'feat_static_cat': array([  1, 904]), 'source': SourceContext(source='list_data', row=2)}

{'start': Timestamp('2019-01-01 00:00:00', freq='D'), 'target': array([ 0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  4.,  6., 16.,  7.,
    ...
 2.,  2.,  2.,  0.,  5.,  0.], dtype=float32), 'feat_static_cat': array([  2, 904]), 'source': SourceContext(source='list_data', row=3)}

I usually train deepar model using a static Predition Length parameter on:
estimator = deepar.DeepAREstimator(
                       freq='D',
                       prediction_length=7 ... )

Is it possible to define a prediction_length by product ? Something like this:
{'start': Timestamp('2019-04-01 00:00:00', freq='D'), 'target': array([ 0., 10.,  2.]), **prediction_length=10**}

Hi @kaleming, unfortunately that is not possible. The prediction_length is a property of the model, and defines together with other hyperparameters how the network internally works: this cannot depend on the data that the model is processing.
The only way to achieve what you need, as far as I can see, is to train different models for different products. That is, define:
estimator_1 = deepar.DeepAREstimator(freq='D', prediction_length=7, ...)
estimator_2 = deepar.DeepAREstimator(freq='D', prediction_length=14, ...)

predictor_1 = estimator_1.train(training_data_product_1)
predictor_2 = estimator_2.train(training_data_product_2)

It sounds a good solution.
Thank you @lostella.

I’m closing this for now; I will add comments in case there are news about having such an option.


Add preliminary code for WebAssembly.

This PR does the basic ground work for getting us ready
to support WebAssembly in the browser via Emscripten.
Emscripten is a project that shims much of musl libc with JS functions
to allow some POSIX code to run in a browser.
As of this change, it is possible to compile the Pony runtime
as wasm32 bitcode, compile a Pony program as wasm32 bitcode,
link them using llvm-link, compile html, js, wasm
assets for the browser using emcc, then run them in a browser.

The biggest thing we are still missing is implementing some evented I/O,
because epoll is not supported by Emscripten.
To move forward with WebAssembly from here, we will need to do one of:
(A): Help implement epoll in JS for Emscripten and contribute those
patches upstream for the good of all epoll applications, possibly
getting bogged down by features of epoll we don't strictly need
for the Pony runtime, or getting bogged down by PR review.
(B): Reimplement the Pony ASIO subsystem using Emscripten-native
features rather than shimming epoll, possibly getting bogged down
by differences between Pony's expectations of how ASIO works and
the way that the Emscripten eventing features actually work.
Either or both of these paths could be pursued, but they are not
required as prerequisites for merging this PR.
This PR does not add official support for WebAssembly to Pony yet,
or any other user-facing features so there is not changelog entry needed.
This is just laying the ground work so that either path (A) or (B)
can be pursued in a later branch/PR.

To compile and run a simple Pony program in the browser, pull down this branch, rebuild LLVM to include WebAssembly, and follow the steps below:
# First, ensure you have the `emcc` compiler on your `PATH`,
# by following the installation steps for `emsdk`.
emcc --version # for me, this was 2.0.32

# Build ponyc.
make configure config=debug
make build config=debug

# Build libponyrt LLVM bitcode for wasm32, using emscripten as the compiler.
EXTRA_CMAKE_FLAGS="-DCMAKE_C_COMPILER_TARGET=wasm32-unknown-emscripten -DCMAKE_SYSTEM_NAME=Emscripten -DCMAKE_SYSTEM_PROCESSOR=wasm32"
rm -r src/libponyrt/build
mkdir -p src/libponyrt/build
env CC=$(which emcc) CXX=$(which em++) cmake -S src/libponyrt -B src/libponyrt/build -DPONY_RUNTIME_BITCODE=true -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON ${EXTRA_CMAKE_FLAGS}
env CC=$(which emcc) CXX=$(which em++) cmake --build src/libponyrt/build --target libponyrt_bc

# Write a basic Pony program.
mkdir -p hello
cat <<PONY >hello/main.pony
actor Main
  new create(env: Env) =>
    env.out.print("Hello, World!")
PONY

# Build the Pony program to LLVM IR for wasm32.
build/debug/ponyc hello --pass=ir --triple=wasm32-unknown-emscripten --cpu=generic

# Link the Pony program to the Pony runtime to produce an LLVM bitcode.
build/libs/bin/llvm-link -o hello.bc hello.ll src/libponyrt/build/libponyrt.bc

# Compile the LLVM bitcode using the emscripten compiler to emit html, js, wasm.
emcc -o hello.html hello.bc -pthread -s PROXY_TO_PTHREAD -s PTHREAD_POOL_SIZE=8 -s INITIAL_MEMORY=1073741824 -s EXIT_RUNTIME=1 -s EXPORTED_FUNCTIONS='["_main"]'

# Open a local web server to serve the html file, and open it in the browser.
# This loads the associated js and wasm, and runs the program!
emrun hello.html

# Alternatively, you can run the program in your terminal using Node.JS.
node --experimental-wasm-threads --experimental-wasm-bulk-memory ./hello.js

Not sure why CI is still failing. Maybe the cache bust didn't work?

I've rebased this to resolve merge conflicts, and tested locally as well. Hopefully can get this merged in soon.

I assume that importing the LLVM project (https://github.com/ponylang/ponyc/blob/ab6a6a389cf51a2c17aae0cae898ba588218ab59/CMakeLists.txt#L27) and possibly using the LLVM macro llvm_map_components_to_libnames (https://github.com/ponylang/ponyc/blob/ab6a6a389cf51a2c17aae0cae898ba588218ab59/CMakeLists.txt#L150) will make use of the LLVM_TARGETS_TO_BUILD define, so it needs to be in the top-level Makefile.

Thanks, Gordon. I've updated the branch in an attempt to fix the issue without moving it back to the Makefile - my hope is that this approach will preserve the nice caching properties I was looking for in the other approach.

Meh. I failed that approach - couldn't get it to work.
It ain't pretty, but I just updated cache buster dates for all the fingerprint scripts in Cirrus CI...

@jemc please get that fixed before this gets merged. for anything that is using a container, adding a cachebusting string back in is not the right thing to do but would be fine for now during PR.

@SeanTAllen - the only point of adding the cache buster string was to make the PR mergeable.
So if you don't think it's mergeable in that state, then there's no point to it.
Gordon and I couldn't figure out how to make the caching work properly.
Aside from the cache busting string in Cirrus CI config, the only other workaround I know of that should work is to make some cosmetic/non-functional change in lib/CMakeLists.txt that will alter the MD5 hash. I thought that setting the cache busting string was a better option because at least it would be a change that is explicit about being about busting the cache.
Do you have any other alternatives to propose?

The only other option I can think of that makes any semantic sense is to add the MD5 hash of the Makefile into the libs fingerprint script as well. But that will have the downside of busting the cache more often (on any Makefile changes).
Is that what you'd prefer?

After discussing with Sean I have updated this branch to add additional files to the ones used by the Cirrus CI cache fingerprinting. This may result in additional frivolous cache busts (if somebody makes other changes to these files which do not result in changes to the built LLVM assets), but it's better than having the possibility of a false cache hit that leads to subtle build bugs.

This is passing CI and ready to merge once approved.

@jemc the fingerprinting changes look good to me. is there anything in particular i should focus on for the rest of the review? without being an expert in this area, there's nothing that stands out as being incorrect. If there are areas you have any worry about, I'm happy to spend some time looking at those.

@SeanTAllen No, there's nothing I'm particularly worried about here - I think it's all pretty simple in this PR, and should be good to merge if you approve.
Then I can follow up with testing approaches for some of the scheduler changes we talked about last week (to enable actors on the emscripten main/browser thread).


doc(spid): Add explicit desc to disable ISR.

As a follow up of https://github.com/lowRISC/opentitan/pull/14016 this
commit adds a description that SW may need to disable interrupts to not
be disrupted by ISRs.

good idea on this one..instead of blocking the other PR on yet another round of CI hehe.


Wrong "Issue-Link" in ReadMe

There is a wrong link in your readme. Line 32.
Ngx-mailto is not a part of "angular-material-extensions" but your "Issue" link redirect us to angular-material-extensions/ngx-mailto/issues

I will check it thank you


fix: update codegen to reflect current status

:tada: This PR is included in version 1.57.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add option to suppress source maps from build stats

Excludes source maps from build stats by default by adding a check to the parseStats for asset names ending in .map.
Added configuration option excludeSourceMaps which is default true.
Closes #88

Thank you @DHedgecock! That works great 😀


iOS VO selection improvements

Closes https://github.com/adobe/react-spectrum/issues/2522
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to TableView highlight selection mode and turn on VO or Talkback
both:
moving with arrow keys should announce the selection each time
selecting all and then hitting the arrow keys should announce the item selected
selecting a non-contiguous set and then replacing that selection with an item already selected should announce the item that remains selected and the count because it's also where focus now is
selecting a set and then replacing that selection with an item not already selected should announce the item that is now selected and the count
onAction:
interaction with touch should read off roughly: long press to enter selection mode
Go to useTable stories, there are two for onAction, one is for the backwards compatible API and the other is the newly add API features. They should behave the same.
🧢 Your Project:

still need to move shared code out, will do tomorrow

@majornista would be great if you could review this behavior!

@devongovett my understanding now is that by allowing people to put onAction only in useTableRow or useTableCell, they could omit it on some, which can lead to some odd behaviors. I've pushed a new story that does just this. The rows where onAction is omitted do not respond to a longPress. It seems to me like either everything responds to the long press or nothing does, this odd middle ground is... troublesome.
The new story is in useTable stories. If you go to your iPhone and longPress row one, selection happens but you don't go into selection mode. If you longPress on row 2 (Blastoise), then you do go into selection mode.
I know it seems a bit contrived, but I could see someone thinking that certain row types don't need an action.
A couple potential options I see for still getting the message onto the Table saying to longPress are

Add onAction to useTable

still has a similar issue since nothing uses it in useTable, so people could misuse it and not send it in)

Add something to state to track if focus is in the table, then when a row/cell receives focus, and focus wasn't previously in the table, we could add a description to that row/cell saying long press. we would remove it when that element loses focus and wouldn't add it to anything again until focus leaves the table and comes back

haven't tried it out, not sure if there's some way to make a description play again, this might prevent that

Something on state to register if there is an onAction anywhere, then all our hooks would have to call it
could be problematic if the rows are async loaded and onAction is or isn't present until later

open to other ideas as well

The announcement of long press behavior and select/deselect an item seems to work well with VoiceOver on iOS now.
Related to VoiceOver announcement of aria-selected state, which I need to open as an issue with Apple.

In highlight selection mode, when we have no checkboxes, we get no indication that a row is selected or not selected when navigating between rows in the ListView or TableView. So, if for example, you were to have multiple items selected, and you were to deselect one item, our liveRegionAnnouncer will make VoiceOver announce the change in the number of items selected, but the user will be unable to distinguish between the remaining selected and not selected items in the ListView or TableView.

One possible solution would be to include a visually hidden indication of the selected status in place of where the checkbox would render.

Perhaps a separate concern within TableView and ListView:

should the Select checkbox have an aria-labelledby that includes the checkbox itself and the rowheader title, so that checkboxes are independently distinguisible?
aria-label for "Select All" column header should probably be simply, "Select", with "Select All" on the checkbox within it. This will prevent the "Select" column for each row from being announced as "Select All" when navigating between cells within a row.

@LFDanLu thanks for reviewing

I noticed that selections and number of rows selected aren't being announced on iPad w/ VoiceOver, "selectionStyle: highlight" story. Works fine on Android TalkBack and desktop VoiceOver

Is it all the time? or just happens sometimes? I noticed that it wasn't always 100% consistent, hopefully fixed by Apple from some of the bugs that Michael is reporting

Should the fact that rows have an 'onAction'/'onRowAction' be announced? Right now they aren't, perhaps out of scope for this PR/deemed not necessary?

I think out of scope, we can decide if we want that in the announcements as well. I think if it says long press to enter selection mode then it can be figured out that a regular press does something other than select.

"long press to enter selection mode" doesn't announce on Android TalkBack

at all??

should there be an announcement of how to exit selection mode for TableViews w/ onAction?

Decided we wouldn't have that announcement, I think it's in one of the resolved conversations above

@snowystinger

Is it all the time? or just happens sometimes? I noticed that it wasn't always 100% consistent, hopefully fixed by Apple from some of the bugs that Michael is reporting

I can't it to ever announce the row selection and number of rows selected. Note that this iPad isn't on iOS 15 though, it is 14.8.

I think out of scope, we can decide if we want that in the announcements as well. I think if it says long press to enter selection mode then it can be figured out that a regular press does something other than select

Sounds good.

at all??

Yeah, it doesn't seem to make that long press announcement on Android Talkback at all. I'm on Android 10.

Decided we wouldn't have that announcement, I think it's in one of the resolved conversations above

Gotcha, good to know

Yeah, it doesn't seem to make that long press announcement on Android Talkback at all. I'm on Android 10.

I was able to get it to announce when navigating to the table itself, but only after selecting a row and deselecting it. Maybe due to this?
https://github.com/adobe/react-spectrum/pull/2521/files#diff-09e89871655ec60bd75e26783c85bf96c088449e7599f6aa2e1f7a0901912e3fR34
If the modality defaults to keyboard then you wouldn't get any message until you interact with something.

I can't it to ever announce the row selection and number of rows selected. Note that this iPad isn't on iOS 15 though, it is 14.8.

@LFDanLu I tested in my iPad which is on 14.6 and it works. Sometimes VO gets confused. Maybe try killing Safari and restarting it?

@LFDanLu I tested in my iPad which is on 14.6 and it works. Sometimes VO gets confused.  The iPad VO now announces the row selection properly.


Introduce standard-rails

Currently there's no linter for this app.
While we can setup our own configuration for RuboCop, I'd like to try standard-rails, which more devs can agree with.

unner/work/conference-app/conference-app/.gem_rbs_collection/rubocop/1.57/rubocop.rbs:21:4: [error] Cannot find type Parser::Source::TreeRewriter

oh……

I think we need the standard gem and the .standard.yml file.
https://github.com/standardrb/standard#plugins
I could not run bundle exec standardrb without adding the gem and file.


WASM: Unreferenced but exported methods are removed by dependency checker

Consider the following code:
package de.mirkosertic;

import org.teavm.interop.Export;

public class Main {

    @Export(name = "passThru")
    public static int passThru(int aValue) {
       return aValue + 1;
    }

    public static void main(String[] args) {
    }
}

The passThru Method is removed by dependency checker, probably as it seems to be unused from the Java bytecode point of view. But the methods is intended to be called from JavaScript.
Exported methods should always be part of the dependency graph.

It's an issue by design. TeaVM does not scan full classpath, since it can be large and imply big compilation time. It rather starts from known main class and then parses additonal classes when they are reached by dependencies. There must be a way to tell TeaVM that a certain method should be scanned. @Export annotation can't serve for this purpose, it's only purpose is to tell TeaVM to generate certain WebAssembly instructions.

I created pull request #259 as a proposal.
You are right, we cannot search the whole classpath for annotated methods. But we can search the already processed classes and for @Export annotated methods and mark them as used during dependency analysis. This mechanism would make the example code from above workable.
This is definitely a tradeoff between performance and usability, but it is better than nothing.


Changing footer result in an unexpected result.

Problem
When user changes the footer text, the the text will concatenate with ticket.pm (i.e. setting the footer to "test" result in ticket.pmtest footer)
Solution
Automatically includes - to the text if the user adds something to the footer. This is the best compromise while including ticket.pm on the footer.

Fixed with commit f84c0a6


Release v219

https://github.com/heroku/heroku-buildpack-python/compare/v218...65c991839ef7a58ac2002570ed214f8fa3737dac

Published:
$ make publish
Deploy as version: v219 [y/n]? y

Tagging commit f8bfeb154ca45c6fa45d6ae7e47c7dac12db79ff with v219...
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/heroku/heroku-buildpack-python
 * [new tag]         v219 -> v219

Publishing to the buildpack registry...
Two-factor code: ********************************************
Publishing buildpack heroku/python... done
Publishing buildpack was successful

Version  Released At               Status
───────  ────────────────────────  ─────────
219      2022-09-26T11:23:17.759Z  published


Cask 'adoptopenjdk-jre' definition is invalid

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  node@14
  node@16
<EMAIL_ADDRESS>
Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 4.1.25-57-gdc3daf7
ORIGIN: https://github.com/Homebrew/brew
HEAD: dc3daf77a527b5c9da85d90c62f14f57ff6a339e
Last commit: 8 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 9bf97a044d99a76ff898c7b8e318124baa262440
Core tap last commit: 23 minutes ago
Core tap branch: master
Core tap JSON: 15 Dec 16:41 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 16
HOMEBREW_NO_ANALYTICS: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.1.4 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/bin/ruby
CPU: 16-core 64-bit kabylake
Clang: 15.0.0 build 1500
Git: 2.43.0 => /usr/local/bin/git
Curl: 8.1.2 => /usr/bin/curl
macOS: 14.1.2-x86_64
CLT: <IP_ADDRESS>.1.1694021235
Xcode: 15.1

What were you trying to do (and why)?
I wanna install a new Cask; first I need to know if it is out there.
❯ brew search -v --eval-all --desc vscode
What happened (include all command output)?
==> Formulae
code-server: Access VS Code through the browser
dockerfile-language-server: Language server for Dockerfiles powered by Node, TypeScript, and VSCode
vsce: Tool for packaging, publishing and managing VS Code extensions
vscode-langservers-extracted: Language servers for HTML, CSS, JavaScript, and JSON extracted from vscode
==> Casks
Error: Cask 'adoptopenjdk-jre' definition is invalid: 'appcast' stanza failed with: Calling the appcast stanza is disabled! Use the livecheck stanza instead.
Please report this issue to the adoptopenjdk/openjdk tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
/usr/local/Homebrew/Library/Taps/adoptopenjdk/homebrew-openjdk/Casks/adoptopenjdk-jre.rb:9
What did you expect to happen?
That there would not be an error and it would list out any Casks that match my search criteria.
Step-by-step reproduction instructions (by running brew commands)
1) `brew search -v --eval-all --desc vscode`
  — This will cause the error noted in the body of the issue description.
2) `brew desc -sv --eval-all vscode`
  — This will cause the error noted in the body of the issue description.
2) `brew search -v vscode`
  — This will run successfully and return a single CASK, `vscodium`.
Run `brew search` or `brew desc` to reproduce. I have only seen the error under the `CASK` list and not the `FORMULA` list.

Please report this issue to the adoptopenjdk/openjdk tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:


Slow to load

It seems to take a few seconds after the editor opens for this extension to kick in. I've tried with subtleBrackets.parse: false but the startup lag remains.
I'm running Win7 x64 on a i7, 14GB RAM, SSD configuration so I know its not the typical HDD lag.

Have you tried disabling all other extensions? It could be that the lag is caused by them and since you do expect a visual cue from subtle brackets you might only notice it there.


Aggregation Temporality Support

Which problem is this PR solving?

Refs: https://github.com/open-telemetry/opentelemetry-js/issues/1528
Add stateless accumulations support.

Short description of the changes

Make metrics and bound metrics state ephemera, so that a label set will not be kept in store throughout the process lifetime without manual unbind.
Rename UngroupedProcessor to BasicProcessor and supports cumulative processing to aggregate AggregationTemporality.DELTA aggregator snapshots to AggregationTemporality.CUMULATIVE accumulations.
Add move and merge to Aggregator interfaces.

This PR depends on previous minor type introductions:

https://github.com/open-telemetry/opentelemetry-js/pull/1717
https://github.com/open-telemetry/opentelemetry-js/pull/1712

Closed due to inactivity. I will continue the investigation once there are any updates on the spec.


Parse folded HTTP field values according to RFC 7230

Change Intent
The intent of this change is to correctly parse folded header field values contained (through HttpHeaders) in HttpRequest and HttpClientResponse.
For example, an HTTP request like:
POST /test HTTP/1.1
Header-A: cat\r
 food\r
Header-B: cat \r <- note space before carriage return
 food\r

Would be parsed like:
// CURRENT BEHAVIOR:
assert(headers['header-a'] == 'catfood');
assert(headers['header-b'] == 'cat food');
// PROPOSED BEHAVIOR:
assert(headers['header-a'] == 'cat food');
assert(headers['header-b'] == 'cat  food');

Justification
RFC 7230 Section 3.2.4 says:

...replace each received obs-fold with one or more SP octets
prior to interpreting the field value or forwarding the
message downstream.

The amount of interior whitespace in an HTTP header value is not significant according to RFC 2616 2.2:

All linear white space, including folding, has the same semantics as SP

Impact
Header folding was deprecated in RFC 7230 (published in 2014) so this is change is unlikely to have a significant impact.
Code that (against the standard) relies on particular whitespace in folded header values will be broken.
Mitigation
I think that this is unlikely to have significant impact.

@itsjustkevin I think that this is ready for sign off.

@vsmenon @Hixie @grouma another breaking change request, hot off the presses!

SGTM, but didn't we just make a change to remove trailing whitespace? Should we also fold inner whitespace since it's not semantically meaningful? Anyway, either way is fine by me.

SGTM.

SGTM, but didn't we just make a change to remove trailing whitespace? Should we also fold inner whitespace since it's not semantically meaningful? Anyway, either way is fine by me.

My intuition, unsupported by any data, is that folding internal whitespace is likely to break things because developers aren't aware that folding is allowed.


let gorm can scan protobuf struct without add an ignore tag ("-")

let gorm can scan protobuf struct without add an ignore tag ("-")
link: https://github.com/go-gorm/gorm/issues/4877

[V] Do only one thing
[V] Non breaking API changes
[V] Tested

What did this pull request do?
implement the  #4877

User Case Description
when gorm process the struct which is generated by the protobuf.

Rely on the json:"-" tag doesn't sound correct.


Typing "/**/" should work

Issue Type: Bug
When I type ", [, (, or { it is automatically matched with ", ], ), or }. But typing "" or () will work by consuming the automatic match, so I don't end up with ()).
When I type /**/ I would expect that to be exactly the text I get, but instead I get /**/ */.

@rebornix @alexandrudima This is because we expand /*| to /**| */. Is there any way to tell VS Code to eat the next / that the user types, like we for for ) when completing ()?

@mjbvz I don't believe it is the same case as a single character expansion.
We expand /**| to /**| */, i.e. we append  */ after the cursor.

It is not clear to me how to possibly recover if the user meant to type literally and empty comment: /**/.
Perhaps we should not expand /**| to /**| */ as it is not 100% clear a JSDoc will follow. Perhaps we should do the smart things when pressing Enter, as that more clearly indicates a JSDoc comment.

Let's track in #1966