Build and test only changed packages

Hey, I just made a Pull Request!

Added lerna flag to make sure only changed packages are built and tested.

Fixes #285
:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] CODEOWNERS updated (for new stuff)
[ ] Regression tests added for bug fixes

This doesn't really work for builds, try cloning a fresh version of the repo and running build for example, don't do much :p
I think we could try it for tests though, and change the issue to consider the problem solved for tests.

This doesn't really work for builds, try cloning a fresh version of the repo and running build for example, don't do much :p
I think we could try it for tests though, and change the issue to consider the problem solved for tests.

I tried making this option only for tests, but the CI still fails
Error:
lerna ERR! Error: Command failed: git diff --name-only origin/master -- packages/app
the flag --since should make lerna run this command behind the scenes :p

It's passing, ok, but it still considers all the test packages. I need to deep dive into a little bit more to understand why it happens.
I think the checkout code action makes pull from a branch with a different name from master, and when lerna runs using the flag --since, it runs git diff --name-only master -- packages/app looking for the branch master and doesn't find it.

I think the git fetch origin master solution you had just now is good. Could you go back to that and squash the history down to 1 commit? Think we'll be ready to merge at that point :grin:

I think the git fetch origin master solution you had just now is good. Could you go back to that and squash the history down to 1 commit? Think we'll be ready to merge at that point

Done! :smile:

Ok, thanks! :grin: Gonna merge if it's green so we can try it out

after a lot of back-and-forth, this ended up very clear, small and understandable. thanks for soldiering through :)


Strange line of sight behaviour

Hi @npruehs!
Been a little while, hope you're well :)
I've been attempting to implement the complete fog of war functionality, with the last step being the line of sight feature. On the demo project, it works as expected, but I'm seeing fairly unreliable line of sight behaviour within my project (video attached below).
I've played around with the Level Height setting of the vision volume but either yielded the same behaviour, or reduced to a value where line of sight was never blocked by objects.
Any advice on where to dig further into this?
Thanks!
https://user-images.githubusercontent.com/13906915/118720798-59395980-b82a-11eb-8e47-f084aad2923a.mp4

Hey @JaredP94!
Sorry for the late reply. I assume that your actors don't have "Ignores Height Levels" checked on their RTSVisionComponent.
Assuming that's not the case, the plugin will compare the height level of the tile being looked at to the height level of the moving actor. These tile heights in turn are cached when the game starts (ARTSVisionVolume::Initialize) for performance reasons, so my next question would be whether your level geometry (vision obstacles) are in place from the very beginning, or not.
If so, the tile height is determined by casting a ray from "infinity" (Z = 10000.0f) downwards (to Z = -10000.0f) against the HeightLevelTraceChannel of your vision volume, so you'd want to check whether these traces are actually able to hit your vision obstacle.
If so, the resulting Z value is divided by the Level Height of your vision volume (and floored) to get discrete height levels.
If that resulting height level of the tile is above the one of the actor, the actor is considered to have no vision on that tile.
If the actor has vision on a nearby tile, the algorithm continues to check the next tile along line of sight using a simple Bresenham algorithm, until it hits a tile the actor doesn't have vision on.
Does that make any sense to you?
Nick

Hi @npruehs,
Appreciate the detailed feedback!
> I assume that your actors don't have "Ignores Height Levels" checked on their RTSVisionComponent.
That is correct.
>so my next question would be whether your level geometry (vision obstacles) are in place from the very beginning, or not.
All objects in question are static and placed in the level prior to startup.
> so you'd want to check whether these traces are actually able to hit your vision obstacle.
I've validated that the objects are well within bounds.
What's interesting is how some objects seem to block vision from one direction, but not from the other, or that objects of equal height seem to exhibit completely different vision blocking. I thought the rugged terrain might have an impact since the demo level is flat, and the shift in terrain is causing some interesting behaviour, but I would expect a bigger tile height to resolve that (and it doesn't really affect the main point of reliable vision blocking from tall objects).

"objects of equal height seem to exhibit completely different vision blocking"
Technially, this could happen if you're you're not using enough tiles, i.e. we use too few rays to properly sample the heights everywhere.
"some objects seem to block vision from one direction, but not from the other"
This however is hard to explain and sounds more like a bug to me...
Hard to tell without having a closer look on your setup. Any chance you might be able to share your project, or a minimal repro if you're more comfortable with that?

> Technically, this could happen if you're you're not using enough tiles, i.e. we use too few rays to properly sample the heights everywhere.
I have experimented with an increased number of tiles, but it did not appear to yield any better behaviour.
> Any chance you might be able to share your project, or a minimal repro if you're more comfortable with that?
This is certainly something I can do. It is currently private, so I would need to add you as a collaborator to look at it. I have also made the transition to UE5EA (yay!) so unless you have it installed, you would need to checkout a commit prior to the conversion. Let me know if you're happy with this? Obviously I would like to make it as quick and easy as possible for you :)
Thanks again for digging into this!

Sure, whatever works for you. I've got UE5 installed as well :)

Nice, that should work out the box then!
Don't mind the current state of things, seems upgrading to UE5 has broken quite a few things in our project, most notably around animation. Guess it's time to hop over to control rig once and for all :)
I have added you as a collaborator, please shout if you have any issues getting everything to build and run :)

Which repo is that? I don't think I got a notification - I might have just missed it, though. Filters show nothing.

Sorry for the delayed response!
I see the invitation is still pending - you should be able to access it here: https://github.com/JaredP94/Unreal-CoH

It says "This invitation has expired."

Hi @npruehs, sorry for the delay - life has been a bit busy :)
I've just sent a new invite!


MultiWorkerMirroredStrategy overhead time

Click to expand!
Issue Type
Support
Source
source
Tensorflow Version
tf 2.9
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I am trying to train tensorflow recommender , When I run in on single machine with 32K batch size every steps take 4 sec, But then when I run it with 2 machines (64k global batch size) it took 7 sec. So the overhead is 3 sec.

Now if I increase my batch size to 64K then step time is increased to 10 sec for single machine and 2 machine it's 17 sec, now overhead is 7 sec.

So with this way I am not actually reducing the training time by adding more machine. Tried with 4, 8, 12 machine it's just take same time it takes for single machine.

Not sure if I am missing anything

Here is my code :
        strategy = tf.distribute.MultiWorkerMirroredStrategy()
        tf.debugging.set_log_device_placement(True)
        global_batch_size = self.batch_size * strategy.num_replicas_in_sync
        train_batches = self.train_dataset.batch(global_batch_size).prefetch(
            tf.data.AUTOTUNE
        )
        test_batches = self.test_dataset.batch(global_batch_size).prefetch(
            tf.data.AUTOTUNE
        )
        options = tf.data.Options()
        options.experimental_distribute.auto_shard_policy = (
            tf.data.experimental.AutoShardPolicy.DATA
        )
        train_batches = train_batches.with_options(options)
        test_batches = test_batches.with_options(options)
        with strategy.scope():
            self.model = self.get_model_with_state()

        self.history = self.model.fit(
            train_batches,
            validation_data=test_batches,
            epochs=self.num_epochs,
            callbacks=self.custom_callbacks,
            verbose=1,
        )

Standalone code to reproduce the issue
strategy = tf.distribute.MultiWorkerMirroredStrategy()
        tf.debugging.set_log_device_placement(True)
        # tf_config = json.loads(os.environ["TF_CONFIG"])
        # num_workers = len(tf_config["cluster"]["worker"])
global_batch_size = self.batch_size * strategy.num_replicas_in_sync
        train_batches = self.train_dataset.batch(global_batch_size).prefetch(
            tf.data.AUTOTUNE
        )
        test_batches = self.test_dataset.batch(global_batch_size).prefetch(
            tf.data.AUTOTUNE
        )
        options = tf.data.Options()
        options.experimental_distribute.auto_shard_policy = (
            tf.data.experimental.AutoShardPolicy.DATA
        )
        train_batches = train_batches.with_options(options)
        test_batches = test_batches.with_options(options)
        with strategy.scope():
            self.model = self.get_model_with_state()

        self.history = self.model.fit(
            train_batches,
            validation_data=test_batches,
            epochs=self.num_epochs,
            callbacks=self.custom_callbacks,
            verbose=1,
        )

Relevant log output
No response

Hi @gadagashwini !
Could you look at this issue.
Thank you!

Hi @surajitkundu-dazn, Thanks for this issue. Could you please share complete code to reproduce the issue. Thank you!

[https://aml-compress.s3.eu-central-1.amazonaws.com/WW/temp_ww.zip?response-content-disposition=inline&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEIz%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCWV1LXdlc3QtMiJGMEQCIGCU42T09AVSxHl7pKMtDaR8%2BVWhLsIIFbZV9z4RlRjIAiB1NMXOY5Bu7uKu8Dl2kGjIwdry%2Bkvg1nP%2Flrtm85lFIyrdAwhFEAMaDDM5NDg3NDg1ODE0NiIML01%2B8VNLTUQ2tkEhKroD53%2BbCsPabfz05YwlcQPEvutqSn%2BYQUgm1qEKrmRMlPvP7NsgNs2HPRf7MQ959D2htOxtec6DAmRUsVc5QE0Q%2BPSKiWasYVUa7S5dFHV0rL%2FHcTpVqwoVWDfHliT9OGSyLBJLaj3fWZgkseu3oIbKa8j3EemOLiBPyP9nkYNlKlswiihWIRhvGSynERx%2BYogJj0%2FZG%2Ftqe2qRwgQE6f34ZiE1YBcb75tHhVaIUBAFMXuSwvH1lriANnX7eMy5jBapyJPoHFlLaACQuKdcVwMG2HNlpkYzq107UlIk2v9FfXI5fS9r1r0G9VeQ2R%2FwTWzkSIoh9D8Z3Y47In3EYsXNGokEAhSevTLAkni2Hm53kv%2FL5N0MtaF6V8xdCiCg%2F05iSJBa5VyPxepykFPJqJUQpQcaHATPmQcmke%2BKq5uhBMzKAZQtA%2BhKv%2F9%2FYrQurq0vqtOchacBWVHAVyYRvhqfFxw3m18KpGQVBBA4ig5r2zaXzpyAe5RSHH2N1P3zvM8scFBMEmag6K%2BgR7OcdJIY6D6YWauwnNAVc%2BVpVqRGOfYaKDGgL4TZje1RrjtwCsfFYXdk3AjzeXyY3TCEi9WZBjqRAtvySGSokR36pHrOctDAee2DqTaB7b0WPnMbG2eEMNa%2BIlieVXvd9rSjR39TsjJx5rcz4R3t3%2BSmj41eMxuADSPTLJW5BjanKIc15dBILB6q9S6jcS7KfsJpcQ5mfd%2FMY3Z%2BcpXJDnIdMnygq3sTdhksXwiNdrzN76gvZBJbe0Ynus7xo1ql0KVkYg3sb4nH0GQGN5ffIMDUcj4W75Jy9bpB0UJ3F%2Fkxiee38jzrBImPXEBxmPDxml2jaNkPePvTK6PqWy%2F%2B4QXICzRabkeVXkrcl%2FmCpija5Cy%2BDwuxKt8YwiCkB2vFQPxBPpkkqbpWnaqqMN%2BTsznmj2VZ4T1K1YQpeQHeAs0bocKO34JCE5OkJA%3D%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20220929T114724Z&X-Amz-SignedHeaders=host&X-Amz-Expires=43200&X-Amz-Credential=ASIAVX4DAFKRCEKD2P6R%2F20220929%2Feu-central-1%2Fs3%2Faws4_request&X-Amz-Signature=1fe8185e7024da220de7f57d035a84190fc78bc6b55ad6acd415c70340fa0cec](Model Training Code)

Hi @surajitkundu-dazn, I am unable to access the link. Thank you!

Hi @surajitkundu-dazn, I am unable to access the link. Thank you!

Can you please try now

Hi @surajitkundu-dazn, Still I am unable to access the given link.


fix(bing): use empty string for real user message in jailbreak mode

Hi everyone, really appreciate this project.
#264 fixed #263, but

Now GPT-4 sees the message repeated twice: once in its normal form (in the previousMessages array) and once again in the garbled form with - and _ inserted. This is understandably confusing, causing:
GPT-4 to reject what looks like correct input to the user. For example, I modified the system message to play a chess game in ASCII art with the model (don't ask), and told it to reject incorrect moves. It would reject my moves many times in a row (since they looked like Be-5, B_e5, etc.)
GPT-4 to think this is some new mode of communication, and modify its output accordingly (as demonstrated by @Naozumi520 in the comments of #264).

Dropping #264 in favor of the old "continue this conversation" prompt is problematic, of course. But a simpler solution is just to leave the message as an empty string. This gets the OK from Microsoft's API, and the model seems to have no problems with it (at least in my own testing). "Repeat my previous message" works flawlessly.
What do you guys think?

Huh, I guess that's a solution. Sounds good to me; thanks for the PR! I'll fix the lint error real quick before merging.

I'm surprised it works because I swore I tested it with an empty message before, and it caused an error. I'm speculating it works now because we're passing it a webpage context, which might be preventing the error from occurring.

Awesome, thank you!


Dialog Layout doesn't fit in Landscape

Samsung N7000, API 16+. Color picker dialog does not fit vertically when device is Landscape, the color selection area is too big (see scrollbars when scrolled to the bottom). The screen resolution is 1280x800, stock firmware, no large font or any accessibility options, etc.

I am aware of this and that is why the view is in a ScrollView. Do you have any suggestions on how to improve this? Pull requests are welcome.

You can modify the color sample size in dimen.xml

<?xml version="1.0" encoding="utf-8"?> <resources>   <dimen name="cpv_required_padding">6dp</dimen>   <dimen name="cpv_dialog_preview_width">66dp</dimen>   <dimen name="cpv_dialog_preview_height">34dp</dimen>   <dimen name="cpv_column_width">30dp</dimen>   <dimen name="cpv_item_size">20dp</dimen>   <dimen name="cpv_item_horizontal_padding">4dp</dimen>   <dimen name="cpv_color_preference_normal">28dp</dimen>   <dimen name="cpv_color_preference_large">40dp</dimen> </resources>

Closing for now. Will review a PR and the dialog does use a ScrollView or you can override the dimensions as suggested. Thanks.


add code coverage + cleanup tests

add code coverage to tests
cleanup test files (separate misc.js to files that make sense)

Done in #110


Add logout test for all backend

Description
Closes #2639.

Readiness checklist

[ ] I added/updated unit tests.
[x] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

:wave: @kropidlowsky
I added additional test for testing logout for already logged out users against all backend :hugs:


Put the transformation checks on the return statement instead of to variables

In OwnedToGuaranteedTransform, FunctionSignatureTransform::OwnedToGuaranteedAnalyze() calls OwnedToGuaranteedAnalyzeResults(), assigns the results to a variable, calls OwnedToGuaranteedAnalyzeParameters(), and assigns that to a variable, and then calls a boolean checking if ANY of those are true.
If the first function returned true, why would we have to call the other one. As a result, I put them on a single return statement conjoined by an OR operator.

This will cause a functional change if either of these function calls has side effects. A quick review of the functions suggest that they do have side effects and are always called on purpose.

I think this is fine. My only concern is if it violates 80 columns. If it does, can you just do an early if, return? I.e.:
if (!foo())
  return false;
return bar();

Actually, sorry, just read this. We need both to execute.

The reason why is we can optimize args or results. If either works, we should try to transform.

They do have side effects, but you can still make those bools const instead.


Installing the Spotify API workaround (rspotify)

Hey, I can't find a way to install the fix for artist page ramsayleung/rspotify#457.

The fix was working fine until today! something must have happened, I submitted an issue here

Oh, ok. Also how do I install any future fixes, because I don't even know if I have installed it right. (im new to rust)

Currently, this issue is not fixed with the latest release. I'm still waiting for upstream to release a new version. Related https://github.com/aome510/spotify-player/issues/330


[BUG] Unable to change the theme with new version 2.3.0

Deployment details:

App version [e.g. v1.7.4]: 2.3.0
Platform [e.g. amd64, arm64, arm/v7]: arm64
Docker image tag [e.g. latest, multiarch]: pawelmalak/flame:multiarch2.3.0

Bug description:
In the theme panel, selecting different theme is not work, it is not registering the click.

Steps to reproduce:

Go to '...' Settings
Click on '....' Theme
Scroll down to '....' Now under App themes, try selecting any theme.

I am using latest MS Edge browser, earlier version (v2.2.2) it was working fine.

It is with NGINX Proxy cache. issue resolved.

@warmbo I just disabled the cache in the Nginx Reverse Proxy, if you already have that disabled, then i would suggest to check it from In-Private browsing, if you still having the issue, the delete the host entry in Nginx reverse Proxy and create new one.
If you are using this with cloudflare proxy, you have to create that too.

@iAmSaugata I'm just trying to use it locally, no proxy, and have same issue. Thanks for the help though!


Bump version to 2.2.0.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.59%. Comparing base (674a78d) to head (1bbbeb4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   93.59%   93.59%
=======================================
  Files           9        9
  Lines        1124     1124
  Branches       99       99
=======================================
  Hits         1052     1052
  Misses         72       72

Flag
Coverage Δ

unittests
93.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rework naming

Add "id" to Publication.Abstract
Add "id" to Publication.Link
Add "id" to Publication.LaySummary
Add "id" to Dataset.Abstract
reasons:

provide id to routes instead of position
in future we can split off these records
in a separate table
no need to set the "index" when providing
a "publication" and an "abstract", as we
can find the right index ourselves by filtering
on its id

rename "_id" to "id" for Publication.Department
Publication.Project
Dataset.Project
Dataset.Department

Publication.Conference.* -> Publication.Conference*

renamed names in PublicationFile:
file.cc_license -> file.license
file.file_name  -> file.name
file.file_size  -> file.size
file.file_id    -> file.id

Publication.SetLink removed
Publication.Abstract removed
Publication.LaySummary removed
reason: only possible reason is "not found", "out of bounds"
better to return pointer or nil from GetAbstract

Publication.AddAbstract
Publication.AddLink
Publication.AddLaySummary
adds id automatically

added Dataset.RemoveAbstract(id)
added  Publication.RemoveLink(id)
added  Publication.RemoveLaySummary(id)
added  Publication.RemoveAbstract(id)
these methods remove the right sub records
when found.
Nothing happens when nothing is found: conflict resolving
can solve this, right? No need to throw an error here,
just before conflict resolving can step in?

Publication.AddProject
Dataset.AddProject
removes potential existing project from the list
and then adds new one at the end.
Actually one should never suggest existing project ids

Publication.AddDepartmentByOrg
Dataset.AddDepartmentByOrg
removes potential existing department from the list
and then adds new one at the end.
Actually one should never suggest existing department ids

Publication.AddFile(file *models.PublicationFile)
automatically generates "id", "date_created" and "date_updated"
"access_level" when not set

change form methods to use this paradigma:
myForm(locale, model, [sub model], errors)
instead of
myForm(context, bind, errors)
see below

fix typo in internal/app/handlers/datasetcreating/import.go that uses "err" instead of "validationErrs"
test: add existing doi that generates a non validating dataset

internal/app/handlers/datasetediting/abstract.go
replace "position" by "abstract_id" in binds
see also internal/routes/register.go
use Dataset#AddAbstract
use Dataset#RemoveAbstract
TODO: when trying to remove an abstract with a non existing
id, code should throw a conflict error?
changed function parameters of abstractForm
to abstractForm(locale, dataset, abstract, errors).
no need to provide index of abstract, as we can find
the right index by searching on id

internal/app/handlers/datasetediting/department.go
replace "position" by "department_id" in binds
see also internal/routes/register.go
use Dataset#AddDepartmentByOrg
use Dataset#RemoveDepartment

internal/app/handlers/datasetediting/details.go
change method detailsForm to
detailsForm(detailsForm(locale, dataset, errors)

internal/app/handlers/datasetediting/project.go
replace "position" by "project_id" in binds
see also internal/routes/register.go.
Question: some project id's may be problematic
for gorilla when constructing an url?
use Dataset#AddProject
use Dataset#RemoveProject

internal/app/handlers/publicationediting/abstract.go
replace "position" by "abstract_id" in binds
see also internal/routes/register.go
use Publication#AddAbstract
use Publication#RemoveAbstract
TODO: when trying to remove an abstract with a non existing
id, code should throw a conflict error?
changed function parameters of abstractForm
to abstractForm(locale, publication, abstract, errors).
no need to provide index of abstract, as we can find
the right index by searching on id

internal/app/handlers/publicationediting/additional_info.go
changed method additionalInfoForm(ctx, bind, errors) to additionalInfoForm(ctx, publication, errors)

internal/app/handlers/publicationediting/book_chapter_details_form.go
changed method bookChapterDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to bookChapterDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/book_details_form.go
changed method bookDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to bookDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/book_editor_details_form.go
changed method bookEditorDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to bookEditorDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/conference.go
changed Conference.* to Conference* fields
changed method conferenceForm(l *locale.Locale, p *models.Publication, errors validation.Errors)
to conferenceForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/conference_details_form.go
changed method conferenceDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to conferenceDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/department.go
replace "position" by "department_id" in binds
see also internal/routes/register.go
use Publication#AddDepartmentByOrg
use Publication#RemoveDepartment

internal/app/handlers/publicationediting/details.go
removed method publicationToBind, as we always
provide the full model to a form method

internal/app/handlers/publicationediting/dissertation_details_form.go
changed method dissertationDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to dissertationDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/files.go
use Publication#AddFile
reflect changes in PublicationFile
change method fileForm(ctx Context, b BindFile, errors validation.Errors)
to fileForm(l *locale.Locale, publication *models.Publication, file *models.PublicationFile, errors validation.Errors)

internal/app/handlers/publicationediting/issue_editor_details_form.go
change method issueEditorDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to issueEditorDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/journal_article_details_form.go
change method journalArticleDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to journalArticleDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/lay_summary.go
replace "position" by "lay_summary_id" in binds
see also internal/routes/register.go
use Publication#AddLaySummary
use Publication#RemoveLaySummary
changed method laySummaryForm(ctx Context, b BindLaySummary, errors validation.Errors)
to laySummaryForm(l *locale.Locale, publication *models.Publication, laySummary *models.Text, errors validation.Errors)

internal/app/handlers/publicationediting/link.go
replace "position" by "link_id" in binds
see also internal/routes/register.go
use Publication#AddLink
use Publication#RemoveLink
changed method linkForm(ctx Context, b BindLink, errors validation.Errors)
to linkForm(l *locale.Locale, publication *models.Publication, link *models.PublicationLink, errors validation.Errors)

internal/app/handlers/publicationediting/miscellaneous_details_form.go
changed method miscellaneousDetailsForm(ctx Context, b *BindDetails, errors validation.Errors)
to miscellaneousDetailsForm(l *locale.Locale, publication *models.Publication, errors validation.Errors)

internal/app/handlers/publicationediting/project.go
replace "position" by "project_id" in binds
see also internal/routes/register.go
use Publication#AddProject
use Publication#RemoveProject

internal/app/handlers/publicationsearching/search.go
reflect change in name from file.FileSize to file.Size

internal/backends/arxiv/client.go
use Publicaton.AddAbstract for automatic id (validation fails otherwise)

internal/backends/bibtex/decoder.go
use Publicaton.AddAbstract for automatic id (validation fails otherwise)

internal/backends/datacite/client.go
use Dataset.AddAbstract for automatic id (validation fails otherwise)

internal/backends/ris/decoder.go
use Publicaton.AddAbstract for automatic id (validation fails otherwise)
use ConferenceName instead of Conference.Name

internal/translations/translations.go
rename cc_license to license

internal/vocabularies/map.go
renamed cc_licenses to licenses
letter_note should be letterNote

Relies on https://github.ugent.be/Universiteitsbibliotheek/librecat/pull/662


SparkSql Editor fetch_result  issues with complex types - Hue 4.10

Describe the bug:
When querying complex types in the latest Spark SQL Editor in Hue 4.10 the results are not being displayed by the _fetch_result method in desktop/libs/notebook/src/notebook/connectors/spark_shell.py
Steps to reproduce it?
Create a table with struct, array ort map types and query it though the SparkSQL Livy Editor
For now I am setting the type to string in case field['type']) is map or array, but maybe a better parser could be used for results fetching in SparkSQL Editor. Have anyone else encountered this issue?
Thanks a lot

Hi @elisabetao,
There has been some improvements recently for SparkSQL, can you once check with the recent master branch? Hue 4.11 is not out yet.

HI @Harshg999 Harsh,
Sorry for the delay, yes I have tested the latest code in the master branch in github , the issues is still there for complex types. Here is how it looks

You can test also on your side with an example as follows:
create table default.structeo(id int, name string, address structcity:string,State:string)
insert into table default.structeo  select 1, 'Test', named_struct('city','Toronto','State','ON') from default.dummy_TBL limit 1
select * from default.structeo
Thanks a lot

Hi @divincode , thanks for the update .
I would expect to have the same results as in Hive  :

I think it's similar to the issue you remarked also for Trino/Presto.
On my side to at least allow the display of the data in desktop/libs/notebook/src/notebook/connectors/spark_shell.py I updated the following in _fetch_result, as a quick hack/workaround :
if 'struct' in str(field['type']):
              meta.append({'name': field['name'], 'type': 'struct' , 'comment': ''})
           elif 'array' in str(field['type']):
              meta.append({'name': field['name'], 'type': 'string' , 'comment': ''})
           elif 'map' in str(field['type']):
              meta.append({'name': field['name'], 'type': 'string' , 'comment': ''})
           else:
              meta.append({'name': field['name'], 'type': field['type'] , 'comment': ''})
          #meta = [{'name': field['name'], 'type': field['type'], 'comment': ''} for field in result['schema']['fields']]

but parsers need to be handled for all non Hive editors for Complex types.
Here's the part of hue.ini that is of interest:
[[interpreters]]
   # Define the name and how to connect and execute the language.
   # http://cloudera.github.io/hue/latest/administrator/configuration/editor/
     [[[sql]]]
      name=SparkSql
      interface=livy

[spark]
 # The Livy Server URL.
 livy_server_url=https://example.domain:8999/

 # Configure Livy to start in local 'process' mode, or 'yarn' workers.
 livy_server_session_kind=yarn

 # Whether Livy requires client to perform Kerberos authentication.
 security_enabled=true

 # Whether Livy requires client to use csrf protection.
 ## csrf_enabled=false

 # Host of the Sql Server
 sql_server_host=example.domain

 # Port of the Sql Server
 sql_server_port=10090

 livy_impersonation_enabled=true

 # Choose whether Hue should validate certificates received from the server.
 ssl_cert_ca_verify=false

 # Use SASL framework to establish connection to host.
 ## use_sasl=false

Hi @elisabetao, thank you for opening this issue!
Complex types query result support is now merged in master via https://github.com/cloudera/hue/pull/3097. It will also be available in upcoming 4.11 release.


Feature/shorter public forecast urls

made public forecast URLs shorter
made public forecast URLs case sensitive
improved the public forecast management screens

Why don't you use a UUID for the token, or bin2hex(random_bytes(20)) ?
IMHO is really enough.


Feeding bytes to a parser

Thank you for working on this parser and publishing it to crates.io!
I'd love to see a way to feed bytes to the parser until a valid frame(s) are encountered and returned.
This will greatly help when developing firmware for embedded devices or any IO input which can feed partial frames.
PS: I'm the community manger at @AeroRust and I would love to take your crate repository under our organization. I'd love to hear your though on this.

This wouldn't be too hard. Some sort of IbusPacketBuilder, could be created, and then it could receive bytes until it encountered a whole valid packet, at which point it would be consumed and return an IbusPacket. At least, this is how I've understood it. Or do you mean some sort of sink for bytes that also functions as a stream?
In regards to having this repository added to an organization, I am curious as to what that would entail. I am open to anything.
Lastly, apologies for the delay in response, I am fairly busy at this moment.

I appreciate the reference. I was personally imagining a fixed size buffer wherein a user feeds bytes, and once a full packet exists, it is returned, and the remaining buffer are shifted over to the left. I will consider using the Read trait (Rust traits are its superpowers after all).

Yes I think before I might be an easy solution especially if it's a Ring buffer of some sort.
There is one drawback to the read trait which I personally haven't researched:
It might be possible to get a partial frame initially so using read_exact might not be ideal.

There is one drawback to the read trait which I personally haven't researched: It might be possible to get a partial frame initially so using read_exact might not be ideal.

I am inclined to agree, which is why I am now hesistant to implement the Read trait, especially since this parser is not a source in the same way a UART or an I2C/TWI line is - that is, the bytes are not meant to be used raw, rather, sent through a parser.
It should be said that I am trying to keep this library in line with the Unix philosophy - do one thing and do it well. It is not the library's job to acquire the bytes from a source, simply to parse them once received.
Lastly, ironically, if I were to implement the embedded_io Read trait, I'd actually not be able to use this new buffered parser with the rppal library, which is ironically the whole reason I started developing this library.
I think a configurable array buffer should suffice for the time being. I will try to learn how to implement a ring buffer using only core and alloc. std has one, but I can't use it, although I may feature-gate it later.


Compile clamav from source

Good to see that this repository seems to be alive again.
I've change the Dockerfile (and the Makefile) quite a bit, have a look here: https://github.com/dirkgomez/bucket-antivirus-function/blob/master/Dockerfile
The rationale: it seems much easier to just compile clamav from a binary. I also updated the whole installation to Python 3.8 and moved the installation to /var/task which is the directory where the lambda runtime expects the action.
Would you consider this? If yes, I would prepare a PR.

Thank you @dirkgomez we will take a look and get back to you soon.


Bump CodeEditModules platform version to .v12

Bumping to .v12 to enable new SwiftUI features in Modules

I think we should stay on v11, Xcode is requiring soon v12 and this can be a great alternative if it can run on v11.

I think we should stay on v11, Xcode is requiring soon v12 and this can be a great alternative if it can run on v11.

Actually, our deployment target is macOS 12.0 and our UI uses some modifiers which are available only since macOS 12.0. So, it doesn't work on macOS 11.0

Somehow the GitHub action does not use macOS 12 when running on macos-latest. So we need to change it to macos-12manually in the action's config

Update: Since Github Actions does not yet support macOS 12 I'm closing this PR for now.
More Info:

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
https://github.com/actions/virtual-environments


Any tutorial for object detection?

Hi I'm going to make implementation of yolo in july :D

HI, I am very greatfull for your example and got the example training the model without any issues.
Have you by any chance been able to make an example of how to use a trained model to find some objects in images.
Is there any example on how to run a segmentation on images with a trained model. I have one where is created a yolo8 model with butterflies.
I have googled but have not come up with anything,
Any help paid would be appreciated
Walter

已收到！

XieXie
You speak english? I need to work on C#, do you have knowledge
Where do you live in China
I will be in Jinan in mai till July
Walter
From: 春笋 @.>
Sent: Montag, 8. April 2024 16:14
To: dotnet/TorchSharpExamples @.>
Cc: Walter Grimm | Q-Auditors @.>; Comment @.>
Subject: Re: [dotnet/TorchSharpExamples] Any tutorial for object detection? (Issue #14)
已收到！
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/TorchSharpExamples/issues/14#issuecomment-2042869182, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKC2QTMCWUYGPRYHA2U2RX3Y4KQ2HAVCNFSM5JSIUT5KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGI4DMOJRHAZA.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>


500 error?

When enabling the plugin on the website of a certain Italian diocese, a 500 error was triggered.
I really have no idea why this is, but it sure needs looking into. I mean, how many other people may have gotten a similar error, but without giving feedback I have no idea how or why. I can't reproduce on my end. But it may very well have to do with them using an old version of PHP on the server.
I've asked them to look at the server logs to see what the error is. Until they give me feedback from the server logs, there isn't a whole lot we can do about it... I have even removed PHP 5.4 completely from my own remote server, I figured most people would have updated a while ago. In theory the plugin should work on PHP 5.4, but since I haven't been using or testing on PHP 5.4 lately who knows, maybe there is some incompatibility?

I have been able to trigger an error when running WordPress on a Windows machine, and when trying to activate a Google Fonts key.
One problem seems to have been the way paths are interpreted on Windows. The WordPress constants were not working at all (I'm guessing because the backslashes needed to be escaped but weren't). In the end I went for using just plugin_dir_path(__FILE__), substituting all backslashes with forward slashes ( $plugin_path = str_replace('\\','/', plugin_dir_path( __FILE__ ) ); ) and followed by the path relative to the current executing / included script. This seems to have taken care of PHP scripts getting loaded properly.
I also some problems communicating with the Google Fonts API from a localhost instance, because of the way the cURL request was being put together. I had to take care of this by conditionally sending IP information based on whether the script is running on a local address or not, so I had to create a method that would check whether the current server address is local:

    private static function isLocalIp( $ip ) {
        $isLocal = false;
        if(filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
            $ipNum = ip2long($ip);
            if(
                ($ipNum >= 167772160    && $ipNum <= 184549375)     //<IP_ADDRESS> – <IP_ADDRESS>
                ||
                ($ipNum >=<PHONE_NUMBER>   && $ipNum <=<PHONE_NUMBER>)    //<IP_ADDRESS> – <IP_ADDRESS>
                ||
                ($ipNum >=<PHONE_NUMBER>   && $ipNum <=<PHONE_NUMBER>)    //<IP_ADDRESS> – <IP_ADDRESS>
            ) {
                $isLocal = true;
            }
        } else if(filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
            if( $ip === "::1" ) {
                $isLocal = true;
            }
        }
        return $isLocal;
    }

If it's not local, then I send it along with the request so that the Google Fonts API knows exactly who is sending the request:
if( false === self::isLocalIp( $_SERVER['SERVER_ADDR'] ) ) {
    curl_setopt($ch, CURLOPT_INTERFACE, $_SERVER['SERVER_ADDR']);
}

This is mostly useful when the API key is restricted to certain IP addresses. If you're using a localhost instance, you want a key without IP address restrictions (and probably even without domain restrictions). If localhost is used for testing, it's probably a key you'll only create temporarily anyways. Make sure you deactivate or delete or restrict the key in the Google Fonts API after you're done testing locally.

I also moved the Minify script to a composer installation, instead of manually loading the script. This way I don't even have to keep the minify script in my Github repository (I don't want my code linting to be influenced by external code anyways). Only thing to look into now is to make sure that a composer install is run by a Github action before checking the code into the SVN repository. We want to be sure that the SVN repository has all the necessary artifacts for the plugin to run correctly.

I got a little more information from the server logs of the nearby diocese.
On March 17th, after installing the plugin in a test WordPress instance that they put up, the webmaster sent me a portion of the server logs (probably cutting out quite a bit of information that might have been useful). There was just one message that gave a little bit of a hint:
Failed to release SSL session cache lock
Facendo un veloce giro sui forum, trovo queste informazioni:
https://serverfault.com/questions/856561/how-to-solve-apache-2-4-ah02026-failed-to-acquire-ssl-session-cache-lock
https://electrictoolbox.com/failed-to-acquire-ssl-session-cache-lock/
https://stackoverflow.com/questions/70068708/ah02026-failed-to-acquire-ssl-session-cache-lock


missing two api calls

request email: https://www.twilio.com/docs/authy/email?code-sample=code-send-a-one-time-passcode-via-email-1&code-language=curl&code-sdk-version=default
and update user's email: https://www.twilio.com/docs/authy/email?code-sample=code-update-authy-user-email-1&code-language=curl&code-sdk-version=default

Thanks for this, I finally got around to adding this in. Check out the new version 3.0.0 of the gem.


Error while using ptr dl_docs

Description of the bug
I have been getting an error for two weeks running pytr dl_docs.
To Reproduce
Steps to reproduce the behavior:

Ran the command pytr dl_docs

Expected behavior
Download of all pdf files from Trade Republic
Error log
/.local/pipx/venvs/pytr/lib/python3.12/site-packages/pytr/timeline.py", line 130, in process_timelineDetail
event = self.timeline_events[response["id"]]
KeyError: '05fcd862-75f4-4271-8236-60ebf207b2f2'
Environment

OS: Mac
pytr version: 0.3.1

Additional context
This used to work for me without a problem. Now there seems to be a problem. Anyone else noticed similar behaviour?

I have narrowed down the problem. When including the parameter last_days parameter it seems to work. There seems to be problem when exporting the christmas present (Weihnachtsgeschenk). Is there a way to fix this?

doesn't work for me even with --last days

doesn't work for me even with --last days

have to correct myself. When I triangulate last days so, that the christmas gift is not in the timespan, it seems to work. Good to know, but somewhat useless since I need to download older values too

Yes, a bugfix is needed to somehow correct the christmas present. Has anyone solved the problem already?

It seems to the same error as the issue #148


Feature: bookmark messages

Complete the following REQUIRED checkboxes:

[X] I have thoroughly read and understand The Odin Project Contributing Guide
[X] The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

[X] I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

1. Because:

Bookmarking messages could come in handy.
2. This PR:

Adds message bookmark feature to odin bot.
Scenario

User reacts to a message they wish to boomark with 🔖

If user has "NOBOT" role

nothing happens

If user has DMs turned off for server members

they get the bookmark message alongside a reminder that they can't recieve DMs in the #bot-spam-playground channel

otherwise

send bookmark message to user's DM

Embed

3. Additional Information:

Used this as a guide: https://discordjs.guide/popular-topics/reactions.html#listening-for-reactions-on-old-messages

I’m very impressed and excited about this. Hope this feature gets added as I see it can be very valuable.


Increment version for search releases

Increment package version after release of com.azure azure-search-documents

This will be done manually in upstream


Crash with 7z basis sets

I'm trying to run a calculation with the benchmark quality 7ZaPa basis set from the basis set exchange, but PySCF just segfaults:
******** <class 'pyscf.scf.hf.RHF'> ********
method = RHF
initial guess = minao
damping factor = 0
level_shift factor = 0
DIIS = <class 'pyscf.scf.diis.CDIIS'>
diis_start_cycle = 1
diis_space = 8
SCF conv_tol = 1e-09
SCF conv_tol_grad = 1e-07
SCF max_cycles = 50
direct_scf = True
direct_scf_tol = 1e-13
chkfile to save SCF result = /tmp/7ztest/tmpfnkfzb59
max_memory 4000 MB (current use 68 MB)
Segmentation fault (core dumped)

The input is the following
from pyscf import gto
from pyscf import dft, scf
import numpy
import os

mol = gto.M(
    verbose = 4,
    symmetry = 0,
    spin = 0,
    atom = '''
Ne 0.0 0.0 0.0
''',
    basis = {
        'Ne' : gto.basis.load('7zapa-nr.txt', 'Ne'),
    }
)

method = scf.RHF(mol)
method.kernel()

I uploaded the basis here:
7zapa-nr.txt
I've identified the issue to be the l=7 K function in the input. If one removes the K function, the calculation runs and converges without problems.
Does something in PySCF or libcint/qcint have a hardcoded angular momentum limit? Can this be somehow increased?
In any case, the program shouldn't segfault but rather emit an error message when the basis set has functions of too high angular momentum.

The integral library does not support 2-electron integrals with basis l >= 7 .
For 1-electron integrals, the limit is l <= 12.

Ah, okay. What's the bottleneck? Is it the lack of higher-order Rys quadrature roots? Looks like there's a semi-recent paper that shows that the roots can be calculated accurately to even absurdly high values: Comput. Phys. Comm. 185, 762 (2014)

Right, the numerical stability issue for high order rys roots. When I
implemented the integrals, I didn't find a robust way to compute rys roots.
Thanks for the paper. I'll try it in the future release.
On Thu, Aug 20, 2020 at 12:00:00AM -0700, Susi Lehtola wrote:

Ah, okay. What's the bottleneck? Is it the lack of higher-order Rys quadrature roots? Looks like there's a semi-recent paper that shows that the roots can be calculated accurately to even absurdly high values: Comput. Phys. Comm. 185, 762 (2014)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pyscf/pyscf/issues/685#issuecomment-677373489

--

I just found a 2016 paper from Harry King on Rys roots and weights, too; I haven't read it yet.
https://pubs.acs.org/doi/pdf/10.1021/acs.jpca.6b10004
@sunqm I saw you've implemented (stable?) integrals up to l=14 in libcint, congrats! This will be great for going to larger basis sets. I guess you're working on the PySCF changes?

Code for regular Coulomb integrals are stable. Small tunings for Coulomb
attenuation (the short-range part) may be applied. But generally they work much
better than older version. Updates in pyscf should come soon.
On Thu, Feb 25, 2021 at 10:08:44PM -0800, Susi Lehtola wrote:

I just found a 2016 paper from Harry King on Rys roots and weights, too; I haven't read it yet.
https://pubs.acs.org/doi/pdf/10.1021/acs.jpca.6b10004
@sunqm I saw you've implemented (stable?) integrals up to l=14 in libcint, congrats! This will be great for going to larger basis sets. I guess you're working on the PySCF changes?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pyscf/pyscf/issues/685#issuecomment-786435269

--

Awesome!

This is an issue of old pyscf verions. Basis angular momentum up to l=15 were supported by pyscf-2.0 and newer versions.


wluma: 4.4.0 → 4.5.1

Adding support for 24.11
Tests: Ran it multiple times and is already present in NisOS unstable channel just simply updated
Package Information

Package name: wluma
Latest released version: 4.5.1 (for 24.11)
Current version on the unstable channel: 4.5.1
Current version on the stable/release channel: 4.4.0

Changes: Minor changes so Latest version works in 24.11 stable
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[X] (Package updates) Added a release notes entry if the change is major or breaking
[X] (Module updates) Added a release notes entry if the change is significant
[X] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Notify maintainers
@yshym @jmc-figueira @Atemu

Hi, does this bump fix any significant bugs that users cannot be expected to bear until 25.05?
We generally only backport to stable if there is good reason to. Users who want the latest and greatest at all times should use the rolling channel.

Please ideally also just cherry-pick the commit that bumped wluma in unstable using -X. It simplest to just add (or request) a backport label on the original PR which makes a bot create a backport PR automatically.

Hi @Atemu,
Yes it fixes Major bugs,
As in wluma by default will crash on Hyprland or other some wlroots based compositor,
but the version change fixes that issue by changing the default config..
Some memory leaks..
and many other minor fixes!
Here is the changelog if you would like
https://github.com/maximbaz/wluma/compare/4.4.1...4.5.0
Thx to let me know about naming convention,
I just learnt about updating packages (Just to fix this issue)
But changed my commit message..

Please ideally also just cherry-pick the commit that bumped wluma in unstable using -X. It simplest to just add (or request) a backport label on the original PR which makes a bot create a backport PR automatically.

Sorry about this as well,
Will learn it and do this, moving forward..

Thanks for adjusting the PR title. However, we need a matching commit message, too - and currently this is still not following the right format.
But, since this is only a single commit, I can adjust the commit message via squash merge.

Sorry about that (Since this was my first commit)
Will make sure to not make such mistakes..
Thanks for merging btw.


Consolidated Issue List

E&O Priority List
Bugs

[ ] Clarify the purpose of Discover search #2215 -- Release 1.11
[x] Case insensitive and partial word search function needed for all searches #2180 -- Release 1.11
Limits resource discovery
[ ] Loading bug with HydroShare GIS #2144, #2185  -- Release 1.12
GIS app should handle viewing multiple files at a time, instead it breaks- related to #2185
[ ] Resource list needs metadata attribute null checks #2171
Corrupted resources break Admin scripts
[ ] Bags don't download properly for selected resources #2056
Corrupted resources need to be fixed- related to #2171
[ ] NWM App Fixes #1716
Bugs with clicking on canals, design improvements, and more-need to cut into separate issues.
[ ] Limit resource file change operations to one file operation per resource at a time #2122
As the system scales we want to prevent file system race conditions.

Feature Requests

[ ] Add Profile requirements to HydroShare new user steps #1915 -- Release 1.12
Improve usage statistics.
[ ] implement automatic email to all new users #2135 -- Release 1.12
Solicit feedback on system from new users. LBrazil will hash out survey content.
[ ] Searching private resources broken #2214
[ ] Making release documentation accurate at release time #1967
Need a staging site for Help Pages, so it stays in sync with releases.
[ ] Folder appearance of file types #1503
Add icons to be associated with all major file types that we support.

Discussion

[ ] Delete Published Resources. How do you remove a published (DOI) resource? #1607
Users formally publish resources by mistake. How do we prevent & make this more evident in the interface?
[ ] Help.HydroShare.org : why pages? #1661
Should read as "Help.HydroShare.org"

Governance / Documentation

[ ] Clean up wiki #408
[ ] Policy and strategy for supporting evolving browsers #473
[ ] Migrate documentation to readthedocs #2039
[ ] Help Page Update -- Resource Type: Time Series #1751
[ ] Help Page Update -- Apps review checklist #1752
[ ] Help Page Update -- Resource Types: Geographic Feature #1753
[ ] Description of apps #1559
[ ] Add functionality description of apps to help page #1560
[ ] Help Page Update- Collection Resource Type #1758

Metadata / Metadata Workflow

[ ] Hydroshare metadata writing back to .nc file #400
[ ] Hydroshare metadata elements "hsterms" capitlization format #608 -
[ ] Refactor read_metadata_from_resource_bag() to use importlib instead of import builtin #640
[ ] Encode sequences in science metadata as sequences in the RDF+XML representation. #658
[ ] Implement updateScienceMetadata REST end point #723
[ ] When editing the spatial coverage information, the invalid value can be saved as metadata #733
[ ] Handle OGC CSW discovery requests #1031
[ ] File metadata for resources #1034
[ ] inconsistency between resourcemap.xml and actual access URLs #1483
[ ] Resolve discrepancies in coordinate system and projection metadata #1518
[ ] Make it possible to upload and incorporate resourcemetadata.xml files created by others #1598
[ ] folder deletion code does not delete type-specific resource metadata from Django #1629
[ ] move file metadata to ResourceFile object #1762
[ ] Discovery -- insufficient metadata to sort creators by last name #1774
[ ] Discovery -- insufficient metadata to categorize spatial coverages by geographic region name #1775
[ ] Creator metadata has insufficient disambiguation for people who are not HydroShare users #1787
[ ] "Reifying" matters of opinion in RDF #1931
[ ] Strategies for storage reduction for highly repetitive metadata, including metadata for CUAHSI HydroServer time series. #1987
[ ] We need to understand how RDF is created from Django #1991
[ ] Resource specific metadata should not be editable for Geographic feature resource type #2021

REST API Specific

[ ] REST endpoint for updating science metadata missing processing of 'relations' #2109
[ ] REST API Enhancements to return additional metadata (optionally) #2112
[ ] REST API for resource metadata update #1423
[ ] File upload and delete work differently in REST API and UI #2177
[ ] Public endpoint for copying from iRODS user zone needed #2187
[x] Flag syntax 't' parameter is confusing #2193
[ ] REST API for resource specific metadata update #2217

UI / UX Issues

[ ] For reference time series it is not possible to add users to access control. The interface element is missing #329
[ ] Comment Reply Emails Unncessary for Your Own Replies #365
[ ] Look at portal.lternet.edu for ideas on improving resource landing page #518
[ ] Create "Model Package" button for Model Instance resource types #545
[ ] Allowing Change of Email #695
[ ] Profile page followup improvements #741
[ ] My Resources Page: Limit the List of Resources to My Resources #765
[ ] Discovery: Create Ability to Add a Discovered Resource to My Resources #767
[ ] My Resources Page: Additional Toolbar Functionality #771
[ ] My Resources Page: Enhancements to the Resource Listing #897
[ ] Resource Metadata: Implement Credit Mapping #941
[ ] Account Creation - Active/Pending workflow #966
[ ] Improvements and optimizations on modal windows #967
[ ] Enhance manage access to generate invitation to join HydroShare #974
[ ] Add author and contributor to include capability identify existing HydroShare user and then automatically fill out content #975
[ ] Add notifications capability #976
[ ] SEO: Include crawlable resource list in profile page w/o JS #981
[ ] Sorting by owner. Should first or last name be used? #1021
[ ] Add content redirects away to landing page #1099
[ ] Open with button to only show apps a user has selected #1161
[ ] Comment editing desparately needed #1213
[ ] Profile and Home Page follow up issues #1237
[ ] Groups: Issue Invitation to Join a Group to a non-HydroShare User #1243
[ ] User group functionality phase-2 #1260
[ ] Show local times #1271
[ ] Add "Log in with Google" functionality #1364
[ ] Add capability to delete comments #1369
[ ] Collections mapping and viewing resource relationships #1387
[ ] Improve consistency in working with people and organizations #1399
[ ] Resource Landing Page Edit Mode: Required Metadata Message Persists Too Long #1411
[ ] Error msg should show up when uploading multiple shapefiles to create one Feature res #1414
[ ] Bulk download of multiple resources #1416
[ ] Discover map is slow and behavior awkward #1479
[ ] Improve the relations tab content entry and display #1494
[ ] Order recent activity in groups from last to first #1505
[ ] Add capability for a user to delete their account #1565
[ ] Square up app icon layout #1569
[ ] Need a right click menu on files to launch apps #1609
[ ] Refining group capabilities #1632
[ ] Provide an embargo/rescission period for publication actions #1649
[ ] User Workflow Feedback - orientation tutorial pop ups to the rescue? #1653
[ ] Terms of use - Page revamp #1714
[ ] Discovery improvements #1755
[ ] Add setting to require agreement to license before manual downloading. #1756
[ ] My resources filter facet counts #1759
[ ] "Visualize" button on resource landing page #1776
[ ] Notifying users of future service outages and changes #1831
[ ] Improve formatting of reset password page. #1835
[ ] MOTD - message of the day #1876
[ ] Google map interface for editing coverage metadata for file types and timeseries resource #1966
[ ] Add About to Header and Footer #1973
[ ] Discover interface shows older versions of resources #1998
[ ] Discovery filter by Resource Type breakpoint display #2016
[ ] REST API doesn't respond to URLs that REST calls generate! #2030
[ ] Change HydroShare New Account Message #2033
[ ] REST endpoint for listing resources should not include obsoleted resources #2045
[ ] Create resource messages repetative regarding irods #2061
[ ] Sync up pages.hydroshare.org footer with www.hydroshare.org footer #2065
[ ] user with EDIT access can undo PUBLIC access but cannot re-institute it. #2080
[ ] Resource creation page: move the multidimensional resource type icon to the geospatial data type list #2086
[ ] New Version of SWAT_MI error if dropdowns are blank #2092
[ ] Add ABOUT to top of pages.hydroshare.org #2093
[x] File icon needed for .shp file #2107
[ ] Spatial coverage in composite resource problems #2110
[ ] Show where (which zone) a resource is stored on resource landing page #2115
[ ] Beta 1.10: Initial My Resources Page View Needs to Change #2116
[ ] UI does not communicate errors to user from REST API #2120
[ ] Timeout issue for large set of file display on resource landing page #2125
[ ] Display a warning when user removes himself as owner #2127
[ ] Create New Resource - Design Updates Needed #2136
[ ] /user throws an error #2164
[ ] Add error checking to the resource stats command #2189
[ ] Add education field to user profile #2190
[ ] Update Quota message text to be more understandable #2196
[ ] Searching private resources broken #2214
[ ] Clarify the purpose of Discover search #2215
[ ] Uploading a file into a resource is not working - files disappear #2216
[ ] Broken resource - exploded when a new file with existing name was added #2224

Administration-Level Tickets

[ ] Email All Email Addresses in HydroShare User Profiles #1867
[ ] Admin panel to list resources by type #1863
[ ] User foreign key field does not show up in Add User Quota dialog from admin panel #2131
[ ] Write management command that allows to change resource GUID #2211

Usage Tracking

[ ] Activity by location #1581
[ ] Resource creation by user type #1579
[ ] Downloaded resources by user type #1580
[ ] Log app launches #2042
[ ] User and Resource metrics cannot be filtered with time #2082
[ ] Active users as default view in Kibana #2094
[ ] Missing activity data #2151

Resource File API / Data Bags

[ ] Incomplete refactor of bag.url for new iRODS BagIt creation workflow #417
[ ] Implement PUT on Resource Files #132
[ ] REST API: Add option to unpack uploaded zipfile on resource creation #485
[ ] REST API: Add ability to ingest resource from fully formed BagIt archive #486
[ ] Add REST API call to ingest file already in iRODS #684
[ ] Resource creation file validation peculiarity #707
[ ] REST API needs to support iRODS federation zone for resource creation and adding files to resources #1276
[ ] download all resources contained in one collection #1304
[ ] Add Project/Organization Branding to Resource Pages #1555
[ ] Implement file quota #1566
[ ] Upload into folder places file at the top level #1671
[ ] data/contents subpath does not belong in /hsapi/resource/{pk}/functions paths #1956
[ ] New REST endpoint for setting file type #1993
[ ] signals are not consistently raised in file/folder operations #2020
[ ] File URLs incorrect in REST API after ResourceFile fix. #2025
[ ] Got error when removing multiple folders from Composite resource #2029
[ ] Completing implementation of logical files #2099
[ ] Avoid embedding configuration into ResourceFile paths #2104
[ ] Should be able to rename and/or move some kinds of files in composite resource #2124
[ ] No resource file gets uploaded when creating a Composite Res through hs_restclient 1.2.8 #2137
[ ] Allow unzipping of compressed file formats other than zip #2143
[ ] Improve unzipping performance for zip file with large set of files and complicated folder structure #2153
[ ] Add check to make sure new quota holder has enough quota #2160
[ ] Management command to set default logical file for composite resource #2162

Code-level improvements

[ ] print names of resource objects #890
[ ] subclassing QuerySet to integrate resources, access control, and labels #831
[ ] REST interface to groups is outdated #920
[ ] Remove Hydroshare Author Group #624
[ ] Make bag replication to iRODS user zone to call create_bags_by_irods asynchronously #1404
[ ] Allow using existing units for TimeSeries Result element editing #1472
[ ] Updates to REST interface #1515
[ ] Include current python-irodsclient in dev build configuration #1590
[ ] Django constraints upon resource models are inadequate #1645
[ ] Add optional author identifiers #1666
[ ] Fail to share resource #1712
[ ] django model constraints inadequate #1765
[ ] Beta 1.10: Editing Site Elevation Throws Error if Decimal #2068
[ ] debugging really complex user interfaces #2095
[ ] Incorrect user logged as making automatic changes #2103
[ ] Lack of REST API decorators causes uncaught exceptions in system log #2123

Clean Up / Updates

[ ] Evaluate code redundancy #958
[ ] Update Django REST Framework to 3.5.3 #1589
[ ] Multiple resource file endpoints should be consolidated #1548
[ ] add autopep8 to dev environment #1634
[ ] Update packages installed from requirements.txt #2017

Security

[ ] Update to defused XML packages #659
[ ] Pass http/https status from nginx to django #1711
[ ] Turn back on Security Features #2058
[ ] Explore Default Deny / Default Permit attributes on API #1722
[ ] Review CORS + CSP #1806
[ ] Uploaded executable files should be scanned for viruses. #1709

Testing

[ ] Unit tests fails occassionally #1433
[ ] Write unit tests for metadata xml for hs_core #1481
[ ] Write unit tests for metadata xml for time series resource #1482
[ ] unit test for post_metadata_update receiver implemented in model instance resources #1507
[ ] It would really help if stacked build requests in Jenkins were automatically cancelled #1965
[ ] Make selenium tests work in Firefox #2013
[ ] Add selenium tests for user registration #2165

Resource type-specific issues

[ ] Reference Model Program resource to allow publication without content files #856
[ ] River Geometry Resource Refinements #619
[ ] Create Workflow Resource Type #748
[ ] Model Program - Git support #923
[ ] Script file extensions should not be limited to .r .py and .m only #1030
[ ] Web App - Edit page enhancements #1093
[ ] Web App - OAuth Clarification #1094
[ ] Failed to create a new version for the Model Instance resource type when linked to a specific Model Program resource #1140
[ ] Unexpected results when searching for Model Instance resource through "Filter by Resource Type" table #1142
[ ] Lower the barrier for creating new specific Model Instance resource types #1216
[ ] Query Model Program with the linked Model Instance #1249
[ ] Feature Res Type: Extract metadata from xml file attached with ESRI shapefile #1421
[ ] Modflow Model Instance Phase 2 #1428
[ ] Auto-create WMS/WFS/WCS layer for Raster and GeographicFeature resources #1450
[ ] Implement delete function for swat model instance #1500
[ ] Create Geographic Feature Resource Fails #1547
[ ] Reference time series rework #1570
[ ] Add reference time series logical file type to composite resource #1571
[ ] Add time series logical file type to composite resource #1573
[ ] Update the App Resource Type to include Registering an App to a specific file extension #1610
[ ] refine webapp resource metadata logic #1673
[ ] SWAT REST API fails test in federated mode #1724
[ ] Catalog CSDMS Models in Hydroshare #2019
[ ] Bulk metadata update for Time Series Resource #2028
[ ] Geographic feature file type #2036
[ ] No information on Geographic Feature Resource type in terms page #2057
[ ] NetCDF resource file validation error #2087
[ ] Geo Feature Resource creation issues #2106

Apps

[ ] HydroShare GIS app - more efficient way to access cumulative size of resource files #1294
[ ] Improve the EPA WATERS Services HydroShare App #1315
[ ] Need to hardwire beta.hydroshare.org to appsdev.hydroshare.org and vice versa #1545
[ ] National Water Model Upload to HydroShare: Broken #1626
[ ] Worldwater app directs to a website...not an app #1638
[ ] National Water Model Data Explorer...is not technically an app #1640
[ ] USGS and AHPS Gaugeviewer WML broken #1641
[ ] Apps: Simple Styling Modifications #1642
[ ] HydroShare GIS features that depend on hs_restclient functionality #1692
[ ] weird username displayed on apps-tethys home page #1715
[ ] Enable unlimited, bidirectional file transfer for apps #1842
[ ] Release management and quality control for apps #1843
[ ] App-HydroShare I/O consistency and best practices #1848
[ ] Track app status #2023
[ ] HydroShareGIS cannot open composite resources #2185
[ ] NWM Viewer - Missing help for subsetting #2201
[ ] NWM Viewer - Missing help button #2202
[ ] NWM Viewer - Toolbar button positions change when screen is maximized #2203
[ ] NWM Viewer - Subset Watershed button activated when no watershed has been loaded #2204
[ ] NWM Viewer - Begin time should be constrained #2205
[ ] NWM Viewer - Form titles revision #2206
[ ] NWM Viewer - Documentation for Configuration #2207
[ ] NWM Viewer - Improve Workflow #2208
[ ] NWM Viewer - Zooms to Kansas Randomly #2209
[ ] NWM Viewer - Remove Lat Lon coordinates #2210
[ ] Data Rods Explorer App: Data retrieval is incurring errors from NASA web-services #2222

SWATShare

[ ] Implement functions that allow SWATShare users to import SWAT model instance resources from HydroShare #595
[ ] Develop SWATShare component which can be launched using the Hydroshare app URL convention #597
[ ] SWATshare model update - pending Error 'Downloading and Extracting the resource failed' #2167

Candidates to be moved away from github issues

[ ] JENKINS CI - Developer Deployment Usage #898

JupyterHub Integration

[ ] Sync HydroShare irods userspace on JupyterHub notebook server #1368
[ ] Jupyter notebook quality check #1567
[ ] JupyterHub-NCSA app broken #1636
[ ] Enable use of irsync for Jypyter notebooks manipulations of genericResource, compositeResource #2146

Misc. External Integrations

[ ] Integrate RHESSys model resource instance with new resource metadata model #178
[ ] Fix Large File Subsetting in HydroShare Hyrax #2024
[ ] Improving interoperability between Hydroservers and HydroShare #1984
[ ] MOPEX needs #1963
[ ] iRODS federation for expanded storage #1918
[ ] iRODS connectivity enhancements #1930
[ ] Improvements to iRODS federation code #1657
[ ] New Django REST call to issue iRODS read (and possibly write) tickets #2147
[ ] How to access HydroShare iRODS hydroshareuserZone from Linux VM #2003
[ ] DataOne reference resource #1892
[ ] DataONE Tier 1 (Read-Only) Compatible API REST API #129

Hi Mark, you can add https://github.com/hydroshare/hydroshare/issues/2167    You may want to move down your list of SWATshare into the Apps section.
Here is the  E&O priorities. Last week I went though and used the label 'user experience' for things that we have initiated or are tracking.

Caps searching - Discover should interpret Postcard and postcard the same way. (Alva may have made this an issue).  Christina
Add profile requirements to HydroShare new user steps  Mark!!!  https://github.com/hydroshare/hydroshare/issues/1915
Implement automatic email to new users with survey link Liza  -   onboarding/Welcome  https://github.com/hydroshare/hydroshare/issues/2135
#1607 - new users getting DOIs because they click through without reading  10-20% click through without reading. Educate on the semantics of publish. Publish is the wrong word for the button.  Mark
2122 &  2056    HydroShare deals poorly with concurrent operations and big data  and Broken resources *** This seems like a major issue (I’d put up there with #1 and #2 but it seems like a complicated solution so doubt will get fixed quickly?)    Chief Canary Herder - Christina   ‘no more limp and poisoned canaries in the HydroShare coalmine’.  Mark and Alva
2144     Loading bug with multiple files/projects in HydroShare GIS App  Jon and Liza
Help.HydroShare.org : why pages?   Change to Help #1661 - do we want to go from Pages to Help in the URL?  Move future issue to current issue. (links need redirects)   Mark
#1967 - Release- documentation timing   Liza
#1503 - folder appearance - do we like it as is? Or do we want more done?  Jim
Other App Bugs
Add Issue for New Release App printable demo testing by HydroInformatics conference (coordinate with Mark and Jon (white paper)).
#1716 NWM is being updated now.    Christina

Thanks @ChristinaB! I've updated the list and put these issues right at the top.

Hi Mark  - What process do you want to keep this updated and tracking priorities?  Here is the first update on the Caps searching for Discovery -- now has an issue assigned to Alva.
https://github.com/hydroshare/hydroshare/issues/2180

Hi @aphelionz
There are two new App bugs which are intended to pass along App assessment to CUAHSI and developers.  They each contain links to the State of the App (SOTA) Report, link to help pages, link to demos/flyers on HydroShare, and link to documents on Google Drive.
List of App related Github Issues WITH  SOTA report:
Suggested Improvements for EPA Waters App #2234
Data Rods Explorer App: Data retrieval NASA web-service update needed #2222
@jphuong and I will be adding a few more - these may need a special App section in this long list, up to you.  They are not on the E&O priority list, but they could be if determined by PIs and developers (those conversations should happen in Alabama).

A full table of links for each App are currently on Page 2 of the E&Outreach meeting notes.

@aphelionz  - I was going to send this by Jon Pollack, but he does not drop down as a link on this repository.

Closing this in favor of another method of tracking


add other solutions to RetinaNet

@yhenon  HI
As for some one-stage detectors, like SSD, a common solution is to perform some form of hard negative mining,such as the positive and negative samples are selected according to the ratio of 1:3 .
For the code of RetinaNet, it seems not use this strategy.If add these strategies, the effect should be better?? I wonder what you think??
many many thanks

if you use both the focal loss and hard negative mining, the effect would be worse


13| Roman To Integer | C++

Title -
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[x] Improving Code
[x] Improving Documentation
[x] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[ ] Python
[x] C++
[ ] Java
[ ] SQL

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

please assign me this issue @SSKale1 @Yashica7

i can do this very well ,would love to work on it @hjpassion

I would like to take this up in CPP. Please assign it to me.

I would like to work on this in Java if that's alright!


Texture stretching

Godot version:
3.2.1.stable.official
OS/device including version:
Android 4.4 Samsung S3 Note Samsung Galaxy Tab 3 8.0 SM-T311, GLES 2
Issue description:
In GLES 2 on a standard 3d-plane, the texture is stretched
Steps to reproduce:
Create a standard 3d-plane, standard material (I use unshaded), assign any texture (I used .png with standard export settings).
Editor (windows 10):

Android 4.4

@DDru Please upload a minimal reproduction project to make this easier to troubleshoot.

@Calinou bug proj.zip

This is how it looks on Galaxy S8+ / Android 9

Android 4.4
GLES: ARM, Mali-450 MP, OpenGL ES 2.0
GL_EXT_debug_marker GL_OES_texture_npot GL_OES_compressed_ETC1_RGB8_texture GL_OES_standard_derivatives GL_OES_EGL_image GL_OES_depth24 GL_ARM_rgba8 GL_ARM_mali_shader_binary GL_OES_depth_texture GL_OES_packed_depth_stencil GL_EXT_texture_format_BGRA8888 GL_OES_vertex_half_float GL_EXT_blend_minmax GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_rgb8_rgba8 GL_EXT_multisampled_render_to_texture GL_EXT_discard_framebuffer GL_OES_get_program_binary GL_ARM_mali_program_binary GL_EXT_shader_texture_lod GL_EXT_robustness GL_OES_depth_texture_cube_map GL_KHR_debug
EGL:
EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_fence_sync EGL_ANDROID_image_native_buffer EGL_ANDROID_recordable EGL_ANDROID_native_fence_sync EGL_ANDROID_framebuffer_target EGL_EXT_create_context_robustness EGL_ANDROID_blob_cache

@avril-gh tested device has Mali-400 MP4 and Android: 4.4.2
Also i made mistake about device name. Correct name is Samsung Galaxy Tab 3 8.0 SM-T311

@DDru
Try to enable debug and see if there's anything 'interesting' in log file
project settings - > debug -> settings -> verbose stdout - enable
project settings - > logging -> file logging -> enable file logging - enable
(log path, is where your log will be on android device, by default its in data/data/yourappname/logs)
also, my image is from latest v3.2.2.rc, would you like to try out on v3.2.2.rc perhaps ?

@avril-gh

also, my image is from latest v3.2.2.rc, would you like to try out on v3.2.2.rc perhaps ?

in 3.2.2.rc.official no any changes

Try to enable debug and see if there's anything 'interesting' in log file

I found logs only in editor. And they had some strange lines:
...
ADDING: res/mipmap/icon_background.png
ADDING: res/mipmap/icon_foreground.png
Unicode error: invalid skip
Unicode error: invalid skip
Unicode error: invalid skip
Unicode error: invalid skip
Unicode error: invalid skip
Unicode error: no space left
ADDING: resources.arsc
0 param: --xr_mode_regular
1 param: --use_depth_32
2 param: --use_immersive
Installing to device (please wait...): Samsung SM-T311

Project directory and path to Godot.exe has only latin-symbols.

Just a hunch, do you get the same problem with a power of 2 texture size? (i.e. 256x256, 512x512 etc)

@DDru , @lawnjelly is very true, your texture is 340px. Try texture with something like x8 let it be 320x320px. ( and btw, what a smart debug idea with this UV, im impressed :smile: )

@avril-gh, @lawnjelly no. At first I used the neighboring texture "checker.png", which is 1024x1024 size and I saw an error on it.

@lawnjelly, visualization UV-coordinates really shows error.
Editor:

Android:

This is because vertex shading is forced by default on mobile. You can disable it in the Project Settings.

I think even with vertex shading these should interpolate correctly (this is basic texture mapping).
From what I can see it looks like the vertex UVs are incorrect in the vertex shader. It would be helpful to see the glsl shaders (rather than uber shader) that are produced to get an idea of what might be causing a problem on this hardware. I'll print these here if I have time to look at the issue. (or @clayjohn)

@lawnjelly, standart CubeMesh, and plane from Blender get bug too.
But on model from Blender it look different.

Hmm, thanks for the extra tests. Have to admit I can't immediately think of an easy way to pin this down remotely. There are a lot of possibilities. It might be one of those cases where one of the rendering team would need access to this hardware.
There's also no high precision available on the Mali 400 MP4 in the fragment shader if the UVs are touched, but I don't think this is fragment shader problem (the texture would presumably look more pixellated if it was).
It is very likely to be a hardware / driver bug or peculiarity, but we could also be doing something like godot accessing the wrong attribute location for the UVs.

@DDru Can you (or anyone else) still reproduce this bug in Godot 3.4.2 or any later release?

I'll close this as nobody else has been able to reproduce this recently. Please comment (with the issue template filled) if you can still reproduce this.


Add testing

This adds testing options, locally with tox and via Travis. The travis testing will require @h-m-f-t to enable that integration.

I'll leave it to @h-m-f-t to do the final approval, since he has the ability to turn on Travis.

No worries. And thanks for fixing the merge conflict, I was trying to do that same thing here, but you were faster than me by 1 minute... ;)

I'm going to go ahead and merge this, so the pull request stops requiring merges with origin/master.  We still need @h-m-f-t to turn on Travis-CI for the repository.  I don't have sufficient permissions to do it.


Issue 678: Testing solidity strings with getters/setters

Unable to confirm reported bug.

Looks like a lot of commits for relatively small net change - I'd recommend squashing the commits and doing git push -f to keep the change log easier to read


Math ops with Tensorflow Lite C++ and Android NDK

I have successfully installed Tensorflow Lite (C++/so) into an Android product (NDK). I'm looking for the tensorflow math operations, do they exist in tensorflow lite? Or is the sole purpose of tensorflow lite to run inference on models? I also can't seem to find array_ops.h in the tensorflow repository, is this cross complied from some other language?
TLDR: Does tensorflow lite lack math ops and in order to use them you need the full tensorflow?

In short, YES. But no, there is no full tensorflow on Android (as far as I can remember previous TensorFlow Mobile is a subset of TF). And you can use something like flex in TFLite to use TF ops. Check this doc for flex and thie one for  op list

Closing this issue since explanation given by @freedomtan is correct. Feel free to reopen the issue if have any follow up questions. Thanks!


(PUP-2551) Simplify lowercase certname warning

(PUP-2551) Updates to simplify the certname case warning as well as the attached documentation.
#puppethack

This is mirrored by https://github.com/puppetlabs/puppet-docs/pull/748 in the documentation

Thanks @drewablank - do you know if there's a JIRA ticket associated with this improvement yet? We try to have commit message titles reference the ticket, number, ie (PUP-NNNN) do a thing..

Sorry @MosesMendoza - updated the title accordingly

CLA signed by all contributors.

Thank you @drewablank!  Sorry for the hassle!

weird - looks like a transient travis failure - will rekick

Thanks @drewablank!


Next steps for repo2docker

This issue collects "next steps" for the project. Each step should fit into one of the following three categories:

now, very concrete/actionable step that is ready for someone to pick it up and work on
soon, less concrete/actionable step that is going to happen soon, discussions around the topic are coming close to an end at which point it can move into the "now" category
later, abstract ideas or tasks, need a lot of discussion or experimentation to shape the idea so that it can be discussed. Should also contain concrete/actionable steps that have been postponed on purpose (these are steps that could be in "now" but the decision was taken to work on them later)

Please leave comments on the order/ideas mentioned here and I will incorporate them. The plan is to start with this list and as things get done or removed add new ones. This means this list should not be exhaustive, it should only represent the "top of the stack" of ideas.
Let's see if we can keep this as an issue instead of a file to make it easier to update. my suggestion would be to use this issue to create a first list and a short "user manual" for it, then create a new issue titled "ROADMAP" and use that from then on with the top comment in that issue representing the ROADMAP at all times.
Guiding thought for the next months:
Repo2docker is a dependable tool used by humans that reduces the complexity of creating the environment in which a piece of software can be executed.
Now

reduce documentation typos and syntax errors
Julia Manifest support (https://docs.julialang.org/en/v1/stdlib/Pkg/index.html)
increase test coverage (https://codecov.io/gh/jupyter/repo2docker/tree/master/repo2docker for low coverage files)
reduce execution time of tests
make a new release once Pipfile and nix support have been merged

Soon

the contributor highway, define the route from newcomer to project lead
add support for using ZIP files as the repo (repo2docker https://example.com/an-archive.zip) this will give us access to several archives (like Zenodo) that expose things as ZIP files.
add support for Zenodo (repo2docker 10.5281/zenodo.1476680) so Zenodo software archives can be used as the source in addition to a git repository
tooling to make it easier to produce good requirements.txt, environment.yml, etc files. They should help users create versions of these files that have a high chance of still working in a few months
support for running with GPU acceleration

Later

repo2docker in repo2docker, to reproduce an environment users need to specify the repository and the version of repo2docker to use. Add support for repo2docker inspecting a repo and then starting a different version of itself to build the image
support execution on a remote host (with more resources than available locally) via the command-line

Nice! One challenge with using an Issue for this is that it's harder to see roadmap evolution over time than a tracked file.

Good point. I had not thought that we might need/want that. What would we do with that information? If we use a file should we update it in a destructive way (use git history for history) or more like a change log which is prepend only?
The use cases I had considered is:

as a user I want to know what is coming next
as a contributor I want to know where to get involved
as a contributor I'd like to know what has been purposefully postponed to later
as a maintainer I want to build consensus around the direction we want to go in the next few weeks

I have a few concerns about using a github issue for roadmaps:

It is super non-discoverable. I think roadmaps are half for the developer team, half for the non-developer (or potential developer) community. Github issues will quickly fall off of the top page, which means they're virtually invisible to anybody not explicitly looking for them.
It is not easy to collaboratively edit. Often folks don't feel comfortable editing the comments of somebody else, and our only other option here is for you to manually re-update the top-level comment each time something changes.
It is very github-focused. Which is fine if roadmaps are only for developers, but IMO they are not only for developers. I want our roadmap displayed in a non-github fashion somewhere (e.g., the documentation)
As Min suggests, it obfuscates provenance around how the roadmap changes, and who made those changes.

Maybe some of these could be worked around if we advertised the roadmap heavily on, e.g., the repo2docker documentation and jupyter.org, but I feel like having it in proper document form would be a better long-term solution. Happy to hear arguments to the contrary!


Port to Terraform 0.12

What does this PR change?
It adapts code to run with the newest Terraform version.

When do you plan to move to terraform 0.12?

As soon as I can finish the coding and test it thoroughly.

Hopefully that could happen in a month or so.

All changes here have been thoroughly tested via the SUSE Manager and Uyuni CI systems.
I plan to merge this PR tomorrow.


Back-end for videos

We created controller, repository, router folder and a table for videos on the server side.

good work


FastAPI integration with Okta using OpenIDConnect

I am trying to integrate FastAPI authentication with Okta using OpenIDConnect.
I could find library for Flask https://flask-oidc.readthedocs.io/en/latest/ but could not find something similar for FastAPI.
Can someone please help with the same.

I've found this: https://github.com/tiangolo/fastapi/issues/488
Could you let us know if this is somehow helpful?

Thanks for sharing #488 , I went through it, but it doesn't seems to be of much help as Okta authentication works differently.

@gopalsi authlib has a fastapi intergration that might work: https://docs.authlib.org/en/latest/client/fastapi.html

@gopalsi Did you find the solution for Okta + FastAPI integration? I am looking for something like this Flask integration: https://developer.okta.com/blog/2018/07/12/flask-tutorial-simple-user-registration-and-login or this: https://github.com/okta/samples-python-flask . I am sure it's doable, but I couldn't find any examples.

FWIW I implemented a solution here.


make install is broken on Ubuntu 22.04

Multiple issues with installing HAL on Ubuntu 22.04:
ldconfig isn't run at the appropriate time
When running make install, ldconfig is invoked via the post_install.cmake.in config, but that happens too early, namely before instead of after installing the shared objects (and plugins). See make install output snippet below:
[…]
-- Installing: /usr/local/share/cmake/hal/halTargets.cmake
-- Installing: /usr/local/share/cmake/hal/halTargets-release.cmake
-- Installing: /usr/local/share/hal/ld_conf/hal.conf
-- Copy file /usr/local/share/hal/ld_conf/hal.conf to /etc/ld.so.conf.d/
-- Running: ldconfig
-- Installing: /usr/local/lib/libhal_core.so
-- Set runtime path of "/usr/local/lib/libhal_core.so" to ""
-- Installing: /usr/local/lib/libhal_utilities.so
-- Installing: /usr/local/lib/libhal_netlist.so
-- Set runtime path of "/usr/local/lib/libhal_netlist.so" to ""
-- Installing: /usr/local/lib/libhal_plugin_system.so
-- Set runtime path of "/usr/local/lib/libhal_plugin_system.so" to ""
-- Installing: /usr/local/lib/hal_py.so
-- Set runtime path of "/usr/local/lib/hal_py.so" to ""
-- Installing: /usr/local/bin/hal
-- Set runtime path of "/usr/local/bin/hal" to ""
[…]

Manually invoking ldconfig once is enough to fix the issue, but this should be handled properly by the build toolchain.
Plugins with dependencies won't load
After installing HAL as above, any plugin that depends on a plugin .so file won't load:
[14.10.2024 13:39:48] [core] [info] loading plugin '/usr/local/lib/hal_plugins/logic_evaluator.so'...
[14.10.2024 13:39:48] [core] [error] [/home/hrecourse/hal/src/plugin_system/runtime_library.cpp:47] cannot load library '/usr/local/lib/hal_plugins/logic_evaluator.so' (error: netlist_simulator_controller.so: cannot open shared object file: No such file or directory) -- did you properly link the plugin?
[14.10.2024 13:39:48] [gui] [warning] [/home/hrecourse/hal/plugins/gui/src/plugin_relay/gui_plugin_manager.cpp:551] Error loading plugin 'logic_evaluator' from location '/usr/local/lib/hal_plugins/logic_evaluator.so'
[14.10.2024 13:39:48] [gui] [warning] [/home/hrecourse/hal/plugins/gui/src/plugin_relay/gui_plugin_manager.cpp:389] GuiPluginManager: loading of 'logic_evaluator' failed, is it really a HAL plugin?

HAL appears to be looking for the shared object in the wrong location:
$ strace -f -e trace=file hal -g
[…]
[14.10.2024 13:48:39] [core] [info] loading plugin '/usr/local/lib/hal_plugins/logic_evaluator.so'...
[pid 35139] openat(AT_FDCWD, "/usr/local/lib/hal_plugins/logic_evaluator.so", O_RDONLY|O_CLOEXEC) = 24
[pid 35139] newfstatat(24, "", {st_mode=S_IFREG|0755, st_size=783584, ...}, AT_EMPTY_PATH) = 0
[pid 35139] openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 24
[pid 35139] newfstatat(24, "", {st_mode=S_IFREG|0644, st_size=78063, ...}, AT_EMPTY_PATH) = 0
[pid 35139] openat(AT_FDCWD, "/lib/x86_64-linux-gnu/netlist_simulator_controller.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid 35139] openat(AT_FDCWD, "/usr/lib/x86_64-linux-gnu/netlist_simulator_controller.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid 35139] openat(AT_FDCWD, "/lib/netlist_simulator_controller.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[pid 35139] openat(AT_FDCWD, "/usr/lib/netlist_simulator_controller.so", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
[14.10.2024 13:48:39] [core] [error] [/home/hrecourse/hal/src/plugin_system/runtime_library.cpp:47] cannot load library '/usr/local/lib/hal_plugins/logic_evaluator.so' (error: netlist_simulator_controller.so: cannot open shared object file: No such file or directory) -- did you properly link the plugin?

@joern274 About that dependency issue: Any insights on what may be going on in the plugin manager here? Is this a configuration problem at install time (e.g. some library path not correctly configured) or caused by the way the plugin manager looks for dependencies?


Try installing NoMachine

This PR attempts to add NoMachine (as both a client and a server) to the image.

It looks like the install failed. I'll just use RustDesk.


ist8310: remove calibration code

it does nothing useful
increases boot time by 2 seconds on pixhawk 4 due to a poll timeout:

IST8310 on I2C bus 3 at 0x0e (bus: 100 KHz, max: 400 KHz)
WARN  [ist8310] ERROR: TIMEOUT 2

Same copypasta in the lis3mdl as well? https://github.com/PX4/Firmware/blob/225a3a0cbaa8e8f04fbbff2bf4c73f96a681fd23/src/drivers/magnetometer/lis3mdl/lis3mdl.cpp#L117


12hr Time on the timetable

The 12 hour time format does not work on the page for the timetable.

I can recreate this, and the timetable does do this.

Fixed 6dddd84467c633a27882c86103b3460bc88df8ed


Eag 1170  column reorder

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

@Daj001 How are sections different from row groups?
If you can remove all the release files, it would be helpful reviewing the PR.


Added new tests to gtractResampleDWIInPlace and fixed the bug related to the content of gradient directions table

This pull request includes two commits.
The first one adds new tests, and the second patch fixes the bug introduced by the new tests.
Each patch is described by a comprehensive commit message.

@hjmjohnson
Hans, Please review this pull request. Thanks.

GREAT WORK.  the wiki page really helps.


Problems with the client name when it has accents

It has happened to me lately that when I receive emails from people who have accents in their name, these are not displayed properly and shows a long text, I attach a test image.

class MailboxResourceWebklexResource extends JsonResource
{
    /**
     * Transform the resource into an array.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable
     */
    public function toArray($request)
    {
        $today =Carbon::now();
        $date = null;
        $dateMail = Carbon::parse($this->date[0])->format('Y-m-d');

        if ($today->format('Y-m-d') == $dateMail) {
            $date = mb_strtolower(Carbon::parse($this->date[0])->format('H:i A'));
        }

        return [
            'uid'   => $this->uid,
            'from'  => $this->from[0]->mail,
            'client'=> $this->from[0]->personal, //This is the problem
            'to'    => $this->to[0]->full,
            'date'  => (is_null($date) ? ucwords($this->date[0]->formatLocalized('%d %b')) : $date),
            'full_date' => Carbon::parse($this->date[0])->format('d-m-Y').', '.Carbon::parse($this->date[0])->format('H:i'),
            'subject'=> $this->subject[0],
            'flags' => (isset($this->flags['seen']) ? $this->flags['seen'] : null)
        ];
    }
}

hi, this kind of string is a quoted-printable-encoding (the ?Q? mean this) you can decode it with below code:
$subject = '=?iso-8859-1?Q?Jos=E9_Antonio_Valiencia?=';
var_dump(mb_decode_mimeheader (str_replace('_', ' ', $subject)));

The replace is required because in Q encoding mode, RFC 2047 encodes spaces as _ (Section 4.2).
Just as info, another encoding exist, is the "B" mode,  is a base64 Encoding mode, also this case is handled by mb_decode_mimeheader below an example with same string of previous example encoded as base64:
 $subject = '=?iso-8859-1?B?Sm9zw6kgQW50b25pbyBWYWxpZW5jaWE=?=';
 var_dump(mb_decode_mimeheader($subject));

Hi @mdemori ,
that's interesting, do you know if those have to be handled separately or are they "included" within these functions?

mailparse_rfc822_parse_addresses
imap_mime_header_decode
iconv
mb_convert_encoding

Best regards,

Hi @Webklex
I would suggest to use the function iconv_mime_decode($subject), as this method will not only take care of the quoted printable encoding but also of the character set and encoding ...
See https://www.php.net/iconv_mime_decode for further information.
Kind regards
Dominik

Please update to v5.1 and give it another try.
If you are currently using an older version below v5.0, please read the breaking changes leading up to v5.1 before upgrading.
Best regards,