Improve article astro-ph/9701158

Exact location of issue
Starting some place around table 1
Problem details
latexml seems to be misinterpreting the table alignment details, leading to first a lack of spaces following the tables, and then generally losing the rest of the article content.
This may be a limitation of our latexml binding for epsf.sty, but a proper troubleshooting session is needed to nail down the exact cause.

After extracting a minimal example here, I think this may be a productive stress test for classic TeX alignment primitives.
Here is a minimal snippet, which works in pdftex, but will produce latexml errors if there are too many (or none) linebreaks before the final \bye:
%----------------------Tables----------------------------------
\newtoks\pream \pream={#\strut}
\newtoks\lpream \lpream={&#\hfil}
\newtoks\rpream \rpream={&\hfil#}
\newtoks\cpream \cpream={&\hfil#\hfil}
\newtoks\mpream \mpream={&&\hfil#\hfil}

\newcount\ncol \def\ncolp{\advance\ncol by 1}
\def\atalias#1{
    \ifx#1l\edef\xpream{\pream={\the\pream\the\lpream}}\xpream\ncolp\fi
    \ifx#1r\edef\xpream{\pream={\the\pream\the\rpream}}\xpream\ncolp\fi
    \ifx#1c\edef\xpream{\pream={\the\pream\the\cpream}}\xpream\ncolp\fi}
\catcode`@=\active

\def\taborl#1{\omit\unskip#1\hfil}
\def\taborc#1{\omit\hfil#1\hfil}
\def\taborr#1{\omit\hfil#1}
\def\multicol#1{\multispan#1\let\omit\relax}

\def\table#1\par{\midinsert\offinterlineskip\everydisplay{}
    \let@\atalias \let\l\taborl \let\r\taborr \let\c\taborc
    \def\space{\noalign{\vskip2pt}}
    \def\tablerule{\omit&\multispan{\the\ncol}\hrulefill\cr}
    \def\onerule{\space\space\tablerule\space\space}
    \def\tworules{\space\space\tablerule\space\tablerule\space\space}
    \def\annot##1\\{&\multispan{\the\ncol}##1\hfil\cr}
    \def\\{\let\\=\cr
           \edef\xpream{\pream={\the\pream\the\mpream}}\xpream
           \edef\starthalign{$$\vbox\bgroup\halign\bgroup\the\pream\cr}
           \starthalign
           \annot\hfil Table #1\\ \noalign{\medskip}}
    \let\par\endtable}

\edef\endtable{\noalign{\vskip-\bigskipamount}\egroup\egroup$$\endinsert}

%---------------------------------------------------------------

\table 1. Properties of Local Group dSph Galaxies

@l @c @c @c @c @c @c \\
\tworules
&\c{Name} & \c{$D$} & \c{$R_{GC}$} & \c{$M_V$} & \c{$R_c$} & \c{$\Sigma_{0,V}$}
  & \c{$I_0$} \\
\onerule
& NGC~205 & 690 & 8 & $-16.3$ & 170 & 19.9 & 1.2 \\
\onerule
\space\space
\annot $D$ = heliocentric distance. \\

\bye


modify register order

Hi @atalyaalon ,
Why was it needed?

@ziv17
Apparently the import order changes the order of the widgets in our API and hence the order of their appearance in the UI.
I preferred having all_locations_widgets first, and no_location_widgets last.

@atalyaalon
We can have specific order. What is the priority of this?

@ziv17 not a priority for now. We'll keep current order with the small modification I made in this pr


Edited accomplishments (qbronze).

debug

👷 Deploy Preview for yunrui-zhang processing.

Name
Link

🔨 Latest commit
24b8201f7fadecde3cbc2e7ec73d7c7de395f492

🔍 Latest deploy log
https://app.netlify.com/sites/yunrui-zhang/deploys/650aec8221ea250008875c90


Allow multiple slack notifiers.

This pull request is for issue https://github.com/linkedin/Burrow/issues/167.

Overall this looks fine, however I would like to see this separated out to 2 PRs - one for the SSL change for the Kafka client and one for the slack notifier change. It's a small thing, but it's good hygiene.
The notifier changes look solid. The only question is whether or not we should remove the Interval configs. I know that they're unused at the moment, but it looks like they may be used in #179 to fix the problems there with not sending notifications until all groups are in a bad state. This would apply to both email and slack notifiers.


How to use React lifecycle methods like componentDidMount in boilerplate v4?

It's not an issue, just wanted to upgrade my code base and was curious how you guys expect to handle lifecycle workflow which I am using right now

Using React Hooks.


Determine doc impact of P0899R1

Determine doc impact of P0899R1
Occasionally, a paper increases restrictions on users (either at compile-time or run-time) without requiring implementations to diagnose improper usage.
This has no implementation impact, but may have doc impact.
Determine the doc impact of this paper.

moved to quest


Add option to put custom image (one .jpg file) as background

Suppose I have take the photo from the very high floor. Next I correct perspective distortion in GIMP. Now I want to place that image at background and start drawing above it.

Alert! Due to lack of funds, MapKnitter.org will go offline on August 31, 2022.


same user is able logged in

I  have installed rdp wrapper, and I have changed come setting in group policy and some here and there (I can't remember). Now for eg. user 1  is logged in the main pc, it can also be logged in via rdp to another. How to stop that?

https://admx.help/?Category=Windows_11_2022&Policy=Microsoft.Policies.TerminalServer::TS_SINGLE_SESSION
Check "Single session per user" in RDPConf.


Task 'installDebug' not found in root project ' '.

Description
Hi, I am new to react/react-native and I have a problem that I've been trying to fix for a week. I've created a react native app with the react-native-cli with the cmd: react-native init myApp. After my app gets created automatically. I run this command: react-native run-android and I get this error:

so then to try and fix that I go into the android directory and use the cmd: gradlew :app:installDebug and it builds successfully:

then I go back into my project directory and run-android again. I expected that this app would run on my android virtual device but I get the same error:

So at this point I know there is something seriously wrong so I go back into the android directory and type in this cmd: gradlew build and this fails at the bundleReleaseJsAndAssets:

I don't know if this is the problem but something is not working correctly. Like I said I've been trying to fix this for a week and looked at several forums to fix this. I found a issue that has the same build errors as me except this was 2 years ago and he is building the assembleRelease for android with a different version of react: #4124 .
Reproduction Steps and Sample Code
If you can get my React-Native app running on your Windows or even your mac let me know what you did. Here is the link to my frustrating app:  https://github.com/CoLagon/React-Native-myApp
Additional Information

React Native version: 0.42.3
Platform: Android
Development Operating System: Windows 10
Dev tools: [Android SDK 23.0.1 - 23.0.3]

What's version of gradle?
EX:
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip'
And what's version of build tool grade?
EX:
classpath 'com.android.tools.build:gradle:2.2.3'

@thiensubs My classpath is: classpath 'com.android.tools.build:gradle:2.2.3'

@thiensubs and yes my distributionUrl is: distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip

Hey @CoLagon,
I cloned your project locally, ran npm install,  and then react-native run-android. I got an error, but not the same one as you. It just said that it couldn't install the app on the device. Then I ran  ./gradlew installDebug from the android directory and got a permission denied error.
After I did chmod +x gradlew, I navigated back to the root directory. I ran react-native run-android and it worked. This was on Mac. I'll run your app on my other machine, that has Windows 7, later today.
I hope this helps!
Did you try running ./gradlew tasks?

Hey @Air-Miha ,
Thanks for checking out my problem. So I ran cmd gradlew inside the android directory and got this:

so it seems that gradlew tasks builds successfully. Is that weird that gradlew tasks builds successfully but gradlew build doesn't?

@CoLagon,
I reinstalled everything Android related on my machine with Windows 7. I followed the official instructions. I was able to run your application on my device. Actually, the installation eventually failed because of insufficient storage, but in your case this would be a good problem to have :).
Notice that your root project is named '' in the error message. When I clone it, whatever error message I get, it says root project "myApp". I think your problem is related to your local environment and one of the issues mentioned in this thread:
http://stackoverflow.com/questions/25172006/android-studio-build-fails-with-task-not-found-in-root-project-myproject
Could you try reinstalling everything and going through the official Getting Started documentation? Make sure you don't skip any steps. It will give you a clean start and there's a good chance everything will work.

@Air-Miha
the new android sdk update doesn't have a GUI. I downloaded a workaround to getting the GUI back. Did you have a GUI to work off of? or were you doing everything sdk and avd related in a the cmd prompt? I'll delete everything android related I reinstall everything again.

@Air-Miha
I Removed everything that was Android related on my Device and reinstalled everything. It still says the same error: I don't know what I'm doing wrong. I have my environment variables set correctly. I have an avd running on my computer. I followed the React documentation and still not luck. It makes no sense that it runs correctly on your computer but on my computer it can't run. I'm so bummed out.

@Air-Miha
HEYYYYYYYYYYYYY!!!!!!!! I FIXXED IT!!!!!!!!!!! OMG. I'm so happy. Thank you so much you inspired me to think and fix the problem.  so when you said that it might be my environment, I scratched my head was thinking about my environment variables and things I did to my computer. So about a month ago I went into my registry editor (regedit) and made a new string value in HKEY_CURRENT_USER\Software\Microsoft\Command Processor called Autorun so when I open up my command prompt my cmd path would be set to my hard drive (C:). So I removed that and it work! That what was wrong with my computer that entire time. so I guess I learned today to never mess with the regedit. I seriously didn't think that was the problem but it was thank god I removed that.

@Air-Miha
I can't thank you enough!

@colelogan thank you a lot. work it.
i remove autorun from registry and work!


Width prop not pulling from spacing scale

Describe the bug
Today I noticed that when doing something like:
<Box width={3}/>
I would expect the 3 here to pull the 3rd value from our spacing scale. Instead, the generated CSS is width: 3px
To Reproduce
Steps to reproduce the behavior:

https://primer.style/components/Box
Edit the width in one of the examples to be width={3}
See that it makes the width only 3 pixels instead of the expected 16px

Expected behavior
Width system prop should pull from spacing scale in the theme
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Looks like this is not a bug. The width prop references sizes theme field: https://styled-system.com/table#layout


Hack to fix bridge devices

Instead of receiving the bridge device from the global configuration, try to autodetect the device each time
This will use the first Ethernet device in /sys/class/net (alphabetically)

I don't think this is the best fix, but it should work on most modern Linux systems. If there are more than one Ethernet devices, then it may or may not do the right thing.
For #102

Closing this due to staleness. Feel free to reopen or open a new PR if there's still a relevant change to be made. Thanks!


perf: calculate capacity of generated Wasm module code

100_000 iterations of test_render_js_wasm_module
Before: 400.4625ms
After: 239.3486ms

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.81%. Comparing base (0c7f83e) to head (6d0dfc8).
Report is 189 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   81.43%   81.81%   +0.37%
==========================================
  Files          97       98       +1
  Lines       23877    25800    +1923
==========================================
+ Hits        19445    21108    +1663
- Misses       4432     4692     +260

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix idgen+auditable

Call markAudited prior to setting the auto-generated id so the audit infrastructure will correctly detect the entity as new on initial save.

/check-enforcer override


Wpf: set textcolor to red doesn't work! Not Refresh the sheet

In Wpf:
sheet.SetRangeStyles("B2:B2", new WorksheetRangeStyle()
{
  Flag = PlainStyleFlag.TextColor,
  TextColor = Color.Red,
});

dosen't work.Not Refresh the sheet.
(If I save the sheet, and then, Load the sheet rfg file, the Color is red!)
But, In Winform:It works well.
A bug?

Fixed, please check from the latest source code.

It works well now! Thanks you so much... ...


Update spaces-github-actions.md

Separate FULL_SPACE_NAME into HF_USERNAME and SPACE_NAME, as suggested in #566 by @julien-c

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


fix mypy compile shape file not found

fix compile.sh
mypy: can't read file 'tinygrad/shape/__init__.py': No such file or directory  error
it was moved to shapetracker.py in https://github.com/geohot/tinygrad/commit/01f39b19dcde3a0ebb701ee405e746146fef90e6

fixed here https://github.com/geohot/tinygrad/commit/5e1380df6ab62e1544b8f17fc26d07c4a62e850f


Simple variant generation mechanism

UVLS should be a starting point to learn basic principles of feature modeling and software product lines. A very simple mechanism to showcase how to derive a variant from a configuration would be helpful. In particular, I think having a powerful composer for actual programming languages would already be too complex for the use case.
Some simple format/language that can easily be extended with presence conditions and could be used to showcase variant generation could be great.
Some suggestions:

Markdown
Latex (may require some restrictions)
A visualization format such as GraphViz

Please explain further what you mean here.
Should we add a mechanism that generates a concrete example (in one of the languages) or should there be an example how feature models might be useful?
Implementing a (fairly simple) preprocessor should be possible but otherwise would not be powerful enough to be useful in real projects.

The idea would be a very simple preprocessor for a single language. For instance, we could use it to generate several variants of a markdown file. UVLS should then identify the preprocessor statements and generate a concrete markdown file given a configuration by removing the preprocessor statements and the parts belonging to deselected features.


gitlab: add gitlabfs

Closing, see https://github.com/iterative/mlem/pull/446#issuecomment-1398315471.


branch-2.1 Add a debug variable of constant fold (#35584)

pick https://github.com/apache/doris/pull/35584

run buildall


Allow us to use {{version}} in the custom join message.

My server currently has these welcome message:
motd:
  enabled: true
  message: |-
    §f[§aEssence§f] §7Hey, thank you for joining!
      §7We're using Essense 1.3.1.
      §7Use §c/help essence §7to see what's available.

I'd like to replace 1.3.1 with {{version}}, or something of that matter, so each time I make an update I do not have to open the configuration file to make that change.

@byteveil Just wanted to give you a heads up that in 1.4.0, the {{version}} tag is being removed and replaced with {{essence-version}} - more info: https://wiki.lewmc.net/index.php/Essence_MOTD#Tags

Tagging 8f72920


gem command just freezing

Trying to understand the problem and can't figure out how resolve this issue
gem --version - just freezing
Here what I have
$ which gem
/home/vladimir/.rbenv/shims/gem
$ rbenv which gem
/home/vladimir/.rbenv/versions/jruby-<IP_ADDRESS>/bin/gem
this happen when I set  export RUBYGEMS_GEMDEPS="-" in my .bashrc
I make a call from project directory ~/code/proj1 and it has Gemfile Gemfile.lock
and previous directory also has different Gemfile and Gemfile.lock
Not sure I have a correct configuration but why gem command is affected that is the question

What is RUBYGEMS_GEMDEPS supposed to do normally?

@mislav As far as I know this force rubygems to travel up and find other Gemfiles
Here is some explanation https://github.com/rubygems/rubygems/blob/c18805ca48f533fbde40025df41a8f817cd6ff48/lib/rubygems.rb#L1021
In fact I just experimenting and trying to setup guard on the top level for several project - with no luck

This sounds like maybe JRuby and RubyGems version that ships with it might not be compatible with your Gemfile. Have you tried bundle exec ruby -e0 to see if that works? Instead of RUBYGEMS_GEMDEPS, you could be using bundle exec instead.

@pironim Do you still have a problem which you believe rbenv is responsible for?

@mislav No. I remove RUBYGEMS_GEMDEPS and Gemfile from projects directory - and problem disappear.

Thanks for the update. Yes, it definitely seems that JRuby has a problem with RUBYGEMS_GEMDEPS. Not an issue with rbenv, it seems.


copyDirectory not working in event hook

Laravel Mix Version: #.#.# (npm list --depth=0)
Node Version (node -v): v7.7.3
NPM Version (npm -v): 4.1.2
OS: MacOS Sierra 10.12.4

Description:
When trying to copy a directory using mix.copyDirectory within an event hook it just does nothing. While doing that same function outside of the event hook would work. It just be to early.
Steps To Reproduce:
Try a mix.copyDirectory inside an event hook; mix.then(() =>) for example
Code snippet
mix.then(() => {
    console.log('Finished, doing postprocessing..');

    mix.copyDirectory('fonts/', 'public/fonts').then(() => {
        del('fonts');
    });
});

Does other methods like scripts() or styles() works in the then() callback ?
You can always use native node-js methods OR a package like ncp to perform such file operations.

Thanks ankurk91 for the response. Other mix functions don't seem to work either. I could use other libraries and it would do the job. But that is not the solution I'd prefer.

mix.then(() => {
    console.log('Finished, doing postprocessing..');

    mix.copyDirectory('fonts/', 'public/fonts').then(() => {
        del('fonts');
    });
});

This isn't how Mix works, so you can'd do that.


Queue the calls to GodotLib.key when Android virtual done is pressed

Currently, when the Android virtual keyboard done (or enter) key is pressed, the action is not queued for sending back to Godot. Not only does this run the risk of hanging the thread, but it also results in enter events being sent to Godot before all the other key events have been processed.
This PR properly queues the done events the same way all the other events are queued. This ensures:

They run on the correct thread
Godot events are processed in the correct order.

Closes #50125. Specifically, it fixes the issue of the entire word not been retyped before the text_entered signal is sent. It does not fix the issue of the entire word being retyped, because this is an Android issue, not a Godot issue.

Thanks!


fix: Use exact label match for PAC state check

Fixes
https://issues.redhat.com/browse/RHTAPBUGS-771

Description
Use exact label match for checking PAC state, since labels are immediately updated on PAC request and the done check is not relevant anymore.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
(No UI updates)

How to test or reproduce?

Create component with custom pipeline
Switch to default pipeline
Check component kebab menu, it should show "start new build" option

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/retest


Goto Definition in modes not work

in Futures:
Goto Definition — For all symbol references like variables, parameters, functions, modes, accumulators etc.
Ехаmple:
<xsl:apply-templates select="node" mode="mode1"/>

<xsl:template match="node" mode="mode1">
<xsl:value-of select="name"/>
</xsl:template>

Goto on mode1 in  <xsl:apply-templates select="node" mode="mode1"/> does not go to <xsl:template match="node" mode="mode1">
But it works for variables
Video
https://user-images.githubusercontent.com/16345533/189931333-aa1f8459-ebe8-43e4-9585-ee12d9ff034b.mov

Thanks for reporting this bug. In XSLT, modes are defined quite differently than other symbols, this possibly accounts for the problem.
With other symbols there can be only one definition, with XSLT I suppose we can say that there's a mode definition on each xsl:template instruction where a mode name is specified. The xsl:mode instruction should also be considered a 'definition' if it has a name attribute.
The xsl:apply-templates instruction with a named mode  can therefore be considered a symbol reference.

The Rename Symbol feature is related to this. There's a bug when renaming a mode - the mode name change is repeated at the cursor position

Summary of fixes
Goto Definition - for modes

'Goto Definition' does not quite fit with XSLT modes (as there is no single definition), but this is implemented as follows:

if on xsl:mode instruction - do nothing as this can be considered the definition
if on xsl:template instruction:

go to xsl:mode instruction if it exists, or:
go to topmost xsl:apply-templates instruction with same mode in same module

if on xsl:apply-templates instruction:

go to xsl:mode instruction if it exists, or:
go to topmost xsl:template instruction with same mode in same module

Goto References - for modes

Did not work reliably as:

It required 'Goto Defintion' functionality that did not work properly
It did not account for multiple modes in a single mode attribute of an xsl:template instruction

Rename Symbols - for modes

Did not work reliably as It uses 'Goto References' functionality that did not work properly


etcdctl cannot add key with "in order" feature

Hello,
The etcdctl always create key using -XPUT http verb. So it's not possible to use it with what is known as "in order" feature (cf. https://github.com/coreos/etcd/blob/master/Documentation/api.md#atomically-creating-in-order-keys)
It should be great if this feature will be available throught high level etcdctl and not only with curl.
JM.

etcdctl does not provide all features in the client or matches all API items provided by etcd. If you are interested in this feature and you have time, then send a pull request. Thanks!

Sorry but I don't know programing in Go and I have no time for learning
this language.
Thank's for your answer anyway.
2016-02-24 20:18 GMT+01:00 Xiang Li<EMAIL_ADDRESS>
etcdctl does not provide all features in the client or matches all API
items provided by etcd. If you are interested in this feature and you have
time, then send a pull request. Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/etcd/issues/4588#issuecomment-188413792.

This should be easy to do, etcd.KeysAPI has CreateInOrder method, the only thing left is to add a new command implementation.


No google analytics for workspace pages

It seems that we do not have google analytics code embedded on the workspace pages, hence, page views are not recorded for any of the pages in the user workspace.
-Maulik

the file content of tracking.jsp is need for this. There are a few lines of javascript in the file.

I think the same goes for app service pages. They are not recorded as of now either.

Harry fixed this with his GA additions a few weeks ago


Jenkins self-update

Hi @geerlingguy 🙂,
I'm wondering if it's possible to add something like jenkins_disable_restart.
I want to update Jenkins by using ansible and a Jenkinsfile. Therefore, I need to make a safeRestart call to the CLI instead of a "hard" reset during the run of the pipeline.
I'm willing to try to implement this, but I wanted to make sure it had a chance of being merged.

#391 closed my issue.
❤ Thanks @geerlingguy  for merging my pull request.


Freezed When Fast Scroll With Many Photos

My album has many photos. When I show those in QBImagePicker and I scroll fast, the application is freezed. CPU usage is over 180% and 40 threads are running. Many threads are in PLJPEGPreheatItem context.

Main thread is blocked in PHCachingImageManager.startCachingImagesForAssets:targetSize:contentMode:options which is called from QBAssetsViewController.updateCachedAssets.

I met the same problem, how to solve the problem，Give up updateCachedAssets？

I solved this issue ad hoc.
I call "stopCachingImagesForAssets" and "startCachingImagesForAssets" with BlockingQueue on worker thread.
This is very very dirty, so I gave up to send pull request my solution. But this ad hoc solution may be helpful.
https://github.com/yonezawaizumi/ImageResizer


Broken links in documentation

I found a section in documentation which seems to be broken.

https://dvc.org/doc/dvc-philosophy/.

should be changed to https://dvc.org/doc/understanding-dvc/

@shcheklein I think it only came as suggestions when searched. So only the API needed an update. Hence closing this :)


add daemonset resource requests to Helm chart

What would you like to be added:
Add daemonset resource requests to the Helm values, as an alternative to the patch approach currently recommended in the docs.
Why is this needed:
With the default daemonset memory limits, it OOM-loops on larger clusters, and having to do a kubectl patch -- especially since the daemonset is not created by the Helm chart itself -- is awkward when deploying with something like Argo.
User story covered

@gsstuart thank you for the request. Do you consider to contribute the change by yourself?

Hi @saschagrunert!  Sure thing... I'm currently implementing the change in an internal fork, and would be happy to contribute back once it's looking good.


BUG Gale-Shapley

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #1097

Codecov Report

Merging #1110 (626fd0a) into master (da08758) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
- Coverage   86.86%   86.71%   -0.15%
==========================================
  Files         170      159      -11
  Lines        9324     9019     -305
==========================================
- Hits         8099     7821     -278
+ Misses       1225     1198      -27

Impacted Files
Coverage Δ

etna/transforms/feature_selection/gale_shapley.py
100.00% <100.00%> (ø)

etna/settings.py
73.13% <0.00%> (-0.75%)
:arrow_down:

...ntal/classification/feature_extraction/__init__.py

...xperimental/change_points/regularization_search.py

etna/experimental/classification/utils.py

etna/experimental/classification/predictability.py

etna/experimental/classification/base.py

...ental/classification/feature_extraction/tsfresh.py

etna/experimental/change_points/__init__.py

etna/experimental/classification/classification.py

... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


smoke: use latest nydus release

In case the latest nydus release breaks off the smoke test.
Signed-off-by: Yan Song<EMAIL_ADDRESS>

Codecov Report

Merging #105 (3e674d1) into main (ea5fd58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   28.77%   28.77%
=======================================
  Files          17       17
  Lines        1536     1536
=======================================
  Hits          442      442
  Misses       1030     1030
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5fd58...3e674d1. Read the comment docs.


Image scaling not accurate for android , but works for ios

Hi
The image scaling was not same for android and ios.It scaled differently for android cropping some part of the image on the screen.
But it fits the image in ios.

I'm suspecting this is an error with the way you have configured the slider. You could do full-screen background images by writing your own renderItem-method as such:

const slides = [
  {
    key: 'a',
    image: require('./assets/1.jpg'),
  },
  {
    key: 'b',
    image: require('./assets/2.jpg'),
  },
  {
    key: 'somethun1',
    image: require('./assets/3.jpg'),
  }
];

export default class App extends React.Component {
  _renderItem = props => (
    <Image style={{ flex: 1, width: null, height: null, resizeMode: 'cover'}} source={props.image} />
  );
  render() {
    return (
      <AppIntroSlider
        slides={slides}
        renderItem={this._renderItem}
      />
    );
  }
}

You can see for yourself by running the example and replacing the code with that.

I was facing a similar issue and I thought that maybe exposing the Image resizeMode prop as a configuration option would be useful.
@Jacse what do you think?

I have the same problem too. For now I directly change the resizeMode prop type from default slide to contain

any tips for having full screen image per slide?


Support CSSParser option rule_set_exceptions

Allow passing the option rule_set_exception to CSSParser per https://github.com/premailer/css_parser/issues/125.

If https://github.com/premailer/premailer/pull/419 gets merged then it'll be automatically supported through https://github.com/fphilipe/premailer-rails/blob/main/lib/premailer/rails/customized_premailer.rb#L11 using Premailer::Rails.config.merge!(rule_set_exceptions: false)

Closing as this is possible as @markedmondson explained.


Chrome+Linux out of memory crash

ParaView Glance on Chrome (Version 65.0.3325.181) + Linux (Ubuntu 16.04, 64 bit) crashes with a OOM heap error. Firefox on the same platform does not exhibit this issue, nor does Chrome on macOS/Windows.
There are multiple ways I have found to reproduce this bug:

Open a dataset, then quickly switch between quad and split layouts
Open multiple datasets, then quickly delete them
Open two NRRD files of at least 2MB
Likely more...

Tracking the virtual memory usage reveals that the Chrome tab process reaches 16GB, which according to this comment is the RLIMIT_AS of chrome processes in Linux.
Running Chrome without the 16GB address space limit (disabled sandbox) and observing memory allocations, the largest spike is a roughly 2MB allocation (for a 2MB NRRD), with a total memory allocation of 41MB.
My first guess is Chrome's GC is too slow to clean up, but I don't know enough about Chrome's GC to comment further.
This issue is to track my findings and to see if anyone else runs into similar issues.

This is no longer an issue with Glance v2. Closing until the issue re-appears.


Ifcfg constructor fails when interface has empty angular brackers.

I have the following interface in my ifconfig:
enc0: flags=0<> metric 0 mtu 1536
The constructor call fails:
ifdata = Ifcfg(commands.getoutput('ifconfig -a'))
as:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "build/bdist.freebsd-8.4-RELEASE-amd64/egg/ifparser/ifconfig.py", line 106, in __init__
  File "build/bdist.freebsd-8.4-RELEASE-amd64/egg/ifparser/ifconfig.py", line 116, in _process
ifparser.ifconfig.ParseError: 'enc0: flags=0<> metric 0 mtu 1536'

@Rahul-RB  Would be possible for you to capture ifconfig output in txt file attach here with gist or pastebin ?

Sure.
Here's a gist. Also attached is a text file having the same output.
op.txt


chore(compress): log with trace level instead of debug.

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
fix https://github.com/datafuselabs/opendal/issues/742

Thanks a lot!


Add linting.

It'd help keep things consistent.  As is, it's a little unruly.

Great, PR for linting are welcome :)

PR #19.


Create a FAQ page

Description
Create a FAQ page where we can answer the most commonly asked questions on Discord, Twitter or GitHub.
Problem Statement/Justification
There are new developers getting started with Chakra UI every day. Most of them ask the same questions on Discord/Twitter/GitHub, and wait for someone to answer them. Having a FAQ page will help the newcomers progress easier and faster.
Proposed Solution or API
Similarly to how the Resources page works, we can create pages/faq.tsx which will read the Q&As from configs/faq.json.
See pages/resources.tsx to see how it's implemented.

I'd like to work on this. (Just as note until i can assign the issue to myself)

@lazarnikolov94 Is there a specific way on how to generate the search-meta content for new entries for omnisearch?


Temporary Keys

It's confusing what separates a temporary key from a not-temporary key. This documentation says "the names of temporary keys should begin with one number (#) sign", but the number sign isn't what makes it a temporary key. The example "Creating a temporary symmetric key" doesn't include any syntax that makes it clear that a temporary key is being created. Because of this, I'm unable to tell what actually makes a key temporary.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e9162b3-83a4-f209-7046-c465a37c3ed8
Version Independent ID: a168dd02-14ba-f666-3aae-028ef7aedd8c
Content: CREATE SYMMETRIC KEY (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/create-symmetric-key-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @VanMSFT
Microsoft Alias: vanto

@VanMSFT Hi Van, this Issue 2218 now assigned to you.  Thanks.

Hey @samrueby - The # sign designates the key as a temporary key, and then is stored in the tempdb. Please let me know if that makes it clear. I will edit the doc to clarify the key_name. Thanks!

Doc changes are taking place. Should be live shortly.
https://github.com/MicrosoftDocs/sql-docs-pr/pull/10611
@samrueby - Sam, if you have any concerns, please let us know. Thanks for your feedback. We appreciate you helping us improve our documentation! I'll go ahead and close this request for now.

The change looks good. Thank you.


ENH: Add a CMake minimum required version.

Add a CMake minimum required version: match the version with the version
currently required by ITK master.

Will help solving some of the issues in #15.


fix! Revert "fix(comid): bring ValueTriple into alignment with rev05"

This reverts commit b015c203eea7f5ca4a6aeee0d8fa9d4802ddd3fe.

@yogeshbdeshpande, Is there any reason you added a separate commit? It looks like the changes I proposed were the same as yours.

@yogeshbdeshpande, Is there any reason you added a separate commit? It looks like the changes I proposed were the same as yours.

No i just ran go mod tidy to confirm that all unwanted stuff is removed or not ? That all..


Change the minimum chain schema length

This PR causes the honest chain schema to have more than k blocks after intersections, and alternative chain schemes to have as many blocks as possible without winning races.
This guarantees come from the generation algorithm, which ensures that every s window has exactly k blocks in the honest chain.

At the moment, the rollback tests are failing because they want to do rollbacks from the tip of the honest chain, which has more than k blocks after intersections.

my understanding is that this ensures that chains are at least two genesis windows long and that all forks happen before the k+1st newest block – how does it cause alternative chains to have maximum active slots?

how does it cause alternative chains to have maximum active slots?

This is done already by the implementation by removing active slots from the alternative chain in the race windows. The description of the PR is probably not the most accurate.

ah, that's much clearer. so it's unlikely we'll manage to get minimum length for fork fragments?

so it's unlikely we'll manage to get minimum length for fork fragments?

The number of active slots on the alternative chain schemas depend on Delta and when they fork from the honest schema. We could ensure that they have k+1 active slots if we do more computation, but maybe the complexity isn't worth the trouble. We can see how much we discard with these changes and reconsider.

C.SomeWindow Proxy winA <- pure $ C.withSuffixWindow (C.windowSize winH) (C.Lbl @AdvLbl) firstAdvSlot

do I understand correctly that this guarantees that the slot count in the fork fragment matches the honest chain?
And if we have the maximum number of active slots in that fragment, does it mean that we have at least k, since the honest chain now has at least k+1?

do I understand correctly that this guarantees that the slot count in the fork fragment matches the honest chain?

The alternative schema starts at firstAdvSlot and ends in the same slot as the honest chain schema.

And if we have the maximum number of active slots in that fragment, does it mean that we have at least k, since the honest chain now has at least k+1?

It depends on the value of Delta. If Delta is large, it may be the case that the generation algorithm assumes the adversary can fill every slot after the stability widow, and therefore, less than k slots might be active in the alternative chain.

With the latest changes, I think it is guaranteed that there are k+1 blocks in both the honest and the alternative schemas after the intersection. Thanks @amesgen for the final insight.
This PR needs a PBT to check that the generated chains do actually have k+1 blocks.

looks reasonable!

At the moment prop_adversarialChain fails with the following output
...
testRecipeH = HonestRecipe (Kcp 2) (Scg 4) (Delta 0) (Len 9)
---
            [  )rHon
      011001110
      [        )H
      [        )A
      000000111
             [ )rAdv'
      [        )stabWin'
...
Use --quickcheck-replay=732461 to reproduce.

The problem is that the first active slot of the alternative schema is too close to the end of time. The verification of the alternative schema expects the acceleration of the leader schedule to happen only after s slots after this first active slot, and it complains when finding the acceleration earlier.
There are two solutions I can think of to still guarantee k+1 slots in every alternative schema:

Require the first slot of the alternative schema to be active. Thus there are sufficient slots where acceleration of the leader schedule is allowed.
Have the verification of the alternative branch ignore the last k+1 slots of the alternative branch (they are always more than sgen+delta slots after the intersection).

Let me know if you have other suggestions.
@nfrisby, you might have opinions on how to resolve this.

sounds good!

Alright, I think this one is good to merge.

From the properties I've seen so far, my instinct is that there's a more straight-forward way to ensure them... eg a call to fillInWindow rather than choosing higher values of asc. But maybe that's insufficient (eg if the honest schema is minimally dense then the only way to also have k+1 blocks after the intersection on the alternative schema is to extend the end of time 🤔 ).

FTR: @facundominguez first tried some things by patching up the output of the schema generator, but it was surprisingly subtle, see https://github.com/input-output-hk/ouroboros-consensus/pull/477#issuecomment-1788263214.

I think @amesgen answers well.
About parametrization of the generators, I think it is still not totally justified for two factors.

If we want to test alternative chains with less than k+1 blocks, we can generate point schedules (or block trees) that ignore the suffixes.
If we want to test sparser alternative chains, we can improve by increasing the probability of having k+1 blocks in the whole chain (even if it is long), instead of doing what we currently do: make density k/s probable over the whole alternative chain.
I think trying to use fillInWindow can be done easily enough if we generate longer alternative chains (sometimes 3*s long). I was reluctant to enlarge our chains, but perhaps it is still to be preferred by simplicity.

I brought fillInWindow back to activate the last k slots of alternative chain schemas. The chains are guaranteed to be long enough that the last k slots are after the acceleration bound.
The first active slot of an alternative chain schema is guaranteed to be before $s+k+d+1$ from the end, which allows ensuring the acceleration bound is always before the end.
Race windows do not push the acceleration bound to the last $k$ blocks because the intersections with the honest chain are always behind the last block preceding the last $s+k+d+1$ slots.
If this looks good to you I'll squash and merge in genesis/milestone6.

Looks like this PR was closed accidentally by deleting the genesis/point-scheduler branch.


Add cpu target percentile parameter to VPA options in Shoot spec

How to categorize this PR?

/area auto-scaling
/kind enhancement
What this PR does / why we need it:
This PR exposes the targetCPUPercentile parameter of the VPA recommender in the Shoot spec. With this parameter, Shoot owners or gardener operators can fine-tune the recommender behavior regarding recommendations for CPU.
The default is 0.9, which means the recommender will issue a recommendation that is fulfilling 90% of the observed CPU measurements. As CPU is a compressible resource, Shoot owner may want to set this to a smaller value, depending on the headroom on their nodes and the requirements for their workloads.
Release note:

In order to fine-tune VPA CPU recommendations, the CPU target percentile parameter for `vpa-recommender` can now be configured in the `Shoot` specification via the `.spec.kubernetes.verticalPodAutoscaler.targetCPUPercentile` field.

/cc @vlerenc @andrerun

/hold running some experiments to verify this has the desired effect

/retest
/hold cancel
Tests have been successful: when modifying the parameter, we see that his has a direct impact on the cpu recommendations. Lower values lead to lower recommendations overall.

PR looks good, but adaptation in https://github.com/gardener/gardener/blob/master/docs/usage/shoot_autoscaling.md#vertical-pod-auto-scaling is still missing.

Ah, sorry, thanks for catching that I missed that.
On a related note: I just find myself copy-pasting the same things that I already wrote in the API docs for those properties. Should we maybe just link to the API docs instead of replicating that information here?

Should we maybe just link to the API docs instead of replicating that information here?

We could. OTOH, the API docs typically do not contain too much information. Maybe this works in case of the VPA fields - if so, feel free to just link the generated docs (maybe in a separate PR).
/lgtm
/approve

/retest


⚠ Cioos National CKAN has degraded performance

In d7de109, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 14399 ms

Resolved: Cioos National CKAN performance has improved in 07f4366 after 23 minutes.


[oap-spark] RDD cache show low performance comparing with vanilla spark.

We use RDD cache to run Kmeans workload and get lower performance comparing with vanilla spark. We use 1+3 clusters and per node contains 384GB DRAM and 1TB PMEM. The data scale is 600GB. baseline use MERMORY_AND_DISK_SER storage level. The result shows that RDD cache has 27% lower comparing with vanilla spark.
Type                        Date            Time        Input_data_size      Duration(s)          Throughput(bytes/s)  Throughput/node
ScalaSparkKmeans 2020-12-07 11:57:11<PHONE_NUMBER>21         1630.870             369406891               123135630
ScalaSparkKmeans 2020-12-07  05:30:55<PHONE_NUMBER>21         1286.897             468145172                156048390

CC @zhixingheyi-tian @yeyuqiang

Hi, haojinIntel:
The following 4 points need attention：

600GB of data scale  is about 360GB of data will be cached (SVM workload has been verified, Kmeas workload needs to be verified).
you are using 1+3 Clusters and per node contains 384GB DRAM and 1TB PMEM, therefore, under the MERMORY_AND_DISK_SER storage level, 384x3=1152GB of DRAM can be used, and 1152GB is greater than 360GB, so this 360GB data can be completely cached to DRAM.
Spark uses UnifiedMemoryManager to manage memory by default, and storage memory and execution memory can be dynamically occupied, When Spark total-executor-memory is much larger than 360GB when running kmeans, storage memory may more than 360GB.
The IOPS and latency of DRAM are higher than PMEM
In view of the above 4 points, you may got the RDD cache has 27% lower comparing with vanilla spark  conclusion.
I have some suggestions:
Under the extremely large data scale , the performance of PMEM_AND_DISK Storage level can exceed the MERMORY_AND_DISK_SER Storage level.
you can increase the data scale make DRAM cannot completely cache data, while PMEM can completely cache, the advantages of PMEM_AND_DISK can be reflected.
If you do not want to change the data scale, you can reduce the cluster DRAM capacity.

Hi, haojinIntel:
The following 4 points need attention：

600GB of data scale  is about 360GB of data will be cached (SVM workload has been verified, Kmeas workload needs to be verified).
you are using 1+3 Clusters and per node contains 384GB DRAM and 1TB PMEM, therefore, under the MERMORY_AND_DISK_SER storage level, 384x3=1152GB of DRAM can be used, and 1152GB is greater than 360GB, so this 360GB data can be completely cached to DRAM.
Spark uses UnifiedMemoryManager to manage memory by default, and storage memory and execution memory can be dynamically occupied, When Spark total-executor-memory is much larger than 360GB when running kmeans, storage memory may more than 360GB.
The IOPS and latency of DRAM are higher than PMEM
In view of the above 4 points, you may got the RDD cache has 27% lower comparing with vanilla spark  conclusion.
I have some suggestions:
Under the extremely large data scale , the performance of PMEM_AND_DISK Storage level can exceed the MERMORY_AND_DISK_SER Storage level.
you can increase the data scale make DRAM cannot completely cache data, while PMEM can completely cache, the advantages of PMEM_AND_DISK can be reflected.
If you do not want to change the data scale, you can reduce the cluster DRAM capacity.

Hi, haojinIntel:
###The following 4 points need attention：###

600GB of data scale is about 360GB of data will be cached (SVM workload has been verified, Kmeas workload needs to be verified).

you are using 1+3 Clusters and per node contains 384GB DRAM and 1TB PMEM, therefore, under the MERMORY_AND_DISK_SER storage level, 384x3=1152GB of DRAM can be used, and 1152GB is greater than 360GB, so this 360GB data can be completely cached to DRAM.

Spark uses UnifiedMemoryManager to manage memory by default, and storage memory and execution memory can be dynamically occupied, When Spark total-executor-memory is much larger than 360GB when running kmeans, storage memory may more than 360GB.

The IOPS and latency of DRAM are higher than PMEM

In view of the above 4 points, you may got the RDD cache has 27% lower comparing with vanilla spark conclusion.
I have some suggestions:###

Under the extremely large data scale , the performance of PMEM_AND_DISK Storage level can exceed the MERMORY_AND_DISK_SER Storage level.

You can increase the data scale make DRAM cannot completely cache data, while PMEM can completely cache, the advantages of PMEM_AND_DISK can be reflected.

If you do not want to change the data scale, you can reduce the cluster DRAM capacity.

@haojinIntel
It is clear that DRAM performs better than PMEM when the data is all cacheable.
We even measured 68% performance degradation using SVM tests in 100GB dataset.

As @JustDoCoder said, the most effective measure is that:
Increase the Data Scale make DRAM cannot completely cache data, while PMEM can completely cache data,——Only in this case can it show pmem's advantage.


Fix Device Simulation setup script

Description and Motivation

fix scripts to work with other shells other than Bash
improve some common errors detection
sync scripts in the 2 solutions, with and without hub

Change type

[x] Bug fix
[ ] New feature
[x] Enhancement
[ ] Breaking change (breaks backward compatibility)

Checklist:

[ ] All tests passed
[ ] The code follows the code style and conventions of this project
[ ] The change requires a change to the documentation
[ ] I have updated the documentation accordingly

This change is

Scripts tested and working fine. The only issue I noticed is a missing "testing" tag in the docker-compose, which is a separate issue.

@ppathan yes, these 2 PRs contain improvements/fixes that we should apply to other solutions:

https://github.com/Azure/pcs-cli/pull/424
https://github.com/Azure/pcs-cli/pull/425

Copy the new setup-wrapper.sh and change it to point to the relevant GitHub URL, note how it doesn't use set -ex to avoid leaking secrets
In the ARM template invoke setup-wrapper.sh (instead of setup.sh) and use bash instead of sh
From setup.sh take the retry logic used to install Docker and other minor improvements about error detection

Note that the setup now creates a log file under /app


Provide config option for new line interpretation

Spawned from this comment.
Instead of interpreting the host OS environment and using that for determining how to parse newlines, let the user decide because TL;DR: the choice of gpg binaries used by WSL users is indeterminate and independent of host OS reported by Node.
As an additional @todo to this item I'm doing the initial config sans translation, but translation support will need to be added via the existing facilities - probably a separate ticket for that.

Woot, new toy!

Progress...
Finally got the coveted lockdown key displayed in the extension.
Except it's permanently locked because of log message posted below and that's another gremlin I will chase down.

Related log error when the extension tries to unlock the key:
[Assuan] Something wrong in the process: Error: unhandled signing flow
Screenshot:

The pin entry pops up so that's good.
I also re-worked the newline/host environment label and description to more accurately depict that the new setting will be used both for finding the executables and determining the newlines, as opposed to having two different settings.
Windows setting/description:

Linux setting/description:

Since I've decided to use one setting for both line ending and executable cross-platform compatibility, I'm closing #7 as a duplicate, since I have more details logged here.

Merged in PR #10.


1.18 Support & Maven project

— Changed project type to maven
— Added NBTEditor as a maven dependency
— 1.18 Support (updated NBTEditor)
— Better tab completion
— fixed message in config

I don't really like maven, but thanks anyway, I will merge it


Packages Not Found

I tried running the compile for the app and got hit with errors regarding the import referencing which result to github.com/rkbalgi folder. I updated this to match my src folder. However this resulted in many more packages referencing not finding files. I have updated the files and the issues keep on arising as some files are not even in this github repo. Kindly check.
Last error received:
work/src/my_project/isosim/web/http_handlers/save_msg_handler.go:4:2: cannot find package "github.com/rkbalgi/isosim/data" in any of:         /usr/local/go/src/github.com/rkbalgi/isosim/data (from $GOROOT)         /home/munyuamugambi/work/src/github.com/rkbalgi/isosim/data (from $GOPATH) work/src/my_project/isosim/web/http_handlers/isoserv_handlers/active_servers.go:5:2: cannot find package "github.com/rkbalgi/isosim/iso_server" in any of:         /usr/local/go/src/github.com/rkbalgi/isosim/iso_server (from $GOROOT)         /home/munyuamugambi/work/src/github.com/rkbalgi/isosim/iso_server (from $GOPATH) work/src/my_project/isosim/web/http_handlers/all_specs_handler.go:5:2: cannot find package "github.com/rkbalgi/isosim/web/spec" in any of:         /usr/local/go/src/github.com/rkbalgi/isosim/web/spec (from $GOROOT)         /home/munyuamugambi/work/src/github.com/rkbalgi/isosim/web/spec (from $GOPATH) work/src/my_project/isosim/web/http_handlers/parse_trace_handler.go:9:2: cannot find package "github.com/rkbalgi/isosim/web/ui_data" in any of:         /usr/local/go/src/github.com/rkbalgi/isosim/web/ui_data (from $GOROOT)         /home/munyuamugambi/work/src/github.com/rkbalgi/isosim/web/ui_data (from $GOPATH) work/src/my_project/isosim/web/http_handlers/misc_handlers/misc_handler.go:5:2: cannot find package "go/hsm" in any of:         /usr/local/go/src/go/hsm (from $GOROOT)         /home/munyuamugambi/work/src/go/hsm (from $GOPATH) work/src/my_project/isosim/web/http_handlers/send_msg_handler.go:15:2: cannot find package "go/net" in any of:         /usr/local/go/src/go/net (from $GOROOT)         /home/munyuamugambi/work/src/go/net (from $GOPATH) /usr/local/go/src/go/encoding/ascii.go:18:2: cannot find package "golang.org/x/text/encoding" in any of:         /usr/local/go/src/vendor/golang.org/x/text/encoding (vendor tree)         /usr/local/go/src/golang.org/x/text/encoding (from $GOROOT)         /home/munyuamugambi/work/src/golang.org/x/text/encoding (from $GOPATH) /usr/local/go/src/crypto/tls/cipher_suites.go:18:2: cannot find package "golang_org/x/crypto/chacha20poly1305" in any of:         /usr/local/go/src/vendor/golang_org/x/crypto/chacha20poly1305 (vendor tree)         /usr/local/go/src/golang_org/x/crypto/chacha20poly1305 (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/crypto/chacha20poly1305 (from $GOPATH) /usr/local/go/src/crypto/x509/x509.go:36:2: cannot find package "golang_org/x/crypto/cryptobyte" in any of:         /usr/local/go/src/vendor/golang_org/x/crypto/cryptobyte (vendor tree)         /usr/local/go/src/golang_org/x/crypto/cryptobyte (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/crypto/cryptobyte (from $GOPATH) /usr/local/go/src/crypto/x509/x509.go:37:2: cannot find package "golang_org/x/crypto/cryptobyte/asn1" in any of:         /usr/local/go/src/vendor/golang_org/x/crypto/cryptobyte/asn1 (vendor tree)         /usr/local/go/src/golang_org/x/crypto/cryptobyte/asn1 (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/crypto/cryptobyte/asn1 (from $GOPATH) /usr/local/go/src/crypto/tls/key_agreement.go:20:2: cannot find package "golang_org/x/crypto/curve25519" in any of:         /usr/local/go/src/vendor/golang_org/x/crypto/curve25519 (vendor tree)         /usr/local/go/src/golang_org/x/crypto/curve25519 (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/crypto/curve25519 (from $GOPATH) /usr/local/go/src/net/http/h2_bundle.go:47:2: cannot find package "golang_org/x/net/http2/hpack" in any of:         /usr/local/go/src/vendor/golang_org/x/net/http2/hpack (vendor tree)         /usr/local/go/src/golang_org/x/net/http2/hpack (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/net/http2/hpack (from $GOPATH) /usr/local/go/src/net/http/h2_bundle.go:48:2: cannot find package "golang_org/x/net/idna" in any of:         /usr/local/go/src/vendor/golang_org/x/net/idna (vendor tree)         /usr/local/go/src/golang_org/x/net/idna (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/net/idna (from $GOPATH) /usr/local/go/src/net/http/h2_bundle.go:49:2: cannot find package "golang_org/x/net/lex/httplex" in any of:         /usr/local/go/src/vendor/golang_org/x/net/lex/httplex (vendor tree)         /usr/local/go/src/golang_org/x/net/lex/httplex (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/net/lex/httplex (from $GOPATH) /usr/local/go/src/net/http/transport.go:32:2: cannot find package "golang_org/x/net/proxy" in any of:         /usr/local/go/src/vendor/golang_org/x/net/proxy (vendor tree)         /usr/local/go/src/golang_org/x/net/proxy (from $GOROOT)         /home/munyuamugambi/work/src/golang_org/x/net/proxy (from $GOPATH)

I've put up a small wiki page here with an example - https://github.com/rkbalgi/isosim/wiki/Setting-Up

Thanks rkbalgi. It is working ok.


v2.23 is broken

Return value of Cmgmyr\Messenger\Models\Models::thread() must be an instance of Cmgmyr\Messenger\Models\Thread, instance of App\Models\Thread returned

Current fix: composer require cmgmyr/messenger:2.22 to downgrade

@LorenzoSapora thanks for reporting, I should be able to look into this today.
Curious - is your App\Models\Thread extending the package's Thread model, or no?

It is not. This is an old install with a half developed messenger system (currently just in code, no frontend, as unfinished project).
Note: composer was previously checking for ^2, so this update came as a surprise. System is PHP 7.4.

@LorenzoSapora can you try pulling the current dev-master in your composer.json file? It should be fixed for you. If that works I can tag another release today
Also, if you have time, can you let me know if implementing a Message interface would fix the issue? That way we could eventually use the interface return types and your custom code could optionally implement the interface, or extend the package's Message class. This would be done for all of the models too. Have you implemented all of the methods or just the ones you need in your app?

Sorry for the delay, yes, that fixes my issues.
As for the Message interface, it would provide some additional structure in the future, and I'm struggling to find a reason not to just say "sure". 😄

Excellent! Thanks for letting me know. I'm waiting to hear back on another issue; then, I'll tag a release and close this issue
I'll chew on the interface idea a little more and see if it makes sense to do in a future release - thanks for the feedback!

Perfect. Thanks for all your work here. I appreciate it.

Just tagged a release for 2.24.0. Please let me know if you have anything else come up. Thanks so much for using this package!


allow anemic tenants (users without account_number) through the API

Description
This is the final PR for the EBS/org_id migratoin. This enables anemic tenants (users without account_number) through the API.
All usages of account_number in smart-proxy and aggregator are gone, so we can safely let them through.
I'm repeating again that we haven't had a single user like that in over a month on stage and several days in prod.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
Unit tests (no changes in the code)

Testing steps
with locally modified tokens according to the new spec and with tokens copied directly from crc.
Checklist

[x] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Base: 60.02% // Head: 59.74% // Decreases project coverage by -0.27% :warning:

Coverage data is based on head (6023e23) compared to base (b252d9f).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   60.02%   59.74%   -0.28%
==========================================
  Files          22       22
  Lines        3192     3195       +3
==========================================
- Hits         1916     1909       -7
- Misses       1060     1069       +9
- Partials      216      217       +1

Impacted Files
Coverage Δ

server/auth.go
62.16% <57.14%> (-6.36%)
:arrow_down:

content/content.go
76.95% <0.00%> (-0.83%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create a script run by Travis CI to auto-build dist build files upon merges pushed to master

PR #209 adds initial support for Travis CI, with a .travis.yml file.
Upon successful merging of Pull Requests into the upstream master branch, the build files should be automatically generated (instead of manually now).
The .travis.yml file in PR #209 should be adjusted to contain the following:
branches:
  only:
  - master

script:
  - npm run build
  - npm run min

after_success:
  - ./scripts/deploy.sh

And the ./scripts/deploy.sh script (see this example, or the examples listed below, for inspiration) would run as a bot, on behalf of a user (with a custom GitHub Token with push access permissions to this repo; ping, @toji), that commits the changes with the updated dist build/ files (after calling npm run build && npm run dist) and pushes to upstream master.
Whenever the a push payload request from the GitHub Webhook hits the Travis CI Webhook endpoint, Travis CI would check that a build  just run npm run build && npm run min on master branch.

Inspiration:

https://github.com/cvan/webvr/blob/ca0e903/scripts/deploy.sh (and https://github.com/cvan/webvr/blob/ca0e903/.travis.yml)
https://github.com/aframevr/a-frobot

This is a great idea, but unfortunately we cannot have non-Google bots that have write access to the code -- that being said, a script for maintainers to auto-build/increment package/publish would definitely be helpful in supporting faster development times -- I'll check it out.
Thanks @cvan!


Suspected executable by F-Secure and Windows SmartScreen

There seems to be a problem with F-Secure (branded by my ISP). The DeepGuard detection marks the executable as suspected. Probably because its appearance on the web is very limited now.
Here's a screenshot (in Dutch):

The same happens with Windows SmartScreen.
I trusted the app, since I cannot find any problems in its source. :) And I think that this problem with fade away when more people start using the app. Or when Microsoft and F-Secure have scanned the executable themselves.

Despite this event, the apps works flawlessly (on Windows 10 x64).

That's interesting to learn about; thanks for mentioning it.  I can run a scan on my executable when I get home this evening to see if I detect anything there.  If you are uncomfortable about using the compiled binary, the source is available under the github release (which was generated by github) and if you want I can help you setup Visual Studio 2013 community edition to build the executable yourself.

No problem, @handruin. I see no need to compile it myself. It is just a quick, dirty and generic protection against unknown files. Probably based on a hash. :)

I added a new version and release.  I did a scan with ESET NOD32 and there were no issues detected.  If you still have an issue with this, please let me know.  I appreciate you help with making this app better.


Automatically Create Log Folder inside /scripts if Needed

I think the solution is supposed to be this straightforward, link to the issue:
https://nextcentury.atlassian.net/browse/MCS-753?atlOrigin=eyJpIjoiZWQwMzAzMDFlYjNiNGVmNTliZWFiOTcwYzM0ZjA4NmIiLCJwIjoiaiJ9

Just a little background/soapboxing.  I consider this a glaring bug of the logging framework.  I think this fix is a good idea (even though I actively did not include it originally) if only to make everyone's lives easier.  We should be aware that if anyone uses a different logging config and changes where the logging resides, this error could still occur.  I don't think there is anything reasonable we can do about that.  Soapbox over.


Windows line endings (CRLF) break "state" scope in .talon files

Compare the following screenshots after uttering "visualize state":
With End of Line Sequence set to LF (you can toggle this in the lower right corner of the window):

With End of Line Sequence set to CRLF:

Presumably this is because the parser is looking for LF to delimit statements (commands) and so it doesn't match on CRLF.
This is a problem because most people check out files on Windows with CRLF because it is the default and has the widest compatibility with text editors (e.g. notepad).

My guess this is an upstream issue in tree-sitter-talon. cc @wenkokke

@auscompgeek you are right. I confirmed this and filed a bug there: https://github.com/wenkokke/tree-sitter-talon/issues/41

This has been fixed upstream. Not sure what it takes to update Cursorless.

I'll take care of it; it's easy

Great thanks. Just beware that the output changed slightly, no more empty nodes. I saw a hack in the queries file that mentions this that can probably be removed.

Shipped in VSCode parse tree extension 0.28.1. Thanks @wolfmanstout for doing the hard stuff! 🙌


[0.9.11] world.get_actors() empty in synchronous mode

CARLA version: 0.9.11
OS: Fedora 33
I'm basically doing the following:

Start the server
Start a client and spawn a vehicle, set server to synchronous mode with 20 FPS:

client = carla.Client(args.host, args.port)
client.set_timeout(2.0)
..
carla_world = client.get_world()
settings = carla_world.get_settings()
settings.synchronous_mode = True
settings.fixed_delta_seconds = 1.0 / 20
carla_world.apply_settings(settings)

Start another client, try to get the first client so I can attach some sensors:

client = carla.Client(args.host, args.port)
client.set_timeout(2.0)
..
carla_world = client.get_world()
actors = carla_world.get_actors()

In step 3, the list of actors returned by get_actors() is empty in synchronous mode. When running in async mode (CARLA default), everything is fine. This does not appear to be documented - is it a bug?
FYI the same issue was mentioned in https://github.com/carla-simulator/carla/issues/2045 I believe.

If you're in synchronous_mode, you must tick the World in the first client. Do you do that anywhere in your code?

Yes, I'm doing it in the first client. My agent can drive the hero vehicle just fine, so server <-> client synchrony works fine. I can probably setup a minimal example for you to reproduce this if needed.

Yes, I'm doing it in the first client. My agent can drive the hero vehicle just fine, so server <-> client synchrony works fine. I can probably setup a minimal example for you to reproduce this if needed.

Please do, we definitely need more information to debug this.

Okay, I found the issue.
Apparently this snippet: carla_world = client.get_world() is not executed in a blocking fashion even when synchronous mode is activated. I use the following workaround to wait until actors are populated:
        retry_count = 10
        while retry_count > 0:
            if len(carla_world.get_actors()) > 0:
                break
            else:
                time.sleep(1.0)

        if retry_count == 0 and len(carla_world.get_actors()) == 0:
            raise ValueError('Actors not populated in time')

Without this workaround, the actor list is empty in approx. 50% of the time for me.
This issue occurs even if I apply the sync mode before requesting the world via carla_world = client.get_world(). Perhaps it makes sense to change the implementation so the call blocks when synchronous mode is activated?

I ran into the same problem. I think the actor list is not populated before the first tick after client initialization. For me:
        client = carla.Client(CARLA_HOST, CARLA_PORT)
        client.set_timeout(CARLA_TIMEOUT)
        client.get_world().wait_for_tick()

solves the problem, but I think this is not the correct client behavior.


Build Provider REST API Definition [5]

Description
As a developer, I want to understand the REST API that build providers must implement as part of the Build System SPI on a detailed level.
Functional Acceptance Criteria

There is a definition for the build provider REST API contract between the build provider and the ALM system.
There is a definition for the communication flows between the components including the involved communication artifacts and models.

Note: this is a "technical userstory" that is not recommended in a Scrum process, but in reality very common. It provides means of doing technical groundwork that is not directly covered by user experiences. The "story" is needed to integrate the work entity into the existing process.
Non-functional Acceptance Criteria

The resulting artifact is a document.
The resulting artifact is considered a architecture/definition that includes all above FACs. Goal is to do detailed definitions in later stories.

https://github.com/almighty/almighty-devdoc/pull/111


fix(ci): removing this versioning tool

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


google-cloud-logging: LoggingImpl.pendingWrites remove before add (with suggested fix)

In LoggingImpl, it is possible to leak memory in pendingWrites, if the future completes before the callback is added. If so, the callback runs before the call to pendingWrites.remove()
  @Test
  public void testMemoryLeak() {
    WriteLogEntriesRequest request =
            WriteLogEntriesRequest.newBuilder()
                    .addAllEntries(
                            Iterables.transform(
                                    ImmutableList.of(LOG_ENTRY1, LOG_ENTRY2), LogEntry.toPbFunction(PROJECT)))
                    .build();
    WriteLogEntriesResponse response = WriteLogEntriesResponse.newBuilder().build();
    EasyMock.expect(loggingRpcMock.write(request)).andStubReturn(ApiFutures.immediateFuture(response));
    EasyMock.replay(rpcFactoryMock, loggingRpcMock);
    logging = options.getService();
    LoggingImpl impl = (LoggingImpl) logging;
    assertEquals(0, impl.pendingWrites.size());
    for (int i = 0; i < 1000; i++) {
      logging.write(ImmutableList.of(LOG_ENTRY1, LOG_ENTRY2));
    }
    logging.flush();
    assertEquals(0, impl.pendingWrites.size());
  }

A proposed fix is to move this code to between creating the future and adding the callback.
        synchronized (writeLock) {
          pendingWrites.add(writeFuture);
        }

PR: #4696

fixed with #4696


Should previousIdentifications be part of Identification?

Should the term dwc:previousIdentifications not be under the class Identification? It is currently lsited under Organism

It seems that generally property terms are listed under the class of the kind of thing that would have that property.  Since organisms would have identifications, I think that's why dwc:previousIdentifications are listed under dwc:Organism.  I'm not sure that there is consistency on this for every property term, but I think it's what happens most of the time when it seems clear what the class is of the subject resource.

I agree with Steve. Sure, previousIdentifications have something to do with Identifications, but the dwcattributes:organizedIn attribute of a term is meant to indicate that the term would be a reasonable candidate to be property of that Class, if we went as far as creating an ontology with such relationships. Specifically, I would ask the question, "Would a previousIdentification be a property of an Identification?" To me the answer is a clear, "No".

I agree. I was simply misled by the name of the term that it should belong to the identification class.


Disable initialFocus and setReturnFocus in focusTrap for screen

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/46109
PROPOSAL: https://github.com/Expensify/App/issues/46109#issuecomment-2249101171
Tests

For macos-web, mweb, safari:

Click the FAB + button, start a chat, and then refresh the page.
Verify that the blue border does not appear.
Click the FAB + button, submit an expense, choose "manual," and then refresh the page.
Verify that the blue border does not appear.
Go to the workspace list page and refresh the page.
Verify that the blue border does not appear.
Go to the workspace preferences page and refresh the page.
Verify that the blue border does not appear.

For desktop:
Open the pages in a browser, refresh the page, and then choose open in Electron.
For native iOS and Android:
Visit the pages and verify that they appear as expected.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

For macos-web, mweb, safari:

Click the FAB + button, start a chat, and then refresh the page.
Verify that the blue border does not appear.
Click the FAB + button, submit an expense, choose "manual," and then refresh the page.
Verify that the blue border does not appear.
Go to the workspace list page and refresh the page.
Verify that the blue border does not appear.
Go to the workspace preferences page and refresh the page.
Verify that the blue border does not appear.

For desktop:
Open the pages in a browser, refresh the page, and then choose open in Electron.
For native iOS and Android:
Visit the pages and verify that they appear as expected.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/3a63491a-f99e-44b1-8aa6-00d1dfb505b5

Android: mWeb Chrome
https://github.com/user-attachments/assets/50e6d1f7-bfac-47a4-8d86-530d7e85a783

iOS: Native
https://github.com/user-attachments/assets/e3359a47-7345-41dd-ab99-681a9eb932b9

iOS: mWeb Safari
https://github.com/user-attachments/assets/9786489f-1115-4a9c-90f4-b107992afc27

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/f1bb707c-fab7-4e21-a8e8-b6bd07ea640f

MacOS: Desktop
https://github.com/user-attachments/assets/b3f5d3fe-944d-4ffc-a13e-3a5edb57701b

@tsa321 Can you please resolve the merge conflict?

Thanks @tsa321
I can no longer access the profile pages by pressing the Enter key. Could you please check on your end? When I reviewed the PR last time, everything was working fine, but after the latest commit, I can no longer navigate to different pages using the Enter key.
https://github.com/user-attachments/assets/cfd820a7-de69-43bb-9205-5502b6b21aeb

Hi @tsa321 or @sobitneupane, is this issue still reproducible on staging?

Awesome, thanks for checking, was able to reproduce on the profile page as well.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Updating CloudCapabilities for TP3

@srimathiS,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Hey Srimathi,
Can you make a README update as well to point to the new file?


bug: Multiple data loaders found shown happens when handling requests

Please read our contributor guide before
creating an issue.
Expected behavior
When multiple data loaders are using @DgsDataLoader with the same name, it should validate that and fail early.
Actual behavior
App starts up successfully, but failed to handle requests with error "Multiple data loaders found"
Steps to reproduce
Note: A test case would be highly appreciated, but we understand that's not always possible

@kzwang in which version you are seeing this issue?


 Further diagnostics are a good idea before merging

bors merge

The maintainers became aware of the personal (and hence non-professional) nature of the commit message inserted after the PR was delegated, and I am letting you know that we decided to force push to the master branch to remove it. This unfortunately disrupts a number of open PRs and complicates the porting process.


Consider supporting GitHub Enterprise

I work on a large international team using GitHub Enterprise. I think it would be cool to support that. We could probably do something like check if we are in a git working tree and if the origin is not github.com then to try the origin as a GitHub Enterprise URL, falling back to github.com.
The trickiest part would be authorization. Would it be reasonable to ask users to place access tokens somewhere?

Thanks for the suggestion.
In the background, it uses gh-got to make some API calls. So I guess when you export GITHUB_ENDPOINT as documented in gh-got, that part is covered.
The only thing that should be fixed is dev-time#L16 line. In order to retrieve the timezone, it downloads the repository with the latest contribution of the user. Is it as simple as https://git.myenterprise.com/some-repo.git? Not really familiar with GitHub Enterprise.

Yes, it's pretty much just github with your own hostname.


[zkapp_command]Write tests for valid_size and get_transaction_commitments

Write property-based tests for valid_size and get_transaction_commitments

Tests written for valid_size. I still need to do get_transaction_comitments


Error during create_base_entity_graph stage in GraphRAG pipeline

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have checked #657 to validate if my issue is covered by community support

Describe the issue
I encountered an error when running the graphrag.index command. The error occurs during the create_base_entity_graph stage. Below is the detailed error message and logs.
Steps to reproduce

Activate the graphrag conda environment (Python 3.11).
Install graphRAG with pip and set the OpenAI API key.
Run the following command: python -m graphrag.index --init --root ./ragtest
See the error message during the create_base_entity_graph stage.

GraphRAG Config Used

encoding_model: cl100k_base
skip_workflows: []
llm:
  api_key: ${GRAPHRAG_API_KEY}
  type: openai_chat # or azure_openai_chat
  model: gpt-4-turbo-preview
  model_supports_json: true # recommended if this is available for your model.
  # max_tokens: 4000
  # request_timeout: 180.0
  # api_base: https://<instance>.openai.azure.com
  # api_version: 2024-02-15-preview
  # organization: <organization_id>
  # deployment_name: <azure_model_deployment_name>
  # tokens_per_minute: 150_000 # set a leaky bucket throttle
  # requests_per_minute: 10_000 # set a leaky bucket throttle
  # max_retries: 10
  # max_retry_wait: 10.0
  # sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
  # concurrent_requests: 25 # the number of parallel inflight requests that may be made
  # temperature: 0 # temperature for sampling
  # top_p: 1 # top-p sampling
  # n: 1 # Number of completions to generate

parallelization:
  stagger: 0.3
  # num_threads: 50 # the number of threads to use for parallel processing

async_mode: threaded # or asyncio

embeddings:
  ## parallelization: override the global parallelization settings for embeddings
  async_mode: threaded # or asyncio
  llm:
    api_key: ${GRAPHRAG_API_KEY}
    type: openai_embedding # or azure_openai_embedding
    model: text-embedding-3-small
    # api_base: https://<instance>.openai.azure.com
    # api_version: 2024-02-15-preview
    # organization: <organization_id>
    # deployment_name: <azure_model_deployment_name>
    # tokens_per_minute: 150_000 # set a leaky bucket throttle
    # requests_per_minute: 10_000 # set a leaky bucket throttle
    # max_retries: 10
    # max_retry_wait: 10.0
    # sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
    # concurrent_requests: 25 # the number of parallel inflight requests that may be made
    # batch_size: 16 # the number of documents to send in a single request
    # batch_max_tokens: 8191 # the maximum number of tokens to send in a single request
    # target: required # or optional

chunks:
  size: 1200
  overlap: 100
  group_by_columns: [id] # by default, we don't allow chunks to cross documents

input:
  type: file # or blob
  file_type: text # or csv
  base_dir: "input"
  file_encoding: utf-8
  file_pattern: ".*\\.txt$"

cache:
  type: file # or blob
  base_dir: "cache"
  # connection_string: <azure_blob_storage_connection_string>
  # container_name: <azure_blob_storage_container_name>

storage:
  type: file # or blob
  base_dir: "output/${timestamp}/artifacts"
  # connection_string: <azure_blob_storage_connection_string>
  # container_name: <azure_blob_storage_container_name>

reporting:
  type: file # or console, blob
  base_dir: "output/${timestamp}/reports"
  # connection_string: <azure_blob_storage_connection_string>
  # container_name: <azure_blob_storage_container_name>

entity_extraction:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  prompt: "prompts/entity_extraction.txt"
  entity_types: [organization,person,geo,event]
  max_gleanings: 1

summarize_descriptions:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  prompt: "prompts/summarize_descriptions.txt"
  max_length: 500

claim_extraction:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  # enabled: true
  prompt: "prompts/claim_extraction.txt"
  description: "Any claims or facts that could be relevant to information discovery."
  max_gleanings: 1

community_reports:
  ## llm: override the global llm settings for this task
  ## parallelization: override the global parallelization settings for this task
  ## async_mode: override the global async_mode settings for this task
  prompt: "prompts/community_report.txt"
  max_length: 2000
  max_input_length: 8000

cluster_graph:
  max_cluster_size: 10

embed_graph:
  enabled: false # if true, will generate node2vec embeddings for nodes
  # num_walks: 10
  # walk_length: 40
  # window_size: 2
  # iterations: 3
  # random_seed: 597832

umap:
  enabled: false # if true, will generate UMAP embeddings for nodes

snapshots:
  graphml: false
  raw_entities: false
  top_level_nodes: false

local_search:
  # text_unit_prop: 0.5
  # community_prop: 0.1
  # conversation_history_max_turns: 5
  # top_k_mapped_entities: 10
  # top_k_relationships: 10
  # llm_temperature: 0 # temperature for sampling
  # llm_top_p: 1 # top-p sampling
  # llm_n: 1 # Number of completions to generate
  # max_tokens: 12000

global_search:
  # llm_temperature: 0 # temperature for sampling
  # llm_top_p: 1 # top-p sampling
  # llm_n: 1 # Number of completions to generate
  # max_tokens: 12000
  # data_max_tokens: 12000
  # map_max_tokens: 1000
  # reduce_max_tokens: 2000
  # concurrency: 32

Logs and screenshots
[42 rows x 5 columns]
🚀 create_base_extracted_entities
                                        entity_graph
0  <graphml xmlns="http://graphml.graphdrawing.or...
🚀 create_summarized_entities
                                        entity_graph
0  <graphml xmlns="http://graphml.graphdrawing.or...
❌ create_base_entity_graph
None
⠦ GraphRAG Indexer
├── Loading Input (InputFileType.text) - 1 files loaded (0 filtered) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 0:00:00
├── create_base_text_units
├── create_base_extracted_entities
├── create_summarized_entities
└── create_base_entity_graph
❌ Errors occurred during the pipeline run, see logs for more details.

Additional Information

GraphRAG Version:  0.2.0
Operating System: Ubuntu 20.04.6 LTS
Python Version: 3.11
Related Issues:

I had the same problem, but it worked out. You can look at the log in the output directory. My problem is that openai doesn't have enough Key permissions. After the repair is done

I had the same problem, but it worked out. You can look at the log in the output directory. My problem is that openai doesn't have enough Key permissions. After the repair is done

What key permissions did you give exactly?

Please provide the indexing-engine.log file located in the report directory inside output dir. This file contains detailed information about the issue you're experiencing, which will help us replicate the problem and find a solution.

Please provide the indexing-engine.log file located in the report directory inside output dir. This file contains detailed information about the issue you're experiencing, which will help us replicate the problem and find a solution.

This is the log file.
indexing-engine.log

It looks like the error message in the log is: 'The model gpt-4-turbo-preview does not exist or you do not have access to it.'
Upon checking, I noticed that the api_base setting in your configuration is commented out. For the model and API base to work correctly, you need to ensure that these fields are properly set.
If you're using an Ollama-based local setup, you might want to use the following configuration:
llm:
  api_key: ${GRAPHRAG_API_KEY}
  type: openai_chat # or azure_openai_chat
  model: mistral # your choice of model
  model_supports_json: true # recommended if available for your model
  # max_tokens: 4000
  # request_timeout: 180.0
  api_base: http://localhost:11434/v1

It looks like the error message in the log is: 'The model gpt-4-turbo-preview does not exist or you do not have access to it.'
Upon checking, I noticed that the api_base setting in your configuration is commented out. For the model and API base to work correctly, you need to ensure that these fields are properly set.
If you're using an Ollama-based local setup, you might want to use the following configuration:
llm:
  api_key: ${GRAPHRAG_API_KEY}
  type: openai_chat # or azure_openai_chat
  model: mistral # your choice of model
  model_supports_json: true # recommended if available for your model
  # max_tokens: 4000
  # request_timeout: 180.0
  api_base: http://localhost:11434/v1

Thank you for your help, but the same error still occurs even after trying that. I've attached the logs. Could you please take a look at them?
logs.json

It looks like there might be an issue with the embedding setup. The response from the embedding API might not be in the expected format.
Try using the following configuration with LM Studio as the API provider and check if it resolves the issue:
embeddings:
  ## Parallelization: Override the global parallelization settings for embeddings
  async_mode: threaded # or asyncio

  llm:
    api_key: ${GRAPHRAG_API_KEY}
    type: openai_embedding # or azure_openai_embedding
    model: nomic-ai/nomic-embed-text-v1.5-GGUF
    api_base: http://localhost:1234/v1/

请提供位于输出目录内的报告目录中的文件。此文件包含有关您遇到的问题的详细信息，这将有助于我们复制问题并找到解决方案。indexing-engine.log

大佬，可以帮我看一下吗？
Uploading indexing-engine.log…

logs.json

请提供位于输出目录内的报告目录中的文件。此文件包含有关您遇到的问题的详细信息，这将有助于我们复制问题并找到解决方案。indexing-engine.log

大佬，可以帮我看一下吗？ Uploading indexing-engine.log…

indexing-engine.log

same

@eeleedev do you have a recent indexing-engine.log? The last one posted was missing api_base, resulting in a 404, but I'm not sure if that was fixed based on following comments. Please double-check the getting started page for the baseline required parameter.

This issue has now been resolved, and I followed the content on the following webpage to solve it:
https://fornewchallenge.tistory.com/entry/%F0%9F%93%8AGraphRAG-%EB%A7%88%EC%9D%B4%ED%81%AC%EB%A1%9C%EC%86%8C%ED%94%84%ED%8A%B8%EC%9D%98-%EA%B7%B8%EB%9E%98%ED%94%84%EA%B8%B0%EB%B0%98-RAG-%EC%A0%91%EA%B7%BC%EB%B2%95feat-Ollama


update info.yaml as per LF build team request

Updated as per https://github.com/odpi/ci-management/issues/118
Signed-off-by: Nigel Jones<EMAIL_ADDRESS>

Thanks @cmgrote - corrected (and again ran yamllint)

I've changed the filename to INFO.yaml
Can you elaborate on what you need for the tsc. Technical Steering Group?
Is it meant to be an id? email? web address?
And what do 'changes' signify (and then what does type/name/link mean?)
I see the schema at https://github.com/lfit/releng-global-jjb/blob/3fba00b0773a59eed76521103afb0a62deb79786/schema/info-schema.yaml but beyond requiring a 'tsc' entry, without docs/info I don't know the context, how the info is used, what is expected . Info on our meetings can be found at https://github.com/odpi/egeria
The TSC itself is the ODPi TSC. More info on this can be found at https://github.com/odpi/tsc
Perhaps you could make the changes that are needed & submit a PR? It is likely more efficient (I can merge my current changes first if it helps?)


must use compile option "-d:release"

If "- d: release" is not used, it will be built in debug mode.
It has considerable overhead and performance gets worse.
I want you to redo the benchmark right now...

Awesome, thanks
I will wait until we use wrk to recompute results

@2vg Wow, my thing in https://github.com/tbrand/which_is_the_fastest/issues/101 was testing mofuw when it is not in release build?  It was already one of the absolute fastest out!
Do note, the benchmarks shown in the readme are absolute garbage, the testing tool is single threaded so it cannot saturate hardly any of the servers at all.
I still don't know why the benchmarks were done with a custom single-core tool...  >.>

It will be updated @OvermindDL1 ... but feel free to PR (a crystal frontend that use wrk)


Update README.md

Codecov Report

Merging #135 (632398c) into main (bf4d4b2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           20        20
  Lines          612       612
  Branches        50        50
=========================================
  Hits           612       612

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4d4b2...632398c. Read the comment docs.


Fixes#827 Fixed the dark mode toggle of job listing page

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

This is not a fix. This is a request to add login and signup pages to the site.
Summarize what this PR fixes:- Fixed the dark mode of job listing page
Fixes #827
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

Same thing on the header here.