SafeHandle implementations do not lease owning objects

The sqlite3_blob implementation does not ensure it is released prior to the owning sqlite3 object. One of the following is needed:

Document that sqlite3 is allowed to be disposed before sqlite3_blob (and more specifically, internal_sqlite3_close_v2 is allowed to be caled before internal_sqlite3_blob_close).
Update the implementation of sqlite3_blob to lease the sqlite3 handle, which guarantees the finalization order. An example of this behavior using the v1 API is available in SafeSqliteBlobHandle.

Without the above, the new SafeHandle implementations are not directly usable, and must be wrapped in a second layer of safe handles to provide the ordering guarantees.
This issue applies to sqlite3_stmt (which dotnet/roslyn uses), and may apply to other types as well (not used by dotnet/roslyn). Please feel free to let me know if you have any questions and/or to mention me on a review.

That's interesting.  Thanks for the info.
Just curious -- did you find this issue because some problem showed up in the wild?  Or did you notice it on code review?

That's interesting.  Thanks for the info.
Just curious -- did you find this issue because some problem showed up in the wild?  Or did you notice it on code review?

We found this issue during our work to update dotnet/roslyn from v1 to v2.

We found this issue during our work to update dotnet/roslyn from v1 to v2.

Thinking more about this.
Issues like this one make me wonder if it was a mistake to migrate these types to use SafeHandle.
The goal of the lowest layer of SQLitePCLRaw is, as much as possible, to present the exact same semantics as the SQLite C API.
For example, in the SQLite C API, it is illegal to close a sqlite3 if it still has sqlite3_stmt instances open.  Nothing ever calls sqlite3_close() automatically, and there is certainly no way to have sqlite3_close() find all sqlite3_stmts that are open and close them down first.
Right now I'm wondering if it would have been better if I had one layer that exactly matched the SQLite C API and everything related to SafeHandle and finalizers was one layer about that.

Still thinking...

Document that sqlite3 is allowed to be disposed before sqlite3_blob

I wonder how credible it would be for me to argue that this documentation is already present and exists here:
https://www.sqlite.org/c3ref/close.html

@ericsink I believe that is a reasonable claim to make. The only remaining question is whether the sqlite3_blob is usable while the connection is in the zombie state.

Please let me know if you think the issue I am describing is not related, I will file a new one, but it's also related to SafeHandle.
I was looking at a PerfView trace for an application using sqlite and the GC stats show a lot of finalized objects:

SQLitePCL.hook_handle
12434

This happens if the object's finalizer is called, and it's not expected if it implements IDisposable since it should call GC.SuppressFinalize() in that case. It happens that hook_handle inherits from SafeHandle which correctly invokes GC.SuppressFinalize(), so it leads me to think that some instances of hook_handle are not correctly disposed.

@sebastienros That's a separate issue. hook_handle.ForDispose() prevents instances created to represent null from getting disposed. The solution is to delete hook_handle.ForDispose() since it's unnecessary (disposing of a null/invalid SafeHandle is not only fine; it's expected).


Tensorflow Lite: iOS 14 breaks the NPU Delegate

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
iOS 14
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
iPhone 11 pro,
TensorFlow installed from (source or binary):
via pods: pod 'TensorFlowLiteSwift', '~> 0.0.1-nightly'
TensorFlow version (use command below):
TensorFlowLiteSwift 0.0.1-nightly

Describe the current behavior
The update to iOS 14 broke the NPU (coreML) Delegate in tensorflow Lite.
The issue presents itself in the tensorflow lite example on iOS for posenet.
As soon as the coreML delegate is selected the joints of the body arent recognized properly anymore and the output of the net is garbage.
Images showing the correct (GPU) and incorrect (NPU) pose estimation:
https://imgur.com/a/UzMM6Pt
Describe the expected behavior
The NPU delegate should produce the same results as CPU/GPU
Standalone code to reproduce the issue
Download the tensorflow Lite example for posenet on iOS and select the NPU delegate on a iOS 14 device

Hi @boost-app , I can confirm I'm seeing the same issue on iOS 14 (iPhone Xs).
Thanks for the report and will take a look.

With the manually converted mlmodel from tflite model, I could reproduce the same issue on iOS PoseFinder demo app. (see details on the coremltools issue.) Will keep investigating is this is actually a bug in iOS 14 or the delegate.

@teijeong Hi,
Seems to be this issue with wrong model (wrong activation) is solved.
But there is another issue with PoseNet example, if you run PoseNet-example and the press Off button (short press side button), and then try to return to the application, then the image will be frozen, and after many attempts the application cannot be closed at all from the iPhone (I managed to stop it only from xcode). iOS 13.7, and all the same settings.

I tested again on iOS 14.1 and 14.2 and it seems to be resolved. Can someone verify?

Yes, it works well for iOS 13.7, 14.1, 14.2.
But it didn't work for iOS 14.0.

@boost-app It looks like you are using an older Version of Tensorflow. Many bugs have been fixed in the latest version. Could you please execute your code using Latest  stable Version of TF 2.5 and let us know if the issue still persists? Thanks!


Guide difficult to understand

I am not sure I understand the guide. In your additional instructions for MacOS you say: "Open Unlimited Hotspot’s "macOS" folder in Finder."
Are we supposed to download "Unlimited Hotspot" on the Mac? There is no link to the releases page. You don't mention downloading Unlimited Hotspot for the Mac. All you mentioned is "download SpoofDPI".
Also, if you want to use your Android phone as a hotspot, do you need to download anything on the Mac? PowerTunnel by itself does not work - the hotspot usage is instantly detected by T-Mobile.
Also, I assume we are talking about wireless hotspot, not USB.
Thanks.

The instructions should be more clear now regarding macOS. The "hotspot" is assumed either wireless, or wired via USB; it applies to both.
You still have to download an anti-DPI application for your Mac when using an Android device for the hotspot. PowerTunnel for Android is to bypass DPI for Android devices, you have to install that on every Android device you use, and the same goes for the macOS instructions for macOS devices.

Thanks! Do we ever run SpoofDPI directly on the Mac, or it just needs to be installed?
Also, does Power Tunnel need to be run in VPN ir proxy mode?

On the Mac you install SpoofDPI https://github.com/xvzc/SpoofDPI#curl -> then you run it -> https://github.com/xvzc/SpoofDPI#osx
PowerTunnel you run in VPN mode, so I'll add a note about that too.

All right, thanks a bunch!

I would try using PowerTunnel, which I put instructions for very recently here: https://github.com/felikcat/unlimited-hotspot#2-moving-past-throttling
I've noticed that SpoofDPI has issues with certain websites for my own usage, like for OpenWrt LuCI, and I don't use any external firewall applications. PowerTunnel also has more protections against DPI than SpoofDPI currently.


Masked RNNs return zero vectors for masked inputs and not a valid state

Hi all
Is there a way to change the behaviour of RNNs with masking so that masked values output the most previous valid state rather than the zero vector? This means we can pad at the end of variable length sequences, which is a little bit easier than pre-padding. Also, it makes a forward-backward RNN model slightly easier to implement, which helps to implement some sequence-to-sequence stuff.
In addition, why is masking only applied if return_sequences is set as True?  I can see why this is the sensible thing to do if padding values return 0 (as otherwise you'll just get 0's at the end), but if you return the most recent valid state I think there's a reasonable use case for masking to always be applied.
Thanks
Kris

n addition, why is masking only applied if return_sequences is set as True?

Masking is always applied, independently from return_sequences.

so that masked values output the most previous valid state rather than the zero vector?

This is already the case.

Sorry, I was working off an older version of Keras. Just rebased and picked up the changes.
Thanks for the heads up!


Storage object sample cannot process an object

After building https://github.com/googleapis/google-cloud-cpp/blob/master/google/cloud/storage/examples/storage_object_samples.cc as an executable against 0.9.x, I used it to ensure the project was working as expected.
Does this issue affect the google-cloud-cpp project?
I think it does (I'm happy to be proven wrong).
What component of google-cloud-cpp is this related to?

Cloud Storage (under development).

What version of google-cloud-cpp are you using?
64bf0e32fbd234a709c3aa910878723da9378f2a
What compiler and version are you using?
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/opt/rh/devtoolset-3/root/usr/libexec/gcc/x86_64-redhat-linux/4.9.2/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/opt/rh/devtoolset-3/root/usr --mandir=/opt/rh/devtoolset-3/root/usr/share/man --infodir=/opt/rh/devtoolset-3/root/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --enable-languages=c,c++,fortran,lto --enable-plugin --with-linker-hash-style=gnu --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.9.2-20150212/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.9.2-20150212/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.9.2 20150212 (Red Hat 4.9.2-6) (GCC)

What operating system and version are you using?
CentOS Linux release 7.5
What were you trying to do?
I was trying to list objects in a bucket, this worked fine. I also checked that I needed the right credentials to do so (without the credentials, I had an error indicating wrong credentials, as expected).
I then tried to download a file through this example and then use read-object on the same file. This failed.
What did you expect to see?
I expected to see the result of the operation, either a downloaded file or the number of lines of this file.
What did you see instead?
I got a curl error for the download:
Standard C++ exception raised: Retry policy exhausted in ReadObject: PerformWork() - CURL error [6]=Couldn't resolve host name, object_name=xxxx,  bucket_name=xxxx [UNAVAILABLE]

For the read-object, I got: The object has 0 lines
Using gsutil on the command line did work and was able to access the file.
Anything else you would like us to know?
I have credentials exported

Thanks for filing a detailed bug report.
I am having trouble reproducing this one. Maybe you can tell how is my setup materially different from yours?  Am I reading your reports correctly: did you compile + install the library and then compiled the example? That should work, just trying to make sure I follow the same steps you took.
$ cat /etc/redhat-release
CentOS Linux release 7.6.1810 (Core)
$ cmake -H. -B/o
[snip snip]
$ cmake --build /o --target storage_object_samples -- -j $(nproc)
$ export GOOGLE_APPLICATION_CREDENTIALS=/tmp/creds.json
$ export MY_BUCKET_NAME=[censored
$ /o/google/cloud/storage/examples/storage_object_samples read-object ${MY_BUCKET_NAME} lorem.txt
The object has 6 lines
$ /o/google/cloud/storage/examples/storage_object_samples download-file ${MY_BUCKET_NAME} lorem.txt foo.txt
Downloaded lorem.txt to foo.txt
$ cat foo.txt
Lorem ipsum dolor sit amet, consectetur adipiscing
elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim
ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit
esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat
non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

$ g++ --version
g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ ldd /o/google/cloud/storage/examples/storage_object_samples
        linux-vdso.so.1 =>  (0x00007ffde83e9000)
        libcares.so.2 => /o/external/lib/libcares.so.2 (0x00007f1428bc8000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f14289ac000)
        libssl.so.10 => /lib64/libssl.so.10 (0x00007f142873a000)
        libcrypto.so.10 => /lib64/libcrypto.so.10 (0x00007f14282d8000)
        libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007f1427fd1000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f1427ccf000)
        libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f1427ab9000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f14276ec000)
        libnsl.so.1 => /lib64/libnsl.so.1 (0x00007f14274d2000)
        librt.so.1 => /lib64/librt.so.1 (0x00007f14272ca000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f1428ddf000)
        libgssapi_krb5.so.2 => /lib64/libgssapi_krb5.so.2 (0x00007f142707d000)
        libkrb5.so.3 => /lib64/libkrb5.so.3 (0x00007f1426d94000)
        libcom_err.so.2 => /lib64/libcom_err.so.2 (0x00007f1426b90000)
        libk5crypto.so.3 => /lib64/libk5crypto.so.3 (0x00007f142695d000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00007f1426759000)
        libz.so.1 => /o/external/lib/libz.so.1 (0x00007f142653b000)
        libkrb5support.so.0 => /lib64/libkrb5support.so.0 (0x00007f142632b000)
        libkeyutils.so.1 => /lib64/libkeyutils.so.1 (0x00007f1426127000)
        libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f1425f0e000)
        libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f1425ce7000)
        libpcre.so.1 => /lib64/libpcre.so.1 (0x00007f1425a85000)

Indeed, I fear it's either an issue with my credentials (I'll check again today with our liaison), or it something else that I can't understand.
Here we go for ldd:
    linux-vdso.so.1 =>  (0x00007ffd9a5f6000)
    libcurl.so.4 => /lib64/libcurl.so.4 (0x00007f034c0e7000)
    libcrypto.so.10 => /lib64/libcrypto.so.10 (0x00007f034bc86000)
    libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007f034b97f000)
    libm.so.6 => /lib64/libm.so.6 (0x00007f034b67d000)
    libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f034b467000)
    libc.so.6 => /lib64/libc.so.6 (0x00007f034b09a000)
    libidn.so.11 => /lib64/libidn.so.11 (0x00007f034ae67000)
    libssh2.so.1 => /lib64/libssh2.so.1 (0x00007f034ac3d000)
    libssl3.so => /lib64/libssl3.so (0x00007f034a9eb000)
    libsmime3.so => /lib64/libsmime3.so (0x00007f034a7c4000)
    libnss3.so => /lib64/libnss3.so (0x00007f034a497000)
    libnssutil3.so => /lib64/libnssutil3.so (0x00007f034a268000)
    libplds4.so => /lib64/libplds4.so (0x00007f034a064000)
    libplc4.so => /lib64/libplc4.so (0x00007f0349e5f000)
    libnspr4.so => /lib64/libnspr4.so (0x00007f0349c21000)
    libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f0349a05000)
    libdl.so.2 => /lib64/libdl.so.2 (0x00007f0349801000)
    libgssapi_krb5.so.2 => /lib64/libgssapi_krb5.so.2 (0x00007f03495b4000)
    libkrb5.so.3 => /lib64/libkrb5.so.3 (0x00007f03492cc000)
    libk5crypto.so.3 => /lib64/libk5crypto.so.3 (0x00007f0349099000)
    libcom_err.so.2 => /lib64/libcom_err.so.2 (0x00007f0348e95000)
    liblber-2.4.so.2 => /lib64/liblber-2.4.so.2 (0x00007f0348c86000)
    libldap-2.4.so.2 => /lib64/libldap-2.4.so.2 (0x00007f0348a31000)
    libz.so.1 => /lib64/libz.so.1 (0x00007f034881b000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f034c350000)
    libssl.so.10 => /lib64/libssl.so.10 (0x00007f03485a9000)
    librt.so.1 => /lib64/librt.so.1 (0x00007f03483a1000)
    libkrb5support.so.0 => /lib64/libkrb5support.so.0 (0x00007f0348193000)
    libkeyutils.so.1 => /lib64/libkeyutils.so.1 (0x00007f0347f8f000)
    libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f0347d76000)
    libsasl2.so.3 => /lib64/libsasl2.so.3 (0x00007f0347b59000)
    libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f0347932000)
    libcrypt.so.1 => /lib64/libcrypt.so.1 (0x00007f03476fb000)
    libpcre.so.1 => /lib64/libpcre.so.1 (0x00007f0347499000)
    libfreebl3.so => /lib64/libfreebl3.so (0x00007f0347296000)

Is there a debug level I can activate to check what is sent to curl for instance?

You can enable logging by setting some environment variables:
$ export CLOUD_STORAGE_ENABLE_CLOG=yes
$ export CLOUD_STORAGE_ENABLE_TRACING=http,raw-client

Be prepared because it is a lot of log output.

Thanks! I don't mind digging in logs, hopefully I'll find my issue.

Got an error very quickly, the name is not resolved on a box on the cloud (one of ours), but it is resolved outside the cloud. The reason for the failure, after checking internally, is that we need to refresh these endpoints from time to time.
Thanks a lot for the help and support!


Add new pet names

This PR adds new names to Snake, Crab, and Duck types.
The TODO comment for hello() in Dog is also removed since we already implemented it.

Thanks for the contribution! I will merge this once the checks pass. Good luck with hacktoberfest

Thank you so much!


Memory problems

BkCommonLib version: 1.12.2-v4
TrainCarts version: 1.12.2-v2
Spigot version: 1.12.2-R0.1

Problem or bug:
When using the automatic train control system, running trains allocate more and more memory and the garbage collector does not help. The result is that my server crash because all free memory was used. In 1 day, it also takes 1GB of RAM. I tested it on an empty server.
Expected behaviour:
I expect trains to get the memory needed for traffic, but not all the time!
Steps to reproduce:
I have 1 km long metro system under my city and the trains have 5 carts and on line was 4 trains.
Trains have the following properties: Speedlimit 1, keepchunks true, playercollision cancel other setting is default. I have 10 security devices on the track like [waiter] which is set to 100 blocks and every sign is always powered in my metro. And in plugin setting is set keepChunksLoadedOnlyWhenMoving: false and other setting is without change.

How much memory did you allocate?
Can you provide detailed timings on the server?

From the details you have given me so far, there are a number of possible things that may be causing lag:

UpdateDirection is called too frequently due to train speed being too high.
BlockCollision (a parameter added in the development builds) being DEFAULT is introducing a lot of lag due to train hitbox intersecting with nearby blocks (is only true if you use models).
Long distance waiters make searching for trains ahead consume server tick routines.

The server is set on 4GB.
I don't know if I understand what you want. If is server empty, trains allocate memory at a rate of several MB per hour. In 1 day after start server using 1GB more that it was on start.
I don't have problems with lags.

As I said, I need the timings of the server when the memory is high. Do [/timings on] to start timings, and [/timings paste] to get the timings.

Anyways, the only thing I'm concerned about is TrainCarts using only 1 GB of RAM is far too less due to algorithm logic.

Oh I did not know about this command. I will send timing later.
Did you say it's 1GB a little? 1GB of RAM per day is really a lot. How much do you think is enough? I have no unlimited memory.
He also said that plugin caches a lot of things into memory banks.  And do you delete data from those banks when the plugin don't needed? I doubt that plugin need more data on the same track.

I believe memory is allocated per train, not per track.

That's possible, I do not know how it's implemented in the plugin.
If in those memory banks accumulating unnecessary data, then their cleaning will solve this problem.

I don't think anything that the trains cache are unnecessary... although I can't say for sure, developer is offline at the moment.

Theres several caching performed to speed up performance overall:

Rail type and positions detected in the world
Signs detected for rails
Rails blocks in use for each minecart
All this data is routinely wiped and as a life of about 10 ticks unless actually used. So while a train is moving, it will continuously poll the same rails, keeping that data loaded. When the train is destroyed, and no other train is driving over the same rails within 10 ticks, the data cached there is gone.

Memory leak from the plugin is unlikely. However, a memory leak due to an increasing number of chunks being loaded is a possibility. Can you run some diagnostics tools to see how many chunks are loaded over time? I don't know what tools can do so as I'm out of the loop, all I know about is NoLagg which is largely no longer maintained.

Using the /lag command in the essentials plugin shows that the number of active bits is between 350-400. But the memory grows, I do not know what tool to measure it.
There are some timings:
https://www.spigotmc.org/go/timings?url=mobajiqecu
https://timings.spigotmc.org/?url=mobajiqecu
https://timings.spigotmc.org/?url=yusimilixi

You can tell java to generate a memory dump when it runs out of memory. Add the following java commandline parameters to that for your server:
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=coredump.dmp
Let it run for a while until it runs out of memory, then it will generate a 1GB file in the location where Spigot (server) jar is located. Zip that file and upload it somewhere.
If you cant/dont want to send it, you can analyze it yourself using the jhat binary that comes with the Java 8 installation. It requires a deep understanding of Java to interpret it though.

Ok the file has over 3 GB (compressed for transfer to 600MB). You can download here: https://www.dropbox.com/s/ol9br8iakpzyvxy/TRAIN.tar.gz?dl=0

Has the file helped to find the problem?
I think you were right about those chunks when I don't use keepchunks so it does not happen.

I mean, if you place a redstone lamp at the location of the sign, whether the lamp is powered will show whether the sign receives power and thus whether it will activate or not.

Lol wrong issue

I've had to fix many things since then so I haven't had real time to properly inspect it (I did download your coredump, so you don't have to keep it available in dropbox).
If keep chunks loaded = true exacerbates the problem, then the likely problem is that chunks don't unload properly when trains go by them. I wonder if one of those 'lag fixer' plugins that routinely unload chunks without players nearby can help you here. It won't harm the keep-chunks-loaded logic, since TC will cancel the chunk unload when a train is nearby them anyway.

Is this issue still affecting you?


What the mean of"Model_rtm3d_epoch_120.pth" and"Utils_rtm3d_epoch_120.pth"?

Hello,I tarined the network successully, and the "Model_rtm3d_epoch_120.pth" and"Utils_rtm3d_epoch_120.pth" appear in "RTM3D/checkpoints/rtm3d"，What do they represent?

hi @hhcNUAA
The weights of RTM3D model are saved in Model_rtm3d_epoch_120.pth file, while the state dicts of optimizer and lr_scheduler are in Utils_rtm3d_epoch_120.pth file. Usually we save all state dicts in a file, but I'd like to separate them, it's just my style 👍


Spanner

https://cloud.google.com/spanner

already included in the wishlist :) https://www.notion.so/kestra-io/Plugin-Backlog-71573110f3ee4890afc99095aa19e7d1?pvs=4


fix for MaskedConstant errors

iris.util.new_axis cannot handle masked constants, so this is a check to turn masked constants into scalar masked arrays, at which point they can be handled correctly.
This fix is checked by a test in PR#2130: https://github.com/SciTools/iris/pull/2130

I'm not happy about these tests failing.  They pass for me, as long as I remove the function 'tests.get_data_path(...)' and use the absolute path instead.
However, now that I know that there are tests for util.new_axis that live here, I will add my tests to these files in this PR and close PR#2130.

@marqh

@ajdawson I don't think I can do this check without touching the data at all ever, but I can touch the data only if the cube is scalar, which is what I have tried to do here.

Can I just rewind this a little. I'd like to understand the actual problem here, and the use case this change is catering for. Would you mind providing a bit more description of this?

@marqh @ajdawson I'm a bit stuck now.  Can't find the problem (tests pass on my own machine) and I don't know how to fix it.

I think your current approach is incorrect, producing a masked array before the reshape won't fix this. I have an alternative implementation that passes existing tests + your new test, but I'd really like to get some more info about the actual problem first (see previous comment).

I'll get the ball rolling with more detail about my concerns:
What you are trying to do is convert a MaskedConstant to a MaskedArray to avoid having the mask a different shape from the data. However, I'm concerned that this is the result of confusion between MaskedArray and MaskedConstant and not the real issue.
A MaskedConstant can have arbitrary dimension, but is always masked, and therefore does not need more than a scalar mask. When you add singleton dimensions to a MaskedConstant via sub-scripting with None (or np.newaxis) this changes the number of dimensions of the array, but not the mask, which makes sense since it is still a MaskedConstant and not a MaskedArray.
I'd like to know more about the problems caused down the line by having a non-scalar MaskedConstant inside a Cube (i.e. what motivated this PR?), so I can understand why (or why not) changing the behaviour of new_axis is the right thing to do.

@ajdawson I received a support request from someone highlighting that new_axis doesn't add a new axis to the mask along with the single-point array.  In the examples he sent me, he was trying to add dimensions to the array and then transpose it.  He pointed out that if he wanted to take a single point out of an existing cube, then add dimensions and transpose it, it didn't work because it was a Masked Constant.
I am in hospital at the moment, so I'm afraid I can't access the example file that he sent me or even get any more information from him about his purposes, but I can do that on Monday if you like.

OK, thanks for the extra information, I can now reproduce the case you are talking about. I'd like to think about it some more, but it seems like your approach is the right option in this case. I think all we need to do is tidy up a few details. We can revisit next week or whenever you are ready.

@ajdawson Hi AJ, I am back at work now and eager to move forward with this issue.  What are your thoughts?

@ajdawson Does the lazy data test look OK to you?

I think the test is OK, but it fails: https://travis-ci.org/SciTools/iris/jobs/161862951#L5040
We need to determine what to do for lazy arrays.

Actually I think that might be my fault.  I didn't check the dimensions of the lazy array before indexing into it to get a single point.  Let me try again.

@ajdawson OK, this has made me a bit confused.  So the test is failing because the lazy array doesn't have a mask on it, so when I try and check the dimensions of the mask it doesn't know what to check.  So I can add a mask to the array, but will it then still be lazy?
Also, what happens if the single-point array we are passing to new_axis is both lazy and a Masked Constant?  Is that a thing? If it is, then it will bypass the fix, right?

what happens if the single-point array we are passing to new_axis is both lazy and a Masked Constant? Is that a thing?

Yes, I think that can happen.
I feel like this should really be fixed in biggus, and it might not be possible to make a fix in Iris anyway. It seems to me that there's no way to know whether realising the data would result in a MaskedConstant without actually realising it, so there's no way to know when to apply the fix.
I think biggus should be fixed so that src_cube.lazy_data()[None] doesn't cause problems for masked data.

@djkirkham You might be right.

OK, if this is out of our direct control for deferred data I am happy for this fix to only apply to loaded data (i.e. as it currently is), with the condition that an issue is opened on biggus, and is picked up again in iris when possible. You'll need to remove the test for lazy data since it fails, and then I think this can be accepted.

@ajdawson @djkirkham Either of you know why these tests are failing now?

It's because there is a new version of cf_units which is being picked up. See https://github.com/SciTools/iris/pull/2144

Actually, most of the errors are because the current version of cf_units has a bug. We're releasing a new version now which will fix all but one of the errors, and https://github.com/SciTools/iris/pull/2144 will fix the remaining one

Thanks Dan

@marqh Dan informs me that the tests for this PR should pass now that his own changes have been merged.  Could you please re-run the Travis CI tests here?  Thanks.

Did you forget to rebase (and thus pull in required changes)? Tests are still failing.

@ajdawson Yes I did.

@ajdawson OK, so I rebased onto upstream master, but actually Dan's fix was merged into v1.10.x so the tests are still failing.  Have spoken to Pete about it, who is waiting to speak to Mark about it, and then maybe somebody might speak to me about it again...

Err, OK! What usually needs to happen is a merge of the v1.10.x branch into master to pickup bug-fix changes from there. Once that is done you can rebase this onto upstream/master. IWhen you can eventually do this, you may as well squash these commits into a single commit while you are at it.

@marqh

@ajdawson Are you happy to merge?

Yep! Thanks @corinnebosley

@ajdawson Thank you!


[RFC] Chapter 2: Rewrite Spoofax section

This rewrites the Spoofax section according to the feedback given by Hendrik, and according to the decision of removing the unused parts of this section (static semantics and term rewriting).
The feedback that was processed is to provide a diagram for the execution model and the relation with the aspects of a language. See also #53.

Very nice :smile:

LGTM!


Add Concat, Union, Except and Intersect

https://github.com/zzzprojects/System.Linq.Dynamic.Core/issues/499


disassemble confilict

for example the (fnmsub.s f18, f19, f20, f21, dyn) instruction and (fnmsub.s x18, x19, x20, x21, dyn) instruction has the same
encoding, so, how does the disassembler disassemble these two instruction

Allocate one bit for zfinx on e_flags should be fine, or ELF attribute is another option, but it's optional section, so I guess e_flags would be more appropriate.
https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md#-file-header

Thanks, Kito. I have a question that if zfinx is enabled, are there float registers?

If zfinx is enabled there are no float registers.
I agree there should be something in the ELF header, I'll check with Jiawei on the mailing list.

the newly formed psABI group will resolve this issue

closed via https://github.com/riscv/riscv-elf-psabi-doc/issues/166


Issue running apache superset with https

A clear and concise description of what the bug is.
Hi Everyone,
I am trying to configure SSL for superset on apache. However, my setup doesn't work. I am running superset locally on port 9020, but since I can't bind apache on the same port I have configured SSL for the UI on port 8080 with a proxy pass that forwards requests locally to port 9020.
Currently, any requests to mysuperset:9020 fail with the 404 error: The plain HTTP request was sent to HTTPS port, but after a few attempts of forcing https it finally redirects to the superset login page.
Expected results
mysuperset:9020 should redirect successfully to https
Actual results
HTTP error 404: The plain HTTP request was sent to HTTPS port
Screenshots

Environment
(please complete the following information):

superset version: 0.34
python version: 3.6
aws centos 7 ec2 instance
ELB configured

superset logs:
2020-01-31 07:01:46,187:INFO:werkzeug:<IP_ADDRESS> - - [31/Jan/2020 07:01:46] "GET / HTTP/1.1" 302 -
2020-01-31 07:01:48,897:INFO:werkzeug:<IP_ADDRESS> - - [31/Jan/2020 07:01:48] "GET /superset/welcome HTTP/1.1" 302 -
2020-01-31 07:01:58,855:INFO:werkzeug:<IP_ADDRESS> - - [31/Jan/2020 07:01:58] "GET / HTTP/1.1" 302 -

@pure-zests it might be better to bind Superset to <IP_ADDRESS> so that it's inaccessible from outside the local loopback. Then you can bind Apache to 80 and 443, and have Apache handle the redirect from HTTP -> HTTPS. If you need to handle the redrect from 9020, I'd recommend moving Superset to another port and again handling the redirect in Apache. I hope this helps!

This has been discussed numerous times in other issues and isn't really a Superset issue per-se, closing.

@mistercrunch, can you ping me the link for the issue where it is resolved, if you have it handy.


feat(lamp): add component formatter

Owner

[x] Nickname(Tuya): Sophia
[x] Intra-group review（组内审阅人员）：若叶

Description
component and formatter
Package
Please select the relevant package.

[x] tuya-panel-lamp-sdk

Type of change

[x] New feature (non-breaking change which adds functionality)

Self CheckList

[x] Intra-group review
[x] ESLint lint
[x] Example Run
[x] Jest Run
[x] No Grammer Error
[x] No Spell Error
[x] No Merge Conflict

LGTM

LGTM~


Global styles for angular libraries

Command
config
Description
Utilizing global styles in the Angular library packaged by ng-packgr at the moment is impossible or at least missing documentation.
It would be nice to have global styles as in normal angular applications so that developers won't need to import, e.g. bootstrap into each component separately.
Describe the solution you'd like
When specifying styleIncludePaths in ng-package.json, there should be an option that resolves and inlines css for each component globally.
Describe alternatives you've considered
Be able to create a global style file for the library.

You can use assets for this, which is covered in https://angular.io/guide/creating-libraries#managing-assets-in-a-library.
However, if you are using UI frameworks it is discouraged to import them directly and instead they should be explicitly imported in the application styles.css to avoid having duplicate CSS which may be the result of duplicate imports to same stylesheet. Example when both a library and the application depends on bootstrap.


ASSERTION FAILED Error while launch

Hello,
System Description
Camera Name and Model: Blackfly S BFS-PGE-23S3C
Operating System: Ubuntu 18.04
Spinnaker Version: spinnaker-<IP_ADDRESS>-Ubuntu18.04
ROS Version: Melodic
Computer details
Processor: Intel® Core™ i7-5820K CPU @ 3.30GHz × 12
RAM: 32 GB
For Ethernet cameras:
Currently connected with Ethernet interface directly to host machine
Do the cameras work with SpinView?
Yes, It does work well with Spin view
Describe the bug
Camera id replaced in the test_params file and tried to launch ROS package using
roslaunch spinnaker_sdk_camera_driver acquisition.launch, But getting error message like below.
Error Messages
SUMMARY
PARAMETERS

/acquisition_node/binning: 1
/acquisition_node/cam_aliases: ['cam0']
/acquisition_node/cam_ids: [18486426]
/acquisition_node/color: False
/acquisition_node/delay: 1.0
/acquisition_node/distortion_coeffs: [[-0.021141875266...
/acquisition_node/distortion_model: plumb_bob
/acquisition_node/exposure_time: 0
/acquisition_node/external_trigger: False
/acquisition_node/flip_horizontal: [False]
/acquisition_node/flip_vertical: [False]
/acquisition_node/frames: 3400
/acquisition_node/gain: 0
/acquisition_node/image_height: 1080
/acquisition_node/image_width: 1440
/acquisition_node/intrinsic_coeffs: [[1886.9232141485...
/acquisition_node/live: False
/acquisition_node/live_grid: False
/acquisition_node/master_cam: 18486426
/acquisition_node/max_rate_save: False
/acquisition_node/projection_coeffs: [[913.700317, 0.0...
/acquisition_node/rectification_coeffs: [[1.0, 0.0, 0.0, ...
/acquisition_node/region_of_interest/height: 0
/acquisition_node/region_of_interest/width: 0
/acquisition_node/region_of_interest/x_offset: 0
/acquisition_node/region_of_interest/y_offset: 0
/acquisition_node/save: False
/acquisition_node/save_path: ~
/acquisition_node/save_type: bmp
/acquisition_node/skip: 20
/acquisition_node/soft_framerate: 30
/acquisition_node/target_grey_value: 0
/acquisition_node/tf_prefix:
/acquisition_node/time: False
/acquisition_node/to_ros: True
/acquisition_node/utstamps: False
/rosdistro: melodic
/rosversion: 1.14.11

NODES
/
acquisition_node (nodelet/nodelet)
vision_nodelet_manager (nodelet/nodelet)
auto-starting new master
process[master]: started with pid [12692]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to 8161f1f0-d595-11eb-a330-3497f62ae04e
process[rosout-1]: started with pid [12703]
started core service [/rosout]
process[vision_nodelet_manager-2]: started with pid [12710]
process[acquisition_node-3]: started with pid [12711]
[ INFO] [1624612367.121071209]: Initializing nodelet with 12 worker threads.
[ INFO] [1624612367.235829001]: Initializing nodelet
[ INFO] [1624612367.236720468]: [ OK ] USB memory: 1000 MB
[ INFO] [1624612367.236773716]: *** PARAMETER SETTINGS ***
[ INFO] [1624612367.236788854]: ** Date = 20210625
[ INFO] [1624612367.237603734]:   Save path set via parameter to: /home/ajay
[ INFO] [1624612367.237640549]:   Camera IDs:
[ INFO] [1624612367.238216752]:     18486426
[ INFO] [1624612367.238789125]:   Camera Aliases:
[ INFO] [1624612367.238826657]:     18486426 >> cam0
[ INFO] [1624612367.239358292]:   External trigger: false
[ INFO] [1624612367.240385761]:   Unique time stamps for each camera: false
[ INFO] [1624612367.240908935]:   color set to: false
[ INFO] [1624612367.241461724]:   18486426 flip_horizontal 0
[ INFO] [1624612367.241977402]:   18486426 flip_vertical 0
[ INFO] [1624612367.242483890]:   Exporting images to ROS: true
[ INFO] [1624612367.242994113]:   Showing live images setting: false
[ INFO] [1624612367.243504674]:   Showing grid-style live images setting: false
[ INFO] [1624612367.244018402]:   Max Rate Save Mode: false
[ INFO] [1624612367.244266621]:   Displaying timing details: false
[ INFO] [1624612367.244524327]:   No. of images to skip set to: 20
[ INFO] [1624612367.244777578]:   Init sleep delays set to : 1.00 sec
[ INFO] [1624612367.245012727]:   'exposure_time'=0, Setting autoexposure
[ INFO] [1624612367.245242641]:   'gain' Parameter was zero or negative, using Auto gain based on target grey value
[ INFO] [1624612367.245478504]:   'target_grey_value'=0, Setting AutoExposureTargetGreyValueAuto to Continuous/ auto
[ INFO] [1624612367.245707548]:   Binning set to: 1
[ INFO] [1624612367.245937309]:   Using Software rate control, rate set to: 30
[ INFO] [1624612367.246164036]:   Saving images set to: 0
[ INFO] [1624612367.246843124]:   tf_prefix set to:
[ INFO] [1624612367.248076987]:   Region of Interest set to width: 0	height: 0	offset_x: 0 offset_y: 0
[ INFO] [1624612367.248414040]:   Camera Intrinsic Paramters:
[ INFO] [1624612367.248699774]:    1886.923214 0.000000 604.721488 0.000000 1886.666877 493.477267 0.000000 0.000000 1.000000
[ INFO] [1624612367.249024244]:   Camera Distortion Paramters:
[ INFO] [1624612367.249082624]:    -0.021142 -0.373387 2.385983 3.282457
[ INFO] [1624612367.249393087]:   Camera Rectification Paramters:
[ INFO] [1624612367.249456960]:    1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000
[ INFO] [1624612367.249763423]:   Camera Projection Paramters:
[ INFO] [1624612367.249820635]:    913.700317 0.000000 953.448302 0.000000 0.000000 1063.296631 777.871993 0.000000 0.000000 0.000000 1.000000 0.000000
[ INFO] [1624612367.249840551]:   Camera coeffs provided, camera info messges will be published.
[ INFO] [1624612367.249895965]: *** SYSTEM INFORMATION ***
[ INFO] [1624612367.249916695]: Creating system instance...
[ INFO] [1624612367.249931206]: spinnaker_sdk_camera_driver package version: 1.1.1
[ INFO] [1624612368.094326697]: Spinnaker library version: <IP_ADDRESS>
[ INFO] [1624612368.094399070]: Retreiving list of cameras...
[ INFO] [1624612368.099277513]: Numer of cameras found: 1
[ INFO] [1624612368.099341686]:  Cameras connected: 1
[ INFO] [1624612368.100866583]:   -18486426 Blackfly S BFS-PGE-23S3C 18<IP_ADDRESS>
[ INFO] [1624612368.146744431]: Dynamic Reconfigure: Level :<PHONE_NUMBER>
[ INFO] [1624612368.147779554]: *** FLUSH SEQUENCE ***
[ INFO] [1624612368.147822868]: Initializing cameras...
[ INFO] [1624612369.382937776]: Deinitializing cameras...
[ INFO] [1624612369.588629055]: All cameras deinitialized.
[ INFO] [1624612371.588816715]: Initializing cameras...
[ INFO] [1624612372.715657274]: onInit Initialized
[ INFO] [1624612372.715799753]: *** ACQUISITION ***
[FATAL] [1624612372.774290124]: ASSERTION FAILED
file = /home/ajay/spinnaker_ws/src/spinnaker_camera_driver/src/camera.cpp
line = 59
cond = frameID_ == 0
message =
[FATAL] [1624612372.774372952]: First frame ID was not zero! Might cause sync issues later...
[FATAL] [1624612372.774400020]:
[vision_nodelet_manager-2] process has died [pid 12710, exit code -5, cmd /opt/ros/melodic/lib/nodelet/nodelet manager __name:=vision_nodelet_manager __log:=/home/ajay/.ros/log/8161f1f0-d595-11eb-a330-3497f62ae04e/vision_nodelet_manager-2.log].
Screenshots

Regards,
Ajay

Pls fill all the info in the bug report template. You can try to comment that assertion line.

@vik748 Thanks for your quick response and here with filled the bug report as you mention.
Could you please help to fix this issue?
Thanks,
Ajay

If you see our readme, we have known compatibility issues with spinnaker versions after <IP_ADDRESS>. I'd suggest trying with that first. Also, you can try commenting the line that checks for the frame number at https://github.com/neufieldrobotics/spinnaker_sdk_camera_driver/blob/9c9633038c17d06f4ba11da9a97dddeb59c0d72a/src/camera.cpp#L59
Unfortunately, I don't have access to an ethernet camera so can't really test it out.

@vik748 Thank you for the suggestions!
Regarding compatibility issues with spinnaker versions as mentioned in the README file;
1. Known Issues

Where can I find the known fixes?
2. Previous releases
As mentioned in the README, Spinnaker <IP_ADDRESS> has been tested with Ubuntu18.04, So where can I find previous versions to download. Because in the official link https://www.flir.com/products/spinnaker-sdk/ I can only find the recent Spinnaker version.
Please share the download link to spinnaker version <IP_ADDRESS> for Ubuntu 18.04 (AMD64)
3. Line comment
I have tried commenting the line as you suggested
spinnaker_sdk_camera_driver/src/camera.cpp (Line 59)
ROS_ASSERT_MSG(frameID_ == 0 ,"First frame ID was not zero! Might cause sync issues later...");
But ROS node terminates with following error

4. Spinnaker View
Also, Spin View also not streaming any data, I can only see a blank screen in Spin View.

Sorry that I can't figure out the issues, looking for your kind assistance.
Regards,
Ajay

https://coe.northeastern.edu/fieldrobotics/spinnaker_sdk_archive/spinnaker-<IP_ADDRESS>-amd64-pkg.tar.gz
Before you use the ROS driver, you have to make sure that the camera works with SpinView. If you have any issues with that part, FLIR can help.

@vik748 Thank you.
Currently, i have a spinnaker version to <IP_ADDRESS>, and able to visualize data SpinView.
Also, After launch roslaunch spinnaker_sdk_camera_driver acquisition.launch, there is no error message.
But once i start rqt_image_view or rviz, Node terminates with an error message.
Changed Spinnaker Version:

Error Message:

Regards,
Ajay

@ajay1606 can you share the params.yaml file that you are using.

@vik748  here with sharing test_params.yaml file currently in use, intrinsic params in the file are default one.
cam_ids:
- 18486426
cam_aliases:
- cam0
master_cam: 18486426
skip: 20
delay: 1.0

# Assign all the follwing via launch file to prevent confusion and conflict

#save_path: ~/projects/data
#save_type: .bmp #binary or .tiff or .bmp
#binning: 1 # going from 2 to 1 requires cameras to be unplugged and replugged
#color: false
#frames: 50
#soft_framerate: 20 # this frame rate reflects to the software frame rate set using ros::rate
#exp: 997
#to_ros: true  #When to_ros is not selected, but live is selected, pressing 'space' exports single image to ROS

#Camera info message details
distortion_model: plumb_bob
image_height: 1080
image_width: 1440
distortion_coeffs:
- [-0.021141875266089592, -0.3733872931278025, 2.385982550579459, 3.2824571732099725]

#specified as [fx  0 cx 0 fy cy 0  0  1]
intrinsic_coeffs:
- [1886.9232141485886, 0.0,<PHONE_NUMBER>709341, 0.0, 1886.6668765711668,<PHONE_NUMBER>4719823, 0.0, 0.0, 1.0]

rectification_coeffs:
- [1.000000, 0.000000, 0.000000, 0.000000, 1.000000, 0.000000, 0.000000, 0.000000, 1.000000]

projection_coeffs:
- [913.700317, 0.000000, 953.448302, 0.000000, 0.000000, 1063.296631, 777.871993, 0.000000, 0.000000, 0.000000, 1.000000, 0.000000]

flip_horizontal:
- false

flip_vertical:
- false

region_of_interest:
  width: 0
  height: 0
  x_offset: 0
  y_offset: 0

Without a camera on hand I am not sure what could be going on. I suggest trying to reduce the bandwidth by using a low FPS, set binning to 2 to reduce resolution and using grayscale.

@vik748 I have tried with the following configuration settings in params.yaml file:
binning: 2 (before 1)
frames: 30 (# before 50)
#soft_framerate: 20
Streaming works well, until following messages appear
[ WARN] [1624845702.362489943]: Frames are being skipped!
[ WARN] [1624845759.880872530]: Image incomplete with image status 3!

Once these messages appeared, the ROS node terminates automatically with the following error:
[FATAL] [1624845761.896066994]: Spinnaker: Failed waiting for EventData on NEW_BUFFER_DATA event. [-1011]
 Likely reason is that slaves are not triggered. Check GPIO cables

[vision_nodelet_manager-1] process has died [pid 18563, exit code -11, cmd /opt/ros/melodic/lib/nodelet/nodelet manager __name:=vision_nodelet_manager __log:=/home/ajay/.ros/log/43a81cd4-d745-11eb-939b-3497f62ae04e/vision_nodelet_manager-1.log].

Frames is when you are saving the frames it will quit after the number of frames. The launch file overrides the settings in params.yaml. so set the binning, color and soft_fps in the launch file.
Yes you have the calibrate the cameras manually, this node just publishes those values.
I think your issues are related to the network settings / network load. You should check FLIR recommendations for network configuration.

@vik748 Thanks for your continuous assistance.
I have modified the changes in the Launch file and the camera working well without any interruption.

But this warning message keep accuring !
[ WARN] [1624931876.891512994]: Frames are being skipped!
[ WARN] [1624931878.749213756]: Image incomplete with image status 3!
[ WARN] [1624931878.791487400]: Frames are being skipped!
[ WARN] [1624931878.947170760]: Image incomplete with image status 3!
[ WARN] [1624931878.991406860]: Frames are being skipped!
[ WARN] [1624931903.231906282]: Image incomplete with image status 3!
[ WARN] [1624931903.270368710]: Frames are being skipped!

Previously, whenever this message occurs, the ROS node terminated automatically, but not this time.
So is this warning message need to fix or just ignore ?
And, if the issue associated with Network setting/ Network load, then it should appear similarly in the SpinView tool also right?
But it has no issues with the SpinView tool, But only with ROS node problem occuring.
Regards,
Ajay

This warning pops up when the camera buffer fills up and you don't extract the images in the time, so that the sequence number shows missing ones.  This is less likely to happen when using software triggering. Also if the buffer is full, you would see a lag in the images.
It seems that once in a while corrupted or incomplete images are coming through and that is why you probably see that warning. It is possible that SpinView just ignores bad images and doesn't show such messages. I still suspect this has something to do with some network configuration.

@vik748 Appreciate your suggestions and completely agree with you. I will communicate with the FLIR once regarding network configuration.

Hi, I have the same issue, could you tell me how to modify  the Launch file? Only change this nframes_ parameter?

@orange2xiaoyu As mentioned by @vik748 The launch file overrides the settings in params.yaml. so set the binning, color and soft_fps in the launch file.
launch/acquisition.launch

Just change above params.

@ajay1606  Thank you for your reply.
But when I modified the  binning, color and soft_fps in the launch file as your launch file, the same error still occurred.

@orange2xiaoyu Try commenting below the line in the source spinnaker_sdk_camera_driver/src/camera.cpp and try again.
ROS_ASSERT_MSG(frameID_ == 0 ,"First frame ID was not zero! Might cause sync issues later...");

@ajay1606 Thank you very much. I comment the line in the source spinnaker_sdk_camera_driver/src/camera.cpp and try again, but the same error still occurred.

@orange2xiaoyu In my case, ASSERTION failed error messaged caused to due to line 59, in the campera.cpp and commenting that resolved my issue. Please check your error message cause, or please share the error message once here.

Hi, this is still a very reproducible issue! I have the exact same setup described by @ajay1606 ; I can see my camera stream just fine in spinview but I experience the exact same symptom as in this comment, https://github.com/neufieldrobotics/spinnaker_sdk_camera_driver/issues/139#issuecomment-869169282, and setting binning, color, and soft_framerate does not solve my problem. @ajay1606 , I have no idea how you managed to dig yourself out of that hole!

@acarrillo I managed to overcome this issue as mentioned above. Please share the actual error message that appears in your camera. There could be another reason for that cause.


Fix: overflow issues on html, body with modals

This fixes bug which would have been created by #5647 while maintaining fix for original issue of modals not scrolling on mobile devices.

Thanks!


Github Community Standards and additional Issue Templates

Add contributors.md
Following Github Community Standards, adding contributors page, forked from ENVO for the time being. Need to update later.

closing per stale updated file


llm_validator with llama-cpp-python fails

Hi,
I use an example derived from your page: https://python.useinstructor.com/examples/self_critique/?h=before#adding-custom-validation , patched to work with llama-cpp-python.
I'm getting an error that function does not contain a key 'chat'.
I found out that I need to patch your validators.py file so that it does not refer to 'client.chat.completions.create' or 'client.moderations.create', but just to 'client' to work correctly with llama-cpp-python.
Full code of the patched example is here:
import llama_cpp
from llama_cpp.llama_speculative import LlamaPromptLookupDecoding

import instructor
from instructor import llm_validator

from pydantic import BaseModel, Field, BeforeValidator
from typing import List, Annotated
from rich.console import Console

llama = llama_cpp.Llama(
    model_path="/Users/flauros/Documents/CODING/models/Qwen2.5-7B-Instruct-Q4_K_M.gguf",
    n_gpu_layers=-1,
    n_ctx= 8 * 1024,
    f16_kv=True,
    offload_kqv=True,
    flash_attn=True,
    logits_all=True,
    chat_format="chatml",
    draft_model=LlamaPromptLookupDecoding(
                    num_pred_tokens=9,
                    max_ngram_size=3,
    ),
    verbose=True,
)

client = instructor.patch(
    create=llama.create_chat_completion_openai_v1,
    mode=instructor.Mode.JSON_SCHEMA, # Weak performance
    # mode=instructor.Mode.TOOLS, # Good
    # mode=instructor.Mode.FUNCTIONS, # Best

question = "What is the meaning of life?"
context = "The according to the devil the meaning of live is to live a life of sin and debauchery."

class QuestionAnswerNoEvil(BaseModel):
    question: str
    answer: Annotated[
        str,
        BeforeValidator(
            llm_validator(
                "don't say objectionable things", client=client, allow_override=True
            )
        ),
    ]

try:
    qa: QuestionAnswerNoEvil = (client(
        model="gpt-3.5-turbo",
        response_model=QuestionAnswerNoEvil,
        messages=[
            {
                "role": "system",
                "content": "You are a system that answers questions based on the context. answer exactly what the question asks using the context.",
            },
            {
                "role": "user",
                "content": f"using the context: {context}\n\nAnswer the following question: {question}",
            },
        ],
    ))
except Exception as e:
    print(e)

and the patched validators.py file is here:
from typing import Callable, Optional

from openai import OpenAI
from pydantic import Field

from instructor.function_calls import OpenAISchema
from instructor.client import Instructor

class Validator(OpenAISchema):
    """
    Validate if an attribute is correct and if not,
    return a new value with an error message
    """

    is_valid: bool = Field(
        default=True,
        description="Whether the attribute is valid based on the requirements",
    )
    reason: Optional[str] = Field(
        default=None,
        description="The error message if the attribute is not valid, otherwise None",
    )
    fixed_value: Optional[str] = Field(
        default=None,
        description="If the attribute is not valid, suggest a new value for the attribute",
    )

def llm_validator(
    statement: str,
    client: Instructor,
    allow_override: bool = False,
    model: str = "gpt-3.5-turbo",
    temperature: float = 0,
) -> Callable[[str], str]:
    """
    Create a validator that uses the LLM to validate an attribute

    ## Usage

    ```python
    from instructor import llm_validator
    from pydantic import BaseModel, Field, field_validator

    class User(BaseModel):
        name: str = Annotated[str, llm_validator("The name must be a full name all lowercase")
        age: int = Field(description="The age of the person")

    try:
        user = User(name="Jason Liu", age=20)
    except ValidationError as e:
        print(e)
    ```

    ```
    1 validation error for User
    name
        The name is valid but not all lowercase (type=value_error.llm_validator)
    ```

    Note that there, the error message is written by the LLM, and the error type is `value_error.llm_validator`.

    Parameters:
        statement (str): The statement to validate
        model (str): The LLM to use for validation (default: "gpt-3.5-turbo-0613")
        temperature (float): The temperature to use for the LLM (default: 0)
        openai_client (OpenAI): The OpenAI client to use (default: None)
    """

    def llm(v: str) -> str:
        # resp = client.chat.completions.create(
        resp = client(
            response_model=Validator,
            messages=[
                {
                    "role": "system",
                    "content": "You are a world class validation model. Capable to determine if the following value is valid for the statement, if it is not, explain why and suggest a new value.",
                },
                {
                    "role": "user",
                    "content": f"Does `{v}` follow the rules: {statement}",
                },
            ],
            model=model,
            temperature=temperature,
        )

        # If the response is  not valid, return the reason, this could be used in
        # the future to generate a better response, via reasking mechanism.
        assert resp.is_valid, resp.reason

        if allow_override and not resp.is_valid and resp.fixed_value is not None:
            # If the value is not valid, but we allow override, return the fixed value
            return resp.fixed_value
        return v

    return llm

def openai_moderation(client: OpenAI) -> Callable[[str], str]:
    """
    Validates a message using OpenAI moderation model.

    Should only be used for monitoring inputs and outputs of OpenAI APIs
    Other use cases are disallowed as per:
    https://platform.openai.com/docs/guides/moderation/overview

    Example:
    ```python
    from instructor import OpenAIModeration

    class Response(BaseModel):
        message: Annotated[str, AfterValidator(OpenAIModeration(openai_client=client))]

    Response(message="I hate you")
    ```

    ```
     ValidationError: 1 validation error for Response
     message
    Value error, `I hate you.` was flagged for ['harassment'] [type=value_error, input_value='I hate you.', input_type=str]
    ```

    client (OpenAI): The OpenAI client to use, must be sync (default: None)
    """

    def validate_message_with_openai_mod(v: str) -> str:
        # response = client.moderations.create(
        response = client(input=v)
        out = response.results[0]
        cats = out.categories.model_dump()
        if out.flagged:
            raise ValueError(
                f"`{v}` was flagged for {', '.join(cat for cat in cats if cats[cat])}"
            )

        return v

    return validate_message_with_openai_mod

I just don't want to interfere with your code, because I don't know how to distinguish when llama-cpp-python is used and when another backend is used.
Could you please check it and address it, if convenient?

Hey @mobeetle, in this specific case, the client here will be what you pass into the llm_validator. There's no other client used.
I'd suggest just using a separate validator though if you're worried in this case and you won't need to monkeypatch the llm_validator file itself.
from pydantic import BaseModel, field_validator, Field
from typing import Optional
from openai import OpenAI
import instructor

client = instructor.from_openai(OpenAI())

class Validator(BaseModel):
    """
    Validate if an attribute is correct and if not,
    return a new value with an error message
    """

    is_valid: bool = Field(
        default=True,
        description="Whether the attribute is valid based on the requirements",
    )
    reason: Optional[str] = Field(
        default=None,
        description="The error message if the attribute is not valid, otherwise None",
    )
    fixed_value: Optional[str] = Field(
        default=None,
        description="If the attribute is not valid, suggest a new value for the attribute",
    )

class QuestionAnswerNoEvil(BaseModel):
    question: str
    answer: str

    @field_validator("answer")
    def validate_answer(cls, v):
        print(f"validating answer of {v}")
        resp = client.chat.completions.create(
            model="gpt-4o-mini",
            response_model=Validator,
            messages=[
                {
                    "role": "system",
                    "content": f"Make sure that {v} doesn't contain objectionable things that go against any sort of spiritual or moral code.",
                },
            ],
        )

        assert resp.is_valid, f"Answer is not valid: {resp.reason}"

        return resp.fixed_value

question = "What is the meaning of life?"
context = "The meaning of life is to live a life of sin and debauchery and harm as many people as possible"

qa: QuestionAnswerNoEvil = client.chat.completions.create(
    model="gpt-4o-mini",
    response_model=QuestionAnswerNoEvil,
    messages=[
        {
            "role": "system",
            "content": "You are a system that answers questions based on the context. answer exactly what the question asks using the context. Do not change the context or hallucinate a response.",
        },
        {
            "role": "user",
            "content": f"using the context: {context}\n\nAnswer the following question: {question}",
        },
    ],
    max_retries=1,
)

# Error is thrown here
#> answer
  Assertion failed, Answer is not valid: This statement promotes harmful behavior and goes against moral and spiritual values. [type=assertion_error, input_value='The meaning of life is t...any people as possible.', input_type=str]
    For further information visit https://errors.pydantic.dev/2.9/v/assertion_error

Closing this due to inactivity, generally would recommend writing your own validator to have a bit more control over the output as shown above.


[T2A3][T10-A4]ZavierOng

Ready for review

inlining the code is one example of worsening the code quality. do look around for other examples.


Microsoft Edge component version showing wrong

The component "Zxcvbn Data Dictionaries" that is used by the Microsoft Edge browser shows as version zero, why is this when as of Feb17 2017 the component version has been 4.4.2. just wondering why this is happening and if its a bug on the Microsoft side or on yours, thanks. Also here is screen shot that shows this.

That is a question for Microsoft Edge.


warn on older sdks when using flutter

We should warn when the current SDK doesn't meet flutter's min. requirements (currently >= 1.13).

closing; the resolution is likely to allow the current stable sdk (1.12 right now)


Details about data preprocessing.

Hi, thanks for your excellent work.
In addition to the feature map, I want to take the RGB image as input of the network. However, the provided preprocessed data do not include the RGB image. I wonder if you could provide a preprocessed data that contain the RGB image.
Or could you please tell me how to preprocess the data? You mention in 'data.md' that "You may need to change details (ex. scale), so check comments in {dataset_name}_utils.py files.". So I worry about that I could not correctly preprocess the data if there is something wrong with the details.
Thank you very much!

Hi @linjing7
Are you trying to build a new network on top of TCMR?

Yes, I'm trying. If it works, I'll cite TCMR :)

Hi @linjing7,
OK, I will tell you how to preprocess data. I asked you because there's one thing you should know about the InstaVariety. It is preprocessed by VIBE's authors and the images are saved in tf-record. I don't know the details about extracting images from them but you could do it, though it will take some time.
Anyway, to preprocess other datasets by yourself, note two things: 'scale' and 'occ'

'scaleX' is added to my preprocessed file's name, when the scale is different from 1.3.
https://github.com/hongsukchoi/TCMR_RELEASE/blob/ade5ab5e2bd8b1a26338406c0b272d2a16f85070/lib/data_utils/mpii3d_utils.py#L327
According to the 'X' value, change the scale parameter of extract_features in each {dataset_name}_utils.py, .

If 'occ' is added to the file name, change the occ parameter of get_single_image_crop here.
https://github.com/hongsukchoi/TCMR_RELEASE/blob/ade5ab5e2bd8b1a26338406c0b272d2a16f85070/lib/data_utils/_feature_extractor.py#L79

Okay, thank you very much.


Setup dedicated Azure App Service and pipeline

This task will involve getting a new App Service setup by CCoE, setting up deployment pipelines, and having a reliable DNS entry for client and QA review. Also create documentation for how to deploy from GitHub to Azure.

To do list:

[ ] Request repo from WIG
[ ] Upload code and configure build artifacts
[ ] WIG creates dev URLs (https://environmental-maps.dev.ec.gc.ca/RAMP-Storylines/ and https://cartes-environnementales.dev.ec.gc.ca/Scenarios-de-PCAR/), app is working
[ ] WIG creates Azure DevOps pipeline for Dev
[ ] Add environment variables and configure token changes in RAMP configs
[ ] WIG creates Azure DevOps pipeline for QA and Production


Not able to run compiance test for rv32E device and RV32E ISA.

Hi,
Is there any support to run the compliance test for RV32E as we need it as part of our thesis. I could successfully do it with RV32i since I can see they are already build in riscv-test-suite  directory but along with rv32i I also need it for rv32E.

Hi,
Can you please clarify the last part of your comment where you are mentioning that "it would be relatively easy to constrain the generator to meet specific coverage goals." Is it possible to generate the tests or is there any Makefile where I can make changes and build the target rules for RV32E  because  I have already build the riscv-gnu toolchain with RV32E arch and abi=ilp32e and was successful in compiling the C source file.

@subhajit26

Can you please clarify the last part of your comment where you are mentioning that "it would be relatively easy to constrain the generator to meet specific coverage goals."

This is an assumption on my part, I think this is best answered by the architects of the generator @allenjbaum @neelgala

Is it possible to generate the tests or is there any Makefile where I can make changes and build the target rules for RV32E because I have already build the riscv-gnu toolchain with RV32E arch and abi=ilp32e and was successful in compiling the C source file.

I am not sure if the generator is publicly available (yet)
Also as I mentioned in my original email, the approach is Assembler based not C, in which case, having an RV32E C compiler does not help

@subhajit26 the test generator is indeed open source and available here: https://gitlab.com/incoresemi/riscv-compliance/riscv_ctg
As Lee mentioned it is indeed simple enough to declare new datasets and coverpoints using riscv_ctg for rv32e. You can simply re-use the samples/rv32i.cgf found in the repo and replace &all_regs with a dataset of x0-x15.
I haven't tried this out yet and will be some time before I do. If you do attempt this please let me know what you find. You could also raise an issue in the riscv_ctg repo for better traction.

I'm sorry to say that we don't have RV32E tests at this time.
In fact, the RV32E spec hasn't been ratified yet; it's still in draft form.
You should be able to modify existing tests to use only registers x0..x15,
but it will be the work of a day or two.
Note that the compliance TG is not responsible for the existing riscv-test
directory.
Those are older tests and are unsupported by us.
On Wed, Nov 18, 2020 at 2:09 AM subhajit26<EMAIL_ADDRESS>wrote:

Hi,
Is there any support to run the compliance test for RV32E as we need it as
part of our thesis. I could successfully do it with RV32i since I can see
they are already build in riscv-test-suite directory but along with rv32i I
also need it for rv32E.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-compliance/issues/142, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJTPESDORJ5LKWNGY43SQOMMBANCNFSM4TZYDSKQ
.

WE have enabled tests for RV32E, but not RV32EM or RV32EC
If that isn't working for you, please respond with what is broken.
IF this works, but you need RV32EM or RV32EC, then we may not get it in. Let me know either way.

I'm going to close this next week unless I hear back from someone with an RV32E implementation that say that the current test won't work or you need RV32EC or RC32EM.

PR#199 fixes this, though the spec remains unratified


Video circuit errors

Video is in colour (at last - just a dead lm1889 and 74ls123) but picture is very unstable

Significant colour bleed
Luma level high then low on alternating lines
Top of border image is too dark
Bottom of border image is light (as in main text area green light)
Text background appears to be alternating between colour sets (green and orange)
Vertical sync seems poor
Horizontal sync is poor at the top of the screen

Check voltage bias level between R33 and R34, should help to resolve border luma levels
Check output of IC23B (Q = 9, ~Q = 8) and frequency of ~VCLK on output of IC22C (8) and IC29A-Q3 (6) - should be CLK and CLK/16
Adjust RV1 and C7 for best output (compare with D64 repro)

Swapped R33 and R34 values - approximately same output as D64
Swapped C49 for resistor (6.8K) - output now comparable to D64 but final output is much worse
Output at this point seems to be a lack of clear HS and FS component in output. Pulses are being generated correctly (strength and frequency) so need to look at multiplexing and final combination of output in amp circuit

Error traced to shorted bodge wires on IC10


Signature Certificate on Azure

The idsrv4 sample cert worked fine on azure for me and I have generate my self-signed certificate by makecert.exe ,it works fine in local testing ,but on azure i got an 500 error.
Is that the cert problem or i missed some other configuration?

And what do the logs tell you?

It seems Azure's Error,
When my code as follow:
var cert = new X509Certificate2(Path.Combine(_environment.ApplicationBasePath, "MySignCA.pfx"),"password1234");
var builder = services.AddIdentityServer(options =>
{
options.SigningCertificate = cert;
});
the Azure server return 500 error.
But when i change the code as follow:
var cert = new X509Certificate2(Path.Combine(_environment.ApplicationBasePath, "MySignCA.pfx"),
"password1234",
X509KeyStorageFlags.MachineKeySet | X509KeyStorageFlags.PersistKeySet | X509KeyStorageFlags.Exportable);
        var builder = services.AddIdentityServer(options =>
        {
            options.SigningCertificate = cert;
        });

Azure works fine.
So,it my self-signed certificate's problem?

I'm using test cert, but it throws me error 500 on azure deployment with following error, even trying with sample copy.
Internal.Cryptography.CryptoThrowHelper+WindowsCryptographicException
The system cannot find the file specified
at Internal.Cryptography.Pal.CertificatePal.FromBlobOrFile(Byte[] rawData, string fileName, string password, X509KeyStorageFlags keyStorageFlags)
at System.Security.Cryptography.X509Certificates.X509Certificate..ctor(string fileName, string password, X509KeyStorageFlags keyStorageFlags)
at hello_2016_01.Startup.ConfigureServices

I was having the same issue. I didn't fully understand why Azure couldn't read the cert file, but I managed to get it working using Azure's Cert Store. Upload your signing certificate to your azure web app, and reference the generated thumbnail key from your code.
(Azure Portal > Web App > Settings > Custom Domains and SSL > Upload Certificate)
Here is how I load the certificate:
public X509Certificate2 LoadCertificate()
{
    if (_environment.IsDevelopment())
    {
        return new X509Certificate2(Path.Combine(_environment.ContentRootPath, "your.development.certificate.pfx"), "secret");
    }
    else
    {
        X509Store certStore = new X509Store(StoreName.My, StoreLocation.CurrentUser);
        certStore.Open(OpenFlags.ReadOnly);

        X509Certificate2Collection certCollection = certStore
            .Certificates
            .Find(X509FindType.FindByThumbprint,
            "XXXX-XXXX-XXXX-XXXX", // Generated by Azure
            false);

        if (certCollection.Count > 0)
        {
            X509Certificate2 cert = certCollection[0];

            return cert;
        }
        certStore.Dispose();

        return null;
    }
}

var builder = ...

var cert = LoadCertificate();
builder.SetSigningCredentials(cert);

Hope that helps.

Thanks. It works perfectly. =D
I guess I found the problem, it is due to the changes in RC2 directory whereby we must have  project.json with "publishOptions" to include the folder "UI" to allow view files and maybe we can have "Certificate" folder to include the signed cert?

No problem :)

@chrisvfabio Are you deploying IdentityServer4 as a windows-based image?  I am trying to deploy essentially the same code as you on top of the microsoft/aspnetcore docker image and it's giving me the error: System.PlatformNotSupportedException: Unix LocalMachine X509Store is limited to the Root and CertificateAuthority stores.

@chrisvfabio, thanks for the script - but I think you are accidentally not disposing certStore in case of  success (calling return before Dispose). Just put certStore into using:
using (X509Store certStore = new X509Store(StoreName.My, StoreLocation.CurrentUser))
{
// the rest of the code...
}
In addition, for those who may hit the same issue as I did - if you want to use it in the Azure Web Apps and you upload the certificate through portal you have to specify in the "Application settings" new setting
WEBSITE_LOAD_CERTIFICATES  (and the value is thumbprint of the certificate)
Details:
https://msftplayground.com/2016/11/using-certificates-azure-app-services/

@chrisvfabio where is SetSigningCredentials method from? I can’t find it anywhere. What is builder instance of?


Now that I can use Sprites with Pixi, get cross domain image loading errors.

Fixed the Pixi version library with #87, thank you!
Now that I can try using the WebGL renderer, I ran into a second issue.  When I'm not using WebGL, I can load images fine.  When I am trying to use WebGL, I get Image from origin 'the source site' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'my web site' is therefore not allowed access.
This means that WebGL is somehow more strict than whatever Matter.js uses normally?  If so, is there some way anyone has found to perhaps "proxy" the images by loading them with the method matter.js normally uses, then passing them to the WebGL renderer?
PS: this isn't a "running local vs running on a website issue", I've tried both with and without the one /*controller: Matter.RenderPixi,*/ line as the only difference, with everything on web servers, and it breaks with it and works without it.

Are your images on a different domain, or using http vs https?
As this isn't allowed when using webgl unless they have the Access-Control-Allow-Origin header set.
If they're on the same server and protocol, could you provide a jsfiddle?

Different domain.  And yes, after reading up on it, this issue isn't specific to matter-js.  Which is bizarre when upgrading to Pixi - it breaks, because WebGL has stronger cross-domain requirements (valid CORS headers) than plain matter-js.  And I can't get around it by rendering to a data URL via a canvas either because it is a "tainted" canvas.  Very unexpected overall.  Back to non-pixi rendering for me! :(

Thanks for confirming. Yeah, this is a well known browser restriction rather than anything in matter.js.
You should really just add the cors headers to your images if you own the server they live on.
Otherwise you'll just have to try put the images on the same domain.

@liabru I got this error on opera or firefox
It also catch error "No 'Access-Control-Allow-Origin' header is present on the requested resource."


Use Case 2 Correction

Issue in help/using/faq/faq-inbound-data-ingestion.md
Hi there,
For cross device data sources, the data is stored for a later time if the user did not login during the time the crm files are processed.  In use case 2, it indicates the opposite which is related to a cookie data source - can we confirm this and make the correction on the site?  It is confusing our clients and also worrying them.

Hi @chee-aam & thanks for opening this issue. Please ignore the automated message above, by adobe-bot.
I'll bring this case up with the product team, but first I wanted to ask if you had a suggestion of what the updated language should be for case 2.
Thanks & regards,
Victor
Senior Technical Writer, Audience Manager

Hi @chee-aam , just wanted to follow up on my question above.

Hi Victor,
Do you mind sending the link over?   My memory isn’t as well as it used to be 😉.
Thanks,
Katelyn
Katelyn Chee  |  Audience Manager Consultant  |  Adobe  |  c.<PHONE_NUMBER>  |  chee<EMAIL_ADDRESS>Please make note of my upcoming business travel, vacation, and Canadian holidays:
From: Victor Giurgiu<EMAIL_ADDRESS>Reply-To: "AdobeDocs/audience-manager.en"<EMAIL_ADDRESS>Date: Friday, November 22, 2019 at 10:56 AM
To: "AdobeDocs/audience-manager.en"<EMAIL_ADDRESS>Cc: Katelyn Chee<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [AdobeDocs/audience-manager.en] Use Case 2 Correction (#17)
Hi @chee-aamhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchee-aam&data=02|01|chee%40adobe.com|5cae5f35ce584582f5ad08d76f648e83|fa7b1b5a7b34438794aed2c178decee1|0|0|637100350027154535&sdata=Ud4a44KDbazHSymZyo8oY%2BgxU7j%2FIhKWHTTl8Ts7KFc%3D&reserved=0 , just wanted to follow up on my question above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAdobeDocs%2Faudience-manager.en%2Fissues%2F17%3Femail_source%3Dnotifications%26email_token%3DANNS76MW5KOENW2F36TNGI3QU76LLA5CNFSM4I7NYN3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6B2WQ%23issuecomment-557587802&data=02|01|chee%40adobe.com|5cae5f35ce584582f5ad08d76f648e83|fa7b1b5a7b34438794aed2c178decee1|0|0|637100350027164538&sdata=EM1nURUHYVHhdYjHlNT1jp%2BMjO1hFHVpBRjaY0L7%2BgM%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANNS76MOCHFS5D32MKXMUV3QU76LLANCNFSM4I7NYN3A&data=02|01|chee%40adobe.com|5cae5f35ce584582f5ad08d76f648e83|fa7b1b5a7b34438794aed2c178decee1|0|0|637100350027164538&sdata=R4d7j%2BhyEK3gud0zwr5KXpJJa9zpuInvg%2BX7dopDsgQ%3D&reserved=0.

Sure. You were enquiring about use case 2 in https://docs.adobe.com/help/en/audience-manager/user-guide/faqs/faq-inbound-data-ingestion.html

Thanks!  I believe Use Case 2 is directly associating this to a ‘cookie data source’ as opposed to a ‘cross device data source’.  My Client – Rogers – was concerned when the records are processed it would not store the record if there was no UUID associated to the CRMID, with cross device data sources, it will store the record.  The below statement I believe is for a cookie data source – if this could be indicated, I think it would avoid any confusion with our documentation versus what we’re telling the customers.
Audience Manager does not have a record of this visitor (or an associated visitor ID) so this record is not processed.
Thanks,
Katelyn
Katelyn Chee  |  Audience Manager Consultant  |  Adobe  |  c.<PHONE_NUMBER>  |  chee<EMAIL_ADDRESS>Please make note of my upcoming business travel, vacation, and Canadian holidays:
From: Victor Giurgiu<EMAIL_ADDRESS>Reply-To: "AdobeDocs/audience-manager.en"<EMAIL_ADDRESS>Date: Friday, November 22, 2019 at 12:44 PM
To: "AdobeDocs/audience-manager.en"<EMAIL_ADDRESS>Cc: Katelyn Chee<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [AdobeDocs/audience-manager.en] Use Case 2 Correction (#17)
Sure. You were enquiring about use case 2 in https://docs.adobe.com/help/en/audience-manager/user-guide/faqs/faq-inbound-data-ingestion.htmlhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.adobe.com%2Fhelp%2Fen%2Faudience-manager%2Fuser-guide%2Ffaqs%2Ffaq-inbound-data-ingestion.html&data=02|01|chee%40adobe.com|7393958871c84d7e1e9908d76f7390d9|fa7b1b5a7b34438794aed2c178decee1|0|0|637100414452834978&sdata=EUG3lwmmX1lDY8P6C4atvyMBtffbGHwrpUHSdVDzP%2Bo%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAdobeDocs%2Faudience-manager.en%2Fissues%2F17%3Femail_source%3Dnotifications%26email_token%3DANNS76IKGISVRFU232EJYZDQVAK6HA5CNFSM4I7NYN3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6LIRA%23issuecomment-557626436&data=02|01|chee%40adobe.com|7393958871c84d7e1e9908d76f7390d9|fa7b1b5a7b34438794aed2c178decee1|0|0|637100414452844935&sdata=WrElZgU3mlzhBo%2FHOjnl51gvmYClJY%2BXPnU694JdyXo%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANNS76JEE4K2YOSKSMJ2VC3QVAK6HANCNFSM4I7NYN3A&data=02|01|chee%40adobe.com|7393958871c84d7e1e9908d76f7390d9|fa7b1b5a7b34438794aed2c178decee1|0|0|637100414452844935&sdata=fX4y5ABmtpGsUjdWiwkovH53i9TXTWd1ly6SAbamous%3D&reserved=0.

Hi @chee-aam , I sent an email to you and Product to clarify this issue. Let's discuss there. Thanks!


discord: bump all versions

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 350948

x86_64-linux

:white_check_mark: 4 packages built:

discord
discord-canary
discord-development
discord-ptb

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 350948

x86_64-darwin

:white_check_mark: 4 packages built:

discord
discord-canary
discord-development
discord-ptb

aarch64-darwin

:white_check_mark: 4 packages built:

discord
discord-canary
discord-development
discord-ptb

Remember to squash merge or squash the commits


Add Paper info for Prepare Dataset

Tiis  is very outstanding work! I am very interested in the pre training dataset collected. So what are the references corresponding to this image?, How to find this paper?

Hi, many thanks for your attention to our work!
This table is from the extention paper of our work, which is still in preparation. And a 100k version is comming soon, we will release them as soon as possible.

Dear researchers, our work is now available at Large-Scale-Medical, if you are still interested in this topic. Thank you very much for your attention to our work, it does encourage me a lot!


Fix directive vs section

Codecov Report
All modified lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
see 12 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


fix typo

Fixes #353

Coverage increased (+0.003%) to 63.081% when pulling cd43ce1160d776b47dbf307b2b6994c336f4c03d on lnashier:fixtypo into 22586f4dba501db90494b2355f83a4f8c95c2263 on gorgonia:master.

Coverage increased (+0.003%) to 63.081% when pulling cd43ce1160d776b47dbf307b2b6994c336f4c03d on lnashier:fixtypo into 22586f4dba501db90494b2355f83a4f8c95c2263 on gorgonia:master.


docs: cleanup audioclip models readmes

Goals:

cleanup READMEs of AudioCLIP models

[x] Bumped version (in README of Executor)

PR feedback: @jina-ai/workstream-hub

@nan-wang Can you check again?


error G4127D1E8: The getter 'headline6' isn't defined for the class 'TextTheme'

it seems flutter has been updated and this package is not. and is causing errors in a big project i have used it

This is causing me an issue as well. Please update!

an update is in the works. thank you.

A new minor for the package has been rolled out. I hope this resolves your issue.


aci/actool: remove superfluous AddFile argument

At some point in the past, AddFile relied on the path to be explicitly passed
in, but now it simply uses the path that is set on the tar header it is
passed, so we can remove the argument now.

lgtm


help

everytime i start it it keeps making this weird noise!

??????????

??????????

it starts making this beeping noise

it starts making this beeping noise

can u make video what happened? I don't understand

can u make video what happened? I don't understand

i found out the issue too much cpu

i found out the issue too much cpu

i have another issue what are some good proxies for 1000

i have another issue what are some good proxies for 1000


feat(icons): added scan-qr-code icon

What is the purpose of this pull request?

[x] New Icon
[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description
New scan qr-code icon
Icon use case

for indicating a scanner feature of qr-codes
to differentiate from the qr-code icon that doesn't indicate scanning

Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[x] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[x] The icons are solely my own creation.
[ ] The icons were originally created in # by @
[ ] I've based them on the following Lucide icons:
[ ] I've based them on the following design:

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[x] I've made sure that the icons look sharp on low DPI displays.
[x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[x] I've made sure that the icons are visually centered.
[x] I've correctly optimized all icons to three points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

hiya @jguddas think i've approved everything.. do i need do anything else ?

@jguddas just nudging this :D


Added 2 more encryption techniques- TripleDES & Blowfish

Hey please check I have added 2 more techniques! @thelegendev

Yeah I also thought of having more stronger algorithms as options, ChaCha20-Poly1305 is cool and fast, sure I'll add them by tomorrow as another PR. For now you can merge these so I'll work on the masking feature on the updated repo

Sure, appreciate the efforts.
Also, happy Diwali man! 🎉

Happy Diwali to you too ! ❤


smooth preview crashes rendering

I think that's because of material id's missing.

Smooth preview crashes if use preview for rendering switch is off.

Fixed, per face shading did not read the subdivs correctly.


W (233198) BLE_MESH: Ran out of retransmit attempts - Unable to get composition data (IDFGH-12959)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
ESP-IDF v5.2.1
Espressif SoC revision.
ESP32 WROOM-32 v3.0
Operating System used.
Windows
How did you build your project?
Eclipse IDE
If you are using Windows, please specify command line type.
CMD
Development Kit.
ESP32-WROOM-32D
Power Supply used.
USB
What is the expected behavior?
When using ESP-BLE-MESH/on-off-server example in esp32-wroom-32d, the nRF mesh app should be able to get the Composition Data successfully
What is the actual behavior?

Steps to reproduce.

download and install espressif-IDE
import example project (onoff server model)
build and flash into esp32 wroom-32 kit
try to provision with the nRF mesh app
...

Debug Logs.
I (31) boot: ESP-IDF v5.2.1 2nd stage bootloader
I (31) boot: compile time May 31 2024 19:14:16
I (31) boot: Multicore bootloader
I (35) boot: chip revision: v3.0
I (39) boot.esp32: SPI Speed      : 40MHz
I (44) boot.esp32: SPI Mode       : DIO
I (48) boot.esp32: SPI Flash Size : 2MB
I (53) boot: Enabling RNG early entropy source...
I (58) boot: Partition Table:
I (62) boot: ## Label            Usage          Type ST Offset   Length
I (69) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (77) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (84) boot:  2 factory          factory app      00 00 00010000 00177000
I (92) boot: End of partition table
I (96) esp_image: segment 0: paddr=00010020 vaddr=3f400020 size=360e4h (221412) map
I (180) esp_image: segment 1: paddr=0004610c vaddr=3ffbdb60 size=05414h ( 21524) load
I (188) esp_image: segment 2: paddr=0004b528 vaddr=40080000 size=04af0h ( 19184) load
I (196) esp_image: segment 3: paddr=00050020 vaddr=400d0020 size=b4fd0h (741328) map
I (450) esp_image: segment 4: paddr=00104ff8 vaddr=40084af0 size=144d0h ( 83152) load
I (496) boot: Loaded app from partition at offset 0x10000
I (496) boot: Disabling RNG early entropy source...
I (508) cpu_start: Multicore app
I (516) cpu_start: Pro cpu start user code
I (516) cpu_start: cpu freq: 160000000 Hz
I (516) cpu_start: Application information:
I (519) cpu_start: Project name:     onoff_server
I (525) cpu_start: App version:      1
I (529) cpu_start: Compile time:     Jun  5 2024 17:32:35
I (535) cpu_start: ELF file SHA256:  5919cbf48...
I (541) cpu_start: ESP-IDF:          v5.2.1
I (546) cpu_start: Min chip rev:     v0.0
I (550) cpu_start: Max chip rev:     v3.99
I (555) cpu_start: Chip rev:         v3.0
I (560) heap_init: Initializing. RAM available for dynamic allocation:
I (567) heap_init: At 3FFAFF10 len 000000F0 (0 KiB): DRAM
I (573) heap_init: At 3FFB6388 len 00001C78 (7 KiB): DRAM
I (579) heap_init: At 3FFB9A20 len 00004108 (16 KiB): DRAM
I (585) heap_init: At 3FFCAD18 len 000152E8 (84 KiB): DRAM
I (591) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (598) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (604) heap_init: At 40098FC0 len 00007040 (28 KiB): IRAM
I (612) spi_flash: detected chip: generic
I (615) spi_flash: flash io: dio
W (619) spi_flash: Detected size(4096k) larger than the size in the binary image header(2048k). Using the size in the binary image header.
I (633) coexist: coex firmware version: 77cd7f8
I (638) main_task: Started on CPU0
I (648) main_task: Calling app_main()
I (648) EXAMPLE: Initializing...

Please use the latest idf 5.2 version, the problem has been fixed.

Thanks👍, it worked for me.


feat(esl-panel-group): add ability to specify the strategy of closing panels in case the max-open-items limit is reached

Closes: #1190

:tada: This PR is included in version 4.0.0-beta.18 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(k8s): improve helm chart

remove 'default' namespace
add common labels
Added Release.Name as Prefix to all resources.
get imagePullSecrets from values.yaml
get db connection string from values.yaml
generate and store webui user/password
Single kong distribution compatible with docker-compose
Vault cannot be installed automatically. So removed the dependency.
auto install postgresql
extraVolumes, extraVolumeMounts and extraEnvVars (useful when putting TLS as Environment Variable)
health check (livenessProbe)

remove 'default' namespace
add common labels
Added Release.Name as Prefix to all resources.
get imagePullSecrets from values.yaml
get db connection string from values.yaml
generate and store webui user/password
Single kong distribution compatible with docker-compose
Vault cannot be installed automatically. So removed the dependency.
auto install postgresql
extraVolumes, extraVolumeMounts and extraEnvVars (useful when putting TLS as Environment Variable)
health check (livenessProbe)

Hey @jclab-joseph
I like most of these changes. However there a few things that don't quite align with what we are trying to accomplish. We do have documentation for deploying to Kubernetes -- for example: https://open-amt-cloud-toolkit.github.io/docs/2.3/Tutorials/Scaling/Kubernetes/deployingk8s-aks/ . As part of the deployment, our scripts deploy a managed postgres instance into Azure. We intend to minimize the amount of state that is managed in a k8s cluster. We do not want a database as part of our k8s deployment and want to encourage the use of a managed database isntance.  That said, we do keep Vault as part of this deployment since we require a secret store. Removing that essentially breaks our toolkit -- we depend on that being there. We also have docs for unsealing and setting this up in our docs. In the future, the ideal scenario is that we integrate with the various cloud provider's secret store (such as Azure Key Vault, and AWS's equivalent offering). Lastly, we are following https://docs.konghq.com/kubernetes-ingress-controller/2.4.x/deployment/k4k8s/ for Kong deploying into Kubernetes. So we wish to keep that as is.
If you can put back the dependencies I think we can go from there.
Thank you for the time you've put into this!
-Mike

Closing this PR, we'll tackle these one by one from the backlog captured in this issue
https://github.com/open-amt-cloud-toolkit/open-amt-cloud-toolkit/issues/263


Tag categories?

We got tag macros and that is good enough. For now at least.


Update package.json

Without the "types" property, TypeScript can't auto-discover the types properly.

Simple, but nice one. This is also the recommended approach at the TypeScript Handbook.

@christopheranderson - sorry i totally missed this before!
I've removed "main" from the package.json as we don't really have an entry point. Will merge when green, thanks again!


Make installation easier for mac users

I think this is the kind of thing that's needed to make life easier for mac users...
https://github.com/anchore/quill

Here are some instructions to work around this issue for now: https://www.lifewire.com/fix-developer-cannot-be-verified-error-5183898
Eg: yesiscan_0.0.11_darwin_amd64” cannot be opened because the developer cannot be verified.


Would it be possible to support Pale Moon?

Pale Moon is a old fork of Firefox, it's been around for ages and it uses the old UI of Firefox. I belive it counts as version 25 of Firefox? Would it be possible to support Pale Moon?
The developer of PM released a old version of Pentadactyl that works. It works, but it would be great to not have a 1,5 year old version. :)

No, unfortunately someone would need to continue developing that old version separately.


Automatically create releases

When there are tags pushed to main then we want to have an automated release created in this repository.

Just to clarify, do you want to publish the project to a NPM or to a Github release?

Yes, @ANKerD a GitHub release. No NPM release for this.


Update docs link

Update docs link to new domain name, was causing https error for me today.

Thank you!


lu validation question

Describe the bug
Trying to update the how to use validation article. The behavior of lu validation differs as listed here:

Lu validation works perfectly in intent trigger creation.

Lu validation not working properly in User Input.
issues:

the red line should be under the error in line 5, but it shows in line 6.

only fixes in User Input works, fixes in inline editor does not work.

Lu validation does not work in lu inline editor.
issue:

error indicator with details is not show at the buttom of the inline editor
error is not synced to User Input
error is not saved

Hi Yan, see comments bellow

Describe the bug
Trying to update the how to use validation article. The behavior of lu validation differs as listed here:

Lu validation works perfectly in intent trigger creation.

Lu validation not working properly in User Input.
issues:

the red line should be under the error in line 5, but it shows in line 6.

It's a bug, will fix it soon.

only fixes in User Input works, fixes in inline editor does not work.

It's kind of known issue, it's because our current LU parser haven't implement parse/update/save lu file with error, if file haven't been saved, the notification page would also not update. At this moment if user go to another page then go back, would see the invalid content are dropped. because currently LU file doesn't have the ability to save with error.
it happens only in inline editor, in all up view edit file we save whole file, no need to call LU Parser to assembly a new lu file, so has or has not error would always been saved.
It's a temporary solution, we can fix it in future.

Lu validation does not work in lu inline editor.
issue:

error indicator with details is not show at the buttom of the inline editor

will fix soon

error is not synced to User Input
error is not saved

explained above, file with error have not been saved.

![lu-issue-in-validation](https://user-images.githubusercontent.com/32497439/76453975-0a27a700-6391-11ea-870b-53be9df4ac98.gif)

Addressed via #2272


Add tests

As it stands, this package has no tests. It will be an exercise in mocking jQuery, but I think it's doable.
I will try to help if I have time.

I'm a little ashamed of this. Would be very appreciative of any help here. Thanks @blimmer.

No shame. Will try to help as time permits.


add msgspec proj

Maybe add UnicodeDecodeError to the list of exceptions that we catch by ourselves in fuzz_*.py

You may use FuzzedDataProvider from Atheris to avoid UnicodeDecodeError exception
E.g., ConsumeUnicode()
https://github.com/google/atheris#fuzzeddataprovider

@koltiradw, I think PR is ready, isn't?


Added Firefox 61 and Opera 54 image information

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   78.48%   78.48%
=======================================
  Files           9        9
  Lines        1125     1125
=======================================
  Hits          883      883
  Misses        190      190
  Partials       52       52

Flag
Coverage Δ

#unittests
78.48% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c5537...a95b690. Read the comment docs.


update fallback jQuery version

oops, sorry missed this in the last PR.

The indentation changes made me blind to anything else.