Improve allocation of escape_into

In regex-syntax,
Make escape_into allocate at most twice (all characters are escaped)
instead of more if used on an unallocated String.  This way, escape
doesn't have to allocate.

Sorry for the second push, added syntax: to the commit title.

@hhirtz doesn't it still needs to be allocated later from escape_into since escape uses it, why should we allocate twice?

hi @pickfire, I don't really understand the first part of your question, but the patch here made escape_into performs less allocations on average.
For example, if you called escape_into with String::new, you'd likely end up doing more allocations than necessary, because String allocates on push when there's not enough space.  There's an example here: https://doc.rust-lang.org/std/string/struct.String.html#representation.
Since s = String::with_capacity(cap) is semantically the same as s = String::new(); s.reserve(s), I removed the with_capacity in escape.
Also escape_into(text, &mut buf) writes between text.len() (no character needs an escape) and text.len() * 2 (all characters are 1-byte codepoints, and they all need to be escaped*) characters in buf.  Here it reserves text.len() bytes in buf because we  know it needs at least text.len() more bytes in buf.
*Though I don't know any regex meta character that uses more than 1 byte in UTF-8.

@hhirtz Ah, thanks for the explaination, now I understand it. By the way, if we count first for exactly how many allocations we need, will allocating / reserving once be faster than potentially allocating multiple times?

Yes, because in most cases reallocation is performed by allocating a larger buffer and copying the previous one into it.  If you know how much you want to push, it's better to call reserve before.

will allocating / reserving once be faster than potentially allocating multiple times?

Generally, yes. This is generally referred to as "amortizing allocation" and it greatly influences the structure of a lot of performance critical code. The entire architecture of the regex crate is designed around doing just that. :-)


DEV 8543.3 In dashboard page, Hide the System nodes section in the UI if the admiralIP is localhost/<IP_ADDRESS> and runMode is dev. (can be tested by changing the run mode from dev to other run modes)

https://github.com/Shippable/pm/issues/8543

this is done, closing


Adding Hotkey for Cancel Task

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description
Hello!
I would like to suggest that the Tasks plugin include a hotkey for Toggle task Cancel, similar to the existing hotkey for Toggle task Done:

While I understand that there can be many customizable statuses, I believe that Cancelled is a particularly important one, especially since it is included in the "Date" setting:

And with this new hotkey, the cancel date could be auto added.
✔ Solution
Adding a new Hotkey for Toggle task Cancel
❓ Alternatives
No response
📝 Additional Context
No response

Hi, yes, I do agree that this would be useful.
We have an issue to track that already:

https://github.com/obsidian-tasks-group/obsidian-tasks/issues/1486

Feel free to subscribe to that, and upvote it with a 👍.

Hi, yes, I do agree that this would be useful.
We have an issue to track that already:

Add 'Set Status' commands [which will also allow users to set hotkeys for particular statuses] #1486

Feel free to subscribe to that, and upvote it with a 👍.

Oh sorry, I searched in issues before and missed this one! I'll close this! 🙏🏻


tour: The random number is always generating same the number!

Context: http://<IP_ADDRESS>:3999/basics/1
package main
import (
"fmt"
"math/rand"
)
func main() {
fmt.Println("My favorite number is ", rand.Intn(10))
}
Something is wrong with the randIntn(10)
Either it is with the import or with the package. I have work on both online and offline version and results are the same.

It's normal. It's written in the note in the same page:

Note: the environment in which these programs are executed is deterministic, so each time you run the example program rand.Intn will return the same number. (To see a different number, seed the number generator; see rand.Seed.)

But changing it so rand.Seed is throwing error!

tmp/sandbox907070895/main.go:9: rand.Seed(10) used as value

What am I doing wrong here?

I think this other issue answers your question.

@alebaffa I just did the tour online as well as local tour and the page that shows this code snippet does not show the text that you mention.  So for a newcomer, I almost thought something was wrong.  I had to dive into the math.rand package docs to see the notes you are talking about.

Maybe we should stop using rand as the first example, but it won't be easy. I elaborated on this in  #408. I'll close here as a dup.


HTTP probe rewrite for webhook part.

webhook requires json patch to inject the sidecar. istioctl kubeinject is doing client side modification directly. We refactor in app_probe.go to reuse.
The right order to handle an injection is

Extract the original app prober config, save it to the env var of the sidecar.
Update the apps own prober config, with the port pointing to the --statusPort.

The helm flag option is encoded in the template because SidecarInjectionSpec is the only available info passing around.

Pilot agent change to environment variable to avoid issue in the old proxy image.
An integration2 test skeleton (tests passing after hard code TODO in the test)

For #9150

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
05bbadfd851b3a5ad013e733d6eb5eacf5491b15
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
f60f18f4144482874c1219c7da90e97f19f1172f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold
Hold on until we resolve the cni test issues also need to address some comments @costinm had from https://github.com/istio/istio/pull/10344/files :(

I got some customers asking about the status of the feature.
Friendly ping, @hzxuzhonghu @mandarjog thanks!

Do you have to integrate this change to istioctl tool? I think you'll need to add smt to mesh.go, no?

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu, incfly, liamawhite
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
istioctl/OWNERS [liamawhite]
pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu correct. But we'll instead deprecate mesh.go,  and make istioctl kube-inject always refers to configmap sidecar injector template.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
b7e50563742af5ddddd1e8cd681d2e6f784523dd
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson, hzxuzhonghu, incfly, liamawhite
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [GregHanson]
istioctl/OWNERS [liamawhite]
pilot/OWNERS [GregHanson,hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio_auth_sds_e2e

prow/istio-unit-tests.sh
302530059658c2b21f39966886995b034a34d70e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio_auth_sds_e2e

prow/istio-unit-tests.sh
302530059658c2b21f39966886995b034a34d70e
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
302530059658c2b21f39966886995b034a34d70e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
bf1f7078de2e348eb823fd2e69bb30b595c93fab
link
/test istio_auth_sds_e2e

prow/istio-unit-tests.sh
302530059658c2b21f39966886995b034a34d70e
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
302530059658c2b21f39966886995b034a34d70e
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
302530059658c2b21f39966886995b034a34d70e
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[dashboard] Usage View

Chore
Task: Implement a sortable and filterable table in the Developer Dashboard's Usage View to display retirements.
The table should list all retirements associated with the logged-in account, allowing sorting and filtering by various keys (e.g., date, amount, type). This feature aims to enhance the user experience by providing a comprehensive overview of retirement activities.
Acceptance Criteria:

A table displaying retirement data is present in the Usage View.
Features to sort and filter the table by different keys are working smoothly.
The table design is consistent with the current dashboard aesthetics and responsive to different screen sizes.

Assigned to: @0xemc
Labels: dev, dashboard

Now in QA


OpenAPI spec adjustments

I noticed the following possible optimizations within the OpenAPI spec:

Missing property sunshine_10 for SynopRecord
If I understand the documentation correctly, the query params dwd_station_id, wmo_station_id and source_id could be described as arrays

Thanks @tobi-laa! This looks all reasonable, I'll probably merge it towards the beginning of next week :)

@jdemaeyer Thanks a lot for the review! :) I have adjusted the spec accordingly

Sure thing, thanks for pointing these out!


How can I show a pane variable in the status bar?

Hello, first of all, fantastic work!  I use your .tmux.conf on all my hosts and it's simply awesome.
Question: how can I show the output of docker-machine active for the current pane on the status bar, next to the hostname?  Or, alternatively, the variable $DOCKER_MACHINE_NAME?
Thanks!

+1 to this - I'd like to show the current git branch for the current pane in the status bar.

Hello @arturog 👋
There's no general way to achieve what you want.


Refactor setting of dynamic library path in test files.

Each Python test file contained duplicate code for detecting the OS X
platform and setting the dynamic library load path to include ../output.
This code has been moved into common.py as a function
set_library_path(config, platforms, path) where both platforms and path
have defaults.
The test files have been modified to use this function rather than
replicating code.

I wasn't happy with the repeated code...


What is 'GO:0017107 anion exchanger adaptor activity'?

This term has no annotation, no references, no children.
Definition: The binding activity of a molecule that brings together an anion exchanger and one or more other molecules, permitting them to function in a coordinated way. Source: GOC:mtg_MIT_16mar07
Does anyone know what it's supposed to represent ?
Thanks, Pascale

Dear all,
The proposal has been made to obsolete ‘GO:0017107 anion exchanger adaptor activity’. This term has no annotation, no references, no children.
The definition is "The binding activity of a molecule that brings together an anion exchanger and one or more other molecules, permitting them to function in a coordinated way.” Looking around in PubMed it seems to rather refer to interactions with the AP1 adaptor by which it is probably transported, see: PMID: 22744004; PMID:20833140. In this case, the adaptor does not specifically target an anion adaptor.
We are opening a comment period for this proposed obsoletion. Please comment on the ticket:
https://github.com/geneontology/go-ontology/issues/14616
We’d like to proceed and obsolete this term on Nov 30, 2017. Unless objections are received by Nov 30, 2017, we will assume that you agree to this change.
Thanks, Pascale


/etc/hosts not updated on disconnect

the network stack is updated but not /etc/hosts --- is this expected behavior?
 ubuntu@ip-172-31-36-118:~$ docker network disconnect isolated_nw container2
ubuntu@ip-172-31-36-118:~$ docker network disconnect bridge container2
ubuntu@ip-172-31-36-118:~$ docker attach container2

/ # cat /etc/hosts
<IP_ADDRESS><PHONE_NUMBER>ca
<IP_ADDRESS>	localhost
::1	localhost ip6-localhost ip6-loopback
fe00::0	ip6-localnet
ff00::0	ip6-mcastprefix
ff02::1	ip6-allnodes
ff02::2	ip6-allrouters
<IP_ADDRESS>	container1
<IP_ADDRESS>	container1.bridge
<IP_ADDRESS>	container3
<IP_ADDRESS>	container3.isolated_nw
/ # ubuntu@ip-172-31-36-118:~$ docker attach container2

/ # ifconfig
lo        Link encap:Local Loopback
          inet addr:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: ::1/128 Scope:Host
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

/ # cat /etc/hosts
<IP_ADDRESS><PHONE_NUMBER>ca
<IP_ADDRESS>	localhost
::1	localhost ip6-localhost ip6-loopback
fe00::0	ip6-localnet
ff00::0	ip6-mcastprefix
ff02::1	ip6-allnodes
ff02::2	ip6-allrouters
<IP_ADDRESS>	container1
<IP_ADDRESS>	container1.bridge
<IP_ADDRESS>	container3
<IP_ADDRESS>	container3.isolated_nw
/ # ping container1
PING container1 (<IP_ADDRESS>): 56 data bytes
ping: sendto: Network is unreachable
/ #

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I think we had the same problem with --link, which tripped up some users. Would be happy to see this resolved though :+1:

Similar issue for "rename"; https://github.com/docker/docker/issues/16485, and some older ones on entries for "removed" containers not being removed; https://github.com/docker/docker/issues/15811

this is resolved via https://github.com/docker/libnetwork/pull/709. will be available in docker/docker via next vendor-in.

Closed by https://github.com/docker/libnetwork/pull/709

@moxiegirl
Fix for this issue was ported to docker by #17381

@aboch thanks, I'll close this one


Do not overwrite empty DefaultBranch

Fix #21994.
And fix #19470.
While generating new repo from a template, it does something like "commit to git repo, re-fetch repo model from DB, and update default branch if it's empty".
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/modules/repository/generate.go#L241-L253
Unfortunately, when load repo from DB, the default branch will be set to setting.Repository.DefaultBranch if it's empty:
https://github.com/go-gitea/gitea/blob/19d5b2f922c2defde579a935fbedb680eb8fff18/models/repo/repo.go#L228-L233
I believe it's a very old temporary patch but has been kept for many years, see:  2d2d85bb
I know it's a risk to delete it, may lead to potential behavioral changes, but we cannot keep the outdated FIXME forever. On the other hand, an empty DefaultBranch does make sense: an empty repo doesn't have one conceptually (actually, Gitea will still set it to setting.Repository.DefaultBranch to make it safer).

I have a feeling that backporting may be a mistake - unless we really do go through EVERY use of defaultBranch and make sure it's not empty before using it.

Is it related to https://github.com/go-gitea/gitea/issues/19470 ? I haven't looked into details, just a guess.

Is it related to #19470 ? I haven't looked into details, just a guess.

Yes, it's the same as #21994.

I have a feeling that backporting may be a mistake - unless we really do go through EVERY use of defaultBranch and make sure it's not empty before using it.

I have another idea, just check if the DefaultBranch could be empty in DB, that would be easier, you know, the times of writing are much less than reading. I did some checking (maybe not enough) and haven't found anything wrong, the DefaultBranch always has a value even if it's an empty repo.

An alternative is to keep the afterload and just prestore the provided default branch at line 243 above before re-getting the repo from the db.

An alternative is to keep the afterload and just prestore the provided default branch at line 243 above before re-getting the repo from the db.

Of course we can fix it in another way, but why do we do extra work for the lagacy code? It is an opportunity to remove it. If it's not harmful we don't have remove it, however, why do we keep it when it's harmful?

@zeripath How about this: we don't packport it to v1.18, just merge it to main, so we'll have enough time to test it and eliminate potential risks.
If you agree, please feel free to remove the backport label.

I'm going to merge this and backport discussion can happen if needed.


[syntax/cpp.vim] Different scientific notation colornig between 'E' and 'e'

Steps to reproduce
#include <stdio.h>
int main()
{
	// Different Colorings bewteen 'E' and 'e'
	double d1 = 19.3E10;
	double d2 = 19.3e10;
	double d3 = 19E10;
	double d4 = 19e10;
	return 0;
}

'e' to '[eE]' in 'syntax/cpp.vim'

Expected behaviour
the same syntax coloring of 19.3E10 and 19.3e10
Version of Vim
8.2.5006
Environment
Windows 10 64bit
Logs and stack traces
No response

Could you create a PR here? https://github.com/vim-jp/vim-cpp

Ticket created at https://github.com/vim-jp/vim-cpp/issues/62 so let's close it here


Rename the repo to "fedimint"

I think we've agreed it would be best to just rename the repo "fedimint".
This change will be very disruptive to rebases. We should do any similarly disruptive changes like #258 at the same time (separate PRs, though).
IIRC @Kodylow had expressed interest in doing this.

will do this tonight, pr incoming

see PR #293


build collection from multiple locations; bug fix for queries; reformat _open_dataset

This PR includes the following.

renamed collections.py to manage_collections.py to avoid collision with collections python package.
refactored _build_cesm_collection method that relies on list of locations and supports POSIX and HPSS file listings.
bug fix in common.py that enable query args that are lists to be handled correctly.
refactor of _open_dataset method in core.py: this remains in preliminary status.

Ok...this is a mess. I removed the csv files in collections because they were getting too big, but did not appreciate the dependence of testing on these files being present... I have rearranged so that the test operate only on the "cesm_dple" collection, which is small.  Also moved the input files out of the package directory.

@andersy005 can you take a look at this please?  I am out of time.

@matt-long, Thank you for pulling this off!

Also moved the input files out of the package directory.

Because you moved the collection_dir out of the package directory, this directory would not be accessible when the user installs the package via pip install intake-cesm. As a result, we will need to make a couple of changes in config.py, common.py, core.py for the rest of the source code to work.

We can get rid of config.py since we were doing very minimal work in that module. As you can see we are return a dictionary in config.py.

Incore.py: we could just change the constructor of CesmMetadataStoreCatalog by adding an argument for an explicit path for the collection:

class CesmMetadataStoreCatalog(Catalog):
    name = "cesm_metadatastore"
    version = __version__

    def __init__(self, collection, **kwargs):
         self.collection = collection
         self.df = open_collection(collection)

to
class CesmMetadataStoreCatalog(Catalog):
    name = "cesm_metadatastore"
    version = __version__

    def __init__(self, collection, collection_path, **kwargs):
          self.collection = collection
          self.collection_path = collection_path
          self.df = open_collection(collection_path)

common.py:

We need to remove this line from .config import collections

Change open_collection() to

def open_collection(collection_path):
    """ Open a CESM collection and return a Pandas dataframe """
    try:

        df = pd.read_csv(collection_path, index_col=0)
        return df

    except (KeyError, FileNotFoundError) as err:
        print("****** The specified collection does not exit. ******")
        raise err

Change get_subset() to:

def get_subset(collection_path, query):
    """ Get a subset of collection entries that match a query """
    df = open_collection(collection_path)

Codecov Report

Merging #17 into master will increase coverage by 5.25%.
The diff coverage is 32%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   39.62%   44.87%   +5.25%
==========================================
  Files           5        5
  Lines         212      332     +120
==========================================
+ Hits           84      149      +65
- Misses        128      183      +55

Impacted Files
Coverage Δ

intake_cesm/__init__.py
100% <100%> (ø)
:arrow_up:

intake_cesm/manage_collections.py
16.14% <16.14%> (ø)

intake_cesm/core.py
66.66% <34.78%> (-10.48%)
:arrow_down:

intake_cesm/config.py
69.23% <68%> (-30.77%)
:arrow_down:

intake_cesm/common.py
85.71% <71.42%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e624904...f7ac3d9. Read the comment docs.

@matt-long, this looks good to me. Don't worry about the codecov patch check. I am going to go ahead and merge this.

Whew! Thanks!


Inference on own data

@KuilongCui
Thank you for your work.
Wonder if you are able to provide pretrained models to test it out?

Please refer to GETTING_STARTED.md

Here's a rough breakdown of the steps:

Download the pre-trained weights DukeMTMC-reID.pth and place it in the weights/ directory.
Put your dataset into the datasets/ directory.
Next, create a new class in fastreid/data/datasets to specify how to read your dataset.
Finally, adjust configs/MDPR/DukeMTMC.yml by changing the dataset setting to match your dataset.

I dont have a dataset like DukeMTMC. I would like to use this to identify people in my database while running my video processing workflow.

I think perhaps you could refer to the Introduction section of this paper on how to build a person re-identification system. I'm sorry, I also lack practical experience in relevant projects. In the issue section, I mainly address how to reproduce MDPR.

If you don't have other questions, I will close this issue.

@KuilongCui
Thank you for the paper recommendation. Seems like i am trying to do Open-World Re-ID. I would like to get the features extracted in your work to do cosine similarity/euclidean distance comparison Re-ID the person in my video.
Hence, since i only want to extract the features, is it correct to look into this?

Yes. You can try using the following command: CUDA_VISIBLE_DEVICES=1 python demo/demo.py --config-file configs/MDPR/DukeMTMC.yml --parallel --input ./test_input/*.jpg --output ./test_output --opts MODEL.WEIGHTS weights/DukeMTMC-reID.pth，Additionally, you may need to refer to train_net.py to add add_mdpr_cfg(cfg) in the setup_cfg function of demo.py.

thanks. i will try it out.


Failed to open code snippets editor. Open in default editor

Prompt when trying to edit extention's snippet.

Which extension's snippets failed to open by the code snippets editor?
The file extension name of extension's snippets is .json (not .code-snippets), so we need to click the button in sidebar to open it in the code snippets editor.

The snippets of vsocde-go seems has different format. I'll check it.
{
	".source.go": {
		"single import": {
			"prefix": "im",
			"body": "import \"${1:package}\"",
			"description": "Snippet for import statement"
		},
		// ...
	},
}

Closing this issue due to inactivity. Please feel free to reopen this issue if you are still running into issues and we would be happy to help troubleshoot further.


Fix deprecated-import false positives

Summary
Remove recommendations to replace typing_extensions.dataclass_transform and typing_extensions.SupportsIndex with their typing library counterparts.
Closes #5112.
Test Plan
Added extra checks to the test fixture.
cargo test

@AlexWaygood - Not too nit-picky at all -- on the contrary, I really appreciate them!


Update to hyper 0.13

I tried to convert examples/simple_response.rs to hyper 0.13 but got stuck at
type `ReqBody` is not a member of trait `hyper::service::Service`

Closing because we're archiving this repo.


parameterized the number of documentation documents to be retrieved

I am working with ChromaDB with many small documentation documents and need to increase the number of retrieved documentation documents from the vectorstore.
it would be useful to also be able to parameterize the number of documentation documents to be retrieved from the vectorstore
fixes #353

@GiacomoPracucci Can you add the "fixes #353" to the PR description. That way when this PR is merged, the issue will automatically be closed.

Thanks @GiacomoPracucci !
@andreped I made some changes here -- the parameters are n_results_sql, n_results_documentation, and n_results_sql which if not present, back up to n_results, and then default to 10.
This gives the user the option to granularly set the n_results for each type or to set them all at once or to omit them. WDYT?

@zainhoda LGTM :) Looking forward to testing this on Monday hopefully. Great job!


Button aways disabled if there is a command bind to it.

Describe the bug
I have a button, and a RelayCommand from Community Toolkit. The button is bind to the command. The button is aways disabled even the command is aways executable.
Moreoever, in the dev tool, the UI treeview shows that the button is disabled. But when you goto the list of properties, it is enabled. Changing the enabled property makes no change to its appearance in the applicaiton window.
To Reproduce
Steps to reproduce the behavior:

Create a new Avalonia C# Project. In the wizard, choose community toolkit.
In MainView.xaml, change the Content to

  <Button Content="Button" Command="{Binding Command}"/>

In MainViewModel.cs, add property

public RelayCommand Command = new RelayCommand(() => { });

Run the app

Expected behavior
The button should not be disabled.
Screenshots

As shown in the image, Command == null and IsEnabled == true
Envir

OS: Windows 11 Home 22H2
Avalonia-Version: 11.0.2

Additional context
None

Any property needs to have a getter at least. Otherwise XAML cannot find it.
public RelayCommand Command { get; } = new RelayCommand(() => { });

This is by design, so not a bug.


Use structpb.Value as internal storage of Property

Summary
There are several reasons to use structpb.Value over any:

NewValue contains pretty nice code that can e.g. serialize a []byte slice base64 encoded
Returning the value as any actually does checks, for example for over/underflow for numerical values and returns a NaN in that case
there is another draft PR that proposes to use structpb.Struct in the general entity protobuf message which would make the value easily usable should we need to

Related: #4171
Change Type

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
unit tests
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 53.724% (-0.04%) from 53.764%
when pulling b4b8befa9f78ed357b8dfa0ca2ef8557d0600067 on jhrozek:prop_proto_struct
into d32c80cf113157df7396f3b9f6854423cd47e4db on stacklok:main.


hereje/i763/refactor/migrate to esm/concerto types

Closes #763 => packages/concerto-types

Changes

convert project to ESM
update script and test files accordingly

Flags

Jest configuration on package.json

Screenshots or Video

Related Issues

Issue #
Pull Request #

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Extend the documentation, if necessary
[x] Merging to main from fork:hereje/i763/refactor/migrate-to-esm/concerto-types

Hi @hereje, as this is a breaking change, we need to target the v4 branch. Are you willing to rebase this on top of that branch, please?

@hereje can you rebase your changes on top of the latest v4.0.0 branch, please? I see that this PR has lots of unrelated changes now too


updated PDF scraping

Updated the pdf scraping to better match misspellings in the month as well as supporting multiple meetings on the same day by appending a letter code (b, c, d, etc) after the filename.

I'm not sure why this thinks there are merge conflicts when there aren't any. Unless I'm missing something (which is possible) there are no merge conflicts, and you just need to delete the extra bits (e.g., ">>>>>>>") to resolve this conflict. Addresses issue #34 when the scraping function is get_boe_minutes() instead of store_boe_pdfs(base_url, minutes_url).


Add ability to get auth tokens from GCP.

This is to enable the ability to connect to Cloudsql using IAM accounts

There is a problem.
To natively use CloudSQL, you have to use db/sql. Some orm does not support it.
Side note:
All Google Client Libraries uses ADC for loading credentials.
So, this does not serve any purpose, as far as I can see.

https://linear.app/flahmingo/issue/DEVOP-13/dig-deeper-into-permissions-on-the-database

https://linear.app/flahmingo/issue/DEVOP-38/secrets-library


Major Changes to Info and Sections

Verified and Validated Changes to be Pushed to GO LIVE (main branch).

EOD Changes - Merge Confirmed.


Check Apps up to date / dependabot for Rocket owned components

disabled dependabot for the following repos:

bridge-operator
kvm-operator
flannel-network-health
flannel-operator
k8s-endpoint-updater
k8s-kvm
k8s-kvm-health
mayu

also went through all the PRs for the above repos and cleaned them all up


netCDF4 missing in dependencies

netCDF4 is imported unconditionally in the forecast module but isn't included in setup.py.
https://github.com/pvlib/pvlib-python/blob/master/pvlib/forecast.py#L6
This breaks the documentation build: http://pvlib-python.readthedocs.io/en/latest/forecasts.html

See this comment regarding the documentation on readthedocs: https://github.com/pvlib/pvlib-python/pull/180#issuecomment-235935887 I'm sure it will work on rtd eventually.
I don't want to add netCDF4 to the required dependencies because only a fraction of pvlib users will need it and it's a non-trivial installation.


Match Que macro with que/lib/que/poller.rb

Fixes Que macro. Finished and expired jobs are not picked up by que poller and should be rejected from calculation.
Also reuse scopes available in que gem: https://github.com/que-rb/que/blob/master/lib/que/sequel/model.rb

Hi @defkode,
Looks good. My only concern is that this ties the macro to ActiveRecord which might not be available in certain environments (and thus, wouldn't be backwards compatible). Would it be possible to make this queryable without relying on ActiveRecord?

ActiveRecord interface was added in que https://rubygems.org/gems/que/versions/1.0.0.beta along with expired_at, finished_at fields.
So, the behaviour is different depending on which version is used...
Unfortunately Que 1.0.0 line is still in beta after more than 3 years - I think best way is to add separate matcher (lib/hirefire/macro/que_beta.rb) for QueBeta and comment both, so people are not confused anymore which matchers they should use in their own applications.

I meant that Que has a soft-dependency (optional) on ActiveRecord. If we use the ActiveRecord interface in the macro exclusively, then the issue is that people that were previously using the Que macro without Rails+ActiveRecord (i.e. Rails+Sequel or something) wouldn't have a working macro anymore.
I've created a draft PR (see #59) that addresses that issue by incorporating your addition, while maintaining backwards compatibility by defaulting to the plain SQL query of Que 0.x.
To try this out in your application, use:
gem "hirefire-resource", github: "hirefire/hirefire-resource", branch: "que-improvements"

Call the macro with the mapper option: HireFire::Macro::Que.queue("email", mapper: :active_record).
Please take a look and let me know what you think.

I left my comment https://github.com/hirefire/hirefire-resource/pull/59


Add support for UserEvent webhooks

Closes https://github.com/google/go-github/issues/1301.

Comments have been updated to reflect feedback. Thanks for the quick feedback, @gmlewis.

Thank you, @wesleimp !
Merging.


Deployment to Vercel

Hi, I just tried to push this to Vercel and it looks like it gives an error due to the package.json node engine.

Any thoughts on how to get this deployed on Vercel?
It seems to be erroring even before env's are set.
Thanks!

Looks like Vercel only supports Node.js 10 and 12, but not version 14. You can try to fork Ackee and change the engine in the package.json. Here's what Vercel recommends:
{
  "engines": {
    "node": "12.x"
  }
}

More: https://vercel.com/docs/runtimes
Let me know if this fixes the issue. Not sure if Ackee still works with Node.js 12.


Wrong Polygon representation in OData submissions API

Problem description
This issue is about the OData API and the submissions data document and the way it renders polygon data e.g. for the geoshape widget. It applies to ODK Central.
Data captured e.g. for the geoshape widget is mapped to the GeographyPolygon type in OData.
This is rendered similar to the example below. Note that the coordinates are rendered as an array of points.
"geoshape_widget": {
	"type": "Polygon",
	"coordinates": [
		[
			13.052775,
			58.252702,
			0
		],
		[
			13.057901,
			58.255344,
			0
		],
		[
			13.052073,
			58.253716,
			0
		],
		[
			13.052775,
			58.252702,
			0
		]
	]
}

Now according to the GeoJSON standard (RFC 7946), a polygon should be rendered as an array of linear rings:

Coordinates of a Polygon are an array of linear ring (see Section 3.1.6) coordinate arrays.  The first element in the array represents the exterior ring. Any subsequent elements represent interior rings (or holes).

RFC 7946: https://tools.ietf.org/html/rfc7946#appendix-A.3
Consequently, ODK should render polygons as an array of arrays of points, similar to this:
"geoshape_widget": {
	"type": "Polygon",
	"coordinates": [
		[
			[
				13.052775,
				58.252702,
				0
			],
			[
				13.057901,
				58.255344,
				0
			],
			[
				13.052073,
				58.253716,
				0
			],
			[
				13.052775,
				58.252702,
				0
			]
		]
	]
}

The current challenge with the deviation from the GeoJSON standard is that OData libraries break when encountering polygon data. In my case, I am using Apache Olingo to read the OData API for ODK, and it crashes with a NullpointerException when it attempts to parse points within polygons. Since I cannot control this code, it becomes a blocker in this case.
Steps to reproduce the problem

Create a project in ODK Central using the "all widgets" template.
Capture a polygon for the geoshape widget.
Retrieve submission data using e.g. https://trial.getodk.cloud/v1/projects/{project-id}/forms/all-widgets.svc/Submissions.
Observe coordinates of type Polygon.
Retrieve submission data in Apache Olingo in Java and observe a NullpointerException.

Just checking if there is hope for getting this one fixed? I am a bit concerned as it will crash OData client without offering a workaround.

hi! apologies. seems the nesting issue is a pretty quick fix so you'll see it in the next release for sure.
but also, odk collect does not produce correct polygon data for geospatial purposes, really. it doesn't respect the right winding direction and doesn't do some of the typical things to avoid edge cases, like dealing with self-overlaps. it really is just a pile of points in collection order. all that to say, it will probably still crash a lot of clients because it's technically degenerate data. i guess we could add post-processing in central but certainly clean data at the source would be better.
(/cc @lognaturel not sure if i've complained about this before)

not sure if i've complained about this before

You have! And it's on the radar otherwise as well. In practice, we've never had complaints about downstream tools having problems because of degenerate polygons. Data collectors always have a map in front of them when collecting traces and shapes and generally have specific instructions on how to do the collection. Agreed it would be nice to have a more standard way of representing composite geo data but that would require folks who can't do what they need with what is currently exposed speaking up.

it will probably still crash a lot of clients

This would only be if specific data points were degenerate in some way? My understanding is that many clients are still robust to the right hand rule not being followed which is the most likely violation, I believe.

A related nitpick with ODK Collect is the occasional whitespace in Geotraces/shapes (https://github.com/getodk/central-backend/issues/300). Easily fixed by a trim() without too much performance overhead, see my ticket.
If ODK Central ever were to add post-processing to geo data, I'd suggest #300 would be a good candidate to include.

Great, thanks for the responses! Yes I am mainly concerned about the potential crashes. I think the extra array will prevent that.
I'm not familiar with the geospatial capabilities of ODK and the need for additional improvements for correctness. I guess that might not be a priority as you indicate or go into separate, new issues.

[ ] Double check PowerBI once fixed (#294)

You were right, @issa-tseng, PowerBI is happy with this as well. 🎉


fix: Added font_size to legacy resource import

This is missing for the sequences so the large font sequence sample was not rendering correctly as the font_size was not being passed in.

Merging without review for demo today.


Create get_permitted_columns() and check_edit_values_permitted() functions

A number of our tables have columns and views where view and edit access varies depending on the user and their permissions.
Broadly speaking, we have STANDARD and ADMIN users, who have either EDIT or VIEW permissions for each column.
Currently, in code we determine who can do what through a number of arrays of varying permutations, which list columns that can or cannot be used. Our current means of organizing them is confusing:
DATA_SOURCES_OUTPUT_COLUMNS = DATA_SOURCES_APPROVED_COLUMNS + ARCHIVE_INFO_APPROVED_COLUMNS + ["agency_name"]
RESTRICTED_DATA_SOURCE_COLUMNS = [
    "rejection_note",
    "data_source_request",
    "approval_status",
    "airtable_uid",
    "airtable_source_last_modified",
]

Instead of creating more permutations of arrays, I propose that for each table and view, we have a tabular structure where:

The rows represent the columns:
The columns represent the columns' view/edit permissions for both STANDARD and ADMIN users.

While it takes more effort in the short-term than the array pattern, in the long term it will pose less cumbersome and scale more effectively.
This is partly a refactoring job, and partly about making the development of issues such as #390, which involve varying levels of visibility and permissions, more manageable. For the moment, I'll put aside refactoring existing code.
The other component, check_edit_values_permitted, will take a dictionary of key-value "edit pairs" (where the key represents the column and the value represents the new value) and checks to see that all values are allowable for editing. This is designed to catch and reject PUT requests that include edit values we do not allow that type of user to edit.
Implementation Steps

[ ] Develop the initial column_permission structure for #390
[ ] Develop get_permitted_columns to incorporate this
[ ] Develop applicable tests
[ ] Develop check_edit_values_permitted
[ ] Develop applicable tests
[ ] Create an issue to replace existing column-permissions with these.

Reference
https://docs.pdap.io/activities/data-dictionaries/hidden-properties

@josh-chamberlain One interesting wrinkle in all of this is how to design our endpoints when the view permissions between standard and non-standard (i.e. admin or otherwise elevated) users differ for a column.
For example, consider the following column as described in #390:

COLUMN
STANDARD
OWNER
ADMIN

archive_reason

VIEW
EDIT

The owner can view it, the admin can view and edit it, and the standard user can do neither.
Here's the issue as it relates to our current design of endpoints:

An endpoint with Basic authentication can be accessed by any user with their API key, and is intended for endpoints that don't require elevated permissions.
An endpoint with Bearer authentication requires a short-lived JWT, and is used to check to see if users have elevated permissions that enable them to access this endpoint.
Some columns are designed to be viewable only by users with certain permissions.
But for the GET methods of previous endpoints, such as /agencies, these are designed to be viewable by standard users, and require only basic auth.

So what should these other endpoints, where we're returning data from a table and where the viewable columns differ based on user, look like? There's a few options as I see it:

Have a Basic endpoint that can look up permissions.
Make the endpoint Bearer and look up permissions that way
Have separate endpoints for different view structures
Have the endpoint be both Bearer and Basic, where the authorization provided impacts whether it has standard permissions (Basic) or whether it should be evaluated for elevated permissions (Bearer).

I think 4 makes the most sense, but I wanted to present all options as I see them.

@maxachis ooh, this is a good point + I probably should have seen it coming! Yes, with # 4 you articulated it perfectly. I think the authorization provided goes through the permission checking machine, and impacts what happens (which fields you get back, what actions you can take). You could provide both bearer and basic auth, but if your account has no permissions, you don't get the good stuff.


CheckIn Delta changes without removing old CheckIn code

We follow below steps:

We unpack deploy full solution using SparkleXRM unpack.bat. We check in the unpacked solution components into local branch in Azure DevOps repository.
Then we create a patch on a solution. Patch contains single component (say a JS file) that was already there in original solution. Hence,  it is there in local branch also.
We unpack patch and check in the same JS into local branch.
We expect that it will update the original JS file in repository. Rather it deletes all the components checked in earlier and newly checks in the single JS file alone.

Query - Is there a way in SparkleXRM to unpack the patch and check in the delta changes without deleting existing components?

Hi @AdiCRM - thanks for the question and it's a very good one!
Microsoft don't recommend using solution patches in the way you describe for exactly the reason you give, making it hard to collaborate as a team.
"Using clone a patch and clone solution to update a solution isn't recommended because it limits team development and increases complexity when storing your solution in a source control system. For information about how to update a solution"
(from https://docs.microsoft.com/en-us/power-platform/alm/update-solutions-alm#create-solution-patches)
If you want to use patches to deploy an update, you can manage your full solution in source control, deploy to a build server and then export the patch from there - you would see all the changes in source control, but the patch would just be a vehicle for deployment.
Hope this helps!


Modern Sky Block 2 Modpack  <IP_ADDRESS>

Hi,
i dunno if this the right spot for my question but i have a problem in the pack. i demolished my whole base and placed all items into a refined storage system with a quantum disk. in the old base everything was available. now i moved to a new location and no items show up after setting up refined storage again. what can i do about that? the disk still shows 310k+ items but they are not shown in the grid.
thanks in advance

#1489


Shader cache compiling on game start

Hello, thanks for this amazing OS. ♥
I have this problem: when I launch a game on my Steam Deck, it compiles the shaders for like 20-25 minutes and If I skip the shader compilation, I get massive lags and game is unplayable.
I'm trying to understand if it's an issue with Steam/with GE-Proton/Bazzite/ or just some setting. And eventually what log to give you :)
Thanks

I believe there is a setting in Steam to always skip the pre-compile step (instead of doing it manually each time). But as you mentioned, you may experience stutters while in-game because the shaders are then compiling as you play.
It is an unfortunate reality of PC gaming. Even on my brand new gaming rig, I sometimes have to wait forever for shaders to compile (all the while fans are at full speed).
I did find this Reddit thread that indicates there could be a way to speed this up:
https://www.reddit.com/r/linux_gaming/comments/1270813/how_to_speed_up_linux_background_shader/
I have not tried this myself, but I intend to look into it. Launching Counter-Strike 2 takes so long, by the time its ready, I don't even feel like playing anymore 😆

It is an unfortunate reality of PC gaming. Even on my brand new gaming rig, I sometimes have to wait forever for shaders to compile (all the while fans are at full speed).

Well, mostly on linux and windows in some games only (first to cross my mind is Warzone/new COD games).

I did find this Reddit thread that indicates there could be a way to speed this up:
https://www.reddit.com/r/linux_gaming/comments/1270813/how_to_speed_up_linux_background_shader/

Mmh, I remember reading this option on my gaming pc, I should try to enable it on the deck (maybe in desktop mode if not available in gamescope) and see if it works.

Launching Counter-Strike 2 takes so long, by the time its ready, I don't even feel like playing anymore 😆

I really hope you're talking about your new gaming rig because you must hate yourself to play cs on the steam deck :D
By the way this behavior didn't occur on the official SteamOS, in there i've never read "Compiling shaders" before running a game, it downloaded a ton of shaders every day for any game in the library, but never compiled by itself. 🤔

This is normal steam behavior, you can skip this step thanks to GPL largely rendering this as uneeded.

On steam os it's not like this, sure I can skip it but runs poorly.
Il ven 27 ott 2023, 01:06 Kyle Gospodnetich @.***> ha
scritto:

This is normal steam behavior, you can skip this step thanks to GPL
largely rendering this as uneeded.
—
Reply to this email directly, view it on GitHub
https://github.com/ublue-os/bazzite/issues/472#issuecomment-1782029438,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC6MBTTM7IZWI6TB56GRJN3YBLUHNAVCNFSM6AAAAAA6RFZC7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGAZDSNBTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

This is normal steam behavior, you can skip this step thanks to GPL largely rendering this as uneeded.
We aren't using the same version of Mesa as SteamOS, so there aren't ready made caches provided by Steam. My understanding is that'll improve as we get more users due to how Steam's cache sharing system works.
Background shader compilation uses a lot of CPU. In the interest of battery life I would keep it off.

If I turn it on, how does it work?
Does it work in the background even when I'm playing some game already? Does it turn stop when launching a game?
And how often is it needed? Only once for every game?
I think I could pay the price of battery usage if this is only once for a game and let's me use my deck normally. Especially that it's really slow on bazzite. I get that it should take some time, but on bazzite it's super slow.
Also,
If it's possible - could you please explain why there's such a big difference? You said something about the way steam precache works. How does it work?

Shaders will be compiled in the background every single time a game is installed or an update is available. It will do this at all times. I certainly wouldn't recommend enabling this. It does take time if you wait it out, and that's the same for almost any system configuration out there unfortunately.
Steam OS downloads precompiled shaders, and they can do this since it targets one hardware configuration on one platform with a single version of mesa. So you never see this as a result of that. However, on all other Linux distros and hardware configurations, shaders have to be compiled before the game runs unless things match Steam OS exactly. But typically, you can skip this and still be fine. I haven't really noticed performance degradation in doing so

But typically, you can skip this and still be fine. I haven't really noticed performance degradation in doing so
@EyeCantCU
Hello, I didn't play on my steam deck much recently. Today I've tried to play some 3d games (everything works just fine with lightweight 2D scrollers) and it's absolutely unplayable. Then I thought about your reply, and I must be missing something huge. This time it didn't compile anything on start, looks like I have 3,5GB of shader cache but OW2 in this example runs at 5-12fps (on menu and same happens ingame).

Here is a video of how bad it looks:
https://imgur.com/GBtTxEm
is it normal?

try enabling background shader processing

It was enabled already and the other day I had steam open on desktop mode for 3 hours, what else should I check?


link to javadoc in readmy not working

In the readme, a link to javadoc is referenced, but when opening (https://docs.hcloud.siewert.io/) you get: There isn't a GitHub Pages site here.
Would be great to have a working link for browsing the javadoc online :)

Thanks for the heads-up! Please try https://tomsiewert.github.io/hetznercloud-java/
I'll change that in the readme

Issue fixed in #200
Thanks again!


Exchange declarations can now be declared with a config.

This allows you to declare the exchange as durable, autodeletable, internal...

Codecov Report

Merging #82 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   99.02%   99.04%   +0.01%
==========================================
  Files          12       12
  Lines         103      105       +2
==========================================
+ Hits          102      104       +2
  Misses          1        1

Impacted Files
Coverage Δ

...m/github/gvolpe/fs2rabbit/config/declaration.scala
100% <100%> (ø)
:arrow_up:

...ithub/gvolpe/fs2rabbit/interpreter/Fs2Rabbit.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c0a10...598d350. Read the comment docs.


this does not work on android kitkat and lollipop

i have a samsung s4 mini with android 4.4.2 and an samsung a3 with 5.0.1 and its not working

if you find out how to do it on your device, please create a PR for it, thanks


uint type not defined in OSX

In cclient/system.h line 19, type uint is not defined when compiling on OSX.
I suggest changing that to a more compatible type, such as uint32_t or uint64_t.

I think you meant cclient/service.h:19:3

Sorry, I meant service.h


Fix Muckrock filename collisions

Additional details
The Muckrock suite is working exactly as planned, except some agencies are sending multiple files with filenames like files.zip and images.png in the same FOI package, just under different branches of the "communication" key in the Muckrock JSON return. Our scraper code then will only make one of those available.
So a few tweaks of the API handling should get us there without too much of a lift:
import the pathlib module for better filename handling
Build an empty dictionary to identify duplicates
Go through the communication['files'] entries
If a filename native to the API does not exist, add it to the dictionary
For each filename in the tally, increase the count by 1
In the existing parser:     for communication in communications: should go with an enumerate to track how which sequential entry it belongs to.
Store that entry number within the CLEAN scraper properties.
If the filename appears in the duplicate dictionary with a count greater than 1, we need to append an identifier. For example, if entries 18 and 23 both had files.zip, the CLEAN filenames would become files_convo18.zip and files_convo23.zip using pathlib.
We also need some accountability here, as @tarakc02 has identified:

confirm that len(set(asset_urls)) == len(set(local_filenames))

This approach should minimize the filename changes but allow everything to get saved on our end.

^ yup i think that's right. within a datetime group, Path(asset_url.name) is 1-1 with asset_url.
we sometimes have the same file (same asset url) given more than once within the same datetime group, but we don't need to download it twice

Can you point me to an example of that repetition within a datetime group? That'd throw off my plans ...

^ If you check out the Sutter County DA request, the communication from May 30 2023 contains 1,906 file entries. But it only has 1,884 distinct asset urls (the 'ffile' for each of the files). https://cdn.muckrock.com/foia_files/2023/05/30/IMG_6497.JPG is an example of an asset that shows up multiple times, as is https://cdn.muckrock.com/foia_files/2023/05/30/9_16_19_PURSUIT__2_VIDEO_990C.mp4


Drop versions requirement for ECOSYSTEM ranges

This resolves a semantic issue: Not all ecosystems that recommend using SemVer 2.0 for versioning actually enforce that format on version numbers, but it may still be possible for the ecosystem to determine which versions are affected based on a range of SemVer-like versions. To address this, after speaking with @oliverchang, we are proposing dropping the validation of a versions requirement for ECOSYSTEM ranges, and changing the documentation to state that versions are strongly recommended for when using ECOSYSTEM ranges but not required. They are still required for GIT ranges.

The goal of the type here is to give readers enough information to be able to algorithmically answer the question "is the version I see in my code in the affected range?". Different ecosystems have different answers for this. We started simple with just SEMVER, GIT, and the wildcard ECOSYSTEM, but it would be OK to define a new type for each ecosystem, provided there is a well-defined algorithm for answering the "version in range?" question.
Loosening SEMVER doesn't help - what if two different ecosystems loosen semver in different ways?
Dropping the ECOSYSTEM enumeration requirement may be OK as long as package.ecosystem is a known ecosystem that all processors are expected to implement a "version in range?" for. But instead of having to define the ones where ECOSYSTEM can omit the version list, it makes more sense to me to just add more 'type' fields, each linked to a well-defined spec for version syntax and the meaning of < and <=.

The goal of the type here is to give readers enough information to be able to algorithmically answer the question "is the version I see in my code in the affected range?". Different ecosystems have different answers for this. We started simple with just SEMVER, GIT, and the wildcard ECOSYSTEM, but it would be OK to define a new type for each ecosystem, provided there is a well-defined algorithm for answering the "version in range?" question.
Loosening SEMVER doesn't help - what if two different ecosystems loosen semver in different ways?
Dropping the ECOSYSTEM enumeration requirement may be OK as long as package.ecosystem is a known ecosystem that all processors are expected to implement a "version in range?" for. But instead of having to define the ones where ECOSYSTEM can omit the version list, it makes more sense to me to just add more 'type' fields, each linked to a well-defined spec for version syntax and the meaning of < and <=.

I believe there will be a strong mapping from package.ecosystem to the version scheme denoted by ECOSYSTEM. Having to define each one separately (where the name is either the same or slightly different -- e.g. "PyPI" vs "PEP-440") seems unnecessarily cumbersome to me.
Tooling like https://osv.dev and https://github.com/nexB/univers will also make this easier to consume in general.

OK, dropping the enumeration requirement for 'ECOSYSTEM' sounds reasonable then. Thanks.
I agree with Oliver's clarifications to the text.

@oliverchang thanks for the change suggestions on wording in the docs. I've incorporated them as requested.


Dynamic folder route is not excluded

I.e. I have a route structure like this:
routes/greet/[name].tsx

It is excluded properly from XML file because it is a dynamic route.
I also have another dynamic routes, where a folder is a dynamic var:
routes/[locale]/about.tsx

This one is not excluded from XML.
Expecting such routes to be automatically excluded too, or they can be handled via options, where proper mapping to variables can be done.

Resolved here: https://github.com/scsmash3r/fresh-seo/blob/main/CHANGELOG


Installation instruction...

You forgot to mention that 2 keys must be added in info.plist to use your lib:
Photo :
Key    :  Privacy - Photo Library Usage Description
Value  :  $(PRODUCT_NAME) photo use
Camera :
Key    :  Privacy - Camera Usage Description
Value  :  $(PRODUCT_NAME) camera use
Otherwise app is crashing

@iSpartak Excellent! I add it now.


Use SQLite rename column instead of ddl helper

Since SQLite version 3.25.0 renaming columns is supported natively.
Knex depends on<EMAIL_ADDRESS>which bundles SQLite version 3.32.3, so this should be safe unless someone manually builds sqlite3 with an older version.

This is a very welcome change, thank you!

This is a very welcome change, thank you!


Use Java7 idiom

Sonar complained about the use of the workaround, which was suggested at SO for Java6. As we don't have the dependency on Java 6 anymore, get rid of it.
Additionally we should not swallow the exception, but just throw it.

@joerghoh thanks for the clean-up - could you resolve that conflict if you have a moment?

Doesn't seem necessary anymore.


Get LSP info

https://github.com/BitcoinAndLightningLayerSpecs/lsp/pull/22#discussion_r1169628545

Thinking out loud: Do we need an additional spec that lists all the nodes the LSP has? Maybe include a website, contact info, terms of service?
For example: I got a website field in LSPS1 that is not specific to LSPS1 but to all other specs as well.

This should include a fee schedule / rate table. Currently LSPS1 V2 only talks about how to actually purchase the channel, but includes no description of a workflow for querying an LSP to see what they have available.


[Fix][UI Next][V1.0.0-Alpha]Fixed an issue with time picker clearing

Purpose of the pull request
Please refer to the issue #8627.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #8655 (f3c22c4) into dev (7329285) will decrease coverage by 0.01%.
The diff coverage is 9.09%.

:exclamation: Current head f3c22c4 differs from pull request most recent head dd27f26. Consider uploading reports for the commit dd27f26 to get more accurate results

@@             Coverage Diff              @@
##                dev    #8655      +/-   ##
============================================
- Coverage     45.32%   45.31%   -0.02%
- Complexity     4071     4073       +2
============================================
  Files           699      700       +1
  Lines         27035    27046      +11
  Branches       2892     2894       +2
============================================
+ Hits          12254    12256       +2
- Misses        13628    13638      +10
+ Partials       1153     1152       -1

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/ApiApplicationServer.java
60.00% <ø> (ø)

...nscheduler/api/configuration/AppConfiguration.java
94.11% <ø> (ø)

...duler/api/interceptor/LoginHandlerInterceptor.java
82.60% <ø> (ø)

...hinscheduler/api/controller/DsErrorController.java
9.09% <9.09%> (ø)

...e/dolphinscheduler/remote/NettyRemotingClient.java
53.52% <0.00%> (+0.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7329285...dd27f26. Read the comment docs.


fix(iroh): handle rpc args in any position

It is now possible to do any of these
> iroh start --rpc-port 1234
> iroh --rpc-port 1234 start
> iroh console --rpc-port 1234
> iroh --rpc-port 1234 console

Closes #1639

Something doesn't sit right, netsim works with this though it doesn't pass in --rpc-port at start.


[support] M5stick-c doesn't seem to work

First of all, great kudos for such work, Mike!
I'm trying to make my m5stick-c, which is based on ESP32-PICO, and I'm getting no signal
I've merged your changes to the main branch of micropython and built it. Module inclusion, class instantiation works fine, but the wav file has only a header, and the signal is all zeroes.
I would appreciate if you or anyone could give me a hint where to look and troubleshoot. Thanks again!
Here's the latest iteration of the snippet (not that m5stick-c documentation doesn't provide any info on bck, and examples refer to I2S_PIN_NO_CHANGE
from machine import I2S
from machine import Pin

SAMPLE_BLOCK_SIZE = 4096
BITS_PER_SAMPLE = 16
BYTES_PER_SAMPLE = BITS_PER_SAMPLE // 8
SAMPLES_PER_SECOND = 16000
RECORD_TIME_IN_SECONDS = 8
DMA_LEN = 512

WAV_DATA_SIZE = RECORD_TIME_IN_SECONDS * SAMPLES_PER_SECOND * BYTES_PER_SAMPLE
wav_header = gen_wav_header(SAMPLES_PER_SECOND, BITS_PER_SAMPLE, 1, SAMPLES_PER_SECOND * RECORD_TIME_IN_SECONDS)

bck_pin = Pin(0)
ws_pin = Pin(0)
sdin_pin = Pin(34)

audio_in = I2S(I2S.NUM0, bck=bck_pin, ws=ws_pin, sdin=sdin_pin,
               standard=I2S.PHILIPS, mode=I2S.MASTER_RX,
               dataformat=I2S.B16,                                                         # Each sample will only take up 2bytes in DMA memory
               # NOTE: ONLY_RIGHT actually samples left channel.
               channelformat=I2S.ALL_RIGHT,                                               # Only sample single left channel (mono mic)
               samplerate=SAMPLES_PER_SECOND,
               dmacount=16,
               dmalen=DMA_LEN
               )

s = open('/mic_recording.wav', 'wb')
s.write(wav_header)

mic_samples = bytearray(SAMPLE_BLOCK_SIZE)

TOTAL_BYTES = RECORD_TIME_IN_SECONDS * SAMPLES_PER_SECOND * BYTES_PER_SAMPLE
bytes_written = 0

# Keep recording until enough samples are written
while bytes_written < TOTAL_BYTES:
    try:
        numread = 0
        numwrite = 0
        numread = audio_in.readinto(mic_samples, timeout=0)
        # If there were samples available in DMA, persist to flash
        if numread > 0:
            numwrite = s.write(mic_samples[:numread])
            bytes_written += numwrite
    except KeyboardInterrupt:
        break

s.close()
audio_in.deinit()

print('Done %d bytes written to flash' % bytes_written)

M5Stick-C specific Arduino Example One
M5Stick-C specific Arduino Example Two

It might just be a typo in the code listing but the bck and ws signals show that they are attached to the same pin 0.  Can you check that?

Hey, Mike, I've set it to 0, as there is simply no doc on which pin is this specific mic is attached, seems like there are only two pins documented (SCL/SDA), and two other pins are gnd and vcc:
Datasheet

I just took a look at the SPM1423 microphone datasheet.  It has a PDM interface and unfortunately will not work with the I2S micropython module only supports microphones having the 3-pin I2S interface.
This limitation is in the I2S micropython module implementation and not in the ESP32.  The ESP32 I2S hardware peripheral supports PDM hardware .   Take a look at section 12.4.7 I2S PDM in https://www.espressif.com/sites/default/files/documentation/esp32_technical_reference_manual_en.pdf.
The good news is that it is possible to modify the C code in machine_i2s.c to work with this microphone.  The M5stack C code can be used as an example on how to do this.
Also, here is some information from Adafruit that discusses the different types of digital microphones:
https://cdn-learn.adafruit.com/downloads/pdf/adafruit-pdm-microphone-breakout.pdf

Sigh I will have to look into that, then. My C is pretty basic, but I guess that would be a great chance to learn how to implement Arduino-based solutions as micropython modules :)
Thanks for checking, Mike!

Seems like this has been already implemented here  or am I mistaken?

That's a good find, but I don't know if it will help to get the PDM feature supported on the ESP32.  The CircuitPython PDM implementation is designed to run on the STM devices that are supported by CircuitPython.  Unfortunately, Adafruit doesn't support any Espressif devices in CircuitPython.
My suggestion is to implement a new machine PDM class in MicroPython, using machine I2S and the M5stack C code as examples.  Other PDM examples using the ESP-IDF might be found in the ESP32 forum or maybe an Arduino forum.  To keep consistency with other machine classes, the C file name would likely be called machine_pdm.c.
Here is how I would approach this:

copy machine_i2s.c to machine_pdm.c and integrate into the ESP32 build
rework machine_pdm.c to support PDM devices, using the M5stack C implementation as a guide

It might be worthwhile to post on the MicroPython ESP32 forum to see if anyone has started to work on this feature.

@AutomationD : did you wind up finding or developing something that connects to the M5StickC's microphone? I am hoping to do some work with it soon, as well, and am still struggling to find anywhere that it's used in python.

@valkyriesavage I broke my M5StickC :-D But yeah, it would be nice...


currency setting

how to set the currency in bdh?

Please look at the template for how to post a well structure question here. pdblp passes through parameters to blpapi which is officially supported by Bloomberg so looking at the help material for blpapi (or inquiring with HELP HELP in a terminal) is a good way to figure this out. A similar question for looking up parameters was asked on Stack Overflow so it's worth checking that answer out.


Add format-graphql extension

Description
Formats GraphQL with provided indentation
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed in the metadata folder

hey @tngranados, congrats on the extension 🎉
Mind adding an .eslintrc file? That's why CI is currently failing 😉

hey @tngranados, congrats on the extension 🎉
Mind adding an .eslintrc file? That's why CI is currently failing 😉

You are right, I missed those. Added now, thanks 👌

Thanks for letting me know @pernielsentikaer, I've updated the extension with error handling.

Hi @tngranados 👋
Thanks for the update. It works a lot better now 🔥


APT source whitelist request for ppa:beineri/opt-qt541 and ppa:beineri/opt-qt521

These are PPAs for Qt5.4 and Qt5.2 respectively.

:+1:

:+1: from me as well - this is preventing us from updating.

+1. Having other qt versions from this repo would also be nice.

Is there any way we can help make this happen?

In the meanwhile, the ppa:beineri/opt-qt541 has been replaced by ppa:beineri/opt-qt542, so this request is not correct anymore.
Not that anyone cared, anyway :disappointed:

If you need to test on qt5, you can run tests on trusty now: http://blog.travis-ci.com/2015-10-14-opening-up-ubuntu-trusty-beta/

@ctrlaltca :+1: that solved our failing CircleCI builds

+1. Having all qt versions from this repo would be great!


Fix volume while retriggering note

Command E9x forces a retrigger of a note at a certain tick interval,
but it should keep the existing volume and volume ramp. Instead, the
current code resets the volume every time.
Tested against XMPlay, OpenMPT and MilkyTracker.
Co-developed with @bryc who also prepared the test.

Here is an audio comparison:

retrigvol (second last) is before the fix. retrigvol-fix is after.
These all had ramping enabled. The fix is slightly different, which is due to some inconsistency with ramping (separate issue).
But without ramping, it is fine:

Thank you for the fix! Merged in 738ef25c7f06f6138c54f741116f7bbf809dcc28


Infinite typing

When you try to write a accent mark and press space bar that letter start to repeat without any way to stop it.

Can't reproduce the error, I'm sorry.


Improve twitter status links

I can link to https://twitter.com/i/web/status/{status}, which works.

Fixed in upcoming release


Rust Rls not showing any lints

Information
VIM version
NVIM v0.2.2
Build type: Release

Operating System: Arch Linux, urxvt
:ALEInfo
Current Filetype: rust
Available Linters: ['cargo', 'rls', 'rustc']
  Enabled Linters: ['rls']
 Linter Variables:

let g:ale_rust_rls_executable = 'rls'
let g:ale_rust_rls_toolchain = 'nightly'
 Global Variables:

let g:ale_cache_executable_check_failures = 0
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 100
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = 50
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {'rust': ['rls']}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = 10
let g:ale_list_vertical = 0
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = 0
let g:ale_open_list = 0
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

(started) ['/bin/zsh', '-c', '''rls'' +''nightly''']

What went wrong
Rls lints never show up at all in file. I remember they used to a long time ago. I tried reducing my config file down to the bare minimum for ale and rls to work, and it still never showed anything.
Removing my let g:ale_linters = {'rust': ['rls']} line and allowing cargo to be the linter works so I think this is specific to the rls setup.
Reproducing the bug
Steps for repeating the bug:

Use nvim and have rls installed
Enable rls for ale
Open an errored rust file  such as

fn main() {
    println!("Hello World")
}
}

No lints

It would be nice to automatically detect which options to use, if possible. You can also set g:ale_rust_rls_toolchain to 'stable' or an empty string to use the stable toolchain. The stable toolchain has only recently become widely used, so 'nightly' has been a good default value for a while. I might consider changing the default later.


Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits of both this extension and the webui

What happened?
When I try to get to the openpose editor by clicking "Edit", I saw the same window as before I downloaded openpose editor, nothing changed :

Steps to reproduce the problem

ControlNet v1.1.407 input an image
Control type -> Openpose
Run Preprocessor
Click "Edit"

What should have happened?
The normal interface of the openpose editor should come.
Commit where the problem happens
webui: v1.6.0 v1.5.2 v1.4.1
controlnet: v1.1.407
openpose-editor: 722bca6
What browsers do you use to access the UI ?
Microsoft Edge
Command Line Arguments
NO

Console logs
To create a public link, set `share=True` in `launch()`.
Startup time: 25.9s (launcher: 8.1s, import torch: 7.1s, import gradio: 0.9s, setup paths: 1.0s, other imports: 1.2s, list SD models: 0.2s, load scripts: 3.3s, create ui: 2.3s, gradio launch: 0.6s, add APIs: 0.3s, app_started_callback: 0.8s).
Loading VAE weights specified in settings: D:\D\ruanjian\AIDraw\novelai-webui-aki-v3\models\VAE\vae-ft-mse-840000-ema-pruned.ckpt
Applying attention optimization: xformers... done.
Model loaded in 9.9s (load weights from disk: 1.2s, create model: 1.3s, apply weights to model: 2.6s, apply half(): 1.3s, load VAE: 2.3s, move model to device: 1.0s).
2023-09-06 13:49:33,270 - ControlNet - INFO - Preview Resolution = 512

Browser logs
:7860/favicon.ico:1
Failed to load resource: the server responded with a status of 403 (Forbidden)
:7860/openpose_editor_index:1
Failed to load resource: the server responded with a status of 404 (Not Found)
Additional information
I'm not very familiar with computers and don't know what Browser logs are. Anyway, I hope I copied it correctly.

Same

please confirm that the dist directory exists. If not please follow instruction to download it manually. Users in China may have issue downloading dist automatically.

Closing for inactivity.


Render protected areas at a lower zoom.

#49 added rendering for protected areas.  However, this starts at zoom 6.  In the western United States these areas are very large and it would be appropriate to render these in generalized form as low as zoom 4 or 5.
This change requires an update to OpenMapTiles to make generalized protected area polygons available at a lower zoom.
Here is a current zoom 6 rendering of protected areas in the western United States:

Experimenting with a custom OpenMapTiles reveals that a no-label rendering is appropriate at zoom 4, with labels starting at zoom 5.
Idaho, zoom 5:

Idaho, zoom 4, no labels:

With the recent deployment of OMT 3.13 to Maptiler Cloud, this is resolved.


Upgrade React to 16.5.0.

Coverage remained the same at 51.048% when pulling 1bc624a5e0dfaa8a9c888267a064e528e5231d44 on react-16.5 into 362e4cb1e5854e6158b082b7ec2705ef47f96525 on master.


Add firefox support

Create firefox extension based on the original chrome extension.

@swapagarwal Maybe this can be merged too?

@j3soon Thanks for taking the time to work on this. I just installed it, and it works great based on my initial testing. 🎉
Quick Question: I see that you have published this here: https://addons.mozilla.org/en-US/firefox/addon/mediumship/, Just wanted to make sure if you'll be willing to support maintaining it (bugs / feature requests)?

Yes, it's my pleasure to maintain the firefox add on.

@swapagarwal However, for problems like issue #4 is not yet fixable.

Thanks @j3soon! 👍


feat: support path parameter & replace the value and description

Hi @joolfe ,
About #130 I implement this feature and compatible with # postman-to-openapi description.
If use # postman-to-openapi, the description have higher priority...
Thanks
Best regards

@Chia-Yu-hung  thanks for your support I definitely review and merge when ever I have time, sorry

@joolfe ok, thanks a lot.


Upgrade to bootstrap 3.3.4

Done! https://github.com/sethladd/bootstrap_for_pub/pull/14
also, uploaded to pub.dartlang.org


[Type Resolution] Only allow each applied directly to a type parameter pack.

The current implementation allows each T.Element in type position, but SE-0393 states that you can only write (each T).Element, because the parenthesis are always required in expression position and in the future, each T.Element could mean that Element is an associated type pack. This change requires that each be applied directly to a parameter pack in type resolution.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please build toolchain


Cannot use stream-based I/O to ConPTY/Console and receive WINDOWS_BUFFER_SIZE_EVENT simultaneously

Microsoft Windows [Version 10.0.18362.1]
To monitor console buffer resize events (and viewport resize events in more recent builds), ReadConsoleInput must be used to look for INPUT_BUFFER events with an event type of 4 ( WINDOW_BUFFER_SIZE_EVENT ).
My problem is that when I open a pseudoconsole session for a new cmd.exe process and I want to use bidirectional VT codes (stream based) for stdin/stdout for maximum cross platform portability. That is to say, I don't want to use the windows console APIs because they are windows specific. This seems to make it very difficult - without gag-inducing and complex task synchronization - to watch for resize events at the same time. When stdin/stdout are flushed, any INPUT_BUFFER records in ReadConsoleInput are too, including WINDOWS_BUFFER_SIZE_EVENT records.
VT allows capturing mouse movement - or at least it should in the future since ConPTY doesn't seem to forward mouse coords/actions yet, but there is no equivalent VT sequence for resizes of the viewport. Here's some demo/repro code:
My specific NuGet dependencies for the repro are:

Vanara.PInvoke.Kernel32   / 2.3.4
Pipelines.Sockets.Unofficial / 2.0.7

using System;
using System.IO;
using System.IO.Pipelines;
using System.Runtime.InteropServices;
using System.Threading;
using System.Threading.Tasks;

using Pipelines.Sockets.Unofficial;
using Vanara.PInvoke;

namespace resizetest
{
    internal class Program
    {
        private static async Task Main(string[] args)
        {
            // run for 30 seconds
            const int timeout = 30000;

            var source = new CancellationTokenSource(timeout); // 30 seconds
            var token = source.Token;
            var handle = Kernel32.GetStdHandle(Kernel32.StdHandleType.STD_INPUT_HANDLE);

            Kernel32.CONSOLE_MODE mode = default;

            if (!Kernel32.GetConsoleMode(handle, ref mode))
            {
                throw Marshal.GetExceptionForHR(Marshal.GetLastWin32Error());
            }

            mode |= Kernel32.CONSOLE_MODE.ENABLE_WINDOW_INPUT;
            mode |= Kernel32.CONSOLE_MODE.ENABLE_VIRTUAL_TERMINAL_INPUT;
            mode &= ~Kernel32.CONSOLE_MODE.ENABLE_MOUSE_INPUT;

            if (!Kernel32.SetConsoleMode(handle, mode))
            {
                throw Marshal.GetExceptionForHR(Marshal.GetLastWin32Error());
            }

            Task drainStdin = Task.Run(async () =>
            {
                // UNCOMMENT THESE LINES TO ENABLE CAPTURE OF RESIZE EVENTS
                //await Task.Delay(timeout, token);
                //return;

                Stream stdin = Console.OpenStandardInput();
                PipeReader reader = StreamConnection.GetReader(stdin);

                while (!token.IsCancellationRequested)
                {
                    var result = await reader.ReadAsync(token);
                    if (result.IsCanceled || result.IsCompleted)
                    {
                        break;
                    }

                    // do stuff...

                    Console.WriteLine("stdin: read {0} byte(s)", result.Buffer.Length);
                }
            }, token);

            Task readInputBuffer = Task.Run(async () =>
            {
                while (!token.IsCancellationRequested)
                {
                    await Task.Delay(10, token);

                    if (!Kernel32.GetNumberOfConsoleInputEvents(handle, out var count))
                    {
                        throw Marshal.GetExceptionForHR(Marshal.GetLastWin32Error());
                    }

                    if (count > 0)
                    {
                        var buffer = new Kernel32.INPUT_RECORD[count];

                        if (!Kernel32.ReadConsoleInput(handle, buffer, count, out var total)) {
                            throw Marshal.GetExceptionForHR(Marshal.GetLastWin32Error());
                        }

                        if (total > 0)
                        {
                            // TODO: de-bounce and only send last resize?
                            for (int index = 0; index < total; index++)
                            {
                                var record = buffer[index];

                                Console.WriteLine("type: {0}", record.EventType);

                                if (record.EventType == Kernel32.EVENT_TYPE.WINDOW_BUFFER_SIZE_EVENT) // resize
                                {
                                    var size = record.Event.WindowBufferSizeEvent.dwSize;
                                    Console.WriteLine("buffer: resize to {{{0}, {1}}}", size.X, size.Y);
                                }
                            }
                        }
                    }
                }

            }, token);

            Console.WriteLine("Running");

            try
            {
                await Task.WhenAll(readInputBuffer, drainStdin);
            }
            catch (OperationCanceledException)
            {
                // timeout
            }

            Console.WriteLine("press any key...");
            Console.ReadKey(true);

        }
    }
}

TL;DR -- it's very hard, if not impossible, to watch for viewport resizing and also use a pure VT implementation (no console API).
Solution? I'd suggest draining the input buffer if streaming but leaving resize, menu, mouse (if enabled) events etc. This may be a memory leak (but probably fixed max, circular buffer etc) if the default behaviour changed, so I guess it should be opt-in.

Just to put this in context, I'm writing a terminal multiplexer under coreclr (2.2). When I've bound conhost to a cmd/wsl/pwsh subprocess, I can't resize the virtual terminal in response to the user resizing conhost.

@oising to be clear, are you trying to be a client application or a server application?
Your title is mixing both ConPTY and the usage of the classic console API, which implies to me that you're trying to be a client application and a server (console window host) to yourself at the same time.
Or is it that you're trying to be a client application but speaking 99% VT on WriteFile and only using the minimal amount of other Windows client-APIs as possible?

OK so you've got this:
(A) Conhost in standard window visible mode <----> (B) Multiplexer application <------> (C) Conhost in ConPty mode <-----> (D) Client application
A is the server on top displaying stuff.
B is the client of the A server and is simultaneously holding the server end of the C ConPty.
The client end of the C ConPty is going to the D client application.
D is probably speaking classic Win32 to the C conhost in ConPTY mode.
The C conhost in ConPTY is then presumably speaking VT out to B (and vice versa).
The B multiplexer on startup right after attaching to A tells the A handles that it wants the virtual terminal output and input modes so it can get/give information in those formats over the STDIN and STDOUT pipes to make things easy with the information it's receiving from the other side from C.
And I think your problem is that between A and B, it's difficult or nigh impossible to know when the A window has resized and have an event come into B in a format that is easy to consume.
Sound right?

@miniksa Right. Between A (physical, visible conhost window) and B (multiplexer watching conpty(c) and relaying stdin/stdout between D and A.
If I resize the physical window (A), it seems impossible to capture that informational event while streaming stdin/stdout to and from (A) and (D).
D is speaking classic win32 yes, but since it's conpty, it doesn't really matter.

It seems that the moment you start reading from Console.OpenInputStream() then ReadConsoleInput stops receiving any data.  Now obviously this makes sense at first glance, since you're gonna use one or the other but unfortunately resize events are only consumable from the latter.

I think that the .NET abstractions here cause inadvertant flushes. If you're trying to do something advanced like this, I would strongly discourage using System.Console and recommend you just P/Invoke the Win32 APIs instead.
I'll have to give your private repo and the rest of this a more thorough scrub tomorrow morning. I have a few other things to get through today. I might also need @zadjii-msft to get back to work to confer with him on the state of resize as he's been in that space more recently than I have (he's just on vacation this week, due back on Monday.)

I dug into FX already and there was nothing there that stood out initially. Internally the console PAL layer uses ReadConsole or ReadFile, depending on whether or not the handle is redirected. Buried halfway down the ReadConsole docs, there's the following ominous statement:

If the input buffer contains input events other than keyboard events (such as mouse events or window-resizing events), they are discarded. Those events can only be read by using the ReadConsoleInput function.

I suppose this shouldn't be a surprise since ReadConsole and ReadConsoleInput drain the same buffer. My vision of having a nice, clean symmetrical usage of pipelines for stdin/stdout has now been crushed.
Blergh.

Yes, sorry, uhhh... When the calls are serviced, it's the same queue underlying both APIs inside the conhost.exe process. So if you try to ReadFile a thing (or ReadConsole) and it hits the queue and a non KEY_EVENT is sitting there, it's discarded and moves onto the next event.
Also, I have a massive pile of e-mail in my inbox this morning so I'm not remotely closer to looking at your private repro that you shared with me. Please bear with me. I'll try to get to it.

@miniksa Don't stress man over the private repo. It's something you might enjoy reading through to get an idea how someone is trying to do something more advanced than a sample app. In your own time!

Okay, so it looks like I've no choice but to wrap ReadConsoleInput as a Stream, just as the console wraps ReadConsole and come up with some way to side channel the other events. Not trivial, but not impossible either. You guys can either close this, or keep it open for tracking if you see this as an API improvement possibility.

This is one of the classes of issue I want to solve when we get time to do something about #281. Might leave it open.

So I managed to hack together a prototype WindowsConsoleInputStream class that accepts a BlockingCollection<INPUT_RECORD> for side-channel event dispatching (MENU_EVENT, MOUSE_EVENT, WINDOWS_BUFFER_SIZE_EVENT etc) while preserving byte array stream semantics for KEY_EVENT. This lets us wrap a PipeReader around it for nice and simple async IO on stdin/stdou with ConPTY, while watching for viewport changes asynchronously too. So, it's doable!

Excellent to hear. If you have a useful reusable component that helps make this easier, I'd be happy to accept a pull into this repo in the tools directory so we can have it for others to use as well.

@miniksa Done - https://github.com/Microsoft/console/pull/414

I think this is answered, done, and relatively over with for now. Any further calculations on getting the event out will have to do with that one that I said "I need to make this a deliverable for size events".


CORS command no longer works.

This is what I get if I run any of the cors commands.
az webapp cors --help
az webapp: error: argument _subcommand: invalid choice: cors
usage: az webapp [-h]
                 {create,list,show,delete,stop,start,restart,browse,list-runtimes,assign-identity,update,traffic-routing,config,deployment,log,auth}

Is this command no longer valid?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab72811c-1db4-678d-b7a7-33a093a1f587
Version Independent ID: 1e835b1b-514f-cd18-94d5-cd10f4864bd0
Content: az webapp cors
Content Source: latest/docs-ref-autogen/webapp/cors.yml
Service: app-service-web
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Had an older version of the CLI on my machine.


#511 Make slash command arguments available in SB starter

Ticket
#511
Description
Make slash command arguments available in annotated methods with @Slash in SB starter
Checklist

[x] Referenced a ticket in the PR title and in the corresponding section
[x] Filled properly the description and dependencies, if any
[x] Unit tests updated or added
[x] Javadoc added or updated
[x] Updated the documentation in docs folder

In this implementation, methods annotated @Slash with a command pattern containing arguments must have all arguments declared as method parameters in order to be registered and triggered. Is it something we want to enforce (since everything is in the CommandContext)?

Does an existing command like "/command blah" still works?

Yes, it was tested here: symphony-bdk-core/src/test/java/com/symphony/bdk/core/activity/parsing/SlashCommandPatternTest.java
I will more tests in SlashCommandTest to make it more obvious.


Font Size Not Validating Properly For The Second P Tag, Even If the Second P Tag Font is not set to 16px it is not throwing error

Challenge Waypoint: Change the Font Size of an Element has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.86 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 Which browser are you using?

I'm sorry it passes for me too, but it should not pass since I had the font size set to color class instead of .p{} it should only pass when is set .p{font-size:16px}
Sent from Outlook
On Wed, Dec 2, 2015 at 4:15 PM -0800, "Berkeley Martinez"<EMAIL_ADDRESS>wrote:
Passes for me. Which browser are you using?

Reply to this email directly or view it on GitHub:
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/4953#issuecomment-161473719

Confirmed.
The tests need to check that there are two p elements with the style red-text.

Allready got a pullrequest ready, commiting it now


How Resolvers resolve user data even though in query we only specify few info, is it looking through the schema ?

I've got extra information when I tried to get user Data from the playground with login mutation
async function login(
  root: Root,
  args: LoginArguments,
  context: Context,
  info: Info,
) {
 // here only specify id and password.
  let user = await context.db.query.user(
    {where: {email: args.email}},
    ` { id password} `,
  );

  if (!user) {
    throw new Error('User is not found');
  }

  let valid = await bcrypt.compare(args.password, user.password);

  if (!valid) {
    throw new Error('Invalid Password');
  }

  let token = jwt.sign(
    {
      userId: user.id,
    },
    APP_SECRET,
  );

  return {
    token,
   // here why this has all info e.g firstName, lastName, role, etc ?
    user,
  };
}
export {createUser, login};

Versions (please complete the following information):

OS: OS X High Sierra,
CLI:  prisma/1.15.1, node-v10.4.0
Prisma Server: 1.13
graphql-cli, prisma-binding, graphql-yoga

Can you please share a minimal reproduction? That I can test at my end. Thanks!
Ideally, if you are not passing the info object, you should be able to specify the field selection.
Thanks!

Nevermind, I figured if my assumption is correct it actually resolve the all the info options from the Schema definition.
so in schema AuthPayload is defined as
type AuthPayload {
 token: String!
 user: User
}

so that's why I'm able to get all the rest of user info, even though I didn't specify it in
  let user = await context.db.query.user(
    {where: {email: args.email}},
    ` { id password} `,
  );

then I just return
return {
    token,
    user,
  };

it knows by itself, that I'm returning a user type, so password won't be able to fetched. because in schema it is not defined.