Deploy Bookstack without composer

Describe the feature you'd like
Installation & Deployment Process Revamp
Creation of a streamlined & secure process for users to deploy & update BookStack with reduced development requirements (No git or composer requirement)
Please how soon will this be implemented.
Some of us are fed up with composer
Describe the benefits this would bring to existing BookStack users
It would make it easier for the less tech knowledgeable.
Can the goal of this request already be achieved via other means?
No
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
Over 5 years
Additional context
No response

Please how soon will this be implemented.
Some of us are fed up with composer

No sure to be honest. It is the next item on the roadmap after permissions, so I could roughly estimate first half of next year, but I'm not sure it'd be that worthwhile and I'd probably consider changing up the roadmap and removing that phase, or alter it to something different.
This is because I haven't seen much complaint about the current install and update processes, and the current process has worked well (In my opinion) for 7 years now, so I'm not sure on the value of removing composer. I can only envision it being a problem in environments with limited access/functionality, which I don't think we should be going out our way to accommodate anyway.
Feel free to put forward reasons why composer is a problem.
The fundamental request here is already open in  #161, so this will be closed off as a duplicate, but I'll leave this open a small while for discussion.

Perhaps use the docker images to streamline deployment and updates? That's the route I've gone down. Might work for you @bridgeyuwa

Since there's not been much further discussion I'll close this off.

I discovered October CMS use Laravel and have a script they use for their install wizard
https://github.com/octobercms/install/tree/master/install_files
I dunno if it will benefit bookstack.


Revert "remove unused import"

This reverts commit e32cc8e6546b5cf12cc2e6a456f0428f68f59d8a.
Description
It seems the dart:ui improt was not unused. See: https://stackoverflow.com/questions/78090711/error-type-fontfeature-not-found-flutter-google-fonts-package-error
Tests
Please describe the tests that you added or updated to verify your changes.
Issues
Fixes #567 #568
Checklist

[ ] I've reviewed the contribution guide.
[ ] I've updated the package CHANGELOG.md

thanks, however the desired fix here was bumping up the minimum supported version


False positive Null Dereference

/_/src/Meziantou.Framework.Csv/CsvReader.cs:34: error: Null Dereference
  [B5] pointer `returned by get_BaseReader()` could be null and is dereferenced at line 34, column 17.

Pipeline: https://github.com/meziantou/Meziantou.Framework/runs/2026462427?check_suite_focus=true#step:6:2550
Reported line: https://github.com/meziantou/Meziantou.Framework/blob/meziantou-patch-2/src/Meziantou.Framework.Csv/CsvReader.cs#L34

In this case BaseReader is set in the constructor and there is a new check, so it cannot be null. However, Infer# reports it later in the code. I think Infer# is confused by the is statement before.
        public TextReader BaseReader { get; }

        public CsvReader(TextReader textReader)
        {
            BaseReader = textReader ?? throw new ArgumentNullException(nameof(textReader));
        }

       public bool EndOfStream
        {
            get
            {
                if (BaseReader is StreamReader streamReader)
                    return streamReader.EndOfStream;

                return BaseReader.Peek() < 0; // 👈 infer# reports this line
            }
        }

Hi! Actually, Infer# translates the "is" as a null check (the actual type-checking behavior can't really be emulated statically so we only retain the null check behavior), so I think it's probably not that.
I have two hunches for the underlying causes: 1) This is because BaseReader's initialization is protected from null via a thrown exception (which we are in the process of adding support for), or 2) BaseReader is a property whose underlying field value is not directly pushed onto stack, but rather ends up there via an invocation of BaseReader__get().
If the former is the cause, this would be resolved via our next release containing race condition detection and exception handling support. If the latter, this false positive would be an inherent artifact of Infer's backend analysis, albeit one we can resolve via some fairly simple filtering heuristics. Once we push the updated exception handling support we will revisit this so we can best isolate the root cause.


MLP: Add minibatch gradient descent solver

JIRA: MADLIB-1206
This commit adds support for mini-batch based gradient descent for MLP.
If the input table contains a 2D matrix for independent variable,
minibatch is automatically used as the solver. Two minibatch specific
optimizers are also introduced: batch_size and n_epochs.

batch_size is defaulted to min(200, buffer_size), where buffer_size is
equal to the number of original input rows packed into a single row in
the matrix.
n_epochs is the number of times all the batches in a buffer are
iterated over (default 1).

Other changes include:

dependent variable in the minibatch solver is also a matrix now. It
was initially a vector.
Randomize the order of processing a batch within an epoch.
MLP minibatch currently doesn't support weights param, an error is
thrown now.
Delete an unused type named mlp_step_result.
Add unit tests for newly added functions in python file.

Co-authored-by: Rahul Iyer<EMAIL_ADDRESS>Co-authored-by: Nikhil Kak<EMAIL_ADDRESS>Closes #243

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/376/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/377/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/378/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/380/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/383/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/392/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/395/


python2Packages.pymysql: reinit at 0.10.1

Motivation for this change
Reintroduce python2Packages.pymsql, fixes trac, nixosTests.trac.
https://hydra.nixos.org/build/143010147
ZHF #122042.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

FWIW: I tried migrating trac to Python 3, alas:
❯ nix-build -A trac
these derivations will be built:
  /nix/store/6vgrp15i34sc6p1sv6sgrfi6sk7fd8w6-trac-1.4.1.drv
building '/nix/store/6vgrp15i34sc6p1sv6sgrfi6sk7fd8w6-trac-1.4.1.drv' on<EMAIL_ADDRESS>copying path '/nix/store/s48f7k4r0qvxk4crb7yr7l8qw9v1gnyq-python-remove-tests-dir-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/s36k44wp5q70qlr8j83wisf37flrj3ip-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/wdzz0vqcy5i28j6vq0002ni1gmpd3xxw-python-catch-conflicts-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/9gydp66b6wmqgwszavwcayndxdxwm4w5-python-imports-check-hook.sh' from 'https://cache.nixos.org'...
copying path '/nix/store/r5aam18w16zws3p09qnxyd5sd6f60fwl-python-namespaces-hook.sh' from 'https://cache.nixos.org'...
copying path '/nix/store/1lmv4cislj46z2b3am3b8qijzsrgjknb-python3.8-pip-21.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/76bhd24lkdqrgzrbicbcl70886cbq98y-setuptools-check-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/5kn701rkl9im7yq4wfyrm0way8zl7w10-setuptools-setup-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/1xrf5r3q64xas7xldhbwq2rdynngdnjb-pip-install-hook' from 'https://cache.nixos.org'...
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Using pipInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing setuptools-check-hook
Using setuptoolsCheckPhase
unpacking sources
unpacking source archive /nix/store/8wwpc6gzg8z8h9gdmjdhzyk05d3alvw8-Trac-1.4.1.tar.gz
source root is Trac-1.4.1
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file Trac-1.4.1/setup.cfg
patching sources
configuring
no configure script, doing nothing
building
Executing setuptoolsBuildPhase
Trac doesn't support Python 3 (yet)
builder for '/nix/store/6vgrp15i34sc6p1sv6sgrfi6sk7fd8w6-trac-1.4.1.drv' failed with exit code 1

zooming out a little. should we really continue to support python2 packages? python2 has been EOL for 18 months

No, we should probably shouldn't, but we are also not ripping it out right now, so the alternative to reintroducing this package would be to drop trac. Both are fine with me.

cc @mmahut what would you like us to do?

This was a one-time offer for the 21.05 release cycle, I see no reason to make excuses for trac now.


Click event not triggered on component with @click.native

Version
1.0.0-beta.11
Reproduction link
https://codesandbox.io/s/3kqlp1p1rq
Steps to reproduce
Add an @click.native="myMethod()"  to an component.
Create a test where you mount this component:
const wrapper = shallow(MainContainer, { // shallow or mount, no difference
		localVue,
		store,
});

Try to trigger an click event on this component.
wrapper.find('some valid selector').trigger('click'); // trigger('click.native') makes no difference

What is expected?
myMethod is being called
What is actually happening?
myMethod is not called

It works perfectly with @click="myMethod()", so i currently use both as a workaround, @click.native is trigered in browser, @click works in tests. I used Vuetify in the example with an click-binding on the card component.

The problem is that v-card isn't registered as a component. That means there's no DOM node for the event to be added to. You can fix this in two ways:
With mount, by installing Vuetify to register the component:
const clickHandler = sinon.stub()
const localVue = createLocalVue()
const VCard = {
  render: h => h('div'),
  name: 'v-card'
}
localVue.use(Vuetify)
const wrapper = mountingMethod(TestComponent, {
  propsData: { clickHandler },
  localVue,
})
wrapper.find({name:'v-card'}).trigger('click')
expect(clickHandler.calledOnce).to.equal(true)

With shallow, by passing a stub:
const TestComponent = {
  template: `<v-card @click.native="clickHandler"/>`,
  props: ['clickHandler']
}
const clickHandler = sinon.stub()
const VCard = {
  render: h => h('div'),
  name: 'v-card'
}
const wrapper = mountingMethod(TestComponent, {
  propsData: { clickHandler },
  stubs: {
    VCard
  }
})
wrapper.find(VCard).trigger('click')

expect(clickHandler.calledOnce).to.equal(true)


Update tasks to support Fractal V2

Update input API & output handling for:
Simple updates:

[x] Cellpose segmentation: ParallelTask, does not generate outputs
[x] Apply registration to image: ParallelTask. Input type is registartion=False, sets registration=True flag.

[x] Implement overwrite_input=False functionality, return the relevant image list update

[x] Illumination Correction: Parallel Task.
[x] napari workflow wrapper: ParallelTask, does not generate outputs

Refactoring required

[ ] Convert CellVoyager to OME-Zarr: New Compound Task that combines Create OME-Zarr + Yokogawa to OME-Zarr
[ ] Convert CellVoyager to OME-Zarr multiplex: New Compound Task with a different init from regular one. Maybe combine the 2? Likely not.
[ ] Import OME-Zarr: Non-Parallel Task. Future work to handle existing image list? Needs to provide correct new task output
[ ] Maximum intensity projection: New Compound task together with Copy OME-Zarr, needs new handling for Task output
[ ] Find Registration Consensus: NonParallel or Compound task, based on Apply registration to ROI table. Needs to compute consensus on well level, either in compound mode or within a non-parallel task
[ ] Calculate Registration Image based: Newly a compound task

Update Manifest

[ ] Apply registration to image: ParallelTask. Input type is registartion=False, sets registration=True flag.
[ ] Illumination Correction: Parallel Task. Input type is illumination_corrected=False, sets illumination_corrected=True

Testing

[ ] Update testing helper functions:

[ ] prepare_3D_zarr and prepare_2D_zarr in _zenodo_ome_zarrs still return zarrs with the old metadata logic (defined in the zenodo_zarr_metadata fixture)

[ ] Update & reenable manifest validation in Github CI
[ ] Update & reenable test_valid_args_schemas
[ ] Illumination correction testing: Also test overwrite=False

Examples

[ ] Update examples to use new API

Future goals

[ ] Illumination Correction with Channel parallelisation: Test this if time available
[ ] Less testing whole workflows and more testing standalone tasks: Create fixtures that create the relevant inputs for many other tasks, create the image list metadata they need [avoid having image list in task CI as much as possible, besides checking they provide the correct new outputs)

I'm doing some refactoring work on the Create OME-Zarr & Yokogawa to OME-Zarr handling. At first, I thought I could just pass the patterns list between the two functions. But the regex for finding individual channels could in some cases break in that approach. Thus, I've now set up an init_args model like this one:
class InitArgsCellVoyager(BaseModel):
    """
    Arguments to be passed from cellvoyager converter init to compute

    Attributes:
        image_dir: Directory where the raw images are found
        plate_prefix: part of the image filename needed for finding the
            right subset of image files
        well_ID: part of the image filename needed for finding the
            right subset of image files
        image_extension: part of the image filename needed for finding the
            right subset of image files
        image_glob_patterns: Additional glob patterns to filter the available
            images with
        acquisition: Acquisition metadata needed for multiplexing
    """

    image_dir: str
    plate_prefix: str
    well_ID: str
    image_extension: str
    image_glob_patterns: Optional[list[str]]
    acquisition: Optional[int]

And pattern parsing like this:
        patterns = [
            f"{init_args.plate_prefix}_{init_args.well_ID}_*{A}*{C}*."
            f"{init_args.image_extension}"
        ]
        if init_args.image_glob_patterns:
            patterns.extend(init_args.image_glob_patterns)


feat(feature_flags): add in feature_flags RE_* actions and update tests/docs

Issue #, if available:
#690
Description of changes:
Extend feature_toggles to enable regular expression actions... next step - lets just use embedded lua!
Checklist

[X] Meet tenets criteria
[X] Update tests
[X] Update docs
[X] PR title follows conventional commit semantics

Breaking change checklist
Nope
RFC issue #:
Nope

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

View rendered docs/utilities/feature_flags.md

View rendered docs/utilities/feature_flags.md

Codecov Report

Merging #692 (74f8759) into develop (79414c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #692   +/-   ##
========================================
  Coverage    99.97%   99.97%
========================================
  Files          116      116
  Lines         4855     4862    +7
  Branches       267      267
========================================
+ Hits          4854     4861    +7
  Partials         1        1

Impacted Files
Coverage Δ

...owertools/utilities/feature_flags/feature_flags.py
100.00% <100.00%> (ø)

...ambda_powertools/utilities/feature_flags/schema.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79414c8...74f8759. Read the comment docs.

Hey @whardier that's a great idea!
I’m returning from vacation next week and can help review, if that's okay.
At a quick glance, I'd suggest receiving a re.compile object so customers to favour performance -- they can compile outside the handler for a full CPU power and we can use it on every invocation.
Thank you!!

Yup I kept things lambda oriented.  I would refer to instead make a mapping
of compiled patterns.
On Thu, Sep 23, 2021 at 12:24 PM Heitor Lessa @.***>
wrote:

Hey @whardier https://github.com/whardier that's a great idea!
I’m returning from vacation next week and can help review, if that's okay.
At a quick glance, I'd suggest receiving a re.compile object so customers
to favour performance -- they can compile outside the handler for a full
CPU power and we can use it on every invocation.
Thank you!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/692#issuecomment-926127721,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKRFOI4STKUM6B2ZY7DMDUDOEHVANCNFSM5EUJBC4A
.

--
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb
Shane Spencer
about.me/ShaneSpencer
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb
Sponsor @whardier on GitHub Sponsors https://github.com/sponsors/whardier

Alternative approach using user mappings:
https://github.com/awslabs/aws-lambda-powertools-python/compare/develop...whardier:feat/feature-flags-user-mapping-by-action

Alternative approach using user mappings:
develop...whardier:feat/feature-flags-user-mapping-by-action

This is awesome -- we're taking a look at it this week. Feel free to change this PR for a user-defined action that we can call it. If it is returns a falsy value or an exception we can say the rule didn't match.
That should give more flexibility to define what they'd like with a simple contract.
thoughts @risenberg-cyberark @michaelbrewer?

I like the regex action. I think we'r missing tests - 6 actions require 12 tests - one for match, one for no match.
Regarding the user actions - i'm the fence regarding this one, because they might override the default action by mistake. If we were to add such a support, the logic in the match by action should be - try to find the action in the default mapping, if it's None, check user mappings (not merge the dicts like i saw in the branch https://github.com/awslabs/aws-lambda-powertools-python/compare/develop...whardier:feat/feature-flags-user-mapping-by-action)

The logic can be improved — we can use a callable. I meant more of an idea
to allow user-defined function
On Wed, 29 Sep 2021 at 15:06, Ran Isenberg @.***> wrote:

I like the regex action. I think we'r missing tests - 6 actions require 12
tests - one for match, one for no match.
Regarding the user actions - i'm the fence regarding this one, because
they might override the default action by mistake. If we were to add such a
support, the logic in the match by action should be - try to find the
action in the default mapping, if it's None, check user mappings (not merge
the dicts like i saw in the branch
develop...whardier:feat/feature-flags-user-mapping-by-action
https://github.com/awslabs/aws-lambda-powertools-python/compare/develop...whardier:feat/feature-flags-user-mapping-by-action
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/692#issuecomment-930156979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBC4CXEZO7XYU4K5WGTUEMFMZANCNFSM5EUJBC4A
.

I think it's a bit over-kill. After we add the regex and more 'not' actions, It will probably cover most of the use cases for most users. It would be really great if we could have some poll/feedback as to what actions are missing.

Actually this would be instead of the regex action.
I’ll have a chat with the team tomorrow as we’ll tackle as many issues and
PRs we can tomorrow
On Thu, 30 Sep 2021 at 08:29, Ran Isenberg @.***> wrote:

I think it's a bit over-kill. After we add the regex and more 'not'
actions, It will probably cover most of the use cases for most users. It
would be really great if we could have some poll/feedback as to what
actions are missing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/692#issuecomment-930838551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBCKTAGQI4K443FWWADUEP7U7ANCNFSM5EUJBC4A
.

Strongly suggest renaming the rules so it is clear which is the pattern (the value or the key) and which is the string.
I'd also suggest that it may be appropriate to have conditions that match the other way around to what is being proposed (i.e. swap what is the pattern and what is the string).

I am on the fence on the approach as well as far as what would be best
suited for long-term maintainability and overall clarity.
Exceptions logged and falsy.
The default rules aren’t overridden and are last in the rules dict update.
On Thu, Sep 30, 2021 at 11:18 AM Gerald Leter @.***>
wrote:

Strongly suggest renaming the rules so it is clear which is the pattern
(the value or the key) and which is the string.
I'd also suggest that it may be appropriate to have conditions that match
the other way around to what is being proposed (i.e. swap what is the
pattern and what is the string).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/692#issuecomment-931596731,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKRFP3IQTOO3JQUA5HHOLUESZYZANCNFSM5EUJBC4A
.

--
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb
Shane Spencer
about.me/ShaneSpencer
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb
Sponsor @whardier on GitHub Sponsors https://github.com/sponsors/whardier

If we go for RE instead to handle most cases we just need a precompiler
On Thu, Sep 30, 2021 at 11:39 AM Shane R. Spencer @.***>
wrote:

I am on the fence on the approach as well as far as what would be best
suited for long-term maintainability and overall clarity.
Exceptions logged and falsy.
The default rules aren’t overridden and are last in the rules dict update.
On Thu, Sep 30, 2021 at 11:18 AM Gerald Leter @.***>
wrote:

Strongly suggest renaming the rules so it is clear which is the pattern
(the value or the key) and which is the string.
I'd also suggest that it may be appropriate to have conditions that match
the other way around to what is being proposed (i.e. swap what is the
pattern and what is the string).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/awslabs/aws-lambda-powertools-python/pull/692#issuecomment-931596731
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AACKRFP3IQTOO3JQUA5HHOLUESZYZANCNFSM5EUJBC4A
.

--
<
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb

Shane Spencer
about.me/ShaneSpencer
<
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb

Sponsor @whardier on GitHub Sponsors <https://github.com/sponsors/whardier

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/pull/692#issuecomment-931609881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKRFOJG5DPBVU7YDDUGE3UES4I3ANCNFSM5EUJBC4A
.

--
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb
Shane Spencer
about.me/ShaneSpencer
https://about.me/ShaneSpencer?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb
Sponsor @whardier on GitHub Sponsors https://github.com/sponsors/whardier

If we go for RE instead to handle most cases we just need a precompiler

Requiring a precompiler does not sound like a good idea.

It is fairly typical to￼ use re.compile in situations like this￼.  It would have to happen between after or during configuration load and use￼.. possibly part of validation

Here is an example use case an RE would not cover -- compare if a key  (e.g. current date in YYYY.MM.DD format) is greater than a given value (i.e. the general go-live date).  The feature might also have anoter rule to see if the user is in a group of beta users and thus has access to the feature prior to the general go-live date.

"The default rules aren’t overridden and are last in the rules dict update."  - what if someone uses the same keys as the default rules?

Here is an example use case an RE would not cover -- compare if a key (e.g. current date in YYYY.MM.DD format) is greater than a given value (i.e. the general go-live date). The feature might also have anoter rule to see if the user is in a group of beta users and thus has access to the feature prior to the general go-live date.

if we added greater than action that you could use unix epoch time, i know its less readable but it works

Here is an example use case an RE would not cover -- compare if a key (e.g. current date in YYYY.MM.DD format) is greater than a given value (i.e. the general go-live date). The feature might also have anoter rule to see if the user is in a group of beta users and thus has access to the feature prior to the general go-live date.

if we added greater than action that you could use unix epoch time, i know its less readable but it works

As long as the key and value are formatted either as epoch time or as a string suggested the compares work.  See:
>>> def test(a,b):
...     if a > b:
...             print("Greater")
...     else:
...             print("Less than or equal")
...
>>> sa = "2021.10.01"
>>> na =<PHONE_NUMBER>
>>> test(sa,"2021.11.01")
Less than or equal
>>> test(sa,"2021.09.01")
Greater
>>> test(na,1635742800)
Less than or equal
>>> test(na,1630472400)
Greater
>>>

hey everyone - could we get the conflicts resolved as I'd like to have a second look at bringing RE actions instead of user defined?
We'd also need to receive a compiled pattern (re.Pattern) to improve perf.

@heitorlessa , if no one gets to it prior to this weekend I'll take a look at pulling down the branch and resolving conflicts.  I'm slammed at work this week and that is the earliest I can get to it.

Due to the lack of activity, I'm gonna close this for now - Once we merge #804, this will make it harder to maintain. Instead, let's focus on support Bring Your Own Action so customers can use anything they'd like to validate features.


Fix some of the errors I've encountered while following tutorials

While doing the tutorial exercises, I had to fix some bugs to make the examples work. This PR contains the fixes I added to the code.

Someone should help merge this pr, I encounter almost the same problem

CC: @tanayvarshney @nealvaidya

Thank you for making these fixes! Have you submitted a Contributor License Agreement so that we can review these changes? https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla
CC: @nealvaidya @tanayvarshney


Tensor all operator results is incorrect on burn-wgpu when using with lower_equal

Describe the bug
The results are incorrect for burn-wgpu backend if used in conjunction with lower_equal. It works for burn-ndarray. And oddly under fusion it passes.
To Reproduce
Add the following test into crates/burn-tensor/src/tests/ops/all.rs and run the test under burn-wgpu:
[burn-wgpu]% cargo test test_bug1

#[test]
fn test_bug1() {
    let tensor1 = TestTensor::from([[0.0, 1.0, 0.0], [1.0, -1.0, 1.0]]) + 1e-6;
    let tensor2 = TestTensor::from([[0.0, 1.0, 0.0], [1.0, -1.0, 1.0]]) + 1e-6;

    let ge = tensor1.lower_equal(tensor2);
    println!("ge: {:#?}", ge.clone().into_data());

    let all = ge.clone().all();
    println!("all {}", all.clone().into_data());

    assert_eq!(Data::from([true]), all.clone().into_data());
}

Results in:
[burn-wgpu]% cargo test test_bug1
    Finished test [unoptimized] target(s) in 0.08s
     Running unittests src/lib.rs (/Users/dilshod/Projects/burn/target/debug/deps/burn_wgpu-42c7d3086f1b764b)

running 2 tests
test tests::all_op::tests::test_bug1 ... FAILED
test fusion::base::tests::all_op::tests::test_bug1 ... ok

failures:

---- tests::all_op::tests::test_bug1 stdout ----
ge: Data {
    value: [
        true,
        true,
        true,
        true,
        true,
        true,
    ],
    shape: Shape {
        dims: [
            2,
            3,
        ],
    },
}
all [false]
thread 'tests::all_op::tests::test_bug1' panicked at crates/burn-wgpu/src/lib.rs:96:5:
assertion `left == right` failed
  left: Data { value: [true], shape: Shape { dims: [1] } }
 right: Data { value: [false], shape: Shape { dims: [1] } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    tests::all_op::tests::test_bug1

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 1306 filtered out; finished in 0.04s

error: test failed, to rerun pass `--lib`

But this passes with burn-ndarray:
[burn-ndarray]% ct test_bug1
   Compiling burn-tensor v0.13.0 (/Users/dilshod/Projects/burn/crates/burn-tensor)
   Compiling burn-autodiff v0.13.0 (/Users/dilshod/Projects/burn/crates/burn-autodiff)
   Compiling burn-ndarray v0.13.0 (/Users/dilshod/Projects/burn/crates/burn-ndarray)
    Finished test [unoptimized] target(s) in 1.40s
     Running unittests src/lib.rs (/Users/dilshod/Projects/burn/target/debug/deps/burn_ndarray-c1c0a5464ba1876e)

running 1 test
test tests::all_op::tests::test_bug1 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 581 filtered out; finished in 0.00s

@ashdtu , @louisfd , @nathanielsimard you guys probably understand why it's the case with WGPU (not fusion). Some data leaks?

This blocks my current PR: https://github.com/tracel-ai/burn/pull/1389

Hi @antimora
It's the same issue as in #1315 which @ashdtu found when working on any/all. It's a known bug about wgpu inplace bool operations I can fix quickly

@antimora The #1391 bugfix should fix it


[RFC] kernel: generate placeholders for kobj tables before final build

Due to the use of gperf to generate hash table for kobjects,
the addresses of these kobjects cannot change during the last
few phases of linking (especially between zephyr_prebuilt.elf
and zephyr.elf). Because of this, the gperf generated data
needs to be placed at the end of memory to avoid pushing symbols
around in memory. This prevents moving these generated blocks
to earlier sections, for example, pinned data section needed
for demand paging. So create placeholders for use in
intermediate linking to reserve space for these generated blocks.
Due to uncertainty on the size of these blocks, more space is
being reserved which could result in wasted space. Though, this
retains the use of hash table for faster lookup.
Alternative to #33719

Related to #32129

This and #33719 seem related to the problem underlying https://github.com/zephyrproject-rtos/zephyr/issues/32129 ; it may be worth looking at the description there when considering alternative solutions, as existing kernel objects are not the only data structures that might change size between link phases.

Updated to use some type of fudging factor as proposed by @mbolivar-nordic. The multiple build passes does not guarantee enough space is reserved for final build so this new method is better and this won't lengthen the build (that much).

The idea seems sound to me, though I suspect if a fudge factor of 200% is really required in practice, we may want to drop gperf eventually for footprint reasons.

The idea seems sound to me, though I suspect if a fudge factor of 200% is really required in practice, we may want to drop gperf eventually for footprint reasons.

200% is simply a safe choice for most scenarios. Apps can tune the value if needed.

Appreciate some reviews to get this or #33719 merged.


Fixed client-side browser validation with required form fields

Fixes #187.

Let's wait for Travis...


Hk move comments specs #trivial

This shovels around some specs to a more fitting place as described in #400.
It allowed me to remove the before block for the #generate_comment examples. I also split the example on deduplicating previous errors into two specs, one concerning the deduplication and one concerning the random compliment. Because of not wanting to stub the subject under test I asserted on a more general \w pattern.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

          1 Message

:book:
@hanneskaeufler is not a contributor yet, would you like to join the Danger org?

  Generated by :no_entry_sign: danger

Thanks for the first PR @hanneskaeufler - would you like to join the org?
This fixe https://github.com/danger/danger/issues/400 and would likely require a rebase for #412

Thanks for the merge. Great first-commit experience btw. An easy to pick up issue, and I just love it when I can git clone && bundle && rake and be confident in the tests right from the get-go. Would be stoked to join the org ❤

Top notch 👍  Thanks for the PR


Create convention to set non-CLR default for enum key sentinel value

When enums are used as keys the default(T) sentinel value will often not be appropriate because default(T) is usually a valid value in the enum. There should be a convention that sets, for example, -1, as the sentinel for enum keys.

Sentinels going away, so this is not needed.


Black Screen Issue

Hello,
After the setup of config.js and installation of npm and node, I succeed to launch the app but the screen is all black, and same for the index.html

Just type npm start in vendor file and voilà !

Just type npm start in vendor file and voilà !

hello @Nograe I'm having the same issue. Tried all of the other suggestions mentioned in other issues that are similar. including the "en" change but nothing seems to be working so my problem must be elsewhere.
What do you mean by vendor file?

@axellejamous Please check http://forum.magicmirror.builders for support.

for anyone else, i solved my blank screen issue by
cd ~/MagicMirror/vendor
npm install

it will download fonts and icons needed by modules.
then
cd ~/MagicMirror
npm start

and now it shows modules perfectly 💃  ..

+1 and kudos to hyd00

Magic Mirror would not properly install for me after doing apt-get update && apt-get upgrade. However, after doing: apt-get -y dist-upgrade, the Magic Mirror package installed. From there, I went inside MagicMirror and ran: git pull && npm install. That brought me current with an installed version of Magic Mirror. Again, thanks to hyd00 for the vendor folder recommendation.

I was stuck for hours on this, thanks @hyd00! Should be added to the instructions for manual install.


Linkify doesn't work

Nevermind, I just noticed that I have to use the component, not the helper.

Yeah, I'll add that functionality to my todo list. I'll hopefully be able to get to it this week. Sorry it was unclear.

That would be cool, thanks.


Remove unused simplesamlphp configuration

These configuration files were in use when profile was still part of
EngineBlock. It should now be possible to remove them.

This needs some more thought!


Getting the following error. Everything specified is installed.

✗ Could not properly compile test addon, did not load binding
✗ /usr/local/lib/node_modules/goingnative/exercises/am_i_ready/child.js:17
✗ if (binding.test !== 'OK') {
✗            ^
✗ TypeError: Cannot read property 'test' of undefined
✗     at Object. (/usr/local/lib/node_modules/goingnative/exercises/am_i_ready/child.js:17:12)
✗     at Module._compile (module.js:397:26)
✗     at Object.Module._extensions..js (module.js:404:10)
✗     at Module.load (module.js:343:32)
✗     at Function.Module._load (module.js:300:12)
✗     at Function.Module.runMain (module.js:429:10)
✗     at startup (node.js:139:18)
✗     at node.js:999:3
✗ Test binding file works as expected

is that the only output? can you provide details on your operating system and version of Node.js please?

I'm using #38-Ubuntu SMP with 3.19.0-33-generic kernel.
Node is v5.4.1
gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
Here's the full output:
✓ Found usable `node` version: v5.4.1
✓ Found usable `gcc` in $PATH: v4.9.2
✓ Found usable `python` in $PATH: v2.7.9
✓ Found usable `node-gyp` in $PATH: v0.12.2
Running `node-gyp`, this may take a few minutes if it hasn't been run before...
make: Entering directory '/media/gabriel/Windows8_OS/Users/Gabriel/Dropbox/goingnative/~test-addon.7522/build'
  CXX(target) Release/obj.target/test/test.o
  SOLINK_MODULE(target) Release/obj.target/test.node
  SOLINK_MODULE(target) Release/obj.target/test.node: Finished
  COPY Release/test.node
make: Leaving directory '/media/gabriel/Windows8_OS/Users/Gabriel/Dropbox/goingnative/~test-addon.7522/build'
✓ Compiled test package
✓ Found compiled test binding file
✗ Could not properly compile test addon, error finding binding: Module did not self-register.
✗ Could not properly compile test addon, did not load binding
✗ /usr/local/lib/node_modules/goingnative/exercises/am_i_ready/child.js:17
✗ if (binding.test !== 'OK') {
✗            ^
✗ TypeError: Cannot read property 'test' of undefined
✗     at Object.<anonymous> (/usr/local/lib/node_modules/goingnative/exercises/am_i_ready/child.js:17:12)
✗     at Module._compile (module.js:397:26)
✗     at Object.Module._extensions..js (module.js:404:10)
✗     at Module.load (module.js:343:32)
✗     at Function.Module._load (module.js:300:12)
✗     at Function.Module.runMain (module.js:429:10)
✗     at startup (node.js:139:18)
✗     at node.js:999:3
✗ Test binding file works as expected

# FAIL

@HeroicAutodidact would you mind trying it in a different directory? It could be that the file system type that's being used isn't playing so nicely here. Perhaps switch to /tmp/ and run through it again and see if it makes a difference. The fact that's it's getting past the compile step suggests that it's something to do with loading from the filesystem .. I think

Alright, I tried this, identical message. I've also tried locally installing goingnative, and I've tried executing gonative as root.
Any other ideas?
Is there someplace I can see which commands are being executed by gonative during the verify step? I can try executing individually and testing where the error is.

@HeroicAutodidact
https://github.com/workshopper/goingnative/blob/master/exercises/am_i_ready/child.js#L13-L19
The line immediately above accessing .test checks to see if binding is defined and outputs an error.
@rvagg shouldn't we be breaking execution when each of those checks fail?

https://github.com/workshopper/goingnative/blob/master/exercises/am_i_ready/exercise.js
it's compiling an addon in ../../packages/test-addon/ and then trying to load it with child.js.

@retrohacker it is broken when one fails, as it has in this case, the callback in each of the processors controls that, the false as a second argument indicates a proper fail.

We can at least avoid the TypeError for referencing a value we already know is undefined from a previous check.
if(binding != null && binding.test !== 'OK')


In cell [5] use new-ish function call for compare_plot

this is done already for German districts, but missing for JHU data
new function call should be something: compare_plot(..., dates="2020-03-15:") (see any German district).

We have quite a lot of code duplication there, and that's the reason we will have to either add even more duplicate code into the make_compare_plot function or refactor the whole set of similar functions into one.  Anyway, that's not a small, it requires to scatter more than, dunno, 20 non-trivial lines of code here and there.


Connectors metrics

Related to [ch60097] https://app.clubhouse.io/cartoteam/story/60097/instrument-connectors-with-business-metrics
This PR involves several events sent to PubSub, all related to connectors.
Acceptance
All the following actions should trigger the creation of the corresponding event in PubSub and then an entry in the corresponding table in BigQuery. The import/sync actions should be tested for all the connectors types, or at list examples from file connectors (i.e. google drive) and db connectors (i.e. postgres, mysql...).

Import a dataset/map through a connector in cartodb
Event: map_created / dataset_created containing the user data and import info (connector, import_duration, data_from, data_size, sync_enabled)

Failed import through a connector in cartodb
Event:import_failed containing the user data and import info (connector, import_duration, data_from, sync_enabled) and the error code

Failed sync process (i.e. when selecting the sync option in an import done through a connector in cartodb)
Event: sync_failed containing the user data and the sync info (connector and error code)

Enable a feature flag (i.e. "carto-connectors") for all the cases:
4.a) a particular user
4.b) an org
4.c) all the users
Event: feature_flag_updated with the user data and the feature flag info (name and state: "enabled")

Disable a feature flag (i.e. "carto-connectors") for the cases:
5.a) a particular user
5.b) an org
Event: feature_flag_updated with the user data and the feature flag info (name and state: "disabled")

@jgoizueta are you doing the acceptance for this one? just saying because I can take a look if you want, just let me know.

I've been testing this in staging and it seems to be working fine. I haven't tested all the cases (for technical limitations in staging right now and for lack of time), but I think this can be safely deployed and it will be easier to finish the tests in production.
Here is the staging testing procedure for future reference:
To test this in staging I used the cartodb-on-gcp-metrics metrics; I created a topic "test-import" and and subscription "conn-metrics-test" on it. I then generated a key for the existing "esloho-test" service account, which already had needed permissions (BigQuery Admin and Pub/Sub Admin roles).
For staging tests it's easier to use a dedicated for this, since we have only one host to configure.
Using a dedicated, I placed the service account credentials in /home/ubuntu/cartodb-on-gcp-metrics-86d83a5f9b6f.json and then I changed the configuration in /home/ubuntu/www/production.cartodb.com/current/config/app_config.yml:
  pubsub:
    project_id: "cartodb-on-gcp-metrics"
    topic: "test-import"
    credentials: "/home/ubuntu/cartodb-on-gcp-metrics-86d83a5f9b6f.json"

pubsub messages are sent from the tracker resqueue queue, which is handled by
the resque-users processes, so we need to restart it to take the new configuration:
sudo monit restart resque-users-0

Then we're ready to test and check by pulling the subscription projects/cartodb-on-gcp-metrics/subscriptions/conn-metrics-test

Moving to deployment, we can do it next Monday.
Thanks! @jgoizueta ❤

💥
thank you!!!


How to bundle it in web apps?

Hello, I attempted to integrate Yanki-Connect into a Vite project. However, an error occurred:
error during build:
<EMAIL_ADDRESS>(1:8): "promisify" is not exported by "__vite-browser-external", imported by<EMAIL_ADDRESS>
I discovered that Yanki-Connect imports 'open', which is exclusive to Node.js. Think removing the autoLaunch functionality would settle this issue. Is there a better way?

Hi thanks for trying the library and taking the time to open an issue.
It looks like even though the Node-specific launching logic is behind a dynamic import, Vite is not tree-shaking it away on build.
However, I'm able to get a Vite project with yanki-connect building correctly with the following vite.config.ts:
import { defineConfig } from "vite";

export default defineConfig({
  build: {
    rollupOptions: {
      external: ["open"],
    },
  },
});

Let me know if that works for you, and if you'd like a full project example.
I'll see if there are better ways to get Vite to ignore the node-specific functionality without placing the burden of configuration on the library user, but in the meantime will add a note to the readme if this is a fix for you.

Thanks, your approach works! And think it's helpful to add this note to README.md.

Great! Added a section to the readme with instructinos.


Make Grafana certificate dashboard default value aligns to Prometheus alerting rule

green: = >3 Months
yellow: 1-3 Months
red: <1 month or even expired

The default Prometheus alerting rules are

info: < 3 months
warning: < 1 month
critical: < 1 week

Signed-off-by: JenTing Hsiao<EMAIL_ADDRESS>

It’s good to align both settings between Prometheus and grafana to avoid any confusion.


Update dependencies

Updates dependencies to newest versions.
Requires #29 to pass CI.

otherwise this look in line with https://github.com/kubernetes/kubernetes/pull/121842 so we can bump ahead of time


fix disconnect not close consumer

Codecov Report

Merging #73 (789b143) into main (f10cf8f) will decrease coverage by 0.36%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   60.36%   60.00%   -0.37%
==========================================
  Files          12       12
  Lines        1244     1245       +1
==========================================
- Hits          751      747       -4
- Misses        397      401       +4
- Partials       96       97       +1

Impacted Files
Coverage Δ

pkg/kafsar/kafka_impl.go
47.12% <60.00%> (-1.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10cf8f...789b143. Read the comment docs.


docs(managing-workflow): Document PROXY protocol configuration

This adds a section on configuring PROXY protocol with a specific example targeting K8s on AWS using ELB.
Because of the fix in deis/router#263 this PR should likely be held back until Workflow v2.6.0 is released.

@kmala Should we mention that K8s 1.3.x or later is needed to support the service.beta.kubernetes.io/aws-load-balancer-proxy-protocolannotation?

@felixbuenemann yes..it is better to mention that and also say that it can be configured manually through  http://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-proxy-protocol.html

I've added an "important" info box with the K8s version requirement and rebased on master.


Fix updating scene root cache twice

Manually updating the cache in advance resulted in some bugs when EditorNode::set_edited_scene() was automatically called for the second update.
Supersedes #89428.
Fixes #87451.

The cube is still duplicated 🤔
https://github.com/godotengine/godot/assets/2223172/981f9e85-c10f-46b0-a73c-83c974dacd57
It's gone when you switch scene tab.

Sorry for the late reply.
It reloads scene tabs one by one, so it's better to switch scene tabs first and then process them later.
In addition, it does not seem to save scene modifications when necessary, so re-importing resources may cause the scene to lose unsaved modifications.

Something is still wrong:
https://github.com/godotengine/godot/assets/2223172/5571f4bc-ca17-4361-b655-140d88021e7f
The level scene gets replaced by test (only visually). It doesn't always happen though. I also had a bug where test.tscn had 2 cubes.

Two scenes appear to be open in the 3D screen at the same time. It seems that get_tree()->set_edited_scene_root() is not switched correctly.

Now it seems to work correctly, but there is an error spam 🙃
https://github.com/godotengine/godot/assets/2223172/422436ac-5424-4105-83d7-32ff199fef15
Also the current changes make updating scenes after reimport much more expensive. Though maybe it doesn't matter unless someone opens, like, 50 scenes with instances to update.

https://github.com/godotengine/godot/blob/214968243c442c0fdcbdfef23943c1547aeafdbc/editor/editor_node.cpp#L5658
Reloading a PackedScene clears the cache, which is not rebuilt until instantiate() is called.

If the scene has unsaved modifications before reimporting, these modifications will not be saved after reimporting, but the unsaved mark (*) will disappear.
Should these modifications be saved before reimporting?

IIRC reloading a scene tries to re-apply unsaved changes, so nothing should be lost. Though maybe it's different for regular instances vs imported scenes.

But it doesn't prompt to save when closing the tab.
https://github.com/godotengine/godot/assets/30386067/8209650a-ea4a-4fad-a4e2-c2be739e1bb5

That's because the scene does not appear unsaved. It should retain the unsaved status after soft-reload.

Needs rebase due to conflicts >_>

The conflict has been resolved.
The latest commit in master no longer restores the changes caused by the import, which should refresh the 3D Screen to show the latest changes, but it seems that only the inherited scene will be refreshed, not other scenes.

Thanks!

I apologize for adding a comment here, not sure if I should have just posted it in the issue (bit new to issues and all of this honestly), but here goes.
I believe this commit is causing an issue with restarting scenes when reimporting resources, resulting in enter tree being called multiple times, you can see my issue here: https://github.com/godotengine/godot/issues/92623
Is this intended or is this a bug?
It's a bit of a blocker to me.


New service Cloudflare, auto find services, better IP Regex and better TLD check

Hi! I've updated your tool with:

New service Cloudflare
It allow to update a domain or subdomain like myhomeserver.mydomain.tld with dynamic IP using latest cloudflare API (v4), it's useful if you use cloudflare in your domain DNS.
Auto find services
Instead of harcored services, now the program search in services folder and auto generate a list with all services.
Better IP Regex
Old regex allow invalid IPs like 987.999.777.676, new regex not allow invalid IPs.
Better TLD check
Using tld library with a function for upload latest tlds, now it allow domains like my.subdomain.google.co.uk
Some code formatting and optimized imports
install_requires added to setup.py for auto-install requires when installing update-ip.

I hope that all changes are ok, this program is awesome and i would like to continue improving it.

On reviewing this locally, I've noticed there plenty of small changes that I overlooked on my first pass. It's probably too much discuss for a single PR, I'm already losing track of all the changes.
I'm going to rebase/squash/fixup this locally and merge the things we've agreed on so far, so we can have clean diffs in the future and keep the discussion focused

I've finally finished :) That was a long rebase!
I've committed your formatting/cleanups and new getters into master.
I've pushed a new branch, CristianDeluxe-cloudfare, with your (squashed) cloudfare changes, plus two commits I did as suggestions. I hadn't noticed you were using tld only for getting the second level domain (you called it the "Zone", I think). Feel free to rebase/merge from there and submit a new PR for that. Hopefully with your formatting changes merged in future PRs will be easier to review
I've left out the regex and services-detection. Re-reading the current code, there's actually already validation for IP addresses, so things like 999.999.999.999 should be a non-issue. Services detection could be nice if we ever have a ton of services, but for now it's more trouble than it's worth for me.


mimes.php: 7z file types changes

As this Wikipedia article states, the 7-Zip generated archives have the 7z extension and the MIME id application/x-7z-compressed.

That's cool but it should add '7z' not replace '7zip'.

I know you are thinking about a potential BC break, I did too. But there won't be any: if we look back in 2007, at the software itself, they were using 7z archives, and not a 7zip.
I don't really mind adding a new line instead of replacing, since I can't really tell what's the source of 7zip extension in that file... but I'm pretty sure that if someone has a 7zip, it's because of a renaming, not as 7-Zip direct output.

Yes, but renames do happen and we've had people complain about the weirdest BC breaks ever ... please just alter the patch.

@narfbg You're right. Done in 8eeb1a8.


test: injected providers

Explanation
Unit-testing for:

Providers.
EventEmitter service

More Information

Resolve #344

Screenshots/Screencaps
N/A

Manual Testing Steps
N/A

Pre-Merge Checklist

[x] PR template is filled out
[ ] IF this PR fixes a bug, a test that would have caught the bug has been added
[x] PR is linked to the appropriate GitHub issue
[ ] PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

These changes are related to old project structure so they are not applicable for monorepo.


minor readme fixes: missing space, code highlight

add a space character between a link and text
fix code highlight; GitHub does not understand MyST
format markdown table (automatically fixed by editor)

add a space character between a link and text
fix code highlight; GitHub does not understand MyST
format markdown table (automatically fixed by editor)


Azure Sentinel Oracle Cloud Infra. Data Connector errors

Issue description:
After deploying the OCI solution and the associated Function App, we observed OCI API errors relating to "ToManyRequest". We are unsure of why this is or how to resolve this issue. Should the Function code be modified with a sleep interval?
We have posted an image of the error below.
Link to solution: https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/OCILogs/Data Connectors
Image of issue:

@v-atulyadav , @ashwin-patil
There seems to be two issues with this solutions.

If there are multiple Partitions assigned to the Consumer Group and one of the cursors outside of the retention period, this will lead to an error. This seems to be address in the following link:  Troubleshooting Streams
In some instances, there can be a lot of data returned (e.g. if netflow logs are being sent to the stream) which could lead to the Log Analytics POST payload to exceed the max allowed. You should consider a payload size calculator and split the payload up into smaller, more manageable chunks.

Hi @happy-jo We have modified the function app and tested it at our end. It is executing fine.
Please use below URL to deploy the azure function and let us know the output. During deployment please select partition cursor in the cursor type.
Azure Deploy :- https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2FAzure-Sentinel%2Fv-ntripathi%2FOCIColumnLimitFixForIcM352779411%2FSolutions%2FOracle%2520Cloud%2520Infrastructure%2FData%2520Connectors%2Fazuredeploy_OCI_logs_API_FunctionApp.json
Thanks.

Since we have not received a response in the last 5 days, we are closing your issue #4603 as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation.


Having issues enabling phishlets

after typing this command   see what i got below pls i need help
[16:56:47] [inf] enabled phishlet 'outlook'
[16:56:47] [inf] setting up certificates for phishlet 'outlook'...
[16:56:47] [war] failed to load certificate files for phishlet 'outlook', domain 'mttn.net': open /root/.evilginx/crt/mttn.net/outlook.crt: no such file or directory
[16:56:47] [inf] requesting SSL/TLS certificates from LetsEncrypt...
[16:56:49] [!!!] acme: error: 400 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-acct :: urn:ietf:params:acme:error:malformed :: No embedded JWK in JWS header, url:
[16:56:49] [inf] disabled phishlet 'outlook'

i need help too

stuck as well, possible solutions are updating acme, I think, but it didn't work for me, maybe I'm just doing it wrong

just buy a linux online server and run your evilginx from there or i can help you do that

I have ubuntu server but having the same issue

after typing this command see what i got below pls i need help
[16:56:47] [inf] enabled phishlet 'outlook'
[16:56:47] [inf] setting up certificates for phishlet 'outlook'...
[16:56:47] [war] failed to load certificate files for phishlet 'outlook', domain 'mttn.net': open /root/.evilginx/crt/mttn.net/outlook.crt: no such file or directory
[16:56:47] [inf] requesting SSL/TLS certificates from LetsEncrypt...
[16:56:49] [!!!] acme: error: 400 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-acct :: urn:ietf:params:acme:error:malformed :: No embedded JWK in JWS header, url:
[16:56:49] [inf] disabled phishlet 'outlook'

i can help you with the<EMAIL_ADDRESS>

i need help too

i can help you with the<EMAIL_ADDRESS>

i need help too

i can help you with the<EMAIL_ADDRESS>
stuck as well, possible solutions are updating acme, I think, but it didn't work for me, maybe I'm just doing it wrong

i can help you with the<EMAIL_ADDRESS>

i need help too

i can help you with the<EMAIL_ADDRESS>
stuck as well, possible solutions are updating acme, I think, but it didn't work for me, maybe I'm just doing it wrong

i can help you with the<EMAIL_ADDRESS>
I have ubuntu server but having the same issue

i can help you with the<EMAIL_ADDRESS>


[LibraFx specs] Migrating the specifications of the Vector module

The specifications of the Vector module are currently defined in tests/sources/functional/verify_vector.move.
We can move the specs into stdlib/modules/vector.move with changing the pragma flag from intrinsic to opaque.

Still want to do this.


Issues running with ChemProp

Are there any known issues with using ChemProp in the scoring function?
I am running a staged learning run with, now, a single scoring component - ChemProp.
This model is built on roughly ~300k compounds and uses 2d normalization.
I have tested with another model and had no issues, this one did not have 2d normalization.
The process appears to start normally and run the first step, it then seems to hang infinitely producing no output or errors.
The predictions from the model appear to be as expected in the log file.

I understand what the issue is now.
I had to specify one of the models within the chemprop model directory.
for example, you create a model using chemprop - this will actually generate a series of models.
In a normal use case, as per chemprop documentation:
"--checkpoint_dir  Directory where the model checkpoint(s) are saved (i.e. --save_dir during training). This will walk the directory, load all .pt files it finds, and treat the models as an ensemble."
I found that when I specified this top directory it would hang.
If I navigate to a sub-directory i.e. fold_0/model_0 and point to this model directly reinvent seems to run as expected.
I am new to using ChemProp so I am not sure what the convention is here but I will investigate further to understand exactly what I have done.
It would be helpful if the code did not hang in an infinite loop in this case and that it would report some kind of error.
I am using ChemProp 1.5.2 just for your information.

Hi again,
ChemProp can create multiple models if requested.  You can do cross-validation and within each CV fold you can create multiple ensembles.  I do not belief though that this is the default.
Currently we only support --checkpoint_dir to access model files.  As the documentation says it will collect all model files from that directory.  There is not principally a reason to just pick a single model.  Are you sure that the directory you have specified in your "hung" job does not read in a really large number of models and that is why it is just slow?
There is nothing much REINVENT can do about long running subsystems.  It seems that it is ChemProp that is slow.  We cannot guess in advance how long a particular scoring component takes as it may very much depend on the specific setup.
Many thanks,
Hannes

Hi Alex,
your job is stuck somewhere in torch.  Have you tried to reproduce this with chemprop_predict?  What OS is that?
Cheers,
Hannes.

Hi Hannes,
Thanks, yes that at least gives some clue!
I have tried it with chemprop_predict - identical command to that which reinvent runs and it seems to compute many predictions without issue - I tested this on a list of 30k compounds and it ran to completion without issue. I will contact my system administrator and see if this clue helps us get any further and will update you when I can.
Many thanks,
Alex

Hi Hannes,
Small update, some more information.
I have tested the same script on another cluster with different setup and can recreate the hanging issue when submitting to the scheduler.
However, if I run interactively on this alternative cluster it seems to run as normal.
Presumably this points to some resourcing issue which that particular interactive instance gets around. It's a very perculiar issue but steps in the right direction.
Regards,
Alex

Hi Alex,
your job is stuck somewhere in torch. Have you tried to reproduce this with chemprop_predict? What OS is that?
Cheers, Hannes.

RHEL 8.9

Hi Hannes,
Running with the example code provided for an ExternalProcess (for ChemProp) works fine if it is as an ExternalProcess component. I have found no way to get the ChemProp component to work other than using this workaround.
Regards,
Alex

Hi Alex,
there is very little I can do about this issue because I suspect that the issue is specific to your particular setup.  The ExternalProcess is there as a very generic way to run a scoring component and to work around issues that may arise like a scoring component relying on specific library versions and thus needing to run in a separate environment (scikit learn for example seems to break there API at every minor release).
Sorry for that as it is certainly not ideal and less performant,
Hannes.

Hi @Apl0x ,
I encountered the same issue as you. In my case, it hangs indefinitely after step 25.
It seems like you were able to resolve this by using ExternalProcess.
Could you please provide more details on how you implemented that solution?
Regards,
Yuki

Hello,
welcome to the community and many thanks for your interest in REINVENT.
You could try to upgrade ChemProp and see if the issue persists.  We provide an example script in support/run-predict.py which happens to be for ChemProp so may work out-of-the box.
Many thanks,
Hannes.

Hello Hannes,
Thank you for your suggestion.
When I updated chemprop from version 1.5.2 to 1.6.1 using "pip install --upgrade chemprop", the following error occurred, and the generation itself could no longer be executed.

data.reraise()
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/torch/_utils.py", line 461, in reraise
raise exception
RuntimeError: Caught RuntimeError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop
data = fetcher.fetch(index)
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py", line 52, in fetch
return self.collate_fn(data)
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/chemprop/data/data.py", line 839, in construct_molecule_batch
data.batch_graph()  # Forces computation and caching of the BatchMolGraph for the molecules
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/chemprop/data/data.py", line 415, in batch_graph
self._batch_graph = [BatchMolGraph([g[i] for g in mol_graphs]) for i in range(len(mol_graphs[0]))]
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/chemprop/data/data.py", line 415, in
self._batch_graph = [BatchMolGraph([g[i] for g in mol_graphs]) for i in range(len(mol_graphs[0]))]
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/chemprop/features/featurization.py", line 575, in init
self.f_atoms = torch.tensor(f_atoms, dtype=torch.float)
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/torch/cuda/init.py", line 207, in _lazy_init
raise RuntimeError(
RuntimeError: Cannot re-initialize CUDA in forked subprocess. To use CUDA with multiprocessing, you must use the 'spawn' start method
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/miniconda3/envs/reinvent4/bin/reinvent", line 8, in
sys.exit(main())
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/Reinvent.py", line 292, in main
runner(input_config, actual_device, tb_logdir, responder_config)
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/RL/run_staged_learning.py", line 331, in run_staged_learning
with Handler() as handler:
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/handler.py", line 65, in exit
self.save()
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/handler.py", line 107, in save
data = self._callback()
File "/home/miniconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/RL/learning.py", line 184, in get_state_dict
model_dict = self._state_info["agent"].get_save_dict()
KeyError: 'agent'

In my environment, I created comp_chemprop_external.py making it run chemprop inference via subprocess. This allowed me to successfully perform reinforcement learning using chemprop scores without any issues.

We only make use of multiprocessing in Mol2Mol.  Is that the generator you are using?
Regarding the external process, that is not really how you should do it.  The idea would be that you indeed just call the external script and so have a generic method to implement external scoring components without touching the core code.

We only make use of multiprocessing in Mol2Mol. Is that the generator you are using?

I used reinvent pretrained model.

Regarding the external process, that is not really how you should do it. The idea would be that you indeed just call the external script and so have a generic method to implement external scoring components without touching the core code.

You are absolutely right. Initially, I tried scoring with Chemprop using external scoring components, but it didn't work well, so I had no choice but to create a new file as a workaround. Looking back at the code now, it seems that I can perform chemprop inference using external scoring components, so I will attempt to modify it accordingly.

The multiprocessing issue appears to be in ChemProp.  I believe the latest version is 1.7 and 2.0 planned to be released this year.  Maybe 1.7 behaves better but the problem should be reported to them.

First, you could try to force-install version 1.7.  It is a bit odd that a newer version would not run with a newer version of Python.
Second, this is precisely the reason why we have ExternalProcess because in this way you can run the external process e.g. with conda run in the required environment.  The support script actually shows how to do that in the comment at the top.

Hi again,
@yukisoya @Apl0x @txand3r in the meantime we have found some clues as to why ChemProp or really PyTorch hangs.  It may have to do with the way we set up the default device.
Would it be possible for you to share input files with us such that we can try to reproduce the issue on our side, please?
Many thanks,
Hannes.

Hi Hannes,
thank you very much for your continuous testing and verification. I'm glad to hear that you have found some clues to resolve the issue.
What kind of input files would you like us to share with you?

Many thanks.  I can confirm that the multiprocessing issue occurs with version 1.6.1 but not 1.5.2 (which is also in the lock file).  The solution would be to use "spawn" instead of the default "fork" for process creation.  However, I observe a performance penalty of about 4-5 in RL.  So this is not the way to go and it looks to me that the savest way to use ChemProp, esp. newer versions, is to rely on the externall process component.
Why your jobs hang with 1.5.2 I do not know but I would only be able to work on this if I had all inputs (config, ChemProp models, etc), unfortunately, because I have never observed that issues in my line of work.


Single source EXPECT_* macros across RFmx system-level tests.

What does this Pull Request accomplish?

Puts the EXPECT_* macros from the NR tests to a single spot: expect_macros.h
Updates other RFmx system-level tests to use these macros over templated functions

Why should this Pull Request be merged?
Tech debt: AB#1839311
It was pointed out in another review that it would be nice to put the Macros David added to NR in one spot to use across the RFmx system-level tests. The advantage of using the macros for assertions is that when an assert fails it lists the line number of the "call" instead of the assert function line number which makes it easier to track down.
What testing has been done?
Ran and passed all RFmx system-level tests locally.

Passing RFmx tests:
PS C:\dev\reckenro-git\grpc-device\build> .\SystemTestsRunner.exe --gtest_filter=*RFmx*
Note: Google Test filter = *RFmx*
[==========] Running 136 tests from 15 test suites.
[----------] Global test environment set-up.
[----------] 10 tests from NiRFmxBluetoothDriverApiTests
[ RUN      ] NiRFmxBluetoothDriverApiTests.Init_Close_Succeeds
[       OK ] NiRFmxBluetoothDriverApiTests.Init_Close_Succeeds (7173 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.InitializeFromNIRFSA_Close_Succeeds
[       OK ] NiRFmxBluetoothDriverApiTests.InitializeFromNIRFSA_Close_Succeeds (1033 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.AcpBasicFromExample_DataLooksReasonable
[       OK ] NiRFmxBluetoothDriverApiTests.AcpBasicFromExample_DataLooksReasonable (2888 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.TxpBasicFromExample_DataLooksReasonable
[       OK ] NiRFmxBluetoothDriverApiTests.TxpBasicFromExample_DataLooksReasonable (1765 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.ModAccMeasurement_FetchConstellationTrace_ComplexNumberLooksReasonable
[       OK ] NiRFmxBluetoothDriverApiTests.ModAccMeasurement_FetchConstellationTrace_ComplexNumberLooksReasonable (1895 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.SetAttributeInt8_ExpectedError
[       OK ] NiRFmxBluetoothDriverApiTests.SetAttributeInt8_ExpectedError (897 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.SetAttributeInt16_ExpectedError
[       OK ] NiRFmxBluetoothDriverApiTests.SetAttributeInt16_ExpectedError (811 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.SetAndGetAttributeInt32_Succeeds
[       OK ] NiRFmxBluetoothDriverApiTests.SetAndGetAttributeInt32_Succeeds (770 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.ConfigureTwentydBBandwidth_FetchMeasurements_DataLooksReasonable
[       OK ] NiRFmxBluetoothDriverApiTests.ConfigureTwentydBBandwidth_FetchMeasurements_DataLooksReasonable (1937 ms)
[ RUN      ] NiRFmxBluetoothDriverApiTests.BuildSlotString_ReturnsSlotString
[       OK ] NiRFmxBluetoothDriverApiTests.BuildSlotString_ReturnsSlotString (2 ms)
[----------] 10 tests from NiRFmxBluetoothDriverApiTests (19177 ms total)

...TRUNCATING REMAINING PASSING TESTS....

[----------] Global test environment tear-down
[==========] 136 tests from 15 test suites ran. (283242 ms total)
[  PASSED  ] 136 tests.

  YOU HAVE 2 DISABLED TESTS
PS C:\dev\reckenro-git\grpc-device\build>


Lame is not defined

Whether I use cdn or local package I get the following error when instanciating MicRecorder

Any idea how to fix ?

If you share a reproducible issue (for example, on Code Sandbox), I can try to help you.

Closing this for inactivity. I'll reopen in case someone shares a reproducible repo/sandbox etc.

#32 fixes this bug

Hi! why this MR #32 not merge! it is supper important!! @buzinas

@buzinas i have this problem because vitejs doesn't support require()

@nanu-c do we have any fix for that?

npm add --save https://github.com/NikolaBalaban/mic-recorder-to-mp3.git

if use vite you need to define to global variables
define: {     "process.env": env,     global: {},     Lame: {},     Presets: {},     GainAnalysis: {},     QuantizePVT: {},     Quantize: {},     Takehiro: {},     Reservoir: {},     MPEGMode: {},     BitStream: {},   },

Untill admin approves changes, you can use
npm i mic-recorder-to-mp3-fixed
and can be used as:
import MicRecorder from 'mic-recorder-to-mp3-fixed';
I have merged the 32 in this package.
Thanks


[i18n] Add Dutch

I'd like to contribute the dutch language to i18n, since I'm a native dutch person. If this has already been done you can close this issue, if not, I'd gladly add it to valibot! If there is a list of currently supported languages please share it!

That would be great! Have a look at: https://github.com/fabian-hiller/valibot/blob/main/packages/i18n/README.md

Awesome, thanks for the guide

@fabian-hiller The develop branch seems to not have the i18n folder, should I start a PR that merges into main?

I've gone ahead and create one anyways so that it's atleast in git history somewhere haha: https://github.com/fabian-hiller/valibot/pull/438

Yes, please merge into main


 However, we get something more sinister later in the process:
(numpy-2-venv) jk@empire$ python3 -m bio2zarr vcf2zarr explode tests/data/vcf/sample.vcf.gz tmp/x.icf -p0
    Scan: 100%|█████████████████████████████████████████████████████████████████| 1.00/1.00 [00:00<00:00, 52.7files/s]
 Explode: 100%|███████████████████████████████████████████████████████████████████| 9.00/9.00 [00:00<00:00, 429vars/s]
(numpy-2-venv) jk@empire$ python3 -m bio2zarr vcf2zarr encode tmp/x.icf tmp/x.vcz -f -p0
  Encode:  85%|███████████████████████████████████████████████████████████▊          | 792/927 [00:00<00:00, 7.81kB/s]Segmentation fault (core dumped)
(numpy-2-venv) jk@empire$ /usr/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

So, during the encode step we've got a segfault. Digging in to this now.

Hmm, so setting copy=True above resolves this segfault (which appears to happen when accessing the genotype data). So, setting copy=True seems fine and dandy to me - I'm sure the perf difference is negligible.

With #257 we should be basically set for numpy 2.0 and numpy 1.x compatibility. To close this issue we should add a CI job that explicitly installs numpy 2.x and runs the tests. Later, when numpy 2.0 becomes the default thing we install (due to dependencies) we can switch this to 1.x.
We're waiting on numpy 2.0 compatible wheels from msprime, so no point in making this CI job until they arrive.

Just waiting on numpy 2.0 wheels for msprime which should arrive in a few days, and we can then ship a numpy 2.0 compatible version.

This is blocking removal of VCF from sgkit (https://github.com/sgkit-dev/sgkit/pull/1264), since we are using vcztools there  for some compatibility tests and one of the test environments runs on NumPy 2 (https://github.com/sgkit-dev/sgkit/actions/runs/11145218525).
It looks like msprime now has NumPy 2 wheels, so it should be enough to do a bio2zarr release.

I'm slightly reluctant to do a bio2zarr release before having a good look at the local alleles stuff. Can we point sgkit at  the development version of bio2zarr for a while, keeping an issue tracking the fact we need to switch before next release?

Can we point sgkit at the development version of bio2zarr for a while

I managed to do this just for the NumPy GitHub action workflow, so I think we're good here.


GO:0008153 - para-aminobenzoic acid biosynthetic process

should this term exist?
It seems to be just an intermediate in folic acid biosynthesis.
seems to only be used for
Para-aminobenzoate (PABA) synthase
(only 7 EXP annotations)

@amorgat
@deustp01
Do you know of any case where this is an end-product ?
Otherwise do you have any objection to the obsoletion?

Mammals don't make pABA at all; bacteria do and then metabolize it further to synthesize folate, so compounds that inhibit pABA biosynthesis (sulfanilamides) are effective anti-bacterial drugs in humans. That of course makes inhibition of pABA synthesis clinically interesting (hence, probably, the GO term) but doesn't make it an end product. As it's natively a bacterial process, perhaps Jim Hu<EMAIL_ADDRESS>might be a better person to answer your question, rather than evading it.

Sorry for the late reply @pgaudet
It's always a nightmare to define pathways boundaries...
MetaCyc considers Pathway: 4-aminobenzoate biosynthesis
see http://metacyc.ai.sri.com/META/NEW-IMAGE?type=PATHWAY&object=PWY-6543&detail-level=3
Note that para-aminobenzoic acid == 4-aminobenzoic acid
Normalized compounds: para-aminobenzoate  == 4-aminobenzoate
Even this is a short pathway, IMHO, I would keep this GO term
Cheers, Anne

@ValWood I suggest I just add the link to metacyc and we can close this.

Go ahead!


Submitted App Crash, Fine In Simulator

Hi all. Have a successful App Store deployment using the swift 1 branch for several months now, having a serious issue with the latest swift 2 branch (downloaded and installed 9/30/15).
My app was rejected today, my error comes from this line of code:
db = try! Connection(NSSearchPathForDirectoriesInDomains(.CachesDirectory, .UserDomainMask, true)[0] + "/Database/skipcast.sqlite")
This code runs perfectly fine in the simulator and on device, but when packaged for distribution and installed via iTunes (as described here: https://developer.apple.com/library/ios/qa/qa1764/_index.html), we get an instant crash with the stack trace of:
0   libswiftCore.dylib            	0x000000010128d928 0x10114c000 + 1317160
1   libswiftCore.dylib            	0x000000010128d928 0x10114c000 + 1317160
2   libswiftCore.dylib            	0x00000001011a6990 0x10114c000 + 371088
3   SkipCast                      	0x00000001002555b8 db.unsafeMutableAddressor (AppDelegate.swift:0)
4   libdispatch.dylib             	0x000000019ba39770 _dispatch_client_callout + 16
5   libdispatch.dylib             	0x000000019ba3a5b4 dispatch_once_f + 80
6   SkipCast                      	0x00000001002555e4 db.unsafeMutableAddressor (AppDelegate.swift:0)
7   SkipCast                      	0x000000010027dd38 AudioLibraryCore.initDatabase() -> () (AudioLibraryCore.swift:257)
The line at 257 relates to the swift code above.
The try block seems to return this error message:
SkipCast[4153] : fatal error: 'try!' expression unexpectedly raised an error: unable to open database file: file /Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-700.0.59/src/swift/stdlib/public/core/ErrorType.swift, line 50
Code above this checks for the existence of the database file, so I know it's present.
Again, this code was, prior to swift 2, running fine, and also runs just fine on the simulator and on device. It's when submitting to the App Store and when installing the .ipa via iTunes (to simulate an app store submission), that the process fails.
I'm desperate for ideas, anyone have any suggestions?

Allow me to answer my own question. Turns out I left a database connection call in AppDelegate. As the database file wasn't present on first launch, this was causing the crash. Removing the call fixed the problem.
As a brief aside, this link has helped me a great deal, I wish I had known about this sooner: https://developer.apple.com/library/ios/qa/qa1764/_index.html
My apologies for the hub bub. Go SkipCast!

Glad you got things sorted!

@MattGrdinic I am also facing the above issue,
init(){
let path = NSSearchPathForDirectoriesInDomains(
.DocumentDirectory, .UserDomainMask, true
).first
    DataManager.con = try! Connection("\(path)/db.sqlite3")

}

this is my code and I am getting the same error :(

Hi Vin, so this was caused by my invocation.
In the move to Swift 2 I had some test code that was attempting to connect to the database in AppDelegate. Problem: the database file, by definition, does not exists yet on first launch in that location (in the caches folder). It's only after my database class loads do I move the database file from the bundle to its proper place. Then I can connect to it just fine.
What's strange is on a clean/brand new simulator install this was never a problem, it was only in the AppStore build that it would crash. Not sure why.
The solution, in my case, was to comment out the test code. As soon as I did problem solved. I will say this though: I perform loads of database queries in my code, and the stack trace I got from this issue, as we can see above, made it seem like something else was at play -- not a simple case of missing database file. To further complicate matters I didn't have an easy way to debug an app store build.
But in the end, that's all it was, a bad database file location. Boring : )
Finally, as noted in my original post, the process outlines here is invaluable: https://developer.apple.com/library/ios/qa/qa1764/_index.html.
Good luck, and please keep us posted!


DL predictor for both ad requests and impressions

Dears,
we have a requirement to use DL predictor to predict both ad requests and impressions in parallel and save the predictions of impressions and ad-requests into different output tables and elastic search indexes.  Can we discuss this feasibility today ?
is it possible to organize a meeting before Thursday's weekly meeting?

You need 2 pipelines to build 2 different models to predict each item.

DLPredictor Impression Pipeline
DLPredictor Request Pipeline

These pipelines are almost identical; the differences can me on

Different active modules, For example, the Request Pipeline has a transform module that modifies the schema of the Request Table so that it can be processed by existing modules; adding price-category and bucket-ids
Configuration; different input tables, pipeline tags and etc.


Support for Swagger to generate and expose API documentation?

Hi,
I found this project and it looks really promising, however in my case it is really important to have Swagger / Swagger explorer on the gateway.
Is there any plan for supporting that? You can easily add swagger to each microservice using: https://github.com/domaindrivendev/Swashbuckle.AspNetCore
All what Ocelot would have to do is to consume the swagger.json from each microservice and expose it as one?

@murbanowicz swagger support would be great! This is an open source project so you can fork and build it yourself! I will happily merge into master!! I will do this myself eventually but it’s quite complicated because Ocelot can change its configuration will running which means swagger would also need updating!

How to work on it?
I have never developed Nuget package so don't know how to start and test it as I would need some simple service/s connected to develop it and test.

@murbanowicz I'm not sure :)
It's quite hard. I don't know much about swagger but I think you create a swagger.json file and then swagger uses that to load the documentation.
This means ocelot would need to generate that file based on the users configuration which could be done on init from either the configuration.json or consul (if using that feature). However whenever the configuration changed either via the administration api or directly in consul then we would need to regenerate the swagger.json file.
Questions..

Does swagger looks at the swagger.json file each time it loads of the docs or only the first time. If it is the first time then we might be screwed because changes wouldn't work.
Do I even know what i

@TomPallister  @murbanowicz
This sounds like an interesting feature.
The way swagger works is, on the application's start it scans the controllers and their methods and creates the swagger.json file.
When you access the swagger UI, its just a javascript app that retrieves that swagger.json and creates UI elements according to instructions in that json. It recreates the UI each time you load the page, or hit the explore button.
In order for this to work, Ocelot would need to fetch and merge swagger.json files from various downstream services on demand, at a specific endpoint, but it would also need to tamper them if the upstream template differs from the downstream template. The swagger spec of the downstream service would not work on Ocelot's swagger UI if there is some different mapping in the Ocelot reroute.

ohh I've misunderstood this. I thought the issue was to create swagger.json from the Ocelot configuration in configuration.json or consul.
Looking at downstream services and making one is quite complicated! I think that might be a feature for long term future!

I think this feature is to complicated to implement in a non crappy way.
The best thing to do is probably have a user make their own swagger.json (however they want) and then use the MapWhen functionality of the app builder to direct people to the swagger endpoint using the swashbuckle package.

It's not a simple parse from configuration.json to swagger.json?

@jefferson yes if all of your routes are defined! What if you have /{everything} :(
Any suggestions would be appreciated! Maybe we could just do a best effort!

Ive had another look at it this morning on the train to work...I think I can get something working low effort so will do that and see how it is!

OK so I have looked multiple times at building swagger.json out of the Ocelot configuration.json but it doesnt fit into the vision I have for Ocelot. If you would like to have Swagger in Ocelot then you can roll your own swagger.json and do the following in your Startup.cs or Program.cs. The code sample below registers a piece of middleware that loads your hand rolled swagger.json and returns it on /swagger/v1/swagger.json. It then registers the SwaggerUI middleware from Swashbuckle.AspNetCore
    app.Map("/swagger/v1/swagger.json", b =>
    {
        b.Run(async x => {
            var json = File.ReadAllText("swagger.json");
            await x.Response.WriteAsync(json);
        });
    });
    app.UseSwaggerUI(c =>
    {
        c.SwaggerEndpoint("/swagger/v1/swagger.json", "Ocelot");
    });

    app.UseOcelot().Wait();

The main reasons why I don't think Swagger makes sense is we already hand roll our definition in configuration.json. If we want people developing against Ocelot to be able to see what routes are available then either share the configuration.json with them (This should be as easy as granting access to a repo etc) or use the Ocelot administration API so that they can query Ocelot for the configuration.
In addition to this many people will configure Ocelot to proxy all traffic like /products/{everything} to their product service and you would not be describing what is actually available if you parsed this and turned it into a Swagger path. Also Ocelot has no concept of the models that the downstream services can return and linking to the above problem the same endpoint can return multiple models. Ocelot does not know what models might be used in POST, PUT etc so it all gets a bit messy and finally the Swashbuckle package doesnt reload swagger.json if it changes during runtime. Ocelot's configuration can change during runtime so the Swagger and Ocelot information would not match. Unless I rolled my own Swagger implementation.
If the user wants something to easily test against the Ocelot API then I suggest using Postman as a simple way to do this. It might even be possible to write something that maps configuration.json to the postman json spec. However I don't intend to do this.
I am really sorry to everyone who wanted this feature and hope they understand why Ocelot won't be supporting it at the moment. If anyone else would like to take them up then they are welcome but I am going to close the issue for now and have written up my thoughts in the Not Supported section of Ocelot docs.

Hi Tom,
I have read your reasons for not supporting swagger, and not going to argue ;-)
But the main reason we use swagger is not so much for the swagger doc and UI - though this is helpful - its mainly for being able to generate clients ( both c# and javascript ) as part of our build process.
is there an Ocelot'y way to do this ?

@TimJarvis thanks for your interest in the project. There isn’t currently a way to generate a client from an Ocelot config.
Again the main problem is going to be the lack of types so client wouldn’t know what it needs to post or what it is going to get. It might be possible to do it with JS / dynamics in C#.
Microsoft have just been exposing the services swagger endpoints via Ocelot if that helps!

@TomPallister thank you for a great project.
For our  is very important to have a documentation for our API.
I've created a package that covers our scenarios MMLib.SwaggerForOcelot.
The idea is as follows:
In the first step, it is necessary to define a Swagger generator in downstream services. Next, in the API Gateway project, we define SwaggerUI to display interactive Swagger documentation.

This package also adds middleware that modifies swagger.json from downstream services under ocelot.json.
I currently support our use case, where Ocelot is mainly used as a reverse proxy. So, in ocelot.json we have projects/{everything}.
I would also like to support other scenarios. I would like to ask if anyone can provide a more comprehensive ocelot.json configuration for inspiration?
Thanks.

@Burgyn I submitted a PR to make a replace on swagger better with JObject.
@TomPallister On this aproach just make a new swagger downStream Based with rules on configuration.json is more easy to expose downStreamSwagger configuration. and easy to expose swaggerUI and capapacities of Gateway Services.
Sry for my poor english.

is it working? any example please?


Multiple failures when building with Intel CL on Windows

Multiple failures are observed when building simple code with Intel CL. All of them are related to SIMDE_ALIGN_TO* macros which apparently end up undefined. The same code gets built fine with Clang >= 11, any ICX version, or latest MSVC.

I don't really have a good way to reproduce this at the moment so it might be a while before this gets fixed, but if you're interested in putting something together it should be pretty straightforward, and I'd be happy to merge it. In simde-align.h you would just need to add checks using HEDLEY_INTEL_CL_VERSION_CHECK(major, minor, revision) in a couple locations (searching for MSVC should help).  The syntax should be similar to MSVC, though I suspect the implementation will be somewhat less limited (I doubt you'll need to define SIMDE_ALIGN_PLATFORM_MAXIMUM).


Supporting safe_open for TF and Flax.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Release file can't be built due to lack of .git

When checking out out git repository and building odftoolkit with maven install it could be built successfully.  However if I download the release file from https://github.com/tdf/odftoolkit/releases/download/v0.12.0/odftoolkit-0.12.0-src.zip it couldn't be built because lack of .git

Hello Franklin,
I am not able to reproduce the problem you are facing.
What exactly was the command that you have executed within the project
directory?
Could you pipe your logout like:
mvn clean install > log.txt 2>&1
Depending if you are on Linux or Unix, I usually place the log in the
parent directory ../log.txt or ..\log.txt
You might send the log directly to me - in case the file structure reveals
any sensitive information.
Best regards,
Svante
On Wed, 24 Jan 2024 at 06:39, Franklin Weng @.***>
wrote:

When checking out out git repository and building odftoolkit with maven
install it could be built successfully. However if I download the release
file from
https://github.com/tdf/odftoolkit/releases/download/v0.12.0/odftoolkit-0.12.0-src.zip
it couldn't be built because lack of .git
Screenshot-2024-01-24-13-21-19.png (view on web)
https://github.com/tdf/odftoolkit/assets/1000315/cc43fe61-ea3b-4978-8a90-936f14df9d5f
—
Reply to this email directly, view it on GitHub
https://github.com/tdf/odftoolkit/issues/276, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGJNW3K7MLFDNRSSF4TX3DYQCNBBAVCNFSM6AAAAABCIE7KE6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TONBWGU3TCOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm using Ubuntu 22.04 and openjdk-11 and maven from Ubuntu repository.
I unzipped the src zip file, enter it and build it with mvn install > log.txt 2>&1
The log is here:
log.txt
The previous four lines are the output of ls -a of that folder.  You can see there is only .github but no .git in there.

Thanks for your log, Franklin!
Now I understood that you unzipped and build the following ZIP:
https://repo1.maven.org/maven2/org/odftoolkit/odftoolkit/0.12.0/odftoolkit-0.12.0-source-release.zip
Michael provided a patch that inserts a line in the pom.xml of ODFDOM and ODF Validator to build even if there is not .git available. We use the latest git version as a label for the manifest within the JAR, so the latest GIT commit is part of the version to be accessed by the command line and/or Java API.
I have done a maven SNAPSHOT release (by mvn deploy) but there is unfortunately no update on the ODF TOOLKIT src zip, as it seems not to be part of a SNAPSHOT release - we might take a look into this later.
You might need to insert the line yourself in the pom. xml of ODFDOM and ODF Validator, see https://github.com/tdf/odftoolkit/commit/abed4a4c6163c8110b08089f7bc8d8a2b4c2e820
Thanks for bringing this up!
Svante


GUI : Network Setting : Add test case to check in MAC and default gateway fields are editable.

GUI : Network Setting : Add test case to check in MAC and default gateway fields are editable.

https://gerrit.openbmc-project.xyz/#/c/11160/


file upload is not returning from page load

I am using the example on wave 0.13.0 https://h2oai.github.io/wave/docs/examples/file-upload/
The site keep loading forever on file upload and never comes back

@coolksrini Can you provide additional info on your browser/env/OS? Does the example work for you when you run it as wave run examples/file_upload.py?

@lo5 Here is my env:
Browser: Google Chrome
OS: Windows Server 2016
I tried both  wave run file_upload and wave run examples/file_upload.py and still the same result. There is a loading message after upload.


Fix flappy integration test

This PR fixes two issues:

[x] A race condition where a test completes and times out at the same time: this is fixed by breaking out the event-loop early after a time out.
[x] Start running the test before the SUT is ready: fixed by waiting for an initial ping from the SUT.

Test's pass locally on both go and node:
ringpop-go:
make test-integration
test/run-integration-tests
[fetch ringpop-common] + cd test/ringpop-common
[fetch ringpop-common] + git fetch origin fix-flappy
[build testpop] + make testpop
[build testpop] rm -f testpop
[build testpop] go build ./scripts/testpop/
[fetch ringpop-common] From ssh://github.com/uber/ringpop-common
[fetch ringpop-common]  * branch            fix-flappy -> FETCH_HEAD
[fetch ringpop-common] + git checkout FETCH_HEAD
[fetch ringpop-common] Previous HEAD position was 4e35f91... wait for first ping in prepare cluster
[fetch ringpop-common] HEAD is now at 0209af7... Don’t conumse initial ping
[fetch ringpop-common] + cd -
[fetch ringpop-common] + cd test/ringpop-common/test
[fetch ringpop-common] + cd -
[test-runner] Running test for cluster size 1...
[test-runner] Running test for cluster size 2...
[test-runner] Running test for cluster size 3...
[test-runner] Running test for cluster size 4...
[test-runner] Running test for cluster size 5...
[test-runner] Running test for cluster size 10...
Tests passed

ringpop-node
npm run test-shared-integration-tests

><EMAIL_ADDRESS>test-shared-integration-tests /Users/menno/Sources/Uber/nodejs/ringpop-node
> test/run-shared-integration-tests

[fetch ringpop-common] + cd test/ringpop-common
[fetch ringpop-common] + git fetch origin fix-flappy
[fetch ringpop-common] From ssh://github.com/uber/ringpop-common
[fetch ringpop-common]  * branch            fix-flappy -> FETCH_HEAD
[fetch ringpop-common] + git checkout FETCH_HEAD
[fetch ringpop-common] Previous HEAD position was 4e35f91... wait for first ping in prepare cluster
[fetch ringpop-common] HEAD is now at 0209af7... Don’t conumse initial ping
[fetch ringpop-common] + cd -
[fetch ringpop-common] + cd test/ringpop-common/test
[fetch ringpop-common] + npm install
[fetch ringpop-common] npm WARN package.json<EMAIL_ADDRESS>No license field.
[fetch ringpop-common] + cd -
[test-runner] Running test for cluster size 1...
[test-runner] Running test for cluster size 2...
[test-runner] Running test for cluster size 3...
[test-runner] Running test for cluster size 4...
[test-runner] Running test for cluster size 5...
[test-runner] Running test for cluster size 10...
Tests passed

LGTM

Nice find on the bug in the lookup function of the test coordinator, fix is legit.

Looks good!


Add click to move cursor to textfields on desktop platforms

On platforms which use a mouse/pointer, users should be able to click anywhere in a text field with text to move the cursor to that point.
Possibly related bug:
I have an issue selecting a single character with a pointer. It seems the selection only happens when the mouse is clicked and dragged across 2+ characters

Should be fixed by #37969, repurposing issue to be about selecting one character

@guidezpl  I can't reproduce this issue on the master branch, could you provide reproducible steps?

Nice, this was fixed. Closing