chore: Only validate against major version of markdownlint

There is no reason to lock markdownlint to a minor version. This just
causes friction when updating the image.

Can you add some context to this change?

@bendiknesbo I updated the PR message.


Min, Max validation rule for string fields

Hello,
I am validating a document which has string fields with min max rules
doc = {"a": "1000"}
schema = {"a":{"min":1,"max":100}}
validating this doc always returns True
shouldn't this error out if the value is a string? (when min,max rules are being applied).
or may be convert the value to integer and then apply the rule? (may not be desired always I guess)
Thanks.

you can compare strings and integers in Python, see:

http://docs.python-cerberus.org/en/latest/validation-rules.html#min-max
http://docs.python-cerberus.org/en/latest/validation-rules.html#type
http://docs.python-cerberus.org/en/latest/normalization-rules.html#value-coercion

Thanks @funkyfuture .
coerce is what I needed, Thanks.


Fix minor typo in live directive paragraph

Fixing a minor typo in the live directive description. Changed agains to against.
PS - When doing a search across files, I saw that there are two more instances of the typo (below). However, I wasn't sure how to rebuild these. I tried running npm run build from /packages/lit-dev-api/package.json but it didn't seem to work. I can gladly update this PR if I can get some guidance on how to do so!

/packages/lit-dev-api/api-data/lit-2/pages.json
/packages/lit-dev-api/api-data/lit-html-1/pages.json

Thanks for the catch! These pages are actually generated from the source code (current docs from the main branch, 1.x docs from the lit-html-1.x branch):
https://github.com/lit/lit/blob/main/packages/lit-html/src/directives/live.ts#L86
https://github.com/lit/lit/blob/lit-html-1.x/src/directives/live.ts#L33
Do you want to make PRs against the lit repo? If that's too much work, let me know.

Thanks for the fix!


Connection Timeout issue after Enabling DFU Mode

Hi
I am facing a connection timeout issue. It seems after Enabling the DFU Mode, it fails to connect again. I tried using the nrfConnect app, the firmware seems to have no issues with it. I found ConnectionTimer in DFUPeripheral.swift class. Is there any way to increase the time from 10 Seconds to at least 30 seconds?
I am using the latest version of the DFULibrary, Xcode version is 11.1 and testing it on iOS 13.4.1.
Any help would be appreciated. Thanks in advance.

Creating another connection timer really helped me out.

Option to set connection timer will be added in 4.8.0, release ongoing.

Implemented in #374.


Initial commit of Simon's algorithm notebook

New notebook, new circuit diagram generated in LaTeX.

@christianbmadsen - Thanks for the input. The index/ToC has been added. The notebook benefits from running on noiseless simulators. Running on hardware can be added, but additional processing to handle noise and other failure modes would need to be added, which would complicate the notebook and detract from the pedagogy.

@christianbmadsen - Thanks for the input. The index/ToC has been added. The notebook benefits from running on noiseless simulators. Running on hardware can be added, but additional processing to handle noise and other failure modes would need to be added, which would complicate the notebook and detract from the pedagogy.

@gsalton thank you for the revision. Just as a last nit - could you make the index/ToC a bullet list instead of a numerated list? Could you also ensure that the title in index/ToC matches the section heading - right now it for instance says "Implementing the Classical Post-Processing" in the index/ToC but "Classical post-processing" in the appendix section. Thanks!

@christianbmadsen Great suggestions. Done


Australian Specific law for Low Value Fixed Assets

Hello Team
Can you please share how we can setup the attached Australian law requirement for LowValue FA? https://www.ato.gov.au/Business/Depreciation-and-capital-expenses-and-allowances/General-depreciation-rules---capital-allowances/Low-value-assets-(pool)/
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4407032-3ab2-06cc-d994-064a0d982d87
Version Independent ID: 76cf6594-a1c6-c456-5c1a-26b5791663a5
Content: Depreciation Methods - Business Central
Content Source: business-central/fa-depreciation-methods.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: edupont

Hello,
Thank you for your feedback. Since your question is not about the Help, we suggest that you submit a feature request here: https://aka.ms/businesscentralfeedback


Bug: How to avoid hitting external IP quota

And what is creating so many of them? And why are they not being destroyed when whatever is using them is destroyed?

For now, I've included instructions about how to request quota increases if quotas are hit. We'll see if this is sufficient in the next batch.


Does not work in app where newer(5.0+) System.identityModel.tokens.jwt.dll is referenced

My project has 5.+ version of system.identitymodel.tokens.jwt.dll referenced because of some other components used. The WSFederation library gives errors saying some types are not found.

@Chris, I have been able to work around this issue by changing your code to not use the methods/types from the JWT dll. Do you think I should submit a PR if it is ok with you?

Sure, I'll look at it.


Skip Files not working after initial attempt at stepping into skipped code

Testing #19096
Below are the 2 typescript files in my workspace and my launch.json

As you can see I have listed hello.ts as a skipped file.
Now with the greetings.ts as the file in the active editor, I hit F5.

Breakpoint is hit
Step in
Callstack shows sayHello and is greyed out
Step Over

I expect to go to the next line (line 5) in greetings.ts, but every step over actually goes thru each line in the hello.ts which was supposed to be skipped.
Call stack shows sayHello greyed out but like line numbers incrementing with each step over

node-debug does not yet support to skip non-JavaScript source files, e.g. TypeScript.

This works now with the new js-debug.


Publish the packages artifact.

@scbedd this is a quick change to the publishing logic for the Python pipelines. At this point its a duplicated publish but I want to get these artifacts consistent with the rest of the unified pipelines in terms of the artifact name that we publish to. However I didn't want to break the existing release pipeline just ahead of release day - therefore I am publishing the artifacts twice.
The good news is that it should be pretty close to a no-op due to deduplication. Once we are past release we can address this duplication / inconsistency. I'm just going through making sure everything is locked down for release.

Can one of the admins verify this patch?

/azp run python - appconfiguration

/cc @Azure/azure-sdk-eng  letting folks know about using my admin rights to merge this change.


Db.save inside a transaction fails if DocumentQuery.searchable is specified before

The following test fails:
test "documents save within a transaction" do
    res = transaction fn(tx) ->
      Moebius.DocumentQuery.db(:monkies) |> Moebius.DocumentQuery.searchable([:name]) |> TestDb.save(%{name: "Mike"}, tx)
    end
    case res do
      {:error, _err} -> flunk "No errors here!"
      res -> assert res
    end
 end

The error code etc would be helpful.

1) test documents save within a transaction (Moebius.TransactionTest)
     test/moebius/transaction_test.exs:52
     ** (exit) exited in: :gen_server.call(TestDb, {:checkout, #Reference<<IP_ADDRESS>6>, true, 5000}, 5000)
         ** (EXIT) time out
     stacktrace:
       (db_connection) lib/db_connection/connection.ex:43: DBConnection.Connection.checkout/2
       (db_connection) lib/db_connection.ex:811: DBConnection.checkout/2
       (db_connection) lib/db_connection.ex:717: DBConnection.run/3
       (db_connection) lib/db_connection.ex:957: DBConnection.run_meter/3
       (db_connection) lib/db_connection.ex:421: DBConnection.query/4
       (postgrex) lib/postgrex.ex:111: Postgrex.query/4
       (moebius) lib/moebius/database.ex:236: Moebius.Database.execute/1
       lib/moebius/database.ex:220: TestDb.update_search/2
       lib/moebius/database.ex:170: TestDb.handle_save_result/3
       lib/moebius/database.ex:134: TestDb.save/3
       test/moebius/transaction_test.exs:54: anonymous fn/1 in Moebius.TransactionTest.test documents save within a transaction/1
       (db_connection) lib/db_connection.ex:1079: DBConnection.transaction_run/4
       (db_connection) lib/db_connection.ex:1009: DBConnection.run_begin/3
       (db_connection) lib/db_connection.ex:766: DBConnection.transaction/3
       lib/moebius/database.ex:109: TestDb.transaction/1
       test/moebius/transaction_test.exs:53

Yep - I see it. A timeout is happening because the transaction is still open, and we're running a separate query to update the search columns without that transaction being passed along. It looks like we need an additional function head here:
https://github.com/robconery/moebius/blob/master/lib/moebius/database.ex#L170
To handle the case when a transaction pid (conn) is passed in. I don't have time to get to this, but if you wanted to PR that would be super super helpful :).

Sure, will do.


Corrected CIFAR for GPU display

There was an error where you missed to add GPU support in final result view. I have added support for that.

LGTM

@cezannec


Chroma adapter for Kernel Memory

Motivation and Context (Why the change? What's the scenario?)
Allow to store Kernel Memory memories in Chroma

Closing for now, postponed to future


Some guidance to enable NRT for library that is compatible with .NET and .NET Framework

I search some guidance to enable NRT (nullable reference type) in my library, but I found nothing in Library guidance.
I found this blog post Embracing nullable reference types that have guidance, but it is from 2019. This is old and this guidance can be obsolete.

I would love to see a guidance in the doc to explain how enable NRT in a library that need to be compatible with .NET Framework and .NET.
If the below blog post is still relevant, I can help and make a PR.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b466e1d8-f9fc-6a4b-50a3-a101e5ea9907
Version Independent ID: ccf98d0b-d65c-522a-a944-e58d60adbee8
Content: Get started creating high-quality .NET libraries - .NET
Content Source: docs/standard/library-guidance/get-started.md
Product: dotnet-fundamentals
GitHub Login: @JamesNK
Microsoft Alias: jamesnk

For information, I found this blog post :
How to use Nullable Reference Types in .NET Standard 2.0 and .NET Framework
It answers all my questions.


Created matrixTranspose.java

I made a java program to transpose a matrix of any given order.

We only do Hello Worlds here.


Ask before creating a new fork if one already exsists

This way scripts for example wouldn't be given the chance to wreck your PR, because you can just say no to overwriting your existing branch.

Hi I don't understand what you're asking here. Could you elaborate more and what workflow do you intend to solve with a proposed change? Maybe with examples?
Sorry for the late reply.

When running hub fork when you have a existing forked branch on github, hub just overwrites the github branch, therefore removing any pushed commits.

What does it mean that hub just overwrites the github branch? Which branch gets overwritten? hub fork doesn't push any commits to a remote and doesn't deal with branches at all. Plus, when your fork already exists, hub fork does nothing but ensure that the git remote is set up correctly.

@TheDoctorsLife I didn't understand your initial problem; do you perhaps have more information for me to treat this as a bug? I'd really like to fix things if hub fork can lead to loss of information. But right now, I can't see how that can happen, since an existing fork on GitHub never gets overwritten by a new one.

What I had happening to me, is if I used hub fork it would appear to delete the existing and replace it with the local copy.

it would appear to delete the existing and replace it with the local copy.

Hub can never delete an existing repository on GitHub.com, not even a fork. It doesn't have any functionality that is able to delete or replace a repository. It can only create new ones.
Can you reproduce your problem? Would you share exact steps you've taken so I might try for myself?

I tried it out again, (was in a script) and the bug/issue I was experiencing appears to be gone. Closing issue.

@TheDoctorsLife Thanks for the update! 👍


Add some missing tests to the payments endpoint

Fixes Presslabs/silver#341

@t-ionut this one needs a rebase.


Improve Tag Selection

Is your feature request related to a problem? Please describe.
Selecting tags during result upload can be tedious when the tag list becomes longer.
Describe the solution you'd like

Alphabetically sorted tag list
Improve selection mechanism by turning list elements (tags) into checkboxes
Some kind of filter mechanism for the tag list

Since eedf272 the tag list is sorted alphabetically.

Due to time constraints and this being a rather low-priority enhancement, I was only able to implement the first task (alphabetically sorted tag list).
For anyone who wants to implement the remaining tasks: the tag list is created here https://github.com/EOSC-synergy/eosc-perf/blob/d1a4dee228d01a40838543530b4f52b5da6c14a6/templates/upload.html#L53-L55 and filled here: https://github.com/EOSC-synergy/eosc-perf/blob/c57b7a95e220db46d52666fc80ef41a7242ea29e/static/scripts/view/upload.js#L165-L176

The multi-selection system has been improved as of 04fb3b2f508e6dc2761040cadc1bec841dc614be. I will open a separate issue for tag search.


Custom getty systemd unit is generated with errors on unstable

Describe the bug
A change after 21.05 breaks a systemd service unit I use to override getty for a single tty. It seems to be caused by a change in how systemd units are processed in general, services built with unstable nix come with erroneous Exec lines and are called drop-in override.conf.
<EMAIL_ADDRESS>= "Autologin at the TTY1";
<EMAIL_ADDRESS>= [ "systemd-logind.service" ];
<EMAIL_ADDRESS>= [ "multi-user.target" ];
<EMAIL_ADDRESS>=
{ ExecStart = [
    ""  # override upstream default with an empty ExecStart
<EMAIL_ADDRESS>agetty --login-program ${pkgs.shadow}/bin/login --autologin nixos --noclear %I $TERM"
  ];
  Restart = "always";
  Type = "idle";
};

Steps To Reproduce
Steps to reproduce the behavior:

Add the code snippet above to configuration.nix on unstable.
nixos-rebuild boot
Reboot.

Expected behavior
On 21.05 the service causes the user nixos to be automatically logged in on tty1 after boot or logging out, while other ttys function as normal.
Additional context
I've written about the testing I did here.
The problem seems to be that unstable generates an exec line containing /nix/store/3srhn7p8d5h7w2jz19nz75qvqbwc76ln-shadow-4.8.1/bin/login -- "" "" "" "" "" "" while 21.05 generates an exec line containing /nix/store/61z6l8p3f14hgz29j607bg1d37sn5d86-shadow-4.8.1/bin/login -f
The issue is easy to reproduce in a virtual machine with a minimal configuration.nix (that information is in the discourse).
Notify maintainers

@andir @Mic92
You two are listed on this commit, which touched a number of files affecting systemd (including the getty service). I don't actually understand the code committed, so please don't take offence if it's an unrelated change, it simply stood out to me as a likely culprit since it too adds an autovt@ service.
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.69, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.15`
 - channels(root): `"nixos-21.11pre319562.c21ba4f7bb4"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/unstable-channel-breaks-systemd-automatic-login-service/15291/7

I've got the same issue with NixOS 21.11.

As a workaround for the autologin issue, I wrote the following configuration (tested on NixOS 21.11):
{ pkgs }:
let
  script = pkgs.writeText "login-program.sh" ''
    if [[ "$(tty)" == '/dev/tty1' ]]; then
      ${pkgs.shadow}/bin/login -f some-user;
    else
      ${pkgs.shadow}/bin/login;
    fi
  '';
in
  {
    getty = {
      loginProgram = "${pkgs.bash}/bin/sh";
      loginOptions = toString script;
      extraArgs = [ "--skip-login" ];
    };
  }

I did give this a try. But no matter how I would create a new "autovt@ttyN" unit, the upstream's "autovt@" would enter and take precedence as a "Drop-In". @Jethril answer works because it enters a special case creating an override.conf to the upstream's "autovt@".
Maybe someone in @NixOS/systemd will know better how to handle this.


FEAT-#3123: Add trino/impala partition SQL

Signed-off-by: taylorhere<EMAIL_ADDRESS>
What do these changes do?

[x] commit message follows format outlined here
[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #3123 ?
[ ] tests added and passing
[ ] module layout described at docs/developer/architecture.rst is up-to-date

I already test it on my impala cluster, this can be used like
pd.read_sql(
    """
    select *
    from some_table
    limit 1000
    """,
    'impala://some_impala_url',
    params={'order': 'some_order_col'}
)

for trino, we should wait trino fix sqlalchemy dialects issue @https://github.com/trinodb/trino-python-client/issues/13

Hi @TaylorHere thanks for the PR! I went ahead and started the CI build.
It looks like a test is failing in i/o, specifically:
    @classmethod
    def _read(cls, sql, con, index_col=None, **kwargs):
        """
        Read a SQL query or database table into a query compiler.

        Parameters
        ----------
        sql : str or SQLAlchemy Selectable (select or text object)
            SQL query to be executed or a table name.
        con : SQLAlchemy connectable, str, or sqlite3 connection
            Connection object to database.
        index_col : str or list of str, optional
            Column(s) to set as index(MultiIndex).
        **kwargs : dict
            Parameters to pass into `pandas.read_sql` function.

        Returns
        -------
        BaseQueryCompiler
            Query compiler with imported data for further processing.
        """
        try:
            import psycopg2 as pg

            if isinstance(con, pg.extensions.connection):
                con =<EMAIL_ADDRESS> # Table in DB
                    con.info.user,  # <Username>: for DB
                    con.info.password,  # Password for DB
                    con.info.host if con.info.host != "/tmp" else "",  # @<Hostname>
                    (":" + str(con.info.port))
                    if con.info.host != "/tmp"
                    else "",  # <port>
                    con.info.dbname,  # Table in DB
                )
        except ImportError:
            pass
        # In the case that we are given a SQLAlchemy Connection or Engine, the objects
        # are not pickleable. We have to convert it to the URL string and connect from
        # each of the workers.
        if not isinstance(con, str):
            warnings.warn(
                "To use parallel implementation of `read_sql`, pass the sqlalchemy"
                "connection string instead of {}.".format(type(con))
            )
            return cls.single_worker_read(sql, con=con, index_col=index_col, **kwargs)
        row_cnt_query = "SELECT COUNT(*) FROM ({}) as foo".format(sql)
        row_cnt = pandas.read_sql(row_cnt_query, con).squeeze()
        cols_names_df = pandas.read_sql(
            "SELECT * FROM ({}) as foo LIMIT 0".format(sql), con, index_col=index_col
        )
        cols_names = cols_names_df.columns
        num_partitions = NPartitions.get()
        partition_ids = []
        index_ids = []
        dtype_ids = []
        limit = math.ceil(row_cnt / num_partitions)
>       order = kwargs.get("params", {}).get("order", None) if kwargs else None
E       AttributeError: 'NoneType' object has no attribute 'get'

You can see more in the Checks tab

I already fix that, but I was baffled by hot to add tests, this feature need a working Impala or trino system to be tested.

I already fix that, but I was baffled by hot to add tests, this feature need a working Impala or trino system to be tested.

Thanks for fixing! I am not sure how we can test in GitHub Actions. @gshimansky Do you have any ideas about testing for Impala? Would it be possible in TeamCity?

I tested trino with PyHive, https://github.com/dropbox/PyHive, which is working on my trino system.

thx for your work.

@TaylorHere, @devin-petersohn, what is the status here?


Add a category which is completely ignored.

I want that some fragments are completely ignored and not even mentioned as Misc
For a close source product release notes there is no value in having all kind of refactoring ticket ids in the Misc category.
So I have created an ".ignore" category.
Here is my patch https://github.com/chevah/towncrier/commit/f9b3c4a4390991384abe270a4eee904c30fb2137
Not sure if this is useful for other. I just thought to make my use case public :)
Thanks!

With the new support for template and showcontent you can create a custom template which will completely ignore a section


macOS: How to request microphone access?

Question
Why won't Java ask for Microphone access?  How does one package a Java application so that will properly ask for permission to use the microphone?
Please see the following unit test: https://github.com/tresf/SoundRecorder.

Test
Pass/Fail
Details

Terminal
:white_check_mark:  PASS
javac SoundRecorder.java &&  java SoundRecorder, from Terminal, it works.  Reset with: sudo tccutil reset Microphone com.apple.Terminal

IntelliJ
:white_check_mark:  PASS
From the Project Explorer, Right Click SoundRecorder.java, Run.  It works. Reset with: sudo tccutil reset Microphone com.jetbrains.intellij.ce

Bundle
:no_entry_sign: FAIL
./package.sh, double-click SoundRecorer.app.  It doesn't work.

Passing criteria:

MacOS should prompt for permission to access the microphone, the resulting .wav file should contain audio, not silence.

Some initial observations:

Failing tests produce a silent .wav file for the specified duration.  No prompt; no Java exceptions thrown.
Successful test show the parent app, not Java.  e.g. "IntellIJ would like to access the Microphone".
You only get one chance to Approve.  Dismissing the dialog will assume "No" and the option will need to be manually added using System Preferences, Security & Privacy, Privacy, Microphone.
Unlike other macOS privacy settings, there's currently no way to manually add an App to the Microphone area.

Java version tested:

AdoptOpenJDK 11.0.10
API: AudioSystem.getLine(...).open(...)

Some general questions:

Are entitlements required for Microphone access to work?
Can entitlements be applied to a non-binary (e.g shell script) executables?

Related questions:

https://github.com/microsoft/vscode/issues/95062"VSCode terminal doesn't allow/request permissions to access media devices"
https://stackoverflow.com/questions/55727488/ "Application doesn't ask for permission to access microphone in MacOS 10.14 Mojave"
https://stackoverflow.com/questions/58728150"How to give Microphone permission to Java application (macOS Mojave and above)?"
https://stackoverflow.com/questions/56084303"OpenCV command line app can't access camera under macOS Mojave"
https://stackoverflow.com/a/66210338/3196753"Cannot Access Microphone on Mac Mojave using pyaudio"
https://stackoverflow.com/questions/61989711"How to record microphone on macos with pyaudio?"

Note: Big Sur can have caching issues between signing steps.

Some general questions:

Are entitlements required for Microphone access to work?

This Unity thread suggests they may be needed:
Quoting:

We discovered that in addition to ensuring NSMicrophoneUsageDescription
was in the plist in the mac app bundle package Contents when built, these entitlements also needed to be set:
com.apple.security.device.audio-input
com.apple.security.device.microphone

Then the signtool must be run (and a cert may be required)

Fixed in 17.0.2 (but not backported)


Modified polymer residues need to have a catch-all atom type

Per CyaNine's error in parsing 2mtz-assembly1 into a Biomolecule object, it seems modified polymer residues need to have a catch-all atom type in their residue_constants.atom_types list.

Yeah, thanks Alex!  The  res_chem_comp_details.type named D-gamma-peptide, C-delta linking ,  and when processing the atom named OXT , get
pos[residue_constants.atom_order[atom_name]] = atom.coord
KeyError: 'ATM'

Maybe need to another approach for retrieving residue_constants, or something else.

Thanks again @Kaihui-Cheng for pointing out this issue. Using this PR, I can now successfully parse and train on 2mtz-assembly1. Let me know if you have any other questions or find any other bugs.

That’s great, thanks!


SVG files in Godot 4 not showing font

Godot version
v4.0.3.stable.official [5222a99f5]
System information
Atlas OS Vulkan (Forward +)
Issue description
I made an icon in Inkscape and put it in the project, the SVG has a font text but it does not appear in Godot

Steps to reproduce
Make an SVG in Inkscape with text, then import it in Godot, no text showing
Minimal reproduction project

This is not supported by the thorvg (https://github.com/thorvg/thorvg#svg) library used to by godot. You need to bake the text into paths for it to show up in godot.

This is not supported by the thorvg
I see thanks.

Is it going to be soported?

That's something to take up on ThorVG

For reference, the requirement to convert text to paths is pretty common when you want your SVG to render correctly across software. Even web browsers require this if you use a font that is not available on all systems. A common approach is to duplicate the text element, hide one of them and convert the visible one to a path. This way, you can still edit the original text later.

Would it be feasible to add an optional Inkscape-importer for .svg files, like it is done for .blend files?
So that users who would require more sophisticated svg features could provide a path to the Inkscape binary which then would be used to convert the .svg files to .png files

Is one available that is open source? Or that can be configured?

Would it be feasible to add an optional Inkscape-importer for .svg files, like it is done for .blend files?

It's technically feasible as Inkscape has a CLI, but it would rasterize files on import with no way to change their scale after the project is exported.

Looking up docs ( https://inkscape.org/doc/inkscape-man.html ) it seems Inkscape has a --export-text-to-path option for command line so you can keep the file as an SVG but with the text converted to paths.
As a test, I renamed the attached SVG to "LogoWithText.svg" and ran the following command:
E:\Programs\Inkscape\bin\inkscape --export-text-to-path --export-filename LogoWithText_converted.svg LogoWithText.svg
The resulting svg (LogoWithText_converted.svg) seemed to show the text in Godot fine:

Converted file for those curious:

@TheSofox This sounds great! Does this option exist in the Inkscape GUI as a non-destructive operation as well? I don't mean using Text to Path manually, as this is destructive (it affects your working copy in Inkscape).

@TheSofox This sounds great! Does this option exist in the Inkscape GUI as a non-destructive operation as well? I don't mean using Text to Path manually, as this is destructive (it affects your working copy in Inkscape).

I know only a (relatively quick) 4-click method Ctrl + A, Ctrl + Shift + C, Save a Copy and Ctrl + Z to keep your working file...


Cancel previous Github workflow runs when a PR is updated more than once

Does this work correctly?  It only cancels a workflow for the same PR, not another PR that happens to start around the same time?  The group line isn't clear about that.

Hi Bram,
On Fri, Dec 24, 2021 at 12:57 PM Bram Moolenaar @.***>
wrote:

Does this work correctly? It only cancels a workflow for the same PR, not
another PR that happens to start around the same time? The group line isn't
clear about that.

The various fields used in the Github action group definition are described
in https://docs.github.com/en/actions/learn-github-actions/contexts:
github.workflow: The name of the workflow. If the workflow file doesn't
specify a name, the value of this property is the full path of the workflow
file in the repository.
github.event_name: The name of the event that triggered the workflow run.
github.head_ref: The head_ref or source branch of the pull request in a
workflow run. This property is only available when the event that triggers
a workflow run is either pull_request or pull_request_target.
github.sha: The commit SHA that triggered the workflow run.
Based on these, the group definition is unique for a particular pull
request or commit.
Regards,
Yegappan


Restructuring Examples folder

Pull request information

Status:  in development
Kind of changes: Enhancement
Related PR or issue: #625

Description

Since the changes in the PR #625 is getting huge, I am making a separate PR (this PR) for the restructuring of the examples folder.
@AboudyKreidieh
Note: PR #625 should be merged before this. I am working on it to finish it.
TODO:
(after this PR is done)

[ ] the code structure in tutorial00 must be updated, to reflect the new changes of the structure
[ ] the code in benchmarks still has old names (e.g. grid). Update the code to the new name
[ ] the code in tests still has old names (e.g. test_green_wave). Update the code to the new name

@AboudyKreidieh you can wait on this PR.
I am going to make a new branch off of master once the PR #625 is merged. This branch is behind.


Disqus Comments support

This is not an issue but more so a question on how I can activate the Disqus Comments. I see it being in rendered in react inspector tab but not on the page. Is there anything specific that has to be done?
Thank you.

Best to ask upstream https://github.com/alxshelepenok/gatsby-starter-lumen


Load json mocks from dynamically defined directories

Proposal
We have a per-test directory for mocks. In resources, we have a such hierarchy:
mocks/{TestClassName}/{TestMethodName}/my-mock.json
Each mock file URL starts with a service name prefix which is taken from ConfigureWireMock#name property. This way mocks are loaded in to the correct WireMockServer instance.
If tests need something common, then you can put your mocks in a directory higher in hierarchy. If you put your mocks in
mocks/{TestClassName} then those mocks will be loaded for all tests inside TestClassName. You can put mocks in mocks if you need something to be available in all tests.
The way I match mocks to the correct WireMockServer might be unfeasible for some users. I guess they could put their mocks in another subdirectory, e.g mocks/{TestClassName}/{TestMethodName}/{ServerName}/my-mock.json or name their mock files as {ServerName}.json.
Would be nice to have something like this built-in in this extension. Currently I'm just hacking in Store, get WireMockServer and inject or clean-up stuff if I need. All of this is done in a custom BeforeTestExecutionCallback
p.s. ClasspathFileSource might be a bottleneck for this use-case. In our implementation, I'm thinking about preloading all stubs in a in-memory store and load from it when needed.
References
No response

How would you like to configure it?
Im thinking it can be done with an option to enable/disable loading mocks from all specified directories. And another one for all specified classpath paths. False by default.
Or perhaps have an option that specifies how many parents of a specified directory, or classpath resource, should also be loaded. Default would be 0.
If that would solve your issue?


Add a wiki: ATLYSS Wiki

Link to origin wiki: https://atlyss.fandom.com/wiki/Atlyss_Wiki
Link to destination (independent) wiki: https://atlyss.wiki.gg/wiki/ATLYSS_Wiki

Thank you for the submission! The wiki has been added in v3.11.0 (available for Chrome, soon to be available on Firefox).


Analyzer: capture non-packet events

Continuing from https://github.com/greatscottgadgets/luna/issues/67
Capture other available information from the PHY such as speed changes, bus resets, RX errors, etc.
An initial version could be built on this generic event system: https://github.com/martinling/cynthion-analyzer/pull/3

Work in progress at https://github.com/greatscottgadgets/cynthion-analyzer/pull/11


Make Shovel Item size 90

It was size 5. Currently spears are 95, baseball bats are 80.

Not sure why this is required, shovels are pretty rare maint loot and underwhelming damage-wise already.
If anything make them size 20-30, it's a shovel after all.

end of an era


Shell Scripts editable by default

Panel or Daemon:  Panel
Version of Panel/Daemon: v.0.6.4+
Server's OS: CentOS 7.4
Your Computer's OS & Browser: Windows 10, Chrome

Add Details Below:
text/x-shellscript is editable by default in Pterodactyl\Repositories\HelperRepository.
Allows users to run shell commands within the executable files.

I have already called out things like this in - https://github.com/Pterodactyl/Panel/issues/895

This is not a bug and is known and intended behavior.


Installing in ST3 with Package Manager silently fails

I had my computer reimaged recently and downloaded my favored packages as usual. When I try to install your package through these steps:

The taskbar shows the 'installing' message for all of about half a second before disappearing; the package doesn't show up in Preferences > Package Settings and there's no trace of it ever having been installed.
Is there a log somewhere on my computer that I could provide to help figure out what's going on?

if you open up console (ctrl + `) in sublime you can see the error. Note that this might be related to a recent update in package control (see their thread #1334)

Yep, same thing. Link for anyone else reading this, as well as the output of Ctrl+` if it helps.
reloading settings Packages/User/Package Control.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
Package Control: The dependency 'pygments' is not currently installed; installing...
Package Control: The dependency 'pygments' is not available
Package Control: The dependency 'pygments' could not be installed or updated
ignored packages updated to: ["Vintage"]
reloading settings Packages/User/Package Control.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings


(Indirect) version incompatibility with DiffEqSensitivity and Zygote

In a fresh, empty environment, this
] add DifferentiationInterface, DiffEqSensitivity, Zygote

leads to
ERROR: Unsatisfiable requirements detected for package ArrayInterface [4fba245c]:

follows by a long, long breakdown at to why.
Is there some version bound on the DifferentiationInterface deps we need to relax a bit more (if possible)?

A likely culprit is the newly released breaking version of Enzyme, v0.13. Since DI uses a lot of stuff from Enzyme, I could not adapt to Enzyme v0.13 while keeping compatibility with v0.12, so I dropped v0.12.
On the other hand, SciMLSensitivity has not yet released a new version that allows Enzyme v0.13, but they have it on main so it shouldn't be too hard. I have opened https://github.com/SciML/SciMLSensitivity.jl/issues/1122 to keep track.

A likely culprit is the newly released breaking version of Enzyme

I'm not sure, I didn't seem to work in the past as well.

But in general, of course we can't keep compatibility with multiple versions of multiple AD-backends across their breaking API changes - it would become a @static if jungle that would be near impossible to maintain.

If you want a better way to diagnose, a good method is to construct the environment gradually. For instance, install Zygote and SciMLSensitivity first, then try adding the latest version of DI and see what breaks. When I did this, it was Enzyme that came up first, but as we work our way through the compat mayhem we will unearth more problems:

```julia
(@v1.10) pkg> activate --temp
  Activating new project at `/tmp/jl_nMQPcm`
(jl_nMQPcm) pkg> add Zygote, SciMLSensitivity
Resolving package versions...
Installed SciMLSensitivity ─ v7.68.0
Updating /tmp/jl_nMQPcm/Project.toml
[1ed8b502] + SciMLSensitivity v7.68.0
[e88e6eb3] + Zygote v0.6.71
Updating /tmp/jl_nMQPcm/Manifest.toml
[47edcb42] + ADTypes v1.9.0
[621f4979] + AbstractFFTs v1.5.0
[7d9f7c33] + Accessors v0.1.38
[79e6a3ab] + Adapt v4.0.4
[66dad0bd] + AliasTables v1.1.3
[ec485272] + ArnoldiMethod v0.4.0
[4fba245c] + ArrayInterface v7.16.0
[4c555306] + ArrayLayouts v1.10.3
[a9b6321e] + Atomix v0.1.0
[62783981] + BitTwiddlingConvenienceFunctions v0.1.6
[fa961155] + CEnum v0.5.0
[2a0fbf3d] + CPUSummary v0.2.6
[7057c7e9] + Cassette v0.3.13
[082447d4] + ChainRules v1.71.0
[d360d2e6] + ChainRulesCore v1.25.0
[fb6a15b2] + CloseOpenIntervals v0.1.13
[38540f10] + CommonSolve v0.2.4
[bbf7d656] + CommonSubexpressions v0.3.1
[f70d9fcc] + CommonWorldInvalidations v1.0.0
[34da2185] + Compat v4.16.0
[a33af91c] + CompositionsBase v0.1.2
[2569d6c7] + ConcreteStructs v0.2.3
[187b0558] + ConstructionBase v1.5.8
[adafc99b] + CpuId v0.3.1
[9a962f9c] + DataAPI v1.16.0
[864edb3b] + DataStructures v0.18.20
[e2d170a0] + DataValueInterfaces v1.0.0
[2b5f629d] + DiffEqBase v6.155.1
[459566f4] + DiffEqCallbacks v3.9.1
[77a26b50] + DiffEqNoiseProcess v5.23.0
[163ba53b] + DiffResults v1.1.0
[b552c78f] + DiffRules v1.15.1
⌅ [a0c0ee7d] + DifferentiationInterface v0.5.17
[31c24e10] + Distributions v0.25.112
[ffbed154] + DocStringExtensions v0.9.3
[da5c29d0] + EllipsisNotation v1.8.0
[4e289a0a] + EnumX v1.0.4
⌃ [7da242da] + Enzyme v0.12.36
⌅ [f151be2c] + EnzymeCore v0.7.8
[e2ba6199] + ExprTools v0.1.10
⌅ [6b7a57c9] + Expronicon v0.8.5
[7034ab61] + FastBroadcast v0.3.5
[9aa1b823] + FastClosures v0.3.2
[29a986be] + FastLapackInterface v2.0.4
[1a297f60] + FillArrays v1.13.0
[6a86dc24] + FiniteDiff v2.24.0
[f6369f11] + ForwardDiff v0.10.36
[f62d2435] + FunctionProperties v0.1.2
[069b7b12] + FunctionWrappers v1.1.3
[77dc65aa] + FunctionWrappersWrappers v0.1.3
[d9f16b24] + Functors v0.4.12
[0c68f7d7] + GPUArrays v10.3.1
[46192b85] + GPUArraysCore v0.1.6
⌃ [61eb1bfa] + GPUCompiler v0.27.5
[86223c79] + Graphs v1.11.2
[3e5b6fbb] + HostCPUFeatures v0.1.17
[34004b35] + HypergeometricFunctions v0.3.24
[7869d1d1] + IRTools v0.4.14
[615f187c] + IfElse v0.1.1
[d25df0c9] + Inflate v0.1.5
[3587e190] + InverseFunctions v0.1.17
[92d709cd] + IrrationalConstants v0.2.2
[82899510] + IteratorInterfaceExtensions v1.0.0
[692b3bcd] + JLLWrappers v1.6.0
[ef3ab10e] + KLU v0.6.0
⌃ [63c18a36] + KernelAbstractions v0.9.26
[ba0b0d4f] + Krylov v0.9.6
⌅ [929cbde3] + LLVM v9.0.0
[10f19ff3] + LayoutPointers v0.1.17
[5078a376] + LazyArrays v2.2.1
[d3d80556] + LineSearches v7.3.0
[7ed4a6bd] + LinearSolve v2.34.0
[2ab3a3ac] + LogExpFunctions v0.3.28
[bdcacae8] + LoopVectorization v0.12.171
[d8e11817] + MLStyle v0.4.17
[1914dd2f] + MacroTools v0.5.13
[d125e4d3] + ManualMemory v0.1.8
[bb5d69b7] + MaybeInplace v0.1.4
[e1d29d7a] + Missings v1.2.0
[46d2c3a1] + MuladdMacro v0.2.4
[d41bc354] + NLSolversBase v7.8.3
[872c559c] + NNlib v0.9.24
[77ba4419] + NaNMath v1.0.2
[8913a72c] + NonlinearSolve v3.14.0
[d8793406] + ObjectFile v0.4.2
[6fe1bfb0] + OffsetArrays v1.14.1
[429524aa] + Optim v1.9.4
[3bd65402] + Optimisers v0.3.3
[bac558e1] + OrderedCollections v1.6.3
[90014a1f] + PDMats v0.11.31
[65ce6f38] + PackageExtensionCompat v1.0.2
[d96e819e] + Parameters v0.12.3
[e409e4f3] + PoissonRandom v0.4.4
[f517fe37] + Polyester v0.7.16
[1d0040c9] + PolyesterWeave v0.2.2
[85a6dd25] + PositiveFactorizations v0.2.4
[d236fae5] + PreallocationTools v0.4.24
[aea7be01] + PrecompileTools v1.2.1
[21216c6a] + Preferences v1.4.3
[43287f4e] + PtrArrays v1.2.1
[1fd47b50] + QuadGK v2.11.1
[74087812] + Random123 v1.7.0
[e6cf234a] + RandomNumbers v1.6.0
[c1ae055f] + RealDot v0.1.0
[3cdcf5f2] + RecipesBase v1.3.4
[731186ca] + RecursiveArrayTools v3.27.0
[f2c3362d] + RecursiveFactorization v0.2.23
[189a3867] + Reexport v1.2.2
[ae029012] + Requires v1.3.0
[ae5879a3] + ResettableStacks v1.1.1
[37e2e3b7] + ReverseDiff v1.15.3
[79098fc4] + Rmath v0.8.0
[7e49a35a] + RuntimeGeneratedFunctions v0.5.13
[94e857df] + SIMDTypes v0.1.0
[476501e8] + SLEEFPirates v0.6.43
[0bca4576] + SciMLBase v2.54.0
[c0aeaf25] + SciMLOperators v0.3.10
[1ed8b502] + SciMLSensitivity v7.68.0
[53ae85a6] + SciMLStructures v1.5.0
[6c6a2e73] + Scratch v1.2.1
[efcf1570] + Setfield v1.1.1
⌃ [727e6d20] + SimpleNonlinearSolve v1.12.2
[699a6c99] + SimpleTraits v0.9.4
[a2af1166] + SortingAlgorithms v1.2.1
[47a9eef4] + SparseDiffTools v2.20.0
[dc90abb0] + SparseInverseSubset v0.1.2
[0a514795] + SparseMatrixColorings v0.4.1
[e56a9233] + Sparspak v0.3.9
[276daf66] + SpecialFunctions v2.4.0
[aedffcd0] + Static v1.1.1
[0d7ed370] + StaticArrayInterface v1.8.0
[90137ffa] + StaticArrays v1.9.7
[1e83bf80] + StaticArraysCore v1.4.3
[82ae8749] + StatsAPI v1.7.0
[2913bbd2] + StatsBase v0.34.3
[4c63d2b9] + StatsFuns v1.3.2
[7792a7ef] + StrideArraysCore v0.5.7
[09ab397b] + StructArrays v0.6.18
[53d494c1] + StructIO v0.3.1
[2efcf032] + SymbolicIndexingInterface v0.3.31
[3783bdb8] + TableTraits v1.0.1
[bd369af6] + Tables v1.12.0
[8290d209] + ThreadingUtilities v0.5.2
[a759f4b9] + TimerOutputs v0.5.24
[9f7883ad] + Tracker v0.2.35
[d5829a12] + TriangularSolve v0.2.1
[410a4b4d] + Tricks v0.1.9
[781d530d] + TruncatedStacktraces v1.4.0
[3a884ed6] + UnPack v1.0.2
[013be700] + UnsafeAtomics v0.2.1
[d80eeb9a] + UnsafeAtomicsLLVM v0.2.1
[3d5dd08c] + VectorizationBase v0.21.70
[19fa3120] + VertexSafeGraphs v0.2.0
[e88e6eb3] + Zygote v0.6.71
[700de1a5] + ZygoteRules v0.2.5
⌅ [7cc45869] + Enzyme_jll v0.0.148+0
[1d5cc7b8] + IntelOpenMP_jll v2024.2.1+0
⌅ [dad2f222] + LLVMExtra_jll v0.0.33+0
[856f044c] + MKL_jll v2024.2.0+0
[efe28fd5] + OpenSpecFun_jll v0.5.5+0
[f50d1b31] + Rmath_jll v0.5.1+0
[1317d2d5] + oneTBB_jll v2021.12.0+0
[0dad84c5] + ArgTools v1.1.1
[56f22d72] + Artifacts
[2a0f44e3] + Base64
[ade2ca70] + Dates
[8ba89e20] + Distributed
[f43a241f] + Downloads v1.6.0
[7b1f6079] + FileWatching
[9fa8497b] + Future
[b77e0a4c] + InteractiveUtils
[4af54fe1] + LazyArtifacts
[b27032c2] + LibCURL v0.6.4
[76f85450] + LibGit2
[8f399da3] + Libdl
[37e2e46d] + LinearAlgebra
[56ddb016] + Logging
[d6f4376e] + Markdown
[a63ad114] + Mmap
[ca575930] + NetworkOptions v1.2.0
[44cfe95a] + Pkg v1.10.0
[de0858da] + Printf
[3fa0cd96] + REPL
[9a3f8284] + Random
[ea8e919c] + SHA v0.7.0
[9e88b42a] + Serialization
[1a1011a3] + SharedArrays
[6462fe0b] + Sockets
[2f01184e] + SparseArrays v1.10.0
[10745b16] + Statistics v1.10.0
[4607b0f0] + SuiteSparse
[fa267f1f] + TOML v1.0.3
[a4e569a6] + Tar v1.10.0
[8dfed614] + Test
[cf7118a7] + UUIDs
[4ec0a83e] + Unicode
[e66e0078] + CompilerSupportLibraries_jll v1.1.1+0
[deac9b47] + LibCURL_jll v8.4.0+0
[e37daf67] + LibGit2_jll v1.6.4+0
[29816b5a] + LibSSH2_jll v1.11.0+1
[c8ffd9c3] + MbedTLS_jll v2.28.2+1
[14a3606d] + MozillaCACerts_jll v2023.1.10
[4536629a] + OpenBLAS_jll v0.3.23+4
[05823500] + OpenLibm_jll v0.8.1+2
[bea87d4a] + SuiteSparse_jll v7.2.1+1
[83775a58] + Zlib_jll v1.2.13+1
[8e850b90] + libblastrampoline_jll v5.11.0+0
[8e850ede] + nghttp2_jll v1.52.0+1
[3f19e933] + p7zip_jll v17.4.0+2
Info Packages marked with ⌃ and ⌅ have new versions available. Those with ⌃ may be upgradable, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use status --outdated -m
Precompiling project...
1 dependency successfully precompiled in 28 seconds. 269 already precompiled.
(jl_nMQPcm) pkg> add<EMAIL_ADDRESS>Resolving package versions...
ERROR: Unsatisfiable requirements detected for package SciMLSensitivity [1ed8b502]:
SciMLSensitivity [1ed8b502] log:
├─possible versions are: 7.0.0-7.68.0 or uninstalled
├─restricted to versions * by an explicit requirement, leaving only versions: 7.0.0-7.68.0
├─restricted by compatibility requirements with Enzyme [7da242da] to versions: 7.68.0 or uninstalled, leaving only versions: 7.68.0
│ └─Enzyme [7da242da] log:
│   ├─possible versions are: 0.1.0-0.13.3 or uninstalled
│   ├─restricted by compatibility requirements with DifferentiationInterface [a0c0ee7d] to versions: 0.13.2-0.13.3 or uninstalled
│   │ └─DifferentiationInterface [a0c0ee7d] log:
│   │   ├─possible versions are: 0.1.0-0.6.1 or uninstalled
│   │   └─restricted to versions 0.6 by an explicit requirement, leaving only versions: 0.6.0-0.6.1
│   └─restricted by compatibility requirements with SciMLSensitivity [1ed8b502] to versions: 0.8.0-0.13.3, leaving only versions: 0.13.2-0.13.3
│     └─SciMLSensitivity [1ed8b502] log: see above
└─restricted by compatibility requirements with DiffEqBase [2b5f629d] to versions: 7.0.0-7.51.0 or uninstalled — no versions left
└─DiffEqBase [2b5f629d] log:
├─possible versions are: 3.13.2-6.155.1 or uninstalled
├─restricted by compatibility requirements with SciMLSensitivity [1ed8b502] to versions: 6.90.0-6.155.1
│ └─SciMLSensitivity [1ed8b502] log: see above
├─restricted by compatibility requirements with Enzyme [7da242da] to versions: 3.13.2-6.151.1 or uninstalled, leaving only versions: 6.90.0-6.151.1
│ └─Enzyme [7da242da] log: see above
└─restricted by compatibility requirements with EnzymeCore [f151be2c] to versions: 3.13.2-6.130.1 or uninstalled, leaving only versions: 6.90.0-6.130.1
└─EnzymeCore [f151be2c] log:
├─possible versions are: 0.1.0-0.8.2 or uninstalled
└─restricted by compatibility requirements with Enzyme [7da242da] to versions: 0.8.0-0.8.2
└─Enzyme [7da242da] log: see above
</details>

Yes, I'll see what I can dig out ...

There's a conversation about this on Slack in the #autodiff channel, if you wanna follow. LinearSolve also needs to be updated for Enzyme v0.13 and apparently it's not easy.

I think we can close this - DiffEqSensitivity has been replaced with SciMLSensitivity - with that, there is no conflict.


Not working for deep pages

Has anyone faced this issue?
https://stackoverflow.com/questions/73904944/rendertron-middleware-not-rendering-anything-other-than-root-page
My rendering works for base URL only. Others give 504 error.

In general, as we're deprecating the project, you should look into alternative approaches to rendering on the web.


RemoveScreenShake.js still shakes a little bit

The concept of RemoveScreenShake is based upon Abyss' disable shake feature, but it feels incomplete in comparison, there is still a small shake to be felt, it's coming from the function that uses blur.xml.
For reference I'm testing this with fireballs, there is still that shake-y blur every fireball.
I have modified the values on blur.xml to stop it but it feels unethical to include that as a fix, so I placed it as an issue.

Well, screen shake and screen blur are two different things. I can look at removing screen blur separately =)

Disable Full Screen Effect in the in-game options.  As far as I know that's only used for screen blur and the upside-down effect that only like two enemies in the entire game can cause and I think they're part of generation quests anyways.

Oh, that would explain why I'm not seeing it. I'm gonna close this issue since @Rydian has addressed it. Thanks!

I disabled it and the blur is now gone, thank you Rydian. I never realized this option does that.


the path to the upload folder needs to be a setting

The PDF feature works by prepending https://via.hypothes.is to links in posts that point into the media upload folder, by default wp-content/uploads. But if your WP system refers to a different place, you're out of luck. So, the path to that folder should be a setting.

Hi @judell! You should be able to use wp_upload_dir()['basedir'] to get the correct /uploads path on any system.

Aha. Thanks Ned!

Fixed by #27, I think!

Closing as fixed


Unit test coverage

Add unit test coverage to GitHub Actions:

bazel coverage --combined_report=lcov --instrument_test_targets //...
genhtml --output-directory ./coverage ./bazel-out/_coverage/_coverage_report.dat

Add badge to report the overall coverage %tage

Done in 07fa3dae58d0a01f3cdcb426abfb15b27af7594e.


Javadoc correction for open method

Just a little correction.

@fabienbancharel thank you for the pull request!


Enhanced Material Select Component

Hello
Is there support for Enhanced Select that we can use?
Like this one here (Enhanced Filled one):
https://material-components.github.io/material-components-web-catalog/#/component/select
Looks like the Preact Material Select only renders the native select?

We'll be adding this in 2.0


Redis Connectivity

Hi,
Could you provide me any documentatin to understand the operator or can we have a section for redis connectivity in the readme?
we are looking for some assistance to know the operator details to use it in our production.
regards,

Why not! I will provide a Chinese document first.

Why not! I will provide a Chinese document first.

https://github.com/ucloud/redis-cluster-operator/pull/65


How to stop auto playing of video on mobile safari

mejs version: "4.2.6"
iPhone 7 with ios 11.1.1

In safari app, when I open http://bit.ly/2zHaVWP and play the youtube video. Just after playing the video, if I press home button, safari closes and return to home screen. Now when I reopen the safari, the video plays automatically. How can I avoid this auto playing.

For what I've seen, there's no way to stop this; many sources indicate that the way to stop it is via phone config.


Unable to deploy with dokku buildpacks nginx

Hi,
I'm trying to deploy a static website following the guide provided on readme.md

but when I deploy it just fails:
MacBook-Pro-de-david:marthe davidscheck$ git push dokku master
Counting objects: 28, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (24/24), done.
Writing objects: 100% (28/28), 31.15 KiB | 7.79 MiB/s, done.
Total 28 (delta 9), reused 0 (delta 0)
-----> Cleaning up...
-----> Building marthe from herokuish...
-----> Adding BUILD_ENV to build environment...
-----> Fetching custom buildpack
To marthewery.be:marthe
 ! [remote rejected] master -> master (pre-receive hook declined)

Can you show the output of a deploy after running dokku trace on?

https://dpaste.de/mgfJ
thanks :)

Can you add a trailing newline to you .env file and try another deploy?

I did and it’s failing
Le dim. 10 juin 2018 à 04:29, Jose Diaz-Gonzalez<EMAIL_ADDRESS>a écrit :

Can you add a trailing newline to you .env file and try another deploy?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dokku/buildpack-nginx/issues/30#issuecomment-396014679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACvXiGLGNBu2B-F8xlLzNmHWEOQghTH-ks5t7ISjgaJpZM4Uhb5P
.

--
With kindest regards,
David SCHECK
PRESIDENT/DEVELOPER
[image: Signature Logo Sphax Bleu-01.png]
Phone: +32 4 87 86 70 12
Visit our website ! https://www.sphax.org

Can you show me the contents of your .env file, and the logs of a deploy with dokku trace on after you added a newline?

and the stack trace
https://dpaste.de/6ujj


Date formats should be a bit more clever.

· omit the year if current year
· use today or yesterday with times
· use “seconds ago” or “minutes ago” if really close by

Hey there and happy hacktoberfest!
As in CONTRIBUTING - I'm letting know, that I want to work on it. By the way, it's very nice of you, that old issues like this are not being forgotten!

Closed via c254ea2.


HBASE-22571 Javadoc Warnings related to @return tag

Javadoc Warnings related to @return tag

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
245
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
28
Maven dependency ordering for branch

+1
mvninstall
295
master passed

+1
compile
122
master passed

+1
checkstyle
145
master passed

+1
shadedjars
287
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
360
master passed

+1
javadoc
89
master passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
277
the patch passed

+1
compile
124
the patch passed

+1
javac
124
the patch passed

-1
checkstyle
78
hbase-server: The patch generated 6 new + 720 unchanged - 1 fixed = 726 total (was 721)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
261
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
784
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
355
the patch passed

+1
javadoc
83
the patch passed

_ Other Tests _

+1
unit
197
hbase-client in the patch passed.

+1
unit
47
hbase-zookeeper in the patch passed.

-1
unit
15548
hbase-server in the patch failed.

+1
unit
1242
hbase-mapreduce in the patch passed.

+1
asflicense
124
The patch does not generate ASF License warnings.

21141

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 91c466cb7c2b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 853e586d0f

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/testReport/

Max. process+thread count
5349 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Thanks for the kind comments. I have addressed and fixed things according to comments. Kindly have a look in the 2nd commit.

Thanks for the feedback. Please find the corrections in the 3rd commit.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
161
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

+1
mvninstall
350
master passed

+1
compile
151
master passed

+1
checkstyle
167
master passed

+1
shadedjars
322
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
384
master passed

+1
javadoc
104
master passed

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
333
the patch passed

+1
compile
168
the patch passed

+1
javac
168
the patch passed

+1
checkstyle
37
The patch passed checkstyle in hbase-client

+1
checkstyle
15
The patch passed checkstyle in hbase-zookeeper

+1
checkstyle
92
hbase-server: The patch generated 0 new + 720 unchanged - 1 fixed = 720 total (was 721)

+1
checkstyle
19
The patch passed checkstyle in hbase-mapreduce

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
334
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
996
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
411
the patch passed

+1
javadoc
97
the patch passed

_ Other Tests _

+1
unit
143
hbase-client in the patch passed.

+1
unit
50
hbase-zookeeper in the patch passed.

+1
unit
12958
hbase-server in the patch passed.

+1
unit
1360
hbase-mapreduce in the patch passed.

+1
asflicense
152
The patch does not generate ASF License warnings.

19288

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 45b597fbef70 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 214553d17a

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/2/testReport/

Max. process+thread count
5352 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
20
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
32
Maven dependency ordering for branch

+1
mvninstall
266
master passed

+1
compile
120
master passed

+1
checkstyle
150
master passed

+1
shadedjars
276
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
340
master passed

+1
javadoc
85
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
257
the patch passed

+1
compile
122
the patch passed

+1
javac
122
the patch passed

+1
checkstyle
32
The patch passed checkstyle in hbase-client

+1
checkstyle
12
The patch passed checkstyle in hbase-zookeeper

+1
checkstyle
83
hbase-server: The patch generated 0 new + 720 unchanged - 1 fixed = 720 total (was 721)

+1
checkstyle
20
hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
292
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
877
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
390
the patch passed

+1
javadoc
85
the patch passed

_ Other Tests _

+1
unit
130
hbase-client in the patch passed.

+1
unit
45
hbase-zookeeper in the patch passed.

+1
unit
8220
hbase-server in the patch passed.

+1
unit
972
hbase-mapreduce in the patch passed.

+1
asflicense
107
The patch does not generate ASF License warnings.

13327

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 2c8aefd9dea7 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 214553d17a

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/3/testReport/

Max. process+thread count
5286 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@syedmurtazahassan Could you please resolve the merge conflicts.

@HorizonNet Solved the merge conflict, kindly review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
30
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
15
Maven dependency ordering for branch

+1
mvninstall
243
master passed

+1
compile
119
master passed

+1
checkstyle
145
master passed

+1
shadedjars
265
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
334
master passed

+1
javadoc
86
master passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
239
the patch passed

+1
compile
118
the patch passed

+1
javac
118
the patch passed

+1
checkstyle
28
The patch passed checkstyle in hbase-client

+1
checkstyle
12
The patch passed checkstyle in hbase-zookeeper

-1
checkstyle
79
hbase-server: The patch generated 5 new + 697 unchanged - 0 fixed = 702 total (was 697)

+1
checkstyle
18
hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
266
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
712
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
362
the patch passed

+1
javadoc
78
the patch passed

_ Other Tests _

+1
unit
101
hbase-client in the patch passed.

+1
unit
46
hbase-zookeeper in the patch passed.

-1
unit
2387
hbase-server in the patch failed.

+1
unit
988
hbase-mapreduce in the patch passed.

+1
asflicense
64
The patch does not generate ASF License warnings.

7116

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestRegionServerRegionSpaceUseReport

hadoop.hbase.client.TestMultiActionMetricsFromClient

hadoop.hbase.regionserver.TestDateTieredCompactionPolicy

hadoop.hbase.TestClientClusterMetrics

hadoop.hbase.replication.regionserver.TestWALEntrySinkFilter

hadoop.hbase.replication.regionserver.TestReplicationSinkManager

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 6b5a5b634980 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 0c8dc5d97e

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/testReport/

Max. process+thread count
5439 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@syedmurtazahassan It seems that you added new Checkstyle issues. Would be great if you could resolve them.

@HorizonNet Fixed the checkstyle issues. Kindly have a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
16
Maven dependency ordering for branch

+1
mvninstall
244
master passed

+1
compile
119
master passed

+1
checkstyle
132
master passed

+1
shadedjars
267
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
321
master passed

+1
javadoc
82
master passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
235
the patch passed

+1
compile
119
the patch passed

+1
javac
119
the patch passed

+1
checkstyle
30
The patch passed checkstyle in hbase-client

+1
checkstyle
13
The patch passed checkstyle in hbase-zookeeper

+1
checkstyle
81
The patch passed checkstyle in hbase-server

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
266
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
738
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
361
the patch passed

+1
javadoc
87
the patch passed

_ Other Tests _

+1
unit
111
hbase-client in the patch passed.

+1
unit
48
hbase-zookeeper in the patch passed.

+1
unit
7939
hbase-server in the patch passed.

-1
unit
1107
hbase-mapreduce in the patch failed.

+1
asflicense
93
The patch does not generate ASF License warnings.

12824

Reason
Tests

Failed junit tests
hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 801f589aa972 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 0c8dc5d97e

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/testReport/

Max. process+thread count
5398 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Re-running build just to make sure test failure flakey.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
69
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
20
Maven dependency ordering for branch

+1
mvninstall
260
master passed

+1
compile
118
master passed

+1
checkstyle
137
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
319
master passed

+1
javadoc
83
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
242
the patch passed

+1
compile
120
the patch passed

+1
javac
120
the patch passed

+1
checkstyle
29
The patch passed checkstyle in hbase-client

+1
checkstyle
12
The patch passed checkstyle in hbase-zookeeper

+1
checkstyle
77
The patch passed checkstyle in hbase-server

+1
checkstyle
19
hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
265
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
727
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
360
the patch passed

+1
javadoc
86
the patch passed

_ Other Tests _

+1
unit
109
hbase-client in the patch passed.

+1
unit
48
hbase-zookeeper in the patch passed.

+1
unit
7944
hbase-server in the patch passed.

-1
unit
1024
hbase-mapreduce in the patch failed.

+1
asflicense
111
The patch does not generate ASF License warnings.

12832

Reason
Tests

Failed junit tests
hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux a5bbb8e21bda 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 52eb893bcc

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/artifact/out/patch-unit-hbase-mapreduce.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/testReport/

Max. process+thread count
5384 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
93
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
18
Maven dependency ordering for branch

+1
mvninstall
229
master passed

+1
compile
111
master passed

+1
checkstyle
126
master passed

+1
shadedjars
253
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
322
master passed

+1
javadoc
77
master passed

_ Patch Compile Tests _

0
mvndep
12
Maven dependency ordering for patch

+1
mvninstall
222
the patch passed

+1
compile
111
the patch passed

+1
javac
111
the patch passed

+1
checkstyle
25
The patch passed checkstyle in hbase-client

+1
checkstyle
11
The patch passed checkstyle in hbase-zookeeper

+1
checkstyle
70
The patch passed checkstyle in hbase-server

+1
checkstyle
15
hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
252
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
690
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
345
the patch passed

+1
javadoc
78
the patch passed

_ Other Tests _

+1
unit
102
hbase-client in the patch passed.

+1
unit
45
hbase-zookeeper in the patch passed.

+1
unit
7958
hbase-server in the patch passed.

+1
unit
830
hbase-mapreduce in the patch passed.

+1
asflicense
92
The patch does not generate ASF License warnings.

12432

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 167ec46ecc11 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 605f8a15bb

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/7/testReport/

Max. process+thread count
5062 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/7/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
63
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 14 new or modified test files.

_ master Compile Tests _

0
mvndep
12
Maven dependency ordering for branch

+1
mvninstall
245
master passed

+1
compile
122
master passed

+1
checkstyle
134
master passed

+1
shadedjars
266
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
340
master passed

+1
javadoc
82
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
245
the patch passed

+1
compile
120
the patch passed

+1
javac
120
the patch passed

+1
checkstyle
27
The patch passed checkstyle in hbase-client

+1
checkstyle
11
The patch passed checkstyle in hbase-zookeeper

+1
checkstyle
75
The patch passed checkstyle in hbase-server

+1
checkstyle
17
hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
267
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
747
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
367
the patch passed

+1
javadoc
84
the patch passed

_ Other Tests _

+1
unit
108
hbase-client in the patch passed.

+1
unit
47
hbase-zookeeper in the patch passed.

+1
unit
16617
hbase-server in the patch passed.

+1
unit
2007
hbase-mapreduce in the patch passed.

+1
asflicense
110
The patch does not generate ASF License warnings.

22493

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/302

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 184c0bd7a027 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 438bf3284e

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/8/testReport/

Max. process+thread count
5098 (vs. ulimit of 10000)

modules
C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/8/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


charm is constantly logging errors

Bug Description
the charm gets into this state wheres logging tls errors and it stays active idle. Its not working as expected and is not injecting configs specified in its settings_yaml config to the other pods (in the corresponding namespaces.)
There is no proper visibility into the state of this charm outside of logs. It would be nice if the charm workload status reflected its state and it could forward its logs to COS(loki).
To Reproduce
N/A
Environment
namespace-node-affinity                                    active       1  namespace-node-affinity  0.1/beta              5  REDACTED    no

Relevant Log Output
2024/01/29 1835 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1838 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1840 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1842 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1857 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1857 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1857 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1836 http: TLS handshake error from REDACTED remote error: tls: bad certificate
2024/01/29 1805 http: TLS handshake error from REDACTED remote error: tls: bad certificate

Additional Context
settings_yaml config
      controller-k8s: |
        nodeSelectorTerms:
          - matchExpressions:
            - key: kubeflowserver
              operator: In
              values:
              - true
      kubeflow: |
        nodeSelectorTerms:
          - matchExpressions:
            - key: kubeflowserver
              operator: In
              values:
              - true
      metallb: |
        nodeSelectorTerms:
          - matchExpressions:
            - key: kubeflowserver
              operator: In
              values:
              - true

this charm erroring out effectively breaks segregation between charmed kubeflow services and other workloads (when the pods get restarted that is)


Allow an async dependency builder?

Maybe this is an antipattern, however i once had the use case where i wanted to register a dependency by using an async dependency builder:
injector.registerSingleton<Calculation>(() async {
  return await createCalculation();
});

Unfortunately, this does not work at the moment.
I am open for discussing this topic.

I would not say that this is an antipattern, it's just something that is harder to do for service locators/dependency injections.
I thought about this a lot and I also had this issue a couple of times. Here are some thoughts about this:
Dependency takes care of the async initializations
In most cases, my dependency took care of handling the async stuff by themselves to avoid dealing with this complexity in the dependency injection.
For example, we have a Repository that works with Hive which is initialized asynchronously. In my case, the Repository will initialize Hive maybe by using a callback.
Just some pseudo code:
injector.registerSingleton(() {
  // openbox is async.
  return Respository(initHive: () => Hive.openbox());
});

This is not an elegant solution if you have the use case a lot because it requires you to handle that init stuff in every class again.
Wrappers for initializing async dependencies
Let's say you register a class that comes from another framework where you have no control if the creation is async or not. You can create a simple wrapper around that dependency. Something like an "AsyncContainer".
// implementation is skipped.
class AsyncContainer<T> {
  Future<T> get value;
  AsyncContainer(Future<T> Function() factory);
}

injector.registerDependency<AsyncContainer<MyClass>>(() {
  return AsyncContainer(() => MyClass.createInstanceAsync(userService: injector.get()));
});

final container = await injector.get<AsyncContainer<MyClass>>().value;

This solution is also not that elegant because you now have to make sure you get all your async dependencies using AsyncContainer.
Adding support for Async factories in injector
We probably need something like
injector.registerSingletonAsync<T>(/* factory method */),
injector.registerDependencyAsync<T>(/* factory method */)
or
injector.registerAsyncFactory<T>(/* factory method */)
When getting the dependency you have to handle the case that the dependency is not yet initialized. So we need something like Future<T> getAsync<T>() and if the dependency that you try to get here is not async we have to throw. (or the other way around if you use get<T>() and it's not async).
Problems with async dependencies
GetIt has other functions like GetIt.allReady() which waits until all async factories are resolved. I think this is really dangerous because if you sometimes register an async dependency that takes longer to initialize and you call GetIt.ready() before hiding a splash screen or even before starting your flutter app, you will probably block the user. A better solution for this would be to handle this explicitly because the interface of that dependency force you to do this which brings me back to the first point. " >Dependency takes care of the async initializations
Example:
injector.registerSingletonAsync(() async {
    final myService = MyService();
    await myService.init();
    return myService;
});

await injector.waitUntilAllDependenciesAreReady();
runApp(MyApp());

Maybe it makes sense to show a loading indicator to your users and call MyService.init at some point in the future. Maybe only then when you need it which might be when the user opens a specific screen. This can be controlled by whatever class is using MyService. Maybe a redux action, maybe a Bloc or a Provider.
To summarize:
Architecture wise there is a lot that can be done wrong with async dependencies, but it's up to the consumer of the package to decide this. I am down for implementing this into this package because many users asking for this.

To inject async dependencies I used this wrapper which acts as a factory to build the dependency.
The extra static sync method I used in my tests.
typedef AsyncBuilder<T> = Future<T> Function();

typedef NonAsyncBuilder<T> = T Function();

class AsyncProvider<T> {

  AsyncBuilder<T> builder;

  AsyncProvider(this.builder);

  Future<T> get get => builder();

  static AsyncProvider<T> sync<T>(NonAsyncBuilder<T> builder) {
    return AsyncProvider<T>(() async => builder());
  }

}

i.e.
injector.registerSingleton<AsyncProvider<UserService>>(() => AsyncProvider<UserService>(() => UserService.get()));

class MyClass {

  final AsyncProvider<UserService> userServiceProvider;

  MyClass() : this.userServiceProvider = Injector.appInstance.get<AsyncProvider<UserService>>();

  Future<void> doSomething() async {
    final UserService userService = await userServiceProvider.get;
    ...
  }

}


ExoPlayer's ConcatenatingMediaSource misinteracts with seekToNext()

Version
Media3 1.1.1
More version details
No response
Devices that reproduce the issue
Google Pixel 4a
Devices that do not reproduce the issue
None found
Reproducible in the demo app?
No
Reproduction steps

Check out https://github.com/stoyicker/mwe-concatenatingmediasource/tree/0d3b27c1419f15f0d9d50e51669bc39cfad50f16
Run the app

Expected result

The item with the URI finishing in audio.mp4 starts playback
The item with the URI finishing in tears_audio_eng.mp4 starts playback

(1 likely lasts too little to be noticeable, but at least it is reasonable to expect 2)
Actual result
Playback never starts as corroborated by log calls from the app pertaining playback state changes.
Additionally, I'd like to note that posting these lines:
setMediaSource(concatenatingMediaSource)
playWhenReady = true
prepare()

after the dispatch of the first media source addition causes the first item to be played, and then when it finishes playback of the third item starts, which gives me the impression that the seekToNext() called skipped not the currently playing item when it was received, but the next one instead. Neither this behavior nor the one from the MWE as is (with these lines before dispatching any addMediaSource calls on the ConcatenatingMediaSource) seem correct to me.
Media
All required media is already available in the linked MWE.
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

When I try the app and add an EventLogger then I see that the player is prepared when the ConcatenatingMediaSource is still empty. The player then falls into STATE_ENDED and afterwards media sources are added and removed.
With this setup I think this is working as intended. See logs below.
I think this is a threading problem created by the sample app and the calls to ExoPlayer do not have the expected sequence. Mostly, prepare is called before media sources are ended to the concatenating media source.
I think if the calls to ExoPlayer are done in the correct sequence this just works.
Can you try doing the setup without special threads as a start? Then if the app really needs these additional threads, can you make sure that media sources are added before prepare() is called on the player?

ExoPlayerImpl       I  Init 70c5693 [AndroidXMedia3/1.1.1] [raven, Pixel 6 Pro, Google, 33]
mwe.root            W  Accessing hidden method Landroid/media/AudioTrack;->getLatency()I (unsupported, reflection, allowed)
EventLogger         D  playWhenReady [eventTime=0.00, mediaPos=0.00, window=0, true, USER_REQUEST]
EventLogger         D  state [eventTime=0.00, mediaPos=0.00, window=0, ENDED]
TEST-Thread[main]   D  Finished dispatching all commands
Compatib...eporter  D  Compat change id reported: 210923482; UID 10254; state: ENABLED
TEST-Thr...Thread]  D  Finished addMediaSource for item id=mp4 on index 0
Compatib...eporter  D  Compat change id reported: 237531167; UID 10254; state: DISABLED
TEST-Thr...Thread]  D  Finished addMediaSource for item id=mp4 on index 1
TEST-Thr...Thread]  D  Finished addMediaSource for item id=mp4 on index 1
TEST-Thr...Thread]  D  Finished removeMediaSourceSync on index 2
EventLogger         D  timeline [eventTime=0.02, mediaPos=0.00, window=0, periodCount=1, windowCount=1, reason=SOURCE_UPDATE
EventLogger         D    period [?]
EventLogger         D    window [?, seekable=false, dynamic=true]
EventLogger         D  ]
EventLogger         D  mediaItem [eventTime=0.02, mediaPos=0.00, window=0, reason=PLAYLIST_CHANGED]
EventLogger         D  loading [eventTime=0.03, mediaPos=0.00, window=0, period=0, true]
EventLogger         D  timeline [eventTime=0.03, mediaPos=0.00, window=0, period=0, periodCount=2, windowCount=2, reason=SOURCE_UPDATE
EventLogger         D    period [?]
EventLogger         D    period [?]
EventLogger         D    window [?, seekable=false, dynamic=false]
EventLogger         D    window [?, seekable=false, dynamic=true]
EventLogger         D  ]
EventLogger         D  timeline [eventTime=0.03, mediaPos=0.00, window=0, period=0, periodCount=3, windowCount=3, reason=SOURCE_UPDATE
EventLogger         D    period [?]
EventLogger         D    period [?]
EventLogger         D    period [?]
EventLogger         D    window [?, seekable=false, dynamic=false]
EventLogger         D    window [?, seekable=false, dynamic=true]
EventLogger         D    window [?, seekable=false, dynamic=true]
EventLogger         D  ]
EventLogger         D  timeline [eventTime=0.03, mediaPos=0.00, window=0, period=0, periodCount=2, windowCount=2, reason=SOURCE_UPDATE
EventLogger         D    period [?]
EventLogger         D    period [?]
EventLogger         D    window [?, seekable=false, dynamic=false]
EventLogger         D    window [?, seekable=false, dynamic=true]
EventLogger         D  ]
TrafficStats        D  tagSocket(103) with statsTag=0xffffffff, statsUid=-1
EventLogger         D  audioEnabled [eventTime=0.39, mediaPos=0.00, window=0, period=0]
EventLogger         D  tracks [eventTime=0.39, mediaPos=0.00, window=0, period=0
EventLogger         D    group [
EventLogger         D      [X] Track:0, id=1, mimeType=audio/mp4a-latm, bitrate=128695, codecs=mp4a.40.2, channels=2, sample_rate=48000, language=und, supported=YES
EventLogger         D    ]
EventLogger         D  ]
EventLogger         D  timeline [eventTime=0.39, mediaPos=0.00, window=0, period=0, periodCount=2, windowCount=2, reason=SOURCE_UPDATE
EventLogger         D    period [634.20]
EventLogger         D    period [?]
EventLogger         D    window [634.20, seekable=true, dynamic=false]
EventLogger         D    window [?, seekable=false, dynamic=true]
EventLogger         D  ]
EventLogger         D  loading [eventTime=0.57, mediaPos=0.00, window=0, period=0, false]

Can you try doing the setup without special threads as a start?

I've tested this by replacing ExoPlayer's control handler by one using the main looper (the handler in ConcatenatingMediaSourceController needs to use a thread of its own because the requirement I'm trying to satisfy is making synchronous additions and removals to the ConcatenatingMediaSource and to achieve that I need a thread that's available to receive the corresponding completion callbacks and release the ExoPlayer control thread). Same result.
Then if the app really needs these additional threads, can you make sure that media sources are added before prepare() is called on the player?
With the same setup as described above but also moving prepare after all calls on the ConcatenatingMediaSource and just before seekToNext, this also doesn't work - in fact there is a significantly smaller amount of logs coming from EventLogger. I would also like to clarify that even if doing this had worked, as far as I can tell it would not be satisfactory as the ConcatenatingMediaSource docs explicitly state that "the list of MediaSources can be modified during playback", meaning that I would expect to need to set at most one MediaSource prior to dispatching prepare(), and then being completely free to add or remove any MediaSources once prepare() has been dispatched.

I have considered the Playlist API yes, unfortunately that's not an option for me at this time.
Regarding making your PR work with ConcatenatingMediaSource, I have pushed a new commit (to my branch) that moves adding the first child MediaSource to before prepare, as well as some more logging to ensure the order of operations:
Finished dispatching all commands
Finished addition on for item id=audio.mp4 index 0
Waiting for addition for item id=audio.mp4 index 0
Finished addMediaSource for item id=audio.mp4 on index 0
playWhenReady changed to true
Received new playback state BUFFERING
Just called prepare
Waiting for addition for item id=dizzy.mp4 index 1
Finished addition on for item id=dizzy.mp4 index 1
Finished addMediaSource for item id=dizzy.mp4 on index 1
Waiting for addition for item id=tears_audio_eng.mp4 index 1
Finished addition on for item id=tears_audio_eng.mp4 index 1
Finished addMediaSource for item id=tears_audio_eng.mp4 on index 1
Waiting for deletion for index 2
Finished deletion for index 2
Finished removeMediaSourceSync on index 2
Received new playback state READY

This looks correct to me, yet it still doesn't work correctly because, even though with the change of preparing only after there's one child media source does mean that playback starts, it's only the first item that plays - the seek is completely ignored.
Note that I think there's been a misunderstanding: I don't care which threads things happen on. What I need to do accomplish the synchronicity that's already built into the Playlist API addMediaSource methods, but using ConcatenatingMediaSource's instead, which are asynchronous:
// This works fine because ExoPlayerImpl.addMediaSource and removeMediaSource are synchronous
exoPlayer.addMediaSource(firstMediaSource)
exoPlayer.prepare()
exoPlayer.addMediaSource(secondMediaSource)
exoPlayer.addMediaSource(thirdMediaSource)
exoPlayer.removeMediaSource(1)
exoPlayer.seekToNext()

// This doesn't work (there's no seek) because ConcatenatingMediaSource.addMediaSource and removeMediaSource are asynchronous
concatenatingMediaSource.addMediaSource(firstMediaSource)
exoPlayer.setMediaSource(concatenatingMediaSource)
exoPlayer.prepare()
concatenatingMediaSource.addMediaSource(secondMediaSource)
concatenatingMediaSource.addMediaSource(thirdMediaSource)
concatenatingMediaSource.removeMediaSource(1)
exoPlayer.seekToNext()

To make the seekToNext() call work when using ConcatenatingMediaSource I have written ConcatenatingMediaSourceController, which blocks the calling thread and uses another one to run completion callbacks on, with said completion callbacks unlocking the calling thread. If I did everything in the same thread my completion callbacks would never run because the calling thread is locked. So the additional thread in ConcatenatingMediaSourceController is just a means for the goal of making seekToNext() work as if I wasn't using ConcatenatingMediaSource, and the thread created in MainActivity has no purpose other than avoiding the main one. You may replace either of the threads backing the handlers with the main one if you so choose and the results of the tests don't vary.
In conclusion, because even when using ConcantenatingMediaSourceController, which should theoretically make the changes to ConcatenatingMediaSource synchronous, the seek is still not processed correctly, I still believe there is something not working correctly with ConcatenatingMediaSource.


[Bug]: PDF text line is cropped & added to the next page

Bug expectation
When generating a PDF from a web page, the page splitting seems to have a problem.
Since an image is better than 1000 words:

The line seems to be split, then the lower half is "glued" on top of the next page.
My configuration to generate this PDF is:
    const pdf = await page.pdf({
      format: 'a4',
      timeout: 120000,
      printBackground: true,
      displayHeaderFooter: !!header || !!footer,
      headerTemplate: header?.html ?? '

',
      footerTemplate: footer?.html ?? '

',
      margin: {
        top: headerHeight ?? 40,
        bottom: footerHeight ?? 30,
      },
    });

With headerHeight & footerHeight the clientHeight of the header & footer respectively, if any.
Bug behavior

[X] Flaky
[X] PDF

Minimal, reproducible example
/*
* Unfortunately I would need to send all the html content to be able to emulate this behavior.
*/

Error string
no error
Puppeteer configuration
No response
Puppeteer version
20.7.3
Node version
16.18.0
Package manager
yarn
Package manager version
1.22.17
Operating system
macOS

I feel like a similar issue has been already reported but I could not find it. In any case, this is a Chromium bug: could you please file it at crbug.com including a minimal reproducible example?

Any solution for this?

The issue does not contain a reproducible example. Therefore, closing as not planned. Please re-test in M117.


Multi-contraction

There are some scenarios where you really want to contract multiple levels of the diagram simultaneously, not just pairwise. For example, if you build the source diagram for the third Reidemeister move, the diagram as a whole is contractible, but the levels aren't pairwise contractible.
The action could maybe be clicking and dragging further than one level.

Logic was done in 765831880cf63697773c73cbe3ec679bc7bf8c2a, the UI remains to be done.


Optimize code logic to avoid some unexcepted exception

Handle some error has been ignored
Change some hard code value to variables
Make log info more appropriate

/ok-to-test

/cc @hanxiaoshuai
for review.

/lgtm Thanks for your fix

/test ci-poseidon-e2e-gce

/approve
/lgtm


wNumb decimal doesn't work :(

wNumb decimal doesn't work :( , i set decimal options with 0/false , and he return for example: 2.9999999, 5.99999996 ....

Same problem here with great numbers like '431 000' that become '430<PHONE_NUMBER>9994'. However I did the decimal to 0

Same here.

Are you on wNumb 1.0.1 or above?

Yes, latest. I just found this function that works though.
   encoder: (value) => {
    	return Math.floor(value)
    }

What specific example with decimals 0 does not work?
// "431000"
wNumb({ decimals: 0 }).to(431000)


Race condition w.r.t. mongodb connector in loopback

It seems there is a race condition w.r.t. creating stones:

https://github.com/crownstone/crownstone-cloud/blob/master/common/models/stone.js#L182

This is even though validatesUniquenessOf is called, which should work properly for the mongo connector. See documentation.
Should we and can we actually define uniqueness on property level limited to a particular [scope] at:

https://github.com/crownstone/crownstone-cloud/blob/master/common/models/stone.json

There seem to be a lot of issues with respect to this bug:

https://github.com/strongloop/loopback/issues/1452
https://github.com/strongloop/loopback-datasource-juggler/issues/892
https://github.com/strongloop/loopback/issues/1637
old: https://github.com/strongloop/loopback-datasource-juggler/issues/87

Sandbox at https://github.com/strongloop/loopback-sandbox/issues is with old loopback version.
If it is not solved within loopback, we will have to do it ourselves (mongo docs).

Has been fixed and pushed to develop and release. The scope is different from the uniqueness option if we define it in the json. Currently we check after saving if the entry is unique, if not, make it so. It's kind of dirty but for now it works.


[fix #367] export align in list-menu

I changed only 2 lines of css

I tested this, it seems to work just fine without any regressions elsewhere (the list_menu class is only used in one UI place).
Merging.