Added a CS3API compliant data exporter to Mentix

A new HTTP endpoint has been added that exports data in a format compliant to the CS3API ProviderInfo structure.

@Daniel-WWU-IT some hound linting

@Daniel-WWU-IT you can just use small-case for the first letter for internal methods. Saves you from adding comments.

@Daniel-WWU-IT you can just use small-case for the first letter for internal methods. Saves you from adding comments.
They aren't internal, otherwise I would have done so. I add comments to types and functions where it makes sense, not just to make the hound happy ;) And these are not the only exported funcs/types that lack comments.

Ideally, all the exported methods should have comments, even though they are self-explanatory ;)
Could you point me to those which aren't commented? I might as well fix those.

Ideally, all the exported methods should have comments, even though they are self-explanatory ;)
Could you point me to those which aren't commented? I might as well fix those.

I think I stumbled upon a few in some other services, not sure if this has changed yet. But I'll go through my code and comment all the obvious ;)

Comments added... hope I got all places

Awesome! Thanks!


Using capturing precondition in async method in struct lead to invalid IL

This bug is related to the #157, but not similar.
Consider following code:
struct Foo
{
    public int Limit { get; set; }

    public Foo(int limit) : this()
    {
        Limit = 42;
    }

    public async Task<int> FooAsync()
    {
        Contract.Requires(Limit == 42);

        await Task.Delay(42);

        return 42;
    }
}

Running this code will lead to InvalidProgramException when preconditions are enabled.
CC version: 1.8+. This is not a regression, this stuff never worked properly.
Please note, the if the Contract.Requires will use arguments everything would be fine. Only when precondition is using this the app will fail.

@SergeyTeplyakov Are you working on this?

@hubuk At least not right now. I hope to merge pull requrests this week, so you can grab it.

Grabbed


Upgrade cert-manager to v1.14.4 and start using cert-manager-startupapicheck instead of cert-manager-ctl

/approve


Update ckb to 0.3.0 and update the repository

CKB is moved to its new repository: https://github.com/ckb-next/ckb-next so I changed and updated it to the new version.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Additionally, if adding a new cask (I also checked these because of the changed repository):

[X] Named the cask according to the token reference.
[X] brew cask install {{cask_file}} worked successfully.
[X] brew cask uninstall {{cask_file}} worked successfully.
[X] Checked there are no open pull requests for the same cask.
[X] Checked the cask was not already refused in closed issues.
[X] Checked the cask is submitted to the correct repo.

==> Downloading https://github.com/ckb-next/ckb-next/download/v0.3.0/ckb-next_v0.3.0.dmg
curl: (22) The requested URL returned error: 404 Not Found
audit for ckb: failed
 - download not possible: Download failed on Cask 'ckb' with message: Download failed: https://github.com/ckb-next/ckb-next/download/v0.3.0/ckb-next_v0.3.0.dmg
Error: audit failed for 1 cask: ckb

@MegaCookie Missed out the releases directory in the URL.
https://github.com/ckb-next/ckb-next/releases/download/v0.3.0/ckb-next_v0.3.0.dmg


Update cupy.array_api

Apply patches from the following two upstream PRs:

https://github.com/numpy/numpy/pull/21260
https://github.com/numpy/numpy/pull/21377

After #6853 is merged I'll send another update PR.
ps: I think this PR can be backported?

/test mini,array-api

@kmaehashi do you know what's up with Jenkins? Other two CI failures are irrelevant.

I see, thanks @kmaehashi. The array-api CI fails likely because something is wrong when checking out the test suite. The cuda117 CI failure is irrelevant.

/test mini

LGTM! Thanks!


Add GOV.UK cross domain tracking to design system

What
Add design system website to cross domain tracking with GOV.UK. Full instructions here and should speak to a PA in the AAA GOV.UK team before doing.
https://docs.google.com/document/d/1Scq-axCUknouQhKkf5ppqcqljeWSo62njL4p9qGcIjo/edit
Why
So we can get cross domain data with GOV.UK
Who needs to know about this
Performance analyst, developer
Done when

[ ] Reviewed documentation
[ ] Implemented cross domain tracking

Replaced by newer work. The Data team will be implementing GA4 for us.


Capitalization plus non-Vietnamese characters leads to inconsistent tokenization

I see that the tokenizer splits on certain non-Vietnamese Latin characters, such as å, ä, č, ç, ë, ğ, ï, ı, ñ, ö, ö, ø, š, ş, ü, and ÿ (which is not a complete list, I expect, just the ones I tested). This is not ideal for text that contains foreign words, but it is also not uncommon for analyzers to split on foreign characters.
I also see that adjacent capitalized words are tokenized together, including names. This is also not always ideal in cases like International Plant Names Index, but it is understandable.
However, these two interact unexpectedly; if the second letter of a capitalized word is a foreign character, it doesn't split. For example, the Spanish word año (which means "year") is tokenized as a + ñ + o, like this:
{
  "tokens" : [
    {
      "token" : "a",
      "start_offset" : 0,
      "end_offset" : 1,
      "type" : "phrase",
      "position" : 0
    },
    {
      "token" : "ñ",
      "start_offset" : 2,
      "end_offset" : 3,
      "type" : "residual",
      "position" : 1
    },
    {
      "token" : "o",
      "start_offset" : 4,
      "end_offset" : 5,
      "type" : "phrase",
      "position" : 2
    }
  ]
}

However, the capitalized form, Año is tokenized as añ + o, like this:
{
  "tokens" : [
    {
      "token" : "añ",
      "start_offset" : 0,
      "end_offset" : 2,
      "type" : "allcaps",
      "position" : 0
    },
    {
      "token" : "o",
      "start_offset" : 3,
      "end_offset" : 4,
      "type" : "phrase",
      "position" : 1
    }
  ]
}

It seems that capitalization should not change the tokenization of a single word.
I'm also seeing similar behavior with other splitting characters: r=22 → r + 22, but R=22 → r= + 22. Similarly, x&y vs X&Y, x*y vs X*Y, x+y vs X+Y, and others.

@Trey314159 Thank you very much for this report, the tokenizer should not analyze the foreign words.
It seems that we have a lot of issues with the Vietnamese tokenizer library, I used a very old version for the plugin (released in 2009). I tried to replace this old one with the latest one here https://github.com/phuonglh/vn.vitk but the performance was very poor, because of Spark.
In order to use the new one with Elasticsearch, I think we should reimplement the tokenizer without Spark. What do you think?

Oddly, I'm getting messages from @duydo in email, but not seeing them here. Not sure where/how to respond properly.

Hi @Trey314159,
I've just fixed the offset issue #25 and implemented your suggestions for the tokenizer. Now the tokenizer does not split non-Vietnamese characters, does not tokenize the capitalized words together, split words/character correctly.

Thank you very much for your contribution.

Duy

@duydo, thanks for the update! I've downloaded the zip and I'll try to give it a thorough testing next week and report back here.

@Trey314159 I just found a bug when doing the query, please don't test that version util it's fixed.

@duydo, let me know when there's a new version.

Hi @Trey314159,
After investigating I found that the original tokenizer is not thread-safe, it's a root cause of the NullPointerException as you reported. I've just re-implemented a new thread-safe tokenizer, can you please give it a try? Here is the new version for ES v5.3.2 elasticsearch-analysis-vietnamese-5.3.2.zip.
Again, thank you very much for raising this critical issue :-)

Cool! I've downloaded it and I'll give it a try next week.

I close this issue, it will be fixed in new tokenizer #37


WIP: Adding option to support subdomains in tileUrl

@jbeezley I need to add a test. Should I add a regression test (image) or some sort of unit test?

Preferably unittests.  In other places, I have used a mocked map to avoid generating an actual map object and to track the internal calls made.  It would probably be good to expose something like this more generally for testing.

Preferably unittests. In other places, I have used a mocked map to avoid generating an actual map object and to track the internal calls made. It would probably be good to expose something like this more generally for testing.

Thanks. I will see if I can find a test that is similar. Are we using mocked map for unit testing?  I agree it would be nice to have it somewhere else for general purpose testing.

Yes, in the test I linked above. https://github.com/OpenGeoscience/geojs/blob/master/testing/test-cases/phantomjs-tests/mapInteractor.js#L25
I am doing some more elaborate mocking in some of the tests in the refactor branch as well.

Yes, in the test I linked above. https://github.com/OpenGeoscience/geojs/blob/master/testing/test-cases/phantomjs-tests/mapInteractor.js#L25

okay, thanks. Should I move mocked map to a common location if that's okay in my branch?

@jbeezley I also changed to {z} vs {zoom} since {z} seems to be conventional.

It could be worthwhile to move that code.
In other news, it looks like there is still a race condition in the phantomjs test startup.  Blanket is starting the test runner before jasmine is done loading.  One of these days I want to move to a standard test runner like jsunit.

@jbeezley I am thinking to add test in the newer code, for now, I will mark it done and create a issue for

Testing
Porting to new code -- @manthey do you want to take care of this?

@jbeezley?

I suppose this is okay, but we will need to be more picky about PR's once the refactor lands.

I agree :+1: .  I am hoping that the refactored code is going to land soon.


why the readme.md updated ?

because  I find much thing has changed, Please!

 Used mask rcnn model?

The old readme has lots of irrelavant contents and now I remove these contents. Please follow the new readme to implement your experiment.

The old readme has lots of irrelavant contents and now I remove these contents. Please follow the new readme to implement your experiment.

the pytorch is 0.x.x so , I guess cuda10 can't be used for this project?

Yes, you should use cuda 9.0 and pytorch==0.4.1. Readme is updated.


which should take an optional parameter...the paths to search

and Command should be able to take an optional list of paths to manually search for the program, which get passed to which

Should this optional parameter take precedence over default search path ?
e.g. If I have "ls" in "/my/home/dir" - which "ls" should which return ? ("/bin/ls" or "/my/home/dir/ls")
import sh
sh.which("ls", "/my/home/dir")

I think it should return /my/home/dir/ls otherwise user would not have passed additional argument
Also, I assume that optional path would be a list, right ?

You've got it right @mandarvaze
The idea I was going for was the constructor would take an optional param for paths that defaults to None.  If it's None, the paths are constructed to be either an empty list (in the case of "PATH" not in os.environ) or the list of your runtime paths: https://github.com/amoffat/sh/blob/master/sh.py#L311-L313, which would then be passed into which (and the existing logic in which refactored out)
It's not super complex but would allow people to override where their programs are searched for without needing to modify their PATH


SessionGuard does not check remember_token column existence

Laravel Version: 5.3.24
PHP Version: 7.0.13
Database Driver & Version: MariaDB/MySQL 10.1.19

Description:
SessionGuard->logout() does not check whether a remember token field exists (logging out), while AuthenticateUsers->attemptLogin() does check by $request->has('remember').
Default LoginController with AuthenticateUsers trait. The call to AuthenticateUsers->logout() will call $this->guard()->logout() which calls $this->refreshRememberToken($user).
This means an error will be thrown when logging out. The error is an SQL error (or sqlite etc.) saying the remember_token column does not exist.
Steps To Reproduce:
Create a custom App/User and migration, without a 'remember me' token. Try logging out. Using default session guard etc. (mainly achieved by make:auth).

@bennoz Why would logout method have that? It is automatically refreshed when the user logs out.  This is not an error in the framework. If you are not using the default user migration, then i think you need to implement your own custom auth provider in this regard.

My point is basically about the ease of use of this framework. The framework allows us to use a lot of defaults, and even checks whether we have a remember_token column except for the SessionGuard. This essentially renders the SessionGuard as out of line.
In Laracasts for example something said a lot is that if we don't need it, we can cut it out! But, when we do in fact cut this specific part out, we get an error only because of the SessionGuard. I understand you can use a custom provider to solve this, but this is about the adaptability of this framework and therefore an issue of this framework.

https://github.com/laravel/framework/blob/5.3/src/Illuminate/Auth/SessionGuard.php#L578
Session Guard tries to set the remember token, without checking even if it exists or not.

Well basically logging in by setting the $remember parameter to true in $guard->attempt() should also fail, because that also does not check for existence of the remember token.

That is indeed what would happen when you pass the parameter, but, again I'm talking about default behaviour when using the AuthenticatesUsers trait. Me, as a framework user does not even touch the $guard->attempt() method, as everything is set up by default to make use of the LoginController. So there is no way for me as a simple developer to make sure the remember token is not being set. Hence the sensible way to disable the feature, which is removing the token column, should be respected by the framework.

@bennoz Again, it is something you need to implement on your own. It's not an issue with the framework. Instead of criticizing the implementation, how about you create a pull request for inclusion into the framework.

I unfortunately have no knowledge of both the pull requests and the internal workings of the framework. Anyway, if it's not an issue, then why would I? I'm merely pointing out an inconsistency within the use of the framework, which is from my (framework) user point of view.
If this really is not an issue, I expect an authorised developer to close this.

@bennoz If you are pointing out an inconsistency, then at least you should be the one who shall come up with a solution.  It's an open source framework. Just fork a copy of the framework, implement your solution & open a pull request for inclusion into the official framework repo.

Fixing this is going to need breaking changes. It won't be an easy fix. Authenticatable and UserProvider will have to change. Maybe fix this in 5.4 ?

Yeah 5.4 will be right one.

The main issue will be when you are fetching the user details by the token value. For instance, if the remember token field name is different. The rest i have been able to refactor.


updated autogenerated types from API

Yep, I can't see anything concerning, and I ran e2e, integration tests, and did a fair bit of manual testing and nothing seems broken!


Bump FMP version to 4.0.0

Signed-off-by: svor<EMAIL_ADDRESS>If try to deploy this sample on OpenShift 4 by mvn clean fabric8:deploy -Popenshift, I see  an error:
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.275 s
[INFO] Finished at: 2019-11-08T14:24:29Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.fabric8:fabric8-maven-plugin:3.5.40:build (default) on project fuse-rest-http-booster: Execution default of goal io.fabric8:fabric8-maven-plugin:3.5.40:build failed: No <dockerHost> given, no DOCKER_HOST environment variable, no read/writable '/var/run/docker.sock' or '//./pipe/docker_engine' and no external provider like Docker machine configured -> [Help 1]
[ERROR]

This PR bumps FMP version to 4.0.0 make it possible to deploy this sample on OpenShift 4. It also works for OpenShift 3.

@valdar Could you take a look please

It seems it is fine for the master community branch! \O/
@svor thanks for this, could you do that for the other boosters as well?

https://github.com/jboss-fuse/fuse-configmap-booster
https://github.com/jboss-fuse/fuse-springboot-circuit-breaker-booster
https://github.com/jboss-fuse/fuse-istio-distributed-tracing-booster
https://github.com/jboss-fuse/fuse-health-check-booster

I will merge when all of them are passing checks just to be sure since it is a major version bump.

@valdar
I did it for

fuse-configmap-booster (https://github.com/jboss-fuse/fuse-configmap-booster/pull/33)
fuse-health-check-booster (https://github.com/jboss-fuse/fuse-health-check-booster/pull/26)

but unfortunately I can't confirm that it'll be work for fuse-istio-distributed-tracing-booster and fuse-springboot-circuit-breaker-booster, probably for these samples need to make more investigations

@valdar we're using the example for CodeReady Workspaces 2.0 and our release is imminent. I think the change itself is not in question, right? We'd appreciate it if you could give an ETA on merging this fix, so we can plan accordingly.

@tsmaeder, of course, the merge is not in question. I just would like to be sure that all the boosters are aligned and everything works properly.
If for your release you just need this one I guess we can go ahead and merge, if you need all of them I can not give you an ETA.

@valdar no, as far as I know, this is the repo we use in the example. Thx for listening.

@svor @tsmaeder since we are upgrading version, can I go to 4.3.1 that is the latest one? or do you need specificalli 4.0.0?

Personally, I have not problem with that. I assume it works with OS 3 and 4?

It should yes (bugs aside) :)

@svor can you update to 4.3.1 your 3 commits? I will merge them as soon as the CI check passes. And do the other 2 projects myselfe.

I've updated PRs for fuse-health-check-booster adn fuse-rest-http-booster.
FMP-4.3.1 doesn't work for fuse-configmap-booster, when I try to deploy it, I see an error: https://github.com/jboss-fuse/fuse-configmap-booster/pull/33#issuecomment-558078314

Thanks @svor !


X Error: BadMatch on Nvidia GTX 1080

I'm running Arch Linux with the latest nvidia, nvidia-utils, and nvidia-libgl packages as well as mesa.
The error I get is:
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  154 (GLX)
  Minor opcode of failed request:  5 (X_GLXMakeCurrent)
  Serial number of failed request:  165
  Current serial number in output stream:  165

This is my initialization code where it fails at bgfx::init():
    if (not glfwInit())
    {
        throw std::runtime_error("Failed to initialize GLFW");
    }

    window = glfwCreateWindow(
        width, height, windowTitle.c_str(), nullptr, nullptr
    );

    if (not window)
    {
        glfwTerminate();
        throw std::runtime_error("Failed to create a window");
    }

    glfwMakeContextCurrent(window);

    // Setup some platform specific stuff
    bgfx::PlatformData pd;
    pd.ndt = glfwGetX11Display();
    pd.nwh = reinterpret_cast<void*>(glfwGetX11Window(window));
    pd.context      = nullptr;
    pd.backBuffer   = nullptr;
    pd.backBufferDS = nullptr;

    bgfx::setPlatformData(pd);

    if (not bgfx::init())
    {
        throw std::runtime_error("Failed to initialize bgfx");
    }

Now, I found a workaround for this issue, namely to
    glfwWindowHint(GLFW_ALPHA_BITS, GLFW_DONT_CARE);
before the creation of the window. This solves the issue, but I feel like it might be worth reporting anyway, as I'm not sure if this is a bug - or which codebase the issue would belong to. I can't say I know why this worked. I saw an SDL bug which inspired me to try several GLFW hints to see if I could affect things. I assume the default alpha bits value is causing the issue.
This was not an issue on Ubuntu 16.04 the last time I tried.

There is full working example of GLFW implementation:
https://github.com/bkaradzic/bgfx/blob/master/examples/common/entry/entry_glfw.cpp
Make sure bug you're reporting can be reproduced with implementation provided in bgfx, before submitting issues.

My apologies! It did also fail with the helloworld example once I got the --with-glfw flag in there.

Try debug build, you might get more info about it.

It should be fixed now.


Ansible Tower job template created with wrong extra_vars

when passing the following example in the options
:extra_vars => { 'key1' => 'default_val1', 'key2' => 'default_val2' }

the extra_vars field in the job template turns out to be
OrderedDict([(u'key1', u'default_val1'), (u'key2', u'default_val2')])

@miq-bot assign @bdunne
cc @syncrou

@bzwei Was this done through create_in_provider or directly through the gem?

create_in_provider

I think create_in_provider needs to ensure that the extra_vars are a JSON string before sending it across.

Yes, it works when we pass in a JSON.


Undo changes made by commit #3849 for certain files

Describe the solution you'd like
The pull request #3849 is pointless; on modern computers, saving such a small amount of storage space is negligible. However, the consequence of this space-saving effort is the inability to use bash, which in turn disables many troubleshooting methods. In Chinese, there's a proverb to describe this situation: "Losing the watermelon while picking up the sesame seeds," meaning you're sacrificing something important for a trivial gain.

Type of feature
Other
Additional context
No response

Agree.
Please bring shell back.

PS：提交那个PR的人就是个SB！


tab delay property for Tabs

"native-base": "^2.2.1",
"react": "16.0.0-alpha.12",
"react-native": "0.46.3",
Actual output - tab switching takes some amount of time for switching when other tab is selected by
touching
Expected output - tab delay should be reduced
<Tabs initialPage={0} tabDelay={0}>
       <Tab heading="send">
       <Send/>
       </Tab>
       <Tab heading="request">
       <Request/>
       </Tab>
       <Tab heading="add">
       <Add/>
       </Tab>
     </Tabs>

got some information from https://github.com/skv-headless/react-native-scrollable-tab-view
identified property scrollWithoutAnimation  but still takes time to switch

Fixed in the latest release

this is still happening on 2.7.2

@akhil-geekyants
may you try inside TabTwo you fetch some data and render it, and then you press another tab, it will be slow and become freeze


docs: update user guide and make find command docs consistent

Had some issues with rebasing and needed to revert the earlier PR and submit a new one


[BUG]

Start the server .dat and then crashed with following error below.
Expected behavior
A clear and concise description of what you expected to happen.
crash-2020-05-02_06.37.39-server.txt
Mod list:
fabric-api-0.7.0+build.330-1.16 / fabric-api-0.10.1+build.336-1.16
fabric-carpet-20w18a-1.3.21+v200429
simpleauth-1.4.1-MC20w18a

Hi, thanks for the report.
I think I have uploaded the dev version on CurseForge. Could you try this one?
https://samolego.github.io/projects/ci?project=simpleauth&build=9

Thank you! It works!
samo_lego<EMAIL_ADDRESS>于2020年5月2日周六 下午7:12写道：

Hi, thanks for the report.
I think I have uploaded the dev version on CurseForge. Could you try this
one?
https://samolego.github.io/projects/ci?project=simpleauth&build=9
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/samolego/SimpleAuth/issues/3#issuecomment-622923540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APNPJJPWSXYJ64RW2YOTJR3RPPPYPANCNFSM4MXSQ5OQ
.

Nice! I'm closing this then. And reupload it to the CF.

Thank you! sir.
samo_lego<EMAIL_ADDRESS>于2020年5月2日周六 下午8:40写道：

Closed #3 https://github.com/samolego/SimpleAuth/issues/3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/samolego/SimpleAuth/issues/3#event-3295375402, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APNPJJIXTH5QU4WZZ3WJHXTRPP2BBANCNFSM4MXSQ5OQ
.


Read XML as String not File

Hello,
I would like to read the XML from a string, not from a file. I'm doing this for JSON and it's trivial. But I'm having a bad time to do with XML.
Any suggestion ?
Thank you

Use XmlReader.xmlRDD to process an RDD or DataFrame of String

Do you think that we suppose to have a standard API to read a file/string that's not ortogonal to the source ?

What do you mean? You can already read XML files directly from files. That's not orthogonal right?

IMHO I think we should have an orthogonal interface to read from string as well, not just for file:
spark.read.json(Seq("foo").toDS)
spark.read.xml(Seq("foo").toDS)

That's, roughly, already what I posted above. Make an RDD from your Dataset/DataFrame and pass to the method I indicated.

@srowen , I understood, thanks, it's perfect working.
   val df = new XmlReader().xmlRdd(spark, spark.sparkContext.parallelize(Seq(string))).toDF
What I'm saying is for the enhancement, would be nice to have a standard way to read from string on the same way we do have for JSON, that's it.

You might be able to define a second implicit for DataFrameReader that accepts a Dataset of String, sure. Open a PR if you are up to it.


4/10/2019 Publish

Docs Build status updates of commit 20f84d8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3fd2ff6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d86f1d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

docs-ref-conceptual/release-notes-azure-cli.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update Download

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

WARNING
All the invalid issues will be rejected!!

Before going further

If your problem is a bug with the youtube-dl program or a request for new site support please report it here

Make sure you are using the latest youtube-dl-gui version: Options > About tab. If it's not please download & install the latest version for your OS and check if your issue still persists

Make sure you are using the latest youtube-dl version: Click the Update button on the main screen and check if your issue still persists

Make sure you searched the bugtracker for similar issues including closed ones

[x] I assure that my problem is NOT with youtube-dl
[x] I've verified and I assure that I'm running youtube-dl-gui 0.3.8
[x] I assure that i am using the latest version of youtube-dl
[ ] Searched bugtracker

What is the purpose of your issue?

[ ] Bug during the download process (encountered problems after hitting the Download button)
[ ] Bug other (encountered other problems with youtube-dl-gui)
[X] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Please remove the following section between the (---) if your problem does not belong to the bug during the download process category
Provide the full verbose output as follows:

Add -v flag to Options > Commands tab
Re-try to download the URL
Go to Options > Log tab and click the View Log button
Copy the whole content of the log file and insert it between the triple ``` part

[delete me and insert your log content here]

Please remove the following section between the (---) if your problem does not belong to the first two categories (bug report)
What operating system do you use ?
List of actions to perform to reproduce the problem:

..
..
..

What is the expected behaviour ?
What happens instead ?

Description of your issue, suggested solution and other information. Please make sure the description is worded well enough to be understood.
As I am not a programmer and this program is by far one of the best and I use it quit often. I file this under issue but really it is rather a request.
Could the programmer of this program please put something extra in the update procedure to first check of the -dl command line application is already  up to date. Because sometimes I as a user make the mistake by pressing the update button by mistake after I already updated the program a very short time back.
When you press the update button it download the -dl command line application all over again. I know this issue is not really the programmer problem but rather I ask if something like this could be included in the gui program. I know the youtube-dl program have his own update flag so it should be easy to include in the youtube-dlg gui program.
Thank you

What is this title?


Simplify embedder, launcher, and docker image. Get rid of different distro flavors

We only ever use savant in practice, so get rid of the others to make it simpler to maintain.
Docker start-indy.py script was a mess; clean this up and make it work properly for all options.
Make indy-docker-kit assembly that people can use to extend / build their own image without using FROM

@ruhan1 @ligangty This change will mean changing the launcher artifactId used in Docker image builds on our various deployments. I don't want to merge this without discussion about the right timing for it.
What do you think? Can we merge this immediately or should we wait?


Links to the PyTorch models

Andrej. Could you add links to all PyTorch models in the table?

see latest update to readme!


Adds glibcLocales to pycharm-community

Description of changes

In non-NixOS systems, if the used keyboard has some non ASCII characters (like á ã ç é ö) those would not show up after typed.
Found that too that if some file name has non ASCII characters the pycharm will not show the file.
This PR is supposed to fix this.
How to test?
nix run --refresh github:PedroRegisPOAR/nixpkgs/adds-glibcLocales-to-pycharm-community#jetbrains.pycharm-community

It is not need, but for the sake of completeness, if you want to install it:
nix profile install --refresh github:PedroRegisPOAR/nixpkgs/adds-glibcLocales-to-pycharm-community#jetbrains.pycharm-community

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I've installed PyCharm via Nix in Ubuntu 22.04.3 LTS, and I was suffering with the lack of non ASCII characters.
The @PedroRegisPOAR's solution worked nicely for me.

Sorry for the massive ping. It was by mistake.
It was a git push --force 🤦♂

Please resubmit the PR, as any further conversation here will mass ping people again.


Training duration question

Not realy an issue, just hoping to learn about the normal behaviour of the software. I hope you don't mind I post this here. If there are other places I should go for that, feel free to let me know.
I have a RTX 3060 12GB and training the bear example to 30000 takes about 25 minutes on my computer. If I then start in2n-small or in2n-tiny to use the prompt "make it a grizzly", it then estimates and actually takes about 24 hours to do another 30000.
Is this a normal duration? I know I didn't use any downsampling of the images at all, but the difference between initial training and the instructed version is quite steep, therefor the question.
I read and so am aware 30000 extra steps is not necessary and that is also my experience, but please let me know about the duration estimation. Thanks!

This should check out I think. I think in practice, you only have to train in2n for 10k iters, so that usually will take an hour.

For running  ns-train in2n , set --max-num-iterations as 30000 + .
Here, 30000 is the default training iteration of nerfacto.
And, since in2n starts from nerfacto checkpoints, it counts the number of iterations from 30000.
So, if you set --max-num-iterations as 60000 (the actual iterations for in2n is 30000), you may see the correct ETA.
I think the reason for the wrong ETA is that the default value of --max-num-iterations is 15,000, which is set smaller than the default iterations of nerfacto.


bug: unexpected behavior of inset colorbar

Description
Unexpected behavior of inset colorbar with keywords tickloc and labelloc.
Steps to reproduce
The code below
import proplot as pplt
import numpy as np

fig, axes = pplt.subplots(None, 1, 2)
cm = axes[0].scatter(*np.random.rand(4, 10), vmin=0, vmax=1)

axes[0].colorbar(cm, loc='ll', length=10, width=0.8, label='abc', tickloc='top')
axes[1].colorbar(cm, loc='ll', length=10, width=0.8, label='abc', labelloc='top')

gives this

If I understand correctly,
left panel: we would expect the ticks shown at the top when tickloc='top' is set.
right panel: strange padding when placing the label on the top.
I tried to fix the padding in the right panel, it turns out not easy for me ...
Proplot version
Paste the results of import matplotlib; print(matplotlib.__version__); import proplot; print(proplot.version)here.
3.4.3
0.9.5.post284

Yeah... the inset colorbar implementation is unfortunately very flimsy right now. I'm working on a fix in #311 that will automatically adjust the position of the colorbar axes and frame using its tight bounding box. Have already done the hard part (figured out how to auto-anchor an axes and adjust a background frame), just have to integrate with ax.colorbar().
Will try to merge #311 before the next release (.....sometime this month) because I'm uncomfortable publishing a new release with such fragile behavior. It was under-tested in previous versions.

Thank you Luke for the hard work! Look forward to the fix.
BTW, one more example about incorrect padding (too large) in the third panel below. From your description, I guess auto-anchor things would fix this behavior as well ;)
Also another strange behavior, note the location of label in the middle panel, it has been changed when plotting the right panel. If I use different cm objects, then it would be at the correct location as in the previous figure.

Code
import proplot as pplt
import numpy as np

fig, axes = pplt.subplots(None, 1, 3)
cm = axes[0].scatter(*np.random.rand(4, 10), vmin=0, vmax=1)

axes[0].colorbar(cm, loc='ll', length=10, width=0.8, label='abc', tickloc='top')
axes[1].colorbar(cm, loc='ll', length=10, width=0.8, label='abc', labelloc='top')
axes[2].colorbar(cm, loc='ll', length=10, width=0.8, label='abc', labelsize='x-small', ticklabelsize='x-small')


[DEPLOYED PROJECTS] : Deploy Diabetes Prediction System as Django Web App!

Description
Added Deployment of Disease Prediction System using Django Web App.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

(Add x in the [] to mark as completed.)
Related Issues or Pull Requests
Issue Number : #253

Please review it @khusheekapoor .
It was great contributing to MindWave!😇


Proposal: implement IP generator for nodes and file discoveries

This PR proposes a simple way, inspired by Ansible, to generate multiple IP addresses for nodes and file discoveries. With this PR, one can manage hundreds of docker instances by simply:
$ swarm manage -H <swarm_ip:swarm_port> 192.168.0.[10:200]:2375
The generator will take care of the pattern 192.168.0.[10:200]:2375 and make a list of IP addresses starting from <IP_ADDRESS> to <IP_ADDRESS> in a go.
Another example,
$ swarm manage -H <swarm_ip:swarm_port> 192.168.0.[10:123]:2375,192.168.1.[10:250]:2375
Signed-off-by: Chanwit Kaewkasi<EMAIL_ADDRESS>

@vieux @aluzzardi could you please take a look? Thank you!

I like it, thanks @chanwit
I think we could also support it with the file discovery service.

no problem @vieux. I will do for the file too.

It's done, @vieux. Could you please take a look. Thank you.

besides my nit, LGTM
@aluzzardi can you take a look ?

ping @vieux @aluzzardi
Thank you!

Sorry for another ping @vieux @aluzzardi
Not sure if you have other comments for this?

rebased

@chanwit I would only support IP to simplify the code
diff --git a/discovery/generator.go b/discovery/generator.go
index fdd84f3..67dfa28 100644
--- a/discovery/generator.go
+++ b/discovery/generator.go
@@ -3,64 +3,34 @@ package discovery
 import (
 	"fmt"
 	"regexp"
+	"strconv"
 )

 //
-// This function increases value in the form of String.
-// It checks the last character of string 's'
-// then returns the value next to s.
-//
-// For example,
-//
-//  - "0" will become "1"
-//  - "01" will become "02", the leading zero will be preserved
-//  - "09" will become "10", the leading zero will be increased to "1"
-//  - "9" will become "10", an extra string "1" will be prepended, if overflow
-//  - "a0" will become "a1"
-//  - "a9" will become "b0", as the last digit will overflow and change "a" to "b"
-//  - "az" will become "ba"
-//  - "AZ" will become "BA"
-//
-func incString(s string) string {
-	if s == "" {
-		return "1"
-	}
-	lastIndex := len(s) - 1
-	lastChar := s[lastIndex]
-	switch lastChar {
-	case '9':
-		return incString(s[:lastIndex]) + "0"
-	case 'Z':
-		return incString(s[:lastIndex]) + "A"
-	case 'z':
-		return incString(s[:lastIndex]) + "a"
-	default:
-		return s[:lastIndex] + string(lastChar+1)
-	}
-}
-
-//
 // IP and Hostname generator
 //
 func Generate(pattern string) []string {
-	re, _ := regexp.Compile(`\[(.+):(.+)\]`)
+	re, err := regexp.Compile(`\[(.+):(.+)\]`)
+	if err != nil {
+		return []string{""}
+	}
+
 	submatch := re.FindStringSubmatch(pattern)
 	if submatch == nil {
 		return []string{pattern}
 	}

-	from := submatch[1]
-	to := submatch[2]
+	from, errFrom := strconv.Atoi(submatch[1])
+	to, errTo := strconv.Atoi(submatch[2])
+	if errFrom != nil || errTo != nil || to < from {
+		return []string{""}
+	}

-	template := re.ReplaceAllString(pattern, "%s")
+	template := re.ReplaceAllString(pattern, "%d")

 	result := make([]string, 0)
-	for val := from; ; val = incString(val) {
-		entry := fmt.Sprintf(template, val)
-		result = append(result, entry)
-		if val == to {
-			break
-		}
+	for ; from <= to; from++ {
+		result = append(result, fmt.Sprintf(template, from))
 	}

 	return result
diff --git a/discovery/generator_test.go b/discovery/generator_test.go
index 9ff757e..34d2309 100644
--- a/discovery/generator_test.go
+++ b/discovery/generator_test.go
@@ -25,18 +25,20 @@ func TestGeneratorMatchFailedNotGenerate(t *testing.T) {
 }

 func TestGeneratorSimple(t *testing.T) {
-	ips := Generate("127.0.0.[00:09]")
-	assert.Equal(t, len(ips), 10)
-	assert.Equal(t, ips[0], "<IP_ADDRESS>")
-	assert.Equal(t, ips[1], "<IP_ADDRESS>")
-	assert.Equal(t, ips[2], "<IP_ADDRESS>")
-	assert.Equal(t, ips[3], "<IP_ADDRESS>")
-	assert.Equal(t, ips[4], "<IP_ADDRESS>")
-	assert.Equal(t, ips[5], "<IP_ADDRESS>")
-	assert.Equal(t, ips[6], "<IP_ADDRESS>")
-	assert.Equal(t, ips[7], "<IP_ADDRESS>")
-	assert.Equal(t, ips[8], "<IP_ADDRESS>")
-	assert.Equal(t, ips[9], "<IP_ADDRESS>")
+	ips := Generate("127.0.0.[00:11]")
+	assert.Equal(t, len(ips), 12)
+	assert.Equal(t, ips[0], "<IP_ADDRESS>")
+	assert.Equal(t, ips[1], "<IP_ADDRESS>")
+	assert.Equal(t, ips[2], "<IP_ADDRESS>")
+	assert.Equal(t, ips[3], "<IP_ADDRESS>")
+	assert.Equal(t, ips[4], "<IP_ADDRESS>")
+	assert.Equal(t, ips[5], "<IP_ADDRESS>")
+	assert.Equal(t, ips[6], "<IP_ADDRESS>")
+	assert.Equal(t, ips[7], "<IP_ADDRESS>")
+	assert.Equal(t, ips[8], "<IP_ADDRESS>")
+	assert.Equal(t, ips[9], "<IP_ADDRESS>")
+	assert.Equal(t, ips[10], "<IP_ADDRESS>")
+	assert.Equal(t, ips[11], "<IP_ADDRESS>")
 }

 func TestGeneratorWithPort(t *testing.T) {
@@ -57,19 +59,14 @@ func TestGeneratorWithPort(t *testing.T) {

 func TestGenerateHostnames(t *testing.T) {
 	ips := Generate("web[00:03].abc.com")
-	assert.Equal(t, "web00.abc.com", ips[0])
-	assert.Equal(t, "web01.abc.com", ips[1])
-	assert.Equal(t, "web02.abc.com", ips[2])
-	assert.Equal(t, "web03.abc.com", ips[3])
+	assert.Equal(t, "web0.abc.com", ips[0])
+	assert.Equal(t, "web1.abc.com", ips[1])
+	assert.Equal(t, "web2.abc.com", ips[2])
+	assert.Equal(t, "web3.abc.com", ips[3])

 	ips = Generate("[00:03]h.abc.com")
-	assert.Equal(t, "00h.abc.com", ips[0])
-	assert.Equal(t, "01h.abc.com", ips[1])
-	assert.Equal(t, "02h.abc.com", ips[2])
-	assert.Equal(t, "03h.abc.com", ips[3])
-
-	ips = Generate("web-[a1z:a2b].example.com")
-	assert.Equal(t, "web-a1z.example.com", ips[0])
-	assert.Equal(t, "web-a2a.example.com", ips[1])
-	assert.Equal(t, "web-a2b.example.com", ips[2])
+	assert.Equal(t, "0h.abc.com", ips[0])
+	assert.Equal(t, "1h.abc.com", ips[1])
+	assert.Equal(t, "2h.abc.com", ips[2])
+	assert.Equal(t, "3h.abc.com", ips[3])
 }

Do you really need hostname ?

@vieux not really.
I'll remove hostname generator to make things simpler.

@vieux could you please take a look. thank you.

@chanwit why do you need to keep 00 -> 01 -> 02 ? an IP is composed of numbers, 00 -> 1 -> 2 should be the same.

@vieux sorry my bad. Reworking.

@vieux done. With removal of hostname generator, I am now using a simple loop in the generator, as suggested by @aluzzardi.
PTAL

Other than that, LGTM. Waiting for the very few changes needed to the doc for convenience :)

@chanwit thanks for your contribution, I added the quotes in the doc and merged so it's in 0.2.0

Thank you for merging it @vieux !


Add cookie support

https://github.com/request/request#requestcookie

passes in CI https://travis-ci.org/apickli/apickli/builds/262149562


VNode.componentInstance is undefined when rendered by a functional component

Version
2.5.17-beta.0
2.5.16
Reproduction link
https://codepen.io/anon/pen/rKwWXq?editors=1010
Steps to reproduce
Open the console
What is expected?
An instance of MyComponent should be logged
What is actually happening?
undefined is logged

This worked in 2.5.15
It also works if you change RootComponent to be non-functional:
const content = h(MyComponent, {}, this.slots.default)

I'm guessing this was caused by 62a922e8, cloneVNode doesn't include that property.

IMHO, private APIs may not be the best idea to rely on as they are always subject to change.

Yeah probably. It would be nice if it was usable though, because functional components don't have a reliable way to access $refs as far as I know.

Ok I've figured out a bit of a workaround using context.data.ref and context.parent.$refs[context.data.ref], but it fills $refs with undefined when the parent re-renders:

Is there anything like _uid to tell functional components apart? (again, more private interfaces)

Also is componentInstance even really private API? I doesn't have a _ prefix, and is pretty common to see when working directly with VNodes.

@KaelWD Did you solve this issue? The componentInstance is also undefined when I use named slot like:
A component  template
<template v-slot:body>
  <test>Hello world</test>
</template>

B component template

  <slot name="body"></slot>

B component script
export default {
  mounted () {
    console.log(this.$slots.body)
  }
}

@KaelWD Did you solve this issue? The componentInstance is also undefined when I use named slot like:
A component template
<template v-slot:body>
  <test>Hello world</test>
</template>

B component template

  <slot name="body"></slot>

B component script
export default {
  mounted () {
    console.log(this.$slots.body)
  }
}

Quite an old issue I know... but did you find a solution @sc0Vu ?

Are there any updates?
This problem is still present in the latest version

I solved this using the 'slot' attribute. But the problem is that official documents of Vue.js say the 'slot' attribute has already been discarded, and it won't be supported in Vue3. However, we can still use it in all versions of 2.x. Therefore, I think it's probably a bug of 'v-slot'. See Slot Attribute [Deprecated-Syntax]


Command that moves to a repository

Gitea version (or commit ref): n/a 0.7.0

Description
Adding a command that opens the repository.
$ tea move user/repo1

The current shells working directory would be changed to that of the root of a local repository copy.
This could be done by using a shell wrapper (function for a bashrc) that listens for move commands and interprets the output into a cd command within the users current shell.
Shipping a bash file that can be sourced by users will enable the move command. (something like)
function teacmd()
{
  # capture the input args
  # if is a call to the move command
  # pass output to the users cd command
}

I'm not sure what you think about that or the idea of storing state client side?
Happy to make the PR.

Thanks for opening this issue, the tea cli is managed here: https://gitea.com/gitea/tea/ please send all feature/bug reports there :)


Use proper logging instead of prints

We should implement a proper logging mechanism and extend the basic prints with meaningful log messages as well as persistent log files

Preliminaries
Certain basic agreements on logging should be made, e.g.:

standardized format for logging messages
where should the logs be written to
guideline for the definition of logging.level
other ?

@erwee6 You're welcome to chime in but my script only had one logging statement, with the syntax I just follow the print() statement that I refactored into a log.
Which loggin level to use is a good question. I went with the standard. logging.basicConfig(level=logging.INFO)
@pmayd What do you think?

@tifa365: in which folder your logging file is located and should every script use the same logfile. I would prefer this.

Hi,
Logging should not be alone to the console but into files so it is not enough to just use logging, you need to setup a proper logging with two handles, one for console and one for files. And no the files should not log all equally, for each script I think it's best to have one log file. But yes then each logger for each file can have the same base config . 1

Hi,
Logging should not be alone to the console but into files so it is not enough to just use logging, you need to setup a proper logging with two handles, one for console and one for files. And no the files should not log all equally, for each script I think it's best to have one log file. But yes then each logger for each file can have the same base config .
@tifa365 regarding log level it doesn't really matter but as this is not a library but a pipeline that is still heavily developed the log level should be DEBUG to log everything. Normally with logging.debug you would log simple status calls like script started, number if files found etc. of course all of that could also be info but I like to have the possibility do reduce the log noise by switching to log level INFO

@pmayd I don‘t understand this fully. When all scipts are running in the process chain, I have to look into n logfiles?

Yes exactly. You could configure the logger to write to the same file again but why should we want one mega log file? Normally, each process and each script is isolated from the others and doing its part so when I want to know when or where something happens I would like to check that log file for that step. At least that is what I would expect and how I am using log files, each step and process has its own log file. Later we can combine these if we are interested in a total log. But if you want to try the other way around you can also try to write into a single log file but then you have to work with different log names or a lot of debug messages to make the start and end of each script clear. I am not totally against it but I would go for the simpler solution of having exactly one log file per main script

@pmayd: @tifa365
Where should the individual logs should be stored?
Perplexity suggests:

Dedicated Logs Directory at Project Root
Logs Subdirectory in src Folder
Configurable Solution (but then a directory must be named)

I don't think we need a config here, it is not for the user or any other person than us. I usually go with a log folder in root, but here I would keep it close to the data folder. Originally, data was on the root level but I think I moved it under python and that is also where to put the log folder in my opinion. The src folder is definitely the wrong place in my opinion as it is specifically about source code files so you would never look for logs in there so I am against this but next to data under python folder should be ideal

We are talking past each other. The setup of the logger and the handler must take place somewhere. I do this in a code snippet logging_config.py. I can then import it if necessary.

I know that and we do not speak part each other, as I was referencing to your last option that you mentioned, configuring the log location in a config. We don't need that, we are not writing a library for others to be used so we can simply define one location. That is why I said we don't need a config to configure the location of our logger :)

Obviously I don't understand your point or vice versa. Let's discuss this in the meeting.


Update wiki UI

A couple of aspects of the wiki UI have been bugging me, and I think part of it is that I set out to use the same form for loading + creating + editing.
Also, there is the use-case of browsing the wiki, reading and following wikilinks (without necessarily wanting to making changes) that is not really covered at the moment. For this reason I think we should make the default view show only the Preview, and reveal edit fields as needed.
Some ideas on what to try next:

default view (showing the Preview of the current doc, and a single field to load a new doc): http://screencast.com/t/RUJ2rkULw
after clicking Edit: http://screencast.com/t/2h9viVvXJGGo
after clicking Load and not finding an existing doc: http://screencast.com/t/ENB8yqp9vRk3

@lfilho let me know what you think about this. I'm hoping it creates less edge-cases for us, rather than more :)

:+1: for this. I think this way would be easier to use.
On the "- Choose a Type -"  dropdown (Create a doc screenshot), how would we enter a new Type?
I think having the preview side-by-side was a better idea... Seems like we won't have too much data in the bodies (or will we?), so I think it's nice to use that extra blank space for side-by-side preview... Thoughts?
Minor wording suggestion: while editing, instead of "close": "cancel" button?
Ultra minor wording suggestion: "Load" feels to me that we know for sure there is something to be loaded (which is not always the case). So "Search" feels more correct to me (as in: "Search and if not found create"). Did that make sense?

Great feedback, thanks.

for the Type dropdown, I think we can get away with hardcoding available types in the frontend for now. As far as the backend knows/cares it is still just an arbitrary string, but hardcoding the available types on the frontend will just be 1 less thing for new users to learn.

I agree side-by-side editor & preview can be cool at times.  The current version is already set up so that it goes side-by-side when there is room, and stacks vertically for smaller windows. So yeah I think we can keep it like that.  Eventually we probably want to allow user to customize widths and remember their settings in localstorage.

yeah I was going back and forth with "Close" and "Cancel". I guess Cancel is more standard, so let's start with that and just confirm it fits every case.

Great suggestion to rename "Load" to "Search".  You actually reminded me of something I forgot to include in the mockup: when you Search for a doc and it's not found, we'll show the "Create a doc" form and we'll also show top 5 search results for that ID, in case you were looking for an existing doc but mistyped it.

I'll update the mockups and commit them

I've updated the mockup, you can pull from master and open this file: https://github.com/joshwnj/team-index/blob/master/docs/ui-mockup/index.html
Then follow the instructions in the js console to load the different screens (edit and search)

status: main updates are done, just fixing a couple of little bugs before I push.

Awesome! Just saw it superficially for now but liked what I saw (in terms of code as well - the rpc thing really simplified things on the http layer. Easier to digest I guess... Good work

Pushed some updates just now.  Finally we'll do a review of functionality before closing this issue.

Completed in https://github.com/joshwnj/team-index/commit/dcfbb2a5c76a1b7d8d77c8061b5d10328dca885f


Make convert_inline_anchor more in line with the html converter

In particular, some cases were using node.target as the id instead
of node.id.

I need example document that reproduces the issue that this PR aims to fix.

From what I recall, if you try and use an inline anchor then it doesn't get its id applied properly, and so you can't refer to it. I think in particular this shows up with anchors in lists, e.g.
[[item1]]foo::bar
[[item2]]baz::qux

Try to refer to <<item1>>.

But more generally, it's pretty suspicious that the code doesn't do the same things as the HTML converter does. That's going to lead to lots of divergence, this one was just obvious.

Thanks

In particular, some cases were using node.target as the id instead
of node.id.

This is because this converter still supports Asciidoctor >= 1.5.3. Once the minimum requirement becomes Asciidoctor 2, then this alignment can occur.
What I'm doing for Asciidoctor PDF is keeping support for Asciidoctor >= 1.5.3 in the 1.5.0 release, then bumping the minimum version of Asciidoctor to 2 for the 2.0.0 release. I recommend that Asciidoctor EPUB3 do the same.

EPUB3 is neither going neither 2.0 nor out of alpha until #47 is solved. Because fixing it involves serious changes that will most likely result in loss of backward compatibility (i.e. users will need to adjust their documents) and nontrivial amounts of bugs due to low test coverage.
For now, I'm keeping 1.5.3 compatibility, it wasn't too hard so far.

I'm unclear why old versions would need this behaviour given that it seems to just make inline anchors not work.
I don't particularly mind waiting for a new major version - I've been using a fork with this applied since I opened the PR.

My understanding is that we have fixed the xref issues already, so you shouldn't need a fork.
The reason it uses node.target in some places is because in versions of Asciidoctor < 2, that's where the ID was stored.

Does the sample I posted work? If so, great!
(The project that I did this work for is inactive at the moment, so I'm not going to mess with it soon, but great to see things are moving!)

You are correct. It's a problem with the :ref type. It should be:
        when :ref
          %()

The or is necessary to support both Asciidoctor < 2 and Asciidoctor >= 2.

All I'm saying is if you don't want to break support for Asciidoctor < 2, you need to be very careful with what changes you make here.
Best is to refer to what Asciidoctor PDF is doing, since it also supports both generations of core. See https://github.com/asciidoctor/asciidoctor-pdf/blob/v1.5.x/lib/asciidoctor/pdf/converter.rb#L2359-L2398 (there's some PDF-specific stuff in there, but if you look around that you can see where the || conditions are).

Don't worry, I'll fix this soon :) I just needed an example to write a test case.

@mojavelinux Could you take a look at updated PR please? Possibly suggest some more test scenarios?


[Support] Unable to connect to Air con unit

Hi there CMD4 Advantage community.
I am having issues with my homebridge setup for advantage air. I have been using olde versions of the CMD4 plugin for a while successfully but after a recent update everything broke. It is driving me mad trying to fix this as it should be trivial. I am having the issue where I get a constant error of More than 500 errors were encountered in a row for___ as per the screenshot I have attached. I have recently reinstalled the entire Raspbery Pi OS on my machine, followed the steps of installing homebridge and CMD4 plugin as per each GitHub’s page and still receiving this issue. I read through the troubleshooting steps of a gentlemen who had the same issue after transferring to a pi from. Mac and none of his steps have worked. I’d like someone who has more per ties in this field to review what I have done and provide me with some ti[s on where to get started. Sorry for long code but iOS won’t let me upload .json

{
    "bridge": {
        "name": "Homebridge 869B",
        "username": "0E:45:59:74:86:9B",
        "port": 51594,
        "pin": "[902-47-334](tel:902-47-334)"
    },
    "accessories": [],
    "platforms": [
        {
            "platform": "Cmd4",
            "name": "Cmd4",
            "outputConstants": false,
            "statusMsg": true,
            "timeout": 5000,
            "stateChangeResponseTime": 0,
            "constants": [
                {
                    "key": "${IP}",
                    "value": "<IP_ADDRESS>"
                }
            ],
            "queueTypes": [
                {
                    "queue": "A",
                    "queueType": "WoRm"
                }
            ],
            "accessories": [
                {
                    "type": "Fan",
                    "displayName": "Fan",
                    "on": "FALSE",
                    "rotationSpeed": 100,
                    "name": "Fan",
                    "manufacturer": "Advantage Air Australia",
                    "model": "e-zone",
                    "serialNumber": "Fujitsu e-zone2",
                    "queue": "A",
                    "polling": true,
                    "state_cmd": "/usr/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh",
                    "state_cmd_suffix": "${IP}"
                },
                {
                    "type": "Switch",
                    "displayName": "Leighton",
                    "on": "FALSE",
                    "name": "Leighton",
                    "manufacturer": "Advantage Air Australia",
                    "model": "e-zone",
                    "serialNumber": "Fujitsu e-zone2",
                    "queue": "A",
                    "polling": true,
                    "state_cmd": "'/usr/local/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh'",
                    "state_cmd_suffix": "z07 ${IP}"
                },
                {
                    "type": "Thermostat",
                    "displayName": "Aircon",
                    "currentHeatingCoolingState": "OFF",
                    "targetHeatingCoolingState": "OFF",
                    "currentTemperature": 25,
                    "targetTemperature": 25,
                    "temperatureDisplayUnits": "CELSIUS",
                    "name": "Aircon",
                    "manufacturer": "Advantage Air Australia",
                    "model": "e-zone",
                    "serialNumber": "Fujitsu e-zone2",
                    "queue": "A",
                    "polling": [
                        {
                            "characteristic": "currentHeatingCoolingState"
                        },
                        {
                            "characteristic": "targetHeatingCoolingState"
                        },
                        {
                            "characteristic": "currentTemperature"
                        },
                        {
                            "characteristic": "targetTemperature"
                        }
                    ],
                    "state_cmd": "/usr/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh",
                    "state_cmd_suffix": "${IP}",
                    "linkedTypes": [
                        {
                            "type": "Fan",
                            "displayName": "Fan Speed",
                            "on": "TRUE",
                            "rotationSpeed": 100,
                            "name": "Fan Speed",
                            "manufacturer": "Advantage Air Australia",
                            "model": "e-zone",
                            "serialNumber": "Fujitsu e-zone2",
                            "queue": "A",
                            "polling": [
                                {
                                    "characteristic": "on"
                                },
                                {
                                    "characteristic": "rotationSpeed"
                                }
                            ],
                            "state_cmd": "/usr/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh",
                            "state_cmd_suffix": "${IP}fanSpeed"
                        }
                    ]
                }
            ]
        },
        {
            "name": "Config",
            "port": 8581,
            "platform": "config"
        }
    ]

}

Hi @l80n63, first mistake I see is you need a space between ${IP} and fanSpeed in "state_cmd_suffix": "${IP}fanSpeed".
Have you sent a simplified version of your config? Do you have temperature sensors and how many zones do you have?

Also @l80n63 it could be worth trying the beta version we have going and see if you issue disappears on that version.

Hi Mitch, I appreciate the fast reply.
I have since fixed the $IP issue as I was trying to do space deletion fix that the other user said resolved his issue. I do not have a simplified config, this was only created earlier today using the data from your wiki on here. I have a single aircon with multiple zones attached, currently I am just testing the one for myself before I can duplicate that block of code adding the other zones to HomeKit. And yes curl does return a version number, I have 7.74.0 installed.

Ah yep that makes sense then. Can I get you to revert the ‘no space’ and make sure you save you config and then delete the Homebridge UI cache for the Thermostat (let me know if you do not know how to do this).
jq and curl both return a version number for you too? If you want, try the beta version and it will require no further config changes or any extra effort. We have made a lot of under the good changes that I would be curious to see if those have helped with this issue that (now) three users have reported.

Ok, I can fix the no space issue. Both also return version numbers for me as per the instructions. I am keen to try the beta version to provide feedback but have not manually installed a Homebridge plugin before. I have found the beta branch in your GitHub repo but if you could inform me how to overwrite the stable stream with the beta files I’d give it a crack.

On the Homebridge web UI, go to the ‘Plugins’ tab, located ‘homebridge-cmd4-advantageair’, click the spanner icon, click ‘Install Previous Version’ and select the beta version from the drop down menu :)

Hey, I have installed the beta as per your instructions Mitch. Unfortunately the error still persists. Do I have to update anything in my config for the new beta? I also tried removing cached accessories again after the upgrade to little use.

The beta should require no further changes to your config if it’s still looks as above. Sounds like this is a different issue then.
Can you fill out the following info for me please that was missed in the original ticket creation? Just so I better understand what you are working with :)
Advantage Air System:

Control Unit: e-zone / MyAir / MyAir3 / MyAir4 / MyPlace / zone10e / zone10
Temperature Sensors: Yes / No

Homebridge Environment:

Node.js Version: node -v
NPM Version: npm -v
Homebridge Version:
homebridge-cmd4 Version:
homebridge-cmd4-AdvantageAir Version:
Operating System: Raspbian / Ubuntu / Debian / Windows / macOS / Docker / other

Hi Mitch,
I'm surprised that your homebridge-ui plugin to check his installation did
not find the error. As while he did put an IP, without the space it should
not have conformed to a proper IP address.
You could check this,
Ttyl,
John
On Fri, Feb 25, 2022 at 2:39 AM Mitch Williams @.***>
wrote:

Hi @l80n63 https://github.com/l80n63, first mistake I see is you need a
space between ${IP} and fanSpeed in "state_cmd_suffix": "${IP}fanSpeed".
Have you sent a simplified version of your config? Do you have temperature
sensors and how many zones do you have?
—
Reply to this email directly, view it on GitHub
https://github.com/mitch7391/homebridge-cmd4-AdvantageAir/issues/51#issuecomment-1050609259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSBCX53B7IAEPGCJ7HFZPTU44W2LANCNFSM5PJQRDCQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>

That is a very fair point John, in this beta I need to update the server.js file for checking the new ‘MyPlace extras’, I will look at adding this check too… The list never ends!

Hey, I have attached the information required below. The only error the self checker in the web platform is finding is to remove the the single quote marks within the double quotes in "state_cmd": "/usr/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh",
It previously looked like:
"’state_cmd": "/usr/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh’",
This produces an error for each one until I remove those single quotes then check passes. However it still has not resolved the issue.
Advantage Air System:
Control Unit: MyAir4
Temperature Sensors: No
Homebridge Environment: Raspbian GNU/Linux Bullseye (11)
Node.js Version: node -v 16.4.0
NPM Version: npm -v 8.3.1
Homebridge Version: V1.4.0 according to logs
homebridge-cmd4 Version: 6.1.2
homebridge-cmd4-AdvantageAir Version: 3.3.0 beta 5
Operating System: Raspbian on raspberry pi 4

Thanks for taking the time to grab this info for me @l80n63. Can you please try the two following commands from your terminal and let me know what each responds with?
which jq

which curl

Sure thing,
Which jq brings back /usr/bin/jq
Which curl brings back /usr/bin/curl

Ok, sweet both of those are in the correct folder and Homebridge will see them. We can cross that off the list!
Can I get you to navigate to your tmp folder. Just in your terminal type:
cd /tmp

Then this command to see all files:
ls -al

And have a look in one of the many files of the naming convention AirconError-*.log (where * will a bunch of numbers). Look at the most recent one with the following command (substituting * for the number of the file):
sudo nano AirconError-*.log

Can you paste the contents here or take a take a screenshot?

Ok this is strange now. the error has disappeared based on me doing nothing but rebooting the Pi (I have been rebooting each time you have suggested a change to clear caches) however the HomeKit system is still not producing changes on the air con unit. I have attached screenshots of the air con unit details and the error log as per the instructions

Hey @l80n63, thank you for getting this to me. I will have to get back to you tomorrow afternoon/evening (sorry for the inconvenience). I have a 30th to go to tonight and plans for most of the day tomorrow.
@uswong feel free to jump in in the meantime but I will have to check out for now; otherwise I will take a look tomorrow.

Hi @l80n63, the return code: 7 means the plugin fails to connect to host.  The host here is your aircon system.
Can you try for me at the terminal command line:
curl -s -g "http://<IP_ADDRESS>:2025/getSystemData"
you should get a whole page of text starting with {"aircons":{"ac1":{"info" etc...
If you don't, try http://<IP_ADDRESS>:2025/getSystemData on your browser, you should get the same thing.
If not, then your aircon system is not communicating with the plugin at all.
One thing to try is to reboot your android unit of the aircon system.

No problem Mitch, you have been very helpful during this process so far and I appreciate the time you have given up so far.
I did follow the advice of @uswong and initially it did not produce anything back. I then restarted the android tablet as suggested and voila the error has disappeared and the HomeKit plugin works. Thanks for the tip and I feel so dumb for not following IT tip #1.
However we are not entirely out of the weeds yet. The other accessories I have configured for the individual rooms like mine (Leighton) do not seem to function. They follow the state of the android tablet but when trying to do through HomeKit/homebridge’s accessories, it does not change on the android tablet and stays to the position it says. So for example, if it is on, and I press off on the iPad, it will turn off on the iPad momentarily then return to on.

The other accessories I have configured for the individual rooms like mine (Leighton) do not seem to function.

Do you have temperature sensor for this room?
Based on the config file you posted earlier, it appears that you have temperature sensor for this room as you have configured it as a Switch.
If this room has no temperature sensor, then you should configure it as a lightbulb accessory.  Just in case this is the case, an example as follow:
  {
        "type": "Lightbulb",
        "displayName": "Leighton",
        "on": "FALSE",
        "brightness": 50,
        "name": "Leighton",
        "manufacturer": "Advantage Air Australia",
        "model": "e-zone",
        "serialNumber": "Fujitsu e-zone2",
        "queue": "A",
        "polling": [
            {
                "characteristic": "on"
            },
            {
                "characteristic": "brightness"
            }
        ],
        "state_cmd": "'/usr/local/lib/node_modules/homebridge-cmd4-advantageair/AdvAir.sh'",
        "state_cmd_suffix": "z07 ${IP}"
    },

I then restarted the android tablet as suggested and voila the error has disappeared and the HomeKit plugin works. Thanks for the tip and I feel so dumb for not following IT tip https://github.com/mitch7391/homebridge-cmd4-AdvantageAir/issues/1.

@l80n63 I am absolutely spewing I did not suggest this sooner haha it will be one of the first times I have not suggested it, as each time I do suggest it, it was not the problem! If you table this locked up (which happens on occasion), then it will show the errors you experienced; but many other things in an incorrect setup can show that same issue. Glad it was a simple fix in the end!
As a non temperature sensor user, you can use the switch accessories if you want to but you will only have control of open/close and not how much percentage open/close. HomeKit does not have an appropriate accessory for zone percentage control, that is why we make use of the LightBulb accessory until they give us something better to use. You can read about it on the Wiki tab if you are interested.
Hope it is all working now and sorry for the late reply; my commitments this weekend ran longer than expected!
@uswong thank for the help in my absence!

Just for future reference, I have just resolved JohnW's issue with the same return code : 7, ie the homebridge lost communication with the hosts (the MyPlace Andoid tablet).
A reboot in this case did not resolve the problem.
Eventually we found that the IP address of MyPlace system has changed.  The change of the IP address was mostly likely due to a blackout and when the power came back, the router has assigned a different IP address to the MyPlace tablet.

Oh yep that will definitely do it! Nice find Ung Sing :)

@l80n63 how has everything been looking on your system? No further issues?

Hey @mitch7391, everything seems to be working very solid the past week. This has been amazing, let me know if future beta updates come out so I can provide feedback to your team but this beta build I have now seems to be working flawlessly. Thanks to everyone for the help as well

Glad to hear it and thanks for the update :) if you are curious to be 'signed up' for future beta testing, all you had to do is go to watch in the top right hand corner of the page, select custom and then Releases. This will give you an email every time I release a new version; including beta versions which people will not know about unless I create an issue for it.


MultiChoiceAlertDialog and SingleChoiceAlertDialog aren't exported in compose-settings ui

These seem to be internal only.

And internal will be kept.
Those are just samples.
Those dialogs are not so difficult to build on compose. And each project would need it on a different way...


NO MRG: Disabled badge test

Please do not merge this. It is for testing purposes only.
Re-renders with a development version of conda-smithy using this PR ( https://github.com/conda-forge/conda-smithy/pull/228 ). This provides a disabled badge in place of the unused CIs. Thus one can see how it works and what the badge looks like by viewing the README.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Closing as testing is completed.


bad link

Please update link so it's clickable

Fixed that for you!

continuous-integration/jenkins/pr-merge — This commit cannot be built

Hmm ...
Btw, while not intended as a proper solution, the Dlang-Bot might soon understand commands like:

please squash this PR ("bot-squash")
please rebase this PR ("bot-rebase")

Especially the later is unfortunately currently commonly needed on PRs.

(rebased to rekick Jenkins and used this opportunity to rebase the PR to stable and squash the commits, i.e. drop the comment).

Rebased again. @CyberShadow imho either @MartinNowak agrees to temporarily disable DUB + Vibe.d tests or we set disable set the Jenkins project-tester to non required again. It's not really fun to rebase a PR 3-4 times just to get it to pass at the project-tester ....

imho either @MartinNowak agrees to temporarily disable DUB + Vibe.d tests or we set disable set the Jenkins project-tester to non required again. It's not really fun to rebase a PR 3-4 times just to get it to pass at the project-tester ....

CC @CyberShadow
Also it seems that there's something wrong with the auto-tester - it doesn't detect this PR (it's not even listed).

Could you email Martin and CC me? I think we need to do something about this today, but Martin isn't responsive to GitHub mentions.

Could you email Martin and CC me? I think we need to do something about this today, but Martin isn't responsive to GitHub mentions.

Done.

Also it seems that there's something wrong with the auto-tester - it doesn't detect this PR (it's not even listed).

Ping @CyberShadow @braddr - should we simply create a new PR?

This has been superseded by https://github.com/dlang/phobos/pull/5526
@zaydek thanks again for submitting this fix. I hope you weren't that frustrated by our temporary CI problems. We are looking forward to your next contribution ;-)

I don't see anything in the auto-tester logs to point to something going wrong, other than the lack of any attempts to build this pull request.  I see the record of it's existence and the edits to switch branches, update the head commit a few times, and add the merge label.  But no builds happened.  Next time you see this happen, let me know and I'll dig deeper.


chore(main): release 1.16.5

:robot: I have created a release beep boop
1.16.5 (2024-12-06)
Bug Fixes

build (b074d6b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.16.5
:sunflower:


Twitch embed autoplay not working correctly

From multiple tests, it seems like autoplay={false} isn't working. You mentioned this is likely due to the twitch embed API changing. I'll take a look at this shortly as well and see if there's a quick fix I can put in

Unrelated to the above, but also receiving a ton of errors in the console from this component.

I noticed the autoplay issue as well, is there any follow up on this? or should we look into this ourselves and create a PR?

Taking a look at this now. Thanks for patience

Seems like something change on Twitch's side the JS library no longer accepts the autoplay options when initializing the class. Took a stab and patching this and should be included in the upcoming 1.1.0 release.

1.1.0 released, let me know if you still see issues with new stuff


Update chroming based on deployment so it aligns with publicPath

Deploy preview for project-koku ready!
Built with commit 0e155052ee1288abe819f05405796cf658674e88
https://deploy-preview-161--project-koku.netlify.com

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   90.74%   90.74%
=======================================
  Files         110      110
  Lines        1178     1178
  Branches      148      148
=======================================
  Hits         1069     1069
  Misses         98       98
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459fbb1...0e15505. Read the comment docs.

Normally wouldn't merge without a review, but attempting to get this change in before a review meeting. Happy to revert or make changes based on comments, but with any deployment change it really needs to be run 😄 to verify the desired change.


[WIP]Move glide.yaml and glide.lock to the top directory

This could be helpful that we can run glide install -v directly under the top-level directory, then the vendor directory is not created inside go folder which could be annoying.

Since we have many modules under cloud project and it could be confusing to set glide only for Go.

I think it's OK? The main programming language is Go, and if we move glide.yaml to root folder, the vender folder will be created here when building which is easier to manage.


Meta variables as optional feature

[x] Make meta variables an optional feature
[x] Adapt examples
[x] Adapt user guide

Fixes #74

Decided to remove the mate variables feature completely. See #77


Add medium review

@justinslack early doors for front-end Friday, since I know tomorrow and Friday will be A Bit Busy. Thoughts?

Don't forget you'll need to jekyll serve --future to see it. That one keeps biting me 😬 .


Flux component prevent lights to be turned off

Home Assistant release with the issue:

unknown
Last working Home Assistant release (if known):
unknown
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io
Integration:

https://www.home-assistant.io/integrations/flux/
Description of problem:
When Flux Light Adjustment switch is on, it is impossible to switch off those lights since they turn on again.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
switch:
  - platform: flux
    lights:
      - light.tradfri_bulb_gu10_ws_400lm_7
      - light.tradfri_bulb_gu10_ws_400lm_8
      - light.tradfri_bulb_gu10_ws_400lm_9
      - light.tradfri_bulb_gu10_ws_400lm_10
    name: Fluxer
    stop_time: '23:30'
    start_colortemp: 5000
    sunset_colortemp: 3000
    stop_colortemp: 2700
    mode: mired

Traceback (if applicable):

Additional information:

The should turn off if you use Home Assistant to turn them off.
The problem is that if you turn them off externally, Home Assistant may not refresh their state before Flux updates the colour temperature. That command from Flux turns them on again.

The should turn off if you use Home Assistant to turn them off.

They should but they don't even with homeassistant only.
Actually, I didn't observe such behavior before, but there were some "improvements" to the Flux component as far as I recall it.
Also, I don't think that the inability to turn the light off externally due to Flux is a bugfree behavior either.

Homeassistant 0.105.x, issue is still present


e2e: enhance UPF scaling test with some additional checks

In 008.sh we test that we can do the update, and that the deployment comes back up. But there are probably a few more tweaks needed.
We should verify that the operator generates an increased memory and/or CPU requests/limits for the deployment. This will require:

~Waiting for the change we pushed to the package to propagate through to the edge cluster. Right now, we probably aren't waiting long enough. Since we change the "leaf" package (the per cluster packages, not the upstream from the PVS), there is no PV involved. It is just seeing it propagate through ConfigSync. So, we could check the UPFDeployment resource in the edge cluster for our change.~ (fixed)
~Once that change is there, we need to wait for the operator to make the update to the Deployment. So, we should monitor the deployment and look for a bump in the CPU (or whatever we expect it to do).~ (fixed)
~Then we should see that the deployment comes back up.~ (fixed)

Finally, once all that is done, we should try another call through that UPF.

https://github.com/nephio-project/test-infra/pull/129 fixes several of these (just not the call).

So, I ran these and then tried to do a ping like we do in 007.sh, and it failed.
I restarted the UE pod and then it worked.
So, I think we're OK - this seems to be a limitation in the UERANSIM?
@henderiw @tliron @s3wong @matysiaq @denysaleksandrov @rravindran123 WDYT?

Not a limitation, i would expect that behavior as the SMF is the control plane for the UPF, and manages GTP session between UPF and the gNodeB for all the UE it is serving. So SMF going offline would mean all those corresponding PDU sessions will be deactivated by the UPF/gNodeB (for the latter should be the AMF). UPF can detect SMF's liveliness using the  heartbeat that goes on between the two services, guess this is on by default in free5gc.

I guess I thought the UE would detect it going down and then reconnect, but maybe not. It's ok, I don't think restarting the UE pod is a problem.
/assign @n2vo

Thinking about it again, you are right, all the UE has to do is to re-issue the PDU session request, since the UDR/UDM should have its registration state (one shoudn't reset their UE if there is a 5GC component failure), but then there should be also be some trigger on the RRC end for UE to re-issue the request. Will have to dig 3GPP to see the expected behavior, but as per the specs if the UE is expected to reissue after the SMF/UPF fails/restarts, may be a limitation with free5gc implementation.


chore: update playwright

Update playwright to v1.47
We're mainly updating for the new "show route actions" setting, which significantly tidies up the UI mode for us

:tada: This PR is included in version 1.9.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow users to specify deployment location of Template inside policy definition

On hold until policy can use ARM template language expression when starting the remediation vs passing literal string.


Update _hf_folder.py

Allow permission error, especially for HPC environment

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Secor v0.29 is released

Checkout the release notes: https://github.com/pinterest/secor/blob/master/RELEASE.md
v0.29
Javadoc Update: fix a few missing params and exclude a few packages
Add native support for Prometheus
Rework cleanup process on shutdown
Add secor.max.active.files property to controll active file count
Add max.poll.interval.ms kafka producer setting
Fix various unit test failures related to powermock running in JDK 11
Upgrade guava to 24.1.1 to address the following security issue
Upgrade parquet version from 1.9.0 to 1.11.0

Henry,
I  compiled and installed v0.29 but can't make it work.
I upgrade from v0.26 and afraid that configuration changed significantly so I ended up with config that doesn't work.
here is my run command:
java -ea -Dsecor.kafka.group=secor_backup -Xmx1194m -Daws.access.key=ZZZZZZZZZZZZZZ -Daws.secret.key=ZZZZZZZZZZZZZZZZZ -Daws.region=us-east-1 -Dzookeeper.quorum=0.zk.service.consul:2181,1.zk.service.consul:2181,2.zk.service.consul:2181 -Dkafka.zookeeper.path=/ -Dkafka.seed.broker.host=kafka.service.consul -Dkafka.seed.broker.port=9092 -Dsecor.s3.bucket=mobileye.secor.intermediate -Dsecor.s3.filesystem=s3n -Dsecor.s3.path=jenkins0 -Dsecor.kafka.topic_filter= -Dsecor.message.parser.class=com.pinterest.secor.parser.RsdParser -Dmessage.timestamp.name=@timestamp -Dsecor.local.path=/tmp/secor_data -Dsecor.file.reader.writer.factory=com.pinterest.secor.io.impl.DelimitedTextFileReaderWriterFactory -Dsecor.compression.codec= -Dsecor.max.file.age.seconds=30 -Dsecor.max.file.size.bytes=50000 -Dostrich.port=19999 -Dsecor.kafka.topic_blacklist=secor.restore -Dsecor.upload.manager.class=com.pinterest.secor.uploader.S3UploadManager -Dlog4j.configuration=file:///opt/secor/log4j.prod.properties -Dconfig=secor.me.prod.backup.properties -cp secor.jar:lib/* com.pinterest.secor.main.ConsumerMain
the parameters are spread over many config files, it would be nice if secor would print them out at the startup like kafka...
any specific values you want to see or all?
The process is running but does nothing:

BTW, side issue - I could not start the process because of the error in OstrichAdminService,
until I put build.properties in com/pinterest/secor/common/monitoring/ directory.
2020-07-22 21:16:38,719 [main] (com.pinterest.secor.common.monitoring.OstrichAdminService:81) ERROR Failed to load properties from build.properties
java.lang.NullPointerException
at com.pinterest.secor.common.monitoring.OstrichAdminService.start(OstrichAdminService.java:75)
at com.pinterest.secor.main.ConsumerMain.main(ConsumerMain.java:69)
Not sure why it needs it and what is the correct way to fix the issue.
Looks completely unnecessary though.
Thanks for your help!
David

For some reason, I couldn't reproduce your problem of build.properties, there is build.properties packaged already inside secor.jar, looks fine to me.
To debug your consumer problem, you can turn on DEBUG logging category in your log4j file.
Which version of kafka are you running?

Henry,
thank you for the quick answer.
We run kafka 2.5.0
Here is DEBUG-enabled log for the first 6 minutes of the service startup.
secor-debug.log
I looked thorough but don't see any obvious (it is a lot of debug prints :) )
Appreciate your help!
David

It seems you are not subscribing to any topics: -Dsecor.kafka.topic_filter=
You can also try to run a few jstack command to what each thread was doing.

Henry,
thanks a lot!
The behavior had changed form version 0.26.
we never set secor.kafka.topic_filter in prev versions.
We set secor.kafka.topic_blacklist=topic-to-exclude
which used to mean "all topics except topic-to-exclude"
Right now I had to set secor.kafka.topic_filter=.* to make it work.
Appreciate your help!
David

Hi @HenryCaiHaiying, I've experienced the same issue with build.properties as @dovka did. In my secor.jar, the file is located in com/pinterest/secor/common/ rather than com/pinterest/secor/common/monitoring/ where the following piece of code expects it
https://github.com/pinterest/secor/blob/f9055b9d477fb14d2c7f9ab126477d094c0ca47a/src/main/java/com/pinterest/secor/common/monitoring/OstrichAdminService.java#L75

Make a fix for this problem: https://github.com/pinterest/secor/pull/1528
On Thu, Aug 13, 2020 at 5:13 PM tomaskoutny-blis<EMAIL_ADDRESS>wrote:

Hi @HenryCaiHaiying https://github.com/HenryCaiHaiying, I've
experienced the same issue with build.properties as @dovka
https://github.com/dovka did. In my secor.jar, the file is located in
com/pinterest/secor/common/ rather than
com/pinterest/secor/common/monitoring/ where the following piece of code
expects it
https://github.com/pinterest/secor/blob/f9055b9d477fb14d2c7f9ab126477d094c0ca47a/src/main/java/com/pinterest/secor/common/monitoring/OstrichAdminService.java#L75
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/secor/issues/1464#issuecomment-673770457,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYJP76FVHUNOMEGS6OFXB3SAR6TLANCNFSM4O7DRVBQ
.

@tomaskoutny-blis


Add OutputElementHintAttribute to control design time IntelliSense for TagHelpers.

Decided to not have the attribute inheritable since TargetElement is not inheritable.
Added tests to validate serialization, deserialization and construction of TagHelperDescriptors with OutputElementHints.

#382

/cc @dougbu

:watch:

Updated.

Overall looks good, just had a question about the class design.

We've got a buried discussion starting here

:watch:

Updated ?. spacing and comment.

:shipit: (I wasn't waiting on those minor comments :smiling_imp:)


Make regex validator option work

So it's possible to turn it off.

I'm having trouble understanding what the use case of this is.
In your test case validates :email, email: { regex: false } you basically say that you validate the email but then disable all the validations making it a NOP.
So why use the validation at all?

Oh, I should have explained it better. The thing is that I need to validate blacklist/disposable only on: :create and I don't want to deal with double errors. Does that make sense?

Alright, i understand.
To be able to even match the blacklist the email has to be somewhat valid (ie. it needs to at least have a domain).
The point of the library is to validate email addresses so i don't really see the point to be able to disable the format validation as that's the first thing you really have to pass to be able to classify it as a real email address.
I understand how you want to use the validation but i don't think it has a real use case other than to not have to deal with the error. So i'm afraid i can't accept this PR.

Ok it's fine. You should consider removing regex from default_options then because it does not make any sense. Cheers!


Evaluation Error on Scrolls Task - 2

I am trying to evaluate LLM on long text understanding.
I encountered the following error.
I tried to resolve minor bugs but couldn't resolve this one.
First I faced this issue
acc_norm = 1.0 if np.argmax(results / completion_len) == gold else 0.0                                 ~~~~~~~~^~~~~~~~~~~~~~~~ ValueError: operands could not be broadcast together with shapes (3,2) (3,)
I checked for the dimensions. Apparently, results parameter had a dimension of (3,2). It was present in this format
[(-16.322248458862305, False), (-14.276965141296387, False), (-10.922859191894531, False)]
To resolve this I added another line of code
results = [result[0] for result in results]
But after this, I faced another error, which I couldn't figure out.

Traceback (most recent call last):
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/bin/lm_eval", line 8, in <module>
    sys.exit(cli_evaluate())
             ^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/__main__.py", line 207, in cli_evaluate
    results = evaluator.simple_evaluate(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/utils.py", line 402, in _wrapper
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/evaluator.py", line 152, in simple_evaluate
    results = evaluate(
              ^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/utils.py", line 402, in _wrapper
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/evaluator.py", line 496, in evaluate
    results[task_name][metric + "_stderr" + "," + key] = stderr(items)
                                                         ^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/api/metrics.py", line 206, in mean_stderr
    return sample_stddev(arr) / math.sqrt(len(arr))
           ^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/api/metrics.py", line 202, in sample_stddev
    return math.sqrt(sum([(x - mu) ** 2 for x in arr]) / (len(arr) - 1))
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
ZeroDivisionError: float division by zero

Yeah, division by zero looks like an error from using only 1 sample. I should patch that.

Yes, thanks. Indeed using limit 1 was the issue. The issue is gone but I have encountered another issue.
Traceback (most recent call last):
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/bin/lm_eval", line 8, in <module>
    sys.exit(cli_evaluate())
             ^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/__main__.py", line 207, in cli_evaluate
    results = evaluator.simple_evaluate(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/utils.py", line 402, in _wrapper
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/evaluator.py", line 152, in simple_evaluate
    results = evaluate(
              ^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/utils.py", line 402, in _wrapper
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/evaluator.py", line 482, in evaluate
    results[task_name][metric_key] = agg_fn(items)
                                     ^^^^^^^^^^^^^
  File "/home/user1/LLM-BenchMarking/lm-evaluation-harness/lm_eval/tasks/scrolls/task.py", line 197, in compute_metrics
    computed = self.metric.compute(
               ^^^^^^^^^^^
AttributeError: 'GovReport' object has no attribute 'metric'

Will take a look

Sorry, reopening this as it turns out there is still an issue in the loading the metric.


Replace deprecated ensureIndex with createIndex.

Fixes #6.
This has been tested against top level issuer and IdP test suites.  No issues detected.

The ensureIndex docs deprecation notice says to use createIndexes.  Is createIndex ok too?

@davidlehn Here is the API documentation for ensureIndex: http://mongodb.github.io/node-mongodb-native/2.1/api/Collection.html#ensureIndex
Here is createIndex which is identical to ensureIndex: http://mongodb.github.io/node-mongodb-native/2.1/api/Collection.html#createIndex
And here is createIndexes which is not the same, the first argument is an array: http://mongodb.github.io/node-mongodb-native/2.1/api/Collection.html#createIndexes

I was just being literal with the ensureIndex deprecation note, which says "use createIndexes instead".  I imagine createIndex is fine.


[boost] build failure; it assumes that MPIEXEC.EXE is installed to C:\Program Files\Microsoft MPI\Bin

Host Environment

OS: Windows 10
Compiler: 16.11.4

To Reproduce
./vcpkg install boost on a machine that doesn't already have the MPI Redistributable installed at that location.
Failure logs
D:\work\github\vcpkg>vcpkg install msmpi
Computing installation plan...
The following packages will be built and installed:
    msmpi[core]:x64-windows -> 10.1.12498#2
Detecting compiler hash for triplet x64-windows...
Restored 0 packages from D:\Users\peter\AppData\Local\vcpkg\archives in 465.4 us. Use --debug to see more details.
Starting package 1/1: msmpi:x64-windows
Building package msmpi[core]:x64-windows...
-- Downloading https://download.microsoft.com/download/a/5/2/a5207ca5-1203-491a-8fb8-906fd68ae623/msmpisdk.msi -> msmpis
dk-10.1.12498-b0087dfd.msi...
-- Downloading https://download.microsoft.com/download/a/5/2/a5207ca5-1203-491a-8fb8-906fd68ae623/msmpisetup.exe -> msmp
isetup-10.1.12498.exe...
CMake Error at ports/msmpi/portfile.cmake:59 (message):
    Could not find:
      C:\Program Files/Microsoft MPI/Bin/mpiexec.exe
    Please install the MSMPI redistributable package before trying to install this port.
    The appropriate installer has been downloaded to:
      D:/work/github/vcpkg/downloads/msmpisetup-10.1.12498.exe

Call Stack (most recent call first):
  scripts/ports.cmake:141 (include)

Error: Building package msmpi:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: msmpi:x64-windows
  Vcpkg version: 2021-09-10-2059ef11aa6067e6f59b0d939c5d17e3c5c47d3e

Additionally, attach any relevant sections from the log files above.

Additional context
Notice the hard-coded pathname for MPIEXEC. On my machine it's in D:\Program Files\[...], not in C:\Program Files\[...]. The correct location is on my PATH, but the build script doesn't seem to try that.

@dannypike, thanks for sharing the workaround here! the default install directory is C:\Program Files\Microsoft MPI\Bin.


Syncing latest changes from master for rook

PR containing the latest commits from master branch

/approve
/lgtm