Fix the rcs(please help)

hello Daniel, could you please fix the RCS and change it so that it's more of a pitch, yaw and standalone RCS
the RCS in the cheat is very very bad, it doesn't even control recoil, it kinda just doesn't work with the aimbot.
I don't know how to code, so i need your help guys.

oh and btw, if the aimbot doesn't kill said target within the first few shots, it will never kill it after unless it does because of spread

#769

#769

that is closed.
i thought the aimbot never hit because it doesn't wait for you to completely stop, this does make more sense because it doesn't hit even with slow walk.

#769

that is closed.
i thought the aimbot never hit because it doesn't wait for you to completely stop, this does make more sense because it doesn't hit even with slow walk.

even tho it's closed, i've been using it for a month and it works perfectly fine, no bans either

#769

that is closed.
i thought the aimbot never hit because it doesn't wait for you to completely stop, this does make more sense because it doesn't hit even with slow walk.

even tho it's closed, i've been using it for a month and it works perfectly fine, no bans either

it uses an old version of Osiris that would crash after the 3/2/2020 update? unless you merged it i dont know how you could have got it to work.

i have better and actual version with rcs (watch my cherry-pulls and cherry-pulls-merge branch) but i discontinued committing atm cause something triggered VAC (surely not the RCS). At the moment i can count 5 VAC banned accounts since 16.02.20 more and more accounts getting delay banned now. At 13.02.20 i have merged engine prediction from master to my branch.
@xAkiraMiura please stop answering that osiris is UD. I dont use VAC-bypass and i will never use it. My own injector is used since years without any detections. I only used highly modificated osiris over a long time without problems. And no, i dont use junk code.
@danielkrupinski, please can you double check engine prediction and commits after 13.02, something is strange.

I have never been VAC banned while using Osiris and I'm using no modifications on Osiris just the regular one, I'm using gerass's Injector,never had any issues with either of them

@steel4me are you sure you don't have osiris on your C:/ drive? Any cheat on the system partition will get detected by VAC through the USN journel.
I've never gotten VAC or untrusted from using Osiris so the problem is on your machine.

@steel4me are you sure you don't have osiris on your C:/ drive? Any cheat on the system partition will get detected by VAC through the USN journel.
I've never gotten VAC or untrusted from using Osiris so the problem is on your machine.

how do you merge multiple pull requests into osiris

@xAkiraMiura please, i have a virtual drive d:\meme.vhdx this drive is formatted as fat32 and mounted with drive letter x:, from there i start my loader / injector. The dll is streamed directly to memory from https source of my nginx in local network.
Thats why the dll is not stored / accessible on any hard disk. From there i work with manual map and erase pe header. I use this method since many years and i had no detections, never! Detections now happened since feb 2020. Strangly, bans er delayed with over 6 weeks till now.
I know some accounts that are already flagged and will be banned till mid of april.
You can ignore what i say.  How can you know that osisirs sigs or parts of it are not already known on VAC modules? Exactly, also you know which modules are loaded/streamed? It is also not possible that there are new modules? Yes sir, it is not detected. You cant say this ;) It is just wrong to say yes or no.

I have never been VAC banned while using Osiris and I'm using no modifications on Osiris just the regular one, I'm using gerasss' Injector.
Edit: And I'm not using the VAC Bypass either
@m0nsterJ i use osiris ~12 months, detections happened since 01.02.20, that means 9 month without any ban. Fact: Detection was somewhere near mid of feb and bans happened 6 weeks later.

But it's okay, there is no point in discussing this topic anymore if everyone always knows everything better and ignores all the information and signals. I wish everyone the best.

yyy, thats it. the USN journel
just keep doing akira ;)

@steel4me Osiris is undetected right now, there are no VAC bans related to the cheat. If you're using an injector thats using LoadLibrary then you'll get Untrusted/VAC banned. I've been using Osiris for so long and I've never banned using Osiris so stop spreading fake information,saying the cheat is detected.

yyy, thats it. the USN journel
just keep doing akira ;)

sounds more like a grudge than you know what your talking about

@steel4me Osiris is undetected right now, there are no VAC bans related to the cheat. If you're using an injector thats using LoadLibrary then you'll get Untrusted/VAC banned. I've been using Osiris for so long and I've never been banned using Osiris so stop spreading fake information,saying the cheat is detected.

my injector uses LoadLibrary and immediately exits and it has never been caught, maybe your loader stays open for too long after injecting? (grasping at straws for an explaination, might just be the injector you use causing a red flag)

@steel4me Osiris is undetected right now, there are no VAC bans related to the cheat. If you're using an injector thats using LoadLibrary then you'll get Untrusted/VAC banned. I've been using Osiris for so long and I've never been banned using Osiris so stop spreading fake information,saying the cheat is detected.

I deleted my old message that was very long cause it makes no sense to discuss anything with people that are registered since 3 days on github an spread wrong informations that osiris is undected or detected. I always said, no one of us can say its detected or undetected. Cause you simply don't know if signatures are already well known on vac modules. Some vac modules are streamed directly after opening csgo or connecting servers, others are streamed randomly.
Also do you have any clue about the fact how valve bans your account? I just inform everyone here that my detections happened somewhere near middle of februar. my account was banned in the middle of april. that means there was a delay between detection and ban. Actual i can confirm that this delay is round about 6 weeks. Also i have 10 test accounts injected with diffrent dll's, i also know that account 5/5 will get banned near 14.04.20.
Just think what you want. I have a virtual drive mounted as drive x: formatted with fat32. My .dll's are streamed from nginx over https directly to memory and then manual mapped with erase pe header over my own loader on this drive x:. I use my own loader / injector since 5 years without detections (excpetion VMT hook detection in 2017), I used highly modificated osiris 12 month now, that means 9 months without problems.
This is my last post now. I only tried to inform you about some facts but you just igrnore everything. Stay save ;)

safe*
ok.

safe*
ok.

do you actually have something productive to contribute instead of constantly knowing everything better and correcting others? please change your behavior, that's not nice

@steel4me hm very weird...
I have around 7 non primes, and I used Osiris on all of them,nothing else,and I did not receive a VAC ban,so I can say that its undetected.

I have around 7 non primes, and I used Osiris on all of them,nothing else,and I did not receive a VAC ban,so its safe to say that its undetected.

Where do i spread wrong infomations? Seems you did not read everything correctly. I only inform what happened. Show me some injector on github that streams a dll from some http(s) source to memory. It is my own and yes, ok, you can call it "shit injector". My good old internal with less functionsn then osiris doesnt trigger any vac with same injector. Believe it or not.
One example: i only want to say. That it is possible, that a vac module already detected something while you used osiris in february, but your vac ban will happen somewhere this or next month in cause of some possible feature detection.
this is almost worse here than in any cheater forums, the linguistic tone is broken .. lol, shit!


Fix CheckoutMercadoPagoModule undefined is not an Object in Example App

This PR is intended to fix issue #5.
I have made a deeper dive on the root causes of what the problems was. After searching I found a lot of guys recommendations to run react-native upgrade in order to match the latest versions of react-native folder structure. I have updated the example app, so now, if you run it, you will see that it launches correctly the MercadoPago checkout.
Also, I have made a little modifications to the example app. Little ones, like modify handlePress method to a class property, and remove lambda expression from render return method (this avoid the app to re render due to function creation inside return statement).
And another modification was to put credentials inside app.json.
I think that's all. Feel free to probe it, and let's review this. I will collaborate if something needs to be modified. This fixes aren't related to the library, they're related to the example app.
PD: I add here an screenshot of the MercadoPago checkout

Note that this overrides #6 since it upgrades Android API to 25 (while the aforementioned PR only does up to 24)
In another note, you made so many changes that it is kinda hard to track what actually fixed the issue #5
I would merge this anyway though, since it upgrades the structure of the project, fixes a bug and updates to latest Android SDK versions

@Positive07 If you read my first comment you'll note that I haven't touched anything related to the library. It seems that the issue was related to older config on the example react-native project.

@JonatanSalas thank you very much for all the hard work. I'll merge the PR and publish to NPM.

@scarmuega You're welcome! This library is simplifying us to integrate mercadopago in our react-native apps, so thank you for giving the library to the community!


New 3d Models adition

Hi Nutiteq Group,

I´d like to ask if it is any chance to send new 3d models to you in order to be converted into nmldb file?

What is the minimal requeriments for meemorychache size and texturecache settings on code in order to get a soft map panning after loading  a model database 75mb heavy?

I´d like to ask for Pro license quotation.

Closing old question - the right channel would be<EMAIL_ADDRESS>for this kind of requests, and Carlos has already got the answer.


Document process to migrate the database

Document the steps needed to migrate the database. This is necessary because there are two applications (Phoenix & Rails) that rely on the same database and shared state across connections. Please note the deployment strategy that will happen on both apps (if needed).
Document the steps for these schema changes:

Adding a new table
Adding new columns to an existing table
Renaming an existing column
Changing an existing column's data type
Removing existing columns
Dropping existing tables

Plan for migrations needed on Phoenix production app before launch.

Document created here https://github.com/GSA/Challenge_platform/wiki/How-to-migrate-the-database


Can't create RTCIceCandidate?

Shouldn't it be possible to create ice candidate instances like this:
new RTCIceCandidate({ candidate: "candidate:1680186374 2 udp<PHONE_NUMBER> <IP_ADDRESS> 37198 typ srflx raddr <IP_ADDRESS> rport 55221 generation 0", sdpMLineIndex: 1, sdpMid: "video" });

On OSX 10.10.5 and Safari 9 I only get "Error calling method on NPObject.". Opening the console on https://doubango.org/webrtc/samples/web/content/peerconnection-states/ and running the above code even produces this error.

It seems that after removing the "type check" code from "RTCIceCandidate::Init" in npapi/RTCIceCandidate.cc
RTCIceCandidate* _candidateInitDict = (RTCIceCandidate*)(RTCIceCandidate::IsInstanceOf(npObj) ? npObj : Utils::NPObjectUpCast(npObj));
if (!_candidateInitDict) {
    CHECK_NPERR_RETURN(NPERR_GENERIC_ERROR);
}

I started working for me, why is this check necessary?


Support for ssh key with passphrase using Apache MINA

Fixes #2201
There are a couple issues with SSH keys using passphrases

The CredentialItem type is now Password and not StringType
The JSCH library would only here have 1 CredentialItem.  With Apache MINA there are now two, and the old code would throw an exception (for some reason) if the first one didn't match the type.  We now need to look through all of them to find the password prompt so I removed the code that would throw an exception.
The prompt text is now different

@kvmw would appreciate it if you could also take a look at this

@ryanjbaxter  judging based on UsernamePasswordCredentialsProvider implementation by JGit, i think, both supports and get methods should accept CredentialItem.InformationalMessage as well as CredentialItem.Password and get method should throw exception if any CredentialItem other than above types was in the list.
I've drafted the #2210 based on your changes and what I understood from the UsernamePasswordCredentialsProvider implementation, just to explain my points.

@kvmw thanks!  I updated the PR based on your feedback

@kvmw thanks! I updated the PR based on your feedback

Thanks! LGTM.


Is it possible to compile the android version only with encode module?

Theoretically yes but we did not try that before.

What's the encode module depend on? After finish compiling , there are libcommon.a,	libdecoder.a,	libencoder.a,	libopenh264.a and libprocessing.a. Thanks.

libcommon.a and libprocessing.a are what libdecoder.a and libencoder.a depend on. libopenh264.a is a sum of them all.

Thanks.


remote signer: fix channel funding with mixed funding input types

Fixes https://github.com/lightningnetwork/lnd/issues/7276.
This fixes an issue where channels couldn't be opened if there were a number of mixed type (p2tr and p2wkh for example) inputs used for the funding transaction.

Oops, itests seem to fail on the new test, taking a look.

I had to fix an issue with np2wkh that was found by the added itest coverage. Can you take another look to double check please, @Roasbeef?


Multiple environments using Amplify

Hi, my app uses vue3, vuetify and amplify with rest api, dynamodb. Things were working as expected until I started getting errors in API calls that I couldn't explain. I deleted the "dev" enviornment using AWS console. When I tried to recreate the env using "amplify push", I got error saying "The specified bucket does not exist". So, I created a new env called "test" using "amplify init". Now "amplify push" is successful but the vue app seems to be pointing to older "dev" config. I have two questions. First, any thoughts on why I got "bucket doesn't exist" error and how do I get the vue app to use the new config that matches "test" env
Amplify CLI version is 7.6.25

Hey @knightsrule :wave: thanks for raising this! When we remove an environment from the web console, we'll want to remove it from our locally instantiated project as well. To do so, we can checkout the second environment and remove the old dev environment that we deleted in the console with amplify env remove dev. This will show us a few messages such as
⠧ Deleting resources from the cloud. This may take a few minutes...Stack has already been deleted or does not exist
⠼ Deleting resources from the cloud. This may take a few minutes...BackendEnvironment dev does not exist.
✔ Successfully removed environment from the cloud
Successfully removed environment from your project locally

and afterwards we can re-create this dev environment with amplify env add dev.

Now "amplify push" is successful but the vue app seems to be pointing to older "dev" config. I have two questions

For this issue, can you try running amplify env checkout test after pushing to test to see if that will trigger the update to aws-exports.js? Ideally this should be handled automatically after a successful push.

Closing due to inactivity. @knightsrule if you are still experiencing this issue please reply back to this thread and we can re-open to investigate 🙂


Clarification changes

These are my proposals.
Most of them are for clarifications which I thought I needed when I read this guide.
If you have any questions, feel free to ask me.
I'm new to git and GitHub. I read documentations on Webs.  For example I tried to commit on each topic.  But I might be doing wrong.  I welcome your suggestions.
Thanks.

@imphil , thank you for your comments.

In the interest of getting this PR in, would you mind splitting things up?

Sure.

Remove the added paragraph about clock dividers from this PR,

I did  on https://github.com/lowRISC/style-guides/pull/42/commits/0c28912050e7e2d908ed1fe216b5bb2b82dad458

and file a follow-up issue where we can discuss this guidance.

I found that I made a mistake.  I did not understand a branch for Git (it is different from a branch for other SCMs) and did not create a branch for this pull-request.  I tried to make a branch and a new pull request for the clock divider issue.  But it includes whole changes for this pull-request.  I will open a new pull-request for clock divider after this request is merged.

I think this is ready to go in as written. Thanks @hirooih for the clarifications. @imphil I'll give you one last chance to weigh in else I'll commit later today. Thanks.

Thanks a lot for those changes @hirooih. I took the liberty to combine your commits into one and commit them directly into the master branch (otherwise you'd have to rebase this pull request, which is a bit tricky if you're new to git).
Regarding the race condition topic: please feel free to open a new issue here in the repository and we can discuss it there. (Or in other words: it's not a rejected proposal, it's only one which needs more discussion to really understand what is going on.)


-wa command working successfully now

Issue that this pull request solves
#347
Closes: # (issue number)
#347
Proposed changes
Brief description of what is fixed or changed
Error removed command working successfully and changing about now. Also readme has been updated correctly.
Types of changes
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Screenshots
Please attach the screenshots of the changes made in case of change in user interface

Other information
Any other information that is important to this pull request

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy

@rpotter12 Please review my PR.

@SinghHimadri This software is a pypi package. So when a user install it from the command pip install wplay, the user will not able to paste the key in the script. The changes which you have made are only for those users who are running it from source code. :)

It was actually already present in the code I just removed the error it was not working 😅

Is there a way that a API key can be pasted itself by some script?

@SinghHimadri This software is a pypi package. So when a user install it from the command pip install wplay, the user will not able to paste the key in the script. The changes which you have made are only for those users who are running it from source code. :)

The file which is already present requires API key but even after adding API Key the code is showing error due to os.getenv() function. I have just removed that error.Web scrapping is not possible for this website as it requires captcha.Only thing that can be done(according to me) is making a list of eg: 10 keys and randomly placing it for the user. The current file doesn't work I have just removed that error.

@SinghHimadri May be we can ask user to enter api key in terminal for now. What do you say??

We can do one thing .. add a .config file and when the user runs the command the file will be checked if the API keys are not present then we will displays the steps for adding them 😅

Or we can directly take input from CLI also but it will be a bit insecure way of doing so

@rpotter12 I have done the changes please see.

@rpotter12 is their some issue left in this PR? I have done the changes you asked.


Integrate translation module @superset-ui/translation

Import @superset-ui/translation module

Replace calls (in about hundred places) from

import { t } from '../locales';

to
import { t } from '@superset-ui/translation'

Update webpack build config

Create preamble.js which defines the steps that has to happen before everything else (e.g. configure the translation module)
Prepend all webpack entry points with preamble.
Deprecate common entry point and create a new entry point preamble.
Update FAB template (base.html and basic.html)

Remove common entry point from the page that has an entry point (because preamble is now included with all entry points). Prior to this PR, Superset imports both common and another entry point (explore, dashboard, etc.) in a single page. With this PR, it will no longer import common.
Replace common with preamble for the page that doesn't have another entry point. (base.html)

Extract getClientErrorObject and error message strings into separate files.

@williaster @xtinec @conglei  @graceguo-supercat @michellethomas

Codecov Report

Merging #6222 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6222   +/-   ##
=======================================
  Coverage   76.87%   76.87%
=======================================
  Files          47       47
  Lines        9401     9401
=======================================
  Hits         7227     7227
  Misses       2174     2174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6a429...124c8d9. Read the comment docs.


Feature/production beta

What does this pull request aim to achieve? 💯
Please be concise and link any related issue(s):

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name> for a regular feature, hotfix/<branch_name> for a hotfix, and service/<branch_name> for a microservice, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[x] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

Tested and confirmed. All features working as intended.

No issues with Join Org except few minor ones .Hence I approve this feature


Add native support for supplied database URI

App should be easily extensible to remote repositories.  This may require more context-aware parameter setting of the connection in get_db().

Made note where connect statement would need to change.  Context manager would require custom env variable defining db_type.  Better to leave to future authors for the time being.


dstask: 0.22 -> 0.23

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/naggie/dstask/releases.
meta.description for dstask is: "Command line todo list with super-reliable git sync"
meta.homepage for dstask is: "https://github.com/naggie/dstask"
meta.changelog for dstask is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.23 with grep in /nix/store/z33w5nvpdvxv07p04ys564cbm7qa2rm7-dstask-0.23

directory tree listing: https://gist.github.com/583b659ba10af23b2bb4ce56889f0bf6

du listing: https://gist.github.com/324349570c39f056adcbc5881e4b2cec

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dstask

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z33w5nvpdvxv07p04ys564cbm7qa2rm7-dstask-0.23 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dstask https://github.com/r-ryantm/nixpkgs/archive/89507db3bc2c607a6de5792f1399cf546f1a78a0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z33w5nvpdvxv07p04ys564cbm7qa2rm7-dstask-0.23
ls -la /nix/store/z33w5nvpdvxv07p04ys564cbm7qa2rm7-dstask-0.23/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

dstask

Maintainer pings
cc @stianlagstad @foxit64 @kalbasit for testing.

Result of nixpkgs-review pr 102047 run on x86_64-darwin 1


Images sometimes don't load on android

Alright so I'm still seeing this error occur on android and it causes images not to get loaded into image views.
Image loading failed: https://s3.amazonaws.com/fanlete/uploads/dee371d0c35a816d22b067d8862b9cfd2db062c8.png System.NullReferenceException: Object reference not set to an instance of an object.
at FFImageLoading.Collections.StrongLruCache`2[TKey, TValue].Add (TKey key, TValue value, System.Boolean overwrite) [0x000ae] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Collections\StrongLruCache.cs:146
at FFImageLoading.Collections.StrongLruCache`2[TKey, TValue].Add (TKey key, TValue value) [0x00000] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Collections\StrongLruCache.cs:113
at FFImageLoading.Cache.ReuseBitmapDrawableCache.Add (System.String key, FFImageLoading.Drawables.ISelfDisposingBitmapDrawable value) [0x0006a] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Cache\ReuseBitmapDrawableCache.cs:352
at FFImageLoading.Cache.ImageCache.Add (System.String key, FFImageLoading.Work.ImageInformation imageInformation, FFImageLoading.Drawables.ISelfDisposingBitmapDrawable bitmap) [0x00042] in C:\projects\ffimageloading\source\FFImageLoading.Droid\Cache\ImageCache.cs:95

I figured to track this down I was going to need to download the FFImageloading source and add it to my project so I could step through the code and figure out where things were going wrong. Here's what I think I've learned. The error occurs in this block of code in StrongLruCache.cs
145         while (CheckEvictionRequired()) {
146		OnWillEvictEntry(list.First.Value, dict[list.First.Value]);
147
148		evictions = evictions ?? new Dictionary<TKey, TValue>();
149		evictions[list.First.Value] = dict[list.First.Value];
150
151		dict.Remove(list.First.Value);
152		list.RemoveFirst();
153
154		raiseEntryRemovedDueToEviction = true;
155	    }

The error occurs on line 146. The LinkedList list variable is empty. So list.First is null and list.First.Value throws the null reference exception error.
You can correct me if I'm wrong but what it appears is happening is the StrongLruCache class is a base class for ByteBoundStrongLruCache. This class I believe attempts to keep track of the number of total bytes in the StrongLruCache.
In the ByteBoundStrongLruCache there is an override for CheckEvictionRequired() which looks like:
protected override bool CheckEvictionRequired()
{
	lock (monitor) {
		if (current_cache_size > high_watermark) {
			has_exceeded_high_watermark = true;
			return true;
		} else if (has_exceeded_high_watermark && current_cache_size > low_watermark) {
			return true;
		}
		has_exceeded_high_watermark = false;
	}
	return false;
}

To me this basically is saying if we exceeded the high water mark keep saying we need to evict entries until we've reached the low water mark. The logic here seems sound. It appears as though the variable current_cache_size is somehow not correctly keeping track of the actual number of bytes held onto by the StrongLruCache. When the null reference exception is generated the LinkedList list is empty, and current_cache_size is greater than low_watermark. If the LinkedList is empty then it stands to reason that current_cache_size should also be 0.
The effect of all of this is that the ByteBoundStrongLruCache keeps telling the StrongLruCache to evict entries when there are no entries to evict, causing the null reference exception.
Testing and Moto g Android 5.1 with VS2015. If theres anything else you need from me let me know.

That's some impressive debugging, thanks for that - it helped a lot. I did some changes (see above). I replaced whole LRUCache implementation. Could you test it?

Been testing on various phones and views and things are looking good. I haven't had a single image throw an exception.

That's really nice! :)

I've made some more changes to android memory cache.


Add a mushroom card template for washers/dryers

Thanks

I already had similar however I like the remaining time in your detail. I also changed the icon depending on the state, not just the colour:
{% if is_state('sensor.dryer', 'on') %}
mdi:tumble-dryer
{% else %}
mdi:tumble-dryer-off
{% endif %}


Error serializing body using Kotlin integration

The following exception is being thrown when calling either a Function or a Consumer that have been generated through spring-cloud-function-kotlin. The Supplier work as intended though.
java.lang.ClassCastException: java.util.LinkedHashMap cannot be cast to io.paulocosta.cloudfunctionpoc.Test
	at io.paulocosta.cloudfunctionpoc.CloudFunctionPocApplication$testFunc$1.invoke(CloudFunctionPocApplication.kt:15) ~[classes/:na]
	at org.springframework.cloud.function.context.config.KotlinLambdaToFunctionAutoConfiguration$KotlinFunction.apply(KotlinLambdaToFunctionAutoConfiguration.java:143) ~[spring-cloud-function-kotlin-2.1.0.RELEASE.jar:2.1.0.RELEASE]
	at org.springframework.cloud.function.core.FluxFunction.lambda$apply$0(FluxFunction.java:41) ~[spring-cloud-function-core-2.1.0.RELEASE.jar:2.1.0.RELEASE]
	at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onNext(FluxMapFuseable.java:107) ~[reactor-core-3.2.6.RELEASE.jar:3.2.6.RELEASE]
	at reactor.core.publisher.FluxIterable$IterableSubscription.fastPath(FluxIterable.java:311) ~[reactor-core-3.2.6.RELEASE.jar:3.2.6.RELEASE]

For example:
data class Test(val name: String)
@Bean
fun testFunc(): (Test) -> Test {
    return { x -> x }
}

Using Java's Function type it works as expected:
@Bean
fun testFunc1(): Function<Test, Test> {
    return Function { x -> x }
}

I investigated a little bit a found that when FunctionInspector gets the function from
the FunctionRegistry the inputType is always java.lang.Object which makes the object
mapper serialize it into a LinkedHashMap and eventually trigger the error above.

On the other hand, the funcions using Java's Function have their types specified:

One thing that bugged me is that the supplier serializes the response properly using either
Java or Kotlin types. But from what I've seen it doesn't use the FunctionInspector for that end.
I've tested on versions 2.0.0.RELEASE and 2.1.0.RELEASE.
The project I'm using is here
I would be interested to dig more and attempt to fix the problem if that's of interest.

I am having the same problem. But I'm using version 3.0.0.M1

I was able to reproduce it, will be addressed for M3

The problem is addressed so give it a shot with the latest snapshot. We should have M3 shortly


How to get Cosmetic item names

I've been looking through the CDOTAWearableItem entities and trying to figure out how to get a name for the cosmetic item in question. The StringTableIndex for all of them is always -1 so it's not there, but there's another number, m_iItemDefinitionIndex, which seems like a unique identifier for each item and may point to a name. I'm just not sure if there's a specific StringTable or container that has these cosmetic names.

Do you have some kind of strong handle in the CDOTAWearableItem? It's a 64 bit value that seems random (like a hash). If so, use the Resources processor by annotating your processor with @UseResources and querying by ctx.getProcessor(Resources.class).getEntryForResourceHandle(yourHandle).
Good luck!

Here's an example for using the Resource processor.

Thank you, I'll look into that!


[MM_20423] 'external_image'module to ts (#16151)

Summary
Converted 'external_image' module to ts

Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/16151

Hello @dizkek,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

/update-branch

/update-branch

The type check failure you are seeing is not anything to do with your PR. The latest redux changes have not had their web app component updated so it's failing. I'll submit a separate PR for this and once it's merged into master, we can merge it into your PR and we should be good! Sorry about the inconvenience.

Awesome! Everything is good now. Approving :)

The QA can be done now because the changes needed shouldn't affect the behavior.

To help push this over the finish line, I helped sort out the merge problems. The redux did not need to be updated as it's already been updated in the latest master.

@jespino Please review when you have time. Thanks

Thanks so much guys for my first PR!


Add runner to wait until snapshot has been created

For snapshot creation (and metrics) so far we've relied only the
create-snapshot runner with a blocking call.
In this commit we are introducing a new runner
wait-for-snapshot-createto complement create-snapshot. This is
similar to restore-snapshot and wait-for-recovery and helps in cases
where network connections maybe terminated making a blocking call
unsuitable.

Thanks for your comments! Could you PTAL?


[Compat] trophies for ice and fire and the newly made Alex's caves

Mod Suggestion
I want the trophies of mobs from those mod
Why Should It Be in the Mod?
Trophies from all the mobs from the mods, all variants of the dragons if possible and the dragons should have a decent size in the trophies, not just tiny.
Please Read and Confirm the Following

[X] I have confirmed this suggestion is unique and has not been suggested already.
[X] I have confirmed this mod does not make use of Geckolib. Geckolib models dont stay static when displaying as trophies, and because of this I have decided not to add them until I find a workaround or Geckolib fixes this problem.

3.1 includes trophies for both of these mods. The dragons are small so they actually fit on the pedestal and this won't be changing so they fit with all the other trophies the mod adds


On mobile scroll closes menu

This plugin works great on desktop and ipad. On mobile, my menu has
6 items and each item has 5-6 sub items.
On mobile, while scrolling to one item in menu, the entire menu just closes. Also, the menu closes when you click anywhere outside the menu.
This is my code
$('#mobileMenuId').slicknav({
open: function(trigger) { slicknavOpened(trigger); },
prependTo: '#dynamicMenu'
});
Can anyone please suggest me what I can do?
Thank You.

This might help: https://github.com/ComputerWolf/SlickNav/issues/3


Allow registering mysterious conversion recipes

Just to register something as a mysterious conversion as I like the concept, the actual recipe would be something that I add with events and such and thus doesn't go into JEI normally. I like how create does this coz there are tooltips to let you know how to make it but also in JEI where most people navigate recipes you are exposed to the fact that the recipe is not usual.

This isn't possible, the recipes are hardcoded and can't even be added via JSON (or a mod).
There are some plans for JEITweaker to do something similar (show recipes for "concepts" that users would then add via events), but that is nothing more than just an idea at the moment.

There is no way to register it like they do in JEI? it's just the jei thing anyhow. I know the recipes themselves can't be recreated. Even if you add something similar to jeit it wouldn't display on the same tab which is desirable in my case. How do they add things to that jei tab?

There is no way to register it like they do in JEI?

Nope.
Create calls this method to provide JEI with it's recipes.
https://github.com/Creators-of-Create/Create/blob/mc1.16/dev/src/main/java/com/simibubi/create/compat/jei/category/MysteriousItemConversionCategory.java#L21-L28
The issue is, every time that method is called, a new list of recipes is made, so I can't even add to it.


fix: eslint max depth warnings

Description
Fixes eslint max-depth warnings in different files.
Left out helper.ts purposely not sure how to remove nesting there.
Related Issue
Fixes #1249
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[X] Unit, Journey, E2E Tests, docs, adr added or updated as needed
[X] Contributor Guide Steps followed

We need to hold off on this PR until our release next week. Thank you for your contribution!

can you please run npm run format:fix to try and fix the formatting issues? @tamirazrab

can you please run npm run format:fix to try and fix the formatting issues? @tamirazrab

Yes I did, sorry for delay, most warning aren't related to max-depth other than pepr/src/lib/helpers.ts which I'm not really sure how to proceed refactoring it.

@tamirazrab, thanks for doing the bulk of the work resolving the max-depth warnings! I'm gonna knock out the last few things and update the branch for us since we've had several changes over the past few weeks.

There are broader issues with test-coverage in the refactored files that we already know about, accepting the small overall decrease to gain linter resolutions.


[PEP] Add Timer Pause When Hover

This PR provides users intending to stay with more time to click "cancel", by pausing the countdown whenever the popup is being hovered.
Resolves: https://jira.corp.adobe.com/browse/MWPW-144532
Test URLs:

Before: https://stage--express--adobecom.hlx.page/express/pricing
After: https://pep-pause--express--adobecom.hlx.page/express/pricing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.39%. Comparing base (db17ac5) to head (6460ec4).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #752      +/-   ##
==========================================
- Coverage   36.66%   36.39%   -0.28%
==========================================
  Files         132      131       -1
  Lines       25750    25639     -111
==========================================
- Hits         9442     9332     -110
+ Misses      16308    16307       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Blocked for now as we're waiting for more confirmation from the Designer and Accessibility Team


Meta Tweaks for #4275

cc: @tgolen
Details
( comment )
Patch for #4275
Fixed Issues

$ #4234
Tests || ### QA Steps

Login to New Expensify
Change language to Spanish
Request money from someone or Go to a chat where money is requested from you
Click on the amount or view details link
button text will not look unusual (Cancel/Decline)

Tested On

[x] Web
[x] Mobile Web
[x] Android
[x] Desktop
[x] iOS

Screenshots

Web

https://user-images.githubusercontent.com/28243942/127920972-2ffc19b0-2338-498c-8ac9-e64848412f42.mp4
Mobile Web

https://user-images.githubusercontent.com/28243942/127930469-563e1f9a-6a48-475d-8ec6-a0db1bce5dd1.mp4
Desktop

iOS

Android

https://user-images.githubusercontent.com/28243942/127930426-926e271f-1c23-49f4-83b8-db67915ea85d.mp4

I'm just working on the last screenshot for iOS

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.82-8🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore(migrate): migrate this tap to gitguardian/tap

In this MR, we lay the ground for transitioning to a unique central tap for all GitGuardian's tools.
This MR will add a redirection to gitguardian/tap in case a formula no longer exist in gitguardian/ggshield.
In this case a warning message would be printed with dedicated instructions, something like :

==> Searching for similarly named formulae...
Error: No similarly named formulae found.
It was migrated from gitguardian/ggshield to gitguardian/tap.
You can access it again by running:
brew tap gitguardian/tap
And then you can install it by running:
brew install ggshield

@jeremyds, can you have a look ? Thanks !


How to use PR2 with assignTaxonomy from DADA2?

Hi!
I'm trying to use the PR2 database with the assignTaxonomy function from DADA2 to assign taxonomy to rRNA sequences in a fastq file. I found a note about using the taxLevels c("Kingdom","Supergroup","Division","Class","Order","Family","Genus","Species") but I wonder how this compares to taxonomic assignments for 16S sequences (which I suspect may also be included in my sequence file) where the taxLevels only go down to genus and then a separate training fasta is used to assign species?
If I want to make taxonomic assignments consistent between 18S and 16S, should I skip species from the PR2 training fasta header and add it separately with the addSpecies function?
Thanks in advance for any help and for a good resource!

Hi
You can use all the taxonomic levels down to species when you use assignTaxonomy. This is true for both Euks and Prok (PR2 has a small number of representative Prok sequences).  I personally never use assignSpecies which is only useful when you want to make sure that the sequence of your ASV is 100% identical to a reference species sequence.

Thank you for the reply!


Add command to manage proposed api enablement

This PR fixes #106427. Well not really because we disallow it in stable, but it fixes the part where it broke in Insiders too.
New model:

User sets hidden setting "extensions.enableProposedAPIOverride": true
Command "Developer: Manage Proposed API for Extensions" becomes available
Upon running the command, a big scary warning is shown:

Upon accepting, user can pick from a set of extensions which have requested proposed api but are not granted it via product.json/being builtin/etc. (some extra entries are shown here as they aren't in OSS's product.json)

Upon choosing which extensions to enable, user gets notification to restart:

The list of overrides is stored in local storage, so we can't access it from the EnvironmentService (sad @jrieken), but also it doesn't require a file read (happy @alexdima). Also I got rid of all of the modifications to argv.json (happy @bpasero)

@JacksonKearl I do not understand what's being solved here. If you are actively developing an extension than you are free to use proposed API anyways. It seems that you want to enable seamless selfhosting/consumption of extensions that you proposed API by anyone and that's something we should never support

I agree that I would also like to understand what is the usecase and why do we think this is a good idea.

My take on the situation:

For some time now it has been possible for users of Stable or Insiders to set an extension id in the enable-proposed-api array of argv.json and thereby turn on the proposed APIs that extension uses. The extension will have had to be built with "enable-proposed-api": true in its package.json. This bars its publication on Marketplace, so the user will have had to download the VSIX from elsewhere (e.g. a GH release artifact).

Recently (#106427) there was a report of this no longer working for Stable, though personally I haven't seen this problem. Latterly @JacksonKearl reported the argv.json technique didn't work reliably even on Insiders. This led to PR #110461, which wasn't popular and was ultimately closed unmerged.

This PR takes a different approach. It removes support for enable-proposed-api from argv.json, for both Stable and Insiders, and replaces it with a mechanism that only works in Insiders. Personally I'll be sad to lose the ability to get end-users of my extensions able to use proposed APIs on Stable. But if this happens I'll ask them to use Insiders. If they're nervous about getting daily updates I guess they can turn off automatic update and instead perform one manual update right after a new Insiders comes out right after a new Stable.

We're having to send our end users down the enable-proposed-api path (despite the inconvenience of having to download a VSIX and install it manually) because we use FileSystemProvider and both FileSearchProvider and TextSearchProvider remain stubbornly in proposed state with no indication of progress to finalization (see  #73524 and #59921). I  know @usernamehw shares similar frustrations about other proposed APIs.

For some time now it has been possible for users of Stable

Should have never been like and I don't know of any doc/resource that states the opposite.

This bars its publication on Marketplace,

There are very easy ways around this.

Personally I'll be sad to lose the ability to get end-users of my extensions able to use proposed APIs on Stable. But if this happens I'll ask them to use Insiders.

That shows a fundamental misunderstanding of what proposed API is for. This is a feature for extension authors, not extension consumers.
Sorry, this will now go in a direction which you won't like: I will refresh my memory for why we added support to enable proposed API via command line flags and I will work towards removing that. We do support proposed API via product.json which is a very well curated list and it should be the only list we have

In my opinion, the reason we get so little feedback from extension authors regarding Proposed API is that it's too hard to selfhost extensions using Proposed API, so they end up not being created in the first place, or even if they are created they don't get enough hours of use for issues to really present themselves.

We get very little feedback on API and I don't want to blame anyone for that. -jrieken

If you ask me we can only blame ourselves -- extension authors aren't going to dedicate lots of their time to learning a new API and help us out by providing feedback if we don't even let them self-host the extension they're creating without jumpting through hoops every time they launch the app.
Take for instance Notebooks, we only have a handful of Notebook extensions allowed in product.json, and none of them get much usage at the moment. That limits our ability to get feedback about the experience and means we're pushing more bugs/feature requests/polish off to when the API goes stable and many users are encountering the issues (and it's harder to make changes as backwards-compatibility becomes essential), whereas we could instead be allowing dedicated extension authors to easily selfhost the API now and file issues now, such that we can quickly fix them while backwards-compatibility is non-essential.
If I understand correctly, the concern with opening up too many extensions to use Proposed API is:

End users shouldn't have extensions break with VS Code updates, as that increases reluctance to upgrade and thereby increases fragmentation. Extensions that use Proposed API are likely to break with VS Code updates. We don't want fragmentation, so we should limit the ability for extensions to use Proposed API.

I agree that fragmentation is to be avoided, but I believe we mitigate this by only opening up to Insiders users (who have self-selected to update daily) and showing the flashing warning dialog explaining that this isn't to be used outside of testing purposes.

@gjsjohnmurray

instead perform one manual update right after a new Insiders comes out right after a new Stable.

Probably better to use the insiders right before the new Stable, as that's the same as Stable. The one right after a new Stable comes is the least hardened of any in the cycle (1+ week of dev work with 0 user testing 🙂)

After discussing with @kieferrm we agree the value added by getting more use of proposed api is substantial, accordingly I've removed the hidden setting feature flag and slightly modified the wording:

Also @sbatten had an interesting idea to disable all escape hatches in Stable (such as --enable-proposed-api via CLI), but in exchange open up some access points in Insiders (such as this, or even allowing proposed api for all extensions by default).

I have had success with asking individuals who want specific API to try out a proposal and confirm that it works well for them. I have seen no need to enable selfhosting of proposed API.

Still 👎 With this approach any user will be able use extensions consuming proposed API without our consent nor knowledge. That will play against our reputation of being a stable host for extensions. We will break proposed APIs and extensions will fail and what happens is that bugs are filed against us. You will see the dialog today and in a couple of month when your favourite extension stops working you will not remember that you have clicked a button. Take this issue as a sample: https://github.com/microsoft/vscode/issues/110569. To blame is LiveShare which hasn't adopted a change in vscode.proposed.d.ts that was made ~2month ago. For LiveShare we at least know to whom to talk to (enough tho the promise was we don't need to do that) but for extension foo on machine bar we have zero knowledge and I will not deal with those issues and don't think that you have a good answer for how to deal with such issues.
Apart from the massive headaches this will be causing I am actually not convinced that "more users of feature using proposed API Y leads in good or more feedback on the proposed API Y". I cannot follow that logic and I actually don't recall issues where such feedback has been provided. Also not for the search api proposal which apparently gets used via command-line tricks.

Since apparently nobody read https://github.com/microsoft/vscode/issues/110729#issue-743855777. It says

A stretch goal is to have a process for how to onboard extensions to be in the product.json allow list.

What that means, and what the LiveShare case (#110569) shows, is that listing extension identifiers in product.json is already insufficient. So, instead of relaxing things even further (as with this PR) we should go the opposite direction, make things stricter, and then we can hopefully onboard more extensions onto proposed API usage.
What I mean: We have no idea what proposed API an extension is using (and shipping with). We have no idea when those extensions are broken because of our changes. Also, extension authors apparently have no idea when they are broken because their CI isn't proper and because they aren't on top of things. The result is a broken experience in VSCode and issues filed against us (again see #110569).
What I propose: We want to know when an extension (that uses proposed API) doesn't work any more. With that we would simply disable it and tell the user something like "extension foo is disabled because it didn't adopt changes of preview features it uses". I believe the granularity should be a proposal (which in vscode.proposed.d.ts is represented as regions, sample). The version can be implicit, like a content hash of the proposal, or explicit, like a version number in the region-comment. An extensions package.json will list a proposed API and version and we do the checks, disablement, informing users etc. Will all that in place I would feel comfortable to have more extensions listed in product.json or even not have it any more

Would strict version of proposed api allow using it in Stable (since it will know if the api has changed or not) and publishing proposed extensions to the marketplace?

Would strict version of proposed api allow using it in Stable (since it will know if the api has changed or not) and publishing proposed extensions to the marketplace?

Yeah. At least that's how it is today with extensions listed in product.json. Tho, it is painful to react to API changes since you would then need two versions of your extension. @eamodio brought up the idea to add a way to check for the availability of a certain API, like vscode.env.hasProposedApi(proposalId: string, proposalVersion: string): boolean. That should make it simpler to write an extension using proposed API

. @eamodio brought up the idea to add a way to check for the availability of a certain API, like vscode.env.hasProposedApi(proposalId: string, proposalVersion: string): boolean.

Wait... What we didn't consider is that such a function means that we cannot disable an extension when its declared api usage isn't matching the actual proposal API shape. We would need to rely on extensions using this check and otherwise obscure failures happen. I don't think we want that and that we should start with "little power"

We cannot disable an extension when its declared api usage isn't matching the actual proposed API shape

Spitballing some way we could make the dynamic proposal availability checking well-typed and enforceable...
vscode.proposed.d.ts
//#region https://github.com/microsoft/vscode/pull/110617
//#id ExampleProposal
export function myProposedAPI(): void;
//#endregion

vscode.proposalHashes.ts (generated at buildtime)
export const ProposalHashes = {
   ExampleProposal: 'S0M3HA5H',
   ....
}

vscode.proposalGates.d.ts (generated at buildtime)
declare module 'vscode' {
   export namespace env {
       export function acquireProposedApi(
          id: 'ExampleProposal',
          version: ProposalHashes['ExampleProposal']
       ): undefined | vscode & { /* type of the proposal */ }
      ... etc for all proposed ...
  }
}

extHostImpl.ts
function myProposedAPI() {
    if (!extensionProposalService.hasProposalGrant(ext, ExampleProposal)
      throw "Extension needs updating blah blah blah")
    doMyProposedAPI()
}

function acquireProposedApi(id: string, version: string) {
   if (version === ProposalHashes[id]) {
      extensionProposalService.grantProposedAPI(ext)
      return vscodeAPIImpl
   }
   console.warn(ext, 'wants proposed api but blah blah blah')
   return undefined
}

extension.ts
import * as vscode from 'vscode' // Only including vscode.d.ts and vscode.proposalGates.d.ts

activate() {
   const vscodeWithProposal = acquireProposedApi('ExampleProposal', 'S0M3HA5H');
   if (vscodeWithProposal) {
      vscodeWithProposal.myProposedAPI();
   }
}

Some open questions remain, including how extensions migrate from proposed to stable when proposals become solidified, and how we could handle making backwards compatible changes to the API's without breaking everything when the hash changes.

This is an interesting proposal but things are more complex (as always). Not all proposed APIs are symbols that you can probe for, some are just "receivers". Take this for instance: https://github.com/microsoft/vscode/blob/12b808cf080f241759149ffa2bfaaa12ad21b217/src%2Fvs%2Fvscode.proposed.d.ts#L1016-L1022
Newly proposed is the | MarkdownString overload and the enforcement of that API is done only when reading.
Also, in the approach this is assumed:
import * as vscode from 'vscode' // Only including vscode.d.ts and vscode.proposalGates.d.ts

Assuming that proposals aren't defined in the vscode-module is really big trouble because them being so and being merged by TypeScript is the backbone of validating the actual api implementation.
In short, I stand by my original strictness of being able to tell that a proposal isn't available statically and then disabling extensions. I agree that feature probing is somewhat cool tech but it is a non-goal of the API proposal process.
For now, I would propose that we focus on the very first step which is to define a declaration for identifying and versioning proposal. Some format that can be authored in vscode.proposed.d.ts and that is trouble-tree. Ideas/questions

Is the identifier of a proposal the issue number of its tracking issue?
Is the version the content hash of the proposal source text? Would changing a comment or whitespace be an API change then?
Is the version something the author needs manually update?
Is there tooling that tells us when a proposal changed but its version hasn't been updated?
How do extension authors know the proposal versions?

Given those considerations (which are likely incomplete) I would propose something like this:

in vscode.proposed.d.ts we author (manually) the proposal id and version
we add a lint rule that computes the version based on non-trivia text of the proposal
the lint rule has an auto-fix to update the version

Sample:
//#region https://github.com/microsoft/vscode/issues/998877 cfe87ae

/**
 * Bla, api is cool
 */
export const foo: number;
//#end region

The following is true

https://github.com/microsoft/vscode/issues/998877 is the proposal identifier (maybe 998877 as short form)
cfe87ae is the version
cfe87ae === magic_hash('export const foo: number;')

With that information extension authors can quickly look-up what proposal and version they are toying and we have little hassle with maintaining that information

Might be a good idea if Issue Reporter's list of extensions indicated which ones have proposed API enabled. Then we just need to get people to use Issue Reporter...

This will not happen


Number of digits for float/double types

Which version of Elastic are you using?
[x] elastic.v3 (for Elasticsearch 2.x)
Please describe the expected behavior

Saving a Go float32 in an ES float should work
Saving a Go float64 in an ES double should work

Please describe the actual behavior
Only when using a map of strings it's possible to use ES float and double correctly.
Example mapping:
{
	"properties": {
		"id": {
			"type": "long"
		},
		"bar": {
			"type": "nested",
			"properties": {
				"a": {
					"type": "float"
				},
				"b": {
					"type": "float"
				},
				"c": {
					"type": "float"
				},
				"d": {
					"type": "double"
				}
			}
		}
	}
}

If I use a document like:
doc := map[string]string{}
doc["a"] = fmt.Sprintf("%.6f", 1.0/3)
doc["b"] = fmt.Sprintf("%.6f", 1.0/3)
doc["c"] = fmt.Sprintf("%.6f", 2.0/3)
doc["d"] = fmt.Sprintf("%.6f", 5.0/7)

Then I can store it correctly. Otherwise I get 400 bad request:
mapper [foo.bar] of different type, current_type [double], merged_type [long]

This is by the way a horrible/unfriendly error message, because it does not tip about the fact that long was picked when trying to parse the source data.
NOTE: the problem happens only with floats/doubles which have a lot of digits after the dot, and I assume it's due to the way they are encoded in JSON and then received by ES (I do not know for sure this, it's my assumption).
Are we sticking to any standard regarding the encoding of floats/doubles in JSON? And what does ES expect in this case?

By the way, I just noticed that the map of strings workaround coerces the field value to be a string, I will repeat my tests with a custom marshaller.

I cannot reproduce it anymore and I do not have the dataset that triggered the behavior...sorry for the noise. I will re-open if I find what is causing this mapping exception again.


Move copycat dependency to catalyst

Remove the copycat dependency and change it to a much smaller catalyst dependency.
Catalyst dependency is needed for Grpc messaging serialization and deserialization.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11175/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11177/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11178/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11179/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11182/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11183/
Test FAILed.

alluxio.server.ft.journal.raft.EmbeddedJournalIntegrationTest
23:25:07.136 [ERROR] alluxio.server.ft.journal.raft.EmbeddedJournalIntegrationTest.restartStress  Time elapsed: 600.023 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 600000 milliseconds
at alluxio.server.ft.journal.raft.EmbeddedJournalIntegrationTest.after(EmbeddedJournalIntegrationTest.java:72)
23:25:07.137 [ERROR] alluxio.server.ft.journal.raft.EmbeddedJournalIntegrationTest.restartStress  Time elapsed: 120.146 s  <<< ERROR!
java.util.concurrent.TimeoutException: Timed out waiting for 11 successes options: WaitForOptions{interval=20, timeout=120000} last value: false
at alluxio.server.ft.journal.raft.EmbeddedJournalIntegrationTest.restartStress(EmbeddedJournalIntegrationTest.java:337)

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11184/
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11185/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11189/
Test PASSed.

alluxio-bot, merge this please


UltimaLive support

Describe the solution you'd like
Implementation of UltimaLive

this is a long term task, will do it, but it's not a priority for now.


Adding labels to hosts removes the automatically created host labels

Using the new reskin.
In v0.46.0, hosts added through a custom host command are automatically given the following labels
io.rancher.host.docker_version and
io.rancher.host.linux_kernel_version
If I edit the labels on the host, the system labels on the host are over-ridden as they aren't shown in the UI.
Steps to Reproduce:

Add  host to Rancher
Look at labels on host to see the above labels
Edit the host to add labels. and click save
Click on Labels of Host

Result: Only shows new user created labels. The io.rancher labels are gone.
Expected Result: The new user created labels would be shown with the io.rancher labels.

Verified with master on 11/23 evening build.


Partial function works differently in UI compared to packages

Using the partial function in code results in
"test": [
<EMAIL_ADDRESS>@.CoveragePremiumExclTaxes, @.CoveragePremiumInclTaxes)",
<EMAIL_ADDRESS>@.CoveragePremiumExclTaxes, @.CoveragePremiumInclTaxes)"
]

instead of the right filterd objects, whereas in the UI the function works fine

It seems that the packages you used were older than those used in the UI. if you upgrade the packages, the behavior will be the same


Tariff explorer

Closes #671

Feedback:

[ ] "Missing data" (here) leading to 0.5 values being plotted as zero
[ ] Request to highlight Category changes in different colours
[ ] 2 decimal places for hover
[ ] Consider ability to add more than one drug

[ ] Cleanup code: lint javascript, code review

Replaced by #679 (easiest way to clean up commit history given it includes merges)


drivers: dac: Add support for Microchip MCP48XX devices

This driver covers the MCP4802, MCP4812, and MCP4822 DACs.

@emz229 do you plan to come back to this PR?

@MaureenHelm I am monitoring the thread where it is being discussed by several maintainers. See https://github.com/zephyrproject-rtos/zephyr/issues/73090


"System is being upgraded please try again later", how to bind device to Xiaomi account?

"System is being upgraded please try again later", says Xiaomi Redmi Note 13 Pro+ when I try binding device (zircon) to Xiaomi account from "Settings > Developer options > Mi Unlock status" menu. Is there another (cli?) way to do this instead of this menu?

same issue Redmi Note 13 Pro+
can find work around


Add support for typescript via type definitions in @types folder.

Add support for typescript via type definitions in @types folder.
Install typescript, emit typedefs, and "fix" index.d.ts.
Replace all BigInteger math function calls with standard BigInt...
... overloads (BigInteger(value).multiply(BigInteger(value2)) ->
BigInt(value) * BigInt(value2))
Type nearly everything in TestSampleCode.ts.
Fix all errors that were due to typing vars in "for...of" statements.
NOTE:
keyImage is defined as string. This is probably correct but can't be
verified due to lack of documentation and my inability to trace the
method chain in the source code.
Intermediate progress writing script to replace BigInteger.compare.
Find lefthand terms of .compare operations.
Replacing BigInteger.compare() with BigIntegerCompare() in progress.
Fix all errors and finish converting TestSampleCode.js to Typescript.
Update "async" to version 2.6.4.

This was a messy, messy merge/rebase. Please take a good look at the diffs to make sure nothing screwy is going on.

Related issue: https://github.com/monero-ecosystem/monero-javascript/issues/81

Wow.  This is a crazy amount of code... it will be extremely useful for anyone using MoneroJs in the future.  Great job. I was able to pull your PR into my active project by replacing monero-javascript in the package.json file with "monero-javascript": "BeanTosser/monero-javascript#add_typescript_support" (if anyone's interested)
It may be worth breaking things into additional index.d.ts files in each group (common, daemon, etc) just to make things a little less heavy in the big index file (though you would have to import the group indexes into the main index :upside_down_face:  )
Bugs:
I'm not able to run this yet- first bug I'm seeing: Module not found: Error: Can't resolve './src/main/js/common/BigIntegerCompare' in 'node_modules/monero-javascript'

Replacing with #108


Allow promotion from int32 to int64

Describe the enhancement requested
I would expect to allow concat_tables to promote an int32 to an int64:
def test_concat_tables_with_promotion_int():
    import pyarrow as pa
    t1 = pa.Table.from_arrays(
        [pa.array([1, 2], type=pa.int64())], ["int"])
    t2 = pa.Table.from_arrays(
        [pa.array([3, 4], type=pa.int32())], ["int"])

    result = pa.concat_tables([t1, t2], promote=True)

    assert result.equals(pa.Table.from_arrays([
        pa.array([1, 2, 3, 4], type=pa.int64())
    ], ["int"]))

This fails with PyArrow <IP_ADDRESS>
>   ???
E   pyarrow.lib.ArrowInvalid: Unable to merge: Field int has incompatible types: int64 vs int32

Component(s)
Python

You'd need to revive PR #12000

@lidavidm Wow, thanks for the quick response. I'll dig into it


Implement the splits.io API

I created bindings for the splits.io API here: https://github.com/LiveSplit/splits-io-api
These should be sufficient to integrate downloading / uploading splits soon.


Create Pull Request Template

Overview
This change creates a file named PULL_REQUEST_TEMPLATE.md, and the contents within will initially populate each new PR.
The goal is to make it easier to consistently fill out whatever info our team prefers when we create a PRs.
Details

This utilizes a feature released by Github back in February.
If you'd like to see an example of a PULL_REQUEST_TEMPLATE.md or an ISSUE.md I can show you how this works over at jedcn/reveal-ck.
I threw in some basic content in the template, and look forward to figuring out what should actually go there.

Anything else?
If this makes sense, we could also introduce ISSUE.md and CONTRIBUTING.md. We could end up putting all of the "Github Meta Files" underneath .github/ if the top level gets too crowded.

I think this is a great idea @jedcn!  👍

We might want to chat about what exactly we have in these files but I think it's a good start.


PlayFromFlash example not working?

I have my Photon hooked up to a amp and speaker.  I tried the sawtooth example and it played fine.  I tried the "PlayFromFlash" example and I have silence.  Can you confirm that the example works?

I had bad code.  Closing issue!


Unwanted letter "B" at the beginning of the printout

I have a problem at the beginning of the printout, whenever I make a printout, it is automatically printing the letter B, as illustrated in the image

I just verified here in the issues that this is a bluetooth.paperCut() call, some models do not support it, so it needs to be removed from the code.


Social media icons are not responsive

The social media icons provided in the footer section are irresponsive. I would like to fix this issue under GSSoC'23. Please assign this issue to me.

I want to work on this issue as a contributor.
Pleasure Assign so that I can show my skills under GSSoC'23.

can i work on this issue if u assign this to me

Hey @Anupkjha2601, I can resolve this issue. I'm a contributor to GSSOC'23 please assign this issue to me as a part of GSSOC'23


docs(api): add ticks to Godoc to fix generated API docs

This PR is the next one in the series of PRs to regenerate approver-policy API docs in our website project, ref. https://github.com/cert-manager/website/pull/1415
/cc @SgtCoDFish

/test pull-cert-manager-approver-policy-test


Paste into quick menu works only in insert mode or command mode

Steps to reproduce:

Open Oni
Ctrl+P
Ctrl+v (need to have something in clipboard)
Nothing happen  < ------
Press  Esc (close menu)
press i (to enter insert mode)
Press Ctrl+P
Press Ctrl+v
Text from clipboard pasted into input

Same for Ctrl+Shift+p, Ctrl+Shift+f
Comment from Ryan C

I expect its this
https://github.com/onivim/oni2/blob/749848d028340f789587ebaf81b9ff81499a5f79/src/Store/KeyBindingsStoreConnector.re#L71-L75
Since it only runs on insertMode or commandLineFocus (i.e. the vim command line)
Adding textInputFocus should fix that bug, I believe its a mistake its only insertMode and commandLineFocus
It was originally always active, but that obviously clashes with the vim bind so it was changed and must have been missed

I'll fix it after https://github.com/onivim/oni2/pull/1716

Fixed by PRs related to https://github.com/onivim/oni2/issues/2428


High, FDH and UHD resolution not working

We are now using the master branch and default resolution in the config file is set to medium. Users can lower the resolution from medium to low, but when they increase from medium to anything higher, the screen stays at medium. This happens when there is more than 1 person in the room. Last week resolution was working fine with the dev branch. So, it's not an issue with the device camera.
Can replicate the issue on letsmeet.no as well

Clearing cache did the trick... not sure what happened.

@cap19
For me with the latest master. it seems working.
Can you please double check?


Euclidean loss

I would like to know the reason for the axis=-1 in the euclidean loss computation
            def eucli(y_true, y_pred):
                # Euclidean distance as a measure of loss (Loss function)
                return K.sqrt(K.sum(K.square(y_pred - y_true), axis=-1))

My model performs better when I remove this axis (and sum over all the density map)

hello
Why my training is wrong? what's the problem
70/700 [==>...........................] - ETA: 1:28:58 - loss: nan - mean_squared_error: nan['data\part_A_final/train_data\images\IMG_137.jpg']
(73, 128, 1)
71/700 [==>...........................] - ETA: 1:28:09 - loss: nan - mean_squared_error: nan['data\part_A_final/train_data\images\IMG_139.jpg']
(46, 68, 1)
72/700 [==>...........................] - ETA: 1:27:07 - loss: nan - mean_squared_error: nan['data\part_A_final/train_data\images\IMG_181.jpg']
loss is nan

Hello，I have a question for this.
Why My loss is about 0.07 ?
I am not family with the loss and My training process is right? I know I have a problem in 'acc' and it should be 'mse'.
Epoch 1/200
/usr/local/lib/python3.6/dist-packages/ipykernel_launcher.py:34: DeprecationWarning: Both axis > a.ndim and axis < -a.ndim - 1 are deprecated and will raise an AxisError in the future.
700/700 [==============================] - 1453s 2s/step - loss: 0.0765 - acc: 0.1712
Epoch 2/200
700/700 [==============================] - 597s 853ms/step - loss: 0.0731 - acc: 0.1873
Epoch 3/200
700/700 [==============================] - 510s 728ms/step - loss: 0.0681 - acc: 0.1805
Epoch 4/200
700/700 [==============================] - 500s 715ms/step - loss: 0.0748 - acc: 0.1870
Epoch 5/200
700/700 [==============================] - 501s 716ms/step - loss: 0.0711 - acc: 0.1848
Epoch 6/200
700/700 [==============================] - 500s 715ms/step - loss: 0.0754 - acc: 0.1868
Epoch 7/200
700/700 [==============================] - 498s 712ms/step - loss: 0.0747 - acc: 0.1732
Epoch 8/200
700/700 [==============================] - 493s 705ms/step - loss: 0.0754 - acc: 0.1765
Epoch 9/200
700/700 [==============================] - 495s 707ms/step - loss: 0.0730 - acc: 0.1830
Epoch 10/200
700/700 [==============================] - 507s 724ms/step - loss: 0.0736 - acc: 0.1936
Epoch 11/200
700/700 [==============================] - 464s 662ms/step - loss: 0.0727 - acc: 0.1928
Epoch 12/200
700/700 [==============================] - 455s 651ms/step - loss: 0.0763 - acc: 0.1850
Epoch 13/200
700/700 [==============================] - 456s 652ms/step - loss: 0.0702 - acc: 0.1852


Wrong calculation for baseValue with rem units

First thank you for this great lib!
I think at line 30 multiplication should be used instead of division.
https://github.com/twbs/rfs/blob/bbdd5597d81af2a0424d27133510143dbb47efa5/lib/rfs.js#L29-L31

@aggreggator,
The baseValue is used to convert the px values to rem and this should work as expected. See https://codepen.io/MartijnCuppens/pen/wvadXRb?editors=1100.


A way to enable globally

It would be nice if the extension could be globally enabled using a toggle in the settings instead of having to choose from plugins. Less cumbersome and also allows you to use dynamic prompts within other scripts.

That is currently the case, are you using a recent version of the script, i.e. >= 0.17.0?

That is currently the case, are you using a recent version of the script, i.e. >= 0.17.0?

i think he means the wildcards, when you have dynamic prompts enabled, UnivAICharGen breaks, also the wildcards extension breaks too

Added a checkbox in 0.21.0


Questions about Go!

foreword
Go is really strange!
Like this:
Go's return values may be named. If so, they are treated as variables defined at the top of the function.
and this:
A return statement without arguments returns the named return values. This is known as a "naked" return.

Hmmm this sounds really strange. But, what's your question?

My question is： “The example shows variables of several types, and also that variable declarations may be "factored" into blocks, as with import statements.” After I read Chinese Tutorial， I understand it.

Another question:
`package main
import "fmt"
const (
// Create a huge number by shifting a 1 bit left 100 places.
// In other words, the binary number that is 1 followed by 100 zeroes.
Big = 1 << 100
// Shift it right again 99 places, so we end up with 1<<1, or 2.
Small = Big >> 99
)
func needInt(x int) int { return x*10 + 1 }
func needFloat(x float64) float64 {
return x * 0.1
}
func main() {
fmt.Println(Big / 10)
fmt.Println(needInt(Small))
fmt.Println(needFloat(Small))
fmt.Println(needFloat(Big))
}`
At line 19, it will come an error "overflows int", but when I alter that to "Big*0.1", it will be all right.
Why?

Question again…
https://tour.golang.org/flowcontrol/7
Why print “27 >= 20” before “9”？

Q1
I'm first trying to rephrase your question to show you an example about how to make it easier to understand thus saving both of our time.

In Go tutorial basic secion, I met a problem of int type overflow. I guess it has nothing to do with the original code, so I will omit other parts but just paste where error happens
const (Big = 1 << 100)
func main() {
   fmt.Println(Big / 10)
}

It fails to run with error saying overflows int. I also tried following code which works correctly
const (Big = 1 << 100)
func main() {
   fmt.Println(Big * 0.1)
}

Basically they are doing the same thing but why the first one fails?

Answer
This is a very good question. I don't have a real answer but it may be something can help you find the real one.
Since Big * 0.1· works, we naturally may think that because Big was converted into a float. Thus it works. If Big / 10` then Big is still a int, so it overflows. It explains. But why Big itself doesn't overflow? I did following investigation.
const (Big = 1 << 100)
func main() {
   var big = Big,
}

It complains big overflows. It means Big itself should be overflowed. So some potential explanations are

in Go, const var is not assigned until it has been used. It means in declaration, Big is not assigned with any value. So it doesn't overflow.
in Go, if you don't specify a type for a const, it doesn't assign value util the type can be referred.

This is a really question and I'm happy to see you find it and think about it. You should dig into Go's language manual to understand how a const var is defined, the value and the type.

Q3
Try to step into the execution of this program and try to answer following questions. Then you'll get the answer.

what's the return value of pow(3, 2, 10)
what's the return value of pow(3, 3, 20
so what's the value of parameters of function fmt.Println in

    fmt.Println(
	pow(3, 2, 10),
	pow(3, 3, 20),
    )

what will `fmt.Println(9, 20) print?
where does the output 27 >= 20 come from

Q3
I reread the tutorial from this page, they say "Constants are declared like variables". The type in the declaration like variables can be omitted, ans the variable will take the type of the initializer.
And "An untyped constant takes the type needed by its context."
Also "Numeric constants are high-precision values"
If like this, the type of Big is int (I guess?).
your explanation 2—— if you don't specify a type for a const, it doesn't assign value util the type can be referred——maybe is not correct ?

Q3
I have no idea about the answer. I just gave you couple hypothetical possibilities which are most likely not true. You need to find out a way to find the answer.

Q4
Type Slice is really weird!!
I was wondering whether slice change the original array.
In this page, they say "Slices are like references to arrays"
But in this page, when run the program, we found 's' is changed.
What most weird is this page.
```
// Slice the slice to give it zero length.
s = s[:0]
printSlice(s)
// Extend its length.
s = s[:4]
printSlice(s)

Slice the slice to give it zero length. I thought that 's' is empty. But next line, the slice can be extended……
Why……

Q5
Maybe this is a long-term question……
The topic is “define methods on types”.
I am not familiar with OO, so it will spend some time to study relevant knowledge.
"A method is a function with a special receiver argument.
The receiver appears in its own argument list between the func keyword and the method name."

Q4
I highly recommend that, you should first have a clear understanding of what is your question, before asking. For example, you question is "why.....". This seems like, you omits the question since it's obvious. But it is not true. The reason why you omits the question is because actually you don't really understand what is your question. You should never asking question like this.
Okay, so I'm going to complete your question. "Why can we extend a slice whose length is zero?" Now the answer is clear. Because here we're talking about the length, not the capacity. We give it zero length, not zero capacity. So that's why we can extend the length.
Regarding your first question, reference means pointer, in some extend. So, is that clear now?

Q5
As mentioned above, the first step to answer a question is clearly understand what is your question. Figuring out what you don't know can be as hard as figuring out what is the answer. So basically it means, most of time, we don't know what we don't know.
I recommend you read this article  first, try to understand different types of languages, and pros and cons of functional language. Then come back again and try to think out, what is your question.


Some regex metacharacters like \A and \z not supported in folder (Ctrl + Shift + F) search

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.80.1
OS Version: WIndows 10 22H2

Steps to Reproduce:

Press Ctrl + Shift + F to go to folder search.
Enable regex search.
Try searching for e.g. \Asomething which would normally find something only at the start of the file/whole string.
Popup with Invalid regular expression: /\Asomething/: Invalid escape appears.

AFAIK that part uses either Rust or PCRE2 engines, both of which support the mentioned metacharacters. I guess this is related to multiline matching then, but not sure why it'd throw an error either way, even if attempts to run the regex on each line, they should work.

Regexes aren't supported by JS won't pass validation, as we use JS regexes to search open files. See here

So it uses ECMAScript engine in the end? Is Rust/PCRE2 used somewhere else or was that info outdated?

It uses both the JS engine (for open files) and Rust/PCRE2 (for searching closed files). Therefore, it must compile in both to search in both. I believe that that's what the stackoverflow answer was referring to. Mentioning PCRE2 was more for the sake of a regex being interpreted differently in open vs. closed files by accident.

Why this approach? Why not e.g. use Rust/PCRE2 for everything?

The functionality for finding within a file was already using JS-based regexes and this was reused for searching in open editors. For example, if you have unsaved changes in the current file, these appear in the search view as its unsaved state since we also consider the state of open files in the editor.


Deployment behind firewall

Hi
Centurion looks really well designed, but am I correct in assuming that it doesn't allow one to deploy to machines behind firewalls?

Hi @arj03 thanks. :) I have never tried it personally, but because we rely on Excon for much of the API work, a lot of it will probably work if you set http_proxy and https_proxy environment variables. Check out the last section here: https://github.com/excon/excon#proxy-support
It looks like the Docker CLI which we also use for certain operations under the covers will also support proxying: http://robwin.blogspot.com/2014/04/running-docker-on-centos-behind-proxy.html
Give that a shot and please report back if it works!

Hi
Thanks for your reply.
I'm a little unsure as to how the deploy works exactly. It seems like one specifies the hostnames / ips of the machines that one deploys to, so it looks as if you ssh into them and update them? Or how do you trigger them to start the update?

Hi @arj03, we were deploying to machines behind a firewall, but abandoned that pretty quickly. Centurion communicates with docker deamon (mostly) via its API, so we opened that port on firewall and set up a TLS authentication to maintain security. That was a major pain point, since we had to generate and maintain additional certificates and distribute them to servers. We even had this automated, but it was simply not worth it. In the end, we opened an additional machine within the unfirewalled private network and just deploy from there. So the steps are: 1. ssh to the deploy machine, 2. pull fresh scripts, 3. run centurion.

Thanks for the explanation.
The problem is we are thinking of deploying to thousands of machines in vastly different networks, so opening a port up is not something we just do. One way around it is to start an ssh tunnel for when we update, but then that has to be handled seperately and integrated into the deploy process.

How would you envision this should work? I'm not sure I understand how you would want this to work. In order to deploy you'll need to talk to the servers, somehow, so a deployment/jump host as @kremso suggests is about the easiest way. You'll need to have some way to communicate through the firewall, obviously.

Well, I was thinking something along the lines of a daemon running on all the machines, that we push updates to. They can do this over standing https meaning that it should work just about anywhere.

@arj03 Docker uses https when you have TLS enabled. Centurion supports TLS thanks to @zedtux so I think it already does what you want. Check out the TLS settings in the README.


bpf: nodeport: re-introduce Ingress HostFW between RevSNAT and RevDNAT

https://github.com/cilium/cilium/commit/5e2202af5c10056d303791d3b24e2656095e0446 ("bpf: nodeport: make Ingress RevDNAT tail-call conditional")
changed the sequence in which RevNAT and Ingress HostFW are
applied on modern kernels. Where previously we would apply in them in the
order of
RevSNAT / Ingress policy / RevDNAT,
the new sequence is
RevSNAT / RevDNAT / Ingress policy
as we now inline nodeport_rev_dnat_ingress_ipv*(), and then only on the
recircle pass through the Ingress policy in bpf_host's handle_ipv*().
With the subtle difference that

we now apply policy after RevDNAT, and thus the .saddr is the VIP
instead of the backendIP, and
after RevDNAT, we might redirect to a different interface
(and thus not recircle, skipping Ingress policy entirely).

Restore the old sequence, by shuffling the relevant HostFW policy code back
into place between RevSNAT and RevDNAT. Having it there was the plan all
along :).

/test

/test

/test

/test


impass_mask

tile flag for making only parts of a tile impassable as defined by a mask

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/22967325-impass_mask?utm_campaign=plugin&utm_content=tracker%2F7646105&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F7646105&utm_medium=issues&utm_source=github).

#41


create a round only where there are two active players

There are two cases where the player can be alone in the room:

a player joins the room and no one else joined yet, he can still choose before any other one joins, in that case, his choice should not trigger a round creation.
the room has many players, and most of them got eliminated (by winning or losing), there are only two remained players and if one of them decides to leave the room (forfeit) the other players should automatically be the last one active. Now ethically speaking:
---> this could be fair when it is about winning, he/she won every round, and in the last game the opponent drops off, he/she should win this round too.
---> this could be unfair when it is about losing because he/she will be automatically the ultimate loser just because his/her opponent drops off ( I don't know how they handle this in sport honestly)

This will be talked through in Sunday's meeting. The refactoring pull request will changes some logic that will cos a huge conflicts for this PR


Update emoji-search sample app README with web instructions

@JakeWharton, @swankjesse, for some reason, I cannot edit the reviewers field. Do I need to be granted write/maintainer access for this repository?


Pass failing commands via studio API

Proposed changes
copilot:summary
Testing

built locally
ran failing and succeeding assertion

Issues fixed

#1617 failing assertions shows up in studio ui

Rebased


Setting "documentation.enable = false" doesn't get rid of asciidoctor dependency

Describe the bug
I'm trying to prune a NixOS install to the absolute minimum. This seems to be a lot.
To Reproduce
I'm on nixos-20.09.2635. I've set
  environment.systemPackages = with pkgs; [
  ];
  environment.defaultPackages = with pkgs; [
  ];
  documentation.enable = false;

There's nothing in the user's or root's environment.
However I still get python-2.7.18, ruby, a whole set of fonts and image libraries, through asciidoc and asciidoctor.
Following the chain:
/nix/store/qyywkkys7k9rwh4ik8x1h1bwqihxrixl-asciidoctor-2.0.10.drv
→ /nix/store/47km899r61m816hv8smgma9mpla49yb2-libndctl-69.drv
…
→ /nix/store/7zcs865y50cp0y843n3479lzi7mvihzr-system-units.drv
→ /nix/store/qbc6pxyy0p956ryqwia11443g66s8shy-etc.drv
→ /nix/store/dx3550qrlyqs0rm08yfxsgzcqlcmbhp6-nixos-system-nixos-20.09.2635.f5f66148b28.drv (this is the current system)

It looks like libndctl-69, the only remaining user of asciidoctor, is the culprit here.
I looked at the package description. asciidoctor is a fixed dependency, not gated on the documentation setting, there's no way to disable it.
Am I misunderstanding how this should work?
Expected behavior
A system with almost nothing in /nix/store.

Should probably mention the maintainer @thoughtpolice

Should probably mention the maintainer @thoughtpolice

one way would be to not build the docs
diff --git a/pkgs/development/libraries/libndctl/default.nix b/pkgs/development/libraries/libndctl/default.nix
index 6e82191e755..33ea81d90b1 100644
--- a/pkgs/development/libraries/libndctl/default.nix
+++ b/pkgs/development/libraries/libndctl/default.nix
@@ -1,5 +1,5 @@
 { lib, stdenv, fetchFromGitHub, autoreconfHook
-, asciidoc, pkg-config, xmlto, docbook_xsl, docbook_xml_dtd_45, libxslt
+, pkg-config
 , json_c, kmod, which, util-linux, udev, keyutils
 }:

@@ -14,24 +14,29 @@ stdenv.mkDerivation rec {
     sha256 = "sha256-osux3DiKRh8ftHwyfFI+WSFx20+yJsg1nVx5nuoKJu4=";
   };

-  outputs = [ "out" "lib" "man" "dev" ];
+  outputs = [ "out" "lib" "dev" ];

-  nativeBuildInputs =
-    [ autoreconfHook asciidoc pkg-config xmlto docbook_xml_dtd_45 docbook_xsl libxslt
-      which
+  nativeBuildInputs = [
+    autoreconfHook
+    pkg-config
+    which
     ];

-  buildInputs =
-    [ json_c kmod util-linux udev keyutils
-    ];
+    buildInputs = [
+      json_c
+      kmod
+      util-linux
+      udev
+      keyutils
+  ];

-  configureFlags =
-    [ "--without-bash"
+  configureFlags = [
+      "--without-bash"
       "--without-systemd"
-      "--disable-asciidoctor" # depends on ruby 2.7, use asciidoc instead
-    ];
+      "--disable-docs"
+  ];

-  patchPhase = ''
+  postPatch = ''
     patchShebangs test

     substituteInPlace git-version --replace /bin/bash ${stdenv.shell}


Get submodule/subtree working with Sia-UI

The Sia-UI repo has history and is ready to go, but is not yet linked to the main Sia repo.
Git subtrees seem to be a good approach, although I'd like to defer this to the great git grand maester @lukechampine

I actually just had a thought... instead of Sia importing Sia-UI, why not the other way around?
After all, it makes sense for Sia to just be library. It might even simplify the design, because the sia package could then live in the top-level. No more NebulousLabs/Sia/sia.

Hmmm, that does make a lot of sense. Because the UI is basically going to be a desktop application, all the startup/shutdown logic will actually be in it instead of Sia.
I think that's probably the best approach at this point.

I'm with Luke we were being silly before

I think some structural changes might be helpful then, if Sia is a library that the UI calls then should it really be the style/web folder within Sia?
Maybe siad could take an optional parameter to the style/web folder?

Actually, it's not necessary for Sia to host the files anymore- it would all be done through atom-shell/node-webkit. So siad could just handle the API and not worry about the style folder

Sounds good to me, I don't think golang is really a great tool for serving pages anyway.


"JVM is terminating. Shutting down Winstone"

This job just stopped with no apparent reason.
The log on jenkins-master says:
Feb 16 18:05:07 ip-172-31-2-59 [jenkins]: INFO: JVM is terminating. Shutting down Winstone

http://jenkins-ci.361315.n4.nabble.com/Jenkins-JVM-crashes-after-few-minutes-after-start-td4417465.html?

We already run under
cd /var/lib/jenkins
touch jenkins.start
exec chpst -u jenkins -U jenkins \
  env HOME=/var/lib/jenkins \
  JENKINS_HOME=/var/lib/jenkins \
  java -server -Xmx4G -XX:MaxPermSize=512M -XX:+HeapDumpOnOutOfMemoryError -jar jenkins.war \
  --httpPort=8080 \
  --httpListenAddress=<IP_ADDRESS> \

and no hprof memory dumps were found. CPU usage was much higher than usual according to EC2 monitoring, but that's all I have...

Maybe it's terminated from a browser console due to a javascript bug. Or a Jenkins virus!

That message is logged in a JVM shutdown hook
If we keep seeing this, we could start that JVM with a custom java agent that logs a stack trace when System.exit is called. I can't think of a more straight forward way to diagnose this.

Closing because we haven't seen this since.


Trying out codeql action

Code scanning for common bugs provided by GitHub: https://codeql.github.com/docs/codeql-overview/about-codeql/
See https://github.com/github/codeql/tree/main/javascript/ql/src for the list of checks.

I'm kind of confused by the description as to what this actually does. Is there a default security analysis in addition to the code querying?

I'm kind of confused by the description as to what this actually does. Is there a default security analysis in addition to the code querying?

Yep, you can find the default set of checks at https://github.com/github/codeql/tree/main/javascript/ql/src
I added a couple errors to this CL temporarily that should get caught. See above for example. One of them was for jsdoc (which didn't fire for some reason) and one of them for weak password hashing, which did!

I added a couple errors to this PR temporarily that should get caught. See above for example. One of them was for bad jsdoc (which didn't fire for some reason) and one of them for weak password hashing, which did!

For the record, in case removing the error makes this go away:

Awesome, thanks for triggering the demo @aomarks ! I wish their docs page lead to a demo. Maybe I missed it.

Awesome, thanks for triggering the demo @aomarks ! I wish their docs page lead to a demo. Maybe I missed it.

I had to dig for it, the docs site is not super clear I agree.


[Improvement][LDAP] LDAP bug fix && Improvements

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Recently, We have tried to enable LDAP on DS and found some questions.

version 2.0.5 User disabled and can't log in, and dev has the same bug, see #10386

Due to the above question,  we need to add a unit test to cover the LDAP user login case.

When you log in with LDAP and are not a ds user, it will create a new user automatedly. But in my option, LDAP login is the same as user-password log-in, if you are not a ds user, your login will be rejected. I think we can add a new config field, user can choose if they log in with LDAP and are not a ds user, which will create a new user or be rejected.

ds config security.authentication.type only can be password or LDAP log in. And do we need the mixed login same as Jenkins or Rancher?

When you log in with LDAP. And there are still change password pages. But LDAP users have no password config. I think hiding this page when you log in with LDAP is better.

dev branch has no LDAP config in the YAML file. Due to https://github.com/apache/dolphinscheduler/commit/4114cb07f64950f88ffb4aa8a4ecc4815f32d76b#diff-f2f54230647b5ed6920efc032cd61c4dc2acd8f728ad0f43aef1e8fd3f9793ed , I'll fix this and make LDAP to a switch,not a comments config.

And some contributor says LDAP needs some improvements, I'll fix this. See #10274

The last one, LDAP miss document, And I'll fix this too. See #10250

Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It seem that @EricGao888 is also working on some LDAP feature

Yes, I already talk to @EricGao888 and we make a deal and I'll handle with LDAP part.

It seem that @EricGao888 is also working on some LDAP feature

@liqingwang Looks cool to me. Just a kind reminder, there could be some differences between Microsoft AD and a typical OpenLDAP. Both of them are supposed to be taken into consideration, as described here: https://github.com/apache/dolphinscheduler/issues/10274#issuecomment-1140431540

@EricGao888  Sure, Thanks for your reminder.

#10274 Will be fixed by @EricGao888 Thx