Change default code of conduct

Hi, firstly: thanks for Bundler.  It's made Ruby development much easier and more enjoyable over the years, and I have the utmost respect and appreciation for everyone involved.
Secondly: thanks for including the option to include a code of conduct when generating a Gem.  It's important to spell out exactly what behaviour is and isn't acceptable when dealing with other project members, and when representing the project itself.  Tech in general has an inclusion problem, and a good CoC is one way of improving that.
However, the default CoC (contributor_covenant) you've picked has a significant issue; it can be used to censure project members for speech that is entirely outside the context of the project.
Some background: I opened a pull request to clarify the wording around project context.  My motivation in opening that pull request was OpalGate.  I wanted to make it clear that participation in a project that has adopted the contributor_covenant does not require contributors to self-censor their opinions outside of the context of the project.  The maintainers of contributor_covenant have made it pretty clear that property of the covenant is by design.
I suggest that we either:
a) Replace the default contributor_covenant with a more clearly-scoped version (perhaps just a fork based off my pull request?).
b) Provide alternative codes of conduct during the generation of a Gem.
c) Break out the code of conduct generation into a separate library, which can itself contain a wide range of codes of conduct from which users can choose (my preferred option).
If people are interested in option (c) I'm happy to do the leg-work involved in setting things up.

I don't think are likely to change this part of the bundle gem scaffolding, sorry.

I'm not asking them to change it, really; I'm mostly offering to do the work myself, either by b) baking alternative CoC into the code, or c) writing an external CLI tool to allow the choice of a CoC.

No, it's not the amount of work. We ourselves use the contributor covenant, so that's not going to change as the option for the generator. We also want to keep bundle gem simple, so we won't be adding additional options. As for c, the same thing applies -- bundle gem is a simple opinionated generator. You're more than welcome to use a tool like ore if you want more customization.

Okay, thanks for the clarification @segiddins.
It seems that the only option then would be a), and that would require either contributor_covenant to accept a PR clarifying the scope of project representation, or for someone to convince you (that is, the bundler project) to change covenant.
Unfortunately, contributor_covenant rejected my PR, which leads to the only remaining alternative being to convince you to switch to a different CoC, or perhaps a modded version of the contributor_covenant.
The reason I raised this was that I think that, as it stands, contributor_covenant is designed to enable behaviour such as @CoralineAda's request to have @elia dropped as a contributor to OpalRb.  I don't agree with that behaviour (in fact, I think it constitutes abuse, albeit perhaps of a milder form than @CoralineAda herself received in response), and I don't think a CoC that enables abuse should accepted by the Ruby community.
But then I'm opinionated, too :wink:

No. Really the only option for us is to keep things as they are, since we've made a very conscience decision to use the contributor covenant and have zero plans of changing that. The attitude of "the only option bundler has" is really not friendly, and it seems that you're trying to kick up trouble here.

@segiddins I'm sorry to hear that.  It's not my intent to start a fight.  I was using bundler to create a Gem this morning, and noticed the contributor_covenant option.  Given my already poor opinion of said covenant, I thought I'd raise an issue on bundler to discuss the possibility of replacing it.
Clearly that's not an option, so you may as well close the issue.  Thanks for taking the time to explain your (that is, bunder's) position on the matter.


warnings are not filled on the validations object

Environment

Ember Version: 2.12.0
Ember CLI Version:
Ember CP Validations Version: 3.4.0

Steps to Reproduce
https://ember-twiddle.com/79f50d8ee340f865d535e809175997f4?openFiles=controllers.application.js%2C
@offirgolan  Do you have any idea why warningMessages, isWarning and warning are not set on the {validations} when calling model.validate()?

Released with v3.5.0.


This is to workaround a problem in XLA's clustering, related to handling resources.

Workaround a problem in XLA's clustering, with the following code pattern,

 op0 : VarHandleOp
 op1 : Switch op0, pred
 op2 : ReadVariableOp op0
 op3 : ReadVariableOp op1

If op2 and op3 are clustered, the op0 and op1 are inputs,
and they are both considered as resources, and
op1 and op0 happen to point to the same resource, and
this will cause an execution error since the resource is
not allowed to be initialized (locked) twice.

The workaround here is to place contraint on clustering candidates to avoid such cases.

On your following comments,
"I have some minor comments inline, but I'm wondering if this scheme is too broad and would break up legitimate clusters. How much work would it be to do the following:
Run an analysis over the TF graph creating a set, S, of Switch nodes that produce resources.
For every Switch in S, find all the users of the switch (call this set SU) and all the users of the data input of the switch (call this set DU). Two nodes, x and y, cannot be in the same cluster if x is in SU and y is in DU.
Run a nested loop like we do for resource variable operations 0 to avoid clustering decisions that would place x and y in the same cluster, where x is in some SU and y is in some DU."
I believe it may be a better and more complete fix to the problem.  I would think it should not be too difficult to implement the algorithm.

@gbaned Looks like @xykong58 is currently working on addressing  https://github.com/tensorflow/tensorflow/pull/28387#issuecomment-490649220 ?

@xykong58 Did you get a chance to look on reviewer comments? Please let us know on the update. Thanks!

@gbaned  I thought I post an update which addressed all the feedback, and I haven't heard back from sanjoy, which is the reviewer.

Unfortunately there has been a miscommunication here.  I interpreted

I believe it may be a better and more complete fix to the problem. I would think it should not be too difficult to implement the algorithm.

As suggesting that you are going to implement the less conservative algorithm.  Though on a second reading it seems that you were only suggesting that doing this would be a good idea, but did not volunteer to do it?
Given that the more precise algorithm is not difficult, I think we should implement that more precise algorithm instead of the current less precise algorithm implemented in this PR.  Usually it takes a large amount of annoying work to identify why the TF/XLA bridge does not auto-cluster a graph as effectively, and if we can reduce the chance of needing to do that, I think we should.

Sorry, I did not make it clear I am not volunteer myself for the implementation. As my priority does not allow me working on the proposed solution, I would leave you to decide how to handle the PR.

@xykong58 Is this bug blocking you?  If not, I'd prefer closing the PR for now and revisit later if this ends up being a common problem.
(Speculatively closing the PR.)


Delete document

Napa was officially retired in March of this year. As such, this document (and any others that focus on Napa) should be deleted.
https://integration.napacloudapp.com/

Q
A

content fix?
no - yes?

New article?
no - yes?

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
Guidance
You can delete this section when you are submitting the pull request.

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'master' branch. Released documents are in live branch.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/sp-add-ins/create-a-basic-sharepoint-hosted-add-in-by-using-napa-office-365-development-too.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thx Cristy, we are in progress of getting these cleaned and thanks for your assistance around this.


Dutch language file

Added the Dutch translation files

Update the main.py line 59 😀

Yay that's excellent! Thank you!

@all-contributors please add @MasaiasuOse for translation

and here also
@all-contributors please add @phoenix-blue for translation


Support periodically sending ping message to keep websocket alive.

Can it be a feature in okhttp-ws?

The API allows sending pings. Just hook this up to a timer and send them on
an interval. There's far too many variations of when people want these to
be sent to try and encode the timing rules inside of OkHttp and the
websocket API.
On Tue, Nov 10, 2015, 4:24 AM 楊朝傑<EMAIL_ADDRESS>wrote:

Can it be a feature in okhttp-ws?
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/issues/1985.


Re-evaluate JSEnv Input modeling

Forcing every input to be of one type is a potential smell (example). We should think about this hard once again before we commit to it.

I'm not sure what you mean. IIUC, you're saying that Input should allow cases like "load this script; then load this CommonJS module". I agree we should be able to do that, but I don't understand how that relates to the linked example: jsdependencies needs scripts for every file anyway, because it needs to assign the loaded modules to global variables.

Oh, right. Yeah, I didn't realize that (for JSDependencies). So this is currently only theoretical.

Also see: #3488 (comment)

One thought I had today is that we currently fail to model the ability of being included as different type of module (i.e. inclusion autodetect or also just side effecting modules). Maybe we need a bitmap kind of thing insted.

A couple of thoughts about this:
Assumption: JSEnv input can only be loaded for its side-effects.
Therefore:

Order matters
Globals matter
Exports do not matter

Therefore, a JSEnv needs to know:

Loading order
Whether to evaluate in global scope.
Required syntax / keywords inside code.

Order is trivially addressed by providing inputs in a Seq. As for loading, it seems we have two possibilities:

Specify requirements (e.g. "NeedsGlobalScope", "NeedsExports", "NeedsES2015Export").
Specify supported inclusions (e.g. "SupportsScript", "SupportsCommonJS", "SupportsES2015").

The "supporting" case makes it possible for inputs to declare that they support being included in multiple ways based on auto-detection.
This would allow us to:

Have heterogeneous input (scripts and modules).
Avoid awkward inclusion of NonNativeJSTypeTestNatives.js.

So my current idea is having a bit-map like LoadModes type with values:

Script
CommonJSModule
ESModule

And:
final class Input(file: Path, allowedModes: LoadModes)

@sjrd WDYT?

TBH the specification you propose seems overkill to me.

I don't understand the need to give an input file that can be imported in several ways, only to let the JSEnv decide how to import it. Why not specify how to import it from the start? If the best way to import it depends on the JSEnv, that's a pretty special requirement that is best addressed in any given build. Actually I'm pretty sure most builds only run and test in one specific JSEnv; they don't test with different JSEnvs. Our build is rather special in that respect.
I don't understand what "requirements" are good for. What is a JSEnv going to be if the requirements are not met? Currently the underlying engine will throw a SyntaxError, which seems like an appropriate response to me. If a JSEnv should proactively detect unmet requirements, that's also quite difficult to implement, even impossible: how would NodeJSEnv detect whether ES2015 exports are supported? It would have to inspect the command-line arguments and the run-time version of Node.js, and it wouldn't even be able to future-proof itself for a future version of Node.js that supports them by default.

I thought all we really needed to do here is that instead of a homogeneous list, we need a heterogeneous list where each file is specified as either a script, CommonJS module or ES module (rather than all files being uniformly specified as scripts, CommonJS modules or ES modules).

That is a fair point. So we can settle for the much simpler:
object Input {
  final case class ScriptToLoad(script: Path) extends Input

  final case class ESModuleToLoad(module: Path)
      extends Input

  final case class CommonJSModuleToLoad(module: Path)
      extends Input
}

And take a List of these instead.
In that rename, shall we:

Remove ToLoad
Rename to actions (e.g. LoadScript, etc.)

Probably removing ToLoad is the best, i.e., just using Script/ESModule/CommonJSModule.


Add quotes of video games

Hi, I realized there is no addition of quotes when checked the committed file. Hence added one more PR with quotes and the source of the quotes.


Update Docker alias to allow AWS SSO + additional clarity

What changed?

Updated the alias in the documentation

Rationale

-e HOME was required in order to make AWS SDK figure out where the .aws/sso/cache folder lives
-e AWS_PROFILE was changed to pick up the current profile when running iambic as an alias
<local_dir\> was changed for clarity
-v ${HOME}/.aws:/app/.aws:ro was changed since write access to this directory should not be required

How was it tested?
If it was manually verified, list the instructions for your reviewers to follow.

[ ] Unit Tests
[ ] Functional Tests
[X] Manually Verified

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


filesystem.NewStorage and filesystem.NewStorageWithOptions broke compatibility

Specifically, this change https://github.com/src-d/go-git/commit/8f6b3127c1ff7661113fff2662416c328971a285#diff-8dd110426eb72706e38f9798b9a95230R37, which removed the error return from these functions, merged with https://github.com/src-d/go-git/pull/949.
This is a real problem, https://github.com/mitchellh/golicense depends on https://gopkg.in/src-d/go-license-detector.v2 which uses gopkg.in/src-d/go-git.v4 v4.1.0, which is before this breaking change was made. So a user cannot simultaneously use github.com/mitchellh/golicense and gopkg.in/src-d/go-git.v4 latest even though SemVer (and by extension, go modules) promises compatibility.
My recommendation would be to revert the signature to include the error, even though it will always be nil. That way we'll be able to tell users to update to latest and it will remain compatible with previous releases, except for 4.7.1-4.13.1.

For others experiencing this issue, for now it's possible to use
replace gopkg.in/src-d/go-git.v4 => gopkg.in/src-d/go-git.v4 v4.7.0

In your go.mod to work around this issue.


Project and namespace rename to use Google.Storage.V1

This will be consistent with other API code moving forward. More changes
to be as consistent as possible will be coming.

LGTM


chore: Improve the way a npm build script is found.

This commit will first install just the production-only dependencies. Then a script
will check the package.json for a build script.  If non is found, it just continues, but
if there is a build script, npm install will be called again to install the dev dependencies.
Then npm run build is execute.

This reason for doing this way was so we weren't installing all dependecies if we didn't need them

At first i thought we could use something like jq to inspect the package.json, but we would have to install that library. Then i realized we could just use node instead, since it is already installed
This should probably also go into the 10.x and 8.x branches
connects to #149

i would suggest doing the npm install --only=production after checking if build exists. Using the current code i am getting errors of missing dependencies when doing a production install.
if [ "$HAS_BUILD" == true ]; then
			# Do a npm install to get the dev depdencies
			echo "---> Installing dev dependencies"
			npm install
			#do not fail when there is no build script
			echo "---> Building in production mode"
			npm run build --if-present

			echo "---> Pruning the development dependencies"
			npm prune
else
                       		echo "---> Using 'npm install -s --only=production'"
                                npm install -s --only=production
fi

@uocxp if you still have a postinall script in your package.json to run your build script then this is probably why you are gettings errors during the production install.  Do you have a repo you can share so i can see if that is the case?
With this new code in this PR, you wouldn't need that postinstall script to run the build

{
  "name": "test-app",
  "version": "0.1.0",
  "description": "Intents Routing Communication with the NLU for Intents matching Is responsible for the module chain management and orchestration Fulfillment endpoint, acts as a relay to the fulfillment resolver component",
  "main": "dist/server/server.js",
  "types": "dist/server/server.d.ts",
  "private": true,
  "engines": {
    "node": "<9"
  },
  "scripts": {
    "docs:install": "gitbook install",
    "docs:serve": "gitbook serve",
    "docs:build": "gitbook build",
    "docs:pdf": "gitbook pdf",
    "prettier": "prettier --list-different '**/*.ts'",
    "precommit": "lint-staged",
    "lint": "tslint -c tslint.json -p tsconfig.json",
    "test": "jest",
    "test:ci": "jest --clearCache && jest --ci ",
    "tsc": "tsc",
    "watch-tsc": "tsc -w",
    "clean": "rimraf dist && rimraf logs",
    "watch-node": "nodemon ./dist/server/server.js",
    "start": "node ./dist/server/server.js",
    "build": "tsc",
    "postinstall": "npm run build",
    "debug": "concurrently -k -p \"[{name}]\" -n \"TypeScript,Node\" -c \"yellow.bold,green.bold\" \"npm run watch-tsc\" \"npm run watch-node\"",
    "deploy": "npm run build && rsync -rv --exclude '.git' --exclude 'node_modules' . root@demo.mswag.wor.net:/usr/local/bot-engine",
    "db:dump": "mongodump --db botengine -o demo-data",
    "db:load": "mongorestore demo-data",
    "db:clear": "mongo botengine --eval 'db.dropDatabase()'"
  },
  "husky": {
    "hooks": {
      "pre-commit": "npm run precommit",
      "pre-push": "npm run test"
    }
  },
  "lint-staged": {
    "linters": {
      "*.{ts,tsx}": [
        "npm run lint",
        "prettier --write",
        "git add"
      ]
    }
  },
  "repository": {
    "type": "git",
    "url": "xxxxxxxxxx"
  },
  "keywords": [
    "node"
  ],
  "author": "xxxxxxxx",
  "dependencies": {
    "axios": "^0.18.0",
    "body-parser": "^1.18.3",
    "compare-versions": "^3.4.0",
    "dialogflow": "^0.6.0",
    "express": "^4.16.3",
    "flat": "^4.1.0",
    "mongodb": "^3.1.6",
    "nodemailer": "^4.6.8",
    "rxjs": "^6.3.3",
    "uuid": "^3.3.2",
    "winston": "^3.1.0"
  },
  "devDependencies": {
    "@types/body-parser": "^1.17.0",
    "@types/compare-version": "^0.1.31",
    "@types/express": "^4.16.0",
    "@types/flat": "^0.0.28",
    "@types/jest": "^23.3.2",
    "@types/mongodb": "^3.1.9",
    "@types/mongodb-memory-server": "^1.8.0",
    "@types/moxios": "^0.4.8",
    "@types/node": "^10.11.0",
    "@types/nodemailer": "^4.6.5",
    "@types/nodemailer-stub-transport": "^1.1.4",
    "@types/supertest": "^2.0.6",
    "@types/uuid": "^3.4.4",
    "concurrently": "^4.0.1",
    "gitbook-cli": "^2.3.2",
    "husky": "^1.0.0",
    "jest": "^23.6.0",
    "lint-staged": "^7.3.0",
    "moxios": "^0.4.0",
    "nodemailer-stub-transport": "^1.1.0",
    "nodemon": "^1.18.4",
    "prettier": "^1.14.3",
    "rimraf": "^2.6.2",
    "supertest": "^3.3.0",
    "ts-jest": "^23.10.1",
    "tslint": "^5.11.0",
    "tslint-config-airbnb": "^5.11.0",
    "tslint-config-prettier": "^1.15.0",
    "typescript": "~3.0.3",
    "mongodb-memory-server": "^2.4.3"
  }
}

yes i have a postinstall script in order to install tsc. when i remove the postinstall script  i get  that tsc: command not found

@uocxp i've updated the script with your suggestion.  We don't need to be calling postinstall scripts more than once.
The other reason why it didn't work, is becuase by default the NODE_ENV is set to "production", and we only override that when specifically in "DEV_MODE", so i've added the NODE_ENV=development to the front of the npm install, so everything should work fine now.

@bparees so if someone creates a new node project using npm init , a scripts property is added to the package.json,  but it could be possible that someone doesn't have it.
Although, in our run phase, we are running "npm run start"(by default), So a scripts property would be required or it would fail, so i think we might be ok with not checking for the existence of a scripts prop.  I'll create an issue anyway though, #153
Thanks for the heads up on this

So i got like 4 notifications for this, but i don't see the comment on GH
On Sun, Oct 21, 2018 at 7:43 PM Ben Parees<EMAIL_ADDRESS>wrote:

@lholmquist https://github.com/lholmquist
fyi, this started breaking our tests in which we had an empty package.json
("{}"):
console.log(require('./package.json').scripts.build ? true : false)
^
TypeError: Cannot read property 'build' of undefined
at eval:1:46
at Script.runInThisContext (vm.js:96:20)
at Object.runInThisContext (vm.js:303:38)
at Object. (eval-wrapper:6:22)
at Module._compile (internal/modules/cjs/loader.js:688:30)
at evalScript (internal/bootstrap/node.js:582:27)
at startup (internal/bootstrap/node.js:267:9)
at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)
subprocess exited with status 1
subprocess exited with status 1
I don't know if that is considered a valid package.json or not, so up to
you whether to do something about it, but basically anyone w/ no "scripts"
entry is going to hit this i think.

if someone creates the package.json using "npm init", a script tag is
created, but i think this is something we should probably be  taking into
account,  someone not having a scripts tag.  Thanks for the heads up

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bucharest-gold/centos7-s2i-nodejs/pull/150#issuecomment-431714467,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_TUssoeodJIWmOaBjmTEpyabCP7YJTks5unQaggaJpZM4XkJgk
.


Add warning to burner.leapdao.org that the wallet is correctly under construction

Actually now that I'm thinking. Should we have staging.burner.leapdao.org and burner.leapdao.org lol :/

Like a rectangular bar on top of the screen? :)


[wip] substitute datastore path at job runtime based on hosting cloud

IBM Cloud is enabled as a possible platform where CI jobs can run.  At present, the datastore URL is hard coded in the storageclass.  The intent of this PR is to templatize the storageclass and allow the datastore path to be provided at job runtime.  Associated PR https://github.com/openshift/release/pull/21819

Closing as storage class is no longer in use.


Add visionOS as a platform alongside iOS, tvOS, watchOS, and the others

Add new enum constants for visionOS in all the places where it is appropriate.
This includes the platforms parameter in the manifest, whose purpose is to list the minimum deployment targets that a package requires. Since there is initially only visionOS 1.0, and because absence of a platform in the platforms parameter means that the default version is supported (not that the platform is unsupported), all packages implicitly support visionOS 1.0 whether or not they list it in the platforms parameter. But having the enum constant alongside those for the other Apple platforms makes everything consistent, and will become important for any future versions.
This change also makes the visionOS platform available for use in conditional target dependencies.
Motivation:
Xcode Beta 2, released earlier today, includes support for the new visionOS platform, and this change aligns SwiftPM with that.  Note that this does not mean you can develop visionOS apps with SwiftPM CLI — support is at the same level as for iOS, tvOS, etc, which is that the platform can be mentioned in the manifest, and that when using the experimental xcbuild build system, building libraries for visionOS will be supported at the same level as iOS, tvOS, etc provided that a suitable Xcode is installed.
Modifications:

add visionOS wherever iOS, tvOS, watchOS, etc are defined
add manifest source generation support
adjust PackageDescription.docc/Curation/SupportedPlatforms.md (courtesy of @zkiraly)
adjust unit tests

rdar://107064954

@swift-ci please smoke test


Updating<EMAIL_ADDRESS>breaks all tests

Please verify the version of auro-input you have installed
@latest
Please describe the bug

npm update<EMAIL_ADDRESS>run tests
see error stack

Reproducing the error on the docsite
This issue cannot be reproduced on the Auro docsite
Expected behavior
When updating to<EMAIL_ADDRESS>all tests pass.
What browsers are you seeing the problem on?
No response
Exit criteria
This issue can be closed once<EMAIL_ADDRESS>is updated and all tests pass successfully.

@jordanjones243 we're pretty sure you've already got a fix for this in your release branch, feel free to close after verifying


cmd/go: 'go get', 'go mod tidy' should update the vendor directory when present

This is basically the same issue as #29058, but the default behavior has changed, so it may be worth reopening the discussion.
Since 1.14, the go command may use the vendor directory by default (without the -mod=vendor flag) if the go version in go.mod is 1.14 or higher and vendor/modules.txt is present. The go command reports an error if go.mod and vendor/modules.txt are out of sync.
Two commands primarily change go.mod: go mod tidy and go get. When these commands make changes, they break vendor builds until go mod vendor is run again.
We've avoided rebuilding the vendor directory implicitly, since the go command currently deletes the entire folder, loads the import graph, and recreates it from scratch. That may cause developers to lose local changes (like a patch being prepared for a dependency).
I propose some new behavior:

We need a mechanism to detect local changes to vendor. That probably means comparing the contents of each package directory to the corresponding directory in the module cache. That would help us implement #27348.
go get would add or update packages in the vendor directory automatically if it's present. Only packages needed to build the packages named on the command line would be affected.
go mod tidy would implicitly rebuild the vendor directory. go mod vendor would be a no-op after go mod tidy.
Any command that modifies the vendor directory would report an error if local changes would be overwritten. We might want a flag to force overwrite, or the developer could run git checkout or rm -rf vendor first.
No change to go build and other commands. -mod=readonly and -mod=mod would continue to ignore the vendor directory.

cc @bcmills @FiloSottile @matloob

FWIW, I think the major behavior change that impacts this since #29058 is #42466.
My main concern was that, because go.mod dependency updates happened implicitly, we would implicitly update a vendored package and accidentally discard a local modification (for example, one important to an ongoing debugging session). However, since we now default to -mod=readonly, the set of commands that may trigger an accidental overwrite is now much smaller.

go get would add or update packages in the vendor directory automatically if it's present. Only packages needed to build the packages named on the command line would be affected.

I'm a bit worried about that behavior. In my experience, users often invoke go get on module roots rather than the specific packages they need, so automatically vendoring the packages named by go get could be both overly conservative (doesn't add other needed packages from the module) and overly aggressive (does add packages needed by the module root, even though the user doesn't actually care about the module's root package).

go mod vendor distinguishes well between mode readonly and mode vendor,  but I feel that the boundary between the two modes are becoming blurred. Should we reduce implicit changes for developers ？

@oiooj, go mod vendor itself does not have a -mod flag, and therefore does not distinguish between -mod=readonly and -mod=vendor. So I don't think I understand what you're getting at...

If user uses go mod vendor, it clearly runs in vendor mode. and the user needs to run this command regularly to ensure that the dependencies are synchronized.
But if it automatically updates vendor, it‘s not easy for users to notice the change, even the mode they used.

@oiooj To clarify, the -mod flag controls how packages are loaded and built in module mode. It accepts three values, mod (uses module cache and network; updates go.mod automatically), readonly (like mod but does not update go.mod), and vendor (uses vendor directory; does not use module cache or network; does not update go.mod).
If the go version in go.mod is 1.14 or higher, and the file vendor/modules.txt is present (not necessarily in sync with go.mod), then the go command defaults to -mod=vendor. Otherwise, it defaults to -mod=readonly.
-mod is not accepted by go mod subcommands including go mod vendor, nor is it accepted by go get. go mod vendor uses the module cache and network to build the vendor directory.
...
So the current user experience is that a developer runs go mod vendor, and then vendoring is enabled by default in their project. If they want to explicitly control whether vendoring is enabled, they can add -mod=readonly or -mod=vendor to  GOFLAGS.
If they change go.mod without running go mod vendor again, they'll see an error because vendor/modules.txt is out of sync. I don't see the benefit in having to run go mod vendor again; it's just an extra step.


added black and flake8 actions

Fixes #15

@rahulharlalka I am participating through BITSoC. Please review.


grpc client for a model with multiple outputs and input dims is -1

Hi All,
My model configuration looks like this.
name: "yolov3"
platform: "tensorflow_savedmodel"
max_batch_size: 128
input [
  {
    name: "input_1"
    data_type: TYPE_FP32
    dims: -1
    dims: -1
    dims: 3
  }
]
output [
  {
    name: "yolo_nms_0"
    data_type: TYPE_FP32
    dims: -1
    dims: 1
    dims: 4
   },
   {
    name: "yolo_nms_1"
    data_type: TYPE_FP32
    dims: -1
    dims: -1
   },
   {
     name: "yolo_nms_2"
     data_type: TYPE_FP32
     dims: -1
     dims: -1
   }
]
instance_group [
  {
    kind: KIND_GPU
    count: 1
	gpus: [0]
  }
]

I am trying to change the grpc_image_client.py to accommodate multiple outputs in this way. Is this correct ?
output_names = 'yolo_nms_0,yolo_nms_1,yolo_nms_2'
output_names = output_name.split(',')
    out_len = len(output_names)
    if out_len > 1:
        for i in range(out_len):
            output_message = api_pb2.InferRequestHeader.Output()
            output_message.name = output_names[i]
            request.meta_data.output.extend([output_message])
    else:
        output_message = api_pb2.InferRequestHeader.Output()
        output_message.name = output_name
        request.meta_data.output.extend([output_message])

Also i like to set the request dims because the dims in the config are -1. I have set this like request.meta_data.input.add(dims=[w,h,c]) .
Thank You,
Srijith

This issue is resolved. Closing.

hi @srijiths i got similar issue with you. my output dims is -1 and i can't server my yolo models.
how to solve this issue.
and can you share yolo source code to me?


OptionCommand tab complete

add some logic on how to tab complete an option command
Completed: tab completing anything starting with '-' without duplicates

Moved to https://github.com/Eluinhost/FlagCommand/issues/1 as code isn't in this repo anymore


Add ability to disable RelationManager list edit action

This just adds a very simple method to complement the canCreate, canDelete, and canDetach methods. The benefit of this is a very easy way to make the relation manager only allow attach and detach actions.

I made the same question earlier today on the filament discord server. What i have to do is this:
use Filament\Resources\RelationManager\ListRecords;
class ListMediaRecords extends ListRecords
{
    public function getRecordActions()
    {
        return [
        ];
    }
}

And in the RelationManager class override the $components static variable to tell filament that use my custom ListMediaRecords:
protected static $components = [
        'attach' => RelationManager\AttachRecord::class,
        'create' => CreateMediaRecord::class,
        'edit' => RelationManager\EditRecord::class,
        'list' => ListMediaRecords::class,
];

It works but seems to me a little bit of overkill if only need to remove the Edit action.

@monoman81 - Thanks for providing that input, I think this helps to show how this PR could be a simpler alternative to that method. This method will also make the control of edit abilities match the others as mentioned in my OP.

I agree with you. Regards.

Thank you!


Remove visibility of inaccessible objects

If a user does not have access to a repo/pipeline, it should not be visible in the dash for that user.

I don't think this is just a dash issue, it's an API-level change, and I think it's covered by #2434, right?  (that's where we've been tracking this feature in the context of other auth changes)

I think it's probably not even a dash level change at all, we don't want these objects to be accessible through the API or pachctl either.

Dupe of #2434


Add jan newsletter template and ospo news

Add Jan newsletter and Sloan foundation grant announcement for ospo!

LGTM @souravcipher ! I've also seen you replaced the revue links with the ghost ones, great work! 🙏


The submit() does not get called after the form validation completes

I was trying to run a form validation before submitting the form. However, when  complete all the form fields and click submit, the submit() function never gets called.
<Form
  ref="form"
  onSubmit={this.handleSubmit}
>
<TextValidator
  name="title"
  label="title"
  validators={['required', 'maxStringLength: 50']}
  errorMessages={['Title is required', 'Title should be less than 50 characters']}
  placeholder="What is this item?"
  type="text"
  value={this.state.title}
  onChangeText={this.handleTitleChange}
/>
<Button
  title="Submit"
  onPress={this.handleSubmit}
/>
</Form>

Here are the submit functions I have
handleSubmit = () => {
        console.log("Uploading Initiated")
        this.refs.form.submit();
}

submit = () => {
         console.log("Submitting")
}

The submit function never gets called for some reason.

Because you don't pass submit function :)
Should be
<Form
  ref="form"
  onSubmit={this.submit}
>

@NewOldMax  his syntax is actually right, in the official documentation handleSubmit is passed to the Form's onSubmit property. However, this did solve the issue.


⚠ Bofrost.de has degraded performance

In 712108c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1736 ms

Resolved: Bofrost.de performance has improved in 954dfa5 after 10 minutes.


Update <IP_ADDRESS>.yml

See merge request #5 for the template.

Testing might be necessary, as I changed my config an a bigger scale and can't merge my whole project with yours. I think the conditionals for ntp and chrony have to be checked, the rest should be fine.

Hi thorian93
I will see if I can validate it sometime this week.
Have you been using the whole role?  To what extent and how is it going?
Thanks for your contribution!!!
Best
Ben

Hi Ben, yes I downloaded the whole role and made changes primarily via the role variables. I am alos trying to push everything I change within the role upstream, so others can use my work too.
I am using the role to harden my CentOS boxes and so far it works really good. Only thing is the issue with sudo, as seen in #8. Apart from thats it's a great implementation as far as I can tell. Keep up the good work!


Add keydown listeners on individual items

We recently started using this package for our command palette. It works very nice, sot hanks for that.
We want a setup where we can "step through" an item which then brings up a new page. We use cmd+enter for that at the moment, where we have a global listener to see if the cmd button is pressed, and then we use that in onSelect to see if we should select an element or step through. However we would very much like to use tabs instead of cmd+enter, but we found no good way of doing this.
We could either add a global listener for tabs, but there is no way for us of knowing which page the highlighted item is pointing to, and the onKeyDown prop on the item did not get called on tabs.
Is there anyway you can add support for this, or is there already a good way to do this?

I believe that onKeyDown does not work because the focus remains on the input.
Maybe a way to be done would be like this? https://codesandbox.io/s/cmdk-playground-x6f91e?file=/src/App.tsx

Uhh, yeah that works! Guess I will have to go with that for now

@SorenHolstHansen Did you figure out how to do this? I don't see how the linked example helps here...

FWIW, I was looking into this to try and see if I could attach an event listener to the "selected" item in the menu changing. What I want to do is pre-fetch certain data when one of the items in the menu is highlighted.

Just chiming in to add that we're trying to build this too @pacocoursey! Any idea when it will be supported?
Love the package btw :)

Any updates on this @pacocoursey
That would be awesome :-)

Bumppp

This would be a really nice feature to have.

Any further updates on this? Would be a nice to have :)


Doc search update

Description
https://jira.mesosphere.com/browse/DCOS_SITE-211
Urgency

[ ] Blocker
[ ] High
[ ] Medium

Requirements

Test all commands and procedures.
Build content locally and test for formatting/links.
Add redirects to dcos-website/redirect-files.
Change all affected versions (e.g. 1.7, 1.8, and 1.9).
See the contribution guidelines.

@renesijnke @judithpatudith is there an updated fix? what's the status?

@joel-hamill @judithpatudith Created a new PR which updates the search to 1.8. Can you please verify this first with Maxime before merging? (tested it locally and it works fine, but just want to be sure nothing breaks)


Access violation writing 0x0000000000000000

@jxrossel commented on Wed Oct 04 2017
Description of your problem
When starting spyder, I get an error message with "Terminal server could not be located (...)" and something about starting spyder in debugging mode (which I don't know how to do).
What steps will reproduce the problem?

starting spyder

What is the expected output? What do you see instead?
error message and no terminal in the consoles
Please provide any additional information below
Versions and main components

Terminal Version: 0.2.2
Spyder Version: 3.2.3
Python Version:  python-3.6.2.amd64 (from WinPython, then I just updated spyder and spyder-terminal)
Operating system: Windows 7

pip list
adodbapi (<IP_ADDRESS>)
alabaster (0.7.10)
algopy (0.5.5)
altair (1.2.0)
altair-widgets (0.1.2)
argh (0.26.2)
asgi-redis (1.4.3)
asgiref (1.1.2)
astroid (1.5.3)
astroML (0.3)
attrs (17.2.0)
autobahn (17.9.3)
Automat (0.6.0)
Babel (2.4.0)
backports-abc (0.5)
backports.weakref (1.0rc1)
baresql (0.7.4)
bcolz (1.1.2)
beautifulsoup4 (4.6.0)
bkcharts (0.2)
blaze (0.10.1)
bleach (2.0.0)
blosc (1.5.1)
bloscpack (0.11.0)
bokeh (0.12.9)
boto3 (1.4.1)
botocore (1.4.36)
Bottleneck (1.2.1)
bqplot (0.9.0)
brewer2mpl (1.4.1)
Brotli (0.6.0)
certifi (2<IP_ADDRESS>)
cffi (1.10.0)
channels (1.1.8)
chardet (3.0.4)
circus (0.14.0)
click (6.7)
cloudpickle (0.3.1)
clrmagic (0.0.1a2)
colorama (0.3.9)
colorcet (0.9.1)
coloredlogs (7.3)
comtypes (1.1.3)
constantly (15.1.0)
CVXcanon (0.1.1)
cvxopt (1.1.9)
cvxpy (0.4.10)
cx-Freeze (5.0.2)
cycler (0.10.0)
cyordereddict (1.0.0)
Cython (0.26)
cytoolz (0.8.2)
daphne (1.3.0)
dask (0.15.1)
datashader (0.5.0)
datashape (0.5.2)
db.py (0.5.3)
decorator (4.1.2)
dill (<IP_ADDRESS>)
distributed (1.18.0)
Django (1.11.5)
django-debug-toolbar (1.7)
django-modeltranslation (0.12.1)
django-redis (4.8.0)
django-spaghetti-and-meatballs (0.2.2)
django-su (0.5.2)
docopt (0.6.2)
docrepr (0.1.0)
docutils (0.14)
ecos (2.0.4)
edward (1.3.3)
emcee (2.2.1)
entrypoints (0.2.3)
enum34 (1.1.6)
fast-histogram (0.2.1)
fastcache (1.0.2)
fasteners (0.14.1)
fastparquet (0.1.1)
feather-format (0.3.1)
Flask (0.12.2)
Flask-Cors (3.0.3)
formlayout (1.1.0)
fuzzywuzzy (0.15.0)
geopy (1.11.0)
gitdb2 (2.0.0)
GitPython (2.1.3)
gmpy2 (2.0.8)
greenlet (0.4.12)
guidata (1.7.6)
guiqwt (3.0.3)
h5py (2.7.0)
HeapDict (1.0.0)
holoviews (1.8.2)
html5lib (1.0b10)
humanfriendly (4.4.1)
husl (4.0.3)
hyperlink (17.3.1)
idna (2.5)
imageio (2.2.0)
imagesize (0.7.1)
incremental (17.5.0)
iowait (0.2)
ipykernel (4.6.1)
ipyleaflet (0.3.0)
ipympl (0.0.5)
ipyparallel (6.0.2)
ipython (6.1.0)
ipython-genutils (0.2.0)
ipython-sql (0.3.8)
ipywidgets (6.0.0)
isort (4.2.15)
itsdangerous (0.24)
jedi (0.10.2)
Jinja2 (2.9.6)
jmespath (0.9.3)
joblib (0.11)
jsonschema (2.6.0)
julia (0.1.2)
jupyter (1.0.0)
jupyter-client (5.1.0)
jupyter-console (5.1.0)
jupyter-core (4.3.0)
jupyter-sphinx (0.1.1)
jupyterlab (0.26.5)
jupyterlab-launcher (0.3.1)
Keras (2.0.6)
keras-vis (0.4.1)
Lasagne (0.2.dev1)
lazy-object-proxy (1.3.1)
livereload (2.5.1)
llvmlite (0.19.0)
lmfit (0.9.7)
locket (0.2.0)
lxml (3.8.0)
Markdown (2.6.8)
MarkupSafe (1.0)
matplotlib (2.0.2)
mccabe (0.6.1)
metakernel (0.20.4)
mistune (0.7.4)
mizani (0.3.2)
mkl-service (1.1.2)
monotonic (1.3)
moviepy (<IP_ADDRESS>)
mpl-scatter-density (0.2)
mpld3 (0.3)
mpldatacursor (0.6.2)
mpmath (0.19)
msgpack-python (0.4.8)
multipledispatch (0.4.9)
multiprocess (0.70.5)
mypy (0.521)
mysql-connector-python (2.0.4)
nbconvert (5.2.1)
nbconvert-reportlab (0.1)
nbdime (0.3.0)
nbformat (4.3.0)
netCDF4 (1.2.9)
networkx (1.11)
nltk (3.2.4)
notebook (5.1.0rc1)
numba (0.34.0)
numdifftools (0.9.20)
numexpr (2.6.2)
numpy (1.13.1+mkl)
numpydoc (0.7.0)
oct2py (4.0.6)
octave-kernel (0.26.2)
odo (0.5.0)
olefile (0.44)
palettable (3.0.0)
pandas (0.20.3)
pandas-datareader (0.5.0)
pandocfilters (1.4.2)
param (1.5.1)
partd (0.3.8)
pathtools (0.1.2)
patsy (0.4.1)
pdfrw (0.3)
pep8 (1.7.0)
pexpect (4.2.1)
pg8000 (1.10.5)
pickleshare (0.7.4)
Pillow (4.2.1)
pip (9.0.1)
pkginfo (1.4.1)
plotnine (0.2.1)
ply (3.10)
port-for (0.3.1)
prettytable (0.7.2)
prompt-toolkit (1.0.15)
protobuf (3.3.0)
psutil (5.2.2)
ptpython (0.41)
ptyprocess (0.5.2)
PuLP (1.6.8)
Pweave (0.30.0a1)
py (1.4.34)
pyarrow (0.5.0)
PyAudio (0.2.11)
pybars3 (0.9.3)
pybind11 (2.1.1)
pycodestyle (2.3.1)
pycparser (2.17)
pyflakes (1.6.0)
pyflux (0.4.15)
pygame (1.9.3)
Pygments (2.2.0)
pylint (1.7.2)
pymc (2.3.6)
pymc3 (3.1)
PyMeta3 (0.5.1)
pymongo (3.5.0)
pyodbc (4.0.17)
PyOpenGL (3.1.1)
pypandoc (1.3.2)
pyparsing (2.2.0)
PyQt5 (5.9)
pyqtgraph (0.10.0)
pyreadline (2.0)
pyserial (3.4)
pystache (0.5.4)
pytest (3.2.0)
python-dateutil (2.6.1)
python-hdf4 (0.9)
python-Levenshtein (0.12.0)
python-snappy (0.5.1)
pythonnet (2.4.0.dev0)
PythonQwt (0.5.5)
pytz (2017.2)
PyWavelets (0.5.2)
pywin32 (221)
pywinpty (0.2.1)
pywinusb (0.4.2)
PyYAML (3.12)
pyzmq (16.0.2)
QtAwesome (0.4.4)
qtconsole (4.3.0)
QtPy (1.3.0)
redis (2.10.6)
reportlab (3.4.0)
requests (2.18.3)
requests-file (1.4.2)
requests-ftp (0.3.1)
requests-toolbelt (0.8.0)
rope (0.10.5)
rpy2 (2.8.6)
Rx (1.5.9)
s3fs (0.1.2)
s3transfer (0.1.10)
scikit-fuzzy (0.3.dev0)
scikit-image (0.13.0)
scikit-learn (0.18.2)
scikit-neuralnetwork (0.7)
scikit-optimize (0.3)
scilab2py (0.6)
scipy (0.19.1)
scs (1.2.6)
seaborn (0.8.0)
setuptools (36.2.7)
simplegeneric (0.8.1)
simplejson (3.11.1)
sip (4.19.3)
six (1.10.0)
smmap2 (2.0.3)
snakeviz (0.4.1)
snowballstemmer (1.2.1)
sortedcontainers (1.5.7)
sounddevice (0.3.8)
Sphinx (1.6.3)
sphinx-autobuild (0.7.1)
sphinx-rtd-theme (0.2.4)
sphinxcontrib-websupport (1.0.1)
spyder (3.2.3)
spyder-notebook (0.2.0.dev0)
spyder-reports (0.1.1)
spyder-terminal (0.2.2)
SQLAlchemy (1.1.13)
sqlite-bro (0.8.11)
sqlparse (0.2.3)
statsmodels (0.8.0)
supersmoother (0.4)
sympy (1.1.1)
tables (3.4.2)
tblib (1.3.2)
tensorflow (1.2.1)
testpath (0.3.1)
Theano (0.9.0)
thriftpy (0.3.9)
toolz (0.8.2)
tornado (4.5.1)
tqdm (4.15.0)
traitlets (4.3.2)
traittypes (0.0.6)
tri.declarative (0.34.0)
tri.form (5.0.1)
tri.named-struct (0.12.0)
tri.query (4.0.0)
tri.struct (2.5.4)
tri.table (5.0.0)
twine (1.9.1)
Twisted (17.9.0)
twitter (1.17.1)
txaio (2.8.2)
typed-ast (1.0.4)
urllib3 (1.21.1)
vega (0.5.0)
ViTables (3.0.0)
watchdog (0.8.3)
wcwidth (0.1.7)
webencodings (0.5.1)
Werkzeug (0.12.2)
wheel (0.29.0)
whitenoise (3.3.1)
widgetsnbextension (2.0.0)
winpython (1.9.20170812)
wordcloud (1.3.2)
wrapt (1.10.10)
xarray (0.9.6)
xlrd (1.0.0)
XlsxWriter (0.9.8)
xlwings (0.11.4)
zarr (2.1.4)
zict (0.1.2)
zope.interface (4.4.3)

@andfoy commented on Wed Oct 04 2017
Hi @jxrossel, to start Spyder on debugging mode you must need to set the SPYDER_DEV variable, as it follows, the following commands must be executed from a system terminal, which corresponds to cmd.exe on Windows:
set SPYDER_DEV=True
spyder

After the execution, the file spyder_terminal_err.log must appear on your current working directory, which is this case must be the directory of the current terminal. Please post the contents of this file, so we can help you to trace the error.

@jxrossel commented on Thu Oct 05 2017
Hi, when starting spyder like that, I first had another error message "The Jupyter Notebook server failed to start..." and then the same message as above.  On this case, <IP_ADDRESS>:8071? Does a terminal appears there?
Also, I invite you to open an issue on spyder-notebook if you have notebook-related issues.

@jxrossel commented on Thu Oct 05 2017
Thanks for the answer, but pywinpty v0.2.1 is the last available version on pypi and its the one I have, so I can't update it...
I've stopped doing blind upgrades (with -U) since it tends to break installations (typically when upgrading a package which depends on the upgrade of another compiled package whose compilation fails...). Usually, I do a 2-step upgrade (with -U --no-deps first, then a simple install)

@jxrossel commented on Thu Oct 05 2017
... and I've checked the <IP_ADDRESS>:8071 in my browser after opening Spyder. Nothing is shown on that page, but the tab title "OS Web terminal" is displayed (better than nothing, I guess!)

@andfoy commented on Thu Oct 05 2017
@jxrossel Is there any message on the developer Web console?

@jxrossel commented on Thu Oct 05 2017
SCRIPT445: Object doesn't support this action
File: main.js, Line: 11, Column: 1
var promptEvent = new Event('promptReady');

@andfoy commented on Thu Oct 05 2017
@jxrossel Can you test if pywinpty is working as expected? Please post the output of the following commands (From a Python prompt):
from winpty import PTY

# Start a new winpty-agent process of size (cols, rows)
cols, rows = 80, 25
process = PTY(cols, rows)

# Spawn a new console process, e.g., CMD
process.spawn(r'C:\windows\system32\cmd.exe')

# Read console output (Unicode)
process.read()

@jxrossel commented on Thu Oct 05 2017
process.spawn(r'C:\windows\system32\cmd.exe') --> True
process.read()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\PortableSoftware\WinPython3-6\python-3.6.2.amd64\lib\site-packages\winpty\winpty_wrapper.py", line 55, in read
    None, None)
OSError: exception: access violation writing 0x0000000000000000

@andfoy commented on Thu Oct 05 2017
@jxrossel Finally an error! Let me check, it seems that this belongs to pywinpty rather than spyder-terminal. However, let me investigate more about it, this is the first instance of such issue.

It seems that this pointer initialization may cause memory access violation issues: https://github.com/spyder-ide/pywinpty/blob/3cae51548ecb5b205395786eeb87a339d9618315/winpty/winpty_wrapper.py#L48

Actually, it seems that Windows API functions should be declared explicitly: https://github.com/asweigart/pyperclip/issues/25#issuecomment-269271886

Still doesn't work:
File "C:\PortableSoftware\WinPython3-6\python-3.6.2.amd64\lib\site-packages\winpty\winpty_wrapper.py", line 63, in read
   ReadFile(self.conout_pipe, data, length, None, None)

OSError: exception: access violation writing 0x0000000000000000

... and another error appeared in spyder after trying to open/close a terminal:
File "C:\PortableSoftware\WinPython3-6\python-3.6.2.amd64\lib\site-packages\spyder_terminal\terminalplugin.py", line 317, in <lambda>
  term.terminal_closed.connect(lambda: self.close_term(term=term))
File "C:\PortableSoftware\WinPython3-6\python-3.6.2.amd64\lib\site-packages\spyder_terminal\terminalplugin.py", line 330, in close_term
  term.close()
AttributeError: 'NoneType' object has no attribute 'close'
Traceback (most recent call last):
File "C:\PortableSoftware\WinPython3-6\python-3.6.2.amd64\lib\site-packages\spyder_terminal\terminalplugin.py", line 317, in <lambda>
  term.terminal_closed.connect(lambda: self.close_term(term=term))
File "C:\PortableSoftware\WinPython3-6\python-3.6.2.amd64\lib\site-packages\spyder_terminal\terminalplugin.py", line 330, in close_term
  term.close()
AttributeError: 'NoneType' object has no attribute 'close'

I think this is an issue related to your distribution header files, I don't know what else to do on your case.

You mean it doesn't / won't work with WinPython as distribution ?

@stonebig, we have a problem here, have you had more problems with Access Violation Errors?

@jxrossel, I've just asked to the current mantainer of WinPython if he can give us some help.

I didn't notice, but also I'm not on Windows7

Following Pyperclip issue https://github.com/asweigart/pyperclip/issues/25 landed on this one. My issue seems to be related to the Windows 10 clipboard
In my case I am using Passpie to copy a password to the clipboard.
Traceback (most recent call last):
  File "m:\miniconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "m:\miniconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "M:\Miniconda3\Scripts\passpie.exe\__main__.py", line 9, in <module>
  File "m:\miniconda3\lib\site-packages\click\core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "m:\miniconda3\lib\site-packages\click\core.py", line 696, in main
    rv = self.invoke(ctx)
  File "m:\miniconda3\lib\site-packages\click\core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "m:\miniconda3\lib\site-packages\click\core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "m:\miniconda3\lib\site-packages\click\core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "m:\miniconda3\lib\site-packages\passpie\cli.py", line 46, in wrapper
    return func(*args, **kwargs)
  File "m:\miniconda3\lib\site-packages\click\decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args[1:], **kwargs)
  File "m:\miniconda3\lib\site-packages\click\core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "m:\miniconda3\lib\site-packages\passpie\cli.py", line 275, in copy
    clipboard.copy(decrypted, clear)
  File "m:\miniconda3\lib\site-packages\passpie\clipboard.py", line 99, in copy
    _copy_windows(text, clear)
  File "m:\miniconda3\lib\site-packages\passpie\clipboard.py", line 55, in _copy_windows
    ctypes.cdll.msvcrt.wcscpy(ctypes.c_wchar_p(pchData), text)
OSError: exception: access violation writing 0x0000000000000000

I am not using WinPython, but rather Anaconda (Miniconda) on Windows 10. Python version 3.6.2 64 bit.
Any clues as to why the OSError: occurs while trying to use the clipboard?

According to this SO answer, this an error ocurring on some 64-bit Python Windows binaries. I'm closing this issue since I don't know how to address this. All our ctypes calls have been tested and have been found to be functional.

Why not try using http://repo.msys2.org/msys/x86_64/winpty-0.4.3-1-x86_64.pkg.tar.xz which is compiled with mingw-w64 like winpty is supposed to be compiled? What are you even using this stuff for though? Why not just spawn a thread with an event loop to communicate with Python?

Ray, two things:

winpty can be compiled with visual studio and mingw.
We're not trying to communicate with Python. Instead, we want to have a pseudo terminal to be able to embed cmd or PowerShell in an application.

winpty cannot be compiled with Visual Studio, please read the upstream https://github.com/rprichard/winpty
I believe someone added support for using Visual Studio but the runtime is then not the expected one (VC6 runtime) and you get this error. Whether this can be fixed or not (outside of compiling it with the compilers that the author supports => which are present in the msys2 channel in the Anaconda Distribution anyway) I do not know.
Regardless of that, can you (or someone with this problem) try my suggestion?

Regardless of that, can you (or someone with this problem) try my suggestion?

We would need to start using the mingw toolchain to compile winpty and also pywinpty. That's easy for conda packages but how can we generate wheels with that?

I don't know anything about how wheels are generated, sorry. @jjhelmus has been looking into winpty for AD recently, maybe he knows?

There are conda packages winpty compiled using mingw-w64 available in the defaults channel as well as pywinpty packages built using VS 2008 for Python 2.7 and VS 2015 for Python 3.5 and 3.6.
Even using mingw-w64 to build winpty I can replicate this issue so I do not believe problem is in the toolchain used.
Wheels could be produced in the same manner as the conda packages.  Use mingw-64 to compile winpty.dll, winpty-agent.exe, and winpty-debugserver.exe and then use VS 2008, VS 2010, VS 2015 to created the wheel.

@jjhelmus, were you also using Windows 7 when you replicated this issue?

FWIW I just tried again today on Windows 10 with the latest Miniconda for Python 3.6 and wasn't able to replicate the issue.

Yes, I replicated this on Windows 7.

@SimonBiggs, @dalito, are you also using Windows 7?

Yes.

System details were previews within the following issue:
https://github.com/jupyterlab/jupyterlab/issues/3647

Then terminals should be deactivated on Win 7 in JupyterLab, notebook and spyder-terminal. I mean, I don't see any other choice until someone finds a solution for this.
@blink1073, what do you think?

Yeah, it looks like Windows 7 is the common thread.  I don't have access to Windows 7 for testing.  We could use sys.getwindowsversion().major in the spyder-terminal and the notebook repo, which would also disable JupyterLab.

Alternatively, we could raise an ImportError in this library based on that condition, which would require no changes to notebook.

Good idea! It's better to do it here to avoid other applications use pywinpty on Win 7, since it's known to generate this ugly error.
Could you take care of that @blink1073?

Yep, coming right up!

Nice! Thanks a lot!

Can someone with Windows 7 please test the following?
from winpty import PTY
p = PTY(80,25)
p.spawn('C:\\windows\\system32\\cmd.exe')
p.close()
del p

I don't seem to be seeing this issue myself on Win7
Python 3.6.4 |Anaconda, Inc.| (default, Jan 16 2018, 10:22:32) [MSC v.1900 64 bit (AMD64)]
Type "copyright", "credits" or "license" for more information.

IPython 6.2.1 -- An enhanced Interactive Python.

In [1]: import winpty

In [2]: winpty.__version__
Out[2]: '0.5'

In [3]: from winpty import PTY
   ...: p = PTY(80,25)
   ...: p.spawn('C:\\windows\\system32\\cmd.exe')
   ...: p.close()
   ...: del p

In [3]:

In [4]: from winpty import PTY
   ...:
   ...: # Start a new winpty-agent process of size (cols, rows)
   ...: cols, rows = 80, 25
   ...: process = PTY(cols, rows)
   ...:
   ...: # Spawn a new console process, e.g., CMD
   ...: process.spawn(r'C:\windows\system32\cmd.exe')
   ...:
   ...: # Read console output (Unicode)
   ...: process.read()
   ...:
Out[4]: b''

λ [environment]::OSVersion.Version

Major  Minor  Build  Revision
-----  -----  -----  --------
6      1      7601   65536

@dhirschfeld, does the high level code work for you on Win 7 as well?
from winpty import PtyProcess

proc = PtyProcess.spawn('python')
proc.write('print("hello, world!")\r\n')
proc.write('exit()\r\n')
while proc.isalive():
	print(proc.readline())

On the first attempt I got an OSError:
>>> proc = PtyProcess.spawn('python')
OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted

I tried again and got the access violation:
>>> proc = PtyProcess.spawn('python')
Exception in thread Thread-2:
Traceback (most recent call last):
  File "C:\Miniconda3\lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "C:\Miniconda3\lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Miniconda3\lib\site-packages\winpty\ptyprocess.py", line 331, in _read_in_thread
    data = pty.read(4096)
  File "C:\Miniconda3\lib\site-packages\winpty\winpty_wrapper.py", line 73, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x0000000000000000

@blink1073 Do we have any idea of why the low-level API is working but not the high-level? Is very counterintuitive, as the reading access is done on the low-level side. But the example given by @dhirschfeld shows that the low level access is working as expected.
Sidenote: BTW, the 32-bit wheels up to the 4.2.0 release were compiled on Windows 7 without any problems.

@dhirschfeld After trying the high-level access, does the low-level API works for you?

Yep, seems to.
Output from Python session:
>>> from winpty import PTY
>>> p = PTY(80,25)
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> p.close()
>>> del p
>>>
>>> from winpty import PtyProcess
>>> proc = PtyProcess.spawn('python')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Miniconda3\lib\site-packages\winpty\ptyprocess.py", line 114, in spawn
    inst = cls(proc)
  File "C:\Miniconda3\lib\site-packages\winpty\ptyprocess.py", line 49, in __init__
    self._server.bind(address)
OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted
>>>
>>>
>>> proc = PtyProcess.spawn('python')
Exception in thread Thread-2:
Traceback (most recent call last):
  File "C:\Miniconda3\lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "C:\Miniconda3\lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Miniconda3\lib\site-packages\winpty\ptyprocess.py", line 331, in _read_in_thread
    data = pty.read(4096)
  File "C:\Miniconda3\lib\site-packages\winpty\winpty_wrapper.py", line 73, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x0000000000000000

>>>
>>>
>>> p = PTY(80,25)
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> p.close()
>>> del p

Ah, my mistake. The low level code I posted doesn't attempt to read. It should be:
from winpty import PTY
p = PTY(80,25)
p.spawn('C:\\windows\\system32\\cmd.exe')
p.read()
p.close()

del p

Ah, my mistake. The low level code I posted doesn't attempt to read. It should be:
from winpty import PTY
p = PTY(80,25)
p.spawn('C:\\windows\\system32\\cmd.exe')
p.read()
p.close()
del p

Here are the result in a Windows 7 VM using the packages from conda-forge
Python 3.6.4 | packaged by conda-forge | (default, Dec 24 2017, 10:11:43) [MSC v
.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from winpty import PTY
>>> p = PTY(80,25)
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> p.read()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\builder\Anaconda3\envs\test_winpty\lib\site-packages\winpty\win
pty_wrapper.py", line 73, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x0000000000000000

Python 3.6.4 | packaged by conda-forge | (default, Dec 24 2017, 10:11:43) [MSC v
.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from winpty import PtyProcess
>>> proc = PtyProcess.spawn('python')
>>> Exception in thread Thread-1:
Traceback (most recent call last):
  File "C:\Users\builder\Anaconda3\envs\test_winpty\lib\threading.py", line 916,
 in _bootstrap_inner
    self.run()
  File "C:\Users\builder\Anaconda3\envs\test_winpty\lib\threading.py", line 864,
 in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\builder\Anaconda3\envs\test_winpty\lib\site-packages\winpty\pty
process.py", line 331, in _read_in_thread
    data = pty.read(4096)
  File "C:\Users\builder\Anaconda3\envs\test_winpty\lib\site-packages\winpty\win
pty_wrapper.py", line 73, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x0000000000000000

Python 3.6.4 (v3.6.4:d48eceb, Dec 19 2017, 06:54:40) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import winpty
>>> winpty.__version__
'0.5.1'
>>> from winpty import PTY
>>> p = PTY(80,25)
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> p.read()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "c:\dev_src\_pyve\stable_py36\lib\site-packages\winpty\winpty_wrapper.py", line 73, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x0000000000000000
>>> p.close()
>>> del p

And how about this?  We'd raise an import error if not valid:
from winpty import PTY
p = PTY(80,25)
valid = False
p.spawn('C:\\windows\\system32\\cmd.exe')
try:
    p.read()
    valid = True
except OSError:
    pass
p.close()
del p
print('valid?', valid)

>>> from winpty import PTY
>>> p = PTY(80,25)
>>> valid = False
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> try:
...     p.read()
...     valid = True
... except OSError:
...     pass
... p.close()
  File "<stdin>", line 6
    p.close()
    ^
SyntaxError: invalid syntax
>>> del p
>>> print('valid?', valid)
valid? False

Calling p.read() does give the access violation:
>>> from winpty import PTY
>>> p = PTY(80,25)
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> p.read()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Miniconda3\lib\site-packages\winpty\winpty_wrapper.py", line 73, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x0000000000000000
>>> p.read()
b''
>>> p.close()
>>> del p

The latter test results in valid=False for me:
>>> from winpty import PTY
>>> p = PTY(80,25)
>>> valid = False
>>> p.spawn('C:\\windows\\system32\\cmd.exe')
True
>>> try:
...     p.read()
...     valid = True
... except OSError:
...     pass
...
>>> p.close()
>>> del p
>>> print('valid?', valid)
valid? False

I can't even import winpty on Windows7 with python 3.5.4
C:\Users\nurp\jupy>python
Python 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:07:06) [MSC v.1900 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from winpty import PTY
Exception in thread Thread-1:
Traceback (most recent call last):
  File "C:\Python\Python35-32\lib\threading.py", line 914, in _bootstrap_inner
    self.run()
  File "C:\Python\Python35-32\lib\threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Python\Python35-32\lib\site-packages\winpty\ptyprocess.py", line 331, in _read_in_thread
    data = pty.read(4096, blocking=True)
  File "C:\Python\Python35-32\lib\site-packages\winpty\winpty_wrapper.py", line 74, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x00000000

..........
same message replicated for 10 threads
C:\Users\nurp\jupy>python
Python 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:07:06) [MSC v.1900 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from winpty import PTY
Exception in thread Thread-1:
Traceback (most recent call last):
  File "C:\Python\Python35-32\lib\threading.py", line 914, in _bootstrap_inner
    self.run()
  File "C:\Python\Python35-32\lib\threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Python\Python35-32\lib\site-packages\winpty\ptyprocess.py", line 331, in _read_in_thread
    data = pty.read(4096, blocking=True)
  File "C:\Python\Python35-32\lib\site-packages\winpty\winpty_wrapper.py", line 74, in read
    ReadFile(self.conout_pipe, data, length, None, None)
OSError: exception: access violation writing 0x00000000

@nurp We've just merged a definitive solution for this issue on https://github.com/spyder-ide/pywinpty/issues/108 and we expect to release a hotfix release today. After the release, you just need to update your packages, so stay tuned for the update.


New plugin: Confluence

Platform or tool
Confluence
Relevant links
https://developer.atlassian.com/server/confluence/confluence-server-rest-api/
Goal or desired behavior
Authenticate the CLI using personal access token
Contribution

[X] I'd be up for building the plugin myself.

Additional information
No response

@AndyTitu @volodymyrZotov @arunsathiya Please assign this issue to me


Use .cmd as default executable on Windows [AUTOZIP]

Download:
Environment: QT=5.12, ARCH=32, CONFIGURATION=release, QTIFW=C:\Qt\Tools\QtInstallerFramework\3.1
trik-studio-master-i686-auto.zip


Adding code guidelines for tasks and metatasks

Thanks @sudhirappaji hopefully all the typos are addressed now. With respect to the repeated definitions I think keeping them in a single place might make the document harder to read. Also the strings are not exactly the same k8s vs K8s, small difference but still they are different for package and classes.  This format also allows one to read, copy and refer to the class name or package name convention independently of each other.

@arvindn05  I believe I have addressed all the things we discussed. Let me know if you have any additional comments or if I can merge.


[feature request] Ignore file pattern

It would be great to have file pattern ignore option, what do you think about it?

Yes, I'm thinking the same thing, plan to add add a key named ignore_files, and allows a list of regexp, how do you think?

@Unknwon it would be great!

@exu code has been pushed, please help test!

@Unknwon working, thanks alot :D

No problem! :beer:


There should be an option to automatically co-whitelist peer-dependencies of a whitelisted module

I'm building an application with Electron where all the node_modules are shipped alongside the application, rather than packed with Webpack.
One module is a private package that needs to get bundled, as it shouldn't get shipped in unpacked format. So I tried adding it to the whitelist and it beautifully gets packed into the distributable.
None of its peer-dependencies get packed though, unless I manually add them all to the whitelist.
Ideally there should be an option that enables scanning of whitelisted modules for peer-dependencies to add them to the whitelist as well.

This problem has been raised multiple times and has never been addressed as far asI can see. See e.g. here and here. Just now I wanted to include axios into the bundle for an AWS Lambda function, and I was forced to manually look up the trail of dependencies. In this case it was:
axios => follow-redirects => debug => ms
OK, it was only four single steps this time, but it could easily have branched out into a dependency tree that one would have to manually figure out. The community would greatly appreciate if inclusion of sub-dependencies could be done automatically.

Assuming the dependency tree is proper. Also what if someone decides to add resolutions to their project? Maybe add a utility that can do that whitelisting for specific packages?

I am a collaborator on razzle, I found out that instead of using allowlist it is better to solve this by using resolve and some logic to decide what to bundle as next.js does. This module is a bit too brittle since it tries to do it in the reverse and pre-resolve what to allow.

@MagnusBrzenk @fivethreeo Thank you for your suggestions and interest. If I understand correctly - the request is that all modules in the allowlist will have their own dependencies bundled as well. Am I correct?
I will take a look on how to solve it. In any case - PRs are welcome!
Thanks again.

@liady
Better to let webpack handle the dependencies
https://github.com/jaredpalmer/razzle/pull/1370/files#diff-b95764a7288c7b8e9f3715219636a1caR299
https://github.com/jaredpalmer/razzle/pull/1370/files#diff-0039aa986c882d14539e6883d06e955d

@florisporro @MagnusBrzenk I'm running into a similar problem that you guys mentioned and I seem to be able to get it working with the config below, can you guys try it out and let me know if it helps?
externals: [
    nodeExternals(), // exclude node_modules in current path
    nodeExternals({
      modulesDir: resolve(__dirname, '../node_modules'), // exclude node_modules in root (monorepo managed by lerna)
      allowlist: [/^@whitelistedModule\/*/], // whitelist private package
      modulesFromFile: {
        fileName: /* path to whitelisted module package.json to read from */,
        includeInBundle: ['dependencies', 'peerDependencies'],
      }
    }),
  ],

I built a small helper that includes all subdependencies for any packages:
https://github.com/kmjennison/datwd
// webpack.config.js
const nodeExternals = require('webpack-node-externals')
const includeSubdependencies = require('datwd')

module.exports = {
  // ...
  externals: [
    nodeExternals({
      // Will include "cookies" and its dependencies; for example:
      // `['cookies', 'depd', 'keygrip', 'tsscmp']`
      allowlist: includeSubdependencies(['cookies'])
    })
  ]
}

Hope this helps others. Feedback welcome!


408 http code generated by mod_reqtimeout is not detected

Describe the bug
408 http code is not detected
Logs and dumps

SecDebugLog level 9:
empty

If you change rule from "@streq 408" to "@streq 200" (for TEST PURPOSES ONLY), it blocks correctly and fill the SecDebugLog(SecDebugLog = 9) with informations. If you leave "@streq 408", debug log is empty and not blocking.

If you change rule detection "408" to "200", it is working (blocking). So, there is any problem with http code 408. Not with the rule itself.
Expected behavior
Detect 408 http code correctly and block attacker
Server (please complete the following information):
Ubuntu 20 TLS (Ubuntu 16 and 18 same problem)
Apache/2.4.58 (Ubuntu) + mod_reqtimeout (lower Apache 2.4.x versions same problem)
libapache2-mod-security2 2.9.3-1ubuntu0.1 (2.9.2 and 2.9.0 same problem)
Rule Set (please complete the following information):
SecRule RESPONSE_STATUS "@streq 408" "id:20,phase:5,t:none,nolog,pass,setvar:ip.slow_dos_counter=+1,expirevar:ip.slow_dos_counter=60,ctl:ruleEngine=On"
SecRule IP:SLOW_DOS_COUNTER "@gt 5" "id:21,phase:1,t:none,log,deny,status:403,msg:'SlowlorisAttack',ctl:ruleEngine=On"

Additional context

Hello @ShaiMagal ,
To clarify: the 408 is being generated by that other mod, right (i.e. mod_reqtimeout)?
In that case, when you write the expectation 'Detect 408 http code correctly and block attacker', it's that other mod that is blocking that transaction, isn't it?
In which case, the actual problem is just ModSecurity's non-receipt of the actual response code (408), right?

Hello @ShaiMagal ,
To clarify: the 408 is being generated by that other mod, right (i.e. mod_reqtimeout)?
In that case, when you write the expectation 'Detect 408 http code correctly and block attacker', it's that other mod that is blocking that transaction, isn't it?
In which case, the actual problem is just ModSecurity's non-receipt of the actual response code (408), right?
Hi @martinhsv

I don't know what is it generating, but I think, it's apache itself, but maybe its via this module, don't know (I don't know source code of Apache/mod_requtimeout). mod_reqtimeout is classic mod for mitigation slowloris and in past mod_security can handle this 408 for block attacker. Without this mod_security can't be used for mitigation slowloris (of course, there are other ways).

mod_security should block attacker. If I change rule "@streq 408" -> "@streq 200", it block "attacker" without problems. So, blocking is working well, but not with 408 http code.

So, it's looks like, everything is working well with http code 200 (for testing purposes rule working well), but after 408 not working (not detecting). Maybe any incompatibility with this module, don't know, but mod_reqtimeout is native apache module and this sucessfully log do apache log 408... I don't know, why mod_security can't handle this :/

The only real question I see here is why ModSecurity is not successfully informed by Apache about the 408 response codes. A potential resolution of this might require an adjustment to how ModSecurity is plugged into Apache ... or it might require a change to mod_reqtimeout or to Apache itself.
Yes, it is the main problem. 408 response code working, other codes working... So not problem at rule, only with connection 408 + modsec + apache + reqtimeout..

So, what next? :)

When a standard slowloris attack (very slow, incremental sending of request headers) is halted by mod_reqtimeout, I don't see a good way to have ModSecurity automatically report on this.
The problem is that ModSecurity never sees the request at all. Note, for example, that the ModSecurity debug log (at level 9) is empty in these cases.
I might have thought that using an Apache ErrorDocument directive might be a way to detect the inital 408 and redirect to a custom408errorpage.html that ModSecurity could detect. But an initial trial of that workaround was not successful. You could consider experimenting with something along those lines, if you were so inclined.
There are a couple of other options that you could consider but neither are great:

With mod_reqtimeout running on the main server, move ModSecurity to a reverse proxy in front of the web server
Use the reqtimeout messages that go to apache's error.log. You could even extract these and include the information in the ModSecurity audit log if you really need to (perhaps via lua script or other mechanism). This would be somewhat clunky and may suffer from timing issues.

It's not clear to me that that Nov. 2016 issue indicates that the interoperability worked as you expect at that time. That is not explicitly stated.
In any case, I tried ModSecurity v2.9.1 (which was the most recent version of ModSecurity in Nov. 2016) and saw no difference. If you believe some change in the ModSecurity engine has resulted in a change of behaviour, you're certainly free to build older versions and experiment yourself.

@martinhsv I don't know where is the problem, I already waste a few days of testing. I tried more versions of modsec and apache, not working. I don't know why..
So, where is the problem? Where should by issue open?

Any recommendation? I think protection is priority for modsecurity and make it working with 408 http code will be awesome.

@ShaiMagal ,
I did provide two possible suggestions here: https://github.com/SpiderLabs/ModSecurity/issues/3007#issuecomment-1810722958 .
Beyond that, any further time to be spent on this item will be prioritized against other open issues.

@martinhsv I read this. So,it isn't important for modsecurity to make partial protection against slowloris attack? I didn't say "now", but in few months? or one year? But OK, I will try to handle it
Because you wrote "When a standard slowloris attack (very slow, incremental sending of request headers) is halted by mod_reqtimeout, I don't see a good way to have ModSecurity automatically report on this.", yes, but this only make 408 and we need to block this IP, because we don't want to allow them to continue their requests.
But I might have thought that using an Apache ErrorDocument directive might be a way to detect the inital 408 and redirect to a custom408errorpage.html that ModSecurity could detect. - can you explain me it little more with any "fast example"? If there is any "simple" solution, I will happy for it.
Because you wrote 2 options and first one (reverse proxy) is not possible because incompatibility with other features and second one is unfamiliar for me (lua script) :/
Thank you.

Btw, here is pointed to same feature for modescurity like I wrote and should be working:
https://www.trustwave.com/en-us/resources/blogs/spiderlabs-blog/updated-modsecurity-advanced-topic-of-the-week-mitigating-slow-http-dos-attacks/

I have exactly the same issue, I am able to see in my apache log 408s after running the slowhttptest tool with mod_reqtimeout configured:
XXX.181.203.XXX - - [25/Sep/2024:16:49:27 -0600] "GET / HTTP/1.1" 408 221
XXX.181.203.XXX - - [25/Sep/2024:16:49:27 -0600] "GET / HTTP/1.1" 408 221
XXX.181.203.XXX - - [25/Sep/2024:16:49:27 -0600] "GET / HTTP/1.1" 408 221
XXX.181.203.XXX - - [25/Sep/2024:16:49:27 -0600] "GET / HTTP/1.1" 408 221
XXX.181.203.XXX - - [25/Sep/2024:16:49:28 -0600] "GET / HTTP/1.1" 408 221

Server Version: Apache/2.4.62 () OpenSSL/1.0.2k-fips
Server MPM: event
ModSecurity for Apache/2.9.7
Amazon Linux 2
However, the modsec_debug.log doesn't see these 408 requests, it does see the 200 responses though:
[25/Sep/2024:14:18:10.635291 --0600] [XXX.com/sid#5591118bf990][rid#7f762003d1a8][/index.php][4] Executing operator "streq" with param "408" against RESPONSE_STATUS.
[25/Sep/2024:14:18:10.635294 --0600] [XXX.com/sid#5591118bf990][rid#7f762003d1a8][/index.php][9] Target value: "200"
I do see that the article referenced suggests using SecConnReadStateLimit to limit max connections, but this is like punishing every IP, hopefully this can be fixed to use mod_security's lovely mechanism of temporary block, log and release.
Thanks.
P.S. I'm just going to go ahead and while this is fixed use IPTABLES xxx --connlimit-above 30 -j DROP
People still work at offices and share the same IP to my platform.


Adding a legacy Required properties resource mix models

Putting in a separate namespace avoid name conflict.
#131

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-azure-resource-manager

Show changes

This PR is ON HOLD until the discussion of @visibility design issues..


In Maui android inside carousel , Button is there, after tapping Button, it is crashing & showing unhandled exception

In Maui android inside carousel , Button is there, after tapping Button, it is crashing & showing unhandled exception

@Arviksain Can you provide a demo project to reproduce this issue?

Android.Runtime.RuntimeNativeMethods.monodroid_debugger_unhandled_exception (Android.Runtime.RuntimeNativeMethods.monodroid_debugger_unhandled_exception:-1)
Android.Runtime.JNINativeWrapper._unhandled_exception (JNINativeWrapper.g.cs:12)
Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPLI_L (JNINativeWrapper.g.cs:221)
Java.Interop.JniPeerMembers.AssertSelf (sources/xamarin/java.interop/3c5cf34b0e3cc9427521530db9aa4b4abe39d20d/src/Java.Interop/Java.Interop/JniPeerMembers.cs:153)
Java.Interop.JniPeerMembers.JniInstanceMethods.InvokeVirtualVoidMethod (sources/xamarin/java.interop/3c5cf34b0e3cc9427521530db9aa4b4abe39d20d/src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.cs:57)
Android.Views.ViewGroup.RemoveAllViews (sources/xamarin/xamarin-android/0d97e20b84d8e87c3502469ee395805907905fe3/src/Mono.Android/obj/Release/net8.0/android-34/mcw/Android.Views.ViewGroup.cs:4164)
Microsoft.Maui.Handlers.ContentViewHandler.DisconnectHandler (sources/dotnet/maui/44a1673f7d2da631396ec9820e1d5cf3c29c9b1a/src/Core/src/Handlers/ContentView/ContentViewHandler.Android.cs:54)
Microsoft.Maui.Handlers.ViewHandler<Microsoft.Maui.IContentView,Microsoft.Maui.Platform.ContentViewGroup>.OnDisconnectHandler

Here u can see this is a content of carouselview in maui android. In this content of caraouselview, there is a button, or any listview or whatever button, when tapped on this particular button that time above error is showing the crash, Particular for Android . IOS working fine.
even formsplugin also worked in xamarin app.
Kindly give me solution

Hi @microspaze , Can u please solve this issue?

https://github.com/user-attachments/assets/6ce916d5-4af2-46fe-a3e9-51477e1aee7e
I‘m really sorry about that I can not reproduce your issue from the log you given. I have tested the button in CarouselView and it works well as the screen record video.
So can you just provide a minimum project that can reproduce your problem and then I will take a deeper look.

Hi @microspaze Sure I will share. But this button operation is inside same page. But my case is after tapping button there will be navigation to another page. that time this error came

Hi @microspaze , I am using freshmvvm.maui in my project as a navigation panel

https://github.com/user-attachments/assets/b72f5dc5-4e0d-49c3-bad9-9048977ed543
I tested that it works fine by the shell navigation.

Routing.RegisterRoute("home", typeof(MainPage));
Routing.RegisterRoute("second", typeof(SecondPage));

await Shell.Current.GoToAsync("second");

await Shell.Current.GoToAsync("..");

You'd better give me a test demo to reproduce your issue.


New Feature, restore all into an incognito session

pretty much, if you could write a new function to restore all tabs into an incognito session.

I would also love to have this.


chore: sync noir repo

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 110 (+912%)
note_trial_decrypting_time_in_ms (64): 126 (+265%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit be5855cd and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
5,700
18,884
36,452

l1_rollup_calldata_gas
66,180
239,000
469,604

l1_rollup_execution_gas
194,128
500,306
908,862

l2_block_processing_time_in_ms
1,184 (-1%)
4,478
9,072 (+1%)

note_successful_decrypting_time_in_ms
198 (-1%)
547 (-6%)
992 (-1%)

note_trial_decrypting_time_in_ms
:warning: 110 (+912%)
72.3 (-32%)
:warning: 126 (+265%)

l2_block_building_time_in_ms
16,378 (+3%)
65,094 (+3%)
130,488 (+3%)

l2_block_rollup_simulation_time_in_ms
12,411 (+2%)
49,618 (+3%)
99,462 (+3%)

l2_block_public_tx_process_time_in_ms
3,937 (+4%)
15,407 (+2%)
30,878 (+3%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,982 (+5%)
28,007 (+2%)

note_history_successful_decrypting_time_in_ms
1,247 (-9%)
2,412 (-2%)

note_history_trial_decrypting_time_in_ms
89.6 (-17%)
130 (-22%)

node_database_size_in_bytes
18,804,816
35,520,592

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
252 (+2%)
44,736
28,001

private-kernel-ordering
193 (+9%)
52,625
14,627

base-rollup
1,318 (+3%)
177,932
933

root-rollup
70.1
4,192
825

private-kernel-inner
321 (+3%)
73,715
28,001

public-kernel-app-logic
196 (+3%)
32,254
25,379

merge-rollup
5.75 (-1%)
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts

tx_size_in_bytes
19,179

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
2,619 (+3%)
1,374 (+2%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.0295 (-14%)
478 (+2%)

I'm not sure why the e2e test is breaking here. I've turned off the new optimisation pass so the only material change to the compiler should be the changes to brillig. Any ideas @sirasistant ?

huh, must have just been a flakey test.


Decode compressed response option

Add decode_compressed_response VCR option #230
httpbin tests might conflict with #149

Great work and nice tests! Just make that one small change that I suggested and I'll merge.

Sweet!  Thanks!

Changes Unknown when pulling 5d866dd77c94779794950c7e4fe5ab8fcb549184 on tobiowo:decode-compressed-response into ** on kevin1024:master**.


Problem downloading xrt_202<IP_ADDRESS>4_22.04-amd64-xrt.deb within run-docker.sh

After running ./run-docker.sh quicktest the process gets stuck on step [10/45] trying to download some files.

Apparently it tries to run wget https://www.xilinx.com/bin/public/openDownload?filename=xrt_202<IP_ADDRESS>4_22.04-amd64-xrt.deb, but it keeps waiting for a response after a HTTP request. I tried to download via browser and it worked fine, but I still don't know where to put the file.

I have encountered this issue for last 3 days. Therefore, I'm using the main brach of v0.10.

If the download works using your browser, you could use wget with the user-agent set.
e.g. wget --user-agent="Mozilla/5.0" [...]

This was probably fixed in https://github.com/Xilinx/finn/pull/1092

If the download works using your browser, you could use wget with the user-agent set. e.g. wget --user-agent="Mozilla/5.0" [...]

It worked, thanks!

Hi all,
Thanks for (re)-opening the issue. We are working on a solution, if you don't need XRT for your specific use case, try to skip the build by using dev and setting FINN_SKIP_XRT_DOWNLOAD=1.

The xrt download link is back up and you should be able to use dev without an issue now.

This PR allows to skip the download and instead use a local version of the xrt .deb: https://github.com/Xilinx/finn/pull/1098
Closing this issue for now.


[MediaComposition] Introducing SDK Private Preview

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check for Azure.Communication.MediaComposition
API review is created for Azure.Communication.MediaComposition. You can review APIs here.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.MediaComposition

@KrzysztofCwalina @tg-msft
This PR is meant to introduce the initial version of the Media Composition SDK, which is a new service that we are working on.
Our service is still a WIP and we currently don't have the E2E running yet so it will be at least a few weeks before we release this SDK. We wanted to merge this initial version in first to the main branch, please let take a look and let us know if that's good to go. Thank you!


faq-shop: new-faq-section-for-shop

@rafkoch This is a public repository. Please use English and do not provide links to private issue trackers.

@rafkoch This is a public repository. Please use English and do not provide links to private issue trackers.

@pietrushnic sorry, I translate my three comments from polish to english language and I remove link to private issue tracker.


Domain test log output contains errors

Example: https://github.com/Energinet-DataHub/geh-charges/runs/4235636600?check_suite_focus=true
It's currently unknown whether it's a technical problem or an error in the production code. But we should fix it. Also because it might hide other important errors if we just leave it as-is.

Give me a call if you take this story

Fixed in #977 and #968

Test: This doesn't look as desired (should be the latest CI from this story - PR #977):

Log entries shown was caused by missing environment variable in the charge app fixture.
Fixed in #983

Test OK: I can't find any significant errors in the latest test run.


Chatty log output at channel shutdown

This "error" appears every time a channel is closed and it's disturbing. We should fix this for 0.15.1.
0 C:\Users\<username>\Documents\GitHub\grpc\vsprojects\..\src\core\ext\transport\chttp2\transport\chttp2_transport.c:1810: close_transport: {"created":"@1466691583.939000000","description":"Failed parsing HTTP/2","file":"
C:\Users\<username>\Documents\GitHub\grpc\vsprojects\..\src\core\ext\transport\chttp2\transport\chttp2_transport.c","file_line":1726,"referenced_errors":[{"created":"@1466691583.939000000","description":"End of TCP stream","file":"
C:\Users\<username>\Documents\GitHub\grpc\vsprojects\..\src\core\lib\iomgr\tcp_windows.c","file_line":179}]}

Originally reported here:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/grpc-io/Jc33SN1V0FI/z2_Y2pVMAwAJ

Tentative fix: https://github.com/grpc/grpc/pull/7025


Sending image as part of credential

Hello,
I am trying to issue a credential that has image/jpeg as a field. I am using also mobile agent and mediator. but whenever i try to issue offer i get this error:
aries_cloudagent.transport.outbound.manager ERROR >>> Error when posting to: http://<IP_ADDRESS>:8022/webhooks/topic/issue_credential/; Error: (<class 'aries_cloudagent.transport.outbound.base.OutboundTransportError'>, OutboundTranspo
rtError('Unexpected response status 413, caused by: Request Entity Too Large',), <traceback object at 0x7f907d3e05c8>); Re-queue failed message ...
My image is 460Kb
Is it possible to change this?
I tried to change default value of --max-message-size in argparse.py but that did nothing

Hi,
i found the same problem in the past at the following code line,
https://github.com/hyperledger/aries-cloudagent-python/blob/653a4c2c4d19e1e3a0b6b89467affcea81827434/aries_cloudagent/admin/server.py#L288
The default client size is used, it can be customized passing the size as here app = web.Application(middlewares=middlewares, client_max_size=2048**2)
@andrewwhitehead  Maybe an args params could be usefull for the scope?

Hi,
I dont see that line in that file. Is that the latest code?

Sorry, I sent an old link. Looking at the actual code it looks like it is already managed with the "admin.admin_client_max_request_size" parameter. Default 1 mb. It can be customized using this parameter.

I saw that but whatever i put there i get the same error. There is no way i am sending more then 20MB

Maybe its because i am running faber demo? How can i add that option in that demo?

Closing this issue because it is old, but am open to having it re-opened, especially if you could provide a more complete example of the problem -- the steps you used to create the problem using the Alice/Faber demo.  We'd just need what you did differently from the doc, and an example image you are using.


Gull data paper

Before submitting

[x] Update title
[x] Add figures
[x] Update dataset metadata: everything except study extent
[x] Update dataset data
[x] Republish dataset
[x] Submit

After review

[x] Update text

After acceptance

[x] Finalize text (with correct version number for dataset)
[x] Update dataset metadata
[x] Update dataset title
[x] Add dataset authors
[x] Add Vlissingen colony to map
[x] Update figure 1
[x] Update dataset data mapping: title
[x] Update data
[x] Update metadata.md

After DOI is known

[ ] Add paper DOI to metadata.md (2 places)
[ ] Add paper DOI to IPT (2 places)
[ ] Add paper reference to metadata.md (as first reference)
[ ] Add paper reference to IPT (as first reference)
[ ] Add paper reference to README
[ ] Republish dataset
[ ] Update dataset on VODP (also citation)

DOI is known: http://doi.org/10.3897/zookeys.555.6173 I'll update where I can.


No active executor found

after configur the properties file,i run the bin/azkaban-web-start.sh
then the issue as follow:
Error injecting constructor, azkaban.executor.ExecutorManagerException: No active executor found
at azkaban.executor.ExecutorManager.(ExecutorManager.java:132)
at azkaban.executor.ExecutorManager.class(ExecutorManager.java:73)
while locating azkaban.executor.ExecutorManager
for the 3rd parameter of azkaban.trigger.TriggerManager.(TriggerManager.java:58)
at azkaban.trigger.TriggerManager.class(TriggerManager.java:39)
while locating azkaban.trigger.TriggerManager
for the 5th parameter of azkaban.webapp.AzkabanWebServer.(AzkabanWebServer.java:155)
at azkaban.webapp.AzkabanWebServerModule.configure(AzkabanWebServerModule.java:52)
while locating azkaban.webapp.AzkabanWebServer
Caused by: azkaban.executor.ExecutorManagerException: No active executor found
at azkaban.executor.ExecutorManager.setupExecutors(ExecutorManager.java:226)
at azkaban.executor.ExecutorManager.(ExecutorManager.java:137)
at azkaban.executor.ExecutorManager$$FastClassByGuice$$e1c1dfed.newInstance()
at com.google.inject.internal.DefaultConstructionProxyFactory$FastClassProxy.newInstance(DefaultConstructionProxyFa

Please follow the setup guide to set up and activate executors.

"Please follow the setup guide to set up and activate executors."
It would be helpful if the documentation highlighted this dependency ordering between the executor and web servers.

Follow the setup guide to set up and activate the executive.
In the case of activation of the program execution, there may be a problem with the database, and the data in the 'executors' table in the database needs to be modified.
E.g
id    host                port         active
1	localhost	12321	1
5	office-prod-bigdata-00	12321	0
You need to change the corresponding actuator's active to 1, you can run, execute the program. It seems that there are some bugs, you can't modify the database information in time.
================中文=====================
请按照设置指南设置和激活执行程序。
在激活程序执行的情况下，有可能是数据库的问题，需要修改 数据库中 'executors' 表中 的数据
例如
id    host                port         active
1	localhost	12321	1
5	office-prod-bigdata-00	12321	0
你需要将 对应执行器的 active 改为1， 就可以运行，执行程序 好像有些BUG，不能及时修改数据库的信息

Follow the setup guide to set up and activate the executive.
In the case of activation of the program execution, there may be a problem with the database, and the data in the 'executors' table in the database needs to be modified.
E.g
id    host                port         active
1	localhost	12321	1
5	office-prod-bigdata-00	12321	0
You need to change the corresponding actuator's active to 1, you can run, execute the program. It seems that there are some bugs, you can't modify the database information in time.
================中文=====================
请按照设置指南设置和激活执行程序。
在激活程序执行的情况下，有可能是数据库的问题，需要修改 数据库中 'executors' 表中 的数据
例如
id    host                port         active
1	localhost	12321	1
5	office-prod-bigdata-00	12321	0
你需要将 对应执行器的 active 改为1， 就可以运行，执行程序 好像有些BUG，不能及时修改数据库的信息

I have the seem question，when I run the ./bin/start-web.sh, it will report No active executor found, and I see the executors table, it is empty, I can't even modify the active status manually, anyone can help me?

@zhangqingkai  i had the same issue.
how to fix:
1)start executor and on that host do curl
2)curl -G "http://localhost:<executor_port>/executor?action=activate" && echo
this is mentioned here
https://azkaban.readthedocs.io/en/latest/getStarted.html#getting-started-with-the-multi-executor-server

@FourSpaces ThankS，very good。加个| 1 | <IP_ADDRESS>| 12321 | 1   就可以了。