Schema manager should not set null values for properties that have no given values or defaults

Ref:

#189


Thread logging through to client and server entry points

Codecov Report

Merging #284 into master will increase coverage by 0.24%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   98.98%   99.22%   +0.24%
==========================================
  Files          69       34      -35
  Lines        3043     1676    -1367
==========================================
- Hits         3012     1663    -1349
+ Misses         18        8      -10
+ Partials       13        5       -8

Flag
Coverage Δ

#dot
99.22% <95.12%> (+0.24%)
:arrow_up:

#dot_changes
100% <ø> (ø)
:arrow_up:

#dot_changes_diff
100% <ø> (ø)
:arrow_up:

#dot_changes_run
100% <ø> (ø)
:arrow_up:

#dot_changes_table
100% <ø> (ø)
:arrow_up:

#dot_changes_types
100% <ø> (ø)
:arrow_up:

#dot_example
100% <ø> (ø)
:arrow_up:

#dot_log
100% <ø> (ø)
:arrow_up:

#dot_ops
98.29% <94.8%> (+0.05%)
:arrow_up:

#dot_ops_bolt
97.56% <ø> (ø)
:arrow_up:

#dot_ops_nw
96.74% <94.73%> (+0.55%)
:arrow_up:

#dot_ops_pg
97.6% <ø> (ø)
:arrow_up:

#dot_ops_sync
99.01% <ø> (ø)
:arrow_up:

#dot_refs
?

#dot_streams
?

#dot_streams_undo
?

#dot_test_seqtest
?

#dot_test_testops
?

#dot_x_dotc
?

#dot_x_fold
?

#dot_x_heap
?

#dot_x_rt
?

#dot_x_ui_collab
?

#dot_x_ui_dom
?

#dot_x_ui_html
?

#dot_x_ui_input
?

Impacted Files
Coverage Δ

ops/transformer.go
100% <100%> (ø)
:arrow_up:

ops/nw/client.go
100% <100%> (+4.08%)
:arrow_up:

client.go
100% <100%> (+13.04%)
:arrow_up:

server.go
88.88% <100%> (+2.22%)
:arrow_up:

ops/nw/server.go
96.15% <90.47%> (+0.5%)
:arrow_up:

ops/nw/request.go
95.45% <95.45%> (ø)

streams/undo/stream.go

x/dotc/structs.go

x/dotc/union.go

x/dotc/slice.go

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b05d8...49b063b. Read the comment docs.


[Github] feat: add criteria events for country and country state routes

1. Why is this change necessary?
It's not possible right now to adjust the criteria with which the country and country-state routes work.
2. What does this change do, exactly?
adds criteria-events to the two routes
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Imported from Github. Please see: https://github.com/shopware/shopware/pull/4851

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38432
[created from NEXT-38432, comment 497756]


Router

Hello,
Thanks a lots, for this good library!
Do you have any ideas to manage navigation in a single activity application with redux?
Thanks.

Good question! We currently don't keep navigation in the state as it's tricky to keep in sync with what android saves with activities and fragments etc. It's definitely something we want to explore though.

I created a navigation middleware that navigate based on Navigation Actions:

class NavigationMiddleware : AppMiddleware {
    override fun dispatch(next: Middleware.Next<Action, Action>, action: Action): Action {
        if (action is NavigationAction) {
            action.navigate()
            return action
        }
        return next.next(action)
    }
}

interface NavigationAction : PageViewAction {
    fun navigate()
}

open class IntentNavigation(val from: Context,
                            private val intent: Intent,
                            override val pageName: String)
    : NavigationAction {

    override fun navigate() {
        this.from.startActivity(intent)
    }
}

open class ActivityNavigationAction(from: Context, val to: Class<out Activity>, pageName: String)
    : IntentNavigation(from, Intent(from, to), pageName)

open class NewStackNavigationAction(from: Context, val to: Class<out Activity>, pageName: String)
        : IntentNavigation(from, Intent(from, to).apply {
                addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK)
                addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
            }, pageName)

If you need a more complex navigation, just implement the NavigationAction interface.

Hello @guitcastro interesting implementation with middleware.
Thanks for your reponse.
@guitcastro can you please add implementation of your NavigationAction? I thinks it's just an Action without specific implement. This is it?
I come back on this thread because , i thinks again on this architecture problem.
The pain point with @guitcastro implementation is that navigation is not in the state.
If we things that all application  state must be in an object State. Then we have a lost.
@evant if your interest i have implemented  a Router implementation of your redux implementation, inspired by an iOS implementation
It's not very clean because depends of Rx because it was much faster for me to plug different UI action, but it's work very well. I have test it on a huge project without problem.


Variable digits lenths

Adding support for variable digits. Battle.net requires 8 digits instead of 6.

Just tested it with my Battle.net account and everything seems to work.
As soon as you remove the two lines I marked I will merge it.


fix: No hover effect for selected options.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/39716
PROPOSAL: https://github.com/Expensify/App/issues/39716#issuecomment-2040221601
Tests

Start a manual IOU flow and enter amount
Select few options for splitting
Hover on selected options and verify the bg changes on hover
Go to workspace members page and select few members
Hover on seleceted members and verify the bg doesn't change (because for selected option we already have different bg)

Test 2

Open App and go to workspace chat page
Start a manual IOU flow and Go to category selection page
Select any category from list
Press the keyboard down arrow a few times to shift the focus
Hover over the selected category
Verify that the selected category backgroud changes when hover over

[x] Verify that no errors appear in the JS console

Offline tests

Start a manual IOU flow and enter amount
Select few options for splitting
Hover on selected options and verify the bg changes on hover
Go to workspace members page and select few members
Hover on seleceted members and verify the bg doesn't change (because for selected option we already have different bg)

Test 2

Open App and go to workspace chat page
Start a manual IOU flow and Go to category selection page
Select any category from list
Press the keyboard down arrow a few times to shift the focus
Hover over the selected category
Verify that the selected category backgroud changes when hover over

QA Steps

Start a manual IOU flow and enter amount
Select few options for splitting
Hover on selected options and verify the bg changes on hover
Go to workspace members page and select few members
Hover on seleceted members and verify the bg doesn't change (because for selected option we already have different bg)

Test 2

Open App and go to workspace chat page
Start a manual IOU flow and Go to category selection page
Select any category from list
Press the keyboard down arrow a few times to shift the focus
Hover over the selected category
Verify that the selected category backgroud changes when hover over

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/3ee3b82f-78b8-49b0-8450-fe27fc77df5d

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/84bd787d-1386-466e-883d-269508b7dcdb

iOS: Native
https://github.com/Expensify/App/assets/85894871/caa271c5-54f3-414e-9636-d56c8ce5abe5

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/1ec7cd4c-c63c-4f55-8952-f450ba18f2db

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/49896cb3-57e7-4544-8687-4d8587b87dba

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/d95aeebe-af92-4d8b-b65c-45c94f08a74a

Screenshots look good to me

@Krishna2323 please resolve the conflicts

@Krishna2323 Please add belows steps in Tests section as Test 2:

Open App and go to workspace chat page
Start a manual IOU flow and Go to category selection page
Select any category from list
Press the keyboard down arrow a few times to shift the focus
Hover over the selected category
Verify that the selected category backgroud changes when hover over

@Krishna2323 I am getting an issue, can you confirm that this is not coming from this PR:

Go to workspace IOU flow, Initially there is no category selected
Press on Category
Use up/down arrow on the category picker page, its working
Select a category, we will navigate to request confirmation page, and now go again to the category picker page and try to use up/down arrow key, this time it will not work

https://github.com/Expensify/App/assets/35371050/8bf4e36d-34dc-499d-9952-83122d5e162b

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/35371050/61f4a0e4-51bf-4a3e-9858-f6d1a68bde45

Android: mWeb Chrome
https://github.com/Expensify/App/assets/35371050/c0798963-aeb9-484c-93f4-ab2e2d94227a

iOS: Native
https://github.com/Expensify/App/assets/35371050/decdc8a2-8604-4182-bf97-1b96d6fc4c73

iOS: mWeb Safari
https://github.com/Expensify/App/assets/35371050/317ddbcf-9666-4ecc-9be4-a0181e58f48f

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/35371050/1b18584c-8cd6-4f07-816d-d985214345ab

MacOS: Desktop
https://github.com/Expensify/App/assets/35371050/ff15d61b-da34-4cd1-aafa-89998e3c3aad

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix padding in  in decks

Potential fix: add  or  as a child of  element, give it
    top: calc(50% - {<a> item height}/2);     position: relative;
and add height: 100% on <td>


PROBLEM WITH 2 GRAPHICS CARD

i ma having 2 graphics card while training PICKS the INTEL graphics card not the NVIDIA graphics card while having the library of tensorflow-gpu not nothing is working .. HELP REQUIRED IN THIS MATTER.

This is an issue with your systems hardware configuration and TensorFlow, not with this repository.
You might want to ask your question here: https://stackoverflow.com/questions/tagged/tensorflow


Create counters

Gotta start somewhere. Ideally the bot needs to be able to accept a command and create a counter that then "starts". Something along the lines of:
!command arguments So like !TimeSince CounterCreate
which would either chat with or message directly, the requester for more details:

Name of Counter
Description of Counter

#6  Might have to be addressed before we can complete this

For now, I think I'm going to persist data in a json ( in a ./data dir). for now as that'll allow me to persist in a nasty hacky way, and we'll deal with "proper" persistence down the line I guess?

fist stab at this is in the #cai-barebones-bot repo now.

#7 closes this.


Setup strategy

From my understanding, this project have been created to extract utility classes that where provided by psr/log ^1.1 but removed from v2 (https://github.com/php-fig/log/pull/76).
This repo should start with a v1.0.0 that provides nothing, but require psr/log ^1.1 which provides TestLogger and LoggerInterfaceTest.
Next, v1.1.0 requires psr/log ^2.0|^3.0 and php >=8.0.0 and provides the classes that were removed from this versions. Older PHP version don't have to be supported since psr/log >= 2.0.0 require PHP 8.0 (see composer.json).
For a project that uses the test classes, needs support for PHP 7 and allows all versions of psr/log, it would have the following requirements:
"require": {
    "psr/log": "^1.1|^2.0|3.0"
},
"require-dev": {
    "psr/log-utils": "^1.0"
}

Seen https://github.com/php-fig/log-util/pull/2#issuecomment-885454569, ~but they don't provide a migration path and looks outdated~ but my proposition is to not change the class names.

This seems a great approach. @Seldaek do you agree?

Yup sounds good to me.

Updated the description, the version that brings the classes can be v1.1.0, since it will be compatible.


Prevent cluster queue webhook from panicking for existing resources

What type of PR is this?
/kind bug
What this PR does / why we need it:
Prevent the cluster queue validation webhook from panicking for existing resources, whose .spec.preemption.borrowWithinCohort field haven't been defaulted yet.
Which issue(s) this PR fixes:
Fixes #1669
Does this PR introduce a user-facing change?
NONE

/ok-to-test

/retest
due to #1658

Thank you for creating this PR! Should we extend the webhook unit test?

You're right. I've added the test cases.
I wonder if adding an upgrade e2e test that would upgrade Kueue from the latest released version and run some smoke tests would be useful.

/retest
due to #1658

I wonder if adding an upgrade e2e test that would upgrade Kueue from the latest released version and run some smoke tests would be useful.

It sounds like overkill in this case. I believe that the unit test should be enough. cc: @alculquicondor

For sure an upgrade testing workflow would be more involved, though it'd likely be able to catch these kind of issues before they are even introduced, while unit tests would have to be added "after the fact".

Yes, you're right.
The updating kueue-system e2e test would be helpful, but I think that we should implement such e2e tests to much more generic ways. It means that I don't think that introducing updating tests only for this case wouldn't useful.

Yes, you're right. The updating kueue-system e2e test would be helpful, but I think that we should implement such e2e tests to much more generic ways. It means that I don't think that introducing updating tests only for this case wouldn't useful.

Absolutely. Maybe something more akin to an "upgrade" test workflow, that would re-use the existing e2e test suite to emulate real usage, while performing the Kueue upgrade.

Absolutely. Maybe something more akin to an "upgrade" test workflow, that would re-use the existing e2e test suite to emulate real usage, while performing the Kueue upgrade.

It makes sense.


Mounted archives don't show up in getDirectoryItems

function lovr.load()
  lovr.filesystem.mount('test.zip', 'omg')
  print(unpack(lovr.filesystem.getDirectoryItems('/'))) -- should include omg
end

The archive iterator does not handle the case where an archive is mounted somewhere in the virtual filesystem -- it should include the archive's mountpoint in the list as a virtual folder.

Also, if a directory is mounted with a mountpoint with multiple path components, the intermediate paths of the mountpoint aren't recognized as virtual directories.


Update dendron.topic.frontmatter.md

Add "stub" to the frontmatter reserved keywords

@kevins* in the newest version of dendron, the stub: false metadata isn't being written out any more since we assume undefined as no stub. so you shouldn't see it anymore going forward in the fm. the reason it shows up is because every node has a stub property and when we create it, dendron populates the frontmatter with some metadata that needs to be persisted (eg. id, creation date). stub shouldn't be one of those fields and has been removed in the latest release
So there is no need for this pull request, Closing


[Feature Request] Improve Protection against Browser Fingerprinting

The concept behind DuckDuckGo Privacy Browser is great. The tracker and ad blocking, I would say it is better than Firefox's by a million miles. One thing that is preventing me from using this app on a more permanent basis, is the lack of fingerprint protection. I know this has been an issue previously raised and it is a legitimate concern. The protection we get is very unique in a way but the fact we can be tracked by our browser's fingerprint is not so great. If you test out this (coveryourtracks.eff.org), you will notice how the fingerprint is unique. This means for all those trackers and ads not blocked, it makes it easier to track users especially with DuckDuckGo as part of the user agent. This does need to be addressed because you can't have a completely private experience unless you implement a measure to protect against browser fingerprinting. A couple of things I must mention is Brave randomizes its fingerprint and even Firefox has a preference to 'resist' fingerprinting.

Closing as this was not a bug, and user who reported the issue deleted the account.


Can't get this Work with ubuntu!

I had follow your manual and the scope won't get recognized. In the lsusb the scope is shown as a OWON PDS6062T.

See https://github.com/tinwhisker/Owon-VDS1022/issues/6#issuecomment-478625152


Subdomains not identified by default.

Similar (or same) issue as here: https://github.com/needle-innovision/nestjs-tenancy/issues/3#issue-696412315
When using
isTenantFromSubdomain: true
Tenants are not being identified.
This seems to be an issue with subdomains not being read properly by nestjs.

@jarrilla Thanks for the note. Reviewing your PR. Will provide an update once approved.

@jarrilla Thanks for the note. Reviewing your PR. Will provide an update once approved.

This was an issue with testing in a local environment.
See https://github.com/needle-innovision/nestjs-tenancy/pull/7#issuecomment-757958355

This was an issue with testing in a local environment.
See https://github.com/needle-innovision/nestjs-tenancy/pull/7#issuecomment-757958355

Thanks @jarrilla

Thanks @jarrilla


Move section navigation bar to the left and (always, mostly) display

For example, on this page, the user doesn't know where to find the rest of the content:

The user needs to click on the "..." on top to open the menu, and it is not intuitive.

Moreover, having navigation on the right is not intuitive for LTR languages since most navigations are on the left (including the one in Metanorma document.
What do you think @strogonoff ?

Sidebar position is by design, same is done on ReactJS and many other sites. Left-to-right, start in order of importance (content first). We can open the sidebar initially, that’s something I’m open to, though it was also a conscious decision. @ronaldtse you tend to see most of my deliberate design decisions a bugs, as I observe🤔

Actually, I don’t see that I can do much on this issue in good faith.

I checked and the sidebar is indeed open initially, unless viewport is narrower than 900px. In that case there’s a risk of overlapping content, and thus the sidebar is collapsed by default. (This is also the breakpoint below which we start hiding top navigation items behind a hamburger menu.)

I placed the sidebar on the right in accordance with LTR parsing order (main content first).

We could change the breakpoint so that sidebar is open by default on screens as narrow as e.g. 800px, but IMO 900px is small enough by today’s standards.

(Added and reverted the commit opening sidebar by default on all viewport widths)

I checked and the sidebar is indeed open initially, unless viewport is narrower than 900px. In that case there’s a risk of overlapping content. This, again, is a conscious design choice, to have navigation “overshadow” content when both don’t fit. Thus, on narrow viewports the sidebar is collapsed by default. (900px is also the breakpoint below which we start hiding top navigation items behind a hamburger menu.)

Hmmm... 900px seems too wide -- I'm using a 15" MacBook Pro, and when I open Metanorma, I often do not see the bar.
If I open 900px and then shrink, the sidebar still stays. Perhaps that indicates we can use a smaller width.
At least, the "..." icon doesn't work. It must occupy vertical space for people to know that extra content exists?

I placed the sidebar on the right in accordance with LTR parsing order (main content first).

The table of contents should always be first (i.e. Left). The main content of that page comes later. People often want to jump to another page rather than read the "main content".

Hmmm... 900px seems too wide -- I'm using a 15" MacBook Pro, and when I open Metanorma, I often do not see the bar.

Fair point, agreed to try changing the breakpoint to 800px. I’m using same hardware though and haven’t had this issue.

If I open 900px and then shrink, the sidebar still stays. Perhaps that indicates we can use a smaller width.

Sidebar state won’t be toggled by window resize.

At least, the "..." icon doesn't work. It must occupy vertical space for people to know that extra content exists?

Not sure I get that point.

The table of contents should always be first (i.e. Left). The main content of that page comes later.

I weighted both options and made my design decision based on first principles and examples of subjectively well-designed and objectively successful documentation from other OSS products (e.g., React, Django).
I’m not responsible for the design of Metanorma documents, but for its documentation site. If the premise is to match documentation sidebar position to the one in Metanorma documents, we can do that though I am not sure why that would be important.

(Changed the breakpoint to around 800px, updated Metanorma to the new version)

In latest version of OP theme (which Metanorma.com was updated to) also ensured that ToC toggle button shows on documentation pages, as it should by design.

In medium term I’m looking into updating navigation with following goals in mind

Combine two collapsible menus (top menu and docs navigation) in one to simplify UX
Make docs navigation more elegant overall and consistent across software & project-wide docs
Fix the issue where long anchor titles in in-page ToC would cause menu to overflow viewport, if viewport is narrow

Planning to do this for all project sites, as part of https://github.com/riboseinc/jekyll-theme-open-project/issues/72 (upstream theme issue).


One Bug in plot_mm when visualizing object from mixtools

I was trying to visualize a two-component Gaussian mixture model with unequal covariance matrices for the two components. An error "Error in eigen(sigma) : non-square matrix in 'eigen'" is reported.
I think the reason is that mvnormalmixEM in mixtools gives two types of output for estimated mean and covariance matrix: vector/matrix when arbmean/arbvar is FALSE (i.e. mean and covariance in all components is equal), or list when the arbmean/arbvar is TRUE. So there are three cases: equal mean and unequal covariance, unequal mean and equal covariance, and unequal mean and covariance. The plot_mm could only handle the case with unequal mean and equal covariance.

Thanks for the flag! Currently I'm on parental leave, so I can't get to this for a bit. But I wanted to respond and label this issue to get back to it when I return.

Note to self: adding feature idea label given that everything works, but for more limited cases. Enhancement will include handling for all "three cases"...

[ ] equal mean and unequal covariance
[ ] unequal mean and equal covariance
[ ] unequal mean and covariance

Note: can use custom functions for adjusting for variance and covariance structures. At present, no plans to expand to include these, given potential of getting there via custom functions. Read docs for more. Thanks


[BUG] can not run project

What happened?
node 20.10.0
npm 10.2.3
pnpm 8.10.2
When I run :pnpm create plasmo --with-antd
error：
<EMAIL_ADDRESS>Running install script, failed in 47s
<EMAIL_ADDRESS>install$ (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebui…
│ sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.14.5/libvips-8.14.5-win32-x64.tar.br
│ sharp: Installation error: aborted
│ sharp: Please see https://sharp.pixelplumbing.com/install for required dependencies
└─ Failed in 47s at<EMAIL_ADDRESS> ELIFECYCLE  Command failed with exit code 1.
🟠 WARN   | pnpm install exited with non-zero code: 1
Version
Latest
What OS are you seeing the problem on?
Windows
What browsers are you seeing the problem on?
No response
Relevant log output
No response
(OPTIONAL) Contribution

[X] I would like to fix this BUG via a PR

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

have you resolved this problem?

I also encountered the same problem
npm error code 1
npm error path D:\octopus-browser\node_modules\sharp
npm error command failed
npm error command C:\Windows\system32\cmd.exe /d /s /c (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)
npm error sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.14.2/libvips-8.14.2-win32-x64.tar.br
npm error sharp: Please see https://sharp.pixelplumbing.com/install for required dependencies
npm error sharp: Installation error: aborted


Dentist parameters

Hi,
I managed to run the pipeline but know I am having a closer look at the options.
My goal is to be conservative with this: I ma happy to fill gaps when there is strong evidence for it but I don't want to mess up the assembly because it is pretty good overall I think.
From what I gathered form the github, --read-coverage combined with the ploidy is one very important option. Do you have any recommendation about how to obtain the coverage value ? Is there recommended tools for this ?
I am thinking I should not play much with the other parameters as I have CLR data.
Any advice on this ?
Best
Aurélien

You are lucky! Your goal is exactly DENTIST's main goal: be conservative, close gaps only with certainty. That's why the default configuration is already aimed to be conservative. Still, to be absolutely certain about the quality of the insertions you can map the reads to the gap-closed assembly using e.g. minimap2 and visualize each closed gap with the help of the *.closed-gaps.bed file which shows the loci of the closed gaps.
Regarding the read coverage, there is already advice in the README under How to Choose DENTIST Parameters:

Ideally, the user provides the haploid read coverage which, can be inferred using a histogram of the alignment coverage across the assembly. Alternatively, the average raw read coverage can be used which is the number of base pairs in the reads divided by the number of base pairs in the assembly.

In my experience, the second method gives already satisfactory results. It is actually not quite clear whether a more accurate estimate of the read coverage provides better performance in gap closing.
I would also invite you to play with other parameters based on the guide in the README if you are not happy with the result. Especially, --max-insertion-error and --join-policy could be interesting to play with.

Hello,
In the validation-report.json, what are the meaning of the different terms ? (I pasted one line of the file at the bottom of the message.
In the bed file I have 717 lines and in the validation report 485 lines and all of them have this  "isValid":false.
Does that mean that the validation-report.json only contains the invalid gap ? and the bed file all of them ?
Or did something go wrong ?
{"spanningReadIds":[3220364,4064883,4417687,6205668,8191962,8278500,8616546,10513266,11032877,14762477,14762478,15227433,17797189,19431685,22248792],
"isValid":false,
"contigIds":[108,109],
"numSpanningReads":15,
"region":{"tag":104,"contigId":104,"begin":21824,"end":22156},
"weakCoverageMaskBps":1964,
"regionWithContext":{"tag":104,"contigId":104,"begin":20824,"end":23156},
"consensusReadIds":[1238256,3220364,3222420,3726037,4064883,4417687,8191962,8278500,8616546,10513266,10841984,11032877,11051323,11119214,11538615,14677272,14762477,14762478,15227433,15825890,17797189,19070061,20192883,21507486,21507487,22248792]}


Feat live view

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


"Try google search" has disappeared

The problem
When the term in the docs.perl6.org search box is not in the index, there used to be a "Try web search" option. It was not perfect (see #1391), but it's now disappeared
Suggestions
We really need specs and a test set for htmlify. But for the time being, just try to put it back where it belongs.

But I can still see it?

I couldn't see it in Firefox...

Firefox:

It was a network error, apparently. It works now.
Anyway, it's true that we should check these things do not disappear...


visibility toggle for time series does not work

Describe the bug
The visibility toggle in the viewer's UI has no effect for the scalar logs / time series

To Reproduce
Steps to reproduce the behavior:

Log time series data to a viewer
Click on the visibility toggle to try and hide an entry
Line plot is still visible :cry:

Expected behavior
Time series plot would be hidden / shown when changing the visibility toggle
Desktop (please complete the following information):

OS: Ubuntu 22.04

Rerun version
rerun_py 0.5.1 [rustc 1.67.1 (d5a82bbd2 2023-02-07), LLVM 15.0.6] x86_64-unknown-linux-gnu hotfix-0.5.1 968bf73, built 2023-05-02T21:13:39Z

I'm seeing this as well


LDAP: Add filter based on memberOf

LDAP authentication is great. In our use case, it would be useful to have a filter based on the AD groups the user is member of. Only member of the "Crackerjack" security group in AD should be able to log in.
In the same way, another group could be used to configure if the user shall be admin or not in Crackerjack.

This is a good recommendation, can you try specifying the OU in the settings to be the one for the CrackerJack users?
As for the admin one, it'd also be a good addition, but originally I've kept it separate to avoid being locked out if the LDAP server was down - by forcing to use local accounts.

Depending on the layout of the AD, in the same OU some accounts shall be allowed to login and other not hence the filter on group membership rather than OU.
Regarding admin accounts, you could still try to authenticate locally and LDAP, whichever succeeds.


GDrive and MEGA uploads for RG351MP

as the title says, the downloads are currently overloaded/broken

They work for me.  Either copy the file to your personal gdrive then download it from you personal gdrive or just wait until they're available again.


bug: Add to cont erc20ABI func permit

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.6.8
Current Behavior
In eip-2612 a function has been added permit.
And in order not to create new files in the project, it would be good to update the existing const.
Expected Behavior
No response
Steps To Reproduce
No response
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Can you please add some more additional info to this issue (e.g. Expected behavior, minimal reproducible example, etc.)?


support prereq check for MCE v2.0

For issue https://issues.redhat.com/browse/CMCS-51

/hold

/lgtm

/unhold

/unhold

/hold

quay image with the fix is 0.0.1-20220325-17-36-50-0749933-main


Text aligned to top instead of center when changing LineSpacing on TextBlock

Describe the bug
Ref #13873
It seems that the problem remains with LineSpacing, rather than LineHeight.
See screenshots.

To Reproduce
private static Grid CreateSample2()
{
    const double LineSpacing = 16; // 0;
    const double LineHeight = double.NaN; // 32;

    var grid = new Grid();
    grid.Background = new SolidColorBrush(Colors.DarkGray);
    grid.ShowGridLines = true;
    grid.VerticalAlignment = Avalonia.Layout.VerticalAlignment.Top;
    grid.HorizontalAlignment = Avalonia.Layout.HorizontalAlignment.Stretch;

    grid.RowDefinitions.Add(new RowDefinition());

    grid.ColumnDefinitions.Add(new ColumnDefinition());
    grid.ColumnDefinitions.Add(new ColumnDefinition());
    grid.ColumnDefinitions.Add(new ColumnDefinition());

    var block = new TextBlock();
    block.LineSpacing = LineSpacing;
    block.LineHeight = LineHeight;
    block.Inlines.Add(new Run("Col 0"));
    block.Inlines.Add(new Run("\n"));
    block.Inlines.Add(new Run("Line 2") { FontSize = 24 });
    block.Inlines.Add(new Run("\n"));
    block.Inlines.Add(new Run("Line 3") { FontSize = 24 });
    block.Inlines.Add(new Run("\n"));
    block.Inlines.Add(new Run("Line 4"));
    grid.Children.Add(block);
    Grid.SetColumn(block, 0);

    block = new TextBlock();
    block.LineSpacing = LineSpacing;
    block.LineHeight = LineHeight;
    block.Inlines.Add(new Run("Col 1"));
    block.Inlines.Add(new Run("\n"));
    block.Inlines.Add(new Run("Line 2"));
    grid.Children.Add(block);
    Grid.SetColumn(block, 1);

    block = new TextBlock();
    block.LineSpacing = LineSpacing;
    block.LineHeight = LineHeight;
    block.Inlines.Add(new Run("Col 1"));
    block.Inlines.Add(new Run("\n"));
    block.Inlines.Add(new Run("Line 2"));
    block.Inlines.Add(new Run("\n"));
    block.Inlines.Add(new Run("Line 3"));
    grid.Children.Add(block);
    Grid.SetColumn(block, 2);

    return grid;
}

Expected behavior
LineSpacing behaves sames as LineHeight with regard vertical alignment
Avalonia version
11.1.3
OS
Linux
Additional context
No response

On second thoughts, I wonder if the correct behaviour is that LineSpacing should refer to line-spacing BETWEEN LINES. In other words, it should indeed align to the Top, but should should have zero spacing at the bottom line.
See the screenshot which shows a test output of mine. The LineSpacing is 1.2 (16 * 1.2 px), except for one item which is 2.0 (16 * 2.0 px). You can see that it bottom pads everything, which I don't think is best.

So you think we should add the spacing to the top instead of the bottom?

No, only between lines, so the Top and bottom would be 0. Think it appropriate to define what is meant by LineSpacing and the difference between it and the behaviour of LineHeight. It might be worth seeing what CSS does.

It looks like there is only a CSS "line-height", which you already appear to handle in the same way CSS does as per Ref https://github.com/AvaloniaUI/Avalonia/issues/13873
So I guess you are free to do whatever you wish with LineSpacing, including leaving it as it is. However, if you agree, I would suggest that it refers to the space between lines.

Currently, we add extra space to the bottom of a text line. We can do the opposite but must leave out the first line. This is doable.

Thank you for your replies.
I realise now that this issue needs a little thought. Your LineHeight property is analogous to the CSS line-height, except that it handles only pixels. I think LineSpacing is actually quite useful, but it wasn't immediately clear what this is and how it differs to LineHeight. I guess I should leave it is an open question as to what it should do in terms of top-bottom spacing, but don't think it should pad just the bottom line as does currently. Either it should behave like LineHeight, or pad only between lines. Are there any use cases which would prefer one above the other? Either would be acceptable, on reflection.


fix: check all events is one of them from future

Change(s):

fixed issue where only first event was checked for is event from future.

Hi @ospeka There is an automated response for python code. Can you please fix that?
Thanks

Looking into this

Hi @ospeka , while deploying function app we have getting error module not found as below. Please include missing module/folder.

Hi @ospeka , please include missing module/folder as mentioned above. Thanks.

Hi @ospeka , please include missing module/folder as mentioned above. Thanks.

@v-atulyadav hi, i have included missing modules. Can you check it now?

Hi @ospeka , we are looking into this.

Hi @ospeka , we are looking into this.

Hi @ospeka, we are checking on this and soon will give you a feedback regarding this. Thanks

Hi, i have updated incorrect module and tested it. Can you check it now?

Hi @ospeka, We will check on this and provide you with feedback as soon as possible. Thanks


[able -With selection and batch actions, Table Save View Model, Table Manage Views Modal, User view management] Unable to select the checkboxes using keyboard(Enter key)

Unable to select the checkboxes using the keyboard(Enter key) in the below components:
Table -With selection and batch actions
Table Save View Model
User view management
Steps:

Go to the "Table - with the selection and batch actions" component in the storybook
PAL URL: https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table--with-selection-and-batch-actions
Select the checkboxes using the keyboard.
Current Behavior: Unable to select the checkboxes using keyboard (Enter key)
Actual Behavior: should be able to select the checkboxes using keyboard.

PAL URLS:
Table -With selection and batch actions
https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table--with-selection-and-batch-actions
Table Save View Modal
https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table-user-view-management-tablesaveviewmodal--playground
Table Manage Views Modal
https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table-user-view-management-tablemanageviewsmodal--with-callbacks-implemented
User view management
https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table-user-view-management--with-user-view-management

I assume there is no work-around for a11y users, so this is a sev 1

Hi @bakkireddi. The accessibility spec actually calls for the spacebar to trigger a selection for checkboxes. If you look at these links here and here you can verify that we are following the spec when it comes to checkbox selection.  I am going to close this issue but feel free to reach out if you would like to discuss further.


llvmio.jl is using incorrect declarations

It looks like many of the llvmcalls have incorrect definitions, atributes, types, ABIs, or other errors. These seem like they really should be using  @ccall instead to let Julia handle those issues. I noticed this because it crashed in PkgEval with an LLVM verifier error.

Ah yeah, I think there's at least one more I still have wrong in there. As far as I understand @ccall is still not really StaticCompiler-able though, which is a must-have here.
If you have any pointers for which calls still have errors and what, that would be much appreciated -- but no worries if not; I know you have important things to do!

Oh, maybe @ccall does compile now, that would be nice!
julia> using StaticCompiler, StaticTools

julia> function hello()
           s = c"Hello, world!\n"
           p = pointer(s)
           GC.@preserve s @ccall printf(p::Ptr{UInt8})::Cint
       end
hello (generic function with 1 method)

julia> compile_executable(hello, (), "./")
"/Users/cbkeller/hello"

shell> ./hello
Hello, world!

A few I noticed specifically: incorrect attributes (e.g. nocapture on putc), incorrect ABI (printf is varargs, ftell may return either i64 or i64* depending on the platform ABI, fputc takes an int, it is usually illegal to pass i16 directly to vararg functions like fprintf, malloc takes an Int not Int64, similar issues for memset)

Thanks!

#34 may (?) be enough to fix the pkgeval failures for now, but I'll leave this open until I get a chance to try switching to @ccall


how to add negative and positive to DC

i want to make an electrical circuit can you help me for it

This is very confusing because the line connecting DC and LED seems to be representing two wires: + going to LED and - going back. It would be nice if LED also had a positive and negative connector so we can see the positive and negative wires separately.

I don't think so.
It seems there one wire.

This simulator is NOT refer to GND.

This simulator is NOT refer to GND.

Ok I think @amitgadhiya and me want there to be GND.


Move to using pyusb instead of custom HID code

pyusb is available and easy to install on all platforms as far as I know.
In particular this would immediately allow compatibility with linux I think?
(I don't personally know much about USB protocols though)

Might be time to make this move. ioLabs bboxes are no longer working in PsychoPy 1.83.x (on mac at least). One major change as compared to 1.82 is (on mac) the move to 64-bit python. So moving away from the custom HID code might fix that (as well as support linux).


DryRun versus ProductionRun

Other than in the screenshot, the value of "ProductionRun" does not appear anywhere in this document. This is painful while doing any text search or search engine searching. Can an area be added describing "DryRun" versus "ProductionRun"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4fa0ebd3-8437-8508-5a8d-462186fcce80
Version Independent ID: efe892fe-387e-0a61-fe7d-33d2ac99dfa9
Content: Migrate from Azure DevOps Server to Azure DevOps - Azure DevOps
Content Source: docs/migrate/migration-import.md
Product: devops
Technology: devops-migrate
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@eponerine Thank you for the feedback, assigning this to the author for review.

@eponerine - Thank you for your request. I'm updating the article to clarify. The current section, Determine the type of import, does describe the differences between Dry run and Production run - but could be clearer in equating them to the parameters, DryRun and ProductionRun.


Regression in conditional type predicate

Bug Report
Search Terms: type assertion, type comparison, related to, generic parameter
Version & Regression Information: This changed between versions 4.7 and 4.8
Code: Playground Link
I discovered this issue in my PR #50454 when I am looking for a possible solution to the typing of Array.isArray.
Consider the following code:
declare function f0<T>(arg: T): arg is Extract<T, readonly any[]>;
declare function f1<T>(arg: T): arg is Extract<T, any[]>;
declare function f2<T>(arg: T): arg is {} extends T ? T & any[] : Extract<T, readonly any[]>;
declare function f3<T>(arg: T): arg is {} extends T ? T & any[] : Extract<T, any[]>;
declare function f4<T>(arg: T): arg is T extends any ? {} extends T ? T & any[] : Extract<T, readonly any[]> : never;
declare function f5<T>(arg: T): arg is T extends any ? {} extends T ? T & any[] : Extract<T, any[]> : never;
declare function f6<T>(arg: T): arg is T extends any ? Extract<T, readonly any[]> : never;
declare function f7<T>(arg: T): arg is T extends any ? Extract<T, any[]> : never;
declare function f8<T>(arg: T): arg is T extends readonly any[] ? T : never;
declare function f9<T>(arg: T): arg is T extends any[] ? T : never;
declare function fa<T>(arg: T): arg is {} extends T ? T & any[] : T extends readonly any[] ? T : never;
declare function fb<T>(arg: T): arg is {} extends T ? T & any[] : T extends any[] ? T : never;
declare function fc<T>(arg: T): arg is T extends any ? {} extends T ? T & any[] : T extends readonly any[] ? T : never : never;
declare function fd<T>(arg: T): arg is T extends any ? {} extends T ? T & any[] : T extends any[] ? T : never : never;
declare function fe<T>(arg: T): arg is T extends any ? T extends readonly any[] ? T : never : never;
declare function ff<T>(arg: T): arg is T extends any ? T extends any[] ? T : never : never;

function case1<T extends any>(a: T | T[]): T[] {
	return f(a) ? a : [a];
}
function case2<T extends unknown>(a: T | T[]): T[] {
	return f(a) ? a : [a];
}
function case3<T>(a: T | T[]): T[] {
	return f(a) ? a : [a];
}

In the above, f4 is the simplified version of the type I used in the PR.
Actual behavior:
From 4.8, the results vary from function to function. In case 3, an error occurs when f is f4 but not in case 1 and case 2 or the case when f is f2 where T is not distributed using T extends any.
Here is a table of whether a ts2322 error occurs in each cases:

f
Case 1
Case 2
Case 3

f0
🛑
🛑
🛑

f1
⚪
⚪
⚪

f2
⚪
⚪
⚪

f3
⚪
⚪
⚪

f4
⚪
⚪
🛑

f5
⚪
⚪
⚪

f6
🛑
🛑
🛑

f7
⚪
⚪
⚪

For the latter half, f(n+8) is simply fn with Extract expanded out, but I could hardly understand why the behavior changes:

f
Case 1
Case 2
Case 3

f8
🛑
🛑
🛑

f9
⚪
⚪
⚪

fa
⚪
⚪
⚪

fb
⚪
⚪
⚪

fc
⚪
⚪
🛑

fd
⚪
⚪
🛑

fe
🛑
🛑
🛑

ff
🛑
🛑
🛑

(Tested in v4.9.0-dev.20221020 and 4.8.4)
Prior to 4.8, ALL the cases passed:

f
Case 1
Case 2
Case 3

f0
⚪
⚪
⚪

f1
⚪
⚪
⚪

f2
⚪
⚪
⚪

f3
⚪
⚪
⚪

f4
⚪
⚪
⚪

f5
⚪
⚪
⚪

f6
⚪
⚪
⚪

f7
⚪
⚪
⚪

f8
⚪
⚪
⚪

f9
⚪
⚪
⚪

fa
⚪
⚪
⚪

fb
⚪
⚪
⚪

fc
⚪
⚪
⚪

fd
⚪
⚪
⚪

fe
⚪
⚪
⚪

ff
⚪
⚪
⚪

(Tested in 4.7.4 and 4.6.4)
(Note: some of the test functions above are for control (i.e. comparison) only.)
Expected behavior:
For each row, the results of case 1, case 2 and case 3 should be identical. (f4, fc, fd)
For each column, the results of fn and f(n+8) should be identical. (f5, fd, f7, ff)
I understand that some of them must be desirable changes, so I am not expecting the results to be the same between 4.7 and 4.8, but the mismatched results due to the absent of generic constraint are really weird.

Putting up a repro for the bisect bot
declare function f4<T>(arg: T): arg is T extends any ? {} extends T ? T & any[] : Extract<T, readonly any[]> : never;

function case1<T extends any>(a: T | T[]): T[] {
	return f4(a) ? a : [a];
}
function case2<T extends unknown>(a: T | T[]): T[] {
	return f4(a) ? a : [a];
}
function case3<T>(a: T | T[]): T[] {
	return f4(a) ? a : [a];
}

I believe the root cause here is that the implicit constraint of unconstrained generics behaves closer to { } | null | undefined than unknown, but don't have a good way to demonstrate that.

Absent a strong argument for any particular thing being a defect, I think the right answer here is just that unknown as the implicit default constraint isn't quite the right mental model, but rather its almost-synonym { } | null | undefined

@RyanCavanaugh Not sure if I interpret anything wrong, but writing T extends {} | null | undefined doesn’t give an error either (in fact extending anything silence the error – leaving #50454 aside, I think you’d like to make it raise errors (though without the error isArray could have been dealt a lot easier – that PR would (very likely) have been a solution in TypeScript 4.7.))
How about the cases with Extract expanded out? Could you please explain why it causes additional errors?


default-features = false with hyper-rustls fails

I had the following line in my Cargo.toml which failed to compile:
yup-oauth2 = { version = "11.0", default-features = false, features = ["hyper-rustls"] }

The error was the following:
error[E0425]: cannot find function `default_crypto_provider` in this scope
    --> /home/.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/yup-oauth2-11.0.0/src/authenticator.rs:1010
:45
     |
1010 |             .with_provider_and_native_roots(default_crypto_provider())?
     |                                             ^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `default_crypto_provider` in this scope
    --> /home/.../.cargo/registry/src/index.crates.io-6f17d22bba15001f/yup-oauth2-11.0.0/src/authenticator.rs:1030
:45
     |
1030 |             .with_provider_and_native_roots(default_crypto_provider())
     |                                             ^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

Simply removing the default-features = false solves the problem, it seems to be a conditional compilation issue.

Looking at the features, you have to decide between crypto libraries - either use ring or aws-lc-rs. Although I agree that an explicit build error would make users' lives easier at this point.


Fix Package function returning more than one item

This fixes issue #22 where Get-Package could return more than one item and incorrectly compare properties. This modifies the Package function to return the first item only.

It looks like this clobbers the fix in #24.

Ack! Git is hard 😀
I'll update the PR.

Actually this includes the fix for #22 which is just changing single quotes to double quotes. Should be safe to merge.


Bump ember-cli-mirage to 0.4.2

closes TryGhost/Ghost#9433

remove unnecessary bower deps
update mirage usage
fix tests

Took a bit longer than expected, but got this working as far as I can tell, minus some flaky tests. This will likely need a fairly significant update too once the multi-author stuff is merged in.

@kevinansfield it looks like tests are failing because of something in Koenig

Coverage increased (+0.02%) to 71.779% when pulling 71040cf54ad51307d4963d720893e103c549a608 on acburdine:update-mirage into fddf679a27d8898554f9a43ae7789532a555c8c8 on TryGhost:master.

@kevinansfield looks like the test errors were just me 😅. Added the tests back & updated some mirage serializers to handle the embedded record stuff, so this should be 👍now.


Use lowercase 'n' in 'no'

Most OpenSSH options take a value of yes or no (lowercase) according
to the man pages.
Having looked at the code with @rboulton, we don't think this will make
any difference, but it's good to be consistent:
https://github.com/openssh/openssh-portable/blob/V_6_6/readconf.c#L772
From http://linux.die.net/man/3/strcasecmp:

The strcasecmp() function compares the two strings s1 and s2, ignoring
the case of the characters.

Looks fine.

Interestingly @deanwilson and I have discovered the uppercase does appear to be a problem in at least some places:
2016-01-21T13:06:18Z: [mongo-licensify] /etc/ssh/ssh_config line 13: Bad yes/no argument.

Thanks @alexmuller :+1:
I've raised a PR to pull in this change in our Puppet repo: https://github.com/alphagov/govuk-puppet/pull/3982


2D CanvasModulate happens before light is applied, making light reset modulation

Godot version: 3.2.1 stable
Issue description: When Canvas Modulate is applied to scene, but Light2D is also used in scene in "Mask" mode (To apply transparency to show player when he's behind some objects), modulation of sprite is reset when it  gets in Light texture range.
Minimal reproduction project:
CanvasModulateBug.zip

Can confirm. Isn't to do with batching, this bug existed at least as far back as 3.1.2.


docs: upstream_rq_per_try_timeout with hedged requests

Per
https://github.com/envoyproxy/envoy/blob/5fd73ca889aa12618c626c96bb33fde4707f8bf0/source/common/router/router.cc#L869-L874
upstream_rq_per_try_timeout is not incremented for hedged requests.

@mpuncel @snowp

/retest-circle

Seems like CI is stuck, could you push an empty commit to restart it?

Seems like CI is really broken for this PR, could you create a new PR with the same change? Sorry for the inconvenience

/retest-circle


Confused - XRP to USD

I used the Trade function which looks like it is tied to bitstamp(I don't have a bitstamp account) but in the wallet it allowed me to sell some XRP for USD(US Dollar) now I am completely lost on how to get that US Dollar transferred into my bank account.
The only option I see in the wallet is to buy more ripple using US Dollar. I have been on multiple forums and nobody seems to understand the Ripple Desktop Wallet was this a mistake to use this thing?

Bump*****


build problems with 1.1.0b on windows

Hi,
In 1.0.2 build, we were using ms\do_ms.bat file to build OpenSSL,
perl Configure VC-WIN32 no-asm
CALL ms\do_ms

But with 1.1.0 version, do_ms.bat is missing. do_ms.bat was using pearl scripts from util folder, which are also missing in latest version.
Is the procedure to build OpenSSL is changed? If yes, where to find the steps?

Yes, the procedure has changed. See:
https://github.com/openssl/openssl/blob/OpenSSL_1_1_0-stable/INSTALL
and
https://github.com/openssl/openssl/blob/OpenSSL_1_1_0-stable/NOTES.WIN


invalid message length: timestamp not drained error

What language are you using?
Python
What version are you using?
0.3.0
What database are you using?
Postgres with mode="cursor"
What dataframe are you using?
Pandas
Can you describe your bug?
Give a high level description of the bug.
When running read_sql() via postgres connection with mode="cursor", multiple tables with a timestamp datatype fail to return data with an error message below. This happens when using return_type is pandas (line 224 in read_sql) or arrow/arrow2 (line 257 in read_sql).
What are the steps to reproduce the behavior?
Create a query string on a table with a timestamp in it, and execute the query via read_sql().
If possible, please include a minimal simple example including:
Example query / code
conn = f"postgres://{username}:{password}@{server}:{port}/{vdm}?sslmode=require"
query = """select [timestamp_col] from table"""

df = cx.read_sql(conn=conn, query=query, protocol="cursor")

What is the error?
Traceback (most recent call last):
  File "~/.../jdv.py", line 56, in query_jdv
    df = cx.read_sql(conn=conn, query=query, protocol="cursor", **kwargs)
  File "~/.../lib/python3.8/site-packages/connectorx/__init__.py", line 257, in read_sql
    result = _read_sql(
RuntimeError: error deserializing column 0: invalid message length: timestamp not drained

Hi @justbldwn , it seems like the error happens when the underlying client driver parsing the timestamp here.
Since we have timestamp type works fine in the CI test here with DDL defined here. Can you provide a simple example that could reproduce this error (including the DDL for table creation and insert some example data)?

hi, thanks for the response. after doing some digging, it appears the root cause most likely is coming from timestamp values we're storing in our database go into millisecond precision, which i'm not seeing in the CI test as possible options. even doing a query in something like select now() in our database fails via connectorx.
example timestamp:2022-09-30 14:45:19.191
seems like that timestamp in the buffer is eventually getting here and chopping off the first 7 characters:
remaining buffer: Ok(
    "30 14:45:19.191",
)

it'd be great if we could have support to use timestamps with this precision.

Ok, did far more research on this one than I should have (this turned out to be one of those fun ungoogleable errors).
I believe in our case we have 2 seperate bugs in our postgres wire format implementation causing this that are not the fault of connectorx (or even rust-postgres).

Our postgres implementation is returning a bytestring that can't be serialized to i64 when doing the TIMESTAMP serialization. That is because it returns the actual timestamp value as an ASCII bytestring.
Ex. 2022-10-01 11:27:00.446
This causes the parse code to chomp the year of the timestamp, which looks like an int, and then the parsing code complains that the buffer is not properly drained because the rest of it is actually a string! This is definitely UB and the main issue.

for now() our implementation also returns the timestamp in what appears to be local time but without timezone (it's at least local for me, need to verify this more thoroughly). Even when the parsing code is correct, the result of this is that the concrete rust type we get back when round tripped is in a different timezone than the raw string from the database (I'm still not convinced there might not be a parsing bug w/ chrono here). While this phenomenon was initially noticed w/ now() it's still an annoyance for  all other TIMESTAMP columns.

via cargo-patch I was able to hack something together that appears to give us the desired behavior, but I highly doubt it is upstream-able:
diff --git a/postgres-protocol/Cargo.toml b/postgres-protocol/Cargo.toml
index a471690..5f507fa 100644
--- a/postgres-protocol/Cargo.toml
+++ b/postgres-protocol/Cargo.toml
@@ -19,3 +19,6 @@ memchr = "2.0"
 rand = "0.8"
 sha2 = "0.10"
 stringprep = "0.1"
+chrono = "0.4.22"
+time = {version = "0.3.14", features = ["std", "large-dates", "parsing"]}
+log = "0.4"
\ No newline at end of file
diff --git a/postgres-protocol/src/types/mod.rs b/postgres-protocol/src/types/mod.rs
index 05f515f..d66f6b9 100644
--- a/postgres-protocol/src/types/mod.rs
+++ b/postgres-protocol/src/types/mod.rs
@@ -1,12 +1,16 @@
 //! Conversions to and from Postgres's binary format for various types.
 use byteorder::{BigEndian, ByteOrder, ReadBytesExt};
 use bytes::{BufMut, BytesMut};
+use chrono::{DateTime, Local, TimeZone};
+use chrono::NaiveDateTime;
+use log::debug;
 use fallible_iterator::FallibleIterator;
 use std::boxed::Box as StdBox;
 use std::error::Error;
 use std::io::Read;
 use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
-use std::str;
+use std::ops::{Add, Sub};
+use std::str::{self, FromStr};

 use crate::{write_nullable, FromUsize, IsNull, Lsn, Oid};

@@ -373,11 +377,23 @@ pub fn timestamp_to_sql(v: i64, buf: &mut BytesMut) {
 ///
 /// The value represents the number of microseconds since midnight, January 1st, 2000.
 #[inline]
-pub fn timestamp_from_sql(mut buf: &[u8]) -> Result<i64, StdBox<dyn Error + Sync + Send>> {
-    let v = buf.read_i64::<BigEndian>()?;
-    if !buf.is_empty() {
-        return Err("invalid message length: timestamp not drained".into());
-    }
+pub fn timestamp_from_sql(buf: &[u8]) -> Result<i64, StdBox<dyn Error + Sync + Send>> {
+    let s = str::from_utf8(buf).map_err(|_| "invalid timestamp")?;
+    debug!("raw datestring: {s}");
+    // write a format string for 2022-09-30 14:45:19.191
+    let fmt: &str = "%Y-%m-%d%_H:%M:%S%.3f";
+    // parse the timestamp into a naive date time with format
+    let naive = NaiveDateTime::parse_from_str(
+        s,
+        fmt,
+    )?;
+    // adding a 8 hour offset because parsing is weird and I don't know why
+    let naive = naive.add(chrono::Duration::hours(8));
+    // convert the naive date time to a chrono date time
+    let local: DateTime<Local> = Local.from_local_datetime(&naive).unwrap();
+    // substract 30 years in milliseconds to convert from unix epoch to postgres epoch
+    let v = local.sub(chrono::Duration::milliseconds(946728000000)).timestamp_micros() as i64;
+    // return in microseconds
     Ok(v)
 }

To replicate this I just ran the query:
select now();

Even if 1) could be fixed on our end (it likely can't), we'd need to rely on some custom parsing logic to solve for 2). I think the easiest solution is to tell our users to cast to string and rely on their dataframe library of choice to do timestamp coercion.


fix: Add hacktoberfest label to the repo

Describe the bug
I noticed that the repo is missing the hacktoberfest label. It would be more convenient for contributors to find this awesome repo if you add the label
Screenshots

Additional context
I'd love to add my cool components here after this bug is fixed. Thanks!

Describe the bug I noticed that the repo is missing the hacktoberfest label. It would be more convenient for contributors to find this awesome repo if you add the label
Screenshots
Additional context I'd love to add my cool components here after this bug is fixed. Thanks!

Hello I have added the label. You can start creating new issues from 1st Oct. Thank you !

I am closing the issue for now but you can surely open new ones .


chore(firebase_auth_web, firebase_ui_localizations): Upgrades intl to 0.18.0

Description
Upgrades intl to version 0.18.0 in all packages
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

@Rexios80 You'll have to update/fix the failing tests before review. Thanks

Pretty sure things are failing because of flutter 3.7 deprecations which is outside the scope of this PR to fix unless you want it done here

We've attempted this before. If the SDK relies on version 0.17, then we aren't able to proceed as far as I can tell.

This should be possible when this issue closes: https://github.com/flutter/flutter/issues/117163

Currently there seems to be 3 opened PRs attempting to bump the version of intl, maybe we should focus on one of them and mark the others as duplicated?

#10416
#10443
And this one

Anyway, I just want to propose to relax the version of intl to >=0.17.0 <1.0.0 given that there aren't breaking changes from 0.17.0 to 0.18.0 and to assume that no breaking changes would be released in minor version updates.
When intl releases 0.19.0, the exact same issue will hit again and the proposed range version should get around with it. Also see this related issue on Pub about version resolving for 0.x.x versions.
If we don't feel safe for minor releases of intl, can we at least set the version to >=0.17.0 <0.19.0 so that the Firebase packages will work for both 0.17.0 and 0.18.0?
I currently have a project that also uses intl and I'm having version resolve issues with a lot of the other packages that also use intl. So I would appreciate if a ranged version is used here so that I can gradually transition with the dependencies upgrade on my project while waiting for all the packages to also support the latest version of intl.

Minor version changes on version 0.x.x are treated as breaking changes. We cannot assume that version 0.19.0 won't have breaking changes, because that's not how the versioning system is designed. What probably needs to happen is that intl needs a 1.0.0 release so that minor version changes aren't treated as breaking, but that is well outside the scope of this repo.
We could have a constraint that includes both 0.17.0 and 0.18.0, but that's probably not worth it since the issue right now is not supporting 0.18.0. This is just a growing pain with 0.18.0 that when resolved won't matter anymore.
If you're having issues with the intl version in your projects, just add it to the dependency_overrides for now:
dependency_overrides:
  intl: ^0.18.0

If there were actually no breaking changes, this will solve your dependency resolution issues.

https://github.com/dart-lang/intl/issues/522#issuecomment-1445123838

Seems we are still waiting on a flutter release with flutter_localizations that uses intl: 0.18.0

Now CI is failing because of Flutter 3.10 changes. Waiting on https://github.com/firebase/flutterfire/pull/10944

This should have been dealt with in https://github.com/firebase/flutterfire/pull/10944


superflat

this mod works perfectly on all of my worlds but i noticed it doesnt on superflats, not sure why

Huh, that’s odd. I never even thought to test it on flat worlds but I’m also able to recreate this so I’ll look into it.

I looked into it and this also happens in 1.12. It’s because the chunk animation is starting at where it’s ending - so they just appear without any animation.
If you change the mode to 1 you will see that the animation works fine, and the chunks fall out of the air.
A simple solution is to just force mode 1 if the player is on a flat world, or I could force the animation to start from a lower value on a flat world.
However I’ve now found that because of the way Minecraft renders chunks (I won’t even try to explain why lol), setting the animation to start lower doesn’t help, so I think the best option here (at least unless I or anyone else can find a way around this, but I don’t think it’d be worth the time) is to force mode 1 on flat worlds.

FYI this (sort of) fix was removed (see #9). If you want a way to use flat worlds and have the animation work use one of the flat world presets where the ground is higher.


Change kuttl tests to run in any namespace

Modify the kuttl tests so that they can run in any namespace, not just
in the openstack one. This requires removing any mention of the
namespace in the asserts and using the $NAMESPACE variable in scripts
instead of the namespace name.
Needs https://github.com/openstack-k8s-operators/install_yamls/pull/410 to be
merged for CI to pass.

Merged https://github.com/openstack-k8s-operators/install_yamls/pull/410
/test cinder-operator-build-deploy-kuttl


Remove hit detection transforms from ol/renderer/webgl/PointsLayer

replaces #9729

Should these transforms be used to address #9736 (or is this change otherwise related to that problem)?

Should these transforms be used to address #9736 (or is this change otherwise related to that problem)?

I think transforms already take the pixel ratio into account so the fix for this lies elsewhere IMO.


Example for route mirroring policy

Commit Message: Example for route mirroring policy
Additional Description: Add a sandbox for route mirroring policy
Risk Level: Low
Testing: Manual/verify script
Docs Changes:
Release Notes: New sandbox for route mirroring policy
Platform Specific Features:
Fixes: https://github.com/envoyproxy/envoy/issues/23119

thanks for working on this @asaha123
first pass review inline ...

Thanks @phlax - pushed a few changes addressing most of the points mentioned.

@asaha123 copying out the advice from CI:

  Please fix your editor to ensure:

      - no trailing whitespace
      - no preceding mixed tabs/spaces
      - all files end with a newline

if you can fix up the formatting and address the remaining issues from previous feedback (remove curl and run composition as a daemon) ill review again
/wait

should we consider adding this case to the logging or document to note for the end users?

During shadowing, the host/authority header is altered such that -shadow is appended. This is useful for logging. For example, cluster1 becomes cluster1-shadow.

But I think the default log should have the authority value, ref: https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log/usage#default-format-string

should we consider adding this case to the logging or document to note for the end users?

During shadowing, the host/authority header is altered such that -shadow is appended. This is useful for logging. For example, cluster1 becomes cluster1-shadow.

But I think the default log should have the authority value, ref: https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log/usage#default-format-string

@nguyenptk not quite sure what you are proposing? Do you suggest we enable logging in envoy and attempt to demonstrate the above behavior?

@asaha123 copying out the advice from CI:
  Please fix your editor to ensure:

      - no trailing whitespace
      - no preceding mixed tabs/spaces
      - all files end with a newline

if you can fix up the formatting and address the remaining issues from previous feedback (remove curl and run composition as a daemon) ill review again
/wait

Thanks @phlax - I am not sure I understand this specific error:

2022-10-04T04:07:16.4082857Z ERROR (validation failed): examples/route-mirroring/front-envoy.yaml
2022-10-04T04:07:16.4084525Z Failed to parse static_resources field: Failed to parse listeners field: Failed to parse filter_chains field: Failed to parse filters field: Failed to parse virtual_hosts field: Failed to parse routes field: Failed to parse requ

Any ideas?

@phlax Locally running ./ci/verify-examples.sh route-mirroring works - i  tried a few times. However, it failed in CI:

2022-10-05T03:55:34.8879288Z run_examples@ /home/vsts/work/1/s/ci/verify_examples.sh :39 (./route-mirroring)
2022-10-05T03:55:34.8879887Z   > main@ /home/vsts/work/1/s/ci/verify_examples.sh :44
2022-10-05T03:55:34.9830228Z ##[error]Bash exited with code '1'.

Any suggestions for troubleshooting? Thanks!

i ran this locally by doing the following...
$ docker-compose up --build -d
$ curl http://localhost:8080/service/1
$ curl http://localhost:8080/service/2
$ docker-compose logs service1-mirror
$ docker-compose logs service2-mirror

only the first call to the logs had the expected entries - not sure why but currently it seems that the service2 route is not working as expected - running with verify.sh also failed
i guess im wondering if the service2 route is necessary - whether it is showing anything different from the first route

@asaha123

Do you suggest we enable logging in envoy and attempt to demonstrate the above behavior?

Yes, I do. I think we need to demonstrate this behavior -shadow in access_log in Step 4: See Logs of document.

i ran this locally by doing the following...
$ docker-compose up --build -d
$ curl http://localhost:8080/service/1
$ curl http://localhost:8080/service/2
$ docker-compose logs service1-mirror
$ docker-compose logs service2-mirror

only the first call to the logs had the expected entries - not sure why but currently it seems that the service2 route is not working as expected - running with verify.sh also failed

You will need to specify the expected cluster header for the call to /service/2 for Envoy to send the request to service2-mirror and hence for the logs to show.

running with verify.sh also failed

That is strange. It works on my box :(

i guess im wondering if the service2 route is necessary - whether it is showing anything different from the first route

Yes, to demonstrate the usage of cluster_header to select the mirror cluster, I use service2 as I believe, it keeps things separate nicely - service1 for static mirror cluster and service 2 for cluster header based mirror cluster.
Hope that makes sense?

Any suggestions for troubleshooting? Thanks!

most likely permissions
CI tests in an env with chmod -og to simulate having a strict umask set

@asaha123

Do you suggest we enable logging in envoy and attempt to demonstrate the above behavior?

Yes, I do. I think we need to demonstrate this behavior -shadow in access_log in Step 4: See Logs of document.

@nguyenptk I made an update in https://github.com/envoyproxy/envoy/pull/23336/commits/df760cf1705ab1f6279187a4e69bede611f86417 to verify the Host header in the application.
I believe that's sufficient?

still fails locally when run with ./verify.sh script - and at the same place that its failing in CI - looks like something to do with the port assignments - ill review now

Green build! :rocket:

Green build!

passes locally also now
/docs

seems to work in CI - not sure if its because your machine is faster or slower - does this happen with any other sandboxes ?

seems to work in CI - not sure if its because your machine is faster or slower - does this happen with any other sandboxes ?

Not sure..:( I am just a bit surprised that it is consistently passing in CI and almost consistently failing locally for me.
I did see the same behavior locally on another sandbox i tried.

I did see the same behavior locally on another sandbox i tried.

which sandbox ?
im wondering what is specific to your environment - i looked at the composition and all looks good - i had confidence in this pattern as it has always worked for me locally and noone has reported any errors
that said, the composition doesnt actually wait for envoy to be ready - it just relies on the fact that envoy starts quick enough it always is (/has seemed to be)
there is no way in docker-compose to tell it to wait for a service that is not depended upon by any other service to be healthy - the workaround is to add a stub service that does wait for the last container/s to up and then exits

possibly related - i saw a CI flake today in the front-proxy example that looked as tho the cause was envoy not being ready
not sure if envoy startup has slowed down recently - that particular sandbox needs some work anyhow, so could be unrelated

@phlax I believe, it was the jaeger-tracing sandbox.
I would be happy for you to merge this PR as it is, as the wait_for issue is not specific to this example as you have mentioned in https://github.com/envoyproxy/envoy/pull/23336#issuecomment-1279143845

I would be happy for you to merge this PR as it is,

i think we need a little more work on the docs - ill review now
re the more general sandbox issue im keen to track that down so would be good to follow up - if you are around on the Envoy slack we could probably test some things out quite easily

re the more general sandbox issue im keen to track that down so would be good to follow up - if you are around on the Envoy slack we could probably test some things out quite easily

sure. what timezone and hours are you online usually? I am not in slack, but I can join the channel during UTC+11 daytime hours

@phlax

one question i have is about responses - im assuming that responses are just ignored from the mirror and that the returned response is always that of the primary service - wondering if we need to say that somewhere explicitly

the other thing im thinking that would be quite helpful are a couple of additional steps showing a request to the dynamic mirror omitting the mirror header and possibly referring to a non-existent cluster

yes, agree.
Also ready for your review now again!

I am not in slack, but I can join the channel during UTC+11 daytime hours

if you join and ping me (@phlax) i can respond when online

@phlax I have addressed the comments.

once we have got the docs down we will need to revisit the ./verify.sh script to ensure its testing the correct steps

Step 6 - non-existent or wrong cluster header is not covered by the script as it stands now.
If you think it's useful to add that, what I can think of is using a specific URL to send to service 2 and check that the request is not received by service2-mirror.

@phlax no worries at all! I have found your suggestions very useful and helped me improve the sandbox documentation.
Addressed the last suggestions.

@asaha123 would you mind addressing https://github.com/envoyproxy/envoy/pull/23336/files#r1007144206
atm, the grammar is slightly incorrect - thanks - then we should be gtm

@phlax thank you, is there anything for me to look at related to the failure/

no i think it was just an existing flake
/retest

Thanks @phlax for all the help!


Schema Registry UI Does Not connect to Confluent Schema Registry over SSL

Url : https://xxx-axxxxxsr0101:8443 CONNECTIVITY ERROR
Global Compatibility level :
schema-registry-ui: 0.9.4
I have installed 3 Schema Registry and when I connect the UI with one of the Schema Registry server it fails.

Do you use the docker image?


[Maintenance] Drop Sylius 1.10 support

Q
A

Branch?
master

Bug fix?
no

New feature?
no

Related tickets
-

Thank you, Jakub! 🎉


Not a Traccar problem but....

I came across this weird problem for the first time ever and it has nothing to do with Traccar but I just thought I should mention
I created a simple html page and the page does an ajax call in the document ready event. The ajax call is to just post the current timestamp to my database. When I open / refresh the page in a browser, then record gets posted to the database perfectly fine
Then I set up the forward url in Traccar and the url is a link to the above page that is running on lighttpd server. I set the extended logging on lighttpd and here comes the surprise - I can see from the logs that Traccar is calling the URL and lighttpd is processing the request correctly but the ajax call just doesn't post the record.

I installed NGINX and tried the same thing. In the log file the call from Traccar to the URL shows
<IP_ADDRESS> - - [24/Mar/2016:03:18:35 +0000] "GET /simpleajaxpage.html?id=358511020511243 HTTP/1.1" 200 1219 "-" "AHC/1.0"
<IP_ADDRESS> - - [24/Mar/2016:03:21:35 +0000] "GET /simpleajaxpage.html?id=358511020511243 HTTP/1.1" 200 1219 "-" "AHC/1.0"

And when I directly open the link in the browser, this is what I see in the log
<IP_ADDRESS> - - [24/Mar/2016:03:23:09 +0000] "GET / HTTP/1.1" 200 703 "-" "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36"
<IP_ADDRESS> - - [24/Mar/2016:03:23:09 +0000] "GET /js/url.min.js HTTP/1.1" 304 0 "http://<IP_ADDRESS>:8086/" "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36"

You need to compare headers. There must be some difference there that causes the problem.

alright thanks...let me investigate it further
Cheers,
M.M

He probably figured out what header was the cause. Issue can be closed.


Add a goal to do an SQL backup before the migration

Original author<EMAIL_ADDRESS>(March 21, 2012 08:12:49)
It would be great if flyway could do an SQL backup of the database before the migration.
With the maven plugin, the backup file should be saved by default in the target directory.
In the same idea, an option or goal to execute the backup if the migration failed (with a truncate before ?).
A third parameter to failed the maven build or not if the migration failed and the backup was execute without error. By default, the build should failed if the migration failed.
Original issue: http://code.google.com/p/flyway/issues/detail?id=233

This should now be possible with callbacks and some custom code. Closing.


New release for updated dependencies

v0.14.2 was released about a month ago, but is now behind recent dependency updates.
Please release a new version (and don't forget to push the tag!)

The new release is published and the tag pushed!


rli template repos also include usefull info and setups

Should this repo also be a github template repo? It would be nice to make it easy to create a new repo based on this one.
How this repo will be different from the other template repos? Should we focus here on setting up tests and code CI as well
as code continuous delivery methods?

@jh-RLI I can't assign anyone to this issue

While the rli_template is focusing on technical stuff, this repo starts with the collaborative and community features. I would rather go step by step and first setup an a proper scientific documentation before adding technical features.
Your help on #4 is welcome!

@Ludee I can't assign anyone to this issue

I updated the user rights, please check again.

Works now :)

That sounds great, I just wanted to make sure we don't overlook the work that has already been done in the other repos. As I work on my master's thesis, I'm adding my research on these topics  (we discussed this already).


Upgrade macOS version in GitHub Actions

Description of changes:
No changes to Kani itself. Because macOS 10.15 is being deprecated in GitHub Actions, this upgrades our regression workflows to macOS 11.
Call-outs:

Testing:

How is this change tested? Testing in CI.

Is this a refactor change? No.

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[x] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Oh, just a thought: maybe we should hold off on this until after the release tomorrow.

I'm fine with this without this, but I think the thing I vaguely found but didn't investigate was MACOSX_DEPLOYMENT_TARGET

Sorry @tedinski , I don't understand this comment. Were you trying to highlight some code there?

Oh, just a thought: maybe we should hold off on this until after the release tomorrow.

Sure, no problem.


Accessibility update color contrast

issue https://github.com/kubeflow/blog/issues/101

after fix

Color, almost do not differ from what it was
/assign @james-jwu

cc @james-jwu


Move RequestServer into isolated plugin

What was wrong?
It is our long term plan to have the RequestServer, the PeerPool and the Sync run in their dedicated isolated processes. The benefits are:

The PeerPool will be free from any CPU intensive work (e.g. block verification etc)
Leverage multiple CPUs better
Have pieces be more reusable (e.g RequestServer plugin can be used for beacon node)
Have each process be a better performance analysis target via py-spy
???

Currently, these three things are still together in one process that is so far know as the networking process.
How was it fixed?

Upgraded to unreleased Lahja version that enables us to broadcast on a higher frequency (by reducing unnecessary cross process propagation when it isn't needed)
Exposed the relevant peer messages on the event bus
Created ProxyPeer classes that allow to forward actions to the actual peers in the peer pool
Created a new IsolatedRequestServer that consumes relevant peer pool messages via event bus and uses proxy peers to communicate back responses
Created a new isolated plugin that runs the isolated request server

To-Do

[x] Clean up commit history

[ ] Add entry to the [release notes PR](https://github.com/ethereum/trinity/pulls?
q=is%3Aopen+is%3Apr+label%3A%22Release+Notes%22)
[x] Run BCCRequestServer via the same plugin
[ ] Release new Lahja and update setup.py

Cute Animal Picture

@pipermerriam This can be given a full review now. It is still blocked on the upcoming lahja release but other than that it has passed my own judgement :)

Just in case anyone wants to review this, hold back, I'm testing some things out to fine tune this.

(sorry for the too-soon review.  I just saw your request to hold off)

Ok, still missing some async with...on it

Looks like you are debugging something, but it seems good to go. Feel free to re-ping me if the solution you end up with needs review, too.

I think, the test that scans the shutdown for errors (which is currently a xfail) got more flaky because, somewhat ironically, the shutdown became more stable with the upgrade to a newer lahja release.
I marked the test as skip for now just because I really want to get this in now and it is 1 AM here. I swear it's the first thing I pickup tomorrow morning to resolve it properly :pray:


Empty figure.caption causes the compiler to panic

Description
Error:
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', /home/user/.cargo/git/checkouts/typst-6808799b0d8fdaa9/360cc9b/crates/typst-library/src/meta/figure.rs:515:19

Reproduction code:
#figure.caption[]

Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

This isn't actually related to being empty. Whenever you call figure.caption on its own, supplement isn't set, so it fails. But you can't pass supplement as a parameter. One possible way to fix this would be to make it impossible to call figure.caption manually, since it's really only there for show/set rules.

I'll look into this and other possible occurrences in sub-elements.


Hitting CapsLock in a field shows 'CapsLock'

Several other special keys similarly.
The problem is this code in AbstractField which was added as part of #211 (pasting into a field).

How can we distinguish between a single keypress that has a multi-character label, and multiple characters (from a paste)?

Now covered under #211


[kernel] move Simulation::prepareIntegratorForDS to NSDS::setOSI taking Model param

This is an alternative suggestion to PR #166, a different proposal for #142.  It's a lot more similar to what we had before, except that NSDS::setOSI calls both Topology::setOSI and OSI::initializeDynamicalSystem(), instead of doing it in the SImulation.  This means NSDS::setOSI requires the Model, similar to #166, but it means the DS/OSI link can be set up without creating the Simulation prior, as originally.  It's exactly like calling Topology::setOSI, but with the additional guarantee that OSI work vectors will be initialized.
As mentioned in #142, ZeroOrderHoldOSI::initializeDynamicalSystem requires the Model, an example of why it can't be removed as a parameter, so here instead it is added as a parameter to setOSI.  I also add the OSI as an optional parameter to NSDS::insertDynamicalSystem, so that a DS can be inserted and assigned an OSI in one line, which is the typical use case for multi-OSI examples.

Closed without merge in favour of #166


bumping js-slang

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.302%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4964

Relevant Lines:
12805

💛  - Coveralls


Fix lookup into macros that can introduce members into types and extensions

Fix and improve lookup for macro-introduced members within types and their extensions:

Find members introduced by peer macros within extensions (before, they only worked within nominal type definitions)
Find members introduced by member macros on extensions (before, they only worked on nominal type definitions)
Only expand member macros during name lookup if they can produce the name in question.
Avoid reference cycles for freestanding macros by using the simpler macro resolution approach we've employed for attached macros
Ensure that we instantiate member and peer macros for extensions and members thereof before visible name lookup

@swift-ci please smoke test

The Observation failure was a useful one; I've now fixed an issue with compound names dodging macro expansions.

@swift-ci please smoke test