ci: add pr-agent

PR Type
configuration changes, enhancement

Description

Added a new GitHub Actions workflow named PR Agent Bot.
Configured the workflow to trigger on pull request events such as opened, reopened, and ready for review.
Set conditions to exclude bot actions and PRs with specific titles.
Included steps to run the PR Agent action using the Codium-ai/pr-agent repository.

Changes walkthrough 📝
Relevant filesConfiguration changes

pr-agent.yamlAdd GitHub Actions workflow for PR Agent Bot

.github/workflows/pr-agent.yaml
Added a new GitHub Actions workflow for PR Agent Bot.  Configured the workflow to trigger on pull request events.  Set up job conditions to exclude bots and specific PR titles.  Included steps to run the PR Agent action using Codium-ai/pr-agent.

+24/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

cool!


Sampling from GeneratorHubInterface does not generate anything

🐛 Bug
When function sample from hub_utils.GeneratorHubInterface, as specified in the language modeling readme, the result is always the same prefix passed as argument to the function, with no extra tokens sampled from the LM.
Internally, the problem is that, when the sentence is converted to token IDs, the EOS token ID is added. When the model is presented with a prefix that "has already ended", it just generates another EOS and finishes.
To Reproduce
Just follow the code to sample from an LM from the language modeling readme.
Code sample
from fairseq.models.transformer_lm import TransformerLanguageModel
custom_lm = TransformerLanguageModel.from_pretrained('/path/to/model/dir', 'checkpoint100.pt')
custom_lm.sample('Barack Obama', beam=1)

Expected behavior
The returned sampled sentences have more tokens apart from the ones already supplied as argument to sample.
Environment

fairseq Version: master:
PyTorch Version: 1.4.0
OS: Ubuntu 16.04.2 LTS
How you installed fairseq: from source
Python version: 3.7.4
CUDA/cuDNN version: none
GPU models and configuration: none

I would be happy to provide a PR.

same issue

I got a similar issue here, I copied the code from template: https://github.com/pytorch/fairseq/tree/master/examples/language_model
lm.sample('Barack Obama', sampling=True, sampling_topk=10, temperature=0.9)
>>> "Barack Obama"

It won't generate any longer sentence except 'Barack Obama'.

Ah, thanks for flagging. I mistakenly broke this in 7c0ab23d14882d77ae5017ee71085925c5c03373.
Will submit a fix shortly.


History page, minor patch

A set of changes from the #GLAMhack event:

Improved history page, with gallery photos and tidier layout
Dependency updates

Codecov Report

Merging #318 (6945303) into main (1c235a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   48.64%   48.64%
=======================================
  Files          40       40
  Lines        3955     3955
=======================================
  Hits         1924     1924
  Misses       2031     2031

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


remove conversation subheading, replace with showing the user type

👀 Overview
This is me rejigging some work I've just done to add a conversation subheading. Instead of a subheading for the conversation, we're showing the user type beneath each author if required.
✅ Checklist

[ ] Tests written
[ ] Browser tested
[ ] Added to documentation
[x] Added to storybook

 Tell people that a guest user has made the comment


MAINT, CI: remove custom mingw Azure

we no longer need the custom install of
mingw 64-bit in Azure CI for Windows builds
because of upstream toolchain updates

this download task consumes valuable time (~2-5 minutes)
and is a source of errors for failed connections
sometimes, so remove it and use the pre-installed
mingw, which is automatically on PATH

the remaining mingw PATH adjustments should
only have en effect for 32-bit builds and shouldn't
be harmful for 64-bit builds where they'd presumably
start pointing to an empty path or simply the
default installed path for mingw (can probably
be cleaned up later)

I can't tell if the other Azure jobs will show up yet--maybe behaving strangely because of our new backlog and/or because the same branch in my fork.. I'll wait a bit and see..

Thanks Tyler!

Awesome! So just to be clear: what changed upstream is that a version of MSVC that works for us is already installed?

I think the mingw version pre-installed in Azure hasn't changed.
I believe it is because OpenBLAS is now built with a newer gcc/gfortran toolchain so we don't have to install a custom/ancient mingw to link/build with.
@mattip will know for sure--I'm pretty sure the gcc toolchain bump happened for a few different reasons. More platform support coming, newer base CentOS/multilinux support in the pipeline, etc.


Update to Quarkus 3.13.2 (but not to new test resource annotation)

What this PR does:
Updates Quarkus dep to latest (3.13.2) without yet updating to new test annotation, since that seems to cause breakage. Will convert test annotations as follow-up.
Which issue(s) this PR fixes:
Fixes #2968
Checklist

[x] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

This was the first part: second is #2986 .


Lowtherville IOW

Lowtherville is entered in teh Gazetteer as both HAM and IOW.
Please move the search records from Lowtherville HAM to the IOW entry and remove the HAM entry.
Geoff

Done


[v1.1.4] Herald plugin not loading

Hi,
I'm using v1.1.4 and noticed today that Herald plugin is not listed when starting Observatory and Herald voice notifications are not working. The DLL is in the plugin folder, I've tried reinstalling Observatory and built-in voice notifications work fine.
Yesterday, Herald was working properly.

You might want to check the Discord, Herald has been disabled in the last 48 hours due to large API usage costs to the dev, you can still use the default TTS.  May be only temporary whilst its looked into, not sure, Discord will have more info

https://forums.frontier.co.uk/threads/elite-observatory-search-your-journal-for-potentially-interesting-objects-or-notify-you-of-new-ones-on-the-fly-while-exploring.521544/post-10485312


Can’t get mods working on NV

Sorry I’m new to Linux and modding in general, I’m trying to get mods/NVSE working for new Vegas but nothing seems to be working even after using the post deploy

Sorry I’m new to Linux and modding in general, I’m trying to get mods/NVSE working for new Vegas but nothing seems to be working even after using the post deploy

I found the issue in the post deploy script I believe. Looks like some of the code wasn’t switched from Fallout 4 to Fallout New Vegas.
If no one else fixes it I’ll try fixing it tonight and give it a test and commit a new merge for pikdum to approve.

Pushed a pull request for merge. I have never modded any of the fallouts so can't say that'll fix the issue.
However hoping it does!

Merged @SirStig's PR, so it should work now after updating.

Thanks I got mods working as far as I can tell but I can’t get my game to read a FalloutCustom.ini folder I need for a mod. Not sure if it’s a user error on my end

Copied the files over, now the game won’t even load currently since it’s stuck on an infinite loop of what I assume is loading plugins. Not sure if I have to do a reinstall of the entire game

Are you launching it from Steam Deck's game mode or from Vortex?

If there’s any issues with dependencies from the mods I’d recommend using STL (SteamTinkerLaunch) to launch the game and go to the winetricks part to install them.

c++ redistributable

Is there  a correct way to install the c++ redistibutable on steam-deck other than adding it to steam as a non-steam game and running it?

I usually use protontricks to run the .exe. Can install the flatpak pretty easily on Steam Deck.

Thank you

Going to go ahead and close this. Feel free to open a new issue if anybody is still having issues.


Examples about highlight data?

Hi,
Anyone have examples about highlight data?
1 - Paint all highlight data with selected color?
2 - Detect when user highlight a text to show a custom view?
3 - Detect when user click on a highlighted text to show current options or remove?
As i do on other issues that i ask, i will post my final code here. But i need some way to understand it. I check the reader_view code and all highlight references, but didn't find anything.
Something like this:

And this:

Thanks.

"highlight" plugin code:
https://github.com/readium/readium-shared-js/tree/develop/plugins/highlights
https://github.com/readium/readium-shared-js/blob/develop/plugins/highlights/views/view.js#L7
template: "

",

https://github.com/readium/readium-shared-js/blob/develop/plugins/highlights/views/border_view.js#L7
template: "

",

https://github.com/readium/readium-shared-js/blob/develop/plugins/highlights/manager.js#L345
    this.getAnnotationsElementSelector = function () {
        return 'div.rd-highlight, div.rd-highlight-border';
    };

Main public API (from which the "manager" instance can be accessed):
https://github.com/readium/readium-shared-js/blob/develop/plugins/highlights/main.js#L42
Example usage from readium-js-viewer:
https://github.com/readium/readium-js-viewer/blob/develop/src/js/EpubReader.js#L851
        $(".icon-annotations").on("click", function () {
            readium.reader.plugins.highlights.addSelectionHighlight(Math.floor((Math.random()*1000000)), "test-highlight");
        });

https://github.com/readium/readium-js-viewer/blob/develop/src/js/EpubReader.js#L1167
readium.reader.plugins.highlights.initialize({
                        annotationCSSUrl: readerOptions.annotationCSSUrl
                    });

                    readium.reader.plugins.highlights.on("annotationClicked", function(type, idref, cfi, id) {
        console.debug("ANNOTATION CLICK: " + id);
                        readium.reader.plugins.highlights.removeHighlight(id);
                    });

Note that annotationCSSUrl references https://github.com/readium/readium-js-viewer/blob/develop/src/css/annotations.css


CreationException: Unable to create injector

Newest deadbolt snapshot:
CreationException: Unable to create injector, see the following errors:

1) No implementation for be.objectify.deadbolt.java.cache.HandlerCache was bound.
  while locating be.objectify.deadbolt.java.cache.HandlerCache
    for parameter 3 at be.objectify.deadbolt.java.ViewSupport.<init>(ViewSupport.java:70)
  at be.objectify.deadbolt.java.DeadboltModule.viewSupport(DeadboltModule.java:48):
Binding(class be.objectify.deadbolt.java.ViewSupport to self in interface javax.inject.Singleton) (via modules: com.google.inject.util.Modules$OverrideModule -> play.api.inject.guice.GuiceableModuleConversions$$anon$1)

1 error

Did you create and expose your own HandlerCache implementation as in the quickstart guide?

No, I just use cache-user=true as before
24 cze 2015 08:11 "Steve Chaloner"<EMAIL_ADDRESS>napisał(a):

Did you create and expose your own HandlerCache implementation as in the quickstart
guide
https://github.com/schaloner/deadbolt-2-java/blob/master/QuickStart.md?
—
Reply to this email directly or view it on GitHub
https://github.com/schaloner/deadbolt-2/issues/63#issuecomment-114741338
.

No, I just use cache-user=true as before
Is it necessary to create own implementation?

I see that in version 2.4.0 there is no class that implements be.objectify.deadbolt.java.cache.HandlerCache
Is it on purpose?

Yes, because it means reflection doesn't have to be used to create instances of handlers; it gives you a lot more flexibility.
You can see an example here: https://github.com/schaloner/deadbolt-2-java-examples/blob/master/app/security/MyHandlerCache.java

I see that in version 2.4.0 there is no class that implements be.objectify.deadbolt.java.cache.HandlerCache
Is it on purpose?

See also this discussion: https://groups.google.com/d/topic/play-framework/KZcCdbWZXvQ/discussion

OK, so If I understood it well - custom HandlerCache is required now?

Yes.  This also provides info and background: https://github.com/schaloner/deadbolt-2-guide/blob/master/manuscript/04-deadbolt-java-hooks.md

OK, understood.
Snapshot was working fine without custom Cache, that is why I was a little bit confused.
Thank you for helpful links. With custom cache it works fine


Issues with push notifications when using Firefox as the default browser

Describe the bug
When Firefox is used as the default browser on a device, the TWA will be opened in Firefox. This leads to multiple issues related to push notifications.
To Reproduce
Steps to reproduce the behavior:

Install Firefox from the Play Store
Set Firefox as your default browser in your settings (Apps and notifications > Firefox > Browser App  > Choose Firefox)
Create and install a bubblewrap TWA that accesses a PWA that utilizes web push notifications.
Open the app, make sure that digital asset linking was successful.
Subscribe to web push notifications.
Receive a notification with a click handler that opens the URL of your PWA.

Expected behavior

When I subscribe to web push notification, I do not get asked if I want to allow notifications. It should be allowed by default.
When I receive a notification, it will have the monochrome app icon and will open the TWA when I click on it.

Actual behavior

Firefox asks me for confirmation if I want to give the site permissions to send me notifications.
The notification has the firefox icon and does not open the TWA. It only opens firefox.

Smartphone

Device: Google Pixel 3a
OS: Android 10 & Android 11
Browser: Firefox for Android, 81.1.1

Additional context
If necessary, I can supply more information, an example application or screenshots. It should be not hard to reproduce though.
The main issue here is that firefox is used instead of chrome. I suspect that FF has a different / incomplete API that leads to issues with advanced features like push notifications.
If it would be possible to force the TWA to use chrome, no matter what browser is set as default on the system, it would solve this and other issues. I have not tested it with other browsers or other features than push notifications.
To be honest, I am not sure if it is possible to fix this problem, or if I have to wait for the other browser vendors to catch up with chrome.

Hey @FLKWSKI,
This does look indeed related to the Firefox implementation. @NotWoods might know the best place to file an issue.
Generally, we want to avoid applications hard-coding as specific browser and ensure we're respecting the user's choice of engine.
@PEConn do you know if have Feature Discoverability enabled for Notification Delegation? It might make sense filter/sort TWA providers by this when picking a provider.

Thank you for your response @andreban.
I totally understand that you don't want to make such changes to your library.
But would it be theoretically possible to manually lock the browser engine in the generated bubblewrap application? If yes, could you give me a hint how to achieve that? I would like to try to do it myself, unfortunately I am not very experienced with android app development.

Unfortunately there's no easy way to do that at the moment. I have a PR out to make it customizable, but we need to give some more care to what happens if the specified browser isn't installed.

I'd also recommend you file an issue in the https://github.com/mozilla-mobile/fenix repo.

Closing this, as this is outside the scope of Bubblewrap.


ckan-upgrade-2.8.0a

Hello,
Is there no longer the ckan-upgrade-2.8.0a branch?
...

Nope, it got merged into master :)


Use without vscode

Hi, can this be used without vscode or the web ui?

Too late but there is only Web UI, even VS Code is not supported.


Option to use SOPS instead of Vault

What would you like to be added: I'd like the ability to use SOPS: https://github.com/mozilla/sops instead of Vault

thank you for this input @robd003 - would love a little more information on your motivations to help guide our roadmap.
with our implementation of hashicorp vault, we establish a self hosted identity provider in Vault to establish engineering team and admin team access to all of the auth-oriented platform tools. this allows teams to leverage SSO on day 1 throughout. SOPS could replace the secrets storage in vault, but that would leave a hole in our SSO authentication story.
in a perfect world where you had SOPS secret storage instead of Vault secrets storage, would it be reasonable to continue to use Vault for IdP, oidc provider, user management... basically everything except the secrets themselves? if you'd prefer to not use vault for user management as well, what SSO provider would you want to see leveraged? or would you rather the tools to not have auth roles built in at all?
thanks for any further input you're willing to share with us.

@robd003 is it still something interesting to you? Could you provide more details based on @johndietz's comment.

Would Authentik be a good fit to replace the identity part of Vault? It seems to tick all boxes.


test: add coverage to config.rs 00

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ x ] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: 499
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ x ] No

Other information
Increasing test coverage for config.rs

Codecov Report

:exclamation: No coverage uploaded for pull request base (staging@6b4725f). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             staging       #1   +/-   ##
==========================================
  Coverage           ?   53.40%
==========================================
  Files              ?       14
  Lines              ?     2277
  Branches           ?        0
==========================================
  Hits               ?     1216
  Misses             ?     1061
  Partials           ?        0


Upgraded help screen, some error handling, and slightly-less-poor-man's config files

Specifically addressing issue #7, but with some extra tuneups that came along as a result.
As usual, the on-screen stuff is preliminary and as we show this to more users, we will find better ways to present it.
Help box
Pressing the help key now loads the "quick help" box, which floats in the upper right corner of the screen while the user works (until the user toggles it off)

Additionally, a small alert appears at the top of the screen when the scroller is first opened. It just tells the user how to open the help menu. Once the user presses a key, however, it goes away (we could make it persist until the user actually opens the help menu, or permanently, if we wanted).

Reading constants from files
It's not yet configurable, but it's a step in that direction. While working on the help box code, I realized it would be better to just load in a bunch of string constants from another file so that it's easier to edit. Once I made the help_menu.py file, it seemed like an obvious next step to create a keybinding.py file.
Minor error handling
There's one more new function that print a red "error" message when the user provides bad input to some of the search functions. e.g.

And I'm failing tests, very exciting! Will check in on this later.


Add ARM build to ensure fallback parser works on non-Intel hardware

What it says on the tin.

This gets moved to a future release. I've manually tested on a couple of different architectures, including big-endian ones. When Arm-based hosted runners become available on GitHub this task becomes a whole lot easier.


AnnotatedScrollBar doesn't dismiss tooltip on PointerLost

Describe the bug

Tooltip for AnnotatedScrollBar is not dismissed properly if pointer is lost. I believe pointer handling for edge cases such as scenario below is needed.
Steps to reproduce the bug

Go to WinUI-Gallery -> AnnotatedScrollBar
Set window height to less than the AnnotatedScrollBar height
Drag AnnotatedScrollBar off window and see that the tooltip follows the pointer off screen
Let go of mouse drag and observe that the tooltip stays there until pointer re-enters and exits AnnotatedScrollBar

Expected behavior
No response
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.5.5: 1.5.240627000
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

The bot did something! Resolving as dupe of #9726


Review and improve docs for nested packages

It is more useful to get quick start information in each package README file:

[ ] components-v6
[ ] runtime
[ ] ui-builder
[ ] dev-tools

Hi!
Spend some time reviewing docs for kl-dev-tools and can suggest improvements on issues below:
– Line 26: suggestion: Seems like it's possible to use ENV variables to define tsconfigRootDir and fallback to __dirname if nothing found. My idea based on the assumption that this is provided as package. IMO – packages might not be changed based from proj to proj, so defining env may bring some good changes.
– Line 34: typo: extra space after the header, break markdown.
– Line 36: suggestion: it would be great to add peerDependenciesMeta field for those on this requirements.
– Line 48: issue: it's hard to understand what is 'shared package' in this context and why one may add it. This topic definitely needs improvement. Also it seems like both sections (see link above) are similar to each other at first sight. As far as I understood – shared config is more like an internal ability to expand package, but not applicable for open-source solution. However, config extension is the section one may want to publish. Definitely need some discussion on this topic.
– Line 64: question: this one has no any description on why one should use this script. IMO, it can be done as a binary with 'post-install' script for example with user prompt on version? But this is far away from the docs problems. :)
– Line 72: question: similar question as the previous point: maybe it's possible to use some kind of 'setup-scripts' to make less user interactions and improve DevExp?
– General: nitpick: README lacks description about all the using configs (take a look – a lot of sections on ESLint, but almost nothing on jest / ts / babel). Hard to understand why project even needs this package. Something like an abstract in the beginning will do.
Therefore, I would like to make some cleaning on this part of docs. I would like to know, what exactly can be changed and what should stay as is so I could propose changes for you to review.
Best wishes,
Mike


[DO NOT MERGE] Experiment with automated fuzz target filtering

JOB: https://console.cloud.google.com/kubernetes/job/us-central1-c/llm-experiment/default/ofg-pr-185-dg
REPORT: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-03-28-185-dg-comparison/index.html
BUCKET: https://console.cloud.google.com/storage/browseross-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2024-03-28-185-dg-comparison
BUCKET GS: gs://oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2024-03-28-185-dg-comparison

@happy-qop Starting the experiment here.

No, I cannot access these crash reports~

What's your preferred email address to access them?
We can test adding you after returning from holiday (the coming Tuesday).

I would like to do this but not sure what is the preferred implementation way to align with your following workflow such as how your experiment scripts work with the new classification data.

I am thinking to start with a very preliminary changes:

Replace the current crash with your is_driver_fuzz_err.
Show the FP reason in the report HTML.

Given you cannot see the report now, it might be quicker for me to do it.

Besides, this classification information also highly relates with the discussed fix prompt strategies. If you can hint on this, I can adapt my existing code such as further classification & fix prompts in the next few days.

Are there any other more sophisticated changes you'd like to propose?
I'd love to hear more : )

Push the first version here: #191
I may adjust it a bit and will update you once it is ready : )

The error filtered here is of driver runtime error, identifying them and proposing corresponding fix prompts is part of the workflow of implementing error type specific fix prompts (FIX_FUZZ_XXX at here).

I see, that seems to be a big change indeed.
Let's do that in a separate PR later, then!


[Bug]: A bug while displaying no names on the dashboard

What happened?
I don't have a name on my github account and it falls back to null null, I am not sure if this is expected behavior.

What did you expect to happen?
To not display anything instead of null null
Version
The current version from https://uploadthing.com/dashboard.
Reproduction Steps
Not having a name on the profile of the github account:

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

What would you say is a better behavior here? Showing something like <no name>?

that sounds pretty good.


Parse error stemming from default type param

I'm currently trying to apply the TS derive to the following:
#[derive(Clone, PartialEq, Eq, Encode)]
- #[cfg_attr(feature = "std", derive(Decode, Serialize, Debug))]
+ #[cfg_attr(feature = "std", derive(Decode, Serialize, Debug, TS))]
#[cfg_attr(
	feature = "std",
	serde(bound(serialize = "T::Type: Serialize, T::String: Serialize"))
)]
pub struct StorageEntryMetadata<T: Form = MetaForm> {
	pub name: T::String,
	pub modifier: StorageEntryModifier,
	pub ty: StorageEntryType<T>,
	pub default: Vec<u8>,
	pub docs: Vec<T::String>,
}

The resulting error points to the = token:
expected one of `(`, `+`, `,`, `::`, `<`, or `>`, found `=`

Any advice on getting this working would be greatly appreciated. Thank you!

Thanks for the report! My guess is that default generic arguments are not handled correctly. Will take a look at it tonight.

Thank you!!!

This should be fixed on master & version 6.0.1 which I just released.
There are still some holes in the support for generics (#56), but this should work now (at least my test passes now :D)

I'll try it out later today. Thank you so much @NyxCode!

No problem - again thanks for opening an issue. It's incredible how many edge cases there are which I just did not think about.
I also fixed #57, so now struct X<Y = String> { .. } properly generates interface X<Y = string> { .. }

Apologies for overloading you with issues.
After applying the derive to my struct (which includes the newly-supported default type param)...

When I add the crate-level #![feature(associated_type_bounds)], the error turns into yet another:

Any recommendations?

Apologies for overloading you with issues.

no worries.
Will take a look at it. Seems like a related issue - We generate an impl TS for YourType item, but getting the generics of that right is not super trivial.

@harrysolovay
A fix, test and release of 6.0.5 later, this should now work.
Please let me know if you hit yet another issue!

It's looking good! Thank you!!!


Feature/libgrpc

add libgrpc package to the rosdistro

I want to make GRPC-ROS bridge.
I want to add these packages below.
debian package is here : https://packages.debian.org/sid/libgrpc-dev
ubuntu package is here : https://packages.ubuntu.com/ja/bionic/arm64/libgrpc-dev
arch package is here : https://www.archlinux.org/packages/community/x86_64/grpc/
fedora package is here : https://apps.fedoraproject.org/packages/grpc-devel

Oh ! I found it includes another commit, so I remove this change.(https://github.com/ros/rosdistro/pull/23437/commits/63e86b75f61428c47ec54b396e81583bc5a3b012)

I removed mdrec
Please check it from file changed. (https://github.com/ros/rosdistro/pull/23437/files)

@hakuturu583 are you able to make the changes requested by @clalancette?

No response from the original submitter for over a month, so I'm closing this.  @hakuturu583 , if you'd like to see this merged, please fix things according to @tfoote 's suggestion and re-open.


Support for Verilog 2001 attributes?

So I saw in #3 that you are looking at trying to keep hdlparse simple and targeted at just being used for documentation generation.

In the IEEE Verilog 1364-2001 standard, an attribute is a way to add information to a Verilog object, statement or groups of statements that is tool-specific and does not affect simulation of that design. All Verilog-2001 attributes begin with the token (* and end with the token *). An attribute can be multi-line and is "attached" to the Verilog object, statement, or group of statements that is specified immediately beneath the attribute.

An example of an attribute is shown below;
(* preserve *) reg my_reg;

I think these attributes would be super useful to be included in documentation. In fact, I think you could probably use attributes for the "symbol-sections" inside Symbolator.
From reading the following page it seems fairly standard to support using attributes or special comment forms for specifying this type of special information. See below;

To use a synthesis attribute or directive in a Verilog Design File you can use the (* and *) delimiters. For example, you can use the following code to use the preserve synthesis attribute:
(* preserve *) reg my_reg;

You can also use a synthesis attribute or directive if you specify the synthesis attribute or directive in a comment in the file. The comment can use one of the following formats:
/* <comment> */
// <comment>

For example, you can use the following comment to use the preserve synthesis attribute in a Verilog Design File:
reg my_reg /* synthesis preserve */;

To use more than one synthesis attribute and/or directive for a single node, separate the synthesis attributes and/or directives with a space. For example, you can use the following comment to use the maxfan and preserve synthesis attributes for a single node:
reg my_reg /* synthesis maxfan = 16 preserve */;

Looking at this page these attributes can also be useful for adding more information about things like finite state machines;

 (* covered_fsm, channel, is="state", os="next_state",
                           trans="STATE_IDLE->STATE_IDLE",
                           trans="STATE_IDLE->STATE_HEAD",
                           trans="STATE_HEAD->STATE_DATA",
                           trans="STATE_HEAD->STATE_TAIL",
                           trans="STATE_DATA->STATE_DATA",
                           trans="STATE_DATA->STATE_TAIL",
                           trans="STATE_TAIL->STATE_HEAD",
                           trans="STATE_TAIL->STATE_IDLE" *)
  always @(reset or state or head or tail or valid)
    ...

Would you accept a patch which adds support for these?

hi all,
i'm trying to write the pin_numbers synthesis attribute
i tried like this:
(* synthesis pin_numbers = "143" *) input in;
showing an error, can anyone help?


[BUG/Question] Minor error in documentation

Thank you for this excellent module - and the fantastic documentation. I found a small typo in the section Calling your APIs from Python
. It should be
'client_id': settings.APP_CLIENT_ID, and not 'client_id': settings.OPENAPI_CLIENT_ID,.
I hope you will continue to maintain this project - it has been a time-saver for me.

Hi! Thanks for the kind words!
Which client ID you should use will vary from which application you create the secret. 😊 In my example I create the secret for the OpenAPI app reg. I think this example is closer to a real life scenario, where another application would like to authenticate to your API.
So, if you created your secret in the backend app reg, you have to swap the ClientID to the backend app reg too.
Hope this cleared up a bit, and thank you so much for creating an issue when you see something that’s off. I’ll try to explain this better in the documentation😊

I see - I guess it makes sense that it would often be a token granted to another app registration instead of the "root" app registration. What fooled me, was that it was the OpenAPI app registration used as an example instead of an entirely new app registration. I think it would not be usual practice to create tokens through the OpenAPI app registration?

Ah, yes, agree. I’ll keep this issue and make sure we update it to make it more clear.
PRs welcome if you’d like to contribute 😊

I had the project open, so made a PR. I'll happily close it in favor of yours if you're currently making one.
If not, I'd love a review. 😊

Thank you for clarifying this - I think it's much better now.


SQRT function implementation using binary search in O(logn) time complexity.

would like to add sqrt() function implementation using binary search.

Please assign this issue to me, I would like to work on it

would like to add sqrt() function implementation using binary search.

Assigned!

Can you assign this issue to me? This would be my first contribution in hactoberfest.


D10.2.3 compiling

I do not have on my D10.2.3 (paid one)
FireDAC.Phys.MSSQLDef or FireDAC.Phys.MSSQL
All I have is
FireDAC.Phys
FireDAC.Phys.SQLGenerator
FireDAC.Phys.SQLPreprocessor
Any help?

Unfortunately, MSSQL drivers are unavailable in the CE(community edition), If you don't need MSSQL-related functionalities you can comment or remove them all, and then you will be able to compile because the rest (MySQL, MariaDB, PostgreSQL, etc.) are available in CE.

No my 10.2.3 IS NOT CE community edition. It is a paid
with license one.

Sorry, I didn't get your point correctly.
Well, I think I can't help with this, unfortunately, this file shouldn't be missing with a paid RAD Studio, I think you should try to get support from Embarcadero.


Rule may not work on 1.3.2 branch

In some corner cases, we found that rule may not work, i.e., no cmdlet generated.
We found  in some cases namespace changes are not sync to SSM, which leads to this issue. Please append log and exceptions to this issue, if you encountered this problem.

We believe this issue is fixed by #1717 .  Issue closed.
Feel free to re-open this issue if there is any update.  :)


AVRO-3459 use keywords instead of struct types

Jira

[ ] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-3459

Tests

[ ] My PR does not need testing for this extremely good reason: Updated existing tests

Commits

[ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

This seems to be breaking change for some users. The generated code should not be different by default. If a user does some post processing on the generated code, this will potentially break them. Maybe a future --nullable option to avrogen, however I am not sure I see the actual benefit. Beside maybe the generated code looks more modern, but the compiled code will be pretty much identical.
Is there any known benefit making those changes in the generated code?

@zcsizmadia I'm running into a problem with nested records.  I was actually thinking about creating a targeted C# version (--csharp-version 7.3) as an option for avrogen.  Let me switch this to draft and think about how I want to change it up.  I reached out to you on the ASF slack about this PR.

Could you post the actual schema which gives you trouble? Maybe there is another solution for your problem.

{"namespace": "org.apache.avro.codegentest.some",
  "type": "record",
  "name": "NestedSomeNamespaceRecord",
  "doc" : "Test nested types with different namespace than the outer type",
  "fields": [
    {
      "name": "nestedRecord",
      "type": {
        "namespace": "org.apache.avro.codegentest.other",
        "type": "record",
        "name": "NestedOtherNamespaceRecord",
        "fields": [
          {
            "name": "someField",
            "type": "int"
          }
        ]
      }
    }]
}

What is the issue with that schema?

It will generate the following:
// ------------------------------------------------------------------------------
// <auto-generated>
//    Generated by avrogen, version <IP_ADDRESS>
//    Changes to this file may cause incorrect behavior and will be lost if code
//    is regenerated
// </auto-generated>
// ------------------------------------------------------------------------------
namespace org.apache.avro.codegentest.other
{
	using System;
	using System.Collections.Generic;
	using System.Text;
	using global::Avro;
	using global::Avro.Specific;

	public partial class NestedOtherNamespaceRecord : global::Avro.Specific.ISpecificRecord
	{
		public static global::Avro.Schema _SCHEMA = global::Avro.Schema.Parse("{\"type\":\"record\",\"name\":\"NestedOtherNamespaceRecord\",\"namespace\":\"org.apache.avro" +
				".codegentest.other\",\"fields\":[{\"name\":\"someField\",\"type\":\"int\"}]}");
		private @int _someField;
		public virtual global::Avro.Schema Schema
		{
			get
			{
				return NestedOtherNamespaceRecord._SCHEMA;
			}
		}
		public @int someField
		{
			get
			{
				return this._someField;
			}
			set
			{
				this._someField = value;
			}
		}
		public virtual object Get(int fieldPos)
		{
			switch (fieldPos)
			{
			case 0: return this.someField;
			default: throw new global::Avro.AvroRuntimeException("Bad index " + fieldPos + " in Get()");
			};
		}
		public virtual void Put(int fieldPos, object fieldValue)
		{
			switch (fieldPos)
			{
			case 0: this.someField = (int)fieldValue; break;
			default: throw new global::Avro.AvroRuntimeException("Bad index " + fieldPos + " in Put()");
			};
		}
	}
}

Is there anything wrong with the current code generation?

The type is @int

Hmmmm. I am confused. My avrogen installed from nuget.org generates this:
// ------------------------------------------------------------------------------
// <auto-generated>
//    Generated by avrogen, version <IP_ADDRESS>
//    Changes to this file may cause incorrect behavior and will be lost if code
//    is regenerated
// </auto-generated>
// ------------------------------------------------------------------------------
namespace org.apache.avro.codegentest.other
{
	using System;
	using System.Collections.Generic;
	using System.Text;
	using Avro;
	using Avro.Specific;

	public partial class NestedOtherNamespaceRecord : ISpecificRecord
	{
		public static Schema _SCHEMA = Avro.Schema.Parse("{\"type\":\"record\",\"name\":\"NestedOtherNamespaceRecord\",\"namespace\":\"org.apache.avro" +
				".codegentest.other\",\"fields\":[{\"name\":\"someField\",\"type\":\"int\"}]}");
		private int _someField;
		public virtual Schema Schema
		{
			get
			{
				return NestedOtherNamespaceRecord._SCHEMA;
			}
		}
		public int someField
		{
			get
			{
				return this._someField;
			}
			set
			{
				this._someField = value;
			}
		}
		public virtual object Get(int fieldPos)
		{
			switch (fieldPos)
			{
			case 0: return this.someField;
			default: throw new AvroRuntimeException("Bad index " + fieldPos + " in Get()");
			};
		}
		public virtual void Put(int fieldPos, object fieldValue)
		{
			switch (fieldPos)
			{
			case 0: this.someField = (System.Int32)fieldValue; break;
			default: throw new AvroRuntimeException("Bad index " + fieldPos + " in Put()");
			};
		}
	}
}


Added a share to social media link so that the shortened url can be shared easily

Closes: #969

Title: Share to social media link added
Name: Shaswata Saha
Idenitfy yourself: Hacktoberfest24 Contributor

Describe the add-ons or changes you've made 📃
Screenshots 📷

After clicking the share,

Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.

Note to reviewers 📄

Kindly assign me the issue and accept the PR. Thank You.

I've already warned you

I've already warned you

You warned me to push directly to the main branch. So where shall I push. If you kindly guide me. You have no other branch except that one.

https://discord.gg/tSqtvHUJzE


portico: Align ToS checkbox with full name input box.

Fixes #9328.
Makes the width on checkbox input-group same as full name input box
width and centers it horizontally.

@shubham-padia can you explain a bit more what this is doing?  Visually, it looks like you added some vertical margin in addition to centering it horizontally?

@timabbott I put the left margin as bottom margin in the commit by mistake, I've updated it.
Screenshot:


6LoWPAN Hop-by-Hop Header compression

This changes the wire representation for IPv6 Hop-by-hop Headers, such that they can be used together with 6LoWPAN (and later with RPL).
6LoWPAN has the same Extension Headers as IPv6, however, the next header field can sometimes be elided, and the length field does not have the same semantics as the definition in the IPv6 standard.
More information can be found here: https://datatracker.ietf.org/doc/html/rfc6282#section-4.2
I added an enum PacketFormat that is added to the Header struct. When the proto-sixlowpan feature flag is not used, then there is only one variant of the PacketFormat, so I think the compiler should be able to optimize this away.

Codecov Report

Merging #765 (96abcc1) into master (56d329b) will increase coverage by 0.09%.
The diff coverage is 93.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   80.39%   80.49%   +0.09%
==========================================
  Files          65       65
  Lines       26849    27015     +166
==========================================
+ Hits        21586    21745     +159
- Misses       5263     5270       +7

Impacted Files
Coverage Δ

src/wire/ipv6hopbyhop.rs
93.82% <92.07%> (+0.57%)
:arrow_up:

src/iface/interface/ipv6.rs
75.75% <100.00%> (ø)

src/wire/mod.rs
69.93% <100.00%> (+7.05%)
:arrow_up:

src/wire/sixlowpan.rs
65.70% <100.00%> (+0.02%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hmm, this approach requires explicitly adding NHC support to every single extension header, which makes me a bit scared. It adds quite a bit of complexity to the wire code.
The compressed NHC format is the same for all extension headers, and the non-compressed is almost the same (the fragmentation header has "Reserved" in the length byte, lol? WHY?). This makes me wonder whether this should be handled at a "higher" layer the same for all extension headers, instead of adding support to each one.
How were you planning to integrate this into iface? It seems to me that for RX decompress_sixlowpan could decompress the NHCs so that the regular ipv6 code doesn't need to handle NHC. For tx we don't have a compress, so i'm not sure...
Another idea we could play with is to make the wire code for the extension headers deal only with the "payload", which is all bytes except the first 2 (next header, and length). The "payload" is the same in the compressed and uncompressed versions, this would leave up to the higher layer code to deal with the "linked list" (either uncompressed or NHC).
:S

I agree that it changes the complexity of the extension headers. At first, I didn't want to change a lot of the wire representations. I think I'll change the extension headers in general like you said:

Another idea we could play with is to make the wire code for the extension headers deal only with the "payload", which is all bytes except the first 2 (next header, and length). The "payload" is the same in the compressed and uncompressed versions, this would leave up to the higher layer code to deal with the "linked list" (either uncompressed or NHC).

This will make the handling in the iface a lot easier and transparent with regard to compression or not. Thanks a lot for the feedback!

Opened #781, which addresses the comment.


Increment Version

@JuliaRegistrator register() ACTRModels v0.4.8

Registration pull request created: JuliaRegistries/General/26885
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.8 -m "<description of version>" 89deaa393fc573c35d1791264c76c9c33fa1c72b
git push origin v0.4.8


fix: add validation to prevent empty comments

Description
This PR adds validation to prevent empty comments in the EditCommentForm. If the user tries to submit an empty comment, an error message is displayed, and the submit button is disabled until valid input is entered.
Checklist

[x] discord username: antipator#8808
[x] Closes #358
[ ] PR must be created for an issue from issues under "In progress" column from our project board.
[x] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
[x] Related file selection: Only relevant files should be touched and no other files should be affected.
[x] I ran npx turbo run at the root of the repository, and build was successful.
[ ] I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?

Go to the post page.
Create a comment.
Click the "Edit" button and delete the comment content.
Try to submit the form.
Write content to the comment.
Click the "Save" button.

After opening pr, I saw that you wanted to switch to zod, I wrote it again with zod.

I'm sorry, I thought I submitted my review but it was still pending, my bad. I'll take a look at this again and get back to you asap!

let's re-open this when the restructuring is done.


Is the Propel Users group still active?

Hello,
I'm a new Propel 2 user that could use some occasional help, but the Propel Users Google Group referenced on the site doesn't seem to be active. (My question from a couple weeks ago hasn't shown up, etc. The Developer group doesn't seem to be active.)
Is there an active Propel 2 user community where I can ask questions now, and hopefully contribute to someday?
— Charles

Well, propel v1 isn't very active and the mailing list in general neither, but you can try the new hipster stuff https://gitter.im/propelorm/Propel, which is active


Issue with new AND/OR Condtion

Make sure you run the latest version before reporting an issue. Feature requests should go in the forum: https://community.home-assistant.io/c/feature-requests
Home Assistant release (hass --version):
0.19
Python release (python3 --version):
3.4.2
Component/platform:
Condition
Description of problem:
I try to align my automation rules with the newest mechanism to handle condition so I changed my rules from this:
#Detect when the TV has been (re)started
- alias: 'TV has been restarted (reset flags)'
  trigger:
      platform: numeric_state
      entity_id: sensor.conso_tv
      above: 13
  condition_type: or
  condition:
    - platform: state
      entity_id: input_boolean.reset_tv_hifi
      state: 'on'
    - platform: state
      entity_id: input_boolean.tv_hifi_reset_done
      state: 'on'
  action:
      service: script.turn_on
      data:
          entity_id: script.reset_flags

to
#Detect when the TV has been (re)started
- alias: 'TV has been restarted (reset flags)'
  trigger:
      platform: numeric_state
      entity_id: sensor.conso_tv
      above: 13
  condition_type: or
  conditions:
    - condition: state
      entity_id: input_boolean.reset_tv_hifi
      state: 'on'
    - condition: state
      entity_id: input_boolean.tv_hifi_reset_done
      state: 'on'
  action:
      service: script.turn_on
      data:
          entity_id: script.reset_flags

But the following error is returned:
homeassistant.bootstrap: Invalid config for [automation]: invalid list value @ data['condition'][0] (See /home/pi/MyHomeAutomationConf/automation.yaml:24)
I don't see what I'm might have done wrong

Try:
automation:
#Detect when the TV has been (re)started
    - alias: 'TV has been restarted (reset flags)'
      trigger:
          platform: numeric_state
          entity_id: sensor.conso_tv
          above: 13
      condition:
          condition: or
          conditions:
            - condition: state
              entity_id: input_boolean.reset_tv_hifi
              state: 'on'
            - condition: state
              entity_id: input_boolean.tv_hifi_reset_done
              state: 'on'
      action:
          service: script.turn_on
          data:
              entity_id: script.reset_flags

The documentation is a bit unclear

It works, thanks
Closing Issue


integration with libvirt-guests.service

libvirt packages onc entos/fedora ship the libvirt-guests systemd service, which takes care of suspending and resuming VMs.
We need to make sure that VMs running the cluster run fine with this service.

It seems to work as expected. Need to be mentioned in the docs


Axis label does not change when max or min is changed

In SpeedometerGauge and MeterGauge the axis label does not change, if max or min is changed in configuration and set with gauge.update(state.configurationJson);
Also the needle stays on wrong position, until the value changes in configuration.

The labels should update now if the max value changes. A min value other than 0 currently isn't supported by any of the gauge types.

I opened a ticket for min value support (#7)

Any updates here?

should be fixed / implemented in master


Return number of accounts / transactions / assets

Problem
When you want to query the indexer to find for example the accounts with a balance above a certain threshold, you need to paginate through the results if they exceed the limit. Sometimes you are not interested in the accounts themselves but simply the number of them which results in many unneccessary requests.
Solution
Return length alongside accounts, next-token etc which indicates the total number of accounts that meet the criteria specified. Similarly add length for other endpoints.
Urgency
Low

Thanks for the suggestion - unfortunately, we can't efficiently support this in the API (a Postgres limitation). You can query the database directly to get these sorts of results if needed for your use case.


[$500] Workspace - System message for workspace description edit shows from "" to "x"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Create a new workspace.
Go to workspace profile.
Click Add description.
Add a description and save it.
Go to #admin room.

Expected Result:
The system message shows <updated the description of this workspace to "m">.
Actual Result:
The system message shows <updated the description of this workspace from "" to "x">.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/6b76c38c-801f-43a5-8779-d4ad34a9e7f3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01890415a5997d6fe7
Upwork Job ID:<PHONE_NUMBER>077556224
Last Price Increase: 2024-03-25

We think that this bug might be related #wave5-free-submitters
CC @dylanexpensify

We should fix this, but I'm removing the blocker label as it shouldn't block the release 👍

Why would we expect this when the description was blank?:

The system message shows <updated the description of this workspace to "m">.

Why would we expect this when the description was blank?:

Oh right. Good point. @kbecciv any other issue here we're missing, or can we close?

Oh right. Good point. @kbecciv any other issue here we're missing, or can we close?

Friendly bump @kbecciv

No other issues @MitchExpensify

@MitchExpensify Reopening the issue.
Previously, we had an empty workspace description, but now there is a default workspace description (due to a new feature). However, the issue remains unresolved.
Could you please advise whether it's preferable to open a new issue or to keep this one open as it is?
https://github.com/Expensify/App/assets/93399543/b2831c59-489b-4fa3-94a5-7c1c91201241

Yeah lets solve that here, good catch. Can you please update the OP accordingly? Thanks

Seems like it is a BE issue. the update description request returns the current format as a new report action in the response

@MitchExpensify this seems pretty low priority. Any preference for how we get this on the roadmap? I'll probably unassign once we've figured that out

I think its polish for Wave Collect

Unassigning as backend issue and no C+ required

unassigning myself as this no need C+

Will try track down an Internal volunteer as a next step

No bites yet
@trjExpensify do we ever apply hot picks label to polish?

Yep, you can add the Hot picks label and move it into the Hot picks section of the project board so anyone browsing it can see it in that column. Once it's picked up, remove the label and move it back into Polish. 👍

Why did you move this back, @MitchExpensify? @chiragsalian put up a PR here: https://github.com/Expensify/Web-Expensify/pull/41774

Actually im just going to close out this issue since its done. Feel free to reopen if something is missing.


Mobile chrome users can accidentally get to the chart, which doesn't work under chrome

Repro:

Go to a page in Digraph on Chrome on a phone
Click on the logo
It takes you to the chart page, and the chart begins to load and then crashes the page

For some reason the chart is no longer causing issues on iOS Chrome.


Profile batch transfer and gradient clipping hooks

What does this PR do?

Fixes #14028
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @kaushikb11 @ninginthecloud @rohitgr7 @nbcsm @guotuofeng @awaelchli @borda @akihironitta

any suggestions for the test here?
I am thinking of extending these with profilers since they cover all the cases with hooks.
https://github.com/Lightning-AI/lightning/blob/master/tests/tests_pytorch/models/test_hooks.py

Added the missing chlog entry

Why did we include this in the bug-fix release? Technically this just added a feature (profiling)

I included it because it was labelled as 1.7.x and also the linked issue had a bug label. This was evidence enough for me that it is correct and intended. If I'm not sure (for example, when linked issue is not also labelled accordingly), I usually ask (https://github.com/Lightning-AI/lightning/pull/9938#issuecomment-1215369656)

It was totally unintentional. The hook was missing from the logging FxValidator that enabled logging in this hook. The real intention was just to ensure these hooks are profiled, so I added it as a bug, but logging is part of the trainer._call_lightningmodule_hook.


razzle-plugin-scss transitively imports a version of object-path with a high severity vulnerability

🐛 Bug report
razzle-plugin-scss currently imports<EMAIL_ADDRESS>which transitively brings in a version of object-path with a high severity vulnerability.  This vulnerability was fixed in<EMAIL_ADDRESS> Would it be possible to upgrade to a newer version of resolve-url-loader that doesn't import the vulnerable object-path dependency?

Will be releasing 4.0 shortly is fixed there.


PagedLOD is not freeing memory anymore

i believe that the issue is coming from the following
In Node Class
the function releaseGLObjects doesnot pass state object as well as when calling the stateset.releaseGLObjects we dont pass the expected state object
releaseGLObjects: function ( /gl/) {
        if ( this.stateset !== undefined ) this.stateset.releaseGLObjects();
    }

then in stateset Class the Function releaseGLObjects  which Expects state object
releaseGLObjects: function ( state ) {
// TODO: We should release Program/Shader attributes too
for ( var i = 0, j = this.textureAttributeMapList.length; i < j; i++ ) {
this.getTextureAttribute( i, 'Texture' ).releaseGLObjects( state );
}
},
as state is passed as null this  will result to  fail to release the texture when the releaseGLObjects is called on the texture Class as state would always be passed as undefined
releaseGLObjects: function ( state ) {
if ( state !== undefined ) {
if ( this._textureObject !== undefined && this._textureObject !== null ) {
state.getTextureManager().releaseTextureObject( this._textureObject );
this._textureObject = undefined;
}
}
},
The Intial Code was working for object.releaseGLObjects as the texture as it was not expecting a state object
releaseGLObjects: function ( ) {
if ( this._textureObject !== undefined && this._textureObject !== null ) {
Texture.textureManager.releaseTextureObject( this._textureObject );
this._textureObject = undefined;
this._image = undefined;
}
},

Hi @hishamabdelrahman
There is more work to be done, but can you try https://github.com/cedricpinson/osgjs/pull/297 to see if it fixes the issues for you? thanks.

Thanks jordi ..I saw your pull request .u believe it should fix my issue
...many thanks for Ur support
On Apr 10, 2015 8:16 AM, "Jordi Torres"<EMAIL_ADDRESS>wrote:

Hi @hishamabdelrahman https://github.com/hishamabdelrahman
There is more work to be done, but can you try #297
https://github.com/cedricpinson/osgjs/pull/297 to see if it fixes the
issues for you? thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/cedricpinson/osgjs/issues/291#issuecomment-91446185.

it can be closed, fixed in #297

i verified the latest code with my data , yes its working well now


PhotoView app won’t display any photos/videos

PhotoView will link to my account but it will not display any photos or videos

This is due to a daily limit of downloads given by Google Photos to the application. This sometimes happens later in the evening as the count resets at 12:00 AM PT.


refactor(mempool): rename priority queue structs

This change is

Codecov Report
Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (5666746) to head (fb818ca).

Files
Patch %
Lines

crates/mempool/src/priority_queue.rs
40.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   75.75%   75.79%   +0.03%
==========================================
  Files          28       28
  Lines        1382     1380       -2
  Branches     1382     1380       -2
==========================================
- Hits         1047     1046       -1
+ Misses        277      275       -2
- Partials       58       59       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[AddToApp] I want to using .android gradle version 6.1.1

Steps to Reproduce
Flutter version: 1.20.4
Target platform: Android

For example, our project structure like below,
https://flutter.dev/docs/development/add-to-app/android/project-setup
Master Project
   |_ Android project
   |_ iOS project
   |_ add_to_app_flutter

Run flutter build aar.
show .android gradle version

build.gradle.tmpl
https://github.com/flutter/flutter/blob/6620f831e93a74ca12e65b501748a6d1df310863/packages/flutter_tools/templates/app/android-kotlin.tmpl/app/build.gradle.tmpl#L26
flutter.gradle
https://github.com/flutter/flutter/blob/6620f831e93a74ca12e65b501748a6d1df310863/packages/flutter_tools/gradle/flutter.gradle#L30
I want to upload minSdk and gradle in the our private library, but flutter is fixed. Because
build.gradle.tmpl using flutter.gradle and flutter.gradle fixed 3.5.0. Overall, it is used in 3.5.0 everywhere. It is target sdk 29, could you review support with gradle 6.1.1?
Thank you :)

Hi @ybin0823
This is no support newer Gradle version yet https://github.com/flutter/flutter/issues/58247 https://github.com/flutter/flutter/issues/65399 https://github.com/flutter/flutter/issues/58479
When there is support for newer Gradle, you would be able to use it everywhere
Thank you


Source image is unreachable

Hi
Im not sure whats wrong but when i want to use the url
http://localhost:8080/insecure/rs:fill:300:400/g:sm/plain/https://image-hub.reproindialtd.com/9789383331888.jpg
i get the error "Source image is unreachable".
There are actually a few thousand (100s of thousands) images I want to process but they are all stored in the same domain.
Some insight would be very much appreciated.

Hi @Pijamo!
You can check the imgproxy's logs to see what's going wrong. For security reasons, imgproxy doesn't respond with the full error message and just points to a general cause. But its logs contain the full error message.
Alternatively, you can use the IMGPROXY_DEVELOPMENT_ERRORS_MODE config so imgproxy will respond with full error messages. Yet I wouldn't recommend doing it in production.


Is this a good way to implement lora module_to_save for embed_token and lm_head?

I'm trying to implement lora that has extra module inside the adapter. Here is what I did to exllamav2 script
Inside lora.py from line 69 I add
                # Find target
                if key.endswith('lm_head.weight'):
                    if tensor.dtype == torch.bfloat16:
                        tensor = tensor.to(torch.float16)
                    elif tensor.dtype == torch.float32:
                        tensor = tensor.to(torch.float16)
                    target_module = self.model.modules_dict["lm_head"]
                    tensor = safe_move_tensor(tensor, target_module.device())
                    self.lm_head = torch.nn.Linear(target_module.in_features, tensor.shape[0], bias = False, device = "meta")
                    self.lm_head.weight = torch.nn.Parameter(tensor, requires_grad=False)
                    continue
                elif key.endswith('embed_tokens.weight'):
                    if tensor.dtype == torch.bfloat16:
                        tensor = tensor.to(torch.float16)
                    elif tensor.dtype == torch.float32:
                        tensor = tensor.to(torch.float16)
                    target_module = self.model.modules_dict["model.embed_tokens"]
                    tensor = safe_move_tensor(tensor, target_module.device())
                    self.embed_tokens = torch.nn.Embedding(tensor.shape[0], self.config.hidden_size, self.config.pad_token_id, device = "meta")
                    self.embed_tokens.weight = torch.nn.Parameter(tensor, requires_grad=False)
                    self.embed_tokens.weight[self.config.pad_token_id] = 0
                    continue

And inside model.py line 615 I change into
            if module.key == "model.embed_tokens" and loras is not None and loras[0].embed_tokens is not None:
                x = loras[0].embed_tokens(x)
            elif module.key == "lm_head" and loras is not None and loras[0].lm_head is not None:
                x = loras[0].lm_head(x)
            else:
                x = module.forward(x, cache = cache, attn_params = attn_params, past_len = past_len, loras = loras)

But, the generating result is not what I expected. I also try it to first version of exllama and it works fine (maybe because first version of exllama did not quantize lm_head?).

There was some implementation of this recently, so I'm closing this issue. It should work now, although it's limited and a little clumsy since LoRAs that include lm_head and embed_token tensors are no longer adapters and don't stack the way adapters normally would.


Ping aliases for @rustbot ping the_alias

Instead of having to remember @rustbot ping icebreakers-cleanup-crew it would be great if we could add a memorable alias for the group so that I could e.g. write @rustbot ping cleanup. We would configure this by adding a list of aliases under a ping section.

fff4611 implements the alias key for the ping configuration; rust-lang/rust can start using it as soon as the change to triagebot.toml lands in the master of that repo. Could you make that PR?

I think so yeah; could you add something to the wiki docs btw?


Bug fix of the Swagger Editor's base URL

@berezovskyi
I don't recall where you reported this problem, but the Swagger Editor was not working. You can see the main fix in this change below. The rest is simple to update based on latest generation.
https://github.com/oslc-op/refimpl/pull/171/files#diff-62e9233ed2373e0a006bd2e47394eac2f43a05ea2f8f31f41fdfbec73cfa08efL109


Different type signatures for identical functions.

Describe the bug
Different type signatures for identical functions.
To Reproduce
let a x y z = x (y z)
let aa x y z = x (y z)

You can see the inferred type signature for the first function is incorrect ('a -> 'b) in the screenshot.
Expected behaviour
Both functions should have the signature:
('a -> 'b) -> ('c -> 'a) -> c' -> b'

Screenshots

Environment (please complete the following information):

OS: Windows and OSX
Ionide version: 4.0.6
VSCode version: July 2019
dotnet SDK version: 2.2.204
mono / .Net Framework version: <IP_ADDRESS>

I suspect the bug is in FCS, not Ionide but all 1 letter functions have this problem :

It may be problem with location we check in FSAC - doesn’t we accidentally show signature of first parameter for a one-letter functions


Update GitHub product requirements for SAML single sign-on

This pull request updates the Tutorial: Azure Active Directory integration with GitHub guide to reflect recent GitHub product name changes (1, 2, 3) and attempts to clarify what's required on the GitHub side for SAML single sign-on via Azure AD.
Closes #24684.

@mattpollard : Thanks for your contribution! The author, @jeevansd, has been notified to review your proposed change.

This article does not require any next steps, so I have not added it. SaaS app tutorials are not TOC integrated.
Our toc is here: https://docs.microsoft.com/en-us/azure/active-directory/active-directory-saas-tutorial-list
#sign-off


Implement smarter numerical ordering

Resolves #5.

That should fix the issues.

Published in 0.2.0.


[question] spans_malformed(invalid_http_status_code)

Hi,
We can see the following error in trace-agent
2024-08-20 15:36:34 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:istio-ingressgateway.gateway] -> spans_malformed(invalid_http_status_code:13). Enable debug logging for more details.
2024-08-21 02:50:19 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:istio-ingressgateway.gateway] -> spans_malformed(invalid_http_status_code:6). Enable debug logging for more details.
2024-08-21 09:44:59 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:webapp-bo.alumni-connect] -> spans_malformed(invalid_http_status_code:1). Enable debug logging for more details.
2024-08-21 09:44:59 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:istio-ingressgateway.gateway] -> spans_malformed(invalid_http_status_code:1). Enable debug logging for more details.
2024-08-21 09:48:09 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:webapp-bo.alumni-connect] -> spans_malformed(invalid_http_status_code:1). Enable debug logging for more details.
2024-08-21 09:48:09 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:istio-ingressgateway.gateway] -> spans_malformed(invalid_http_status_code:2). Enable debug logging for more details.
2024-08-21 11:23:19 UTC | TRACE | WARN | (pkg/trace/info/stats.go:101 in LogAndResetStats) | [lang:cpp lang_version:202002 tracer_version:v0.2.2 endpoint_version:v0.4 service:whitelabel.whitelabel] -> spans_malformed(invalid_http_status_code:1). Enable debug logging for more details.

What could it be the origin of it? We're guessing that it could come from the istio sidecar. Do you know if there have been errors related to this previously?
BR

Hi @mcatany
It looks like the issue is coming from Istio / Envoy. This setup is a bit different from others integrations, because, while we provide the tracer, the Envoy team handles the instrumentation.
I've seen similar behavior before, where Envoy tags spans with status code outside the expected HTTP [100, 599] range. Since our Agent expects a status code within this range, those spans are flagged as malformed and aren't ingested by the trace agent.
My gut feeling is that something might be off on those requests, causing these spans to be tagged with a status code. The status code is not in a HTTP code range, maybe it's not an HTTP status code then. Are you using a gRPC or other kind of filter?
In the meantime, I strongly suggest to open a support case here for visibility.

By filters, I was referring to Envoy filter. Unfortunately, I don't have a solution right now, but I'l give it a some thought this week, talk with colleagues and get back to you. If you can infer any pattern, that could help.
Also, just to confirm, is the support ticket for CleverTech?

Thanks,
The ticket is for Hivebrite


id vs name

I'm not sure id and name behave as documented.
Example from API docs on README:
const store = new ObjectStore();
const file = store.createFile("file_id", { name: "foo.txt", content: "Foo", parentId: "folder_id" });

console.log(file);
/*
{
    id: "file_id",
    name: "foo.txt",
    type: "file",
    parent_id: "parent_id",
    created_at: "2022-10-20T12:00:00Z",
    modified_at: "2022-10-20T12:00:00Z",
}
*/

However, when running I get this:
{
  id: "1",
  name: "file_id",
  type: "file",
  parent_id: "0",
  created_at: "2024-06-20T10:43:33.455Z",
  modified_at: "2024-06-20T10:43:33.455Z",
  size: 3,
}

demo: https://livecodes.io/?x=id/dmxf2mysgqv

Just a documentation error. Too much copy-pasting.

Code samples now work very well.
Demo: https://livecodes.io/?x=id/8x8devpzvvs
Thank you for the nice project.
P.S. you may also want to add docs for getFolder and updateFolder
Thank you.

@hatemhosny documentation PRs gratefully accepted. :smile:

I will 😊
Thank you.


Programming Practice: Improve other groups code

[x] Work on checkstyle improvements.
[ ] Google DocStrings all up the same standard.
[x] The scenerio game mode could be split up (espically the if statement blocks).
[x] Look at a different way of writing the add to tray method - less ifs.
[x] Group similar classes into packages.

Using hash set instead of list also

Taking longer then expected - just need to finish scenerio game master test and docstring and test messages (Aiming to finish by Thursday ideally)

New ticket will be generated for finishing off tests


add inference test for llama-2-7b-chat-hf

CI
Description
add inference test for llama-2-7b-chat-hf

@lvliang-intel
I have to remove farm-haystack and fastapi to make the inference work as expected. Otherwise, I'll get below due to pydantic issue.
_Loading model meta-llama/Llama-2-7b-chat-hf
13 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1130, in _get_module
14 return importlib.import_module("." + module_name, self.name)
15 File "/opt/conda/envs/chatbot-demo/lib/python3.9/importlib/init.py", line 127, in import_module
16 return _bootstrap._gcd_import(name[level:], package, level)
17 File "", line 1030, in _gcd_import
18 File "", line 1007, in _find_and_load
19 File "", line 986, in _find_and_load_unlocked
20 File "", line 680, in _load_unlocked
21 File "", line 850, in exec_module
22 File "", line 228, in _call_with_frames_removed
23 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/llama/modeling_llama.py", line 32, in
24 from ...modeling_utils import PreTrainedModel
25 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/modeling_utils.py", line 87, in
26 from accelerate import dispatch_model, infer_auto_device_map, init_empty_weights
27 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/accelerate/init.py", line 3, in
28 from .accelerator import Accelerator
29 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/accelerate/accelerator.py", line 41, in
30 from .tracking import LOGGER_TYPE_TO_CLASS, GeneralTracker, filter_trackers
31 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/accelerate/tracking.py", line 65, in
32 import mlflow
33 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/init.py", line 247, in
34 from mlflow import gateway # noqa: F401
35 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/init.py", line 1, in
36 from mlflow.gateway.fluent import get_route, search_routes, query, create_route, delete_route
37 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/fluent.py", line 4, in
38 from mlflow.gateway.client import MlflowGatewayClient
39 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/client.py", line 8, in
40 from mlflow.gateway.config import Route
41 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/config.py", line 66, in
42 class OpenAIConfig(ConfigModel):
43 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/config.py", line 79, in OpenAIConfig
44 @root_validator(pre=False)
45 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/pydantic/deprecated/class_validators.py", line 228, in root_validator
46 raise PydanticUserError(
47pydantic.errors.PydanticUserError: If you use @root_validator with pre=False (the default) you MUST specify skip_on_failure=True. Note that @root_validator is deprecated and should be replaced with @model_validator.
48
49For further information visit https://errors.pydantic.dev/2.1.1/u/root-validator-pre-skip
50
51The above exception was the direct cause of the following exception:
52
53Traceback (most recent call last):
54 File "/root/chatbot/workflows/chatbot/inference/generate.py", line 1044, in
55 main()
56 File "/root/chatbot/workflows/chatbot/inference/generate.py", line 943, in main
57 load_model(
58 File "/root/chatbot/workflows/chatbot/inference/generate.py", line 400, in load_model
59 model = AutoModelForCausalLM.from_pretrained(
60 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 515, in from_pretrained
61 model_class = _get_model_class(config, cls._model_mapping)
62 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 377, in _get_model_class
63 supported_models = model_mapping[type(config)]
64 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 690, in getitem
65 return self._load_attr_from_module(model_type, model_name)
66 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 704, in _load_attr_from_module
67 return getattribute_from_module(self._modules[module_name], attr)
68 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 648, in getattribute_from_module
69 if hasattr(module, attr):
70 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1120, in getattr
71 module = self._get_module(self._class_to_module[name])
72 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1132, in _get_module
73 raise RuntimeError(
74RuntimeError: Failed to import transformers.models.llama.modeling_llama because of the following error (look up to see its traceback):
75If you use @root_validator with pre=False (the default) you MUST specify skip_on_failure=True. Note that @root_validator is deprecated and should be replaced with @model_validator._

@lvliang-intel  please check this.

@lvliang-intel I have to remove farm-haystack and fastapi to make the inference work as expected. Otherwise, I'll get below due to pydantic issue.
_Loading model meta-llama/Llama-2-7b-chat-hf
13 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1130, in _get_module
14 return importlib.import_module("." + module_name, self.name)
15 File "/opt/conda/envs/chatbot-demo/lib/python3.9/importlib/init.py", line 127, in import_module
16 return _bootstrap._gcd_import(name[level:], package, level)
17 File "", line 1030, in _gcd_import
18 File "", line 1007, in _find_and_load
19 File "", line 986, in _find_and_load_unlocked
20 File "", line 680, in _load_unlocked
21 File "", line 850, in exec_module
22 File "", line 228, in _call_with_frames_removed
23 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/llama/modeling_llama.py", line 32, in
24 from ...modeling_utils import PreTrainedModel
25 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/modeling_utils.py", line 87, in
26 from accelerate import dispatch_model, infer_auto_device_map, init_empty_weights
27 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/accelerate/init.py", line 3, in
28 from .accelerator import Accelerator
29 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/accelerate/accelerator.py", line 41, in
30 from .tracking import LOGGER_TYPE_TO_CLASS, GeneralTracker, filter_trackers
31 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/accelerate/tracking.py", line 65, in
32 import mlflow
33 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/init.py", line 247, in
34 from mlflow import gateway # noqa: F401
35 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/init.py", line 1, in
36 from mlflow.gateway.fluent import get_route, search_routes, query, create_route, delete_route
37 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/fluent.py", line 4, in
38 from mlflow.gateway.client import MlflowGatewayClient
39 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/client.py", line 8, in
40 from mlflow.gateway.config import Route
41 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/config.py", line 66, in
42 class OpenAIConfig(ConfigModel):
43 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/mlflow/gateway/config.py", line 79, in OpenAIConfig
44 @root_validator(pre=False)
45 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/pydantic/deprecated/class_validators.py", line 228, in root_validator
46 raise PydanticUserError(
47pydantic.errors.PydanticUserError: If you use @root_validator with pre=False (the default) you MUST specify skip_on_failure=True. Note that @root_validator is deprecated and should be replaced with @model_validator.
48
49For further information visit https://errors.pydantic.dev/2.1.1/u/root-validator-pre-skip
50
51The above exception was the direct cause of the following exception:
52
53Traceback (most recent call last):
54 File "/root/chatbot/workflows/chatbot/inference/generate.py", line 1044, in
55 main()
56 File "/root/chatbot/workflows/chatbot/inference/generate.py", line 943, in main
57 load_model(
58 File "/root/chatbot/workflows/chatbot/inference/generate.py", line 400, in load_model
59 model = AutoModelForCausalLM.from_pretrained(
60 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 515, in from_pretrained
61 model_class = _get_model_class(config, cls._model_mapping)
62 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 377, in _get_model_class
63 supported_models = model_mapping[type(config)]
64 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 690, in getitem
65 return self._load_attr_from_module(model_type, model_name)
66 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 704, in _load_attr_from_module
67 return getattribute_from_module(self._modules[module_name], attr)
68 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 648, in getattribute_from_module
69 if hasattr(module, attr):
70 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1120, in getattr
71 module = self._get_module(self._class_to_module[name])
72 File "/opt/conda/envs/chatbot-demo/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 1132, in _get_module
73 raise RuntimeError(
74RuntimeError: Failed to import transformers.models.llama.modeling_llama because of the following error (look up to see its traceback):
75If you use @root_validator with pre=False (the default) you MUST specify skip_on_failure=True. Note that @root_validator is deprecated and should be replaced with @model_validator._

You can remove these two packages for inference code, they are for retrieval based server code.

@chensuyue if you don't have more comments, please help merge it. I'll add test for mpt model.


Use S3's range Object to fetch a chunk of bytes

Related to https://github.com/aiven/tiered-storage-for-apache-kafka/issues/126
You can use S3's range API to fetch a chunk of bytes from S3 object instead of the whole object/file:
            // Get a range of bytes from an object and print the bytes.
            GetObjectRequest rangeObjectRequest = new GetObjectRequest(bucketName, key)
                    .withRange(0, 9);

https://docs.aws.amazon.com/AmazonS3/latest/userguide/download-objects.html
This can be applied to S3ClientWrapper.fetchLogFile: https://github.com/aiven/tiered-storage-for-apache-kafka/blob/main/s3/src/main/java/io/aiven/kafka/tiered/storage/s3/S3ClientWrapper.java#L75

Please read the comment in https://github.com/aiven/tiered-storage-for-apache-kafka/issues/126

With the new chunking approach ranged fetch queries are supported: https://github.com/aiven/tiered-storage-for-apache-kafka/blob/7e499717cdaf47af71f20aa00890b3b045b8d50b/core/src/main/java/io/aiven/kafka/tieredstorage/transform/FetchChunkEnumeration.java#L98


Added single button callbacks.

In my projects, I use retrolambda. The current design of ButtonCallback is not compatible with lambdas, and so results in boilerplate that could be avoided. This pull requests adds methods to the builder that can accept a lambda argument. So instead of needing to define this:
new MaterialDialog.Builder(this)
        .callback(new MaterialDialog.ButtonCallback() {
            @Override
            public void onPositive(MaterialDialog dialog) {
            }
        });

It's possible to define this instead:
new MaterialDialog.Builder(this)
        .onPositive(dialog -> {});

I left the current implementation in place for compatibility.

This is cool, thanks.
The only issue with this is that you removed the overridden final methods from ButtonCallback. They prevent Android Studio from suggesting that those methods be overridden.

I'll add them back myself though.

I'm curious, how did you get lambda expressions to work with Android?
Android technically does not support Java 8.

Oh nevermind, you used retrolambda


ffmpeg with [bzip2,lzma] x64-windows Debug build fails during configuration

This is because ffmpeg configure is checking for bz2.lib instead of bz2d.lib.
Same issue with lzma.lib and lzmad.lib.
Here's the pertinent output from config.log
check_lib bzlib bzlib.h BZ2_bzlibVersion -lbz2
check_func_headers bzlib.h BZ2_bzlibVersion -lbz2
test_ld cc -lbz2
test_cc
BEGIN ./ffconf.ZZkkEj22/test.c
    1	#include <bzlib.h>
    2	#include <stdint.h>
    3	long check_BZ2_bzlibVersion(void) { return (long) BZ2_bzlibVersion; }
    4	int main(void) { int ret = 0;
    5	 ret |= ((intptr_t)check_BZ2_bzlibVersion) & 0xFFFF;
    6	return ret; }
END ./ffconf.ZZkkEj22/test.c
cl -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_USE_MATH_DEFINES -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_WIN32_WINNT=0x0600 -DPIC -nologo -DHAVE_UNISTD_H=0 -MDd -c -Fo./ffconf.ZZkkEj22/test.o ./ffconf.ZZkkEj22/test.c
test.c
./ffconf.ZZkkEj22/test.c(3): warning C4311: 'type cast': pointer truncation from 'const char *(__cdecl *)(void)' to 'long'
/c/Dev/vcpkg/buildtrees/ffmpeg/src/ffmpeg-4-df5e227e2d/compat/windows/mslink -nologo -out:./ffconf.ZZkkEj22/test.exe ./ffconf.ZZkkEj22/test.o bz2.lib
LINK : fatal error LNK1181: cannot open input file 'bz2.lib'

Not sure what the preferable solution here is, whether to patch ffmpeg configure to look for bz2d.lib or modify the bzip2 port to also write a debug/lib/bz2.lib as a duplicate of debug/lib/bz2d.lib.
Here's the console output for reference:
PS C:\Dev\vcpkg> .\vcpkg.exe install ffmpeg[openssl,lzma,bzip2,vpx,x264,opencl,nonfree,gpl]:x64-windows
The following packages will be built and installed:
    ffmpeg[bzip2,core,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows
Starting package 1/1: ffmpeg:x64-windows
Building package ffmpeg[bzip2,core,gpl,lzma,nonfree,opencl,openssl,vpx,x264]:x64-windows...
-- Using cached C:/Dev/vcpkg/downloads/ffmpeg-4.1.tar.bz2
-- Extracting source C:/Dev/vcpkg/downloads/ffmpeg-4.1.tar.bz2
-- Applying patch create-lib-libraries.patch
-- Applying patch detect-openssl.patch
-- Applying patch configure_opencv.patch
-- Applying patch fix_windowsinclude-in-ffmpegexe-1.patch
-- Applying patch fix_windowsinclude-in-ffmpegexe-2.patch
-- Applying patch fix_libvpx_windows_linking.patch
-- Using source at C:/Dev/vcpkg/buildtrees/ffmpeg/src/ffmpeg-4-df5e227e2d
-- Acquiring MSYS Packages...
-- Acquiring MSYS Packages... OK
-- Building Options: --enable-asm --enable-yasm --disable-doc --enable-debug --enable-runtime-cpudetect --enable-nonfree
 --enable-gpl --enable-openssl --disable-ffmpeg --disable-ffplay --disable-ffprobe --enable-libvpx --enable-libx264 --en
able-opencl --enable-lzma --enable-bzlib  --extra-cflags=-DHAVE_UNISTD_H=0 --disable-static --enable-shared
-- Building ffmpeg for Release
-- Building ffmpeg for Debug
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:58 (message):
    Command failed: C:/Dev/vcpkg/downloads/tools/msys2/msys64/usr/bin/bash.exe --noprofile --norc C:/Dev/vcpkg/ports/ffm
peg\build.sh C:/Dev/vcpkg/buildtrees/ffmpeg/x64-windows-dbg C:/Dev/vcpkg/buildtrees/ffmpeg/src/ffmpeg-4-df5e227e2d C:/De
v/vcpkg/packages/ffmpeg_x64-windows/debug "--enable-asm --enable-yasm --disable-doc --enable-debug --enable-runtime-cpud
etect --enable-nonfree --enable-gpl --enable-openssl --disable-ffmpeg --disable-ffplay --disable-ffprobe --enable-libvpx
 --enable-libx264 --enable-opencl --enable-lzma --enable-bzlib  --extra-cflags=-DHAVE_UNISTD_H=0 --disable-static --enab
le-shared  --extra-cflags=-MDd --extra-cxxflags=-MDd"
    Working Directory: C:/Dev/vcpkg/buildtrees/ffmpeg/x64-windows-dbg
    Error code: 1
    See logs for more information:
      C:\Dev\vcpkg\buildtrees\ffmpeg\build-x64-windows-dbg-out.log

Call Stack (most recent call first):
  ports/ffmpeg/portfile.cmake:194 (vcpkg_execute_required_process)
  scripts/ports.cmake:73 (include)

Error: Building package ffmpeg:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: ffmpeg:x64-windows
  Vcpkg version: 2019.06.26-nohash

The Debug build succeeds when the bz2 and lzma debug libraries are renamed.

there is such, through meson a lot of libraries for debug version is simply not visible at Assembly of GTK and components
apparently the debug version is only for the VCPKG ecosystem

Copy bz2d.lib to bz2.lib and lzmad.lib to lzma.lib. Place both into a folder within the build tree after archive extraction using a move or copy operation. Add the folder containing bz2.lib and lzma.lib to the include path before the build starts.
Should be fairly trivial to do so within the portfile IMO.

Hi @toratora, thanks for reporting this issue.
I've fixed this issue. Please update vcpkg and rebuild ffmpeg.
Thanks.


Does sys.label LIKE '%bus%' still work if using the new Azure.Messaging.ServiceBus client library?

In the "Filter on system properties" section, the example sys.label LIKE '%bus%' is shown. Does this still hold for the new Azure.Messaging.ServiceBus client library?
Asking because the Message in the old Microsoft.Azure.ServiceBus client library has a Label property, while the ServiceBusMessage in Azure.Messaging.ServiceBus does not have a Label property, but a Subject property.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bce37cf-a134-9a2c-7c1e-81329ab5af72
Version Independent ID: f97acc7d-9936-ea76-0bdb-1838333abe57
Content: Set subscriptions filters in Azure Service Bus - Azure Service Bus
Content Source: articles/service-bus-messaging/service-bus-filter-examples.md
Service: service-bus-messaging
GitHub Login: @spelluru
Microsoft Alias: spelluru

@aleksandervalle Thank you for your feedback! We will review and update as appropriate.

@aleksandervalle Yes, your understanding is correct. As mentioned in the document here it will be system properties with few examples.
In case of If you are using Azure.Messaging.ServiceBus library the system properties will of class ServiceBusMessage properties.
Whereas for Microsoft.Azure.ServiceBus library the system properties will of class Message properties.
Feel free to get back to me if you have any queries or concerns.

@MayankBargali-MSFT Thanks for you response. I tried to create an SQL-filter using sys.Subject (since I'm using ServiceBusMessage), and got this error message:

servicebus.RulesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="The specified property Subject does not exist, or it is not a gettable property of the Microsoft.ServiceBus.Messaging.BrokeredMessage class.

I'm using Terraform to provision this rule, so I guess this might be a "problem" with Terraform or underlying Aure Resource Manager.
In essence, it's a tad unclear to me how (if at all) the properties usable in subscription filters are related to the particular client library you're using :)

@aleksandervalle Apology for the delay. Looks like I have misunderstood both libraries is use the same Subject field in the filter. @spelluru Any thoughts if it needs document update as the Subject is still valid.

@MayankBargali-MSFT - Please assign it to me. I will need to work with the product team to get a clarification on it. Thanks.

SQL filters are evaluated on the broker, so they wouldn't be using the updated names from the client. Users would need to continue using the old names from the Microsoft.Azure.ServiceBus Message type.

Added a note at the top.
#please-close


Formatting for Event between Start and End Date is thrown off by UTC

In multi format date, using the array of valid event dates, the adding of the "event" class is thrown off by the UTC date difference and sometimes excludes the last day of the range, i.e. 5-8 Jan will only show the "event" class for 5-7.  The actual object being returned by the onclick does still confirm that the date is part of the valid events.  I suspect it is because my local is ZA and my timezone is GB.
(day.isSame(end, 'day') ) RETURNS false, even though it is not really (is actually)
line 368 of clndr.js  (search for "woohoo semantics!"). :)
Below what is retuned on my side and effectively fails.
?day
{...}
proto: {...}
_d: Wed Jan 06 2016 00:00:00 GMT+0000
_i: [2016,0,6]
_isAMomentObject: true
_isUTC: true
_locale: {...}
_offset: 0
_pf: {...}
?end
{...}
proto: {...}
_d: Wed Jan 06 2016 00:00:00 GMT+0200 (South Africa Standard Time)
_f: "YYYY-MM-DD"
_i: "2016-01-06"
_isAMomentObject: true
_isUTC: false
_isValid: true
_locale: {...}
_pf: {...}
WORKAROUND:
If you know or are comfortable with the GMT difference, then you can specify a appropriate time in the Events Array - as below:
multidayMixedArray = [
{ title: 'Multi1', endDate: '2016-01-07 10:00:00', startDate: '2016-01-06 10:00:00',
etc.
Not ideal, but it worked for me.
See: http://stackoverflow.com/a/11805627/1662973 - just for clarification on date diff logic / problem.

@anthonyhorne Are you able to send a sample array of event data, and a sample config for me to plug this into the browser and replicate? I'm having trouble understanding the issue unfortunately, and I fear it might be due to having two competing timezones in your application.
I'll leave this open for a few weeks to allow you to send over any replication info, but I'll need that (preferably a JSBin) before I can step through any debugging.

@mikegioia Attached is the full example I used - working.  Does NOT work in edge, but works in Firefox (latest) - uses cookies for the array list Meeting / calendar data.  If you choose Jan 2016 (when I did the dev), and choose a option from the combobox on the bottom, it will populate the calendar with events that you can click on which shows some items on the right of the calendar.   As I say, it worked, but required me to include the time which allowed me to fool the time difference.  I still think the comparisons should be consistently UTC or not.  Ran out of time and am not using that dev anymore - hopefully someone else will benefit from the change, or it won't affect them in the first place :)
FullExample.zip

Thanks @anthonyhorne. Just FYI you're using an old version of CLNDR (1.2.4) that was giving me errors with multi-dates as well in both FF and Chrome. When I upgraded to 1.4.4 (latest) those errors went away.
I opened your example with CLNDR 1.4.4 in IE Edge it worked :D Could you try it with that version?

I'm going to close this out as its stale, but feel free to re-open the issue. I think it had to do with the old version though.


NTP hook support for ntpsec

Debian has apparently migrated to ntpsec as its preferred standalone NTP daemon for cases when timesyncd won't be used. Debian ships the config file as /etc/ntpsec/ntp.confwhich might require some adaptation to current NTP hooks. I'm unsure of whether dhcpcd's hooks will require any other finetuning to add support for this NTP daemon. I'm merely filing this report as a FYI. Cheers!

Returning to this bug, Debian ships the following NTP implementations (plus systemd-timesyncd, for which we already have a separate hook), with each configuration found as follows:

chrony: /etc/chrony/chrony.conf
ntpsec: /etc/ntpsec/ntp.conf
openntpd: /etc/openntpd/ntpd.conf

AFAIK the ntpsec config follows the traditional format of the reference NTP implementation.