Why is the loss function of fastflow negative, What are the meanings of pixel_F1Score  and pixel_AUROC？Thanks

hello

The loss is likelihood as general normalizing flow models. It will be helpful to search concepts of normalizing flow. In addition, fastflow predicts whether the pixel is anomaly. Pixel AUROC means the localization(segmentation) perfomance.

@leibaoer sorry for the late response. As @cytotoxicity8 mentioned, fastflow computes the loss by maximizing the negative log jacobian. You can see it defined here https://github.com/openvinotoolkit/anomalib/blob/main/anomalib/models/fastflow/loss.py#L27. Section 3.3 of the fastflow paper (https://arxiv.org/pdf/2111.07677.pdf) might make it more clear.


2.4.3 Version breaks compatibility with vrcfury + NDMF builder

Describe the bug / バグの説明
After some tests I see that when I upload an avatar with any vrcfury component in it and with the VQT avatar builder (NDMF) the builder gets an error about wrong materials, but all the materials I use are for quest. The issue is the vrcfury compatibility
To Reproduce / 再現手順

Install vrcfury and NDMF
Upload any avatar with a vrcfury component in it using the NDMF feature with VQT avatar builder

Expected behavior / 期待する動作
Upload the avatar succesfully
Screenshots / スクリーンショット
No response
Used assets / 使用したアセット
No response
VRCQuestTools version / VRCQuestToolsのバージョン
2.4.3
Unity version / Unityのバージョン
2022.3.22f1
Additional context / その他の情報
No response

When my avatar does not have any vrcfury components, it can be uploaded correctly

I'm not familiar at VRCFury. What component should I test?
Please describe about your case more specifically.

Any component, try adding vrcfury gestures component at the root of your avatar and then try to upload it with VQT builder and NDMF

Thank you for your info, the issue reproduced for me.
v2.4.3 changed the ndmf phase from transforming to optimizing when converting avatars. When using NDMF and VRCFury, NDMF optimizing phase is processed after VRCFury. But VRCFury rejects the avatar because of shaders, so VQT can't perform conversion.

I'm planning to revert the v2.4.3's change. So that VQT can perform before VRCFury as same as before.

We will still having the replacing multiple materials with the same one?

At the time of my screenshot, materials are not converted yet. VQT didn't perform because VRCFury rejected the build process.

Fixed by v2.5.0.

I think this should also be reported to VRCF side?
It is quite possible that there are other tools processing after VRCF (callbackOrder: -10000), and since it is known to actually exist, it can be considered inappropriate to validate the avatar and block the upload at that time.

My first investigation was mistake. NDMF optimizing phase runs after VRCFury, but VRCFury automatically removes invalid materials. So VQT can't detect materials to convert and it leads material error on actual devices.


Choose IL search type from find dialog

The find dialog allows you to search IL text, etc., but defaults to the current selected IL at the time the dialog was opened, without the ability to change it:

It should be possible to choose which IL to search from inside the find dialog.

This is related to the second bullet point in my recent comment in #2788.


vehicle detection error

@ahmetozlu When I run vehicle_counting.py the bounding boxes are getting displayed on the vehicles but when it passes the ROI line its not getting detected. please help me with this

Same as me. Any suggestion?

Please modify this line as considering your case specs (for example fps)! Thus, you can improve the accuracy of object counting module.

@ahmetozlu , i use the current code and also the sample video in this git. I don't make any change yet. but the result is 0 vehicle detected

+1 to this problem

+1

same issue. any solution to this?

fixed

@ahmetozlu - what was the fix? which line / python file ?

I think there's no so-call 'fix' here. As ahmetozlu tells, modify the line to improve the algorithm will help.


Add Readthedocs maintainers

Hi @reclosedev, would you be willing to add myself (https://readthedocs.org/profiles/JWCook/) and @skorokithakis (https://readthedocs.org/profiles/stavrosk/) as maintainers for the requests-cache project on Readthedocs?
I would like to add some automation rules for things like:

Publishing to /stable on git tags, so users don't see in-development changes there
Making multiple versions of the docs available, so a user can go to, for example, /v0.5.2 to see docs for the previous version

It would also be convenient for future maintenance if I could do things like manually trigger builds, activate previous versions, etc.
Thanks!

Hi! Done.

Thank you!


No More Regional Cringe

About the PR

Now without:

Russian cringe.
USA cringe.
Irland cringe.
Japanese cringe.
Chinese cringe.
Miami cringe.
African cringe.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

remove: Removed regional cringe.

spite pr

You forgot about Holidays: Christmas, Chinese new year, Friday 13th.

:trollface:


feature request: add support for low-end logic analyzers like the pi pico rp2040 or the Saleae Logic?

I have a circuit with a microcontroller that's talking to a i2c clockchip. In very rare cases, something goes wrong, and the time in the clockchip is wrong. The microcontroller also talks to the outside world via SPI and several uarts.
I would like to use ngscopeclient to monitor and decode the i2c communication to the clockchip. Then, when i see a jump in the time of the clockchip, I would like to see what the i2c, SPI and uarts pins were doing at that time, so i can figure out howto solve it.
Problem is, I don't have a way to capture the digital signals. I don't have one of the devices that are listed [1] as supported.
I do have a pi pico (rp2040) board that talks to sigrok via a serial-over-USB connection, with sigrok at the other end. [2,3].
I also have a Saleae_Logic that talks to sigrok via a USB connection. [4]
Is it possible to build support for such a solution into ngscopeclient?
How can I help that development?
[1] http://www.ngscopeclient.org/hardware.html
[2] https://hackaday.com/2022/03/02/need-a-logic-analyzer-use-your-pico/
[3] https://github.com/pico-coder/sigrok-pico
[4] https://sigrok.org/wiki/Saleae_Logic

There are open requests for fx2lafw (https://github.com/ngscopeclient/scopehal/issues/270) and Saleae (https://github.com/ngscopeclient/scopehal/issues/16) drivers but nobody is actively working on either.
We're still working on building out developer documentation, we have an API reference at https://www.ngscopeclient.org/devdocs/ but haven't had time to write a proper "how-to-make-a-driver" guide.
The tl;dr is you'll need to create a new class derived from SCPIOscilloscope (oscilloscopes and logic analyzers are treated the same internally, both can have analog and/or digital channels - a LA is simply a MSO with no analog channels) using an existing driver as a template. Then register it in DriverStaticInit() in scopehal.cpp so it'll be created when ngscopeclient starts up, and implement all of the necessary Oscilloscope methods for your desired functionality.
Note that ngscopeclient is BSD licensed and thus not compatible with GPL contributions (you can use our code in a patch to sigrok, but not the other way around).
if there is already a Sigrok driver for your target instrument, you may find https://github.com/ngscopeclient/scopehal-sigrok-bridge to be useful as a quick way to get things running. It's a dual licensed GPL/BSD tool that links against libsigrok and exposes instruments via a SCPI API over a TCP socket that ngscopeclient then connects to using the dslabs driver (providing both a license boundary and network transparency, allowing you to run ngscopeclient on a computer other than the one the LA is plugged into should you so desire). It was intended for use with DreamSourceLabs USB scopes/LAs like the DScope and DSLogic, and I think has bitrotted a bit, but it's probably closer to where you want to be than starting from scratch.


Error while exporting your games: Error while trying to write your Steam shortcuts

All my games work fine to load into Steam except Astroneer. It is not detected by name like the others but the aumid begins with SystemEraSoftworks.
I have logged into other accounts on Steam before. The error is showing a user account I havent logged into since 2017 (and doesnt have a config folder) while all the other games I added used the proper user/config/shortcuts.vdf file

I have the same issue. I click OK a few times and keep getting the same error message. After about 3 of 4 clicks it finally says it is successful and I can then run the game from the shortcut in Steam. I am curious why I am getting this error though.

For me too, I discovered after doing this a few times at least one or two had actually been added to Steam.

Same issue for me. Mine tried to write to Steam\userdata\0\config. I don't know why I had a 0 folder as I only have the one Steam account on my PC, but once I deleted out that folder and exported again everything seemed to work out ok.
Nothing seemed worthwhile that was in my 0 folder, and notably there was no config folder.

I've fixed this by creating the folder "config" in every Steam\userdata\x directory the error message mentions.

I'm getting this error to, pretty sure it's because my Steam is installed at "G:\Steam" and not the default location.
Any way to change where this thing thinks Steam is?

Shouldn't be caused by a non default location, as mine is in a custom location and didn't have this issue.

Well, it tried to put it in Program Files (x86), even though I have nothing Steam there.
Putting a symlink from there to my actual install location fixed this for me.

Creating a config folder in each folder in userdata fixed this for me, using this powershell script (run it from the userdata folder)
ForEach ($dir in (get-childitem -Path "./" | where {$_.mode -like 'd*'})){     New-Item -Path $dir.fullname -Name "config" -ItemType Directory }

首先，打开steam，随便添加一个非steam app，比如Microsoft Edge，然后，steam会自动生成这个文件。然后就可以正常使用了。


Fix golint issue caused by typo

Signed-off-by: Guangwen Feng<EMAIL_ADDRESS>

Thanks!


Problem with digit leaving the Dial on small screen

I have a problem where i have a left menu bar that is folded by default, when i unfold the menu bar the digit ket moved away from the dial.

Here is my layout in the html:

    InHg

And my js to generate it!
$(document).ready(function(){
console.log("Document is loaded!");
$(function() {
$("#vacKnob").knob({
'min':0,
'max':30,
'step':'.1',
'angleArc': 250,
'angleOffset':-125,
'width':100,
'height':100,
'fgColor':'#71b444',
'lineCap':'round',
'readOnly':true,
});
});
$("#vacKnob").val(0).trigger('change');
});

Also another question, how can i modify the max value once the main setup is done ?

if you use the plugin in this way you can improve html input number everywhere :
https://github.com/aterrien/jQuery-Knob/issues/365


grpc_status":14,"os_error":"unknown node or service"

What version of gRPC and what language are you using?
"grpc": "^1.12.2",  grpc-node
What operating system (Linux, Windows, …) and version?
Amazon AMI Node JS
What runtime / compiler are you using (e.g. python version or version of gcc)
GCC
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
What did you expect to see?
Grpc server should start
What did you see instead?
but i am getting server UNAVAILABL getting shutdown
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
 E0611 22:53:10.050183000<PHONE_NUMBER>94496 server_chttp2.cc:40]          {"created":"@1528737790.049739000","description":"getaddrinfo failed","file":"../deps/grpc/src/core/lib/iomgr/tcp_uv.cc","file_line":73,"grpc_status":14,"os_error":"unknown node or service"}  where is this coming from don't know !!
Anything else we should know about your project/environment?

/* eslint camelcase: 0 */

const grpc = require('grpc');

const path = require('path');
const GRPC_SERVER = `${global.configuration.grpc.host}:${global.configuration.grpc.port}`;

const proto = grpc.load(`${__dirname}/protos/site.proto`);

const server = new grpc.Server();

server.addService(proto.siteData.SiteService.service, {
  user(call, callback) {
    callback(null, { site_id: "1" , site_stauts:"Created"});
  }
});

server.bind('GRPC_SERVER', grpc.ServerCredentials.createInsecure());
server.start();
console.log('grpc server running on port:', GRPC_SERVER);

module.exports = server;

You're binding the server to the string 'GRPC_SERVER' instead of the value of that variable.


Ignore self-loops in DQM.add_linear_equality_constraint

Codecov Report

Merging #798 (7fe504a) into main (a56318d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   91.78%   91.78%
=======================================
  Files          63       63
  Lines        4676     4676
=======================================
  Hits         4292     4292
  Misses        384      384

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a56318d...7fe504a. Read the comment docs.

I had a bug in my original implementation -- or perhaps we need to decide what to do when the following happens:
terms =  [(u, 0, 1.0), (u, 0, 1.0), (v, 0, 1.0]
the expression above can be simplified to
terms =  [(u, 0, 2.0), (v, 0, 1.0]
but the original implementation and the current one simply ignores one of the terms with the repeated variable/case combination.

I did add a test with self loops?

Also, currently I am pretty sure the case you describe is added as desired, but I can test that.

there is a test for self-loop, but I was saying that we can add a random one as well.
I noticed in my testing that if the variable-case are both repeated, one of the terms is ignored.

Got it, I can add a test for that. Worth noting that unittests in general shouldn't be random :)

here are the two cases:
def case_1():
    num_variables = 4
    cases = np.random.randint(3, 6, size=num_variables)
    dqm_0 = dimod.DiscreteQuadraticModel()
    dqm = dimod.DiscreteQuadraticModel()
    for i in range(num_variables):
        dqm_0.add_variable(cases[i], i)
        dqm.add_variable(cases[i], i)
    x = dqm.variables

    expression1 = [(0, 0, 2), (1, 0, 2), (2, 1, 0), (3, 0, 8)]
    expression2 = [(0, 1, 2), (1, 1, 2), (2, 0, 0), (3, 1, 8)]
    expression = expression1 + expression2
    constant = np.random.randint(1, 10) * num_variables
    lagrange_multiplier = np.random.randint(1, 10)
    dqm.add_linear_equality_constraint(
        expression,
        lagrange_multiplier=lagrange_multiplier, constant=constant)

    expression_dict1 = {v: (c, b) for v, c, b in expression1}
    expression_dict2 = {v: (c, b) for v, c, b in expression2}

    for case_values in itertools.product(*(range(c) for c in cases)):
        state = {x[i]: case_values[i] for i in x}
        energy = dqm.energy(state) + lagrange_multiplier * constant ** 2
        s = constant
        for v, cv, bias in expression1:
            if expression_dict1[v][0] == state[v]:
                s += bias
        for v, cv, bias in expression2:
            if expression_dict2[v][0] == state[v]:
                s += bias
        assert (energy == lagrange_multiplier * s ** 2 + dqm_0.energy(state))

def case_2():
    num_variables = 4
    cases = np.random.randint(3, 6, size=num_variables)
    dqm_0 = dimod.DiscreteQuadraticModel()
    dqm = dimod.DiscreteQuadraticModel()
    for i in range(num_variables):
        dqm_0.add_variable(cases[i], i)
        dqm.add_variable(cases[i], i)
    x = dqm.variables

    expression1 = [(0, 0, 2), (1, 0, 2), (2, 1, 0), (3, 0, 8)]
    expression2 = [(0, 0, 2), (1, 0, 2), (2, 1, 0), (3, 0, 8)]
    expression = expression1 + expression2
    constant = np.random.randint(1, 10) * num_variables
    lagrange_multiplier = np.random.randint(1, 10)
    dqm.add_linear_equality_constraint(
        expression,
        lagrange_multiplier=lagrange_multiplier, constant=constant)

    expression_dict1 = {v: (c, b) for v, c, b in expression1}
    expression_dict2 = {v: (c, b) for v, c, b in expression2}

    for case_values in itertools.product(*(range(c) for c in cases)):
        state = {x[i]: case_values[i] for i in x}
        energy = dqm.energy(state) + lagrange_multiplier * constant ** 2
        s = constant
        for v, cv, bias in expression1:
            if expression_dict1[v][0] == state[v]:
                s += bias
        for v, cv, bias in expression2:
            if expression_dict2[v][0] == state[v]:
                s += bias
        assert (energy == lagrange_multiplier * s ** 2 + dqm_0.energy(state))

case_1 passes, case_2 fails.

Right, it's not that a term is ignored, here is a smaller test case
    def test_self_loop3(self):
        dqm1 = dimod.DiscreteQuadraticModel()
        dqm2 = dimod.DiscreteQuadraticModel()

        dqm1.add_variable(5)
        dqm2.add_variable(5)

        lagrange_multiplier = 1
        constant = 0
        dqm1.add_linear_equality_constraint(
            [(0, 0, 2), (0, 0, 2)],
            lagrange_multiplier=lagrange_multiplier,
            constant=constant)

        dqm2.add_linear_equality_constraint(
            [(0, 0, 4)],
            lagrange_multiplier=lagrange_multiplier,
            constant=constant)

        np.testing.assert_array_equal(dqm1.get_linear(0), dqm2.get_linear(0))

The problem is in the linear step. So we do lbias = lagrange_multiplier * biases[i] * (2 * constant + biases[i]) (source). So we get
case1 == 1*2*(2*0+2) + 1*2*(2*0+2) == 8
case2 == 1*4*(2*0+4) == 16

So, the solution is to sort the variables/cases/biases on input and deduplicate. This obviously will have some performance implications. Though it will be O(nlog(n)) in where n is the number of terms. This will be dominated by the O(n**2) operation which constructs the bqm.

Ok, this time for real. @hsadeghidw , can you retest?

will do

passes all tests now


Interface for filtering "sources"

The interface should make it simple and safe way to filter underlying source data

The current approach is doing something like:
import pandas as pd
from pandas_ts.packer import pack_flat

sources = pd.DataFrame({id=..., time=..., mag=...})
packed: pd.Series = pack_flat(sources, name="sources")
# Do something with packed
new_sources = packed.ts.to_flat()
new_sources = new_sources[new_sources['mag'] < 99]
new_packed = pack_flat(new_sources, name="new_sources")

Could be also solved with #9

Implemented with #34 and #32


FieldValue functions/sentinels not working properly since v3.8

I upgraded this library today to 3.8 and broke my app. Looks like the issue is with FieldValue.timestamp() and FieldValue.increment(..) and maybe others, though I've only checked these. Basically these values aren't getting to the server it appears. It works for every version up till 3.8, the current latest, so presumably something in there has busted this.
Note I am testing against the gcloud emulator running in Docker (mtlynch/firestore-emulator-docker) ... it's a fairly significant break so perhaps I've missed something obvious here, or this is even a weird incompatibility with the emulator.
Environment details

OS: MacOSX
Node.js version: 12.6
npm version: 6.13.4
@google-cloud/firestore version: 3.8

Steps to reproduce

Run the following code - basically just the "quickstart" in the doc modified to use FieldValue:

const { Firestore, FieldValue } = require('@google-cloud/firestore');

// Create a new client
const firestore = new Firestore();

async function quickstart() {
  // Obtain a document reference.
  const document = firestore.doc('posts/intro-to-firestore');

  // Enter new data into the document.
  const data = {
    title: 'Welcome to Firestore',
    body: 'Hello World',
    num: 1,
    date: FieldValue.serverTimestamp(),
  };
  await document.set(data);
  console.log('Entered new data into the document: ', data);

  // Update an existing document.
  const update = {
    body: 'My first Firestore app',
    num: FieldValue.increment(1),
  };
  await document.update(update);
  console.log('Updated an existing document: ', update);

  // Read the document.
  let doc = await document.get();
  console.log('Read the document, data: ', doc.data());

  // Delete the document.
  await document.delete();
  console.log('Deleted the document');
}
quickstart();

Note the output shows the sentinels basically being ignored:
jesss-mbp:repository $ node test.js
Entered new data into the document:  {
  title: 'Welcome to Firestore',
  body: 'Hello World',
  num: 1,
  date: ServerTimestampTransform {}
}
Updated an existing document:  {
  body: 'My first Firestore app',
  num: NumericIncrementTransform { operand: 1 }
}
Read the document, data:  {
  num: 1,
  body: 'My first Firestore app',
  title: 'Welcome to Firestore'
}
Deleted the document

Now revert the version of the library to 3.7.5 and try again... much better:

jesss-mbp:repository $ npm install<EMAIL_ADDRESS>
jesss-mbp:repository $ node test.js
Entered new data into the document:  {
  title: 'Welcome to Firestore',
  body: 'Hello World',
  num: 1,
  date: ServerTimestampTransform {}
}
Updated an existing document:  {
  body: 'My first Firestore app',
  num: NumericIncrementTransform { operand: 1 }
}
Read the document, data:  {
  date: Timestamp { _seconds:<PHONE_NUMBER>, _nanoseconds: 887000000 },
  num: 2,
  body: 'My first Firestore app',
  title: 'Welcome to Firestore'
}
Deleted the document

@jessmorecroft Thanks for filing this!
Note that issues like these are almost always due to version conflicts between two different instances of @google-cloud/firestore. While you only seem to be using a single version in your code, do you mind double-checking (via npm list). There is no obvious change in 3.8 that would have affected this behavior.
With your repro, I get:
Entered new data into the document:  {
  title: 'Welcome to Firestore',
  body: 'Hello World',
  num: 1,
  date: ServerTimestampTransform {}
}
Updated an existing document:  {
  body: 'My first Firestore app',
  num: NumericIncrementTransform { operand: 1 }
}
Read the document, data:  {
  body: 'My first Firestore app',
  num: 2,
  date: Timestamp { _seconds:<PHONE_NUMBER>, _nanoseconds: 655000000 },
  title: 'Welcome to Firestore'
}
Deleted the document

package.json:
{
  "name": "quickstart",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@google-cloud/firestore": "^3.8.0"
  }
}

Hi @schmidt-sebastian,
Just tried this and still no luck.
jesss-mbp:repository jessmorecroft$ npm list | grep firestore
├─┬<EMAIL_ADDRESS>
FYI, my package file at the bottom. Basically I'm trying to upgrade the library in my repo (https://gitlab.com/jmorecroft/repository) and my sentinel test is now failing.. could this be some weird incompatibility with the emulator introduced in the latest version perhaps?
Here's the gcloud version installed on the Docker image I'm using showing the emulator version:
/ # gcloud --version
Google Cloud SDK 270.0.0
beta 2019.05.17
bq 2.0.49
cloud-firestore-emulator 1.10.0
core 2019.11.04
gsutil 4.46

package.json:
{
  "name": "@jmorecroft67/repository",
  "version": "3.0.0",
  "description": "Generic repository interface and implementations for Firestore and in-memory.",
  "main": "dist/index.js",
  "scripts": {
    "prebuild": "rimraf dist",
    "build": "tsc -p tsconfig.build.json",
    "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
    "test": "node node_modules/.bin/jest --runInBand",
    "test:watch": "jest --watch",
    "test:cov": "jest --coverage",
    "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
    "test:e2e": "jest --config ./test/jest-e2e.json",
    "postversion": "git push --follow-tags"
  },
  "files": [
    "/dist"
  ],
  "types": "dist/index.d.ts",
  "repository": {
    "type": "git",
    "url": "https://gitlab.com/jmorecroft/repository.git"
  },
  "keywords": [
    "repository",
    "firestore"
  ],
  "author": "Jess Morecroft",
  "license": "ISC",
  "bugs": {
    "url": "https://gitlab.com/jmorecroft/repository.git"
  },
  "homepage": "https://gitlab.com/jmorecroft/repository/-/blob/master/README.md",
  "dependencies": {
    "@google-cloud/firestore": "^3.8.0",
    "diff-arrays-of-objects": "^1.1.5",
    "fp-ts": "^2.5.2",
    "io-ts": "^2.1.2",
    "io-ts-types": "^0.5.6",
    "monocle-ts": "^2.1.0",
    "newtype-ts": "^0.3.4",
    "rxjs": "^6.5.4",
    "uuid": "^7.0.1"
  },
  "devDependencies": {
    "@types/jest": "^25.1.3",
    "@types/node": "^13.7.7",
    "@types/uuid": "^7.0.0",
    "@typescript-eslint/eslint-plugin": "^2.21.0",
    "@typescript-eslint/parser": "^2.21.0",
    "eslint": "^6.8.0",
    "eslint-config-prettier": "^6.10.0",
    "eslint-plugin-import": "^2.20.1",
    "jest": "^25.1.0",
    "prettier": "^1.19.1",
    "ts-jest": "^25.2.1",
    "ts-node": "^8.6.2",
    "typescript": "^3.8.2"
  },
  "jest": {
    "moduleFileExtensions": [
      "js",
      "json",
      "ts"
    ],
    "rootDir": "src",
    "testRegex": ".spec.ts$",
    "transform": {
      "^.+\\.(t|j)s$": "ts-jest"
    },
    "coverageDirectory": "../coverage",
    "testEnvironment": "node"
  }
}

I am not sure how to proceed further here. We have seen a lot of reports with strange behavior on Jest is used. Have you tried disabling Jest to see if this issue reproduces?
See also here: https://github.com/firebase/firebase-admin-node/issues/793

Hi Sebastian,
I don’t think that’d matter as am not using Jest here, but will have a play.
Can you clarify how you are testing? Are you connecting to an emulator or Firestore proper? If the former what version of the emulator are you using?
Cheers
Jess

I cannot repro the issue against Firestore production or the emulator.

Hi again @schmidt-sebastian ,
Well I think I figured it out. I just upgraded my emulator via gcloud components upgrade and it now works. So obviously there's an incompatibility with 3.8 and the older Firestore emulation. As I say, works fine with 3.7.5 so there must something in 3.8.0 that doesn't play nicely. Easy enough to fix for my local testing just by using the later gcloud.. unfortunately the docker image I'm using in my CI is configured/fixed to the earlier version of gcloud so I'll have to find another image.
To be clear, this emulator version is not working:
jesss-mbp:~ jessmorecroft$ gcloud --version
Google Cloud SDK 279.0.0
beta 2019.05.17
bq 2.0.53
cloud-datastore-emulator 2.1.0
cloud-firestore-emulator 1.10.2
core 2020.01.31
gsutil 4.47
kubectl 2019.11.04
Updates are available for some Cloud SDK components.  To install them,
please run:
  $ gcloud components update

This updated version is working:
jesss-mbp:~ jessmorecroft$ gcloud --version
Google Cloud SDK 293.0.0
beta 2019.05.17
bq 2.0.57
cloud-datastore-emulator 2.1.0
cloud-firestore-emulator 1.11.3
core 2020.05.15
gsutil 4.50
kubectl 2020.05.01

Thanks for your help.
Cheers
Jess

I checked with one of the contributors of the Emulator. They cannot explain the behavior you observed, but they also mentioned that there is likely nothing they can do since they only support the latest emulator version. Given that, I will close this issue. Please do let us know if this happens to block you again.
Thank you for your patience!

How bizarre!
No problem. I’ll just be sure to use a later version.
Thanks for taking a look.


"runtime: fatal error: sweep increased allocation count" in rclone mount

I'd like to keep you all updated on a bug in go that I found while using rclone mount (rclone v1.35-DEV).
The command runs fine, but when I start using the mount, go/rclone mount crashes spectacularly (see my traces in upstream bug report).
Maybe some of you rclone devs want to chip in to help the go folks solve this bug in go1.8rc3 (and apparently also in go1.7.5):
https://github.com/golang/go/issues/19029
it seems like they need help in finding the source of an rclone structure they see in the memory dump, "five []byte all taken from the same underlying array." Can anyone help them with that?

I'll take a look and see if I can help - thanks for the heads up!

@ncw, can you recreate this bug by following my instructions?

This looks like a frozen bug in GO so not sure there is much left to do for this one. If this is still something that needs work, let me know and we can capture the right information for it.
Thanks!


Add Code of Conduct

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>As the title says.

@rhatdan PTAL

I think we can delete this repository, @baude ?


test_fd

New test for the symbolic finite differences against polynomial.
Allowed me to find a sign error.
The sign is removed from finite_differences as it was a hack for adjoints. The time-axis PR will introduce proper adjoint flag.
IN PROGRESS

This needs PR 176 first

This is good to go?

It's a yes for me. You'll have to rebase on master first though. Is this OK with you @mlange05 ?

Yes, looks good to me. Merging....


How do you setup TOR and a VPN on your computer?

This might be a pretty straight forward question where the answer could be any link to any tutorial explaining the hows and whys and all but I want to add one thing:
Is your browsing experience terrible with those enabled and if not why? :laughing:
(cuz whenever I do, I get the worst and slowest experience of all time – and I've been on the web with a 28.8k modem back in the days)

For Tor I use the Torbrowser with the default settings. It mostly works fine but if it’s too slow you can still try to get a new route.
For VPN there are a lot of privacy services but I use only two options here:

My own VPN which is running on my router (mostly not for privacy reasons, won’t help for VDS)
Disconnect Premium service. Block privacy leaking scripts and provides a secure, fast VPN for Desktop and iPhone (but it seems Apple just removed their app from the AppStore, glad I still have it)

Got the hint that https://proxy.sh/ is also a got bet for a VPN.

Thanks for the answers.
Related question: what do you think of the new EpicBrowser? Built on Chrome (currently 40) with built-in Tor Proxy and autoblocking all tracking scripts and so on and so forth...
I gave it a try and while the blocking and privacy is truely amazing, the speed make the whole experience not so much worthwhile. =(

Oh, I don’t know it. Honestly, I’d only use the official browser but it’s up to you and if it’s open source it might be totally fine to use it.


Compiler crashing Neovim

Pylyzer version: v0.0.62
Neovim version: v0.9.1
Cargo version: 1.81
Installed Pylyzer with Mason, and opening a python file results in a The compiler has crashed error message. Error from logs below.
[ERROR][2024-09-25 14:15:39] .../vim/lsp/rpc.lua:734	"rpc"	"C:\\Users\\Username\\AppData\\Local\\nvim-data\\mason\\bin\\pylyzer.CMD"	"stderr"	"thread 'start_auto_diagnostics' panicked at C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\erg_compiler-0.6.45-nightly.0\\context\\instantiate.rs:290:17:\ninternal error: entered unreachable code: D / ?D / ?D\n"

Maybe it's fixed in the latest version.


refactoring the me handler for subscribe/publish the event

This should be done in the module itself.

Done.


Treat STRING to BOOLEAN data type change as backward compatible schema change

Description
In #6719 we introduced the native BOOLEAN data type support. Before the native support, BOOLEAN data type is stored as STRING within the schema.
To keep existing schema backward compatible, when different field specs are found and the new field spec has BOOLEAN data type, set the new field spec's data type to STRING and compare again. If they match, count it as backward compatible schema change.

Codecov Report

Merging #7259 (ad50672) into master (066c793) will decrease coverage by 8.22%.
The diff coverage is 64.28%.

:exclamation: Current head ad50672 differs from pull request most recent head ad8e102. Consider uploading reports for the commit ad8e102 to get more accurate results

@@             Coverage Diff              @@
##             master    #7259      +/-   ##
============================================
- Coverage     73.53%   65.30%   -8.23%
  Complexity       92       92
============================================
  Files          1508     1508
  Lines         73999    74002       +3
  Branches      10691    10693       +2
============================================
- Hits          54413    48327    -6086
- Misses        16020    22252    +6232
+ Partials       3566     3423     -143

Flag
Coverage Δ

integration
?

unittests
65.30% <64.28%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ntroller/helix/core/PinotHelixResourceManager.java
59.27% <25.00%> (-3.17%)
:arrow_down:

...rc/main/java/org/apache/pinot/spi/data/Schema.java
76.06% <80.00%> (+0.44%)
:arrow_up:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pache/pinot/common/utils/grpc/GrpcQueryClient.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...t/core/startree/plan/StarTreeDocIdSetPlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ot/common/restlet/resources/TableMetadataInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../core/startree/plan/StarTreeTransformPlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 355 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 066c793...ad8e102. Read the comment docs.


The standalone-integration-tests-check CI job went missing

The standalone-integration-tests-check CI job went missing, and now the SDK's manual integration test Cargo.toml files no longer match the generated Cargo.toml files, which makes local development much harder since many of them don't even compile.

[ ] Restore checks for the manual Cargo.toml files (originally added in https://github.com/awslabs/smithy-rs/commit/21df7234a64a5f48d3b800158048dcf878295083)
[ ] Fix integration test builds

Looks like the check was removed in 6fa7b36812e19fbfff02b5938672a6c0f5ce69bd


Extend spo web set welcomePage. Closes #1730

Pull Request Title

Extends 'spo web set' command with support for adding Welcome page. Closes #1730

Linked Issue

Closes #1730

Coverage remained the same at 100.0% when pulling 6aaf9bbc754104d8d305d28df483d64df171e412 on arjunumenon:1730-web-set-welcomePage into 9b70527cc776495e73e5644b2b271cb120a26871 on pnp:master.

Thank you 👏🏻 We will review it shortly!

Merged manually. Thank you! 👏

Very nicely done with a few minor changes I've done when merging the PR 👍

Thanks @waldekmastykarz . You are being humble by telling "few minor changes" in the review. 😂😂.. Thanks anyways for making the changes and approving the PR.
I have learned a lot of things with this.. Thank you... 🖖🖖🖖

My pleasure and thank YOU for all the hard work. Great to have you with us 😊


Replace actualConfiguration with consensus configuration: [ECR-3612]

Overview
Provide access to consensus configuration instead of all configuration
according with the changes in core.
Remove the Java types representing the consensus configuration
in favour of the generated protobuf messages.

See: https://jira.bf.local/browse/ECR-3612
Definition of Done

[x] There are no TODOs left in the code
[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[x] Method preconditions are checked and documented in the Javadoc of the method
[x] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage decreased (-0.1%) to 85.819% when pulling e4dca44dab2218e866caf4e41c8925d7ecec19b5 on dmitry-timofeev:add-consensus-config-ECR-3612 into 655eb58c40ad6c228e7f9458e210cc347e4b0116 on exonum:dynamic-services.


sentiments.py:54-56: Extract first 15-20 words from first...

The puzzle 153-c5f98a2f from #153 has to be resolved:
https://github.com/h1alexbel/sr-detection/blob/c86fda0c316212b0cb4eb20f4aad5d986cf96f54/sr-data/src/sr_data/steps/sentiments.py#L54-L56
The puzzle was created by @h1alexbel on 18-Nov-24.
Estimate: 35 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd Main quality problem: Lack of clear problem description. Suggestion: Add a concise description...

I see you're talking to me, but I can't reply since I'm not a chat bot.


Performance Counters (FetchSize, WriteSize)

Description

Hi, using RenderDoc, I was able to capture and analyze frames for the sake of understanding graphics workloads. The captured frames are from 3DMark (Time Spy). I observed an unreasonable behavior across the captured frames (the attached frame is one of them). For a given frame, the overall frame duration seems reasonable and inline with the reported FPS. However, the FetchSize + WriteSize, reported in bytes, seems unreasonable as we observed terabytes of requested data from memory. Such size along with the frame duration leads to unrealistic bandwidth. The used GPU has a memory bandwidth of 1 TB/Second. I suspect that FetchSize and WriteSize are reporting 1000X more.
Steps to reproduce

Open RenderDoc.
Open the attached capture with the default options.
OneDrive Link (RDC File + Log File): https://1drv.ms/u/s!AuNZOSQ8XvnBg-gzE7Fl7lv5F6VoXw?e=FSFpyr
Open the Performance Counter Viewer.
Select AMD -> GlobalMemory -> FetchSize/WriteSize Counters.
Capture counters.

Environment

RenderDoc Version v1.9
AMD Radeon VII GPU
Windows 10 Pro, Version 2004
AMD Ryzen Threadripper 2950x 16-Core Processor 3.5 GHz
128 GB RAM
3DMark (Time Spy)

RenderDoc is only intended for capturing your own programs. Capturing copyrighted programs that you do not have the rights to is not endorsed and I will provide absolutely no support for it.


omnicored is generating blocks much more than bitcoin mainnet

I am running a USDT node, it supposed to sync the bitcoin block chain to local.
But very strange, after days, I check the block count and find it has blocks much more than mainnet (714286 vs 524091). And the number is keep growing for about 5 blocks per second.
$ omnicore-cli -datadir=/usdt/data -conf=/usdt/omnicore.conf getblockcount
714286
$ bitcoin-cli -datadir=/btc/data -conf=/btc/bitcoin.conf getblockcount
524091
It is correct? Why it is happening?

My mistake, no such issue.

Hi @dexX7, it is not a real problem, please forget about it.
Extra blocks were come from testnet. Someone changed the omnicore.conf to run against the testnet, but haven't told me.


feat: Drop card v2

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[x] Feature

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #9797

continue to #9830

resolve code conflict with scheduled drops
several bugs fix
small code refactor

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary
copilot:summary
copilot:poem

Thanks!
pay 50 usd

😍 Perfect, I’ve sent the payout
💵 $50 @ 9.11 USD/DOT ~ 5.488 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x3aa314728a6744146acaed8e229b7c47d92d8433c068d7b9226115d07ec0a741
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


changes to detect HDF5 HL, build with CRT and detect ZLIB in HDF5

these are the changes explained in
#848
https://github.com/Unidata/netcdf-c/issues/848

Thanks!


chore(docker): Upgrade PnPM to the latest version

Commit message typo in "PnPM", should be "PNPM" (or "pnpm"). Fun fact: When verifiying the capitalization, I realized that https://pnpm.io/ shows a different capitalization each time your refresh the page... funny guys 😆

Commit message typo in "PnPM", should be "PNPM" (or "pnpm"). Fun fact: When verifiying the capitalization, I realized that https://pnpm.io/ shows a different capitalization each time your refresh the page... funny guys 😆

Thanks for the info. That page was infact the source of my PnPM capitalization variant.


Update fr.yml for version <IP_ADDRESS>

Hey @Nogapra, so sorry for the ridiculously long delay, seems like I never saw this pull request, would ya be able to reupdate the French file if ya like, as there are some conflicts and I would not like to mess up getting the correctly translation trying to fix it!

No problem, all of us more or less busy so no worries,
a lot of updates have been released since I will completely redo the trads from the latest version.
So you can close this Pull Request I will recreate a fresh one as soon as I have a moment, it will be easier for me, I have always struggled with the conflict resolution system of Github ^^


project file (.vcxproj) missing

Hi,
Trying to build the repository but the project file is missing so not sure how it links to dependencies and what they are.
Thanks

Hello NPatch,
project file updated,
now I need to find some time to compile the latest coin3d on windows and linux.

I tried with Boost 1.45.0.
Also I had to download coin, sowin(GUI) and simage(texture loader) and use the same installation directory for all(so gl3dv can find them easily). Also built for both Debug, Release for VS2019 x64.
Had to reset all overridden paths(e.g. output, intermediary etc) in gl3dv solution due to issues(some of them didn't match).
This is minor, but changed COIN3DDIR to Coin_DIR as an environment var name as it seems to be recommended by coin( https://github.com/coin3d/coin/pull/241).
Lastly, check out property sheets in VS.  Library dependencies in VS can be a bit easier to deal with. Added bonus, aggregating all include paths in one INCLUDE_DEPENDENCY_PATHS means you can later just use the User Macros sheet to add a new library without moving around for different options.


Having active_record_vis_endpoint feature flag enabled, sync datasets appear as regular datasets

Fixes #3319

@juanignaciosl CR please.
I've removed a few fields not needed to be exposed to the outside.

Frontend tests were OK :+1: (details)

:+1:


Fix ndarray dimension signedness, fix ndarray length overflow, close #3519

hi @nlohmann, sorry for the new bug from my code.
I debugged this, and found there were two issues:

the dimension vector elements were not written in the correct signedness
when the total length overflew, the length resets to 0 and did not raise an error.

with this patch, I was able to fix both, an additional test was added to verify both, the fuzzer data now raise an "excessive ndarray size caused overflow" error.
One thing I want to verify with you is the error code, now I am using 113, let me know if there is a better code. if the length is non-zero and passed to sax functions, it raise a 408 error "excessive array size". but I am capturing this overflow before that.

Coverage remained the same at 100.0% when pulling bccd7aeef20efffd1eb8fdf191b8533759565133 on NeuroJSON:issue3519 into b6d00d18974358ab1d55dcc3379d0ee3052deb4e on nlohmann:develop.

There is still an issue with MSVC 2019.

More accurately, 32bit builds, which should be a clue.

I think this is what happened: when reading the uint64 number in the dimension vector on a 32 bit windows, the overflow happened earlier, i.e when reading the uint64 M... record to a 4-byte size_t dim element, it is stored as 0, and then the below code returned an empty array
https://github.com/nlohmann/json/blob/b6d00d18974358ab1d55dcc3379d0ee3052deb4e/include/nlohmann/detail/input/binary_reader.hpp#L2153-L2160
I am wondering if there is a way for me to tell when an overflow happen when reading a large number on win32?

Because the size of std::size_t is dependent on architecture/platform, when assigning a value to std::size_t, you'll have to manually check if a given value fits.
Somehting like this should suffice:
#include <limits>
if(value > std::numeric_limits<std::size_t>::max()) throw ...;

Because the size of std::size_t is dependent on architecture/platform, when assigning a value to std::size_t, you'll have to manually check if a given value fits.

now I am wondering why this was not tested in other binary formats, for example UBJSON?
upon reading this part of the test, is it true that the test simply compares the overflowed value and allow overflow to happen on 32 bit system?
https://github.com/nlohmann/json/blob/develop/tests/src/unit-ubjson.cpp#L510-L558

The test uses number_integer_t and std::uint64_t both are 64bit types. The problem only arises when std::size_t is used, because that is most likely going to be an unsigned 32bit integer on 32bit systems.
Whenever a 64bit value is read and used as the size for a container, that's where things can go wrong.
I'm curious if the UBJSON code accounts for this or why it doesn't need to.

I added the below if (number > std::numeric_limits<std::size_t>::max()){...} block in the 'L' and 'M' marker handling in get_ubjson_size_value(). I also added a if(sizeof(size_t)==4) {...} else {...} in the test. The test runs fine on my 64bit machine, but I am not entirely sure how this change will UBJSON's tests on win32. should I commit and test?
            case 'L':
            {
                std::int64_t number{};
                if (JSON_HEDLEY_UNLIKELY(!get_number(input_format, number)))
                {
                    return false;
                }
                if (number < 0)
                {
                    return sax->parse_error(chars_read, get_token_string(), parse_error::create(113, chars_read,
                                            exception_message(input_format, "count in an optimized container must be positive", "size"), nullptr));
                }
                if (number > std::numeric_limits<std::size_t>::max())
                {
                    return sax->parse_error(chars_read, get_token_string(), parse_error::create(408, chars_read,
                                            exception_message(input_format, "integer value overflow", "size"), nullptr));
                }
                result = static_cast<std::size_t>(number);
                return true;
            }

Depending on your compiler, you may be able to build 32bit executables by configuring the CMake project with -DCMAKE_CXX_FLAGS="-m32".
Otherwise, just commit and run it through CI.

@falbrechtskirchinger, thanks, after installing cross-compilation packages, I was able to test it on -m32. Just commited the change, but realized that coverage will be a problem ...

/__w/json/json/include/nlohmann/detail/input/binary_reader.hpp:2082:28: error: result of comparison 'std::int64_t' (aka 'long') ><PHONE_NUMBER>3709551615 is always false [-Werror,-Wtautological-type-limit-compare]
                if (number > std::numeric_limits<std::size_t>::max())
                    ~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I figured that would be a problem but couldn't think of the proper warning flag when I tested. Let me see if I can come up with a better solution ...

I have a proof of concept. This might be overengineered.
@fangq I'll sleep on it and submit a PR against your branch tomorrow (for reference, it's past 9 pm here) if I can't come up with a less involved solution.
template<typename T, typename U, bool = (std::numeric_limits<U>::max() < std::numeric_limits<T>::max()), typename = std::enable_if_t<std::is_unsigned_v<T> && std::is_unsigned_v<U>>>
struct value_in_range_of_impl;

template<typename T, typename U>
struct value_in_range_of_impl<T, U, false>
{
    static constexpr bool test(U val) { return val < std::numeric_limits<T>::max(); }
};

template<typename T, typename U>
struct value_in_range_of_impl<T, U, true>
{
    static constexpr bool test(U /*val*/) { return true; }
};

template<typename T>
constexpr bool value_in_range_of_size_t(T val)
{
    return value_in_range_of_impl<std::size_t, T>::test(val);
}

I tried to open a PR and NeuroJSON/json does not appear in the list (I've opened a GH support ticket about that).
Meanwhile, you can git remote add my repository and git cherry-pick the commits from my branch issue3519-trait (https://github.com/falbrechtskirchinger/json/commits/issue3519-trait). Don't know about your git knowledge - happy to help if you need it.
There's still a problem with the UBJSON unit test. I assume that's because the range check changes the exception type.

@nlohmann How would like to address coverage?
if (number > std::numeric_limits<std::size_t>::max())
{
    return sax->parse_error(chars_read, get_token_string(), parse_error::create(408, chars_read,
        exception_message(input_format, "integer value overflow", "size"), nullptr));
}

Are you okay with excluding this line, as it's only reachable on 32bit targets?
If that's acceptable, I might as well open another PR instead of having @fangq go through the trouble of cherry-picking from my branch.

@falbrechtskirchinger I would rather have a test suite compiled with 32 bits that test exactly this issue.

How would that work with coverage/coveralls? I'm not super familiar with lcov/gcov. Is it possible to collect coverage information from multiple builds?

How would that work with coverage/coveralls? I'm not super familiar with lcov/gcov. Is it possible to collect coverage information from multiple builds?

We collect coverage reports for anything executed by CTest. If we have another test binary that contains tests relevant for 32 bits and add it to the test suite, the results should appear in the coverage report automatically.

Ok, a separate test shouldn't be too difficult. I just need to figure out, when -m32 is available (probably via cmake_try_compile or whatever it's called).


Use vndr instead of godep.

To support container streaming, I need to import the streaming server from kubernetes. However, it's impossible to do that correctly with Godep.
You'll keep getting following error although no packages we are depending on are using it:
$ godep save ./...
godep: Package (github.com/docker/distribution/digest) not found

So as to avoid future trouble and make cri-containerd consistent with moby, containerd and cri-o, let's switch to vndr instead.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Also updated the README.md to include information about how to update dependencies.

LGTM

Over in CONTRIBUTING.md you'll need to modify or delete the part about godep...
https://github.com/kubernetes-incubator/cri-containerd/blob/master/CONTRIBUTING.md#adding-dependencies
Or just move this readme edit to contributing.md

Sorry. I thought contributing is linking to outside the repo, and just found that it's inside the repo.

@mikebrow Done.


Re-enable user profiles & use users name and avatar on incoming payments that use default Liquid naming in their titles

This PR addresses

https://github.com/breez/misty-breez/issues/165

User profiles are re-enabled and various bugs are fixed with picking & saving avatar images.
Incoming payments with default Liquid naming in their titles will now use "Payment to <-username->" in their title and use user's avatar as their image.
Changelist:

Re-enabled user profiles f4f41997f1916cac222df6edd4c2e9dc69fc69b0
Fix bugs with persisting avatar image file 1e002f1bd07d3a1a5a8fe48e09d147e9d156392e
Replace default payment titles with liquid naming on incoming payments b6704e1113bbb91f3b5c3f1c61dce38a1a2878aa

Use "Payment to <-your-username->" as payment title.
Display users avatar on payment list for these payments.

Remove artificial delay on saving avatar changes fcb03b2de040b88b09956530222b4ee993f0d20b
Address crop issues on gallery picked images for avatars 5ba5134e4de3873a9dd16fa3d27233a8d3b29566

Use 1:1 ratio when cropping images

Update payment list when user changes their avatar to reflect username & avatar changes 7acb40cb75360b1350a5d4068d2e84105fd559ea

@roeierez Caching alone had issues as I imagined, I've addressed the iOS issue without using platform specific code by using relative path the access the image file & implemented caching to improve loading speed & reduce disk access.

Use relative path to access profile image saved on application documents directory
Implement caching for profile images to improve loading speed and reduce disk access


Fatal ExecutionEngineException when process has hidden windows without composition target

Commit 2a5da54671990381 changed the navigation tree to include all windows of the process. This may include windows that have been created but not yet shown. Such windows do not have a composition target yet and cannot be layouted. But using them as source of a VisualBrush will forcibly layout them and trigger WPF-internal asserts that crash the process (the managed debugger displays a fatal exception indicating process corruption which is not the case here).
Simple repro: Create a new empty WPF project and add this to the MainWindow:
public partial class MainWindow
{
    private Window window = new Window {
        Visibility = Visibility.Hidden // Must be hidden (not collapsed) to not skip layouting.
    };

    public MainWindow()
    {
        InitializeComponent();
    }
}

Thank you @gix. This has been merged into Snoop master.

Hey, by the way @gix ... I love your https://github.com/gix/PresentationTheme.Aero project. Would love to toy with that sometime.


Update glyphsLib requirement

Hey folks,
I've updated the pip requirements so fontmake now uses glyphLib's pr googlei18n/glyphsLib@43e199d99e7caaad0d8f3c5b1751ce4ade9a0b89
Thanks,
Marc

did you sign the CLA?

Yep, all signed up.
Thanks again Cosimo.

Hey, I can't merge this yet because git thinks there are conflicts with other recent updates to requirements.txt. Could you resolve and push?

Hi James,
I'll close this and submit another pr.
Thanks


Add more emojis to the README

Every good README could use some extra emoji flair! I would love to see some added to it 😄

Hello @Lunarelements, how are you? Congratulations for this project.
I've added some emojis, feel free to change if you don't approve of any of them.
😁

Hey there @lucalves, I appreciate the help! Hope your holidays are going well!


Readme indentation

Could we make the readme code snippet indentation consistent?
Some samples look like
var couchdb = nock('http://myapp.iriscouch.com')
                .get('/users/1')
                .reply(200, {
                  _id: '123ABC',
                  _rev: '946B7D1C',
                  username: 'pgte',
                  email<EMAIL_ADDRESS>                 });

others
var scope = nock('http://www.example.com')
    .get('/resource')
    .reply(200, 'domain matched');

still others
nock('http://example.com')
  .get('/users')
  .query({name: 'pedro', surname: 'teixeira'})
  .reply(200, {results: [{id: 'pgte'}]});

I'd be happy to fix this given a decision on which style to use.

@morenoh149 Let's fold this into #838


feat(http): object values for token header and claims

Coverage decreased (-0.8%) to 96.583% when pulling e415b291e03f6db8f342d9f37fb2a52f02903d86 on object_token_claims into 11e5bf6b0631d91814bb2285ed4855c371dc4897 on main.


added JsonStringLocalizer & added Sass dar

List of changes in this pull request.

Added JSON Based Localization
Use Dart Sass instead of Sass

Both translation files present in Client/Resources (the MainMenu ones) should be in ClientUI.Components/Shared

Both translation files present in Client/Resources (the MainMenu ones) should be in ClientUI.Components/Shared since they're associated with the MainMenu.razor file. This is so we can reuse those resource files when in webasm mode (note just in server mode).

Good point! I moved  ClientUI/Resources into ClientUI.Components/Resources. Should the resources be in one place (all JSON files in the resources folder) or beside the razor file?

In Resources folder (structure 2):

📁 Resources

📁 MainMenu

en.json
fr.json

This approach looks pretty good actually! I didn't know we could use subfolders as type names! Makes things a lot cleaner.


iPad Multitasking support requires launch story board in bundle

In project settings from Xcode, we need to check the Requires full screen option. Looking into finding a way we can do this from the command line, otherwise platforms-as-artifacts is useless for iOS


Responsive modal at mobile

I think that the modal isn't responsive at mobile, it cover all the screen, as you can see.

By design, the modal will take the fullscreen in mobile, which arguably is a better experience for mobile
https://github.com/aldabil21/react-scheduler/blob/4a498ce4dd3534456d2ef044740d54b1af86f556/src/lib/views/Editor.tsx#L230
Since you are using a custom editor, you are in charge of arranging the modal fields and buttons. You could make it better though, here is an example with the same fields you are using.


Move Ingress (status) controller from Pilot to Galley

Pilot has an K8s ingress controller that listens and updates status of the Ingress resource. As part of making Pilot less dependent on K8s, we should move it to Galley.

@ozevren are you working on this, if not I would like to help with this one.

Hey @Nino-K sorry, I missed the tag. I am currently not working on it, feel free to grab it. Thanks!

@Nino-K are you still working on this?

@Nino-K are you still on this?

No I have not done any work on this, as I got involved in other works with higher priority. Feel free to unassigned me.

@utako, were you still planning to work on this?

@ayj, yes! I'm starting out by fitting the existing Pilot status controller into the pattern in the Galley server. were people in the config wg hoping for a full rewrite? were there problems

Given Istiod movement I don't think this is required


rethink token pricing

ethink how tokens are priced currently. pricing currently works in two different approaches, due to historical reasons:

A cron that queries coingecko and updates all tokens that have a coingecko ID (queried by their address) using the coingecko price. Price will be the same across all chains
A cron that updates prices through stacked and prioritized price handlers. Whenever a price handler can price a token, it will not be priced by following handlers. This results in prices per chain where the last price handler will be the swaps price handler.

There are a few problems and considerations with this approach:

Do we need prices per chain or could we also only do "global" pricing?
If coingecko is down, we don't have a fall back, as the tokens that have a coingecko ID, are excluded from approach 2
Since we'll need token groups for multichain filters, could we also leverage the approach for pricing? e.g. DAI will have one price across all chains
we will most probably need to make sure we can "exclude" tokens from these pricing groups to make sure we can account for "depegged" assets (see multichain on fantom)

also token grouping (as requested by frontend) is part of this

think about reward tokens not in pools

first draft

New iteration

We store multiple prices for the same token, we do not use the pricingId. It creates more problems as it solves. Only downside is that we have "duplicate" prices. The DB should be able to handle it.

We still store all price data in either the currentPrice table or the tokenPrice table. No hourly/daily tables.


bug(focus indicators): Focus indicators are now positioned.

Just as every .mat-ripple is positioned in order to create an easy API for developers, every .mat-focus-indicator should be positioned. This way, when developers add the class .mat-focus-indicator to their own custom focusable elements they do not also need to position the element.
As a result of positioning every .mat-focus-indicator, a few components that set position: absolute on the associated element need to have their specificity bumped.
In testing this change, I fixed a few bugs as a result of https://github.com/angular/components/pull/19304 (comments inline).

@jelbourn Before merging this, let's close on whether the style .mat-focus-indicator { position: relative; } should be within mat-strong-focus-indicators or mat-core. See the associated comment on the PR.

TGP LGTM, sent the link to you @jelbourn.

Addressed naming comment, rebased and squashed commits.


SMA-27 Account Recovery Module: fixes upon audit

Summary

Added a check for the outer method selector for the userOp.callData to avoid call to other methods rather than default executor
Now guardians sign controlMessage + SA.address. This is even more secure in terms of revealing guardians address across SAs.
Removed unneeded conditional

TODO: technically validAfter = request.timestamp + securityDelay may overflow as both validAfter and securityDelay are uint48s. Making securityDelay an uint24 should solve issue however it will limit delay to 194 days (which is enough I think).
Waiting confirmation from auditors on this matter.
Related Issue: # SMA-27
Change Type

[x] Bug Fix

Checklist

[x] My code follows this project's style guidelines
[x] I've reviewed my own code
[x] I've added comments for any hard-to-understand areas
[x] I've updated the documentation if necessary
[x] My changes generate no new warnings
[x] I've added tests that prove my fix is effective or my feature works
[x] All unit tests pass locally with my changes
[x] Any dependent changes have been merged and published

resolve conflicts

all comments addressed


gRPC metrics: Add per-message metrics.

Blocked waiting on https://github.com/census-instrumentation/opencensus-specs/pull/206.

Codecov Report

Merging #1563 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1563      +/-   ##
============================================
+ Coverage     83.08%   83.15%   +0.07%
  Complexity     1703     1703
============================================
  Files           255      255
  Lines          7810     7850      +40
  Branches        752      752
============================================
+ Hits           6489     6528      +39
  Misses         1101     1101
- Partials        220      221       +1

Impacted Files
Coverage Δ
Complexity Δ

...a/io/opencensus/contrib/grpc/metrics/RpcViews.java
71.42% <ø> (ø)
11 <0> (ø)
:arrow_down:

...nsus/contrib/grpc/metrics/RpcMeasureConstants.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

...ncensus/contrib/grpc/metrics/RpcViewConstants.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

...census/implcore/trace/export/SpanExporterImpl.java
91.78% <0%> (-1.37%)
8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11f47b...3a0e68a. Read the comment docs.

Note that we must define the *_COUNT measures in Java, in order to do the mapping to internal resources. This may not be the case for other languages and the *_COUNT measures are not in the specs.

Reverted https://github.com/census-instrumentation/opencensus-java/pull/1563/commits/bd37f103445fb4eb0d6469971cc9e7a6fe7c733a. We can do some internal mapping to get the counts.

Updated per https://github.com/census-instrumentation/opencensus-specs/pull/212, PTAL.

Thanks!


Doesn't work with 2FA / MFA

This method does not work with 2FA sms authenticated account....

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39fbe5a2-c138-b566-c094-82ffc3d1b734
Version Independent ID: 4d69ee5d-5a6d-a203-69fe-bf5441a8b5eb
Content: Connect to Exchange Online PowerShell
Content Source: exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/connect-to-exchange-online-powershell.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

@nidelius see the MFA specific instructions here: https://docs.microsoft.com/powershell/exchange/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell

PLEASE add these instructions inside the document itself, not just in the comment

@VNJoe, are you able to update or suggest updates to the Partner Center docs? If so, they should be linking to https://docs.microsoft.com/powershell/exchange/exchange-online/exchange-online-powershell-v2/exchange-online-powershell-v2 for how to connect to Exchange Online PowerShell.
That's the best and most future-proof link (works with or without MFA).

No, I'm not.  I'm not a Microsoft employee.  I don't believe anyone DOESN'T need the new method who's a partner, as we all need MFA.  But they're saying it's called out at the top of the document, when really, the old way is (or should be) deprecated, I think? No partner doesn't need Powershell for Exchange, and no partner doesn't need to have MFA enabled, so if its a Partner Center doc....

@VNJoe, let's take a step back. I want to help fix the issue.

I've asked around an no one seems to know the whereabouts of the offending "Partner Center" doc that contains the non-MFA connection instructions link that you mentioned. If you have access to the doc, you're one up on me, and I thought you might be able to edit it or at least suggest changes to it. I wan't trying to imply that you were a Microsoft employee. I would ask for the link to the topic here, but I probably can't access it, anyway, so I'm not going to ask..

It sounds like the best fix for that offending topic is to replace the bad link with EXO V2 module link. That will 100% work for everyone using MFA.

If/when the old method of connecting to ExO PowerShell goes away, then the topic will go away. Until then, it stays. We already have a big "doesn't work for MFA" call-out and link at the top, so that's the best we can do for now.


Does FluentValidation actually work in the master repo?

Hi Thanks for raising an issue,
To be honest, I'm not actively developing on this codebase - it was used to create some code samples to support a talk - and the focus was on EF Core features and examples.
You can find some better-maintained samples (including fluent validation) on the repos of my colleague jason taylor:
https://github.com/JasonGT/NorthwindTraders
https://github.com/JasonGT/CleanArchitecture


Use of -bundleForClass: for getting resources

Since cocoapods 0.36.1.beta, which introduces Frameworks and Swift, -bundleForClass must be used instead of mainBundle:
http://blog.cocoapods.org/Pod-Authors-Guide-to-CocoaPods-Frameworks/
I've made the changes to make the pod compatible for that

Great! I will merge it once CocoaPods 0.36 becomes mainstream. Thank you for contributing.

Hi,
CocoaPods 0.36 is now official out, could you please merge it?
I'm using your pod in a few apps, and I'd like to point to the official one ;-)
Thnaks

Sorry for the late reply. I am on it.

what happened here?

It's been merged. I am really sorry for the delay.


Please provide apt repo

Hi,
Please provide an apt repository, enabling users to keep their machines up-to-date.
For example with Github Pages.

I want to do this with the supervised installer too

It would be really great if the software was available in a repo.


Border Radius of Popover Menu is incorrect

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
There are two issues:

Mini Menu

Sign into the app
Hover over any message
Note that the mini menu looks like this:

Link Popover

Sign into the app

Hover over any link
Note that it looks like this:

Expected Result:
Describe what you think should've happened
The border radius for the mini menu should have it appear circluar.
The boarder radius for the link popover should not be a pill shape.
Actual Result:
Describe what actually happened
They're both the opposite of the Expected Results.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cf116c84fb1d9f8a
Upwork Job ID:<PHONE_NUMBER>308433408

Hey @zanyrenney, sorry for the noise, I'm just going to fix this one up real fast.

Can I be reporter of this as I reported it here https://expensify.slack.com/archives/C049HHMV9SM/p1669645639980109?

Actually @zanyrenney would you be willing to pay out @parasharrajat for reporting this issue?

Yep, let me mark this as external so it creates the Upwork issue.

@parasharrajat have invited you to the job on upwork.

Thanks, @zanyrenney. Please assign me to the issue as well because I am reviewing the PR.

Mini Menu
When hovering over a message, you can give the border-radius of the object in css.
Example:
.message:hover {  border-radius: 100px }

Link Popover
You can add popover function by using plugins like bootstrap.

Can someone add Reviewing label?

Added that @parasharrajat - thanks!

Heading OOO so reassigning to get @parasharrajat 's questions answered and paid out.

@parasharrajat , I'm helping get issues paid around holidays, how much are you due for this?

Thanks @parasharrajat , I'm assuming you meant you're due $1250 in total so I bonused you $1000 to get there.
@slafortune you or I need to do the regression test.  I'll try to get to this week

Bug:  (Dark Theme) Mini menu hover style is not correct.
Bug:  (Dark Theme) Padding of multi line tooltip does not look correct.

I can't remember if we ever settled on when to pay for multiple bug reports that are fixed by the same PR.  What we want to avoid is contributors reporting a bunch of variations on the same bug, knowing that it might be fixed by one PR.      @parasharrajat , would you say....

You or another engineer might or should have known the bugs were related?
The two bugs could have been fixed separately but you were able to combine them into one to make things easier?

Paid @parasharrajat $250, it appears to be an edge case where we chose to fix two bugs in one issue/PR.
@parasharrajat  @Luke9389 , can you complete the BZ checklist above plz?
https://github.com/Expensify/App/issues/13213#issuecomment-1349861728


Necessity of SVG position and viewbox?

When executing canvg on a page with leaflet, the SVG gets shifted out of position and put into the wrong place.  This also occurs when using html2canvas.  (html2canvas is used as a part of leaflet-image.)
http://jsfiddle.net/difftech/f7e87oqb/1/

See note below for info on running

The cause is _updateSvgViewport in Path.SVG.js.  It sets a style position and sets the viewbox.  In the browser, removing the style positioning and setting the viewbox x and y values to both be 0 fixes this problem and places the SVGs in their same original position.   In the _updateSvgViewport function directly, doing something like this works the same:
	if(root.tagName !== 'svg') { // or just remove these 2 lines altogether
		L.DomUtil.setPosition(root, min);
		root.setAttribute('viewBox', [min.x, min.y, width, height].join(' '));
	}
	root.setAttribute('width', width);
	root.setAttribute('height', height);

Altering the code as above doesn't seem to make any difference to the functionality (zooming, panning, etc), so it seems like an ok change.  Are the position and viewbox necessary?

Note: For leaflet in this example, the option to disable 3d needs to be used so that it doesn't have the translate3d which canvg doesn't seem to support. So in this fiddle, you can put a breakpoint when the check for t.L_DISABLE_3D occurs in mapbox.js. And execute this line t.L_DISABLE_3D = true.

I reported a similar issue  #3313. I thought the svg positioning was due to the zoom animation being enabled. When i disabled it, it seemed to fix. I will go back and take a look at my code for capturing an image from a leaflet map containing svg markers.


Unable to open the specified log file. No such file or directory

How can I solve this? Thanks!

Solved! It just needs to set the right path to access.log. It should be /var/log/nginx/access.log. There are other log files in /var/log/nginx/, how about those log files? Is it already included in report.html?

You need to parse each access log.
goaccess /var/log/nginx/access.log /var/log/nginx/access.log.1 ...

OR
zcat /var/log/nginx/access.log.*.gz | goaccess access.log -

Thanks for the clarification!

how can this be solved in docker? because i'm getting the same error.
i have created /srv/logs/access.log
and i mounted it in the docker command like this -v "/srv/goaccess/logs:/srv/logs"

@M034B5 Did you follow this?

@M034B5 Did you follow this?

Oops forgot to update my post, everything ran smoothly. I skimmed through some closed issues back then and solved my problem, Documentation lacks a lot of information. But all good now. Thanks!

@M034B5 Did you follow this?

Oops forgot to update my post, everything ran smoothly. I skimmed through some closed issues back then and solved my problem, Documentation lacks a lot of information. But all good now. Thanks!

Mind sharing your findings? I'm having the same issue.

@lelas Are you still having this issue? Can you please share how you are running goaccess? also, are you able to tail the log?


Uncaught ReferenceError: figma is not defined

Getting figma is not defined error when I try to get selected node in ui.tsx file
  const handleClick = () => {
    const selectedNode = getSelectedNodesOrAllNodes();
  };

How do I access utilities?

Turns out you are only able to access figma global object from main.ts and exchange data between ui.tsx main.ts via events for ex: on('event_name', data) once('event_name', data) emit('event_name', data).


Add prop for SQForm fields to allow 'validation' as informational text

Use case:
We need to implement design and business requirements that require informational text to a SQForm field, similar to Validation.
Any place there is validation we need the ability for informational text, including to SQFormMultiselect, since there is currently no mechanism to override what the form engine is doing for validation text generation.
This is needed for the following input types:

Figma Fields examples: https://www.figma.com/file/DsJr2cFZqMYkOX6VjcuhqW/SC3-DESIGN-LIBRARY?node-id=1518%3A11678&t=IWwH5R2yzR5UNulh-0

This seems to be a duplicate of #882
Closing