Import existing Azure resources issue

If I want to import existing resources (in my case because I'm getting an error when creating the resources via composer), it's not clear what resources need to be created and where we get the information from in order to update the json.  The "Import existing Azure resources" section would benefit from more information on how to do this manually.
I'm looking at the Bot Framework SDK documentation as a reference to see if I can do it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3462131-c17c-c9e1-106c-390e0bdb523d
Version Independent ID: bd203f82-3725-6df6-1aef-9ffad92fa7fa
Content: Publish a bot to Azure - Bot Composer
Content Source: composer-docs/how-to-publish-bot.md
Service: bot-composer
GitHub Login: @zxyanliu
Microsoft Alias: kamrani

Hi @tiagonmas which SDK documentation are you reading as a reference? The one you shared still point to https://docs.microsoft.com/en-us/composer/how-to-publish-bot

Sorry, sent the wrong link. I'm looking at https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-deploy-az-cli?view=azure-bot-service-4.0&tabs=csharp but also not having a lot of luck there as the ARM template is giving me some error :(

Did you get any progress on this?

Did you get any progress on this?

not yet as I was hoping to get more guidance from you or resolution on the open issues.

not yet as I was hoping to get more guidance from you or resolution on the open issues.

Any more guidance on how we can publish our bot manually ? Need a work around to the publish bot functionality not working. We have the solution runtime that I think has everything that is needed to publish the bot. It's just not clear what steps we manually need to do, things to configure ... would be great to have that documented.

Any more guidance on how we can publish our bot manually ? Need a work around to the publish bot functionality not working. We have the solution runtime that I think has everything that is needed to publish the bot. It's just not clear what steps we manually need to do, things to configure ... would be great to have that documented.

The content to Import existing Azure sources is being updated but not yet published.
It is recommended that you read instructions in the following issue:
https://github.com/microsoft/BotFramework-Composer/issues/5456#issuecomment-777870194

I've been using the workaround to e #73 and it's working fine. So I don't need to publish manually any more. thanks

Cool! I am working on a script-based provision and publish article. Will keep you posted on this. Closing this issue for now.
Thanks again for your patience.


sgx_urts: implement Drop trait for SgxEnclave

Any thoughts on this? It'd be nice to not have
to remember to call destroy() before the SgxEnclave
goes out of scope.

Thanks for your contribution! @jbowens


Added regex listener, added http post request with regex match

Need the backend to really test this, but I think it is simple enough. Used the official Documents: https://hubot.github.com/docs/scripting/

:+1:  Looks simple enough.

Gonna add testing


Fixed all hyperlinks in guide-ru documentation

Q
A

Is bugfix?
Yes

New feature?
No

Breaks BC?
No

Tests pass?
Yes

Fixed issues
No

Looks wrong to me. It works w/o the change.


control-tower-customizations relies on outdated libraries & runtimes and looks abandoned

Is your feature request related to a problem? Please describe.
We are evaluating a configuration mechanism for an environment with hundreds of accounts using AWS Control Tower. Customizations for AWS Control Tower (CfCT) is officially documented solution for the problem. However, according to the CHANGELOG the project seems abandoned. Latest version is from 2022. Also request for transparency did not result in a public roadmap.
The project is built on soon-to-be-deprecated version of Python (3.8), refers to Ruby 2.6 while 3.2 already exists and is using aws/codebuild/standard:5.0 when the latest version is 7.
Describe the feature you'd like
We would highly appreciate public roadmap as with other AWS products (CDK, CloudFormation) and up-to-date libraries as the currently used versions do not look very professional for the tooling which is the most critical part of maintaining highly-secured AWS environments.
If CfCT has been superseded with another tool, it could be articulated in a clearer way in the documentation to guide users there and provide a migration path.
Regards,
Markus

Thank you for reaching out @markusl I want to reiterate that CfCT remains a fully supported service under the AWS Control Tower umbrella. Since features for CfCT are prioritized against those for the Control Tower service, new releases can sometimes be infrequent. Over the last year, the team has prioritized building public APIs for Control Tower and supporting scale for large enterprises. We will continue to address bugs reported by customers and prioritize enhancements depending on the Control Tower backlog. We cannot share future roadmaps in public forums, but we do plan to continually enhance the CfCT solution.
In addition, I have created an item in our backlog to update these dependencies.

AWS Just annonunced: "We are ending support for Python 3.8 in Lambda on October 14, 2024. This follows Python 3.8 End-Of-Life (EOL) which is scheduled for October, 2024 [1]." The most current CfCT release (v2.7.0) relies on Lambda running the python version being EOLed. Kindly address ASAP!
https://github.com/aws-solutions/aws-control-tower-customizations/blob/2fa6e6170230dc97410006897e389a3146b5be23/customizations-for-aws-control-tower.template#L1043C1-L1043C25
https://github.com/aws-solutions/aws-control-tower-customizations/blob/2fa6e6170230dc97410006897e389a3146b5be23/customizations-for-aws-control-tower.template#L1317
https://github.com/aws-solutions/aws-control-tower-customizations/blob/2fa6e6170230dc97410006897e389a3146b5be23/customizations-for-aws-control-tower.template#L2911


Clarify .dockerignore example for Markdown files

The current documentation correctly states that dockerignore pattern
searches are non-recursive. However, the example given for Markdown
files seems to contradict this by saying that *.md will exclude all
Markdown files. This commit clarifies the situation by explicitly
specifying that *.md will only exclude files in the root directory of
the project.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:timwraight/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

once signed, LGTM

Thanks!, LGTM
ping @fredlf @jamtur01 @SvenDowideit

LGTM

Thanks for this, @timwraight!

No worries, @thaJeztah, thanks for Docker!

cherry-picked


The ↑ arrow not correctly working

Thanks for this tool.
I just began to test some of the features.
I found the up arrow not working ( the down arrow is ok).
To be detailed, the up-arrow will only work once to select two items, as follows:

My environment is Win10.
Please check it.
And, I found this tool reacts really snow in my side, wondering some problem here in Windows?

Yeah I fixed all those issues. It was due to an update I did for #2, unfortunately I missed a few selectors and it sort of messed everything up :(

Thanks and take it easy. Will wait the new version :)

Should be live now!


Use DefaultUncaughtExceptionHandler to log the uncached exception

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (0b873e6) 38.04% compared to head (c25bae3) 38.03%.

:exclamation: Current head c25bae3 differs from pull request most recent head 0a90348. Consider uploading reports for the commit 0a90348 to get more accurate results

Files
Patch %
Lines

...hinscheduler/alert/metrics/AlertServerMetrics.java
0.00%
4 Missing :warning:

...dolphinscheduler/api/metrics/ApiServerMetrics.java
0.00%
4 Missing :warning:

...ler/server/master/metrics/MasterServerMetrics.java
0.00%
4 Missing :warning:

...ler/server/worker/metrics/WorkerServerMetrics.java
0.00%
4 Missing :warning:

...org/apache/dolphinscheduler/alert/AlertServer.java
0.00%
2 Missing :warning:

...che/dolphinscheduler/api/ApiApplicationServer.java
0.00%
2 Missing :warning:

...lphinscheduler/common/thread/BaseDaemonThread.java
0.00%
2 Missing :warning:

...e/dolphinscheduler/server/master/MasterServer.java
0.00%
2 Missing :warning:

...uler/server/master/registry/ServerNodeManager.java
0.00%
2 Missing :warning:

...e/dolphinscheduler/server/worker/WorkerServer.java
0.00%
2 Missing :warning:

... and 8 more

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15496      +/-   ##
============================================
- Coverage     38.04%   38.03%   -0.02%
- Complexity     4688     4692       +4
============================================
  Files          1304     1304
  Lines         44770    44754      -16
  Branches       4799     4776      -23
============================================
- Hits          17031    17020      -11
+ Misses        25888    25885       -3
+ Partials       1851     1849       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PIP-199: Create a robust and inline Client Feature Matrix page

Motivation
As the outcome of PIP-108, the Client Feature Matrix has addressed the initial user request for technology evaluation and selection. It has been linked on Pulsar doc site, providing an overview of feature supportability on language-specific clients.
However, it has the following limitations to continually serving the purpose over time:

Visibility: Not prominent for users/maintainers to notice.
Process control: No required review/approval or version control.
Accuracy: A bit out-of-dated with limited chances to get it updated (possibly caused by 1&2).

Goal
As an extension/enhancement to PIP-108, this proposal aims to make the existing client feature matrix more robust and prominent to address the above pain points and better serve the adoption purpose.
Implementation

Note: Instead of showing a full version to duplicate the existing feature matrix, this PIP aims to build a compact version with key features listed to serve the adoption purpose better, while users can still visit the existing full version via the link.

Deliver a more robust Client Feature Matrix and required documentation through a thorough review and update.
----@RobertIndie and @shibd will be working on adding the information for missing features and supportability in language-specific clients.
Work out a compact feature list that makes more sense for adoption from a user perspective. ---- @ericsyh @liudezhi2098 reviewed the feature list.
Build the compact matrix on a web page to provide a better reading experience. Reference.  ---- @urfreespace has researched it.

Thanks for starting this discussion. I'd like to mention my previous attempt on this direction https://github.com/apache/pulsar-site/issues/146.
I will take a closer look at this proposal. Generally, I'd prefer inline the current feature matrix into each client's document entries instead of displaying the big feature matrix map in another approach - it consumes substantial developer efforts while it may not provide too much value.

@tisonkun thanks for your suggestion. Maintaining a matrix provides a chance to do a horizontal comparison within the same set of features. I think it provides value to both maintainers and users in the whole picture.

@momo-jun Yeah. If only there were volunteers who are willing to do it instead of "need developer resources".
Do you have a more concrete design and implementation? This proposal is far more than actionable now.

@tisonkun This is just a heads-up. I haven't got a concrete design or implementation plan yet.
The questions you listed are good ones that need to be clarified. I will add more details and discuss it in the community soon.

Move it to pending at this time point since there has been no feedback on the discussion thread yet and no engineering resources to build the page.
Will revisit it later.

This PIP has been WIP since last week. I've updated the description and will add more details as soon as we have a bare bone to demo.

awesome!


Remove a custom done callback from the Observer

This didn't end up being used by anything

Also @Andarist the tests fail when this is removed.

@Andarist Tests still fail 😢


[BUG] Ensure token-wrapper fee recipient has existential deposit

Issue summary
The token wrapper pallet sends the fee for every wrap call to the fee recipient address, if the fee recipient address does not already have ED, the transfer will fail with Existential Deposit error for small amounts.
T::Currency::transfer(
			from_currency_id,
			&from,
			&Self::get_fee_recipient(&asset_details.name),
			Self::get_wrapping_fee(amount, into_pool_share_id)?,
		)?;

We need to populate the fee recipient address with ED at genesis or consider an alternate approach for fee here.
https://github.com/webb-tools/protocol-substrate/blob/f0c637dc00625f65a7df28acd2d5f463c5f833c3/pallets/token-wrapper/src/lib.rs#L436

Adding some funds to the fee recipient address is not the best solution here, since we technically could change the fee recipient at any point using proposal-like runtime transaction or directly using sudo, for example.
A better way is to expose get_amount_to_wrap using a storage/RPC or a runtime call for example so that the user have to first consider the amount they will need to input + fees. This method will take the amount that I want to wrap and returns the total amount (including the fees) that I can pass to the token wrapper or the vanchor. On the other side, this method also should consider that the fees >= existential deposit and returns a more readable error for the user.


Fixed a challenge validation error.

You can't validate the challenge, unless you change project-tile to project-title.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #31785

LGTM! This fixes bug #31785 and is a more complete fix than the more recent #34097.

@lynxlynxlynx Thanks for referencing the issue number, I've updated the description.


Fix Go downloading issue

$ make
mkdir -p go-1.11.5
rm -f go-1.11.5/bin/go
Downloading and unpacking Go 1.11.5.linux-amd64 to go-1.11.5
curl -s https://dl.google.com/go/go1.11.5.linux-amd64.tar.gz | tar xf - --strip-components=1 -C go-1.11.5
tar: Archive is compressed. Use -z option
tar: Error is not recoverable: exiting now
Makefile:29: recipe for target 'go-1.11.5/bin/go' failed
make: *** [go-1.11.5/bin/go] Error 2

I'll merge but with note that root makefile is not for general use and will go away at some point.  go get is desired source ops workflow


Support OpenSBI Linux

Recently https://risc-v-getting-started-guide.readthedocs.io/en/latest/linux-qemu.html is updated. It no longer uses bbl and instead uses the OpenSBI. We should support it.

Done


Importing from other files

This could be something like:
A: YAML-resolver
foo:
  type: string
  from:
    yaml:
      path: foo.yml
      key: foo

B: YAML-resolver and "hash" type
variables:
  foo:
    type: hash
    from:
      yaml: foo.yml

services:
  dog:
     environment:
       - "FOO=${foo[bar]}"

C: Subgroups and YAML-resolver
variables:
  foo:
    type: group
    from:
      yaml: foo.yml

services:
  dog:
     environment:
       - "FOO=${foo.bar}"

Looks like all variations include a YAML-resolver. All variations can probably coexist nicely so maybe no choice is necessary.
Filename interpolation
The yaml filename should probably be interpolatable, and to not break kontena YAML reader, it should probably go something like:
  from:
    yaml:
      path:
        interpolate: ${foofile}
      key: foo

(kontena-cli interpolator skips any lines that start with /\s+interpolate: because opto interpolates those lines on its own)

Closed through #42


HADOOP-17210 Backport HADOOP-15691 PathCapabilities

This is the backport to branch-3.2
see: [https://issues.apache.org/jira/browse/HADOOP-17210)(https://issues.apache.org/jira/browse/HADOOP-17210)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
10m 23s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-3.2 Compile Tests _

+0 :ok:
mvndep
3m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 35s
branch-3.2 passed

+1 :green_heart:
compile
14m 19s
branch-3.2 passed

+1 :green_heart:
checkstyle
2m 44s
branch-3.2 passed

+1 :green_heart:
mvnsite
5m 14s
branch-3.2 passed

+1 :green_heart:
shadedclient
21m 47s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
4m 17s
branch-3.2 passed

+0 :ok:
spotbugs
0m 47s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 44s
branch-3.2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
13m 38s
the patch passed

+1 :green_heart:
javac
13m 38s
the patch passed

-0 :warning:
checkstyle
2m 41s
root: The patch generated 12 new + 594 unchanged - 1 fixed = 606 total (was 595)

+1 :green_heart:
mvnsite
5m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 45s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
4m 18s
the patch passed

+1 :green_heart:
findbugs
8m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m  0s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 58s
hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
4m 52s
hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
unit
4m 45s
hadoop-aws in the patch passed.

+1 :green_heart:
unit
1m 37s
hadoop-azure in the patch passed.

+1 :green_heart:
unit
1m  0s
hadoop-azure-datalake in the patch passed.

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

164m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2231

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 8011ac3de4b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
branch-3.2 / 9aa78fe

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~16.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/1/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/1/testReport/

Max. process+thread count
1393 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-tools/hadoop-azure-datalake U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

did an s3a test run for strictness; throttle tests failed because the S3guard table was pay-on-demand. Probably time to just cut that test, but not here

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ branch-3.2 Compile Tests _

+0 :ok:
mvndep
3m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 26s
branch-3.2 passed

+1 :green_heart:
compile
14m 17s
branch-3.2 passed

+1 :green_heart:
checkstyle
2m 42s
branch-3.2 passed

+1 :green_heart:
mvnsite
5m 12s
branch-3.2 passed

+1 :green_heart:
shadedclient
21m 29s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
4m 17s
branch-3.2 passed

+0 :ok:
spotbugs
0m 43s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 43s
branch-3.2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
13m 56s
the patch passed

+1 :green_heart:
javac
13m 56s
the patch passed

-0 :warning:
checkstyle
2m 42s
root: The patch generated 4 new + 594 unchanged - 1 fixed = 598 total (was 595)

+1 :green_heart:
mvnsite
5m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 19s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
4m 15s
the patch passed

+1 :green_heart:
findbugs
8m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 57s
hadoop-common in the patch passed.

+1 :green_heart:
unit
2m  1s
hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
4m 55s
hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
unit
4m 46s
hadoop-aws in the patch passed.

+1 :green_heart:
unit
1m 36s
hadoop-azure in the patch passed.

+1 :green_heart:
unit
1m  6s
hadoop-azure-datalake in the patch passed.

+1 :green_heart:
asflicense
0m 51s
The patch does not generate ASF License warnings.

154m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2231

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 317d8cd18428 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
branch-3.2 / 9aa78fe

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~16.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/2/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/2/testReport/

Max. process+thread count
1374 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-tools/hadoop-azure-datalake U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2231/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


chore: upgrade Go version to 1.20

Description
This PR upgrade the Go version and libraries that are in lockstep with the Go compiler:
quic-go -> 0.32
libp2p -> 0.27.8
Closes: https://github.com/zeta-chain/node/issues/1074
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

[x] Tested CCTX in localnet
[ ] Tested in development environment
[ ] Go unit tests
[ ] Go integration tests
[ ] Tested via GitHub Actions

Checklist:

[ ] I have added unit tests that prove my fix feature works

closes https://github.com/zeta-chain/node/issues/575


youtube wayback machine capture fallback

Checklist

[X] I'm reporting a feature request
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS> (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
this feature request is a option (something like --wayback-fallback) for if the youtube video that the user tries to download is unavailable it will fallback to a wayback machine capture of the video
Verbose log
No response

Use ytarchive:video_id

Yes, what they are asking is to support some pseudo URL pattern like ytf:id to try downloading id in both YouTube and archive. The other request is impossible because it was suggesting a single way to support archive pages of all websites. But this is only about YouTube, for which we already support web archive.


add paroxython

When reviewing https://github.com/python/typeshed/pull/5248, I did a Github code search for projects that contain import docopt  # type: ignore. I had never heard of paroxython before, but I chose it because it's quite big and the latest commit is not too long ago.

Thanks! Although note that mypy_primer currently doesn't work for third party package changes (broken by modular typeshed, https://github.com/hauntsaninja/mypy_primer/issues/7)


Two consistently calls causes error - Received RST_STREAM with error code 2

What version of gRPC and what language are you using?
gRPC: 1.24.2
I use Objective-C gRPC library from Swift 5.0 code
Server was written on grpc-go v1.19.0
What operating system (Linux, Windows,...) and version?
iOS 12.2
What did you do?
I have a class which conforms to GRPCProtoResponseHandler protocol and it has a method foo which creates two services and calls one method from each service:
class MyClass: NSObject, GRPCProtoResponseHandler {
    var dispatchQueue: DispatchQueue {
        return .main
    }

    func foo() {
        let callOptions = GRPCMutableCallOptions()
        callOptions.initialMetadata = ["authorization": "Bearer eyJhbGciO..."]

        featureService = FeatureTogglingService(host: "example.com:443", callOptions: callOptions)
        userService = UserService(host: "example.com:443", callOptions: callOptions)

        let userCall = userService?.sendOnlineStatus(withMessage: userRequest, responseHandler: self, callOptions: nil)
        let featureCall = featureService?.getFeaturesWithMessage(featureTogglingRequest, responseHandler: self, callOptions: nil)
        featureCall?.start()
        userCall?.start()
    }

    func didReceiveProtoMessage(_ message: GPBMessage?) {
    }

    func didClose(withTrailingMetadata trailingMetadata: [AnyHashable : Any]?, error: Error?) {
        print("🛑🛑🛑 error: \(error)")
    }
}

I call foo method.
What did you expect to see?
I expected to see two callings back the method func didClose(withTrailingMetadata trailingMetadata: [AnyHashable : Any]?, error: Error?) with error == nil
What did you see instead?
I see two callings back the method func didClose(withTrailingMetadata trailingMetadata: [AnyHashable : Any]?, error: Error?) where error contains:
🛑🛑🛑 error: Optional(Error Domain=io.grpc Code=13 "{"created":"@1572546519.322425000","description":"Error received from peer ipv4:...:443","file":".../Pods/gRPC-Core/src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Received RST_STREAM with error code 2","grpc_status":13}" UserInfo={io.grpc.HeadersKey={
    date = "Thu, 31 Oct 2019 18:28:39 GMT";
    server = nginx;
}, io.grpc.TrailersKey={
}, NSDebugDescription={"created":"@1572546519.322425000","description":"Error received from peer ipv4:...:443","file":".../Pods/gRPC-Core/src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Received RST_STREAM with error code 2","grpc_status":13}, NSLocalizedDescription=Received RST_STREAM with error code 2})
🛑🛑🛑 error: Optional(Error Domain=io.grpc Code=13 "{"created":"@1572546519.322339000","description":"Error received from peer ipv4:...:443","file":".../Pods/gRPC-Core/src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Received RST_STREAM with error code 2","grpc_status":13}" UserInfo={io.grpc.HeadersKey={
    date = "Thu, 31 Oct 2019 18:28:39 GMT";
    server = nginx;
}, io.grpc.TrailersKey={
}, NSDebugDescription={"created":"@1572546519.322339000","description":"Error received from peer ipv4:...:443","file":".../Pods/gRPC-Core/src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Received RST_STREAM with error code 2","grpc_status":13}, NSLocalizedDescription=Received RST_STREAM with error code 2})

But in server logs I see that every call went ok because response status 200. That's why I think there is a problem on client side in gRPC Objective-C library.
Anything else we should know about your project / environment?
My protos:
syntax = "proto3";
package ...;

message Response {
    ServiceStatus status = 1;
}

message ResultStatus {
    Status status = 1;
}

enum Status {
    OK = 0;
    ...
}

syntax = "proto3";
package ...;

message Feature {
    string name = 1;
    bool is_enabled = 2;
    int64 valid_until = 3;
}

message QueryFeatures {
}

message ResultFeature {
    common.ResultStatus status = 1;
    repeated Feature features = 2;
    reserved 3;
}

service FeatureTogglingService {
    rpc GetFeatures(QueryFeatures) returns (ResultFeature);
}

syntax = "proto3";
package ...;

message CommandSendOnlineStatus {

}

service UserService {
    rpc SendOnlineStatus(CommandSendOnlineStatus) returns (Response);
}

The error message does indicate that a RST_STREAM from the server was received, maybe unexpectedly in your context. I don't see an indication of bug in gRPC ObjC library. For gRPC messages, the server always respond 200 status code, even with an error. gRPC status code is sent over to the client in the HTTP/2 trailer. I think the main issue here is why the server issued an RST_STREAM.

@muxi Could you explain what means RST_STREAM? What cases does server should send RST_STREAM ordinarily? I need that information to speak with backend developers to define and point servers side bug.

It's the RST_STREAM frame in HTTP/2 that gRPC uses. Usually it means the server decides that a call (stream) is terminated on the server side due to some error. See some of the details here.

@muxi We defined the issue - it is located inside backend. When a grpc response is going from Ambassador to Nginx with error message upstream sent frame for closed stream 1 while reading response header from upstream  a grpc client receive an error which described above. Therefore I close that issue. Thank you a lot!

Thanks for the update @slavabulgakov


Fix build on Linux

Changes in #5494 added references in System.Data.Common.DbParameter API that is technically in the .NET 4.5.1 API surface, but missing from Mono reference assemblies.
See mono bug by @bricelam and @divega: https://bugzilla.xamarin.com/show_bug.cgi?id=29167
Even though we don't run tests against Mono anymore, dotnet build on Linux/OSX still uses Mono reference assemblies to compile.
Solutions:

Update Mono ref assemblies to pre-release versions that have the API surface.
Change our code.
Set DOTNET_REFERENCE_ASSEMBLIES_PATH to a folder that contains proper .NET 4.5.1 reference assemblies. (see DotNetReferenceAssembliesPathResolver)
Alter build script to not build for desktop .NET on Linux/OSX.

cc @pranavkm @Eilon what do you think about solution 4?

FWIW, solution 3 looks like a good choice to me, assuming we can make it work.

cc @davidfowl - we have a similar issue building some of the incoming changes with Logging (https://github.com/aspnet/Logging/pull/434). Do you have ideas on how we'd get the correct reference assemblies on Travis?

I'm testing a travis build with Mono beta (currently 4.4.0 RC1). https://github.com/aspnet/EntityFramework/commit/db4cd2db22b94dfe61e78ce68c496895368462db and https://travis-ci.org/aspnet/EntityFramework/builds/132707297. We've had issues with Sake + newer versions of Mono. Hopefully those are fixed now.

(3) would be nice, assuming we can do it. Option (4) is potentially reasonable as a short-term solution, but is not a valid long-term solution. So if we do (4) to unblock things, log a new bug to revert (4) and find a proper long-term solution.

BTW solution 3 is a .NET 4.5.1 multi-targetting pack for Linux and OSX 😉

Fixed with 24a9526caa83bd58d8c4ba84ec663f256f53ce07. We may need to update other CI agents.


Production API host doesn't work out of the box

User ember server --proxy http://localhost:8000 to point proxy to default Django runserver.

I meant in a deployed environment for some reason it wanted to use localhost:8000 for all Ember Data requests.
this is closed by b8383b22b4d4d06b05dd4affcf8d11b369455170


Fix extractCommitteeMember loop

Resolves #1511

Codecov Report
Patch coverage: 22.17% and project coverage change: -0.34 :warning:

Comparison is base (57c6bbd) 40.18% compared to head (7c7fcdf) 39.84%.

:exclamation: Current head 7c7fcdf differs from pull request most recent head fd3910c. Consider uploading reports for the commit fd3910c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   40.18%   39.84%   -0.34%
==========================================
  Files         147      147
  Lines        9651     9785     +134
==========================================
+ Hits         3878     3899      +21
- Misses       5144     5253     +109
- Partials      629      633       +4

Impacted Files
Coverage Δ

pkg/config/genesis/config.go
0.00% <ø> (ø)

pkg/core/consensus/agreement/checkcert.go
6.97% <0.00%> (ø)

...nsensus/blockgenerator/candidate/blockgenerator.go
0.00% <0.00%> (ø)

...core/consensus/blockgenerator/candidate/genesis.go
0.00% <0.00%> (ø)

...kg/core/consensus/blockgenerator/candidate/mock.go
0.00% <0.00%> (ø)

pkg/core/data/block/block.go
8.97% <0.00%> (-1.48%)
:arrow_down:

pkg/core/data/block/certificate.go
0.00% <ø> (ø)

pkg/core/data/block/header.go
0.00% <0.00%> (ø)

pkg/core/data/ipc/transactions/fixtures.go
13.76% <0.00%> (-0.21%)
:arrow_down:

pkg/core/data/ipc/transactions/provider.go
0.00% <0.00%> (ø)

... and 16 more

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create protos for LVS using EdaTool

Codecov Report

Merging #59 (22ccba7) into master (3d6381d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   53.95%   53.95%
=======================================
  Files          43       43
  Lines        3412     3412
=======================================
  Hits         1841     1841
  Misses       1571     1571

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Default instance for functors

@paf31 is this OK? I didn't even try it at first, expecting overlap problems, but @joneshf suggested it, I tried it, and it seems to be fine.
My test case for seeing whether instances would resolve was using Endo in Data.Monoid:
module Test where

import Data.String
import Data.Functor.Invariant
import Data.Monoid.Endo

test = runEndo (invmap show length (Endo \x -> x :: Number)) "fooooooooooo"
-- "12"

And likewise invmap works for things with Functor instances and no Invariant.

I think this is fine on the level of laws, but it feels dodgy on the level of uniqueness of instances. It seems like it would cause problems later if we tried to add Invariant instances for other things, but I'm not sure. I'll think on this some more.

I think Const will have overlapping instances, like with the Compose/Contravariant/Functor thing. May be best to just not have this instance, and go back to the function.

I don't think Const would need an explicit instance would it (as the behaviour would be the same as the Functor-dervied version anyway)?

A little factoid which seems relevant:
For every Profunctor p there is an Invariant functor Endo p given by
newtype Endo p a = Endo (p a a)

This gives a functor from the category of profunctors to the category of functors. But we can go the other way too.  But if f is Invariant, we can map back too:
lowerProneda :: forall f a. (Invariant f) => Proneda f a a -> f a
lowerProneda (Proneda fx f g) = imap f g fx

I claim that Proneda is right adjoint to Endo, i.e. it is a free Profunctor for a functor, and in the case of an Invariant f, liftProneda and lowerProneda are inverses. I haven't proved this yet...
So my conjecture is that whenever you have a thing and you think Invariant is useful, it's just as useful to work with Proneda f instead.

Invariant should really be a superclass of both Contravariant and Functor (that's the way Scalaz handles it). Although since we don't have defaults, that would make instances tedious so maybe we push back on that.

Isn't that a bit overkill?

Very seldom, which is why I wouldn't recommend such a change unless it were painless (i.e. default functions on instances). Nonetheless, I do have a strong preference for creating the right type class hierarchy, as we've seen how wrong ones have stalled, stymied and splintered the Haskell community over the decades. :smile:

:-1: I think I would rather just provide this as a function.


Update options css for text-wrap

Hello,
Currently, for css text-wrap, the library provides the options none | normal | avoid | [initial | inherit | unset | revert].
Text-wrap also has balance, pretty, stable etc. options. Doc
Is it planned to support these options? If not, how can we get around it?

Can you provide example?
because
const MyDiv = styled.div`
 text-wrap: balance;
`

works

Yes, when I want use this property, I have an error.

also tried
const  GlobalS = createGlobalStyle`
    body {
        text-wrap: wrap;
    }
`

does you code work on browser? Maybe is an vscode bug?

I must have had a problem when I tried to use the property, but it seems to be working in my browser at the moment. This was not the case at the time of my question. The site being a legacy, I had tested on a new environment, without success either.
I imagine that for the IDE (phpstorm), we'll be able to live with it^^
Sorry for the inconvenience and thank you for your time :)

I'm guessing this is more of a typing issue than a functionality issue. Cause I am having a similar problem (see screenshot below), but in the browser it works just fine. Would still be nice to have this supported in the typing though.


KAFKA-13138: FileConfigProvider#get should keep failure exception

@cmccabe @hachikuji this uses the two-argument constructor of ConfigException as a (message, cause) pair but in reality, that constructor is supposed to accept a (name, value) pair. The usage in this PR can lead to confusing stack traces (see https://github.com/apache/kafka/pull/11349 for one example of how this type of usage looks when logged to users).
I can appreciate the desire to preserve the cause of the exception for debugging purposes; would it be alright if we reverted this change to the ConfigException that's constructed in this case and, instead, log at ERROR level the causing exception before throwing our ConfigException? Thinking something like:
        } catch (IOException e) {
            log.error("Could not read properties from file {}", path, e);
            throw new ConfigException("Could not read properties from file " + path);
        }

Filed https://github.com/apache/kafka/pull/11555 to address.


added IdGeneratorInterface and generateId for custom entity-managers

Hello doctrine maintainers,
while trying to write a replacement for doctrine's own entity-manager (to experiment with different behavior regarding transactions) i have noticed that currently there are hard-coded dependencies to doctrine's own entity-manager in the id-generator classes. In order to make the id-generation process work with third-party entity-managers while still maintaining full backwards-compatibility, i have added an interface called IdGeneratorInterface which specifies a "generateId" method that depends only on the EntityManagerInterface instead of EntityManager, allowing third-party entity-managers to be used with it.
The AbstractIdGenerator class still exists as an adapter translating the new method to the old (if possible). This allows full backward compatibility because other (old) third party id-generators (like these defined in the unit-tests) extend the AbstractIdGenerator which in turn translates all calls from "generateId" to "generate" if doctrine's own entity-manager is used. The only situation where this fails is when an old id-generator (extending AbstractIdGenerator) is used with a third-party entity-manager, which is a situation that is currently also not supported anyway. Old third-party id-generators can (in almost all cases) simply be upgraded to use the IdGeneratorInterface and the "generateId" method to be able to be used with third-party entity-managers.
I have made sure that all tests pass on my computer with the inmemory sqlite driver.

@addiks I have mixed feelings regarding your changes... I understand that you tried to not insert a BC break but at the same time it's weird to have a method generateId on an IdGenerator (I just don't expect to have an IdGenerator that generates other things than an ID).
And I'm not sure if it's worth to have this "temporary complexity"...

Example:
`
class GenerateMyThings implements IdGenerator, NameGenerator
{
public function generateId()
{
// Generates an id
}
public function generateName()
{
    // Generates a name
}

}
`
The method-name "generate" makes much more sense if the class extends the AbstractIdGenerator because the class is practically guaranteed to be just an id-generator. The name "generateId" makes more sense in the context of an IdGeneratorInterface because here all we know is that the class can also generate id's besides maybe other things. If the method was just named "generate" it would be unclear what would be generated here and it could possibly cause name-conflicts. I don't want to forbid a class to implement multiple (generator-) interfaces. Something like that might be considered bad design by some, but that is a decision the user has to make and i don't want to impose my idea of good design on anybody by causing name-conflicts that otherwise could easily be avoided. Also the method-name "generate" would conflict with the generate-method defined in AbstractIdGenerator, which would kill of the backwards compatibility.
As for if it's worth the extra complexity, to me it does not look like that much more complexity because everything still works just the same as before, It's just a different name to be called (while the old one still works). The only additional "weight" is the AbstractIdGenerator for backwards compatibility. I think having this is worth it because it allows users to use their own implementation of an entity-manager.
In my case i created an alternative entity-manager to experiment with a different behavior regarding transactions for better use with batch-processing and recovering from a faulty state but which should probably not be the default because for beginners it is the much more safe option to just stop if any error happens.
If you (or anybody else here) is at SymfonyCon in Berlin next week, we could talk in person. I'm looking forward to interesting discussions.

I like how you mitigated the changes, but I don't know yet if I like working around everything like that. Possibly a good idea to allow dropping the abstract class for 3.x though.
Just one thing: please don't merge master into your branch: rebase instead.

One thing missing: a test that passes an EntityManagerInterface to the id generator (regression checking, mostly)

Thanks for pointing me to git rebase, i didn't knew about that. I have now rebased my commit on doctrine master, so the previous commits vanished and were replaced with a new one. I hope that does not confuse anybody.
I will look into writing a test for using the id-generators with another entity-manager, but first i need to make myself familiar with the current set of tests in doctrine to find out where and how to best put that test.

first i need to make myself familiar with the current set of tests in doctrine

Try looking for existing tests around the identifier generators. Unsure if they are segregated (one per SUT)

I've now modified the assigned-id-generator-test to also execute with a test-double of the entity-manager-interface. I don't know if this is to your standards so just tell me if anything is wrong here. I also tried to modify the sequence-generator-test, but that one seems very tightly coupled to the actual db-connection, which i think would be hard to write test-doubles for.

Hi @addiks, just wanted to let you know that we've made some changes to id generators in develop:

they were moved to Sequencing namespace;
we're now typehinting EntityManagerInterface, not EntityManager;
generators have been generalized as more generic value generators so they could be used for generating values even for non-ids (this is not yet implemented);
we now have a value generation plan to encapsulate value generation on multiple places.

With these changes, I think this PR is obsoleted for 3.x and adding such code in 2.x wouldn't be worth it. Let me know what you think and whether this PR could be closed.

Closing as per @Majkl578's comment. Indeed, the scope changed here, so the patch would need to be thought through (new discussion/pr if relevant), while this thread should end here.


Launcher integration

Configs adjusted to format expected by launcher
Automated builds with launcher (I skipped macOS, as I don't have a way to test those builds)
Fix for https://github.com/opensoldat/opensoldat/issues/116

You can download the builds here - https://github.com/opensoldat/opensoldat/actions/runs/2740249081
Before merging this PR, you have to:

Merge https://github.com/opensoldat/base/pull/23, and upload a new release of soldat.smod with tag v0.3
Update BASE_REPOSITORY_URL, BASE_GIT_TAG and SOLDAT_SMOD_SHA1 in OpenSoldatAssets.cmake

Looks and works great for me! Bugfixes look fine too. But I think we should somehow turn off the lobby until more work is done on https://github.com/opensoldat/lobby. The servers are incompatible and it will confuse people.

Done. Launcher no longer shows incompatible servers.


[libra framework] remove unused Debug and Compare modules from Libra …

…Framework
Both of these modules are useful, but not called by any current transaction scripts. This PR moves them to a nursery/ directory under stdlib/ that is not compiled or published alongside the other Libra Framework modules.
This moves the tests for Compare and Debug to Move CLI expected value tests to avoid the headache of maintaining multiple genesis blobs in the stdlib. In addition, this tests the exact output of Debug, whereas before the tests only made sure it didn't crash.
This will delete the copies of the Compare and Debug modules currently on-chain, but this is not a client or validator software-breaking change because this code is dead. The deletion can be performed via a writeset.

/land

/land

@sblackshear :bulb: This PR is already queued for landing

:broken_heart: Test Failed - commit-workflow

/land


Fix patch image command in rolling update section

Fixes one part of the issue #7056 about patch command failing to update.
It changes the image URL to another different than the used previously to create the StatefulSet to make the patch command works without fail.

This change is

@tengqm hi, it's been 10 days since I submitted the PR. Should I assign it to other owner in addition to @smarterclayton? Thanks

@rgo I don't have right to merge this, so you have to wait.
/cc @heckj @zacharysarah

apologies for the delay @rgo - and thank you for the fix!
/approve

@heckj no problem and you're welcome :)


v1/api: Add more logging for blueprint creation

Feel free to merge and do a followup, or rebase. I can do the followup if needed.

I've added the info to all our db statements and reorginized error checks first there as well :)
IMO it's ready to get merged tomorrow :)

Thanks, merged for you.


[v9.1.0]  Legacy forms results are not showing up in the reports dashboard.

When using a Legacy form the results are not showing in the reports dashboard after the form has been submitted. I can see the form data in the database and in the notification email it says "To view all of this form's submissions, visit https://mywebsite.com/index.php/dashboard/reports/forms?qsid=1641399736" this still only shows a blank page.

Yes I can confirm that. Everything is saved properly as stated.
The issue is with the single page not showing the "Legacy" button to access the reports. If you add /legacy to the URL of the reports page, everything is there

Fixed by #10216


Switch TDI pin to use 2.54mm jumper

The JP1 connector is a little too small to work with, switch the header pins to a 2.54mm connection instead.

Also after further review, the pin should not be disabled to ground when not used, it should simply not be connected.


fix(sheets-drawing-ui): sheet-drawing memory leak

close https://github.com/dream-num/univer-pro/issues/3296

Pull Request Checklist

[ ] Related tickets or issues have been linked in the PR description (or missing issue).
[ ] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[ ] Unit tests have been added for the changes (if applicable).
[ ] Breaking changes have been documented (or no breaking changes introduced in this PR).

Marking this as verified because it does not contain logical changes.


VideoJS dependency of VideoPlayer redefines global/document and globalwindow

The VideoPlayer component have a dependency video.js has a long standing issue where global/document and global/window get redefined for their internal testing, which causes users of the package who also have code that rely on these standard global variables to use complicated work-arounds to have their code bases work.
https://github.com/videojs/video.js/issues/5680 for context
This issue was fixed in https://github.com/videojs/video.js/pull/6954, but when the VideoPlayer is exported from react-components, a basic usage within storybook results in the following error:
 ERR! ModuleNotFoundError: Module not found: Error: Can't resolve 'global/window'

If i remove VideoPlayer from being exported, this issue goes away which is why I am confident video.js is the root cause.
Expected behavior
I should be able to import in VideoPlayer and not have to write shims to get the library imported in projects that utilize global/document and global/window

Looking into this.

This should be resolved.


White Theme homepage QA fixes before release

Objective
Make sure all the detail are done and ready for the release.
The PR for fixing can be viewed  here.
Task items

[x] Update homepage hero message per Linda's request and detail can be viewed here

[x] Set max-width to the Hero Message so it always stays with a minimum of three lines of text.

[x] Pictograms are not showing properly when viewed in Safari.

[x] The "Sketch Theme Libraries" card (image one) just goes to the resource page. The link should land on the Theme section (image two) of the page.

(image one)

(image two)

@JennySanchez When I hover over the link to 'Start contributing' is the internal bluemix url...it be the live url "https://www.ibm.com/standards/web/ibm-dotcom-library/contributions".

I notice when you use the external link icon, it opens the page in the same window...shouldn't it open in a second window?

@ljcarot You are correct, I am not sure why it takes you to the Bluemix URL.
@annawen1 Does it have anything to do with it's in the staging environment? Can we make sure "Start contributing" is linked to https://www.ibm.com/standards/web/ibm-dotcom-library/contributions ?
Thank you.

@ljcarot About use the external link icon, I agree on open in a second window is a better experience. However, I noticed the Carbon website has the same treatment and now I wonder if it's a Gatsby Theme card or external link treatment.
For example, all the cards in the Resource page open within the same window.
View cards on Carbon website Resource page here.

Ok @JennySanchez we can leave that alone for now.

@ljcarot Did some investigation and noticed our current homepage the 'Start contributing' is linked to the internal bluemix url as well. My guess is the link did not get updated when we update the URL for some reason - FYI.

@ljcarot @JennySanchez I'll update the "Start contributing" link and make it relative like you suggested. I also tried setting the resource cards to open to a new tab and that works. I push those updates up

@annawen1
Question: In the PR, I noticed there are conflicts. Just wanna bring it to your attention and make sure it won't be a problem when we push the homepage live as soon as Linda gives the green light.

@annawen1 The updates look good. Thank you!
Question: In the PR, I noticed there are conflicts. Just wanna bring it to your attention and make sure it won't be a problem when we push the homepage live as soon as Linda gives the green light.

@JennySanchez Yep I noticed, conflicts have been resolved.

@annawen1 Awesome. Thanks!
@ljcarot FYI - 'Start contributing' link on the current website is updated.
https://github.com/carbon-design-system/ibm-dotcom-library-website/pull/481

@ljcarot @jeffchew @wonilsuhibm All fixes completed and just need to know when you think we should push the update live. Thank you.

Let’s not wait any longer. I’m good to push live

Update: Based on the Slack conversation with Anna and Jeff, we got the green light from Jeff. We will push the update live today.

White Theme Homepage is updated and lived.


Replace simple activationScripts

This is one part of a series of PRs towards activation without Perl. See more about this larger project here: https://pad.lassul.us/nixos-perlless-activation#
This PR is part of step 1 of the larger project.
In this PR, I replace many of the simple activationScripts. I employed this strategy to remove activationScripts:

removing them without replacement because they are not needed anymore
replacing them via ExecPreStart=
replacing them via a separate service ordered correctly before the other services that need it
replacing them via a separate service that runs very early, e.g. withwantedBy = [ "sysinit.target" ];
before = [ "sysinit.target" ];
unitConfig.DefaultDependencies = false;

One of the immediate benefits of this work is that these activationScripts now actually run after the initrd when you use the systemd initrd. The systemd initrd calls stage-2-init.sh in the initrd as ./prepare-root
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I've only reviewed the shell script parts of this PR.

I will not change the shell scripts themselves. I just move them into a systemd service or preStart.
Improving the shell scripts is out of scope.

Resoled @ElvishJerricco comments by removing the changes in question from this PR. I will open another PR where we can have a focused discussion on only the controversial bits.

@ofborg test wrappers mysql.mysql80 iscsi-root strongswan-swanctl mattermost systemd-binfmt systemd-timesyncd opensearch.opensearch stunnel grafana.provision activcation-nix-channel activation-var
The stargazer test seems to be broken on master

@ElvishJerricco is this good to go now?

https://github.com/NixOS/nixpkgs/commit/a8f50f991948b91d1a191d1348bfff860a39b5a2 broke the installer tests.

Reverting in https://github.com/NixOS/nixpkgs/pull/264200

Reverting in https://github.com/NixOS/nixpkgs/pull/264200

Thank you for taking the time to only revert the offending commit!


Best practice for style library

What is the best practice to use a library like boostrap or material, or maybe a custom one in project. To import the same sass in all components

Yeah, this is a feature that I will implement and add to docs in the future. Thanks for your suggestion. I need to have more time to test other UI libraries.


remove installer- from file names

#15

4.6 nightly's are currently broken on fyre, bugzilla report opened.  https://bugzilla.redhat.com/show_bug.cgi?id=1879511


[FLINK-4837] flink-streaming-akka source connector

This PR is created to propose the idea of having a flink-streaming-akka source connector.
The source connector can be used to receive messages from an Akka feeder or publisher actor & these messages can then be processed using flink streaming.
The source connector has the following features.

It can supports several different message formats like iterable data, bytes array & data with timestamp.
It can send back acknowledgements to the feeder actor.

We recently started collaborating with Apache Bahir (http://bahir.apache.org) to host additions. That makes it easier to add new connectors and to do faster releases of connectors.
The Bahir website does not yet reflect that, because it started recently and the first release of Flink connectors is still pending.
What do you think about adding this to Bahir as well? @rmetzger can probably help out here.

Thank you for opening a pull request for adding a new streaming connector.
I also think that this connector is a good candidate to go into Apache Bahir. You find the GitHub repository of Bahir here: https://github.com/apache/bahir-flink
Let me know if you need help while opening a pull request at Bahir.
I'm happy to review your pull request at Bahir!

Hello @rmetzger ,
I'll open a new PR in bahir. Closing this.

Thank you!


ACR support for app-controller, GROW-128

ISSUE(S):

https://platform9.atlassian.net/browse/GROW-128
SUMMARY

Add constants for detecting ACR url, change extractRegistryURL function to accept and correctly construct a URL for acr.
ISSUE TYPE

🎁 New feature (non-breaking change which adds functionality)

IMPACTED FEATURES/COMPONENTS:

appctl deploy (now supports acr private registries)

DEPENDS ON:

TESTING DONE
Automated

Manual

appctl list
appctl deploy
Testing Output (Snapshot/file)

All azure registries are private by default. I'll update the docs
On Thu, Mar 3, 2022, 12:24 Anup Barve @.***> wrote:

@.**** approved this pull request.
We would need to update this wiki
https://platform9.atlassian.net/wiki/spaces/GI/pages/2985230519/Private+registry+support
and this documentation
https://platform9.com/docs/appctl/deploy
Which should explain how to setup azure private registry and what is the
username and password.
—
Reply to this email directly, view it on GitHub
https://github.com/platform9/app-controller/pull/27#pullrequestreview-898510247,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJNJ3US2KZCK5CI7SIWZ3HDU6BOZTANCNFSM5PZRYELQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@anupbarve will merge after updating docs


Avoid showing vertical scroll bar on stage error listview

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change

PR Type
What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?
On some cases it could happen that the list which shows startup stage errors is also showing a scroll bar, which also makes not all stages be seen at the same time
What is the new behavior?
Listview is measured and resized to a height which would allow all stages statuses to be seen at the same time
Other information
Testing on the emulators didn't show the current behavior. However, testing on my physical device did show it. I suggest testing this PR on a physical device.
ListView layout_height on app_bar_main.xml was changed to "0dp" as Android Studio was recommending that change.

Hey, thanks for this. Wouldn't it just be easier to set android:scrollbars="none" on the ListView in the layout xml? Is there a particular reason for taking this approach?
Edit: I actually, I see the reason now. I wasn't getting the behaviour with some being cut off when I tested, so maybe it also depends on device screen resolution.

Exactly. Testing on the emulator with any Pixel AVD didn't show the problem at all. It was on my physical Redmi device that list only showed a few items. Setting scrollbars='none' only hide the scrollbars, letting the list still not at its full height. That attribute is now not needed, but I don't see it as doing anything wrong neither.


⚠ Bofrost.at has degraded performance

In 8ca8bea, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1755 ms

Resolved: Bofrost.at performance has improved in d5fefc5 after 6 minutes.


fix file url with double slash error message

Addressing #37

Added check if the file schema URL has double leading slash
Added an appropriate error message on such file URLs

Please let me know if it is a valid fix, or if I need to make changes further.
Thank you.

Looks good, thanks @Mr-Destructive!


Node samples should add or modify examples to match the tutorials

http://www.nats.io/documentation/tutorials/nats-req-rep/
http://www.nats.io/documentation/tutorials/nats-queueing/
And generally the go client - note documentation is wrong since it suggests that nats-sub takes a queueing argument when separate samples illustrate that functionality.

We have very nice docs on https://www.nats.io/documentation/writing_applications/connecting which show side by side client languages.


[C-API/common] Add fp16 type.

Declare API formats for API change review process.
Note:
Fp16 is generally supported by arm/arm64 compilers.
However, x64/x86 compilers usually don't support it
(GCC>=12 is required along with some compiler flags).
Signed-off-by: MyungJoo Ham<EMAIL_ADDRESS>

Removing BF16. Add it after BF16 is supported by nnstreamer

I'll fix the error soon. Don't merge this.

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/181-202207181417180.83104395866394-24ede5ceaa1790e1affccdeaa6390f428f136a30/.


NOTES.txt: Fix links

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:
Fixes links in output after falco install without sidekick
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Checklist

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] CHANGELOG.md updated

Welcome @schnatterer! It looks like this is your first PR to falcosecurity/charts 🎉

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: schnatterer
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @schnatterer, could you please run make docs-falco and then push again?

Thanks, done.
The option in the PR template /kind chart-release lead me to believe you might not release every change.
I had a look at the CONTRIBUTING.md  but missed the make docs mentioned in README.md.
You could adapt those in the PR template to make it easier for new contributors :slightly_smiling_face:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku, schnatterer
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 29d32b87396ad3b4a9f31635f90b64379e257bc5

@Issif, con you have a look?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, Issif, schnatterer
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Q] Config library that supports "dotted" flags without creating duplicate config parameters?

Hi! I'm wondering if the nested-dict parameters from wandb sweep were developed with a particular config library in mind?
I thought fancyflags would be a nice solution, as I can do:
fancyflags.DEFINE_dict(
    'model',
    arch=ff.String('resnet_v1_18'),
    bn=ff.Boolean(True))
fancyflags.DEFINE_dict(
    'train',
    batch_size=ff.Integer(128),
    learning_rate=ff.Float(0.1),
    num_epochs=ff.Integer(50))

def main(_):
  wandb.init(..., config={'model': FLAGS.model, 'train': FLAGS.train})

and it creates flags like --model.arch, which I would like to have for manually calling my program at the command line.
Using fancyflags, I can define a sweep in YAML like:
method: grid
parameters:
  model.bn:
    values: [true, false]
  train.learning_rate:
    values: [0.1, 0.01, 0.001]

However, I find that I get duplicate columns in the web interface, since wandb.config contains:
{'train.learning_rate': 0.1,
 'train': {'learning_rate': 0.1, ...},
 ...}

One solution would be to manually flatten the dict from fancyflags myself, although that's not ideal.
I saw that wandb sweep supports nested parameters, and it tries to pass the nested parameters as a JSON string Python dict converted to a string, however this is not supported by fancyflags. Is there a config library that both:

gives user-friendly "dotted" flags like --train.learning_rate for running my code manually, and
supports the dict string produced by nested parameters in sweeps?

Thanks!

Oh, one correction: wandb sweep attempts to pass the nested parameters using str() of a Python dict, not JSON. That makes things more difficult.

I found the ${args_json} option in the docs and this let me write a simple workaround (below). However, I would still be interested to know whether there was an intended config library. Thank you!
from absl import flags
import fancyflags as ff

flags.DEFINE_string('json', '', 'Flag overrides encoded as JSON.')
ff.DEFINE_dict(...)

def main(_):
    if FLAGS.json:
        # Override flags using values in JSON.
        flag_dict = json.loads(FLAGS.json)
        if not isinstance(flag_dict, dict):
            raise ValueError('JSON value was not a dict', flag_dict)
        unknown_flags, unparsed_args = FLAGS._parse_args(list(args_from_dict(flag_dict)), False)
        for name, value in unknown_flags:
            raise flags.UnrecognizedFlagError(name, value)
  ...

def args_from_dict(flags_dict, prefix=''):
    assert isinstance(flags_dict, dict)
    for flag, value in flags_dict.items():
        if isinstance(value, dict):
            yield from args_from_dict(value, f'{prefix}{flag}.')
        else:
            yield f'--{prefix}{flag}'
            yield str(value)

and I add this to my YAML sweep definition:
command:
  - ${env}
  - ${interpreter}
  - ${program}
  - "--json"
  - ${args_json}

I'm not sure whether it's safe to call FLAGS._parse_args a second time, but it seems ok as a temporary workaround.

Hmm.. on closer inspection, I found that the above code doesn't work, because wandb.init(..., config=config_from_flags) will not recursively update wandb.config. That is, if wandb.config['train']['learning_rate'] is set by the sweep and wandb.config['train']['batch_size'] was not specified in the sweep, the default value for batch_size will not be set.
I also realised that it's not necessary to pass the config as JSON, since the agent receives the config from the sweep anyway.
In the end, I'm just going to flatten the config dict before passing it to wandb.config.update(). The below code does this, and also unflattens the parameters in wandb.config to update the flags, just to make sure that they're consisten.
from absl import flags
import fancyflags as ff
from ml_collections import ConfigDict  # Provides .lock() and .update_from_flattened_dict()

flags.DEFINE_string('json', '', 'Flag overrides encoded as JSON.')
flags.DEFINE_integer('seed', ...)
ff.DEFINE_dict('train', ...)

CONFIG_FLAGS = ['seed', 'train']

def merge_configs():
    """Must be called after wandb.init(). Modifies FLAGS and wandb.config."""
    assert_flat(wandb.config)
    flags_config = ConfigDict({k: getattr(FLAGS, k) for k in CONFIG_FLAGS})
    flags_config.lock()  # Disallow adding or removing options.
    # Update wandb.config using flags.
    # For a sweep, this sets unspecified params and does not override specified params.
    # Use flat dict because wandb does not update recursively.
    wandb.config.update(dict(flatten_items(flags_config.items(), sep='.')))
    assert_flat(wandb.config)
    # Update config using wandb's config (gets params set by sweep).
    # (Not necessary if all params were passed as flags.)
    # Raises if new params were specified.
    flags_config.update_from_flattened_dict(wandb.config.as_dict())
    print('final flags_config:')
    pprint(flags_config.to_dict())
    # Modify FLAGS in-place to avoid confusion.
    for k, v in flags_config.items():
        setattr(FLAGS, k, v)

def flatten_items(items, sep: str = '.', prefix: str = '') -> Dict[str, Any]:
    for k, v in items:
        if hasattr(v, 'items'):
            yield from flatten_items(v.items(), sep=sep, prefix=f'{prefix}{k}{sep}')
        else:
            yield f'{prefix}{k}', v

def assert_flat(mapping: Mapping):
    child_mappings = [k for k, v in mapping.items() if isinstance(v, Mapping)]
    if child_mappings:
        raise ValueError('wandb.config contains nested parameters', child_mappings)

def main(_):
    wandb.init(...)
    merge_configs()
    ...

I'm still interested to know if there is a nicer solution.

Thank you! I'll check it out


Cross-network endpoints not being served to sidecar

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
When trying the following WE/SE/Gateway configuration for cross-network requests:
apiVersion: networking.istio.io/v1beta1
kind: WorkloadEntry
metadata:
  annotations:
    cluster.solo.io/cluster: cluster-1
  creationTimestamp: "2023-08-07T17:08:41Z"
  generation: 1
  labels:
    app: helloworld
    security.istio.io/tlsMode: istio
  name: vd-helloworld-vd-anything-app-helloworld--remote
  namespace: helloworld
  resourceVersion: "858106"
  uid: 3e7b78be-083b-4d7c-b45a-11d31f965301
spec:
  labels:
    app: helloworld
    security.istio.io/tlsMode: istio
  locality: us-west/us-west-1b
  network: cluster-2
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  annotations:
    cluster.solo.io/cluster: cluster-1
  creationTimestamp: "2023-08-07T17:08:41Z"
  generation: 1
  name: vd-helloworld-vd-anything
  namespace: helloworld
  resourceVersion: "858105"
  uid: 83463ade-a5f1-445c-92e6-56529c9647f4
spec:
  addresses:
  - <IP_ADDRESS>
  exportTo:
  - bookinfo
  - default
  - gloo-mesh
  - gloo-mesh-addons
  - helloworld
  - httpbin
  - istio-gateway-egress
  - istio-gateway-ew
  - istio-gateway-internal
  - istio-gateway-ns
  - istio-system
  - local-path-storage
  - not-in-mesh
  hosts:
  - helloworld.vd
  location: MESH_INTERNAL
  ports:
  - name: http-80
    number: 80
    protocol: HTTP
    targetPort: 5000
  resolution: DNS
  subjectAltNames:
  - spiffe://cluster.local/ns/helloworld/sa/default
  workloadSelector:
    labels:
      app: helloworld
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  annotations:
    cluster.solo.io/cluster: cluster-1
  creationTimestamp: "2023-08-07T16:31:25Z"
  generation: 1
  labels:
    topology.istio.io/network: cluster-2
  name: istio-remote-ew-gateway-cluster-2
  namespace: istio-system
  resourceVersion: "850664"
  uid: 611c5da7-2747-4cfc-a3fd-ac3bf66795d2
spec:
  addresses:
  - type: IPAddress
    value: <IP_ADDRESS>
  gatewayClassName: istio-remote
  listeners:
  - allowedRoutes:
      namespaces:
        from: Same
    name: cross-network-cluster-2
    port: 15443
    protocol: TLS
    tls:
      mode: Passthrough
      options:
        gateway.istio.io/listener-protocol: auto-passthrough
status:
  conditions:
  - lastTransitionTime: "1970-01-01T00:00:00Z"
    message: Waiting for controller
    reason: NotReconciled
    status: Unknown
    type: Accepted

Of note is the status on the istio-remote Gateway resource.
The config dump of the helloworld sidecar only includes local endpoints with STRICT_DNS type cluster, but no remote network endpoints.
In addition, there were no relevant error logs in istiod, and this is the only warning log I see:
2023-08-07T18:09:03.691450Z	warn	constructed http route config for route https.16443.https.eastwestgateway-istiomutual-ist-326a5f0fd557d2aa89a6bae59a63a56.istio-gateway-ew on port 16443 with no vhosts; Setting up a default 404 vhost

Version
❯ istioctl version
client version: 1.19.0-alpha.1
control plane version: 1.19-alpha.94759dcb12a99708beda01cc22e34a0c76432bb0
data plane version: 1.19-alpha.94759dcb12a99708beda01cc22e34a0c76432bb0 (16 proxies)

❯ kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.26.5
Kustomize Version: v4.5.7
Server Version: v1.26.4

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[X] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Looks like @kdorosh created a ticket to add tests for this work

this config will not work because SE resolution has to be static instead of DNS for now (pending some more upstream work) in the new model. an updated version of this doc should show some working configuration https://soloio.slab.com/posts/gateway-api-based-multi-network-demo-7d25lw76


High memory usage causes OutOfMemoryError

Because the app crashes occasionally on my phone, I did some researches with Android Studio:
When using the app (and swiping through the comics) the memory usage increases and increases . . .
When it reaches ca. 55 MB an OutOfMemoryError is thrown.
Also it seems like all favourites are loaded into Memory, which isn't a perfect behaviour when there are a number of favourites . . .
Maybee it's possible to unload more comics that are not needed any more and don't load all favourites into RAM?

Did anybody else experienced such crashes?
Can't realy explain that, because my system is telling me there is at least 200 MB free RAM.
Might be some Android related stuff?

On my secondary device with offline mode disabled the memory usage will always be around 30MB, so it seems to be an issue with offline mode...

Yep, it is definitely caused by offline mode. The OfflineComic objects hold a direct reference to the comic image. The method getBitmap() returns this image. Instead the offline comic should just return a reference to the bitmap but not hold a reference itself, so that the bitmap can be garbage collected.


Habitat

@teknofire   Please review

👍
I also see there are some lesson to learn about how to handle configs in tools like that


[Package Issue]: Nushell.Nushell MSI use machine-scope installation by default instead of user-scope installation

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
When installing Nushell.Nushell MSI use machine-scope installation by default instead of user-scope installation.
As a consequence winget installation winget install --id Nushell.Nushell fails in a non-eleveted terminal which is not desired (see https://github.com/nushell/nushell/issues/13281 for details)
The culprit is the ALLUSERS=1 installer switch that was introduced as a manual change in the manifest for version 0.94.2 and is now carried over to subsequent releases.
Steps to reproduce

Start a non elevated terminal
run winget install --id Nushell.Nushell --version 0.97.1

Actual behavior
The installation fails with error Installer failed with exit code: 1603 and in the installation logs the following message is written You do not have sufficient privileges to complete this installation for all users of the machine
Expected behavior
The installation succeeds and Nushell gets installed with user scope
Environment
Windows Package Manager v1.8.1911
Windows: Windows.Desktop v10.0.22631.4037
Microsoft.DesktopAppInstaller v1.23.1911.0

Screenshots and Logs
No response

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Environment variable for secrets

https://circleci.com/docs/2.0/reusing-config/#environment-variable-name
We recommend setting any private information to the value of an environment variable
am also including a suggestion to rename the executor “default”. This is a standard orb convention and also reduces redundancy “company/company-executor” 👉 “company/default”.

Cool! Thanks for the PR!


http-server: add /healthcheck

part of #353
We need a healthcheck endpoint on the backend http-server.

Done in #470


geany-with-vte: fix desktop shortcut and man pages

Motivation for this change
geany-with-vte lacked geany.desktop, share/icons/, the man pages, etc...
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Any reason this is held back? Unless I'm missing something, it's really a trivial change. geany-with-vte always depends on a local geany install so linking to the store directory is completely safe.
Right ?

Thanks!


gpgme: add patch for Python 3.10 support

Motivation for this change
Fix build (https://hydra.nixos.org/build/164507537)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This will trigger a little over 1k builds.

@ofborg build gpgme

@ofborg eval
@ofborg build gpgme python39Packages.gpgme python310Packages.gpgme

I manually build this PR before and something else in the dependency chain of rust is broken....

It worked before but now it fails with because python3.10 -c "import distutils" outputs <string>:1: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives.


Get api with enum parameter don't show up in swagger.json

Version of swashbuckle: Swashbuckle.AspNetCore" Version="5.5.0
Using .Net Core 3.1
Defined the api as:
public async Task<ActionResult<EntityResponse>> GetAsync(
            [FromQuery][Required] Provider provider)

where Provider is an enum.
    [JsonConverter(typeof(StringEnumConverter))]
    public enum Provider
    {
        ProviderDummy,
        ProviderData,
    }

The created swagger json look like:

I updated provider from string to enum then type declaration for string completely goes away.
Any suggestions how may I get it working?

Please create a "minimal project" (ideally starting from an empty project) that repro's your issue and post it to github. That way, I can pull it down and have a ready made repro to work troubleshoot from. Thanks

Richard,
I will try to get up a sample repository for you later on today.  I've noticed that enum parameters ignore the XML docs entirely too. I can change it to a string and everything shows up given the exact same comment. My guess is these two things are related.

@domaindrivendev here is the link of a dummy swagger project with enum used in query parameter. https://github.com/priyankajayaswal1/SwaggerDummy
The generated swagger doesn't have any type. This is what I was telling. Let me know if you need any other information here.

Reminder

@domaindrivendev just to bring this to your notice once again You may remove the "Waiting for author" label.

Dup of #1329. Long story short, I think you can resolve this by using the UseInlineDefinitionsForEnums config setting.

Dup of #1329. Long story short, I think you can resolve this by using the UseInlineDefinitionsForEnums config setting.


Add parameter validation for CCM module

This PR adds parameter validation to the CCM module.
It is based on #1643, the first relevant commit is 9ca2615724641090d191072fac8a478a3a55cc37

@hanno-arm @mpg I have reworked the PR according to your remarks. Could you please re-review it?

@hanno-arm I hope to have addressed all of your comments correctly. Could you please re-reveiw?

@hanno-arm @mpg I have rebased the PR. Can you please re-review?

CI only failed in know-flaky GnuTLS interop with fragmentation, so as good as a pass.

@hanno-arm @mpg The PR has been rebased against development

https://github.com/k-stachowiak/mbedtls/tree/param-valid-ccm has an identical result to https://github.com/k-stachowiak/mbedtls/tree/param-valid-ccm but omits the two commits "Add initial options and support for parameter validation" and "Remove the library provided function of MBEDTLS_PARAM_FAILED" which have exactly reverse patches.

CI is ok except for the timing tests on FreeBSD.

Reviewed, approved and passes CI. Labelling as 'ready for merge'.


cannot get ./scripts/generate-bosh-lite-dev-manifest running

I'm trying to setup a local CF using bosh-lite.  Getting an issue when I run ./scripts/generate-bosh-lite-dev-manifest.  It states Director UUID is not defined in deployment manifest.  Did I miss a step here?
./scripts/generate-bosh-lite-dev-manifest deploy.yml
./scripts/generate-bosh-lite-dev-manifest: line 25: ./scripts/../bosh-lite/deployments/cf.yml: Permission denied
Director UUID is not defined in deployment manifest

@Amit-PivotalLabs any ideas?

@NareshKosgi @cppforlife migrated this issue to cf-release: https://github.com/cloudfoundry/cf-release/issues/864


RVP in ViewPager

Hi.
I have three tabs which your library is used in the middle tab in horizontal scrolling. When I scroll right, it is fine however when I scroll left, it changes the tab.
I record a video that you can watch below. Can you help me to resolve it? Thanks and Best regards
http://www.myscreen.my/img/device-2016-03-16-023207.mp4

I think that you can override ViewPage's dispatchTouchEvent to prevent RVP from ViewPager's handling when you are touching in RVP area.
May be i could add a demo about this!

hi. thanks. really i need demo. please help me. thanks so much
Sent from my Samsung Galaxy smartphone.-------- Original message --------From: lsjwzh<EMAIL_ADDRESS>Date: 16/03/2016  23:01  (GMT+08:00) To: lsjwzh/RecyclerViewPager<EMAIL_ADDRESS>Cc: myscreen<EMAIL_ADDRESS>Subject: Re: [RecyclerViewPager] RVP in ViewPager (#70)
I think that you can override ViewPage's dispatchTouchEvent to prevent RVP from ViewPager's handling when you are touching in RVP area.
May be i could add a demo about this!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

can you provide me a simple demo ;(
Thanks


detect long press end

Is it possible to detect when a drag is completed? I tried adding a GestureDetector as the parent widget but it just seems to break the DragSelectGridView widget.

What do you mean by "break the DragSelectGridView widget"?

i mean the DragSelectGridView widget fails to respond to gestures when it has a GestureDetector as its parent. I looked through the code and noticed that the DragSelectGridView widget itself has a GestureDetector widget, but the onLongPressEnd event does not pass any information back to the user to indicate that the drag has been completed. Is this something you've given thought to, cause it seems like an obvious event that the user should be able to receive as a callback.

i mean the DragSelectGridView widget fails to respond to gestures when it has a GestureDetector as its parent.

This is something the parent should be able to handle. By default, when you have nested GestureDetectors, the child is going to receive the gesture events (HitTestBehavior.deferToChild). It's possible to send events to both child and parent by passing HitTestBehavior.translucent.

Is this something you've given thought to, cause it seems like an obvious event that the user should be able to receive as a callback.

No, I haven't thought about exposing such information. May I ask you why do you need such feature? I feel like exposing such callback would imply I need to expose all the other ones: onTapUp, onLongPressStart, onLongPressMoveUpdate. After all, what makes the callback you mentioned particularly more important then the other ones?

thanks for the help. i decided to use the Listener widget instead. By using the Listener widget i can just check for when the pointer is up. I read in the flutter docs that multiple cascaded GestureDetector widgets with the same event listener will clash and only 1 will run.

May I ask you why do you need such feature?
It's for a project i'm working on.


#1 Minor

Sorry I messed up some thing :3. Pls just ignore this

This pull request introduces 3 alerts when merging 115f41b75f50783ea4d226f006a9260e4682333f into e3ad351d2291ec03b6108dd17b9be57fa89ba4ed - view on LGTM.com
new alerts:

3 for Unused import

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com


Hidden input field breaks responsive design

The below hidden input field adds additional width to  that may break design in Angular-based layouts.
<input type="file" style="visibility: hidden; position: absolute;">
Could it be solved with adding left: 1px; width: 1px or similar positioning trickery?

Possibly display:none is worth a try? I was struggling with this the other day.


OptionButton Throwing Errors in Export

Tested versions

Reproducible in Godot Engine v4.2.stable.official [46dc27791], unsure of previous or newer versions.

System information
Windows 11 Home
Issue description
Interacting with an OptionButton produces an error message:
ERROR: Attempt to disconnect a nonexistent connection from 'root:<Windows#24779948753>'. Signal: 'focus_entered', callable:...
at: (core/object/object.cpp:1420)
ERROR: Attempt to disconnect a nonexistent connection from 'root:<Windows#24779948753>'. Signal: 'tree_exited', callable:...
at: (core/object/object.cpp:1420)
Only when the project is exported to executable, both release and debug, but does not produce an error when run in the editor.
Steps to reproduce
Starting from an empty project with the root node being a control node, add a child OptionButton and add 2 items to it, labeled Option 1 and Option 2. Then, export the project with the console to an executable. The console executable will display an error when an option is selected in the OptionButton.
Minimal reproduction project (MRP)
Test.zip

Can you try this with 4.2.1? Or 4.2.2.rc2? This might have been fixed and you are on an out of date version

I did just now try it with v4.1.3.stable.official [f06b6836a] and the error did not occur. I can try with other versions here soon.

That's an older version, but good to get comparison that means it was introduced after 4.1 was released

The error was reproduced in v4.2.1.stable.official [b09f793f5].

I can reproduce the issue with the MRP, using 4.2.1-stable, and 4.3-dev4 (didn't have dev5 templates locally to test).
I also confirm that there's no bug with 4.1.3-stable. So the regression must be a commit between 4.1-stable and 4.2-stable.

I tested intermediate releases and it seems that the error was introduced in 4.2-rc2:
https://github.com/godotengine/godot-builds/releases/tag/4.2-rc2
Here's the changelog for that snapshot: https://godotengine.github.io/godot-interactive-changelog/#4.2-rc2
From that list, #85280 seemed like a potential culprit. I tested in latest master with that PR reverted and confirm that this solves the error in the MRP.
CC @bruvzg @RandomShaper

Happening in v4.2.2.stable.official.15073afe3

Can't reproduce in 4.3.


Missing email notification for translation approval

As by subject, I only got it once (IIRC).
Other notifications seem to come just fine, including comments on translations not yet approved.

I just got two translation notification this morning, so it seems to work now; can't be sure that they were all the translation approved and it didn't miss anything, but still a great leap forward: thanks :)