[ISSUE #2883] [Part D] Improve produce performance in M/S mode.

Change log level to debug: "Half offset {} has been committed/rolled back"
Optimise lock in WaitNotifyObject
Remove lock in HAService
Remove lock in GroupCommitService
Eliminate array copy in HA
Remove putMessage/putMessages method in CommitLog which has too many duplicated code.
Change default value of some parameters: sendMessageThreadPoolNums/useReentrantLockWhenPutMessage/flushCommitLogTimed/endTransactionThreadPoolNums
Optimise performance of asyncPutMessage (extract some code out of putMessage lock)
extract generation of msgId out of lock in CommitLog (now only for single message processor)
extract generation of topicQueueTable key out of sync code
extract generation of msgId out of lock in CommitLog (for batch)

Coverage increased (+0.5%) to 52.362% when pulling 5fe0041686739ce3959dfa17a6ae63b84ab6320c on areyouok:dev_speed_D into b4240d5cea8d001c21b9c0d73f5aa700fcd0d568 on apache:master.


[Feature] Custom module formating

I would like the script of my custom module in "exec" to return json such as {"title": "NGGYU", "singer": "Rick"}, and that we can use them in format and tooltip-format, with {title} and {singer}, for example, instead of having to return {"text": "NGGYU - Rick"} and use {}
Can you can add this functionality, keeping backwards compatibility eventualy ?

See PR #2441, which has not been merged yet.


Update aws-core, http-client-spi, ... to 2.17.255

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.104 to 2.17.255.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #248.


TestInfo 、TestFUSE and TestMySQLClient  failed

What happened:
Three test cases failed .
What you expected to happen:
All test cases passed .
How to reproduce it (as minimally and precisely as possible):
Follow the actions https://github.com/juicedata/juicefs/runs/7871034723?check_suite_focus=true(TestFUSE) 、https://github.com/juicedata/juicefs/runs/7871311634?check_suite_focus=true(TestMySQLClient )
and https://github.com/juicedata/juicefs/runs/7870743494?check_suite_focus=true (TestInfo).
Anything else we need to know?
No .

Not reproduced for a long time.


machinelearningservices: workspace API isn't returning publicNetworkAccess

Service: Machine Learning Services
API Version: 2021-07-01
Hello,
We want to expose the field publicNetworkAccess in the Terraform resource for Machine Learning Workspaces. Unfortunately this field isn't returned from the API regardless of whether it is set to Enabled or Disabled (example PUT and GET down below with IDs redacted). It also looks like setting this field doesn't do anything, when I inspect the workspace in the portal it still says that public network access is allowed for all networks.

Can you please update the API so that setting this field sets public network access properly and also that this field is returned by the API.
Thanks!
cc. @denniseik
PUT
{
  "identity": {
    "type": "SystemAssigned"
  },
  "location": "westeurope",
  "properties": {
    "allowPublicAccessWhenBehindVnet": true,
    "applicationInsights": ***,
    "containerRegistry": ***,
    "description": "Test machine learning workspace",
    "encryption": {
      "status": "Enabled",
      "identity": {},
      "keyVaultProperties": {
        "keyVaultArmId": ***,
        "keyIdentifier": ***
      }
    },
    "friendlyName": "test-workspace",
    "hbiWorkspace": true,
    "imageBuildCompute": "terraformCompute",
    "keyVault": ***,
    "publicNetworkAccess": "Enabled",
    "storageAccount": ***
  },
  "sku": {
    "name": "Basic",
    "tier": "Basic"
  },
  "tags": {
    "ENV": "Test"
  }
}

GET
{
  "id": ***,
  "name": "acctest-MLW-2204071344164086",
  "type": "Microsoft.MachineLearningServices/workspaces",
  "location": "westeurope",
  "tags": {
    "ENV": "Test"
  },
  "etag": null,
  "properties": {
    "friendlyName": "test-workspace",
    "description": "Test machine learning workspace",
    "storageAccount": ***,
    "keyVault": ***,
    "applicationInsights": ***,
    "hbiWorkspace": true,
    "tenantId": ***,
    "imageBuildCompute": "terraformCompute",
    "provisioningState": "Succeeded",
    "containerRegistry": ***,
    "notebookInfo": {
      "resourceId": "72c7e7d8d62c4eca8e558cb7e45cf9e0",
      "fqdn": "ml-acctest-mlw--westeurope-941a184a-d1eb-4694-88ba-55126f8e17e0.notebooks.azure.net",
      "isPrivateLinkEnabled": false,
      "notebookPreparationError": null
    },
    "serviceProvisionedResourceGroup": ***,
    "serviceManagedResourcesSettings": {
      "cosmosDb": {
        "collectionsThroughput": 8000
      }
    },
    "storageHnsEnabled": false,
    "workspaceId": "941a184a-d1eb-4694-88ba-55126f8e17e0",
    "linkedModelInventoryArmId": null,
    "privateLinkCount": 0,
    "allowPublicAccessWhenBehindVnet": true,
    "discoveryUrl": "https://westeurope.api.azureml.ms/discovery",
    "mlFlowTrackingUri": ***,
    "sdkTelemetryAppInsightsKey": ***,
    "encryption": {
      "status": "Enabled",
      "identity": {
        "userAssignedIdentity": null
      },
      "keyVaultProperties": {
        "keyIdentifier": ***,
        "identityClientId": null,
        "keyVaultArmId": ***
      },
      "cosmosDbResourceId": ***,
      "storageAccountResourceId": ***,
      "searchAccountResourceId": ***
    }
  },
  "identity": {
    "type": "SystemAssigned",
    "principalId": "5eac07d7-047c-4986-bb08-e38681b664a9",
    "tenantId": "26e25406-6564-4a26-98ee-c71ba03235ad"
  },
  "sku": {
    "name": "Basic",
    "tier": "Basic"
  },
  "systemData": {
    "createdAt": "2022-04-07T11:47:39.9199045Z",
    "createdBy": "af46c99c-71b9-47cf-84f7-4f303c7596a1",
    "createdByType": "Application",
    "lastModifiedAt": "2022-04-07T11:47:39.9199045Z",
    "lastModifiedBy": "af46c99c-71b9-47cf-84f7-4f303c7596a1",
    "lastModifiedByType": "Application"
  }
}

Acknowledged and investigating

@stephybun publicNetworkAccess is returned from january 01 2022 api version onwards. Could you please validate this fixes your workflow?

I think the issue was that it was working before. Did something on the prior API version change? This was working just fine about a month ago and now it's not working as designed. See https://github.com/hashicorp/terraform-provider-azurerm/issues/16177#issuecomment-1091717454

@deeikele, still broken. We don't necessarily care about the value being returned either; the main issue is with setting the value with PUT, which is not working as intended. It was working about a month ago when we set up Azure ML for our organization, but, since then, I can't programmatically adjust it at all since it automatically sets that setting back to Enabled, which we don't want.
I've had a MSFT ticket open for this for a while now (#2204200040005290) and it seems from both sides I'm getting the same answer; just use the newer API version. Very frustrating from our side since there are several layers of abstraction, including Azure's own azure-sdk-for-go which doesn't even implement the newest API version, that prevent us from just "using the newer version".

We're seeing the same problem while using Terraform.  We set public_access_behind_virtual_network_enabled = false for azurerm_machine_learning_workspace but the setting is not updated on the actual resource.

@deeikele   Terraform  AzureRM uses API v2021-07-01, but portal is not using this version, I try reproduce error and found that portal uses v2021-10-01, the properties returned by the two APIs  are different.
v2021-07-01 vs v2021-10-01

Response from portal (v2021-10-01):

I've followed up over email @xuzhang3. I can confirm below call is succesfull using the workspace REST API
{
"location": "eastus",
"identity": {
"type": "SystemAssigned"
},
"properties": {
"friendlyName": "Test workspace",
"description": "test description",
"publicNetworkAccess": "Disabled"
..
}
}

seems to be no other way, except to upgrade the API from v2021-07-01 vs v2021-10-01 to cover this breaking change

Hi,
Not sure, but I guess that also breaks compliance evaluations for builtin policies :
https://github.com/Azure/azure-policy/blob/master/built-in-policies/policyDefinitions/Machine Learning/Workspace_PublicNetworkAccessDisabled_Audit.json

2018-11-19:
        "allowPublicAccessWhenBehindVnet": false,
2021-07-01:
        "allowPublicAccessWhenBehindVnet": false,
2021-10-01:
       "publicNetworkAccess": "Disabled",
2022-05-01:
        "publicNetworkAccess": "Disabled",
Didnt find a way to know which API version is used by Policy Evaluations.


Update to node v5.3.0, browserify v12.0.1

Prerequisites:
https://github.com/deathcap/voxelmetaverse/issues/52 Cannot "npm install" - commits do not exist
https://github.com/deathcap/voxelmetaverse/issues/60 nonexistent dependency (esprima-six unpublished)

https://github.com/deathcap/voxelmetaverse/commit/08791671ca7fa98a82efdc3d902caf78de829045


Allow parameterized typed in static mixin methods

We used to generate:
/** @type {function(number): string} */
Comp.staticMethod;

but that does not allow type parameters. By Using the following syntax
we can support type parameters.
/**
 * @param {!Array[T]} p0
 * @return {T}
 * @template T
 */
Comp.staticMethod;

We still need to use the @type syntax for abstract optional methods
but we could potentially figure out a way to allow type parameters there
too by using a temporary typedef and using typeof types.

TBR

LGTM


Unable to Install on Airflow

I am trying to install this library on Airflow, but Textract requires six 1.12.0 but airflow is unable to go down below 1.15.0. Is there a way I can get this installed on Airflow

changed it in requirements file


Create Publish Wishlist Action Endpoint

Create Publish Wishlist Action Endpoint

@Dracco30, @studentgrad0419 I reworked this PR.  Please review so we can merge by midnight!


✨[feature Request]:  Missing Hover Animation in the About Section

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The "About" section on the website lacks consistent padding around the content, leading to a crowded appearance. Additionally, there is no hover animation when interacting with the links or buttons in this section, which could enhance user engagement.
Use Case
Users expect a well-spaced and visually appealing layout for the "About" section, with hover animations that indicate clickable elements.
Benefits
Improves the readability and visual balance of the section.
Enhances the user experience by providing clear interactive cues.
Aligns the design consistency across the entire website, making it more professional and polished.
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@Anjaliavv51 I should prefer u give this work  also

@Anjaliavv51  why u closed it

It's not complete. I seen  everything

There no animation nothing is there not labled

@Sunilkumarchavhan9
https://meet.google.com/cts-thto-rge
please join the meet

i will explain u in detail.

@Sunilkumarchavhan9

Ok

@Sunilkumarchavhan9 work on this.
and also raise an issue for login.

@Anjaliavv51 if u give any social id of Urs it will best to conversation like twitter etc.

because I need work this project more

because I need work on this project more

Discord.
anjali_23151

@Anjaliavv51 can  u show me the file  of this issue  other vise tell me the name i didn't find previously  it was in the about sec

@Sunilkumarchavhan9 collection.html

@Anjaliavv51 ok


add options for websocket

add options for websocket

I'd love this PR to be merged since I need the rejectUnauthorized option to support self-signed certificates


Missing PathNotFoundException in nested arrays.

Hey,
I got the following json
{
  "array1": [
    {
      "array2": []
    },
    {
      "array2": [
        {
          "key": "test_key",
        }
      ]
    }
  ]
}

And i want to read the following path : $.array1[*].array2[0].key.
Actually my goal was to retrieve a list with [null, "test_key"] but this didnt work, however I expected at least a PathNotFoundException for $.array1[0].array2[0].key. Instead I get a list with ["test_key"].
greetings,
jan

+1
Exactly the same issue, I'm using Option.DEFAULT_PATH_LEAF_TO_NULL but the missing nodes are quietly ignored - I can see the null value only if the last leaf is missing.

One thing that complicates this is the AS_PATH_LIST option. The results must be the same regardless if this option is set or not.
Configuration conf = Configuration.builder().build();

List<String> result = using(conf).parse(json).read("$.array1[*].array2[0].key");

assertThat(result).containsExactly("test_key");

vs
Configuration conf = Configuration.builder()
       .options(Option.AS_PATH_LIST).build();

List<String> result = using(conf).parse(json).read("$.array1[*].array2[0].key");

assertThat(result).containsExactly("$['array1'][1]['array2'][0]['key']");

If the first example was to return [null, "test_key"] how would this be represented in the path list?

To get PathNotFoundException in this case (indefinite path + absent array indices) some option could be introduced: REQUIRE_PROPERTIES-like option, but more strict, e.g. REQUIRE_PATHS.
@nztomas Option.DEFAULT_PATH_LEAF_TO_NULL does not help you to get null because not a leaf but entire object node (at $['array1'][0]['array2'][0]) is missing.


weird interference with iostream

I'm suffering from weird interference with iostream.
Here's a test code:
    xt::xarray<double> t = {1};
    xt::xarray<double> y = {0.1};
    auto f = [](const auto &pred, const auto &correct) -> auto {
        constexpr auto esp = 1e-7;
    #if CASE == 1 //ok
        std::cout << "case 1" << std::endl;
        std::cout << pred << std::endl;
        std::cout << xt::log(pred) << std::endl;
        std::cout << xt::log(pred + esp) << std::endl;
    #elif CASE == 2 // nan
        std::cout << "case 2" << std::endl;
        std::cout << pred << std::endl;
        std::cout << xt::log(pred) << std::endl;
        std::cout << xt::log(pred + esp) << std::endl;
        std::cout << (correct * xt::log(pred + esp)) << std::endl;
    #elif CASE == 3 // ok
        std::cout << "case 3" << std::endl;
        std::cout << pred << std::endl;
        std::cout << xt::log(pred) << std::endl;
        std::cout << xt::log(pred + esp) << std::endl;
        std::cout << (correct * xt::log(pred + esp)) << std::endl;
        std::cout << -xt::sum(correct * xt::log(pred + esp)) << std::endl;
    #endif
        return -xt::sum(correct * xt::log(pred + esp));
    };
    std::cout << "returned: " << f(y, t) << std::endl;

With #define CASE 1 and #define CASE 3, console displays returned: 2.302585 at last line. However, with #define CASE 2, console displays returned: nan. at last line.
What's going on here?

This is due to a dangling reference, which triggers an undefined behavior. On my computer, the first case is ok, the second and third one print NaN.
The dangling reference occurs when you return -xt::sum(correct * xt::log(pred + esp)). Here, esp is an lvalue and thus will be stored by reference in the expression. But esp is local to your lambda, and thus goes out of scope when your lambda returns, leading to a dangling reference.
One way to fix that is to return -xt::sum(correct * xt::log(pred + std::move(esp))).
For the long stor, see here

Okay, thank you for your reply!

There is an updated version of this doc here:
http://xtensor.readthedocs.io/en/latest/closure-semantics.html#writing-functions-that-return-expressions


Update translate.ps1

Powercfg command isn't supported for WS2008 R2 if SP1 isn't installed.

Brian, do you want to do the proper changes? I just sent this out to unblock a customer.

Brian, do you want to do the proper changes? I just sent this out to unblock a customer.


[FEATURE] Add message reactions

Description
Enable users to react to messages in their chats with emojis
Screenshots
No response

It's great having you contribute to this project by creating an issue Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:

Sounds good to me. I'm willing to contribute.
Please assign it to me.

Hey! I would love to work on this for my first PR. Would you pls give some more information about this issue?

hey @Dun-sin i want to work on this can you assign this to me

How would you?

well i will have to go through all code but if you assign me this i can start looking into it,i  am basically thinking of attaching a reaction value and render reaction if any according to the value

well i will have to go through all code but if you assign me this i can start looking into it,i  am basically thinking of attaching a reaction value and render reaction if any according to the value

Using any library? 🤔

Anyway go with it, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck

@ShahIsCoding been inactive for too long, unassigned

I want to work on this issue.

I want to work on this issue. please assign me.

sure, thanks for wanting to contribute, read the issue description properly and understand what it tells you to do also feel free to ask questions, make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck.

@12345rams according to the contributing guideline, your time is up and if there's a PR by the end of the day, you will be unassigned

I want to work with this issue

I want to work with this issue
okay, walk me through what you would do

@Dun-sin I want to work on issue #171 to add the emojis as the user reacts on the messages i try to do the same as we do in WhatsApp
can you assign this issue  #171 to me?

Is this available for assiging @Dun-sin , If yes then please assign me I can resolve this issue


session.endConversation('text') fails in Slack channel

If I invoke session.endConversation('text') with a text the method doesn't work and the text is not sent to the user in the slack channel, in console mode it works fine.
Otherwise if i do:
session.send('text');
session.endConversation();
it works fine,

Have you tried with the latest version of the SDK? There's no reason it shouldn't work but I can try to reproduce the issue.

Hello @Stevenic I'm experiencing the exactly same issue with the latest version of the SDK on Facebook.
session.endConversation(); works, and session.endConversation("any text"); doesn't.

I can't reproduce this on facebook...  I tried several combinations of calling endConversation() in the sample below and they all worked.
var restify = require('restify');
var builder = require('botbuilder');

// Setup Restify Server
var server = restify.createServer();
server.listen(process.env.port || process.env.PORT || 3978, function () {
   console.log('%s listening to %s', server.name, server.url);
});

// Create chat bot
var connector = new builder.ChatConnector({
    appId: process.env.MICROSOFT_APP_ID,
    appPassword: process.env.MICROSOFT_APP_PASSWORD
});
var bot = new builder.UniversalBot(connector);
server.post('/api/messages', connector.listen());

bot.dialog('/', [
    function (session) {
        builder.Prompts.text(session, "Hi, whats your name?");
    },
    function (session, results) {
        session.endConversation("Hello... %s", results.response);
    }
]);

Can you see if the sample above reproduces the problem for you guys?

Assuming the last message from steve fixed it. Closing due to inactivity, please open a new issue or reply to this one asking us to reopen if needed. Thanks!

I am experiencing the same issue with endConversation in the email channel.
If I use session.endConversation with a text string, it fails intermittently and when it fails no email is sent.  If I use session.endConversation with a msg object, it always works and an email is always sent.
In the emulator channel endConversation always works no matter what kind of argument is used.
-Colin

That's interesting... calling session.send() with a string simply fills out a message for you under the hood. Could be a timing issue...
I don't know where your at in your dialog flow but have you tried just calling endDialog() instead of endConversation()?  This cuts some steps off which could help diagnose.

Does this still reproduce on email?

Closing because of age.  If you are still having an issue please raise the issue again.


terminal not executing

im on kubuntu 18.10 and when i download shadowfox_linux_x64 and go to properties it shows it is already set as executable, double clicking on it doesnt bring up the GUI in terminal. if i go to see if the process is running, it is. if i chmod +x shadowfox_linux_x64 it does the same thing. if i ./shadowfox_linux_x64 from terminal it works fine that way.
im fairly new to linux so i may be making assumptions on how this should work but i have other files that are executable like that that seem to work just fine. also, this has been the issue for me for many versions, i just havent remember to bring an issue. i talked about it here, though: https://www.reddit.com/r/ShadowFoxCSS/comments/9ghs79/does_the_dark_scroll_bars_not_work_anymore/e64zkd9

This is expected behaviour, given that double clicking it just runs the program in the background, without actually showing any output. It is necessary to run it from the command line because the UI lives inside the command line


Categorize function

I would like to add a function that, given an array of clusters and an object, returns which cluster’s centroid they are closest to.
categorize(clusters, object)

The return value is the index of the nearest cluster inside the array.

closing this as it were some time ago


upgrade alpine to 2.15

3.15 works, but ran out of support a week ago
3.16 fails because of depext issues
I suspect opam changing from 2.0.8 -> 2.1 between these releases of alpine.
Tested building locally, will wait for CI to do it's thing.
PR checklist:

[X] PR comment includes a reproducible test plan
[X] Change has no security implications (otherwise ping the security team)

Issue with Circle?

Issue with Circle?

Yeah, looks like it lost the repo config after the returntocorp -> semgrep rename, I just reconfigured it, hopefully I can get it to trigger.


Add InputCode component (aka InputNumber)

Summary
Align with @ianrobertlambert, since we only use this type of component for OTP, we choose to rename it InputCode. The component may not be fully operationnal for OTP, but I choose to make a first version of it, which will be improved when we decide to implement it in to the Luko app. This is not the priority right now.
Checklist before requesting a review

[x] Working on iOS
[x] Working on Android
[x] Integration tests added
[x] Visual regressions screenshots are up to date
[ ] Design validated

Screenshots & E2E report

iOS
Android

Looks good from my side! Thanks @hcourthias 😊


map to location and vice versa

@varsharathore16 Review this PR and yeah I would like to thank @pabloescoder for helping me with this issue!


Integration not work. This device has no entities

Bosch info
There are problems with config of your thermostat.
You might have unsupported firmware version 04.06.07.
Version

Home Assistant 2023.9.3
HA Bosch component version= iCom_Low_NSC_v1 (program version 04.06.07)

bosch_scan.json: https://jsonblob.com/1157029460720869376

Configure RELOAD logs:
2023-09-28 22:20:00.029 WARNING (MainThread) [custom_components.bosch] Unloading Bosch module.
2023-09-28 22:20:00.033 DEBUG (MainThread) [custom_components.bosch] Closing connection to gateway.
2023-09-28 22:20:00.033 INFO (MainThread) [custom_components.bosch] Setting up Bosch component version 0.23.2.
2023-09-28 22:20:00.034 DEBUG (MainThread) [custom_components.bosch] Initializing Bosch integration.
2023-09-28 22:20:00.034 DEBUG (MainThread) [custom_components.bosch] Checking connection to Bosch gateway as ***
2023-09-28 22:20:01.013 ERROR (MainThread) [custom_components.bosch] You might have unsupported firmware version 04.06.07
2023-09-28 22:20:01.016 DEBUG (MainThread) [custom_components.bosch] Bosch BUS detected: EMS
2023-09-28 22:20:01.017 INFO (MainThread) [custom_components.bosch] Bosch initialized.
2023-09-28 22:20:01.018 DEBUG (MainThread) [custom_components.bosch] Registering debug services.
2023-09-28 22:20:01.018 DEBUG (MainThread) [custom_components.bosch] Bosch component registered with platforms [].

Installation is finnished

Sensor and control is nothing

IVT
von RC300
Firmware: 04.08.02
Could be normal.
Please open the "Bosch thermostat"
and activate adding new noticed entities automatically

This didn't work. The notification came again

EasyRemote Mobile App Displays information correctly.

Try to do a firmware update.

I tried to find this. I couldn't find an update for the "Bosch Logamatic Gateway web KM200" software. Do I need to ask for support from the integrator?

If your KM200 has an internet connection, your device should do the update automatically (could take some hours and have a look into your app). Otherwise you should call the Bosch service.
https://community.home-assistant.io/t/buderus-web-gateway-km200-support/25432/71?u=honikos

I think it should be fixed in https://github.com/bosch-thermostat/home-assistant-bosch-custom-component/releases/tag/v0.24.1
I'll close issue now and reopen if you report that issue still occurs.


Refactor to improve DX

Currently we provide the following composables:
useDrupalCeFetchPage, useDrupalCeFetchMenu, useDrupalCeMessages, useDrupalCePage, useDrupalCeRenderCustomElements.
We will refactor the helpers, to be used in this way:
const { fetchPage, fetchMenu, getMessages, getPage, renderCustomElements } = useDrupalCe()

Solved by #116.


Lagoon-sync output colours

I think we need to do something about the colours on output - it's impossible to read the commands that are to be run on a black screen.

In fact, I think we remove the coloration generally - it really messes with the log output if you run sync in a custom task
eg.
[36;1mRunning the following:


Implemented recommendations of a usability study

This PR is meant for discussion, before merging, it needs localization and thorough testing!

Changes in after install setup

Less detail and reformulated for Keep local statistics users were concerned that CookieBlock can track them and sell the data. More details available after clicking.
Changed `Keep local statistics' defaul to checked.
Links to extensions for banner removal + mention that CB can break  websites.

Settings: similar to setup.
Popup:

Visualization of removed cookies. For implementation reasons, it is rather simple and it ignores paused removal (note that simple counting of removed cookies would be wrong, because same tracking cookies are being removed all the time).
Grouping elements of popup based on semantics.
Adding tooltips - users did not understand the Pause Cookie Removal checkbox or the Add Domain Exception button.

Stores description in a Bullet points with shorted disambiguation what is CookieBlock doing and
what not

Extension for testing: CookieBlock.zip. Installation guide: Firefox, Chrome


[Feature Request] Structured logging (KV) support

Structured logging enhances traditional text-based log records with user-defined attributes. Structured logs can be analyzed using a variety of data processing techniques, without needing to find and parse attributes from unstructured text first.
With JsonFormatter (PR #69) added, the KV can be injected into the output logs as a separated JSON object for parsing by third-party programs.
Implementation
Steps / History

[ ] Logging macros accepts a new optional parameter kv.
[ ] Add a new kv field in struct Record.
[ ] Implement kv::Value:

there are multiple possible implementations: enum (like serde_json::Value), std::any, log::kv::Value (based on crate value-bag), which one is better?

log:kv::Value issues

rust-lang/log#641

[ ] ... (We need to carefully consider how the API looks and is implemented)

A reference is the log kv implementation, we can see if we can improve anything base on that. There are more references in rust-lang/log#343.

I've started this work today, and trying the first step - implementing kv::Value.
There are multiple possible implementations, I'll try to summarize and keep updating the pros and cons of them here.

Make a enum like serde_json::Value ourselves
I prefer not to do this because it requires a lot of code to be written and a lot of effort to keep them interactive.

Use std::any
Consider how to support it for user-defined types? And if we need to support external traits (like serde) we need to write some code for that as well.

Use value-bag
Its implementation is a bit like enum + any, and external traits are available out of the box. This seems pretty cool. The only drawback is that it comes from an external crate, should we wrap it or just expose it to the user?

@AlexTMjugador Hi, I'm happy to know that you saw this issue. :smile: Yes, tracing has a large user base and is practically tested, so I'm learning about its implementation of kv as well. Thank you for the information.


🗒 add notice to readme about shopify-express deprecation

This is a companion to the deprecation PR on shopify-express.
As I mentioned there:

This has been overdue for a while. It's no secret that we haven't been maintaining this package for a long time. We've released other packages as open source which more adhere to the tech-stack and model we use in node applications and removed this package from our official documentation already. In making this change I'd like to redirect as many people as possible from this repo to packages that we will actually be maintaining.

I've tried to include as much help as I can in the deprecation notice for those who might need it, and we won't be actually archiving this repo or anything so you can continue to use it if you want. To those who have contributed here, thank you so much. Of course, feel free to fork this and continue to develop it if you would like.
@markiiikram @tylerball, I know you had wanted to call out to our future plans in some way, is the current wording too vague, or just vague enough?

@tylerball do you think I should just pull in the whole blurb about the koa libs from the shopify-express PR?

@TheMallen yeah! the more information the better, I think.

@tylerball is this good now? :)


SongRenderer: plug memory-leak

Just a drive-by fix; noticed this while rebasing some old patches; we're currently leaking the events-array. It's not a big deal, but we might as well plug it.

Nice catch!


HTTPoison.Base was implemented as "defp" but should have been "def" (in module Forcex.Api.Http)

I just compiled my project to include forcex and got the following warning:
warning: function process_response/1 required by behaviour HTTPoison.Base was implemented as "defp" but should have been "def" (in module Forcex.Api.Http)
lib/forcex/api/http.ex:1: Forcex.Api.Http (module)

This is fixed in https://github.com/jeffweiss/forcex/pull/54 .


Shift+Enter in Python console extends the current line instead of creating a new one

what exactly is working wrong?
I tested auto-indentation and execution of script with shift+enter instead of enter. It worked.
Script was:
for i in range(10):
    print 'a'

It's not about indentation. It's about line numbers:

Ah, I get it now


Clarify when the changed signal is emitted for Resource and Material

Proposed fix to #69571

Bugsquad edit, fixes: #69571

Could you also please squash your commits into one? Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing.

Thanks! And congrats on your first merged Godot pull request!


Added support for Transfers

Added "create", "retrieve" and "cancel" hooks

Can we get this merged?


Appstudio update test-component-pac-kjcv

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-kjcv-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
27 seconds
build-container

✅ Succeeded
25 seconds
inspect-image

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
23 seconds
deprecated-base-image-check

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
20 seconds
label-check

✅ Succeeded
7 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-component-pac-kjcv-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
27 seconds
build-container

✅ Succeeded
25 seconds
inspect-image

✅ Succeeded
23 seconds
deprecated-base-image-check

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
20 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary


WAV: support of more flavors

Any combination of 44/48/96 kHz * 8/16/24 bits * 1/2/6 channels in WAV/PCM.
8-bit content is unsigned, 16/24-bit content is signed.


Deploy multi zones cluster

We need a simple and cost effective way to deploy multi zones cluster for demo cluster. We have some possible way:

docker compose
use binary directly

In my opinion docker compose is better, we should create a docker compose repo which has:

local cluster with all nodes
separated docker compose for each server

@giangndm for autoupdates we can just package https://github.com/containrrr/watchtower included in the docker compose file, and host the docker compose yaml along with a bash script in a repo so we can use a single command like (wget -O "script_url") > /bin/bash to deploy it anywhere.
Custom configurations can be config through a .env file or be set using the -e flag

@luongngocminh I think we will have 2 version:

simple version use docker-compose direct and above watchtower
advance version can be a deployer service which run independent for deploying autoscale multi-zones cluster

How often do you think we will need to update the docker-compose file? Unless there are breaking changes, I don't think it's that much of an issue to be needed to be done automatically.
We can provide an update script also if that's necessary.

@luongngocminh Sure, maybe the config will be changed during alpha version, but we can manual update that or simply use cronjob

Now we can easily deploy a cluster or single server using this: https://github.com/8xFF/atm0s-docker-compose


Adding volumes and volumeMounts to ambassador service helm chart

We need to use volume mounts to import our SSL certificate into ambassador (due to how it's being stored), and the helm chart doesn't allow us to add volume mounts. This PR adds that capability.

Is there anything further I need to do to get this merged? I've noticed the build is failing, but that seems to be the case for all open PRs, and the error doesn't seem related to these changes.

My apologies for the delay -- we've been mostly heads down on Ambassador 0.50.0!
Let me verify, though: no volumeMounts section generated at all with the default values.yaml, correct?

Yep, using the default values.yaml will result in the same result as the current chart. I wasn't sure about was whether you'd want to bump the patch or minor version number on the chart with the change - let me know if I should change that.

Great, thanks for the confirmation!
We've been generally sync'ing the version number with the version of Ambassador that's current when the Helm chart is updated. Happy to take suggestions, but your switch to 0.40.1 is what I'd do at this point.

Awesome, sounds great!

I think we have everything we need, yes. I'm planning to land this into 0.40.2 very soon -- thanks!

Taking for the next 0.40


Support point size when drawing point clouds with remote tree viewer

I'm not 100% sure this isn't supported by the channel feature, but I don't think it is.
Not high priority, just writing this down because it would be useful.

+1.  Also, line width would be a nice to add.
On the director side, Point size is an exposed display property.  Line width is not an existing property but it is easily added and I'd be happy to help.

Hi, maybe I can mention something related. I'm drawing point clouds which end up at the leaves of remote tree viewer. However, to change the size of points, you'd have to update them all individually down the tree one by one... Is there maybe a shortcut for this or a global modification field?

Sounds like we might need a new command like setproperties with a path and a dictionary of properties, which would then recursively set those properties for all geometries below the path.

fyi, i recently merged a branch which adds a Line Width property in director.  So if we wanted this could also a display property in remote tree viewer.  This lets you draw thicker lines without having to draw lines as cylinders.

you can also set Line Width on the triad objects, which is convenient for making them more visible.


Proofread README.md

The apostrophe changes are a matter of formality. It is best to avoid apostrophes for conjunctions, and only use apostrophes for showing possession. E.g. 'Bill's code'.
'a couple of' -> 'several' - 'couple' is associated with literally two items. This is also a matter or formality.
'run' -> 'runs' - Typo

Seems 👍 to me

Thanks


where are datas in the app from?

hello，I'm confused about where your datas in the app from？Can you please tell me about this?

@binbinla It was scraped from the official NBA.com https://github.com/wwayne/react-native-nba-app/blob/master/app/channel/address.js#L18
I'm not sure if it is still available

Its still available
Sample: http://data.nba.com/data/json/cms/2017/league/standings.json

@wwayne Hello ,  I was trying to scraped datas from the website you offered in https://github.com/wwayne/react-native-nba-app/blob/master/app/channel/address.js#L18 . Here is the problem :  I used window.fetch(url) to finished the network request , it  worked for the website started with 'http://data.nba.com/' , but it didn't work for the website started with 'http://stats.nba.com/' .  I couldn't figured out why , could you please help me point out . Thanks.

@binbinla Sorry I have no idea for that, it may relate to the NBA official websites security policy, I would suggest you use whatever works for you


max_tracelength option is global, not local

Example:
#lang forge
option problem_type temporal

one sig Counter {
    var count: one Int
}
pred init { Counter.count = 0}
pred move { Counter.count' = add[Counter.count, 1] }
pred traces {
    init
    always move
}

-- expect to need 2^<bitwidth> states to loop back around and form a lasso
-- 2 Int: -2, ..., 1
-- 3 Int: -4, ..., 3
-- 4 Int: -8, ..., 7
option max_tracelength 10
test expect {
    -- Confirm extension w/o traces pred (confidence test):
    traces_1: {init and move} for 3 Int is sat
    -- 16 is too many to loop back in 10 states
    unsat_10_4: {traces} for 4 Int is unsat
    -- however, 8 is not too many to loop back in 10 states
    sat_10_3: {traces} for 3 Int is sat
}

-- Adding this should apply to only the _later_ test cases
option max_tracelength 16
test expect {
    -- with 16 states, we have just enough to loop back
    sat_16_4: {traces} for 4 Int is sat
}

Test unsat_10_4 fails in Forge 2.1.0; if you turn on verbose 5 you'll see that the max tracelength sent to Pardinus is 16 for that test. If options apply in-place, I'd expect the trace length there to be 10.

@bennn Example demonstrating the option-ordering question as promised. This example where the problem arise is temporal-specific, but seems likely to impact other options as well.

Folllowing up on this, copying contents of a code-dive mail I just sent. This isn't just temporal options; it's an issue with the exec submodule.
Forge option statements are supposed to take effect at their position in the module.  So this should pass:
#lang forge
option no_overflow false // default
test expect {
    overflow_allowed: {some i: Int | i > 0 and add[i,1] < 0} is sat
}
option no_overflow true
test expect {
    overflow_forbidden: {some i: Int | i > 0 and add[i,1] < 0} is unsat
}

Unfortunately, this isn't currently happening. The issue is that, since we shuffle the execution of runs and tests to the end of a module (via the execs submodule) , they're displaced from their context between options. So something that expands as
option = 1
run A
option = 2
run B
will actually run as
option = 1
option = 2
run A
run B
We could fix this by just invoking add-to-execs on option statements. This fixes the example above. I believe this will affect how imports treat options, though: the execs module is meant to prevent importing a model file from actually executing anything that module runs. Predicates, sigs, even "run" names will be preserved, but the actual execution won't be.
So if I make this change, options will be excluded, too. Instead, it's worth investigating what is going wrong with the separation of

declaring a run
executing a run
The declaration shouldn't be delayed. And the declaration SHOULD be capturing the current options.

This issue is not happening for run, which led to finding the issue. There's a candidate fix on the fix_test_import branch. Risks:

Need to check other execution-generating constructs to confirm the same issue isn't present there;
Need to create a test case to confirm proper import semantics for options, runs
I believe this change will cause test runs (by name) to be imported, where before they were not since the creation of the run itself was deferred to the execs submodule. Need to discuss with @sidprasad to make sure this won't interfere with Toadus. (Not urgent.)

One other threat that comes up is: should the name of a test in module A be bound in a module importing A?
Why does the run macro in forge/core bind the id, rather than allowing the caller to bind the name, or not, as they wish? Perhaps in tests we ought to be using the functional version.


Comments

Comments seem to throw an error

I have tested it in my VSCode, and this way of commenting does not cause any errors.
You need to understand that CSS Better Sort only sorts your CSS code; the error comes from the CSS formatter, which reports an error and thus blocks CSS Better Sort.
You should check whether your CSS formatter (Prettier/Biome/VS Code's built-in formatter) supports this type of CSS comment.
Additionally, you can try using this CSS commenting method, which may not result in errors.
/** css comments **/


Transpile template literals

Another feature for those who care about minification. @mxstbr Please put attention on docs and suggest/make changes if something there is difficult to comprehend.

This looks great! Is there any reason to not enable this by default?

@mxstbr This is something I was not sure about. The only reason to disable I can see is that transpilation will make bundle size slightly bigger given you don't care about transpilation at all.
But you can always disable this feature in that rare case... Actually, I'm thinking about making it enabled by default as it's the case for most users.

Yeah that sounds reasonable to me!

Made it enabled by default and updated docs.


Crash report [FlurryStreamMessageDeserializer streamMessageFromData:error:]

I have crash reports in XCode for
Flurry_iOS_SDK: -[FlurryStreamMessageDeserializer streamMessageFromData:error:] + 260
No further details (just empty Thread 1)
I have a total of 48 reports, all on iPhone. This compared with my user numbers would imply a very rare edge case.

no further occurrences of this -closing it


rye: 0.6.0 -> 0.11.0

Description of changes
Update rye to its latest version.
CHANGELOG: https://github.com/mitsuhiko/rye/releases/tag/0.11.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 244122 run on x86_64-linux 1

1 package built:

rye

The darwin CI is failing:
ld: symbol(s) not found for architecture x86_64

I don't know really why it happens.

Result of nixpkgs-review pr 244122 run on aarch64-darwin 1

1 package built:

rye


Jest tests don't finish when using --record-logs=all

Hey there,
It seems that intermittently, the logger fails to log correctly and never finishes, hanging the test process.  Sometimes it finishes, sometimes it doesn't.

Detox: 9.0.1
React Native: 0.56.0
Node: 10.5.0
Device: iPhone 6 Simulator
Xcode: 9.4.1
macOS: High Sierra

I'm using this command to launch the tests:
yarn detox test --configuration=ios.sim.debug --runner-config=test/detox-jest.json --specs=e2e/ --artifacts-location=./.e2e/flexmobile  -f '"e2e.*"' --record-logs=all
If I remove the --record-logs=all it works consistently.

@EdwardDrapkin , run with --loglevel trace and attach logs.

By the way, @EdwardDrapkin, looks like I've found the issue. It was a hack in a third party lib that caused a race condition. Thanks for the feedback, anyways!


[BUG][Functional] Unable to add multiple static routes targeting the firewall

Bug reports which fail to provide the required information will be closed without action.
Required Basic Info

Accelerator Version:  v1.3.8
Install Type: Upgrade
Upgrade from version: v1.1.7

Describe the bug
When adding multiple static routes within a route table targetting the firewall, the State Machine fails.
Failure Info

What error messages have you identified, if any: The error from Codebuild project PBMMAccel-DeployPrebuilt is:
"Error: There is already a Construct with name ‘FirewallRouteTableName_eni_Proxy_b’ in AccountStack [PerimeterPhase2]".
What symptoms have you identified, if any: The symptom is that the State Machine fails and the routes are not added to the Route Table.

Required files

Please provide a copy of your config.json file (sanitize if required) - not provided, but the relevant code is as follows:
{
"name": "RouteTableName",
"routes": [
{
"destination": "<IP_ADDRESS>/24",
"target": "firewall",
"name": "Firewall",
"az": "b",
"port": "Proxy"
},
{
"destination": "<IP_ADDRESS>/24",
"target": "firewall",
"name": "Firewall",
"az": "b",
"port": "Proxy"
}
]
},

Steps To Reproduce
Described above.
Expected behavior
I expect the State Machine to complete and individual static route entries to be created in the Route Table. Each route entry is targetting the firewall.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Validated as a bug
Extend fix #743 to include firewall target types (on VPC route tables)
review all other route types and ensure LID naming allows multiple targets/instances
do not break existing customers - be creative in LID naming per ticket 743
also see and fix related ticket #773

Fixed in this PR : https://github.com/aws-samples/aws-secure-environment-accelerator/pull/876

Done


⬆ upgrade dependencies

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
Upgrade dependencies
What is your testing strategy?
Run existing unit tests
Have you read the Contributing Guidelines?

[x] I have read the Contributing Guidelines

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.36%. Comparing base (4b0ec5a) to head (a34d3ef).
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   70.38%   70.36%   -0.03%
==========================================
  Files         110      110
  Lines        4488     4488
  Branches      439      439
==========================================
- Hits         3159     3158       -1
- Misses       1113     1114       +1
  Partials      216      216

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wrong computer name

In AT 4.12, one of the computers at the back (or top of the map) is labelled "pontremoli". Inspecting in real life, that computer is actually "ditali".

thanks, fixed. the room will be greyed out now until the next worker run (~15 mins)


HOFD-5 add delete form

What
Added delete function
Why
So form can be deleted from db

This looks good to me.


Add examples to Layout/IndentHash

Adds examples to layout/IndentHash

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests(rake spec) are passing.
[x] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Can you please restyle the examples to look like https://github.com/bbatsov/rubocop/commit/a50f67d8cae615484b5033a2096b63d4d9002bd3 ?

Thanks for your comments guys! I'll address these when I have a chance this weekend. 👍

@seport Just merged your other PR. Hopefully you'll have time to update this one as well.

@bbatsov Sorry this took me so long! Hopefully this looks better. Let me know if any other changes need to be made!

It looks great! Thanks! 👍


Add FaceDetection APIs

We haven't added the face dertection API but we added general object detection APIs along with a pre-trained weights for face detection (see http://support.sas.com/documentation/prod-p/vdmml/zip/index.html).


Update to Core 0.4

This is an (incomplete) updating of Font Picker to use Arcsjs Core 0.4.

Seems like I messed up the Github Actions. I also built this up ... iow I didn't intentionally delete properties (e.g. Ibis).
I'm hoping you (Ray) can help me restore full functionality!

It looks like the vs code demo may have been removed here, we do want to keep that around if we can. Whether it's follow-up for @cromwellian or otherwise, I wanted to mention. Ray, you could add it to the issue tracker.

Also (and first and foremost) thank you for doing this! @cromwellian I defer to you for code review, discussion, merge, etc.

Ack: seems like I removed a bunch of explainer/demo/ibis stuff. I'm not sure how that happened, I wasn't careful.


Init improvements

Coverage decreased (-0.65%) to 69.68% when pulling 888c5574fb1071f7b3bd161ed6e78c96a20b06ce on init-empty-dir-fix into b26df719ad55524b801b3bac266164417ff4b51e on master.

Coverage decreased (-0.49%) to 69.84% when pulling 57a40cd171939b7d386005e87a3effe9be67514d on init-empty-dir-fix into b26df719ad55524b801b3bac266164417ff4b51e on master.

Coverage decreased (-0.49%) to 69.84% when pulling 44d6e9d5afd5da2727537630f98d4fa85e2d54f7 on init-empty-dir-fix into b26df719ad55524b801b3bac266164417ff4b51e on master.

Coverage decreased (-0.49%) to 69.84% when pulling b7110722a7b4f987757f9bcfdaa3789b9a4a66c6 on init-empty-dir-fix into b26df719ad55524b801b3bac266164417ff4b51e on master.

Coverage decreased (-0.49%) to 69.84% when pulling b1087607528e4751824a9cb8b39e6f611098dd06 on init-empty-dir-fix into b26df719ad55524b801b3bac266164417ff4b51e on master.

Coverage decreased (-0.49%) to 69.84% when pulling fe84a2266fb83d737230420ac8d2d94420436389 on init-empty-dir-fix into b26df719ad55524b801b3bac266164417ff4b51e on master.


Styling issues in Safari

Just a note that the sidebar dropdown caret indicator is too low, and if scrollbars are enabled in macOS, the code snippets are unreadable.
Seems to only affect Safari

Fixed


Remove unmaintained component

Last commit was three years ago and the example is also failing.

Good point!
How that could be automated in hand-edited list?
Some automation needed with the bot checking the commits, stars and other activity then ( like on https://npmcompare.com for example)


sudo nixos-rebuild edit doesn't use default editor

Describe the bug
When running nixos-rebuild edit as root, the default editor is ignored. It always uses nano, no matter how anything is configured.
👟 Reproduction steps

Add programs.neovim.enable = true; and programs.neovim.defaultEditor = true; to /etc/nixos/configuration.nix.
Run sudo nixos-rebuild switch.
Reboot the machine.
In a prompt, type sudo nixos-rebuild edit.
BUG: the file is opened in nano, instead of neovim.

👀 Expected behavior
sudo nixos-rebuild edit should open /etc/nixos/configuration.nix in neovim.
😓 Actual Behavior
sudo nixos-rebuild edit opens configuration.nix in nano, regardless of my configuration.
Priorities
Add :+1: to issues you find important.

For me there is also a difference if I run an interactive shell (EDITOR is set to nvim) or not (editor is set to vim). Not sure why though.

https://nixos.wiki/wiki/NixOS_configuration_editors
I guess this helps you edit /etc/nixos/configuration.nix in editor of your choice.
worked for me.

Please use links to the new wiki https://wiki.nixos.org/wiki/NixOS_configuration_editors


ios: fix podspec for v0.2.0 support

Makes several updates to our podspec in order to fix CocoaPods integration with v0.2.0:

Link resolv.9 and c++ which is being done with Bazel today
Link SystemConfiguration which is being done with Bazel today
Specify Swift version and platform version
Specify source_files with an empty .swift file in order to ensure that Swift libraries are linked when building (i.e., swiftFoundation)

Important notes:
Releasing new versions of the pod requires the following manual changes:

Unzipping envoy_ios_framework.zip
Renaming the directory to envoy_ios_cocoapods
Creating an empty file at envoy_ios_cocoapods/Envoy.framework/Swift/Empty.swift. This forces CocoaPods to link Swift libraries as necessary. We worked around this in Bazel similarly in the past here
Copying the repo's LICENSE file and placing it at envoy_ios_cocoapods/LICENSE
Re-zipping envoy_ios_cocoapods and uploading envoy_ios_cocoapods.zip

In the future, we should see if this can be simplified or at the very least add a script that uploads this artifact with each commit to master just like we do with other artifacts. This is being tracked in https://github.com/lyft/envoy-mobile/issues/578.
I tested this PR by using this podspec for building an app against Envoy Mobile with CocoaPods. This spec is currently published as v0.2.0.
Signed-off-by: Michael Rebello<EMAIL_ADDRESS>

Yep, agree. Looks like https://github.com/CocoaPods/CocoaPods/issues/8649 is actually this problem and their workaround was also to include a .swift file. I'll link that issue in this commit


Sometimes Engine not making move in Training session, Exercise (initial position)

Do you have some more info for this? When you say "Exercise (initial position)" I understand that the problem occurs when you start training from the initial position of the exercise, right?  And "Engine not making move" means that the game has started (i.e. we are out of the workbook)? Or is it the program not making a move that is still in the workbook (exercise)?

I have identified and found some issues that were occurring in the Training mode when continuous evaluation was on.  Not sure if it will address the issues, you have encountered but it will be worth to re-test. Implemented in the private build 1.2.3 that I intend to publish in a couple of days.

oh sorry. I was busy.
Here is the demo. is it enough?
https://youtu.be/9GDAaUGhhmE
i also dont know why?

Do you have some more info for this? When you say "Exercise (initial position)" I understand that the problem occurs when you start training from the initial position of the exercise, right? And "Engine not making move" means that the game has started (i.e. we are out of the workbook)? Or is it the program not making a move that is still in the workbook (exercise)?

Still in the workbook

No problem, I realize you have other things to do too :)  By the way, I really appreciate the time you have put into submitting comments/reports/suggestions that have made the program better and much less buggy.
As for the issue at hand, looking at the video, that behavior is by design.
My thinking was as follows: when the solution is hidden (for example, after exiting the solving mode) and the user tries to move a piece on the main board, the program does not know what the user's intention is.  Do they want to start solving, but did not click any of the solution buttons, or do they want to edit the solution? Hence the message/question to the user to clarify their intention.
Of course, I can change this behavior if we can think of a better logic there.

I guess you missed it. I meant the difference between 7th second and 21 st second.

Ah, ok. But in the 7th second "Solving is in progress..." so the move is allowed, while in the 21st second there is no active solving mode, and the move is blocked as per the logic I described above.
Does this explain or am I missing something still?

Yes. You missed it. Engine not on responding first try.
https://youtu.be/hbrJuqNARSM

Oh, now I got it. Thanks!

Did you noticed the Speed in exercise ?
https://youtu.be/EY6lCbQ9sH8

Only that it's fast in both Solving and Training modes :).  What specifically should I have noticed?

No. I feel very slow in exercise.  I didnt mean engines reply moves. I mean my piece placements is very slow in exercise.
I request you to watch this clip in 0.5x.

Yes, that I have noticed, I'll be looking at this as soon as I start addressing various performance issues.

Actually, I had my suspicion, and I have already resolved the slowness issue. I'll try to publish a new private build 1.2.3 tonight (Costa Rican time :))
Explanation: a while back I added a function checking for identical positions within the Workbook when you make a move. In a large Workbook like your "SyZyGy" that takes a very long time.
My implementation has multiple issues: one, it shouldn't run in the Solving mode to start with, two, more importantly, it should run as a background process which is what I will implement as part of the planned performance improvements. For now, temporarily, I commented out that function altogether.
(I still can't reproduce the program not responding to the first move in the exercise, though. So, it may not be fixed in tonight's build.)

I have published a new private build 1.2.3 at the usual location https://chessforge.sourceforge.io/Releases/latest/ChessForge.msi
As I mentioned above, I haven't fixed the original issue as I can't reproduce it.  Can you reliably reproduce it on your machine?  Does it only happen on the first solving attempt and then works correctly every time after that?

Ok, disregard my questions. My wife was just able to reproduce this issue on her laptop. So, I have something to work with.

Now fixed.

Explanation: a while back I added a function checking for identical positions within the Workbook when you make a move. In a large Workbook like your "SyZyGy" that takes a very long time.

You are talking about 4000+ exercise.
Me imported

Now fixed.

I think it still may happen somewhere, sometimes  (looks like some timing issue with Windows messaging). But I can't repro on my machine, and on my wife's machine only happens with the non-debug build so very hard to investigate.

Just FYI. We were able to force a repro (with the previous version) and I have identified the reason for the problem.  It's truly fixed now.


Fixing bad link

Bad link that went directly to MD file for the powershell command.  Just removed the extension so it was the right link.

Docs Build status updates of commit f7aa66d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Sign-a-Package.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bump versions

This PR should be created automatically but I don't permissions to allow GitHub actions to do that. Right now, it fails with:
pull request create failed: GraphQL: Resource not accessible by integration (createPullRequest)

See logs
@alexcrichton can you allow actions to create PRs.
Please also publish this release
Fixes: #3530

@alexcrichton yes, please do add the secret. I would also like to reduce it down to one step, so adding a secret is necessary. You can go ahead and publish this release. We can automate the next one

Ok! I've added CRATES_PUBLISH_TOKEN as a crate secret here. It's scoped to wasm-bindgen*, js-sys, and web-sys only, but I think that should work?
Otherwise I'll defer to y'all when to merge this, but when merged I'll tag this and publish it.

There's one more version that still needs to be bumped, which is the 'Unreleased' heading in CHANGELOG.md that should now become 0.2.88. That should be it though, looking at #3475 for a reference.

I bumped it manually this time but we should update the script to automate this

I'm going to merge this for @alexcrichton to publish and tag. We can use the automated workflow from next release (I would love to fix it now but unfortunately I got ill...)

Ok published and tagged 👍


Can not get output in CBR version 6.4.0

File "navgen.py", line 503, in
main()
File "navgen.py", line 469, in main
tid_dict = generate_tid_dict(data_from_cbr)
File "navgen.py", line 355, in generate_tid_dict
if "windows" in threat_report['tags'] or "linux" in threat_report['tags'] or "macos" in threat_report['tags']:
KeyError: 'tags'

Hi @alibay7
Have you tried to running this recently? If you are still having issues let us know but I will close this out due to age.


Add openshift-python-wrapper as required

Add openshift-python-wrapper to requirements.txt and setup.py

!verified

Not needed anymore


Do you plan to add Inner Page sample?

Issue:
I've reviewed the template, and it looks fantastic! 🚀 Are there any plans to include inner page samples as well?
Details:
I've had a positive experience with the current template, and I believe incorporating inner page samples would provide a more comprehensive understanding of its capabilities. This addition would be highly beneficial for users exploring the template's potential use cases.
Request:
Could you consider adding inner page samples to enhance the overall utility and showcase the template's versatility?
Additional Context (if applicable):
Feel free to share any insights or timelines regarding the potential inclusion of inner page samples. This information would help users anticipate and plan their use of the template more effectively.
Thank you! 👍

Thank you so much for reviewing and yes may be in the future i will add inner pages to this landing page Thank you so much


New version cardano-api-<IP_ADDRESS>

Changelog
- description: |
    New version `cardano-api-<IP_ADDRESS>`
  compatibility: no-api-changes
  type: maintenance

Context
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] The change log section in the PR description has been filled in
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
roundtrip tests

[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] The changelog section in the PR is updated to describe the change
[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG node developers to do this
for you.

Do we need this commit here: https://github.com/input-output-hk/cardano-api/commit/ec8bf580f18f085f94e44568d8479f81b2cb570e ?
It would be better to just have a version bump in the release pr I think.

The extra commits were pushed for testing purposes only and have been removed.


Safe Recovery Plugin

Adding another plugin that we can use to reset a key for recovery.  Right now this is a MVP to work with the ECDSA plugin.
List of changes:

Added an updateOwner() function to the SafeECDSAPlugin.
Added a RecoveryPlugin that can execute a tx from the Safe to reset the key.
Added a hardhat test to enable a RecoveryPlugin and test changing the key for the ECDSA plugin

Notes/questions from this work

After the SafeECDSAPlugin is enabled, the original owner of the safe can still execute transactions the normal 'safe' way.  Do we want to change this so that when a plugin is enabled you can't still sign transactions the old way?
Since we deploy the SafeECDSAPlugin with the acutal Safe, the plugin doesn't know the address of the safe.  So we can't do validation to check msg.sender is the safe.
I think it could be a nice UX improvement to make the ECDSA plugin a singleton or registry that anyone can enable.  Rather than deploying a plugin for every Safe.

After the SafeECDSAPlugin is enabled, the original owner of the safe can still execute transactions the normal 'safe' way. Do we want to change this so that when a plugin is enabled you can't still sign transactions the old way?
I spoke with Andrew about this earlier today, I think a default ECDSA plugin to begin, so original way is not required. Perhaps even an ECDSA multisig plugin that replicats the same functionality. For demos we don't need to remove the original safe multisig functionality, it's a helpful fallback if all validation plugins are removed or become unusable through user config error.
Since we deploy the SafeECDSAPlugin with the acutal Safe, the plugin doesn't know the address of the safe. So we can't do validation to check msg.sender is the safe.
There will be a way around this chicken/egg scenario, feel free to create an issue (or not if referring to https://github.com/getwax/wax/issues/89).
I think it could be a nice UX improvement to make the ECDSA plugin a singleton or registry that anyone can enable. Rather than deploying a plugin for every Safe.
Yes, also mentioned this morning. Feel free to create an issue :+1:


Add tests for sl-grid-header-settings component

Closed by https://github.com/softlayer/sl-ember-components/pull/344


Is this a bug?

For Dynamic method return types, I am wondering if you meant to allow a Promise type or any subclass of it?  If so, then I think the following code snippet might be a bug:
https://github.com/orfjackal/jumi-actors/blob/1e36f97e02171b00548553d8d4b8236fd8e12c1a/jumi-actors/src/main/java/fi/jumi/actors/eventizers/dynamic/DynamicListenerToEvent.java#L28
Should it be as follows?
if (Promise.class.isAssignableFrom(method.getReturnType())) {

You can check that by changing the code and running all tests; that change will make ActorsContract.handlers_can_return_arbitrary_futures fail. ;)
It helps to remember than the order of parameters in isAssignableFrom is inverse to the instanceof operator.

Thanks for the quick reply!  I fully understand the rules and I didn't realize the goal was to allow any subclass of the Future class.  Please note that I have not even tried to compile or run tests, I was simply reviewing the source code.  My initial thought was you were wanting to pin the base class to Promise.class.  For any instance of Future (but not limited to Promise.class), I would have expected the following:
if (Future.class.isAssignableFrom(method.getReturnType()))
Anyway, Thanks again.

Oh yeah, the Future interface. I forgot about that aspect.
I don't remember why I wrote the code to check for the custom Promise class instead of the Future interface. The way it's currently, instead of the isAssignableFrom method it would be clearer to just use the equals method, because Promise is a final class.
It might be possible to modify the code to support arbitrary Futures, though I'm not sure whether it would complicate things needlessly. I haven't myself used the return values much, so it's hard to say that what kind of an API would be best for the uses cases of this library. Also the Promise class still only has TODOs for exception support, so it's far from feature complete.
I guess I'll go change it to use equals and add some more TODOs about the Feature interface. 😆

Um, actually the original code was correct. It was just very non-obvious. I added a comment for that.
The code checks whether the return type is a supertype of Promise. This matches both Promise and Future. What it doesn't match is e.g. FutureTask. If the code would use if (Future.class.isAssignableFrom(method.getReturnType())) then it would also match methods which return FutureTask, but the code would crash at runtime because this wrapper code will always return a Promise instance to the caller.

I just realized that it should disallow Object return types. Maybe I’ll just do an equality check for Promise, Future and ListenableFuture.

Sounds reasonable.  FYI:  I am on Java 8 (CompletableFuture is awesome) and must use the latest released version, so I don't really have anyway to work with the master.  Also, the master does have dependencies on guava which has @beta or unstable stuff.  If somehow you can fix that sometime would be cool.
Finally,
The other issue I run into which I guess is normal, is that I have an interface which has metadata methods combined with actually methods I want to bind to (proxy).  I have had to use trickery and composites to make it work.  What would be cool if you could annotate only those methods which are applicable to proxying (if it is even possible).  Then it would simplify the code  and make the interface more flexible.  Example:
interface Foo {
    String getA();
    int getB();
    @Proxy
    void onDoSomething(String arg);
 }

Then when binding, it would scan and and only worry about the method with the @Proxy annotation.
The other methods would be ignored and hopefully not barf the Proxy object.

Guava is shaded inside the released artifact, so it should not leak into your project: https://search.maven.org/remotecontent?filepath=fi/jumi/actors/jumi-actors/1.0.277/jumi-actors-1.0.277.pom
The other issue could also be solved by checking the return type when the method is called, instead of when the actor system is setup. But I prefer failing early. Another option would be to have an alternative factory method for creating DynamicEventizer so that it relaxes those checks. I don't like littering code with annotations, so I would prefer to avoid the need to mark every method (marking the proxied methods or the ignored methods).
Please create a new issue about this need for unrelated methods in the same interface.


Issue when building with cmake

Build Process
Describe how you build polybar, list the exact commands you are using:
$ git clone --branch 3.2 --recursive https://github.com/jaagr/polybar
$ mkdir polybar/build
$ cd polybar/build
$ cmake ..
$ sudo make install

If you build polybar directly from this repository:

Output of git describe --tags:
3.2.1

If you use some other way (like the AUR):
List exactly where you are building from and which version you are building.
Building from ~/polybar/build, building latest polybar version
Build Log
Post everything that is output to the terminal while building polybar below. This HAS to include the output of the cmake and make commands, if you used them.
$ sudo cmake ..
-- Trying to enable ccache
-- Using compiler cache /usr/bin/ccache
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- broken
CMake Error at /usr/share/cmake-3.12/Modules/CMakeTestCCompiler.cmake:52 (message):
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /home/anthony/polybar/build/CMakeFiles/CMakeTmp

    Run Build Command:"/usr/bin/gmake" "cmTC_35de0/fast"
    /usr/bin/gmake -f CMakeFiles/cmTC_35de0.dir/build.make CMakeFiles/cmTC_35de0.dir/build
    gmake[1]: Entering directory '/home/anthony/polybar/build/CMakeFiles/CMakeTmp'
    Building C object CMakeFiles/cmTC_35de0.dir/testCCompiler.c.o
    /usr/bin/cc    -o CMakeFiles/cmTC_35de0.dir/testCCompiler.c.o   -c /home/anthony/polybar/build/CMakeFiles/CMakeTmp/testCCompiler.c
    cc: error trying to exec 'as': execvp: No such file or directory
    gmake[1]: *** [CMakeFiles/cmTC_35de0.dir/build.make:66: CMakeFiles/cmTC_35de0.dir/testCCompiler.c.o] Error 1
    gmake[1]: Leaving directory '/home/anthony/polybar/build/CMakeFiles/CMakeTmp'
    gmake: *** [Makefile:121: cmTC_35de0/fast] Error 2

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:23 (project)

-- Configuring incomplete, errors occurred!
See also "/home/anthony/polybar/build/CMakeFiles/CMakeOutput.log".
See also "/home/anthony/polybar/build/CMakeFiles/CMakeError.log".

Environment:

Distro (with Version):
Solus V.3.9999

Additional context
Add any other context that you think is necessary about the problem here.

Do you have gcc or clang installed?
Btw, you don't need sudo for cmake

Do you have gcc or clang installed?
Btw, you don't need sudo for cmake

Yup, I do have gcc installed, and it's outputting me this.

What is the output of cc -v?
Maybe you need to explictly set gcc as your compiler. Try running cmake again with this:
cmake -DCMAKE_C_COMPILER="gcc" -DCMAKE_CXX_COMPILER="g++" ..

This is the output of cc -v:
Using built-in specs.
COLLECT_GCC=cc
COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-solus-linux/8.2.0/lto-wrapper
Target: x86_64-solus-linux
Configured with: ../configure --prefix=/usr --with-pkgversion=Solus --libdir=/usr/lib64 --libexecdir=/usr/lib64 --with-system-zlib --enable-shared --enable-threads=posix --enable-gnu-indirect-function --enable-__cxa_atexit --enable-plugin --enable-gold --enable-ld=default --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --enable-lto --with-bugurl=https://dev.solus-project.com/ --with-arch_32=i686 --enable-linker-build-id --with-linker-hash-style=gnu --with-gnu-ld --build=x86_64-solus-linux --target=x86_64-solus-linux --enable-languages=c,c++,fortran
Thread model: posix
gcc version 8.2.0 (Solus)

It still didn't work with your command. The output was:
-- Trying to enable ccache
-- Using compiler cache /usr/bin/ccache
-- The C compiler identification is GNU 8.2.0
-- The CXX compiler identification is GNU 8.2.0
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- broken
CMake Error at /usr/share/cmake-3.12/Modules/CMakeTestCCompiler.cmake:52 (message):
  The C compiler

    "/usr/bin/gcc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /home/anthony/polybar/build/CMakeFiles/CMakeTmp

    Run Build Command:"/usr/bin/gmake" "cmTC_30ef7/fast"
    /usr/bin/gmake -f CMakeFiles/cmTC_30ef7.dir/build.make CMakeFiles/cmTC_30ef7.dir/build
    gmake[1]: Entering directory '/home/anthony/polybar/build/CMakeFiles/CMakeTmp'
    Building C object CMakeFiles/cmTC_30ef7.dir/testCCompiler.c.o
    /usr/bin/gcc    -o CMakeFiles/cmTC_30ef7.dir/testCCompiler.c.o   -c /home/anthony/polybar/build/CMakeFiles/CMakeTmp/testCCompiler.c
    Linking C executable cmTC_30ef7
    /usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_30ef7.dir/link.txt --verbose=1
    /usr/bin/gcc      -rdynamic CMakeFiles/cmTC_30ef7.dir/testCCompiler.c.o  -o cmTC_30ef7
    /usr/bin/ld: cannot find /usr/lib64/libc_nonshared.a
    collect2: error: ld returned 1 exit status
    gmake[1]: *** [CMakeFiles/cmTC_30ef7.dir/build.make:87: cmTC_30ef7] Error 1
    gmake[1]: Leaving directory '/home/anthony/polybar/build/CMakeFiles/CMakeTmp'
    gmake: *** [Makefile:121: cmTC_30ef7/fast] Error 2

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:23 (project)

-- Configuring incomplete, errors occurred!
See also "/home/anthony/polybar/build/CMakeFiles/CMakeOutput.log".
See also "/home/anthony/polybar/build/CMakeFiles/CMakeError.log".

I haven't found much information about solus packages, but I suspect that you don't have all the prerequisites for installing packages on your system. Try installing system.devel


Add default value to getSegment() method

Description
This PR adds a second parameter to the getSegment() method, so we can change the default value that will be returned when there is no segment set. Usually, this feature will be used along with setSilent(), so that the exception will be not thrown.
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Changes are ready.

Thanks you two. I know this was a much bigger process than this PR lets on!


make format_properties private

make format_properties private

please look at the (first commit)[https://github.com/sublayerapp/sublayer/pull/26/commits/1ce998eda38a0a50d05cb1c9196fce42e153a252]
to see the actual changes
the indentation really messes with github's ability to see the diffs properly

please look at the first commit to see the actual changes
the indentation really messes with github's ability to see the diffs properly
the second commit is only indentation


Add GHA publish to publish release to github

The publish workflow could be further tweaked to explicitly have a dist and publish job. See https://github.com/jcfr/jinja2-github/blob/main/.github/workflows/cd.yml

The publish workflow could be further tweaked to explicitly have a dist and publish jobs. See https://github.com/jcfr/jinja2-github/blob/main/.github/workflows/cd.yml

The other thing is if this package should be published to PyPI for easier use.


Publish Toolkit Components As Wrapped React Components

Feature/component description
As members of the community have been testing out the fast-react-wrapper in order to use the toolkit components inside React-based webview extensions the process of getting correctly set up has proven to be a bit difficult.
In order to ease some of the pain points and boilerplate currently required to get set up, we would like to explore taking on the responsibility of wrapping the toolkit components and publishing them so devs simply need to import the React toolkit component they desire.
Extra Context / Details / Thoughts
Ideally, the components can be imported using the following syntax (with the notable part being the /react sub-directory inside the toolkit package):
import { VSCodeButton } from "@vscode/webview-ui-toolkit/react";

Since this package will be consumed inside React and I believe (???) there is a reasonable expectation of being able to use ES Module syntax I'm going to say we probably don't need to provide a bundled Rollup version of the React components and can instead focus all our attention on using the TypeScript compiler to build a set of ESM-based components within a react sub-directory.
With that said, I'm open to listening to arguments/use cases advocating for having a bundled Rollup version of the React components.
More thoughts will be included in the comments as I think of them.

Oh, also cc @mattrothenberg.
I just realized I can't seem to add you as an Assignee for this issue because I assume you're not a part of the Microsoft GH org.

No problem! Starring this issue and will post updates as I make them. Stay tuned.

Also, a final thought for the moment is an implementation detail for @mattrothenberg:
In terms of defining the actual wrapped component code, I think I would prefer for it to live inside a src/index-react.ts file that pulls in all the toolkit components, wraps them with the fast-react-wrapper, and then exports those newly created React components.
Not super sure if there will be any gotchas with making sure that tsconfigs don't clash, but assuming it's possible, defining the wrapping and exporting code inside one file directly inside src would be ideal imo.

@hawkticehurst Agreed with this approach.

No problem! Starring this issue and will post updates as I make them. Stay tuned.

Woo, thank you!! 🎉
Also obviously feel free to reach out with Qs as you get oriented with the repo.


seq: missing -f option

seq is missing the -f option:
       -f, --format=FORMAT
              use printf style floating-point FORMAT

For example,
$ seq -f "%.3f" 0 .1 1
0.000
0.100
0.200
0.300
0.400
0.500
0.600
0.700
0.800
0.900
1.000

This could use the code that already exists in printf. I guess that code would need to be moved to uucore so that it could be used by both printf and seq (and others, if any other program requires printf-style string formatting).


Issue #78: Add Linux installation instructions for Go and Mage

Codecov Report

Merging #79 (9540097) into main (e2ee9a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   26.63%   26.63%
=======================================
  Files          13       13
  Lines         751      751
=======================================
  Hits          200      200
  Misses        521      521
  Partials       30       30

Help us with your feedback. Take ten seconds to tell us how you rate us.

Yup I think that's all it does -- links to Mage and shows Linux folks that's what they should use. I ported it from the updates I made to the template repo.

Yup I think that's all it does -- links to Mage and shows Linux folks that's what they should use. I ported it from the updates I made to the template repo.

I mean having "MacOS" or "Linux" sections is unnecessary in itself. The tools themselves are multi-platform, and have supporting documentation for specific platforms, so pointing to them without calling out each is sufficient.

Oh, could be! I can alter the Mage section here and in the template repo to be "Multi-platform" instead of "macOS"-specific.

Fixed in the latest commit https://github.com/TBD54566975/ssi-service/commit/e0e2f33d36fc21b2ecf3746eda3638f8b3281664
If there are specific OS commands worth adding, we can amend. If we're just pointing to mage/go docs - that's covered.


Correct info about when a wrapper is received

[Hello, just read this "Recipients of encrypted messages who receive encrypted or rights-protected mail sent to their Outlook.com, Gmail, and Yahoo accounts receive a wrapper mail that directs them to the OME Portal where they can easily authenticate using a Microsoft account, Gmail, or Yahoo credentials". and Outlook.com shouldn't be there. The experience is seamless with a Microsoft account as actually already mentioned in the article!, thanks.]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23994166-5118-02ea-c398-49099e5e03f3
Version Independent ID: 4954d005-4bf2-246d-ac43-a7660c62add5
Content: Message Encryption - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/ome.md
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

@ChristianJBergstrom Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/7784
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @ChristianJBergstrom Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[4.2][Fix] Reorder operation fix for more than 200 items

This is a fix for https://github.com/Laravel-Backpack/CRUD/issues/3722
NOTE: As pointed out by @tabacitu, it could break custom implementations so it could be merged as part of version 4.2.

A new inspection was created.

The inspection completed: 1 new issues

Thank you @o15a3d4l11s2 !
Tagged and added to project. We will be reviewing it when time comes 👍


Added fix to null hierarchy, which was deleting existing hierarchy

@rheafernandes - Merging the pull-request. But, expecting another pull-request with test cases ASAP.


Does it work ?

When I was trying to Authenticate,  it shows Error: &{   0 invalid character '<' looking for beginning of value}.
And then I insert  fmt.Println(string(body))in yggdrasilClient.Authenticate(). It look's like printing a html doc
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<TITLE>ERROR: The request could not be satisfied</TITLE>

403 ERROR

The request could not be satisfied.

Request blocked.

Generated by cloudfront (CloudFront)
Request ID: oCZRyfqWbMf0L8lZ_1g25d0yt-k2jxdiqipiRK_gn3bTA_5DB_5vQg==

<ADDRESS>
</ADDRESS>
```

This issue should be fixed now with the pull request made by @dazoe! Feel free to re-open if you encounter any further issues regarding this particular issue.


ca: Don't close "started" channel until the CA server is actually ready

"started" is closed slightly too early, so tests could start sending
requests to the CA server before it was ready to handle them. This bug
was present for awhile, but it was hidden before the join-token changes
because context was also set too early, so isRunning would return true.
This only affects unit tests, since the "started" channel is just used
to make the tests wait for the server to start up. So there should be no
impact on real-world use.
Fixes: #1255
cc @abronan @diogomonica

Current coverage is 54.83% (diff: 100%)

Merging #1261 into master will increase coverage by 0.10%

@@             master      #1261   diff @@
==========================================
  Files            78         78
  Lines         12422      12418     -4
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6799       6810    +11
+ Misses         4679       4668    -11
+ Partials        944        940     -4

Powered by Codecov. Last update e56300f...de6b80a

LGTM

Doesn't this code remove our protection against a doubly started CA?

Yes, but the protection was silly because we never start a CA twice. It was also racy.
I can add it back but it's a best-effort check.

With the new code we'll panic if you try to start it twice, which seems reasonable for something that should never happen by design.

The reason why we added it is because it was happening: if a node was demoted and then re-promoted, we were throwing a panic.

But we fixed that. Run won't be called twice in a row. Stop is always called in between, which resets the started channel.

LGTM


Upgrade lodash to v4.13

Problem:
Babel v6 depends on lodash v4.
npm v3 flattens and resolves to lodash v3.9 (from component-playground’s dependencies), and a babel error appears.
Solution:
This PR upgrades component-playground’s lodash to v4. Babel error disappears.
/cc @coopy @rgerstenberger @kenwheeler

:thumbsup:


Clean up cask audit tmpdir after use

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Cask::Audit#extract_artifacts is used in the #audit_signing and #cask_plist_min_os methods to create a directory in /tmp and extract cask artifacts without duplicating the work if it's already done. However, due to how this is set up, tmpdir isn't removed afterward and the extracted artifacts will take up disk space until the tmp directory is cleaned up. As a result, running brew audit --strict --online locally can chew through disk space and it may not be clear to the user where their free space has gone.
This adds a finalizer method to Cask::Audit to remove the created @tmpdir (if any) once it's no longer needed. There may be a better way of addressing the issue but this works for now without having to restructure how these audits work.

As discussed on Slack, it probably makes sense for brew cleanup to also clean up tmp directories that brew has created. From a quick glance at our use of #mktmpdir, we would probably have to institute a common prefix (e.g., using homebrew- or homebrew-brew- before existing prefixes) to be able to reasonably identify brew-created tmp directories (without manually maintaining a list of prefixes in use). There may be a better way of going about it but that was my initial thought.
That said, it may not be necessary if everything's working correctly. With this patch in place, I've only ended up with a lingering homebrew-unpack tmp directory on maybe one or two occasions but I haven't figured out why that happened (my best guess is that I may have prematurely interrupted a command using ^C).

As discussed on Slack, it probably makes sense for brew cleanup to also clean up tmp directories that brew has created. From a quick glance at our use of #mktmpdir, we would probably have to institute a common prefix (e.g., using homebrew- or homebrew-brew- before existing prefixes) to be able to reasonably identify brew-created tmp directories (without manually maintaining a list of prefixes in use). There may be a better way of going about it but that was my initial thought.

This is a good idea 👍🏻

(my best guess is that I may have prematurely interrupted a command using ^C).

I think we should still endeavour to have brew cleanup handle these.


Make jwks resolver timeout configurable

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
The current timeout of jwks resolver is 5 seconds, as found at https://github.com/istio/istio/blob/0cb0d8afc422349e22077f22d84c2084023e5417/pilot/pkg/model/jwks_resolver.go#L50
I think for some environments, 5 seconds may be too short and this value should probably be allowed to be configurable.
Describe alternatives you've considered
We've tried to use a local proxy for the jwks url, and use the local proxy to handle the longer timeout, but that's not quite a good solution.
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[x ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
We have jwt verification with a remote jwks url. The jwks server may from time to time get overloaded, and serve the requests longer than 5 seconds, but still in the tolerable range. However, istiod seems to report
context deadline exceeded (Client.Timeout exceeded while awaiting headers)

and then retry in an exponential fashion. This means our service would be down for an somewhat unpredictable amount of time until the jwks timeout is gone.

Hello @tugtugtug
I will take a look this week and I will try to push some changes :)

Closed as completed via https://github.com/istio/istio/pull/48203


Fix spatial colors

closes #10612
replaces/supersedes #11017

Awesome, marked for merge -- thanks in advance @drammock !

Hello @drammock, what's the status of this one? :)

Hello @drammock, what's the status of this one? :)

I am teaching this week, so may not get back to it quickly. CIs are not passing, feel free to take a look yourself.

thanks a lot @drammock 🙏

Amazing, thanks!

This will make plots look much nicer by default for our users! Super happy to see this included.


Notes

Is the fact that VNET IP rages overlap irrelevant?
Also, the RG creation has to set a region, otherwise private link might not be created.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f85b671d-f324-1bbb-9ae1-cfb4d14f642b
Version Independent ID: 6357b6d4-9748-c80a-7331-d69e486fa3ad
Content: Create an Azure Private Link service using Azure CLI
Content Source: articles/private-link/create-private-link-service-cli.md
Service: private-link
GitHub Login: @asudbring
Microsoft Alias: allensu

@mcurko Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Region is specified in commands for RG creation.  Will ask PM about overlapping networks, as the PoSh commands have separate network spaces.
#44498 @malopMSFT

From PM:
"Private Link Support PLS and PE in VNETs with overlapping IP space. Bot ends are independent of each other in terms of IP space."
#please-close


Mocking internal services

I have a module which creates a bunch of service objects, and then those are used to contruct some manager objects:
@Provides
@Singleton
public TokenStore provideTokenStore(final SharedPreferences sharedPreferences) { ... }

@Provides
@Singleton
public LoginManager provideLoginManager(final TokenStore tokenStore) { ... }

NOTE:  These two objects are actually in two different modules, as my data/http layer is separated from my business logic (which allows me to have an offline demo mode as well).
I tried inserting a mock version of TokenStore in my test class:
@Mock
TokenStore tokenStore;

While this replaces the TokenStore that's exposed via @Inject, this seems to happen
outside of the actual module itself.  So within the module, the TokenStore that's given to the
LoginManager is the real instance, and not the mocked one.
Is there any way to solve this issue, and allow the mock TokenStore to be used as dependencies within a module?

Hi, this example should work. Are you passing both modules when you create the rule?
Are you using it in an open source project? Or can you create a small example to reproduce it?
Thanks for you report

I think this may have had to do with the activity rule auto launching.  I have since made it a manual launch of the activity, and it worked.  However, i also struggled alot to get things compiled due to dependencies on dexmaker and some proguard rules that were needed.
  androidTestCompile 'com.github.fabioCollini:DaggerMock:0.6.2'
  androidTestCompile 'com.google.dagger:dagger:2.1'
  androidTestCompile "com.github.crittercism.dexmaker:dexmaker-parent:$dexmakerVersion"
  androidTestCompile "com.github.crittercism.dexmaker:dexmaker-mockito:$dexmakerVersion"
  androidTestCompile "com.github.crittercism.dexmaker:dexmaker-dx:$dexmakerVersion"
  androidTestCompile "com.github.crittercism.dexmaker:dexmaker:$dexmakerVersion"
  androidTestCompile 'javax.inject:javax.inject:1'
  testCompile 'com.github.fabioCollini:DaggerMock:0.6.2'
  testCompile 'com.google.dagger:dagger:2.1'
  testCompile "com.github.crittercism.dexmaker:dexmaker-parent:$dexmakerVersion"
  testCompile "com.github.crittercism.dexmaker:dexmaker-mockito:$dexmakerVersion"
  testCompile "com.github.crittercism.dexmaker:dexmaker-dx:$dexmakerVersion"
  testCompile "com.github.crittercism.dexmaker:dexmaker:$dexmakerVersion"
  testCompile 'javax.inject:javax.inject:1'

ext {
  dexmakerVersion = 'b0ac1c73a9530909a5ad4cbe03859e11eada0b06'
}