Expose AppStoreConnection and getTransactions method from the payment…

… queue wrapper so that "hanging" transactions can be dealt with.
Description
It isn't currently possible to do anything about AppStore transactions which for some reason were not completed, meaning they just hang around and cannot be changed. The underlying plugin code actually exposes a list of transactions already, which can simply be exposed and from that, create PurchaseDetails and run completePurchase on each of them.
Example code:
if (Platform.isIOS) {
AppStoreConnection appStoreConnection = _connection as AppStoreConnection;
var transactions = await appStoreConnection.getTransactions();
// print(transactions);
for (var transaction in transactions) {
var purchaseDetails = PurchaseDetails.fromSKTransaction(transaction, null);
if (purchaseDetails.status != PurchaseStatus.pending) {
try {
var billingResult = await appStoreConnection.completePurchase(purchaseDetails);
// print(billingResult);
}
on Exception catch(e) {
// print(e);
}
}
}
}
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

Unfortunately we're not able to accept patches without a CLA, so closing.

Unfortunately we're not able to accept patches without a CLA, so closing.


React Router routing with express router routing

Hi !
I'm currently working on an application who needs a server routing and a client routing for a specific route of the server router.
In fact my server router severs a lots of different routes where one of them is a front end React application who has his own inner routing.
For example :

(server route )  '/' : serves a single html page
(server route) '/app' : serves my React application
(client route) '/app/profile' : serves the page profile of my React application

This is my problem (I think it's more my lack of comprehension ) :
When I use on my client routing hashHistory I've no problems it works well but I've (ugly) URLs with query keys and for the user this isn't friendly at all.
And when I use on my client routing browserHistory (to have clean URLs) this don't work, react-router tells me "[react-router] Location "/app" did not match any routes".
I think I missed something but I don't really know what :/
Is there a way to avoid using hashHistory ?
Thanks a lot for your time and your help !

You need to configure your express server correctly: https://github.com/ReactTraining/react-router/blob/master/docs/guides/Histories.md#configuring-your-server

Oh I see ! Thanks a lot !
But in my routes definition of my client routing I must define :
var routes = {   path: '/app',   component: Root,   childRoutes: [     {path: 'user', component: User}   ] };
for it works well right ?
Thanks for your time ! :)


Ignore bench and canary test coverage

What changed?
Ignore bench and canary test coverage

Why?
The canary and bench are not the critical components belong to Cadence service.

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build fdc751cd-885f-44aa-aa96-5c1502ca3006

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
57 unchanged lines in 13 files lost coverage.
Overall coverage increased (+0.5%) to 60.267%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tools/sql/clitest/connTest.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

host/archivalTest.go
1
97.81%

service/history/queue/timer_queue_processor_base.go
1
79.5%

common/persistence/historyManager.go
2
66.33%

common/task/fifoTaskScheduler.go
2
87.63%

common/task/weightedRoundRobinTaskScheduler.go
2
89.64%

common/types/mapper/thrift/shared.go
2
65.01%

service/history/execution/mutable_state_builder.go
2
69.81%

service/history/task/fetcher.go
2
77.18%

service/matching/matcher.go
2
91.46%

common/cache/lru.go
3
90.73%

Totals

Change from base Build 6d46f454-ca28-40ea-bc90-538398b3097c:
0.5%

Covered Lines:
90031

Relevant Lines:
149388

💛  - Coveralls


installing nuget livecharts.winforms package installs also WPF package

why is livecharts.wpf package installed if i just need winforms components?

The WinForms version wraps the WPF using ElementHost class, this makes the code easier to maintain. Since WPF relies on Direct3D we can easily have animations, and a much better performance than using native WinForms Shapes.


Fix/drone setup missing packages

Codecov Report

Merging #4 (d568f9c) into master (066f241) will decrease coverage by 70.58%.
The diff coverage is 15.38%.

@@             Coverage Diff              @@
##            master       #4       +/-   ##
============================================
- Coverage   100.00%   29.41%   -70.59%
============================================
  Files            1        2        +1
  Lines            4       85       +81
============================================
+ Hits             4       25       +21
- Misses           0       60       +60

Impacted Files
Coverage Δ

torrentSearch/utils.py
25.92% <15.38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9f303...d568f9c. Read the comment docs.


add logging function to rtt sub-command.

It will be handy to log data from up channel to a file, just like JLinkRTTLogger.
So, a new option --log-file is added to specify the file name and enable logging mode.
Other two options are also added to select up/down channels.

Sorry to jump into this PR... I'm currently doing some API experiments and one of my ideas was to do some RTT console fetching in an example.  Unfortunately the current RTT implementation is not very flexible (underestimation).
How about extending the RTT module so that it exposes some methods like: SearchSignature() (perhaps in smaller bunches) and FetchData()?
If you already have your hands on this code, how about refactoring it a "little" bit?

@rgrr, RTTControlBlock.from_target in pyocd.debug.rtt seems just like SearchSignature.

@rgrr, RTTControlBlock.from_target in pyocd.debug.rtt seems just like SearchSignature.

@zjli-2019 : perhaps we have different sources, but I cannot find something like pyocd.debug.rtt or RTTControlBlock in pyocd.  Do you have a link to a file?

@rgrr you can find it on the develop branch:
https://github.com/pyocd/pyOCD/blob/8ac1dbac77150acb22fd88617653d55e63eb5fb0/pyocd/debug/rtt.py#L120

@rgrr you can find it on the develop branch:
https://github.com/pyocd/pyOCD/blob/8ac1dbac77150acb22fd88617653d55e63eb5fb0/pyocd/debug/rtt.py#L120

Thanks for pointing me into that direction.  That's exactly what I was looking for.  Question is when this will be integrated.

Question is when this will be integrated.

I'm planning a release of everything on the develop branch as soon as the CMSIS-Pack debug sequence support (#1488) is merged in. The only thing remaining (I hope!) is a fix for an issue related to generation of memory regions for flash algorithms that don't have an explicit region definition, when there are certain alias regions present. Actively being worked on.

Just the minor file-related requests.
On a more functional level, do you think it would make sense to have logging be independent of viewing/input? So you could simultaneously view and log, or save a log from an interactive session.

It is nice to be able to simultaneously view and log, or save a log from an interactive session.
If so, file format has to be considered: how to store input/output separately, how to parse it later, etc.
In my case, an up channel is used to transfer binary trace data.  Logging mode
is just like JLinkRTTLogger, and all data coming from the up channel is saved to a file that will be processed later.


Allow overriding plugin settings

Problem
When deploying a JupyterLite, some default settings might not be right for the use case of a particular deployment. It should be easy to finely-tune default settings, down the tool level (e.g. use one theme in /lab, and another in /classic/notebooks and another in /classic/editor).
Proposed Solution
Building on #58, add a new section to jupyter-lite.json that has the same structure as overrides.json (no JSON5, thanks!). So to disable the modal command palette:
{
  "jupyter-lite-schema-version": 0,
  "jupyter-config-data": {},
  "settings-overrides": {
    "@jupyterlab/apputils-extension:palette": {"modal": false}
  }
}

Alternately, these could right into jupyter-config-data, but it wouldn't be "canonical"...
Additional context
Wherever it lands, the Schema definition would be something like:
"settings-overrides": {
  "description": "plugin-keyed settings that replace the defaults. See https://jupyterlab.readthedocs.io/en/stable/user/directories.html#overrides-json",
  "type": "object",
  "patternProperties": {
    "that-enormous-regex:.*": {
      "type": "object"
    }
  }
}

In settings.ts, these would be read either by PageConfig (simple) or we have equivalent jupyter-lite.json reading equipment on the "app" side (more flexible).

add a new section to jupyter-lite.json that has the same structure as overrides.json (no JSON5, thanks!).

Sounds good :+1: If we can keep most of the configuration system similar to what JupyterLab already does, it should hopefully help keep things simple (and help documenting this).

Another approach might be to know about overrides.json in each folder, merging them upwards... it's more http requests that could 404, though...

Starting this now, going to keep in in jupyter-lite.json for the time being.


npm module without jQuery dependency

Now that velocity doesn't require jQuery, it would be awesome to remove the dependency from the package.json.
I'm using React and I don't need jQuery for my app as I can call React.findDOMNode(element). It's not possible for me to grab a version for Browserify that doesn't include jQuery with the current npm module.
https://www.npmjs.com/package/velocity-animate
Thanks!

Open to having 2 npm packages to retain compatibility with anybody's existing codebase. But that's what semver is for!

I'd also like to see the dependency removed if it's no longer one.

That's what's been bumping my file size by 500 kB!

+1

On it

Great! This would be awesome, especially in conjunction with https://github.com/twitter-fabric/velocity-react (which has a velocity-animate npm dependency)

Really looking forward to this! Besides that, any reasons why Velocity gets registered as global variable when i require it?

+1
Package explicitly claiming not being dependend on jQuery has jQuery as the only dependency on npm :) Would be better without it.

This is closed by: https://github.com/julianshapiro/velocity/commit/927b7313e2c34a3fe7b2a65553aa9e3c70dfcd55

Hi.
It seems 927b731 is merged into master as v1.3.1.
But in npm, latest version is still v1.2.3.
Could you please publish latest version to npm by npm publish?


New, unknown printing behavior

When I run the MNIST example, a bunch of "twos" are printed:

This seems undesirable for users.
Note: I had to temporarily fix issue #14 (deleting some imports in blobs/__init__.py) to get the MNIST example running. However, it seems unlikely that this is the problem.

Thanks for catching this, just pushed a fix.


Blue bar present when running in Android 2.2 but not when in Android 4.0

Using the same program with the same resources ( this means styles and drawables ) I get differente results when running in Android 2.2 and Android 4.0.
The most annoying of them all is definitely a blue bar under the ActionBar.
You can see the screenshots here:

Edit: I forgot to add that I was using the 4.0 RC version.

This was my experience as well. Native Theme.Holo.Light uses the solid style ActionBar by default, whereas Theme.Shelock.Light uses the transparent one with the blue keyline.
Easy enough to workaround by specifying an actionBarStyle, but I think it's a bug none the less.

Fixed in 4.0-wip. Thanks.


TexEnv data is not always updated after modification

Currently, a TexEnv is flagged for update in C3D_GetTexEnv, rather than C3D_TexEnvSrc, etc. As a result, if one retrieves a TexEnv with C3D_GetTexEnv and modifies it after drawing something, which triggers updates and clears flags, the final state will not take effect until after the next C3D_GetTexEnv call.

This is by design. Several state structures in citro3d like C3D_TexEnv are supposed to be independent of the current GPU state. The current design allows users to make their own C3D_TexEnv structures separate from the ones that are internally managed in the GPU context and configure them - to upload them the user can use C3D_SetTexEnv. Adding the dirty flag to any of the functions that configure a TexEnv structure would not make sense. Moreover, the return value of C3D_GetTexEnv is not supposed to be stored in a persistent variable - every time you want to modify the state of a TexEnv stage directly, you are supposed to call C3D_GetTexEnv and call the appropriate functions using its return value right away.

I can understand that, I just felt it a bit confusing as a beginner to this library, that modifying the TexEnv again did nothing.
With that in mind, I feel like it would make more sense to require SetTexEnv than flagging it dirty in GetTexEnv, as it may not have actually changed and could cause the confusion I had.


Cron schedule

Changes

Added a weekly scheduling of the CI job that runs the tests on the library

Outcomes

The workflow previously would only run tests against PR's and now it would also run on every Monday at 8:30 AM EST

Updates -
Changed the Python version from 3.6+ to 3.7+ in the CI pipeline since Python 3.6 reached the end of the line on Dec 2021, and it wont be no longer supported on latest versions of Ubuntu and is only supported until 20.04 version

Changed the documentation accordingly.

References
Please check out the issue and the contributor comment here on depreciating support for Python 3.6 - https://github.com/actions/setup-python/issues/544#issuecomment-1332535877

Updates -

Fixed the Pandas deprecated append function
Updated readme's , changelogs and bumped the version from 1.3.2 to 1.3.4 where ever necessary


Update README.md file with the settings examples.

The current guide to proper settings can be found in the settings.example.py and settings.example1.py file. But that is not quite the correct format when we have a README.md file to guide new users or contributors.
A better approach would be to rewrite the settings guides on the README.md file and later after everything is reviewed, we can delete the settings example from the code.
Or we can leave the settings in the codebase too, doesn't matter.
Make sure to check all the guides are exactly copied and since it's now on README file, a little text for better help would be a great boost.

Hi, I am new here and I would like to contribute on your project. This issue looks like great beginning. Can you assign me this issue?

@navanish07 Assigned!

Can you please assign it to me? I want to work on it.
and add the gssoc-ext label


Out circExplorer chimeric (or BSJ-only) reads in BAM

Nobu wants to visualize circExplorer chimeric reads. Exporting in BAM files is ideal. STAR 2.7.0f has:

Ideally, I would like to export both Junctions and SeparateSAMold. This does not work in STAR 2.7.0f, but seems to be working in 2.7.6a. But 2.7.6a, seems to allow running both together. This will require recreating STAR index.

Seems like it is still not possible in 2.7.6a:

Raised issue

Updating to 2.7.6a added the header line to the junction file
chr_donorA	brkpt_donorA	strand_donorA	chr_acceptorB	brkpt_acceptorB	strand_acceptorB	junction_type	repeat_left_lenA	repeat_right_lenB	read_name	start_alnA	cigar_alnA	start_alnB	cigar_alnB	num_chim_aln	max_poss_aln_score	non_chim_aln_score	this_chim_aln_score	bestall_chim_aln_score	PEmerged_bool	readgrp

needs to be removed before running CircExplorer2 parse

Not all chimeric reads but those leading to BSJs need to be redirected to a different SAM/BAM file.
Original request from Sarah

junctions2readids.py, filter_bam_by_readids.py and filter_bam_for_BSJs.py work together to get BSJ reads.

Find chimeric readids from junction file... NOT all chimeric reads are BSJ reads
Create an intermediate BAM with all chimeric reads
filter readids using CircExplorer2 parse to eliminate readids with no BSJs
use CIGAR filtering to find which "HI" value to keep just BSJ reads

junctions2readids.py, filter_bam_by_readids.py and filter_bam_for_BSJs.py work together to get BSJ reads.

Find chimeric readids from junction file... NOT all chimeric reads are BSJ reads
Create an intermediate BAM with all chimeric reads
filter readids using CircExplorer2 parse to eliminate readids with no BSJs
use CIGAR filtering to find which "HI" value to keep just BSJ reads


[pl] Probabilities and Statistics

Hi. First of all, great idea & project! Here is Polish version: https://github.com/mbiesiad/cheatsheet-translation
for "Probabilities and Statistics" 🔥
Best wishes

@kekuu could you CR, in your freetime?

Thank you @mbiesiad for all the work you have put into this translation! Let's start the review process.

@shervinea Ok, my pleasure!


Help running apiserver in a local minikube cluster

I have been trying to run apiserver-boot run local-minikube --build=false as explained in the docs (which haven't been updated since 2017) https://github.com/kubernetes-sigs/apiserver-builder-alpha/blob/master/docs/running_in_minikube.md without success under the release 1.18.0.
I will explain below what errors I get and how I have got around some of them in case it's useful. I'm not sure if what is failing is the tool or the document explaining the workflow to set it up.
At first glance it seems that it fails to run the apiserver with privileges, I get the following lines in the output:
I0803 18:08:26.949484  114681 local.go:199] bin/apiserver --etcd-servers=http://localhost:2379 --secure-port=443 --insecure-port=8080 --insecure-bind-address=<IP_ADDRESS> --delegated-auth=false
Flag --insecure-port has been deprecated, This flag will be removed in a future version.
Flag --insecure-bind-address has been deprecated, This flag will be removed in a future version.
I0803 18:08:27.026853  114722 start.go:363] loading in-cluster loopback client...
W0803 18:08:27.026895  114722 start.go:250] attempting to instantiate loopback client but failed: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined
Error: failed to create listener: failed to listen on <IP_ADDRESS>:443: listen tcp <IP_ADDRESS>:443: bind: permission denied

However, it will successfully run if I run it separately with sudo instead of doing it with apiserver-boot.
The next issue that I find is that the generated config/apiserver.yaml contains errors. It's generated with apiVersion: apiregistration.k8s.io/v1beta1 and has spec/priority. This will fail to run in kubernetes, to get over it I pump the apiVersion to apiVersion: apiregistration.k8s.io/v1 and remove spec/priority.
However spec/externalName seems to be hardcoded to <IP_ADDRESS>, not sure if this value is supossed to be correct or not, but after registering the apiserver on kubernetes it will fail to reach it, this is the Status reported when calling kubectl describe apiservice v1beta1.testing.foo:
Status:
  Conditions:
    Last Transition Time:  2020-08-03T16:09:50Z
    Message:               failing or missing response from https://<IP_ADDRESS>:443/apis/testing.foo/v1beta1: Get https://<IP_ADDRESS>:443/apis/testing.foo/v1beta1: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
    Reason:                FailedDiscoveryCheck
    Status:                False
    Type:                  Available
Events:                    <none>

In order to get over this I change externalName to one of my interface addresses and bind /bin/apiserver to such address by changing the value of it's --insecure-bind-address, and this makes it reachable from kubernetes.
After doing this it will report that everything is fine in the apiservice status:
Status:
  Conditions:
    Last Transition Time:  2020-08-03T16:25:37Z
    Message:               all checks passed
    Reason:                Passed
    Status:                True
    Type:                  Available
Events:                    <none>

However, at this point apiserver will start complaining about tls: bad certificate when performing it's TLS handshake.
This is the point where I'm stuck. I'm obviously configuring something wrong with my certs, but this should be easily done with apiserver-boot run local-minikube. Feel free to ask me for any information that might be lacking here.

thanks for reporting, apiserver-boot run local-minikube. i didn't get a chance to run this in my local environment yet, i will get back w/ more feedbacks later.

However, at this point apiserver will start complaining about tls: bad certificate when performing it's TLS handshake.

did you try setting insecureSkipTLSVerify: true in your apiservice's spec?

Yes, if I use insecureSkipTLSVerify: true it works, Thanks for your help!


closeOnClick : false is not working in vue3

Describe the bug
closeOnClick : false is not working in vue3
To Reproduce
Steps to reproduce the behavior:

change the default value of closeOnClick: false   notify({
        title: "Tenant Onboarding started 🎉",
        text: `Workflow_id = ${result.data["workflow_id"]} <br />
               Onboarding update will be sent to your mail id`,
        group: "onboard",
        duration: -1,
        closeOnClick: false,
      });

still in the notification will disappear on click

Expected behavior
notification should expire after a given time not the click
Screenshots

Desktop (please complete the following information):

OS: Macos
Browser: chrome
chrom Version 96.0.4664.110

Additional context
Add any other context about the problem here.

@sudhanshuptl, there is no option closeOnClick for notify. The option is only available in this way:
import { createApp } from 'vue'
import Notifications from '@kyvg/vue3-notification'

const app = createApp({...})
app.use(Notifications, {closeOnClick: false});

@sudhanshuptl, there is no options closeOnClick in notify. The option is only available in this way:
 <notifications
   group="foo-css"
   position="bottom left"
   :close-on-click="false"
 />

@kyvg Great it does work, but not properly reflected in the documentation.


Slow request after restart

Hello!
We want to use your solution as a docker registry backend. We need only 3 replicated node, so we have 3 monitor and osd. We use etcd too so we store datas in a kv backed (for test I use your populate.sh example). It works good until we don't restart the 3 node at same time. In this case I got slow request message when I want to try for example a docker pull from registry. The another intressting thing the cluster health is ok. After I restart all 3 osd  node it works good again. I really dissapointed because I spent many times to find the bug but I haven't any ide what is the problem.
Maybe this is not an issue but I hope you have an idea.
Platform: RedHat7 and cloud
Docker version: I try it with 1.8.2 and 1.9.1

Do you use pid=host to run your OSD?

No. It can help me maybe or why?

Yes it will. OSDs are really instable without this flag. I'll update the doc to reflect that.

Thanks for your help, it seems working fine now after ~5 restart.

@aga20 np np :)

@leseb, I think it is a terrible idea to pass --pid=host because it will allow container to do literally anything with host system. This is not the capability OSDs need to have.
The root of issue should be found and fixed, until then this issue is not resolved.
Situation is especially bad because you've added this anti-recommendation to readme.

@nazar-pc I understand your concern and it makes sense. However until the shared PID namespace option gets merged in Docker we don't really have the choice.

Can you clarify how --pid=host actually solves this issue?

It allows all of the OSDs to share a PID namespace (specifically, the host's PID namespace).
If the OSDs do not share their PID namespace, port exhaustion will rapidly ensue.

I should note that it doesn't matter if there is only a single OSD per host.

I'm not too familiar with such kind of issues, but there must be an alternative way to resolve the issue.
I was able to find article about similar issue in HAProxy blog: http://blog.haproxy.com/2012/12/12/haproxy-high-mysql-request-rate-and-tcp-source-port-exhaustion/
Also there are some Docker-specific suggestions here: https://github.com/docker/docker/issues/2842
I think mentioned solutions should help to fix an issue in proper way. Can anyone try them?

@nazar-pc You can see the original discussion: #19
This is not a problem with the TCP port timeout, CLOSE_WAIT state timeouts, etc.  The port exhaustion takes seconds irrespective of load.  It is a problem of the OSDs walking on each other.  They appear to have some port-use detection scheme, and when multiple daemons exist on the same machine when they can't talk to each other (referenced by the PID namespace), they start spontaneously walking all over each other.

Have you tried Docker 1.9+ Networking feature, maybe, it can help?
Also since issue exists, whose issue is that in the first place: Ceph or Docker?
From what I've seen http://tracker.ceph.com/issues/10763 is the upstream bug, it is is closed for whatever reason without being actually resolved.
I'm pushing because building infrastructure around hacks is not good (especially using --privileged or --pid=host), I prefer resolving issues entirely.

Using a custom networking scheme (via the Docker Networking plugin, for instance) should also be a viable solution, yes.  If you have separate IP addresses for each OSD, you shouldn't be competing over the same port-stack, so you will probably be fine.
Privileged mode is mostly a problem of tracking down all the required permissions.  This is made more difficult, though, because each of the different OSD schemes require a different set of privileges.  Not only that, there are some edge cases:  running BTRFS inline OSD journals, for instance, requires some other strange permission.
That said, all of my Ceph daemons are now running without privileged mode or --pid=host.  If you run in osd_directory mode and utilize a separate journal disk/partition, you can run without --privileged and without --pid=host.
--net=host is still required, of course, unless you use a custom networking scheme (since the OSD must know its own IP address and that IP address must be the same IP address at which all other members of the cluster reach it).

Thanks for explanation, my use case assumes using Ceph withing virtual network in Docker Swarm cluster using Docker Compose, so all containers will be within the same network and will have information who is where, so I think I'll not need --net=host either.
BTW, I have question about osd_directory, would be great if you can help there.

Just for historical reference:
I'm running osd_directory, without --pid=host, without --net=host, without --privileged, but with Docker 1.9+ Networking and everything works fine with 3 ODSs even if I restart all of them together.

@nazar-pc so no stability issues at all? Which networking plugin do you use?

It was testing setup on local machine, so it uses bridge by default, nothing serious yet. No issues when restarting one or even all OSDs together. I'll do more advanced setups with Docker Swarm cluster and overlay network later and definitely post updates/ reportissues if there will be something to say.


Flux, Redux & cia.

I'd love to see a ReactCast about Flux, Redux & other ways to organize a big project that uses React. I like Flux & Redux and I understand the motivations behind them, but I'm not 100% sold on any of them.
Also, bug report: in IE9 + Windows Vista, the name of the channel appears as AngularCasts. Please fix.

Thanks for the suggestion, @czanella.
As for your bug report: It's not a bug, it's a feature.

Hey @czanella: Loved to see your suggestion here, but looks like nowadays everybody uses Redux without discussion... Maybe an episode about "when NOT to use redux would be more useful, but than again we already have this.
I'll close this issue for now, but please come up with new suggestions!


Update README.md

Changed Wording added words

Thanks

Can I ask what I can do to make a better pr?


Test-Path does not throw an exception on invalid path

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Given this code:
function IsPathValid {
Param ([string]$Path)

try {
    if (Test-Path -Path $Path -ErrorAction Stop) {
        Write-Host "path $Path exists"
    } else {
        Write-Host "path $Path does not exist"
    }
} catch {
    Write-Host "caught error on $Path"
}
}

$Paths = @(
    'C:\src\t'
    ,'C:\sr|c\t'
)
foreach ($Path in $Paths) { Write-Host "calling for $Path"; IsPathValid -Path $Path }

On Windows PowerShell 5.1, an invalid path given to Test-Path produces an exception.
PS C:\src\t> $PSVersionTable.PSVersion.ToString()
5.1.19041.1320
PS C:\src\t> .\IsPathValid.ps1
calling for C:\src\t
path C:\src\t exists
calling for C:\sr|c\t
caught error on C:\sr|c\t
PS C:\src\t>

However, on PowerShell Core 7.2, an exception is not thrown.
PS C:\src\t> $PSVersionTable.PSVersion.ToString()
7.2.0
PS C:\src\t> .\IsPathValid.ps1
calling for C:\src\t
path C:\src\t exists
calling for C:\sr|c\t
path C:\sr|c\t does not exist
PS C:\src\t>

Expected behavior
PowerShell 7.2 should throw an exception when an invalid path is used with `Test-Path`.

Actual behavior
PowerShell 7.2 does not throw an exception when an invalid path is used with `Test-Path`.

Error details
No response
Environment data
PS C:\src\t> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.0
PSEdition                      Core
GitCommitId                    7.2.0
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

It is by-design. For all Test-* cmdlets a right design is to return true or false. We discussed this already.

It is by-design. For all Test-* cmdlets a right design is to return true or false. We discussed this already.

I trust this was rightly categorized as a breaking change.
Is there anything available that would test the validity of a path and not just the presence or absence of an item?

Is there anything available that would test the validity of a path and not just the presence or absence of an item?

PowerShell has a code to try the check but it is a fundamental problem since only (file) system driver know whether the path valid or no.
See Test-Path -IsValid.

Is there anything available that would test the validity of a path and not just the presence or absence of an item?

PowerShell has a code to try the check but it is a fundamental problem since only (file) system driver know whether the path valid or no. See Test-Path -IsValid.

@iSazonov, -IsValid is a good suggestion. It appears to return $true for items that do not exist, but for which there is a valid path. Closing.

Just a minute...
PS C:\src\t> Test-Path -Path 'C:\sr|c\t' -IsValid
True

Only reliable way to check a path validity is to try to create the path.

This is a confusing determination. Is it by-design that the Test-Path call using the -IsValid parameter will not provide an accurate result? It returns true in all cases. The call using IsValid does not attempt to validate the path. What is the point of the IsValid parameter and why are we accepting its useless existence?

It is by-design. For all Test-* cmdlets a right design is to return true or false. We discussed this already.

If you would link to the discussion, we could inform ourselves.

Only reliable way to check a path validity is to try to create the path.

I still don't understand why PowerShell 5 is able to correctly return False on Test-Path -IsValid "C:\invalid?path" and PowerShell 7 is not.


Articles with "/" break

Going to articles such as "F/A-18 Hornet" would instead lead to the article "F" due to the "/"

Deployed a fix, should be out in a few minutes. Can you check that everything works on your side?


Source app environment variables

In our fork, we're playing with allowing the deployment environment call out which procs to execute. We need the app env to do so and thought perhaps others might as well.

I think the latest commits handle this. If not please re-open and I'll take a look.

Negative. This PR sources the app env prior to the generation of the supervisord config. I'll open a new PR with the complete feature and better explanation.

see #22


Apply for membership

Hi there, I'd like to be a member of oam community.
We are using Kubevela and have contributed two PRs.
Hope to become a Member and continue to contribute.
Thank you.

Yes, you're qualified. Thanks for your contributions. invited.


Show flagged variants in side panel by filter categories

Also, pathogenic variants should be exclusive of other categories so that variants aren't duplicated in list.


found no layout file

whe i run hugo server --config hugo.toml i get the following warning and the website does not display. Thanks
Building sites … WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "section": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "home": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "taxonomyTerm": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2024/05/10 17:29:06 found no layout file for "HTML" for kind "taxonomyTerm": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
               | EN

-------------------+-----
Pages            |  4
Paginator pages  |  0
Non-page files   |  0
Static files     |  6
Processed images |  0
Aliases          |  0
Sitemaps         |  1
Cleaned          |  0
Built in 24 ms
Watching for changes in /home/alessandro/Scrivania/work/personal/quint-demo/{archetypes,content,static}
Watching for config changes in /home/alessandro/Scrivania/work/personal/quint-demo/hugo.toml
Environment: "development"
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)
Press Ctrl+C to sto

Hello,
This is happening because git clone doesn't fill the theme submodule by default. Instead, use:
git clone --recurse-submodules -j8 https://github.com/victoriadrake/quint-demo.git

I've updated the README to reflect this. Thank you for letting me know!


disable prev/next if it is on first/last page

disable prev/next button if it is already on first/last page.
Just a one line tweaking.
as discussed in issue #103

@aguegu I noticed you just +1'd the version, could you please also tag that commit?
The version should be tagged when the composer.json file is updated.
Just run:
git tab v0.0.2
git push --tag

I can only tag on my fork. And it is already done. That is why you can see it. I am afraid that I can tag on this origin repo.

I can only tag on my fork. And it is already done. That is why you can see it. I am afraid that I can tag on this origin repo.

noted, apologies @aguegu...


Add a .gitattributes file with eol=lf

Using eol=lf would ensure all line endings are LF on Windows too. While it would be possible to use CR LF on Windows and autoconvert to LF on commit, there are two places that will break with that now:

Utilities like code policy check will detect and reject the CR LF.
If you distribute with sources containing CR characters, they end up in the tar.xz making a dist package created from Windows and Linux look different on unpack. It's best if the dist is always the same, i.e. LF line endings.

Something like this:

https://github.com/svaarala/duktape/compare/add-gitattributes-lf-ending

Now in master.


Package command

PhLImagePackageCliCommandTest>>#testCreateLaunchScriptShouldSucceed is not working. PhLImagePackageCliCommand>>#location returns a NotFound exception.
There are also tests missing for different combinations of options (zip or not zip, missing arg, etc).


gateway-api: add timeouts and retries support

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Given that Istio plans to make Gateway API the default API for traffic management in the future, there are several missing Istio features that need to be supported in the Gateway API implementation. Currently, the only way to support them is by providing Istio implementation-specific extensions to Gateway API.
Timeouts and retries are two examples, so we can start by supporting them with a new Istio ExtensionRef kind something like this:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: reviews
spec:
  parentRefs:
  - kind: Service
    name: reviews
    port: 9080
  rules:
  - filters:
    - type: ExtensionRef
      extensionRef:
        group: networking.istio.io/v1beta1
        kind: K8sRouteExtension
        name: reviews
    backendRefs:
    - name: reviews-v1
      port: 9080
---
apiVersion: networking.istio.io/v1beta1
kind: K8sRouteExtension
metadata:
  name: reviews
spec:
  timeout: 10s
  retries:
    attempts: 3
    perTryTimeout: 2s
    retryOn: connect-failure,refused-stream,503

Describe alternatives you've considered
Work with the kubernetes.sigs/gateway-api community to add first class support for these features, although that would probably be better as a followup, after we've successfully implemented them as extensions first.
Affected product area (please put an X in all that apply)
[ ] Ambient
[x] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

I think upstream is actively working on this for the next release already

This is all I could fine about upstream timeout work: https://gateway-api.sigs.k8s.io/geps/gep-1742/
There's some discussion or retry in the the PolicyAttachement doc, which has me wondering whether PolicyAttachment (vs. ExtensionRef) is the right way to do these things.

Yeah, I think Nick is working on it, but he could certainly use some help

More upstream related info: https://github.com/kubernetes-sigs/gateway-api/issues/1731

Proceeding on 2 tracks:

Upstream discussion started here: https://github.com/kubernetes-sigs/gateway-api/pull/1997
Start to document when and how to use Istio config together with Gateway API config

Related discussion: https://github.com/istio/api/pull/2770

This would be a fantastic addition

Looks like the upstream https://github.com/kubernetes-sigs/gateway-api/pull/1997 is now implementable; I too am excited to see this addition.
gep-1742

We also desperately need this feature. For us, it is not viable to have default retries on 503, which is the standard configuration in istio 1.20. /reopen

And you need this for gateway api specifically? Virtual service has retry support; we're also changing the default retries in upcoming versions

defaultHttpRetryPolicy in https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/ is probably what you want


Fixed formatting and removed a comment that broke policheck

@pranavkm

Hi @ajaybhargavb, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

cc @Eilon

:shipit: once @Eilon's happy

b05f8771ae4f6fcc4e3a6fded04046eedfb59e12


Change expose service interface in Application

Description
This PR changes the interface for the expose service in the Application Pattern
Example of an Application Pattern
name: ApplicationPattern
services:
  app:
    type: Application
    namespace: test
    settings:
      replicas: 1
      advanced:
        create_service: false
      containers:
        - name: svc-demo
          image: utkarsh23/meshy:v5
          ports:
            - name: http
              containerPort: 8080

Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #4428 (f4f30d3) into master (cbf3dc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4428   +/-   ##
=======================================
  Coverage   31.85%   31.85%
=======================================
  Files          59       59
  Lines        5063     5063
=======================================
  Hits         1613     1613
  Misses       2989     2989
  Partials      461      461

Flag
Coverage Δ

e2etests
∅ <ø> (?)

gointegrationtests
10.17% <ø> (ø)

integrationtests
∅ <ø> (?)

unittests
24.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f767b...f4f30d3. Read the comment docs.


Build failing with error: malformed HTML

What happened?
/home/runner/work/pulumi-docker/pulumi-docker/sdk/java/src/main/java/com/pulumi/docker/Image.java:290: error: malformed HTML
     * The manifest digest of an image pushed to a registry, of the format repository{@literal @}<algorithm>:<hash>, e.g. `username/demo-image{@literal @}sha256:a6ae6dd8d39c5bb02320e41abf00cd4cb35905fec540e37d306c878be8d38bd3`.
                                                                                ^

Example
This was discovered when testing pulumi-terraform-bridge v3.89.0-candidate on docker:
https://github.com/pulumi/pulumi-docker/actions/runs/10307662375/job/28533381889
I have confirmed that this issue is not present on 0.12.0.
Output of pulumi about
NA
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@lunaris, possibly due to https://github.com/pulumi/pulumi-java/pull/1397?


Drone Detection

💥 Proposal
Detect drones from input image, video or real-time feed.
Assign this issue to me under GSSOC'23

@shraddha761 - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!
Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.


LowerThumb moves UpperThumb

Hi, I'm using this library to create a RangeSlider but I have a problem. When I move the lower thumb and it reaches the position of upper thumb instead of stop the movement, the lower thumb pushes the upper thumb (see the attached video). I think this behavior is not natural on app development. Is there a way to fix it?
https://user-images.githubusercontent.com/13442110/143972064-c740edbd-b02e-45e9-a150-20633b3f7b85.mov

Hi, you have to disable .forceAdjacentValue
Here is an example
RangeSlider(range: $range2)
    .rangeSliderStyle(
        HorizontalRangeSliderStyle(
            track:
                HorizontalRangeTrack(
                    view: Capsule().foregroundColor(.purple)
                )
                .background(Capsule().foregroundColor(Color.purple.opacity(0.25)))
                .frame(height: 8),
            lowerThumb: Circle().foregroundColor(.purple),
            upperThumb: Circle().foregroundColor(.purple),
            lowerThumbSize: CGSize(width: 32, height: 32),
            upperThumbSize: CGSize(width: 32, height: 32),
            options: [] // instead of .forceAdjacentValue
        )
    )


Feature request: Implement ok boolean response field

I'm not sure, but I can't find a way to produce ok boolean value in response object. https://developer.mozilla.org/en-US/docs/Web/API/Response/ok

ok is set automatically whenever you send a response with a status from 200-299:

The ok read-only property of the Response interface contains a Boolean stating whether the response was successful (status in the range 200-299) or not.

I still do not get it, here are couple of examples with latest 12.0.2

response for status 200

{
      [Symbol(realm)]: { settingsObject: {} },
      [Symbol(state)]: {
        aborted: false,
        rangeRequested: false,
        timingAllowPassed: false,
        requestIncludesCredentials: false,
        type: 'default',
        status: 200,
        timingInfo: null,
        cacheState: '',
        statusText: 'OK',
        headersList: HeadersList {
          cookies: null,
          [Symbol(headers map)]: [Map],
          [Symbol(headers map sorted)]: null
        },
        urlList: [],
        body: {
          stream: undefined,
          source: '{"body":"Some invalid json","statusText":"DDDDD"}',
          length: 49
        }
      },
      [Symbol(headers)]: HeadersList {
        cookies: null,
        [Symbol(headers map)]: Map(2) { 'content-length' => [Object], 'content-type' => [Object] },
        [Symbol(headers map sorted)]: null
      }
    }

response for status 550

{
      [Symbol(realm)]: { settingsObject: {} },
      [Symbol(state)]: {
        aborted: false,
        rangeRequested: false,
        timingAllowPassed: false,
        requestIncludesCredentials: false,
        type: 'default',
        status: 550,
        timingInfo: null,
        cacheState: '',
        statusText: '',
        headersList: HeadersList {
          cookies: null,
          [Symbol(headers map)]: [Map],
          [Symbol(headers map sorted)]: null
        },
        urlList: []
      },
      [Symbol(headers)]: HeadersList {
        cookies: null,
        [Symbol(headers map)]: Map(1) { 'content-length' => [Object] },
        [Symbol(headers map sorted)]: null
      }
    }

I do not see any ok: true/false.
In fact I need to test code like this:
	const response: Response = await fetch(url, requestInit);
	if (!response.ok) {
		console.log(response.statusText);
	}

Can you try doing console.log("response.ok", response.ok)
It may be that the property is not enumerable, so is not picked up by console.log when logging the entire object

It does, but it uses the native fetch classes to do so, so you should receive a genuine Response, and the ok property should always exist on it.
I'm happy to investigate further, but I'll need you to create a repo with a reduced test case in it so I can reproduce locally

Thank you for clarification, and great project! I'll try to find out myself and will back here if find something interesting.

Closing due to inactivity. Happy to open and look into it if you can provide a reduced test case repo @Elmaranin


THRIFT-4809: Implement episodic compilation for js code generation

Implement episodic compilation for js code generation
Two new options are:
thrift_package_output_directory: If set, the generator will create an episode file thrift.js.episode that will contain the import paths of the generated modules. thrift_package_output_directory will be a prefix for the import path. This episode file then should be placed in the root of the node_module.
imports: The : separated paths of node_modules to import from. The node_module must have thrift.js.episode file in the module root. This option is mutually exclusive with -recurse option.

Hi @jeking3,
Can you review this PR?
I noticed that there are failures in travis but they are not related to me. My test was run and it passed.

Rebase on master as I fixed the xenial issue.

Hi @jeking3, there seems to be other failures

Something changed in haskell land, or hackage is down (again).  I'll look at it when I can..

Ping @jeking3

Yeah, haskell is still busted, even on other PRs.  I haven't had time to look yet.

hi @jeking3 - any hope this PR will be merged?

Haskell is still busted and I'm not qualified to review more complex JavaScript PRs... I don't know the language other than casual use.

@jeking3 - can you please suggest someone to help get this reviewed (btw, I work with @mustafa-cosar and we (myself and @bgedik) have (internally) reviewed and tested this.

Hi @jeking3
I rebased on master

@jeking3 ping

I kicked the failing job which had some java-cpp cross test timeouts.

The travis build is green, but appveyor failed at the start. Will you kick another build or is travis enough?
Thanks


ProvideNgIconLoader doesnt work with ChangeDetection.OnPush

With the following configuration
  changeDetection: ChangeDetectionStrategy.OnPush,
  viewProviders: [
    provideNgIconLoader(name => {
      const http = inject(HttpClient);
      return http.get(`/assets/${name}.svg`, { responseType: 'text' });
    })
  ]

The image doesn't get injected into the DOM element, guessing it needs a markForCheck somewhere. Removing the changeDetection (back to default) solves this.

Thank you for the bug report. This has now been resolved:
https://stackblitz.com/edit/stackblitz-starters-vy6bfb?file=src%2Fmain.ts
Check out the 25.6.1 release for the fix.

Great stuff - thanks.


create backgrounds/ directory in update_theme.py if dir does not exist

fixes #39
This is a problem I have overlooked, sorry
I think having an empty directory there in the repo would be better, but afaik this is not possible with git

A different way to fix this would be to include a dummy file in minegrub/backgrounds/ (file name starting with an underscore!) to be able to add this directory to the repo. I am honestly not sure which of the two is the better solution

I thought about it a bit more and I think the best solution is the following:
Change update_theme.py to ignore files that start with a dot (choosing the underscore was a stupid decision of me anyway). Then add the backgrounds directory with a hidden dummy file in it.
I can implement this later today

Fixed with #41


[FEAT]: allow filters in JS

Description
To better support templates with custom filters, allow filters to be written in JS and be placed inside the SDK templates.
Ideally it shall also be possible to overwrite the built-in filters and or to call these filters from the overwritten filters. Also these filters would need to have access to a larger list of helper functions, to ensure custom filters do same string handling (e.g. title case, camel case) then the go version.
Additional Information
We use already Goja (js runtime) for the simulation. We can use same js runtime to parse js filters and expose these functions.
I would expect this would be some weeks work, to ensure good error handling, documentation, elegant way to implement and overwrite filters, ....

Any filtering in plugins will be difficult. As the filters receive a pointer to an internal data structure (e.g. model.Schema, model.TypedNode). These are only available inside the same shared memory.
Any external plugin system (e.g. go-plugin) will not work, as we can not so easily serialise the data and allow lookups on the plugin side.
Any conversion (e.g. JS might be difficult at least). JS will require to use the same string conversion methods as otherwise we will see subtle behaviour changes, e.g. snake case behaves different from library to library.
Also this will make the cli more slow and easier to fail, due to inconsistent template code.


Upgrade django-solo require

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         101    101
  Branches        3      3
=====================================
  Hits          101    101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a86e2f...4720215. Read the comment docs.

Closes #2

I meant "closes #1"!


Add validation structure

Instead of adding a large, hard to maintain method for validation, I thought it would be best if multiple classes implemented each individual rule in the language.
The intention is for each piece of https://facebook.github.io/graphql/#sec-Language.Document.Operations to be represented by an individual class.

I'm traveling this weekend, will take a look on Monday.  Relates to #10

This has now been superseded by https://github.com/graphql-dotnet/graphql-dotnet/pull/90 - thanks for your initial work @bryanerayner !


feat: add commit_transaction to postgres.to_sql

Feature or Bugfix

Feature

Detail

add commit_transaction to postgres.to_sql

Relates

closes #2790

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 0b5f37f0e2367020983cc70c53a3368f3b768982
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 0b5f37f0e2367020983cc70c53a3368f3b768982
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 0b5f37f0e2367020983cc70c53a3368f3b768982
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: cb9841e308764253bf439d24fe2f0a8b9c964979
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: cb9841e308764253bf439d24fe2f0a8b9c964979
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Implementation design on how to work with existing work items (onboarding) and new work item types

Currently the Release Planner and the Scheduler tool uses the ADO workitem Onboarding to save information, and make decisions. Our PM team also uses the existing WI to track and make progress on their work.
With the new design of having different workitems, how shoul we implement it withough affecting the existing flow?

We can use a tag in addition to release planner test to mark any work item types are created by release planner . For e.g. package work item etc and these work items can be ignored by Cala or anyone who uses work items other than onboarding work item even after we roll this feature to production. This will help us continue creating all types of work items at all stages. We need to identify what work item needs to be created by which stage of the release plan.
//cc: @maririos @JonathanCrd

You mean add a label/tag to the WI, like "Release Planner App Test" ?

Where do you want to add the tag? In the Work Item or the Database?

In the work Item


Continued: Fix port aliases (Seems you can't autosuggest an element of type "number")

Also
apply to src too.
remove is_numeric check
remove min/max (not valid on text fields; does not work)
add pattern in place of min/max

The is_numeric may be a part of XSS protection. Should probably check is_portoralias instead to be safe. Will leave for @sbeaver-netgate to review

The is_numeric was added as part of my original commit ( PR #2347 ).  It's existence will prohibit the text field from being populated with a non numeric existing value such as an alias name.  Don't think that is the desired behavior.  But sure no problem letting Steve check it to be sure.

IMO it would be nice if we have a special type of form_input for "port or alias" fields, but @sbeaver-netgate is the best person to say

The PR is acceptable as submitted since XSS protection is provided in the FORM_* framework (pfForm?) , but I will check the possibility of a special input class. We would need to do the same for IP addresses (and accommodate v4/v6 addresses) so it would be a rather significant change.
Another solution would be to provide an allowAlias() method that could be applied to Form_Input and Form_IpAddress classes.
Care has to be taken because there are three levels of validation: What can you type into an element, what will the browser allow you to submit, what do you do with the submitted data. Browsers have slight differences in how the first two are handled.


Uri (TryCreate, IsWellFormedUriString)

Validating URL Input

I'm trying to validate a URL input using a predefined methods (TryCreate, IsWellFormedUriString)
Please find the below code snippet

What is the problem @Despa22 ?
cc: @MihaZupan

Both comma and colon are legal characters in a URL, so as strange as it looks, that URL is a valid URL.
For example, the oldest capture of www.microsoft.com by archive.org is https://web.archive.org/web/19961020014044/http://www.microsoft.com:80/
web.archive.org is one of the few places I've seen where a URL is used as part of a bigger URL, so your test case is probably not locating a valid target... but it's syntactically valid.

Thanks @bartonjs for your reply
Do you have any suggestions that I can apply here?

I think you need not to reject this kind of URL because how you going to deal with URL that have commas like in google map location?

Closing this as by-design.


Admin  unauthorized_client after deploy to azure

Hi, I publish both site to azure. I created database and run seed. I can login to sts, but when i try go to admin I get the error unauthorized_client. When i remove autorize atribute from HomeController  i see UI. I changed URL in applicationSettings. json, lanuchSettings.json, and in AdminConfiguration object but does not help me.

Hi,
can you check logs, please? You can check log file or in DB.
Thanks.

Logs.xlsx

Hi, please do you have any idea? I try it on localhost and its work fine, but when is application in azure attribute Autorization does not work. When i remove Autorization atribute, admin works fine. Thanks.

I can not find any issue in this log.
Please try check - if you have correctly set in admin ui client props:
RedirectUri
ClientSecret

try more explore log, this must generates better error message.

Any update on this issue?
Thanks

I am closing now, if you have any questions, please let me know.
Thanks.

I too am getting this error and I don't see the Serilog Log table.

I have the same error


not able to confirm setup intent created for my connected account

I’m working with a Stripe account (platformAccount) and using Stripe Connect to set up a connected account. I’m trying to save a card for a customer on the connected account by creating a SetupIntent for that account. I then pass the client secret of this SetupIntent to the frontend, where I use confirmCardSetup(). However, I’m encountering an error with the following details:
Error Documentation: https://stripe.com/docs/error-codes/resource-missing
Message: "No such setupintent: 'seti_1PmBVYRtBFCjzLBfZ*******'"
Param: "intent"
Type: "invalid_request_error"
I’ve verified that the SetupIntent is correctly created for the connected account and that the client secret is correctly passed to the frontend.
Could you suggest whether this is an implementation issue or if it might be related to Stripe? Any advice or potential workarounds would be appreciated.

I'm encountering the same issue. Any additional context other than just "closed"?

Hello, I'm having the same issue, do you found any solution?

same issue here for payment intend for stripe connect account


OPSEXP-1699 Fix compatibility issue with Ansible 2.13

OPSEXP-1699

Good catch! Did you check locally 2.13 works like that?

there is another branch for that but the build is still not green
I would merge this anyway since it seems improving