[cinder-csi-plugin] IgnoreVolumeAZ does not work for volumes with Topology

Is this a BUG REPORT or FEATURE REQUEST?: bug
/kind bug
What happened:  I am testing this new topology thing in two different openstack. In one openstack I have setup where I have 3 compute azs (zone-1, zone-2, zone-3) and 1 volume az (nova). I should be able to use IgnorevolumeAZ option (https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/cloudprovider/providers/openstack/openstack.go#L152) somehow. However, when topology is enabled using featureflag (in next version it will be enabled for ALL so this will break things for everybody who is using ignorevolumeaz) the nova zone for volumes cannot be used.
What you expected to happen: I expect that I could still use csi provider after topology feature.
How to reproduce it:

OpenStack region with zone names that does not match between compute and volume, you have that if you have been using ignorevolumeaz option.
enable topology featureflag for provisioner (and use like 2.0.3 version)
use storageclass

allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    storageclass.beta.kubernetes.io/is-default-class: "true"
  name: csi-sc-cinderplugin
parameters:
  availability: nova
  type: solidfire
provisioner: cinder.csi.openstack.org
reclaimPolicy: Delete
volumeBindingMode: Immediate

try to create volume

I have loglevel 4 in cinder-csi-plugin and the result is this:
I1030 15:05:39.988102       1 controllerserver.go:44] CreateVolume: called with args {Name:pvc-6084d54f-c2d9-43af-b7af-2ac62f8bd33d CapacityRange:required_bytes:17179869184  VolumeCapabilities:[mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER > ] Parameters:map[availability:nova type:solidfire] Secrets:map[] VolumeContentSource:<nil> AccessibilityRequirements:requisite:<segments:<key:"topology.cinder.csi.openstack.org/zone" value:"zone-2" > > requisite:<segments:<key:"topology.cinder.csi.openstack.org/zone" value:"zone-3" > > requisite:<segments:<key:"topology.cinder.csi.openstack.org/zone" value:"zone-1" > > preferred:<segments:<key:"topology.cinder.csi.openstack.org/zone" value:"zone-1" > > preferred:<segments:<key:"topology.cinder.csi.openstack.org/zone" value:"zone-2" > > preferred:<segments:<key:"topology.cinder.csi.openstack.org/zone" value:"zone-3" > >  XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}

The problem is here https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/csi/cinder/controllerserver.go#L68-L76 because, now the topologies has even some data. The availability parameter is just ignored. It should not be ignored if we have ignoreaz use-case.

https://github.com/zetaab/cloud-provider-openstack/commit/46cb0d6f5238d025c325089d31f30fc9da1137bd with this, its possible to provision volume correctly to zone called nova. However, it will add nodeaffinity things to pv -> provisioning does not work because there is no nodes in zone called nova. Instead zone-1, zone-2 and zone-3
apiVersion: v1
kind: PersistentVolume
metadata:
  annotations:
    pv.kubernetes.io/provisioned-by: cinder.csi.openstack.org
  name: pvc-41cb91f0-944a-48d8-99b6-fdb482857ae7
spec:
  accessModes:
  - ReadWriteOnce
  capacity:
    storage: 16Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: prometheus-k8s-db-prometheus-k8s-1
    namespace: monitoring
    resourceVersion: "2701"
    uid: 41cb91f0-944a-48d8-99b6-fdb482857ae7
  csi:
    driver: cinder.csi.openstack.org
    fsType: ext4
    volumeAttributes:
      storage.kubernetes.io/csiProvisionerIdentity:<PHONE_NUMBER>367-8081-cinder.csi.openstack.org
    volumeHandle: 870a698a-1cab-47e1-a2c0-dee9239699b2
  nodeAffinity:
    required:
      nodeSelectorTerms:
      - matchExpressions:
        - key: topology.cinder.csi.openstack.org/zone
          operator: In
          values:
          - nova
  persistentVolumeReclaimPolicy: Delete
  storageClassName: csi-sc-cinderplugin
  volumeMode: Filesystem

If I understand this correctly, this nodeAffinity thing is not created by csi-cinder?

/kind bug

Like discussed in external-provisioner issue: Maybe the best way to handle this is that we disable topology support from cinder-csi-plugin if IgnorevolumeAZ is true

seems something has been addressed previous issue https://bugzilla.redhat.com/show_bug.cgi?id=1500776
and I think it make sense that we disable topology support from cinder-csi-plugin if IgnorevolumeAZ is true

@zetaab I guess we have two problems here when node and volume AZ are diff

'availability' is ignored when Topology = true, which shouldn't be when node and volume AZ are different.
nodeAffinity is getting populated in PV with volumeAZ which shouldnt be

yes, we can make use of ignore-volume-az option , which is not currently supported by cinder-csi.
Let me check if I can get this fixed with minimal changes.
Note: IgnoreVolumeAZ is never supported for cinder-csi , its supported for intree provisioner , so marking it as feature instead of bug,

/kind feature


Incomplete - Do not go live.

Codecov Report

Merging #163 (453c0d9) into dev (a88d420) will increase coverage by 8.37%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev     #163      +/-   ##
==========================================
+ Coverage   86.38%   94.75%   +8.37%
==========================================
  Files          26       20       -6
  Lines        1153      801     -352
  Branches      269      215      -54
==========================================
- Hits          996      759     -237
+ Misses        142       37     -105
+ Partials       15        5      -10

Impacted Files
Coverage Δ

api/__init__.py
86.00% <100.00%> (-4.55%)
:arrow_down:

api/models/eplant2.py
100.00% <100.00%> (ø)

api/models/eplant_poplar.py
100.00% <100.00%> (ø)

api/models/eplant_rice.py
100.00% <100.00%> (ø)

api/models/eplant_soybean.py
100.00% <100.00%> (ø)

api/models/eplant_tomato.py
100.00% <100.00%> (ø)

api/models/rice_interactions.py
100.00% <100.00%> (ø)

api/models/single_cell.py
100.00% <100.00%> (ø)

api/models/tomato_sequence.py
100.00% <100.00%> (ø)

api/resources/gene_information.py
100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Using Lambda Layer to implement bi-directional rnn

I am currently trying to implement various rnn structures, I followed the code in the examples,"imdb_bidirectional_lstm.py", however, I want to do sequence labeling, which not only needs the last step, but also needs the complete sequence.
So here's the issue, I want the forward lstm and the backward lstm to be strictly aligned in the same order of the input sequence. But if I only set the go_backwards=True, it will return a backward sequence, which is not the same order as the input. Since the code in seya and other repos haven't updated for a long time, and seem difficult to apply, I added a Lambda Layer upon the backward lstm. Will it work as I expected? Thanks!
106     model.add_node(LSTM(200,return_sequences=True),name='lstm',input='dropou    t')
107     model.add_node(LSTM(200,return_sequences=True,go_backwards=True),name='l    stm2',input='dropout')
108     model.add_node(Lambda(lambda x:x[:,::-1,:]),name='reverse',input='lstm2'    )
109     model.add_node(Dropout(0.5),name='dropout2',inputs=['lstm','reverse'],me    rge_mode='concat')
110     model.add_node(TimeDistributedDense(nb_label),name='tdd',input='dropout2    ')

Sorry for the delay updating Seya.
This Lambda layer will indeed reverse you sequences again, which is what you need to align forward and backward passes.

probably right.
but be careful when you use masked input.
AFAIK, current version of Keras has some issues in using backward RNN with masked input.

@ymcui is right! To cope with that, since you are in a graph, you should use two regular forward LSTMs and revert the input and mask as a second input. In that case your new Lambda layer will be useful as well.

@EderSantana When it comes to bidirectional RNN, do you have any ideas on how to realize a shared Embedding layer with masked input?
I thought it would be easy by just using the add_shared_node, and put Embedding layer in it.
But I have noticed that the add_shared_node will not produce an masked output.
So I have to set two Embedding layers, and set the second one to have weights=graph.nodes['first_embedding'].W and trainable=False, am I right?

The idea would be to have two separate embedding layers and make sure they point to the same symbolic Tensor. Or, much better, you should create your own embedding layer that outputs two looked-up series: one with left padding and the second with right padding and reversed.
@farizrahman4u wrote the Siamese layers, maybe he has an opinion on that as well. Also, if that doesn't exist yet. Open up an issue called "Embedding layers for Bidirectional RNN" and post your solution there. This should be a useful future reference for other users.

@EderSantana OK, i'll post it right away.


[dpg]: lro protocol method sample should use WaitUntil.Started

Description
Per comment here, for examples of LRO, we should pass in WaitUntil.Completed, and not invoke WaitForCompletion. This is a revert change of #2978

@archerzz , could you describe the difference between the 2 approaches?    cc @ArcturusZhang

@archerzz , could you describe the difference between the 2 approaches? cc @ArcturusZhang

WaitUntil.Started: the method returns instantly after the 1st request/response. Users have to poll/update the status of the long running operation by themselves (e.g. Operation.UpdateStatus() or Operation.WaitForCompletion()).
WaitUntil.Completed: the method will send the request, and poll the status of the operation until it succeeds or fails. Users can write codes to directly get the response right after the method.


cross compiling error when build the Arm NN for tensorflow lite

I follow the steps in https://developer.arm.com/solutions/machine-learning-on-arm/developer-material/how-to-guides/cross-compiling-arm-nn-for-the-raspberry-pi-and-tensorflow/single-page to cross compile the Arm NN.
But I got the following error
[ 49%] Linking CXX shared library libarmnn.so
/home/ivslab/armnn-zcu104/ComputeLibrary/build/libarm_compute_core-static.a: error adding symbols: File format not recognized
collect2: error: ld returned 1 exit status
CMakeFiles/armnn.dir/build.make:3577: recipe for target 'libarmnn.so.20.02' failed
make[2]: *** [libarmnn.so.20.02] Error 1
CMakeFiles/Makefile2:118: recipe for target 'CMakeFiles/armnn.dir/all' failed
make[1]: *** [CMakeFiles/armnn.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
And the following is my cmake
cmake .. -DCMAKE_LINKER=/usr/bin/arm-linux-gnueabihf-ld -DCMAKE_C_COMPILER=/usr/bin/arm-linux-gnueabihf-gcc -DCMAKE_CXX_COMPILER=/usr/bin/arm-linux-gnueabihf-g++ -DCMAKE_C_COMPILER_FLAGS=-fPIC -DCMAKE_CXX_FLAGS=-mfpu=neon -DARMCOMPUTE_ROOT=$BASEDIR/ComputeLibrary -DARMCOMPUTE_BUILD_DIR=$BASEDIR/ComputeLibrary/build -DBOOST_ROOT=$BASEDIR/boost -DTF_GENERATED_SOURCES=$BASEDIR/tensorflow-protobuf -DBUILD_TF_LITE_PARSER=1 -DPROTOBUF_ROOT=$BASEDIR/protobuf-arm -DARMCOMPUTENEON=1 -DARMNNREF=1 -DFLATBUFFERS_ROOT=$BASEDIR/flatbuffers -DFLATBUFFERS_LIBRARY=$BASEDIR/flatbuffers/libflatbuffers.a -DTF_LITE_GENERATED_PATH=$BASEDIR/tensorflow/tensorflow/lite/schema
Is the command for cmake incorrect for tensorflow lite?

Hi @ivs-pychen
thinking about it a bit more I think you may have better luck with the armnn crossbuild guide at https://github.com/ARM-software/armnn/blob/master/BuildGuideCrossCompilation.md
The raspberry pi guide mentions building compute library for an earlier architecture (armv7a) but your device has a more recent one so you should be using something more like (arm64-v8a)

Hi @ivs-pychen ,
Were you able to cross compile successfully?
Thanks

I didn't use cross compile. I directly build Arm NN on my device.


Feature: localise for eu and ca fr

Summary of Changes

Show the correct money format based on locale
Show correct currency based on configured locale
Add translations for fr-CA, fr-FR, it-IT and es-ES
Allow valid checkout urls for clearpay.com
Add pay in 3 (and update instalment tests to match)
Add V1 option to cart for testing purposes

Submission Checklist

[x] Tests are included.
[x] Documentation is changed or added.

@ScottAntonacAP do you have any screenshots of the new features proposed here? Maybe a before & after to highlight the changes?


"No attribute was found for @{Iano Legra|name}"

Created a new character sheet but when trying to roll something, every time it would produce the titular error in the chat box. The roll works fine itself, but the name section of the template shows as "Iano Legra|name". I've fixed the issue by manually adding 'name' into the Abilities & Attributes section, so it functions fine now. Just thought you'd like to know that there's a bug in the sheet.
Here's what it looks like:

Thanks for the bug report! This was introduced in v2.4.4 for new characters and is fixed in 2.4.5 next week.


Object pinning

Scenario: Assume you draw out a large arbitrary number of boxes and connections. After initial keyboard bashing you clean up the automatically rendered output by dragging them into a better layout which makes more sense to you as a user than the computer. Except after 2 hours of work you realize you need to add one last shape and connection. Doing so causes the push strength to recalculate and all your hard work organizing disappear. You have to start all over.
Ideal solution: a toggle that freezes the existing shapes in place, new shapes would at best be placed and pushed away by previous shapes without the new shape pushing on those older "Frozen" shapes.

I agree, persisting user-augmented layouts could be hugely beneficial, and the notion of pinning could work well.
I need to do some tests to make sure it doesn't negatively impact the layout engine. In other words, if we pin certain boxes, can we still reflow the layout intelligently around those pinned boxes.
My other concern is that, although we can store the pinning in-memory (like while the user is using the site), will it be confusing for users if they  refresh (or open another tab) and their graph loses the layout. Which then leads me to think... should we search for a solution to pinning via the syntax so that we can persist it :\
A lot to think about but I will leave this issue open so everyone can make suggestions.
Thanks for opening this one!

Maybe it would make sense to import/export the pinning in a separate file? This way you would separate the graph definition (the text that the user sees and types) and the properties of the nodes and edges. An explicit import/export would help with refreshes as well.
Perhaps this can also be the solution to #97? The user clicks on a node or an edge. A separate menu shows where you can change color, shape, change text properties (fonts, size etc.).

What if there was just a boolean value in the header to disable auto-regeneration of the layout.
for example:
~~~
layout:
  name: cose
  rankDir: LR
  auto-regen: false
~~~

When set to false any new nodes would be either placed relative to their parent node (ex. Right: 100px, Down: 100px) or in the center of the current view, if no parent exists. When set to true, it acts as it does currently.

@james-powis

Ideal solution: a toggle that freezes the existing shapes in place, new shapes would at best be placed and pushed away by previous shapes without the new shape pushing on those older "Frozen" shapes.

True frozen graphs are now possible. Thanks for suggesting this way back!
https://user-images.githubusercontent.com/159949/172648574-cd3efbf4-2b91-44c0-950e-444a2b6549df.mov


default group not being assigned

I have tried to fix my issue with "/pex set default group  " So I ran /pex set default group lobby lobby and I get in chat "Group "lobby" is no loner default in world 'null'" when I check if there is a default group set for lobby the list is blank. I'm attempting this on Spigot 1.12 with pex 1.12.4

The easy solution: open the permissions.yml file in Notepad ('Notepad++' is better) and make sure only one group has default: 'true' in their options: section as you see in this example.  (The other groups don't need default: 'false' in them.)
The PEX Command is actually /pex set default group <group> <value> (/pex set default group GroupNameHere true.  Then open the permissions.yml file in Notepad anyway to make sure the data is displayed in there correctly.  (heh)

I forgot to mention I'm using SQL, the command worked great. I updated my file fr commands to pex just in case I make mistake and remove default group again. Thanks

On the positive side, "fake" stuff in the file won't have any sort of effect on the server at all— neither positive or negative effects aside from making the file longer —so I'd bet the same is true when using SQL.  PEX may be delayed in finding other information it's looking for in a group, but we're talking about single-digit milliseconds of a delay— and to give you something to compare it to, your brain takes 150 milliseconds to respond to a trigger of any kind, from seeing something, to wanting to say something, to even being surprised by something, so PEX (actually, the computer) is still handling operations for your server extremely fast.
As long as you don't have dozens or hundreds of "fake" things in the file/SQL database, it won't impact the server in a negative way.  (It's just something us neat freaks don't like to see, in which case we'd migrate to file, clean it up, delete the database, and migrate to database again.)
You're welcome. :-)  If you have any other issues, you can still post here after I close this ticket.


Propose renaming GitRepository Kind to SourceRepository

The fact that the source control system can be Git is an implementation detail that I don't believe needs to be in the name of the Kind.
I think more appropriate names for the Kind would be SourceRepository or maybe ManifestRepository which indicate what is contained in the repository as opposed to the source control system used to manage it (which could be a SourceRepository.Spec.Driver field)

I see with https://github.com/fluxcd/kustomize-controller that the source repository doesn't necessarily have to store raw manifests (it can be a repo containing, e.g. Kustomize overlays), so ManifestRepository doesn't work. But I think SourceRepository or simply Repository is better than embedding Git in the name of the Kind.

GitRepository is source kind, another one is HelmRepository, please see the spec.
We do have the concert of a source, but it's just an interface that each kind must implement, see https://github.com/fluxcd/source-controller/blob/master/docs/spec/v1alpha1/common.md#source-interface

Opposed to this as doing it would result in a lot of complexity within the <source> reconciler as it becomes a one-to-many solution, and the Source interface (as Stefan mentioned) already covers working with a 'generic' source.

@hiddeco you are opposed to renaming the Kind to remove "Git", or you are opposed to adding support for non-Git source control systems?

I am not opposed to adding support for non-Git source control systems, but they should have their own kind and reconciler.
(So the former).

ack, understood. makes sense. :)

The technical difference seems to me to be between dispatching on the Kind or dispatching on a field within a single kind. The tooling (kubebuilder) probably helps more with dispatching on the kind of the resource; but that's only dispatch. The rest of the code for each VCS system would still have to go somewhere, so I don't think complexity is really at issue.
I would rather see an argument made in terms of value for users -- less cognitive load, or a superior force multiplier -- for either way of doing things.
One argument for a single kind representing all VCS repositories is that they are fungible, in a way that e.g., a git repo and a Helm chart are not. The kustomize controller ought to be able to use a VCS repository from anywhere, but it can't use a Helm chart, and that delineation is going to line up better with people's intuitions.
If you are using an ObjectReference (or LocalObjectReference) to refer to a resource, the kind is implied by the slot it's used in -- so you'd either have to have a union of {gitSourceRef,hgSourceRef, ...}, everywhere you want to refer to one of those, or somehow enforce names to be unique across all the kinds. That situation is a sign that the abstraction is in the wrong place.

Yes, all good points @squaremo!

The rest of the code for each VCS system would still have to go somewhere, so I don't think complexity is really at issue.

It is not just the complexity of the reconciler I am worried about, but also the fact that you need to invent a generic API good enough to e.g. support advanced revision filtering for every VCS out there. Looking at JFrog's VCS Repositories API, I think this will be harder to understand for a user than a dedicated API that matches the specific-domain of the VCS.

I see with https://github.com/fluxcd/kustomize-controller that the source repository doesn't necessarily have to store raw manifests

I agree that there is no good reason for the kustomization API to be tied to a GitRepository source. I've switched the controller to the Source interface so that future implementation of a source, for example an S3 Bucket, would be easily plugged in.


suggestion

Make a "pinned" camo section where you can select up to 3 or so camos that you are working on such as a primary rifle and a secondary pistol that pin to the top of the page.

If you go to the camouflage page, there's an option to "favourite" camos that will appear at the top @cpjet64

Would it make sense to have a similar section for weapons @carlssonemil? I.e. a favourites section for weapons you're currently working on.
I'd definitely use that.

I see what you are talking about. From my perspective of completionism I want to unlock all unique camos across all weapons now that I have max leveled all weapons. So being able to stay on the weapons page would be a huge plus. Instead of a massive list of everything it would be nice to focus on a section where it only contains the weapons I'm currently working on and as I complete camos for the ones I'm currently working on I can checkmark them right there as well.

A favorite section for weapons as well is definitely a great idea! I'll take a look at it! 😄 👍


Update version to 1.4.0

Update the version to 1.4.0 and release it.

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   84.01%   84.01%
=======================================
  Files          33       33
  Lines        3222     3222
=======================================
  Hits         2707     2707
  Misses        432      432
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7f01a...961dd49. Read the comment docs.


Fix pedigree affected (filled) / unaffected (outline) colouring

Somewhat by luck, the conventional indication was used in dark mode but swapped in light mode.
Status codes are 1=unaffected / 2=affected, so correct the conditional in the code and reverse the dark mode colours in the CSS. With those changes, in both light/dark modes, colAffected approximately matches the person-border colour and colUnaffected approximately matches the background colour (and is used to redraw the interior, producing an outline), as expected. Fixes SET-164.

The current situation, incorrect in light mode:

With this PR, light mode is corrected and the two changes cancel each other out leaving dark mode unchanged:


feature: support for transaction annotations on classes

Ⅰ. Describe what this PR did
support for transaction annotations on classes
Ⅱ. Does this pull request fix one issue?

#2562
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2565 into develop will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2565      +/-   ##
=============================================
- Coverage      51.40%   51.25%   -0.15%
  Complexity      2805     2805
=============================================
  Files            553      553
  Lines          17698    17679      -19
  Branches        2093     2054      -39
=============================================
- Hits            9097     9062      -35
+ Misses          7742     7736       -6
- Partials         859      881      +22

Impacted Files
Coverage Δ
Complexity Δ

...ing/annotation/GlobalTransactionalInterceptor.java
9.58% <0.00%> (ø)
2.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 21 more


How to use C++ in java

How to compile android/jni c + + files, their own so files? Beginner Android my language makes you confused, please understand

How to use Tracking C++ files below in my test project


Advance Where Clause

Summary of problem or feature request
Searching result show all the datas without respect the input when I use Laravel Advance Where Clauses. After applying advance where clause , Search box doesn't work and it shows all the data.
Code snippet of problem

->where(function($query) {
                            $query->where('voucher_details.status', '!=', 'pending');
                        })->orWhere(function($query) {
                            $query->where('voucher_details.shipping_option', 'standard')
                           ->where('voucher_details.shipping_option', 'free');
                        })

Can you please paste your whole DT code? But afaics, these where clause looks fine.

Closing inactive issue.


az bot create fails with site_name referenced before assignment

This is autogenerated. Please review and update as needed.
Describe the bug
Ran az bot create command at Azure CLI 2.0.63. Command failed.
Command Name
az bot create
Errors:
local variable 'site_name' referenced before assignment
Traceback (most recent call last):
Temp\pip-install-68v0_w99\knack\knack\cli.py, ln 206, in invoke
azure\cli\core\commands\__init__.py, ln 523, in execute
azure\cli\core\commands\__init__.py, ln 581, in _run_jobs_serially
azure\cli\core\commands\__init__.py, ln 574, in _run_job
Local\Temp\pip-install-68v0_w99\six\six.py, ln 693, in reraise
azure\cli\core\commands\__init__.py, ln 551, in _run_job
azure\cli\core\commands\__init__.py, ln 289, in __call__
azure-cli-core\azure\cli\core\__init__.py, ln 453, in default_command_handler
azure\cli\command_modules\botservice\custom.py, ln 136, in create
azure\cli\command_modules\botservice\bot_template_deployer.py, ln 153, in create_app
UnboundLocalError: local variable 'site_name' referenced before assignment

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az bot create -n {} -l {} -g {} -k {} --appid {} -p {} -v {} -s {} --lang {} --verbose

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: powershell.exe

azure-cli 2.0.63

Extensions:
interactive 0.4.1

Additional Context

@plzm, this bug was fixed in azure-cli 2.0.64. Please upgrade and try to run the command again.
Please note that there are a number of breaking changes in the 0.2.0 release of az bot. One of which being, that --storage is no longer used when creating v4 bots, and that for v4 bots, you must provide the --echo flag if you wish to have the old v4 echo bot provisioned when calling az bot create -v v4.
To see a full list of the breaking changes, please see the HISTORY.rst.


[staging]librsvg: 2.44.15 -> 2.46.0

Motivation for this change
noticed it was broken when reviewing a few other packages. Bumping it seems to fix the build.
should help with #70056 #69837
this causes a lot of rebuilds, so opening against staging
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @FRidh (curates staging often)

We actually already did this in gnome-3.34 branch https://github.com/NixOS/nixpkgs/pull/68608/commits/2b488ebc1ec5c4fb3a18d401b578798aa0a26a66. Didn't realize this was broken on master, guess rust was updated?
I can merge that to staging now if it's needed. cc @hedning @jtojnar

correct https://github.com/NixOS/nixpkgs/pull/69534

Any problems with sending it to master, as it's broken there so needs to be rebuild anyway? (especially since broken librsvg means broken channels).

@hedning Rust was updated in master, so yes we can merge that commit there :+1:

i just cherry picked the commit

Merged one way or another to master in 02585db25bc4d5d623ce083b41f727c65709ad3f :smile:

well, that's one way to do it. lol


Added some create/update functions

Hello,
I needed to do some AWX API work and stumbled upon your library which was exactly what I needed. However I did need some additional create/update/delete functions, so I have added them to the code. I figured I may as well submit PR for it in case somebody else needs it.
While working on the code, I have messed up formatting so I just used black to reformat everything and bring it back to some kind of coherent state.

Hello, thank you for your contributions. However this repository was abandoned after we discovered that there is a towerlib.
Here is the Docs.

@wiltonsr Thanks for the info, much appreciated!


Inconsistent EditorImportPlugin extensions detection in FileSystem Dock

Godot version
3.x branch at 23bb5883cb0de5455afe8b9d473f0d67d72487b3
System information
Arch Linux
Issue description
Registered EditorImportPlugin extensions are no longer showing up consistently in the FileSystem Dock on subsequent Editor restarts.
Seems to be caused by #52344, which is related to issue #52968.
Steps to reproduce

Open the attached project.
Search for 'tmx' on the FileSystem Dock -- only the file level1.tmx should show up and if it does, move to step 3. If level1.tmx doesn't show up on the search, the issue has been reproduced.
Close the attached project.
Repeat steps 1 through 3 until the issue has been reproduced in step 2. The issue can usually be reproduced within 10 tries or so.

Minimal reproduction project
editor_import_extension_not_showing.zip

CC @TechnoPorg.

Same as https://github.com/godotengine/godot/issues/52968#issuecomment-928051500, I reverted the change in 3.3 and 3.x so this should now only affect master.


Portal 2023 fixed

1.Image scanning report Line chart data aggregation problem solving.
2.The image, risk, and workload detail pages add drag and drop functions and fix hidden problems in drag and drop.
3.Risk scanning report line chart xAxis problem display order adjustment

4.The data in the detail in the risk scanning report detail page is hidden after exceeding the width

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c6b9f71). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage        ?   43.70%
=======================================
  Files           ?       10
  Lines           ?     1167
  Branches        ?        0
=======================================
  Hits            ?      510
  Misses          ?      624
  Partials        ?       33

Flag
Coverage Δ

unittests
43.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Vegetation should be treated as factor in models

https://github.com/kaitlyngaynor/hopland-hunting/blob/ccbc8cd6158f41fb8cc89dfd80926a275d4ac49b/Scripts/06-ssf.Rmd#L151-L153
Currently, vegetation gets scaled along with all of the other raster covariates in this line. However, we should probably pull them out separately and make them a factor (or just make them a factor AFTER scaling? I guess that wouldn't cause any issues, and would be easier?)

This remains true, BUT the moveHMM does not allow for any character covariates, only numeric. We might get around this by using 'area of X within X meters' as a covariate instead of the vegetation type at the point.

Made note to this effect https://github.com/kaitlyngaynor/hopland-hunting/commit/febcbdea6575ef9e1ea93dcc8cfbe68ee37053a9


String interpolation rework proposal

String interpolation is a simple and powerful feature for expressing complex, runtime-created strings, but the current version of the ExpressibleByStringInterpolation protocol has been deprecated since Swift 3. We propose a new design which improves its performance, clarity, and efficiency.

The implementation is in apple/swift#18590. There's currently one project failing with a compiler crash in the source compatibility suite, but it doesn't look like a design flaw. A couple of benchmarks are currently showing regressions, but we're mostly seeing improvements in both speed and size. We have managed to include all of the features we were hoping for, including throwing appendInterpolation methods, so the new design is far more flexible too.
My coauthor @milseman hasn't yet reviewed this draft, but as far as I'm concerned, it's ready to go.
cc @jckarter, @DougGregor

This is in good shape. We're going to schedule the review for Monday, September 10--Tuesday, September 18th.

@brentdax can still tweak the wording and such before Monday, of course


Build failure on Android. Build success on iOS.

Bug description:
Hi react-native-community,

I am unable to build my react-native app on Android but it is working on iOS.
This is the error:

FAILURE: Build failed with an exception.
What went wrong:
Could not determine the dependencies of task ':app:lintVitalStagingrelease'.
Could not resolve all task dependencies for configuration ':app:stagingreleaseRuntimeClasspath'.
Could not resolve project :react-native-webview.
Required by:
project :app
Could not select value from candidates [null, debug, release] using AlternateDisambiguationRule.BuildTypeRule.
java.lang.NullPointerException (no error message)

I have read other bug reports, some suggest updating my RN version to 57 or 58 but I would like to avoid potential breaking changes unless the upgrade is critical.
I have also removed node modules, reinstalled them with npm ci and ran react-native link
Environment:

OS: macOS
OS version: 10.13.6
react-native version: 0.56.0
react-native-webview version: 5.12.1

We receive the same error when trying to build our project in CI.

Help, please. @Titozzz @jamonholmgren @StephenGrider

We had the same problem yesterday using react-native-webview 5.12.1 and react-native 57.
I strongly believe react native libraries should not use kotlin as this complicates usage for apps that do not use kotlin (most of them, as they are building apps in javascript..) as this is the main reason why integrating fails.
I was able to integrate the lib with the following changes:

Add kotlinVersion to android/build.gradle kotlinVersion = '1.3.41' (android/build.gradle)

buildscript {      ext {          buildToolsVersion = "27.0.3"          minSdkVersion = 21          compileSdkVersion = 27          targetSdkVersion = 27          supportLibVersion = "27.1.1"          **kotlinVersion = '1.3.41'**      } }

Add kotlin gradle plugin (android/build.gradle)

buildscript {     dependencies {         classpath 'com.android.tools.build:gradle:3.3.0'     } }

Add matchingFallback to non debug build types (android/app/build.gradle)

android {     buildTypes: {         client: {             matchingFallbacks = ['client', 'debug']         }         release: {             matchingFallbacks = ['release', 'debug']         }     } }
Note: I am using:

gradle wrapper 4.10.1 (distributionUrl=https://services.gradle.org/distributions/gradle-4.10.1-all.zip in gradle-wrapper.properties)
build tools 27.0.3 (buildScript.ext.buildToolsVersion = '27.0.3' in build.gradle)
gradle 3.3.0 (buildscript.dependencies { classpath 'com.android.tools.build:gradle:3.3.0' } in build.gradle)


Make supervisor more resilient to node going down

Follow-up to #895
See also #871
Description
The supervisor should now be more resilient to a node going down temporarily.
Instead of sitting there waiting for events via the subscription, the supervisor is
now notified that something went wrong, while the event monitor will attempt to
reconnect for a limited time (max retries with a delay between attempts).
Errors yielded by the client and packet workers are now caught at the top-level run loop of the worker,
and printed to the console rather than causing the worker to exits. This is quite brittle still
and will need more work and thought put into for the next milestone.
Tested with

setup the chains, clients, connections, and channels:

❯ ./scripts/dev-env ibc-0 ibc-1 ibc-2
❯ hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer -o unordered
❯ hermes create channel ibc-1 ibc-2 --port-a transfer --port-b transfer -o unordered

in a new console, with the debug log level in the config:

❯ hermes start-multi

send some packets if you want:

❯ hermes tx raw ft-transfer ibc-1 ibc-0 transfer channel-0 9999 1000 -n 5
...

kill one of the node, eg. ibc-1:

❯ ps aux | rg gaiad | rg ibc-1 | awk '{ print $2 }' | xargs -I{} kill -9 {}

watch the output of start-multi, it should show some errors about the WebSocket connection being down and perhaps some RPC queries failing but keep going and retrying to connect to the WebSocket.

start the nodes again (will automatically kill the remaining ones):

❯ ./scripts/dev-env ibc-0 ibc-1 ibc-2
❯ hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer -o unordered
❯ hermes create channel ibc-1 ibc-2 --port-a transfer --port-b transfer -o unordered

after a while it should be able to reconnect and you can send some packets

❯ hermes tx raw ft-transfer ibc-1 ibc-0 transfer channel-0 9999 1000 -n 5

For contributor use:

[x] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Updated relevant documentation (docs/) and code comments.
[x] Re-reviewed Files changed in the Github PR explorer.

I still see an error when starting with 3 chains in config but only two gaia processes. The output is:
May 06 15:22:30.864  INFO ibc_relayer_cli::commands: Using default configuration from: '.hermes/config.toml'
May 06 15:22:30.879 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'Tx'
May 06 15:22:30.880 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'NewBlock'
May 06 15:22:30.881 DEBUG ibc_relayer::event::monitor: subscribed to all queries
May 06 15:22:30.881  INFO ibc_relayer::event::monitor: starting event monitor chain.id=ibc-0
May 06 15:22:30.881 TRACE ibc_relayer::registry: spawned chain runtime for chain identifier ibc-0
May 06 15:22:30.885 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'Tx'
May 06 15:22:30.886 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'NewBlock'
May 06 15:22:30.887 DEBUG ibc_relayer::event::monitor: subscribed to all queries
May 06 15:22:30.887 TRACE ibc_relayer::registry: spawned chain runtime for chain identifier ibc-1
May 06 15:22:30.887  INFO ibc_relayer::event::monitor: starting event monitor chain.id=ibc-1
Error: RPC error to endpoint http://<IP_ADDRESS>:26457/: error trying to connect: tcp connect error: Connection refused (os error 61) (code: 0)

I believe the error comes from here (see ?):
https://github.com/informalsystems/ibc-rs/blob/ecbdb07a8bbed69e9cd9f88778a4b50edf0f5567/relayer/src/supervisor.rs#L332-L334
We should ignore the error...maybe create subscription as part of spawn_workers() below since we iter the chains there anyway.

@ancazamfir Should be fixed in https://github.com/informalsystems/ibc-rs/pull/903/commits/493191b7c549871ad46f87b4006820d8b48008a4.

Another nice to have is this: If there are 3 chains in config and only two chains/ gaiad nodes are up then I should see the same behavior regardless on how this state was reached. Right now:

when hermes starts with 2 nodes up and 3 chains, it tries to init 3rd chain and then it relays only for the two chains. It doesn't retry to reconnect with the third chain.
when hermes starts with 3 nodes and then one is killed, it relays over the two chains but keeps retrying to reconnect with the third.

Also the trying to reconnect to WebSocket end... and error when reconnecting are too often maybe especially because they are warn/ error and happen every 5 sec (exponential backoff would be nice here) or maybe give up after a while.


internal: Exclude conformance tests from code coverage

@bcoe: If I am not mistaken, conventional commits using the commit message from the merge commit, which is the PR title. Is that correct? It's a bit of a pain to update a PR that from an edit on GitHub, so I am inclined to leave the original commit message as is.

This is the file we need to change:
https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/.nycrc
After that's in, we need to do a hammer PR to make the change (happy to do that).
Also - for the conventional commits bit I think the chore: prefix or test: prefix would be the right answer :)


Module 4 exercises [Mohammed Munzamil]

Please "drag & drop" exercise 1 excel file below.
Exercise 1.xlsx

Please "drag & drop" exercise 2 excel file below.
Exercise 2.xlsx

Please "drag & drop" exercise 3 pdf file below.
MODULE 4 EXERCISE 3A Ranksum.pdf

MODULE 4 EXERCISE 3B Rankreciprocal.pdf

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 4 and make sure to take
the post-training survey. Participating in surveys is required for receiving
the "GALUP Certificate" by the University of Florida.

Well done, Mohammed. You clearly grasped the material outlined in Module 4 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


[enhancement] COG.YAML support trusted host and extra index for NVIDIA

Trying to leverage the new TensorRT Diffusers support feature, it requires using NVidia's hosted package manager. My cog.yaml looks like this gross mess:
build:
  gpu: true
  cuda: "11.7"
  python_version: "3.9.16"
  system_packages:
    - "python3-pip"
  python_packages:
    - "diffusers==0.15.1"
    - "torch==2.0.0"
    - "ftfy==6.1.1"
    - "scipy==1.9.3"
    - "transformers==4.25.1"
    - "accelerate==0.15.0"
    - "huggingface-hub==0.13.2"
    - "nvidia-pyindex==1.0.9"
    - "tensorrt==8.6.0"
  run:
    - pip3 install polygraphy --extra-index-url=https://pypi.ngc.nvidia.com --trusted-host pypi.ngc.nvidia.com
    - pip3 install onnx --extra-index-url=https://pypi.ngc.nvidia.com --trusted-host pypi.ngc.nvidia.com
    - pip3 install onnx_graphsurgeon --extra-index-url=https://pypi.ngc.nvidia.com --trusted-host pypi.ngc.nvidia.com

Would be great to specify in python_packages to use --extra index and --trusted-host in addition to pypi.

Hi @djj0s3. I agree, that's a mess. Fortunately, Cog lets you define package dependencies in a requirements.txt file like this:
build:
  gpu: true
  cuda: "11.7"
  python_version: "3.9.16"
  system_packages:
    - "python3-pip"
  python_requirements: requirements.txt

Then, in a sibling requirements.txt file:
diffusers==0.15.1
torch==2.0.0
ftfy==6.1.1
scipy==1.9.3
transformers==4.25.1
accelerate==0.15.0
huggingface-hub==0.13.2
nvidia-pyindex==1.0.9
tensorrt==8.6.0

--extra-index-url=https://pypi.ngc.nvidia.com --trusted-host pypi.ngc.nvidia.com
polygraphy
onnx
onnx_graphsurgeon

Unfortunately, this doesn't appear to be documented anywhere. So I opened https://github.com/replicate/cog/pull/1016 to fix that.


polish: README.md

What is the purpose of the change
polish README.md  , make sure hyperlink can jump to dubbo-samples  Instead of 404

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

thanks very much for your contribution


JavaScript Module Loading Possibly Broken

Hi Jeffrey (and others),
Love your work.
Replacing Bootstrap with Foundation in Elixir works great, but the same swap does not work in Mix.  I've spent over 8 hours trying to figure out why before bugging you here.
I've created a simple modification to your laravel-mix-example that illustrates the issue.
Trying to run the resulting js results in the error foundation is not a function, because the Foundation code has not been ran at all (and so $.fn.foundation has not been defined):

As best I can tell, the module loader in Elixir generates strings like so:

It appears to do this with some kind of experimental loader called buble-loader.  The eval() call ensures the code gets ran.
Mix, on the other hand, uses perhaps a different Babel loader, resulting in actual code instead of a string:

For some reason, the jQuery plugin is never registered, it's as if it's dealing with a different jQuery instance?
Several others are having the same issue.
Thanks in advance for any guidance.

Were you using mix.webpack with Laravel Elixir?
It looks like this is an issue with Foundation: https://github.com/zurb/foundation-sites/issues/7386

Yeah that's weird. I can't get it to work either. Some odd foundation bug.
If somebody figures out a fix, please post here.

Got the same problems, trying to get it fixed, but no solution so far...

Hmm...  I'm not sure that Foundation is the issue.
If you set up your app.js as just:
window.$ = window.jQuery = require('jquery');

And then set up your template's scripts like this:
<script src="{{ mix("js/app.js") }}"></script>
<script>
	jQuery(function() {
		alert('hello');
	});
</script>

It also throws an undefined error:

@ItsRD Thanks for the hack - while that seems to get Foundation running, I found it impossible to actually bind to any events like the modal open event and whatnot, no matter what I tried.
Everything I do in Elixir "just works", whereas most event-driven / jquery binding stuff doesn't work in Mix no matter what I try.

jQuery plugins can be confusing with Webpack - usually because they're legacy plugins that assume there will be a global jQuery object available to work with.

What's odd is how amazingly well Elixir's webpack works, even though it seems to be dependent on that "experimental" JS loader.
@JeffreyWay What do you think about perhaps using the same webpack JS loader that Elixir uses (buble-loader) in Mix?

@JVMartin - Maybe. I like Buble a lot.
We're you using mix.webpack() with Laravel Elixir? Or mix.scripts()?
Webpack has always been confusing, when it comes to jQuery plugins. But I'd like to get this all figured out so that people don't even have to think about it.
I was able to get it working by:

Adding mix.autoload({}) to your webpack.mix.js file.
Running npm install script-loader
Setting bootstrap.js to:

import 'script-loader!jquery';
import 'script-loader!foundation-sites';

$(document).foundation();

Interesting.  I am using mix.webpack().  I actually tried script-loader early on in my experiments, but was missing the mix.autoload({}) which is probably why I had no success with it.
Here's what's working for me, using Elixir:
gulpfile.js
elixir(mix => {
	mix.sass('app.scss');
	mix.webpack('app.js');
	mix.version(['css/app.css', 'js/app.js']);
});

resources/assets/js/bootstrap.js
// Window-bound objects.
window._ = require('lodash');
window.$ = window.jQuery = require('jquery');
window.Vue = require('vue');
window.tinymce = require('tinymce/tinymce');
window.axios = require('axios');
window.axios.defaults.headers.common = {
	'X-Requested-With': 'XMLHttpRequest'
};

// Other packages.
require('foundation-sites');
require('any-other-jquery-plugin');

resources/assets/js/app.js
require('./bootstrap');

$(document).foundation(); // Works great

$('#modal').bind('open.zf.reveal', function() { // Works great
	alert('Works great!');
});

Everything I throw at Elixir's webpack like this - jquery plugins, etc. - all work great without any additional tweaking.
I know next to nothing about converting ES6 to ES5, I wish I could be of more assistance in figuring out what's going wrong in Mix.

@JeffreyWay Thanks for the mix.autoload({}) tip. That worked perfectly for me, from a fresh Laravel 5.4 install with Laravel Mix.
For others, my relevant files are below (with a little experiment to prove the event binding works).
boostrap.js

window._ = require('lodash');

/**
 * We'll load jQuery and the Bootstrap jQuery plugin which provides support
 * for JavaScript based Bootstrap features such as modals and tabs. This
 * code may be modified to fit the specific needs of your application.
 */

window.$ = require('jquery');
window.jQuery = window.$;

/**
 * Vue is a modern JavaScript library for building interactive web interfaces
 * using reactive data binding and reusable components. Vue's API is clean
 * and simple, leaving you to focus on building your next great project.
 */

window.Vue = require('vue');

/**
 * Require Foundation JS
 */
require("foundation-sites");

/**
 * We'll load the axios HTTP library which allows us to easily issue requests
 * to our Laravel back-end. This library automatically handles sending the
 * CSRF token as a header based on the value of the "XSRF" token cookie.
 */

window.axios = require('axios');

window.axios.defaults.headers.common = {
    'X-Requested-With': 'XMLHttpRequest'
};

app.js

/**
 * First we will load all of this project's JavaScript dependencies which
 * includes Vue and other libraries. It is a great starting point when
 * building robust, powerful web applications using Vue and Laravel.
 */

require('./bootstrap');

/**
 * Next, we will create a fresh Vue application instance and attach it to
 * the page. Then, you may begin adding components to this application
 * or customize the JavaScript scaffolding to fit your unique needs.
 */

Vue.component('example', require('./components/Example.vue'));

const app = new Vue({
    el: "#app",

    mounted(){
        $(document).foundation();

        $("#dropdown-pane").on("hide.zf.dropdown", () => {
            console.log("Dropped down");
        });
    }
});

webpack.mix.js
const { mix } = require('laravel-mix');

/*
 |--------------------------------------------------------------------------
 | Mix Asset Management
 |--------------------------------------------------------------------------
 |
 | Mix provides a clean, fluent API for defining some Webpack build steps
 | for your Laravel application. By default, we are compiling the Sass
 | file for the application as well as bundling up all the JS files.
 |
 */

// Prevents Mix's automatic configuring of jQuery, so that we
// can set it up ourselves later
// https://github.com/JeffreyWay/laravel-mix/issues/229#issuecomment-276230983
mix.autoload({});

mix.js('resources/assets/js/app.js', 'public/js')
   .sass('resources/assets/sass/app.scss', 'public/css');

This works great but for some reason when running the production code this fails...
@AndyBursh Can you check if running yarn run production works or fails for you?
Thanks!

@amosmos I can't, sorry. I don't have a Mix project to test it on.


[mle chat] cli should be redesiged

the existing workflow has several issues

I would like to redesign the mle chat, and here are some thoughts I've had:

enable mle chat to execute code and debug: users may have written their codes, and they need MLE Chat to execute and debug on these.
allow mle chat to read logs and other files: users may train multiple models with different configurations, and it would be helpful for mle chat to analyze training logs and suggest an optimal configuration.
enable mle chat to retain conversation memory: users can choose to return to their previous conversations when they re-enter the CLI.
allow mle chat to greet users at first and inform users of its capabilities, reducing the need for users to provide prompts at the beginning, and making the interaction more engaging.

If you have time, could you share some insights or suggestions on these? Thank you!
cc. @HuaizhengZhang, @huangyz0918

enable mle chat to execute code and debug: users may have written their codes, and they need MLE Chat to execute and debug on these.

I think we already have this?


Render notification_topic_arn when exporting ElastiCache clusters

I think it's good to render notification_topic_arn on .tf file and .tfstate file. Because I'm using terraforming with Terraform CLI tool with import subcommand.
In that situation, I work according to the below instructions.

Execute terraforming ecc
Cut and paste (or process the output by a script) a target cluster TF configuration to a new .tf file.
Run terraform import module.elasticache_redis.aws_elasticache_cluster.foo foo to import the actual resource into tfstate file.
I confirm that there are no diffs by run terraform plan command.

If the actual resource has a notification configuration, then the terrafrom plan generates the following output.
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ module.elasticache_redis.aws_elasticache_cluster.foo
      notification_topic_arn: "arn:aws:sns:ap-northeast-1:123456789012:bar" => ""

Plan: 0 to add, 1 to change, 0 to destroy.

I’d like the output of terraforming to eliminate diffs after run terraform import. What do you think about this?
I'm using terraforming with the following environment.

macOS
ruby 2.5.3p105
Terraform v0.11.10 with provider.aws v1.39.0

Coverage remained the same at 100.0% when pulling 92f101d2ec954cb1cc8c3d4a3f6ae4c8b26d6b18 on mozamimy:elasticache-cluster-notify into 1ba96b958123087dc1454e284ce34cc9c00b69a0 on dtan4:master.

Sorry for the late review 🙇

I’d like the output of terraforming to eliminate diffs after run terraform import. What do you think about this?

I agree with this 👍

Thank you!


[SPARK-32757][SQL][followup] fix a small mistake in SubqueryBroadcastExec

What changes were proposed in this pull request?

This is a followup of https://github.com/apache/spark/pull/29601 , to fix a small mistake in SubqueryBroadcastExec. SubqueryBroadcastExec.doCanonicalize should canonicalize the build keys with the query output, not the SubqueryBroadcastExec.output.
Why are the changes needed?

fix mistake
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing test

Test build #128144 has started for PR 29610 at commit a2fea25.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32769/
Test PASSed.

thanks for the review! merging to master!

Test build #128144 has finished for PR 29610 at commit a2fea25.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128144/
Test PASSed.


fix: keep from unnecessarily recreating "no release" comment

We were wiping the “no release” comment on each run, even if nothing changed. This became especially problematic when used with semantic-release-monorepo, recreating the “no release” comment for any package without a new release (likely the vast majority of packages).
BREAKING CHANGE:
Dropped use of verifyConditions as a plugin hook to delete stale comments. This now happens in analyzeCommits instead.

Merging this PR will publish the following release:

5.0.0 (2018-03-07)
Bug Fixes

keep from unnecessarily recreating "no release" comment (531676a)

BREAKING CHANGES

Dropped use of verifyConditions as a plugin hook to delete stale
comments. This now happens in analyzeCommits instead.

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Drawable move constructors + fix board

move constructors and assignmnet operators for drawable + small fix for the board

looks good


[PLATI-1143] Merge in v2.20.0

Merges v2.20.0 into our fork
Spec changes were borrowed from https://github.com/braze-inc/mongo-ruby-driver/pull/9
This diff shows that our patches were applied fairly cleanly — some patches were moved since retryable.rb was refactored. For comparison, this diff shows how the current version is patched.
https://github.com/Appboy/platform/compare/PLATI-1143-mongo contains these changes to platform:

bulk_write monkey-patched to not raise an error if passed an empty array
Mongo::BulkWrite::Result.new updated with a new parameter
update monkey-patch of Mongo::Server::Monitor to match current implementation
adjust new max_connecting mongo client parameter to match sidekiq concurrency

I was able to get the tests passing in gemtester with a small patch (a few tests don't being run inside docker)
https://github.com/braze-inc/gemtester/compare/PLATI-1143-mongo-2.20.0


Add #[debug] to descriptor structs

Closes #542

Add #[debug] support for UNION!
Add #[debug] to .*?_DESC\d? in (d2d|d3d|dxgi).*

And add #[debug] to any types depended on by above.

I'm not sure how I feel about Debug on unions.

I'm not sure how I feel about Debug on unions. I'll think about it and come up with a solution.

We have a need for this in https://github.com/crossterm-rs/crossterm/pull/363. Wouldn't a reasonable solution be to just print the underlying [u16]?


Neomake causes neovim to close quite slowly.

First of all, thanks for a very handy plugin! Second, I don't really know how to debug neovim's closing procedure, so if one has any ideas on how to do it I would be pleased to dive into this problem.
Expected behavior
Neovim closes and one can immediately type bash commands.

Steps to reproduce

Open neovim.
Load neomake.
Close neovim.
See that you have to wait round about 2 seconds for neovim to close.

Output of the ":verb NeomakeInfo" command
Neomake debug information
Async support: 1
Current filetype:
Enabled makers
For the current filetype (with :Neomake): None.
NOTE: the current buffer does not have a filetype.
For the project (with :Neomake!): None.
NOTE: you can define g:neomake_enabled_makers to configure it.
Default maker settings:

remove_invalid_entries: 1
buffer_output: 1

Settings
g:neomake_place_signs = 1

shell: /bin/zsh
shellcmdflag: -c
Windows: 0

:version

NVIM 0.1.7
Build type: RelWithDebInfo
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20170102-28468-abikw3/neovim-0.1.7/build/config -I/tmp/neovim-20170102-28468-abikw3/neovim-0.1.7/src -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/opt/gettext/include -I/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include -I/tmp/neovim-20170102-28468-abikw3/neovim-0.1.7/build/src/nvim/auto -I/tmp/neovim-20170102-28468-abikw3/neovim-0.1.7/build/include
Compiled by<EMAIL_ADDRESS>
Optional features included (+) or not (-): +acl   +iconv    +jemalloc +tui
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.1.7/share/nvim"

:messages

Which maker?  Please expand on the "Load neomake." step.
After :NeomakeSh sleep 5 I can quit immediately.

Neovim closes and one can immediately type bash commands.
…
shell: /bin/zsh

?! ;)

It has really nothing to do with any makers. It's just the "closing mechanism". My guess is that some autocommands which are run on the VimLeave event causes the problem. The init.vim I tested with looks like this:
call plug#begin()
" Plug 'benekastah/neomake' " Linter and maker.
call plug#end()

so maybe it's a vim-plug related bug. However, with other plugins enabled neovim closes normally. And there is another plugin which causes neovim to close slowly: vim-airline. But that shouldn't be discussed in here, I believe..

We're not hooking into VimLeave.
So with the minimal setup it also happens for you?

Try :set verb=9 (or higher) when quitting and see where it hangs and/or what it does more compared to when not running Neomake.
Do you say that just having Neomake without it being have run and/or when all makers have finished is slow?
Does my example also hang for you?  Also with the minimal config?

OK, tried it with a completely fresh config and now neovim closes correctly, i. e. fast. Sorry for the inconvenience. Thanks for your help, though!

Good to hear.
So it is not even Neomake related then?
I will close the issue, please tell me more when you find something.

So it is not even Neomake related then?

No it's not.

I will close the issue, please tell me more when you find something.

It was actually me "cleaning" my init.vim and somehow, during this process, I managed to install vim-plug into ~/.nvim/autoload instead of ~/.config/nvim/autoload.


⚠ Mobitopup has degraded performance

In 7178f35, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6243 ms

Resolved: Mobitopup performance has improved in 1c2290d.


C/C++ Build scripts

@saipriya-m Thank you for the contribution. I will review the updates this week.
Please make sure the DCO is in place, and that you have sent an email to Dan Bruce as outlined in :
https://github.com/IBM/dbb-zappbuild/blob/main/CONTRIBUTIONS.md

@dennis-behm
I will work on the requested changes and push the code again.


Gatsby cloud integration POC

[ ] Determine which projects need to be onboarded with Gatsby cloud
[ ] Create a POC to showcase Gatsby cloud features
[ ] Create a benchmark of current setup vs cloud setup
[ ] Detail migration path from existing path to Gatsby cloud (playbook)

Closing as usecase is not imminently active.


Add documentation for contributing to tinylog

Description
Linked issue: #196
Contributing guidelines

@proohit Have I missed anything that could be helpful for new committers?

I will have a look at it tomorrow :)

Thank you for your review! Would you be able to build tinylog with the given information? Have I missed anything?

Yep I would be able to build with those hints.
For the tests: Do you expect a minimum code coverage? If yes, then you could add that too.

For the tests: Do you expect a minimum code coverage? If yes, then you could add that too.

Good suggestion! I have just added it.


"Decline All" in modal re-opens consent bar

Environment

Operating System: Linux
Node Version:     v16.20.0
Nuxt Version:     3.7.0
CLI Version:      3.7.2
Nitro Version:    2.6.2
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, modules, cookieControl
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-whwnbg?file=app.vue
Describe the bug
When clicking on the "Learn More and Customize" option in the cookie consent bar to open the modal, clicking "Decline All" closes the modal, and re-opens the consent bar.
The expected behavior is that all cookies should be declined, the modal closes, as well as the full consent bar.
If this is the intended behavior, would it be possible to allow that behavior to be configured through the nuxt.config? It appears that the code which would need to be changed is /src/runtime/components/CookieControl.vue line 270. isConsentGiven: false.
I would be happy to create a pull request for this issue.
Thanks!
Additional context
No response
Logs
No response

Well, if you decline all cookies there is no cookie that could save that preference. So that's intended behavior. I'd be cautious not to get into legal issues with that, but I'm not an expert in that field so I keep to reasoning that's plausible to me.
Maybe that's answer enough, maybe you still see the possibility to implement this. If the latter applies, what would be your explanation for users that cookies are set when they chose not to? (there could be a reason, it may just not come to my mind)

Closing for now.

Sorry for the delay in responding @dargmuesli. What you've explained makes sense. I have noticed, though, that if you click "Decline All" it does store a cookie called ncc_c with value 0 anyway, so that might be a bug if the intended behavior is that all the cookies should be deleted.
To boil down the part which isn't intuitive is that when the user makes the "Decline All" selection, they are immediately presented with the same choice again.  There are a couple of ways to solve this that I can think of:

Remember that the user made a "Decline All" selection in-memory without setting a cookie. That way they at least won't be prompted again until returning to the site, or doing a "hard" navigation.
Change the verbiage to "Decline Optional" or something to that effect, and then only decline the non-necessary cookies to make the site run appropriately. (which would include the choice the user just made). This seems to be the most common approach I've seen on the web.

I tend to lean towards the second choice. The second option could also be turned on as a configuration setting in the Nuxt config file so it wouldn't be a breaking change. What are your thoughts?

I think the second option makes sense. Would you be up to implement that?

Hi @dargmuesli and @volkipp, I would also the Decline All button to close the modal and the cookie bar as well. Did you make any progress in this feature request?

Hey @volkipp, right now, the default "Save" button reflects the settings like you described and expect.
It only saves the optional cookies and the bar stays hidden after closing the modal.
So in theory, you could just hide the "Decline all" button and remain with the 2 buttons: "Save" (rename to "Accept only optional") and "Accept all".
Unfortunately, you'd had to do it over css or patch the module with my proposed enhancement from here applied until/for the case it gets implemented. With this change, you can adjust reorder the buttons and remove the "Decline all" button markup-wise.

Well, it's not really only about the necessity of consent fetching but about denying consent. There are two primary thoughts that I see:

If I'm asked whether I'd like to consent to cookies being stored on my device and decline, I'd not expect cookies to be stored on my device and as the EU certainly aims to protect the users' interest, that expectation should be satisfied
Keeping the cookie banner could be considered "unnecessarily disruptive" as it is worded in Recital 32 EU GDPR, especially on mobile screens on which the cookie banner might take up the full width and height of the screen

But a solution for 2. could also be to design the cookie banner differently.

btw, both sites, https://www.cookiebot.com/ as well as https://www.cookieyes.com/, currently seem to have broken cookie policies themself:

https://www.cookiebot.com/en/cookie-declaration/ (no content at all)
https://www.cookieyes.com/cookie-policy/ (button "cookie settings" does not lead anywhere)

not sure if those are indicators of trustworthiness...


Why ROS 1 over ROS 2?

Hi!
Very exciting project.
How come the choice to use ROS 1, and not ROS 2?

I have used ROS1 for years and I don't have much experience with ROS2. ROS 1 just fast for me to prototype. I think after this going forward I am more likely to develop something more generic without dependency on ROS, like a pure Python API or something like that.

Aaah, that makes a lot of sense. Thank you for all this cool work 😄

Aaah, that makes a lot of sense. Thank you for all this cool work 😄


Add german translation

Add german translation files.
Yes/No buttons in Dialogs are still in French though, see https://github.com/edrlab/readium-desktop/issues/128#issuecomment-377915633

Dear maintainers: Please ping me a couple of days before the next public release / every public release after its feature-freeze so I can update the german language file in time!

Thanks a lot Tobias, for these translations.
Note: I see that a TravisCI lint check has failed...
Ok, we'll ping you (as much as we can trigger our memory).
Don't hesitate to give us info about your use of Readium Desktop.

@llemeurfr yeah, just noted a linting error. Will fix it.

Hello Tobias, I believe Pull Requests must target the 'develop' branch, not 'master' (which is used to tag releases).

Hi Daniel, alright, I changed target to develop. Travis running again, but shouldn't be a problem as master and devlop seem to be even. Will do that for the other PR's as well.
You could add a GitHub Contributing file to state this info.

You could add a GitHub Contributing file to state this info.

See also PR templates e.g. the one for readium-css, with a checklist at the very beginning to make sure everything is OK. Not perfect but it’s at least another safety net.


Newfeature

made some change required
create a second pull request , because i closed the first one #1 accidently.
Hello code reviewer my default branch is (master) and the pull request is from the (newfeature) to the (master)

For what time i could submit the Project??
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows
De: Akinlade @.>
Enviado: sábado, 24 de septiembre de 2022 06:06 p. m.
Para: @.>
CC: @.>; @.>
Asunto: Re: [maherramadan78/Myportfolio] Newfeature (PR #2)
@mckent05 requested changes on this pull request.
Hi @maherramadan78https://github.com/maherramadan78 ,
STATUS: CHANGES REQUIRED ♻ ♻
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes ♻
Check the comments under the review.
Optional suggestions

I have left some optional comments, I recommend implementing these suggestions as they will help to improve the look of your project 😄

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your code.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policyhttps://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this formhttps://airtable.com/shrQAqnBwek5a0O0s.
In css/style.csshttps://github.com/maherramadan78/Myportfolio/pull/2#discussion_r979327499:

+.My-Recent-Work {

font-weight: 300;

font-size: 35px;

line-height: 45px;

align-items: center;

display: flex;

Just as the previous reviewer suggested, this section should have a display of grid.

In index.htmlhttps://github.com/maherramadan78/Myportfolio/pull/2#discussion_r979327825:

MY RECENT WORK

Multi-Post Stories

A daily selection of privately

  personalized reads; no accounts

  or sign-ups required. has been the

  industry's standard dummy text

  ever since the 1500s, when an

  unknown printer took a standard

  dummy text.

CSS

html

bootstrap

Ruby

+
+
+
+
+
+
+Multi-Post Stories
+
+
+A daily selection of privately

personalized reads; no accounts

or sign-ups required. has been the

industry's standard dummy text

ever since the 1500s, when an

unknown printer took a standard

dummy text.

+

+
+
+CSS
+
+html
+
+bootstrap
+
+Ruby
+

+
+
+
+

+
+
+
+

Just like the previous reviewers have suggested, please wrap the whole of your work section around a section` tag 🙏 . This will improve the accessibility of your site 😄 😄

In index.htmlhttps://github.com/maherramadan78/Myportfolio/pull/2#discussion_r979328039:

+

+
+
[OPTIONAL} - This shouldn't be an image, it should either be a button tag or an a tag. Please try to fix this 🙏 🙏
—
Reply to this email directly, view it on GitHubhttps://github.com/maherramadan78/Myportfolio/pull/2#pullrequestreview-1119351341, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVUZBWZJTNF5IEFY4FS4JDDV76COHANCNFSM6AAAAAAQTIKZJA.
You are receiving this because you were mentioned.Message ID: @.***>

Hello , Good morning thank you so much, i have fixed the body tag.
Do i need to make git push again?
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows
De: Olaoluwa @.>
Enviado: sábado, 24 de septiembre de 2022 11:57 p. m.
Para: @.>
CC: @.>; @.>
Asunto: Re: [maherramadan78/Myportfolio] Newfeature (PR #2)
@Olamarx requested changes on this pull request.
Hi @maherramadan78https://github.com/maherramadan78,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
[https://camo.githubusercontent.com/8275c8d55934871bc1ac2954860c36dc9db830c5fcdee002022266c7d30d5af2/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f7854394450494259663070417669424c7a4f2f67697068792e676966]https://camo.githubusercontent.com/8275c8d55934871bc1ac2954860c36dc9db830c5fcdee002022266c7d30d5af2/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f7854394450494259663070417669424c7a4f2f67697068792e676966

[ ] Kindly implement all the changes required by the previous code reviewer

Your Project
[image]https://user-images.githubusercontent.com/86200356/192128961-b0f1a2fc-45ce-4982-83b7-3dae17109567.png
Figma
[image]https://user-images.githubusercontent.com/86200356/192128995-c2c2084d-5b29-4ddb-ab3f-5543b3a246a0.png
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policyhttps://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this formhttps://airtable.com/shrQAqnBwek5a0O0s.
In index.htmlhttps://github.com/maherramadan78/Myportfolio/pull/2#discussion_r979353343:

[ ] There should be a body tag here, just immediately after the head tag and the header tag would be inside the body tag.

—
Reply to this email directly, view it on GitHubhttps://github.com/maherramadan78/Myportfolio/pull/2#pullrequestreview-1119369814, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVUZBW3UVQKBKEOSYWTNZKTV77LUFANCNFSM6AAAAAAQTIKZJA.
You are receiving this because you were mentioned.Message ID: @.***>

yes , i have fix it , thank you so much

Hi @maherramadan78,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

You have submitted a project for re-review using a merged and approved PR. Each milestone should be submitted in a new pull request.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

They asked me to merge it, i didnt know that i delete body tag accidently.
Thats too rude  really.
What can i do now???
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows
De: Emmanuel @.>
Enviado: domingo, 25 de septiembre de 2022 12:32 a. m.
Para: @.>
CC: @.>; @.>
Asunto: Re: [maherramadan78/Myportfolio] Newfeature (PR #2)
Hi @maherramadan78https://github.com/maherramadan78,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
[Invalid Submission]https://user-images.githubusercontent.com/20554583/192127422-b4f07238-39b6-4938-ac85-a7988da86494.gif
You have submitted a project for re-review using a merged and approved PR. Each milestone should be submitted in a new pull request.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
—
Reply to this email directly, view it on GitHubhttps://github.com/maherramadan78/Myportfolio/pull/2#issuecomment-1257124665, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVUZBWYZ3ZQUMXWQ33KYFDDV77PWDANCNFSM6AAAAAAQTIKZJA.
You are receiving this because you were mentioned.Message ID: @.***>


Rename wrap and coroutine + various minor changes

This PR contains various minor changes, please review it with care. The major changes are wrap → createRunnable + coroutine → createCallable with the names borrowed from Java.
Further points not yet addressed:

Coroutine::dispose should probably not dispose the generator, but execute all finally blocks normally, just like a regular PHP function would. If another promise in a finally block fails, that error is the result of the promise instead, similar with returns.
wait should probably fail with an Error if Loop::run throws instead of letting that exception bubble up. Addressed now.
I'm not sure whether we should keep pipe and capture.

Not sure about createRunnable and createCallable… those names are going to need time to grow on me.
Why the function instead of UnionTypeError? The same could be done for InvalidYieldError, so what's the difference?
I used UnionTypeError in at least one place in another Amp lib, so if going with a function, maybe it should not be internal?
I've been unsure of the behavior of Coroutine::dispose myself. Maybe it's better to change these lines to simply $this->generator = null which should force finally blocks of the generator to be run.
I agree on wait, adding the thrown exception from Loop::run as the previous exception.
My initial reaction to eliminating pipe and capture was no… but really uses of those should probably be coroutines, so maybe it would be best to discourage then-style usage of promises.

wait throws an Error now in case Loop::run throws.

createCallable(callable): callable - that signature makes absolutely no sense to me; you pass in a callable to create something it already is? coroutine(callable): callable makes much more sense in that context. At least one then knows that it's about creating callable coroutines. I do not see where it makes the name any clearer.
createRunnable(callable) … what's the difference between calling and running? if I call a function, it runs??
I think we should retain coroutine() and rename wrap() to asyncCoroutine(), because that's typically what it is - it creates a coroutine which will continue asynchronously (i.e. not along the flow of the calling coroutine).
I don't care about Amp\UnionTypeError or TypeError, in the end it's just an Error which anyway should not be caught.
The other changes are fine.

Renamed to asyncCoroutine and coroutine.


Training

I use the data of CNN/Daily Mail and  the hyper parameter of the paper to train the model based on your project.  However, I found that the loss keeps almost constant when I set the batch size to 32 or 64 and if I set the batch size to 8, it will  be convergence gradually.  if you know the reasons, could you tell me about it , many thanks.

it seems  problems in your preprocess procedure， just debug it.发自我的华为手机-------- 原始邮件 --------主题：[pocheyeniu/SummaRuNNer] Training (#3)发件人：Liguinan 收件人：pocheyeniu/SummaRuNNer 抄送：Subscribed I use the data of CNN/Daily Mail and  the hyper parameter of the paper to train the model based on your project.  However, I found that the loss keeps almost constant when I set the batch size to 32 or 64 and if I set the batch size to 8, it will  be convergence gradually.  if you know the reasons, could you tell me about it , many thanks.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/pocheyeniu/SummaRuNNer/issues/3?email_source=notifications\u0026email_token=AD6J45YDD7CBNP5SS5XIGWTP4MRDXA5CNFSM4H3PVPUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3XVXUA",
"url": "https://github.com/pocheyeniu/SummaRuNNer/issues/3?email_source=notifications\u0026email_token=AD6J45YDD7CBNP5SS5XIGWTP4MRDXA5CNFSM4H3PVPUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3XVXUA",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

what do you mean？ the data format before reading or the data has been read before training？which step could be wrong if you know？ by the way，I preprocess the original data as your Chinese corpus in the project before reading it.
many thanks for your kind help.

i have no idea. i suggest u debug it by yourself. i think it's not a hard work


Un-substituted ${username_service} in Twitter assertion failure message

I changed the name on my Twitter account from resiak to wjjjjt this morning. The error from keybase id about my previous proof in the name of resiak contains a literal ${username_service}:
% keybase id resiak@twitter
▶ INFO Identifying wjt
✔ public key fingerprint: 1E68 E58C F255 8883 0164 5B56 3422 DC0D 7AD4 82A7
[ irrelevant, passing assertions removed ]
✔ "resiak" on twitter failed: Bad post authored: wanted ${username_service} but got wjjjjt (code=203) [cached 2017-02-22 08:58:41 GMT]
▶ ERROR Unmet remote assertions for user "wjt"

I also notice that it has a check mark, rather than (say) a cross.

Platform Information:
    OS:        linux
    OS vers:   Linux 4.9.8-201.fc25.x86_64 x86_64-"Fedora release 25 (Twenty Five)"
    Runtime:   go1.7.1
    Arch:      amd64

Client:
    version:   1.0.18-20170220171343+19c204b

Thanks for the report! CC @oconnor663

CC: @mlsteele on the PVL error (more likely)

Updated to 1.0.18-20170222170057+287734c, the patch from #5978 has fixed the string substitution:
% keybase id wjt
▶ INFO Identifying wjt
✔ public key fingerprint: 1E68 E58C F255 8883 0164 5B56 3422 DC0D 7AD4 82A7
[...]
✔ "resiak" on twitter failed: Bad post authored: wanted 'resiak' but got 'wjjjjt' (code=203)

Is the check mark intended to show for failing assertions as well as successful ones?

A check implies that you have followed the other person with this failure
and an "x" implies that this proof "breaks" your following of them
On Thu, Feb 23, 2017 at 3:37 AM Will Thompson<EMAIL_ADDRESS>wrote:

Updated to 1.0.18-20170222170057+287734c, the patch from #5978
https://github.com/keybase/client/pull/5978 has fixed the string
substitution:
% keybase id wjt
▶ INFO Identifying wjt
✔ public key fingerprint: 1E68 E58C F255 8883 0164 5B56 3422 DC0D 7AD4 82A7
[...]
✔ "resiak" on twitter failed: Bad post authored: wanted 'resiak' but got 'wjjjjt' (code=203)
Is the check mark intended to show for failing assertions as well as
successful ones?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/5973#issuecomment-281928950,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_2QAgDTBmGK9dZsNjF4IE_UhcsWKks5rfUU3gaJpZM4MIX9z
.

I don't quite understand the distinction. A friend who follows me, and has done so since before I changed my Twitter handle (invalidating the proof), sees the following output:
$ keybase id wjt
▶ INFO Forking background server with pid=10199
▶ INFO Identifying wjt
✔ <tracked> public key fingerprint: 1E68 E58C F255 8883 0164 5B56 3422 DC0D 7AD4 82A7
You last followed wjt on 2017-01-09 17:14:49 GMT
✔ <tracked> admin of DNS zone willthompson.co.uk: found TXT entry keybase-site-verification=hnN35c3ZWjUuB1zIcqihFwHk7azY5pihFDC7sL1JClk
✖ <tracked> "resiak" on twitter failed: Bad post authored: wanted 'resiak' but got 'wjjjjt' (code=203)
✔ <tracked> "wjt" on github: https://gist.github.com/ceb8cfbac518cf005845
✔ <tracked> admin of DNS zone wjt.me.uk: found TXT entry keybase-site-verification=QZbKxln38lrxNdnvoB757i-q_fw-75B24ber6u3AI24
✔ <tracked> "wjt" on hackernews: https://news.ycombinator.com/user?id=wjt
▶ ERROR failed to identify "wjt": 1 followed proof failed

Why does he see a ✖, while I see a ✔  for the same invalid proof?

Your " ✔" is there because you have OK'ed the fact that the proof is invalid.

I guess you can't really make a signed statement for who you are that's different from whom you are, so you are usually "OK" with anything that's you.  Maybe this can use some tweaking, I realize it's confusing.
BTW, the code to render this is here