Added evaluator for code-code Clone Detection

Hi @EZ7051 , the readme file (https://github.com/SEEDGuard/SEVAL/blob/92799b302aea7f59a3adb8f04e3c713075096c97/src/tasks/clone_detection/README.md) does not look correct to me. The input of the task are a code and a collection of candidates, the output is Top K codes with the same semantic (see here https://github.com/microsoft/CodeXGLUE/blob/main/Code-Code/Clone-detection-POJ-104/README.md). Pls correct this.

Hi @EZ7051,
Sorry for the delayed response and thank you for your contribution.
We are requiring that contributors add a test script for their evaluation in the test folder. You will find a starter file for your script there. The script will test that the output of the evaluator is correct. You can find an example here. We also ask that you add a "How to test" section to your README and move the data files to the test folder, e.g. answers, predictions, expected.
If you have any questions please let me know.

Hi, @maxxbw54 Professor, updated the readme file, earlier I mentioned the input and output of the evaluator instead of the task, corrected it.
@mrhuggins03 Added the test.py file and moved the data files to the test folder.

Hey @EZ7051,
Everything looks great! The only small thing is that we do not need the train or valid files for the evaluation. I will go ahead and delete these and then your code will be merged!
Thanks for your contribution


Better tilegrid selection UIList

Current UIList is a bad hack, needs to be rewritten so it works better
Implementation details:

A function needs to take the grid list and generate a new array, consisting of material and then grids below it
An integer property used for indexing generated array, if a material element is selected, moves to first grid

Closed, superseded by issue #12


Validate Accessors in GraphQL Resources

GraphQL resources should only be allowed the accessors query and mutation (When we support mutations). We may decide how to handle subscriptions later.
With the #19 we validate the accessors at the runtime. But ideally, this should be validated using a compiler plugin.
Related Discussion: #757

This is now fixed with the Compiler Plugin implementation. (https://github.com/ballerina-platform/module-ballerina-graphql/pull/153)


Consider facilities for recording volunteer effort

In FreeREG as well.  But V1.6 or even V2.

It is issue #20 in FreeREG - scheduled for version 2.0.
On 25 April 2017 at 11:17, Eric Dickens<EMAIL_ADDRESS>wrote:

In FreeREG as well. But V1.6 or even V2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FreeUKGen/FreeCENMigration/issues/241#issuecomment-296986265,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGC5BjVISJGhqdE93jWsNKGQAcwEAGMsks5rzcgzgaJpZM4NHPmw
.

--
- -
Dr Pat Reynolds
Executive Director
Free UK Genealogy  http://www.freeukgenealogy.org.uk/
A Charitable Incorporated Organisation registered in England and Wales,
number 1167484
VAT registration: 233 0105 70
+44 1723 362616   +44 7943 145387
Westwood House,Westwood, Scarborough YO11 2JD, UK


Use codecov instead of lcov

This should enable codecov region coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e2a19f7) 93.03% compared to head (8f4850c) 90.49%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   93.03%   90.49%   -2.55%
==========================================
  Files          11       11
  Lines        2283     2283
  Branches        0     2283    +2283
==========================================
- Hits         2124     2066      -58
+ Misses        159      158       -1
- Partials        0       59      +59

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


e2e CI: Run nightly tests both on Rancher Manager stable and latest devel versions

Right now, we only run our test on top of latest devel Rancher Manager version.
For instance:
root@ubuntu:~# helm search repo --devel
rancher-latest/rancher                 	2.7.2-rc1      	v2.7.2-rc1     	Install Rancher Server to manage Kubernetes clu...

But I think we also need to test latest stable version:
root@ubuntu:~# helm search repo
rancher-latest/rancher                 	2.7.0        	v2.7.0     	Install Rancher Server to manage Kubernetes clu...

and I will rename all workflow because we can not read them as they are:

Test's descriptions are too long to be displayed entirely.


update aws-java-sdk to 1.11.764

Bumping to unblock https://github.com/spinnaker/kork/pull/617

Released with updated version: https://github.com/Netflix/AWSObjectMapper/releases/tag/v1.11.764


Miscellaneous Tasks

An issue to add various different tasks for Turing Commons Repository and Website
(1) WEBSITE

[ ] Change icons of the "About" pages for each skills track and each module (except for the overall RRI Skills track about page)
[ ] Add citation information for each skills track page
[ ] Check if there's a way to show only the information relevant to the specific skills track on the left-hand side menu of the page
[ ] Landing page: Update to new landing page
[ ] Landing page: Revise definition of Turing Commons
[ ] Welcome page: Revise content + add image
[ ] Skills Track page: Add explanatory definition of modular approach, skills tracks, modules, etc. + revise content
[ ] About RRI Skills Track page: Fix layout of citation info + revise content
[ ] About Module 1 page: Add title of the module (Understanding Responsibility: About this module)
[ ] About RRI Skills Track page: Check content
[ ] RRI-100-1: Update responsibility vs accountability graphic
[ ] RRI-100-2: Add initial image
[ ] RRI-100-3: Add initial image
[ ] About module 2 page: Add title of the module (The Project Lifecycle: About this module)
[ ] RRI-100-1: Perhaps change the project lifecycle icon to our new illustrated version?
[ ] RRI-101-2: Add illustrative examples (health care + environmental sciences)
[ ] RRI-101-3: Add illustrative examples (health care + environmental sciences)
[ ] RRI-101-4: Add illustrative examples (health care + environmental sciences)
[ ] RRI-101-4: Complete Burton (2019) reference
[ ] About SAFE-D principles module pages: Add overarching title of the modules (The SAFE-D principles: About these module)
[ ] About SAFE-D principles module pages: Change the content for the fairness module as soon as we merge fairness modules branch
[ ] About Fairness module: Add title of the module (Fairness: About this module)
[ ] About Fairness module: Add learning objectives and descriptions of each section
[ ] RRI-201 --> RRI-204: Check version that is uploaded
[ ] RRI-203-2: Add dynamic tabs for domain-specific examples of digital divides
[ ] About Explainability module: Add title of the module (Explainability: About this module)
[ ] RRI-204-2: Add full citation to footnote 6
[ ] RRI-204-3: Add full citation to footnote 1
[ ] Resources --> Gallery: Capitalise all in parenthesis
[ ] Resources --> Gallery: Revise tags (factorisation + possible addition of new tags)
[ ] Resources: Add animations
[ ] Resources: Add case studies
[ ] Resources: Add activities
[ ] Resources: Add bibliography
[ ] Blog: Upload draft of Illustration blog
(2) REPOSITORY
[ ] Fix Clau's deletion of 7000+ files
[ ] Curation for resources branch of the repo (past presentations, recordings of courses, handouts, etc.)
[ ] Add explanation for each branch (wiki)
[x] Add new illustrations to images and images.yml

[x] Air Quality Forecasting
[x] Remote Sensing
[x] Genetic Disorder
[x] Confusion Matrix
[x] Precision v Recall
[x] Project Lifecycle no tags
[x] Project Lifecycle tags
[ ] Individual Project Lifecycle

[ ] README document:

[ ] Why is the project useful + Project vision and goals
[ ] About the team
[ ] How contributors or users can get started
[ ] How to cite the TC and the TC resources (illustrations and animations)
[ ] Who they can reach out to for help
[ ] Other relevant project summary info: i.e. milestones of the project, what is currently missing in terms of stakeholders, skills, and scope

[ ] Add code of conduct
[ ] Add detailed contribution guidelines and interaction pathways
[ ] Add specific blog contributing guidelines and ideas
[ ] Add new version of project lifecycle illustration to gallery
(3) OTHER
[ ] Create onboarding/handover document for new starters in the project
[ ] Finish animation video RRI SK
[ ] Add links to gallery of newly added illustrations to Illustrations HackMD
[ ] Finish illustrations
[ ] Citizen's guide to data
[ ] Finish activities upload
[ ] Draft remaining modules for RRI skills track
[ ] Draft activities for remaining modules for RRI skills track
[ ] Go over all illustrations with Cami
[ ] Review scripts for OLE
[ ] Record OLE

Useful resource for Community Management aspect of repository: The Turing Way's Guide to Planning a Community

@ClauFischer and @JohnGTuring: I have merged the updates to the gallery into the main branch to bring the tags functionality. Thanks for your help with this, John.
@ClauFischer: please go ahead and fetch these updates in your main branch and then you can delete your local copy of the gallery branch (assuming you have one). We can now start on the refactoring/refining of the list of tags in the images.yml file.

@chrisdburr have fetched the updates on my main branch. Only have remote version of gallery branch so all done.

Two additional updates:

[ ] Update site logo
[ ] Update site favicon


Handling Router Middleware

Previously with tRPC, we were doing the following to handle an is-authenticated check for every router request:
const isAuthenticated = t.middleware(async ({ ctx, next }) => {
  if (!ctx.req.isAuthenticated()) {
    throw new TRPCError({
      code: "UNAUTHORIZED",
      message: "You are not logged in",
    });
  }
  return next({ ctx });
});

const authenticatedProcedure = t.procedure.use(isAuthenticated);

Is there a way in TS-Rest to add a function that is executed before every router handler? I can add an Express middleware, but I thought I'd ask as it'd be nice to avail of TS-Rest's common response type, data.isLoading, etc. From looking at the documentation I see I could add a 401 option to every route, e.g.
export const apiContract = c.router({
  getFoo: {
    method: "GET",
    path: "/ts/foo",
    responses: {
      200: c.response<FooResponseType>(),
      401: c.response<NoAuthResponseType>(),
    },
    summary: "Get foo",
  },
});

What is the TS-Rest recommended approach? And if it doesn't exist, is there any plan to add support for this?
For what it's worth, I'm currently handling it this way:
export const configureTSRest = (app: Express): Express => {
  app.use("/ts/*", (req, res, next) => {
    if (!req.isAuthenticated()) {
      return res.status(401).send();
    }

    return next();
  });

  createExpressEndpoints(apiContract, completedRouter, app);

  return app;
};

UPDATE: This is working quite nicely with just:
export const configureTSRest = (app: Express): Express => {
  app.use("/ts/*", (req, res, next) => {
    if (!req.isAuthenticated()) {
      return res.status(401).send();
    }

    return next();
  });

  createExpressEndpoints(apiContract, completedRouter, app);

  return app;
};

And on the client:
const queryClient = new QueryClient({
  defaultOptions: {
    queries: {
      refetchOnWindowFocus: false,
      retry: false,
      onError: (error: any) => {
        // Redirect to login for any unauthorized response
        if (error.status === 401) {
          // Redirect to login code here
        } else {
          console.error(error?.message, error?.data);
        }
      },
    },
  },
});


unable to show multiple calendar ar a time

hello,
please let me know if there is a option to show multiple months calendars at a time.
thanks,

This is not a feature the datepicker currently supports. I can't give an ETA on when the will come or if this will even be added to the datepicker. Keep an eye on the changelogs if this is added in the future!


Feat: Add and update Newsletter component

What's the purpose of this pull request?
fs/components

[x] Moves Newsletter component

fs/ui

[x] Updates Newsletter styles
[ ] Adds new colorVariant variants

fs/core

[x] Review Newsletter  structure @lucasfp13

How to test it?
run yarn dev and check the Newsletter feature on the store or test it using the doc preview link:

Newsletter Doc

Starters Deploy Preview
WIP

closing this PR in favor of https://github.com/vtex/faststore/pull/2189


stand-alone conditional_base

This is related to #83.
Current solution will only work with block-wise nets and is therefore not future proof.

Closing in favour of #375.


Custom transport issue

I've got problem with capture log message. info[MESSAGE] and info[LEVEL] is undefined... And typeof info is "string" = type of log message (for example: info = "debug" or "info"). So how to get log message?
My transport code:
const Transport = require('winston-transport');
const util = require('util');
const { LEVEL, MESSAGE } = require('triple-beam');

module.exports = class SocketIOTransport extends Transport {
    constructor(options) {
        super(options);

        if (!options.socketio)
            throw new Error('options.socketio is required.');

        this._socketio = options.socketio;
    }

    log(info, callback) {
        let self = this;
        setImmediate(function () {
            self.emit('logged', info);
        });
        this._socketio.sockets.emit('botlog', { a: info[MESSAGE] });
        if (callback && typeof callback === 'function')
            callback();
    }
};

Initilaze winston:
winston.configure({
            transports: [
                new (SocketIOTransport)({
                    socketio : io
                }),
                new (winston.transports.Console)({
                    colorize: true,
                    timestamp: function() {
                        return moment().format('DD.MM.YY HH:mm:ss');
                    }
                }),
                new (winston.transports.DailyRotateFile)({
                    filename: '../storage/logs/bot/log',
                    datePattern: 'MM-dd.',
                    prepend: true,
                    localTime: true,
                    maxDays: 31,
                    level: process.env.ENV === 'development' ? 'debug' : 'info'
                })
            ]
        });

I don't know what's the problem( Any help? Thx.

Looks like your mixing winston3 and winston3 APIs.
Which version of winston did you install with npm?

@mempf oh, version 2.4.0. My bad

Looks like you've resolve this issue. Thanks @mempf for jumping in to help. Going to close this as fixed – if you're still having problems with winston@3 please feel free to reopen.


Create second project for mypy-protobuf

This was a rudimentary way of having multiple mypy commands
per project (as needed here). It might be more elegant to have
multiple mypy_cmd within a project, but it seemed nontrivial to
achieve, and I was able to whip this mechanism up more quickly -
using multiple projects with one mypy_cmd per project.
Not the most proud of it, but it works.

It's not super critical this gets in.
If the implementation strategy gives you the eebie jeebies, I think it's ok for this to wait for a better impl.

Thanks, let me think about this one!


merge two layers or more

is there is a way to merge
two layers in one layer
from this

to this

This is a feature that we are including in the Geoman Pro version in an upcoming release.


[IMPROVEMENT] Show empty msg in recent emoji picker

@RocketChat/android

Closes #897

This PR will show "No recent emoji" msg in recent emoji picker.

Could you fix the conflict file @divyanshub024 ?

@filipedelimabrito all requested changes are done.

@leonardoaramaki I have made the changes.

Thanks!

Would be great to rebase to fix conflicts rather than add merge commits.


fix: Remove ArcGIS API for JavaScript & Add ArcGIS Maps SDK for JavaScript

ArcGIS API for JavaScript Version 3.x retired on July 1, 2024. Version 3.46 was the final release of the 3.x series. For more details, see the [retirement announcement](https://www.esri.com/arcgis-blog/products/js-api-arcgis/developers/arcgis-api-for-javascript-version-3-x-retirement/).
This fix adds ArcGIS Maps SDK for JavaScript, the 4.x version of Esri's ArcGIS JavaScript API. It addresses issues #6 and #7.

already done!   5ca3858


Add Timestamp Queries to Bitonic Sort Example

Utilized example code found at https://developer.chrome.com/blog/new-in-webgpu-121 to add timestamp queries for the bitonic sort on compatible browsers.
At large enough element sizes, these queries can be used to compare the performance between sorts of various sizes, or compare performance when the maximum invocations per dispatch are arbitrarily limited.
Minor changes:
'Complete Sort' has been renamed to 'Auto Sort' to better reflect controller functionality.

observation: it's interesting that on my machine, the first sort step takes 0.06ms and the last one takes 2ms

Maybe it's not clear from my comments yet, but the displayed time is accumulating the times of each step rather than displaying the time a single step takes to execute. Given that the last step is almost certainly swapping over global indices rather than workgroup local indices at greater than 512 elements, it stands to reason that the last step would take longer than the first step, but there wouldn't be such a great difference. Perhaps there should be a display controller that displays the time a single step takes to execute (i.e if you're using Execute Sort Step rather than Auto Sort), a display controller that accumulates the times for each step within a sort, and maybe a final display controller that averages out the time a sort takes under a certain sort config combination (Elements + Workgroup Size Limit)

I think I'll fix/add that (maybe move this back to draft or ask for re-review later).

I think I'll fix/add that (maybe move this back to draft or ask for re-review later).

This should be finished now bar any unexpected bugs.


Can only download from the No-Intro directory

The System selection box only lists the systems under the No-Intro directory, is is intended or do you plan to add the other directories/systems too (such as Redump/Internet Archive etc)?
Is it also possible to add an option to download all regions of a system at once?

Yeah, I'm planning to add an 'Advanced mode' in version 1.1 that enables downloading from whatever directory you want. It's sort of a difficult conundrum as i want MRScraper to be as easy to use as possible

Released v1.1 with these improvements included


Differentiate byte strings and text strings

As per RFC 7049, there are two types for string-like objects:

byte string (initial bytes from 0x40 to 0x5f)
text string (initial bytes from 0x60 to 0x7f)

I was able to generate text strings with CBOR.encode, but I could not generate byte strings. Any ideas?
In my particular use case, I am encoding a digital signature as part of a CBOR message:
iex(39)> sig
<<163, 123, 73, 53, 241, 26, 53, 147, 219, 117, 91, 170, 239, 198, 167, 21, 246,
  117, 186, 249, 230, 246, 246, 125, 162, 151, 118, 125, 104, 118, 241, 203,
  141, 95, 89, 146, 46, 181, 160, 77, 216, 199, 225, 150, 225, 248, 153, 125,
  13, 254, ...>>
iex(40)> sig |> CBOR.encode() |> Base.encode16()
"7840A37B4935F11A3593DB755BAAEFC6A715F675BAF9E6F6F67DA297767D6876F1CB8D5F59922EB5A04DD8C7E196E1F8997D0DFE7337FBB7C3AC22C86B6092E93901"

When loading the hexadecimal into a Python CBOR library, it fails, since it is expecting a printable text string (initial byte is 0x78).
>>> import cbor2
>>> cbor2.loads(bytes.fromhex("7840A37B4935F11A3593DB755BAAEFC6A715F675BAF9E6F6F67DA297767D6876F1CB8D5F59922EB5A04DD8C7E196E1F8997D0DFE7337FBB7C3AC22C86B6092E93901"))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa3 in position 0: invalid start byte

So it would be useful if the library allowed encoding of binary objects as CBOR byte strings.

I just learned that I have to use a CBOR.Tag to encode bytes, and it worked. Closing the issue.

Ah, was just about to respond. Yeah you have to wrap the sig like this %CBOR.Tag{tag: :bytes, value: sig} and it should do what you want.
If you ever need to understand what to encode/decode take a look at the tests for the library. They should follow the exact examples in Appendix A of the RFC.


Not tracked Libraries show in Statistics

Describe the bug
When I disable tracking for a specific library it is hidden in "Librares" Tab, but still shown as graph in Statistics.
Environment Details (please complete the following information):

OS: macOS
Browser: Safari
Jellystat Version: 1.1.0
Jellyfin Version: 10.9.11

To Reproduce
Steps to reproduce the behavior:

Go to Settings
Go to Library Settings
Uncheck "Tracked" on a library
Reload page
Library is hidden on Librarys Tab (can be shown by clicking the eye in the top-right corner
Library shows still on graphs in Statistics Tab.

Expected behavior
Library should be also hidden on Statistics Tab.
Screenshots

Libarary "Videos" has "Tracked" unchecked.

Library "Videos" is still be shown in Graph in Statistics Tab.
Task Logs
If applicable, add Task Logs for your problem.
Container Logs
If applicable, add Container Logs for your problem.
Additional context
Add any other context about the problem here.

Hey @alexanderkuenzel , is this still an issue?

Hey @CyferShepard, this is working now. Thank you!


Convenience method for creating spans

The goal of this PR is to make it easier for users to create spans wrapped around blocks of work, without having to manually call start or finish on the span.
The interface for the current implementation would be:
span = Span.wrap do
  # do something
end
# Send span to NR via client or harvester

Looking forward to feedback on whether this is a sufficiently convenient setup or whether there's something more intuitive.

I am closing this for now because we're considering a wider-scale entry point that would allow users to conveniently interact with various parts of the SDK.


Parsing python programs

This is rather a question than issue. I am wondering is there a off-the-shell python parser that is readily for use in C# program. Thanks

@keowang I am using https://github.com/Microsoft/PTVS/
Curious what do you need such a parser for?


perf(scroll): prevent unneeded forced synchronous layout on update

In the case where new items are added or the component is otherwise rerendered,
this avoids an expensive relayout in getScroll() where the result would not change.
In a production application I see as much as 9ms on unneeded synchronous
layout when this happens.

This is minified production code, but it gives an idea of how expensive this synchronous layout can be. This happens when I append an item to the top of the list, which should not require scroll recalculation.

LGTM, thanks!

Thanks for the very quick merge!

Published in 0.8.9


Issue with k8s.io/docs/reference/access-authn-authz/rbac/

This reference manual on RBAC fails to define its terms; the legal and recognized "verbs" in this syntax are nowhere to be found; one can only glean the verbs from the arbitrary examples given, with no expectation of comprehensiveness, and otherwise go searching elsewhere.

/wg api-expression
PR #25299 might help by adding a better list of verbs. However, I don't think there is an agreed list of API verbs defined anywhere.


No data for the filter selection because of selected categories (7 by default)

As only 7 categories are selected by default on the color axis, the risk is high of not having any data for the current filter selection. This is a pity, especially now that we have solved this problem with the cascading filters.
To Reproduce

int.visualize.admin.ch, source : PROD
Search and open "Soil pollution"
Choose "sampling period" on the x-axis
Choose "Site" on the color axis
Try several Filter combination for dimension "Heavy metal" and "Land use"

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Visualize environment and version: INT, source PROD, v3.7.11 ([ba2e668]
Browser : edge

Fixed on dev, through #697


Transfer SOL should be associated with wallet

it's in account view atm, a bit odd since you can only use the wallet

Sure -- In the AccountView for each account we have this component, "Transfer SOL", which implies that you can transfer SOL to/from that account. But the operation is only possible for the accounts for which we have private keys, and mainly, when we do operations with priv keys in Workbench, we are expecting to use the selected wallet up top. So it would make more sense to have a dropdown for Transfer SOL in the top bar that sends from the wallet, instead of in each individual account view.

imo its nice to have it i the account view, but the UX would then change to "send SOL to this account", where the FROM==wallet-adapter-account, and TO==account selected in AccountView (right pane).
that way, there's no real need for copy&paste, or typing (and we don't get asked why super.sol Solana Name Service names don't work)

I do agree with sven that its better to keep the button where it currently is, but renaming it to "send SOL" and making the target account input read only. That way I think user will get the feeling that the button is to send sol to the selected account. But also, I think there needs to be another element using which user could just type or paste the target account. That way the user wouldn't have to filter through the accounts list.

closed by #219 ?


Correct usage of AntiForgery token in ASP.NET 5 in SPA application?

In previous version of ASP.NET during SPA application the idea of AntiForgey token was following:

add @Html.AntiForgeryToken(); on the page
add __RequestVerificationToken to the request
override AuthorizeAttribute as ValidateJsonAntiForgeryTokenAttribute.

I don't really understand the authorization requirements (is there some good information source?) in ASP.NET 5 but looks like new behavior should be like this:

add asp-anti-forgerytaghelper
add __RequestVerificationToken to the request
here should be the new requirement.

The question is: how to write this new authorization requirement and remove standard one?
Could someone give some advice or point me on some example? Thanks
P.S. Looks like I need to create custome middleware and check if it's json to use my way or use standard await _antiforgery.ValidateRequestAsync(context);
But still not sure about it.

Then ASP.NET 5 isn't ready? SPA framework namely angularjs using $resource to perform an ajax post to RESTful service. It appears I would need to create some custom pre-filter attribute to validate the antiforgery token. I did notice the dev branch appears to implement a header token to handle this cause. So why wasn't this added to release (RC1)

@kscott5 you're right, ASP.NET 5 is only rc1 now. You can't create pre-filter attribute anymore. According to this answer http://stackoverflow.com/a/31465227
I've found only this implementation on MusicStore https://github.com/aspnet/MusicStore/blob/master/src/MusicStore/Controllers/ShoppingCartController.cs#L62
However this is bad one. So looks like it should be a custome middleware  which reuse a code from MusicStore if it's json or use standard one.
But of course I'm thinking maybe there is something good from asp.net team.

So why wasn't this added to release (RC1)

Time machines are hard.

There's a few different approaches and ways to go with this. I've opened a PR with the sample I wrote in parallel to the feature. https://github.com/aspnet/Antiforgery/pull/31
We're certainly all ears when it comes to making this easier in the framework.
This sample is based on Angular and sets up the necessary state to have Angular interoperate ASP.NET Antiforgery. See info here: https://docs.angularjs.org/api/ng/service/$http (ctrl+f XSRF)

Some page accessed by the user directly sets the 'request token' in the XSRF-TOKEN cookie. In my sample I did this with a simple middleware since the 'landing page' is a static HTML file.
Angular will send back the 'request token' in the X-XSRF-TOKEN header
Configure Antiforgery to look at this header

services.AddAntiforgery(options => options.HeaderName = "X-XSRF-TOKEN");

Your server side code needs to validate the token, either by calling into the service, or using the attribute provided by MVC.

@davidfowl That's hilarious.
@rynowak Unfortunately the AntiforgeryOptions does not include the HeaderName property in RC1 but I believe I can work around this by using the middleware suggestions and avoid the Antiforgery pre-filter attribute.
I see what I come up with.

Unfortunately the AntiforgeryOptions does not include the HeaderName property in RC1 but I believe I can work around this by using the middleware suggestions and avoid the Antiforgery pre-filter attribute.

@kscott5 - If you want this to work on rc1, I'd suggest replacing the IAntiforgeryTokenStore and copying from the rc2 implementation. https://github.com/aspnet/Antiforgery/commit/3280ff6ac55aee20953fbcb7284dcdcb93aa07dd#diff-b6e9c2bfe3926a98f35010c4e094e419R76
Lines 75-88 have the logic you need. The rest of that commit is just renames and error handling.

Thanks guys, gonna play with this over the weekend.

I've followed the changes since last year, and impressed with what I've tried.
@rynowak You saved me sometime cause in the past I had to create custom stores for Identity, etc. So you just saved me sometime. Thanks.

@rynowak will your updated features and guidance cover everything discussed here?

@rynowak ping

Yes, I'm not aware of anything else we need to in antiforgery to light up these scenarios.

@rynowak so what MusicStore has right now shows the recommended pattern for antiforgery in a SPA scenario?

yes

Hey guys,
I'm developing a SPA and I'm getting an issue when logging in the user. I tried the approach @rynowak suggested but after logging in I get Antiforgery token validation failed. The provided antiforgery token was meant for a different claims-based user than the current user. whenever I do a POST request.
Do you have any suggestion of how I could workaround this?
Thanks!

You will need to refresh the antiforgery token(s) after logging in. The token is tied to the user's identity.

Thanks for your quick reply! I realized I always call /profile right after signing in, so I put the token refreshing logic there. It works for my app, but seems hackish.
My main issue is that I'm not using the cookie authentication, but JWT. When the user authenticates I can't call context.Authentication.SignInAsync because it's not implemented.
I was thinking maybe manually adding my JWT claims to the context.User will make it work since this is where you get it from.
But this won't work with my app since the client side saves the access_token in a cookie that is not read by the code when context.Request.Path == "/" (it saves the token to avoid signing in each time).
What do you think is a good approach here? I'm probably going to stick with my current solution, but maybe JWT authentication is a scenario we'd want to have better support.

If you're doing bearer auth, you have no reason to use antiforgery.

Jum, that's interesting. I guess I have to search how Bearer Auth protects from CSRF. I haven't seen that mentioned anywhere!

Bearer auth doesn't need CSRF protection because it's not a persistent auth mechanism.
Think of it this way... if a malicious site hosts a form that posts to example.com, then example.com's cookies will be included when that form is submitted. This is an automatic behavior of browsers, and it's just how cookies work.
On the other hand if you're using bearer (JWT) using the Authorize header then there's nothing automatic. The malicious site doesn't have your JWT, and it won't automatically be provided by the browser - because it's not a cookie.

Oh, I see. So if I store the jwt in a cookie but don't read it in the
server (I only use it as a storage mechanism in the client side) I won't be
subject to XSRF?
On Thu, Sep 22, 2016, 19:19 Ryan Nowak<EMAIL_ADDRESS>wrote:

Bearer auth doesn't need CSRF protection because it's not a persistent
auth mechanism.
Think of it this way... if a malicious site hosts a form that posts to
example.com, then example.com's cookies will be included when that form
is submitted. This is an automatic behavior of browsers, and it's just how
cookies work.
On the other hand if you're using bearer (JWT) using the Authorize header
then there's nothing automatic. The malicious site doesn't have your JWT,
and it won't automatically be provided by the browser - because it's not a
cookie.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Antiforgery/issues/29#issuecomment-249044903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9J6eGMLlWZPOMVedRmBsF0ieieBJks5qsv7qgaJpZM4G2yYr
.

if I store the jwt in a cookie but don't read it in the
server (I only use it as a storage mechanism in the client side) I won't be
subject to XSRF?

You will absolutely be vulnerable to xsrf if you're using cookies to send it to the server, regardless of what type of token or credential it is. Can you please open a new issue with an example and a more clear description of what you need to accomplish? I think we need more background information to understand what you need.

Sure, I'll see what I can do.

@rynowak I'm using your suggested implementation in an Angular 4 SPA, and am wondering how you reccommend handling token expirations?

Our tokens currently don't expire unless the user's session times out.
I'd suggest getting a new token every time a user logs in

From what I can tell, that is precisely the problem - the user's session is timing out, and the token is no longer valid.  The site uses windows authentication so there is no explicit log in.  Here is the error I get:
CryptographicException: The key {...} was not found in the key ring. Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingBasedDataProtector.UnprotectCore(Byte[] protectedData, bool allowOperationsOnRevokedKeys, out UnprotectStatus status) InvalidOperationException: The antiforgery token could not be decrypted. Microsoft.AspNetCore.Antiforgery.Internal.DefaultAntiforgeryTokenSerializer.Deserialize(string serializedToken)
Doing some searching on this I discovered that this can happen unless you have explicitly set the application to persist keys, so I followed the instructions here to create a "registry hive" as the key store, but that hasn't resolved the issue.

Can you please open a new issue for this on aspnet/DataProtection - that sounds like your real problem

Sure - but if you are correct that the AntiForgeryToken expires when a user's session expires, seems like I'll still run into this issue regardless of whether the keyring is properly persisted..?

That error doesn't have to do with the token expiring.

@rynowak  I was able to resolve the DataProtection error, but I am running into token expirations with users that are testing the application.  I can reproduce the behavior by manually deleting the anti forgery cookies and then trying to make an ajax call.  However, I find if I remove the following, and add the cookie on every response it seems to resolve the issue (at least when I delete the cookie manually).  Any reason the cookie shouldn't be written on every response?
if (context.Request.Path == "/")

I am running into token expirations with users that are testing the application.

Can you describe what you mean by this? Do you mean that the browser has lost track of the cookie? Our token's themselves don't have an expiry, but they are attached to the user's identity.

Any reason the cookie shouldn't be written on every response?

In general you should only need to do this when you user has to log-in/log-out. I don't see a problem with it though.

Do you mean that the browser has lost track of the cookie?

Right - when I checked the user's machine the cookie was not present.  I am unable to reproduce myself after leaving a browser session overnight.  Occurred to me that the user may have a plugin that is causing cookies to be cleared, but the user indicated the issue occurs both in IE and Chrome on this particular machine.

In general you should only need to do this when you user has to log-in/log-out.

The application uses windows authentication, so there is no log in form or explicit log in to hook into.

@artemgrygor I had moved on after my initial assessment but thank you for responding.

@rynowak How am I supposed to refresh the antiforgery token(s) after logging in? Could you please show an example?

I have an ASPNET Core API \ Angular app. My API needs to support cookies and tokens.
After I login using my service the anti-forgery token returned is not valid as it was created based on a null user. I've  tried setting ClaimsPrincipal after my PasswordSignInAsync and regenerating the anti-forgery token (see below) but that still does not work. Any ideas!
public virtual async Task<IActionResult> Login([FromBody] AccountLoginModel model)
{
        var result = await this.SignInManager.PasswordSignInAsync(model.Email, model.Password, isPersistent: model.RememberMe, lockoutOnFailure: false);
        if (!result.Succeeded)
        {
            return this.BadRequest();
        }
        var user = await this.UserManager.FindByEmailAsync(model.Email);

        // Must manually set the HttpContext user claims to those of the logged
        // in user. Otherwise MVC will still include a XSRF token for the "null"
        // user and token validation will fail. (MVC appends the correct token for
        // all subsequent reponses but this isn't good enough for a single page
        // app.)
        var principal = await this.PrincipalFactory.CreateAsync(user);
        this.HttpContext.User = principal;

        // Update XSRF token
        var tokens = this.Antiforgery.GetAndStoreTokens(this.HttpContext);

        return this.Ok();
}

I just noticed that this.Antiforgery.GetAndStoreTokens(this.HttpContext); is not changing the value of XSRF-TOKEN. Shouldn't this update based on the fact I have changed the HttpContext.User to be the new principal?

Same Here, It doesn't change the xsrf token if  HttpContext.User Changes After login
here's my description :
https://stackoverflow.com/questions/52290736/xsrf-token-conflicts-with-jwt-token

I just noticed that this.Antiforgery.GetAndStoreTokens(this.HttpContext); is not changing the value of XSRF-TOKEN. Shouldn't this update based on the fact I have changed the HttpContext.User to be the new principal?


Allow renaming the workspace

right now it breaks if you rename your workspace.

going to look up workspace by fixed ID instead of name to allow this, and will also prevent nodes with fixed IDs (usually system nodes) to not be deletable and that should reduce chance of bad data being stored.


Ensure our metrics labels are honored

Since OCP 4.3, the monitoring stack is featuring a Prometheus proxy
component (Thanos). One of the proxy components (prom-query-proxy) is modifying
the metrics on the fly: it changes our namespace label to exported_namespace.
In result, while virt-handler sets the namespace label to be the
namespace in which the VMI resides, it's being overwritten to the
namespace of virt-handler. Since virt-handler's namespace is privileged,
users without access to this namespace will not be able to view this
metric.
Signed-off-by: Daniel Belenky<EMAIL_ADDRESS>
** Related BZ **:
https://bugzilla.redhat.com/show_bug.cgi?id=1805044
** Related PR on openshift-console **:
https://github.com/openshift/console/pull/4623
Release note:

Ensure Prometheus operator honors labels on kubevirt exported metrics

/cherry-pick release-0.26

/retest

/hold
Apparently, honorLabels is discouraged by the monitoring team because it introduces some security risks. The alternative is to use relabelings and ensure that Prometheus doesn't even attach the namespace label to our metrics. I'm checking this path now and will update the PR accordingly.

/hold cancel

/retest

/test pull-kubevirt-e2e-k8s-1.15.1-ceph


Created a seperate section for ngAttr directive

This ticket is with reference  to  #9780 to create a seperate directive page for ngAttr binding attribute, as such.

I've recently added info about ngAttr to the new interpolation guide page: https://code.angularjs.org/snapshot/docs/guide/interpolation
A special page for ngAttr is imo overkill, although it would be nice if it was easier to find.
If you think we should any info from your PR to the guide page, please open a new PR.
Apart from that there are some problems with your PR. You have added a page to build version of the docs, not the src version. We cannot add this to the repo, as we don't check in anything that is built from the source.

I'm going to close this PR because we cannot merge it in its current state, as we are either waiting for more information, tests are missing, or required code changes haven't been made.
Feel free to reopen this PR or open a new one if you have remdied the issues pointed out.


Could not use more than one command for atom-shell-commands in config.cson

I am using Atom 1.19.2 in MacOS Sierra. When I try to save the config.cson file with additional
commands it only saves the last command.
Example:
"*":
  "advanced-open-file":
    createDirectories: true
    createFileInstantly: true
    fuzzyMatch: true
  "atom-shell-commands":
    commands: [
      {
        name: "run_script"
        command: "bash"
        arguments: [
          "run_script.sh"
          "{FileName}"
        ]
        options:
          cwd: "{FileDir}"
          keymap: "ctrl-5"
      }
    ]
    # Another example
    commands: [
      {
        name: "copy"
        command: "cp"
        arguments: [
          "{FileName}"
          "/Users/poudel/Dropbox/FileBackups/macpro_{FileNameNoExt}{FileExt}"
        ]
        options:
          cwd: "{FileDir}"
          keymap: "ctrl-2"
      }
    ]
  # Another Example
    commands: [
      {
        name: "man"
        command: "/usr/bin/man"
        arguments: [
          "{CurWord}"
        ]
        options:
          cwd: "{FileDir}"
          keymap: "ctrl-1"
      }
    ]

Gives only the last command for man.
I have also posted a StackOverflow question for this, but could not get the answer.
The quesition
How can we fix the problem. Help will be greatly appreciated.
atom-shell-commands is indeed one of the best packages, and I am waiting to use it.

take this:
commands: [
    {
        name: "cmd1",
        ....
    },
    {
        name: "cmd2",
        ....
    },
    {
        name: "cmd3",
        ....
    }
]


Netio

Hi, finally stable so it is PR time :)
This is thus support for Netio smart outlets as switches with consumption as attribute.
I am also looking into get this consumption as a separated sensor but as I saw the branch sensor template I will check it out.

There is a lot of stuff that shouldn't be in this PR. Please rebase off dev. I think you're so far down the rabbit hole it would probably be easier to branch off a fresh checkout of the dev branch and cherry pick your commits back in.

Indeed,
completely screwed up my merge on the wrong origin… sorry, I have already changed and rebased I will correct that.

On 22 Jan 2016, at 03:43, Paulus Schoutsen<EMAIL_ADDRESS>wrote:
There is a lot of stuff that shouldn't be in this PR. Please rebase off dev. I think you're so far down the rabbit hole it would probably be easier to branch off a fresh checkout of the dev branch and cherry pick your commits back in.
—
Reply to this email directly or view it on GitHub https://github.com/balloob/home-assistant/pull/960#issuecomment-173785369.


Add Item 12: Prefer Member Initializers to Assignment Statements

This pull request is based on #62 (thanks @rorozcov!) and introduces a new Roslyn analyzer to enforce best practices for member initializers and assignment statements in C#. The analyzer identifies cases where a member variable and constructor have duplicate or divergent logic, leading to extra work being done by the runtime.
Changes

Analyzer: PreferMemberInitializerAnalyzer:

Detects duplicate member variable assignment and initialization
Detects member variable assignment from a constructor that could be done at declaration
Accounts for complex control flow and variable usage to limit false positives

Code fix provider: None

The initialization logic of applications can be complex and a code fix provider can be complex to capture all cases of remediation. This implementation only shows areas of potential duplication.

Tests: Comprehensive unit tests covering various scenarios

This analyzer aligns modern C# and .NET practices, particularly CA1805: Do not initialize unnecessarily and Effective C# Item 12: Prefer member initializers to assignment statements.
Closes #36

Summary by CodeRabbit

New Features

Introduced a new diagnostic analyzer to enforce the use of member initializers over assignment statements in constructors, improving code clarity and maintainability.
Added performance benchmarking capabilities for the new analyzer.

Documentation

Added guidelines for the new coding rule (ECS1200) emphasizing member initializers, including examples and best practices.

Bug Fixes

Enhanced diagnostic capabilities to accurately identify redundant initializations and improve overall code quality.

Tests

Implemented a comprehensive suite of unit tests for the new analyzer, covering various initialization scenarios and ensuring adherence to best practices.

Performance baseline test fails, tracked in #64. After this merges the commit hash will move forward and the issue will go away until we move the version forward again.


⚠ Bofrost.be has degraded performance

In 0934d5b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1983 ms

Resolved: Bofrost.be performance has improved in 84446bb.


Error in kubeflow 05_04_Pipeline_SageMaker

Transform job ended with status: Completed
    s3_client.download_file(bucket, output_key, 'valid-result')
  File "/usr/local/lib/python2.7/dist-packages/boto3/s3/inject.py", line 172, in download_file
    extra_args=ExtraArgs, callback=Callback)
  File "/usr/local/lib/python2.7/dist-packages/boto3/s3/transfer.py", line 307, in download_file
    future.result()
  File "/usr/local/lib/python2.7/dist-packages/s3transfer/futures.py", line 106, in result
    return self._coordinator.result()
  File "/usr/local/lib/python2.7/dist-packages/s3transfer/futures.py", line 265, in result
    raise self._exception
botocore.exceptions.ClientError: An error occurred (403) when calling the HeadObject operation: Forbidden
Runtime execution graph. Only steps that are currently running or have already completed are shown.

My original execution role has SM and follow policies.
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:GetObject",
                "s3:PutObject",
                "s3:DeleteObject",
                "s3:ListBucket"
            ],
            "Resource": [
                "arn:aws:s3:::*"
            ]
        }
    ]
}

@Jeffwan we need to investigate why its still failing. The chapter has an IAM policy with full S3 permissions. Also, the transform job completes. I'm not sure what this error mean

This is an error from batch_transormation component. It tried to fetch result file after job finish. I will double check images and code to figure out the issue.
WARNING:root:pandas failed to import. Analytics features will be impaired or broken.
INFO:botocore.credentials:Found credentials in environment variables.
INFO:root:Submitting Batch Transformation request to SageMaker...
INFO:root:Batch Job request submitted. Waiting for completion...
Traceback (most recent call last):
('Created Transform job with name: ', 'BatchTransform-20191202005620-C12M')
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job is still in status: InProgress
Transform job ended with status: Completed
  File "batch_transform.py", line 48, in <module>
    main()
  File "batch_transform.py", line 39, in main
    _utils.print_tranformation_job_result(args.output_location)
  File "/app/common/_utils.py", line 219, in print_tranformation_job_result
    s3_client.download_file(bucket, output_key, 'valid-result')
  File "/usr/local/lib/python2.7/dist-packages/boto3/s3/inject.py", line 172, in download_file
    extra_args=ExtraArgs, callback=Callback)
  File "/usr/local/lib/python2.7/dist-packages/boto3/s3/transfer.py", line 307, in download_file
    future.result()
  File "/usr/local/lib/python2.7/dist-packages/s3transfer/futures.py", line 106, in result
    return self._coordinator.result()
  File "/usr/local/lib/python2.7/dist-packages/s3transfer/futures.py", line 265, in result
    raise self._exception
botocore.exceptions.ClientError: An error occurred (403) when calling the HeadObject operation: Forbidden


Support for uninstalling extensions given paths to their .vsix files

Fix for #33106.
I tried to touch as few things as possible and to reuse already available functions. Is it good enough?
I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

@fabiospampinato,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@fabiospampinato, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

It means you should run Format Document before staging. In the team we all have "editor.formatOnSave": true in order to have the files always formatted.

Thanks for the info.
It should be properly formatted now.

@joaomoreno Is this PR going to get merged anytime soon?

Thanks! 🍻


Footer icon incompatible

Preview is directly from demo:

My guess for this is caused by
https://github.com/adisaktijrs/hexo-theme-minima/blob/15c3b0f2a8806dc1231a0131cc323fb536257057/source/css/skeleton.css#L295
Also, I can see there are plenty of hacks can be done within this theme, but usually they locates within skeleton.css, hope you can collect these customization and add options in config.yml
Good work!

Hi, yes you are right, the footer icons don't fit to the hover. And there are still a lot of customization that can be done with this theme. I will try to fix it for the next release. Thank you in advance, I will also wait for your PR if you wish 😁

Fixed at f96c7dda9e3cfbaad4df1575e01ac50b38f5b01a


Several bugfixes for improper closing of websocket and eventmachine

Couple of fixes to different issues in shut down logic that all lead to such errors in different scenarios:
RuntimeError: eventmachine not initialized: evma_install_oneshot_timer

There's a problem with shutting down strategy introduced in this commit:
https://github.com/litaio/lita-slack/commit/b27046fb13bbe59fc31ad27d0fdf16b63077f712
the shut_down method that has been added to :close callback on websocket, tries to close websocket itself, triggering shutdown logic twice and attempting to turn off the EM twice as well, with the second attempt failing. To make it happen only once, I've substituted it with direct EM shutting down command.
Websocket ensures to be closed itself, when EM, where it operates on, is shut down: https://github.com/faye/faye-websocket-ruby/blob/39e26115b39c83e923dc0656548fad52dd736956/lib/faye/websocket/client.rb#L85
And in the same time, websocket is not suited to receive close instruction outside the EM loop:
https://github.com/faye/faye-websocket-ruby/blob/39e26115b39c83e923dc0656548fad52dd736956/lib/faye/websocket/api.rb#L92
This leads us to necessity to check, whether EM is running before trying to close socket. I've added it.
Also, I consider this fix to be the most important one, since that's how Lita itself handles interrupts:
https://github.com/litaio/lita/blob/e9abbce2aed0a6659e96250bb6a0b576ec306fdd/lib/lita/robot.rb#L128
Shortly, it makes EM loop in lita-slack to finish and only after that, it runs the shut_down which will fail on exception with current implementation, since there no working EM anymore.
Fixed race condition in test for websocket through a proxy. Shortly, the url used there (http://foo:3128) made websocket throw exception here: https://github.com/faye/faye-websocket-ruby/blob/master/lib/faye/websocket/client.rb#L50 which immediately kicked off the shutdown procedure for the socket and after that, for the whole EM. Sometimes it has been forcing it to finish before the shutdown call in the test helper and also resulted in this error.
Also, bringing back a test, that has been removed, but which covered one of such cases:
https://github.com/litaio/lita-slack/commit/65e8b2f07a5b9017bc2bb962d7d7e855937cfa4a

Please, don't hesitate to contact me for clarifications.

Done.


test case for checking classes loaded from kcontainer ClassLoader

This test case will be incorporated by https://github.com/droolsjbpm/drools/pull/835


Remove round for create/delete database for 1000 times

I'm not sure what we testing here except our disk drives healthiness.

@rnewson do you remember why we had this?

nope, except to flush out race conditions. +1


front led ?

Is it possible to turn on the front flash instead of the rear?

Same question.Any solution?


More flexability to get totalCount within SqlDataProvider

I am using a SqlDataProvider and would like to be able to retrieve the totalCount property via other methods such as a callBack function or other...
For example, here is the example of how to use SqlDataProvider from the Yii2 docs:
$count = Yii::$app->db->createCommand('
        SELECT COUNT(*) FROM user WHERE status=:status
', [':status' => 1])->queryScalar();

$dataProvider = new SqlDataProvider([
        'sql' => 'SELECT * FROM user WHERE status=:status',
        'params' => [':status' => 1],
        'totalCount' => $count,
        'sort' => [
                'attributes' => [
                        'age',
                        'name' => [
                                'asc' => ['first_name' => SORT_ASC, 'last_name' => SORT_ASC],
                                'desc' => ['first_name' => SORT_DESC, 'last_name' => SORT_DESC],
                                'default' => SORT_DESC,
                                'label' => 'Name',
                        ],
                ],
        ],
        'pagination' => [
                'pageSize' => 20,
        ],
]);

You can see this does a COUNT in a query before the actual query within the SqlDataProvider that gets the actual data results.
However I would prefer to use SLC_CALC_FOUND_ROWS as this number is a more reliable method to get the correct number that matches the actual amount of rows returned by the query inside the DataProvider as it's possible that matching rows could get added or deleted between the COUNT query and the SqlDataProvider queries and hence I need something more reliable.
I could lock the tables, but I don't think that's such as wise idea, so I need to use SQL_CALC_FOUND_ROWS to get the correct amount.
Whilst this may seem like an unlikely scenario, it would be an issue on high volume websites with a lot of insert activity.
I'm not sure the best way to achieve this, but perhaps either by expanding the totalCount to allow callbacks to get the total count or by setting an option that you want Yii to automatically generate this value.
In addition to this, the same count should be made available to the totalCount property in the pagination instance.

It is better to create your own data provider for this case.
Such feature is not generic among different DBMS.


CM13 Stamina System

Description

In CM-13 there's 5 tiers of stamina for marines that gives you different effects based on the tier including paralyzing you at tier 5 (blinding, muted, stunned and knocked down.) With different messages.
Reproduction

Screenshots

Additional context

Made this more general since it's the whole system that needs porting.


UI updates

What does this PR do?

Modularize listing vote buttons
Moved vote buttons from ListingMetadata to ListingName for better UX
Place buttons after listing description for better UX flow
Add external link icons to docs navigation (Navbar and Sidebar)
Fixed sidebar URL routing to correctly navigate to bot pages
Updated the editing background to be black background with white text for the description and title
Fixed text color issue with the GDPR banner.

If this PR changes the UI, include a screenshot below.

nice!


Add Crafter CMS to the list

[X] verified that the CMS I'm adding is still maintained.
[X] read CONTRIBUTING.md.
[X] did not generate README.md.

Thank you, @russdanner!


Superseeded by 31783dfd . It is simpler I could wager faster, and, while it doesn't allow copy from anywhere to anywhere, it turns out we don't need copy from anywhere to anywhere.


[BUG] No validation of proper hostname format

Describe the bug
When entering a non-conformant hostname during installation the system never enters a Running state, its stuck at NotReady.
systemctl is-system-running is starting and the queued jobs is stuck at rancherd.
systemctl status rancherd gives an error printout about the hostname.
To Reproduce
Use a non-conformant hostname during install, e.g. Harvester
Expected behavior
"Error invalid hostname" or similar (e.g. the error output that rancherd prints).
It would also be nice if the queued jobs that are not yet completed are listed below the Status: line in the console.
Support bundle
Not needed
Environment:

Harvester ISO version: 0.3.0-preview1
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal

I can reproduce this issue and get error message as following:
> journalctl -u rancherd.service
# ...
Sep 27 02:47:27 Harvester rancherd[1821]: time="2021-09-27T02:47:27Z" level=info msg="[stderr]: The Node \"Harvester\" is invalid: metadata.name: Invalid value: \"Harvester\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')"

Tested in master-f38adc70-head. Fixed.

.


rtsp stream can normaly played in vlc,but failed to play in this program

here are the consle outputs:
INFO[2023-10-23T23:53:23+08:00] Client Full Exit                              ERRO[2023-10-23T23:53:34+08:00] Stream error restart stream stream no video   call=Restart INFO[2023-10-23T23:53:36+08:00] Run stream                                    call=Run channel=0 func=StreamServerRunStreamDo module=core stream=7a9ee681-c435-470b-a2d6-f320d2432d50 INFO[2023-10-23T23:53:36+08:00] Success connection RTSP                       call=Start channel=0 func=StreamServerRunStream module=core stream=7a9ee681-c435-470b-a2d6-f320d2432d50 ERRO[2023-10-23T23:53:56+08:00] Stream error restart stream stream no video   call=Restart INFO[2023-10-23T23:53:58+08:00] Run stream                                    call=Run channel=0 func=StreamServerRunStreamDo module=core stream=7a9ee681-c435-470b-a2d6-f320d2432d50 INFO[2023-10-23T23:53:58+08:00] Success connection RTSP                       call=Start channel=0 func=StreamServerRunStream module=core stream=7a9ee681-c435-470b-a2d6-f320d2432d50 ERRO[2023-10-23T23:54:18+08:00] Stream error restart stream stream no video   call=Restart INFO[2023-10-23T23:54:20+08:00] Run stream                                    call=Run channel=0 func=StreamServerRunStreamDo module=core stream=7a9ee681-c435-470b-a2d6-f320d2432d50 INFO[2023-10-23T23:54:20+08:00] Success connection RTSP                       call=Start channel=0 func=StreamServerRunStream module=core stream=7a9ee681-c435-470b-a2d6-f320d2432d50 ERRO[2023-10-23T23:54:22+08:00] stream not found                              call=HLSMuxerM3U8 channel=0 func=HTTPAPIServerStreamHLSLLM3U8 module=http_hlsll stream=7a9ee681-c435-470b-a2d6-f320d2432d50 ERRO[2023-10-23T23:54:24+08:00] stream channel codec not ready, possible stream offline  call=StreamCodecs channel=0 func=HTTPAPIServerStreamWebRTC module=http_webrtc stream=7a9ee681-c435-470b-a2d6-f320d2432d50 ERRO[2023-10-23T23:54:24+08:00] stream channel codec not ready, possible stream offline  call=StreamCodecs channel=0 func=HTTPAPIServerStreamMSE module=http_mse stream=7a9ee681-c435-470b-a2d6-f320d2432d50 ERRO[2023-10-23T23:54:24+08:00] <nil>                                         call=Close channel=0 func=HTTPAPIServerStreamMSE module=http_mse stream=7a9ee681-c435-470b-a2d6-f320d2432d50

Has the problem been resolved?

not yet :(
------------------ 原始邮件 ------------------
发件人:                                                                                "deepch/RTSPtoWeb"                                                                                @.>;
发送时间: 2023年10月31日(星期二) 下午4:01
@.>;
<EMAIL_ADDRESS>主题: Re: [deepch/RTSPtoWeb] rtsp stream can normaly played in vlc,but failed to play in this program (Issue #394)
Has the problem been resolved?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Facing the same issue, any guidance here?

Has anyone solved this problem yet? :(

I solved the problem.
The reason is codec of RTSP, RTSPToWeb only support H264 codec, if we give another codec it will return error.

I solved the problem. The reason is codec of RTSP, RTSPToWeb only support H264 codec, if we give another codec it will return error.

I was wondering about that, having the same issue... We're reading & processing raw camera video with opencv & then writing frames out to an rtsp server (mediamtx) via ffmpeg (the resulting rtsp streams look fine when playing  them in VLC player or ffmpeg). When we try to convert those streams with RTSPtoWeb, we were seeing "codec not supported" in logs. We weren't able to get h264 encoding to work with our opencv/ffmpeg container (it's been a struggle and i'm not sure why, still wrestling with that). Anyways, if this only supports h264 code that would explain why RTSPtoWeb can't convert.


[DO NOT MERGE][Testing]: Format-wise gallery

Demonstration of how we could have a matrix deployment over each formatwise key to ensure the data interface corresponding each one works as expected.
@h-mayorquin The doctests would be a great way to harness that, can you provide a command to run doctest on only a single file in the gallery here?

This command runs a single test for me:
pytest --doctest-glob="*.rst" docs/conversion_examples_gallery/recording/edf.rst

Replaced by #121


Write a Perl program to convert days to minutes

Description
Write a Perl program to convert days to minutes
1 day = 24 hours = 1440 minutes
Input  : 5
Output : 7200

How to contribute

Save the solution in convert_days_to_minutes.pl file
Add convert_days_to_minutes.pl file in convert-days-to-minutes folder

!assign


Create release-lifecycle.rst

Per Conversation in Community - Core team: https://community-release.mattermost.com/private-core/pl/seg438yjs3dm8mrmmd7h4ikaaa

@cpanato Can you check into the 'Build and deploy' step?  It seems to be hung.

@wiersgallak just sync with master and this pr fix the problem :)
this is because we move from travis to circleci


alt-tab : yabai -m space --focus recent not working

alt-tab : yabai -m space --focus recent doesn't seem to work with macos14.5 with the latest version of yabai and skhdrc. Could someone help me here on the what am I missing here

I am new yabai. Most of my other stuff are working like:
alt - r : yabai -m space --rotate 90
alt - f : yabai -m window --toggle zoom-fullscreen
alt - g : yabai -m space --toggle padding; yabai -m space --toggle gap
excepting this one alt - tab : yabai -m space --focus recent
I just installed yabai skdrc using brew and started the service - enabled yabai at login and accessbilty and as for the config - I tried to follow from config in the internet.
I am on Sonoma 14.5 and the following shows on my terminal when I run
csrutil status System Integrity Protection status: enabled.
yabai_tridib.err.log

Alright i had something similar like this happen to me before i figured it out
first you have to partially disable SIP
https://github.com/koekeishiya/yabai/wiki/Disabling-System-Integrity-Protection
then after that you are going to need to install the scripting additions
https://github.com/koekeishiya/yabai/wiki/Installing-yabai-(latest-release)#configure-scripting-addition
lastly make sure to uncomment the last line from the sudoers file
sudo visudo -f /private/etc/sudoers
it should read
#includedir /private/etc/sudoers.d
then reboot your mac


Invalid Remote File URI

Chef::Exceptions::InvalidRemoteFileURI
"https://chromedriver.storage.googleapis.com/2.21\n/chromedriver_linux64.zip" is not a valid source parameter for remote_file. source must be an absolute URI or an array of URIs.
It looks like when trying to use knife solo to prepare my instance, on line 69 of the default recipe the new version variable is adding a line break to the end.

That was fixed by #3. Upgrade to latest 1.2.1 release.

Thanks, much appreciated!


Typo in changelog for 7.2.x?

In the change log it states there is a new property called fullWidthRows and then it links to here
However there the docs explain the property embededFullWitdhRows. Is this the real property and the changelog is wrong?

docs update, will be on website next time we refresh the website. thanks.


Be able to pass in closure to advertise_service

Description

Would like to be able to pass in closures to advertise_service
By using a generic type F for the server function argument in advertise_service this allows us to pass in more than just functions, i.e. closures,
Would like to be able to pass in closures so that one can pass data through the closure to the callback that is executed by advertise_service
Updated the example code as well to show how it would work

Fixes
Issue Number: number

n/a

Checklist

[ ] Update CHANGELOG.md

Ahhh this is a really cool and very interesting change, and something I'd been playing with myself and debating what the right approach was.
I've been trying to figure out how to allow the service function itself to be async, since I'm pushing for an "async first" design style with this crate, but haven't yet figured out how to "do that right" giving evolving interfaces in the rust ecosystem.
Readings if you are interested here:

Good blog post summarizing design tradeoffs: https://smallcultfollowing.com/babysteps/blog/2023/03/29/thoughts-on-async-closures/
Current tracking issue for async closures in rust:
https://github.com/rust-lang/rust/issues/62290

I think what you've suggested is obviously better than what we currently have, perfect is the enemy of done, and in the future we can add an "advertise_async_service" alternative api if and when Rust stabilizes something.

Some small changes are requested to PR prior to approval:

Please run cargo fmt and commit the resulting lint fixes, our CI currently rejects code not formatted by cargo fmt.

Please add a short description of your change to CHANGLOG.md

Beyond that every looks good if it passes CI (we'll find out after lint is fixed). I'm also happy to make these small edit myself (if you've given me permission)

Ok sounds good - will do @Carter12s


coverage run: add a -o option

Add a way to specify the coverage filename manually for coverage run (option: -o) and correspondingly for the reporting commands and combine (-c, --input-coverage):
python3 -m coverage run -o output.coverage test.py
python3 -m coverage xml -c output.coverage -o -

Use case: I am writing an IDE plugin to integrate coverage.py, and I would like to use the python package unmodified. However, I'd like to avoid the creation of a .coverage file at the project root, and would instead like the coverage to be written to a file of my choosing (somewhere in the IDE's data directory).
This idea could (possibly) be taken further, if use cases are found (for my use case, the feature as implemented in this PR is sufficient), so I have not implement them here:

coverage erase could take a list of coverage files instead of only one (with this PR: via -c)
input-coverage for coverage run: allowing the coverage data of a previous run to be extended while writing to a new file (would require further core changes, introducing an input_data_file argument to the Coverage class)

I don't understand why tox (docs and quality/pylint) is failing.

Hi, thanks for doing this. It's been requested before (https://github.com/nedbat/coveragepy/issues/624), but I've relied on the COVERAGE_FILE environment variable to cover the need.
I haven't reviewed the code yet, though I think a --data-file option for both run and report would be the clearest way to expose it on the command line.
About the tests: I added some explanation to the tox.ini and the cmd.rst files in the latest commit on master.  Let me know if they help make it clear?

Thanks for the suggestion, I've changed the options to --data-file (I agree that it is less ambiguous than -c and -o). As for the tests, they run through on my machine, but there are some failing GitHub checks (I don't know if that is a problem), and I don't know why they fail.
I've somehow overlooked COVERAGE_FILE (I should have looked more closely at the docs), and that env var is actually a better solution for my use-case, since it won't require the latest coverage.py version for my plugin, so I no longer personally need this PR (though if you consider this feature worthwhile, I'll implement all suggestions you have).

I squashed these commits and merged them in commit ba884e41. Thanks for getting this over the line!

This is now released as part of coverage 6.3.  Thanks again! <3


Timestamp on the project folder

last accessed timestamp that can be used to sort the projects.
Moving up projects that are accessed recently.

Triaged away.


Create a Contact Us page

Please reach out to the design team for assistance here.

Hi @sheenarbw , how can I reach out to the design team to support on this


Middleware API lost in npm run build (possible Azure specific)

Description
When adding a middleware api to server/index.js it seems to get lost through the npm run build process.  There is a chance this is an issue specific to Azure.
Steps to reproduce
Add a custom middleware api to server/index.js.  Mine looks like the following:
...
const api = require('./middlewares/api');
...
app.use('/api', api);
...

Then my middleware API just has a basic token authentication bones in place:
...
router.post('/login', (req, res) => {
  const { username, password } = req.body;
  // For the given username fetch user from DB
  const mockedUsername = 'admin';
  const mockedPassword = 'password';

  if (username && password) {
    if (username === mockedUsername && password === mockedPassword) {
      const token = jwt.sign({ username }, 'worldisfullofdevelopers', {
        expiresIn: '24h', // expires in 24 hours
      });
      // return the JWT token for the future API calls
      res.json({
        success: true,
        message: 'Authentication successful!',
        token,
      });
    } else {
      res.json({
        success: false,
        message: 'Incorrect username or password',
      });
    }
  } else {
    res.json({
      success: false,
      message: 'Authentication failed! Please check the request',
    });
  }
});
...

Then upload to an Azure Node.js app service following these steps: https://docs.microsoft.com/en-us/azure/app-service/containers/quickstart-nodejs
Expected behavior

[x] I should be able to use a tool like Postman to interact with this API during development:

POST /api/login HTTP/1.1
Host: localhost:3000
Content-Type: application/json
Cache-Control: no-cache
Postman-Token: e56ca744-0af7-f005-3dbd-10a4dec0dbe7

{
 "username": "admin",
 "password": "password"
}

[ ] I should be able to use Postman to perform this same API call to the deployed build code:

POST /api/login HTTP/1.1
Host: MYSERVERNAME.azurewebsites.net
Content-Type: application/json
Cache-Control: no-cache
Postman-Token: bd42e331-5c47-dc15-b8a0-a59f14f64295

{
 "username": "admin",
 "password": "password"
}

Error: The resource you are looking for has been removed, had its name changed, or is temporarily unavailable.
Versions

React-Boilerplate: 4.0.0
Node/NPM: 10.13.0 locally
Browser: N/A

How is Azure serving your code?  If you don't, then Azure is serving your code by itself without using your express server at all. (That's the most common case for deploying an SPA IME.)

I believe it serves the code up by itself until you put in a web.config that tells it to use iisnode instead.  In that link I had with the steps for publish a Node app to Azure they reference a GitHub project at https://github.com/Azure-Samples/nodejs-docs-hello-world and it has a web.config within per the following:
<?xml version="1.0" encoding="utf-8"?>
<!--
     This configuration file is required if iisnode is used to run node processes behind
     IIS or IIS Express.  For more information, visit:

     https://github.com/tjanczuk/iisnode/blob/master/src/samples/configuration/web.config
-->

<configuration>
  <system.webServer>
    <!-- Visit http://blogs.msdn.com/b/windowsazure/archive/2013/11/14/introduction-to-websockets-on-windows-azure-web-sites.aspx for more information on WebSocket support -->
    <webSocket enabled="false" />
    <handlers>
      <!-- Indicates that the server.js file is a node.js site to be handled by the iisnode module -->
      <add name="iisnode" path="index.js" verb="*" modules="iisnode"/>
    </handlers>
    <rewrite>
      <rules>
        <!-- Do not interfere with requests for node-inspector debugging -->
        <rule name="NodeInspector" patternSyntax="ECMAScript" stopProcessing="true">
          <match url="^index.js\/debug[\/]?" />
        </rule>

        <!-- First we consider whether the incoming URL matches a physical file in the /public folder -->
        <rule name="StaticContent">
          <action type="Rewrite" url="public{REQUEST_URI}"/>
        </rule>

        <!-- All other URLs are mapped to the node.js site entry point -->
        <rule name="DynamicContent">
          <conditions>
            <add input="{REQUEST_FILENAME}" matchType="IsFile" negate="True"/>
          </conditions>
          <action type="Rewrite" url="index.js"/>
        </rule>
      </rules>
    </rewrite>

    <!-- 'bin' directory has no special meaning in node.js and apps can be placed in it -->
    <security>
      <requestFiltering>
        <hiddenSegments>
          <remove segment="bin"/>
        </hiddenSegments>
      </requestFiltering>
    </security>

    <!-- Make sure error responses are left untouched -->
    <httpErrors existingResponse="PassThrough" />

    <!--
      You can control how Node is hosted within IIS using the following options:
        * watchedFiles: semi-colon separated list of files that will be watched for changes to restart the server
        * node_env: will be propagated to node as NODE_ENV environment variable
        * debuggingEnabled - controls whether the built-in debugger is enabled

      See https://github.com/tjanczuk/iisnode/blob/master/src/samples/configuration/web.config for a full list of options
    -->
    <!--<iisnode watchedFiles="web.config;*.js"/>-->
  </system.webServer>
</configuration>

Some additional insight - I just signed up for a Heroku account and everything works perfectly there so this is definitely an Azure specific issue.  Perhaps there are feature limitations to iisnode coming into play here as well.  I am going to try to create the resource out there a bit differently and see if I can get a pure node environment as opposed to iisnode - will report back.

Ok, confirming it here - the issue is resolved if the correct type of resource is created on Azure.  So for any future folks searching for this, DO NOT follow the instructions posted at https://docs.microsoft.com/en-us/azure/app-service/containers/quickstart-nodejs if you are looking to host your react-boilerplate project.  Instead, manually create a resource from their marketplace listed as 'Web App' and select one of the node versions for the runtime stack.  Then I deployed using local Git by selecting that from the Deployment Center, set up my user name and password, and then ran the following commands from the root of the source folder (not the build subfolder):
git remote add azure https://MYSITE.scm.azurewebsites.net:443/MYSITE.git
git push azure master

I saw all of the same scripts running (including the npm run build) as on Heroku using this methodology.  I will do a pull request to update the documentation on deployment to add an entry for Azure.


Bulwark Shard Relic replaced by Artifact glitches the Act IV boss fight.

Describe the bug
Final fight skips after picking up artifact which replaces all relics, and the relic to access Bulwark's Ambry is replaced.
To Reproduce
Steps to reproduce the behavior:

Go to Bulwark's Ambry
Select the artifact which replaces all relics every few floors (the name escapes me atm)
Do the elite fight, and have all the relics replaced.
The final fight will be unselectable. If you save and quit the game, and reload, you will get the ending screen as though you had beaten the boss fight in act IV, and it will say "No artifacts selected".

Expected behavior
Expected that we would either be able to proceed with the Bulwark's Ambry fight, as Act IV has already been transformed, or it would be replaced with the standard Act IV heart fight.
Screenshots
Could not get a screenshot, unfortunately.
Additional context
Seems very similar to the bug where the relic was deleted by Egocentrism.

The fix will be pushed soon. Thanks for the report!


docs: updated link

This PR only fixes a dead link.

I cannot merge myself since I don't have write access to this repository.


Create MaterialAboutToggleItem

Hi! Is it possible to set a toggle state programmatically?
It looks like MaterialAboutToggleItem doesn't have such method.
I have a case when I should set toggle back depending on user answer. Like if user toggles “set fullscreen”, then we show him permission dialog and if the user denies to give the permission, we uncheck the toggle back programmatically.

MaterialAboutToggleItem? Don't think I've created one of these - is it in a forked library. I've actually wanted to implement some items like this so that people can use the library as a settings page also.

Hi, this functionality has been implemented in a fork at by @filol here: https://github.com/filol/material-preference-library

@daniel-stoneuk Perhaps you can close this issue as it was merged?

@Robyer we haven't merged it into the main branch yet since it's performance is pretty terrible.

@daniel-stoneuk Aha, I saw on the MaterialPreferenceLibrary notice that that library is deprecated now as it was merged to MAL.
And can you be more specific? What kind of performance issues are there?

Also, I'm comparing the changes between your branch and master and I noticed some weird things:

why is there new INTERNET permission in AndroidManifest?

why is there areContentsTheSame method that calls getDetailString() to create big string representations of the objects and then compares the two strings? Why not just properly implement equals() method in first place?

if the performance issues you are talking about are when you set checked listener and then deny the checked state as in that example, it is caused by this: we are setting this.aCheckBox.setOnCheckedChangeListener(, but this is called always, when the internal checked state changed, i.e. even when it is programatically changed by calling "setChecked". So in example here we are inside checked change listener, and here we call setChecked(true) again, which will as a result call our checked change listener again, where we will again call it... Also notice that we return false from this method (to notify that we don't want to allow the change). So we may just remove that manual call to switchItem.setChecked(true); and theoretically it should work. BUT it is implemented here with the same infinite recursion problem - if user returns false, then we call the setChecked(!isChecked) which in turn again calls our own listener, where we call that again... (second infinite recursion). Thing why it won't end up in app crash is that there is the check for buttonView.isPressed(), so the infinite recursion is going on as long as you hold your finger on the screen. So that code must be reworked...

why is there areContentsTheSame method that calls getDetailString() to create big string representations of the objects and then compares the two strings? Why not just properly implement equals() method in first place?

Yep spot on with the edit, and you're right. We should implement a function to compare just the visuals - generating the strings and then comparing them is probably quite slow and wasteful. I've created issue #91. Probably won't get round to fixing this until after my University interview in a couple weeks.
The performance issues I was noticing was during scrolling. Lots of frames are dropped, which doesn't really give a good user experience. Because of this, I didn't clean up the PR too much & kept it in a separate branch. I think part of this is due to the inherent performance issues that come with using nested RecyclerViews - I knew from the start that this wouldn't be a great idea for scalability, however it seemed most practical & I didn't want to include library like groupie, which might struggle to display a cardview beneath the items. Another perk of the nested RVs is the ability to use custom adapters like LicenseAdapter.
Would you say the fixes you've made are ready to be merged? Thanks very much for the commits - as I mentioned, I don't have much free time right now but in a couple weeks should be able to put more work into it if required.

@daniel-stoneuk As I now tried it, the bad performance during scrolling really seems to be caused by the nested RecyclerViews - it can be seen when you scroll down slowly, when the Custom Adapter should be drawn, it lags for some hundreds of milliseconds. So problem is not in the checkbox/toggle.
I think the preferences branch could be merged (as it is not the cause of bad scrolling performance), but the feature should be improved in the future - e.g. configure on click listener to whole row so it will change checkbox/toggle when clicking anywhere on the row. Or also I think changing the row checked state programatically won't work. But that is related only to new 2 items, everything in library should work same as before, that why I think you can merge it.


[Minor] Possible to make a hang while integration test

There are three status of completion of paragraph.run. with Status.FINISHED only, that makes tests hang because other status returns. Fast fail will help to fix it.

Looks good to me.

Ready to merge

Looks good to me


[GHSA-h755-8qp9-cq85] protobufjs Prototype Pollution vulnerability

Updates

Affected products

Comments
https://github.com/m-honarzade/guessNumber-App
https://github.com/m-honarzade/realtor-clone-site

Hi @m-honarzade, this pull request does not make any changes to GHSA-h755-8qp9-cq85. Were there any changes you wanted to make that did not appear correctly in the PR?

👋 This pull request has been marked as stale because it has been open with no activity.  If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.


Activity bar empty space

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Version: 1.84.0-1
OS Version: Arch Linux 6.5.9-arch2-1

Steps to Reproduce:

Download new VSCode update version 1.84.0.
Set "workbench.activityBar.location": "hidden" in the settings JSON file.
Look at the right side of vscode, the activity bar is hidden, but empty space for it is preserved, and it looks ugly.

Maybe #197428
/assign @sandy081

Maybe #197428
/assign @sandy081

I think it is related, but I don't need even to do the second step described here #197428

Open the command palette and activate View: Focus activity bar

It always has an empty space when the activity bar is hidden, and sometimes vscode ignores my setting (hiding the activity bar in setting.json file) and shows it.

Please diagnose the root cause of the issue by running the command F1 > Help: Troubleshoot Issue and following the instructions. Once you have done that, please update the issue with the results.
Happy Coding!

@untainsYD I am not able to reproduce the issue without the step Open the command palette and activate View: Focus activity bar - Can you please confirm by following F1 > Help: Troubleshoot Issue

@untainsYD I am not able to reproduce the issue without the step Open the command palette and activate View: Focus activity bar - Can you please confirm by following F1 > Help: Troubleshoot Issue

Type: Bug

Issue troubleshooting has identified that the issue is with Visual Studio Code.

see https://github.com/microsoft/vscode/issues/197447
VS Code version: Code 1.84.0 (d037ac076cee195194f93ce6fe2bdfe2969cc82d, 2023-11-01T11:28:21.782Z)
OS version: Linux x64 6.5.9-arch2-1
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz (8 x 3192)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 0, 0

Memory (System)
15.57GB (12.25GB free)

Process Argv
--unity-launch --enable-accelerated-video-decode --user-data-dir=/home/untainsYD/.config/Code/data --extensions-dir=/home/untainsYD/.config/Code/extensions --crash-reporter-id c502b379-21a4-40bd-a0eb-48c5dcf7f303

Screen Reader
no

VM
0%

DESKTOP_SESSION
undefined

XDG_CURRENT_DESKTOP
sway

XDG_SESSION_DESKTOP
sway

XDG_SESSION_TYPE
wayland

Extensions: none
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30880072
38873714:30881509
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
f6dab269:30613381
a9j8j154:30646983
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30882110
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
synctok:30869157
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixtcf:30871695
pythonregdiag2:30871582
pythonmypyd1:30879173
pythoncet0:30874138
pythontbext0:30879054
dsvsc016:30880769
dsvsc018cf:30880895
aa_t_chat:30882232

Are you able to repro this with empty profile? If not, please try to come up with a minimal set of settings you need to have to reproduce this and share those settings?

@sandy081 I noticed @untainsYD is on Arch Linux, so perhaps this is a different build of VS Code from the one you and I use.

@gjsjohnmurray i am using a proprietary Microsoft-branded release/build, here is the link.

Are you able to repro this with empty profile? If not, please try to come up with a minimal set of settings you need to have to reproduce this and share those settings?

Is there any option to run in profiless mode, like debug mode, or should i just move my vscode settings/config folder with profiles and instantiate the new one?

I think this issue only happens in non-macOS systems (I don't know on windows) but I can reproduce the issue in Ubuntu (work computer) but not in MacOS (personal computer) as happens with the option for moving the Activity Bar to the top, it works in MacOs but not in my Ubuntu (I know is not related).

Is there any option to run in profiless mode

F1 > Profiles: Create Profile
On Activity Bar change the position to top

Check if you can reproduce.

F1 > Profiles: Create Profile

Alternatively: Profiles: Create a Temporary Profile

Much better 👍

Check if you can reproduce.
Yes, i can, i have created a new profile, and as you said, the same bug occurs.

@deepak1556 May I know if we support this platform - Arch Linux 6.5.9-arch2-1 ?

Yes we support the platform, the official arch package is community maintained but it just wraps our production build using arch specific packaging steps.

@untainsYD Can you please check if you see any errors in the following places?

F1 > Toggle Developer Tools > Console
F1 > Open View... > Window

@sandy081

F1 > Toggle Developer Tools > Console

F1 > Open View... > Window

Thanks for sharing information. No errors in the console 🤔
Can you please try launching VS Code using fresh user data dir and extensions dir and see if you can still reproduce? From CLI
code --user-data-dir <new-folder> --extensions-dir <new-folder-2>

code --user-data-dir <new-folder> --extensions-dir <new-folder-2>

No, it's working fine, i have set custom workbench options like:
{
    "window.dialogStyle": "custom",
    "window.titleBarStyle": "custom",
    "workbench.activityBar.location": "hidden"
}

But it still works fine.

So, should i remove my data/plugins and make clean installation?

@sandy081 ok, i removed those user folders and made a clean installation,  now it is completely broken, now alt bar, activity bar is preserving space, and a lot of errors in console:

Thank you, @sandy081, for your assistance. While I may not fully understand the inner workings, I successfully resolved the issue.
I removed the default settings, including the default user profile settings (default profile), and deleted all other profiles. Then, I recreated them from scratch, ensuring that I applied "workbench.settings.applyToAllProfiles": [...] settings shared between profiles. I also applied extensions to all profiles that needed sharing and configured each profile with specific settings tailored to its requirements. This resolved the problem, looks like the Default profile had some conflicting settings with all others, and it had been breaking up the vscode.
I don't now the root of the issue, so if you want you can close it.


Replace erroneous reference to DaisyUI

Readme incorrectly mentions DaisyUI as one of the "features" of the project, despite the paragraph above mentioning Magic UI has replaced Daisy. This PR fixes that.

Thank you 🤙


Restrict highlighting of verbatim to standalone Yul

It turns out that verbatim currently only exists in standalone Yul, not in Solidity assembly.  So, I restricted it to standalone Yul.  We can revert this commit later if verbatim is eventually brought to Solidity assembly, which I believe is planned.
Also I upped the timeout on the test of verbatim, because it was timing out when I ran it locally (probably due to being in a meeting at the time :P ).

Not sure what you mean... I linked to that issue?  Is there something additional I should do there?


Add new congis please

All the configs are broken on android and IOS. please add new ones. Thanks in advance.

yes! please don't forget us:/


Cannot connect to Vsphere VM

I have created a module for Rancher2 to be used in both an AWS and an OnPrem solution that uses Vsphere. The module I have created uses ssh_resource without any sort of problems in AWS. Vsphere however is struggling to get working.
In both scenarios, I generate an ED25519 key in the terraform and have loaded it onto the vm using a remote_exec.
resource "tls_private_key" "global_key" {
  algorithm = "ED25519"
}

After that, I would expect to be able to use the ssh_resource without problems, but it just keeps giving the vague result:
Error: execution of command 'echo 'hello world'' failed. stdout output

   with module.rancher_common.ssh_resource.run_command,
   on ..\..\Common\RancherCore\main.tf line 34, in resource "ssh_resource" "run_command":
   34: resource "ssh_resource" "run_command" {

The strange thing is that the remote-exec using the same key works just fine. See my code below:
resource "null_resource" "run_command" {
provisioner "remote-exec" {
    inline = [
      "echo 'hello world'",
    ]
    connection {
      type        = "ssh"
      user        = "******"
      private_key = var.ssh_private_key_pem
      host        = var.node_public_ip
      timeout     = "5m"
    }
  }
}

resource "ssh_resource" "run_command" {
  host = var.node_public_ip
  commands = [
    "echo 'hello world'"
  ]
  user = "******"
  private_key = var.ssh_private_key_pem
}

Any idea what might be happening here?

@jcomish can you set debug_log (https://registry.terraform.io/providers/loafoe/ssh/latest/docs#debug_log) and see if there is more info availble there? It could be a compatibility issue with the key, not sure.

Here is the contents of the log:
command: echo 'hello world'
done: true
stdout:
hello world

stderr:

command: echo 'hello world'
done: false
stdout:

stderr:

error: dial tcp xx.xx.xx.xx:xx: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

I just noticed that I am embarrassingly out of date - v1.0.1
But it looks like newer versions of the provider is not available for windows.

I managed to upgrade the module manually and gave a timeout of 15 minutes. Still immediately fails with the same error.

For some reason, v2.2.1 was not installing on a terraform init -upgrade. That wouldn't install anything beyond v1.0.1.
I did manually install with the same error, so that isn't the problem.

Any idea if I can workaround this? I am now on the latest version, but the problem persists.

@jcomish not able to reproduce this locally. I did Google a bit and it seems that specific error only happens in context of Windows environments. Are you running Terraform on Windows? And if so, do you have the ability to try it on Linux? (e.g. WSL2) -- Unfortunately I don't have access to Windows

I have done some additional testing and found that it will work if I run the terraform again. Something must be going on with the state of the new machine.
Still strange that null_resource will immediately connect, but ssh_resource does not. I am still investigating the root cause.

I now have it working. It appears that Terraform was starting the module I was running with the ssh_resource before the machine was finished with ssh configured.
The reason that the null_resource did work is that it would retry until the specified timeout. ssh_resource was immediately failing instead of retrying. Would it make sense to have a variable to enable retry until timeout within the ssh_resource as well?

@jcomish yes definitely makes sense. I think there is an existing ticket for this #31 -- I'll look into this over the weekend

Excellent, tha k you for your help, and great job with this!


Make the repository public

Verify if the image can be created without the use of nvidia base image.

Completed