filter: dateFilter() not working with Date type

I am fetching data from remote server with a function demo as can be seen in codesandbox at line 9. But when I try to create a new date type that is what filter: dateFilter() takes as input, it crashes.
The problem basically is that it doesn't wait for the async setState of the fetched data from server, before it tries to put the filter and I get the following error:
react-dom.development.js:12299 Uncaught TypeError: Cannot read property 'dateBgn' of undefined
as I have a did Mount flag checking if it has mounted. I have put flags, but it keeps on happening:
componentDidMount(){
	this.getMahList('http://localhost:8080/blahblah')
}

componentWillUnmount() {
	this._isMounted = false;
}

codesandbox: https://codesandbox.io/embed/error-with-datefilter-j2l37?fontsize=14&hidenavigation=1&theme=dark
I try and follow the demo from storybook: https://react-bootstrap-table.github.io/react-bootstrap-table2/storybook/index.html?selectedKind=Column Filter&selectedStory=Date Filter&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

Basically what could help me is if you could tell me how filter: dateFilter() does function. I  think it tries to render the table before the data is fetched from the server, in that case is there something you recommend doing ?


Enabling self Healing in my python code.

I am trying to implement an trading module using python-binance. I am currently having difficulties in making this a fail safe / self-healing code. Below is the scenario I am trying to address:

There is a main script which will start seperate thread for a binance monitor.
That binance monitoring class will create the binanceSocketManager object and subscribes to several websocket streams of a given currency.
If by any chance, this Binacnemontior(the helper thread which is started by the main block) is killed / died, the main thread will try to start a fresh thread again.
At this point, the binance monitor is not getting any data(after the thread is restarted) from the binance server and my program is just waiting for the response and doing nothing.

Below is the main method code:
while True:
        for exchange in exchanges_list:
            if exchange in threads_dictionary:
                if threads_dictionary[exchange] is not None:
                    # Check if the thread is alive
                    if threads_dictionary[exchange].is_alive():
                        print(exchange," is still running")
                    else:
                        print("Restarting the thread for ", exchange)
                        #del threads_dictionary[exchange]
                        #threads_dictionary[exchange] = helpers_mapping[exchange](tid)
                        threads_dictionary[exchange].run()
                        tid += 1

            else:
                print("Starting a fresh thread for ", exchange)
                threads_dictionary[exchange] = helpers_mapping[exchange](tid)
                threads_dictionary[exchange].start()
                tid += 1

Below is the Binance helper I am currently using:
class BinanceCollector (threading.Thread):
    def __init__(self, threadID):
        # The initialization section of the class. We will initialize the keys
        try:
            print("Started the thread binance")
            self.api_key = secrets.Binance_API_Key
            self.api_secret = secrets.Binance_API_Secret
            self.website_name = "Binance"
            self.threadID = threadID
            self.client = Client(self.api_key, self.api_secret)
            #pprint(self.client.get_exchange_info())
            self.symbols_list = []
            for i in self.client.get_exchange_info()['symbols']:
                self.symbols_list.append(i['symbol'].lower()+"@depth")
            pprint(self.symbols_list)
            self.bm = BinanceSocketManager(self.client)
            self.bm.start()
            threading.Thread.__init__(self)

        except Exception as e:
            print(e)

    def helper(self):
        count = 0
        conn_key = self.bm.start_trade_socket('BNBBTC', process_trade_message)
        # diff_key1 = self.bm.start_depth_socket('BNBBTC', depth_message_processor)#, depth=BinanceSocketManager.WEBSOCKET_DEPTH_20)
        # diff_key2 = bm.start_multiplex_socket(['bnbbtc@depth'], depth_message_processor)
        # diff_key3 = bm.start_multiplex_socket(self.symbols_list, depth_message_processor)
        #help(config.binance_manager)
        # self.bm.start()
        # self.bm.run()
        count  = 0
        while True:
            count += 1
            print("Count = ", count)
            if count >= 3:
                print("Killing the thread now")
                self.bm.stop_socket(conn_key)
                self.bm.close()
                # bm.stop_socket(diff_key2)
                # bm.close()
                # reactor.stop()
                return
            time.sleep(3)
        return

    def run(self):
        print ("Starting " + self.website_name)
        self.helper()
        print ("Exiting " + self.website_name)

The problem is due to the BinanceSocketManager. Debugging it further to identify the error causing logic.


update: drawer header title tabindex

{{ title }}
Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

发现光改 title 的tabindex 不行，焦点还会跑按钮上、跑其他地方去


Add multiple interface editing

Would it be possible to add the option to edit multiple interfaces? I've had a case where I accidentally selected the wrong form factor on a device with 48 ports, it would be a nice addition to be able to select multiple ports to change the form factor.
Thank you!

This was added in 0da3661 and c09cb5d.


Add undocumented dependency to ROS Bag tutorial

After following the steps on this tutorial, I was unable to execute the ros2 bag record ... command. I received the following error:
Failed to load entry point 'record': libconsole_bridge.so.1.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
  File "/home/abell/Repositories/ros2_galactic/install/ros2cli/bin/ros2", line 11, in <module>
    load_entry_point('ros2cli', 'console_scripts', 'ros2')()
  File "/home/abell/Repositories/ros2_galactic/build/ros2cli/ros2cli/cli.py", line 39, in main
    add_subparsers_on_demand(
  File "/home/abell/Repositories/ros2_galactic/build/ros2cli/ros2cli/command/__init__.py", line 250, in add_subparsers_on_demand
    extension.add_arguments(
  File "/home/abell/Repositories/ros2_galactic/build/ros2bag/ros2bag/command/bag.py", line 26, in add_arguments
    add_subparsers_on_demand(
  File "/home/abell/Repositories/ros2_galactic/build/ros2cli/ros2cli/command/__init__.py", line 237, in add_subparsers_on_demand
    extension = command_extensions[name]
KeyError: 'record'

Following the steps in the page linked above resolved this issue for me. Just wanted to add this to the tutorial in case other beginners with ROS2 run into this error and are unsure of what to do to proceed.

Can you give more details on how you installed ROS 2?  This shouldn't be necessary, as rosbag2_storage_default_plugins depends on pluginlib which depends on class_loader which depends on libconsole-bridge-dev.

Can you give more details on how you installed ROS 2? This shouldn't be necessary, as rosbag2_storage_default_plugins depends on pluginlib which depends on class_loader which depends on libconsole-bridge-dev.

I followed the steps documented here.
I did notice that I had the libconsole-bridge-dev package, but it seemed like there was a version misalignment. If you see the error above, ros bag record ... required libconsole_bridge.so.1.0. The version I had installed as a result of the installation process linked above was libconsole_bridge.so.0.2.5.

I did notice that I had the libconsole-bridge-dev package, but it seemed like there was a version misalignment. If you see the error above, ros bag record ... required libconsole_bridge.so.1.0. The version I had installed as a result of the installation process linked above was libconsole_bridge.so.0.2.5.

What platform are you installing ROS 2 on?  I ask because I would have expected you to have libconsole_bridge.so.0.4 installed.  Either way, though, the system should have picked up our vendored copy of libconsole_bridge.so.1.0 in the local ROS 2 directory.  The fact that it didn't suggests that something else is wrong.

No response to the latest question here for quite a while, so I'm going to close this out for now.  Feel free to respond to my latest question and reopen.


Rancher k8s upgrade: K8s v1.24 & Rancher v2.6.9

Updated Rancher Version to 2.6.9
Changes as per K8s v1.24

Updated HPA to autoscale/v2
Updated Cron to batch/v2

Upgrade the cloud init scripts with new rancher version @pranavv0

@pranavv0 also upgrade cloud init scripts in aws

Tasks remaining @pranavv0

[ ] Use azure file csi instead of azurefile in-tree as its depreciated
[ ] Add ebs-csi-storage-class in example aws resource values and remove ebs-storage-class as its depreciated
[ ] Upgrade Nginx ingress as it uses depreciated PSP , PDB
[ ] Upgrade cloud init scripts in aws

@pranavv0 please merge the master branch to ur local branch and resolve conflicts. Also please cherry pick commits and pull another PR at 4.0.0 branch

We no longer using databroker manifest files, use helm files


[WIP] Address security vulnerabilities

@ccaominh if you're considering a Guava upgrade, check out https://github.com/apache/incubator-druid/issues/6942, #6948, maybe others. I believe it is likely to cause compat issues w/ Hadoop.

This is superseded by other PRs (e.g., https://github.com/apache/incubator-druid/pull/8980)


Hello please contact me.

Type: Bug
Hello, I wrote an auto clicker and I installed plugins like pyinstaller, cx_Freeze, py2exe to convert it to exe file (from cmd.) and none of them work, I keep getting the same error please help me.
The error: pyinstaller : The term 'pyinstaller' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1

pyinstaller --onefile deneme.py

  + CategoryInfo          : ObjectNotFound: (pyinstaller:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException

VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.19045
Modes:

@requim111 none of those (pyinstaller, cx_Freeze, py2exe ) seem to be extensions for VS Code. You should better ask the Python community on StackOverflow for help since this repository is about features that are owned by VS Code.


[CI/Build] Support compilation with local cutlass path (#10423)

Could you mention this in the documentation somewhere? Maybe in the build from source section https://docs.vllm.ai/en/latest/getting_started/installation.html#build-from-source

hi，I updated the doc, but I don't know how to preview the changes. Please review it.

Please merge from main to fix the CI failures.

Hi, I've updated to the latest version, but there are still some failures. I'm not sure if they are related to my patch. Could you take a look?


bug: [React] dropdown - after dismissing dialog opened from dropdown, focus is returned to label element, reopening dropdown

What version of daisyUI are you using?
3.9.3
Which browsers are you seeing the problem on?
Firefox
Reproduction URL
https://play.tailwindcss.com/JGN0l5uIdN
Describe your issue
I attempted to reproduce it in the link above, but it doesn't work. perhaps it is something specific react is doing under the hood for tabIndex/ focus? i have checked and neither component is rerendered, so its just a head scratcher.

interestingly, i was able to fix it by switching from a to button for the dropdown items. i think it is the presence of a with empty href which is causing the focus to return when dismissing the dialog.

The code works as expected:
https://stackblitz.com/edit/daisyui-nextjs-22ximc/?file=pages%2Findex.js
I just removed that e.preventDefault() and changed onclick to JSX syntax.
So I think the issue is somewhere else. daisyUI is just CSS style so I'm going to close this issue but feel free to continue the conversation. Let me know if I can help.


Clean-up userdata scripts and testdata

What this PR does / why we need it:
Follow up of PR of https://github.com/kubermatic/machine-controller/pull/759 bringing some clean-up.
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Optional Release Note:

NONE

/retest

@irozzo-1A "Clean-up ubuntu" took you too far away :D
Please drop parts with coreos/flatcar

@irozzo-1A "Clean-up ubuntu" took you too far away :D
Please drop parts with coreos/flatcar

I agree that this PR is not very cohesive, but I don't consider dropping this a good option. This part was functional to the cause as it avoided me to apply the exact same fixes twice.
I could extract it to a new PR and merge it before this one, but it would cost me some effort as I have to adjust the testdata.
Could you please clarify what's the problem with this concretely speaking?

/retest


Reset Setting to Default

Is your feature request related to a problem? Please describe.
It is frustrating to try testing setting defaults because as soon as the setting exists, that default is not applicable.
Describe the solution you'd like
A button which allows a given setting to be 're-set' to the default on the module settings page.
Describe alternatives you've considered
Something which allows a key to be entered or even autocompleted that would let this work for non-config-able settings.

this lets you set a setting to its default:
game.settings.set('gm-screen', 'rows', game.settings.settings.get("gm-screen.rows").default)


Cannot switch between Keypress and Key Toggle behaviors

Trying to switch between them directly does not work. You need to switch from one to an intermediary behavior first, then you can change to the other.

@Nick-Munnich Can you please give the deploy preview from #62 a try? TIA.

Yep, fixed by #62.


Dig before curl in tests

Proposal
Right now we don't dig test domains to ensure they resolve, before attempting to curl with timeout.
We should dig to ensure that the domains resolve, and fast fail if they don't.
Background
We can't curl a domain that doesn't resolve. This can save CI time, and assist debugging.

Closed by #381


Can't add package

I'm using the Xcode 16 beta

Don't know what's the issue. Provided the full log, maybe something about your deployment target or version limit.
I tried and it works.

I also get this error, in target deployment target 16.0 , version limit 3.1.2. @repoluhun how you fix this?

I also get this error, in target deployment target 16.0 , version limit 3.1.2. @repoluhun how you fix this?

Imma be honest with you I just dropped the package and quit the project I was working on lmao

I work on multiple projects, they are on same target version. But one of them got this library, but other one did not get. This is interesting.

I work on multiple projects, they are on same target version. But one of them got this library, but other one did not get. This is interesting.

Yeah, I could honestly not tell you

Because I can not reproduce this issue on my own demo, I can zip and send it here.
Can you zip your example project to me and have a check ? Because if I can not reproduce a issue, nothing can be done to fix it.

Here:
SDWebImageSwiftUIDemo.zip
Fetched successfully.

Hi, I had "&" in the name of the project and when I change it, it is works  :D, but not sure that was the issue.


undefined download folder

Hi,
Sometimes the download folder is set to "undefined" and file are downloaded into /undefined

The folder are created automatically.
I haven't found how reproduce the bug voluntariamente.

I'm sorry, so late to reply.
You can enter the path you want to save.


Performance fixes

This makes sure the performance parameter is passed to the tracks command even if it is null, because null is meaningful (you may have an album where one version of the work has performance populated and a second one doesn't).
It also sets performance to -1 to indicate all performances (null or not) when browsing "all tracks".
It requires the latest https://github.com/LMS-Community/slimserver/pull/1109 to work properly. (This is now ready to go and also includes the fix to return work_id in the status command response.)
PLEASE make sure I've got this right and haven't broken anything else.
BTW, in testing I found that adding all tracks to the playlist using the buttons in the header is adding all tracks in the library when used from a Works--All Tracks list. This  happens without these changes, but I wouldn't have a clue where to start looking for the bug: JSON request is:
JSON REQ: ["00:04:20:12:4b:74",["playlistcontrol","cmd:add","currentaction:3"]]

Done it again - wrong base. Closing this one will recreate.


chore: update jest-environment-testenv-recycler integration test runner

:tada: This PR is included in version 5.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature request: Custom Mapping default value

Description
A default value for custom mapping could be great, especially for boolean custom mapping (that could be undefined)
I can propose something like :
"mapping": {
"1": "Checked",
"true": "Checked",
"0": "Unchecked",
"false": "Unchecked",
"default": "Not defined"
}

Thanks for raising it, seems like a nice feature to implement. We will take care of that and release in 2 weeks.

Resolved in v.5.49.0

table: allow to define default value for custom mapping via "[[default]]" (docs)


The request message Response now reflects the redirected url

The following code gives you the redirected url. This fixes ModernHttpClient on iOS to do the same.
var response = await client.GetAsync(url,HttpCompletionOption.ResponseHeadersRead);
response.EnsureSuccessStatusCode();
var redirectUrl =  response.RequestMessage.RequestUri.ToString();

Good catch. Does this bug exist on Android as well?

Haven't tested it yet on Android.

@paulcbetts Just pushed the fix for Android as well.

Thank you thank you!


Handle empty Leaderboard case

When there is no leaderboard available for a given realm and a given timeframe we should show the placeholder

Let's not let this block.

Empty leaderboard is using the old image as a placeholder and I think it is fine for now, please reopen @VladUXUI when you'll have new image for empty leaderboard


Flows stopped due to missing node types.  ui_artlessgauge

In manage palette having message:
node-red-contrib-ui-artless-gauge
0.3.11
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined (line:1192)

I have two installations of node red (with dashboard) and if i install your node into node-red where no "path" parameter is set - the node works fine.

I was my mistake, in the second node red installation I'm declared middleware variable and did not declare path variable at all...


Handle nested structs

The app does not handle nested structs, e.g.:
struct [[json]] outer
{
  struct [[json]] inner
  {
  };
};

inner does not get parsed as a class in the AST.

While this does add the inner class to the AST, I think it's not in a way that is usable from the template engine.
It appears as a regular class but with the parent classe's name as part of the scope.
There is no way to differentiate whether the scope is a namespace or a parent class.
This results in generated code such as:
namespace ns1::ns2 {

// conversion functions for OuterStruct

}

namespace ns1::ns2::OuterStruct {
// conversion functions for InnerStruct
}

This does not compile with namespace ... redefined as a different kind of entity.
I'll look into this during the week when I can, but maybe split scope and namespace in our AST model, possibly an is_inner_class attribute and a parent field pointing to the id of the parent class.


Ios Simulator createOrUpdate event not working.

While adding event to the calendar in simulator it is giving me below error.
PlatformException(405, Calendar with ID E0E5295C-DCDA-47BF-9161-4C7F08F94A68 is read-only, null)

As the error says, the calendar you're trying to use is read-only and you're not allowed to add/edit or delete the calendar.


No released version of the yard-cucumber gem supports cucumber greater than 3.0.0

On September 27th version 3.0.0 of the cucumber gem released. In order to update my acceptance test project to use it, I had to downgrade yard-cucumber to 2.2.3 which doesn't have an upper-bound limit on the version of the cucumber gem.

I need to definitely update this gem. Thank you for the issue.

Release 4.0.0 that has updated the cucumber and gherkin gems. Thanks for the comment and patience.


Preload, support ConfigurationItemFactory as argument

SonarQube analysis reported 1 issue

 1 critical

Watch the comments in this conversation to review them.


Added functionality of filtering of Status page data

Screencast from 23-04-24 04:24:25 PM IST.webm
The local developement have been done by hardcoded data, as server(api-docker container) was not spinning up locally

I love the new design it looks great! Just one nit, we should remove a bit of padding to the dropdown so we can align them with the left hand side of the tables:

Doneeeee @frouioui

I am still seeing some gap depending on the size of the screen. Is there a way of "sticking" these components (the dropdown + execution queue + previous execution) in the same div and aligning everything.
Good alignement:

After increasing the size of the screen:

Hey @frouioui i have alligned the select component in the center instead of it being at the start, it is looking nicer here

the scrollbar is there is every page, i think there is problem with the DisplayList.tsx, should i modify in this PR or create a new one as it will effect all the pages
cc @frouioui

Ah right I am seeing the same issue on the PR page. Yes, feel free to open a follow up PR.

That's really good work, it is a nice feature that will be really useful. Thank you! As soon as you resolve the merge conflict I will be able to merge this PR.

Done @frouioui


update opencv to 3.3.0

fix #1615, add in vtk, ceres dependency, successfully tests it's compilation, and downstream project successfully compiles
some problems

build still failed with CUDA enabled, see #1609
Need to disable DNN module because it is causing compilation errors, see below error message

"C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\install.vcxproj" (default target) (1) ->
       "C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\ALL_BUILD.vcxproj" (default target) (3) ->
       "C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj" (default target) (35) ->
       (ClCompile target) ->
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\tensor_shape.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\tensor_shape.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\attr_value.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\attr_value.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\graph.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\graph.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\tensor.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\tensor.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\op_def.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\op_def.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\types.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\types.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\function.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\function.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\versions.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\tensorflow\versions.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]
         c:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\caffe\caffe.pb.h(17): fatal error C1189: #error:  This file was generated by an older version of protoc which is (compiling source file C:\dev\vcpkg\buildtrees\opencv\src\opencv-3.3.0\modules\dnn\misc\caffe\caffe.pb.cc) [C:\dev\vcpkg\buildtrees\opencv\x64-windows-rel\modules\dnn\opencv_dnn.vcxproj]

    774 Warning(s)
    9 Error(s)

3. When using OpenCV from a downstream project, the OpenCV dlls does not get copy over. Potentially related to #1435. One thing I noticed is that the dlls are not directly inside the bin folder. It is inside the x64/vc14/bin folder, which could be the root cause of the problem.

@jasjuang,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ras0219-msft @alexkaratarakis  I fixed the dll copy problem and also the debug build issue. This works seamlessly with my downstream project now. This is ready to merge.
I will try to fix the dnn and cuda problem in future PRs.

what about ffmpeg? do you think it is possible, maybe in a future PR?

@cenit see #1663

@atkawa7  I mean, building opencv with ffmpeg support here in vcpkg, since ffmpeg is already available (and updated, thanks!) ;)

@cenit ffmpeg is enabled, it compiles and my downstream project also compiles

thank you very much, really appreciated the commit b501937.
I hope that your PR is soon accepted :)

@jasjuang
Sorry for the delay on this.
The reason contrib was opt-in is that the VTK dependency it adds takes a significant amount of time. Similarly, CUDA was opt-in because it wouldn't be ideal to force users to (manually!) install CUDA even though they might not want it in the first place.
This issue occurs in other libraries too; to address it there has been an effort for a while now in providing the ability for vcpkg to easily allow you to choose what features of a package you want. These are the "feature packages" that you may have spotted in other PRs (#1205, #1566).
I am leaving this open until "feature packages" are in vcpkg. In the meantime, we would be happy to accept just the update to 3.3.0 as a separate PR.

@alexkaratarakis I do agree that CUDA has to be optional.
VTK is actually not a dependency for contrib, it's for the main opencv itself, and necessary for basic functions like cv::imshow. Contrib actually doesn't result it a significant increase in terms of build time. I strongly thinks that contrib should be in there by default. However, if you still think contrib should be optional, I can comment them out for now in order to get this PR merged. There are a lot of good new features in OpenCV 3.3.

Ok, let me run some tests :) .

Looks like I misunderstood the situation regarding contrib and VTK. After your clarification, I agree with having contrib on by default, but I believe there is concern for VTK. These are the dependencies with and without the PR:
Without VTK (6 libs):

libjpeg-turbo:x86-windows
liblzma:x86-windows
libpng:x86-windows
opencv:x86-windows
tiff:x86-windows
zlib:x86-windows

With VTK (41 libs):

bzip2:x86-windows
ceres:x86-windows
clapack:x86-windows
double-conversion:x86-windows
eigen3:x86-windows
expat:x86-windows
ffmpeg:x86-windows
freetype:x86-windows
gettext:x86-windows
gflags:x86-windows
glew:x86-windows
glib:x86-windows
glog:x86-windows
harfbuzz:x86-windows
hdf5:x86-windows
jsoncpp:x86-windows
libffi:x86-windows
libiconv:x86-windows
libjpeg-turbo:x86-windows
liblzma:x86-windows
libogg:x86-windows
libpng:x86-windows
libpq:x86-windows
libtheora:x86-windows
libxml2:x86-windows
lz4:x86-windows
metis:x86-windows
msmpi:x86-windows
openblas:x86-windows
opencv:x86-windows
openssl:x86-windows
pcre:x86-windows
proj:x86-windows
protobuf:x86-windows
qt5:x86-windows
sqlite3:x86-windows
suitesparse:x86-windows
szip:x86-windows
tiff:x86-windows
vtk:x86-windows
zlib:x86-windows

Apart from the vast increase in dependencies, there is:

msmpi, which requires manual intervention
qt5, which has issues with MAX_PATH, so I had to restart the build on a shorter path
Some library (forgot which one) that could not be built on x86. It was also the 31st out of the 41 libs to be installed so that was... unpleasant (Incidentally, detecting this thing prior to starting the build is something we are working on).

Thus, in my opinion we should not have VTK by default and allow the user to enable it with feature packages. Incidentally, with features packages it will look like this:
vcpkg install opencv =  Install opencv contrib
vcpkg install opencv[vtk] =  Install opencv contrib with VTK
vcpkg install opencv[cuda] = Install opencv contrib with CUDA
vcpkg install opencv[vtk,cuda] = Install opencv contrib with VTK and CUDA

Well, OpenCV is a huge library so I wouldn't be surprised if there is a lot of dependencies.
How about taking vtk and cuda out of the CONTROL file in the build-depends section, but we leave WITH_CUDA and WITH_VTK unspecified. So CMake can auto detect whether vtk/cuda is installed and auto configure on whether OpenCV should be built with vtk/cuda.

The problem with this is that depending on the order you do things, you will get different results.

vcpkg install vtk
vcpkg install opencv
vcpkg install opencv
vcpkg install vtk

If you do vcpkg list, both scenarios will report the same libraries are installed, but opencv will be different. We believe that consistency is critical and would be violated by having a dependency on the order of installation. If you have a script that installs a bunch of libraries you would always want it to have the same effect, but this can lead to a scenario where the install graph decides to install things in a different order yielding different results for opencv.

@alexkaratarakis Ok I understand your concern. Could you give me some pointers on how to write the port file with feature packages? I can make vtk and cuda optional.

It appears there is still work before we can confidently use feature packages, so please add a "manual opt-in". As in, lines that users can comment in/out if they want vtk/cuda. I see four distinct lines here:
0) no vtk, no CUDA (default)

vtk only
cuda only
vtk + cuda

[Combination of features is something feature packages will handle gracefully]
We will modify the package with feature packages when the corresponding work is finished.
(In fact, this will be another very nice test case for feature packages! :)  )

@alexkaratarakis VTK and CUDA are disabled by default now.

Thanks for the solid PR!
Very sorry for the huge delay.

OpenCV does not build anymore, neither in x86-windows nor in x64-windows, due to dependency problems, explained in the above issues


Model certain instructions' memory operand alignment, cache behavior

Certain instructions (in X86 at least, and likely other architectures) check for memory operand alignment, and SIGSEGV if the operand is not aligned to a particular boundary – 16-byte alignment (with 128-bit operands) or 32-byte alignment (with 256-bit operands). The reason for this is that the processor requires two memory accesses to make an unaligned memory access; aligned accesses require only one memory access. A word or doubleword operand that crosses a 4-byte boundary or a quadword operand that crosses an 8-byte boundary is considered unaligned and requires two separate memory bus cycles for access. The Remill semantics for such instructions are not modeling memory operand alignment requirements, and will never throw a CPU exception if the memory operand is misaligned.
Similarly, the X86 "non-temporal move instructions" (MOVNTxxx), when executed natively, write data from a register out to memory while bypassing the CPU caches. We do not model this behavior. All MOVNT instructions alias to the equivalent normal MOV instructions.
Since I think the choice not to model these aspects of memory was a design decision and this is a wontfix issue, maybe the solution is to add these notes to the Remill documentation.

Just commenting to say its probably a wontfix, but maybe something will come up where we need to decide differently.
Typically, we have not modeled various exceptions that can happen during instruction execution. If we start, the semantics for many simple instructions may get needlessly slow and complicated.


Delete duplicate method: isDerivedColumnName

Fix the problem #3213
Changes proposed in this pull request:
Delete duplicate method: isDerivedColumnName

Pull Request Test Coverage Report for Build 627

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 67.615%

Totals

Change from base Build 471:
-0.008%

Covered Lines:
11239

Relevant Lines:
16622

💛  - Coveralls

I just carry on the comment from #3213
I check the code carefully, they are different with that 2 methods.
In method isDerivedColumnName, it use DerivedColumn.values();
In method isDerivedColumn, it use DerivedColumn.getValues();
The different of DerivedColumn.values() and DerivedColumn.getValues() is deal with AGGREGATION_DISTINCT_DERIVED.
So we cannot just merge those 2 methods, need refactor further. So I just close this pr, please keep focus is you want to continue refactor this method, thank you.


superenv: fix formula prefix path to consider revisions

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[X] Have you successfully ran brew tests with your changes locally?

Fixes a bug in #63. It's formula prefix path calculation logic didn't include the revision in the package version, so would be wrong for formulae with revision > 0.
Switches to passing the whole prefix path from the parent brew process to avoid duplicating path calculation logic.

WRT the discussion from Slack: I don't think this actually needs an empty-string check for @formula_prefix. The way it's used within brew, it'll always be either nil or a nonempty string. You'd have to be calling the wrappers from something else, and populating HOMEBREW_FORMULA_PREFIX="" from outside brew code. I don't know if we care about being that defensive.

:+1:

I don't know if we care about being that defensive.

I don't think we need to be so defensive.


Check httpRes is not nil

What type of PR is this?
/kind bug

What this PR does / why we need it:
Check httpRes is not nil, return error otherwise.
httpRes can be nil and httpRes.status return nil pointer exception.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #199
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests

@outscale-mdr @outscale-hmi   I supposed that every api call can not return http status.

Closes #199

@outscale-mdr @outscale-hmi Are you ok with the latest version ?

@outscale-mdr Are you ok with latest changes

@outscale-mdr Thanks i add the docs.


Support for JavaScript modules

It'd be rad to be able to use choo in a no-build environment. Thanks!

Which environments are you thinking of?

Beaker Browser apps (offline, has Chrome's support for ES6 modules).

Choo works in no-build electron now.  It would be great if we could get no-build beaker support as well.  Chrome as well, but I haven't seen any great examples of that, know of any?  I'm guessing this will be trivial once Node.js (and by consequence, browserify) gets better es-modules support.

we could publish an ES module bundle by browserifying choo/index.js and adding export default $BUNDLE. otherwise we'd have to add ES module support to all dependencies too.

Thats an unfortunate catch 22

Yes, module support would be super cool :)


[GoInception] Failed to install goinception pod in my k8s in China region

Describe the bug
I cannot pull the image, busybox from docker hub since the installation of goinception is located in China region. As a result, the installation of the pod failed. (I tried to install the chart, Archery, also failed since the goinception is dependent part in the chart. )
I checked the deployment of goinception(see link below).  The address of busybox is hard coded. Can someone in team change it to an variable? Then I can modify the value to a local repo in China region instead of pointing to the docker hub directly.
https://github.com/douban/charts/blob/3fa7828ca90be5e317e4a6c4ab9ca762e636e9df/charts/goinception/templates/deployment.yaml#L31
To Reproduce
Follow the https://github.com/douban/charts/tree/master/charts/archery
to install the Archery chart in China region, you will see the issue.
Expected behavior
Want to install the goinception pod in China region successfully.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

欢迎pr，另外，你可以使用containerd 的 registry mirror https://github.com/containerd/containerd/blob/main/docs/cri/registry.md
或者k8s 的mutation webhook 解决问题 https://open-policy-agent.github.io/gatekeeper/website/docs/mutation/ https://kyverno.io/docs/writing-policies/mutate/

Thank you so much. Just did a quick change and sent a PR. Please help check.


Upgrading to Rails 5

Upgrading to Rails 5 is failing because:
aptible-api (>= 0) ruby depends on
aptible-auth (>= 0.5.0) ruby depends on
activesupport (~> 4.0) ruby
Is there any fork/fix for apitble-auth that uses activesupport > 4.0

The latest version no longer relies on activesupport


Introduction Text is Incorrect and does not represent activity

The introduction text in this article is wrong.  It appears to have been copied from the "Get Intent" QuickStart".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a402a037-2bf4-24a5-e9af-9efa9d874eb0
Version Independent ID: 85c80b78-b831-d37a-0b52-857daeb9a553
Content: Change, train app, Go - Language Understanding - Microsoft Cognitive Services
Content Source: articles/cognitive-services/LUIS/luis-get-started-go-add-utterance.md
Service: cognitive-services
Sub-service: language-understanding
GitHub Login: @diberry
Microsoft Alias: diberry

@Rich-Lang Thank you for reporting this. It has been fixed and published. #please-close

@Rich-Lang We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Build watch mode

vite build --watch

defaults to development mode

Use Cases

Debugging cases that involve build-only plugins
Debugging in legacy browsers w/ plugin-legacy
Chrome extensions / electron?

Relevant API
https://rollupjs.org/guide/en/#rollupwatch

If I get it, work have to be done here ?
https://github.com/vitejs/vite/blob/v2.0.0-beta.15/packages/vite/src/node/cli.ts#L90
https://github.com/vitejs/vite/blob/v2.0.0-beta.15/packages/vite/src/node/build.ts#L277
I can go for implementation if needed

If I get it, work have to be done here ?
https://github.com/vitejs/vite/blob/v2.0.0-beta.15/packages/vite/src/node/cli.ts#L90
https://github.com/vitejs/vite/blob/v2.0.0-beta.15/packages/vite/src/node/build.ts#L277
I can go for implementation if needed

@yyx990803 Could you review this PR #1449 , and merge it ASAP?

@yyx990803 Could you review this PR #1449 , and merge it ASAP?

I did not get time to finish it yet, I can take time in the end of the week to merge with master and finish it

Looking forward to this as it'll let me build web extensions with Vite...

Adding to the chorus excited for this functionality!

This would be a very useful feature for library mode when building UI components library 🚀

Can we use vite to build a chrome extension project?
When I build a chrome extension, I wish do the following,

Use manifest.json as one input file, and compile related script files, such as background.ts. And probably mount vue in background.ts with a dynamically generate element.
Use popup.html or options.html as other input files with vue.
Thanks

@StarkShang Once #1449 this merged version is live, you can do that. So, on each save, it will trigger a build so you can run the project in the chrome extension local package.

Thank you very much, @surjithctly.
I have 2 more questions
1. Is Feature build watch mode #1449 works in version 2.1.5?
I am using<EMAIL_ADDRESS>but I get error messages when I add watcherOptions in vite.config.ts with defineConfig. It seems that the watch property is not on BuildOptions.
And when I run command vite build --watch, I get error messages,

throw new CACError(Unknown option \${name.length > 1 ? --${name} : -${name}}``);
CACError: Unknown option --watch
at Command.checkUnknownOptions
at CAC.runMatchedCommand
at CAC.parse
at Object.

2. Can I use manifest.json file as input?
I am trying to use manifest.json as input. My project has following structure,

src

manifest.json
background.ts
options

index.html
main.ts
...

package.json
vite.config.ts

And my config is as follows,
import { resolve } from "path";
import { defineConfig } from "vite";
import { WatcherOptions } from "rollup";
import vue from "@vitejs/plugin-vue";
const watcherOptions: WatcherOptions = {};
export default defineConfig({
    root: resolve(__dirname, "src"),
    publicDir: resolve(__dirname, "public"),
    resolve: {
        alias: {
            "@": resolve(__dirname, "src"),
        },
    },
    build: {
        outDir: resolve(__dirname, "dist"),
        emptyOutDir: true,
        watch: watcherOptions,
        rollupOptions: {
            input: {
                manifest: resolve(__dirname, "src/manifest.json"),
                options: resolve(__dirname, "src/options/index.html"),
            },
        },
    },
    plugins: [
        vue(),
    ],
});

@StarkShang

Is Feature build watch mode #1449 works in version 2.1.5?

No

Can I use manifest.json file as input?

No. I think it will be easier for set up build of 2-3 html pages
input: {
    background: resolve(__dirname, "src/background/index.html"),
    options: resolve(__dirname, "src/options/index.html"),
},

Thanks. @cawa-93
However, if I use html file as input file, I have to edit the url of the background script in manifest.json manually everytime after vite built.
As mentioned by @haikyuu in #163, there is a rollup plugin for this problem. But it cannot be used in vite directly.

@StarkShang

However, if I use html file as input file, I have to edit the url of the background script in manifest.json manually everytime after vite built.

Why? I'm not sure it's allowed this now, but before you could set the background page as a html file. and even if it is not allowed now, you can specify the path of the background script. You only need to do this once, because the source file will always be in the same place.
If you are bothered by hashes in the file name, you can disable them.

Thanks for your reply, @cawa-93.
I noticed there is slight difference between chrome extension and mozilla. In chrome extension manifest v3, we should use a script file as service worker in manifest.json file, as denoting in Migrating from background pages to service workers.

As stated in Service Workers: an Introduction, a "service worker is a script that your browser runs in the background, separate from a web page, opening the door to features that don't need a web page or user interaction.

I have tried to using a background.html directly in manifest file as,
{
    "background": {
        "service_worker": "./background.html"
    },
}

An error with message "Service worker registration failed" is prompted by chrome.

Why --watch still not work?

This PR was merged, but has not yet been released

This PR was merged, but has not yet been released

I mean why not still not release? 😂

The feature has released at v2.2.0, changelog: https://github.com/vitejs/vite/compare/v2.1.5...v2.2.0

Import SCSS are not considered.
Main JS File
import './themes/all.scss' => --watch works and rebuild the files
All.scss File
@import "default"; => --watch not works
@import "theme"; => --watch not works
Only changes in the Main JS File and All.scss start the rebuild.
Changes inside default.scss or theme.scss are not detected.
Why?
My Vite Config:
export default {
  mode: 'development', // production
  build: {
    // minify: false,
    emptyOutDir: false,
    lib: {
      entry: './src/main.js',
      name: 'Main'
    },
  }
}

CLI: vite build --watch

I can confirm I have the same issue as @JonathanSchndr

@JonathanSchndr @farzadso could you open a new issue with a reproduction?

@JonathanSchndr @farzadso could you open a new issue with a reproduction?
#3566


Bring SDRPlay gain handling in line with SoapySDR abstractions.

This PR solves #44 and #60. Summary of changes:

Rename IFGR to IF, and negate it. (For example, an "Intermediate Frequency Gain Reduction" of +30 dB is now interpreted as an IF gain of -30 dB.)
Remove RFGR from the list of gains. Instead, RFGR is adjusted using the equivalent "RF Gain Select" setting. (RF can be re-added to the list of gains via an optional build flag.)
Override setGain and getGainRange so that setting an overall system gain will adjust the IF gain only. RF gain should not be adjusted implicitly.
Rename the rfgain_sel setting to lna_state for semantic consistency.

The impact on CubicSDR clients will be the following:

CubicSDR in manual gain mode will have an IF gain slider labeled -59 at the bottom and -20 at the top, with the greatest amplification obtained at the top of the slider. This replaces the old IFGR slider, which was backwards from usual (it was labeled 20 at the bottom and 59 at the top, with the greatest amplification at the lowest setting).
The RFGR slider is no longer present in manual gain mode. The RF gain is settable in any mode by means of the "RF Gain Select" menu item. A build option (off by default) adds an RF gain slider in manual gain mode. RF gain values on this slider are negated from the previous RFGR slider (-9 through 0 instead of 0 through 9) for directional consistency with the other gain sliders.

This PR will require that any other applications which explicitly set IFGR, RFGR, or rfgain_sel by name must update their configuration files. It will introduce compatibility with any application that calls Device::setGain without a name.
I have built and tested this PR with an RSP1A, using CubicSDR (to verify manual and automatic gain control work properly) and trunk-recorder (to validate that Device::setGain with no name now has reasonable behavior).
References:

Block diagram of RF and IF gains: SDRPlay application note
Actual dB losses caused by RF Gain setting: SDRPlay API documentation, section 5.3

Remove RFGR from the list of gains. Instead, RFGR is adjusted using the equivalent "RF gain" setting.
The RFGR slider is no longer present in manual gain mode. The RF gain is settable in any mode by means of the RF gain menu item.

Well, that was set precisely for Cubic because it was way more practical to use a "gain" slider than consistently going to the menus. The menu entry was kept simultaneously because in case of AGC on, the gain sliders were hidden in Cubic.
OK for the the rest of the changes, but I recomend keeping the setGain/getGain("RF") with a #ifdef, disabled by default in CMakeLists.txt if you wish.

Also you should put @SDRplay in the conversation about how relevant those changes are given those are for API v2 and there is already a working implementation of API v3 mentionned #58 on which it may be more relevant to work.

how relevant those changes are given those are for API v2 and there is already a working implementation of API v3 mentionned #58 on which it may be more relevant to work.

I'll be happy to port these changes to the v3 SDRPlay API once they are merged for v2. (Alternatively, if v3 is merged to master first, then I will rebase my PR.) For now, I'd just like to get the gain situation fixed.

it was way more practical to use a "gain" slider than constantly going to the menus. The menu entry was kept simultaneously because in case of AGC on, the gain sliders were hidden in Cubic.

For anyone else following along, this is how CubicSDR manual gain mode looks right now:

And this is how it would look with my proposed change:

There is definitely a tradeoff here between adherence to the SoapySDR abstraction, and ease of adjustment in CubicSDR's manual gain mode. Question for @vsonnier -- as someone who uses the RFGR slider in manual gain mode, would you prefer to have the existing "RFGR" slider which adjusts from 0 to 9 (with the highest gain at the bottom), or an "RF" slider which is inverted and runs from -9 to 0?
I still feel a bit uneasy about exposing a SoapySDR gain which is not in dB. (In fact, it's not even monotonic in all cases... on the RSP1, RFGR 0 -> 0 dB, RFGR 1 -> -24 dB, RFGR 2 -> -19 dB, and RFGR 3 -> -43 dB.) But a compiler flag to make it optional, especially one that's off by default, could be a solution.
In the long term, I'd love to figure out some way for CubicSDR to display UI widgets for arbitrary additional device settings. Then you could have an RF gain adjustment widget that would be visible all the time, in automatic or manual mode :-)
Cheers!
David

as someone who uses the RFGR slider in manual gain mode, would you prefer to have the existing "RFGR" slider which adjusts from 0 to 9 (with the highest gain at the bottom), or an "RF" slider which is inverted and runs from -9 to 0?

Neither :) Make it simple so that 0 means the lowest LNA gain (the old 9) and 9 the highest gain (the old 0)

But a compiler flag to make it optional, especially one that's off by default, could be a solution.

Yes, please.

In the long term, I'd love to figure out some way for CubicSDR to display UI widgets for arbitrary additional device settings. Then you could have an RF gain adjustment widget that would be visible all the time, in automatic or manual mode :-)

I wish it too, I studied the problem when I bought my RSP2 but gave up and has stayed on the easy side, exposing LNA state as "Gain".

Neither :) Make it simple so that 0 means the lowest LNA gain (the old 9) and 9 the highest gain (the old 0)

I am afraid that this would be too confusing for SoapySDR users who are not hands-on with the SoapySDRPlay source code. (Imagine: CubicSDR RFGR goes from 0 to 9, the SDRPlay documentation has RF gain performance tables that go from 0 to 9, but we have decided to shuffle around the meaning of 0 and 9!)
I'll wait a few days to hear from any other contributors or users who would like to weigh in on this design question, and will plan to update the PR this weekend.

Previous discussion about the RFGR gain slider vs menu item may be found in #35

the SDRPlay documentation has RF gain performance tables that go from 0 to 9, but we have decided to shuffle around the meaning of 0 and 9!)

Why not ? this PR is about reversing (GR)IF, is it not ? Whatever [-9 ; 0] is just as good, and user will have to adapt anyway to this convention so the same questions will inevitably araise in the long run amaong the existing users.

Previous discussion about the RFGR gain slider vs menu item may be found in #35

Indeed. The goal here would be to have "RF" presented as settings all the time (so removing the current #define RF_GAIN_IN_MENU), with an additional #ifdef RF_AS_GAIN (defaulting to "off"  on CMake side) for instance bringing back RF as a Gain slider for Cubic users typically.

Why not ? this PR is about reversing (GR)IF, is it not ?
Well, I have two goals:

Comply with standard SoapySDR abstractions, so that a higher gain number results in more amplification and the CubicSDR slider is not backwards.
Maintain a direct correspondence with SDRPlay documentation (and other tools such as SDRUno), to avoid confusion among new users.
The nice thing about using the negative number range is that it (mostly) satisfies both goals.

@vsonnier, thanks for taking the time to talk through this with me! Looking back I can see you have done a lot of work for SoapySDRPlay and CubicSDR in the past. Your contributions are appreciated :-)

PR revised per discussion. I edited the description above to have an up-to-date summary of the changes.
Cheers!

I came across this PR after I had just deduced experimentally that the reported "gains" were in fact gain reductions and was wondering what to do about it.
In my application, I want to be able to measure the absolute signal strength of the received signal (e.g. in dBm or dBuV at the antenna input). This requires knowledge of the overall gain of the front-end, which I am obtaining from SoapySDR::Device::getGain(). I don't need to know the absolute gain - it's fine if there's an overall calibration offset to be added. But if the RF gain isn't reported, this would lead to different results for the same input level depending on the RF gain.
I've started work on a change that would incorporate the lookup tables from the SDRPlay API reference, such that getGain() would report the actual gain reduction in dB (with a negation of the sign as proposed here). However, there needs to be symmetry between getting and setting, so for setGain() I would search the lookup table for the LNA state that gave the nearest gain to the demand value. I'd need to make corresponding changes to getGainRange() too.
My changes are based on commit 0d84f1c1a5 (28th July 2021) which uses the v3 API.
Clearly you (@dlaw) put a lot of work both into backwards compatibility and into how it works with the CubicSDR UI, so I'd be very interested in your thoughts (or anyone else's) on this approach.

@olliehaffenden - thanks for your comment and hard work.
I started a similar discussion for the current version of the SoapySDRPlay module here: https://github.com/pothosware/SoapySDRPlay3/issues/35
I also created a branch for that module called new-gain-controls to experiment with some ideas on how to improve the gain controls for the SoapySDRPlay3 module, without affecting too heavily existing applications like CubicSDR and their users.
Please feel free to try using the different options offered by that branch of the SoapySDRPlay3 module, and let us know what you think.
I would suggest to use that discussion thread for your input in order to try to keep this important conversation in one place.
Franco


initialZoom state update does not work with _zoomConfig()

Describe the bug
I want to create a zoom In/Out button for the graph by updating the state value of initialZoom with the code below:
Graph.jsx
zoomIn = () = > {
  this.setState({
        ...this.state,
        config: {
          ...this.state.config,
          initialZoom: this.state.config.initialZoom + 1
        }
      },
        () => {
          this._zoomConfig();
        }
      )
    };
};

<div>
        <button type="button" onClick={this.zoomIn}>+</button>
</div>

When the button is clicked once, graph will zoom in properly. However, the graph will zoom in afew times and then, returned to original zoom setting of null when the button is clicked multiple times. I printed out the initialZoom value and realised that the state value is "1,2, null, 1, 2, null ..... and repeat". However, the state value of initialZoom will be increasing properly if I remove "zoomConfig()" from the code, (1,2,3,4,5,6,7,8,9......and so on).
To Reproduce
Steps to reproduce the behavior:

When the button is clicked once, graph will zoom in
When the button is clicked multiple times, graph will zoom in and returned to its original setting of 'null'

Expected behavior
Graph will be zoom in by a value of 1 when a button is clicked.
Screenshots
N/A
Environment:

OS: Windows 10 Enterprise 64 bit
Browser Chrome
Version 87.0.4280.141
Node version v12.18.0
react-d3-graph version 2.6.0
d3 version 5.5.0
react version 16.4.1

Additional context
N/A

Hello @JonasJonesWee ,
I don't really understand if you are changing the code of the repository by including your code in Graph.jsx or not.
I think that you can achieve what you want by using the initialZoom property, like in this codesandbox.
Is this what you are looking for?

Hello @JonasJonesWee ,
I don't really understand if you are changing the code of the repository by including your code in Graph.jsx or not.
I think that you can achieve what you want by using the initialZoom property, like in this codesandbox.
Is this what you are looking for?

Ok thanks! I will try it out.

@JonasJonesWee I am closing this issue.
Please feel free to reopen it if needed.


[FLINK-2017] Add predefined required parameters to ParameterTool

adds Option class to represent required parameter
adds RequiredParameter class to interact with ParameterTool to check and/or validate parameters
adds corresponding unit tests

One of the builds failed because of a test failure in:
CoStreamCheckpointingITCase>StreamFaultToleranceTestBase.runCheckpointedProgram:105->postSubmit:126 Restore was never called on counting Map function.
I will check it out and update the pull request if necessary.

Thanks for the PR! I am sure that the mentioned test failure is unrelated to your changes. If you like, you can create a new issue with the label test-instability for the failing test.

OK, cool. I have created a separate ticket. https://issues.apache.org/jira/browse/FLINK-2628

Thanks for the PR @mliesenberg!
Can you add the checks (and tests to verify the checks are working) that I mentioned in my comments?
The original JIRA issue also included type checks. I think we could restrict those to Java primitives (Integer, Long, Double, Float, Boolean).
I would be OK with adding this PR without type checks (and opening another JIRA for that) but it would be a cool feature if you'd like to add that.

@fhueske Yes, I will add the checks.
Regarding the type checks: Does that refer to the interaction with the ParameterTool class? I thought about that as well, but there the values are stored as strings and only upon retrieval the expected types are used.

If you add a type field (or enum) to the option, you can check if you can cast the string into the requested type. Since we would only support a fixed set of types (the primitives I listed above) this should be quite easy.

Ok, I will add that.

The test failure seems unrelated to my changes. It's connected to the YARNSessionFIFOITCase test.
FLINK-2700 has been opened a couple of days ago with the same error.

I'll soon review this pull request. Sorry for the delay.

Looks like good progress! As pointed out in one of my comments, I think we should make the use a bit more intuitive. Having two methods which are named so similar but which do different things is not a good idea. IMO it would be better to have one method that applies (and checks) the required options to the parsed parameters.

I think that might just boil down to the question whether or not there is a common enough use case for one without the other.
If so, we could change it to one method for check and one for populate which would untangle the code a bit as well.
If there is no use case for one without the other, I'd agree to get rid of the check.
I am unfortunately a bit pressed for time at the moment, but hope to find time to address the other comments during the weekend and.

Going through FLINK-2017, I interpreted the semantics of check and checkAndPopulate as follows:

check verifies that all required parameters are provided and valid (type, choice, etc.)
checkAndPopulate copied the default values of the options into the ParameterTool

I think a method that is called checkAndPopulate should perform the same checks as check and do the populate in addition. Moreover, I do not see why check alone would be useful. Why would somebody define required parameters with default values without enforcing them, i.e., why you call check without checkAndPopulate.
If we have a single method, we could also give it a simpler name such as applyTo.
What do you think?

I do see your point about the uselessness of only check, so I'll go ahead and implement applyTo.
I'll update the PR tonight.

Thanks!

Thanks for the update!
Except for my comments, the only remaining question is whether to offer the add(Option) method or not, right?

Yes, that's right.
I'll address the comments tonight. If the add(Option) issue is blocking the merge, we can just drop the function it, if you want.

I think it's fine to have an add(Option) method in addition to add(String). There might be cases where you want to create the Options first and add them later on.

Thanks @mxm for the feedback. Then let's keep this PR as it is :-)

Ok, should I rebase on the current master and squash the commits into one before it will be merged?

Yes, that would be nice. Thanks

Hi @rmetzger, do you want to give it another look and check if it does what you intended with FLINK-2017?

Thank you for reviewing the pull request while I was away @fhueske.
I've just tried it out with this code:
RequiredParameters rp = new RequiredParameters();
rp.add("input");
rp.add("output");
rp.add(new Option("parallelism").alt("p").help("Set the parallelism for all operators").type(OptionType.INTEGER));
ParameterTool pt = ParameterTool.fromArgs(args);
try {
	rp.applyTo(pt);
} catch(RequiredParametersException rpe) {
	System.out.println(rp.getHelp());
	System.exit(1);
}

and the output is the following:
 Required Parameter
name, short name, help text, default valueinput	null
output	null
parallelism	p	Set the parallelism for all operators

I think the getHelp method is not producing helpful output here.
How about something like:
Required Parameters:
    --input
    --output
    -p, --parallelism        Set the parallelism for all operators

The RequiredParametersException could list the missing arguments.

I'll address the comments and rework the getHelp method to produce more useful output (and cover that with more tests).

thanks for the feedback.

Thank you for reacting so quickly to my feedback.
I'm sorry for the delays during the PR review.

Sure, no problem.
One comment concerning the comment:
The RequiredParametersException could list the missing arguments.
At the moment the validation in applyTo fails with the first missing parameter. To list all missing arguments would require to change that, but it might be worth it.
What do you think?

I think it should not be too hard to collect all the issues in a list and then throw the exception in the end.
What do you mean by the optional list? Only listing those arguments which are still missing?

optional in the sense of, if the list is passed, then the missing arguments are added to the help text in an extra paragraph at the end.
realized probably via method overloading.

Okay, I think its a good idea.

cool. will update the PR today.

I think the test cases are not good enough.
I tried it out with this code again:
RequiredParameters rq = new RequiredParameters();
rq.add("input");
rq.add(new Option("parallelism").alt("p").defaultValue("1").type(OptionType.INTEGER));
ParameterTool pt = ParameterTool.fromArgs(args);
rq.applyTo(pt);

and got the following error:
Exception in thread "main" org.apache.flink.api.java.utils.RequiredParametersException: Value null is not in the list of valid choices
	at org.apache.flink.api.java.utils.RequiredParameters.applyTo(RequiredParameters.java:126)
	at org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:64)

Passing --input abc will result in RequiredParametersException: Value abc is not in the list of valid choices.
The output of the help method looks better now
Required Parameters:
	--input
	-p, --parallelism	Set a parallelism for the job	default: 1
	--ouput	This is my help

Oha. yes. Found the problem causing the exception, will fix it and make the tests more specific as to which exceptions they need to catch.
While I am at it, anything else which needs change or are we good to go?
I'll update the PR tomorrow.

No, I think once that's resolved, the PR is good to merge.

Cool. Pushed my latest changes which fix the bug and add more test cases.
Btw., is there any way to see a test coverage report?

Yes, in IntelliJ the button right to the Debug button will generate a test coverage report.

I'm wondering whether you are trying to run the examples I'm posting here:
RequiredParameters rq = new RequiredParameters();
rq.add("input");
rq.add(new Option("parallelism").alt("p").defaultValue("1").type(OptionType.INTEGER));
ParameterTool pt = ParameterTool.fromArgs(args);
rq.applyTo(pt);

with --input abc
leads to:
Exception in thread "main" org.apache.flink.api.java.utils.RequiredParametersException: Value for parameter parallelism cannot be cast to type INTEGER
	at org.apache.flink.api.java.utils.RequiredParameters.applyTo(RequiredParameters.java:123)
	at org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:65)

I didn't provide any value for parallelism and I was expecting it to be set automatically to 1.
I would recommend you to at least add the examples I'm posting here as test cases.

Oha. that is embarrassing, I thought I had it covered. I'll look into it. Sorry for the mess.

the build failure is due to a test in streaming, so most likely not related.
the test failure has been observed before and is captured in issue FLINK-2348

I've tested the PR again.
I found a minor issue with the alternative arguments.
input: --input abc --p 12,
code:
RequiredParameters rq = new RequiredParameters();
		rq.add("input");
		rq.add(new Option("parallelism").alt("p").defaultValue("1").type(OptionType.INTEGER));
		ParameterTool pt = ParameterTool.fromArgs(args);
		rq.applyTo(pt);

		String in = pt.get("input");
		System.out.println("In = "+in + " parallelism = "+pt.getInt("parallelism") + " p="+pt.getInt("p"));

		System.exit(0);

error
Exception in thread "main" java.lang.RuntimeException: No data for required key 'p'
	at org.apache.flink.api.java.utils.ParameterTool.getRequired(ParameterTool.java:236)
	at org.apache.flink.api.java.utils.ParameterTool.getInt(ParameterTool.java:272)
	at org.apache.flink.examples.java.wordcount.WordCount.main(WordCount.java:69)

I think we need to set the (default) value for the long and the short variant.

yep, based on the discussion above with fabian the default value is set only on the long key.
I'll go ahead and set it on the short key as well, if nothing else is defined.
I think the issue above is something else though:
when a value is found for the short key, but not the long key, it is copied to the long key and removed from the short key - also based on my understanding of the discussion above. rereading it and seeing your use case, it is probably better to drop the removal from the short key.

Oh, I see. I have to admit I didn't closely follow the discussion with Fabian.
Would be nice if you could change the behavior.

ok. done.

Thank you for addressing the issues so timely.
I'll merge the change now, thank you!


Nanopb 0.3.9-dev seems to hang the firmware

While testing with Merlin it appears that the latest Nanopb library causes the firmware to hang.

Does an older version of nanopb work?
On Mon, Mar 20, 2017 at 3:17 PM, Uriah Welcome<EMAIL_ADDRESS>wrote:

While testing with Merlin it appears that the latest Nanopb library causes
the firmware to hang.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/science-journal-arduino/issues/22, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHtyQMMu2UcFWca0c_A0_TZicWFK9NaQks5rnvsUgaJpZM4MjFpY
.

Yes 0.3.8-dev works fine.  I commited a fix to the platformio.ini to force 0.3.8-dev until we can determine what in 0.3.9 breaks things.

(relevant lines here)
This is going to stop working, as 0.3.8-dev has been removed from the package manager (https://github.com/nanopb/nanopb/commit/cc74b9f200176edc5524aa00ba45fa90a5e87d27#commitcomment-23061529)

Sorry for the issue, the 0.3.8-dev version has been just restored. In any case, I recommend to depend on 0.3.7 which is the same as 0.3.8-dev.
See http://platformio.org/lib/show/431/Nanopb

That issue is probably why 0.3.9-dev didn't work for you in the first place. You might now find that 0.3.8 works properly, now that that platformio package and protoc plugin versions are in sync

Thanks for the info.  I'll pin @0.3.7.  @0.3.8 is still giving me errors on installation here.


Explicitly drop database connection acquired during application setup

The dirty shutdown we observed were caused by the sqlite pool patiently waiting
until we close the connection we've opened in the application setup.
This is turn was eventually triggering Rocket timeout (which is by default
configured to wait 5s for cleanup).
When loading cfds gets moved into the projection actor, the connection can be
moved to a tighter scope (only for the housekeeping functions).
Resolves #477

bors r+


Update types for input events.

event.target.value is a common thing to do with events on InputElements. This change will allow that.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@johnwun could you please address test failures?

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot import

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

Unfortunately, this can't land as is because it overrides a property of a superclass at a different type (subtype of original) in a subclass. This would be sound if the property was declared covariant (@samgoldman is working on a feature that would enable that), but right now this change would break on all code by reporting "inconsistent lib defs".

Ok cool, thanks for the update!
On Aug 16, 2016 4:54 PM, "Avik Chaudhuri"<EMAIL_ADDRESS>wrote:

Unfortunately, this can't land as is because it overrides a property of a
superclass at a different type (subtype of original) in a subclass. This
would be sound if the property was declared covariant (@samgoldman
https://github.com/samgoldman is working on a feature that would enable
that), but right now this change would break on all code by reporting
"inconsistent lib defs".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/flow/pull/2100#issuecomment-240275056, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABDVCO2JG85sIKQAoq0pd0vUnT5EXtrVks5qgk3LgaJpZM4JQSmu
.

@avikchaudhuri - what if we updated it to
 declare class SyntheticEvent<Target: EventTarget = EventTarget> {
     ...
     target: Target;
 }

 declare class SyntheticClipboardEvent extends SyntheticEvent<> {
     clipboardData: any;
 }

 declare class SyntheticCompositionEvent extends SyntheticEvent<> {
     data: any;
 }

declare class SyntheticInputEvent extends SyntheticEvent<HTMLInputElement> {
    data: any;
}

The downside is that it breaks existing SyntheticEvent type annotations, since it requires people to add the <>

Any updates?

Sorry for the delay! I've patched this PR to get this working. Just waiting on a review and then I'll merge it!


ARROW-1289: [Python] Add PYARROW_BUILD_PLASMA CMake option, follow semantics of --with-parquet

Now the test suite does not fail if you build the Plasma libraries but forget to pass --with-plasma to the Python build

cc @pcmoritz

+1 LGTM


Virtual table modules

SQLite supports creating virtual tables that are implemented by the host application. We should create an API for doing this. See Virtual Table Object.

Apparently these things can be used as TVFs. See the table-valued functions section.
(cc @divega)

We would need to have access to sqlite3_create_module or sqlite3_create_module_v2 in SQLitePCL.raw first.

Yeah, that's an area of the sqlite API that I never implemented.
But I could...
:-)

This is a fantastic feature of SQLite! It's really sad it isn't available in netcore.
@ericsink any chance of unleash https://github.com/ericsink/SQLitePCL.raw/issues/191 for us, mere mortals? 😉
I'm really interested to work on this (with an API similar to System.Data.SQLite, with room for improvements). But for now I'm yet trying to build https://github.com/ericsink/SQLitePCL.raw (and failing miserably 😄).

@fdcastel Nobody needs my permission to work on a feature of SQLitePCL.raw.  It's open source, so if you want to proceed, feel free.
Admittedly, getting your changes merged into my repo is another story.  :-)
The real problem here is that SQLitePCL.raw is too hostile to work on.  I'm planning some improvements in that area, to make things easier for other developers who want to collaborate.  But I haven't got much done in that area yet.

(I've considered starting a PR, but my TODO list is pretty big...)

@bricelam if you already made any work on this subject (even if largely incomplete/unusable) and could share it, it would be great.
I'm just starting to grasp some concepts of SQLitePCL.raw.
The good things is: It's building now! 😄

I remember starting on a P/Invoke version of sqlite3_module similar to our or old sqlite3_vfs implementation, but decided I wasn't ready to see it through and threw it away.


Add support for non-correlated subqueries

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I would like to be able to run this query:
CREATE TABLE paintings AS SELECT 'Mona Lisa' as name, 1000000 as listed_price;

SELECT name, listed_price
FROM paintings
WHERE listed_price > (
    SELECT AVG(listed_price)
    FROM paintings
);

It currently fails with:
Skipping optimizer rule decorrelate_scalar_subquery due to unexpected error: scalar subqueries must have a filter to be correlated at /home/andy/git/apache/arrow-datafusion/datafusion/optimizer/src/decorrelate_scalar_subquery.rs:177
caused by
Error during planning: Could not coerce into Filter! at /home/andy/git/apache/arrow-datafusion/datafusion/expr/src/logical_plan/plan.rs:1127
NotImplemented("Physical plan does not support logical expression (<subquery>)")

This is because the existing subquery optimizer rules fail to rewrite the query.
It should be possible to rewrite the query as a join:
SELECT name, listed_price
FROM paintings
CROSS JOIN (SELECT AVG(listed_price) AS avg_price FROM paintings) temp
WHERE listed_price > temp.avg_price;

Describe the solution you'd like
:point_up:
Describe alternatives you've considered
None
Additional context
None

FYI this should not be super-hard. I actually started adding uncorrelated support, and there is even an example of it here. CC @DaltonModlin

When this works, q15 in the TPCH benchmark should work as well.

I'll take a look into this issue as I'm currently trying to fix q15 for TPCH benchmarks.

I think there are three things preventing q15 from working:

projections in the view definition (now fixed by @DaltonModlin )
a different view-related error @DaltonModlin is working on presently
The uncorrelated issue we're chatting on right now

2 & # 3 could be worked on independently I believe.

4 things! We need the PR for drop view #3267 to be merged in too for q15. :)
I can take a stab at this issue, but I wouldn't care if someone came up with a competing patch .. plan optimization is totally new to me so I'm not sure how successful I'll be over what timeframe.


Pandas 1.1.0 error: ValueError: Names should be an ordered collection.

Hi,
The following code generates "ValueError: Names should be an ordered collection." with Pandas 1.1.0:
from pandas_plink import read_plink
bim, fam, bed = read_plink(plink_file_path)

(see https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.1.0.html)
Thanks for looking into it!

Fixed in https://github.com/limix/pandas-plink/pull/19.


Problem with automation with SONOFF SNZB-04 sensor

Hi,
I have installed your SonoffLAN succesful. I see the sensor in LOVELACE and information is updated.
When I create an automation it doesn't react on the trigger.
I am a beginner with HA and I think I do something wrong (see attached automation.yaml)
What do I wrong?
Thanks already for your support.
Rob
In the automations.yaml next info is in:
- id: '1615998130041'
  alias: test1
  description: test1
  trigger: []
  condition: []
  action: []
  mode: single
- id: '1616162863125'
  alias: test1
  description: ''
  trigger:
  - platform: state
    entity_id: binary_sensor.sonoff_a48000aa3d
    to: Closed
    attribute: device_class
  condition: []
  action:
  - type: toggle
    device_id: 4699860caa37cdb35bf4ddac811dde0c
    entity_id: switch.eb26b575a68d5e71ddseim
    domain: switch
  mode: single

You need to learn how to create automation with Home Assistant. It is not related to this component. Ask in the community forums or on Discord.


Add JSHint and Hook up Travis

The :eyes: are always watching

This PR addresses Issue#22.

Adds Travis integration to repo
updates .npmignore to keep dev config out of npm package
Sets up jshint for dat crocks style (need to set up a style guide for contributors)
Adds the Travis badge to the README
:wrench:  some of the npm scripts to work with the linting addition.
:wrench: some linting errors that came back :taco: :tada:


Want a global setting

I could like to have a global setting for things like height_toggle, win_opts, etc. You know, this will be convenient.

Sure. I'll implement it soon :)

Hi @luck07051 , please update the plugin. You should be able to call nm.setup_defaults({opts}) to setup your default options.

Thanks! Works for me.
Really good plugin. :+1:


Make intermediate scores retrievable from the backend during Single Mode

implemented and successfully tested by @Altishofer  with another dev task and the major following commits 446cf4653123f72d0afb8967fd3f778033d4d54b and 2fdd7f51b70f95fc54ad1c6cbf5c2922bf3e0e8c

Gets tested by intermediateGame_whenValid_returnResults_200 in GameControllerTest


document

Document usage in README

Note potential to use for mining/oil gas restrictions as per designated lands.


Issue with Highlight Selected Package

See issue: https://github.com/richrace/highlight-selected/issues/180
I think it's an issue with: https://github.com/richrace/highlight-selected/blob/master/lib/highlighted-area-view.coffee#L114-L117

thanks @richrace


Add Ubuntu 20.04 to the list of supported operating systems

According to the release notes, Ubuntu 20.04 is supported since August.
https://docs.microsoft.com/en-us/azure/azure-arc/servers/agent-release-notes

@alexandair : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@alexandair - Thanks for submitting this, but I can't approve because the PG is pulling support for this version and I'm getting ready to publish changes to reflect this in the release notes.  I should have a PR out tomorrow AM reflecting this.  Thanks!

@MGoedtel If the release notes info is not correct, this change doesn't make sense obviously. :)
You can close the PR.

#please-close


New package: Asap v0.1.0

Registering package: Asap
Repository: https://github.com/keithjlee/Asap
Created by: @keithjlee
Version: v0.1.0
Commit: 20e96b39b1162551ca7b004977b1457942763b0c
Reviewed by: @keithjlee
Reference: https://github.com/keithjlee/Asap/issues/4
Description: Another structural analysis package

The name seems ok to me, with the explanation in the README, but the repo URL needs to be fixed, and it’ll need a manual merge because of the short name

[noblock] you probably have to retrigger the registration

Yes, it needs a new registration and with the updated repo URL a different branch will be used and thus a new PR will be opened.

Closing in favor of https://github.com/JuliaRegistries/General/pull/102897


todo: Website with better examples

Needs website with better examples

Some progress: https://liike.js.org 👍


Enable ILRMA to be given by default keyword arguments

Summary
From now, we can set default NMF parameters.
close #37

Codecov Report

Merging #102 (dde8d5e) into develop (c5c6ed2) will increase coverage by 0.05%.
The diff coverage is 90.47%.

@@             Coverage Diff             @@
##           develop     #102      +/-   ##
===========================================
+ Coverage    94.41%   94.46%   +0.05%
===========================================
  Files           18       18
  Lines         2702     2712      +10
===========================================
+ Hits          2551     2562      +11
+ Misses         151      150       -1

Impacted Files
Coverage Δ

ssspy/bss/ilrma.py
97.96% <90.47%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fb36b...dde8d5e. Read the comment docs.


When chat disappears for both participants, this means it was deleted for both sides by one of the participants (you or your wife in this case, or potentially any third-party who had physical access to the device). This is the way Telegram platform works, and it doesn't matter which specific official Telegram client was used.

When chat disappears for both participants, this means it was deleted for both sides by one of the participants (you or your wife in this case, or potentially any third-party who had physical access to the device). This is the way Telegram platform works, and it doesn't matter which specific official Telegram client was used.
The only chance to recover any part of the content of that chat is to have Telegram session, which was offline since before chat was deleted, and you have that chat cached & media downloaded. The moment you turn on network on such device, the offline cache on such device will be deleted.
This can be applied to any Telegram client, which has offline chats cache (which includes Telegram X).
Originally posted by @vkryl in https://github.com/TGX-Android/Telegram-X/issues/442#issuecomment-1703757221

When chat disappears for both participants, this means it was deleted for both sides by one of the participants (you or your wife in this case, or potentially any third-party who had physical access to the device). This is the way Telegram platform works, and it doesn't matter which specific official Telegram client was used.
The only chance to recover any part of the content of that chat is to have Telegram session, which was offline since before chat was deleted, and you have that chat cached & media downloaded. The moment you turn on network on such device, the offline cache on such device will be deleted.
This can be applied to any Telegram client, which has offline chats cache (which includes Telegram X).
Originally posted by @vkryl in https://github.com/TGX-Android/Telegram-X/issues/442#issuecomment-1703757221


Revert "Add factorization"

I create a pull request by mistake, if possible I would like to revert it

I create a pull request by mistake, if possible I would like to revert it


Keep babel or not?

I feel the babel flow is a bit of a tooling overhead - especially given Node 4 support most of es6.
What's the feeling? Keep or let go?

Rather than letting go, we can make it optional?

how about use typescript instead of babel?

Babel is gone 👋🏼
… at least for now. See 602e2507037903a6597bdc042a12d9f45f323bf4.


Update the issue template to include running the tests.

/assign @Bobgy

Requiring two sponsors were not included as a requirement in https://www.kubeflow.org/docs/about/contributing/#joining-the-kubeflow-github-org?
Should we add it there too?
/lgtm
/hold

@Bobgy Yeah we should update contributing.md.
/approve
/hold cancel


Stop on getting account data

I use 3 account
Server location : iran
I run without proxy
Last update of your bot
Its about 1 day no work and stops on getting accoumt data
Also i have to add this : Account not detected as bot

Try using a different location instead of Iran.


Initialize README.md and swagger file

Update README.md (light info).
Provide initial swagger file

The swagger file needs a bit of expansion, though...

No CI yet to check if the swagger file is well formed. I'll do that next.


Documentation for loadingIndicator on Node level

Loading indicator settings can be set for navigation Nodes, but the docu currently only mentions it in Luigi Client. Add it to general Navigation configuration documentation too.

fixed


Fix Markdown syntax in readme.md

This commit fixes some markdown syntax errors in readme.md that causes rendering issues on e.g. https://www.npmjs.com/package/html2canvas

Fixed with https://github.com/niklasvh/html2canvas/commit/50579f399ec8a61144d2bf1061d391ef0af3bceb


[DOC] fix coturn ports

The problem here is, that nginx is already listening on port 443. I must have overlooked that when writing the role.
I would rather change the default, because we can't have multiple services listening on one port...

Jep, that was the problem in normal state ....


Another attempt at travis bundler caching.

For rspec/rspec-dev#101. The changes in #102 don’t seem
to be caching properly. I’m switching back to a single
shared bundle directory but manually caching it rather
than using cache: bundler so that bundle clean doesn’t
run.
I plan to put this in rspec-dev (and all repos) if it works
but wanted to test on just one repo for now.

This appears to be working.  Compare this build:
https://travis-ci.org/rspec/rspec-support/builds/45625577
...to this one:
https://travis-ci.org/rspec/rspec-support/builds/45629964
The first build took 37 commutative minutes (3-5 minutes per matrix entry).  The latter took 11.5 minutes cumulatively (with all builds under 90 seconds).  That's a huge improvement.
The one problem is that it doesn't clean the bundle, so the bundle will grow infinitely as new gem versions are released and get installed in our bundles.  I'm not sure what to do about that yet.  I'll go open a PR in rspec-dev with these changes.

This appears to be working.  Compare this build:
https://travis-ci.org/rspec/rspec-support/builds/45625577
...to this one:
https://travis-ci.org/rspec/rspec-support/builds/45629964
The first build took 37 commutative minutes (3-5 minutes per matrix entry).  The latter took 11.5 minutes cumulatively (with all builds under 90 seconds).  That's a huge improvement.
The one problem is that it doesn't clean the bundle, so the bundle will grow infinitely as new gem versions are released and get installed in our bundles.  I'm not sure what to do about that yet.  I'll go open a PR in rspec-dev with these changes.

Closing in favor of #149.


Test fx update

Ability to login interactively on .NET 4.5
Tests for interactive login
Ability to inject custom environment (e.g. brazilUs, German cloud etc)
Tests for custom environment

Splitting this PR into two PR. Closing this one.


Load management should be 'off' by default and the new profiles should be used

This has to happen before Monday 7-6-2015 :worried:

The first thing is to have load management 'off' by default. It would be nice if it could be toggled but that is a nice-to-have.

Secondly, the new profiles should be used if possible. For base-load, they consist of a flexible and an inflexible part. Both parts should be added when load management is 'off'. The rest likely works out of the box (right @antw ?)

The first thing is to have load management 'off' by default. It would be nice if it could be toggled but that is a nice-to-have

How can I tell if it's turned on right now?

How can I tell if it's turned on right now?

I don't know. @antw told me it was on :smile:

On this line, "flexibility" is set to true. To turn it off, set it to false.

The rest likely works out of the box (right @antw ?)

Yep! The inflexible part will need to be a new Technology added to the database; set its behavior attribute to "optional" to get the expected result.


[SPARK-48280][SQL][FOLLOW-UP] Add expressions that are built via expressionBuilder to Expression Walker

What changes were proposed in this pull request?
Addition of new expressions to expression walker. This PR also improves descriptions of methods in the Suite.
Why are the changes needed?
It was noticed while debugging that startsWith, endsWith and contains are not tested with this suite and these expressions represent core of collation testing.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test only.
Was this patch authored or co-authored using generative AI tooling?
No.

@cloud-fan ready for merge


feat(): previews custom template

And here we are !
This is the documentation related to the previews customization.
I hope everything is clear, I'm somewhat sleepy today!

Thank you.
It's ok, the only thing that I suggest to change is the section Add additional data in the ModalImage objects because it can be another live example.
I suggest to create another dedicated page for the live example with preview template + additional data.

So be it.

Thank you. Merged


Fix GroupByParam to return original param string

Page.GroupByParam function internally uses Page.GetParam to get a
parameter value for a key of a page group but now Page.GetParam returns
a lowercase character string every time. It has no need to using
lowercase character string as a group key value and it confuse a
function user.
This fixes it to keep and return an original parameter string as a group
key value.
Fix #1564

 You should sign our Contributor License Agreement in order to get your pull request merged.

Merged in 139be09


[FLINK-6886][table]Fix Timestamp field can not be selected in event t…

In this JIRA. will fix the exception when we run the folllows SQL:
SELECT name, max(num) as myMax, TUMBLE_START(rowtime, INTERVAL '5' SECOND) as winStart,TUMBLE_END(rowtime, INTERVAL '5' SECOND) as winEnd FROM T1 GROUP BY name, TUMBLE(rowtime, INTERVAL '5' SECOND)
Exception Info:
org.apache.flink.table.api.TableException: The field types of physical and logical row types do not match.This is a bug and should not happen. Please file an issue.

	at org.apache.flink.table.api.TableException$.apply(exceptions.scala:53)
	at org.apache.flink.table.api.TableEnvironment.generateRowConverterFunction(TableEnvironment.scala:721)
	at org.apache.flink.table.api.StreamTableEnvironment.getConversionMapper(StreamTableEnvironment.scala:247)
	at org.apache.flink.table.api.StreamTableEnvironment.translate(StreamTableEnvironment.scala:647)

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

I think the root cause is that TUMBLE_START inherits the wrong type (TimeIndicatorRelDataType) from rowtime column.  So maybe a better solution is to re-create a RelDataType from optimizedPlan's  rowType and orignalPlan's rowType and pass into the getConversionMapper method. I create a simple commit for this: https://github.com/wuchong/flink/commit/82c17ab45699f5f9beb925b156e760ebdeff79fb   What do you think? @sunjincheng121  @fhueske
BTW, do we really need so many IT cases for this ?

Hi @wuchong Thanks very much for your reviewing. According to your suggestions and our discussion, I made the following two changes:

Reduce ITCase, remove all the ITCase which added in TableSoruceITCase.
Replace schema: RowSchema param to fieldNames: Seq[String].

@twalthr I appreciated if you can take look at the change #2.
Best,
SunJincheng

Hi @fhueske I have update the PR. according your suggestion. Please have a look at the changes.
Best,
SunJincheng

Please see my message in the 1.3.1 thread on the dev@ list :)


Keyboard navigation (a11y)

📝 Provide a description of the new feature
I'd like to be able to navigate through Gitify by only using my keyboard. (Following #995)
➕ Additional Information
Most elements are missing a focus style, which makes the keyboard navigation impossible.
This feature would be very useful for both power-users and/or users with disabilities.
Let's make Gitify more inclusive! 😁

I haven't done any PoC for now, but I'd like to start contributing again so I might try and time to work on this -- if you approve the idea :)

I haven't done any PoC for now, but I'd like to start contributing again so I might try and take some time to work on this -- if you approve the idea :)

Absolutely worth exploring, @adufr


9397: search for providers, facilities, senders via new submitters API

This PR adds the endpoint for fetching the submitters for a particular receiver
Test Steps:

If you don't have any data locally, submit some reports through the legacy pipeline (I have data sent to the ignore.HL7 receiver
Run

curl --location 'http://localhost:7071/api/v1/receivers/ignore.HL7/deliveries/submitters/search' \
--header 'Content-Type: application/json' \
--data '{
    "sort": {
        "direction": "DESC",
        "property": "type"
    },
    "pagination": {
        "page": 1,
        "limit": 10
    },
    "filters": [
        {
            "value": "2023-05-21T00:00:00+00:00",
            "filterName": "UNTIL"
        }
    ]
}'

and test that adjusting the filter (and trying the SINCE filter) works as expected as well as pagination and sorting.
Changes

Adds a new endpoint for fetching submitters to a particular receiver
Updates ReportGraph to fetch metadata based on the item lineage rather than just the report lineage

Checklist
Testing

[x] Tested locally?
[x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[x] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

#9397
#9403
Will be used to render the following:

To Be Done
Specific Security-related subjects a reviewer should pay specific attention to

Note:  This actually be usable is still pending the devops team finishing the rest of the db maitenance

Manual testing still returns expected results

Back to you @snesm


Add [BRAVE COIN DISTRIBUTION coin.bravepay.net] #wallet GBIUB3…PGRPXP

Address: GBIUB3KMEQ4DXNMAXNOODVYRZUG6OGI6XNOQK2C5HTWZ2HKCPFPGRPXP
Tags: wallet
Title: BRAVE COIN DISTRIBUTION  Domain: coin.bravepay.net
Requested by @batcode80

combined with
https://github.com/stellar-expert/public-directory/issues/325

done


using ingot from Rats mod is not compatible: 1.20.1

Thanks for reporting, I'll look into it.

The issue is not with rats but with the armour mod. Which mod is that from

it was from alexsmobs, but i also tested with a gold chestplate with a resourcepack

I can't reproduce this. What is the exact mod and texture pack you are using for that chestplate? All of alex's mobs armour work.

https://www.curseforge.com/minecraft/texture-packs/nekos-enhanced-tools-and-armor/comments

This works as expected

please can you provide your latest.log


Requiring modules in a test

I want to watch my JS modules and have the tests run each time I make a change.
Here's my example test spec:
var test = require('tape');
test('returns 1', function (t) {

  var valueReturner = require('./valueReturner');

  t.plan(1);

  t.equal(valueReturner(1), 1; }

);

Each time this runs the valueReturner module executes as it did the first time the test was run. Is there a way to re-require the module each time the test runs?

Woops I didn't see issue https://github.com/yuanqing/gulp-tape/issues/16
I'll close this one.