[bugfix] Do not set up Spack shell support

I have two-fold motivations for this:

I'm trying to use reframe with spack build system on a system where activating shell support seems to screw something up
not enabling shell support lets us skip the line https://github.com/eth-cscs/reframe/blob/f996fabf25a35f3bb2a5b7090dd0ea4bf327bace/reframe/core/buildsystems.py#L872 which is very useful when using https://github.com/eth-cscs/spack-batteries-included/ with the single squashfs file (there is no material $(spack location --spack-root)/share/spack/setup-env.sh file on disk, so this line would fail).  Also, that line caused problems in the past (see #2097, now solved), and not activating the shell support just makes things more transparent.

As an added bonus, this PR has a negative net diff :slightly_smiling_face:

Hello @giordano, Thank you for submitting the Pull Request!

In the file unittests/test_buildsystems.py:

Line 269:80: E501 line too long (80 > 79 characters)
Line 278:80: E501 line too long (86 > 79 characters)

Do see the ReFrame Coding Style Guide

Can I test this patch?

ok to test

Codecov Report

Merging #2424 (ae1d5ad) into master (f996fab) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
- Coverage   85.67%   85.66%   -0.02%
==========================================
  Files          56       56
  Lines       10466    10458       -8
==========================================
- Hits         8967     8959       -8
  Misses       1499     1499

Impacted Files
Coverage Δ

reframe/core/buildsystems.py
96.20% <100.00%> (-0.03%)
:arrow_down:

reframe/frontend/executors/policies.py
92.41% <0.00%> (-0.13%)
:arrow_down:

reframe/utility/osext.py
84.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f996fab...ae1d5ad. Read the comment docs.


Marker Clusterer Marker Customization

Is your feature request related to a problem? Please describe.
Enhancement request: Allow for cluster marker customization
Does this feature exist in the Google Maps SDK for android and iOS? Please link the documentation for this feature.
Google Maps Marker Clustering
Describe the solution you'd like
Either enableClustering method to accept an optional parameter for a custom renderer, or a setClustererRenderer method in which parameters can be passed to customize the cluster marker

are you able to cluster at all with this library?


Battle State Manager

Added a 'BattleStateMonoSystem' to keep track and broadcast changes in battle states

So I went and thought about the question you asked concerning why we need to keep the SetState and the StateChanged Message Events consistent.
So, in our GameStateMonoSystem the SetState method looks like this:
        private void SetState(GameState nextState)
        {
            if (currentState == nextState)
            {
                Debug.LogWarning($"Game is already in \"{nextState}\" state.");
                return;
            }

            prevState = currentState;
            GameManager.Publish(new GameStateChangedMessage(prevState, nextState));
            currentState = nextState;
        }

And our Message Event for GameStateChangedMessage reads like this:
    internal sealed class GameStateChangedMessage : IMessage
    {
        public GameState PrevState { get; }

        public GameState NextState { get; }

        public GameStateChangedMessage(GameState prevState, GameState nextState)
        {
            PrevState = prevState;
            NextState = nextState;
        }
    }

While the code you wrote setting the BattleState and and the Message Event for BattleStateChangedMessage accomplish the same goal, having one Finite State Machine use a different order of operations than another, and communicate the state change in a different way (i.e. prevState/nextState vs currentState/prevState) means that the various state machines in the project communicate changes in states slightly differently.
This slight difference in communication the state change means that we'll need to treat these messages differently, resulting in slightly different code when reaction to a state change. That would look a bit like the following:
In one controller we might want to react to the GameState changing. In the current setup we'd check the NextState and compare it to the PrevState.
        private void OnGameStateChangedMessage(GameStateChangedMessage message)
        {
            if (message.NextState == GameState.Exploration && message.PrevState == GameState.Battle)
            {
                ReturnToPreviousExplorationScene();
            }
        }

In another controller we might want to react to the BattleState changing. Note that the following code is functionally the same, but the inconsistency in how the states are assigned, and how the StateChangedMessage is communicated adds a bit of mental overhead, since it differs from how we treat our GameStates:
        private void OnBattleStateChangedMessage(BattleStateChangedMessage message)
        {
            if (message.curState == BattleState.None && message.prevState == BattleState.GameOver)
            {
                ReturnToMainMenu();
            }
        }

By keeping the Message Events for all of our finite state machines consistent, we're being kind to other developers, as they can trust that each StateChangedMessage communicates the same information, and that both our GameState and BattleState finite state machines work the same internally.


Adds /features/get-by-sno endpoint

This is a GET request that can be hit to retrieve all the properties of a region. The format is:
features/get-by-sno?sno=<serial_number>

Would be useful to add a comment about how it can be used in the file

@ankithkanderi24 There you go - added it in.


Should we give meltano engineering team access to all repos?

We've been giving Meltano core engineers repo access on a one off basis by adding them to the repo specific Github teams. It also looks like theres inconsistent levels of access for the repo teams (some write and some maintainers).
Should we give the meltano engineering team maintainer access to all repos to avoid this one off permission setting? Then it might make sense to have all repo teams be consistently write level access and not maintainer.
@WillDaSilva raised a point to consider - that we might not want to do this to avoid fall out if an account is compromised. It's probably a tradeoff we want to weigh. Either simpler maintenance for engineering team for on/offboarding or higher security in case of compromise but harder to manage on/offboarding.
@aaronsteers @WillDaSilva @kgpayne what do you think?
Proposed

[ ] add meltano engineering team as maintainer to all repos
[ ] convert permissions for all repo teams to only write access
[ ] document the process in https://github.com/MeltanoLabs/Meta#permissions-and-teams

Context from Slack: https://meltano.slack.com/archives/C03GKHWS0HM/p1664456467035269?thread_ts=1664450851.731359&cid=C03GKHWS0HM

@WillDaSilva I added your point around limiting fall out to the description above.

@pnadolny13 - In the context of MeltanoLabs, yes, I agree we can give the Meltano Team "Write" on all repos.


UnboundLocalError is not returned

x = 10
def foo():
    x += 1
    print(x)
foo()

Expected
Traceback (most recent call last):
  File "test3.py", line 5, in <module>
    foo()
  File "test3.py", line 3, in foo
    x += 1
UnboundLocalError: local variable 'x' referenced before assignment

Actual
11

This might be related to #1333

In fact, there is no UnboundLocalError defined at all.

In fact this is because the generated bytecode is wrong.
def foo():
    x += 1

dis(foo)
# RustPython bytecode
""""
                 0 LoadName             (x, Free)
                 1 LoadConst            (1)
                 2 BinaryOperation      (Add, true)
                 3 StoreName            (x, Free)
""""
# Python bytecode
"""
            0 LOAD_FAST                0 (x)
              2 LOAD_CONST               1 (1)
              4 INPLACE_ADD
              6 STORE_FAST               0 (x)

"""

RusyPython bytecode Load x from free scope,  it means that  load variables globally when reading from a local scope fails.
In cpython, it just load variable from locals.
//ceval.c 1329
        case TARGET(LOAD_FAST): {
            PyObject *value = GETLOCAL(oparg);
            if (value == NULL) {
                format_exc_check_arg(tstate, PyExc_UnboundLocalError,
                                     UNBOUNDLOCAL_ERROR_MSG,
                                     PyTuple_GetItem(co->co_varnames, oparg));
                goto error;
            }

This seems to be fixed now


loss tend to be nan or inf

Thank you for this great work!
May I ask whether the reported results are from fake_quantization=True or fake_quantization=False? When I use fake_quantization=False, the training doesn't succeed for the gsm8k task for llama-2-7b, always leading to nan or inf loss.

Resolved. It is caused by the cuda memory. Since my A100 only has 40GB, I need to decrease the per_device_batch_size

@yxli2123 Hi, Thanks for your great work. I find that loftq has been merged into peft in https://github.com/huggingface/peft/pull/1150, then I run examples/loftq_finetuning with commands in https://github.com/huggingface/peft/blob/main/examples/loftq_finetuning/README.md:
python train_gsm8k_llama.py \
    --model_name_or_path LoftQ/Llama-2-7b-hf-4bit-64rank \
    --output_dir exp_results/gsm8k/llama-2-7b/bit4-rank64/lr3e-4 \
    --learning_rate 3e-4  \
    --seed 202 \
    --dataset_name gsm8k \
    --dataset_config main \
    --pad_to_max_length \
    --max_source_length 128 \
    --max_target_length 256 \
    --num_train_epochs 5 \
    --per_device_train_batch_size 4 \
    --per_device_eval_batch_size 4 \
    --gradient_accumulation_steps 4 \
    --with_tracking \
    --report_to tensorboard

But I also met this problem: loss tend to be nan after ~1200 steps.

Hi @PuNeal, I have rewritten the training script. Please try again.

I didn't meet this problem again with the new update


feat: please add an option to enable/disable foreground notification

Description
Clearly describe what you are looking to add. The more context the better.
Requirements

[ ] Checklist of requirements to be fulfilled

Additional Context
Add any other context or screenshots about the feature request go here.

Closes #1 as duplicate of #2. Closes #1


Test commit from the past

+code-checks

A new Pull Request was created by  iarspider for master.
It involves the following packages:

RecoJets/FFTJetProducers (reconstruction)

iarspider, jfernan2, mandrenguyen can you please review it and eventually sign? Thanks.
ahinzmann, clelange, gkasieczka, jdamgov, jdolen, mariadalfonso, missirol, nhanvtran, rappoccio, schoef, seemasharmafnal this is something you requested to watch as well.
iarspider you are the release manager for this.
cms-bot commands are listed here

cms-bot internal usage

+reconstruction


Replace deprecated np.rank with np.ndim

Rank function has been deprecated.
http://docs.scipy.org/doc/numpy/release.html#rank-function

We are now directing pull requests for bug fixes and feature branches into the dev branch. Rolling releases will be made from prs off of dev into master. We will update the docs to reflect this soon, so for now please reissue this pr to target dev not master.

Sure. No problem :)


Missing LICENSE file

Same issue as mentioned in issue PauliBuccini/meteor-linkedin#7. I've found a bug and would like to contribute a fix but need to know the license first.
I notice that your package is a fork of @yefim's package so I mentioning him here in hopes that he will indicate the license associated with his original repo.

Added MIT licence

Thanks!


Consider a "zero config" plugin architecture

Problem Description
It's currently somewhat cumbersome to add customizations to Library. People have used Docker-based solutions, or simply forked the repo in order to more easily get customizations added to the app.
Feature
It would be nice to add a more simple way to distribute and add plugins to Library. A few possibilities

A config.yaml or customizations.yaml that allowed you to pass URLs of github gists that include middleware
A plugin API and naming pattern (e.g. library-plugin-foo or @your-scope/library-plugin-foo) that automatically configured itself when installed alongside library, similar to how Parcel handles plugins.

Somewhat related to https://github.com/nytimes/library/issues/146


Set up CI with Azure Pipelines

OPS Build status updates of commit 2e6e665:
:clock10: Preparing: average preparing time is 2 min(s) 1 sec(s)

OPS Build status updates of commit 2e6e665:
:clock10: Incremental building: average incremental building time is 19 sec(s)

OPS Build status updates of commit 2e6e665:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-pipelines.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: modify data_store behavior when getting structs.

Feature Request
Describe the Feature Request
In GMX, functions to get Order, Deposit, Withdrawal, Market and Position  return an empty struct if there is no associated object with the given key. In our implementation we are returning None, so it gives a different behavior an could lead to unexpected results. We should return Default struct instead.
Describe Preferred Solution
Modify the five concerned getter functions in data_store.cairo to return Default struct when there is no associated struct to given key.

Can I get this one, pls?

Sure !


fasta -> GFA

gfa_stats (and other utilities) rely on the file being in GFA format. A FASTA file of contigs could be converted to valid GFA containing just a header and sequence lines, allowing use of such utilities.
I wrote a small python script to do this but it should get brought into the cpp code, probably somewhere in the gfa_spec_convert CLI.

Closing, python is fine in my opinion.


zero in file names

If css file contains any path to file with name ending with 0, i.e. "bg-section10.jpg", CSS-minify resolve it to "bg-section1.jpg" which breaks dependencies.

This is not happening anymore :bowtie:. Thanks!


java.io.EOFException while processing SSTables

We are trying out POC for bulk load of data from Cassandra (version 3.0.9) to HDFS. But running into EOFException. Please find the command that we are using. Any help in this matter is greatly appreciated.
hadoop jar /opt/aegisthus/aegisthus-hadoop-0.3.0-SNAPSHOT.jar com.netflix.Aegisthus -inputDir /raw/cassandra/sstables -output /raw/cassandra/json -Daegisthus.columntype=UTF8Type -Daegisthus.keytype=UTF8Type -libjars lz4-1.2.0.jar

I should looked at related issues before opening this one. Looks like the current version only supports 2.x Cassandra versions.

Hi Pankaj,
I'm closing this issue because, as you said, Aegisthus only works with C* 2.x.  I updated the README to make this clear to people and save them the inconvenience you had.


use enum in attribute?

Hi,
Is it possible to use an enum value in the has_permissions attribute at all? I understand that what i have below is not valid syntax but want to understand if something like this is possible?
from:
#[has_permissions("CanRead")]

to:
#[has_permissions(Permissions::CanRead.to_string())]

Well, I'm gonna do some refactoring soon with one more feature.
So 'll try to change it to expression instead of only string 🤔

Btw, I probably misunderstood the initial question. Have you checked this example (/examples/enum-role)?
It's currently possible to use enums, but you need to pass their path as strings "MySuperEnum::User"


remove references to specific services

needed cleanup - after this, more work to do

Not sure why (or if) this is broken: ##[error]Input required and not supplied: github_token
Does it just need a docs reviewer?

Just checked, and I think docs review is all it needs now.
Alanna Casey
Security & Compliance
<EMAIL_ADDRESS>civicactions.com | @civicactions
On Thu, Sep 17, 2020 at 1:45 PM Fen Labalme<EMAIL_ADDRESS>wrote:

Not sure why (or if) this is broken: ##[error]Input required and not
supplied: github_token
Does it just need a docs reviewer?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/CivicActions/handbook/pull/625#issuecomment-694394364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOARGV7S2NMVNXYFAN3FY3LSGJDLVANCNFSM4RPTPOPQ
.

Replaced with #626


should this be updated to include a newer version of Nuxt?

https://github.com/nuxt-community/starter-template/blob/308ca01d6520629dab11316b9717a68fd106c844/template/package.json#L16

It's not necessary with the caret ranges (^ notation)
npm will install the lastest version
^1.0.0 is equal to >= 1.0.0 < 2.0.0

@NicoPennec great, thanks for that bit of information!


Added Translation for Planet Types in locale.ini(Fixes #1076)

Have added the translations in locale.ini and added a .replace() function in activity.js

Nice. Thanks.
Just one thing: do lot localize strings because it's better to let native people do the translation instead of using Google translate.


Feature/lite

Hi
I did some modifications, and added a code alignment feature.

File rearrangement : extension.ts is divided into three files : extension.ts, hover.ts, instantiation.ts. hover.ts and instantiation.ts contain only codes for their own function. extension.ts imports main function from these files and is responsible for only command registration stuff.
Modify the module instantiation : The instantiation snippet is formatted (port alignment) before the insertion.
A new command to align the selected codes.  The command can be activated from menus or keybind. Here's the using example http://gph.is/2ezF7wX

Thank you for sending me your PR.
I'll review it ASAP.

Pulled.


Rspec crashes when running with bundler on 1.9.3p0

When i ran bundle exec rspec spec on 1.9.3 i recieved this error.
The same config works on 1.9.2
https://gist.github.com/1329819

That looks like it's coming from ruby-debug-base19-0.11.25. Do you get the same error if you remove ruby-debug19 and it's dependencies from your Gemfile?

Oh - just realized this is the wrong tracker. Please report this to http://github.com/rspec/rspec-core/issues and continue the conversation there.

BTW - I just poked around and this is a known issue with ruby-debug19 (actually linecache19). Here are a few references:
https://github.com/mark-moseley/linecache/issues/8
http://redmine.ruby-lang.org/issues/5193
https://github.com/ruby/ruby/pull/47

Thanks for that, yeah I was poking around the error again as well.  Sorry about the non-issue!


Getting Access Denied after Deployment

Hi
i am installing LambStatus with your "getting started" guide. I am receiving the E-Mail after ~15 Minutes but get an Access Denied Error from S3. Do i have to tweak the S3 Bucket after installation?
<Error> AccessDenied <Message>Access Denied</Message>
Thank you!

I am experiencing the same issue, have waited approx 1 hour after install..
<Error> AccessDenied <Message>Access Denied</Message> <RequestId>XXX</RequestId> <HostId> XXX </HostId> </Error>

Please check the doc: https://lambstatus.github.io/get-started#troubleshooting

The doc just says to wait 10-20 minutes.  I'm having the same problem 40 minutes after the deployment completed.  I checked the S3 permissions, and the static files including the index.html are viewable only by owner.  I'm probably not the owner--I'm not the only engineer on this project, although I have elevated permissions.  Are you assuming that only the owner will access the site?
I went in to S3 and made the index.html for the admin page public, and then I could load it via the emailed link, but of course the page is broken because all the other files [javascript, etc.] are still private.  Do I need to make them all public in order for the dashboard to be usable?
Thanks!

LambStatus uses the Origin Access Identity for S3 access. So it's ok that the S3 buckets are not public.
Do you still have a problem? If yes, check if you have any items on the Origin Access Identity page below:
https://console.aws.amazon.com/cloudfront/home#oai:

@elemenoeric i just checked the other day and then it worked.

Indeed, it's started working for me now.  I thought cloudfront must be done already because the redirect worked when I made index.html world-readable, but apparently there's more going on than that, and waiting yet longer did the trick.  Sorry about the noise, and thanks for your help!


Type Declarations not Working for ESModule

When trying to import this package from an ESModule TypeScript ecosystem, it won't work.
TypeScript shows an error stating that the corresponding types could not be found.
This is caused by the package.json setting the file for import calls to be index.mjs.
The setting mentioned before causes TypeScript to go search for the type declarations at gulp-esbuild/index.d.mts.
There are basically two ways on how to fix this:
A separate index.d.mts file can be created or - if both type declarations match - the types can be set to resolve to index.d.ts:
"exports": {
    "types": "./index.d.ts",
    "default": "./index.mjs"
}

Sadly, the type declarations do not match (index.js uses an export assignment, index.mjs uses a default export), so I think a separate type declaration file should be the proper solution.
I'll go create a PR concerning this matter.

Hello @manuth! Thank you for the issue!
Can I see an example to reproduce the problem? I just don't quite understand what's going on.

Sure - will do asap

About This Error
Using ESModules in TypeScript
TypeScript allows you to emit modules both written as CommonJS or as ESM. The corresponding setting is called module:
https://www.typescriptlang.org/tsconfig#module
Files written in CommonJS can import ESModules using dynamic import()s:
(await import("gulp-esbuild"))({});

Files written in ESM can import other ESModules using import statements:
import gulpEsbuild from "gulp-esbuild";

gulpEsbuild({});

The module Setting
In tsconfig.json, When setting module to CommonJS, TypeScript will use the types field (if present) or the main  field in your package.json file in order to determine the corresponding types, so everything is working out just fine.
However, when setting module to Node16, NodeNext or ES2022, the module resolution of TypeScript changes.
Just like NodeJS, TypeScript will first check the file extension.
.cts/.cjs files will be considered CommonJS, .mts/.mjs will be considered as ESModule. For .ts/.js files, it will check the project's package.json and decide, depending on whether the package.jsons type is set to commonjs or module, whether the corresponding file is cjs or mjs.
If nothing else is specified (for example using the types-projerty in package.json or the exports["."].import.types in package.json), for .js files, TypeScript will look for ".d.ts" files, for .cjs files, TypeScript will look for .d.cts
Furthermore - and this is the point where the use of gulp-esbuild breaks - TypeScript checks the exports field and, based on whether the file performing the import is cjs or mjs, check the import or require field in the package.jsons exports.
In the exports field, people can specify custom paths to the type declarations if they'd like to do so:
{
    "exports": {
        "-": {
            "import": {
                "types": "./index.d.ts", // TypeScript will resolve types to "[gulp-esbuild]/index.mjs"
                "default": "./index.mjs" // node will resolve "gulp-esbuild" to "[gulp-esbuild]/index.mjs"
        }
    }
}

For further reading, you might want to have a look at this: https://www.typescriptlang.org/docs/handbook/esm-node.html
This means, that, when importing (instead of requireing) your module from an ESM file, TypeScript would resolve to [gulp-esbuild]/index.mjs. Based on this, TypeScript will try to find its corresponding type declarations at [gup-esbuild]/index.d.mts resulting in an error.
Reproducing The Error

Create a new npm project (in fact, an empty folder will just do)
Install typescript and gulp-esbuild
Create a tsconfig.json file which has its module set to Node16, NodeNext or ES2022 (and its moduleResolution undefined):{
    "compilerOptions": {
        "module": "ES2022",
        "lib": [
            "ES2020"
        ],
        "target": "ES6"
    },
    "include": [
        "./src/**/*"
    ]
}

Create a file which is an ESModule file (either by setting type to module or by creating an .mjs file
Import the gulp-esbuild module using an import-statement:import gulpEsbuild from "gulp-esbuild";

Take note, that TypeScript reports an error that the types could not be found.

I tried your reproduction sequencing but I didn't face any types problems. What did I do wrong?
Example here https://github.com/ym-project/gulp-esbuild-issue17

It's nothing big, really
TypeScript won't do actual type checking on .js files on its own without tweaking it a little.
You might want to add something like this to your compilerOptions:
{
    "compilerOptions": {
        "allowJs": true, // Allow JavaScript files to be part of your project
        "checkJs": true, // Enable type checking in JavaScript files

        /* With `outDir` unspecified, compiling a JavaScript file would cause it to overwrite itself.
         * Adding this option will tell TypeScript that this project is not supposed to be compiled and
         * thus not causing JavaScript files to overwrite themselves. */
        "noEmit": true
    }
}

As I understand typescript documentation correctly, module resolution Classic will work correctly only if the package has typing via @types/package library.
You can run command tsc --noEmit --traceResolution and see:
For gulp-esbuild
======== Resolving module 'gulp-esbuild' from '/home/ymdev/Dev/esbuild-test/src/file.mjs'. ========
Explicitly specified module resolution kind: 'Classic'.
File '/home/ymdev/Dev/esbuild-test/src/gulp-esbuild.ts' does not exist.
File '/home/ymdev/Dev/esbuild-test/src/gulp-esbuild.tsx' does not exist.
File '/home/ymdev/Dev/esbuild-test/src/gulp-esbuild.d.ts' does not exist.
File '/home/ymdev/Dev/esbuild-test/gulp-esbuild.ts' does not exist.
File '/home/ymdev/Dev/esbuild-test/gulp-esbuild.tsx' does not exist.
File '/home/ymdev/Dev/esbuild-test/gulp-esbuild.d.ts' does not exist.
File '/home/ymdev/Dev/gulp-esbuild.ts' does not exist.
File '/home/ymdev/Dev/gulp-esbuild.tsx' does not exist.
File '/home/ymdev/Dev/gulp-esbuild.d.ts' does not exist.
File '/home/ymdev/gulp-esbuild.ts' does not exist.
File '/home/ymdev/gulp-esbuild.tsx' does not exist.
File '/home/ymdev/gulp-esbuild.d.ts' does not exist.
File '/home/gulp-esbuild.ts' does not exist.
File '/home/gulp-esbuild.tsx' does not exist.
File '/home/gulp-esbuild.d.ts' does not exist.
File '/gulp-esbuild.ts' does not exist.
File '/gulp-esbuild.tsx' does not exist.
File '/gulp-esbuild.d.ts' does not exist.
Directory '/home/ymdev/Dev/esbuild-test/src/node_modules' does not exist, skipping all lookups in it.
File<EMAIL_ADDRESS>does not exist.
Directory '/home/ymdev/Dev/node_modules' does not exist, skipping all lookups in it.
Directory '/home/ymdev/node_modules' does not exist, skipping all lookups in it.
Directory '/home/node_modules' does not exist, skipping all lookups in it.
Directory '/node_modules' does not exist, skipping all lookups in it.
File '/home/ymdev/Dev/esbuild-test/src/gulp-esbuild.js' does not exist.
File '/home/ymdev/Dev/esbuild-test/src/gulp-esbuild.jsx' does not exist.
File '/home/ymdev/Dev/esbuild-test/gulp-esbuild.js' does not exist.
File '/home/ymdev/Dev/esbuild-test/gulp-esbuild.jsx' does not exist.
File '/home/ymdev/Dev/gulp-esbuild.js' does not exist.
File '/home/ymdev/Dev/gulp-esbuild.jsx' does not exist.
File '/home/ymdev/gulp-esbuild.js' does not exist.
File '/home/ymdev/gulp-esbuild.jsx' does not exist.
File '/home/gulp-esbuild.js' does not exist.
File '/home/gulp-esbuild.jsx' does not exist.
File '/gulp-esbuild.js' does not exist.
File '/gulp-esbuild.jsx' does not exist.

For react
======== Resolving module 'react' from '/home/ymdev/Dev/esbuild-test/src/file.mjs'. ========
Explicitly specified module resolution kind: 'Classic'.
File '/home/ymdev/Dev/esbuild-test/src/react.ts' does not exist.
File '/home/ymdev/Dev/esbuild-test/src/react.tsx' does not exist.
File '/home/ymdev/Dev/esbuild-test/src/react.d.ts' does not exist.
File '/home/ymdev/Dev/esbuild-test/react.ts' does not exist.
File '/home/ymdev/Dev/esbuild-test/react.tsx' does not exist.
File '/home/ymdev/Dev/esbuild-test/react.d.ts' does not exist.
File '/home/ymdev/Dev/react.ts' does not exist.
File '/home/ymdev/Dev/react.tsx' does not exist.
File '/home/ymdev/Dev/react.d.ts' does not exist.
File '/home/ymdev/react.ts' does not exist.
File '/home/ymdev/react.tsx' does not exist.
File '/home/ymdev/react.d.ts' does not exist.
File '/home/react.ts' does not exist.
File '/home/react.tsx' does not exist.
File '/home/react.d.ts' does not exist.
File '/react.ts' does not exist.
File '/react.tsx' does not exist.
File '/react.d.ts' does not exist.
Directory '/home/ymdev/Dev/esbuild-test/src/node_modules' does not exist, skipping all lookups in it.
Found 'package.json' at<EMAIL_ADDRESS>'package.json' does not have a 'typesVersions' field.
File<EMAIL_ADDRESS>does not exist.
'package.json' does not have a 'typings' field.
'package.json' has 'types' field 'index.d.ts' that references<EMAIL_ADDRESS>File<EMAIL_ADDRESS>exist - use it as a name resolution result.
======== Module name 'react' was successfully resolved to<EMAIL_ADDRESS>with Package ID '<EMAIL_ADDRESS>========

As you can see, typescript goes node_modules folder only once and only for @types/* package. So I think we can not fix this problem without @types/gulp-esbuild package.

If we set "moduleResolution": "nodenext", we can fix this without new files. Just change package.json file
  ...
  "exports": {
    "import": {
      "types": "./index.d.ts",
      "default": "./index.mjs"
    },
    "require": {
      "types": "./index.d.ts",
      "default": "./index.js"
    }
  },
  // for old versions
  "types": "index.d.ts",
  "main": "index.js",
  ...

Yes but the index.d.ts types mismatch index.mjs a tiny bit.
You might notice the little differences in my PR

Ok. I have understood.
I will check your PR in the evening and merge it.

Awesome! Thank you so much for taking time 😄


hession protocol is not supported?

Question
When I use the Hession protocol, the tracking is separated. There is no connection between them. Do I need the relevant plugins?

please assign to me. I want have try this

@xbkaishui A tip. Please check the hession protocol, whether it provides headers for propagation. Some reported this as a blocker.

Hession protocol is widely used in alipay(sofa freamwork), it is just on top of http, I think it's easy to support it,  I will add spring related hession first

No activity for a long time.


add cmd blacklist

:white_check_mark: Aikido Security check OK. No new issues were introduced. No issues were solved. View details
Scan results for commit: 303c7793a6d55a2a918ce38fcefa2c707c6e846e

:white_check_mark: Aikido Security check OK. No new issues were introduced. No issues were solved. View details
Scan results for commit: f899cc6d15058cf23d9b6af1510ffab5cf516ddb

:rotating_light: Aikido Security found issues. 1 new HIGH issue was introduced. 1 HIGH issue was solved. View details
Scan results for commit: 8758ac2c24a854da0b1c573d6892901b875be406

:rotating_light: Aikido Security found issues. 1 new HIGH issue was introduced. 1 HIGH issue was solved. View details
Scan results for commit: 1dd4780fa7ee24229eb5d34d02ced6040bedf0ed

:rotating_light: Aikido Security found issues. 1 new HIGH issue was introduced. 1 HIGH issue was solved. View details
Scan results for commit: c7d1afc87b7af2f98618ac59553a5604392cb18a

:rotating_light: Aikido Security found issues. 1 new HIGH issue was introduced. 1 HIGH issue was solved. View details
Scan results for commit: c1fbc0ec2c141b0805721186c58b2eb931db089e


Add Code Splitting to Reduce JS Bundle Size

Our current JS Bundle has now begun to bloat to nearly an entire 5mb!
Well, 4.97mb to be exact.... That is a large file, and with a 10mb/s internet connection, that's approximately 5 seconds to load.
The reason this file is such a large size is because that 5mb file contains all the javascript, for the entire site, regardless of whether we ever even see any of the pages it contains the code for.
As the react docs say:

Code-splitting your app can help you “lazy-load” just the things that are currently needed by the user, which can dramatically improve the performance of your app. While you haven’t reduced the overall amount of code in your app, you’ve avoided loading code that the user may never need, and reduced the amount of code needed during the initial load.

One way to split a bundle is to use Route-based code splitting.

Deciding where in your app to introduce code splitting can be a bit tricky. You want to make sure you choose places that will split bundles evenly, but won’t disrupt the user experience.
A good place to start is with routes. Most people on the web are used to page transitions taking some amount of time to load. You also tend to be re-rendering the entire page at once so your users are unlikely to be interacting with other elements on the page at the same time.

Enter some multicursor editing of the imports and adding a suspense wrapper to the component, and voila, code splitting is added.
I also took this opportunity to reorganize some of the imports to be more alphabetical because with the amount of imports as we have in this file, it makes finding the import you're want easier.
Enough explanation, how about the results?
The resulting bundle js size is... smaller. 10% smaller.
I managed to reduce the bundle size from 4.97mb to 4.40mb. Not a huge improvement, but this is a very simple way to code split, without having to spend much time or effort identifying where our largest assets exist, and how to code split those separately.
At some later point, we can revisit code-splitting in-depth, but for now, this gives a fair size reduction to the initial js bundle, and anything is still better than nothing.
note: I haven't verified that every route still works and functions properly without any issue, so there may be slight issues.
One potential flaw I can think of is that we may not want to lazy load an error page / error template, in case whatever error we encounter disrupts our network and may prevents us from dynamically loading an error component and page. So this should be investigated and explored to some degree.
All the codesplit files generated:

Bundle size before codesplitting diet:

Bundle size after codesplitting diet:

Time to compile old bunlde js file without codesplitting:
Time: 123230ms

Time to compile codesplit js file:
Time: 119687ms

The timing difference seems identical within an reasonable window of error margins (though if anything it suggests codesplitting was slightly faster though, but that's likely timing error)
/endoptimization

closing this for now


doc:Update README.md

Updated README.md
Provided table of contents and added the necessary sections

Perfect! @yash2189. @all-contributors please add @arbazdiwan for doc

@all-contributors please add @yash2189 for doc


Update README

Remove Gulp Installation Instructions.

I am already working on this

Oh Right. Didn't see that early. @vipulgupta2048

Check it out, we collaborated on a commit. You don't see that every day do you.

@AniVerma17 @utkarsh2102 @akshat0047 @joybhalla @vips28 Start commenting. Even if it is just an emoji to show approval.

LGTM!


Clarification

Dear Authors,
In the Summarizer generate function,
https://github.com/SaFoLab-WISC/AutoDAN-Turbo/blob/3501f211d62b15b105bc672f39d006f7453bcb6b/models.py#L211
the model generate does  not return a dict with Strategy key, instead it returns a text.  This text is referenced at https://github.com/SaFoLab-WISC/AutoDAN-Turbo/blob/3501f211d62b15b105bc672f39d006f7453bcb6b/database_organizer.py#L169
to access the "strategy" in the returned output I just wanted to bring to your notice, may be small utility function is missing here to convert the text to json dict.
Please correct me if I missed something. Thank you.

Appreciate for your clarification, I am going to check the source code again and fix the potential bugs.

Thank you. I have a one question, when you use model like gemma-7b-it  or llama-3.1-8b-instruct as the attacker, in the final implementation of the paper, did you use, apply_chat_template() to the attacker input prompt?
Thanks for answering.

As for the summarize, we need to let it output to be specific format, so we use apply_chat_template() or prompt level regularization to formalize the output. But for the attacker, scorer, and target models, we didn't use any method like apply_chat_template().


Chart editor crashing past section 98

Describe your bug here.
I transferred a chart file from one psych engine to another, and this chart works fine until section 98 where right at the end of it it crashes. This issue does not happen when playing it normally, rather exclusively in the editor; whether it be from scrolling past said point or letting it autoplay there. It always crashes.
Command Prompt/Terminal logs (if existing)
states/editors/ChartingState.hx (line 2840)
states/editors/ChartingState.hx (line 2807)
states/editors/ChartingState.hx (line 2762)
states/editors/ChartingState.hx (line 2259)
states/editors/ChartingState.hx (line 2574)
states/editors/ChartingState.hx (line 1645)
flixel/FlxState.hx (line 203)
flixel/FlxGame.hx (line 752)
flixel/FlxGame.hx (line 682)
flixel/FlxGame.hx (line 556)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)

Uncaught Error: Null Object Reference
Please report this error to the GitHub page: https://github.com/ShadowMario/FNF-PsychEngine

> Crash Handler written by: sqirra-rng

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No.

Welp I found the issue. Not gonna lie was not expecting to find this; no wonder it crashed :>


feat(partition): Add label as meta info for partitions

Pull Request template
Why is this PR required? What issue does it fix?:
Fixes https://github.com/openebs/openebs/issues/3136
What this PR does?:
Adds label as meta information for newly created partitions.
Does this PR require any upgrade changes?:
Not sure
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[x] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@akhilerm take a look.

@akhilerm I've updated the PR, please review. Thanks.

@avats-dev . There is a corresponding unit test also for the addPartition method. Can you modify that also.

Done @akhilerm along with the test, PTAL. Thanks.

Codecov Report

Merging #494 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   46.86%   46.89%   +0.03%
==========================================
  Files          73       73
  Lines        3186     3188       +2
==========================================
+ Hits         1493     1495       +2
  Misses       1549     1549
  Partials      144      144

Impacted Files
Coverage Δ

pkg/partition/partition.go
46.15% <100.00%> (+2.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0baecdc...3167cc6. Read the comment docs.

@akhilerm PTAL, updated. Thanks for bearing with me.

@akhilerm PTAL, updated with requested changes. Thanks.

I've squashed commits into one and have signed off the commit with a better message. Thanks @akhilerm , it was a minor change but for bearing with me, I learnt a lot, specially squashing commits. PTAL

I'm open to new issues if you can think of any, for further contributions.

Thank you @avats-dev for this PR. You can sign up for Hacktoberfest swag from MayaData by entering details here: https://github.com/mayadata-io/swag/issues/new/choose


Programming issues

I need help with my programming exercises, which are not refreshing or resetting, so I can retry them. It's not refreshing; I have followed Cengage Mindtap customer support's instructions: In the Command Palette, type Codespaces: Rebuild Container. This tells your Codespace to start fresh. Select this command from the list that appears. Also, the companion must be more refreshing for me to start over.
Here's another error: I received these errors for Chapter 1, 1-4. The programming exercise's status is FAILED!
Reason: Unable to run circle.py
Error: python: can't open file '/home/runner/work/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/python/chapter1/ex04/circle.py': [Errno 2] No such file or directory
Timestamp: 2024-03-19 15:05:40.513587
Status: FAILED!
Reason: Unable to run circle.py
Error: python: can't open file '/home/runner/work/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/python/chapter1/ex04/circle.py': [Errno 2] No such file or directory
Timestamp: 2024-03-19 15:05:40.513676
Status: FAILED!
Reason: Unable to run circle.py
Error: python: can't open file '/home/runner/work/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/python/chapter1/ex04/circle.py': [Errno 2] No such file or directory
Timestamp: 2024-03-19 15:05:40.528891
Status: FAILED!
Reason: Unable to run circle.py
Error: python: can't open file '/home/runner/work/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/python/chapter1/ex04/circle.py': [Errno 2] No such file or directory
Timestamp: 2024-03-19 15:05:40.528935
Status: FAILED!
Reason: Unable to run circle.py
Error: python: can't open file '/home/runner/work/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/python/chapter1/ex04/circle.py': [Errno 2] No such file or directory
Timestamp: 2024-03-19 15:05:40.544145
Status: FAILED!
Reason: Unable to run circle.py
Error: python: can't open file '/home/runner/work/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/9780357881019-fundamentals-of-python-3e-785b3211-2d72-4a5f-b77a-1066fe102513/python/chapter1/ex04/circle.py': [Errno 2] No such file or directory
Timestamp: 2024-03-19 15:05:40.544188
Your current grade is: 0.00%
RUN CODECALCULATE GRADESUBMIT

ADD ISSUE DESCRIPTION HERE
Version: 1.87.2
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
Embedder: codespaces

/question Please continue to use Cengage Mindtap support.

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Drop support for iOS Versions older than iOS 9? FEEDBACK REQUIRED!

Nowadays the build tools, especially Xcode only support the latest iOS (=10) and latest iOS - 1 (=9). Is it reasonable to drop support for all smaller iOS versions? This would really optimise the codebase a lot. Please comment!

Fine by me.

As the minimum deployment target with Xcode 8 is iOS 8 i think I will change it accordingly.

I still target iOS 8+ but if it truly helps to do this for future releases then by all means.

I've been targeting iOS 9+ for a while now, so don't see why older versions should be supported at this point.

I still support 7, but that's just my unpopular opinion.

iOS 8 support would be great.

Funny sidenote: I downloaded Xcode 7 to test with iOS 7. But inside Xcode 7 you can not download an iOS 7 simulator anymore ...

iOS 8 is still a significant portion of users when an app is mostly used on tablets
FWIW https://david-smith.org/iosversionstats/

Thanks, totally forgot about _ iOS stats.

Tried also now Xcode 6. It does nut run on Sierra. You need to apply cruel fixes to make it work, but even than the simulator does not work (http://indiestack.com/2016/08/xcode-6-on-sierra/) Therefore it is not reasonable at all to still support iOS 7, as we can not test anymore.
iOS 8 will therefore be the minimum target.

@jmcazaux Significant portion = 5% of tablets?

9 should be fine these days

if iOS 8 is not supported anymore, I'll have to look for a replacement

@dafnedegroof Or just use a version that supports iOS 8. No need to be dramatic.

We still support iOS 8, but I agree with dropping it. We'll pin to a version that supports iOS 8 and will have yet another reason to drop iOS 8 in our app :D

We will remain on 8 for now and support always the latest version supported by Xcode.


HDDS-6177. Extend container info command to include replica details

What changes were proposed in this pull request?
When debugging some recent cluster issues related to containers, it would be useful if the details of the replicas were available in the output from the ozone admin container info <id> command.
Ideally, the ContainerReplica object, which is used to stored the replicas details on SCM would be re-used for this purpose, but it is only available in the hadoop-hdds-server-scm package, while the client code lives in the common package. Creating a dependency
Therefore I have created a new class called ContainerReplicaInfo and corresponding proto definition to send the replica details from SCM to the client, and hence display on the command output.

New unit tests and validated the new command via a docker-compose cluster.

@adoroszlai I have addressed your comments - can you have another look and see if it looks OK? Thanks!


size mismatch when load pre_trained model for testing

Hello, i trained my model with patch size 64, but the size mismatch when load the pre_trained model for test. Here are error:
RuntimeError: Error(s) in loading state_dict for Uformer:
size mismatch for conv.blocks.0.attn.relative_position_bias_table: copying a param with shape torch.Size([49, 16]) from checkpoint, the shape in current model is torch.Size([225, 16]).
size mismatch for conv.blocks.0.attn.relative_position_index: copying a param with shape torch.Size([16, 16]) from checkpoint, the shape in current model is torch.Size([64, 64]).
size mismatch for conv.blocks.1.attn.relative_position_bias_table: copying a param with shape torch.Size([49, 16]) from checkpoint, the shape in current model is torch.Size([225, 16]).
size mismatch for conv.blocks.1.attn.relative_position_index: copying a param with shape torch.Size([16, 16]) from checkpoint, the shape in current model is torch.Size([64, 64]).
Doesn't it work when training with patch size 64?

I got it! The input_resolution of Bottleneck is 4 when the patch size 64, so the win_size is 4 too. The win_size 4 is different from default win_size 8, so cause size mismatch.


lumen

I installed this package by composer but the below error occurred:
Class apm-agent does not exist.
Is there any requirements for this package? Or what should I do for config that?

Firstly, did you register the provider? do you have the agent extension installed on your host machine?
Secondly, due to the breaking changes in the elastic apm agent, it'll break. it will not be maintained due to the breaking changes. after the agent become stable, will work on it hopefully.

I register  the provider in app.php  and install the apm-agent-php from https://github.com/elastic/apm-agent-php/releases/tag/v1.0.0
Now I get the following error:
Call to undefined method Elastic\Apm\Impl\Span::setLabel()

Firstly, the package was unmaintained due to the instability of the dependency. and check the installation process. https://www.elastic.co/guide/en/apm/agent/php/current/setup.html

seyed php agent extention works and sends all the reports to the apm system but your package gives the error I told you about.

If you missed the readme, please go through it again. Thanks.

https://github.com/ssi-anik/elastic-apm-php/blob/03ddc1c2283474394a309dd42e0d5de7aa9cccf8/readme.md


Reindex vault

As plugin uses frontmatter to relate notes to a journal.
Existing notes are not known for plugin unless they follow same folder/name structure and are opened through plugin command or code blocks.
Idea is to add UI to run reindexing process through the vault.

Released in 1.3.0


recommend contributions to rebase upstream/dev prior to PR

For future PRs and contibutions, it may be worth including in how-to-sync-your-BioCRNPyler-fork
git fetch upstream dev
git checkout <branch_with_amazing_new_feature>
git rebase upstream/dev
git push origin <branch_with_amazing_new_feature>

NB git fetch upstream dev without /, while git rebase upstream/dev with.
This is motivated by comments in #100 .

I have been reading up on the recent rebase issues on the PRs from @dr3y and @eldad-a, glad all that got fixed but it got me wondering why these problems occurred in the first place? Like my usual workflow is much simpler (atleast to me) and it works (I think).

git checkout -b my_new_branch

<work on this branch, change files whatever..>

git add .
git commit -m "new commits"
git pull upstream dev

Fix  merge conflicts if any

git push origin my_new_branch

Go to github and create a pull request from my_new_branch to upstream/dev.
I understand that fetch instead of directly pull is a better practice but is that the only reason?

Disclaimer: I'm not a git savvy...
Guess it boils down to how you'd like your history (log) to look like.
According to git-when-to-merge-vs-when-to-rebase, it may be that a good practice in this case would be:
git fetch upstream dev
git rebase −p upstream/dev

-p shortcut for −−preserve−merges.
I found the following also very helpful:
scikit-image: Development workflow
and
How to contribute to scikit-image

First of all, there was no problem in any of the mentioned PRs. I just wanted to test how easily people can pick up rebasing on their own branches. As it was mentioned in the previous message, rebase is useful to make a cleaner commit log.
For example, here's a section of the log for this repo:

Because of the merge commits there are multiple paths running around and merging into each other (merge commit). It the long run, it will be hard to see what was going on. (Especially if you are new to the project)
Rebase is an advanced feature of git, I wouldn't make it compulsory for contribution to the code. However, it is part of a much wider discussion, namely what put into our CONTRIBUTING.md.

Hi @eldad-a,
Thanks for the suggestion, we decided to squash commits in a PR, which gives us the same outcome without advance git commands.


SecurityDefinition json file loaded from classLoader

As you can see here:
https://github.com/kongchen/swagger-maven-plugin/blob/02c0b48758278de493803855d51d0fd2d0bebb6d/src/main/java/com/github/kongchen/swagger/docgen/mavenplugin/SecurityDefinition.java#L31
the JSON security file defined in <json> parameters is loaded from classloader instead of normal path.
<securityDefinitions>
    <securityDefinition>
        <type>apiKey</type>
        <json>/security.json</json><!-- this should be a normal path but is loaded from classloader -->
    </securityDefinition>
</securityDefinitions>

I also wonder whether it is using the class loader of the plugin itself. Because I put the file inside the src/main/resources of my project, it still can't load the file.


holdings_administrative_notes

create new LDP derived table holdings_administrative_notes

@jenmawe I think this is ready for you to review again. If you don't have time, should we find another reviewer?


Add autoResize flag to the create api docs

As the title says, adding just a small bit of documentaton of a really helpful feature.

Looks great -- could you also add a note about enabling for just height/width? For example, it's possible to do:
autoResize: {
    width: false,
    height: true
}

Thanks again!

This was just the feature I was trying to implement until I looked on github.
Updated docs would be highly appreciated

@bluepnume done!
Note: @twig-openlearning this is happening probably not only to you, but to many people. That's why I started docs as I discover things. I really think this project has a lot of value, but without proper docs it's really difficult to start with. So, please, I encourage you to do the same!

Awesome, thanks!


Packaged windows app includes unnecessary support artefacts

Describe the bug
When deployed, a Briefcase Windows app unpacks the Python support package; this includes a copy of python.exe and pythonw.exe. These files are unnecessary, increase the size of the packaged app, and potentially represent a security issue. They should be stripped before packaging.
Steps to reproduce

Generate a windows app
See python.exe and pythonw.exe in the packaged app.

Expected behavior
The Python binaries should be stripped as part of the build process.
Screenshots
No response
Environment

Operating System: Windows
Python version: All
Software versions:

Briefcase: 0.3.12

Logs
n/a
Additional context
The briefcase.toml file on a template can contain a cleanup_paths definition; this allows a template to specify files that should be deleted after the template is rolled out. See the beeware/briefcase-macOS-app-template for an example of usage.

Hi, there are some Stub-3.x.exe files, how these file to be created?  Where to find the source code of the stub.exe?

@Jzhenli They are generated using the stub project in this repository; that project uses briefcase-windows-visualstudio-template to generate the source code for a windows app. The stubs are generated by a CI task when a substantive change is made to the VisualStudio template.


SAA-895: Appointment set print movement slip

Addressing PR comments from previous code review
Optimise appointment search API call
Remove unused prisoner count property from occurrence summary causing additional DB queries
Use only the next future occurrence's prisoner list, the last occurrence if all occurrences have past or an empty list if there are no occurrences. This prevents additional DB queries

Codecov Report
Patch coverage: 90.90% and project coverage change: +0.04 :tada:

Comparison is base (cc304e7) 85.00% compared to head (1fbc59f) 85.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #418      +/-   ##
============================================
+ Coverage     85.00%   85.04%   +0.04%
- Complexity     2105     2111       +6
============================================
  Files           285      285
  Lines          8004     8006       +2
  Branches        457      460       +3
============================================
+ Hits           6804     6809       +5
+ Misses          940      937       -3
  Partials        260      260

Impacted Files
Coverage Δ

...ctivitiesmanagementapi/model/AppointmentDetails.kt
80.85% <ø> (ø)

...anagementapi/model/AppointmentOccurrenceSummary.kt
100.00% <ø> (ø)

...ntapi/resource/BulkAppointmentDetailsController.kt
100.00% <ø> (ø)

...anagementapi/entity/AppointmentOccurrenceSearch.kt
93.61% <50.00%> (ø)

...hmppsactivitiesmanagementapi/entity/Appointment.kt
100.00% <100.00%> (+1.25%)
:arrow_up:

...itiesmanagementapi/entity/AppointmentOccurrence.kt
98.01% <100.00%> (+0.96%)
:arrow_up:

...tapi/service/AppointmentOccurrenceSearchService.kt
90.90% <100.00%> (+0.66%)
:arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Listener not detaching on go back

"useCollection"
this hooks keep listening even go back or remove screen from stack.

@c-info I'm happy to investigate if you can provide a reproducible example, but this is not the behaviour that I see when using the hooks correctly.
Please feel free to re-open with an example if you're still seeing the problem


Add new LXC: NextPVR

Description
Add new LXC: NextPVR.
I only can test the usage of the ui. i dont have an System for it.
After Merge we can add the requester as final reviewer / or need later an bugfix.
Fixes # (issue)
Fixes https://github.com/community-scripts/ProxmoxVE/issues/384
Type of change

[ ] Bug fix (non-breaking change that resolves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[x] New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[x] Testing performed (I have tested my changes, ensuring everything works as expected)
[x] Documentation updated (I have updated any relevant documentation)

@havardthom Done & Tested | Approve pending

These are strings in all other json's. Perhaps they should be numbers, but then it should be fixed everywhere

I was wondering, because it doesn't actually need “[INT]” if it's just numbers? But okay, it's adjusted ^^


Convert Step by Step admin to Design systems

What
Change the step by step admin in collections publisher to use design system and remove the bootstrap css framework.
Why
Design system adds additional accessibility needs which is needed to help support users with accessibility needs.
Background
The bootstrap v3 that is being used will shortly be deprecated and no longer supported.
User Need
As a admin user, I want an accessible user interface so that I can complete my task without assistance.
Tickets included in this PR

https://trello.com/c/Qr1UyzNS/57-change-step-edit-page-to-use-the-govuk-design-system
https://trello.com/c/1LtOVSfK/56-change-step-by-step-overview-page-to-design-systems
https://trello.com/c/evdkh2xW/61-change-title-and-metadata-page-to-use-the-govuk-design-system
https://trello.com/c/nNjQU8p8/67-change-reorder-step-by-step-page-to-use-the-govuk-design-system
https://trello.com/c/g9AliraQ/68-change-secondary-links-page-to-use-the-govuk-design-system
https://trello.com/c/QkSf7ZI5/59-change-publish-step-by-step-page-to-use-the-govuk-design-system
https://trello.com/c/SuD4p0Ys/60-change-change-notes-page-to-use-the-govuk-design-system
https://trello.com/c/HiN1oxZd/55-change-list-step-by-step-page-to-design-systems-to-design-systems

Screenshots

@DilwoarH In addition to the comments on Friday, there are a few more things.

The tests hang if you run them locally. This doesn't happen on the master branch, so I think that some config might need to be added to govuk-docker to get them working.

The navigation selection on the choose navigation page doesn't appear to be working:

Whilst I think the index page is a massive improvement on what's there at the moment, I think having the "Title" and "Slug" link to two different places could be confusing. Perhaps change the label of the link to "Preview"?

@DilwoarH This is looking really good! I've added a few inline comments, but nothing too major.
I'm going through the app checking the functionality, and here are a couple of things I've noticed:
When you "check for broken links" (love the button btw!), and then reload the page, the text that tells you the last check time isn't styled:

This isn't a blocker, but can you add a card to the backlog so that we don't forget about it?
On the Secondary content page, I think the "Delete" buttons should be classed as "destructive", like they are at the moment.

This isn't a blocker either, but can you add a card to the backlog so that we don't forget about it?
I also think there might be some questions about why sometimes clicking on the "Save" button takes you back to the overview page, and other times it keeps you on the same page.
I suspect it's to do with which button component is being used. For example, title and intro and choose navigation take you back to the overview page, but editing a step does not.
Again, this isn't a blocker, but it's something to be aware of.

@leenagupte pushed up


change groupby-ness tests in _maybe_slice

[x] Tests added / passed
[x] Passes flake8 dask

This PR add generalizing groupby object handling/detection.  Currently, there is limited overlap between the groupby objects of cudf and pandas.  I'm working on resolving that now.

Merging tomorrow if there are no further comments


tls_client example doesn't work anymore

I'm new to this library and wanted to get started with using it as a client. I used the tls_client.rs example and had to realize that it doesn't work anymore, mostly because of breaking changes in rustls.
After some tinkering, actually a lot of tinkering, I got it working and thought I'd share.
This was quite intimidating for a simple connection to a WebSocket stream. I left everything as rudimentary as possible.
use std::future::Future;
use std::sync::Arc;

use anyhow::Result;
use bytes::Bytes;
use fastwebsockets::FragmentCollector;
use fastwebsockets::Frame;
use fastwebsockets::OpCode;
use http_body_util::Empty;
use hyper::header::CONNECTION;
use hyper::header::UPGRADE;
use hyper::upgrade::Upgraded;
use hyper::Request;
use hyper_util::rt::TokioIo;
use tokio::net::TcpStream;
use tokio_rustls::rustls::ClientConfig;
use rustls_pki_types::ServerName;
use tokio_rustls::TlsConnector;

struct SpawnExecutor;

impl<Fut> hyper::rt::Executor<Fut> for SpawnExecutor
where
  Fut: Future + Send + 'static,
  Fut::Output: Send + 'static,
{
  fn execute(&self, fut: Fut) {
    tokio::task::spawn(fut);
  }
}

fn tls_connector() -> Result<TlsConnector> {
  let mut root_store = tokio_rustls::rustls::RootCertStore::empty();

  root_store.extend(webpki_roots::TLS_SERVER_ROOTS.iter().cloned());

  let config = ClientConfig::builder()
    .with_root_certificates(root_store)
    .with_no_client_auth();

  Ok(TlsConnector::from(Arc::new(config)))
}

async fn connect(domain: &str) -> Result<FragmentCollector<TokioIo<Upgraded>>> {
  let mut addr = String::from(domain);
  addr.push_str(":9443"); // Port number for binance stream

  let tcp_stream = TcpStream::connect(&addr).await?;
  let tls_connector = tls_connector().unwrap();
  let domain = ServerName::try_from(domain.to_owned())
    .map_err(|_| {
      std::io::Error::new(std::io::ErrorKind::InvalidInput, "invalid dnsname")
    })?;

  let tls_stream = tls_connector.connect(domain, tcp_stream).await?;

  let req = Request::builder()
    .method("GET")
    .uri(format!("wss://{}/ws/btcusdt@bookTicker", &addr)) //stream we want to subscribe to
    .header("Host", &addr)
    .header(UPGRADE, "websocket")
    .header(CONNECTION, "upgrade")
    .header(
      "Sec-WebSocket-Key",
      fastwebsockets::handshake::generate_key(),
    )
    .header("Sec-WebSocket-Version", "13")
    .body(Empty::<Bytes>::new())?;

  let (ws, _) =
    fastwebsockets::handshake::client(&SpawnExecutor, req, tls_stream).await?;
  Ok(FragmentCollector::new(ws))
}

#[tokio::main(flavor = "current_thread")]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
  let domain = "data-stream.binance.com";
  let mut ws = connect(domain).await?;

  loop {
    let msg = match ws.read_frame().await {
      Ok(msg) => msg,
      Err(e) => {
        println!("Error: {}", e);
        ws.write_frame(Frame::close_raw(vec![].into())).await?;
        break;
      }
    };

    match msg.opcode {
      OpCode::Text => {
        let payload =
          String::from_utf8(msg.payload.to_vec()).expect("Invalid UTF-8 data");
        // Normally deserialise from json here, print just to show it works
        println!("{:?}", payload);
      }
      OpCode::Close => {
        break;
      }
      _ => {}
    }
  }
  Ok(())
}

Yep, I was having the same issue and your example works. Thanks @xelra! Note this introduces crate rustls-pki-types as a dependency.

替换依赖库的版本后可以正常运行。


Issue 177 extend persistence

Addressing #193
tf reference error in ColsVisibility and FiltersVisibility extensions.

:+1:


feat(iota): Add shell completions

Description of change
Adds the ability to generate shell completion files using clap_completion to the CLI. These files are also included in these changes. Let me know if you think these should be checked in, or whether users should be required to generate them themselves. Of course, if they are checked it they must be updated whenever the CLI changes. This could be checked in CI.
Links to any relevant issues
Closes #4495

I would put this behind a feature flag and only use that feature when we release binaries to generate the completions.
The completions then should be added to both the binaries release and the brew formula.
Wdyt?

I would put this behind a feature flag and only use that feature when we release binaries to generate the completions. The completions then should be added to both the binaries release and the brew formula. Wdyt?

I think that's reasonable.

Generated the shell completions and copied the generated _iota file for zsh into /usr/share/zsh/functions/Completion/Zsh/, works fine here


Invalid key shows weird error

They key contains %3 from copying and this gets non-base58 error
near stake sparkpool ed25519%3ACSUZgqBHtpUyycqRmZe8yg1QgERpc7MzmihGS7kB8zfw<PHONE_NUMBER>00
[WARNING] Didn't find config at /root/src/config, using default shell config
Staking<PHONE_NUMBER>00 on sparkpool with public key = ed25519%3ACSUZgqBHtpUyycqRmZe8yg1QgERpc7MzmihGS7kB8zfw.
Error:  Error: Non-base58 character
    at Object.decode (/root/.nvm/versions/node/v10.0.0/lib/node_modules/near-shell/node_modules/base-x/src/index.js:112:11)
    at Object.base_decode (/root/.nvm/versions/node/v10.0.0/lib/node_modules/near-shell/node_modules/nearlib/lib/utils/serialize.js:16:39)
    at Function.fromString (/root/.nvm/versions/node/v10.0.0/lib/node_modules/near-shell/node_modules/nearlib/lib/utils/key_pair.js:42:63)
    at Function.from (/root/.nvm/versions/node/v10.0.0/lib/node_modules/near-shell/node_modules/nearlib/lib/utils/key_pair.js:35:30)
    at Account.stake (/root/.nvm/versions/node/v10.0.0/lib/node_modules/near-shell/node_modules/nearlib/lib/account.js:133:110)
    at Object.exports.stake (/root/.nvm/versions/node/v10.0.0/lib/node_modules/near-shell/index.js:139:34)
    at process._tickCallback (internal/process/next_tick.js:178:7)

our public key is (base58 encoded), so error is right

Seems to me the issue is the "%3A" which is the url encoded value of ":" being input into the near-api-js library... which doesn't seem to decode the key string before processing.
Assuming the near-api-js library is the standard and correct way of doing things, we should be url decoding the user input.  PR issues for fix https://github.com/near/near-shell/pull/406.


What to modify for multi-label classification in Colab Notebook?

Hi can you please guide us on how to modify the colab notebook to make it work for multi-classification please?
TIA.

Hi @rohanali1798,
You would have to change the classification head from:
classifier_head = tf.keras.layers.Dense(1, activation="sigmoid")(model_body.output)

to
# for 3 classes
classifier_head = tf.keras.layers.Dense(3, activation='softmax')(model_body.output)

in the transfer learning section, then ensure the training data has the appropriate labels for the multi-classification labels, and train with a SparseCategoricalCrossentropy loss function (instead of BinaryCrossentropy)
fine_tune_model.compile(
    optimizer=tf.keras.optimizers.Adam(learning_rate=0.01),
    loss=tf.keras.losses.BinaryCrossentropy(from_logits=False),
    metrics=METRICS,
)

For the inference side, https://github.com/ArmDeveloperEcosystem/ml-audio-classifier-example-for-pico/issues/1#issuecomment-980029385 has some tips.

Great. Thanks! I will try this and let you know.


Add support for models.get and models.list endpoints

See https://replicate.com/docs/reference/http#models.get
See https://replicate.com/docs/reference/http#models.list
Currently, the Model class has only username and name, and the ModelCollection.get method constructs a new instance with the provided username and name arguments.
This PR makes the following changes to bring it more in line with the replicate-javascript and the other official clients:

Adds url, description, visibility, and other fields to Model
Adds owner field and reimplements existing username field to deprecated property that aliases this field
Updates ModelCollection.get to fetch information about the named model from Replicate's API
Adds ModelCollection.list to fetch public models from Replicate's API
Refactors run to avoid making an additional fetch for the model
Updates predictions.create to support creating a prediction by version ID string

Thanks for reporting, @awerks. PR with a fix here: https://github.com/replicate/replicate-python/pull/162


Should it be possible to use ctrl+up/ctrl+down to navigate within a comment thread

Testing #188536

Open a file in a PR that has comments
Set focus to the comment widget input
:bug: can't ctrl+up/ctrl+down to move focus to the comments within that thread

Author of #187077 here. I would like to solve this.


how to parse list of list?

Hi, I want parse a case like this:
my program -I 1,3,224,224 1,10

which I will have a vector<vector<int>> how to do that?

I think that would be difficult to implement. One option would be to parse those into a vector of strings and then split that up separately.

thanks, I have done it.


feat: Schema support on topic resource

Topic CRD with Schema exmaple:
apiVersion: pulsar.streamnative.io/v1alpha1
kind: PulsarTopic
metadata:
  name: "test-pulsar-topic123"
  namespace: test
spec:
  name: persistent://test-tenant/testns/topic123
  connectionRef:
    name: "test-pulsar-connection"
  schemaInfo:
    type: "JSON"
    schema: "{\"type\":\"record\",\"name\":\"User\",\"namespace\":\"com.foo\",\"fields\":[{\"name\":\"file1\",\"type\":[\"null\",\"string\"],\"default\":null},{\"name\":\"file2\",\"type\":\"string\",\"default\":null},{\"name\":\"file3\",\"type\":[\"null\",\"string\"],\"default\":\"dfdf\"}]}"
    properties: {}

apiVersion: pulsar.streamnative.io/v1alpha1
kind: PulsarTopic
metadata:
  name: "test-pulsar-topic123"
  namespace: test
spec:
  name: persistent://test-tenant/testns/topic123
  connectionRef:
    name: "test-pulsar-connection"
  schemaInfo:
    type: "STRING"
    schema: ""
    properties: "{"key1": "value1"}"

Schema Manage workflow

Add schema on topic resources: Use schemas upload API to add schema on the topic.
Update schema on topic resources: Use schemas upload API to update schema on the topic.
Delete schema on topic resources: Use schemas delete api to delete schema on the topic.


Data ablation study capability: allow skipping of sections

Section slices could have quite a bit of duplicated data.
To shorten training time you could split every other (or even more) sections.

To facilitate ablation studies to assess model robustness and to optionally speed up training, we need to have the ability to drop some inlines and crosslines from training (but not testing). For example, one study could be fraction of dropped data during training versus mean IoU (e.g. how much data can we drop before model accuracy degrades by more than X%).
Can also use the same mechanism to reduce size of training data for demos or tests.


Don't require default destination (it's not required for windows and linux)

See https://github.com/keybase/keybase-issues/issues/2055

LGTM, thanks :thumbsup:


Track expense - Receipt scanning is stuck

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2990407
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Tap on the FAB (Floating Action Button) and select 'Track Expense'
Select the scan option
Upload a receipt that will be successful
Access the scan request you just created

Expected Result:
The header shows 'Scan in progress...'
The 'Amount' and 'Merchant' fields display 'Scanning...'
Wait a <30 min for the scan to finish
Actual Result:
The header shows 'Scan in progress...'
The 'Amount' and 'Merchant' fields display 'Scanning...'
Receipt scanning is stuck for hours
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/38aad55d-ac63-4d18-baf4-ebc59735d0fb

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Cannot reproduce. I suspect we had a lag with agents manually scanning when this was tested but that backlog probably cleared out shortly after.


Running out of memory

Hello,
Thanks for finally supporting mutation in AD!!
I am on a mac and on julia 1.7 it seems that an example of this size will die (allocates a lot of memory and goes to swap, I guess the kernel kills it). I tried for the function to be non-allocating as below, and didn't help.
function fwd3!!(d,c,pp,pc)
    n1,n2,n3=size(c)
    nt=length(d)

    #pp=zeros(n1,n2,n3)
    #pc=zeros(n1,n2,n3)
    pp.=0.
    pc.=0.
    pp[n1÷2,n2÷2,n3÷2]=1

    for it in 1:nt
        for iy in 2:n3-1
            for ix in 2:n2-1
                for iz in 2:n1-1
                    pc[iz,ix,iy] = 2pp[iz,ix,iy] - pc[iz,ix,iy] +
                        1e-8*c[iz,ix,iy]^2*(pp[iz-1,ix,iy]-2pp[iz,ix,iy]+pp[iz+1,ix,iy])+
                        1e-8*c[iz,ix,iy]^2*(pp[iz,ix-1,iy]-2pp[iz,ix,iy]+pp[iz,ix+1,iy])+
                        1e-8*c[iz,ix,iy]^2*(pp[iz,ix,iy-1]-2pp[iz,ix,iy]+pp[iz,ix,iy+1])
                end
            end
        end
        pc,pp=pp,pc
        d[it] = pc[n1÷4,n2÷3,n3÷3]
    end
    return nothing
end

c=1e3*ones(101,111,105)
pp,pc=similar(c),similar(c)
d=zeros(1500)
@time fwd3!!(d,c,pp,pc)

function adj3!!(d,c,dd)
    ddc=copy(dd)
    dc=zeros(size(c)...)
    pp,pc=similar(c),similar(c)
    tpp,tpc=zeros(size(c...)),zeros(size(c)...)
    Enzyme.autodiff(fwd3!!, Duplicated(d,ddc), Duplicated(c,dc),Duplicated(pp,tpp),Duplicated(pc,tpc))
    return dc
end

ddr=rand(size(d)...)
@time dc=adj3!(d,c,ddr); ### and dead

Is there a way around that? I understand that the size of the problem is big, but these are the sizes I am interested in for the applications I have in mind :)
Also, while I am here... Is there a way to define pushforwards in enzyme? I asked on discourse, so excuse me for asking here as well!
Cheers!

An afterthought: having written the pullback by hand a few times, is enzyme effectively saving pp/pc for every it in 1:nt?


Enable CC0029 analyzer to work with arrow methods

Fixes #809

Coverage decreased (-0.01%) to 91.607% when pulling b8d8b046027f32e6d06a7a95b1d992e3826d7557 on giggio:gb/fix809 into f7d2893e8ea03ace30451a553a00f80615553987 on code-cracker:v1.0.x.

@giggio This PR has conflitcs, can you check ?

@carloscds updated!

Coverage decreased (-0.01%) to 91.608% when pulling 7cfff1c99f54fe3000cc93bcb000ad54678fa548 on giggio:gb/fix809 into 965ba029bd91d6769708689917688c7e7df94bce on code-cracker:v1.0.x.


Do we need attrs as streams? Can we just rely on nullish values instead?

In order to settle #16, it would be nice to discuss the semantics of setting and removing attributes, properties and events. Here's a brain dump of what I think so far:
Setting aside SVG (whose props are mostly readonly):
With the DOM:

Attributes and events can be set, updated and removed
IDL properties can only be set or updated. deleting a property is a noop, because the getters/setters are defined on the prototypes.

With vella:

()=> c() ? {foo} : {}, going from c() === true to c() === false:

when it is detected as an event, the event is removed
when foo is detected as a property, it is set to null (and ~automatically turned into a "null" string by the browser). There are a few exceptions for problematic setters, that fall back on setting the attributes.
otherwise it is treated as an attribute, which is removed.

... and as it ought to work once #11 and #13 are addressed

{foo: ()=> (c() ? foo : null)}
Basically does the same.

The trouble with the scheme above is that most relevant attributes have equally named IDL properties that take precedence. So you can't remove most attributes right now, they end up being set to "null". For most values setting them to ""  would be better, (that's what most getters return when the attribute is not set, and it is cast to false for boolean attrs such as checked or selected)... but not perfect. As far as CSS and querySelectorAll go , <b id=""> and <b> are distinct. Also, setting input.checked = true does not set the corresponding attribute, so you can use input[type='checkbox'][checked] to style it, but you can use input[type='checkbox']:checked (which I suppose is a best practice in a post IE8 world).
From a purely semantic point of view, for HTML elements, it would be better to be able to set and remove the attributes (I think it would require a ), but I don't know if that matters in practice, since there are workaround in userland for most problems.
We can't also not just set the attributes, the property in element check is important for custom element to work properly.
So the only advantage of streams as attrs I see right now is that it lets one set/remove/update several values in one fell swoop. I think that's nice to have semantically, but it hampers writing clean hyperscript...
Stream as attrs have the disadvantage that they let one accidentally remove a property, which is nonsensical.
My knowledge of HTML, IDL and CSS is incomplete though so I'd like to be sure I'm not missing something crucial.

I don't believe the benefits of attrs as streams outweigh the ergonomic benefits of optional attrs.
I think if attribute removal proves to be a serious issue, we really should consider a sentinel specifically for that purpose. We can still allow null children, but passing e.g. v.null to remove an attribute seems to me to be the simplest and most likely the most performant.

Oooh, I'm an idiot...
Without attrs as streams how do we remove event listeners? You can't pass a stream/live zone as an event listener like you can for other values...
I knew this, but let it slip somehow.


Controller Not Obeying RS Signal Preference

Issue description:
Applying redstone via lever to controller does not turn controller, and thus the whole network off, when mode is set to "Work Only Without RS signal"
What happens:
Nothing.
What you expected to happen:
Controller and all connected devices that use RS power should turn off, right?
Steps to reproduce:

Change controller mode to "work only without rs signal"
Apply lever and turn on
See that nothing happens.
...

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>3
Refined Storage: 0.9.3

Does this issue occur on a server? [yes/no] Yes
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

I can't reproduce this, please try on the latest version. If the issue is still there, let me know


Customize the import preview template with fields which aren't in the model ?

How to customize the import preview template ?
I can't find the rendering of the preview in import workflow.
I am decalring a fields that don’t exist in the target model, i'm using it to find the id that matches (before_import) but I cannot displaying it to the user... I don't understand how to do so and where...
Picture of my excel and what the module displays me

Hi @HydrUra, you can accomplish it using a custom format. See explanation in issue #277. I'll try to put an example in the documentation.


Update apache-jena-libs to 5.0.0

About this PR
📦 Updates org.apache.jena:apache-jena-libs from 4.10.0 to 5.0.0 ⚠
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.jena", artifactId = "apache-jena-libs" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.jena", artifactId = "apache-jena-libs" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #261.


Fix #5428: Remove non-ASCII characters from JsBuiltIn.js and generated .bc.*.h

Fixes #5428

Looks like you'll have to actually regenerate the bytecode, there might be some kind of reference to the sources or length in there?


Messed order in $children when using v-for.

Hi,
When I tried to use
<component-a>
  <component-b :id="-1">

  <template v-for="(index, b) in many_b">
    <component-b :id="index">
  </template>
</component-a>

// I use id to indicate the component for illustration purpose
console.log(this.$children);   // output [0, 1, 2, ..., n, -1]

// It would be more reasonable if it's
// [-1, 0, 1, 2, ..., n].

Or, is there anything I may have done it wrongly to cause this?
Thanks.

Nested child components are created first. But either way, $children offers no guarantee about its order and you should not rely on it.


Fixed a typo in the stable_marriages.py

When merged, this Pull Request fixes a typo in the Python 3 implementation of the stable marriages problem. Thanks to @Gathros for spotting this one.

Anytime, You can count on me to point out a mistake you've made.

Haha, I have made that typo many times before! Merged


Remove an unused use declaration in the docs

It appears PathBuf is unused here and can be removed since u32 is used in this example.

Nice catch and thank you @havenwood!


getServerSideProps() example does not work.

Hello,
The getServerSideProps() example in the readme does not seem work. Having copied it character for character and tried building, it throws the following error:
Build optimization failed: found page without a React Component as default export in
pages/ssr

I am only able to get a build to succeed when I remove the experimental-edge runtime config from both the page itself and the next.config.js file. It appears to occur whenever you specify the experimental-edge runtime in either the next config or the page.
From what I can tell, a Next.js app cannot be built when using getServerSideProps in pages while the experimental-edge runtime is specified.
If you were able to manage to have getServerSideProps work when specifying the experimental-edge runtime, would you please be able to provide a source code example, as I am unable to get it to work at all with any of my trial and error?

Did you remember to add the export default Home; at the bottom? It should work!

Did you remember to add the export default Home; at the bottom? It should work!

Yes, the page's component is the default export.
I created a new next.js app with create-next-app and copied over the example code, but when I specify experimental-edge in the page or in the next.config.js, I get the error.
Spent some time trying it in my projects as well and it's the same error.
Do you have an example application where it works that I can compare against?

After the problems I was experiencing with dev mode/building Next.js 13 (using the new appDir) on Windows with webpack (vercel/next.js#41806), I thought I would give this another spin on Linux, and it builds as expected.
Apologies for this false alarm, I'm going to assume this was just another bug I had building with webpack on windows.


Selfhost Compiler Crashed with Segmentation Fault printing a LinkedList

WHF :) On the most recent main branch (commit 9c52bee6) I tried to compile the following progam:
struct LinkedList {
    value: i64
    next: LinkedList?
}

function main() {
    mut node1 = LinkedList(value: 1, next: None)
}

and the compiler (not the resulting program) crashed with a Segmentation Fault.|
Steps I took:
cargo install --path .
jakt ./selfhost/main.jakt && mv ./build/main ./jakt_selfhost
./jakt_selfhost test.jakt # test.jakt is the program shown above

The Rust-based compiler doesn't crash and produces some Cpp which clang then rejects with
error: invalid application of 'sizeof' to an incomplete type 'Jakt::LinkedList'

It is basically this line: if struct_.record_type is Class and not top_level { in codegen.jakt
As the record type is Struct it ends up with infinite recursion.
If the code is changed from struct to class it works, I am not sure if there should be an error about recursion in structs or that the codegen should be changed to handle it.

Ah interesting, since Struct is a value type it makes sense that it cannot contain itself as a value.

Basically the same as with recursive enums which have to be boxed (aka class)

So the compiler should reject code in which a value type references itself directly, as in:
struct S {
    field: S
}

and indirectly through other value types such as tuples, arrays or other structs (e. g. Optional):
struct S {
    field: S?
}

whilst allowing non-value types such as pointers to reference it safely?

only if it is a struct, it should work for classes.

i.e. this should be ok:
class S {
    field: S
}


Request interceptor/adapter call order

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

Created session and request interceptors (see snippet below) and used each one when creating the session and request, respectively.
Called the request

Example:
class MySessionInterceptor: Alamofire.RequestInterceptor
{
    func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
        var urlRequest = urlRequest
        urlRequest.setValue("defaultValue", forHTTPHeaderField: "MyCustomHeader")
        completion(.success(urlRequest))
    }
}

class MyRequestInterceptor: Alamofire.RequestInterceptor
{
    func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
        var urlRequest = urlRequest
        urlRequest.setValue("newValue", forHTTPHeaderField: "MyCustomHeader")
        completion(.success(urlRequest))
    }
}

What did you expect to happen?
I'd expect the request interceptor to be able to override values set by the session one. I believe the use case is valid, where your app might always send a certain value, but on specific requests you might want to tweak that instead (or modify the request in any other way).
What happened instead?
The request never got modified, because (and the documentation is helpful+clear here) the session interceptor's adapt() method is only called after the request one.
Alamofire Environment
Alamofire version: 5.0.0
Xcode version: 11.3.1
Swift version: 5.1
Platform(s) running Alamofire: macOS
macOS version running Xcode: 10.15.3
Demo Project
I haven't extracted this into a demo project as my issue is more to spark a discussion than to report a bug, since as I stated above the behaviour is actually following the documentation... but happy to do so if needed.
Further Discussion
My sincere apologies if my question makes no sense and/or if there's a very clear reason I'm missing to have these ordered like they are right now. I can certainly find a workaround on my end to achieve this goal, but it seemed to me that it warranted a proper discussion.
Happy to investigate and file a PR with the change if the team agrees with it.

You can find the relevant code here:
func adapter(for request: Request) -> RequestAdapter? {
    if let requestInterceptor = request.interceptor, let sessionInterceptor = interceptor {
        return Interceptor(adapters: [requestInterceptor, sessionInterceptor])
    } else {
        return request.interceptor ?? interceptor
    }
}

func retrier(for request: Request) -> RequestRetrier? {
    if let requestInterceptor = request.interceptor, let sessionInterceptor = interceptor {
        return Interceptor(retriers: [requestInterceptor, sessionInterceptor])
    } else {
        return request.interceptor ?? interceptor
    }
}

As you can see, if a Request has both a Session and Request adapter or retrier, both are used, Request instance first. If one or the other is missing a value, it coalesces in the same order in an attempt to find an instance. This allows the pattern your examples seem to want. However, some care is required in order to prevent the Session instances from overwriting the Request ones, such as checking if a header value has already been set.
If you aren't seeing the behavior, or you aren't seeing your adapters or retriers called at all, there may be a bug. This is where a demo project can help. Feel free to add a link, or the code you're using to make the request, and we can see if there's an issue.

Hi @jshier! Thanks for getting back to me so quickly!

If you aren't seeing the behavior, or you aren't seeing your adapters or retriers called at all, there may be a bug.

I'm definitely seeing that behaviour. As far as I can tell Alamofire is working as intended, which is what prompted me to spark a discussion here.

However, some care is required in order to prevent the Session instances from overwriting the Request ones, such as checking if a header value has already been set.

What if you need to customize a request to remove a header? With the current logic it's impossible to do so because when the Session interceptor fires it has no way of knowing that a header it normally injects needs to be absent for that specific request.
For example, you might always send some data as a header, but on a specific request you'd like to send that same data as a query parameter instead.
So my question is: am I wrong thinking that a Request interceptor should be able to customize a request after the Session interceptor did whatever it needs to do? (i.e. return Interceptor(adapters: [sessionInterceptor, requestInterceptor]))
Or was there a reason behind having it the other way around? What's the advantage?

You can always inspect the incoming URLRequest to see wether it should be adapted, but in general you're always going to have this issue when you only use one adapter for either side. Either the Session interceptor will have to do some work to only adapt when needed, or the Request interceptor will. My suggestion would be to take advantage of the per-request interceptors and only add particular interceptors to the request that need them, letting the Session interceptor only handle things that are necessary for every request. I usually do this at my request API layer where I know certain requests require authentication or other adaptation. This way the interceptors are more composed together rather than layered on top of each other.

Great discussion, and I'm with @jshier. Don't put anything in the Session interceptor that wouldn't be set on all requests. It's just like the URLSessionConfiguration headers. Only add what you want on every request. Don't put a header you may want to remove for a request into the Session interceptor.
Then, I'd suggest you take advantage of making separate interceptors (or at least adapters) for splitting up your header add/remove logic. Any request can be "adapted" any number of time at the Request level, and you control the order that they're executed. This should give you everything you need to design any add/remove header logic you would want.
Best of luck! 🍻

First of all, thanks to you both for taking the time to address my question! ❤

Then, I'd suggest you take advantage of making separate interceptors (or at least adapters) for splitting up your header add/remove logic. Any request can be "adapted" any number of time at the Request level, and you control the order that they're executed.

You mean more than one interceptor/adapter per request?
If so, is there a way in the API to do this that I'm missing? All I saw was a parameter to pass a single interceptor.
The more I think about it though, the more I agree with you in that I should try to compose instead of layer the interceptors. If there's indeed a simple and clean way to apply multiple interceptors to a given request, I'm sold! 👍

Yes, our Interceptor type can be used to compose multiple interceptors.

Ah, how did I miss that! 🤪
Thank you so much. Closing this now and hiding in shame 😂 ❤

No problem, always good to know where we might need to improve our documentation.

Hopefully this issue will be seen by many that run into a similar challenge.

Yes, our Interceptor type can be used to compose multiple interceptors.

I think this is worth mentioning in the advanced usage doc and also the migration guide. I wish I'd known about this earlier, now I need to undo my work where I squashed my retryer & adapter into a single class 🙃


Insiders Mac version pulled?

Was the MacOS Code Insiders latest update (v37) pulled? I was able to update at home, but an hour or so later at work there is no update available.
(A place to see the current "release" version would be helpful - with a note if an update was pulled would be a bonus)

VSCode Version:

OS Version:
MacOS
Steps to Reproduce:

Launch Code Insiders
Check for updates
No Updates available.

Yes. Same for Windows.
Looks like there were few new (severe?) issues that may be a reason to roll back buggy version.

There were a few bugs in the old builds that were causing a bad user experience so we decided to roll it back until it could be fixed. A new version of insiders should be out now!


Command: toggle_status_bar

Reopening old Issue in relevant Repo
https://github.com/limetext/lime/issues/98

closed by https://github.com/limetext/commands/commit/b06698e09460ee259bb67aceff03350286f44696


Add handleError issues/39

https://github.com/thejameskyle/marionette-wires/issues/39

Manually merged.


+xpgains command shows users as (Unknown)

🐛 Bug Report
Should show the full names, so can see where you are ranked. Kcgains is working as intended. This issue is present on both bots.

Nah it did show names a while ago, then at some point went to (unknown). Dont recall there being an update for it to be like how it is now.

Same goes for BSO, too. It's been like this every since runecrafting was SOTW on BSO. I would love to be able to see the names on this again.


NS_ERROR_MALFORMED_URI when importing nogos with buffering

Hi,
When importing a GeoJSON file of nogo areas (typically https://opendata.paris.fr/explore/dataset/chantiers-perturbants/download/?format=geojson&timezone=Europe/Berlin) with some buffering, this results in a NS_ERROR_MALFORMED_URI being emitted (brouter-web.js:93, seems to be happening in onMapMove leaflet-fullHash.js:192).
Then, the modal would not close and the URL would not be updated with the correct parameter.
The buffering action works fine though and the nogos are displayed on the map. The route computation fails, due to a subsequent TypeError: t is null in L.Routing.Draw.

I had a look at it and my best bet so far is that it is not particularly due to buffering. The issue is probably that all polygons and nogo areas get appended to the URL, which makes it too long at some point and considered as being malformed.
Not sure what can / should be done then.

I can reproduce in Firefox, works fine in Chromium.
My guess would also be that the URL gets too long, but before taking measures, I think we would need to be sure, e.g. by researching Firefox URL limit; narrow down the error by splitting the polygons parameter of the URL into halves and see if both are valid, ... Would leave that to you unless you get stuck as I really want to get on with milestone 0.11.0.
Not sure if that would really help, my first thought is to try same kind of polyline encoding, like mapbox/polyline (we already include that one).

I tested with a very long GeoJSON, trimming it to only keep part of the features, and I am almost sure this comes from the URL length (this is happening when too many features are in the GeoJSON and this is not bound to a specific feature).
I tried to run
url = 'http://example.com#'; for (i = 0; i < 2000000; ++i) { url = url + 'a'; }; new URL(url)

in a console in Firefox. This crashes with a TypeError (the limit is between 1e6 and 2e6) but this works in Chromium.
Indeed, we should probably have a compact encoding of the polylines / polygons. mapbox/polyline is probably a solution. I'll have a look once #227 is fine and merged to avoid conflicts.