Comply to helm3's way of handling namespaces

As of now, the helm chart handles namespaces in a "helm2" way:

target namespace for the operator is in values.yaml
there is a Namespace resource in templates/namespace.yaml

helm3 compliant charts do not create namespaces (this is left to the user). They also use the --namespace parameter of the helm install command to decide where resources in the templates/ directory should be installed, and if template files ever need to reference the said namespace, it is available under the .Release.Namespace built-in variable.
Affects:
[ ] Configuration Infrastructure
[] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Does not have any changes that may affect Istio users.

Hi @kabooboo. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Should this be accepted, some modifications should be brought to the istio.io repository, here.

@morvencao - today Istio also supports standalone model of operator install (using helm template or helm directly, without istioctl).
Cheers,
-steve

So operator-init must create the operator's namespace before applying the manifest.
It seems it can be done in this file operator/cmd/mesh/operator-init.go:125. There is a createNamespace function but it does not add the label istio-operator-managed: Reconcile.
Is it the correct location to handle this namespace creation issue?
Should we create a new function addLabels(toNamespace) or pass labels as parameters createNamespace ?

@googlebot I consent.

@morvencao I've added some changes for istioctl operator init to try and create the namespace.

/cc @howardjohn


merge Dockerfiles into one

I noticed that the docker images for v0.4.3 and v0.4.4 do not include the fix introduced in #7.
That is probably because the goreleaser config doesn't use the Dockerfile where that fix was applied.
To prevent this I merged the two Dockerfiles into one and also created a github action that runs goreleaser. Releasing should be as easy as pushing a tag :tada:
You would have to add two secrets: DOCKER_USERNAME and DOCKER_PASSWORD

I noticed that the docker images for v0.4.3 and v0.4.4 do not include the fix introduced in #7.
That is probably because the goreleaser config doesn't use the Dockerfile where that fix was applied.
To prevent this I merged the two Dockerfiles into one and also created a github action that runs goreleaser. Releasing should be as easy as pushing a tag
You would have to add two secrets: DOCKER_USERNAME and DOCKER_PASSWORD

You can perhaps merge the Dockfiles alone in this PR - I have no interest in providing DOCKER secrets to GitHub @lukashass

Fair enough. I changed the PR to only merge the Dockerfiles.


Empty canvas_item shader with thousands of nodes = high (100%) CPU core usage

Godot version:

3.2.3 stable, 3.2.4 beta 6
OS/device including version:

Windows 10, GLES2 and GLES3, GeForce 1070Ti (last version of drivers).
Issue description:

When attaching empty shader script (only shader_type canvas_item;) to scene that is instanced thousands times CPU core usage raises to 100%. In my project I made simple shadow shader for grass (fragment shader to make sprite black+transparent and vertex shader to rotate and skew the result). Benchmark results:
No shader, about 3000 grass sprites: 8% CPU core usage.
Shader and around 3000 grass sprites: 100% CPU core usage.
Benchmark results for minimal reproduction project:
No shader, 8000 sprites: 6% CPU core usage.
Empty shader, 8000 sprites: 100% CPU core usage.
I also noticed that turning on shader increases 2d/draw calls by 4 * nodes count. CPU usage is also affected by node's visibility (if none of the nodes are visible, CPU usage is low).
Steps to reproduce:

Make scene with sprite and sprite for shader.
Add ShaderMaterial to sprite and create empty shader (shader_type canvas_item;).
Instance scene thousands times.

Minimal reproduction project:

empty_shader_with_thousands_of_nodes.zip
Bugsquad edit (keywords for easier searching): 2D

You probably want to use MultiMeshInstance2D when you have thousands of instances like this. I don't think you can benefit from batching with custom shaders, or can you?

You probably want to use MultiMeshInstance2D when you have thousands of instances like this. I don't think you can benefit from batching with custom shaders, or can you?

Yes Calinou is right. If you tick project_settings->rendering->batching->debug->diagnose_frame you can see the difference. Your null shader is not batching.
Before batching, all projects took this much CPU. These days a lot of custom shaders will batch, but just not this one (have not investigated why, but given it is unlikely in practice, it doesn't seem a big problem).

Yes Calinou is right. If you tick project_settings->rendering->batching->debug->diagnose_frame you can see the difference. Your null shader is not batching.
Before batching, all projects took this much CPU. These days a lot of custom shaders will batch, but just not this one (have not investigated why, but given it is unlikely in practice, it doesn't seem a big problem).

Ah looking closer your sprite.tscn contains 2 sprite objects. A sprite, and a sprite with a shader as a child. They are thus one rendering 1 - 2 - 1 -2 etc. It can't batch them because they use separate shaders, and they also overlap so can't be reordered.
If you instead make the shader the root of sprite.tscn, and hide the other node, the shader will batch (because there are no material changes).
See:
https://docs.godotengine.org/en/stable/tutorials/optimization/batching.html
For a full description of how it works. As such, it is working great, so closing this issue.

Ah looking closer your sprite.tscn contains 2 sprite objects. A sprite, and a sprite with a shader as a child. They are thus one rendering 1 - 2 - 1 -2 etc. It can't batch them because they use separate shaders, and they also overlap so can't be reordered.
If you instead make the shader the root of sprite.tscn, and hide the other node, the shader will batch (because there are no material changes).
See:
https://docs.godotengine.org/en/stable/tutorials/optimization/batching.html
For a full description of how it works. As such, it is working great, so closing this issue.


Fix: secondary subtitles not showing

Partial fix #27
Filter out null SubtitleFactory.build result allows the secondary subtitles menu being showed correctly, this is a partial fix beacuse netflix added some extra subtitles in which the subtitle manifest seem to have missing fields, ttDownloadables for those extra subtitles is empty, generating the bug in nflxmultisubs.js#L456.
This pr aims to solve the problem for the previous existing subtitles, the new extra subtitles could require some new way to build them or just wait for netflix to update the manifest to correspond with the previous existing subtitles

Many thanks! I'll submit a new version with this fix today.
Those new extra subtitles are indeed quite interesting. I think I'll open a new issue to address this, would be nice if we can also find a way to use them as secondary subs.


this.router.go(-1) doesn't work only on Chrome 67

Version
2.6.0
Reproduction link
[http://jsbin.com/?html,css,js,output;I don't know how to show this question in  editor such as JSBin,  you can try it on you page.](http://jsbin.com/?html,css,js,output;I don't know how to show this question in  editor such as JSBin,  you can try it on you page.)
Steps to reproduce
use this.router.go(-1)   return to previous page
What is expected?
return to previous page
What is actually happening?
nothing, it doesn't work. horever, it worked  well on Chrome 66.

It's probably a regression in chrome then. Make sure it's not a html history issue

@wpsumsun Hi, I had met the same issue.
How to fix it?


fix: openssf-scorecard link

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


fix: update dev-deps to actual

bump @semantic-release/commit-analyzer to 11.1.0
bump @semantic-release/github to 9.2.1
bump @semantic-release/npm to 11.0.1
bump @semantic-release/release-notes-generator to 12.1.0 bump @types/node to 20.8.10
bump @typescript-eslint/eslint-plugin to 6.9.1
bump @typescript-eslint/parser to 6.9.1
bump eslint to 8.53.0
bump semantic-release to 22.0.7
bump typedoc to 0.25.3
bump typescript to 5.2.2

:tada: This PR is included in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


v3.0.0

ℹ Development branch/PR for Spook v3.0.0; ⚠ Work in progress

[x] Switch Spook to MIT license
[ ] Make Spook "your homie" (ton of docs changes)
[ ] Adjust config flow introduction text to remove the license / make it more serious
[ ] Adjust documentation steps to remove the license step
[ ] Tune down other documentation parts
[ ] Update "in the media" part of the documentation
[ ] Improve performance of entity/device/area gathering (ref #637)
[ ] Add support for floors (2024.4)
[ ] Add support for labels (2024.4)
[ ] Add icons translations
[ ] Find a way to make service translations work with Spook (and make the overrides work)
[ ] Replace poetry with rye

Going to merge this to main and continue working from there.
../Frenck


⚠ Samsung has degraded performance

In 7cba08d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3210 ms

Resolved: Samsung performance has improved in f52728c.


Thermostat Temperature Throttling

It seems with every increment of a temperature change this is hitting the API which in turn causes rate limits:
...
"errors":[{"message":"Rate limited for the SetThermostatTemperatureHeat command for the user.","domain":"global","reason":"rateLimitExceeded"}]}
Entryway Thermostat

Would be great if this could throttle the setting of this to the requested value by even 500ms or so to reduce the occurances of this.

Duplicate of https://github.com/potmat/homebridge-google-nest-sdm/issues/99

Oops, my bad.


Inserting completions erases prompt

General information

Please report the following information as possible as you can:

Terminal program: kitty 0.29.2
Operating system: NixOS 23.05
ZSH framework: zgenom
ZSH version: 5.9

Basic examination

[x] I have read through the README page
[x] I have the latest version of zsh-vi-mode
[x] I have tested with another terminal program

Problem description
When trying to perform a completion, the prompt is sometimes erased. If the candidate is long enough, the completion result itself is truncated (only visually).
I think there has been a regression somewhere, because I remember that it was working just fine a few weeks ago.

Reproduction steps

Activate a prompt e.g. starship-rs
Try to complete something long

Expected behavior
Prompt doesn't disappear

I bisected, and found the commit where this issue starts happening: 6f14b2f6a00e03004abe5fa5ca95c7f4d8875348

I am experiencing the same issue when using fzf for history search

I am experiencing the same issue when using fzf for history search

I experienced the same issue and this is how I worked around it:
function dotfiles_fzf_history_widget() {
  fzf-history-widget "$@";
  zle .reset-prompt; # This is the workaround
}

zvm_define_widget dotfiles_fzf_history_widget;
zvm_bindkey viins '^R' dotfiles_fzf_history_widget;

So the fix is that I call .reset-prompt, which is the default reset-prompt, instead of zsh-vi-mode's zvm_reset_prompt. I've tried to add "echo" to that widget to see what happens, and for some reason it seems like $ZVM_POSTPONE_RESET_PROMPT is set to "1". I haven't looked into it further, since I'm ok with the current workaround.

Unfortunately not. I changed back to bash after having too many old servers that didn't have recent enough zsh for me to work efficiently.


Emit events on finished task / Execute function or promise

Pull Request Test Coverage Report for Build 260

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 258:
0.0%

Covered Lines:
259

Relevant Lines:
259

💛  - Coveralls


[Doc Improvement][Update SBS guide Invoke Task Module from Teams][2653072]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
83
43
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 69b99ac:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/sbs-botbuilder-taskmodule.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
83
43
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 01960c8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/sbs-botbuilder-taskmodule.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-linkunfurling.yml
84
31
link
:white_check_mark:

msteams-platform/sbs-botbuilder-taskmodule.yml
84
42
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 069ee8f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/sbs-botbuilder-taskmodule.yml
:warning:Warning
View
Details

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/gotohome_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage-apps_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/messaging-endpoint_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/multi-tenant-option.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/review-plus-create_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/scopes_1 (1).png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/setlink_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/terms_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/upload-app_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/webauth_1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-linkunfurling.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-taskmodule.yml

Line 253, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/Teams-task-module/scopes_1.png'.
Line 412, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/Teams-Messaging-Extensions-Search/AppStore_1.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-linkunfurling.yml
84
31
link
:white_check_mark:

msteams-platform/sbs-botbuilder-taskmodule.yml
84
42
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1b2f3a2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/sbs-botbuilder-taskmodule.yml
:warning:Warning
View
Details

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/gotohome_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage-apps_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/messaging-endpoint_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/multi-tenant-option.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/review-plus-create_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/scopes_2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/setlink_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/terms_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/upload-app_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/webauth_1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-linkunfurling.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-taskmodule.yml

Line 247, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/Teams-task-module/addascope_2.png'.
Line 253, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '~/assets/images/Teams-task-module/scopes_1.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-linkunfurling.yml
84
31
link
:white_check_mark:

msteams-platform/sbs-botbuilder-taskmodule.yml
84
41
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit be2b7a8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/gotohome_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage-apps_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/messaging-endpoint_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/multi-tenant-option.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/review-plus-create_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/scopes_2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/setlink_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/terms_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/upload-app_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/webauth_1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-linkunfurling.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-taskmodule.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
84
41
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 00dedce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientsecret.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientvalue.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/gotohome_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage-apps_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/messaging-endpoint_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/multi-tenant-option.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/review-plus-create_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/scopes_2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/setlink_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/terms_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/upload-app_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/webauth_1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-botbuilder-taskmodule.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
84
41
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 65003d0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettings_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettingslocation.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientsecret.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientvalue.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/configteams.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/gotohome_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manage-apps_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/manifest_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/messaging-endpoint_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/multi-tenant-option.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/review-plus-create_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/scopes_2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/setlink_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/solutionexplorer_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/startup_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/terms_1.png
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
84
41
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1542478:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Teams-task-module/adaptive-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-card-submit.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-card-text.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-custom-chat.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/add-app.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appisready.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettings_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettingslocation.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/certificate.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/chat_ready.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientsecret.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientvalue.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/configteams.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-form.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-on-sign-up.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-text.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/final_image.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
83
42
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f49935a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Teams-task-module/adaptive-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-card-submit.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-card-text.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-custom-chat.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/add-app.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appisready.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettings_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettingslocation.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/certificate.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/chat_ready.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientsecret.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientvalue.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/configteams.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-form.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-on-sign-up.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-text.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/final_image.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-botbuilder-taskmodule.yml
83
42
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 8cc4ea9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Teams-task-module/adaptive-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-card-submit.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-card-text.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/adaptive-custom-chat.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/add-app.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/addascope_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appisready.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appregister_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettings_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/appsettingslocation.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/AppStore_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/authend_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/azure-bot_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-deployment_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/bot-page_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/certificate.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/chat_ready.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientsecret.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/clientvalue.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/configteams.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-form.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-on-sign-up.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/custom-text.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/exposeanapi_1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Teams-task-module/final_image.PNG
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


CLI hangs executing an invalid workflow

Describe the bug
If the CLI is trying to execute an invalid workflow like the setup explained in #654 it just hangs and does not return.

not reproducable


♿ No way to get out of MSAL login page if login is not completed

yeah there is no button in the app to cancel the login, but when you click cancel on the login page, the app should also fall back


Better error on BQ schema parse

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

oops this is broken

I realize that this is a small fix so fine if not.

there isn't


Unicorn 3.3.2 transparent sync "ParentItemNotFoundException", does not Sync (deserialize) yml files uploaded via FTP to Azure web app

Dear Unicorn team,
I have an Azure Website running Sitecore 8.2.5, with a Helix style solution of many Feature projects in VS2015. Each VS Project has its own serialization.config file with  set to a dedicated targetDataStore physical root path, and enableTransparentSync="true".
Now, from my VSTS GIT repo, I have a build/deploy definition that deploys my sitecore webapp (Web Deploy), and also all serialized items (YML files) are uploaded via "FTP Upload" task to the targetDataStore physical root path of my target Azure web app (an integration testing instance)
However, even after the VSTS build succeeds and all YML files are uploaded to the Azure web app (under suitable folders like D:\home\site\Feature\MyFeature1 etc.). Unicorn does not Sync (deserialize) the YML files to the web app's Sitecore content tree.
The error I get is "ParentItemNotFoundException: Exception of type 'Sitecore.Data.Serialization.Exceptions.ParentItemNotFoundException" for all my 47 items.
True enough, parent items don't yet exist in my Web app. I want TransparentSync to create all items in Sitecore using the serialized YML files available on the web app disk.
Please can you advise, how can I get transparent sync to automatically update a fresh new Sitecore Tree when YML files are uploaded to the specified targetDataStore on the server's disk ?
Thanks and regards,
Rahul

Transparent sync is reliant on file system eventing. With the filesystem
entirely abstract in azure web app it is unlikely that eventing is
supported. Unfortunately you'll need to rely on explicitly syncing in
azure.
On Mon, Oct 2, 2017, 2:56 AM RMahb<EMAIL_ADDRESS>wrote:

Dear Unicorn team,
I have an Azure Website running Sitecore 8.2.5, with a Helix style
solution of many Feature projects in VS2015. Each VS Project has its own
serialization.config file with set to a dedicated targetDataStore physical
root path, and enableTransparentSync="true".
Now, from my VSTS GIT repo, I have a build & deploy definition that
deploys my sitecore webapp (Web Deploy), and also all serialized items (YML
files) and uploaded via "FTP Upload" task to the targetDataStore physical
root path of my targer Azure web app.
However, even after a VSTS build succeeds and all YML files are uploaded
to the Azure web app (under suitable folders like
D:\home\site\Feature\MyFeature1 etc.). Unicorn does not Sync (deserialize)
the YML files to the web app's Sitecore content tree.
Please can you advise, how can I get transparent sync to automatically
update the Sitecore Tree when any YML files are uploaded to the web app ?
Thanks and regards,
Rahul
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kamsar/Unicorn/issues/250, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGU_ZDd9pkgvf268CqitWmIq8ls25yZks5soLNUgaJpZM4Pqa-f
.

Hi Kam,
many thanks for your advice, I will take this up with Azure teams and switch to explicit manual Sync'ing.
However, when all my YML files are on web app disk, but the Sitecore content tree is empty (as it is new), when I manually press the Sync button in /unicorn.aspx to do a 1st time Sync from disk to Tree, I get ParentNotFoundExceptions like : "ParentItemNotFoundException: Exception of type 'Sitecore.Data.Serialization.Exceptions.ParentItemNotFoundException" for all my 47 items on disk.
Is it true that I have to manually do a 1st time Item creation in my new Sitecore Tree (say by uploading sitecore packages of unicorn managed items using installation wizard), and only then will the Sync button work from 2nd time onwards ? Apologies for my ignorance as I am new to Unicorn, and really loving it so far.
Thanks and best regards,
Rahul

The included paths' parent items must exist. However if it's set up right
no initial package should be required. I bootstrap stock DBs with unicorn
in my dev work.
On Mon, Oct 2, 2017, 6:18 AM RMahb<EMAIL_ADDRESS>wrote:

Hi Kam,
many thanks for your advice, I will take this up with Azure teams and
switch to explicit manual Sync'ing.
However, when all my YML files are on web app disk, but the Sitecore
content tree is empty (as it is new), when I manually press the Sync button
in /unicorn.aspx to do a 1st time Sync from disk to Tree, I get
ParentNotFoundExceptions like : "ParentItemNotFoundException: Exception of
type 'Sitecore.Data.Serialization.Exceptions.ParentItemNotFoundException"
for all my 47 items on disk.
Is it true that I have to manually do a 1st time Item creation in my new
Sitecore Tree (say by uploading sitecore packages of unicorn managed items
using installation wizard), and only then will the Sync button work from
2nd time onwards ? Apologies for my ignorance as I am new to Unicorn, and
really loving it so far.
Thanks and best regards,
Rahul
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kamsar/Unicorn/issues/250#issuecomment-333548371, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGU_b6Pqo7l2qSMq-z8q1WVOLNK3LgOks5soPDNgaJpZM4Pqa-f
.


Implement sections API endpoints

Added GET /v1/sections/id
Added GET /v1/sections/search?property=value
Added hashed api key middleware
Added documentation for the two new endpoints

Just about everything looks fine to me. My only observation is that the documentation really only outlines the returned data. If you could revise the docs to better explain how the search endpoint logic works, it would be more helpful for developers. For example, someone with black-box knowledge of the API except for what is provided in the docs wouldn't know whether or not the search endpoint individually queries each property individually and then returns all data that has any provider property, or if it makes sure all the data returns has every property listed. I know this may seem obvious but it is important since anyone will be allowed to use our API.


editorInlayHints look pretty bad

Rust-analyzer adds these super helpful but incredibly aggressive-looking inlay hints, I've overridden them myself, but I'd hope the theme would handle it better in more consistent colors.

Hey @kayteh,
I don't have any real experience using the inlay hints feature in VSC, but is something like this closer to what you'd expect/want?

These are the color settings in the screenshot:
"editorInlayHint.background": "#1d202d",
"editorInlayHint.foreground": "#a19cb9",
"editorInlayHint.parameterBackground": "#1d202d",
"editorInlayHint.parameterForeground": "#a19cb9",
"editorInlayHint.typeBackground": "#1d202d",
"editorInlayHint.typeForeground": "#a19cb9",


Python driver docs does not include rethinkdb.net.Cursor.next

If you do help(rethinkdb.Cursor.next) you get the generic auto-generated text:
Help on method next in module rethinkdb.net:

next(self, **kwargs) unbound rethinkdb.net.Cursor method
(END)

We do have documentation on Cursor.next that shows up in the web docs, but for some reason it is not being translated into the docs for the driver.

@chipotle and I looked at this a little closer. It looks like the Python docs.py file in next is just very old. The v1.16.2 branch has this, so my guess is that we have only been updating the release branches for a while.
@chipotle is going to drop the latest version into next to fix this for the moment.


bugfix: vtkconversion of 3D line mesh

For the 3D case, the z component of the points that defined the mesh was set to 0 instead
of the proper z value.

closed due to erroneous commit (sorry for that). Will be reopened once fixed.


dict_validator is broken

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
Hi there!
We are developing a project in FastAPI and faced an issue with dict validator.
As long as we are using Pydantic models with content-type: application/json it all works like a charm. Problem occurs when we try to use form-data for POST routes (content-type: application/x-www-form-urlencoded) AND it contains fields of type dict.
example:
@router.post('/route-to-view')
async def view(json_data: Annotated[dict, Form()], request: Request):
    pass

Say we post some JSON dictionary in this field as a string, eg:
{"hello": "world"}
Then we try to call this endpoint, say
curl -X 'POST' \
  'http://localhost/route-to-view' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/x-www-form-urlencoded' \
  -d 'json_data=%7B%helo%22%3A%20%world%22%7D'

But instead we get a validation error:
{
  "detail": [
    {
      "loc": [
        "body",
        "json_data"
      ],
      "msg": "value is not a valid dict",
      "type": "type_error.dict"
    }
  ]
}

Since we are pretty sure value provided IS a valid dict, we had to dig deeper.
And we could debug into pydantic/validators.py code
def dict_validator(v: Any) -> Dict[Any, Any]:
    if isinstance(v, dict):
        return v

    try:
        return dict(v)
    except (TypeError, ValueError):
        raise errors.DictError()

The issue is with line
return dict(v)
When a string contained stringified json is passed as a parameter to dict() DOES NOT return a valid dict. This built in function actually expects a list of named parameters so that will be translated into dictionary key-value pairs. And when a single string is passed as a parameter, it throws an exception: ValueError('Dictionary Update Sequence Element #0 Has Length 1; 2 Is Required') thus causing a dict_validator to fail.
We have changed this line in our local development environment by changing return dict(v) to return eval(v) and it fixes the problem for us - all the endpoints that require json as form-data work just fine. So our local version of this function looks like this:
def dict_validator(v: Any) -> Dict[Any, Any]:
    if isinstance(v, dict):
        return v

    try:
        return eval(v)
    except:
        raise errors.DictError()

Obviously it's not a reliable solution since we cannot rely on patching 3rd party libraries in production environments. And also using eval() is considered very unsafe and resource consuming. So we would really appreciate if this issue is fixed in further versions of pydantic.
Thank you!
Example Code
No response
Python, Pydantic & OS Version
pydantic version: 1.10.11
            pydantic compiled: True
                 install path: /.../venv/lib/python3.10/site-packages/pydantic
               python version: 3.10.6 (main, May 29 2023, 11:10:38) [GCC 11.3.0]
                     platform: Linux-5.19.0-46-generic-x86_64-with-glibc2.35
     optional deps. installed: ['dotenv', 'email-validator', 'typing-extensions']

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Selected Assignee: @hramezani

this looks like an issue with how you're using FastAPI, not with Pydantic.
Either way, at this stage we won't be making changes to the way dicts are validated in V1, please upgrade to Pydantic V2 and let us know if you still have an issue.

No, it is not an issue with FastAPI. Passing Annotated[dict, Form()] as an argument is perfectly valid sentence. Also you seem to not read my report properly, since I've pointed very clear the place where error occurs in your code and it has to do with wrong usage of python's built in dict() function.
At this point we could not upgrade to pydantic v2 because FastAPI is relying on pydantic v1. As soon as FastAPI becomes compatible with v2 we will upgrade immediately, but not yet. But since it's stated on your github that validation code has been backported from v1, I'm pretty sure the issue will be still there.

validation logic hasn't been "backported from v1", almost all validation logic has been completely rewritten. In a different language.
Please create a self-contained example demonstrating your problem using only Pydantic and I'll try to help you. But I'm telling you that fundamental intrinsic logic like dict_validator is very unlikely to be changed in V1 at this point.
BTW FastAPI v0.100.0 has been released with support for pydantic V2 - https://github.com/tiangolo/fastapi/releases/tag/0.100.0.


Gstreamer logging

In order to output logs from gstreamer, the only option currently in mmids is to use the GST_DEBUG environment variable.  This mixes the gstreamer logs with the normal mmids logging.
While this is useful in local development scenarios, this won't cut it for deployed scenarios when you need to determine why something in production is going wrong.
This issue is to investigate custom looking hooks into gstreamer for better logging.

Probably use something like:
debug_remove_default_log_function();
debug_add_log_function(handler);
debug_set_default_threshold(gst::DebugLevel::Warning);

With a function that calls tracing values.

Added in 08110c3269c913bdaef85246ecc8a7d3bee1609a


Modnix 3 Roadmap

Must Dos:

[x] Complete API tests.
[ ] Mod collections.
[ ] Data mods
[ ] New run-once phases HomeMod, GameMod, GeoscapeMod, TacticalMod.
[ ] New repeated phases HomeOnShow, GameOnShow, GeoscapeOnShow, TactialOnShow.
[ ] Safeguard config save (#25)
[ ] Api should return Exception on error (not thrown).

May be:

[ ] Add api events, e.g. before phase, after phase, mod loaded.
[ ] Write GUI log to file, and keep a few log backups.
[ ] Refactor log code.
[ ] Dark Theme ?

Tweaks:

[ ] Linkify mod contacts.
[ ] Add ppml to long modnix status.
[x] Rename MainGUI to Manager.

With the success of a proof of concept, Modnix can now evaluate strings in mod info on the fly. This allow mods to modify data without coming in form of dll.
The mods may be called eval mods, since they are no longer restricted to changing data.

Beta 1 release note draft
This is a preview of next major update with the most critical new features.

New "Action Mod" that process json-based .js mods.

The "Scripting Library" mod allows .js mods to run C# scripts, and in game console.

The "Laser On Fire" .js mod demo the potentials by adding damage to weapons and changing equipment abilities.

Major Changes:

Mod API now returns Exception objects on error.
A few deprecated Modnix 1 features removed.

There are also lots of minor changes.
Changelog: https://github.com/Sheep-y/Modnix/blob/v3.0-beta1/Manager/Resources/Changelog.md
Roadmap: https://github.com/Sheep-y/Modnix/issues/24
Known issues:

Mod loading order does not factor-in new phases.
GeoscapeOnHide is not triggered on Exit Game.

Modnix 3 beta 1 is compatible with PPML 0.1 and 0.2 mods.


feat(Counterexamples/CliffordAlgebra_not_injective): Some quadratic forms cannot be constructed from bilinear forms

Turns out that this follows trivially from the previous counterexample.
Perhaps there's a slicker proof that doesn't go via Clifford algebras at all, but it seemed worth recording this one anyway.

It shouldn't be too hard to use LinearMap.toQuadraticForm instead, right?


Upgrade backend base image to 3.11

Received a ModuleNotFoundError warning in the log of backend, but it looks fine. Need developer's review.
wait-for-it.sh: waiting 30 seconds for lcfs-postgres-dev-1064-postgresql.d2bd59-dev.svc.cluster.local:5432
wait-for-it.sh: lcfs-postgres-dev-1064-postgresql.d2bd59-dev.svc.cluster.local:5432 is available after 6 seconds
running prestart.sh from /app
Applying base migrations.
INFO [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO [alembic.runtime.migration] Will assume transactional DDL.
INFO [alembic.runtime.migration] Running upgrade -> e7fa1aeef86e, initial migration
INFO [alembic.runtime.migration] Running upgrade e7fa1aeef86e -> 4038ff8d8c49, Consolidated materialized views and triggers
INFO [alembic.runtime.migration] Running upgrade 4038ff8d8c49 -> 4f25f8811872, Add documents
Running Python seed script.
Traceback (most recent call last):
File "/app/lcfs/db/seeders/seed_database.py", line 11, in
from lcfs.db.seeders.test_seeder import seed_test
File "/app/lcfs/db/seeders/test_seeder.py", line 11, in
from lcfs.db.seeders.test.test_organization_seeder import seed_test_organizations
File "/app/lcfs/db/seeders/test/test_organization_seeder.py", line 4, in
from faker import Faker
ModuleNotFoundError: No module named 'faker'
Python seed script failed.
INFO: Will watch for changes in these directories: ['/app']
INFO: Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO: Started reloader process [94] using WatchFiles
INFO: Started server process [98]
INFO: Waiting for application startup.
INFO: Application startup complete.


fix: use flann_Index both in opencv2 and opencv3

fixes #228

This is broken for me, so I'm reverting to the old code
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.

import cv2
cv2.version
'3.2.0-dev'
cv2.flann_Index
Traceback (most recent call last):
File "", line 1, in
AttributeError: 'module' object has no attribute 'flann_Index'

I've pushed too fast. Sorry. I don't see the pattern between opencv version and variable name since it changed on two occasions. I'll explicitly check which name is available.

@bdholt1, I've just pushed a fix for this to master. Please, ping me in case it does not fix your problem. Thanks!


Deactivate a feature

If something goes wrong, we should be able to deactivate a specific feature for everybody at once.

Done!


Set Title Function Fixed

Now with Windows support!

Sorry I'll get around to this soon.

Just a couple notes:
Instead of using strings.Compare(os.Getenv("TERM") , "screen") == 0 you could just write os.Getenv("TERM") == "screen".
Unless you are certain these escape sequences work for all terminal types, I think you should check to make sure the terminal contains xterm before applying them (but not for the screen one obviously). So before doing the \033...\007 just check if strings.Contains(os.Getenv("TERM"), "xterm") (also make sure to check in the Fini function as well).
This means that the terminal title setting will only work in screen and xterm but I think that's acceptable.

@zyedidia Sorry about the radio silence. For one, I totally missed the notification for these comments. For another, I've been in and still am in the process of moving. We're actually in the house now, so that's nice, but over the next week I should be fairly busy with various errands. Also, I suppose I can do that, though I'd have to add another line in after the logic to check if the terminal is a screen. And uh, anyways. The only major, widely used terminal I didn't check is Konsole. I already checked and the escapes work on:

gnome-terminal
mate-terminal
urxvt
xfce4-terminal

And cause no error and no effect on:

linux terminal for at least >= kernel version 3.xx
actual xterm

I don't know if this is wide enough support and I don't know what the escape codes would do on true POSIX or VT100 emulators to be honest, so I'll go ahead and put in the logic. ( On the other side of the coin, I don't know anyone who actually uses true POSIX compatible terminals or VT100 emulators. ) For bonus points, I'll test the control codes on Konsole.

@zyedidia I put in the logic with the merge since I had to resolve the conflicts anyway. Probably should've done it in two commits, but oh well. Should be ready to merge whenever you're ready to merge it.


Add feature2

@deploy feature2

@deploy feature2

@deploy feature2

no deploy

@deploy feature3

@deploy feature2

@deploy feature2

@deploy feature2

@deploy feature2

@deploy feature2


Boostrap34admin css

Bootstrap 4 support. Fontawesome icon color/cursor.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: robiso:white_check_mark: NicolasCARPi:x: scrutinizer-auto-fixerYou have signed the CLA already but the status is still pending? Let us recheck it.


[GPU Driver Error] Inference Phi-3 on Snapdragon X Elite

Describe the bug
Hello guys, Thank you for your work.
I wanna test phi-3 inference on copilot PC(Snapadragon X Elite).
I installed onnxruntime-genai-directml to use adreno gpu.
To Reproduce
I run the phi-3 models by referring phi-3 tutorial.
"https://github.com/microsoft/onnxruntime-genai/blob/main/examples/python/phi-3-tutorial.md"
Screenshots
(genai) c:\Users\kyung\source>python.exe phi3-qa.py -g -v -m directml\directml-int4-awq-block-128
Loading model...
Model loaded
Tokenizer created
Device Type: DirectML

Input: Generate a 200 word story of starwars.
Generator created
Running generation loop ...

Output: 2024-8019 14:57:30.3851640 [E: onnxruntime:onnxruntime-genai, sequenctial_executor.cc:516 onnxruntime::ExecuteKernel] Non-zero status code returned while running DmlFusedNode_0_0 node. Name: 'DmlFusedNode_0_0' Status Message: D:\a\_work\1\s\onnxruntime\core\providers\dml\DmlExecutionProvider\src\DmlGraphFusionHelper.cpp(576)\onnxruntime.dll!00007FFFDD326373: (caller: 00007FFFDD3B88FD) Exeption(1) tid(44dc) 887A0005 The GPU device instance has been suspended. Use GetDeviceRemovedReason to determine the appropriate action.

Traceback (most recent call last):
  File "C:\Users\kyung\source\phi3-qa.py", line 105, in <module>
     main(args)
  File "C:\Users\kyung\source\phi3-qa.py", line 65, in <module>
     generator.compute_logits()
onnxruntime_genai.onnxruntime_genai.OrtException: D:\a\_work\1\s\onnxruntime\core\providers\dml\DmlExecutionProvider\src\DmlCommandRecorder.cpp(371)\onnxruntime.dll!00007FFFDD33CA80: (caller: 00007FFFDD2AF694) Exception(2) tid(44dc) 887A0020 An internal issue prevented the driver form carrying out the specified operation. The driver's state is probably suspect, and the application should not continue.

Desktop (please complete the following information):
●  OS: window11
●  Version: onnxruntime-genai-directml(0.3.0), onnxruntime-directml(1.18.1)
Additional context
I got an error from GPU driver.
How to fix this issue? Have you ever tested on Qualcomm adreno GPU?

I'm getting something similar in C#.  D:\a_work\1\s\onnxruntime\core\providers\dml\DmlExecutionProvider\src\DmlCommandRecorder.cpp(371)\onnxruntime.dll!00007FFD53F6577C: (caller: 00007FFD53ED0514) Exception(2) tid(3f6c) 887A0020 An internal issue prevented the driver from carrying out the specified operation. The driver's state is probably suspect,
and the application should not continue.
Microsoft.ML.OnnxRuntimeGenAI.DirectML 0.5.2. I just installed the Qualcomm hexagon NPU Driver <IP_ADDRESS> and I'm not even sure if it's trying to use the GPU or the NPU at this point.


Support ::name metadata property

Currently we have this legacy template interpolation for @doc which will look at the internal properties of the value passed.
@doc("{name}", T)
model Foo<T extends {}> {}

playground
This parameter is broken as it requires to be an object but it looks at the internal type properties(it doesn't actually interpolate the model properties)
We added string interpolation in a goal to remove fill that gap but it doesn't actually cover the only case where the formatArgs parameter did actually work.
We should find a way to have ::name metadata property that we can use on templates args
@doc("${T::name}")
model Foo<T extends {}> {}

::name would also be useful for discriminated unions (https://github.com/microsoft/typespec/discussions/3153#discussion-6490487).
Given the following models:
@discriminator("_type")
model Piece<T extends {}> {
  @key
  id: ID<T>; // custom scalar to denote an ID for a given model

  name: string;
  description: string;
}

model Course extends Piece<Course> {
  _type: "Course";
}

model Single extends Piece<Single> {
  _type: "Single";
}

And a newly introduced ::name meta property, we could simplify it to:
@discriminator("_type")
model Piece<T extends {}> {
  _type: T::name;

  @key
  id: string;

  name: string;
  description: string;
}

model Course extends Piece<Course> {}
model Single extends Piece<Single> {}


[Bug] Drag and Drop files onto extensions also opens the file inside the default application for that file type

Type: Bug

clone repo https://github.com/maxbublik/vscode-customeditor-drop
press f5 to demo repo
drag and drop any file into the extension editor while holding shift

Notes:
I am primarily creating this issue to track the bug I made with  https://github.com/microsoft/vscode/pull/209211
VS Code version: Code - OSS Dev 1.91.0 (Commit unknown, Date unknown)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 5800X 8-Core Processor              (16 x 3800)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.93GB (20.85GB free)

Process Argv
. --disable-extension=vscode.vscode-api-tests

Screen Reader
no

VM
50%

Extensions disabled

https://github.com/microsoft/vscode/assets/21202515/31579895-e05b-4a5c-9b0e-ddfbc2cf19d5

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.90.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

My plan is to bubble up the "drop" event like I did with the "drag" event and prevent default in the webviewDragAndDrop setting.
However, I think it should be noted that extension developers can prevent default on their own and prevent the files from opening.
I'm not 100% sure if VSCode should assume that responsibility or not but I'll make the PR anyways once I verify that my idea works. Probably this weekend when I have time!

I didn't need to bubble up the event since VSCode doesn't need to do anything with the drop event. I simply prevented default within the extension iframe html.

@mjbvz  should I move over my potential fixes from my other PR (https://github.com/microsoft/vscode/pull/219148) to this one?

Dragging and dropping from the Windows file explorer onto the webview even while holding down shift still opens the default application.
Dragging and dropping from the VS Code file explorer onto the webview while holding down shift does not work anymore.

Kindly make an immediate release with the solution as this is blocking our production release for a plugin that uses drag drop feature.

@rzhao271 I saw that you mentioned the mp4's were not working so I made a youtube video commenting on the changes on my latest PR
https://youtu.be/-yHb7srObLs
Please let me know what you think and if I missed anything. Thank you


App on/off status and iPhone status out of sync and cannot discover a way to recover

Summary | Résumé

I am running IOS 14.2 beta 2 on iPhone X. After a phone restart, the next time the Covid App was opened, it claimed the collection was off.

and the iPhone screen shows:

The App does not seem to re-synchronize to the ON state and the iPhone screen promises to delete all my exposure data if I try the turn off and on fix. So I assume the onus falls to the Covid App to get itself On again somehow.
Steps to reproduce | Étapes à reproduire

Sequence from memory of how I got out of sync; cannot repeat as my phone is in an out-of-sync state now.

Covid app was working on IOS14.2

Upgraded to IOS 14.2 beta 2 developer beta

Covid App worked (I'm pretty sure but not 100% on this)

iPhone restarted.

Covid App opened now in off state.

Environment | Environnement logiciel

iPhone X IOS14.2 beta 2 (developer beta)

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

This out of sync is not a desired state. If it remains possible the a help procedure to correctly recover sync without losing the last 14 days of exposure data would be desirable

@steve-h we're currently following up with Apple for some related issues around the region setting.
If you navigate to Settings -> Covid Alert -> Exposure Notifications -> "Health Canada" ... is that screen showing as blank?
I'm currently running iOS 14.2 beta and see:

Settings -> Exposure Notifications

Now things are weird/better. First of all the Covid app shows green and on status today and I didn't do anything. Yesterday the screen that you are asking about was totally black/blank.
So with that I am attaching shots of the region stuff that had been showing blank. The last screen has a black empty bit that I had seen when the exposure feature was enabled for IOS14 betas.

Something did happen overnight. The iPhone auto-upgraded the App to version 1.0.10. So the good news is that things at least went back to what I had seen before. The odds of reproducing how I got the App out of sync are maybe less.
I will leave it as is for now and check what happens if I restart the phone in the future.

An extra screenshot from Apple Exposure > Share a COVID-19

Very interesting thanks for the screenshots.  The latest update on our side was just a content update but looks like an app update regardless of what it was kicked off some other events on the OS layer.

Yes. Whatever code ran on app install may need to run from the Covid App side in case an out of sync occurs like it did for me. Recovery from the Apple side looks like it will delete exposure data and it is likely the onus will always be for the app to at least adopt the Apple state.

Yes, I do have remove region. It is in the earlier screenshots. I will not use it unless you want me to.

Hey! When we flagged this for Apple, they mentioned a potential work around for this could be to remove the region and reselect Canada. If we hear anything else, we will let you know!

Latest from Apple testing is try deleting the app "Remove App" from the device and re-install (onboard etc...)
After that.

Settings > Exposure Notification > Health Canada > Set As Active Region. Upon returning to the app, it now showed as alerts active.

Note: Removing the app doesn't remove the exposure checks

Well I deleted Covid alert and reinstalled. The data still is in the Apple cache.
I do not see a >Health Canada>  part to the region stuff. Looks like all the screenshots in thread.
It takes a little nerve on delete as you get the standard "all your data will be deleted" warning, and this notification

Hi @steve-h
We're told  iOS 14.2 beta 4 might fix this issue.
We're looking for some end users that we're experiencing this issue that are also running the beta.
Would you be able to confirm?

Indeed the region does work in beta 4. It shows health Canada now instead of black rect. You can close issue if you are not worried about the original out of sync. It could be a beta thing as I started using COVID alert on ios14 beta.

Great - thanks for reporting and testing.  We should see patch in an upcoming iOS release.


Add imports and function invocations to sample code

Copying and pasting the existing samples either fails due to import errors, or empty profile results if the function decorated with @profile isn't invoked. The samples have been updated so they can all be copy and pasted and run to produce the same results listed in the README

Great work! Thanks for your contribution.

Can you add a future in requirements.txt to fix the py2.7 test.
ref: https://stackoverflow.com/questions/27495752/no-module-named-builtins


resizing ui-button doesn't work

Current Behavior
changing the value of the size property, the button will add a margin instead of resizing the actual button.
Expected Behavior
The button should resize based on the value of the size property.
Steps To Reproduce
Create a ui-button set the initial size property.
Change the size property larger from the initial property but lower or same value of the group size.
Environment

Dashboard version: v1.12.4
Node-RED version: v3.1.10
Node.js version: v20.10.0
npm version: 10.8.0
Platform/OS: Windows 10 Enterprise v10.0.19045 build 19045
Browser: google chrome v126.0.6478.127, MS Edge Version 126.0.2592.81

Have you provided an initial effort estimate for this issue?
I am not a FlowFuse team member

Hi
Not able to reproduce either with Node-Red 4.0.2 or 3.1.7 (booth using Dashboard 1.12.4)
https://github.com/FlowFuse/node-red-dashboard/assets/17281826/86b1b96d-dbd7-4a66-b31a-c52a498af1d7

Thanks. I found the main cause of the issue being the global CSS I added affecting the behavior of the button.


[wip]

Changes Unknown when pulling 59a690159f9aa054f759600b2b7c4ad9a9db1233 on classic-theme into ** on dev**.

Coverage remained the same at 39.786% when pulling 3c5773df3463e6e780b1c9e2d7e44421bad1f16e on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 15fdca2219e6a4ba7738c812587db472b3225b7c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 2c562f808f31738113a16af1d16caf451a3f891c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling c7fe32d8675f3d6dc969b8b2711e5e7ef97f620d on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling c7fe32d8675f3d6dc969b8b2711e5e7ef97f620d on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling c7fe32d8675f3d6dc969b8b2711e5e7ef97f620d on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling b8856ed27cdc145c99c80970644e2c39bc116810 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ad7ee377a118d5e3ed5ef538876530415e116a21 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ad7ee377a118d5e3ed5ef538876530415e116a21 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ad7ee377a118d5e3ed5ef538876530415e116a21 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ad7ee377a118d5e3ed5ef538876530415e116a21 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ad7ee377a118d5e3ed5ef538876530415e116a21 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 472adde47fc66900c6952082913cc100d3f1f2fc on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 472adde47fc66900c6952082913cc100d3f1f2fc on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 7c80beb08367af9112fd0f2d6b8579208aef0247 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 7c80beb08367af9112fd0f2d6b8579208aef0247 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 83972e79b4f137f2d8ba4fc2dcffcb3213ba5e1b on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 563b77ec22a5681ba2a864cc9bfc855a2472c74d on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9f290425caa63950b8864301e1fa40d2d60cdb97 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9f290425caa63950b8864301e1fa40d2d60cdb97 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling f3bcc5d82374043e6370076cfd58620a071ff74c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 0fe6e8dc2a64258dbc9a5f0814fd91b6e01b3fe5 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ac8e5090835365198865fc9d1d4ae8d3ab30e4a3 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling ac8e5090835365198865fc9d1d4ae8d3ab30e4a3 on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9b7dfbd33c46f494112a1cb48614ba92bd99622c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9b7dfbd33c46f494112a1cb48614ba92bd99622c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9b7dfbd33c46f494112a1cb48614ba92bd99622c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9b7dfbd33c46f494112a1cb48614ba92bd99622c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Coverage remained the same at 39.786% when pulling 9b7dfbd33c46f494112a1cb48614ba92bd99622c on classic-theme into d1d4bf8e28099307110d45bf23d0b011daa33e10 on dev.

Changes Unknown when pulling 7af00be32e31d783b18ef3dae11066cf593132a7 on classic-theme into ** on dev**.

Coverage remained the same at 39.786% when pulling c79de6ad720ad07becd13f187ae0fd070040febe on classic-theme into 5b1c6aed4e29fc6da5377f3756f44ba8536fbf70 on dev.

Coverage remained the same at 39.786% when pulling c79de6ad720ad07becd13f187ae0fd070040febe on classic-theme into 5b1c6aed4e29fc6da5377f3756f44ba8536fbf70 on dev.

Coverage remained the same at 39.786% when pulling 03da1000a022e82933be1384359b0dbab3c47137 on classic-theme into 5b1c6aed4e29fc6da5377f3756f44ba8536fbf70 on dev.

Coverage remained the same at 39.84% when pulling 856db97528d07d0a30716f0fc9d0c061f664de47 on classic-theme into f8112723f8b09aa2bd0c93025e2b8ecf21c7f175 on dev.

Coverage remained the same at 39.84% when pulling 856db97528d07d0a30716f0fc9d0c061f664de47 on classic-theme into f8112723f8b09aa2bd0c93025e2b8ecf21c7f175 on dev.

Coverage remained the same at 39.84% when pulling 856db97528d07d0a30716f0fc9d0c061f664de47 on classic-theme into f8112723f8b09aa2bd0c93025e2b8ecf21c7f175 on dev.

Coverage remained the same at 39.84% when pulling d8a6837261c795ef889ff5d19433f8ebaf2bd4dd on classic-theme into f8112723f8b09aa2bd0c93025e2b8ecf21c7f175 on dev.


better documentation please ?

Help needed ! It would be great to see a pull request for that :)

If anyone else finds this issue looking for just a simple example of adding a Google layer, see this example:
https://github.com/shramov/leaflet-plugins/blob/master/examples/google.html
The gist of the code there is basically this (differences are just small clarifications):
<script src="path-to-shramov-leaflet-plugins/layer/tile/Google.js"></script>
<script type='text/javascript'>
var map = new L.Map('map', {center: new L.LatLng(53.9618, 58.4277), zoom: 13});
var osm = new L.TileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png');
var ggl = new L.Google(); //defaults to SATELLITE
var ggl2 = new L.Google('TERRAIN');
map.addLayer(ggl);
map.addControl(new L.Control.Layers({'Open Street Map': osm,
                                     'Google Satellite': ggl,
                                     'Google Terrain': ggl2}, {}));
</script>

And note that the full set of Google tile types are given in /layer/tile/Google.js: SATELLITE, ROADMAP, HYBRID, or TERRAIN.

Documentation for L.BingLayer and L.Yandex can be extracted from my recent commits messages. It'd easy to compile README.md

What about documentation for the permalink script?


Working version?

Hi @kimrutherford. This is the repository. It should be possible to generate the gtf file at data/pombe_genome.gtf by running the script run_with_docker.sh. See the readme for more details.

Hi @manulera
I tried run_with_docker.sh on oliver1 and got ImportError: No module named pandas
Any ideas?
Full output:
> bash run_with_docker.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1193k  100 1193k    0     0  18.7M      0 --:--:-- --:--:-- --:--:-- 18.7M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 4518k  100 4518k    0     0   339M      0 --:--:-- --:--:-- --:--:--  339M
1.1.1--pyhdfd78af_0: Pulling from biocontainers/bioconvert
Digest: sha256:20dc2db9f7cc5569fa3e01f3376e057725a51ad05db1d9a412a2135faa225e8b
Status: Image is up to date for quay.io/biocontainers/bioconvert:1.1.1--pyhdfd78af_0
quay.io/biocontainers/bioconvert:1.1.1--pyhdfd78af_0
WARNING [bioconvert.core.base:147]:  converter 'CLUSTAL2FASTA': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'CLUSTAL2NEXUS': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'FAST52POD5': method pod5 is not available
WARNING [bioconvert.core.base:147]:  converter 'FASTA2CLUSTAL': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'FASTA2NEXUS': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'FASTA2PHYLIP': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'NEWICK2NEXUS': method gotree is not available
WARNING [bioconvert.core.base:147]:  converter 'NEWICK2PHYLOXML': method gotree is not available
WARNING [bioconvert.core.base:147]:  converter 'NEXUS2CLUSTAL': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'NEXUS2FASTA': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'NEXUS2NEWICK': method gotree is not available
WARNING [bioconvert.core.base:147]:  converter 'NEXUS2PHYLIP': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'NEXUS2PHYLOXML': method gotree is not available
WARNING [bioconvert.core.base:147]:  converter 'PHYLIP2FASTA': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'PHYLIP2NEXUS': method goalign is not available
WARNING [bioconvert.core.base:147]:  converter 'PHYLOXML2NEWICK': method gotree is not available
WARNING [bioconvert.core.base:147]:  converter 'PHYLOXML2NEXUS': method gotree is not available
Traceback (most recent call last):
  File "scripts/pombasegtf_to_ensemblgtf.py", line 1, in <module>
    import pandas
ImportError: No module named pandas

Hmm, that's weird. Are you using the latest version of the repository? I cloned a fresh copy and it's working for me.

Are you using the latest version of the repository? I cloned a fresh copy and it's working for me.

Yep, it's the latest version.  It works for me on my desktop but not on oliver1.
I'm just booting up a fresh installation of Ubuntu in a VM to see if it works there.

hmm... the script relies on the fact that pandas seems to be installed in the bioconvert container, but I don't install the depency specifically.
If we don't manage to make it work, maybe adding pip install pandas or something like that to the docker run line is a hacky solution (unlikely that the pandas version matters for what I am doing)

So there was a simple solution: I changed "python" to "python3" in the run_with_docker.sh script.  On oliver1 the "python" command is python v2.  We have pandas installed on oliver1 but only for python v3.

Oh that's an error on my side. I somehow thought the python command was being executed in the container, but it's not, the ";" makes a new command entirely.

I have fixed it, maybe it was not necessary, but I think it's best since pandas is included in the container. Now the python script is executed inside the container.
https://github.com/manulera/pombase_gtf_file/commit/3effba3313aeae07698c6bdf511a52ab93676873

I have fixed it, maybe it was not necessary, but I think it's best since pandas is included in the container. Now the python script is executed inside the container.

Great.  Thanks.  That now works on oliver1.


SyntaxError: invalid regexp group

When I install your addon, I get the following error in the console: "SyntaxError: invalid regexp group"
Same thing happens with our own demo: http://bestof.morganatwork.com/storybook-addon-xd-designs/

@michelcve
I opened your link with Chrome 78.0 (Chrome OS) but couldn't see the error.
Can you provide your browser information and an error log or screenshot?

Here you go:

I was using the latest firefox:

In Chrome it work, though I do see some warnings:

Oh, what you're using is storybook-addon-xd-designs, not this addon. Please file an issue there.


Update Sui Cost Tables

Update the cost tables for natives, bytecode, consensus, etc

https://github.com/MystenLabs/sui/pull/3734

https://github.com/MystenLabs/sui/pull/3398

Remaining costs are difficult to measure. Will use formulas to approximate them

This will continue as part of calibration.
There is no distinct end to this


Update scalafmt-core to 3.2.0

Updates org.scalameta:scalafmt-core from 3.1.2 to 3.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-minor, semver-spec-minor

Codecov Report

Merging #63 (9102f11) into master (6d8a6a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   31.78%   31.78%
=======================================
  Files          17       17
  Lines         258      258
  Branches        6        6
=======================================
  Hits           82       82
  Misses        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8a6a1...9102f11. Read the comment docs.


Partially French UI

Describe the bug
Parts of the UI in the game are in French instead of English when launched from 7th Heaven.
** Versions **
[x] Tested on latest stable version
[ ] Pre-release only bug
To Reproduce
Steps to reproduce the behavior:

Play the game in English, pay attention to text (particularly for locations, battle menus, enemy names, and enemy attacks).

Expected behavior
Display the English names instead of French.
Desktop (please complete the following information):

OS: [Windows 11]
Version: [22H2]
Build: [22621.3007]

Additional context
Converting the exe did not help.
This issue is partially remedied by the Enhanced Stock UI by Chrysalis, but that only changes the locations and battle menus. The enemy names and enemy attacks are still in French. This makes me wonder if there could be a more roundabout solution by copying the official English text into a mod to overwrite the French.

This is not a problem related to 7th, but for some reason people in Canada are facing this more often, since the game forcefully downloads in French and not in English despite you picking English on Steam. Double check your connection and/or your VPN if you're using one.


HTTP SD does not remove disappeared target groups

What did you do?
I removed some target groups from my HTTP SD endpoint.
For example, the endpoint returns three target groups (mylabel :v1, v2, v3) at the first scraping.
[
  {"labels": {"mylabel": "v1"}, "targets": ["<IP_ADDRESS>:9090"]},
  {"labels": {"mylabel": "v2"}, "targets": ["<IP_ADDRESS>:9090"]},
  {"labels": {"mylabel": "v3"}, "targets": ["<IP_ADDRESS>:9090"]}
]

Then the endpoint returns only one target group (v1) at the second scraping.
[
  {"labels": {"mylabel": "v1"}, "targets": ["<IP_ADDRESS>:9090"]}
]

What did you expect to see?
HTTP SD removes disappeared target groups from scrape targets. In the case of the example, v2, v3 should be deleted.
What did you see instead? Under which circumstances?
I still see disappeared target groups (v2, v3 in the example) in scrape targets.
HTTP SD may need to send empty updates for deletion as File SD does.
Environment

Prometheus version: prom/prometheus:v2.28.0
Prometheus configuration file:

scrape_configs:
  - job_name: http_sd_job
    http_sd_configs:
    - url: http://localhost:8080/targets.json
      refresh_interval: 5s

Fixed by #9020, released in 2.28.1

@roidelapluie @servak Thanks for the quick fix and release!
I confirmed that this issue is fixed in Prometheus v2.28.1.


Obsoletion notice: GO:0008565 protein transporter activity

Dear all,
The proposal has been made to obsolete GO:0008565 protein transporter activity. The reason for obsoletion is that the term has been inconsistently used: it’s been used mostly as the ‘protein transport’ process, but annotations represent various mechanisms to transport proteins.
There are 116 EXP annotations as shown below. I have created a review ticket with suggestions as to how to re-annotate:
https://github.com/geneontology/go-annotation/issues/2293

Contributor   (Assigned by)
Number of annotations

CACAO
1 @sandyl27

dictyBase
1 @pfey03

EcoCyc
1 @keseler

EcoliWiki
3

FlyBase
9  @hattrill

GeneDB
2 @ggeorghiou

MGI
13 @hdrabkin

SGD
47 @srengel

TAIR
6 @tberardini

UniProt
30 @milarolo

There are also 8 InterPro families with mappings @happy-lorna
This term is present in 3 slims:
goslim_chembl
goslim_generic
goslim_yeast
(the slim tags could be moved to the BP 'GO:0015031 protein transport'?)
Any comments can be  added to the issue: https://github.com/geneontology/go-ontology/issues/17071
We are opening a comment period for this proposed obsoletion. Since this involves some reannotation, I propose to obsolete this term on April 8th, 2019. Unless objections are received by April 8th, 2019, we will assume that you agree to this change.
Thanks, Pascale

Took care of mine, thanks!

Hi Pascale, for obsoletions can you also  non-exp evidence codes. Pombe has a lot of ISS which we will need to reannotate but they are not in this list. We prefer to do them before the term disappears.
Also we have one experimental (IGI) but that doesn't appear.
https://www.pombase.org/term/GO:0008565

I also found one IC we have and deleted that.

I have added a second spreadsheet with the non-IEAs annotations

Contributor   (Assigned by)
Number of annotations

AgBase
1

ARUK-UCL
1

ComplexPortal
3

dictyBase
10

FlyBase
32

GeneDB
14

JCVI
12

MGI
18

PINC
3

PomBase
6

RGD
1

SGD
1

TAIR
4

TIGR
12

UniProt
66

RGD has deleted the one TAS annotation.

Still to do: delete Reactome dbxrefs


A few things I see:

You don't need to run npm install, our platform will do that automatically.
platform=windows won't work because our platform does not run Windows, you probably want platform=web.
If the gulp command is running a server, then it will not work with ZEIT Now. You will need to use Serverless Functions.


report all duplicated column names at once

Currently it only reports the first case

Just checked in the test system and this has been solved for both the sample and the prep info files.


Update load-balancer-internet-overview.md

Removing encrypted traffic wording as the image is about traffic on port 80.

@grellis,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@grellis : Thanks for your contribution to the Azure documentation! The author, @kumudd, has been notified to review your proposed change.

#sign-off