Gitea stopped working after a git push, hook crashed?

Git version: 1.11.4
Operating system: Debian 10
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Log gist: see below

Description
When I made a git push I got this an error when processing the internal gitea hooks:
$ git push
Enumerating objects: 22, done.
Counting objects: 100% (22/22), done.
Delta compression using up to 8 threads
Compressing objects: 100% (15/15), done.
Writing objects: 100% (15/15), 1.80 KiB | 1.80 MiB/s, done.
Total 15 (delta 13), reused 0 (delta 0), pack-reused 0
remote: . Processing 1 references
remote: Gitea: Internal Server Error
remote: Unable to contact gitea: Post http://localhost:3000/api/internal/hook/post-receive/mondas/mondas: read tcp [::1]:36456->[::1]:3000: i/o timeout

I had to press Ctrl+C to stop the push, it hanged. I tried to open the web interface but the page could not be loaded. Doing a curl https://mygiteapage delivered HTML content, but curl https://mygiteapage/user/login?redirect_to= also hanged.
Systemd's journal of the Gitea services was not showing anything unusual, I could see the login attempts that I myself tried
May 27 21:22:55 gitea gitea[468]: [Macaron] 2020-05-27 21:22:55: Completed GET /vendor/assets/font-awesome/css/font-awesome.min.css 200 OK in 312.83µs
May 27 21:23:16 gitea gitea[468]: [Macaron] 2020-05-27 21:23:16: Started GET /user/login?redirect_to= for xx.xx.xx.xx
May 27 21:23:17 gitea gitea[468]: [Macaron] 2020-05-27 21:23:17: Started GET / for xx.xx.xx.xx
May 27 21:25:09 gitea gitea[468]: [Macaron] 2020-05-27 21:25:09: Started GET /user/login?redirect_to= for xx.xx.xx.xx
May 27 21:25:16 gitea gitea[468]: [Macaron] 2020-05-27 21:25:16: Started GET /user/login?redirect_to= for xx.xx.xx.xx
May 27 21:25:34 gitea gitea[468]: [Macaron] 2020-05-27 21:25:34: Started GET /user/login?redirect_to= for xx.xx.xx.xx
May 27 21:25:47 gitea gitea[468]: [Macaron] 2020-05-27 21:25:47: Started GET /user/login?redirect_to= for xx.xx.xx.xx

so I decided to stop the process. The systemctl stop gitea.service took at least one minute to end and then I inspected the journal again, now I got this:
$ journalctl -e -u gitea
...
May 27 21:26:46 gitea systemd[1]: Stopping Gitea (Git with a cup of tea)...
May 27 21:27:47 gitea gitea[468]: [Macaron] 2020-05-27 21:27:47: Completed POST /api/internal/ssh/3/update/1 500 Internal Server Error in 6m49.225738586s
May 27 21:27:47 gitea gitea[468]: panic: sync: negative WaitGroup counter
May 27 21:27:47 gitea gitea[468]: goroutine 496105 [running]:
May 27 21:27:47 gitea gitea[468]: sync.(*WaitGroup).Add(0xc001d49d10, 0xffffffffffffffff)
May 27 21:27:47 gitea gitea[468]:         /usr/local/go/src/sync/waitgroup.go:74 +0x139
May 27 21:27:47 gitea gitea[468]: sync.(*WaitGroup).Done(...)
May 27 21:27:47 gitea gitea[468]:         /usr/local/go/src/sync/waitgroup.go:99
May 27 21:27:47 gitea gitea[468]: code.gitea.io/gitea/modules/graceful.wrappedConn.Close(0x3347d40, 0xc001d2d930, 0xc001d49ce0, 0xc0086fa008, 0x330ace0, 0xc012064e10)
May 27 21:27:47 gitea gitea[468]:         /go/src/code.gitea.io/gitea/modules/graceful/server.go:253 +0x83
May 27 21:27:47 gitea gitea[468]: net/http.(*conn).close(0xc010256000)
May 27 21:27:47 gitea gitea[468]:         /usr/local/go/src/net/http/server.go:1662 +0x42
May 27 21:27:47 gitea gitea[468]: net/http.(*conn).serve.func1(0xc010256000)
May 27 21:27:47 gitea gitea[468]:         /usr/local/go/src/net/http/server.go:1771 +0xbf
May 27 21:27:47 gitea gitea[468]: net/http.(*conn).serve(0xc010256000, 0x3335ae0, 0xc0073aa6c0)
May 27 21:27:47 gitea gitea[468]:         /usr/local/go/src/net/http/server.go:1900 +0xa49
May 27 21:27:47 gitea gitea[468]: created by net/http.(*Server).Serve
May 27 21:27:47 gitea gitea[468]:         /usr/local/go/src/net/http/server.go:2928 +0x384
May 27 21:27:47 gitea systemd[1]: gitea.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
May 27 21:27:47 gitea systemd[1]: gitea.service: Failed with result 'exit-code'.
May 27 21:27:47 gitea systemd[1]: Stopped Gitea (Git with a cup of tea).

I made a backup of the database and I inspected the sqlite3 file and it was OK, it doesn't seem to be corrupted or anything.
So I restarted Gitea and now is working fine again, I can access the web interface again. I can see that the commits were pushed but the database was not updated (it was the hook which failed). I tested pushing again:
$ git commit --amend
$ git push
....
Writing objects: 100% (8/8), 918 bytes | 918.00 KiB/s, done.
Total 8 (delta 7), reused 0 (delta 0), pack-reused 0
remote:
remote: Create a new pull request for 'dev_new_scheduler_loop':
remote:   https://mygiteapage/myuser/myproject/compare/master...somebranch
remote:
remote: . Processing 1 references
remote: Processed 1 references in total
To mygitea:user/project
 + b47d03e73...c2d9f8e79 somebranch -> somebranch (forced update)

It seems to be fine again. So the question is, what happened? Should I worry? Is this something you've already seen?

We need the logs around the time of:
remote: Gitea: Internal Server Error
remote: Unable to contact gitea: Post http://localhost:3000/api/internal/hook/post-receive/mondas/mondas: read tcp [::1]:36456->[::1]:3000: i/o timeout

Then we can try to find some reason as to why there was a hang - potentially there was a deadlock in SQLite but without some more info as to where it got stuck we're just guessing,
The logs around panic: sync: negative WaitGroup counter are not anything to be worried about - we've put a PR in to prevent these. (In 1.12)

Hi, is there a way to give you the last 1000 lines of the logs in a more secure & private way? I don't want to put the log in a public settings (don't want to expose private information like IP, users, repositories, etc.).

You can message me directly on our discord

How can I send you directly? Is there a way in github to send a private message?

Hi,I've created an account on discord and tried to send a message to you, but I got the error Your message could not be delivered because you don't share a server with the recipient or you disabled direct messages on your shared server, recipient is only accepting direct messages from friends, or you were blocked by the recipient.. I've never used discord, I don't know what do do.

https://discord.gg/Gitea

I've never used discord, so I don't really know what to do there or how to send you privately the log file without everybody else seeing it. I looked at previous post on the discord page and found you, tried to send you a message but got the error mentioned above. Perhaps if you tell me how to do that in discord, like I said, never used it, I'm completely unfamiliar with it :(


some refactoring

Changes Unknown when pulling dd7e08473543429aa81e43796c7a3afa60313b6a on Jakousa:trunk into ** on OhtuGrappa2:trunk**.

Coverage decreased (-0.6%) to 57.907% when pulling 750f952d0728fc3cfbf8be333cecbb2adb6507b2 on Jakousa:trunk into 5d91216e798ea257639a78554ff0b861e6b7b4c9 on OhtuGrappa2:trunk.

Coverage decreased (-28.9%) to 29.588% when pulling 67ea07c56028740c93e065a2115a1a1596df553e on Jakousa:trunk into 5d91216e798ea257639a78554ff0b861e6b7b4c9 on OhtuGrappa2:trunk.

Coverage decreased (-28.8%) to 29.674% when pulling ff3059bd1aa46202ee3f51b7d6fcbbf9d28dea24 on Jakousa:trunk into 6d550dcbf80c9c61236078de611e43e736200b6b on OhtuGrappa2:trunk.

Mitähän ihmettä kävi coveragelle tossa "refactor routes" kohdassa..

Coverage decreased (-31.3%) to 27.158% when pulling 24da6fadd11f193477bb569a7544ba49e0b792c3 on Jakousa:trunk into 6d550dcbf80c9c61236078de611e43e736200b6b on OhtuGrappa2:trunk.

Coverage decreased (-31.3%) to 27.19% when pulling 6a7ef3ec6de3efc1b84b4b2cb0abbec7acf706a8 on Jakousa:trunk into 6d550dcbf80c9c61236078de611e43e736200b6b on OhtuGrappa2:trunk.

Coverage decreased (-31.3%) to 27.19% when pulling bdbb3190212f9e5db41a232d3ee7839d4787b236 on Jakousa:trunk into 6d550dcbf80c9c61236078de611e43e736200b6b on OhtuGrappa2:trunk.

Coverage decreased (-30.7%) to 27.789% when pulling a50e5e8591b1ea2ecdc2e06a3750cc09c3bf5386 on Jakousa:trunk into 6d550dcbf80c9c61236078de611e43e736200b6b on OhtuGrappa2:trunk.

Coverage decreased (-30.7%) to 27.789% when pulling cb611ebf8159d15a1706c582b39ff943b272d719 on Jakousa:trunk into 6d550dcbf80c9c61236078de611e43e736200b6b on OhtuGrappa2:trunk.


Error logs have regressed to the point they are basically useless.

The previous power platform build tasks used to show detailed error logs. The current ones display something akin to this:

In order to get to the actual REASON for the failed solution import I then have to navigate to make.powerapps.com and view the history

This is the information we need to see in the Task logs. This has been raised but was raised on #239  but that was another issue which then got closed.
I would like to see a return to how the previous build tasks showed the logs. Thanks.

ping

Have you tried clicking on the "Enable system diagnostics" when running your pipeline?
The log files should then contain more detailed logs coming from the internal Pac CLI.

Thanks... This is a good tip and helps somewhat in the immediate future - however, the previous version of the tasks had detailed logging and output this as standard. The removal of this is a regression. For this reason I no longer user the build tools tasks and do everything in a powershell task with pac cli directly.

Yo! @cT-m00cat, this situation is straight-up regression. I gotta remember to enable system diagnostics, 'cause that's the fix, you know what I'm saying? But honestly, I'd rather have the tasks go back to how they used to be, showing all the detailed log output like before. Might have to take a page outta @cT-m00cat's book and just use pac cli directly.


Ansible2

This is syntax update for ansible 2

Thanks @jfcoz some of those will likely remove a log of deprecation warnings :).
I'm just curious, where did you find that this was the v2 way to write things?
Don't we do {{ foo }} but {{foo}}? Or does this only work for groups and with_items?

For {{foo}} it's from the deprecation warning.
For with_items it's from http://docs.ansible.com/ansible/playbooks_loops.html#looping-over-the-invento

@jfcoz unfortunately, it seems that this is breaking 1.9.4... :(
Not sure if everyone has moved to v2 yet...

@jfcoz give me a couple of days, I'm rethinking how I want to manage 1.9.4 and v2

@jfcoz would you mind rebasing this?

@jfcoz thanks for the rebase. Give me some time to see where it is failing in 1.9.4 thanks!

test this please

@jfcoz can I get a sign-off from you? I just pushed #1068 and I'd like to add you as a co-author for this as you originally started this initiative. Thanks!


Increase minimum Go version to 1.22

1.22 is the minimum version required by a couple of dependencies.

Might it make sense to squash the latest commit with the first one (with the Go version bump)? It'll ensure we can bisect the repo going forward

LGTM
Would it be possible to add more information about the dependencies that require 1.22 in the commit message?

LGTM
Would it be possible to add more information about the dependencies that require 1.22 in the commit message?

I don't really know. I just see dependabot failing with a diff that indicates that 1.22 is required.

It looks like k8s.io/api is one of these dependencies:

https://github.com/kubernetes/api/commit/b374e580f9e2820e0870f45715ab92e2916f0664
https://github.com/kubernetes/kubelet/commit/8ce7a49ca85885ce6ce6f26ef206be17979d8623

@rst0git Added k8s.io/api to the commit message.
@snprajwal squashed


Add customer managed key for SQS for fixing issue #38

Issue #38
Description of changes:
Add customer managed key for SQS to avoid that CloudWatch event invocation failed due to limited access to default encryption key of SQS.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi - This should have been resolved in the most recent commit to this Solution. Please let us know if you need additional assistance.


Added LIS algorithm

Description
Find out the size of the longest increasing subsequence.

@vatsalsharma376 You are encouraged to create an Issue first with the name of the program and then refer the issue in a PR.


codemirror/mode/rpm/changes/index.html made webpack build error

here is build error:
 WARNING  Compiled with 1 warnings                                                                                10:41:24

 warning  in ./node_modules/codemirror/mode/rpm/changes/index.html

Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type.
| <!doctype html>
|
| <title>CodeMirror: RPM changes mode</title>

 @ ./node_modules/codemirror/mode lazy ^\.\/.*$
 @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib/selector.js?type=script&index=0!./packages/codeMirror/src/main.vue
 @ ./packages/codeMirror/src/main.vue
 @ ./packages/codeMirror/index.js
 @ ./packages/index.js
 @ ./examples/main.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 webpack/hot/dev-server ./examples/main.js

This is not a loader issue but a codemirror issue I think.
I have checked what i get from npm, there is  no doc directory, but codemirror/mode/rpm/changes/index.html need some resource depend on it.

You appear to be including an HTML file as if it is a script. That won't work, and suggests the problem is in your build setup.

The build script is generated by vue-cli, and it doesn't do anything with  .html file.
how to reproduce the compile error:

vue init webpack
add CodeMirror.vue into components folder
add <code-mirror :options="{mode: 'javascript', theme: 'mbo'}"></code-mirror> into App.vue
run npm run dev

CodeMirror.vue:
<template>
  <div :id="id"></div>
</template>

<script>
import CodeMirror from 'codemirror'
import 'codemirror/lib/codemirror.css'

export default {
  name: 'EvCodeMirror',
  props: { options: { type: Object } },
  data() {
    return { codeMirror: null, id: `CodeMirror_${+new Date()}` }
  },
  mounted() {
    import(`codemirror/theme/${this.options.theme}.css`)
    import(`codemirror/mode/${this.options.mode}/${this.options.mode}`).then(() => {
      this.codeMirror = CodeMirror(document.getElementById(this.id), this.options)
    })
  },
}
</script>

Have the same error, Codemirror need to do something it should not do, my code only have this:
require('expose-loader?CodeMirror!codemirror/lib/codemirror');
require('expose-loader?debounce!debounce');
//require('expose-loader?LightningFS!../../lightning-fs');
require('expose-loader?LightningFS!../lightning-fs.min.js');
require("codemirror/lib/codemirror.css");
require('codemirror/addon/scroll/simplescrollbars');
require('codemirror/addon/scroll/simplescrollbars.css');
require("codemirror/addon/edit/matchbrackets");
['css', 'xml', 'javascript', 'htmlmixed', 'scheme'].forEach(function(mode) {
    require(`codemirror/mode/${mode}/${mode}`);
});
require("codemirror/theme/twilight.css");

Some file in codemirror need to be loading html file.
This only happen in development mode of webpack, maybe the import is stripped off by tree shaking.

I think this is bug in webpack. if I create any file in mode directory webpack try to loaded it.


Add a Grand Exchange option for setting the default "withdraw as" option (note/item)

Currently RS switches the options based on if there are 1 or multiple items to collect. My suggestion is to add a setting for the user to set a default option so it doesn't change.

@Rami-J Thanks for contributing 👍
I was just thinking, does it work with the "collect" option in the Grand Exchange? It also changes the withdraw type depending on the stack size.

@fashionLeek I've only gotten the collect button to swap entries between "Collect to inventory" and "Collect to bank". When I collect to inventory using the collect button, it still changes withdraw type depending on stack size.


slim.js doc website - github button not working on firefox

on Firefox 61.0b11 (64-bit).
clicking this btn opens a tab with  about:blank in the url.

@viggin543 will check.

fixed


feat: fetch minimal data and cache where possible

finding all open disputes in a session requires looping over the entire disputes array. Not getting voteCounters reduced the time from ~700ms/dispute to ~200ms/dispute.
Cache data used in fetching disputes (timestamps, open disputes, meta evidence)
Getting disputes table should be much faster but still relatively slow (~ 200ms * number of disputes + (2-9 seconds) * number of sessions juror was drawn + some extra time for http requests, draws, dispute created event).
Loading a dispute takes about 15 seconds.

Pull Request Test Coverage Report for Build 777

6 of 40 (15.0%)  changed or added relevant lines in 4 files are covered.
9 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.09%) to 16.327%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/resources/Disputes.js
0
1
0.0%

src/contracts/implementations/arbitrable/Arbitrable.js
1
4
25.0%

src/utils/StoreProviderWrapper.js
1
4
25.0%

src/contracts/implementations/arbitrator/Kleros.js
4
31
12.9%

Files with Coverage Reduction
New Missed Lines
%

src/utils/StoreProviderWrapper.js
1
2.86%

src/resources/Disputes.js
1
5.26%

src/contracts/implementations/arbitrable/Arbitrable.js
2
5.26%

src/contracts/implementations/arbitrator/Kleros.js
5
2.45%

Totals

Change from base Build 770:
-0.09%

Covered Lines:
201

Relevant Lines:
1001

💛  - Coveralls


How can I specify the direct mode at connectionMode?

We have a performance problem on registering 2,000 data.
So, I've tried to connect by direct mode to document DB.
But I could not find any definition for direct mode in documents.js.
Only gateway mode seems to be defined.
ConnectionMode: Object.freeze({
    Gateway: 0
}),

And 'ConnectionMode' not seems to be referenced at any files.
Can I specify the connectionMode or not?

sorry, this is just a question. so, I'll ask this on other QA site.

@kaneshuzou JavaScript client doesn't supports Direct mode and only works in Gateway mode.

thanks, I'll take the other solution.


Update compiled-grammar.js

This label was causing a browser error in a webpack generated bundle, so I removed it as it's not referenced anywhere else in the file.
I know that the file is generated, but I don't know how to fix it properly.
Btw, great library. I really like that it doesn't try to be your router. :+1:

Thanks! could you give me a bit more detail on where you were seeing errors? I'd like at least understand what problem this is causing, even if I can't fix the toolchain for it.
Maybe we can figure that out and come up with a different way to work around it. To get this fixed in this way (changing the compiled file), we'll need to update the compile-parser execution path somehow, so this doesn't get lost and reintroduced when the grammar gets updated.

Looking into this more, https://github.com/zaach/jison/pull/305 looks rather promising. When I get a chance, i'll try updating there, or will accept a PR for it.

You're right. Updating jison to the latest version did the trick.
If you decide to merge this, please also publish a new version on npm.

Would you mind squashing these two commits down to one? I'll merge and cut a new version.
Thank you!

I made a new pull request #14 .


Insert default/template chart into placeholder?

Thanks a lot for creating this useful tool!
I have a problem when trying to insert charts which are based on my customized chart template into multiple placeholders. I create a chart template which has line and bar types and a few edits on text direction and coloring, and saved it as my default chart. However, I don't know how to insert such charts into placeholders. Is there a way to do placeholder.insert_chart(XL_CHART_TYPE.DEFAULT, chart_data)? Appreciate if you can point out a way to solve this issue.
Jin

@just4jin did you find a work around / solution to this? @scanny Any idea how we could customise chart styles if not using templates? For example changing the background colour or a chart or font sizes? Thanks

@just4jin I'm not exactly sure what you're proposing. I think you'll need to spell it out a bit more as far as what behaviors you'd like to see. Are you saying put a chart in a chart placeholder and just replace the data? That you can do today with Chart.replace_data(). That will respect all the formatting and other customization that you've already done.

@jdelight Chart styles are a thing, and there's a way to specify which one to apply to a chart, I think it's chart.chart_style = {n in range 1-48}. However these chart styles are formed by a built-in PowerPoint algorithm that combines theme color choices and "effect" styles. I think it's 6 color combos X 8 effect styles. Both of these are defined in the theme. An effect is like what 3D effect, shadow or no, gradient, maybe transparency, etc.
There is a mechanism, I think it's called example charts, or chart templates, or something. These are each a separate file that can be stored in the PowerPoint templates directory. I'm not sure of their exact behavior, and they're not supported in python-pptx as of yet, but might be something to explore.

Thanks @scanny - yes we have chart templates which we can easily apply in the PowerPoint UI. I've had a look using opc-diag at the resulting pptx after applying a chart template and looks like there are a few extra rels/files added to the charts folder. So it seems like the options are either:
a) apply the individual styles manually to each chart (legend, label, fonts / colours etc...) and figure out how the background colour for a chart can be set (still not sure on that one)
b) use opc-diag to  unpack the pptx, add the extra raw files (e.g. theme.xml, colours.xml) and somehow re-link them back to the chart, then repackage the files.

A customized chart style cannot be defined by an end-user (or anyone else). However, a lot of what they do can be customized by customizing the theme in the template you're using.

This also sounds like a good approach - so will give that a go.
Great library btw and really well documented 👍

@jdelight I'm actually working on something now that might need something like this. Can you say a bit more about your use case and how you do it manually, like what set of chart templates you keep around, "like one for this, one for that, this other one works for all these"?
Maybe we can thing about something like Chart.apply_template('templates/my-chart.crtx').

That API would be fantastic! chart.apply_template('templates/my-chart.crtx').
Our use case is that we have an analytics application which allows users to create several types of charts (line, bar, horizontalBar, pie etc...). Our UX designers have created a reference PPTX file with examples of how each type of chart should look. At the moment we're recreating the look of each chart as we dynamically build pptx presentations.
For example, certain type of clustered column charts need to have legends, other charts may not need a legend or title for example.
So the ideal workflow is that we save a set of chart templates from our reference pptx file.
Then as we build presentations we can just apply the correct template - based on arbitrary metadata for the chart.
The real benefit here is that our UX designers can create a set of chart templates within the Powerpoint UI and we (developers) don't really need to worry about the effects. We can just say given chart type "x", apply template "y".
One other thing is that it's possible to have chart templates show/hide chart elements. So a chart template could show axis titles or trendlines.
If that API existed and we could apply templates - would it be possible to manipulate things like chart axis titles even though there's not an API for it in python-pptx yet.
If it is possible then in theory that opens up a lot of functionality for developers in that they can store/apply chart templates then dive into the underlying xml to update content/text etc...
I'd be happy to help work on this as it's something we feel will save us time and immediate improve the quality of our generated powerpoint files. I need to skill up a bit on openxml but let me know if there's a way I can help.

That's great @jdelight :)  The first step would be for us to flesh out an enhancement proposal page (what I used to call "analysis page"). The key purposes for that are:

Agree on the API/calling protocol (fairly trivial in this case I think)
Work out the scope, both full general scope of the completed feature, and what makes sense as a chunk to bite off initially. In this case I think it would mostly be a statement of expected behaviors.
Collect all the technical documentation elements (schema excerpt, any MS API references and enumerations, specimen XML) we'll need to plan and execute the implementation.

These are located here; this new one could be named cht-apply-template.rst:
https://github.com/scanny/python-pptx/tree/master/docs/dev/analysis
The enhancement proposal is mergeable separately, even if we decided not to go forward with implementation (never happened so far :).
I'm thinking the key questions in this case will be:

What is contained in a chart template (and what is specifically not?). At a glance it looks like everything except the series data points is included, but it will take some snooping around and probably some before/after comparisons with opc-diag to confirm that.
What does PowerPoint do when you apply a template to a chart? This can also be determined by before/after XML diffs.

Let me know if you're keen and if there are any details you need me to help with :)

Thanks for the thorough outline @scanny  - I've checked with the team to decide if we have time to start on this. We don't right at the moment. But one of the things we're wondering is with the current release assuming we have a chart instance - is it possible to do something like:
chart.element.insert_some_xml_after_element([xml string])
I'm thinking specifically if we can just drop in some xml for a chart title for example.
I didn't seem to find much around manipulating the underlying xml - but I got the impression it was possible. If you could point to some useful docs or part of the code base that would be great.

@jdelight Apologies for a delayed reply, lost track of this one. You can use the "oxml layer" to do what you want; actually a combination of some base lxml API and some of the oxml wrapper. The oxml layer is just the code in pptx.oxml that provides some wrapper on lxml. The key modules are probably oxml (init.py), oxml.ns, and oxml.xmlchemy.
Basically I'd find the element of interest with XPath:
element = other_element.xpath('.//c:title')[0]

then use oxml/lxml operations to add some stuff after:
new_subtree = parse_xml(new_xml)
element.addnext(new_subtree)

The lxml API for the _Element class is here:
http://lxml.de/api/lxml.etree._Element-class.html
All XML elements in python-pptx derive from that class and also from oxml.xmlchemy.BaseOxmlElement.
If you search around on 'python-pptx OR python-docx workaround function' you'll find some other approaches.

Fantastic thanks @scanny - will give that a go.

@scanny Is there a chance that it will ever be completed? I have exactly the same situation as in the comment of @jdelight


public $user : data of object and related objects visible for user

https://github.com/mikebarlow/megaphone/blob/e0eb25922c2fb58ecc16118a23d6634dcb147341/src/Livewire/Megaphone.php#L11
currently $user is a public variable and the user-model with all related models is serialized as json and visible for the user client side. This can be a major security issue. As far as I see $user is not used in the components templates so could you please change this to
class Megaphone extends Component
{
    private $user;
...

this would solve the problem.
thx

Can you give an example or screenshot of this in practice? I cannot see anything on my front end for this when rendering the livewire component.
Often I see comments on posts with people bringing up this complaint and 9/10 times it's because they have barryvdh/laravel-debugbar installed and they're seeing the requests from that and mistaking that for the live wire request.

https://github.com/mikebarlow/megaphone/blob/e0eb25922c2fb58ecc16118a23d6634dcb147341/src/Livewire/Megaphone.php#L11
currently $user is a public variable and the user-model with all related models is serialized as json and visible for the user client side. This can be a major security issue. As far as I see $user is not used in the components templates so could you please change this to

class Megaphone extends Component

{

    private $user;

...

this would solve the problem.
thx

Can you give an example or screenshot of this in practice? I cannot see anything on my front end for this when rendering the livewire component.
Often I see comments on posts with people bringing up this complaint and 9/10 times it's because they have barryvdh/laravel-debugbar installed and they're seeing the requests from that and mistaking that for the live wire request.

Another thing to note here as per the Livewire 2.0 docs:

Note: For this to work, you need to have a validation entry in the $rules property for any model attributes you want to bind to. Otherwise, an error will be thrown.

Since there is nothing bound to $user  there will be no actual data passed.
The reason that it cannot be made private or protected is because of this:

protected and private properties DO NOT persist between Livewire updates. In general, you should avoid using them for storing state.
You should also note that while null data type is Javascript-friendly, public properties set to null DO NOT persist between Livewire updates.

So after we trigger a markAsRead() we need to reload the announcements for the user and if user is set to protected or private it will be null and the loadAnnouncements() will return an empty collection.

PR #21 will address the concerns brought up in this issue. @mikebarlow what do you think?

Hey, so yeah I think @axelzuzek concern is that the user model is visible when you inspect the internal API calls that Livewire performs. So for example from the Megaphone demo, when I run a mark as read command, here is a screenshot from the payload, you can see the serialized user model with ID exposed.

Thanks for the PR, I'll take a look in the next few days. My initial thought had been to remove the public $user and try and do something with $request->user() as I think the user session should be available within Livewire requests. That way we can remove the need for passing the serialized model or even a "notifiable_id" so there should be no issues with user model data being visible in the main request payload.

request()->user() is what's being used to set the public notifiable_id property right now, so really we could just drop the public property all together and just use request user in the markAsRead function... I'll make a change to to PR and test in the morning. 👍🏻

I've updated the PR with the suggestions from this conversation. Let me know what you think.

any news here?

Hey, sorry real life got in the way of getting this done.
Just finished up the readme changes and merged in now as 1.2.0

Hey Mike, just updated the component and it works flawless. Thx a lot!


Enable github auth for grafana

Connects to ministryofjustice/cloud-platform#445

@jasonBirchall I've pushed 5b77847, can you take another look please?


Use ion-hash-tests verbatim

Due to #219, the current tests in ion-hash use a subset of the full test suite with the unloadable elements removed. Once this bug is fixed, we should go back and use the tests from the submodule directly.

https://github.com/amzn/ion-rust/blob/76ceb3b0edab4760af78455e10f11dee21932de2/ion-hash/tests/ion_hash_tests.rs#L82 is the line that needs to change.


🐛 [firebase_performance][iOS] httpMetricStart ended up in a crash

Bug report
Describe the bug
App crashed several times - the crash log seems to indicate that firebase_performance is the culprit.
This is an ongoing project in which recently we've bumped versions of all Firebase components (firebase_performance moved from version 0.7.0+9 to 0.9.0+9), without any other major changes, esp. in the native part.
Today, around the same time (12-13 GMT - in case somehow the backend could impact the behavior..?), two devices (iOS 16) started crashing in one of the app flows, resulting in nearly identical crash reports (7 in total).
The problem could not be reproduced with the same scenario later today.
Date/Time:           2023-01-25 13:16:02.6219 +0100
Launch Time:         2023-01-25 13:15:25.3363 +0100
OS Version:          iPhone OS 16.0 (20A362)
Release Type:        User
Baseband Version:    2.09.01
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Triggered by Thread:  0

Application Specific Information:
abort() called

Last Exception Backtrace:
0   CoreFoundation                	       0x1d5b36248 __exceptionPreprocess + 164
1   libobjc.A.dylib               	       0x1cef03a68 objc_exception_throw + 60
2   CoreFoundation                	       0x1d5cda6d4 -[__NSCFString characterAtIndex:].cold.1 + 0
3   CoreFoundation                	       0x1d5ce5b38 -[__NSDictionaryM setObject:forKey:].cold.3 + 0
4   CoreFoundation                	       0x1d5b2e9f8 -[__NSDictionaryM setObject:forKey:] + 840
5   Runner                        	       0x101213e74 0x1005c4000 + 12910196
6   Runner                        	       0x101213a64 0x1005c4000 + 12909156
7   Flutter                       	       0x102d23cd0 0x1027ac000 + 5733584
8   Flutter                       	       0x1027efde4 0x1027ac000 + 277988
9   libdispatch.dylib             	       0x1dcfb04b4 _dispatch_call_block_and_release + 32
10  libdispatch.dylib             	       0x1dcfb1fdc _dispatch_client_callout + 20
11  libdispatch.dylib             	       0x1dcfc07f4 _dispatch_main_queue_drain + 928
12  libdispatch.dylib             	       0x1dcfc0444 _dispatch_main_queue_callback_4CF + 44
13  CoreFoundation                	       0x1d5bc6a08 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
14  CoreFoundation                	       0x1d5ba8368 __CFRunLoopRun + 2036
15  CoreFoundation                	       0x1d5bad1e4 CFRunLoopRunSpecific + 612
16  GraphicsServices              	       0x20e9cd368 GSEventRunModal + 164
17  UIKitCore                     	       0x1d805cd88 -[UIApplication _run] + 888
18  UIKitCore                     	       0x1d805c9ec UIApplicationMain + 340
19  Runner                        	       0x1005cbef8 0x1005c4000 + 32504
20  dyld                          	       0x1f3ed1948 start + 2504

I had troubles automatically symbolicate the crash, but managed to decode the lines manually (we do store dSYMs from our builds)
Lines 6-5 translate to:
atos -arch arm64 -o Runner.app.dSYM/Contents/Resources/DWARF/Runner -l 0x1005c4000 0x101213a64
-[FLTFirebasePerformancePlugin handleMethodCall:result:] (in Runner) (FLTFirebasePerformancePlugin.m:0)
atos -arch arm64 -o Runner.app.dSYM/Contents/Resources/DWARF/Runner -l 0x1005c4000 0x101213e74
-[FLTFirebasePerformancePlugin httpMetricStart:withMethodCallResult:] (in Runner) (FLTFirebasePerformancePlugin.m:92)

[EDIT]
Got the issue symbolicated by Crashlytics, it also extracted the cause in a better way:
NSInvalidArgumentException - *** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: 19)

The issue seems to be pretty similar to #10240 - it seems like the returned httpmetric happened to be null in these cases.. Looking at the Firebase API, the method used does return a nullable value, so it is not impossible.. https://firebase.google.com/docs/reference/ios/firebaseperformance/api/reference/Classes/FIRHTTPMetric
Why aren't the calls guarded with a try-catch statements to prevent problems like that (on the Android side, each handler is done this way)?
Steps to reproduce
No clear way of reproducing the issue unfortunatelly - happened few times in a row, and stopped :/
The flow that triggered the crash in our app involves establishing a connection to a new Wifi network, without Internet access. Once established, API requests are sent immedietaly and all there requests are measured with the Firebase http metric.

Flutter doctor
Happened with a release build coming from a build pipeline - no Flutter doctor from there. Below are versions of the Flutter and plugins from pubspec (same versions are in the lock file)
Flutter 3.3.9

  firebase_analytics: ^10.1.0
  firebase_core: ^2.4.1
  firebase_crashlytics: ^3.0.9
  firebase_performance: ^0.9.0+9

Thanks for the report @b055man
Pretty much looks similar to the issue you linked : https://github.com/firebase/flutterfire/issues/10240 which was fixed and new version of the plugin was released that has the fix: https://pub.dev/packages/firebase_performance/changelog#09010
You seem to be on one version lesser (^0.9.0+9) so most probably getting the crash still, so is there a way for you to upgrade the plugin version and check once again to see if you still get the crash or if the above fix helps in your case too?

@darshankawar it is similar but it clearly deals with a different method - the one fixed was related to the firebase trace. In my case, the issue is with the HttpMetric, and the flow is different - so I don't think it'd help :) The fix is not general, it is limited to that specific (trace) method.

Thanks for the update. Keeping this issue open and labeling for team's attention, as there's no concrete steps to replicate or code sample to verify.


appeared constantly re-open re-close of electron login window after I using google contact logined

as title

it is running automatically

it is v16.17.0

and I using Stage Management in Ventura. probably

I pushed an hotfix, you can find it in the 1.1.5 version, today the open ai changed cookies handling, i introduced the new cookie cf_clearance handling. You have to clear session with command: 'assistant reset auth' before retry

my version is 1.1.5 now, and I run 'assistant reset auth'
but still, the problem occurs

Sorry there was some problems that i fixed after the implementation of Cloudflare by OpenAI.
With the version 1.2.1 you shouldn't have any problem, i tested with Ventura and Ubuntu (WSL).
You can launch 'assistant clean' to reset session

I updated to version 1.2.3, the problem was gone !

same problem with 1.4.0 macos


Explore Mock OkHttpClient Testing Implementation

An OkHttpClient instance which can be scripted similar to MockWebServer. The advantages here are explicit control over the objects passed back to the caller and much lower overhead.

https://github.com/square/retrofit/blob/763fe1639e3348480214873323caacd00cbd7fa6/retrofit/src/test/java/retrofit/MockClient.java

Hi guys, based on @swankjesse comment I've created this repo: https://github.com/gmazzo/okhttp-client-mock. I can make a PR to include it in your mock API if you like it.

Hello guys.. Any updates here? I'd love to see this feature as native on okhttpclient.

Closing out as https://github.com/gmazzo/okhttp-client-mock is probably the right way to go here.


Https request using Alamofire with AWS beanstalk, nodejs , and NginX

Hi, I'm David.
I have fund lot of searching information related to Https with alamofire but, I'm not sure perfectly answer
The problem is when I request with 'https://www.example.com' domain, then I get a error
as I see log on my server, the log has not any other request, So, I think ATS of iOS might be blocking..
2017-08-28 02:59:11.357445+0900 A380[25209:1977377] [] nw_coretls_callback_handshake_message_block_invoke_3 tls_handshake_continue: [-9807]
2017-08-28 02:59:11.357 A380[25209:1977385] NSURLSession/NSURLConnection HTTP load failed (kCFStreamErrorDomainSSL, -9802)

also, I'm not sure plist configuration.
<key>NSAppTransportSecurity</key>
	<dict>
		<key>NSExceptionDomains</key>
        <dict>
            <key>www.example.com</key>
            <dict>
                <key>NSThirdPartyExceptionMinimumTLSVersion</key>
                <string>TLSv1.2</string>
                <key>NSThirdPartyExceptionRequiresForwardSecrecy</key>
                <false/>
                <key>NSIncludesSubdomains</key>
                <true/>
            </dict>
        </dict>
	</dict>

what is the best solution???
P.S
if I access my domain address on web browser as www.example.com or http://www.example.com, then all of requests on web browser automatically access to https://www.example.com because of nginX
what should I do??

Sorry, we use our GitHub project for bug reports and feature requests. In the future, you should open questions like this on Stack Overflow and tag alamofire.
Cheers. 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


The search box for the Portal home page does not match the one in the Data Browser

The portal dropdown lists the following facets:

Organ
Disease (should be "Known Diseases"?)
Project
Organ Part
Instrument Manufacturer Model
Institution (not in Browser - remove?)
Biological Sex
Laboratory
Genus Species

The Data Browser adds:

Organism Age
Organism Age Unit
Preservation Method (shows "Storage Method" in "Method" dropdown)
Library Construction Approach
Protocol
File Format

Both search boxes should have identical contents, including presenting facets in the same order.

Testing in dev: In the Browser "Known Diseases" is the 2nd facet in the list whereas it should be 6th as it is in the Portal search bar.


Readme Update Incomplete

The Readme has been updated from
An "Action" is an [`Operator`](api/spell/Operator.kt)
An action that pushes a spell is a [`Spell`](api/spell/SpellOperator.kt)

to
An "Action" is an [`Operator`](api/spell/Action.kt)
An action that pushes a spell is a [`Spell`](api/spell/SpellAction.kt)

when it should probably be as below?
An "Action" is an [`Action`](api/spell/Action.kt)
An action that pushes a spell is a [`SpellAction`](api/spell/SpellAction.kt)

@Talia-12 this is fixed, right?


[ISSUE #2538]send trace data failed, print exception info

Make sure set the target branch to develop
What is the purpose of the change
The original log does not log any error info when sending meessage trace data failed. It`s hard to find the cause of failed on th production environment. And if any people who do not know source code, they even do not know it has sent failed according to log.
Brief changelog
Modify log level from info to warn， And printing exception info.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.09%) to 51.849% when pulling a400da4df91d713fda388ba1bb7b7d911023b165 on xxd763795151:trace_data_log into 0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop.

Coverage decreased (-0.09%) to 51.849% when pulling a400da4df91d713fda388ba1bb7b7d911023b165 on xxd763795151:trace_data_log into 0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop.

Codecov Report

Merging #2544 (a400da4) into develop (0239421) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #2544      +/-   ##
=============================================
+ Coverage      45.97%   45.98%   +0.01%
- Complexity      4318     4322       +4
=============================================
  Files            547      547
  Lines          36236    36236
  Branches        4808     4808
=============================================
+ Hits           16658    16663       +5
- Misses         17491    17492       +1
+ Partials        2087     2081       -6

Impacted Files
Coverage Δ
Complexity Δ

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
73.60% <33.33%> (-0.51%)
17.00 <0.00> (ø)

...tmq/logappender/log4j2/RocketmqLog4j2Appender.java
36.66% <0.00%> (-8.34%)
4.00% <0.00%> (ø%)

...ain/java/org/apache/rocketmq/test/util/MQWait.java
43.24% <0.00%> (-5.41%)
3.00% <0.00%> (ø%)

...he/rocketmq/client/impl/consumer/ProcessQueue.java
57.67% <0.00%> (-4.19%)
31.00% <0.00%> (-1.00%)

...nt/impl/consumer/ConsumeMessageOrderlyService.java
38.98% <0.00%> (-3.62%)
16.00% <0.00%> (ø%)

...ava/org/apache/rocketmq/filter/util/BitsArray.java
58.11% <0.00%> (-1.71%)
29.00% <0.00%> (-1.00%)

...che/rocketmq/namesrv/kvconfig/KVConfigManager.java
59.18% <0.00%> (-1.03%)
11.00% <0.00%> (-1.00%)

...ketmq/client/impl/consumer/PullMessageService.java
75.55% <0.00%> (ø)
9.00% <0.00%> (ø%)

...etmq/client/latency/LatencyFaultToleranceImpl.java
50.00% <0.00%> (ø)
8.00% <0.00%> (ø%)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0239421...a400da4. Read the comment docs.

Codecov Report

Merging #2544 (a400da4) into develop (0239421) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #2544      +/-   ##
=============================================
+ Coverage      45.97%   45.98%   +0.01%
- Complexity      4318     4322       +4
=============================================
  Files            547      547
  Lines          36236    36236
  Branches        4808     4808
=============================================
+ Hits           16658    16663       +5
- Misses         17491    17492       +1
+ Partials        2087     2081       -6

Impacted Files
Coverage Δ
Complexity Δ

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
73.60% <33.33%> (-0.51%)
17.00 <0.00> (ø)

...tmq/logappender/log4j2/RocketmqLog4j2Appender.java
36.66% <0.00%> (-8.34%)
4.00% <0.00%> (ø%)

...ain/java/org/apache/rocketmq/test/util/MQWait.java
43.24% <0.00%> (-5.41%)
3.00% <0.00%> (ø%)

...he/rocketmq/client/impl/consumer/ProcessQueue.java
57.67% <0.00%> (-4.19%)
31.00% <0.00%> (-1.00%)

...nt/impl/consumer/ConsumeMessageOrderlyService.java
38.98% <0.00%> (-3.62%)
16.00% <0.00%> (ø%)

...ava/org/apache/rocketmq/filter/util/BitsArray.java
58.11% <0.00%> (-1.71%)
29.00% <0.00%> (-1.00%)

...che/rocketmq/namesrv/kvconfig/KVConfigManager.java
59.18% <0.00%> (-1.03%)
11.00% <0.00%> (-1.00%)

...ketmq/client/impl/consumer/PullMessageService.java
75.55% <0.00%> (ø)
9.00% <0.00%> (ø%)

...etmq/client/latency/LatencyFaultToleranceImpl.java
50.00% <0.00%> (ø)
8.00% <0.00%> (ø%)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0239421...a400da4. Read the comment docs.

This is an outdated pr, may be has been fixed or fix it  later, so I close it now.
I`m sorry for rembering to deal with it now.


Document usage of examples

How are users supposed to get the examples? Via git? Should we provide a link to an archived version?

Fixed in #231.


[google-cloud-cpp] update to latest release (v1.32.0)

Updates google-cloud-cpp to the latest release (v1.32.0)
I tried but failed to use vcpkg_cmake_config_fixup(). Will try again in a future PR.

What does your PR fix?

N/A

Which triplets are supported/not supported? Have you updated the CI baseline?

No change

Does your PR follow the maintainer guide?

yes.

Yes.

Thanks for the update!


Update controls per CNSWPv2 updates

Background
I created a new doc v1.1 to include the updates from CNSWPv2. I also added a changelog to indicate what has been added compared to v1.
Note to Reviewers
(1) For now, any new controls have been added at the end of the doc. While adding them in the respective locations would be recommended, I'm concerned that it leads to 'ID' being updated for all other controls and that would be difficult to keep a track/update dependent frameworks
(2) CNSWPv2 recommends several SSCP best practices as well as GitOps best practices which are already covered in SSCP controls. (check (3) & (4) in the changelog file). Do we think we should add each control separately again as a part of CNSWP or since it is covered in SSDP, it is fine?

Is it a fair summary to say that there are only 3 additional controls in the CNSWP v2 vs v1?  Meaning that CNSWP v2 is a true superset of v1

@pratiklotia please rebase on main

@pratiklotia when you get a chance can you please give this PR some love?  Thanks!


Document how to send UDP messages

Adds a basic usage section to the readme.md with some sample code.

Dear Anton,
The email sent to<EMAIL_ADDRESS>with subject
"Re: [VeniceX/UDP] Document how to send UDP messages (#6)"
will be delivered as soon as possible.
Your email address is automatically added to the
recipients 'whitelist'. This means for further
emails to<EMAIL_ADDRESS>you will not receive a delivery
notification again.
TK MAILIAS

Looking for a way to Protect Your Identity and
for a great no-more-spam solution for your email
address<EMAIL_ADDRESS>Sign up for TK Mailias.
It's free! Please visit http://www.mail.tk/

Oh, why nobody seen this? 😱
thank you!


chore: bump werkzeug and Flask

SUMMARY
Bump Flask and Werkzeug
https://nvd.nist.gov/vuln/detail/CVE-2023-30861
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hi @dpgaspar! We have a Mypy configuration problem in #23927
Do you know how to fix it?

Basically the problem is that some dependencies (e.g. Flask since version 2.0) have stubs include in their main distribution, while other dependencies require stubs to be installed vie the typeshed distribution. (i.e. the 'types-*' packages from PyPI).

Hi @dpgaspar! We have a Mypy configuration problem in #23927 Do you know how to fix it?

Basically the problem is that some dependencies (e.g. Flask since version 2.0) have stubs include in their main distribution, while other dependencies require stubs to be installed vie the typeshed distribution. (i.e. the 'types-*' packages from PyPI).

not yet

@cwegener @dpgaspar I found that mypy PR which resolves flask & werkzeug typing problems.
@dpgaspar Can you try to upgrade the mypy version?

@cwegener @dpgaspar Ohh we already has v1.0.1 mypy but it downloads flask-stubs because we use additional_dependencies: [types-all] in .pre-commit-config.yaml file

Hi @dpgaspar! We have a Mypy configuration problem in #23927 Do you know how to fix it?

Basically the problem is that some dependencies (e.g. Flask since version 2.0) have stubs include in their main distribution, while other dependencies require stubs to be installed vie the typeshed distribution. (i.e. the 'types-*' packages from PyPI).

I'm actually not very concerned about the static type checking at the moment. I think it's a lower priority.
Getting the Async Query Runner working with Flask 2.2 is currently the main blocker for migrating to Flask 2.2

@cwegener @dpgaspar Ohh we already has v1.0.1 mypy but it downloads flask-stubs because we use additional_dependencies: [types-all] in .pre-commit-config.yaml file

Yes. The solution for this particular mypy issue should be to remove the types-all dependency in the pre-commit config and replace it with the curated, explicit list of all desired python type stubs packages that we know are required to successfully run static type checks.

Would it be better to go to Flask 2.2 before migrating to Flask 2.3?

This is great job!
Now we need to fix the flask-stubs issue.
We use additional_dependencies: [types-all] in .pre-commit-config.yaml file which downloads the old flask-stubs.

Would it be better to go to Flask 2.2 before migrating to Flask 2.3?

Flask is on 2.2


Refactor loadTestDataStore to use performFuzzActions

Description
Refactors the sendOps implementation of LoadTestDataStore to use the performFuzzActions paradigm.
I'm opening this as a draft PR as I'm not convinced it's particularly high-value: the implementation of sending ops isn't a super large part of these tests, is pretty hand-crafted, and this doesn't significantly change overall readability. I think the large op jittering might be slightly more readable, and this structure lends itself more nicely to writing config-enabled features with a mixin pattern (thus more well-chunked code), but it doesn't really advance the goal we have to make workloads more customizable, which is the main thing left to be desired by current service load architecture.
Open to thoughts from reviewers if this is a direction we want to head in--I figured I might as well propose it as an option. See AB#3681 for more context.

i don't intend to merge this currently. would still love someone's opinion on if it makes things clearer (I think it does for me, but it's a bit subjective), but have no larger agenda here.


[v1.4.x] Apply deconv FIx

Description
this patch applies PR https://github.com/apache/incubator-mxnet/pull/13433 to release 1.4.x, which fixes mkldnn deconvolution under certain conditions.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Apply https://github.com/apache/incubator-mxnet/pull/13433 to release

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@srochel

@mxnet-label-bot add [Operator, pr-awaiting-review]


Preview support/Candidate-changed-hook

Would it be possible to add some stable api which allows to hook into Selectrum when the selected candidate changed. Maybe something exists already but I overlooked it? It would be great to have this in order to support previews. See
https://github.com/minad/consult/blob/a98a6e456360e751d37c3bda5fd9c7b068c9f512/consult.el#L184

@okamsn I refactored this a bit more and the solution is not that bad now I think.
https://github.com/minad/consult/blob/a98a6e456360e751d37c3bda5fd9c7b068c9f512/consult.el#L184
But it would still be nice if we wouldn't have to rely on an internal name.

There are two more related issues regarding preview:

There is the variable completion-all-sorted-completions (living in minibuffer.el, so quite fundamental?), which is a list of all completions. This variable is not set by selectrum, but it is set by icomplete for example. Is this variable part of the completing-read api or more related to the completions buffer and some additional ad-hoc mechanism on top of completing-read. I know there is selectrum-get-current-candidate, which I am using right now. But I still wonder about the variable.

Is there a possibility to get the matches of the current filtering? This would be helpful to highlight the matches in the preview buffer of consult-line (swiper), consult-mark etc. It seems to me that this is dependent on the filtering framework (e.g. prescient, orderless)? But how could that be done in selectrum and icomplete?

@clemera Do you have an opinion about this? I know you don't like preview...

After implementing consult-preview-mode I am happy with my solution - therefore I can close this. I don't expect we would win much by adding some preview support to selectrum since it would not help with regards to compatibility with for example icomplete. Please let me know if you have some other comments regarding preview. @okamsn Since you reacted with :+1:, is the solution implemented in consult acceptable to you?

Yes, Consult previews are working well for me.


Scale diffusion data by Jacobian determinant?

Hello,
I'm trying to correct for EPI distortions in diffusion data (hence my earlier question about restrict-deformation). This paper - http://dx.doi.org/10.1016/j.neuroimage.2012.06.081 - indicates that best practice is to calculate the deformation as a pre-processing step before calculating the tensor, and importantly to scale the pre-processed images by the Jacobian determinants to correct for 'signal pile-up'. Am I correct in thinking that antsApplyTransforms does NOT scale by the Jacobian? In which case I think the pipeline should look like:

Extract a b=0 image from my diffusion dataset
Register to structural image with restrict-deformation ~1x0.1x0.1
Calculate Jacobian with CreateJacobianDeterminantImage on the Inverse warp
Apply the forward transformation to all diffusion images
Multiply all diffusion images by the Jacobian
Calculate my tensor + FA + MD etc...

Note that I do not have to worry about subject motion (ex-vivo samples).
My question is do I have steps 3 & 5 the correct way round - i.e. should I be using the Inverse warp & multiplying? Or should it be division, and/or the forward warp?
Hope that makes sense, and if I've missed an example that covers this just point me to it.
Thanks,
Toby

hi toby
antsApplyTransforms will not scale by the jacobian.   you should calculate
the jacobian of the mapping that is in the space of the structural image.
if the t1 is the fixed image, then this is the forward transformation.
then you would divide the signal intensity (voxel-wise) by the jacobian.
note: a possible problem with this solution is that there is true loss of
information in the "signal pile up" which cannot be corrected.
brian
On Thu, Aug 6, 2015 at 1:59 AM, Tobias Wood<EMAIL_ADDRESS>wrote:

Hello,
I'm trying to correct for EPI distortions in diffusion data (hence my
earlier question about restrict-deformation). This paper -
http://dx.doi.org/10.1016/j.neuroimage.2012.06.081 - indicates that best
practice is to calculate the deformation as a pre-processing step before
calculating the tensor, and importantly to scale the pre-processed images
by the Jacobian determinants to correct for 'signal pile-up'. Am I correct
in thinking that antsApplyTransforms does NOT scale by the Jacobian? In
which case I think the pipeline should look like:

Extract a b=0 image from my diffusion dataset
Register to structural image with restrict-deformation ~1x0.1x0.1
Calculate Jacobian with CreateJacobianDeterminantImage on the
Inverse warp
Apply the forward transformation to all diffusion images
Multiply all diffusion images by the Jacobian
Calculate my tensor + FA + MD etc...

Note that I do not have to worry about subject motion (ex-vivo samples).
My question is do I have steps 3 & 5 the correct way round - i.e. should I
be using the Inverse warp & multiplying? Or should it be division, and/or
the forward warp?
Hope that makes sense, and if I've missed an example that covers this just
point me to it.
Thanks,
Toby
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTs/issues/217.

Hi,
When using the pipeline steps outlined below, the Jacobian is the same for all of the DWI volumes, and hence the intensity correction would also be constant, and would have no effect on the diffusion tensor calculation.
The Jacobian scaling is usually applied when correcting for eddy-current distortions. Often this is done by registering each DWI to the b=0 image, or to a T2 image. The distortion will differ across the DWI volumes, which makes the Jacobian correction necessary.
As Brian says, you can't recover details when there is a severe signal pileup, but if there is a small change in volume that retains the features of the image, the Jacobian correction can help.
On Aug 8, 2015, at 11:41 AM, stnava<EMAIL_ADDRESS>wrote:

hi toby
antsApplyTransforms will not scale by the jacobian. you should calculate
the jacobian of the mapping that is in the space of the structural image.
if the t1 is the fixed image, then this is the forward transformation.
then you would divide the signal intensity (voxel-wise) by the jacobian.
note: a possible problem with this solution is that there is true loss of
information in the "signal pile up" which cannot be corrected.
brian
On Thu, Aug 6, 2015 at 1:59 AM, Tobias Wood<EMAIL_ADDRESS>wrote:

Hello,
I'm trying to correct for EPI distortions in diffusion data (hence my
earlier question about restrict-deformation). This paper -
http://dx.doi.org/10.1016/j.neuroimage.2012.06.081 - indicates that best
practice is to calculate the deformation as a pre-processing step before
calculating the tensor, and importantly to scale the pre-processed images
by the Jacobian determinants to correct for 'signal pile-up'. Am I correct
in thinking that antsApplyTransforms does NOT scale by the Jacobian? In
which case I think the pipeline should look like:

Extract a b=0 image from my diffusion dataset
Register to structural image with restrict-deformation ~1x0.1x0.1
Calculate Jacobian with CreateJacobianDeterminantImage on the
Inverse warp
Apply the forward transformation to all diffusion images
Multiply all diffusion images by the Jacobian
Calculate my tensor + FA + MD etc...

Note that I do not have to worry about subject motion (ex-vivo samples).
My question is do I have steps 3 & 5 the correct way round - i.e. should I
be using the Inverse warp & multiplying? Or should it be division, and/or
the forward warp?
Hope that makes sense, and if I've missed an example that covers this just
point me to it.
Thanks,
Toby
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTs/issues/217.

—
Reply to this email directly or view it on GitHub.

Ah! Thanks Phillip, I had missed that the scaling was to correct for differences in eddy-currents between the b values.
In this case the more pressing problem is large EPI distortions in all the diffusion images, which may be too severe to recover with a non-linear registration. If I get a chance this week I will try to put an example image up somewhere and if anybody has time and is kind enough to have a try themselves I am open to suggestions.
Thanks both,
Toby

closing due to lack of activity/interest.

Hi, I know this is an old threat, but if someone is still active I do appreciate:
In a very similar procedure, I am mutiplying the gradients by the Jacobian from the transformation, however my question is:
Should I mutiply by the Jacobian of the forward transformation, or the Jacobian of the inverse transformation (I guess that would be similar to dividing by the Jacobian)?
Thanks!


AMQ Custom song list game script: "answer results" listener failed error

https://gyazo.com/f0340c4f99e7f209dc32ed491013d0b0
Plays the first song according to the list just fine, but then stalls during answer reveal and with no reveal and displays CSL Error: "answer results" listener failed. Persists after multiple computer/browser restarts and re-installations.

delete AMQ Song List script by joseph

that worked! thanks for the immediate response too, really appreciate it!


Awesome work, why remove the render method of ScreenClassRender?

I am currently, using the render method of ScreenClassRender; I am unable to update to .7 because the method was removed. Is there a reason for removing it?

I removed it because AFAIK, it was unused and undocumented. If you really need it, I can put it back in the next version :)

It's restored :smile:

@gerbenmeyer thank you so much!!!


ConsoleAPI: Add lauchedGroupID/groups.id to experiment.json

🚀 Deployed on https://6373c613dd270034ef6b8df2--cozy-fox-0defec.netlify.app


Toastr Container

Hi all!
It seems to me that after a toast is rendered (and then disappears) the container also disappears with it.
And, after that, my old container stops existing, and following toasts will render inside the default container with fixed position.
Is there anything I should be aware of?
Stay awesome,
tbragaf

I have the same issue.

I hacked this behaviour with an empty span inside the container xD

@tbragaf hah nice!

The container should be RECREATED once a new toast appears. Specifically, the toastr.xxxxxx() functions will internally call the notify() function. Within notify(), it gets the container using the internal function getContainer(options,true). The second parameter being true means that it will first try to find an existing container, and if not then it will create the container and return that.

This isn't an issue - the container is removed by design once there are no remaining toasts.

@TimFerrell So how can I achieve my purpose?

@TimFerrell I don't want the container to disappear from my div element.

Why are you trying to prevent the container from closing?

@TimFerrell because I want the toasts to always appear inside it.

The container will recreate itself automatically. Maybe I'm not asking the right questions here but can you please explain why you don't want this to happen?

In my sample, the container recreates at the default position: body
And I need it inside another tag

Sorry for the slow response. You can specify the element that the container appears within - is that not happening for you?

@TimFerrell How so?
I tried with:


fixgroup by expr may be bound twice in bind agg slot

Proposed changes
select
      1,
      id / (select max(id) from t2)  as 'x',
      count(distinct c) as 'y'
  from
      t2
  group by
      1,
      x

in above sql, Alias(x) may be bound both in binding agg output and binding group by expr. This pr fix the problem and make sure the Alias(x) can be bound only once.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Traffic compression, udp/tcp.

English Only.
will you add a traffic compression feature?
to save bandwidth, because wireguard does not know how to compress traffic.

no, don't want to put this feature into udp2raw.
this feature can be implement outside of udp2raw. For example,
you can implement a compression tunnel and chain that in between:
wg client---->compression tunnel client---->udp2raw client----------------------------->udp2raw server--->compression tunnel server ----> wg server
In this way, the tunnel will be more re-usable

what are the tunnels with this feature?

for tunnelling tcp traffic, kcptun has the feature.
for udp there are a few on google, but I never used them. I cannot suggest.

Which "tcp" tunnels do you know?

First, I feel I don't communicate well with you.
Second, I checked your history on github, I found something something suprising in https://github.com/cnbatch/kcptube/issues/24 :

You are not welcomed here as well I guess.

blocked and reported


ClamAV implementation

In order to detect potential malware, could ClamAV or something similar be used to scan for known issues? It could then mark the problematic file or automatically delete it.

The idea of CIRCLean is to detect potentially malicious files without relying on antiviruses, and we figured out that on USB keys, we can be a lot stricter and detect more potentially malicious content by searching active files, or files with active content, than with signatures.
But if you want to support clamav, we welcome contributions so as long as clamav is an optional dependency, we'd be happy to merge it.


#6 Autocomplete for cities + #2 Dinamic background color + #17 Cards & Logo

Need a new Google Maps Javascript API for the pod repo with this name REACT_APP_GOOGLE_API_KEY
Added redux to access to the state of the variable city
Added react component for the autocompletion, Autocompletion.js
Move the weather api calls to a separate file, webServices.js
Added necessary dependancies for Tailwind
Added responsive and semi transparent cards displaying the information of each city
Moved the MLH logo to the left top corner
Refactor in components
Change color scheme depending of temperature
#6
#17
#2

@GustavoElizarraras Can you DM me the key for REACT_APP_GOOGLE_API_KEY so I can add it to production and we can test it.

Regarding the design, the other issue we were assigned to was to change the background depending on the weather, Mahmoud made some little changes. Let me correct/revert the styling in this PR and open an issue for displaying weather information in cards (currently working on it also)

@khattakdev This PR is for all of our issues, looking good in the preview, the only missing thing is the API key, I have already sent it to you.

@GustavoElizarraras This looks cool but it doesn't show the map and the reminder message ( Don't forget to bring ... )

@khattakdev Oh, I thought when we solved the merged conflicts all of it would come together, let us fix this.

@khattakdev Everything is working now!


parallel RNG

Could a RNG be added for parallel use?
Would require a "jump" function or equivalent to produce statistically independent streams.
For use with multi-threading would require thread-safe independence.
As well as higher "rand" functions stability.
RandomNumbers package has some candidate RNGs. In particular, from the Xorshifts.Xoshiro family: Xoshiro256Plus and Xoshiro256StarStar.

I somewhat feel that for the use case of this package (tests), this feature is probably not needed by many, but would have a quite high maintenance cost.
I'm very unfamiliar with threads in Julia, but currently when threads are involved, it's my understanding that reproducibility is often impossible to achieve, no? But this package's only goal is to support reproducibility... Anyway, for tests, wouldn't it be good enough to initialize different RNGs (on different threads) with randomly looking seeds? Sure nothing is proven, but it might be enough for tests.

As well as higher "rand" functions stability.

I don't understand what you mean here!

OK, fair enough. You make some good points.


scipy.integrate.solve_bvp BC Jacobian Size

There is an issue with the description of the size of the BC Jacobian in the documentation. In the doc, the following is said for the size of the BC Jacobian:

dbc_dya : array_like with shape (n, n) where an element (i, j) equals to d bc_i(ya, yb, p) / d ya_j.
dbc_dyb : array_like with shape (n, n) where an element (i, j) equals to d bc_i(ya, yb, p) / d yb_j.
dbc_dp : array_like with shape (n, k) where an element (i, j) equals to d bc_i(ya, yb, p) / d p_j.

However, it should say that the sizes of those arrays are (n+k, n), (n+k, n), and (n+k, k), respectively. Using the second example in the doc (Sturm-Liouville) and following the size requirements shown above, the following Jacobian can be made:
def bc_jac_v2(ya, yb, p):
    # dbc_dya, dbc_dyb = (n,n)
    # dbc_dp = (n, k)
    dbc_dya = np.array([[1, 0],
                       [0, 0]])
    dbc_dyb = np.array([[0, 0],
                       [1, 0]])
    dbc_dp = np.array([0, 0])
    return dbc_dya, dbc_dyb, dbc_dp
sol = solve_bvp(fun, bc, x, y, p=[6], bc_jac=bc_jac_v2)

However, it gives a ValueError from the coo_matrix function within _bvp.
ValueError: row, column, and data array must all be the same length

Changing the dbc_dya, dbc_dyb, and dbc_dp matrices to have shapes (n+k, n), (n+k, n), and (n+k, k) respectively,
def bc_jac_v1(ya, yb, p):
    # dbc_dya, dbc_dyb = (n+k,n)
    # dbc_dp = (n+k, k)
    dbc_dya = np.array([[1, 0],
                       [0, 0],
                       [0, 1]])
    dbc_dyb = np.array([[0, 0],
                       [1, 0],
                       [0, 0]])
    dbc_dp = np.array([0, 0, -1])
    return dbc_dya, dbc_dyb, dbc_dp
sol = solve_bvp(fun, bc, x, y, p=[6], bc_jac=bc_jac_v1)

successfully solves the BVP and gives the same result as without using the BC Jacobian.
Scipy/Numpy/Python version information:
1.0.0 1.14.0 sys.version_info(major=3, minor=6, micro=4, releaselevel='final', serial=0)

Looks like a real bug/misinformation. I will check it.

Hello
I have two nonlinear coupled equations. how can I calculate the bc_jac for them?
How should I define it in python and, how should I use it in solve_BVP function?


added node.max_local_storage_nodes to sandbox config

this allows to start up to 3 nodes from within intellij

Codecov Report

Merging #5543 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5543      +/-   ##
============================================
- Coverage     82.78%   82.62%   -0.16%
+ Complexity    11454    11432      -22
============================================
  Files          1360     1360
  Lines         44427    44427
  Branches       5535     5535
============================================
- Hits          36778    36707      -71
- Misses         5079     5142      +63
- Partials       2570     2578       +8

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/io/crate/planner/PositionalOrderBy.java
41.02% <0%> (-41.03%)
9% <0%> (-4%)

...in/java/io/crate/lucene/match/CrateRegexQuery.java
43.47% <0%> (-30.44%)
4% <0%> (-4%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
75% <0%> (-25%)
2% <0%> (ø)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...ava/io/crate/data/CloseAssertingBatchIterator.java
71.42% <0%> (-10.72%)
9% <0%> (-1%)

...peration/collect/BatchIteratorCollectorBridge.java
65.78% <0%> (-10.53%)
2% <0%> (ø)

...ate/planner/node/dql/PlanWithFetchDescription.java
80% <0%> (-10%)
12% <0%> (-2%)

...io/crate/protocols/postgres/types/VarCharType.java
91.66% <0%> (-8.34%)
10% <0%> (-1%)

...ain/java/io/crate/lucene/GenericFunctionQuery.java
63.82% <0%> (-6.39%)
9% <0%> (-1%)

...src/main/java/io/crate/data/RowsBatchIterator.java
95.23% <0%> (-4.77%)
11% <0%> (-1%)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2de066...0585a36. Read the comment docs.


New action request: einaregilsson/build-number

Action name
uses: einaregilsson/build-number
Reasons
einaregilsson/build-number

Intended usage
einaregilsson/build-number

I have checked the internal marketplace for similar actions and couldn't find one that works for us.

[X] I have checked the internal marketplace first

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:white_check_mark:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:x:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Check completed with result: ✅
Found 0 Dependabot security vulnerabilities:
0 where high and 0 where moderate.
Use this link to verify the alerts.


port feathers-shallow-populate to feathers-graph-populate

First of all: just the pure port, nothing fancy, nothing has changed as proposed in #28 (1).

[x] hook
[x] tests
[x] docs

Second: finally add github actions

[x] replace yarn with npm
[x] working configs
[x] add node.js workflow

psssssst @marshallswain, what are your plans on graph-populate? When will you have time for this and is there anything I can do to support you?

Closing in favor of #41


Set up and Configure Dev Environments

Open in MURAL
CAMD 3-PI Roadmap - EPA CAMD Business Suite - ECMPS and AMPD

See closed issues

Marking this as invalid; covered under #19


[Bug]: We could not connect to our servers please check your internet connection - Getting this error when accessing appsmith from browser

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I am running appsmith on kubernetes and when i access the appsmith using Loadbalancer Ip from browser , getting below error message
We could not connect to our servers please check your internet connection
Steps To Reproduce
install on kubernetes using below link
https://docs.appsmith.com/setup/kubernetes
expose it to internet using ingress and access from browser using ingress IP
Environment
Production
Version
Cloud

When i describe appsmith internal server pod i can see liveness probe is failing
Warning  Unhealthy  7m18s (x9 over 8m13s)  kubelet            Liveness probe failed: Get "http://<IP_ADDRESS>:8080/api/v1/users/me": dial tcp <IP_ADDRESS>:8080: connect: connection refused

I just want to add that on-premise Docker starts up successfully, but we also are getting connection refused. We have tried with iptables and without iptables, neither are successful.
Server is headless Ubuntu 21.10, so I cannot test via localhost. Telnet connection to all ports 80, 443, 9001 answer. Only in the browser do we see connection refused.

Hey @kpchandr, it sounds like your backend service isn't running. Is it possible to get the logs from the backend pod to see why it's failing to start?

Hey @un-fuf-a-doo, may I ask if you are also running on Kubernetes? If not, then I think you are facing a different issue. Let's move to another issue to investigate the problem. If you are indeed also running Kubernetes, can you share the logs from your backend pod to see why it might be having trouble working right?

No mine is a Docker issue, but it is the exact same.  We fixed our issue by running AppSmith on a higher port number, above 1024 and it works.  We don't know why it won't run on port 80, we have no other services using it.

Closing this and adding allowed ports to our docs


The first steps towards WASM module integration

Hello all! This is a grafting of some of the WASM module loader into mosaic!
There is a lot still to do, but this is the first step!
From here, I'll be adding

[ ] A way to load "tiles" from a layout file
[ ] A way to actually render a plugin to a pane
[ ] Working on parsing input into a struct usable by the plugin system

Also, it's a bit silly to have put those tasks here, check out #74 for an actual tracking issue!


Config template updates

Few fixes of config template:

Fix skip_samples_stages option formatting
slack section to use token secrets
Comment out realign_from_cram_version in the template
Fix elasticsearch section
Use sm-api and driver images related to cpg-common (TODO to self: make sure we deploy them automatically`)
Add liftover_38_to_37 reference

LGTM


Set a custom hostname

Hi, I would like to reach my service using a custom name -that it is not the machine hostname- by http://mycustomname.local
I tryied to create JmDNS with a string:
JmDNS.create("mycustomname");
but it use that name only for instance name ad not as hostname while publishing the service.
Maybe I can rewrite the HostInfo.newHostInfo() method to force a custom "name", but is there any other better solution?
Thanks

Sorry I was working with an old relese, now that feature is working.


[Question] Gradle, Scope & Kotlin

Hi,
I did an audit for a project using Gradle and Kotlin.
The scan step (with scanCode) takes a huge time for some dependencies not in cache.
Some of theses dependencies looks like internal compiler deps, example : Maven:org.jetbrains.kotlin:kotlin-daemon-embeddable:1.5.10 or Maven:org.jetbrains.kotlin:kotlin-scripting-compiler-embeddable:1.5.10 and are defined in specific scope like kotlinCompilerClasspath.
I don't have this kind of dependency with other projects using Maven and Kotlin.
My question is: can we consider that scopes in Kotlin* (kotlinCompilerClasspath, kotlinCompilerPluginClasspath et kotlinKlibCommonizerClasspath) to be excluded? If so, maybe they should be added in the configuration examples ?
Regards

@fb33 Yes, we commonly exclude some of the scopes you mentioned for Gradle project see for example https://github.com/oss-review-toolkit/ort/issues/4294, this file is part of ORT's helper CLI.
You can generate the scope excludes in an .ort.yml using the helper CLI by running the following command:
[ort_home]/helper-cli/build/install/orth/bin/orth repository-configuration generate-scope-excludes \
    --ort-file [analyzer-result.json or scan-result.json file] \
    --repository-configuration-file [.ort.yml file]

Actually, my recommended to speed up the process for such "basic" framework / SDK / compiler type of dependencies is to create a curation that sets both the concluded license and author for these, and enable the scanner's skipConcluded configuration setting. That way, such dependencies won't be scanned or downloaded at all, but will still be attributed for.


rPackages.haven: fix installation

Motivation for this change
Installation of rPackages.haven fails using the current master branch of NixOS/nixpkgs (18.03-beta-14880-ge65bdb91997). This causes installation of rPackages.tidyverse to fail as well.
The cause of the error is the missing buildInput pkgs.zlib.dev.
Steps to reproduce
nix-build -E 'with import <nixpkgs> {}; rWrapper.override { packages = [rPackages.haven]; }'

Resulting in (partial output):
...

readstat/spss/readstat_zsav_write.c:3:10: fatal error: zlib.h: No such file or directory
 #include <zlib.h>
          ^~~~~~~~
compilation terminated.
make: *** [/nix/store/38s6jybgbpxprys4pbgyc83f1zkfl8sj-R-3.5.1/lib/R/etc/Makeconf:159: readstat/spss/readstat_zsav_write.o] Error 1
ERROR: compilation failed for package 'haven'
* removing '/nix/store/8gb8wdk33jsjj78xlcyw6cj1yp7dhj51-r-haven-1.1.2/library/haven'
builder for '/nix/store/4zhk033hcfyih4kk1hiv9fr96f5a0ahy-r-haven-1.1.2.drv' failed with exit code 1
cannot build derivation '/nix/store/viz2ikwnqc4p3vj59f1pjgadiwmal0ql-R-3.5.1-wrapper.drv': 1 dependencies couldn't be built
error: build of '/nix/store/viz2ikwnqc4p3vj59f1pjgadiwmal0ql-R-3.5.1-wrapper.drv' failed

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build rPackages.haven

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: rPackages.haven
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: rPackages.haven
Partial log (click to expand)
*** installing help indices
*** copying figures
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (haven)
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/x7vijyknw29myk1hbjmy6fb71807a3f5-r-haven-1.1.2
/nix/store/x7vijyknw29myk1hbjmy6fb71807a3f5-r-haven-1.1.2

Success on x86_64-linux (full log)
Attempted: rPackages.haven
Partial log (click to expand)
** installing vignettes
** testing if installed package can be loaded
* DONE (haven)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2
shrinking /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2/library/haven/libs/haven.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2
checking for references to /build in /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2...
/nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2


Click to Open Editor Feature of Error Overlay Documentation

Can you reproduce the problem with latest npm?
yes
Description
The Feature 'click on the error overlay to open in editor' expects an environment Variable called REACT_EDITOR (https://github.com/facebookincubator/create-react-app/pull/2141/files#diff-e891084243d9d79cbaff6e11eab1a4fdR82). However the documentation states, that any environment variable not starting with REACT_APP_* will get blocked.
Expected behavior
When writing REACT_EDITOR=wstorm (etc) into a .env.local File I expect the click to open editor Feature to work.
Actual behavior
The Feature does not work. When using console.log(process.env.REACT_EDITOR) in the code it logs undefined.
Environment
Run these commands in the project folder and fill in their results:

npm ls react-scripts (if you haven’t ejected): 1.0.7
node -v: 7.10.0
npm -v: 4.6.1

Then, specify:

Operating system: Windows 10
Browser and version: Chrome 58

Reproducible Demo
https://github.com/wirmar/cra-error-overlay-issue
things to note in demo:
.evn.local file
console log
Other
This probably also blocks automatic detection of used Editor on windows via env vars EDITOR and VISUAL.

It's not blocked—the environment variable is being taken into account. It's just not available to the front end code (because there's need for it). The development server will still read it.
If there are any issues with opening the process, you should see an error in your terminal after clicking. Do you see anything there?

Thanks for the reply. On further investigation it seems that the click to open Feature is only available on some specific errors (runtime react errors) and not on build errors like I assumed at first. Is this intentional?
But I still don't know how to make it work with WebStorm (on windows). It isn't detected automatically and REACT_EDITOR=wstorm also doesn't work. Maybe some documentation of this Feature would be helpful (I could try to do that if I knew how to make the Feature work).

It doesn't currently work for build errors although we'd like to make it work in the future.
For runtime errors it should work but I haven't tested with WebStorm specifically. Again, do you see any error message in the Terminal after you click?

Yeah sorry I just edited my answer after realising I didn't answer your question.

Does running wstorm directly from the terminal work?

No I just naively plucked that from here: https://github.com/facebookincubator/create-react-app/pull/2141/files#diff-e891084243d9d79cbaff6e11eab1a4fdR54
I tried to use REACT_EDITOR=C:\Program Files (x86)\JetBrains\WebStorm 2016.2.2\bin\webstorm64  but the space in the path cuts off the env var.
After I added the path to webstorm to the system PATH variable and just used REACT_EDITOR=webstorm64 it opens the correct File in the editor, but not the correct line.
Is there interest in documenting the neccesary configuration for this editor integration?

Is there interest in documenting the neccesary configuration for this editor integration?

I think it would make sense if it was more comprehensive (e.g. figure out what's missing for every popular editor), not just focused on WebStorm.

it opens the correct File in the editor, but not the correct line.

Perhaps you could look into its console arguments? Maybe we're passing the line in a wrong way.

I tried to use REACT_EDITOR=C:\Program Files (x86)\JetBrains\WebStorm 2016.2.2\bin\webstorm64 but the space in the path cuts off the env var.

You can probably fix it by wrapping path in quotes. Although the approach with PATH seems closer to how I imagined it working.

Fixed by https://github.com/facebookincubator/create-react-app/pull/2414.

I think it would make sense if it was more comprehensive (e.g. figure out what's missing for every popular editor), not just focused on WebStorm.

Maybe something that mentions the Feature and having to add the editor bin Folder to PATH and the executable name to the .env.local File? However I am not sure how it would work on mac/linux.
Would that documentation be in the README or in the console output from #2150? Also should it only be added after full support of the Feature on all errors?
If you want I can try to write up a PR.

It's worth adding a section to User Guide and linking to it from the console with a short URL (e.g. goo.gl/...).

Reopened for docs.

Is it possible to hack support for PhpStorm 2017 in<EMAIL_ADDRESS>

Maybe! Check out this file and suggest edits:
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/launchEditor.js

Fixed via https://github.com/facebookincubator/create-react-app/issues/2445.
For more editor support, please help in https://github.com/facebookincubator/create-react-app/issues/2636!

Fixed in 1.0.8. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8

Thank you! I have also noticed that it might create /usr/local/bin/pstorm shortcut. I'll open an issue about all Jetbrains IDEs this week with suggestion to unify all their products.


follow-up to migrate to m105

@igordmn I'm not sure why, but after the latest changes two problems revealed.
First, we failed to apply on of patches on Windows
Second, we failed to download emscripten tool on linux

We should update the version of the build, add something like "-2".


Renamed imports are not propragated to call site

import { assert as debugAssert } from '@ember/debug';

debugAssert('', condition);
// becomes
Ember.debugAssert('', condition);
// instead of
Ember.assert('', condition);

Can you open up a failing test case in babel-plugin-ember-modules-api-polyfill?

Should be straightforward to fix over there though, thanks for working on it!


chore(starknet_sequencer_node): add remote client to active component config

Stack:

#2570
#2569 ⬅
#2568
#2567
#2566
#2565
#2564

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is


originate via bgapi is waiting for the answer/busy event and not returning the job-id

Hi!
Just noticed that using bgapi to create an originate is not as expected. It should return the job-id for the task and instead it wait for the call answer/reject event and then returns the call-uuid.

PRs welcome!


BUG

when ejectCooldown is 1 you cant throw virus fast.
The points pierce the virus

@RelTakeover You can use decimal numbers.

And what does that have to do with my problem?

use 0.5 or 0.9 or anything else!

@RelTakeover It works fine for me, the cooldown does not affect the way viruses eat ejected mass or how viruses split. Make sure you are using the latest GameServer.js

Increase virusMaxAmount to 1e999.

yes @Megabyte918  Ejected mass goes through viruses when the max amount is reached, and that happens very quickly when having ejectCooldown and virusMaxSize set to 1 and using the eject macro.


Fasten MaintainTimer connecting test

1.9x faster

3 days ago in 7 min 54 sec
https://ci.appveyor.com/project/typewriter/epsp-peer-cs/builds/42613324

8 minutes ago in 4 min 11 sec
https://ci.appveyor.com/project/typewriter/epsp-peer-cs/builds/42642224


Fix not-working cupsSNMPSupplies and cupsIPPSupplies settings via lpa…

…dmin
Connected to issue #5609

Looks about right, will need to merge by hand however...

Oh, I missed the indentation - I hope I corrected it now, please correct me if I'm wrong.

Indentation looks fine, I just can't merge to multiple Git branches via pull requests. No biggy, this is a small change...

Oh, and there were two other places where we needed to set ppdchanged to 1...
[master 9539c5306] Fix lpadmin with cupsIPPSupplies and cupsSNMPSupplies (Issue #5610)
[branch-2.2 c50773934] Fix lpadmin with cupsIPPSupplies and cupsSNMPSupplies (Issue #5610)

Indentation looks fine, I just can't merge to multiple Git branches via pull requests. No biggy, this is a small change...

Can I do anything about it in the future?

Oh, and there were two other places where we needed to set ppdchanged to 1...

D'oh, I missed those two, thank you for checking!

[master 9539c53] Fix lpadmin with cupsIPPSupplies and cupsSNMPSupplies (Issue #5610)
[branch-2.2 c50773934] Fix lpadmin with cupsIPPSupplies and cupsSNMPSupplies (Issue #5610)

Thank you for the fix!

@zdohnal Unfortunately, Github is all about merging to master. Until they add support for pull requests against alternate branches I'll just keep doing manual merges...
Most of these fixes are pretty small anythings, so it is no problem - the bulk of the work has already been done! :)


ARROW-2529: [C++] Update mention of clang-format to 5.0 in the docs

Also add docs on how to install on macOS via Homebrew.

Thanks @andrioni !


Magnifying glass icon in top search can be browsed with VoiceOver but says nothing

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.84.1
OS Version: macOS (I'm using 14.1 but not specific to this version)

Note that this issue is specific to Mac VoiceOver. Not a problem on Windows using NVDA or JAWS .
Steps to Reproduce:

Start VoiceOver on macOS via Cmd+F5
Start Visual Studio code
Ctrl+Option+Shift+Up Arrow to move up until "Application" is announced (might take several times depending on starting location)
Ctrl+Option+Shift+Down Arrow to enter the "Application", should announce you are on a toolbar (the one with the left/right arrows and search)
Ctrl+Option+Shift+Down Arrow to enter the toolbar
Navigate forward using VoiceOver cursor until the magnifying glass icon is selected (using Ctrl+Option+Right Arrow)
The element is selectable via VoiceOver, but says nothing (no accessible text)

Expected:
I'd lean towards making this icon aria-hidden. It's already that way with other screen readers and you can't just add an aria-label to it (it would need a role for that to be fully supported).

FYI @meganrogge (looks like you do a lot of a11y work).


Waterskin cannot be dragged and dropped in equipment.

The Waterskin from "dsa5-armory" cannot be dragged and dropped in equipment, it simply does not appear. The one from "dsa5-core" can but lacks details from the Armory.
Steps to reproduce the behavior:

Locate Waterskin (dsa5-armory)  equipment in LIbrary
Drag and drop it your hero's equipment

The waterskin should be added to the hero's equipment list. The waterskin from dsa5-core functions properly.

Foundry Version 9.269
DSA/TDE version 3.4.5

Ok never mind my equipment ticket and the other one. Those can be quickly adjusted in-game. However we must be careful with equipment attributes as not everyone is able to edit items.

Yes, item was dropped in a container. You can cancel this issue.


major version library upgrades

Codecov Report

Merging #1313 into master will increase coverage by 3.12%.
The diff coverage is 85%.

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
+ Coverage   47.16%   50.29%   +3.12%
==========================================
  Files         184      182       -2
  Lines        3763     3601     -162
  Branches      780      763      -17
==========================================
+ Hits         1775     1811      +36
+ Misses       1988     1790     -198

Impacted Files
Coverage Δ

...app/components/datasets/owners/suggested-owners.ts
100% <ø> (ø)
:arrow_up:

wherehows-web/app/router.ts
88.23% <ø> (-2.01%)
:arrow_down:

wherehows-web/app/services/current-user.ts
56.52% <100%> (+0.96%)
:arrow_up:

...ows-web/app/components/datasets/urn-breadcrumbs.ts
100% <100%> (ø)
:arrow_up:

wherehows-web/app/controllers/login.ts
85% <100%> (+6.42%)
:arrow_up:

wherehows-web/app/routes/logout.ts
77.77% <33.33%> (+77.77%)
:arrow_up:

...-web/app/components/notifications/banner-alerts.ts
77.77% <88.88%> (+2.77%)
:arrow_up:

wherehows-web/app/utils/api/authentication.ts
61.53% <0%> (-30.77%)
:arrow_down:

wherehows-web/app/components/dataset-aclaccess.ts
41.66% <0%> (-29.17%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117e527...c0dae61. Read the comment docs.

Coverage remained the same at 27.612% when pulling c0dae610f13bec32381917754704aa802e74dd7f on theseyi:wholesale-upgrades into 117e5273a9deb8e2059f5b4ef7cfc5a045426f13 on linkedin:master.