gitignore: add .DS_Store

macOS creates .DS_Store files all over the place while browsing directories. Let's add it to the list of ignored files.
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

@nhorman @t8m @mattcaswell @tom-cosgrove-arm @levitte @paulidale @tmshort @bernd-edlinger

This pull request is ready to merge

Merged to master, 3.3, 3.2, 3.1, and 3.0. Thank you for the contribution!


feat(devops): Add cycles ledger and depositor

Motivation
Oisy will have to start paying cycles for signing.  To support that in tests, we will need the cycles ledger and cycles depositor (used in test environments to add cycles to the cycle ledger).
Changes

Add the cycles_ledger and cycles_depositor to dfx.json.

Tests
Existing tests should suffice.
Locally, npm run deploy works.

Please update main deploy.sh script if those need to be spinned to develop locally.


[misc] Remove extraneous comma

📌 Checklist before creating the PR

[x] I have created an issue for this PR for traceability
[x] The title follows the standard format: [doc/gemini/tensor/...]: A concise description
[x] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number
N/A
📝 What does this PR do?
Prevents TypeError: category must be a Warning subclass, not 'str'.
💥 Checklist before requesting a review

[ ] I have linked my PR to an issue (instruction)
[x] My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
[x] I have performed a self-review of my code
[x] I have added thorough tests.
[x] I have added docstrings for all the functions/methods I implemented

⭐ Do you enjoy contributing to Colossal-AI?

[x] 🌝 Yes, I do.
[ ] 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

cc @FrankLeeeee

LGTM.

Hi @yasyf  Thank you very much for your contribution!


returning data from stream in flutter

doesn't work listening to a specific column.
My Table;
database columns(category5) = (category5_id,name,fk_category4_id)
My code is;
db.supabase
.from('category5:fk_category4_id=eq.${selectCategory5!.keys.first}')
.stream(['category5_id,name']).execute();

return data => all columns.

@yutech23
Thanks for opening this issue.
Are you unable to receive all insert, update, and delete events, or is it only delete events?
There was an issue on our realtime server where the delete events stopped coming through when listening with eq filter, which is resolved now.

@dshukertjr
In my case
The stream return for the first time, After initializing str again
Stream failed to load

We need to able to cancel stream with StreamSubscription
And
Initialize again
Like
If user not have internet, an error throws form stream,
Then
When user get internet and press refresh we shall able to initialize stream again

@iampopal That sounds like a separate issue, so would you want to open a new issue and discuss it there? It would be helpful if you could follow the issue template and include some reproducible code as well!

@yutech23 The issue with not being able to receive delete events has been resolved, so I would like to close this one assuming you were facing the same issue, but if you are still experiencing the issue that you open this thread for, please feel free to reopen it at any time!

@yutech23 The issue with not being able to receive delete events has been resolved, so I would like to close this one assuming you were facing the same issue, but if you are still experiencing the issue that you open this thread for, please feel free to reopen it at any time!

Hi  Sorry for late reply, this problem continues.

return value:

@yutech23 Thanks for notifying that it is still not working.
May I ask how you are listening to your stream? Also, you have a provided an screenshot of a log, but how are you logging the data? If you could provide the code for it as well, it would be amazing!

Of course.
Listining

like this Data input;

@yutech23
Thanks for providing the code. Generally, it would be more awesome if you could copy and paste the code rather than taking a screenshot of it!
I want to make sure that I understand the issue here, but in the title of this issue, you wrote that relatime does not work when listening to a specific column, but it looks like you are not listening to a specific column in this example. Is the issue that you are not able to receive any realtime data at all?
If so, there are few things that come to my mind here.

Persist the stream data as state. More details here. In your case, I would just make the stream a property of the bloc instead of returning it in a method.
Make sure you have realtime turned on. You can turn it on by managing replication under database menu of your Supabase dashboard.

Hi,
I made an example similar to this problem.
My database column names are ('category1_id','name')
I want to stream only 'name' column.
My Code;
ElevatedButton(
onPressed:() async{
var res =  db.supabase.from('category1').stream(['name']).execute();
res.listen((event) {
print(event);
});
                  },
                  child: Text('Gönder'))

Returning Data;
[{category1_id: 15, name: Unisex}, {category1_id: 23, name: Kadın}, {category1_id: 25, name: Erkek}]
Note: Returned All Table data.
Thank you for all of replies.

@yutech23 I don't think you can stream specific columns. Is name your primary key column?

@yutech23
Yup, with stream(), there is currently no way to limit which columns to retrieve. It can only retrieve all the columns in a table. The List you pass inside the .stream() is list of primary keys for the table.
@Vinzent03
I wonder if we can make the API better by making the primary keys named parameters like this:
supabase.from('category1').stream(primaryKeys: ['id'])

This might open up the api to allow only retrieving certain columns like this:
supabase.from('category1').stream(primaryKeys: ['id'], columns: ['name', 'category'])

I think that makes it more clear. Do you want to support the column select on client or just prepare for server select with named parameters. But we should change the name, because there is only one primary key, but with multiple columns.

@Vinzent03

Do you want to support the column select on client or just prepare for server select with named parameters.

Sorry, didn't catch this one. What do you mean by "server select"?

But we should change the name, because there is only one primary key, but with multiple columns.

Oh yeah, makes sense!

@dshukertjr I mean whether you want to prepare for a future feature of the realtime server of selecting columns, because that's currently not possible, right? Or you want to select columns in the local dart code? So basically where the column filtering happens, on realtime server or local.

@Vinzent03
Thanks for the clarification! I was thinking about this over the weekend, and was wondering if we really need to add the ability to restrict which columns to select. At least since this would be a new feature, we don't have to implement it right now. Let's wait on this one for now, and just go with changing the syntax around primaryKey for now!

@dshukertjr lets include the stream parameter change in supabase-dart 1.0.0, right?

I don't think you can stream specific columns

'name' is not primary key column.
category1_id is primary key.

@yutech23
Yup, in your case, you need to get the stream like this:
db.supabase.from('category1').stream(['category1_id']).execute();

Note that there is no way to limit which columns to retrieve at the moment, and .stream() will return all the columns for the table.

@yutech23  Is your original issue solved, so we can close this? Selecting columns in stream should be discussed in another issue.

@yutech23 Is your original issue solved, so we can close this? Selecting columns in stream should be discussed in another issue.

Of course you could close.


[resotocore][feat] clearer Jira custom command parameter names

Description
Introduces clearer Jira custom command parameter names
To-Dos

[x] Add test coverage for new or updated functionality
[x] Lint and test with tox
[x] Document new or updated functionality (someengineering/resoto.com#380)

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Also want to remove chunk 25, as discussed on Discord.


CloudConfigurationManager GetSetting using web.config even when in Azure

Are there any known issues with Microsoft Azure Configuration Manager 3.1.0 ignoring the cscfg when in Azure? Our Cloud Service is getting its value from the web.config even when it's running in azure and not the value listed in the cscfg.

Is 3.1.0 incompatible with ServiceRuntime 2.4??
More information on issue - http://stackoverflow.com/questions/29703622/cloudconfigurationmanager-getsetting-not-getting-value-from-cscfg-when-running

It seems the role environment itself is throwing an exception, but Configuration Manager is just falling back silently to the web.config rather highlighting that there has been an exception in role.


Outdated EIP-1559 references

Description
The troubleshooting docs currently states EIP-1559 transactions are not yet supported, when this article announced support for it in August 2022, and also indicated here.
Unfortunately, I think it's the first result that pops up when googling about this. I can send a PR but I want to confirm first if the expected approach would be pointing out that it is an old known issue, and now EIP1559 transactions are supported, or just remove it directly.

Thanks for raising this. The whole page needs updating. We will do it asap.


AQCU-858: Only show one max/min per day

Coverage increased (+0.07%) to 88.889% when pulling 347175a9730eb12002e7ca627e1f3e6ffa8407f3 on zmoore-usgs:feature/no-duplicate-min-max into e478d822fde4f80f2b25f8f4498385ebcc7587d9 on USGS-R:master.

You should add a test to make sure this is working as expect

Coverage increased (+0.07%) to 88.889% when pulling 6f3a97472d658521d7499012c953a839057f14f5 on zmoore-usgs:feature/no-duplicate-min-max into e478d822fde4f80f2b25f8f4498385ebcc7587d9 on USGS-R:master.

Coverage increased (+0.07%) to 88.889% when pulling 6b06a6b6243f59dfd8f9d653a83886de5c7c3433 on zmoore-usgs:feature/no-duplicate-min-max into e478d822fde4f80f2b25f8f4498385ebcc7587d9 on USGS-R:master.


[#2398] Remove marquand-phref

closes #2398

The location has been removed from https://bibdata-staging.princeton.edu/locations/holding_locations


support Nix

This PR prepares sns-testing to support Nix:

rename sns-cli to sns
replace bin/dfx by dfx or which dfx, analogously for ic-admin
replace /bin/bash by /usr/bin/env bash
drop ic-regedit dependency inside nix-shell
do not clone II and nns-dapp repositories

Notes while trying out the Nix solution:

Entering nix-shell for the first time takes a lot of time (ca. 30 min). This should be indicated in the instructions.
The section for Docker should precede the (more experimental) Nix instructions; there should be a forward reference to the Nix instructions for Apple Silicon users.
The anchor to #apple-silicon seems broken. The local hyperlink doesn't work.

There's an issue while running the following step inside nix-shell:
[nix-shell:~/sns-testing]$ ./setup_locally.sh
Using identity: "default".
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  308k  100  308k    0     0  1966k      0 --:--:-- --:--:-- --:--:-- 1966k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  162k  100  162k    0     0  1301k      0 --:--:-- --:--:-- --:--:-- 1291k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  649k  100  649k    0     0  16.2M      0 --:--:-- --:--:-- --:--:-- 16.2M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  659k  100  659k    0     0  5149k      0 --:--:-- --:--:-- --:--:-- 5190k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  438k  100  438k    0     0  2848k      0 --:--:-- --:--:-- --:--:-- 2866k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7154  100  7154    0     0  89425      0 --:--:-- --:--:-- --:--:-- 89425
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  512k  100  512k    0     0  4459k      0 --:--:-- --:--:-- --:--:-- 4459k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 83840  100 83840    0     0  3149k      0 --:--:-- --:--:-- --:--:-- 3149k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7154  100  7154    0     0  65633      0 --:--:-- --:--:-- --:--:-- 65633
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  808k  100  808k    0     0  24.6M      0 --:--:-- --:--:-- --:--:-- 23.9M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  255k  100  255k    0     0   9.9M      0 --:--:-- --:--:-- --:--:--  9.9M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  428k  100  428k    0     0  2506k      0 --:--:-- --:--:-- --:--:-- 2506k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  275k  100  275k    0     0  2042k      0 --:--:-- --:--:-- --:--:-- 2042k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  583k  100  583k    0     0  3762k      0 --:--:-- --:--:-- --:--:-- 3762k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  391k  100  391k    0     0  3266k      0 --:--:-- --:--:-- --:--:-- 3266k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  527k  100  527k    0     0  3178k      0 --:--:-- --:--:-- --:--:-- 3178k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  209k  100  209k    0     0  1509k      0 --:--:-- --:--:-- --:--:-- 1498k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  211k  100  211k    0     0  1471k      0 --:--:-- --:--:-- --:--:-- 1471k
Importing all canisters from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/dfx.json
Importing canister 'cycles-minting' as 'nns-cycles-minting'
Importing /home/arshavir/sns-testing/candid/nns-cycles-minting.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/cmc/cmc.did
cycles-minting canister id on network 'ic' is rkp4c-7iaaa-aaaaa-aaaca-cai
Importing canister 'genesis-token' as 'nns-genesis-token'
Importing /home/arshavir/sns-testing/candid/nns-genesis-token.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/gtc/canister/gtc.did
genesis-token canister id on network 'ic' is renrk-eyaaa-aaaaa-aaada-cai
Importing canister 'governance' as 'nns-governance'
Importing /home/arshavir/sns-testing/candid/nns-governance.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/governance/canister/governance.did
governance canister id on network 'ic' is rrkah-fqaaa-aaaaa-aaaaq-cai
Importing canister 'ledger' as 'nns-ledger'
Importing /home/arshavir/sns-testing/candid/nns-ledger.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/rosetta-api/icp_ledger/ledger.did
ledger canister id on network 'ic' is ryjl3-tyaaa-aaaaa-aaaba-cai
Importing canister 'lifeline' as 'nns-lifeline'
Importing /home/arshavir/sns-testing/candid/nns-lifeline.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/handlers/lifeline/lifeline.did
lifeline canister id on network 'ic' is rno2w-sqaaa-aaaaa-aaacq-cai
Importing canister 'registry' as 'nns-registry'
Importing /home/arshavir/sns-testing/candid/nns-registry.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/registry/canister/canister/registry.did
registry canister id on network 'ic' is rwlgt-iiaaa-aaaaa-aaaaa-cai
Importing canister 'root' as 'nns-root'
Importing /home/arshavir/sns-testing/candid/nns-root.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/handlers/root/impl/canister/root.did
root canister id on network 'ic' is r7inp-6aaaa-aaaaa-aaabq-cai
Importing canister 'sns-wasm' as 'nns-sns-wasm'
Importing /home/arshavir/sns-testing/candid/nns-sns-wasm.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/nns/sns-wasm/canister/sns-wasm.did
sns-wasm canister id on network 'ic' is qaa6y-5yaaa-aaaaa-aaafa-cai
nns-registry canister id on network 'local' is rwlgt-iiaaa-aaaaa-aaaaa-cai
nns-governance canister id on network 'local' is rrkah-fqaaa-aaaaa-aaaaq-cai
nns-ledger canister id on network 'local' is ryjl3-tyaaa-aaaaa-aaaba-cai
nns-root canister id on network 'local' is r7inp-6aaaa-aaaaa-aaabq-cai
nns-cycles-minting canister id on network 'local' is rkp4c-7iaaa-aaaaa-aaaca-cai
nns-lifeline canister id on network 'local' is rno2w-sqaaa-aaaaa-aaacq-cai
nns-genesis-token canister id on network 'local' is renrk-eyaaa-aaaaa-aaada-cai
nns-identity has no local canister ID.
nns-ui has no local canister ID.
nns-sns-wasm canister id on network 'local' is qaa6y-5yaaa-aaaaa-aaafa-cai
nns-ic-ckbtc-minter has no local canister ID.
Importing all canisters from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/sns/cli/dfx.json
Importing canister 'sns_governance' as 'sns_governance'
Importing /home/arshavir/sns-testing/candid/sns_governance.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/sns/governance/canister/governance.did
sns_governance has no canister id for network 'ic'
Importing canister 'sns_index' as 'sns_index'
Importing /home/arshavir/sns-testing/candid/sns_index.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/rosetta-api/icrc1/index/index.did
sns_index has no canister id for network 'ic'
Importing canister 'sns_ledger' as 'sns_ledger'
Importing /home/arshavir/sns-testing/candid/sns_ledger.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/rosetta-api/icrc1/ledger/ledger.did
sns_ledger has no canister id for network 'ic'
Importing canister 'sns_root' as 'sns_root'
Importing /home/arshavir/sns-testing/candid/sns_root.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/sns/root/canister/root.did
sns_root has no canister id for network 'ic'
Importing canister 'sns_swap' as 'sns_swap'
Importing /home/arshavir/sns-testing/candid/sns_swap.did from https://raw.githubusercontent.com/dfinity/ic/e4a9c0aa4ef24f7ee5bb9d27ce930551a7c5e24d/rs/sns/swap/canister/swap.did
sns_swap has no canister id for network 'ic'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19528  100 19528    0     0   515k      0 --:--:-- --:--:-- --:--:--  515k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15498  100 15498    0     0   504k      0 --:--:-- --:--:-- --:--:--  504k
[ic-nns-init] The content of the registry will be initialized with an empty content. This is most likely not what you want. Use --initial-registry or --registry-local-store-dir to specify initial content.
[ic-nns-init] Initializing neurons from CSV file: "initial_neurons.csv"
[ic-nns-init] Initializing with test ledger account: 3ea2985b64e3af5dba6f6d9e552f53f8c55a54248a90a6a02aabf33e946bf23c
[ic-nns-init] Initializing with test ledger account: 5b315d2f6702cb3a27d826161797d7b2c2e131cd312aece51d4d5574d1247087
[ic-nns-init] Initializing with test ledger account: 2b8fbde99de881f695f279d2a892b1137bfe81a42d7694e064b1be58701e1138
[ic-nns-init] Initialized governance.
thread 'main' panicked at 'Failed to create canister at specific id.: "unexpected result: \"rejected\" - Some(\"Canister rwlgt-iiaaa-aaaaa-aaaaa-cai is already installed\")"', rs/rust_canisters/canister_test/src/canister.rs:385:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Could you please share what which dfx prints inside the nix-shell. I suspect that you still have dfx 0.13.1 in your bin folder and this take precedence over dfx 0.14.0 pinned by Nix. On the other hand, we cannot remove the bin folder from the PATH in general because it's still required inside Docker. Moreover, the instructions assume that you clone the repository so it sounds weird to say that you make sure the bin folder is empty.

Notes while trying out the Nix solution:

Entering nix-shell for the first time takes a lot of time (ca. 30 min). This should be indicated in the instructions.
The section for Docker should precede the (more experimental) Nix instructions; there should be a forward reference to the Nix instructions for Apple Silicon users.
The anchor to #apple-silicon seems broken. The local hyperlink doesn't work.

Fixed.

Could you please share what which dfx prints inside the nix-shell. I suspect that you still have dfx 0.13.1 in your bin folder and this take precedence over dfx 0.14.0 pinned by Nix. On the other hand, we cannot remove the bin folder from the PATH in general because it's still required inside Docker. Moreover, the instructions assume that you clone the repository so it sounds weird to say that you make sure the bin folder is empty.

If I enter a nix-shell, then I get
[nix-shell:~/sns-testing]$ which $DFX

[nix-shell:~/sns-testing]$ which dfx
/nix/store/rp6ql01zkjxkrldl36yhgrd0h2aafvs6-dfx-env/bin/dfx

however, when I run source ./constants.sh normal, I get
[nix-shell:~/sns-testing]$ which $DFX
/home/arshavir/sns-testing/bin/dfx

[nix-shell:~/sns-testing]$ which dfx
/home/arshavir/sns-testing/bin/dfx

Could you then please remove all files from the bin folder. Users are not expected to run install.sh when setting up the test env via Nix (and thus users are not expected to have any files in the bin folder when using Nix).

Now trying on apple silicon.
Apple-m1 $ nix-shell
trace: warning: replaceChars is a deprecated alias of replaceStrings, replace usages of it with replaceStrings.
...
copying path '/nix/store/bsssjf1g2dip82is7n9zqbdhirv3f1dj-autoconf-archive-2022.02.11' from 'https://cache.nixos.org'...
error: builder for '/nix/store/27csbm5gnl544nnql2yjyxw68jpwjhnx-nix-shell.drv' failed with exit code 1;
       last 8 log lines:
       > WARNING
       >
       > ****************************************************************************************
       >   It appears there is no prebuilt binaries available for system aarch64-darwin.
       >   Run nix-shell with `--arg force true` if you want to build it from source.
       >   Note that if this is the first time you build it, it can take about an hour to finish.
       > ****************************************************************************************
       >
       For full logs, run 'nix-store -l /nix/store/27csbm5gnl544nnql2yjyxw68jpwjhnx-nix-shell.drv'.
error: build of '/nix/store/0nwihy9i6vpgjwk2bplblbg2kxc8w3cs-cmake-3.24.3.drv', '/nix/store/17y4rckzjqmacjsjdl60drm0r9bdfyj8-cachix-1.3.3.drv', '/nix/store/27csbm5gnl544nnql2yjyxw68jpwjhnx-nix-shell.drv', '/nix/store/7a3wsmc2yh8iyl6l3fz97iir2p1mqh9c-openssl-3.0.8.drv', '/nix/store/bgk253gy4j78g811hajk3z09iz9i81q1-jq-1.6.drv', '/nix/store/h4q71qq63qazizh3qw03v77bi5jbq9k8-pkg-config-wrapper-0.29.2.drv', '/nix/store/j8ydpr0i4rryq0c348xlxyrg3vk0wcln-bc-1.07.1.drv', '/nix/store/n1cszx9yxfr51g7sf5g0zc807b8hbq2n-subnet-id-0.1.0.drv', '/nix/store/p2hd81jixdqgdr5zd8ci7dyjy8w835gf-killall-shell_cmds-187.drv', '/nix/store/rkvndanrnii7d6mlfmb50fbbmaac4fvm-quill.drv', '/nix/store/wbmrp6bchr8vpwph33kv3i96wvq7qw13-rustup-1.25.2.drv' failed

Running nix-shell --arg force true results in the same error. :-(

We're not gonna support Nix for sns-testing.


Adding database backup and accounts page to migration wizard

Creating this PR because we reverted the previous one.

Pull Request Test Coverage Report for Build 414046133

10 of 129 (7.75%)  changed or added relevant lines in 3 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 41.455%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/localizedConstants.ts
3
4
75.0%

extensions/azurecore/src/extension.ts
0
13
0.0%

extensions/azurecore/src/azureResource/utils.ts
7
112
6.25%

Files with Coverage Reduction
New Missed Lines
%

extensions/azurecore/src/extension.ts
4
0%

extensions/notebook/src/jupyter/serverInstance.ts
4
73.81%

Totals

Change from base Build 413966237:
-0.1%

Covered Lines:
22111

Relevant Lines:
48927

💛  - Coveralls


Any  plan to release a new version?

Hi, is there any plan to release a new version so blake2b-py can support python 3.10 by https://github.com/ethereum/blake2b-py/pull/10 ?

@cburgdorf The current version on PyPI is 0.1.4 : https://pypi.org/project/blake2b-py/
Thats pretty old and a couple of commits are missing: https://github.com/ethereum/blake2b-py/compare/f7dda6ede0b9c006578854f055cefff75acf2ddc...master
Would you mind to create a new release on PyPI?

@kclowes I noticed you are already an admin for this project. Would you mind taking over the maintenance? I'm so detached from Python development these days. It looks like #9 would be a good candidate to merge but I think it should be rebased to run against CI first.

@cburgdorf If the project currently has no active maintainer and nobody volunteers from within the project, you might want to consider https://github.com/jazzband

@cburgdorf - can you give me pypi privileges? Then I can get a release out, hopefully early next week.

Sure, thanks a lot Keri!

@cburgdorf - can you give me pypi privileges? Then I can get a release out, hopefully early next week.

Turns out, I don't have managing privileges on pypi either. I can push releases but can not add other maintainers. @davesque Could you add Keri?

I just got Pypi permissions 🎉  will plan to do a release early next week!

@kclowes Is there anything blocking you from making a release? Is there any way you can be supported?

@MT-Cash Thanks for checking :) 0.2.0 is out!


Docker compose v2

#423 Export variables without default value
I am using this fix, and everything seems to work.

@alinalexandru Just tested this locally and it works perfectly. Thanks!

I've been using this change locally for about a week now, but just noticed that the COMPOSER_VERSION variable in .env isn't forwarded to the PHP-FPM yml when it is compiled. I'm not entirely certain where/why that is yet.

Notised that more variables are not forwarded. I'll investigate

Looks like this issue isn't reproducing anymore in the Docker Compose version v2.2.1

It worked perfectly fine with the latest docker-compose version for a few weeks.
I think we can close this PR as the issue was fixed on the docker-compose level

Closing, as the issue was a BC break in an upstream dependency.


Tweet stats broken

Tweet stats appear to be broken, screenshots are attached down below.
Before:

After:

Thanks for reporting this! I accidentally introduced a bug while merging an old pull request of mine, it should be fixed now.


[Bug] Disabled generic tests appear in manifest.nodes

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
When you have a generic test for a model, it remains in the manifest when disabled.  Other node types are only in the disabled dictionary.
Expected Behavior

The generic test is not in in manifest.nodes
The generic test is in the disabled dict

Steps To Reproduce
my_model.sql
select 1 as id, 'orange' as color, false as is_primary_color

schema.yml
models:
  - name: column_removed_model
    columns:
      - name: id
        tests:
          - unique

dbt compile and see the model and the test in manifest.nodes, disabled dictionary is empty
delete my_model.sql
dbt compile and see the test in manifest.nodes but not disabled dictionary
or
dbt compile and see the model and the test in manifest.nodes, disabled dictionary is empty
add the enabled: false config my_model
dbt compile and see the test in manifest.nodes but not disabled dictionary and the model in the disabled dict but not in manifest.nodes

Relevant log output
none

Environment
- dbt: 1.9a1

Which database adapter are you using with dbt?
No response
Additional Context
TODO: Does this also apply to singular tests?
This may require some tests that verify the number of nodes in the results equals a specific number.  This is an unknown that may add some time to the fix.
More context for how it works now:
In compilation.py we specifically check for disabled tests in the "nodes" dictionary. However, when we do "cleanup_disabled" anything that's disabled ought to be moved to the disabled dictionary.

Tests for a disabled model aren't explicitly marked as disabled are they?  We move everything in the "nodes" dictionary that's marked disabled into the "disabled" dictionary as a post-parsing step.


Remove package to add compatibility with vlp_v3.0.6

This package doesn't exist in vlp_v3.0.6 and its presence is unimportant. So I remove it from the image.

This meta-mistysom PR is working on RZG2L with VLP 3.0.0 here: https://github.com/MistySOM/rzg2l/pull/63
And RZV2L with VLP 3.0.6 here: https://github.com/MistySOM/rzv2l/pull/81
It wouldn't pass the yocto build because the pipeline is using the master branch of RZG2L which doesn't include the latest laird submodule.


Fixed a spelling error in Identical validator documentation

Following the "Improvement Kata", making small improvements will significantly impact a project positively over time. In this case it's fixing just a typo.

Thanks, @DragonBe!


Fix typo in compressor method

Hi @anthony-khong,
While exploring the new code I found that the call to nippy/* function was perhaps miss-spelled so this PR just try to fix this.
Thanks

Codecov Report

Merging #251 into develop will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            develop       #251   +/-   ##
===========================================
  Coverage   100.000%   100.000%
===========================================
  Files            34         34
  Lines          2658       2658
===========================================
  Hits           2658       2658

Hi Burin, it is indeed a typo. Thanks for catching it! That script is still a work in progress. Let me change it myself in my next PR!
I’d like to avoid the docs (which is ~180KB) to change so often as to bloat the repo size. I hope that’s okay with you!


feat: index all pages on docsearch

Add all links for docsearch to index, the current approach was not indexing all pages as docsearch was not able to detect all paths related to /.

Is there a reason the reference page is left out?

Is there a reason the reference page is left out?

Thanks for the review, I didn't notice that all links where different. I include other ones that were also missing.


Purpose of disable_auto_retries

@hyder , Hi Ali, what's the purpose of disable_auto_retries ? I don't see it used anywhere in the code.

@briangustafson commented that "disable_auto_retries should always be false. (This variable made sense in some cases a very long time ago before the OCI provider improved its retry logic.) "
As a result, you'll see that in https://github.com/oracle-terraform-modules/terraform-oci-base/blob/master/docs/quickstart.adoc#instructions (Step 5) when the provider is created, this is hardcoded to false.
You'll also see that the variable has been removed from https://github.com/oracle-terraform-modules/terraform-oci-base/blob/master/variables.tf
We just need to remove it from the terraform options doc.

Makes sense! I guess we should remove disable_auto_retries from terraform.tfvars.example as well then. I'll submit a PR.

$ grep -r 'disable_auto_retries' .
./terraform.tfvars:  disable_auto_retries = false
./docs/terraformoptions.adoc:|disable_auto_retries
./docs/quickstart.adoc:  disable_auto_retries = false
./examples/gitlab/README.md:  disable_auto_retries = false
Binary file ./.terraform/plugins/linux_amd64/terraform-provider-oci_v3.47.0_x4 matches
./provider.tf:  disable_auto_retries = false
./terraform.tfvars.example:  disable_auto_retries = false

fixed in #10


[4.x] Mark navigation classes and nodes as experimental

The navigation team has some large changes planned for navigation in the 4.x time-frame, so marking these nodes as experimental to give users a heads up that the API may change in breaking ways.
I went ahead and marked all of the navigation related classes, but let me know if I should pare that back.

Thanks!


added createdDate and modifiedDate to Wishlist

modified
service/models/wishlist.py
tests/test_wishlist.py
tests/factories.py

Made a mistake of wrong file name. Corrected now


Tables in Word don't convert to PDF

(untested so no sample, but users noted this)

This should be fixed in v0.0.3 on dev. While the conversion is just from changing to Open Office (see #4), I also realized and fixed an issue that comments in the table were not being captured correctly. (Just happened to do this in my made up test case.) It's possible that the anchors are not exactly the same as Hypothesis would create - if there are issues, getting a sample doc and Hypothesis created annotation would be helpful in fixing it. (The big question is whether Hypothesis inserts any chars in the stream to represent the table elements or just does what I did and look for the embedded paragraph elements and just treat them as though they were paragraph elements in the doc itself.

Fix confirmed


Complex multi-model benchmarks

Comment from MLPerf Inference v0.7 wishlist document:
Request for multiple dependent and independent inferences per query (eg. image-to-text-to-voice, voice-to-text-to-translate-to-voice).

No one showed interest in a proposal so we will close this issue for now and re-open if needed.


Restore frontend + server example potential bug?

I'm working on adding "restore" functionality to a Laravel project, but ran into an issue where filepond always displays "upload complete" for chunked files.
As you can see from the below code, I return the file and header as expected via the filepond documentation.
public function restore(Request $request, string $id)
{
    $disk = config('filepond.temporary_files_disk', 'local');
    $path = config('filepond.temporary_files_path', 'filepond').DIRECTORY_SEPARATOR.$id;

    $mime = Storage::disk($disk)->mimeType($path);
    $file = Storage::disk($disk)->get($path);

    return Response::make($file, 200, [
        'Content-Type' => $mime,
        'Content-Disposition' => 'inline; filename="'.$id.'"',
    ]);
}

Routes (overwritten):
// Filepond
Route::prefix('filepond')->group(function () {
    Route::patch('/', [FilepondController::class, 'chunk'])->name('filepond.chunk');
    Route::post('/process/{video}', [FilepondController::class, 'upload'])->name('filepond.upload');
    Route::delete('/process/{video}', [FilepondController::class, 'delete'])->name('filepond.delete');
    Route::get('/restore/{id}', [FilepondController::class, 'restore'])->name('filepond.restore');
});

Frontend JS:
FilePond.setOptions({
    chunkUploads: true,
    server: {
        url: '/filepond',
        process: '/process/{{ $video->id }}',
        revert: '/process/{{ $video->id }}',
        restore: '/restore/',
        headers: {
            'X-CSRF-TOKEN': '{{ csrf_token() }}',
        }
    },
});

const inputElement = document.querySelector('.filepond');
const pond = FilePond.create(inputElement, {
    files: [
        {
            source: '9K3Z9t0DSEU4tfFI', // example chunk id
            options: {
                type: 'limbo',
            },
        },
    ],
});

Visiting the page with filepond integrated then displays:

But I'd expect it to continue the upload which was interrupted.
Any suggestions would be greatly appreciated.

Which version of FilePond?

filepond version is 4.28.1

Correct, what Trev said.

@AndreasElia Why close?

@rikschennink It turns out "restore" doesn't work how I thought it did, so in turn, this isn't a bug as far as I'm aware?
From my understanding, restore only restores already uploaded files. I assumed when creating this that restore would restore a partially uploaded file in order for the user to continue the upload (e.g. if the upload got to 70% and the user refreshed, it would restore the file for the user to continue the final 30%).
Feel free to correct me if I'm wrong.

@AndreasElia you're correct. I believe it currently doesn't do that.


415

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/465/
Test PASSed.


Congrats 🎉

Just wanted to say hi! It's really awesome to see this codebase out in the public, big congrats!
I still see some of my mistakes in it -- I won't tell you where, to make it interesting xD
Hope everything's going well with the team. Hoping to see the Java agent out in public as well!
Let the best agent and product win ;)

Thanks Ivo! Best of luck with everything.


Improve validation when creating instance

When creating a new community instance, the validation fails if a folder exists in /Communities that is not in a valid structure, even if it's nothing to do with the instance being created.
Repro Steps

Create an empty folder in /Communities called demo.local
Try and create an instance e.g. Get-TelligentVersion 9 | Install-TelligentInstance example.local

Ended up fixing this issue and a performance issue that were reporting in the same week with a change to stop the search for 'Web' folders being recursive.


feat: initial eMRTD reading messages

Initial import of eMRTD reader messages. For the moment, no parsing is being done, as it is simply intended to help on Hologram app testing.

The error in the validation occurs because the tsconfig.build.json file requires running yarn install in the examples/chatbot project as well.
$ nest build
examples/chatbot/index.ts:[6](https://github.com/2060-io/2060-service-agent/pull/27/checks?notification_referrer_id=NT_kwDOAqSoELQxMjc5NzY3NzY2MTo0NDM0NTM2MA#step:7:7):24 - error TS2307: Cannot find module 'tslog' or its corresponding type declarations.


Update libgit2 submodule

Includes a fix for a potential DoS/memory corruption and adds checks for
configuration file in ProgramData.

Thanks!  3828d7afdd08b595584048e8e4dab6ddd4506ed1 doesn't appear to be a valid commit, though?

It is valid, but it's actually rolling back to the v0.27 series and I'm not sure how it got there. I meant to update to HEAD. I'll push up a correction.

Unfortunately it looks like there hasn't been an update in a while so we still need to adjust to some API changes.

Thanks!


https://github.com/phusion/baseimage-docker/issues/391

Argh looks like it broke the build: https://travis-ci.org/phusion/baseimage-docker/builds/221640311

Looks like something hinky is going on. I will have to check it out tomorrow. I don't think your change broke the build. https://github.com/phusion/baseimage-docker/pull/393

This was my first pull request, so I might have messed things up. As I said in the original thread, I fixed it locally and tested, all was good. I merged the edits in my local image per these instructions: https://gist.github.com/glamp/74188691c91d52770807. And the Python code is clearly wrong :)

Yeah, as I said, I don't believe you broke it. I reverted your changes and the build is still failing. Something weird is going on and I will check it out tomorrow. Your contribution is greatly appreciated, thank you!

My pleasure and thanks for the quick responses!


4 issues in Dockerfile (--no-install-recommends not used, RUN not combined, running as root, no commit for tor lib)

Add --no-install-recommends for apt-get install commands:

adding --no-install-recommends for apt-get install commands will probably/may reduce the amount of packages installed (then the package list may need to be increased with some required dependencies for the usage which are part of the recommended list, like for example ca-certificates package)
https://github.com/ACINQ/phoenix/blob/67e5a9754d92dc58d3082afa42e4918049244b05/Dockerfile#L50
https://github.com/ACINQ/phoenix/blob/67e5a9754d92dc58d3082afa42e4918049244b05/Dockerfile#L53

Combine RUN commands

https://github.com/ACINQ/phoenix/blob/67e5a9754d92dc58d3082afa42e4918049244b05/Dockerfile#L77-L82
https://github.com/ACINQ/phoenix/blob/67e5a9754d92dc58d3082afa42e4918049244b05/Dockerfile#L55-L63
each RUN command create layer, it's better to use less RUN commands instead, such as:
RUN set -ex; \
         command1; \
         command2;

Checkout specific commit of Tor_Onion_Proxy_Library

https://github.com/ACINQ/phoenix/blob/67e5a9754d92dc58d3082afa42e4918049244b05/Dockerfile#L66
Doesn't use git checkout to check commit/tag, thus always will use latest commit which is not reproducible.

Running as root in container

Currently every command is run under root in the container, it's better to run whats possible under regular user instead.
Use USER directive to change to user created with useradd -ms /bin/bash appuser (ubuntu) or adduser -D appuser (alpine) commands

We've been working on migrating Phoenix to a completely new stack based on Kotlin multi-platform:

https://github.com/acinq/lightning-kmp
https://github.com/acinq/phoenix-kmm

Any work on deterministic builds will be done over there.


Fix handling of UIs v2

This is v2 of #18.
Summary of changes in v2:

Terms "accept UI" and "commit UI" changed to "capture UI" and "release UI"
Unnecessary conditional variable removed from peerstate package
Comments to uiCapturer and uiReleaser (previously uiAcceptor and uiCommitter) refined

Please note, that comment refinement was not requested in code review.

This line has also to be changed: https://github.com/hyperledger-labs/minbft/pull/19/commits/f90c79dc97781dadd3b350d774d6821b0f351739#diff-361906aeff1cb8f4413e72c2e1f99f73L165. We are testing backup replica behavior, but the backup replica ID in view view may happen to become a primary in view view+1.


ConstantVerifier should be merged into ConstantVisitor

Both the ConstantVisitor and ConstantVerifier analyze constant expressions. The distinction between the two is that ConstantVisitor was designed to produce diagnostics related to run-time exceptions while ConstantVerifier was designed to perform static analysis checks. (Historically, this was done because analyzer has not always done complete constant evaluation.)
Unfortunately, this means that some of the logic for how to deal with constant expressions is duplicated. It would be nice to consolidate the logic to ensure that the two can't get out of sync.
It would also address a performance issue. The ConstantVisitor visits each node in a constant expression, and in most cases evaluates the child nodes. This causes it to evaluate some expressions multiple times, which is unnecessary.

See also https://github.com/dart-lang/sdk/issues/42271.


fix(fsc): Fixes to test is_feature_enabled with fsc.

@yasirfolio3 unit tests are failing. Can you look into why?

@yasirfolio3 unit tests are failing. Can you look into why?

done, because now we are providing support for pre v3.0 audiences as well, one of the tests had audience mapping increased from 3 to 4.


convertto-json bigint is not properly serialized

[bigint]1|ConvertTo-Json
results in
{
"IsPowerOfTwo":  true,
"IsZero":  false,
"IsOne":  true,
"IsEven":  false,
"Sign":  1
}
instead of 1
tested on 6.2.0 on linux and 5.1 on windows

JavaScript implementations cannot read large integers >53 bytes precision, without loss of precision, so it looks like there's no clearly correct answer here, and the main choices are:

Pick what another system does and do that; Newtonsoft Json.Net encodes larger integers than JavaScript can read safely and risks compatibility problems, Twitter encodes large numbers as strings and cautions developers to expect that, Google V8 refuses to serialize BigInts saying it isn't supported.
Encode small values, but error for BigIntegers representing larger values. (Might be unpredictable)
Do what it does now, with that object encoding, which isn't useful, but is consistent - doesn't promise anything which it can't deliver.
Defer until such time as ECMAScript / Google have agreed ways of serialising BigInts to JSON, and do what they do.

Background links:
ECMA-404 JSON standard  doesn't put a limit on how large a value can be serialized as an integer in JSON, but JavaScript is limited to reading 53 bytes precision so it can't read integers larger than that, and returns truncated values. Twitter works around this by using strings to encode its 64-bit numeric identifiers and cautions developers to expect that.
Chrome's JavaScript engine V8 gained support for BigInt as a data type in 2018 but cannot serialize them to JSON, with VM134:1 Uncaught TypeError: Do not know how to serialize a BigInt.
ECMAScript has an open issue for what to do about JSON serialization of BigInts, appears inconclusive, with lots of discussion about compatibility.

/cc @markekraus

I think JavaScript is one of thousands of use-cases for JSON and probably a much small minority among those employed in PowerShell. The primary use cases for JSON in PowerShell are serializing and desalinizing data for interaction with REST APIs or for consumption or storage as settings. I see no reason to deny serializing BigInt. There are possibly REST APIs that would depend on such things.
But, I'd be more interested in what the .NET Core 3.0 JSON implementation does with them. If we still plan to move from NewtonSoft to the .NET Core native implementation, it probably behooves us to do as they do.

If we still plan to move from NewtonSoft to the .NET Core native implementation
@markekraus If we don't still have an issue tracking this please open new issue. Thanks!

Both .NET Core 3.0 and powershell should be based on the actual behavior of oracle java in the next two years, such as jdk12. It has been officially released.
Oracle java is the standard, if JSON in jdk12 do, then powershell do.

Oracle java is the standard

I disagree. RFC-8259 is the the standard. How any language implements JSON should be based on that standard.
The relevant part of the RFC is here https://tools.ietf.org/html/rfc8259#section-6

Note that when such software is used, numbers that are integers and
are in the range [-(2^53)+1, (2^53)-1] are interoperable in the
sense that implementations will agree exactly on their numeric
values.

We already support Int64 conversion which is out of range for general interoperability. Int64.MaxValue<PHONE_NUMBER>854775807 is greater than Number.MAX_SAFE_INTEGER<PHONE_NUMBER>740991. There is no strict limit on this per the RFC, just a warning with regards to interoperability.
If PowerShell was written in Java, then interoperability with jdk12 would be critical. However, we are based on .NET Core so we are bound by their support and limitations. Thus, it is far more important for us to consider .NET Core 3+'s implementation than any other language for any area not explicitly  restricted by RFC-8259.

I would like to note that if we do end up converting BigInt to a JSON Number by, it will be a breaking change. It could be implemented in a non-breaking manner as a configurable option. However, I suspect what most users would consider the default behavior would be to convert BigInt to JSON Number. Whether we wish to not make it option or what is the default behavior needs to be considered carefully.

en,thank you share.
Dependent on Newtonsoft Json ？ or   .net core 3 ？or jdk12 ？
Who is willing to open an issue in .net corefx and ask this question?

This creates inconsistent behavior with desktop PowerShell 5 though.  Wouldn't this be a bug and not a breaking change then?  Since ConvertFrom-Json prioritizes BigInteger over Decimal in PSCore, you can't go from JSON back to JSON without breaking the result.  This doesn't repro in Windows PowerShell.
Windows PowerShell 5.1.18362.145:
PS C:\> "9223372036854775808" | ConvertFrom-Json | ConvertTo-Json
9223372036854775808

The intermediate type is interpreted as Decimal.
PSCore 7.0.0-rc.1
PS C:\> "9223372036854775808" | ConvertFrom-Json | ConvertTo-Json
{
  "IsPowerOfTwo": true,
  "IsZero": false,
  "IsOne": false,
  "IsEven": true,
  "Sign": 1
}

The intermediate type is interpreted as BigInteger.

I'm running latest 7.3.9 version of PowerShell. Running the command provided by @zackste still produces the incorrect output:
❯ "9223372036854775808" | ConvertFrom-Json | ConvertTo-Json
{
  "IsPowerOfTwo": true,
  "IsZero": false,
  "IsOne": false,
  "IsEven": true,
  "Sign": 1
}


Monorepo create react app build fails on re deploy

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d36ng4ja7wbcyq
AWS Region
ap-south-1
Amplify Hosting feature
Deployments, Frontend builds, Monorepo
Describe the bug
We have a mono repo setup with react app and typescript. Example repo structure
Root
  - web
  - shared

web is built with react app and it has dependency on shared package as well. When we connect a branch in amplify console and deploy a build it works fine. But when we redeploy or push some code changes to the branch, the build fails with following error
Module parse failed: Unexpected token (2:34)
                                 File was processed with these loaders:
                                 * ../node_modules/source-map-loader/dist/cjs.js
                                 You may need an additional loader to handle the result of these loaders.
                                 | const DELIMITER = "---";
                                 > export const stringToBase64 = (str: string): string =>
                                 |   Buffer.from(str).toString("base64");
                                 |

The referenced file is in shared package and somehow after the first build, web is not able to resolve the typescript types from shared package.
Expected behavior
Re build/deploy should work always
Reproduction steps
Redeploy the successful build from here
Fails to deploy
Build Settings
No response
Log output

# Put your logs below this line

Additional information
No response

@saravmajestic Were you able to figure out your build issue?

@chrisl777 not yet and I have ran out of ideas and depending on AWS team for help

Now available as a beta, Amplify Hosting has improved support for monorepo frameworks including npm/yarn/pnpm workspaces, Turborepo and Nx. If you'd like to try it out, please let me know your AWS Account ID number so we can flag you in. My email is<EMAIL_ADDRESS>

@michrome @hloriii even after the new monorepo support, I am still facing the issue in my projects. Another active project with similar structure here:
App Id
djfn7tjuxd1cy
AWS Region
eu-west-2
Successful build
Next failed build


Add image labels via buildah

Buildah should set some image labels, similar to https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/component/BuildOpenShiftImageStage.groovy#L150.
I think we can trim the amount of set labels a bit. I'd say it is enough to record:

Git URL and commit
Timestamp
Pipeline Run

In theory, the pipeline run is enough to know which task built the image, but if we consider that pipeline runs might be removed, it could also make sense to bake in the task version and the SHA of the builder image.

Closing this. If there is a real need for this, it can be re-opened.


Tracking Issue for Stale Bot

We are evaluating the use of the Stale bot, and this is the tracking issue to gather feedback on it.

Initial setup: https://github.com/rust-lang/cargo/pull/6020
Messaging tweak: https://github.com/rust-lang/cargo/pull/6030

I find this extremely annoying.

I really really really hate this stale bot.

I disagree with the very premise of this bot. An issue without recent activity often means that it hasn’t been prioritized, that doesn’t make it less of an issue.
What is the problem that this is trying to solve? PR https://github.com/rust-lang/cargo/pull/6020 that set this up gives no reasoning or discussion at all.

So I proposed using this bot.  I realise this is a contentious issue (I believe Aaron mentioned it's been discussed in the past in the context of the Rust issue tracker).
My motivation is that in trying to help out resolving issues in the Cargo project I found myself often bumping into issues that just aren't ready for an implementation, often because its isn't clear what the issue is or what solution is desired, making it effectively un-actionable.
So I proposed using this bot to help close off some issues so that the issues that have the greatest interest can stay open, and those that are more niche don't clog up the backlog.
Now, I too disagreed with the premise of this bot, but have since changed my mind.
A closed issue doesn't mean the issue isn't valid, and a closed issue doesn't mean the issue was resolved.  Simply, there isn't sufficient interest in the issue to keep it open at this time.  However issues can also be re-opened and, indeed, the team has no problem with that.
Alex kindly accepted trialing this bot.  I personally think that using this bot can be beneficial to a project.  But every project and community is different, and this is just an evaluation.  If you have any suggestions or recommendations for its usage, I/we'd be interested to hear them.

Issues should not be closed just because they're "niche" or low priority, especially when "niche" often is just whatever the people in charge don't care enough about. Issues should only be closed when they've been resolved. There are better ways to prioritize issues, whether via priority labels or meta issues or github projects or external lists somewhere.
There is a need to ensure old issues get triaged, and there should definitely be some sort of thing to automatically direct some sort of triage team at a rotating list of inactive issues to see what can be done to get them moving. Automatically closing issues is not triaging, it's just sweeping issues under the rug, and it definitely won't solve issues with a lack of manpower.

My motivation is that in trying to help out resolving issues in the Cargo project

If the scenario we want to improve is that of a contributor searching for something to work on, I think that a positive signal like the E-easy label is much better suited.

its isn't clear what the issue is or what solution is desired, making it effectively un-actionable.

Just because an issue isn’t immediately actionable doesn’t mean that there isn’t a real problem that should be resolved.

A closed issue doesn't mean the issue isn't valid, and a closed issue doesn't mean the issue was resolved.

I suppose this is where we fundamentally disagree. I view closing an issue as a statement that no further action will be pursued: either the issue is resolved, or we made a decision not to resolve it (even if that decision can be reversed later).

clog up the backlog

How do inactive issues “clog up” anything? What does that mean? Why is that a problem?
GitHub allows sorting issues by most recently updated. This way you can avoid looking at them, without closing them.

Perhaps automatically add a tag for inactive after x number of days of no activity on the issue (and automatically remove the tag on activity). It certainly shouldn't be closed though, closing an issue implies either it's resolved, or there's no intention for it to be resolved.

An alternative would be to just use P-low, P-medium, P-high labels to prioritize things ? Everything that doesn't have a P-label, can be interpreted as P-lowest.

While I appreciate the need to keep the number of open issues down, I think this is a very bad idea. I work on another large open source project that uses a bot like this (Kubernetes). It results in lots of issues with the only activity being the annoying interaction being with this bot, e.g. https://github.com/kubernetes/kubernetes/issues/59119#issuecomment-388973598 and https://github.com/kubernetes/kubernetes/issues/58477#issuecomment-387898504. It doesn't help resolve issue any faster. In fact, it makes it harder to figure out whether a particular issue has already been reported or solved.

I found myself often bumping into issues that just aren't ready for an implementation, often because its isn't clear what the issue is or what solution is desired, making it effectively un-actionable.

The number of issues without a clear actionable path is minimal. The vast majority of issues without activity are just not being triaged, prioritized, or otherwise being worked on. The solution is not to pretend those issues don't exist by closing them.

A closed issue doesn't mean the issue isn't valid, and a closed issue doesn't mean the issue was resolved.

In my mind this is exactly what a closed issue means. It's a signal to the reporter that the community doesn't care about their issue.

If a feature request ticket is closed, imo this often signals "the feature-idea was rejected by the team" or "the feature has been implemented already".
If a bug has been closed imo this means "the bug has been fixed" or "nobody was able to reproduce the bug in the current version of the program (somtimes there are wontfix or works-for-me tags).
If now old tickets are closed automatically and people search for features they want in cargo or bugs they struggle with, but all they find is tickets that are closed, the might not even report "hey, I got this old bug again, here is a way to repro" or  "hey, I want this features as well, may I start working on it?" because the case was closes already...
I don't like having to comment on feature requests every N days to keep them from getting closed (maybe someone could setup an auto-comment bot...), of course I still want the feature, otherwise I would have closed it myself already.
If we have an issue with several "stalebot threatened to close this issue" comments and "bump"-comments after it, just to prevent the issue from being closed, I don't think this is going to help a lot...

A half-way compromise is possible: the stale bot adds the "stale" label and requests a summary, but never actually closes the issue. In some cases the original author will decide to close the issue.
It may also be worth adding support for commands, such as @stale close (with a 7-day delay) and @stale cancel.

I am 100% against the use of this bot. Closing issues does not make them go away, but it does guarantee that they won't be seen anymore. Issues getting old because there isn't enough manpower to fix them doesn't make the issues invalid.
The only effect of this bot is that people who are contributing by reporting issues see an email, months later, that tells them nobody cares about their issue and it will never be fixed.

Thanks all for taking the time to provide some feedback on this, it's definitely appreciated! We discussed this during the @rust-lang/cargo triage meeting yesterday, and I'm going to try to do my best to summarize the result of the discussion.
The main aspect that we concluded was that we view it as quite valuable to, in an automated fashion, poke issues to try to keep them moving forward. This is a great way for the team to be reminded about older issues (as well as contributors). This not only provides an opportunity for someone to realize that the issue has been fixed by something else but it also provides a great time to refresh the context to make sure the bug is up to date.
There was not consensus amongst the team about the usefulness of automatically closing issues if they had been stale for awhile. We all agreed, however, that many of the points brought up here were agree that we don't want to happen. For example we do not want to portray the message that if an issue is automatically closed that it will be forever closed. Furthermore we don't want to irritate ourselves or contributors by constantly fighting to keep a legitimate issue open.
With all that in mind, and in addition with the experience we've learned over the past weekend, we concluded that this is the steps we'd like to take at this time:

We've updated the bot's configuration to slow down even more. Although 24 issues per day is as slow as the bot can go, we felt it was still too fast. We've increased the time it takes for an issue to be considered as "stale" (to three years) to only have a handful of issues be considered for being stale.
We've also updated the amount of time given until an issue is automatically closed, now to 30 days. We're in no rush to close a stale issue, and we want to make sure that if an issue is closed that it truly is stale with very little interest!
We're looking for feedback on wording of the message to clearly imply that the main purpose is poking the issue to help it move forward. We don't want the focus to be that this is closing and it's a race against the clock.
We won't decrease the amount of time to the first poke by the bot until we can figure out how to execute at a slower rate than 24/day. This may require changes to the bot upstream, however.
We'd love to get some feedback on labels that turn off the bot. For example right now all issues tagged as a feature request will not be poked by the bot. Are there other labels to add too?

Others from the @rust-lang/cargo team can feel free to chime in here too!

we don't want to irritate ourselves or contributors by constantly fighting to keep a legitimate issue open.

Maybe the lower frequency will make this less irritating, but it’ll keep happening.

@SimonSapin that's true, yes, but if truly nothing happens on an issue for literally years on end I think asking someone to say (like once a year) that the issue still exists is quite reasonable. If an issue has gone multiple years with only a bot and one person poking it then it's highly likely that it's entirely un-actionable its current form and needs to change somehow, and leaving it simply sit and collect dust won't actually do that.

We've increased the time it takes for an issue to be considered as "stale" (to three years)
We won't decrease the amount of time to the first poke by the bot

Sorry, I think I'm misinterpreting something but these seem contradictory... to clarify, how old will an issue get before the bot first pokes it?

Regarding tags that disable the bot, it seems to me that almost any tag should do it. That is, if a team member comes along to add tags and says "gee, this issue looks really unclear/unactionable/unreproducible", I'd imagine it should stay untagged or get a C-needs-details-plz tag right from the get-go. But yeah, I realize that's kind of idealistic and it's still quite possible for issues to become outdated.
I still think there should be a more human touch before closing issues, like maybe the bot can assign a random person to follow up like highfive does (I'd be on that ping list if you need volunteers).

@durka the exact amount of time is up in the air, currently it's set at three years. We won't make that shorter, though, until we can get the rate limits under control.

We won't decrease the amount of time to the first poke by the bot until we can figure out how to execute at a slower rate than 24/day. This may require changes to the bot upstream, however.

I opened https://github.com/probot/stale/issues/165 to track that.  My initial attempt to fix that wasn't successful.

Sounds good to me, thanks for investigating though!


proxy views in list serializer

I need to be able to specify that a view is used on the elements of a list serializer, and check that a given view exists on the element serializer when only given the list serializer.

Fixed in SoberSwag reporting.


DOC: Code Guidelines for HTML/CSS

This issue tracks the progress of the creation of the CodeGuidelines.md file that will govern the HTML and CSS for fabric8io/fabric8-ui and fabric8io/fabric8-planner.
The file can be found here: CODEGUIDELINES.md, or can be viewed on the fabric8-ux site.

Suggest CSS Property Order:
css property order
Related property declarations should be grouped together following the order:

Positioning

position
top
right
bottom
left
z-index

Box model

display
float
width
height
max-width
max-height
min-width
min-height
padding
padding-top
padding-right
padding-bottom
padding-left
margin
margin-top
margin-right
margin-bottom
margin-left
margin-collapse
margin-top-collapse
margin-right-collapse
margin-bottom-collapse
margin-left-collapse
overflow
overflow-x
overflow-y
clip
clear

Typographic

font
font-family
font-size
font-smoothing
osx-font-smoothing
font-style
font-weight
hyphens
src
line-height
letter-spacing
word-spacing
color
text-align
text-decoration
text-indent
text-overflow
text-rendering
text-size-adjust
text-shadow
text-transform
word-break
word-wrap
white-space
vertical-align
list-style
list-style-type
list-style-position
list-style-image
pointer-events
cursor

Visual

background
background-attachment
background-color
background-image
background-position
background-repeat
background-size
border
border-collapse
border-top
border-right
border-bottom
border-left
border-color
border-image
border-top-color
border-right-color
border-bottom-color
border-left-color
border-spacing
border-style
border-top-style
border-right-style
border-bottom-style
border-left-style
border-width
border-top-width
border-right-width
border-bottom-width
border-left-width
border-radius
border-top-right-radius
border-bottom-right-radius
border-bottom-left-radius
border-top-left-radius
border-radius-topright
border-radius-bottomright
border-radius-bottomleft
border-radius-topleft
content
quotes
outline
outline-offset
opacity
filter
visibility
size
zoom
transform
box-align
box-flex
box-orient
box-pack
box-shadow
box-sizing
table-layout
animation
animation-delay
animation-duration
animation-iteration-count
animation-name
animation-play-state
animation-timing-function
animation-fill-mode
transition
transition-delay
transition-duration
transition-property
transition-timing-function
background-clip
backface-visibility
resize
appearance
user-select
interpolation-mode
direction
marks
page
set-link-source
unicode-bidi
speak

@mindreeper2420  I have some suggestions:
For General Formatting

Use only lowercase
Comments: Explain code as needed, where possible. Avoid heavily commented HTML Code

For HTML Attribute order

Put class attribute first (developers read/write this most often).
Put id attribute second (important if it’s defined).
Everything else is alphabetical.
Put data-* attributes last (alphabetical).
But there can be some exceptions. When an attribute is critical to defining an element put it first to improve readability. For e.g.

<button type="" class=""></button>

<input type="text" class="" id="" disabled name="" placeholder="" readonly value="">

For Class Names Naming convention How about using BEM Methodology? Instead of underscores we can use single hyphens

As you( @mindreeper2420 ) said using io as prefix is the great idea but what about planner/platform specific components? We should also come up with prefixes as that needs to be in guidelines

I have another point on lengthy HTMLs (horizontally). Can we limit the HTML line length for better readability ?

@SMahil Responses to your points below :)

Agree on General Formatting and HTML Attributes ordering. Those are definitely things that we can define that will also be easy to keep consistent.

I thought about the BEM Methodology (the PatternFly 5 Code Guidelines state that, but I commented them out when I forked them), but wasn't sure if we should go down that path right now. I'd be for it, just need to get the timing right.

This is what PatternFly 5 is recommending:

BEM
PatternFly follows the BEM methodology. It's a way to decouple CSS from HTML, and modularize class names so they can be extended.
Class name structure follows the {{pf-block}}__{{element}}--{{modifier}} structure:
.pf-block__element--modifier {}

Example:

Heading

Lorem ipsum dolor sit amet.

.pf-panel {}                      // Block
.pf-panel--collapsible {}         // Modifier of block

.pf-panel__title {}               // Element

.pf-panel__content {}             // Element
.pf-panel__content--unpadded {}   // Modifier of element

Why it’s better

All the selectors have same specificity.
Every element is defined via a block.
Every modifier is defined via a block or element.
Each class name imparts structural info without binding to exact HTML.

As all of these are consumed by IO, I'd either stick with that, or go with an f8- prefix for everything, as all of these areas are part of the Fabric8 organization. That would clearly separate what is specific to fabric8 and what is not. I think that breaking it down into Platform/Planner prefixes would decrease the extensibility of the overall environment.

I started working on a linter and set the max character line for Less files to 100 characters. We can do something similar for the HTML, but extend that to the ordering and formatting that you mentioned. A good piece of that would be specifically written in our code guidelines document.

Ready to close or still in review?

@dgutride @dlabrecq any thoughts on the Code Guidelines that we've written up?

Does Patternfly 5 have a code guidelines file available for reference? I'm wondering if we can point to that or at least have a pointer to it as the gold standard?
Looking at the proposed CSS property grouping order and seems difficult to follow. I don't know if folks will get the ordering right each time? Unless everyone understands that 'content' comes before 'quotes' and 'word-spacing' comes before 'color'?
You might want to note why we're following that particular order? If we're are expected to place 'word-spacing' before 'color', it would be good to understand why that makes a difference. That is, why are the selector groupings not alphabetical?
I'm not a fan of 100 chars limits, especially for HTML files with long selector names? I find 120 to be a more reasonable number. If the Angular code is allowed to be greater than 100 chars, other files should be the same.

@dlabrecq this was copied from the PatternFly 5 code guidelines here: https://github.com/patternfly/patternfly-css/blob/master/CODE-GUIDELINES.md, but with our additions/alterations. I added a reference to it at the bottom of the file, but I can include one at the top as well.
On the CSS grouping order, PatternFly 5 will be following the Field CSS Manual, which this guideline has just taken the pieces out and put them into one list. The Field Manual does break them out in an easier to read format, so we can just refer to that.
Regarding the 100 character limit, that is coming from the Less Hinter that we will be using: lesshint. The default there is 100, so that is what I put for our limit as well. That can be changed, though I'd like to have a limit that isn't too out there.

The Field CSS manual shows appears to be alphabetical within groups -- color is before any other property. Just want to be clear about the proposed order because your suggested groupings were not.
120 chars is not unreasonable for HTML.

PR for updating the Code Guidelines with information on Field CSS Manual, structure and HTML character limit: https://github.com/fabric8io/fabric8-ux/pull/508.

With the latest PR merged, I'm going to close this issue. We can open another if updates are needed, once we start to implement the guidelines across the platform.


User Report: Learning Isn't Happening

See this thread.
https://discord.com/channels/1102639988832735374/1278048402567069728
User queried the logs and didn't see any entries for BuildLog.

Are the logs Processing Any Log File?
https://github.com/jlewi/foyle/blob/4288e91ac805b46103d94230b32dd1bc2f957095/app/pkg/analyze/analyzer.go#L200

Negative. I don't see any Processing log file logs:
https://gist.github.com/sourishkrout/bc7cdccaa828056b3f5c622679ac49bb

@jlewi I am not sure what this logic does, but it appears my logs always wind up in this condition (see below):
https://github.com/jlewi/foyle/blob/4288e91ac805b46103d94230b32dd1bc2f957095/app/pkg/analyze/analyzer.go#L207-L209

Oh, looks like that's just tracking "savepoints" to avoid double processing.

3. Search the logs for the above message
     jq -c 'select(.msg == "Processing log file")' "/Users/jlewi/Library/Application Support/runme/logs/logs.2024-08-19T19:45:23.json"

Q: Processing log file should appear in Foyle's log and not in the Runme AI's logs, no?

Here we go. Logs! Still not learning, though.
https://gist.github.com/sourishkrout/3cdecee8b123a436d35775cfbf4b8dac

Here are my results @jlewi:
https://gist.github.com/sourishkrout/0f77867bb35df94d1b0eb4490c8fc6ff

Thanks @sourishkrout
It looks like you set LASTLOG to the RunMe logs here
So all log statements below that are checking the wrong log file.
Does the formula in the notebook not work for you?
export LASTLOG=~/.foyle/logs/raw/$(ls -t ~/.foyle/logs/raw | head -n 1 )

Your earlier trace indicates that a BlockLog was properly computed for your cell so that's good.
In this particular case I wouldn't expect learning to occur. If you look at the BlockLog you can see that contents of the generatedBlock and the executedBlock are the same. The only difference is some whitespace.
You can see here that when processing examples (BlockLogs) we strip whitespace and then compare the contents. If they are the same then we don't learn from that example.
So here's the things to try

Enable debug logs by running with "--level=debug"
Accept a suggested edit cell
Make a non whitespace change to the cell
Use the notebook to get the block trace for that cell

Verify the executed and generated contents are different in more than just whitespace

Check the logs for that cell ; there should be a message saying it learned from that example

Okay, so now again with Foyle & Runme on latest main:
https://gist.github.com/sourishkrout/f075e1a7eb7b23e84854383323f666ec#file-troubleshoot_learning-01j7kh2c6177p74pfkcd6w3ns8-md

So there are two bugs. That I fixed in #233

The first is a bug in the documentation; the command to check the blocklogs has changed because we now use the  ConnectProtocol

The updated command is here

The second is there was a bug in adding execution events to the blocklog

So please retry using the latest on main which has the fix.   The updated command for checking the blocklog is here
https://foyle.io/docs/learning/troubleshoot_learning/#did-block-logs-get-created
Your logs indicate the BlockLog is being generated
{"severity":"info","time":1726158688.428434,"caller":"analyze/analyzer.go:658","function":"github.com/jlewi/foyle/app/pkg/analyze.buildBlockLog","message":"Building block log","blockId":"01J7KH6B5YJ111KEXAAHD97XY8","block":{"id":"01J7KH6B5YJ111KEXAAHD97XY8","gen_trace_id":"da7a66391bad2f64f6f66e056eed6772","exit_code":0,"eval_mode":false,"resource_version":"c7db69f7-869b-4439-92e2-09ba254bc364","suggestion_status":"SuggestionStatusUnknown"}}

So I suspect the blocklog is there so once we start using the updated CURL command we should be able to fetch it and see what's going on.

The updated command is here

Where? Did you forget to include the link?
Here's an updated Runme session gist: https://gist.github.com/sourishkrout/babd0e9f32ad8079869d4534f8b3bb4b#file-troubleshoot_learning-01j7mayp580arr60njbes5fbq6-md

Oh sorry. I did forget the link;
https://foyle.io/docs/learning/troubleshoot_learning/#did-block-logs-get-created

Oh great looks like you found the correct link sorry about that.
It looks like things are working now.

The output shows that you have "example.binpb"

So it looks like #233 fixed the issue with example.binpb files not being computed.

Sorry the example showing up in the output isn't from my machine. The cell is echoing the static content from the original doc since it's plain text.
The issue I'm observing is still the same where the previously accepted, corrected, and successfully executed does not seem to get retained as part of learning.

Ahh my mistake.
So it looks like cell 01J7KQPBYCT9VM2KFBY48JC7J0 is your cell?

it looks like the block log is available and indicates different commands

Generated command was jq
Executed was a CURl

There is no log message corresponding to this line indicating a new examples was detected

So there are a couple possibilities

The block is never enqueued
The block is enqueued but it is never reconciled
Reconcile is invoked but execution is aborted before reaching this line

Blocks get enqueued here by invoking the blockNotifier. That will not happen if the blockNotifier is nil.
Block notifier gets set here
Analyzer.Run is called here.
I can't see any reason why Learner.Enqueue wouldn't be getting invoked.
Next Steps
At this point the best way to probably debug this would be to set a couple breakpoints and see what code paths are getting executed. My suggestion would be to start as follows

Set a breakpoint here (https://github.com/jlewi/foyle/blob/8c57b00bc2b104e387b51e8032919d6ea90d865e/app/pkg/analyze/analyzer.go#L642

This will tell us whether the block is being enqueued

Set a breakpoint in learner.Reconcile https://github.com/jlewi/foyle/blob/8c57b00bc2b104e387b51e8032919d6ea90d865e/app/pkg/learn/learner.go#L124

Let me know if you want to pair.

@sourishkrout I found and fixed another bug #241 due to the logging changes. Fingers crossed that fixes things for you.

🤞 testing this now.

No dice. However, the additional cells in the troubleshooting guide might be helpful, @jlewi.
https://gist.github.com/sourishkrout/cceb035482da5da3ec5e4ce294da9207#file-troubleshoot_learning-01j80nc4fqpm7c5ffxyfpx5r5s-md
I'll try the breakpoints and see what happens. I could pair tmrw afternoon if that's easier.

It looks like I never get past this line, even though one of the two occasions was definitely a generated block:
https://github.com/jlewi/foyle/blob/main/app/pkg/learn/learner.go#L158

I'm sorry this is so frustrating. I really appreciate your patience.

It looks like I never get past this line, even though one of the two occasions was definitely a generated block:

Yes.
I think I know what is going on. "learner_enqueued_total" is only 1.
In #241 I changed when we notify the learner because we should only need to notify the learner after processing the executed log entry because that should necessarily be after the generated log entry.
The learner gets notified here. My assumption was that by the time the execution event gets processed the BlockLog has already been processed
But that's not guaranteed because we read the log lines in chunks and only update the blocklog after reading the entire chunk
https://github.com/jlewi/foyle/blob/6035823bd821512769415825b4cccba2970ab092/app/pkg/analyze/analyzer.go#L307
So why was it working for me and not you?
So here are some examples that were produced for me
-rw-r--r--    1 jlewi  staff  30077 Sep 16 18:24 01J7YMFGD47MEG6QN46NN0GXKQ.example.binpb
-rw-r--r--    1 jlewi  staff  33214 Sep 16 18:25 01J7YQ57WRP73B0ND35NZY3MVG.example.binpb
-rw-r--r--    1 jlewi  staff   7953 Sep 17 14:34 01J80YESW7NYV5N6DX0168HNAQ.example.binpb

Two things are true in my case

I ended up executing the cell multiple times because I needed to iterate to get  to the correct command
I have debug logs enabled.

I think those two things contribute to the bug being masked. In particular, the bug means the first time the learner gets notified due to the first execution event the generated block won't be part of the log. The subsequent cell executions lead to additional learner notifications being fired. Debug logs increase the number of logs in between the two execution events. As a result, were more likely to hit the chunk limit in between execution events and therefore  combine the log entries and update the BlockLog with the generated block.

@sourishkrout Latest fix is #244

I can definitely see more activity in the logs now. However, my ~/.foyle/training remains empty, and learning still does not take effect. I made sure that in the example below, I would edit the cell a few times to achieve the desired outcome.
If you're available tomorrow afternoon, we could pair up to work through it. Looking over my shoulder might help, too.
https://gist.github.com/sourishkrout/f42a1b63578f4c95701b8ca332360caf#file-troubleshoot_learning-01j814mfadm7dw0m5b1jdgny3w-md

So we're making progress.  I think I found the next bug.
Your counters show that there were two learning examples.
learner_blocks_processed{status="learn"} 2
learner_blocks_processed{status="nochange"} 1
learner_blocks_processed{status="notgenerated"} 1
learner_blocks_processed{status="unexecuted"} 10

So we know the code reached  here
https://github.com/jlewi/foyle/blob/d67a104e1263c243ad6271d5329d154626751576/app/pkg/learn/learner.go#L176
If something went wrong in the subsequent processing we should have seen an error.
I think the bug is that exampleFiles is empty then the for loop never iterates and we don't try to create any exampleFiles
https://github.com/jlewi/foyle/blob/d67a104e1263c243ad6271d5329d154626751576/app/pkg/learn/learner.go#L177
getExampleFiles will return an empty list if getTrainingDirs is empty
https://github.com/jlewi/foyle/blob/d67a104e1263c243ad6271d5329d154626751576/app/pkg/learn/learner.go#L252C29-L252C44
getTrainingDirs returns empty if Learner in your configuration is empty
https://github.com/jlewi/foyle/blob/d67a104e1263c243ad6271d5329d154626751576/app/pkg/config/config.go#L247
This is legacy code. Prior to #211 you had to set the location of the RunMe logs and learner could be nil. Post #211  you shouldn't need to set learner.
My config looks like
learner:
    logDirs: []

Fix incoming.

@sourishkrout latest fix is #245

Two other issues we ran into during our pair programming
#249
#248

@sourishkrout I'm marking this as fixed. Let me know if your still having problems.


how to determine which elements set fflags?

According to Vector Floating-Point Exception Flags, fflags will be set if any active element causes exception. That means a vector instruction may set all fflags.
Then how does programmers know which elements contribute to the flags?

The intuition behind this design is that most code checks the flags at specific points, not after every operation.  This is doubly true for RISC-V, which does not trap when floating-point instructions set the exception flags.
In some cases, and only when exceptions are rare, it's possible to speculatively vectorize the code, then re-run the problematic portion in scalar code to determine which element was at fault.

Thanks.


Add support for input state (other than isFocused)

Adding checked and disabled states to be able to assert them easily:
assert.ok(find('input[type="checkbox"]').checked);
assert.dom('input[type="checkbox"]').isChecked();

assert.ok(find('input[type="checkbox"]').disabled);
assert.dom('input[type="checkbox"]').isDisabled();

Also what about readonly or required?

I guess we should probably have a generic hasProperty() assertion roughly similar to hasAttribute(), but having those shortcut assertions for the most common properties should also be useful.


Create style.yaml

Github action for code style check.

I think early next week I'll take a pass at fixing all the existing style issues, then we can merge this.

This PR can been superceded by #285; the github action action-ros-ci runs the tests, and the tests are include the uncrustify action


FR: Also expose placeholders for geo ip information

I was looking at caddy geoip capabilities so I could augment my access logs with location information (for later processing and monitoring) and it seems like this plugin is the only geolocation plugin that was ported to caddy v2.
caddy v1 had https://github.com/aablinov/caddy-geoip which exposed placeholders and I think this plugin is best situated to do something similar.
There might be an issue of redundancy since once you define placeholders then one could use either the custom matchers already defined by the plugin or just use expression to create any condition they want using the value of the placeholders.
(On the other hand, it would make extensions like https://github.com/porech/caddy-maxmind-geolocation/issues/3 to implement since no expression syntax would need to change)
It seems like using a handler to add placeholders is pretty easy but it is a bit of a philosophical change vs having a matcher. My own opinion is providing placeholders is more elegant software solution but then we'd have to worry about migration.
Let me know what you think!

Hey, I believe this would be very useful feature, is there any plan to add this placeholders ?

Here is another addon that does it.
But would be great if that functionality was available in this addon too (so we didn't need two).
https://github.com/shift72/caddy-geo-ip


pull request for e2e test at 12/08/2016 22:56:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Better History Recording

Description of the new feature / enhancement

For example, chapter 1,2,3 are opened, currently they all are recorded in history, instead only record last opened chapter i.e, 3.
After opening another 2 chapters from the same manga and opened chapter 3 again, then only record chapter 3 in history.
Only the last opened chapter should be recorded in the history column for that manga.
Same for different mangas.

Scenario when this would be used?

History record will be greatly reduced in this way.
In this way, each manga will have only one record of history.
It will be more efficient and the chapter last read from different mangas will be known easily when there large collection of mangas.

Supporting information
No response

1px / 2px for the separators in way-2.
In this way even if the bookmarks tab is collapsed/un-collapsed the line end will act as the border.

I didnt understand, can you rephrase.


refactor AbstractLineNumbers so that they are more functional

Instead of having a AbstractLineNumberBuilder, instead AbstractLineNumber should have the following methods:

AbstractLineNumber increment() returns a clone but with the last component's sequence number incremented
AbstractLineNumber addBranch(b) returns a clone but with a new component appended

Then PDGBuilderVisitor can just have an initial AbstractLineNumber and increment or add a branch as needed, without a separate abstract line number builder.

resolved by https://github.com/apl-cornell/viaduct/commit/4e1b14f0d030c33e431772f703f540a9babf41ec


Use libc::{clock_t, c_char} to allow compilation on ARM

This is related to but does not 100% solve Issue #205.
The style difference (::libc versus use libc::{ ... }) is just because I used whatever I saw in the particular source file I was editing. macros.rs doesn't seem to use-import anything.

Thanks!


Missing plugin exception

Android 10
FilesystemPicker.open(.....
[ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: MissingPluginException(No implementation found for method requestPermissions on channel flutter.baseflow.com/permissions/methods)
MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:154:7)

@KonstantinKolesnik Please report a complete dump of the error.

D/ViewRootImpl@3478631MainActivity: ViewPostIme pointer 0
D/ViewRootImpl@3478631MainActivity: ViewPostIme pointer 1
I/flutter (12202): [GOING TO ROUTE] null
E/flutter (12202): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: MissingPluginException(No implementation found for method requestPermissions on channel flutter.baseflow.com/permissions/methods)
E/flutter (12202): #0      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:154:7)
E/flutter (12202):
E/flutter (12202): #1      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:329:12)
E/flutter (12202): #2      PermissionHandler.requestPermissions (package:permission_handler/src/permission_handler.dart:85:30)
E/flutter (12202): #3      _FilesystemPickerState._requestPermission (package:filesystem_picker/src/picker_page.dart:112:35)
E/flutter (12202): #4      _FilesystemPickerState.initState (package:filesystem_picker/src/picker_page.dart:106:5)
E/flutter (12202): #5      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4640:58)
E/flutter (12202): #6      ComponentElement.mount (package:flutter/src/widgets/framework.dart:4476:5)
E/flutter (12202): #7      Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #8      Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #9      SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5830:14)
E/flutter (12202): #10     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #11     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #12     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4527:16)
E/flutter (12202): #13     Element.rebuild (package:flutter/src/widgets/framework.dart:4218:5)
E/flutter (12202): #14     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4481:5)
E/flutter (12202): #15     ComponentElement.mount (package:flutter/src/widgets/framework.dart:4476:5)
E/flutter (12202): #16     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #17     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #18     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5830:14)
E/flutter (12202): #19     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #20     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #21     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5830:14)
E/flutter (12202): #22     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #23     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #24     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4527:16)
E/flutter (12202): #25     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4675:11)
E/flutter (12202): #26     Element.rebuild (package:flutter/src/widgets/framework.dart:4218:5)
E/flutter (12202): #27     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4481:5)
E/flutter (12202): #28     StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4666:11)
E/flutter (12202): #29     ComponentElement.mount (package:flutter/src/widgets/framework.dart:4476:5)
E/flutter (12202): #30     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #31     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #32     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5830:14)
E/flutter (12202): #33     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #34     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #35     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5830:14)
E/flutter (12202): #36     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3446:14)
E/flutter (12202): #37     Element.updateChild (package:flutter/src/widgets/framework.dart:3214:18)
E/flutter (12202): #38     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4527:16)
E/flutter (12202): #39     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4675:11)
E/flutter (12202): #40     Element.rebuild (package:flutter/src/widgets/framework.dart:4218:5)
E/flutter (12202): #41     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4481:5)
E/flutter (12202): #42     StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4666:11)
E/flutter (12202): #43     ComponentElement.mount (package:flutter/src/widgets/
W/maestro.ecosca(12202): Reducing the number of considered missed Gc histogram windows from 103 to 100

@KonstantinKolesnik Have you specified permissions in AndroidManifest.xml?
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_INTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>```

Yes, sure

Does your project use AndroidX?

Try migrating to AndroidX: https://flutter.dev/docs/development/androidx-migration

I have these in my gradle.properties
org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
android.useAndroidX=true
android.enableJetifier=true
Is it correct?

Yes, see an example: https://github.com/andyduke/filesystem_picker/tree/master/package/example


Is there a way to update variable without using setState, notifyListeners or any external packages?

Yes. Variables in ViewModels are often called "properties" when using MVVM. To create a property, you can
  late final count = createProperty<int>(0);

And the update the property like
count = 5;

or
count++;

mvvm_plus uses notifyListeners under the hood to notify listeners that the value has changed.

Just a word of advice: although createProperty<T>() is easy to use, it publishes it mutability (i.e.: I can change the value of a property outside the class that declares it, which is very very very bad).
A better approach is always use a private changer:
int _count = 0;
int get count => _count;

void someMethodThatMutatesCount() {
  ...
  if(_count != newCountValue) {
    _count = newCountValue;
    buildView();
  }
  ...
}

First, it won't rebuild if nothing has changed.
Second, you can't change count outside of that view model.


Load project dependencies by name instead of path in EFServices.

Trying to fix the test issue on CI, where E2E tests fail while trying to load project dependencies.
cc @natemcmaster

:shipit:
I believe you probably hit of the breaking changes introduce in .NET Core's assembly loader. cc @davidfowl


Media type check too strict

The media type check seems a bit too strict. One of my schemas on file has a reference to https://raw.githubusercontent.com/iziteq/izi-api-schemes/master/sections/uuid_schema, which is marked text/plain, yet should be a valid schema file. As I have no control over the schema files other than that I can use them, I am wondering whether this check is too strict.

:+1: However is possible use a custom URIRetriever

@Maks3w Would you expound upon that?
My workaround was to change line 29 in /vendor/justinrainbow/json-schema/src/JsonSchema/Validator.php from:
const SCHEMA_MEDIA_TYPE = 'application/schema+json';
to:
const SCHEMA_MEDIA_TYPE = 'application/json';
I appreciate any help.

According the specs: http://json-schema.org/latest/json-schema-core.html#anchor34 it's not too restrict I think?

The MIME type MUST be "application/json", or any other subtype

OK, then I think this issue can be closed?

thx!


[test] Adjusting production test for dom

Modifications due to Jenkins tests failing on DOM.

@jenkins-cscs retry all


Lasso Scenario Creation Quickstart

@e-lo, I tried to run Lasso Scenario Creation Quickstart.pynb. I received several errors related to the schema (e..g outboundReferenceIds, inboundReferenceIds). I think the schema that's on master might be out of date?
Would you take a look at the example notebooks and see if you also have problems running them? (If not, maybe it's something in the way I set up the repo?)

@i-am-sijia or @e-lo, I would like to run lasso in a notebook that is not stored as a subfolder of the lasso directory. When I do, it throws an error in get_base_dir
 "Cannot find Lasso base directory from {}, please input using keyword in parameters: \lasso_dir =` ".format(init_d)`
I understand that I need to pass the directory for lasso in and that not doing so is causing the error. However, I'm unclear how to declare a kwarg that you pass in during an import statement (since it fails when I import Project from lasso. (The articles I found on kwargs all touched on using kwargs for a function but not this step.)

Network Wrangler schema needs to be updated to the latest network.

--> now fixed in Wrangler Develop branch : https://github.com/wsp-sag/network_wrangler/commit/7167f54351267b0af8cce06bfe7c404f5c5fd0d9

"Cannot find Lasso base directory from {}, please input using keyword in parameters:lasso_dir = ".format(init_d)

--> moving this to a separate issue