Outlook Problem

First I want to say that is App is amazing and has saved me so much time, however, my client is very very outlooked based, and for some reason when the email is pulled up into outlook it ignores the width of 600px and just makes the email 100% of the screen.
Here is my mjml code:
`

%%LOC(PREHEADER)%% %%AD(1)%%

	<mj-section background-color="#187EC3" width="600">
		<mj-column width="100%">
  		<mj-image src="http://www.aans.org/Eblast/TEST/NewslineHeader.jpg"></mj-image>
  	</mj-column>
	</mj-section>
<mj-section background-color="#fff" width="600">
	<mj-column>
  	<mj-text font-style="italic"
             padding="0px 25px">
    Newsline features headlines from around the globe regarding newly-released research on noteworthy advancements in the field of neurosurgery that are pertinent to the neurosurgical community. Here are some highlights from recent top stories:
    </mj-text>
  </mj-column>
</mj-section>

	<mj-section background-color="#fff" padding="0px" width="600">
		<mj-column background-color="#187EC3" >
    	<mj-text color="#fff"
               font-size="16px"
               font-weight="600"
               font-family="Open Sans">
      	Newsline |
      </mj-text>
    </mj-column>
	</mj-section>

	<mj-section background-color="#fff" width="600" padding="10px 0px 0px">
		<mj-column>
    	<mj-text>
      	%%LOC(INFORMZ CONTENT HERE)%%
      </mj-text>
    </mj-column>
	</mj-section>

	<mj-section background-color="#fff" width="600">
		<mj-column>
    	<mj-text>%%AD(2)%%</mj-text>
    </mj-column>
	</mj-section>
	<mj-section padding="0px">
		<mj-column background-color="#187EC3">
    	<mj-text color="#fff"
               font-size="16px"
               font-weight="600"
               font-family="Open Sans">
      	For a list of all Newsline posts
      </mj-text>
    </mj-column>
	</mj-section>
	<mj-section background-color="#fff" width="600">
		<mj-column>
    	<mj-text padding="0px 25px">
      Follow AANS Neurosurgeon through its social media outlets for more news and other updates:
				</mj-text>
      <mj-list>

AANS Neurosurgeon’s Twitter feed: @AANSNeurosurg

AANS Neurosurgeon is now on Facebook. Like the page to keep up with the latest neurosurgical happenings.

      </mj-list>
    </mj-column>
	</mj-section>

	<mj-section background-color="#187EC3" width="600">
		<mj-column>
    	<mj-text color="#fff" font-size="12px">
        American Association of Neurological Surgeons

					5550 Meadowbrook Drive, Rolling Meadows, IL 60008-3852

<PHONE_NUMBER> or<PHONE_NUMBER>

<EMAIL_ADDRESS>      </mj-text>
			</mj-column>
		</mj-section>
		<mj-section padding="10px 25px" width="600">
	<mj-text color="#000" font-size="10px">You are currently subscribed to receive information from the AANS. You may change your email address by 						logging in to MyAANS.org with your username and password. Click here to unsubscribe from all AANS, NPA and NREF 							communications.
© 2017 American Association of Neurological Surgeons. All Rights Reserved</mj-text>
    </mj-column>
	</mj-section>
		<mj-section>
		</mj-section>
</mj-container>

`
this is what it is meant to look like
![newsline](https://cloud.githubusercontent.com/assets/28782009/26202123/d07e53ac-3b9b-11e7-9c71-a79ce76e9dd7.png)

Hi @Kpaetschow23
On which Outlook version you're seeing this issue ? It looks fine on Litmus for me from 2003 to 2016

2016

This is what I'm getting in outlook

Here the test from Outlook 2016 mac & windows :

Can you try with a clean service like putsmail.com maybe your ESP is altering the email HTML ?

You are right it must be my email service, thank you for your time! Again love the app


openOnEnter for Disable fields

Was there a reason that the openOnEnter option was removed in version 4? If you click on a select2 field that is disabled you can still open the search field

Duplicate of https://github.com/select2/select2/issues/4695.


Linting and Formatters

Hello @hellt
What are your thoughts on adding further development tooling to the project and GH Actions?

linter(s)
formatter(s)

(If it's ok,) Might you have any preference on the tool or tools to use?
Thank you!

Hi @mjbear
yes, please check out ruff - https://docs.astral.sh/ruff/
both linter and formatter

Hi @mjbear yes, please check out ruff - https://docs.astral.sh/ruff/ both linter and formatter

I'll take a look at ruff
We're certainly most interested in Python linting and formatting. :wink:
There's also a markdown linter which I'll look into running locally first to see what it finds or how it behaves. :sweat_smile:
https://github.com/markdownlint/markdownlint

So far I haven't exactly found one that stands out as an exceptionally popular MD linter.

https://github.com/markdownlint/markdownlint

ruby
GH action: https://github.com/marketplace/actions/run-markdownlint-mdl

https://github.com/igorshubovych/markdownlint-cli

javascript
GH action: https://github.com/marketplace/actions/markdown-linting-action

https://github.com/btford/write-good

javascript
GH action: https://github.com/marketplace/actions/lint-markdown

https://github.com/jackdewinter/pymarkdown/tree/main

python
pypi - https://pypi.org/project/pymarkdownlnt/

https://github.com/DavidAnson/markdownlint

nodejs

I use markdownlint in my docs

maybe after footnote sorted you can enhance https://github.com/hellt/pymdowx-block-converter which is another important tool in the mkdocs toolchain  =)

@hellt
The markdown linting is more of a pain than I figured. (It's creating character and experience though. :rofl:)
Worked through a bunch of the md linting, but not all of it so far.
mdl-action is hard-coded to run against the current dir .
And the README.md has some warts still even after all the clean up I've done.

mdl doesn't like inline HTML, which is necessary to resize an image in README.md

one option is to leave the image in its original size

mdl doesn't like the long line for the HTML img tag in README.md

possibly remedied if I go with the full size image

you can disable rules in .mardownlint.yml to silence annoying things

you can disable rules in .mardownlint.yml to silence annoying things

Agreed.
I'm less concerned about disabling the inline HTML, but it seems like an issue to disable the line length checks.
With some enhancement to mdl-action now it supports specifying a directory :grinning:
I'll still probably see if there's a means to resize the image without having to upload a static one.
Realization:
Oh, the markdownlint I was using has *.rb files. Maybe I'm using the wrong one.
Is this an issue?
Would you be able to share the uses: line so I at least know what markdownlint action you meant?

I haven't used an action before
But if id do that I would probably install it and use it as a make target so that it can be called by a user outside of gh actions as well

I haven't used an action before But if id do that I would probably install it and use it as a make target so that it can be called by a user outside of gh actions as well

@hellt
Makes sense.
Totally agree. I was also thinking a next step would be to set up local testing as well.

I ran linting locally to fix up issues
Add GH Action to run on PR and so on
[soon in the future] Add a means for bundling local package management and testing

I'll investigate the Node.js version of markdownlint/markdownlint-cli2 since that uses .markdownlint.yml
:rocket: :moon: :ringed_planet:

Hello @hellt
I have the Markdown linting PR #19 ready for your review.
I have others staged as drafts since there will be merge conflicts (example being more than one modifies ci.yml).
Thank you!

@hellt
Does it make sense to lint the Dockerfile via GH Actions?
Thank you.
(If yes) Like the others, using Docker images...

https://github.com/replicatedhq/dockerfilelint

GH Action - https://github.com/marketplace/actions/docker-lint

https://github.com/hadolint/hadolint

GH Action - https://github.com/marketplace/actions/hadolint-action

I don't think so, docker file is very small in this instance


:sparkles: Add support for sharing user pages

Proposed changes

Renamed pushcheck to prepush for pre-push checks.
Made the articleCard component links conditional.
Add a "Share Link" button to the "Posts" page.
Rename the tags in button attributes of button attributes to p in order to fix Hydration Error.
Add "Back to the researches" button to the researches if user is not logged in.
Create /user/[id].tsx page to show user's researches.

Types of changes
What types of changes does your code introduce to research-box?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments
None.

Preview works fine.


ipython-notebook not found when creating the docker container in the getting-started section.

After navigating to docs/getting-started and calling $ docker-compose up, ipython-notebook doesn't have an installation candidate in the docker container.
  Could not find a version that satisfies the requirement ipython-notebook (from versions: )
No matching distribution found for ipython-notebook
You are using pip version 8.1.1, however version 20.3.3 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

The ipython-notebook package seems to have been removed. The notebook installation can be fixed by installing ipython[notebook] instead of ipython-notebook.
What do you think about this solution? I would be more than happy to open a PR with this change.

The ipython-notebook package seems to have been removed. The notebook installation can be fixed by installing ipython[notebook] instead of ipython-notebook.
What do you think about this solution? I would be more than happy to open a PR with this change.

I had to change the dockerfile too.
FROM ubuntu:16.04

RUN useradd -ms /bin/bash indy

# Install environment
RUN apt-get update -y && apt-get install -y \
	wget \
	python3.5 \
	python3-pip \
	python-setuptools \
	apt-transport-https \
	ca-certificates \
	software-properties-common

WORKDIR /home/indy
RUN pip3 install -Iv pip==19.1.1
RUN pip3 install -U \
	pip \
    ipython==7.9 \
	setuptools \
	jupyter \
	python3-indy==1.11.0

RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys CE7709D068DB5E88 \
    && add-apt-repository "deb https://repo.sovrin.org/sdk/deb xenial stable" \
    && apt-get update \
    && apt-get install -y \
    libindy=1.11.0

USER indy

EXPOSE 8888

I installed pip 19.1.1 because the latest version is incompatible with python v3.5 and the error message suggested upgrading pip from version 8.  I then removed the ipython-notebook line.  The getting started jupyter notebook then ran properly.

Someone addressed it in this unmerged pr https://github.com/hyperledger/indy-sdk/pull/2261


license in comments points to 404

/*
 * Copyright LWJGL. All rights reserved.
 * License terms: http://lwjgl.org/license.php
 */

[chris@xpslaptop ~]$ wget  http://lwjgl.org/license.php
--2016-08-03 12:46:52--  http://lwjgl.org/license.php
Resolving lwjgl.org (lwjgl.org)... <IP_ADDRESS>
Connecting to lwjgl.org (lwjgl.org)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://www.lwjgl.org/license.php [following]
--2016-08-03 12:46:52--  https://www.lwjgl.org/license.php
Resolving www.lwjgl.org (www.lwjgl.org)... <IP_ADDRESS>
Connecting to www.lwjgl.org (www.lwjgl.org)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2016-08-03 12:46:52 ERROR 404: Not Found.

Temporarily fixed with an NGINX rewrite ( 301 Moved Permanently ) to the correct URL https://www.lwjgl.org/license
@Spasi Please update license URL to avoid redirects ( one from http://lwjgl.org to https://www.lwjgl.org  and one for the actual path ).

While we're talking licence, on the footer of the lwjgl.org site it says "Licensed under GPL" shouldn't that say "Licensed under BSD" ?

@kappaOne It should! My bad.
https://github.com/LWJGL/lwjgl3-www/commit/9ec95247f5996fbe99b7fc7066d735a0aa6d3e07


IMAP Gmail - connection setup failed

Hello.
I'm trying to use the library to connect my gmail account, but i'm receiving the message error below.

Thu Nov 10 15:20:15 2022] <IP_ADDRESS>:57154 Accepted
[Thu Nov 10 15:20:16 2022] got an extra server challenge: eyJzdGF0dXMiOiI0MDAiLCJzY2hlbWVzIjoiQmVhcmVyIiwic2NvcGUiOiJodHRwczovL21haWwuZ29vZ2xlLmNvbS8ifQ==

[Thu Nov 10 15:20:16 2022] got failure response: NO [AUTHENTICATIONFAILED] Invalid credentials (Failure)

[Thu Nov 10 15:20:16 2022] PHP Fatal error:  Uncaught Webklex\PHPIMAP\Exceptions\AuthFailedException in /home/igor/projects/php-imap/src/Client.php:385
Stack trace:
#0 /home/igor/projects/php-imap/src/Client.php(371): Webklex\PHPIMAP\Client->authenticate()
#1 /home/igor/projects/php-imap/index.php(19): Webklex\PHPIMAP\Client->connect()
#2 {main}

Next Webklex\PHPIMAP\Exceptions\ConnectionFailedException: connection setup failed in /home/igor/projects/php-imap/src/Client.php:391
Stack trace:
#0 /home/igor/projects/php-imap/src/Client.php(371): Webklex\PHPIMAP\Client->authenticate()
#1 /home/igor/projects/php-imap/index.php(19): Webklex\PHPIMAP\Client->connect()
#2 {main}
  thrown in /home/igor/projects/php-imap/src/Client.php on line 391
[Thu Nov 10 15:20:16 2022] <IP_ADDRESS>:53416 [200]: GET / - Uncaught Webklex\PHPIMAP\Exceptions\AuthFailedException in /home/igor/projects/php-imap/src/Client.php:385
Stack trace:
#0 /home/igor/projects/php-imap/src/Client.php(371): Webklex\PHPIMAP\Client->authenticate()
#1 /home/igor/projects/php-imap/index.php(19): Webklex\PHPIMAP\Client->connect()
#2 {main}

Next Webklex\PHPIMAP\Exceptions\ConnectionFailedException: connection setup failed in /home/igor/projects/php-imap/src/Client.php:391
Stack trace:
#0 /home/igor/projects/php-imap/src/Client.php(371): Webklex\PHPIMAP\Client->authenticate()
#1 /home/igor/projects/php-imap/index.php(19): Webklex\PHPIMAP\Client->connect()
#2 {main}
  thrown in /home/igor/projects/php-imap/src/Client.php on line 391

My code:
use Webklex\PHPIMAP\ClientManager;

$cm = new ClientManager($options = []);

$client = $cm->make([
    'host' => 'imap.gmail.com',
    'port' => 993,
    'encryption' => 'ssl',
    'validate_cert' => true,
    'username' => 'username',
    'password' => 'password',
    'authentication' => 'oauth',
]);
$client->connect();
$folders = $client->getFolders('INBOX');
``

Could you please help me if i did something wrong in the configuration?
Thank you.
igor.

Hi @igordeveloper ,
please checkout this example: https://www.php-imap.com/examples/oauth
You'll need to provide either a dedicated app password or use the google auth flow to obtain a valid access token.
Best regards & happy coding,

You'll need to provide either a dedicated app password or use the google auth flow to obtain a valid access token.

Hi.
I'll check it.
Thank you for the quick reply,


Gives you the total score of the email

Gives you the total score of the email

yo i like your energy, like the direction we're going here but each line is a separate email


Include discipline incidents in the home page feed

Who is this PR for?
educators
What problem does this PR fix?
Show more of what we know about what's going on with students, improve zero-day for home page in new districts.
What does this PR do?
Adds discipline incidents into the home page feed.

Also factors out the formatting from EventNoteCard into FeedCardFrame for re-use in the incident card.  No regressions:

Checklists

[x] Author checked latest in IE - Home page
[x] Author included specs for new code

selfie; right now this is disabled everywhere, and can be enabled per-district with an env variable.  My intention is to switch it on just for New Bedford, and ship for Somerville and Demo next week.


Generator uses uppercase parameter name when using a field instead of a property

@pakrym, it's not an issue, but I found this unusual with the generator. When I changed to using a field, the parameter name casing was changed to PascalCase. Still internal/private accessibility, so not a problem.
Originally posted by @heaths in https://github.com/Azure/azure-sdk-for-net/pull/15950#discussion_r504894819

Closing for now. We can revisit this if this continues to be an issue.


add documentation

Add documentation for person-vehicle-bike-detection-crossroad-1016 model

Jenkins please retry a build

@ygnn123 please note that other models description have just empty Performance section. If you do not provide exact values here, it is better to left it empty instead of 'tbd'

Jenkins please retry a build

@ygnn123 please also note that new file should be added to index.md
10:23:07  person-vehicle-bike-detection-crossroad-1016 not in index.md file

Jenkins please retry a build

Jenkins please retry a build

Jenkins please retry a build

Fine by me.

@ygnn123 also change target branch to develop

Jenkins please retry a build

Jenkins please retry a build


Browser mode is flaky

Describe the bug
I'm writing a testsuite for aria behavior (in vanilla js). These tests require checking against DOM, such as document.activeElement to see if the expected element received focus.
While writing tests, I realized one of my tests started to fail. I was even more suspicious when I commented out the tests that happen before and my failing test become successful, huh?
I figured I could shuffle the tests with describe.shuffle() and yes, running them through shuffle makes them fail and succeed.
I also have some ideas, why that might be:

Some DOM operations are put on micro/macro task queue and need to be awaited to finish (closing and opening popovers as I do in the tests, wait for document.activeElement)
between suites, the browser isn't "resetted" and state leaks between them

Here is a video of me running tests (shuffle mode):
https://github.com/vitest-dev/vitest/assets/283700/09d838a7-e5d4-4e35-9e95-9b1fcaf836c1
Reproduction
My repro is the monorepo of my design system. Though the affected package in there is a leaf package. I committed the flaky state, here is the repro sha: https://github.com/hokulea/hokulea/tree/655f2ac11697dd5dc54bf2faafa56aceb142e40e
Repro steps:

Checkout the sha above
run pnpm install in the root
cd incubator/aria-navigator
run vitest in there (pnpm vitest:ui is what I use)

The affected tests are tests/menu/navigation.test.ts, the submenu navigation suite.
The test code is what matters, details the the things being tested shouldn't matter that much, but here is a summary for better understanding:

DOM event handlers
HTMLElement methods: focus(), showPopover(), hidePopover()
Popover API, more precise auto mode

System Info
System:
    OS: macOS 14.4.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 99.50 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.volta/tools/image/node/20.10.0/bin/node
    Yarn: 4.1.1 - ~/.volta/tools/image/yarn/4.1.1/bin/yarn
    npm: 10.2.3 - ~/.volta/tools/image/node/20.10.0/bin/npm
    pnpm: 8.15.1 - ~/.volta/tools/image/pnpm/8.15.1/bin/pnpm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 124.0.6367.158
    Edge: 124.0.2478.51
    Safari: 17.4.1
  npmPackages:
    @vitest/browser: ^1.6.0 => 1.6.0
    @vitest/coverage-istanbul: ^1.6.0 => 1.6.0
    @vitest/ui: ^1.6.0 => 1.6.0
    vite: ^5.2.6 => 5.2.8
    vitest: ^1.6.0 => 1.6.0

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I don't think that this flakiness is something that we can address on a runner level - if you need to wait for an event to resolve, then you should await until it happens - Vitest provides vi.waitFor utility for example. You also need to write tests isolated from one another - so one test doesn't affect the other.
What we will do in the future though is provide API to deal with events because dispatchEvent is not something that actually happens when user interacts with the web page - the most correct implementation would be to call Devtools protocol, because even a simple click can have a lot of sub-events and different behaviors depending on the browser and the element. For example, in the next version you should be able to use the new commands API: https://github.com/vitest-dev/vitest/pull/5097. In the future, it will be expanded to support more APIs.

Thanks for the explanation. I was writing tests for QUnit which does that cleanup and I incorrectly transported that mental model over. I massively restructured my tests and now it's clean and working.
Looking forward for the new commands API 👍
Can close this issue here.


usb->serial adapter with coreelec and hyperion.ng possible?

not sure if this is a feature request or a support question but... i have a FT232R USB UART adapter and a sk9822 LED stripe. thought i can connect the tx/rx from the usb adapter to the stripe. i have that but i dont know how i can now configure hyperion.ng to use that. is there some kind of wiki or irc or any other way to get some support?

just found hyperion-project.org, sorry ;)

just found hyperion-project.org, sorry ;)


Draw rotate option seems to be inverted

Android 13.1 ArrowOS
ImageToolbox 2.6.0a2
Option Draw > Lock draw orientation seems inverted:

when setting is off, the app does not rotate
when setting is enabled, the screen does rotate

Seems like the setting is inverted.

This setting meant to lock device orientation to drawing image orientation

That's how I understood the setting. It says If enabled in drawing mode, screen won't rotate.  But for me: when disabled, screen won't rotate. And when enabled screen will rotate from portrait to landscape. That seems wrong.

Wrong description👀

I will remove this setting maybe

Hmm, so screen would always rotate? If I can prevent rotation that would awesome.

fixedd kinda

ImageToolbox 2.6.0a3 behaves as expected. Thank you.


[MadNLPGPU] Refactoring - Part I

First part of MadNLPGPU's refactoring.

rename all kernels as _{name_of_function}_kernel!
move all code related to the KKT systems in a directory src/KKT
move the linear solvers in another directory src/LinearSolvers
format the code with JuliaFormatter.jl

Agreed with the direction, but I'd first do a minor release

LGTM!


App exec with env file

When calling kamal app exec for new non interactive containers, run the command per role on each server and include the role config including the environment.
Fixes: https://github.com/basecamp/kamal/issues/492

@djmb Thanks! This was a major blocker for my deployment setup. 1.1.0 was a very well one surprise!


phospholipid scramblase activity, odd comment

It's confusing to have all the stuff about flippases and floppases, on a term which is not a flippase or a floppase.
GO:0017128    phospholipid scramblase activity
Definition (GO:0017128 GONUTS page)
Catalysis of the movement of phospholipids from one membrane bilayer leaflet to the other, by an ATP-independent mechanism. PMID:20043909 PMID:20302864
Comments
Nomenclature note. Scramblases are ATP-independent, non-selective, inducing non-specific transbilayer movements across the membrane. Flippases and floppases are ATP-dependent transbilayer lipid translocators. According to an extensively used, though not universal, nomenclature, they catalyze lipid transfer towards the inward monolayer (flippases) or towards the outward monolayer (floppases). Some authors however use the name floppase to denote any enzyme catalyzing transbilayer lipid motion, in some cases even in the absence of ATP requirements (PMID 20043909).

Hi Val
having spent a considerable time making sure these terms were used appropriately perhaps some mention could be made of these sibling terms. If only to state that if there is evidence from the paper or from the domains of the protein/family members that it has ATPase activity then this term should not be used, and the siblings or parent considered?
Best
Ruth

perhaps  instead
Note. Scramblases are ATP-independent, non-selective, translocases inducing non-specific transbilayer movements across the membrane.  **if you require  ATP-**dependent transbilayer lipid translocators i.e. Flippases (catalyze lipid transfer towards the inward monolayer) or floppases  (towards the outward monolayer) please refer to GO:0140326 and descendants.
I think you should leave this part out:
Some authors however use the name floppase to denote any enzyme catalyzing transbilayer lipid motion, in some cases even in the absence of ATP requirements (PMID 20043909).
The precise defs and the  reinforcing comment should suffice. I don't think we should say " almost universal" we are with the consensus here.
Also  shouldn't this parent term
GO:0140303   intramembrane lipid transporter activity
have exact synonym "translocase" ?
What do you think?  . I couldn't at first figure out what the comment was trying to tell me, but figured it out because I knew the history.

@marcfeuermann and I worked on this together. The literature is using both a bit interchangeably, which is why we added this comment. It took Marc and I a while to figure out what it all meant.
If that comment is too confusing for users I can remove it.

I think a comment here is good. It just needs a little tweaking. There were definitely some words missing too !
I understood what the information was for but only because I had followed the topic and   updated  my annotations.  It just needs to be a bit  clearer. If I haven't got it quite right we can go through it when we next speak just to make sure  we are all on the right page. Maybe we could tag it onto the end of a transcription call, so Ruth can also  approve the comment?

Also  @marcfeuermann could you check my comments and suggest any revision?

Hi Val and all,
First of all, sorry for this late reply, busy times. I hope you are all doing fine. In the literature, the terms scramblase, flippase and floppase or often not used appropriately. Some papers use flippase (and others floppase) as a general term for all these activities. This is why we wanted to insist on the specificity of each by adding this note.
However, I may understand that the note is a little bit long, especially since it is not mentioning scramblases. I would not have any concern to leave out the last sentence, which is indeed not essential, but keep the rest.
Regards,
Marc.

I  would like to clarify. I think there should be a note. It's just that the note was also slightly confusing. It has a few problems . Some words are missing, and  it isn't immediately clear why the information is being provided. My solution might not be better but  it is a  slight improvement.
If we state the difference the final sentence should not be required. Adding it only points out that some people use the term incorrectly, and thereby makes the consensus definition fuzzy again.
However, if you think the final sentence
"Some authors however use the name floppase to denote any enzyme catalyzing transbilayer lipid motion, in some cases even in the absence of ATP requirements (PMID 20043909)."
is also useful, I don't have any objection to keeping this . It's was  the first part that was particularly  unclear.  As a reader I needed to know why this information was being provided in the scramblase  comment before 2 sentences describing flippases and floppases. I lost the thread and I needed to read it twice to get why this information was there, because this wasn't given until the end.

@pgaudet  this should be quick. I'm not so bothered about this, I just found the comment slightly confusing   for the term I was looking at. But if you put the missing words in I think it is fine.

New note is:
comment: Nomenclature note. Flippases and floppases are ATP-dependent transbilayer lipid translocators. According to an extensively used, though not universal, nomenclature, they catalyze lipid transfer towards the inward monolayer (flippases) or towards the outward monolayer (floppases). Scramblases are ATP-independent, non-selective, inducing non-specific transbilayer movements across the membrane. The direction of the translocation should be taken into account for annotation.
OK ???

I think this is fine. Note that the comment is on the related terms too, not just GO:0017128
so needs updating on all.


dlovell/nix commands

add some nix commands and fix others

I'll wait till #37 is merged so I can modify the .git-blame-ignore-revs file to include it (and any other similar commits I can find)


Add TREZOR ypub example

TREZOR example using an account ypub to generate receive addresses

Oh fantastic! Thanks for the pull request :)


Report time first for option --duration yes ?

Currently the console reporter reports test durations as:
prompt>TestCatch.exe -r console --duration yes [approx]

Some simple comparisons between doubles completed in 0.000123s
Approximate comparisons with different epsilons completed in 6e-005s
Approximate comparisons with floats completed in 5.7e-005s
Approximate comparisons with ints completed in 5.5e-005s
Approximate comparisons with mixed numeric types completed in 0.000105s
Use a custom approx completed in 0.00016s
Approximate PI completed in 7.2e-005s
===============================================================================
All tests passed (27 assertions in 7 test cases)

The presentation below seems easier to read and to sort:
prompt>TestCatch.exe -r console --duration yes [approx] | sort -n

0.055 ms: Approximate comparisons with ints
0.057 ms: Approximate comparisons with floats
0.06 ms: Approximate comparisons with different epsilons
0.072 ms: Approximate PI
0.105 ms: Approximate comparisons with mixed numeric types
0.123 ms: Some simple comparisons between doubles
0.16 ms: Use a custom approx
===============================================================================
0.632 ms: All tests passed (27 assertions in 7 test cases)

I'm wondering if this would matter to anyone?

+1

Someone is working on this already? I may try to implement it if nobody is already doing this.

I took a look at this and ended up with this
0.50439 s: AA
0.512456 s: A
1.00093 s: AB
1.00331 s: A
1.00156 s: BA
1.00743 s: B

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CatchWork.exe is a Catch v1.7.2 host application.
Run with -? for options

-------------------------------------------------------------------------------
B
  BB
-------------------------------------------------------------------------------
c:\users\xarn\documents\github\catchwork\catchwork\main.cpp(47)
...............................................................................

c:\users\xarn\documents\github\catchwork\catchwork\main.cpp(49): FAILED:
  REQUIRE( false )

0.173347 s: BB
0 s: B
0.001148 s: B
===============================================================================
test cases:  2 |  1 passed | 1 failed
assertions: 16 | 15 passed | 1 failed

I thought about changing the reported time to milliseconds, but then decided against it -- if your long running tests still finish in lot less than a second, then you probably don't care about how long they actually take.

@horenmar, if you want you can add this snippet (below). I think it ends up looking better:
	void printDuration(double duration){
		const char * unit = "s";

		if((duration * 1000) < 100.0){
			duration *= 1000;
			unit = "ms";
		}

		stream << duration << " " << unit;
	}

@paulobrizolara I'd prefer to keep the units uniform, to simplify possible parsing.

Well, i may be wrong, but I don't think this reporter is intended to machine processing.
Instead, i think its targeted for the developer.
So, IMHO the UX should be priority.
Anyway, congratulations for your work. This issue was open for more than 2 years! :open_mouth:

Thanks @paulobrizolara - @horenmar has been incredible at working through the backlog. See http://www.levelofindirection.com/journal/2017/1/19/catch-up.html for more.

Uou!
I am not using Catch to so many time, but i really likes it!
So i am very happy to see things progressing.
Congrats @philsquared, @horenmar and all community for the work! :+1:

Btw, @philsquared , do you think it worths to change the time units format (to something like the initial proposal), besides the possible problems with parsing?

I'm in two minds about it. On the one hand I agree that consistency is nice - and makes it easier even for human readers.
On the other hand most unit tests should run in ms, not seconds - and the small fractions look out of place when most, if not all, runtimes are so small. I'm not sure that standardising on ms is much better. And making it a command line option seems overkill. I'm not sure there's an easy answer - and nothing seems significantly better than the status quo (to me at least).

My opinion is that it is not meant for parsing for cases that really matter, but those use-cases could afford to parse ms/s/etc properly anyway. My expected use case is something along the lines of
SelfTest -d yes | sort -n -b, which will print out the longest running tests last, and which would get hopelessly confused if Catch switched between units according to the underlying value.
I agree that the current output could be improved, and I think that changing the output to use fixed format with 2 decimal places would be nicer than the current state, and I'll make the change before the next release, but I don't quite think that dynamic units are that improvement.*

Standardizing on milliseconds might be an improvement, that depends on how people want to use it -- do they care about which tests take so long, or do they really care about how long each test takes? After all, Catch is not a benchmarking library and should not be used as such.


WIP, TST: add Python 3.8 Win CI

Don't merge until there's more official word on Python 3.8 stability/full release in Azure pipelines: https://github.com/microsoft/azure-pipelines-image-generation/issues/1317
(see discussion there with i.e., Nathaniel et al.)

Add a 64-bit Python 3.8 Windows test
entry for SciPy in Azure CI; the Python 3.8
Windows builds in the wheels repo have been
causing sufficient difficulty to warrant
regression testing in the main repo

Related wheels PR: https://github.com/MacPython/scipy-wheels/pull/55

While we wait for stability, you could fix the mpl install line to be conditional on Python version. 3.5 has no rc0 candidate:
ERROR: Could not find a version that satisfies the requirement matplotlib==3.2.0rc1 ...

That's true -- I think we will also need a distributor init file for Python 3.8/Windows as well, as noted in https://github.com/MacPython/scipy-wheels/pull/55, because of the changes to DLL path resolution in Python 3.8.

Don't merge until there's more official word on Python 3.8 stability/full release in Azure pipelines: microsoft/azure-pipelines-image-generation#1317

FYI: Issue has been resolved, see https://github.com/microsoft/azure-pipelines-image-generation/issues/1317#issuecomment-551965427

Ok, I've revised based on the feedback above.
Note that I'm still expecting Python 3.8 Windows Azure to fail for one of two reasons:

The cross-linked issue still notes that the Windows vm images may still not be fully propagated with 3.8.
Once the above is resolved, I'm expecting around 173 DLL errors in Python 3.8/Windows CI job until I add a _distributor_init.py as was done for wheels repo (indeed, it will be reassuring to see that this is detected).

Looks like the 3.8 failure is about the pinned MPL version
https://dev.azure.com/scipy-org/SciPy/_build/results?buildId=3882&view=logs&jobId=4e749fca-3d34-5c5a-3ce5-4d1276511512

Yep, guess matplotlib 3.2.0rc2 isn't available on PyPI yet, so I've switched back to rc1 for now.
Hopefully we see the DLL failure on Windows/Python 3.8 now.

There we go, CI now exactly reproducing the 173 DLL errors on Python 3.8/Windows we saw in the wheels repo.
So, now the question is--should Azure CI do i.e., a shallow clone of the wheels repo to pull in _distributor_init.py & make sure it is still working well?
I suppose this may be nicer than keeping two potentially separate versions of the same file, as long as the copying from the wheels repo is not too expensive/error prone to happen over & over in CI..

So, now the question is--should Azure CI do i.e., a shallow clone of the wheels repo to pull in _distributor_init.py & make sure it is still working well?

that sounds like a nice idea to me

Thanks @tylerjereddy


Render-blocking css even prioritize_critical_css

Hi.
I have enabled prioritize_critical_css, but as per Pagespeed Insight following css loading render blocking. Anyway to defer this css?

https://www.drcrhub.com/wp-content/plugins/social-widget/A.style.css.pagespeed.cf.VwCAC9pbRMdnBl8Sr6K4.css

https://www.drcrhub.com/wp-content/themes/focus-pro/A.style.css.pagespeed.cf.PQud-w4WWumUcKt9tXIT.css

Hi @utags
You are using CloadFlare. Try to bypass the CF Cache. Whe you make request to your site w/o CF and see whats happend and solve any issue you had, then enable CF, but you need to configure some type of upstream cache. CF may store un-optimized or semi-optimezed resources and serve it as the final resource thing.
You are using some type of CF optimization tool, rocket-loader that may interfere w/ pagespeed javscript.....


Fixes for contentctl migration

A number of issues were caught by the new contentctl codebase.
While fixes were made that "resolve" these errors, we should ensure that these were actually errors and do not introduce regressions into the playbooks.

Site still generates fine, looks the same to me.
:shipit:

Based on this review, I have dropped the WIP / Work In Progress Tag


add tooling to find dead links

Add tooling to identify dead links - First output:
Checking Cloudhealth
Checking SegmentIO
Checking StackDriver
Checking Zencoder
URL: https://support.brightcove.com/using-zencoder-s3
Response Code: 404
----------------------
Checking Datadog
Checking Cloudability
URL: https://developers.cloudability.com/docs/vendor-credentials-end-point
Response Code: 404
----------------------
Checking Rackspace
Checking New Relic
Checking Brightcove
URL: https://support.brightcove.com/using-dynamic-ingest-s3
Response Code: 404
----------------------
Checking CloudCheckr
URL: https://support.cloudcheckr.com/cloudcheckr-api-userguide/cloudcheckr-admin-api-reference-guide/
Response Code: 302
----------------------
Checking SignifAI
Error connecting to URL: https://docs.signifai.io/docs/amazon-web-services
Error message: HTTPSConnectionPool(host='docs.signifai.io', port=443): Max retries exceeded with url: /docs/amazon-web-services (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x1039afd50>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known'))
----------------------
Checking ParkMyCloud
Checking CenturyLinkCloud
Checking ELB logs
Checking Redshift logs
Checking Billing
Checking skeddly
Checking freshservice
URL: https://support.freshservice.com/support/solutions/articles/207515-creating-a-role-arn-for-integrating-amazon-web-services-aws-in-freshservice
Response Code: 302
----------------------
Checking signalfx
URL: https://signalfx-product-docs.readthedocs-hosted.com/en/latest/getting-started/send-data.html
Response Code: 302
----------------------
Checking cloudsploit
Checking globus
Checking dynatrace
Checking deepsecurity
Checking cloudbreak
Checking teraproc
Error connecting to URL: http://www.teraproc.com/awskey/
Error message: HTTPConnectionPool(host='www.teraproc.com', port=80): Max retries exceeded with url: /awskey/ (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x103b07550>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known'))
----------------------
Checking orbitera
Error connecting to URL: https://support.orbitera.com/support/solutions/articles/147040-add-new-aws-accounts
Error message: HTTPSConnectionPool(host='support.orbitera.com', port=443): Max retries exceeded with url: /support/solutions/articles/147040-add-new-aws-accounts (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x103b07550>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known'))
----------------------
Checking redline13
URL: https://www.redline13.com/blog/aws-setup/
Response Code: 404
----------------------
Checking kochava
Checking instaclustr
Checking CloudTrail
Checking Summit Route
Checking TrendMicro
URL: https://help.deepsecurity.trendmicro.com/Add-Computers/add-aws.html
Response Code: 404
----------------------
Checking Convox
URL: https://convox.com/docs/aws-integration
Response Code: 404
----------------------
Checking Spotinst
Checking Redlock
Checking Sumo Logic
URL: https://help.sumologic.com/03Send-Data/Sources/02Sources-for-Hosted-Collectors/Amazon-Web-Services/Grant-Access-to-an-AWS-Product
Response Code: 302
----------------------
Checking Bridgecrew
Checking Lacework
Checking Onelogin
Checking nOps
URL: https://help.nops.io/manual_setup
Response Code: 404
----------------------
Checking Fivetran
URL: https://fivetran.com/docs/logs/cloudwatch/setup-guide
Response Code: 302
----------------------
Checking Rapid7
Checking Databricks
Checking Threat Stack
Checking Cloudyn
Checking Lucidchart
Checking Workato
Checking Palo Alto Networks
Checking CloudZero
URL: https://www.cloudzero.com/hubfs/CloudZero%20Configuration%20Guide%20-%20Automated.pdf
Response Code: 404
----------------------
Checking Cloudinary
Checking Tenable
Checking Stitch
Checking Emnify
Checking Qualys Cloud View
Checking Auth0
Checking Altus
Checking AlertLogic
Checking CloudConformity
URL: https://github.com/cloudconformity/documentation-api/blob/master/Accounts.md#update-account
Response Code: 404
----------------------
Checking Nessus AWS Connector
Checking Dome9 Arc
Checking FortiCASB
Checking FortiCWP
Checking Azure Sentinel
No source for Azure Sentinel
----------------------
Checking Azure Billing Management
Checking ADC Application Deployment, ADM Delivery Management
Checking CloudManager for CloudVolumes
Checking Axonius.com
No source for Axonius.com
----------------------
Checking Fugue
No source for Fugue
----------------------
Checking CloudPhysics
Checking QRadar
No source for QRadar
----------------------
Checking LogicMonitor
No source for LogicMonitor
----------------------
Checking MVision ePO
Error connecting to URL: https://docs.mcafee.com/bundle/prod-name-n.n.x-guide-type/page/GUID-9B6E696A-78DA-4F41-A0FC-39699DD39639.html
Error message: HTTPSConnectionPool(host='docs.mcafee.com', port=443): Max retries exceeded with url: /bundle/prod-name-n.n.x-guide-type/page/GUID-9B6E696A-78DA-4F41-A0FC-39699DD39639.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1002)')))
----------------------
Checking Cloud Workload Protection
Checking Cloud Workload Protection
No source for Cloud Workload Protection
----------------------
Checking Logz.io
No source for Logz.io
----------------------
Checking Xi Frame
No source for Xi Frame
----------------------
Checking CloudWisdom, metricly
No source for CloudWisdom, metricly
----------------------
Checking Rockset
No source for Rockset
----------------------
Checking CloudHiro
Error connecting to URL: https://cloudhiro.com/AWS/AWSRegistrationGuide.php
Error message: HTTPSConnectionPool(host='cloudhiro.com', port=443): Max retries exceeded with url: /AWS/AWSRegistrationGuide.php (Caused by SSLError(CertificateError("hostname 'cloudhiro.com' doesn't match '*.cloudhiro.com'")))
----------------------
Checking Densify
URL: https://www.densify.com/docs/Content/Data_Collection_for_Public_Cloud_Systems/AWS_Data_Collection_Prerequisites_for_an_IAM_Role.htm
Response Code: 404
----------------------
Checking Armor Anywhere
URL: https://docs.armor.com/pages/viewpage.action?pageId=20709565
Response Code: 302
----------------------
Checking Genys
Checking site24x7
No source for site24x7
----------------------
Checking ylastic
Checking qubole
Checking Cloudability
URL: https://developers.cloudability.com/docs/vendor-credentials-end-point
Response Code: 404
----------------------
Checking VManage
Checking Cloud Applicatoin Manager
Checking Cloudaware
No source for Cloudaware
----------------------
Checking Cloud Ranger
No source for Cloud Ranger
----------------------
Checking FoxPass
Checking Nirmata
URL: https://nirmata-documentation.readthedocs.io/en/latest/CloudProviders.html
Response Code: 404
----------------------
Checking GitLab
No source for GitLab
----------------------
Checking Snyk
Checking CloudCraft
No source for CloudCraft
----------------------
Checking JupiterOne
Checking rev.com
URL: https://www.rev.com/api/s3bucketpolicy
Response Code: 404
----------------------
Checking Funnel
Checking Domo
URL: https://knowledge.domo.com/Connect/Connecting_to_Data_with_Connectors/Configuring_Each_Connector/Connectors_for_File_Retrieval/Amazon_S3_AssumeRole_Connector
Response Code: 302
----------------------
Checking Atlas DataLake
No source for Atlas DataLake
----------------------
Checking Upsolver
No source for Upsolver
----------------------
Checking Weave Cloud
Checking ChaosSearch
Checking EDB Postgres
No source for EDB Postgres
----------------------
Checking TheGlobalSolutions.net
No source for TheGlobalSolutions.net
----------------------
Checking wpengine
Checking cloudsqueeze
No source for cloudsqueeze
----------------------
Checking ThingSpace
URL: https://thingspace.verizon.com/resources/documentation/cloudconnector/Getting_Started/Streaming_to_AWS/
Response Code: 302
----------------------
Checking Anodot
Checking MediaMath
URL: https://apidocs.mediamath.com/reporting/log-level-data-service/overview#data-security-and-authorization
Response Code: 404
----------------------
Checking Presidio
Invalid URL: customer IAM policy
Checking Checkpoint Cloudguard
Checking Cisco Umbrella
Checking Cloudflare
Checking [Deprecated] AWS Log delivery Service
Checking Epsagon
URL: https://docs.epsagon.com/docs/faq
Response Code: 404
----------------------
Checking Turbot
URL: https://turbot.com/v5/docs/integrations/aws/import-aws-account
Response Code: 302
----------------------
Checking Qualys AWS EC2 Connector
Checking API Gateway
Checking Slack EKM
Checking SSLMate
Checking SSLMate (Sandbox Site)

@z0ph What action would you imagine us taking when a link is dead?
I don't think we'd want to "age out" accounts, so the link dying likely doesn't change validity of inclusion
If we always want a valid link, I would generally prefer proactive automation (for example, archive.org'ing any link that is submitted) vs. reactive

I do not want to remove items because links no longer work, as folks probably still have trust policies in their environment for the related account IDs, and the purpose of this repo is to let people know what those are.  There may be a need for us to identify some accounts as known but no longer valid or various other categories (ex. known malicious), but for now, I think we should just leave these.  Some accounts may have new references, while others may be dead (ex. no one should have a trust relationship from my old Summit Route consulting business anymore).  Mostly the links have been to ensure that at some point in time there was an admission by a company that they owned the account ID.   As account IDs are not re-used, there shouldn't be any reason not to leave these.  So for now, I think we should just ignore these.

@0xdabbad00 a few of the entries that you removed from the Permiso data-set had links, but those links no longer have the account ID. At one point they did, otherwise the link wouldn't have been in the original data-set. Do we want to include a crawled-at time indicating the time when the URL did have the account ID information?


Default hierarchical_ingress_rules in fast networking stages don't pick up layer4_configs configuration

Hello,
The net-firewall-policy module is looking for layer4_configs under the match key but the default hierarchical ingress rules defined in the networking stages in fast — e.g. here —  have the layer4_configs at the same level as the match key so they are not applied.
I figure it's just an indentation error, I can submit a PR if you will.
Best,
Pierre

Good catch
I've submitted a fix in #1715


kobalt 0.720

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Thanks for your pull request! :tada: Homebrew thrives because of contributions like this one.

Thanks @tdsmith.
Did I make the commit in the wrong repo?

Nope! We split the repos since you sent this PR, so it was in the right place. PRs should land against homebrew-core in the future. :)

That’s what I suspected, will send my PR’s to homebrew-core next time.
Thanks!

--
Cédric
On Tue, Apr 5, 2016 at 4:12 AM, tim smith<EMAIL_ADDRESS>wrote:

Nope! We split the repos since you sent this PR, so it was in the right
place. PRs should land against homebrew-core in the future. :)
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/legacy-homebrew/pull/50634#issuecomment-205554642


(core): add_notifications method does not send notifications as expected

Describe the bug
add_notifications method in CICDPipelineStack creates the CodeStar notification but no notification is sent when the CodePipeline pipeline fails
How to Reproduce

Create a DDK CICD pipeline and add notifications

CICDPipelineStack(
...
.add_notifications()

An SNS topic should be created. Subscribe your email address to it
Fail the pipeline. The user expects an email to be sent but it never arrives

Expected behavior
An email is sent when the Pipeline fails
Your project
No response
Screenshots
No response
Environment
Provide your `pip list` output, particularly the version of the AWS DDK library you used. Providing this information may significantly improve resolution times.

OS
Mac
Python version
3.7
AWS DDK version
0.2.1
Additional context
No response

I imagine there's some issues with the SNS topic policy created, will investigate. Thanks for identifying..

Hmm @jaidisido I'm not able to replicate

Functionality confirmed working, unable to replicate.


Map Not Showing on Reload

I'm trying to use Angularjs-Google-Maps in comibination with ui-router. I'm getting a weird issue where the map is only partially appearing.
I've managed to resolve it by creating a directive that triggers a 'resize' event to repaint the map:
function autoRefresh() {
  return {
    restrict: 'A',
    link: function(scope, element, attrs) {
      scope.$on('$stateChangeSuccess', function(){
          google.maps.event.trigger(scope.map, 'resize');
          console.log("this works!");
      });
    }
  }
}

<map center="-34.397, 150.644" zoom="8" auto-refresh></map>

And this works great, once the initial page has loaded and I change the state, the map appears. But if I simply do a hard reload of the page in the browser, the map doesn't appear. I have to change the state before the map is visible.
Is there an alternative to '$stateChangeSuccess' that works on initial page load?
Any help is appreciated. Thanks in advance!

Add this to map tag, init-event="init-map"
and add this to your controller or any place desired; $scope.$broadcast('init-map') like in this example, https://github.com/allenhwkim/angularjs-google-maps/blob/82b5c10b6b00763f940430d95e8cb084105e3fce/testapp/map_lazy_init.html
The purpose of this is not to render map until an event is fired.


Add logging and parameters validation

Codecov Report

Merging #3 into master will increase coverage by 0.41%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   95.62%   96.03%   +0.41%
==========================================
  Files          12       12
  Lines         183      202      +19
==========================================
+ Hits          175      194      +19
  Misses          8        8

Impacted Files
Coverage Δ

lib/client/code_coverage_service.dart
100% <100%> (+11.76%)
:arrow_up:

lib/command/post/post_command.dart
97.43% <88.88%> (-2.57%)
:arrow_down:

lib/bitbucket_code_coverage_command_runner.dart
96.15% <93.75%> (-3.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e098e81...cf63826. Read the comment docs.


typechecker: Error when prefilling array in functions that don't throw

Prefilling an array is wrapped inside a TRY() in generated cpp code so its scope should throw
This also should fix issue #137

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@devBoi76 - Great, now can you squash the two commits into one? With that, I think we'll be okay

@devBoi76 - Great, now can you squash the two commits into one? With that, I think we'll be okay

Done
Thank's for pointing out these issues btw :)

Looks like you'll need to run cargo fmt on your code to make sure the Rust code is in the standard code formatting.

Looks like you'll need to run cargo fmt on your code to make sure the Rust code is in the standard code formatting.

Hi, I won't have access to my PC until Sunday because of IRL stuff so that's when I'll be able to fix it. Sorry for taking up so much time for a simple change, I'll make sure to remember all of these steps next time.

Ok, I ran rustfmt on the file so it should work now!

@devBoi76 - looks like you need to run cargo fmt on it


Release notes for Desktop Stable <IP_ADDRESS>

Release notes for Docker Desktop Stable <IP_ADDRESS> release

Need to add download URLs and release date when confirmed
The link to the Windows Home install topic will work when https://github.com/docker/docker.github.io/pull/10669 is merged.

Can you please add equivalent to https://github.com/docker/pinata/pull/13860 (in known issues)?


Inconsistent item counts with track_sizes

Describe the bug
Hello!
When running with the option --extended=track_sizes, item counts returned by the command stats sizes are sometimes incorrect after letting items in the cache expire via TTL.
This seems like a race condition updating the sizes histograms based on the output of stats sizes after all items have been expired from the cache:
$ printf 'stats sizes\r\n' | nc -N localhost 11211
STAT 3168<PHONE_NUMBER>
STAT 3456<PHONE_NUMBER>
END

Note that both these counts are 2^32-1, which makes sense if they were unsigned ints set to 0 and then decremented again.
According to stats items and lru_crawler, there aren't actually any items in the cache after letting items expire via TTL.
$ printf 'stats items\r\n' | nc -N localhost 11211
END

$ printf 'lru_crawler metadump all\r\n' | nc -N localhost 11211
END

For what it's worth, I'm able to fix the incorrect counts by adding locking around updates to the sizes histogram.
To Reproduce
Note that the steps below use a Go tool I've been using for testing, but anything that does lots of concurrent reads and writes should work.

After building from commit efee763c93249358ea5b3b42c7fd4e57e2599c30 (I don't think this specific commit is required, it's just what I've been using), start Memcached with the track_sizes option: ./memcached -v -m 1024 -I 64m --extended=track_sizes.
In the directory that contains the Memcached repo, check out jankcache.
Run the reads-and-writes.go tool to get and set Memcached source code in a local Memcached instance: go run tools/reads-and-writes.go ../memcached
Let the tool run for about 30 seconds and then stop it via ^C
Wait for the TTL of items in the cache to expire (5 minutes when using reads-and-writes.go).
Run stats sizes and confirm that counts of some sizes are not 0: printf 'stats sizes\r\n' | nc -N localhost 11211

Expected output
$ printf 'stats sizes\r\n' | nc -N localhost 11211
END

Actual output
$ printf 'stats sizes\r\n' | nc -N localhost 11211
STAT 3168<PHONE_NUMBER>
STAT 3456<PHONE_NUMBER>
END

System Information

OS/Distro: Ubuntu
Version of OS/distro: Ubuntu 22.04.2 LTS
Version of memcached: master, efee763c93249358ea5b3b42c7fd4e57e2599c30
Hardware detail: 5.15.0-76-generic #83-Ubuntu SMP Thu Jun 15 19:16:32 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Detail (please include!)
/proc/cpuinfo
processor       : 0
vendor_id       : GenuineIntel
cpu family      : 6
model           : 140
model name      : 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz
stepping        : 1
microcode       : 0xa6
cpu MHz         : 3000.000
cache size      : 12288 KB
physical id     : 0
siblings        : 8
core id         : 0
cpu cores       : 4
apicid          : 0
initial apicid  : 0
fpu             : yes
fpu_exception   : yes
cpuid level     : 27
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l2 invpcid_single cdp_l2 ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves split_lock_detect dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq rdpid movdiri movdir64b fsrm avx512_vp2intersect md_clear flush_l1d arch_capabilities
vmx flags       : vnmi preemption_timer posted_intr invvpid ept_x_only ept_ad ept_1gb flexpriority apicv tsc_offset vtpr mtf vapic ept vpid unrestricted_guest vapic_reg vid ple shadow_vmcs pml ept_mode_based_exec tsc_scaling
bugs            : spectre_v1 spectre_v2 spec_store_bypass swapgs eibrs_pbrsb
bogomips        : 5990.40
clflush size    : 64
cache_alignment : 64
address sizes   : 39 bits physical, 48 bits virtual
power management:

stats
STAT pid 48821
STAT uptime 843
STAT time<PHONE_NUMBER>
STAT version 1.6.17_127_gefee763
STAT libevent 2.1.12-stable
STAT pointer_size 64
STAT rusage_user 12.505970
STAT rusage_system 39.869818
STAT max_connections 1024
STAT curr_connections 3
STAT total_connections 23
STAT rejected_connections 0
STAT connection_structures 13
STAT response_obj_oom 0
STAT response_obj_count 1
STAT response_obj_bytes 65536
STAT read_buf_count 58
STAT read_buf_bytes 950272
STAT read_buf_bytes_free 868352
STAT read_buf_oom 0
STAT reserved_fds 20
STAT cmd_get 6229419
STAT cmd_set 623548
STAT cmd_flush 0
STAT cmd_touch 0
STAT cmd_meta 0
STAT get_hits 6228371
STAT get_misses 1048
STAT get_expired 0
STAT get_flushed 0
STAT delete_misses 0
STAT delete_hits 0
STAT incr_misses 0
STAT incr_hits 0
STAT decr_misses 0
STAT decr_hits 0
STAT cas_misses 0
STAT cas_hits 0
STAT cas_badval 0
STAT touch_hits 0
STAT touch_misses 0
STAT store_too_large 0
STAT store_no_memory 0
STAT auth_cmds 0
STAT auth_errors 0
STAT bytes_read<PHONE_NUMBER>4
STAT bytes_written<PHONE_NUMBER>03
STAT limit_maxbytes<PHONE_NUMBER>
STAT accepting_conns 1
STAT listen_disabled_num 0
STAT time_in_listen_disabled_us 0
STAT threads 4
STAT conn_yields 0
STAT hash_power_level 16
STAT hash_bytes 524288
STAT hash_is_expanding 0
STAT slab_reassign_rescues 0
STAT slab_reassign_chunk_rescues 0
STAT slab_reassign_evictions_nomem 0
STAT slab_reassign_inline_reclaim 0
STAT slab_reassign_busy_items 0
STAT slab_reassign_busy_deletes 0
STAT slab_reassign_running 0
STAT slabs_moved 0
STAT lru_crawler_running 0
STAT lru_crawler_starts 19
STAT lru_maintainer_juggles 177049
STAT malloc_fails 0
STAT log_worker_dropped 0
STAT log_worker_written 0
STAT log_watcher_skipped 0
STAT log_watcher_sent 0
STAT log_watchers 0
STAT unexpected_napi_ids 0
STAT round_robin_fallback 0
STAT bytes 0
STAT curr_items 0
STAT total_items 623548
STAT slab_global_page_pool 0
STAT expired_unfetched 3
STAT evicted_unfetched 0
STAT evicted_active 0
STAT evictions 0
STAT reclaimed 147
STAT crawler_reclaimed 0
STAT crawler_items_checked 868
STAT lrutail_reflocked 10701171
STAT moves_to_cold 2498082
STAT moves_to_warm 2393194
STAT moves_within_lru 920608
STAT direct_reclaims 0
STAT lru_bumps_dropped 0
END

stats settings
STAT maxbytes<PHONE_NUMBER>
STAT maxconns 1024
STAT tcpport 11211
STAT udpport 0
STAT inter NULL
STAT verbosity 1
STAT oldest 0
STAT evictions on
STAT domain_socket NULL
STAT umask 700
STAT shutdown_command no
STAT growth_factor 1.25
STAT chunk_size 48
STAT num_threads 4
STAT num_threads_per_udp 4
STAT stat_key_prefix :
STAT detail_enabled no
STAT reqs_per_event 20
STAT cas_enabled yes
STAT tcp_backlog 1024
STAT binding_protocol auto-negotiate
STAT auth_enabled_sasl no
STAT auth_enabled_ascii no
STAT item_size_max 67108864
STAT maxconns_fast yes
STAT hashpower_init 0
STAT slab_reassign yes
STAT slab_automove 1
STAT slab_automove_ratio 0.80
STAT slab_automove_window 30
STAT slab_chunk_max 524288
STAT lru_crawler yes
STAT lru_crawler_sleep 100
STAT lru_crawler_tocrawl 0
STAT tail_repair_time 0
STAT flush_enabled yes
STAT dump_enabled yes
STAT hash_algorithm murmur3
STAT lru_maintainer_thread yes
STAT lru_segmented yes
STAT hot_lru_pct 20
STAT warm_lru_pct 40
STAT hot_max_factor 0.20
STAT warm_max_factor 2.00
STAT temp_lru no
STAT temporary_ttl 61
STAT idle_timeout 0
STAT watcher_logbuf_size 262144
STAT worker_logbuf_size 65536
STAT read_buf_mem_limit 0
STAT track_sizes yes
STAT inline_ascii_response no
STAT ext_item_size 512
STAT ext_item_age<PHONE_NUMBER>
STAT ext_low_ttl 0
STAT ext_recache_rate 2000
STAT ext_wbuf_size 4194304
STAT ext_compact_under 0
STAT ext_drop_under 0
STAT ext_max_sleep 1000000
STAT ext_max_frag 0.80
STAT slab_automove_freeratio 0.010
STAT ext_drop_unread no
STAT proxy_enabled no
STAT proxy_uring_enabled no
STAT num_napi_ids (null)
STAT memory_file (null)
END

stats slabs
STAT 6:chunk_size 304
STAT 6:chunks_per_page 3449
STAT 6:total_pages 1
STAT 6:total_chunks 3449
STAT 6:used_chunks 0
STAT 6:free_chunks 3449
STAT 6:free_chunks_end 0
STAT 6:get_hits 42374
STAT 6:cmd_set 4236
STAT 6:delete_hits 0
STAT 6:incr_hits 0
STAT 6:decr_hits 0
STAT 6:cas_hits 0
STAT 6:cas_badval 0
STAT 6:touch_hits 0
STAT 7:chunk_size 384
STAT 7:chunks_per_page 2730
STAT 7:total_pages 1
STAT 7:total_chunks 2730
STAT 7:used_chunks 0
STAT 7:free_chunks 2730
STAT 7:free_chunks_end 0
STAT 7:get_hits 211836
STAT 7:cmd_set 20846
STAT 7:delete_hits 0
STAT 7:incr_hits 0
STAT 7:decr_hits 0
STAT 7:cas_hits 0
STAT 7:cas_badval 0
STAT 7:touch_hits 0
STAT 8:chunk_size 480
STAT 8:chunks_per_page 2184
STAT 8:total_pages 1
STAT 8:total_chunks 2184
STAT 8:used_chunks 0
STAT 8:free_chunks 2184
STAT 8:free_chunks_end 0
STAT 8:get_hits 42363
STAT 8:cmd_set 4130
STAT 8:delete_hits 0
STAT 8:incr_hits 0
STAT 8:decr_hits 0
STAT 8:cas_hits 0
STAT 8:cas_badval 0
STAT 8:touch_hits 0
STAT 9:chunk_size 600
STAT 9:chunks_per_page 1747
STAT 9:total_pages 1
STAT 9:total_chunks 1747
STAT 9:used_chunks 0
STAT 9:free_chunks 1747
STAT 9:free_chunks_end 0
STAT 9:get_hits 42377
STAT 9:cmd_set 4187
STAT 9:delete_hits 0
STAT 9:incr_hits 0
STAT 9:decr_hits 0
STAT 9:cas_hits 0
STAT 9:cas_badval 0
STAT 9:touch_hits 0
STAT 10:chunk_size 752
STAT 10:chunks_per_page 1394
STAT 10:total_pages 1
STAT 10:total_chunks 1394
STAT 10:used_chunks 0
STAT 10:free_chunks 1394
STAT 10:free_chunks_end 0
STAT 10:get_hits 127085
STAT 10:cmd_set 12925
STAT 10:delete_hits 0
STAT 10:incr_hits 0
STAT 10:decr_hits 0
STAT 10:cas_hits 0
STAT 10:cas_badval 0
STAT 10:touch_hits 0
STAT 11:chunk_size 944
STAT 11:chunks_per_page 1110
STAT 11:total_pages 1
STAT 11:total_chunks 1110
STAT 11:used_chunks 0
STAT 11:free_chunks 1110
STAT 11:free_chunks_end 0
STAT 11:get_hits 381329
STAT 11:cmd_set 38108
STAT 11:delete_hits 0
STAT 11:incr_hits 0
STAT 11:decr_hits 0
STAT 11:cas_hits 0
STAT 11:cas_badval 0
STAT 11:touch_hits 0
STAT 12:chunk_size 1184
STAT 12:chunks_per_page 885
STAT 12:total_pages 1
STAT 12:total_chunks 885
STAT 12:used_chunks 0
STAT 12:free_chunks 885
STAT 12:free_chunks_end 0
STAT 12:get_hits 169493
STAT 12:cmd_set 16858
STAT 12:delete_hits 0
STAT 12:incr_hits 0
STAT 12:decr_hits 0
STAT 12:cas_hits 0
STAT 12:cas_badval 0
STAT 12:touch_hits 0
STAT 13:chunk_size 1480
STAT 13:chunks_per_page 708
STAT 13:total_pages 1
STAT 13:total_chunks 708
STAT 13:used_chunks 0
STAT 13:free_chunks 708
STAT 13:free_chunks_end 0
STAT 13:get_hits 381348
STAT 13:cmd_set 38179
STAT 13:delete_hits 0
STAT 13:incr_hits 0
STAT 13:decr_hits 0
STAT 13:cas_hits 0
STAT 13:cas_badval 0
STAT 13:touch_hits 0
STAT 14:chunk_size 1856
STAT 14:chunks_per_page 564
STAT 14:total_pages 1
STAT 14:total_chunks 564
STAT 14:used_chunks 0
STAT 14:free_chunks 564
STAT 14:free_chunks_end 0
STAT 14:get_hits 254249
STAT 14:cmd_set 25578
STAT 14:delete_hits 0
STAT 14:incr_hits 0
STAT 14:decr_hits 0
STAT 14:cas_hits 0
STAT 14:cas_badval 0
STAT 14:touch_hits 0
STAT 15:chunk_size 2320
STAT 15:chunks_per_page 451
STAT 15:total_pages 1
STAT 15:total_chunks 451
STAT 15:used_chunks 0
STAT 15:free_chunks 451
STAT 15:free_chunks_end 0
STAT 15:get_hits 211860
STAT 15:cmd_set 21110
STAT 15:delete_hits 0
STAT 15:incr_hits 0
STAT 15:decr_hits 0
STAT 15:cas_hits 0
STAT 15:cas_badval 0
STAT 15:touch_hits 0
STAT 16:chunk_size 2904
STAT 16:chunks_per_page 361
STAT 16:total_pages 1
STAT 16:total_chunks 361
STAT 16:used_chunks 0
STAT 16:free_chunks 361
STAT 16:free_chunks_end 0
STAT 16:get_hits 211861
STAT 16:cmd_set 21301
STAT 16:delete_hits 0
STAT 16:incr_hits 0
STAT 16:decr_hits 0
STAT 16:cas_hits 0
STAT 16:cas_badval 0
STAT 16:touch_hits 0
STAT 17:chunk_size 3632
STAT 17:chunks_per_page 288
STAT 17:total_pages 1
STAT 17:total_chunks 288
STAT 17:used_chunks 0
STAT 17:free_chunks 288
STAT 17:free_chunks_end 0
STAT 17:get_hits 508378
STAT 17:cmd_set 51406
STAT 17:delete_hits 0
STAT 17:incr_hits 0
STAT 17:decr_hits 0
STAT 17:cas_hits 0
STAT 17:cas_badval 0
STAT 17:touch_hits 0
STAT 18:chunk_size 4544
STAT 18:chunks_per_page 230
STAT 18:total_pages 1
STAT 18:total_chunks 230
STAT 18:used_chunks 0
STAT 18:free_chunks 230
STAT 18:free_chunks_end 0
STAT 18:get_hits 211771
STAT 18:cmd_set 21215
STAT 18:delete_hits 0
STAT 18:incr_hits 0
STAT 18:decr_hits 0
STAT 18:cas_hits 0
STAT 18:cas_badval 0
STAT 18:touch_hits 0
STAT 19:chunk_size 5680
STAT 19:chunks_per_page 184
STAT 19:total_pages 1
STAT 19:total_chunks 184
STAT 19:used_chunks 0
STAT 19:free_chunks 184
STAT 19:free_chunks_end 0
STAT 19:get_hits 169491
STAT 19:cmd_set 16904
STAT 19:delete_hits 0
STAT 19:incr_hits 0
STAT 19:decr_hits 0
STAT 19:cas_hits 0
STAT 19:cas_badval 0
STAT 19:touch_hits 0
STAT 20:chunk_size 7104
STAT 20:chunks_per_page 147
STAT 20:total_pages 1
STAT 20:total_chunks 147
STAT 20:used_chunks 0
STAT 20:free_chunks 147
STAT 20:free_chunks_end 0
STAT 20:get_hits 381309
STAT 20:cmd_set 37823
STAT 20:delete_hits 0
STAT 20:incr_hits 0
STAT 20:decr_hits 0
STAT 20:cas_hits 0
STAT 20:cas_badval 0
STAT 20:touch_hits 0
STAT 21:chunk_size 8880
STAT 21:chunks_per_page 118
STAT 21:total_pages 1
STAT 21:total_chunks 118
STAT 21:used_chunks 0
STAT 21:free_chunks 118
STAT 21:free_chunks_end 0
STAT 21:get_hits 296597
STAT 21:cmd_set 29574
STAT 21:delete_hits 0
STAT 21:incr_hits 0
STAT 21:decr_hits 0
STAT 21:cas_hits 0
STAT 21:cas_badval 0
STAT 21:touch_hits 0
STAT 22:chunk_size 11104
STAT 22:chunks_per_page 94
STAT 22:total_pages 1
STAT 22:total_chunks 94
STAT 22:used_chunks 0
STAT 22:free_chunks 94
STAT 22:free_chunks_end 0
STAT 22:get_hits 169507
STAT 22:cmd_set 16735
STAT 22:delete_hits 0
STAT 22:incr_hits 0
STAT 22:decr_hits 0
STAT 22:cas_hits 0
STAT 22:cas_badval 0
STAT 22:touch_hits 0
STAT 23:chunk_size 13880
STAT 23:chunks_per_page 75
STAT 23:total_pages 1
STAT 23:total_chunks 75
STAT 23:used_chunks 0
STAT 23:free_chunks 75
STAT 23:free_chunks_end 0
STAT 23:get_hits 338940
STAT 23:cmd_set 34021
STAT 23:delete_hits 0
STAT 23:incr_hits 0
STAT 23:decr_hits 0
STAT 23:cas_hits 0
STAT 23:cas_badval 0
STAT 23:touch_hits 0
STAT 24:chunk_size 17352
STAT 24:chunks_per_page 60
STAT 24:total_pages 1
STAT 24:total_chunks 60
STAT 24:used_chunks 0
STAT 24:free_chunks 60
STAT 24:free_chunks_end 0
STAT 24:get_hits 338958
STAT 24:cmd_set 33979
STAT 24:delete_hits 0
STAT 24:incr_hits 0
STAT 24:decr_hits 0
STAT 24:cas_hits 0
STAT 24:cas_badval 0
STAT 24:touch_hits 0
STAT 25:chunk_size 21696
STAT 25:chunks_per_page 48
STAT 25:total_pages 1
STAT 25:total_chunks 48
STAT 25:used_chunks 0
STAT 25:free_chunks 48
STAT 25:free_chunks_end 0
STAT 25:get_hits 338991
STAT 25:cmd_set 34274
STAT 25:delete_hits 0
STAT 25:incr_hits 0
STAT 25:decr_hits 0
STAT 25:cas_hits 0
STAT 25:cas_badval 0
STAT 25:touch_hits 0
STAT 26:chunk_size 27120
STAT 26:chunks_per_page 38
STAT 26:total_pages 1
STAT 26:total_chunks 38
STAT 26:used_chunks 0
STAT 26:free_chunks 38
STAT 26:free_chunks_end 0
STAT 26:get_hits 254260
STAT 26:cmd_set 25411
STAT 26:delete_hits 0
STAT 26:incr_hits 0
STAT 26:decr_hits 0
STAT 26:cas_hits 0
STAT 26:cas_badval 0
STAT 26:touch_hits 0
STAT 27:chunk_size 33904
STAT 27:chunks_per_page 30
STAT 27:total_pages 1
STAT 27:total_chunks 30
STAT 27:used_chunks 0
STAT 27:free_chunks 30
STAT 27:free_chunks_end 0
STAT 27:get_hits 296587
STAT 27:cmd_set 29668
STAT 27:delete_hits 0
STAT 27:incr_hits 0
STAT 27:decr_hits 0
STAT 27:cas_hits 0
STAT 27:cas_badval 0
STAT 27:touch_hits 0
STAT 28:chunk_size 42384
STAT 28:chunks_per_page 24
STAT 28:total_pages 1
STAT 28:total_chunks 24
STAT 28:used_chunks 0
STAT 28:free_chunks 24
STAT 28:free_chunks_end 0
STAT 28:get_hits 211876
STAT 28:cmd_set 21270
STAT 28:delete_hits 0
STAT 28:incr_hits 0
STAT 28:decr_hits 0
STAT 28:cas_hits 0
STAT 28:cas_badval 0
STAT 28:touch_hits 0
STAT 29:chunk_size 52984
STAT 29:chunks_per_page 19
STAT 29:total_pages 1
STAT 29:total_chunks 19
STAT 29:used_chunks 0
STAT 29:free_chunks 19
STAT 29:free_chunks_end 0
STAT 29:get_hits 211844
STAT 29:cmd_set 21294
STAT 29:delete_hits 0
STAT 29:incr_hits 0
STAT 29:decr_hits 0
STAT 29:cas_hits 0
STAT 29:cas_badval 0
STAT 29:touch_hits 0
STAT 30:chunk_size 66232
STAT 30:chunks_per_page 15
STAT 30:total_pages 1
STAT 30:total_chunks 15
STAT 30:used_chunks 0
STAT 30:free_chunks 15
STAT 30:free_chunks_end 0
STAT 30:get_hits 254234
STAT 30:cmd_set 25471
STAT 30:delete_hits 0
STAT 30:incr_hits 0
STAT 30:decr_hits 0
STAT 30:cas_hits 0
STAT 30:cas_badval 0
STAT 30:touch_hits 0
STAT 31:chunk_size 82792
STAT 31:chunks_per_page 12
STAT 31:total_pages 1
STAT 31:total_chunks 12
STAT 31:used_chunks 0
STAT 31:free_chunks 12
STAT 31:free_chunks_end 0
STAT 31:get_hits 42377
STAT 31:cmd_set 4312
STAT 31:delete_hits 0
STAT 31:incr_hits 0
STAT 31:decr_hits 0
STAT 31:cas_hits 0
STAT 31:cas_badval 0
STAT 31:touch_hits 0
STAT 32:chunk_size 103496
STAT 32:chunks_per_page 10
STAT 32:total_pages 1
STAT 32:total_chunks 10
STAT 32:used_chunks 0
STAT 32:free_chunks 10
STAT 32:free_chunks_end 0
STAT 32:get_hits 42377
STAT 32:cmd_set 4187
STAT 32:delete_hits 0
STAT 32:incr_hits 0
STAT 32:decr_hits 0
STAT 32:cas_hits 0
STAT 32:cas_badval 0
STAT 32:touch_hits 0
STAT 35:chunk_size 202152
STAT 35:chunks_per_page 5
STAT 35:total_pages 1
STAT 35:total_chunks 5
STAT 35:used_chunks 0
STAT 35:free_chunks 5
STAT 35:free_chunks_end 0
STAT 35:get_hits 42358
STAT 35:cmd_set 4293
STAT 35:delete_hits 0
STAT 35:incr_hits 0
STAT 35:decr_hits 0
STAT 35:cas_hits 0
STAT 35:cas_badval 0
STAT 35:touch_hits 0
STAT 36:chunk_size 252696
STAT 36:chunks_per_page 4
STAT 36:total_pages 1
STAT 36:total_chunks 4
STAT 36:used_chunks 0
STAT 36:free_chunks 4
STAT 36:free_chunks_end 0
STAT 36:get_hits 42341
STAT 36:cmd_set 4253
STAT 36:delete_hits 0
STAT 36:incr_hits 0
STAT 36:decr_hits 0
STAT 36:cas_hits 0
STAT 36:cas_badval 0
STAT 36:touch_hits 0
STAT active_slabs 29
STAT total_malloced 30408704
END

Thanks!
Might take me a bit to get to this. I think hardly anyone has ever used the stats sizes command and I wrote it a very long time ago. It probably bitrotted.

Gave it a quick look and it does seem like I meant the feature to be "best effort". It's probably worth revisiting and either at least noting this or switching to atomics and noting that it has more potential performance impact. The original command had a massive performance impact (hung the instance for potentially tens of seconds if there were a lot of items) so I tried to rewrite it to be less taxing.
ie; it's also possible to turn it on and off during runtime, in which case it'll only collect data as things are added or removed. It's aytpical for people to fill something, empty the whole thing, then expect the numbers to make sense :)
Throwing a lock around them does make the numbers consistent but at too high of a cost.

Gave it a quick look and it does seem like I meant the feature to be "best effort".
<...>
Throwing a lock around them does make the numbers consistent but at too high of a cost.

Ah, I thought that might be the case. Thanks for taking a look!

Between the --help update and the explanation in this issue for others that might run into this, I'm good to close it if you are.

Thanks for the poke. usually I close the related issues when the release goes out but missed this one.

@dormando , @56quarters : Just wanted to ask what is the performance penalty for having this option enabled and running the command. Just if you could give an estimate or mention potential problems, it would be great. Say,

Can it increase the latency for get requests?
Does it increase CPU utilization noticeably?

@sergmour given the way it's implemented the overhead should be close to zero, maybe 1-2% at most if you run a lot of set traffic. it only affects set traffic.
if we implemented locks to make it more accurate it would be a bigger impact.

Thanks @dormando ! I totally agree with having stats as best-effort to avoid any overhead.
Sorry for being that meticulous, can you please clarify the overhead please:

No impact on "get" traffic at all, right ?
1-2% overhead on "set" traffic, is it latencies or CPU utilization or both?

@sergmour I can't really say what impact it would have since I have no idea what your traffic looks like. It can be turned on and off at runtime if you have CAS enabled; go ahead and try it out for a minute.
The feature only activates on sets. It should be low, I can't give exact values. I'd be shocked if you could measure a change in latency.

Thanks @dormando ! We'll try it.


Unknown waveshare driver variant epd2in13[.*]

Trying with this board: https://www.aliexpress.us/item/2251832623543336.html. Picked every variant of the 2.13" 250x122 Waveshare device.
2024-01-03 23:16:20
- Generating app: 351b3071-4b50-4471-b0f7-a94b4d94ba56 (unsplash)
2024-01-03 23:16:20
Unknown waveshare driver variant epd2in13

[...]

2024-01-03 23:17:24
- Generating app: 351b3071-4b50-4471-b0f7-a94b4d94ba56 (unsplash)
2024-01-03 23:17:24
Unknown waveshare driver variant epd2in13g

[...]

- Generating app: 351b3071-4b50-4471-b0f7-a94b4d94ba56 (unsplash)
2024-01-03 23:17:39
Unknown waveshare driver variant epd2in13_V2

[...]

- Generating app: 351b3071-4b50-4471-b0f7-a94b4d94ba56 (unsplash)
2024-01-03 23:17:50
Unknown waveshare driver variant epd2in13_V4

The fact that it doesn't know about the "driver variant" suggests the problem is not a mismatch with the hardware, but rather a problem with the software toolchain. But that's just speculation.

Indeed, this is a bug. More specifically, I rushed out the implementation with just two waveshare drivers, and left adding the remaining ones as one of the next todo items.
This blew up on HN faster than I thought, so it's not done yet. Essentially this folder needs a few extra files for all the drivers to work. The readme gives hints on how to do that. Feel free to have a look, or I'll get to it first chance I get, but not before tomorrow.

Good luck with the project! Was looking for something turnkey.

All 2-color and 3-color waveshare displays should now work.
I've added all the waveshare drivers I found under https://github.com/waveshareteam/e-Paper/tree/master/RaspberryPi_JetsonNano/c/lib
These are all the ones with the SPI interface on the list on any of their store pages.

Everything except these ones with "Parallel port" is now wired up.

The only problem is that I didn't implement any color reduction algorithms for the 4-color, 4-grayscale and 7-color displays yet. I sadly don't have any frames to test with. Thus this goes on the TODO list.
I do however also have one 2.13" Waveshare display, and got it working with the V3 driver.


CHEBI:88514, please check

Hi,
Please check CHEBI:88514, butyl formate, as it is used in a Rhea reaction.
Cheers,
Kristian

Hi Kristian,
Now done!
Cheers,
Gareth


Create AbstractAnvilSystemBase and supporting types

Ported over project agnostic features from the TwistedDOTS project
Added documentation and namespaces

What is the current behaviour?
N/A
What is the new behaviour?
AbstractAnvilSystemBase

Adds convenience methods to

Copy to/from singleton dynamic buffers
Build BufferFromSingleEntity<T> and ComponentDataFromSingleEntity<T>
Detect and error when a System's Dependency property has been overwritten without being chained or combined off it's previous value. (Only when ENABLE_UNITY_COLLECTIONS_CHECKS is present)

BufferFromSingleEntity<T> and ComponentDataFromSingleEntity<T>

Encapsulate the intent to read a buffer or component off of a single entity. This is used to reduce boilerplate in jobs that require a single value to be referenced along side a query and more clearly express intent.

What issues does this resolve?
None
What PRs does this depend on?

PR22 in TwistedDOTS

Does this introduce a breaking change?

[ ] Yes
[x] No - but you should probably change the base class of all your existing systems from SystemBase to AbstractAnvilSystemBase

Converted to Draft until TwistedDOTS PR is merged

Ready for review now

Wow, that was a lot of typos...Thanks for catching them!


Customer headers strips the character 's'

Hi,
Firstly, it is a great tool, thanks for open-sourcing.
The issue is that the --with-headers flag removes the character 's' in the header value.
--with-headers 'Accept-Version:test' ends up as Accept-Version: tet.
Best,
~ hb

Hi @HolyBugx
Thank you so much for reporting the issue.
It seems there was a typo in the header handling. I will fix it right away! 😄

Test

Hi @HolyBugx
The bug you reported appears to have been fixed, and closing the issue. It has been addressed in v0.9.1, and you can upgrade using the following method. If it happens to reoccur, please feel free to reopen the issue :D
# If you use home brew
brew upgrade

# If you do not see the updated version, please run this command.
brew update; brew upgrade

# Install with source
git clone https://github.com/hahwul/noir; cd noir
shards install
shards build


[Bug]:   in [Get start section ]in nav bar Improve Layout and Responsiveness of Sign-Up and Footer Sections

🐞 Bug Report

📋 Description
The layout of the sign-up form and footer section is not fully responsive. The form elements are slightly misaligned, and the footer content (specifically the "Contact Us" and social media icons) appears cramped on smaller screens.
⚙ Steps to Reproduce
Steps to reproduce the behavior:
Open the website on a mobile or tablet device.
Navigate to the sign-up form and footer section.
Observe the alignment and spacing issues on smaller screens.
✔ Expected Behavior
The sign-up form and footer should have proper alignment and spacing, adapting to different screen sizes without content overlap or cramping.
❌ Actual Behavior
The form fields and buttons in the sign-up form are misaligned. The footer content becomes cramped and disorganized, particularly on smaller screens, with social icons and the "Contact Us" section not spaced correctly.
📷 Screenshots
(Refer to the provided image for the current layout issue.)
🖥 Environment (if applicable):
OS: Windows, macOS, Linux
Browser: Chrome, Safari, Firefox
Version: Latest versions
🔧 Additional Information
The padding and margin inconsistencies might be the cause of this issue. Adjusting these styles and ensuring proper responsiveness across breakpoints should resolve the problem.

@skmirajulislam hello sir please assign me leval 3 or atleast level 2 for this issue because it take lot of time. It's help me to work with full motivation. Thank you


Refs in arrays not handled properly

I can't for the life of me figure out how to do a self-ref in array items.
When I use a string loader for the schema and it doesn't have any ids at all, I can handle recursion in objects by using "$ref":"#" to say "this same object".
For some reason, when used inside of the "items" property for an array, the meaning changes to be "the root schema".
This wouldn't be a problem, and isn't for most other validators, becuase instead of using #, you can simply point to #/definitions/.  Unfortunately, gojsonschema can't handle this and panics due to recursion causing stack overflow.
In the following schema, the definiting of "rule.composite" contains an array who's items can contain a "rule.composite".  If I change the ref to #, it fails validation, and if I change it to "rule.composite" it stack overflows...
{   "$schema": "http://json-schema.org/draft-04/schema#",   "type": "array",   "definitions": {     "rules.composite": {       "type": "object",       "properties": {         "conditions": {           "type": "array",           "items": {             "anyOf": [               {                 "$ref": "#/definitions/rules.composite"               },               {                 "$ref": "#/definitions/rules.condition"               }             ]           },           "minItems": 1         },         "match": {           "type": "string",           "pattern": "^all$|^any$|^none$"         }       },       "required": [         "match",         "conditions"       ]     },     "rules.condition": {       "type": "object",       "properties": {         "op": {           "type": "string",           "pattern": "^eq$|^neq$|^gt$|^lt$|^gte$|^lte$|^exists$|^notexists$"         },         "path": {           "type": "string"         },         "value": {}       },       "required": [         "path",         "op"       ]     },     "rule": {       "type": "object",       "properties": {         "condition": {           "type": "object",           "title": "CompositeOrCondition",           "anyOf": [             {               "$ref": "#/definitions/rules.composite"             },             {               "$ref": "#/definitions/rules.condition"             }           ]         }       },       "required": [         "condition"       ]     }   },   "items": {     "$ref": "#/definitions/rule"   } }
Here's an example payload:
[   {     "condition": {       "match": "all",       "conditions": [         {           "path": "user.system",           "op": "eq",           "value": true         },         {           "path": "user.bad",           "op": "notexists"         },         {           "match": "all",           "conditions": [             {               "path": "user.name",               "op": "exists"             },             {               "path": "user.username",               "op": "exists"             }           ]         }       ]     }   } ]
you can paste them both here to see the expected behavior:
https://www.jsonschemavalidator.net/

It's on the radar and it will be fixed by #196

@jdoklovic Looks like this was fixed. Can you confirm and if so close please? =]


Schedule a community meeting! 🦁🐯🦄

Hello to everyone involved / using this project!
I am David, one of the cotributors to this project and I would like to propose a video call to allow everyone to get to know each other and maybe, (if lucky) form a clear roadmap for this project.
I am personally very invested in this project as I am using it constantly in all of the projects I am working on, so I would love to see and meet whoever else that has any interest in this cool project!
Anyone interested, please use this doodle to vote on time in the next two weeks: https://doodle.com/poll/gz6rbygtuvka5x98
Any comments or suggestions are welcome!
Thanks!

Digging the initiative, let's get it done!

@TimMikeladze @pradel @darkbasic @Aetherall
The days that will be okay with everyone are:

Thu, Nov 9th
Mon, Nov 13th
Wed, Nov 15th
Thu, Nov 16th

Which timing will be best and will it work out this Thursday:

12:00 UTC+2 - 12:30 UTC+2
17:00 UTC+2 - 18:30 UTC+2
19:00 UTC+2 - 20:30 UTC+2

Let me know and please send me your email address so i'll send an invite.
Mine is on my github profile.

I prefer 17:00 UTC+2 - 18:30 UTC+2. Thursday is fine for me.
My email address is on my github profile, but I'm sending you an email anyway.

Thursday is perfect and all timings works for me :)

Thursday is good for me.
17:00 UTC + 2 - 18:30 UTC + 2
OR
19:00 UTC + 2 - 20:30 UTC + 2

Great! Sent everyone an invite!
Note that there is a google hangouts on the event.
I've created a small start of an agenda and goals doc - https://docs.google.com/document/d/18pQP5FWXGDLY21g7TNnrEz6-88cBAXr5wRWnzvxbDwE/edit?usp=sharing
Feel free to edit it as you wish! 🔈

@TimMikeladze @darkbasic @Aetherall
https://hangouts.google.com/hangouts/_/b5vkzhhclneohn67bdxmgaos7ye

I'm sorry but for some reason I didn't receive the google calendar notifications.
I tried to connect at 17:30 after I got the github notification, but it seems it was already too late.
Do someone have a recording of the meeting?

Sorry to hear that @darkbasic! I don't have any, maybe someone else..
I've added you now to the hangouts so we can speak in a chat environment.
We've updated the doc with the gist of what we plan on doing so definitely take a look and let us know what your thoughts!
Hope to see you next time in about two weeks!


Scenario 2 unworkable with 3rd party email gateway/security.

Update the documentation to indicate that "Scenario 2" is only available if the domain's MX records are pointing to Exchange Online. If the organization is leveraging a 3rd party email gateway, scenario 2 will not work. Please see support Case #:30772915.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 54783558-94f0-24ad-0fa3-1461a608fd10
Version Independent ID: 53ebf483-a8ef-e242-9a2c-c285bbce65da
Content: Choose the domain to use when creating Microsoft 365 groups
Content Source: microsoft-365/solutions/choose-domain-to-create-groups.md
Service: o365-administration
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@JLambEJG Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8988
Once the author approves, the changes will be live.
Thanks
Sri


DateComponents: Fix Overlapping accesses to 'self' warnings.

@swift-ci please test

I believe this code is shared with the overlay.

@spevans can you open a PR against https://github.com/apple/swift/blob/master/stdlib/public/SDK/Foundation/DateComponents.swift too?
@swift-ci please test and merge


Renaming folders not syncing

When I rename a folder (or sometimes even a file), this change is not reflected remotely. To get this to show, I have to manually add the now renamed folder to the workspace, and get my collaborator to remove the old named folder from the workspace (and then delete it).

@geoffreyd
What version of the plugin are you using?

1.5.1 but this was also happening on the 1.4.* versions

How are you renaming the folder? You need to right click on it, refactor -> rename. Doing it outside of IntelliJ wont work. We don't get events for that I don't think.

Yes, the renames where done from inside RubyMine using the refactor. We had to rename a number of folders, so we tested different ways, even having my team member disconnect and reconnect, but the new folder was never there until we manually added it to the workspace.

That's pretty strange since when I rename files it works. I wonder if you wouldn't mind sharing your intellij log with us when you tried this. Sorry for the late response. Is there any kind of exception there?

This is pretty old and I can't reproduce. Feel free to re-open it if you have additional information.  Thank you for letting us know!


Update pubspec.yaml

It looks a little odd to have our sources be the homepage, and I think flutter.io matches the author value better. WDYT?

As discussed, let's make it https://github.com/flutter/plugins .

Updated!


Fix intellisense errors by manually including TerminalAppLib's pch.h

Summary of the Pull Request
This is simply the solution to our intellisense errors as suggested in #6866. You can't just replace the pch.h's with lib/pch.h, because that fails to compile, because the compiler is looking for literally #include "pch.h". So If you include both, then the compiler will be happy, and intellisense will be happy.
PR Checklist

[x] Closes #6866
[x] I work here
[x] Tests/CI passed?
[ ] Requires documentation to be updated - sure doesn't

FYI in case you are interested in pushing this further- this approach will prevent IntelliSense from actually pre-compiling that header, losing out on that optimization. This means longer pauses after first opening a file, and after making "top-level" edits (i.e. outside the body of a function).
The rule of thumb we (the IntelliSense team) use here is that the build should still work with PCH disabled, and then IntelliSense should automatically work as well. If I understand correctly, then adding lib to TerminalAppLib's include paths shouldn't cause any conflicts (as there are no other header files there), and would allow everything to work.

FYI in case you are interested in pushing this further- this approach will prevent IntelliSense from actually pre-compiling that header, losing out on that optimization. This means longer pauses after first opening a file, and after making "top-level" edits (i.e. outside the body of a function).
The rule of thumb we (the IntelliSense team) use here is that the build should still work with PCH disabled, and then IntelliSense should automatically work as well. If I understand correctly, then adding lib to TerminalAppLib's include paths shouldn't cause any conflicts (as there are no other header files there), and would allow everything to work.

Neither @zadjii-msft or I can tell whether your suggestion means "use the include path INSTEAD of adding the extra PCH to all of the headers" or "use the include path IN ADDITION TO adding the extra PCH to all of the headers." Can you please clarify, @rpjohnst?

And you know what, I did try just adding $(OpenConsoleDir)\cascadia\TerminalApp\lib\; to <AdditionalIncludeDirectories> in TerminalApp.vcxproj, and removing the lib/pch.h line from TerminalPage.cpp, but that gave me the same list of Intellisense errors as always. Maybe I'm doing it wrong?

Ah, sorry for the confusion. I meant to suggest using the include path instead of adding the extra #include lines.
And now that you mention that you've tried that, I think I see why it didn't work- #include "pch.h" with "" instead of <> prioritizes the source file's directory over the include search paths, and the wrong PCH happens to be in the source file's directory.
So I tried adding $(OpenConsoleDir)\cascadia\TerminalApp\lib and replacing #include "pch.h" with #include <pch.h>" and that seems to be working. (Well, I'm now hitting a different bug where IntelliSense crashes on some coroutines stuff, which TerminalPage.cpp is full of, but at least it's not spitting out errors 🙂)

Okay, weird. I've tried that too, but now it seems that whenever I open a cpp file with the <pch.h> in it, it will intermittently have intellisense errors in it, until I load up the header for that file. Once intellisense has had a chance to parse the header too, it seems like the errors in the cpp file go away as well.
I have no idea if that's expected or not.

Hm, that's definitely not expected. A guess at what's happening- perhaps the cpp file you open finds the wrong pch.h, while the header finds the correct one. IntelliSense could then build a working PCH in response to opening the header, which could then be picked up by the cpp file when you return to it.
If so, one thing to double check is the order of the AdditionalIncludeDirectories list. Make sure lib is before the existing ... (Or even replace it, if that doesn't break anything else?) It might also help to temporarily disable PCH use project-wide and make sure the compiler can still find everything.
If that doesn't help, then maybe it's just some leftover state that would go away if you did "Project > Rescan File," restarted VS, and/or deleted the .vs directory. (Fair warning, that will reset a few things like the set of open files; if that's a problem then it may be enough to delete just .vs/<Project>/v16/ipch)

K well. I was having Intellisense issues and I merged this into my branch and they're gone. Well, Intellisense is still slow but that's par for a WinRT project. So I don't care if there's a better way, this is better than 100% broken as it is now.

It might be even easier to move the lib project into the TerminalApp/ folder and make a dll project that just dllizes it


{bp-15252} crypto/xform.c: migrate to SPDX identifier

Summary
NOTE
The code was reported as GPL by FOSS ID
and Xiaomi scanned the file xform.c with Black Duck Security and it showed that the license was BSD-3-Clause and no risk was reported.
Since there is no clause on the license it was concluded as 0BSD
Refference
https://github.com/apache/nuttx/pull/15252
Impact
RELEASE
Testing
CI

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements as described.  While it provides some information, it lacks crucial details.
Here's a breakdown of what's missing:

Summary:  While it explains the why (license clarification), it's missing the what and how.  What file(s) were modified?  What specific license text was changed? How was the determination of 0BSD reached (beyond referencing a seemingly unrelated PR)?

Impact:  Simply stating "RELEASE" is insufficient.  While a license change might not impact functionality, it does impact legal considerations.  The PR needs to explicitly state whether this change affects compatibility, requires documentation updates, etc.  Even if the answer is "NO" for most categories, it needs to be stated explicitly.

Testing: "CI" is also insufficient.  While Continuous Integration testing is important, the PR needs to show specific test results demonstrating that the change doesn't introduce regressions.  It should ideally include test commands used and relevant output, both before and after the change, even if those tests are simply verifying successful compilation.  If the change is purely related to licensing, the testing section could explain how the license was validated (e.g., using a specific tool).

In short, this PR needs to be significantly more detailed to meet the NuttX requirements.  It needs to clearly articulate the what, how, and provide concrete evidence of testing and consideration of the impact.