passing $_POST['code'] to check() is not always a string

So either please change the documentation/examples how to use the check() function or do a test within the check function if the parameter is really a string before passing it to validate().
If someone changes in a form input-tag from name="code" to name="code[blabla]", $_POST['code'] is passed as an array by PHP.
And then you get
Warning: strtolower() expects parameter 1 to be string, array given in /***/dapphp/securimage/securimage.php on line 2358
(securimage 3.6.5)

Admittedly, the documentation on the site is in need of an update, and the current state of things is to use the examples and code as docs (bad!).  But this does seem like a fair warning.
The phpDoc comments for the check() function reads:
    /**
     * Checks a given code against the correct value from the session and/or database.
     *
     * @param string $code      The captcha code to check
     * @param string $captchaId The ID of the captcha being checked
     * @param bool   $alwaysDelete True to delete captcha data after a failed guess.
     *   Useful if the form post results in a full page reload and the old captcha
     *   ID is never used again. Not so useful on Ajax forms.  (default false)
     *
     * <code>
     *     $code = $_POST['code'];
     *     $img  = new Securimage();
     *     if ($img->check($code) == true) {
     *         $captcha_valid = true;
     *     } else {
     *         $captcha_valid = false;
     *     }
     * </code>
     *
     * @return bool true if the given code was correct, false if not.
     */

Admittedly, the 'string' parameter hint is subtle as well.
I'm not against type checking the $code parameter explicitly to prevent this warning from strtolower.  Would a trigger_error to the effect of The $code parameter passed to Securimage::check() must be a string, $type given be sufficient in your opinion?

My error log is full of this error:
The $code parameter passed to Securimage::check() must be a string, NULL given in /home/xxxx/public_html/securimage/securimage.php on line 1278

My error log is full of this error:
The $code parameter passed to Securimage::check() must be a string, NULL given in /home/xxxx/public_html/securimage/securimage.php on line 1278

Yes I get this too.

I solved this problem. The problem is solved when I send the values sent from the form with GET instead of POST and receive them with GET.


Speed Up our rituals, iesnium and eldritch upgrades and otherthings

Sacrificial Bowls
Copper/Silver Sacrificial Bowl

Decorative, works like a sacrificial bowl
Craftable with a sacrificial bowl and an ingot

Iesnium Sacrificial Bowl

Works like a golden sacrificial bowl, but 4x faster
Afrit tier craft (golden bowl, iesnium block, spirit crystal, afrit essence, research dust)

Eldritch Chalice
(not really a bowl...)

Works like a golden sacrificial bowl, but makes the recipe instantly
Last tier craft (almost the old recipe of reinforced deepslate)
The (useful) trophy item

Pentacles
Accepts the Iesnium sacrificial bowl and the Eldritch Chalice in the middle, but the preview only shows the golden sacrificial bowl to avoid spoilers
Ritual Duration
Due to the new methods to speed up rituals, the entire ritual duration has been revised, now follows a formula based on type and tier (and reordered in the datagen file)

Summon: 60 x tier (half for time/weather jobs)
Possess: 30 x tier (half to random)
Familiar: 45 x tier
Craft: 30 x tier^2 + 30
Resurrect: 15 familiar, 30 allay
Repair: 5 chalk, 60 others
Wild: 90 mob (half to random), 180 item

Pedestals
Otherstone pedestal

Same hitbox as storage actuator

Silver pedestal

Decorative
Craft with other stone pedestal and silver ingot

Storage actuator base

Change to use copper in recipe and texture
Same hitbox as storage actuator

Stabilized storage actuator

Storage actuator with built-in 7x level 4 stabilizer (the amount is configurable)
Last tier craft (items corresponding to the setup and three echo dust)

Stabilizer level 0

Crafting material, to craft level 1 instead of pedestal
Decorative
Craft with other stone pedestal

Iesnium Anvil

Better Anvil
Indestructible
Reduced cost
Slower cost increase
Higher max level cost
Can exceeds max enchantment level by 1
Marid tier craft (anvil, 3x iesnium block, marid essence)

Otherglass

Invisible block, see with third eye
Shapped craft (4x iesnium nugget, 4x endstone dust, and glass)

Otherflower

Natural version generate in Grove
Craft with any Flower on spirit fire
Clone any dye, otherflower + dye (tag) -> 3 dye (vanilla)
Suspicius stews give third eye
Can be placed in flower pot

Iesnium Golem

Stronger iron golem
Invulnerable except to crouching player (one hit to dismiss, drops soul fragment)
Marid tier possess (3x iesnium block, marid essence, spirit crystal, nether star, sacrifice iron golem)

Rainbow and Void Chalks

Rainbow is for non foundation chalks, void is for all
Both eldritch tier
Can replace any glyph, but you choose the color using any dye
Can be used as brush (crouching)
Toggleable random color auto changing (flickering)

Pentacles
Accepts rainbow or void glyphs in any valid position, but the preview only shows default colored version to avoid confusion
Trinity gem

Upgraded Soul Gem
Separated blacklist entity (default empty, but ender dragon still uncatchable)
Last tier craft

Others

Easier reinforced deepslate recipe, low tier (wild) and cost (to 4x obsians, 4x iron bars, 1 deepslate, still needing warden sacrifice)
Reinforced deepslate will drop if mined with infused/iesnium pickaxe
Silver ore need iron tool (to match other mods that add silver)
Iesnium height changed, found in all nether y 0 ~ 128 (from 50 ~ -64, to match nether depth)
Fix djinni hat not moving with head (when pushing or hitting djinni)
Time and weather spirits work faster (reduced default max age)
Random special animals use wind charge instead firework, because using firework in a block don't work
Text "foil" to "glint" (match with visual settings)
Soul shard reset the fall distance and effects (to familiars don't get stuck in infinite death loop)
Books of binding (unbound) stack up 16
Guardian familiar fixes drop (only one soul shard instead two)
Guardian in ring no more grant infinity immortality (now auto-leaves the ring to does its normal function, limited uses)
Recipes for bee nest and bell (wild tier)
fix #1266
Dimensional mineshaft has redstone interactions (signal turn off, comparator can read lamp durability and occupied slots)
Coal crushing (missing recipe, discord report)
Tallow block (9 tallow), infinity burn (like netherhack), small speed and jump reduction when stand on top
Removed various warnings
Familiar goat gets random name when separated from chimera (shub niggurath keep this name after transform)

Image

(yeah, some blocks already exist, but I put to see all variations)

https://github.com/user-attachments/assets/7de61a7d-9bbc-44e4-a0d4-16fcd19f0411
Flickering glyphs (rainbow and void), the pentacle still working

@Eqis-Edu as always, fanstastic content!
Question about the stabilized actuator, does crafting keep the contained items?

i understand that otherglass is a bit special in that it is invisible compared to other (other-)items like otherstone and otherwood but do we really need to use iesnium (nuggets) and endstone (dust)? if throwing glass in spiritfire is a bit too.. much? how about acquiring it through a trader that you have to summon also like otherstone?
if yall think the recipe cost is justified then ignore my comment

Question about the stabilized actuator, does crafting keep the contained items?

The recipe use a new base and matrix, not the actuator (because it does not copy the items inside)

this morning when i woke up i had a thought: the stabilized storage actuator is really really nice but.. cant it be used like a shulker box? is having players taking a whole giant storage solution as an replacement backpack/shulker box really desirable?

@klikli-dev this PR is ready

Sorry I completely missed the ping (had a flood of other github mails in my inbox). Will look into this today!


AGU journals

tables for AGU journals.
Note: It is my first attempt to create this, so I hope there is not a lot of mistakes.

@rmzelle I use pspad (pspad.com), but after inserting in github I manually delete all "spacec" between items and use the TAB key. I can try to do it again, if there is still the same problem, I will try to insert text without editing.

Yes, still no tabs. The file on gdrive is good, though, so the problem here is the github editor. Try uploading without changes, if that doesn't work I'll just do this manually.

I just made a pull request for @libora, where I just copied the data from the Google Docs spreadsheet and pasted it into _journals.tab using the online editor: https://github.com/libora/journals/pull/1/files
Came out as tabs for me (Firefox, OS X). @libora, if you keep having issues you can always use a desktop program like GitHub Desktop.

@rmzelle I merged your PR just now (I am on cottage so I have only a few moments in the day when I have available PC). I do not use Github desktop because it is not working in my office (I think due proxy settings) and editing on the web interface of Github was OK till now.

@libora, thanks! Just added the styles. Just had to fix one ISSN that was missing a digit.
We often also add a brief README to mention where we got the metadata from. Did you just copy and paste all the journal titles and ISSNs, or did you find a catalog file somewhere?

@rmzelle I copy it directly from web page of journal and control it on Ulrichsweb.

and control it on Ulrichsweb.

Is that where you got the ISSNs from?

Yes


Add NSFW safe search filter to room directory landing page

Add NSFW safe search filter to room directory landing page.
We can put placeholder RoomCards for any rooms caught in the filter. This way our grid of rooms is even, we don't throw off pagination by trying to fetch more than needed and filter down, people are aware of content they are not seeing, and we don't upset our Google SEO rankings as much.

The Safe search toggle control above the grid of rooms:

What is considered NSFW?
Any room with NSFW, porn, nudes (maybe other keywords, sex, 18+) in the title or topic/description. This won't be exhaustive or completely effective but seems like it would do a decent job.
Dev notes
Default to safe search on which keeps it out of the query parameters by default.

Checkbox styles look something like http://jsfiddle.net/MadLittleMods/x049hLb7/
Prior art
Good language and semantics around how Google explains safe search.

hey @MadLittleMods I'd like to give this a try. But I'd like some clarification on what the t and vm are in the code render(t, vm) and how the app is doing a search for the rooms

clarification on what the t and vm are in the code render(t, vm)

@Jem256 It's from Hydrogen so you'll get a better picture by exploring that codebase first, see vector-im/hydrogen-web -> doc/UI/ui.md:

In views based on TemplateView, you will see a render method with a t argument.
t is TemplateBuilder object passed to the render function in TemplateView. It also takes a data object to render and bind to, often called vm, short for view model from the MVVM pattern Hydrogen uses.
-- vector-im/hydrogen-web -> doc/UI/ui.md#templateview

how the app is doing a search for the rooms

We're fetching the rooms on the room directory landing page in server/routes/room-directory-routes.js#L47 via fetchPublicRooms which uses the /publicRooms API endpoint. But as mentioned in the issue description, we don't need to change the way we fetch rooms at all.
We just need to detect that a room falls in the NSFW bucket and put the NSFW version of the RoomCard in place depending on whether safe search is enabled or not.


Add collection assertion overloads for IComparer

Create overloads of .Should().BeInAscendingOrder(...) and all related methods, specifically in the CollectionAssertions and GenericCollectionAssertions classes. Custom IComparer<T> objects can now be passed in.
Unit tests are included for the new methods.  :)

Good work!

Thanks!


eslint plugin lit-a11y fails on rule "role-has-required-aria-attrs" with role=option

Expected behavior
Element with role="option" and aria-selected="${etc}" passes rule "role-has-required-aria-attrs"
Actual Behavior
lit-a11y throws an error even though both role and aria-selected are set on the element.
Context
This is the template it errors on. I've triggered other variants of this rule (such as with role="combobox") and gotten those to pass, but this one still recurs.
html` <li
        @click=${this.selectOption}
        class="px-3 py-1 ${classMap(this.itemHighlighted(index))}"
        role="option"
        aria-selected="${this.itemSelected(option) ? 'true' : 'false'}"
      >
        ${this.itemDisplay(option)}
      </li>`

Which packages and versions are you using.
v1.0.1

I was unable to reproduce this locally:

Could you provide some more information, or potentially a minimal reproduction repo?


[framework] CoinMetadata -> Display

Description

Replaces CoinMetadata methods with a nested display
Allows creating a Display for any Coin<T>
Unifies approaches while preserving bits of the previous functionality
Improves testing setup by providing display::create_for_testing function

Test Plan

Display has its tests
CoinMetadata tests updated

Type of Change (Check all that apply)

[x] user-visible impact
[x] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

CoinMetadata now wraps Display
Display<Coin<T>> can be created for any T using the Supply<T>
Simplifies the coin module by replacing metadata edits with Display / VecMap.

I can approve, but might want some folks who know whats going on to take a look


Add "Campground" Type in Area

When outlining a campground (an area with several sites), I've seen several areas marked simply as "camp site", which is almost the equivalent of a "lot" in a "neighborhood"
Generally, these collections should be campgrounds and the individual parking pads/areas are camp sites.
Would like to see the addition of a "campground" type in areas, and possibly points.

Can you please give an example?

Here's two:
ILSB: https://www.openstreetmap.org/edit#map=17/42.43578/-87.80754
Indiana Dunes: https://www.openstreetmap.org/edit#map=17/41.65950/-87.05485

Looks like the tag is http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dcamp_site
and it is a point/area type for the perimeter of the camp ground.
Camp Pitches could be tagged with the proposed:  camp_site=camp_pitch
http://wiki.openstreetmap.org/wiki/Proposed_features/camp_site_pitch
I'd prefer not to add a preset for camp pitch unless there is significant tagging of these already in osm (taginfo would tell us these numbers, but it's currently down)

update now that taginfo is back up..
camp_site=camp_pitch has 1300+ uses, which is good enough for me.

Closed with these:
1692f5e Rename "Camp Site" to "Campground"
8cd2d70  Add preset for camp_site=camp_pitch for individual pitches
We did have the "Camp Site" tag already, but I renamed its label to say "Campground" to make it clearer that it is for the overall area.. Then I added "Camp Pitch" preset for tagging individual pitches.

I assume we can change it back to camp site for the  en-gb translation?

Yes, definitely.. we can change it on transifex tomorrow after the nightly job picks up the update.

I assume we can change it back to camp site for the en-gb translation?

FYI, I did this, it should show as "Camp Site" in en-GB

Thanks for getting this added into OSM!


Revert "Reland fix custom task shell doesn't work without manually passing in "run command" arg/flag"

Reverts microsoft/vscode#236058
This has broken something else #236657. Reverting before the break.

Thanks for the quick work!


Simplify get_offset_value_reference and add unit tests

Simplify get_offset_value_reference and add unit tests
Description

The logical test on base_addr and offset to know if we should return null is implicitly already provided by the Relocatable addition in the last step of the get_offset_value_reference function, so that I don't think it's needed is as an overhead.
Two unit tests are added to test edge configurations.

Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[X] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.
[ ] CHANGELOG has been updated.

This function no longer exists in the main branch


feat: samples for upcoming Istio tutorial

This PR contains Kubernetes manifest files for the Istio tutorial:

CR to install Kiali server with Kiali operator
Istio PeerAuthentication to configure STRICT mode for mTLS per namespace
Google Managed Prometheus CR PodMonitoring to collect Istio and Envoy proxy sidecar containers metrics.

A link to the tutorial will be provided as soon as it will be published.

Question: Is this tutorial specifically for Autopilot?
Asking because of the directory. If it's not an Autopilot-specific tutorial, maybe we could put it in e.g. service-mesh/istio-tutorial/?

Question: Is this tutorial specifically for Autopilot?
Asking because of the directory. If it's not an Autopilot-specific tutorial, maybe we could put it in e.g. service-mesh/istio-tutorial/?

I wrote a tutorial for Autopilot and didn't test it against Standard GKE. But instructions in the tutorial and these manifest files are not Autopilot specific (except the requirement to enable NET_ADMIN Linux capability and install Google-managed Prometheus) So I think I could move files to service-mesh/istio-tutorial

I'm wondering if the Bank of Anthos /extras folder is a better place for these samples. But approving because it was approved by Olivier (Bank of Anthos tech lead).
This looks ready to merge. @TheRealSpaceShip are we waiting on anything else? (May I go ahead and merge this?)
Heads-up: if you're including/embedding these samples in your tutorial, you'll need to use "region tags" similar to what we see here (region tags), here (embedding in tutorial) and here (tutorial code referencing region tag to create embedding). Ping me if you need assistance with this.

I'm fine with keeping the samples here or on BoA - but please do add the region tags :)

The samples are fine here, but +1 to adding region tags.

@TheRealSpaceShip please rebase and merge

@TheRealSpaceShip this is still ready to be merged whenever it's ready to go, just let me know

@bourgeoisor this PR is done and ready to be merged.


Validate correctness of ByteBuffer / byte[] interchange

Problem description
The bridge between Pravega and Flink serializers switches between ByteBuffer and byte[]. It makes the assumption that the provided byte buffers are always heap-backed and that the payload of the byte buffer is the complete backing array (no position / mark / limit / slice).
Problem location
In the FlinkPravegaUtils$FlinkDeserializer.deserialize() method.
Suggestions for an improvement
We should have sanity checks that validate that the byte buffer spans the full backing array (position is zero, limit is capacity).

This is fixed thanks to #42


Enhan_smith_waterman_cython

-- Added cython function to Smith Waterman measure to improve the performance.

Coverage decreased (-0.1%) to 99.81% when pulling 640fa34dc17657df15c37cf0343de77312fb7a21 on enhan_smith_waterman_cython into e7f6dbe9d278ea8edeb4fe2c4d0f9de719e0b538 on master.

Coverage decreased (-0.0009%) to 99.905% when pulling 66a8fe8f646919298baf6a0e7de590066095d9ed on enhan_smith_waterman_cython into e7f6dbe9d278ea8edeb4fe2c4d0f9de719e0b538 on master.


[Spotify Player] ...Menu bar player has encountered an error

Extension
https://www.raycast.com/mattisssa/spotify-player
Description
Error:
{"_isRayError":true,"code":16,"title":"Could not initialize OAuth","name":"Error","message":"OAuth request creation is not available when command is launched in background","stack":"Error: OAuth request creation is not available when command is launched in background\n    at Rr (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:25:230)\n    at Ye (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6249)\n    at ht (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6374)\n    at Immediate.<anonymous> (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6139)\n    at process.processImmediate (node:internal/timers:478:21)","breadcrumbs":[{"level":"debug","category":"Request","message":"","timestamp":"2023-12-06T14:25:47.579Z","data":{"function":"getApplications"}}]}:

Steps To Reproduce
I've been using it for months. Now it just doesn't work. I keep logging in and succeeding, but it just stays the same
Current Behaviour

Expected Behaviour

I just installed Raycast for the first time and running into the same issue with the Spotify extension.
{"_isRayError":true,"code":16,"title":"Could not initialize OAuth","name":"Error","message":"OAuth request creation is not available when command is launched in background","stack":"Error: OAuth request creation is not available when command is launched in background\n    at Rr (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:25:230)\n    at Ye (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6249)\n    at ht (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6374)\n    at Immediate.<anonymous> (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6139)\n    at process.processImmediate (node:internal/timers:478:21)","breadcrumbs":[{"level":"debug","category":"Request","message":"","timestamp":"2023-12-13T20:06:46.522Z","data":{"function":"getApplications"}}]}:

hey @ortonomy & @gpnagy, thanks for reporting this.
There's a bug with menu bar commands that use OAuth and are re-run at very short intervals (the Spotify menu bar command runs every 10 seconds) that makes it so that you have to make sure you complete authentication before a background run can be launched. 😅 I'm looking into fixing that, but in the mean time you should be able to work around it by running a different command (like Your Library) and authenticating from that. Once you're authenticated, the menu bar command should work fine, too.

@sxn Thanks so much for the reply. Confirming that using the Your Library command worked to establish the connection Spotify and the menu bar player is working now as well. Very much appreciate your support and amazing work on this project. It's fantastic!

Using your "Your library" doesn't work for me, as get logged out of Spotify a few minutes later.
Is there any other workaround, or is a fix for this in the pipeline?
Thanks!

This should have been fixed as part of release v1.65. So I'm closing this issue to maintain a clean backlog. Feel free to comment it if you still have the problem.

Unfortunately still happening to me, even when signing in through "Your library".
I'm on 1.66.2.
Error:
{"_isRayError":true,"code":16,"title":"Could not initialize OAuth","name":"Error","message":"OAuth request creation is not available when command is launched in background","stack":"Error: OAuth request creation is not available when command is launched in background\n    at Rr (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:25:230)\n    at Ye (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6249)\n    at ht (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6374)\n    at Immediate.<anonymous> (/Applications/Raycast.app/Contents/Resources/RaycastCommands_RaycastCommands.bundle/Contents/Resources/api/node_modules/@raycast/server/index.js:24:6139)\n    at process.processImmediate (node:internal/timers:478:21)","breadcrumbs":[{"level":"debug","category":"Request","message":"","timestamp":"2024-02-06T02:23:33.767Z","data":{"function":"getApplications"}}]}:

@sxn is this something we recently tried to fix?

@peduarte not this particular issue.
we recently fixed a bug that made it hard to authenticate to OAuth via the menu bar command, because you had to finish the entire process before the next background run kicked in.
In this case, it sounds like @marcelscruz logged in just fine, but then for some reason (token expired, something else etc) was logged out. So the next background run kicked in, tried to initialize OAuth and…that's not allowed in background runs. 😅

Exactly, I can log in and the menu bar shows the current song and all, but after some time it crashes.

Did this ever get fixed?

No, it was never fixed.

In this case, it sounds like @marcelscruz logged in just fine, but then for some reason (token expired, something else etc) was logged out. So the next background run kicked in, tried to initialize OAuth and…that's not allowed in background runs.

Yeah, this just happened to me. The menu bar item crashed and stopped working after 24 hours. This is still borked/not working. Uninstalled.


Viewport Addon: Custom devices are NOT appearing as available options in Viewport drop-down

Bug or support request summary
I had previously been running viewport and using its default list of devices. I came across the need to add a custom device to test against a specific resolution, so I updated my .storybook/config.js file as instructed in the README. However, my custom devices are not appearing in the drop-down no matter what I try.
Steps to reproduce
Here is my .storybook/config.js file contents
import { configure as reactConfig } from '@storybook/react';
import { configure as viewportConfig, INITIAL_VIEWPORTS } from '@storybook/addon-viewport';

function loadStories() {
  require('../src/stories');
}

reactConfig(loadStories, module);

const newViewports = {
  arrowDevice: {
    name: 'Arrow Device',
    styles: {
      width: '1280px',
      height: '800px',
    },
    type: 'tablet',
  },
};

viewportConfig({
  viewports: {
    ...INITIAL_VIEWPORTS,
    ...newViewports,
  },
  defaultViewport: 'arrowDevice'
});

Please specify which version of Storybook and optionally any affected addons that you're running
3.4.1
Who to contact
@anthonymetzler

@anthonymetzler Version 3.4.1 does not support configuration, please use 4.0.0-alpha.x instead.
I think you have seen the README file in master, no? (README v3.4.1)

Ahh, I just did the same. I was expecting master to ref to the latest stable build and developing of a new version on another branch. Could it be an idea to give a little heads up in the readme files that master is about the new alpha version and point to README for the latest stable branch?
I can send a PR on that if that is something that you want to have @mshaaban088

@SindreSvendby More about the release process can be found in RELEASES file. Feel free to raise your concern.


HADOOP-19051: Highlight Capacity Scheduler new features in release for the release 3.4.0

Description of PR
Highlight the new features implemented for CS in 3.4.0.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@brumi1024 Thanks for the contribution! Merged into trunk.


docs(DevTools): documenting DevTool chrome extension support

The DevTools chrome extension is pretty handy but the only references to its compatibility are in commit messages and the code itself. This just adds a note to the README letting people know that there is a Chrome extension out there for DevTools and that the app supports it

Thankya!


Flaky kernel startups

Over the past few days I've been seeing flaky CI with kernel startup issues.
Basically the kernel doesn't start even after we've connected to it.
This is what jupyter does today

send kernel info request
wait for the response
ensure we get messages on iopub

What can we do:

send request for kernel info as soon as we establish connection
don't wait for resonse for kernel info (we don't do this today)

Lets see from telemetry how bad things are rather than slowing the whole startup by waiting for response for kernel info
Add telemetry to see when we connect to kernels and its not ready (don't get response for kernel info)

Probably send a second request for kernel info if we don't get the resopnse for first request in half of the timeout period
Wait for shell & iopub ports to be used (i.e. kernel connects to these two ports)

I think we've addressed the issues, closing this for now.


Typos

Here are typos I've found:
On page 12 of the PDF, it claims you can double click the "shmsader" to open it. Presumably this is meant to say "shader".
On page 13 the info box ends with two stops. Also, the enable parenthesis don't close.
On page 17 there is no space between "values" and "this"
~Molive

Thanks for your attention to detail! Just committed the changes :)


Some tests misusing assertTrue for comparisons

assertTrue is not for comparing arguments, should use assertEqual for that.
The developer's intent of the test was to compare argument 1 with argument 2, which is not happening. Really what is happening is the test is passing because first argument is truthy. The correct method to use is assertEqual. more details
https://github.com/tensorflow/tensorflow/blob/d9e5d3c634c2ab1221e7d30b562c48b0b0e110b7/tensorflow/python/autograph/pyct/cfg_test.py#L85
https://github.com/tensorflow/tensorflow/blob/d9e5d3c634c2ab1221e7d30b562c48b0b0e110b7/tensorflow/python/distribute/distributed_variable_test.py#L383
https://github.com/tensorflow/tensorflow/blob/d9e5d3c634c2ab1221e7d30b562c48b0b0e110b7/tensorflow/python/eager/def_function_xla_jit_test.py#L1182
https://github.com/tensorflow/tensorflow/blob/d9e5d3c634c2ab1221e7d30b562c48b0b0e110b7/tensorflow/python/keras/mixed_precision/loss_scale_optimizer_test.py#L1007
https://github.com/tensorflow/tensorflow/blob/d9e5d3c634c2ab1221e7d30b562c48b0b0e110b7/tensorflow/python/ops/parallel_for/control_flow_ops_test.py#L2549
I found this issue automatically, see other issues here

we've also raised a PR for the keras one upstream

Thank you created a PR https://github.com/tensorflow/tensorflow/pull/54395 for the same.


PropTypes is a separate module now

I'm not sure for which version of react-native this has been implemented, however, I noticed in index.js PropTypes is imported from 'react' when in newer versions it's become its own module and should be imported from 'prop-types'.
https://www.npmjs.com/package/prop-types
I hope this helps,
George.

My commit was never merged. https://github.com/cardash/react-native-openalpr/pull/24


input type = checkbox

I consider a checkbox to be of type Boolean.
However, the code doesn't work that way.
So my question is: How to handle input elements of type 'checkbox' in this templateforms framework?

It's very simple. See the example here for registering a custom form element:
https://github.com/meteortemplates/forms#reactiveformscreateelement
The HTML element is in the first argument of validationValue (which is your chance to transform the value of what's in the DOM into any data type/structure you want, including a Boolean, before it is sent to be validated). The logic required would be simple and once you write it, the checkbox form element can be reused.

awesome.
I didn't read that piece at documentation at first, but now it works.
For referencial purpuses, here is the code I used:
ReactiveForms.createElement({
    template: 'onoffswitchElement',
    validationEvent: 'keyup',
    validationValue: function(el, clean, template) {
        value = $(el).is(':checked');
        return value;
    }
});

Thanks for the quick response.

Here my code including click event
ReactiveForms.createElement({
  template: 'basicCheck',
  validationEvent: ['keyup', 'click'],
  validationValue: function (el, clean, template) {
    console.log('Specifying my own validation value!', $(el).is(':checked'));
    value = $(el).is(':checked');
    return value;
    //return clean(value, { removeEmptyStrings: false });
  }

Actually, I noticed that this validation for a checkbox doesn't really matter. It just needs to return a boolean, but you can't rerun this function to check the ACTUAL value of the checkbox. So, returning a random boolean (true or false, makes no difference) is all that matters. If you want to do some validation whether you may be able to tick it, you have to write that piece of validation code somewhere else.
ReactiveForms.createElement({
    template: 'onoffswitchElement',
    validationEvent: 'keyup',
    validationValue: function(el, clean, template) {
        var v = $(el).val();
        if (v === 'on') { // input of type checkbox always returns true, whether it is ticked or not
            return true;
        }
        throw new Meteor.Error("validation value incorrect.")
    }
});

I think your problem is that your validationEvent is for keyup, not for click. So it might not rerun?

@jonjamz you're totally right. Adding the click event made all the difference. Now it is being rerun.

I did something similar to @VanHumbeeckA . When my page loads, and I change the checkbox, all works as expected. So checkbox off, I select it and save, form saves correctly, then I turn if off again, and it does not get recognized as a changed field in my action function. Any idea how to get this to change?


Initial  commit of zookeeper example and statefulsets dir

This change is

@erictune @enisoc @foxish

Reviewed 7 of 10 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

statefulsets/zookeeper/Dockerfile, line 48 at r2 (raw file):

RUN set -x \
	&& useradd $ZK_USER \
    && id $ZK_USER \

Since you rely on the uid/gid being specific numeric values in the k8s manifest, you can "assert" them here instead of just printing:
    && [ `id -u $ZK_USER` -eq 1000 ] \
    && [ `id -g $ZK_USER` -eq 1000 ] \

Then the docker build will fail if the assumption is violated because of a change in an upstream image or tool.

statefulsets/zookeeper/README.md, line 54 at r2 (raw file):

The Stateful Set configuration must match the Headless Service, and it must provide the number of
replicas. In the example below we request a ZooKeeper ensemble of size 3.
**As weighed quorums are not supported, it is imperative that an odd number of replicas be chosen.

Do you mean "weighted"?

statefulsets/zookeeper/README.md, line 77 at r2 (raw file):

      - name: k8szk
        imagePullPolicy: Always
        image: kowens/k8szk

Don't forget to update this copy of the yaml to the gcr.io image.

statefulsets/zookeeper/README.md, line 140 at r2 (raw file):

outdated logs and snapshots.

If you do not have a existing retention policy and backup procedure, and if you are comfortable with

"an* existing"

statefulsets/zookeeper/README.md, line 193 at r2 (raw file):

Currently, the use of Persistent Volumes to provide durable, network attached storage is mandatory.
**If you use the provided image with emptyDirs, you will likely suffer a data loss.** The example
below demonstrates how to request a dynamically provisioned persistent volume of 20 Gib.

GiB*

statefulsets/zookeeper/zookeeper.yaml, line 58 at r2 (raw file):

            {
              "podAntiAffinity": {
                "requiredDuringSchedulingRequiredDuringExecution": [{

As mentioned in https://github.com/kubernetes/kubernetes.github.io/pull/1894#issuecomment-266081871 I'm wondering if preferred might be better. Whatever we decide there will probably apply here too. I'm just leaving a link here so they'll be consistent.

Comments from Reviewable

Review status: all files reviewed at latest revision, 10 unresolved discussions.

statefulsets/zookeeper/README.md, line 7 at r2 (raw file):

##Limitations
1. Scaling is not currently supported. Once an ensemble is created, it is not safe to patch the
replicas of the Stateful Set. This is primarily due to the lack of the ability to update ensemble's

This sentence could be simplified.

statefulsets/zookeeper/README.md, line 9 at r2 (raw file):

replicas of the Stateful Set. This is primarily due to the lack of the ability to update ensemble's
membership in a safe way in ZooKeeper 3.4.9 (The current stable release). When ZooKeeper 3.5.x
advances from alpha to stable we will consider adding this feature.

I think making statements about the future was something we were avoiding elsewhere in documentation. Should be avoided here as well?

statefulsets/zookeeper/README.md, line 133 at r2 (raw file):

####Data Retention Configuration
**ZooKeeper does not, by default, purge old transactions logs or snapshots. No, never. Yes, this can cause

nit: I found the "No" and the "Yes" a little hard to parse in a quick read.

statefulsets/zookeeper/README.md, line 187 at r2 (raw file):

```yaml
  volumeMounts:
          - name: datadir

Indentation seems a bit off.

Comments from Reviewable

Review status: 8 of 10 files reviewed at latest revision, 10 unresolved discussions.

statefulsets/zookeeper/Dockerfile, line 48 at r2 (raw file):
Previously, enisoc (Anthony Yeh) wrote…
Since you rely on the uid/gid being specific numeric values in the k8s manifest, you can "assert" them here instead of just printing:
    && [ `id -u $ZK_USER` -eq 1000 ] \
    && [ `id -g $ZK_USER` -eq 1000 ] \

Then the docker build will fail if the assumption is violated because of a change in an upstream image or tool.

Done.

statefulsets/zookeeper/README.md, line 7 at r2 (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
This sentence could be simplified.

Done.

statefulsets/zookeeper/README.md, line 9 at r2 (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
I think making statements about the future was something we were avoiding elsewhere in documentation. Should be avoided here as well?

Done.

statefulsets/zookeeper/README.md, line 54 at r2 (raw file):
Previously, enisoc (Anthony Yeh) wrote…
Do you mean "weighted"?

Done.

statefulsets/zookeeper/README.md, line 77 at r2 (raw file):
Previously, enisoc (Anthony Yeh) wrote…
Don't forget to update this copy of the yaml to the gcr.io image.

Done.

statefulsets/zookeeper/README.md, line 133 at r2 (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
nit: I found the "No" and the "Yes" a little hard to parse in a quick read.

Done.

statefulsets/zookeeper/README.md, line 140 at r2 (raw file):
Previously, enisoc (Anthony Yeh) wrote…
"an* existing"

Done.

statefulsets/zookeeper/README.md, line 187 at r2 (raw file):
Previously, foxish (Anirudh Ramanathan) wrote…
Indentation seems a bit off.

Done.

statefulsets/zookeeper/README.md, line 193 at r2 (raw file):
Previously, enisoc (Anthony Yeh) wrote…
GiB*

Done.

statefulsets/zookeeper/zookeeper.yaml, line 58 at r2 (raw file):
Previously, enisoc (Anthony Yeh) wrote…
As mentioned in https://github.com/kubernetes/kubernetes.github.io/pull/1894#issuecomment-266081871 I'm wondering if preferred might be better. Whatever we decide there will probably apply here too. I'm just leaving a link here so they'll be consistent.

We are going with hard spreading for the blog, tutorial, and container. At least for now.

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

statefulsets/zookeeper/README.md, line 7 at r2 (raw file):
Previously, kow3ns (Kenneth Owens) wrote…
Done.

Done.

statefulsets/zookeeper/README.md, line 9 at r2 (raw file):
Previously, kow3ns (Kenneth Owens) wrote…
Done.

Done.

Comments from Reviewable

/lgtm


New UX insert link dialog - internal URLs

Acceptance criteria

Links to pages can be created through TinyMCE
Users can add link descriptions to all media types
When the cursor is on an existing internal page link, opening the "insert link" panel allows editing of the link
I can insert a link with a custom title set in the dialog when no selection is made
When editing an existing link, clearing the selection removes the link
I can explicitly remove a link from the dialog

Tasks

[x] Create Internal URL form in React
[x] Create entwine script to inject in to tinymce
[x] Re-instate commented out behat tests

Resources

Related ticket: #5947
Precondition: #6141
Designs: https://projects.invisionapp.com/share/BGAYOTRFY#/screens/224873109

Related

Inline edit/remove of links in HTML editor
New UX insert link dialog - Insert anchors

Exclusions

Create AnchorLink (dropdown list) component for the form, refer to HTMLEditorField_Toolbar::getanchors()
Users do not have the ability to edit linked file descriptions from the insert link modal

PRs:

[x] https://github.com/silverstripe/webpack-config/pull/2 (critical , please merge first and update NPM)
[x] https://github.com/silverstripe/silverstripe-framework/pull/6969
[x] https://github.com/silverstripe/silverstripe-cms/pull/1834
[x] https://github.com/silverstripe/silverstripe-admin/pull/88
[x] https://github.com/silverstripe/silverstripe-asset-admin/pull/491

WIP is at https://github.com/open-sausages/silverstripe-admin/tree/pulls/4.0/tinymce-link-dialog
I've dropped priority of this story in lieu of some confirmation with @sminnee

I don't think this covers all of the dev from #5947 as it misses: link to file, link to email, and link to external url. @tractorcow is all of that work separated out into other issues?

Yes @sminnee split the work into separate stories.

See

https://github.com/silverstripe/silverstripe-framework/issues/6743
https://github.com/silverstripe/silverstripe-framework/issues/6740
https://github.com/silverstripe/silverstripe-framework/issues/6141

Changed ACs from:

Links can be created through TinyMCE to the following:

Pages
Anchor link on a page

Users can add link descriptions to all media types
Should be in CMS module

to

Links to pages can be created through TinyMCE
Users can add link descriptions to all media types
The insertion is disabled when no selection is made
When the cursor is on an existing internal page link, opening the "insert link" panel allows editing of the link
When the cursor is on an external URL, file or email link, the "link" tinymce dropdown has only the relevant options enabled
When editing an existing link, clearing the selection removes the link

New acceptance criteria look good, @chillu it would be good to go over some of the UI next week to confirm some the designs and discuss edit functionality. Some of the mockups need a bit of talking to and then we can add a bit more acceptance criteria for editing.

Re-instate behat tests:
#  Scenario: I can link to an internal page
#    Given I select "awesome" in the "Content" HTML field
#    And I press the "Insert Link" HTML field button
#    When I select the "Link to a page on this site" radio button
#    And I fill in the "internal" dropdown with "Home"
#    And I fill in "my desc" for "Link description"
#    And I press the "Insert" button
#    # TODO Dynamic DB identifiers
#    Then the "Content" HTML field should contain "awesome"
#    # Required to avoid "unsaved changes" browser dialog
#    Then I press the "Save draft" button

#  Scenario: I can link to an anchor in an internal page
#    Given I select "awesome" in the "Content" HTML field
#    And I press the "Insert Link" HTML field button
#    And I select the "Link to a page on this site" radio button
#    And I fill in the "internal" dropdown with "Details"
#    And I select "youranchor" from "Form_EditorToolbarLinkForm_AnchorSelector"
#    And I press the "Insert" button
#    Then the "Content" HTML field should contain "awesome"
#    # Required to avoid "unsaved changes" browser dialog
#    Then I press the "Save draft" button

After talking a bit more with @clarkepaul, I've removed the following ACs:

The insertion is disabled when no selection is made (replaced with: You can insert a link with a custom title set in the dialog when no selection is made)
When the cursor is on an external URL, file or email link, the "link" tinymce dropdown has only the relevant options enabled (too hard)

Added AC:

I can explicitly remove a link from the dialog

I've split out the anchor work into another card: https://github.com/silverstripe/silverstripe-admin/issues/65.
Created a new card for a "edit/remove link" overlay: https://github.com/silverstripe/silverstripe-admin/issues/66

FYI I've updated the mockups to match new acceptance criteria.

WIP at https://github.com/open-sausages/silverstripe-admin/tree/pulls/4.0/insert-page-link

Prs created but need to fixup some tests. Monday....

for @clarkepaul here are some screenshots:

Sorry been away from computer most of the morning so couldn't provide feedback early enough, my only minor changes for this was the modal heading and link names in the dropdown being different from the designs. I will open a new issue for these here https://github.com/silverstripe/silverstripe-admin/issues/93


Admin tool for redis not working when using --with-local-redis command

ERROR: php_network_getaddresses: getaddrinfo failed: Name or service not known [tcp://global-redis:6379]
This only happens when I install redis like this
ee site create example.com --type=wp --cache --with-local-redis --local-db
But when I install without --with-local-redis, admin tools for redis is working fine.

@seyntjim Thanks for reporting the issue. We're looking into it.


can it work on C++11?

@axxel   Hi,
Deployed on embedded, can it work on C++11?
If I want it to work on C++11, how can it be modified while maintaining performance as much as possible? Can you provide some suggestions?

My first suggestion: update/replace your tool chain. ;)
The library will obviously not compile with a c++11 compiler. If you tried, you'll get a lot of compiler errors. Out of the top of my head, I have no idea how much code would need to be touched/modified to make it compile on c++11. If I personally had this goal, I'd simply try it and see what happens and then start disabling features and work around issues and see how far I can get. I personally don't have any interest to go that direction. The next major release will likely require at least c++20.

Ok.Thanks


update npm version through travis

@raeeschachar what does this PR do?

@AlasdairSwan
This is a try to automate the process of pushing new version of this package to npm repo so that edX could use it.

Right right @matthugs thanks for the help. Done, please check.

That is good to know @matthugs. Will do that.

Done @matthugs
Good to merge?


Base Sphinx makefiles on the modern template

This significantly reduces the amount of boilerplate code in the makefiles and should hopefully make the logic a bit easier to follow

@astafan8 I am not sure what you mean. Functionally there should be no big change. It is mainly that instead of having all these exilic targets on the line of target foo: call sphinx build with arg foo there is just a default target

@jenshnielsen ah, got it now, thanks!


Drop Python 3.5 support for Shapely 2.0

I know we are only just dropping Python 2.7 support (#743, #884), but I would already like to bring up the timeline for keeping/dropping Python 3.5 support.
Shapely 1.8 will require >= Python 3.5, and I would propose that the future Shapely 2.0 with PyGEOS integration (#782) can require >= Python 3.6.

It's hard to exactly plan of course, but realistically by the time that a potential Shapely 2.0 would come out, Python 3.5 will be end of life (2020-09-13, see https://devguide.python.org/#status-of-python-branches)
In the scientific python ecosystem, many packages already dropped or are dropping Python 3.5 support (see https://numpy.org/neps/nep-0029-deprecation_policy.html, although this describes a shorter support cycle than many packages in practice do)

But the main reason that I am already bringing this up now, is that if this sounds good for Shapely, we would like to already start with that in PyGEOS (https://github.com/pygeos/pygeos/issues/125). Meaning we can start using Python 3.6 features in PyGEOS now (eg ordered default dict, f-strings, type annotations, ..). Because if not, I would prefer not do start doing that in PyGEOS to not make integration with Shapely later on more difficult.

Generally, I don't have any strong desire to hang onto Python 3.5 for much longer. I suppose shapely 1.8 could keep Python>=3.5, despite this version reaching EOL this year. We may want to target at release date for shapely 1.8 later this year (2020).
As for shapely 2.0 planning, I agree it should require Python>=3.6 to align with pygeos and much of scientific Python ecosystem lead by the NumPy folks.

@jorisvandenbossche @mwtoews agreed. Python 3.6 for shapely 2.0.

Super, thanks!

This is already done for Shapely 1.8 (https://github.com/Toblerity/Shapely/commit/1b7020a8d3df40cbcfea1d5f358f335627236f7b), so closing.


Logo

we reject because your file is the wrong convention

Hi.
Thanks for your reply.
What sort of file does the logo need to be?
On Tue, 1 Sep 2020, 8:40 pm Do Minh Khai<EMAIL_ADDRESS>wrote:

we reject because your file is the wrong convention
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tomochain/tokens/pull/105#issuecomment-684758784, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZ5AFGQNRX6BBAKP5TNE2TSDTFTNANCNFSM4QQIJALA
.

Could you help me add a logo please?
I'm making this token to use for loyalty points and competitions on my
website. It's not a coin for listing or ICO or anything like that and will
never be sold but I still want it to reflect my website logo. Please help
me with this.
Thanks
On Fri, 4 Sep 2020, 11:42 am Michael Michael Loftus, <
<EMAIL_ADDRESS>wrote:

Hi.
Thanks for your reply.
What sort of file does the logo need to be?
On Tue, 1 Sep 2020, 8:40 pm Do Minh Khai<EMAIL_ADDRESS>wrote:

we reject because your file is the wrong convention
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tomochain/tokens/pull/105#issuecomment-684758784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZ5AFGQNRX6BBAKP5TNE2TSDTFTNANCNFSM4QQIJALA
.

@CryptoInvestingandEarning Please read README.MD file for more detail


I'm not sure what you are asking about.


i have a suggestion

can you make "Please use this software only if you have an active lightroom subscription. I'm not responsible of any use without subscription" version?

No piracy when not needed. Sorry


The problem occurs when I use instantID in conjunction with Ipadapter:

The problem occurs when I use instantID in conjunction with Ipadapter:

Did I do something wrong? I'm using the example provided by instantID

update ipadapter and instantid


Restructure TAL configuration and remove init command.

This PR restructures the TAL configuration in response to the dropped requirement to opt into the ARIN TAL.
Routinator will now use the bundled RIR TALs directly unless told otherwise by the new --no-rir-tals command  line and config option. The additional bundled TALs can be added via the new --tal command line and config option. Additionally, the TAL directory can still be used via the --extra-tals-dir option. The tal-dir option has been removed but will still be accepted – and ignored – in the config file only.
The init command has been removed.
Fixes #788. Fixes #583.

@ximon18 I left the Docker installation section in the documentation alone. Can you please update this with the new installation steps when you have them?

ARIN has confirmed that the implementation in this PR reflects the intentions of the changes to the RPA. The PR can thus now be moved.


Uncaught Error: [remote-sync] invalid transport: undefined in /Users/vaibhavchauhan/x/.remote-syn...

[Enter steps to reproduce below:]

...
...

Atom Version: 1.5.3
System: Mac OS X 10.11.3
Thrown From: remote-sync package, v3.5.0
Stack Trace
Uncaught Error: [remote-sync] invalid transport: undefined in /Users/vaibhavchauhan/x/.remote-sync.json
At /Users/vaibhavchauhan/.atom/packages/remote-sync/lib/RemoteSync.coffee:119

Error: [remote-sync] invalid transport: undefined in /Users/vaibhavchauhan/x/.remote-sync.json
    at RemoteSync.createTransport (/Users/vaibhavchauhan/.atom/packages/remote-sync/lib/RemoteSync.coffee:119:17)
    at RemoteSync.getTransport (/Users/vaibhavchauhan/.atom/packages/remote-sync/lib/RemoteSync.coffee:125:19)
    at RemoteSync.uploadFile (/Users/vaibhavchauhan/.atom/packages/remote-sync/lib/RemoteSync.coffee:84:37)
    at handleEvent (/Users/vaibhavchauhan/.atom/packages/remote-sync/index.coffee:46:14)
    at atom-workspace.disposables.add.atom.commands.add.remote-sync:upload-file (/Users/vaibhavchauhan/.atom/packages/remote-sync/index.coffee:85:40)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at CommandRegistry.handleCommandEvent (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchContextMenuCommand (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1019:28)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)
    at EventEmitter.ipc.sendSync (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/atom.asar/renderer/api/lib/ipc.js:21:31)
    at BrowserWindow.RemoteMemberFunction [as emit] (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/atom.asar/renderer/api/lib/remote.js:143:29)
    at ContextMenuManager.module.exports.ContextMenuManager.showForEvent (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/context-menu-manager.js:156:33)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentContextmenu (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:250:47)
    at HTMLDocument.<anonymous> (/Users/vaibhavchauhan/Downloads/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands
  2x -0:06.7.0 core:save (atom-text-editor.editor.is-focused)
     -0:00.7.0 remote-sync:upload-file (li.file.entry.list-item.selected)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages
# User
remote-sync, v3.5.0

# Dev
No dev packages

I think you did not set your transport type in .remote-sync.json
see https://github.com/yongkangchen/remote-sync/blob/master/README.md


wont open files on android 12

Help I can't open files on my phone, but I give the app access to the folder

Already opened


WIP - Improve ice pop accessibility

TODO: tests
Done:
Making accessibility updates to the base popper, so it applies to dropdown, popover, and tooltip.
Some of this is simple aria roles for open/close of the popper. I generally followed these suggestions for roles usage: https://www.w3.org/TR/wai-aria-practices/examples/menu-button/menu-button-links.html
The more involved part is the tabbing, here are the actions I added:
When focused on popper trigger:
-hitting enter or space opens the popper
-hitting tab then goes inside the popper, visibly focusing on the first tabbable item
-hitting escape or enter on the trigger when the popper is opened but NOT entered yet, closes the popper
When focused in popper:
-hitting tab continues to focus on each naturally tabbable item
-hitting tab on last tabbable item closes popper and focuses back on the trigger
-hitting escape closes the popper and focuses back on the trigger
-hitting enter on an item with data-close closes the popper and focuses back on the trigger
-hitting enter or space on a submenu trigger opens the submenu popper, tabbing goes inside
-properly disabled items are naturally skipped in tabbing
Up/down arrow navigation support for dropdown menus will be a future addition, this pr is already complicated enough.
Also made a ton of related documentation and demo page updates.

@Addepar/ice Any comments on stuff other than tests so far?


APS-1615: E2E tests for Manage flow

Context
https://dsdmoj.atlassian.net/browse/APS-1615
Changes in this PR
This adds the end to end tests to cover the standard Manage flow at the end of the Standard application test:

[x] Edit keyworker
[x] Record arrival
[x] Record departure

NOTE: it may be possible to separate those actions and have them as standalone tests, not tacked on the end of the Standard application flow: at the moment the application returns useful info (placement date, premises booked in, etc) to select the correct placement on the premises page, but it should be possible to select the first available placement without those arguments passed in. This should enable testing other paths, like recording non-arrival, etc. May also speed up tests, but would require solid seed data!

Superseded by https://github.com/ministryofjustice/hmpps-approved-premises-ui/pull/2217 to avoid having to deal with a gazillion conflicts 😄


cloudflare tunnels docs update

Which Cloudflare product does this pertain to?
<IP_ADDRESS>
Existing documentation URL(s)
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/get-started/create-remote-tunnel/
My dashboard has nothing like what is described here.
"Select Create a tunnel."
Where? I see an add location. Extremely confusing when the documentation does not match what is presented.
What changes are you suggesting?
update documentation to reflect the current implementation or a header or banner which explains what version of the documentation you are viewing and a link to updated docs.
Additional information
No response

Hi @Roguito, thanks for flagging! We've updated the docs in #11626.


[FP]: spring-core-5.3.19.jar CVE-2016-1000027

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:vmware:spring_framework:*:*:*:*:*:*:*:* versions up to (excluding) 6.0.0
CVE
CVE-2016-1000027
ODC Integration
{"label"=>"Maven Plugin"}
ODC Version
7.1.0
Description
According to https://nvd.nist.gov/vuln/detail/CVE-2016-1000027#VulnChangeHistorySection the cpe version range was recently changed to 6.0.0 but it is not clear why. The description text still mentions 5.3.16.

I also stumbled over this vulnerability. In the Spring Repo there is a discussion ongoing: https://github.com/spring-projects/spring-framework/issues/24434
After reading the thread I think this is not a false positive because the vulnerability is there and was only removed in the Spring 6.x branch. For version 4.x and 5.x only the user can decide if the vulnerability may be used by an attacker: https://docs.spring.io/spring-framework/docs/current/reference/html/integration.html#remoting-httpinvoker

A suppression of this FP (for among others spring-core) is scheduled for the next release. You can use a similar suppression until it's released:
    <suppress>
        <notes><![CDATA[
   Issue is in spring-web and will only be fixed by Spring in their next major release.
   So suppressing it for the spring-framework components other than spring-web.
   https://github.com/spring-projects/spring-framework/issues/25379 (deprecation only in current 5.x versions)
   https://github.com/spring-projects/spring-framework/commit/5822f1bf85b94fd15f9829914b065b1c61910c7d (removal in 6.0.0-M1)
   ]]></notes>
        <packageUrl regex="true">^pkg:maven/(?!org\.springframework/spring\-web@).*$</packageUrl>
        <cve>CVE-2016-1000027</cve>
    </suppress>

I just updated to 7.1.1 but it still fails if I remove my manual suppression. Should this ticket be reopened or should I log a new ticket?


Use client error when client closed connection

Summary
When client closes the connection while downloading a blob, we will set the error response status to InternalServerError and then increment a GetBlobServerError counter in ContainerMetrics. But this is not a server error, this is a client.
This PR fixes this discrepancy. We will set error response status to client error so later it won't be counted as server error.
Operations
This would likely to impact two operations, GetBlobOperation and PutOperation.
For GetBlobOperations, it should be fine, since the client already closes the connection, and we already send back 200 or 206 before, so it won't affect the status code of this response. This is just for internal metric tracking.
For PutOperations, it should be fine too, since client closing connection without sending all the byte should be considered as bad request, instead of 503. This will reduce the number of 503 in public access log.
Test
Unit test

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 18.60%. Comparing base (52ba813) to head (7c2fc36).
Report is 78 commits behind head on master.

Files
Patch %
Lines

...va/com/github/ambry/rest/NettyResponseChannel.java
0.00%
2 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (52ba813) and HEAD (7c2fc36). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (52ba813)
HEAD (7c2fc36)

3
1

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2868       +/-   ##
=============================================
- Coverage     64.24%   18.60%   -45.64%
+ Complexity    10398     2917     -7481
=============================================
  Files           840      851       +11
  Lines         71755    72537      +782
  Branches       8611     8728      +117
=============================================
- Hits          46099    13497    -32602
- Misses        23004    57795    +34791
+ Partials       2652     1245     -1407

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[#31] Framework support

Hey @trupin
What are the next steps to take before weaver framework support can be released? Just fixing the broken tests?
Asking cause I'll have some time this weekend, and I'd love to release a framework for client with these changes. 😃

By the way I took a peek at the changes you've made and all seems sound.
If you make any more changes in the meantime I can play with it on Saturday.

The change generates container code that expects to be initialized with dependencies.

The next step are:

Validate the concept is working in the Sample
Write more Inspector tests to make sure it doesn't break the DI graph validation (which I'm pretty sure it does right now)

Yea, that was my idea. If a class is declared public, then its DI container needs to take its parameters directly from the call site rather than from a parent DI container. This way, all the weaver logic can stay internal to the framework.

I'm working on it today, and then I'll integrate it to a framework I'm currently working on to make sure this is stable enough.
Feel free to play with it and report anything you think is wrong or weird.

Hey @trupin, I've been dwelling on other matters. I did play with the sample API earlier and got it to work fine, voiced some concerns in review. Catching up w/ your changes right now, feel free to update me on the status / ask for any help 🙂


Let Travis CI build PRs from non-committers with committer's authorization

Something we need to investigate.

I think the main problem here is that we use these secure environment variables to run the tests on a trusted ec2 account. The secure environment variables are not exported for PRs outside the fork as discussed in https://docs.travis-ci.com/user/pull-requests#Pull-Requests-and-Security-Restrictions
I guess the two ways we can try to solve this are

try and use some other mechanism to pass in the EC2 creds. Following that we disable the auto-building of PRs and only build them through some explicit command like https://github.com/FiloSottile/travis-cron/tree/master/travis_ping
try and write a github plugin that will somehow patch a trusted PR into a branch in pywren/pywren and then ask travis to test that branch.

Any other ideas ?

It seems you can also pass environment variable with travis APi: https://docs.travis-ci.com/user/triggering-builds/
So solution 1 should be do-able.
For solution 2, we have to populate the build status back to PR; and to maintain the normal workflow of pull requests when contributors want to update PRs, we might need to automate the process of re-merge.
Both seem fine. The first one is easier?

One thing to investigate for the first one is that we need to encrypt / decrypt the ec2 creds as the travis conf itself is checked in. The secure environment variable gives us that for free in some sense.

I'll try to put some prototype today.

this isn't mission critical right now. Pulling someone's PR locally and pushing it back to pywren totally works. We don't have 100s of people opening PRs.
We could ask travis for best-practices
I'd much rather we invest the time in worrying about features and other places where contributing is difficult.


Bug with new lines and/or tabulations

Parsing a string or a file that contains new lines and/or tabulations leads to a non-expected result.
For example, with the XML:
<?xml version="1.0" encoding="UTF-8"?>
<root>
	<child foo="bar">
		<grandchild baz="fizbuzz">grandchild content</grandchild>
	</child>
	<sibling>with content!</sibling>
</root>

the result does not contain 'child', nor 'sibling'.

Here is a better version of the input xml file :
<?xml version="1.0" encoding="UTF-8"?>
<root>
    <child foo="bar">
        <grandchild baz="fizbuzz">grandchild content</grandchild>
    </child>
    <sibling>with content!</sibling>
</root>

Would you mind throwing together a gist with your code and examples?
Thanks.


Feature/header improvements

Update status according to response from API

@danielfdsilva Looks like the build is breaking: https://travis-ci.org/hotosm/oam-browser/builds/119303448#L493-L506. I can duplicate this locally. Can you take a look at how we can resolve?

:clap: thanks @danielfdsilva


The "render-expired-frames" command wont work

Environment

OS: Windows 11
scrcpy version: v1.25
installation method: Windows release
device model:  Xiaomi Redmi Note 10 Lite
Android version: 12

The Bug :
After running scrcpy as Administrator on my laptop, I used the following command below
scrcpy --render-expired-frames
When running the above command, it gives me an error that the option was ignored. The output error is below
WARN : Option --render-expired-frames has been removed. This flag has been ignored.

Yes, it was provided to configure an useless internal detail and has been removed. Why do you need it?

Yes, it was provided to configure an useless internal detail and has been removed. Why do you need it?

The feature actually used to somewhat work better when enabled(50-55fps). The frame output from software drops a lot of frames (I had a counter on both my phone and pc and they don't match as my game runs at 56-60fps but the software shows it in 25-40fps)
Is there gonna be a newer command added which will show the true frames 😢
My phone is at an average of 2400x1080p on default and everything else works fine. The command I usually use is below
scrcpy --render-expired-frames --bit-rate=16M --max-fps=100

I had a counter on both my phone and pc and they don't match as my game runs at 56-60fps but the software shows it in 25-40fps

Enabling the option just changes the count, but not all "rendered" frame will actually be displayed (several OpenGL calls will occur within a single display "slot", since vsync is disabled), so it does not change anything in practice (except it may add delay).
See 55806e7d312f2acabd99d1a3c707f7e42fbf90e2.
Btw, you can remove --max-fps=100 to mean "unlimited".

I had a counter on both my phone and pc and they don't match as my game runs at 56-60fps but the software shows it in 25-40fps

Enabling the option just changes the count, but not all "rendered" frame will actually be displayed (several OpenGL calls will occur within a single display "slot", since vsync is disabled), so it does not change anything in practice (except it may add delay).
See 55806e7.
Btw, you can remove --max-fps=100 to mean "unlimited".

Oh thanks, could you also show how I can enable vsync for this software? Or is it overall for the device


fix google sso doc

Description
Found mistake in the example in the following document
https://www.getambassador.io/docs/latest/howtos/sso/google/
Related Issues
n/a
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Tasks That Must Be Done

[ ] Did you update CHANGELOG.md?
[ ] Did you add or update tests?
[ ] Did you update documentation?
[ ] Were there any special dev tricks you had to use to work on this code efficiently?

[ ] Did you add them to DEVELOPING.md?

[ ] Is this a build change?

[ ] If so, did you test on both Mac and Linux?

Other

If this is a documentation change for a particular release, please open the pull request against the release branch.

Thank you!


Swagger lack of some meta parameters

Hi,
I am wondering why Swagger is missing some of the parameters from meta property. In decorator there are only 2 properties in meta object defined. I am using OpenAPI generator to generate client so those are missing in a client definition.
    meta: {
        itemsPerPage: number
        totalItems: number
        currentPage: number
        totalPages: number
        sortBy: SortBy<T>
        searchBy: Column<T>[]
        search: string
        select: string[]
        filter?: {
            [column: string]: string | string[]
        }
    }

Swagger decorator
       ApiExtraModels(PaginatedDocumented, dataDto),
       ApiOkResponse({
           schema: {
               allOf: [
                   { $ref: getSchemaPath(PaginatedDocumented) },
                   {
                       properties: {
                           data: {
                               type: 'array',
                               items: { $ref: getSchemaPath(dataDto) },
                           },
                           meta: {
                               properties: {
                                   select: {
                                       type: 'array',
                                       items: {
                                           type: 'string',
                                           enum: paginatedConfig?.select,
                                       },
                                   },
                                   filter: {
                                       type: 'object',
                                       properties: Object.keys(cols).reduce(
                                           (acc, key) => {
                                               acc[key] = {
                                                   oneOf: [
                                                       {
                                                           type: 'string',
                                                       },
                                                       {
                                                           type: 'array',
                                                           items: {
                                                               type: 'string',
                                                           },
                                                       },
                                                   ],
                                               }
                                               return acc
                                           },
                                           {} as Record<string, SchemaObject | ReferenceObject>
                                       ),
                                   },
                               },
                           },
                       },
                   },
               ],```

I'm not sure how that decorator is supposed to work, but there seems to be additional properties in the { $ref: getSchemaPath(PaginatedDocumented) } part. Can you show with a reproducer when these meta properties are missing?

Sure,
so as I mentionted I am generating client with openapi-tools
import { OpenApiNestFactory } from 'nest-openapi-tools'
...

		await OpenApiNestFactory.configure(
			app,
			new DocumentBuilder()
				.setTitle('Core API')
				.addServer('NEXT_PUBLIC_BACKED_API_URL', 'staging', {
					variable: { default: '3.0' },
				})
				.addBearerAuth(),
			{
				webServerOptions: {
					enabled: true,
					path: 'docs',
				},
				fileGeneratorOptions: {
					enabled: true,
					outputFilePath: './openapi.yaml', // or ./openapi.json
				},
				clientGeneratorOptions: {
					enabled: false,
					type: 'typescript-fetch',
					outputFolderPath: '../../web/typescript-api-client/src',
					additionalProperties:
						'apiPackage=clients,modelPackage=models,withoutPrefixEnums=true,withSeparateModelsAndApi=true',
					openApiFilePath: './openapi.yaml',
					skipValidation: true, // optional, false by default
				},
			},
			{
				operationIdFactory: (c: string, method: string) => method,
			},
		)

If I open swagger documentation in browser then it shows that indeed totalItems is in response

But when I am generating client from openapi.yaml some properties are missing from generated client and only 2 of them are shown filter and select.
Quick workaround for that for me right now is that I have taken your decorator and added missing property by hand
	return applyDecorators(
		ApiExtraModels(PaginatedDocumented, dataDto),
		ApiOkResponse({
			schema: {
				allOf: [
					{ $ref: getSchemaPath(PaginatedDocumented) },
					{
						properties: {
							data: {
								type: 'array',
								items: { $ref: getSchemaPath(dataDto) },
							},
							meta: {
								properties: {
									select: {
										type: 'array',
										items: {
											type: 'string',
											enum: paginatedConfig?.select,
										},
									},
									totalItems: {
										type: 'number',
									},
									filter: {
										type: 'object',
										properties: Object.keys(cols).reduce(
											(acc, key) => {
												acc[key] = {
													oneOf: [
														{
															type: 'string',
														},
														{
															type: 'array',
															items: {
																type: 'string',
															},
														},
													],
												}
												return acc
											},
											{} as Record<string, SchemaObject | ReferenceObject>,
										),
									},
								},
							},
						},
					},
				],
			},
		}),
	)

Below is part of openapi.yaml that is generated automatically when decorator from you package is used. Based on this file I am generating typescript-fetch client.
      responses:
        "200":
          description: ""
          content:
            application/json:
              schema:
                allOf:
                  - $ref: "#/components/schemas/PaginatedDocumented"
                  - properties:
                      data:
                        type: array
                        items:
                          $ref: "#/components/schemas/MyEntity"
                      meta:
                        properties:
                          select:
                            type: array
                            items:
                              type: string
                          filter:
                            type: object
                            properties:
                              name:
                                oneOf:
                                  - type: string
                                  - type: array
                                    items:
                                      type: string

Hmm thanks for you detailed report. Do you think you could create a quick repository with some steps for me to follow to generate the same things you're speaking of? That way I can follow the steps and make changes to arrive at the same outcome as your workaround!

I didn't get an issue tbh, as far as I understand swagger UI looks ok, but your code that exports Swagger and generates a client, doesn't generate a proper one. ?
if yes, can you download a spec file from swagger UI and compare it
@robertstrz

Closing due to lack of reproducer and author response. Feel free to reopen so we can pick this back up :)


Details regarding authentication

--This input can be applied to all Azure API documentation---
You can add details of where I can get the account name & account key.  These are very basic questions. But as a newbie trying to understand how to quick start the tutorials. I usually stumble at this point!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15591874-317e-ce4c-0dff-20d06b625e40
Version Independent ID: be7fed9a-343a-0ec7-a94d-02c354d1ae33
Content: Azure Quickstart - Upload, download, and list blobs in Azure Storage using Python
Content Source: articles/storage/blobs/storage-quickstart-blobs-python.md
Service: storage
GitHub Login: @tamram
Microsoft Alias: tamram

@skyprince999 ,Thanks for the feedback. We are actively investigating and will get back to you shortly.


lazyLoadTabs not followed

According to the documentation setting lazyLoadTabs to true will "Open empty tabs and load the website on the first rotation", so i figure setting it to false will "Open all tabs and load websites immediately"
When i run http://weboost.dk/tabcycle.json there is no difference. It always lazy loads.
Chrome v85.0.4183.121 (Official Build) (64-bit)
Enterprise Tab Rotate v1.1.1
Happy to help in any way.
/frm

Thank you for the bug report, I will look into it shortly.

Awesome :)  It's such a pleasure with addons that are actively developed.
/f

I found and fixed both of your bugs. However the automated release is currently broken and I need to look into it.
I will release the bugfixes as soon as the release works.

Brilliant 🥇
Very appreciative of your quick effort :)))
/f

:tada: This issue has been resolved in version 1.1.2 :tada:
The release is available on:

Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:

Please leave a rating on the chrome store if the extension helps you and you are satisfied with my support :).
That would tremendously help me.

Absolutely 👍


Add sample project to language clients that shows multiple two-phase transfers in flight all at once

See https://tigerbeetle.slack.com/archives/C04375JUAMS/p1688158327999759 for background.

👍

This should follow the same structure as the existing sample projects and use only a single file for simplicity.
We should probably have it create two accounts and send 3 pending transfers and have 2 be marked as completed and 1 marked as void.
In the future the third one should be allowed to timeout but we haven't implemented two-phase transfer timeouts yet so that wouldn't work yet.


mesonpy: select the correct ABI tag

Fixes #16

Okay, the code is done, we have tests, and the CI is finally passing!

Nice!
Naive question: is there anything Meson-specific here? Should this live in packaging or some such library in the future?

Not really, there isn't anything Meson specific, we get a file list from Meson and look at the ABI tags. I don't really think this would be useful to a lot of people, but maybe some, as is it very uncommon for a build backend to not be in charge of building the native Python modules.

as is it very uncommon for a build backend to not be in charge of building the native Python modules.

I'd expect this to be(come) fairly common actually, because build backends are thin shims that are not that much work to write, while a build system dealing with compiled code is quite complicated. Scikit-build is in the same situation I guess, with CMake doing the heavy lifting. Same for enscons/scons, bento/waf, etc. - I'd expect the setuptools design to be the exception, not the rule.

Hum, that makes sense, though it would still be quite a limited use-case, so I doubt something like this would be accepted in pypa/packaging. We could, however, extract it to a new package with the goal of helping the development of Python build backends.

Sounds good, but maybe whenever someone needs it rather than right now? Maybe @henryiii has a use for this in skbuild soon?

Yes, that was my plan. It might be useful for https://github.com/FFY00/trampolim too.


fix(shadow-database): Remove mention of migrate reset

Does not actually apply to migrate reset.

I was confused, it's just a notification from a very old PR 😅
👍🏼


Add test and doc for ast-builder::statements::querying::data-aggregation

Goal
Add test and doc for ast-builder::statements::querying::data-aggregation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

51 of 55 (92.73%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 98.901%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test-suite/src/ast_builder/statements/querying/data_aggregation.rs
51
55
92.73%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
45257

Relevant Lines:
45760

💛  - Coveralls


Feature: Set value of global register

What is the feature you'd like to have?
On some architectures (eg PPC), certain registers are considered "Global" (eg r2) and are not considered by dataflow. There should be a way to set these registers to a constant value at the start of a function, considering they do not have variables created which you can use Set User Variable Value on.
Is your feature request related to a problem?
I wanted to reverse a PPC binary and my HLIL is full of -1234(r2) with no way to tell binja what r2 should be.
Are any alternative solutions acceptable?
Could do a more general approach of "set any register to a PossibleValueSet at start of function"
Additional Information:
Binary available upon request

This was completed at some point between 4.1 and 4.2, although we currently only allow a single global register. Support for multiple is tracked now by #6096.


Remove Last login: message (.hushlogin file does not remove it)

Check for existing issues

[X] Completed

Describe the feature

This Last login: Fri Sep 15 12:33:38 on ttys002 is extremely annoying and I don't want to see it.
I thought doing this:
https://osxdaily.com/2010/06/22/remove-the-last-login-message-from-the-terminal/
touch ~/.hushlogin
Would remove it. But that did nothing. It's still there.
In my main terminal Warp, this does not happen:

With or without ~/.hushlogin.
Please let users hide that message from new terminal sessions.

Duplicate https://github.com/zed-industries/community/issues/1373


RuntimeError: OrderedDict mutated during iteration (Python3.5)

While running yotta with python3.5 on Debian GNU/Linux, yotta stops and complains "RuntimeError: OrderedDict mutated during iteration".
The way to reproduce:
git clone git@github.com:ARMmbed/mbed-drivers.git && cd mbed-drivers
yotta target frdm-k64f-gcc
yotta -v build

Traceback:
  File "/usr/local/bin/yotta", line 4, in <module>
    __import__('pkg_resources').run_script('yotta==0.7.0', 'yotta')
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 735, in run_script
...
    return installDeps(args, c)
  File "/usr/local/lib/python3.5/dist-packages/yotta-0.7.0-py3.5.egg/yotta/install.py", line 105, in installDeps
    test = {'own':'toplevel', 'all':True, 'none':False}[args.install_test_deps]
  File "/usr/local/lib/python3.5/dist-packages/yotta-0.7.0-py3.5.egg/yotta/lib/component.py", line 559, in satisfyDependenciesRecursive
    test = test
  File "/usr/local/lib/python3.5/dist-packages/yotta-0.7.0-py3.5.egg/yotta/lib/component.py", line 375, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File "/usr/local/lib/python3.5/dist-packages/yotta-0.7.0-py3.5.egg/yotta/lib/component.py", line 375, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File "/usr/local/lib/python3.5/dist-packages/yotta-0.7.0-py3.5.egg/yotta/lib/component.py", line 375, in __getDependenciesRecursiveWithProvider
    _processed = _processed
  File "/usr/local/lib/python3.5/dist-packages/yotta-0.7.0-py3.5.egg/yotta/lib/component.py", line 366, in __getDependenciesRecursiveWithProvider
    for c in need_recursion:
RuntimeError: OrderedDict mutated during iteration

Thanks for reporting this – python 3 support is currently experimental, so it looks like this is something the current test suite doesn't cover.

Hi, so I encountered this issue with my own code, and I was performing some del operations on the OrderedDict while looping through it. My solution was to perform a copy.deepcopy of the OrderedDict and perform the del operations on that, and now I don't have the issue anymore. So perhaps something like that was going on here.

In this case there was a difference between a generator and an explicit list between python 2 and 3 (where in the python 3 case because the list being iterated over was really a generator that was a view onto the ordered dictionary, modifying the dictionary during iteration would cause the error): this is the line that was changed to fix it:
https://github.com/ARMmbed/yotta/pull/414/files#diff-699129f8cde34ce5a928fa71a8f1a68cL359
(Basically explicitly converting the generator into an actual list)
:)


Correctly indent multi-line double-quoted string

🗣 Description
This pull request corrects the indentation of a multi-line double-quoted string in the GitHub Actions build workflow.
💭 Motivation and context
GitHub Actions' sanity checks became more stringent in the last few hours, and this incorrect indentation is now causing builds for all descendants of this skeleton repository ti immediately fail in GitHub Actions.
🧪 Testing
All automated tests now pass.  There were not passing a few hours ago, without this change.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

@jsf9k I was looking at this over the weekend and it looks like a one-off issue with processing on Azure and not something persistently failing. Do we still want to push this out for this skeleton?

If that is true then we don't need to push this out.

The changes in this pull request were not necessary to successfully run our GitHub Actions workflow when I was updating and merging other pull requests in this repository. I believe the error seen was some kind of one-off error from the Azure back-end that is used for the organization's free GitHub Actions runners.


Support for ray.util.iter.ParallelIterator

To use RaySGD with modin DFs it would be nice to have simple and efficient path to creating MLDataSet from a modin DF.
The MLDataSet can be constructed from a ray.util.iter.ParallelIterator. Such a ParallelIterator can be constructed from actors.
An implementation could assign one actor per modin shard, which would allow MLDataSet to operate locally not and copy data (if distributed). In theory, it should even be possible to use the same ObjRefs.
Since this is Ray-specific, such a feature should probably live in a lower level of the API that clearly exposes that it's specific to Ray.
@YarShev

I don't think functionality like this would belong in Modin. Modin is runtime agnostic, so it doesn't make sense to have these narrowly focused utilities here.
How were you imagining this working? I imagine that we could add something to Ray that creates an MLDataSet from Modin. To me that makes more sense.

Yes, there is benefits to either way, in modin or ray. I already heard similar arguments from the ray side just inversed.
I don't see any problem with having something like modin.modin_on_ray.get_parallelIterator(df). I think it's important to think about how modin wants to collaborate/compose with the rest of the world. Just converting to pandas and take it from there is not a scalable approach.
Yes, such functionality is runtime specific, but is is good style and useful to provide the opportunity to benefit from sharing runtime features. A parallel iterator is not a narrow feature to me.

We are building high level APIs for getting runtime agnostic partitions to handle externally. I am not suggesting that everything should go through pandas, I think you misunderstand.
I can see how modin.modin_on_ray.get_parallelIterator(df) might lead to severe API bloat as the number of integrations grows. I imagine the solution as being more along the lines of how libraries typically handle integrations, where if we want to collaborate/integrate and convert to something else, it goes on the consumer side. There might be exceptions, but for something general like this, it is more natural in Ray.

@fschlimb I opened an issue on the Ray side and they are enthusiastic to have it added there: https://github.com/ray-project/ray/issues/14039.
Please feel free to add it there! We have some examples for how to create actors from Modin partitions in the XGBoost implementation, it might be good to take a look there as well.

Great, thanks @devin-petersohn !


Add parameter : fraction of partners used at each federated round

This is useful when the number of partners is large

@HeytemBou I think you are introducing this in your DRFA PR right?

The attribute has been added by @HeytemBou in PR #354 (as a Scenario() attribute), but it remains to adapt standard multi-partner learning approaches to leverage it.

@arthurPignet indicates that there is a similar mechanism in PVRL - to be checked, see if some can be reused and/or upgraded when we implement this fraction of partners approach.
@HeytemBou can you complement this issue with elements of thoughts from your work on DRFA please?

Indeed PVRL is a contributivity method where an agent trained by reinforcement learning (policy gradient) would choose a subset of partners at every epoch. Currently one mpl object is created, and the method .fit_epoch is called. The mpl.fit method is kind of overwritten within the contributivity function PVRL. Every epoch the mpl.partner_list is changed (and the aggregator is re-initialized).
It could be really interesting to rewrite PVRL with your new tool @HeytemBou. Actually it could be easy to test various RL algorithms.


Can I get ONNX format for the pre-trained models?

Hello:
I have all kinds of issue to use any models in python to make predication.  But I can run ONNX format model in C#.
Is it possible to convert the pre-trained model to ONNX format and published here?
Thanks,

Sorry, we do not have plans to provide ONNX format model, you could try out our online demo on huggingface.


Added "registerParser" to response spec

From<EMAIL_ADDRESS>on September 07, 2011 08:45:52
Sometimes it's useful to register a parser to the response spec instead of statically. Today you need to use RestAssured.registerParser in a try-finally statement which is quite ugly if you only intend to use it for a single test.
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=101

From<EMAIL_ADDRESS>on September 19, 2011 11:37:49
Status: Fixed


[QUESTION] In a M365LP update, are assets updated or replaced by new versions?

We are using many M365 Learning Pathways assets provided by Microsoft, but all of them are displayed via custom playlists. So it is important for us to know for sure if the actual assets are updated, so that we can keep our custom playlists.
Or will only the standard Microsoft playlists keep working, because the assets are replaced by new versions?

Assets will not be changed in that way although the page that they link to may be updated.  We currently have no way to notify you if the underlying content for the asset changes.

Assets will not be changed in that way although the page that they link to may be updated.  We currently have no way to notify you if the underlying content for the asset changes.

Thanks Julie! But just to be sure I understand it correctly:

The underlying content in the non-custom asset pages (text and/or video) gets updated by Microsoft (or somebody else) if anything changes in that M365 app, so that my custom playlist gathering those assets will be kept up-to-date automatically, when the content gets updated?
But I won't be notified of those updates in the underlying content, so I should trust the editors of the underlying content (and maybe keep an eye on it from time to time)?

Thanks Julie! But just to be sure I understand it correctly:

The underlying content in the non-custom asset pages (text and/or video) gets updated by Microsoft (or somebody else) if anything changes in that M365 app, so that my custom playlist gathering those assets will be kept up-to-date automatically, when the content gets updated?
But I won't be notified of those updates in the underlying content, so I should trust the editors of the underlying content (and maybe keep an eye on it from time to time)?

Yes and Yes... Microsoft is the editors of the underlying content... it's just iFraming pages from support.office.com or docs.microsoft.com.

Yes and Yes... Microsoft is the editors of the underlying content... it's just iFraming pages from support.office.com or docs.microsoft.com.

Great. Thank you Julie!

Great. Thank you Julie!


pull request for e2e test at 01/11/2017 04:56:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Reset message visibility if an error happens when downloading the files

This makes Lambda retries faster. They had become much slower when we increased the SQS message visibility to be three times the length of the Lambda timeout: https://github.com/nationalarchives/tdr-dev-documentation/blob/master/architecture-decision-records/0020-sqs-visibility-timeout.md
This change means that the retry happens immediately, not when the message has expired after a few minutes.
The message visibility reset only happens if an error is encountered when fetching the original filepath from the API, downloading the file or updating the downstream queues. Those types of errors might be caused by temporary network glitches, and can be retried.

@MancunianSam Yeah, the LambdaRunner finishes without errors even if the receipt handle doesn't exist. I think SQS handles it silently - it assumes that if there's no message with that receipt handle, then it must have already been deleted.


Battle.net enrollment API changed/disabled

Probably due to the switch to the BattleNet app. See https://www.warcrafttavern.com/wow/news/authenticator-moving-to-battle-net-app/
As a result I have disabled the related tests for now.

Removed. It was fun while it lasted...


ci: add pr title format validation

What is the purpose of this pull request?
To assist #508 / #506 by ensuring that PR-title's are always valid conventional commit format before merging
What changes did you make? (Give an overview)
Added a pinned mtfoley/pr-compliance-action similar to what I use at eg. neostandard: https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml

This may be better as a branch ruleset :thinking:
Then again, I dont know if this org is an 'Enterprise' org on github?
(This should be the link) https://github.com/eslint-community/eslint-plugin-promise/settings/rules/new?target=branch
Eg here is one in one of my repos:

@scagood I believe that's only enforced in enterprise organizations

I added it to the ruleset now, but yeah, not enforced :)


CTRL+Click Material Logic not working.

if material pane is full of item it doesn't move it to current open storage pane.

I was able to replicate it on my alt account easily, however, it may be buggy because I wasn't having that after my fix.

what was the fix? I will read your post.

On another 3 accounts that I have, I was able to test the logic again and it worked.

Non-material items work fine according to the storage logic selection for me. But I can't get materials to follow the unchecked logic option.  Basically first move into materials pane, if full move to open storage pane.

Yeah, that one I figured out after I tested it from my main account and then tested my alt accounts. I did discover that non-material stuff movements were fine. Then I checked the material lists and it was fine after, the only thing that I can think of is when the chest in full of items, you either have to delete something that isn't needed or check a different panel number.