md5: Avoid signed left-shift overflow

Fix rhash_md5_final to use unsigned integers for left shifting to avoid the possibility of undefined overflow behavior.
This was exposed by UBSan:
.../librhash/md5.c:217:32: runtime error:
  left shift of 128 by 24 places cannot be represented in type 'int'

Oh, I've already copied this change with some other from cmake repository :)
Anyway, thanks!

Yes, I see it in d090fb73c8a89b2008fa13cd3bff8572511e025b now.  Thanks!


Quick links need to open in a new tab

The quick links present on the Shesha get started screen currently open in the same window when you click on them. The request is to please have them open in a new tab to retain the users position while they follow the guide.
https://starter-adminportal-test.shesha.dev/

This item has been implemented


Fix documentation on Address.comments methods [skip ci]

Currently the documentation on the method comments says it will return an empty array
if there is not comments on Mail::Address. This is not accurate on current implementation
and confirmed also on current test ( mail/spec/mail/elements/address_spec.rb#213 - "email addresses from the wild") where we expect nil if the address has no comments

Thanks @esparta! Merged @ 19597dcc182b5cf2942887bdf6cf5e18da4aeebc

Thanks for your time reviewing it and merging.


Add csv parser validation logic on client side

Description
Since, in the requirements we have a limitation of 100 words of csv file. It is safe to handle the parsing from the client side. In previous implementation we were assuming all the services to be on same computation device which will not be the case. So, updated the logic of handling csv files and implementation of validation from the client side.
Issue
#9

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


NooBaa image can be "downgraded"

Using various methods (for example kubectl edit NooBaa), one update the NooBaa image to an older image than the current. This may cause undesired behaviors.
I suggest a fix where the NooBaa operator will not accept updates to the NooBaa CRD where the NooBaa image is older build then the current installed one.

Moved from operator to core.
INIT container (during its upgrade check) should verify if we try to "downgrade", communicate to logs/alerts whatever and prevent the pod from continuing

Adding one request to this - please allow env var such as:
FORCE_DOWNGRADE_FROM_VERSION="5.1.1"

that will allow to bypass this check if the current version of the DB matches.


Code coverage reports generates invalid report when having 100% coverage

Summary
Hi! first of all very huge thank you for implementing the functionality for generating the test & code coverage report. We currently have an in house script to generate this reports from a json from a deployment but its much better to have it directly integrated in the cli
What I found is that, when you generate a code coverage report for a fully covered class, in the lines list, instead of having a hit for each line, you have one entry for line number infinity. In my pipeline (Azure Pipelines) this breaks the report generation
<class name="XXX_class" filename="no-map/XXX_class" line-rate="1" branch-rate="1">
    <methods>
    </methods>
    <lines>
        <line number="Infinity" hits="1" branch="false"/>
    </lines>
</class>

In my scenario, deleting this line <line number="Infinity" hits="1" branch="false"/> fixes the report generation but the report generated is "invalid"

Steps To Reproduce:
Deploy dreamhouse project running tests and generating code coverage report
> sfdx force:source:deploy -p force-app --runtests="TestPropertyController,TestSampleDataController,GeocodingServiceTest" --testlevel=RunSpecifiedTests --coverageformatters cobertura

Expected result
I assume that the correct result would be to generate a line tag for each covered line, but I don't know how can this be accomplished as the deployment json does not return any line coverage info if the file has 100% code coverage
Actual result
<class name="GeocodingService" filename="no-map/GeocodingService" line-rate="1" branch-rate="1">
    <methods></methods>
    <lines>
        <line number="Infinity" hits="1" branch="false" />
    </lines>
</class>
<class name="PagedResult" filename="no-map/PagedResult" line-rate="1" branch-rate="1">
    <methods></methods>
    <lines>
        <line number="Infinity" hits="1" branch="false" />
    </lines>
</class>

System Information
{
        "cliVersion": "sfdx-cli/7.153.0",
        "architecture": "darwin-x64",
        "nodeVersion": "node-v16.15.0",
        "pluginVersions": [
                "@oclif/plugin-autocomplete 0.3.0 (core)",
                "@oclif/plugin-commands 1.3.0 (core)",
                "@oclif/plugin-help 3.3.1 (core)",
                "@oclif/plugin-not-found 1.2.6 (core)",
                "@oclif/plugin-plugins 1.10.11 (core)",
                "@oclif/plugin-update 1.5.0 (core)",
                "@oclif/plugin-warn-if-update-available 1.7.3 (core)",
                "@oclif/plugin-which 1.0.4 (core)",
                "@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
                "alias 2.0.1 (core)",
                "apex 0.13.0 (core)",
                "auth 2.0.3 (core)",
                "community 1.1.5 (core)",
                "config 1.4.7 (core)",
                "custom-metadata 1.1.0 (core)",
                "data 2.0.2 (core)",
                "generator 2.0.1 (core)",
                "info 2.0.1 (core)",
                "limits 2.0.1 (core)",
                "org 1.13.2 (core)",
                "salesforce-alm 54.4.0 (core)",
                "schema 2.1.1 (core)",
                "sfdx-cli 7.153.0 (core)",
                "signups 1.1.2 (core)",
                "source 1.10.1 (core)",
                "telemetry 2.0.0 (core)",
                "templates 54.8.0 (core)",
                "trust 1.1.0 (core)",
                "user 2.0.2 (core)"
        ],
        "osVersion": "Darwin 21.4.0"
}

Additional information
Feel free to attach a screenshot.

@mnunezdm we have identified the issue and are working on a fix. Thanks for reporting the issue.

Hey @mnunezdm, the fix for this was included in sfdx v7.153.1 which is currently latest, let us know if it works for you, thanks!
cc @WillieRuemmele

Hello @cristiand391 I've just checked and seems that this fixes the error
Thx!
Feel free to close the issue!


Upgrade to newer JSONLD

@The-Alchemist Thanks for picking this up. Unfortunately, we can't accept your contribution without you having signed the Eclipse Contributor Agreement. Please have a look at the contributor guidelines, in particular the points on how to sign the ECA. Let me know if you need any help with any of it.

@jamesrdf : strange, it says for me that I have a valid ECA:

You have to use the sign-off flag in git to confirm. To change this PR you can checkout your local branch then run "git commit -s --amend" then force push your chances "git push origin patch-1 --force"


Remove trailing commas so we will run in ie8

This is pretty straight forward. Trailing commas cause issues in older versions of IE.

Trailing commas is a feature because they are diff-friendly. I'm not sure why you would want to execute defs.js within IE8 (I'm genuinely curious) and it's not a supported platform, however trailing commas will not be a blocker because after browserify + uglify they are gone.

You are right, this shouldn't normally be much of an issue. In some senarios we were doing client side transpiling of JSX and babel in dev and because of how we were bundling (building) using webpack it hit us.


Add Presets header

Adds a little "Presets" header above the buttons in the theme editing menu.

Can you rename the message to just themePresets or something like that? The _ is for generated message names.

Can you rename the message to just themePresets or something like that? The _ is for generated message names.

Ok, that's been fixed.


fix: Miscellaneous bug bash on stlor-map.

 I'll do my best to catalog them here for posterity.
Bug Fixes

Improve alignment of the search bar and zoom controls on desktop. Previously, there was a 0.5rem difference between the bottom values of the two.

Before
After

Remove max-width constraint on the Menu on mobile. Previously, we set a max-width that could be less than 94% of the viewport—which we use as the width of the Menu—on larger mobile devices.

Before
After

Prevent overlap of mobile controls when search is expanded. Previously, search on mobile filled up 94% of the viewport, which meant that other controls were fully covered when search was open.

Before
After

Fix absent border-bottom, border-bottom-right-radius, and border-bottom-left-radius on tablet viewports. Previously, the border-bottom: transparent, border-bottom-right-radius: 0, and border-bottom-left-radius: 0 values on mobile were not being transitioned to their desktop values at our 640px breakpoint.

Before
After

Improve the smoothness of the menu drawer collapsing transition. Previously, we transitioned max-height whereas we now transition translateY, which can be much more effectively accelerated on the GPU. We also include a single SVG icon for our caret (as opposed to two) and apply a nicer transform: rotate(180deg) transition on it.

Before
After

Other Changes

Shifte a few packages listed incorrectly as dependencies into devDependencies, thus shrinking bundle size.
Replace lodash.<module> dependencies with lodash-es. While the former strategy of module-level package imports used to be recommended to keep bundle sizes small, the Lodash team recommended moving away from them in preparation for a (seemingly never arriving) v5. lodash-es is a tree-shakeable ESM distribution of lodash and can be effectively tree-shaken by Vite, which is perfect for our purposes.
Switch to using d3-scale-chromatic to access schemePaired directly rather than inlining hex code values.
Consistently lift constants into const definitions throughout.
Comments and doc strings throughout.

#24 is maybe the most beautiful PR I've ever seen in my life


Unable to use Anthropic Model

Hi, I'm trying to test it on my local. I'm a bit confused on how to make it work with only an Anthropic Key, without providing openai key.
The following is terminal my command:
docker run --platform linux/amd64 --rm -it
  -e config.model=anthropic/claude-3-5-sonnet-20240620
  -e ANTHROPIC.KEY=...
  -e GITHUB.USER_TOKEN=...
  codiumai/pr-agent
  --pr_url "$pr_url" "improve"
  --pr_description.keep_original_user_title=true
  --pr_code_suggestions.commitable_code_suggestions=true

These are the following output:
  File "/usr/local/lib/python3.10/site-packages/litellm/utils.py", line 6913, in exception_type
    message = original_exception.message
AttributeError: 'OpenAIError' object has no attribute 'message'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/app/pr_agent/algo/ai_handlers/litellm_ai_handler.py", line 145, in chat_completion
    response = await acompletion(**kwargs)
  File "/usr/local/lib/python3.10/site-packages/litellm/utils.py", line 3181, in wrapper_async
    raise e
  File "/usr/local/lib/python3.10/site-packages/litellm/utils.py", line 3017, in wrapper_async
    result = await original_function(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/litellm/main.py", line 296, in acompletion
    raise exception_type(
  File "/usr/local/lib/python3.10/site-packages/litellm/utils.py", line 8182, in exception_type
    raise original_exception
  File "/usr/local/lib/python3.10/site-packages/litellm/main.py", line 283, in acompletion
    response = await init_response
  File "/usr/local/lib/python3.10/site-packages/litellm/llms/openai.py", line 439, in acompletion
    raise e
  File "/usr/local/lib/python3.10/site-packages/litellm/llms/openai.py", line 402, in acompletion
    openai_aclient = AsyncOpenAI(
  File "/usr/local/lib/python3.10/site-packages/openai/_client.py", line 296, in __init__
    raise OpenAIError(
openai.OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/app/pr_agent/algo/pr_processing.py", line 272, in retry_with_fallback_models
    return await f(model)
  File "/app/pr_agent/tools/pr_code_suggestions.py", line 341, in _prepare_prediction_extended
    prediction_list = await asyncio.gather(
  File "/app/pr_agent/tools/pr_code_suggestions.py", line 175, in _get_prediction
    response, finish_reason = await self.ai_handler.chat_completion(model=model, temperature=0.2,
  File "/usr/local/lib/python3.10/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
  File "/usr/local/lib/python3.10/site-packages/tenacity/__init__.py", line 314, in iter
    return fut.result()
  File "/usr/local/lib/python3.10/concurrent/futures/_base.py", line 451, in result
    return self.__get_result()
  File "/usr/local/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
    raise self._exception
  File "/usr/local/lib/python3.10/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
  File "/app/pr_agent/algo/ai_handlers/litellm_ai_handler.py", line 146, in chat_completion
    except (openai.APIError, openai.Timeout) as e:
TypeError: catching classes that do not inherit from BaseException is not allowed

see https://qodo-merge-docs.qodo.ai/usage-guide/changing_a_model/#changing-a-model

see https://qodo-merge-docs.qodo.ai/usage-guide/changing_a_model/#changing-a-model

I have made both configurations.toml and .secrets.toml, but same result with the command I have.
Does this mean, that I have to deploy our own docker-image with the configs?
Sorry, new to this. Command works with OPENAI.

if you run via pre-built docker, do:
docker run --platform linux/amd64 --rm -it
  -e config.model=anthropic/claude-3-5-sonnet-20240620
  -e config.model_turbo=anthropic/claude-3-5-sonnet-20240620
  -e config.fallback_models=['anthropic/claude-3-5-sonnet-20240620']
  ...

or something similar

Thank you @mrT23!
Though using anthropic/claude-3-5-sonnet-20240620 it can't find the MAX_TOKENS. I used anthropic/claude-3-opus-20240229 for now.
Full command that works:
docker run --platform linux/amd64 --rm -it
-e config.model="anthropic/claude-3-opus-20240229"
-e config.model_turbo="anthropic/claude-3-opus-20240229"
-e config.fallback_models="anthropic/claude-3-opus-20240229"
-e ANTHROPIC.KEY=...
-e GITHUB.USER_TOKEN=...
codiumai/pr-agent --pr_url "$pr_url" "$review_command"
--pr_description.keep_original_user_title=true
--pr_code_suggestions.commitable_code_suggestions=true

https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/algo/__init__.py#L56
also:
https://qodo-merge-docs.qodo.ai/usage-guide/changing_a_model/#custom-models


Add more cluster information to subctl info

Currently subctl info only shows cluser network information. It is not enough to know current status of deployment and is missing other useful information too. It should be enhanced to show additional information like:

Status of all services/daemonsets, gateways including which node is current leader etc.
Connectivity status
Cable driver in-use.
Anything else that is useful in determining health of deployment and/or helps with initial troubleshooting.

@maayanf24 if you comment on the issue I can assign it to you, since you're looking at it.

I'm working on this issue

@maayanf24 see the comment here: https://groups.google.com/forum/#!topic/submariner-dev/EEyaG5iDg6M now we have submariner-io/enhancements repo where we can add the document explaining the plan.

Will subctl info become deprecated ?
If so, please add it to the docs too, thanks!


[AAP-8470] Added support for vars namespace

https://issues.redhat.com/browse/AAP-8470
Allows conditions to contain data from the variables or environment variables passed via --vars or --env-vars
e.g.
    event.address.street == vars.person.address.street
    event.year in vars.person.address.years_active

Supports string, integer, floats, booleans, list.

@Alex-Izquierdo @ttuffin Had to rebase since the float PR got merged, I added support for floats


Please sign assembly with a strong name

The application I use this NuGet package in has strongly named assemblies, so when I update this package, I have to manually sign the assembly.  Not difficult, but it would be nice if it came signed.

Also facing this issue trying to update to v5.4.0 from v5.3.0

Yeah, that would be really great, if you can sign the assembly in the next release!

Facing this issue as well

Please publish a signed version

nvm... just found this blog fixing the strong name issue easily: https://www.nuget.org/packages/strongnamer


fix(rebranding): Update the ascii art

Suprised you did not take the opportunity to write "Mielisearch" instead

bors merge

bors merge

bors merge


Add e2e tests for PowerVS CSI Driver

Explore other CSI Driver platforms about how the e2e testing is done
Add e2e test cases for Power VS CSI Driver

/assign

Exploring Amazon EBS CSI Driver e2e test cases
Setting up the e2e suite for Power VS CSI Driver (e2e suite with pre provisioned volumes)
Debugging issues in the sample test case

Updates:

Installed CSI Driver on the new cluster in upstream-core-lon04 resource group and deployed sample application
Sample application deployment fails as volume attachment fails with the error

Warning  ProvisioningFailed    2s (x3 over 5s)  powervs.csi.ibm.com_powervs-csi-controller-56d978f56f-v75k9_d1c4f97d-565c-46e2-be90-59869eaaf739  failed to provision volume with StorageClass "powervs-sc": rpc error: code = Internal desc = Could not create volume "pvc-926dfeca-800a-4d8a-b3ee-b28327ef7bbb": invalid PowerVS VolumeType "Tier3-Flash-1"

Volume created from the script matches with the tier of the cloud instance, But it doesn't match with Flash type
Debugging create volume with power vs rest APIs


Enable opts as second arg in build, buildTree & buildSFX

Check if second arg is options instead of outFile. added "isPlainObject" helper. Falls back if Object.getPrototypeOf is not defined.

@origin1tech kills build, since typeof null === 'object' but  Object.getPrototypeOf cannot be called on null (wat)
@guybedford slightly uncomfortable with type based approach dispatch here - a very fancy way to essentially sugar omitting the second parameter.
Would favour switching argument order in the 0.17 release instead, then outFile can simply be omitted. Is it common to instantiate a Builder without passing opts?

Thanks, I've commented in line.


Applicable to internal service catalog publishing?

Is this customer usage attribution applicable to managed app that are published into an internal service catalog?
https://docs.microsoft.com/en-us/azure/managed-applications/publish-service-catalog-app does not state any requirement for GUID registration.
Additionally, the link https://aka.ms/listonazuremarketplace towards the submit form appears to be outdated. After submitting I received an automated mail from your team with a new pointer to http://aka.ms/joinmarketplace. Is it required to join marketplace juist for publishing towards an internal service catalog?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db44bc8f-a6d7-8651-165d-929230435633
Version Independent ID: c7847825-9d79-419e-a177-aca5872f1431
Content: Azure partner and customer usage attribution
Content Source: articles/marketplace/azure-partner-customer-usage-attribution.md
Service: marketplace
GitHub Login: @yijenj
Microsoft Alias: yijenj

@cveld
Thanks for your feedback! We will investigate and update as appropriate.

adding @qianw211 to review the request

@femisulu please contact the authors of this article, as we don't own the Azure Managed Apps docs.  The link to the registration form should be updated, see the end of the following article for more information:
https://docs.microsoft.com/en-us/azure/marketplace/marketplace-publishers-guide

@qianw211 can you suggest who the main author should be. I assumed you were one of the authors on the article since your name shows up as an author. Would appreciate any help to identify the appropriate author.

@femsulu It seems that @tomfitz is the author listed.

adding @tfitzmac for input

@femsulu and @ tfitzmac, is this issue resolved? It's seems still assigned to me... Thanks!

@cveld - you do not need to join the marketplace to publish a service catalog app. The customer usage attribution is not applicable to service catalog apps.
All the steps to create and publish a service catalog app are shown in Publish an Azure managed application definition and Deploy service catalog app through Azure portal.

#please-close


chore(main): release 0.15.3

:robot: I have created a release beep boop
0.15.3 (2023-04-10)
Continuous Integration

build: fix file name again (#94) (52107ff)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/thesis/releases/tag/v0.15.3 :sunflower:


docs: Update Node.js doc imports after v0.8.0

Follow up to #5517
⚠ PUBLISH AFTER v0.8.0 RELEASE

Since we are a few hours from release, can we get this one merged now?

We can merge after. Is there a reason to do it sooner?


Add rename device example to documentation

Add a command example to rename a device

Added to README and to PacketPushers article


remove duplicate interfaces

This PR fixes #153279

closing bc the author of that issue actually made a PR that does the same thing. there were two of them in each file


differentiable physics tutorial missing module brax

When I run the Imports and installations section of differentiable physics tutorial I am getting the following import error
ModuleNotFoundError                       Traceback (most recent call last)
[<ipython-input-10-b1c0dcecae40>](https://localhost:8080/#) in <cell line: 14>()
     12 config.update("jax_enable_x64", True)
     13 config.update('jax_default_matmul_precision', jax.lax.Precision.HIGH)
---> 14 from brax import math
     15
     16 # Sim

ModuleNotFoundError: No module named 'brax'

---------------------------------------------------------------------------
NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.

To view examples of installing some common dependencies, click the
"Open Examples" button below.
---------------------------------------------------------------------------

I think the noteboot forgot to provide instruction to install brax
!pip install brax

I will submit a fix for this.


could I transferred the paper's idea to object detection task?

Recently, do an object fine-grained detection task, is it convenient to transferred to object detection?
thanks

in the revised version of the paper, i share results on ms-coco detection task, with MTResNet backbone, where switching pretraining from 1K to 21K improved results.
some people said in the git that with resnet50 they were not able to get an improvement.
i dont know, i suspect they might had a bug in loading the weights.,
since resnet50  is a crappy network anyway, my recommendation is not to use it, and switch to mtresnet (or MBV3).
the original 1K weights can be found at:
https://github.com/Alibaba-MIIL/TResNet/blob/master/MODEL_ZOO.md


Alias fields

resolves #241

Coverage increased (+0.5%) to 86.224% when pulling c213af8635f3fc5de9110a9576a89a61781ca011 on alias-fields into c1e1ba40ae0b5e5239d34947a19eba4eb0602344 on main.


Automate forking workflow for testing and local development

This PR adds a chain spec extension that allows the user to configure the block heights at which various forks will take place manually.
The dev chain now has a fork happen automatically every 10 blocks until block 30 when we are done.
There is also a manual mode that we will use in class when we run the workshop live so that students can hard code their forking logic.
As a side effect, this PR also breaks instant seal. That's okay because we decided in #45 that we want to take a different "easy pow" approach instead.

I'm going to merge this because I want the docker image.


Receiving a callback when a Toast is tapped not trigger in Android

hi @EddyVerbruggen
I am using =>
Cordova Cli 6.0 + Cordova-Android 5.1.1 + cordova-plugin-crosswalk-webview 1.5.0 + cordova-plugin-x-toast 2.4.2 + Android 4.4.2 (my device)
according to this
https://github.com/EddyVerbruggen/Toast-PhoneGap-Plugin#receiving-a-callback-when-a-toast-is-tapped
Receiving a callback when a Toast is tapped
I test many times，iOS no problem at all，but in Android，when Toast is tapped but no trigger
if (result && result.event) {
        console.log("The toast was tapped");
        console.log("Event: " + result.event); // will be defined, with a value of "touch" when it was tapped by the user
        console.log("Message: " + result.message); // will be equal to the message you passed in
        console.log("data.foo: " + result.data.foo); // .. retrieve passed in data here
      }

Something changed on Android. I've adjusted the implementation and now it should work better. Available in 2.5.0 (releasing it in a minute).

hi @EddyVerbruggen
I tried 2.5.0 version and tried many times but seem still not work
I am using =>
Cordova Cli 6.0 + Cordova-Android 5.1.1 + cordova-plugin-crosswalk-webview 1.5.0 + cordova-plugin-x-toast 2.4.2 + Android 6.0 (my device)

Same here.
Events are working fine under iOS but not on Android.
2 Samsung devices: Android 5.1.1 and Android 6.0.1

Are you able to debug it a little in Android Studio?

@EddyVerbruggen
I was now building the app in Android studio. In the Emulator the click on a toast message works as expected. If I build it with the ionic CLI (ionic build android) and then install it on my physical device the click on the toast message is not fired.

I justed (perhaps) fixed an issue on Android < 5 devices regarding the tap.. couldn't reproduce on Android 5+ though.

Same issue fr me on plugin v 2.5.2. The click on toast callback is fired in iOS but not Android. I'm using an Android 5.1 device.

hi @EddyVerbruggen
still some trouble in android (even 6 version)
same with @blattmann and @peterturquoise

hello @EddyVerbruggen
2 months passed
anything wrong ?

I can't reproduce it. That's the problem. If someone can please at least attempt to fire up Android Studio and try to fix it.

hi @EddyVerbruggen
just like @blattmann said
in the Emulator the click on a toast message works as expected
but my physical device（mine is HTC M9，Android 6.0） the click on the toast message is not fired（Android > 5）

I can't test that since I don't currently own an Android 6 device.

thanks @EddyVerbruggen reply
well...
maybe if you have free time and one day have a Android 6 device，you can try for this
Cheers

Same issue on Android OS 6.0 :(
(Android LG G3)

Hi Eddy,
I am facing the same issue on Android 6.0, click on toast callback is not called.
Could you please check.
I am using cordova-plugin-x-toast 2.6.2,
Thanks in advance.


link to bot commands in pull requests

This is a Bug Report
In pull requests, messages from the k8s-ci-robot show a link to the list of prow commands. However, there is a link ("here") that refers back to the PR not to the command list.
Problem:
Investigate if the "prow command" link is incorrect. If the link is invalid, fix the link to the prow command help.
The full list of commands accepted by this bot can be found here.
Proposed Solution:
The link does not point to https://prow.k8s.io/command-help?

The full list of commands accepted by this bot can be found here.

/sig testing

#21874 has a correct link but #21875 does not. So it seems that this problem was introduced at some time between Jun 19 and Jun 20?

this is best tracked in https://github.com/kubernetes/test-infra/issues/18622
/triage duplicate
/close

I think this was https://github.com/kubernetes/test-infra/pull/17784#issuecomment-650772422 and may already be fixed


Search all files in specified folder for mac

Issue Type: Feature Request
In the Windows version, you can search all the files in the folder specified in the file explorer, but since it is not possible in the Mac version, please add a function.
VS Code version: Code 1.37.1 (f06011ac164ae4dc8e753a3fe7f9549844d15e35, 2019-08-15T16:16:34.800Z)
OS version: Darwin x64 18.7.0

This works just fine on the mac

Check in all languages. Not displayed in Japanese version.
Do not close all versions without checking them.

This works just fine on the mac

Check in all languages. Not displayed in Japanese version.
Do not close all versions without checking them.

@masahirokjp this is unrelated to the language used.
Please try using vscode insiders https://code.visualstudio.com/insiders/


Fix presentation of man page tables

Currently the use of "*" in tables is causing go-md2man
to screw up the format of the man page.
This PR removes the "*" since it is not really necessary.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

LGTM


BUG:contact form

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?
in dark theme contact background and text not changed ,
in dark theme whole theme change with a contact page

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Varsani2520 go ahead send screenshot alse while creating pr.

ok @mdazfar2


Quantum Entangloporter broken after server restart

I found out that there seems to be a problem with the Quantum Entangloporters when Galacticraft is installed. It's exactly the same like in other Topics described. After a server restart every type of pipes (Universal Cable, Logistical Transporters, pipes from Buildcraft etc.) disconnects from the entangloporter and it's not possible to reconnect them without creating a new channel. However I think it doesn't happen in singleplayer.  If thats important i tried it with these versions:
-GalacticraftCore-<IP_ADDRESS>.12.375
-Galacticraft-Planets-<IP_ADDRESS>.375
-Mekanism-1.7.0-<IP_ADDRESS>6
-MekanismGenerators-1.7.10-<IP_ADDRESS>6
-MekanismTools-1.7.10-<IP_ADDRESS>6
-MicdoodleCore-<IP_ADDRESS>.12.375
and Forge 1558 for 1.7.10
edit: Okay also happens with forge 1614 and Mekanism-...-278 and without Galacticraft.
strangely pressurized tubes do not disconnect

Mod interaction issue, I assure you.  Been reported several times in the past.

Yes I read that in other threads. but interaction with what? I do not have another mod installed besides Mekanism.

Ah, I didn't see your edit. Does this constantly happen on multiplayer or is it on and off? Are you sure you can't reproduce in single player?

I'm doing some testing on a server and I'm unable to reproduce this as you've stated.  I'm using the exact version of Forge mentioned.

At least for the 5 times i tried it now it happens constantly. And yes I can't reproduce it in single player (leaving the world, and loading it should be enough right?), ah okay found out that if i open the world to lan in singleplayer it also happens in singleplayer.

Fixed, once and for all.  Thanks.


Example of palette theming in stable documentation does not work

I have been struggling a lot with customizing colors. I tried to just cut and paste the example code here https://makie.juliaplots.org/stable/documentation/theming/#palettes (also pasted below)
using CairoMakie

f = Figure(resolution = (800, 800))

Axis(f[1, 1], title = "Default cycle palette")

for i in 1:6
    density!(randn(50) .+ 2i)
end

Axis(f[2, 1],
    title = "Custom cycle palette",
    palette = (patchcolor = [:red, :green, :blue, :yellow, :orange, :pink],))

for i in 1:6
    density!(randn(50) .+ 2i)
end

set_theme!(Density = (cycle = [],))

Axis(f[3, 1], title = "No cycle")

for i in 1:6
    density!(randn(50) .+ 2i)
end

f

Expected behavior: the output plots in the documentation
Actual behavior:
MethodError: no method matching add_cycle_attributes!(::MakieCore.Attributes, ::Type{MakieCore.Combined{Makie.density}}, ::Makie.MakieLayout.Cycle, ::Makie.MakieLayout.Cycler, ::Observables.Observable{Any})

Closest candidates are:

add_cycle_attributes!(::Any, ::Any, ::Makie.MakieLayout.Cycle, ::Makie.MakieLayout.Cycler, !Matched::MakieCore.Attributes) at C:\Users\andyd\.julia\packages\Makie\vwpRo\src\makielayout\layoutables\axis.jl:613

var"#plot!#339"(::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}, ::typeof(MakieCore.plot!), ::Makie.MakieLayout.Axis, ::Type{MakieCore.Combined{Makie.density}}, ::MakieCore.Attributes, ::Vector{Float64})@axis.jl:687
plot!@axis.jl:684[inlined]
var"#plot!#340"(::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}, ::typeof(MakieCore.plot!), ::Type{MakieCore.Combined{Makie.density}}, ::Makie.MakieLayout.Axis, ::Vector{Float64})@axis.jl:701
plot!(::Type{MakieCore.Combined{Makie.density}}, ::Makie.MakieLayout.Axis, ::Vector{Float64})@axis.jl:700
var"#plot!#958"(::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}, ::typeof(MakieCore.plot!), ::Type{MakieCore.Combined{Makie.density}}, ::Vector{Float64})@figureplotting.jl:48
plot!@figureplotting.jl:46[inlined]
#density!#742@recipes.jl:37[inlined]
density!(::Vector{Float64})@recipes.jl:37
top-level scope@[Local: 7](http://localhost:1234[...]#)[inlined]

I ran this in a Pluto notebook, and I had previously run commands like set_theme!
I re-ran the notebook but I did not restart it. It (shouldn't?) matter since Pluto notebooks do not have hidden state, but nonetheless seems to have caused an error.

Did you make sure you're on the versions listed by the docs?
They're right at the bottom:


Add support for "dynamic" configuration

This is a replace of PR #206 including only the additional support for request url and generic configuration.
This PR do not break existing configuration and can be used in combination with existing configuration.
The change add the following optional query parameters:
token=<token>&profile=FGT40F

In the fortigate-key.yaml the above profile is define as a "normal" entry like:
FGT40F:
  probes:
    exclude:
      - Switch/ManagedSwitch
      - Wifi

With this configuration, an entry in  fortigate-key.yaml becomes a sort of "profile" that during the Prometheus discovery can be defined based of model, adom etc and what ever is available during the Prometheus discovery phase.
The existing way to configure and the above can of course coexists in the fortigate-key.yaml like:
FGT40F:
  probes:
    exclude:
      - Switch/ManagedSwitch
      - Wifi

"https://localhost:443":
  token: XXXXXXXXXXXXXXXXXXXXXXXXXXXX
  probes:
    include:
      - System

@bluecmd to you feel it is okay? Have tried to do it as you requested in #206

Looks good, thanks! :)

:tada: This PR is included in version 1.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to get responses from initSdk function

Report
Plugin Version
ℹ cordova -plugin-appsflyer-sdk - 4.4.18
On what Platform are you having the issue?
ℹ Angularjs and ionic - 4.5.0
What did you do?
ℹ I have moved appsflyer.initSdk function to other js file. i am unable to get any error or success callbacks from the appsflyer.initSdk function in other js file (without using main.js).
What did you expect to happen?
ℹ Based on our business logic, i need to call appsflyer.initSdk function in other js file (without  using main.js)
What happened instead?
ℹ It is not showing any responses at first call.when i try to call intSdk function in any other js file. I am not shown any sort of error or success message in first call. but when i close and open the application,it functions properly
Please provide any other relevant information.
ℹ First call and second call responses.
First call
/com.fam.card01 D/AppsFlyer_4.8.19: didConfigureTokenRefreshService=false
/com.fam.card01 W/AppsFlyer_4.8.19: Exception while collecting facebook's attribution ID.
/com.fam.card01 I/AppsFlyer_4.8.19: IMEI was not collected.
/com.fam.card01 I/AppsFlyer_4.8.19: Android ID was not collected.
Second call
/com.fam.card01 D/AppsFlyer_4.8.19: didConfigureTokenRefreshService=true
/com.fam.card01 I/AppsFlyer_4.8.19: AppsFlyerLib.sendTrackingWithEvent
/com.fam.card01 I/AppsFlyer_4.8.19: url: https://t.appsflyer.com/api/v4/androidevent?buildnumber=4.8.19&app_id=com.fam.card01
/com.fam.card01 I/AppsFlyer_4.8.19: data: {"country":"xx","kef6365":"xxxxxx","af_timestamp":"xxxxx","appsflyerKey":"R********************J"}
Thanks in advance.

@a6un Thanks for reporting this issue!
The problem now solved and you will get an ''Failed'' or ''Success'' message.
if you want to get more info from the init function please add "onInstallConversionDataListener: true" inside the options you send to the function.


[BEAM-14341]: BigQuery Storage Connector trace id population missing bracket

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Run PostCommit_Java_Dataflow

Can one of the admins verify this patch?

Test failure is pubsublite ReadWriteIT, which I just disabled in #17415. Merging.


Issue with CustomValidators.phone('de-CH')

Validation of a 'ch-DE' phone number isn't working with current version 4.2.0. It fails after three digits.
Workaround is setting version back to 3.9.1

I had a similar issue with 'en-IN'. It was fixed by using 'IN' instead of 'en-IN'. Apparently, country metadata expects it in this format.

@baljeet I already did that and it worked but the resulting validation was crappy. It didn't check for chars like 'A' or 'W' and the phone number was valid after a certain amount of characters.


Feature request: edit AI answer/submit text as AI reply

Sometimes AI generates pretty good response, but it gets small detail incorrectly, or you just want to add details to the reply, or you want to guide the discussion. It would be cool to edit AI message, at least the last one. (Though general editing is even better)
For example it can be made by adding  "Say as the character" button which will take the current text from send_textarea and say it from the character's PoV rather than from the PoV of the player
Proof of concept
https://github.com/TavernAI/TavernAI/compare/main...Maykeye:TavernAI:say_as_ai
I'm not sure if it's how messages should be saved, so not PR

Yes such an option is planned

Function added


Devcontainer-updates

ignore env files and update devcontainer to behave the same as biblio-backoffice (use docker volumes)

@nics Could not upload files after first build. This error was logged:
ERROR   ctx/ctx.go:136  operation error S3: PutObject, https response error StatusCode: 404, RequestID: 17C9CC78C5BB24E3, HostID: 7f397c59f622c45d3d572587aab6357e63a713a3cc8f8426e6cdd785ef5470cd, api error NoSuchBucket: The specified bucket does not exist

I noticed the "minio/mc" conainer (named "minio-mc-1") was not running and logged this error:
mc: <ERROR> Unable to initialize new alias from the provided credentials. Get "http://minio:3171/probe-bsign-fepyta3dyes1d452gp42md5mtivbyl/?location=": dial tcp <IP_ADDRESS>:3171: connect: connection refused.
Bucket created successfully `devcontainer/deliver`.

After I started it manually, uploading worked. Also after reopening the devcontainer the issue was gone and all tests succeed.
Not sure if this should be blocking.

Got it to work in Firefox, however Safari keeps acting up when creating folders even after I throw out cookies and surf via a private window.
Not sure if it works in Firefox because I tried restarting minio-mc-1, because it kept exiting.

@mietcls minio-mc is the minio client; it only creates the bucket and then exits
@verheyenkoen i think fixed this in the latest commit

@nics That seems to resolve it indeed.


kitty not show image

I just tried using this package today and it also doesn't work for me

same issue

Can you try without pandas to narrow down the cause? Running matplotlib directly works for me (in both ipython and cpython):

Also can you confirm which version of the module you are using? There was a recent commit to address ipython support with pandas but if you installed via pip you likely got an older version without this patch (#16). If so may be worth trying to clone the version from the repo directly to see if this fixes your problem.


Fix scroll

When the panels are higher than the window, bad stuff happens. We should handle scroll inside the pane itself

That one is not that easy unfortunately. The obvious solution would be to set {max-height: 100%; overflow: auto}Because we have overflowing controls (the color picker or the joystick) we would have artefacts such as this one:
Before:

After:

Of course we could try tricks such as setting position: fixed on the color picker, or put them in portal that would be a sibling of the root, have a scroll listener on the root so that we can reflow the color picker at the right position, but that's a lot of troubles tbh.
One potential quick fix would be to only add overflow: auto to the root only when its height is greater than the window height. We would still have the clipping issue for color-pickers at the very bottom of the pane but that's an acceptable trade-off imo.

Ideally we should portal the color picker and other floating elements to a container outside of the overflow-hidden one, that would be the safest solution. Do we have that kind of control for the colors? (I guess we do for the joystick input)

Just that wouldn't work because of the scrolling + we would have to set the initial position manually with js. Not saying it's impossible, but handling the sync is ugly and adds some logic. Maybe v1.1?

What about manually checking if it overflows the window and setting overflow-y: auto accordingly?
Could be done after the drag is finished as well.

What about manually checking if it overflows the window and setting overflow-y: auto accordingly?
Could be done after the drag is finished as well.

Yes we could do that. Then I guess could also manage in which direction should the overlays pop (either on upwards or downwards, depending on their position on the screen).

Yes we could do that. Then I guess could also manage in which direction should the overlays pop (either on upwards or downwards, depending on their position on the screen).


Change how streams without a description are shown

At present, a stream without a description looks like this:

Instead, we should make what's shown depend on whether the user has permissions to edit the stream description.

With permissions: "Add a description", linking to the General panel of the settings UI for this stream
Without permissions, we should just leave the description blank in the top bar.

@zulipbot claim

@zulipbot claim

"Add a description" should be a link or normal text ?


check image flip with mode=1 for head_cam

see comments in https://github.com/ipa320/cob_robots/pull/541#pullrequestreview-3712086

mode=1 seems to be used https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_hardware_config/cob4-2/config/image_flip_params_head_cam.yaml#L3
Is this behavior satisfying?
@ipa-fmw @ipa-nhg please comment and close

Can be closed, @ipa-rmb solved the problem with this PR: https://github.com/ipa320/cob_perception_common/commit/61312f7ad5e501fb40b020b99e322caea3f01f6a


Focus colour is not working

@anday013  There is an issue in the library. I just created the sample app and found that the focusColor prop doesn't work when I use the borderColor in the pinCodeContainerStyle theme prop.
Here I attached the screenshots to explain the issue

Hi @KamranBarlas111 , I see the problem. Thank you for bringing it up. I'm preparing a fix :)

@anday013 Thank You So Much. It's working fine now


Action fails to decorate PR when text is too long

I just ran this action in a repo where the action failed with the error below and no content at all was posted to the workflow.
Would it be possible, in these cases, to leave a PR comment with the semantic of "The dependency review found new vulnerabilities in this change but was unable to display them here. You can see them in the output of the build here: <link to the action output/logs>" ? I know that a failed Check already has some of this semantic, but creating a comment provides a place to centralize discussion and clarity to developers.
Additionally, of course, maybe consider reviewing the output format to get more compact output in these cases by removing the "Scanned manifest files" section or trimming vulnerability descriptions to a fixed number of characters?
Warning: Unable to comment summary to pull-request, received error: Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"}

@henriquevcosta thanks for the report. Can you post the configuration you're using for the Action?


Remove Triplebyte because they are shutting down

You might want to remove the Triplebyte entry that always appears from the list. They've announced that they're being acquired by Karat and shutting down Triplebyte as a service in this blog post. Maybe Karat will roll out something like Triplebyte with their brand on it eventually, but based on the blog post, that won't be before Triplebyte shuts down.

Thanks! I missed a notification on this.

Thx again, @spolisar , should be gone now.


Adds a line break on cleaning the text for the u tag

String msg = "test on fire";
msg = Jsoup.clean(msg, Whitelist.simpleText());
System.out.println(msg);

Output:
t
est
on
f
ire

Seems to be a bug in the pretty print code. Simply parsing the HTML fragment and outputting it with pretty print enabled will lead to the same result.

pretty print code ? do you mean of the java System.out.print ? or with jsoup itself ?

https://jsoup.org/apidocs/org/jsoup/nodes/Document.OutputSettings.html#prettyPrint-boolean-

(If you add a
 at the start the output is OK. So it's because the pretty printer is line breaking inline els when in a block el. That would be the fix. Would be nice to rebuild that all, it's a bit hairy.)

Thanks, fixed with 279fbe120c5bd4221478481b78d31ddf41475360


IndexError while annotate certain skill

Describe the bug
while using skill_extractor.annotate(text) to annotate certain skill it returns error
To Reproduce
Here are some examples to reproduce the behavior:

text= "IDS/IPS sensors are collecting"
skill_extractor.annotate(text)
the main error is resulted from the skill "IDS"

@GordonYeh39, Thanks for the snippet that reproduces the error.
There was a small bug that occurs when not handling accordingly low surface skill.
The bug is now fixed:

P.S: The fix will be taken into account in the next release.


[ML-42739] Add custom forecasting data splits

[x] unit tests
[ ] manual e2e tests
[x] add comments

Can you add more details in the PR description


fix "Closing split bill doesn't refocus on composer" on web/desktop

Details
In PopoverMenu component, props.onItemSelected(item); should be called first. And then item.onSelected(); should be called after onModalHide callback.
This is already done in native side: https://github.com/Expensify/App/blob/main/src/components/PopoverMenu/index.native.js
We no longer need platform specific handling for this component.
So remove current index.js and rename index.native.js to index.js
Fixed Issues
$ https://github.com/Expensify/App/issues/10888
PROPOSAL: https://github.com/Expensify/App/issues/10888#issuecomment-1245652236
Tests

Login with any account on desktop or web.
Click on any report in LHN.
Click on + icon on left end of composer.
Click one of Request money / Split money / Split bill.
Click cross icon to close this modal page.
Verify that composer input is focused automatically

NOTE: It's intended behavior to prevent focus on touchable devices (native, mWeb) after navigating back from modal screens. reference: https://github.com/Expensify/App/blob/fbf0334713e7e8d73507e30a8b12c941d9b46670/src/pages/home/report/ReportActionCompose.js#L168-L174

[x] Verify that no errors appear in the JS console

QA Steps

Login with any account on desktop or web.
Click on any report in LHN.
Click on + icon on left end of composer.
Click one of Request money / Split money / Split bill.
Click cross icon to close this modal page.
Verify that composer input is focused automatically

[ ] Verify that no errors appear in the JS console

PR Review Checklist
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots
Web
https://user-images.githubusercontent.com/96077027/196853192-5006f8d1-5069-4f0e-b474-a514dd622ce7.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/96077027/196853143-7bbc51e5-bf59-42fd-8025-a08ca8b82550.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/96077027/196853167-006e6561-9eec-45c8-9715-c1cd18b0094f.mov
Desktop
https://user-images.githubusercontent.com/96077027/196853089-29ff0d9e-517c-4f4f-a5e9-662d2181fe43.mov
iOS
https://user-images.githubusercontent.com/96077027/196853128-8577adf7-6db1-4428-88de-8bfa23769918.mov
Android
https://user-images.githubusercontent.com/96077027/196853038-84c1cb6e-c040-42cb-8784-e28f94ac4ddc.mp4

@Luke9389 @aimane-chnaif I was just about to test and while checking the code locally, I think we can further refactor this.
We have BasePopoverMenu currently, only because we have two files, index.js and index.native.js. With us merging all code into index.js, BasePopoverMenu is redundant. I feel we should merge BasePopoverMenu itno PopoverMenu/index.js
What do you folks think?

@aimane-chnaif Can you implement the changes requested?
cc - @Luke9389

thanks @aimane-chnaif. Will need 1-2 days to test this as it'll required a good amount of regression suite to test.

Thanks for the changes and patience on this one @aimane-chnaif. Changes look good and test well. I agree with your comment that for mobile devices (app and mweb) we don't want to refocus as it'll popup the keyboard.
@Luke9389 All yours
🎀 👀 🎀
C+ reviewed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/3069065/199849463-1c1540bd-3919-445c-a8e8-ad1582f9d217.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/3069065/199849521-0aceb1a3-11a8-43cc-afb5-d930c9370b81.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/3069065/199849584-facda024-79c9-4a0f-8475-4ddef80e722e.mov
Desktop

https://user-images.githubusercontent.com/3069065/199849610-f0659a32-d9ed-4b56-b737-9c2e92925950.mov
iOS

https://user-images.githubusercontent.com/3069065/199849669-94561efc-74dc-4022-97a8-be87f2976b43.mov
Android

https://user-images.githubusercontent.com/3069065/199849736-9eb42a64-c879-4c23-87db-398ca3ef0179.mov

@Luke9389 Quick bump on this one

@Luke9389 did you get a chance to look at this PR?

Oh man, missed it. Thanks for the bump(s)

@aimane-chnaif did you test this on all platforms (multiple pop-overs, not just the bill split one)?

@Luke9389 @aimane-chnaif Is there anything pending here? Then I can retest with the latest changes and update the checklist again.

@Luke9389  Did you get a chance to look at the previous comments?

@Luke9389 This PR is blocked by your review and approval.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Hi this PR has been linked to a regression here: https://github.com/Expensify/App/issues/13435
I think since this is a lower level change more care could have been applied to test all the existing popovers. In fact, that is what this checkbox is asking us to do.

I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)

@mananjadhav @aimane-chnaif please keep this in mind in the future. If we are making changes to something that is used multiple places it's a good idea to quickly check all the usages of that thing, thanks!

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Why mysqlclient-sys does not provide mysql_ssl_mode enum?

Both bindings_windows.rs and bindings_macos.rs provide  MYSQL_OPT_SSL_MODE variant in mysql_option enum. But only bindings_macos.rs offers values for the option in form of mysql_ssl_mode enum.
There is no word in mysql_options documentation about any Windows incapability according MYSQL_OPT_SSL_MODE.
Would it be possible to add mysql_ssl_mode enum into bindings_windows.rs also?

@weiznich, this was fixed by #28 and can now be closed.

:+1:


webdav is uploading file twice

Hello,
it seems that the file will be uploaded twice. how can i get rid of this?
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 13.95865 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 6.979325 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 20.937975 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 27.9173 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 34.896626 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 41.87595 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 48.855274 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 55.8346 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 62.813927 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 69.79325 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 76.77257 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 83.7519 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 90.731224 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 97.71055 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 100.0 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 53.489662 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 56.979324 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 60.46899 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 63.958652 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 67.44831 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 70.93797 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 74.427635 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 77.917305 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 81.40696 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 84.89662 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 88.386284 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 91.875946 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 95.365616 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 98.85528 completed.
Uploading<PHONE_NUMBER>.3943272.png to /1552322294.522569.png: 100.0 completed.
file:///var/mobile/Containers/Data/Application/HFG467DC-C6C1-4DDE-9A85-71D44C1DEEF2/Documents/1552322291.3943272.png copied to /1552322294.522569.png.
file:///var/mobile/Containers/Data/Application/HFG467DC-C6C1-4DDE-9A85-71D44C1DEEF2/Documents/1552322291.3943272.png copied to /1552322294.522569.png.

the function itself gets called only once, checked with breakpoints
webdav?.copyItem(localFile: path, to: remotePath, completionHandler: nil)

Have you managed to fix the problem yourself? When I'm trying to download a file from FTP, it calls "copyItem()" twice and since this "copyItem" can't overwrite files, the overall thing fails with an error message.


deallocate_all can deallocate smart_pointers that with non-zero reference count

Call to deallocate_all either in python or in C++ is allowed at any point of the process lifetime.
This is dangerous as it allows for free the memory location of smart pointers that still have higher than zero ref counts.
In fact, in the tests tests/tt_eager/python_api_testing/sweep_tests/pytests/tt_dnn/test_matmul.py as part of test setup DeallocateBuffers is the pybind for deallocate_all is called right after op is finished. This causes multiple Buffers to have their underlying mem freed while their pointers are still alive.
We either have to keep track of the smart pointers and make deallocate_all reset them, or get rid of deallocate_all all together and make sure we don't leak.

@TT-billteng I rmr  deallocate_all was  added when we were chasing a lot of bugs / hangs with trying to keep device open across different pytests. If I recall there may have been a mem leak. I don't think anyone ever looked into whether it was resolved or is still being seen.
To test out removal of deallocate_all we could keep track of number of buffers that are still allocated on device close and assert if its > 0.
If we never hit this case then I think this check is still worth having for some "mem leak detection" mode

@tt-asaigal fyi is this is an issue for full async

old issue, still relevant? @mo-tenstorrent

It looks like we are not using smart pointers anymore for the memory buffers so I believe not relevant anymore.


This bug re-occurred for me for version 1.36.2 onwards. My workaround was to remove strictmode.

This bug re-occurred for me for version 1.36.2 onwards. My workaround was to remove strictmode.
Possibly re-introduced by https://github.com/TanStack/router/pull/1734

Originally posted by @tl-frameplay in https://github.com/TanStack/router/issues/1566#issuecomment-2201904780
Original issue:
If the RouterProvider is wrapped in <React.StrictMode>, the status of the Router is alway "pending".
Due to this issue, you can never get the correct resolvedLocation, because this will always return the first location you visited.

@tl-frameplay, I'm unable to reproduce the issue you mentioned. If you are able to create a successful minimal reproduction showing off this StrictMode issue, reply here and I'll reopen this issue.


Use standard merge algorithm when merging Values

While investigating a runtime/GC stall, @aclements noticed that Values.Merge was using a sub-optimal algorithm and that a traditional merge algorithm would likely perform better in general.  He also discovered that the benchmark we were using had a bug which caused the current implementation to appear better when it was actually quite worse in all but one case.
This switches the Values.Merge to use a standard merge algorithm.
benchmark                          old ns/op     new ns/op     delta
BenchmarkValues_Merge-8            729849        47429         -93.50%
BenchmarkValues_MergeSame-8        22544         51528         +128.57%
BenchmarkValues_MergeSimilar-8     247516        49819         -79.87%

benchmark                          old allocs     new allocs     delta
BenchmarkValues_Merge-8            1              1              +0.00%
BenchmarkValues_MergeSame-8        0              1              +Inf%
BenchmarkValues_MergeSimilar-8     1              1              +0.00%

benchmark                          old bytes     new bytes     delta
BenchmarkValues_Merge-8            32768         32768         +0.00%
BenchmarkValues_MergeSame-8        0             32768         +Inf%
BenchmarkValues_MergeSimilar-8     32768         32768         +0.00%

@jwilder two-way merges works best when the two lists are around the same size. Would it be unusual to merge very differently sized lists? If so, could we add a benchmark for that?

@e-dard I'll add those.  Sizes of both lists with usually be different.

@e-dard Added some other benchmarks:
benchmark                           old ns/op     new ns/op     delta
BenchmarkValues_Merge-8             725067        46914         -93.53%
BenchmarkValues_MergeDisjoint-8     23278         24094         +3.51%
BenchmarkValues_MergeSame-8         22181         51152         +130.61%
BenchmarkValues_MergeSimilar-8      250766        49441         -80.28%
BenchmarkValues_MergeUnevenA-8      5111          7141          +39.72%
BenchmarkValues_MergeUnevenB-8      7302          7265          -0.51%

benchmark                           old allocs     new allocs     delta
BenchmarkValues_Merge-8             1              1              +0.00%
BenchmarkValues_MergeDisjoint-8     1              1              +0.00%
BenchmarkValues_MergeSame-8         0              1              +Inf%
BenchmarkValues_MergeSimilar-8      1              1              +0.00%
BenchmarkValues_MergeUnevenA-8      0              1              +Inf%
BenchmarkValues_MergeUnevenB-8      1              1              +0.00%

benchmark                           old bytes     new bytes     delta
BenchmarkValues_Merge-8             32768         32768         +0.00%
BenchmarkValues_MergeDisjoint-8     32768         32768         +0.00%
BenchmarkValues_MergeSame-8         0             32768         +Inf%
BenchmarkValues_MergeSimilar-8      32768         32768         +0.00%
BenchmarkValues_MergeUnevenA-8      0             12288         +Inf%
BenchmarkValues_MergeUnevenB-8      12288         12288         +0.00%


In file sequence test, failing folder not logged

"2019-04-19 15:01:00,471" ERROR i.b.a.a.s.shell (shell.java:108) [main] FILE_SEQUENCE:Sequence  folder :/Users/tbrc/staging/in-progressA/W3CN2612/images/W3CN2612-I3CN2614: Last file index is 2612, but there are 3 files in the folder . not found

Fixed in # #11


Use native lib reference to improve android shake options

Hi,
This is my fork, now i want to make a PR to improve or implement shake options from native lib.
Please check it. It also check & apply successfully.
Thanks, Công
This is our app after applying shake lib https://play.google.com/store/apps/details?id=com.enouvo.app

forked android native lib: https://github.com/congnguyen91/android-shake-detector?organization=congnguyen91&organization=congnguyen91

@congnguyen91 Sorry but this PR has some conflicts with latest code. And please do not commit *.iml files as they are generated by Android Studio.


Clicking on Drivers multiple times from Cluster Management loads different pages

Rancher Server Setup

Rancher version: v2.6-10588abd4becac0864d6b8d653573a7b06850ce4-head
Installation option (Docker install/Helm Chart): Docker install
Proxy/Cert Details: N/A

Information about the Cluster

Kubernetes version: v1.21.3+k3s1
Cluster Type (Local/Downstream): local

Describe the bug
If I go into Cluster Management and then click on Drivers I get a list of drivers. However, if I click on Drivers again, I get a tabular list of clusters.
To Reproduce

Login to Rancher
Click on Cluster Management
Click on Drivers, the list of Drivers will appear
Click on Drivers again, a page with the title Clusters will appear

Result
Expected Result
Clicking on the list of Drivers should always take me to the list of Drivers
Screenshots
Here's a GIF:

Additional context
N/A

Fix verified in v2.6-4b6af95d72dfaef280046ca2ffe13aa7780eaec9-head.

Also verified in master-e904efe724d97ee7d7da08e2d2a3f39cd288f68b-head.


Some tutorials/examples are not showing cells outputs

As an example:
https://ross-rotordynamics.github.io/ross-website/examples/tutorial_part_2.html

At first, I thought it was caused due the lack of .show() command in the end of the line. But if we look to other examples from tutorial part 1, it shows the image without it.

For some reason notebooks will not always store the plots, so we have to execute them during the build process.
I have opened a PR implementing this.

I am reopening this issue since the plots are not showing again.

After migrating things to readthedocs I was still having this problem in some notebooks.
Just to register here, in one case I had to import plotly:
import plotly.graph_objects as go

Even though I was not calling plotly directly in the notebook (was only the rotor.plot_rotor() method).

Once again we have this problem in the Modeling tutorial.
Will check what is happening.

Solved the current issue by trusting the notebooks, adding the following to the imports and rerunning:
import plotly.graph_objects as go
import plotly.io as pio

pio.renderers.default = "notebook"

Reopen this on for the pages below:

[ ] Overview
[ ]

Waiting for #1040 to be solved for this issue.


Group.updateCache offsets the group slightly

If you add a graphic to a group and then call group.updateCache it gets drawn slightly offset. Probably related to issue #1925.
See http://jsfiddle.net/abdno8tw/

This is now fixed in dev.


Change the default filter to All Organisations

What
Change the default filter to All Organisations
Why
We have found from user research that users are having
problems finding content.
We think this is because of the organisation filter which defaults
to the users organisation.
Screenshots
Before

After

Review Checklist

[ ] Changes in scope.
[ ] Added/updated unit tests.
[ ] Added/updated feature tests.
[ ] Added/updated relevant documentation.
[ ] Added to Trello card.

 (2) Make all orgs the default


Add logo to Carousel on home page

Submitted PR #19

https://github.com/turtlemoons/Care-On-Click/pull/19

added logo


support wasm

Can you fix the DCO? Thanks!
https://www.secondstate.io/articles/dco/

DCO is fixed


doc: Clarify arguments of util.process_prior

Looks good, thanks!
@michaeldeistler It's failing because of new black rules, see #810 .
Fix: rebase onto main once #810 is merged.

actually, never mind @musoke. Since this is just change in the doctstring it's fine to be merged as is. Thanks again!

Great!  Thanks for the package!


请问这个问题什么意思呀

The string did not match the expected pattern..

Just like this

作者说demo网页用不了了，你这是作者给的demo吗？

Currently, the entire project has been refactored using Langchain and this issue has been resolved. #81


Add documentation on creating effects and domains

Also:

Use new nested syntax for domain status registration
Add similar entry for domain creation in microcosm.md

Related issues:

https://github.com/vigetlabs/microcosm/issues/254

What kind of change does this PR introduce? (check at least one)
Documentation
Does this PR introduce a breaking change? (check one)
No
Does this PR fulfill these requirements:

[x] All tests are passing
[x] Commits reference open issues

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #275   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          23     23
  Lines         751    750    -1
=====================================
- Hits          751    750    -1

Impacted Files
Coverage Δ

src/addons/presenter.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419d914...9f4dbd1. Read the comment docs.

Nested syntax for domain status registration is less confusing and verbose, I like that.
In seeing all this we need to combine some of what is in the actions section and in the domains section of the docs to explain registering in a single consistent way.
Maybe it's just a matter of changing how it's written everywhere and explaining register() separately. I think adding a note that explains that [action]: this.handleAction is the same as [action.done]: this handleAction which is the same as [action]: {done: this.handleAction} (assuming I am getting that right) would solve this problem for this PR until we rework the sections.

@leobauza you're totally getting that right. I wonder what the best way to handle that would be.

@nhunzaker well, this is a microcosm pattern right? So under architecture under Domain and Effects we should add a new section called The Register Method. With a full explanation of what I said on my other comment. Then you can write the register() method in any of it's three forms as long as we add a note that says something like:
"Confused by the register() method? the architecture section should clear things up"
And we link to that from there. We can also do more explaining about it's origin and how it compares to Redux's switch statements on reducers.

Awesome. Sounds good!
On Tue, Mar 28, 2017 at 2:30 PM Leo<EMAIL_ADDRESS>wrote:

@leobauza approved this pull request.
👍 I am saying this is good and I added what we talked about to #250
https://github.com/vigetlabs/microcosm/issues/250 to better document
register()
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vigetlabs/microcosm/pull/275#pullrequestreview-29535840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkEOCj88PeludYxTyRCz3Du9yB0bea3ks5rqVGzgaJpZM4MrezL
.


Aliased buffers in MPI_Allreduce in hdfio.c and use of possibly uninitialized variable MP_DM

At line 2230 of hdfio.cxx we have
    if (opt.nsnapread>1) {
        MPI_Allreduce(&MP_DM,&MP_DM, 1, MPI_DOUBLE, MPI_MIN,mpi_comm_read);
    }

Intel MPI crashes on this because the send and receive buffers overlap. It's easily fixed by replacing the send buffer with MPI_IN_PLACE.
However, it looks like MP_DM is only set if we compile with -DHIGHRES, which I'm not using so it probably shouldn't execute this line at all. Maybe this should be in a #ifdef HIGHRES?
There's another possible use of MP_DM when it hasn't been set at line 2209:
        opt.Omega_b=MP_B/(MP_DM+MP_B)*opt.Omega_m;

Fixed by adding the MPI_IN_PLACE and wrapping the call in an ifdef


[docs] fix grammatical error in section title

Thanks for this great project! I noticed two minor grammatical issues in the FAQs today, and in this PR I propose fixes for them.
Thanks for your time and consideration.

Thanks a lot for helping out!


test(stableswap): deriveUpperLowerXFinalReserveBounds function and spec

Background
Test this and add a godoc explaining logic in detail:
https://github.com/osmosis-labs/osmosis/blob/6398733549c124cb973eaa20d7aaba0fe6915ab9/x/gamm/pool-models/stableswap/amm.go#L288
Acceptance Criteria

test coverage is maximized
godoc added

Someone with a solid understanding of stableswap should work on this to add a decent godoc
Based on the README, I thought that the lower bound is always 0 but we seem to only set in under a certain condition:
https://github.com/osmosis-labs/osmosis/blob/6398733549c124cb973eaa20d7aaba0fe6915ab9/x/gamm/pool-models/stableswap/amm.go#L304-L305
CC: @ValarDragon @AlpinYukseloglu

If the initial y guess is too small, that implies that it acts as the lower bound.
If the initial y guess is too large, then we keep the lowerbound as 0


GIS: Detectors of semantic types

Add detectors of semantic types to the GIS package:

[ ] longitude/latitude detection (different formats and coordinate systems)
[ ] countries detector
[ ] states and regions detector
[ ] ZIP code detector
[ ] address detectors

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-14818

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16077


Snapchat icon broken in latest development build

About this discussion
The snapchat icon is a "^" in the latest development build.

I don't have snapchat but when searching it in the app, the icon appears to be broken. I'm running this build

Update: it was something on my end, since now it's displaying as expected.


Increase the schema for the user.

Increase the schema in models folder.  It should have name, email, phone number, username, password, profile picture and others as required. We need them to build a profile page.

I would like to work on this issue can i?

Cool

Updates?

I also want to work on this issue

@devyaniChoubey I'll assign you the issue if I don't get any reply from @Sahastracookcoder1 by tomorrow

okk

Assigning it to @devyaniChoubey


Windows不能跟随系统主题切换深色浅色模式

Before feedback
Before you feedback, please search for the issues to see if there are similar problems that can solve your problem.
Please delete the above and the contents of this line, then fill in the feedback form in the following format, Thanks.

Windows10 21H2 Motrix1.6.11
Describe the bug
A clear and concise description of what the bug is.
The question is the same as the title.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS & Version: [e.g. macOS, Windows, Linux]
Version: [e.g. macOS 10.14.2, Windows 10, Ubuntu 18.04]
Motrix Version: [e.g. v1.1.3, v1.1.0]
Installation package type: [e.g. dmg, AppImage]

Additional context
Add any other context about the problem here.

更新 Motrix 版本到 1.8.19+


'format' checks in before_render hook when exception occur is not reliable

This is not a problem, but maybe should be taken into account: Because ->render_maybe changes stash. The M:P:DefaultHandlers:142 implicitly sets up handler to 'ep'. Thus second call to _fallbacks M:P:DefaultHelpers:123 will always try to use ..ep templates
this prevents to check format

format.t.txt

https://irclog.perlgeek.de/mojo/2018-05-23#i_16196900


Highlight focus on search hover

So if we were changing a reason within an argument:
Type to change it, search pops up, we see one we're interested in and hover over.
On hover, the reason we were editing lights up / colors somehow.

Old and stale issue


Merge changes from 'staging' to 'main' (Update Image Tags for github-repository-dispatcher-service2)

Summary
Description

Image Tag Update: "github-repository-dispatcher-service2"

Jira Ticket Links
PR Links
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code refactoring (restructing existing code without changing any functionality)
[ ] This change requires a documentation update

Testing Checklist
Changes tested on

[ ] staging (pre-prod)
[ ] MABL Tests Link (if any)
[ ] Successful Workflow Links (if any)

Error: The following fields are empty: Description, Jira Ticket Links, PR Links
Hint: Pull Request description is too short. Please add relevant information about the changes.


Add a README for the notebooks

where should the data used in the alboran sea notebook be stored (in a permanent way)?


bump jekyll to 4.3.1

The PR bumps the Jekyll version to 4.3.1.
Motivation for change
We currently run ruby 3.1.2 on our development machines to develop WaniKani.  Webbrick is no longer bundled with Ruby as of version 3, and to load Jekyll on our development machines we either:

need to use a ruby version manager (which is a bit of pain),
or we could containerise this application and stay on a ruby version < 3,
or the approach I took (upgrade Jekyll).

The change is the result of running bundle update jekyll.

Going with the jekyll upgrade option seems like the best path.
Only thing to add is that maybe it is worthwhile to submit a PR to the original project. Then we could just pull the changes upstream.
Looks like there are some recent commit changes there, so we'll probably want to pull upstream (probably in a separate PR).

Cool, I will look at taking this approach a little later on then.  The change is not high priority (and I will round back to it after kanavocab). I only made it so I could check my changes in #86 worked.
I have added a backlog task so this doesn't get forgotton: https://www.notion.so/tofugu/Finish-updating-Jekyll-for-the-knowledgebase-11cc0d8cf64b4d48902af8b8e2153b9a

Closing in favor of https://github.com/tofugu/wanikani-knowledge-guide/pull/105


Adding E2E Tests for SqlServer.Design

See #1669.
Also added FileService to abstract outputting files so can override for tests. And ensured resources have same name when built using VS as when built using command line.

Closing in favor of #2257 (which has a couple of the issues above addressed and is rebased on top of the latest code).


Fix for angularJS>=1.3 when ngLazyBind is absent

Close #40

@decipherinc are there any concerts with merging this?

Other than the tests failing... mostly it's just I'm spread pretty thin and don't have time to maintain everything

@boneskull I fixed the tests in https://github.com/decipherinc/angular-history/pull/43. It would be great if you find the time to merge and tag a new release. Thanks!


debug jack 1.9.22

relates to https://github.com/Homebrew/homebrew-core/pull/122566/

ended up removing the tests (relates to the example-tools)


koa dependency keyGrip stale since 2019

koa introduction docs lists keyGrip dependency for use in setting app.keys = ...
however keyGrip hasnt received updates since 2019
is anyone using this functionality, and if so, how are you working around this stale dependency?
to be fair: the keygrip package code is relatively small (yet impactful). its own dependencies are nodes crypto (which would depend on your env and not packaged with keygrip) and more importantly the tsscmp package.
the tsscmp hasnt been updated since apr 2020.

Lack of commits does not indicate usage. Keygrip is actively used/downloaded downloaded ~1m times from the npm registry every week. It's not stale, it's stable.

You know what else was downloaded over 2illion times a week? eslint-scoped

I am the current maintainer of keygrip. If you are having trouble with something, please open an issue and I can help to fix your issue. If you think there are enhancements that can be made to it, please open an issue with your idea/request or even open a pull request. As @miwnwski stated, the module is stable and doesn't need constant releases to fix bugs any longer, but if there is a bug you want to report to fix, please do.

@dougwilson thx - will take into account @miwnwski thoughts and do some research, and if necessary, reopen @keygrip repo

Hi @noahehall I was about to edit, but I'll just reply here: ultimately I am not here to tell Koa to use keygrip :) Koa is free to use whatever module they wish. But I just watch repos that depend on modules I maintain to help when I can -- I'm not sure you'll find a lot of other module maintainers that actually watch/interact with the repos that depend on their modules :)
As for the Keygrip repo, it is open and not archived or anything. Not having an update mainly means there is nothing to actually publish out. But if there is some specific bug, yes, please open an issue describing the bug and provide the specific steps to reproduce the issue. You're also welcome to open a pull request with a proposed fix if you already diagnosed it.

valid points from you @dougwilson as well as by @miwnwski
will gork a bit and see if i find anything

is anyone using this functionality

Keygrip is actively used/downloaded ~1 million times from the npm registry every week

You know what else was downloaded over 2million times a week? eslint-scope

I'm not sure what you're implying? I was answering your question?


pushup: init at 0.2

Description of changes
Pushup is a new web framework tool for making page-oriented web apps using the Go programming language.
Pushup compiles a novel syntax that combines Go and HTML down to pure Go code. The Pushup binary builds self-contained, standalone web app executables. It features file-based routing and support for modern HTML-over-the-wire projects like HTMX.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 276158 run on x86_64-linux 1

1 package built:

pushup

[nix-shell:~/.cache/nixpkgs-review/pr-276158-2/results/pushup/bin]$ ./pushup --version
Pushup 0.0.1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3140

You'll have to rebase on master so ofborg can find your maintainer object that we just added.
Also please squash the commits so we just have pushup: init at 0.2, we do this because nixpkgs tries to have a atomic git commit history.

@ofborg build pushup

just waiting for ci now.

@paulsmith please change the pname to the static value as torres suggested, but leave the comments there.
This was a slight oversight on my part and having it set to pname can have bad interactions with overrides and inherits.
@AndersonTorres next time you do a review please write at least some explanation on why you are suggesting some changes.

@Janik-Haag

having it set to pname can have bad interactions with overrides and inherits

what's an example of a bad interaction for my own education?

what's an example of a bad interaction for my own education?

An outdated example: the Python Imaging Library has pname = pil but repo = Imaging.

@AndersonTorres next time you do a review please write at least some explanation on why you are suggesting which change.

The comments convey no new information.

I agree w/ @AndersonTorres about these comments but isn't a showstopper for me

I looked at some other go packages before hand and most of them have comments about that so I would prefer to leave them in.

@rjpcasalino @Janik-Haag @AndersonTorres Thank you, appreciate you all reviewing this PR and helping me get my first Nix contribution merged!


Sort datasets in a collection by descending order of cell count

@brianraymor commented on Thu Mar 18 2021
@colinmegill suggested a mitigation for Curators want to order the datasets in a collection based on their relevance

We don’t have a way to call out that there is an ‘all'
Default sort by number of cells should accomplish this in every case

In the A Collection view, the datasets for the collection MUST be sorted in descending order of cell count (the dataset with the largest cell count is at the top of the list).

@brianraymor commented on Mon Apr 05 2021
Research from @tihuan on potential FE solutions:

Ooh I just did a quick search, looks like HTML5 has drag and drop API
And this article details how to do it with React!
So maybe we just need a quick POC to make sure it works with an HTML table too, then we’re good?

Estimated during April 27th refinement, the repo copy removed the planning poker record.