brew install mkcert failed

curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "mkcert"
Download failed: http://7xkcej.dl1.z0.glb.clouddn.com/bottles/mkcert-1.4.2.catalina.bottle.tar.gz
Warning: Bottle installation failed: building from source.
==> Downloading http://7xkcej.dl1.z0.glb.clouddn.com/bottles/go-1.15.3.catalina.
#=#=#
curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "go"
Download failed: http://7xkcej.dl1.z0.glb.clouddn.com/bottles/go-1.15.3.catalina.bottle.tar.gz
Warning: Bottle installation failed: building from source.
==> Cloning https://go.googlesource.com/tools.git
Cloning into '/Users/jasonli/Library/Caches/Homebrew/go--gotools--git'...
fatal: unable to access 'https://go.googlesource.com/tools.git/': Failed to connect to go.googlesource.com port 443: Operation timed out
Error: Failed to download resource "go--gotools"
Failure while executing; git clone --branch release-branch.go1.15 -c advice.detachedHead=false https://go.googlesource.com/tools.git /Users/jasonli/Library/Caches/Homebrew/go--gotools--git exited with 128. Here's the output:
Cloning into '/Users/jasonli/Library/Caches/Homebrew/go--gotools--git'...
fatal: unable to access 'https://go.googlesource.com/tools.git/': Failed to connect to go.googlesource.com port 443: Operation timed out

Google was broken for a bit it appears. Please try again @Brolly0204


Improve performance of JSONPointer encoding

Bug/issue #, if applicable:
Summary
This improves the performance of JSONPointer encoding which is a hot spot when building documentation for mixed Swift and Objective-C projects.
On an example mixed Swift and Objective-C project with 10k+ symbols, these changes improves the total documentation convert time by almost 1%:
┌──────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Metric                                   │ Change          │ main                 │ current              │
├──────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Duration for 'convert-total-time'        │ -0,9475 %¹      │ 14,88 sec            │ 14,739 sec           │
│ Duration for 'documentation-processing'  │ -1,533 %²       │ 6,859 sec            │ 6,754 sec            │
│ Duration for 'finalize-navigation-index' │ -1,141 %³       │ 0,293 sec            │ 0,29 sec             │
│ Peak memory footprint                    │ no change⁴,⁵    │ 743,2 MB             │ 745,9 MB             │
│ Data subdirectory size                   │ no change⁶      │ 248,6 MB             │ 248,6 MB             │
│ Index subdirectory size                  │ no change⁷      │ 5,3 MB               │ 5,3 MB               │
│ Total DocC archive size                  │ no change⁸      │ 288,5 MB             │ 288,6 MB             │
│ Topic Anchor Checksum                    │ no change       │ 081bb0f890c7fa3fba23 │ 081bb0f890c7fa3fba23 │
│ Topic Graph Checksum                     │ no change       │ 2683bd73f5612a553927 │ 2683bd73f5612a553927 │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────┘

 1: There's a statistically significant difference between the two benchmark measurements.
    The values are different enough that the most probable explanation is that they're random samples from two different data sets.
    t-statistic : +3,226          degrees of freedom : 28       95% confidence critical value : +2,042

 2: There's a statistically significant difference between the two benchmark measurements.
    The values are different enough that the most probable explanation is that they're random samples from two different data sets.
    t-statistic : +3,576          degrees of freedom : 28       95% confidence critical value : +2,042

 3: There's a statistically significant difference between the two benchmark measurements.
    The values are different enough that the most probable explanation is that they're random samples from two different data sets.
    t-statistic : +2,606          degrees of freedom : 28       95% confidence critical value : +2,042

 4: No statistically significant difference.
    The values are similar enough that the most probable explanation is that they're random samples from the same data set.
    t-statistic : -0,707          degrees of freedom : 28       95% confidence critical value : +2,042

 5: A human should check that the measurements for this metric look like random samples around a certain value to ensure the validity of this result.

 6: No statistically significant difference.
    The values are similar enough that the most probable explanation is that they're random samples from the same data set.
    t-statistic : -1,569          degrees of freedom : 28       95% confidence critical value : +2,042

 7: No statistically significant difference.
    The values are similar enough that the most probable explanation is that they're random samples from the same data set.
    t-statistic : -0,005          degrees of freedom : 28       95% confidence critical value : +2,042

 8: No statistically significant difference.
    The values are similar enough that the most probable explanation is that they're random samples from the same data set.
    t-statistic : -1,566          degrees of freedom : 28       95% confidence critical value : +2,042

Dependencies
None.
Testing
Nothing in particular. This isn't a user-facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

~[ ] Added tests~
[x] Ran the ./bin/test script and it succeeded
~[ ] Updated documentation if necessary~

@swift-ci please test

Also, should we entirely remove the EscapedCharacters enum? Leaving that in the code might lead to a maintenance issue: If we ever decide to escape other characters someday we might simply add them to the enumeration, not realizing the optimized code here doesn't use that any more. If we leave EscapedCharacters in the code, we should at least add a comment explaining that it's not used.

It's public API so we'd need to deprecate it and phase it out. There was never any public API to escape / unescape a JSONPointer so there wasn't really a reason for EscapedCharacters to be public API to begin with, other than as information about what characters need escaping and what their replacements are. I don't know how useful it is for a client of DocC to have access to that information I didn't feel like taking it away in this PR.


Use transactions in db operations when needed

Whenever multiple database operations are needed, a transaction should be used to ensure data consistency. Account creation is an example. Also, some database calls return errors but are ignored (e.g. s.db.InsertAccountToken).

Closing as this is more of a guideline than an issue


Can't connect sparrow wallet.

Unable to connect Sparrow Wallet to Bitcoin Core using Tails OS on thumbdrive iall running wireless on laptop. Data is pruned to 2 gb. Here is log of last connection attempt. Any help greatly appreciated. Out of idea's.
amnesia@amnesia:~$ Persistent/Sparrow/bin/Sparrow ~/Persistent/Sparrow/data
2023-11-26 23:44:13,640 ERROR Connection error
java.lang.IllegalStateException: I/O error during request processing
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.execute(Unknown Source)
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.invoke(Unknown Source)
at jdk.proxy2/jdk.proxy2.$Proxy15.getNetworkInfo(Unknown Source)
at com.sparrowwallet.sparrow@1.8.0/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindClient.initialize(Unknown Source)
at com.sparrowwallet.sparrow@1.8.0/com.sparrowwallet.sparrow.net.cormorant.Cormorant.start(Unknown Source)
at com.sparrowwallet.sparrow@1.8.0/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown Source)
at com.sparrowwallet.sparrow@1.8.0/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$6(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$7(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.net.ConnectException: Connection refused
at java.base/sun.nio.ch.Net.connect0(Native Method)
at java.base/sun.nio.ch.Net.connect(Unknown Source)
at java.base/sun.nio.ch.Net.connect(Unknown Source)
at java.base/sun.nio.ch.NioSocketImpl.connect(Unknown Source)
at java.base/java.net.Socket.connect(Unknown Source)
at java.base/java.net.Socket.connect(Unknown Source)
at java.base/sun.net.NetworkClient.doConnect(Unknown Source)
at java.base/sun.net.www.http.HttpClient.openServer(Unknown Source)
at java.base/sun.net.www.http.HttpClient.openServer(Unknown Source)
at java.base/sun.net.www.http.HttpClient.(Unknown Source)
at java.base/sun.net.www.http.HttpClient.New(Unknown Source)
at java.base/sun.net.www.http.HttpClient.New(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.connect(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream(Unknown Source)
at com.sparrowwallet.sparrow@1.8.0/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindTransport.pass(Unknown Source)
... 15 common frames omitted

Did you resolve this as per the chat?

No, still unsolved.

Tails is probably blocking the connection - all non-Tor connections are blocked by default. I don't believe this is a Sparrow bug, so closing this issue.
See https://web.archive.org/web/20230330153803/https://sovrnbitcoiner.com/sparrow-wallet-and-tails/

Bit confusing Craig, this article says it works with tails and I am on the Tor network so it shouldn't be blocked ? I still need to read further, maybe make sense yet

Hello Craig, I have a Tor connection so should not be blocked. So maybe it is a sparrow bug. You don't seem to want to pursue this in the least. Makes me wonder why you bothered replying. I am set up as the article suggests that you supplied. Makes no sense.

Are you connecting to Bitcoin Core over Tor? - i.e. via an onion address, or to an internet-accessible IP address?
See https://sparrowwallet.com/docs/faq.html#how-does-the-proxy-support-work - Sparrow does not use Tor to reach local IPs, as this would always fail.

You don't seem to want to pursue this in the least. Makes me wonder why you bothered replying.

You have mistaken Github for a support forum - it's not, it's a place for bugs and feature requests. Be aware I am drawing on many years of experience when I say I do not believe this is a bug.

Hello Craig,
Apologize for the rant. I was at the end of my rope with trying to get it to work and I was in the wrong place looking for support. Never seen this message till later and didn't know how to reach you outside of GitHub.
Rick
From: "craigraw" @.>
To: "sparrowwallet/sparrow" @.>
Cc: "Rick Rick" @.>, "Author" @.>
Sent: Monday, November 27, 2023 9:14:59 PM
Subject: Re: [sparrowwallet/sparrow] Can't connect sparrow wallet. (Issue #1180)
Are you connecting to Bitcoin Core over Tor? - i.e. via an onion address, or to an internet-accessible IP address?
See [ https://sparrowwallet.com/docs/faq.html#how-does-the-proxy-support-work | https://sparrowwallet.com/docs/faq.html#how-does-the-proxy-support-work ] - Sparrow does not use Tor to reach local IPs, as this would always fail.
You don't seem to want to pursue this in the least. Makes me wonder why you bothered replying.
You have mistaken Github for a support forum - it's not, it's a place for bugs and feature requests. Be aware I am drawing on many years of experience when I say I do not believe this is a bug.
—
Reply to this email directly, [ https://github.com/sparrowwallet/sparrow/issues/1180#issuecomment-1829120294 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/A65NSQGM4EMBSV676ZTYIITYGVXNHAVCNFSM6AAAAAA73G7Y6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGEZDAMRZGQ | unsubscribe ] .
You are receiving this because you authored the thread. Message ID: < @.*** >

No worries.
My suggestion is to use an Electrum server on a .onion address if you are using Tails. Exposing Bitcoin Core to an internet accessible address is not advisable for both privacy and performance reasons.


Eac integration touchups

This just cleans up the file structure a bit, and uses the semantic versions of BN where applicable to improve readability.

Pull Request Test Coverage Report for Build 297

1 of 7 (14.29%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 32.905%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/selectors/schedule/transaction.ts
0
1
0.0%

common/sagas/schedule/currentSchedulingToggle.ts
0
1
0.0%

common/sagas/schedule/currentTimeBounty.ts
0
1
0.0%

common/libs/scheduling/index.ts
1
4
25.0%

Totals

Change from base Build 296:
0.0%

Covered Lines:
2430

Relevant Lines:
6219

💛  - Coveralls


Add test for clear overdue command

Codecov Report

Merging #197 (65c8c04) into master (3587114) will increase coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
+ Coverage     44.03%   44.50%   +0.47%
- Complexity      505      511       +6
============================================
  Files           152      152
  Lines          2539     2539
  Branches        302      302
============================================
+ Hits           1118     1130      +12
+ Misses         1356     1344      -12
  Partials         65       65

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/seedu/address/model/ModelManager.java
53.84% <0.00%> (+1.92%)
26.00% <0.00%> (+1.00%)

src/main/java/seedu/address/model/AddressBook.java
63.29% <0.00%> (+2.53%)
24.00% <0.00%> (+1.00%)

src/main/java/seedu/address/model/entry/Entry.java
73.91% <0.00%> (+4.34%)
18.00% <0.00%> (+1.00%)

...u/address/model/entry/NonOverlappingEntryList.java
50.00% <0.00%> (+4.34%)
11.00% <0.00%> (+1.00%)

...dress/logic/commands/ClearOverdueEntryCommand.java
100.00% <0.00%> (+100.00%)
2.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3587114...65c8c04. Read the comment docs.


add Rotation::from_sin_cos constructor

Being able to construct Rotation from sin and cos allows for full-precision serialization and deserialization, without having to (eg) go via a single scalar radians value.

committed your suggested change, then force pushed after squashing into one commit


Bump to 1.7.1

Not sure why the bot didn't pick this one up yet (and whether I can get further with the build adaptations than in #35)...

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [117, 118, 165, 166].

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

OK, first builds passing again... Now just failing on a (flaky?) test...
FAILED tests/test_residual_quantizer.py::TestAdditiveQuantizerWithLUT::test_RCQ_knn

=================================== FAILURES ===================================
__________________ TestAdditiveQuantizerWithLUT.test_RCQ_knn ___________________

self = <test_residual_quantizer.TestAdditiveQuantizerWithLUT testMethod=test_RCQ_knn>

    def test_RCQ_knn(self):
        ds = datasets.SyntheticDataset(32, 1000, 0, 123)
        xt = ds.get_train()
        xq = ds.get_queries()

        # RQ 3+4+5 = 12 bits = 4096 centroids
        rcq = faiss.index_factory(ds.d, "RCQ1x3_1x4_1x5")
        rcq.train(xt)

        aq = rcq.rq

        cents = rcq.reconstruct_n(0, rcq.ntotal)

        sp = faiss.swig_ptr

        # test norms computation

        norms_ref = (cents ** 2).sum(1)
        norms = np.zeros(1 << aq.tot_bits, dtype="float32")
        aq.compute_centroid_norms(sp(norms))
E        x: array([ 7.76706, 15.41243,  2.32282, ..., 36.52338, 25.93759, 45.54408],
E             dtype=float32)
E        y: array([ 7.76706, 15.41243,  2.32282, ..., 36.52338, 25.93759, 45.54408],
E             dtype=float32)

@conda-forge/vc
It seems that the new compilers in the win-2019 image somehow regressed? The master branch built the same recipe fine essentially, but not this yields weird compilation errors (not related to the version bump, the same errors appear in #45).
I tried downgrading to vs 2017, which worked (mostly), see second-to-last CI run...

Though it could also be something with nvcc, because cuda10.2 seems to build fine on vs2019, whereas cuda11.x fails.
CC @conda-forge/nvcc


Segmentation fault on import

Issue
I am getting a segmentation fault when running the following import statement
from autogluon.tabular import TabularPrediction

and segmentation fault: 11 when running
from autogluon.text import TextPrediction

I am using a recent branch of autogluon, installed in a clean virtual environment: autogluon version 0.0.16b20210120
Environment
conda create -n autogluon-dev python=3.7
conda activate autogluon-dev
python3 -m pip install --upgrade "mxnet_cu100<2.0.0"
python3 -m pip install --pre autogluon

I have also tried installing by cloning autogluon from github, replacing the last line with
git clone https://github.com/awslabs/autogluon.git
cd autogluon
bash full_install.sh

Platform: Linux/UNIX
(ec2) Instance type: p2.8xlarge
AMI: Deep Learning AMI (Amazon Linux 2) Version 36.0
python3 --version: Python 3.7.9
nvcc --version: Cuda compilation tools, release 10.0, V10.0.130
pip freeze:
attrs==20.3.0
autocfg==0.0.6
autogluon==0.0.16b20210120
autogluon-contrib-nlp==0.0.1b20210112
autogluon.core==0.0.16b20210120
autogluon.extra==0.0.16b20210120
autogluon.mxnet==0.0.16b20210120
autogluon.tabular==0.0.16b20210120
autogluon.text==0.0.16b20210120
autogluon.vision==0.0.16b20210120
autograd==1.3
bcrypt==3.2.0
beautifulsoup4==4.9.3
blis==0.7.4
bokeh==2.2.0.dev4
boto3==1.16.57
botocore==1.19.57
Bottleneck==1.3.2
catalogue==1.0.0
catboost==0.24.4
certifi==2020.12.5
cffi==1.14.4
chardet==4.0.0
click==8.0.0a1
cloudpickle==1.6.0
ConfigSpace==0.4.16
contextvars==2.4
cryptography==3.3.1
cycler==0.10.0
cymem==2.0.5
Cython==3.0a6
d8==0.0.2
dask==2021.1.0
decorator==4.4.2
decord==0.4.2
dill==0.3.3
distributed==2021.1.0
fastai==1.0.61
fastprogress==1.0.0
flake8==3.8.4
future==0.18.2
gluoncv==0.10.0b20210120
graphviz==0.8.4
HeapDict==1.0.1
idna==2.10
immutables==0.14
importlib-metadata==3.4.0
iniconfig==1.1.1
Jinja2==3.0.0a1
jmespath==0.10.0
joblib==1.0.0
kaggle==1.5.10
kiwisolver==1.3.1
liac-arff==2.5.0
lightgbm==3.1.1
MarkupSafe==2.0.0a1
matplotlib==3.3.3
mccabe==0.6.1
msgpack==1.0.2
murmurhash==1.0.5
mxnet-cu100==1.7.0
networkx==2.5
numexpr==2.7.2
numpy==1.19.5
nvidia-ml-py3==7.352.0
opencv-python==<IP_ADDRESS>
openml==0.11.0
packaging==20.8
pandas==1.2.1
paramiko==2.7.2
Pillow==6.2.1
plac==1.1.3
plotly==4.14.3
pluggy==1.0.0.dev0
portalocker==2.0.0
preshed==3.0.5
protobuf==3.14.0
psutil==5.7.0
py==1.10.0
pyaml==20.4.0
pyarrow==1.0.0
pycodestyle==2.6.0
pycparser==2.20
pyflakes==2.2.0
PyNaCl==1.4.0
pyparsing==3.0.0b2
pytest==6.2.1
python-dateutil==2.8.1
python-slugify==4.0.1
pytz==2020.5
PyYAML==5.4
regex==2020.11.13
requests==2.25.1
retrying==1.3.3
s3transfer==0.3.4
sacrebleu==1.4.14
sacremoses==0.0.43
scikit-learn==0.23.2
scikit-optimize==0.8.1
scipy==1.4.1
sentencepiece==0.1.95
six==1.15.0
sortedcontainers==2.3.0
soupsieve==2.1
spacy==2.3.5
srsly==1.0.5
tblib==1.7.0
tensorboardX==2.1
text-unidecode==1.3
thinc==7.4.5
threadpoolctl==2.1.0
tokenizers==0.9.4
toml==0.10.2
toolz==0.11.1
torch==1.7.1
torchvision==0.8.2
tornado==6.1
tqdm==4.56.0
typing-extensions==<IP_ADDRESS>
urllib3==1.26.2
wasabi==0.8.0
xgboost==1.2.1
xmltodict==0.12.0
yacs==0.1.8
zict==2.0.0
zipp==3.4.0

I got the same error.
I solved it by changing python version from 3.7 to 3.6.
Hope this helps.

I got the same error.
I solved it by changing python version from 3.7 to 3.6.
Hope this helps.

Switching to Python 3.6 worked for me too.
conda create -n autogluon-dev python=3.6
conda activate autogluon-dev
python3 -m pip install --upgrade "mxnet_cu100<2.0.0"
python3 -m pip install --pre autogluon

Minor issue: the nightly build documentation shows AutoMLPipelineFeatureGenerator residing at autogluon.utils.tabular.features.generators.auto_ml_pipeline.AutoMLPipelineFeatureGenerator, but it appears to now be at autogluon.tabular.features.generators.auto_ml_pipeline.AutoMLPipelineFeatureGenerator.

Just a guess, but it might be related to the use of Amazon Linux, since all our tests are on Ubuntu, and therefore we haven't tested Amazon Linux. I'll plan to have someone look into this prior to our next release. If anyone is able to figure out the cause or has additional info, please feel free to share it here.

Just a guess, but it might be related to the use of Amazon Linux, since all our tests are on Ubuntu, and therefore we haven't tested Amazon Linux. I'll plan to have someone look into this prior to our next release. If anyone is able to figure out the cause or has additional info, please feel free to share it here.

My environment was:
Ubuntu 18.04 LTS
NVIDIA GTX 1080
CUDA toolkit 10.2
python 3.7.5

I got this error.

My environment was:
Ubuntu 18.04 LTS
NVIDIA GTX 1080
CUDA toolkit 10.2
python 3.7.5

I got this error.

I also encountered Segmentation fault: 11 once when running .fit() with AG Text on a p3dn.24xlarge with Ubuntu. Rebooting the instance solved the problem for me - might be an issue with the instance itself.

I also encountered Segmentation fault: 11 once when running .fit() with AG Text on a p3dn.24xlarge with Ubuntu. Rebooting the instance solved the problem for me - might be an issue with the instance itself.

I expect some of the issue is related to ConfigSpace, which we have recently stabilized in pre-release. I am marking this resolved for now, but please re-open if issues persist in latest pre-release and v0.1+


Kyverno inclusion into Kubernetes-Marketplace

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!
If your pull request is to submit a new application to the marketplace, please answer the following questions:

[x] Have you followed the guidelines in our Contributing document in setting up the application?
[x] Have you checked that the application your submission is proposing to add does not yet exist on the Marketplace, or as a pull request to be processed?
[ ] Have you tested your application on the Civo managed Kubernetes service? Please include a screenshot.
[ ] Can you confirm that the software you are submitting licensed for use in a publicly-available Kubernetes marketplace?

If your pull request concerns an existing Marketplace application, please make sure you have:

[ ] Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
[ ] Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
[ ] Tested that the application works with the proposed updates applied (including a screenshot)

Please feel free to contact me with any issues

submitting following logo resize

submitting after reducing logo size

LGTM


[BUG] Compatible with Laravel Telescope in Composer require-dev

Describe the bug
php artisan scout:import crashes when Laravel Telescope is configured as "dev" requirement, to only load in "local" environment.
To Reproduce
Steps to reproduce the behavior:

Require Laravel Telescope as dev req.: composer require laravel/telescope --dev
Install Telescope as described here https://laravel.com/docs/telescope#installation, for dev!

php artisan telescope:install and php artisan migrate.
After running telescope:install, you should remove the TelescopeServiceProvider service provider registration from your app configuration file. Instead, manually register the service provider in the register method of your AppServiceProvider.

Try php artisan scout:import (without extra argument). This throws exception: "Class 'Laravel\Telescope\TelescopeApplicationServiceProvider' not found"

Expected behavior
Running scout:import should only try to load classes with require_once $file; that are Eloquent model and Searchable only. If possible.
Additional context
I think the problem is located here:
https://github.com/matchish/laravel-scout-elasticsearch/blob/06c90914668942b23ffaff7d58af5b9db1901fb1/src/Searchable/SearchableListFactory.php#L69
There ALL php files in the app directory are loaded, even when it is not used at runtime.
In my setup the class \App\Providers\TelescopeServiceProvider should only be loaded in dev, but is now loaded anyway by \Matchish\ScoutElasticSearch\Searchable\SearchableListFactory::getProjectClasses.
The intention of my setup is made clear in \App\Providers\AppServiceProvider::register:
        if ($this->app->isLocal()) {
            $this->app->register(TelescopeServiceProvider::class);
        }

Version
Versions of Laravel, Scout, and the package.
Laravel 5.8
Scout: 7.2.1
Package: 3.0.3

The same issue https://github.com/algolia/scout-extended/issues/213

@ametad I sugest to open stackoverflow question. Maybe we can find a solution there. Post the link here to the question if you will do it pls.

Stackoverflow is an idea indeed 👍

I have another idea, a whole different approach:
What about a config setting that defines what searchable classes there are in your system? I think this solves it all and is the most robust implementation. Also very sufficient regarding resources and very controllable.
IMO the only reason for the short command (artisan scout:import) to be there in the first place is: convenience. You don't have to explicitly write all the class names you want to import. With the config in place, convenience is still very high! You only have to keep up the config with your searchable classes. I prefer this explicit way of coding anyway, because implicit ways are in the long run more difficult to maintain and understood imo.

We are not alone :wink:
https://github.com/algolia/scout-extended/issues/213

We are not alone :wink:
https://github.com/algolia/scout-extended/issues/213

What about a config setting that defines what searchable classes there are in your system? I think this solves it all and is the most robust implementation. Also very sufficient regarding resources and very controllable.

What do think about this @matchish ? Perhaps with fall back to the old approach?

What about a config setting that defines what searchable classes there are in your system? I think this solves it all and is the most robust implementation. Also very sufficient regarding resources and very controllable.

What do think about this @matchish ? Perhaps with fall back to the old approach?

We have searchable argument in import console command. So we can specify what classes to import.
https://github.com/matchish/laravel-scout-elasticsearch/blob/master/src/Console/Commands/ImportCommand.php#L20
You can create a config in your application and use it with import command. You can create a new command and call import command from code with searchable argument loaded from the config

We have searchable argument in import console command. So we can specify what classes to import.
https://github.com/matchish/laravel-scout-elasticsearch/blob/master/src/Console/Commands/ImportCommand.php#L20
You can create a config in your application and use it with import command. You can create a new command and call import command from code with searchable argument loaded from the config

Yes of course... So your solution would be "do it yourself". No offense, you are entitled to say so. And I know that is a good solution to be usable and flexible for the majority.
My question is: what is your philosophy about finding all the searchable models?
In my opinion it can work in ALL scenarios when this is configurable. The other option is that there is a solution implemented for every new scenario where it was not working. This could be something that goes on and on.
BTW I do think I can come up with a solution to find searchable models when this is declared in a higher order trait.

Yes of course... So your solution would be "do it yourself". No offense, you are entitled to say so. And I know that is a good solution to be usable and flexible for the majority.
My question is: what is your philosophy about finding all the searchable models?
In my opinion it can work in ALL scenarios when this is configurable. The other option is that there is a solution implemented for every new scenario where it was not working. This could be something that goes on and on.
BTW I do think I can come up with a solution to find searchable models when this is declared in a higher order trait.

For me config for searchable classes is workaround
I think we need only two options
Specify searchable models manually
Find all models with searchable trait
Until we don't have bulletproof search we can live with a solution that fit most cases.

For me config for searchable classes is workaround
I think we need only two options
Specify searchable models manually
Find all models with searchable trait
Until we don't have bulletproof search we can live with a solution that fit most cases.

Why this fix is not merged in latest version?

As I remember we had some dependencies incompatibility in php8. So I rolled back this fix until it will be fixed.

DO you think it should work now?


Fatal Error with plugin -

Hi!
Would love for this too work, please see below.
can't select an option in the dropdown either see image
WordPress version 5.8
Current plugin: Modern Images WP (version 1.0.1)
PHP version 7.4.21

Error
An error of type E_ERROR was caused in line 195 of the file /var/www/vhosts/web.co.uk/web.co.uk/wp-content/plugins/modern-images-wp-main/src/Setting.php. Error message: Uncaught Error: Call to undefined function Modern_Images_WP\str_to_upper() in /var/www/vhosts/web.co.uk/web.co.uk/wp-content/plugins/modern-images-wp-main/src/Setting.php:195 Stack trace: #0 /var/www/vhosts/web.co.uk/web.co.uk/wp-content/plugins/modern-images-wp-main/src/Setting.php(117): Modern_Images_WP\Setting->isImageFormatSupported() #1 /var/www/vhosts/web.co.uk/web.co.uk/wp-admin/includes/template.php(1743): Modern_Images_WP\Setting->Modern_Images_WP\{closure}() #2 /var/www/vhosts/web.co.uk/web.co.uk/wp-admin/includes/template.php(1701): do_settings_fields() #3 /var/www/vhosts/web.co.uk/web.co.uk/wp-admin/options-media.php(156): do_settings_sections() #4 {main}  thrown

Thanks for reporting @AcmeLDN - Fixed in #17


SAK-30607 Removed plus sign from Add New Site and renamed the menu option

I have removed the redundant plus sign ("+") from beside the "Add New Site" option in the Account menu. I have made this change to all of the sitenav.properties language files that contained the plus sign beside this option (sit_newsite).
I have also changed the wording (in English translations) from "Add New Site" to "Create New Site" to match the wording in Worksite Setup and to avoid any linguistic confusion (such as with "adding a favourite site", or with "being added to"/"becoming a member of" a site).
Please see my before and after screenshots of the change in English.
Before:

After:

I'm neutral with this change but I don't understand why did you change all translation files to remove the "+", I think translators should maintain their own files. For example, in spanish this change will be overwritten with the translation of the sentence "Create New Site" that the translation manager will make in transifex. I don't know if there are other unmaintained translations, but I think it has no sense for the updated translations (they have to translate "create" also, not only remove "+").

I removed the plus sign from the translation files because I figured it was separate from the task of translating the language.

I have reverted all of my changes to non-English translations for this patch. Please review.

Thank you Shawn, LGTM.


BeforeConvertCallback<> not called when persisting nested entity

Due to different database engines I chose to generate UUID within application and not database so I used this callback method.
So consider entities:
public class Order implements Persistable {

    @Id
    private UUID orderId;
    private OrderType orderType;
    @MappedCollection(idColumn = "order_id")
    private Set<Product> products;
...
}

public class Product implements Persistable {
    @Id
    private UUID productId;
    private String productType;
    private String productName;
    private UUID orderId;
...
}

and callback:
@Component
class EntityCallback implements BeforeConvertCallback<Persistable> {

    @Override
    public Persistable onBeforeConvert(Persistable aggregate) {
        if (aggregate.getEntityId() == null) {
            aggregate.setEntityId(UUID.randomUUID());
        }
        return aggregate;
    }
}

when I execute orderRepository.save(order)
I get following exception
SQLException with SQL state '23502', error code '23502', message [NULL not allowed for column "PRODUCT_ID";
meaning that productId was not generated during callback function (checked via debug)
Is this intended to work like this?

Yes, this is intended. Events and callbacks are only triggered for aggregates.
Unfortunately this is not properly documented.
We'll fix that.


feat(reactivity): unlink triggered effects to dereference effects when possible

This mitigates the memory leak problem with computeds, as well as improving performance in a one-to-many computeds scenario.
Closes https://github.com/vuejs/vue-next/issues/2261

It may be worthwhile to add a test which checks that removed computeds aren't in the depsMap anymore after triggering, since it is easy to accidentally create a regression which breaks this fix.

See https://github.com/vuejs/vue-next/issues/2261#issuecomment-705170322
Although this does de-reference computed effects in some, it doesn't guarantee de-referencing (as it requires the dependency to trigger the effect, and only clears it from the map of that specific dependency) in all cases. It is still required to properly stop the effect to fully prevent leaks.


[dvsim] List CPU runtimes and longest ones in the report

Current regression user has to go to each individual file to find the CPU time.
Proposing supporting the following feature:
Support searching and abstracting all CPU runtimes, and list the longest ones in the report.
Proposed steps are:
1). Parse the job log file
2). Read out tool-generated statistics representing CPU time (wall clock) and the simulated time (ns)
3). Maintain this on per job basis
4). Each DUT (sim cfg) reads out this info from each test run and creates a HJSON / XML for future purposes
5). Report needs to list 10 slowest tests
6). Add 2 columns to the regression table in the report to represent those two times

https://github.com/lowRISC/opentitan/issues/13685 duplicate issue :)

#13756 duplicate issue :)

Whoops, sorry!


Auth callback metaerror: error.toJSON is not a function

Describe the bug
Testing auth before updating my publication for autodiscovery, went through auth flow and callback triggered this:
TypeError: error.toJSON is not a function
at file:///app/node_modules/@indiekit/indiekit/lib/indieauth.js:174:24
at processTicksAndRejections (node:internal/process/task_queues:96:5)

To reproduce
Deploy gerwitz/hgc-indiekit to Railway.app
Use IndieAuth to authenticate
Environment

Indiekit version: v1.0.0-alpha.11r
Browser: Safari
Server/host: Railway
Content store URL: https://github.com/gerwitz/hgc-indiekit
Publication URL: https://hans.gerwitz.com/

After reading #432 I added a TOKEN_SECRET envvar simply guessing that was the root error.
On my next deployment, I instead got a properly rendered but not helpful "Invalid value for state" error, and ended up in an odd session state (maybe via query strings) that rendered a menu, but attempted to redirect to an empty URL if I clicked the sign in button.
So I started at my own root again, and now I am reproducing the above.
I don't understand space or time.

Glad you got it working, and thanks for filing these errors. It’s really valuable getting first run impressions, as I’m so far beyond that stage I no longer have that perspective. 👍


finding packages by package path

We should allow the "filtering" or "scoping" be flexible to handle package relative paths or absolute paths. Perhaps reference pnpm's --filter syntax?

Hi @kenotron, I would like to pick this up if you don't mind.

@kenotron is anyone working on this? If not, I can pick it up.


Fix Build: Remove incorrect include of deleted picture_rasterizer.h

LGTM

feel free to check in build bustage fixes with TBR

Will do


Upgrade popper

Migration guide: https://popper.js.org/docs/v2/migration-guide/
ref https://github.com/popperjs/react-popper/pull/333

@prayerslayer Any chance you can take a look at this?

Hi!
Any chance this gets merged soon?

I need some help testing the changes. Since this is a major upgrade we need to be careful not breaking any existing functionality.

@martijnrusschen anything I can help with? Just forked the repo to bump react-popper and realized, that this PR already exists. So, how can I serve you?

@martijnrusschen anything I can help with? Just forked the repo to bump react-popper and realized, that this PR already exists. So, how can I serve you?

@martijnrusschen anything I can help with? Just forked the repo to bump react-popper and realized, that this PR already exists. So, how can I serve you?

I did a first pass on this, but it seems it's not working yet. Feel free to add to this, or create your own PR if you can get this working. Would be great to have this upgraded to the latest version.

@martijnrusschen anything I can help with? Just forked the repo to bump react-popper and realized, that this PR already exists. So, how can I serve you?

I did a first pass on this, but it seems it's not working yet. Feel free to add to this, or create your own PR if you can get this working. Would be great to have this upgraded to the latest version.

Completed in https://github.com/Hacker0x01/react-datepicker/pull/2626

Completed in https://github.com/Hacker0x01/react-datepicker/pull/2626


Option to limit the height of the floating window

In a C if () ... else if () ... else if () ... else if () ... else ... block with many branches, the floating window becomes very large, occupying over a half of the screen. An option to limit the height of the floating window can be helpful in this case.

Hey, what do you think about #67?

I also want this but maybe for a bit of a different reason.
I want to use this plugin only to show which function I am inside. Having it show me if I'm in an "if" or a "switch" case is not very helpful to me. Would your pull @jakelinnzy accomplish this by setting the length to 1?

Now things are getting a bit complicated, as it is not clear what to truncate.

I also want this but maybe for a bit of a different reason.
I want to use this plugin only to show which function I am inside. Having it show me if I'm in an "if" or a "switch" case is not very helpful to me. Would your pull @jakelinnzy accomplish this by setting the length to 1?

I think it wouldn't.


Add more detailed de error responses

Add domain and device_class option to german error responses, like it is done in french

there is already a pending PR for that -> #2579

close this, since we're working on #2579


Update your README.md

Look for the number 5 instruction... it says that we need to make changes inside here and then click on the create pull request button...so here I am... regards...

oh i see.. okay... I'll check it out.. after looking over instruction #5, it seems there's been a new change to the wording from last night... anyways, I don't see any comments from you about my purpose section of the writing, the section about "What to Use TrumpScript for and When to Use It"  - does that mean I did a greater than great job?  ;)  If it is then that's great.  But I don't think I can merge your pull request because it contains your portion of the assignment - our subsequent pull request to the owner's would show my request containing your "For the non-technical, for America section of the readme.  Regards

What do you mean not comments?? So how we doing??

you need to give me some feedback on my Part (b) assignment;  Any suggestion must be done in your local machine so when you create a pull request I can accept it or ignore it... if I accept it I can then merge it as a final "polished" product;  then and only then I can create a pull request to the owner of the TrumpScript repository so they can look over it and decide if they would also accept or ignore it.  Get it??? Let me know... Last night I provided you with the steps to do that Regards

Ok I did what you said and when I try to git push origin returns me with this error:
Permission to bruceLeeO/TrumpScript.git denied to luisRojas29. fatal: unable to access 'https://github.com/bruceLeeO/TrumpScript.git/': The requested URL returned error: 403 So, do you have to make permission to me??

hmm, there shouldn't be any permission needed because when you clone bruceLeeO repository into you local machine that's your own copy of that repository.  you can make any changes and commit and then pull request so I can check the contribution changes you had made on that repository

So it's not pushing, only make a pull request... let me try that...

Mmm... still nothing, could you please merge this actually pull request, so we can see what it does??

sure thing

I can see my part (a) in your fork repo inside the branch purpose-readme-contribution in fact this branch has everything part (a) and (b), and the non-developer-readme-contribution only has my part (a)

Do you think this is it?? If so, will you please go to my fork project page, inside the non-developer-readme-contribution README.md post your changes and then make a pull request??

sorry for the constant delay Luis... juggling between making dinner for my kids and getting them ready for bed.... having both part (a) and part (b) is fine i guess... but only one of us  can make the pull request because the owners might get confused why two different pull request is created for the same changes.  I think the assignment is calling for both collaborators to experience being a contributor and the owner.  And the final stage of the assignment is for each collaborator to create pull requeston their part of the assignment.   let me know what you want to do... regards

Don't worry... I have no rush... Ok, so because your fork has the two parts of the assignment, I suggest you make the pull request to the owner, the part that you make change on my fork repo is for having a backup in case the Modern Developer people ask for my assignment... If you think we're ready to go... lets improve TrumpScript...jejeje... regards

alrighty... I'm working on it right now... i'll let you know... regards

you know what... I think it was already done 23 hours ago... here the link of the pull request https://github.com/samshadwell/TrumpScript/pull/110

Jajaja nice... hope that the chat in Q&A will be soon... so we can communicate a little more fluid... but this was great... thank you, hope we can work together in another project. Best regards... see you on MD...

lol too... same here Luis... Richard responded to one of my comment saying that chat should be up this week  best regard as well


add dependabot

Hello!
Thanks for your app.
I made some minor edits.
I hope they are useful.
Thanks.

Not reaction


Research alternate databases

Related to #6
Can we go for a local free database instead of a service? This is a crucial decision.

We have decided on turso.


Fixed persistent.hpp documentation

Small error - object fs does not exist in this code example

:+1:


Jenkins plugin

This is just a rebase of https://github.com/spotify/backstage/pull/1802, all credit goes to the actual developers of that feature!

Happy to iterate on it later, otherwise later today / tomorrow I should be able to review comments and adjust.

i had push rights to the original branch - hopping back to that one instead


Not working with 2022.3.3

Version of the custom_component
Latest
Configuration
Using configuration UI
Describe the bug
Govee integration was not working and showing an error in the integrations page. Removed integration, but now it won't even add.
Debug log
Error setting up entry govee for govee
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 335, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/govee/__init__.py", line 67, in async_setup_entry
    await hub.rate_limit_delay()
AttributeError: 'Govee' object has no attribute 'rate_limit_delay'

Whoops, my AdBlocker started blocking developer-api.govee.com, disregard.


I am not a bot :)
I am evaluating the jmespath-java library. I saw that this project uses the antlr-maven-plugin.
This PR is merely a maintenance bump of the Antlr library.
Antlr 4.9.3 was released in November 2021.
Antlr 4.13.2 was released in August 2024.
https://mvnrepository.com/artifact/org.antlr/antlr4


See if cv::ximgproc::contourSampling  can replace equidistance interpolation

https://github.com/opencv/opencv_contrib/blob/4.x/modules/ximgproc/src/fourier_descriptors.cpp

Not directly applicable (contourSampling works only for closed contours) but might as well implement its algorithm.

Can just use scipy...


[FEATURE] - Game On Section Content Design Enhancement

Description
Changing the font styling of each game's font which includes description and rules of each game. The current font styling is simple giving simple look. We can improve it by selecting more gamic font style.
Screenshots
Current Design

Expected Updated Design

Additional information
No

Hi @panwar8279
Kindly enlarge updated design images to clearly see the difference.

Hi @iamRabia-N , I have assigned this task to you. Kindly complete within 2 days. Good luck 1


Uncommented line 29 and line 41

Fixes Jira Story or GH Issue if applicable
Description of changes in release / Impact of release:
(insert text here)
Documentation
(insert text here)
Risks of this release
Is this a breaking change?

[ ] Yes
[ ] No

If you answered Yes then describe why is it so
(insert text here if applicable)
Is there a way to disable the change?

[ ] Use previous release
[ ] Use a feature flag
[ ] No

Additional details go here
(insert text here if applicable)

Fixed by #309


Authenticate client connections with mysql_native_password

This only allows one password hash
This does NOT verify the username
This won't work for clients that ignore the default authentication method send by the server and are not using mysql_native_password by default. See also: https://github.com/vitessio/vitess/issues/4332 and https://bugs.mysql.com/bug.php?id=93044 . This affects MySQL 8.0 clients as 8.0 always tries to authenticate with caching_sha2_password. The solution is to implement caching_sha2_password over TLS and/or implement AuthSwitchRequest.

Issue: #6
Example use:
$ ./my sql -BNe "SELECT PASSWORD('foobar')"
*9B500343BC52E2911172EB52AE5CF4847604C6E5
$ rippled -ripple_server_password_hash=9B500343BC52E2911172EB52AE5CF4847604C6E5

@dveeden I see there were a couple force pushes here (that I wasn't notified about), but no comments from you. Are you still working on this PR or is it ready for the next round of review?

Hi @pivanof
I assumed that github would notify you about resolved issues. I'll put a note in the PR next time this happens.
This PR is ready for another round of review.
Note that #9 has the commit from this PR and another commit on top of that to add compatibility with MySQL 8.0, that PR is also ready for review.
So let's first do this PR and then #9

I've pushed a new version.


Like New Overuse

The day-7 experience has shown that LN use is off a bit. Currently, the script just presumes some chance of use which increases during the day, which seems fine at first glance, but it means presuming quite a bit. Perhaps something a bit more dynamic which uses LNs in proportion to WHs would be in order.

#276 Attempt at this issue


docs(readme): add Greenkeeper badge

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix var function inside color functions

I tried to fix #196. Not sure if it is good solution, but at least it works ;)

This should also fix #186.

@sabberworm Anything else you'd like to see from this? We'd like to include it in the v2.0 release of the AMP plugin for WordPress.

@westonruter No, I just haven’t had time to do a proper review yet. I only wonder if it would be possible to solve this case generically as opposed to special-casing the color parsing. Next we’ll have someone wanting to use variables in url() and we’ll have to add a special case there.


📌 Temp Components & Roadmap

I'm sure most of you have realized that we're lacking some of the "cooler" components from the original project, which also happen to be some of the more difficult components to build (the right way). This is because there isn't a battle-tested, actively maintained, and feature-complete headless UI library for Svelte at the moment (at least from my extensive searches).
The ideal state of this project would be to use the same headless UI library for >90% of the components. This keeps the component APIs  familiar and enables us to easily track breaking changes, updates, and issues.
However, I don't want to hold this project back while our primary headless UI library is being developed and refined. Not only does that apply additional unnecessary pressure to the maintainers of that project, but also keeps us from building complete projects while that development is underway.
So what we've decided to do is work on some "temp" components, which will eventually be replaced by the single headless library's implementation once it's ready. The goal is to do our best to make the APIs as similar as possible to their final state, so that migrating to the newer ones is as simple as changing a few imports/replacing a dependency, but of course no 100% guarantee on that. Since you own the code/components, you can ride out the temps for as long as you'd like, and upgrade to the final version when it works for you.
If you're thinking, why "temp" and not "beta" or "experimental"? Well I couldn't make a decision on what to label these, so I asked ChatGPT and here's what it came up with:

"Experimental" suggests that the component is in the early stages of development and may undergo significant changes or may even be removed altogether. It indicates that the feature is not yet stable or fully tested and is primarily meant for evaluation purposes.

While this somewhat aligns with what we're going for, experimental would be a better label if we were to release a partially-working, untested component, which is not what we'll be doing.

"Beta" is typically considered to be in a more advanced stage of development compared to experimental versions. It implies that the feature is mostly functional but may still have some known issues or require further refinement based on user feedback. Beta versions are often released to a wider audience for testing and gathering user input.

Also partially true, but since the entire API may change and we aren't continously iterating over these components, it doesn't really fit.

"Temp" is an abbreviation for "temporary" and is commonly used to indicate that a component or feature is intended for short-term use. It implies that the element is not final and may be replaced or removed in the future. This term is often used when a placeholder or temporary solution is implemented pending the development of a more robust feature.

Right on the money.
Temp Component Roadmap
The issues below are to be used for discussion around these temporary components. If you know of a solid headless component that would fit in one of these places, first check the issue to ensure it isn't already being developed, and then provide your feedback via a comment.
I've also created a project which makes it a bit easier to visualize the status of each of these components, you can check that out via the "Projects" tab, or this link here.
Don't forget that the goal of this project is to align with shadcn/ui as closely as possible, so ensure to consider/compare before making any suggestions.

[ ] #96
[ ] #97
[ ] #99
[ ] #98
[ ] #100
[ ] #101
[ ] #102
[ ] #103
[ ] #104
[ ] #105
[ ] #106

@phenomen - We'll eventually migrate all the Radix Svelte components to MeltUI components. It should be seamless!

Closed by #150 - will begin new issues for remaining missing components, all of which are being actively worked on by us at Melt UI!


SqlException: 'String or binary data would be truncated in table' while SaveToken() for OAuth2

System
Umbraco version: 10.2.1
Umbraco.AuthorizedServices version: 0.3.2

Issue
I added a new authorized service in appsettings.json named Survey aim to call external API with OAuth2 authorization code.
When I run the project and navigate to backoffice Settings > Authorized Services > Survey then click Authorize Service button, I got the exception.
SqlException: String or binary data would be truncated in table 'umbraco-cms.dbo.umbracoAuthorizedServiceOAuth2Token', column 'accessToken'. Truncated value: 'CfDJ8ACj27kvevhCo6u3x6aXer_xxxxxxxxx'. The statement has been terminated.

I looked to the call stack seem like the app try to save a token in the database table umbracoAuthorizedServiceOAuth2Token with column accessToken after received the token.
I'm not sure this is a bug or I just did something wrong.
Any idea ?

Additional info
appsettings.json, [remove my actual value]
    "AuthorizedServices": {
      "TokenEncryptionKey": "",
      "Services": {
        "survey": {
          "DisplayName": "Survey",
          "AuthenticationMethod": "OAuth2AuthorizationCode",
          "IdentityHost": "https://login.microsoftonline.com",
          "TokenHost": "https://login.microsoftonline.com",
          "RequestIdentityPath": "/[my tenant]/oauth2/v2.0/authorize",
          "RequestTokenPath": "/[my tenant]/oauth2/v2.0/token",
          "RequestTokenFormat": "FormUrlEncoded",
          "JsonSerializer": "SystemTextJson",
          "AuthorizationUrlRequiresRedirectUrl": true,
          "SampleRequest": "/identity/me"
          "ApiHost": "https://[my api url]/api",
          "ClientId": "[my client]",
          "ClientSecret": "[my secret]",
          "Scopes": "api://[my scope uri]/user_impersonation"
        },

Call stack
Microsoft.Data.SqlClient.SqlException (0x80131904): String or binary data would be truncated in table 'umbraco-cms.dbo.umbracoAuthorizedServiceOAuth2Token', column 'accessToken'. Truncated value: 'CfDJ8ACj27kvevhCo6u3x6aXer_xxxxxxxxx'.
The statement has been terminated.
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean isAsync, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Umbraco.Cms.Infrastructure.Persistence.FaultHandling.RetryPolicy.ExecuteAction[TResult](Func`1 func)
   at NPoco.Database.ExecuteNonQueryHelper(DbCommand cmd)
   at NPoco.Database.InsertAsyncImp[T](PocoData pocoData, String tableName, String primaryKeyName, Boolean autoIncrement, T poco, Boolean sync)
   at NPoco.Database.Insert[T](String tableName, String primaryKeyName, Boolean autoIncrement, T poco)
   at NPoco.Database.Insert[T](T poco)
   at Umbraco.AuthorizedServices.Services.Implement.DatabaseOAuth2TokenStorage.SaveToken(String serviceAlias, OAuth2Token token)
   at Umbraco.AuthorizedServices.Services.Implement.AuthorizedServiceBase.StoreOAuth2Token(String serviceAlias, OAuth2Token token)
   at Umbraco.AuthorizedServices.Services.Implement.AuthorizedServiceAuthorizer.SendRequest(ServiceDetail serviceDetail, Dictionary`2 parameters, Boolean isExchangeTokenRequest)
   at Umbraco.AuthorizedServices.Services.Implement.AuthorizedServiceAuthorizer.AuthorizeOAuth2AuthorizationCodeServiceAsync(String serviceAlias, String authorizationCode, String redirectUri, String codeVerifier)
   at Umbraco.AuthorizedServices.Controllers.AuthorizedServiceResponseController.HandleOAuth2IdentityResponse(String code, String state)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Logged|12_1(ControllerActionInvoker invoker)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
   at Umbraco.Cms.Web.Common.Middleware.BasicAuthenticationMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<<UseMiddlewareInterface>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Umbraco.Cms.Web.BackOffice.Middleware.BackOfficeExternalLoginProviderErrorMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<<UseMiddlewareInterface>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authorization.Policy.AuthorizationMiddlewareResultHandler.HandleAsync(RequestDelegate next, HttpContext context, AuthorizationPolicy policy, PolicyAuthorizationResult authorizeResult)
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext httpContext, Boolean retry)
   at StackExchange.Profiling.MiniProfilerMiddleware.Invoke(HttpContext context) in C:\projects\dotnet\src\MiniProfiler.AspNetCore\MiniProfilerMiddleware.cs:line 119
   at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<<UseMiddlewareInterface>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Umbraco.Cms.Web.Common.Middleware.PreviewAuthenticationMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<<UseMiddlewareInterface>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestLoggingMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<<UseMiddlewareInterface>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)
ClientConnectionId:394be641-72e1-4fab-83d7-ff6ffe5ed3db
Error Number:2628,State:1,Class:16

It sounds like the access token the service you are using is generating is too long for what we have allocated in table storage.  Access tokens have been assumed to be less than 1000 characters.  Are you able to confirm that the token you receive is longer than that?  And if so, can you let us know how long so we can appropriately increase the database column size?  Thanks.

It sounds like the access token the service you are using is generating is too long for what we have allocated in table storage. Access tokens have been assumed to be less than 1000 characters. Are you able to confirm that the token you receive is longer than that? And if so, can you let us know how long so we can appropriately increase the database column size? Thanks.

@AndyButland You are right. In my case, the Access token contains 1867 characters in total.

OK, I've created a PR to extend the column size.  Once that's reviewed we'll create a new release of the package to address this issue.
Meantime if you want to move forward now there's no harm in you already increasing the field size in your own database to 2000 characters via:
ALTER TABLE umbracoAuthorizedServiceOAuth2Token
ALTER COLUMN accessToken nvarchar(2000) NOT NULL

ALTER TABLE umbracoAuthorizedServiceOAuth2Token
ALTER COLUMN refreshToken nvarchar(2000) NOT NULL
GO

@AndyButland Thank you for your suggestion, I tried to increase accessToken size to 2000 characters as your suggest but still failed. I tried again to increase it to 3000 characters and now it is successfully save the token and call to  sample request via back office :). I checked the token length in the database, seem like the actual token length is 2608 charactors.
Is it possible to extend the column size to 3000 characters ?

OK... I guess we'll go with 5000 just to give some more headroom.  Thanks for the update.

You'll find this in release 0.3.3 which I've just deployed to NuGet.  If you have manually set the database field to anything under 5000 that'll be fine, as when the migration runs it'll update it to that.


/nick

The /nick command throws an error.
the message displayed to the user is
'An internal error occurred whilst attempting to execute this command'

I believe the issue is a compilation error.
Maven shade plugin is not properly shading the jar.

v1.6 addresses this issue


cloud-init user-data script is not working on centos 7

Hello everyone,
In cloud-init I took one of the centos VM, while I am creating the VM there is an option called "custom data" in that given one of the sample scripts for testing, I attach the script.
just follow this link "
([(https://docs.microsoft.com/en-us/azure/virtual-machines/linux/tutorial-automate-vm-deployment)])
OS:
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"
CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
kernel : Kernel: Linux 3.10.0-1160.6.1.el7.x86_64
[root@centos-7-cloud-init cloud.cfg.d]# cloud-init --version
/bin/cloud-init 19.4
script:
#cloud-config
package_upgrade: true
packages:

nginx
nodejs
npm
write_files:
owner: www-data:www-data
path: /etc/nginx/sites-available/default
content: |
server {
listen 80;
location / {
proxy_pass http://localhost:3000;
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection keep-alive;
proxy_set_header Host $host;
proxy_cache_bypass $http_upgrade;
}
}
owner: azureuser:azureuser
path: /home/azureuser/myapp/index.js
content: |
var express = require('express')
var app = express()
var os = require('os');
app.get('/', function (req, res) {
res.send('Hello World from host ' + os.hostname() + '!')
})
app.listen(3000, function () {
console.log('Hello world app listening on port 3000!')
})
runcmd:
service nginx restart
cd "/home/azureuser/myapp"
npm init
npm install express -y
nodejs index.js

After deployment of centos VM the "user-data script" is not working, these are logs

I have doubt that when I tested on the ubuntu machine is working fine, but I tried a number of times on centos vms still it is not working, is script issue or centos os is not compatible for cloud-init?
Here I attached cloud-init logs
cloud-init.log
Thanks,
Bobby.
Edited: Added doc metadata

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d3da20d-57c3-1dcf-ada6-e9ded556e028
Version Independent ID: bc6f80e2-38c9-aafe-cbe9-2eaf94117474
Content: Tutorial - Customize a Linux VM with cloud-init in Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/tutorial-automate-vm-deployment.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

@bobbybhaskar, Thanks for the question! We are taking a look into this and will get back to you soon.

Hi @bobbybhaskar ,
That script in the quickstart is intended for an UbuntuLTS  image.
Azure Supports cloud-init for a number of CentOs images. See the list here to ensure your using the correct version for your script. This doc here has good examples for a Centos image.


Use verify-agent-conf

This is more just informational for @jm404 since I just stumbled across it myself:
As of chef 12.5.1, you can use verify in the template resource as follows:
include_recipe 'wazuh::manager'

template "#{dir}/etc/shared/default/agent.conf" do
  source 'manager_agent.conf.erb'
  owner 'ossec'
  group 'ossec'
  mode '0644'
  verify '/var/ossec/bin/verify-agent-conf -f %{path}'
end

As seen: https://github.com/chef-cookbooks/openssh/pull/120

Hi @curiositycasualty ,
I reviewed the Chef changelog and the OpenSSH example you provided. It gives a great way to verify the modifications of configurations files. Will surely implement it on new release (#28) and will let you know!
I really appreciate your mention to give me some good examples and ideas.
Best regards!
Jose

Hi @curiositycasualty ,
I've investigated the verify parameter and tested it in different situations. If the code block in the verify parameter resolves to false, the whole chef-run process is stopped.
I understand it as a stopping condition but can't see a fit in our installation process for it.
Let me mention you the official docs in case you want to check them: https://docs.chef.io/resource_template.html
Anyway, I appreciate your mention and feel free to open any other issue with any other issue, question or improvement.
Best Regards,
Jose

@jm404 What's the use case for not wanting to stop the run if the manager's shared agent.conf is invalid according to verify-agent-conf? I would think you wouldn't want to write an unverified .conf file into place. Like Salt's check_cmd, the verify stuff is run against a file before it gets placed at the final location specified in the template resource.
Without this, you can have an invalid agent.conf which the manager will silently refuse to push to the agents.

Hi @curiositycasualty ,
The Wazuh Manager cookbook implements Gyoku in order to give the user flexibility when configuring the ossec.conf file. The main reason for using Gyoku is that makes the installation completely flexible, you can declare any attribute you want and it will be translated to XML and properly inserted in ossec.conf file.
Same happens with agent.conf, I think that it's way more difficult and a worse approach to generate that file using a template because it makes the installation process much less flexible and harder to customize.
The solution you proposed is completely right, stopping the manager from pushing a wrong configuration file makes a lot of sense but we can't benefit from the verify parameter since we don't use templates for ossec.conf and agent.conf is not implemented yet.
Anyway, as you stated, some method of verification for configuration files is needed. I'm testing different approaches to implementing this.
Best Regards,
Jose

@jm404 It would see using Gyoku actually nets you less flexibility.

Hi @curiositycasualty ,
I checked the official docs for file resource and as you stated it implements the verify parameter. I will keep it in mind when implementing agent.conf.
We've had no problems with nesting Gyoku as you can check here. Anyway we are reviewing that issue in 3.9.
Regards,
Jose

In the link you supplied, there's an array of hashes, which is valid ruby even when the hashes are duplicates of each other. In the link I supplied, there's a hash with multiple, duplicate keys. I think the submitter for https://github.com/wazuh/wazuh-chef/issues/10 was referring to the fact that {... feed: {...}, feed:{...} ...} is an invalid ruby hash due to duplicate keys, but if Gyoku-ize-able, would produce valid xml (<thing>...<feed>...</feed>...<feed>...</feed>...</thing>).
But that's a different conversation, I'll close this one out.


Resetting TrainTab on start training click is confusing

When StartTraining is clicked for images ...
https://github.com/dotnet/machinelearning-tools/blob/master/Microsoft.ML.ModelBuilder/ToolWindows/TrainTabControl.xaml.cs#L94
triggers this:
https://github.com/dotnet/machinelearning-tools/blob/master/Microsoft.ML.ModelBuilder/ToolWindows/TrainTabDataContext.cs#L754
right before training ... this sets the training time to 10 seconds.
This causes Local and Azure to fail.

https://github.com/dotnet/machinelearning-tools/blob/master/Microsoft.ML.ModelBuilder/ToolWindows/ModelBuilderDataContext.cs#L307
The value from there ^ should be saved as Default or ... on reset we need to make sure that value is set.
Also, I'm not sure it should be resetting the tab when Start Training is clicked.

I regressed this by adding TrainTabContext.ResetTab() on the Train tab reset step. While the other steps do actually reset everything (e.g. in data tab reset it clears any selected files/folders) the train tab is being called just to clear the train result.
This should be investigated further and a better pattern established, but to unblock us and deprioritize this issue, I've removed the reset code.

Sounds like this is resolved. Moving to Validate


New search UI doesn't have error handling in Selection Session

Describe the bug
In the context of Selection Session, new search UI does not have any real error handling due to the implementation of updateTemplate being a nop. More details can be found in App.tsx,
To Reproduce
Steps to reproduce the behavior:

Open new search UI in Selection Session
Manually throw an error
Nothing is given to indicate an error has happened.

Expected behavior
An indicator like a SnackBar should pop up to let users know what error just happened.
Screenshots
N/A
Stacktrace
N/A
Platform:

OpenEquella Version: 2020.2
OS: Ubuntu 18.04
Browser: Chrome, Firefox

Additional context
N/A

Tested.


Request Headers should convert object to Headers

The request will currently accept headers as an object and apply them directly when they should be converted to a Headers instance.
This makes headers an object:
const request = new Request(requestUrl, {
    header, {
        'x-foo': 'bar',
    }
});

This makes headers a Headers Map:
const headers = new Headers();
headers.set('x-foo', 'bar');

const request = new Request(requestUrl, {
    headers,
});

(Related to #48)
In addition to what @gauntface mentioned:

Headers has an append() method that's not the same as set()
Headers can be constructed from a Headers object, which is different from map
Map has a few methods that Headers doesn't have, like clear().

I'd recommend implementing Headers as composing Map rather than extending Map.

Oh no! My laziness is showing! I'll get this fixed for you all 😳

Thanks! BTW, we have some mocks that we're using locally that we'll try to upstream once we're happy with them.

@philipwalton mind taking a look at the PR above ^? Should work, and my tests pass, but wanted to make sure before I push and publish again!

The fix has been published to 1.7.1. Thanks for report!


Update PR template

Update PR template to use published content to get lighthouse scores.

Resolves: https://github.com/adobecom/bacom/issues/106
Test URLs:

Before: https://main--bacom--adobecom.hlx.live/?martech=off
After: https://bmarshal-pr-template-live--bacom--adobecom.hlx.live/?martech=off

Codecov Report

Merging #124 (2d8006c) into main (3bf4b2d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   96.36%   96.36%
=======================================
  Files           6        6
  Lines         468      468
=======================================
  Hits          451      451
  Misses         17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


implement Trino source

I'd really like to see Trino being implemented as a source in ConnectorX and thus have begun working on it. It uses prusto as a client and currently supports all basic types. Support for tuple, array, row and uuid isn't implemented yet and there's a bug with time columns not being mapped correctly. Also I want to look into fetching results more efficiently and not everything at once.
What do you think, is it worth continuing work on it? Is there anything else I need to consider eg. regarding mapping the results?

Thanks @domnikl for the PR. I think it in general looks great and complete!

Also I want to look into fetching results more efficiently and not everything at once.

Yes, I think this might be an issue in terms of performance. I don't have experience of using prusto before, but it seems like the get and get_next APIs are working for gradually fetching the results. Not sure whether it is easy to switch from get_all to these two.

time columns not being mapped correctly

I'm not sure what exactly the bug is. Currently we are converting the NaiveTime type in rust to String type in pandas in general (and also I see it in your pr), it is done by the function here. If you want to customize the conversion or mapping it to another type in pandas, it can be done by modifying the mapping in the macro as well as this function.
It would be great to also submit the corresponding seed database script here so others can run the python test_trino locally.

@wangxiaoying thanks for looking into it!

I'm not sure what exactly the bug is

The problem is with reading timestamps with time zone types, prusto does not support it (yet) by the looks of it. Instead it returns EmptyData and it appears the result is just empty. But its not that important anyway I think to get starting. I'll create an issue in their project.

It would be great to also submit the corresponding seed database script

Will do in the next days and also rework fetching from the database with the get/get_next calls if possible.

@wangxiaoying I implemented the missing partitioning as well as switched to get/get_next for prusto and fixed the tests and added test data and squashed some bugs along the way. Could you have a look at it again please?

Hi @domnikl , thanks so much for completing the PR!
I've tested the test cases locally and it seems works well. I have two minor comments above but in general I think the code looks good and complete. We probably also need to add a documentation page for trino here.
I think after fixing the above minor issues, we can merge it and make it into our next release!

@wangxiaoying thanks for having a look! Added the missing pieces and a bit of documentation for it.


[FLINK-21646][table-planner-blink] Support StreamExecWindowAggregate json serialization/deserialization

What is the purpose of the change
This pr aims to support json serialization/deserialization for StreamExecWindowAggregate
Brief change log

Port the classes in windowingSpecs.scala to Java
Port the classes in plannerWindowProperties.scala to Java
Port FlinkRelBuilder.PlannerNamedWindowProperty to Java
Support Duration json serialization/deserialization
Support StreamExecWindowAggregate json serialization/deserialization

Verifying this change
This change added tests and can be verified as follows:

Added WindowAggregateJsonPlanTest and WindowAggregateJsonITCase which could verify the change

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

It seems a81f035dc4ec463e7c7c7323b54249ec9e194cc2 is also introduced mistakenly in this pr ...

It seems a81f035 is also introduced mistakenly in this pr ...

Before this pr is based on https://github.com/apache/flink/pull/15194, and once https://github.com/apache/flink/pull/15194 is merged, I will rebase the master and drop the first commit

@zjuwangg I have rebased the master


Improve visibility of Metaflow Code object

The code tarball saved by Metaflow is accessible with the client but it is not very easy to work with. We may want to make it more visible possibly even in the Metaflow UI.
Another idea would be to link it to the source control that the Metaflow code is in (if there is one). In particular, we could store the branch/commit information as well as a "dirty" patch file if needed. We can keep the same tarball to work internally but also linking it to the user's development environment may make it easier to work with.

Ksnonxonidnid
Idnosmosvs. Ochiens
X xbodenpms x
Muvsunod. Jusm
Xj. Ofnpdnidnisoms e
I did lncocnrk ud zlmco
Cl js inckd
L.zh icnfos.ls.


Adding automatic channel name to Hex color mapping

Here I made a dictionary with the most popular colors and most of the channels utilized in our imaging platforms including the label-free channels (i.e S0,S1,S4, Retardance,Phase,etc) and fluorophores (i.e GFP, TXR, DAPI, etc) to automate the channel name to hex color mapping #83 .
For the color mapping, I have the red fluorophores mapped to magenta as magenta-green is preferred for visualization to be inclusive for folks with deuteranomaly. We currently don't have an easy way to handle HSV #74  except splitting the HSV into RGB, in which each channel is named red, blue, and green.

@mattersoflight
One interesting thing to note is that in the from the CSS3 Specifications lime is (0,255,0) and green is just an opaque lime (0,128,0).

From these suggestions, we realized that the current pydantic.color.Color() converts the long hex to short hex (i.e #FFFFFF to #fff). However,  the following function was also not working when modifying the color field and calling .json(), so I'm getting rid of it since it doesn't work and it also outputs the wrong hex format.
https://github.com/czbiohub/iohub/blob/866e6690991fee623a00b8c60a3602a4d7b30922/iohub/ngff_meta.py#L254
Instead, we will import the color dictionary from the CSS Specs that already exist in PIL.
Thank you @ziw-liu!

Adding to maybe why the json_encoder didn't work is linked here
Given that it's used here as well. https://github.com/czbiohub/iohub/blob/866e6690991fee623a00b8c60a3602a4d7b30922/iohub/ngff_meta.py#L303

Adding to maybe why the json_encoder didn't work is linked here
Given that it's used here as well.
https://github.com/czbiohub/iohub/blob/866e6690991fee623a00b8c60a3602a4d7b30922/iohub/ngff_meta.py#L303

Thanks for pointing this out! I think I fixed the remaining one in https://github.com/czbiohub/iohub/pull/101/commits/411a51350d3d35fdde28e53e021c6697e6995154.


Gradle

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0e8be28). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #287   +/-   ##
=========================================
  Coverage          ?   52.73%
  Complexity        ?      215
=========================================
  Files             ?       59
  Lines             ?     1189
  Branches          ?      166
=========================================
  Hits              ?      627
  Misses            ?      479
  Partials          ?       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8be28...2caab79. Read the comment docs.


setReference not working the other way around

I have a many to many relationship and I'm using foreign keys in the singular:
- orders
- products
- order_has_products

order_has_products.order_id -> orders.id
order_has_products.product_id -> products.id

When I use setReference to try to configure this relationship it works only in one sense but not in the other:
$db->setReference('order_has_products', 'orders', 'order_id');

// this works
$db->order_has_products([
    'order_id' => 1000,
    'product_id' => 200
])->orders();

// this doesn't work
$db->order(1000)->order_has_productsList()->fetchAll();

// but this works
$db->order(1000)->order_has_productsList()->via('order_id')->fetchAll();

Shouldn't it work without via() ? Am I doing something wrong or this functionality is not supported?

Seems I should have used $db->setBackReference() although it wasn't clear by the example provided by the documentation.

The confusing part here is that via works both ways, whereas references and back references are needed depending on where you start. In your example, you'll need both setReference and setBackReference: orders is back referenced by order_has_products.order_id and order_has_products references orders via order_id.
Note however that your db structure does not follow the conventions. If your table names were order and product instead of their plural forms, none of the schema hints were required (except maybe setPrimary on order_has_product because of composite key).
I'll add a note to the docs that table names should really be singular by convention. In any case, thanks for reporting!

Yeah, I understand I wasn't following the standards. It's just that I'm working with an existent database. I guess I just got confused.

If you have more ideas how to improve the API or the docs somehow, let me know :-)


Update GUI - On script generation

Due to WxWidget the painted colours that happens based on walking patterns are not shown immediately. The steps grid is typically only repainted on a new click event. Which is annoying and confusing when intermediate walk steps are not identifiable immediately.

Agreed, it is really annoying and would be nice if It was possible to fix.


Feature/refactor hakodate scripts

What is this pull request?

In this PR hakodate scripts were refactored, so that we can set up IROHA_CLI environment variable to run iroha-cli from any place. Before we have hardcoded absolute path every time, when we called iroha-cli.
It turns out that on mac port 10001 is not available. So it was changed to 10000.
In order to everyone be able have their own config files, config.json was added to .gitignore and config.sample was created

Why do you implement it? Why do we need this pull request?
To increase flexibility of running iroha example
How to use the features provided in the pull request?

Now to add your own configs you need to copy config.sample file (like cp config.sample config.json) and edit config.json.
As before you can run hakodate.sh and run.sh. But now if you running iroha on your own machine and not in the docker you need to add environment variable IROHA_CLI, which points to iroha-cli binary

Details/Features
List of features / major commits
Common functions for hakodate.sh and run.sh were moved to functions.sh file

Codecov Report

Merging #598 into develop will increase coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #598      +/-   ##
===========================================
+ Coverage    44.63%   44.85%   +0.22%
===========================================
  Files          275      271       -4
  Lines        11383    11200     -183
  Branches      6036     5909     -127
===========================================
- Hits          5081     5024      -57
+ Misses         752      750       -2
+ Partials      5550     5426     -124

Impacted Files
Coverage Δ

libs/common/types.hpp
60.86% <0%> (-0.67%)
:arrow_down:

libs/common/operators.hpp

test/module/libs/result_test.cpp

libs/common/result.hpp

libs/common/visitor.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3251cbe...87ee73a. Read the comment docs.


a couple of IO plugins

HI,
here I propose to add plugin for:

export x,y,z centres of all spots as a tab-delimited plain-text file
export x,y,z,t as a tab-delimited plain-text file
import the two above (no linking)
export t,x,y,z,trackLabel,trackParent,spotLabel plain-text file[1]
import from instance segmentation including

linking based on same labels
linking based on overlap
GUI dialog to choose which view or external files one wants to use for the import

[1] The file is envisioned to be imported/parsed easily into whatever one wishes (Excel, python, plotting...). The tracking get out of Mastodon's internal (and binary) format.
The plugins (are hopefully fully) aware of viewTransforms, aha, that concerns probably only the instance segmentation importer as this one works with voxel data. I can demo everything.
Vlado

this PR (including the Jan's suggestion) has been incorporated into https://github.com/mastodon-sc/mastodon-ctc (which is making it more a mastodon-IO at the moment....)


Pulsar: report latency in ns for Payload RRT and allow to connect with non-admin privileges

Fallout expects latencies in "ns" and not in "ms".
This patch reports latency for payload_rtt measure in "ns"
I also added a fix to connect to Pulsar cluster with Tokens with low privileges

@jshook this patch is ready for review


How to install Node and Probot for Development

New Developers may not not understand how to install node and probot with the current instructions. This PR expands the instructions for developers working on Mac OS X.

This is awesome, thanks @webdog! We do have another repo create-probot-app to help people get started - do you think it makes sense to point people there instead of suggesting an npm install probot?

@JasonEtco Oh awesome! That repo looks to be scaffolding on top of probot, yeah? I think offering that in the docs (Instead of replacing npm install probot) would be super helpful to help people get started. What do you think?

That repo looks to be scaffolding on top of probot, yeah?

Yep! I think it's in the docs somewhere, but it's often a good place to start as you suggest. It does still require Node installed though - maybe we can do both here?

@JasonEtco Yeah! Let's do both, I think that gives users the most info to ramp up 👍


Move icons artifacts under kobwebx?

Do "font-icons-fa" and "font-icons-mdi" really belong under core Silk namespaces? Probably not! They should probably be considered an "extension" to the core classes, say at the same level as the markdown feature is. This is because many users might want to omit them if they don't need them, as they increase their site's download footprint.
Note that recently Silk has been adding more and more SVG icons into its feature set. That seems more like something "core".
If we go through with this change, I think it implies the artifact should become "com.varabyte.kobwebx:kobwebx-silk-icons-xxx" and then the namespace for all the icons move to "com.varabyte.kobwebx". Of course, we'll need to update all templates to use the new ones.
Old codebases should still work because "com.varabyte.kobweb:kobweb-silk-icons-xxx" will still be hosted, although once they bump up their kobweb version, they may get compile errors.

This is done and the change will go out in 0.14.1


AttributeError: 'NoneType' object has no attribute 'namespace'

No idea why it's not being caught in Sentry so pasting here manually.
This is in packit-service@stg pod logs after accessing https://stg.packit.dev/api/srpm-builds?page=6&per_page=20
 mod_wsgi (pid=20): Exception occurred processing WSGI script '/usr/share/packit/packit.wsgi'.
 "GET /api/srpm-builds?page=6&per_page=20 HTTP/1.1" 500 538
 Traceback (most recent call last):
   File "/usr/local/lib64/python3.7/site-packages/werkzeug/middleware/dispatcher.py", line 66, in __call__
     return app(environ, start_response)
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 2464, in __call__
     return self.wsgi_app(environ, start_response)
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 2450, in wsgi_app
     response = self.handle_exception(e)
   File "/usr/local/lib/python3.7/site-packages/flask_restx/api.py", line 638, in error_router
     return original_handler(f)
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 1867, in handle_exception
     reraise(exc_type, exc_value, tb)
   File "/usr/local/lib64/python3.7/site-packages/flask/_compat.py", line 39, in reraise
     raise value
   File "/usr/local/lib/python3.7/site-packages/flask_restx/api.py", line 636, in error_router
     return self.handle_error(e)
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
     response = self.full_dispatch_request()
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
     rv = self.handle_user_exception(e)
   File "/usr/local/lib/python3.7/site-packages/flask_restx/api.py", line 638, in error_router
     return original_handler(f)
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
     reraise(exc_type, exc_value, tb)
   File "/usr/local/lib64/python3.7/site-packages/flask/_compat.py", line 39, in reraise
     raise value
   File "/usr/local/lib/python3.7/site-packages/flask_restx/api.py", line 636, in error_router
     return self.handle_error(e)
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
     rv = self.dispatch_request()
   File "/usr/local/lib64/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
     return self.view_functions[rule.endpoint](**req.view_args)
   File "/usr/local/lib/python3.7/site-packages/flask_restx/api.py", line 375, in wrapper
     resp = resource(*args, **kwargs)
   File "/usr/local/lib64/python3.7/site-packages/flask/views.py", line 89, in view
     return self.dispatch_request(*args, **kwargs)
   File "/usr/local/lib/python3.7/site-packages/flask_restx/resource.py", line 44, in dispatch_request
     resp = meth(*args, **kwargs)
   File "/usr/local/lib/python3.7/site-packages/packit_service/service/api/srpm_builds.py", line 60, in get
     "repo_namespace": project.namespace,
 AttributeError: 'NoneType' object has no attribute 'namespace'

Thanks.

No idea why it's not being caught in Sentry

Sentry isnt enabled in the service pod.

Sentry isnt enabled in the service pod.

We should fix that since the API is getting a lot of use lately.


Add SPSP 2016

There are a lot of unreleated changes in this PR. @jolene-esposito Can you resend this, making sure to branch off of master when you make your changes?
Thanks