Set $stderr/$stdout to mocked io in runner

Set $stderr/$stdout to mocked io in runner
Description
Set $stderr/$stdout to mocked io in runner so that the output is captured correctly if someone uses $stdout.puts or $stderr.puts inside cucumber. This trival changes makes testing output on $stderr/$stdout a lot of easier. Otherwise some quirks are needed to capture and check them using steps from aruba.
I found that one while implementing the new options-API for formatters. Without that change testing is cumbersome.
Motivation and Context
I would like to be able to capture puts output to make feature https://github.com/cucumber/cucumber-ruby/pull/954/files#diff-61df043d3516e6b2647a8c992f671037R70 pass.
How Has This Been Tested?

Tested via cucumber run
I verified the output of cucumber

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I don't understand the use-case for this. Can you show me the code that needs it?

Sorry, that I was not that explicit about the reason behind the change.

cucumber uses aruba's InProcess-feature

In lib/cucumber/cli/main.rb a user can pass STDOUT and STDERR. This is used for the tests

In https://github.com/cucumber/cucumber-ruby/pull/954/files#diff-61df043d3516e6b2647a8c992f671037R70 I need to output information. I see two options for this

Use config.out_stream.print

Use puts

Unfortunately #out_stream is not really an option for this example. It refers to the out-file. puts's output is not captured by the Then it should pass with exactly: step, since puts does not use the the StringIO-object passed into Cli::Main.new.
If I change the code of Cli::Main.new to also set $stdout and/or $stderr all output generated by $stderr.puts, $stdout.puts and puts is captured and can be validated by Then it should pass with exactly: step.
I also added an description to aruba's documentation some time ago. Hope this also makes things clearer: https://github.com/cucumber/aruba/blob/0a3bffa5817911b4f72e9bb286582fb325d75780/features/steps/command/in_process.feature#L315.

The failing test is not related to this PR. It's mime-types which fails on ruby < 2.0.0 I send you another PR to fix that.

Right I think I understand. You want a way to print to the process's STDOUT from the custom formatter created in the test scenario so that you can validate the behaviour of the code you're testing by reading STDOUT. You can't just use puts because way Cucumber captures calls to puts and sends them through the formatters (and thus into the output file).
Did you consider using $stderr.puts directly in the custom formatter? I think that's what I normally do when I want to circumvent the puts capture.

You want a way to print to the process's STDOUT from the custom formatter created in the test scenario so that you can validate the behaviour of the code you're testing by reading STDOUT.

Exactly. But I also tried STDERR via $stderr.

You can't just use puts because way Cucumber captures calls to puts and sends them through the formatters (and thus into the output file).

When I remember correctly only config.out_stream.print sends output to the output file. Which is expected for this test case.

Did you consider using $stderr.puts directly in the custom formatter? I think that's what I normally do when I want to circumvent the puts capture.

Yes. I tried all three and they all fail.

$stderr.puts
$stdout.puts
puts

Background:
In aruba we pass in StringIO's to cucumber's runner. In the steps we use all output written to those StringIO-objects. Or with other words aruba mocks stdout/stderr via arguments in Cucumber::Cli::Main.new. Those passed objects are used for all latter tests in the steps.
Problem
Without the change proposed in this PR, the following is true - at least from my understanding. This seems to be proofed because without the change using puts/$stderr.puts the output of cucumber is cluttered.
$stderr != @stderr # from Aruba
$stdout != @stdout # from Aruba
$stderr == STDERR
$stdout == STDOUT

One possible solution
Within the Main-class you've got access to @err e.g. in this line, but not in other "contexts", because @err/@out not passed down to other classes. I think the best we can do is overwriting $stderr and $stdout since they are global and accessible from each and every context.
With this PR merged:
$stderr == @stderr # from Aruba
$stdout == @stdout # from Aruba

And even a simple puts works - at least with ruby 2.3.0.
Does this makes sense to you @mattwynne

I'm still finding this one a bit difficult to parse, sorry @maxmeyer.
What it comes down to, is that I'm very uncomfortable setting global variables inside this class. If you really need them to be set, can't you do that yourself in the client code?

@mattwynne Will have a look at that.

I understand the problem now, and I think this is the wrong solution.
We need to fix Aruba's InProcess adapter to do this (or something like it) itself, don't we?

We need to fix Aruba's InProcess adapter to do this (or something like it) itself, don't we?

Yeah, that seems to be the best idea.


Document All of the Chat Commands

Add documentation for all of the chat commands both in game and out of game. An updated list of commands with descriptions should be accessible with the !help, !helptraitor, and !helpadmin commands in game. Out of game, a list of commands and their usage should be included in the readme.

Did first pass on readme adding existing commands.


INFRA-122 - use getAssetPath() as per readme

Hopefully fixes loading assets like the FR logo in footer in full dist load contexts like the "sorry" page

Code looks like it's fine as long at works - @NoelLH would you suggest I test it any way in particular? If not happy for you to merge.

I don't think we can easily tell for sure that it works prior to merging. We should see the Fundraising Regulator logo in the footer of the sorry page instead of a broken image. We might see Firefox load the page.


Add ScrollLock component, extend Scrollable

Fixes #56
The ScrollLock component wraps any scrollable element, and prevents users from scrolling past its top or bottom extent. This is especially important for scrollable modals or dropdowns, as scrolling past the end will otherwise cause the page to scroll.
Implemented by cloning the only child element and catching the wheel event, which is cancelled if the scroll would move past the end of the container.
Since this is the expected user behaviour, also extend Scrollable to use ScrollLock by default. This can be disabled with a prop.

Coverage decreased (-0.2%) to 99.761% when pulling 9f88b402c01022339b7d3302f681fbfae7f3d0b4 on alisdair:scroll-lock into f392c6b6af4d39c4bb53d982047943cfddc88f49 on helpscout:master.

Coverage remained the same at 100.0% when pulling e08b09a50cdbaac778e4d1f65e6791813686043a on alisdair:scroll-lock into f392c6b6af4d39c4bb53d982047943cfddc88f49 on helpscout:master.

@alisdair Amazing!! Thank you so much :D. As a bonus, it works beautifully in components like Modals that already <Scrollable>., which get scrolllock for free with this update 😊
Super approved!


Can't edit details / properties

After adding a page to monitor I can't edit the settings.
Steps to reproduce:
checkout master (currently at: d1bf249eb036bac9fe937a2a2fb7a53c13dd4f75)
run: mvn spring-boot:run -Djava.io.tmpdir=sitemonitoring-temp -Dspring.profiles.active=dev -Ddbport=9001 -Dserver.port=8081
open browser at: http://localhost:8081/
login: admin/admin
manage pages
enter page name: test
press save
try to edit details (press wrench button)
nothing happens

My Bad...
Edit is only for editing the name, this works perfectly.


Minor fixes in concepts-multiple-qubits.md

Qubits, not gates, have the state
Fix missing ')'
Change $ to $$ since the equation doesn't fit into a line anyway
Two-qubit basis is formed from one-qubit basis states
Shorten and clarify the sentence about partial measurement
Add comma
Shorten and clarify the sentence about 50% probability
Fix the sentence defining e_k and S
explicitly give -> need (a formula)
Trying to break the cycle "what happens when the probability is zero - no problem because the probability is zero"
Remove confusing/redundant part of a sentence.
the state after the first qubit is measured

@microsoft-github-policy-service agree


Add maximum scan range for ndt_mapping/approximate_ndt_mapping

New Feature
ndt_mapping/approximate_ndt_mapping ignore the scan points closer than Minimum Scan Range but there are no parameter to ignore the scan points far than certain distance. So Maximum Scan Range should be added.

Merged


Indicators for OPG

Check box when indices are coded, include a docstring and are accompanied by unit tests.

Indicator
Description
Units
Done

Heat wave index
Days that are part of a heat wave (5 or more consecutive days with Tmax > 25°C)
# of days / year
 [x]

Cold spell index
Days that are part of a cold spell (5 or more consecutive days with Tavg < -10°C)
# of days / year
 [x]

Freeze/thaw cycles
days when Tmax >0°C and Tmin < 0°C
# of days / year
 [x]

Very hot days
Days when Tmax > 30°C
# of days / year
 [x]

Cooling degree days
Air conditioning indicator: number of degrees a given day’s Tavg is >18°C
Sum of degree days / year
 [x]

Heating degree days
Heating indicator: number of degrees a given day’s Tavgis <18°C
Sum of degree days / year
 [x]

Freshet start
First day of year that is followed by >5 consecutive days each having Tavg > 0°C
Day of year
 [x]

Winter rain
Ratio of rainfall to total precipitation during December/January/February(rainfall assumed when Tavg > 0°C)
ratio
 [x]

Possible rain-on-snow events
Days with rainfall that followed 7 or more days of Tavg< 0°C    (rainfall assumed when Tavg > 0°C)
# of days / year
 [x]

Maximum 3-day spring precipitation
Maximum 3-day total precipitation during spring (March-May)
mm
 [ ]

Mean Monthly Temperature
Mean monthly temperature
°C
 [x]

Max Monthly Temperature
Max monthly temperature (daily max of month)
°C
 [x]

Min Monthly Temperature
Min monthly temperature (daily min of month)
°C
 [x]

Total Monthly Precipitation
Sum of all precipitation during a month
mm
 [x]

Frost Days
Number of days with Tmin <0°C
Days
 [x]

Consecutive dry days
Maximum number of consecutive days with precip < 1mm
Days
 [x]

Heavy precipitation days index
Number of days when precipitation >10mm
Days
 [ ]

Heavy precipitation days
Number of days when precipitation >20mm
days
 [ ]

Monthly Temperature variability
Standard deviation of monthly temperature (over e.g 30-year period)
°C
 [ ]

Monthly Precipitation variability
Coefficient of variation of monthly precipitation (over e.g. 30-year period)
-
 [ ]

@huard
I've copied-pasted this table into the GitHub wiki (https://github.com/Ouranosinc/xclim/wiki/Indicator-List). To be revised as we continue to develop, I suppose.

We can close this one when #90 is merged. The remaining indices can be obtained by existing indices.

Cool. Closing now!


Stream not closed when running XsltPipe plus HttpSender witth test a pipeline

Describe the issue
When testing the below configuration with latest 7.9 SNAPSHOT version test a pipeline will say:
An error occured!
When opening the report in progress with Ladybug the output of the pipeline shows:
context:
content-length: 0
date: Tue, 28 Feb 2023 12:46:34 GMT
Metadata.Charset: ISO-8859-1
Http.StatusCode: 200
Http.ReasonPhrase:
value:
Waiting for stream to be read, captured and closed...
With 7.8-RC3 everything seems to work fine.
Reporter
Jaco de Groot

To Reproduce
Steps to reproduce the behavior:

Run an adapter with only the below pipes (xxx needs to be replaced with a valid value, I can provide one when needed)
Use test a pipeline with the below input
See error

Screenshots
-
Configuration
			<XsltPipe
				name="Xml to Json"
				xpathExpression="concat('{"temperature":', /current/temperature/@value, '}')"
			/>
			<SenderPipe	name="Post temperature to ThingsBoard">
				<HttpSender
					url="https://demo.thingsboard.io/api/v1/xxx/telemetry"
					methodType="POST"
					contentType="application/json"
				/>
			</SenderPipe>

Input
<current><temperature value="0"/></current>

Environment
Not okay with:
FF! 7.9-20230224.143242: Frank2Example3
Running on xxx using Apache Tomcat/9.0.68
Java Version: OpenJDK Runtime Environment (1.8.0_292-b10)
Heap size: 206M, total JVM memory: 692M
Free disk space: 48GB, total disk space: 475GB
Up since: 2023-02-28 13:31:35 (10m)

Okay with:
FF! 7.8-RC3: Frank2Example3
Running on xxx using Apache Tomcat/9.0.68
Java Version: OpenJDK Runtime Environment (1.8.0_292-b10)
Heap size: 274M, total JVM memory: 995M
Free disk space: 48GB, total disk space: 475GB
Up since: 2023-02-28 13:43:34 (26s)

Additional Environment
-
Additional Context
-

Can't reproduce this? Might have been fixed in #4692.

Did a retest and it is indeed solved. With 7.9-20230224.143242 I still get the error with 7.9-20230706.190017 there's no error.


Failed to activate the Hydrogen package

It seems like Hydrogen now requires libzmq5 instead of libzmq3, is this correct?  Hydrogen (0.7.0) was working fine for me until I updated to 0.7.1.  I cannot roll back now, however, since I get the same error.  I'm trying to figure out if I did something else to break this on my end...
[Enter steps to reproduce below:]
$ apm install hydrogen
Installing hydrogen to /home/knox/.atom/packages l✓
$ atom .
# Failure then occurs when running hydrogen in any python file

Atom Version: 1.5.3
System: Ubuntu Xenial
Thrown From: Hydrogen package, v0.7.1
Stack Trace
Failed to activate the Hydrogen package
At libzmq.so.5: cannot open shared object file: No such file or directory

Error: libzmq.so.5: cannot open shared object file: No such file or directory
    at Error (native)
    at Object.module.(anonymous function) (ATOM_SHELL_ASAR.js:137:20)
    at Object.module.(anonymous function) [as .node] (ATOM_SHELL_ASAR.js:137:20)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at bindings (/home/knox/.atom/packages/Hydrogen.old/node_modules/zmq/node_modules/bindings/bindings.js:76:44)
    at Object.<anonymous> (/home/knox/.atom/packages/Hydrogen.old/node_modules/zmq/lib/index.js:6:30)
    at Module.contents.overrideModuleCompile.Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.keys.forEach.Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/knox/.atom/packages/Hydrogen.old/node_modules/zmq/index.js:2:18)
    at Module.contents.overrideModuleCompile.Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.keys.forEach.Object.defineProperty.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/knox/.atom/packages/Hydrogen.old/lib/main.coffee:4:7)
    at Object.<anonymous> (/home/knox/.atom/packages/Hydrogen.old/lib/main.coffee:1:1)
    at Module.contents.overrideModuleCompile.Module._compile (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.keys.forEach.Object.defineProperty.value [as .coffee] (/usr/share/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/usr/share/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Package.module.exports.Package.requireMainModule (/usr/share/atom/resources/app.asar/src/package.js:720:27)
    at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:172:16)
    at /usr/share/atom/resources/app.asar/src/package.js:800:25
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:241:20)
    at __bind (/usr/share/atom/resources/app.asar/src/command-registry.js:3:61)
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:536:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:359:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/usr/share/atom/resources/app.asar/src/window-event-handler.js:97:36)
    at HTMLDocument.__bind (/usr/share/atom/resources/app.asar/src/window-event-handler.js:3:61)

Commands
     -0:01.0 hydrogen:run (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "language-python"
    ],
    "themes": [
      "one-dark-ui",
      "pumpkin-syntax"
    ]
  },
  "Hydrogen": {
    "languageMappings": "{\"magicpython\": \"python\"}"
  }
}

Installed Packages
# User
Hydrogen, v0.7.1
MagicPython, v0.5.8
autocomplete-python, v1.6.1
browser-plus, v0.0.54
color-picker, v2.1.1
language-latex, v0.6.1
latex, v0.29.0
latexer, v0.3.0
linter, v1.11.3
linter-chktex, v1.2.5
linter-flake8, v1.12.0
live-doc-viewer, v1.0.6
method-separator, v0.1.4
minimap, v4.19.0
pigments, v0.24.2
pumpkin-syntax, v0.1.0
python-indent, v0.4.0
python-iresolve, v0.0.3
python-tools, v0.6.7
react, v0.14.1

# Dev
No dev packages

We tend to require libzmq3, there is no libzmq 5 (4.1 was the last release of libzmq, with 4.2 likely to come down the pipe relatively soon). What does apt-cache search libzmq show?

For some reason, the libzmq 4.1 lib is named libzmq.so.5 on my machine.  I have anaconda installed and it uses the same naming convention in my conda env lib directory:
$ ls /path/to/anaconda/atom/lib/libzmq*
libzmq.a
libzmq.la
libzmq.so
libzmq.so.5
libzmq.so.5.0.0

$ conda list
# packages in environment at /path/to/anaconda:
#
# . . .
zeromq                    4.1.3
# . . .

Even zeromq.org references libzmq.so.5 for zeromq 4.1, which I admit, confuses me (see Running Example heading about halfway down that link).
Here is the result of running the apt-cache search, although I suspect the anaconda libs might override this:
$ apt-cache search libzmq
libjeromq-java - Java implementation of the ZeroMQ messaging library
libxs-compat-libzmq-dev - Crossroads I/O 'libzmq' compatibility library (header files)
libxs-compat-libzmq1 - Crossroads I/O 'libzmq' compatibility library (shared library)
libzeromq-perl - messaging library using ZeroMQ
libzmq-dbg - lightweight messaging kernel (debugging symbols)
libzmq-dev - lightweight messaging kernel (development files)
libzmq-java - ZeroMQ Java bindings (jzmq)
libzmq-java-doc - Documentation for ZeroMQ Java bindings (jzmq)
libzmq-jni - ZeroMQ Java bindings (jzmq)
libzmq1 - lightweight messaging kernel (shared library)
libzmq3 - lightweight messaging kernel (shared library)
libzmq3-dbg - lightweight messaging kernel (debugging symbols)
libzmq3-dev - lightweight messaging kernel (development files)
libzmqpp-dev - High-level C++ bindings for zeromq3 - development files
libzmqpp3 - High-level C++ bindings for zeromq3

I've got Hydrogen working again!  It feels like a blindfold has been lifted; Hydrogen has spoiled me. :-)
For what it's worth, I removed all traces of zeromq, ipython and Hydrogen, reinstalled them all using my anaconda env instead of using pip, then deleted atom's compile-cache folder.  In the end I had to install Hydrogen 0.7.0 and zeromq 4.0.5 to get it to work.  Thanks for helping me look into this.
Should I close this, or could there be a genuine issue with Hydrogen 0.7.1?

On 01/03/16 07:27, Jeff wrote:

[...] then deleted atom's compile-cache folder.

Personally, I think what fixed your problem was removing the cache folder.

Should I close this, or could there be a genuine issue with Hydrogen 0.7.1?

Have you tried to upgrade to 0.7.1? If you do so, make sure the libraries in your environment (pip or anaconda) are the same as those used to install Atom and the plugins.

Just curious. Would apm rebuild fix this issue?

A word of caution: apm rebuild should be run on the same folder Hydrogen was installed.

I have the same problem.

Ubuntu 16.04
Atom 1.11.2
Hydrogen 0.15.0

Fixed, by installing libzmq.so.1 vis sudo apt install libzmq-dev.

I am having this same issue but I am unable to install Lodash directly. I need to install it from source.
When I try to run Python code using Hydrogen (Packages -> Hydrogen -> Run) I receive the below error:
Cannot find module 'lodash'
I am behind a proxy and cannot simply run $ npm install lodash --save as described here
I have manually downloaded lodash from here and put them on my computer in this directory "C:\Users...\AppData\Local\atom\app-1.12.4\resources\lodash-4.15.0-npm-packages"
Is there a way I can resolve this error given I have the source file in that location?

@Ben-Gillman In Hydrogen 1.0 we changed the installation method so this issue isn't relevant anymore.
What happens if you install hydrogen with  apm install hydrogen?

I am unable to run apm install hydrogen because I am behind this proxy. When I run this code I receive the error Request for package information failed: tunneling socket could not be established, cause=write EPROTO 0:error...
I had to install Hydrogen 1.0 from source, from here. It lives in "C:\Users...\AppData\Local\atom\hydrogen-1.0.0"

Just copying the hydrogen folder won't install all the dependencies.
I would try install the dev version as described here. But I'm not sure if this works inside a proxy.

@lgeiger Unfortunately, I receive the same error when I run apm develop hydrogen as I do when I run apm install hydrogen.
I am willing to install the dependencies manually if there are not too many


Update Notification will not clear

Top Notification Bar insists there is an update...

No update available, restarting and reinstalling doesn't resolve?

Thanks!

This is unfortunately an issue with BetterDiscord itself, not CollapsibleUI. They are implementing a new integrated updater and it's pretty broken currently. Try clicking on the name of the plugin in the notification itself and see if that works. If not, manually downloading the latest release from here should fix it.


Update setup.py

Adding 'tensorflow-macos' for in list tf_pkg_name for the new tensorflow builds for apple silicon chips.
'distutils.LooseVersion' is depracated
replacing it with 'packaging.version.parse'

I was about to make a pull request for the exact same thing!!!


On getting data from KC Wikia

Hello, I've noticed that this plugin gets its data from KC Wikia by parsing front-end pages. The core data is actually stored in a Lua backend, I have a script that uses MediaWiki API to enumerate those Lua pages and converts them to JSON, so maybe that JSON can be used? Alternatively, there is also https://github.com/KC3Kai/kc3-translations.

I did notice the existence of these data, but fetching them and executing them in lua vm is also complex. By far we only have some difficulties with enemy ship suffixes which could be monkey patched (but we're all doing the similar thing), so I'm not thinking of changing the code.

Well, I'm already converting all that Lua to JSON, the script if fairly simple (something like 100 lines of JS and 50 lines of Lua). I will see if I can generate JSON files just for names, identical to those used in this project, because right now some translations are missing (since some front-end pages are always behind).
Also, can the quests be translated? I see that if I just add translations in the file it somewhat conflicts with the quest plugin (it only adds some translations in tooltips).

IMO since the wikia pages are generated from the backend database, the time lag between these two is not huge. The major factor here is the plugin publishing frequency
For quests we're using JSON structures to store the requirements and rewards, see plugin-quest

It is usually not huge, except for (somewhat abandoned) enemy page, as it can take weeks (if not months) to update, like right now it was last updated in December.
I have plugin-quest installed, but it is
https://cdn.discordapp.com/attachments/176206906141048832/420335119463743498/u.png
(only English string here is one I added via this plugin).

@gakada I realize you're mentioning quest name itself, since the quest name usually fails to imply what the quest is, I personally have no intention to translate them.

Yeah, in other viewers it is not exact translations, but quest codes (wikiwiki/etc.) and short descriptions, like on this screenshot, so you can see what it is without a tooltip.

@gakada to add up the quest name translation could be too long to fit into the quest panel

Like, IMO D2d1: Complete 3 Expe... or Complete 3 Expeditions is better than just untranslated string.

Added _names files here, those are from backend, so should be updated more frequently.

Just realized that some quests have same titles, so replacing those kanji in interface can't be done in this plugin anyway.

Still, running this (have duplicates and missing many quests) gives


Abstract method that returns byte[] array translated with --objc-generics raises compile error

Hi,
we have Java file with method:
abstract byte[] readData();

In .h is generated:
- (IOSArray<JavaLangByte *> *)readData;

It raises compile error: Declaration of JavaLangByte must be imported before required
It looks like that generator counts with usage of IOSByteArray (it is defined by @class declaration in .h file). That is also type, that is used in generated .m file.

Good catch, thanks for reporting it.
As a very temporary workaround, you can add the following above your Java file's class declaration:
/*-HEADER[
#include "IOSPrimitiveArray.h"
]-*/

This adds the block contents to the .h file instead of the .m file.

Oops, make that "java/lang/Byte.h".


Refactor AMQP logic to better isolate rust AMQP code from uAMQP code.

Most of this change is refactoring code, but there is a significant difference in this PR:
doxygen really doesn't handle conditional compilation well if there are ambiguous filenames in the repo. A large part of how this refactoring works depends on the fact that there are files with the same name in two different locations, so doxygen doesn't do well with this.
To resolve the issue, I changed doxygen to scope to just files in the "inc" subdirectory and the readme.md file.
That may result in public APIs which are not in the "inc" directory being dropped, but we shouldn't have any public APIs which aren't in the "inc" subdirectory.

Ping :).

Ping please.

Ping please.

Hi Larry, this is a fairly large PR (I understand a lot of it is refactoring). How would you recommend we review it? Put another way, what areas should we try to focus our attention on, which you think will be the most valuable for you?

Hi Larry, this is a fairly large PR (I understand a lot of it is refactoring). How would you recommend we review it? Put another way, what areas should we try to focus our attention on, which you think will be the most valuable for you?

You should ignore the moved files - that's about 250 or so of the files in the PR.
Concentrate on the 50 or so remaining files.
The vast majority of the changes are removing #if UAMQP conditionals from the UAMQP specific code, and removing UAMQP specific code from the rust implementation.
Note that there are some vestiges of the UAMQP stuff in the rust implementations, that's done so I have boilerplate in place to make the rust implementations of stuff that's not there yet.


ways to get the heating duration and the user defined temperatures

Hello, this is not a bug report but actually 2 questions :

on the COMAP web site in the user interface there is a [Statistiques] tabs with very interesting data. Among them the duration time of eating (per day, weeks,...). Do you know if there is a way to get this value ?

is there a way to read the temperature settings ? (I can get the temperature of the sensor module, the temperature I am setting but not the ones that I programmed)

And again and above all thank you and congratulations for your amazing work !

Hi,
1: For sure there is a way to get them, but it's not implemented into the API. The main goal of the API is to provide actions/infos for Jeedom plugin, and Jeedom histories all data and display them graphically, so there is no need for it into the API.
2: Yes, this was previously reported by the API, but things have changed on comap side. I've just fix it yesterday on Jeedom plugin. I've also just updated the API on this repo.
Basically, you need to get $_qivivo->getFullDevices() and check for model thermostat, order should be correct now.

Thank you again for your great work !
So in your opinion without using Jeedom what would be the best way to assess the duration of eating ?
I was thinking about testing the state of the heating_status on a regular basis (like every 10 minutes or so) but I am sure there is a more elegant way to do so. No ?

Yes you can do a cron that check state, but best way for me would be to integrate this in the API. Not much time right now, but shouldn't be hard, you just need to ask the right url and parse the result, adding a getStats() function.

Thank you again for you answers ! But I don't have much knowledge on how to do that.
I know how to handle API response but I don't get the how the identification process.
More generally is there any place where I could find any kinf of documentation regarding this API ?
I really appreciate the time you dedicate to us and the quality of your work !


Service Bus SDK fails when run inside Azure Container Instances

Using the latest Service Bus Python SDK inside a Windows docker container to send and receive messages from a Service Bus queue works fine. But take the exact same docker container and host it in Azure Container Instances (ACI) and the following exception occurs:
C:\Users\kehilsch\Source\Repos\PythonServiceBus>az container logs --resource-group pythonservicebus --name pythonservicebus
Sending message... Message 0
Traceback (most recent call last):
  File "C:\Python\lib\site-packages\urllib3\connection.py", line 171, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw)
  File "C:\Python\lib\site-packages\urllib3\util\connection.py", line 56, in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
  File "C:\Python\lib\socket.py", line 743, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 343, in _make_request
    self._validate_conn(conn)
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 849, in _validate_conn
    conn.connect()
  File "C:\Python\lib\site-packages\urllib3\connection.py", line 314, in connect
    conn = self._new_conn()
  File "C:\Python\lib\site-packages\urllib3\connection.py", line 180, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.VerifiedHTTPSConnection object at 0x000001CD2D41BDA0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Python\lib\site-packages\requests\adapters.py", line 445, in send
    timeout=timeout
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 638, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "C:\Python\lib\site-packages\urllib3\util\retry.py", line 398, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='khtest1.servicebus.windows.net', port=443): Max retries exceeded with url: /khqueue1/messages (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x000001CD2D41BDA0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\solver\sender.py", line 17, in <module>
    bus_service.send_queue_message('khqueue1', msg)
  File "C:\Python\lib\site-packages\azure\servicebus\servicebusservice.py", line 890, in send_queue_message
    self._perform_request(request)
  File "C:\Python\lib\site-packages\azure\servicebus\servicebusservice.py", line 1228, in _perform_request
    resp = self._filter(request)
  File "C:\Python\lib\site-packages\azure\servicebus\_http\httpclient.py", line 181, in perform_request
    self.send_request_body(connection, request.body)
  File "C:\Python\lib\site-packages\azure\servicebus\_http\httpclient.py", line 143, in send_request_body
    connection.send(request_body)
  File "C:\Python\lib\site-packages\azure\servicebus\_http\requestsclient.py", line 81, in send
    self.response = self.session.request(self.method, self.uri, data=request_body, headers=self.headers, timeout=self.timeout)
  File "C:\Python\lib\site-packages\requests\sessions.py", line 512, in request
    resp = self.send(prep, **send_kwargs)
  File "C:\Python\lib\site-packages\requests\sessions.py", line 622, in send
    r = adapter.send(request, **kwargs)
  File "C:\Python\lib\site-packages\requests\adapters.py", line 513, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='khtest1.servicebus.windows.net', port=443): Max retries exceeded with url: /khqueue1/messages (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x000001CD2D41BDA0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))

I tried creating the ACI with and without a public IP and DNS label, but it did not resolve the exception.
https://docs.microsoft.com/en-us/cli/azure/container?view=azure-cli-latest#az-container-create
Here's the sending code...
from azure.servicebus import ServiceBusService, Message, Queue
import time

if __name__ == '__main__':

    bus_service = ServiceBusService(
        service_namespace='mytestnamespace',
        shared_access_key_name='RootManageSharedAccessKey',
        shared_access_key_value='blahblahfakekey')

    i = 0

    while True:
        message = f'Message {i}'
        print(f'Sending message... {message}')
        msg = Message(message)
        bus_service.send_queue_message('khqueue1', msg)
        i += 1
        time.sleep(5)

I decided to not use the Service Bus Python SDK and simply go against the Service Bus HTTP REST API. Same problem, same error. Seems to be pointing to some issue between urllib and ACI...perhaps because there are some gateways in front of ACI.
Sending message... Message 0
Traceback (most recent call last):
  File "C:\Python\lib\site-packages\urllib3\connection.py", line 171, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw)
  File "C:\Python\lib\site-packages\urllib3\util\connection.py", line 56, in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
  File "C:\Python\lib\socket.py", line 743, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11002] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 600, in urlopen
    chunked=chunked)
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 343, in _make_request
    self._validate_conn(conn)
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 849, in _validate_conn
    conn.connect()
  File "C:\Python\lib\site-packages\urllib3\connection.py", line 314, in connect
    conn = self._new_conn()
  File "C:\Python\lib\site-packages\urllib3\connection.py", line 180, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.VerifiedHTTPSConnection object at 0x0000016EE7732A90>: Failed to establish a new connection: [Errno 11002] getaddrinfo failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Python\lib\site-packages\requests\adapters.py", line 445, in send
    timeout=timeout
  File "C:\Python\lib\site-packages\urllib3\connectionpool.py", line 638, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "C:\Python\lib\site-packages\urllib3\util\retry.py", line 398, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='somename.servicebus.windows.net', port=443): Max retries exceeded with url: /somequeuename/messages?timeout=60%20HTTP/1.1 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x0000016EE7732A90>: Failed to establish a new connection: [Errno 11002] getaddrinfo failed',))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\solver\http_sender.py", line 45, in <module>
    r = send_message(sb_name, queue_name, sas_name, sas_value, message)
  File "c:\solver\http_sender.py", line 30, in send_message
    r = requests.post(url, headers = headers, data = message)
  File "C:\Python\lib\site-packages\requests\api.py", line 112, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "C:\Python\lib\site-packages\requests\api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "C:\Python\lib\site-packages\requests\sessions.py", line 512, in request
    resp = self.send(prep, **send_kwargs)
  File "C:\Python\lib\site-packages\requests\sessions.py", line 622, in send
    r = adapter.send(request, **kwargs)
  File "C:\Python\lib\site-packages\requests\adapters.py", line 513, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='somename.servicebus.windows.net', port=443): Max retries exceeded with url: /somequeuename/messages?timeout=60%20HTTP/1.1 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x0000016EE7732A90>: Failed to establish a new connection: [Errno 11002] getaddrinfo failed',))

Here's the code I used:
import time
#import urllib
import urllib.parse
import requests
import hmac
import hashlib
import base64
import time

def send_message(sb_name, queue_name, sas_name, sas_value, message):
    """
    Send a message to Azure Service Bus
    queue using the REST API.
    """

    #Generate the SAS token
    uri = urllib.parse.quote_plus('https://{}.servicebus.windows.net/{}' \
                                  .format(sb_name, queue_name))
    sas = sas_value.encode('utf-8')
    expiry = str(int(time.time() + 10000))
    string_to_sign = (uri + '\n' + expiry).encode('utf-8')
    signed_hmac_sha256 = hmac.HMAC(sas, string_to_sign, hashlib.sha256)
    signature = urllib.parse.quote(base64.b64encode(signed_hmac_sha256.digest()))
    sas='SharedAccessSignature sr={}&sig={}&se={}&skn={}'.format(uri, signature, expiry, sas_name)

    #Create and send HTTP POST message
    url = f'https://{sb_name}.servicebus.windows.net/{queue_name}' + '/messages?timeout=60 HTTP/1.1'
    headers={'Authorization': sas, 'Content-Type': 'application/atom+xml;type=entry;charset=utf-8'}
    message=message
    r = requests.post(url, headers = headers, data = message)
    return r

if __name__ == '__main__':

    sb_name='somename'
    queue_name='somequeuename'
    sas_name='RootManageSharedAccessKey'
    sas_value='somefakekey'

    i = 0

    while True:
        message = f'Message {i}'
        print(f'Sending message... {message}')
        r = send_message(sb_name, queue_name, sas_name, sas_value, message)
        print(r.status_code, r.reason)
        i += 1
        time.sleep(5)

Thanks to @lmazuel I was connected to the ACI team. They have confirmed that with Windows containers on ACI, ACI networking is not immediately available when ACI starts the container. I tested putting a sleep timer time.sleep(60) in before connecting to Service Bus and that resolved the issue.


default_query in config and as query param behaving differently.

I have set
rtsp:
  default_query: mp4

in my config. When I call ffprobe rtsp://go2rtc_ip:8554/front_cam I get a 404 and I see an error in the logs 2023-01-31 12:12:21.655335765  12:12:21.655 WRN [rtsp] error="codecs not match: H265,AAC" stream=front_cam
However, when I call ffprobe rtsp://go2rtc_ip:8554/front_cam?mp4 I get the expected ffprobe output.
It seems that the default_query in the config and query parameters are not behaving the same.

You can enable trace logs for streams module and check negotiation process

This is what I see:
# without ?mp4

2023-01-31 13:51:11.170184632  13:51:11.170 DBG [streams] probe producer<EMAIL_ADDRESS>2023-01-31 13:51:11.210199661  13:51:11.210 TRC [streams] producer=0 candidate=0 media="video, sendonly, 96 H265/90000"
2023-01-31 13:51:11.210214042  13:51:11.210 TRC [streams] producer=0 candidate=1 media="audio, sendonly, 97 MPEG4-GENERIC/16000"
2023-01-31 13:51:11.210233242  13:51:11.210 TRC [streams] consumer=0 candidate=1 media="audio, recvonly, 97 MPEG4-GENERIC/16000/1"
2023-01-31 13:51:11.210266162  13:51:11.210 TRC [streams] producer=0 candidate=0 media="video, sendonly, 96 H265/90000"
2023-01-31 13:51:11.210298983  13:51:11.210 TRC [streams] producer=0 candidate=1 media="audio, sendonly, 97 MPEG4-GENERIC/16000"
2023-01-31 13:51:11.210329083  13:51:11.210 DBG [streams] stop producer<EMAIL_ADDRESS>2023-01-31 13:51:11.210475155  13:51:11.210 WRN [rtsp] error="codecs not match: H265,AAC" stream=front_cam

# with ?mp4

2023-01-31 13:54:08.182216696  13:54:08.182 TRC [streams] consumer=0 candidate=0 media="video, recvonly, 0 H264/0, 0 H265/0"
2023-01-31 13:54:08.182245446  13:54:08.182 DBG [streams] probe producer<EMAIL_ADDRESS>2023-01-31 13:54:08.223362405  13:54:08.223 TRC [streams] producer=0 candidate=0 media="video, sendonly, 96 H265/90000"
2023-01-31 13:54:08.223392355  13:54:08.223 TRC [streams] match producer:0:0 => consumer:0:0 codec="96 H265/90000"
2023-01-31 13:54:08.240219952  13:54:08.240 TRC [streams] consumer=0 candidate=1 media="audio, recvonly, 0 MPEG4-GENERIC/0"
2023-01-31 13:54:08.240223592  13:54:08.240 TRC [streams] producer=0 candidate=0 media="video, sendonly, 96 H265/90000"
2023-01-31 13:54:08.240239242  13:54:08.240 TRC [streams] producer=0 candidate=1 media="audio, sendonly, 97 MPEG4-GENERIC/16000"
2023-01-31 13:54:08.240240322  13:54:08.240 TRC [streams] match producer:0:1 => consumer:0:1 codec="97 MPEG4-GENERIC/16000"

The api shows this:
{"host":"<IP_ADDRESS>:1984","rtsp":{"listen":":8554","DefaultQuery":"mp4"},"version":"1.1.0"}

You have very strange candidate in first case - 96 H264/90000. It shouldn't look like that. I'll think how it can be so.

OK. This is a bug. Will fix it in next release

You can check latest master version

Fixed in https://github.com/AlexxIT/go2rtc/commit/08c2174e94715156cb0a60d56dc480bedb28927a


Flush tilemap physics on tree notifications

Fixes #83291. As mentioned in that issue, the relevant problem (collision bugginess when reparenting TileMaps to SubViewports) #81070. I've tried researching the cause of this regression and why it didn't occur before that commit, but I'm not too sure honestly. So this fix doesn't directly tackle the issue of why this needs to be done at all, especially why this only occurs for SubViewports, but it definitely works and I think it's elegant enough not to cause any other issues.

CC @groud

Hmm, I've just checked. I am not sure this is the right fix. Technically, the re-creation of all physics shapes should already happen thanks to _physics_was_cleaned_up being true.
I suspect the issue would be due to RID space = tile_map_node->get_world_2d()->get_space();. As in a subviewport, the expected space might change.
I think the solution would be to instead update _physics_notify_tilemap_change to update the bodies space on DIRTY_FLAGS_TILE_MAP_IN_TREE change or something. That would avoid recreating all the physics shapes.

Hmm, I've just checked. I am not sure this is the right fix. Technically, the re-creation of all physics shapes should already happen thanks to _physics_was_cleaned_up being true.
I suspect the issue would be due to RID space = tile_map_node->get_world_2d()->get_space();. As in a subviewport, the expected space might change.
I think the solution would be to instead update _physics_notify_tilemap_change to update the bodies space on DIRTY_FLAGS_TILE_MAP_IN_TREE change or something. That would avoid recreating all the physics shapes.

Yeah, I figured this wasn't the optimal solution - what you say about the space changing makes more sense. I'll replace the commit.

I think it's the right solution, but I kind of dislike the refactor you added with the other notifications. I understand why you would like to change it that way but it makes the code a lot harder to read IMO.
Animatable collisions is kind of an easy thing to mess up (it basically does a complex thing, like reverting transforms changes in _process then re-applying them later on). So I'd rather keep it easier to read, even it it implies a few more lines.

Superseded by #84968, which is your fix with the additional changes requested (speed tracked to include it in RC1 today).


Update instructions

The following section needs to be updated for the recent version of Blazor Server:
https://learn.microsoft.com/en-us/power-apps/developer/data-platform/webapi/quick-start-blazor-server-app#prepare-the-app-to-use-azure-ad-tokens

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4db187af-a897-e8df-f587-4b9763e0bf27
Version Independent ID: b7446e9a-88eb-f6de-5d11-3f2e0489249a
Content: Quickstart: Blazor Server Web API sample (C#) (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/webapi/quick-start-blazor-server-app.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @JeremyLikness
Microsoft Alias: jeliknes

Thanks for your comment, @pvanroos. This issue has been assigned to the doc author for review.

@pvanroos
Thanks for your feedback.
Can you be more specific about what needs to change?
We also accept pull requests if you want to apply the changes you feel are needed.

I've updated the Quickstart instructions with new design based on VS 2022 patterns with .NET 7.0


DSERV-112-uniprot

Some schema is not working under new version of biocypher: open chromatic region and variant.
Also auto generated API is not working properly using new version of biocypher. I tried all the endpoints. Query by id is working. Filter by other properties will give empty json object with 200 status code… Query parents or children give you INTERNAL_SERVER_ERROR…

created a new branch for this ticket. Close this PR.


Add Player Potential to output and Add Year Keys

Hi,
I've taken the player potential value via redefinition of the mapping as stated in the issue https://github.com/Big-Data-FC/scraper/issues/5, and added more years to YEAR_KEYS.
Hope this helps!

Great, thank you 👍🏼


[Bug] Can't render ScaleOverlayTool

Describe the Bug
The ScaleOverlayTool annotation object is successfully added to the annotation manager at its first call of _init() function in which addAnnotation() is called, however, as of second call of it, addAnnotation() is not called. That's because viewportsWithAnnotations that stores which viewports have an annotation prevents _init() from calling addAnnotation(), but there is no logic removes viewports from viewportsWithAnnotations array. So even after removing annotation with something like annotation.state.removeAllAnnotations(), you cannot add ScaleOverlay annotation again, which results in fail of rendering scale overlay.
Steps to Reproduce

Enable ScaleOverlayTool (this will call _init())
removeAllAnnotations()
Enable ScaleOverlayTool again
Uncaught TypeError from ScaleOverlayTool.renderAnnotation()

The current behavior
Can't render ScaleOverlayTool
The expected behavior
Render ScaleOverlayTool
OS
Windows 10
Node version
20.11.1
Browser
Chrome 128.0.6613.85 64bit

This is fixed i think


It doesn't seems to work with pdb in terminal?

非常的Amazing as it is, i don't think it can work in a terminal like pdb cuz it is a package...
Personally, I won't be happy if I had to code so much watch and unwatch and debug over and over and over..

Unfortunaly that's how watchpoints works now. It probably won't work with pdb because there's some black magic behind it to get the variable you are trying to trace, which requires file access. More importantly, it uses settrace which conflicts with pdb. So even I can understand your frustration, there's nothing I can do to make you happy at this point.

Unfortunaly that's how watchpoints works now. It probably won't work with pdb because there's some black magic behind it to get the variable you are trying to trace, which requires file access. More importantly, it uses settrace which conflicts with pdb. So even I can understand your frustration, there's nothing I can do to make you happy at this point.

🤣pitty for pdb not having a watch like gdb.


Build window conflicts with gitignore

Hey,
I just spotted it today, that Build folder from MixedRealityToolkit won't be recognized in git if you generate by default a .gitignore for Unity:

I had to remove [Bb]uild to fix this issue.
I understand, that's not a bug per se and it's not your fault, but it would be nice if new users could avoid it in the future :)

Thanks for the report


Adds an smtp test

Ticket: 4948
Needs https://github.com/OISF/suricata/pull/7050 to pass

Needs OISF/suricata#7050 to pass

Q: Why does it pass on all branches without it being merged then? :thinking:

It should fail if you compile with --enable-debug-validation

Merged. Thanks!


[MRG] Pybids for meg

closes https://github.com/INCF/pybids/issues/227
just looking into adding new entities + test for MEG data
still work in progress
cc @teonbrooks @adelavega @tyarkoni

Cool. BTW don't worry about Appveyor

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   74.59%   74.59%
=======================================
  Files          23       23
  Lines        2204     2204
  Branches      525      525
=======================================
  Hits         1644     1644
  Misses        409      409
  Partials      151      151

Flag
Coverage Δ

#unittests
74.59% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fdf09a...b94bf5b. Read the comment docs.

Looks good to me, but maybe cut back on the files in the test dataset, and add some _proc files so you can test the new entity that was added to bids.json.
@tyarkoni ?

okay, done!

LGTM!

Looks good, but can you fix the merge conflicts to reflect the renaming of grabbids to layout? Thanks!

Rebasing done!

Thanks! Will merge once tests pass.

Congrats @jasmainak on your first productive hackathon ;)

Finally all those hours of socializing has been vindicated :grin:


Write Dockerfile that installs node & slackit

slackit already has a Dockerfile but it looks like it has a few issues. It might be easier to have a quick Dockerfile that installs node and then installs slackit, before running it.

Once this is up, we can continue with https://github.com/kingsreach/kingsreach-online/issues/23

Can't believe I accidentally called it slackit everywhere. Such a mungbeen 😧.

Done.


go mod, network-attachment-definition-client: Bump to v1.6.0

What this PR does
Allows us to use the new IPAMClaimReference [1]
which is required for the new secondary networks IPAM feature.
Feature design https://github.com/openshift/enhancements/pull/1456
[1] https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/pull/60

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/test pull-kubevirt-e2e-k8s-1.29-sig-network

makes sense to me.
I hope there aren't issues w/ the kube-api bump ...

all seems fine, and using it with the poc locally looks good, nice job
undrafting

never saw this
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11321/pull-kubevirt-unit-test-arm64/1760329445371023360
(it passed today before)
not sure it is related to the PR, keeping it here for reference
/test pull-kubevirt-unit-test-arm64

Creating soon a PR that will include also the usage, so lets close this for now


updating species.josn with ITREECODE and noting when it is approx. Al…

…so fixed issue #65 and #56.

I gave it a quick scan (after merging in develop), built it locally, and launched ok. I think my device credentials are pointing to an obsolete server instance, and I don't have the patience for that dance right now. I will go ahead and merge.


UHF-9635: Custom Sentry traces_sampler callback

Codecov Report
Attention: Patch coverage is 22.22222% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 81.47%. Comparing base (a4a0aaf) to head (ab8b375).

Files
Patch %
Lines

.../EventSubscriber/SentryTracesSamplerSubscriber.php
22.22%
14 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #163      +/-   ##
============================================
- Coverage     82.04%   81.47%   -0.57%
- Complexity      554      560       +6
============================================
  Files            75       76       +1
  Lines          1888     1906      +18
============================================
+ Hits           1549     1553       +4
- Misses          339      353      +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


workaround some pandas 1.4.0 database pain

OK, awaiting updated pyIEM to be available from conda-forge.


badge-maker 3.3.1 release

Having had this running in production for a bit, we've had no reported issues. Once we merge this I'll create a tag and push the package to NPM.

Messages

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS against 0799771ffeb0e0e9acb2753cd975c34f060fb54d


Armed mode can be changed whilst alarm is armed

Alarmo Version
v1.9.9
HA Version
2023.5.3
Bug description
With the system armed in "Away" mode, clicking on the shield on the Alarmo card allows you to change it to "Home" mode without first disarming (with a code) the away mode. The reverse is also true.
I would expect it to request a code before changing arm modes.
Armed mode cannot be changed when system is in pending or triggered state.
Steps to reproduce
With the system armed in "away" mode, click on the shield in the Alarmo card. Change the mode from "Away" to "Home" and the alarm will start the exit delay for the "Home" mode.
Relevant log output
No response

This is a false bug report.

With the system armed in "Away" mode, clicking on the shield on the Alarmo card allows you to change it to "Home" mode without first disarming (with a code) the away mode. The reverse is also true.

Yes, the ability to switch between arm modes is considered a feature.

I would expect it to request a code before changing arm modes.

I cannot argue your expectations, but this is not how it works.
Alarmo will only require a code when either arming or switching arm modes if you have set this option:

Armed mode cannot be changed when system is in pending or triggered state.

Correct, in this case you need to disarm the alarm first. This is also illustrated in the flow chart in the documentation.

Thanks for getting back to me so quickly. I'll see if I can do a workaround for not needing a code to arm, but need one to change the alarm state.


New package: CRNHexagon v0.1.0

Registering package: CRNHexagon
Repository: https://github.com/matthiashimmelmann/CRNHexagon
Created by: @matthiashimmelmann
Version: v0.1.0
Commit: 0140369a7e8388354f4355b18824df4e3d60b8b3
Reviewed by: @matthiashimmelmann
Reference: https://github.com/matthiashimmelmann/CRNHexagon/commit/0140369a7e8388354f4355b18824df4e3d60b8b3#commitcomment-146967267

block automerge

Closing in favor of https://github.com/JuliaRegistries/General/pull/115546


Use environment variables for testing

This adds the EnvironmentVariables to the Test Config and initializes the BlockfrostService with BFCLI_API_KEY and BFCLI_NETWORK variables

this should work once out of the PR


@subcommand('name') decorators

Instead of having a huge execute() with essentially a python switch, I'd prefer to have a  decorator that maps a function to a sub function.

The initial commit is here: https://github.com/android-dtf/dtf/commit/0f1fafc00c62933547dc337a7015e70c8b59c94d
This includes a number of tests too. Next, I'll do the automatic usage() generation.

via: https://github.com/android-dtf/dtf/commit/0f1fafc00c62933547dc337a7015e70c8b59c94d


STEVAL-MKI207V1 instructions for connections

A question about the intructions found here: https://github.com/jerabaul29/OpenMetBuoy-v2021a/blob/main/instrument_hardware/ST_eval_instructions.md .
Is it correct that we should be connecting the red qwiic cable (3.3V) to pin 4 for SCX and pin 5 for SDX?
Reason for confusion is the following:
From the diagram found online (https://www.st.com/en/evaluation-tools/steval-mki207v1.html), it seems like SCX is connected to two pins (P4 and P24), but the connection to P24 had a resistor that says DNM, which we assume means 'do not mount'. So we concluded that the red cable should go to P4 for SCX. Same holds for SDX (with P5 and P17 as connected pins), where P17 had a DNM resistor, so the red cable for SDX should go to P5.
Might be nice for future users to add the schematic diagram of STEVAL-MKI207V1 as a link on 'ST_eval_instructions.md' page :)

Great to see you go in such details to check :) . Many thanks for raising this issue here :) .
TLDR: yes, I think you are right, and thanks for pointing this out :) .
cc:ing @gauteh here :) (Gaute should get credits for finding that the chip was available in this way, and helping me find out how to correctly wire it :) ).
A side note: @gauteh had looked in details at the datasheet for the ISM330DHCX itself for knowing which pins to connect or not, see the datasheet available at: https://www.st.com/en/mems-and-sensors/ism330dhcx.html section 3.1:)
Regarding your question: I think (I do not have the chip under the hand to double check; if you and / or @gauteh can confirm it would be perfect :) ) that you are right and that the pins to use are the pins connected to R3 and R5, ie pins P4 and P5, ie the SCx and SDx on the side of VDD and VDDIO rather than on the other side. I agree that it looks like the pins SCx and SDx on the other side of the breakout, i.e. pins P17 and P24, are only "connected" through a non-mounted resistor, ie not connected and not active. This is indeed very confusing, and I will have to update the instructions, to make it clear that the pins on the side of VDD and VDDIO should be used, and NOT the pins on the other side, when connecting SCx and SDx.
I was actually not really aware of this, went a bit fast and was a bit sloppy myself, and I just connected to some "randomly chosen" SCx and SDx on my breakouts... It turns out that, since I am "luckily lazy", I connected the SCx and SDx corresponding to pins P4 and P4 to +3.3V, since these are the 2 close to VDD and VDDIO, so I could cut a shorter jumper ^^ . This is actually (barely) visible on the picture https://github.com/jerabaul29/OpenMetBuoy-v2021a/blob/main/instrument_hardware/jpg/STEval_PCB.jpg . If you zoom there you can see that I did let the SCx and SDx on the SDA/SCL side unconnected, and I connected instead the SCx and SDx on the VDD and VDDIO side. Pure luck, but need some now and then ^^ :) .
As a side note:

I tested relatively extensively my setup corresponding to the description above, and it seems to work very well
I had initially not read the datasheet as I should have, and not connected SCx and SDx at all, and things were working fine if I remember well (though as @gauteh had pointed out then, floating inputs that should be clamped was not a good idea)

Having an extra pair of eyes on this would be great :) . So if you can read this being quite critical / not "trusting", and double check and confirm, would be great :) .
Let us confirm, keep the issue open, and I will update the readme :) .

@gauteh  I thought so, that it does not matter which SCx and which SDx was connected as long as one of each was connected to 3.3V, but looks like as @CatherineTaelman points out from the STeval datasheet and how the PCB looks like that the SCx and SDx on the side of the SCL / SDA pins are just not connected to the chip in the center at all - while the SCx and SDx on the side of VDD and VDDIO do are connected to the chip in the center.

Would need a breakout under my hand (all mines are mounted in the boxes that are now sealed and glued) and a multimeter to check, though :) .

Thanks for double-checking and confirming! We also noticed indeed that the SCx and SDx on the side of the SCL / SDA pins are not connected at all to the chip. So we are going for the connections to P4 and P5 :)

Perfect, then this is confirmed, and I will update the md instructions file and let you know :) .

Great, that is a very important bit of information. Good catch!

Many thanks again, updated the readme here: https://github.com/jerabaul29/OpenMetBuoy-v2021a/commit/c627122b078af8c59dee82092ee670f9348295b6 .
Btw @gauteh , is it ok if I add your schematic (see under) to the md file (with credits of course :) ):

Of course 😊
ons. 9. mar. 2022, 15:59 skrev JR @.***>:

Many thanks again, updated the readme here: c627122
https://github.com/jerabaul29/OpenMetBuoy-v2021a/commit/c627122b078af8c59dee82092ee670f9348295b6
.
Btw @gauteh https://github.com/gauteh , is it ok if I add your
schematic (see under) to the md file (with credits of course :) ):
[image: ISM330DHCX_wireup]
https://user-images.githubusercontent.com/8382834/157467679-2f0ed74d-e853-4507-a3b1-9c29757c4cea.png
—
Reply to this email directly, view it on GitHub
https://github.com/jerabaul29/OpenMetBuoy-v2021a/issues/25#issuecomment-1063009157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAN365MJ7OH7S7TVOZCPBTU7C4FJANCNFSM5QJQGNNA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Many thanks again, updated the readme here: c627122 .
Btw @gauteh , is it ok if I add your schematic (see under) to the md file (with credits of course :) ):

That schematic is really nice for the readme! :)

Dear @jerabaul29
Sorry, I have really lagging on this, and now I need to move fast for the AWI prep.
May I ask about the resistor R1? So have you guys had a bit more experience now with this chip and the resistor R1 is not necessary?


Error during initialization on Windows 8.1 Pro via Boot Camp with .NET 4.6.1

A co-worker of mine is trying to run an app that is using Ryder to override internal implementation details of WPF's TreeView class. This application works fine on a number of other systems, but on this particular system, it encounters the following error during initialization:
Exception Info: System.IO.FileNotFoundException
  at Ryder.Helpers.AllowRW(IntPtr)
  at Ryder.MethodRedirection..ctor(System.Reflection.MethodBase, System.Reflection.MethodBase, Boolean)
  at Ryder.Redirection.RedirectCore(System.Reflection.MethodBase, System.Reflection.MethodBase, Boolean)

This workstation is a Mac running Windows 8.1 Pro via Boot Camp, if that makes any difference, and it has .NET 4.6.1 installed.
I had a go at trying to figure out what could cause the problem, but all I came up with, looking at the Helpers.cs code, is that RuntimeInformation.IsOSPlatform(OSPlatform.Windows) must be returning false. I created a test application to call this particular method from the System.Runtime.InteropServices.RuntimeInformation package, and it did not return false for me. I have verified that it is the same version of System.Runtime.InteropServices.RuntimeInformation.dll in both cases.
What can I check next?

I'll look into it. So if I recap:

There is a file IO exception in AllowRW on Windows, running itself on Boot Camp.
IsOSPlatform(OSPlatform.Windows)returnstrue` on the system. Also, is the system 64 or 32 bits? Unfortunately I haven't had the chance to test Ryder on the latter.

If so, the exception could be caused when trying to load kernel32.dll for interop. Do you have more details on the exception? It is usually followed by a message.

I suppose we should try setting SetLastError to true before anything, in case there is indeed a mechanism that throws when it is not the case. Another possibility for FileNotFoundException to be thrown is when an assembly cannot be found, which might be the case of System.[..].RuntimeInformation, can you try using it at some other point in the program to see if it can be loaded?


disable analysis on dashboards

Seems that clicking on the map opens an 'invisible' pop-up. You can still see the 'x' to close the interaction ands the white boarder.

Good catch, have fixed this issue in the last commit


Error on Catalina: relativeLevel must be between…

On Catalina when I try to run the plugin I get the following error:

pretty sure this is the same as https://github.com/skpm/sketch-module-web-view/issues/109


Automated cherry pick of #8087: huawei snapshot delete fix

Cherry pick of #8087 on release/3.4.
#8087: huawei snapshot delete fix

/lgtm
/approve


How do I launch demo app?

Please, provide instructions how to launch demo app

Create a virtual environment.
Clone the repository to your local machine
run pip install -r requirements.txt.
In your terminal: python manage.py runserver

Thank you! Unfortunately, the demo app does not work.
(bs4) ...\django-bootstrap4> conda list
# packages in environment at C:\Miniconda3\envs\bs4:
#
# Name                    Version                   Build  Channel
alabaster                 0.7.12                     py_0    conda-forge
babel                     2.7.0                      py_0    conda-forge
beautifulsoup4            4.8.0                    py36_0    conda-forge
certifi                   2019.6.16                py36_1    conda-forge
django                    2.2.3                    py36_0    conda-forge
docutils                  0.14                  py36_1001    conda-forge
imagesize                 1.1.0                      py_0    conda-forge
jinja2                    2.10.1                     py_0    conda-forge
markupsafe                1.0                      py36_0    conda-forge
packaging                 19.0                       py_0    conda-forge
pip                       19.1.1                   py36_0    conda-forge
pygments                  2.4.2                      py_0    conda-forge
pyparsing                 2.4.1                      py_0    conda-forge
python                    3.6.7             he025d50_1005    conda-forge
pytz                      2019.1                     py_0    conda-forge
requests                  2.13.0                   py36_0    conda-forge
setuptools                41.0.1                   py36_0    conda-forge
six                       1.12.0                py36_1000    conda-forge
snowballstemmer           1.9.0                      py_0    conda-forge
soupsieve                 1.9.2                    py36_0    conda-forge
sphinx                    2.1.2                      py_0    conda-forge
sphinx_rtd_theme          0.4.3                      py_0    conda-forge
sphinxcontrib-applehelp   1.0.1                      py_0    conda-forge
sphinxcontrib-devhelp     1.0.1                      py_0    conda-forge
sphinxcontrib-htmlhelp    1.0.2                      py_0    conda-forge
sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
sphinxcontrib-qthelp      1.0.2                      py_0    conda-forge
sphinxcontrib-serializinghtml 1.1.1                      py_0    conda-forge
sqlparse                  0.3.0                      py_0    conda-forge
wheel                     0.33.4                   py36_0    conda-forge
wincertstore              0.2                   py36_1002    conda-forge

(bs4) ...\django-bootstrap4> python manage.py runserver
Watching for file changes with StatReloader
Exception in thread django-main-thread:
Traceback (most recent call last):
  File "C:\Miniconda3\envs\bs4\lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "C:\Miniconda3\envs\bs4\lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\utils\autoreload.py", line 54, in wrapper
    fn(*args, **kwargs)
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\core\management\commands\runserver.py", line 109, in inner_run
    autoreload.raise_last_exception()
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\utils\autoreload.py", line 77, in raise_last_exception
    raise _exception[1]
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\core\management\__init__.py", line 337, in execute
    autoreload.check_errors(django.setup)()
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\utils\autoreload.py", line 54, in wrapper
    fn(*args, **kwargs)
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\apps\registry.py", line 122, in populate
    app_config.ready()
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\admin\apps.py", line 24, in ready
    self.module.autodiscover()
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\admin\__init__.py", line 26, in autodiscover
    autodiscover_modules('admin', register_to=site)
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\utils\module_loading.py", line 47, in autodiscover_modules
    import_module('%s.%s' % (app_config.name, module_to_search))
  File "C:\Miniconda3\envs\bs4\lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\admin\__init__.py", line 5, in <module>
    from django.contrib.gis.admin.options import GeoModelAdmin, OSMGeoAdmin
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\admin\options.py", line 2, in <module>
    from django.contrib.gis.admin.widgets import OpenLayersWidget
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\admin\widgets.py", line 3, in <module>
    from django.contrib.gis.gdal import GDALException
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\gdal\__init__.py", line 28, in <module>
    from django.contrib.gis.gdal.datasource import DataSource
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\gdal\datasource.py", line 39, in <module>
    from django.contrib.gis.gdal.driver import Driver
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\gdal\driver.py", line 5, in <module>
    from django.contrib.gis.gdal.prototypes import ds as vcapi, raster as rcapi
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\gdal\prototypes\ds.py", line 9, in <module>
    from django.contrib.gis.gdal.libgdal import GDAL_VERSION, lgdal
  File "C:\Miniconda3\envs\bs4\lib\site-packages\django\contrib\gis\gdal\libgdal.py", line 48, in <module>
    lgdal = CDLL(lib_path)
  File "C:\Miniconda3\envs\bs4\lib\ctypes\__init__.py", line 348, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] Module not found

This environment was created using conda env create -f=requirements.txt -n bs4 like 15 minutes ago

You could try this or this solutions and let me know how it goes

I just thought it was easy to launch the demo following the above steps. Unfortunately, I got problem:
django.core.exceptions.ImproperlyConfigured: Could not find the GDAL library (tried "gdal", "GDAL", "gdal2.2.0", "gdal2.1.0", "gdal2.0.0", "gdal1.11.0", "gdal1.10.0", "gdal1.9.0"). Is GDAL
installed? If it is, try setting GDAL_LIBRARY_PATH in your settings.
Any idea about this issue? Run on Ubuntu18.04, py36, django2.1.
Insetting file there is ""django.contrib.gis"", why do we need it in such a bootstrap app? GDAL seems related to Geo package.

I could guess that it is needed to style the layout of the page the map was rendered on if anyone who was using the django-bootstrap4 as an eternal package to reduce the load of writing everything.
Have you tried a sudo apt-get install gdal-bin ?

Hi all, the gis part is for the demo app. I can imagine it's not for everybody, might be good to make that optional.

The gis requirements for the demo (now: example) app were removed in 207ab33427aa7ebb64334b3020cd509c8dd4faa9. Thanks for reporting this.


Refactor to use message flow

Please wait before merging.  My gut feeling is that this should not have passed.

@bnaul It looks like the latest version of xarray broke API?

Yeah, that's what https://github.com/mltsp/mltsp/pull/137 was for... did
you rebase after that was merged?
On Wed, Jan 27, 2016, 8:31 AM Stefan van der Walt<EMAIL_ADDRESS>wrote:

@bnaul https://github.com/bnaul It looks like the latest version of
xarray broke API?
—
Reply to this email directly or view it on GitHub
https://github.com/mltsp/mltsp/pull/134#issuecomment-175727577.

I thought I did, will try again.

This failed once because of that weird transient RethinkDB failure, but I re-built and it looks to have a real error as well...

Thanks, working on it.

Could you also update the "Starting the web app" section of install.md for the new front-end steps?


fix references to rust-analyzer-build-deps

Description of changes
Clean up some fallout from #221878 which currently prevents running ./pkgs/development/node-packages/generate.sh
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This was covered as part of #226095


Standard Shopware error handling and non cancelable payment results in the previous payment page being opened on Mollie checkout

If I use the standard Shopware default error handling and during payment close the window, change the payment and restart the payment later on (e.g. order history), then the previous payment method is still pre-selected because the existing payment is not changed or canceled. However, changing the payment method on a payment with a selected payment method is not possible either.
Maybe canceling the whole order and re-creating it instead would work?
Not sure why that payment is not cancelable but for me in test mode I never found a cancelable payment which is kind of weird though.

After checking issues in the mollie php api client apparently most payments now are non cancelable. Therefore, the only solution I can think of in this scenario is to create a new Mollie order, if there is an open payment and the Shopware default error handling is used and let the previous order and payment expire. It isn't perfect but better than using the wrong payment.
And I would also forward such scenarios to Mollie, there really shouldn't be a reason for the payment not being cancelable, especially as the user themself can cancel the payment. I admit it is an edge case but with headless setups e.g. apps that use Shopware headless, this can be a real scenario as the external payment window can easily be closed.

So to summarize the steps:

Login in Shopware frontend.
Set Mollie plugin to use "Standard failed payment workflow"
Start payment process for payment method A.
Close browser.
Login in Shopware again.
Go to order history, change the payment method to method B and finish payment.

The payment method used by mollie will now be still method A, instead of B.  I admit it is and edge case but it is not impossible. Especially with headless / API approaches in apps.

Hi again
thanks for this
perfect, that is also another internal ticket that I have as TODO :)
it should of course change
so what I once tested is, that the webhook should change the payment method (but as mentioned, I have to double check this).
did you test with or without webhooks?
so maybe its already being changed,
but anyway...i have to double check it too :)
great job with all this
thanks a ton

Hi there
I'm currently planning new features
thank you for your description
i think that should do for now
I'm digging deeper when I start this ticket :)

@AndreasA
i tried to reproduce the error in order to fix the bug, but it seems like it was fixed by another ticket.
can you try it again? i assume there is no issue anymore. if everything works as expected we can close the ticket

Hi @BlackScorp I am not sure when I will find the time to retest this.
If you think it is fixed, I am fine with closing the issue and if I have time and the issue still exists I will create a new issue and reference this one.


The number of ipv6 addresses is not displayed properly

The number of ipv6 addresses is not displayed properly

That number is just soooo big..
I don't see the added value to display that very long number. This representation is the scientific notation of long numbers


update typings

I was getting TS errors as JQuery is undefined
node_modules/ember-cli-page-object/types/index.d.ts:64:87 - error TS2304: Cannot find name 'JQuery'.

64   function findElement(pageObject: Component, scope?: string, options?: FindOptions): JQuery;
                                                                                ~~~~~~

node_modules/ember-cli-page-object/types/index.d.ts:65:97 - error TS2304: Cannot find name 'JQuery'.

65   function findElementWithAssert(pageObject: Component, scope?: string, options?: FindOptions): JQuery;
                                                                                ~~~~~~

node_modules/ember-cli-page-object/types/index.d.ts:163:40 - error TS2304: Cannot find name 'JQuery'.

163     testContainer?: string|HTMLElement|JQuery;
                                           ~~~~~~

Typechecking failed

Stack Trace and Error Report: /var/folders/3s/0wqmw2rj7vl5yknprr76j4h80000gn/T/error.dump.b425730c96d5c6bd30e5f7bdb6b05995.log
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error: Typechecking failed
    at Class.postBuild (/Users/artemhurzhii/Programming/Work/uplisting/uplisting-frontend/node_modules/ember-cli-typescript/js/addon.js:73:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Promise.all (index 0)
    at async Builder.build (/Users/artemhurzhii/Programming/Work/uplisting/uplisting-frontend/node_modules/ember-cli/lib/models/builder.js:209:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Thanks. Just released it as v1.17.11.


Encode paths using ERB::Util.url_encode

URI.encode is deprecated.
Use ERB::Util.url_encode instead.
Fixes https://github.com/avadev/AvaTax-REST-V2-Ruby-SDK/issues/90

This needs to be merged, right now it's impossible to use the avatax gem with Ruby 3.

Bump on this. Is there anything we can do to help get this in?

Hi avadev folks. Is there anything we can do to help get this merged and a new release published? It'd really help us out and we'd really appreciate it.

@svc-developer Is there a plan on merging #108? This is flooding our CI with warnings.

Closing this request as fix is merged  in pull request : https://github.com/avadev/AvaTax-REST-V2-Ruby-SDK/pull/111


[#215] Optionally specify language when encoding texts

Motivation: see #215
Implementation:

Add the language argument to each abstract task and each evaluator, and pass to the model, if its encode method has the language argument.
For cross-lingual tasks, split the language code in two.
Include https://github.com/embeddings-benchmark/mteb/pull/221.
Fix task name ScalaNnClassification (it used to be ScalaNbClassification, copy-pasted from the previous task).
For ScalaNbClassification and ScalaNnClassification, remove redundant language codes, because they are monolingual: nn and nb are just special cases of no.
Update the readme with a few nits about non-English task.

Some issues spotted

A few tasks are not marked as multilingual or crosslingual, but do contain multiple languages (BornholmBitextMining, NordicLangClassification, ScalaNbClassification, ScalaNnClassification). The last two seem to be monolingual, but are marked with two codes. BornholmBitextMining contains Danish and its Bornholm dialect; both will be interpreted as Danish by the model.
For NordicLangClassification; the first language code (da) will be passed to the model for the texts in all languages. Using the same code for all languages makes sense (because we want to classify the languages without leaking the answer), but the choice of the code is arbitrary.
Polish retrieval tasks still don't work: https://github.com/embeddings-benchmark/mteb/issues/219

Testing
Relying on the automatic tests.
Also, succesfully ran the evaluation with SONAR in https://github.com/embeddings-benchmark/mteb/issues/139.

Interesting, didn't realize it was that complex 😅
For BEIR, we need to remove the integration anyways, so we can also leave it for later (cc @tomaarsen)

Actually, it is even more complex :(
Because now I am trying to evaluate SONAR with all the languages, and many language codes are ambiguous: does "Kurdish" refer to Northern, Central or Southern Kurdish? Does "Norvegian" refer Bokmal or Nynorsk? Does "Albanian" refer to Tosk or Gheg dialects?
For a model where the output depends on the exact language code, it is kind of nightmare.
Maybe, for the tasks added in the future, it would make sense to start indicating more specific language codes (e.g. ISO 639-3 code for the language + ISO 15924  code for the script, like "eng_Latn"), to make the set of languages slightly less ambiguous.

Actually, it is even more complex :( Because now I am trying to evaluate SONAR with all the languages, and many language codes are ambiguous: does "Kurdish" refer to Northern, Central or Southern Kurdish? Does "Norvegian" refer Bokmal or Nynorsk? Does "Albanian" refer to Tosk or Gheg dialects? For a model where the output depends on the exact language code, it is kind of nightmare. Maybe, for the tasks added in the future, it would make sense to start indicating more specific language codes (e.g. ISO 639-3 code for the language + ISO 15924 code for the script, like "eng_Latn"), to make the set of languages slightly less ambiguous.

Yes I agree! Ideally we also revamp it for all existing datasets. Though I guess for some datasets, they may not even tell us what exact dialect it is.

I think this problem can also be solved on the user side without changing MTEB by just iterating through the languages one by one (i.e. recreating MTEB(...) but change task_langs) 🤔

It would be fine for me to do so, if MTEB was writing the results in files named like {TaskName}_{Language}.json.
Currently, if I recreate MTEB for each language, I have also to care about creating a new output directory for each language, and then merging all the per-language results. To me, it doesn't look clean either.
And anyway, this solution wouldn't work for bilingual tasks, such as bitext mining.

I think this problem can also be solved on the user side without changing MTEB by just iterating through the languages one by one (i.e. recreating MTEB(...) but change task_langs) 🤔

It would be fine for me to do so, if MTEB was writing the results in files named like {TaskName}_{Language}.json. Currently, if I recreate MTEB for each language, I have also to care about creating a new output directory for each language, and then merging all the per-language results. To me, it doesn't look clean either.
And anyway, this solution wouldn't work for bilingual tasks, such as bitext mining.

Ah yeah good point re: bilingual, you're right

I think this is really cool & we can probably merge it --- I'm just afraid if it adds to much complexity to the code for a feature that's very specific to few models?

Do you have thoughts on this @KennethEnevoldsen? This was my main concern 🤔

As I understand it (and feel free to correct me if I am wrong) it only adds the optional language input during the encode? I think it is a reasonable change, though I would simplify it by just passing in either the task metadata (which contains the language as well). This should also allow prompt-based models to create prompts based on the task).

@KennethEnevoldsen Out of the box, the task metadata contains information about the set of the languages involved into the current task, but not the language of the specific text which is currently being encoded.
Anyway, I am willing to modify this PR pass to the model something else alongside with the language tag, if you suggest a convenient way to package it.

@avidale Ahh yeah I see especially for the bitext tasks.
Hmm right so I imagine the ideal encode function would look something like:
def encode(
    sentences: list[str],
    encode_type: Literal["queries", "corpus"] | None # currently formalized in encode_corpus and encode_queries which I think is fine
    language: list[str] | None, # e.g. required for bitext mining. None can e.g. solve cases where language is unknown (e.g. lang clf)
    task: str # or some kind of metadata object - this allow e.g. embedding differently depending on clustering, retrieval etc.. It also allows for prompt-based encoding.
    )

@avidale what are your thoughts here?
@Muennighoff any reason to prefer encode_corpus and encode_queries over passing it as an argument?

@avidale Ahh yeah I see especially for the bitext tasks.
Hmm right so I imagine the ideal encode function would look something like:
def encode(
    sentences: list[str],
    encode_type: Literal["queries", "corpus"] | None # currently formalized in encode_corpus and encode_queries which I think is fine
    language: list[str] | None, # e.g. required for bitext mining. None can e.g. solve cases where language is unknown (e.g. lang clf)
    task: str # or some kind of metadata object - this allow e.g. embedding differently depending on clustering, retrieval etc.. It also allows for prompt-based encoding.
    )

@avidale what are your thoughts here? @Muennighoff any reason to prefer encode_corpus and encode_queries over passing it as an argument?

I don't mind removing encode_corpus & encode_queries & passing it as an argument though it will break backward compat

@Muennighoff when we switch from MTEB to MMTEB might be the best time to break backward compatibility otherwise I am also fine with leaving it as is.

@Muennighoff when we switch from MTEB to MMTEB might be the best time to break backward compatibility otherwise I am also fine with leaving it as is.

I'm also fine either way ---- I think the switch from MTEB to MMTEB would not break backward compact though no?

I think the switch from MTEB to MMTEB would not break backward compat though no?

No you are right. It would just seem like a fitting time to do so if we think it streamlines the encode method for future uses.

Will close this PR as it seems to have gone stale.


Error: Cannot find module '../build/Release/bson'

.715Z - error: (node:13240) DeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes instead. { Error: Cannot find module '../build/Release/bson'     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)     at Function.Module._load (internal/modules/cjs/loader.js:507:25)     at Module.require (internal/modules/cjs/loader.js:637:17)     at require (internal/modules/cjs/helpers.js:20:18)     at Object.<anonymous> (/home/gxc/Desktop/continue-integration/strider-continue/node_modules/strider-webhooks/node_modules/bson/ext/index.js:15:10)     at Module._compile (internal/modules/cjs/loader.js:689:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)     at Module.load (internal/modules/cjs/loader.js:599:32)     at tryModuleLoad (internal/modules/cjs/loader.js:538:12)     at Function.Module._load (internal/modules/cjs/loader.js:530:3)     at Module.require (internal/modules/cjs/loader.js:637:17)     at require (internal/modules/cjs/helpers.js:20:18)     at Object.<anonymous> (/home/gxc/Desktop/continue-integration/strider-continue/node_modules/strider-webhooks/node_modules/bson/lib/bson/index.js:3:24)     at Module._compile (internal/modules/cjs/loader.js:689:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)     at Module.load (internal/modules/cjs/loader.js:599:32)     at tryModuleLoad (internal/modules/cjs/loader.js:538:12)     at Function.Module._load (internal/modules/cjs/loader.js:530:3)     at Module.require (internal/modules/cjs/loader.js:637:17)     at require (internal/modules/cjs/helpers.js:20:18)     at Object.<anonymous> (/home/gxc/Desktop/continue-integration/strider-continue/node_modules/strider-webhooks/webapp.js:1:78)     at Module._compile (internal/modules/cjs/loader.js:689:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)     at Module.load (internal/modules/cjs/loader.js:599:32)     at tryModuleLoad (internal/modules/cjs/loader.js:538:12)     at Function.Module._load (internal/modules/cjs/loader.js:530:3)     at Module.require (internal/modules/cjs/loader.js:637:17)     at require (internal/modules/cjs/helpers.js:20:18) code: 'MODULE_NOT_FOUND' } 2018-09-07T03:23:40.048Z - error: js-bson: Failed to load c++ bson extension, using pure JS version 2018-09-07T03:23:40.336Z - info: Express server listening on port 3000 in development mode 2018-09-07T03:23:40.341Z - error: (node:13240) DeprecationWarning: collection.update is deprecated. Use updateOne, updateMany,or bulkWrite instead. ^C
environment

centos 7
mongodb 3.6.3
node  v10.6.0
npm 6.4.1
"mongoose": "^5.2.8"

description
i had find this problem in google and baidu they say this problem is made by mongoose and i can't find this file in ..node_modules\mongodb\node_modules\bson\ext\index.js to sovle this problem . so i think maybe there are something wrong in other problem . i chang this file node_modules/strider-webhooks/node_modules/bson/lib/bson/index.js:3:24) and find the promble err was disappear but also has a little trouble in running .so i hope can sovle this problem . thank you very much .

That is an error that is handled, see the text in the log after the error:

error: js-bson: Failed to load c++ bson extension, using pure JS version

What is the issue you are experiencing and what version of Strider are you using?

The version of Strider is "strider-cli": "^2.0.0" .  I find the problem is here  The strider-webhooks can't find bson .  i find windos and linux all throw out this error ! thank you very much

Notice line 19, the error is ignored and an alternative is used. This is a non issue and a red herring if something doesn't work for you.
What is the version of strider (not strider-cli)?

Hello. I have same issue.

+1

Closing since the bson issue is handled, there must be another error. I recommend giving 2.1.0 a try.


Our Contributor page should have a [Home] button

In 'Our Contributor' page there is no way to go to the 'Home' page itself neither this page open in new tab.
There should be something, with the help of, user can navigate to the home page.
-->  I add a home icon in the top left corner of this page. From this user can navigate into the home page.

Please assign me this ISSUE. I want to work on this.

Please assign this issue to me @vishanurag