RUMM-1100 Generate and use the UserInfo model from json schema

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #498 (8a18c34) into mconstantin/pokogenerator-support-any-value-for-additional-properties (3fcee1c) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@                                             Coverage Diff                                             @@
##             mconstantin/pokogenerator-support-any-value-for-additional-properties     #498      +/-   ##
===========================================================================================================
+ Coverage                                                                    89.22%   89.36%   +0.13%
+ Complexity                                                                    1411     1402       -9
===========================================================================================================
  Files                                                                          168      167       -1
  Lines                                                                         4928     4905      -23
  Branches                                                                       569      561       -8
===========================================================================================================
- Hits                                                                          4397     4383      -14
+ Misses                                                                         341      338       -3
+ Partials                                                                       190      184       -6

Impacted Files
Coverage Δ
Complexity Δ

...lin/com/datadog/android/log/internal/domain/Log.kt
100.00% <ø> (ø)
12.00 <0.00> (ø)

...atadog/android/log/internal/domain/LogGenerator.kt
97.96% <ø> (ø)
29.00 <0.00> (ø)

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
87.26% <ø> (ø)
27.00 <0.00> (ø)

...ndroid/rum/internal/ndk/NdkUserInfoFileStrategy.kt
100.00% <ø> (ø)
1.00 <0.00> (ø)

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
90.12% <100.00%> (+3.28%)
32.00 <1.00> (+2.00)

...tadog/android/log/internal/domain/LogSerializer.kt
91.89% <100.00%> (+1.35%)
29.00 <0.00> (ø)

...droid/log/internal/user/DatadogUserInfoProvider.kt
85.71% <100.00%> (ø)
4.00 <1.00> (ø)

.../android/log/internal/user/UserInfoDeserializer.kt
66.67% <100.00%> (+6.67%)
2.00 <0.00> (ø)

...og/android/log/internal/user/UserInfoSerializer.kt
100.00% <100.00%> (+21.43%)
2.00 <1.00> (-8.00)
:arrow_up:

...ndroid/rum/internal/domain/scope/RumActionScope.kt
98.23% <100.00%> (ø)
53.00 <0.00> (ø)

... and 10 more


ko: Change the full link in the document to an inline link.

Change to inline URL for inconsistent full URLs and inline URLs.
following command
grep -r "https \: \ / \ / kubernetes \ .io" content/ko/docs
Changed to inline link except the following list.

URLs are mentioned directly in the body
release note
url to blog
url to community
Url to be redirected

Changed docs list.

[x] /ko/docs/concepts/architecture/nodes

Submitted in PR #16876.

[x] /ko/docs/concepts/workloads/pods/pod-overview
[x] /ko/docs/reference/glossary/cri
[x] /ko/docs/setup/production-environment/windows/user-guide-windows-nodes
[x] /ko/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk

reference
/language ko
from #17058

/assign @seokho-son

Master에 #17057 PR을 확인하였습니다. 해당 PR이 merge되는 것을 보고 처리하도록 하겠습니다 :)

@seokho-son 넵 :)

/lgtm
/approve


TypeScript extension is not picking up my virtual project scope Visual Studio 2015

I am experiencing some unclear behavior within Visual Studio 2015.
Somehow the Visual Studio TypeScript extension is not picking up the files within my project.

It is a project.json based project. It looks like there is some conflict with the gulp-typescript package?
Setup a repo on GitHub: https://github.com/cveld/angular-typescript

Try removing the tsconfig.json file (just rename it to something like tsconfig.json.bak) and see if that helps.

Yes that works! What to do next?

Glad you found the issue!


add calico-apiserver to list of rancher namespaces so that it doesn't show up in user namespace filters in 1.23 clusters

Rancher Server Setup

Rancher version: v2.6-head (6c12bee)
Installation option (Docker install/Helm Chart): helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): rke1, v1.3.10-rc3

Proxy/Cert Details: valid letsencrypt certs

Information about the Cluster

Kubernetes version: 1.23.5
Cluster Type (Local/Downstream): downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): any (tested with vsphere node driver)

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom): any (tested with standard user, cluster owner)

Describe the bug
on a fresh install, the calico-apiserver workload/namespace are listed under user namespaces when rancher installed it during the provisioning process.
To Reproduce

deploy a 1.23 cluster using a node driver
wait for the cluster to get to active state, and view workloads of the cluster with only user namespaces filter enabled (this is the default view)

Result
workloads are listed for calico-apiserver
Expected Result
user namespaces should be empty on a fresh install downstream cluster
Screenshots

Additional context
this is net-new on 1.23

Reassigned to team 3 because the UI decides how to classify things based on fields in the chart.

@jakefhyde which chart are you referring to? This workload would be deployed when calico is selected as the CNI during cluster provisioning.

Root cause
calico-apiserver was not present in the list of CATTLE_SYSTEM_NAMESPACES
What was fixed, or what changes have occurred
Added calico-apiserver to the list of CATTLE_SYSTEM_NAMESPACES. This should be automatically added on upgrade, based on the work done for this issue: https://github.com/rancher/rancher/issues/32898
Areas or cases that should be tested

Create the calico-apiserver namespace on a rancher setup before this commit. Verify that it is moved on upgrade.
Create the calico-apiserver namespace on a rancher setup after this commit. Verify that it is present in the list of system namespaces.

What areas could experience regressions?
N/A
Are the repro steps accurate/minimal?
:heavy_check_mark:

tested on v2.6.7-rc3:

new and upgraded clusters to 1.23+ do not have any namespaces/workloads in user only namespaces -- pass


Creating of organisms

Later I saw that the users can create their own organisms and add them to the project. I suggest to add a hint on that in the project management window. For instance: “If you cannot find the organism, you can create it here.”

When I created a mock organism to thest the organism creation it was possible to create it by just providing the Display name. The NCBI Taxonomy URI is implemented as an optional attribute (no red star and I did not need to provide it) although the text says „A valid NCBI taxonomy URI is required.“ So, is it a bug that the NCBI Taxonomy URI is optional currently?


chore: upgrade dependencies

Upgrade all Dependencies using  yarn upgrade-interactive --latest to remove all security vulnerabilities.

I'm not surprised by the big diff in the log file but am wondering about /dist/main.js. This is a generated file, or? Is it intentionally committed?

I'm not surprised by the big diff in the log file but am wondering about /dist/main.js. This is a generated file, or? Is it intentionally committed?

Yes, it is autogenerated by yarn build which converts the latest JS code in action to transpiled code into the bundle /dist.main.js for node to understand and run in Pull requests.
The big diff is because of the all the new dependencies added.
I also minified the bundle now, so we don't have a huge difference.


path/filepath: confusing error message for Rel

This program
U:\>type main.go
package main

import (
        "fmt"
        "path/filepath"
)

func main() {
        fmt.Println(filepath.Rel(`c:\windows`, `d:\windows`))
}

outputs
 Rel: can't make \windows relative to \windows

but should output
 Rel: can't make d:\windows relative to c:\windows

Alex

Currently the error message contains pathnames that are Cleaned after dropping the volumeName.  It may be preferable to instead show the original basepath and targpath in error messages.  If so, some existing tests break.  Should we display the original pathnames in the error messages and fix the existing tests?


[release-v1.9] Remove JVM RAM percentage

We don't set limits, so we can't define percentages.

/retest

/cc @matzew


Fix problem with git subdir repos

Fixes https://github.com/nephio-project/nephio/issues/451

I manually ran the Porch e2e tests successfully with images build from this PR.


Add directions to MUC for project

See https://github.com/node-xmpp/node-xmpp.github.io/issues/7#issuecomment-73371760

Added in https://github.com/node-xmpp/node-xmpp.github.io/pull/9


Removed GOPATH from Atom's config.cson

Don't think it's necessary(?) as $GOPATH is set in https://github.com/holman/dotfiles/blob/master/go/path.zsh
https://github.com/joefitzgerald/go-config/wiki/GOPATH

My link above probably didn't make much sense... this is from the go-plus settings

My link above probably didn't make much sense... this is from the go-plus settings

Yeah this likely can be removed - prior to 1.8, Atom had a hard time reading environment variables unless directly launched from the shell (vs the dock icon, etc.).  In the 1.8 release, Atom got better environment handling where launching Atom from the shell "remembers" the environment variables for any other launches.
For me, I had to manually set the GOPATH in go-plus before 1.8, but haven't had to since.

Yeah this likely can be removed - prior to 1.8, Atom had a hard time reading environment variables unless directly launched from the shell (vs the dock icon, etc.).  In the 1.8 release, Atom got better environment handling where launching Atom from the shell "remembers" the environment variables for any other launches.
For me, I had to manually set the GOPATH in go-plus before 1.8, but haven't had to since.

Cool; I'll give this a shot. I've been seeing weird stuff with the GOPATH stuff in Atom lately; maybe this'll fix it.

Cool; I'll give this a shot. I've been seeing weird stuff with the GOPATH stuff in Atom lately; maybe this'll fix it.


Module not found: Can't resolve 'styled-components/primitives'

Steps to reproduce
Install<EMAIL_ADDRESS>or @3.4.1 or @3.4.0
Use styled-components/primitives
Error: Module not found: Can't resolve 'styled-components/primitives'
Expected Behavior
filenames in styled-components/dist do not have trailing m
ie. styled-components-primitives.cjs.js
Actual Behavior
filenames in styled-components/dist have trailing m
ie. styled-components-primitivesm.cjs.js
Workaround
downgrade to<EMAIL_ADDRESS>

It's fixed in master, just haven't done a patch release yet. I'll try to get one out today.

Should be resolved in 3.4.3


update for wgpu 0.8

Changes to get Bevy to compile with wgpu master.
With this, on a Mac:

2d examples look fine
3d examples crash with an error specific to metal about a compilation error
3d examples work fine after enabling feature wgpu/cross

Feature wgpu/cross seems to be needed only on some platforms, not sure how to know which. It was introduced in https://github.com/gfx-rs/wgpu-rs/pull/826

feature wgpu/cross can be removed after https://github.com/gfx-rs/naga/pull/693 has been released 🎉

updated to 0.8!
examples fails to run with
wgpu error: Validation Error

Caused by:
    In Device::create_bind_group
    sampler binding 3 expects filtering = false, but given a sampler with filtering = true

fixed above issue by setting all sampler bindings to filtering

There's a whole bunch more validation in wgpu-0.8, it would be really nice to upgrade just for that alone.

I think I renamed everything following the changes in wgpu

bors r+


feat: add profile support

Fix for Issue #81

No comments? 🚀

thanks @mhornbacher! it was good! 🎉 I'll create a new release later :)

Thanks. This unblocked us internally at block :)


Error while installing xhtml2pdf

I am using Docker and I am not being able to install xhtml2pdf.
 × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [10 lines of output]
      ##### setup-python-3.9.10-linux-x86_64: ================================================
      ##### setup-python-3.9.10-linux-x86_64: Attempting build of _rl_accel
      ##### setup-python-3.9.10-linux-x86_64: extensions from 'src/rl_addons/rl_accel'
      ##### setup-python-3.9.10-linux-x86_64: ================================================
      ##### setup-python-3.9.10-linux-x86_64: ===================================================
      ##### setup-python-3.9.10-linux-x86_64: Attempting build of _renderPM
      ##### setup-python-3.9.10-linux-x86_64: extensions from 'src/rl_addons/renderPM'
      ##### setup-python-3.9.10-linux-x86_64: ===================================================
      ##### setup-python-3.9.10-linux-x86_64: will use package libart 2.3.21
      !!!!! cannot find ft2build.h
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Is there any other version that can work with linux?

Same error here

Same error

Is there any more information about what dependency exactly needs libart or ft2build.h for that matter? I mean it's not a direct dependency of xhtml2pdf, so I'm not sure what we can do on our end to prevent this. Maybe a platform-specific sub-dependency? But we'd need more information to reproduce this and offer a solution.

I have a similar issue #694 . The specific dependency is reportlab. To reproduce this, you can try to install xhtml2pdf on a minimal Linux distribution(like Alpine) that doesn't have freetype installed or installs it in a non-standard location.

reportlab and xhtml2pdf are two different projects, although xhtml2pdf uses reportlab. You should probably seek support at the reportlab user forum instead of here, as we cannot do anything about reportlab issues.

I'll repeat myself:

@stefan6419846 Thanks a lot for your support in issue triage, I agree that this has nothing to do with xhtml2pdf.
Unfortunately, I don't see a clear way how to report bugs for reportlab, there is the repository https://hg.reportlab.com/hg-public/reportlab but I don't see a way to report bugs there. Maybe via the google group https://groups.google.com/g/reportlab-users?

– https://github.com/xhtml2pdf/xhtml2pdf/issues/694#issuecomment-1742058956


Create Xmlable contract

Trying again…
I find myself working with a lot of XML-based web services. The framework has a Jsonable contract so thought I would add a Xmlable contract in case any one else is like me and unfortunately enough to be working with XML-based web services instead of JSON ones.

If it doesn't do anything in the framework it might be best to just define the contract in your own application for now. If we had some automatic conversion to XML or something I think it would make more sense.

@taylorotwell No problem. Thanks for the feedback.


Feature): Adds postcss-sorting and initial config.

Description
Adds postcss-sorting and initial boilerplate config. No script implementation included.
Type of change
Please delete options that are not relevant.

[x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
ran yarn build and yarn lint with no errors.
ran cli command as recommended in docs
npx postcss --no-map --replace dist/storybook.css with little or no effect.
Checklist:

[ ] My changes generate no new warnings

Marking as a Draft as my first test locally, it doesn't seem to want to reorder the rules as described by the project. ¯_(ツ)_/¯
I'll do a little digging. I'm not seeing this is anything you did or left out. But in theory, when this is setup, and you run yarn start for local dev or yarn build for prod build, yarn prep is ran and should be running all the CSS through this and reordering at least a few styles I'm looking at.

Yeah I'm not sure what this is doing either. As I noted I ran the replace command with little effect other than doubling up some existing styles.


Add takeUntil

Keep items earlier than a signal from another stream.   Add takeUntil unit tests and cleanup up unit tests in same file.  Improve jsdoc for filter-related public APIs.
Close #26

Hey @briancavalier i believe this is not expected. i hope you could shed some light.
http://requirebin.com/?gist=fcabd52e0c21abfa10bc
Open the browser console and check the comment's. takeUntil doesn't seem to unsubscribe properly when invoked.

Hey @nissoh, could you open a new issue for this?  I'll look into it today.  Thanks!


saving results fails

The adata file from the tutorial https://cellrank.readthedocs.io/en/stable/cellrank_basics.html can not be saved using adata.write('CellRank_Tutorial.h5ad').

## after the tutorial https://cellrank.readthedocs.io/en/stable/cellrank_basics.html
adata.write('CellRank_Tutorial.h5ad')
...

adata.write('CellRank_Tutorial.h5ad')
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/utils.py", line 209, in func_wrapper
    return func(elem, key, val, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/h5ad.py", line 148, in write_not_implemented
    raise NotImplementedError(
NotImplementedError: Failed to write value for uns/coarse_fwd, since a writer for type <class 'anndata._core.anndata.AnnData'> has not been implemented yet.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/anndata/_core/anndata.py", line 1912, in write_h5ad
    _write_h5ad(
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/h5ad.py", line 118, in write_h5ad
    write_attribute(f, "uns", adata.uns, dataset_kwargs=dataset_kwargs)
  File "/usr/lib/python3.8/functools.py", line 875, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/h5ad.py", line 130, in write_attribute_h5ad
    _write_method(type(value))(f, key, value, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/h5ad.py", line 294, in write_mapping
    write_attribute(f, f"{key}/{sub_key}", sub_value, dataset_kwargs=dataset_kwargs)
  File "/usr/lib/python3.8/functools.py", line 875, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/h5ad.py", line 130, in write_attribute_h5ad
    _write_method(type(value))(f, key, value, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/anndata/_io/utils.py", line 212, in func_wrapper
    raise type(e)(
NotImplementedError: Failed to write value for uns/coarse_fwd, since a writer for type <class 'anndata._core.anndata.AnnData'> has not been implemented yet.

Above error raised while writing key 'uns/coarse_fwd' of <class 'h5py._hl.files.File'> from /.
...

Versions:

cellrank==1.5.1 scanpy==1.7.2 anndata==0.7.8 numpy==1.21.2 numba==0.55.0 scipy==1.7.3 pandas==1.3.5 pygpcca==1.0.3 scikit-learn==1.0.2 statsmodels==0.13.1 python-igraph==0.8.3 scvelo==0.2.4 pygam==0.8.0 matplotlib==3.5.1 seaborn==0.11.2

Hi @stela2502 ,
thanks for raising this issue, can reproduce. Quickest way to fix this is to upgrade to the newest version of AnnData as pip install git+https://github.com/theislab/anndata, though new release should be coming out soon.
Not sure exactly why I've decided to store the coarse-grained transtions as AnnData (could be just pandas.DataFrame), so will change it later.

Sometimes one is totally focused on an other mechanistic part and just happy there is a structure to store the results in that one does not need to maintain oneself ;-)
But the fact you never tried to save the results seams to be surprising to me. You do not think the results are worth saving?
:-D
Looking forward to the update. At the moment I just deleted the 'problematic' part.

Hi @stela2502, thanks for catching this!
In my analysis workflow, I usually don't write entire AnnData objects to file to save intermediate results because it's quite memory inefficient. Instead, @michalk8 developed a simple scanpy extension called scachepy: https://github.com/theislab/scachepy
As a disclaimer, it's not actively maintained and a bit unstable. Nevertheless, the idea is great: you initialize a cache object c before you start your analysis and you tell it where to write the cache to. This object has wrappers for some expensive computations, like scVelo's dynamical model paramter fit. Instead of scv.tl.recover_dynamics, you simply call c.tl.recover_dynamics, and this automatically writes the results to file. You don't need to worry about filepaths etc every single time you do this, they have been declared once at the beginning of your analysis. This ensures that only those attributes are written to file which are associated with a specific action, which is much more memory efficient. Also, I find this solution more elegant rather than writing to AnnData at intermediate analysis steps.

Thank you for this info.
I saved the adata object at the end of the tutorial analysis as that was as far as I wanted to go there.
We are thinking of how to show the results in VR: https://www.cellexalvr.med.lu.se/

Thank you for this info. I saved the adata object at the end of the tutorial analysis as that was as far as I wanted to go there. We are thinking of how to show the results in VR: https://www.cellexalvr.med.lu.se/

Nice! Would be very cool to see CellRank results in VR :)

To import CellRank results into VR one needs to hop through some loops at the moment.
We can only use the CellRank results as FACS index values. And we can not directly show these values on the umap, but one can create FACS 3D plots and select from there.

Hi @stela2502, sorry but I don't get the problem. Could you give a concrete example of what's currently failing/missing please?

@michalk8, anything to be done here from our side?

Hi,
I have been working through the scvelo ->cellrank paga directed graphs workflow, and have tried to save the adata with adata.write . Data has saved successfully up until this workflow. As per suggestion above, I upgraded to anndata @ git+https://github.com/theislab/anndata@8cc6ddc1fb6df0523482b3184aca461c57e93f99  with cellrank 1.5.1 and scvelo 0.2.4.
I get roughly the same error, NotImplementedError: Failed to write value for uns/coarse_fwd, since a writer for type <class 'anndata._core.anndata.AnnData'> has not been implemented yet..
Any help or tips would be greatly appreciated!
adata.write("scvelo.cr.5.h5ad")
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/utils.py:209, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    208 try:
--> 209     return func(elem, key, val, *args, **kwargs)
    210 except Exception as e:

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/h5ad.py:148, in write_not_implemented(f, key, value, dataset_kwargs)
    143 @report_write_key_on_error
    144 def write_not_implemented(f, key, value, dataset_kwargs=MappingProxyType({})):
    145     # If it’s not an array, try and make it an array. If that fails, pickle it.
    146     # Maybe rethink that, maybe this should just pickle,
    147     # and have explicit implementations for everything else
--> 148     raise NotImplementedError(
    149         f"Failed to write value for {key}, "
    150         f"since a writer for type {type(value)} has not been implemented yet."
    151     )

NotImplementedError: Failed to write value for uns/coarse_fwd, since a writer for type <class 'anndata._core.anndata.AnnData'> has not been implemented yet.

The above exception was the direct cause of the following exception:

NotImplementedError                       Traceback (most recent call last)
Input In [40], in <cell line: 2>()
      1 import anndata
----> 2 adata.write("scvelo.cr.5.h5ad")

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_core/anndata.py:1912, in AnnData.write_h5ad(self, filename, compression, compression_opts, force_dense, as_dense)
   1909 if filename is None:
   1910     filename = self.filename
-> 1912 _write_h5ad(
   1913     Path(filename),
   1914     self,
   1915     compression=compression,
   1916     compression_opts=compression_opts,
   1917     force_dense=force_dense,
   1918     as_dense=as_dense,
   1919 )
   1921 if self.isbacked:
   1922     self.file.filename = filename

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/h5ad.py:118, in write_h5ad(filepath, adata, force_dense, as_dense, dataset_kwargs, **kwargs)
    116 write_attribute(f, "varp", adata.varp, dataset_kwargs=dataset_kwargs)
    117 write_attribute(f, "layers", adata.layers, dataset_kwargs=dataset_kwargs)
--> 118 write_attribute(f, "uns", adata.uns, dataset_kwargs=dataset_kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/functools.py:888, in singledispatch.<locals>.wrapper(*args, **kw)
    884 if not args:
    885     raise TypeError(f'{funcname} requires at least '
    886                     '1 positional argument')
--> 888 return dispatch(args[0].__class__)(*args, **kw)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/h5ad.py:130, in write_attribute_h5ad(f, key, value, *args, **kwargs)
    128 if key in f:
    129     del f[key]
--> 130 _write_method(type(value))(f, key, value, *args, **kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/h5ad.py:294, in write_mapping(f, key, value, dataset_kwargs)
    292 def write_mapping(f, key, value, dataset_kwargs=MappingProxyType({})):
    293     for sub_key, sub_value in value.items():
--> 294         write_attribute(f, f"{key}/{sub_key}", sub_value, dataset_kwargs=dataset_kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/functools.py:888, in singledispatch.<locals>.wrapper(*args, **kw)
    884 if not args:
    885     raise TypeError(f'{funcname} requires at least '
    886                     '1 positional argument')
--> 888 return dispatch(args[0].__class__)(*args, **kw)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/h5ad.py:130, in write_attribute_h5ad(f, key, value, *args, **kwargs)
    128 if key in f:
    129     del f[key]
--> 130 _write_method(type(value))(f, key, value, *args, **kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/utils.py:212, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    210 except Exception as e:
    211     parent = _get_parent(elem)
--> 212     raise type(e)(
    213         f"{e}\n\n"
    214         f"Above error raised while writing key {key!r} of {type(elem)}"
    215         f" from {parent}."
    216     ) from e

NotImplementedError: Failed to write value for uns/coarse_fwd, since a writer for type <class 'anndata._core.anndata.AnnData'> has not been implemented yet.

Above error raised while writing key 'uns/coarse_fwd' of <class 'h5py._hl.files.File'> from /.

@michalk8, it seems like we write an AnnData object to AnnData.uns, do we really want to do this? @ivirshup asked me that recently as well.

@michalk8, it seems like we write an AnnData object to AnnData.uns, do we really want to do this? @ivirshup asked me that recently as well.

Should be doable in the newest AnnData version, let's stick with this. Will update the requirements + add a test case for this.

I think it's fine, this should work with anndata==0.8.0 (IIRC @cramsuig has confirmed this). I was more curious about why it was being done this way.

Thanks! Anything to be done here @michalk8 to help @kmh005 ?

Thanks! Anything to be done here @michalk8 to help @kmh005 ?

Updating to the newest anndata (0.8.0) should make it work. Can revert this and use pandas.DataFrame instead.

Thanks for you help with this. My pip install version is 0.8.0rc2.dev4+g8cc6ddc . Is this the recommended version?

Thanks for you help with this. My pip install version is 0.8.0rc2.dev4+g8cc6ddc . Is this the recommended version?

I've changed it so that a dict is saved, instead of AnnData. You can try updating CellRank to dev as pip install git+https://github.com/theislab/cellrank@dev
Closing this via #841 , feel free to re-open if any related problems arise.

@michalk8, why did you end up removing that? Did you just not want to rely on anndata>=0.8?

@michalk8, why did you end up removing that? Did you just not want to rely on anndata>=0.8?

Yes, since it's the newest version and we'd need it only in this place. For compatibility with scanpy/scvelo, think it' better not to have this stricter requirement.

Hi,
I set my pip install to 0.8.0 as instructed. I get a different error trying to save the anndata, any guidance most appreciated.
import anndata
adata.write("scvelo.cr.5.h5ad")
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/utils.py:214, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    213 try:
--> 214     return func(elem, key, val, *args, **kwargs)
    215 except Exception as e:

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/specs/registry.py:175, in write_elem(f, k, elem, modifiers, *args, **kwargs)
    174 else:
--> 175     _REGISTRY.get_writer(dest_type, t, modifiers)(f, k, elem, *args, **kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/specs/registry.py:64, in IORegistry.get_writer(self, dest_type, typ, modifiers)
     63 if (dest_type, typ, modifiers) not in self.write:
---> 64     raise TypeError(
     65         f"No method has been defined for writing {typ} elements to {dest_type}"
     66     )
     68 return self.write[(dest_type, typ, modifiers)]

TypeError: No method has been defined for writing <class 'cellrank.tl._lineage.Lineage'> elements to <class 'h5py._hl.group.Group'>

The above exception was the direct cause of the following exception:

TypeError                                 Traceback (most recent call last)
Input In [18], in <cell line: 2>()
      1 import anndata
----> 2 adata.write("scvelo.cr.5.h5ad")

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_core/anndata.py:1918, in AnnData.write_h5ad(self, filename, compression, compression_opts, force_dense, as_dense)
   1915 if filename is None:
   1916     filename = self.filename
-> 1918 _write_h5ad(
   1919     Path(filename),
   1920     self,
   1921     compression=compression,
   1922     compression_opts=compression_opts,
   1923     force_dense=force_dense,
   1924     as_dense=as_dense,
   1925 )
   1927 if self.isbacked:
   1928     self.file.filename = filename

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/h5ad.py:100, in write_h5ad(filepath, adata, force_dense, as_dense, dataset_kwargs, **kwargs)
     98 write_elem(f, "obs", adata.obs, dataset_kwargs=dataset_kwargs)
     99 write_elem(f, "var", adata.var, dataset_kwargs=dataset_kwargs)
--> 100 write_elem(f, "obsm", dict(adata.obsm), dataset_kwargs=dataset_kwargs)
    101 write_elem(f, "varm", dict(adata.varm), dataset_kwargs=dataset_kwargs)
    102 write_elem(f, "obsp", dict(adata.obsp), dataset_kwargs=dataset_kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/utils.py:214, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    211 @wraps(func)
    212 def func_wrapper(elem, key, val, *args, **kwargs):
    213     try:
--> 214         return func(elem, key, val, *args, **kwargs)
    215     except Exception as e:
    216         if "Above error raised while writing key" in format(e):

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/specs/registry.py:175, in write_elem(f, k, elem, modifiers, *args, **kwargs)
    171     _REGISTRY.get_writer(dest_type, (t, elem.dtype.kind), modifiers)(
    172         f, k, elem, *args, **kwargs
    173     )
    174 else:
--> 175     _REGISTRY.get_writer(dest_type, t, modifiers)(f, k, elem, *args, **kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/specs/registry.py:24, in write_spec.<locals>.decorator.<locals>.wrapper(g, k, *args, **kwargs)
     22 @wraps(func)
     23 def wrapper(g, k, *args, **kwargs):
---> 24     result = func(g, k, *args, **kwargs)
     25     g[k].attrs.setdefault("encoding-type", spec.encoding_type)
     26     g[k].attrs.setdefault("encoding-version", spec.encoding_version)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/specs/methods.py:281, in write_mapping(f, k, v, dataset_kwargs)
    279 g = f.create_group(k)
    280 for sub_k, sub_v in v.items():
--> 281     write_elem(g, sub_k, sub_v, dataset_kwargs=dataset_kwargs)

File ~/.conda/envs/scvelo/lib/python3.9/site-packages/anndata/_io/utils.py:220, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    218 else:
    219     parent = _get_parent(elem)
--> 220     raise type(e)(
    221         f"{e}\n\n"
    222         f"Above error raised while writing key {key!r} of {type(elem)} "
    223         f"to {parent}"
    224     ) from e

TypeError: No method has been defined for writing <class 'cellrank.tl._lineage.Lineage'> elements to <class 'h5py._hl.group.Group'>

Above error raised while writing key 'terminal_states_memberships' of <class 'h5py._hl.group.Group'> to /```

I set my pip install to 0.8.0 as instructed. I get a different error trying to save the anndata, any guidance most appreciated.

Seems like in anndata==0.8.0 with the IOSpec changes, writing Lineage class is broken, minimal reproducible example:
from anndata import AnnData
import cellrank as cr
import numpy as np
import scanpy as sc

lin = cr.tl.Lineage(np.random.normal(size=(10, 3)), names=["foo", "bar", "baz"])
adata = AnnData(X=np.random.normal(size=(10, 3)), obsm={"lin": lin})

sc.write("foo.h5ad", adata)

I will implement a proper reader/writer in #777 and request anndata>=0.8.0 + revert the changed made in #841 .
In the meantime, I'd recommend downgrading anndata<0.8 and installing cellrank from master as pip install git+https://github.com/theislab/cellrank as tests in #844 passed (with some unrelated exceptions).

Hmm, this is unexpected. As a last resort, you can remove the values that cause this issue before saving:
del adata.uns['coarse_fwd']['coarse_init_dist']
try:
    del adata.uns['coarse_fwd']['coarse_stat_dist']
except KeyError:
    pass

Hello All,
I am also using Anndata=0.8.0. I am not able to save adata in h5ad format.
Here is the sample code
import anndata adata=anndata.read_h5ad("/home/Akila/input.h5ad") adata.write("/home/Akila/BA9.h5ad")
Error message:
TypeError: No method has been defined for writing <class 'numpy.matrix'> elements to <class 'h5py._hl.group.Group'>
Above error raised while writing key 'X' of <class 'h5py._hl.group.Group'> to /
Please advice

I also had an issue with saving an AnnData object (AnnData==0.8.0),
due to adata.obsm containig a pandas series.
TypeError: No method has been defined for writing <class 'pandas.core.series.Series'> elements to <class 'h5py._hl.group.Group'>
I ended up changing the datatype to pandas DataFrame and the saving went through.

Hi @michalk8, is there anything for us to do here?

Should've be fixed on master long ago.

Hello, I am having a similar problem as users above.
I downgraded to anndata=0.7.8 and cellrank=1.5.1
I also tried with pip install git+https://github.com/theislab/cellrank
Any ideas for how to resolve this?
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/utils.py:214, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    213 try:
--> 214     return func(elem, key, val, *args, **kwargs)
    215 except Exception as e:

 File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/specs/registry.py:175, in write_elem(f, k, elem, modifiers, *args, **kwargs)
    174 else:
--> 175     _REGISTRY.get_writer(dest_type, t, modifiers)(f, k, elem, *args, **kwargs)

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/specs/registry.py:64, in IORegistry.get_writer(self, dest_type, typ, modifiers)
     63 if (dest_type, typ, modifiers) not in self.write:
---> 64     raise TypeError(
     65         f"No method has been defined for writing {typ} elements to {dest_type}"
     66     )
     68 return self.write[(dest_type, typ, modifiers)]

TypeError: No method has been defined for writing <class 'cellrank.tl._lineage.Lineage'> elements to <class 'h5py._hl.group.Group'>
</code>
The above exception was the direct cause of the following exception:

TypeError                                 Traceback (most recent call last)
Cell In [14], line 1
----> 1 adata.write_h5ad(f'/home/gridsan/showe/neuroTF_shared/mouse_cortex_development/scVelo/vk08.c02.lineage.drivers.h5ad')

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_core/anndata.py:1918, in AnnData.write_h5ad(self, filename, compression, compression_opts, force_dense, as_dense)
   1915 if filename is None:
   1916     filename = self.filename
-> 1918 _write_h5ad(
   1919     Path(filename),
   1920     self,
   1921     compression=compression,
   1922     compression_opts=compression_opts,
   1923     force_dense=force_dense,
   1924     as_dense=as_dense,
   1925 )
   1927 if self.isbacked:
   1928     self.file.filename = filename

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/h5ad.py:100, in write_h5ad(filepath, adata, force_dense, as_dense, dataset_kwargs, **kwargs)
     98 write_elem(f, "obs", adata.obs, dataset_kwargs=dataset_kwargs)
     99 write_elem(f, "var", adata.var, dataset_kwargs=dataset_kwargs)
--> 100 write_elem(f, "obsm", dict(adata.obsm), dataset_kwargs=dataset_kwargs)
    101 write_elem(f, "varm", dict(adata.varm), dataset_kwargs=dataset_kwargs)
    102 write_elem(f, "obsp", dict(adata.obsp), dataset_kwargs=dataset_kwargs)

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/utils.py:214, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    211 @wraps(func)
    212 def func_wrapper(elem, key, val, *args, **kwargs):
    213     try:
--> 214         return func(elem, key, val, *args, **kwargs)
    215     except Exception as e:
    216         if "Above error raised while writing key" in format(e):

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/specs/registry.py:175, in write_elem(f, k, elem, modifiers, *args, **kwargs)
    171     _REGISTRY.get_writer(dest_type, (t, elem.dtype.kind), modifiers)(
    172         f, k, elem, *args, **kwargs
    173     )
    174 else:
--> 175     _REGISTRY.get_writer(dest_type, t, modifiers)(f, k, elem, *args, **kwargs)

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/specs/registry.py:24, in write_spec.<locals>.decorator.<locals>.wrapper(g, k, *args, **kwargs)
     22 @wraps(func)
     23 def wrapper(g, k, *args, **kwargs):
---> 24     result = func(g, k, *args, **kwargs)
     25     g[k].attrs.setdefault("encoding-type", spec.encoding_type)
     26     g[k].attrs.setdefault("encoding-version", spec.encoding_version)

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/specs/methods.py:281, in write_mapping(f, k, v, dataset_kwargs)
    279 g = f.create_group(k)
    280 for sub_k, sub_v in v.items():
--> 281     write_elem(g, sub_k, sub_v, dataset_kwargs=dataset_kwargs)

File ~/.conda/envs/cellrank/lib/python3.9/site-packages/anndata/_io/utils.py:220, in report_write_key_on_error.<locals>.func_wrapper(elem, key, val, *args, **kwargs)
    218 else:
    219     parent = _get_parent(elem)
--> 220     raise type(e)(
    221         f"{e}\n\n"
    222         f"Above error raised while writing key {key!r} of {type(elem)} "
    223         f"to {parent}"
    224     ) from e

TypeError: No method has been defined for writing <class 'cellrank.tl._lineage.Lineage'> elements to <class 'h5py._hl.group.Group'>

Above error raised while writing key 'to_terminal_states' of <class 'h5py._hl.group.Group'> to /

hi @spkhowe did you manage to solve your problem? I experience the same issue but am on anndata 0.8.0 and cellrank-krylov 1.5.1
TypeError: No method has been defined for writing <class 'cellrank.tl._lineage.Lineage'> elements to <class 'h5py._hl.group.Group'>

Above error raised while writing key 'terminal_states_memberships' of <class 'h5py._hl.group.Group'> to /

For me, the issue was resolved when I explicitly cast the .X matrix to a csr_matrix:
from scipy.sparse import csr_matrix
adata = sc.AnnData(csr_matrix(mtx), obs=barcodes, var=peaks)


Add MAINTAINERS file

Change-type: patch
Signed-off-by: Gergely Imreh<EMAIL_ADDRESS>

Can one of the admins verify this patch?


[feature]:  add interceptors for mocking http client calls in API

Is there an existing feature request for this?

[X] I have searched the existing issues

Summary

Since keploy generates mocks along with testcases to mock infra structure calls like http client calls , db calls , message queues , it's necessary to add integrations for dependency mocking .

As http clients are the most commonly used external dependencies which help an API to perform and communicate to other services as well as APIs . We can add interceptors which can act as an intermediate between the http requests and response .

We can save the all the attributes of that call in HTTP SPEC in the form of yamls.

We can replay those at test mode and this time we would be using mocks rather than making actual api calls to the external servers .

We can implement this feature for Apache and Okhttp clients which are widely used in java applications .

Integration can be smooth if user will be able to integrate in its application on the fly . For that we can use some ASM library tools like Bytebuddy .

Then user can define the agent JAR in its VM options of IDE or run manually using cli command .

Why should this be worked on?
This is an important feature to showcase the mocking infra capabilities of keploy
Also user will be able to test its API with ETE tests generated by keploy without caring about test environments
Tests and mocks generated will be more realistic are captured from the real traffic .

Closes with the above PR #73


Error while deploying Subscription for APIM API using Bicep

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Run Sample.ipynb through Visual studio code
Any log messages given by the failure

"details":[{"code":"LinkedInvalidPropertyId","message":"Property id '/apis/openai' at path 'properties.scope' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'."}]}]}]}}
Expected/desired behavior

It should add a subscription for API OpenAI.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
Windows 11

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

@arindamhazramsft I located the issue with the deployment. The Bicep template was using older API versions which caused an error in the infrastructure deploying successfully.
If you could try again and let me know if this is now working for you, that would be appreciated.


Raise error when function as llm_config passed to GroupChatManager

Raise error when function as llm_config passed to GroupChatManager
Add test in test_function_call_groupchat.py.
Handling undesired case when selector is returning a function_call instead of str name.

Why are these changes needed?

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (cbd1e19) 26.58% compared to head (dd9c3b0) 30.60%.

Files
Patch %
Lines

autogen/agentchat/groupchat.py
7.69%
10 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   26.58%   30.60%   +4.01%
==========================================
  Files          28       28
  Lines        3732     3745      +13
  Branches      847      854       +7
==========================================
+ Hits          992     1146     +154
+ Misses       2667     2512     -155
- Partials       73       87      +14

Flag
Coverage Δ

unittests
30.60% <7.69%> (+4.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sounds good. Have we fixed that notebook?

Sounds good. Have we fixed that notebook?

Right. Thanks for the heads up. Let me update it.

@afourney I went through the notebooks and fix one in agentchat_groupchat_RAG.ipynb. Am I missing anything? I didn't find other notebooks that are passing functions to groupmanager.

Test fails: https://github.com/microsoft/autogen/actions/runs/7137474617/job/19437525044?pr=911


==> Tapping homebrew/services

Cloning into '/usr/local/Homebrew/Library/Taps/homebrew/homebrew-services
'...
fatal: unable to access 'https://github.com/Homebrew/homebrew-services
/': The requested URL returned error: 400
Error: Failure while executing; git clone https://github.com/Homebrew/homebrew-services\
 /usr/local/Homebrew/Library/Taps/homebrew/homebrew-services\
 --depth=1 exited with 128.

Thought it was permissions related but it is not best I can tell....

Interesting it worked this way instead....
~ $ brew services start mysql

==> Tapping homebrew/services
Cloning into '/usr/local/Homebrew/Library/Taps/homebrew/homebrew-services'...
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 12 (delta 0), reused 7 (delta 0), pack-reused 0
Unpacking objects: 100% (12/12), done.
Tapped 1 command (41 files, 58.8KB).
Error: No available formula with the name "mysql
"

You'll need to figure this out yourself as both issues are with your setup.


Admin UI, logs meta are displayed incorrectly in Firefox

Logs meta section are not visible in latest Firefox.
I can't find a bug report, but I did find a related stackoverflow  thread . Its recomendes to set the td height to 100%. I tested it, it solves the problem.
I will continue the research and write if there is no better solution.
Pocketbase version 0.14.2

This seems to be caused by the overflow style of the .code-wrapper element. I'll push a fix sometime later today.

I've added a wrapper div that seems to fix the overflow issue in master.
The "fix" will be available with the next minor v0.14.3 release sometime later this week.


Fixing ServiceUrl to include protocol

The AmazonS3Config class requires the protocol to be specified when using the ServiceUrl property.

Happy to revert https://github.com/serilog-contrib/Serilog.Sinks.AmazonS3/pull/25/commits/cb272e6f3bb880357b7a502abeb3667dfdd34595 if you think it's too much.

I will have to check this again in production, but from a first view, it looks good 👍


Incompatible with Ruby 2.1.2

Just switched a project over too ruby 2.1.2, and it seems jazz_hands's dependencies kill the bundle.
Using debugger-ruby_core_source 1.3.4

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    /Users/me/.rvm/rubies/ruby-2.1.2/bin/ruby extconf.rb
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
  --with-opt-dir
  --with-opt-include
  --without-opt-include=${opt-dir}/include
  --with-opt-lib
  --without-opt-lib=${opt-dir}/lib
  --with-make-prog
  --without-make-prog
  --srcdir=.
  --curdir
  --ruby=/Users/me/.rvm/rubies/ruby-2.1.2/bin/ruby
/Users/me/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/fileutils.rb:1573:in `stat': No such file or directory @ rb_file_s_stat - ./212/ruby_debug.h (Errno::ENOENT)
  from /Users/me/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/fileutils.rb:1573:in `block in fu_each_src_dest'
  from /Users/me/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/fileutils.rb:1587:in `fu_each_src_dest0'
  from /Users/me/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/fileutils.rb:1571:in `fu_each_src_dest'
  from /Users/me/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/fileutils.rb:399:in `cp'
  from extconf.rb:83:in `block in <main>'
  from extconf.rb:82:in `each'
  from extconf.rb:82:in `<main>'

extconf failed, exit code 1

Gem files will remain installed in<EMAIL_ADDRESS>for inspection.
Results logged to<EMAIL_ADDRESS>An error occurred while installing debugger (1.6.6), and Bundler cannot continue.
Make sure that `gem install debugger -v '1.6.6'` succeeds before bundling.

This is closed almost one year ago but still have this problem due to debugger gem that is not compatible with ruby 2.x

I guess jazz_hands never was updated.  I just had the same issue but the 'bring-your-own-debugger' did the trick.

@brobertsaz Try my fork jazz_fingers. It is pretty much the same but with all the latest version of the dependencies.

@plribeiro3000 thanks and i will try it out in just a minute :)

I was getting these two errors:

Running bundle install after adding jazz_hands to my Gemfile failed and said it could not find a compatible version of pry.

Running bundle update gave me a build error while installing debugger 1.6.8 because as people have said here, it's not compatible with ruby v2.1+.

Here's how I fixed it:
I replaced gem jazz_hands in my Gemfile with:
gem 'jazz_hands', github: 'nixme/jazz_hands', branch: 'bring-your-own-debugger'
gem 'pry-byebug'

Then bundle update. That fixed it!
Note: Running bundle install still gave me the pry build error. Make sure you update.


Environment variables are not expanded when opening command window

VSCode Version: 1.3.1
OS Version: Win 10

Steps to Reproduce:

Create a new System environment variable (e.g. NODE_HOME=C:\Node)
Update System environment variable for PATH to be %NODE_HOME%;%PATH%
Restart windows
Open command prompt (e.g. Win-X, C) and enter 'set PATH' to see PATH=C:\Node;...
Open VSCode, right click on a file in explorer and select 'Open in Command Prompt'
Enter 'set PATH' and you see %NODE_HOME%;.. rather than "C:\Node;..." as in step 4.

Restarting PC resolved issue


Booster Manager not working for me

when having it go to create a booster it throws the error shown below

tried fixing it myself to no avail, also note it wont craft any boosters even if i give it a specific appid
running on linux (ASF <IP_ADDRESS> - linux-x64 - 6df84ff), i have almost 6k games with craftable boosters
other plugins:
MobileAuthenticatorPlugin <IP_ADDRESS>
SteamTokenDumperPlugin <IP_ADDRESS>
ASFEnhance <IP_ADDRESS>
FreePackages <IP_ADDRESS>
ItemsMatcherPlugin <IP_ADDRESS>

You are using a pre-release version of ASF, which may have broken something.

Hmmm... I think you should use the generic version of ASF instead of the linux-x64 version. See the note.

Don't have a fix for it yet, but I can reproduce the issue in V<IP_ADDRESS> and can confirm that the issue don't exist in V<IP_ADDRESS> and earlier.

Hmmm... I think you should use the generic version of ASF instead of the linux-x64 version. See the note.
Loosely related:

Cannot run on ASF <IP_ADDRESS> #13 (comment)

the issue with generic is i cant get it to run on my linux machine bc dot net tools isn't wanting to work, i've tried installing dot net and everything i can think of but nothing I've tried has worked.

Just released BoosterManager V<IP_ADDRESS> which fixes this issue


Adjust code snippet width/height

How do I go about making the window that displays the code taller/wider inside a markdownSlide? And also adjust the font size?
I tried to play around with the presentationConfig Block but couldn't get it to work.

Sorry for the delayed response.
Are you displaying code using Kotlin Playground or highlight.js?

No worries at all! I believe it would be highlight.js?

I just want to get more vertical and horizontal space to get rid of the scroll bars.
For Kotlin Playground, I would need to set it in a css block inside the playgroundConfig block right?

For Kotlin Playgrounds, the text size is controlled in the css, as seen here. Another approach to specifying the css can be seen here. The height of a playground is specified here.
For the highlight.js blocks, the font size can be controlled with a css block like:
      .reveal pre code {
	      font-size: 20px;
      }

Other candidate css attributes are mentioned in this post.

I wish all of this was cleaner, but such is the nature of the underlying technology. I will add a page to the docs that explicitly deals with the issues you raised.

Thanks I'd appreciate that! How would I go about modifying a specific highlight.js block?

I'm trying to follow the css examples in the kslides presentation but I can't seem to target the .reveal pre code right.

The line-specific highlighting is specified in the argument to the code block, as seen here. Individual lines are comma-separated and ranges are specified with a "-".

Oh I think I didn't explain myself properly, I mean to increase the height and width of a specific code block, not highlight it.

For the highlight.js blocks, the font size can be controlled with a css block like:
      .reveal pre code {
	      font-size: 20px;
      }

Other candidate css attributes are mentioned in this post.

As in apply this css rule to a single slide, not the entire presentation.

Ah, sorry. That is an interesting question, at least for a non-css expert like me. I know how to do it with a playground slide, but I am not sure about the answer with a markdown code block. I will play wth it and figure it out.


Rendering remote can give different slides than rendering with desktop version

I sometimes get different results when rendering the slides online vs. rendering them locally with the Desktop app.
I include an example where I used the snap environment to locate a flowchart on the east part of slide with
@snap[east span-39]
@img[shadow](assets/flowcharts/flowchart.png)
@snapend

I expect this to produce

whereas online I get

You find the slide deck here

Florian, the quick workaround is to define span-39 as a style in your assets/css/PITCHME.css, like this:
.span-39 { width: 39% !important }

I need to update the set of built-in styles used by the online server to include the latest and full set of span-xx classes that are already available in the Desktop. Currently only the 5, 10, 15...90, 95, 100 spans are available online. Not the full set of 1,2,3...95,96,97,98,99,100 spans that are found in the Desktop.
When I make that change I'll bump this thread. But for now, you need the workaround. Thanks for bringing this to my attention.

The gitpitch.com server has been updated with the full set of span-xx styles. This change should resolve the problem reported here. Depending on your browser you may need to refresh or clear your cache to see this change take effect for your presentation.
If you applied the workaround to your PITCHME.css can you please undo that change. Then test and let me know how it goes.

The fix works for me, no need for any workaround. Thank you very much!


Add k0s installation instructions

I would like to add here k0s installation instructions

Sounds good to me!  Be sure to include a brief description of what k0s is and its pros/cons -- not all of the existing options include this information but they should.

sure great working on this

stale


Order of matching characters

Trying to re-open https://github.com/krisk/Fuse/issues/629. Please help.

bump to prevent close


Cameras don’t import in UE5/5.1

Cameras don’t import into UE5/5.1. I clicked the cameras checkbox in DTU settings in Daz side

I also clicked the checkbox in UE


Set travis and docker to node 10.4.1 and upgrade package.lock.json

Description:
Hopefully fix the build !
Improvements

build?

Known Issues:
NONE

Pull Request Test Coverage Report for Build 2615

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 69.94%

Totals

Change from base Build 2595:
0.009%

Covered Lines:
1282

Relevant Lines:
1772

💛  - Coveralls

@danielkesselberg since we don't use the dir yet, I remove it to see if it helps. But it dind't and yesterday I had no motivation left to fix it, so Thank You! Hopefully now the build works. @danielkesselberg can you approve it?

Build looks good in Travis. Does the frontend work?


[US] UI Refactoring for Consistency

As a user, I want to have a UI friendly application, so that I can have a consistent application.

MoSCoW
Risk
Story Points

Should
Low
3

Acceptance Criteria

Have consistency with the UI throughout the application

Risks

No Risk

Pre-requisites

[ ] Meet with the stakeholder to clarify the requirements
[ ] Complete the requirements of this US

Tasks

[ ] Make the UI more consistent
[ ] Fix the 2000's buttons for "Adding a lookup tables"

Change it to this button

Maybe make the button smaller, more square so it fits better in the page

[ ] Verify all the modals, and make them consistent.

[ ] Make all modal titles Pascal Case for example "Add New Language" capitalize each new word!

[ ] Save button having the secondary color "Blue" and only being named "Save" not "Save Changes"

[ ] Same gap between twin buttons in each modal

[ ] Add button only being named "Add"

[ ] Change the "Add Enum Row", "Add List Row", and "Add New User" to a different type of modal. The type of modal depicted at the end, with the line after the title etc,. For more information ask @lyubageorgieva.

This look of modal should be the targeted feel, but needs the title to be Pascal Case and the "Save Changes" button to be just "Save".

[ ] Verify all these other modals

Feel free to fix any other inconsistency you find! maybe some aren't discovered yet..

Looks good to me! Signing off!


chore: release 0.1.3

:robot: I have created a release *beep* *boop*
0.1.3 (2024-04-13)
Bug Fixes

Add version to logs (d989cce)

Miscellaneous Chores

release 0.1.2 (6df1480)
release 0.1.3 (efe00c3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/luisgabrielroldan/ddogzip/releases/tag/v0.1.3 :sunflower:


"More than one DbContext was found" when migrating database in a vanilla project

From @Biarity on December 21, 2016 7:57
When creating a new ASP.NET Core MVC project, then running:
Add-Migration _some_name,
Update-Database,
I get:
More than one DbContext was found. Specify which one to use. Use the '-Context' parameter for PowerShell commands and the '--context' parameter for dotnet commands.
Any idea why? Isn't ApplicationDbContext the only one there? But then running
Update-Database -Context "ApplicationDbContext" gives:
No parameterless constructor was found on 'ApplicationDbContext'. Either add a parameterless constructor to 'ApplicationDbContext' or add an implementation of 'IDbContextFactory<ApplicationDbContext>' in the same assembly as 'ApplicationDbContext'.
However, my ApplicationDbContext class has the following parameterless constructor:
public ApplicationDbContext(DbContextOptions<ApplicationDbContext> options)             : base(options)         {         }
so I'm not sure why it isn't working.
Same issue on VS 2015 & VS 2017 RC 2.
Copied from original issue: aspnet/Mvc#5626

From @Eilon on December 22, 2016 1:36
@divega any idea on this? Do you need more info to investigate?

@Biarity Not sure why you are getting the first error, but the constructor you posted is not parameterless; it has the ApplicationDbContext parameter.

@Biarity could you provide a repro project for this?

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.

In this thread there are two references and each one references the other ( (Circular) #5646 references this thread #7297 and vice versa).
What was the cause of this problem? Thanks

What was the cause of this problem?

We never heard back from the original reporter, so we weren't able to understand the issue.
If you are experiencing the same problem, please file a new issue so we can investigate further.


fix(assets): Download fonts as offline assets

When quasar is used with tauri, the bundled application does
not have access to the internet so it cannot fetch remote components of the css.
To avoid this issue we extract and bundle the fonts used by this module

cc: @jourdain


Update GSoC-interest.md

Signed-off-by: Sakshi Diggikar<EMAIL_ADDRESS>

Awesome job, @thesakshidiggikar!


InjectionToken error after install

After installing and importing the module, the error appears while compiling:
typescript: ...ento/MyApp/app/node_modules/ng2-currency-mask/src/currency-mask.config.d.ts, line: 1
            Module '"D:/Desenvolvimento/MyApp/app/node_modules/@angular/core/index"' has no exported member
            'InjectionToken'.

       L1:  import { InjectionToken } from "@angular/core";
       L2:  export interface CurrencyMaskConfig {

[15:53:12]  typescript: ...o/MyApp/app/node_modules/ng2-currency-mask/src/currency-mask.directive.d.ts, line: 12
            Type 'KeyValueDiffer' is not generic.

      L11:  inputHandler: InputHandler;
      L12:  keyValueDiffer: KeyValueDiffer<any, any>;
      L13:  optionsTemplate: {

What Angular version are you using? You should use the version 2.x.x for Angular 2.x.x applications and the version 4.x.x for Angular 4.x.x applications.

@cesarrew Change the version in your package.json to "less than 4.x.x" like the following example:
"ng2-currency-mask": "<4.0.0",
It will work, trust me ;-)


Please validate the IDP-initiated URLs are correct

In the "Configure Azure AD SSO" section, on Step 5, I entered my Region-specific URL into the Sign-on URL configuration. When I try to perform an IDP-initiated test of the Mimecast app from the My Apps portal, I am NOT redirected to the application sign on page. I land on the https://protect-eu.mimecast.com/connectivity?status=false URL with the following error:
"Sorry, we're having trouble logging you in.
This is because we can't validate your identity. Please tell your organization's administrator that this is likely to be caused by a SAML issue."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b85b077-78d6-8994-e5b2-14a05e6d8d2b
Version Independent ID: 59db0a3a-b498-c417-fb17-6b7659a2f811
Content: Tutorial: Azure AD SSO integration with Mimecast
Content Source: articles/active-directory/saas-apps/mimecast-personal-portal-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

#please-close


share link should have a 'copy to clipboard' button

This is pretty standard. Its a little confusing what to do with the resolver link. Its a clickable url but goes to the exact same page you are already on. What we really want is for user to copy it. We should have a copy-to-clipboard icon next to it. This seems like its pretty standard.
https://www.w3schools.com/howto/howto_js_copy_clipboard.asp

We decided to take a slightly different approach to resolve this issue than what the w3 link suggests we do.

What we have implemented is an icon (looks like a copy to clipboard icon), that when clicked, will copy the link to the clipboard. We didn't want to clutter the UX more with an input box for copying from or popping up another dialog on top of the modal dialog.

nice, i like how you did this. thank you


About the android project

where is the android project about it, thanks a lot.

https://github.com/nolanliou/PeopleSegmentationDemo


[CS] Fixes #2261 Add Check Required abstract Keyword for Class Name Start with Abstract

All checks have passed 🎉 @TomasVotruba it is ready for review.

Thank you


Any plans for snippets interpolation?

Hello, are there any plans to allow calling external commands from snippets?
Backticks call an external command. It would look something like this:
"External python command": {
  "prefix": "lorem",
  "body": [
    "${`lorem.py 2s 3p`}"
  ],
  "description": "External python command"
}

The program would need to return a list with empty items for new lines ['paragraph1','','paragraph2','','paragraph3'].
for n in range(n_para):
		p1 = [random.choice(sentences) for p in range(n_sent) ]
		wrapstr = ''.join(p1)
		word_list = word_list + wrapper.wrap(text=wrapstr) + ['']

return word_list

Result: This is just a simple example but it would open up the doors for more things.
Duis tempus convallis urna eget rhoncus. Etiam tempor fermentum leo vitae
tincidunt.

Aenean porta, magna ut dignissim egestas, ligula nisi volutpat tellus, id
imperdiet enim nisl nec est. In hac habitasse platea dictumst.

Phasellus commodo auctor lacus. Phasellus aliquet dui eget dui sagittis dapibus.

Thanks

This is a duplicate. Unfortunately, I don't recall the exact issue number nor its title :flushed: Anyways, searching for issues with the same labels will likely help you :point_right:
https://github.com/microsoft/vscode/issues?utf8=✓&q=is%3Aopen+label%3A"snippets"


Make thiner border for focused links

Summary of the changes (in less than 80 characters):

Added support for Firefox browser
Make thinner border when navigating page with TAB or clicking a link

Addresses https://github.com/NuGet/NuGetGallery/issues/9072

Thanks @MRmlik12! This looks really good. The new borders work for most things, but I noticed that it is now harder to see the borders around the Package Manager tabs (class="package-manager-tab"), especially the selected/active tab.
With the changes:

Original:

I think we should change the color of the border around the package manager tabs, picking something with a good contrast ratio (we target a contrast ratio greater than 3:1 for UI components, and something like #0078d4 seems to have a good contrast ratio with the package manager tabs' colors). We can target this to just these package manager tabs (class="package-manager-tab"), since all the other elements look great with the new changes.

https://user-images.githubusercontent.com/44818681/195198299-f6a2c091-8e07-446b-b3cb-1103244430b3.mp4
@advay26  I changed the border width to 3px and used #0078d4 color. It's seems to be ok.

I changed the border width to 3px and used #0078d4 color. It's seems to be ok.

Yep, this looks good to me.

Done

@advay26 @zhhyu  Ok, I made some changes which you're suggested

Thanks for your contribution @MRmlik12! :blush:


Expose this.equals to custom matchers.

Summary
This was previously exposed through jasmine.matcherUtils.equals. It's now part of the custom matcher API so that it can be used in libraries like Relay.
Test plan
See added test.

Codecov Report

Merging #3469 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3469      +/-   ##
=========================================
+ Coverage    64.1%   64.1%   +<.01%
=========================================
  Files         179     179
  Lines        6647    6648       +1
  Branches        5       5
=========================================
+ Hits         4261    4262       +1
  Misses       2384    2384
  Partials        2       2

Impacted Files
Coverage Δ

packages/jest-matchers/src/index.js
95.45% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccd640...aadd3a3. Read the comment docs.


(Freecad) Fail Safe for Null Versions

@AdmiringWorm @majkinetor @gep13 @pascalberger

Description

This is a Fail Safe for if no Version found to not halt the other streams from being updated, and spacing issue in the code.
Motivation and Context

The error report for the AU Update linked above.
How Has this Been Tested?

Tested locally and on Appveyor
Screenshot (if appropriate, usually isn't needed):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[x] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

Original Location

Original Repository
Open Issues Add the different issues underneath, and tick those that are fixed in this PR

[ ] Issue 1 link
[ ] Issue 2 Link

[ ] Include the link to the opened PR that removes the package from the original location
[ ] The migration guidelines have been followed

:white_check_mark: Package verification completed without issues. PR is now pending human review

I never tried it, but perhaps returning ignore for that stream would be more telling option if it works.

@majkinetor
I'll test it out and report back

@majkinetor @AdmiringWorm
I'm going to close this due to the fact that making it to use the ignore would mean rewriting the whole thing to check the hash being written to the current stream hash.
The FreeCAD developers where able to fix the error that caused the null in the first place.
Thanks all for the input 👍


Vue3: Fix warnings with vue-router

Setup

Rancher version: 2.10 - Vue3
Rancher UI Extensions:
Browser type & version:

Describe the bug

There's a lot of warnings from vue-router due to the fact that we use custom params in our application. According to https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2022-08-22 it's an anti-pattern that is discouraged to use, since we shouldn't define params that aren't defined on the route.
One of the biggest problems is that extensions rely on it, despite "hardcoding" it on their routes, so that the routes become unique and don't get a match with our broad wildcarded routes like:
broad dashboard routes
 /:product/c/:cluster
vs
elemental example
/elemental/c/:cluster
With that in mind, since our architecture needs the product param to work it's magic, in an extension we get a lot of warnings. I believe that dashboard also throws a few warnings as well.

To Reproduce

Run dashboard locally, vue3 edition, and check console

Result
Registering/navigating to a route with these "anti-pattern" params throws warnings to the console
Expected Result

No warnings should be thrown to the console
Screenshots

Additional context

https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2022-08-22
has been advised against for years as it's an anti-pattern in routing for many reasons, one of them being reloading the page lose the params

This is so true; we lose parameters on many pages and it is not possible to access them from the URL or reload. It may be worth to suppress the warning (if possible) or either fix the issue.

As far as I can see there's no way to disable the warnings unless we override the error handling and we start to hack the way out for all our cases.
This would also require a plan to fix the issue, as it will probably be enforced or broken with updates.
@codyrancher also mentioned that this issue has been brought by a version bump, so we may even restore the previous version instead of hacking.

@cnotv My opinion is that either we fix this properly which, worst case scenario, might implicate the change of all route definitions in Dashboard and extensions OR we pin it to an older version and assume the tech debt for the future.
One thing that would be heartbreaking is for us to deal with this in another version and we would have yet another breaking change for extensions in a different version when it could have been dealt with along with other breaking changes.

We will have for sure more breaking changes in the future, next to the list Vite. This one also does not seem to break yet.
It seems to me that there are several operations to do the refactoring:

List known warnings
Identify methods and functions triggering the warning, e.g. based on console report:

router.resolve()
router.replace()
fetchClusterResources(this.$store, METRIC.NODE, { force: true } ); (no idea why log points here)
this.showSearchModal = true; (no idea why log points here)

Search through the code every instance where we do that, based on console report:

shell/components/nav/Type.vue
shell/components/nav/Group.vue
shell/pages/c/_cluster/explorer/index.vue
shell/components/nav/Header.vue

Identify all the undefined (or artificial as they say) parameters, so far just these 2:

resource
product
I have not seen others

List down all the definitions for each parameter or replace them with data binding as they suggest, although I doubt this last one

These are the occurrences in the router where are not defined:

I do not see the issue happening for others such as :namespace or :cluster.
Log

We could try a quick fix for these 2 parameters, although I rather recommend a single issue with proper investigation.
This whole process is way too much for such short notice and for fitting our release planning, so I would rather opt for a version rollback.

I've doubled checked and the warnings do not appear in production builds. That was my biggest concern, as it confuses users and makes support tasks harder.
If there are no functional issues then I'd vote we move this out to 2.11. I don't think there are, @cnotv and @aalves08 can you confirm?

I like my console log to be white and empty 😄, but agree to be for 2.11 at this point.

There are no functional issue that I am aware of, but we haven't investigated if a proper fix would introduce breaking changes on extensions and that's what I am trying to avoid in the near future since we got them on 2.9 and 2.10 and that raises concerns for me.
We can leave this out for now but if  the proper fix introduces breaking changes then I'd say that the milestone needs to be adjusted from 2.11 to another version where we aggregate more breaking changes 🙏

If I got it right, in the current state, you are just not able to retrieve the parameter from the router, but I did not validate the hypothesis. In such case I doubt you need to know what resource or product is or at least not from the router.

@aalves08 a fix shouldn't impact extensions. Routes don't need to change to resolve this, we just need to stop resolving routes with extraneous params as @cnotv pointed out here https://github.com/rancher/dashboard/issues/12128#issuecomment-2401708209.
In fact most of the warnings I saw in both dashboard and harvester are resolved with this experimental change I made (more care needed)
https://github.com/rancher/dashboard/pull/12193
As @richard-cox  pointed out the warning is wrapped to ensure it doesn't make it into production

I'm going to bump this to 2.11. Feel free to bump it back if you think it needs to be fixed sooner.


Remove duplicate FollowRedirects function

Use default value for maxRedirects instead
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

[x] CI passes
[x] Description of proposed change
[x] Documentation (README, code doc blocks, etc) is updated
[ ] Existing issue is referenced if there is one
[x] Unit tests for the proposed change

Oh awesome. Thanks for catching this!


"unlock_notify" support does not cover all needed cases - execute_batch, transaction creation

I have noticed that "unlock_notify" support does not cover transaction creation.
Transaction creation uses InnerConnection::execute_batch which does not support unlock_notify properly.
As a result, in Deferred mode, first write on transaction will fail with 6, "database table is locked",
and in Immediate mode transaction creation will fail with 262, "database table is locked"
instead of waiting for lock to be unlocked when another connection holds a lock.
execute_batch needs to be fixed, maybe by not using sqlite3_exec directly but splitting sql on ; and using existing prepare / execute support that does have unlock_notify implemented properly.

Here is a small program that demonstrates the issue,
repro.zip

See partial fix: #768.
To fix execute_batch, we need to handle SQL tail.

The partial fix above is effective when starting transaction in the correct TransactionBehavior::Immediate mode, thank you.
In the Deferred / default mode the test app still fails, but it is for different reason of deadlock as sqlite starts read only transaction when encountering SELECT first, and then tries to upgrade it to write transaction on INSERT, while other transaction has the read lock already, which is the correct behavior (this test transaction requires the Immediate mode to work properly).
Looking forward for this fix to bubble up to a public release :) 👍

Looking forward for this fix to bubble up to a public release :) 👍

This is probably waiting for #771 and probably #769 (which I need to do, first). As well as anything else that comes in before then... I'd assume a couple weeks?
If you need it urgently a release can probably be cut sooner, though.

Checking in after ~5 weeks...
Could you make a minor release with the fix please?
I'm about to release my project and having an unreleased dependency is looking bad...

Ah, sorry, rough month. Will look into cutting a patch release ahead of all the big changes.

FYI I was hit by the layoffs at mozilla recently, and thus have my hands slightly full for a bit as I figure out where I stand, and so I don't think I'll be able to get a release out soon.
@gwenn might be able to, but they also might be busy too.
Sorry about this, everybody.

I will try on friday or saturday.

Landed there after having issues with unlock_notify on commit()ing a transaction. FWIW it was closed but the reproduction example given above still fails for TransactionBehavior::Deferred. Changing in the code in the zip above:
    // create a transaction to group looking and insert
    // pick one of these:

    //let mut t = c
    //.transaction()
    //.map_err(|e| ErrorContext::new(e, "create transaction".to_string()))?;
    //let mut t = c
    //.transaction_with_behavior(TransactionBehavior::Immediate)
    //.map_err(|e| ErrorContext::new(e, "create transaction".to_string()))?;
    let mut t = c
        .transaction_with_behavior(TransactionBehavior::Deferred)
        .map_err(|e| ErrorContext::new(e, "create transaction".to_string()))?;

Results in:
  Creating database
Thread 2 inserting numbers for 5 sec
Thread 1 inserting numbers for 5 sec
Thread 1 died: ErrorContext { context: "execute insert statement", error: SqliteFailure(Error { code: DatabaseLocked, extended_code: 6 }, Some("database table is locked")) }
Thread 2 ended ok

(Same behaviour with the first line obviously, as Deferred is the default)

See my comment above, it fails for other reason - it's a deadlock when you try to upgrade from read lock to write lock while someone else does the same as you prevent each other from upgrading. In this situation you genuinely need Immediate mode to avoid the deadlock.


Add PostCSS filter

Adds support for PostCSS.

The build failure is on master and is unrelated to this change.

Thanks. Apologies for the delay.

Thanks for merging this @miracle2k . Any plans to cut a release? I'd love to get off of my fork.


Feature/130 impl new master actor

Ref #130
I'm working on re-design actor system.
And it is the first step,

design master actor interface

Coverage decreased (-1.9%) to 84.052% when pulling 82123744b705e210d352f71480fcce4598990841 on feature/130_impl_new_master_actor into 4b79060ca4d56ef400a63e1bf1ec5845e6915282 on develop-0.5.

@Alencion @Doyuni @RulLu16 @yeonnseok
Feel free to review this, if you have any advice.
(til 2020.09.19)
Thx


base64 encoding occurs for application/javascript

I'm not sure if/how I'm getting this behavior but unless I've added this mime type (application/javascript) here:
https://github.com/logandk/serverless-wsgi/blob/master/wsgi.py#L16
All of my javascript files loading in are base64 encoded and break rendering.  I've adding this mime type and everything is fixed.  This seems like a bug unless I'm overlooking something in configuration.

That does seem odd. Even though application/javascript is indeed not on the list of text mime-types, it should not end up being base64 encoded in the response. The WSGI handler base64 encodes the payload and sets the isBase64Encoded, instructing API Gateway to decode the payload, thus sending the original javascript to the client.
I'm fine with adding the mime-type, but I'd like to see a simple reproduction case in order to find the actual root cause. Could you help out by providing a simple configuration that reproduces the error? Thanks!
As a side note, serving assets should ideally happen through S3/CloudFront rather than the Lambda function itself

Appreciate the feedback, sorry for the delayed response, was just working on this over the weekend and have been busy.
I've started with this as a base for a simple flask based serverless application which works fine.  I've then replaced the requirements.txt, app.py and serverless.yml to support flask-restplus which is a REST framework for flask that provides swagger-ui built in, so these js files are built within this package:
http://flask-restplus.readthedocs.io/en/stable/
I've attached a zip that contains the requirements, app.py to support flask-restplus, as well as the updated serverless.yml.
sls flask-restplus.zip
Let me know if this helps, or if I can provide anything further from the project.

Don't worry, I haven't had time to look into this yet myself. Thanks for the attached files, I'll try to reproduce it.

After testing this, as far as I can tell, there is some special handling of application/javascript going on in API Gateway. The other assets are passed along fine as base64 encoded, but the JS files doesn't get decoded. I've added the mimetype, which makes sense either way.


fix unset of user_id

issue fixing for the #49 #51

@vrkansagara Will you fix the PR as per my review comments?  If not, I will fix it myself.

I will fix it myself.


Suggestion: Add a simplified way to link javadoc to relevant JDK javadoc

Expected Behavior
It should be easy to link to the JDK javadocs in a java project's javadoc.
In order to avoid the ceremony of detecting the build's JDK version and correct URL to use (see below), it could come in the form of a linkToJdk() method in Javadoc task's options.
This method would append the correct URL for the JavaVersion.current() to the external links, the same way links(...) appends (but taking the URL from an hardcoded Map keeping the correct one relative to each JavaVersion.majorVersion).
Current Behavior
All links must be manually provided by the user, but in the case of the JDK javadocs there is both some overhead and an issue with differing URL templates between javadocs for Java 8-10 and Java 11+.
Context
There are two problems since JDK11:

If the build's JDK is JDK11 or above, it will fail to link to JDK docs from an earlier version, with the javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/9/docs/api/ are in the unnamed module message.
The JDK javadoc URL cannot simply be inferred from JavaVersion.current().majorVersion, as since JDK11 the template has changed:

https://docs.oracle.com/javase/8/docs/api/
https://docs.oracle.com/javase/9/docs/api/
https://docs.oracle.com/javase/10/docs/api/
https://docs.oracle.com/en/java/javase/11/docs/api/

Steps to Reproduce (for information)
Building a java project with a javadoc link to https://docs.oracle.com/javase/8/docs/api/ with JDK11 should display the first issue. Replacing 8 with 11 will also fail.

too bad this was closed, this would be a useful feature.


avoid TypeError in addSpriteSheet method of TextureManager

Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)

Fixes a bug

Describe the changes below:
The variable texture is set to null on line 1057.   On 1061 we attempt to read its key property which is not available, throwing a TypeError.  Instead we can use the key from the source argument as documented on line 1048.

What code produces the error?

Agree with this PR.
It is clear that an error occurs when the source is an instance of Texture.
key does not exist as a null attribute.
https://github.com/photonstorm/phaser/blob/8c44dffcc7b5e1cfff92c22cfa639068c5f0cdd0/src/textures/TextureManager.js#L1055-L1063

What code produces the error?

Attempting to create a SpriteSheet from an existing texture results in an error.
new Phaser.Textures.TextureManager(this.game)
.addSpriteSheet(
  "key",
  this.textures.get("key"),
  {frameWidth: 300, frameHeight: 300, startFrame:0, endFrame: -1}
); // => got error

👍


Fix for unsaved changes dialog on new pages

Fix for #205
When a DTGE-editor is added to a new created page and the serverside validation fails, the dialog for unsaved changes pops up.
This fix captures the $routeParams.create values, resets it and sets it back after saving.

This is the firstime a made a pull request and submitted changes so maybye it's not the way it usually has to be is done. Sorry!


correcting terminology to reflect physical workflow

Replacing "hyper-V Vms" with "physical machines" as this article is about the physical not hyper V workflow

@emmclare : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for you feedback. This was already fixed in another edit.
#please-close


Add more Invidious instances

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
See Invidious-Instances for the reference.

Please add invidiou.sh too.


Fix a typo and some changes to dashboard template.

Is there a changelog that lists these little things that have changed between versions?
Would've saved me from a small headache. :3

:+1:


wrong default install location on Linux x64

Version: 1.19.1
Platform: Linux, x64

make install installs libuv into /usr/local/lib by default. I could be wrong, but it should be /usr/local/lib64 on x64 Linux.
Note: using ./configure --libdir=/usr/local/lib64 fixes that, but then libtool generates a warning during install.

That's really an autotools issue.  Libuv doesn't set the libdir, it comes from automake.  Since that isn't under our control, I'll go ahead and close this out.

I could be wrong, but it should be /usr/local/lib64 on x64 Linux.

Neither right nor wrong, it depends on the distro.

Turned out this problem is a result of some conflict between CentOS/Redhat/etc Linux distro maintainers and autotools authors. Solution is:

either specify --libdir=/usr/local/lib64 when running ./configure
or create /usr/local/share/config.site file with this content (not sure how this is going to affect 32-bit builds, though):

# /usr/local/share/config.site for platforms that prefer
# the directory /usr/local/lib64 over /usr/local/lib.
test "$libdir" = '${exec_prefix}/lib' && libdir='${exec_prefix}/lib64'

problem happens on x86_64 platform (which supports both 32- and 64-bit binaries) and without explicit instructions autotools always defaults to /usr/local/lib.
Related reading:
https://groups.google.com/forum/#!topic/comp.lang.tcl/VqOYBRteEOI
https://lists.gnu.org/archive/html/autoconf/2009-02/msg00014.html
https://stackoverflow.com/questions/46837809/how-to-get-automake-to-set-libdir-to-usr-lib64-on-dual-arch-linux-platforms
https://bugzilla.redhat.com/show_bug.cgi?id=772997


Bundle config does not canonicalize URLs

If the user fails to add a trailing slash character to a URL when running bundle config the setting is accepted but doesn't work.
$ bundle config https://example.com user:pass
# => BUNDLE_HTTPS://EXAMPLE__COM: user:pass
# ===> this setting is never used

$ bundle config https://example.com/ user:pass
# => BUNDLE_HTTPS://EXAMPLE__COM/: user:pass
# ===> this setting will be used

Fixed in 1.8.1.


Add user, password, path and single signon to Sparkle Launcher

The first cut of the Sparkle launcher's gci connection is incomplete. We need to add user, password, path, and single sign-on checkbox.  The first three are hard coded currently.
Need a file selection window to choose the 'path' which is the location of the 'clientlibs' directory necessary to find the gci libraries. I'm unclear if host user & host password is necessary or if the single sign-on checkbox is sufficient.

User, password, client library path were finished and checked in. https://github.com/GemTalk/Sparkle/commit/0962162f19786b5ddb704e86adbadd685897c164
Password type input fields don't seem to be supported yet in Pharo 9.0/Spec2

Also, could you make direct the default?  It currently defaults to GCI which did not work as I expected (since I expected direct...)

GCI will need to be the default as soon as it works, but we could make direct the default until then.


Dump the computational graph on error

When Chainer raises an exception during forward computation, we can see the stack trace to identify which line of the code is the cause. We do not have any other way to identify the point of failure. It has two drawbacks:

If the code contains some structure that makes it hard to uniquely identify which node in the graph is the bug. For example, if the code contains a loop, we cannot determine the loop counter value from the error.
We cannot identify the node when the error occurs in backward computation, since the backward is not associated to the forward code.

I propose to dump the computational graph on error in forward/backward computation with the erroneous node highlighted. It makes easier to identify the erroneous node.

It's a good idea, but it's a little difficult to use graphviz in a server machine and to show its result. Visualizing in CUI is cool!

Close. Please reopen or make a new one if anyone is still interested in it.


Reset & update password

The logic presented in this PR allows any registered SHOGun2-User to reset their password manually.
This is done by the following workflow:

A user requests a password-reset by sending their account-email to the interface resetPassword.action, e.g.
<EMAIL_ADDRESS>

If the mail really exists, a new PasswordResetToken containing a unique token, expire date and user reference is being generated and persisted.

A special link for updating the password including this token and id will be send to the user, e.g.:
http://localhost:8080/shogun2/login/#passwordchange?id={{token-id}}&token={{token}}

The user will be redirected to a (client-)page to update their password if they follow the link.

The client sends a request to the changePassword.action with the provided token, token-id and password, e.g.:
http://localhost:8080/shogun2/user/changePassword.action?password={{newPassword}}&id={{tokenId}}&token={{token}}

If the token is valid (token exists and is not expired) the user will be authorized to change their password and the token will be deleted.

This looks good @dnlkoch. I have added some comments and would value the feedback of @buehner for certain aspects.
The comments with regard to Exception should not block this, as we need general consensus for this thing.
I am :+1: on merging, but would love to heart @buehner's thoughts first.
Thanks anyhow!

@buehner may also be able to help with some tests, so that coveralls is happy.

I rebased this PR/branch to resolve the conflicts with master. When CI is finished, i will merge and open a follow up PR to address the open issues.

There is a (WIP) follow up PR: #101


Enable benchmark builds in GitHub Actions by default using benchmarks: True

Description
The Consensus Mempool benchmark is the only benchmark executable currently on the main branch, but benchmark builds are disabled by default by cabal. As such, our GitHub Actions workflow also does not build benchmark executables. This PR enables benchmark building in GitHub Actions by default, by adding benchmarks: True in the relevant cabal.project.local file.
Checklist

Branch

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] The documentation has been properly updated
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
[ ] Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers. If deprecating a whole module, remember to add it to ./scripts/ci/check-stylish.sh as otherwise stylish-haskell would un-deprecate it.
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[ ] Self-reviewed the diff
[ ] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[ ] Reviewer requested

I don't think we need the one in cabal.project.local, the one in cabal.project will be used which is fine

I don't think we need the one in cabal.project.local, the one in cabal.project will be used which is fine

Removing the field from cabal.project might have the unfortunate side effect that CI does not build the benchmarks anymore, so might it be better to duplicate it to prevent that case?

bors r+


File upload for dashboard

Description
Api for file uploads
Issue
https://github.com/papercups-io/papercups/issues/181
Screenshots
For frontend updates, please include a screenshot.
Checklist

[x ] Everything passes when running mix test
[x ] Ran mix format
[x ] No frontend compilation warnings

FYI Phoenix just added a native API for file upload on 11/20, dunno if it's useful? https://www.phoenixframework.org/blog/phoenix-live-view-upload-deep-dive

@fkotsian we're not using LiveView, so unfortunately it's not relevant to us 😞


RFC: Shorthand for properties getters

Is it a bad move to make this possible:
var skateDefinition = {
  ...
  properties: {
    myproperty: function () {
      return value
    }
  }
  ...
}

?
I will use it a lot with templates. I tend to use logicless templates and pass attributes along with custom properties. This type of property definition will be significantly more pretty to look at, compared to a lot of:
var skateDefinition = {
  ...
  properties: {
    myproperty: {
      get: function() {...}
    }
  }
  ...
}

I'm closing this. I understand it's not vital and it's yeat another diversion from W3C spec.


ProxyDrawable doesn't respect the original drawable's parent's IsPresent state

If a drawable's parent becomes IsPresent = false, its proxied version will still be drawn to the screen.

Moving to January (low priority as we have a local workaround in osu!)

Adding back to milestone (still causing issues with approach circles in latest master).


Date Parsing assumes local time

The date parsing code assumes that any date in a page is local time, but the server's location may not be the same as the client. Timezone should be specified in the site configuration.

Fixed by commit f90f297fb1f7495f1a40fa711c3ce03d5a8bb5f8