Add DLBCL cell lines data to bundled sample_data

We have mutations from 5 cell lines in the bundled maf. For the same cell lines, the manta bedpe calls should also be included as part of sample_data

They are actually already bundled, see here: https://github.com/morinlab/GAMBLR.data/blob/cf00849e0fbc2e7fb70e08c644bb2f798c7cee18/data-raw/assemble_bundled_data.R#L337-L344


Old CRDs in gateway-operator package

Could I ask for upgrade of CRDs to newest version that contains support to externalTrafficPolicy?

@rkuccf 👋
https://github.com/Kong/charts/releases/tag/gateway-operator-0.2.2 includes the updated CRDs.

Thank @pmalek for quick reply. Unfortunately, after installing it operator has issue with cluster permission and is not able to do action on dataplanemetricsextensions:
W1015 13:56:50.586784       1 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.2/tools/cache/reflector.go:232: failed to list *v1alpha1.DataPlaneMetricsExtension: dataplanemetricsextensions.gateway-operator.konghq.com is forbidden: User "system:serviceaccount:operators:controller-manager" cannot list resource "dataplanemetricsextensions" in API group "gateway-operator.konghq.com" at the cluster scope E1015 13:56:50.586887       1 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.2/tools/cache/reflector.go:232: Failed to watch *v1alpha1.DataPlaneMetricsExtension: failed to list *v1alpha1.DataPlaneMetricsExtension: dataplanemetricsextensions.gateway-operator.konghq.com is forbidden: User "system:serviceaccount:operators:controller-manager" cannot list resource "dataplanemetricsextensions" in API group "gateway-operator.konghq.com" at the cluster scope
Could you look at this?

This will be fixed in 0.2.3 by #1148.
Thanks for staying vigilant 🙇


fix(ci): reconfigure coveralls to not swallow error exit codes

Related to #904 , #898
Summary

In #898 the testing thresholds weren't being met, yet CI didn't catch this. #904 updated the thresholds to get the build passing locally.
I suspect that CI builds passed while local builds failed because the testing script ran by travis piped the text results of jest directly to yarn run coveralls. Due to this, error codes from jest were being swallowed and not causing build failures when coverage thresholds were not met.

Change List (commits, features, bugs, etc)

Modify jest config to output lcov coverage reporter file
Modify travis script to pipe the lcov coverage reporter file to coveralls, instead of directly piping lcov text output from jest.

Some related discussion from others with the same problem on the coveralls tracker
https://github.com/nickmerwin/node-coveralls/issues/230
https://github.com/nickmerwin/node-coveralls/issues/126

Just pushed an updated snapshot file, #914 updated with latest master before merging which needed snapshots regenerated. Failing snapshots slipped through to master due to this same bug

:tada: This PR is included in version 2.42.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Upgrade django

Description:
Upgrade Django from 1.8 into 1.11
New imports / dependencies:

Django 1.11

Codecov Report

Merging #650 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%
==========================================
  Files          81       81
  Lines        2668     2665       -3
  Branches        2        2
==========================================
- Hits         2452     2449       -3
  Misses        213      213
  Partials        3        3

Impacted Files
Coverage Δ

...ps/volontulo/tests/views/offers/test_offer_view.py
100% <ø> (ø)
:arrow_up:

...ps/volontulo/tests/views/offers/test_offer_join.py
100% <ø> (ø)
:arrow_up:

...lontulo/tests/views/offers/test_offers_archived.py
100% <ø> (ø)
:arrow_up:

...ps/volontulo/tests/views/test_edit_organization.py
100% <ø> (ø)
:arrow_up:

...ps/volontulo/tests/views/offers/test_offer_edit.py
100% <ø> (ø)
:arrow_up:

...ckend/apps/volontulo/tests/views/offers/commons.py
100% <ø> (ø)
:arrow_up:

...nd/apps/volontulo/tests/views/test_usersprofile.py
100% <ø> (ø)
:arrow_up:

backend/apps/volontulo/tests/models/test_offer.py
100% <ø> (ø)
:arrow_up:

...nd/apps/volontulo/tests/models/test_offerstatus.py
100% <100%> (ø)
:arrow_up:

backend/apps/volontulo/lib/email.py
100% <100%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8532508...b74e1ef. Read the comment docs.


Implement manual cancellation

Implement the possibility to cancel the task not only by disposal of reference, but also manually.

Current coverage is 93.05%

Merging #7 into master will decrease coverage by -4.05% as of aecf144

@@            master      #7   diff @@
======================================
  Files            6       6
  Stmts          138     144     +6
  Branches         0       0
  Methods
======================================
  Hit            134     134
  Partial          0       0
- Missed           4      10     +6

Review entire Coverage Diff as of aecf144

Powered by Codecov. Updated on successful CI builds.

@rbuussyghin Would you prefer cancel() to be "silent" (ie, no events will be propagated to observers), or should one .Completion event be still sent?

Silently cancel


A few seconds delay on creating a screenshot of a viewer

v1.20.2, 1.21.1
Steps to reproduce:

Open a table
Add some viewer, e.g. a scatter plot
Click the viewer
Press Ctrl/Cmd-C

Expected results: viewer screenshot should be created almost immediately and green message should appear as soon as screenshot is made.
Actual results: There is a few seconds (5-7) delay before the screenshot is created and a message is shown.

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16668


Device tracker?

Hi and thanks for all your work on this. I own an I-PACE and this integration works great!
I see that you already pull in the last trip, would it be possible to add the destination_latitude and destination_longitude to a device tracker for the car? I am aware that a "real" device tracker is not possible since the JRL api don't provide real-time updates. It would still be of great use for me if there was a device tracker for the car. For example; if the car is parked at home and has less than 50% battery in the evening; send a notification. Another use case; I sometimes take the car to work and other times I use public transport. So if the car is in the work zone at 16:00 I could get an update for estimated travel time with my car. And if not; provide me with latest information about the public transport.

This does have a device tracker. Can you check it is there or check that there is not an error in the logs trying to load it.

I thought that I saw in the documentation that it should have a device tracker. Unfortunately I am unable to find it when I look at the device trackers entites in the developer console. I don't find anything in the logs either, the only message I can find is the warning of running a custom component and missing pin for door locking.
I have a sensor "last_trip" wich shows departure and arrival. Is this the one you are thinking of or should I have had an explicit device_tracker enitity as well? If so; I could probably change the loglevel and see if any more information gets logged.

You should have an explicit device tracker in addition to the last trip sensor. Turn on debug logging as see if it gets created. The other thing i think thwt can happen is that you have your HA set not to track new devices. Cant remember how this is set but i think something to do with known devices.yaml.

there is device_tracker.mycar   with latitude and latitude.
and work with Zones if you set up it under Dashboarr/Zone.
can done Automation llike "if the car is in the work zone at 16:00 I could "  BUT it's not real-time so can be some issue.
maybe 1st call service jlrincontrol.update_health_status for the car and then check time&position etc.

@mariwing did you get this working.  Happy to help you resolve if needed.

Thank you both @MZorzy and @msp1974. The thing that fixed it was to go to known_devices.yaml and find the entry and then set track: true. You where correct that I had default = false to track new devices.

look like tracker is changed from device_tracker.rrs to device_tracker.rrs_device_tracker


Getting an error when trying to use this package in applicaton code

I'm using the package like so:
  import { w3cHtmlValidator } from 'w3c-html-validator';

  const html = ReactDOMServer.renderToStaticMarkup(elementWithCollectedStyles);

  const htmlDoc =
    `<!DOCTYPE html>
      <body>` +
    html +
    `</body>
    </html>`;

  const result = await w3cHtmlValidator.validate({
    html: htmlDoc,
  });

which results in the following error:
/Users/rein/workspace/brightbook-2/node_modules/pirates/lib/index.js:141
      oldLoader(mod, filename);
      ^
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/rein/workspace/brightbook-2/node_modules/w3c-html-validator/node_modules/chalk/source/index.js from /Users/rein/workspace/brightbook-2/node_modules/w3c-html-validator/dist/w3c-html-validator.umd.cjs not supported.
Instead change the require of index.js in /Users/rein/workspace/brightbook-2/node_modules/w3c-html-validator/dist/w3c-html-validator.umd.cjs to a dynamic import() which is available in all CommonJS modules.
    at newLoader (/Users/rein/workspace/brightbook-2/node_modules/pirates/lib/index.js:141:7)
    at require.extensions.<computed> [as .js] (/Users/rein/workspace/brightbook-2/node_modules/ts-node/dist/index.js:851:20)
    at /Users/rein/workspace/brightbook-2/node_modules/w3c-html-validator/dist/w3c-html-validator.umd.cjs:18:37
    at /Users/rein/workspace/brightbook-2/node_modules/w3c-html-validator/dist/w3c-html-validator.umd.cjs:8:17
    at Object.<anonymous> (/Users/rein/workspace/brightbook-2/node_modules/w3c-html-validator/dist/w3c-html-validator.umd.cjs:14:3)
    at Module._compile (/Users/rein/workspace/brightbook-2/node_modules/pirates/lib/index.js:136:24)
    at newLoader (/Users/rein/workspace/brightbook-2/node_modules/pirates/lib/index.js:141:7)
    at require.extensions.<computed> [as .cjs] (/Users/rein/workspace/brightbook-2/node_modules/ts-node/dist/index.js:851:20)
    at Object.<anonymous> (/Users/rein/workspace/brightbook-2/app/javascript/scripts/print-cli/renderHtml.tsx:33:30)
    at m._compile (/Users/rein/workspace/brightbook-2/node_modules/ts-node/dist/index.js:857:29)
    at newLoader (/Users/rein/workspace/brightbook-2/node_modules/pirates/lib/index.js:141:7)
    at require.extensions.<computed> [as .tsx] (/Users/rein/workspace/brightbook-2/node_modules/ts-node/dist/index.js:859:16) {
  code: 'ERR_REQUIRE_ESM'
}

Any help would be greatly appreciated.

Is it practical to upgrade your project to 100% ES modules?
w3c-html-validator includes distribution files for both ES modules and CommonJS:
package.json
   "exports": {
      ".": {
         "import": "./dist/w3c-html-validator.js",
         "require": "./dist/w3c-html-validator.umd.cjs"
      },
      "./": "./dist/"
   },

However, it looks like one of the dependencies does not support CommonJS anymore.  At this point, CommonJS is so old and obsolete that it would be weird to spend time on it.  If anyone puts up a pull request to fix CommonJS support, I'll merge it.  Otherwise, it probably makes sense to drop support to avoid confusion.


message number fix

Do not send empty string on shutdown
Fix msgN to match the order in which the messages are queued

@lukechurch

LGTM! Thanks for the catch


Better long-lived token support

I understand that long-lived tokens are supported by writing it directly to the config file but I don't want to put sensitive data in the config (as it's exposed publicly).
The UI could ask for the token and store it in the local storage or cookie like it did previously with plain passwords.
Flow-wise, when not logged in, it could open an overlay of some sort that would give option to either login through HA or enter token manually.

This is up to the user to make a decision. A simple window.prompt with saving data to  localStorage would be sufficient. Same can easily be defined in an anonymous function.

Are you suggesting that all this is implemented in config file?
A lot can be done through config file (as history showed) but where do draw the line in terms of ease of use? Is it a project for developers or normal users? :) I wouldn't mind this being solved in core, with some nice and simple UI.

TileBoard is actually for developers rather that users to be honest hence the relative code simplicity and hack-ability.

Please also remember that long-lived tokens were actually never meant for normal users. We handle refreshing tokens for normal users.

Guess you are right, given that it's not easy to configure tiles in the first place.
Feel free to close if you don't agree that core should handle that.


Calls should reject promise if target window is unresponsive

Is your feature request related to a problem? Please describe.
If I call A() on a child window, the target window may become unresponsive while running A() and the caller is stuck waiting on the result of A().
Describe the solution you'd like
I'd like for the call to fail after a set amount of unresponsive time (e.g. 2 seconds).
Describe alternatives you've considered
I can manually implement a simple ping() method on the target and have the caller ping it periodically to check if the target window is still responsive. This is not ideal because we have a complex architecture with many target windows and we'd have to implement ping() on all of them. I think changes in post-me are required for this, I can do it myself if you don't have time but any guidance is appreciated.
We have the target windows catching errors and onunload events and those are handled properly, but there are situations in which those aren't triggered.
Additional context
Related but different is a timeout parameter for calls. We don't want calls to timeout for our specific use case because we expect some calls to take an indefinite amount of time. We just want to check that the window continues to be responsive.

I think an initial approach could be to add an optional timeout field to the existing customCall()'s options parameter.
For example, calling the method "foo" with no parameters, would look something like this:
remoteHandle.customCall('foo', [], {timeout: 1000});

Additionally, we could introduce a new method similar to setCallTransfer(), so that the timeout parameter can be set just once per method instead of passing it with each method call.
For example:
remoteHandle.setCallTimeout('foo', 1000); // Set timeout just once
remoteHandle.call('foo'); // Each call to foo will reject after 1000ms

Let me know if the approach proposed here would be enough to solve your use case, I can work on a fix later in the week (unless you would like to give it a shot!).
PS:
I'm trying to understand what you mean exactly in the "Additional context" paragraph: are you suggesting for post-me to have and internal polling mechanism to verify if the other end is still responsive?

I'm trying to understand what you mean exactly in the "Additional context" paragraph: are you suggesting for post-me to have and internal polling mechanism to verify if the other end is still responsive?

Yes, apologies if I wasn't clear. When I see "timeout" I think: I call A(), it runs for 2 seconds, after which the call is not returned so I consider it to be a timeout. I tried to say that this behavior is specifically not what is desired (though I can see use cases for it).
The behavior I want (and I think is more useful generally for post-me comms) is: I call A(), it runs for some unspecified amount of time (say two hours) during which it is responsive but the call is not returned, but then fails to respond to polling for 2 seconds -- this is what I want to consider a "timeout". Not sure if that is the correct terminology here (I'm just getting started on the front-end side of the stack).
I like both of your suggestions (assuming "timeout" is a good term there). For our use case being able to set the "timeout" in both customCall and setCallTimeout may be useful, depending on the needs of the caller 👍
Thanks for the quick response 🙂 Once we've settled on the API, I may have time to attempt the fix myself. I'll let you know when I start so we don't duplicate work.

@m-cat  Any updates on your end? Let me know if you run into any issues or need some help

Hey @alesgenova, I haven't started yet because I wasn't sure if you agreed with the suggestion. Anyway, I can try to start within a week or so, but got quite a bit on my plate atm


Add Videos to Magento Demo

What is the motivation for adding / enhancing this feature?
In order to demo and test the ability to have videos in product gallery from #2388 and PR #2433 would it be possible to have some videos added to the VS Demo Magento shop? Adding at least 1 from YouTube and Vimeo each would be great for testing and demoing.
What are the acceptance criteria

At least 1 video added to a product gallery from YouTube and from Vimeo

Can you complete this feature request by yourself?
No

This should be done if #2433 will be merged to develop.

@rain2o please contact me on<EMAIL_ADDRESS>so I could send you magento demo admin access data

@rain2o did you managed to add these videos?
Please provide products to test before closing it:)

@patzick Not yet. I emailed @pkarw to request the credentials, just waiting for those.

Also mage2vuestorefront#71 will need to be implemented in order to import the video data.

I have added a video from each source on the Luma Yoga For Life product (http://demo-magento2.vuestorefront.io/luma-yoga-for-life.html & https://demo.vuestorefront.io/p/240-LV09/luma-yoga-for-life). I tried to find sample videos of the products but didn't have a lot of luck so used a VS demo video for YouTube.
The Vimeo one isn't loading when testing on the Luma theme, but I think it's because the Magento demo isn't using SSL, because it should work with no configuration. Should work once it gets ported to VS.
The video data can be pumped into VS using the changes from mage2vuestorefront#75.


Generate ComicInfo.xml for volumes as well

The idea
I noticed that the ComicInfo.xml is created for cbz format, but not for cbz-volume.
Since volumes are more similar to the usual full books I put on my device, I'd love to use the cbz-volume option, also to reduce clutter.
But calibre (using the EmbedComicMetadata plugin) relies on the ComicInfo.xml file to find out metadata like the name of author and series, which is currently not created for volumes.
Why this feature should be added to the app ?
This would make it much nicer to read manga on e-readers in terms of whole volumes, instead of chapters, which can be only few pages at times.

Hello, ComicInfo.xml file has been added into cbz-volume and cbz-single formats. You can try it now by installing development version.
Installation method with pip & git:
pip uninstall mangadex-downloader
pip install -U git+https://github.com/mansuf/mangadex-downloader.git@0d0e724975f8ec963f46d9a9dea2e58d6f6adf19

Installation from Github Release:
You can download it from here (in "artifacts" section) -> https://github.com/mansuf/mangadex-downloader/actions/runs/8518332683


Replace Flux.Data with MLDatasets

WIP: Need to update all examples.

The test is failing because calling MNIST.traindata() from MLDatasets for the first time asks the user
Do you want to download the dataset from ["https://ossci-datasets.s3.amazonaws.com/mnist/train-images-idx3-ubyte.gz",
"https://ossci-datasets.s3.amazonaws.com/mnist/train-labels-idx1-ubyte.gz", "https://ossci-datasets.s3.amazonaws.com
/mnist/t10k-images-idx3-ubyte.gz", "https://ossci-datasets.s3.amazonaws.com/mnist/t10k-labels-idx1-ubyte.gz"] to "/home
/runner/.julia/datadeps/MNIST"?
[y/n]

Not sure how I can push y to input stream here. There also doesn't seem to be a force download option.

@ayush-1506  Please see https://github.com/JuliaML/MLDatasets.jl/issues/63 for a solution.

@ablaom Yes, updated the notebooks and readme. Would love a review.

Codecov Report

Merging #141 (1ef2661) into dev (0387c2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #141   +/-   ##
=======================================
  Coverage   92.01%   92.01%
=======================================
  Files           6        6
  Lines         263      263
=======================================
  Hits          242      242
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0387c2c...1ef2661. Read the comment docs.

@ayush-1506 If I set execute=true in the second last line of mnist.jl, to generate a notebook including cell evaluations, then I get some issue with the de-serialization.
[warn | JLSO]: UndefVarError: ##318 not defined
[warn | JLSO]: UndefVarError: ##318 not defined
┌ Error: error when executing notebook based on input file: `~/Dropbox/Julia7/MLJ/MLJFlux/examples/mnist/mnist.jl`
└ @ Literate ~/.julia/packages/Literate/XP0eh/src/Literate.jl:607
ERROR: LoadError: LoadError: MethodError: no method matching Machine(::Vector{UInt8}; cache=true)
Closest candidates are:
  Machine(!Matched::M, !Matched::AbstractNode...; cache) where M<:MLJModelInterface.Model at /Users/anthony/.julia/packages/MLJBase/gcxd6/src/machines.jl:32
in expression starting at string:1
when executing the following code block

```julia
mach2 = machine(joinpath(DIR, "mnist_machine5.jlso"))
predict_mode(mach2, images[501:503])

Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:33
  [2] execute_block(sb::Module, block::String)
    @ Literate ~/.julia/packages/Literate/XP0eh/src/Literate.jl:720
  [3] execute_notebook(nb::Dict{Any, Any})
    @ Literate ~/.julia/packages/Literate/XP0eh/src/Literate.jl:623
  [4] (::Literate.var"#34#36")()
    @ Literate ~/.julia/packages/Literate/XP0eh/src/Literate.jl:604
  [5] cd(f::Literate.var"#34#36", dir::String)
    @ Base.Filesystem ./file.jl:106
  [6] jupyter_notebook(chunks::Vector{Literate.Chunk}, config::Dict{String, Any})
    @ Literate ~/.julia/packages/Literate/XP0eh/src/Literate.jl:603
  [7] notebook(inputfile::String, outputdir::String; config::Dict{Any, Any}, kwargs::Base.Iterators.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:execute,), Tuple{Bool}}})
    @ Literate ~/.julia/packages/Literate/XP0eh/src/Literate.jl:540
  [8] top-level scope
    @ ~/Dropbox/Julia7/MLJ/MLJFlux/examples/mnist/mnist.jl:225
  [9] include(fname::String)
    @ Base.MainInclude ./client.jl:444
 [10] top-level scope
    @ REPL[2]:1
 [11] top-level scope
    @ ~/.julia/packages/CUDA/3VnCC/src/initialization.jl:81
in expression starting at /Users/anthony/Dropbox/Julia7/MLJ/MLJFlux/examples/mnist/mnist.jl:225

Are you able to reproduce this issue, and if so, investigate?
I haven't tried working directly with the notebook and evaluating, just running the Literate script.

Update: This is not an issue if I just run the notebook by hand. I'm going to update the notebook by hand for now, merge this PR and open a separate issue.

@ayush-1506 Thanks!


Query functions done.

Codecov Report

Merging #48 (37c3c9c) into master (1121a05) will increase coverage by 1.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   95.66%   97.65%   +1.99%
==========================================
  Files           5        5
  Lines         392      427      +35
==========================================
+ Hits          375      417      +42
+ Misses         17       10       -7

Impacted Files
Coverage Δ

service/model.py
100.00% <100.00%> (ø)

service/route.py
100.00% <100.00%> (+4.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1121a05...37c3c9c. Read the comment docs.

Query functions are done.
TO DO:
Some route path for /items need to be changed into /suppliers/items

Query functions done.
Some route path need to be changed more RESTFul


Add RefreshToken model to the list aliases

Closes #38 , fixing issues with the package usage alongside laravel 6.
This description is possibly not descriptive, if you need more information, please ask.

@esron did you test the changes?

We are using this fork in a production product:
https://ligasaudavel.com/

Thank you both


Why Ebedded  VLC on Microsoft Windows,  background  is transparent.

I wrote a program under Microsoft Windows ,  which embed a LVC in a GTK DrawingArea .  It seems OK  except that the background  around video (the gap between video and others)   is transparent.
I'v connect draw event to a function  and use cr.SetSourceRGB(0, 255, 0)/cr.Paint() to draw background. When I click to maximize window,  sometimes I can see the green  background ,  but at  most time it keep transparent.
BTW: same program is All OK under linux

func main() {

	// Initialize libVLC module.
	err := vlc.Init("--quiet", "--no-xlib")
	assertErr(err)

	gtk.Init(nil)

	Window, _ = gtk.WindowNew(gtk.WINDOW_TOPLEVEL)
	hPanel, _ = gtk.BoxNew(gtk.ORIENTATION_HORIZONTAL, 0)

	playerArea, _ = gtk.DrawingAreaNew()
	hPanel.PackEnd(playerArea, true, true, 0)

	Window.SetTitle("销售终端")
	Window.SetDefaultSize(1024, 768)
	Window.Connect("destroy", gtk.MainQuit)

	playerArea.Connect("draw", func(playerArea *gtk.DrawingArea, cr *cairo.Context) {
		cr.SetSourceRGB(0, 0, 0)
		cr.Paint()
	})

	// Create a new player.
	player, err := vlc.NewPlayer()
	if err != nil {
		log.Println("Cant' Attach video player", err);
		return
	}

	_, err = player.LoadMediaFromPath("..\\selpos\\install\\videos\\11111-0-0-11111.mp4")
	if err != nil {
		log.Println("Cant' load video", err);
		return
	}

	playerArea.Connect("realize", func(playerArea *gtk.DrawingArea) {
				fmt.Println("realize");
				// Set window for the player.
				playerWindow, err := playerArea.GetWindow()
				assertErr(err)
				setPlayerWindow(player, playerWindow)
				assertErr(err)
				player.Play()
	})

	Window.Add(hPanel)
	Window.ShowAll()

	gtk.Main()

}

I found some hint : When I  add a GtkHeaderBar to the mainWindows It  would OK. Why?

Hi @gallex. I'm not sure what the issue is. Seems more like a GTK problem. You are right, the issue does not manifest with a custom GtkHeaderBar. I've noticed that setting window.SetDecorated(false) also solves the issue (although there's no title bar after that). I'm not sure how the default title bar (or decorations) affects the drawing area. It's as if it captures expose events and prevents them from getting passed to the drawing area.
I'll investigate this more and let you know.

@adrg thans for your reply. Fortunately, I can use your solution to solve my problem( I just do not need any title).

It's as if it captures expose events and prevents them from getting passed to the drawing area. I'll investigate this further and let you know.

I am sure  draw event is captured case I have print  logs in the  function .


Release-testing: v7.1.6 tiflow repo CI trigger

CI trigger to run FT on release-7.1 branch

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/retest

/test ?

/test cdc-integration-kafka-test cdc-integration-mysql-test cdc-integration-storage-test dm-compatibility-test dm-integration-test engine-integration-test
This is an automated do-test comment triggered by a release-testing robot.
Every evening at 11 PM, if there are updates to the PR in the repo, then perform the `/test CI FT` test.
Commented on: 2024-11-13 11:27:53.

/test cdc-integration-kafka-test cdc-integration-mysql-test cdc-integration-storage-test dm-compatibility-test dm-integration-test engine-integration-test
This is an automated do-test comment triggered by a release-testing robot.
Every evening at 11 PM, if there are updates to the PR in the repo, then perform the `/test CI FT` test.
Commented on: 2024-11-13 21:54:26.

/test cdc-integration-kafka-test cdc-integration-mysql-test cdc-integration-storage-test dm-compatibility-test dm-integration-test engine-integration-test
This is an automated do-test comment triggered by a release-testing robot.
Every evening at 11 PM, if there are updates to the PR in the repo, then perform the `/test CI FT` test.
Commented on: 2024-11-14 21:03:10.

/test cdc-integration-kafka-test cdc-integration-mysql-test cdc-integration-storage-test dm-compatibility-test dm-integration-test engine-integration-test
This is an automated do-test comment triggered by a release-testing robot.
Every evening at 11 PM, if there are updates to the PR in the repo, then perform the `/test CI FT` test.
Commented on: 2024-11-15 21:08:29.

/test cdc-integration-kafka-test cdc-integration-mysql-test cdc-integration-storage-test dm-compatibility-test dm-integration-test engine-integration-test
This is an automated do-test comment triggered by a release-testing robot.
Every evening at 11 PM, if there are updates to the PR in the repo, then perform the `/test CI FT` test.
Commented on: 2024-11-20 17:13:13.


[v1.0][W14-B3] Campus Recruiter

@mhq199657 @kexiaowen @Ang-YC

End of v1.0 milestone

Hello @kowshik-sundararajan
Thanks for the review! We'll update the changes to the docs accordingly 😄
All PRs did pass both Travis and AppVeyor builds actually before we merge them. One failed due to decreased coverage and some were pending due to some anomalies in Coveralls.
The Coverage build was passing when we checked it manually but the PR check was not updating in Github so we just merged the PRs after confirming that the Travis/AppVeyor builds passed.
I did a reset and the Coveralls check is working fine now!

Sweet @tanhengyeow!
I should have taken a closer look 🙂

Dear @kowshik-sundararajan The Travis Build fails because it is not running on our latest code. We have reflected this problem to the TA during yesterday's tutorial.

Dear @kowshik-sundararajan Travis still does not run on our code. Could you help us fix this problem? The Travis CI build failed notification is annoying especially when our code actually does not fail.

As a favour, could you add a comment every weekend to summarize what are the changes that have been made? This would make it easier for me to review the changes.
About Travis, let me look into it and see what can be done.

Hi @kowshik-sundararajan
Thanks for the review!
Here is the summary of work done for our v1.1 milestone:

Added an optional resume field to each student
Added a rate command and ratings field to each student
Improved the find command to extend to all fields
Added a interview command and interview field to each student
Updated documentation for v1.1

Each PR has a write up that explains the changes in depth :smile:

Great! Additionally, if you want me to review your code for quality checks, tag me in the PRs submitted to your repo.
Note for next week: Each member of the team should have at least 1 merged PR of their enhancement as v1.2 release. (It doesn't have to be perfect code, but something that works).

Summary of changes for v1.2
Hongqiang:

Improve filter command to make it always filter the current view of the list instead of all the persons in HR+.
Support advanced filter predicate strings, in the form of e, a - b, c, d - f (single or interval connected with commas). Logical predicates separated with comma are ORed.

Xiaowen:

Add overall score for rating which is calculated as the average of technical skills score, communication skills score, problem solving skills score and experience scores.
Add deleteRating command that deletes the rating of the person at the specified index.

Heng Yeow:

Add a Major class and support adding major in the add command. Make this field editable as well.
Improve find command by adding new predicate and predicate test for field major. Refactor methods in FindCommandParser to FindUtil.

Yee Chin:

Revamp the interface to make it more intuitive and clean, allowing users to find the necessary information easily. (Details can be found in the PR created)

Summary of work done for v1.3
Hongqiang:

Added status field
Improve filter command to support multiple fields

Heng Yeow:

Added Grade Point Average field
Improve find command to support wildcard search

Xiaowen:

Added Job Applied field
Added rating_sort command to sort current list of students based on overall rating

Yee Chin:

Added Profile Image and Comments field
Made user interface more responsive

@kowshik-sundararajan


Add more information to README about changes on this fork

I think it would help to have a bit more info on the README to explain what is different about this fork compared to the original repo.
What do you think about having a condensed changelog, to show the various issues that have been fixed? This could help give other developers or users a clearer sense of what has changed, and give them confidence in what has not changed (e.g. that the API remains the same).
It could either be a summary in the README, or perhaps a separate changelog. I'm inclined to go for the main README for visibility. I'd recommend the standard format from https://keepachangelog.com/en/1.0.0/

Agree that we should have a changelog. That should be part of the pre-requisites before the next release.
I'm more inclined towards a separate changelog file though. And I'ld suggest putting the changelog into the docs.
I prefer the README to be a little leaner (just my preference).
The changes that we've made thus far are mostly bug fixes and not noteworthy enough (IMO) to be placed in the README. If we introduce new features or change the API, then I think we can highlight it in the README.
Maybe see https://github.com/yt-dlp/yt-dlp#readme for an example (I do think their README is way too long, but just trying to illustrate the point that they, as a fork repo, is only highlighting new features).

I'm open to having something short in the README. It could be nice to highlight the main improvements in the README (even if they are comparatively minor), like fixing warnings, tests, and setup.


Fixes for Connection Display Name

Thanks for submitting a Pull Request to this project.
This template will help you create your pull request.
Please make sure you have read the Contribution Guidelines.
To aid community reviewers in reviewing and merging your PR, please take the time to run through this checklist:
DELETE THIS LINE AND ABOVE
[Replace this with a description of your pull request]

[ ] Change details added to Unreleased section of changelog.md?
[ ] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[ ] Examples updated for both the single server and small farm templates in the examples folder?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and Integration tests created/updated where possible?

This change is

Codecov Report

Merging #814 into dev will decrease coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##             dev    #814   +/-   ##
=====================================
- Coverage     91%     91%   -1%
=====================================
  Files        111     111
  Lines      10739   10731    -8
  Branches       1       1
=====================================
- Hits        9847    9811   -36
- Misses       891     919   +28
  Partials       1       1

You PR basically reverts the changes in my previous PR, which was a fix for issue #804 . There the resource tried to create the connection over and over again. If we would like to enable to use the dot in the name, we should also counter for the scenario where new connections will be created by DSC.

@Yorick yes, I gave some thoughts around that at first, but really, how can we tell if the connection was created by hand or by DSC?  Should the Set-TargetResource create the connection, then performs a check against the created name and the name passed as a parameter and rename it if they don't match?
So for example, if the connection needs to be "contoso.com", DSC will create it as "contoso-com", and then Set-TargetResource would rename it back to "contoso.com"? This would handle the Set, and the Get would simply check for an exact match based on the name received.

The issue is that the "Add-SPProfileSyncConnection" cmdlet does not have an Name parameter. Internally it uses the Forest parameter, replacing the dot with a dash (I verified by looking at the code). So OOTB SharePoint acts differently when you create a connection from the GUI (you can specify a name) and by PowerShell (you cannot specify a name).
I think we should cater for both situations. Maybe by first checking if the specified name exist and if it does not, check for the Forest name where the dot is replaced by dash. But this does mean there could be a situation where you have two connections: One with dots and one with dashes. This resource is then unable to handle both situations......

Reviewed 2 of 2 files at r3.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


doc: make help install more explicit if issue with tensorflow installation

write something like:
If you experience the following error:
Could not find a version that satisfies the requirement tensorflow>=XXX (from axondeepseg) (from versions: )...
You will need to manually install TensorFlow dependency by following the instructions from the TensorFlow website.

make it a warning, not a note.
then, tell user to re-run pip install...

Already resolved in commit 21fae060e7192a669154887416e86af7472f648f
(full link: https://github.com/neuropoly/axondeepseg/commit/21fae060e7192a669154887416e86af7472f648f).


Fixed installation of R packages

User no longer needs to run 'make results' twice in order to get the necessary R libraries installed if they don't already have them.

It would be nice if we followed the other code convention of using {} on their own lines. +1 on the general idea.

No problem, updated the formatting.

+1 to merge, thanks.


Having trouble running go get github.com/myodc/micro

I am using ubuntu 14.04, go version 1.4
Here are the error details:
github.com/myodc/go-micro/registry/kubernetes
/home/abhi/.gvm/pkgsets/go1.4/global/src/github.com/myodc/go-micro/registry/kubernetes/kubernetes.go:60: item.Spec.PortalIP undefined (type "github.com/GoogleCloudPlatform/kubernetes/pkg/api".ServiceSpec has no field or method PortalIP)
/home/abhi/.gvm/pkgsets/go1.4/global/src/github.com/myodc/go-micro/registry/kubernetes/watcher.go:29: svc.Spec.PortalIP undefined (type "github.com/GoogleCloudPlatform/kubernetes/pkg/api".ServiceSpec has no field or method PortalIP)

Hi, looks like there was a change in the kubernetes api package. Should be fixed now.


Make GGIR run easier on machines not configured for UK/US

This PR:

Adds parameters dec_reports and dec_config to complement sep_reports and sep_config that already existed. I have tested this on Dutch configured laptop and it now works smoothly, fixes #1048.
While doing this I also tidied up the way params_output is passed on to some of the functions.
Adds Sys.setlocale("LC_TIME", "C") in a more systematic way. For part 2 and 5 it turned out to be necessary to also set this inside the functions that are run in parallel, because somehow R does not pass on this setting to the parallel process, fixes #1047.
I observed that parameter week_weekend_aggregate.part5 was not used, I have now made sure it is actually used.
Parameters sep_reports and sep_config, were not checked for being a character by check_params, now also fixed.

Checklist before merging:

[ ] Existing tests still work (check by running the test suite, e.g. from RStudio).
[ ] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[x] Updated or expanded the documentation.
[x] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[ ] Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

@jhmigueles I tested this on a Dutch laptop and have now asked the group in Paris to test it on their computer. However, maybe you want to inform the group you developed the sep_reports argument for to start using these new dec_* parameters and get them to test it to?
@l-k- Previously I was setting LC_time to C in every specific instance of GGIR code where language is important, with this PR I am attempting to set it more broadly such that we do not always have to worry about language issues. May I ask you to have a look at how I now enforce LC_time. More specifically, I am not sure how to pass on system settings via foreach, so I decided to re-enforce it also inside the subfunctions main_part2 and main_part5 inside g.part2 and g.part5. Does this make sense to you or can you see a more elegant way to do this?


move RELEASING.md to a GitHub wiki

Move RELEASING.md into a Wiki as it would be so much easier to keep up to date and in my opinion changes to it shouldn’t require a 2 person review flow
Wiki can be found at https://github.com/adoptium/temurin-build/wiki/Temurin-Release-Guide

I agree, I'm wathcing the diffs too. Also the changes to docs comes together
with code changes.
I think there is a way to keep wiki in sources, and so to make PRs mandatory
for them, and still have wiki as read only view on them. Cant his be set up?
--
Mgr. Jiri Vanek
@.***
---------- Původní e-mail ----------
Od: Stewart X Addison @.>
Komu: adoptium/temurin-build @.>
Kopie: Subscribed @.***>
Datum: 11. 10. 2024 15:23:02
Předmět: Re: [adoptium/temurin-build] move RELEASING.md to a GitHub wiki (PR
#3993)
"
@sxa commented on this pull request.
I quite like having the reviews so I notice when changes are made, but I
appreciate that's not a compelling reason.
Since it's quite a formal process maybe there's some advantage to having it
formally reviewed when changes are made. So I'll stay neutral and let two
other people review this one ;-)
Good shout on making sure we don't just delete the file and replacing it
with a link to the new location though.
BTW there is one part of this file that I think has some formatting oddities

if you find them while reading through the rendered output it would be
good to correct them.

—
Reply to this email directly, view it on GitHub
(https://github.com/adoptium/temurin-build/pull/3993#pullrequestreview-2362801918)
, or unsubscribe
(https://github.com/notifications/unsubscribe-auth/AAWFCS4DVKXPVEWDQDHWTJLZ27GLFAVCNFSM6AAAAABPY5IHFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRSHAYDCOJRHA)
.
You are receiving this because you are subscribed to this thread. Message
ID: @.***>
"

I think there is a way to keep wiki in sources, and so to make PRs mandatory
for them, and still have wiki as read only view on them. Cant his be set up?

I guess the point I'm making is that in my opinion PRs shouldn't be mandatory, we shouldn't be adding hurdles to people who want to improve our docs. For what it's worth, Wikis do still have revision history so if we used meaningful updates this might be okay? https://github.com/adoptium/temurin-build/wiki/Temurin-Release-Guide/_history

Tahts a good point. To full-fill both - no PR for doc only, and have doc change part of the PR is hard one. I would still vote the second option. As the doc-only change can have very narrow and stright forward review. But it is narrow fight 49:51:( Good luck!

Yeah same view as me then :-) Ultimately both are viable and as a "part of the release process" document I like it being under full change control but not enough to block this
The releasing doc is a bit special as it covers various areas of the project and quite often any changes aren't directly aligned with stuff in this repository as well so you can't necessarily put any code change and doc change into the same PR. And, of course, this is a doc which we frequently perform updates to for clarifications etc. independent of actual code changes to avoid any undue stress for people following the steps in here during the busy release cycles.
There may be a valid argument for using a wiki in the adoptium/temurin repository instead of in build since it's not just covering things in the build repo 🤷🏻

I agree, I'm watching the diffs too

As George says the pages still have change history, and I would strongly recommend that anyone updating this way uses the comment box at the bottom so there is a meaningful change log, similar to commit messages.

I can move the wiki to the adoptium/temurin repo if you'd prefer it to be located there?

I can move the wiki to the adoptium/temurin repo if you'd prefer it to be located there?

@sxa can you please confirm if you'd prefer I move the wiki to the temurin repo?

I can move the wiki to the adoptium/temurin repo if you'd prefer it to be located there?

@sxa can you please confirm if you'd prefer I move the wiki to the temurin repo?

My (slight) preference is still slightly to leave it as a file in the main repo, but if we're moving it in into a wiki I'd definitely prefer it to be put into the temurin repo alongside the checklists. Having said that I'm pretty neutral on all of it so it would be good to get others' opinions which might be stronger than mine ;-)

I'm good with moving this.

This document should always have regular reviews for readability, and I think having it in wiki form makes said reviews harder.
I recommend either:

Keeping the document in a Github repo and reducing the number of reviews to 1.
And/Or
Having the wiki document be an "additional notes" document for gotchas, situational tips on best practices, etc.

@gdams will need a rebase.


proposal: encoding/xml: Return a SyntaxError for unmatched start elements at EOF

I propose to make the xml.Decoder's Token routine fail with a syntax error, when the XML input contains unmatched start elements and the end of the stream.
Background
The xml.Decoder's Token routine returns successfully for input even if the XML content includes not properly closed start elements. For example, the following input
<root><bar></bar>

causes Token to return nil, io.EOF at the end of the stream, despite the unmatched "root" start element.
In my understanding Token should reject syntactically incorrect XML like this with an error.
This is also indicated by the following statement of the godoc of Token (emphasis mine)
Token guarantees that the StartElement and EndElement tokens it returns are properly
nested and *matched*: if Token encounters an unexpected end element, it will return an
error.

Proposal
I propose that a xml.Decoder's Token routine should return xml.SyntaxError for dangling start elements at the end of the stream. To do so, I have a CL ready for submission. Should this go through the proposed proposal process? Should this wait until Go 1.6?
Working example: http://play.golang.org/p/Fs6NPvDLu0
Verified on Go version: 1.4.2 and 1.5 development version (go version devel +751eef8).
[edited for clarity]
[edited to serve as a proposal for the proposal process]

@nigeltao Who could I ping for a comment? I can send a CL over for discussion but would prefer to first get feedback if this should even be fixed (and if so, what's the release target).

The Decoder.Token doc comment, which you linked to, does make your proposal sound reasonable. CC'ing @rsc.
As for the proposal process, TBH I'm as new to it as you are, but submitting a proposal seems fine.
In any case, this should wait until 1.6.

I think we should try this. However, it changes the behavior of existing programs, so we will need to call this out very explicitly in the release notes.

Great! I plan to send a CL over the weekend. Please let me know if you would like to see a design doc first.

The CL lives at https://go-review.googlesource.com/#/c/14315/


Integrate with HACS

Make this repo installable via HACS  by slightly changing the directories structure and adding a hacs.json file.

Thanks for the good work !
Last time I check to integrate with HACS, I thought it was harder to do. Let me check the HACS doc

These are the minimal changes to make the component installable via hacs.

Well yes, I remember now that I read the doc. There are 2 PRs to do (one to HACS and one to brands repository, for the logo). And there are lots of rules to fulfil in order to be accepted

There are 2 PRs to do (one to HACS and one to brands repository, for the logo). And there are lots of rules to fulfil in order to be accepted

That is required if you want this component to be added to the official HACS integrations list.
However, it is possible to install the component by adding a custom repository in HACS. hacs.json is the only requirement in this case.

better will be official integration in HA.... no HACS....

Just one last thing: I think render_readme should be set to true, otherwise there is no doc, see:

(this is basically saying there is nod doc available).


I'd like to be able to define the API gateway re-routing configurations in code

New Feature
Defining up the reroute endpoints in code, using the builder design pattern, for example.
In code it'd be something similar to putting the routes in a .json or .yml.
Motivation for New Feature
It'd be easier to visualize and break down into smaller classes, the definitions of of the routes. A long .json file with every single configuration when they tend to be different can be difficult to mantain.

Hi Nuno!
You want to write C# code as Routes classes instead of writing routes in ocelot.json file, right?
First,
Do you understand that having hardcoded routes in C# classes you must compile, build and deploy your entire gateway solution to some hosting environment each time having even a small change in these routes classes?
Second,
Note, that ocelot.json file can be changed on the fly when gateway is running. So, there is hot reload feature for ocelot.json. In this case you need not to redeploy the gateway instance.
More about hot reload here: Reload JSON config on change
Third,
If your routes number increases then it make sense to consider to introduce CatchAll routes which will process all traffic for entire web service instance (Docker container). I don't think you will have dramatic number of services instances.
Fourth,
Do you know about the Merging configuration files feature?
Usage of this feature will bring exactly what you want: to split large config into a number of smaller configuration files for easier support and development via Git versioning. You can provide a suffix in the name of config file to track a file as a logical piece of functionality.
Finally,
Your feature request is overhead one. It will take some valuable effort to implement. But idea is interesting!
We can consider implementation of middleware which can read Routes definitions from another DLL-file as NuGet package or separate project in the solution.
Anyway, it should be discussed...

@badjuice  Hi Nuno!
It seems you are not interested in a discussion...
Your user case is similar in something to #1665 where Christofer requested to have multiple Routes config files.
You would like more control on Route when defining them as C# classes/code in comparison to having a .json or .yml files.
So, I see that you would like to write C# code and manage the routes.
In this case I would recommend you to consider Service Discovery feature/approach where you control all services and their routes. You can use Consul or Eureka, or another service provider you love.
Finally, I would say that you need to try another great feature of Ocelot which is Dynamic Routing!
This feature allows you to get all services from a service discovery provider (for example, from Consul) by the service name key, and register all services as routes dynamically! Pay attention that Ocelot works here in special mode of Dynamic Routes. So, it is impossible to mix static routes and dynamic routes modes!
Well... Usage of dynamic routes doesn't allow you write C# Route classes. But I believe you can design and develop some client which will register your services in service discovery, and after that your "dynamic config" will be deployed by Dynamic Routes mode of Ocelot.
P.S. I suggest you to develop new AddRoute method  for IOcelotBuilder interface, and I believe it will be possible to register static/dynamic route from the C# code.
If you will have some real working code we will accept and review your PR with pleasure in future!
For now this issue is going to be closed...


[No QA] Feature - Improve android build time

Details

Android builds take a lot of time to build and most of the time they can take more than 1h to build.
The culprit is the fact that gradle produces multiple builds for different architectures that aren't the one we need to run locally.
By following React Native official docs - https://reactnative.dev/docs/build-speed#build-only-one-abi-during-development-android-only - we can apply a flag to the android build command that prevents gradle from making builds for unused architectures.
Fixed Issues

$ N/A
PROPOSAL:

Add --active-arch-only flag to the android build script, on package.json

Tests

Run npm run android with the new flag and check how much time it takes to build

Offline tests

N/A
QA Steps

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

going to test an AdHoc build on this branch

well those platforms are completely unaffected by this PR so I'd say everything seems to be in order here

for context, I've made this change before and didn't notice a substantial difference in build times, but I'm pretty sure it's safe / recommended. re-testing once more locally

build finished in 12mins, that's fast by my reckoning 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.45-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


refactor: fix no callback warning for record write file

Refactors to fix this Node deprecation warning in the console:
(node:42160) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.

This solves the issue for now and is intended to retain current behavior.
As an additional or future point of discussion, I'm not sure if it's best to continue to push these writes to the background and merely log errors asynchronously, or if we should consider bubbling the error up to Express - especially if we integrate the recording proxy feature with the generic proxying in the future (#58).

@AndersDJohnson, looking forward to discussing error handling practices.


Host's stripe account is connected but not showing in UI or DB

Host  https://opencollective.com/plus-ninety-5-pte-ltd/ has a stripe account successfully connected in stripe dashboard but there is no payment method service=stripe connected to that id in the data base.
Search PaymentMethods table for collectiveid=38432 only the opencollective method is showing up.

When you connect a Stripe account, it adds a ConnectedAccount, not a payment method.
You can only receive money when you connect a stripe account. To send money you need a payment method which is a credit card or prepaid card / gift card.

The issue remains that the user doesn't have a stripe service payment menthod in the data base

(I said payment method because that's the name of the table in the data base)
No, the table is ConnectedAccounts (stripe, twitter, github). There is also a table PaymentMethods but that's for payment methods (stripe tokens for credit cards, paypal, prepaid, ...).

I see the Stripe Connected Account so it worked. Might be related to #1964 let me deploy it.

Ok - asked user to see if it shows up now.

closing this - it's fixed on the user's end


change highlight of a given node

Hi,
Im reviewing the code for node and tree but can figure out how to change a node highlight. I want to add a global mapping that search for the node in the tree (✅), goes to the node (✅), and adds a special highlight. I cant figure out this last part, could you please show me an example?
Thanks

-- consider create a stateful decorator saves the node's path
local MyDefault = {}

function MyDefault:decorator()
    return function(node)
        if self.selected and self.selected == node.abs_path then
            return node.name, '<YourAwesomeHighlight>'
        end
        return decorators.default(node)
    end
end

-- use this decorator replacing the default
tree:setup({
    draw_opts = {
        decorators = {
		    -- ...
            -- decorators.default,
            MyDefault:decorator(),
			-- ...
        },
    },
	-- ...
})

-- setting `selected` when you find your target file
 	MyDefault.selected = node.abs_path
	tree:force_refresh_node(node)

-- dont forget to clear `selected` when you don't need the special highlight

Great, thank you!


Update install.md to ensure Spin is copied to correct path

Signed-off-by: tpmccallum<EMAIL_ADDRESS>

Good point; I am not sure what best practice is in relation to removing things from .cargo area. Thanks for pointing out that we probably ought not just put binary files in there either. Would love a second opinion on how to proceed if a user used to use cargo and now want to use the install script.

We have an issue in for explaining how to update Spin. This PR will cover off original point/issue of creating awareness of the spin version and path.


Need a Demo Morphing project.

I need a real project of above wiki's project.https://github.com/exyte/Macaw/wiki/Morphing-animation

I can't run above example morphing shapes.

You may find one of the wiki's examples right in the Example project: https://github.com/exyte/Macaw/tree/master/Example.
Here is MorphingView source code which is quite similar to the wiki: https://github.com/exyte/Macaw/blob/master/Example/Example/Examples/Morphing/MorphingView.swift
Then you can modify MorphingView locally and use code samples from the wiki, everything should work fine. For the last sample I couldn't find exactly these two animals, however you can use any two SVG files. For example, you can use nice sample from the one of the recent tickets: https://github.com/exyte/Macaw/issues/223#issuecomment-345630774

I want to run this one but IDK how to do https://camo.githubusercontent.com/d9df4ef4b86715aa4469bd561821db3c1d121a24/687474703a2f2f692e696d6775722e636f6d2f6b7573774235552e676966

You can do following:

check out example project: https://github.com/exyte/Macaw/tree/master/Example
open MorphingView
replace content of the newScene method with the sample you need:

let form1 = Rect(x: 50.0, y: 50.0, w: 200.0, h: 200.0)
let form2 = Circle(cx: 150.0, cy: 150.0, r: 100.0)

let shape = Shape(form: form1, stroke: Stroke(width: 3.0))
let animation = shape.formVar.animation(to: form2, during: 1.5, delay: 2.0)
animation.autoreversed().cycle().play()
return shape

Then you can create your own project using Example as a template.

thank you.

@ystrot Can I draw custom path(shape)? If yes, give me some instruction. Thanks for your support. 😃

Regarding drawing custom path - you can start from this sample:
let path = MoveTo(x: 10, y: 10)
	.lineTo(x: 20, y: 20)
	.lineTo(x: 10, y: 20)
	.close().build()

let shape = Shape(form: path, fill: Color.red)

Macaw works with SVG path segments, so you could learn more about available options using SVG documentation: https://www.w3.org/TR/SVG/paths.html


speech/transcript: initial commit

The program will be upgraded to use the streaming API and send content in smaller chunks.
/cc @broady

LGTM otherwise. I suggest making a function like
func Recognize(ctx context.Context, client speech.SpeechClient, *data []byte) (*NonStreamingRecognizeResponse, error)

Done with all and added tests.

:+1:


Metadata and runtime support for suppressible protocol requirements

Introduce metadata and runtime support for describing conformances to
"suppressible" protocols such as Copyable. The metadata changes occur
in several different places:

Context descriptors gain a flag bit to indicate when the type itself has
suppressed one or more suppressible protocols (e.g., it is ~Copyable).
When the bit is set, the context will have a trailing
SuppressibleProtocolSet, a 16-bit bitfield that records one bit for
each suppressed protocol. Types with no suppressed conformances will
leave the bit unset (so the metadata is unchanged), and older runtimes
don't look at the bit, so they will ignore the extra data.
Generic context descriptors gain a flag bit to indicate when the type
has conditional conformances to suppressible protocols. When set,
there will be trailing metadata containing another
SuppressibleProtocolSet (a subset of the one in the main context
descriptor) indicating which suppressible protocols have conditional
conformances, followed by the actual lists of generic requirements
for each of the conditional conformances. Again, if there are no
conditional conformances to suppressible protocols, the bit won't be
set. Old runtimes ignore the bit and any trailing metadata.
Generic requirements get a new "kind", which provides an ignored
protocol set (another SuppressibleProtocolSet) stating which
suppressible protocols should not be checked for the subject type
of the generic requirement. For example, this encodes a requirement
like T: ~Copyable. These generic requirements can occur anywhere
that there is a generic requirement list, e.g., conditional
conformances and extended existentials. Older runtimes handle unknown
generic requirement kinds by stating that the requirement isn't
satisfied.

Extend the runtime to perform checking of the suppressible
conformances on generic arguments as part of checking generic
requirements. This checking follows the defaults of the language, which
is that every generic argument must conform to each of the suppressible
protocols unless there is an explicit generic requirement that states
which suppressible protocols to ignore. Thus, a generic parameter list
<T, Y where T: ~Escapable> will check that T is Copyable but
not that it is Escapable, and check that U is both Copyable and
Escapable. To implement this, we collect the ignored protocol sets
from these suppressed requirements while processing the generic
requirements, then check all of the generic arguments against any
conformances not suppressed.
Answering the actual question "does X conform to Copyable?" (for
any suppressible protocol) looks at the context descriptor metadata to
answer the question, e.g.,

If there is no "suppressed protocol set", then the type conforms.
This covers types that haven't suppressed any conformances, including
all types that predate noncopyable generics.
If the suppressed protocol set doesn't contain Copyable, then the
type conforms.
If the type is generic and has a conditional conformance to
Copyable, evaluate the generic requirements for that conditional
conformance to answer whether it conforms.

The procedure above handles the bits of a SuppressibleProtocolSet
opaquely, with no mapping down to specific protocols. Therefore, the
same implementation will work even with future suppressible protocols,
including back deployment.
The end result of this is that we can dynamically evaluate conditional
conformances to protocols that depend on conformances to suppressible
protocols.
Implements rdar://123466649.

@swift-ci please test

@swift-ci please test

I still have more to do, but this is passing all tests locally (finally).

I'm sure you've thought about this so this is just me being paranoid and double-checking: we're pretty sure we'll never need more than 16 of these? I can't think of anything close to 14 more that we'd ever want to add, but, paranoid.

Everyone seems to think we'll be okay with 16. If not, we'll have a non-back-deployable issue with the 17th.

Added support for variadic generics and structural types, including "noescape" function types (based on the existing bits).

@swift-ci please test

Help, I've been replaced by a snake who puts too many "s"'s in everything

@swift-ci please smoke test

@swift-ci please smoke test Windows

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test


Can not display the font on wayland on rk3568.

[✓] eLinux toolchain - develop for embedded Linux devices
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
I have created a test by  flutter-elinux create test
and build it
flutter-elinux build elinux \
     --target-arch=arm64 \
     --target-compiler-triple=aarch64-linux-gnu \
     --target-sysroot=<Absolute_path_to>/ubuntu18-arm64-sysroot

the app can run on the rk3568 weston , but the font is not showed.
I can see the assets has the MaterialIcons-Regular.otf
My version is 3.13.1
Any suggestions?

First, does it work fine on desktop PC?

I have created a test by flutter-elinux create test
and build it

test shouldn't have any font asset after creating this test. Please check your project first. Thanks.

First, does it work fine on desktop PC?

Work well on PC.

I have created a test by flutter-elinux create test
and build it

test shouldn't have any font asset after creating this test. Please check your project first. Thanks.

I don't know what you mean. I don't any other fonts
ls build/elinux/arm64/release/bundle/data/flutter_assets/fonts/
MaterialIcons-Regular.otf

I see.

the app can run on the rk3568 weston , but the font is not showed.

What does it mean? No messages like "You have pushed the button this many times:" ?
Did you copy build/elinux/arm64/release/bundle directory to your target device?

I see.

the app can run on the rk3568 weston , but the font is not showed.

What does it mean? No messages like "You have pushed the button this many times:" ?
Did you copy build/elinux/arm64/release/bundle directory to your target device?

You're right.
The Text is not be showed and blank.
mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:', // can not be show blank
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ), // can not be show blank
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton( // work well
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),

I have copied bundle to the target device
@RK356X:/root/bundle# ls data/flutter_assets/fonts/MaterialIcons-Regular.otf
data/flutter_assets/fonts/MaterialIcons-Regular.otf

How about run flutter-elinux directory on rk3568 without cross-building? Does it work?

How about run flutter-elinux run -d elinux-wayland --release directory on rk3568 without cross-building? Does it work?

My system is linux not ubuntu or centos. So I can not build on the board.

Okay, but unfortunately, I have no more ideas.

I have change the font to DejaVuSansMono.ttf and works well. Maybe other fonts will works well too.


update chip styling

Looks good.  I assume you'll need to get rui-chip into the redoxengine app in a separate PR?

Yup, there is a separate card for that.


Prow configs

/lgtm

/lgtm

@zryfish: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/shrug

/pony

@zryfish:

In response to this:

/pony

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cat

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zryfish
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test

@zryfish: No presubmit jobs available for kubesphere/test-infra@main

In response to this:

/test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test

@zryfish: No presubmit jobs available for kubesphere/test-infra@main

In response to this:

/test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test

@zryfish: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test pull-test-infra-yamllint
/test pull-test-infra-prow-checkconfig

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test all

@zryfish: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-test-infra-yamllint
136f91403a2cf9f2072b28bfda68adff77bfe0fd
link
/test pull-test-infra-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zryfish: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-test-infra-yamllint
136f91403a2cf9f2072b28bfda68adff77bfe0fd
link
/test pull-test-infra-yamllint

pull-test-infra-prow-checkconfig
136f91403a2cf9f2072b28bfda68adff77bfe0fd
link
/test pull-test-infra-prow-checkconfig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zryfish: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-test-infra-yamllint
136f91403a2cf9f2072b28bfda68adff77bfe0fd
link
/test pull-test-infra-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zryfish: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-test-infra-yamllint
eaf33ebf69bec12181be9fb3230f383b6fb6a805
link
/test pull-test-infra-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test pull-test-infra-yamllint

@zryfish: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-test-infra-yamllint
eaf33ebf69bec12181be9fb3230f383b6fb6a805
link
/test pull-test-infra-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test pull-test-infra-yamllint


Autocomplete Fills 2nd Street Address not 1st Street Address

Great small plugin but for some reason the autocomplete fills doens't put the street all on the first street line. It only keeps the street number on street line 1 and then auto moves the street name down to street line 2. Not sure where this behavior is coming from.

Hi, I just installed the module and I'm experiencing the same issue.
Where yuo able to solve this issue?

i don't know, if it's a bug or some configuration error, but if you want to have the street address in line 1 just change the
js/turiknox/addressautocomplete.js in line 27 from
                target: this.type + ':street2'
to
                target: this.type + ':street1'


"validateAuthorizationCode" in Mercado Pago's OAuth2 flow is not standard

I'm using the OAuth2Client to set up a OAuth2 flow from Mercado Pago
links to docs:
flow docs
token creation and refresh API
there is a specific difference that this flow requires, that the OAuth2Client does differently.
instead of using the Bearer token like this (from OAuth2Client)
if (this.clientPassword !== null) {
  const encodedCredentials = encodeBasicCredentials(this.clientId, this.clientPassword);
  request.headers.set("Authorization", `Basic ${encodedCredentials}`);
}

it requires a direct "accessToken" gotten from Mercado Pago's dashboard, and not this computed "encodeBasicCredentials" one.
this is how I'm doing it. Anything I'm missing? I would love staying in arctic land, using only arctic APIs, but this seems like a deal breaker?
complete code
import type { OAuth2Tokens } from "arctic"
import { CodeChallengeMethod, OAuth2Client } from "arctic"
import { createOAuth2Request, sendTokenRequest } from "arctic/dist/request"

const authorizationEndpoint = "https://auth.mercadopago.com.ar/authorization"
const tokenEndpoint = "https://api.mercadopago.com/oauth/token"

export class MercadoPago {
  private client: OAuth2Client
  public clientId: string

  private clientSecret: string
  private redirectURI: string
  private accessToken: string

  constructor(clientId: string, clientSecret: string, accessToken: string, redirectURI: string) {
    this.clientId = clientId
    this.clientSecret = clientSecret
    this.redirectURI = redirectURI
    this.accessToken = accessToken
    this.client = new OAuth2Client(clientId, clientSecret, redirectURI)
  }

  public createAuthorizationURL(state: string, codeVerifier: string, scopes: string[]): URL {
    const url = this.client.createAuthorizationURLWithPKCE(
      authorizationEndpoint,
      state,
      CodeChallengeMethod.S256,
      codeVerifier,
      scopes,
    )
    return url
  }

  public async validateAuthorizationCode(
    code: string,
    codeVerifier: string,
  ): Promise<OAuth2Tokens> {
    const body = new URLSearchParams()
    body.set("grant_type", "authorization_code")
    body.set("code", code)
    body.set("redirect_uri", this.redirectURI)
    body.set("code_verifier", codeVerifier)
    body.set("client_id", this.clientId)
    body.set("client_secret", this.clientSecret)
    const request = createOAuth2Request(tokenEndpoint, body)
    request.headers.set("Authorization", `Bearer ${this.accessToken}`)
    const tokens = await sendTokenRequest(request)
    return tokens
  }

  public async refreshAccessToken(refreshToken: string): Promise<OAuth2Tokens> {
    const tokens = await this.client.refreshAccessToken(tokenEndpoint, refreshToken, [])
    return tokens
  }
}

This is expected behavior. OAuth2Client only works with providers that are strictly compliant with the spec.

would you accept this as a possible provider?

yes


The connection to the server localhost:8080 was refused - did you specify the right host or port?

Facing error for kubectl get node command for EKS cluster (AWS)
History from AWS CLI :
eksctl create cluster
--name my-cluster
--region us-west-2
--nodegroup-name my-nodes
--node-type t3.medium
--nodes 3
--nodes-min 1
--nodes-max 4
--managed

Looks like your cred exec plugin is not installed correctly or has issues
/kind support

/remove-kind bug

/close


[SPARK-28595][SQL] explain should not trigger partition listing

What changes were proposed in this pull request?
Sometimes when you explain a query, you will get stuck for a while. What's worse, you will get stuck again if you explain again.
This is caused by FileSourceScanExec:

In its toString, it needs to report the number of partitions it reads. This needs to query the hive metastore.
In its outputOrdering, it needs to get all the files. This needs to query the hive metastore.

This PR fixes by:

toString do not need to report the number of partitions it reads. We should report it via SQL metrics.
The outputOrdering is not very useful. We can only apply it if a) all the bucket columns are read. b) there is only one file in each bucket. This condition is really hard to meet, and even if we meet, sorting an already sorted file is pretty fast and avoiding the sort is not that useful. I think it's worth to give up this optimization so that explain don't need to get stuck.

How was this patch tested?
existing tests

cc @hvanhovell @maryannxue @viirya

Test build #108525 has started for PR 25328 at commit fb8793d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13619/
Test PASSed.

I agree that it was very hard to meet the condition. BTW, IIRC, the main reason for that optimization was to get the same result with Hive for the LIMIT queries which didn't have ORDER BY.

I think it's worth to give up this optimization so that explain don't need to get stuck.

Test build #108525 has finished for PR 25328 at commit fb8793d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108525/
Test FAILed.

I don't think a system needs to guarantee the output order of a SQL query without ORDER BY. But let me add a legacy config to keep this optimization, just in case. what do you think @dongjoon-hyun ?

Test build #108571 has started for PR 25328 at commit fa763eb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13662/
Test PASSed.

Test build #108571 has finished for PR 25328 at commit fa763eb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108571/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13773/
Test PASSed.

Test build #108688 has started for PR 25328 at commit 0652c22.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13774/
Test PASSed.

Test build #108688 has finished for PR 25328 at commit 0652c22.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108688/
Test FAILed.

retest this please

Test build #108699 has started for PR 25328 at commit 0652c22.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13785/
Test PASSed.

Test build #108700 has started for PR 25328 at commit 0652c22.

Test build #108699 has finished for PR 25328 at commit 0652c22.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108699/
Test PASSed.

Test build #108700 has finished for PR 25328 at commit 0652c22.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108700/
Test PASSed.

LGTM except one minor comment https://github.com/apache/spark/pull/25328/files#r311096949.

LGTM except one comment.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13826/
Test PASSed.

Test build #108745 has started for PR 25328 at commit 264a259.

Test build #108745 has finished for PR 25328 at commit 264a259.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108745/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13828/
Test PASSed.

Test build #108747 has started for PR 25328 at commit bf9b261.

Test build #108747 has finished for PR 25328 at commit bf9b261.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108747/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13834/
Test PASSed.

Test build #108753 has started for PR 25328 at commit bf9b261.

Test build #108753 has finished for PR 25328 at commit bf9b261.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108753/
Test PASSed.

thanks for the review, merging to master!

@cloud-fan :

The outputOrdering is not very useful. We can only apply it if a) all the bucket columns are read. b) there is only one file in each bucket. This condition is really hard to meet, and even if we meet, sorting an already sorted file is pretty fast and avoiding the sort is not that useful. I think it's worth to give up this optimization so that explain don't need to get stuck.

We see cases where sorting the pre-sorted data results in 30+ mins to runtime when reading terabytes of data. There was similar discussion in the email list this Aug[1].
Are there plans to remove this config that can potentially break Spark users with large datasets that benefit from this?


New blocks + genesis handling broke jsonrpc tests

@jnnk
https://github.com/ethereum/pyethapp/commit/b50e9da309dd2f4f6bdcc0a0b0e239d1b4202baf
i didn't take a closer look, but it seems that there are no funds to send txs (maybe need to add some alloc to the genesis). event tests stall if the tx fails.

Fixed in 7e4d8caa0ef9ce6a71d27484241b77561fe4ed12


Warm up the database in Spring integration tests

Description
It is better to create some "fake" operations of adding data to the database and removing it before real test generation.
If some small values are used as id, fuzzer may just guess it, so generated test may not be reliable.
Even though we reset some Spring beans between the tests, database tables ids are not reset, so some warm up will highly likely help to avoid ids clashes.

There may be other id generators non-related to Spring data repositories, that also require same warmup. I think more general solution may be to change the way we emit UtFuzzedExecutions. Right now for every unique Coverage the very first UtFuzzedExecution that achieved that Coverage is emitted. I think, if we have multiple UtFuzzedExecutions achieving same coverage we should ignore first few ones.
The drawback of such approach is that it leads to generation of unreproducible tests if some Coverages we observed only with guessed identifiers. That may be fixable by rerunning tests after minimization, while fully resetting context after every individual test.


GEOMESA-992 README.md should mention -Daccumulo-1.5

Added language to README.md describing how to build GeoMesa targeting
either Accumulo 1.5 or 1.6 by the use of the -Daccumulo-1.5 property.

4534ed5a76f168b31dce78b786755fc6468cb6e8


[SDA-6791] fix: path compatibility issue with inline policies from acc roles

Related issue: https://issues.redhat.com/browse/SDA-6791
What
Compatibility issue with upgrading account roles policies when the policy was created as inline instead of attached, this happened when the acc roles were created from older ROSA CLI
Why
Clients couldn't upgrade their account roles if they created it from an older ROSA CLI version (tested with 1.1.3)
Changes
If policy type is 'inline' than consider the path from the role, as it will be the same considering current implementation. This might be changed in the future to support different paths, so it might need to be revised later.
With this path in consideration, it deletes the inline policy and creates an attached one with the path from role as the flow is supposed to be.
After

/lgtm


Remove Yammer metrics from hystrix-contrib?

From what I can tell, the Yammer metrics library is no longer maintained and has been superseded by both the CodaHale and DropWizard metrics libraries.  @fkjellberg / @benjchristensen - any objection to removal of this module?

I don't know enough about it to comment. Does it cost us anything to maintain it for backwards compatibility for people using it still?

It doesn't have to cost anything if we stop adding new features to it (like collapser metrics as in #576).


install.sh tries to git clone outisde of my home dir.

So, i am the user 'bibek' on my machine but '/home/bibek/' is not mine. But '/home/bibek22' is. When i try to install oh-my-zsh with the install script, it tries to create dir in /home/bibek and fails as I don't have permission there.
tried to look into the script, couldn't find anything. $USER is "bibek" $HOME is "/home/bibek22"

I can't reproduce this. The installer script uses ~ to refer to $HOME, perhaps there's some edge case where it doesn't work correctly. What does print -P ~ output?

hey, i forgot to update this sooner. so, the issue was due most likely due to the config files I copied over from other machine where i owned '/home/bibek/' and had omz installed. It set some variables that installer script uses. i removed the configs entirely and relogin, and then was able to install omz.
Thanks. closing.


Vulnerability roundup 97: libsixel-1.8.6: 1 advisory [6.5]

search, files

[ ] CVE-2020-19668 CVSSv3=6.5 (nixos-20.09, nixos-unstable)

Scanned versions: nixos-20.09: 50c8d1e0deb; nixos-unstable: 83cbad92d73.
Cc @vrthra

See also: #90869


more data please!

This will obviously have to wait until the app supports more than the basic fields, but this is a suggestion for how the present display could be enhanced with more data, when available :)

The attached mockup shows a truncated description and additional information; tags, task ID, blocked tasks, blocking tasks and number of annotations, and is a discussion-point.

I'm closing this issue similar to issue #38. "More data" will be probably there, when you "click" on a task. Showing everything would too much work (and additionally too much for a phone).


Problem installing

On a stock install of Ubuntu 12.10/numpy the installation
python setup.py build
sudo python setup.py install

works, but running the demo
python Demo/compute_gr.py

fails with
Traceback (most recent call last):
  File "Demo/compute_gr.py", line 4, in <module>
    from pyljfluid.components import (LJForceField, Config, MDSimulator,
  File "/usr/local/lib/python2.7/dist-packages/pyljfluid/__init__.py", line 29, in <module>
    from components import *
  File "/usr/local/lib/python2.7/dist-packages/pyljfluid/components.py", line 27, in <module>
    from base_components import (NeighborsTable, BaseForceField, LJForceField, BaseConfig,
ImportError: cannot import name BaseForceField

Hopefully it isn't rude to comment on a multi-year old thread like this, but the problem is in a mislabelled variable in pylfjluid/components.py
To fix it, before running setup.py, you should go into pyljfluid/components.py and on lines 27 and 37, change BaseForceField to BasePyForceField. If you have already run the setup, the same fix will work, just be sure to go to /lib/python2.7/site-packages/pyljfluid/components.py and make the change there.


[release-next] Use dependencies instead of IMAGE_FORMAT and switch to cluster pool

Switch to dependencies instead of IMAGE_FORMAT
Use cluster pool for 4.8

based on  openshift/knative-eventing#1377

/retest


Merge prTesting_201906161116 branch to master branch

Docs Build status updates of commit d91837b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Rewrote the geolocation distance calculation to use great circle distances

We can now limit to an exact distance, which has been set to 25 miles.
See spec https://docs.google.com/document/d/1xaGiEWQ_FHmgsK2msusGSZcX256kwe4J06IHMyrdf_o/edit#

👍


Software Serial not working. Be carefull with ESP8266 package's version

Hi, I think that someone could find this usefull.
I have been getting problems with SoftwareSerial and ESP8266 package version. (i am using a wemos d1 mini board for test). Trying enroll sketch, It seems that it can detect the fingerprint sensor, but after that ... "comunication error"
Software Serial is NOT working with 2.5.1 package version.
I have read in severalweb pages that we have to use 2.4 packages.
I will try 2.5.2 package version and write down here.
Update: 2.5.2 also not working with Software Serial

Hi, finally you need to use any esp8266 package ABOVE 2.4, I mean, you can use 2.3, but not 2.4
"you have to take into account that Arduino core for ESP8266 version 2.4 and later has troubles with Software Serial (check plerup/espsoftwareserial#63).
So you have to use version 2.3."
https://github.com/plerup/espsoftwareserial/issues/63

Exactly, that's right.
When I tried using SIM800L with NodeMCU I had a communication problem sometimes.
So I change the ESP8266 version to 2.4.2 and after that everything worked as it should.
On other hands, When I made the code for this project (fingerprint system), I tired many ESP8266 versions in order to check if the Software Serial library will work or not, so after testing these libraries I noticed that the code worked. but sometimes still there problems while using 2.5.0 version.
Anyway, There are two versions I will test them soon for the SIM800L and NodeMCU project to know which is the better library for that.
Thanks for your time and sharing your result.