feat: add ability to theme individual components

SUMMARY:
feat: add ability to theme individual components
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:

[ ] Bugfix Pull Request
[x] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Codecov Report

:exclamation: No coverage uploaded for pull request base (main-next@184ae0b). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             main-next     #183   +/-   ##
============================================
  Coverage             ?   76.78%
============================================
  Files                ?       72
  Lines                ?     1788
  Branches             ?      695
============================================
  Hits                 ?     1373
  Misses               ?      404
  Partials             ?       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184ae0b...b0886f0. Read the comment docs.


Signal cannot be emitted from a script attached to a GDExtension class

Godot version
4.0.stable
System information
macOS, Radeon Pro 555X 4 GB, 16 GB RAM
Issue description
I have a custom class made with GDExtension. In the process method I call test_signal() method:

test_signal() is emitting a signal called test_signal_gd:

Inside godot I attach a script to this custom class node and I connect the signal to a gdscript method:

onTestSignal() is not being called(nothing is printed). One workaround is to add a child node to GDExample and attach the script to that node and connect the signal there, this method works.
Steps to reproduce

Create a custom class in GDExtension
Inside this class create a method that emits a signal
call that method to make sure the signal its emitted (I call it inside _process (double delta) function)
add the signal in _binding_methods() function
inside editor add the custom node and attach a script to it
connect the custom signal to a method inside the script
as a result the function that is connected in gdscript won't be called

Minimal reproduction project
N/A (idk how to provide the c++ files)

N/A (idk how to provide the c++ files)

You can provide the source code with the C++ files and the SCons or CMake setup you're using to build, plus the Godot project using the library.


Resolve some compiler warnings

Resolves
N/A - just clean-up
Description

I disabled missing XML comments on the test project as that's not required
I removed an XML param that had been removed from the method

This is ready for a review


Projections Phase #2: Live and Inline Javascript Projections

Not sure if this is going to make it to v0.9, but maybe.
Live aggregation of a single stream

[ ] Synchronously
[ ] Synchronously at a given version
[ ] Synchronously at a given timestamp
[ ] Asynchronously
[ ] Asynchronously at a given version
[ ] Asynchronously at a given timestamp
[ ] Inside of BatchQuery
[ ] Inside of BatchQuery at a given version
[ ] Inside of BatchQuery at a given timestamp

Inline aggregation of a single stream

[ ] From SaveChanges()
[ ] From SaveChangesAsync()

One for One Transform to Documents

[ ] Live synchronous selection
[ ] Live asynchronous selection
[ ] Live within Batch Querying
[ ] Inline, SaveChanges()
[ ] Inline, SaveChangesAsync()

Purely technical tasks

[ ] Mechanism to load JS projections into postgres at bootstrapping time. Was #83

I think everything we care about has already been done. I'm bailing out on the JS projections


docs: add ci badge

Description

fix: bug where code blocks were being reprinted each time
docs: add CI badge

pre-commit.ci run


New Sample: creating symbols from a web style

Description
This is my first shot at working on the first implementation of a sample - so any initial feedback, particularly on the README before I create the Design PR is welcomed. I'll then make any changes from that process before it is "officially reviewed".
The issue within CS (2331) is called "Save feature layer with symbol style". However the requirements changed and the actual requirements became just following the existing JavaScript sample to create symbols on the LA County Points of Interest service as a feature layer. So functionality wise it's fairly straightforward and clear, it's more the write up where I may need some tweaks.
So that also means I've come up with the current name - "Create Symbols from Web Styles" - so I welcome feedback / ideas on that too, and then I'm sure it'll also then get debated within the samples team. I had thought maybe "Create symbol style from web style" could work but it felt like there were too many styles?!
JS sample: https://developers.arcgis.com/javascript/latest/sample-code/webstylesymbol-2d/index.html
Web Style being used: https://developers.arcgis.com/javascript/latest/guide/esri-web-style-symbols-2d/
The key point of the sample is demonstrating that the constructor for a SymbolStyle can now be from a portal (AGO / Enterprise) where a style file is hosted. I can send any internal links from my reading if you want any more links to info.
Thanks!
Additional note - I'll probably extract some of the UI styling out into a CSS file when things are sured up.

@JonLavi this design is now merged in CS 🎉  Could you re-check this PR following your initial comments? Thanks!


Upgrading for Universal Render Pipeline

Just wanna say that these shaders have been extremely helpful, thanks for all the hard work! As a total shader novice, I wanted to ask if it's possible to upgrade these shaders to work with the new scriptable render pipelines, and if so, how much work would that entail?

Do we have any alternative shaders for UnitySpriteShaders, which can work in Unity URP (Universal Render Pipeline)?


Compiling tf.keras.Model with hub.KerasLayer fails in distributed scope

System information

Have I written custom code: Yes
OS Platform and Distribution: Debian 9.11 (Google Cloud tf2-latest-gpu image)
TensorFlow installed from: Preinstalled on Google Cloud image
TensorFlow version: v2.1.0-rc2-17-ge5bf8de
Python version: 3.5.3
CUDA/cuDNN version: N/A
GPU model and memory: None (Using Google Cloud TPU v3-8)

Describe the current behavior
When compiling a tf.keras.Model that includes a hub.KerasLayer (tensorflow hub), it fails to compile in a distribution strategy scope:
ValueError                                Traceback (most recent call last)
<ipython-input-23-7b06371889c9> in <module>
     16         optimizer=tf.keras.optimizers.Adam(learning_rate=LEARNING_RATE),
     17         loss=tf.keras.losses.binary_crossentropy,
---> 18         metrics=["accuracy"]
     19     )

1 frames
/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/training/tracking/base.py in _method_wrapper(self, *args, **kwargs)
    455     self._self_setattr_tracking = False  # pylint: disable=protected-access
    456     try:
--> 457       result = method(self, *args, **kwargs)
    458     finally:
    459       self._self_setattr_tracking = previous_value  # pylint: disable=protected-access

/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/keras/engine/training.py in compile(self, optimizer, loss, metrics, loss_weights, sample_weight_mode, weighted_metrics, target_tensors, distribute, **kwargs)
    469                 'with strategy.scope():\n'
    470                 '  model=_create_model()\n'
--> 471                 '  model.compile(...)'% (v, strategy))
    472
    473   @trackable.no_automatic_dependency_tracking

ValueError: Variable (<tf.Variable 'bert/embeddings/word_embeddings:0' shape=(119547, 768) dtype=float32>) was not created in the distribution strategy scope of (<tensorflow.python.distribute.tpu_strategy.TPUStrategy object at 0x7f4df23cddd8>). It is most likely due to not all layers or the model or optimizer being created outside the distribution strategy scope. Try to make sure your code looks similar to the following.
with strategy.scope():
  model=_create_model()
  model.compile(...)

Describe the expected behavior
Model should be able to compile.
Code to reproduce the issue
Code used to create scope:
TPU_ADDRESS = "grpc://" + "<IP_ADDRESS>:8470"

with tf.compat.v1.Session(TPU_ADDRESS) as session:
    print('TPU devices:')
    pprint.pprint(session.list_devices())

resolver = tf.distribute.cluster_resolver.TPUClusterResolver(TPU_ADDRESS)
try:
    tf.config.experimental_connect_to_cluster(resolver)
except tf.errors.UnimplementedError as uie:
    print(uie, "This appears to be caused by the TPU already being connected. Ignoring.", sep='\n')
tf.tpu.experimental.initialize_tpu_system(resolver)
tpu_strategy = tf.distribute.experimental.TPUStrategy(resolver)

Code used to compile model:
with tpu_strategy.scope():
    in_id = tf.keras.layers.Input(shape=(MAX_SEQ_LENGTH,), name="input_ids", dtype=np.int32)
    in_mask = tf.keras.layers.Input(shape=(MAX_SEQ_LENGTH,), name="input_masks", dtype=np.int32)
    in_segment = tf.keras.layers.Input(shape=(MAX_SEQ_LENGTH,), name="segment_ids", dtype=np.int32)
    bert_inputs = {"input_ids": in_id, "input_mask": in_mask, "segment_ids": in_segment}

    bert_layer = hub.KerasLayer(BERT_MODEL_HUB, signature="tokens", output_key="pooled_output")(bert_inputs)
    bert_layer.trainable = True

    dense = tf.keras.layers.Dense(256, activation='relu')(bert_layer)
    pred = tf.keras.layers.Dense(len(unique_labels), activation='sigmoid')(dense)

    model = tf.keras.Model(inputs=bert_inputs, outputs=pred)

    model.compile(
        optimizer=tf.keras.optimizers.Adam(learning_rate=LEARNING_RATE),
        loss=tf.keras.losses.binary_crossentropy,
        metrics=["accuracy"]
    )

Other info / logs
Previously opened issue with TF Hub here: https://github.com/tensorflow/hub/issues/469
Google Cloud TPU v3-8 is running TPU Software 2.1

Is there any update on this? Just wanted to check in being as it's been two weeks now.

Can you try these tf2 hub modules here: https://tfhub.dev/tensorflow/bert_en_cased_L-24_H-1024_A-16/1?
The Albert modules from the TF2 model code are publishing soon.
The example here: https://github.com/tensorflow/models/blob/master/official/nlp/bert_models.py#L370
should work for TF 2.1

@saberkun the new models do seem to work. I was just able to load and train a model using this TF hub model loaded as a KerasLayer: https://tfhub.dev/tensorflow/bert_multi_cased_L-12_H-768_A-12/1.
The example link you posted gives me a 404 error however.
So is the bug just an issue of lacking backwards compatibility?

I don't think we support loading TF1 hub model from TF2, maybe someone from TF hub team can confirm.

@rxsang it loooks like it should be possible based on this: https://www.tensorflow.org/hub/migration_tf2

@uchua Looks like issue is resolved. Please feel free to reopen the issue if you still have a concern. Thanks!

@saberkun was the conclusion here that the TFHub SavedModel had to be in TF2 format? There is an open issue at https://github.com/tensorflow/hub/issues/295 for a problem similar if not identical to this one. I am experiencing this same problem when I use the Efficientnet-lite TF1 SavedModel from TFHub on AI Platform runtime 2.3 with TPUs. In my case, this model is not available in TF2 format. Is it not possible to use TF1 SavedModels with TF2 distributed scope, and is there someone specific I should ask about making a TF2 version available?

@saberkun was the conclusion here that the TFHub SavedModel had to be in TF2 format? There is an open issue at https://github.com/tensorflow/hub/issues/295 for a problem similar if not identical to this one. I am experiencing this same problem when I use the Efficientnet-lite TF1 SavedModel from TFHub on AI Platform runtime 2.3 with TPUs. In my case, this model is not available in TF2 format. Is it not possible to use TF1 SavedModels with TF2 distributed scope, and is there someone specific I should ask about making a TF2 version available?


fix duplicate on the fly

Is there  a way to add a number in the url key at generations to fix on the fly duplicates?

In my opinion I think that is more useful modify the url_key appending a number on it, as @psol7 said.

Hello.
This logic was implemented in version 1.5.0. Please update extension.
Best regards,
Oleg Koval.


Fix cmake files for highwayhash and re2.

Tested via the following:
$ cd tensorflow/contrib/cmake
$ mkdir build
$ cd build
$ cmake ..
$ make

Jenkins, test this please.


Expose ability to generate a CoreSchemaOrField for json schema building from a FieldInfo

cc @tiangolo @adriangb
@tiangolo would be good if you could confirm whether this would do the trick for you. I think @adriangb might want it addressed in a different way, I also understand that perspective. I was surprised by how little code it took to do this though (and how it affected basically nothing else).
Also, to be clear, I don't think this is fully ready for primetime, probably could use some minor tweaks/improved tests/a bit of documentation, but I also think there's a good chance it needs substantial revisions before merging and/or will be rejected, so I don't want to do that until it's confirmed.

whoa we can have siblings keys for $ref? That probably means we can remove a lot of otherwise-error-prone code and also will probably simplify things for users in some cases where there may-or-may-not be an allOf

Agreed. I still think we should provide a better way of dealing with the need to generate multiple json schemas while resolving conflicts and such.

I found the right/better link saying $ref can now have siblings: https://json-schema.org/draft/2019-09/release-notes.html#core-vocabulary

Just FYI, I updated the tests in main-pv2 in FastAPI with this branch, and now I made this draft PR that just installs this branch to confirm it makes tests pass: https://github.com/tiangolo/fastapi/pull/9777 🎉

@tiangolo could you clarify a bit what the use case is within FastAPI for this? I'm assuming it's to take a collection of types and generate JSON schemas for all of them (which will go into path operations, query parameters, etc. in the OpenAPI def) with a single "$def" section, handling name collisions and such. Is this right?

@adriangb yep! That's right. In FastAPI, the first-class citizens are fields (in v1 there was a ModelField object) not the models. And this is indeed the pure types with their metadata, including lists, ints, and anything else that is not strictly a Pydantic model (and also including Pydantic models).
I collect all those, generate the JSON Schemas for them, and then put any relevant definitions in OpenAPI's components (e.g. for models), and the rest that don't produce a reusable definition but a pure JSON Schema I put them directly in the relevant parts of OpenAPI (e.g. a path operation parameter).
The specific thing I'm not being able to do is this, with FastAPI:
from fastapi import FastAPI, Query

app = FastAPI()

@app.get("/items/")
async def create_item(
    batch: str = Query(
        default="asdf",
        description="some query param",
        examples=["yes please", "oh, no"],
    ),
) -> str:
    return ""

The JSON Schema for that includes batch, includes the default value, but doesn't include the description and examples.

Here's a test for that code with the long OpenAPI
There's a comment inside the OpenAPI showing where the extra metadata should be:
def test_model_field():
    # insert_assert(app.openapi())
    assert app.openapi() == {
        "openapi": "3.1.0",
        "info": {"title": "FastAPI", "version": "0.1.0"},
        "paths": {
            "/items/": {
                "get": {
                    "summary": "Create Item",
                    "operationId": "create_item_items__get",
                    "parameters": [
                        {
                            "name": "batch",
                            "in": "query",
                            "required": False,
                            "schema": {
                                "type": "string",
                                "default": "asdf",
                                "title": "Batch",
                                # Here's the problem, this doesn't show up without this PR
                                "description": "some query param",
                                "examples": ["yes please", "oh, no"],
                                # End of the problem
                            },
                            "description": "some query param",
                        }
                    ],
                    "responses": {
                        "200": {
                            "description": "Successful Response",
                            "content": {
                                "application/json": {
                                    "schema": {
                                        "type": "string",
                                        "title": "Response Create Item Items  Get",
                                    }
                                }
                            },
                        },
                        "422": {
                            "description": "Validation Error",
                            "content": {
                                "application/json": {
                                    "schema": {
                                        "$ref": "#/components/schemas/HTTPValidationError"
                                    }
                                }
                            },
                        },
                    },
                }
            }
        },
        "components": {
            "schemas": {
                "HTTPValidationError": {
                    "properties": {
                        "detail": {
                            "items": {"$ref": "#/components/schemas/ValidationError"},
                            "type": "array",
                            "title": "Detail",
                        }
                    },
                    "type": "object",
                    "title": "HTTPValidationError",
                },
                "ValidationError": {
                    "properties": {
                        "loc": {
                            "items": {
                                "anyOf": [{"type": "string"}, {"type": "integer"}]
                            },
                            "type": "array",
                            "title": "Location",
                        },
                        "msg": {"type": "string", "title": "Message"},
                        "type": {"type": "string", "title": "Error Type"},
                    },
                    "type": "object",
                    "required": ["loc", "msg", "type"],
                    "title": "ValidationError",
                },
            }
        },
    }

Right but instead of you calling GenerateSchema.generate_inner and cobbling together a solution from disparate pieces of functionality in Pydantic I feel like it'd be better if Pydantic had first-class support for this, essentially I'd like something like TypeAdapter.json_schemas that actually works well, and in particular I'd like an easy hook to customize name clash resolution.

To be clear, I'm not against this change, I think making Field and TypeAdapter play well together makes a ton of sense.

Agreed with both @adriangb!

More context on my side:
The main reason why I used GenerateSchema.generate_inner and not something else is because if I'm asking for a model schema, it will give me the {"$ref": "blahblah/Foo"} instead of rendering the model schema at the top level and including internal defs, which is what other methods did (I don't remember exactly which ones I tried).
This way I can re-use that ref schema in OpenAPI.
For FastAPI, the current (and I think sort of ideal? at least up to now) process would be:

Collect all Pydantic fields (including Pydantic models, but also other things), each field is a combination of a type and a FieldInfo (e.g. Annotated[str, Field(description="The name of the user")])
Give a list of all that (some of them reference each other) to GenerateSchema
Get a bunch of definitions that can be put in $defs (or in components in OpenAPI)

Up to this point, the process is just for GenerateSchema to know all the models, resolve name conflicts, and generate the definitions and usable refs.

Later, give GenerateSchema (currently with GenerateSchema.generate_inner) one specific field (not model, a combination of type and FieldInfo)
It gives back something I can inject in OpenAPI, so a {"$ref": "blahblah/Foo"} or a pure JSON Schema for things that don't live in the pre-created definitions.

Now, for this current process, the main thing I'm missing is being able to get all that, but making sure FieldInfo metadata attached to a type is preserved (what this PR does).
But if there's any (feasible) better way to do that process with different steps, that would also be very welcome, of course. 😅

But if there's any (feasible) better way to do that process with different steps, that would also be very welcome, of course

That's what I think we should design :)

each field is a combination of a type and a FieldInfo (e.g. Annotated[str, Field(description="The name of the user")])

I think this is an interesting bit. I get the feeling that FieldInfo is being abused to represent a different concept just because it can hold a type, a default value, and a name (the name matters, e.g. authorization: FromHeader[str] the authorization part matters. But maybe that's fine.
At the very least, I think this PR would be better if the function had the signature generate_schemas(fields: list[FieldInfo], mode: Literal["input", "output"]) -> tuple[list[JsonSchemaValue], dict[str, JsonSchemaValue]] where the returned tuple is (1:1 mapping to input fields, definitions).
And I don't think that should go in TypeAdapter, it seems like a better fit for a function in json_schema.py.

Looking through what we have, we already have a GenerateJsonSchema.generate_definitions that does pretty much exactly what you want Sebastián. It seems like we just need a version that accepts a FieldInfo. Given that you can always convert that to Annotated[field_info.annotation, field_info] (assuming we fix #6353) is there any reason that wouldn't work? I'm also not sure that using a type as a key (which is what GenerateJsonSchema.generate_definitions does) is always going to work, e.g. you could have two List[int] and I'd assume want to treat them separately? Not sure about that last bit.

I think this is an interesting bit. I get the feeling that FieldInfo is being abused to represent a different concept just because it can hold a type, a default value, and a name (the name matters, e.g. authorization: FromHeader[str] the authorization part matters. But maybe that's fine.

Just to clarify, in FastAPI the main class I move around is a custom ModelField that contains the name and the FieldInfo (as the name is not stored anywhere in v2, not even in FieldInfo, only in the parent model if there's one).
Up to now, from what I've seen, the FieldInfo is the lowest common denominator that can store the information and can have information related to more than Pydantic models (it can hold information about lists, ints, etc). I think the lower layer would be pure Pydantic core schemas, but those don't contain the metadata (e.g. description and examples), that metadata is inside closures in callables in the Pydantic core "metadata" dict key.

As it stands right now, I think fixing https://github.com/pydantic/pydantic/issues/6353 and related issues may be a better path forward so that at least TypeAdapter(Annotated[TheType, Field(...)]) works correctly.

Probably, it seems using TypeAdapter currently doesn't generate the extra metadata from FieldInfo for JSON Schema, if solving multiple Field() in annotated solves it, then that would certainly solve it.

Looking through what we have, we already have a GenerateJsonSchema.generate_definitions that does pretty much exactly what you want Sebastián. It seems like we just need a version that accepts a FieldInfo. Given that you can always convert that to Annotated[field_info.annotation, field_info] (assuming we fix https://github.com/pydantic/pydantic/issues/6353) is there any reason that wouldn't work? I'm also not sure that using a type as a key (which is what GenerateJsonSchema.generate_definitions does) is always going to work, e.g. you could have two List[int] and I'd assume want to treat them separately? Not sure about that last bit.

Yep, GenerateJsonSchema.generate_definitions is exactly what I use right now. The only problem is that currently, it doesn't take types, it takes Pydantic core schemas, so Annotated[field_info.annotation, field_info] (which is what I was using up to this PR) still needed to go in a TypeAdapter to extract the Pydantic core schema from that.
I was doing:
TypeAdapter(Annotated[self.field_info.annotation, self.field_info]).core_schema

...but that didn't include the JSON Schema metadata (description, examples, etc).
I was collection all those, and then passing them to GenerateJsonSchema.generate_definitions().
And then the next thing I need to do is "query" the GenerateJsonSchema for the JSON Schema for a specific type annotation (a specific ModelField).
If GenerateJsonSchema.generate_definitions could take FieldInfos directly, that would definitely work. If it still took core schemas but TypeAdapter had a way to generate core schemas that end up including the metadata, that would work as well.
If there are two List[int] without more metadata I think it would be fine to use the same JSON Schema 🤔 ...it would probably be different if one is Annotated[List[int], Query(description="the tokens")] and the other is Annotated[List[int], Query(description="the search terms")], but that's already different, I guess different objects with different id/hash, so that should be fine. I'm not sure if I'm missing something... but I think that's fine how it has worked up to now. The key thing now is being able to pass that, in some way, to GenerateJsonSchema.generate_definitions(), and then being able to query it again.

It also doesn't have to allow "querying" the GenerateJsonSchema.generate_definitions(), if the initial return had a way to map from input to output definitions, I could (probably?) handle the rest outside.


Add env subcommand.

Summary

This subcommand prints out cosign/sigstore environment variables. This
is intended for debugging to make it easy to find environment variables
that might be impacting cosign behavior.
This was inspired by https://github.com/sigstore/gitsign/pull/92
Signed-off-by: Billy Lynch<EMAIL_ADDRESS>cc @imjasonh
Release Note

env subcommand to print out cosign environment variables added.

Documentation

Updated CLI docs.

@imjasonh implemented as a new subcommand because version is coupled to sigs.k8s.io/release-utils/version. Figured this was a good alternative since there's already prior art with go env.

@imjasonh implemented as a new subcommand because version is coupled to sigs.k8s.io/release-utils/version. Figured this was a good alternative since there's already prior art with go env.

This looks good. Should we add gitsign env too, for consistency?


python311Packages.dvc: 3.21.1 -> 3.22.0

Diff: https://github.com/iterative/dvc/compare/refs/tags/3.21.1...3.22.0
Changelog: https://github.com/iterative/dvc/releases/tag/3.22.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256264 run on x86_64-linux 1

10 packages built:

dvc (python310Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python310Packages.dvc.dist)
python310Packages.dvclive
python310Packages.dvclive.dist
python311Packages.dvc
python311Packages.dvc.dist
python311Packages.dvclive
python311Packages.dvclive.dist


python stopped working..

I am trying to use this code for some different data-set, in which image sizes are different (75 x 75) and two channels are there. But It stops working in the beginning with a pop window which states that "python stopped working".
Here are some other details (I modified the demo code).
num_classes = 2
x_train.shape = (1203, 75, 75, 2)
y_train = (1203, 2)
x_test = (401, 75, 75, 2)
y_test = (401, 2)
Rest of the parameters are all same. Image is in 'float32' with normalized between 0 - 1.
Any help??

I updated my jupyter. Now it is working fine.
Thank you for your nice work.  :)


chore: manage monorepo with turborepo

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

The goal of this PR is to simplify management of the monorepo without sacrificing the independence of the apps. Ignoring postgres the following is all we need to stand up the app:
cp publish-backend/sample.env publish-backend/.env
cp publish-frontend/sample.env publish-frontend/.env
npm i
turbo seed
turbo develop

and subsequently you just need to
npm i
turbo develop

The production Dockerfiles are now both in docker/ and have been updated to make use of turbo prune. Otherwise they should be about the same.
I left the existing docker development config in, but I propose we ditch it and just use docker for production.

Finally, I created a compose file to stand up postgres and mailhog. This means that contributors that already have postgres running don't have to worry about conflicting ports. And that contributors without it can set it up quickly.

@ojeytonwilliams Could you resolve the merge conflicts?


Error post deployment in azure kubectl get minions Error: Get http://localhost:8080/api/v1beta3/minions: dial tcp <IP_ADDRESS>:8080: connection refused

Hi,
I have tried this steps but it fails to get minions.
core@kube-00 ~ $ kubectl get minions
Error: Get http://localhost:8080/api/v1beta3/minions: dial tcp <IP_ADDRESS>:8080: connection refused
Deployment was successful without any errors and I can see the all nodes up and running in azure.
Please assist ..
Thank you

Error message posted :
Waiting for cluster initialization.
This will continually check to see if the API for kubernetes is reachable.
This might loop forever if there was some uncaught error during start
up.
...............................................................................................................................................................................................................................
Next step: kubectl run my-nginx --image=nginx --replicas=2 --port=80
Error: unknown command "run"
Run 'kubectl help' for usage.

I have the same problem.

Can someone close this please, it's a duplicate of #9036.

Does this mean I can now download the latest version and re-try install on Azure ?

Sure, it should work if you pull from master and rerun the provisions
scripts.
On Tue, 2 Jun 2015 18:56 srakesh28<EMAIL_ADDRESS>wrote:

Does this mean I can now download the latest version and re-try install on
Azure ?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/9034#issuecomment-108032088
.


Allow using a custom console

Some JS frameworks offer their own wrapper around window.console (i.e. Angular's $log).
It would be very convenient to be able to tell SIP.js which console object to use when trying to print messages.

This is already possible: http://sipjs.com/api/0.5.0/ua_configuration_parameters/#log

Oops, I missed this one. Thanks!


Add: Sum of Two Integers

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #386   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         136    137    +1
  Lines        1408   1412    +4
=====================================
+ Hits         1408   1412    +4

Impacted Files
Coverage Δ

...roblems/sum-of-two-integers/sum_of_two_integers.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de1fc5...ee5486d. Read the comment docs.


[BugFix] Ingest processor cannot read index name from ingestDocument

Description
This PR is focused on fixing an issue from neural search repo. The reason for the bug is that text chunking processor cannot read the index name from the ingestDocument.
When doc_as_upsert is true, the getIndexWriteRequest() function will read the doc field from the update request. This PR is a small fix on BulkRequestParser.java to add index field for the doc in updateRequest.
Related Issues
Resolves https://github.com/opensearch-project/neural-search/issues/798
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross Can you help review this PR? Maybe we can discuss what tests should be added.

The bug has been fixed in https://github.com/opensearch-project/OpenSearch/pull/12891/files. Closing the PR now.


add a more complete list of swedish holidays

The list of Swedish holidays have been updated and added to, to be more complete. Also the first letter in all Swedish holiday names are now in capitals.

Are these all official public holidays?

They all are official public holidays, and swedish traditions, yes! See https://sv.wikipedia.org/wiki/Svenska_högtider_och_traditioner (swedish)

No no no, do not merge this. These are not official public holidays. The only one that is properly missing is "Pingsdagen" / "Whit sunday".
Source:
https://www.riksdagen.se/sv/dokument-lagar/dokument/svensk-forfattningssamling/lag-1989253-om-allmanna-helgdagar_sfs-1989-253
https://www.riksdagen.se/sv/dokument-lagar/dokument/svensk-forfattningssamling/semesterlag-1977480_sfs-1977-480

An other solution is use the type -> for example type: PublicHolidayType.Bank | PublicHolidayType.School | PublicHolidayType.Optional


Fail to install SoS in Windows

Run the following command in powershell:
PS C:\Users\ml69> pip install sos sos-notebook
Got error (the bottom):
Collecting sos
  Using cached sos-<IP_ADDRESS>-py3-none-any.whl
Collecting sos-notebook
  Using cached sos_notebook-<IP_ADDRESS>-py3-none-any.whl
Requirement already satisfied: pygments in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Requirement already satisfied: tqdm in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Requirement already satisfied: pexpect in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Requirement already satisfied: psutil in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Collecting xxhash (from sos)
  Using cached xxhash-1.0.1.zip
Collecting pydot (from sos)
Requirement already satisfied: pyyaml in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Requirement already satisfied: fasteners in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Requirement already satisfied: colorama; sys_platform == "win32" in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Requirement already satisfied: networkx in c:\users\ml69\anaconda3\lib\site-packages (from sos)
Collecting pydotplus (from sos)
Collecting markdown (from sos-notebook)
  Using cached Markdown-2.6.11-py2.py3-none-any.whl
Requirement already satisfied: notebook>=5.0.0 in c:\users\ml69\anaconda3\lib\site-packages (from sos-notebook)
Collecting tabulate (from sos-notebook)
Collecting wand (from sos-notebook)
Requirement already satisfied: ipython in c:\users\ml69\anaconda3\lib\site-packages (from sos-notebook)
Requirement already satisfied: nbconvert>=5.1.1 in c:\users\ml69\anaconda3\lib\site-packages (from sos-notebook)
Requirement already satisfied: ipykernel in c:\users\ml69\anaconda3\lib\site-packages (from sos-notebook)
Requirement already satisfied: nbformat in c:\users\ml69\anaconda3\lib\site-packages (from sos-notebook)
Requirement already satisfied: ptyprocess>=0.5 in c:\users\ml69\anaconda3\lib\site-packages (from pexpect->sos)
Requirement already satisfied: pyparsing>=2.1.4 in c:\users\ml69\anaconda3\lib\site-packages (from pydot->sos)
Requirement already satisfied: monotonic>=0.1 in c:\users\ml69\anaconda3\lib\site-packages (from fasteners->sos)
Requirement already satisfied: six in c:\users\ml69\anaconda3\lib\site-packages (from fasteners->sos)
Requirement already satisfied: decorator>=4.1.0 in c:\users\ml69\anaconda3\lib\site-packages (from networkx->sos)
Requirement already satisfied: setuptools>=18.5 in c:\users\ml69\anaconda3\lib\site-packages (from ipython->sos-notebook)
Requirement already satisfied: jedi>=0.10 in c:\users\ml69\anaconda3\lib\site-packages (from ipython->sos-notebook)
Requirement already satisfied: pickleshare in c:\users\ml69\anaconda3\lib\site-packages (from ipython->sos-notebook)
Requirement already satisfied: simplegeneric>0.8 in c:\users\ml69\anaconda3\lib\site-packages (from ipython->sos-notebook)
Requirement already satisfied: traitlets>=4.2 in c:\users\ml69\anaconda3\lib\site-packages (from ipython->sos-notebook)
Requirement already satisfied: prompt_toolkit<2.0.0,>=1.0.4 in c:\users\ml69\anaconda3\lib\site-packages (from ipython->sos-notebook)
Requirement already satisfied: mistune>=0.7.4 in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: jinja2 in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: jupyter_core in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: entrypoints>=0.2.2 in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: bleach in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: pandocfilters>=1.4.1 in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: testpath in c:\users\ml69\anaconda3\lib\site-packages (from nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: jupyter_client in c:\users\ml69\anaconda3\lib\site-packages (from ipykernel->sos-notebook)
Requirement already satisfied: tornado>=4.0 in c:\users\ml69\anaconda3\lib\site-packages (from ipykernel->sos-notebook)
Requirement already satisfied: ipython_genutils in c:\users\ml69\anaconda3\lib\site-packages (from nbformat->sos-notebook)
Requirement already satisfied: jsonschema!=2.5.0,>=2.4 in c:\users\ml69\anaconda3\lib\site-packages (from nbformat->sos-notebook)
Requirement already satisfied: wcwidth in c:\users\ml69\anaconda3\lib\site-packages (from prompt_toolkit<2.0.0,>=1.0.4->ipython->sos-notebook)
Requirement already satisfied: MarkupSafe>=0.23 in c:\users\ml69\anaconda3\lib\site-packages (from jinja2->nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: html5lib>=0.99999999 in c:\users\ml69\anaconda3\lib\site-packages (from bleach->nbconvert>=5.1.1->sos-notebook)
Requirement already satisfied: pyzmq>=13 in c:\users\ml69\anaconda3\lib\site-packages (from jupyter_client->ipykernel->sos-notebook)
Requirement already satisfied: python-dateutil>=2.1 in c:\users\ml69\anaconda3\lib\site-packages (from jupyter_client->ipykernel->sos-notebook)
Requirement already satisfied: webencodings in c:\users\ml69\anaconda3\lib\site-packages (from html5lib>=0.99999999->bleach->nbconvert>=5.1.1->sos-notebook)
Building wheels for collected packages: xxhash
  Running setup.py bdist_wheel for xxhash ... error
  Complete output from command C:\Users\ml69\anaconda3\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\ml69\\AppData\\Local\\Temp\\pip-build-wlz8q2on\\xxhash\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d C:\Users\ml69\AppData\Local\Temp\tmpnaujf4dcpip-wheel- --python-tag cp36:
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-3.6
  creating build\lib.win-amd64-3.6\xxhash
  copying xxhash\cffi.py -> build\lib.win-amd64-3.6\xxhash
  copying xxhash\__init__.py -> build\lib.win-amd64-3.6\xxhash
  running build_ext
  building 'cpython' extension
  error: [WinError 3] The system cannot find the path specified: 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\PlatformSDK\\lib'

  ----------------------------------------
  Failed building wheel for xxhash
  Running setup.py clean for xxhash
Failed to build xxhash
Installing collected packages: xxhash, pydot, pydotplus, sos, markdown, tabulate, wand, sos-notebook
  Running setup.py install for xxhash ... error
    Complete output from command C:\Users\ml69\anaconda3\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\ml69\\AppData\\Local\\Temp\\pip-build-wlz8q2on\\xxhash\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record C:\Users\ml69\AppData\Local\Temp\pip-qczbq2i7-record\install-record.txt --single-version-externally-managed --compile:
    running install
    running build
    running build_py
    creating build
    creating build\lib.win-amd64-3.6
    creating build\lib.win-amd64-3.6\xxhash
    copying xxhash\cffi.py -> build\lib.win-amd64-3.6\xxhash
    copying xxhash\__init__.py -> build\lib.win-amd64-3.6\xxhash
    running build_ext
    building 'cpython' extension
    **error: [WinError 3] The system cannot find the path specified: 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\PlatformSDK\\lib'

    ----------------------------------------
Command "C:\Users\ml69\anaconda3\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\ml69\\AppData\\Local\\Temp\\pip-build-wlz8q2on\\xxhash\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record C:\Users\ml69\AppData\Local\Temp\pip-qczbq2i7-record\install-record.txt --single-version-externally-managed --compile" failed with error code 1 in C:\Users\ml69\AppData\Local\Temp\pip-build-wlz8q2on\xxhash\**

Information of this machine:

Also, should I open another ticket for changing the installation guide for windows user?

This is related to #875 in which we replaced the system hash module with a third-party one. This module needs to be compiled from source, which is usually not a problem but is causing problem under windows.
My windows machine has VC installed and can install xxhash, therefore sos without problem.
@gaow  any comment?

I also installed VC on this machine. Let me try to install xxhash

Fail to do so...
PS C:\Users\ml69> pip install xxhash
Collecting xxhash
  Using cached xxhash-1.0.1.zip
Building wheels for collected packages: xxhash
  Running setup.py bdist_wheel for xxhash ... error
  Complete output from command C:\Users\ml69\anaconda3\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\ml69\\AppData\\Local\\Temp\\pip-build-t3ea_pri\\xxhash\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d C:\Users\ml69\AppData\Local\Temp\tmpwrnvk6zjpip-wheel- --python-tag cp36:
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-3.6
  creating build\lib.win-amd64-3.6\xxhash
  copying xxhash\cffi.py -> build\lib.win-amd64-3.6\xxhash
  copying xxhash\__init__.py -> build\lib.win-amd64-3.6\xxhash
  running build_ext
  building 'cpython' extension
  error: [WinError 3] The system cannot find the path specified: 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\PlatformSDK\\lib'

  ----------------------------------------
  Failed building wheel for xxhash
  Running setup.py clean for xxhash
Failed to build xxhash
Installing collected packages: xxhash
  Running setup.py install for xxhash ... error
    Complete output from command C:\Users\ml69\anaconda3\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\ml69\\AppData\\Local\\Temp\\pip-build-t3ea_pri\\xxhash\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record C:\Users\ml69\AppData\Local\Temp\pip-45daqtxo-record\install-record.txt --single-version-externally-managed --compile:
    running install
    running build
    running build_py
    creating build
    creating build\lib.win-amd64-3.6
    creating build\lib.win-amd64-3.6\xxhash
    copying xxhash\cffi.py -> build\lib.win-amd64-3.6\xxhash
    copying xxhash\__init__.py -> build\lib.win-amd64-3.6\xxhash
    running build_ext
    building 'cpython' extension
    error: [WinError 3] The system cannot find the path specified: 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\PlatformSDK\\lib'

    ----------------------------------------
Command "C:\Users\ml69\anaconda3\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\ml69\\AppData\\Local\\Temp\\pip-build-t3ea_pri\\xxhash\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record C:\Users\ml69\AppData\Local\Temp\pip-45daqtxo-record\install-record.txt --single-version-externally-managed --compile" failed with error code 1 in C:\Users\ml69\AppData\Local\Temp\pip-build-t3ea_pri\xxhash\

They need specific version of VC that is compatible with Python. From the error message, it is looking for The system cannot find the path specified: 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\PlatformSDK\\lib. Do you have VS 14.0 installed?

Yes, I have it installed. Just google it and people said that \\PlatformSDK\\lib won't exist unless having SDK installed. Waiting for the installation of SDK... It takes couple hours.

So we can either switch back to hash on windows, or require users to install VC. I personally would prefer the former.

If requiring users to install VC and SDK, it might take a lot of disk space and time, and some of the users might never use VC and SDK (it should be the case in my office...)

So we can either switch back to hash on windows,
Do you mean keeping xxhash for LINUX and macOS users, or also using hash for them?

That is my plan but I will wait for @gaow 's comment. Basically we will have to conditionally use xxhash in setup.py, and modify https://github.com/vatlab/SoS/commit/700ea2dd5826ad6a37e344443d789f0e22b719b8

Sorry about the unexpected troubles with xxhash. I guess it is a judgement call whether xxhash's benefit in speeding up hashing is worth treating separately, because that will make cross windows / non-windows signatures not portable. But it is not an issue for now since we are still pending on #850 ? Since windows is much less likely used in large scale analysis that are expected to be portable, I'd support switching back to hash on Windows.

Also pending on #899 since right now signatures are verified locally, not across network to a centralized server. Given the status of sos on windows, I think it makes sense to make it easier to install.

Successfully installed sos kernel after I install SDK.

Tried to remove SDK and SoS, then reinstall it with the new patch, it works. I think I can close this ticket.


OVN SSL Checks

This patch aims to add SSL certificates validation for OVN.
It currently verifies the certificate name by the package name,
and adds information to the openvswitch summary in case ovn-host
or is ovn-central is installed.
Closes: #325
Signed-off-by: David Negreira<EMAIL_ADDRESS>

Abandoning this pull request since it has not had any updates in months. Feel free to re-open and update whenever you want.


hello_xr crash on Oculus runtime using Vulkan

Current on the Oculus runtime, the hello_xr example crashes.
The crash occurs at the following line, where xrSuggestInteractionProfileBindings seems to fail:
https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/51cade1763267c750f53cefa9834644c7e7b37f3/src/tests/hello_xr/openxr_program.cpp#L483
The actual crash however happens because of an access violation in ~OpenXrProgram() when running xrDestroySession.
On release the call just fails gracefully without ~OpenXrProgram failing too.
Additionally, here's the log:
[13:28:11.123][Info   ] Press any key to shutdown...
[13:28:11.174][Info   ] Available Layers: (0)
[13:28:11.191][Info   ] Instance RuntimeName=Oculus RuntimeVersion=1.49.0
[13:28:11.193][Info   ] Available View Configuration Types: (1)
[13:28:11.193][Info   ] Available Environment Blend Mode count : (1)
[13:28:11.193][Info   ] Environment Blend Mode (XR_ENVIRONMENT_BLEND_MODE_OPAQUE) : (Selected)
[13:28:11.272][Info   ] INFO: (INSTANCE 0x1ddcf6a0080) [Loader Message] Loading layer library C:\VulkanSDK\<IP_ADDRESS>\Bin\.\VkLayer_khronos_validation.dll
[13:28:11.272][Info   ] INFO: (INSTANCE 0x1ddcf6a0080) [Loader Message] Inserted device layer VK_LAYER_KHRONOS_validation (C:\VulkanSDK\<IP_ADDRESS>\Bin\.\VkLayer_khronos_validation.dll)
[13:28:11.272][Info   ] INFO: (INSTANCE 0x1ddcf6a0080) [Loader Message] Loading layer library C:\WINDOWS\System32\DriverStore\FileRepository\u0355311.inf_amd64_183b8d63847c90cf\B355199\.\amdvlk64.dll
[13:28:11.272][Info   ] INFO: (INSTANCE 0x1ddcf6a0080) [Loader Message] Failed to find vkGetDeviceProcAddr in layer C:\WINDOWS\System32\DriverStore\FileRepository\u0355311.inf_amd64_183b8d63847c90cf\B355199\.\amdvlk64.dll
[13:28:11.313][Info   ] Loaded vertex shader
[13:28:11.313][Info   ] Loaded fragment shader
[13:28:11.371][Info   ] Swapchain length 1
[13:28:11.421][Error  ] ERROR: (DEVICE 0x1ddd60bce90) [Validation] Validation Error: [ UNASSIGNED-CoreValidation-Shader-FeatureNotEnabled ] Object 0: handle = 0x1ddd60bce90, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x8c548bfd | Shader requires VkPhysicalDeviceFeatures::shaderStorageImageMultisample but is not enabled on the device
[13:28:11.439][Info   ] Available reference spaces: 3
[13:28:11.441][Error  ] ERROR: (INSTANCE 0x1ddcf6a0080) [Validation] Validation Error: [ VUID-vkDestroyImage-image-parameter ] Object 0: handle = 0x1ddcf6a0080, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x18c56777 | Invalid VkImage Object 0x1ddd6724190. The Vulkan spec states: If image is not VK_NULL_HANDLE, image must be a valid VkImage handle (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.2-extensions/vkspec.html#VUID-vkDestroyImage-image-parameter)
[13:28:11.441][Error  ] ERROR: (IMAGE 0x1ddd6724190) [Validation] Validation Error: [ UNASSIGNED-Threading-Info ] Object 0: handle = 0x1ddd6724190, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0x5d6b67e2 | Couldn't find VkImage Object 0x1ddd6724190. This should not happen and may indicate a bug in the application.

I've updated the issue with a fixed line number, I got the wrong one, along with more info as on release the error is different.

Hi @LaylConway, are you on the public test channel? I've verified that it's fixed in our upcoming v19 release.

I checked the PTC, the xrSuggestInteractionProfileBindings has been fixed, but there continue to be access violations raised by the validation layers because of reported invalid images. Since the original issue was xrSuggestInteractionProfileBindings, I'll close this issue.


Imports consumed in later cells flagged as unused with LSP notebooks

This was reported via a Marketplace review:

When I use Jupyter notebook and put the imported modules in a separate cell, Pylance always shows "module not used/module not accessed" despite the fact that they are used in the cells below. The bug needs to be fixed. (Then I installed old version v2022.5.1, there is no such problem)

This repros when the LSP notebooks experiment is enabled (but not with concat docs) because we aren't checking to see if symbols imported in a cell are used in later cells.

These features will be disabled for LSP notebooks in the next release. We don't see any good ways to support these features when LSP notebooks are in use.

This issue has been fixed in version 2022.7.21, which we've just released. You can find the changelog here: CHANGELOG.md


[4.0][TSan] Change TSan inout accesses to use __tsan_external_write callba…

…ck (#11032)
Adopt the  __tsan_external_write compiler-rt callbacks when IRGen'ing
the TSan inout access builtin.
rdar://problem/32260994
rdar://problem/33461691

Approved by Ted.

@swift-ci Please test and merge


Fails to assign milestone

The action doesn't actually assign pull requests to milestones and there's few warnings when running it -
(node:1763) UnhandledPromiseRejectionWarning: HttpError: Resource not accessible by integration
    at /home/runner/work/_actions/zoispag/action-assign-milestone/v1/webpack:/action-assign-milestone/node_modules/@octokit/request/dist-node/index.js:86:1
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:1763) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1763) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Hey @vadi2.
Thanks for reporting the issue.
It does work for me, see:

but indeed, does not work for PRs originated by dependabot (which used to work as well).
Is this PR created by a user marked as bot by GitHub?

It's created by a user, though I'm also committing the workflow itself in the same PR. Maybe that is it

It's created by a user, though I'm also committing the workflow itself in the same PR. Maybe that is it

Ah, it is possible that this is the reason. I know GitHub changed something recently and it stopped working for me for PRs made by dependabot. Let me know if it works when the workflow is already committed.


Use volume control to lock/unlock

In addition to the unlock button presented at the lower right corner of the canvas, allow locking/unlocking with the physical volume control buttons of the phone.

Mind if I give this a go? :)

Absolutely not! :+1: please let me know if I can be any help setting up the project.


[#551] Prevent screenshots when seed phrase is displayed on the screen

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[x] Automated tests: Did you add appropriate automated tests for any code changes?
[x] Manual tests: Did you update the manual tests as appropriate? While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.
[ ] Documentation: Did you update documentation as appropriate? (e.g README.md, etc.)
[x] Run the app: Did you run the app and try the changes?
[ ] Screenshots: Did you provide before and after UI screenshots in the description of this pull request?  This is only applicable for changes that modify the UI.
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[x] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[x] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[x] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?
[x] How is code coverage affected? We encourage you to compare coverage before and after changes and when possible, leaving it in a better place.
[ ] Documentation: Did you review Docs, README.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

I'm not sure this is conceptually correct. users might want to screenshot their seed phrase in the absence of pen and paper to effectively backup their seed.
I would also interfere with on-the-go onboardings like the ones Zooko does. Taking a screenshot of the seed is much safer than taking an improvised note on a napkin to be able to pass the test.
I think this needs to be reviewed and analyzed further. @geffenz

Thanks Pacu, those are valuable points.  The core intention of this PR is that we have the hooks to signal certain screens should be secure.  In the future, if we decide to not act on those hooks, it can be quickly disabled with a one-line change.
For now I believe this is a good option, as it keeps screenshots from leaking into Google Photos, Dropbox, OneDrive, etc.
We have a separate upcoming issue to enable users to vault their seed with the Google Credential Manager #301, to help solve the issue with users not having a simple default option to save their seed phrase.  When this issue and #301 are combined, I think we will have improved security, reduced risk of users losing funds, and improved usability.


Adding fixes and workarounds to allow compilation with nvcc/msvc (VS2015up3)

This also fixes some possible problems with base_lco_with_value

We should have really reverted the nvcc flags and look for a proper fix.
Not everyone wants to keep the intermediates and have verbose output.
Am 07.12.2016 11:17 nachm. schrieb "Hartmut Kaiser" <
<EMAIL_ADDRESS>
Merged #2416 https://github.com/STEllAR-GROUP/hpx/pull/2416.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/STEllAR-GROUP/hpx/pull/2416#event-886017397, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADRl0rQiPfrfM8W3eMMdPx0Xhv-MK_5ks5rFzCVgaJpZM4LAqQA
.

I will remove --verbose and --keep


[ISSUE #2941] Polish lite pull consumer code style

Make sure set the target branch to develop
What is the purpose of the change
Polish lite pull consumer code style
Brief changelog
Modify  DefaultLitePullConsumerImpl class
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.1%) to 53.979% when pulling 14f37fb578efcd3bc115d04a2808352e925bd750 on RongtongJin:develop into<PHONE_NUMBER>a3fb71d4473e2451cf174ad560fa2a on apache:develop.

Codecov Report

Merging #2942 (0430860) into develop (3e1d501) will increase coverage by 0.13%.
The diff coverage is 0.00%.

:exclamation: Current head 0430860 differs from pull request most recent head 14f37fb. Consider uploading reports for the commit 14f37fb to get more accurate results

@@              Coverage Diff              @@
##             develop    #2942      +/-   ##
=============================================
+ Coverage      47.75%   47.89%   +0.13%
- Complexity      4527     4539      +12
=============================================
  Files            552      552
  Lines          36518    36522       +4
  Branches        4831     4832       +1
=============================================
+ Hits           17440    17492      +52
+ Misses         16849    16809      -40
+ Partials        2229     2221       -8

Impacted Files
Coverage Δ
Complexity Δ

...tmq/namesrv/processor/DefaultRequestProcessor.java
35.93% <0.00%> (-0.50%)
17.00 <0.00> (ø)

...rg/apache/rocketmq/common/stats/StatsSnapshot.java
84.61% <0.00%> (-15.39%)
7.00% <0.00%> (-2.00%)

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
2.00% <0.00%> (-1.00%)

...ache/rocketmq/common/stats/MomentStatsItemSet.java
43.47% <0.00%> (-8.70%)
6.00% <0.00%> (-1.00%)

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
71.15% <0.00%> (-7.70%)
10.00% <0.00%> (-1.00%)

...va/org/apache/rocketmq/common/stats/StatsItem.java
52.50% <0.00%> (-1.67%)
13.00% <0.00%> (+1.00%)
:arrow_down:

...n/java/org/apache/rocketmq/store/ha/HAService.java
71.47% <0.00%> (-0.66%)
17.00% <0.00%> (ø%)

.../main/java/org/apache/rocketmq/common/UtilAll.java
37.98% <0.00%> (-0.33%)
43.00% <0.00%> (ø%)

...mq/client/impl/producer/DefaultMQProducerImpl.java
44.77% <0.00%> (ø)
82.00% <0.00%> (ø%)

...main/java/org/apache/rocketmq/store/CommitLog.java
66.52% <0.00%> (+0.10%)
79.00% <0.00%> (ø%)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1d501...14f37fb. Read the comment docs.


storybook and cra updates

sets up a new storybook app with basic stories
sets up a new cra app with previous App.js
changes rollup config to output umd modules instead of cjs
updates app to rollup v1
updates app to babel v7

Is there any reason to keep the example directory and contents?

@MikeLockz I don't think so. That's why I deleted it. Is it still there?


Questionnaire explainer modal

Currently the user is launched into the questionnaire at the start of the app, without knowing anything about how the answers are to be used. Suggested feature to make the benefit of answering the questionnaire apparent:
Button in the questionnaire brings up modal with explanation:"this app contains information explaining 64 different topics that are relevant to many newcomers. If you answer these questions, the app will collect all the topics that will help you in your particular situation"
Acceptance Criteria

[ ]

Steps for QA:

See what users are saying about the new questionnaire, now that it is hooked to the onboarding flow, before we decide if this is a good idea


Fixing build on android: removed createJSModules

Fixing build on android: removed createJSModules …In react-native 0.47 there is no createJSModules method anymore to override in android/src/main/java/com/reactlibrary/RNSqlite2Package.java. I removed it since it is causing a build error. :)

LGTM. Thanks for your contribution!

I'm getting this error, what I shoud do? I have opened a new issue #28


RW Source Manager - Failed Sink Job (Inconsistent State between Durable & In-Memory Cache)

Describe the bug
As per discussions with Tianxiao Shen, the Source Manager component in Rising Wave, had stopped scheduling the job, due to inconsistent state between the RW Database (durable state) and RW REDIS (in-memory cache). Thus, we were asked to perform ANY or ALL of the 3 options :

Fire RECOVER command
Restart RW Cluster
Drop and Recreate RW Sink

Given that we would have RW Sinks in the tune of 1000s, this anomaly would be catastrophic for Production scenarios. Can you please fix this bug and also let me know, if we could have an Alerting Mechanism for such scenarios.
Error message/log
No errors were reported in our RW Cloud Portal or even programmatically we did not get exceptions. This is most concerning because in a Production scenario when we have about 2000 Sinks running, ALL of them could silently fail, without we being alerted about this.
This primarily means loss of revenue !!!
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
Rising Wave Cloud
The version of RisingWave
v1.10.0-rc.1-patch-us-west-2-11-type-mismatch-patch
Additional context

The issue was reported on Friday 09-August-2024 around 1:30 PM (Indian Standard Time)
The Source was working fine, as we were able to query the Source, however the Sink was not reflecting the data.

cc. @xxchan Can you elaborate on

inconsistent state between the RW Database (durable state) and RW REDIS (in-memory cache)

Didn't get what is RW REDIS (in-memory cache). Does it mean a Redis Sink?

It's source_fragments in source manager being outdated and not consistent with table fragments info.

https://risingwave-labs.slack.com/archives/C0606NNR74P/p1723192165241219?thread_ts=1723191534.743279&cid=C0606NNR74P
https://www.notion.so/risingwave-labs/Geniusmind-Data-not-sinked-939611f015db4370afe7305aebdc1cd4?pvs=4

It's source_fragments in source manager being outdated and not consistent with table fragments info.

https://risingwave-labs.slack.com/archives/C0606NNR74P/p1723192165241219?thread_ts=1723191534.743279&cid=C0606NNR74P


Nuclide's Autocomplete failed with flow's lib/react.js.

I have a same issue #417 in nuclide previously,and nuclide confirmed this is belong to flow.
The problem happened when  Nuclide's Autocomplete work with flow's lib/react.js.
When lib/react.js is short enough, Autocomplete will work right:
When lib/react.js get longer,Autocomplete will fail, seems caused by nuclide directly use the contents of module as the type hint for something imported from a module.( seems failed with some complex syntax ? )
I tested this issue with flow's Repository,these are results:
With short  lib/react.js like this,Autocomplete work correctly:
declare module react {
  declare var Children: any;
  declare var DOM: any;
  declare var PropTypes: ReactPropTypes;
  declare var version: string;
  declare function initializeTouchEvents(shouldUseTouch: boolean): void;
}

the type is shown like:

and Autocomplete is shown as:

With full long contents of lib/react.js as flow's react.js#L148 Autocomplete failed:
no Autocomplete information for module,and the type hint is shown as any

(as a module,the type should be any,but seems marked it with module 'react' should be better? or give it a typename as descibed below?)
modified react.js#L148 declare type React,will give it a type like this have some help in resolution?
declare module react {
  declare type React = {
      Children: any;
      DOM: any;
  };
  declare var exports: React;
}

though as directly imported , the result will be an object type. but this will give an additional type React which can be imported.

I have the same issue using the last version of both flow and nuclide.
I guess it's a important issue as flow is mainly used with react.


VS2017现在编译不通过了，年久失修？

连asio工程下，detail文件夹都没有了

asio是个submodule，你得在tinyrpc目录下运行git submodule update --init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX
.

问题是asio目录下没有detail目录，代码中用到了
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 19:56，Chuntao Hong 写道：
asio是个submodule，你得在tinyrpc目录下运行git submodule update --init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

正常的话应该有tinyrpc/tinyrpc/asio/asio/include/asio/detail
On Sat, Mar 9, 2019 at 9:54 PM xiaocjnu<EMAIL_ADDRESS>wrote:

问题是asio目录下没有detail目录，代码中用到了
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 19:56，Chuntao Hong 写道：
asio是个submodule，你得在tinyrpc目录下运行git submodule update --init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471179036, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABFI4XiVEMTfEaGRzLx3OX6vOcOAr4Ikks5vU70QgaJpZM4bk9GX
.

有的，那就是git上的sln文件有问题
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 22:32，Chuntao Hong 写道：
正常的话应该有tinyrpc/tinyrpc/asio/asio/include/asio/detail
On Sat, Mar 9, 2019 at 9:54 PM xiaocjnu<EMAIL_ADDRESS>wrote:

问题是asio目录下没有detail目录，代码中用到了
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 19:56，Chuntao Hong 写道：
asio是个submodule，你得在tinyrpc目录下运行git submodule update --init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471179036, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABFI4XiVEMTfEaGRzLx3OX6vOcOAr4Ikks5vU70QgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

你是不是选的x86编译？Platform(平台)得选x64，x86的编译选项不行。我应该在sln里把x86都删了 :-P
On Sat, Mar 9, 2019 at 10:35 PM xiaocjnu<EMAIL_ADDRESS>wrote:

有的，那就是git上的sln文件有问题
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 22:32，Chuntao Hong 写道：
正常的话应该有tinyrpc/tinyrpc/asio/asio/include/asio/detail
On Sat, Mar 9, 2019 at 9:54 PM xiaocjnu<EMAIL_ADDRESS>wrote:

问题是asio目录下没有detail目录，代码中用到了
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 19:56，Chuntao Hong 写道：
asio是个submodule，你得在tinyrpc目录下运行git submodule update --init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471179036, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/ABFI4XiVEMTfEaGRzLx3OX6vOcOAr4Ikks5vU70QgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471182998, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABFI4Zb3EW2w8OiOgoz3u4StN2F1Eacdks5vU8augaJpZM4bk9GX
.

删掉了，你再pull一下应该就只有x64的platform了
On Sat, Mar 9, 2019 at 10:38 PM 洪春涛<EMAIL_ADDRESS>wrote:

你是不是选的x86编译？Platform(平台)得选x64，x86的编译选项不行。我应该在sln里把x86都删了 :-P
On Sat, Mar 9, 2019 at 10:35 PM xiaocjnu<EMAIL_ADDRESS>wrote:

有的，那就是git上的sln文件有问题
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 22:32，Chuntao Hong 写道：
正常的话应该有tinyrpc/tinyrpc/asio/asio/include/asio/detail
On Sat, Mar 9, 2019 at 9:54 PM xiaocjnu<EMAIL_ADDRESS>wrote:

问题是asio目录下没有detail目录，代码中用到了
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 19:56，Chuntao Hong 写道：
asio是个submodule，你得在tinyrpc目录下运行git submodule update
--init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471179036, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/ABFI4XiVEMTfEaGRzLx3OX6vOcOAr4Ikks5vU70QgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471182998, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABFI4Zb3EW2w8OiOgoz3u4StN2F1Eacdks5vU8augaJpZM4bk9GX
.

我明天试一下，谢谢
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 22:43，Chuntao Hong 写道：
删掉了，你再pull一下应该就只有x64的platform了
On Sat, Mar 9, 2019 at 10:38 PM 洪春涛<EMAIL_ADDRESS>wrote:

你是不是选的x86编译？Platform(平台)得选x64，x86的编译选项不行。我应该在sln里把x86都删了 :-P
On Sat, Mar 9, 2019 at 10:35 PM xiaocjnu<EMAIL_ADDRESS>wrote:

有的，那就是git上的sln文件有问题
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 22:32，Chuntao Hong 写道：
正常的话应该有tinyrpc/tinyrpc/asio/asio/include/asio/detail
On Sat, Mar 9, 2019 at 9:54 PM xiaocjnu<EMAIL_ADDRESS>wrote:

问题是asio目录下没有detail目录，代码中用到了
| |
xiaocjnu
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
在2019年03月09日 19:56，Chuntao Hong 写道：
asio是个submodule，你得在tinyrpc目录下运行git submodule update
--init才能把asio给clone下来
On Fri, Mar 8, 2019 at 5:14 PM xiaocjnu<EMAIL_ADDRESS>wrote:

连asio工程下，detail文件夹都没有了
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5, or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABFI4T5XMsn3V5GMzEgbBnA_EcVc6LwOks5vUinXgaJpZM4bk9GX

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471179036, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/ABFI4XiVEMTfEaGRzLx3OX6vOcOAr4Ikks5vU70QgaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hjk41/tinyrpc/issues/5#issuecomment-471182998, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABFI4Zb3EW2w8OiOgoz3u4StN2F1Eacdks5vU8augaJpZM4bk9GX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Allow simple expressions in env var expansion

Implements the grammar defined in https://github.com/superfly/litefs/issues/176.

Sweet!


Sticky is sometimes not initialized

Under certain condition Sticky component is not initialized. That means that className or style is not set for Sticky component.
Here is a demo https://jsfiddle.net/Halama/Le8trz6e/1/
Problem is that event which triggers initialization is not fired https://github.com/captivationsoftware/react-sticky/blob/538bbf3603d674ea6e884e5278e9db36dc34a3ce/sticky.js#L45
I have fixed it in this PR by setting className in getInitialState, it works for our use cases, but I think that better solution would be somehow force handleTick to run after componentDitMount. I have tried add this.hasUnhandledEvent = true; before https://github.com/captivationsoftware/react-sticky/blob/538bbf3603d674ea6e884e5278e9db36dc34a3ce/sticky.js#L78 to force the intialization but i was getting Cannot read property 'firstChild' of .. error #17
thanks
M

Hey, so I'd like to get a little more information about your environment if I could, because I'm def not seeing this. I'm inclined to agree with you that the better fix would be setting this.hasUnhandledEvent = true in componentDidMount. The fact that it ONLY raises the first child error in that case is pretty strange. After doing a little research, issue #17 is usually the result of multiple react libs not using the same versions of React and/or not using peer dependencies. What other react-libs are you using along with react-sticky? And in which browser/OS are you seeing the issue ?
Thanks!

So following up... I went ahead and implemented this.hasUnhandledEvent = true on master, since it had the added benefit of making firing the component on load completely unnecessary. I also made another change whereby I'm not calling the deprecated this.getDOMNode() whenever React.findDOMNode is available in the event you are using ES6 style classes. Give whats on master a shot if you don't mind and see how it suits your needs.

Hi,
I've finally updated the application to use latest version (2.5.2) of react-sticky and it works great. This issue is solved.
thanks


e2e: Add test for prometheus-operator PVC

This commit adds a code to verify if the PVCs in the prometheus-operator
component reach the Bound phase in the record time.

We are checking if the expected names' PVC is bound. If prometheus-operator changes the naming convention below us we will know that the names expected PVC are not created at all.


How long will be the domain data stored after it is deleted

Which Cloudflare product does this pertain to?
<IP_ADDRESS>
Existing documentation URL(s)
https://developers.cloudflare.com/fundamentals/get-started/basic-tasks/manage-domains/remove-domain/
Section that requires update
I just noted that the settings are still there after the domain is readded ?
So, How long will be the domain setting data stored after it is deleted for free plan.
What needs to change?
Update.
how to trigger completely deleted the domain setting data?
How should it change?
Support manually complete deleted settings immediately.
Additional information
No response

Your audit logs (which contains your configuration history) can stay there for up to 18 months.


Add Netapp https authentication method

This PR has https authentication method for Netapp.

Thank you for contributing to openstack/cinder!
openstack/cinder uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


(Makefile) clean up kustomization and Makefile

Change command to one word.
Add confirmation dialog to delete command

Need to mkdir cert-manager and kubeflower-issuer build folder.

Please feel free to review and comment later. I will create separate PR for the comments.


Add missing nightly checkouts on jobs

Added missing nightly branch checkout on jobs
Test: https://github.com/MOV-AI/project-movai-studio/actions/runs/8750720004

[x] Make sure you are opening from a topic/feature/bugfix branch
[x] Ensure that the PR title represents the desired changes
[x] Ensure that the PR description detail the desired changes
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[^note]:
Put an x into the [ ] to show you have filled the information.
The template comes from https://github.com/MOV-AI/.github/blob/master/.github/pull_request_template.md
You can override it by creating .github/pull_request_template.md  in your own repository

Let's go!


Create a Swift Package

[ ] Create a Swift Package
[ ] Differentiate the code into reusable forms like a static row or a row with the navigation link.

Any progress on this?

Hi @haroutig, I've to rewrite a lot of parts to make the rows reusable. After I'm done with it, I'll create the Swift Package. Thank you!


add a news page

to publish information on updates leading to the conference that will provide vital data on plans, activities and proceedings prior to the main conference

fixed


Revert "Changed downloads to use intermediate partial file and cache node.js download."

Reverts Microsoft/vsts-agent#247

why are we reverting?


Make SQLite.SQLiteConnection.MigrateTable as public method

Hi ,
Can "MigrateTable" be made a public method?
We had a situation in our mobile apps where we had to upgrade our application but it would require end-user losing data.
Resulting us to check for any alternative method to check for missing column and add to it. Luckily while reading the code we realized that by just making  "migratable" we were able to get the application to check at the start for any missing columns and add using this function.
Thought it would be helpful for others.
Here is the usage
public void Checktable(string pathToDatabase , Type ObjType)
{
using (var db = new SQLiteConnection(pathToDatabase))
{
//typeof(tableObj.type)
var map = db.GetMapping(ObjType);
db.MigrateTable(map);
}
}
called in
sqliteHelperObj.Checktable(pathToDatabase, typeof(DAL.Models.Patient));

Thanks for this.  I have encountered the same issue with app upgrades.  I agree, it would be helpful if MigrateTable() would be made public.


Bump cert-manager to v1.9.0

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updated cert-manager to v1.9.0.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Updated cert-manager to v1.9.0.

Codecov Report

Merging #1043 (e9e3790) into main (afec96f) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

:exclamation: Current head e9e3790 differs from pull request most recent head c09505f. Consider uploading reports for the commit c09505f to get more accurate results

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   50.73%   50.09%   -0.65%
==========================================
  Files          42       42
  Lines        4766     4779      +13
==========================================
- Hits         2418     2394      -24
- Misses       2262     2299      +37
  Partials       86       86

/lgtm

/retest

/test pull-security-profiles-operator-test-e2e

/test pull-security-profiles-operator-test-e2e

/test pull-security-profiles-operator-test-e2e

/retest

/lgtm
/approve

/test pull-security-profiles-operator-test-e2e

/test pull-security-profiles-operator-test-e2e


cmd/compile: wrong line offset for "cannot use ... in argument" error

I'm enjoying having the offset-within-the-line information printed in the compiler errors, because my editor is set up to jump to the exact position being printed, which is really very nice.
But I found an example where the offset seems to be wrong:
package p

var s string

func f(x, y, z int) int

func g() int {
	return f("hello", s, "world")
	return f(s, "hello", "world")
}

Every argument to f in the two return statements is wrong: f takes ints and they're all strings.
$ go tool compile /tmp/x.go
/tmp/x.go:8:11: cannot use "hello" (type string) as type int in argument to f
/tmp/x.go:8:11: cannot use s (type string) as type int in argument to f
/tmp/x.go:8:23: cannot use "world" (type string) as type int in argument to f
/tmp/x.go:9:10: cannot use s (type string) as type int in argument to f
/tmp/x.go:9:14: cannot use "hello" (type string) as type int in argument to f
/tmp/x.go:9:23: cannot use "world" (type string) as type int in argument to f

While the offsets printed for the literal strings are correct, the offsets for the variable s are not. On line 8, the error about s reuses the position of the literal "hello". On line 9, the error about s seems to use the position of the opening parenthesis on the call.
In a real program I noticed this as:
./buildid.go:42:20: cannot use f (type *os.File) as type string in argument to readBinary
./buildid.go:42:20: cannot use name (type string) as type *os.File in argument to readBinary

The arguments - both variables of different types - had been swapped and yet the position reported was the same for both. In this case the errors reported the initial parenthesis twice instead of the beginning of each bad argument.
/cc @griesemer @mdempsky

@mdempsky Can you look into this and see if there's an easy fix?

This issue is because we reuse the same ONAME Node to represent both the declaration of the name as well as uses, so we lose position information for their use sites.
We do have the position information in the package syntax AST representation, but we lose it once we convert to the Node AST representation.
There are a handful of special cases (chiefly composite literals and expressions used as statements) where we insert OPAREN nodes just for the purpose of preserving position information when we want to be able to emit errors for identifier use. We could potentially expand that to more cases (e.g., function call arguments).
At the extreme end, I experimented previously with always adding OPAREN nodes, which should address the entire class of problem: https://go-review.googlesource.com/c/go/+/38735
However, it had a significant performance impact on some packages, so I abandoned pursuing that solution.

@mdempsky Thanks for checking. No matter the solution, it does appear this is too late for 1.10. I'm going to bump it and mark as "early in cycle".

Nor urgent. Bumping down the road.

The error messages are now (Go 1.18) coming from types2 and the positions are correct. Closing.


Refactor and unit-test FreeRTOS_IP.c

Description

Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@htibosch, this PR is a part of two PRs adding separate unit-tests.
The breaking build issues will be addressed in the next PR.


Fix TypeError When Using @Paginate() with @MessagePattern() (@nestjs/microservices)

Problem
Currently, when the @Paginate() decorator is used alongside the @MessagePattern() decorator within a NestJS microservice, an error is thrown. This occurs because ExecutionContextHost.switchToHttp().getRequest() does not contain a query key in 'rpc' mode, leading to undefined being returned and causing the following TypeError:
TypeError: Cannot read properties of undefined (reading 'searchBy')

This error specifically arises due to the incompatibility of the @Paginate() decorator expecting HTTP request objects in an environment where such objects are not available.

I'm unfamiliar with RPC, could you explain why request instead of request.query is an appropriate fix?

I'm unfamiliar with RPC, could you explain why request instead of request.query is an appropriate fix?

While using @MessagePattern - request variable contains query parameters in itself and nothing more. Im also unfamiliar with RPC, I did some "console.logging" and found that out.
I'm not really interested in contributing or finding other, better solutions. This fix works perfectly in my project, and I just wanted to highlight the issue for maintainers and fellow gamers

@ppetzold could you have a look?

@ppetzold ping :)

:tada: This PR is included in version 9.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Please include a copy of the license in the repository root

The readme states that the license is MIT, which I was happy to see.
Please include a copy of the license in the repository root.

Thanks you for pointing this out, just added!