In addition to having multiple interfaces, each interface can have multiple ipv6 addresses and node-matter is picking link local address. But for some reason it is not reachable from Android phone in my network. IMHO, the MatterDevice should make it possible to optionally pass in the interface name(s) and perhaps even IP addresses on command line.  I assume that most physical Matter devices will have one network interface (or perhaps two - wired and wireless).

Unfortunately, I am not allowed to contribute code.

Unfortunately, I am not allowed to contribute code.

???
It is an open source project. Anyone can contrinute code personally in his free time. But sure, up to you

So, I had a chat (started for fun, but hey why not) with ChatGPT about network interfaces :-)
On one hand we could try to folter out to check if the network interfaces support broadcasts and multicast:>

If you want to include network interfaces that support both multicast and unicast traffic, you can modify this filter condition to check for both the IFF_MULTICAST and IFF_BROADCAST flags. The IFF_BROADCAST flag indicates whether the interface supports broadcast traffic, which includes unicast traffic.

.filter(iface => (iface.flags & (0x10000 | 0x2)) > 0)

For the link.local adresses I'm in the end not taht sure and need to read further. ChatGPT says:

If a network interface has multiple IPv6 addresses, you may want to choose the one that has the longest prefix length or the highest address scope.

For example, if the interface has both a link-local address and a global address, you can choose the global address because it has a longer prefix length (typically 64 bits) and a wider address scope (typically global).

Maybe this woukld be an approach ... need to investigate further but maybe it is a direction ....

ChatGPT - That's scary :-) Of course the scarier prospect is that it's just spouting nonsense and people will cut-and-paste its advice into their code :-)

Honestly ... much less nonsense that I was expecting ... in most cases you get a 80% "good start answer" and can iterate. With the background of basically "all GitHub public repos" in it it should have enough knowldge to have seen solutions to many things already because most stuff was already solved by a dev. And no I would not and never blindly copy code from it ... nbut for topics where you need to start with and would "google around" it gives you a  better startpoint to google ;-)

If a network interface has multiple IPv6 addresses, you may want to choose the one that has the longest prefix length or the highest address scope

This is the right answer.
For a simple test, I just hardcoded my ipv6 address into node-matter and Commissioning with Google Home App worked and devices showed up in my "Home".  But it immediately went offline. This is a repeatable behaviour so we should be able to debug it.
When I tried the same hardcoded ipv6 address hack with Android HA Companion App, the commissioning went much further but somehow the HA app just got stuck (waiting for some response or such).

I will experiment around with it tomorrow and potrovide an experimental PR. Idea wopuld be to sort the adresses and start with the "most global one" found ...
For Google home "went offline after commissioning": Do you have just the App or also a Google/Nest Hub? If not then this behaviour is to be expected, see our Readme! Google, Apple and ALexa all need a "hub" to operate the devices. Pairing works via app on Google and Apple, but after that only the hubs are communicating. For Alex even the commissioning process is done by their Hubs (aka Echo devices)

Aha - I don't have a hub - that explains it.

exactly.No idea how it work with HA, but I assume that HA server would be the "hub" then afterwards ... ?!

That is the idea - matter-server add-on is supposed to be the hub

Attached are captured logs from node-matter and android phone (adb logcat | grep matter) when trying to Commission with HA Android Companion app.  It seems like things progress up-to a certain point and then stall.
matterandroodadblog.txt
nodematter11.txt
The HA add-on did not produce any logs.

For comparison, attached are node-matter and adb logs with Commissioning actually does complete.
matterandroodadblog2.txt
nodematter12.txt

In fact according to the ligs in my eyes nothing is "stalled" ... it just has been commissioned correctly...
see also

Commissioning completed on fabric #18156227419154863424 as node #00000000FB1AA4D5.

Also the adb log shows

02-15 18:03:25.479 25634 25634 I MatterCommissioner: Commissioning completed successfully. [CONTEXT service_id=336 ]

So the initial step is done.
For Apple/Google this is konf og the part the app does. AFter that you get a new connection to the device coming from "the hub" to initiate the operational connection that then subscrie to values and such
So here the question would go to HA about what is supposed to come next

In fact according to the ligs in my eyes nothing is "stalled" ... it just has been commissioned correctly...

The lines you are seeing is in successful commissioning with Google HA app. The logs for commissioning with HA Companion app (one reply above that) doesn't show the 'completed' lines.

This is the right answer.

I'm not sure after investigating. especially for MDNS traffic which is supposed to be "local discovery" it makes more sense to use local interfaces over global ones

The lines you are seeing is in successful commissioning with Google HA app. The logs for commissioning with HA Companion app (one reply above that) don't have the 'completed' lines.

then please show the logs when pairing with Companion app?? :-)

then please show the logs when pairing with Companion app?? :-)

They are already posted here
https://github.com/mfucci/node-matter/issues/11#issuecomment-1432194520

Good news (at least for me). It seems like my router was somehow not enabled for IPv6 routing on the LAN. After enabling IPV6 routing on my local LAN, the node-matter code now works without any modifications (for hardcoding IP) - the Google Home App can now consistently find and commission.  The HA app now consistently finds the device and starts commissioning but fails to complete it (as seen in logs I posted earlier https://github.com/mfucci/node-matter/issues/11#issuecomment-1432194520).
Attached is the screenshot of my working IPV6 router settings (I am using Unify USG router). This shows the LAN ipv6 properties.

Ok, then the reason is that we do not yet respon correctly to read requests for unknown attributes.

2023-02-15 17:56:40.570 DEBUG InteractionProtocol Received read request from udp://fd04:8e92:e99f:1:cb2b:b7a6:ccb2:1613:39893 on session secure/23602: MA-rootdevice(0x0)/Basic Information(0x28)/unknown(0x12), isFabricFiltered=true

I already solved this locally and PR will come soon

Yes!!!! With this change I am able to commission the node-matter device and control it with HA.  We can close the issue now.

Can you please close (for completeness) post a node-mater log from such a pairing process? Then I close

For future reference, attached is log from node-matter and corresponding logs from HA Matter server of a successful commissioning and turning the switch on/off from HA a couple of times
ha-matter-server.log
nodematter-success-home-assistant.txt
Hopefully closing this issue for good now.

sure

With latest release of Home Assistant and Matter Add-on, I can no longer commission with node-matter. However, this is not an issue with node-matter. It is an issue with HA because it is now refusing to commit devices with test vendor id (0xfff1). I am still looking for a workaround similar to how you have to add test vendor/product Id to the backend.

With the infos from above and the "HA companion App" which uses Google in the background please check the readme about the instructions on how to use the Google Developer Console to whitelist this vendor/product id ... I would expect that this helps then?!

Already done that but it doesn't help.  Jatin
Sent from my mobile device

From: Ingo Fischer @.>
Sent: Wednesday, March 8, 2023 2:17:03 AM
To: mfucci/node-matter @.>
Cc: Jatin Desai @.>; State change @.>
Subject: Re: [mfucci/node-matter] Unable to complete commission process with Home Assistant (Issue #11)
With the infos from above and the "HA companion App" which uses Google in the background please check the readme about the instructions on how to use the Google Developer Console to whitelist this vendor/product id ... I would expect that this helps then?!
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmfucci%2Fnode-matter%2Fissues%2F11%23issuecomment-1459648959&data=05|01||0f97b0aef3b841a322c608db1fa51e47|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638138566257385698|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=UKPCSJs14T9UCNpjHiZkfJWjiWsTugiqXjOf2fS8P68%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADBZQWF6ZZCWER6VSUMLV7TW3AW67ANCNFSM53TPMB6A&data=05|01||0f97b0aef3b841a322c608db1fa51e47|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638138566257385698|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=LlTW6xhMwMpVVor7UnhYOod9DeQV32PgCAFQtw7%2FfNY%3D&reserved=0.
You are receiving this because you modified the open/close state.Message ID: @.***>

DId you opened an issue on Homeassistent to get details?

Can you please post logs from both parties (node-matter and also HA).
Are you sure that only HA was updated or did you also updated node-matter? because we now generate correct certificates and not use the "full testing default chain". But chiptool and all othersd are ok with it, so would be interesting to see the logs

No logs from node-matter - it doesn't even get a connection request.  Will post HA logs in a day but I didn't see any errors or logs. I will likely have to get phone logs.
Jatin
Sent from my mobile device

From: Ingo Fischer @.>
Sent: Wednesday, March 8, 2023 6:56:35 AM
To: mfucci/node-matter @.>
Cc: Jatin Desai @.>; State change @.>
Subject: Re: [mfucci/node-matter] Unable to complete commission process with Home Assistant (Issue #11)
Can you please post logs from both parties (node-matter and also HA).
Are you sure that only HA was updated or did you also updated node-matter? because we now generate correct certificates and not use the "full testing default chain". But chiptool and all othersd are ok with it, so would be interesting to see the logs
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmfucci%2Fnode-matter%2Fissues%2F11%23issuecomment-1460047087&data=05|01||1917df74a1fd4744ff6d08db1fcc2b99|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638138733981354700|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=n5z%2FfS2Y%2FlegbwfM3RzX1hb4U4okg3WeIHBPoW7O6gc%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADBZQWBAGAF3GRF22PANSETW3BXXHANCNFSM53TPMB6A&data=05|01||1917df74a1fd4744ff6d08db1fcc2b99|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638138733981510932|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=1%2B9nK7MDYvBIoeaVA1iXAGBFSTt0wyWw5sVCcxGhl80%3D&reserved=0.
You are receiving this because you modified the open/close state.Message ID: @.***>

But sorry when e have not a singel connection request then it CAN NOT be certificates or such ... then it is more network or UDP data flow

Not sure what happened, but after another upgrade of HA, it started working again... Sorry for the noise.


HADOOP-18653. LogLevel servlet to determine log impl before using setLevel

LogLevel GET API is used to set log level for a given class name dynamically. While we have cleaned up the commons-logging references, it would be great to determine whether slf4j log4j adapter is in the classpath before allowing client to set the log level.
Proposed changes:

Use slf4j logger factory to get the log reference for the given class name
Use generic utility to identify if the slf4j log4j adapter is in the classpath before using log4j API to update the log level
If the log4j adapter is not in the classpath, report error in the output

@steveloughran This PR is a follow-up task from #5315 (comment here)
Could you please review this PR?

@Apache9 @jojochuang could you please also take a look?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 25s

trunk passed

+1 :green_heart:
compile
23m  6s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
20m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 49s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
22m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
23m 14s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
23m 14s

the patch passed

+1 :green_heart:
compile
21m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 42s

the patch passed

+1 :green_heart:
javadoc
1m  6s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 42s

the patch passed

+1 :green_heart:
shadedclient
22m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 24s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

210m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5456

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0d56583e869a 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b4714dcf9ebe156914b1bf1eac1c4355accca309

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/1/testReport/

Max. process+thread count
2587 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 43s

trunk passed

+1 :green_heart:
compile
23m 11s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
20m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 51s

trunk passed

+1 :green_heart:
shadedclient
22m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
22m 34s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
22m 34s

the patch passed

+1 :green_heart:
compile
20m 36s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
20m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 43s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 42s

the patch passed

+1 :green_heart:
shadedclient
22m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 19s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

207m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5456

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux dd115a00a37e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c74b7a059a528369ba49ad279880a523d84d75cb

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/3/testReport/

Max. process+thread count
1520 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 32s

trunk passed

+1 :green_heart:
compile
23m 17s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
20m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 48s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 48s

trunk passed

+1 :green_heart:
shadedclient
22m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
22m 34s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
22m 34s

the patch passed

+1 :green_heart:
compile
20m 38s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
20m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 43s

the patch passed

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
22m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 27s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  3s

The patch does not generate ASF License warnings.

208m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5456

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux aa35c8c218a4 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cfd3e93c6255f04131ffe135134537709d9a144b

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/4/testReport/

Max. process+thread count
1500 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5456/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Prioritize required inputs for analyses

For the analysis tools, the inputs show up in apparently random order.
It would be ideal if we could put the required inputs at the top. And potentially make them more obvious than just the asterisk.

This is fixed now. Required fields appear before optional ones. Also changed to red asterisks on required fields to make it stand out more.


Add possibility of sending message with tag

Add the function sendMessageWithTag(recipient, payload, tag, cb) which allows sending messages with the specified tag.
Example of usage :
bot.sendMessageWithTag(payload.sender.id, { "text": "message_test"}, "NON_PROMOTIONAL_SUBSCRIPTION", (error, body) => {
    // ...
});

Please fix tests @baudev

What about Node4? I have not setup these pipelines so I'm not sure I can make changes to those.
Maybe @remixz can.

The mentioned errors in Node4 doesn't seem to be link

The function could be used as following finally :
bot.sendMessage(payload.sender.id, {"text": "message_test"},  (error, body) => {
    // ...
}, 'MESSAGE_TAG', 'NON_PROMOTIONAL_SUBSCRIPTION');

This issue's comment https://github.com/istanbuljs/nyc/issues/865#issuecomment-398435383 explains that node 4.x is no more supported with the latest versions of nyc. This is confirmed by the following commit: https://github.com/istanbuljs/nyc/commit/19b7d2130556b939bdd2fb69c2a35d09fe83f61e
We have two options:

Drops support for node 4.x and then this test in Travis
Specify the version of nyc. As nyc is a dependency of tap we should specify the version of the latter.

I prefer the last solution: easier and more secure. Then it requires that @remixz remove the node 4 test in his Travis account.
What do you think about @eXeDK ?

I tried everything. I think that specifying the tap version doesn't work due to the Travis cache. Anyway.
@remixz should remove the Node4 test or maybe @eXeDK have the rights of editing/remove/add tests ?

I'll merge this and try and fix the tests afterwards @baudev


SearchOptionsProcessor (Value cannot be null. (Parameter 'itemName'))

Hi Abdul Rahman,
I know this problem is not related to your component but i wanted to ask some help from you.
I am using mongo db as a database, everything is going fine but i am not able to run search functionality successfully.
i am having Value cannot be null. (Parameter 'itemName') error. after googling a bit i came across this link. I provided the name as mentioned in the blog and the error is gone but i am not getting the search functionality properly.
can you please help me regarding problem.

Sorry Abdul Rahman,
I solved it i was just missing a simple thing. i downloaded your code from git hub and copied the SearchOptionsProcessor to my project and modified line number 90 to var obj = Expression.Parameter(typeof(TEntity), "search"); //ExpressionHelper.Parameter(); and it worked. if it is correct can you please update your code and also the nuget package so that i can continue using the component' s class rather than mine.

looks like this is a issue with mongo db c# driver. did you report this to them? whats their response for this?


yara.py object has no attribute

Traceback (most recent call last):
File "ghidra_scripts/yara.py", line 53, in
add_bookmark_comment(vaddr, current_rule)
File "ghidra_scripts/yara.py", line 30, in add_bookmark_comment
cu.setComment(CodeUnit.EOL_COMMENT, text)
AttributeError: 'NoneType' object has no attribute 'setComment'

N/A wrong submission, apologies


[enhancement] instead of downsample factors below 1, use factors of 2 (speed improvements, less downsampling artifacts)

wrote wrapper for dask arrays to handle large data downsampling better/faster
this creates a list of dask arrays that can be called to store in h5 files
https://github.com/samwelborn/tomopyui/commit/f2ad6670ce144b36cb0de34aadb31c858ceec618


keep originalUrl if redirected

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   82.63%   82.63%
=======================================
  Files          18       18
  Lines        1094     1094
  Branches      186      186
=======================================
  Hits          904      904
  Misses        190      190

Impacted Files
Coverage Δ

src/controller/main.js
80.55% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0edd1b...80bb472. Read the comment docs.


Add exit code to compile-scss script on failure

Description
Add exit code to compile-scss script on failure. Previously, if this script had an error, it wouldn't propagate, which would cause false positives in our CI workflows.
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[x] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Do you want these to be the same exit code, or different to distinguish between them?

I don't think it matters much for this case, as long as it isn't 0, the workflows will fail. Maybe it could be useful for some case, but the point of this PR is to make the command propagate errors. If we find a use case in the future, this is an easy thing to change


Two minor complaints

Chromium sends UDP broadcasts every two minutes even if the media router extension is disabled.
Solution: open chrome.dll in a hex editor, replace the only instance of <IP_ADDRESS> with <IP_ADDRESS> and save.
Chromium always launches the crash reporter processes even if Breakpad is disabled.
Solution: open chrome.exe in a hex editor, replace the only instance of crashpad-handler with xyxyxyxy-handler and save.
I'm too lazy to check if this also occurs in the official Chromium.
Thanks to anon for finding these

I'm guessing these are hacks for the latest Windows binary?
I'm not sure if the crashpad-handler process is a bug or not from our side, but the UDP broadcasting deserves a look.

That's correct, they are tested on 66.0.3359.139-1 for Windows.
As for the UDP broadcasts, they persist even after disabling "Load Media Router Component Extension" and "Media Remoting during Cast Tab Mirroring" in chrome:flags and setting EnableMediaRouter to false via group policy. A comment on issue 665572 at bugs.chromium.org suggests just disabling Media Router should be enough to stop them, but it's from two years ago and I haven't checked this on an unmodified Chromium build.

The UDP broadcast of the media router is not limited to Windows and can be effectively disabled by creating a managed policy setting for EnableMediaRouter, at least in Linux.
The state of the media router is set in chrome/browser/media/router/media_router_feature.cc:
bool MediaRouterEnabled(content::BrowserContext* context) {
#if defined(OS_ANDROID) || BUILDFLAG(ENABLE_EXTENSIONS)
  const PrefService::Preference* pref = GetMediaRouterPref(context);
  // Only use the pref value if it set from a mandatory policy.
  if (pref->IsManaged() && !pref->IsDefaultValue()) {
    bool allowed = false;
    CHECK(pref->GetValue()->GetAsBoolean(&allowed));
    return allowed;
  }

  // The component extension cannot be loaded in guest sessions.
  // TODO(crbug.com/756243): Figure out why.
  return !Profile::FromBrowserContext(context)->IsGuestSession();
#else  // !(defined(OS_ANDROID) || BUILDFLAG(ENABLE_EXTENSIONS))
  return false;
#endif  // defined(OS_ANDROID) || BUILDFLAG(ENABLE_EXTENSIONS)
}

Under Windows I tried both this...
[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Chromium] "EnableMediaRouter"=dword:00000000
...and setting EnableMediaRouter to 0 by enabling the "Enable policy management page" experiment and going to chrome:policy-tool.
In both cases the change is acknowledged by about:policy, but the broadcasts continue anyway.

@2x9Mon Did you restart Chromium after setting the policy? I cannot reproduce it with Windows 10 and Ungoogled Chromium 67.0.3396.87. Does the chrome:policy page show a Mandatory level for the policy? Otherwise it won't have an effect.
This is the policy I used, same as yours:
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Chromium]
"EnableMediaRouter"=dword:00000000

@2x9Mon I used the binaries compiled by Wyse- at https://github.com/Eloston/ungoogled-chromium/issues/414#issuecomment-402553207.

@xsmile
Thanks for the link! I upgraded to that version and the broadcasts are now gone under the same profile and setup, without having to patch anything.
I took a little time to find out which of the countermeasures I'd tried actually does the trick. It seems the UDP traffic is gone if and only if EnableMediaRouter is set to 0 via group policy. The "official" solution of disabling "Load Media Router Component Extension" and "Media Remoting during Cast Tab Mirroring" via chrome:flags does nothing, and neither does using their corresponding command-line switches instead.
I guess this issue is only about the crash reporter processes now :)

I took a little time to find out which of the countermeasures I'd tried actually does the trick. It seems the UDP traffic is gone if and only if EnableMediaRouter is set to 0 via group policy.

Hmm, do the UDP broadcasts occur in the Linux and macOS builds as well? If so, I wonder what it is necessary to disable them. We could use that info to make a patch that makes it easier to disable these UDP broadcasts, if someone is inclined to do so.

I located 2 chromium files that seem to be related to broadcasting <IP_ADDRESS>.
dial_service.cc
permissions_data_unittest.cc
Not really sure what could be done with these but thought this information could be helpful.

We need to add a patch for that main stream to fix it for all platforms

Given that there is an existing policy setting to disable media router, I'd rather have a CLI flag for this toggle than patch out this specific code within media router.

@intika Would you be able to submit a PR for this to the User Resources page on the Wiki? Thanks.

Done https://github.com/ungoogled-software/ungoogled-chromium-wiki/pull/3


🌐 [i18n-KO] Translated package_reference/community.md to Korean

What does this PR do?
Translated the package_reference/community.md file of the documentation to Korean.
Thank you in advance for your review.
Part of https://github.com/huggingface/huggingface_hub/issues/1626
Before reviewing

[x] Check for missing / redundant translations (번역 누락/중복 검사)
[x] Grammar Check (맞춤법 검사)
[x] Review or Add new terms to glossary (용어 확인 및 추가)
[x] Check Inline TOC (e.g. [[lowercased-header]])
[ ] Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review? (Final)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

LGTM!

LGTM

@Wauplin I've reviewed this PR, and it looks good to me.
Would you mind merging this PR, please?


rulesDirectory is ignored

The options object in the tslint has the configuration property, AND an optional property named rulesDirectory. tslint will NOT read the rulesDirectory from the configuration object.
You can see that in the tslint-cli they read it from the configuration and send it to the Linter...
It's a bit misleading because you would think that tslint will read the rulesDirectory from the configuration, but it does not, only the tslint-cli does...
All you have to do, is check if this property exist on the configuration object, and if it does, add it to the options object.

Created a PR


Add Style/StringConcatenation support for << with string literals?

Style/StringConcatenation cop detects string concatenation using + like so:
'hello ' + name
# corrects to interpolation:
"hello #{name}"

It seems this cop could also detect concatenation using << in a similar way if the left-hand operand is a literal:
'hello ' << name
# would also correct to:
"hello #{name}"

I think it should be closed due to https://github.com/rubocop/rubocop/pull/11101#issuecomment-1293218980


Lewd library filter doesn't light the filters button

Steps to reproduce
Check the "Lewd" option in library filters (either state)
Expected behavior
Filters button light up to indicate there are filtered out entries
Actual behavior
Filters button remains the same color as if there were no filters active
Crash logs
No response
TachiyomiSY version
r542
Android version
13
Device
Generic Tablet
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[ ] I have updated the app to version 1.10.5.
[ ] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

What people? And notice what, that you have a filter active that might as well be unread?

From: Turhvjbufv 'notifications at github.com' @.>
Sent: Wednesday, March 13, 2024 3:16:26 AM
To: @. @.***>
Subject: Re: [jobobby04/TachiyomiSY] Lewd library filter doesn't light the filters button (Issue #1109)
It so that people won't notice it if they look at your library I'm guessing
—
Reply to this email directly, view it on GitHubhttps://github.com/jobobby04/TachiyomiSY/issues/1109#issuecomment-1993645649, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABWGTI7TF72IG2YJNY4QRWLYX7VLJAVCNFSM6AAAAABETEA75OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTGY2DKNRUHE.
You are receiving this because you authored the thread.Message ID: @.***>
This email was sent to @.*** from @.***
Click herehttps://app.addy.io/deactivate/4fdf154a-7812-4c90-934f-fb03c8989873?signature=b9997111da178fee9b75e73e6203e5bdd9bfa66b3d491d9e4791f11ef2591502 to deactivate this alias

WDYM good luck? It's your device, just don't show them¯\_(ツ)_/¯

From: Turhvjbufv 'notifications at github.com' @.>
Sent: Wednesday, March 13, 2024 3:58:42 AM
To: @. @.***>
Subject: Re: [jobobby04/TachiyomiSY] Lewd library filter doesn't light the filters button (Issue #1109)
Yeah but if they have eyes and see that the unread filter isn't on/any other filter then gl
—
Reply to this email directly, view it on GitHubhttps://github.com/jobobby04/TachiyomiSY/issues/1109#issuecomment-1993690275, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABWGTI2ZVMXJ737IAUGE5W3YX72J5AVCNFSM6AAAAABETEA75OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJTGY4TAMRXGU.
You are receiving this because you authored the thread.Message ID: @.***>
This email was sent to @.*** from @.***
Click herehttps://app.addy.io/deactivate/4fdf154a-7812-4c90-934f-fb03c8989873?signature=b9997111da178fee9b75e73e6203e5bdd9bfa66b3d491d9e4791f11ef2591502 to deactivate this alias

Should be fixed in the next build

Caught in the cherry-picking crossfire?


Update custom.train.txt

Hi @aparnavalli ,
Thanks for your PR. Are you going to contribute your dataset?

Yes Sir. In fact i have over 1 lakh reviews collected..If they will be of
any use, would be happy to share)
Thank you
Aparna
On Wed, Jun 22, 2022 at 3:08 PM Heng Yang @.***> wrote:

Hi @aparnavalli https://github.com/aparnavalli ,
Thanks for your PR. Are you going to contribute your dataset?
—
Reply to this email directly, view it on GitHub
https://github.com/yangheng95/ABSADatasets/pull/26#issuecomment-1162877965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZC2EWCPZYFHAQHEGQ3K7LDVQLNKBANCNFSM5ZPQ65PA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add "protest" button to battleforthenet.com flow, ideally that passes through zipcode

This screen would ideally have a "protest" button in after-action-footer.tsx, like the widget does.

It should link to the same place as the button in the widget, and pass through the zipcode that the user has already entered in the same way.
It would look the same and use the "pin.svg" icon.

sorry... long day. this should be in https://github.com/fightforthefuture/battleforthenet/issues moving and closing.


Custom backend URL support

Describe the feature or improvement you're requesting
Currently, the URL for an OpenAI completion (openai.Completion.create) is predefined to support 'azure' and 'openai' backends.
Would it be possible to have a custom api_type (openai.api_type = "custom") where the URL would then be possible to define while creating the OpenAI completion engine?
Additional context
The feature would probably be implemented at https://github.com/openai/openai-python/blob/v0.27.8/openai/api_resources/abstract/engine_api_resource.py#L22 (method `class_url´)

Additionally, there should be a possibility to set extra headers, and omit the standard authorization header, if not possible already (I understand this may be doable already)

just use
openai.api_base = "ALT_URL"

Then, when you do ChatCompletion (for example) it queries ALT_URL/chat/completions, and passes the api key and everything.

Unfortunately, that does not work since the backend URL does not end with '/chat/completions', but rather uses different URI. Also the authorization is handled through separate header, and the openai - API type Authorization header (sent by default) results in an authentication failure.

@mkaalto Ok, that makes some sense. Still if a service is providing almost OpenAI compatible API, they might as well make it fully compatible. Almost compatible is still not compatible :)

I'm teaching a class, and I've writtena  reverse proxy.  I would like students to be forced to log in with a custom header to the proxy.  Other than that extra header, the proxy is fully compatible.
So there's a use case of why we might need to customize headers in the client call.

This is fixed in v1 which was just released!
You can specify a custom base URL by passing the base_url argument to the constructor, e.g. OpenAI(base_url='...').
If you need to use custom paths then you can write your own event hook to do so, for example:
import httpx
from openai import OpenAI

def update_base_url(request: httpx.Request) -> None:
    # rewrite the path segment to what the proxy expects
    if request.url.path == "/v1/chat/completions":
        request.url = request.url.copy_with(path="/my/custom/path")

client = OpenAI(
    base_url="https://www.my.base.url",
    http_client=httpx.Client(
        event_hooks={
            "request": [update_base_url],
        }
    ),
)
completion = client.chat.completions.create(
    model="gpt-4",
    messages=[
        {
            "role": "user",
            "content": "Say hi!",
        }
    ],
)

@nowucca your request is also supported in v1, you can pass in custom default headers to the client constructor, e.g. OpenAI(default_headers={'X-Foo': 'true'}) or on a per-method basis with the extra_headers argument.
completion = client.chat.completions.create(
    model="gpt-4",
    messages=[
        {
            "role": "user",
            "content": "Say hi!",
        }
    ],
    extra_headers={'X-Foo': 'true'},
)

Tested, this solves the problem. Thank you very much!

This is fixed in v1 which was just released!
You can specify a custom base URL by passing the base_url argument to the constructor, e.g. OpenAI(base_url='...').
If you need to use custom paths then you can write your own event hook to do so, for example:
import httpx
from openai import OpenAI

def update_base_url(request: httpx.Request) -> None:
    # rewrite the path segment to what the proxy expects
    if request.url.path == "/v1/chat/completions":
        request.url = request.url.copy_with(path="/my/custom/path")

client = OpenAI(
    base_url="https://www.my.base.url",
    http_client=httpx.Client(
        event_hooks={
            "request": [update_base_url],
        }
    ),
)
completion = client.chat.completions.create(
    model="gpt-4",
    messages=[
        {
            "role": "user",
            "content": "Say hi!",
        }
    ],
)

@nowucca your request is also supported in v1, you can pass in custom default headers to the client constructor, e.g. OpenAI(default_headers={'X-Foo': 'true'}) or on a per-method basis with the extra_headers argument.
completion = client.chat.completions.create(
    model="gpt-4",
    messages=[
        {
            "role": "user",
            "content": "Say hi!",
        }
    ],
    extra_headers={'X-Foo': 'true'},
)

For people happened to use httpx.AsyncClient, the code should be like
async def update_base_url(request: httpx.Request) -> httpx.Request:
    # rewrite the path segment to what the proxy expects
    if request.url.path == "/v1/chat/completions":
        request.url = request.url.copy_with(path="/custom/path/completion")
    return request

Then we can use it like this
httpx.AsyncClient(event_hooks={
            "request": [update_base_url],
        })


[Style] Make the NavBar Hover Effect Dyanamic

What's the style idea?
We need to improve
Currently the components in the navbar becomes pink color when hovered  , no matter what the theme is in ....ie in both dark and light mode the hover effect is in same color
I expect it to be different colors according to the theme change
Screeenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a KWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100  Kindly assign this issue to me

I see that it is not the same, it's pink in one theme and purple in another, lmk further @isid555

But Still It does'nt suit well to the background , the pink in blue background and purple(similar pink shade) in pink background ....That's why I have raised It @Rakesh9100
It can be more dynamic and suitable to the backgrounds I guess

Okay, proceed @isid555


multiline paste on command line/terminal should show a warning.

As the title.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

I'm sorry for that I didn't give sufficient information; The issue I'd like to suggest about is that multiline paste on the command line/terminal on vscode should show a warning because it's dangerous sometimes i.e. when you have copied a shell script file content without noticing it; At least a toggle to show a warning on multiline pasting wouldn't be a failure point I believe. thanks.


Bug: Cannot add contributors to contributor insights

Describe the bug
The /add-contributors page for workspace insights errors out.

Steps to reproduce

Go to any contributor insights
Add a contributor
See error modal

Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

I believe this is because the addContributorsToList function

only returns an error
POSTs to /lists/[id]/contrtibutors endpoint instead of the /workspaces/[id]/userLists endpoint since its for workspaces

https://github.com/open-sauced/app/blob/beta/pages/workspaces/[workspaceId]/contributor-insights/[listId]/add-contributors.tsx#L215

cc @brandonroberts - I thought this was fixed in: https://github.com/open-sauced/api/pull/565
but looks like the addListContributor fetch in the frontend is only sending an array of contributors:
https://github.com/open-sauced/app/blob/8d6f1d1dced63a2d6e9a76e0fde45f36b8a785ca/lib/hooks/useList.ts#L73-L85
where it should be an object of either id or login

@jpmcb Ahh ok, need to adjust this here and when adding a contributor to a list from their profile page


Module split to separate files

The only public API change is moving Event from system to input, since it seems to be completely input related.
If something is really out of place I'll put it somewhere else.
Closes #136

Woo, nice! If you don't mind, I'll have a look tomorrow, My brain is about to shut down. But it's possible someone else will read through and merge it :-).

Okay, this looks great! There's a couple of things I think need fixing before we merge this. I do this later today but if you just want to update this, I can just merge it. Or indeed, feel free to merge this yourself if you do end up fixing them :-).
I've a couple more ideas that can be added later but was wondering what you think:

the mouse mod in input.rs doesn't seem to make much sense to me now. Can we remove it?
Now that AStarPath and DijkstraPath are within the pathfinding namespace, I'm thinking of dropping the "Path" suffix since it's redundant.

I think removing the mouse mod in input is a great idea, I just didn't want to do any sweeping changes during the initial split (this preserved backwards compatibility, except for the system::Event -> input::Event change). I'm also all for removing the Path suffix.
There's one thing though: both of these things would depend on, in my opinion, on not reexporting the contents of these modules: as it is now, pathfinding is not even a pub mod. If you'd like to have the reexports, then having it the way it is makes sense.

I'm okay with dropping the re-exports.

Alright, I'll go ahead end do it. There is one workaround I ended up having to do: the TcodMap trait in the map mod: since pathfinding wants to use the native representation, and the member variable is not public (which is good). I think having it as a separate trait (and so having to explicitly include) is a good enough separation, but if you have any other ideas...

Also, there's that comment in pathfinding about the Drop implementation. It lets me move ffi::TCOD_path_t into the the actual structs, implement Drop, and the compilation does not fail. Is there some kind of behaviour I'm still unaware of, that makes that approach impossible?

Here are the changes both to the code and the examples. I left some reexports, because getting rid of them would've made the library pretty inconvenient to use (I can still get rid of them if you want).

Thanks! I like the AsNative trait.


Support Class?.member in the VM

As of b11670f89924c1961be8f93d00848c7fa9887f99, Class?.member is interpreted the same as Class.member. Currently, the VM treats it as (Class)?.member, which throws a NoSuchMethodError when accessing static methods.

This is fixed
Committed patchset #1 (id:1) manually as
223e5a6bb5877dd4c3c46cf1f097172c879e8424 (presubmit successful).

This is commit 223e5a6bb5877dd4c3c46cf1f097172c879e8424, confirmed that this was already merged to the dev channel:
mit-macbookpro:sdk mit$ git log a5c19bdb713bd3bd18bb47fe13fc2d9f220078e9

commit a5c19bdb713bd3bd18bb47fe13fc2d9f220078e9
Merge: bfc0565 28611c9
Author: William Hesse<EMAIL_ADDRESS>Date:   Tue Aug 11 11:21:05 2015 +0200

    Version 1.12.0-dev.5.2

...
    Cherry-pick 223e5a6bb5877dd4c3c46cf1f097172c879e8424 to dev
...


Bump llvm version to 04da3dfecc199a7fdd262b06eeb399fc8ce0d1f6

This builds successfully but I am getting a segfault on the mm tests. I didn't bisect to determine if the issue was pre-existing. I'm ok not merging this until someone more familiar with the project verifies, but since it took a bit of digging to resolve the path issue, I'm putting it out there.

The segfault is due a change in the handling of memref function arguments in newer versions of MLIR. In previous versions, memref arguments were lowered to pointers to structures describing the memrefs (e.g., struct vec_f2d in Teckyl's tests/exec/lib/memref.h). The newer version lowers each memref argument to a set of function arguments that correspond to the fields of the structure describing the memref.
I have pushed a commit into for-stella/bumpllvm_20200227 fixing the issue. If this fixes the segfault in your setup, please squash that commit into yours and update the PR.
Thanks!

Commits squashed and tested. Merged as 5b245386e36848f89694b5cc1fb87aba17ade3d1.


Remove inverseStyle Prop

Allows for more control over component classes, requested here: https://github.com/dcos/dcos-ui/pull/56#discussion_r61338091
Depends on https://github.com/dcos/dcos-ui/pull/56

Reviewer: @kennyt

is this rebased? all the changes in the PR are from this PR?

It is now!


move verify-install from experiment

move  istioctl verify-install from experimental command.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: irisdingbj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liamawhite
If they are not already assigned, you can assign the PR to them by writing /assign @liamawhite in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irisdingbj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
f7c96a12d94420f49a29228bfe3b7d6664fbd2ac
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-integ-local-tests

@irisdingbj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
f7c96a12d94420f49a29228bfe3b7d6664fbd2ac
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think we should add integration tests to avoid regressions before graduating a command from experimental to stable.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
f7c96a12d94420f49a29228bfe3b7d6664fbd2ac
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
5bf288d8c4dec09ac74af8abb0d0f86efd663216
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
f7c96a12d94420f49a29228bfe3b7d6664fbd2ac
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
5bf288d8c4dec09ac74af8abb0d0f86efd663216
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
5bf288d8c4dec09ac74af8abb0d0f86efd663216
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-integ-k8s-tests

/test integ-pilot-k8s-presubmit-tests-master

test integ-security-k8s-presubmit-tests-master

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, irisdingbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, irisdingbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Issue/138 build ffprobe command

Allow a customized FFprobe report.
Tasks:

[x] Extend output with -show_packets
[x] Extend output with -show_frames
[x] Handle intermixed reports (-show_packets and -show_frames together produce a rather weird combined response)
[x] Allow running custom commands similar to FFmpeg (taking a list as input)
[x] Create an FFprobeBuilder

Fix #138

Added a builder to FFprobe.
Additionally implemented -show_packets and -show_frames.
There are some weird shenanigans if both -show_packets and -show_frames are set.
Rather than producing two distinct lists, they merge into one giant list.
The builder provides default values aligned with the original default command.
-show_packets and -show_frames can be relatively slow; therefore, they are disabled by default.

@bramp
I've updated this pr with the changes merged in #254.
This would also replace #203


Update http4s-ember-server to 0.21.22

Updates org.http4s:http4s-ember-server from 0.21.14 to 0.21.22.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s", artifactId = "http4s-ember-server" } ]

labels: library-update, semver-patch

Codecov Report

Merging #25 (eb04aba) into master (1e27808) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            1         1
=========================================
  Hits             1         1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ebb72...eb04aba. Read the comment docs.

Superseded by #32.


Add support for os_log on Apple platforms

Apple platforms (macOS, iOS, watchOS, tvOS) have a unified logging system called os_log. I implemented support for os_log and made it the default on Apple platforms. This is similar to how slf4j-android implements slf4j-api to write to the Android system log.
I kept the console output appender still available on Apple platforms because it might still be desirable to use it in, for example, a command line tool.
os_log has two key concepts – a subsystem and a category. A subsystem is intended to be constant for an entire project (i.e. the reverse DNS notation for the project) and the category is supposed to change based on the component. Neither are usually part of the log message string itself, but rather used for filtering the log messages. If you have a subsystem and a category, you can create a log object with os_log_create(2), but if you don't have either you can just use OS_LOG_DEFAULT
My implementation makes OS_LOG_DEFAULT the default for Apple platforms, but you can specify a subsystem with:
KotlinLoggingConfiguration.appender = OSLogSubsystemAppender("com.example.app")

If you are using the default log, the loggerName is logged as a part of the message, but if you are using a specific subsystem, the loggerName will instead be used as the category. Similar to the subsystem and the category os_log also makes the level a parameter of the message itself (and something you can filter on), instead of as a part of the message text.
I hide the log level and loggerName if you are using a OSLogSubsystemAppender, but this part of the diff is a bit rough, and I'd love your thoughts on which direction it should go. For the time being, it works for my needs :)
os_log also has the ability to disable log levels for performance, and my implementation supports that as well.
Thank you for writing this library, it is working great for me! Feel free to suggest changes, or to just make them yourself – the branch is yours 😊
One small note is that Kotlin multiplatform handles the artifact multiplexing automatically – I am able to just specify the single io.github.microutils:kotlin-logging dependency in my commonMain and It Just Works™

Thanks for the PR! I will look into it as soon as possible.

LGTM!
Do you want to also create a documentation for that (in the wiki?) once merged?

Yes, I can do that! I will also make sure that the README is updated in the commit before merge

Thanks for the PR!


Read trailing data from tar reader

Not reading all the data from the tar reader causes the layer digest mismatch which causes failures during unpack of certain images for lcow. This is the same issue as that of #3569.

/ok-to-test


feat: 🎸 add NftCollection entity + create procedure

Description
Add NftCollection entity and  assets.createNftCollection method to Assets namespace to create it
Breaking Changes
None
JIRA Link
✅ Closes: DA-876
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 23.0.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


support for "count with" blocks

In some situation, have a count with block ( https://github.com/google/blockly/wiki/Loops ) would be handy -- or allow our for-loop to modify the start and increment.
https://github.com/google/blockly/wiki/Loops

Won't fix for now


gitignore directories and files ignored despite settings

I'm not sure if something changed in recent versions, but now anything in my .gitignore file does not show up in the file browser column on the left. Changing the "Exclude Vcs Ignored Paths" setting in the Preferences menu doesn't have any effect. Is there another setting I'm missing or is this a bug?

I got bit by this today. I agree, I didn't even consider that TreeView was a package until I ran into this bug report. I had just assumed that the "Exclude VCS Ignored Paths" setting in Core Settings was busted.

@lee-dohm I'm running into this issue right now, despite having Hide Ignored Names and Hide VCS Ignored Files deselected in the Tree View package settings. Changing Exclude VCS Ignored Paths in the Core Settings doesn't make any difference, either.

@lee-dohm @mdfragala Same problem here (my .gitignore is just *.pyc and all the relevant settings are checked)

@krabbypattified What you're describing is being tracked in https://github.com/atom/atom/issues/14006, you may want to subscribe there for updates.


Enable Document model to be observable.

As of right now, it is not observable.  We should evaluate if calling this.rerender() as needed in consuming components is good enough (and not needless clutter), or if we want to change Document base class to extend from Ember.Object and call notifyPropertyChange as needed internally.

Closed by https://github.com/aptible/ember-json-schema/pull/8


Support for 'nonull': 'error'

This PR is similar to the one that's been sitting here for nearly two(!) years. It's a simple six line change that allows users to specify that the task should throw an error via grunt.fail.fatal() when a missing file is encountered. It is entirely backwards-compatible. You have three options:
{ 'nonull': false } // Don't warn about missing files
{ 'nonull': true } // Warn about missing files
{ 'nonull': 'error' } // Throw missing files

Test / documentation. Can I get a merge?

If anyone else wants this functionality, FYI - grunt-concat-verify.


Check exit status instead of contents of stderr

This changes the way an error is detected, inspecting the exit status for a non-zero exit code rather than inferring an error if there is any content in the stderr stream. This caused false positives when gpg output warnings to stderr.
Warning - this probably doesn't work on 1.8.7 due to changes in popen3 in 1.9.3 and later. Don't know if this is an issue for you, but thought I'd flag it.

Beautiful. Thanks.


fix: Don't enable lsp complete for starting buffer

LSP completion is enabled always in the startup buffer due to the Register() call during OptionsChanged(). Now, with this call removed, LSP completion source is added only via LspAttached autocommand.
Without this fix, when starting vim as vim abc.txt, we get error messages like:
Error: Language server for "text" file type supporting "completion" feature is not found

Thank you for noticing the problem. However your solution is not the correct one. It will cause priority to not be updated when options change (and priority is changed in options). The correct solution is to check if LSP server is either running or ready and only then register.
e9fbec9
This should solve the problem.
Secondly, if you want more fine grain control you can specify filetypes for this plugin to register, and it will ignore other filetypes.
var options = {
    lsp: { enable: true, priority: 10, maxCount: 5, filetypes: ['python', 'java', 'c', 'cpp'] }
}
autocmd VimEnter * g:VimCompleteOptionsSet(options)

Thank you for noticing the problem. However your solution will cause priority to not be updated when options change (and priority is changed in options). The correct solution is to check if LSP server is either running or ready and only then register. I will correct this in my next commit.
Secondly, if you want more fine grain control you can specify filetypes for this plugin to register, and it will ignore other filetypes. (this is not required after my next commit).
var options = {
    lsp: { enable: true, priority: 10, maxCount: 5, filetypes: ['python', 'java', 'c', 'cpp'] }
}
autocmd VimEnter * g:VimCompleteOptionsSet(options)

201f43d


[FLINK-19943][table-planner-blink]add parallelism config  of  elasticsearch dynamitic table sink

What is the purpose of the change
add parallelism config of elasticsearch dynamitic table sink
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
Elasticsearch6DynamicSinkTest.testParallelismConfig
Elasticsearch7DynamicSinkTest.testParallelismConfig
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
The serializers: (yes / no / don't know) no
The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
The S3 file system connector: (yes / no / don't know)no

Documentation

Does this pull request introduce a new feature? (yes / no) yes
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)  yes

The description about the PR should be what changes you do.

@flinkbot run azure

@flinkbot run azure

@wg1026688210 Thanks for your contribution,I left some comments.
The docs should also be updated,the path are /docs/dev/table/connectors/elasticsearch.md and /docs/dev/table/connectors/elasticsearch.zh.md

ok.I will add the config

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run travis

@JingsongLi @wuchong  please take a look

This PR is superseded by https://github.com/apache/flink/pull/18033
@fapaul Can you close this one?


:books: migration changes

/cc @BillWagner

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/index.md
:white_check_mark:Succeeded
View
Details

docs/csharp/csharp.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/additional-resources.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/breaking-changes-in-visual-studio-2013.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/getting-started-with-csharp.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/introduction-to-the-csharp-language-and-the-net-framework.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/whats-new.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0001.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0006.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0007.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0015.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0016.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0019.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0029.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0034.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0038.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0039.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0050.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0051.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0052.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0071.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0103.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0106.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0108.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0115.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0116.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0120.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0122.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0134.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0151.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0163.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0165.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0173.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0178.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0188.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0201.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0229.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0233.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0234.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0246.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0260.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0266.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0269.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0270.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0304.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0310.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0311.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0413.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0417.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0420.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

🎉

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/index.md
:white_check_mark:Succeeded
View
Details

docs/csharp/csharp.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/additional-resources.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/breaking-changes-in-visual-studio-2013.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/getting-started-with-csharp.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/index.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/introduction-to-the-csharp-language-and-the-net-framework.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/whats-new.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0001.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0006.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0007.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0015.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0016.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0019.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0029.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0034.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0038.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0039.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0050.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0051.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0052.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0071.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0103.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0106.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0108.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0115.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0116.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0120.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0122.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0134.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0151.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0163.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0165.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0173.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0178.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0188.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0201.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0229.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0233.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0234.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0246.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0260.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0266.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0269.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0270.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0304.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0310.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0311.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0413.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0417.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/index.md
:white_check_mark:Succeeded
View
Details

docs/csharp/concepts.md
:white_check_mark:Succeeded
View
Details

docs/csharp/csharp.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/additional-resources.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/breaking-changes-in-visual-studio-2013.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/getting-started-with-csharp.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/index.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/introduction-to-the-csharp-language-and-the-net-framework.md
:white_check_mark:Succeeded
View
Details

docs/csharp/getting-started/whats-new.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0001.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0006.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0007.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0015.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0016.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0019.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0029.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0034.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0038.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0039.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0050.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0051.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0052.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0071.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0103.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0106.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0108.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0115.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0116.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0120.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0122.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0134.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0151.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0163.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0165.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0173.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0178.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0188.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0201.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0229.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0233.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0234.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0246.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0260.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0266.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0269.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0270.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0304.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0310.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0311.md
:white_check_mark:Succeeded
View
Details

docs/csharp/language-reference/compiler-messages/cs0413.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:boom: Ready to :shipit:


azure-devops commands corrupt the powershell console and prevent further output

azure-devops
Description of issue
Running the following command in a powershell window corrupts the console so the output generated is black on black, including the prompt when the command finishes.
$Result = (az pipelines show --organization $ADOUri --project $ADOProjectName --name $PipelineName)

You can work around this issue by creating the following function then calling it after the command is executed:
$PSBackgroundColor = $Host.UI.RawUI.BackgroundColor
$PSForegroundColor = $Host.UI.RawUI.ForegroundColor

function Reset-Console {
	$Host.UI.RawUI.BackgroundColor = $PSBackgroundColor
	$Host.UI.RawUI.ForegroundColor = $PSForegroundColor
}

The same issue occurs for multiple other commands, and it only seems to happen for commands that output the following message:
This command is in preview. It may be changed/removed in a future release.

The x is me entering a character into the now invisible prompt.
Highlighting the text and copying it into a text editor shows the text, so it is rendering as black on black.

azure-devops


note_polyphony and note_selfmask doesn't seem to work

When setting note_polyphony to 1, Sfizz still doesn't limit polyphony for repeated instances of the same note.
note_selfmask=on should allow multiple repeated notes to play if the new notes are lower in velocity than the previous notes, but should cut off previous notes if the new ones are higher in velocity.
note_selfmask=off should cut off ALL previous notes on repeated note hits (if note_polyphony=1).
Sfizz plays repeated notes with full polyphony regardless of these settings.

Relevant tests are here and below: https://github.com/sfztools/sfizz/blob/acd866fd3d247d2fc659593cac96e88e801c29e2/tests/PolyphonyT.cpp#L218
I'll check this behavior to see if there are things that are not covered.

On this one I dont

When setting note_polyphony to 1, Sfizz still doesn't limit polyphony for repeated instances of the same note.
note_selfmask=on should allow multiple repeated notes to play if the new notes are lower in velocity than the previous notes, but should cut off previous notes if the new ones are higher in velocity.
note_selfmask=off should cut off ALL previous notes on repeated note hits (if note_polyphony=1).
Sfizz plays repeated notes with full polyphony regardless of these settings.

Do you have an example? After some quick testing it looks like the behavior is similar between ARIA and sfizz for what I tried:
<region> sample=crash.wav note_polyphony=1 note_selfmask=on loop_mode=one_shot

If note_selfmask=off repeated notes will off the previous ones. If note_selfmask=on you can stack notes with decreasing velocity. A higher velocity note will steal the polyphony of a lower velocity one.

Let's see if this works as an example. In this test, repeated notes does NOT off the previous ones on Sfizz, but does in Sforzando. The only circumstance where Sforzando lets previous notes ring out is when note_selfmask is changed to "on", and the repeated notes are of lower velocity than the first. That's the proper behavior, right?
Perhaps this is related to that Sfizz lets the release phase of previous notes be polyphonic even when polyphony=1?
It sounds like at your end Sfizz DOES off previous notes? That's weird.
The disco tom pitch sweep in the example is so you can hear both the old notes and the repeated new ones:

sample=*triangle
ampeg_release=10
pitcheg_release=10
pitcheg_depth=1200
note_polyphony=1
note_selfmask=off


Fix/publish task

Fix publish task

Codecov Report

Merging #1312 (574dcc9) into master (5bbcf00) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   76.07%   75.96%   -0.12%
==========================================
  Files         142      142
  Lines        4218     4218
  Branches      137      137
==========================================
- Hits         3209     3204       -5
- Misses       1009     1014       +5

Impacted Files
Coverage Δ

...e/akka/actor/process_index/ProcessIndexProto.scala
97.16% <0.00%> (-2.36%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BUG] - Initialisation is extremely slow

Internal/External
External
Area
Other
Summary
After running cardano-node using the default configuration from 5b5310988c7c0500897bacb5555f3334d89f4aa1, there is a very long period before cardano-cli becomes usable. It seems to be about an hour. I'm using AMD Ryzen 5 1600 with 16 GB of memory.
Expected behavior
Initialisation should take much less time.
System info (please complete the following information):

OS Name: NixOS
OS Version: https://github.com/NixOS/nixpkgs/tree/fbd3124b92cc7ba1b354261c9aba092d2f2b3c20
Node version: cardano-node 1.31.0 - linux-x86_64 - ghc-8.10 \n git rev 5b5310988c7c0500897bacb5555f3334d89f4aa1
CLI version: the same

Closing this. If this is still relevant please reopen.


ValueError: mutable default <class 'pytest_tui.utils.TuiSection'> for field live_log_sessionstart is not allowed: use default_factory

Tried this out and it blew up.
pytest-tui 1.7.0
Python 3.11
Debian flavored Linux
Built-in terminal in VSCode
  File "/home/vscode/.local/share/virtualenvs/template_management_service-R81hyB01/lib/python3.11/site-packages/pytest_tui/utils.py", line 192, in <module>
    @dataclass
     ^^^^^^^^^
  File "/usr/local/lib/python3.11/dataclasses.py", line 1220, in dataclass
    return wrap(cls)
           ^^^^^^^^^
  File "/usr/local/lib/python3.11/dataclasses.py", line 1210, in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dataclasses.py", line 958, in _process_class
    cls_fields.append(_get_field(cls, name, type, kw_only))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dataclasses.py", line 815, in _get_field
    raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class 'pytest_tui.utils.TuiSection'> for field live_log_sessionstart is not allowed: use default_factory

Thanks for reporting this! Python 3.11 has some stricter rules around the use of dataclasses that I have not yet fixed in my code. I actually have an issue filed against the repo to fix this, just didn't get around to it yet - I'll work on it this weekend. In the meantime, can you re-try with Python 3.8, 3.9 or 3.10?

I've coded up a solution and posted the new package at https://test.pypi.org/project/pytest-tui/. Please give it a try and let me know if it solves your problem. I am still testing it, which is why I have not yet released it officially.

Works for python3.11, ubuntu, gnome terminal.
However
pytest --tui

has no effect, is it supposed to do anything?
tui

does launch a terminal ui.
more info
pytest==7.2.1
pytest-cov==4.0.0
pytest-metadata==2.0.4
pytest-tui @ file:///home/mmartin/github/dedlin/pytest_tui-1.7.2-py2.py3-none-any.whl

pytest --tui simply runs the Pytest session, and saves the test results in a format that either of the two console scripts (tui | tuih) can use to generate the results via their interfaces. So it's a two-step process right now. I kind of liken it to pytest-html, where you give the --html=report.html flag to the Pytest run, then you go find the results file and launch it in a browser.
At one point I had a whole configuration infrastructure built around tui and tuih, where you could set the scripts to auto-launch after running the Pytest session. I retired it because it felt intrusive, and it was a hassle to maintain. I've been considering bringing it back again, but before I do that, I need to focus on getting a thorough set of automated tests in place that will tell me if I've broken something during development. There have been too many times when I've made a seemingly innocent change, only to find out something was not working anymore.
Thanks for verifying the fix. I'll go ahead and get it up on Pypi.org soon.

Fixed in 1.8.0


Highlight for Float Win does not work correctly

Hi,
When I open BufSelect, highlight for Float Win does not work correctly:

It should be:

When I toggle Help section, it also does not work as well:

I don't see this happening on my setup.  What does the statement :hi NormalFloat return?  You can override or create the highlight group yourself by putting this statement in your init.vim, after setting your colorscheme: hi! link NormalFloat Normal

I don't see this happening on my setup.  What does the statement :hi NormalFloat return? You can override or create the highlight group yourself by putting this statement in your init.vim, after setting your colorscheme: hi! link NormalFloat Normal

Thank you. You're right, the colorscheme that I am using (https://github.com/ishan9299/nvim-solarized-lua) has not defined NormalFloat yet.
Before I close the issue do you think that it does make senses to add option to allow to overwrite highlight groups in float window, like this PR https://github.com/PhilRunninger/bufselect/pull/29 but its value is empty by default?

Sorry for making you confused. There are two problem in this issue:

BufSelect - Sort Highlight is not working correctly on startup - this pr https://github.com/PhilRunninger/bufselect/pull/30 to try to address this problem by adding redraw! on CursorMoved event.

Float Window's background is not the same as normal buffer - the reason maybe that NormalFloat is not defined in colorscheme. This PR https://github.com/PhilRunninger/bufselect/pull/29 to add option to allow to update float win's highlight

I'd rather not add complexity to this plugin to address a deficiency in the colorscheme, so I will close #29. Like I demonstrated above, the workaround is to define NormalFloat in your init.vim or init.lua.

I'm not sure what's happening with the sort highlight. I see it flicker as you show it in your screenshots briefly, but it always resolves to the intended appearance. However, if I remove this line - https://github.com/PhilRunninger/bufselect/blob/master/autoload/bufselect.vim#L12, the flickering goes away, and everything still ends up as it should. I'm not a fan of adding the redraw as you have it in #30. What happens when you remove the one on line 12 instead?
I added that redraw! in this commit 23c7a6136fdecf1fa8fcbcf25e3e3320cfc8cfef, but I don't remember the actual circumstances, so it might be OK to remove it if that solves your issue.

I'd rather not add complexity to this plugin to address a deficiency in the colorscheme, so I will close #29. Like I demonstrated above, the workaround is to define NormalFloat in your init.vim or init.lua.
I'm not sure what's happening with the sort highlight. I see it flicker as you show it in your screenshots briefly, but it always resolves to the intended appearance. However, if I remove this line - https://github.com/PhilRunninger/bufselect/blob/master/autoload/bufselect.vim#L12, the flickering goes away, and everything still ends up as it should. I'm not a fan of adding the redraw as you have it in #30. What happens when you remove the one on line 12 instead?
I added that redraw! in this commit 23c7a61, but I don't remember the actual circumstances, so it might be OK to remove it if that solves your issue.

I tried to remove redraw! line (https://github.com/PhilRunninger/bufselect/blob/master/autoload/bufselect.vim#L12) as you told, it solved my issue.

I'd rather not add complexity to this plugin to address a deficiency in the colorscheme, so I will close #29. Like I demonstrated above, the workaround is to define NormalFloat in your init.vim or init.lua.

Just adding a note about PR #29, It is not only for workaround but it will allow to customize/link BufSelect* highlight groups based on current colorscheme. For example, something like this:
let g:BufSelectFloatWinHighlight = 'NormalFloat:Normal,BufSelectSort:Pmenu,BufSelectCurrent:Keyword'

Thanks.

I've been thinking about changing the way the settings are done. I would like to combine them all into a single dictionary, like are used in the newer lua plugins. Perhaps I'll work your WinHighlight feature into that. In the meantime, the customization described at the bottom of the README should be capable of doing the overrides you describe.

Yes, sounds good. Closing PR now. Thanks for your support.


Read: fetch file_schema directly from pyarrow_to_schema

https://github.com/apache/iceberg-python/issues/584#issuecomment-2049204249

If we truly read by Field-IDs the names should be irrelevant, so we should probably update our mapping to ensure we correctly project by IDs.

I think we do correctly project by IDs. The real problem is the way that we sanitize the column names.
In https://github.com/apache/iceberg-python/pull/83, we add sanitize the file_schema in _task_to_table with the assumption that the column name  of the parquet file follows the Avro Naming spec. However, I think the "sanitization" should be more general here: it should just ensure that the final file_project_schema contains the same column names of the parquet file's schema.
The names in file_schema are different from the actual column names in the parquet file because we first try to load the file schema from the json string stored in the parquet file metadata: link
file_schema = (
            Schema.model_validate_json(schema_raw) if schema_raw is not None else pyarrow_to_schema(physical_schema, name_mapping)
        )

Parquet files written by iceberg java contain this metadata json string. The json string represents the iceberg table schema at the time of writting the file. Therefore, it contains un-sanitized column names.
Since we always need to run a visitor to sanitize/ensure column names match, how about we just get the file_schema directly from the pyarrow physical schema?
file_schema = pyarrow_to_schema(physical_schema, name_mapping)

This way, we can ensure that the column names match, and thus do not need to sanitize the column names later.
I have verified that changing to this can fix both the sanitization issue in #83 and the issue here. Given that we want to align the writing behavior with the java implementation, we should also proceed #590.
Borrowed the integration test from https://github.com/apache/iceberg-python/pull/590

Thanks @kevinjqliu and @Fokko for reviewing!