Realtime: timeouts implementations are outdated

I'm opening this issue because of:
(RTC7) The client library must use the configured timeouts specified in the ClientOptions,
falling back to the client library defaults and defaults described in ClientOptions below

Currently, the ClientOptions doesn't have any of the TO3l specifications:

disconnectedRetryTimeout: possible to implement with small refactoring
suspendedRetryTimeout: possible to implement with small refactoring
httpOpenTimeout: bigger refactoring
httpRequestTimeout: bigger refactoring
httpMaxRetryCount: bigger refactoring
httpMaxRetryDuration: bigger refactoring

The Realtime client use some defaults (basic timeouts):

connectTimeout: on connecting to the server
disconnectTimeout: retry interval when Disconnected
suspendTimeout: retry interval when Suspended

Different from what's defined on DF1.
DF1a and DF1b requires some refactoring.

With this I need to now what's important to test right now having in mind the current state of the lib.
@mattheworiordan /cc @paddybyers

Check changes:
https://github.com/ably/docs/commit/1f853e96b1a63fadf9c7c9f613d1a1d273a048cd

@ricardopereira implementing configurable timeouts is probably lower priority for now.
I am not sure what you mean by DF1a and DF1b needing refactoring, to be clear the impact I assume is:

connectionStateTtl  will simply map the existing max time in state for the disconnected state i.e. the iOS Realtime library should have already implemented some mechanism to move from the disconnected state to the suspended state after X time after being disconnected.  connectionStateTtl is simply this value.  Either way, this is not a public API attribute anyway
realtimeRequestTimeout is simply a generic timeout value that is applied to any request that should auto-fail if a response does not come back in that time, for example (RTN12b) If the CLOSED ProtocolMessage is not received within the default realtime request timeout, the transport will be disconnected and the connection will automatically move to the CLOSED state

This is done.


Force to use multipart/form-data in stead of application/x-www-form-u…

Related to the issue #788 , I would like to create this pull request in order to support people who got the problems like the issue's owner and me. It's just a small change, and don't affect to the original function.

Thanks for the PR!
I think this would be better implemented by checking to see what content-type the user set. If they set it to multipart, and there's no boundary, add it. That way we're not adding more API surface area, and being more intelligent for the user.
Impl would be around this area:
https://github.com/jhy/jsoup/blob/105f7bdcdbfffc879d0737cf857c02b6823b1b73/src/main/java/org/jsoup/helper/HttpConnection.java#L1004-L1007
Also please make sure you include test cases into ConnectTest.
https://github.com/jhy/jsoup/blob/e26267dd77b437f9e3ea155ae7a52013fde6c2f5/src/test/java/org/jsoup/integration/ConnectTest.java#L35

Hi @jhy ,
Thanks for your suggestion. I agree with that, it should be better. And I have already updated.

Revert the old way (open new api to force multipart)
Set the boundary when the user set the content type as multipart.

Thanks! I squash-merged this in (56ea479e22fdcb360696c5a922d6b45d9445e06d) and changed the constant's visibility for easier access


How to generate public and private keys

Hello, I would like to ask you for a help.
I am using next .NET 4.8 code for PFX saving, which is good for IIS.
`Dim privateKey = KeyFactory.NewKey(KeyAlgorithm.ES256)
Dim cert As CertificateChain = Await myOrder.Generate(New CsrInfo With {.CommonName = dr,
.CountryName = "CZ",
.State = "Czech",
.Locality = "",
.Organization = "",
.OrganizationUnit = "CA"}, privateKey)
Dim pfxBuilder = cert.ToPfx(privateKey)
Dim pfxData = pfxBuilder.Build(dr, My.Settings.pfxPassword)
Dim pfxFileName = Path.Combine(My.Settings.pfxFolder, dr & ".pfx")
File.WriteAllBytes(pfxFileName, pfxData)`
I need to have separate private and public keys for streaming software Unreal Media Server.
Would you be so kind to point me for some resources how to export these files?
Thank you very much
Miroslav

If you have a PFX file you can use OpenSSL to convert the file into a private key and public certificate file.

Hello, I got same idea and spent half day with this task.
It seems I can export certificate and private key with password, but when I try to remove password, I got error:
C:\mmsw\CertStore>"C:\Program Files\OpenSSL-Win64\bin\openssl" pkcs12 -in pfx\admin.mmsw.cz.pfx -out admin.mmsw.cz.key -nocerts -nodes
Enter Import Password:

C:\mmsw\CertStore>"C:\Program Files\OpenSSL-Win64\bin\openssl" rsa -in admin.mmsw.cz.key -out admin.mmsw.cz1.key
120900:error:0607907F:digital envelope routines:EVP_PKEY_get0_RSA:expecting an rsa key:crypto\evp\p_lib.c:469:

Further solution posted here: https://community.letsencrypt.org/t/windows-certes-how-to-generate-public-and-private-keys/191056/10
You have the option of calling .ToPem() on both your key and certificate chain then saving that output to files, or for OpenSSL use ec instead of rsa because your private key here is ECDSA not RSA.


Update to Serde 1.0

Release notes for 0.9.0: https://github.com/serde-rs/serde/releases/tag/v0.9.0
Release notes for 1.0.0: https://github.com/serde-rs/serde/releases/tag/v1.0.0

I think this is likely a breaking change, but if there's any way to conditionalize our code to cover a wide range of serde versions, maybe we can squeeze by.

Technically it's definitely possible but I'm not going to recommend that you do it. :rofl:
The way to do it would be make a serde-0-9 crate and a serde-1-0 crate that each depend on the respective version of serde and just contain extern crate serde; pub use serde::*. Then you could provide an impl for serde_0_9::Serialize as well as serde_1_0::Serialize.

Oy.  I was thinking more along the lines of detecting the selected serde version in a build script somehow, and just emit a feature name for that.  But maybe that's not possible.
We need to do a semver bump.  I've been procrastinating that forever.  Maybe stable i128 will finally be worth advancing num so we don't have that major lack.

We could do it as a separate num-serde crate, like url does with url_serde.

So I've got local changes for serde 1.0, and I was hoping to make a PR.
It seems like the options are:

bump to 0.2 and require serde 1
support both with features (trying to wrap my head around that one)
support both with intermediate crates
wrapper crate (num_serde)

The changes are pretty trivial if we do (1), but I don't see a PR/branch with them.  Would you like me to push it so it can be linked to the 0.2 milestone?  If not, would you like me to take a look at one of the other options?

We need to just do 0.2.  I hate to force an upgrade on the ecosystem, but it's going to happen sometime.  We'll do it in a side branch so we can batch as many breaking changes as we can at once.
To that end, there's now a next branch, and #302 to get it going.  When that lands, you can send a PR for next instead of master with the breaking change.  Serde 1 only, still behind an optional feature, and probably remove rustc-serialize while we're at it.  Sound good?

This is done on the next branch.


Consider putting Cartesian sampling into FourierOp

We should evaluate creating a Cartesian Sampling op in Fourier Op.

related to #228 #288 and #233


Multi-cursor movement shouldn't jump to the last cursor

Repro steps:

Open a file with a few hundred lines
Find a word that's used in many parts of the file
cmd-ctrl-g on this word to create a cursor on all the occurrences
see that it moves to the last occurrence. Intended behavior: shouldn't move
scroll all the way up to the first occurrence
hit the right arrow
see that it moves to the last occurrence. Intended behavior: shouldn't move

Why does it happen?
The screen movement logic is encoded in the single cursor implementation:
https://github.com/atom/atom/blob/0e992326154d387611543f618ad5872dc4665586/src/cursor.coffee#L255-L268
And the cursor movement action just delegates to all the cursors:
https://github.com/atom/atom/blob/f726dcc81bcd88eb7aff1e61bd77484b875f0854/src/text-editor.coffee#L2153-L2154
So, what happens is that we're going to iterate over all the cursors, and set the screen position on all of them and the last one is going to win.
Instead, what should happen is that if the screen is currently under any of the cursors, don't move. If not, then find the nearest cursor and move to that one, instead of the last one.
cc @nathansobo do you have advice on how I can refactor this piece of code to solve the issue?

Hey I'm out right now and on my phone, so I'll need to take a closer look tomorrow. But I wanted to pull the logic up out of cursor and into the editor for a long time.  Basically, if we can eliminate the cursor class entirely I think that would be a win.

So what we'll need to do is explicitly pass autoscroll: false when manipulating the cursors from the editor to suppress the auto-scrolling behavior of the last cursor.
I'm open to suggestions on what the behavior should be instead... Do we want to autoscroll the screen in some other way, rather than to the last cursor? For example, should we try to keep the set of cursors visible before the move still visible? Regardless of what we choose, autoscroll can be implemented in the movement methods of TextEditor directly.
If I had it to do over again, the individual cursor objects wouldn't even exist... cursors would be nothing more than state in the selections marker layer of the editor. Unfortunately, they're part of the public API now so we'll have to keep the existing autoscroll behavior working outside of the batch-oriented context since individual cursors can be moved.

It's still reproducible

Yeah, kind of glad the stale bot put it back on my radar.


fix(client): select all local dp

Before: Client checks if dp is local by dp.hosts[0].
Once there is one and just one dp satisfied, only one dp will be written till dp is full so that the write rate is low in the beginning.
After: Client checks if dp is local by dp.hosts.
All local dp can be chosen.

Codecov Report

Merging #1958 (561d05f) into master (853bcda) will increase coverage by 0.05%.
The diff coverage is 56.75%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1958      +/-   ##
==========================================
+ Coverage   48.11%   48.16%   +0.05%
==========================================
  Files         455      456       +1
  Lines       79612    79639      +27
==========================================
+ Hits        38304    38362      +58
+ Misses      38283    38233      -50
- Partials     3025     3044      +19

Impacted Files
Coverage Δ

master/metadata_fsm_op.go
52.98% <ø> (-0.05%)
:arrow_down:

master/server.go
57.81% <ø> (-0.52%)
:arrow_down:

sdk/data/wrapper/default_random_selector.go
1.86% <0.00%> (-0.12%)
:arrow_down:

master/cluster.go
45.89% <10.00%> (+0.16%)
:arrow_up:

master/api_service.go
28.78% <100.00%> (+0.75%)
:arrow_up:

master/config.go
80.00% <100.00%> (+0.45%)
:arrow_up:

master/data_node.go
53.40% <100.00%> (+0.48%)
:arrow_up:

master/dp_count_limiter.go
100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Ruby colors

Please provide as much information as possible, usually I need these information to actually start working on an issue, so try to fill as much of these as possible
Sample code
class CoursesController < ApplicationController
  before_action :authenticate_user!, except: [
    :index, :show, :search, :certificate, :all, :video]
  before_action :show_removed_course_flash_banner_if_applicable, only: :show

  layout 'application_v2'

  # GET /courses
  def index
    redirect_old_filter_by_tech_urls
    return if performed?
    render_courses_view(allow_json: true)
  end

Filename and Language selected
ruby
*.rb
Atom Original theme Screenshot

VSCode theme Screenshot

Versions used

VSCode version: 1.45.0
Theme version: 2.2.1

Extra information
I have the ruby plugin installed but nothing else

When I opened my Computer after the weekend all colors looked right... I have no clue why but the issue is solved for now!

Sorry My theme was not saved... the issue is still persistent

Thanks for opening this issue. I'll investigate and try to match the colors. I'll get back to you as soon as I release a new version.


Need an option to avoid internal DNS caching

I need a way for my connection to be automatically recovered at runtime when Postgres server is restarted under a different IP address (associated with a same domain).

Domain name resolution is taken care of by libc via ToSocketAddrs (Tokio and async-std both provide an async equivalent which just calls this inside spawn_blocking()) which, through a somewhat convoluted code path ends up invoking getaddrinfo(). This is invoked every time we connect so the only caching being done is either inside libc or as part of the operating system's DNS resolver.
Now, it turns out we actually have somewhat inconsistent behavior in the case that a domain resolves to more than one address.
The Tokio socket implementation will actually try them all in order as we just forward to TcpStream::connect(): https://github.com/launchbadge/sqlx/blob/main/sqlx-core/src/net/socket/mod.rs#L197
However, the async-std implementation is a little funky because async_std::net::TcpStream doesn't have the same set of calls we expect (try_read, try_write, poll_ready()) and so we have to go down one level and use async-io directly. But Async<TcpStream>::connect() doesn't use ToSocketAddrs so I had to implement that part manually, and I didn't realize the behavior as-written was inconsistent.
However, this only applies if the domain name actually resolves to multiple IP addresses. In your case, it sounds like the server restarts, gets a new IP address and then updates the domain dynamically. For that, we don't really have a solution without implementing the entire lookup in userspace.
You'd need to detect the restart and clear the DNS resolver cache at the operating system level, or just get a static IP for your database server (most cloud solutions offer something like this).


Service Migration Automation

This requirement only needs to consider the following scenario:
Customer runs their services in their Kubernetes cluster, we need to migrate their services to ease mesh automatically and safely.
The proposal as below:

Install EaseMesh into Kubernetes.
List the Kubernetes service deployment, and ask to choose the deployment to need to migrate.
Automatically get the current service's deployment YAML and migrate to EaseMesh, and deploy the Mesh version.
enable mesh version service and disable the original services gracefully. (can be done by traffic scheduling)

https://github.com/megaease/easemesh/pull/51 fixed by supporting native deployment of k8s


[BUG] KNN doesn't release memory when close index

Run big KNN indexes, and see memory usage keep high as 95%. Close one big KNN index, but memory usage still keep high.
Have to delete the KNN index to release the memory. After deleting the index, can see memory usage goes down to 75%.
Seems like a bug that when close an index, KNN doesn't release the memory.

@ylwu-amzn Thanks for reporting this. Yes, the problem is that we do watch for the files to be deleted to free memory as opposed to freeing memory when the IndexReader gets closed.
I think a fix for this is to implement a DocValuesReader that frees memory when it is closed.

Addressed in 2.18 with #2182

@jmazanec15 After  #1946, when close the indices, it would release the memory.


Stuck in update view

Every time this package gets updated, the atom package UI never finishes the "updating" process. The progress bar for the update is always on "updating..." and never finishes. The package is infact updated, the package ui just does not notice it. Is there a callback missing/not firing?

This was raised in #262. This is actually an issue with atom here and there is a pull request to fix it here


More open customization of Polly use

In certain contexts, we need to be able to fully tune the way Polly is used for timeouts and circuit-breakers, but not only that.
With this in mind, I'm proposing in this PR to open up the use of AddPolly by adding :
public static IOcelotBuilder AddPolly<T>(this IOcelotBuilder builder, Dictionary<Type, Func<Exception, Error>> errorMapping)
     where T : class, IPollyQoSProvider<HttpResponseMessage> =>
     AddPolly<T>(builder, GetDelegatingHandler, errorMapping);

 public static IOcelotBuilder AddPolly<T>(this IOcelotBuilder builder, QosDelegatingHandlerDelegate delegatingHandler)
     where T : class, IPollyQoSProvider<HttpResponseMessage> =>
     AddPolly<T>(builder, delegatingHandler, ErrorMapping);

 public static IOcelotBuilder AddPolly<T>(this IOcelotBuilder builder)
     where T : class, IPollyQoSProvider<HttpResponseMessage> =>
     AddPolly<T>(builder, GetDelegatingHandler, ErrorMapping);

Thanks to this, we will be able to use our own implementations of IPollyQoSProvider<HttpResponseMessage>, QosDelegatingHandlerDelegate  and  Dictionary<Type, Func<Exception, Error>>

Nice feature! :+1:

Not delivered


Upgrade all use-cases to pytorch 2

Maybe you could also add in the PR name/descriton that you'll upgrade also lightning as the main code changes come from this.


[WFLY-17363]: Upgrade artemis-wildfly-integration from 1.0.6 to 1.0.7

Upgrading artemis-wildfly-integration from 1.0.6 to 1.0.7 to fix the issue WFLY-17362 where some transactions are left in prepared state.

Jira: https://issues.redhat.com/browse/WFLY-17363
https://issues.redhat.com/browse/WFLY-17362
Signed-off-by: Emmanuel Hugonnet<EMAIL_ADDRESS>

Thanks @ehsavoie


[PROCS-3838] Add handling for ECS Fargate misconfiguration during chunking

What does this PR do?
This PR handles the issue described in https://github.com/DataDog/datadog-agent/issues/22940. Previously, when on ECS Fargate with a misconfigured pidMode setting, the process agent can fails to maintain the relationship between chunks and props in the ChunkAllocator when calling appendContainerWithoutProcesses causing a panic when props is accessed during ChunkAllocator.Accept. Now, ChunkAllocator.Accept is used directly in the function to that props and chunks remain equal in length.
Motivation
PROCS-3838
Additional Notes
The added unit test confirmed the behavior as it results in a panic on main but passes with this PR's changes.
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Run the agent as a sidecar container with container on ECS Fargate without pidMode set. Verify the panic no longer occurs and the log warning appears.
Sample task definition to create service from:
{
    "containerDefinitions": [
            {
                "name": "redis",
                "image": "redis:latest",
                "cpu": 0,
                "portMappings": [],
                "essential": true,
                "environment": [],
                "mountPoints": [],
                "volumesFrom": [],
                "dockerLabels": {
                    "com.datadoghq.ad.check_names": "[\"redisdb\"]",
                    "com.datadoghq.ad.init_configs": "[{}]",
                    "com.datadoghq.ad.instances": "[{\"host\": \"%%host%%\", \"port\": 6379}]"
                },
                "systemControls": []
            },
            {
                "name": "datadog-agent",
                "image": "public.ecr.aws/datadog/agent:latest",
                "cpu": 0,
                "portMappings": [],
                "essential": true,
                "environment": [
                    {
                        "name": "ECS_FARGATE",
                        "value": "true"
                    },
                    {
                        "name": "DD_PROCESS_AGENT_PROCESS_COLLECTION_ENABLED",
                        "value": "true"
                    }
                ],
                "mountPoints": [],
                "volumesFrom": [],
                "secrets": [
                    {
                        "name": "DD_API_KEY",
                        "valueFrom": "<secret>"
                    }
                ],
               ...
            }
        ],
}

Log:
2024-04-25 20:06:47 UTC | PROCESS | WARN | (pkg/process/checks/chunking.go:25 in chunkProcessesBySizeAndWeight) | No processes found for container , pidMode may not be configured correctly (set to task)

/merge

/merge c

/merge --cancel

/merge


Error 500 with latest version in adminpanel (page orders)

In adminpanel when checking the orders you get the following error on the orders page (wp-admin/edit.php?post_type=shop_order)
Status Code: 500
php error:
Uncaught Error: Call to undefined method WCMP_Export::find_order_shipping_classes() in /wp-content/plugins/woocommerce-myparcel/includes/admin/class-wcmp-export.php:870\nStack trace:\n#0 /wp-content/plugins/woocommerce-myparcel/includes/admin/class-wcmp-export.php(916): WCMP_Export->getOrderShippingClass(Object(Automattic\WooCommerce\Admin\Overrides\Order), 'flat_rate:1')\n#1 /wp-content/plugins/woocommerce-myparcel/includes/admin/class-wcmypa-admin.php(244): WCMP_Export->getPackageTypeFromOrder(Object(Automattic\WooCommerce\Admin\Overrides\Order))\n#2 /wp-includes/class-wp-hook.php(287): WCMYPA_Admin->showMyParcelSettings(Object(Automattic\WooCommerce\Admin\Overrides\Order))\n#3 /wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters(...\n', referer: https://xxxxxx/wp-admin/admin.php?page=wc-admin
woocommerce version: 4.8.0
wordpress: 5.6
php: 7.2.33
mysql: 10.3.24-MariaDB
MyParcel:  4.1.5

This has been fixed in version [4.3.1] (https://github.com/myparcelnl/woocommerce/releases/tag/v4.3.1) of the MyParcel WooCommerce plugin.


Fix a2s player query

Fix a2s player query again which has been broken by source updates again.
We again use the alternative method of requesting players with an invalid challenge.
This fixes #46.

Thank you for this fix!


Should referral bonus emails should be translated?

It looks like the referral bonus email text messages are not part of the translation file, which means they can't be translated. These need to be added to the .po file and then sent to translation.
cc @Mojganahk

Please make sure the file contains all the phrases which needs to be translated.

After seeing the commit from @alexdashkov, I've realized that putting all the HTML in the .po file is a bad idea (hadn't really thought it through). The entire file should be translated.
However, the other question is if we should really be sending Turkish referrals to all the friends of a Turkish user? Or should the referral email be sent in English? This is a question for @volentixnonton11 or @vlabs-mar.

@Mojganahk asked for all of the options. Here they are that I can think of:

Always send English email
Send Turkish email if sender is Turkish
Drop down on client side choosing language to send all emails in
Drop down on client side choosing language to send each email in
Send English email if sender is Turkish, but that also includes a link to a hosted copy of the referral email in Turkish (this hosted version in fact can display the referral link if we host the email on Venue)
Send all languages in email (probably won't fit)
Shrink the size of the email content in order to put all languages (might fit for ~2 languages)

Let me know what @Mojganahk and @volentixnonton11 decide.

5 and 7 seem most appropriate to me.
Sending only Turkish emails is ruled out because if it is an English
receiver and they flag as spam because it's Turkish and they can't
understand anything that has long term threat attached.
@mojganhk ?
On Fri, Aug 17, 2018 at 1:42 PM, Shawn Lauzon<EMAIL_ADDRESS>wrote:

@Mojganahk https://github.com/Mojganahk asked for all of the options.
Here they are that I can think of:

Always send English email
Send Turkish email if sender is Turkish
Drop down on client side choosing language to send all emails in
Drop down on client side choosing language to send each email in
Send English email if sender is Turkish, but that also includes a
link to a hosted copy of the referral email in Turkish (this hosted version
in fact can display the referral link if we host the email on Venue)
Send all languages in email (probably won't fit)
Shrink the size of the email content in order to put all languages
(might fit for ~2 languages)

Let me know what @Mojganahk https://github.com/Mojganahk and
@volentixnonton11 https://github.com/volentixnonton11 decide.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Volentix/venue-server/issues/181#issuecomment-413938910,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmMCiHIBGBjaIN9vIzxAcuZGCATZkMxeks5uRwCCgaJpZM4V-cFe
.

@volentixnonton11 @shawnlauzon  Number 5 can be a good option.


[Bug] Not encoded non-normative characters when in url or href, not seperate non-normative characters from English ones

Steps to Reproduce:

Create an 'md' file.
Write your href like this （mixed with Chinese characters）：

The "汉字" (or other non-lartain characters) shouldn't be included as the part of Url or href, or mailto：
Ref：https://github.com/nodejs/nodejs.org/issues/1612

@vscodebot：Not a duplicate question.

Please share the text of the code along with screenshots

@mjbvz：Thanks for your very quick reply, here's the text for your demo to reproduce this issue ——

Screenshots is in my 1st post (Non-Lartain Characters shouldn't be the part of the url or href, or mailto, so "汉字" and "我们" should be white instead of blue).

Here's the test file for you to download :)
README.zip

Thanks. Linked text for quick future reference:
http://www.baidu.com。

http://www.baidu.com汉字。

<EMAIL_ADDRESS>
<EMAIL_ADDRESS>

@mjbvz：Suddenly got an idea of how to encode these non-normative characters？
According to RFC 1738,  It says——
Octets MUST be encoded if they have no corresponding graphic
character within the US-ASCII coded character set, if the use of the
corresponding character is unsafe, or if the corresponding character
is reserved for some other interpretation within the particular URL
scheme.

No corresponding graphic US-ASCII:

URLs are written only with the graphic printable characters of the
US-ASCII coded character set. The octets 80-FF hexadecimal are not
used in US-ASCII, and the octets 00-1F and 7F hexadecimal represent
control characters; these must be encoded.

It seems that you can keep the Chinese characters but just do something like 'encodeURI' or 'encodeURIComponent'……What do you think of this？If you are OK with this idea, I'll change my topic.
^_^

Closing since there hasn't been any further interest in this issue for two years. We'd still take a PR if someone want to try to fix this and the solution is reasonable enough


Disable Export dataset option to user

Export dataset option should be visible only to Admin not to the user.
Because users can download the dataset to their local computer, it can cause data leaks and privacy issues.

Hi, Do you want a user to have access to a task (I suppose the user is assigned to the task in this case, right?), but at the same time does not have access to exporting features?

Exactly. Only admin can have the option to "Export Dataset".

You can try to assign users (who are not supposed to be able to export datasets) not to tasks, but to jobs. In this case they will not be able to export dataset for the whole task as far as I know.
@nmanovic can correct me if I am wrong.


nixos/amazon: drop

Description of changes
This is a PR dropping all the Amazon stuff that is unmaintained in nixpkgs. Read commits for details.
Feel free to revert and add yourself as a maintainer if you care about a particular piece.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

I was wrong about the ZFS image, I was able to finish building it just fine on bcc0da2607931f95903f9d0d64cc714fb7f9aa6b, though it did take a while:
[...snip...]
++ mv /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos.boot.vhd /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd
++ mkdir -p /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nix-support
++ echo 'file vpc /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd'
++ echo 'file vpc /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.root.vhd'
+++ /nix/store/v6r36lyl0c6cjd9n4d9vhqqwh1vrisdh-qemu-host-cpu-only-8.1.2/bin/qemu-img info --output json /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.root.vhd
+++ /nix/store/bpjd8324a6qj34zxhn5asgvi8bpm9bb2-jq-1.7-bin/bin/jq '."virtual-size"'
+++ /nix/store/v6r36lyl0c6cjd9n4d9vhqqwh1vrisdh-qemu-host-cpu-only-8.1.2/bin/qemu-img info --output json /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd
+++ /nix/store/bpjd8324a6qj34zxhn5asgvi8bpm9bb2-jq-1.7-bin/bin/jq '."virtual-size"'
++ /nix/store/bpjd8324a6qj34zxhn5asgvi8bpm9bb2-jq-1.7-bin/bin/jq -n --arg system_label 24.05beta-420383.gfedcba --arg system x86_64-linux --arg root_logical_bytes<PHONE_NUMBER> --arg boot_logical_bytes<PHONE_NUMBER> --arg boot_mode legacy-bios --arg root /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.root.vhd --arg boot /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd '{}
   | .label = $system_label
   | .boot_mode = $boot_mode
   | .system = $system
   | .disks.boot.logical_bytes = $boot_logical_bytes
   | .disks.boot.file = $boot
   | .disks.root.logical_bytes = $root_logical_bytes
   | .disks.root.file = $root
   '
/nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux

@cole-h Let me get you my traces.

Just to be clear, I'm not signing up to help maintain this stuff, but I think citing the reason for removal as "being broken", when it's not broken, is a bit weird :)

Amazon image: https://clbin.com/TVz4l (initially had a store corrupting bug with hash mismatch at install time, but that's Nix fault.)
Amazon image ZFS: it OOM for me, will try to get a proper log for it again but might be transient.

Just to be clear, I'm not signing up to help maintain this stuff (I very, very rarely use AWS EC2), but I think citing the reason for removal as "being broken", when it's not broken, is a bit weird :)

Yeah, you are right, I can be more precise in the individual commits about the reasons.

I will open a PR to add myself as maintainer instead of dropping. I have no interest in maintaining zfs support though as we don't use it At work

There's a pending amis pr https://github.com/NixOS/nixpkgs/pull/263075

@arianvp If you can send an ownership taking PR, I will close this one in the time being.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/ami-for-nixos-23-11/36860/2


Feedback iteration 2

[x] It is a good practice to have all the imports at the top of the notebook instead of in between because if there is a missing library, you will detect it at the beginning.
[x] Work in different branches and for every new small feature, do a PR to main

Hi Sir @miguelgfierro,
Issue 1: Imports not organized properly
Closed: Issue resolved
Thanks for bringing this issue to our attention. We have made the necessary changes and now all the libraries are imported at the top of the notebook. This should make it easier to detect any missing libraries at the beginning. The latest commit includes these changes.
Issue 2: Branching and Pull Request workflow
Label: enhancement
Thank you for your valuable suggestion on improving our project workflow. We completely agree that working in different branches and creating Pull Requests (PRs) for every new feature is a good practice. This will not only improve the overall code quality but also make the project more maintainable.
We will incorporate this advice for future improvement of the project's components and ensure that the team follows the recommended branching and PR workflow. We appreciate your input and will keep this issue open to track our progress on this enhancement.
Thanks again for your advices to our project!

Hi Sir @miguelgfierro,
Issue 1: Imports not organized properly
Closed: Issue resolved
Thanks for bringing this issue to our attention. We have made the necessary changes and now all the libraries are imported at the top of the notebook. This should make it easier to detect any missing libraries at the beginning. The latest commit includes these changes.
Issue 2: Branching and Pull Request workflow
Label: enhancement
Thank you for your valuable suggestion on improving our project workflow. We completely agree that working in different branches and creating Pull Requests (PRs) for every new feature is a good practice. This will not only improve the overall code quality but also make the project more maintainable.
We will incorporate this advice for future improvement of the project's components and ensure that the team follows the recommended branching and PR workflow. We appreciate your input and will keep this issue open to track our progress on this enhancement.
Thanks again for your advices to our project!


Added meeting minutes for march

Signed-off-by: dleniston<EMAIL_ADDRESS>Description
The work in this request adds the meetings minutes template and the minutes from the last TSC meeting (March).
Please review and offer feedback as you see fit.
Preconditions
None
Clean Up
There are no clean up steps required after the completion of this pull request.

Thank you Darren, the minutes are great :-) Have you committed the PDF intentionally?

I did purposely include the PDF in case it was easier to read without needing an editor. However I can remove it if needs be :)


error in Tests build

just tried to build the tests and got the error:

C:\dev\workspace\Simple-Web-Server\tests\parse_test.cpp(17): error C2248: 'SimpleWeb::ServerBaseSimpleWeb::HTTP::Request::Request': cannot access private member declared in class 'SimpleWeb::ServerBaseSimpleWeb::HTTP::Request'

ah, I see the problem, this is GCC specific stuff, but I'm from vc world
I see cmakelists scripts are not adapted for other than GCC compilers

I don't use Windows, but feel free to see if cl supports this option.

as far as I know - no, it doesn't . will try to use your lib on Win for my project. on the moment, looks useful for me. thank you!
then I'm going to close the request.
just a question before that - I see a lot of boost libs used in your project currently included into the standard, or in TR, I mean : regex, chrono, thread, filesystem, asio can also be used without boost dependency. why you don't minimize the dependencies from other than standard libraries?

please close the request, I currently don't know the solution,
if will find this I'll raise a PR


Support partial/tilde/carret versions in @version syntax

Would like to be able to specify the minimal (and max) version for a tool to install.
Would enable the following
uses: taiki-e/install-action@v1
      with:
        tool<EMAIL_ADDRESS>

Encountered in https://github.com/cross-rs/cross/pull/1042#issuecomment-1264685777

Thanks for the suggestion. Omitting the patch/minor version is already supported in some packages, and what you actually need for your use case is not to support the (complex) semver requirement, but to support omitting the patch/minor version in other packages as well, right?
https://github.com/taiki-e/install-action/blob/e85ee51dd0ff4e1362366b809fb249d9a672f562/.github/workflows/ci.yml#L32-L33

Yes! Nothing fancy needed
So this issue is only present on some of the packages, with some being those installed via binstall ?

cargo-binstall already supports this, i.e. cargo binstall<EMAIL_ADDRESS>or cargo binstall --version '~0.5' cargo-llvm-cov.

My comment was written in reverse, the issue is not present in those installed by cargo-bininstall I presume because of that

My comment was written in reverse, the issue is not present in those installed by cargo-bininstall I presume because of that

Oh sorry :D

It is the unexpected behavior that ~ is accepted when binstall is used as a fallback. If that was the intended behavior, officially supporting the package would always be a breaking change.

officially supporting a new package would always be a breaking change

Sorry that I didn't quite understand this.
Why would supporting a new package be a breaking change?

officially supporting a new package would always be a breaking change

Sorry that I didn't quite understand this. Why would supporting a new package be a breaking change?

Users install crate X using install-action's binstall fallback with ~ requirement. (install-action does not support crate X, but crate X support installation via binstall)
install-action now supports crate X. (No support for ~ requirements)
Workflow to install crate X using ~ requirement became broken because it ~ requirement is now not supported.

Workflow to install crate X using ~ requirement became broken because it ~ requirement is now not supported.

Thanks for the explanation, I got it.
So I think the solution is to reject version that contains any operator and make sure it only contains digits and ., I can submit a PR for this fix.

It is the unexpected behavior that ~ is accepted when binstall is used as a fallback. If that was the intended behavior, officially supporting a new package would always be a breaking change.

@taiki-e This is fixed in #26

This has been supported in 2.0.0 (taiki-e/install-action@v2).


Ability to use arbirary OAuth 2.0 authorization servers

First, nice project!
Did you ever think about providing something like a 'generic' function which takes a bunch of parameters to support OAuth 2.0 flows with authorization servers like https://github.com/thinktecture/Thinktecture.IdentityServer.v3 ?

First off, nice work with this library!
Regarding the OAuth 2.0 functions: will these then also work with ADFS?

Active directory is a completely different beast.  With that said, no this library will not work with ADFS.
Sorry,

That's too bad then. Any idea, example or library on how to authenticate against ADFS that you know of?

I don't know a single thing when it comes to ADFS.  You may try posting this question in the Ionic Framework forums.
Sorry,

I finally got the OAuth 2.0 working with ADFS. It is in fact not very different from the other providers. Any interest in adding this to the library?

Can you fork this repository so I can see your code?

Are there any updates on this issue?

Since this ticket has become more than one issue I'm going to close it.  If you have specific issues, please open a ticket and lets try not to get multiple topics into a single ticket.
Thanks,


chore(stepper): change background-color to inherit

SPT-2453
Description
This PR changes background-color for Stepper component to inherit so it can be displayed correctly in containers with non-white background-color
How to test

Compare two screenshots

Screenshots

Before.
After.

Review

[x] Read CONTRIBUTING.md and Component API principles
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure that tests pass by running yarn test
[x] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@sanex3339 can you please share a design where you've spotted this background is a problem for you? 🙇♂

Sure.


TypeError: oTable.fnSettings is not a function

Does YADCF support DataTables 2.0? fnSettings get dropped?

haven't checked compatibility with the 2.0, please share a working test page (jsfiddle / etc) so I check it out

@vedmack https://jsfiddle.net/425gmakb/1/
Your CSS is in the "CSS" tab, your JS is in the "JS" tab. At the very bottom is the sample code from your "DOM source" example.

Here is a self-contained index.html, jsfiddle just chokes out when I try and work in it with all that code. Hope this helps.
https://gist.github.com/VictorioBerra/6b2fd02957ad430a5ce91f95087b4b4c

Hi @VictorioBerra, I will check this out

@vedmack Any luck?

FWIW, all the legacy API has been removed (functions starting with fn). See https://www.datatables.net/blog/2024/datatables-2#Removed and https://www.datatables.net/upgrade/2#Removed for details.

@VictorioBerra @louking I just pushed the 2.0.1.beta.1 although I did a lot of API adoptions to the new  DT 2, there is still a lot of work to be done, so it might take some time, feel free to check it out and provide feedback
https://github.com/vedmack/yadcf/blob/master/2.0/jquery.dataTables.yadcf-2.0.js

@vedmack thank you!! I am looking forward to it!

@VictorioBerra check out yadcf 2.0.1.beta.3 on https://jsfiddle.net/vedmack/8bur71tk/ test page
feel free to provide additional test cases

new showcase page https://yadcf.web.app


use GitHub Actions instead of Travis-CI

https://github.com/xuwei-k/sbt-dao-generator/actions/runs/1767366751

@tkawachi 🙏


removing duplicate repository object

This PR just removes the duplicate 'repository' object from the package.json file.

Thanks!


Missing package.json for handlebars

Cannot install handlebars with npm
$ npm install -g handlebars
npm ERR! couldn't read package.json in .
npm ERR! Error installing .
npm ERR! Error: ENOENT, No such file or directory 'package.json'
npm ERR! Report this *entire* log at <http://github.com/isaacs/npm/issues>
npm ERR! or email it to<EMAIL_ADDRESS>npm ERR! Just tweeting a tiny part of the error will not be helpful.
npm not ok

NPM 0.2.19
Node 0.4.9

Both installed from apt on Ubuntu 11.10

packages are out-dated installed npm etc from current stable. all is well.


Cross-origin image load denied by Cross-Origin Resource Sharing policy.

I am getting Cross-origin image load denied by Cross-Origin Resource Sharing policy. issue in safari

Merged your pull-request, hope that solved the issue


Added short description on sidebar

Added search suggestion under search bar
Added link to GitHub repo to the description
Description
I've added a short description and link to the GitHub repo on the sidebar and some search suggestions under the search bar
Related Issues
#54 Lack of Information and Guidance in devFind UI
Changes Proposed
Added short description of the website with a link to the GitHub repo
`

            devFind is an open-source user friendly platform for developers to showcase their skills and connect with potential collaborators.
            Find out how to contribute by visiting our GitHub

`
Added search suggestion under the search bar
 <label className="search-suggestions">Try searching "India", "Python" or "ReactJS"</label>
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@CyberManMatt You can remove the search suggestion, there is a placeholder in search bar which says the same.
About the sidebar the description is too long, make it short sweet like Add you profile?, which directs to github repo. If you have any suggestions than let me know.

You can close this issue


It's This New Error?

Describe your bug here.
I Just Compiliing The Game And This It's Happened:

Windows Build Has Have The Problem.
Command Prompt/Terminal logs (if existing)
1s
Run haxelib run lime build windows --app-version="4.0.0-2951547312"
Called from ? line 1
Called from CommandLineTools.hx line 1895
Called from CommandLineTools.hx line 22
Called from a C function
Called from CommandLineTools.hx line 125
Called from CommandLineTools.hx line 1703
Called from lime/tools/ProjectXMLParser.hx line 21
Called from a C function
Called from lime/tools/ProjectXMLParser.hx line 50
Called from lime/tools/ProjectXMLParser.hx line 2043
Called from lime/tools/ProjectXMLParser.hx line 1528
Called from lime/tools/ProjectXMLParser.hx line 608
Called from a C function
Called from lime/tools/ProjectXMLParser.hx line 719
Called from a C function
Called from lime/tools/ProjectXMLParser.hx line 709
Called from /Users/runner/hostedtoolcache/haxe/4.2.1/x64/std/neko/_std/sys/FileSystem.hx line 69
Called from /Users/runner/hostedtoolcache/haxe/4.2.1/x64/std/neko/_std/sys/FileSystem.hx line 60
Uncaught exception - std@sys_file_type

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yeah

I'm no programmer but I think you need you reinstall haxe ( and possibly the libs)

I'm no programmer but I think you need you reinstall haxe ( and possibly the libs)

Nevermind, I Just Fixed


Feat/icon button as column type

Description

Add IconButton as column type

Fixes #5635
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feat/icon-button-as-column-type

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.9 (0)
36.76 (-0.02)
33.68 (0.05)
55.44 (0)

:red_circle:
app/client/src/components/designSystems/appsmith/IconButtonComponent.tsx
50 (0)
8 (-0.33)
22.22 (0)
60.61 (0)

:red_circle:
app/client/src/components/designSystems/appsmith/TableComponent/TableUtilities.tsx
39.16 (-3.93)
18.45 (-1.14)
15.79 (-2.96)
37.69 (-3.9)

:red_circle:
app/client/src/components/propertyControls/ColumnActionSelectorControl.tsx
40.43 (0)
28.57 (-3.01)
16.67 (0)
42.86 (0)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
50.71 (0.24)
38.6 (0.88)
36.21 (0)
55.35 (0.27)

:green_circle:
app/client/src/widgets/TableWidget/TablePropertyPaneConfig.ts
38.73 (10.04)
10.2 (2.83)
65.63 (18.01)
40.15 (10.24)

:red_circle:
app/client/src/widgets/TableWidget/index.tsx
27.14 (-0.27)
5.92 (-0.16)
25 (-0.49)
27.27 (-0.3)

Pls add jest or cypress tests as well.
Also do we need a docs PR update for this feature?

@somangshu @marks0351 this is the only reference to columnType i saw on the docs.
Not sure  there's anywhere to update this on the docs

@marks0351 Tested this PR and please find the status below,
1.Click on any o the icon in the table throws the following 'Cannot read property 'replace' of undefined'
https://www.loom.com/share/b2ca756a61f64451a813cd806707691b

@YogeshJayaseelan please leave all feedback together if possible. This will help us minimize the to and fro

@YogeshJayaseelan, Fixed the first issue, the same thing happens when you change to a Button type, You can open an issue for that and assign it to me

@somangshu, I felt it should have a JS option, since its on a Table, and Each row could have different icons and styles based on some other logic.

@Tooluloope Verified the fix for 6th point and it is working as expected.
Suggestion:
7. Can we remove the icon columns in filter pane options as we ignored buttons in the filter pane option - clicking on icons in the filter pane throws - oops try again something went wrong error
https://www.loom.com/share/aa71b1d39a484bfcb97f7c16159eff81

@Tooluloope Verified this PR and it is working as expected


OHBM 25 abstract

We're going with the IDP discoverability
TODO

[x] Outline abstract
[ ] Discuss outline (anything to add feature wise before submission -> prefer no)
[ ] Decide on figures to create for abstract (if any)
[x] Decide co-authors (input JB)
[x] Early draft for co-author feedback (by Friday 6th of Dec)
[ ] Implement feedback by Friday 13th of Dec
[ ] Submit by Monday 16th of Dec

waiting for feedback


brew install feroxbuster Not works

Hi
Can you please check why it doesn't work?  The download page seems to be empty
https://github.com/epi052/feroxbuster/releases/download/v2.2.5/x86_64-macos-feroxbuster.tar.gz - NOT FOUND
Thanks
brew install feroxbuster
==> Installing feroxbuster from tgotwig/feroxbuster
==> Downloading https://raw.githubusercontent.com/epi052/feroxbuster/master/ferox-config.toml.exampl
######################################################################## 100.0%
==> Downloading https://github.com/epi052/feroxbuster/releases/download/v2.2.5/x86_64-macos-feroxbus
#=#=#
curl: (22) The requested URL returned error: 404
Error: Failed to download resource "feroxbuster"
Download failed: https://github.com/epi052/feroxbuster/releases/download/v2.2.5/x86_64-macos-feroxbuster.tar.gz

that was 100% my fault, thanks for the heads up!  It should work now, lmk if it doesn't.


3213 Migrate from container registry to artifact registry

Motivation and Context
We are moving our images to an artifact registry.
What has changed

Update image URIs

How to test?
Check the new image URIs are correct
Links
https://trello.com/c/0LziJk8R/3213-migrate-from-container-registrys-to-artifact-registry-using-standard-repository-8

@liamtoozer All those changes were already merged on main, I just branched this wrong, so the diff is showing them. I've rebased to main and the changes shouldn't show up in the diff any more


Error whith empty .less file

In less for Node.js, if you @import a less file that exists but is empty (strictly - 0 characters exactly), you get a JavaScript error @ parser.js:190: str is not a String, and thus has no "replace" method.
A trivial workaround is putting a space in the file, so this is no big deal.

Yes, that's what I'm seeing. If it tries to import a blank file, it doesn't import anything else after that.

On Chromium 15, I'm getting the same error with any amount of white space in a blank file.


BOWImgDescriptorExtractor.Compute -> Send KeyPoints

I hope this is not a silly request but, I have a feeling that there is something wrong with the definition of BOWImgDescriptorExtractor.Compute method. KeyPoints are defined as out. How will we send the key points then? In EMGU it is not defined like that.
I could not able to get a result with the Compute method. The descriptor output is always empty:
DescriptorMatcher matcher = new FlannBasedMatcher();//nearest neighbor matcher
                BOWImgDescriptorExtractor bowDE = new BOWImgDescriptorExtractor(featureDetector, matcher);
                bowDE.SetVocabulary(this.Vocabulary);

                Mat samples; Mat responses;
                SVMHelper.GetTrainingData(class_mats, out samples, out responses, (mat) =>
                {
                    Mat desc0 = new Mat();
                    KeyPoint[] kp = featureDetector.Detect(mat, null);

                    int[][] pnts;
                    bowDE.Compute(mat, out kp, desc0, out pnts);
                    //bowDE.Compute(mat, desc0, out pnts);
                    //bowDE.Compute2(mat, out kp, desc0);

                    return desc0;
                }, null);

That's great, thank you shimat :)

Hi shimat. I am checking if the new version has been released almost every day. I would be very happy if you release latest changes soon. Thank you very much..

Try the following NuGet package source. The appvayor CI creates NuGet package every time the master is updated.
https://ci.appveyor.com/nuget/opencvsharp-1wksfub2jrci

Shimat thank you very much for spending your valuable time for my questions. But I couldn't manage to update with this link. I am using Visual Studio 2015, and update using Package Manager Console (Install-Package OpenCvSharp3-AnyCPU -Version <IP_ADDRESS>70126 for example) I coun't find how to update with https://ci.appveyor.com/nuget/opencvsharp
BTW: I am very happy with using OpenCVSharp. Thank to everyone that is involved on this great project.

Please try this command.
PM> Install-Package OpenCvSharp3-AnyCPU -Source https://ci.appveyor.com/nuget/opencvsharp -IncludePrerelease


Create software_artifact_examples.md

can I have editor rights on this repo? I would live to be able to refine the software artifacts zoo :)

@OR13, is this a draft?

@SteveLasker
This is ancient.... I requested the ability to create software artifacts examples, my intention was to just start a collection, so we have named examples to point to, when discussing specific artifact types.

@OR13, so, do you want to merge, or is this old and now outdated? Just looking for what action to take (LGTM or ?)

Steve, I wish to contribute the artifacts I plan to demonstrate during the SCITT Hackathon:
https://github.com/rjb4standards/SCITT-MVP-USeCases
SBOM, VDR and a Vendor Response File for OMB M-22-18.
FYI, these are actual production artifacts from REA's SAG-PM V1.2 product distribution.

Thanks, @rjb4standards,
Could you open a PR or Issue to track separately from here?
Would these be examples of evidence submitted to a SCITT ledger? It would be great to get a narrative, or are you suggesting these could be the types of evidence documents we could submit as part of: https://github.com/ietf-scitt/scitt-web/blob/a604c8630217c43ec49dac461d2f75b66ae9d7d3/what-is-supply-chain.md

In my view, a notary would examine these artifacts and the associated digital signatures of these artifacts and then insert a "trust declaration" claim into a SCITT Registry to indicate the combination of the artifact and digital signature are trustworthy.
I'll describe in more detail in an issue.

Steve, I've created an Issue to track this concept: https://github.com/ietf-scitt/use-cases/issues/26

Closing this PR, moving the content to the web repo, where I can merge.


handle closed yubihsm-connector connection

TL;DR
When yubihsm-connector is restarted / shutdown the yubihsm.rs http client enters infinite condition, and busy loops, eating up 100% of CPU time.

How to repro?
Components: TMKMS (v0.12.2) and yubihsm-connector (2021-03-ubuntu1804-amd64) + osmosis testnet node (can be any other cosmos-sdk network)
Setup A: Both tmkms and yubihsm-connector run on the same machine
In this setup it's hard to reproduce. I am not sure why, but out of many tries, I managed to break tmkms/yubihsm.rs only once.
Setup B: tmkms + osmosis node run on host A, where yubihsm-connector with HSM device run on host B
In this setup I can reproduce the issue every single time.
Flow

Start TMKMS + Osmosis node and observe tmkms logs to see signed votes
Restart yubihsm-connector (or shut it down and start again, or don't start at all)
Observe TMKMS logs, see the last log line:

Jun 28 18:32:47 <host A> tmkms[1349138]: 2023-06-28T18:32:47.623775Z DEBUG yubihsm::session: session=5 n=1147 uuid=dccf03d4-34bd-4156-af7b-352fbdeeb75d cmd=SignEddsa

Check CPU usage with TOP/HTOP and confirm the ~100% usage
Restart TMKMS and see it works again

FIX
The patch simply checks if socket returned 0 bytes and errors out if it did. Based on the Rust documentation 0 bytes indicates closed connection, in case of TcpStream, and that is precisely the case here. Yubihsm.rs uses TcpStream to transport HTTP messages.
Quote from docs:
Pull some bytes from this source into the specified buffer, returning how many bytes were read.

This function does not provide any guarantees about whether it blocks waiting for data, but if an object needs to block for a read and cannot, it will typically signal this via an [Err](https://doc.rust-lang.org/std/result/enum.Result.html#variant.Err) return value.

If the return value of this method is [Ok(n)](https://doc.rust-lang.org/std/result/enum.Result.html#variant.Ok), then implementations must guarantee that 0 <= n <= buf.len(). A nonzero n value indicates that the buffer buf has been filled in with n bytes of data from this source. If n is 0, then it can indicate one of two scenarios:
1. This reader has reached its “end of file” and will likely no longer be able to produce bytes. Note that this does not mean that the reader will always no longer be able to produce bytes. As an example, on Linux, this method will call the recv syscall for a [TcpStream](https://doc.rust-lang.org/std/net/struct.TcpStream.html), where returning zero indicates the connection was shut down correctly. While for [File](https://doc.rust-lang.org/std/fs/struct.File.html), it is possible to reach the end of file and get zero as result, but if more data is appended to the file, future calls to read will return more data.
2. The buffer specified was 0 bytes in length.

Test plan
I did reproduce the faulty flow with the patched binary and I could see the message:
Jun 29 22:38:32 <host A> tmkms[2888484]: 2023-06-29T22:38:32.272595Z ERROR tmkms::client: [...] signing operation failed: signature error: protocol error: protocol error: bad response from connector: error reading response

after that tmkms moves on and signs the further messages.
Unittests:
$ cargo test
test result: ok. 29 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 22.70s

$ cargo test --features=usb
test result: ok. 29 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 33.73s

$ cargo test --features=mockhsm
test result: ok. 27 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.61s

Why is this important?
Without the patch, every time the yubihsm-connector is restarted, the tmkms gets stuck. This may happen rarely on the localhost, but occurs 100% of the time in the remote setup.

@mkaczanowski can you please rebase?

done


Improve Push Notification UI & Refactoring

Motivation
The process for implementing new features for push notifications was a bit less thorough than usual. We need to do some clean up after the release of #2380.
Proposed Solution

Show draft status of a message in the Status box.
Filter messages in the API by draft=False status. If we publish this update to soon (8 weeks?) after #2380, we may accidentally remove messages from the API that should still be there.
Change caption of "Save & Send" to "Save & Schedule" ("Speichern & Später senden") if the schedule checkbox is selected
Change caption of "Save" button to "Save as Draft" ("Entwurf speichern")
De-duplicate code in the news and template list views
Use a multi-select for the region selection (to avoid extremely long lists for admins)

Alternatives
None really :)
User Story
As a news author I want save my work in progress, schedule and directly send finished push news so that the notification reaches the app users at the intended time.
Additional Context

https://chat.tuerantuer.org/digitalfabrik/pl/sgnuh4f4stn1i8ufyx9bg64zuc

Design Requirements

Would it alternatively be an option to only show save & schedule in case the schedule checkbox is checked? To save as draft, users could still just not click the schedule checkbox and then save without sending.
Providing a save as draft button for scheduled messages would also be possible, but then we would probably need to modify the push notification model and introduce some more complexity.

@david-venhoff I agree! :+1:
If a notification should not be sent (and not even in the future), then the scheduling checkbox should not be enabled.
Actually, the draft state does not really have an effect for push notifications anyway, so we might remove that field.
No matter if draft or not, push notifications that are not yet sent are not delivered via the API.

I think it is a use case to set a date etc but wait for confirmation from another person? I therefore think the draft state is quite useful. It is already in use for the scheduler. But I think we forgot to implement it for the API.

Filter messages in the API by draft=False status. If we publish this update to soon (8 weeks?) after Release 2023.7.3 #2380, we may accidentally remove messages from the API that should still be there.

Could we just update the existing entries to be consistent with what we would expect their draft status to be according to the current behaviour? I guess ideally as part of the migration of #2378, but also manually in the DB if need be?

Is my understanding correct that:

Before #2373 the draft field was unused and always True
After #2373 The draft field is True iff the message was not sent and is not a scheduled push notification that was submitted via Save and send?

If so, an automatic migration might not be possible anymore. @svenseeberg Is manually migrating the DB still an option?

As all notifications were public before the release, we can set draft=False for all messages that were created before our update time.


Add files via upload

Pull request

@DarkK0o file/lib/domains/pl/edu/zsp1piotrkow.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

Should work now


first pass at ways to request an extract

closes #34

Looking at https://mapzen-odes-extracts-pr-35.herokuapp.com/static/index.html, I like this direction. Couple thoughts as I interact with it:

When typing, we get auto-complete for existing extracts. Could we use autocomplete with Mapzen Search instead, to make it possible to show existing extracts based on coverage rather than name matches? E.g. “Fremont” could get me to the overlapping SF Bay Area extract as part of the autocomplete process.
The visible results work well as boxes. They might also need to show up as text or a list to the right of the map? For a really big overlapping request, the whole map is blood-red due to a big bbox, which is odd.

@migurski since this PR was supposed to be about ways to make a request, I'd like to move the "contained in an overlapping area" to another issue

Okay!
The right-hand side is still a bit weird; do you want to leave that for another issue?

Open the page and see this

Start typing, filter the list below and also see autocomplete suggestions

type out a thing and hit enter if the extract exists

selecting an extract from the drop-down menu that already exists: not great! addressed by #37

if it does not you get this


Input: update to v1 API

[Current coverage][cc-pull] is 85.45%

No coverage report found for master at 65592b2.

Powered by Codecov. Last updated by [65592b2...5cc8abe][cc-compare]
[cc-base-branch]: https://codecov.io/gh/TechnologyAdvice/stardust/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/TechnologyAdvice/stardust/compare/65592b2f3d1a60b35f3702ba448908abd127bebd...5cc8abeb27b979e78802a91688df9b097242cd3e
[cc-pull]: https://codecov.io/gh/TechnologyAdvice/stardust/pull/281?src=pr

Input API Proposal
Here is how I see the v1 API applying to the Input.  Would love feedback.  I'll update this comment as we narrow things down in the comments.
Input
<Input />

  <input type="text" >

Focus
<Input focus />

  <input type="text">

Loading
In SUI, the loading style automatically adds a spinner icon, or overrides the provided icon.  It then requires either an icon or left icon class to correctly place the icon on the left or right.
Loading only
I propose we add the icon class by default when the loading prop is given.  This would place the spinner on the right inside of the input.
<Input loading />

  <input type="text">

Disabled
<Input disabled />

  <input type="text" disabled="disabled">

Error
<Input error />

  <input type="text">

Icon
I see two possible APIs for the input icons:

Makes use of the iconPropRenderer
Follows the labeled and action pattern (ie icon or icon='left') and allows an Icon as an input child.

The two suggestions here follow the first option above.  After writing the rest of the examples, I am leaning toward API number 2 (see alternative below).
Icon
<Input icon='search' />

  <input type="text">

Left Icon
We might expect this to be icon='left' however, there is then no way to pass the icon string.  Open to more ideas on how to achieve left/right icon positions.
<Input leftIcon='search' />

  <input type="text">

Alternative
The alternative is to allow Icons as children (as we do with actions and labels). The Input icon class would be inferred if there is an Icon child.
It would exclude the use of the iconPropRenderer.  Therefore excluding the simple icon='search' use as well.
Though it would be more consistent with the labeled an action props.  Lastly, it follows the cx utilities as well icon='left' => class="left icon".  Whereas, iconLeft='search' seems to break away from the pattern.
I think I prefer this alternative syntax to the icon prop but would love any feedback.
// same as <Input icon>
<Input>
  <Icon name='user' />
</Input>

<Input icon='left'>
  <Icon name='settings' />
</Input>

<Input action='right' icon='left'>
  <Icon name='search' />
  <Button>Search</Button>
</Input>

  <input type="text">

  <input type="text">

  <input type="text">
  <button>Search</button>

Labeled
Labeled Inputs can be pretty complex.  I've include all the SUI examples here to be sure we cover them all.
Our current Input supports most all of these already.  The approach was to use children for any buttons, dropdowns, or labels.
Again, any input or feedback is much welcomed.
Label
Just as I am proposing the loading input automatically adding the icon class, I propose a Label child automatically adds the labeled style.
// same as `<Input labeled>`, inferred by child
<Input>
  http://
</Input>

http://

  <input type="text">

Label Dropdown
The docs for this input configuration show use of a label class on the dropdown.  This is not documented in the dropdown itself.  I've added #291 to consider how we should support it.
<Input labeled='right'>
  <Dropdown label options={[...]} />
</Input>

  <input type="text">

.com

.com

.net

.org

Right Label
<Input labeled='right'>
  kg
</Input>

  <input type="text">

kg

Left and Right Label
When two labels are given, the input must be in between them in the markup.  Notice also the HTML requires the right labeled class even though there are labels on both sides.
I propose the order of the label children should determine which is left/right.  Also, that the style labeled='right' should be inferred by the presence of two labels.
// same as <Input labeled='right' />
<Input>
  $
  kg
</Input>

$

  <input type="text">

.00

Left Corner Labeled
Corner labeled inputs require HTML classes that match the corner position of the Label itself.  I propose we infer the Input classes from the Label props.
// same as <Input labeled='left corner' />
<Input>

    <Icon name='asterisk' />

</Input>

  <input type="text">

Corner Labeled
As with the left corner labeled Input above, I propose we infer the Input labeled classes to match the label props.

See #292 for Label boolean corner prop support

// same as <Input labeled='corner' />
<Input>

    <Icon name='asterisk' />

</Input>

  <input type="text">

Action
I see the action prop behaving much like the labeled prop.  Since there are only a limited number of supported Input actions, I think we should infer the action prop settings for the Input.
I also notice action class is synonymous to right action.
Action
// same as <Input action />
<Input>
  <Button>Search<Button>
</Input>

  <input type="text">
  <button class="ui button">Search</button>

Left Action
<Input action='left'>
  <Button color='teal' labeled icon='cart'>
    Search
  <Button>
</Input>

  <button class="ui teal labeled icon button">

    Checkout
  </button>
  <input type="text" value="$52.03">

Right Action with Left Icon

This shows the alternative form of the proposed icon API

<Input action='right' icon='left'>
  <Icon name='search' />
  <Dropdown basic floating button options={[...]} />
</Input>

  <input type="text">

This Page

This Organization

Entire Site

Dropdown Action
// same as <Input action>, inferred by children
<Input>
  <Dropdown compact selection options={[...]} />
  <Button type='submit'>Search</Button>
</Input>

  <input type="text">
  <select class="ui compact selection dropdown">
    <option value="all">All</option>
    <option selected="" value="articles">Articles</option>
    <option value="products">Products</option>
  </select>

Search

Transparent
<Input transparent />

  <input type="text">

Inverted
<Input inverted />

  <input type="text">

Fluid
<Input fluid />

  <input type="text">

Size
<Input size='mini' />
<Input size='small' />
<Input size='large' />
<Input size='big' />
<Input size='huge' />
<Input size='massive' />

  <input type="text">

  <input type="text">

  <input type="text">

  <input type="text">

  <input type="text">

  <input type="text">

I've been having a look at labeled/action syntax and seems like a bit of a stumbling point, not only from an implementation standpoint, but also one of user clarity.
Leaving Icon out, how many labels/actions can an Input feasibly have?  Is it correct to assume one of either, one left and one right?  Assuming there is some limit, how do you handle other added components that don't fit the template?
I'm not a fan of making user assumptions, as more often than not they turn out to be incorrect. Is there no way of ring fencing left/right label/action's and to follow the emerging syntax a little more closely?  (just thinking out loud here):
<Input>
  <Input.Left label>
     <Icon name='search' />
  </Input.Left>
  <Input.Right action>
    <Button>Search</Button
  </Input.Right>
</Input>

Seems a little more declarative, and digestible for the end user, but also enforces correct configuration?  So you could easily define what gets glued onto each side, be it a label or action, either of which could contain an Icon.

This syntax could easily be rolled out across similar components.  Was scratching my head looking at Button labeled/icons earlier, and this could fit the bill there quite well also:
<Button>
  <Button.Left labeled icon="pause"/>
</Button>
<Button>
  <Button.Right labeled icon="right arrow" />
</Button>

I've got an updated proposal that I intend to post here once I finish up the Form in #400.  My focus will then shift to Input and Button since they are very related.

Heads up!  I'm resuming work on this PR now 🍻

@levithomason - I have a request/idea for this component: It's currently not possible to add props to the underlying input that are also props of the Input component (e.g. there's no way to add a class to the input since className is a handled prop of Input. This is preventing usage of the Input component within the Search component since the input tag needs the prompt class.
I'd propose an input shorthand prop that is passed to a factory to create the <input> tag. A string could be treated at the type, options would be passed as props. The defaultProp would be text so you'd get the current default (<input type="text">).
The weird thing here would be that you could technically pass null to not render an  tag at all, although I can't see any scenario where anyone would do that unintentionally.

Cool, I'll incorporate an input shorthand here.

Update
The newly updated API spec for customizing the HTML <input /> and dealing with the labeled and action variations this looks like so:
<Input
  label='http://'
  labelPosition='left'
  input={<input />}
  action={<Button icon='heart' content='Like' />}
  actionPosition='right'
/>

Where label, input, and action are all shorthand props.  They will accept a literal, props object, or element. Also note, any input props passed are automatically spread on the <input /> itself.  So the input shorthand prop here is mainly needed for adding classes / style props to the input.
This will be my main focus tomorrow.  The Button API is scheduled to be updated to keep consistent.  See #510.

The Input API spec of <Input label='.com' labelPosition='right' /> will not work for inputs with a label on the left and on the right:

The same actions API <Input action='Checkout' labelPosition='left' /> will not work for inputs with multiple actions:

The first thought was to go with leftLabel rightLabel, however, this does not extend to the actions very well.  There are two actions on one side.  Ideally, this would be consistent for icons, labels, and actions both here and in the Button API.  Here is a start at the available patterns for each prop:
icon iconPosition - works for all components, only ever one icon
leftLabel rightLabel - works for all components, only ever one label per side
actions actionsPosition - if actions took an array of components, this would work.  can have multiple actions, but only ever on one side at a time
What I don't like is the inconsistency there.  I'd almost rather support a single icon, label, or action and go with foo fooPosition` across the board.
@jcarbo @layershifter Help? :confused:

What about this?
const elements = [
  Left,
  {position: 'left', element: Left},
  {position: 'right', element: Rigth},
];

const leftElements = _map(elements, element => {
  if(_.isObject(element) && element.position === 'right') return

  return element
})

const rightElements = _map(elements, element => {
  if(_.isObject(element) && element.position === 'right') {
    return element
  }
})

function Input () {
  return (

      {leftElements}
      <input>
      {rightElements}

  )
}

It will be simply validatable with props, but there will be key problem.

It is an option, I actually suggested this same thing to our team offline :)
<Input labels={[
  { position: 'left', content:'$' },
  { position: 'right', content: '.00', basic: true },
]} />

It just seems too verbose / clunky IMO.  That said, it is better than having a different API for every prop.  I'm not sure if it is better than just supporting a single icon/label/action with a single foo``fooPosition API though.

Okay, what about full sub component markup? It will make everything simplier there.
<Input>
  1
  2
  <input type="text" />
  3
  4
</Input>

Or even this.
<Input>
  <Input.Left>
    1
    2
  </Input.Left>
  <Input.Right>
    3
    4
  </Input.Right>
</Input>

Thanks, I'll let this incubate a bit while I work on the prop standardization.

I love the simplicity of <Input label='foo'/>.  I think 90%+ of the time you just need a single label, icon, etc next to an input.  Supporting more than one label elegantly is great, but I'd hate to lose declarative simplicity to support what seems like an edge case.
My preference would be to have 1 label be done with a label prop, with labelPosition to dictate the side.
(FWIW, I’d prefer labelOn over labelPosition, less to type, reads a bit cleaner IMO and fits with on prop proposal below)
<Input label=“Foo” labelOn=“right”/>

yields

  <input type=“text”/>

Foo

For simplicity, I’d make inline labels exclusive with the label... props, but supporting both would probably work.
Then if the developer wants more than one label or to do something fancy, they can just create inline elements and use an on prop in the child to set the order.  The parent element would “consume” the on prop of the nested elements.  I’d probably infer the order based on child order if on wasn’t specified.
Fancy label
<Input>
  That name is taken!
</Input>

yields

  <input type=“text”/>

That name is taken!

Multiple Labels
<Input>
  $
  kg
</Input>

yields

$

  <input type=“text”/>

kg

I’d do the same with icon and iconOn props:  they can easily get one icon with props, if they want more than one, use nested elements.
Same for actions: action and actionOn props for one auto-created action, then use inline elements with an “on” prop to specify more than one.  This extends nicely to the case where you have multiple actions on a side.
<Input>
  <Button on=“left” content=“Left"/>
  <Button on=“right” primary content=“Right1"/>
  <Button on=“right” content=“Right2"/>
</Input>

yields

  <button class=“ui button”>Left</button>
  <input type=“text”/>
  <button class=“ui primary button”>Right1</button>
  <button class=“ui button”>Right2</button>

The child on paradigm should extend well to other elements (Button, etc) which auto-create sub-elements given certain props.
I'd be happy to work on supporting this if there's interest.

I really like labelOn for its brevity.  I'll run this by our team for some more input.  I'd like to use this for the props API.
I also really love the idea of not having an <input /> child by consuming the on prop for children.  However, the sub component API is the escape hatch for when the props API boxes you in.  We must provide full access to the markup in at least one of the APIs, otherwise, we create a trap that we're sure to fall into.
There are two (albeit unlikely) limitations we'd add with the on child prop API:

Using a child component that had an actual on prop.  If we consume it, then the component will never receive it.  We'd have to assume the user will never use a component child that requires an on prop.
Inability to access the <input /> directly.  If we abstract away this element, then the user will never be able to access it (to wrap it or what have you).  Since shorthand props are not allowed with children, the user also would not be able to pass a shorthand input and the child components.  We could create a trap here.

Since the difference in the amount of code for adding on markup to children vs adding an actual input is negligible, but requires more logic and brings more limitations, I think we should avoid on for children.  Thanks for the detailed write up and engineering contribution, much appreciated.

Folks I respect have out voted me on labelOn, looks like we'll go with labelPosition!

I take your point about the on prop being consumed when sub-elements might want to use it.  It's non-optimal but it sure does feel natural to me when I read the JSX.
What's your current thinking for the ability to put a label on either side?  I'm really not wild about the "labels" option above -- if I'm specifying components in JSX, I want to specify sub-components in JSX as well, not JSON.  It also doesn't extend well to actions where you might want more than one on a side (unless you add a "postion" or "on" prop to your JSON spec, or use a map of arrays, etc).  Also, for the 90% case where I only want one label, having to use labels (and presumably pass in an array) is awkward.
What about the strategy of using an "empty" <input> as a placeholder value inside the <Input>, eg:
<Input>
    Foo
    <input>
    Bar
    <Dropdown>...</Dropdown>
    <Button>...</Button>
<Input>

The description of how to use this would be:
"If you want more than one label, icon, action, etc, place an <input/> sub-element without any props as a marker in the place where you want the input control to go, relative to the other subcomponents."
Eg:

If they specify an <input> sub-element without props, we'll replace it, either with the automatically generated <input> element, or with the value of the input prop if they provide one.
If they specify an <input> sub-element with any props, we'll use that as the main input element.
If they don't specify an <input> sub-element, all of the labels/etc will appear before the auto-generated input element.  If this happens and they get confused, a quick look at the docs tells them an easy way to get exactly what they want.

Actually, if we had this, I'd be content to drop the "labelPosition" prop and just default to putting the auto-generated  from the label prop on one side or the other.  Keep the set of props as simple as possible, and let them use nested elements to do anything else.

Also, re: labelOn vs labelPosition -- position feels more "techy" and doesn't seem to fit with the "make things as english-like as possible" philosophy of Semantic UI.
If I was describing the component to someone, I'd likely say "put the label on the right" -- which translates pretty exactly to labelOn="right".
I'd be very unlikely to use position when describing something this to someone, if so I'd probably say "position the label on the right".  Mapping that to labelPosition="right" feels awkward to translate mentally and doesn't feel like english.  And I note that I'd still say "label on...right".  :-)

Most all the above comments are outdated and inaccurate.
Current API (single label/action)
The majority use case of a single label/action can be achieved without child components:

This also translates well for complicated labels, like in SUI's ability to use a Dropdown as a Label:

Current API (multiple labels/actions)
The current state of this PR (and vote) is to use the below API for multiple labels.  It will also be used for actions.

input child
I want to make things as simple as possible.  Given the SUI constraints here, I think that means render children based on props:
<Input />

  <input type="text" />

Otherwise render the children as is:
<Input>
  // ...
</Input>

  // ...

This is very clear and consistent with our other components.  Any additional branch logic I fear will further complicate things.
labelOn naming
I agree with your comments on SUI's philosophy here.  There will be a final sweep through all components and props once we finish the legacy component migration, #269.  I'll reconsider this at that time.  Appreciate your zeal regarding it.

Ah!  Long awaited, but I think it is finally done.

Whew, released in<EMAIL_ADDRESS> Thanks to everyone for chipping in on this one in so many ways.  Much appreciated.


task-54 Update Dockerfile and remove pyvista import

Pyvista import is not working correctly inside the container.

Merging this without closing the pull request.
Will wait for the docker-publish.yml workflow to complete successfully.

.


Extend convertLocalUriToShared to add support for untitled files

The live share API method, convertLocalUriToShared does not include support for untitled files. As a result, we've had to implement some pseudo-matching behavior to match the implementation of the filename on the client side to support our extension (Quokka.js) running on unsaved files.
Since we use the API for matching files, ideally we would like to use the same API which would give us a single way of mapping files (regardless of whether they exist on disk or not).

@smcenlly Are you blocked by this? It seems you have a workaround for now.

We're not blocked by this, we have a workaround for now.

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.


instead of silently ignoring / asserting return an error if one tries to create a collection on a dbserver

Scope & Purpose
behave honest to the wrongly API on DB-Server using instead of silently ignoring the collection cretion or asserting.

[x] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :book: CHANGELOG entry made

Backports:

[x] Backports required for: all

Testing & Verification
use arangosh to create a collection on a dbserver.

[x] This change is a trivial rework / code cleanup without any test coverage.
[x] The behavior in this PR was manually tested

Link to Jenkins PR run:
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/14776/

We should also protect HTTP DELETE in the same way, potentially also HTTP PUT. It may be easier to do this in execute().


A couple of errors and questions about the examples repo

Hi ICP folks,

nft-wallet example failed to deploy locally

When I followed https://github.com/dfinity/examples/blob/master/rust/nft-wallet/README.md#step-1-you-can-deploy-the-dapp-using-the-startsh-script to deploy locally, I got the following error
created public/build/main.js in 12.8s
thread 'main' panicked at 'Could not create HTTP client.: reqwest::Error { kind: Builder, source: "Unknown TLS backend passed to `use_preconfigured_tls`" }', /Users/nanjiang/.cargo/registry/src/github.com-1ecc6299db9ec823/ic-agent-0.20.1/src/agent/http_transport/reqwest_transport.rs:79:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Can I use dfx command to list all transactions in cycle?
e.g. dfx wallet --network ic balance is for checking the total balance, but no transaction history.

Thanks and regards,

Which version of dfx are you using?

There are canister functions for transaction history, but dfx does not use them, only the web UI does.

Thanks @adamspofford-dfinity for the prompt response.

Sure, dfx version is dfx 0.16.0, would you be able to deploy it locally successfully?

Regarding There are canister functions for transaction history, but dfx does not use them, only the web UI does.

Did you mean the web UI like below, where I didn't find Cycle transaction history (gas fee history)

I also got the same issue under dfx 0.16.1.
I cloned the examples again incase they were updated.
nft-wallet panicked in the same spot as the above.

Aha, I see the problem. Run cargo install icx-asset --version 0.20.0 --locked, the --locked part being important. Does this resolve the error?

Yes @adamspofford-dfinity , it fixed the problem, appreciate your help.


Updated gp-gas-estimation dependency

Codecov Report

Merging #1610 (ec80887) into main (8a0610e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1610   +/-   ##
=======================================
  Coverage   66.61%   66.61%
=======================================
  Files         171      171
  Lines       33647    33647
=======================================
  Hits        22415    22415
  Misses      11232    11232


Support Public Project

Current State
Currently, the module only supports private projects because it compresses and uploads the app. Through the file upload approach, PhoneGap/Build requires the project to be private (closed-source).
Goal
We need to add support for public projects.
Problem
This means that we need to implement a new workflow to support linking to open source repositories.

já apaguei i ID, alterei, e nada até agora, sempre aparece o mesmo erro
"error":"app 123121 not found"
o que faço?


Inconsistent order in fish_user_key_bindings from fisher and fisher up

fisher bang-bang; and fisher pisces; and fisher fzy
results in this order of key bindings:
less functions/fish_user_key_bindings.fish | grep '#' | uniq | sed s/###//g | string trim

bang-bang
pisces
fzy

fisher up after that – seemingly reproducibly – creates a different order:

bang-bang
fzy
pisces

I would expect fisher up to keep the original order.

More generally, I think that the order in fish_user_key_bindings should be independent of the order of installation, i.e. a pure function of the set of the installed plugins.

👋 Hi, @alexbepple. I'm going to remove this feature. See: #443.

You opened #443 like more of a discussion. But I get your point, @jorgebucaran.

This is a bug, so your creating this issue is perfectly valid, but see my point about key bindings in https://github.com/fisherman/fisherman/issues/443#issuecomment-419751882.


Fixing busted build with node v10 and refactoring and fixing busted flow spec unit tests

This allows yarn to install properly with node v10, and should also support better upwards compatibility. Also fixes build error on latest with some improperly escaped tests in flow spec. Includes refactoring flow spec unit tests to prevent tripping the refactor checker.

Hi! Sorry for the slow handling. We are trying to expand the team and pickup the pace! If you still want to help with the project, please get the latest code and resolve the conflicts. This would be much appreciated.
If you are not interested or unable to do the update, the PR will be closed 60 days from now.
👋

@knsv This pr can be closed, the 60 days are way over.

I'll go ahead and declare this one stale / expired manually to keep the PR list clean. Sorry for any inconvenience.


Default keys for cookies are not RFC standard compliant

The default key names of this plugin are ember_simple_auth:session and ember_simple_auth:session:expiration_time those are not standard compliant b/c of the colon in them.
Have a read of this gist that gives a good summary: https://gist.github.com/jeremiahlee/ff7dfb60572211dce306
This causes problems as soon as you use cookies and your backend is itself standard compliant and validates cookies or also if the backend validates the headers, one example would be hapi.js you will be denied to access those applications with an error like
{"statusCode":400,"error":"Bad Request","message":"Invalid cookie value"}

And the behavior of hapi.js is not wrong, they do deny the request right, but ember-simple-auth's default key names are wrong, so I would suggest to change those.

Hm, good point. Thought I checked when I decided on these names… Want to submit a PR?

@marcoow Can do, haven't thought about how to name them instead yet. Replace with - would be an option though.

Yeah, I'd say replacing : with - or _ should be fine (we should check which one is actually allowed though to be sure - this change is going to log all users out after the next reload).

Yes true, except for those who overwrite the default key name.
- and _ are both fine: https://tools.ietf.org/html/rfc2616#section-2.2

I guess you will also need to announce this as a probably breaking change, as the users of ember-simple-auth do need to adjust the cookie name in their backend too if they were using the default ones.

No, this doesn't change any API. The cookie is not supposed to be used directly be the backend - it's internals and name might be changed any time as it is considered private API in its entirety.
The only side effect of this change is that all users will be logged out when deploying this but I don't consider that a breaking change really as that probably happens for other reasons from time to time anyway


Clean up legacy issues in production database

Create some code to be run to correct the following issues in the production database (e.g. a management command). (And then run it.)
General Checkups

[x] Have you checked that there isn't already an existing issue that describes what you report below?
[x] Have you checked that there isn't already an open pull requests for this issue/update/change?

Description

Find all DataFile objects without a direct-sharing- source. Create a DataRequestProjectMember (not authorized/joined) for the corresponding project (if one doesn't exist), and update the source string:

fitbit → direct-sharing-102
runkeeper → direct-sharing-140
private_sharing → direct-sharing-14

For each of the PublicDataAccess objects, check if there is a corresponding DataRequestProjectMember. If there isn't one, create one (not authorized/joined).

I think these are all resolved now!


improve error message if simulator not found

if the person doesn't have the correct simulator installed, we don't have a good error message
it simply gets stuck on:
#################################################################
# npm run e2e (debug)

><EMAIL_ADDRESS>e2e /Shared/detox-new/detox/detox/test
> mocha e2e --opts ./e2e/mocha.opts "--___detoxargs___:::debug target=ios-sim"

DETOX scheme:
 { app: 'ios/build/Build/Products/Release-iphonesimulator/example.app',
  device: 'iPhone 7 Plus' }

DETOX fbsimctl "iPhone 7 Plus" list:

and indeed when I run fbsimctl "iPhone 7 Plus" list I get an empty list

and indeed when I run fbsimctl "iPhone 7 Plus" list I get an empty list
How can that be? Xcode 7?

As a future dev, we should be actually creating a sim for the duration of the test, and then deleting it. So we get a unique ID for each test.

How fast is creating a new simulator @LeoNatan ?

Shouldn't be much more than booting for the first time. Perhaps this should be a flag of the CLI tool.

isn't the first launch of a new simulator very slow? it shows that progress indicator

Yes, but on Travis we already see that anyway due to spinning a VM image.

@LeoNatan btw, regarding empty list of "iPhone 7 Plus", I do have iPhone 7 Plus installed. It looks like a bug for fbsimctl that doesn't parse the versions of the new simulators correctly:
...
CBCF2790-13B9-43D3-901E-82C305FDAF14 | iPhone 6 Plus | Shutdown | iPhone 6 Plus | iOS 9.2
719B3D6B-0B97-49A6-879B-5FF142DA7664 | iPhone 6 | Booted | iPhone 6 | iOS 9.2
3BB074C0-BA8E-4294-88F0-5DECE19BD5D0 | iPhone 5s | Shutdown | iPhone 5s | iOS 9.2
25E85F46-F63A-4EE9-A068-ACEADF1A1B80 | iPhone 5 | Shutdown | iPhone 5 | iOS 9.2
1265FBD5-E967-4C9F-908E-B82DF221520C | iPhone 4s | Shutdown | iPhone 4s | iOS 9.2
0B92ADCC-E034-41E5-ACF1-B5723AD0AE16 | iPad Retina | Shutdown | iPad Retina | iOS 8.3
304D8649-CCB3-4AC1-B33B-2D4D0D215B0E | iPad Air | Shutdown | iPad Air | iOS 8.3
7C6B427D-2A55-4883-B1D3-9E5E7BC70B42 | iPad 2 | Shutdown | iPad 2 | iOS 8.3
2860F2B5-C5F0-4EAA-8EE3-038763919D0F | iPhone 6 Plus | Shutdown | iPhone 6 Plus | iOS 8.3
5989C669-D3E5-421B-8390-BDA3FEAD8519 | iPhone 6 | Shutdown | iPhone 6 | iOS 8.3
CEDA9709-B0A5-442A-AB37-4C9F07FD0D4B | iPhone 5s | Shutdown | iPhone 5s | iOS 8.3
3599298F-9D9D-4944-8045-E4109A53A293 | iPhone 5 | Shutdown | iPhone 5 | iOS 8.3
FA56C1C3-C719-457D-B07A-316981A7EBD1 | iPhone 4s | Shutdown | iPhone 4s | iOS 8.3
09B0E0FA-DAE9-4ABC-84BD-BE3B7A678BBC | Apple Watch Series 2 - 42mm | Shutdown | Apple Watch Series 2 - 42mm | watchOS 3.1
3A140DC5-AE15-41C9-9593-D3C2D0D449FC | Apple Watch Series 2 - 38mm | Shutdown | Apple Watch Series 2 - 38mm | watchOS 3.1
2D0D818E-E2CE-4AEA-84AA-C16A25CA38E5 | Apple Watch - 42mm | Shutdown | Apple Watch - 42mm | watchOS 3.1
CEC4C04B-210A-43CD-9456-CD801367AA63 | Apple Watch - 38mm | Shutdown | Apple Watch - 38mm | watchOS 3.1
F854E393-0095-44B3-86AE-F1754DE9B61C | iPhone SE | Shutdown |
F0018338-049D-46B5-83F4-DCFD35E7D2A4 | iPad Retina | Shutdown |
C74773E0-4CB2-4D05-AAA4-999B1C977BA0 | iPhone 5 | Shutdown |
B25E84B6-0206-4159-B691-953F9D438FCB | iPad Pro (12.9 inch) | Shutdown |
A99A990E-3B37-4CA9-BFBB-A532C2F824F1 | iPhone 7 | Shutdown |
8FA1917D-F4DD-4322-B748-043F68D9A900 | iPad Pro (9.7 inch) | Shutdown |
7FBE9401-4621-4ED3-9B38-C1E7B3477243 | iPhone 6s Plus | Shutdown |
77F7E81C-68FC-413F-A1E9-271A8E7F5F93 | iPhone 5s | Shutdown |
70CDEF29-9D9E-48A7-AB44-B625A7E0DFA5 | iPhone 6s | Shutdown |
5AB96D46-A236-4B06-BDA6-91FE5FF4527A | iPad Air | Shutdown |
52A48EF2-25CC-4EB2-B7FE-0597DE00007A | iPhone 6 Plus | Shutdown |
42EC4C3A-39EE-47C9-9535-3844F2D61589 | iPad Air 2 | Shutdown |
3C9698CA-7623-4B00-84DF-E5548EB2C8D8 | iPhone 6 | Shutdown |
13B201CB-A692-4FEC-9EAE-6C898834EA50 | iPhone 7 Plus | Shutdown |

This was handled in the new implementation of detox's fbsimctl wrapper.

Better parsing
Better handling of edge cases
Much better logging

Closing the issue.