Unable to get websockets (wss) working

There isnt much documentation around getting Websockets to work from an injected sidecar. I came across this working example https://github.com/istio/istio/tree/master/samples/websockets but the same rules don't work in my case.
I have a Slack bot that uses websockets using Spring's WebSocketConnectionManager however I keep getting,
2018-10-05 01:41:12.178 ERROR [customer-invitation-service,,,] 1 --- [cTaskExecutor-1] o.s.w.s.c.WebSocketConnectionManager     : Failed to connect

java.nio.channels.ClosedChannelException: null
	at io.undertow.protocols.ssl.SslConduit.write(SslConduit.java:369)
	at org.xnio.conduits.ConduitStreamSinkChannel.write(ConduitStreamSinkChannel.java:150)
	at org.xnio.http.HttpUpgrade$HttpUpgradeState$StringWriteListener.handleEvent(HttpUpgrade.java:385)
	at org.xnio.http.HttpUpgrade$HttpUpgradeState$StringWriteListener.handleEvent(HttpUpgrade.java:372)
	at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
	at org.xnio.conduits.WriteReadyHandler$ChannelListenerHandler.writeReady(WriteReadyHandler.java:65)
	at io.undertow.protocols.ssl.SslConduit$SslWriteReadyHandler.writeReady(SslConduit.java:1260)
	at io.undertow.protocols.ssl.SslConduit$3.run(SslConduit.java:275)
	at org.xnio.nio.WorkerThread.safeRun(WorkerThread.java:582)
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:466)

Works flawlessly without the sidecar.
My rules are given below,
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: app-gateway
spec:
  # Using Istio default ingress gateway implementation
  selector:
    istio: ingressgateway
  servers:
  - port:
      name: http
      number: 80
      protocol: HTTP
    hosts:
    - "*"
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: app-test-virtual-service
spec:
  hosts:
  - "*"
  gateways:
  - app-gateway
  http:
  - match:
    - uri:
        prefix: /
    route:
    - destination:
        host: app-test
        port:
          number: 8080
      weight: 100
    websocketUpgrade: true

As i forgot to mention the websocket address its wss://cerberus-xxxx.lb.slack-msgs.com/websocket/...

/cc @ymesika
Im cc'n you since you worked on the websocket example and PRs. It will be nice to have some documentation around websockets specially around traffic management. I bet I can't be the only person trying to tackle the websockets in the Istio world.
I have fixed this specific issue by adding the following set of rules. My use case was ofcourse completely different to the example as the websocket upgrade DOES NOT initiate from an ingress.
I have mTLS enabled in my mesh. Hence the following.
cat <<EOF | kubectl apply -n apps -f -
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: slack-serviceentry
spec:
  hosts:
  - cerberus-xxxx.lb.slack-msgs.com
  ports:
  - name: https
    number: 443
    protocol: HTTPS
  resolution: DNS
---
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: slack-gateway
spec:
  selector:
    istio: egressgateway
  servers:
  - port:
      name: https
      number: 443
      protocol: HTTPS
    hosts:
    - cerberus-xxxx.lb.slack-msgs.com
    tls:
      mode: MUTUAL
      serverCertificate: /etc/certs/cert-chain.pem
      privateKey: /etc/certs/key.pem
      caCertificates: /etc/certs/root-cert.pem
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: slack-destination-rule
spec:
  host: is-egressgateway.control.svc.cluster.local
  subsets:
  - name: slack
    trafficPolicy:
      loadBalancer:
        simple: ROUND_ROBIN
      portLevelSettings:
      - port:
          number: 443
        tls:
          mode: ISTIO_MUTUAL
          sni: cerberus-xxxx.lb.slack-msgs.com
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: slack-virtual-service
spec:
  hosts:
  - cerberus-xxxx.lb.slack-msgs.com
  gateways:
  - slack-gateway
  - mesh
  http:
  - match:
    - gateways:
      - mesh
      port: 443
    route:
    - destination:
        host: is-egressgateway.control.svc.cluster.local
        subset: slack
        port:
          number: 443
      weight: 100
  - match:
    - gateways:
      - slack-gateway
      port: 443
    route:
    - destination:
        host: cerberus-xxxx.lb.slack-msgs.com
        port:
          number: 443
      weight: 100
    websocketUpgrade: true
EOF

Thanks @nixgadget for documenting this.
I will add this information to the sample readme.

@markmarijnissen Did you find the solution?

No, I stopped using istio and am using Traefik instead. (As I needed an
edge router more than I needed to control the entire service mesh)


K8s API Object usage within Statically Rendered Helm Charts

Render all helm charts and generate k8s Kind usage.
This will give us an idea for stable charts:
How many need PVCs, use beta/alpha objects etc

Issue Closed: Stale / Clean-up


Use database_version in PostgreSQLAdapter when available.

https://github.com/rails/rails/commit/1c6e508ade793b5f2676e9218ab2f4cc9474f9ce#diff-cc31fc1dd1e78db64638200f710b2f59L427 removes postgresql_version method in favor of database_version.
My change selects the one available.
I have filled in also rails pull request to fix this on their side - https://github.com/rails/rails/pull/35907. Let's wait unless that one is decided.

ok https://github.com/rails/rails/pull/35907 was merged (in https://github.com/rails/rails/pull/35909). closing


[Web] Emojis broken on CanvasKit backend

Steps to Reproduce

Browser: Chrome
OS: Windows

Add textfield to app
Run app with canvaskit backend using flutter run -d chrome --dart-define=FLUTTER_WEB_USE_SKIA=true --release
Try to enter an emoji using the keyboard (on Windows press Windows Key + .)

Expected results:
Expect to see emoji in text field.
Actual results:
A box shows up.

Logs

[√] Flutter (Channel master, v1.18.1-pre.1, on Microsoft Windows [Version 10.0.18363.720], locale en-CA)
    • Flutter version 1.18.1-pre.1 at D:\flutter
    • Framework revision a2e6c30b44 (5 days ago), 2020-04-03 20:26:01 -0700
    • Engine revision 09bc1fc45e
    • Dart version 2.8.0 (build 2.8.0-dev.19.0 e736495eb7)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\kusay\AppData\Local\Android\Sdk
    • Platform android-28, build-tools 28.0.3
    • ANDROID_SDK_ROOT = C:\Users\kusay\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Professional 2019 16.3.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional
    • Visual Studio Professional 2019 version 16.3.29424.173

[!] Android Studio (version 3.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[√] VS Code, 64-bit edition (version 1.43.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.9.1

[√] Connected device (3 available)
    • Windows    • Windows    • windows-x64    • Microsoft Windows [Version 10.0.18363.720]
    • Chrome     • chrome     • web-javascript • Google Chrome 80.0.3987.163
    • Web Server • web-server • web-javascript • Flutter Tools

! Doctor found issues in 1 category.

This issue also occurs on MacOS when using ctrl + cmd + space and entering an emoji
Code Sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: TextField(
            decoration: InputDecoration(
              border: OutlineInputBorder(),
              labelText: 'TEXT',
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.4 19E266, locale en-GB)
    • Flutter version 1.18.0 at /Users/taha/Code/flutter_dev
    • Framework revision 8f7327f83a (2 days ago), 2020-04-06 22:11:01 -0400
    • Engine revision 49891e0653
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 1210d27678)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.0.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.44.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (3 available)
    • macOS      • macOS      • darwin-x64     • Mac OS X 10.15.4 19E266
    • Chrome     • chrome     • web-javascript • Google Chrome 81.0.4044.92
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

This might be a duplicate of https://github.com/flutter/flutter/issues/53897

/cc @hterkelsen

For the record, emojis are rendered correctly without the '--release' flag.

@jyardin as far as I understand without the --release flag CanvasKit is not used at all, it only works in release mode. That's why all the other bugs (Images from network etc.) also don't happen without release flag.
Hope Emojis get fixed in CanvasKit as I found workarounds for all other issues and love the better rendering performance of CanvasKit

For me using the --release FLUTTER_WEB_USE_EXPERIMENTAL_CANVAS_TEXT=true flag fixed some text issues, like multi line Text widgets and also displays emoijs correctly.
So perhaps this could be a temporary fix, see:https://github.com/flutter/flutter/issues/33523

Reproducible on the dev 1.21.0-9.0.pre

flutter doctor -v
[✓] Flutter (Channel dev, 1.21.0-9.0.pre, on macOS 11.0 20A5343i, locale
    zh-Hans-CN)
    • Flutter version 1.21.0-9.0.pre at /Users/angus/flutter
    • Framework revision 7c6f9dd239 (11 days ago), 2020-08-09 10:31:03 -0400
    • Engine revision 6d86e67f04
    • Dart version 2.10.0 (build 2.10.0-4.0.dev<PHONE_NUMBER>)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/angus/Library/Android/sdk
    • Platform android-R, build-tools 29.0.2
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.0.beta.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 43.0.3
    • Dart plugin version 193.6015.53

[✓] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.13.2

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • macOS 11.0 20A5343i
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      84.0.4147.125

Deduplicating with https://github.com/flutter/flutter/issues/53897

@yjbanov I think closing this issue in favor of #53897 technically makes sense and it is also beneficial for maintaining the issues.
Still, I think that it would make sense to rename / edit the other issue to mention emojis as it seems like there are more people finding the emoji issue than the other issue and that does not even mention emojis.


fix(form-field): updated form-field-prefix-suffix password icon

The password icon must represents the current input state:

When the input is in hidden state (i.e. the password input is a password input and the chars are hidden), the password icon must be visibility_off;
When the input is in visible text state (i.e. the password input is a text input and the chars are shown), the password icon must be visibility.

This is according to the Material rules (see https://material.io/design/components/text-fields.html#outlined-text-field)

Commit message fix-up:
docs(form-field): invert "visibility" icon for password example

Based on  https://material.io/design/components/text-fields.html#outlined-text-field


chore: bump k8s dependencies to v1.25.3

Signed-off-by: Sertac Ozercan<EMAIL_ADDRESS>What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #
Special notes for your reviewer:

@pmengelbert @ashnamehrotra can i get a review on this?

Codecov Report

Merging #433 (5b8252b) into main (0c39e66) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   13.29%   13.29%
=======================================
  Files          12       12
  Lines        1301     1301
=======================================
  Hits          173      173
  Misses       1110     1110
  Partials       18       18

Flag
Coverage Δ

unittests
13.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Conflicting declarations error for multi variant Android module

Describe the bug
I have multiple variants in my android lib module. so the code below tries to include all generated files and creates conflict when I switch to a different variant (causing multiple identical generated module classes).
    libraryVariants.all { variant ->
        variant.sourceSets.java.each {
            it.srcDirs += "build/generated/ksp/${variant.name}/kotlin"
        }
    }

To Reproduce
Steps to reproduce the behavior:

Have an Android library module with multiple build variants.
Trigger module generation for a variant. (make the project)
Switch to a different variant.
Retrigger module generation again. (make the project again)
You will see "Conflicting declarations..." error.

Expected behavior
The source dirs for a particular variant should only care about its own generated files, not the ones for other variants.
Koin project used and used version (please complete the following information):
koin 3.2, annotations 1.0.0-beta-2

while changing variant, you need to clean your generated files. Did you tried?
applicationVariants.all { variant ->
        variant.sourceSets.java.each {
            it.srcDirs += "build/generated/ksp/${variant.name}/kotlin"
        }
    }

why is cleaning necessary? isn't src dir for every variant different? why does the compiler think there is a conflict?

This #39 worked for me


Fix test msvc-abi-return-indirect-trivial-record.swift for windows aarch64

The test msvc-abi-return-indirect-trivial-record.swift fails on windows aarch64 because the type of the third argument of @"??YLoadableIntWrapper@@QEAA?AU0@U0@@Z"
(@LoadableIntWrapper::operator+=(LoadableIntWrapper)) is i64 which differs from i32 for x86_64. Accommodate this as this is how Clang generates code. See https://godbolt.org/z/G76aMr5M9. Split the test per architecture.

@swift-ci Please test

Can we not use a conditional on the architecture for the check rather than duplicating the entire test?

Can we not use a conditional on the architecture for the check rather than duplicating the entire test? (i.e. CHECK-x86_64 and CHECK-aarch64)

Done. PTAL

@swift-ci please test

@swift-ci please test Linux platform

@swift-ci please test macOS platform


Directly turn off the camera or mute the microphone in conference app.

Provide a description of the new feature / enhancement
The intended behavior would be instead of setting the camera to be a specific image or muting the microphone in the system settings, it would mute your microphone or turn off your camera in the conference app itself.
This would be used when you want your microphone or camera to actually be off instead of having it muted in the settings and having the status of the microphone or camera in the conference app stay on. This is on v0.36.0

muting the mic via VCM should mute the app as well.  I know this is the case for Teams.
Muting the camera is different / hard / impossible.  The app controls that experience for muting the video which is why we had to go the route we did for a virtual camera.  If we didn't, we'd have to know / test every app and version to be sure however we're supposed to hook in, we did.  This also goes for things like web based experiences as well.
It is near impossible to keep up-to-date and validated


Placeholder translatable and minor improvements for NL translation

See #666

Crap. Just noticed that the nl.json file was reformatted. Sorry. My bad.
How do I proceed? New PR?

Should be ok now. Also a CSP warning has been fixed.

thank you so much


1st brig example in the README

blindly following the example instructions in the README with no editing provides this result because my/project is  not in the myvalues.yaml, but rather deis/empty-testbed is:
$ brig run -f brigade.js my/project
Started brigade-worker-01bxqkp639xcgkb1f72y9e4mst-master
Error: container "brigade-runner" in pod "brigade-worker-01bxqkp639xcgkb1f72y9e4mst-master" is waiting to start: ContainerCreating
Usage:
  brig run PROJECT [flags]

Flags:
  -e, --event string     The name of the event to fire (default "exec")
  -f, --file string      The JavaScript file to execute (default "./brigade.js")
  -p, --payload string   The path to a payload file

Global Flags:
      --kubeconfig string   The path to a KUBECONFIG file, overrides $KUBECONFIG.
  -n, --namespace string    The Kubernetes namespace for Brigade (default "default")
  -v, --verbose             Turn on verbose output

container "brigade-runner" in pod "brigade-worker-01bxqkp639xcgkb1f72y9e4mst-master" is waiting to start: ContainerCreating

after adjusting the run command, it works:
$ brig run -f brigade.js deis/empty-testbed
Started brigade-worker-01bxqm1dtyksf3qvthp75n0xqq-master
yarn run v1.1.0
$ node prestart.js
prestart: src/brigade.js written
$ node --no-deprecation ./dist/src/index.js
Creating PVC named brigade-worker-01bxqm1dtyksf3qvthp75n0xqq-master
Hello world!
after: default event fired
beforeExit(2): destroying storage
Destroying PVC named brigade-worker-01bxqm1dtyksf3qvthp75n0xqq-master
Done in 0.65s.

Good point. I know the README tries to make this clear with two notes in that section:

Assuming you have a project named my/project,

and

To see the names of your projects, run brig project list.

We can probably re-arrange this to make it a little clearer though for users flying through the docs.

Not probably. :-)


Module sizes

Currently all npm packages have same size in UI, while some may be 10kb and others 1mb. Can you please make modules size based on their size in bundle? It works like that in webpack-bundle-analyzer

My report look like that
Here's 5mb package

And here's 18kb side by side

Thanks for your report. This feature will be implemented in the next version.

0.7.0 has been released.

Thank you very much! Works like expected. Not sure if related, but for some reason most modules lost their gzip and parsed sizes, only stat tab works.

Also for some reason vite outputs ?worker inputs as assets instead of chunks, not sure how can that be fixed, but because of that, we don't have workers in report

@TrueCarry The summary option will only add module information at the end. Like this

I've actually meant 2 different issues.
1.
Stat page:

Parsed page:

Gzipped page:

As you see, gzipped and parsed pages are broken. I'm not sure that it's analyzer problem, maybe it's vite thing.

What I meant with ?worker. It is imported as import Worker from '../executorWorker?worker'. As you see on my screenshot from previous comment, I have ExecutorWorker.js that weights 5900kb, but it's not available in chunks list:

I've checked vite output, and worker gets bundled as 'asset', not 'chunk', not sure how can that be addressed, but I don't think there's an easy way.
I don't think both issues could be addressed without too much effort, so I just wanted to let you know about them. Thank you for your work!

In actuality, 'stat sizes' represents the size proximity to your native code (at least, that's my interpretation). However, I've observed that '?worker' does not appear in the 'parsed' or 'gzip' sizes (to be frank, there is currently no effective method to calculate this specific size). Vite is built on Rollup, where each chunk might be missing in the 'sourcemap' (resulting in the remaining chunks being merged by the analyzer). I believe switching to 'rolldown' in Vite might effectively address this issue.
As the documentation suggests, he just tries to analyze it as much as possible.

About doc, I think vite don't put right chunk into bundle context, So I'm trying to get expect behavior from vite repl

Parsed or gzip has no relation to worker. Even packages in index.js not listed there.

@TrueCarry I know, I'm planning resolve them at next version.


[BACKPORT 0.2.latest] Support for null value coalescing

Resolves #142
Description
The lack of null value coalescing is a bug in 0.2.x because it makes some metrics incorrect. We're backporting the addition of these options to correct that. This is specifically a backport of #159
Checklist

[X] I have read the contributing guide and understand what's expected of me
[X] I have signed the CLA
[X] This PR includes tests, or tests are not required/relevant for this PR
[X] I have run changie new to create a changelog entry

Seems reasonable! I assume we won't be able to deploy this until core 1.6.x is updated, correct? Or is this also backwards compatible with existing installations? Like the parser should be fine until someone tries to actually set one of these parameters, but otherwise the defaults take over? When we add support for this to MetricFlow we'll need to ensure the MF dependency specifies the associated 0.2.x as the minimum version.

So from the core side, these options don't exist in 1.6 yet. That's okay because they are optional / will get defaulted. The parser will be fine unless someone tries to specify one of these. With that said the plan in core was to backport these options to 1.6. We've done the work to support them in the upcoming 1.7 release, and I was planning on backporting it to 1.6 later this week.

Sounds good, merge when convenient!


docs: update uploadFiles to v6 API

Closes #485

Not sure if we should have a callout about old versions having a different API.

I really wish nextra supported versioned docs...

Eeeh - I think since we can't have versioning we should favor the later versions, but obviously versioning would be goated. Look into Mintlify maybe?


By-name parameters?

The signature currently is: https://github.com/tadzik/Template-Mojo/blob/master/lib/Template/Mojo.pm#L126
Can we make it so that named parameters are allowed? I can probably whip up a PR.

It'd be lovely; please whip up a PR if you can :)

Actually, I came back to using template "foo", {params...} and then  % my (%v) = $^params in the view (...i think) - works neatly. I looked at implementing this issue, but it seemed like there was a lot of flattening going on, and lost track of it.

I wonder if the upcoming GLR changes will make us require more or less flattening here :)


C# code nonce value is wrong

Hi,
C# code example where it generates nonce value is wrong.
Only DateTime.Now.Ticks is used which will return the long value but not alpha-numeric value.
Kindly update this code for nonce.
Thank you,
Sagar

Fixed in new c# example code.


[Feature] 为所有的微服务都增加doc文档（swagger），在测试模式的时候打开，有利于了解整体架构与代码调试

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Problem Description
仅仅影响日常开发工作效率，不方便查阅各个微服务提供的接口，也不方便调试
Description
增加swagger文档后，可以在测试模式看到所有服务的接口，也能够直接调试接口，带来很大的便利性
Use case
No response
solutions
增加swagger文档
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

It is very necessary, it is recommended to use English translation, including sending an email to<EMAIL_ADDRESS>for discussion, https://linkis.apache.org/zh-CN/community/how-to-email

have submit a pull request for this feature
https://github.com/apache/incubator-linkis/pull/1336


Position of Metadata interlinking component

metadata interlinking component potentially feeds back to the metadata storage, as it will augment exiting content with new (or broken) link information.


[Bug]: When running gradle sync getting the error "Could not install Gradle distribution"

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
When running gradle sync from within Android Studio I'm getting the following error:
Could not install Gradle distribution from 'https://services.gradle.org/distributions/gradle-7.5.1-bin.zip'.

Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This turned out to be a network configuration issue. The WiFi network I was using did not allow "non-web" traffic so requests from Android Studio were refused.
Switching to a non-restricted network solved the issue.


Instructions to avoid Cobra and CircleCI ignored?

Describe the bug
My answers to the prompts:
use_logrus_logging [y]: n
use_viper_config [y]:
use_cobra_cmd [y]: n
Select use_ci:
1 - travis
2 - circle
3 - none
Choose from 1, 2, 3 (1, 2, 3) [1]: 3

However I still get those packages and directories:
$ cat go.mod
module github.com/redthor/symbol-svc

require (
        github.com/sirupsen/logrus v1.4.1
        github.com/spf13/cobra v0.0.3
        github.com/spf13/viper v1.3.2
)

$ ll .circleci/
total 12
drwxrwxr-x 2 douglas douglas 4096 Jun 20 23:32 ./
drwxrwxr-x 6 douglas douglas 4096 Jun 20 23:32 ../
-rw-rw-r-- 1 douglas douglas 1429 Jun 20 23:32 config.yml

To Reproduce
Steps to reproduce the behavior:

Run cookiecutter https://github.com/lacion/cookiecutter-golang.git
Answer as above

Expected behavior
I didn't expect to have the packages/directories relating to the options I've avoided.
Desktop (please complete the following information):

OS: Ubuntu 18.04
Golang Version 1.12

Thanks

thanks for catching this one up.


An invalid password doesn't prevent setup

Then the site is in a corrupted state as the admin user is not created.

See also #250 , #191

How to debug this? Is it not about password escaping, serialization, deserialization?
I tried but can't figure out where this can happen

maybe related : https://stackoverflow.com/questions/2049502/what-characters-are-allowed-in-an-email-address


Create feature content page

[x] Create page
[x] Add description of what is being covered
[x] Add description of checks required on this content, compiled from current protocol documents
[x] Add examples covering correct and incorrect scenarios, as required to support checks
[x] Populate with schematron messages
[x] Provide explanations for how to fix schematron errors and warnings
[ ] Review house style document to ensure all requirements are covered by GitBook and schematron
[x] Review schematron messages related to this topic to ensure they are user friendly
[x] Becky approved page
[x] Melissa approved page
[x] Fred approved page
[x] James approved page
[x] Naushin approved page
[x] Share page with Exeter and invite feedback

Definition of done

[ ] Page completed
[ ] Team reviewed and approved page?
[ ] Assign Fred to update the Schematron

Just adding a thought I had here before I forget - Should we share this page with features as well?

Already planning to do so!

Perfect - I should've realised you will have already thought of that! :+1:

FYI - Adding a new test feature-bio-test-6, which is in the G Spreadsheet. I will commit it tomorrow.

@bcollins14 @naushinthomson @Melissa37 @FAtherden-eLife
First draft done! https://app.gitbook.com/@elifesciences/s/productionhowto/article-details/content/feature-content
All feedback welcome - I figure we're running it around the team before sharing with Features?
Questions -

Do we need something explicit linking to the figures page re illustrations? All the warnings will point there rather than here, I think.

I didn't include any specific XML at the end, I've just dotted it through where it was needed for the schematron. Should I summarise at the end for educational purposes? E.g. include XML for sub-display channel, template type etc?

Have I sufficiently covered publication issues for features? I figure that we'll have a full publishing page that I can link to at some point.

How to handle the different types of Feature content
first line - F should be f to follow the rest of the document?

Can we lower case references to Production and Feature content throughout?
Personal preference :-)

Editorial - an editorial piece written by one or more of eLife's deputy or senior editors, or the editor-in-chief, usually addressing a specific issue or development in the scientific community in general and/or at eLife in particular.

I thought these were only written by eLife staff or editor-in-chief

Magazine templates

Can we link to the templates on the googledrive? So people can look at the full template if they want?

Title prefix - a brief category label displayed in front of the title, currently captured in the XML as a 'sub-display-channel' subject element. The text should be in title case.

Add this is not a pre-defined list of terms.

Feature content is submitted to eLife via two paths: articles arriving through the the normal submission process and articles commissioned or invited by the Feature team.

Double 'the'

Feature content is submitted to eLife via two paths: articles arriving through the the normal submission process and articles commissioned or invited by the Feature team.

Suggest change to:

Feature content is submitted to eLife via one of two paths: the article arriving through the normal submission process OR the article is commissioned or invited by the Feature team.

and will likely have decision and response sections as a result.

Suggest change to:

and will likely have a decision letter and author response as a result.

The article file will be renamed to indicate which template should be used and the any figure files

remove the from in front of any

Feature content should be processed as soon as possible after export (within 24 hours for Insights, Editorials and Template 3/4 content, within 48 hours for Template 5 content).

48 hours for feature 5? I did not know this! I need to add it to the agreements with Exeter. Can you confirm this is what Peter said? Thanks :-)

In very rare cases where copy-editing is required, the Features team will advise the Production team who will request that the article is moved into the copy-editing workflow.

add a comma in front of who

The author's name should be given in bold and the bio should not end in a full-stop.

Suggested change:

In the author bio the author's name should be bold and the bio should not end in a full-stop.

Once author proofing is complete, the article will move into the 'Feature Review' stage to allow the Features team to check over the authors' edits. They will be alerted with an email notification when this occurs.

Can we suggest features team accepts the author changes? It makes sense and is more efficient

If the authors have requested an additional proof, the article should be sent back to them following the normal procedure (signing the article off to Author review for a second time).

If the author makes more changes do we pass to Features to check? Should we always have a second post-author stage for Features too?

Insight articles should be published alongside the research content to which they are related. Usually, the typeset version of record for this content will be ready by the time the Insight has gone through proofing. In the event that the research content is not ready for VoR publication and it has not been published as an accepted manuscript, the Insight should be held until the related article is ready. If the article has been published on acceptance (PoA), the Features team should be contacted to ask if the related Insight should be held until the VoR is ready. They may decide to go ahead with publication of the Insight as it will be linked to the PoA version of the research content.

Need to also mention the need to contact the author to ensure they are ready to hold publication until the Insight is ready

Error: bio must contain a bold element which contains the name of the author - XXXXXX.

Chane to>Error: bio must contain a bold element that contains the name of the author - XXXXXX.

Action: Only bold formatting () elements are allowed within an author's bio. Any other formatting and any hyperlinks should be removed. The message will indicate which disallowed elements are present and the text of the affected bio will be included at the end.

Not allowing hyperlinks in an author bio - is that a Continuum or Kriya issue? Presumably, this should be acceptable?

This elements (e.g. formatting, bold, italics) should be removed

Either this element or these elements

Action: This error indicates the template type in the XML (see above) is not 1, 2, 3, 4 or 5. Correct the template type to the one indicated by the name of the article file in the export package (e.g. ). If the template number given in the article file name is a value other than 1, 2, 3, 4 or 5, the Production team should check which value the Feature team intended for the article.

Does this display in Kriya? I assumed it would have to be corrected by Exeter staff, but this is not clear from the action

feat-custom-meta-test-3	and feat-custom-meta-test-4

Same issue as above - can production staff change this?

This error indicates that zero or more than one elements of this type are present.

remove plural from element

feature-subj-test-4
Error: There is more than one sub-display-channel subjects. This is incorrect.

should be 'There are'

Nice! Thanks James :-)

Do we need something explicit linking to the figures page re illustrations? All the warnings will point there rather than here, I think.

Yes, thnk that's a good idea.

I didn't include any specific XML at the end, I've just dotted it through where it was needed for the schematron. Should I summarise at the end for educational purposes? E.g. include XML for sub-display channel, template type etc?

Would be good if just following the same model as other pages

Have I sufficiently covered publication issues for features? I figure that we'll have a full publishing page that I can link to at some point.

Yes I think so!!

feat-custom-meta-test-3 and feat-custom-meta-test-4

Same issue as above - can production staff change this?

@FAtherden-eLife can we flag this for Libero - if we have this in the XML and we can change it, does that mean the template will update automatically? I wonder :-)

Yeah good point. For MVP, I reckon we could just manually edit the XML files ourselves, but it would be nice post-MVP to do.
I've raised a ticket in the Editor repo. It would also be good to confirm this with Exeter when we're discussing integration with them.

In addition to this there are four categories of Feature article that come through the Production process:

Suggest changing to

In addition to this there are three categories of feature article that come through the production process:

In the Magazine templates table, is it worth adding which have author contributions? I think 4 and 5 do (4 is less common but I've seen it) - the rest don't (I think), or does that still need confirming with Features?

feature-bio-test-6

In the action there's an example of where this can be ignored. This example wouldn't fire this rule. It's checking that the content of the affiliations is in the bio (specifically it tokenises each affiliation by comma, and then checks that each of those tokens is present in the bio - so in the example Department of Genetics, University of Bristol, Bristol, United Kingdom, Institute of Neuroscience and so on).
I've only myself seen this when the apostrophes are slightly different in them (or similar other character differences), although I'm obviously not working on them so much anymore.

feature-bio-test-5

This is actually checking that the only child of <bio> is a <p> element. If there is a child of bio which is not a p, then it will fire.

Please can you add insight-asbtract-impact-test-1 and insight-asbtract-impact-test-2?
I will correct the typos in the ids so that they are insight-abstract-impact-test-1 and insight-abstract-impact-test-2

Do we need something explicit linking to the figures page re illustrations? All the warnings will point there rather than here, I think.

I suggest it should probably go the other way - from the figures page to the Features page.

I didn't include any specific XML at the end, I've just dotted it through where it was needed for the schematron. Should I summarise at the end for educational purposes? E.g. include XML for sub-display channel, template type etc?

I personally think it's fine, you've provided feature specific snippets in the relevant places which I think is sufficient.

Have I sufficiently covered publication issues for features? I figure that we'll have a full publishing page that I can link to at some point.

Suggest putting the insight paragraph before this paragraph:

Publication of feature content follows the same process as for research content. If no specific date has been requested for Editorials or Feature articles, they should be published as soon as they are ready to go.

and suggest the following edit:

Publication of other feature content follows the same process as for research content. If no specific date has been requested for Editorials or Feature articles, they should be published as soon as they are ready to go.

Is it worth just summarising the workflow steps for feature content at the beginning of the 'Production process for feature content' section? Maybe just a bulleted list?

Is it worth including disp-subj-value-test-6 here? Or should we save that for a different page?

Similarly back-test-7 is a test which will only fire in feature content. Is it worth including here or in a separate page?

That's it from me - thanks for this James!

This content is overseen by the Features team and consists in part of blogposts and podcasts that do not required Production intervention to publish.

change to

This content is overseen by the Features team and consists in part of blogposts and podcasts that do not require Production intervention to publish.

I don't think I have anything else to add! Thanks James!

Please also add the newly added test final-feat-ok-test. (there's a separate equivalent for digests which should presumably go in that page).

In the key box info, where you say 'This content is not currently displayed online.', is it worth mentioning that instead we include the related article to the right hand of the webpage?

Sometimes Features will send their corrections via slack in addition to emails so would be good to mention this.

In the publication section, could we talk about the press side of things? That Peter will give Emily the date that the Insight should be ready and that if the Insight isn't ready, that the press publication is prioritised.

Otherwise, looks good. Thanks James :)

Is it worth including disp-subj-value-test-6 here? Or should we save that for a different page?

I think I'd prefer to cover this on an article types page. I assume we are going to have one?

Please also add the newly added test final-feat-ok-test. (there's a separate equivalent for digests which should presumably go in that page).

Done - do we need to convert these into author queries are pub check?

Insight articles should be published alongside the research content to which they are related. Usually, the typeset version of record for this content will be ready by the time the Insight has gone through proofing. In the event that the research content is not ready for VoR publication and it has not been published as an accepted manuscript, the Insight should be held until the related article is ready. If the article has been published on acceptance (PoA), the Features team should be contacted to ask if the related Insight should be held until the VoR is ready. They may decide to go ahead with publication of the Insight as it will be linked to the PoA version of the research content.

Need to also mention the need to contact the author to ensure they are ready to hold publication until the Insight is ready

Or does that need to go on a publication page, since that's about holding the research content?

In the publication section, could we talk about the press side of things? That Peter will give Emily the date that the Insight should be ready and that if the Insight isn't ready, that the press publication is prioritised.

Again, I think this needs to go on a publication page.

feature-subj-test-4
Error: There is more than one sub-display-channel subjects. This is incorrect.

should be 'There are'

I've fixed this - @FAtherden-eLife, did this get corrected in the actual schematron?

Editorial - an editorial piece written by one or more of eLife's deputy or senior editors, or the editor-in-chief, usually addressing a specific issue or development in the scientific community in general and/or at eLife in particular.

I thought these were only written by eLife staff or editor-in-chief

We have had them from other editors in the past.

feature-subj-test-4
Error: There is more than one sub-display-channel subjects. This is incorrect.

should be 'There are'

I've fixed this - @FAtherden-eLife, did this get corrected in the actual schematron?

I've changed this to:

There is more than one sub-display-channel subject. This is incorrect.

in the Schematron and GitBook.

Notes for a meeting with Features:

Ask Features about converting [OK] to author queries?
Ask Features about contributions vs templates
Ask Features about how they want to handle second proofs

I'm still waiting for a wider discussion with Features about what's allowed in each template but in the meantime, I've shared this with Exeter since I don't anticipate the actual schematron rules will change much (except insofar as we'll update them in response to any template changes).

I'm still waiting for a wider discussion with Features about what's allowed in each template but in the meantime, I've shared this with Exeter since I don't anticipate the actual schematron rules will change much (except insofar as we'll update them in response to any template changes).

insight-abstract-impact-test-1 and insight-abstract-impact-test-2 are also on the Impact statement page. Which should I be linking to in the Schematron?

insight-abstract-impact-test-1 and insight-abstract-impact-test-2 are also on the Impact statement page. Which should I be linking to in the Schematron?

@FAtherden-eLife Did you already update the impact statement page to remove them from there?

@FAtherden-eLife Did you already update the impact statement page to remove them from there?

@JGilbert-eLife, no I'm asking where they should be placed (impact statement page or feature page).

@JGilbert-eLife, no I'm asking where they should be placed (impact statement page or feature page).

Ah - spelling mistake on the impact statement page meant they didn't show up when I searched them. Impact statement page seems more appropriate given out treatment of other item-specific rules. I've made the required changes.

Ah - spelling mistake on the impact statement page meant they didn't show up when I searched them. Impact statement page seems more appropriate given out treatment of other item-specific rules. I've made the required changes.

Sounds good to me - thanks.

Sounds good to me - thanks.


setting default FeatureSet to ALL in create_organization

Issue
Within the service Organizations for the operation create_organization, the docs (doc1 and doc2) state the following:

By default (or if you set the FeatureSet parameter to ALL ), the new organization is created with all features enabled and service control policies automatically enabled in the root.

As of now, not setting the FeatureSet, and therefore relying on the default value, results in a KeyError.
Summary
This PR solves this issue by setting "ALL" as the default if none is present.

Hi @ackdav, thanks for the PR. Would you mind adding a test case for this, to verify it works as expected?
Existign tests can be found here: https://github.com/spulec/moto/blob/master/tests/test_organizations/test_organizations_boto3.py

Hello @bblommers - sure, I added a little test. Wasn't quite sure how to test the proposed changes in isolation... Happy to adjust it..
By the way, make lint results in countless warnings and ends in an Error. Is that just on my machine, or is that currently expected?

By the way, make lint results in countless warnings and ends in an Error. Is that just on my machine, or is that currently expected?

That is probably an issue with your setup, maybe an issue with the versions of black/flake8/pylint that you have installed?
The linter passes in our CI: see https://github.com/spulec/moto/actions/runs/3133548981/jobs/5099910561


wip: git support and git init

Checklist

[X] I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
[X] I updated my branch with the master branch.
[ ] I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
[ ] I have added necessary documentation about the functionality in an appropriate .md file.
[X] I have appropriately commented any code I have modified

Short description of what this PR does:

Add support for git command
Add support for git "add" command
Add "init" command to create the $NOTES_DIRECTORY and init a empty git repo inside

I've thought about this for a few days, and I'm not really convinced it's a good idea.
I do see how using notes with git could be useful, but I think that either you can use git manually as normal, with no changes needed here, or notes should manage it for you automatically. Here we're in an odd middle ground, where notes doesn't help you with git, but you call git through it all the time.
I've written some thoughts on this before over here that might be of interest: https://github.com/pimterry/notes/issues/12#issuecomment-264658482.
It looks like the main benefit this provides at the moment is that it passes the notes directory as -C, so the correct working directory is used. Are there other important benefits to this?
I don't think we should add a wrapper to notes for every command that you might want to run in your notes directory. We could potentially provide a generic helper though... How would you feel about something like notes run git status? That would be a generic notes run command that runs the rest of the arguments as a command in the notes directory. Simple and works for git cases like this, but also nicely flexible for any other commands too.

Hi, thanks for review of my pull request.

I've thought about this for a few days, and I'm not really convinced it's a good idea.

Ok no problem

I do see how using notes with git could be useful, but I think that either you can use git manually as normal, with no changes needed here, or notes should manage it for you automatically. Here we're in an odd middle ground, where notes doesn't help you with git, but you call git through it all the time.
I've written some thoughts on this before over here that might be of interest: #12 (comment).

I read all now, sorry for not do it before.
Maybe i can try to implement the "autocommit" features, as describe on the comment by primis with "notes git" as primary command for this options and all remain git command.

It looks like the main benefit this provides at the moment is that it passes the notes directory as -C, so the correct working directory is used. Are there other important benefits to this?

Other benefits: the notes init part; but yeah maybe you are right about this.
I was inspired from "pass" password-manager (autocommit features is present on this app too)

I don't think we should add a wrapper to notes for every command that you might want to run in your notes directory.

Right, but git is the best option to backup your notes and share it across device, different by importance from other type of command wrapper.

We could potentially provide a generic helper though... How would you feel about something like notes run git status? That would be a generic notes run command that runs the rest of the arguments as a command in the notes directory. Simple and works for git cases like this, but also nicely flexible for any other commands too.

But how do you implement this?
Git use the "-C" option but other command may use other type of argument to point to some specific dir.
I don't like something like "cd $notes_dir and then run this".
Other thoughts: a generic run command can be data destructive and security issue.
Thanks and sorry for my bad english.

Maybe i can try to implement the "autocommit" features, as describe on the comment by primis with "notes git" as primary command for this options and all remain git command.

Autocommit would be interesting, if you'd like to have a go! It's not super easy, but I think it would be popular. Do make sure you read the other thread carefully first though, because it's important to do it well.

I don't think we should add a wrapper to notes for every command that you might want to run in your notes directory.

Right, but git is the best option to backup your notes and share it across device, different by importance from other type of command wrapper.

I don't think I agree. I don't think manually adding, committing, pushing & pulling every change to your notes files is common. Instead, most users use one of the many tools like Dropbox/Google Drive/Spider Oak/OwnCloud/etc which do automatic versioning & sync. And on the other hand, I can think of many other great use cases that a more generic run command would help with, plus it allows for lots of other new ideas that I haven't thought of.

How do you implement this?

(cd $NOTES_DIRECTORY; $COMMAND) should work nicely, I think? It changes directory, but only for that one command, not the rest of your session.

I don't like something like "cd $notes_dir and then run this".

Could you be more specific please? Why don't you like this?

Other thoughts: a generic run command can be data destructive and security issue.

I don't think this is a concern. Users have to manually run the command themselves, and it's not any more dangerous than any other command you may run on your command line. I don't think it's very different - any risky command run with notes run would also be very risky to run directly. rm -rf / is obviously dangerous to any experienced CLI user. notes run rm -rf . would be equally dangerous, but also equally obviously dangerous.


⚠ Bofrost.at has degraded performance

In a84ed37, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1990 ms

Resolved: Bofrost.at performance has improved in 7ee7f79.


jsonapi: Add getVersion response

Needed to check API compatibility in gopasspw/gopassbridge#37.
I also fixed some typos and slightly incorrect references to stdin/stdout.

@martinhoefling

Codecov Report

Merging #893 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   63.73%   63.77%   +0.03%
==========================================
  Files         170      170
  Lines        9791     9800       +9
==========================================
+ Hits         6240     6249       +9
  Misses       2771     2771
  Partials      780      780

Impacted Files
Coverage Δ

pkg/jsonapi/api.go
60% <ø> (ø)
:arrow_up:

pkg/action/jsonapi.go
4.48% <100%> (ø)
:arrow_up:

pkg/jsonapi/responses.go
75.23% <100%> (+2.23%)
:arrow_up:

pkg/jsonapi/messages.go
52.17% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2415d23...fceba30. Read the comment docs.

lgtm


Publish-NAVContainerApp error : A drive with the name 'C' does not exist

Environment is hosted from bcsandboxazure using latest-w1 build.
Upon running the Publish-NAVContainerApp and putting in the .app path file, hitting this error.

When checking in NAV server powershell, i'm able to access c:\run.

What is the full command you are running?

      What is the full command you are running?

When you are supplying values as input, you shouldn't supply the '
you only supply that when supplying values on the cmdline

      When you are supplying values as input, you shouldn't supply the '

you only supply that when supplying values on the cmdline

Works now. My mistake. Closing the issue and appreciate the help Freddy.


Issue with Snowflake on Android 11+

https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40278

We need an update IPtProxy with latest fix merged as indicated on the ticket above please!

Fixed with 6963a3a6bd001c2f72f8a551199937d1baf83c04.
Already uploaded to Sonatype.
Will appear there soon.


Fix update dispatch

Something needs to be done with this part of ReceiveAsync method because it can throw NullReferenceException on the first run and also it can also repeatedly dispatch the same updates more than once if GetUpdatesAsync throws and updates variable already contains updates from previous iteration.
https://github.com/TelegramBots/Telegram.Bot/blob/44b36f294945035c80b2b22c5a0ec24d4d5186d1/src/Telegram.Bot/TelegramBotClient.cs#L323-L327

I think it could be solved with something like that:
enum PollingState
{
    Success,
    Fail
}

private async void ReceiveAsync(
    UpdateType[] allowedUpdates,
    CancellationToken cancellationToken = default)
{
    IsReceiving = true;
    var pollingState = PollingState.Success;

    while (!cancellationToken.IsCancellationRequested)
    {
        var timeout = Convert.ToInt32(Timeout.TotalSeconds);
        Update[] updates = default;

        try
        {
            updates = await GetUpdatesAsync(
               MessageOffset,
               timeout: timeout,
               allowedUpdates: allowedUpdates,
               cancellationToken: cancellationToken
            ).ConfigureAwait(false);
        }
        catch (OperationCanceledException)
        {
            pollingState = PollingState.Fail;
        }
        catch (ApiRequestException apiException)
        {
            pollingState = PollingState.Fail;
            OnReceiveError?.Invoke(this, apiException);
        }
        catch (Exception generalException)
        {
            pollingState = PollingState.Fail;
            OnReceiveGeneralError?.Invoke(this, generalException);
        }

        if (pollingState == PollingState.Success &&
            updates != null)
        {
            foreach (var update in updates)
            {
                OnUpdateReceived(new UpdateEventArgs(update));
                MessageOffset = update.Id + 1;
            }
        }
    }

    IsReceiving = false;
}

Also with dispatching placed out of try/catch IsReceiving property is no more guaranteed to reflect actual state of polling loop. I suggest make this prop obsolete because if user code throws the entire process will stop.


Introduce helper class to aid indexing various content and data in Umbraco

This is now implemented via the new IndexingHelper class, which is also available via dependency injection.
The purpose of the class is that developers can get a textual representation of a given object. The entry point is via one of the GetSearchableText methods:

GetSearchableText(IPublishedElement)
GetSearchableText(BlockListModel)
GetSearchableText(JToken)

Internally the class also has several public and non-public methods:

WriteElement(TextWriter, IPublishedElement)
WriteProperty(TextWriter, IPublishedElement, IPublishedProperty)
WriteBlockList(TextWriter, BlockListModel)
WriteJsonToken(TextWriter, JToken)
WriteJsonObject(TextWriter, JObject)
WriteJsonArray(TextWriter, JArray)
WriteString(TextWriter, string)
WriteValue(TextWriter, object)

All methods are marked as virtual, so individual method can be overriden in a custom class like:
public class MyIndexingHelper : IndexingHelper {

    public override void WriteValue(TextWriter writer, object value) {

        switch (value) {

            case BorgerDkPublishedArticle article:
                writer.WriteLine(article.Title);
                break;

            default:
                base.WriteValue(writer, value);
                break;

        }

    }

}


Bootstrap error: Failed to execute write on Document (...) an asynchronously-loaded external script

OpenUI5 version: All NPM versions
Browser/version (+device/version): Chrome, Edge, Firefox, IE
Any other tested browsers/devices(OK/FAIL): FAIL
URL (minimal example if possible):
https://github.com/mauriciolauffer/openui5-sample-app/blob/doc-write-issue/webapp/index.html
Steps to reproduce the problem:

Open a terminal;
$ git clone https://github.com/mauriciolauffer/openui5-sample-app.git
$ git checkout doc-write-issue
$ npm install
$ npm start
Open http://localhost:8080/index.html
Open DevTools (F12)
Check browser consoles for errors

What is the expected result?
UI5 bootstrap loaded successfully.
What happens instead?
It does not load, there is an error.
Failed to execute 'write' on 'Document': It isn't possible to write into a document from an asynchronously-loaded external script unless it is explicitly opened.
The error only happens when using async defer: script async defer id="sap-ui-bootstrap"
Any other information? (attach screenshot if possible)
The error happens in sap-ui-core.js file due to statement document.write in lines 44, 48 and 52.

Hi @mauriciolauffer ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Best Regards,
Florian
Note:
Don't forget to switch the branch with git checkout doc-write-issue to start the app with the adjustments.

This is not a final answer, but rather a comment:
The development version of sap-ui-core.js can only be used within the head of a document. It is not intended for other scenarios. The problem is with the long-established sync contract of the bootstrap script. To make it work within the body, we could have used sync XHR and eval, but that felt even worse.
There are plans to establish an async alternative, but the feature set of it has not been agreed upon (should it guarantee the same APIs as sap-ui-core.js to make migration easy - an sap-ui-core-async.js so to say - or should it be much smaller, following the direction of UI5 evolution thinking? A prototype of the latter can be found under the name sap-ui-boot.js, but it's not a public offering.

@flovogt Thanks  👍
@codeworrior I've notice this sap-ui-boot.js a while ago, when I first got the reported error. I was wondering why it isn't being used... Thanks for the comments

This issue will be covered in backlog item CPOUI5FOUNDATION-382.


Revalidate doesn't work always with Netlify Functions

Describe the bug
I have a page which has an option revalidate: 5,. It works fine with netlify dev. However, when I deploy it and run on netlify, the serverless functions are not being triggered on refresh after 5 seconds.
I made a small test using codesanbox server and a next js site which shows the current time. The time is calculated on the server and sent to the next js app which is handled using getStaticProps. There's also a couple of routes sent via the server to getStaticPaths
To Reproduce
Steps to reproduce the behavior:

Go to Codesandbox Server (required)
Go to https://goofy-galileo-ba9249.netlify.app/
Refresh
If it works, refresh again
Time does not update after 5 seconds between refreshes

Link to Github Repo: https://github.com/saidattax/next-js-test
Expected behavior
Everytime on refresh, atleast after 5 seconds, the serverless function should trigger to get the latest getStaticProps
Versions

Next.js: 10.2.0
plugin (if installed at fixed version): 3.3.0

If you're using the CLI to build

OS: [e.g. macOS, Windows]
netlify/cli version:

If you're using file-based installation

netlify.toml:

[build]
  command = "npm run build"
  functions = "netlify/functions"
  publish = "out"

[context.production.environment]
  NEXT_SERVERLESS = "true"
  NODE_ENV = "production"

[[plugins]]
  package = "@netlify/plugin-nextjs"

@saidattax hey! thank you so much for opening such a wonderful and detailed issue. we really appreciate the time and thoughtfulness you spent. unfortunately this has been a request/known issue on the platform for nearly a year 😲 (see https://github.com/netlify/netlify-plugin-nextjs/issues/151). this is netlify's most recent work to address this issue: https://github.com/netlify/netlify-plugin-nextjs/issues/151#issuecomment-819806060. for this reason, i'll close your issue, but feel free to direct any additional comments/feedback to #151!! ❤

Hey @lindsaylevine ! Thanks for getting back. However, I have another project where I use the same revalidate and the netlify function is indeed called on every request within 5 seconds.
It can also be seen in it's function logs, that it works. next_pname
Here's the deploy id 609e5727d93f45bc37e4e932 for that project.
Any idea how it's working there but not in this one? Did I do something there that I missed here?
Thanks

@lindsaylevine
Also, a different issue I found,
In my package.json I have fixed the version of the plugin
    "devDependencies": {
        "@netlify/plugin-nextjs": "3.2.2"
    }

But in the build, it is taking the latest version? 🤔
4:28:33 PM: ❯ Installing plugins
4:28:33 PM:    -<EMAIL_ADDRESS>4:28:54 PM:
4:28:54 PM: ❯ Loading plugins
4:28:54 PM:    -<EMAIL_ADDRESS>from netlify.toml

Here's the deploy id 60a39dbfcd1460de0e4c6613
This is supposed to say<EMAIL_ADDRESS>, right?

@saidattax

i think what your describing is just SSR, aka what we do in place of ISR. if a next project has revalidate set, we simply SSR that page instead of the prerendered html.

you'd need to install it as a prod dependency, not a dev dep! i just checked our README and realized we have -D in there so lemme go replace that rn! (see https://github.com/netlify/netlify-plugin-nextjs#faq though fyi!)

ok, i see now. your site in the original issue body is not updating. this is because, i believe, you're using fallback: true, which means (as of the most recent plugin version) we cache the first function response. if you take that out, it should work as you expect.

Thank you so much for the help @lindsaylevine ! That fixes it :)

yay!! happy to help ❤ :D


feat: free users of fedimintd-lib from manually adding std modules

As a user of fedimintd-lib I just want to depend on fedimintd and add my own modules.

needs rebase


Scrape server with self signed certificate

Im unable to get apache status on a server running on a self signed certificate. Is there any way to skip this? Scraper seems to fail at this point
func (e *Exporter) Collect(ch chan<- prometheus.Metric) {
	e.mutex.Lock() // To protect metrics from concurrent collects.
	defer e.mutex.Unlock()
	if err := e.collect(ch); err != nil {
		log.Errorf("Error scraping apache: %s", err)
		e.scrapeFailures.Inc()
		e.scrapeFailures.Collect(ch)
	}
	return
}

Is there a way to skip SSL validation?

Hi @Preston1299
Did you try the -insecure flag?
./apache_exporter -insecure=True  ?


Ordering Client dropdown by name

Enhancement suggested by
@GauravGusain98
Is your feature request related to a problem? Please describe.
In any application, the UI should be user-friendly i.e user should not find any difficulty using different components in the application. In the portal, any user who wants to edit project details faces difficulty finding the client while changing the client from the dropdown. Currently, the client list is not ordered by name which is causing trouble, if we sort the list by client name in ascending order then it would be easier to find the client for that list.
So we want to order the client list by client name in ascending order.
To replicate the problem

Go to edit project screen

Check the client dropdown and see the client order, it is not sorted by names

Additional context
This task will improve the user experience while using the portal.
Point of Contact for Guidance
@GauravGusain98

Action Items
Basics - 1 pointer

[ ] Read about Models in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Views in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Routes in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Controller in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read about Services files in Laravel. Share your understanding of why we use them in the task comment in your own language
[ ] Read how we can print a value in Laravel using dd()
[ ] Try printing hello world using the dd function
[ ] On the project details page print details of the project using dd function
[ ] Read about HTML forms and how we submit forms. Also, share the use of the below provide items

[ ] Action attribute in the form
[ ] Method attribute in the form
[ ] Name attribute in any HTML tag and its importance while form submission

Sorting - 1 pointer

[ ] Figure out the function from where we are fetching the client's details/name and passing them to frontend
[ ] Read about Laravel queries and some basic queries like

[ ] Running Database Queries
[ ] Basic Where Clauses
[ ] Select Statements
[ ] Ordering, Grouping, Limit & Offset

[ ] Now try to update the query that is used to fetch client details in a way that is to order the client's result by client name in ascending order.
[ ] Raise PR and assign it for reveiw

Models-models are used to connect or interact  with database. To create model we use command :php artisan make:model ModelName.we use models to manage and manipulate data.
Views- we put our html part into view or whatever we want to show to user .View templates usually written using the blade templating language.
Routes-It is used for mapping our laravel page with specific url, it  also  used to map to controller actions for creating, updating, and deleting records.
Controller- It is central unit of any mvc architecture,all logical part are done in this part .It fetches the data from model and view
service files-service files are  used to centralize application logic and make it easier to maintain, test and debug. They allow us to organize our code into logical groups, making it easier to read, understand.

Models-models are used to connect or interact with database. To create model we use command :php artisan make:model ModelName.we use models to manage and manipulate data.
Views- we put our html part into view or whatever we want to show to user .View templates usually written using the blade templating language.
Routes-It is used for mapping our laravel page with specific url, it also used to map to controller actions for creating, updating, and deleting records.
Controller- It is central unit of any mvc architecture,all logical part are done in this part .It fetches the data from model and view
service files-service files are used to centralize application logic and make it easier to maintain, test and debug. They allow us to organize our code into logical groups, making it easier to read, understand.

The motive of putting updates in your own language is that we can get to know what you understand from these topics and if there is anything that needs to be corrected. But most of your updates are definitions that we can get from the internet. Hope you understood the concept as these things will be used quite frequently ahead.


Extract systemvm.iso using bsdtar if available.

Signed-off-by: Kai Takahashi<EMAIL_ADDRESS>Description

Extract systemvm.iso using bsdtar in injectkeys.sh if available.
With bsdtar, injectkeys.sh doesn't need to mount systemvm.iso and works even on unprivileged containers.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

Checked that a new key is injected to systemvm.iso by running injectkeys.sh manually.

@cl-k-takahashi how about we add bsdtar as the dependency for both debian/rpm packages? That way we can enforce CloudStack to use bsdtar?

@cl-k-takahashi how about we add bsdtar as the dependency for both debian/rpm packages? That way we can enforce CloudStack to use bsdtar?

@rhtyd I agree. Should I remove all 'mount' command calls from injectkeys.sh?

While bsdtar is available in Ubuntu and CentOS 7 official repository, it's in EPEL in CentOS 6.

I added bsdtar as the dependency for rpm(CentOS7)/debian packages.
The cloud.spec for CentOS 6 is untouched.

@cl-k-takahashi I've moved the milestone to 4.14, in which we'll remove support for CentOS6 (reference https://markmail.org/message/eenfpyya2wfgd2gw), then your PR will be acceptable. Thanks.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-271

Solved a conflict: A dependency removed from debian/control: python-netaddr was removed from the debian dependency in master branch.

@blueorangutan package

@cl-k-takahashi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-298

@blueorangutan test centos7 vmware-65u2

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Trillian test result (tid-389)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48864 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3536-t389-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_00_deploy_vm_root_resize
Failure
320.03
test_deploy_vm_root_resize.py

test_05_rvpc_multi_tiers
Failure
598.88
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
641.18
test_vpc_redundant.py

Because CentOS 6 support by CloudStack was removed, I propose removing all "mount" and "umount" command execution from the script. Do you think it's good?

If we assume that bsdtar is available as installed with the packages, then yes @cl-k-takahashi

@rhtyd I've removed them.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-346

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-374

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-434

@blueorangutan test centos7 vmware-65u2

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan test centos7 vmware-65u2

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@DaanHoogland kindly take a look if you can LGTM this one.

Trillian test result (tid-684)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50741 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3536-t684-vmware-65u2.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

code looks good, nice cleanup. It does change the logic concerning file permissions, though. The logic looks fine and *should {tm} work on all platforms ;), @andrijapanicsb. If you tested it, I'm fine with it.

Yes, manually tested by injecting custom keys manually running the same command/script and verified the modified pub key present in SSVM.

👍 master or first to 4.13?

I've tested master, but this is a change, not bugfix, so I say only master @DaanHoogland?

ok, go ahead, @andrijapanicsb ! looks good

Mergng based on 2 x reviews and manual testing and regression testing (no failures).

@cl-k-takahashi Can you please see the comments in #3800 and resubmit this? I don't think the change will be big, but it a very specific error during upgrades that needs addressing. Sorry for the invconvenience.


Don't depend on Fabric API

Spyglass doesn't use it at all, so I should remove the dependency

Closed by 775adaef4807b6c5d6b2815b4442deba4f241dbb


Fixing scanning issue of jars inside war files

Current version would not scan zip files inside zip files properly (i.e., log4j jars inside *.war files)

Do you have an example war file where it goes wrong?
I tested on the following WAR file: https://get.jenkins.io/war-stable/1.409.3/jenkins.war
python3 log4j-finder.py /tmp/war -q
[2021-12-17 00:13:52] UNKNOWN: /private/tmp/war/jenkins.war -> winstone.jar -> winstone/JNDIManager.class [fc0814d1ed17c42eee4ea62ad8646f2b: Unknown MD5]

You're right, it works on Python 3.8.5. On Python 3.6.9, the same command gives this (i.e., fails silently):
python3 log4j-finder.py jenkins.war --no-banner
[2021-12-17 01:41:05] MediaPC2 Scanning: jenkins.war
[2021-12-17 01:41:05] MediaPC2 Finished scan, elapsed time: 0.02 seconds

Summary:
 Processed 0 files and 0 directories
 Scanned 1 files

Elapsed time: 0.02 seconds

With the debug output:
2021-12-16 20:43:18,320 DEBUG <zipfile.ZipExtFile name='winstone.jar' mode='r' compress_type=deflate>: File is not a zip file

Just realized Python 3.6.9 does not work anyway with more recent changes
Traceback (most recent call last):
  File "log4j-finder.py", line 329, in <module>
    sys.exit(main())
  File "log4j-finder.py", line 304, in main
    has_lookup = zipfile.Path(zfile, lookup_path).exists()
AttributeError: module 'zipfile' has no attribute 'Path'

I'll close for now.

@dariux  Hi dariux, i fixed the zipfile.Patherror, and it should be Python 3.6 compatible again. Feel free to open the PR again if it still doesn't work for you.

Thanks, should work now. Python 3.8.5 - same output (still works).
Python 3.6.9 BEFORE:
python3 log4j-finder.py /tmp/jenkins.war --no-banner
[2021-12-17 11:24:50] PC Scanning: /tmp/jenkins.war
[2021-12-17 11:24:50] PC Finished scan, elapsed time: 0.02 seconds

Summary:
 Processed 0 files and 0 directories
 Scanned 1 files

Python 3.6.9 AFTER:
python3 log4j-finder.py /tmp/jenkins.war --no-banner
[2021-12-17 11:25:43] PC Scanning: /tmp/jenkins.war
[2021-12-17 11:25:43] PC UNKNOWN: /tmp/jenkins.war -> winstone.jar -> winstone/JNDIManager.class [fc0814d1ed17c42eee4ea62ad8646f2b: Unknown MD5]
[2021-12-17 11:25:43] MediaPC2 Finished scan, elapsed time: 0.46 seconds

Summary:
 Processed 0 files and 0 directories
 Scanned 1 files
  Found 1 unknown files

Before I merge I want to check what causes this issue. Now it loads the zip file in memory instead of a file handle, which can be problematic if it's a big file.

Made a small test case:
import zipfile

# https://get.jenkins.io/war-stable/1.409.3/jenkins.war
zfile = zipfile.ZipFile("jenkins.war")
zinfo = zfile.infolist()[1332]
print(zinfo)
zf = zfile.open(zinfo.filename)
print(zf)
test = zipfile.ZipFile(zf)
print(test)
print(len(test.infolist()))

Dockerfile for easy testing:
ARG  VERSION
FROM python:${VERSION}

RuN echo "building version ${VERSION}"
COPY jenkins.war /
COPY test.py /

CMD python3 test.py

$ docker build -t zipfile:3.6.9 --build-arg VERSION=3.6.9 .
$ docker build -t zipfile:3.6.10 --build-arg VERSION=3.6.10 .
$ docker build -t zipfile:3.7.0 --build-arg VERSION=3.7.0 .
$ docker build -t zipfile:3.7.2 --build-arg VERSION=3.7.2 .

# run using:
$ docker run -it --rm zipfile:3.6.9    # breaks
$ docker run -it --rm zipfile:3.6.10  # breaks
$ docker run -it --rm zipfile:3.7.0    # breaks
$ docker run -it --rm zipfile:3.7.2    # ok

Traced back to this issue: https://stackoverflow.com/questions/54886147/zipextfile-does-not-have-a-seek-method-in-python3-7-0
And these bugs in Python:

https://github.com/python/cpython/pull/8527
https://bugs.python.org/issue34035

So anything below 3.7.2 seems to have zipfile issues.

Yes, you were too quick for me to respond, those are the correct references. The downside is it loads individual jars into memory; the upside - does not fail scanning war files silently. Thanks!

Ideally, maybe we could check for the correct Python version via try/except; it does seem like it might slow down the scan considerably, which is avoidable for versions >= 3.7.2

Yes agreed, i have modified your patch to do just this, See #33
Best of both worlds! :)


Fix #121 removed unnecessary ucwords header name

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

Fixed issues
#121

Merged. Thanks!


Tests for the tripolar grid

Some tests for the Tripolar grid

This PR should be ready to merge, we can figure out later the reference for the change in areas

Ready to go


Unable to have travis ci run test:browser

For having a test-on-travis only run test:node and not both test:node and test:browser like test does.
I'm getting tried a couple different configurations, see travis runs 20 and 21, both generate the same error:
The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://chromedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH.

Run 20 was configured from here and Run 21 was configured from here

The chromedriver needed to be installed, which was the reason for the ChromeDriver not being found, the following was added to before_script section:

LATEST=$(wget -q -O - https://chromedriver.storage.googleapis.com/LATEST_RELEASE) ; wget http://chromedriver.storage.googleapis.com/$LATEST/chromedriver_linux64.zip
unzip chromedriver_linux64.zip && sudo ln -s $PWD/chromedriver /usr/local/bin/chromedriver

But Travis is now hanging at the end of the tests, it appears Alsatian isn't stopping see this build:
$ yarn test:node & yarn test:browser
yarn test:browser v0.17.8
yarn test:node v0.17.8
$ alsatian build/test.js --tap
$ alsatian build/test-web.js --tap
TAP version 13
1..3
# FIXTURE NopTests
ok 1 test nop type is function
ok 2 test nop return value is not defined
ok 3 test a js file can import and call nop
setupFixture:+
setupFixture: 1
setupFixture: 2
TAP version 13
1..2
setupFixture:-
# FIXTURE Browser nop tests
testWdNop:+
testWdNop: 1
testWdNop:-
ok 1 wd: nop which is defined in a TS file
testWdCallNop:+
testWdCallNop: 1
testWdCallNop:-
ok 2 wd: callNop which is defined in a JS file
teardownFixture:+
teardownFixture: 1
teardownFixture:-
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

Fixed with 77844e6103fe, spawn needed to be used instead of exec.


Automatic completion is overzealous

I'm finding that when typing in commands the autocompletion is autocorrecting my work and causing issues.  For instance:
When typing \section{Quadratic Formula} I frequently got to the Quad part and had the autocorrector change it to quad before I was able to complete the word.   It requires constant review to insure that the work hasn't been "corrected" incorrectly.

We heavily rely on autocomplete library for this feature, so we may need to investigate whether there's a simple fix for this. Btw. auto complete can be switched off completely or configured in the application settings.


Last meeting attendee count is on feedback page

not ready for merge

@zachlatta Would you please review this?

I get the following when going to http://localhost:3000 with this.
web_1 | method=GET path=/ format=html controller=pages action=root status=302 duration=7.56 view=0.00 db=0.00 location=http://localhost:3000/feedback_responses/new
web_1 | method=GET path=/feedback_responses/new format=html controller=feedback_responses action=new status=302 duration=1.36 view=0.00 db=0.00 location=http://localhost:3000/sessions/member/new
web_1 | method=GET path=/sessions/member/new format=html controller=sessions action=new status=500 error='ActionView::Template::Error: undefined method `meetings' for nil:NilClass' duration=54.63 view=0.00 db=0.62
web_1 |
web_1 | ActionView::Template::Error (undefined method `meetings' for nil:NilClass):
web_1 |     4:       = form_for feedback_response do |f|
web_1 |     5:         .modal-header
web_1 |     6:           %h4.modal-title We  Feedback
web_1 |     7:           - unless club_previous_attendee_count(@current_club) == 'N/A'
web_1 |     8:             %h5.modal-title
web_1 |     9:               Last meeting attendees:
web_1 |    10:               = club_previous_attendee_count(@current_club)
web_1 |   app/helpers/clubs_helper.rb:3:in `club_previous_attendee_count'
web_1 |   app/views/feedback_responses/_form_modal.html.haml:7:in `block in _app_views_feedback_responses__form_modal_html_haml___2261655978021091053_47283196892680'
web_1 |   app/views/feedback_responses/_form_modal.html.haml:4:in `_app_views_feedback_responses__form_modal_html_haml___2261655978021091053_47283196892680'
web_1 |   app/views/sessions/new_member.html.haml:2:in `_app_views_sessions_new_member_html_haml___1523015056656965560_47283183227660'
web_1 |   app/controllers/sessions_controller.rb:7:in `new'

I'd assume this is because views/sessions/new_leader.html.haml and
views/sessions/new_member.html.haml work because they pass empty objects into
the feedback_responses/form_modal partial (see
https://github.com/hackedu/packrat/blob/master/app/views/sessions/new_leader.html.haml#L1-L4).
Would passing in an empty club object fix this issue? What should we display for
attendance when the member is not part of a club yet?

@zachlatta I've just amended it. The div doesn't show up unless there is a current_member with a club.

Hmm, I'm not seeing the attendee count from the last meeting show up?
Here's what I see (I've also injected a web console and ran a command to show the number of attendees at the last meeting):

Any thoughts on what might be causing this? And have you tested it locally?

@zachlatta I'll check this out

Closing this because we're deprecating packrat.


Captcha correct but still not want to accept it..

Describe the bug
I am setting this up the first Time, both Addons running with no Errors, but it always fails at the Captcha
To Reproduce
Steps to reproduce the behavior:
Enter the Captcha, it will load few seconds and then it says "Only a single instance is allowed."
and this at the integration: "Warning: Captcha required - Go to Configurations page for Eufy Security Integration to enter the code"
**Hardware Information about Home Assistant
Home Assistant 2021.12.3

Thanks for this - noticed 2FA was being triggered but there was nowhere to enter the code.  Created guest account with no 2FA and set up with that and the install instructions worked perfectly.

Exactly the same issue here.
2FA was already disabled, I tried the guest account per your suggestion and some outcome "Only a single instance is allowed."
I do receive a mail with a six digit code, but no place to enter that code


Parser: allow ~ operator for complex conjugation

Question: should this be its own Tree.Tag or should it reuse .bit_not_expr?

Clang also uses UO_Not for this and we don't have a separate tag for pointer arithmetic either so I think reusing it is fine.


clarify the output blocks of the jacobian

Adds documentation for what the Jacobian blocks are when using the MFEM Tribol interface.

@srwopschall, thanks for the review.  Can you check the updated docs address your comments before I merge?


No build-dev script

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: EXACT RELEASE VERSION OR COMMIT HASH, HERE.

Live Link or JSFiddle/Codepen: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP). You can start from forking one of the templates: iOS JSFiddle/Codepen, Material JSFiddle/Codepen

What you did
EXPLAIN WHAT YOU DID, PREFERABLY WITH CODE EXAMPLES, HERE.
Expected Behavior
EXPLAIN WHAT IS TO BE EXPECTED, HERE.
Actual Behavior
EXPLAIN WHAT IS ACTUALLY HAPPENING, HERE.
P.S. Remember, an issue is not the place to ask questions. You can use Stack Overflow
for that or join the #framework7 channel on irc.freenode.net, where we will be more
than happy to help answer your questions.
Before you open an issue, please check if a similar issue already exists or has been closed before.

https://github.com/framework7io/Framework7/blob/v2/package.json#L9

[anton@user-xp Framework7]$ npm run build-dev
npm ERR! missing script: build-dev
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/anton/.npm/logs/2017-09-22T19_42_33_378Z-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'build-dev' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose stack Error: missing script: build-dev
4 verbose stack     at run (/usr/lib/node_modules/npm/lib/run-script.js:151:19)
4 verbose stack     at /usr/lib/node_modules/npm/lib/run-script.js:61:5
4 verbose stack     at /usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:114:5
4 verbose stack     at /usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:401:5
4 verbose stack     at checkBinReferences (/usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:356:45)
4 verbose stack     at final (/usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:399:3)
4 verbose stack     at then (/usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:159:5)
4 verbose stack     at /usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:347:12
4 verbose stack     at /usr/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:78:16
4 verbose stack     at tryToString (fs.js:514:3)
5 verbose cwd /home/anton/Framework7
6 verbose Linux 3.10.0-693.2.2.el7.x86_64
7 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "build-dev"
8 verbose node v8.5.0
9 verbose npm  v5.3.0
10 error missing script: build-dev
11 verbose exit [ 1, true ]

Changed package.json but still getting error on npm run build-dev
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'build-dev' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild-dev', 'build-dev', 'postbuild-dev' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/anton/Framework7/node_modules/.bin:/opt/swift/usr/bin:/home/anton/.cvm:/home/anton/.npm-global/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/usr/java/jdk1.8.0_144/bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/anton/Framework7
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'cross-env NODE_ENV=development gulp build' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec build-dev script
13 verbose stack Error<EMAIL_ADDRESS>build-dev: cross-env NODE_ENV=development gulp build
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter. (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:289:16)
13 verbose stack     at emitTwo (events.js:125:13)
13 verbose stack     at EventEmitter.emit (events.js:213:7)
13 verbose stack     at ChildProcess. (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14)
13 verbose stack     at emitTwo (events.js:125:13)
13 verbose stack     at ChildProcess.emit (events.js:213:7)
13 verbose stack     at maybeClose (internal/child_process.js:927:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /home/anton/Framework7
16 verbose Linux 3.10.0-693.2.2.el7.x86_64
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "build-dev"
18 verbose node v8.5.0
19 verbose npm  v5.3.0
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>build-dev: cross-env NODE_ENV=development gulp build
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>build-dev script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

And error on gulp build
[anton@user-xp Framework7]$ gulp build
module.js:529
throw err;
^
Error: Cannot find module 'gulp-jade'
at Function.Module._resolveFilename (module.js:527:15)
at Function.Module._load (module.js:476:23)
at Module.require (module.js:568:17)
at require (internal/module.js:11:18)
at /home/anton/Framework7/gulpfile.js:7:16
at Object. (/home/anton/Framework7/gulpfile.js:589:3)
at Module._compile (module.js:624:30)
at Object.Module._extensions..js (module.js:635:10)
at Module.load (module.js:545:32)
at tryModuleLoad (module.js:508:12)
[anton@user-xp Framework7]$

To be honest don’t understand what happens. What if you run just ‘gulp build’? Does  ‘npm run prod’ work?


Fix untrust of trusted certificate

Fixes #1950
This PR adds the certificate to the list to check only if they are untrusted.

Codecov Report
Base: 60.49% // Head: 46.18% // Decreases project coverage by -14.31% :warning:

Coverage data is based on head (053ff35) compared to base (075f474).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1964       +/-   ##
===========================================
- Coverage   60.49%   46.18%   -14.32%
===========================================
  Files         179      179
  Lines       14523    14523
===========================================
- Hits         8786     6707     -2079
- Misses       4633     6844     +2211
+ Partials     1104      972      -132

Flag
Coverage Δ

acceptance-api
?

acceptance-apps
36.43% <0.00%> (+0.41%)
:arrow_up:

acceptance-cli
35.43% <100.00%> (-20.46%)
:arrow_down:

unittests
8.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Generalize AllocBoxToStack pass to handle apply variations.

Remove all the bespoke utilities for handling apply sites.
Use the ApplySite abstraction instead. So we can not properly
analysis begin_apply and try_apply.

@swift-ci test.

@swift-ci test source compatibility.

@eeckstein or @gottesmm would you care to review this?

I'll take a look real quick.

@atrick I was just thinking. Do we have a test for apply of partial_apply? Would be good to add if it is missing. It may be useful to use a thin_to_thick_function as a test case as well. I am fine with fixing this in a later commit if you want.

@gottesmm thanks. There is an apply of partial_apply test. This PR decreases the need for pass-specific unit tests by removing a bunch of pass specific utilities. It's obviously intractable to test all possible SIL patterns that a pass can handle, but if there's any special-case logic in the pass, that needs an explicit test.

@swift-ci smoke test and merge.


Added variable

$loggedInuser was used in the script, but the variable was not in the script.

This will also cover issue #33