Linking github issues?

This is a random question rather than an "issue", but I am not sure where else to ask this question: Is there any way to put links between github issues? For example for Twinkles I would like to create a "Reprocess all phosim runs" issue, and then link each issue which needs to be fixed before this can be done. This is something I do all of the time with JIRA and so far really miss with GitHub issues.

Just start to type a "#" and then number or text to bring it up.  Then select and it will put a link in for you.  Or maybe you are asking something more complicated, like actually putting in dependencies?

You can also cross-repo, but it doesn't have autocomplete: DarkEnergyScienceCollaboration/ComputingInfrastructure#13

Right I know I can put links in comments, but I want more than that. In JIRA I can actually create link types, like "Is Required By", "Is Related To", "Must be fixed before" etc. Then for any issue I can see what needs to be done before that issue can be completed (and then those issues may in turn have their own requirements). Links within comments does not seem an adequate substitute for this functionality.

Right... this kind of dependency doesn't exist.
@connolly got us access to a JIRA type story board overlay (https://www.zenhub.io).  I'm not sure if it also gives that kind of extension.

As far as I know, ZenHub does not enable linking of issues in this way. The closest thing that could be useful for us is their "Burndown Charts" - but its still all just labelled issues.
One thing we could try is making some issues be "epics":  "Reprocess all phosim runs" would be a good example. In an epic, the first issue comment is special: if you make a list of check boxes in this comment box, a little progress bar for that issue is rendered in the main issue list. All issue comments are editable, so the list can be grown with time if necessary. Then, each checklist item can be issued, and the new issue linked back to the epic (again by editing the check list in the first comment box). For clarity, we could make an epics label, so we can see them all easily. Shall we give this a try?

Trying this sounds fine. To clarify, I do not need to do anything special to create an "epic", except create an issue, optionally label it as epic, and add a set of check boxes in the first comment (like this: https://github.com/DarkEnergyScienceCollaboration/ComputingInfrastructure/issues/14 I assume).

That's right - although notice that in that example Andy and I are not
using the issue as an epic, really, because we are not editing the first
comment. In the main list at
https://github.com/DarkEnergyScienceCollaboration/ComputingInfrastructure/issues
you can see that issue 14 is listed as having "0 of 3" tasks done. Here's a
real epic, that I just made for you:
https://github.com/DarkEnergyScienceCollaboration/ComputingModel/issues/99
On Wed, Mar 23, 2016 at 2:49 PM, Tony Johnson<EMAIL_ADDRESS>wrote:

Trying this sounds fine. To clarify, I do not need to do anything special
to create an "epic", except create an issue, optionally label it as epic,
and add a set of check boxes in the first comment (like this:
DarkEnergyScienceCollaboration/ComputingInfrastructure#14
https://github.com/DarkEnergyScienceCollaboration/ComputingInfrastructure/issues/14
I assume).
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/185#issuecomment-200556431

You can also take a look at  a look at https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/41 (I just reopened it for you) which was used as an epic (you might be able to see it in zenhub - I havent checked)

Yes, that was a good one. Although I see that I closed it before the
checklist was complete! Tut tut.
On Wed, Mar 23, 2016 at 4:02 PM, Andrew Connolly<EMAIL_ADDRESS>wrote:

You can also take a look at a look at #41
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/41 (I
just reopened it for you) which was used as an epic (you might be able to
see it in zenhub - I havent checked)
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/185#issuecomment-200575837

Nice epic at #187, @tony-johnson ! I labelled it attractively for you :-) Feel free to close this if you like.


xUnit Test-Discovery seems not be working with Preview 2 in VS 2017 Preview (1 and 2)

From @WernerMairl on June 16, 2017 17:21
Not sure where i should post this issue (xUnit, VisualStudio, Cli) => please move on the right place
please advice if i can provide more/other informations/traces
Steps to reproduce
"Visual Studio Enterprise 2017 Preview (2) Version 15.3.0 Preview 2.0"
plus
https://dotnetcli.blob.core.windows.net/dotnet/Sdk/release/2.0.0-preview2/dotnet-sdk-latest-win-x64.exe
Expected  behavior
Test Explorer should list some tests
Actual behavior
0 tests
no exception/additional messages in "Show Output from Tests"
Additional findings:
uninstalling dotnet cli Preview2
re-installing Preview 1 (2.0.0-preview1-005977)
solves the problem i can see all my tests- it looks like the problem correlates with preview 2
Not able to solve the problem by

updateing nuget packages ,
clear some VS-TestExtension Caches
etc..

The same problem with two different projects => Preview1 working, Preview2 not working....
Attention: i'm using the newest VS 2017 Update "Preview 2" ....
But i had the same problem with the VS 2017 Preview 1!
My test.csproj is simple:
https://gist.github.com/WernerMairl/e8f2728d7717869c8ab3816c68fbe0a0
Pure cli "dotnet test" is working, the issue is about VS-Test Discovery!
Environment data
dotnet --info output:
dotnet --info
.NET Command Line Tools (2.0.0-preview2-006470)
Product Information:
Version:            2.0.0-preview2-006470
Commit SHA-1 hash:  4ea3671bbd
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.14393
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.0.0-preview2-006470\
Microsoft .NET Core Shared Framework Host
Version  : 2.0.0-preview2-25407-01
Build    : 40c565230930ead58a50719c0ec799df77bddee9
Copied from original issue: dotnet/cli#6910

Looks like same issue as #847.
@WernerMairl we've fixed it for next update of VS 2017 15.3. Please try the following steps if you're blocked on the issue:

Rename attached file to vsix and try. TestPlatform.vsix.zip
Please take a backup of C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise\Common7\IDE\Extensions\TestPlatform just in case.

It works!
Thank you!!
Retested with CLI/SDK
2.0.0-preview2-006470
2.0.0-preview2-006502
regards
Werner

@codito I can't seem to get it to work with the official release of asp.net core from command line.  "dotnet test" cannot find the xunit test.
using Microsoft.AspNetCore 2.0.0
Microsoft.NET.Test.sdk 15.3.0
I posted the bug here https://github.com/Microsoft/vstest/issues/1034


Stuck at first step - Simple blog implementation

Hello @aheinze,
My issue is very silly and concern the front-end, i followed the tutorial for the beginning (https://github.com/COCOPi/cockpit/wiki/Simple-blog-implementation-with-a-router) but i am allready stuck with a Type 4 error.. like that : { "type": 4, "message": "syntax error, unexpected '='", "file": "/home/lawzadpu/savary/views/index.php", "line": 2 }
It seems the server don't like <?php=
I am on php 7 apache and all seems to be well setted.
In other part i tested the cocopikickstart and it work on the same server.
Any idea ?

Please try <?= instead of <?php=

Thanks a lot ! it solve the error but it don't display.
Anything wrong with this in the BO
:
Collections
-blog
--title
--content
?

Sorry, i found it, to many filter


[BUG] The Chain Tool is not working with the Conversational Retrieval QA Chain

Describe the bug
@HenryHengZJ please bear with me 1 min, since this issue is a bit tricky to understand.
The Chain Tool  node does not work as expected when is conected to a Conversational Retrieval QA Chain.
The Agent can not use the Chain Tool to get any info from the Conversational Retrieval QA Chain. It is unclear if this is a issue with the Agent or the Chain Tool node itself.
To Reproduce

Upload the attached flow (a Tool Agent conected to a Conversational Retrieval QA Chain via the Chain Tool). See bellow.
Once loaded, try to make the Tool Agent to use the Chain Tool by asking relevant questions. In this case; "What Tigermergente is all about?"
You will see that it gives you an empty response:

If you force the Agent to use the Chain Tool via system message, then it will make up a response and will tell you that it cant use the Tool Chain

The Tool Agent can see the Chain Tool but cant use it.

Expected behavior
Tool Agent uses the Chain Tool with no problem.
Flow
test - 004 Chatflow.json
Setup

Flowise is up to date.

@HenryHengZJ please help

Fixed this issue via PR
@toi500 FYI

that's a good point @toi500 I wasn't aware of that agent is going to be deprecated.
I'll try to use the Tool Agent as the base agent and see if it works.
Thanks

@toi500 I've changed it to be based on ToolAgent,
Your comment was very effective, thanks 👏

You are the man! Thank you for ur great work here.


Setting DefaultBaseDir to a directory that may not exist fails the plugin

Setting DefaultBaseDir to a directory that may not exist causes the plugin to fail.
I have a controlled parent pom that several projects inherit from.
I have configured the plugin DefaultBaseDir to  "${project.basedir}/src" or even "${project.build.sourceDirectory}.
Most projects are multi-module.
Often with the top level module not having a source directory.
Because this directory does not exit the plugin outright fails.
I believe a better behavior would be that the plugin checks if the defaultBaseDir exists first, and skips if the directory does not exist.

Thanks for the report. I will have a look.

I thought about the use case...
The defaultBaseDir is a property that has to be set because it determines from where the plugin will execute itself. When it is resolved, it means its execution is required. defaultBaseDir is also used to derive the license baseDir in case a module has multiple licenses.
In other words, when the license plugin execution is wanted, defaultBaseDir is required and must be valid.
In modules where the plugin execution is NOT wanted, it should be skipped. Maven has a way to do that by binding the plugin phase to none, or it is possible to use the plugin property skip to skip it.


Shipping from shopify settings, still showing

Hey! Get app, btw!
Is there not a way to disable the shop settings for shipping ? We are using this app to publish Free + Shipping products .. so with your app SKU XXXX would be FREE plus 9.99 shipping. Now, it's working perfectly, but still showing the shops free shipping in the checkout.
Thoughts ... thanks.

@michaelsomerville  I think you just need to delete all of the shipping options in your Shopify admin.

I missed that issue... But yeah, essentially as @onedanshow said, simply delete all the shipping options from within the Admin, and only keep those from Parcelify.


Always close pipes in RunContainer(), in order to avoid hang in error cases

https://bugzilla.redhat.com/show_bug.cgi?id=1442875
@openshift/devex
@bparees ptal - running this against origin tests + extended tests at https://github.com/openshift/origin/pull/13817 then intend to repurpose that PR for the s2i vendoring bump.

[merge]

merge failures look likely to have been introduced by this change.

[test]

squash a couple of these commits and lgtm.

@bparees squashed

[merge]


add option -mongodb.collect.database to enable database-level metrics

work in progress, would like some feedback
the idea is to add the ability to capture some important DB-level metrics
https://docs.mongodb.com/manual/reference/command/dbStats/
Running dbStats for each DB returned by session.DatabaseNames() could potentially slow down metrics collection so that is one of my concerns.
Would like feedback about how this could be made generally useful to others. OR if it is useful

@deepthawtz this looks good, can you rebase it with master?
Also, I added you as collaborator :) thanks for your contributions!


Revert "Content Validation STG 97"

Reverts Azure/azure-sdk-for-net#46489

API change check
API changes are not detected in this pull request.


About SE layer in Fused-MBConv

I understand that the SE layer might get removed in the original fusion attempt: https://ai.googleblog.com/2019/08/efficientnet-edgetpu-creating.html
But according to Fig2 in the paper, it seems like the SE layer is preserved in the Fused MBConv. So I am quite confused when I  found the SE layer lacking in your implementation. Have you ever tried the implementation with SE layer, or am I missing something in the paper?

OK...I guess the missing SE parameter in the architecture table implies that. Nevermind.

OK...I guess the missing SE parameter in the architecture table implies that. Nevermind.

I also notice this implementation lack of SE layer in Fused MBConv. Could further explain about this ?

OK...I guess the missing SE parameter in the architecture table implies that. Nevermind.

I also notice this implementation lack of SE layer in Fused MBConv. Could further explain about this ?

In the architecture table, "SE" shows up but only with normal MBConv, I guess that means it is not used with Fused MBConv

Oh thanks！


Cannot download an older release.

Steps to Reproduce:

Go to releases page
Try to download 1.41.1 or any older version

The link for all versions download the latest version.

@KroneCorylus What versions are you seeing this for? The process we have is that links will always point to the latest for that major version - but each major version should have its own links. So 1.41.0, 1.41.1 and 1.41.2 all point to the same downloads (the 1.41.2) release. But 1.40.* and older major versions should each have their own.
We do this because we don't want people to use older versions that have known issues, so when a hotfix is released we want the link for the major version that hotfix is for to always point to the latest hotfix release for that major version.
So closing this as "working as intended" - although if you're seeing links that don't follow the above rules we have let us know, it's possible that some of the links on those pages are wrong!

Thank you for the excellent answer and sorry if I wasted your time.  I didn't know that it worked like that and indeed I was trying to download a version within the same major release (1.41.1 but getting 1.41.2).  Thanks again.


Cannot generate types if typeDefs are imported from local package monorepo

Describe the bug
I am using monorepo where I have to share the type definitions between packages. So I have defined common graphql type definition in a separate package. But while generating the schema code-generator could not find the schemas imported from the shared module.
To Reproduce

Create a monorepo with a shared packages let's say @demo/schema  and a application package let's say @demo/web
Add @demo/schema to @demo/web
Create a simple enum let's say UserRole inside @demo/schema and build the @demo/schema shared package
Create a simple apollo-server inside @demo/web and import that enum in @demo/web and simply run the server.
Run the apollo server
Generate the schema with the following config

# all the juicy stuff
schema: http://localhost:3000
# all other juicy stuff

This should work but when running with the following config it won't work

# all the juicy stuff
schema:
  - "./packages/web-api/schema/*.ts":
      noRequire: true
# all other juicy stuff

Code Sanobx link: Sandbox
My codegen.yml config file:
schema:
  - "./packages/web-api/schema/*.ts":
      noRequire: true
generates:
  ./packages/web-api/generated.ts:
    plugins:
      - typescript
      - typescript-resolvers

Expected behavior
Environment:

OS: Linux/Mac
@graphql-codegen/cli: 1.20.0
@graphql-codegen/typescript: 1.21.0
@graphql-codegen/typescript: 1.17.4
NodeJS:

Additional context
Please help me with this.

Hi @sunaulo-suhail ,
If you are using noRequire: true, then only pluck process will happen and will extract typeDefs from gql tag. So in this case, you MUST provide all schema pieces, because there is not resolution or require that being called. So your schema config should be:
schema:
  - "./packages/**/src/*.ts":
      noRequire: true

If you are using string interpolation or template literals strings, you need to use noPluck: true to make sure to use require your files, and then you need to export a GraphQLSchema object from the file you specify.


Return NotFound on KEB instance updates when instance is missing

Description
Changes proposed in this pull request:

KEB returns 5xx error on instance update method when instance is not found in db. This proposes a simple change to return 404 instead.

Related issue(s)

https://github.com/orgs/kyma-project/projects/10#card-60954090

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/test all

/assign @piotrmiskiewicz

/test all

/retest

/retest


Ability to exclude certain fragments (outside of Sponsorblock) from file download

Checklist

[X] I'm reporting a feature request
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
Hi,
So I have a situation where I need to exclude certain timestamps / fragments from the file download.
I was thinking of something like this:
An post-processor argument called --exclude-from-file ARGS, where the ARGS are like this:
minute:second-minute:second, and the supplied time stamp would be skipped, just like --sponsorblock-remove CAT excludes fragments from the file download.
And if multiple fragments / timestamps need to be excluded, the fragments could be separated by a semicolon.

From https://github.com/yt-dlp/yt-dlp#post-processing-options
--remove-chapters REGEX          Remove chapters whose title matches the
                                 given regular expression. Time ranges
                                 prefixed by a "*" can also be used in place
                                 of chapters to remove the specified range.
                                 Eg: --remove-chapters "*10:15-15:00"
                                 --remove-chapters "intro". This option can
                                 be used multiple times

Wow, thanks!
How do I use this in my own Python program though? I'm assuming it's a part of the postprocessors key in the ytdl_options, but how do I append this in the postprocessors option?

        YoutubeDL({'postprocessors': [{
            'key': 'ModifyChapters',
            'remove_ranges': [(start1, stop1), (start2, stop2)]
        }]

Here are the other arguments that ModifyChapters take: https://github.com/yt-dlp/yt-dlp/blob/d0e6121adf4f82b266c82d7e632f7fe79f05096c/yt_dlp/postprocessor/modify_chapters.py#L22-L24

Thank you once again!
One last question; are these ranges in seconds (like: (120, 150)) or in the same way as --remove-chapters? (Like 2:00-2:30)

Never mind for my last questions, I figured it out.
For anyone else who wants to know how to do this:
I used 2 different keys, like this:
    'postprocessors': [
        {
        'key': 'FFmpegExtractAudio',
        // other stuff
        },
        {
        'key': 'ModifyChapters',
        // other stuff
        }
    ],
The `remove_ranges` has to contain integers. They also need to be in the same index of the `ModifyChapters` key.
Like this:

    {
    'key': 'ModifyChapters',
    'remove_ranges': [
        (197, 209),
        (242, 272),
        (260, 272)
        ]
    }

My complete options dictionary:

{
'format': 'bestaudio/best',
'postprocessors': [
{
'key': 'FFmpegExtractAudio',
'preferredcodec': 'mp3',
'preferredquality': '192'
},
{
'key': 'ModifyChapters',
'remove_ranges': [
(197, 209),
(242, 272),
(260, 272)
]
}
],
'ffmpeg_location': 'bin',
'progress_hooks': [progress_function],
'outtmpl': 'downloads\%(title)s.%(ext)s',
'noplaylist': True
}

I should have been more clear about that. remove_ranges should be in seconds. The min:sec syntax is allowed in CLI only for convenience. If you want to make use of that in your script, you can use the yt_dlp.utils.parse_duration


Use replacable values when possible

Hi @JunqiZhang0
Its not good to expose internal URLs, it makes people nervous at least. Also, when using values you want the user to replace (replacables), use <replace_me> in text files, and replace_me where better markup is available.
Thank you

Hey @swadeley , thank you for submitting PR! tfacon has been moved to https://github.com/RedHatQE/tfacon, you can submit PR there.

I can do that, but you still need to accept this PR or remove this repo from public view.

Sorry, did not mean to close, let me know if you want it reopened.

https://github.com/RedHatQE/tfacon/pull/22


Are congestion control algorithms applied when the client isn't in the browser?

Hi,
If we're using a custom client like examples/client.rs that communicates with a wtransport server, do we bypass congestion control, since congestion control is enforced in the browser? This is for a CLI application.
QUIC datagrams are ACK-eliciting, which means they are acknowledged for the purpose of congestion control. [1]
But since congestion control algorithms are moved into the user space at both endpoints, will using a custom client like examples/client.rs remove such noise? Especially since there is no browser interfacing.

As you mentioned, QUIC standard (the underlying protocol behind HTTP3 and WebTransport) demands that both QUIC-Streams and QUIC-Datagrams frames are congestion controlled.
<EMAIL_ADDRESS>
DATAGRAM frames employ the QUIC connection's congestion controller.

This is required by the standard, not by browsers.
As consequence, wtransport follows that requirement.

Having said that, the underlying library used by wtransport that implements the QUIC stack (i.e., quinn) allows the possibility to configure a "custom" congestion control.
In the next release of this library, it will be possible to directly configure the underlying QUIC transport configuration: https://github.com/BiagioFesta/wtransport/blob/69f8a77512ed3920acabcf2e6097732c6c1c7735/wtransport/src/config.rs#L448
By using that, it would be possible to inject a custom quinn transport configuration and leverage this method.
It might depend on your application, but generally it is not a good idea messing with the congestion controller. Standard algorithms (such as CUBIC) are well-known and tested for many years.

Thank you for the clarification!


add code addr env support

Description
What is the purpose of the change?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Brief of your solution
Please describe your solution to solve the issue or feature request.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Codecov Report

Merging #24 (c11e9e2) into main (e0287b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   35.80%   35.80%
=======================================
  Files           4        4
  Lines          81       81
=======================================
  Hits           29       29
  Misses         49       49
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0287b4...c11e9e2. Read the comment docs.


Bug in the compiler in 0.60 : 'tuple' object has no attribute 'name'

Reporting a bug
This bug appeared after upgrading from 0.59 to 0.60.

[X] I have tried using the latest released version of Numba (most recent is
visible in the release notes
(https://numba.readthedocs.io/en/stable/release-notes-overview.html).
[X] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

  File "/usr/local/lib/python3.10/dist-packages/torch_geometric/utils/ppr.py", line 113, in get_ppr
    cols, weights = _get_ppr_numba(
  File "/usr/local/lib/python3.10/dist-packages/numba/core/dispatcher.py", line 442, in _compile_for_args
    raise e
  File "/usr/local/lib/python3.10/dist-packages/numba/core/dispatcher.py", line 375, in _compile_for_args
    return_val = self.compile(tuple(argtypes))
  File "/usr/local/lib/python3.10/dist-packages/numba/core/dispatcher.py", line 905, in compile
    cres = self._compiler.compile(args, return_type)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/dispatcher.py", line 80, in compile
    status, retval = self._compile_cached(args, return_type)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/dispatcher.py", line 94, in _compile_cached
    retval = self._compile_core(args, return_type)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/dispatcher.py", line 107, in _compile_core
    cres = compiler.compile_extra(self.targetdescr.typing_context,
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler.py", line 744, in compile_extra
    return pipeline.compile_extra(func)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler.py", line 438, in compile_extra
    return self._compile_bytecode()
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler.py", line 506, in _compile_bytecode
    return self._compile_core()
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler.py", line 481, in _compile_core
    raise e
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler.py", line 472, in _compile_core
    pm.run(self.state)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler_machinery.py", line 364, in run
    raise e
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler_machinery.py", line 356, in run
    self._runPass(idx, pass_inst, state)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler_lock.py", line 35, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler_machinery.py", line 311, in _runPass
    mutated |= check(pss.run_pass, internal_state)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/compiler_machinery.py", line 273, in check
    mangled = func(compiler_state)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/typed_passes.py", line 468, in run_pass
    lower.lower()
  File "/usr/local/lib/python3.10/dist-packages/numba/core/lowering.py", line 187, in lower
    self.lower_normal_function(self.fndesc)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/lowering.py", line 226, in lower_normal_function
    entry_block_tail = self.lower_function_body()
  File "/usr/local/lib/python3.10/dist-packages/numba/core/lowering.py", line 256, in lower_function_body
    self.lower_block(block)
  File "/usr/local/lib/python3.10/dist-packages/numba/core/lowering.py", line 270, in lower_block
    self.lower_inst(inst)
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 51, in lower_inst
    _lower_parfor_parallel(self, inst)
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 67, in _lower_parfor_parallel
    return _lower_parfor_parallel_std(lowerer, parfor)
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 349, in _lower_parfor_parallel_std
    exp_name_to_tuple_var) = _create_gufunc_for_parfor_body(
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 1500, in _create_gufunc_for_parfor_body
    hoisted, not_hoisted = hoist(parfor_params, loop_body, typemap, wrapped_blocks)
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 975, in hoist
    find_setitems_body(setitems, itemsset, loop_body, typemap)
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 950, in find_setitems_body
    find_setitems_block(setitems, itemsset, block, typemap)
  File "/usr/local/lib/python3.10/dist-packages/numba/parfors/parfor_lowering.py", line 936, in find_setitems_block
    if getattr(typemap[item.name], "mutable", False):
AttributeError: 'tuple' object has no attribute 'name'

Repro:
from itertools import chain
from typing import Callable, List, Optional, Tuple

import numpy as np

import numba

def _get_ppr(  # pragma: no cover
    rowptr: np.ndarray,
    col: np.ndarray,
    alpha: float,
    eps: float,
    target: Optional[np.ndarray] = None,
) -> Tuple[List[List[int]], List[List[float]]]:

    num_nodes = len(rowptr) - 1 if target is None else len(target)
    alpha_eps = alpha * eps

    for inode_uint in numba.prange(num_nodes):
        inode = numba.int64(inode_uint)

        p = {inode: 0.0}
        r = {}
        r[inode] = alpha
        q = [inode]

        while len(q) > 0:
            unode = q.pop()
            res = r[unode] if unode in r else 0
            if unode in p:
                p[unode] += res
            else:
                p[unode] = res
    return None, None

_get_ppr_numba: Optional[Callable] = None

alpha = 0.2
eps = 1e-5
num_nodes = 128
row = np.random.randint(low=0, high=num_nodes-1, size=(128,), dtype=np.int64)
col = np.random.randint(low=0, high=num_nodes-1, size=(128,), dtype=np.int64)

_get_ppr_numba = numba.jit(nopython=True, parallel=True)(_get_ppr)

cols, weights = _get_ppr_numba(row, col, alpha, eps, None)

Thanks for the report. Can confirm the bug exists in Numba.
An ugly patch that seems to fix the issue:
diff --git a/numba/parfors/parfor_lowering.py b/numba/parfors/parfor_lowering.py
index 00de2f65b..db2e4c9ac 100644
--- a/numba/parfors/parfor_lowering.py
+++ b/numba/parfors/parfor_lowering.py
@@ -929,9 +929,12 @@ def find_setitems_block(setitems, itemsset, block, typemap):
             rhs = inst.value
             if isinstance(rhs, ir.Expr):
                 if rhs.op in ["build_tuple", "build_list", "build_set", "build_map"]:
-                    for item in rhs.items:
-                        if getattr(typemap[item.name], "mutable", False):
-                            itemsset.add(item.name)
+                    for tup in rhs.items:
+                        if isinstance(tup, ir.Var):
+                            tup = (tup,)
+                        for item in tup:
+                            if getattr(typemap[item.name], "mutable", False):
+                                itemsset.add(item.name)


[GOBBLIN-1973] Change Manifest distcp logic to compare permissions of source and dest files even when source is older

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1973

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

When Manifest distcp fails to set permissions for any reason, we would expect a retry of the copy to allow the datasets to reach eventual consistency. However, the current logic of checking if a file is eligible for copy is to check if the source file is newer, if so copy, and if the source file is exactly the same modification time as the destination file, also copy if the permissions are different. However, in most cases the destination will have a newer modification time once it is written and set permissions, so the source file will generally be older but we still want the permissions to match.
This PR changes the check so that if the source file is older, we still want to check permissions between source and destination to ensure if the file is eligible for copy.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (00c60ca) 42.61% compared to head (91c3560) 46.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3845      +/-   ##
============================================
+ Coverage     42.61%   46.09%   +3.47%
+ Complexity     3779     2182    -1597
============================================
  Files           804      416     -388
  Lines         33940    17992   -15948
  Branches       3769     2194    -1575
============================================
- Hits          14463     8293    -6170
+ Misses        18103     8815    -9288
+ Partials       1374      884     -490

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add all releases for my favorite stars to the download list, not just recent releases

A user is asking if there is a way to do an initial run to add all releases that can be found for the star to the download list?

Thanks for adding the support. Appreciate it!
What does this failure mean after starting the backfilling task?

Probably a bug that I could just fix by hardening calls to Addrange.
Please download the v0.3 again and replace your current pdbMate.exe file with the newly downloaded one.

ok thanks, now there is no failure but the downloads aren't added to nzbget.

Before adding to nzbget begins there should be a log message like:
.. releases after Filter: remove duplicates.
That's the number of releases that will be added. How many to you have there?
For each release there then you should be:
Add ..... to download list ....
Add to nzbget: ....
Do you have any of these loggings in verbose-mode?

That's all I get with the backfilling command:

Looking at your console output and the source code, I don't really see how this is possible.
I put in some more log-messages and uploaded the win-64 exe to the v0.3 release. Please download the version and try again and post the output of the console.
I fixed nothing so the end result should be the same.

There is no difference in the output of the console after replacing the win-64.exe .

I've found out that it adds downloads to the list if I say yes to "Do backfilling for all yout favorite sites?". But it than only adds downloads to the list out of the combination favorite stars from favorite sites what is not what I assumed it is.
Also why do I get so many bad request 400 failures for the downloads in nzbget?

I tested with the latest version and got this result on my own test (one favorite actor and one favorite site - only nzbprn as indexer):

It went just fine working only with the actors.

For the latest console output please update to pdbMate-v0.3-win-x64-fixed.zip from the release section.

That's  the complete output I get after the update to the fixed version:

Also this is only a fraction of the actors I added to favorites.
Is it maybe a problem with nzbget?

No it's not nzbget related. I was finally able to reproduce the problem.
I'm looking into it.

Okay logging was broken and I found the bug. Before I release the new version, we should discuss another problem when testing with your account:
pdbMate would try to add thousands of nzb files to your nzbget. This might work, but I guess this might crash sabnzbd or nzbget. Besides downloading will take forever and many of the older releases won't be available on usenet anymore.
So I was wondering how we should limit the number of releases that are selected.
Two options come to mind:

Add only releases that are not older than X days.
Add only the newest X releases per actor.

Another possibility would be to go one by one regarding the actors. So you could only backfill one actor at a time.
Would one of these options suite your needs? What exactly are you trying to accomplish with backfilling?

That sounds good! I think this option would be good: "Add only releases that are not older than X days."
I just want to fill a NAS with a bunch of releases of my favorite stars.
Did you also found out why it wasn't adding releases for every actor? I have like ~100 favorite actors on porndb and it only says that it adds releases for 6 actors.
Are you also the developer of porndb? If so, there can I ask you questions about it?

The release version 0.3.1 contains all the bugfixes you need and interactive setup now enables you to set the daysback argument. Which makes: "Add only releases that are not older than X days" happen.
The problem with the actors list was, that it did throw error messages but didn't display them and it exited the whole actors queue once there was an actor for which no releases could be found. I fixed these problems and it works now even for hundreds of actors.
I'm not the developer of porndb but I'm in contact with him. You can reach out to him by the support form and he will respond to you by email (ongoing conversations are then by email).

Thank you but I now get this error message:

Please try again. The API was down, it's back up again.

Now I get this error:

And isn't a total of 195 releases a bit low for all the releases that were added for the actors?

It hast to do something with the number of days. It didn't work for 100 days but it worked for 10 days.

@pdbme How does the backfilling handle already downloaded files?

I fixed the issue you experienced. 100 days work now.
Regarding your question:
The target directory for renaming is scanned. So downloads previously done by autopilot mode with renaming active are considered.
You can also let pdbMate rename existing files and once they are in the target directory and correctly attributed in the filename with an ID, backfilling will recognize those files and not download them again.
When backfilling your nzbget download queue and your history are checked against identical releases. So you do not download the same release from porndb twice. BUT this function does not try do recognize normal duplicates from other sources or previous downloads that are found in your queue.

Thank you. Actually it doesn't check against the nzbget history through the backfilling. I think the problem is the download are added to nzbget as RSS links and nzbget still fetches them.
One other question since the update I get a lot of these messages when I use the rename function. What exactly do they mean, what does pdbMate check here?
The videos are still in the folder.

Yes you need to wait until all downloads are correctly loaded or fetched as nzb files before running backfilling again.
Anyway the backfilling is more a one-time usage feature. For continues downloading there is the normal autopilot mode.
No video found means that these wasn't any matching video found (done by release scene title matching).

That's what I did. But nzbget will not do a check against the history and just downloads the file again. But htank you anyways for the great application!

You can close this. But I have one feature request:
Backfilling for only a specified actor.

Luckily this is already possible by command line:
pdbMate backfilling --client nzbget --actor 9999 --daysback 30
You have to replace 9999 by the actor id you want to backfill.
If you have additional feature requests please add a new issue.

Thank you. Is there an easy way to find out the actor id?


Simplify raceWith and effectAsyncM impls

Removes Refs used for control flow logic and replaces them with uninterruptibleMask.

Thank you for this!


models: Add the release_image term form property in the Release typings

Change-type: minor
See: https://www.flowdock.com/app/rulemotion/r-beginners/threads/TDQW8r5EnnQSygJhsPNO9k8moDi
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


How pluralize tables?

Is there a way to pluralize table names in Configurations classes??
Example:
public class DepartmentConfigurations : IEntityTypeConfiguration<Department>
    {
        public void Map(EntityTypeBuilder<Department> builder)
        {
            builder.HasKey(m => m.Id);
        }
    }

Where I can configure table name? I don't want to use DataAnnotations and my OnModelCreating method in DbContext is created by CodeGenerator.
Thanks in advance

Sure, just use builder.ToTable("xxx").
http://ef.readthedocs.io/en/latest/modeling/relational/tables.html#fluent-api

Hi, thanks for your answer but unfortunately method ToTable doesn't exist:

@ronovelo It does exist, add this using statement to the top
using Microsoft.Data.Entity;
Also, make sure that you have
"EntityFramework.Relational": "7.0.0-rc1-final" package in your package.json

Thank you so much, it works with using statement. Greetings!

@ronovelo Would you be able to share your email address. I want to email you few questions and it doens't really belong in this issue?

Ok, I sent you a mail.


nodejs: support corepack

NodeJS ships with corepack nowadays, and with corepack enable that installs a bunch of wrappers for npm, pnpm, yarn so that they honor the packageManager field in package.json.
It's fairly trivial to ship these wrappers too. I wouldn't mind if they were part of the regular nodejs package, but perhaps they should be a separate corepack package?

Thinking about it some more, since upstream doesn't make them part of the package, I think a corepack package is better. I'll try to make one.

Thinking about it some more, since upstream doesn't make them part of the package, I think a corepack package is better. I'll try to make one.

FWIW I've opened https://github.com/nodejs/corepack/pull/244 to document a workaround for users of Nix.

I created #244646 instead but it's waiting on review from someone.


OscServer is inaccessible due to its protection level (Unity 2017.1)

I'm getting the error:
"Assets/OscJack/Editor/OscMonitorWindow.cs(63,46): error CS0122: `OscJack.OscServer.ServerList.get' is inaccessible due to its protection level
"
In Unity 2017.2 . I dont get it in 2018.2.  Don't really understand why...

OscJack now requires assembly definition support. So, it only works on 2017.3 or later.
Sorry for the misinformation. I updated README.


Improve key typing for WHPNames dict

Right now the key type for WHPNames evaluates to Union[str, Tuple[str, str], Tuple[str, None], Tuple[str]] depending on conditions, the input might also look to mypy to be Tuple[str, Optional[str]] which is not explicitly listed.
It's possible that the Tuple[str, str], Tuple[str, None] could just be replaced with Tuple[str, Optional[str]], though this needs evaluation/testing.

It looks like this got fixed "inadvertently" in 2b22c7bef53dcd9c63bfa867bd9fb727247777fd.


Break when an exception is thrown only for user code!

When I set Break when an exception is thrown it would be nice to have an additional option where debugger will stop only if exception is thrown from user code, or saying other way not coming from node library, files inside ‘node_modules’ and global packages. Normally you are not interested on handled exceptions coming from system libraries, because they only generate a lot of noise and some time, like starting application, it’s practical impossible with this option turned on.
thx

Great idea. Unfortunately I don't see this getting fixed in the near future unless we get a community contribution... but for the time being you can filter the exceptions that are thrown if you see that a library you are using has a "favorite" exception type.

Closing, as #699 should offer a less noisy experience and I'm not sure the user / non-usercode distinction will be necessary in this particular instance.


Aasveen/bot changes 8 aug 17

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/TOC.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/TOC.md

[Warning] Invalid file link:(~/WebSDK/docs/troubleshooting/handlingapplicationerrors).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/TOC.md
:white_check_mark:Succeeded

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:warning:Warning

Details

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:warning:Warning

Details

Skype/TOC.md
:warning:Warning

Details

Skype/Trusted-Application-API/docs/TrustedApplicationEndpoint.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md

Line 11: [Warning] Invalid file link:(~/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md).
Line 28: [Warning] Invalid file link:(~/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md).

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md

Line 62: [Warning] Invalid file link:(~/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md).
Line 188: [Warning] Invalid file link:(~/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md).

Skype/TOC.md

[Warning] Invalid file link:(~/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Overview.md
:white_check_mark:Succeeded

Skype/TOC.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Updates AI/ML Inferentia lab to use Trainium instances

What this PR does / why we need it:
PR adds support for Trn1 instances and updates the module to the latest version of Neuron SDK.
Which issue(s) this PR fixes:
Clean up script now cleans up regardless of where you are in the module.
Updated to Karpenter V1
Fixes #
Quality checks

[X] My content adheres to the style guidelines
[X] I ran make test module="<module>" it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I've removed the identity mapping and tested Karpenter. I've also moved the container image environment variables to the Terraform file so users can't accidentally use the wrong images.


Target Initialization Bugs?

Code looks kinda weird...

It appears that target 1 is getting placed at (0,0), and target is getting placed at (0.6,0).

Probably want to make this consistent at some point eventually, but for now I'm just going to leave it as-is.

will tackle this one together with the infusion check mini refactor

no longer relevant


How do I use the prepare function for preview?

I can't seem to find the proper syntax for the prepare function

I don't really understand. It should work just as it does with a sanity schema does natively. If it helps, here's a test that shows that: https://github.com/saiichihashimoto/sanity-typed-schema-builder/blob/ffdbab6dae5f280f79c3a1d472e6cf4af67218f7/src/document/index.spec.ts#L323

@MrNekoShin please comment/make a new comment if you've got a response but otherwise, I'm going to close this.


Improve disabled state close button

Add
not-allowed: cursor
and
user-select none
to the close button in order to give the user feedback it is disabled

we abandoned the not-allowed cursor quite a few versions back because it's non-standard and, subjectively, very disruptively ugly on windows.

@patrickhlauke Thoughts on the user-select: none addition?

the user-select:none part is good...sorry, should have mentioned that at the time

Closing for ##31641.


Embedded Elasticsearch description

Description plus different command as described in #4

Thank you very much for the documentation!


Expose electric status

Since I am owner of Toyota's EV, model BZ4X, it was useful for me to find this library already built. It was missing EV specific statuses that was already part of response. My guess is that BZ4X was not available for testing so it was not exposed in final output.
I added ElectricStatus model and populated attributes with information from payload. There were no need for many transformation from sourced data. I have tested library locally with different status on my car. Everything worked smoothly.
These steps have been performed successfully:

:heavy_check_mark: passed poetry run pre-commit run --all-files
:heavy_check_mark: passed pytest tests/.

This is my first contribution to this project but I have plan to be active user, tester and contributor. Also my plan is to contribute to Home Assistant project https://github.com/DurgNomis-drol/ha_toyota in order to make these data useful for smart home automation.
As side note, this PR should solve question from here: https://github.com/DurgNomis-drol/mytoyota/discussions/371

Hi @CM000n @DurgNomis-drol
I hope this PR is sent correctly. There is no option for requesting review or assigning it to someone from my side.
Cheers
Dino

Thank you for your effort in extending the library for the bZ4X! Adding the ElectricStatus model to expose EV-specific statuses is a fantastic improvement. If this could be implemented in Home Assistant, it would be truly amazing and incredibly useful for smart home automation enthusiasts like myself.
Looking forward to seeing your contributions in the Home Assistant project. Many thanks again for your hard work and for sharing this!


API calls to Client Calls

Changes:

Changed all API calls with clients.
Added immer for state immutability (mutating state is never a good idea with react (ex: mutating array), as it can cause all sorts of nasty issues down the line. If mutation is needed, immer is good because it creates a draft object which can be mutated however you want, and immer will then produce a new array with just the changes you applied to the draft, hence keeping the state immutable).
Added temp solution for auto-finding or auto-creating user for faster setup time.

 Replace Current API Calls with API Clients


IOS thumb purchase.

Hello, Is there any way I can Purchase using thumb imprint in IOS? Is there any workaround for that?

Because you’re testing it in the sandbox.
It will be Ok with using thumbs when it’s in production.

I have no clue how to do it. There are several authorizing methods out there, we have to arrange those methods first.

Wel.. @benevbright answered very well. We will close this issue after some time.
@coldfins Thank you for your concern.


IOU - Back button unresponsive on touches on IOU details page in offline

Details

Issue was caused by the fact that while in offline mode the loading skeleton component is rendered and this component's back button from the header had onPress={() => {}} which wouldn't perform any function. This PR's changes pass down a onBackButtonPress function prop to the onPress of the skeleton component header back button.
Fixed Issues

$ https://github.com/Expensify/App/issues/32408
PROPOSAL: https://github.com/Expensify/App/issues/32408#issuecomment-1837217057
Tests

Open app
Navigate to any 1:1 conversation
Make a Money Request - Manual
Go offline by either turning your internet connection off or Settings > Preferences > Force offline
Navigate to IOU details page and click on the created money request
Tap on the back button in header and observe that the back button works

[x] Verify that no errors appear in the JS console

Offline tests

Open app
Navigate to any 1:1 conversation
Make a Money Request - Manual
Go offline by either turning your internet connection off or Settings > Preferences > Force offline
Navigate to IOU details page and click on the created money request
Tap on the back button in header and observe that the back button works

QA Steps

Open app
Navigate to any 1:1 conversation
Make a Money Request - Manual
Go offline by either turning your internet connection off or Settings > Preferences > Force offline
Navigate to IOU details page and click on the created money request
Tap on the back button in header and observe that the back button works

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/56457735/fdf302a0-b071-4219-9a74-ddcf2ee7f90b

Android: mWeb Chrome
https://github.com/Expensify/App/assets/56457735/a5a81982-93b1-46af-a55c-eedd1f0966c9

iOS: Native
https://github.com/Expensify/App/assets/56457735/764fa77a-d5b1-46d0-9cc3-e80bba760167

iOS: mWeb Safari
https://github.com/Expensify/App/assets/56457735/1a2f3589-2509-4f1d-b98f-ea599aa9cc72

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/56457735/7c58d19e-d963-42e9-8489-417639be3da5

MacOS: Desktop
https://github.com/Expensify/App/assets/56457735/963b6520-f53b-4fd4-856c-e03d9cd649a2

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix url encoding when fetching remote assets

Use url.parse(url).href instead of decodeURI/encodeURI to properly encode the url if necessary.
This fixes the issue where an avatar url was getting double-encoded.

Oops, how did I not see the conflict between the url package and the url var, fix coming...

I used const urlParse = require('url').parse to avoid the conflict with existing url variables. Let me know if it's undesirable. If so, feel free to suggest an alternative names for either the library variable or the existing url variables.


Add pearl to calculator

I literally fat-fingered a typo as I was typing 'commit', feelsbadman

Before

After


WIP: Changes to attrs backend

Implemented:

allow non-GenericAliases to pass through some checks
allow optional and default to be set simultaneously (necessary for bools, convenient for others)
more specific Optional check that avoids certain edge cases
use typed.__origin__ instead of SpockTypes enum

Things that are still missing:

typing.Any and other non-GenericAliases types would be useful to support
Everything goes haywire right now if you have multiple levels of subscripting, e.g. typing.Dict[int, typing.List[float]]

Merging for continued development...


Prerender: Don't redirect search engines

Description/Context
We use Prerender.io to with MIT Learn for the purpose of generating social media previews.
Our prerender fastly integration (based on https://docs.prerender.io/docs/fastly-integration) also redirects user agents googlebot, bingbot, and google.
We'd like to not mess with search engines—e.g., google runs Javascript (See [google docs](https://developers.google.com/search/docs/crawling-indexing/javascript/javascript-seo-basics#:~:text=Once Google's resources allow%2C a,HTML to index the page; also https://vercel.com/blog/how-google-handles-javascript-throughout-the-indexing-process).
Plan/Design
Suggest we remove googlebot and google from the VCL redirects. Maybe bingbot too?
Overview of Google crawlers and fetchers (user agents)

Sure this is very straight forward. Just googlebot, bingbot, and google? Any others?

@Ardiea Google clearly recommends using their JS rendering rather than prerendering (which I guess they call dynamic rendering...maybe because it's "dynamic" in the sense of serving different content to bots vs humans.) I wish I had a better citation for Bing, though  https://webmasters.stackexchange.com/a/140252 from 2023 suggests Bing [and only Bing+Google] run JS.
So, yeah, I'd say only googlebot, bingbot, and google.


[📚] [cloud_firestore_odm] Document how to use transaction in the update method

Moved from: https://github.com/firebase/flutterfire/issues/10088

If I want to use transactionUpdate() method, I need to provide a Transaction object, but there is no documentation on how to create this object. For example, this code doesn't compile:
usersRef
  .doc('foo_id')
  .transactionUpdate(
    transaction, // How to create this object?
    name: 'John',
  );

I can create a Transaction object, using
var transaction = FirebaseFirestore.instance.runTransaction((txn) async {
  return txn;
});

but using this object doesn't work in the first code. Here's the question on StackOverflow.

The question on SO is answered already.
Your problem is unrelated to the ODM. The problem is that you have runTransaction return the Transaction object.
That's not allowed. The Transaction object shouldn't be used outside of runTransaction.
You should instead put your transaction logic inside runTransaction.


Use hash map for accounts in db::Buffer

Codecov Report

Merging #57 into master will increase coverage by 0.07%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   84.22%   84.29%   +0.07%
==========================================
  Files          49       49
  Lines        3829     3847      +18
==========================================
+ Hits         3225     3243      +18
  Misses        604      604

Impacted Files
Coverage Δ

silkworm/db/buffer.hpp
75.00% <ø> (ø)

silkworm/db/buffer.cpp
82.41% <96.29%> (+1.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37ca51...11d808f. Read the comment docs.


.ptp() not @njit compilable anymore?

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

I cant pass numpy arrays like the following to an njit compiled function that contains numpy.ptp().
Why is that ( I think here it says, that .ptp() is supported: https://numba.pydata.org/numba-doc/dev/reference/numpysupported.html)
a = [0.         ,0.         ,0.         ,0.         ,0.         ,0.
,0.         ,0.         ,0.00224828 ,0.00317533 ,0.00830591 ,0.00934349
,0.80603907 ,0.80603907 ,0.80603907 ,0.80603907 ,0.80603907 ,0.94597275,
1.,        1.,        1.,        1.,        1.,        1.,
1.,       ]

import math
from numba import  prange
@nb.njit(nopython=True,parallel=True)
def anynan(array):
   for i in prange(array.size):
       if math.isnan(array[i]):
           return True
   return False
@nb.njit
def scale_zero2one(x):

   x -= x.min()
   x /= x.ptp()
   if anynan(x):
       x[np.isnan(x)] = 0
   return x

a = np.asarray(a,dtype=np.float32)
print(scale_zero2one(a))

np.ptp is supported, but the .ptp method of array objects is not. Modifying your reproducer to define missing imports, define a, and use np.ptp instead results in a successful compilation:
import math
import numpy as np
from numba import prange, njit

@njit(nopython=True, parallel=True)
def anynan(array):
    for i in prange(array.size):
        if math.isnan(array[i]):
            return True
    return False

@njit
def scale_zero2one(x):

    x -= x.min()
    x /= np.ptp(x)
    if anynan(x):
        x[np.isnan(x)] = 0
    return x

a = [1, 2, 3]

a = np.asarray(a, dtype=np.float32)
print(scale_zero2one(a))

https://github.com/numba/numba/pull/6261 fixes


NoSuchMethodError when open Web3Modal

Describe the bug
I have this error when trying to open modal sheet
java.lang.NoSuchMethodError: No virtual method getBackQueue()Lkotlin/collections/ArrayDeque; in class Landroidx/navigation/NavController; or its super classes (declaration of 'androidx.navigation.NavController' appears in /data/app/~~EhdRHUGllLoB-BzAZgrPjQ==/io.interfacelab.debug-m78d9nwRSf09VvJSFTG06Q==/base.apk!classes18.dex)
at com.walletconnect.web3.modal.ui.components.internal.root.Web3ModalRootState.getCanPopUp(Web3ModalRootState.kt:32)
at com.walletconnect.web3.modal.ui.components.internal.root.Web3ModalRootKt.TopBarStartIcon(Web3ModalRoot.kt:105)
at com.walletconnect.web3.modal.ui.components.internal.root.Web3ModalRootKt.access$TopBarStartIcon(Web3ModalRoot.kt:1)
SDK Version

Client: Kotlin
Version bom 1.22.0

To Reproduce
Steps to reproduce the behavior:
navController.openWeb3Modal(
shouldOpenChooseNetwork = true,
onError = { }
)
Expected behavior
Doesn't crash
Device (please complete the following information):

Device: [Oneplus 8 pro]
OS: [Android 11]

What version of navigation dependencies do you have in your project?

2.7.6

Same issue.
Version bom 1.22.0
We don't even have navigation dependency declared.
I've used Web3ModalComponent:
    Web3ModalComponent(
        shouldOpenChooseNetwork = true,
        closeModal = { }
    )

This happens because other library also uses navigation library, but uses more modern version, which is then applied to web3modal:
+--- com.walletconnect:web3modal -> 1.1.1
|    +--- androidx.navigation:navigation-fragment-ktx:2.5.3 -> 2.7.6

@kacperoak Is it possible for Wallet Connect to update navigation library version? I think its reasonable thing to do.
Version 2.5.3 was realeased on October 24, 2022.

@jakubuid Hi. Any update on that? As this is blocker for us - we are still using handmade UI + Sign SDK for this, and cannot begin migration to Modal SDK until this is resolved

@Raenar4k Hello, I'll work on the update of navigation lib version

@Raenar4k the androidx.navigation:navigation-fragment-ktx is already on 2.7.7 within the newest SDK version. I'll update it further to 2.8.0 tho


Option to filter git changes to active workspace

Feature request
Hi. Would it be possible to add new option to vscode settings that would filter displayed git changes to active workspace?
Let's imagine following scenario: I have a parent directory with git repository and few folders which are separate projects. When I open any project in vscode I'd like to see git changes only for this project.
As far as I know this behaviour existed before  multi workspaces were introduced (#37547). Is it possible to make it opt-in functionality, for example in vscode user/workspace settings?
Edit:
Working example implementation at 93a0a27

Filtering is usually a bad idea. A user might think he's committing X files, when in fact he's committing X+Y files since there are Y files hidden away. I'd like us to not be in that position.
If we could render the SCM view as a tree, the experience would be much less painful: #14582

This is very painful.
I agree filtering only is bad idea.
But there should be an option for VS to observe only files from work space and below.
I currently have 1 repo with following folders:

App

Client
Backend

I run separate VS codes for both Client / Server (multiple workspaces does not work for me as code is too big and VS code is slow).
When I'm in Client VS code sees changes in both Client and Backend (which is confusing).
Please consider adding option to watch and (add / commit) only from current work-space.

@pankleks I totally agree with you. But I still think the way forward is to be able to show the SCM changes in a tree-like form.


Missing PR's

We're noticing on some of our higher volume repositories that we get occasional missed PR's that never build in concourse.  It's currently setup to use a webhook trigger as well as the default polling method.

I think I just experienced this as well, where PR A was updated with a force-push to its branch while PR B was opened fresh a couple minutes later.  Manually triggering a check on the resource doesn't seem to help.

@rosenhouse The unfortunate part is the only workaround i can think of is implementing some sort of persistent key value mechanism to track these commits to make sure they're always built. Hopefully i'm missing something fairly obvious though.

Based on the description you are likely running up against #26.  There are a couple PRs under review that would address that issue, but in the meantime one way to get the resource to notice PRs that it missed is by running the following commands on your PR branch:
git commit --amend --no-edit # Updates commit timestamp without modifying commit contents
git push -f origin head # Force-push your PR branch; proceed with caution so you don't accidentally overwrite something you didn't mean to

@ctreatma Right, that’s not the best developer experience though.


Fix default of router.status.port in jobs/gorouter/spec

The status port value is described as 8080 in the spec,
but it is actually 8082 in the source code of gorouter.
cf.

https://github.com/cloudfoundry/gorouter/blob/1d44eeb855da9def0af9c32baef2c9be321d4dd6/config/config.go#L31
(the commit 1d44eeb is referred from the HEAD of the latest develop branch of routing-release)

@nota-ja :
gorouter source code defaults are meant for developing purpose. I do not think we should update status port on release level to match source code defaults.
We have a story in backlog to cleanup defaults and as a part of that story we will remove source code defaults and add a sample config to run gorouter locally.
@shalako @abbyachau opinions ? Thoughts?
Regards
Shash

If we don't specify router.status.port, router.status.user, and router.status.password explicitly in our bosh deployment manifest, the router(s) become listening the port 8082 in the deployed environment.
I think it is very confusing because the word "default" generally means the configuration when we don't specify explicity, at least for me.
However, if you don't think that is confusing, I will respect your opinion.

@nota-ja
As @shashwathi mentioned, we do have a story to sync up the "default" config with what we provide in job specs:  https://www.pivotaltracker.com/story/show/139315175
We don't see the behavior of listening on port 8082 instead of 8080. We have a few questions:

Could you please provide some output to show that port 8082 is in use?
Could you give us more details on your deployment (such as IaaS, bosh vs bosh-lite, etc.)?
How do you generate your manifest?
On the router VM in /var/vcap/jobs/gorouter/config/gorouter.yml, which port do you see for status.port?

@aaronshurley

As @shashwathi mentioned, we do have a story to sync up the "default" config with what we provide in job specs: https://www.pivotaltracker.com/story/show/139315175

Sounds great!

We don't see the behavior of listening on port 8082 instead of 8080. We have a few questions:

Could you please provide some output to show that port 8082 is in use?

I found this behavior when I was deploying gorouter and doppler collocated in a same VM.
But the doppler job failed.
Then I found the following logs from /var/vcap/sys/log/doppler/doppler.stderr.log:
2017/02/16 13:53:30 Startup: Setting up the doppler server
2017/02/16 13:53:30 dropsondeUnmarshallerCollection: created 5 unmarshallers
2017/02/16 13:53:30 Listening for GRPC connections on 8082
2017/02/16 13:53:30 Failed to start listener (port=8082) for gRPC: listen tcp :8082: bind: address already in use
panic: Failed to create doppler: listen tcp :8082: bind: address already in use
(..omit..)

Doppler tried to listen the port 8082 for GRPC (this is the default), but the port was already in use.
So I ran netstat and found the port 8082 was used by gorouter:
# netstat -ltnp
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:8400          <IP_ADDRESS>:*               LISTEN      8992/consul
tcp        0      0 <IP_ADDRESS>:28081         <IP_ADDRESS>:*               LISTEN      9253/trafficcontrol
tcp        0      0 <IP_ADDRESS>:33331         <IP_ADDRESS>:*               LISTEN      941/bosh-agent
tcp        0      0 <IP_ADDRESS>:8500          <IP_ADDRESS>:*               LISTEN      8992/consul
tcp        0      0 <IP_ADDRESS>:53            <IP_ADDRESS>:*               LISTEN      8992/consul
tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN      1544/sshd
tcp        0      0 <IP_ADDRESS>:17016         <IP_ADDRESS>:*               LISTEN      9446/ssh-proxy
tcp        0      0 <IP_ADDRESS>:2822          <IP_ADDRESS>:*               LISTEN      2027/monit
tcp        0      0 <IP_ADDRESS>:2825          <IP_ADDRESS>:*               LISTEN      941/bosh-agent
tcp        0      0 <IP_ADDRESS>:6060          <IP_ADDRESS>:*               LISTEN      9253/trafficcontrol
tcp        0      0 <IP_ADDRESS>:17005         <IP_ADDRESS>:*               LISTEN      9411/file-server
tcp        0      0 <IP_ADDRESS>:6061          <IP_ADDRESS>:*               LISTEN      9066/metron
tcp        0      0 <IP_ADDRESS>:8301          <IP_ADDRESS>:*               LISTEN      8992/consul
tcp        0      0 <IP_ADDRESS>:41582           <IP_ADDRESS>:*               LISTEN      590/rpc.statd
tcp        0      0 <IP_ADDRESS>:111             <IP_ADDRESS>:*               LISTEN      540/rpcbind
tcp6       0      0 :::8080                 :::*                    LISTEN      9411/file-server
tcp6       0      0 :::80                   :::*                    LISTEN      9135/gorouter
tcp6       0      0 :::8082                 :::*                    LISTEN      9135/gorouter
tcp6       0      0 :::22                   :::*                    LISTEN      1544/sshd
tcp6       0      0 :::59717                :::*                    LISTEN      590/rpc.statd
tcp6       0      0 :::17003                :::*                    LISTEN      9135/gorouter
tcp6       0      0 :::2222                 :::*                    LISTEN      9446/ssh-proxy
tcp6       0      0 :::2223                 :::*                    LISTEN      9446/ssh-proxy
tcp6       0      0 :::111                  :::*                    LISTEN      540/rpcbind

Could you give us more details on your deployment (such as IaaS, bosh vs bosh-lite, etc.)?

I am using OpenStack as IaaS.
This is my bosh manifest used for the deployment (confidential information has been reducted).
The part commented out is in question.

How do you generate your manifest?

Manually.

On the router VM in /var/vcap/jobs/gorouter/config/gorouter.yml, which port do you see for status.port?

This is the generated YAML file (confidential information has been reducted). There's no configuration for status.port.
I think that is reasonable because of the source code of gorouter.yml.erb, and thus gorouter uses the default port 8082.

@shalako @abbyachau @nota-ja
The reason this is happening is that if all three of router.status.port, router.status.user, and router.status.password are not present, the gorouter.yml will not have a status field and will fall back on gorouter source code defaults (which uses port 8082).
https://github.com/cloudfoundry-incubator/routing-release/blob/52d75abb9006d950fed0de6d79eef81d7efc7b65/jobs/gorouter/templates/gorouter.yml.erb#L2-L4
https://github.com/cloudfoundry/gorouter/blob/1d44eeb855da9def0af9c32baef2c9be321d4dd6/config/config.go#L31
How about removing the status endpoint in Gorouter if the manifest does not explicitly contain all three properties, instead of having a secret unexpected endpoint (which also happens to have no authentication)?

@flawedmatrix

How about removing the status endpoint in Gorouter if the manifest does not explicitly contain all three properties, instead of having a secret unexpected endpoint (which also happens to have no authentication)?

I have no objection, because I don't yet have any deployment of Cloud Foundry in production.
However, the change will probably break the current expectation of other deployers, so I think it should be carefully done.

I would suggest the manifest template require a value for status.password and fail the deployment before rolling the router if a value is not provided. This way the template defaults for status.port and status.password always apply.
We must listen on some port for /routes, /health, and /varz.

@shalako

I would suggest the manifest template require a value for status.

That means also to delete "default" value for router.status.port from develop/jobs/gorouter/spec?
Is my understanding right?
If so, it's OK for me and I will close this pull request.

I think we'd keep the default port 8080 as that is providing the healthcheck endpoint for production deployments.
I'm proposing we add a default user and require a password (with no default).

@shalako
Now I think I've understood what you wrote.
So providing default values for router.status.user and router.status.password, generated gorouter.yml will always have configuration for router.{port,user,pass} even when one of them are omitted, and thus the default port will also be effective.
One last question just from curiosity.
Why gorouter.yml requires all the three value for custom configuration. If this code were something like the following, I think this issue may not occur.
status:
  <% if_p("router.status.port") %>
  port: <%= p("router.status.port") %>
  <% end %>
  <% if_p("router.status.user") %>
  user: <%= p("router.status.user" %>
  <% end %>
  <% if_p("router.status.password") %>
  pass: "<%= p("router.status.password") %>"
  <% end %>

@nota-ja Regarding your last question, health check port, username and password were considered a tuple so either the manifest values would be picked if all three are present otherwise source code defaults take precedence. We do see your point in wanting to only change a subset of these properties.
Do you agree with @shalako in requiring a password but we can set a default user?
Would you like to update the PR for these changes? Otherwise, it will be a feature request and a story will be created for it.
Thanks,
Aaron && @shashwathi

I agree with all you (the routing-release team) have decided with this issue.
I would not update this pull request so would you please file the propsed change as a feature request.
And thus, I would close this pull request right now.


Issue with Image Display in Rich Text Editor when Synchronizing Work Items from Azure DevOps via Pulse

Discussed in https://github.com/Tricentis/qTest.Integration.Pulse/discussions/19

Originally posted by AmineLaggoune October  7, 2024
I’m currently working on synchronizing work items from Azure DevOps into qTest as requirements via Pulse. During this process, I encountered an issue with the display of images in the Rich Text Editor field type.
Specifically, I tried embedding an image both via a direct URL and as a Base64-encoded string within the Rich Text Editor field of the requirement. However, neither method successfully renders the image in qTest. The image tags seem to be ignored or not supported, and the image doesn’t display as expected.
Here’s an example of the data stored in the Rich Text Editor field:
{     "field_id": 12133227,     "field_name": "Description",     "field_value": "" }
Or using a direct URL:
{     "field_id": 12133227,     "field_name": "Description",     "field_value": "" }
Neither the Base64-encoded image nor the direct URL is rendered.
I wanted to check if this is a known limitation with the Rich Text Editor field in qTest or if there’s a different approach I should use to handle images in this context.

Sorry for your trouble, but you will have better luck opening a support ticket directly for that one, as I don't have personal experience with what you're attempting, only the attachment API.  Please go here: https://support-hub.tricentis.com/open


Fix configure calico network pool for ipipMode = CrossSubnet

When you set calico ipip mode to CrossSubnet, deployment fails because filter capitalize remove the uppercase in "Subnet", so CrossSubnet gets converted to Crosssubnet which breakes the task Calico | Configure calico network pool

Fix issue https://github.com/kubernetes-incubator/kubespray/issues/3237