Wait windows up time parameter.

The problem this PR tries to solve is that In some clouds a restart could happen on a Windows Host 2 minutes after it is provisioned. This could be because of System Upgrade or other.
What particularly I experience is that this Blueprint fail:
services:
  type: org.apache.brooklyn.entity.software.base.VanillaWindowsProcess
  brooklyn.config:
    pre.install.command: echo preInstallCommand
    install.command: echo installCommand > C:\\install.txt
    post.install.command: echo postInstallCommand
    customize.command: echo customizeCommand
    pre.launch.command: echo preLaunchCommand
    launch.powershell.command: |
      Start-Sleep -s 400
      Write-Host Test Completed
    post.launch.command: echo postLaunchCommand
    checkRunning.command: echo checkRunningCommand
    stop.command: echo stopCommand

When I login on the host and search for System event of type 1074 in Windows Event Viewer, there is
The process C:\Windows\system32\winlogon.exe (W2K12-STD) has initiated the restart of computer WIN-JV0CGR5J6GN on behalf of user NT AUTHORITY\SYSTEM for the following reason: Operating System: Upgrade (Planned) Reason Code: 0x80020003 Shutdown Type: restart Comment:

With this config key Brooklyn will wait 5 minutes for a restart to happen before returning the machine as accessible. With this config Brooklyn waits before giving the machine to the entity and the blueprint succeeds.
I tried adding Get-PendingReboot script from  gallery.technet.microsoft.com but every time it executes it tells that no restarts are pending and again it restarts.
I left out commented code so you can test Get-PendingReboot yourself.
Do you think adding this option is enough or I should investigate further why it restarts?

Finished review. The PR was updated while commenting, so part of my comments are now marked as outdated. Worth going through each one the confirm that its addressed and not rely on github's UI.

Thank you @neykov most of the comments were addressed.
I am verifying the changes now. It takes some time to wait all of this :)

@neykov I tested it and it is working fine.
I am hesitant about using milliseconds though.

Needs config key's description updated, otherwise good to merge.

Cherry-picked to 0.9.x branch


Fix wrong mipmap sampling level in IBL

I found that IBL on the current main branch does not work correctly.
As shown below:

The back of the helmet is not smooth and should not project the surrounding environment obviously.
That is irradiance is not sampled correctly from the corresponding blur level according to the roughness.
This PR fixed this.

Ah, nice catch!


explicit sign

this will sign a tx, how to construct a tx wihtout signing and then sign later?
tx = VersionedTransaction(msg, [sender])

You can use VersionedTransaction.populate with Signature.default(), or you could just not construct a transaction without real signatures? A transaction is merely a Message with signatures, so you could just use a Message?

thanks, I didnt know that.  from a higher level library.
def sign_tx_with_private_key(
    unsigned_tx_base64: str, keypair: kp.Keypair
) -> str:
    """
    Signs message content and replaces placeholder zero signature with signature.

    :param unsigned_tx_base64: transaction bytes in base64
    :param keypair: key pair to sign with
    :return: signed transaction
    """
    b = base64.b64decode(unsigned_tx_base64)

    raw_tx = solders_tx.VersionedTransaction.from_bytes(b)
    signature = keypair.sign_message(msg.to_bytes_versioned(raw_tx.message))
    signatures = [signature]

    if len(raw_tx.signatures) > 1:
        signatures.extend(list(raw_tx.signatures[1:]))

    tx = solders_tx.VersionedTransaction.populate(raw_tx.message, signatures)

    # convert transaction back to base64
    signed_tx_bytes_base64 = base64.b64encode(bytes(tx))
    return signed_tx_bytes_base64.decode("utf-8")


An unwanted blank space in the subject

I'm using the lettre to send emails with the reset password token, my software is in Portuguese.
I'm facing a problem with the subject, I'm sending:
let subject = format!("{0}, aqui está o seu código de recuperação do e-mail.", user_first_name);
And the email subject are displaying: André, aqui está o seu c ódigo de recuperação do e-mail.
"c ódigo" should be "código".
Thank you very much.

Did you try this on version 0.10.3 or higher?
Could you post a full POC? You can use the basic_html example as a starting point

Using lettre version 0.11.7 and the exact same subject format!("{0}, aqui está o seu código de recuperação do e-mail.", "André");, I could not reproduce the bug. It appears to be fixed in https://github.com/lettre/email-encoding/pull/8 on March 27th just a few days before this issue was opened.

Thanks for testing it again, closing.


Questions on Restsharp dependency tracking

I know that dependency tracking is enabled automatically for HttpClient, I was wondering if there was a way for me to implement this same dependency tracking for RestSharp? Do I just need to use telemetry client to track the request? Also, how do I get my downstream dependencies to use the parent operation ID from my incoming web requests?

I have made some progress on this, I have this call which I use on every restsharp request:
private void AddAppInsightsTracking(HttpRequestMessage request)
        {
            var activity = System.Diagnostics.Activity.Current;
            request.Headers.Add(W3CConstants.TraceParentHeader, activity.Id);
            var traceState = activity.TraceStateString;
            if (traceState != null)
            {
                request.Headers.Add(W3CConstants.TraceStateHeader, traceState);
            }
        }

This is now successfully correlating between our frontend API and our backend services, however it seems that app insights is not correlating the dependency telemetry from our frontend SPA to the frontend API.
The traceparent header is present on my requests from the SPA, so I had assumed that the frontend API app insights would be smart enough to use that traceparent header to set the parent Id on Activity.Current but it appears Activity.Current.Id and Activity.Current.ParentId are always the same. Am I missing something?

Anyone able to fix this one? Would this work for the HttpClient itself?

Can someone confirm that dependency tracking does work for appication insights in combination with RestSharp?


Create and connect a database with existing data

Rather than keeping all data in the frontend, let's transition to hosting our own API server and requesting some data on demand.

[x] Files related to the API server should live at the root of the repo in a folder named /api.
[x] The API should consist of a Postgres database and a Flask API server
[x] They should each be dockerized so the DB and API server can be recreated easily in local dev builds and deployed easily.
[x] The database should fill itself with the data from SA_dashboard.geojson and SA2_info_for_dashboard.csv.
[ ] To start with, the API server should have one endpoint, /api/features.geojson, which produces the same content as SA_dashboard.geojson.

For a cheap way to test if the API endpoint produces the right output:
if [ "$(md5 -q src/data/SA_dashboard.geojson)" == "$(curl -sL "http://localhost/api/features.geojson" | md5 -q)" ]; then echo "yay"; else echo "boo"; fi

Change localhost to include whatever port you end up using for the API server.

I've added a better method of comparing the API endpoint's output with the reference geojson file. I added it to the backend-dev branch under /src/data/compare_json.py. You can do a git pull to get that commit on your local branch.

Resolved by #214, #226, and others.


Conda packaged caffe2 still requires LD_LIBRARY_PATH for CUDA

Steps to reproduce:

Build and install Caffe2 using the conda packaging
Run this:

python -c "import caffe2.python.core"
WARNING:root:This caffe2 python run does not have GPU support. Will run in CPU only mode.
WARNING:root:Debug message: libcudart.so.8.0: cannot open shared object file: No such file or directory
CRITICAL:root:Cannot load caffe2.python. Error: libcudart.so.8.0: cannot open shared object file: No such file or directory
(python2<EMAIL_ADDRESS>~/local/pytorch] LD_LIBRARY_PATH=/usr/local/cuda/lib64 python -c "import caffe2.python.core"

Expected result: it's not necessary to add LD_LIBRARY_PATH to CUDA directory
Actual result: it is necessary
I am not familiar with how Caffe2's Python library looks for these libraries so I don't know if there's some mechanism that should be triggering that is not. Possibly the notice that CUDA is not supported by this build is related.

This is expected, since we currently don't add an RPATH to the built libraries. I'm looking into this.

FYI, recent CUDA packages do this for you:
cuda-cudart-8-0: /etc/ld.so.conf.d/cuda-8-0.conf
cuda-cudart-9-0: /etc/ld.so.conf.d/cuda-9-0.conf

OK, I'm going to close this


covidcast endpoint - as_of field fails silently when given a range of dates

Giving as_of a date range fails silently and it returns the latest data. Example:
https://delphi.cmu.edu/epidata//covidcast/?data_source=hhs&signals=confirmed_admissions_influenza_1d_prop_7dav&time_type=day&geo_type=state&time_values=*&geo_values=ca&as_of=20230101-20230102
Giving a single date gives different issues
https://delphi.cmu.edu/epidata//covidcast/?data_source=hhs&signals=confirmed_admissions_influenza_1d_prop_7dav&time_type=day&geo_type=state&time_values=*&geo_values=ca&as_of=20230102
Giving it a list of dates, it fails with a helpful error message:
https://delphi.cmu.edu/epidata//covidcast/?data_source=hhs&signals=confirmed_admissions_influenza_1d_prop_7dav&time_type=day&geo_type=state&time_values=*&geo_values=ca&as_of=20230101,20230102
[edit from katie:] The behavior we want is for it to fail with a helpful error message.

This happens, because time range like this -> 20230101-20230102 is a "valid range".
This function is used to parse it:
    # parses a given string in format YYYYMMDD or YYYY-MM-DD to a number in the form YYYYMMDD
    try:
        if s == "*":
            return s
        else:
            return int(s.replace("-", ""))
    except ValueError:
        raise ValidationFailedException(f"not a valid date: {s}")

Which means that 20230101-20230102 is parsed to<PHONE_NUMBER>230102.


consider toning down red selection and wide border

I think I preferred a blue colour selection rectangle instead of red.
...and with the border not this fat. It doesn't allow us to have accuracy in selecting the target portion.

from https://github.com/tabulapdf/tabula/issues/303

+1 to making the border thinner

check this ish out: 3b4c889 what do you think?

Much better. Closing.


Some commands error!

Sometimes there are some commands which take like 40 mins and just say thinking and after that it give error application did not respond!

Do you have examples of commands? And what errors do you get?

 In the other case I don't know


Controls are not showing on Android for vimeo player

When opening up the following page: https://plyr.io/#vimeo and clicking play
Expected behaviour
Clicking video should show video controls
Actual behaviour
Not able to click pause or show controls
Steps to reproduce

Open https://plyr.io/#vimeo
Click play

Environment

Browser: Chrome
Version: LTS
Operating System: Android
Version: 10

Same thing happens in:
Environment

Browser: Chrome & Firefox
Operating System: Android
Version: 11

https://plyr.io/#vimeo
Also on Android Opera (Full version).
Youtube, Video & Audio all work fine on the demo.

Same thing happens in iOS

I check every day if the issue is resolved, seems like it's not going to be yet.
Any workarounds maybe? How to fix that manually?

I reverted to the previous release, as the bug isn't present in that
version.
On Thu, 24 Dec 2020, 07:24 lmcsu<EMAIL_ADDRESS>wrote:

I check every day if the issue is resolved, seems like it's not going to
be yet.
Any workarounds maybe? How to fix that manually?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sampotts/plyr/issues/2018#issuecomment-750786128, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARRVK2FF4OEZJEDJ52SIVATSWLUERANCNFSM4TVOY6XQ
.

@michaelfigment thank you, I downgraded to version 3.6.2 and it works.

Downgrading to plyr 3.6.2 is also not working. Using ngx-plyr 4.0.0. Any updates on this issue?

Downgrading to plyr 3.6.2 is also not working. Using ngx-plyr 4.0.0. Any updates on this issue?

Yes, we are getting the same issue on chrome on android after updating plyrjs to 3.6.4.
After pausing the video the controls are not shown.

Hi anyone with some urgent fix , users are not able to see any controls after playing vimeo video  with new version 3.6.4??

Hello, any updated or maybe workarounds?

I'm having this same issue, anyone found a solution?
Once I press play, the controls disappear and won't reappear again unless I press space bar
Happens on both:
Chrome & Firefox


Cluster-API: upstream support for most common providers

Support Flatcar in Cluster-API
Tracked Issues and PRs
Foundational

[x]  Kubeadm Bootstrap provider ignition support: https://github.com/kubernetes-sigs/cluster-api/pull/4172

Related / dataurl dependency: https://github.com/vincent-petithory/dataurl/issues/7

[X] Image Builder support for Flatcar: https://github.com/kubernetes-sigs/image-builder/pull/248
[x] https://github.com/kubernetes-sigs/image-builder/pull/701

Platforms / Providers

AWS: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/1979

Blocked by Ignition bootstrap PR
[x] Support ignition for bootstrapping: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/2271

Azure: https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/629 ( downstream tracking issue )

Blocked by Ignition bootstrap PR
[ ] Add Flatcar Container Linux template to CAPZ: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1729
[x] Support for Shared Image Gallery images requiring a Plan : https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/1463 , https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1469
[x] image-builder: support for Azure SIG flatcar image  https://github.com/kubernetes-sigs/image-builder/pull/652
[x] TODO: update azure go library in Mantle to support unmanaged disk images. Fallout of https://github.com/kinvolk/Flatcar/issues/417

Equinix Metal:

[ ] Upstream PR for v1alpha4/v1beta1 support https://github.com/kubernetes-sigs/cluster-api-provider-packet/pull/289
[ ] WIP: template + metadata injection work needed

Metal3:

[X] Support for Flatcar images: https://github.com/metal3-io/metal3-dev-env/pull/457
[ ] CAPI provider supports Flatcar: https://github.com/metal3-io/cluster-api-provider-metal3

Tinkerbell
vSphere

[x] https://github.com/kubernetes-sigs/image-builder/pull/817 VSphere Image builder support for Flatcar (blocked by below)
[x] https://github.com/kubernetes-sigs/image-builder/pull/827
[x] https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/1429 Ignition support for VSphere

GCP

Tracking issue: https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/540

Tests

https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-aws
https://prow.k8s.io/?repo=kubernetes-sigs%2Fcluster-api-provider-aws

SIG cluster lifecycle meetings calendar<EMAIL_ADDRESS>Follow-up work (not checkboxed since it does not contribute to the roandmap item)

Publish a blog post on our changes and additions to CAPI to make Ignition and Flatcar work.
Integrate into the release process and publish Flatcar CAPI images on Azure and AWS.
AWS provider: For Ignition support to graduate out of experimental phase we need to abstract out S3 support into a separate CRD, ref: issue comment.

@dongsupark The Azure image-builder PR is still failing a test (containerd version detection), can you help? https://github.com/kubernetes-sigs/image-builder/pull/652

@t-lo I don't have access to edit the issue comment. But for Ignition support to graduate out of experimental phase we need to abstract out S3 support into a separate CRD, ref: issue comment.

I would contribute openstack related support, if there is any interest?

@till There absolutely is! Please pardon the late reply. We're basing the support for individual providers on our work to support Ignition config as an alternative to cloud-init in the kubeadm bootstrap provider; that's a good point to start.

@t-lo No worries.
Is this ultimately replacing the work in lokomotive? I hacked around in it to add Openstack, but wasn't able to gain any quick wins.

Is this ultimately replacing the work in lokomotive?
I hacked around in it to add Openstack, but wasn't able to gain any quick wins.

It's not related to Lokomotive; CAPI and Lokomotive have different use cases.

@till The PR to add Ignition support to kubeadm was merged and will be part of the CAPI v1.1 release next year. That's a good point in time to get started with Openstack support ;)
Please feel free to ping us here if you have questions.

I'm looking into vSphere support.

@t-lo If possible we would like to have support for GCP and OpenStack added to the supported provider list.

@ericgraf Ignition support was added in the v1.1 CAPI release yesterday, making it significantly easier to add support for more providers. While we currently don't have plans to work on GCP or OpenStack please feel free to pick this up, I'll happily update the tracking issue to reflect the work.
Please do not hesitate to reach out to us for pointers and for help - the maintainers are available all day via https://app.element.io/#/room/#flatcar:matrix.org.

Adding @johananl 's PR for vSphere support here: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/1429

@t-lo FYI I've opened an issue on CAPG to request Flatcar support - https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/540

@AverageMarcus Thank you! I've added the tracking issue to the summary.

@AverageMarcus Would you be interested to work on CAPG support? The team is supportive of the idea but currently pursues other priorities. We can definitely ramp you up on existing CAPI work and support you in the process.

I can't currently as have other work with higher priorities but possibly in the future once this becomes more of a priority for us. I mainly wanted to ensure it was tracked on CAPG so there was at least an awareness of wanting this.

Happy to ping everyone informing that CAPI support has been merged today :tada:

@t-lo I opened an issue for openstack https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1261. I'm working on this currently.

There will be changes required to the image-builder as well. Currently I'm basing my work on the QEMU image but grub.cfg requires modification. There is also a WIP PR to fix ongoing issues with the build https://github.com/kubernetes-sigs/image-builder/pull/907

There will be changes required to the image-builder as well. Currently I'm basing my work on the QEMU image but grub.cfg requires modification. There is also a WIP PR to fix ongoing issues with the build kubernetes-sigs/image-builder#907

Please feel free to reach out if you feel stuck. @pothos and @dongsupark are good peers for Flatcar related image builder issues, and @johananl did quite some work on image builder lately, too.

We'll soon retire this epic tracking issue in favour of our new ClusterAPI tab in our Projects board: https://github.com/orgs/flatcar/projects/7/views/14

Everything was migrated to the board 🎉. Closing.


iOS release build warning: Built to build/aot/. warning: parsing line table prologue at offset 0x6f697463 found unsupported version 0x00 warning: line table parameters mismatch. Cannot emit.

Steps to Reproduce

Create new flutter app
Open ios/Runner.xcworkspace in Xcode
Build in Release

Logs
warning: parsing line table prologue at offset 0x6f697463 found unsupported version 0x00
warning: line table parameters mismatch. Cannot emit.
note: while processing /Users/m/Projects/test_language_headers/test_app_objc/build/aot/armv7/snapshot_assembly.o

$ flutter doctor -v
[✓] Flutter (Channel swift-plugin-podspec, v1.10.16-pre.68, on Mac OS X 10.14.6 18G87, locale en-US)
    • Flutter version 1.10.16-pre.68 at /Users/m/Projects/flutter
    • Framework revision f770ea54d0 (31 minutes ago), 2019-11-06 20:35:26 -0800
    • Engine revision d68c00947e
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/m/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2)
    • Xcode at /Users/m/Applications/Xcode-11_2.app/Contents/Developer
    • Xcode 11.2, Build version 11B41
    • CocoaPods version 1.8.3

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 40.2.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[!] IntelliJ IDEA Ultimate Edition (version 2019.1.4)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.39.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (3 available)
    • Flutter iOS Device • d83d5bc53967baa0ee18626ba87b6254b2ab5418 • ios • iOS 13.1.3
    • iPod touch         • 9fbe53ba4d06927398644c5bd520d2aa18053017 • ios • iOS 11.3.1
    • iPhone 11 Pro Max  • 73D9DE48-6FBE-4E26-A728-C534A621DAF0     • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-2 (simulator)

! Doctor found issues in 1 category.

I'm getting the same warning on Xcode after archive build. I'm also having problems submitting the build to the App Store (corrupted binary). Don't know if it is related.
$ flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.14.6 18G103, locale en-GB)
    • Flutter version 1.9.1+hotfix.6 at /Users/allesbestedev/Programmering/flutter
    • Framework revision 68587a0916 (3 months ago), 2019-09-13 19:46:58 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_HOME to that location.
      You may also want to add it to your PATH environment variable.

[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.1, Build version 11A1027
    • CocoaPods version 1.8.4

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).

[✓] VS Code (version 1.40.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.0

[!] Connected device
    ! No devices available

Same issue here now. Command line:
flutter build ios --flavor production
Result:
...
Xcode's output:
↳
    Building AOT snapshot in release mode (ios-release)...
    Building App.framework for arm64...

    Building App.framework for armv7...
    Building AOT snapshot in release mode (ios-release)...             56.0s
    Built to build/aot/.
    warning: parsing line table prologue at offset 0x6f697463 found unsupported version 0x00
    warning: line table parameters mismatch. Cannot emit.
    note: while processing ../build/aot/armv7/snapshot_assembly.o
    Project ../myapp built and packaged successfully.
    ../myapp/ios/Runner/GeneratedPluginRegistrant.m:10:9: fatal error: module 'cloud_firestore' not found
    @import cloud_firestore;
     ~~~~~~~^~~~~~~~~~~~~~~

Not sure is it related but this problem occurred after I deleted myapp/ios folder (which was based on a very old Flutter version) and created it again with flutter create using the latest Flutter version (I did this for trying to resolve one other issue). Then I had to make some heavy manual editing to files under myapp/ios to restore some required stuff (flavors etc.). So yes it is possible that I have caused this issue myself. Anyway, same strange error message. And not any clean operation seems to fix it.
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G95, locale en-US)
    • Flutter version 1.12.13+hotfix.5 at /Users/user/development/flutter
    • Framework revision 27321ebbad (8 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/user/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.41.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

This is a duplicate of https://github.com/flutter/flutter/issues/42974.


⚡  add undici for uber fast webdis requests

Description
Small refactor for better perf
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

closing because it won't work in middleware.


Imporve password validation test cases

Password validation policy is disabled with

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6194630927

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6194630927
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6194916839

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6194916839
Status: success


md-datepicker

Status:

There is no public Material Design spec that works for both desktop and mobile (the current spec is mobile-only). The design team is working on this.
We have some contributors exploring an implementation.

Hello @jelbourn , do you know when this feature of md-datepicker (md-calendar) while be available?
Where I can find the current contributor's work for this ?
Thanks

@jelbourn something worth investigating: code.promactinfo.com/md2/datepicker - squeeze in a md-select for the year part and you got one steamy md-datepicker :grinning:

Along with md-datepicker, would be nice to have a md-timepicker, like this. That feature will be available?

Hello @jelbourn, Just the md-datepicker is not so useful in a lot of the cases in my point of view because is necessary the time to be used in the form. Would be good to have a md-datetimepicker where you configure the format date, time or datetime. This way we don't need to mix datepicker and timepicker to create the Date object that is going to be used in the system. A good example is https://eonasdan.github.io/bootstrap-datetimepicker/. I use it with jQuery to create a component but would be nice to have a pure component using just angular2.

Would be nice If it has multi date select option and an option to exclude dates.

@arnaudforaison in the meantime you could try to use this one.. it's not the best implementation ever a it lacks a dialog view but i think it could be a good start

Hello guys (thanks for your awesome work)
I just would like to ask news about this element, any ETA? Is someone working on it? Can we contribute?

Date picker is not working with angular 2
.Not showing anything days,month or year.

@VisualtThreat You might be seeing the issue I filed.  Does it work for you in Chrome?
https://github.com/angular/material2/issues/1333

No, only some design displays.No data displayed.
On Oct 12, 2016 7:28 PM, "Ross Nordstrom"<EMAIL_ADDRESS>wrote:

@VisualtThreat https://github.com/VisualtThreat You might be seeing the
issue I filed. Does it work for you in Chrome?
#1333 https://github.com/angular/material2/issues/1333
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/issues/675#issuecomment-253220951,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR2ryxz89T9X1dblBrpBkk3bZoW7x0kHks5qzOeXgaJpZM4I0cvd
.

Hi, thanks for your great work. I have 2 questions about the md-datepicker:

Will it support german (or any other) dates? e. g. dd.mm.YYYY?
Will there be a option to use the picker for time only or datetime-combination?

Hi,
Yes ,we will get get these two supports .But the material date picker is
not yet released from officially .
You can refer this https://github.com/angular/material2 .I have used some
other solution that is not working in my case.
On Fri, Oct 21, 2016 at 2:01 PM, Niedermann IT-Dienstleistungen <
<EMAIL_ADDRESS>wrote:

Hi, thanks for your great work. I have 2 questions about the md-datepicker:

Will it support german (or any other) dates? e. g. dd.mm.YYYY?
Will there be a option to use the picker for time only or
datetime-combination?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/issues/675#issuecomment-255324644,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR2ry_HvsBZZOXWN97zqZ5knDYqJvwZQks5q2HhsgaJpZM4I0cvd
.

--
Thanks & Regards,
Manjunath S S
J11240

I have you will develop:

datepicker
timepicker
datetimepicer

all of them supporting:

ISO format as data input or output
custom disply / locale format

A daterange picker would be awesome too!

Hi, I've started to develop a md-datepicker !
It respect many requirements quoted in #1746, like:

Support for accessibility
Support for i18n (RTL)
Support for theming
Following our coding standards
Using existing infrastructure (such as the Overlay service) // I use a dialog, but whatever.

Implementation on MomentJS.

But I have many issues with the dialog and the input:

input: events, it auto focus when dialog close..
dialog: padding of the container.

@jelbourn said:

In particular, with the datepicker, we're not quite ready to go into implementation because a revision for the Material Design spec is in the works.

So ? I have to wait ?
Thanks !

@bastienlemaitre we are indeed waiting on a revised spec for the date-picker.
I'd encourage you to release your datepicker as a standalone package and we can revisit the component in @angular/material after our beta release.

Here a preview of the date selector
https://github.com/angular/material2/pull/1903

Looking forward to this!
It would be awesome if it can also show the week number (at least as an option).

Just as @a5hik @marcoskubis @andvasp @hkusulja mentioned, this 3 components shipped in material2 would be killing features (+md-table):
. datepicker
. timepicker
. datetimepicker

something I noticed is commonly forgotten: make it possible to type the date, maybe with some mask? Most datepickers i was for ng2 are click only! Oh... and a way to clear the field as well...? thanks!! excellent work!

Just a datePicker is not going to solve the problem, a year ago implementing dateTimePicker got removed from backlog promising for version 2.
Do you think is it worth bringing datePicker from material and then a time picker from somewhere else, which has date and time in the same package?

Version 2 would be nice to be able to use date/time picker from a Dialog window. As there is currently not a clear way of doing it currently. I don't care if it hides the origin dialog window, from as long as it restores the origin window and state.

@alobban
You can add this attribute to your show dialogs:
skipHide : true
And they won't close on opening new ones!

@Frly Your project material2 of branch my not build:

TSError: ⨯ Unable to compile TypeScript
tools/gulp/tasks/release.ts (52,10): Type 'Promise<{}>' is not assignable to type 'Promise'.
Type '{}' is not assignable to type 'void'. (2322)
at getOutput (/Users/juliano/Workspace/material2Frly/node_modules/ts-node/src/ts-node.ts:210:13)
at Object.loader (/Users/juliano/Workspace/material2Frly/node_modules/ts-node/src/ts-node.ts:225:23)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (/Users/juliano/Workspace/material2Frly/gulpfile.js:14:1)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)

I did a pull of changes and settings the project material2, but after open http://localhost:4200 the console says:

Unhandled Promise rejection: Template parse errors:
Can't bind to 'value' since it isn't a known property of 'md-input'.

If 'md-input' is an Angular component and it has 'value' input, then verify that it is part of this module.
If 'md-input' is a Web Component then add "CUSTOM_ELEMENTS_SCHEMA" to the<EMAIL_ADDRESS>of this component to suppress this message.

Hi, I've developed md-datepicker and I want to refactor it with:

Support for accessibility
Support for i18n (RTL)
Support for theming
Support for type(i.e. date, tyme and datetime picker)
Following our coding standards
Use Overlay service and dialog.

This is one of the most important component needed for most application development. Really hope to see it prioritizes into the development.

@dharmeshpipariya your date picker looks great! Can your md2 library be used alongside Angular Material 2 at the same time, and only use the date picker component?

Will the datepicker component use the native implementation in mobile devices?

@dharmeshpipariya how about selecting only a whole month\weeks?
because our company needs to select those allot for reports (i am sure there are other use cases as well)

How do i install md2 correct? can't find the system.config.js file in my project

Any ETA? With my team we are about to pick a framework for new version of our product and it uses datepicker in quite few places, was hoping it might be finished sooner in A2 :(.

Any approx. start date for this?

Is it just me (or) the year selection is completely unintuitive in angular 2 datepicker demo?
The year at the top of the dialog does not feel like it user can click/tap on it to change

I checked the datepicker on https://material2-demoapp.firebaseapp.com/date-picker
If the user switches to different months the height differs from month to month. This is because the days in each month are not equal and that the first day is not always monday.
The ux for the next (or previous) button it not that good because it doesn't stay in the same place.
Its better to have the previous and next buttons always in the same place.
If you have any questions please ask.

Page not found.

I see that, thats weird. Just go to https://material2-demoapp.firebaseapp.com/ and then select datepicker then it works.

@gvlekke is there anything relating to the time range?

@rajeshvaya No If you just use the basic datepicker and go to the month june there are 5 rows. When you click on the next button and you go to July there are 6 rows. Of course that isn't a problem but its the cause that the size of the popup is changed and because its centered the previous and next month are pushed more to the top. As a user you want to click multiple times on the next month button without having to move your mouse.

I think it had better to use JavaScript Intl DateTimeFormat API, because it also supports many languages and calendar types(hijri, jalali etc.)

@gvlekke @rajeshvaya

@a8775 thx for the example.

https://material2-demoapp.firebaseapp.com/
What is this ? Is it official ? A side project ? How can I use the date picker presented in it ? It looks like it's exactly what I need.

@Robouste I researched a little bit on that its a side project from someone who have a PR to the material2 library. It won't be merged (yet) because we need to discuss what we want and what problems we need to face.
check this pr #1903
Its good that people already made something like this. So we can detect some problems in the early stage. As example the switching of the months and the next and previous buttons shift in height.

Hi, eagerly awaiting datepicker. I am new to following a project that is still rolling out like this. Any date on when the 'Next Milestone' will be available with datepicker. I could not find an estimated date on this. Thank you for your work on this.

Please make this datepicker accepting and returning European dates too (dd-mm-yyyy).

@riankol I think there need to be a option where you can set how you want to get it back. Or just set it to a country code. And for a bonus you can just set it to a country code and it returns the value formatted out of the box.

Consider the option of choice of time with the help of sliders:
http://t1m0n.name/air-datepicker/docs/#timepicker

I think it maybe looks nice but in usability it's a real disadvantage.  When you know it is 13:16 you don't want to scroll to the right pixel that I'd 13:16.  When the scrollbar is to fast and goes to 17 and then back to 15 it is frustrating to the user.
Some other people have a opinion about this?

Add ability to enter value by input or other

Oké you can do that but why you want to show the scrollbar and don't use it..  Only because it looks cool? Why do you want to use a scrollbar?

+1 gvlekke, by experience the slider is never used.
I discovered this component, it looks pretty cool and more convenient
http://code.promactinfo.com/md2/#/datepicker
But, big problem on it : there is not input (for date or time).
Many thanks for your awesome work.

I agree with nlgi - the datepicker here http://code.promactinfo.com/md2/#/datepicker looks nice and works well.  The 'select time' interface is familiar to android users and also works well.
It does need an option for manually entering a date however, which makes it much quicker for dates far away - for example date of birth.
Also, it's not totally obvious that to change the year, you have to click on the year over in the left pane.  Would be more familiar to click on the month/year just above the calendar to select months/years.
Appreciate all the work on the components so far!

It should also use native android datetime input on phones (would be much faster and nicer).

@zigfry @nlgi  Yeah, it's a great component but it doesn't work on safari < 9. There is some issues in hour/minute picker (touch don't work on safari).

Yes it's for example, angular material team will do better !
;)

Nice inspiration from react toolbox datepicker https://twitter.com/javivelasco/status/831570140265340929

the date range can be a problem when you have long ranges. List out 'from' and 'to' on the datepicker component itelf, with the visual clues like above? Yeah, that would work.

https://demo.vaadin.com ; the datepicker doesn't have to be two seperate calendars . Vaadin has some really nice features though. The ease of picking years is designed very nice.

@automatedenergy I think the scrollable part is cool for the years (but a little bit to fast). Scrolling for months is cool to see, but when you scroll to the next month the first day of the month is never on top. Don't know how other users experience this.

Status update for people who haven't seen the PRs:
Development is ongoing on the datepicker branch: https://github.com/angular/material2/tree/datepicker
It's based on a new spec that's still in-progress (not publicly available) that aims to address some of the issues with the last iteration (what the AngularJS version was based on).

What about the timepicker. Actually, I need datetime picker in my project.

Not perfect, but you have a dateTimePicker here : https://github.com/DSI-HUG/dejajs-components/tree/dev/src/component/date-picker
It's may help !

Too bad that spec is not available @jelbourn I have some UX concerns with what @mmalerba is working on, but given it's not yet finished those might yet be addressed.

@paramsingh88 though I want to add timepicker as well it won't be available in the first version
@fxck It is still in progress, but feel free to open an issue with your concerns and assign to me

I'll just wait until it's at least in master.

Thanks @mmalerba . It sounds like the md-datepicker for Material 2 is close to rolling out.
The timepicker can be added later. No big deal. For now, we can create our own hr and minute select combo boxes and tie them to the datepicker . We just need an official datepicker for Material 2 that works with Angular 2 and beyond.
I probably don't have to tell you that it needs to have a similar look and feel of the familiar Material 1 datepicker, but also takes into account the comments from the above collaborators and stakeholders. It looks like representing the date range and scrolling through years easily will be a major design consideration for you and the Material 2 team.
I still think that the date range can be a single calendar with visual clues that there is a range between two picked dates. Also, for long ranges, putting a 'from' and 'to' associated with the date range would be a good way to let the user know when the date range begins and ends. Maybe we eventually give users the option to go with a single date range calendar or two separate calendars that still has the look and feel of Material 1. I know you are probably dealing with a lot of compatibility considerations as well to make it work with Angular 2 and beyond. My comments here are just user interface design. : )

@mmalerba couple of things that's been bothering me UX/design wise:

when in touch ui mode and clicking thru month, dialog height keep changing causing the button to jump
months changing button is too small for both touch and click
the "down" arrow button has confusing behaviour, it seems to me like it would drop down a select of months/years, rather than to switch mode from days to months
I don't understand duplicity of this

month label is too close to the border

days do not make sense in "months" mode

also while I understand that there probably were reason why abandon the scrolling-type calendar from m1, it was sooooooooooo much user friendlier than having to click thru months

@fxck the infinite scrolling will be added. However, the number one piece of feedback we had from the v1 datepicker was, overwhelmingly, that the virtual scrolling was unintuitive.

Yeah I'm not surprised, but it's one of those things you use once, it's confusing, but you ultimately realize it makes your life easier. But then again, it could look the same as it does right now, only the buttons would trigger scroll down / up.

@fxck thanks, duly noted. I love the infinite scrolling as well, but we'll need to make sure we do it in a way that doesn't hurt performance. the mocks are also still evolving and the latest ones already address some of these issues.

Cool. M1 virtual scroll felt pretty performant, I would have guessed that in angular2 it would be even faster by default, just because it's.. well angular2
I've already seen some experiments https://github.com/rintoj/angular2-virtual-scroll

I don't think I every included the exact link to vaadin's datepicker. It is using a jquery wrapper to run in an Angular app https://vaadin.com/elements/-/element/vaadin-date-picker#demos . The scrolling on this is super fancy. I have never used polymer.

I do like the inertia of the angular2-virtual-scroll a lot.

@jelbourn have a look at https://github.com/IckleChris/ic-datepicker

Hi there, is there an official date for you guys to include this feature in the master ??

@mijaelx64

High level items planned for next few months:
Initial version of datepicker
...

@mmalerba is there going to be a mode, where you'll be able to select a month only, so you could pick say March, 2017, without having to pick a day? it would be handy

@fxck and Month + Year as well.

don't think year would even be possible with the current design.. also if you wanted to select just a year, simple select would be sufficient

Agree! if we just want to select year, What if we want user to select Month and Year?
One more thing would the datepicker return javascript date or something more powerful like moment object?

@fxck Yes I want to add that, probably not in the first version due to challenges with parsing & formatting i18n

any updates on when this will be released..

I've been using https://www.npmjs.com/package/angular2-material-datepicker. Very minimal and some quirks in my locale. Must absolutely have a way to enable/disable selection of dates. A simple callback might be enough.
Date range selection: it not useful for me and I don't recall many cases in which it's used.
Please don't let perfect be the enemy of good; I'm so far very satisfied with ng material 2, good work.

@jelbourn is this now in beta.3

it's not even on master

Any chance an update could be pushed to master or a rebase off master?  I looked at the branch, and I'd like to try it out even if it isn't feature complete, but the date picker branch its quite a few commits behind master at the moment.

Can't wait to see this in the master branch, it's one of those things that are really important in this kind of frameworks, great job (y)

I bet you just didn't PICK a DATE to release this ;)

For those looking for something to use now, ng2-date-picker works along side the @angular/material mdInput directive and is very configurable.

@mmalerba
couple of things:

it is impossible to open datepicker with input focus (technically you can, but since it's using overlay, it will lose focus and clicking to try and focus again will close the overlay).. from my own experience with users, they won't ever find out that clicking the calendar icon opens a calendar, so doing it with focus would be a bit more user friendly
month/day mode still looks like a dropdown / select, still confusing

Damn, it's not really written with extensibility in mind at the moment, is it.. it's gonna be quite a lot of pain and rewriting to add a timepicker.

@jelbourn any update on when this would be added to master?

@xtianus79 soon enough https://github.com/angular/material2/pull/4296#issuecomment-298183090 but seeing the code and design, I'm a bit concerned with long it's gonna take to reach feature completness, datepicker, range picker etc

@fxck As stated before timepicker will not be part of the first version, but will be added later. Please create separate issues for your other concerns so they can be addressed individually

Yeah, I wasn't talking about the first version, I was talking about how long it's probably gonna take to implement all the other features after the first version is released. I'll create issues for all the other features as soon as the first version is in master.

Is the date picker configurable to make it inline rather than a popup? Is it part of the specs?

Will this include the time selection?

@xg-wang it is stated clearly some comments above

the initaliale version don't work correctly in the "fr-fr" localization "dd-mm-yyyy" format

@badre429 it only works properly for the mm-dd-yyyy format https://github.com/angular/material2/issues/4358#issuecomment-299661961

Will this feature in the future also have the ability to have the date picker be on screen? as in, not within a popup or dialog.

@jelbourn @bastienlemaitre I've written a Moment.js DateAdapter, do you want the code?

@arlowhite we do want to include a Moment.js adapter in Material, but we're currently tweaking our packaging structure and holding off until that's done. We want to make sure we don't make Moment.js a dependency for apps that aren't using the adapter. If you want to create an issue for it I can let you know when we're ready.

@mmalerba Moment.js currently is not modular and not quite treeshakable https://github.com/moment/moment/issues/2373 the way you are import moment is like import * as moment from 'moment'; doing this way you ending up having the whole moment.js in your bundle + all locales modules http://stackoverflow.com/questions/25384360/how-to-prevent-moment-js-from-loading-locales-with-webpack/43728394#43728394. In case of using angular-cli you just have to -eject the webpack config to handle that.
Many people just mowing away from moment.js it to https://github.com/date-fns/date-fns because of that.
Currently  in my case I just using moment-mini as I do not want to -eject webpack config, but I might be considering date-fns in the long run.

To clarify: md-datepicker can use any date format; it just needs an appropriate adapter for i18n. We plan on making a moment adapter available since it's relatively popular, but ultimately people can use whatever i18n solution works for them.
(inside Google everyone generally uses goog.Date from the Closure Library)

@mmalerba what if the user imports moment and passes in the moment library in as a constructor arg? new MomentDateAdapter(moment);
If the adapter were to only import { isMoment, Moment } from 'moment'; would that be ok?
Here's my MomentDateAdapter
Issues:

Moment has no narrow format, so I just chop of the first character in those cases.
Have not tested setLocale but I think it should work.
I don't like how parsed dates without a year (e.g. "May 17") default to 2001, so in parse() I default to the current year and default to dates in the past. So people will want to review that logic.

Let me know if you need a CLA or explicit license in order to use this. How do I just declare it public domain?
import { DateAdapter, MdDateFormats } from '@angular/material';
import { isMoment, Moment } from 'moment';
import * as moment from 'moment';

export const MOMENT_DATE_FORMATS: MdDateFormats = {
  parse: {
    dateInput: 'll'
  },
  display: {
    dateInput: 'll',
    monthYearLabel: 'MMMM Y',
    dateA11yLabel: 'LL',
    monthYearA11yLabel: 'MMMM Y'
  }
};

const dateNames: string[] = [];
for (let date = 1; date <= 31; date ++) {
  dateNames.push(String(date));
}

export class MomentDateAdapter extends DateAdapter<Moment> {

  private localeData = moment.localeData();

  getYear(date: Moment): number {
    return date.year();
  }

  getMonth(date: Moment): number {
    return date.month();
  }

  getDate(date: Moment): number {
    return date.date();
  }

  getDayOfWeek(date: Moment): number {
    return date.day();
  }

  getMonthNames(style: 'long' | 'short' | 'narrow'): string[] {
    switch (style) {
      case 'long':
        return this.localeData.months();
      case 'short':
        return this.localeData.monthsShort();
      case 'narrow':
        return this.localeData.monthsShort().map(month => month[0]);
    }
  }

  getDateNames(): string[] {
    return dateNames;
  }

  getDayOfWeekNames(style: 'long' | 'short' | 'narrow'): string[] {
    switch (style) {
      case 'long':
        return this.localeData.weekdays();
      case 'short':
        return this.localeData.weekdaysShort();
      case 'narrow':
        // Moment does not accept format even though @types/moment suggests it does
        return this.localeData.weekdaysShort();
    }
  }

  getYearName(date: Moment): string {
    return String(date.year());
  }

  getFirstDayOfWeek(): number {
    return this.localeData.firstDayOfWeek();
  }

  getNumDaysInMonth(date: Moment): number {
    return date.daysInMonth();
  }

  clone(date: Moment): Moment {
    return date.clone();
  }

  createDate(year: number, month: number, date: number): Moment {
    return moment([year, month, date]);
  }

  today(): Moment {
    return moment();
  }

  parse(value: any, parseFormat: any): Moment {
    let m = moment(value, parseFormat, true);
    if (!m.isValid()) {
      // try again, forgiving. will get warning if not ISO8601 or RFC2822
      m = moment(value);
      console.log(`Moment could not parse '${value}', trying non-strict`, m);
    }
    if (m.isValid()) {
      // if user omits year, it defaults to 2001, so check for that issue.
      if (m.year() === 2001 && value.indexOf('2001') === -1) {
        // if 2001 not actually in the value string, change to current year
        const currentYear = new Date().getFullYear();
        m.set('year', currentYear);
        // if date is in the future, set previous year
        if (m.isAfter(moment())) {
          m.set('year', currentYear - 1);
        }
      }
      return m;
    }
    else {
      return null;
    }
  }

  format(date: Moment, displayFormat: any): string {
    if (date) {
      return date.format(displayFormat);
    }
    else {
      return '';
    }
  }

  addCalendarYears(date: Moment, years: number): Moment {
    return date.clone().add(years, 'y');
  }

  addCalendarMonths(date: Moment, months: number): Moment {
    return date.clone().add(months, 'M');
  }

  addCalendarDays(date: Moment, days: number): Moment {
    return date.clone().add(days, 'd');
  }

  getISODateString(date: Moment): string {
    return date.toISOString();
  }

  setLocale(locale: any): void {
    console.info('setLocale', locale);
    this.localeData = moment.localeData(locale);
  }

  compareDate(first: Moment, second: Moment): number {
    return first.diff(second, 'seconds', true);
  }

  sameDate(first: any | Moment, second: any | Moment): boolean {
    if (first == null) {
      // same if both null
      return second == null;
    }
    else if (isMoment(first)) {
      return first.isSame(second);
    }
    else {
      const isSame = super.sameDate(first, second);
      console.warn('first not a Moment. fallback to super.sameDate()', first, second, isSame);
      return isSame;
    }
  }

  clampDate(date: Moment, min?: any | Moment, max?: any | Moment): Moment {
    if (min && date.isBefore(min)) {
      return min;
    }
    else if (max && date.isAfter(max)) {
      return max;
    }
    else {
      return date;
    }
  }
}

@kuncevic date-fns does not support parsing from given format yet. https://github.com/date-fns/date-fns/pull/375

Is it possible to grab the date displayed in the input? Using an [(ngModel]) on the input element prints a long string instead of what is displayed. For example:

Input displays "5/17/2017"
[(ngModel)] string set on the input is "Wed May 17 2017 00:00:00 GMT-0400 (Eastern Daylight Time)"

@ryanpm40 The ngModel value is not a string, but a date object, you can format it however you want

@mmalerba Silly me- got it, thanks!

Can we have the DatePicker popup when selecting the input (not a button) without having to DI the datepicker and write a function for (click)?
I'm thinking something like [mdDatepickerToggle]="myDatepicker" being an available attribute on inputs as well as on buttons

What are the next steps, now that the initial version is out.

@levitatejay You can hook (focus)="myDatepicker.open()", but it currently steals focus and prevents typing input.

Hi @arlowhite, i was trying to incorporate the MomentDateAdapter that you shown in your earlier comment. However, i am getting an error for MdDateFormats import stating that @angular/material has no exported member 'MdDateFormats'. I have tried importing the same directly from the anguarl/core/typings/datetime/date-formats.d.ts but failed.
I am currently using Material 2.0.0 beta 5 and angular-core 4.2.0 rc.0.
Thanks for your help :)

@n4navin9 This is because MdDateFormats wasn't exported in beta 5 (#4534). That is fixed, but not released. You can either use a not released version or wait for a new release. You also could modify the files directly on your own, but those changes would be gone after reinstalling.

@n4navin9 I'm using material2-builds
You probably need commit https://github.com/angular/material2/commit/58c252f36e2c471cce8805b4948f3c27771f351d
package.json
"@angular/material": "git+https://github.com/angular/material2-builds.git#15b91f6fa8cb99f1d46ac4cb075e4620ad4db486"
(I like to specify the commit so that I know everyone on our team is using the exact same version of material2)

I'm using beta.6, and I wanted to use mdDatepickerToggle directive at the input itself, but I found that only buttons are meant as right targets for it:
selector: 'button[mdDatepickerToggle], button[matDatepickerToggle]',

Why not make it general attribute selector, without constraining the kind of element? Imho, we should be able to use it on (almost?) everything: divs, anchors, buttons, inputs, ...

Hi @jelbourn
First of all, thanks for everyone who did the work ! As always, I still have some issue about timing.
Do you have any time idea, or any link to a roadmap, about all the functionalities of the datepicker list in the datepicker doc ?

in this context, how to check if the user has entered an Invalid String into the input field.? I want to have a check to see if the date is valid or not. this might be a simple one but couldnt manage to make it work. thanks

@angular2fan This is determined by DateAdapter.parse() According to the function doc: @returns The parsed date, or null if date could not be parsed.

I don't know if that can help, but I managed to format the date input value using momentjs like this :
this.form.valueChanges.subscribe(data => {       this.changeFormat(data.badge_endOfValidity);     });
I had to do a subscribe like this because as weird as it is when you pick a date from the date picker the (change) event is not triggered I don't know why. Not sure if it's a bug or it comes from my code.
And in changeFormat method I do :
changeFormat = (date) => {     this.form.value.badge_endOfValidity = moment(date).format('DD/MM/YYYY');   }
Not sure if there is an easier way. If so I would gladly take it but I couldn't manage to understand how DateAdapter work from the tiny doc on it.

@imadhy @angular2fan Try upgrading to the latest version of material2 2.0.0-beta.7 and test your valueChanges code again. I also noticed that change events were not triggered by MdDatepicker in the past, but I think the latest version triggers valueChanges correctly now.

@arlowhite Using (focus)="myDatepicker.open()", I am able to type into the input by clicking a second time on the input after the datepicker dialog pops up.

Is there any date on when time picker will be available?  Could someone recommend the best alternative util this is ready?

@bendg25 i would go with md2 for now

Closing this issue since the initial version is out; additional features should be tracked via their own issues.

so no timepicker?

@david-oyeku still planned, just will be tracked in a separate issues: https://github.com/angular/material2/issues/5648

Shouldn't there be an yearPicker?
it becomes difficult to select you date of birth. Too many clicks for reaching a data which is 20 years old.

For those looking for a angular5/material2 / latest flex time picker, I banged one out last night for a personal project.  Feel free to rip it to your needs.  https://github.com/SteveDunlap13/MaterialTimeControl

SteveDunlap13 Thanks for trying to help but it does not work

You can use amazing time picker (amazing-time-picker) for this purpose, and it is fully compatible with Angular 2-7 and Material design:
https://github.com/owsolutions/amazing-time-picker
Live demo:
https://owsolutions.github.io/amazing-time-picker
Thanks.


zoom threshold feature is missing 20w32a.

I used to use this feature extensively. it does help to make a video interesting. I was thinking to request for a zoom level setting somewhere. Please bring it back if possible.

If I find a convenient way to add zooms, I'll add that feature back in, but in a more expanded way.

I never forgot about this.
The move from primarily rendering with opencv to pyav made this feature harder to do and it will still have to be supported with premiere pro and resolve eventually. However, this is now the most priopized feature right now besides scale, so expect an update soon.

Also, before I forgot, here's how I plan to implement it. Zoom will use --zoom and it will take (start point),(end point),(start zoom),(end zoom),(motion) separated by commas.
Example:
auto-editor example.mp4 --zoom 0,10,100,120,linear

It may also take conditional values:
auto-edtior example.mp4 --zoom loudness>0.08,end_of_cut,100,150,quadratic

and could take multiple arguments (nargs=*)
auto-editor example.mp4 --zoom 0,20,100,120,linear 30,40,100,80,linear

@WyattBlue Thanks. I went through the zooming readme article.
Does it have a capability to do zoom automatically when the loudness is detected, or a motion is present.
I am looking for things which we can do to make this process even less manual.

@lijovklm You can use expressions like "audio>0.05" for example to automatically add zooms.
Full command:
auto-editor example.mp4 "audio>0.03,audio<0.03,1,1.2,centerX,centerY,sine"


Autocomplete: Prompt quality: Find out how we can benchmark completions. Is there a good benchmarking set? Can we build that?

We're currently focusing on runtime analytics instead as we ramp up our user base


subscription or a topic -> subscription on a topic

Fixing typo where a subscription is "on" a topic instead of "or"

@ramya-rao-a : Thanks for your contribution! The author, @clemensv, has been notified to review your proposed change.


Added admin login and register pages

This pull request includes the following changes:

added admin login and register pages
passwords are hashed with scrypt
admin table in sqlite DB

@hemansh Check your PR again

@Pranjal360Agarwal sir i have resolved the conflicts . please give your feedback!!

Again invalid PR


feature/gstreamer-audiosink

A Gstreamer audio sink based on @wuurrd's work.

Tested on Linux 64, Python 2.7. LGTM.


Add tests, cleanup, reorganize mtiLib

I just pushed out code in fontTools.mtiLib that implements Monotype Imaging's OpenType Layout source format (GSUB/GPOS/GDEF):
http://monotype.github.io/OpenType_Table_Source/otl_source.html
The code is rough, doesn't implement feature and lookup addresses by name, has no tests, and lives at the module toplevel.  All of these need to be fixed!
Monotype has some more formats that will probably become Open Source, so moving the OTL code from init to a submodule makes sense.  Or maybe doesn't matter: we'll just introduce more tables to the same parseTable() (or whatever it will get renamed to).

:100:

Just wondering, why the interest in MT's format?

Just wondering, why the interest in MT's format?

Because apparently some of the designers at Monotype can't be bothered with learning Adobe's format, so for some Noto fonts (Indic, East-Asian, etc), we are getting source deliveries in this format.  Although, it doesn't look hand-written to me, so I suppose they have a GUI that saves in this format.
The format is so simple and straightforward mapping of the binary, that I find it useful regardless.  I know I'd be hand-writing a few lookups in it (Turing machines!).  We can also use this, and the decompiler that will be added in feaLib, to convert these to Adobe's format in the future.

fontTools supports other such tables, most notably for the VOLT and VTT data. I think it's a great thing that fontTools is aware of all SFNT tables that are publicly specified or are used by larger groups of people. Since Monotype published the spec, it's possible that they may piblish some tools that compile these tables. But even if the tools to compile these are currently proprietary, it's still good to have them. Also, let's not forget that pretty much all the Google Noto fonts are made by Monotype, and possibly that format is used in the sources.

"Bosma joined Monotype in 1992. His role was to oversee TrueType production and hinting. One of Bosma's first projects for the company's UK office was to manage the production of Greek and Cyrillic core fonts for the Windows 3.1 operating system. Known for his work with non-Latin typefaces, Bosma has produced fonts for Hebrew, Thai, Arabic and Indic scripts. He relies a lot on his own software, including a truetype font editor called FontDame." — http://luc.devroye.org/fonts-33309.html
The name "FontDame" appears in the spec of the Monotype formats.

"Bosma joined Monotype in 1992. His role was to oversee TrueType production and hinting. One of Bosma's first projects for the company's UK office was to manage the production of Greek and Cyrillic core fonts for the Windows 3.1 operating system. Known for his work with non-Latin typefaces, Bosma has produced fonts for Hebrew, Thai, Arabic and Indic scripts. He relies a lot on his own software, including a truetype font editor called FontDame." — http://luc.devroye.org/fonts-33309.html
The name "FontDame" appears in the spec of the Monotype formats.

Indeed.
Monotype released the spec on our request, as we cannot accept source material for Noto in an unpublished proprietary format.  While it would be great if they publish some source in the future, nothing is currently planned for this format as far as I know.

Because apparently some of the designers at Monotype can't be bothered with learning Adobe's format

AFAIK the FDK is not used at Monotype, so there may be no reason to learn its syntax.

Closing.  Testing, API, etc, will be continued in https://github.com/behdad/fonttools/issues/585

Tests integrated now in https://github.com/fonttools/fonttools/pull/787 as well.


Services are global singletons rather than per-editor

monaco-editor version: master
Browser: Chrome and Firefox
OS: MacOS
It's not possible to have a different version of a service for each editor loaded on the page, because they are stored in the global namespace. Instead, the service used by the first editor (potentially the default one) is used for all the editors. This is particularly an issue in single page apps, which might have multiple editors that have very different behaviour.
Playground code that reproduces the issue:
With the first editor enabled
// The Monaco Editor can be easily created, given an
// empty container and an options literal.
// Two members of the literal are "value" and "language".
// The editor takes the full size of its container.

// Uncomment this block to reproduce:
/*
monaco.editor.create(document.getElementById("container"), {
  value: "function hello() {\n\talert('Hello world!');\n}",
  language: "javascript"
});
*/

class MyEditorService {
  addCodeEditor(editor) {
        throw new Error("This error should be thrown, but isn't if the above editor is uncommented");
  }
}

monaco.editor.create(document.getElementById("container"), {
  value: "function hello() {\n\talert('Hello world!');\n}",
  language: "typescript"
}, {
    codeEditorService: new MyEditorService(),
});

As far as I can see, this is because StaticServices is a global singleton https://github.com/microsoft/vscode/blob/master/src/vs/editor/standalone/browser/standaloneServices.ts, so _all gets populated when the first editor instantiated, and this._value in each service entry is populated with the service used by that editor.

I guess it is by design to save memory, unnecessary too many services will eat up all memory. Mostly in editor kind of application we have different views (editors) but with same underlying model and services, think of having diff view, and code split, tabbed pages where each page has one editor for one file but all files are in same project sharing all dependencies.
You can easily solve your issue by wrapping your code inside an IFrame where each IFrame will be its own editor with its own services. You will notice linear 2x memory growth with each IFrame added on the page.

Multiple editors also share things like web workers or text models. So only 1 typescript language service web worker will service any amount of instantiated editors. Also, it is possible to set the same text model to multiple editors, so editors are not isolated from each other and it is an intentional use-case that they can share things between them (text models).


Error: nothing found at DockerDesktop setting "vm"

Running any command that attempts to modify/get any of the settings values in the vm namespace.
For example running ctlptl docker-desktop set vm.kubernetes.enabled false gives the error ctlptl docker-desktop: nothing found at DockerDesktop setting "vm".
I have tried reinstalling docker but no luck.
My ctlptl version is vv0.8.28.

Can you try upgrading ctlptl?
Docker desktop made a breaking change to the settings API, the fix for it is in ctlptl 0.8.34
https://github.com/tilt-dev/ctlptl/releases/tag/v0.8.34


How to acknowledge an external_select block type using lazy listeners on an AWS lambda instance

How can I acknowledge and external_select options request using lazy listeners considering I can't use ack() within the lazy function?
Essentially, I want to be able to do the following but using lazy listeners:
# Example of responding to an external_select options request
@app.options("menu_selection")
def show_menu_options(ack):
    options = [
        {
            "text": {"type": "plain_text", "text": "Option 1"},
            "value": "1-1",
        },
        {
            "text": {"type": "plain_text", "text": "Option 2"},
            "value": "1-2",
        },
    ]
    ack(options=options)

Like:
def respond_to_slack_within_3_seconds(ack):
    ack()

def return_options(ack):
    project_list = send_project_list()
    ack(options = project_list)

def send_project_list():
    pass

def lambda_handler(event, context):
    app.options("project_dropdown")(
        ack=respond_to_slack_within_3_seconds,  # responsible for calling `ack()`
        lazy=[return_options]  # unable to call `ack()` / can have multiple functions
    )

Any help would be appreciated.
Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`

The slack_bolt version
slack-bolt==1.18.0
slack-sdk==3.21.3
Python runtime version
3.8
OS info
AWS lambda handler
Steps to reproduce:
import json
from slack_bolt import App
import os
import logging
from slack_bolt.adapter.aws_lambda import SlackRequestHandler
from slack_bolt.workflows.step import WorkflowStep
from slack_bolt.response import BoltResponse
import requests
import boto3

logging.basicConfig(level=logging.DEBUG)

app = App(
    process_before_response=True,
    token=os.environ.get("SLACK_BOT_TOKEN"),
    signing_secret=os.environ.get("SLACK_SIGNING_SECRET")
)

def edit(ack, step, configure):
    ack()

    blocks = [
        {
            "type": "input",
            "block_id": "task_name_input",
            "element": {
                "type": "plain_text_input",
                "action_id": "name",
                "placeholder": {"type": "plain_text", "text": "Enter a summary"},
            },
            "label": {"type": "plain_text", "text": "Summary"},
        },
        {
            "type": "input",
            "block_id": "task_description_input",
            "element": {
                "type": "plain_text_input",
                "action_id": "description",
                "placeholder": {"type": "plain_text", "text": "Enter a description"},
            },
            "label": {"type": "plain_text", "text": "Description"},
        },
        {
            "type": "section",
            "block_id": "task_assignee",
            "text": {
                "type": "mrkdwn",
                "text": "Assignee"
            },
            "accessory": {
                "action_id": "assignee_dropdown",
                "type": "users_select",
                "placeholder": {
                    "type": "plain_text",
                    "text": "Select users"
                }
            }
        },

        {
            "type": "section",
            "block_id": "project_name",
            "text": {
                "type": "mrkdwn",
                "text": "Pick a project name"
            },
            "accessory": {
                "action_id": "project_dropdown",
                "type": "external_select",
                "placeholder": {
                    "type": "plain_text",
                    "text": "Select a project"
                },
                "min_query_length": 0
            }
        },

    ]
    configure(blocks=blocks)

def execute(step, complete, fail):
    inputs = step["inputs"]
    # if everything was successful
    outputs = {
        "task_name": inputs["task_name"]["value"],
        "task_description": inputs["task_description"]["value"],
        "task_assignee": inputs['task_assignee']['value'],
        "project_name": inputs['project_name']['value']
    }
    complete(outputs=outputs)

    # if something went wrong
    error = {"message": "Just testing step failure!"}
    fail(error=error)

def save(ack, view, update):
    ack()

    values = view["state"]["values"]
    task_name = values["task_name_input"]["name"]
    task_description = values["task_description_input"]["description"]
    task_asignee = values['task_assignee']['assignee_dropdown']
    project_name = values['project_name']['project_dropdown']

    inputs = {
        "task_name": {"value": task_name["value"]},
        "task_description": {"value": task_description["value"]},
        "task_assignee": {"value": task_asignee["value"]},
        "project_name": {"value": project_name['value']}
    }
    outputs = [
        {
            "type": "text",
            "name": "task_name",
            "label": "Task name",
        },
        {
            "type": "text",
            "name": "task_description",
            "label": "Task description",
        },
        {

        }
    ]
    update(inputs=inputs, outputs=outputs)

ws = WorkflowStep(
    callback_id="create_jira_issue",
    save=save,
    execute=execute,
    edit=edit
)

def respond_to_slack_within_3_seconds(ack):
    ack()

def return_options():
    project_list = send_project_list()
    response = {
        "statusCode": 200,
        "headers": {"Content-Type": "application/json"},
        "body": json.dumps({"options": project_list})
    }

    return BoltResponse(
    status=200,  # you can redirect users too
    body=response['body'],
    headers = response['headers']
    )

    #Want to call ack(options = project_list) here

def send_project_list():
    pass

def lambda_handler(event, context):
    app.options("project_dropdown")(
        ack=respond_to_slack_within_3_seconds,  # responsible for calling `ack()`
        lazy=[return_options]  # unable to call `ack()` / can have multiple functions
    )

    app.step(ws)
    slack_handler = SlackRequestHandler(app=app)
    slack_handler.handle(event, context)

Expected result:
When the user carries out the project_dropdown action, I want it to return the response from send_product_list.
My issue is that I can't use ack(options = project_list) within the lazy listener function and I can't figure out a way to return the response normally considering this isn't possible.
Actual result:
All runs fine but the dropdown returns no results

Hi @dwatson15 thanks for writing in 💯
You are correct the lazy functions do not have access to ack(), have you tried using respond() instead?
Our lazy listener documentation elaborate on this, I think this may be what you are looking for!
Let me know if this answers your issue

Hey @WilliamBergamin, I've tried to use respond()instead yeah but running into this issue:
Failed to run an internal function (respond is unsupported here as there is no response_url)

@dwatson15 Your app must return the option results within 3 seconds synchronously using the ack(options=...) method. No other method, including respond() or any other utilities, can perform this task. Therefore, lazy listeners, which do not have access to the ack() method, are not suitable for handling app.options request patterns. I hope this helps to clarify things.

@seratch Ok, the option results should be returned within 3 seconds so maybe the lazy listener is not the best option. It's just I had no success without using lazy listeners so went with this option.
i.e my app's workflow step doesn't work at all without passing process_before_response = True into the app instantiation

Yes, setting process_before_response: true is necessary for your app to run correctly on AWS Lambda. We understand that returning search results within 3 seconds may be challenging in some situations, but this is a stringent requirement of the feature. We hope you'll find a viable solution for it. Let us close this issue now.

Ok, so trying the alternative:
@app.options("project_dropdown")
def handle_project_dropdown(ack):
    print('Invoked')
    options = send_project_list()
    ack(options = options)

This method doesn't seem to work either, any ideas?

@dwatson15 Not sure what you mean by"not working" here but can you double-check if you've set a valid URL (The /slack/events URL works) for select menu? You can set the string at Features > Interactivity & Shortcuts > Select Menu > Options Load URL on the app configuration page (https://api.slack.com/apps/{your app id}/interactive-messages).
Another possibility is your options data structure may be incorrect. Please try the simple static example on the document first: https://slack.dev/bolt-python/concepts#options

@seratch What I meant is that this function gets invoked when a user interacts with the external_select block but the options never get returned with no error.
For example, if I try:
@app.options("project_dropdown")
def handle_project_dropdown(ack):
    print('Invoked')
    options = [
        {
            "text": {"type": "plain_text", "text": "Option 1"},
            "value": "1-1",
        },
        {
            "text": {"type": "plain_text", "text": "Option 2"},
            "value": "1-2",
        },
    ]
    ack(options = options)

like in the example then I can see that the print statement is carried out, but no options are ever returned


pull request for e2e test at 12/13/2016 13:26:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Everywhere we use display: none, we should use the hidden attribute instead

This is a lot simpler to control with React.

Hm not sure why I thought this was a thing... looks like we're not doing this anywhere!


Responsive campaign page

Coverage increased (+0.02%) to 86.443% when pulling f11385e6a6e570070d71023238998e95bd08a669 on responsive_campaign_page into 03b376f11fb7cc8259cf47f51be2fd9ebd693740 on master.

Coverage increased (+0.02%) to 86.443% when pulling 86603c58f12a0cd013577d0e71d221dd000b4b93 on responsive_campaign_page into debce8f03744d9eb9e1f9d9d9f82d8f2c1e5834e on master.


chore: add gapVariables & fix Stack

Changes

Modified Stack to work even when spacing is not specified.
Created a gapVariables function to unify processing with Flex.

Check

[ ] Added new Component

[ ] Added data-* prop and id prop

[ ] Updated Ubie Vitals or Added an update issue(if needed)

LGTM!


feat(c/driver/postgresql): implement statistics API

I'll update the Java/Go schemas separately once this lands.


[bug] Problem using SLSA3+ provenance generator for arbitrary projects

Describe the bug
I am following the instructions for using generator_generic_slsa3 to generate provenances for Oak. The call to the workflow fails with the following error:
Run ./.github/actions/generate-builder/generate-builder.sh
/home/runner/work/_temp/9c89bedb-16a3-4329-be6c-a854f00c4572.sh: line 1: ./.github/actions/generate-builder/generate-builder.sh: No such file or directory
Error: Process completed with exit code 127.

The workflow is running and failing on a pull_request trigger. I know that pull_request triggers are not supported, but since this is the first time I am using this workflow, I was hoping to experiment with it before merging this PR to main. If this is the expected behaviour on pull requests, it would help to have the behaviour described in the documentation.
To Reproduce
Here is the PR that uses the generator_generic_slsa3 workflow: https://github.com/project-oak/oak/pull/3166
This is the failed action: https://github.com/project-oak/oak/runs/7953028722?check_suite_focus=true. The step that fails is the "Generate builder" step.
Screenshots

It is true that this happens because of the pull_request trigger. Because of this, the workflow can't access the OIDC token required to create the Fulcio issued certificate.
Can we support a dry-run option that is only valid for pull_request triggers?
It depends what you would like to test here: If you want to test provenance generation, but not signature validation, we can do something similar to how the CI tests here work in which they do not actually create sigs.

A dry-run option would be great. For the pull-request, I only care about provenance generation.

That would be an easy fix, we can modify IsPresubmitTests():
https://github.com/slsa-framework/slsa-github-generator/blob/1a55da84338004ca26d38b941483c89ab93a695d/internal/utils/presubmits.go#L20
@laurentsimon any oppposition to allowing all pull_request triggers here?

pull_request is already listed, is it not?

pull_request is already listed, is it not?

Must be pull_request AND this repository, I can change to remove the AND

Got it. Is this something we should give an option for so that's it's more explicit? I'm worried users won't realize that signature fails.
/cc @ianlewis

Yes, exactly: only if a dry-run input option is passed in.

That'd work for me. So the dry-run would generate the signatures on triggers that support it, and not for triggers like pull_request. Is my understanding correct?

So the dry-run would generate the signatures on triggers that support it, and not for triggers like pull_request, or no generation in both cases?

I was thinking yes, that it would end up making the workflow compatible with pull_request when run in that.
I agree there's a risk that users may assume this would be valid provenance. No upload or no new release would be done in the case that a dry run is being performed.

I think having a dry-run option is fine if we document it. We should also probably put in some kind of warning in the output that the provenance is not signed.
I'm thinking:

[ ] Add dry-run option to skip signing on pull_request events

[ ] Print a warning "Provenance is not signed in a dry run." in this case.

[ ] Print a friendlier error message run in a pull_request without the dry-run option.

Got it. Is this something we should give an option for so that's it's more explicit? I'm worried users won't realize that signature fails.

Does the signature actually fail, or is it possible to skip it? My assumption was that the provenance is first generated, and then signed in a separate, possibly optional step. If the two must happen together, perhaps the dry-run does not even need to generate the provenance, but just give a signal the the workflow job is set up correctly. For instance, for my PR, what I want to know is that I have configured the permissions correctly, and am passing in the right inputs.
For the permissions, by the way, I had to change  contents: read to contents: write.
Also, the current error message says ./.github/actions/generate-builder/generate-builder.sh: No such file or directory. That does not look like a permission or access problem to me.

Got it. Is this something we should give an option for so that's it's more explicit? I'm worried users won't realize that signature fails.

Does the signature actually fail, or is it possible to skip it? My assumption was that the provenance is first generated, and then signed in a separate, possibly optional step. If the two must happen together, perhaps the dry-run does not even need to generate the provenance, but just give a signal the the workflow job is set up correctly.

Would using the workflow_dispatch trigger solve the problem? You need to merge it in first, but you can then trigger it manually.

For the permissions, by the way, I had to change  contents: read to contents: write.

We fixed the documentation yesterday.

Would using the workflow_dispatch trigger solve the problem?

Good idea. I'll try that, and will update this issue with the result.
I think a dry-run option is still a better solution :)

We fixed the documentation yesterday.

Nice. Thanks.

Thanks for the help. I was able to use the workflow and generate a provenance. My first attempt failed, because I had not set the subject correctly. That is the kind of issue that a dry-run option can detect :)
Should I close this bug, or do you prefer to keep it open for more discussion about a dry-run option? Perhaps https://github.com/slsa-framework/slsa-github-generator/issues/358 is a better place for that discussion?

Let's keep here. Dry-run option is more general than the pull_request. Thanks again for the issue

Related #131 #358


Children of component arguments ($1.foo)

Just realised you can't access properties of arguments passed through to components: http://jsfiddle.net/rich_harris/6n58rwg2/
Filed under nice-to-have

Available in edge :smile:


Accessibility issues

After going to http://airbnb.io/react-dates/?selectedKind=DateRangePicker&selectedStory=default&full=0&down=1&left=1&panelRight=0 and opening the date picker, I can't figure out how to scroll through the months / select a date using the keyboard. It seems like it requires the mouse to be used, meaning it can't easily be used by screen readers.
Additionally, the layer that pops up should have the correct ARIA attributes (role="dialog", aria-expanded).

 We need to fix this, and we've been thinking about the best way to go about this.
The accessibility of our current version of the datepicker has been focused on making sure that despite the custom focus state and presentation of the inputs that you can still type in dates and that they will still be validated appropriately. Currently, if you type in a date into the input, if it is iso format or moment's 'L' format in whatever locale you're in, it will accept the date as soon as it strictly matches that format, move focus forward, and close the datepicker as necessary.
Here are some things we need to do to get full accessibility working on the datepicker though and that are on our roadmap (of course we want more suggestions and best practices too!):

Currently we use placeholders as labels which is not a very good practice! We want to have labels as separate entities above the input (Check In) and placeholders dictating how the input should look (YYYY-MM-DD). Given our current state of affair, we would probably make this optional and allow for inline placeholder labels... for now.
We need to have better error messaging for when you are typing a date! ie if you type 10 characters that we cannot parse as a date, we need to refocus and inform the user somehow that they need to try again instead of just silently failing.
A la https://github.com/airbnb/react-dates/issues/18, we need to be able to close the datepicker on escape --- this probably means have a state where you can be focused on the input and that is separate from the datepicker visibility. We would also need to be able to reopen the datepicker, maybe on arrow-down?
Once the above is settled we need to figure out what exactly the best practices are for how to navigate the calendar. How do you navigate between months? how do you enter focus onto the calendar itself? Does the input maintain focus?

The tl;dr is that we have focused primarily on making sure the input itself is accessible and still have not determined the best way to approach the calendar for this. @backwardok and I have been talking a lot about this in the past weeks!

I guess this is why you have changed the tagline of this library from:
"An accessible, easily internationalizable, mobile-friendly datepicker library for the web."
to
An easily internationalizable, mobile-friendly datepicker library for the web.
@majapw Curious..do you have a timeframe for addressing the accessibility issues?  I notice the same issues are a feature of the date picker on airbnb.com which surprised me (assumming its essentially the same code).
Thanks

Huzzah! Use your keyboard for great profit in v10.0.0 which features keyboard accessibility!
I'm sure we'll be slowly improving things throughout as well.


Add timeout optional argument

This is an extension of the existing API. We don't currently allow users to specify a timeout. Part of the challenge is how we would support the feature as we move from Google API Client 0.8 to 0.9 and eventually to GRPC and GAX. I believe we should be able to support this API across all those implementations.

I did not specify what the default timeout is when none is set, but I could not figure out what the timeout is in Hurley or HTTPClient. The gRPC timeout is infinity. So I felt it best to not say in the documentation exactly what the default timeout was.

This does work across GAPI and GRPC services:
gcloud.storage(timeout: 0.1).buckets.count
#=> Gcloud::Error: execution expired
gcloud.pubsub(timeout: 0.1).topics.count
#=> Gcloud::DeadlineExceededError: 4:Deadline Exceeded

I think moving the timeout configuration from a single global variable to the project instances is a great change.

Sorry... I was not at home.
I saw the code and looks really good. I agree with Chris that moving out the timeout variable from the global configuration is great.
But I have a question... maybe it's a bit stupid... I'm not able to see how Hurley use that timeout_sec. Could you let me know  ? ( It's simple interest in order to know a bit more the flow ).


Option to hide arrows on number inputs

I'm submitting a:

[ ] bug report
[x] feature request

What OS are you using?
Windows 10
What browser(s) is this bug affecting:
Chrome, Firefox
Current behavior:

Firefox arrows ^
Expected behavior:
Add an option to apply css needed to hide arrows when input is set to type='number' since this option is not accessible due to the shadow dom.

Hello, number type is unfortunately not fully supported. Though, we will have a more-comprehensive styling option coming soon, so this may be fixed by that.
In the meantime, I recommend doing what @material/mwc-textfield/mwc-textfield.js is doing in your own file (import base class and styles) and add your own style to fix this. e.g.
import {customElement} from 'lit-element';
import {TextFieldBase} from './mwc-textfield-base.js';
import {style} from './mwc-textfield-css.js';

export {TextFieldType} from './mwc-textfield-base.js';

const hideInputSpinnerStyle = css`
  input[type=number]::-webkit-inner-spin-button {
    -webkit-appearance: none;
  }`

declare global {
  interface HTMLElementTagNameMap {
    'mwc-textfield': TextField;
  }
}

@customElement('mwc-textfield')
export class TextField extends TextFieldBase {
  static styles = [style, hideInputSpinnerStyle];
}

and import that file instead of the file that defines the mwc-textfield custom element

Thanks for looking into this for me.


TTA embedded cussheet causes duplicate scrobbls

foobar 1.5.5
file: 発熱巫女～ず - ''Everflowering'' Masterpieces of Hatsunetsumiko's 2011 - 2013.tta
(I don't know if it will cause any problem, but i will give the files for you to test)
https://mega.nz/folder/8llHQSQB#YbhptauVaJWNsZmlOa5hQA
When I use cue file, it works well. But if I embed cuesheet in the tta file and open the tta file, foobar will scrobble it every second.
like this.

And foobar will send error album artist.
error
https://www.last.fm/zh/music/陽花/'Everflowering'+Masterpieces+of+Hatsunetsumiko's+2011+-+2013
it should be
https://www.last.fm/zh/music/発熱巫女～ず/'Everflowering'+Masterpieces+of+Hatsunetsumiko's+2011+-+2013
How can I solve this problem? Thanks
PS:
I have tried to use other tta files, they repeated those problems.

This seems to be a bug in  foo_input_tta. When playing such a TTA file, the "dynamic info track" event is continuously emitted, even though the artist/title hasn't changed.


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter solax for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.solax
   -
:thumbsup: No errors found
WARNINGS:

[x] :eyes: [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 01 Nov 2024 05:53:43 GMT based on commit 9e787e4ba0cf3b6db02d78043e5aaab555fb6b4a
ioBroker.repochecker 3.1.4

done


AUR Package

Hey there,
I put together a working PKGBUILD using Tauri’s guidelines here. It builds a package for Arch using the .deb release. I’d like to maintain a zmk-studio-bin package in the AUR to make it easier for Arch users to install.
Just wanted to check in and make sure it’s okay before I go ahead and publish it. Let me know if you have any concerns!
Thanks!

Hi, I'd love to try/test an AUR package. Would you mind pushing to a github repo to share?

Just pushed it here. Thanks!

Since it’s been a while without any response, I’m going to go ahead and publish the package to the AUR under the name zmk-studio-bin, as it uses the prebuilt .deb release. If there are any concerns, please don’t hesitate to reach out. Thanks!


Add flask and twilio to extras

Description
Add flask and twilio to extras as similar to other bots requriments.
Fixes #483
Type of change
Please delete options that are not relevant.

[x] Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

[x] Unit Test

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

Same lint issue for failed tests.


Unprimed endpoints return a success response

Hey Steve, hope life is treating you well! :smile:  We need something like PinchHitter for mocking out some interactions with our payment processor, and there are a few features I'd like to add.
First up is this one! If you request an endpoint that hasn't been stored, right now it returns a blank 200 response. For our purposes, it would be better for it to return a 404. This might be similar to #7 (it could be implemented via some such mechanism), but I think this should be the default behavior, and then #7 could be used to get back the old behavior or any other desired behavior.
Whatdya think?

404s as the default makes sense to me.  Definitely better than a 200 and a log message :)

Cool, I'll probably start digging into this tomorrow :heart:


How to use it as BottomNavigationView item??

dynamically set icon for menu item but not showing.

I have the same issue, is there any workaround for this?

Try this. It's working.
https://github.com/abhishektiwarijr/BottomNavigationNameInitialsItem


[6.x] Bump minimum PHP version to v7.2.5

Because we merged https://github.com/laravel/framework/pull/34884, Flysystem indirectly bumps Laravel 6.x to v7.2.5. It makes sense to make this more explicit now through Laravel's own version constraint.

Thanks. Need to also change Laravel.com/docs

@bytestream yup, will do as well as soon as we merge this one 👍


Scoping: loading missing families on receive

Scoping an initial implementation: https://www.notion.so/speckle/Allow-loading-missing-families-on-receive-042fb2209756464a809eeb534ba685d8?pvs=4

closing as dupe of: #1240


The value of "messageid" could not be found from the original message

Reported at Pull-Request #150 , The following email has folded Message-Id field but Sisimai cannot get the value.
https://github.com/azumakuniyuki/p5-Sisimai/blob/master/eg/cannot-parse-yet/no-message-id.txt
[
  {
    "token": "d158c8c23a469026ca008feb7175017f88dee6cf",
    "alias"<EMAIL_ADDRESS>    "lhost": "sample.net",
    "recipient"<EMAIL_ADDRESS>    "action": "failed",
    "softbounce": 0,
    "replycode": "550",
    "rhost": "smtp.sample.co.jp",
    "deliverystatus": "5.1.1",
    "diagnostictype": "SMTP",
    "timestamp":<PHONE_NUMBER>,
    "smtpcommand": "RCPT",
    "addresser"<EMAIL_ADDRESS>    "diagnosticcode": "550 5.1.1<EMAIL_ADDRESS>Recipient address rejected: User unknown in virtual mailbox table",
    "subject": "Test",
    "destination": "sample.co.jp",
    "smtpagent": "Postfix",
    "messageid": "",
    "feedbacktype": "",
    "reason": "userunknown",
    "senderdomain": "sample.net",
    "listid": "",
    "timezoneoffset": "+0900"
  }
]

The email file has been move from eg/cannot-parse-yet to eg/something-is-wrong directory to avoid failure of make test.
https://github.com/azumakuniyuki/p5-Sisimai/blob/master/eg/something-is-wrong/no-message-id-from-pr-150.eml

I have tried to make a patch.
Please evaluate this.
patch-151.zip

@0xcdcdcdcd Thanks for the patch. I've applied the patch to new branch "patch-from-0xcdcdcdcd-for-issue-151" at issue #157