Upgrade to v18.0 triggers the destruction of the entire EKS cluster

Description
I am attempting an upgrade of this module to v18, and after faffing a bit with the parameters to get the plan to work I discovered that it attempts to change the role_arn and vpc_config.security_groups parameters of the EKS cluster itself, which triggers a re-creation of the entire cluster. This seems like a really major problem as it would destroy all deployments in Kubernetes.
I'm not sure if I'm missing something here, the upgrade guide states that resources may need to be recreated and that these resources may also trigger the re-creation of the cluster. Apart from setting prefix_separator to "" (which doesn't work) it doesn't mention anything about solving this issue.
Versions
Terraform v1.0.11
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v3.72.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.7.1
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0
+ provider registry.terraform.io/terraform-aws-modules/http v2.4.1

Module: 18.2.0

Reproduction
Steps to reproduce the behavior: Upgrade from v17.24.0 -> v18.2.0
Code snippet to reprocude
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "18.2.0"

  cluster_name              = var.name
  cluster_version           = var.cluster_version
  subnet_ids                = length(var.control_plane_subnets) > 0 ? var.control_plane_subnets : var.subnets
  vpc_id                    = var.vpc_id
  cluster_service_ipv4_cidr = var.cluster_service_ipv4_cidr

  prefix_separator = ""

  cluster_endpoint_private_access                = true
  cluster_endpoint_public_access                 = false
  cluster_security_group_additional_rules        = merge(
    var.cluster_endpoint_security_group_rules,
    local.cluster_sg_sg_rules,
    local.cluster_sg_cidr_rules
  )
  enable_irsa = true

  cluster_encryption_config = var.encrypted_secrets ? [
    {
      provider_key_arn = aws_kms_key.eks[0].arn
      resources        = ["secrets"]
    }
  ] : null

  cluster_enabled_log_types = var.cluster_logs ? ["api", "audit", "authenticator", "controllerManager", "scheduler"] : null

  self_managed_node_groups        = var.self_managed_node_groups

  self_managed_node_group_defaults = {
    subnets          = length(var.worker_subnets) > 0 ? var.worker_subnets : var.subnets
    root_volume_type = "gp3"
    root_volume_size = "100"
    root_encrypted   = true
  }
}

Terminal Output Screenshot(s)
(Truncated, because there's a LOT of output)
  # module.k8s.module.eks.aws_iam_role.cluster[0] will be destroyed
  - resource "aws_iam_role" "cluster" {
      - arn                   = "arn:aws:iam::XXX:role/dev20211202123117646800000004" -> null
[...]
    }

  # module.k8s.module.eks.aws_eks_cluster.this[0] must be replaced
+/- resource "aws_eks_cluster" "this" {
      ~ arn                       = "arn:aws:eks:eu-west-1:XXX:cluster/dev" -> (known after apply)

        ] -> (known after apply)
[...]
      ~ role_arn                  = "arn:aws:iam::XXX:role/dev20211202123117646800000004" -> (known after apply) # forces replacement
      ~ status                    = "ACTIVE" -> (known after apply)
[...]
      ~ vpc_config {
          ~ cluster_security_group_id = "sg-xxx" -> (known after apply)
          ~ security_group_ids        = [
              - "sg-xxx",
            ] -> (known after apply) # forces replacement
          ~ vpc_id                    = "vpc-xxx" -> (known after apply)
            # (4 unchanged attributes hidden)
        }
        # (1 unchanged block hidden)
    }

v18 version of module is breaking change, please refer to https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/UPGRADE-18.0.md what resources are moved/renamed/removed and you will need to adjust your terraform state as part of upgrade task.

This is what the upgrade guide says about it:
Resource name changes may cause issues with existing resources. For example, security groups and IAM roles cannot be renamed, they must be recreated. Recreation of these resources may also trigger a recreation of the cluster. To use the legacy (< 18.x) resource naming convention, set prefix_separator to "".

I've figured out that this is far from complete, and at least the following prevents the security group from being re-created:
  iam_role_name                          = var.name
  cluster_security_group_name            = var.name
  cluster_security_group_use_name_prefix = true
  prefix_separator                       = ""
  cluster_security_group_description     = "EKS cluster security group."

Now it's just the IAM role left deal with...
I feel that this may be the most important part of the Upgrade documentation, and it's completely missing.

duplicate of #1744 - as @daroga0002 stated, this was a breaking change and there are no guarantees of resources not being re-created/modified if users elect to upgrade from v17.x t o v18.x - thats what a breaking change is

This is what the upgrade guide says about it:
Resource name changes may cause issues with existing resources. For example, security groups and IAM roles cannot be renamed, they must be recreated. Recreation of these resources may also trigger a recreation of the cluster. To use the legacy (< 18.x) resource naming convention, set prefix_separator to "".

I've figured out that this is far from complete, and at least the following prevents the security group from being re-created:
  iam_role_name                          = var.name
  cluster_security_group_name            = var.name
  cluster_security_group_use_name_prefix = true
  prefix_separator                       = ""
  cluster_security_group_description     = "EKS cluster security group."

Now it's just the IAM role left deal with...
I feel that this may be the most important part of the Upgrade documentation, and it's completely missing.

iam_role_arn instead of iam_role_name should do it 👍

For future travelers, I found I had to set create_iam_role = false as well. End result is something like:
  create_iam_role                    = false
  iam_role_arn                       = "arn:aws:iam::000000000000:role/dev00000000000000000000000000"
  prefix_separator                   = ""
  cluster_security_group_name        = var.name
  cluster_security_group_description = "EKS cluster security group."


Error (500):: Cannot read property 'id' of null

Hi I am getting this error as soon as I launch the site, I tried to go to /keystone, logged in and created meetups, talks, users, and came back to home, still the same, I tried this in windows 7, then tried the same in ubuntu VM, getting the error in VM as well.
Error (500)
J:\poc\key\sydjs-site-master\templates\views\site\index.jade:91
89| |  ·
90| a(href='/members') Find your friends in SydJS

91| p.mt-1: a(href="https://twitter.com/sydjs", class="twitter-follow-button", data-show-count="true", data-size="large") Follow @sydjs
92| //- JS
93| block js
94| script.

Cannot read property 'id' of null

My bad I did not publish the meetup, was in draft mode, had to publish it...
modified the line
SydJS.currentMeetupId = !{JSON.stringify(meetup.id)}; //this was causing the 500 error.
to
SydJS.currentMeetupId = !{JSON.stringify(meetup? meetup.id:0)};

Please patch the master branch.  Thanks!

After changing the line above, this error repeats over and over and appears to make the landing page load very slowly initially.
Error finding meetup:  { [CastError: Cast to ObjectId failed for value "0" at path "_id"]
message: 'Cast to ObjectId failed for value "0" at path "_id"',
name: 'CastError',
type: 'ObjectId',
value: '0',
path: '_id' }
GET /api/meetup/0 304 110.366 ms

had to comment out both line 94 & 95 to get this working
	//- 	SydJS.currentMeetupId = !{JSON.stringify(meetup.id)}; ```

This issue was fixed with conditional in commit #71

I receive this error message everytime I go to the website's initial page, and every category I then click on.

what if it will not allow you to update the proper lines?


In reading a file from sharepoint documents, the code was getting as …

Description
The current code encounters an issue when reading files from SharePoint documents. Specifically, the SharePoint site name is retrieved in a Windows-style format (\ instead of /), which causes the replacement logic to fail when attempting to extract data from SharePoint site documents. This pull request addresses this issue by replacing occurrences of / with \ in the file path string.
Issue
When reading files from SharePoint documents, the SharePoint site name is retrieved with backslashes (\) instead of forward slashes (/). This discrepancy causes the file path processing logic to fail, as it expects the SharePoint site name in the Unix-style format (/). Consequently, the expected replacements and subsequent data extraction do not occur.
Solution
To resolve this issue, the proposed solution modifies the file path construction logic. Specifically, it replaces occurrences of / with \ in the file path string. This adjustment ensures that the file path constructed aligns with the format returned by SharePoint, thereby enabling successful data extraction from SharePoint site documents.
Before
        file_path = (
            str(input_file).lstrip("/").replace(f"{self.sharepoint_site_name}/", "", 1)
        )

After
 file_path = (
 str(input_file).lstrip("/").replace(f"{self.sharepoint_site_name}\\", "", 1)
)

Fixes # (issue)
#14734
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[x] No

Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Verify that files can be successfully extracted from SharePoint documents.
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

hi @dous what is pending ?

Hi Team,
Kindly some please review the code change. after this change only i was able to run sharepoint Rag chatbot in my system. i hope this will help others as well

Hi,
I want to discuss on documentation bug. as currently there are two approaches to resolve it.

hi @dosu @dosu.dev / Team
Please have a look into the PR


0.96.0 - Platform not found: device_tracker.nmap_tracker

Home Assistant release with the issue: 0.96
Last working Home Assistant release (if known): 0.95.4
Operating environment (Hass.io/Docker/Windows/etc.): HASS.IO on Rasperry Pi3, 32bit version
Component/platform: https://www.home-assistant.io/components/nmap_tracker/
Description of problem:
Running the Addon "Check Home Assistant Configuration" to check compatibility with the new 0.96 version results in the error below. Testing via TravisCI also triggers the same failure.
[19:16:50] INFO: Installing Home Assistant: latest...
[19:16:50] INFO: Please be patient, this might take a few minutes...
[19:22:34] INFO: Installed Home Assistant 0.96.0
[19:22:34] INFO: Don't worry, this temporary installation is not overwriting your current one.
[19:22:34] INFO: Making a copy of your configuration for checking...
[19:24:50] INFO: Checking your configuration against this version...
[19:33:46] ERROR: The configuration check did not pass!
[19:33:46] ERROR: See the output below for more details.
INFO:homeassistant.util.package:Attempting install of colorlog==4.0.2
Testing configuration at /tmp/config
INFO:homeassistant.util.package:Attempting install of pyHS100==0.3.5
INFO:homeassistant.util.package:Attempting install of tplink==0.2.1
INFO:homeassistant.util.package:Attempting install of sqlalchemy==1.3.5
INFO:homeassistant.util.package:Attempting install of libpurecool==0.5.0
INFO:homeassistant.util.package:Attempting install of aiohttp_cors==0.7.0
INFO:homeassistant.util.package:Attempting install of tuyaha==0.0.2
INFO:homeassistant.util.package:Attempting install of python-nest==4.1.0
INFO:homeassistant.util.package:Attempting install of mutagen==1.42.0
INFO:homeassistant.util.package:Attempting install of hbmqtt==0.9.4
INFO:homeassistant.util.package:Attempting install of distro==1.4.0
INFO:homeassistant.util.package:Attempting install of netdisco==2.6.0
INFO:homeassistant.util.package:Attempting install of bellows-homeassistant==0.8.2
INFO:homeassistant.util.package:Attempting install of zha-quirks==0.0.18
INFO:homeassistant.util.package:Attempting install of zigpy-deconz==0.2.1
INFO:homeassistant.util.package:Attempting install of zigpy-xbee-homeassistant==0.4.0
INFO:homeassistant.util.package:Attempting install of homeassistant-pyozw==0.1.4
INFO:homeassistant.util.package:Attempting install of pyRFXtrx==0.23
Failed config
  General Errors:
    - Platform not found: device_tracker.nmap_tracker

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
device_tracker:
    # https://www.home-assistant.io/components/nmap_tracker/
  - platform: nmap_tracker
    hosts: <IP_ADDRESS>-254

Additional information:
Also being reported by others in the 0.96 release thread: https://community.home-assistant.io/t/0-96-notion-updated-sidebar-advanced-mode/126889

Also referenced in #25270

Indeed, duplicate of #25270. Closing this one.


Write files with BOM.

The extension saves the files as UTF-8, instead of UTF-8-BOM.
Comparing the files result in:
"These files have different encodings. Left file: Unicode (UTF-8) with signature. Right file: Unicode (UTF-8) without signature. You can resolve the difference by saving the right file with the encoding Unicode (UTF-8) with signature."
Options:
1- Add the encoding to File.WriteAllText(), to always save with BOM (Text.Encoding.UTF8).
2- Add one option to the extension to save with/without BOM.
3- Detect the encoding of the original file and preserve it on save.

This is a great suggestion.
(Note to self: check other extensions that write XML files.)

3- Detect the encoding of the original file and preserve it on save.

I've gone for this option

Good choice. The options are in order of difficult level, easier to harder.

This functionality has been incorporated into version 1.2 and is now available from the marketplace.
Please show your support and appreciation by leaving a rating/review: https://marketplace.visualstudio.com/items?itemName=MattLaceyLtd.DontCopyAlways&ssr=false#review-details
Thanks.


Docker image fails to push

I am trying to build and push the demo, but am getting this error:
Building docker image with:
  docker build -t tongueroo/demo-ufo:ufo-2018-10-19T16-35-07-eb0789a -f Dockerfile .
Sending build context to Docker daemon    105kB
Step 1/10 : FROM ruby:2.5.1
 ---> 3c8181e703d2
Step 2/10 : WORKDIR /app
 ---> Using cache
 ---> 6f32cccb1763
Step 3/10 : ADD Gemfile /app/Gemfile
 ---> Using cache
 ---> 834f52b91aa7
Step 4/10 : ADD Gemfile.lock /app/Gemfile.lock
 ---> Using cache
 ---> 47da938fec85
Step 5/10 : RUN bundle install --system
 ---> Using cache
 ---> 85b22cc531ff
Step 6/10 : ADD . /app
 ---> Using cache
 ---> e3e5473cafda
Step 7/10 : RUN bundle install --system
 ---> Using cache
 ---> 876dd45bc20b
Step 8/10 : EXPOSE 4567
 ---> Using cache
 ---> e9f4e3a77519
Step 9/10 : RUN chmod a+x bin/*
 ---> Using cache
 ---> ea6323a7c4e4
Step 10/10 : CMD ["bin/web"]
 ---> Using cache
 ---> 0ad5ec7460fe
Successfully built 0ad5ec7460fe
Successfully tagged tongueroo/demo-ufo:ufo-2018-10-19T16-35-07-eb0789a
Docker image tongueroo/demo-ufo:ufo-2018-10-19T16-35-07-eb0789a built.
Docker build took 0s.
=> docker push tongueroo/demo-ufo:ufo-2018-10-19T16-35-07-eb0789a
The push refers to repository [docker.io/tongueroo/demo-ufo]
0eba6c28d7bc: Preparing
4f8e6bd38f44: Preparing
b4446fb7ed07: Preparing
01c08c0fd4ad: Preparing
6da5e8658278: Preparing
0f8c9434318c: Waiting
a4172301657f: Waiting
3696bfafb5ed: Waiting
dda5ada3fa53: Waiting
f5e615773459: Waiting
9978d084fd77: Waiting
1191b3f5862a: Waiting
08a01612ffca: Waiting
8bb25f9cdc41: Waiting
f715ed19c28b: Waiting
denied: requested access to the resource is denied
ERROR: The docker image fail to push.

I'm admittedly pretty new to Docker, but I believe the issue is that this process does not have permission to push to the Docker repository. However, I'm not understanding how to configure the repository. Is this something that needs to be done within the UFO framework config? How do you configure what repository to push to?

@joeyvmason I see. You're getting a push error because it's my tongueroo dockerhub account. So only I can push to that. Sorry meant the commands to served as an example.
What you probably want to do:
You'll need to create your own dockerhub account and then use docker login command to log into your account and be able to push to that.
Then use your own image name. So something like this:
gem install ufo
git clone https://github.com/tongueroo/demo-ufo.git demo
cd demo
ufo init --image=joeyvmason/demo-ufo
ufo current --service demo-web
ufo ship

Hope that helps. Closing the issue, but feel free to comment additionally.

Here's some additional help info from docker's site: https://docs.docker.com/docker-id/#register-for-a-docker-id

Works perfectly, thank you!

@joeyvmason Happy it worked out. Also if you're new to Docker, your might find blog post helpful: Docker Crash Course Introduction Tutorial: Common Commands


Ensure unique names

Put device address (or equivalent) is all auto-created device names to ensure uniqueness.

Complete in 7.1.0-b6


UI Improvements

After reviewing the UI in the qgis-like-output branch, the following possible improvements came up:

[x] Add header with general Info and Links (as before)
[x] left-align OSM type (otherwise it feels a bit restless…)
[x] Measure should be outside of simple, it's used for advanced as well
[x] Years - Months - Days is a bit unclear - is this the Period for the Time interval below? If so, reorder and add title
[x] What is keep geometry less in the advanced parameters
[x] Rename harmon. geom to harmon geom in output since it only affects output
[x] sort advanced parameters to the bottom
[ ] The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped
[ ] Centroids get deleted once you click "+" again. These should stay, the API even supports multiple radii :)
[ ] any provider change issues a metadata request. This results in a lot of them. Can this be changed only if something in the provider settings changes?
[ ] if a layer contains a lot of points, the log gets rather long. could we add truncation to the geometry part in the log? Everything else is super helpful though!
[ ] if no output is given, a temporary layer should be produced

keep geometry less applies the dict.pop() method on the dictionary created from the response geojson, with "Feature" as an argument. This, when checked, results in the output of an additional table without geometry, containing the same data as the usual output file.

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option.
What is the preferred option?

keep geometry less applies the dict.pop() method on the dictionary created from the response geojson, with "Feature" as an argument. This, when checked, results in the output of an additional table without geometry, containing the same data as the usual output file.

Then this could maybe be called "also save only data" or something similar.
I think the space for a more "lengthy" name is there, and there should be the possiblity to add a "comment" that only gets shown on mouseover.

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option.
What is the preferred option?

Is it possible to keep the Centroids-option and have all other layer inputs as QGIS usually does?
If not, I'd like @mcauer and/or @joker234  to comment on this, since they have a better intuition on what will be more useful to our users.

Regarding: if a layer contains a lot of points, the log gets rather long. could we add truncation to the geometry part in the log?:
I assume we are talking about the View'->'Panels'->'Log Messages' log? From the documentation it seems that this was intentionally kept to full length for debugging reasons. Should we add truncation anyways?

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option.
What is the preferred option?

Is it possible to keep the Centroids-option and have all other layer inputs as QGIS usually does? If not, I'd like @mcauer and/or @joker234 to comment on this, since they have a better intuition on what will be more useful to our users.

I suppose with a days worth of work it could be done.

Regarding: if a layer contains a lot of points, the log gets rather long. could we add truncation to the geometry part in the log?: I assume we are talking about the View'->'Panels'->'Log Messages' log? From the documentation it seems that this was intentionally kept to full length for debugging reasons. Should we add truncation anyways?

Yes, exactly.
If possible, it would be good if only the geometry could be truncated, such that you still have the original request, but your geometry looks like:
points: point1, point2, point3, …

Regarding: May metadata requests when provider changes, this is due to the temporal index being adapted. Isn't this a necessary step?

In general, yes.
It is something that shouldn't change too often, and that could be cached and updated once/day? It might be a bit of premature optimization though, I'm also fine with keeping it how it is currently and adding an issue (to then tackle later on, hopefully).

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option.
What is the preferred option?

Is it possible to keep the Centroids-option and have all other layer inputs as QGIS usually does? If not, I'd like @mcauer and/or @joker234 to comment on this, since they have a better intuition on what will be more useful to our users.

I suppose with a days worth of work it could be done.

I would say it is worth to put some effort and keep interactive centroid option in addition to choose some layer input

fixed in #58


[BUG] Cannot Decode JSON Unexpected Application Error on Paring

Describe the bug
Getting an Unexpected Application Error! when pairing Vultisig 1.0.3 to existing vault.
This is the error:
Unexpected Application Error!
cannot decode vultisig.keygen.v1.ReshareMessage from JSON: Unterminated string in JSON at position 405 (line 1 column 406)
Error: cannot decode vultisig.keygen.v1.ReshareMessage from JSON: Unterminated string in JSON at position 405 (line 1 column 406)
    at zs.fromJsonString (http://wails.localhost/assets/index-d883f60f.js:505:2366)
    at fromJsonString (http://wails.localhost/assets/index-d883f60f.js:1173:15842)
    at http://wails.localhost/assets/index-d883f60f.js:1173:26250
    at Object.useMemo (http://wails.localhost/assets/index-d883f60f.js:43:25846)
    at react_production_min.useMemo (http://wails.localhost/assets/index-d883f60f.js:9:7273)
    at useCurrentJoinKeygenMsg (http://wails.localhost/assets/index-d883f60f.js:1173:26185)
    at JoinKeygenPage (http://wails.localhost/assets/index-d883f60f.js:1208:7027)
    at Nh (http://wails.localhost/assets/index-d883f60f.js:43:18892)
    at Vk (http://wails.localhost/assets/index-d883f60f.js:45:48504)
    at Uk (http://wails.localhost/assets/index-d883f60f.js:45:43758)

To Reproduce
Steps to reproduce the behavior:

On iPhone, goto top left menu icon and navigate to Vault Settings > Reshare
Click on Start Reshare
On the top right, click on the export button
Save QR code somewhere you can access from your Windows computer
Start brand new Vultisig 1.0.3 (brand new installation) on your computer
Select on Secure at top
Select Pair at the bottom
Upload the QR code from step 4 above
Click on Continue
Error shows up.

Expected behavior
Vultisig on Windows should pair with Vultisig on iPhone.
Screenshots

Desktop (please complete the following information):

OS: Windows 11 Pro 64-bit
Version: 24H2 build 26100.2161

Additional context
Add any other context about the problem here.

Thanks @comanche for reporting this


default language Italian

why I install pock is default language is Italian or not English?

has been fiex


Separate RSA key reading from login decoding

Motivation
I had a difficult time writing clean code to programmatically add new RSA keys (#179) due to how tightly-coupled key reading and authentication logic were.
Result
Separates the responsibility of reading RSA keys from authentication logic. It is written in such a way that is open to extensibility and closed for modification so that developers can define custom key read/write implementations without breaking any adjacent systems.
This also introduces a new package io.luna.security.

Hey @notjuanortiz,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 40f9a230-5b29-11ea-b66e-89572c858fbd

Something that still needs to be done so I'll leave this open as a reminder


Have an option for automatically adjusting when system theme or accent color changes

Is your feature request related to a problem? Please describe.
Currently when a theme is not explicitly set, FluentAvalonia will default to the system theme and accent color on Windows 11 (and 10 maybe?), but if the system theme is changed while the application is running it will not be reflected in the application.
Describe the solution you'd like
Fluent apps, at least the ones included in Windows 11, will adjust to system theme and accent color changes even while the apps are already running. There should be an option included in FluentAvalonia to enable this behavior.
Additional context
I believe this can be accomplished by subscribing to the SystemEvents.UserPreferenceChanged event. I was planning on testing this in my own app but I am unable to until #145 is solved.

I've purposely left this up to users to handle, which is why InvalidateThemingFromSystemThemeChanged() exists. It may be a bit more work on users end, but gives you control for how to handle it whether using SystemEvents class or handling it from the WndProc directly. Also, Microsoft.Win32.SystemEvents isn't available on netstandard2.x which makes that unsuitable for use within FluentAvalonia.


Can not convert matlab class 2 python

can not convert or need more args?
thans for help anyway
SyntaxError: Not implemented: classdef
Errors: 1

Hello, I have also found this problem. I think this is because the developer of smop has started in early years and only implemented some simple structures.  The translation for Matlab class is entirely not touched.
But how did you solve the problem later on?

Did you guys find a workaround?

I'm getting the same error
SyntaxError: Not implemented: classdef
Any more thoughts?

Unfortunately, see #71
If anyone found a workaroud to this, I'll be glad to hear about it


errs in make when using libtorch1.9

the code i use is the latest wenet code;
the libraries like fst,glog etc. are the same as previous version (the previous code and libraries can run rightly);
I only chg the libtorch to cxx-1.9-cpu downloaded by my self from official-website;
now, when I make, it report errs like below.
I think maybe you have met the err before.
If you have some knowledge about the err, please give me some suggestions.
Thank a lot.
/home/fc_base/glog-build/libglog.a(logging.cc.o): In function google::(anonymous namespace)::LogFileObject::Write(bool, long, char const*, int)': logging.cc:(.text+0x1443): undefined reference to std::__cxx11::basic_ostringstream<char, std::char_traits, std::allocator >::basic_ostringstream()'
logging.cc:(.text+0x1a0c): undefined reference to std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::basic_ostringstream()' /home/fc_base/glog-build/libglog.a(logging.cc.o): In function google::CheckstrcmptrueImpl[abi:cxx11](char const*, char const*, char const*)':
logging.cc:(.text+0x5f07): undefined reference to std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::basic_ostringstream()' /home/fc_base/glog-build/libglog.a(logging.cc.o): In function google::CheckstrcmpfalseImpl[abi:cxx11](char const*, char const*, char const*)':
logging.cc:(.text+0x60f3): undefined reference to std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::basic_ostringstream()' /home/fc_base/glog-build/libglog.a(logging.cc.o): In function google::CheckstrcasecmptrueImpl[abi:cxx11](char const*, char const*, char const*)':
logging.cc:(.text+0x62e0): undefined reference to std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> >::basic_ostringstream()' /home/fc_base/glog-build/libglog.a(logging.cc.o):logging.cc:(.text+0x64cc): more undefined references to std::__cxx11::basic_ostringstream<char, std::char_traits, std::allocator >::basic_ostringstream()' follow
/home/fc_base/openfst-subbuild/openfst-populate-prefix/lib/libfst.so: undefined reference to `std::__cxx11::basic_ostringstream<char, std::char_traits, std::allocator<EMAIL_ADDRESS>collect2: error: ld returned 1 exit status
CMakeFiles/decoder.dir/build.make:306: recipe for target 'decoder' failed
make[2]: *** [decoder] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/decoder.dir/all' failed
make[1]: *** [CMakeFiles/decoder.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

please refer https://github.com/wenet-e2e/wenet/issues/188


add pyproject.toml to mox init --pyproject and mox pyproject CLI command

https://github.com/Cyfrin/moccasin/pull/79


endDocument possible wrong

https://github.com/Microsoft/vscode-languageserver-node/blob/e3b566dc9e6ae60fa3d6641c3bb480634e4a0ad8/client/src/common/diagnostic.ts#L752
		} else if (document === this.endDocument) {

Document instance could be different on remove, seems it should use uri string for comparison here.

Fixed in https://github.com/microsoft/vscode-languageserver-node/pull/1065


[question] Need explanation about usecase generic class and the way it is implemented

"todo-mvp-clean"
I was reading your source code and trying to find out the way you are thinking about business cases.
I'm wondering how do you come up with "UseCase.java" I really want to learn this way of thinking about projects and practice it on my own project.
Is there any references about this type of designing? book/video/website?

I'll Google that for you!
https://8thlight.com/blog/uncle-bob/2012/08/13/the-clean-architecture.html


Fin won't work with docker compose

Describe the bug
Docker compose mqtt_net is not exposed to soarca container

`

/ ___|/ __ \   /\   |  __ \ / |   /\
| ( | |  | | /  \  | |) | |       /  \
_ | |  | |/ /\ \ |  _  /| |      / /\ \
) | |__| / ____ | | \ | | / ____ \
|__/ _//    __|  _\_____//    _\
{"component":"MAIN","level":"info","msg":"Version: 1.0.0","time":"2024-05-14T09:56:55Z"}
{"component":"MAIN","level":"info","msg":"Buildtime: 2024-03-18T20:15:56+0000","time":"2024-05-14T09:56:55Z"}
{"component":"MAIN","level":"warning","msg":"Failed to read env variable, but will continue","time":"2024-05-14T09:56:55Z"}
{"component":"soarca/internal/controller","level":"info","msg":"Log level is info","time":"2024-05-14T09:56:55Z"}
{"component":"soarca/internal/capability/controller","level":"error","msg":"network Error : dial tcp: lookup mosquitto on <IP_ADDRESS>:53: no such host","time":"2024-05-14T09:57:00Z"}
{"component":"soarca/internal/controller","level":"error","msg":"network Error : dial tcp: lookup mosquitto on <IP_ADDRESS>:53: no such host","time":"2024-05-14T09:57:00Z"}
{"component":"soarca/internal/controller","level":"error","msg":"network Error : dial tcp: lookup mosquitto on <IP_ADDRESS>:53: no such host","time":"2024-05-14T09:57:00Z"}
{"component":"soarca/internal/controller","level":"info","msg":"SOARCA API Trying to start","time":"2024-05-14T09:57:00Z"}`


no module named Client

When I tried this code from the documentation:
from snakebite.client import Client
I got the following error:

from snakebite.client import Client
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named client

Are you sure snakebite is in your python path?

I did a pip uninstall and then easy_install of snakebite and it worked


Document the magical starting-Homu incantation

This information would have turned 45 minutes of troubleshooting this morning into about 5.

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)


Redun pipeline is broken with orjson ~3.8

Hey Rico,
When downloading, installing, and running the main redun pipeline, one gets this error message:

Error message
```
[redun] Execution duration: 0.84 seconds
[redun] *** Execution failed. Traceback (most recent task last):
[redun]   Job eea2a311: File "/Users/falexwolf/repos/bioinformatics-pipeline-tutorial/wf/workflow.py", line 27, in main
[redun]     def main(
[redun]     amino_acid       = 'C'
[redun]     enzyme_regex     = '[KR]'
[redun]     executor         =
[redun]     input_dir        = 'fasta/'
[redun]     max_length       = 75
[redun]     min_length       = 4
[redun]     missed_cleavages = 0
[redun]   Job 299f076a: File "/Users/falexwolf/repos/bioinformatics-pipeline-tutorial/bioinformatics_pipeline_tutorial/lib.py", line 269, in plot_count_task
[redun]     def plot_count_task(input_count: File) -> File:
[redun]     input_count = File(path=data/KLF4.count.tsv, hash=be612cb0)
[redun]   File "/Users/falexwolf/repos/bioinformatics-pipeline-tutorial/bioinformatics_pipeline_tutorial/lib.py", line 278, in plot_count_task
[redun]     counts_plot = plot_counts(output_path, counts)
[redun]   File "/Users/falexwolf/repos/bioinformatics-pipeline-tutorial/bioinformatics_pipeline_tutorial/lib.py", line 108, in plot_counts
[redun]     fig.write_image(tmp_file.path)
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/plotly/basedatatypes.py", line 3829, in write_image
[redun]     return pio.write_image(self, *args, **kwargs)
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/plotly/io/_kaleido.py", line 267, in write_image
[redun]     img_data = to_image(
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/plotly/io/_kaleido.py", line 144, in to_image
[redun]     img_bytes = scope.transform(
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/kaleido/scopes/plotly.py", line 153, in transform
[redun]     response = self._perform_transform(
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/kaleido/scopes/base.py", line 296, in _perform_transform
[redun]     export_spec = self._json_dumps(dict(kwargs, data=data)).encode('utf-8')
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/kaleido/scopes/plotly.py", line 76, in _json_dumps
[redun]     return pio.to_json(val, validate=False, remove_uids=False)
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/plotly/io/_json.py", line 199, in to_json
[redun]     return to_json_plotly(fig_dict, pretty=pretty, engine=engine)
[redun]   File "/opt/anaconda3/envs/base1/lib/python3.9/site-packages/plotly/io/_json.py", line 126, in to_json_plotly
[redun]     opts = orjson.OPT_NON_STR_KEYS | orjson.OPT_SERIALIZE_NUMPY
[redun] AttributeError: partially initialized module 'orjson' has no attribute 'OPT_NON_STR_KEYS' (most likely due to a circular import)
```

I tried downgrading plotly from 5.11 to 5.8, and it didn't help.
I then downgraded orjson from 3.8.1 to 3.5.4, and it fixed the issue.
If other people want to try out your code, to keep your example running, I'd suggest to pin the plotly and orjson versions for the time being - even if it's not great to pin such fundamental dependencies it's much better than an erroring workflow. ☺

Fixed in https://github.com/ricomnl/bioinformatics-pipeline-tutorial/commit/55409956e5d1e92df62b1d330c4009557b6005ea

Great!


Add support for werkzeug-3.0.0

...and in turn Flask 3.0.0 which requires that version.
Werkzeug removed support for passing bytes where str is expected.
See: https://github.com/pallets/werkzeug/commit/5ff0a573f4b78d9724f1f063fb058fd6bc76b24d

Ahh you beat me to it.
For all the people searching for this bug, this is the stacktrace:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/app/venv/lib64/python3.9/site-packages/flask/app.py", line 1478, in __call__
    return self.wsgi_app(environ, start_response)
  File "/app/venv/lib64/python3.9/site-packages/flask/app.py", line 1458, in wsgi_app
    response = self.handle_exception(e)
  File "/app/venv/lib64/python3.9/site-packages/flask/app.py", line 1455, in wsgi_app
    response = self.full_dispatch_request()
  File "/app/venv/lib64/python3.9/site-packages/flask/app.py", line 870, in full_dispatch_request
    return self.finalize_request(rv)
  File "/app/venv/lib64/python3.9/site-packages/flask/app.py", line 891, in finalize_request
    response = self.process_response(response)
  File "/app/venv/lib64/python3.9/site-packages/flask/app.py", line 1270, in process_response
    self.session_interface.save_session(self, ctx.session, response)

  File "/app/venv/lib64/python3.9/site-packages/flask_session/sessions.py", line 362, in save_session
    response.set_cookie(app.config["SESSION_COOKIE_NAME"], session_id,
  File "/app/venv/lib64/python3.9/site-packages/werkzeug/sansio/response.py", line 224, in set_cookie
    dump_cookie(
  File "/app/venv/lib64/python3.9/site-packages/werkzeug/http.py", line 1304, in dump_cookie
    if not _cookie_no_quote_re.fullmatch(value):
TypeError: cannot use a string pattern on a bytes-like object

Which is breaking the functionality of SESSION_USE_SIGNER=True

Hi everyone, is it possible to know when this pull will be accepted and a new version will be released?

Hi everyone, are there any updates?

Hi everyone, is it possible to know when this pull will be accepted and a new version will be released?

Hi to all. A quick check in for any updates... or any solution?

Hello good developers, are there any changes or updates performed on this specific bug?

Hi @hluk thanks for the issue and thanks everyone else for the reminders. @hluk I seem unable to push to your PR branch. Are you able to manually add me as a contributer perhaps?

Hi @hluk thanks for the issue and thanks everyone else for the reminders. @hluk I seem unable to push to your PR branch. Are you able to manually add me as a contributer perhaps?

Sorry, I might have missed some contribution guidelines: Why do you need to push to my fork?
Is there anything you want me to fix in the PR?

No you didn't miss anything, I just wanted to take your implementation a step further and clean up some of the original logic.
Normally maintainers can push to a fork (can see it's checked on the right sidebar) but I think it's an issue with my maintainer permissions in this case.
I've put my additions in (https://github.com/Lxstr/flask-session/tree/werkzeug-3) for now. Let me know your thoughts. Also waiting from input from the team.
Ps. I'm thinking we will merge Black formatting PR before this one, hence the formatting additions.

I've put my additions in (https://github.com/Lxstr/flask-session/tree/werkzeug-3) for now. Let me know your thoughts. Also waiting from input from the team.

I've included your changes in this PR.

just a suggestion for future prs: using merge commits to bring a PR branch up to date results in a quite hard to read git log. it's much better to rebase a PR's branch or do a squash merge if the branch contains merge commits and there's no need to keep individual commits from the PR

Hello, any update on this? Still getting TypeError: cannot use a string pattern on a bytes-like object today.

Hi everyone, are there any updates?

Hi all. A pre-release is imminent, sorry for the delay I've had to go through a lot of historical issues and PRs. If you are able to test the code on the current Development branch and give any feedback that would be appreciated

Hi @Lxstr. Do you have an ETA for the next release with this fix?

Hi all. A pre-release is imminent, sorry for the delay I've had to go through a lot of historical issues and PRs. If you are able to test the code on the current Development branch and give any feedback that would be appreciated

Hi @Lxstr, I am using your development branch on one of my projects, and seems to be stable for my use cases. I Am using Flask==3.0.0 and Werkzeug==3.0.1.
Looking forward to the pre-release. Thanks for the work on this!

Hi all 0.6.0rc1 is now available. Please try in development and let me know if there is any issues.

Using pip-compile it pulled in flask-session==0.6.0 and it seems to work — at least no more TypeError: cannot use a string pattern on a bytes-like object on startup
flask==3.0.1
    # via
    #   -r requirements.in
    #   flask-babel
    #   flask-login
    #   flask-principal
    #   flask-session
flask-babel==4.0.0
    # via -r requirements.in
flask-login==0.6.3
    # via -r requirements.in
flask-principal==0.4.0
    # via -r requirements.in
flask-session==0.6.0
    # via -r requirements.in
werkzeug==3.0.1
    # via
    #   flask
    #   flask-login


Bump bugsnag-android dependency to 5.23.1

Bug fixes

Report the correct filename for native-libs that are loaded from within apk files
#1705

Superseded by #170


Getting onWillFocus() upon tab changes...possible?

My setup is pretty standard - a tab bar with each tab's root being an <ExNavigator>. I update my status bar color accordingly in the onWillFocus() function for each route in my router object. This works great pushing/popping between scenes within each ExNavigator, however when I switch between tabs (to each different ExNavigator component), onWillFocus() is not fired. I realize this isn't really an issue with your library, but I'm wondering if this is possible. I can get the ref of the ExNavigator on tab change no problem, but is there any way I can get the CURRENT route from that, so I can explicitly call onWillFocus() upon tab change?

I believe you can go from the navigator to the navigation context, and then get the current route that way. Something like navigator.context.currentRoute. Longer term I'd like for Navigator to stabilize and then have TabNavigator act as another Navigator.

@ide you're right! Exactly what I needed...thanks!


Nova 4 Update

Refresh this package for Nova 4.

This was just what I was looking for! Hopefully the amout of work to get in Nova 4 compatible won't be too much. Saw a nice writeup of this package here: https://laravel-news.com/manage-maintenance-mode-in-laravel-nova


Fix err.h by changing to new win_safe_err.h

I Sure Hope This Works!

Haha, you got to this before me, I'll revert my commit and then merge this as this is 100% way better.


How to remove Embed button

Hey guys!
Please help me! I need to remove embed button to prevent users from insert embeds objects.
thanks.

You can do:
$('.editable').mediumInsert({
  editor: editor,
  addons: {
    embeds: false
  }
});


new camel-chatscript component

changes for below JIRA
https://issues.apache.org/jira/browse/CAMEL-12955

I don't see the new component. Please close this PR and raise a correct one :-)

Hi,
I forked the main project and checked in the component here : https://github.com/varunblaze/camel/tree/master/components/camel-chatscript


alertmanager: clarify the documentation and sample config

Note: I cannot use google groups as suggested because google groups are blocked at my company.

Looking at: https://github.com/prometheus/alertmanager/blob/master/doc/examples/simple.yml and corresponding section of the documentation..
We have a group of people trying to understand the difference between these two configs and we fail.
Could somebody please try to clarify them again:
  # When the first notification was sent, wait 'group_interval' to send a batch
  # of new alerts that started firing for that group.
  group_interval: 5m

  # If an alert has successfully been sent, wait 'repeat_interval' to
  # resend them.
  repeat_interval: 3h

What did you do?
Tried to use alertmanager as documented
What did you expect to see?
For a continuous condition, I expect to see alerts at a predictable interval, let's say every hour
What did you see instead? Under which circumstances?
Unpredictable alerts: sometimes too many, other times too few. But the complaint is really about the documentation/example, not about the behavior as I am not sure we understood it right and configured it right. Looks like it's a common issue(#642), but I'm still not clear
Environment
Linux

System information:
Linux 2.6.32-754.23.1.el6.x86_64 x86_64

Alertmanager version:
0.18.0

Note that I do not have access to the logs because AM is being hosted by somebody else at the company.

For a continuous condition, e.g. Disk full, and Prometheus firing the same event say every 10 mins, how to configure Alertmanager so it dispatches the alert once an hour

repeat_interval: 1h should do the job. Can you share the Alertmanager configuration and the alerting rule?

Alerting rule:
 - alert: unix_diskfree_usedpct
    expr: count_over_time (( unix_diskfree_usedpct>92) [60m:1m])  >10
    #for: 1h   #this didn't do the trick

Alertmanager configs:
Version: 0.18.0
global:
  resolve_timeout: 5m
  - receiver: alertmanager.yaml:nsq
    group_by:
    - asset
    - filesystemName
    group_wait: 1h
    group_interval: 1h
    repeat_interval: 61m
  group_wait: 1m
  group_interval: 1m
  repeat_interval: 1h

Results:

asset
params
Prometheus' startsAt
alert received

node1
{'filesystemName':   '/fs/hdata'}
2020-02-05   08:54:59
2020-02-05   08:58:25

node1
{'filesystemName':   '/fs/hdata'}
2020-02-05   04:57:59
2020-02-05   07:50:04

node1
{'filesystemName':   '/fs/hdata'}
2020-02-05   04:57:59
2020-02-05   07:31:00

node1
{'filesystemName':   '/fs/hdata'}
2020-02-05   04:57:59
2020-02-05   05:58:25

The problem is: Looking at the configs, I cannot explain why I got the alerts at these particular times.Note that three of them are for the same 'startsAt', and one is for a different one. Either way, this filesystem is full and I'm keeping it that way to observe the behavior of Prometheus and Alertmanager, and the desired behavior is alerts at predictable intervals.
  9.2T  8.5T  254G  98% /fs/hdata

In general I'd recommend a group_interval value (e.g. 5m) lower than repeat_interval value (.e.g. 1h). Are there other labels than asset and filesystemName for the alerts?
Having said that, your alert didn't fire constantly as the startsAt value changes from 04:57:59 to 2020-02-05 08:54:59.

Thanks, I will adjust the config as you recommend.
No, there are no other labels for this alert.
And still, how to explain the three alerts where startsAt=04:57:59 ?

Here's another interesting example. This is a different alert, with different labels - note that filesystemName is not there, so the grouping in the config should not apply.
Note that there are 5 alerts with startsAt = 18:47:59, all received at 19:48:14, or almost exactly an hour later - doesn't look like a coincidence.
But then there are 10 alerts with startsAt =03:05:59, and 5 of them arrive 3 mins later at 03:08:30, and the other 5 at 03:45:37. :astonished:
How to explain this?

asset
params
Prometheus' startsAt
alert received

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   05:32:59
2020-02-07   06:30:18

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:45:37

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:45:37

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:45:37

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:45:37

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:45:37

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:08:30

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:08:30

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:08:30

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:08:30

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   03:05:59
2020-02-07   03:08:30

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-07   01:05:59
2020-02-07   02:08:30

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-06   18:47:59
2020-02-06   19:48:14

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-06   18:47:59
2020-02-06   19:48:14

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-06   18:47:59
2020-02-06   19:48:14

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-06   18:47:59
2020-02-06   19:48:14

hdfs-178721-namenode.datanode.volfails
{'dn':   'd178721-131', 'nn': 'd178721-002'}
2020-02-06   18:47:59
2020-02-06   19:48:14

This is a different alert, with different labels - note that filesystemName is not there, so the grouping in the config should not apply.

The grouping always applies somehow. If filesystemName is not present, Alertmanager will still group the alerts by asset.

Ok, thank you for the correction. This is true, but I think is irrelevant in this case. Looking at the results, how to explain them?

Start Alertmanager with --log.level=debug and share the logs.


chore: Add packit service configuration

Signed-off-by: Tibor Dudlák<EMAIL_ADDRESS>

@lbarcziova Thanks for help fixing the config for packit now it nicely green.

Thanks for updating the PR descriptions. With given content I am clear on what feature this PR is implementing. Also the test jobs are passing. Hence approving.


Should we make sure one way sync is not modifiable on the destination?

In a sync from A to B. What happens if something in B is changed after it is moved from A to B?

As discussed, it's probably an anti-pattern to revert a user's explicit changes in the destination system.
That does mean that the two systems are allowed to go out of sync though.

It may also be hard to track if the ChangeInterpreter uses the 'full scan' approach


ui: added placeholder for mirror registry blank option

The default blank option for the registry on the mirror creation form
was confusing. To keep the same experience with the "Create new
registry" button, the solution was to simply add "Select a registry"
text to work as a placeholder.
bsc#1095255
Signed-off-by: Vítor Avelino<EMAIL_ADDRESS>(cherry picked from commit 7065bbcd70901f58c4235542ea67462b2bc33769)
Backport of #571

 Bug 1095255 - Confusing blank option on registry mirrors while selecting a registry


Upgrading to Grafana 10.1.1 causes all Redshift queries to timeout.

What happened:
Upgrading to Grafana 10.1.1 from 9.5.5 caused all of the previously working Redshift queries to timeout with 504 Gateway Timeout.
Subsequent downgrade to 10.0.3 restored the queries back to the working condition.
What you expected to happen:
Previously working Redshift queries to continue working with Grafana 10.1.1.
How to reproduce it (as minimally and precisely as possible):
Generate a significant number of Redshift queries in a 24 hour period to degrade the response of ListStatements requests;
Background:
Aware that feature flag redshiftAsyncQueryDataSupport = true by default in Grafana 10.1.1 and applied the necessary policy updates.
DEV and UAT environments provided no indication of any Redshift timeout issues during the upgrade to 10.1.1.
Only when we deployed to our production environment where there is a significantly higher number of Redshift requests did we experience timeout issues.
Further investigation revealed redshift-data:ListStatements was being called in the async flow.
Due to our high number of requests and Redshift's 24 hour query result retention, the number of statements in a 24 hour period can reach above 20,000.
This can cause the ListStatements request to take a long time to respond (up to 120 sec), long enough to timeout the Grafana data request.
Please let me know if more information is required.
Screenshots

Anything else we need to know?:
Environment:

Grafana version: 10.1.1
Plugin version: 1.12.1

We are experiencing the same issue after upgrading to 10.1.x. Can we get this resolved asap?

Hi! Sorry to hear that you're having problems, we've prioritized this issue to be worked on soon. Until we fix it, you can configure the redshiftAsyncQueryDataSupport to false (docs for configuring feature toggles and it'll turn off the feature. If you're using Hosted Grafana, you can ask your support person to turn the toggle off for you.

Hi @iwysiu thank you for the suggested workaround. We run our Grafana instance on AWS ECS and use environment variables to set any configurations. However, when we tried to set in ENV it didn't get picked up. I suspect it will only get picked up if RedshiftAsyncQueryDataSupport also exists in the default grafana.ini file.
Is there another way to disable this feature without having to modify or create default grafana.ini file?

Hi @thanissi ! I checked the documentation, and it looks like you if you have Grafana enterprise, you can do runtime settings updates but otherwise, I think you'll have to update the grafana.ini file (docs here). Sorry for the inconvenience!

Hi @thanissi and @sasa-gojic ! I've picked this up to work on, and I'm wondering:

Are you were using open source or enterprise grafana?
If you use enterprise, do you have query caching turned on?
The initial implementation of async queries didn't support grafana query caching and I'm trying to figure out if that's related.

Hi @iwysiu we are using open source version so no access to the caching feature.

Hi @thanissi and @sasa-gojic ! I just released v1.12.2, which should fix this issue.

Hi @iwysiu thank you so much for such a quick turn around. Will try it out.

Hi @iwysiu, thank you, will try it out and let you know the results :)


Regression: formula .pax.gz sources are no longer extracted

A number of formulae that I maintain extract their contents from .pax.gz files. This used to work fine (although it's not clear to me if it's a supported use case) but recently stopped working. A quick git bisect shows that the commit that broke it was 4c80f827a.
Steps to reproduce:
brew create testformula and give it the contents
require 'formula'

class Testformula < Formula
  url 'https://salilab.org/modeller/9.20/modeller-9.20-mac.pax.gz'
  sha256 '161c8d5576a52ead4a90d775549cbc772c33cba71500be33c5e21af75da33729'

  def install
    doc.install "Library/modeller-9.20/ChangeLog"
  end
end

brew update && brew reinstall testformula then fails with
Errno::ENOENT: No such file or directory - Library/modeller-9.20/ChangeLog
(Looking in the build directory, brew downloaded and gunzipped the .pax.gz file, but did not extract it, hence future operations on the files from that archive failed.)
cd /usr/local/Homebrew/ && git checkout f8dc9ef && brew reinstall testformula successfully installs the formula.
cd /usr/local/Homebrew/ && git checkout 4c80f827a && brew reinstall testformula fails in the same way as current master.
If not supporting .pax.gz is intentional, please let me know - I can have my formulae explicitly run pax in the install step (just seems odd since it used to work).
FWIW, the complete formulae that I maintain with this problem are modeller.rb and ifort-runtime.rb at https://github.com/salilab/homebrew-salilab/
Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[x] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[x] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

What you were trying to do (and why)
What happened (include command output)
What you expected to happen
Step-by-step reproduction instructions (by running brew commands)

$ brew doctor
Your system is ready to brew.
$ brew config
HOMEBREW_VERSION: 1.7.3-75-g13869a7
ORIGIN: https://github.com/Homebrew/brew
HEAD: 13869a7558b92b65695f230a3ba4d6f15ccc31da
Last commit: 11 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 6e742cd0efbb32dd6539c661adee4bf636f77146
Core tap last commit: 64 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_DEV_CMD_RUN: 1
HOMEBREW_GIT: git
CPU: octa-core 64-bit kabylake
Homebrew Ruby: 2.3.7 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
Clang: 9.1 build 902
Git: 2.18.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 10.0.2, 1.6.0_65-b14-468
macOS: 10.13.6-x86_64
CLT: <IP_ADDRESS>.1.1528165917
Xcode: 9.4.1

BTW, 'brew audit testformula' does not complain once I give it a suitable desc and homepage. It certainly sees nothing wrong with a .pax.gz url.


Found a typo that causes index files to never load.

Hello! Thank you for making this awesome little app, it's very useful!
I noticed that some of my RVC files that worked on other programs, were not producing the expected results on your client. I tracked the issue down to a typo in this line:
https://github.com/Vali-98/XTTS-RVC-UI/blob/11889f71cd44df66561168211a04434b2619e43c/app.py#L102
It should be rvcs, not rvc. Now .index files are loading just fine, and voices sound more accurate.
I don't know how to submit a pull request but I thought this was probably just as good. Thanks again!

This has been fixed in 0537707bbbf17a536a60c36d174e2f84aba9d040 , thanks for reporting!


Update README

Include data for how to populate sections in the admin portal, how to deploy, and how to do basic maintenance on the README.

Finished with PR #113


Set the rust-version, update edition.

You might as well set the MSRV so you know what the minimum supported rust version is. You may as well also icrement the edition because it requires no changes and the MSRV is supported by the edition increase.
I calculated the MSRV with cargo msrv.

I agree with the sentiment here; edition is straightforward. I have some questions/thoughts on MSRV, however.

reqwest (the primary use case this crate is used alongside) specifies an MSRV of 1.63.0
Using cargo-msrv, I end up w/ a possible MSRV of 1.60.0. This may be due to the version of cargo-msrv; I used the latest release 0.16.2. I had first tried with an older version (0.15.1), it yielded a different answer.
If I enable all features (cargo msrv find --all-features), the MSRV becomes 1.64.0.

Reading around, I haven't found a definitive source on best practices w.r.t. MSRV; in particular in this case, the --all-features:

Enables preserve_order, which brings in hashbrown transitively via indexmap, and this has MSRV 1.64.0. But, it seems we can bump indexmap to 2.6.0, which actually ends up resolving the hashbrown MSRV issue (they downgraded MSRVs).
But, the new serde_ron feature brings in ron, which does unfortunately have a 1.64.0 MSRV.

With the indexmap change, I am inclined to set the MSRV to 1.60.0 (minimum w/o --all-features), in order to keep the MSRV w/i that of reqwest. serde_ron is a new feature, so reqwest does not utilize it (and I would not see it doing so in the future). And since MSRV is transitive, it seems reasonable to specify MSRV as the "out-of-the-box" MSRV (w/o --all-features); enabling optional features such as serde_ron would expose the MSRV of transitive dependencies like ron, effectively bumping cookie_stores MSRV when built this way(?) But, maybe I am thinking of MSRV wrong, philosophically?
Also, I see that you modified this PR to move the MSRV to 1.67.0, so I am a bit curious what version of cargo-msrv you are using, or why you might be coming up with that?

I was using an older version of cargo-msrv, but I updated it and tried running it with --all-featutes, and either way I got 1.67.1. After taking another look at the documentation 1.67 is the same as 1.67.0, so I should actually include the patch version, since it is 1.67.1. Maybe my OS/target makes the difference? I get:
Result:
   Considered (min … max):   Rust 1.31.1 … Rust 1.81.0
   Search method:            bisect
   MSRV:                     1.67.1
   Target:                   x86_64-unknown-linux-gnu

when using the latest version.
https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
https://github.com/rust-lang/rust-clippy?tab=readme-ov-file#specifying-the-minimum-supported-rust-version

Ah, I had not done a cargo update in my local checkout recently. A prior (semver compatible w/ the cookie_store Cargo.toml specified 0.3.16) version of time had a lower MSRV, but the current 0.3.36 has an MSRV of 1.67.0. Doing a cargo update --precise 0.3.20 time (0.3.20 being the newest with a suitable MSRV) and then checking the MSRV will yield 1.64.0 w/ --all-features and 1.63.0 without.
Which goes back to my prior thoughts: I don't think there is a consensus if bumping MSRV should be a semver compatibility break. From cookie_stores perspective, there is a set of semver-compatible packages that will compile on 1.63.0 (or 1.64.0 w/ --all-features).  But a downstream dep, such as time here, could up their MSRV w/ a semver compatible release, which would be picked up by consumer of cookie_store unless the dependency specification were made more restrictive (which I don't think is desirable...), "breaking" our advertised MSRV (naively, at least).
Which is all to say I am fine adding MSRV here, but I'm not sure what the best practice should be. I would like to make it "truly minimal", or at least keep it to reqwest, in that there is a set of semver compatible dependency versions (& all cookie_store code) that will compile under the lower 1.63.0.
I've opened a urlo topic to solicit some community feedback on the general question.

Thanks for the contribution here; in the end the discussion on urlo led me to believe there isn't a best practice here, really. I opted to target 1.63.0 as that is the advertised MSRV of reqwest, and MSRV-changes aren't semver breaking. So, even if we chose what cargo msrv reports today, a downstream dep could make a semver compatible update bumping their MSRV, and we would be "out of date". So this ultimately means the MSRV here is "arbitrarily" chosen with the rationale "a set of downstream semver-compatible dependencies can be chosen which will allow compilation under 1.63.0`.


Error: client.profiles.listAllInResourceGroup is not a function

Received error when trying run code from example (in Azure Function App).
My code:
const RestAzure = require('ms-rest-azure');
const TrafficManager = require('azure-arm-trafficmanager');

module.exports = function (context, myTimer) {
    RestAzure.loginWithServicePrincipalSecret('...', '...', '...').then(credentials => {
        const client = new TrafficManager(credentials, '...');
        return client.profiles.listAllInResourceGroup('test-traffic');
    }).then(profiles => {
        profiles.map(profile => {
            context.log(`found profile : ${profile.name}`);
        });
        context.done();
    }).catch(err => {
        context.log('Error: ' + err.message);
        context.done();
    });
};

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b10f74fe-dc7c-635e-86e8-d4c1094b7c6f
Version Independent ID: 0d5ed087-ba6a-9e65-2eb4-49acae107138
Content: Azure Traffic Manager modules for Node.js
Content Source: docs-ref-services/traffic-manager.md
Service: traffic manager
Product: azure
GitHub Login: @KumudD
Microsoft Alias: kumud

Thanks for reporting @fiftin and apologies for the delay in response
Looks like the page Azure Traffic Manager modules for Node.js for which this issue was logged has been since updated and I don't see the above code snippet there.
Moreover, the azure-arm-trafficmanager package has been deprecated in favor of @azure/arm-trafficmanager
If you still see an error when using the latter, please log an issue at https://github.com/Azure/azure-sdk-for-js

Thanks for reporting @fiftin and apologies for the delay in response
Looks like the page Azure Traffic Manager modules for Node.js for which this issue was logged has been since updated and I don't see the above code snippet there.
Moreover, the azure-arm-trafficmanager package has been deprecated in favor of @azure/arm-trafficmanager
If you still see an error when using the latter, please log an issue at https://github.com/Azure/azure-sdk-for-js


double quote in regex not working

Hi,
having a double quote in regex create problems for language highlighting.
The easiet solution seems to be to update tmLanguage file where matching double quote is changed from " to [^\]" as below. This means using " when double quote is needed in the reqex.
<key>string-constant</key>
		<dict>
			<key>begin</key>
			<string>[^\\]"</string>
			<key>beginCaptures</key>
			<dict>
				<key>0</key>
				<dict>
					<key>name</key>
					<string>punctuation.definition.string.begin.awk</string>
				</dict>
			</dict>
			<key>end</key>
			<string>"</string>
			<key>endCaptures</key>

now with updated file
awk.tmLanguage.zip

Ran into this as well:
{
	last_innner = ""
	url = ""
	while ( match($0, /"[^"]*"/) ) {
		inner = substr($0, RSTART + 1, RLENGTH - 2)
		if ( last_inner == "url" && inner ~ /\/releases\/[0-9]+$/ ) {
			url = inner
		} else if ( last_inner == "tag_name" && inner == option_tag ) {
			print url
			exit
		}
		last_inner = inner
		$0 = substr($0, RSTART + RLENGTH)
	}
}


Any objection to me adding a :skip_verification example to your wiki docs?

I propose adding this section. It appears I have permission to edit that wiki page but I just want to clear it with you @nov. My use case is when I get a key verification failure I'd still like decode token so I can see what went wrong...
Decode without verifying (not recommended, use for debugging only)
id_token = JSON::JWT.decode id_token_string, :skip_verification
puts id_token.to_json

looks good.
thanks

Cool. Done at at https://github.com/nov/json-jwt/wiki
Thanks again for these libraries.


Fix DeepSpeed (ZeRO2 + Pipeline Parallel)

There is an issue with the DeepSpeed library that prevents you from using Pipeline Parallelism and ZeRO Stage 2 at the same time. @leogao2 has a rudimentary patch that allows the code to run (see here) but it causes a significant slowdown. We need to figure out how to do this better. For additional on the problem at hand, see #62
Profiling results from initial patch:

patched, zero2+checkpoint+pipeline: samples/sec: 1159.741, max vram: 3245MiB
patched, zero2+checkpoint: samples/sec: 1120.8568733324405, max vram: 1704MiB

@StellaAthena @leogao2 How is this a significant slowdown? Looks like the SamplesPerSec are quite high, w/ and w/o PP.
Also, what do you attribute the reduction in VRAM to in the case w/o PP?


Two visible levels

Is it possible to have two visible levels at the same time?
Similar to what happens in Mac Os X finder explorer but with only two levels.
The 2nd one would be empty if nothing from the 1st level is selected.

I just realized it doesn't make sense. Not with this layout.

FYI
I've been thinking about this behavior before, but couldn't find any proper usage for it and thus moved it down the roadmap.

Good news, the next version will have a "columns" add-on included.

Great news!


Sponsor API

Hey @junhoyeo ✌ we've integrated a similar (commercial) API at Piloterr! :) Companies can sponsor the project?

Absolutely, @josselinlbe! I'm eagerly awaiting the approval for GitHub Sponsors that I requested a few hours ago. I'm very open to sponsorships, and your support would indeed be invaluable. 😉
I'll let you know when it's live! Also, feel free to reach out to me at<EMAIL_ADDRESS>if you prefer!

This is the first Threads scraper code. This requires no login . I think this will help someone.
https://github.com/iamdeepak92/threads-scraper


State when tilt is open

Hi, is it possible to change the state from closed to open when the tilt is open?

Thaaaanks :)

@fvatter I'm not 100% sure I get what you want.
Are you unable to open the blinds when tilt is fully open?
What is the behavior you're experiencing?

I can open the shutter, but I would like the shutter state to be open when the tilt is open.
now the shutter state is closed when the tilt is open.

Hello, I agree with the OP, I believe that when a cover is closed but the slats are tilted open, the integration should report the cover is open. At least this should be a user option.
In the current implementation, I have an automation that based on conditions closes the cover and sets the slats open during the afternoon (let some light in), and another one that closes the cover at night. In the afternoons when the first one runs, the second one doesn't do anything at night as it considers that the cover is already closed.


Update documentation after API renaming

Examples in existing documents are updated to use the new API.
Include information about the API renaming and the procedure to
upgrade clients in the main api.md document.

/skip-all

/skip-all


Unsupported block type in some resources

Terraform Version
Terraform v0.12.10
Apigee download: terraform-provider-apigee_0.0.16_linux_amd64.tar.gz
On AWS Amazon Linux 2
Affected Resource(s)
Please list the resources as a list, for example:

apigee_company
apigee_developer

Terraform Configuration Files
provider "apigee" {
  org      = "${var.APIGEE_ORG}"
  user     = "${var.APIGEE_USER}"
  password = "${var.APIGEE_PASSWORD}"
}

resource "apigee_company" "helloworld_company" {
   name = "helloworld_company"
   display_name = "some longer description for company"

   attributes {
      DisplayName = "my-awesome-company"
   }
}

Debug Output
2019/10/09 19:11:45 [TRACE] buildProviderConfig for provider.apigee: using explicit config only
2019/10/09 19:11:45 [TRACE] GRPCProvider: GetSchema
2019/10/09 19:11:45 [TRACE] GRPCProvider: PrepareProviderConfig

Error: Unsupported block type

  on main.tf line 11, in resource "apigee_company" "helloworld_company":
  11:    attributes {

Blocks of type "attributes" are not expected here. Did you mean to define
argument "attributes"? If so, use the equals sign to assign it a value.

2019/10/09 19:11:45 [TRACE] <root>: eval: terraform.EvalNoop
2019/10/09 19:11:45 [TRACE] <root>: eval: terraform.EvalNoop

Expected Behavior
Successful plan.
Actual Behavior
What actually happened?
Error as above: Error: Unsupported block type
Steps to Reproduce
Please list the steps required to reproduce the issue, for example:

terraform int
terraform plan

Important Factoids
Failure is on AWS ECS - Amazon Linux 2
v.0.0.16 Darwin version works on on Mac with Terraform v0.11.8

Nevermind, I forgot to do a upgrade on the script.

I needed to update my Terraform script to be v.12 compatible.  I just ran terraform 0.12upgrade and it fixed those issues for me.
So for TF v.11
resource "apigee_company" "helloworld_company" {
  name         = "helloworld_company"
  display_name = "some longer description for company"

  attributes {
    DisplayName = "my-awesome-company"
  }
}

But in TF v.12 the attribute block now needs the = sign:
resource "apigee_company" "helloworld_company" {
  name         = "helloworld_company"
  display_name = "some longer description for company"

  attributes = {
    DisplayName = "my-awesome-company"
  }
}

Oh man, I can't believe I overlooked that.  Thanks!


Phantom signTransaction not defined

Describe the bug
A clear and concise description of what the bug is.
Sporadically, phantom becomes disconnected from the window. It's still defined (window.phantom) but the signTransaction method is now undefined from useWallet() and in other places.
To Reproduce
Steps to reproduce the behavior:
Not really possible to reproduce it. It happens sporadically. However, here is my package.json:
{   "name": "asdasda",   "version": "2.1.0",   "description": "",   "main": "index.js",   "scripts": {     "build": "webpack --config webpack-dist.config.js",     "start": "webpack serve",     "lint": "eslint . --ext .js --ext .ts"   },   "author": "sdsdasd",   "license": "ISC",   "devDependencies": {     "@types/easystarjs": "^0.3.1",     "@types/node": "^20.4.1",     "@typescript-eslint/eslint-plugin": "^5.4.0",     "@typescript-eslint/parser": "^5.4.0",     "copy-webpack-plugin": "^10.0.0",     "css-loader": "^6.8.1",     "eslint": "^8.2.0",     "eslint-config-google": "^0.14.0",     "phaser-import-pipeline": "^3.0.0",     "prettier": "^2.8.8",     "style-loader": "^3.3.3",     "ts-loader": "^9.4.2",     "typescript": "^5.0.4",     "webpack": "^5.64.2",     "webpack-cli": "^4.9.1",     "webpack-dev-server": "^4.5.0"   },   "resolutions": {     "@solana/wallet-standard-wallet-adapter-base": "1.0.1"   },   "dependencies": {     "@project-serum/anchor": "^0.26.0",     "@solana/spl-token": "^0.3.8",     "@solana/wallet-adapter-base": "^0.9.22",     "@solana/wallet-adapter-react": "^0.15.32",     "@solana/wallet-adapter-react-ui": "^0.9.31",     "@solana/wallet-adapter-wallets": "^0.19.17"<EMAIL_ADDRESS>"^1.77.3",     "@types/react": "^18.2.14",     "array-flat-polyfill": "^1.0.1",     "browserify-zlib": "^0.2.0",     "crypto-browserify": "^3.12.0",     "dotenv": "^16.0.3",     "easystarjs": "^0.4.4",     "heap-js": "^2.2.0",     "https-browserify": "^1.0.0",     "immutable": "^4.3.0",     "jsonrepair": "^3.2.0",     "langchain": "^0.0.96",     "node-fetch": "^3.3.1",     "openai": "^3.3.0",     "pg": "^8.11.0",     "phaser": "^3.55.2",     "phaser3-rex-plugins": "^1.60.2",     "react": "^18.2.0",     "react-modal": "^3.16.1",     "sharp": "^0.32.2",     "stream-browserify": "^3.0.0",     "stream-http": "^3.2.0",     "typescript-eslint": "^0.0.1-alpha.0",     "url": "^0.11.1",     "zod": "^3.21.4"   } }
Expected behavior
signTransaction to always be there.
Screenshots

Desktop (please complete the following information):

OS: MacBook Pro 2019 2.6 GHz 6-Core Intel Core i7
Browser Chrome
Version Version 115.0.5790.170 (Official Build) (x86_64)

Lockfile: https://gist.github.com/bhgames/e33684e095003856f99be4862bc49c0e

So, checked window, and it's saying isConnected is false:

So what's interesting is I do have the users connect via the select wallet button. I think this might be a case of some session timer running dry or something. Gonna verify this, don't look into it until I get back to you to save you time.

Just linking origin tweet for future context: https://twitter.com/redacted_j/status/1689027265869299712

@jordansexton Do you still have the tweet please?

I deleted it because I didn't want to cause any panic.


Make sure to compare the new parentReportAction when memoizing Report…

cc @bernhardoj @techievivek @youssef-lr
Details
This was a regression found in https://github.com/Expensify/App/issues/37466
Fixed Issues
$ https://github.com/Expensify/App/issues/37466
Tests

Be online
Request money from someone
Go to the money request details so that the data loads from the API
Go back to the chat that lists all the money requests with that user
Go offline
Go to the money request details again
Verify that the details are visible and the page loads

[ ] Verify that no errors appear in the JS console

Offline tests
Same as above
QA Steps
Same as above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome NOTE: I was unable to test here because of broken emulator
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Testing

Thanks for reporting, those really look the same to me, so maybe it's just hard to spot on video. My gut tells me it's OK and the main thing is really for the page to load while the app is offline. If there is still a delay that needs to be fixed, it's must be with the withOnyx() loading which is probably better tackled as a non-blocker in a separate issue. Is that OK with you?

If there is still a delay that needs to be fixed, it's must be with the withOnyx() loading which is probably better tackled as a non-blocker in a separate issue. Is that OK with you?

Sounds good to me!

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.45-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


lock expiration feature

Motivation
The current implementation works fine in a simple system were the JVM is not likely to be interrupted. But nowadays most production environments are managed by automated platforms for containerised environments.
Anyway, the JVM could be interrupted for any other reason in a no containerised environment.
Specific scenario that forced us to add this feature
In Kubernetes when a pod takes longer than the initialDelay, it's restarted and the JVM is interrupted. Which could happen by any unexpected event, but easily if the execution of the changelogs takes longer than the Kubernetes initialDelay. With the current implementation this leaves the lock held. So, the next time Kubernetes starts the pod, Mongobee won't be able to obtain the lock, so will ignore the changelog. Although the throwExceptionIfCannotObtainLock feature in PR #73 fixes the problem ignoring the changelog if cannot acquire the lock, Mongobee still won't be able to take the lock and the pod will never be started.
Solution provided by this PR
The idea is to add an TTL (expiration time) when the lock is acquired and refresh it while Mongobee is executed. So, no other Mongobee instance will be able to obtain the lock until is released (removed from database) or expired. The lock is refreshed while is used by Mongobee, so it will be kept during the execution. If, for any reason, the lock is lost (which will be a sign of bad implemented changelogs), Mongobee will need to contend for the lock again.
Mongobee configuration parameters

lockAcquiredFor: Time the lock will be held for once it's acquired.

maxTries: Max number of times Mongobee will try to acquire the lock if held by another Mongobee instance.

maxWaitingForLock: Max time Mongobee will wait for the lock in each try.
These parameters will be added to Mongobee by using the method setLockConfig or setLockQuickConfig which use the default configuration and set throwExceptionIfCannotObtainLock to true.

By default, if any of those methods are invoked, it will work as previously with the different that the lock won't be held forever, but for 24 hours instead and won't wait for the lock. So, if the lock is held the execution will be ignored, as previous implementation, or will throw an exception if the parameter throwExceptionIfCannotObtainLock is set to true.
Deprecated
Parameters waitForLock, changeLogLockPollRate and changeLockWaitTime have been deprecated in order to provide a simpler interface and avoid wrong configurations.

Hello @mongobee  and @lstolowski,
we, at  Gamesys, are using Mongobee for several really important projects, which speaks well about your project ;)
However, we are facing several issues due to the lack of this feature. Although I know you are probably busy, we would appreciate if you can review or provide some feedback or review expectation as soon as you can.
Otherwise, we would have to fork it and carry on independently, which is not ideal as we better join efforts.
Thanks


Install the basic structure for React project

Install the basic structure for React project
This branch was used for :

Install the basic configurations of the React project.
Install necessary linters.
Install Jest.
Install Redux.

Issues

close #1
close #13

Thank you @Aduda-Boaz


.github: automatic version upgrader v2

Reintroducing version upgrader.
The previous attempt from https://github.com/prometheus-operator/kube-prometheus/pull/983 and https://github.com/prometheus-operator/kube-prometheus/pull/1002 was correctly creating PRs, but it had issues with triggering CI pipelines. The solution from this PR was tested in https://github.com/thaum-xyz/ankhmorpork and consistently created PRs which were correctly triggering CI (examples: https://github.com/thaum-xyz/ankhmorpork/pull/79 and https://github.com/thaum-xyz/ankhmorpork/pull/81).
Sadly every solution for automated upgrades needs a Personal Access Token from an active Github Account with repo-access. For the time being, I will use my account for this purpose (PRs will appear as if they are created by me), but in the long run, we might want to create a special bot account.
PRs created by this CI workflow will be labeled as kind/enhancement and kube-prometheus-reviewers team will be assigned as reviewers for easier discovery.
PRs will be created on automated-updates branch in this repository and the branch should be deleted automatically when PR is merged.
Manual reproduction of the workflow is also entirely possible on developer machine by running following commands:
scripts/generate-versions.sh > jsonnet/kube-prometheus/versions.json
make --always-make generate

Pinging directly whole @prometheus-operator/prometheus-operator-reviewers for feedback as I feel this is something whole team should be aware of - @s-urbaniak @kakkoyun @metalmatze @paulfantom @brancz @lilic @dgrisonnet @ArthurSens

In regards to this comment, how would it work if the bot was to create a second PR while the first one hasn't been merged yet?

It will update PR with new content


Feature/htmlmap

The html map feature expanded somewhat. This adds the following concepts and changes:

Producers - async actions that produces messages to the application triggered outside of the application, a timer is a simple example.
Actions - is async actions triggered from the update function.
The state of the application has been simplified
Event handling has been simplified, mostly due to the large amount of event types in js that is a mess. Now there is only one event handling type, and it is up to the user to define how the event should be decoded. In time we could add helpers for the most common scenarios.

Nice! 👏
Just one thing: it seems samples/browser/lsystem/lsystem.fsproj sneaked into the PR (probably it was modified by Paket or Forge). Could you please remove it, please?

Merged!


"mirror" selection modes

The current way is it mirrors relative file position. The way I think it should be by default (maybe only) is to mirror relative screen position

doing it the latter way only for now


integration with glide

Is that another nice way to integrate with glide since this is a reliable library for developer to use in the app.
is there a feature that can be requested by the api to setup a scaled 1:1 square sized cropping ?

No integration with glide/picasso/etc. yet
See the FAQ for setting square crop window using aspect ratio.

+1 for Glide


Document creating an awsx.ec2.Vpc in one stack and consuming from another

This is a common scenario when splitting a stack, and due to issues with objects not fully round tripping through JSON serialization and lack of helpers in AWSX, it is somewhat difficult today.
Let's document how this can be done today (as well as address https://github.com/pulumi/pulumi-awsx/issues/385 so that it's easier and then improve the docs).

@lukehoban / @susanev do you have guidance on how someone could do this today? Even if ideal helpers for doing this aren't currently exposed in AWSX.

@gj In general it depends a bit on what exactly you need access to from the other stack.  Very common is to need just the subnet-ids, but in some cases, the VPC id, security group ids, or even in very rare cases things like the NAT Gateway IDs.
The guidance for today is to do what you would have to do if you weren't using AWSX - export the individual resource ids that your other stack depends on, and then import those in the other stack via StackReference.
As far as this issue goes - I'm not entirely certain where we should document this.  I suspect it will belong in the AWSX docs in the registry.


Fix missing form fields

We will need to make corresponding changes to profile, but they can be made later


Not all of the tables listed in the documentation are publicly available

The tables section of the documentation describes several tables that are not (yet) included in the public release: (e.g. http://eicu-crd.mit.edu/eicutables/nurseCharting/). The documentation should clarify which tables are available in the public release.

Added "This table is not currently available in the public dataset" to pages where the table is not yet released.


Relative link resolution to confluence welcome page

I have 2 md files in the same folder
a.md:
<!-- Parent: test -->
# Title A
AAAAAAAA
[Link to b](./b.md)

b.md:
<!-- Parent: test -->
# Title B
BBBBBBBBB
[Link to a](./a.md)

The links cannot be properly resolved when running mark with --title-from-h1. It is mandatory to set the page title via the HTML metadata headers.
I would consider this a bug

I have tried to get some details from --trace and --debug
2022-05-04 11:32:30.172 INFO  processing a.md
2022-05-04 11:32:30.173 TRACE loaded macro "@\\{([^}]+)\\}"
                              ├─ template: ac:link:user
                              ├─ expr: @\{([^}]+)\}
                              └─ config:
                                      Name: ${1}
2022-05-04 11:32:30.173 TRACE found a relative link: full=./b.md filename=./b.md hash=
2022-05-04 11:32:30.173 TRACE rest: GET /rest/api/content/?expand=ancestors%2Cversion&spaceKey=&type=page HTTP/1.1
                              Host: my-confluence.local
                              Authorization: Bearer REDACTED

2022-05-04 11:32:30.401 TRACE rest: HTTP/2.0 200 OK
                              Connection: close
                              Cache-Control: no-store
                              Content-Type: application/json
                              Date: Wed, 04 May 2022 11:32:29 GMT
                              Expires: Thu, 01 Jan 1970 00:00:00 GMT
                              Server: Caddy
                              Set-Cookie: JSESSIONID=REDACTED; Path=/; Secure; HttpOnly
                              Strict-Transport-Security: max-age=31536000;
                              X-Ausername: REDACTED
                              X-Content-Type-Options: nosniff
                              X-Seraph-Loginreason: OK
                              X-Xss-Protection: 1; mode=block

                              {"results":[{"id":"65537","type":"page","status":"current","title":"Learn the wonders of autoconvert (step 7 of 9)","version":{"by":{"type":"anonymous","profilePicture":{"path":"/s/apy6ca/8703/4mhn8a/_/images/icons/profilepics/anonymous.svg","width":48,"height":48,"isDefault":true},"displayName":"Anonymous"},"when":"  ... and so on

2022-05-04 11:32:30.401 TRACE substitute link: "./b.md" -> "https://my-confluence.local/pages/viewpage.action?pageId=65537"

[...]

2022-05-04 11:32:30.564 TRACE rendering markdown:
                              # Title A
                              AAAAAAAA
                              [Link to b](https://confluence.signavio.com/pages/viewpage.action?pageId=65537)

Seems however mark is doing the link substitution, the result from confluence API seems to be wrong

Put an empty line before your h1's
<!-- Parent: test -->

# Title A
AAAAAAAA
[Link to b](./b.md)

If you have markdownlint in place it would ask you to put an empty line after them as well.

I did, it does not make a difference, unfortunately.

Weird. Worked for me.

I think for this to work, we'd need a fundamentally reworked approach as you need to open each linked file and extract its title.


Error using in NextJS (React)

Module not found: Package path . is not exported from package /Users/tmorrow/repo/iot/node_modules/cron-expression-input
(see exports field in /Users/tmorrow/repo/iot/node_modules/cron-expression-input/package.json)

I've been having similar problems in a different setting. I think this needs to change from "./": "./lib/" to ".": "./lib/".


Reland "More EditableText docs (#66864)"

This reverts commit a57f45e0806d5b7fbdd374fc4ade6d154577cc3e. Passed on TGP (the failures seem unrelated).
Description
Revert the whitespaceformatter change. It will be updated in a followup PR (that updates input formatter logic).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Thanks! Looking forward to having this in the 1.22.3 release. This is really the stopper of our project being upgraded to 1.22


Standardise size params: Table component

In this issue It was suggested that adding the size params to variants would standardise variants across all components. But the decision has been made to keep the size ones separate due to the fact it could be confusing about which variants could be set together and which ones couldn't.
The Table component uses size params that need standardisation.
To do this we need a common way of setting the size of these components, some are currently using variants some are not. This would mean that the variant params on the ones that do use them would need to be changed so that they only accept a string and not an array as only one variant would now be able to be set, other than button.

This cannot be applied to this component