Docs: CODE_OF_CONDUCT.md

What type of PR is this?
/kind documentation:- code_of_conduct.md

What this PR does / why we need it:
We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
Which issue(s) this PR fixes:

Fixes #514 #517
Special notes for your reviewer:
if you have further enquiry regarding code of conduct file something need to be change let me know. I'll try my best to fix it.
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@SparkYuan I made pull request request again

@Madhurchandran Commit lint failed. Please amend your commit messages to follow the commit convention.
https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@Madhurchandran Could you please clarify why there is an empty file named "code"? Is it pushed by mistake?

@SparkYuan sorry it pushed by mistake, can i try again and remove this code file then make new pull request.

There is no need to create a new PR.  Here is a tutorial about how to amend your git history: https://www.atlassian.com/git/tutorials/rewriting-history
You can also google these two commands for more details.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 74.553%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/parser.go
3
79.27%

pkg/cmd/apply/options.go
7
72.03%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
6548

Relevant Lines:
8783

💛  - Coveralls

Hi there! I have already added contributing.md. You can add a section Code of Conduct in the contributing.md and ref  to the article CODE_OF_CONDUCT.md you added.

@healthjyk I already created CODE_OF_CONDUCT.md file so you want add reference link in contributing.md file.

@healthjyk I already created CODE_OF_CONDUCT.md file so you want add reference link in contributing.md file.

@Madhurchandran CODE_OF_CONDUCT is necessary. After this PR is merged, you can also modify the contributing.md file to add a reference link.

@healthjyk why we need amend someone already deleted code file which is pushed by mistake.

@healthjyk why we need amend someone already deleted code file which is pushed by mistake.

@healthjyk why we need amend someone already deleted code file which is pushed by mistake.

Your previous commit messages don't pass the Constraints / Commit Lint (pull_request)  validation. You can squash all your commits and modify the commit messages like "docs: add CODE_OF_CONDUCT" to pass this validation. Once the CI validation has been successfully completed, we may proceed to approve this PR.

yes i need help @SparkYuan

I do not have permission to push code to your repository. You can follow the instructions below to create a new PR.

fork a new branch named code-of-conduct from the latest origin main branch in your repo. NOT your current local main branch!!!
create a new file named code_of_conduct.md in the directory kusion/docs
copy your contents into the new file
push this branch to your repo and create a new PR.

feel free to contact me if you have any questions :)

@Madhurchandran Your current commit history is already messy. Please fork a new branch and avoid making further changes based on the current main branch.
You can also join our Slack to communicate more efficiently.

@Madhurchandran Thank you so much for your contributions. I got an idea to help you to fix the commit history. All commits will be squashed before they can merged into the main branch, I can utilize this feature to fix your commits.


It is unclear whether the P2G units produce for domestic use or for export.

Problem description
When I use the P2G flexibility options to reduce my excess electricity my aim is to supply the hydrogen demand, but not to overproduce hydrogen (which results in export).
For example the Urgenda scenario does not contain hydrogen technologies in the transport sector. So, implementing P2G for transport directly results in export of hydrogen.
Hydrogen is used non-energetically in the industry sector. Currently I use some educated guessing/trial-and-error to find the slider setting with which all hydrogen demand in the fertilizer industry sector is supplied through P2G without overproducing (exporting) hydrogen.
In short, it is unclear whether the P2G units produce for domestic use or for export. This can be seen, but requires quite a lot of ETM knowledge of the user.
It is also unclear how many P2G units would sufficient to fulfill the hydrogen demand in the transport and industry sector.
Proposal

Add a calculation/chart that indicates the number of P2G units that would fulfill the hydrogen demand in the transport an industry sector. I do not yet have a proposal for the implementation of this.
Adjust slide/slider text to contain information about the non-energetic use of hydrogen in industry. This is related to #2211.

Removing from milestone as this is more complicated to solve than I anticipated.

This is solved by @MichielDenHaan by changing the existing chart for hydrogen in transport and adding a similar graph for hydrogen in the fertilizer industry. See below.

Nice!
@MichielDenHaan and @jorisberkhout I like this a lot!


How can I get the name of function node or whatever node ?

I try to google on how can I get the name of node itself.
Or where can I find the manual or tutorial to write my code effectively in function node ?

Hi, thanks for raising an issue.
If you check out our contribution guidelines you'll see we prefer to handle this sort of thing on the mailing list, slack team or you could ask a question on Stack Overflow and tag it node-red.
Thanks!


Create an issue template

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates

Demo Airtable Form / Automation:
https://airtable.com/appaZflpqbFjA6pwV/shrK3ZcP577udv9Kq


[DOC] How to contribute docs

Describe the issue linked to the documentation

Since updating our cicd the hot to contribute document hasn't been updated so now I don't know how to reinstall my dev version of sktime.
For example here: https://www.sktime.org/en/stable/get_involved/contributing.html#continuous-integration
there are the steps given:

However, build_tools/requirements.txt doesnt exist anymore.
Suggest a potential alternative/fix

Update.

What do you mean, "the hot"?

Hi @chrisholder, the docs were updated however the link you are referring to points to stable i.e. last tagged/release version of the docs. If you want to access the most recently build docs you need to go the latest i.e. https://www.sktime.org/en/latest/installation.html notice the difference in the url after  https://www.sktime.org/en/.

Hm, should we add a remark on the top of the contribution related pages that latest may be correct in a situation where a recent update to the dev installation, CI, or release process has happened? But that would probably be quite rare?

has ben updated in 2022.


Persist feeds sidebar open/close state

The first thing I do every time I open NNW (if it has been terminated) is hide the feeds sidebar. It would be great if this choice was saved so that this wasn't necessary. It would also make opening the app more seamless between when it had been suspended and when it was actually stopped, since this is what happens if it's just suspended.
iPadOS, but I assume this would be desirable behaviour on macOS as well, even though the mechanics of whether an app is/is not running aren't identical.

Confirmed issue in MacOS as well.  Have to be careful not to quit and lose my crisp two-pane setup!

Years ago, in the days of NetNewsWire of Yore, we persisted collapsed sidebar — if you collapsed it, when you launched the app it would still be collapsed.
Which then led to a significant support issue — people kept reporting that the sidebar had disappeared!
But maybe that’s less of an issue these days. Maybe hiding/showing the sidebar is more of an understood thing. So maybe it wouldn’t be this crazy support burden.

But maybe that’s less of an issue these days. Maybe hiding/showing the sidebar is more of an understood thing. So maybe it wouldn’t be this crazy support burden.

Every native app on my system remembers if I've closed its sidebar, including Mail, Calendar, and Finder. I believe the benefits of adhering to this standard would outweigh any occasional confusion.

@brentsimmons This remains my sole frustration with NetNewsWire, which is otherwise solid and annoyance-free. Every time I launch the app, I'm met with a sidebar I don't want and have explicitly asked not to be shown hundreds, possibly thousands of times.

This was fixed on the main branch when I fixed the rest of the state restoration code.


Pass a few more specs on Windows

The Travis-built ruby-head by RVM is broken again for C-API specs :disappointed:

Thanks for the feedback, @eregon, I wasn't sure how to handle these buggy cases - codifying incorrect behavior in a spec somehow feels wrong, but I guess we can always fix the spec if/when the corresponding bugs get fixed in MRI.

@vais Yes, it's always a bit of a dilemma for me too.
But in the end, if it's there in MRI, it's not so likely to change for old versions, and the best we can do is report the bug and annotate in the spec this is unexpected behavior as you did.
If another implementation has better Windows support and would not pass one of these specs because it did the "right" behavior, then I think we could move to specify the right one and having tags for MRI, but it does not seem the case so far.

3469 files, 23695 examples, 193655 expectations, 176 failures, 152 errors, 0 tagged
to
3469 files, 23686 examples, 193675 expectations, 139 failures, 146 errors, 0 tagged
Good job! Thank you for your help and valuable Windows knowledge :smiley:


ICB Boundary Changes - CCG Abolition

Legislation has passed that will remove CCGs as organisations and replace them with Integrated Care Boards (ICBs) from July 1st. There is more information here on ODS code changes and we expect an update from BSA in due course (which @richiecroker me or @a-d-brown should see in bulletins and update)
There are two different aspects to this a) straightforward organisational changes b) we lose CCG granularity what are we going to do?
a) straightforward organisational changes
Although tedious we have a lot of experience with new/replacing NHS organisations. ICBs are effectively a straight replacement for STPs which is already an organisational layer in OpenPrescribing https://openprescribing.net/stp/  Some jobs I can think of
tidy up nomenclature on site
make sure each STP has the right members
make judgments about CCG alerts like #949
b) we lose CCG granularity what are we going to do
There is no replacement for a CCG which used to number about 200  to be replaced by 42 STPs. As we use CCG deciles to illustrate variation this is problematic. Secondly for a user in an ICB the noise gets worse; for example I used to work in Islington CCG and my members was 35 practices which were easy to scan on a chart and I knew what they were all doing. Now I have NCL STP and when I break down to members I immediately have >100 practices which is much too noisy to meaningfully work with.
I think we need to look at an organisation layer in between practice/PCN and STP

I think it is worth considering whether we continue to publish CCG level data

Sorry I probably wasn't clear on this bit. CCGs disappear legally on July 1st and they will also disappear from NHS data flows as a consequence (unless I have completely missed something?).  We would have to maintain CCG membership manually which we probably cannot do.

I thought the CCG level data was just going to be renamed as 'Sub ICB Location' data - as an interim measure until the 'ICB Place' codes come into existence in April 2023.
That was the impression I'd taken from reading this - but I be misinterpreting it, have a read and see what you reckon!

Well spotted - lets check what BSA plan to do.

From BSA

From 1 July the naming convention for certain organisations will be changing.
•	STP’s (Sustainability and Transformation Partnerships) will be renamed as ICB’s (Integrated Care Boards) e.g. W YORKSHIRE & HARROGATE H&C P/SHIP STP will be changing to NHS WEST YORKSHIRE INTEGRATED CARE BOARD.
•	CCG’s (Clinical Commissioning Groups) will be renamed as SICBL’s (Sub Integrated Care Board Locations) e.g. KIRKLEES CCG will be changing to SICBL of NHS WEST YORKSHIRE ICB X2C4Y.
Organisation codes are not changed, and you will need to be aware of codes when running both ICB and SICBL data.
The changes above will be reflected in May 2022 prescription data when it is published in our ODP around mid-July and the column headings affected by these changes will be renamed accordingly.

Colum headings of STP_NAME and STP_CODE will be renamed to ICB_NAME and ICB_CODE and these changes will be reflected within the following datasets.

Community Prescribing & Dispensing
Prescription Cost Analysis (PCA) Monthly Administrative Data
English Prescribing Dataset (EPD)

Experimental Data Sets
English Prescribing Dataset (EPD) with SNOMED code

English Prescribing Dataset (EPD) and English Prescribing Dataset (EPD) with SNOMED code
CCG names held under the column heading of PCO_NAME will reflect Integrated Care Board Sub Location Names as in the example stated above for KIRKLEES CCG.

The Data Dictionaries that accompany these datasets will also be updated to reflect the above.

Boundary changes which take place from 1 July 2022 will be reflected in the July 2022 prescription data when it is published around mid-September.

@inglesp May 22 English Prescribing data has now been published. This includes the changes mentioned above (except boundary changes mentioned in the last point which should come mid-September).
I've had a quick look through, hopefully shouldn't be too difficult to adjust as I think the only change that will be needed will be the column name changes (STP_NAME -> ICB_NAME) and (STP_CODE -> ICB_CODE).
Please could you have a look into this so we can update the OpenPrescribing data.


:new: Add beautysh as bash/shell beautifier

What does this implement/fix? Explain your changes.
Add beautysh as a beautifier for bash/shell
Does this close any currently open issues?
It should close #451
Any other comments?
I've generated the doc with codo as I've seen in the doc. Quite sure this will make the review a bit harder. I can revert if it's more convenient to generate the doc after the merge.
Checklist
Check all those that are applicable and complete.

[x] Merged with latest master branch
[x] Added examples for testing to examples/ directory
[ ] Travis CI passes (Mac support)
[ ] AppVeyor passes (Windows support)

It looks like Travis CI is not passing: https://travis-ci.org/Glavin001/atom-beautify/jobs/162254176#L1407

Hey, I've taken all the comments into account in a new commit.
Let's see if that fixes the build.

Anything I can do to fix the build on mac/windows ?

Mac is failing on Clojure tests: https://travis-ci.org/Glavin001/atom-beautify/jobs/162591062#L971
Windows is failing on Clojure and more tests: https://ci.appveyor.com/project/Glavin001/atom-beautify/build/764#L514
If you have time to debug and fix them then feel free, however I just require that one of the 3 (Linux in this case) to pass indicating that Atom-Beautify is doing its job, since Node.js is cross platform and the failing tests are because the CI is not installing the appropriate dependencies before running tests.
Ideally, all are passing, however Windows support has always been a problem and often times dependencies are updated and break the builds in future Atom-Beautify commits with unrelated changes. It is difficult to maintain. I settle with ensuring that your Pull Request passes applicable tests at this point and time. Cleaning it up later if I have time.

OK, not sure I can do anything if the problem is on CI side.

I see Linux tests are all passing and you have added a Bash example so it is tested. Once the other little comments are addressed then this is good to go!

Should be OK on last commit. Tell me what you think.

Thank you for contributing!

Published to v0.29.15

Thanks @Glavin001 :)


[3.0] Upgrade slf4j to v2.0.7

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?

Upgrades slf4j to v2.0.7 for Azure Linux 3.0

Change Log

Upgrade to v2.0.7
Change to maven build and install
Remove jcl subpackage as it does not exist in updated version
Add additional files in main package

Does this affect the toolchain?

NO
Test Methodology

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=549497&view=results

can you please run and link a buddybuild?

Have added the link in the top PR test methodology section


[Performance] Check the possibility that improve Triton atomic op performance.

XeTLA atomic op seems to have better performance than Triton atomic rmw op.
We should check if the perf gap do exists, find the gap and see if we can make corresponding changes to improve Triton atomic performance.

From the asm comparison between Triton and XeTLA streamK kernel, the 2 potential optimization points for atomic:

XeTLA uses threads-per-warp 32 by default, triton uses 16 by default for PVC. We can try to change it to 32 for DPAS.
Basically, we need to guarantee there is no index conflict in a warp for AtomicOp while we did not do this in Triton. We can try to do this in kernel implementation or in lowering passes. For StreamK kernel, referring to XeTLA implementation to optimize index arrangement is good to get start.

As offline discussion, switching to https://github.com/intel/intel-xpu-backend-for-triton/issues/2678 since it's more important our goal. Will move back when #2678 is done.


How can I update an existing project to target FSharp.Core 4.5? Project Properties do no list it

Since Visual Studio 15.8, F# 4.5 has been around, but I fail to be able to update existing projects.
Repro steps
Take an existing project (like the one attached: FSharpBug#5988.zip) and attempt to target FSharp.Core 4.5. You'll see the following:

Other projects might even disable changing the target F# Core completely:

Expected behavior
FSharp.Core 4.5 should be selectable from the dropdown. It isn't. It doesn't seem to matter if I change to .NET Framework 4.7.1. Or perhaps I misunderstood and recent versions of FSharp.Core are no longer supported with legacy .NET Frameworks and require .NET Core?
Actual behavior
No possibility to update.
Known workarounds
Probably possible by doing it manually, by updating the fsproj files, but I haven't tried it yet. That's what I did with previous cases, I've been hit by the "greyed out" option before.
Related information
Attached is a solution that exhibits this behavior on my machine (VS 2017 15.9.3). I would be interested in knowing whether this is something local, or whether others can repro this behavior as well.

This by design. Since FSharp.Core is a NuGet package, starting with 4.5.x we deploy via that mechanism as of VS 15.8.
See #4977

Thanks, I must have read that, and forgot.


Regent: metaprogram task annotations

I would like to be able metaprogram task annotations.
Maybe do something like this:
local annotation = rquote end
if variant == "gpu" then
    annotation = rquote __demand(__cuda) end
end

local [annotation] task SomeTask
end

I've been contemplating the syntax for registering task variants, which would support meta-programming better than pragmas. The syntax would look like this:
variant SomeTask_cuda of SomeTask where isa(cuda) end

And of course the idea here is to specify layout constraints for a variant in where ... end. Does this syntax sound reasonable to you, or do you somehow still want to meta-program pragmas?

Just to clarify, here is the syntax:
variant VariantName of TaskName where constraint1, constraint2, ... end

This syntax will work for me.

Just to be clear though, we should also allow metaprogramming the annotations on regular tasks since there are use cases for those besides what you get via variants.

I agree with @elliottslaughter I do actually have a use case for this besides just __demand(__cuda).

@magnatelee I will need this sooner rather than later.

Another useful thing to have with the task variant syntax is a way to allow different task bodies in task variants. So far we assume that a task has only one platform agnostic definition and the compiler automatically generates its variants for different architectures. In scenarios where there exist specialized implementations for certain architectures, such as Singe kernels in S3D, we want to make variants have different implementations.

I think having different task bodies would also be useful for implementing something like the subrank task variant in the Regent version of S3D.
Just looking at the history of this bug report though, as @elliottslaughter said, the original request of being able to metaprogram task annotations would still be useful. If we could do that then for S3D we could have a build option that optimizes for compilation time vs one that optimizes for application run time performance just by changing the annotations on the tasks.
So we should probably do both things.

I think we should split this issue into two: one that matches the current title, and one to add an explicit task variant syntax.


Parquet-format interns strings when reading filemetadata

Parquet-format when deserializing metadata will intern strings. References I could find suggested that it had been done to reduce memory pressure early on. Java (and jvm in particular) went a long way since then and interning is generally discouraged, see https://shipilev.net/jvm-anatomy-park/10-string-intern/ for a good explanation. What is more since java 8 there's string deduplication implemented at GC level per http://openjdk.java.net/jeps/192. During our usage and testing we found the interning to cause significant gc pressure for long running applications due to bigger GC root set.
This issue proposes removing interning given it's questionable whether it should be used in modern jvms.
Reporter: Robert Kruszewski / @robert3005
Assignee: Robert Kruszewski / @robert3005
PRs and other links:

GitHub Pull Request #92

Note: This issue was originally created as PARQUET-1261. Please see the migration documentation for further details.

Robert Kruszewski / @robert3005:
This isn't really a parquet issue - after thorough investigation it's clear that interning is the best way to save space. It's only CMS that has bad time dealing with it


Remove handle_post_results

handle_post_results is depreciated and an internal function to begin with. It can be safely disposed of

Coverage increased (+0.53%) to 77.26% when pulling bbd74060a74435a375b63433815eeda6686f2efd on remove_handle_post_results into e0abeaa24f0fb69aa3492ac9a92ffbb80a919abf on master.


Update “forms”

Automatically generated by Netlify CMS
(The page accidentally got Markdown code entered on the rich text panes. Fixing that quickly.)

@designlanguage @cfarm @contolini Looking for one reviewer to compare against the currently deployed https://cfpb.github.io/design-system/foundation/forms


define target interface

What's a target? Can't this just be the same as a normal computer? All I think we'd ever need a MAC and IP address.
What's interesting for the future however is having a table to keep all the things we've exploited together


fix(awslint): Add cloudformationResource field to DocSpec interface.

Add cloudformationResource field to the DocSpec interface, used by CDK codegen.
Related to https://github.com/aws/aws-cdk/issues/26839.

The PR title also needs some tweaking. Different scope and in the context of this repo, I'd say this will be a feature.


Add autocomplete for brew

I was familiarizing myself with the code and I thought I'd write an autocomplete plugin while I'm at it. Let me know if it needs any changes.

Looks good to me! Just needs to merge master.

👍


GET /session/account/profile: "404 Admins have no profiles" error

This is a starter issue. It’s part of https://github.com/hoodiehq/hoodie-server-account/issues/83
:octocat:  Your First Pull Request?
We would like to take the opportunity to invite someone who did not yet contribute to Hoodie to work on this issue. Follow @YourFirstPR on Twitter for more of these issues across many open source projects :)
:bug: The Bug
We differentiate between normal user accounts that you can sign up for with PUT /session/account and admin accounts which are configured in the app configuration. The latter have no account or profile, they are only used to manage other accounts and other app settings.
GET /session/account/profile is already implemented correctly, the only problem is that we currently respond with a 403 status code, although after discussing it we agreed that 404 would be the better error code here.
:dart: The goal
For admin users, GET /session/account/profile should respond with 404 Not found and the error message "Admins have no profiles"
:clipboard: Step by Step

[x] claim this issue (@ederribeiro)
[x] Setup repository locally and make sure that all tests pass
[x] Update the assertion in tests/integration/routes/profile/get-profile-test.js to test for 404 and the desired error message
[x] Make sure tests fail when you run npm test
[x] Commit with test(routes): GET /session/account/profile error for admins
[x] Start a Pull Request: #114
[x] Implement :)
[x] Make sure tests pass. Commit with fix(routes): GET /session/account/profile error for admins
[x] Done :+1: Ask in comments for a review :)

Ping us in the Hoodie Chat or on Twitter if you have any questions :)

Hello,
I want to solve this issue...

All yours Eder :+1:

released as v2.6.8 :ok_hand:

Would you mind us give you a shout out at https://twitter.com/hoodiehq? Your twitter account is https://twitter.com/ApuSoft – right?
I’ve also missed to invite you to our Contributors team at Hoodie, you should see the invitation at https://github.com/hoodiehq. We would love to welcome you :)
If you feel like contributing again, let us know :) We are out of starter issues, but there are other things you could work on if you like, I’m sure we can find something interesting


customize installation should let you set CARGO_HOME and RUSTUP_HOME

Its very weird that 2) customize installation rustup option doesn't let you set where to actually install things. That's kind of installers 101 😆

Duplicate of #618


Update README.md

Gonna leave this. MSP program requires a lot of commitment. We are currently looking for swags or rewards that are defined and can be achieved within a short period. Thanks for your contribution!

Could you please add the label "hacktoberfest-accepted" to this PR, so that it would be counted towards my Hacktober fest PR! :)
Even if it's closed, if you add the label it would be helpful! :)


multiple messages from the socket

We get multiple messages from the unix socket /var/run/salt/master/master_event_pub.ipc and we only unmarshal the first one.
This results to missing some messages.

fixed with https://github.com/tsaridas/salt-event-listener-golang/commit/5a1b102bfb2e7f523ca72a75b147bcc7a6d1a5d6


Allow extensions to opt-in to pinning their Language Status Item by default

Originally posted by @andschwa in https://github.com/microsoft/vscode/issues/145950#issuecomment-1077811671
Have talked with @TylerLeonhardt about this too. When the PowerShell extension switched from its own status bar icon to the new Language Status Item API, the user experience was forcibly changed: the PowerShell icon (with the current version) is now by default hidden under {} (the language status item icon), which is confusing enough to our users that we've added it to our troubleshooting document, and have kept it in our extension's preview channel.
While I understand the rationale of having all language status items under the {} menu, and like being able to pin each icon, it seems that extension's should be able to opt-in to pinning their icon be default so as to not overly change the existing user experience.

/cc @jrieken

I believe that the population of VS Code users isn't divided by "power shell" users, "fooLang" users, or "barLang" users. Instead, I believe that the population is divided by users that like feature A to be a certain way, and feature B to be a certain other way. I also believe that extension authors are naturally biased towards "their feature contributions". So, I am trying to say "no" to allowing extensions to control this and "yes" to let's consider if this could/should be a user setting.

Well, the user setting is to click the "pin" button; this is more about a breaking change in behavior that all are users are having to contend with.

Well, the user setting is to click the "pin" button;

No, I meant a user setting that goes "all language status items are pinned by default and need to be unpinned"

a breaking change in behavior that all are users are having to contend with.

Well, what should I say 🤷  Yes, many people don't like changes. If you truly believe that all your users are put off by this then don't make this change or only make this change for new users and let existing users chose. Python, for instance, takes a two step approach: move status to the right, later move status into the language status item.

Hey @CsCherrYY in https://github.com/microsoft/vscode/issues/129037#issuecomment-1068650735 I think I see the confusion. I had unpinned the menu bar item "Editor Language" which you have pinned, so you see {} Java <language status item>, and the Java part is just the selected "Editor Language". The {} icon does look a little less weird with the language next to it!

Well, what should I say 🤷 Yes, many people don't like changes. If you truly believe that all your users are put off by this then don't make this change or only make this change for new users and let existing users chose. Python, for instance, takes a two step approach: move status to the right, later move status into the language status item.

I didn't say "my" users I said "our" users, as in the users of VS Code and its extensions. We're already at Python's step 1, our status icon has been on the right-side (and was one of the impetuses for the development of the language status item, so all extensions can converge on this API). I'm just pointing out that (our, collective) users  of VS Code and its extensions (like PowerShell, and Python, and TypeScript) have a breaking change incoming and we should either make it less breaking for them, or more documented, as the small userbase we've tested with have complained. I will point them this way if ship with it unpinned by default 😊

Hey @CsCherrYY in https://github.com/microsoft/vscode/issues/129037#issuecomment-1068650735 I think I see the confusion. I had unpinned the menu bar item "Editor Language" which you have pinned, so you see {} Java , and the Java part is just the selected "Editor Language".

@andschwa Yeah, that's the gap here.

The {} icon does look a little less weird with the language next to it!

That would be the reason why the default behavior of "Editor Language" is pinned. I didn't try to unpin the "Editor Language" before🙂.

FWIW after GA'ing with the language status item that is not pinned...no complaints (except the original few from our preview users) 🤷

Thanks for the update


bug: Not working on fresh install for LTS node

Just error. Is the only one extension on this planet for VSC to lint smarty templates used in Prestashop.
Installed as required in doc. No from where error come from
Node:

v16.11.1

NPM:

8.0.0

> Executing task in folder ... : npm run lint <

><EMAIL_ADDRESS>lint
> smarty-lint

/Volumes/.../node_modules/.bin/smarty-lint: line 1: /Applications: is a directory
/Volumes/.../node_modules/.bin/smarty-lint: line 3: syntax error near unexpected token `('
/Volumes/.../node_modules/.bin/smarty-lint: line 3: `const fs = require('fs');'
The terminal process "/bin/bash '-c', 'npm run lint'" terminated with exit code: 2.

Terminal will be reused by tasks, press any key to close it.

Right now work fix:

"lint": "node<EMAIL_ADDRESS>

But require to change smartylint.json if just one file we check


[FR] Separate Leader and Member rewards for the reward address of the pool

DB-Sync version
cardano-db-sync 13.0.2 - linux-x86_64 - ghc-8.10
git revision 8733b71af3ada773755c5cb08d9c061eda11fb96
PostgreSQL version
14.4
Problem Report
At the moment usually a pool's reward address has only leader type in the reward table, even if it's delegated to this pool. This leader reward contains both leader and member parts of rewards, i.e. equal to the sum of pool margin/fee + delegation rewards. But there are some addresses (234 at the moment in mainnet) which have both types leader and member at the same time, for the same epoch. They have right amounts of pool margin/fee in row with leader type, and delegation rewards in row with member type. This happened only in case when pool's reward address is not simultaneously the owner of this pool.
It will probably be more clear in the following example forstake1uyt0rrp60jn8qnvnzlcj6up9q0r3mxyvnmxtlm0y4r3vltgf05u87
SELECT *
FROM reward
WHERE addr_id = (SELECT id FROM stake_address WHERE view = 'stake1uyt0rrp60jn8qnvnzlcj6up9q0r3mxyvnmxtlm0y4r3vltgf05u87')
ORDER BY id;

    id    | addr_id |  type  |  amount   | earned_epoch | spendable_epoch | pool_id
----------+---------+--------+-----------+--------------+-----------------+---------
 22123937 | 1286599 | leader | 601547401 |          286 |             288 |    2252
 30092783 | 1286599 | member |   2407545 |          297 |             299 |    2252
 30829684 | 1286599 | leader | 667983420 |          297 |             299 |    2252
 31830284 | 1286599 | member |   2238730 |          299 |             301 |    2252
 32588487 | 1286599 | leader | 644985517 |          299 |             301 |    2252
 35364094 | 1286599 | member |   3758819 |          303 |             305 |    2252
 36147626 | 1286599 | leader | 644101159 |          303 |             305 |    2252
 39928735 | 1286599 | member |   4635321 |          308 |             310 |    2252
 40726881 | 1286599 | leader | 631304175 |          308 |             310 |    2252
 57495779 | 1286599 | leader | 659485102 |          324 |             326 |    2252
 68558739 | 1286599 | leader | 496559296 |          334 |             336 |    2252
 75285178 | 1286599 | leader | 492516169 |          340 |             342 |    2252
 81950560 | 1286599 | leader | 469693483 |          346 |             348 |    2252
 90464187 | 1286599 | leader | 462095941 |          353 |             355 |    2252
 91639614 | 1286599 | leader | 461872884 |          354 |             356 |    2252
(15 rows)

As can we see here, addr id 1286599 has both leader/member types, but from epoch 324 it has only leader type. Now, let's check the changes of pool_owners for this pool id 2252
SELECT pool_update.id, pool_update.active_epoch_no, STRING_AGG(pool_owner.addr_id::varchar, ','), pool_update.reward_addr_id
FROM pool_update
LEFT JOIN pool_owner ON pool_owner.pool_update_id = pool_update.id
WHERE pool_update.hash_id = 2252
GROUP BY pool_update.id, pool_update.active_epoch_no, pool_update.reward_addr_id
ORDER BY pool_update.id DESC;

  id   | active_epoch_no |          string_agg           | reward_addr_id
-------+-----------------+-------------------------------+----------------
 25985 |             323 | 638268,4461974,576317,1286599 |        1286599
 19074 |             276 | 576317,638268                 |        1286599
 19073 |             276 | 638268,576317                 |        1286599
 17438 |             269 | 638268,576317                 |        1286599
 16091 |             264 | 576317,638268                 |        1286599
 15851 |             263 | 576317,638268                 |         638268
 15330 |             261 | 638268,576317                 |         638268
 15329 |             261 | 576317,638268                 |         638268
 14941 |             260 | 638268                        |         638268
 14858 |             260 | 638268                        |         638268
 13741 |             257 | 638268                        |         638268
 11165 |             251 | 638268                        |         638268
 10813 |             250 | 638268                        |         638268
(13 rows)

We can see that addr_id 1286599 was added in the (active) Epoch 323 as pool owner, and there are no rewards with member type for this address in the reward table from this epoch.
So, the question is can we separate member and leader rewards for pools reward addresses in case when this address is simultaneously the owner of the pool?
Sorry if my explanation wasn't completely clear. I tried to explain in as much detail as possible, but it still looks a bit confusion :) If you need more details I am at your disposal

I think owners of a pool never get member rewards from that pool. It doesn't matter if they delegate to the pool or if they are the pool reward accounts.

So, the question is can we separate member and leader rewards for pools reward addresses in case when this address is simultaneously the owner of the pool?

I'm not sure if there is something to separate, since there are no member rewards in that case. db-sync gets from the ledger layer only leader rewards and this is what it stores in the db.

Thanks kderme, I completely forgot that pool owners do not receive any rewards, their rewards are distributed to the pool reward address only. You're right, there's no way to separate them.


Improve usage of passed along react-intl modules

Feature Request
Description
We've started exposing react-intl modules from terra-base. One of the issues with this is related to how we expose the react-intl modules. We import modules from react intl and then export them from this file. This is then consumed like so: import { injectIntl, intlShape } from 'terra-base';.
This pulls in and executes more code than just injectIntl and intlShape, but it's not immediately obivous. This executes this file, which executes this line, which exectus this file from terra-i18n which executes our i18n logic.
If we want to continue exporting react-intl modules from terra-base, we should look at ways to do this that don't require the full terra-base and terra-i18n files to execute when importing the react-intl modules.
Additional Context / Screenshots
Consumers noticed this issue in a recent release of terra-application-header-layout where we added this line import { injectIntl, intlShape } from 'terra-base';.

Tech Design
Split react-intl into separate file exports under terra-base.
This allows terra-base to remain 1 dependency used to manage react-intl while allowing individual modules to be imported without pulling in all of terra-base.

Discussed with @tbiethman about this issue. We think a better path forward would be to avoid passing react-intl modules through terra-i18n / terra-base and instead manage the version of react-intl through peerDependencies in components that need intl similar to how we manage the version of react that components use.
With this, each package that needs modules from react-intl would import directly from react-intl and set a peerDependency on react-intl. The react-intl modules that are passed through terra-i18n and terra-base should be removed in a major version bump.

+1 on peer-dependencies.

Peer deps would also allow consumers to begin using the new context API sooner once this PR merges.


cli.py not installed

The cli.py script is not getting installed as zpdata.
Seems to work if copied to (e.g.) /usr/local/bin/zpdata

Thanks. Let me have a look what's up.

So, I'd been playing with uv for replacing the build chain which meant I wound up making some other changes. In any case, I've rebuilt and republished version 1.1.2.
I've tested on Mac/windows/linux systems and it seems to work across all 3. I did notice one case where it appeared to fail: when the site_packages are not writable (e.g. python installed by root). In that case pip dropped the package into my local site packages, which happened not to be in my path.
Whether because of the change in build tools or some other reason it appears on my side to be working. If you're still having issues, could you let me know a bit more about your setup so I can try to reproduce?

How do you test it @puckdoug ?
`(3.12) martinh@zen-imac eracing % uv pip install zpdatafetch
Resolved 20 packages in 2.07s
Built zpdatafetch==1.1.2
Prepared 20 packages in 1.37s
Installed 20 packages in 57ms

anyio==4.4.0
beautifulsoup4==4.12.3
certifi==2024.7.4
h11==0.14.0
httpcore==1.0.5
httpx==0.27.2
idna==3.8
iniconfig==2.0.0
jaraco-classes==3.4.0
jaraco-context==6.0.1
jaraco-functools==4.0.2
keyring==25.3.0
keyrings-alt==5.0.2
lxml==5.3.0
more-itertools==10.4.0
pip==24.2
pluggy==1.5.0
sniffio==1.3.1
soupsieve==2.6
zpdatafetch==1.1.2
`

@mhgit - I'm assuming /Users/martinh/3.12 is your venv directory? If you've got a current uv, you should also be able to simply execute uv run zpdata -h but the above appears good. Thanks.
@stuartlynne - I'm going to mark this done, but please do come back if it's not working on your end and let me know more about your environment so we can figure it out.

martinh@zen-imac eracing % source ~/3.12/bin/activate
(3.12) martinh@zen-imac eracing % uv run zpdata -h
error: No project table found in: /Users/martinh/git-work/eracing/pyproject.toml

@mhgit - I'm assuming /Users/martinh/3.12 is your venv directory? If you've got a current uv, you should also be able to simply execute uv run zpdata -h but the above appears good. Thanks.
@stuartlynne - I'm going to mark this done, but please do come back if it's not working on your end and let me know more about your environment so we can figure it out.

I ditched venv...


Added confidence support to disparity filtering

DisparityWLSFilter now supports confidence-based filtering, which improves the results considerably
WLS filter was optimized (~4x speedup)
Demo application is significantly modified. Compiled demo with a couple examples: https://www.dropbox.com/s/2tw9fielh6boe08/bin.rar?dl=0

I tried running the example and got strange noise when using it without confidence map:

Shouldn't this regions be excluded by ROI?

Looks good, thank you!
Please, squash all commits into one before merge.

:+1:


Does not respect mcmmo max level

Players can level over the max mcmmo levels if they are set.

If this is still an issue, please create a new issue with your Quests version number. Thanks!


Decouple CMake from Python somewhat

Closes #629.

For deployment, use CMake to install pure Python files to the install tree, rather than pip. Hence remove the unused and incomplete setup.py, for now.
For tests, only create a Python virtualenv if an OPENASSETIO_ENABLE_PYTHON_TEST_VENV option is set. Otherwise, simply expect the user to have appropriately configured an external environment for running tests (installed test dependencies and made the openassetio package in the install tree discoverable).
For tests, roll all Python virtualenv creation targets into a single, easily excludeable, target - useful for subsequent runs where the environment already exists.
CMake presets by default enable OPENASSETIO_ENABLE_PYTHON_TEST_VENV

WIP notes

Build instructions updated, but not yet manually tested.

Need to remove redundant pip install [...]/requirements.txt for test dependencies, if virtualenv fixture is enabled(?).

Should some of these changes be split into separate PRs?
Should we have deleted setup.py, only for it to return very soon?
Should we add new CI checks to check test runs without an automatically created venv?
Should we default-enable OPENASSETIO_ENABLE_PYTHON_TEST_VENV in CMake presets, despite it being default-disabled when presets are not used?
Component tag on some commits should perhaps be [Tests]
Need to review some code comments around changed lines.

Notes from standup:

Move test venv from build/dist to build/test-venv (so dist only contains distribution artifacts)
Always extend python path to dist
Don't pip install codegen, ensure CLI tests invoked with sys.executable -m openassetio_codegen vs the wrapper (will need requirements.txt to install deps to test-venv), extend PYTHONPATH to resources dir for tests.
Issue to add test coverage for setup.py in codegen.
Any commit that touches cmake/etc... tagged with [Build]

Re the whole codegen/pip install malark, would it work if (ultimately, once #630 is done too), is it just a test option for "tests use pip" that switches from extending PYTHONPATH (for non venv/tdd workflows) to properly installing them into the test venv?

Re the whole codegen/pip install malark, would it work if (ultimately, once #630 is done too), is it just a test option for "tests use pip" that switches from extending PYTHONPATH (for non venv/tdd workflows) to properly installing them into the test venv?

Yeah that could work, but might get messy(er) with more branching logic in the CMake code.

Re the whole codegen/pip install malark, would it work if (ultimately, once #630 is done too), is it just a test option for "tests use pip" that switches from extending PYTHONPATH (for non venv/tdd workflows) to properly installing them into the test venv?

Yeah that could work, but might get messy(er) with more branching logic in the CMake code.

Yeah. I guess I was wondering if the "happy place" would be when ctest uses a pip install by default (when you're not a contributor) such that we have the most e2e coverage (vs needing to run a separate job?)


Implement Contacts Page on My Profile

[ ] Add Contacts menu item
[ ] Left align left profile menu (incl. name, image, etc)
[ ] Populate contacts list
[ ] When click name/image send to public profile

@oznekenzo this is ready for implementation. Will share sketch file in Discord


Support of recursive ReBAC

I need to use ReBAC recursively.
I made a POC in the playground and unfortunately my model don't seem to work.
I have a model like this:

That I can modeling in the playground like the following:
entity user {}

entity organization {
    relation parent @organization
    relation member @user @organization#member

    action view = member or parent.member
}

Here, I want my organization members to view their organization, but also parent organization members to see child organizations.
Zanzibar documentation specify the support of recursive relation, I didn't find a way to do it using permify.
The playground don't allow parent organization members to view child organization of their child organization.
For example:

James isn't allowed to view Charlie Organization. But it should, right ?
Thanks for taking time to read.

Hi @LeoFVO, thanks for opening this issue, and for the illustrations :) We've been thinking to add this functionality for a while but never scheduled it. We internally discussed and planned to ship it within this quarter. You can track the progress over here ✌

Hello @LeoFVO ,
We were examining the issue and we've realized something. Please test the model by using the following link to the Permify playground: https://play.permify.co/?s=l2Z2QhVIh32AiY1yr2mHC. The model has been set up to accommodate multiple levels of upward traversal in a hierarchy. Instead of using member or parent.member which only accounts for a single upward step, you should try using member or parent.view to correctly handle multiple hierarchical levels.
entity user {}

entity organization {
    relation parent @organization
    relation member @user @organization#member

    action view = member or parent.view
}

Hey @tolgaOzen, this work as expected. I didn't find this in the documentation, do you have the reference ?
Thanks for your help !

Hi @LeoFVO, we don't have a reference right now, but we've started working on documentation to create a more comprehensive modeling guide. We'll let you know through this thread when it's completed.

Hi @LeoFVO, a quick question. Could I use one of the illustrations you provided (the second one featuring James, Alpha Entity) to explain this specific case in our docs? It's worth mentioning that we'll definitely give you credit on the docs page with providing a link of your GitHub profile.

Of courses, thanks for this !

Here is the related section for this issue: https://docs.permify.co/docs/getting-started/modeling/#recursive-rebac @LeoFVO


Please invite me to the community

Name
Samrat Mitra
Discord Username (if applicable)
No response
Additional Context
I will love to collaborate with all devs out there !!

Hey, welcome to the community. Don't forget to join our discord


fix: memory leaks and deletion

Description

#5

This PR addresses the issue by implementing the fixes in https://github.com/bbenligiray/stag/pull/31 and https://github.com/bbenligiray/stag/pull/32. I took the liberty of patching other occurrences of bad deletion too.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

[ ] Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes
[ ] Tested on robot

So currently, I am getting
Thread 41 "state_engine" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff7cff9640 (LWP 278)]
0x00007ffff72c847e in free () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) backtrace
#0  0x00007ffff72c847e in free () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fff0c12ea9f in stag::EdgeMap::~EdgeMap (this=0x7fff2804f6d0, __in_chrg=<optimized out>)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/include/stag/ED/EdgeMap.h:42
#2  0x00007fff0c12db16 in stag::EDInterface::~EDInterface (this=0x7fff4400a398,
    __in_chrg=<optimized out>)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/EDInterface.cpp:31
#3  0x00007fff0c6017de in stag::Stag::~Stag (this=0x7fff4400a390, __in_chrg=<optimized out>)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/include/stag/Stag.h:14
#4  0x00007fff0c601802 in __gnu_cxx::new_allocator<stag::Stag>::destroy<stag::Stag> (
    this=0x7fff4400a390, __p=0x7fff4400a390) at /usr/include/c++/11/ext/new_allocator.h:168
#5  0x00007fff0c6016b5 in std::allocator_traits<std::allocator<stag::Stag> >::destroy<stag::Stag> (
    __a=..., __p=0x7fff4400a390) at /usr/include/c++/11/bits/alloc_traits.h:535
#6  0x00007fff0c601571 in std::_Sp_counted_ptr_inplace<stag::Stag, std::allocator<stag::Stag>, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x7fff4400a380) at /usr/include/c++/11/bits/shared_ptr_base.h:528
#7  0x000055555602be2f in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (
    this=0x7fff4400a380) at /usr/include/c++/11/bits/shared_ptr_base.h:168
#8  0x0000555556029fbd in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (
    this=0x7fff209c1ec8, __in_chrg=<optimized out>) at /usr/include/c++/11/bits/shared_ptr_base.h:705
#9  0x00007fff0c5fc8ea in std::__shared_ptr<stag::Stag, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr (
    this=0x7fff209c1ec0, __in_chrg=<optimized out>) at /usr/include/c++/11/bits/shared_ptr_base.h:1154
#10 0x00007fff0c5fc90a in std::shared_ptr<stag::Stag>::~shared_ptr (this=0x7fff209c1ec0,
    __in_chrg=<optimized out>) at /usr/include/c++/11/bits/shared_ptr.h:122
#11 0x00007fff0c601440 in pose_detection::detectors::STagDetector::~STagDetector (this=0x7fff209c1dd0,
    __in_chrg=<optimized out>)
    at /home/ros2/ws/src/pose_detection/include/pose_detection/detectors/STagDetector.hpp:17
#12 0x00007fff0cbe2b85 in __gnu_cxx::new_allocator<pose_detection::detectors::STagDetector>::destroy<pose_detection::detectors::STagDetector> (this=0x7fff209c1dd0, __p=0x7fff209c1dd0)

When reading through the code, there is no explicit destructors for Stag.h stag object. Also, these objects do not explicitly define which should be deleted first.
From reading the code, Stag object creates EDInterface which has a pointer EdgeMap object. Hence, we want to delete EDInterface before EdgeMap. But as seen in the GDB console, the EdgeMap object gets deleted first, probably due to the order of inheritance, which has a dangling pointer. Phind (AI chatbot) says that free could mean double free or dangling pointer.

Thread 45 "state_engine" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff667fc640 (LWP 692)]
stag::QuadDetector::groupLines (this=0x7fff3000ffe0, image=..., edInterface=0x7fff3000ffa8) at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/QuadDetector.cpp:120
120	/home/ros2/ws/build/pose_detection/_deps/stag-src/src/QuadDetector.cpp: No such file or directory.
(gdb) backtrace
#0  stag::QuadDetector::groupLines (this=0x7fff3000ffe0, image=..., edInterface=0x7fff3000ffa8)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/QuadDetector.cpp:120
#1  0x00007fff15138678 in stag::QuadDetector::detectQuads (this=0x7fff3000ffe0, image=...,
    edInterface=0x7fff3000ffa8)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/QuadDetector.cpp:30
#2  0x00007fff151411fd in stag::Stag::detectMarkers (this=0x7fff3000ffa0, inImage=...)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/Stag.cpp:27

Thread 40 "state_engine" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff757fa640 (LWP 553)]
0x00007fff14fc9cbf in stag::EDInterface::correctLineDirection (this=0x7fff3c2b47a8, image=..., ls=...) at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/EDInterface.cpp:57
57 /home/ros2/ws/build/pose_detection/_deps/stag-src/src/EDInterface.cpp: No such file or directory.
(gdb) backtrace
#0  0x00007fff14fc9cbf in stag::EDInterface::correctLineDirection (this=0x7fff3c2b47a8, image=...,
    ls=...) at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/EDInterface.cpp:57
#1  0x00007fff14fde1ef in stag::QuadDetector::groupLines (this=0x7fff3c2b47e0, image=...,
    edInterface=0x7fff3c2b47a8)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/QuadDetector.cpp:134
#2  0x00007fff14fdd678 in stag::QuadDetector::detectQuads (this=0x7fff3c2b47e0, image=...,
    edInterface=0x7fff3c2b47a8)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/QuadDetector.cpp:30
#3  0x00007fff14fe61fd in stag::Stag::detectMarkers (this=0x7fff3c2b47a0, inImage=...)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/Stag.cpp:27

Thread 46 "state_engine" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff61ffb640 (LWP 424)]
0x00007fff8856ef29 in cv::invert(cv::_InputArray const&, cv::_OutputArray const&, int) () from /ws/install/pose_detection/lib/../apt/lib/x86_64-linux-gnu/libopencv_core.so.4.5d
(gdb) backtrace
#0  0x00007fff8856ef29 in cv::invert(cv::_InputArray const&, cv::_OutputArray const&, int) ()
   from /ws/install/pose_detection/lib/../apt/lib/x86_64-linux-gnu/libopencv_core.so.4.5d
#1  0x00007fff885c691a in ?? ()
   from /ws/install/pose_detection/lib/../apt/lib/x86_64-linux-gnu/libopencv_core.so.4.5d
#2  0x00007fff10e2d8a6 in cv::MatExpr::operator cv::Mat (this=0x7fff61ff6480)
    at /home/ros2/ws/install/pose_detection/apt/usr/include/opencv4/opencv2/core/mat.inl.hpp:3078
#3  0x00007fff1042e09a in stag::PoseRefiner::refineMarkerPose (this=0x7fff3c00cc28,
    edInterface=0x7fff3c00cb68, marker=...)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/PoseRefiner.cpp:69
#4  0x00007fff1043e4b0 in stag::Stag::detectMarkers (this=0x7fff3c00cb60, inImage=...)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/Stag.cpp:53

So after implementing the mutex, I am getting random segmentation fault problems, all stemming from stag::Stag::detectMarkers . Do you think it's because there are other parts in that function that's looking for the deleted edInterface object and that's a dangling pointer? It's basically the stag detector trying to run a function while being destructed too? So if we move the mutex here it might solve the problem?

free(): invalid pointer

Thread 43 "state_engine" received signal SIGABRT, Aborted.
[Switching to Thread 0x7fff677fe640 (LWP 533)]
0x00007ffff72b9a7c in pthread_kill () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) backtrace
#0  0x00007ffff72b9a7c in pthread_kill () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007ffff7265476 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007ffff724b7f3 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007ffff72ac6f6 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#4  0x00007ffff72c3d7c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#5  0x00007ffff72c5ac4 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#6  0x00007ffff72c84d3 in free () from /lib/x86_64-linux-gnu/libc.so.6
#7  0x00007fff14507d17 in stag::EDLines::~EDLines (this=0x7fff342056a0, __in_chrg=<optimized out>)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/include/stag/ED/EDLines.h:57
#8  0x00007fff14506c05 in stag::EDInterface::~EDInterface (this=0x7fff500019f8,
    __in_chrg=<optimized out>)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/EDInterface.cpp:31
#9  0x00007fff14523270 in stag::Stag::~Stag (this=0x7fff500019f0, __in_chrg=<optimized out>)
    at /home/ros2/ws/build/pose_detection/_deps/stag-src/src/Stag.cpp:26
#10 0x00007fff149d7b34 in __gnu_cxx::new_allocator<stag::Stag>::destroy<stag::Stag> (
    this=0x7fff500019f0, __p=0x7fff500019f0) at /usr/include/c++/11/ext/new_allocator.h:168
#11 0x00007fff149d7aff in std::allocator_traits<std::allocator<stag::Stag> >::destroy<stag::Stag> (
    __a=..., __p=0x7fff500019f0) at /usr/include/c++/11/bits/alloc_traits.h:535
#12 0x00007fff149d79bb in std::_Sp_counted_ptr_inplace<stag::Stag, std::allocator<stag::Stag>, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x7fff500019e0) at /usr/include/c++/11/bits/shared_ptr_base.h:528
#13 0x000055555602be2f in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (
    this=0x7fff500019e0) at /usr/include/c++/11/bits/shared_ptr_base.h:168
#14 0x0000555556029fbd in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (
    this=0x7fff189b3218, __in_chrg=<optimized out>) at /usr/include/c++/11/bits/shared_ptr_base.h:705
#15 0x00007fff149d300a in std::__shared_ptr<stag::Stag, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr (
    this=0x7fff189b3210, __in_chrg=<optimized out>) at /usr/include/c++/11/bits/shared_ptr_base.h:1154
#16 0x00007fff149d302a in std::shared_ptr<stag::Stag>::~shared_ptr (this=0x7fff189b3210,

Alright, after locking all unsafe functions during destruction, it really seems that the problem has returned to these arrays, where they are not NULL but deleted somewhere, and they also have unsafe functions that could be running during destruction. Furthermore, the entire Stag code is too complicated to code trace without spending so much time on it, and adding mutexes or pointer = NULL is a little silly. I will see how our pose detection uses stag and maybe we can decide what's the next course of action

bool STagDetector::configure() {
  stag_ = std::make_shared<stag::Stag>(library_->get_value(), error_correction_->get_value(), false);
  return BaseMarkerDetector::configure();
}

std::map<int, std::vector<cv::Point2d>> STagDetector::detect_markers(const cv::Mat& image) {
  cv::Mat gray;
  cv::cvtColor(image, gray, cv::COLOR_RGB2GRAY);
  this->stag_->detectMarkers(gray);
  annotated_image_ = this->stag_->drawMarkers();

  std::map<int, std::vector<cv::Point2d>> markers;
  for (const auto& marker: this->stag_->getMarkerList()) {
    markers.insert_or_assign(marker.id, marker.corners);
  }
  return markers;
}

So I am looking at the part of the code that invokes the Stag class found here, and it uses 3 functions.

detectMarkers which is originally part of the code
drawMarkers which was resolved in #2. We find that it's also added here
getMarkerList which was also resolved in #2, which is here as well.

And after, there's some clean up with seperating headers and cpp file, as well as making sure all the installation and compilation scripts are working.
We could try to update our Stag library to the latest version, and it would be easier to update down the line too (maybe). Let me know what you think.

This is closed to facilitate #7


Computing power spectrum of already masked map

I need to compute the power spectrum of an already masked map, of which I have the apodized mask. If I just follow the examples, my map will be multiplied by the mask again and the final power spectrum will not be correct.
I adapted my script from the existing examples, but I could not confirm from the source code whether or not this makes sense. Given that my_map is masked with apodized_mask, whose binary version is binary_mask, and other_map is an unrelated map, is it correct to:
f_other = nmt.NmtField(apodized_mask, other_map)
w = nmt.NmtWorkspace()
w.compute_coupling_matrix(f_other, f_other, b)
f0 = nmt.NmtField(binary_mask, my_map)
cl = nmt.compute_coupled_cell(f0, f0)
cl_decoupled = w.decouple_cell(cl)
Thanks

Hi @umilta
I think what you're doing should work. The main thing to remember is that, when one calls w.compute_coupling_matrix, the two fields one passes should have their true masks associated with them.
Note however, that if you try to use the systematics deprojection or purification functionality in NaMaster, it won't really work for f0, since these functions also need to know the mask.
To make things slightly less hackish, I'd do the following:
f_other = nmt.NmtField(apodized_mask, other_map)
w = nmt.NmtWorkspace()
# Divide by mask where it's not zero
map_unmasked = np.zeros_like(my_map)
map_unmasked[binary_mask>0.001] = my_map[binary_mask>0.001] / apodized_mask[binary_mask>0.001]
f0 = nmt.NmtField(apodized_mask, map_unmasked)
cl_decoupled = w.decouple_cell(nmt.compute_coupled_cell(f0, f0))

I agree that it'd be nice to be able to pass masked maps to NaMaster, so I'll open an issue to address that. Thanks!

@umilta this feature has now been implemented in the master branch.

Thanks!


Add support for HttpContent

Is the feature request related to a problem
I want to write tests that compare the content of HttpContent (eg. as found in Content property of HttpRequestMessage)
Describe the solution
Add a converter HttpContentConverter
Describe alternatives considered
I could extract the value directly via await content.ReadAsStringAsync() but then you would lose the context from the parent HttpRequestMessage object

can you use the httpcontent converter in https://github.com/VerifyTests/Verify.Http?

ah, why yes! Didn't realise it might be somewhere else!


[SUGGESTION] 1.20.1 Backport?

Please describe your request.
Can we get a backport? :D

yes

yes

Woohoooo :)

Stfu is now available for 1.20 and 1.20.1!

Stfu is now available for 1.20 and 1.20.1!

Since the mod called stfu, i feel insulted wherever i hear that lmao.
Anyways thank you so much ❤


Add C-based tracer stub.

In an effort to make nv2a trace more efficient and consistent, tracing is being delegated to the hardware itself via an injected DLL. This commit is the first phase, simply injecting a nop DLL and verifying that it is responsive.

Note that this change would also make the tracer dependent on XBDM (but I believe that's more or less the status quo right now anyway).

Not entirely. I'd link nxdk-rdt into my homebrew to analyze it with nv2a-trace in some cases.
I'd also run unmodified nxdk-rdt to inject homebrew remotely (although not sure if nv2a-trace was involved or if it was just parts of it).
nv2a-trace is also an alternative to PIX for homebrew, and I'd appreciate if we'd be able to run without a stolen-XDK / debug-Xbox.
So while it's fine that it's temporarily only working use XBDM, I'd very much appreciate if some other support came back soon.
I didn't use nv2a-trace for a while and also mostly focused on debugging retail games (through XBDM), but the plan has always been to get rid of XBDM (also why xbe-loader exists: https://github.com/JayFoxRox/xbe-loader - because you could probably link nxdk-rdt into it in the future, to replace XBDM).

So while it's fine that it's temporarily only working use XBDM, I'd very much appreciate if some other support came back soon. I didn't use nv2a-trace for a while and also mostly focused on debugging retail games (through XBDM), but the plan has always been to get rid of XBDM (also why xbe-loader exists: https://github.com/JayFoxRox/xbe-loader - because you could probably link nxdk-rdt into it in the future, to replace XBDM).

Thanks for the context, I wasn't sure how functional it was without XBDM.
I think it'd be possible to preserve the rdt-usecase if there's an alternative way to load XBEs and still keep something resident. For the case where we have control over the loading process we wouldn't need to do the hacked injection/loading procedure used here since we could build the loader functionality into rdt (or xbe-loader, etc...).
At that point we'd just need to provide an implementation of a small subset of XBDM functionality to be able to leverage the same tracer DLL. Specifically handling network interaction and handler registration, basic memory management, sending notifications, maybe a couple other things.
Seems like the homebrew case would be very doable, particularly once the network stack in the nxdk becomes more performant. I'd probably be able to find some time to write the necessary XBDM-compatible bits at some point, and could certainly share my findings (which are more or less documented via comments in https://github.com/abaire/nxdk_demo_dyndxt) if somebody else wanted to contribute.
The loader path to debug retail games sounds very interesting, but, to be transparent, is not something I'd personally have time to look into anytime in the near future given the backlog of interesting problems I already have :)
In the interim, (and all assuming this PR gets approved), maybe the maintainers can tag (or branch, or create a release of) the tracer before merge so it's still straightforward to get a version to work for folks without XBDM?

I ended up developing this solution inside xbdm_gdb_bridge instead (consisting of a dynamically injected tracer that runs on the XBOX, writing raw capture to circular buffers which are retrieved by the xbdm tool and can be processed into nicer artifacts as a separate concern). Closing this PR.


semantic gulp build-css not true working

i running
gulp build-css

or
gulp build

dist/component/popup.css and dist/component/transition.css file not created...
but other files was created.
is this a bug?
"version": "2.4.1", and i use bower

@sannysc Try using Fomantic-UI, we have upgraded and fixed some bugs with the build system and it may fix your issue.


Jira projects succeed when executed individually, but fail when multiple project tasks are executed simultaneously

Describe the bug
As shown below, when the following Jira tasks are executed individually, they are all successful, but a permission exception occurs when some of them are executed in plural.

Add logs in relevant locations, as shown below:

The corresponding error on config-ui is as follows:

To Reproduce
Steps to reproduce the behavior:
Create several empty projects in Jira, add these projects to execute at the same time, there is a probability of the above situation.
Expected behavior
Working on multiple projects at the same time can perform the same as a single project
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

After adding the log and modifying the logic, see the process of reading the config.
Note that the configuration read fails for the first time, and it succeeds when retrying after waiting for one second. It is considered that the (.env) file read exception is caused by concurrency.

Analyze the config.go source code, notice that every time LoadConfigFile uses the global object pointer, and it will be accompanied by an invalid object that makes the pointer point to empty for a moment


Add example for TI 74HC595 shift registers

Example code to use a 595 shift register to light up 8 LEDs from 3 wires + 5V/GND, link to wiring diagrams and hardware tutorial is in the source file.  All feedback welcome, thanks for this awesome project!

Should be fixed I believe, thanks!

Thanks!


Fixing recipe_seaice_drift for 2.4

Describe the bug
As pointed out in https://github.com/ESMValGroup/ESMValTool/issues/2354#issuecomment-954195415, recipe_seaice_drift.yml crashes in the diagnostic run. After debugging I found a couple of issues:

For the GDFL dataset, the script crashes because there is a mismatch between the shapes of areacello and sispeed, which gets derived from usi and vsi. After taking a look at the preprocessed files, it looks like the coordinate points in sispeed differ from the coordinate points in all other variables. I am not sure if this is a dataset issue, because it is the only dataset where this happens. Taking this dataset out of the first diagnostic fixes the issue.

For diagnostic SCICEX, the script crashes when it's trying to find out whether or not certain points are inside the given polygon. For latitudes => 90º, the points get transformed and get assigned infinite values, which makes some routine in shapely crash. I found that this change fixes the issue, but I don't know if it affects the results:

           # if self.polygon.contains(Point(point[0], point[1]).buffer(0)):
           #     return 1.
           # return np.nan
            try:
                contained = self.polygon.contains(Point(point[0], point[1]))
            except shapely.errors.TopologicalError:
                return np.nan

            if contained:
                return 1.
            return np.nan

There is also one instance of write_plots that should be removed.

@jvegasbsc  let me know if you agree with the changes and I can open a PR.
Please attach

The recipe that you are trying to run, you can find a copy in the run directory in the output directory
The main_log_debug.txt file, this can also be found in the run directory in the output directory

Changes are ok. Thanks!


[IMPORTANT] Fixed not connecting and constantly updating

Better use string.IsNullOrWhitespace . Also you did not change anything which is related to the version, how are you sure it fixes this issue?

how are you sure it fixes this issue?
All the problems were fixed when I rebuilt the project.

I will rewrite this using the suggested IsNullOrWhitespace


Generic Multipart reader/writer implementaion

[ ] All tests passed. If this feature is not already covered by the tests, I added new tests.
[ ] This pull request is on the dev branch.
[ ] I used gofmt for formatting the code before submitting the pull request.
[ ] I labeled this pull request with one of the following: 'breaking change', 'new feature', 'bug', or 'ignore for release'

Also, I think that the package should be called "multipartform" to distinguish between the HTTP "multipart/form-data" content type, which is relevant here, and multipart upload.


Updates go to v1.23.1

Update go version and all version references to v1.23.1.
Updates golangci-lint version to v1.61.0.
Updates components-contrib version to main HEAD, and updates all component Closers to no longer type check for io.Closer.
Updates workflow linter to only check for changes. This should be removed once all linter errors have been resolved for v1.61.1.

Standalone validation is failing because master cannot be built with go v1.23. Tests are all green otherwise :slightly_smiling_face:


Added makeCircular() to UIViewExtensions

There was a func which does this

@goktugyil there's an extension for UIImageView called roundSquareImage(), but in UIView would be much better, so not only images can be rounded

why do you need to set the center?

You don't, sorry. I found that method in the internet and someone added the center

I changed


[CERT-TEST-FAILURE] - TC-WASHERCTRL-1.1 - Test failed

Feature Area
Area:Dishwashers
Test Case
TC-WASHERCTRL-1.1
Summary
All-clusters-app has to be enabled with below mentioned attributes :

[ ]    generated-command-list
[ ]    accepted-command-list
[ ]    event-list
[ ]   attribute-list
[ ]    feature-map
[ ]   cluster-revision

Bug prevalence
Everytime
GitHub hash of the SDK that was being used
d55f68526864b2986404d1da9c2ccd8b64735b6e - master
Platform
raspi
Platform Version(s)
RPI4 8GB RAM

Issue resolved in 55327986b373b50a5aaa030deeaf05d5eef3317e


Let's add some timing stats around the dnsmasq stats generation.

So that we know how long things take.

Honestly - it's so fast - it's two tiny structs - I don't care.


Use the FFTW binaries from fftw-builder

Let's see what happens...

At this point, this looks like a failure of the BinDeps setup rather than one of the binaries themselves. Any thoughts or suggestions, @tkelman and/or @staticfloat?

Overall looks reasonable, and the errors you're seeing are, ironically, due to BinDeps.jl, not BinDeps2.jl.  I don't know why it's crashing with an InterruptException.  That's weird.

because it's spawning a process to check if sudo works and that spawning fails

not BinDeps2.jl

Dunno why they would be coming from BinDeps2 anyway, since that isn't being used here...

It keeps trying to build from scratch on Linux. It's like it's not even seeing the provides(Binaries, ...) bit. :( Even on Windows it says none of the declared providers can satisfy the library requirement.

I see the issue: The binaries built on Travis have a directory structure in the tarball, whereas the rest of them just have the binaries right inside. I just need to not do that and it should be good I think.

Well, that's an issue at least. Doesn't explain the Windows failure.

Okay. Summary of current bad things:

64-bit Linux still ignores the binaries and builds from scratch
Windows says UndefVarError: libfftw not defined (maybe related to how I set libfftw_name?)
macOS says tar: could not chdir to '/Users/travis/.julia/v0.7/FFTW/deps/libfftw3_threads'

Any ideas, BinDeps masters?

Awesome, Windows works now! Linux x64 is still building from scratch (it isn't even hitting the info I put in there :/) though.

Okay, apparently BinDeps.debug("") doesn't like include().  That's interesting.
I guess next is to debug this locally, on a docker instance or something.


back to top does weird overlay apparently

On mobile, back to top does weird overlay apparenlty.

Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/6118#issuecomment-1569974098

I think it's just unlucky it in same line with those buttons, maybe move it further from border?


Are PRs welcome?

I'd be keen to start contributing to this project, but apparently no PRs have been approved/merged so far. Just wondering if PRs are welcome at all?
Can you post a roadmap or create tasks so people can contribute to this project?
Thanks

hi. yes. but i would prefer it folks could wait for next release which should be out in next few days. it should involve a big clean up of the code and added documentation/tests. once i have that out would be happy to start planning a roadmap and taking contributions and would be delighted to have some other folks involved!

Sweet, thanks for clarifying.


Refactor worker tests

This pr aims to clean up the worker tests, as I felt they were getting messy and unmaintainable.
I also plan to refactor the worker class itself in the near future, which will require the tests to be clean.
Changes

Order worker tests into classes. This should make it easier to find and read tests.

Checklist

[x] Unit tests
[x] Documentation

Thanks for the review @kbakk!
In order to avoid merge conflicts, I'll address your comments in my next pull request. :)
That pull request will split the task building process from the worker class.


[SPARK-22187][SS] Update unsaferow format for saved state such that we can set timeouts when state is null

What changes were proposed in this pull request?
Currently, the group state of user-defined-type is encoded as top-level columns in the UnsafeRows stores in the state store. The timeout timestamp is also saved as (when needed) as the last top-level column. Since the group state is serialized to top-level columns, you cannot save "null" as a value of state (setting null in all the top-level columns is not equivalent). So we don't let the user set the timeout without initializing the state for a key. Based on user experience, this leads to confusion.
This PR is to change the row format such that the state is saved as nested columns. This would allow the state to be set to null, and avoid these confusing corner cases.
How was this patch tested?
Refactored tests.

Test build #82407 has started for PR 19416 at commit 64a8d86.

Test build #82407 has finished for PR 19416 at commit 64a8d86.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FlatMapGroupsWithState_StateManager(
case class FlatMapGroupsWithState_StateData(

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82407/
Test PASSed.

Merged build finished. Test PASSed.

Test build #82454 has started for PR 19416 at commit ee0b81a.

LGTM pending tests

Test build #82454 has finished for PR 19416 at commit ee0b81a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82454/
Test PASSed.


Handle input only if Container has AliveInternalChildren

resolves https://github.com/ppy/osu-framework/issues/3245
This change should give us the desired effect in the following Container use cases:

empty ScrollContainer

empty FlowContainer and FillFlowContainer

Known issues:

ScreenshotManager does not work since it is a Container without children. (fixed in https://github.com/ppy/osu/pull/7743)

* Why not on `CompositeDrawable` instead?

Because the issue is about ScrollContainer. I decided that CompositeDrawable level is too wide for this case.

* This should probably have tests to validate this solution and not regress on the issue further on.

Indeed. I will add them tomorrow.

I disagree that this is what we want. It’s possible that we want composites to handle input when there’s no alive children. Something like moving around the screen (e.g. maybe a “blueprint” that overlays the drawable but needs to know about the drawable hover state, or the drawable itself is handling this), or perhaps adding a child on mouse/key events.
The issue was specific to ScrollContainer, not intended as a general issue.

unsure if it should be done at the input queue building, as opposed to the event overrides, where we would usually do this kind of thing.


When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 266:49  throw_
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3    assertFailed
../packages/flutter_test/src/test_text_input_key_handler.dart.js 2756:33         [_verifyInvariants]
../packages/flutter_test/src/test_text_input_key_handler.dart.js 2334:34         _runTestBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50            <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 165:98              <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 217:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 165:80              <fn>
../dart-sdk/lib/async/zone.dart 1406:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1307:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 147:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 767:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 796:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 567:5                                     [_completeWithValue]
../dart-sdk/lib/async/future_impl.dart 640:7                                     <fn>
../packages/fake_async/fake_async.dart.js 136:40                                 flushMicrotasks
../packages/flutter_test/src/test_text_input_key_handler.dart.js 2730:19         <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54            runBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5            _async
../packages/flutter_test/src/test_text_input_key_handler.dart.js 2727:62         <fn>
../dart-sdk/lib/async/future.dart 277:37                                         <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 217:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 160:71              <fn>
../dart-sdk/lib/async/zone.dart 1390:47                                          _rootRun
../dart-sdk/lib/async/zone.dart 1300:19                                          run
../dart-sdk/lib/async/zone.dart 1208:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1248:23                                          <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 217:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 160:71              <fn>
../dart-sdk/lib/async/zone.dart 1398:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1300:19                                          run
../dart-sdk/lib/async/zone.dart 1208:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1248:23                                          callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                              _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                               _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15           <fn>

The test description was:
  Cannot drag one handle past the other (variant: TargetPlatform.iOS)

Per the chat thread, the revert made the roller recover at 9 AM on Friday.


Object Info shows wrong clock settings

Using version 2.4.1 for P2 code shows wrong clock settings in Object Info and ignores _xtlfreq setting. It shows always "Clock Mode=XTAL3 + PLL1X" and "XIN Freq=Clock Freq" if a _clkfreq is provided.
The same code using PNut shows the correct clock setting and "Clock Mode=7pF XTAL + PLL".
It looks like that only the infos shown in Object Info are wrong, as the code is running fine if loaded into the Propeller.

Thank you, @TKliche.
Yes indeed, that's showing the wrong details but the application itself is correct and runs properly on the Propeller.  I'll fix it.


Update README.md

Hi, can you share the code that you implement by paper"Latent Space Autoregression for Novelty Detection" ?

@ChristophJud


Fixed blocker issues reported by sonarqube in js files

All of them are trailing comma in array or object
more details @
https://analysis.apache.org/component_issues?id=org.apache.cloudstack%3Acloudstack#resolved=false|severities=BLOCKER|languages=js

LGTM (less gomma's tis more:)


Internal Server Error: /dashboard/

Version
official docker image - v0.10.0
Stacktrace
ERROR Internal Server Error: /dashboard/
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/contrib/auth/mixins.py", line 52, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/list.py", line 157, in get
    context = self.get_context_data()
  File "/usr/src/shynet/dashboard/views.py", line 39, in get_context_data
    service.stats = service.get_core_stats(
  File "/usr/src/shynet/core/models.py", line 116, in get_core_stats
    main_data = self.get_relative_stats(start_time, end_time)
  File "/usr/src/shynet/core/models.py", line 203, in get_relative_stats
    chart_data, chart_tooltip_format, chart_granularity = self._get_chart_data(
  File "/usr/src/shynet/core/models.py", line 295, in _get_chart_data
    chart_data[k["date"]]["hits"] = k["count"]
KeyError: datetime.date(2021, 6, 26)

Remediation
I had to delete some session data and was able to access the dashboard again, should've investigated which data exactly was causing this, but the data is gone now.

Thanks for bug report.
I will investigated this.

The problem are days with hits and without sessions. It's quite rare case.
It may occur if today's hit is related to session from yesterday and there is no new session today.
I see two solutions:

Add extra if statement and display days with hits and without sessions.
(It will never occur with AGGRESSIVE_HASH_SALTING = True)
Categorize hits by related session start_time.

I will choose first solution unless someone has different opinion.

The problem are days with hits and without sessions. It's quite rare case.
It may occur if today's hit is related to session from yesterday and there is no new session today.
I see two solutions:

Add extra if statement and display days with hits and without sessions.
(It will never occur with AGGRESSIVE_HASH_SALTING = True)
Categorize hits by related session start_time.

I will choose first solution unless someone has different opinion.

Solution 1 sounds good!

Shouldn't this be closed by now?
@haaavk: If you put fix #158 in the commit message or PR body, it will close the issue automatically when the PR is merged.
As far as I remember, it also works on close, closes, resolve and resolves


Can build APK

Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter build aot --suppress-analytics --quiet --target lib/main.dart --target-platform android-arm --output-dir /Users/hdhuu/DATA/DEV/Sources/AndroidStudioProjects/your-reward-user/build/app/intermediates/flutter/release --target-platform android-arm --release
exception
ProcessException: ProcessException: Bad CPU type in executable
Command: /Users/hdhuu/DATA/DEV/Sources/Flutter/flutterSdk/flutter/bin/cache/artifacts/engine/android-arm-release/darwin-x64/gen_snapshot --causal_async_stacks --deterministic --snapshot_kind=app-aot-blobs --vm_snapshot_data=/Users/hdhuu/DATA/DEV/Sources/AndroidStudioProjects/your-reward-user/build/app/intermediates/flutter/release/vm_snapshot_data --isolate_snapshot_data=/Users/hdhuu/DATA/DEV/Sources/AndroidStudioProjects/your-reward-user/build/app/intermediates/flutter/release/isolate_snapshot_data --vm_snapshot_instructions=/Users/hdhuu/DATA/DEV/Sources/AndroidStudioProjects/your-reward-user/build/app/intermediates/flutter/release/vm_snapshot_instr --isolate_snapshot_instructions=/Users/hdhuu/DATA/DEV/Sources/AndroidStudioProjects/your-reward-user/build/app/intermediates/flutter/release/isolate_snapshot_instr --no-sim-use-hardfp --no-use-integer-division /Users/hdhuu/DATA/DEV/Sources/AndroidStudioProjects/your-reward-user/build/app/intermediates/flutter/release/app.dill
#0      runCommandAndStreamOutput (package:flutter_tools/src/base/process.dart:142:27)
<asynchronous suspension>
#1      GenSnapshot.run (package:flutter_tools/src/base/build.dart:68:12)
#2      AOTSnapshotter.build.<anonymous closure> (package:flutter_tools/src/base/build.dart:207:88)
#3      AOTSnapshotter._timedStep (package:flutter_tools/src/base/build.dart:363:33)
<asynchronous suspension>
#4      AOTSnapshotter.build (package:flutter_tools/src/base/build.dart:207:43)
<asynchronous suspension>
#5      BuildAotCommand.runCommand (package:flutter_tools/src/commands/build_aot.dart:143:56)
<asynchronous suspension>
#6      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:559:18)
<asynchronous suspension>
#7      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:495:33)
<asynchronous suspension>
#8      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#9      _rootRun (dart:async/zone.dart:1124:13)
#10     _CustomZone.run (dart:async/zone.dart:1021:19)
#11     _runZoned (dart:async/zone.dart:1516:10)
#12     runZoned (dart:async/zone.dart:1463:12)
#13     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#14     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:486:20)
#15     CommandRunner.runCommand (package:args/command_runner.dart:196:27)
<asynchronous suspension>
#16     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:396:21)
<asynchronous suspension>
#17     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#18     _rootRun (dart:async/zone.dart:1124:13)
#19     _CustomZone.run (dart:async/zone.dart:1021:19)
#20     _runZoned (dart:async/zone.dart:1516:10)
#21     runZoned (dart:async/zone.dart:1463:12)
#22     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#23     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:356:19)
<asynchronous suspension>
#24     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:111:29)
#25     new Future.sync (dart:async/future.dart:224:31)
#26     CommandRunner.run (package:args/command_runner.dart:111:11)
#27     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:242:18)
#28     run.<anonymous closure> (package:flutter_tools/runner.dart:60:20)
<asynchronous suspension>
#29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#30     _rootRun (dart:async/zone.dart:1124:13)
#31     _CustomZone.run (dart:async/zone.dart:1021:19)
#32     _runZoned (dart:async/zone.dart:1516:10)
#33     runZoned (dart:async/zone.dart:1463:12)
#34     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#35     runInContext (package:flutter_tools/src/context_runner.dart:50:24)
<asynchronous suspension>
#36     run (package:flutter_tools/runner.dart:51:10)
#37     main (package:flutter_tools/executable.dart:60:9)
<asynchronous suspension>
#38     main (file:///Users/hdhuu/DATA/DEV/Sources/Flutter/flutterSdk/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#39     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:298:32)
#40     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)

flutter doctor
[!] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.15 19A501i, locale en-US)
    • Flutter version 1.5.4-hotfix.2 at /Users/hdhuu/DATA/DEV/Sources/Flutter/flutterSdk/flutter
    • Framework revision 7a4c33425d (2 months ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)
    ✗ Downloaded executables cannot execute on host.
      See https://github.com/flutter/flutter/issues/6207 for more information

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/hdhuu/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment 18.9 (build 11.0.2+9-LTS)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.

[!] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    ✗ libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:
        brew update
        brew install --HEAD usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        brew install cocoapods
        pod setup

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/setup/#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.5901

[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.5)
    • IntelliJ at /Users/hdhuu/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.5901

[✓] Connected device (2 available)
    • Android SDK built for x86 • emulator-5554                        • android-x86 • Android 9 (API 28) (emulator)
    • iPhone Xʀ                 • 782566CB-D8D2-4F32-BDED-98886CB8BF43 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)

! Doctor found issues in 4 categories.

Thanks for filing this. It is actually this issue (Xcode version >= 10 no longer supporting 32-bit). Please subscribe to that issue for updates.


Don't have villagers shrink. They need to unhypnotize and drop soap and then walk off screen.

@wadek2 should we be animating them off screen like they are walking? it may look awkward - the other idea johnny had would be to put a bubble sprite on them (translucent) and have them float away off screen.


Incorrect extraction of GTot-subtyping

F* admits a subtyping rule for effectful functions such that a -> b is a subtype of a -> GTot b.  However this rule implies that a function f can have both the type a -> b and the type a -> GTot b, even though one extracts to a function while the other is erased.
We can use this rule to easily convert an erased ghost function to a total function and then call it:
module GTotSub

let t = nat -> nat
let f : t = fun x -> x + 42

let s = nat -> GTot nat
let g : s = f

irreducible let force_smt (x:Type) : y:Type { x == y } = x
let h : t = (g <: force_smt t)

let uhoh = h 42

Extracting this module predictably results in an OCaml program that crashes when run:
open Prims
type t = Prims.nat -> Prims.nat
let (f : t) = fun x -> x + (Prims.of_int (42))
type s = unit

type 'x force_smt = 'x
let (h : t) = Obj.magic ()
let (uhoh : Prims.nat) = h (Prims.of_int (42))

Interesting. Slight minimization:
let t = nat -> nat
let s = nat -> GTot nat

let f : t = (fun n -> n)
let g : s = f

let _ = assert (has_type g t)

This is accepted from (roughly) HasType f t and (= g f) in the encoding. Reminds me of https://github.com/FStarLang/FStar/issues/2069, a similar issue where the lack of universes in the encoding produces more equalities than there should be.

https://github.com/FStarLang/FStar/issues/1390 is another related issue. We reject subeffecting a -> Tot b into a -> Tac b since we need some internal marker to make sure the tactics normalize properly. Instead one can eta-expand (we also considered using coercive subtyping so the typechecker would automatically do it, but did not implement it).
I would imagine without that patch we run into the issue for tactics (reifiable effects in general). And also forbidding subeffecting of Tot arrows into GTot arrows, without eta expanding, would avoid this issue I think (but it would probably be painful for users).