openjfx11: init at 11.0.3+1

Motivation for this change
JavaFX (modern Java GUI framework) support in our GUI OpenJDK build. This allows for running JavaFX applications on NixOS. I don't know if any way to split it from OpenJDK and install it separately (perhaps via a symlink farm) exists; this is a documented way to integrate OpenJFX.
Before:
/nix/store/wkd27f2vi5vfx6c8cb0gcjaaxmhcfk4v-openjdk-11.0.3-ga	 637.7M

After:
/nix/store/vm1hzj1gs67xb0rqxndjrwvhxqz4j03y-openjdk-11.0.3-ga	 859.2M

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

OpenJFX 8 is quite a bit different so it's subject to future work.

really good timing, I needed this to try out bisq about 10 seconds ago. testing it now.

getting
hash mismatch in fixed-output derivation '/nix/store/pydsjv0h52hf8r5vvqrl99dkdl9983n8-openjfx-deps-11.0.3-11.0.3+1':
  wanted: sha256:0isga30c598y4qwx1r30cm2m3yz639kmyvrw5hwlkcpgbn5053lv
  got:    sha256:1zzq7wfj0yly2qrgfwml387cnhi4ad891nnw1lalqi3wls01f2z7

That's what I feared. Let me check.

Nothing. @jb55 can you fix the checksum and then show me find -L ./result -type f | xargs sha256sum?

@abbradar sure give me a sec, I'm running into further build issues so I'm going to update my unstable branch to rule out any weirdness

I'm getting this on unstable:
these derivations will be built:
  /nix/store/ijfad24igcym0pd3abll40i1ysbzaaj1-openjfx-modular-sdk-11.0.3-11.0.3+1.drv
building '/nix/store/ijfad24igcym0pd3abll40i1ysbzaaj1-openjfx-modular-sdk-11.0.3-11.0.3+1.drv'...
unpacking sources
unpacking source archive /nix/store/ak9da97df7sfmkjhlfn65dkyj3478v6r-11.0.3+1.tar.gz
source root is rt-11.0.3+1
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file rt-11.0.3+1/tools/scripts/whatChanged
patching sources
configuring
no configure script, doing nothing
building

Welcome to Gradle 4.10.3!

Here are the highlights of this release:
 - Incremental Java compilation by default
 - Periodic Gradle caches cleanup
 - Gradle Kotlin DSL 1.0-RC6
 - Nested included builds
 - SNAPSHOT plugin versions in the `plugins {}` block

For more details see https://docs.gradle.org/4.10.3/release-notes.html

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/nix/store/ch67lqkmfmbg7y12wqi3dzxc42nphifx-gradle-4.10.3/lib/gradle/lib/groovy-all-2.4.15.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
> Task :buildSrc:compileJava NO-SOURCE

> Task :buildSrc:compileGroovy
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/nix/store/ch67lqkmfmbg7y12wqi3dzxc42nphifx-gradle-4.10.3/lib/gradle/lib/groovy-all-2.4.15.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

> Task :buildSrc:processResources NO-SOURCE
> Task :buildSrc:classes
> Task :buildSrc:jar
> Task :buildSrc:assemble
> Task :buildSrc:compileTestJava NO-SOURCE
> Task :buildSrc:compileTestGroovy NO-SOURCE
> Task :buildSrc:processTestResources NO-SOURCE
> Task :buildSrc:testClasses UP-TO-DATE
> Task :buildSrc:test NO-SOURCE
> Task :buildSrc:check UP-TO-DATE
> Task :buildSrc:build

> Configure project :
*****************************************************************
Unsupported gradle version 4.10.3 in use.
Only version 4.8 is supported. Use this version at your own risk
*****************************************************************
gradle.gradleVersion: 4.10.3
OS_NAME: linux
OS_ARCH: amd64
JAVA_HOME: /nix/store/xdliin147xw3868k0z1qi3qcq6hrn6a2-openjdk-bootstrap/lib/openjdk
JDK_HOME: /nix/store/xdliin147xw3868k0z1qi3qcq6hrn6a2-openjdk-bootstrap/lib/openjdk
java.runtime.version: 10-internal+0-adhoc..jdk10u-jdk-1046
java version: 10
java build number: 0
jdk.runtime.version: 10-internal+0-adhoc..jdk10u-jdk-1046
jdk version: 10
jdk build number: 0
minimum jdk version: 10
minimum jdk build number: 46
HAS_JAVAFX_MODULES: false
HAS_UNSUPPORTED_DESKTOP: false
STUB_RUNTIME: /nix/store/xdliin147xw3868k0z1qi3qcq6hrn6a2-openjdk-bootstrap/lib/openjdk
CONF: Release
NUM_COMPILE_THREADS: 16
COMPILE_TARGETS: linux
COMPILE_FLAGS_FILES: buildSrc/linux.gradle
HUDSON_JOB_NAME: not_hudson
HUDSON_BUILD_NUMBER: 0000
PROMOTED_BUILD_NUMBER: 0
PRODUCT_NAME: OpenJFX
RELEASE_VERSION: 11.0.3
RELEASE_SUFFIX: -internal
RELEASE_VERSION_SHORT: 11.0.3-internal
RELEASE_VERSION_LONG: 11.0.3-internal+0-2019-06-20-182840
RELEASE_VERSION_PADDED: <IP_ADDRESS>
MAVEN_VERSION: 11.0.3-internal+0-2019-06-20-182840
UPDATE_STUB_CACHE: false
Building Webkit configuration /Release/ into /build/rt-11.0.3+1/modules/javafx.web/build/linux
module: project ':apps' (buildModule=NO)
module: project ':base' (buildModule=YES)
module: project ':controls' (buildModule=YES)
module: project ':fxml' (buildModule=YES)
module: project ':fxpackager' (buildModule=NO)
module: project ':fxpackagerservices' (buildModule=NO)
module: project ':graphics' (buildModule=YES)
module: project ':media' (buildModule=YES)
module: project ':swing' (buildModule=YES)
module: project ':swt' (buildModule=NO)
module: project ':systemTests' (buildModule=NO)
module: project ':web' (buildModule=YES)

> Task :verifyJava
> Task :base:processVersionInfo

> Task :base:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :base:processResources NO-SOURCE
> Task :base:classes
> Task :base:jar SKIPPED
> Task :base:assemble UP-TO-DATE
> Task :buildModuleBaseLinux
> Task :graphics:generateGrammarSource FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all files for configuration ':graphics:antlr'.
> Could not resolve org.antlr:antlr-complete:3.5.2.
  Required by:
      project :graphics
   > Could not resolve org.antlr:antlr-complete:3.5.2.
      > Could not get resource 'http://download.eclipse.org/eclipse/updates/4.6/R-4.6.3-201703010400/plugins/ivy.xml'.
         > Could not GET 'http://download.eclipse.org/eclipse/updates/4.6/R-4.6.3-201703010400/plugins/ivy.xml'.
            > download.eclipse.org: Name or service not known

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.10.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 23s
5 actionable tasks: 5 executed
builder for '/nix/store/ijfad24igcym0pd3abll40i1ysbzaaj1-openjfx-modular-sdk-11.0.3-11.0.3+1.drv' failed with exit code 1
error: build of '/nix/store/ijfad24igcym0pd3abll40i1ysbzaaj1-openjfx-modular-sdk-11.0.3-11.0.3+1.drv' failed

does this require stuff from master? It doesn't look like it...

sigh Okay, I think I know what happens. Give me several minutes.

Fixed. Fun fact - you need to build close-to-full JavaFX extra time to get all downloaded dependencies.

you need to build close-to-full JavaFX extra time to get all downloaded dependencies

my brain isn't parsing this, what do you mean?

I build JavaFX two times - the first one (thankfully without GStreamer and WebKit but still a full build) to get all dependencies into a fixed derivation as a byproduct.

oh that sounds fun. I got it to build! thanks!

Hmm this seems to be causing an evaluation failure on darwin?
error: while querying the derivation named 'openjfx-modular-sdk-11.0.3-11.0.3+1':
while evaluating 'assertValidity' at /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:246:20, called from /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/make-derivation.nix:278:18:
while evaluating 'checkValidity' at /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:227:19, called from /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:247:18:
while evaluating 'hasDeniedUnfreeLicense' at /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:63:28, called from /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:228:8:
while evaluating 'isUnfree' at /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:49:14, called from /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:66:5:
while evaluating 'toList' at /Users/r/code/nixpkgs-devel/lib/lists.nix:270:12, called from /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/check-meta.nix:66:15:
while evaluating the attribute 'meta.license' at /Users/r/code/nixpkgs-devel/pkgs/development/compilers/openjdk/openjfx/11.nix:105:5:
while evaluating the attribute 'meta.license' at /Users/r/code/nixpkgs-devel/pkgs/stdenv/generic/make-derivation.nix:319:19:
attribute 'license' missing, at /Users/r/code/nixpkgs-devel/pkgs/development/compilers/openjdk/openjfx/11.nix:105:15

Yeah - non-nixos linux x86_64, openjfx11 itself builds fine but openjdk11 fails: https://gist.github.com/risicle/15c36f01f70cec28f1c9879dad2375fd

@risicle I've fixed Darwin problems. No idea what happens with your build though. I've tested in against master now, it builds for me on x86_64 NixOS.

Running it again and it appears to be working this time :man_shrugging:

Very strange, it's not like I changed anything of significance apart from disabling Darwin.
Anyway, thanks for testing! I'll merge this in several days if there is no better ideas about closure size..


Updated Graph View (Nested Code Layout)Is Buggy

Describe the bug
A new feature was added to the development version of Ghidra under the Tool Options / Function Graph / Nested Code Layout to "Route Edges Around Vertices"  In general, the view is much better than the previous, but it is still fairly buggy.  Maybe 20% of the edges don't get routed around the code blocks and still go through the code blocks.  Sometimes they go straight through the middle, sometimes just through the edges.  Additionally, if you don't use the default code block layout, the graphing algorithm seems to get very buggy.  With the default field sizes, the graphing algorithm is maybe making 20% mistakes, but the field size for the instruction operands is too small to even see the operand in the graph view.  When I increase the size of the fields in the graph view so that I can view the entire instruction, operand, and comment, the graphing algorithm becomes much more buggy and is failing maybe 40% of the time.  With the increased field sizes, you also get many more overlapping edges instead of having them distinct.  Once the edges overlap, it because very difficult to read and determine where the edge starts or ends.
In either case, if the new features worked consistently, it would be enormously helpful and close to using other tools such as Ida Pro.  There are many situations where it is desirable or necessary to use the graph view over the decompiler.  In those situations of using the graph view, the portions where the edges go straight through code blocks makes it almost unusable because it's nearly impossible to follow where the control flow logic.  If this feature could be fixed to work consistently to the same accuracy as IdaPro, binary ninja, or radare2, it would make Ghidra a very attractive alternative.
I put a few screenshots below for examples with captions for comments.
Figure 1 shows several edges still going through the code blocks, though near the edge instead of straight through the middle.  This tool is using the default field sizes.

Figure 2 shows an example where the edge is still going straight through the middle of a code block.  This tool is using the default field sizes.

Figure 3 shows the same image as Figure 2 except for the default field sizes are not used.  In this case, I expanded the fields so that I could see the entire instruction, operands, and comments.  In this case, you can see the graphing algorithm has a major problem with the new field sizes.  Note that instead of the edges only going through the middle of 1 block, the edges go through 3 blocks and there are several overlapping edges that are indistinguishable.

To Reproduce
Open any moderatly complex malware file
Expected behavior
Ideally, if the edges can be routed around all code blocks so they do not go  through any existing code block regardless of the code block field sizes used.  It would also be very helpful to have the edges not overlap because it because extremely difficult to determine where the edge goes if you have overlapping lines.
Environment (please complete the following information):

OS: Windows 10
Java Version: openJDK 12
Ghidra Version: 9.1 (development built off of github page to test out new feature)

The images above are helpful to show the issues you have found.   We should be able to fix most of these pretty easily.

One thing you can try is to disable the 'Use Condensed Layout' option, which is enable by default.   This will fix some of the issues with edges flowing behind vertices.

Thanks for the quick response.  I tried to disable the "Use Condensed Layout", but it didn't correct the issue.  I redid one of the screen shots in case it's helpful with the condensed layout turned off.  Just as an FYI, if I turn off the condensed layout, the graph gets so spread out it makes it difficult to follow because you end up only seeing virtually only one code block on the screen at a time.  The spacing of the condensed layout seems to be pretty good in general so that you can see enough on the screen.  The places where the edges properly route around the code blocks works great.  It's just a problem where they don't get properly routed or get multiple over-lapping lines.

There is a fix in the 9.1 branch that addresses the biggest offending edge in the above screen shot.  There are also another couple bug fixes in progress to address the edges getting clipped by vertices.

thanks for the update.  2 quick follow on questions.
When you say there is a fix in the 9.1 branch for the biggest offender, does that mean I can generate a new build myself now to see how well the fix works?
for the additional bug fixes in work, is there anyway for me to track when the fixes are implemented so that i can test them out?
thanks again for all the support!

The first fix has been committed to 9.1, which means you should be able to build and test it.
The second bug fix branch is winding through review, but is not yet committed to 9.1.   I will update this ticket once the fix has been merged in.

thanks for all the hard work on Ghidra.  I built a new version of Ghidra to test and can definitely see an improvement.  Hopefully the second bug fix will correct more of the problems.
I'm assuming that when you say the first bug fix was for the biggest offender, that you are referring to when the edges go straight through the middle of a code block versus near the edges.  If that is the case, i wanted to provide some feedback that while it looks like it's doing better, there still seems to be something a little off in the logic.  I analyzed my example file and found several places where there are edges still going through the middle of the code blocks versus being near the edges.  I put one screenshot here if it's helpful.

If i'm misinterpreting what you were referencing as the biggest offender, no worries.  I'll test it out again once the 2nd bug fix is included.  I just wanted to provide some quick feedback as an FYI in case the routing algorithm is working better on your test files so that you have more information.
Keep up the good work.

The new fixes are now in master.

The first fix addressed the odd case where an edge could degenerate into a spaghetti-like leviathan, with nonsensical protrusions.   The second fix addresses the issue above, the lines traveling behind vertices.
Keep us posted if there are still degenerate cases after these fixes.
Thanks for the testing help.

i built a new version of Ghidra to test out the fixes.  I can see an improvement, particularly in that first case you mentioned.  For the second situation with lines traveling behind vertices, i think it got better, but unfortunately there's still a fair number of occurances with the lines going behind the code blocks.  I put a few examples below.  I tried testing it both with the default code block sizes and with a view where I expanded the field sizes so the instructions are fully shown.  It didn't seem like one view did particularly better than the other.  It's a little strange because there are places with the default field sizes that are having the problem but are ok in the expanded field  sizes and vice versus.  I tried looking, but I can't seem to find any type of pattern where the edges are going behind the code blocks.  For some reason, it just seems like the routing algorithm can't always identify the code block locations.  In some situations, the edges cut straight through the middle of a code block.  In other situations, the edges try to route around the code blocks, but don't quite make it and still go through the code block, just near the edge instead of through the middle.

Note in this second image, the purple line that's doing a funny route around the code blocks is the same line in the first image that went straight  through the middle of the the code blocks.  For some reason, the first situation the algorithm didn't seem to know the code blocks were there, but the 2nd situation it seemed to know the location of the code blocks.  You can also see the green lines going through the code blocks again; near the middle in one code block but near the edge in another code block

I think the improvements are really helpful for Ghidra.  Compared to the other available tools like binary ninja or ida pro, the decompiler is a nice addition, but the graph view is a little more of a subtraction.  It makes deciding to use Ghidra a little more difficult because you need to decide if the decompiler addition is worth the graphing subtraction.  I think if it's possible to improve these graphing routing algorithms so they are in line with the other available tools, it makes Ghidra much more competitive because you can decide to use it without losing anything from the other tools.  You would only be gaining functionality.
If I should put these images in a new bug request since this ticket was closed, let me know.  I'm guessing this graphing problem must be more complicated then it seems and i appreciate all the work you guys are putting into the tool.

Having the images here is fine, since we are actively examining the issue.
It appears from your samples that there are still bugs in the algorithm.   That being said, there will be cases that degenerate when the graph gets too complicated.   This layout, and graph layouts in general, seek a pleasing aesthetic by valuing symmetry and minimal edge crossings.   The original edge layout algorithm minimizes crossings by combining edges flowing to the same end point.   The new mode of routing around vertices means that we will get more edge crossings, including times where the edges travels behind vertices.   This is even more likely when we condense the vertices to save space.    Ideally, we can fix the bugs causing the edges to flow behind the vertices, which will make the graph easier to read.  But, all of the competing requirements mean that there is no real perfect solution.
It is possible that we can create different layouts for the Function Graph that are easier to use/read, depending upon what the user is trying to accomplish.  I have experimented with other layouts and have found the current one to be the best for quick visual scanning and for determining overall high-level function flow.   It is possible that a more simplistic layout would make following individual edge flow easier.     If you get the time, then the best way forward is to create a new ticket  requesting a new graph layout, with descriptions of your typical workflow(s) included.   This information will be valuable if we decide to allocate resources to this area.
Regarding this ticket specifically, we will investigate the issues you have shown above and update this ticket if we have any new related fixes.

I have already found another bug; still looking for more edge cases.
Also, in case I didn't mention it, you can always select an edge by clicking it if you are having trouble following its path through the graph.   Once the edge is selected, it becomes emboldened, making it much easier to follow.   (Also, fun tip: you can double-click and edge to navigate to each endpoint.)

There is a bug fix making its way through code review, but I don't think it will fix the issues you have reported.
I did find cases that looked similar to your screen shots.   When you see the edges move behind the vertices, as you have shown above, try turning off the 'Use Condensed Layout' feature to see if they no longer get clipped.   If they are still clipped, then that is a bug; if they are no longer clipped, then that is a flaw of how the algorithm currently works.
It is possible that we could fix the algorithmic flaw, but that is not likely to happen for the 9.1 release, as it could require much more work.

Not sure if it's good news or bad, but I turned off the "Use Condensed Layout" feature and the problem was fixed.  I went through the entire binary and didn't see any location where the edges were going behind any of the code blocks.  They always seemed to route around the code blocks properly.
I agree with your assessment that the current layout is pretty good for visual scanning the function flow.  I think if the algorithm can be fixed for a future release so that it works as is while still using the condensed layout, the solution would be pretty good.  The condensed layout is definitely preferable as the graph gets a little too spread out without it, but i can uncheck the option for now.
When the algorithm works, the only major downside I've seen is that it looks like a fair number of edges get overlapped so that you can't distinguish between them without clicking on one to highlight it.  If it were possible to fix the algorithm for a future release and also have some type of minimum separation between all of the edges, I think it would be comparable to the other RE tools.  I'm not quite sure, but it sounds like the overlapping edges might be a design choice for aesthetics rather than a bug though.


OpenSCD as custom element published on npm

PR:

https://github.com/openscd/open-scd/pull/1485

We have a few global things going on in our index.html
Settings
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover" />
<meta name="Description"
    content="Open Substation Communication Designer is a bottom-up system configuration tool for projects described using IEC 61850-6 Edition 2 or greater.">
<base href="/">

External Stylesheets
  <!-- Original URL from Google: https://fonts.googleapis.com/css2?family=Roboto+Mono:wght@300&family=Roboto:wght@300;400;500&display=swap -->
  <link href="public/google/fonts/roboto-v27.css" rel="stylesheet">
  <link href="public/google/fonts/roboto-mono-v13.css" rel="stylesheet">
  <!-- Original URL from Google: https://fonts.googleapis.com/css?family=Material+Icons+Outlined&display=block -->
  <link href="public/google/icons/material-icons-outlined.css" rel="stylesheet">
  <link href="public/css/normalize.css" rel="stylesheet">

Favicons
  <link rel="manifest" href="manifest.json">
  <link rel="icon" type="image/png" sizes="16x16" href="public/favicon-16x16.png">
  <link rel="icon" type="image/png" sizes="32x32" href="public/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="192x192" href="public/icon-192x192.png">

Protection of Duplicate Custom Tags
<script>
const _customElementsDefine = window.customElements.define;
window.customElements.define = (name, cl, conf) => {
  if (!customElements.get(name)) {
    _customElementsDefine.call(window.customElements, name, cl, conf);
   }
};
</script>

Registering Services Workers
<script>
  if ('serviceWorker' in navigator)
    navigator.serviceWorker.register('/sw.js');
</script>

Prevention of Data/Work Loss on Closing OpenSCD
  <script>
    const openScd = document.querySelector("open-scd");
    addEventListener("beforeunload", e => {
      if (openScd && openScd.doc) {
        e.preventDefault();
        return e.returnValue = "Are you sure you want to exit?";
      }
    });
  </script>

All these things still need to work when we use OpenSCD as a single custom element.
The nice thing is that, the elements does not necessarily need to be in the <head>.
We can put them into a wrapper element that behaves like the index.html.
However this element would scope everything into its own shadow DOM. For that we can create a light DOM element by using the createRenderRoot function:
  protected createRenderRoot(): Element | ShadowRoot {
    return this;
  }

This opts out a lot of custom element features but in this wrapper we don't need anything.

I have tried to do it with Vite, but it does not like dynamic imports, even with plugins it does not compile something that is not referenced so OpenSCD could not load the plugins.
There might be some configurations with which I could force vite to compile every file, but I did not find a solution in reasonable time.
Next, I will try to publish the whole build to npm but I think everything it will try to load from the public will fail.

Publishing the whole build folder works, but the assets are not loading through unkpg.com, but could load if deployed to github pages

Deploying to GitHub Pages worked for the plugins. Or at least they load.

However, the assets are not yet correct. I think I would bundle every asset that we need so you don't have to depend on some setup or fix location for them.
What does not work is the suppression of duplicate custom tags

I also got this "undefined entity" error

and the plugins don't seem to work either

After a talk with the team we agreed on that distributions take care of:

service workers
bundling of favicons
plugins and their locaion

Each plugin will have its own package and there will be an essential plugin package that contains the official essential plugins


Unable to login with OpenID connect

Describe the bug:
To Reproduce

Deploy otomi with default settings
Go to gitea dashboard
Click OpenID login button
Observe error 404 not found

Expected behavior:
Can login by clicking OpenID button

do we care in dev mode? I think this is not a problem

I found differences between working and not working setup for gitea OpenID login
After a user clicks the OpenID login button a GET  https://gitea.<IP_ADDRESS>.nip.io/user/oauth2/otomi-idp
In the response there is redirect URL:
Correct redirect
https://keycloak.<IP_ADDRESS>.nip.io/realms/otomi/protocol/openid-connect/auth?client_id=otomi&redirect_uri=https://gitea.<IP_ADDRESS>.nip.io/user/oauth2/otomi-idp/callback&response_type=code&scope=openid&state=cecc23da-fac7-4ed8-9272-117295e2a299

Incorrect redirect which cause HTTP 404
/user/oauth2/?client_id=otomi&redirect_uri=https://gitea.<IP_ADDRESS>.nip.io/user/oauth2/otomi-idp/callback&response_type=code&scope=openid&state=e7927f00-2f39-4c99-b29a-e74f38ce4e1d

Now we need to find it out why the configuration differs

Killing gitea Pod solves this issue.

Added info in post-install steps: https://otomi.io/docs/installation/post-install/


Support PDF Export in Preview V2

Context
Proposal

The easiest way is obviously to use a headless chrome.
I would prefer export to LaTeX, and then compile it to PDF, it would look so much better.

i like the way markdown-preview-enhanced (MD-P-E) does it.
you right click on the preview and then choose how to export.
very happy just to have that. the v2 enhancement for this is to have commands specific to each export.
which even MD-P-E doesn't have.
Also good to have a settings way to set default export.
you know how u have a paste image and auto you sent to /assets folder? would be good to have somethign similar for /exports then .gitignore that folder.

closing in favor of https://github.com/dendronhq/dendron/issues/1204


Change site to use typewind

Attempt to use the library on the own website. Making it work will be a great display, but will require solving some crucial bugs happening. Currently it breaks with the following:

this gave me the idea to write a codemod, from tailwind to typewind 🤔. I'll write an issue soon

hey! thanks I'll look into these issues

Some styles were different from the original website so I've fixed those and formatted them correctly. Merging 👍


[Das Schwarze Auge (TDE) 5 OFFICIAL by Ulisses] v1.1.1

& damage buttons rolltemplate
Changes / Comments
Bugfix

Fix repeating row attacks not clickable anymore

Enhancement

Roll damage button for rolltemplates

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Fixed MSVC architecture detection regular expression

MSVC regular expression doesn't account for the remaining '0' when
parsing "Visual Studio 10 2010..". The 3rd regex remove [1-9] where it
should be [0-9].

@PyrO70 Thanks. Just for your information I've added a test: https://github.com/ruslo/hunter/commit/a40830ef8ce073efbbddc8e886e5863e4f10b17d


Animate VisualState changes of Caption Buttons

Description of the new feature/enhancement
Win32 apps have a short fade animation on pointer enter and exit events, but UWP apps do not. I propose having a short fade animation only when the pointer hover ends on caption buttons, so the app feels snappy on pointer hover start but has a smooth animation on hover end. Its super nit picky and maybe opinionated, so tell me your thoughts

Proposed technical implementation details (optional)
Add storyboard coloranimation to MinMaxControl.xaml to animate visual state changes. I would be willing to work on this if the proposal is accepted😊

Sure absolutely, go for it!


RandomForest with configuration .all hyperparameters

Why random forest is not accepting my parameter n_estimator .i cannot find any documentation about random forest since its my one of the favourite algo and far good than cart.and one more thing ..how can i do cross validation and hyperparameter tuning ?
heres my config.json.

To find the names of the configurable fields you can either inspect the source code, or use the DescribeConfigurable tool from OLCUT. For example:
java -cp tribuo-classification-experiments-4.0.1-jar-with-dependencies.jar com.oracle.labs.mlrg.olcut.config.DescribeConfigurable -n org.tribuo.common.tree.RandomForestTrainer -o true

Produces the output:
Class: org.tribuo.common.tree.RandomForestTrainer

Field Name   Type                                 Mandatory Redact Default Description
combiner     org.tribuo.ensemble.EnsembleCombiner true      false          The combination function to aggregate each ensemble member's outputs.
innerTrainer org.tribuo.Trainer                   true      false          The trainer to use for each ensemble member.
numMembers   int                                  true      false          The number of ensemble members to train.
seed         long                                 true      false          The seed for the RNG.

Example :
<?xml version="1.0" encoding="utf-8"?>
<!--OLCUT configuration file-->
<config>
<component name="example" type="org.tribuo.common.tree.RandomForestTrainer" export="false" import="false">
	<property name="seed" value="0"/>
	<property name="combiner" value="EnsembleCombiner-instance"/>
	<property name="innerTrainer" value="Trainer-instance"/>
	<property name="numMembers" value="0"/>
</component>
</config>

You can see the configurable variables and an example configuration snippet in xml, edn or json depending on the program arguments. We'll update the docs to reference this tool more clearly, but as Tribuo is open source you can see all this information in the code.
For the RandomForestTrainer the number of ensemble members is controlled by the numMembers field.
To perform hyperparameter tuning you'll need to measure the performance using either CrossValidation or a held out validation set, and then manually tune the parameters. It should be straightforward to write a grid search or random search for any specific trainer as you'll know the parameters you want to tune. We're considering how hyperparameter tuning would fit into Tribuo in a more general way, but we don't have anything to share at the moment.

okk i understand numMembers is the num of trees and other params are same
as decision tree.
and how can i use crossvalidation is there any tribou api for cross
validation or i have to manually use For loop for training and testing my
model.?
On Sun, 25 Oct 2020 at 20:34, Adam Pocock<EMAIL_ADDRESS>wrote:

To find the names of the configurable fields you can either inspect the
source code, or use the DescribeConfigurable tool from OLCUT. For example:
java -cp tribuo-classification-experiments-4.0.1-jar-with-dependencies.jar com.oracle.labs.mlrg.olcut.config.DescribeConfigurable -n org.tribuo.common.tree.RandomForestTrainer -o true
Produces the output:
Class: org.tribuo.common.tree.RandomForestTrainer
Field Name   Type                                 Mandatory Redact Default Description
combiner     org.tribuo.ensemble.EnsembleCombiner true      false          The combination function to aggregate each ensemble member's outputs.
innerTrainer org.tribuo.Trainer                   true      false          The trainer to use for each ensemble member.
numMembers   int                                  true      false          The number of ensemble members to train.
seed         long                                 true      false          The seed for the RNG.
Example :

You can see the configurable variables and an example configuration
snippet in xml, edn or json depending on the program arguments. We'll
update the docs to reference this tool more clearly, but as Tribuo is open
source you can see all this information in the code.
For the RandomForestTrainer the number of ensemble members is controlled
by the numMembers field.
To perform hyperparameter tuning you'll need to measure the performance
using either CrossValidation or a held out validation set, and then
manually tune the parameters. It should be straightforward to write a grid
search or random search for any specific trainer as you'll know the
parameters you want to tune. We're considering how hyperparameter tuning
would fit into Tribuo in a more general way, but we don't have anything to
share at the moment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oracle/tribuo/issues/75#issuecomment-716162592, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AL3BT7GLM2FGJB5WRGMTLFTSMQ47PANCNFSM4S6GY3XA
.

You can use the CrossValidation, and then aggregate the evaluations using EvaluationAggregator to pull out the mean of whatever statistic you are maximising or minimising.
You will need to do the parameter selection yourself inside some kind of loop.

I've added some examples of the configuration description to the doc-fixes branch in the docs and in the configuration tutorial.

thankyou adam...sorry for another question but i m still struggling with
random-forest algo.not accepting my hyperparameters in
config.json.impurity,maxdepth not accepting. dont know why?
On Tue, 27 Oct 2020 at 02:05, Adam Pocock<EMAIL_ADDRESS>wrote:

I've added some examples of the configuration description mechanism to the
doc-fixes branch in the docs and in the configuration tutorial.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oracle/tribuo/issues/75#issuecomment-716807826, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AL3BT7G7UEVRKC4PRG5X6CTSMXMSXANCNFSM4S6GY3XA
.

Those are parameters of the tree algorithm you supply to the RandomForestTrainer. You need to pass it a reference to a tree algorithm elsewhere in the config, and an ensemble combiner (e.g. for classification use VotingCombiner). There is a complete example random forest classification configuration file here.

thanks a lot it helped me a lot.
On Tue, 27 Oct 2020 at 19:18, Adam Pocock<EMAIL_ADDRESS>wrote:

Those are parameters of the tree algorithm you supply to the
RandomForestTrainer. You need to pass it a reference to a tree algorithm
elsewhere in the config, and an ensemble combiner (e.g. for classification
use VotingCombiner). There is a complete example random forest
classification configuration file here
https://github.com/oracle/tribuo/blob/main/Classification/Experiments/configs/random-forest-example.xml
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oracle/tribuo/issues/75#issuecomment-717256103, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AL3BT7AGCMU3RZABHCS7BWDSM3FUHANCNFSM4S6GY3XA
.


Istio default retry strategy is transparently retrying POST requests that connected fine

As you can see from this trace, a POST request reached vehicle-metric-service, and for some unknown reason (likely https://github.com/istio/istio/issues/13848) it 503's mid processing.
It was then retried by the default retry policy.
I really do not think the default retry policy should retry anything which successfully connected, only connection errors.  @nmittler I know we've talked about this before but couldn't find the associated thread.

If this is to be expected then at the least you need to call it our or give people the ability to disable it, there are most definitely code paths we would not want to just retry without the source service being involved in that decision.

So the issue here is that we include retries on 503 by default (which you can modify).
Envoy doesn't currently allow the configuration of retries on a per-method basis, but it probably should.
@PiotrSikora WDYT?

So the issue here is that without 503 retries things like https://github.com/istio/istio/issues/13848 become an even bigger problem.
The retries are currently masking that issue.
I can't help but think the 503 here too was completely unjust and linked to that issue.

@Stono servers are allowed to terminate their end of the connection during the idle period.  That should be considered routine behavior, but the client must handle that event well and I'm not sure it is.

@arianmotamedi if we had the Envoy PR that detects the closed by upstream you mentioned in https://github.com/istio/istio/issues/13848#issuecomment-489751037, we could retry 503s less aggressively which could address this issue.
@PiotrSikora @jplevyak @silentdai

@duderino - is there anything tracing what we talked about re separating 502 and 503, and only retrying 502/network level errors as that would address this issue I think

https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html says POST is not idempotent. Shouldn't the default therefore be to not retry? Am I missing something?

Nope you're correct.  A POST imo shouldn't be retried unless the error was a connection error

I am not sure I agree. The error could be raised after the action of the POST was performed. In that case, the retry would lead to an inconsistent state. https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.5 doesn't really indicate otherwise.

Sorry perhaps I'm not being specific enough.  I mean if one envoy fails to connect to the other.

That makes sense but then you would obviously need to ensure that the HTTP status was raised by the proxy and not the server. Also the proxy would need to ensure it did not forward the POST. I am not sure how reliable that can be done but I am certainly no expert.
Still I am not sure what the default should be. Maybe it should be optional?

Aye I completely agree with you and that's exactly the conversation I had with the istio folks a week or two ago.
At the moment 503 is used and covers too many scenarios.  Both envoy and upstream get wrapped by it

Great, thanks for clarifying!

Here's my two cents on this: network errors happen. With Envoy or without, at some point something in the lower level causes the packets to get lost. When that happens, the client will almost never know if the request had reached the server for processing or not, so it has no choice but to either retry or report a failure. And as correctly mentioned here, http retries can have significant consequences for non-idempotent requests (POST, PUT, DELETE, etc.). Sure you could implement logic in Envoy to only retry on GET requests, but what about everything else? A 503 is simply "something happened up there and I didn't get what I expected back". A 503 won't include the state of the server, so there is absolutely no way for Envoy (or ANY client) to 100% detect if the request is eligible to be retried or not (only exception is a CONNECT failure which can be safely retried, but that's hardly ever the case for 503 errors). I want to emphasize on this because there seems to a misconception that a specific 503 flag (UC) means the issue is from Envoy-to-Envoy communication and it never made it to server. That's simply not true.
The real solution is to write code in a way that all requests (GET and POST) are idempotent from the server's perspective - that way failed requests can be safely retried. There are lots of articles out there on how to implement idempotency in microservices, but the simplest way is to have the client generate a unique id and pass it as a header to the server ("x-request-id"). Once the server gets the request, it processes it and stores the result for that id in a cache table. If a network-level error happens at this point, the client (Envoy) retries the request with the same id. This time the server sees that the request has already been processed, so it simply returns the cached result without processing the request again. Similarly if the connection is dropped before the request makes it to the server, next retry will cause the server to process it because it'll get a cache miss for that specific id.
I understand that this might not be the answer you were looking for, but unfortunately you can't have 100% resiliency by just relying on Envoy to do retries on its own.

I agree entirely.  Connection errors should be the only thing retried as I said in my OP, this retry happened on a POST after a successful connection.
So to clarify... the current strategy of retrying on 503 is wrong.

Just to further clarify what I meant by 503's masking connection errors, on this diagram there are 3 distinct connections, all of which can fail to connect.  At the moment, C which is a failed connection from destination envoy to the local app (lets say, because the app hasn't started), is manifested back as a 503 with a response flag of UC.
This is what I mean about 503 being used to wrap too many scenarios, some of which likely can be retried (such as a connection issue between and envoy and an app).

If "C" fails with CONNECT_FAILURE, it needs to be retried by Dest Envoy, not Source. The only case Source envoy can retry is also on a CONNECT_FAILURE to Dest Envoy; any other 503 is ineligible unless idempotency is implemented in Dest app.

Yes I agree... I was simply telling you how it works now.  I really feel like we're saying the same thing here and I'm not sure how else to word it:  "Connection errors should be retried anywhere they can occur by the system instantiating the connection".
At the moment, they don't, they're wrapped in a 503 and retried by a default retry policy on all 503a.

Agreed, but I'd like to make an amendment to your statement:

Connection errors should be retried anywhere they can occur by the system instantiating the connection if and only if upstream can guarantee idempotency.

And I want to clarify - when I see the word "connection", I tend to think about established connections. When I say only CONNECT errors are always safe to retry, I mean the literal http CONENCT method to initiate a new connection. Once the connection is established (ACK'd), nothing else can be retried without knowing the implications.

Fair enough, I definitely mean un-acked connections, eg connections that have not been established.

I personally agree that without deeper understanding of the 503 reason, istio shouldn't retry POST.
@mandarjog  Do you have more contexts on why istio still retry since #13848 is resolved.

You wanna have a chat with Josh who had a list of action items leading towards not retrying 503

@howardjohn @duderino as discussed, 503 errors should not be retried by default. It can be manually added if needed (and if the consequences are understood by the consumer). Unless there are any objections, I'm going to open up a pr to remove it from the default policy.

I agree with that move, however prepare yourself for a raft of "503" issues that get opened.  Those retries were added during a phase of istio getting a lot of stick about 503's, and right now they do retry 503s as a result of CONNECT errors too.    It might be worth pulling together some doco that explains how to debug 503s (similar to my blog post https://karlstoney.com/2019/05/31/istio-503s-ucs-and-tcp-fun-times/index.html)
Also; i think there should be a broader "epic" covering the work @duderino captured some weeks ago (eg retries on CONNECT errors), not using 503 for everything, etc.

CONNECT errors aren't included in 503s, Envoy treats them separately. Istio's default retry policy includes both connect-failure as well as 503 as a retry-able status code: https://github.com/istio/istio/blob/master/pilot/pkg/networking/core/v1alpha3/route/retry/retry.go#L33. Removing 503 won't affect connect-failure retries.

OK if you're sure.  I just remember a lot of things like 503's during app rollouts because envoys had stale config (whilst waiting for pilot pushes) etc...
In summary that retry was added for a reason, it's worth just double checking the underlying causes that can be addressed have been otherwise you'll be faced with all the old 503 drama again.

Hey, I'm rekindling this subject.
Transparent retries of non-idempotent (POST) requests on anything other than gateway connection errors still doesn't feel right, so it'd be nice to get some traction on this discussion again.

@duderino @PiotrSikora @lambdai any update on this?

@Stono Why did you close this issue? This seems to be relevant even now. Envoy retrying 503's is causing a lot of issues for us

We ran into this problem too.

The same problem here. Istio 1.7.4.
The microservices has its own mechanisms of transaction compensation on integration failures.
But Istio still retrying requests, when some integrations has 503 status code responses.
I need to disabled it. At least on POST. And let the application take care of it.

Why not something like this to disable it?
`
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: "httpbin-virtual-service"
spec:
hosts:

"*"
gateways:
my-istio-gateway
http:
match:

method:
exact: POST
uri:
prefix: /status/503
route:
destination:
host: "httpbin"
port:
number: 80
retries:
attempts: 0
`

Run into the same issue. Explicit retries disabling in VirtualService did help.

Running into the same issue.  Has anyone come up with a work around?  Explicitly disabling the retries hasn't fixed it for us.   We are using Red Hat OpenShift Service Mesh which is using upstream 1.9.9

We ran into the same issue too.  I experimented with changing our microservices to return 508 - Loop Detected instead of a 503 and this fixed it so that istio is not performing retries.  I suspect that many other values in the 5xx range would do the same trick, not just 508.  But, I'm not happy at the prospect of having to make a ton of code changes just to make it so that POSTs are not retried when the application returns a 503.  I agree, give us the option to let the application handle retries by being able to turn this "feature" off.

I finally think with the release of 1.23; this issue can be closed :D


[CARBONDATA-2901] Fixed JVM crash in Load scenario when unsafe memory allocation is failed.

Problem: Jvm crash in Load scenario when unsafe memory allocation is failed.
scenario:
a) Have many cores while loading. suggested more than 10. [carbon.number.of.cores.while.loading]
b) Load huge data with local sort, more than 5GB (keeping default unsafe memory manager as 512 MB)
c) when task failes due to not enough unsafae memory, JVM crashes with SIGSEGV.
root casue:
while sorting, all iterator threads are waiting at UnsafeSortDataRows.addRowBatch as all iterator works on one row page.
Only one iterator thread will try to allocate memory. Before that it has freed current page in handlePreviousPage().
When allocate memory failed, row page will still have that old reference. next thread will again use same reference and call handlePreviousPage().
So, Jvm crashes as freed memory is accessed.
solution:
When allocation failed, set row page reference to null.
So, that next thread will not do any operation.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8189/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/118/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8236/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/165/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/8237/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/166/

LGTM


config.ocelot has mistakes

From<EMAIL_ADDRESS>on August 16, 2009 15:11:12
Hi,
when reading config.ocelot, these two lines are executed:
fi.descend("ocelot");
fi.descend("OcelotRuntime");
but the example config.ocelot in svn hasn't got OcelotRuntime tags,
adding them causes Ocelot runtime to load it's settings.
Also there is an unneeded 0 inbetween tags.
Attaching corrected file.
Attachment: config.ocelot
Original issue: http://code.google.com/p/gpuocelot/issues/detail?id=22

From<EMAIL_ADDRESS>on August 23, 2009 13:28:12
Added your file to replace ocelot.config.  Please verify that it works correctly now.
Status: Fixed


⚠ Account - Ascentia has degraded performance

In 3ab0e1f, Account - Ascentia (https://account.ascentia.fr/) experienced degraded performance:

HTTP code: 522
Response time: 15592 ms

Resolved: Account - Ascentia performance has improved in f7aa46b.


DynamicBufferMesh

a little bit late to the party, but would it be possible to have the Vertex Offset on the Stride DynamicBufferMesh node exposed as an optional pin? Just came across this this weekend and i thought it could make sense as it would enable e.g. multiple triangle strips being rendered from one buffer.
Addendum: to take advantage of the example given one would also need the Count pin exposed though..^^

https://matrix.to/#/!fSWTWNSnJwBXstXVeA:matrix.org/$sswWuFK2XXcNhZwP506sqCWS3vIqoelSmBWVPOYMJfI?via=matrix.org


Add ViewRow as a field to TextDocumentShowOptions

When using the TextDocument API, specifically vscode.window.showTextDocument TextDocumentShowOptions should also have a ViewRow so that for instance, one can do
vscode.window.showTextDocument(vscode.Uri.parse("/tmp/someFoo"), { viewColumn: 2, viewRow: 2});

This would useful in a whole host of scenarios. I suppose it comes with some challenges; like for instance
How do the windows get laid out; if there is only 1 column, and the next opened window is opened on row 2, and then another window is opened after that in column 2, does the previous "split down" take precedence and thus take up the entire width, or does columns take precedence?
Probably be wise to add another field, if this functionality is added, that sets precedent for the layout. There's a host of examples from X Windowing managers to look for, for inspiration to solve this problem. This way, the user can decide the layout of the split so that one can get these results
 ______ ______
|      |      |
|      |      |
|      |      |
|______|______|

But also
 _____________
|      |       |
|______|______ |
|              |
|______________|

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Feature gogs

added 2 links, sorry not very familiar with forking ... a little mess with the differents commit

Thank you! I will merge it manually, it is not a problem.


Fix the problem that the 'adb shell input swipe' command is invalid.

Fix the problem that the 'adb shell input swipe' command is invalid. https://github.com/flutter/flutter/issues/94534
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

cc @Piinks

Hi @Piinks , Thanks for your reply.
First, Configure this myself in my app is work. But I think the previous submission (#81569) brought break change. As I described in the issue(#94534) :

It will confuse the user? Because in previous versions, this wasn't required to let adb scroll a page.
If the user does not understand PointerDeviceKind, it may take a long time to locate and know it needs to be set through this API.
I don't think we should hand over the cost to developers.
Maybe we should just disable mouse swiping, and not affect any other ways of swiping.

#81569 was announced as a breaking change when it was released. A migration guide was also provided to help users update their apps to maintain or change the behavior they had before that change. I think it may be more appropriate for us to update the migration guide to include this use case. I do not know if it is a correct assumption to let an unknown pointer device act like a touch device, but it is very easy to configure the devices that you would like to have supported in your app.
Migration guide: https://docs.flutter.dev/release/breaking-changes/default-scroll-behavior-drag
Announcement: https://medium.com/flutter/whats-new-in-flutter-2-5-6f080c3f3dc

I see that the bug was updated to update the migration guide. I am going to close this PR then as per @Piinks's previous comment.


[Question] How much do you use it in Basecamp?

Hi!
I'm curious to know how much you use it in Basecamp. If it's fine to share it, of course.
In which cases have you decided not to use it and what did you look for instead?

We use it… a lot? Feel free to View Source.  :)


Why must Keybase open my browser to show me Getting Started on every launch? :(

Keybase GUI Version: 1.0.18-20161219185928+7868d49

this seems like a bug, @cjb / @gabriel

Yes, it shouldn't.  @taylorbanks, please could you run keybase log send?  Thanks!

Success! log ID:   2b8df04790e03d951ee0f41c
Why I jump out of bed every morning: http://TheLearningBanks.com
How I afford this dream life: http://Ecom.School
On Mon, Jan 9, 2017 at 2:12 PM, Chris Ball<EMAIL_ADDRESS>wrote:

Yes, it shouldn't. @taylorbanks https://github.com/taylorbanks, please
could you run keybase log send? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/5321#issuecomment-271378277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALocIwMpQG1bH_O2XUsMOW3PjXBCWhYks5rQoaogaJpZM4LeljG
.

What's the output of?
ls -al "~/Library/Application Support/Keybase/started.txt"
ls -al ~/Library/Caches/Keybase/started.txt

No such file or directory in either location.
Why I jump out of bed every morning: http://TheLearningBanks.com
How I afford this dream life: http://Ecom.School
On Mon, Jan 9, 2017 at 3:30 PM, Gabriel Handford<EMAIL_ADDRESS>wrote:

What's the output of?
ls -al "~/Library/Application Support/Keybase/started.txt"
ls -al ~/Library/Caches/Keybase/started.txt
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/5321#issuecomment-271398732,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALocD0DQrfDsaoAoDx1B4k_JjoouZGEks5rQpj7gaJpZM4LeljG
.

What are the permissions of ~/Library/Application Support/Keybase and ~/Library/Caches/Keybase?
ls -al ~/Library/Application\ Support/ | grep Keybase
ls -al ~/Library/Caches/ | grep Keybase

Are you able to run:
touch "~/Library/Application Support/Keybase/started.txt"

Hmm.. 700 permission on both. The file now exists (prior to attempting to
touch it). :\
Why I jump out of bed every morning: http://TheLearningBanks.com
How I afford this dream life: http://Ecom.School
On Fri, Jan 13, 2017 at 2:02 PM, Gabriel Handford<EMAIL_ADDRESS>wrote:

What are the permissions of ~/Library/Application Support/Keybase and
~/Library/Caches/Keybase?
ls -al ~/Library/Application\ Support/ | grep Keybase
ls -al ~/Library/Caches/ | grep Keybase
Are you able to run:
touch "~/Library/Application Support/Keybase/started.txt"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/5321#issuecomment-272519443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALocGUVf19Rcz356HHkNmHuHAvwc_1Vks5rR8pbgaJpZM4LeljG
.

Do you still get the "getting started" web page on startup or has that stopped happening?


[Question] How to show 3d Object that can play like running or fly. but not video

i have few question. can i show 3D animation object can played ? in AR core. and if i wanna show that object just in some location (like pokemon go) how i can do that. plesase show me some reference. i realy news about AR. thanks

For advice and general questions, please use the Sceneform tag on
Stack Overflow: https://stackoverflow.com/questions/tagged/Sceneform
In addition, please see the Sceneform SDK developer documentation and API reference.


Scroll bar is too thin to select it properly

When I have multiple sheets open, it is very difficult to select the scroll bar, because it's too thin (see below)

It would be great to make the scroll bar bigger so you can move around your spreadsheets with ease.
Tried on the Windows executable v2.1.1

should be fixed in 2.3.7, please close once tested

The scroll bar is thick enough. Closing


Once I connect the pet shop to my wallet, every Adopt button turns into Success without me doing anything.

Once I connect the pet shop to my wallet, every Adopt button turns into Success without me doing anything. Can @adrianmcli or anyone fix this? My repo is below: https://github.com/dennymrh/pet-shop-tutorial

I'm curious about this issue, let's re-open this. Either I or someone else will look at this sometime soon.

Thanks Adrian
On Mon, Jul 15, 2019 at 4:35 AM Adrian Li<EMAIL_ADDRESS>wrote:

I'm curious about this issue, let's re-open this. Either I or someone else
will look at this sometime soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/truffle-box/pet-shop-box/issues/46?email_source=notifications&email_token=AFMFRZ7GQDCI7GNE3BMDJG3P7QZE3A5CNFSM4HLWVD22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ5BGGY#issuecomment-511316763,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMFRZ7YOW3BKTQSTUMQ4VDP7QZE3ANCNFSM4HLWVD2Q
.

I am not able to reproduce your error. I even cloned your repo and ran it and it worked jus fine. Sorry, but I am going to close this issue again.


Use variables to render envoy telemetry template

Render envoy_telemetry.yaml.tmpl  by variables instead of static value population

@ChangyuWang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-new-install-k8s-tests_istio

integ-istioio-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-new-install-k8s-tests_istio

integ-istioio-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-istioio-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ChangyuWang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-new-install-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
bbe854a1fb36e700bbda2d076e251e726dc74fbe
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


refactor(state): add TemporaryState trait

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.39%. Comparing base (e64bf80) to head (827eeeb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1842   +/-   ##
=======================================
  Coverage   77.39%   77.39%
=======================================
  Files          60       60
  Lines        8556     8556
  Branches     8556     8556
=======================================
  Hits         6622     6622
  Misses       1494     1494
  Partials      440      440

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for parsing Link Header with variable whitespace

add support for variable whitespace in link header
PR Summary
Thanks to the @cruscio's analysis, it appears that the Link Header allows for any amount of whitespace or even no whitespace.  The currently explicitly expect a single whitespace after the semicolon in the Link Header before the Rel property.
Fix is to change the regex to allow for variable or no whitespace and associated tests to handle these two cases.  Changed GetLink helper to support passing in whitespace to use.
Fix https://github.com/PowerShell/PowerShell/issues/5667
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[x] Add [feature] if the change is significant or affects feature tests

@markekraus added documentation!


Update Device-Type Template

Environment

Python version: 3.6.8
NetBox version: 2.6.0

The Jinja template should be updated to reflect the recent change of Instance_count to device_count on the Device-Type. It currently still shows Instances.
Steps to Reproduce

Browse to netbox.example.com/dcim/device-types/ or netbox.example.com/dcim/device-types/. They both say Instances when referring to device_count.

Expected Behavior
It'll show Count or Device Count, preferably the former.
Observed Behavior
It shows Instances.

If I'm not mistaken, it needs to be updated in the following:
./netbox/templates/dcim/devicetype.html

Personally, it doesn't bother me one way or the other.  The instance_count property was renamed to device_count for consistency within the API (in my opinion).
However, I have a different preference:
I personally would actually prefer instance, instead of count.  I look at it like this, such that a device is a sub of device_type, and each device would be an instance of device_type.  Contrast that to things like sites,  racks where they are containers for devices and don't directly correspond to devices in a

Good point. I don’t mind either way. I just thought I’d mention it in case it was missed. If it wasn’t, feel free to close the issue.

On 24 Jun 2019, at 5:36 pm, Daniel Sheppard<EMAIL_ADDRESS>wrote:
Personally, it doesn't bother me one way or the other. The instance_count property was renamed to device_count for consistency within the API (in my opinion).
However, I have a different preference:
I personally would actually prefer instance, instead of count. I look at it like this, such that a device is a sub of device_type, and each device would be an instance of device_type. Contrast that to things like sites, racks where they are containers for devices and don't directly correspond to devices in a
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yeah I'm fine leaving this as-is.


t.throws giving false positive RegExp matches

Hey,
Thanks for writing tape!
I believe I found a bug in test.throws, that should have been failing much earlier. The problem is illustrated by the following example (which you can run in Chrome, e.g.):
> var re = /foo bar/;
undefined
> re.test(new Error('foo bar'));
true
> re = /^foo bar$/;
/^foo bar$/
> re.test(new Error('foo bar'));
false

Unfortunately, that's what t.throws is doing under the hood. This is causing tests like the following to fail
test('does not match regex', t => {
  let fn = () => {
    throw new Error('foobar bazqux')
  };

  t.throws(fn, /^foobar bazqux$/)
});

as well as this test.

See the closing comment here.


[Feature]: Replace Chakra UI elements with Tailwind CSS in Contact Us Page

Feature Request
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I have an issue when [...]
Currently, the Contact Us page is using Chakra UI elements for the layout. These would need to be removed and replaced with Tailwind classes preferably.
Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.
Remove the instances of Chakra UI and replace them with Tailwind classes in:

Contact Us Heading
Contact Us Form

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Preline does have some layout elements but I would prefer using Tailwind classes.
Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version in the docs.
Maybe a screenshot or design?
n/a

can i take on this issue?


feature grafana templating

@LostInBrittany let me know if something don't work or if it can be with a better way

Hey, I kinda like it!


Create CITATION.bib

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #39   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           1      1
=====================================
  Hits            1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2613f8...4eacb58. Read the comment docs.

Hi @asinghvi17 , thank you for the PR. Is there any part of the Julia ecosystem that is going to use this CITATION.bib file?

Eventually there will be a package which gives you a citation file based on your Project.toml, but now it's just a matter of convenience.

Do you have anything in mind that uses this CITATION.bib file currently? I would rather wait for the support in Project.toml directly, the BIBTeX entry is already in the README.md, wouldn't it be sufficient for now?

CITATION.bib will remain a separate file, but the tool will look at some arbitrary project's dependencies, find their CITATION.bibs, and then create a unified file.  That was the idea behind the standard, anyway...

Got it. That makes sense. I will push a small change to the file (regarding the entry name), and merge. Thanks again for the PR :ok_hand:

The entry name is supposed to be that way...from julialang.org/research:

In order to make Julia packages and projects easy to cite, the community has settled on a standard location and format for bibliographic information. Please add a CITATION.bib file (BibTeX format) in the top-level directory of your package or repo. The key for the bib entry should be <PackageName.jl>-- (Use a letter if you have multiple citations in same year). For example, see the CITATION.bib file in the Julia repo. We welcome additions to this list in the form of pull requests.

Saw it too late, fixing it back. Thanks for the pointer!


support to local reports

support a local reports

Hello. Thank you for your help with the project. I briefly reviewed the code and haven't seen the way to pass data source to the local report. How can I do that?

I have reviewed your changes and implemented local report support with custom data sources based on them. Thank you for your help!


Upgrade planner to Angular 6 and RxJS 6

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"
Mandatory

[ ] What does this PR do?
This Pr upgrades Planner to Angular 6 and Rxjs 6

[ ] What issue/task does this PR references?

[ ] Are the tests Included?

Optional

[ ] Is the documentation Included?

[ ] Are the Release Notes included?

[ ] @mention(s) to expected reviewer(s) included

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2794 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2794 and visit http://localhost:5000 to access it.

@Raunak1203 truncate works absolutely fine for me.

@Raunak1203 truncate works absolutely fine for me.

@sudsen please check in this space rbajpai-preview/test_space/plan/queryq=typegroup.name:Scenarios
for me it's not working. Please see above screenshot.

I agreed that it doesn't work on the query page. My point is, this is also not working in production. Thus this PR has nothing to do with that.

Thanks @sanbornsen @sahil143
These two issues can be recreated in production. And I have raised these 2 issues so that we can track it :
https://github.com/openshiftio/openshift.io/issues/4404
https://github.com/openshiftio/openshift.io/issues/4403


I created a program that can generate mapping Json files outside of the Editor.

Because the Editor is not running all the time, generating it through an external program can effectively reduce the time needed to open the project.

Hi @NekoShatoo,
thanks a lot for your contribution! I think supporting the generation of the mapping file outside of unity is a nice idea, however I would offer it as an additional possibility instead of the only possibility, since this requires to have .NET installed or we would need to offer downloads of the executables for Windows, Mac and Linux (I would not want to have the binary builds checked in).
I will do a code review later today, one question that popped into my head right away: How long does it take to generate the mapping file with the standalone program compared to the unity script I provided (In the script I simply log it with a StopWatch, which should be sufficient to compare them)?

By the way, this has been successfully tested on Unity 2022. It's possible that other Unity versions might have different database versions…


Release 2.40.7

We have 2 bugfixes,  one which is important for Windows users and another one on native histograms. I think it is worth cutting another bugfix release before 2.41 comes out.
@codesome is still out of a few days, therefore I am cutting the release.
Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

(triggering CI)


⚠ Bofrost.de has degraded performance

In 165140a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 3026 ms

Resolved: Bofrost.de performance has improved in 855ebeb after 6 minutes.


Multiple test files (suites) not working on Android with --cleanup

Describe the bug
When I pass --debug to detox, only the first file runs. Others fail with:
detox[20868] INFO:  [DetoxServer.js] server listening on localhost:6690...
detox[20868] ERROR: [EmulatorTelnet.js/TELNET_ERROR]
  err: Cannot connect
detox[20868] ERROR: Error: Cannot connect
 FAIL  e2e/documents.e2e.js
  ● Test suite failed to run

Interestingly, iOS is fine.
To Reproduce

[x] I have tested this issue on the latest Detox release and it still reproduces

Create two or more test files
Run npx detox test e2e -c android.emu.release --cleanup

Note that I included device.launchApp() in all files.

Expected behavior
All files should run.
Screenshots

Device and Verbose Detox Logs
detox[19480] DEBUG: [exec.js/EXEC_CMD, #25] "C:\Users\amq\AppData\Local\Android\Sdk\platform-tools\adb.EXE" -s emulator-14632 shell "ps | grep \"com\.app$\""
detox[19480] DEBUG: [DetoxServer.js/CANNOT_FORWARD] role=app not connected, cannot fw action (sessionId=a6a827d6-95b7-d079-7556-36f412f539d4)
detox[19480] DEBUG: [DetoxServer.js/LOGIN] role=app, sessionId=a6a827d6-95b7-d079-7556-36f412f539d4
detox[19480] DEBUG: [DetoxServer.js/LOGIN_SUCCESS] role=app, sessionId=a6a827d6-95b7-d079-7556-36f412f539d4
detox[19480] INFO:  login: login is working properly
detox[19480] INFO:  login: login is working properly [OK]

detox[19480] DEBUG: [exec.js/KILL] sending SIGINT to [pid = 25060]: C:\Users\amq\AppData\Local\Android\Sdk\platform-tools\adb.EXE -s emulator-14632 shell
am instrument -w -r -e detoxServer ws://localhost:13318 -e detoxSessionId a6a827d6-95b7-d079-7556-36f412f539d4 -e debug false com.app.test/androidx.test.runner.AndroidJUnitRunner
detox[19480] DEBUG: [DetoxServer.js/DISCONNECT] role=tester, sessionId=a6a827d6-95b7-d079-7556-36f412f539d4
detox[19480] DEBUG: [exec.js/KILL] sending SIGINT to [pid = 25060]: C:\Users\amq\AppData\Local\Android\Sdk\platform-tools\adb.EXE -s emulator-14632 shell
am instrument -w -r -e detoxServer ws://localhost:13318 -e detoxSessionId a6a827d6-95b7-d079-7556-36f412f539d4 -e debug false com.app.test/androidx.test.runner.AndroidJUnitRunner
detox[19480] DEBUG: [exec.js/EXEC_CMD, #26] "C:\Users\amq\AppData\Local\Android\Sdk\platform-tools\adb.EXE" -s emulator-14632 reverse --remove tcp:13318
detox[19480] DEBUG: [DetoxServer.js/DISCONNECT] role=app, sessionId=a6a827d6-95b7-d079-7556-36f412f539d4
detox[19480] DEBUG: [DetoxServer.js/CANNOT_FORWARD] role=tester not connected, cannot fw action (sessionId=a6a827d6-95b7-d079-7556-36f412f539d4)
detox[19480] DEBUG: [DetoxServer.js/WS_CLOSE] Detox server connections terminated gracefully
 PASS  e2e/login.e2e.js (112.205 s)
  login
    √ login is working properly (49525 ms)

detox[19480] INFO:  [DetoxServer.js] server listening on localhost:13439...
detox[19480] DEBUG: [AsyncWebSocket.js/WEBSOCKET_OPEN] opened web socket to: ws://localhost:13439
detox[19480] DEBUG: [DetoxServer.js/LOGIN] role=tester, sessionId=517f5b8a-2ab8-2399-6a44-11f108479881
detox[19480] DEBUG: [DetoxServer.js/LOGIN_SUCCESS] role=tester, sessionId=517f5b8a-2ab8-2399-6a44-11f108479881
detox[19480] DEBUG: [exec.js/EXEC_CMD, #27] "C:\Users\amq\AppData\Local\Android\Sdk\emulator\emulator.EXE" -list-avds --verbose
detox[19480] DEBUG: [exec.js/EXEC_CMD, #28] "C:\Users\amq\AppData\Local\Android\Sdk\emulator\emulator.EXE" -version
detox[19480] DEBUG: [EmulatorVersionResolver.js/EMU_BIN_VERSION_DETECT] Detected emulator binary version { major: 30, minor: 0, patch: 12, toString: [Function: toString] }
detox[19480] DEBUG: [EmulatorDeviceAllocator.js/ALLOCATE_DEVICE] Trying to allocate a device based on "pixel"
detox[19480] DEBUG: [exec.js/EXEC_CMD, #29] "C:\Users\amq\AppData\Local\Android\Sdk\platform-tools\adb.EXE"  devices
detox[19480] DEBUG: [exec.js/EXEC_SUCCESS, #29] List of devices attached
emulator-14632  device

detox[19480] ERROR: [EmulatorTelnet.js/TELNET_ERROR]
  err: Cannot connect
detox[19480] ERROR: Error: Cannot connect
 FAIL  e2e/documents.e2e.js
  ● Test suite failed to run

Environment (please complete the following information):

Detox: 18.0.3
React Native: 0.63.4
Node: 14.15.1
Device: pixel AVD with SDK 27
OS: Win10
Test-runner (select one): jest-circus

rm ~/.emulator_console_auth_token  #prevent test flakiness
That would work for you. There is already a ticket if you search with ERROR: [EmulatorTelnet.js/TELNET_ERROR]

rm ~/.emulator_console_auth_token  #prevent test flakiness
That would work for you. There is already a ticket if you search with ERROR: [EmulatorTelnet.js/TELNET_ERROR]

@amq Please rerun while applying the --loglevel trace argument (instead of verbose) to Detox. Currently, the log is quite obscure.

@amq Please rerun while applying the --loglevel trace argument (instead of verbose) to Detox. Currently, the log is quite obscure.

@Quandm1195 , did the suggestion of @amq work out well? If so, we might add a hint to our error in the future.

@noomorph Hello, not sure what suggestion you mean, but the issue should be resolved by my suggestion.

@Quandm1195, sorry. :)

@amq , did the suggestion of @Quandm1195 work out well? If so, we might add a hint to our error in the future.

After I swapped your nicknames, my question should now make sense.
Sorry I got confused between you two :) I wask


Move Flatcar repositories and website (back) to its own Github org

Revive the flatcar-linux github org as the go-to point for everything Flatcar Linux.
Items

[x] Move repositories from kinvolk org back to flatcar-linux
[x] Use Github pages for Flatcar website, Docs (http://flatcar-linux.org), adjust nameserver entries accordingly
[x] consider retiring stale repos (rkt, appc/spec, acbuild, moby, etc.) instead of moving
[x] Move or recreate release and roadmap boards

I think this issue is mainly done.

Use Github pages for Flatcar website, Docs (http://flatcar-linux.org/), adjust nameserver entries accordingly

Is it still something we want to do?

We could set it up in parallel and eventually migrate the domain when needed: https://gohugo.io/hosting-and-deployment/hosting-on-github/#branches-for-github-actions

@pothos @tormath1 Let's close and open a new for the domain migration?


[FR] Support Signin with Facebook Gaming Graph login (which is different from regular Facebook login)

[REQUIRED] Please fill in the following fields:

Unity editor version: 2019.4.11
Firebase Unity SDK version: 15.2
Source you installed the SDK: UPM (.unitypackage or Unity Package Manager)
Problematic Firebase Component: Auth (Auth, Database, etc.)
Other Firebase Components in use: RTDB (Auth, Database, etc.)
Additional SDKs you are using: Facebook (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Mac (Mac, Windows, or Linux)
Platform you are targeting: iOS (iOS, Android, and/or desktop)
Scripting Runtime: Mono (Editor), il2cpp (Device) (Mono, and/or IL2CPP)

[REQUIRED] Please describe the issue here:
We have updated one of our development apps to use the gaming graph. Login to facebook (using Facebook APIs) works correctly, and returns an access token of the form "GG|{tokenString}". Attempting to pass this token to SignInWithCredentialAsync() results in:
(Inner Exception #0) Firebase.FirebaseException: The supplied auth credential is malformed or has expired.
We can confirm that that token is for the gaming graph API (by logging the Facebook AccessToken's GraphDomain) , however, when we attempt to log in to Firebase using a credential generated from that token, SignInWithCredentialAsync() throws an exception , the inner of which is:
(Inner Exception #0) Firebase.FirebaseException: The supplied auth credential is malformed or has expired.
Interestingly, Credential.IsValid() returns true.
We are as certain we've got this test right as it's possible to be when most of the opportunities for error are mostly app configuration dashboards rather than the 10 lines of fairly well tested code itself.
Relevant code:
Debug.Log($"Getting credential from access token {AccessToken.CurrentAccessToken.TokenString}");
Firebase.Auth.Credential credential = Firebase.Auth.FacebookAuthProvider.GetCredential(AccessToken.CurrentAccessToken.TokenString);
Debug.Log($"Credential has provider {credential.Provider} : IsValid {credential.IsValid()}" + credential.ToString());
var authTask = auth.SignInWithCredentialAsync(credential);

Debug.Log("Android debugging with printf is fun.");

try
{
    var authUser = await authTask;
    Debug.Log($"Firebase auth sign in task completed. IsCompleted:{authTask.IsCompleted} IsCanceled:{authTask.IsCanceled}. UserID {authUser.UserId} Provider: {authUser.ProviderId}");
}
catch (System.Exception ex)
{
...

Steps to reproduce:

Produce a simple app with Firebase and Facebook SDKs.
Confirm that sign in with Facebook and Firebase Auth FacebookCredentialProvider works.
Switch facebook app in the Facebook developer dashboard to use Gaming Graph API
https://www.facebook.com/fbgaminghome/developers/gaming-services/
Confirm that Facebook will still sign in correctly but Firebase SignInWithCredentialAsync logs exception:

---> (Inner Exception #0) Firebase.FirebaseException: The supplied auth credential is malformed or has expired.<---
Repro 100%

I'm still having the exact same issue. Any updates?

Still no updates?

I ended this non-sense and ditched Firebase. It's a lot of work to implement another backend service but I just can't take this anymore. I'm back using Playfab. I don't even know why I decided to use Firebase in my current project tbh.

The same happens to me!

Anyone has tried this recently? Is it yet not possible to user Facebook Login for Gaming with Firebase?

It is still not working. I think this feature needs to be prioritized. Nowadays, Facebook login for gaming is an important aspect of the games.

https://github.com/firebase/flutterfire/issues/4524#issuecomment-764610739
This worked for me by recreating Facebook Application with type of Consumer.
I have noticed that Facebook Application built for gaming doesn't have public_profile available in their permissions and have gaming_profile instead.
I haven't tried it out, but for those of you that doesn't want to recreate Facebook Application, maybe replacing public_profile permission requirements to gaming_profile may avoid this error.

@Sitiyoh does this work? Consumer profile doesnt work with the invitable_friends endpoint and connecting players with thier friends is 100% of the reason we're involving facebook. Are you implying that I may be able to change the user permission to gaming_profile  instead of public_profile and that will circumvent the issue?

Hi everyone, I'm an engineer from Facebook Login for Gaming. We have landed a fix on our end last week and verified Facebook Login for Gaming now can integrate with our Firebase test App. Could you please help us confirm if the issue has also been resolved for your Apps?
Thank you very much for your patience and help!

Hi everyone, I'm an engineer from Facebook Login for Gaming. We have landed a fix on our end last week and verified Facebook Login for Gaming now can integrate with our Firebase test App. Could you please help us confirm if the issue has also been resolved for your Apps?
Thank you very much for your patience and help!

"A fix is expected in coming weeks" - from Facebook dev a year ago. And a year later you fix this issue?
This is such disrespect to developers using Facebook. And to answer your question: because of this issue we never created an app as a gaming app ever again. Once we do, we'll let you know.

Hi everyone, I'm an engineer from Facebook Login for Gaming. We have landed a fix on our end last week and verified Facebook Login for Gaming now can integrate with our Firebase test App. Could you please help us confirm if the issue has also been resolved for your Apps?
Thank you very much for your patience and help!

Yes, thanks I can confirm is working now.

Closing as closed.


go_1_{9,10}: disable problematic tests in net module

Motivation for this change
On a NixOS laptop TestWritevError sometimes hangs (#37704) and TestVariousDeadlines fails with
--- FAIL: TestVariousDeadlines (5.00s)
        timeout_test.go:878: 1ns run 1/1
        timeout_test.go:903: for 1ns run 1/1, good client timeout after 19.113µs, reading 0 bytes
        timeout_test.go:913: for 1ns run 1/1, server in 794.51µs wrote 393216: readfrom tcp4 <IP_ADDRESS>:43227-><IP_ADDRESS>:44660: write tcp4 <IP_ADDRESS>:43227-><IP_ADDRESS>:44660: write: connection reset by peer
        timeout_test.go:878: 2ns run 1/1
        timeout_test.go:903: for 2ns run 1/1, good client timeout after 4.91µs, reading 0 bytes
        timeout_test.go:917: for 2ns run 1/1, timeout waiting for server to finish writing
FAIL
FAIL    net     6.498s

So they are added to the list of problematic tests which do not run.
Fixes #37704

Success on x86_64-linux (full log)
Attempted: go
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/bc5v2zr96c83s6yh8n7p4gaz9lfkgnvn-go-1.10.1

@GrahamcOfBorg build go_1_9

Success on x86_64-linux (full log)
Attempted: go_1_9
Partial log (click to expand)
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/kh0vmcchpsaivd66x18yx0smfig682zh-go-1.9.5

Success on aarch64-linux (full log)
Attempted: go
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/1dspk6493c0lj37i5crkb0pcm4qinzkz-go-1.10.1

Success on aarch64-linux (full log)
Attempted: go_1_9
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/n85am1iywksll5wyrp8aqlxvpcq37f7x-go-1.9.5


hotkeys: Add hotkey to narrow to current compose target.

It would be great to have a hotkey that worked while you were in compose (so would probably need to include a Ctrl or Alt) that

Narrows to the appropriate PM if composing a PM
Narrows to the topic if there is a topic and that topic has at least 1 previous message
Narrows to the stream otherwise

@rishig since I have worked with the hotkeys, I would like to take this up. Can you elaborate it a bit more that which hotkey do you want to include for which function?

Awesome!
Just realized this is a duplicate issue with #6546 -- maybe let's move this there?


blaze is not compiled with the latest rust nightly version

Describe the bug
rust compiler reports the same error with this issue due to the dependency: arrow-45 -> packed_simd_2-0.3.8
we should upgrade datafusion dependency to v46 and arrow-rs to v32. alternatively, we may replace nightly with stable rust for better production usage.

Hey, I wonder why not using the official datafusion crate? Do you have some different patch?

@zuston yes, we have some specialized code in branch (v30-blaze)[https://github.com/blaze-init/arrow-datafusion/tree/v30-blaze]

@zuston yes, we have some specialized code in branch v30-blaze

Got it. Thanks

now we fixed nightly version to 2023-08-01, which is verified in production environment.

now we fixed nightly version to 2023-08-01, which is verified in production environment.

Should we update the rust version in rust toolchain toml ?


Add bottom to top example

I understand that I need to create my own stages table to configure where and how my notifications look.
However all examples use the available_row() utility function which I believe only puts notifications top to bottom.

I've made the available_slot function  as a more generic solution so you can supply a direction to start notifications from. Just change the direction to the one you want, so in this case change to BOTTOM_UP

Works great!
Thanks.


Added support for Azure China and Azure US Gov

Added support for Azure China and Azure US Gov.

This will close https://github.com/Azure/aml-workspace/issues/18#issuecomment-650318246

Confirmed success:
uses: Azure/aml-compute@target_cloud

@action-devops thanks for testing!


Added SOLID entry

@jchartrand The file looks correct in my fork.  How has the formatting changed?

@gordoncavanaugh
You can see the difference between your commit and the prior commit here:
https://github.com/digitalcredentials/sandbox-registry/pull/4/commits/f878215960f3da9f8f187db22760cf817f0b887d
Ideally we want the green + bits to only show your new addition. As it is, it shows the removal (the red - bits) of most of the file, and then the addition of what is probably the same stuff, but it isn't easy to tell that. We want it so that later if someone is looking through the commits, it only takes a quick glance to see what was changed.
I can see that your commit has at least removed some spaces.  So nothing that would change the semantics of the json, but it does mess up the diff a bit.

@jchartrand I'm guessing my editor changed the line endings.  I'll see if I can figure out a way to correct this.

@jchartrand I updated the registry.json file in my original fork by copying and pasting the registry.jon file from the main branch, and adding our entry.  I committed the changes, but I cannot seem to create another pull request.  Github doesn't show any changes between my fork and main.
I was not able to create another fork.  Do I have to delete the existing one first?  Thanks.

@gordoncavanaugh
When you create a PR, you create it for a branch, which in this case is your 'main' branch.  And if you make commits to that branch after submitting it as a PR, the new commits also become part of the PR, which is what has happened in this case:  your second commit has become part of the PR.
But, the second commit still seems to have reformatted the json.
Yes, you are correct: a GitHub account can only have one forked copy of a project. So, yes, you'd have to delete your fork, and fork it again if you want to start from scratch. Which is easily done, though, and would then let you edit the existing registry.json file directly from the GitHub web page, which hopefully wouldn't change the formatting.
Alternatively, if you'd rather not fiddle with it anymore, I can commit your new did myself.


Revert Ben's changes

@benborgers I think your changes broke most of the docs functionality. I reverted both of them. Can you try to fix them and then re-implement the functionality that I reverted?
Also, please create a test plan that we can run thru before merging.

@vpontis On it!


nextSerializable fails on classe with constructor that requires argements

https://github.com/massalabs/as/blob/1ed2d3046e87616acaaf4d4b4291957240a2441a/packages/as-types/assembly/argument.ts#L566
When using nextSerializable<T>() if T has a constructor with required parameters, compilation fails with a confusing error.
This problem comes from instantiate being called without arguments and calling the constructor of T with the arguments provided.
From there, either this is voluntary that we instantiate a dummy object (since the value will be overridden anyway) and then it should be made clear that a class that implements Serializable needs a constructor with no parameters.
Or we can modify the signature of nextSerializable as nextSerializable<T> (...args: any[]) and give those args to instantiate<T>

its indeed a pain. as a workaround you can set default values in your constructor:
  constructor(     public tata: string = '',     public titi: string = '',     public toto: number = 0,   ) {}

yup, that's what we did.
It is a bit annoying because then we can't type checker that we do provide parameters to the new Class (), so I added a static method create for this and add the coding rules that we need to use this


Add SNS message filters

Description
AWS recently introduced SNS message filtering using message attributes. This is very useful if you use single topic for multiple consumers (SQS, Lambda, etc) and you don't want every message to trigger function or just don't want to filter messages inside Zappa.
By simply setting the following in your config:
        "events": [
            {
                "function": "your_module.your_function",
                "event_source": {
                    "arn":  "arn:aws:sns:::your-event-topic-arn",
                    "filters": {
                        "interests": ["python", "aws", "zappa"],
                        "version": ["1.0"]
                    },
                    "events": [
                        "sns:Publish"
                    ]
                }
            }
        ]

a Zappa function will be executed for SNS messages with attributes where at least one value matches interests list.
Note that each filter must be list of strings.
For detailed documentation how it works: http://docs.aws.amazon.com/sns/latest/dg/message-filtering.html

Coverage decreased (-0.1%) to 73.899% when pulling 766298c0c802dca56f086bd720fc3c509077541d on tripliks:subscription-filters into 7359acec488976e3ce143a766c092bff252dd25f on Miserlou:master.

Coverage decreased (-0.1%) to 73.899% when pulling 65c5e8570c14d2403b840360380e0d42c1bfa05e on tripliks:subscription-filters into 7359acec488976e3ce143a766c092bff252dd25f on Miserlou:master.


Dealing with error retrieving tags/version on GitHub Pages Configuration documentation

Currently on the configuration documentation hosted on GitHub Pages (https://rust-lang.github.io/rustfmt/) if there's any error retrieving the tags from the GH API then the page will silently fail to populate the version dropdown. Version specific docs can still be retrieved by using the url query param to set the version, but the dropdown/selector behavior is not ideal.
One use case where I can imagine this popping up (which I ran into myself) is when you've hit GH's rate limits
I'm not sure this is an entirely avoidable scenario as long as the dropdown's being populated dynamically, but some kind of error message/banner would be a helpful addition.

Rejection of these two promises needs to be handled:
https://github.com/rust-lang/rustfmt/blob/e438529f736cd6d10e91eabafbc9db232c37e053/docs/index.html#L174
https://github.com/rust-lang/rustfmt/blob/e438529f736cd6d10e91eabafbc9db232c37e053/docs/index.html#L119
(the second one already is, but the error message is not helpful)
A backoff could be added as well: https://github.com/aishek/axios-rate-limit
60 unauth'd requests per hour seems rather ridiculous for GitHub...