Pagination does not make request to server for more pages

Currently the tables only pull the first 10 submissions / grants and pagination does not pull the next 10.
Implimenting models-table-server-paginated should fix this
http://onechiporenko.github.io/ember-models-table/v.2/docs/classes/Components.ModelsTableServerPaginated.html

There is currently a naive search implementation in the UI which does not do paging. However, I didn't realize that the default behavior of Store.query was to return only 10 objects. This probably explains this ticket. At a later date we will have to get paging to work.

Note for later impl:
see jabrah/dev/server-paged-tables
https://ember-twiddle.com/3177ccf0b6c8a4656c9724cd8aa4f83a?fileTreeShown=false&numColumns=2&openFiles=templates.index.hbs%2Ccomponents.my-table.js

Starting to add manual paging to the various data tables: https://github.com/jabrah/pass-ember/tree/refactor/server-side-paging
This branch removes controls from the ember-models-table's in appropriate routes and uses custom controls tied to controller actions to be able to hit Elasticsearch when needed

Note: Server side paging is currently stalled because of filtering and sorting
There is information displayed in all tables that require paging that does not come from the primary table object. For example, the Submissions table displays a row for each submission, but data comes from the submissions Publication object, associated grant objects, etc. Paging is implemented in the UI by issuing new search requests for each page. Filtering and sorting require queries on properties that are not present on the desired return object.
In the submissions table, when you filter for a word in publication title, you really want to return the submission objects that have a publication object that has the matching word. In the current ES, if you blindly do a query for the title property with the desired word, it will return the matching publication object, but there is currently no way on the server side to then return the submission it belongs to. This same issue is relevant to filtering and sorting.
Possible work around?
Would it be possible/feasible to add properties from related objects onto related objects in the index? For example when indexing a Submission, pull in its related Publication and add a publication_filter property that can be searched for the purpose of filtering and sorting. The property name would have to be distinct so that it can be explicitly ignored in the returned submission object (see how autocomplete _suggest fields are ignored).

Yes. You would have to copy properties from child objects to parent objects. This requires custom PASS indexer support. We would have to figure out a reasonable scheme. But this would require a lot of idiosyncratic work on the index. First we should be careful to only keep filtering and sort functionality that is required.


missing needed parameter

File: config/daemon/ipv6.md
as it stands, if you only do what it says here it will crash your demon on reboot.
it is missing the
"fixed-cidr-v6": "2001:db8:1::/64"
or something there abouts.. This but if info is all over the internet but you guys don't have it here.

Thanks for sharing the issue. It appears fixed in https://github.com/docker/docker.github.io/commit/1b319c30a57334d82096bc4e1cabfab3a8b6dda1


Extracted method to configure HttpMessageHandlerBuilder

Extracts method for applying HttpClientFactoryOptions into the HttpMessageHandlerBuilder.

Enhances encapsulation and readability.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: afaganga sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Incorrect dashboard in certain conditions

First of all, thanks for the plugin, it's working great ❤!
I noticed when going to the dashboard using the button (see image) the page will not show the old dashboard. Not sure if this is detectable in any way, but thought I'd let you know 🙂

I also noticed that when visiting https://github.com/dashboard the new dashboard is still showing.
Which is where you get redirected after clicking this link:

URLs like https://github.com// also load the new dashboard but that's a non-issue.
Thanks again, I'll definitely will keep using this!

Hey, thanks! 😄
Managed to come up with fixes for all of the issues you mentioned - the challenge was ensuring they all work whilst still making sure the feed only loads in the background for the homepage, but I think I have something fairly robust!
I'll push up the updates now (if you're on Chrome you'll be able to download and replace the old version, for Firefox I think you'll have to wait for it to be approved again).

Okay, new version submitted to Firefox,, for Chrome you'll be able to pull/download the latest changes and install it as before. (Safari users - I'm working on a new release now - check the releases tab for v1.0.1.)


docker compose icon is missing

docker-compose.yaml icon is missing. a default icon is shown

Hi,
github-vscode-icons is based on vscode-icons extension for vscode and it seems they don't support file extension .yaml, only .yml.
Maybe you can try create issue for vscode-icons or rename your docker-compose.yaml to docker-compose.yml


[BEAM-8133] Update influx db publisher

runtimeMs and numResults are now published as integer not float type
Additional logic for error logging added

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

H

R: @kamilwu
Please, take a look. Thanks!

Run Direct Runner Nexmark Tests

Retest this please

Run Java PreCommit

Run Direct Runner Nexmark Tests

Run Seed Job

Run Direct Runner Nexmark Tests

LGTM, thanks


Lower precision RoPE computation leads to training instability

Hi everyone,
When running a Llama3.1 training job with FSDP and BF16 mixed precision, we noticed a large gap in train/val loss between FP8 autocast enabled vs. disabled which we do not see with Llama2.
For context, the main difference between Llama3.1 and Llama2 is that the rotary embedding initialization is different (main relevant portion is that the RoPE rotary base value is changed from 10k to 500k).
After some investigation we found that this was because although the RoPE inverse frequencies are created in FP32 (and cast to FP32 during fused rope application), the query/key layers are in BF16 (due to mixed precision in our case), they are passed to tex.fused_rope_forward(t, freqs) as is (which I assume is intentional).
However, this appears to have different behavior than passing both t and freqs explicitly as FP32, which I assume is some loss of precision with the fused rope kernel.
We can verify this with the following test script:
# TE main (after 1.11 at time of writing)
# needed for the tunable `rotary_base` change in `RotaryPositionEmbedding`
from transformer_engine.pytorch.attention import (
    apply_rotary_pos_emb,
    RotaryPositionEmbedding,
)
import torch

S = 2  # seqlen
B = 1  # bs
H = 1  # num attn heads per partition
D = 8  # hidden size per attn head

device = torch.device("cuda:0")
rope = RotaryPositionEmbedding(dim=D, rotary_base=10000)

# FP32 rope frequencies
rotary_emb = rope(max_seq_len=S)

# BF16 input tensor
t1 = torch.rand((S, B, H, D), dtype=torch.bfloat16, device=device)
# FP32 input tensor
t2 = t1.detach().clone().to(torch.float32)

t1_out = apply_rotary_pos_emb(t=t1, freqs=rotary_emb, fused=True).to(torch.float32)
t2_out = apply_rotary_pos_emb(t=t2, freqs=rotary_emb, fused=True)

# Assertion fails here
assert torch.allclose(t1_out, t2_out)

This precision loss appears to be fine for the smaller rotary_base=10k for Llama2, but is exaggerated when rotary_base=500k and even further exaggerated when FP8 is enabled.
Llama with rotary_base=500k.

blue=FP8 autocast off
orange=FP8 autocast on

Llama with rotary_base=500k with the query/key layers upcast to FP32 before FusedRoPEFunc.apply().

pink=FP8 autocast off
green=FP8 autocast on

What I think is happening, is that even though the RoPE computation itself is not being done in FP8, the precision loss is being amplified and accumulating across layers/iterations when FP8 is enabled.
Thus, I think there should be an explicit upcast to FP32 for the query/key layers and so the logic in MultiheadAttention.forward() should look something like this:
orig_q_dtype = query_layer.dtype
orig_k_dtype = key_layer.dtype

# Upcast qk to FP32.
query_layer = query_layer.to(torch.float32)
key_layer = key_layer.to(torch.float32)

query_layer = apply_rotary_pos_emb(query_layer, q_pos_emb, self.qkv_format, fused=True)
key_layer = apply_rotary_pos_emb(key_layer, k_pos_emb, self.qkv_format, fused=True)

# Cast qk back to orig dtype.
query_layer = query_layer.to(orig_q_dtype)
key_layer = key_layer.to(orig_k_dtype)

It could also be an upcast_to_fp32 flag in apply_rotary_pos_emb, either way looks good to me.
This should probably be applied to all cases, but if not all, at least when FP8 is enabled to mitigate its impact.
Although slightly different, HuggingFace appeared to also see similar precision issues with RoPE, though this is just showing how impactful RoPE precision is.
Note 1: I did not investigate the unfused rope case as it is not used in MultiheadAttention.
Note 2: The Llama runs were run with TE=v1.10, with a patched RotaryPositionEmbedding to allow the tuning of rotary_base.
What do you guys think?
Thanks!

Hi @viclzhu, thanks for your report.
In your test script, change t1_out and t2_out to
t1_out = apply_rotary_pos_emb(t=t1, freqs=rotary_emb, fused=True)
t2_out = apply_rotary_pos_emb(t=t2, freqs=rotary_emb, fused=True).to(torch.bfloat16)

and the assertion successes.
In fact, the fused RoPE kernel just works as your suggestion.
It will first cast the input tensor to FP32, then do the calculation in FP32, and store the results back to the original dtype.
https://github.com/NVIDIA/TransformerEngine/blob/55dcbb4b02f560d52dc1215a9de348b37487ee3d/transformer_engine/common/fused_rope/fused_rope.cu#L31-L34
So I'm surprised that there will be such a big difference in your loss curves.
@ksivaman Can you comment as I remembered you changed the computation of RoPE to FP32 in https://github.com/NVIDIA/TransformerEngine/pull/645?

Thanks @yaox12!
Hm, you're right, it should be testing the outputs cast to BF16, and since the outputs are close enough, there shouldn't be any impact from this.
Not sure why we're seeing this behavior then, maybe there's something else going on in our setup.


Challenge Add Borders Around your Elements has an issue.

Challenge [Add Borders Around your Elements](http://www.freecodecamp.com/challenges/add-borders-around-your-elements#?solution=<link href%3D"http%3A%2F%2Ffonts.googleapis.com%2Fcss%3Ffamily%3DLobster" rel%3D"stylesheet" type%3D"text%2Fcss">
<style>
  .red-text {
    color%3A red%3B
  }

  h2 {
    font-family%3A Lobster%2C Monospace%3B
  }

  p {
    font-size%3A 16px%3B
    font-family%3A Monospace%3B
  }

  .smaller-image {
    width%3A 100px%3B
  }
  .thick-green-

border%7B%0A%20%20%20%20width%3A10px%3B%0A%20%20%20%20color%3Agreen%3B%0A%20%20%20%20border%3Asolid%3B%0A%20%20%7D%0A%3C%2Fstyle%3E%0A%0A%3Ch2%20class%3D%22red-text%22%3ECatPhotoApp%3C%2Fh2%3E%0A%0A%3Cimg%20class%3D%22smaller-image%20thick-green-border%22%20src%3D%22https%3A%2F%2Fbit.ly%2Ffcc-relaxing-cat%22%3E%0A%0A%3Cp%20class%3D%22red-text%22%3EKitty%20ipsum%20dolor%20sit%20amet%2C%20shed%20everywhere%20shed%20everywhere%20stretching%20attack%20your%20ankles%20chase%20the%20red%20dot%2C%20hairball%20run%20catnip%20eat%20the%20grass%20sniff.%3C%2Fp%3E%0A%3Cp%20class%3D%22red-text%22%3EPurr%20jump%20eat%20the%20grass%20rip%20the%20couch%20scratched%20sunbathe%2C%20shed%20everywhere%20rip%20the%20couch%20sleep%20in%20the%20sink%20fluffy%20fur%20catnip%20scratched.%3C%2Fp%3E%0A) has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

@UWarbs is correct.
Issues are not for code problems.  Please ask for help in Help Chat.
Thanks and Happy Coding!


Write prep_riboviz.py configuration for simulated fastq records

simulatefastq-36 has riboviz/tools/create_fastq_examples.py which produces test data building up to Duncan & Mata-style:

data/simdata_UMI3_4nt.fastq - 4nt UMI at 3' end
data/simdata_UMI5and3_4nt_adaptor.fastq - 4nt UMI at 3' end and another at 5' end
data/simdata_UMI5and3_4nt.fastq- 4nt UMI at 3' end and another at 5' end, and adaptor

These .fastqs were designed so they could be run with vignette index files yeast_CDS_w_250utrs.fa/.gff3, and the adaptor from the vignette, because the "reads" align to sequences in the .fa
They will need to be gzipped and the yaml edited as appropriate.
Originally posted by @ewallace in https://github.com/riboviz/RiboViz/issues/58#issuecomment-527676381

I created a new YAML configuration, vignette/vignette_simdata_config.yaml, for the test data. The differences to the default configuration are as follows:
$ diff vignette/vignette_config.yaml  vignette/vignette_simdata_config.yaml
1c1
< dir_in: vignette/input # input directory
---
> dir_in: data/ # input directory
16,18c16
<   WTnone: SRR1042855_s1mi.fastq.gz
<   WT3AT: SRR1042864_s1mi.fastq.gz
<   NotHere: example_missing_file.fastq.gz # prepRiboviz should give error message for missing files
---
>   simdata: simdata_UMI5and3_4nt_adaptor.fastq

Running fails at generate_stats_figs.R:
$ python -m riboviz.tools.prep_riboviz rscripts/ vignette/vignette_simdata_config.yaml
...
Create summary statistics and analyses plots. Log: vignette/logs/20190930-063308/simdata_10_generate_stats_figs.log
Problem processing sample: simdata
...
AssertionError: ['Rscript', '--vanilla', 'rscripts/generate_stats_figs.R', '--Ncores=1',
  --MinReadLen=10', '--MaxReadLen=50', '--Buffer=250', '--PrimaryID=Name',
  '--dataset=vignette', '--hdFile=vignette/output/simdata.h5',
  '--out_prefix=vignette/output/simdata', '--orf_fasta=vignette/input/yeast_YAL_CDS_w_250utrs.fa',
  '--rpf=True', '--orf_gff_file=vignette/input/yeast_YAL_CDS_w_250utrs.gff3',
  '--dir_out=vignette/output', '--t_rna=data/yeast_tRNAs.tsv',
  '--codon_pos=data/yeast_codon_pos_i200.RData', '--features_file=data/yeast_features.tsv',
  '--do_pos_sp_nt_freq=True'] failed with exit code 1
Finished processing 1 samples, 1 failed

The invocation (from run_riboviz_vignette.sh) is:
Rscript --vanilla rscripts/generate_stats_figs.R --Ncores=1 --MinReadLen=10 \
  --MaxReadLen=50 --Buffer=250 --PrimaryID=Name --dataset=vignette \
  --hdFile=vignette/output/simdata.h5 --out_prefix=vignette/output/simdata \
  --orf_fasta=vignette/input/yeast_YAL_CDS_w_250utrs.fa --rpf=True \
  --orf_gff_file=vignette/input/yeast_YAL_CDS_w_250utrs.gff3 --dir_out=vignette/output \
  --t_rna=data/yeast_tRNAs.tsv --codon_pos=data/yeast_codon_pos_i200.RData \
  --features_file=data/yeast_features.tsv --do_pos_sp_nt_freq=True

The log shows:
$ cat vignette/logs/20190930-063308/simdata_10_generate_stats_figs.log
...
[1] "Starting: Check for 3nt periodicity"
Saving 7 x 7 in image
[1] "Completed: Check for 3nt periodicity"
[1] "Starting: Distribution of lengths of all mapped reads"
Saving 7 x 7 in image
[1] "Completed: Distribution of lengths of all mapped reads"
[1] "Starting: Biases in nucleotide composition along mapped read lengths"
[1] "Completed nucleotide composition bias table"
[1] "Starting: Position specific distribution of reads"
Saving 7 x 7 in image
Warning message:
Removed 1000 rows containing missing values (geom_path).
[1] "Completed: Position specific distribution of reads"
[1] "Starting: Calculate TPMs of genes"
[1] "Starting: Correlations between TPMs of genes with their sequence-based features"
Saving 7 x 7 in image
Error: Faceting variables must have at least one value
Execution halted

The following files had been created:
$ ls -1 vignette/tmp/
simdata_nonrRNA.fq
simdata_orf_map_clean.sam
simdata_orf_map.sam
simdata_rRNA_map.sam
simdata_trim.fq
simdata_unaligned.fq
$ ls -1 vignette/output/
simdata_3nt_periodicity.pdf
simdata_3nt_periodicity.tsv
simdata.bam
simdata.bam.bai
simdata_features.pdf
simdata.h5
simdata_minus.bedgraph
simdata_plus.bedgraph
simdata_pos_sp_nt_freq.tsv
simdata_pos_sp_rpf_norm_reads.pdf
simdata_pos_sp_rpf_norm_reads.tsv
simdata_read_lengths.pdf
simdata_read_lengths.tsv
simdata_tpms.tsv

For the PDFs:

simdata_read_lengths.pdf: bar at Length = 38 of height 1.
simdata_3nt_periodicity.pdf: 5' graph has spike at 0, read counts 1; 3' graph has read counts 0
simdata_pos_sp_rpf_norm_reads.pdf: graphs are empty
simdata_features.pdf: PDF is blank

@ewallace any suggestions?

Lengths of simdata reads should be 28nt and 30nt, if UMIs were removed. The extra 4nt of UMIs is likely to prevent alignment, which would explain why only a single read aligned. So we should have another file, data/simdata_noUMI.fastq, that runs for the existing vignette without deduplication. Then the other data files will work properly only when we have extracted the UMIs before alignment.
The error in generate_stats_figs.R occurs during features_plot. Faceting error means that ggplot2's facet_wrap is trying to plot a subgraph for every value of a variable, but it doesn't find any values. This is likely to come from the filtering step:
plot_data <- merge(features,tpms,by="ORF") %>%
    filter(readcount >= count_threshold, !is.na(ORF))

Which removes all genes with readcount below count_threshold, which has a default value of 64. Should be fixed by setting count_threshold <- 1 in the config yaml.

Commited changes to develop branch - 0983b49 - to allow count_threshold argument to generate_stats_figs.R to be specified via configuration parameter.
Commited changes to simulatefastq-36 branch - 6f9296d - extending create_fastq_examples.py to create fastq files post-UMI extraction. There are two new files created: simdata_extracted_UMI5and3_4nt.fastq and simdata_extracted_UMI3_4nt.fastq - these share the same reads but they differ in their quality scores as the data they are derived from - data that is saved in simdata_UMI5and3_4nt.fastq and simdata_UMI3_4nt.fastq - differ in their quality scores due to the way create_fastq_examples.py creates these. The commit also has a new vignette/vignette_simdata_config.yaml file.
$ diff vignette/vignette_config.yaml  vignette/vignette_simdata_config.yaml
1c1
< dir_in: vignette/input # input directory
---
> dir_in: data/ # input directory
16,18c16,17
<   WTnone: SRR1042855_s1mi.fastq.gz
<   WT3AT: SRR1042864_s1mi.fastq.gz
<   NotHere: example_missing_file.fastq.gz # prepRiboviz should give error message for missing files
---
>   simdata5and3: simdata_extracted_UMI5and3_4nt.fastq
>   simdata3: simdata_extracted_UMI3_4nt.fastq
35c34
< count_threshold: 64 # Remove genes with a read count below this threshold, when generating statistics and figures
---
> count_threshold: 1 # Remove genes with a read count below this threshold, when generating statistics and figures

Run:
rm -rf vignette/index vignette/tmp vignette/output/ vignette/logs/ riboviz.*.log run_riboviz_vignette.sh
python -m riboviz.tools.prep_riboviz rscripts/ vignette/vignette_simdata_config.yaml

Lengths of simdata reads should be 28nt and 30nt, if UMIs were removed.

simdata5and3_read_lengths.pdf has Lengths=28, Counts=5 and Lengths=30, Counts=4: OK
simdata3_read_lengths.pdf has Lengths=28, Counts=4 and Lengths=30, Counts=4:  OK


Cut release v0.19.0

What's Changed

Zoom to fit by Serena and Jess
Human speed completions by Jess
Dark edge lines in light mode by Frank and Mike
3D axes gizmo fix by Kurt
Rust refactor of filesystem operations by Jess
Fixes for recast, const completion, u32 math, and 2d linear patterns by Jess
Bump dependencies (tauri and internal)

Known Issues

File Explorer shows directories as files (#2237)

Full Changelog: https://github.com/KittyCAD/modeling-app/compare/v0.18.1...v0.19.0

Can't get it all green at this point due to microsoft ubuntu repo errors https://github.com/KittyCAD/modeling-app/actions/runs/8814640085/job/24196789793#step:6:35
Will try again later

Windows 10 build tests:

sign in
open existing project
create new project

sketch on base plane
rectangle
extrude
sketch on top face
rectangle
extrude
export to STL ascii
change project settings

sign out
sign back in

Same issue on Windows:

Created https://github.com/KittyCAD/modeling-app/issues/2237


failedRules not behaving as expected

I try to implement the onChange functionality in order to make a distinction between the password that is validated against the password rules and the matching of the password.
The onChange is only triggered if isValid changes. And this only happens if all of the requirements are met, or none of the requirements are met if you start filling in a password.
I would expect, that onChange is triggered if the password is changing from valid to invalid AND if one of the rules changes from being non-compliant with the rule to being compliant with the rule, or from compliant to non compliant.
As it is now, the failedRules are sort of useless, while it could be great functionality in telling the user in depth where something is going wrong

Actually I found some time this morning to crank this out - fix coming up shortly...

wow! you are fast!! good job

Fixed and published in v1.5.1 - thanks for the report!


File upload broken on latest version of MVC

Functional impact
The ability to upload a file isn't possible.
Minimal repro steps

Create a page with a simple form to upload one or more files.
Create an action that receives the uploaded files and saves them to the wwwroot.
Ensure you're on the latest MVC version (rc1-16028 at time of writing).
Upload a file using the created form.

Expected result
An except copy of the file in the wwwroot folder of the file(s) you selected.
Actual result
There are no files in the folder if you have choosen to upload a single file.
If you choose to upload multiple are some files in the folder but they are corrupt. (There is one file as example in the sample project)
Further technical details
Sample project I created for this bug

I'm trying to repro this on newest bits. It's very likely that this was a manifestation of https://github.com/aspnet/KestrelHttpServer/issues/270 - which lead to all sorts of request corruption.
aspnet/KestrelHttpServer#270 was fixed as of build 15890.
I'll update here with results.

I can confirm that this is working for me on the latest build of kestel.
When this fails for you do you still see "Done" (the response) or do you get a white screen and a 500? I'd suggest adding the developer exception page https://github.com/aspnet/Diagnostics/blob/dev/samples/DeveloperExceptionPageSample/Startup.cs#L10 if you still hit this issue. There's no default 'yellow screen of death' if your app throws, you just get a 500 now.


How to get  and display single data from a string in a array

Hi I just went through your code and I am trying something  in the useractivitycomponent.ts there is this code  public logdata: Array<Stuff> = [];
now I am trying to get the type or date at postition 0 in the component file I i tried  doing different things but cant get it to work I am learning Typescript
public myHero = this.logdata[0];
public stuff: Stuff = new Stuff();
public mmm: string = this.stuff.date;
public myfirstdate: string = this.stuff[0].date;
I hope you understand what i am trying to do I am trying to get the first object in the array  "date"

Hi @chris86 ,
This is more of a JS question rather than a Cognito question, so you might want to use stackoverflow for that.
Vladimir


Query symbol index for document symbols if analysis on document is not complete

For #433.

This is obsolete; the indexer will always be queried for info regardless of the status of the analysis. I'll open an issue for allowing the analysis to augment the indexed data (better detection of imports, for example).


Fix static log targets not being purged when a custom log storage location is specified

From the source it looks like this'll do what it intends to but I couldn't get this tested with the game-side PR today. Maybe tomorrow if this is still here unmerged.


procps: enable systemd support when available

Motivation for this change
ps can show various systemd-related information, like a unit to which a process belongs. But when it's not compiled in, it shows only ? in such fields.
Can be tested with:
ps -o unit= ax

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Something strange happens with this change, it can be seen in GrahamcOfBorg error message above. And it actually breaks nixos VM tests, with the same message.
I've tried to look into this a bit, and it looks like things like fetchzip and fetchpatch are getting fetchurlBoot instead of full-fledged fetchurl (where support for all the fancy options really is).

I don't know how to investigate that fetchurl/bootstrap issue. So for now I've made this option available only by explicit request, so that https://github.com/NixOS/nixpkgs/pull/34265 can move forward.

I pushed a few changes. I could not reproduce the ofborg failure. It could have been something that was closed.

I've dug deeper into this issue, as VM tests were still failing. Short story is that during tests procps/systemd is evaluated with stdenv bootstrap-stage4-stdenv-linux that is not functional enough to build systemd.

Everything starts here https://github.com/NixOS/nixpkgs/blob/43650115e34ea610e53f718d9e02de7222ac0ba2/nixos/modules/misc/documentation.nix#L81-L82
This pulls in texinfo with interactive flag set
Looking at texinfo history, I can see that procps dependency (conditionalized on doCheck) was introduced by https://github.com/NixOS/nixpkgs/pull/11527 - https://github.com/NixOS/nixpkgs/blob/aa5184a88dd116b80aa9d75772db860a2dbd431a/pkgs/development/tools/misc/texinfo/5.2.nix#L15
So the only reason for procps to be pulled in is to run tests, but right now it always happen
When I start tests usingNIX_PATH=nixpkgs=$(pwd) nix-build '<nixpkgs/nixos/tests/boot.nix>'

all fails
Here is the snippet of what chain of derivations is causing this: https://gist.github.com/binarin/9f4cb48211eecf9040cd9269326d32f1
What's going on here is that dbus systemd service tries to pull in system-path, which now includes the texinfoInteractive
And for some reason procps is evaluated with bootstrap-stage4-stdenv-linux stdenv, which is not functional enough to build systemd

As a quick hack I'm going to make a systemd dependency conditional not only on isLinux, but also on the absence of bootstrap in stdenv.name.
Or maybe somebody with more understanding of bootstrap stage layering, fix-points, etc. will chime in with a proper fix.

Merged along with 5ae438a3e.


Clarify that audits evaluate both moderation policies and their application

Checkboxes:

[ ] @Mark-Simulacrum
[x] @yaahc
[x] @joshtriplett
[x] @technetos
[x] @khionu
[x] @jntrnr
[x] @rylev

@Mark-Simulacrum asked to be non-blocking for the moment, so merging this with six :heavy_check_mark:s.


[KOGITO-3793] Review OLM UI spec descriptors

Signed-off-by: Karel Suta<EMAIL_ADDRESS>https://issues.redhat.com/browse/KOGITO-3793
Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[x] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[x] You've added a RELEASE_NOTES.md entry regarding this change

Mostly formatting adjustments. I have applied specific descriptors for some fields, but for some reason it didn't reflect properly in OCP console as I would expect.

@ricardozanini @spolti PR adjusted. I figured out that I was still using old descriptors, now it should be correct.
However operator-sdk has a bug [1] preventing it from resolving descriptors from types defined in separate go file, so KogitoRuntime and supporting service fields are still without descriptors.
That will get fixed once we upgrade to operator-sdk > 1.2
[1] https://github.com/operator-framework/operator-sdk/pull/4507

Thanks, @sutaakar. I believe it's pretty important to upgrade the SDK since we are too behind. Do we have a JIRA to track it?

Thanks, @sutaakar. I believe it's pretty important to upgrade the SDK since we are too behind. Do we have a JIRA to track it?

@ricardozanini
I create below jira to upgrade operator-sdk version in kogito operator.
https://issues.redhat.com/browse/KOGITO-5760

I see that this PR was already merged. Were you guys able to reproduce the UI locally? It would be nice to document it with some screenshots (release notes would definitely be enhanced by them :)).

The most "interesting" parts are waiting for operator-sdk upgrade. What I reproduced was mostly "just" indentation adjustments and replacing checkboxes with toggles in some places.

Luckily there is something on KogitoBuild :)

@vaibhavjainwiz I believe that's pretty critical to have this update for 1.11.0 since it will be the productized version.

@vaibhavjainwiz I believe that's pretty critical to have this update for 1.11.0 since it will be the productized version.

Already on it. Will try to raise its PR by tomorrow.


Use 'good fee' provider to provide users' effective fee rates

cointape.com provides estimates of the 'right' fee to use to get transactions confirmed.
There is an API here:
http://www.cointape.com/api
This could be incorporated as a more advanced dynamic fee option i.e. Do you want a fixed fee rate or use a fee rate provider ? On the Fees dialog.

We've received some user feedback from the community about incorporating this, especially in light of the ongoing "stress tests".
I propose we move this into 0.1.5. Because it relies on a third-party API provider we may need to consider multiple alternative feed providers (including ourselves) and also what to do in the absence of a provider.


Allow visibility on constructors

Fixes #2341.
Changes:
1 - Allows private, protected and public accessibilities on constructors.
2 - Disallows classes with private constructors from being extended.
3 - Now throws an error on constructor overloads with different access modifiers (than the constructors implementation).

Hi @AbubakerB, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

For this to work properly, the visibility needs to be part of the construct signature rather than being a declaration-based check that happens during signature resolution. Otherwise it's going to be too difficult to enforce assignability constraints based on constructor visibility.
A relevant testcase to add would be:
class Foo {
  private constructor() { }
}
class Bar {
  protected constructor() { }
}
let x: new() => any;
x = Foo; // Should be an error
x = Bar; // Should be an error

@RyanCavanaugh SignaturesRelatedTo now checks visibility of constructor.

Should i close this off? or is this in the pipeline?

The declaration emitter will need to be amended - add // @declaration: true to the top of every file.

The declaration emitter will need to be amended - add // @declaration: true to the top of every affected test file.

The following test cases would be useful too:
class Base {
    protected constructor() {
    }
}

class Derived extends Base {
    private constructor() {
        super();
    }
}

class Base {
    protected constructor() {
    }
}

class Derived extends Base {
    protected constructor() {
        super();
    }
}

var baseCtor = Base;
baseCtor = Derived;

@AbubakerB sorry this fell off of our radar, we've been hard at work on TypeScript 1.6.
@ahejlsberg @mhegazy @vladima any thoughts?

@DanielRosenwasser I see, that's fine :)

I've added // @declaration: true to the three test files.
Added test cases under classConstructorAccessibility2.ts. Although, I have one question... Can a X ctor signature be assigned to a non-X ctor signature? (where X is public/protected/private).
Renamed the diagnostic message for error code 2656 to be more clear.

@AbubakerB can you get this up-to-date and resubmit in a new PR? Very sorry we left this hanging for so long.

Sure. I've opened a new PR for this.


Hero formatting update

See trello card for more details.

Hi @theSKa!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

Changes must be made to the original JS source code file(s), not just the generated concatenated JS file(s).

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)

...and again. Don't try to push your changes upstream like this, thanks.


NPM & Certbot Renewal Hooks

Certbot renewal hooks not firing. See discussion.
Discussed in https://github.com/NginxProxyManager/nginx-proxy-manager/discussions/2023

Originally posted by jtrosper April 22, 2022
Hello,
I have a use case where my goal is the following:
Have NPM running via docker
Have a proxy host configured with NPM's letsencrypt support generating the SSL cert.
Have a script on the local host's file system in /npm-dir/letsencrypt/renewal-hooks/post/ which uses the cert generated via npm/certbot.
My understanding is that a standard install of certbot will automatically execute anything contained in /renewal-hooks/post/ without having to specify any extra config.
Does a dockerized NPM installation also do this, if a post-renewal script is placed into this folder?  Or does it need to live inside of the container somehow?

Keeping open.
Thanks,
Jimmy Trosper

From: github-actions[bot] @.>
Sent: Friday, April 5, 2024 9:48:11 PM
To: NginxProxyManager/nginx-proxy-manager @.>
Cc: Jimmy Trosper @.>; Author @.>
Subject: Re: [NginxProxyManager/nginx-proxy-manager] NPM & Certbot Renewal Hooks (Issue #3185)
Issue is now considered stale. If you want to keep it open, please comment 👍
—
Reply to this email directly, view it on GitHubhttps://github.com/NginxProxyManager/nginx-proxy-manager/issues/3185#issuecomment-2040852049, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADSCXG6K4L62FPE3GXKUORDY35H5XAVCNFSM6AAAAAA4O4LEQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHA2TEMBUHE.
You are receiving this because you authored the thread.Message ID: @.***>

Hello jtrosper, did you find a solution to this?
I'm doing exactly the same thing, and similarly, the bash script I've put in renewal-hooks/post does not seem to get executed.


[Bug]:

Project Version
3.2.6
Platform and OS Version
macOS Sequoia Versión 15.1 beta (24B5070a)
Affected Devices
MACBOOK PRO M1
Existing Issues
No response
What happened?
I cant save pth....
Steps to reproduce

...
Expected behavior
generate pth
Attachments
No response
Screenshots or Videos
No response
Additional Information
No response

follow the template

follow the template

https://github.com/user-attachments/assets/3e9125e1-aa56-4aa3-a6d4-649d0aeae88b


Updating sorting positions

So … users have been reporting to me that "the sorting is broken", which baffled me until they showed me what they meant. Turns out sorting isn't broken, but the fact that each subsequent click on a header adds a sortingColumns entry with higher position (i.e. lower priority) means that in practice, clicking on a header often doesn't have any visible effect – because any lower-position column will determine the order unless its data is degenerate.
I explained the position system – to lots of hmmms and cocked heads and furrowed brows – and was told that the intuitive expectation was instead that every click should make that column the lowest-position one, while all others' positions are incremented by one, such that every click has a visible effect and nothing feels broken.
Having spent time with the sorting code myself, I was totally unaware that this would be an issue for people, but I can see now that it may be worthwhile providing the option at least. Maybe the position-updating behaviour can be provided via a prop to <Table.Header> or something? Or maybe you have a better idea altogether? Looking forward to your thoughts.

Yeah, I can see how that could be confusing to the users. I think you could solve this neatly by passing a custom sort function to sorter. Basically it does sort(data, columnIndexList, orderList) (lodash orderBy).
You could write a custom function like this:
const customSort = (data, columnIndexList, orderList) =>  orderBy(data, columnIndexList.reverse(), orderList.reverse());

Note that reverse() mutates the original array so you might want to do something else instead but I think this should work for your case.
If we start getting a lot of feedback about this, maybe we can bake something in. I'm not too sold on custom props as I feel this is something better solved on logic level. That was one of the main goals of the redesign. I don't want to go back to flags and all that again. 👍

Brilliant, that works like a charm! (So well, in fact, that I think it deserves a mention in the docs :)
Thanks for the warning about reverse(), too. There's always slice().reverse(), but I don't even think that's necessary here. :+1:

Yeah, I'll add a note. 👍

Hey, sorry, I do have to revisit this one. I've received complaints – there are situations in which the reverse() hack doesn't achieve the desired effect after all.
What I need, really, is this: when I click on a column with current position: n, that column is set to position: 0 while all column positions between 0 and n - 1 are incremented by one. That is extra code that needs to go into by_columns.js (or a sibling file) I'm afraid.
If you're not interested in offering this functionality I can make a local version of byColumns for myself. Otherwise, I think it would be nice to give users the choice between alwaysPrioritizeLastSort: true or not. What do you think?

I'm not that great fan of flags. I would accept a PR for another sort variant, though.

Sure thing. Any preference regarding the name?

Not really. Propose something. 👍

Man, I'm having a hard time with this one. byColumnsPrioritizeLastSorted okay? It's a mouthful, I know ...

Good enough. Merged. 👍


Is it necessary to train to get a model?

Is it necessary to train? Or else do you have a pre-trained model for making this tested on web cam? Iam new to python. Can you please tell me the steps to make this working on my windows10.
Thank you...

https://github.com/TILhub/Sign-Language-Recognizer-

can someone tell the necessary steps to install all packages and how to proceed?

I think it is pretty clear in the repo.
still try this,
https://www.tensorflow.org/hub/tutorials/image_retraining


Not using https for REST requests

Hi,
I have an asp.net core web api that requires https.
The swagger ui is at https://.../swagger,
and the swagger doc comes from https://...
But if I authenticate and hit the "try it out" button it makes the REST request to http://...
(i can see that request in the firefox console, where it fails because firefox won't automatically mix http and https. If I turn off that protection, it fails with the 302 redirect to https from the rest service)
The rest of the url is correct.
I can't  seem to see how to setup the configuration to sort this.
(it all works fine locally with http://...)
I'm using a clone of the curent codebase (6.0.0). as of when this issue was created.
My config looks like:
public IServiceProvider ConfigureServices(IServiceCollection services)
        services.AddSwaggerGen(c =>
        {
            c.SwaggerDoc("v1", new Info { Title = "API V1", Version = "v1" });

            var authTokenAddress = Configuration["SiteConfig:TokenAddress"];
            c.AddSecurityDefinition("oauth2", new OAuth2Scheme
            {
                Type = "oauth2",
                Flow = "implicit",
                AuthorizationUrl = authTokenAddress,
                Scopes = new Dictionary<string, string>
                {
                        { _scope, "all access" }
                }
            });
            c.IncludeXmlComments(GetXmlCommentsPath(PlatformServices.Default.Application));
        });

public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
           app.UseSwagger();

            app.UseSwaggerUi(c =>
            {
                c.SwaggerEndpoint("/swagger/v1/swagger.json", "V1 Docs");
                c.ConfigureOAuth2("<clientname>", "<passwordvalue>", "<scope>", "<realm>");
            });

I assume I'm missing something obvious but I can't see what.
Cheers
David

In your swagger.json, can you please check if there is a "schemes" element in the root? This may be overriding your scheme to HTTP.

As mentioned by @ahofman, the only way I can really see this happening is if you have an explicit "schemes" field in the generated Swagger. But, I don't see you specifying that anywhere in the config. above.
I've tried to repro with the latest code (available as a preview Nuget on MyGet) but am unable. The requests are made using the scheme that the swagger-ui is provided at - which is the expected behavior.

Closing due to inactivity and unable to repro. If you can provide some clear repro steps (ideally based on a fresh project), please feel free to post and re-open the issue.


Use const in pdf_thumbnail_view.js

Closing since we decided to convert the entire web folder automatically using ESLint's --fix parameter in ##11450 to both reduce code churn and to be done with the conversion quickly. Thank you for helping out with this though; your patches prompted us to look into ways to automate tasks more, like the linting and const conversion, so that's really positive!


Change Univariate implementation for discrete distributions

Distributions are currently Univariate<i64, f64> but I'm pretty sure they can all be changed to Univariate<u64, f64>

Doing this alongside #34. Completed Binomial, Bernoulli, and Geometric so far. DiscreteUniform is not applicable to this issue

Completed with 4ff90fa


this is under which licence ?

This code is under which licence ?
It would be great if you can add that
thanks

This python miner is actually under GNU GPL License though I don't know exactly which version.


[BUG] Cannot connect to promptflow tracing during release deploy pipeline

Describe the bug
Promptflow tracing requires:
az login
pf config set trace.destination..... etc.
When I try to run this as part of my deployment automation workflow in Devops, I get this error every time:
2024-06-07T17:19:50.9316803Z ERROR: The command failed with an unexpected error. Here is the traceback:
2024-06-07T17:19:50.9352168Z ERROR: HTTPSConnectionPool(host='login.microsoftonline.com', port=443): Max retries exceeded with url: /organizations/v2.0/.well-known/openid-configuration (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x000001E92283EE10>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions'))
2024-06-07T17:19:50.9353333Z Traceback (most recent call last):
2024-06-07T17:19:50.9353863Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 174, in _new_conn
2024-06-07T17:19:50.9354502Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/connection.py", line 95, in create_connection
2024-06-07T17:19:50.9355180Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/connection.py", line 85, in create_connection
2024-06-07T17:19:50.9355839Z PermissionError: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions
2024-06-07T17:19:50.9356109Z
2024-06-07T17:19:50.9356463Z During handling of the above exception, another exception occurred:
2024-06-07T17:19:50.9357845Z
2024-06-07T17:19:50.9358145Z Traceback (most recent call last):
2024-06-07T17:19:50.9358642Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
2024-06-07T17:19:50.9359316Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in _make_request
2024-06-07T17:19:50.9359956Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in _validate_conn
2024-06-07T17:19:50.9360610Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 363, in connect
2024-06-07T17:19:50.9361281Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 186, in _new_conn
2024-06-07T17:19:50.9362096Z urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPSConnection object at 0x000001E92283EE10>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions
2024-06-07T17:19:50.9362612Z
2024-06-07T17:19:50.9362938Z During handling of the above exception, another exception occurred:
2024-06-07T17:19:50.9363167Z
2024-06-07T17:19:50.9363427Z Traceback (most recent call last):
2024-06-07T17:19:50.9363909Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 486, in send
2024-06-07T17:19:50.9364541Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 827, in urlopen
2024-06-07T17:19:50.9365184Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 799, in urlopen
2024-06-07T17:19:50.9365820Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/retry.py", line 592, in increment
2024-06-07T17:19:50.9366983Z urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='login.microsoftonline.com', port=443): Max retries exceeded with url: /organizations/v2.0/.well-known/openid-configuration (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x000001E92283EE10>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions'))
2024-06-07T17:19:50.9367764Z
2024-06-07T17:19:50.9368136Z During handling of the above exception, another exception occurred:
2024-06-07T17:19:50.9368337Z
2024-06-07T17:19:50.9368572Z Traceback (most recent call last):
2024-06-07T17:19:50.9368849Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
2024-06-07T17:19:50.9369231Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 664, in execute
2024-06-07T17:19:50.9369645Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 731, in _run_jobs_serially
2024-06-07T17:19:50.9370051Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 701, in _run_job
2024-06-07T17:19:50.9370453Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 334, in call
2024-06-07T17:19:50.9370864Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
2024-06-07T17:19:50.9371262Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/profile/custom.py", line 139, in login
2024-06-07T17:19:50.9371654Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/_profile.py", line 154, in login
2024-06-07T17:19:50.9372052Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/auth/identity.py", line 160, in login_with_auth_code
2024-06-07T17:19:50.9373083Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/auth/identity.py", line 119, in _msal_app
2024-06-07T17:19:50.9373474Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/application.py", line 1814, in init
2024-06-07T17:19:50.9373848Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/application.py", line 504, in init
2024-06-07T17:19:50.9374201Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/authority.py", line 115, in init
2024-06-07T17:19:50.9374582Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/authority.py", line 182, in tenant_discovery
2024-06-07T17:19:50.9374964Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/individual_cache.py", line 269, in wrapper
2024-06-07T17:19:50.9375325Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 602, in get
2024-06-07T17:19:50.9375693Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 589, in request
2024-06-07T17:19:50.9376061Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 703, in send
2024-06-07T17:19:50.9376405Z   File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 519, in send
2024-06-07T17:19:50.9377099Z requests.exceptions.ConnectionError: HTTPSConnectionPool(host='login.microsoftonline.com', port=443): Max retries exceeded with url: /organizations/v2.0/.well-known/openid-configuration (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x000001E92283EE10>: Failed to establish a new connection: [WinError 10013] An attempt was made to access a socket in a way forbidden by its access permissions'))
2024-06-07T17:19:50.9385986Z To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
2024-06-07T17:19:51.5542663Z pf : The term 'pf' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
2024-06-07T17:19:51.5543369Z spelling of the name, or if a path was included, verify that the path is correct and try again.
2024-06-07T17:19:51.5543918Z At D:\AzureDevOps\Agents\A2_work_temp\61376baa-b908-4c17-ad64-dc2bcd9fd926.ps1:5 char:1
2024-06-07T17:19:51.5544302Z + pf config set trace.destination="azureml://subscriptions/a06dfadd-e31 ...
2024-06-07T17:19:51.5544642Z + ~~
2024-06-07T17:19:51.5545002Z     + CategoryInfo          : ObjectNotFound: (pf:String) [], ParentContainsErrorRecordException
2024-06-07T17:19:51.5545404Z     + FullyQualifiedErrorId : CommandNotFoundException
2024-06-07T17:19:51.5546027Z
2024-06-07T17:19:51.5757871Z ##[debug]Exit code: 1
2024-06-07T17:19:51.5797694Z ##[debug]Leaving Invoke-VstsTool.
2024-06-07T17:19:51.6194256Z ##[error]PowerShell exited with code '1'.
2024-06-07T17:19:51.6201865Z ##[debug]Processed: ##vso[task.logissue type=error;source=TaskInternal]PowerShell exited with code '1'.
2024-06-07T17:19:51.6315367Z ##[debug]Processed: ##vso[task.complete result=Failed]Error detected
2024-06-07T17:19:51.6337231Z ##[debug]Leaving D:\AzureDevOps\Agents\A2_work_tasks\PowerShell_e213ff0f-5d5c-4791-802d-52ea3e7be1f1\2.239.1\powershell.ps1.
2024-06-07T17:19:51.6615458Z ##[section]Finishing: PowerShell Script
How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

Try to get promptflow tracing to run on an Azure Web Application

Hi @tyler-suard-parker , thanks for reaching out. According to your error message, seems there are two issues:

az login failed, might be permission issue for your Azure web app
pf seems does not installed correctly. I see

Maybe you need to ensure 1) your Azure web app has enough permission; 2) you have correctly installed pf in the compute.

@zhengfeiwang Thank you for the response.  I installed promptflow using  python -m pip install promptflow promptflow-tools etc. during the build phase.  During the deployment phase, I changed my startup command to the same.  I am getting "requirement already satisfied" for promptflow, but the pf command in bash is still not recognized.  I am not directly calling pf, it looks like when I import promptflow in my Python script, it promptflow tries to run pf in the command line?
Also I am able to log in using azure-cli, but only manually with the interactive web page.

I have tried multiple ways around this, including exporting the binary directory holding pf to PATH, and this is still now working.  Please advise on how to get this to work.

I see line below from your error message:

2024-06-07T17:19:51.5543918Z At D:\AzureDevOps\Agents\A2_work_temp\61376baa-b908-4c17-ad64-dc2bcd9fd926.ps1:5 char:1

So I think there is one powershell script executing az login and pf config set. For the Azure CLI login issue, not sure what's the next step because it seems no action from prompt flow. I recommend you to raise your question in Azure CLI repo: https://github.com/Azure/azure-cli.
The way you install prompt flow looks good to me, but not sure why your compute cannot find the binary. What pf config set trace.destination actually does is 1) validate the Cosmos DB status; 2) persist this config in pf.yaml. So one workaround for you is if you can ensure your Cosmos resource is available, you can modify pf.yaml with simple bash commands, instead of pf commands.

@zhengfeiwang Thank you for your help.  That is correct, I have one powershell script executing both az login and pf config set.
That is good to know that I can modify the pf.yaml file directly, but that still does not help with getting promptflow tracing to run.  Whenever I import promptflow tracing:
from promptflow.tracing import start_trace
from promptflow.tracing._integrations._openai_injector import recover_openai_api
start_trace(collection="PGPT")
for some reason it tries to run the "pf" command in the OS, and even though I installed PF twice already, I still get the bash error "file not found".  Promptflow was installed in a virtual environment on the build computer, and then that virtual environment and working directory were zipped up and moved to the deployment computer, so that may have something to do with it.  However, after deployment I can't modify the file system on that computer because it is read-only.

Here is some more research I have done: the "pf" file has the path for an interpreter at the top:
# -*- coding: utf-8 -*-
import re
import sys
from promptflow._cli.pf import main
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(main()) ```

It looks like that path was created on the build computer, but it did not change when the built package was moved to a different directory on the deployment computer.

in that case, as I don't know how you deploy, you might need to make sure the installation happens in your deploy environment; and seems there is no action required from prompt flow for this issue, so I plan to close this issue - please let me know if you still have further questions regarding to this issue.

No @zhengfeiwang, do not close this ticket.  My issue is, why did your team write this program so that it forces users to authenticate using azure CLI, unlike every other Azure service, where a user can connect by using environment variables?  For Azure AI Search, CosmosDB, SQL, OpenAI, Blob Storage, and Cognitive Services, I can easily connect using environment variables and entering strings like API key, endpoint, etc.  When your team wrote PromptFlow tracing, you made everyone's life miserable by forcing us to use azure CLI and then set the trace destination using another command line.  Please change your code so that it matches with every other Azure service, and we can connect using strings and environment variables.  I have spent 2 weeks so far trying to get Promptflow to work in an Azure web app, and I have come up with nothing.  Promptflow is an Azure product and it should be compatible with other Azure products, and currently it is not.

@tyler-suard-parker regarding to the Azure Web App support, my comment in #3411 shall be enough, it will be tracked as a feature.
As for the pf command not found issue, prompt flow tracing uses a local service as OTLP collector, to invoke this service, it will internally execute command pf service start. Just like you mentioned in this issue, you shall not configure your deploy environment properly, so you will run into pf command not found issue. You still need to figure out that and make prompt flow installed in your Azure Web App or other runtime.
Besides, I want to declare that the Cosmos DB for traces persistence is associated with an Azure ML workspace, or AI project. From your description across issues, I understand you expect to store traces from a custom application hosting on Azure Web App; I have to say, AFAIK, it's not a scenario we considered before. I remember the Cosmos resource is free now, but I don't know whether it will be charged in the future, this is also a risk for you.
At last, I think there is still a workaround for your problem: as prompt flow tracing follows Open Telemetry spec, you can absolutely write a custom exporter that logs traces to a Cosmos DB by yourself, so that you even don't need to worry about configuring your deploy environment with pf command! In that case, how traces logged to Cosmos DB is all dependent on you, including the auth part - so I believe you can connect them easily like your previous experience.

I was able to work around this issue by containerizing my code, creating a new web app, changing my existing deployment pipeline, and re-installing azure cli and promptflow when deploying.


Breadcrumbs on complex view.

I am having trouble figuring out how to get breadcrumbs working on a view that includes both a primary key and a foreign key. In this case there is a project content type (model) and projects can have notes associated with them. I have the breadcrumbs working until a user tries to view an individual note - projects/project/notes/note. I can't figure out how to get the select the relevant ids.
The view:
class ProjectNotesDetailView(DetailBreadcrumbMixin, FormMixin, DetailView):
    model = ProjectNotes
    id = ProjectNotes.objects.only('id')
    template_name = 'company_accounts/project_note_detail.html'
    comments = ProjectNotes.comments
    form_class = NoteCommentForm

    @cached_property
    def crumbs(self):
        project = self.get_object()
        return [
            ("Projects", reverse(
                "company_project:" + CompanyProjects.list_view_name, )
             ),
            (f"{project.title}",
             reverse(
                 "company_project:" + CompanyProjectsDetailView.detail_view_name,
                 kwargs={'pk': project.id})
             ),
            ("Notes", reverse(
                "company_project:" + ProjectNotesList.list_view_name,
                kwargs={'pk': project.id})
             ),
            (f"{ProjectNotes.title}",
             reverse(
                 "company_project:" + ProjectNotesDetailView.detail_view_name,
                 kwargs={'pk': project.id, 'note_pk': self.kwargs.get('pk')})
             ),
        ]

    def get_object(self):
        return get_object_or_404(Project, id=self.kwargs.get('pk'))

    def related_project(self, **kwargs):
        project = get_object_or_404(Project, id=self.kwargs.get('pk'))
        notes = ProjectNotes.objects.all()
        return notes

    def get_context_data(self, **kwargs):
        # Call the base implementation first to get a context
        context = super().get_context_data(**kwargs)

        context['project'] = get_object_or_404(Project, id=self.kwargs.get('pk'))
        return context

    def form_valid(self, form):
        projectnote = get_object_or_404(ProjectNotes, id=self.kwargs.get('pk'))
        comment = form.save(commit=False)
        comment.projectnote = projectnote
        comment.created_by = self.request.user
        comment.save()
        return super().form_valid(form)

    def get_success_url(self):
        return reverse('company_project:project_note_detail', args=[self.kwargs.get('pk'), (self.object.id)])

    def post(self, request, *args, **kwargs):
        if not request.user.is_authenticated:
            return HttpResponseForbidden()
        self.object = self.get_object()
        form = self.get_form()
        if form.is_valid():
            return self.form_valid(form)
        else:
            return self.form_invalid(form)

The URL:
path('project/<int:project_pk>/note/<int:pk>/', ProjectNotesDetailView.as_view(), name='projectnotes_detail'),

The models:
class Project(models.Model):
    title = models.CharField(max_length= 200)
    description = tinymce_models.HTMLField()
    status = models.CharField(max_length=20, choices=PROJECT_CHOICES, default="active")
    date = models.DateTimeField(auto_now_add=True, null=True)
    created_by = models.ForeignKey(CustomUser, editable=False, null=True, blank=True, on_delete=models.RESTRICT)
    tags = tagulous.models.TagField(to=SiteWideTags, blank=True, related_name='projects_tags')

    def __str__(self):
        return self.title

    def get_absolute_url(self):
        return reverse('company_project:project_detail', args=[str(self.id)])

class ProjectNotes(models.Model):
    title = models.CharField(max_length=200)
    body = tinymce_models.HTMLField()
    project = models.ForeignKey(Project, default=0, blank=True, on_delete=models.CASCADE, related_name='notes')
    date = models.DateTimeField(auto_now_add=True, null=True)
    created_by = models.ForeignKey(CustomUser, editable=False, null=True, blank=True, on_delete=models.RESTRICT)

    def __str__(self):
        return self.title

    def get_absolute_url(self):
        return reverse('company_project:project_note_detail', args=[self.project_id, str(self.id)])

Any suggestions for solving this?

@macumhail In such a case I’ll suggest using a View class or if you want to make this a DetailView you can make sure that the link point to the ProjectNotes and you should be able to utilize the get_absolute_url you defined on the model. I’ll also recommend removing the override of get_object since the project would always exists as the database would generally enforce FK constraints.


Stylus tap gesture registering as drag/pan

Upgraded Flutter from version 1.20.x to 1.22.x, now when using a stylus what used to registrer as tap gestures are often registrered as drag/pan.
Everything works fine when using fingers. Downgrading fixes it.
Seems to be an issue on both Android (Nvidia Shield with stylus) and iOS (iPad with Apple pencil).
@jonahwilliams mentioned in discord that he has changed the touch thresholds for stylus pointer types and that changing https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/gestures/constants.dart#L99 may fix the issue.
I might try fixing the problem when I get time.
Steps to Reproduce
Using the following code and tapping with a stylus inside the red container:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: Scaffold(
        body: GestureDetector(
            onTap: () => print('ON TAP'),
            onPanStart: (_) => print('ON PAN'),
            child: Container(color: Colors.red, height: 500, width: 500)),
      ),
    );
  }
}

Expected results:
Flutter version 1.20.4 on the Nvidia tablet I get the expect output when tapping:
I/flutter (30919): ON TAP
I/flutter (30919): ON TAP
I/flutter (30919): ON TAP
I/flutter (30919): ON TAP
I/flutter (30919): ON TAP

Actual results:
Flutter version 1.22.1:
I/flutter (30625): ON PAN
I/flutter (30625): ON TAP
I/flutter (30625): ON TAP
I/flutter (30625): ON PAN
I/flutter (30625): ON PAN

Logs
[✓] Flutter (Channel stable, 1.22.1, on Linux, locale en_US.UTF-8)
    • Flutter version 1.22.1 at /opt/flutter
    • Framework revision f30b7f4db9 (3 days ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /home/mrb/Android/Sdk
    • Platform android-29, build-tools 28.0.3
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Android Studio (version 4.0)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[!] IntelliJ IDEA Community Edition (version 2019.3)
    • IntelliJ at /usr/share/idea
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[!] IntelliJ IDEA Ultimate Edition (version 2019.2)
    • IntelliJ at /opt/intellij-idea-ultimate-edition
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] Connected device (1 available)
    • SHIELD Tablet (mobile) •<PHONE_NUMBER>1820029c2c • android-arm • Android 7.0 (API 24)

! Doctor found issues in 2 categories.

Looking at https://github.com/flutter/flutter/pull/64267 perhaps it was the wrong decision going with stylus having the same precision as a mouse?
When testing setting kPrecisePointerHitSlop = kTouchSlop at least fixes the issue.

Seems reasonable. The safest choice would probably be to revert that change for the stylus type, but it would be helpful to know the threshold where stylus becomes unusable. Possibly with a lower slop than touch, but not quite all the way


Enable arp_accept when configuring ARP cache

Enabling arp_accept makes fail-overs faster. This is so, because it prevents the kernel from dropping unsolicited ARP requests.
The disadvantage of the setting is that containers / weave bridge become prone to the ARP spoofing attacks.
Keep in mind, that the documentation about arp_accept is a bit misleading in Documentation/networking/ip-sysctl.txt: regardless whether an entry with IP addr == unsolicited ARP request IP addr exists in the ARP table, the kernel might drop the request if the last update of the entry is within LOCKTIME boundaries. Please see https://github.com/weaveworks/weave/issues/2316#issuecomment-236975722 for further details.
Fixes #2329 and #2316.

Closing due to the security considerations.


Broken documentation

Code from http://cyclone.io/ Code samples in Twisted Application Style simply does not work.
There's an error in last line, instead of  internet.TCPServer(8888, foobar(), interface="<IP_ADDRESS>").setServiceParent(application) it should be  internet.TCPServer(8888, foobar, interface="<IP_ADDRESS>").setServiceParent(application)

updated. thanks!


Generator: update SDK /services

Generated from GitHub run<PHONE_NUMBER> (https://github.com/stackitcloud/stackit-api-specifications/actions/runs/8643921353)

To be merged only after https://github.com/stackitcloud/stackit-sdk-go/pull/395


Should not close the modal if I click anywhere else

Hi,
I want to show the backdrop and should close the popup only on clicking the button Close/OK, currently when i click anywhere else on screen it closes the modal.
Regards,
Nirav

@nirav-upadhyay you can do this by settings backdrop="'static'". The docs show an example of this:
<modal #modal [keyboard]="false" [backdrop]="'static'">
    <modal-header [show-close]="false">

I'm a modal!

    </modal-header>
    <modal-body>
        Hello World!
    </modal-body>
    <modal-footer [show-default-buttons]="true"></modal-footer>
</modal>

The two functions are completely unrelated.  Dismissing a dialog on Esc is a universal approach.  The user has to take an explicit action, just like clicking the Cancel button.
However, whether or not a dialog is closed when the user clicks outside of it is dictated by a business case.  For forms in dialogs, a lot of the time, it is not desirable for the dialog to go away if the user clicks outside of the dialog by accident while navigating from field to field with a mouse.
Could you possibly implement a closeOnOutsideClick option, similar to ng2-modal?
Thanks,
Anna


Create a Helm Chart & Host it

Features:

Catalog = Deployment (conv via env)
Health Checks: Liveliness & Readiness Probes
Service (Configurable, default ClusterIP) - good example in Airflow Community Helmcharts
PodMonitor (as soon as metric endpoint is there https://github.com/hansetag/iceberg-catalog/issues/87)
Ingress (https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/webserver/webserver-ingress.yaml)
Pod Disruption Budget (PDB) (https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/webserver/webserver-pdb.yaml)
Optional database backend (postgres)
Serviceaccount (in airflow chart it is called rbac). Pods should: Drop all capabilities, runAsNonRoot: true

Done https://github.com/hansetag/iceberg-catalog-charts/tree/main/charts/iceberg-catalog !


Hypothesis tests for VCF

Fixes #249
This should be working now, but does it need a hypothesis-vcf release before merging (or not)?

The failure here was because hypothesis created a VCF with a GT INFO field of type Character, and bio2zarr assumes all GT fields have type Integer. The VCF is valid (but almost certainly never occurs in practice), so I think the fix is to change bio2zarr to only interpret GT FORMAT fields as Integer.

coverage: 98.848% (-0.04%) from 98.887%
when pulling 48df4cc312eb64ae3bb5a5f0ad6860f062fa3c35 on tomwhite:hypothesis-vcf-tests
into d1920541bf36101d5e3aa7656094901182c0e98b on sgkit-dev:main.

coverage: 98.89% (+0.003%) from 98.887%
when pulling 48df4cc312eb64ae3bb5a5f0ad6860f062fa3c35 on tomwhite:hypothesis-vcf-tests
into d1920541bf36101d5e3aa7656094901182c0e98b on sgkit-dev:main.

I'm happy to merge if you are?


Tidy up a bit Settings drawer

Now that we're adding some more options to the Settings drawer, maybe we could tidy up a bit the drawer, tweaking some spacings and alignements.
Here is a very raw example but we could tweak it other way!

Forgot to close this issue!


feat: esbuild 0.17

Description
This PR updates esbuild to 0.17.5 from 0.16.14. v0.17.0 has some breaking changes. The breaking changes are:

Move everything related to incremental builds to a new context API

This does not affect most users. If a user is using a plugin that uses build.esbuild.serve/build.esbuild.build + rebuild, it will break.const examplePlugin = {
  name: 'example',
  setup(build) {
    build.esbuild.serve() // something like this
  }
}

Incremental builds now write out build results differently

This does not affect users as we don't use incremental: true. Also we don't expect users to set optimizeDeps.esbuildOptions.incremental: true.

The onRebuild watch mode callback was removed

Since we don't expect users to set optimizeDeps.esbuildOptions.watch, I think we can ignore this one.

FYI type definition diff: https://github.com/evanw/esbuild/compare/v0.16.17...v0.17.0#diff-53664fbdfc62af3b722184289b51ff956243fc8f7e81fb9d0548219307587f7c
Because of the first change, it's technically a breaking change. That said, I guess most plugins doesn't use these and the benefit of bumping the version in minor is larger than little breakage.
Also upgrading esbuild will unlock context.dispose API that will make #11243 straight forward.
close #11704
Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I think this make sense for the next minor too. The first case is pretty strange and doesn't fit optimizeDeps that I think it's safe to bump this.

/ecosystem-ci run

vite-setup-catalogue is failing with main branch and I guess it's a problem on vite-setup-catalogue side.

I also think we should upgrade on the next minor. Breaking changes in esbuild and rollup in our minors have also happened in the past. Maybe in Vite 5 we should formalize that in Vite minors, we may upgrade esbuild and rollup and users should pin Vite to the current minor if they depend on esbuild plugins or rollup types (that we saw breaking in minors). Related: clarify in Vite 5 a policy for Node.js minors.


Bash installation script:  need for root?

This page says the following just above the bash install script:
Fill in the correct parameters on the first three lines, then execute this script as root:
Why is the guidance to run the script as root?  There doesn't appear to be any dependencies on needing root, and in fact, I was able to successfully run the script as a normal user.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72166f34-3f44-ab06-23ab-6369aa29eb7d
Version Independent ID: 9ee7879b-d821-830c-240f-17740418ee86
Content: Azure Compute - Linux Diagnostic Extension
Content Source: articles/virtual-machines/linux/diagnostic-extension.md
Service: virtual-machines-linux
GitHub Login: @jasonzio
Microsoft Alias: jasonzio

I agree; there's nothing in that script that requires root.

Please don't assign this to me; I no longer have a direct involvement with LAD. New owner is @abhijeetgaiha

@SaurabhSharma-MSFT can you please reassign to @abhijeetgaiha. FYI @danielsollondon.

@saurabhsensharma can you try reassigning it to @roiyz-msft

paging @johnkemnetz to respond on this.

#assign @johnkemnetz

@larryms I agree that there is no reason to use root. I'm going to file PR to update the doc, since the owner hasn't responded.
Thanks again for the feedback! Sorry that it has taken so long to get resolved :(
#please-close


bumb TibberLink stable to 1.4.3

1.5.0 created 14.11.2023
1.5.0 120 User
@hombach
Is there any reason to NOT update directly to 1.5.0 which is already 6 days at latest and has 120 Users?

Well, yes, thought the rule is minimum one week in latest?
If 1.5.0 is ok,   I would file a new request?


feat: Azure AD Workload Identity support for Azure Scalers and Key Vault

Signed-off-by: Vighnesh Shenoy<EMAIL_ADDRESS>
Provide a description of what has been changed
Related PRs -
Helm Changes - https://github.com/kedacore/charts/pull/263, https://github.com/kedacore/charts/pull/264
Doc changes - https://github.com/kedacore/keda-docs/pull/752
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)

Relates to #2487

LGTM, added a few remarks.
Would you mind opening a PR for the docs please?

Yeah, I have some minor changes left to do. Will get onto the docs after I am done with those.

@tomkerkhove @JorTurFer @zroubalik Would be helpful if you can run all the azure* e2e tests.

/run-e2e azure*

@tomkerkhove The Application Insight tests started failing recently, I am not sure what changed exactly (even on my dev cluster). Looking at the error, it seemed that the library was not able to send the metrics correctly with just the instrumentation key, and using the connection string resolves the issue.
Could you add AZURE_APP_INSIGHTS_CONNECTION_STRING GitHub secret, and rerun the azure* e2e tests?
(Note - I have already updated the workflow yamls with the env variable.)

PR is open: https://github.com/kedacore/keda/pull/2934

(Note - I have already updated the workflow yamls with the env variable.)

It's not enough, the yaml needs to be in main to be applied. Please undo the changes in the workflow yamls 🙏

@tomkerkhove @JorTurFer I want to raise a PR for the documentation here, but before that we would need to finalize upon and complete the helm changes.

Why does the docs have a pre-requisite on Helm? Normally that should not be the case.
Our Helm charts are available in https://github.com/kedacore/charts where you can just open a PR to change the YAML specs (no need to bump versions) Let me know if you need help.

Why does the docs have a pre-requisite on Helm? Normally that should not be the case.
Our Helm charts are available in https://github.com/kedacore/charts where you can just open a PR to change the YAML specs (no need to bump versions) Let me know if you need help.

Similar to pod identity, we need to mention the flags the user can use, right?

I will go ahead with the helm changes as per the flags mentioned in this comment. Had a question regarding this. There are other changes in the main KEDA code, that also require helm changes (ex - TriggerAuth / ClusterTriggerAuth CRD changes done for Key Vault). Do I need to copy those changes over as well, right now, or do I just add my changes and the rest will be copied over during the release process?
For context, I only need to change the service account template and values used for helm.

Why does the docs have a pre-requisite on Helm? Normally that should not be the case.
Our Helm charts are available in kedacore/charts where you can just open a PR to change the YAML specs (no need to bump versions) Let me know if you need help.

Similar to pod identity, we need to mention the flags the user can use, right?

You can already change v2.7 docs; there's no problem there as they only go live when we ship v2.7.
Our new Helm chart version will only be available then as well.

You can already change v2.7 docs; there's no problem there as they only go live when we ship v2.7.

No, I was confused about the specific flags to add in docs as I was not sure if we had finalized them :)

Helm changes - https://github.com/kedacore/charts/pull/263

Doc changes - https://github.com/kedacore/keda-docs/pull/752

@tomkerkhove Could you once again run the e2e tests? Thanks.

/run-e2e azure*

No tests seem to be running here, weirdly.

/run-e2e azure*

Time to finally try and run the tests? @tomkerkhove @JorTurFer

/run-e2e azure*

Sorry to be a bother. @JorTurFer @tomkerkhove Need the tests to be run again, so I can see the logs from sh

please, use AZURE_RUN_WORKLOAD_IDENTITY_TESTS instead of RUN_WORKLOAD_IDENTITY_TESTS, we add the prefix to organize the envs and I have already created the PR adding it

please, use AZURE_RUN_WORKLOAD_IDENTITY_TESTS instead of RUN_WORKLOAD_IDENTITY_TESTS, we add the prefix to organize the envs and I have already created the PR adding it

I think the prefix needs to be added to the OIDC_ISSUER_URL variable as well.

/run-e2e azure*

/run-e2e azure*

/run-e2e azure*

/run-e2e azure*

Now I can't check it, after lunch I'll try it, maybe I can give you some extra info 🤞

@v-shenoy do you think that you can try to rebase this to the latest main?

@zroubalik This branch is already based on the latest main (commit hash - ea3b2e10d638).

/run-e2e azure-blob*

/run-e2e azure*

@zroubalik I added some logs, could you run the test once more? (You can only run the workload identity tests (workload-identity)

@zroubalik @JorTurFer Could you run the tests once, I added some log statements to check.

/run-e2e azure*

@JorTurFer @zroubalik @tomkerkhove I know I am asking this constantly, but could you run the tests?

Certainly!
/run-e2e azure*

/run-e2e azure*

@tomkerkhove @JorTurFer @zroubalik Could you run the tests?

/run-e2e azure*

@tomkerkhove There seems to be something wrong with the workflow?

@tomkerkhove @zroubalik @JorTurFer There seems to be something wrong with the workflow.

Yeah, some problem with GH probably :( it is failing in another PR as well.

@JorTurFer Could you try running them now?

@v-shenoy , rebase main again please, there is a missing line

/run-e2e azure*

Checking the cluster, there are resources related with aad-wi even the e2e tests have finished

Is this expected?

Checking the cluster, there are resources related with aad-wi even do the e2e tests have finished  Is this expected?

@JorTurFer
I was initially installing these components in the setup file, and removing them during the clean up. I ran into some issues where the tests would randomly fail in this scenario. I wasn't able to figure out what exactly was causing these random failures. So, I removed the clean up, considering we would need the components on the test cluster anyway.
My guess is that the failures were due to the webhook components not being ready by the time keda is deployed. I have added some sleep in the setup section to try and resolve this issue.
You can try running the test again. I would want for the test to at least pass twice before we can begin trusting them.

/run-e2e azure*

/run-e2e azure*

/run-e2e azure*

Personally, I don't have problems with keeping aad-wi there because there are e2e clusters and they are for that, but one question. Are both clusters ready (from Azure pov) or only this PR-e2e clusters is ready?

@JorTurFer I am fine with either, keeping the components in the cluster or cleaning them up. Right now, the tests seem to be working with the clean-up and sleep included, so I guess we can keep them. The reason this test run failed was that both the normal service bus queue and workload identity tests ran together at the same time.
If you want to be sure, you can run just the workload identity tests, regex - workload-identity.
As for the permissions / grants, they have been done for both the pr-e2e and main-build clusters. But obviously they have not been run on the other cluster yet, so after merging we will need to check that they work over there as well.

The reason this test run failed was that both the normal service bus queue and workload identity tests ran together at the same time.

wow, that's true and I didn't notice!  Please use another queue for this test to avoid fails in case of running both at the same time (like it has happened). I mean, changing the queue name should be enough for avoiding the collisions during tests, right?

Right now, the tests seem to be working with the clean-up and sleep included, so I guess we can keep them

yes, if it's already the behavior, lets keep it

The reason this test run failed was that both the normal service bus queue and workload identity tests ran together at the same time.

wow, that's true and I didn't notice! Please use another queue for this test to avoid fails in case of running both at the same time (like it has happened). I mean, changing the queue name should be enough for avoiding the collisions during tests, right?

Yup, it just kind of slipped my mind that this would be a problem when the tests ran parallelly. Changed.
Could you run the tests? (Last time, fingers crossed).

@JorTurFer @tomkerkhove

/run-e2e azure-service-bus*

/run-e2e azure*

@JorTurFer @tomkerkhove Any more work to be done here?

hey @v-shenoy
Sorry for the slow answer, I have been busy with the hotfix release. It's all, thanks for the huge effort you have done


fix(locale):; fixes #1300

Related Ticket(s)
#1300
Description
Fixes fallback when translation response fails.
Changelog
Changed

us-en is now always called in addition to user cc-lc, as opposed to only calling if user cc-lc fails.

@kennylam this needs to target the release branch.

@kennylam this needs to target the release branch.

Doh!


Stapfen's internal arrays and hashes should be thread_safe

See thread_safe

Merged https://github.com/lookout/stapfen/pull/44


Fix a false positive for RSpec/FactoryBot/ConsistentParenthesesStyle when using generate with not a one argument

Fix: https://github.com/rubocop/rubocop-rspec/issues/1480

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[-] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Side note:
We may need to have a configuration if the syntax methods are included or not. People using FactoryBot might prefer using explicit calls in order to avoid ambiguity.

Thank you!


SNX pool APR is 0% on L2 when user is not staking anything

Description:
SNX pool APR is 0% on L2 when user is not staking anything.
Prerequisites:

wallet without a stake on L2

Reproduction steps:

Go to staking "Home" page (https://dev.staking.synthetix.io/)
Connect your metamask
Click on "Switch to L2" button
Go to "Earn" page (https://dev.staking.synthetix.io/earn)

Current behavior:

APR is 0%
Earning section is 0%

Expected behavior:

APR and Earning section should show correct APR for SNX pool

Screenshots:

Desktop (please complete the following information):

OS: macOS Big Sur 11.2.2
Browser: Chrome 89.0.4389.95

Fixed.


Add DeferredRestAction

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
This fixes an issue that might occur with delayed RestActions that are backed by cache state.
Problem
jda.retrieveUserById(userId).queueAfter(24, HOURS, (user) -> {
    System.out.printf("%#s\n", user);
});

The user here might be directly in cache which will return an EmptyRestAction with the user stored immediately. This user is then kept in that rest action instance for 24 hours while JDA might reconnect and invalidate.
Solution
With a deferred implementation we try to load the user from cache lazily. This means the moment that queue is called will decide whether to load the member from cache or make a request.

I know it's late, but looks good.


Remove some pylint warnings

Please review #652 first.
This is a first shot at using #642 but removes only some of the warnings (because there are over 2,000 lines of warnings).  After this PR, probably we should use the pylint configuration from raiden repo.

Breaking rules for being at the bottleneck.


CI: GKE-based: network "default" does not have available private IP space in <IP_ADDRESS>/8 to reserve a /14 block

GKE-based workflows (GKE, external workloads, multicluster) occasionally fail during cluster creation with the following error:
The network "default" does not have available private IP space in <IP_ADDRESS>/9 to reserve a /14 block for pods for cluster

Examples:

Scheduled run on master: https://github.com/cilium/cilium-cli/runs/7000764590?check_suite_focus=true
PR #933: https://github.com/cilium/cilium-cli/runs/6993592366?check_suite_focus=true

I assume this can happen if too many clusters are created simultaneously. One option to work around this would be to specify --cluster-ipv4-cider on gcloud container clusters create. Also see https://stackoverflow.com/questions/42129327/gke-cluster-creation-fails-because-the-network-default-does-not-have-available

The runs linked by Tobias have now expired, but here's a recent one (from the cilium repo) that has the same error message: https://github.com/cilium/cilium/actions/runs/3464773077/jobs/5786716112
https://github.com/cilium/cilium/actions/workflows/conformance-gke.yaml is currently disabled because how flaky it is.
CC: @brlbil


Add support for Spotlight

Summary

If possible, I would love to have spotlight integration to this Sentry SDK.
Motivation

Spotlight is slowly becoming available across all of the other sentry SDKs and it would be extremely helpful to have it here too.

Noted, will be a bit further out as we have to get some other things in first.


PSASSET-860 - Security Group Rules without Descriptions

Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger

https://governance.rightscale.com/org/6/projects/7954/policy-incidents/5b63209c64ce7200709820b8


Mypy update

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jaheba I'm not sure why some checks fail and some others don't, do you think you can fix the mypy complaints that came up?

On it!
Not sure why it is so inconsistent.

Codecov Report

Merging #628 into master will not change coverage by %.
The diff coverage is n/a.


MC land detector question

Hi,
After looking at the land detector code I have a questions :

Why do we use vz in https://github.com/PX4/Firmware/blob/26e85736a52f5dd6cf2395c06a151d17ae0512f1/src/modules/land_detector/MulticopterLandDetector.cpp#L193, but we use derived z in https://github.com/PX4/Firmware/blob/26e85736a52f5dd6cf2395c06a151d17ae0512f1/src/modules/land_detector/MulticopterLandDetector.cpp#L200? shouldn't we use derived in both cases?

Thanks in advanced:)

@garfieldG I'm not too familiar with that code but I think it has to do with the fact that the estimated velocity can have a considerable bias when landing which makes land detection harder. The derivative of the height state might suffer less and I think that's why it's used.

@RomanBapst Thank for response!
But I still can't understand why if we landed less than 2 seconds ago we use vz, otherwise we use vertical derivative. Shouldn't we use the same one (estimated vertical velocity or  vertical derivative) in both cases?
@Stifael maybe you know how to answer on this one? relates to https://github.com/PX4/Firmware/commit/26e85736a52f5dd6cf2395c06a151d17ae0512f1

if I remember it correctly, that commit entered the firmware against my advice. That commit was part of a test branch to check if it would improve the detection, which I could not verify (maybe it does, I was just not able to do verify it). The fact that the derivative term is not always used is probably because of inconsistency. It probably would make sense to evaluate once more the difference between z-deriv and vz.


Add some Timeseries helpers for various calculations.

Adds some methods to Timeseries for helpful calculations, most notably:

computeDeltas() - Calculates the deltas between data points (e.g. to turn cumulative cases into daily new cases).
windowed() - Windowing function that helps with aggregating data (e.g. for rolling average).
rollingAverage() - Calculates the rolling average timeseries from a timeseries.

Note that:

I'm not 100% sure how much of this kind of logic we want to build into Timeseries.  At some point you should probably spin up python and pandas and build a "data pipeline" if you're doing a lot of computation.  But at the same time, it does seem like it's often handy to do basic transformations in the frontend.  So we'll see how this evolves.
The implementations and options provided are kinda' opinionated based on what I think we might want / need, but I'm not super confident so these may evolve over time.
I was torn about creating these as standalone functions (rollingAverage(timeseries)) vs methods (timeseries.rollingAverage()).  The latter is a lot more handy to use, so that's what I did, but it does potentially bloat the Timeseries class with code we might not need for every project.  So if it gets too bloated, we might want to refactor.
computeDeltas() and rollingAverage() only really make sense if the timeseries contains numbers, but you could technically call them on a Timeseries<string> or whatever.  This is a slight wart by putting them directly on the Timeseries class, but I think it's okay.

Part of solving #89.

Would it make sense to call assertFiniteNumbers() in those methods to make it explicit that these only work for Timeseries? I'm not sure if that would add complexity, or if it has any real benefit considering it will (I think) fail anyway if they are called on a Timeseries

It looks like I was doing that (.removeNils().assertFiniteNumbers()) in computeDeltas() but not rollingAverage().  I think was feeling hesitant to do it because I am a bit worried about the wasted performance of calling those over and over.  But I think it is better / cleaner.  I may look into making Timeseries "remember" if those methods have already been called and turning subsequent ones into no-ops, so I can stop worrying about the performance impact.


Proper case for identifiers in all sources

Description

Proper case for identifiers in all sources
It allow us to enable yet another linter

Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

/approve

/lgtm


[FEATURE] Encrypt sensitive data in the catalog properties

Describe the feature
The catalog properties may store some sensitive data, like MySQL passwords and AWS secret keys, which need to be encrypted.
Motivation
No response
Describe the solution
No response
Additional context
No response

I'm drafting a propose to resolve this issue.


Solution to const multiplication of lim.

Hello,
I am fairly new to Lean but I decided to try implementing the theorem limit.const_mult:

Given a sequence (a_n) with limit L, the sequence defined by (c*a_n) should have the limit c*L.

This seemed like a nice next step from showing that a limit is unique. The theorem compiles, but I am not sure if you find it too verbose or just not quality enough. Feel to close or make changes to this pull request if you feel it is not of high enough quality.
Thank you.

@thyrgle Thank you for your PR contribution to the real number game and sorry for the long delay. We couldn't merge your file any more because of the changes in mathlib. We did use your idea however and will acknowledge it to our best.