[SEI-5111]: Fix commits metric document error

Harness Developer Pull Request
Fixed the errors in the SCM Commits metrics ingestion logic doc errors.
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65b10bf11276b18bc36f0193--harness-developer.netlify.app


python dependency missing

I tried to install code via docker,and found some python dependency was missing.
Obtaining misaka from git+https://github.com/qingfeng/misaka.git@2fbe52692e8f304eea9d8925fd2a857916ff0ea5#egg=misaka (from -r requirements.txt (line 20))
  Cloning https://github.com/qingfeng/misaka.git (to 2fbe52692e8f304eea9d8925fd2a857916ff0ea5) to /pip-src/misaka
  Could not find a tag or branch '2fbe52692e8f304eea9d8925fd2a857916ff0ea5', assuming commit.
Collecting mikoto==0.0.4 (from -r requirements.txt (line 21))
  Downloading mikoto-0.0.4.tar.gz
Collecting WebTest==2.0.20 (from -r requirements.txt (line 22))
  Downloading WebTest-2.0.20-py2-none-any.whl
Collecting mock==1.3.0 (from -r requirements.txt (line 23))
  Downloading mock-1.3.0-py2.py3-none-any.whl (56kB)
Collecting nose==1.3.7 (from -r requirements.txt (line 24))
  Downloading nose-1.3.7-py2-none-any.whl (154kB)
Collecting docutils==0.12 (from -r requirements.txt (line 25))
  Downloading docutils-0.12.tar.gz (1.6MB)
Obtaining sina from git+https://github.com/douban/sina.git@fd90a60150545bafd491dfd632d0f8212ae4f622#egg=sina (from -r requirements.txt (line 26))
  Cloning https://github.com/douban/sina.git (to fd90a60150545bafd491dfd632d0f8212ae4f622) to /pip-src/sina
  Could not find a tag or branch 'fd90a60150545bafd491dfd632d0f8212ae4f622', assuming commit.
Obtaining DoubanUtils from git+https://github.com/douban/douban-utils.git@5ca697545da191dab3fbe308e6b6776d8da83bd5#egg=DoubanUtils (from -r requirements.txt (line 27))
  Cloning https://github.com/douban/douban-utils.git (to 5ca697545da191dab3fbe308e6b6776d8da83bd5) to /pip-src/doubanutils
  Could not find a tag or branch '5ca697545da191dab3fbe308e6b6776d8da83bd5', assuming commit.
Obtaining DoubanSQLStore from git+https://github.com/douban/douban-sqlstore.git@d7136b7cac1075f0b285e8c763af2e85124f8b76#egg=DoubanSQLStore (from -r requirements.txt (line 28))
  Cloning https://github.com/douban/douban-sqlstore.git (to d7136b7cac1075f0b285e8c763af2e85124f8b76) to /pip-src/doubansqlstore
  Could not find a tag or branch 'd7136b7cac1075f0b285e8c763af2e85124f8b76', assuming commit.
Obtaining DoubanMC from git+https://github.com/dongweiming/douban-mc.git@5a0a21cdb73a448eb09a1b657ad80d4941ddb404#egg=DoubanMC (from -r requirements.txt (line 29))
  Cloning https://github.com/dongweiming/douban-mc.git (to 5a0a21cdb73a448eb09a1b657ad80d4941ddb404) to /pip-src/doubanmc
fatal: could not read Username for 'https://github.com': No such device or address
Command "git clone -q https://github.com/dongweiming/douban-mc.git /pip-src/doubanmc" failed with error code 128 in None

me too

cc @dongweiming 这个仓库可以直接用 https://github.com/douban/douban-mc 么?我不太记得了，不知道你是否有改动？

@xtao 嗯 之前被我项目可能被我误删了。 已经恢复
@waterdrops @pigletfly 现在试试

  Cloning https://github.com/qingfeng/misaka (to 2fbe52692e8f304eea9d8925fd2a857916ff0ea5) to /pip-src/misaka
  Could not find a tag or branch '2fbe52692e8f304eea9d8925fd2a857916ff0ea5', assuming commit.
Collecting mikoto==0.0.4 (from -r requirements.txt (line 21))
  Downloading mikoto-0.0.4.tar.gz
Collecting WebTest==2.0.20 (from -r requirements.txt (line 22))
  Downloading WebTest-2.0.20-py2-none-any.whl
Collecting mock==1.3.0 (from -r requirements.txt (line 23))
  Downloading mock-1.3.0-py2.py3-none-any.whl (56kB)
Collecting nose==1.3.7 (from -r requirements.txt (line 24))
  Downloading nose-1.3.7-py2-none-any.whl (154kB)
Collecting docutils==0.12 (from -r requirements.txt (line 25))
  Downloading docutils-0.12.tar.gz (1.6MB)
Obtaining sina from git+https://github.com/douban/sina.git@fd90a60150545bafd491dfd632d0f8212ae4f622#egg=sina (from -r requirements.txt (line 26))
  Cloning https://github.com/douban/sina.git (to fd90a60150545bafd491dfd632d0f8212ae4f622) to /pip-src/sina
  Could not find a tag or branch 'fd90a60150545bafd491dfd632d0f8212ae4f622', assuming commit.
Obtaining DoubanUtils from git+https://github.com/douban/douban-utils.git@5ca697545da191dab3fbe308e6b6776d8da83bd5#egg=DoubanUtils (from -r requirements.txt (line 27))
  Cloning https://github.com/douban/douban-utils.git (to 5ca697545da191dab3fbe308e6b6776d8da83bd5) to /pip-src/doubanutils
  Could not find a tag or branch '5ca697545da191dab3fbe308e6b6776d8da83bd5', assuming commit.
Obtaining DoubanSQLStore from git+https://github.com/douban/douban-sqlstore.git@d7136b7cac1075f0b285e8c763af2e85124f8b76#egg=DoubanSQLStore (from -r requirements.txt (line 28))
  Cloning https://github.com/douban/douban-sqlstore.git (to d7136b7cac1075f0b285e8c763af2e85124f8b76) to /pip-src/doubansqlstore
  Could not find a tag or branch 'd7136b7cac1075f0b285e8c763af2e85124f8b76', assuming commit.
Obtaining DoubanMC from git+https://github.com/dongweiming/douban-mc.git@5a0a21cdb73a448eb09a1b657ad80d4941ddb404#egg=DoubanMC (from -r requirements.txt (line 29))
  Cloning https://github.com/dongweiming/douban-mc.git (to 5a0a21cdb73a448eb09a1b657ad80d4941ddb404) to /pip-src/doubanmc
  Could not find a tag or branch '5a0a21cdb73a448eb09a1b657ad80d4941ddb404', assuming commit.
Obtaining ORZ from git+https://github.com/douban/douban-orz.git@208b48177dc847ef2afdadfda302868c39797bdf#egg=ORZ (from -r requirements.txt (line 30))
  Cloning https://github.com/douban/douban-orz.git (to 208b48177dc847ef2afdadfda302868c39797bdf) to /pip-src/orz
  Could not find a tag or branch '208b48177dc847ef2afdadfda302868c39797bdf', assuming commit.
Obtaining Quixote from git+https://github.com/douban/douban-quixote.git@20cda948580802ee4205b72fe46728de9dda5253#egg=Quixote (from -r requirements.txt (line 31))
  Cloning https://github.com/douban/douban-quixote.git (to 20cda948580802ee4205b72fe46728de9dda5253) to /pip-src/quixote
  Could not find a tag or branch '20cda948580802ee4205b72fe46728de9dda5253', assuming commit.
Obtaining pygit2 from git+https://github.com/douban/pygit2.git@c7b13237e9934b5620cf0c351ae7eaea7d14ffc3#egg=pygit2 (from -r requirements.txt (line 32))

  Cloning https://github.com/douban/pygit2.git (to c7b13237e9934b5620cf0c351ae7eaea7d14ffc3) to /pip-src/pygit2
  Could not find a tag or branch 'c7b13237e9934b5620cf0c351ae7eaea7d14ffc3', assuming commit.

there are some error when installing requirements.

@pigletfly 这种「Could not find a tag or branch」是个warn请不要介意。这是豆瓣长期以来的指定使用项目的某个commit上的方法，也是pip支持的用法，事实上可用的。


Thoughts on best practices for line endings?

I'm currently using git attributes to keep LF endings on Windows, but I'm wondering if the text differ should ignore LF/CTLF differences by default. WDYT?

We probably want to keep strict diffs the default, but feel free to submit a PR to add a line-ending-agnostic differ!

Closing for now but looking forward to a PR!


[RFE] trace exec: add new fields for: from memfd, upper layer, writable, unlinked

Current situation
The events from the trace exec gadget have the following columns:
$ ig trace exec -h
...
Available columns:
  args
  comm
  gid
  loginuid
  mntns
  pid
  ppid
  ret
  runtime.containerId
  runtime.containerImageName
  runtime.containerName
  runtime.runtimeName
  sessionid
  timestamp
  uid
Default columns: runtime.containerName,runtime.containerImageName,pid,ppid,comm,ret,args
...

It does not have the following details about the program being executed:

from memfd: whether the program file is not on the filesystem but on a memfd (see man 2 memfd_create), aka "fileless execution"
upper layer: whether the program file is on the upper layer of overlayfs, i.e. it was modified in the container
writable: whether the caller has write permission on the program file.
unlinked: whether the program file has been deleted.

Impact
The missing details are useful to understand security attacks.
Ideal future situation
The trace exec gadget has an 'inode info' field with the 4 aforementioned booleans.
Implementation options
This list comes from Falco libraries and Tetragon:

extract__exe_from_memfd
extract__exe_upper_layer
extract__exe_writable
file->f_inode->__i_nlink

We don't have direct access to the struct file from tracepoint/syscalls/sys_exit_execve. Options:

kprobe/security_bprm_check (https://github.com/cilium/tetragon/pull/499)
(Falco's extract__exe_file_from_task)

Additional information
https://en.wikipedia.org/wiki/Fileless_malware

bumping this issue.
We need this feature for our commitments to product & sales team

As per our discussion we should close this issue in favor of new issues split up.
I cannot close since I didnt open it


update vendors

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

Updated vendor libraries. set php 7.0.8 as min version, because its required for symfony components 3.4.* versions.
there is no symfony component for >=7.0 & <=7.0.8 because php7 had some nasty bugs in those early 7.0.x versions.
I know this change could lead to some discussion, therefore I will not yet add CHANGELOG and similar.
In case we agree on this change, I can finish it up.
Motivation for this change is some strange behaviour with uoload(), which seems to only work in 40-50%. there could be some kind of race condition in the php impl.  without changes in the recipe it hangs rather often for me

per changelog there is no documented BC break in any of our referenced components
https://github.com/symfony/console/blob/3.4/CHANGELOG.md
https://github.com/symfony/process/blob/3.4/CHANGELOG.md
https://github.com/symfony/yaml/blob/3.4/CHANGELOG.md

Dropped config at all.

thx.
FWIW, I created a symfony process upstream issue for the hanging rsync+multiplex problem
https://github.com/symfony/symfony/issues/25580
as the update of the vendors did not fix the issue for me :-/


Add a gradient_clip_algorithm flag to the Trainer

What does this PR do?

Add "clip_gradients_by_value"
Related Issues: #5460, #5456, #4927
Previous PR: https://github.com/PyTorchLightning/pytorch-lightning/pull/5477
@tchaton Thanks for giving me a lot of advice.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Related Issues: #5460, #5456, #4927

what does it mean that it solves these issues?

@Borda Thank you for your comments.
I changed codes based on comments.

Related Issues: #5460, #5456, #4927

what does it mean that it solves these issues?

It means, this PR adds a clip_gradient by value option.

Hello @dhkim0225! Thanks for updating this PR.

In the file pytorch_lightning/utilities/enums.py:

Line 103:1: W293 blank line contains whitespace

@dhkim0225 I merged master into the PR but some tests are failing. Can you have a look?

@carmocca clip gradients by value seems doesn't work with horovod-cpu.
I keep getting an error from horovod-cpu tests, but it works well after I remove the clip_grad_by_value test in horovod-cpu tests.
I'm not sure if this is normal. If it's expected behavior, we can mention in the document that clip_gradients does not work with horovod cpu.

DoublePrecisionPlugin needs to be updated too

@ananthsub Patched :]

@dhkim0225 Could you please address the failing tests?

Bugs in the test codes clip gradients by value with horovod are fixed.
Some tests are failed since pytorch v1.8.1 released (https://github.com/pytorch/pytorch/releases/tag/v1.8.1)

@carmocca Honestly, I'm tired of the slow progress.
The first time this PR was written was on January 12th. (https://github.com/PyTorchLightning/pytorch-lightning/pull/5477)
Merge is continuously postponed and new conflicts continue to occur, although It is a simple feature.
Please clearly guide me if there is anything I can do to make this feature merge quickly.

Hey @dhkim0225! Thanks a lot for your patience. This PR is just waiting for the final approval so I will just push it internally 👍

merged!
sorry about that! Looks like this one fell through the cracks.
Thanks for the contribution!


Streaming playback?

How will this work exactly? And what are your plans for implementing it?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/4024648-streaming-playback?utm_campaign=plugin&utm_content=tracker%2F298985&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F298985&utm_medium=issues&utm_source=github).

Streaming playback is already supported. From the README:
stream = file.createReadStream([opts])
Create a readable stream
to the file. Pieces needed by the stream will be prioritized highly and fetched from the
swarm first.
You can pass opts to stream only a slice of a file.
{
  start: startByte,
  end: endByte
}

Both start and end are inclusive.

Streaming playback is implemented for VLC, Chromecast, Airplay, the html5 <video> tag, etc. by detecting seek events and responding with the correct file data. If those pieces of the torrent haven't been fetched from the network yet, then these pieces are highly prioritized.


[REQUEST] The new null safety code design has a serious issue regarding AssetEntity

When I just recently updated the package to 5.0.1 it hit me pretty hard.
According to the own documentation the f.e. duration of an AssetEntity should have a default value of 0.
Yet within null safety it is declared as required.
Furthermore the property isFavorite or orientation is also set as required even if they are platform specific properties --> then those kind of properties should not really be set to required.
I'm using the AssetEntity object pretty often within my app.
Therefore I suggest, that we change the declaration of the AssetEntity constructor the following way, so it will become more readable and understandable:
AssetEntity({
required this.id,
required this.typeInt,
this.duration = 0,
this.width = 0,
this.height = 0,
this.orientation = 0,
this.isFavorite = false,
this.title,
this.createDtSecond,
this.modifiedDateSecond,
this.relativePath,
});
I really hope we can improve the code, because many values really don't need to be required

Could you move the issue to the photo_manager's repo? This is not really a good place to start the improvement. Anyway thanks for the advice. Let's continue with the correct repo.

oh sure sorry for the mistake

Let me know if you filed a new issue. :)


Video Pauses when starting playback

Video Pauses itself each time you start to play something

This issue is already open:
Auto play #179

I edited and removed what was mentioned on this issue
I somehow missed it, thanks.

Is this caused by the Auto frame rate matching? Does it work (start the playback) when you disable it? If yes, than it is the same issue as in #179. In this case, please provide me a bug report.


pipenv sync changes Pipfile.lock

I checked the issues, but found nothing similar. I used the pipenv included in Ubuntu Eoan
Issue description
I added 1 dependency to the Pipfile, but left Pipfile.lock untouched.
pipenv sync changes Pipfile.lock
Expected result
Pipfile.lock is left untouched when running pipenv sync. pipenv installs packages described in Pipfile.lock, as described in the docs.
Actual result
Pipfile.lock was changed
Steps to replicate
relevant part of dockerfile:
FROM ubuntu:eoan

RUN apt update \
    && apt install -y --no-install-recommends \
      'python3=3.7.5-1' \
      'pipenv=11.9.0-1' \
    && apt clean \
    && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

ENV APP_DIR=/usr/src/app
RUN mkdir -p ${APP_DIR}
WORKDIR ${APP_DIR}

COPY Pipfile* ${APP_DIR}/

# Pipfile.lock should be present in git repository - it should not be generated in CI/CD
# We generate Pipfile.lock inside the container if PIPENV_LOCK is set to non-empty string
ARG PIPENV_LOCK
RUN md5sum Pipf*
RUN if [ -n "$PIPENV_LOCK" ] ; then pipenv lock --verbose ; fi
RUN chmod a-w ./Pipfile.lock
RUN md5sum Pipf*
RUN pipenv sync --verbose
RUN md5sum Pipf*
RUN pipenv --support

commands run in the directory containing the dockerfile
docker build -t project . && \
  id=$(docker create project) && \
  docker cp $id:/usr/src/app/Pipfile ./Pipfile && \
  docker cp $id:/usr/src/app/Pipfile.lock ./Pipfile.lock && \
  docker rm -v $id && \
  git add Pipfile Pipfile.lock

I'm attaching the output of the commands:
pipenv.log
I believed pipenv will enable me to be sure I've installed the same packages, with the same hashes. In reality pipenv sync changes the file it is supposed to read from. Some parameters described in the docs does not work. Is this production ready? How does this make sure packages' hashes haven't change if the file containing the hashes was changed itself?

It seems you are using an old release version (11.9.0)which is 2+ years ago. Please try the latest release.

Yep. After installing the latest stable with pip everything is fine. Sorry to bother you and thank you so much for help!


Examples throw an ERROR:  [uncaughtException] Invalid value "undefined" for header "x-forwarded-for"

I didn't check all examples, but some in routing section ("pages", "universal router") don't work cause of above mentioned error.
Others might don't work too, I didn't check.

can you share an example url?


If you want to show titlebar menu delete all of this line:

          If you want to show titlebar menu delete all of this line:

/* Hides Top Toolbar (single toolbar) */
:root[zen-single-toolbar="true"] #zen-appcontent-navbar-container {
  max-height: var(--zen-element-separation) !important;
}

:root[inDOMFullscreen="true"] #zen-appcontent-navbar-container {
  display: none !important;
}

and then search /* delete this to show */ , just remove the display: none;
Originally posted by @nieffka in https://github.com/nieffka/bubble-clean-zen/issues/2#issuecomment-2554052817
I have done the said corrections in the CSS file, and now the title bar does appear on hover, but the minimize, maximize and close buttons have disappeared.

do you do this?

Oh now I found. I tried to find it first (forgot Notepad has a Search feature😅). Now using the Search I found it...


TSP dynamic solution optimization

The TSP dynamic solution is very slow. It must be optimized with special attention to sets/subsets manipulation.

Resolved by PR #66


Add Help Text to Admin Add Reportback Form

User Story
Sometimes, leads need to manually add reportbacks for users who have missed the campaign deadline or are having trouble uploading their photo. They use this link: dosomething.org/admin/users/rb/add. However, the form is tricky and doesn't provide a lot of clarity about how to use it.
Additional Information (optional)
FIELD :: Additional Help Text
NODE :: The campaign node this reportback was submitted for.
USER :: Type in the UID of the user that submitted this reportback and choose the UID from the dropdown menu. If you don't see the UID in the dropdown menu, please go to the user's profile, the edit tab, and copy the username listed in the topmost field. Slowly type this into the field and select the correct user from the dropdown menu. You MUST select the user from the dropdown menu for this form to submit.
CHOOSE FILE :: The image must be at least 480 by 480 pixels. The site will crop the image on its own, so if possible submit a square image with the subject in the center of the crop.
CAPTION :: This is public facing. Do not enter private user information.
TOTAL NUMBER OF NOUNS VERBED :: Only type in the number -- like "300" or "5".
Why This Matters
The form should be self explanatory.

Hey @chloealee -- looks like the admin help text for the reportback form is showing up in the user-facing view as well :(
https://www.dosomething.org/us/campaigns/elephant-tusk-force


Installing AdminCenter

Maybe I missed something obvious, but I can't see any way to pull in and install the admin-center jar (for instance, from here: https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/beta/wlp-beta-admin-2<IP_ADDRESS>.jar)
This feels like a pretty core component of wlp alongside extended and extras.
On top of this, it would be pretty slick to have a special provider that will automatically make admin center aware of other selected servers defined through serverconfig.  That's probably a future request.

You make a good point. The wlp-beta-admin-2<IP_ADDRESS>.jar is classed as an addon in http://wasdev.net/repo - meaning it conains a group of features, for the sake of convenience.
install_feature.rb is able to download and install a feature .esa. It puts it into the Chef cache then runs featureManager install. But because it installs the feature directly from the local Chef cache, the featureManager doesn't figure out the dependencies and so doesn't install them first. So right now you have to figure out the dependencies yourself and drive install_feature.rb for each of them. Something like:
  feature_map = {
    "restHandler" => "http://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/<IP_ADDRESS>/com.ibm.websphere.appserver.restHandler-1.0.esa",
    "adminCenter" => "http://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/<IP_ADDRESS>/com.ibm.websphere.appserver.adminCenter-1.0.esa",
    "explore" => "http://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/<IP_ADDRESS>/com.ibm.websphere.appserver.adminCenter.tool.explore-1.0.esa"
  }

  # download each file and place it in right directory
  feature_map.each do | feature, feature_location |
    wlp_install_feature feature do
      location feature_location
      accept_license true
    end
  end

The install_feature.rb caches the .esa files - which is good. What's not good, is it doesn't calculate the dependencies. I'd like to switch to the new installUtility that's in the beta. By default, installUtility download only downloads the artifacts it doesn't already have, and it calculates the dependencies required.


One-click deployment to closed testing

For using fastlane: it's in the feeder/android folder
https://docs.fastlane.tools/getting-started/android/setup/
Application id: com.gita.sudeep.gitahtml
Google cloud project name: gitapower-26
service account email<EMAIL_ADDRESS>Location of json: .google-play/gitapower-service-account.json
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
Command from https://docs.fastlane.tools/actions/upload_to_play_store/
fastlane supply --apk path/app.apk --track beta --rollout 0.5
Learn more about how to automate the Google Play release process:
https://docs.fastlane.tools/getting-started/android/release-deployment/
For a summary of actions:  fastlane action upload_to_play_store
Learn more about how to automatically generate localized Google Play screenshots:
https://docs.fastlane.tools/getting-started/android/screenshots/
Learn more about distribution to beta testing services (we don't use such services):
https://docs.fastlane.tools/getting-started/android/beta-deployment/
List of other actions: https://docs.fastlane.tools/actions

Automate screenshots by creating a separate test, with dependency on screenshots:
https://pub.dev/packages/screenshots?source=post_page-----f78be70cd5fd--------------------------------
Create workflow file for it and commit to github


Table-based Git tag specs

@charlierudolph @allewun @ricmatsui

adds table-based Git tag specification
implements the Finder pattern that @charlierudolph proposed
specifies the tag behavior when syncing feature branches

@ricmatsui feel free to chime in if you feel like it, but no pressure :)

Looks good to me. Should there be a spec to clarify that git sync --all has the same behavior, too?

Good idea @ricmatsui. I have added feature specs that describe the behavior of git sync --all for both feature and non-feature branches. That should cover all cases. Doing so I realized that git sync --all doesn't push branches. I have filed #464 to address that separately.

all comments addressed

All comments addressed

I have implemented your recommendation of swapping NAME and LOCATION in the tags table in a separate branch: https://github.com/Originate/git-town/blob/kg-fetch-tags-reverse-order/features/git-sync/current_branch/non_feature_branch/tags.feature
Although initially liking the idea, looking at this now, I'm not too much a fan of it. The declaration of tags reads weird, and the verification of them also, kind of.
In additon, there isn't much opportunity for dry up, since there usually aren't that many tags around, and sorting the verification tables is rather complicated.
Are you okay with leaving the order as NAME and LOCATION for the tag tables?

I have implemented your recommendation of swapping NAME and LOCATION in the tags table in a separate branch: https://github.com/Originate/git-town/blob/kg-fetch-tags-reverse-order/features/git-sync/current_branch/non_feature_branch/tags.feature
Although initially liking the idea, looking at this now, I'm not too much a fan of it. The declaration of tags reads weird, and the verification of them also, kind of.
In additon, there isn't much opportunity for dry up, since there usually aren't that many tags around, and sorting the verification tables is rather complicated.
Are you okay with leaving the order as NAME and LOCATION for the tag tables?

Ping

:ship:


Do not require argument for --empty with redis-load.

This was missing the action so it was expecting an argument.

Thank you for the patch.


EndpointInfo is now Hashable/Equatable

EndpointInfo is now Hashable/Equatable so easier to compare.
Also midiPortRef optional property is added (I'm working on)
@aure can I join slack channel some times I need to ask your opinion about structural changes in AK. I don't want to develop some codes in wrong direction.

Cool, I'll merge. Please put a space after colons in the future to match AudioKit style guidelines.

Consider using v5 for development if it works for you, its slowly becoming where I want updates to go.


How to add a new episode in gym wrapper?

I understand that gym demo is a wrapper. But how can i add a new episode of my own choice to the gym wrapper demo? I have downlaoded different houses. I wanted to load them gym demo.

The gym demo loads the set of houses specified by the active --env_config configuration file.  The default value is objectgoal_suncg_sf which loads the configuration in config/envs/objectgoal_suncg_sf.py.  There, you can see the parameter scenes_file which refers to the file containing house ids to be loaded, as well as the scene_filter and episode_filter parameters which apply filtering on that file to select a subset of the houses.  If you would like to have your own set of house ids, you can change the scenes_file to point to a new file with your own house ids, and also change the lambda functions in scene_filter and episode_filter appropriately.


Test 1, DO NOT MERGE

DO NOT MERGE

https://jenkins.code.rdkcentral.com/job/github-triggered/2157/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/18228/ started.

Test complete


Router not updated before passing to getInitialProps of App

Bug report
Describe the bug
props.router.asPath of props from getInitialProps of App is lagging behind what's passed to Page or what's retrieved in withRouter
To Reproduce
Go to https://github.com/sheerun/next-reproduce-router-lagging
And run yarn dev
If you click butten the asPath from getInitialProps or App is lagging behind.
Expected behavior
Router instance passed to getInitialProps of App should be the same as in other places

We should remove router there, it has no added value there at the moment. Instead you should read from ctx, which holds immutable values. router holds the singletonrouter instance.

Hey, not so fast :) There is a use case for me: I use router.asPath and other router data to fetch appropriate data asynchronously in getInitalProps of App.

Like I said, it's only confusing people. asPath is available on ctx and it's immutable

I've updated reproduction and indeed ctx.asPath is keeping up the pace, just two comments:

I hope you'll push removing it to next.js 8 as it's breaking change. Maybe deprecate in this release
If server-side App component is supporting withRouter decorator, then why you won't opt for just fixing this behavior? It's nice to have access to router instance regardless. If for some reason it's not recommented then maybe also introduce warning when using withRouter on App

I hope you'll push removing it to next.js 8 as it's breaking change. Maybe deprecate in this release

We're not introducing breaking changes between majors.
I guess we should wrap App into a provider component for the router, I was holding off on that to implement React 16.3 context.

Just to make things clear: withRouter is currently working properly with App component

Even if you remove router from appContext it would be still good to update singleton instance
before getInitialProps of App is called, because users of Next.js can try to read from this instance in code that's running in getInitialProps of App. It's just not symmetrical that router singleton is already in good state in getInitialProps of Page, but not in getInitialProps of App..

@timneutkens Is it removed?

@sheerun not removed, but I dropped it from the docs to avoid further confusion. I've also tracked down why we even pass it along to getInitialProps, it's for getDataFromTree in the with-apollo example. So I guess we'll have to create the object one level higher than _app.js and pass it into _app.js / getInitialProps there.

Closing this because of https://github.com/zeit/next.js/issues/6537


Undefined reference to `RestClient::get(std::string const&)'

Hello,
So I installed all the files using the configure, make and make install commands.
Now when I use the example I get the following error:
Undefined reference to RestClient::get(std::string const&).
Do you have any idea how to fix this?

this looks like a duplicate of https://github.com/mrtazz/restclient-cpp/issues/55, closing this in favor of the existing issue. If it's not the same one, please reopen.

On closer inspection this is most likely not the same issue. Can you provide your platform and environment details and the output log of the failed compilation please?

i have the same problem. i used on raspberry pi

Did you install it into the default location as root? Have you run /sbin/ldconfig after installation?

I am facing a similar issue with this lib. I've got this error:
main.cpp:(.text+0x64): undefined reference to `RestClient::get(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)'
I have used this link to setup the lib:

G++ and Ubuntu version:
g++ (Ubuntu 5.4.0-6ubuntu1~16.04.2) 5.4.0 20160609

I tested the restclient using the terminal and it worked, so it seems to be just an issue with the reference. Should I have to export some global variable?

@gosantos can you provide the test program that throws this error on compilation?

@mrtazz I recompiled the lib from source and now I've got the same error:
main.cpp:(.text+0x45): undefined reference to `RestClient::get(std::string const&)'
My code is very simple:
#include "restclient-cpp/restclient.h"

int main(){

  RestClient::Response r = RestClient::get("http://ip.jsontest.com/?callback=showMyIP");

  return 0;
}

@gosantos thanks! can you also provide the command with which you compiled the test program?

@mrtazz yes, ofc. I am using g++ main.cpp -o main
Btw I have ran the command   /sbin/ldconfig and it didn't work as well;

You have to tell it to link the shared library in as well. Something like g++ main.cpp -o main -L /path/to/restclient-cpp-so/ -l librestclient -lcurl

closing this issue. Please reopen if the problem persists.

@mrtazz I'm having this issue too. i used -L /usr/local/include/restclient-cpp/  /usr/local/lib/librestclient-cpp.so  /usr/lib/x86_64-linux-gnu/libcurl.a and I'm getting
c++: warning: /usr/local/lib/librestclient-cpp.so: linker input file unused because linking not done c++: warning: /usr/lib/x86_64-linux-gnu/libcurl.a: linker input file unused because linking not done [100%] Linking CXX executable testing CMakeFiles/testing/testing.o: In function main':
/home/xxxxxx/testing.cpp:1088: undefined reference to RestClient::get(std::string const&)' collect2: error: ld returned 1 exit status
Any idea how to solve this? Been debugging all day long. Thanks!

@kiyology
iirc I think you want to do
-L /usr/local/lib -lrestclient-cpp

@mrtazz still having the same issue. after trying -L /usr/local/lib  -lrestclient-cpp -lcurl
saying undefined reference to RestClient::get(std::string const&)'` during linking.

Hi @mrtazz, I have been facing with compiling the simple code. I am getting
some.cpp:(.text+0x57): undefined reference to `RestClient::get(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)'
collect2: error: ld returned 1 exit status
To compile the code I am using : g++ -L /usr/local/lib -lrestclient-cpp -lcurl  some.cpp
Also my code looks like :
#include "restclient-cpp/restclient.h"
#include
#include
#include
#include
using namespace std;
int main() {
RestClient::Response r = RestClient::get("http://localhost:8080/get_logs/1/2");
return 0;
}
========================
For installation , I have used

git clone https://github.com/mrtazz/restclient-cpp.git
cd restclient-cpp
./autogen.sh
./configure
make install

Kindly let me know what I did wrong ? Any help would be good ! :)

do you have the headers in your include path like -I /usr/local/include?

undefined reference to RestClient::get(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
Tried installing your lib via every method I found, still doesn't work.
Header files included, include path told to the compiler; -L /usr/local/lib/ and -lrestclient-cpp passed to linker, all files ARE in that directory.
ldconfig -p shows that  ld  sees the library, and ar with objdump show that such symbols are in the file...
Even tried moving the files between usr/lb and usr/local/lib, renaming them with or without the - symbol...
I've been working on it all day, idk what else to do.
Here's what is passed to the compiler:
g++ tests/tests_all.cpp -std=c++1z -pthread -Iinclude/ -Ilibs/ -L /usr/local/lib/ -L../build -o tests/tests_all -lrestclient-cpp -lcurl -lgtest build/libao3.a

Well, sorry for the mess, figured out I should never forget there's no evil magic when working with code.
The problem was on my side, and quite common, I must say, and it was about linking order.
I use GNU Make, and my makefile has the following line:
TEST_LIBRARIES=$(LIBRARIES) $(OUT) -lgtest, where $(OUT) was the static library I made with make build and $(LIBRARIES) == -lrestclient-cpp
I got confused and for some reason didn't realize that not only the executable, but also the library in $(OUT) depended on the restclient lib. Well, I realized, but didn't pay much attention to it. So, it was all about linking order, №0 solution on StackExchange. :man_facepalming:
My bad, sorry again.
Your library is awesome :trophy: :+1:

@rakhack Thanks! Glad you found a fix :)

Anyone can help me for the following problema please
build/Debug/Cygwin-Windows/main.o: In function MinHeap<std::string>::insert(int, std::string)': /cygdrive/c/Users/nibrass/Documents/NetBeansProjects/P3_Ex1/MinHeap.h:85: undefined reference to NodeMinHeapstd::string::NodeMinHeap(NodeMinHeapstd::string const&)'
when i click on the error , it takes me to my class MinHeap in a method insert where i creat a node type of NodeMinHeap i don't know where i am getting wrong, please help me .

Sorry, I still get this error. And I have tried all methods mentioned above.
I install this lib by download deb file in https://packagecloud.io/mrtazz/restclient-cpp, and use sudo dpkg -i xxx.deb to install.
After install, i found header files in /usr/include, and so file in /usr/lib/. Then I run sudo ldconfig.
my code:
#include "restclient-cpp/restclient.h"
#include <iostream>
#include <string>

int main() {
    std::string url = "http://baidu.com";
    RestClient::Response r = RestClient::get(url);

    std::cout << r.code << "\n";
    return 0;
}

I run g++ -I /usr/include/ -L /usr/lib/ -lrestclient-cpp -lcurl test_restclient.cc to compile.
Then I get error message:
/tmp/ccCejkeS.o: In function `main':
test_restclient.cc:(.text+0x66): undefined reference to `RestClient::get(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'

I have no idea how to fix it. It make me so sad.

g++ main.cpp -o main -I /home/smartcow/restclient-cpp/include/ -L /usr/local/lib/librestclient-cpp.so -lcurl -L /usr/local/lib -lrestclient-cpp


Example code does not work as intended

The example code does not work as intended.
Steps to reproduce
Use the example code:
var express = require('express');
var proxy = require('http-proxy-middleware');

var app = express();

app.use(
  '/api',
  proxy({ target: 'http://www.example.org', changeOrigin: true })
);
app.listen(3000);

Expected behavior
This should create a proxy for /api to http://www.example.org/api. The debug output should look like this:
[HPM] Proxy created: /api  -> http://www.example.org
Actual behavior
It creates a proxy for / to http://www.example.org. The debug output looks like this:
[HPM] Proxy created: /  -> http://www.example.org
Workaround
As provided in the core concept in the README.md, move the /api from app.use() to proxy(). Like this:
app.use(
  proxy('/api', { target: 'http://www.example.org', changeOrigin: true })
);

This example works as intended, the debug output looks like this:
[HPM] Proxy created: /api  -> http://www.example.org
Setup
This happens in
<EMAIL_ADDRESS><EMAIL_ADDRESS>node v10.15.3
Windows 10 1903 (Build 18362.418).
I did not test this with other combinations yet. I hope i did not misunderstood anything. If so, feel free to tell me and close the issue :-). Thank you for this project!

I ran into the same issue... dont know when this changed honestly, but im concerned it may add overhead since it skips the express pattern matching layer... is there a good workaround?

same problem here, using the latest version of this library, used node v14.x.x and followed the example code in README. getting the same result where proxying / instead of the path I am using in app.use

+1 on this.  Is the solution provided by @caritasverein the proper one?


create two versions of bestie with different backgrounds/colors

in order to show the versions changing during upgrades and rollbacks

already exists, just need to push opdev

different image (blue background) pushed to opdev: quay.io/opdev/bestie:1.4


Make the timer text red when it gets to fewer than ten seconds

per @ssmirti, good idea Steve!

I did it!


Make defaultBaseImages configurable. Fixes #430

@coreosbot test this please

hmm .. I can't see why the tests failed there, I checked it out locally and it unit tests passed. I'll re-run. @coreosbot test this please.

I ran the tests locally this time, and they passed.
hangs head in shame
Should have done that the first time, sorry.

No worries, that happens. @coreosbot test this please.

lgtm, thanks a lot @mikebryant !


Bracket expansion not working

Apparently when running:
shell.ls('src/*.{less,js}')

Will always return an empty array, which makes me think bracket expansion is not supported yet?

This should be resolved by #275

@zanona I think this is resolved by #359. Please reopen if this is an issue.


Add links to the project structure documentation (#15)

Description

Hi, I've added links for everything below. There weren't any explicit instructions on where to link so I just linked to the documentation home for the most part. On some occasions, I would like to a specific part of the documentation (Django Migrations, Docker Containers etc.):

Docker
docker-compose
sphinx
Django
Django Rest Framework
Vue.js
Django database migrations
requirements.txt
DICOM
git-lfs
Flask
flake8

Links not added (there didn't seem to be any place to put them, advice?):

pip
pytest

Oh yea, while I was looking through it I found some minor typos so I also added those changes.
Reference to official issue

#15 - Add links to the project structure documentation
Motivation and Context

How Has This Been Tested?

I tested with make html and it built with no error. I also ran it and went through and clicked on each link.
Screenshots (if appropriate):
CLA

[x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

whoops didn't realize someone already submitted something


columns with "_" in their names are not supported

It's worth mentioning, that column names can't have any non-alphanumeric characters in their names, e.g. the underscore "_"
(as far as I understand that limitation is imposed by Search, which is supposed to create crawled/managed properties based on column names, and "_" is not allowed in property names)
A lot of people have underscores in their column names in their databases.
And the error message we get when trying to use them is very confusing. It suggest the values in the columns are incorrect, and doesn't say the column name is the problem.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b069776-85d6-8e77-db4f-061ef6e558f1
Version Independent ID: ee77b097-5c80-43f9-935a-c225740af80e
Content: Azure SQL and Microsoft SQL server Graph connector for Microsoft Search
Content Source: MicrosoftSearch/MSSQL-connector.md
Service: mssearch
GitHub Login: @mecampos
Microsoft Alias: mecampos

Thank you very much for the feedback @toskr , we'll take it into account.


adding Segwit on Litecoin to your wallets?

When will you add Segwit on Litecoin to your wallets now when it´s activated?

As far I know it's already added in Bitcoin/Altcoins chrome app. I can see my litecoins on segwit address in this app.

@briannyeko Have you had a chance to take a look at the Chrome app?

Yes, I have been using your Chrome app for over a year, but a chrome app is
not the same as a "electron app which you install independently from
chromes webstore"
On Tue, Nov 14, 2017 at 2:20 AM, Jonathan Cross<EMAIL_ADDRESS>wrote:

@briannyeko https://github.com/briannyeko Have you had a chance to take
a look at the Chrome app?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LedgerHQ/ledger-nano-s/issues/18#issuecomment-344114241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFlX23wo5I8HVGa0UmsNmTENz8HYHqyRks5s2OrUgaJpZM4NJY7S
.


stability of bootstrap 4 alpha

On the recent changes to bootstrap 4 alpha - we seem to have removed bootstrap 3 and be using bootstrap 4 alpha only.  Just questioning if there is a rollback to be included if not using bootstrap 4.  (I'm assuming that cookiecutter-django  is aimed at production ready deployment which obviously doesn't fit with the 4 alpha state).
Thanks

Hi @yunti, cookiecutter-django often explores the bleeding edge. Hence why we moved to Bootstrap 4 Alpha, and why we sometimes explore different architectural patterns. What's interesting is that the changes to our base.html were minimal and forms (powered by django-crispy-forms) continue to work. What this means is if you want to remain with Bootstrap 3, the edits to base.html are quite easy.

Thanks good to be clear on how it's used (i.e. more bleeding edge than conservative production). As you mentioned it's not much to change.  Thanks for the feedback and sorry for raising an unnecessary issue.

Hi @yunti, you would be surprised by how many conservative production minded people want us to be using bleeding edge stuff. :wink:
Also, there are no unnecessary issues. Please, don't feel constrained in asking questions or raising issues.

I can well believe it - the temptation of being on the cutting edge is too much some times.
Thanks for your comment regarding issues, I really appreciate, particularly as I’m currently finding my way round open source development etiquette.
I was curious as to why you went for the separate base,local, prod settings (and requirements) file approach rather than say django-configurations. Is either fine for best practice or does django-configurations have issues in some areas?

On 1 Sep 2015, at 16:27, Daniel Greenfeld<EMAIL_ADDRESS>wrote:
Hi @yunti https://github.com/yunti, you would be surprised by how many conservative production minded people want us to be using bleeding edge stuff.
Also, there are no unnecessary issues. Please, don't feel constrained in asking questions or raising issues.
—
Reply to this email directly or view it on GitHub https://github.com/pydanny/cookiecutter-django/issues/316#issuecomment-136760405.

Previously, django-configurations was used in this project, see tag 1.6.6, but with the release of Django 1.8, Jezdez was too busy to solve problems on non paid projects ( and I understand, because I have not figured out a way to support my family only from sunlight ), https://github.com/jezdez/django-configurations/issues/105#issuecomment-88895512 .
After that, @theskumar suggested the alternative that is being used now. This solution has simplified things, to let the settings closest to the configuration generated by django startproject and also uses an approach based on [Twelve Factor methodology] (http://12factor.net/) and because Heroku use that ...
let django-configurations, eventually solved these problems https://youtrack.jetbrains.com/issue/PY-12443 https://youtrack.jetbrains.com/issue/PY-11429 https://youtrack.jetbrains.com/issue/PY-16530
The explicit separation of test configurations, development(local) and production + environment variables prevents you inadvertently put in a git repository (or other) data that should not be easily accessible, such as passwords.
Also for this reason, it is not interesting to have, for example, django-debug-toolbar in a production environment because it may end up revealing too much information of your system, and make life easier for malicious users, and some tools used in the development environment can also decrease the performance of your site.
The Zen of Python say Explicit is better than implicit. I think this approach is sufficiently explicit, but not enough to be complicated.
Additionally, I think the practice of "explicit is better than implicit", could be used for other things besides code ... maybe life would be a little easier (or not :smile_cat: )...
I have my personal rule, always try to be cordial with people, irrespective of the level of knowledge, color, race, sexual orientation, religion ... Life is short enough and complicated enough for me to lose my precious time with useless discussions.
ps.: my english is bad, excuse me for possible failures of concordance in the text ...

To reinforce @luzfcb, one of the issues that we faced with having just one settings module was that it became huge, unwieldy. When a module gets over 1000 lines of code I get nervous on principal, so I was never quite happy with our old single settings module.
When @theskumar suggested migrating to a multiple file approach I thought about it long and hard. Finally I focused on these three lines from the Zen of Python:
Readability counts.
Special cases aren't special enough to break the rules.
Although practicality beats purity.

Conclusions:

On readability, the single module was so large it was hard to mentally parse. It wasn't readable, unless you can remember all the bits and pieces, which most of us cannot with a huge file. Which suggested that maybe we should break it up.
12 Factor insists on single settings modules and breaking this would be a special case. Which breaks the rules, right?
Practically speaking, in real world deployments the single settings module was a pain. Fortunately for us, 12 Factor is a practice, not a law. So we consciously broke the practice a little bit, in the name of practicality.

I also agree with @luzfcb, life is short. Open source etiquette in my opinion is about being cordial to one another, no matter their background (I heartily subscribe to https://www.djangoproject.com/diversity/). As long as we remain cordial we can talk plainly and openly. Let us not be afraid to ask any question, no matter how small or how large.
Glad to have you in the open source world @yunti. :smile:

I have my personal rule, always try to be cordial with people, irrespective of the level of knowledge, color, race, sexual orientation, religion ... Life is short enough and complicated enough for me to lose my precious time with useless discussions.

Absolutely, you forgot the gender. I'm sure you've already seen it, but for everyone stumbling across this you should watch the excellent talk from @olasitarska and @asendecka on EuroPython 2015 https://www.youtube.com/watch?v=DUgYznUfwyo


Fix a few issues catched by valgrind

Thanks Haihao

@dvrogozh I'm ok with proposed solution. Maybe I'd rather define also operator !=, but that is up to developer


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

1d87f1c: Remove slice(). It is not needed.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (a02f418) compared to base (1d87f1c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           37        37
  Branches        20        20
=========================================
  Hits            37        37

Flag
Coverage Δ

resolve.imports
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Avoid stack overflow when #respond_to? expectation fails

As per discussion in issue #1020.
(I slipped a spelling fix in as an extra commit...)

Thanks


Override distribution attribute type in all distutils-based commands

Summary of changes

This was already done here and there for various commands as needed as they came up from type-checking more code. Figured I may as well go ahead and make it complete.
Pull Request Checklist

[x] Changes have tests (existing type-checking tests)
[x] News fragment added in newsfragments/. (not user facing yet)
(See documentation for details)

Thank you very much!


⚠ Bofrost.de has degraded performance

In c0b777a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 931 ms

Resolved: Bofrost.de performance has improved in 1ab1c0b after 6 minutes.


Forgot password functionality

Have route and controller functionality to reset password for the user.
this should send the user to a link via email which will bring a user to a webpage then prompt the user to update password

fixed with commit f26cd92140ac43f6354111f22fa070aeaa959867


points scale linearly with difficulty or space?

Points in one partial = the currrent difficulty set for that farmer
Points over time scale linearly with space.


added method to get the ratio of the given image

https://github.com/ArthurHub/Android-Image-Cropper/issues/231

idk why the build failed did I do something wrong? :)


Make test of number work with negative numbers

Pretty sure this should fix https://issues.apache.org/jira/browse/CASSANDRA-11058

If the argument to is_number is a string representing a float, this will error out:
❯ python
>>> int('2.1')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: '2.1'

So, do you expect the input to always be represent an integer? If not, use float instead of int. If you need to address that, please do, then go ahead and squash and merge. Looks great, thank you!

do you expect the input to always be represent an integer?

Yes, that's currently what gcstats will give us, but I guess there is no harm in making it work if that ever change. I'll make the change and merge.

Great, thank you!


Fix dialyzer checks

Guess we need to wait for another test run when PRs to supervisor3 and kafka_protocol are merged.
Otherwise good to go.


Add failing test for issue #110

I'm not sure if I've chosen the right file to put it in. Also unsure about the nested interface/class pair or their naming. @fir3pho3nixx would be glad if you could review.

Thanks


Bump tekton-chains version and rearrange the application to reflect stonesoupe config (infra-deployments)

/retest


Add sut service for curl-based integration tests to test various points in ML deployment pipeline

part of larger test infrastructure.


add some microbench about collection in MasterWorkerInfo

What changes are proposed in this pull request?
recording
Why are the changes needed?
no such microbench now

@voddle are you working on this PR? or do you need any help for moving forward?

@voddle are you working on this PR? or do you need any help for moving forward?

thank for asking, it's still in progress and no help needed for the moment


Interpolation compatible + extension case insensitive

I'm making these changes so that a configuration file with interpolation could still be validated.
For instance we have the following configuration :
[formatter_form1]
format=%(asctime)s %(levelname)s [%(filename)s:%(lineno)d] %(message)s
datefmt=

Confirm will raise an interpolation syntax error and the changes made fix that.
The last change made is for file.CONF to not raise the exception "Could not load configuration file!" and to behave exactly like file.conf.
@Ronan- Could you please review the following ?

@fcharette could you add some tests to validate this behaviour? Looks good otherwise !

@louib Since we do not have the rights to update the version of confirm on Pypi's public server, it would be great if you could update it with these previous changes. =)

@louib @fcharette or ideally let Travis do the work http://5minutes.youkidea.com/howto-deploy-python-package-on-pypi-with-github-and-travis.html

@fcharette @Ronan- pushed version 0.1.3 of confirm on PyPI!

:dancer:


Command line parameters not being passed to workers in macOS

Hi, luigi community!
I am experiencing some problems when trying to pass global parameters to multiple workers. When I run a workflow using multiple workers, the command line parameter values are not being passed. I am wondering if this might be similar to the problem observed when luigi is run on Windows (https://github.com/spotify/luigi/issues/2247) but, in my case, on macOS. An additional issue is a difference in log formatting, it seems that logging.cfg is not passed to the workers.
Next toy example summarizes my problem.

import luigi
import logging

logger = logging.getLogger('luigi-interface')

class HelloConfig(luigi.Config):
    reference = luigi.Parameter(default="World")

class HelloTask(luigi.Task):
    def run(self):
        logger.info("Hello %s!", HelloConfig().reference)

    def requires(self):
        return []

I run the task calling
luigi --module weekly_update.etl.load_ex HelloTask \
      --workers ? \
      --HelloConfig-reference "Mars"

When workers is 1 the log shows
2023-04-21 10:59:09,386 - luigi-interface - INFO - [MainThread] - Hello Mars!

but when workers is 2
2023-04-21 10:59:53,030 [INFO]-load_ex.run: Hello World!

As of Python 3.8, MacOS now defaults to using spawn instead of fork, thus having issues that we previously only saw on Windows. You can change the start method using
import multiprocessing

multiprocessing.set_start_method('fork')

I'm not sure there is a better solution, and we're also struggling with command line parameters across multiple workers when not on Linux.

Thanks so much! @hypostulate. Your solution worked like a charm. I had lost all my hope on this issue. In case you had the time to reply, I asked the same question in StackOverflow (https://stackoverflow.com/questions/76081135/luigi-workflow-engine-command-line-parameters-not-being-passed-to-workers-in-mac).


Filter articles for locale

There seems to be no activated? method, unfortunately, to check whether an extension is enabled
or not.
It there another way to check whether multi-language support is enabled ?

Simply testing the existence of @app.extensions[:i18n] should work, I think. If not, I'll add an API for this.

I kind of think this should happen in your code, though. Rather that ours. The specifics of how people want to paginate are too hard to predict.
helpers do
  def current_locale_articles
    return blog.articles unless @app.extensions[:i18n]

    blog.articles.select do |article|
      article.lang == ::I18n.locale
    end
  end
end

@tdreyno: Unfortunately using a helper won't work with pagination, as the paginator will count and
paginate all articles, and not per locale.
I think that users usually want to paginate like this. I can't see why one would have articles of all languages on a single page when all the other content (non-blog stuff) is separated per language ?

How about passing a proc as an extension option that allows pre-filtering articles before
they are passed to the paginator ?

I think a proc is a very good idea.

Ok, I'll send you PR with a proper implementation and close this.

Wonderful, thanks so much @furunkel

Ah, I forgot; what would be a good name for the option, article_filter ?

Coverage decreased (-0.3%) to 97.307% when pulling 93c10b8846e2ad992f37e317b2c471f1a2b7b108 on furunkel:locale_articles into 0f7beabdb8837fc8366c9a95d0ce7731bcc9d1ff on middleman:master.


Removal of TxTransitionId table

Describe the feature
@onbjerg already noticed that having a full Table of Tx->TransitionId seems like a waste as transaction and transition ids are mostly "same" as in incremental.
I am writing this so as to not forget it.
Current tables:
Transitions: TransitionId -> Changeset
BlockTransitionId: BlockNumber -> TransitionId
TxTransitionId: TxNumber -> TransitionId

What we can do is use BlockBody to get to transition count and then tx Transition would be BLockTransitionId+count.
This would remove a needs or TxTransitionId table but would require TransactionBlock table that can be reused for other things.
Just idea for now, seems possible
Additional context
No response

very nicely works with: #1699

Closing this as I don't think it's relevant anymore? Let me know though cc @rakita


Making some adjustments

Alright, this should be the definitive working version of what I had made before, with Preload NP. The name can always change, I still don't like it.
Starting off, this is only confirmed working in both JP and EN servers, in all aspects I'm about to list. To get it working in the other regions, I'll need screenshots of the servers in question in these screens:
Support screen
Withdraw screen (on failed mission where you choose to withdraw, spend Saint Quartz [Stones], or use Command Seals
Connection Failed screen
With these 3 screenshots from TW and CN servers, I can make it function 100%.
So to list the new features.
Firstly, Preload NP is working and is better than before! Before it would spring up toast messages about being unable to read cards, but now that is no longer an issue! The cards are all being read and cached in a list locally within card.lua, which is then reset to a clear list after battle.lua finished performBattle. I have adjusted a bit in card.lua to make this work, but essentially there are 2 new functions, readCommandCards and resetCommandCards. readCommandCards stores the array locally, and which can be called by battle.lua. Thinking back, I believe this is possible to do without adding this function, but I didn't want to damage anything that wasn't broken, so this option was the safer choice. Then with resetCommandCards, the list of command cards stored is reset to a blank list, and then "cardsClickedSoFar" is reset to 0. cardsClickedSoFar is a new variable added for the PreloadNP feature, which keeps track of how many cards have been clicked. In the clickCommandCards function, this value is checked to ensure any cards that are already clicked are not clicked again.
There is a small added portion within clickCommandCards that I have that is the beginning of my attempts to get chaining to work. This has no influence on how things work now, so it can be ignored. I made sure the file would work regardless of updated config files. These changes can be found in the battle.lua in the init function, where it checks if "chains" is nil (which would be in the config file) and sets chaining to false if it is the case. Thus, nothing changes in regards to the function of the script.
A change to Support, I changed the scrolling method from the manualTouch option to swipe. This adjustment was made in order to increase the speed of scrolling. The swipe can be adjusted as needed for those that wish to, but I made it small enough that slower devices should still be able to use it without issues. This can be adjusted as we get feedback. The location of the change to occur from feedback is line 168 and 169 of support.lua. 169 is the wait time to wait for scrolling to finish, and 168 is how fast it scrolls. Smaller is faster for line 168. If people find the scrolling to skip servants, increase this number. If people find that it starts scrolling again before it finishes the movements, increase the wait time on 169.
The new features Withdraw and Retry are working on JP and EN servers! I acquired the necessary screenshots in order to crop the buttons needed for these features to work. The Retry feature works on both, and Withdraw has at least been tested on EN servers (haven't tried it on JP. Please give some feedback on whether it works or not!) To test it, or acquire screenshots, simple enter one of the Fuyuki quests (I did the last one for 7 Stamina/AP) with lvl 1 servants. A level 40 Mashu will be able to clear the quest, so if you don't want to waste the Stamina/AP, choose a lower level support. Fail the quest, and take a screenshot where it says "Withdraw" as an option.
One thing to note, and I took this into consideration when writing this feature in, based on what is available, the "Withdraw" button will move. There can be from 1 to 3 buttons available. If you don't have 3 Command Seals, or no Saint Quartz (Stones) then it'll be decreased by 1 or 2 if both are unavailable. To compensate for this, I adjusted the method of choosing the click location.
If you take a look at the regular.lua file, you'll see on line 26 a new field: MatchClick. This is to utilize an optional clicking method that we haven't been using in the script up to this point. It is used in both Retry function and Withdraw function located on lines 72 and 83 respectively. MatchClick, in their Validator functions, gets set to the returned value of the region:exists function in each of the Validator functions. This is then used as the click location in the respective Actor functions. Afterwards, this field is set to nil to prevent false positive clicking. If MatchClick is set to nil, and the function attempts to click the nil value, the script will crash. This shouldn't happen, as I should've been successful in keeping such a thing from occurring, but in the case that it does, we'll need to double check the functions associated with MatchClick (only Withdraw and Retry for now).
Now, Retry is a feature many have been asking for. It reads the menu in which states that connection couldn't be established or was lost. And then proceeds to click the button to retry to connect. I have done what I could to account for all instances where this occurs and my best option was to list it with the Validators and Actors loop. In this way, it'll be checked on every iteration of the loop and should account for most cases where it occurs. Note that this has to be the FIRST Validator/Actor option, otherwise it'll read the other menus first and fail to recognize it has lost connection (this gave me a huge headache to figure out by the way).
Now there was at least one instance where this didn't account for connection problems to occur, which was updated friends list on support selection. Because the support selection is a closed loop, once it enters it, it won't leave until a support is selected. Thus, it'll never re-enter the Validator loop and never see that Retrying was needed. This wasn't necessarily a problem though, as in the process of pressing the update button, it would end up clicking the retry button anyways. However, this could still cause problems in certain instances, thus I came up with a solution. Said solution was a loop within the selectPreferred loop located on line 152 of support.lua. This loop will check if Retry is needed and then click Retry when it sees it. Then loop again and again as necessary (some connection issues can span for minutes if you are in a bad area). At least on my own device, the wait time located on line 75 of regular.lua was more than plenty between Retry attempts.
If you guys have any feedback and suggestions, feel free. I'll implement any changes that are needed as soon as I have time. Alternatively, feel free to make any changes yourself if you think it is simple enough.

Also! Forgot to mention this, but I also resolved the issue in regards to the "support_region_tool" not working as initially intended! I just remembered this when clearing up the conflicts listed for the merge. Essentially changed the tool from the quick card to the "confirm support setup" button. This required a small adjustment to the offset from 156 to 114 due to the location of the button. This also resulted in a changed to the Region used for the region anchor. Because of this change, there should be no conflicts resulting in having Command Codes applied to support servants!

Hmmm, okay. So I'll go in order here.
My bad on the duplicate. I didn't realize that that was there XD
The delay is for NP Animation. 25 seconds is about average NP duration length. I specifically made it so that it wouldn't hit this length if an NP wasn't touched. It also only accounts for 1 NP animation. But basically this delay allows the pone to not be constantly searching for images, which can save on battery life and causes less lag. I can't 100% confirm it either, but I also think it lowers the rate which Accessibility issues arise too.
I tested the retry function in Support menu and it worked fine for me though.... Not sure what the problem is on that? I might have to take another look. Otherwise, just making it a global as you mentioned, or writing a duplicate in the module itself. Both should work.
I really wish Swipe worked more globally.... I've seen people have issues with Manual Touch though too so I'm not sure what to do about this. Swipe is definitely faster between the two though.

 I didn't test it after making the change. Sorry!

Next time I would recommend squashing the commits into 1 so master isn't flooded with commits like "Reverting X", "Fixing X", "Restore accidentally deleted..." like it's the case here.
There should be a squash button on every open Pull Request, here's some info https://github.blog/2016-04-01-squash-your-commits/

Thanks for this. I've only worked on a few projects that revolve around Git so I never had the chance to learn about this. Glad I know it now, it'll be nice for future pull requests!

It was more directed towards @potchy in this case, the one merging the Pull Request has to use that button.

Yeah, I didn't realize that until after I read the link you posted (commented before checking it). But still appreciate it myself as well. It'll be useful for future projects.

There's also an option to only allow Squash Merges in the repository settings, only @29988122 can do that. The option can be found in https://github.com/reconman/Fate-Grand-Order_Lua/settings under "Merge Button".
@29988122 Could you deactivate "Allow rebase merging" and "Allow merge commits"? Then every Pull Request only produces a single commit where the merger has to choose the combined commit message. That's how we do it in the company project and it works really well.

I appreciate your concern, but it was a conscious choice. I usually rebase to maintain a linear history, but since there were many commits this time around, I thought it was a good idea to group everything together. It's possible to compare merge commits as a whole anyway. In retrospect, this PR's original messages had a lot of "fixed this", "fixed that", "oops", so I agree a squash would have been better. 🤔


docs(install): add termux section

This PR updates the docs.md to include a section for Termux.
H/T to @GNUxeava for providing excellent reproduction steps in #2758 which led to this doc addition.
Related:

#2758
#2749
#2768

Nice catch! Fixed and pushed up


Add support for patterns in path params

shelf_router supports defining path parameters with <paramName|REGEXP>, where REGEXP is a regular expression (leaving out ^ and $).
OpenAPI spec also supports patterns for String types.
This PR adds support for converting path parameters with patterns in the OpenAPI spec to shelf_router path parameters.
For example:
paths:
  /proxy/{endpoint}:
    parameters:
      - in: path
        name: endpoint
        schema:
          type: string
          pattern: '^.*$'
        required: true
    post:
      ...

will be converted to:
router.post('/proxy/<endpoint|.*>', (Request request, String endpoint) async {...}

which will match any path that starts with /proxy/ and will pass the rest of the path as endpoint parameter.
cc @walsha2

New release (v0.5.5): https://pub.dev/packages/openapi_spec


Take asset checkbox before generating threat suggestions

When we put the assets and data flows into the diagram, we are allowed to set  a few checkboxes. If we ask the application to generate threat suggestions, it does not take them into consideration, thus suggesting a "Tampering" threat to a data flow that has been marked as "encrypted" in one of its checkboxes.

Issue #187 and pull request #310 satisfy this issue - so closing


Added optionally gzipped recipes

Codecov Report

Merging #667 into master will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   81.39%   81.13%   -0.27%
==========================================
  Files         114      114
  Lines        3870     3874       +4
  Branches       95       95
==========================================
- Hits         3150     3143       -7
- Misses        720      731      +11

Impacted Files
Coverage Δ

...main/scala/com/ing/bakery/baker/RecipeLoader.scala
79.16% <100.00%> (+4.16%)
:arrow_up:

...e/akka/actor/process_index/ProcessIndexProto.scala
94.05% <0.00%> (-5.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4eff39...c3ed16f. Read the comment docs.


How to handle Array responses?

Howdy.  I'm using this library to connect to an XML-RPC service that returns an array -- such as a list of records that match a query.  But, I'm running in to a number of errors.  Unless I'm mistaken, gorilla-xmlrpc can't handle an array response, at least not as the root level result.
Unfortunately, I'm not in control of the remote XML-RPC server, so I can't just wrap the responses into a struct.  So, I really need to figure out how to make this work.
I'm not sure if this project is active or not, so I'm digging in to see if I can decipher how it's working.  If you have any suggestions, or even patches to make this go, please pass them on!

Go figure.. you spend hours on a proble, but as soon as you post a question publicly, then you figure out the answer.  I'm posting my answer here for anyone else who has the same trouble.
Similar to functions in Go, XML-RPC can return several results for one RPC call.  So, the top-level result is ALWAYS a struct.  This means if your API returns an array of results, then you need to wrap that array in a struct with a single element.  Then the RPC call will work as expected.

Hi Ben. Would you care to share how to achieved this? I am very new to Go and would appreciate any help. My response I want to unmarshal is an array with int, string,int. I also have responses which have arrays in the array.
For the first instance, my response array is of the format value/array/data/values in the xml tree, which I think is standard for arrays? anyway my method at the moment is;
func XmlRpcCall(method string, args struct {
Who  string
What string
Why  string
}) (reply struct {
Arra struct {
Code   int
Msg    string
Number int
}
}, err error)
And when outputting this (still in the example codes format)
log.Printf("Response: %d %s |%1d| \n", reply.Arra.Code, reply.Arra.Msg, reply.Arra.Number)
It will compile, and looking at the response method on Wireshark shows the response I am looking for, but I get the error
panic: reflect.MakeSlice of non-slice type
Any help would be great thank you!


Rework KIC version compatibility into a template sourced from YAML

Description
Sources KIC version compatibility with a table similar to gateway's https://docs.konghq.com/gateway/3.3.x/support/third-party/ page, but simpler.
Editing the current raw Markdown table is painful, and we'll soon run out of old versions we can discard (which makes it less painful) without omitting some of the versions covered by the single source page.
Making the page a loop over versions to avoid creating the navtab block for each, but I'm not sure it's doable in a way that gets you both versions with dots (for display) and versions without (for referencing data, where . has a special syntax meaning). Dunno if Liquid is fancy enough to support variables in include directives; probably not.
Changes the current exhaustive version lists to ranges. We have never had a non-contiguous list of supported versions and likely never will, so there's no clear need to list all the intermediate versions.
Testing instructions
https://deploy-preview-5924--kongdocs.netlify.app/kubernetes-ingress-controller/latest/references/version-nuevo/ temporary home pending a rebase and move once the 2.11 docs are merged.
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

I took a look at this as I love the idea of these pages being data driven, but I don't think we can get the same look and feel.
I had a go at formatting without the version tabs so that everything's shown on a single page per KIC version, but it didn't work out (and I forgot to commit 🤦 )
On balance, I think the cross/check UI is better for consumers even if it's more painful for us to maintain. If maintenance is too painful, we should look at investing in tooling to generate the same view from data
Current

Travis

I didn't lose it! I just did in on #5989
Moving my above comment there and closing this PR as if we move forward we want the most automation


feat: Improve OpenAPITool error handling/reporting

Why:
Enhances the error handling in the OpenAPITool component for improved usability.
What:

Introduces the JSONDecodeError exception to handle invalid function invocation JSON payloads gracefully.
Modifies the run method to return a service_error containing the error message and the invalid JSON payload when a JSONDecodeError is encountered.

How can it be used:

With the enhanced error handling, the OpenAPITool now provides more descriptive error messages and improves the overall user experience.

How did you test it:

Added unit tests to cover the new error handling scenarios.
Tested the implementation with Mock objects to simulate the cases of "no such operation" and "invalid JSON payload."

Notes for the reviewer:

Please review the changes made to the openapi_tool.py and test_openapi_tool.py files.
Pay special attention to the new error handling logic in the run method and the new tests in the test suite.
Consider checking the overall impact of these changes, ensuring they address the original issue and provide a more robust OpenAPITool implementation.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

36 of 36 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 90.419%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
1727

Relevant Lines:
1910

💛  - Coveralls

Closing, will investigate later


Streaming extraction

WIP, experimental

Current commands to test
Run extraction with verbose logging and time measurement
time poetry run python -m explorer.extract --target-flake-ref github:tweag/nickel --verbose --n-workers 8 nodes.json

In the meantime, you can monitor in other consoles (e.g. using tmux) a few metrics
# count of lines in output file
watch wc -l nodes.json
# output file size
watch du -h nodes.json
# last output line
watch tail -1 nodes.json

Get extracted output paths
cat nodes.json | grep --text --regex '^\{' | jq -rR '. as $line | try (fromjson | .outputPath)' > output-paths.txt

Unfortunately, some lines in the output file are garbage.
Maybe because of some concurrence writing to file? I thought the Python GIL was taking care of that. 🤷♂

Todo: use MutEx lock to prevent race conditions on output write

The queue processor seem to end before everything is actually processed, even though the stopping condition looks good to me. Needs investigation.

Stopping condition looks good, but evaluation of some attribute paths is not working. Example:
NIXPKGS_ALLOW_UNFREE=1 NIXPKGS_ALLOW_BROKEN=1 NIXPKGS_ALLOW_INSECURE=1 TARGET_FLAKE_REF="github:tweag/nickel" TARGET_SYSTEM="x86_64-linux" TARGET_ATTRIBUTE_PATH="vscodeExtension.vsix.buildInputs.3.buildInputs.5.nativeBuildInputs.5.nativeBuildInputs.2.nativeBuildInputs.1.nativeBuildInputs.0.propagatedBuildInputs.0.nativeBuildInputs.2" nix eval --json --file ./explorer/extract/describe-derivation.nix

After c146821 I can test extraction using
./core $ poetry run python -m explorer.extract --target-flake-ref "path:$(realpath ./fixtures/flake-trivial/)" --n-workers 1 -
{"attribute_path": "default.out", "derivation_path": "/nix/store/5r3q2vgy3951hf8vxg711zl3z2ij3fdp-trivial-1.0.drv", "output_path": "/nix/store/ys4vhl5izaahsx7mwiblsbbrlcw03w83-trivial-1.0", "output_paths": [{"name": "out", "path": "/nix/store/ys4vhl5izaahsx7mwiblsbbrlcw03w83-trivial-1.0"}], "name": "trivial-1.0", "parsed_name": {"name": "trivial", "version": "1.0"}, "nixpkgs_metadata": {"pname": "False", "version": "", "broken": false, "license": ""}, "build_inputs": []}

I think the test breakage in the CI is due to changes in the core model.
TODO

[ ] fix tests
[ ] add tests

Using a mutex lock on output fixes the racing condition, but I feel it slows the throughput down a bit. I have no data to claim that though, and the correctness is more important (plus the performance is still ok).

I approved, because I only considered the content in the new cli.py file after :arrow_right: START REVIEW HERE :arrow_right:
But I think cli.py would benefit from:

more comments
some architectural comments
sharing parameters that are common to multiple functions to a helper object

I suppose that, once we do that, possibly some simplifications would become easier to spot.


MenuBar sub-menu Arrow not showing

Menubar is not Showing sub-menu Arrow

In Flex it was Showing sub-menu Arrow

This might be a good task for you to try to fix yourself.  The menu is made up of renderers and the renderers can be taught to display the expand icon or graphic (or even just a ">")

This should be ok now.


Updates to TP2000 199

Why
The reference price field on the conditions step of the MeasureCreateWizard needs to be able to handle simple duties (e.g. "3%" or "11 GBP / 100 kg").
What

Adds custom clean() method to MeasureConditionsForm, using DutySentenceParser to validate input and pass duty_amount, monetary_unit, and condition_measurement to the measure creation view
Adds form tests and updates view tests
Updates view test to handle last step of MeasureCreateWizard
Update duty_help.jinja examples to use valid duty sentences

Codecov Report

Merging #517 (b44e0e2) into master (7783e00) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   92.64%   92.73%   +0.08%
==========================================
  Files         299      299
  Lines       18541    18578      +37
  Branches     1475     1478       +3
==========================================
+ Hits        17178    17228      +50
+ Misses       1086     1078       -8
+ Partials      277      272       -5

Impacted Files
Coverage Δ

measures/views.py
93.87% <ø> (+2.55%)
:arrow_up:

measures/forms.py
90.56% <100.00%> (+1.49%)
:arrow_up:

measures/tests/conftest.py
91.72% <100.00%> (+0.12%)
:arrow_up:

measures/tests/test_forms.py
100.00% <100.00%> (ø)

measures/tests/test_views.py
100.00% <100.00%> (ø)

geo_areas/models.py
96.34% <0.00%> (+1.21%)
:arrow_up:

importer/taric.py
82.66% <0.00%> (+1.33%)
:arrow_up:

geo_areas/forms.py
83.87% <0.00%> (+4.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7783e00...b44e0e2. Read the comment docs.


While running Detox, the tests just hang.

React-Native: 0.61.5
Detox: 16.7.2
Jest:24.9.0
Logs after following this guide (https://github.com/wix/Detox/blob/master/docs/Guide.DebuggingInXcode.md):
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
  * frame #0: 0x00007fff23bd5a3a CoreFoundation`_CFRelease + 186
    frame #1: 0x00007fff23bce337 CoreFoundation`__CFRunLoopDoObservers + 487
    frame #2: 0x00007fff23bce97a CoreFoundation`__CFRunLoopRun + 1514
    frame #3: 0x00007fff23bce066 CoreFoundation`CFRunLoopRunSpecific + 438
    frame #4: 0x000000010207ba6a EarlGrey`-[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:](self=0x0000600002a524f0, _cmd="grey_drainRunLoopInActiveModeAndCheckCondition:forTime:", stopConditionBlock=0x00000001020c9560, time=1.7976931348623157E+308) at GREYRunLoopSpinner.m:175:31
    frame #5: 0x000000010207b435 EarlGrey`-[GREYRunLoopSpinner spinWithStopConditionBlock:](self=0x0000600002a524f0, _cmd="spinWithStopConditionBlock:", stopConditionBlock=0x00000001020c9560) at GREYRunLoopSpinner.m:58:26
    frame #6: 0x00000001020c8cba EarlGrey`-[GREYUIThreadExecutor executeSyncWithTimeout:block:error:](self=0x000060000252c300, _cmd="executeSyncWithTimeout:block:error:", seconds=1.7976931348623157E+308, execBlock=0x000000010209aec0, error=0x00007ffeef3274d0) at GREYUIThreadExecutor.m:227:22
    frame #7: 0x000000010209a3d1 EarlGrey`-[GREYElementInteraction assert:error:](self=0x0000600003b10a00, _cmd="assert:error:", assertion=0x00006000025db840, errorOrNil=0x0000000000000000) at GREYElementInteraction.m:436:9
    frame #8: 0x000000010209bd4d EarlGrey`-[GREYElementInteraction assertWithMatcher:error:](self=0x0000600003b10a00, _cmd="assertWithMatcher:error:", matcher=0x00006000025db820, errorOrNil=0x0000000000000000) at GREYElementInteraction.m:481:10
    frame #9: 0x000000010209bc7e EarlGrey`-[GREYElementInteraction assertWithMatcher:](self=0x0000600003b10a00, _cmd="assertWithMatcher:", matcher=0x00006000025db820) at GREYElementInteraction.m:476:10
    frame #10: 0x00007fff23c7820c CoreFoundation`__invoking___ + 140
    frame #11: 0x00007fff23c753af CoreFoundation`-[NSInvocation invoke] + 319
    frame #12: 0x0000000101f1833f Detox`+[DTXMethodInvocation invoke:onError:](self=DTXMethodInvocation, _cmd="invoke:onError:", params=3 key/value pairs, onError=0x0000000101f10f60) at DTXMethodInvocation.m:246:2
    frame #13: 0x0000000101f10bcc Detox`__35-[TestRunner invoke:withMessageId:]_block_invoke(.block_descriptor=0x0000600003b10ec0) at TestRunner.m:71:12
    frame #14: 0x00007fff23bd429c CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
    frame #15: 0x00007fff23bd3a08 CoreFoundation`__CFRunLoopDoBlocks + 312
    frame #16: 0x00007fff23bcee1b CoreFoundation`__CFRunLoopRun + 2699
    frame #17: 0x00007fff23bce066 CoreFoundation`CFRunLoopRunSpecific + 438
    frame #18: 0x000000010207ba6a EarlGrey`-[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:](self=0x0000600002b84240, _cmd="grey_drainRunLoopInActiveModeAndCheckCondition:forTime:", stopConditionBlock=0x00000001020c9560, time=1.7976931348623157E+308) at GREYRunLoopSpinner.m:175:31
    frame #19: 0x000000010207b435 EarlGrey`-[GREYRunLoopSpinner spinWithStopConditionBlock:](self=0x0000600002b84240, _cmd="spinWithStopConditionBlock:", stopConditionBlock=0x00000001020c9560) at GREYRunLoopSpinner.m:58:26
    frame #20: 0x00000001020c8cba EarlGrey`-[GREYUIThreadExecutor executeSyncWithTimeout:block:error:](self=0x000060000252c300, _cmd="executeSyncWithTimeout:block:error:", seconds=1.7976931348623157E+308, execBlock=0x0000000101f09f70, error=0x0000000000000000) at GREYUIThreadExecutor.m:227:22
    frame #21: 0x00000001020c8783 EarlGrey`-[GREYUIThreadExecutor executeSync:error:](self=0x000060000252c300, _cmd="executeSync:error:", execBlock=0x0000000101f09f70, error=0x0000000000000000) at GREYUIThreadExecutor.m:198:10
    frame #22: 0x0000000101f09f46 Detox`__45-[EarlGreyImpl(.block_descriptor=0x0000600002b4c210) detox_safeExecuteSync:]_block_invoke at EarlGrey+Detox.m:17:3
    frame #23: 0x00007fff23bd429c CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
    frame #24: 0x00007fff23bd3a08 CoreFoundation`__CFRunLoopDoBlocks + 312
    frame #25: 0x00007fff23bce894 CoreFoundation`__CFRunLoopRun + 1284
    frame #26: 0x00007fff23bce066 CoreFoundation`CFRunLoopRunSpecific + 438
    frame #27: 0x00007fff384c0bb0 GraphicsServices`GSEventRunModal + 65
    frame #28: 0x0000000101f0f8da Detox`__detox_UIApplication_run(self=0x00007fb6f0100900, _cmd="_run") at ReactNativeSupport.m:143:9
    frame #29: 0x00007fff48092d4d UIKitCore`UIApplicationMain + 1621
    frame #30: 0x00000001008d6930 DetoxTestApp`main(argc=1, argv=0x00007ffeef329c80) at main.m:14:12
    frame #31: 0x00007fff5227ec25 libdyld.dylib`start + 1
(lldb)

Terminal logs after running tests:
detox[17781] DEBUG: [DetoxServer.js/CANNOT_FORWARD] role=testee not connected, cannot fw action (sessionId=7f3c526f-ba61-1c9e-8937-d08d09665fba)
detox[17781] DEBUG: [DetoxServer.js/LOGIN] role=testee, sessionId=7f3c526f-ba61-1c9e-8937-d08d09665fba
detox[17781] DEBUG: [DetoxServer.js/LOGIN_SUCCESS] role=testee, sessionId=7f3c526f-ba61-1c9e-8937-d08d09665fba
detox[17781] INFO:  <Login />: should expect email input
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.facebook.react.ShadowQueue
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.facebook.react.ShadowQueue
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync WXRunLoopIdlingResource: React Native thread is busy.
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.facebook.react.ShadowQueue
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync WXRunLoopIdlingResource: React Native thread is busy.
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  [actions.js] Sync JavaScript Timers: Javascript Timers
detox[17781] INFO:  [actions.js] Sync Dispatch Queue: com.apple.main-thread
detox[17781] INFO:  <Login />: should expect email input [FAIL]

detox[17781] WARN:  [Client.js/PENDING_REQUESTS] App has not responded to the network requests below:
  (id = 1) invoke: {"target":{"type":"Invocation","value":{"target":{"type":"EarlGrey","value":"instance"},"method":"detox_selectElementWithMatcher:","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"GREYMatchers"},"method":"matcherForAccessibilityID:","args":[{"type":"NSString","value":"email-input"}]}}]}},"method":"assertWithMatcher:","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"GREYMatchers"},"method":"matcherForSufficientlyVisible","args":[]}}]}
  (id = -1000) isReady: {}

That might be the reason why the test "<Login /> should expect email input" has timed out.

detox[17781] DEBUG: [DetoxServer.js/DISCONNECT] role=tester, sessionId=7f3c526f-ba61-1c9e-8937-d08d09665fba
detox[17781] DEBUG: [DetoxServer.js/DISCONNECT] role=testee, sessionId=7f3c526f-ba61-1c9e-8937-d08d09665fba
detox[17781] DEBUG: [DetoxServer.js/CANNOT_FORWARD] role=tester not connected, cannot fw action (sessionId=7f3c526f-ba61-1c9e-8937-d08d09665fba)
detox[17781] DEBUG: [DetoxServer.js/WS_CLOSE] Detox server connections terminated gracefully
 FAIL  e2e/screen-navigation.test.js (121.37s)
  <Login />
    ✕ should expect email input (60018ms)

  ● <Login /> › should expect email input

    Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.

      at mapper (../node_modules/jest-jasmine2/build/queueRunner.js:25:45)

  ● <Login /> › should expect email input

    : Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 60000ms timeout specified by jest.setTimeout.Error:

      12 |   // });
      13 |
    > 14 |   it('should expect email input', async () => {
         |   ^
      15 |     await expect(element(by.id('email-input'))).toBeVisible();
      16 |   });
      17 |

      at new Spec (../node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Suite.<anonymous> (screen-navigation.test.js:14:3)
      at Object.<anonymous> (screen-navigation.test.js:2:1)

detox[17778] ERROR: [cli.js] Error: Command failed: node_modules/.bin/jest --config e2e/config.json '--testNamePattern=^((?!:android:).)*$' --maxWorkers 1 e2e

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

My init.js:
const detox = require('detox');
const config = require('../package.json').detox;
const adapter = require('detox/runners/jest/adapter');
const specReporter = require('detox/runners/jest/specReporter');

// Set the default timeout
jest.setTimeout(60 * 1000);

jasmine.getEnv().addReporter(adapter);

// This takes care of generating status logs on a per-spec basis. By default, jest only reports at file-level.
// This is strictly optional.
jasmine.getEnv().addReporter(specReporter);

beforeAll(async () => {
  console.log('**********INITSTART'); // --------------> this is logged
  await detox.init(config, { launchApp: false });
  console.log('**********INITDONE'); // --------------> this is logged
  await device.launchApp({
    newInstance: true,
    launchArgs: {
      detoxPrintBusyIdleResources: 'YES',
    },
  });
  console.log('**********LAUNCHED'); // ------------> this is not logged
});

beforeEach(async () => {
  await adapter.beforeEach();
});

afterAll(async () => {
  await adapter.afterAll();
  await detox.cleanup();
});

The console.log after device.launchApp is not logged. Not sure if there is any issue in launching the app.
Where could the issue be? I have tried many combinations, disabling synchronizations, etc etc but to no avail.
PS. I can see the app being launched in the simulator and I can interact with it.

I found something if it can provide some clues. I am using react-navigation for my project. If I don't render the Navigator and just render the Normal react component(say <Login />) then everything works fine(console.log('**********LAUNCHED') after device.launchApp logs to the terminal). But If I render Navigator then console.log('**********LAUNCHED') doesn't logs to the terminal and the above-pasted logs are printed.

@LeoNatan I have posted this on StackOverflow https://stackoverflow.com/questions/62690718/detox-tests-hangs-when-using-react-navigation

This issue seems to be caused due to react-navigation and has raised it here react-navigation/react-navigation#8533. Maybe react-navigation guys have any idea what could be the cause.

Hi, could you solve this? Having the same problem here.


Feat/stellar more tokens

📝 Description
Adding new Stellar tokens and a small bug fix in reserved balance calculation
❓ Context

Impacted projects: ledgerjs, ledger-live-common
Linked resource(s): ``

✅ Checklist

[ ] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Hi @quietbits,
Thank you for your contribution.
Could you have a look on the tests that are not passing the CI and add changeset (with pnpm changeset).
Best regards.

@aelmilligy-ledger thanks for taking look at this PR! What updates should I run to make all the tests happy with new tokens (looks like this might be the issue)? I used to run pnpm common jest sortByMarketcap -u but it doesn't work anymore. :pray:


Improve some Haddock in BlockFetch

Updated some stale Haddock references. Improved wording and added details to FetchDecline Haddock.

Status update: I think this PR is ready for merge, once it gets an Approval.

Thanks @amesgen & @nfrisby :)
bors merge