update isBrave / isBraveMode

been like a year+ since we looked at this
https://github.com/arkenfox/TZP/commit/521ab0e57f5e2ed96e712611d271ce3051499967
this is now dependent on the shield mode
fileSystemAccessDisabled: !windowKeys.filter(key => fileSystemKeys.test(key)).length

so far nothing seems broken after my patch
things I/we can do

[x] note: in the isBrave checks, if we determine isBrave = true but the primary check braveInNavigator = false, I add this as a lie: not strictly necessary for entropy, since it will be reflected in the navigator keys array - but it's something people like to mess with and I like pointing out how stupid that is: hence why I check for all true but primary

scrapped: this is already reported as a lie in navigator keys if missing, we do not need to worry about hasPrimary - keep it simple

[x] determine isBrave better

we don't need to use hashes
allow some flexibility

[x] alert when isBrave but we have false results

an alert clickable link is shown top left when there are alerts, and they are added to the perf/debug details
special alerts like this one I also add output to console.error,
this is the only way for me to auto pick up when Brave changes something

[ ] update/check our checklist for both isBrave and isBraveMode

e.g standard/strict now returns navigator.keyboard as null (which is very unusual)
e.g isBrave is now down to six items: is this enough

@abrahamjuliot where are we at with all this?

https://github.com/arkenfox/TZP/commit/4703db07c721a2518b844ff71f7bce262fe30419

OT: https://mm.icann.org/pipermail/tz-announce/2022-September/000073.html (from https://bugzilla.mozilla.org/show_bug.cgi?id=1797248 ... these tzdata updates aren't useful for entropy (usually), they always get backported to ESR and we can already detect versions and engines)

Simplify three Ukraine zones to one, since the post-1970 differences seem to have been imaginary.

since post-1970 ? .... holy cow ... so 50'ish years then ...

MOAR OT timey stuff

https://news.ycombinator.com/item?id=33316941
https://www.howderfamily.com/blog/australias-weird-little-time-zone/

a comment on the article mentions Broken Hill as also having a weird anachronism
Anyway, Australian Central Western Standard Time (ACWST) which is what that article about is Australia/Eucla and yes, there is an Australia/Broken_Hill - both have unique timezone at https://arkenfox.github.io/TZP/tests/timezones.html
Australia/Broken_Hill

    8bc44a2ea49ad4cfd14a4943430a5a692717247d
    1879: -124.2, -124.2
    1921: -120, -120
    1952: -150, -150
    1976: -150, -150
    2018: -150, -150

Australia/Eucla

    37b22fa093e15c5e236caa7d37730509c274e979
    1879: -174.53333333333333, -174.53333333333333
    1921: -165, -165
    1952: -195, -195
    1976: -255, -195
    2018: -255, -195

and here's Nepal showing 45mins (as mentioned in the article) - i.e minus 6hr, 15 minutes
Asia/Kathmandu

    117dd3a545aebb630f62b085604202af6f9107c2
    1879: -348.73333333333335, -348.73333333333335
    1921: -360, -360
    1952: -390, -390
    1976: -450, -390
    2018: -435, -375

@abrahamjuliot where are we at with all this?

Brave has a new Screen farbling available in Nightly by enabling brave://flags/#brave-block-screen-fingerprinting.
as far as I know:

does not change the visual viewport resolution
binds the screen resolution to the window outer resolution

way to bypass:

if brave + mobile, use the viewport resolution
if brave + desktop, distrust the screen resolution if no taskbar is available

method to restore (slow):

create an iframe with a 0x0 viewport (this can work with any preset resolution)
render the iframe on the page and get the screen resolution to obtain the offset values
subtract the offset values from the corresponding root window screen resolution values

There's also a font randomization, but it can be bypassed using document.fonts.check('12px Consolas'), for example.

yup, I know about the screen: not read it yet. It was mention by Arthur is test news 35 - https://privacytests.org/news.html - but I haven't looked into it
ATM, I am busy refactoring everything

no smarts if isTZPSmart = false (almost there)
no sha1 (almost there) - just use mini: everything was already mini, then some things were sha1 to get length
no hashing .join() - we just hash the array or object (almost there)
make each section and overall FP an object (almost there)
make detail data (e.g. arrays/objects of lists of things like font sizes, css colors, whatever) into objects where appropriate - e.g. retain typeof (almost there)
each section/overall FP contains the detail data (almost there)
removal of "blocked" and treating it as lies: just trap errors and record them (halfway there)

e.g. if the error was X = not supported in versionY+ then we would report not supported, else we would report blocked, but only on FF, otherwise we would do something else = fuck this, just record the error = entropy in itself

treat typeof mismatches as errors and record them (started)
treat timeouts as errors and record them (mostly done)
treat invalid results as errors and record them (started) - e.g. empty buffer arrays: when we expect a result but get nothing (not to be confused with a typeof mismatch)
get rid of gMethods (almost done)

all errors, typeof mismatches, invalid results, timeouts = already recorded in the errors FP
anything "method" entropy such as domrect or canvas will be reported in that metric

domrect elements test is gone: instead we do a one-off prereq isClientRect test
canvas: will be replaced to ONLY be a protection test, and the results we be e.g. "RFP random", "stealth random", actualhash (if no lies) = no need for gMethods, as the method is in the metrics

note: but we can still bypass errors: e.g. if matchmedia = errors, we can still read the css result
errors are retained and shown per section run as well as global (done)
lies + bypasses are retained and shown per section run as well as global (to do)

this makes it easier when I run simulations that cycle thru a set of results each section run, so I can check I am capturing and returning the right info/FPs

logging all errors via a generic function (done)

which also returns a trimmed/max-length result for display

logging all lies and bypasses via a generic function (to do)

i.e log_lies(name, bypassvalue) (if we can bypass something then there must be a lie, even if it was an "error")

some other stuff, am losing track, send COVFEFE

simplifying code/processes. over the years of prototyping it has just gotten so inconsistent somewhat. The less thinking about isFF, is blocked, is supported, etc the better. And so much game theory going on with extensions and lies and bypasses. Sometimes the number of paraemeters in the logic makes my head spin.
Am working my way section by section, or sometimes by searching for key words in my code like " sha1(" or "zB0" or .join( etc. Bit of a mess TBH right now. But almost there.
When all that is finished and a PR done, then I can focus on isBraveMode lies/bypasses - atm it just returns things like math proofs (canvas), some of your stuff (plugins/mimetypes) and some isBraveMode stuff like hardwareConcurrency
isTZPSmart can be turned on and off per engine, per FF version, and by any other metric such as isBrave. I need to decide what I want to do. It's not hard to leverage isBrave + isBraveMode and point out all the randomizing/lies - but I would rather focus on FF and mathematical proofs and adding new items or improving current ones

@pes10k - last paragraph

as far as I know
ways to bypass

some quick notes off the top of my head

mobile will always lack parity. Even RFP does not protect screen on android
the viewport cannot be faked, RFP doesn't do this either. too many methods to measure it, and any BS will cause layout or other issues

binds the screen resolution to the window outer resolution

RFP binds to inner (and inner = outer), which I think is silly: I have been pushing to change this for years. On desktop, despite letterboxing, we should just report a sliding result depending on the inner height (don't care about orientation)

note: RFP has newwin protections
e.g. if height =< 1600 report 1600x900 (this means all RFP users on startup will be identical)
e.g. else if height =< 2560 report 2560x1440
e.g. else if ... 4k, else if 8k
i.e if users change the inner by maximizing or going fullscreen, it changes. If they revert, it changes back. Most users will not change the newwin (which is another story about the default newwin sizes)
this is not meant as a full protection, since inner is still entropy, but it makes screen less risky. scripts like screen as it is more stable, vs inner which is a shitshow (toggle chrome bits on or off, or accidentally resize, or zoom (zoom also affects screen) - in other words this helps reduce screen entropy on it's own down to 3 or 4 buckets, even for those who turn off letterboxing (and they do, even TB users)

applies a random offset distinct to each resolution coordinate

RFP just returns 0 for everything and it has been proposed as a standard IIRC, but sure, brave can farble it, why not, since the engineering is there

this I do not get (@pes10k)

binds the screen resolution to the window outer resolution

I have not read what brave does exactly, so maybe something is missing here. This is a terrible idea. Look, outer and inner aren't exactly super stable, and while RFP ties to inner (and outer == inner with RFP), at least RFP has newwin size protections and letterboxing. So I'm sure Peter must be doing more than just the above sentence

https://github.com/arkenfox/TZP/issues/209#issuecomment-1296537253 - see method to restore: those pesky iframes again

could we add @arthuredelstein to this conversation, who is working on fingerprinting protections in Brave (and comes from Mozilla and Tor Browser)?

@Thorin-Oakenpants Hi! Why do you think binding the screen size to innerWidth/Height is silly?
I don't really follow the advantage of the approach you are proposing. The downside of your approach, it seems to me, is that if give a website screen dimensions that are too high, the website may attempt to open a window that is too large for the screen.

Hey Arthur!
To be clear, the "silly" (and not the best term I admit) was about RFP, where new windows are restricted to new tabs - to stop malicious window sizes. The initial RFP protection, of which you were a part, was newwin (on creation) sizes of 1000 x 1000 px max, outer == inner, screen + available screen = inner. There was no letterboxing. And android TB didn't exist (and is different anyway)
One issue with this is that any change in inner affects reported screen. Screen is a stable metric (aside from zooming) that scripts love. Inner is for advanced scripts and is less stable. i.e while attempting to make as few screen buckets as possible, by limiting to the same as inner (and we assume advanced scripts in Tor Browser), we have also made it somewhat fragile - cue newwin size bugs etc. Or users resizing accidentally, even by a smidgen. So we have a dozen newwin sizes, plus bugs, plus users changing the size (chrome changes toggling bits on and off like sidebar or menu, maximizing, full-screen, manual, etc). All of which affect screen. Yes, inner is still measurable, but the screen buckets are affected - think of scripts that don't get or try to use inner to link.
Additionally, there are some RFP orientation patches, which TBH are incomplete.
Now picture what I suggested - desktop only of course. Screen (and available screen) is limited to e.g. 2k, 4k, 8k, end of. story - 3 buckets. Or 4 buckets. Or 5 buckets. As long as all newwins are under the smallest res/bucket. All scripts that only get/use screen and/or available screen will now have all TB users in a single bucket on that metric. If a user exceeds the size, we step up one - I like this as it can create a different FP if the user maximizes for example.
Now letterboxing is still great and it limits the entropy in inner (and outer) sizes. But it's still tied to screen. The sliding LB steps of 50px, 100px, 200px width and 100px height, allow for a LOT of buckets. Certainly nothing like the 1px steps, but it's still a lot. By decoupling screen from matching inner, we can reduce potential screen buckets from a million+ (no letterboxing) to hundreds? (letterboxing) to 3 or 5 (just step several sizes). And we can reduce screen buckets on startup from a dozen+ or whatever it is (1000x600, 1000x700, 1000x800, etc 900x800, 900x700, etc) to one bucket.
This literally cannot increase entropy, it can only reduce it, and only on scripts that don't use inner. Letterboxing we keep for inner protection. It would also remove the necessity of RFP orientation spoofing, which is incomplete and was discussed as being done away with - as we would always be reporting landscape anyway
And another reason to not tie to inner, is that round hundred screen sizes is used in the wild to detect TB - why make it easy for them. So, in the bigger picture, while it does nothing for advanced scripts, it does mitigate the risk and is a first step in being able to re-evaluating newwin sizes for usability (1000px width is not sufficient on desktop these days and most screens are widescreen, we can at least increase the max width without any (or very minimal) inner entropy loss IMO but I need to crunch the numbers properly - i.e smaller res non 16/9 screen already have their own buckets)
maybe I'm terrible at explaining things, because while not super high priority, I don;t get why no-one else sees this, and it's trivial to implement

Now for Brave. As I said, I have not read what you have done. So when abraham commented "binds the screen resolution to the window outer resolution" and nothing more with that metric (they other bullet points were about coordinates and viewport), I said surely there must be more. Just reporting someone's unprotected outer window size is not the answer.
I didn't mean that using outer as a starting point was "terrible" (we need to start with something based in reality - RFP uses inner), I meant if that was it, then it was "terrible"  -  surely there must be more going on? Which is why I said "I have not read what brave does exactly, so maybe something is missing here"
RFP is based on inner (or outer if you like since they are the same), but at least RFP has newwin, and letterboxing, and TB forces new windows to open as new tabs.
So I would expect Brave to be doing at least something else with screen metrics

The downside of your approach, it seems to me, is that if give a website screen dimensions that are too high, the website may attempt to open a window that is too large for the screen

to be clear, as per last post

RFP, where new windows are restricted to new tabs - to stop malicious window sizes.

To be clear, the "silly" (and not the best term I admit)

No worries at all. :) Just trying to understand, and I appreciate the feedback.

Now for Brave. As I said, I have not read what you have done. So when abraham commented "binds the screen resolution to the window outer resolution" and nothing more with that metric (they other bullet points were about coordinates and viewport), I said surely there must be more. Just reporting someone's unprotected outer window size is not the answer.

I didn't mean that using outer as a starting point was "terrible" (we need to start with something based in reality - RFP uses inner), I meant if that was it, then it was "terrible" - surely there must be more going on? Which is why I said "I have not read what brave does exactly, so maybe something is missing here"

In Brave's protection, APIs are actually bound to the original inner (not to outer). You can see a full summary at https://github.com/brave/brave-core/commit/e63185989b457dc01152b165d527efa5188e408c. The goal of that work is strictly to hide hardware characteristics. I hope that clears up our approach, but let me know if anything isn't clear. (@abrahamjuliot's "method to restore" is very interesting and I will look into it.)
I think of the viewport size problem to be a (mostly) separate problem from screen size. It is quite challenging because of the UX implications and likely should be lower priority than some other fingerprinting problems.

I think of the viewport size problem to be a (mostly) separate problem from screen size

exactly. which is why (not your problem) I think TB/RFP should decouple them. once they do that, it enables better solutions - that was what I was getting at

You can see a full summary

OK. That shows farbling. So it was more than just tying to inner

"method to restore" is very interesting

but wait .. I see no css protection... in which case, TZP should bypass it already (range 500 to 2560 px)

You can see a full summary

OK. That shows farbling. So it was more than just tying to inner

Yes, tying to inner plus a small random offset.

"method to restore" is very interesting

but wait .. I see no css protection... in which case, TZP should bypass it already (range 500 to 2560 px)

CSS protection is the third item in that commit message:
3. device-{width,height} in media queries

When farbling is enabled, media query for device-width
matches the same value as window.screen.width (also farbled).
Same for device-height.

https://arkenfox.github.io/TZP/tzp.html#screen
I have

[css min-device-] screen resolution (I use min because on devices with subpixels it usually drops 1 pixel)
[matchMedia] screen resolution - on devices with subpixels this may not be an integer

my bad, I read media queries in my head as matchmedia/JS
I assume you covered all possible css queries? I guess I can wait til the patch hits stable release, but I don't check Brave often (the other day was the first time in like six months) and while TZP is aimed at gecko, a lot is still in common
I'll leave it all to you - you know what needs to be done, having been part of TB + RFP. If I see anything in future in my tests, Peter knows where I reveal them "-)

I assume you covered all possible css queries?

The only css queries that commit covers is device-width/device-height, which reveal screen size (through media queries and matchMedia). If you know of any other css query I might have missed that reveals screen size, please let me know!

^^^ look up ... .css min-device-

Yes, min-device-width/height and max-device-width/height is also covered.

Hi @abrahamjuliot, I'm interested in this technique:

method to restore (slow):

create an iframe with a 0x0 viewport (this can work with any preset resolution)
render the iframe on the page and get the screen resolution to obtain the offset values
subtract the offset values from the corresponding root window screen resolution values

I tried to reproduce this but couldn't. Do you have a working example I could look at?

Sure. I'm finding this detection is not that great. 😢 It only restores the inner resolution, which can instead be accessed directly with innerWidth and innerHeight.
// iframe method (slow)
;(() => {
  const presetWidth = 1920
  const presetHeight = 1080

  const iframe = document.createElement('iframe')
  iframe.width = presetWidth
  iframe.height = presetHeight

  document.body.appendChild(iframe)
  const { width, height } = iframe.contentWindow.screen
  document.body.removeChild(iframe)

  const offsetHeight = height - presetHeight
  const offsetWidth = width - presetWidth

  console.log('offset:..', ''+[offsetWidth, offsetHeight])
  console.log('inner:...', ''+([innerWidth, innerHeight]))
  console.log('screen:..', ''+([screen.width - offsetWidth, screen.height - offsetHeight]))
})()

// matchMedia method (fast)
;(() => {
  const matches = (x, query) => matchMedia(`(device-${query}: ${x}px)`).matches
  let offsetHeight = 0
  let offsetWidth = 0

  while (offsetHeight < 10 && !matches(window.innerHeight + offsetHeight, 'height')) offsetHeight += 1
  while (offsetWidth < 10 && !matches(window.innerWidth + offsetWidth, 'width')) offsetWidth += 1

  console.log('offset:..', ''+[offsetWidth, offsetHeight])
  console.log('inner:...', ''+([innerWidth, innerHeight]))
  console.log('screen:..', ''+([screen.width - offsetWidth, screen.height - offsetHeight]))
})()

closing .. isBrave was hardened and I added some alerts for when something changes .. job done .. back to focusing on gecko


Criggie: Watch vidmate.bid

Criggie requests the watch of the watch_keyword vidmate\.bid. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vidmate\.bid has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


Can't specify Content-Type or Accept Non JSON API Compliant Request Format","detail":"Invalid Accept Header: 'application/json'.

Seems like you should be able to specify this as a header to comply.
{
"errorCode": "2200",
"message": "Failure happened on 'Source' side. ErrorCode=UserErrorHttpStatusCodeIndicatingFailure,'Type=Microsoft.DataTransfer.Common.Shared.HybridDeliveryException,Message=The HttpStatusCode 406 indicates failure.  {"errors":[{"title":"Non JSON API Compliant Request Format","detail":"Invalid Accept Header: 'application/json'. JSON requests must comply with the jsonapi.org specification - supplying Accept and Content-Type headers with a value of 'application/vnd.api+json'.","code":"1030","status":"406"}]},Source=Microsoft.DataTransfer.ClientLibrary,'",
"failureType": "UserError",
"target": "Copy Data1"
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9da1816-3f64-bd45-443f-5bdb48bacc24
Version Independent ID: e649f787-62da-fc97-2e9a-ba89765beed4
Content: Copy data from a REST source by using Azure Data Factory
Content Source: articles/data-factory/connector-rest.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@pearcec Could you ask your question in the forums? The audience there would be a better suited to answer your question. https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=AzureDataFactory.

As called out by @CHEEKATLAPRADEEP-MSFT this looks to be an implementation question and we think the forums can be more helpful here . At this time we are going ahead and closing this issue , if you feel appropriate you can always reopen the issue .


Improve query-expr and query-action parsing

Purpose
$subject.
Fixes #24923
Approach
N/A
Samples
N/A
Remarks
N/A
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Also noticed a change coming from upstream in which the invalid node in leading minutiae get flattened.
Assertion updated for that change with 6ed3200

An integration test failed due to a time out. Hence re-triggering builds


July CPU : Fix Checksum For Debian JRE 17 Riscv

July CPU : Fix Checksum For Debian JRE 17 Riscv

/merge

/approve

/approve


fix: bump checkout to v4

Minor change, the GitHub Action (which is great btw) uses actions/checkout@v3 which uses Node 16, bumping to v4 uses Node 20 which fixes this deprecation.

Good catch @Arcath - @f-bader 👌


Make Capture Node ASG size configurable

Description
Currently, the size of the Capture Node's autoscaling group is static and not configurable by the user.  We should enable the user to indicate an expected traffic volume and provision the ASG according to the user's specification.
Considerations:

According to the docs, each Gateway Load Balancer VPC Endpoint can support 10 Gbps by default, and will automatically scale up to 100 Gbps [1]
We have one such VPCE in each subnet of the user's VPC
To simplify our initial offering, we can set our maximum volume to 100 Gbps for the Capture Nodes as a whole.  This enables us to avoid dealing with individual subnets emitting more volume than their VPCE can transmit through their VPCE to the GWLB.
Per @awick, a physical host w/ 8 CPUs and 16 GB of memory can handle ~4 Gbps of capture traffic volume.  The current default choice of Capture Node instance type (m5.xlarge) has ~3.5 usable vCPUs and ~15 GiB.  We will assume a 50% knockdown factor due to the reduced number of cores and use 2 Gbps/instance as our scaling constant.  This is a guestimate, and we will likely update with experimental data later.

[1] https://docs.aws.amazon.com/elasticloadbalancing/latest/gateway/quotas-limits.html
Note: This is a sub-task of https://github.com/arkime/cloud-demo/issues/34
Acceptance Criteria

The user should be able to specify an expected traffic volume when calling create-cluster
Once the expected traffic volume is set, the user should not need to pass it in via the CLI again unless they want to change it.  If the user re-specifies the parameter, then it should be updated
If the user does not specify an expected volume, then a reasonable default should be chosen
Demonstrate the ability of the CLI to set and update the ASG size.

Taking a look at the mechanics of this, ASGs have three "dials" you can turn on their capacity - min cap, max cap, and desired cap.  The max/min are hard limits, while the desired is the initial capacity.  Auto-scaling events will change the initially provisioned capacity without the max/min limits.
In that context, it seems like we should have something like:

Min = 1
Desired = ceiling(expected traffic load in Gbps/2)
Max = ceiling(Desired * 1.25)

This should help deal with miss-estimates on our side and the user's side.

Since we're using BRIDGE mode for ECS-on-EC2, we have a 1:1 ration of ECS Tasks and EC2 instances, so our initial starting task number should be the same as our desired instances.

Overall, task appears to be:

Add README update for the new option explaining it
Add the CLI parameter to the "frontend"
Add code to convert a desired volume into a capacity plan
Add code to pull the capacity plan for a cluster if it exists, update if appropriate
Add code to pass the capacity plan through to the CDK
Add CDK code to store the capacity plan in SSM
Update CDK code to use capacity plan

Code merged; AC met.  Resolving.


prevent empty form submission and fixed redirects of navigation bar and footer links

Related Issue

Fixes issue: #182

Proposed Changes

prevent default empty form submission
fixed redirects issues when click on links

Checklist

[:heavy_check_mark:] Documentation of the code
[:heavy_check_mark:] Add your name to the CONTRIBUTORS file
[:heavy_check_mark:] Testing your code in the local machine

Screenshots

@vivek0033 Please follow the contribution guidelines before you create a pull request. PRs without parent issues are a bad practice in industry. They lead to poor progress documentation.
Having said that, please claim #182 before our chapter lead brutally closes this pr into oblivion.

@vivek0033 Welcome to open-source! Thank you for editing the PR message but when I mean 'claim' the issue, I'm asking you to comment in the issue thread (#182) saying something like "Can I work on this?". This is usually followed by a maintainer like me 'assigning' you the issue. Then the contributor is supposed to begin working on the patch.

Oh I just noticed you already commented. Also, I'll recommend joining our Discord if you wish you contribute more to our repository. We have tonnes of beginners there and all queries, discussions, and collaboration efforts are welcome!
Happy Hacktoberfest!


line 307 in editor.py

Dear EasyEdit team，
I may have found a seeming contradiction line 307: EasyEdit/easyeditor/editors/editor.py
    with torch.no_grad():         for k, v in weights_copy.items():             nethook.get_parameter(self.model, k)[...] = v.to(f "cuda:{self.hparams.device}")
This seems to be restoring the weights of the original model. But the final return value is named edited_model in line 361.
This has confused me, and I'm not sure if I'm missing other information that has led me to this confusion.

Actually, the edited_model is a reference (address) to model, so they are essentially the same.

😆Yes. But my question is that the weights of the specific layer in edited_model are recovered by weight_copy which records the origin value of origin model. So the edited_model  gets the same weights as the origin model. I'm confused about whether the return value is what we expect. 🤔

👍Yes, your understanding is correct. In the past editing literature, the measurements were the results of a single edit, so it was necessary to roll back after each evaluation. However, in EasyEdit, you can enable continuous editing by setting keep_original_weights = False, more details in the issue #220

Oh, I see. Thanks for your reply!😆


How enable multiuser use RDP

Can use rdpWrap with two user?

Of course.
If you are using two different users, there will be no problem. But if you want to use the same user logged in console and RDP sessions, you need to use RDPConf and clear checkbox "Single Session Per User", then click Apply.


[Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address

Make query_rpc_tracker show the correct device server port and customized address. Previously, the query_rpc_tracker command shows a dummy port and does not support showing the customized address.

Now, it shows the correct port and supports the customized address.

Also fixed some minor typos.

@lmxyy thanks for fixing this! I'm not quite sure I understand the order of events that leads to the incorrect port, though. could you explain for my understanding?

Sure. Previously, when you set up a server on your device side, the device would open a new connection to the tracker. When the tracker accepts the connection, it will register the device and record where the connection comes from (code). However, this connection is built on a dummy port on the device instead of the server port, so the address is not correct. Moreover, this address will not be updated since the device only sends the device key to the tracker (code).

@lmxyy ah i had missed the thing at your first code pointer.
could you change that line to self._info = {} then? there is no sense in recording the tracker connection's remote address in place of the RPC server that should be there. the "dummy" value you're referring to is the port dynamically allocated by the OS of the machine running the RPC server when the tracker connection is established.

Sure, I've changed self._info={}.
@tqchen Could you help review this pull request?

@tqchen @areusch @merrymercy

@areusch Do I need to make further modifications?


Remove buildbot directory and migrate what it did to main Makefile

[x] Detect if hll is supported instead of using flag
[x] Detect if timeseries is supported instead of using flag

+1


explaining how "publicPath" & "outputPath" template placeholders work

I just added information about "publicPath" and "outputPath" template placeholders in the Readme file

@knee-cola friendly ping :)

@knee-cola Any changes the requested comments will be addressed in this PR ? :)

Closed due to inactivity && superseded by #171. Thx :)

IMO this explanation is more clearer than what's on the doc.


Use enum class for message types and status codes for secure channel.

This should give us better type-safety.

Problem
Secure channel message types and status codes are C-style enums, which gives worse type-safety properties than C++ enum classes.

Summary of Changes
Use enum classes instead.

Just give a second thought, after we change to enum class, we now finally need to static_cast those strong typed values to int during encoding .
// Set the message type for this header.
payloadHeader.SetMessageType(msgType);
It seems not much gain we can achieve, right?

I would propose we add an API that looks like payloadHeader.SetIsSecureChannelMessage(msgType), which takes the message type enum as the arg and sets both the protocol id and the message type together, with the cast happening at this point.  That ensures that the protocol id and the message type can't get out of sync.
We probably still need to leave the raw SetMessageType API for use by consumers that add extension protocols...

Or even just have an overload of SetMessageType that is specialized for the enum type and sets the protocol id along with the message type if we don't care to do the cross-checking between protocol name and message type....

We also need to take care of the incoming path, convert the decoded int value to enum class for message type and status code at transport level.
Right now, the spec defines the protocol ID is a 32-bit unsigned int, and status code as a 16-bit unsigned int. So we use variables some like unit32_t protocol_id, uint16_t status_code to take and process the status code from all protocols. After switching to enum class, we need to use separate variables to host status code for each protocol, one for generic Common protocol status code and one for protocol specific status code.
If we plan to transit protocol ID also from enum to enum class, we need to make the same adjustment.

For the incoming path, I think the best we can do it offer the unsigned int in the payload header getter.  That said, for dispatch, we can consider having APIs on payload header like IsSecureChannelMessage(SecureChannel::MsgType type) that would do the type check and also check the right protocol, instead of doing compares to the members directly.
I agree that it might turn out that this is all too painful, and then we can revert back to the C-style enum, but I think the APIs I've mentioned so far would be useful to have in any case.
Protocol id can't easily become enum class, because the set of protocols is not really known ahead of time, unlike the set of messages or status codes per (standard) protocol.  Though I suppose we could have an enum class of "standard" protocols (with 0 vendor id).... Not sure it's worth it.


[Question]: How to authenticate with OpenRouter model server when running Fabric commands

What is your question?
Hello, I'm attempting to use OpenRouter as the model server for the Fabric command-line tool. I have set the OPENAI_BASE_URL environment variable to point to https://openrouter.ai/api/v1 and am able to successfully list models available from Openrouter using the fabric --listmodels command. However, when I try to execute a command that requires communication with the OpenRouter server, I encounter an authentication error.
Steps to Reproduce:

Set the environment variable OPENAI_BASE_URL to https://openrouter.ai/api/v1.
Run fabric --listmodels to confirm connectivity and list available models.
Attempt to run a Fabric command that interacts with OpenRouter, e.g., echo "I like turtles" | fabric -p write_essay -m llama-3-8b-instruct:free.

Expected Behavior:
The command should execute successfully, with Fabric using the provided API key to authenticate with OpenRouter and process the request.
Actual Behavior:
I receive the following error message:
Error: Error code: 401 - {'error': {'message': 'Missing Authentication header or invalid API key', 'code': 401}}
Error code: 401 - {'error': {'message': 'Missing Authentication header or invalid API key', 'code': 401}}

Troubleshooting Steps Taken:

I have added the appropriate OpenRouter API key to the ~/.config/fabric/.env file with both OPENAI_API_KEY and OPENROUTER_API_KEY assignments.
I have verified that the API key is correct and has the necessary permissions on the OpenRouter platform.
I have ensured that there are no typos or syntax errors in the environment variable settings or in the commands being executed.

Environment:
Operating System: Windows 10
Python version: 3.11
Could you please guide me on how to properly configure Fabric to authenticate with OpenRouter's API? Am I missing a step or is there a known issue with integrating Fabric and OpenRouter?
Thank you for your assistance.

Hello! I just got Fabric working, and I'd like to help with it.

Set env variables in .config/fabric/.env. You have to set OPENAI_BASE_URL=https://openrouter.ai/api/v1 and OPENAI_API_KEY to your generated OpenRouter token.
As for the model, copy the model name from OpenRouter website. The model names outputed from fabric --listmodels are missing the first segment. For example, I'm using DEFAULT_MODEL=meta-llama/llama-3-8b-instruct:free

With those couple of points, you should up and running in no time.

Thanks so much for the instructions @MonkeyAndres!
I actually had all that setup but I see the issue was that I also had environmental variables for OPENAI_API_KEY that were different than what I had in the .env file, interfering with my inference. 😆
I greatly appreciate your assistance! ❤
Though perhaps self evident to those more skilled than myself, perhaps the fabric documentation would benefit from a version of @MonkeyAndres's information.


grpc for CreatePod

Signed-off-by: Yao Zengzeng<EMAIL_ADDRESS>

Refer #136.

When I test this PR against newest hyperd hyperstart runv, I encountered (regardless of any network):
qemu: fatal: Trying to execute code outside RAM or ROM at 0x0000000000107474

in libvird's log. @YaoZengzeng Please check if it happens to your env.  If yes, your commit seems not work with newest runv.

lgtm


main frame general tab needs content in scroll pane

or at least set a minimum size since the rest of the app is pretty much unusable anyway

fix in ssl branch


Move a note from one folder to another caused all files in the attachment folder to move with that note?

Moved a note between folders
So in this case simply moving file1.md to folder 2 resulted in every single attachment being moved from folder1\attachments to folder2\attachments?
├── folder 1/
│   ├── attachments
│   └── file1.md
└── folder 2/
    └── attachments

To be clear, are you asking a general question (usually you would use the present tense of verbs in English) or are you asking about what happened when you used the extension (here you would  use the past tense of verbs in English)?

Moved a note between folders
So in this case simply moving file1.md to folder 2 resulted in every single attachment being moved from folder1\attachments to folder2\attachments?
├── folder 1/
│   ├── attachments
│   └── file1.md
└── folder 2/
    └── attachments

If you enabled auto rename, the associated attachemnt folder of a note will be renamed

Thanks for the reply
In folder 1 there would be many other notes, so the attachments folder would have a few 100 files. In this case, I do not understand why the plugin moved everything.

Hi @trganda - This is still happening. When you have time, could you please look into this?

I will take a look :)

Hi @spiritualgeek, sorry for waiting so much time.
I have released https://github.com/trganda/obsidian-attachment-management/releases/tag/0.8.5, the rename operation will only rename the attachments linked by the notes file.
As shown in the picture below, I hope this can help you.

Thank you so much. I'll test it soon and let you know


feat: supports js extension for react and vanilla ui

closes #356

Details
Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I checked the current PR for duplication.

Note that this PR breaks CSUI.
ATM, Plasmo uses the .tsx vs .ts extensions to differentiate CSUI vs CS (plain content script with no extra UI mount runtime).
We can incorporate .jsx extension for this PR, which helps differentiate between code that has React vs plain JS without JSX (for Flow)
@pd4d10 For rescript - you can create a rescript parcel transformer, that incorporates the .res file extension. We can incorporate it in our config and that will allow you to use the .res extension for rescript with zero external bundlings needed.

Move the above to #367


When there is GPS fix but NO parsed message available

In void logToSDCard(void) {
The default logic in that case is to assign a random date, is there a quick way to fire up the RTC and use it instead BEFORE the next RS1D message arrives (4Hz, every 0.25s):
dataString += "2011_11_11__11_11_11.100"; // <DEBUG>
EDIT: Also here:
// TODO#1: if we have a GPS timeout here, we should revert back to the RTC. Add code
    fileName += "2011_11_11__11_11_11"; // <DEBUG> <PLACEHOLDER>

Done


How to set maximum number of value?

For example I'm getting

Please re open this if you have more information.


[cluster-test] Use 'Name' tag instead of 'PeerId'

Summary
PeerId is no longer a tag on the AWS instance, so using the "Name" tag to identify an instance. Since we no longer have the PeerId, we dont have the short_hash either, so rename it to peer_name
Test
Tested on my cluster which was brought up by dynamic config

@bors-libra r+

:pushpin: Commit 60e212b has been approved by andll

:hourglass: Testing commit 60e212b0b6402142fb28f3c568b6c9b4ced499ac with merge 35d008bd8c575a1022927f13fcd69bb7213036fc...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=andll

:pushpin: Commit 38770e0 has been approved by andll

:hourglass: Testing commit 38770e0c47ab6e5535620d9830cb405306266baa with merge 8e61b637230b219fd896187d1a4b8960131e4bbd...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: andll
Pushing 8e61b637230b219fd896187d1a4b8960131e4bbd to master...


62% 🐶building 668/768 modules 100 active  ...

when I  run dev, It just shutdown the terminal when it goes  about 60%,and  when I  remove some packages, it just works well,
I guess the package may be larger!
But I do not konw why? May it has some other cause?
Thanks!

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us by recreating the issue using one of our templates.
Please fill out all fields, we can't help you without it


Testing

This is a pretty low amount of coverage, but I think the heavy lifting in setting up the required infrastructure for testing some of the more complex parts of the code is covered.

i should fix that test failures before we merge this.


Reverse colors for selection.

Give style_from_dict an option to reverse the colors for a selection.
Probably, to be the most flexible. We want a Highlighter (the SelectionHighlighter) to not just replace a token to a fixed value, like Token.SelectedText, but instead prefix the existing token with the given one:  Token.SelectedText.Name.Whatever.

Implemented. Selection can now be styled in any possible way. (Reversed or fixed fg/bg.)


Hello, Kijai, what's the meaning of "hf_step" and "lf_step" of fastercache node?

Fastercache is really useful, it can speed up  2x  when work with cogvideox 1.5,  really appreciate for your great work.
but I can find information about this node, what's the meaning of "hf_step" and "lf_step" of fastercache node? and what's the recommended value of them?
and are there any other tricks to speed up and improve the video quality?
Thanks!

Did you notice that the results of Fastercache seem noisy

Did you notice that the results of Fastercache seem noisy

you can set the sample steps to 30, the quality is pretty good.

Did you notice that the results of Fastercache seem noisy

you can set the sample steps to 30, the quality is pretty good. I set the start step of fatercache to 5 and set the sample steps to 30, both speed and quality are taken into account, and the image consistency is much better

Did you mean to say that set steps to 30, fatercache start step to 5, while fatercache hf_step and lf_step keep 30 and 40?
If that's so, I think the fastercache doesn't work because all the steps in it need to be less than total steps

I don't really know myself what the optimal settings are, probably situational, based on the original example for 50 steps (the default values in the node too) and looking at their graph it would align to something like this:

You do indeed need to fit the steps within the sampling process.
Another thing I noticed is that results are far better with DDIM than DPM when using FasterCache.

CogVideoXDPM
https://github.com/user-attachments/assets/fed4e224-0f7a-45a0-9992-c1975770a2bb
CogVideoXDDIM
https://github.com/user-attachments/assets/1e277eb7-3b04-4bd7-9611-0d4dd554b9db
Some quality hit is pretty much unavoidable of course.

Kigali, thanks for your replay, I mainly use the workflow to animate humans, my settings is best for my 4060ti 16g, my requirement are "the face and body is consistent, no wired motion, the speed is fast", it seems that  it is quite fit my needs.
https://github.com/user-attachments/assets/3a40b14c-5a35-4c3b-8aaa-9839cab0be2a

Another thing I noticed is that results are far better with DDIM than DPM when using FasterCache.
According to my test, it seems that cogvideoxdpmscheduler is the best for human.


Ensure correct scoping for Single Page CSS templates

Description

Removes the duplicate rendering of page/site:css templates into Baseline. For some reason, this wasn't updating on new page navigation, and so rendering "Single Page CSS" on all screens
Add E2E test coverage

Related Issue(s)
Fix #901

Thanks all.


Vickel: Watch ethicaltechhack

Vickel requests the watch of the watch_keyword ethicaltechhack. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ethicaltechhack has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


install: place the libraries in architecture-specific directories on ELF platforms

This is needed for apple/swift#63782, which changes the Unix toolchain to look for libraries in architecture-specific directories.

@rokhinip, now that this passed the CI on the linked compiler pull, looking for review so I can get this in before the upcoming 5.9 branch. Please don't merge though, as all 11 pulls will have to be merged together.

Closing since the Swift devs want to take a different approach.


fix HelmRelease status update error

Signed-off-by: Di Xu<EMAIL_ADDRESS>
What type of PR is this?
kind/bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Codecov Report

Merging #305 (5db89ed) into main (15d4a33) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   11.04%   11.09%   +0.04%
==========================================
  Files          47       47
  Lines        4970     4976       +6
==========================================
+ Hits          549      552       +3
- Misses       4382     4386       +4
+ Partials       39       38       -1

Impacted Files
Coverage Δ

...ub.com/clusternet/clusternet/pkg/utils/deployer.go
4.05% <0.00%> (-0.05%)
:arrow_down:

...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d4a33...5db89ed. Read the comment docs.


Wherefore callbacks?

Hi,
the current design uses callbacks to communicate the results of operations back to the fuse daemon, e.g.:  the cb in readdir: function (path, cb) ....
Can you explain the rationale for this, rather than, say having the operations return values e.g.
readdir: function (path) { return ['file1'];}

The python bindings for fuse seems to choose that approach.
For instance is it ever correct to call a callback more than once for a given operation?  Also can a callback be used after the operation notification has completed? (e.g. readdir returns without calling cb, and at a later point cb is called with proper data)
A 'yes' to either question would clarify the current design, however, best would be examples demonstrating the possibilities.
Cheers! nehal

Python is a blocking language, while Javascript not, so operations are asynchronous. They work the same way, only that in Python the execution will stop until the called functions return a value, and in Javascript they continue, so instead of returning the result, you pass it to the callback function.

python learned async/await a while back and has known yield for a very long time....
But, to keep it simple -- is it valid to cb more than once for any operation?

But, to keep it simple -- is it valid to cb more than once for any operation?

Depends of the library you are using, but usually (like in this case) not.


Document Postgres & Storage security checklists with evidence of completion

Checklist has been sent to Michelle. PR created to address Terraform misconfiguration.


play tone sounds not working on Mobile Safari

music.playtone

does not sound on Mobile Safari. Possibly not playing the sound for long enough.
Also note editor doesn't sound very good on Mobile Safari.

iOS will only let you start playing sound with the Web Audio API as a result of a user action.

There is no fix for this as this is an IOS restriction. Closing this until we have a workaround.


Idol.sankaku is using incorrect subdomain for full resolution images

What steps will reproduce the problem?
When trying to load full resolution image (whether for viewing, single download or batch download), the subdomain used for fetching the image is iss.sankakucomplex.com. While it “works”, it is not actually the address that contains the full resolution images: that's the is.sankakucomplex.com subdomain. I'm honestly not even sure where does the iss.sankakucomplex.com come from when by studying the JSON source, it always links to the is.sankakucomplex.com subdomain.
At any rate, according to the log tab, Grabber tries to find to fetch the full resolution image from the iss. subdomain with .jpg, .png, .gif, .jpeg, .webm and .swf extensions and eventually falls back to .jpg while at the same time prepending the filename with sample- and changing subdomain to is.. Only on that address the image is found and downloaded, but at that point it's not the highest resolution available.
What is the expected behavior? What do you get instead?
Using is.sankakucomplex.com subdomain for fetching full resolution images. By setting up a local proxy with rule to rewrite iss.sankakucomplex.com to is.sankakucomplex.com, I can fool Grabber to actually fetch the correct resolution images. Please note that this problem only truly manifests for images that are really high-resolution, I'd guesstimate that the image must be at least 2000 pixels in one dimension.  FWIW, the rewrite of the subdomain was really enough to fix the problem locally, meaning the rest of the URL can stay the same and work just fine.
What version of the program are you using? On what operating system?
Grabber 5.0.0 on Windows XP. Don't laugh, it was the only system I had available for virtualization 😃
Please provide any additional information below

While it “works”, it is not actually the address that contains the full resolution images

It doesn't seem to work from here though?

Thumbnail: https://i.sankakucomplex.com/data/preview/0a/f0/0af025da02bd6e4ec881ec19490186e1.jpg
Full-size: https://is.sankakucomplex.com/data/0a/f0/0af025da02bd6e4ec881ec19490186e1.jpg

Trying to load "https://iss.sankakucomplex.com/data/0a/f0/0af025da02bd6e4ec881ec19490186e1.jpg" (full-size url with the "iss" subdomain instead of "is") results in a 404.

I'm honestly not even sure where does the iss.sankakucomplex.com come from when by studying the JSON source, it always links to the is.sankakucomplex.com subdomain.

It comes from the Regex parsing: Grabber takes the thumbnail url and applies two transformations on it: replace "/preview/" by "/" and ".sankakucomplex" by "s.sankakucomplex". The second one actually means "add a S to the subdomain". The problem here is that these transformations should not break already-good urls.
An easy fix before the update is simply changing the tranformation from ".sankakucomplex->s.sankakucomplex" to "i.sankakucomplex->is.sankakucomplex" in Sankaku's model.xml file that can be found in "C:\Users%username%\AppData\Local\Bionus\Grabber\sites\Sankaku".

At any rate, according to the log tab, Grabber tries to find to fetch the full resolution image from the iss. subdomain with .jpg, .png, .gif, .jpeg, .webm and .swf extensions and eventually falls back to .jpg while at the same time prepending the filename with sample- and changing subdomain to is.. Only on that address the image is found and downloaded, but at that point it's not the highest resolution available.

Yes, in case of 404, Grabber tries other possible extensions if he is not confident in the one he is using. Then, if all fails, it fallbacks to the sample url.

By setting up a local proxy with rule to rewrite iss.sankakucomplex.com to is.sankakucomplex.com, I can fool Grabber to actually fetch the correct resolution images.

Kudos on that trick :smile:

Grabber 5.0.0 on Windows XP. Don't laugh, it was the only system I had available for virtualization 😃

At least it proves that Grabber still works on XP!
But why do you need virtualization to run Grabber? If you're on Linux or OS X, Grabber is pretty straight-forward to build (as long as you don't mind installing the Qt dependencies).

It doesn't seem to work from here though?

Apologies, I think I expressed myself poorly there. It “works” in the sense that Grabber tries to access the iss. subdomain several times, then falls back to is. but prepends the filename itself with sample-, therefore downloading at least something, but not the thing people would probably want. Nothing ever gets downloaded from the iss. subdomain, that's true 😄

An easy fix before the update is simply changing the tranformation from ".sankakucomplex->s.sankakucomplex" to "i.sankakucomplex->is.sankakucomplex" in Sankaku's model.xml file that can be found in "C:\Users%username%\AppData\Local\Bionus\Grabber\sites\Sankaku".

I'll try that once I have few minutes of a time!

Kudos on that trick 😄

Thank you 😄

But why do you need virtualization to run Grabber? If you're on Linux or OS X, Grabber is pretty straight-forward to build (as long as you don't mind installing the Qt dependencies).

That's exactly the thing, it didn't seem all that smart to install the Qt dependency for just one program, especially since I've got a fairly fresh and clean installation of the system. Isolating it to VM that I can delete once I have obtained what I need seemed more reasonable.
Thank you so much for looking into this, by the way. I've got one more issue regarding tags being ignored during large batch download and everything getting put into one huge misc copyright/unknown character folder but I need to first do some more research on that topic before I open an issue for that – plus I've seen that several people had this issue in the past so I need to go through their tickets first and see if I can resolve it by myself.


Question: Inserting files

Is it possible to insert a file into the CodeMirror?
I know there is a method for inserting a string: setValue(string) But I would like to insert an entire file (such as: script.js), including line numbers etc.
Is this possible?

This is a bug tracker. The place for questions is the forum. As for your question, I'm not sure why setValue wouldn't work for an entire file.


The virtual columns should be _version and _sign

So that this is interoperable with MaterializedMySQL
Currently
sign and ver

https://clickhouse.com/docs/en/engines/database-engines/materialized-mysql/#virtual-columns

Fixed in #88


BUG-005: Crash on Pixel devices in Android 14+ when receiving alarms

Fatal Exception: java.lang.RuntimeException
Unable to start service com.mlucas.mushu.AlarmService@aef5aab with Intent { act=START_ALARM cmp=com.mlucas.mushu/.AlarmService (has extras) }: android.app.ForegroundServiceStartNotAllowedException: Service.startForeground() not allowed due to mAllowStartForeground false: service com.mlucas.mushu/.AlarmService

Issue appears to be present in Android 14 in Pixel devices mostly, but also may appear on some other. It seems these devices have more agressive policies regarding foregound usage of background apps.
Trying to change Alarm approach to use AlarmManager instead of just relying on playing media from background. This requires an additional permission from the user


plan to support official gRPC interceptors?

gRPC python now support interceptors, link , any plan to support it?

We're open to it. Would you be able to put a PR for it?

I would love to.

@rnburn please see if there is anything needs to be changed.

Hi.
Any updates on this?

Any plan for PR14 to be merged if the conflicts are resolved? Or is there anything else needed to get it over the line?


Text color issue when desktop is in darkmode

I use KDE/browser in dark mode and normally sites adapt accordingly, I wasn't expecting this to impact neutrino, but it does.. partially anyway. This is how it looks:

Thanks for opening the issue, I'll look at it


Removed call to deleteAll from deleteInternal

in this manner we removed the hidden relation between delete and deleteAll. Example: if we have to override deleteAll and call delete for single model (and trigger delete event)

Pretty sure this will break the AR implementation of non-SQL dbms. If you need to trigger events on delete you should not use deleteAll() but use another method for that.

Ok, but
https://github.com/yiisoft/yii2-mongodb/blob/master/ActiveRecord.php#L324
It not use deleteAll into deleteInternal, and it's correct.
Only yii2-redis override deleteAll without change deleteInternal.
I think it's a dangerous relation. IMHO. bye bye


Column Area box and C3 Stacked Bar Chart break out of div container when number of data fields is larger

Hi Nicolas,
Firstly, can I say a massive thank you for creating this incredibly powerful PivotTable component - it was exactly what I was looking for.
I have an issue that I thought you might be interested in, as I think it's more to do with the PivotTable interface than the C3 chart.
When I provide a JSON data source that has only 5 data fields, all of the data fields fit neatly within the grey horizontal "attributes" box (to the right of the "renderer" drop-down box).
When I provide a JSON data source that has 15 data fields, they exceed the width of this horizontal "attributes" box and instead appear in a new grey vertical box (directly below the chart type drop-down box). This is clearly a good way to accommodate a larger number of data fields.
However, in this latter scenario, the horizontal "column area" box (and the C3 chart below it) breaks out of the div container that houses the PivotTable component, presumably pushed across by the addition of the vertical "attributes" box.
Is the behaviour I described above intentional? Or is there a way to resize the PivotTable interface (specifically the "column area" and chart) to fit within the div container?
Any assistance or advice would be much appreciated.
Many thanks,
Clive

Thanks for such a quick response - much appreciated.
I'm using Windows 7 and the issue consistently occurs in Chrome, Firefox and IE11 (I've not tried in any other versions of IE).
Attached are two example HTML files; one which loads a JSON dataset consisting of 5 fields and one which is identical apart from loading a JSON dataset consisting of 15 fields. The first example fits the parent div neatly, the second example breaks out of the right side of the parent div.
Hope that clarifies my previous post.
pivottable_issue_505_examples.zip

OK, that definitely helps illustrate the issue, thanks! So the issue actually shows up on both your examples, if you shrink the width of your window enough... Basically the #output div isn't stretching to accomodate its contents. I was able to fix this on OSX/Chrome by adding display: inline-block; to the #output div as per http://stackoverflow.com/questions/1161166/how-can-i-ensure-a-div-stretches-to-fit-its-contents.

Many thanks Nicolas - that's sorted it.

Happy to help!


[ZEPPELIN-5831] Enable Cassandra for JDK11

What is this PR for?
This PR updates scala for the cassandra interpreter to 2.12
What type of PR is it?

Improvement

Todos

[ ] - Verify with real Cassandra Backend

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5831

How should this be tested?

CI

Questions:

Does the licenses files need to update? Yes
Is there breaking changes for older versions? Yes
Does this needs documentation? No

I have not tested the changes against any external Cassandra backend. Besides, my Cassandra knowledge is very limited.
I would be very grateful if someone tests the changes. Maybe @alexott ?

If no further comments are received till Thursday, I will merge the change into the master to proceed quickly with JDK 11 support.

FYI, I heard that @alexott is not actively contributing to Cassandra any longer.


chore: Docs change for 3.2.1 release

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3640a28) 38.15% compared to head (bb31886) 38.15%.

:exclamation: Current head bb31886 differs from pull request most recent head 94dfcf3. Consider uploading reports for the commit 94dfcf3 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##             3.2.1-prepare   #15539      +/-   ##
===================================================
- Coverage            38.15%   38.15%   -0.01%
  Complexity            4707     4707
===================================================
  Files                 1304     1304
  Lines                44828    44792      -36
  Branches              4807     4784      -23
===================================================
- Hits                 17105    17091      -14
+ Misses               25870    25849      -21
+ Partials              1853     1852       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


groups: creating a channel with the same flag in different groups causes collision

To Reproduce
Steps to reproduce the behavior:

Create a group and a notebook within it, then add a test post
Create another group, then a new notebook with the same name as the previous notebook
Observe that the post from the first notebook is duplicated in the new notebook
Delete the post in the second notebook
Observe that the post is gone from the first notebook

Expected behavior
Channels should be able to have the same name across multiple different groups
Additional context:
This is because we are only considering the channel flag for some state operations and component rendering. Will need to refactor to use a composite key of group flag + channel flag

https://user-images.githubusercontent.com/2065299/199561886-46893d06-72a4-4b5f-8259-0caf4eb71a1d.mov

applies to channels too, so if you make a channel with the name 'general' in two different groups it gets mirrored

@liam-fitzgerald Do you have thoughts on how to address this? The team is suggesting using the group name along with the channel name in the whom to prevent duplicate entries in the pact.

As per @liam-fitzgerald via @arthyn: add an integer - the most straightforward and most-secure thing may be to associate with the group but causes some incompatibility. Maybe we hash the group name?
@patosullivan feel free to spike a few approaches.


Unable to automerge #5164

My PR #5164 updates my token logo and requires a manual review. @keone
Thank You.

merged


[BUG] cython.operators cimported in *.pxd --> undeclared in *.pyx

Minimal example would be something like
module.pxd
from libcpp.string cimport string       # "Normal" imports like this can be here

module.pyx
from cython.operator cimport dereference as deref      # This _has_ to be here and not in module.pxd

cdef string food = b'Pizza'
cdef string* ptr = &food

print("{0:x}".format(<long long>&ptr))
print(deref(ptr))

If deref is cimported in the *.pxd I get undeclared name not builtin: deref.
To my understanding these kind of operators are handled here
https://github.com/cython/cython/blob/fb02b15da178e58ff2ce3bccd29eaeecc287dda9/Cython/Compiler/ParseTreeTransforms.py#L640
There might be a reason to why this doesn't (or shouldn't) work, but I'm guessing the imports have just to look in the *.pxd for those special operators like for normal imports.
Regards
Oliver

Thanks for the report, good call.
It doesn't really fell like a clear-cut decision, though.
On the one hand, .pyx files and their corresponding .pxd files share a common namespace, so this request makes sense.
On the other hand, why should names that were cimported to be used in a .pxd file leak into the .pyx file? If a .pyx file uses something provided by an external module, it can cimport it itself, right? The question then is, should it have to?
I'm slightly leaning towards keeping the cimport explicit for the .pyx file. It should definitely be consistent with other cimports (i.e. from actual .pyx implemented modules and not only apply to Cython's internally defined tools), but it doesn't feel like the current behaviour is inherently wrong.

Personally I like moving all imports to the *.pxd file, but this of course is just personal preference.
Most users won't know the difference of cython.operator and let's say libcpp.string, so the main argument is consistency and beginner-friendliness.
I'd say this is low priority, but at least people should be able to find this issue now and understand what's happening.


Added text relating to .gitignore and credentials.csv

Also, although I did not edit these because I was not sure of the intended outcome, there are two places where text appears inside square brackets, rather than creating a clickable link.
Otherwise, this looks good to me.

CLAHub check has failed, but accepting because it's work-related.


Suggestion: "$last", "$even", "$odd" etc (v-for special properties)

Would it be relatively inexpensive to add other special properties to v-for loops?
For example (from the Angular docs):

I'm currently writing a breadcrumb component and a property like $last would simplify:
<li :class="{ active: $index + 1 == crumbs.length }">

into:
<li :class="{ active: $last }">

Interested to hear your thoughts!

Unfortunately, it is in fact relatively expensive to add these aliases, because in Vue these properties need to be reactive, so each of them would have extra initialization and memory costs. It would be wasteful to always define them on every repeated fragment.
You can define custom methods like isLast and just use it like
<li :class="{ active: isLast($index) }">

Understood. Cheers.


E711: --fix doesn't always fix and messes up quotes

ruff correctly identifies the issues with the code below
def test():
    assert "string" == None  # E711
    assert 42 == None  # E711
    assert foo("string") == None  # E711

but ruff --fix here is far from perfect:
def test():
    assert 'string' == None  # suddenly single quotes and no fix
    assert 42 == None  # no fix
    assert foo('string') is None  # fixed, but why single quotes?

Tested on 0.178.

Huh, wait, this actually does do the right thing for me (modulo the single quotes) -- I get this output:
def test():
    assert 'string' is None  # E711
    assert 42 is None  # E711
    assert foo('string') is None  # E711

Any idea on the discrepancy?

Weird, I have checked again just now in a fresh venv.
❯ cat test.py
def foo(x):
    return None

def test():
    assert "string" == None
    assert 42 == None
    assert foo("string") == None

❯ python -V; ruff --version
Python 3.10.6
ruff 0.0.182

❯ ruff --fix test.py; cat test.py
Found 202 error(s) (200 fixed, 2 remaining).
test.py:5:24: E711 Comparison to `None` should be `cond is None`
test.py:6:18: E711 Comparison to `None` should be `cond is None`
def foo(x):
    return None

def test():
    assert 'string' == None
    assert 42 == None
    assert foo('string') is None

I wonder if there are competing error fixes that are causing a conflict here.

Ah, ok, I think the issue here is that we have two conflicting rules (though Flake8 raises the same errors).
Before the is fix, we have:
foo.py:5:21: E711 comparison to None should be 'if cond is None:'
foo.py:6:15: E711 comparison to None should be 'if cond is None:'

And once that's autofixed, we get:
foo.py:5:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
foo.py:6:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)

So we just keep autofixing back and forth (hence "200 fixed").

I think E711 should be disabled when the other comparator is a literal.

Thanks for this!

(Will fix today.)

Oh nice, thanks a lot!
Also a reminder for me to include the configuration in bug reports, I do have both E and F enabled.

It's kind of tricky because the rules are fundamentally in conflict :)
Take, for example, if "abc" is None: pass.
F632 says we should change this to if "abc" == None: pass, since comparing to None with == like that is a SyntaxWarning (which I believe will be an error in the future). But if "abc" == None: pass triggers E711.
The fix I settled on is to avoid auto-fixing E711 and E712 errors that would in turn cause an F632, which I think is the best compromise. So, in this case, we would change it to if "abc" == None: pass to avoid the syntax error; but you'd then be presented with an E711 that you'd have to fix yourself or disable.


FftFixedInOut fails to process

Hi! Thank you very much for your work. I have encountered an issue that I am unsure of whether it is a bug, or am I not understanding something. I am trying to add real-time resampling to my sound processing pipeline using FftFixedInOut. My sound processing model accepts only 48khz samples, and my data is 44.1 khz, and the processing is done in 10 ms chunks. I have initialized 2 resamplers
let u = FftFixedInOut::<f32>::new(44100, 48000, 441, channels).unwrap();
let d = FftFixedInOut::<f32>::new(48000, 44100, 480, channels).unwrap();

And I am having no troubles passing a chunk of length 441, sample rate 44.1khz to my resampler, then to my model. However, I am having troubles processing the output chunk with the downsampler. For some reason, it asks for the input buffer size 640, and output buffer of size 588. I thought that maybe, chunk length of 480 is too small for the resampler, and the next possible values with the same resample ratio as (480, 441) are (640, 588) but then it doesn't make sense that there was no trouble on the upsampling processing, as the operation should be symmetrical. What do you think can be the reason of that behaviour?

PR here: https://github.com/HEnquist/rubato/pull/77
Could you try running your code with branch fix_fft_input_chunksize?

You should be able to get around it for now by asking for a chunksize of 441 (or less, it gets rounded up):

let d = FftFixedInOut::<f32>::new(48000, 44100, 441, channels).unwrap();

Yeah, I tried enforcing the chunk length but unfortunately the problem persisted.

You should be able to get around it for now by asking for a chunksize of 441 (or less, it gets rounded up):

let d = FftFixedInOut::<f32>::new(48000, 44100, 441, channels).unwrap();

That workaround solved it, thanks!

PR here: #77 Could you try running your code with branch fix_fft_input_chunksize?

Yes, this also solved it. Thank you!

Great, thanks for testing!


bug: when user also trade manually on the brokerage website, Runtime Error: Received unknown Tradier order id(s): 4444444

Expected Behavior
Same account, the user also trade on the brokerage website, and Lean engine trade in the background, if it detect an unknown order id (which come from the manual trade), it should just ignore. At most it can issue an warning, and continue.
Actual Behavior
Lean engine throw exception, and shutdown.
ERROR:: TradierBrokerage.CheckForFills(): Unable to verify all missing brokerage IDs: 4444444
...
ERROR:: Runtime Error: Received unknown Tradier order id(s): 4444444
 System.Exception: Received unknown Tradier order id(s): 4444444
Trace:: LiveTradingRealTimeHandler.Run(): Exiting thread... Exit triggered: True
...

Potential Solution
At most it can issue an warning, and continue.
Reproducing the Problem
as described in the Expected Behavior section.
System Information
Doesn't matter, it's a logic problem.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

Hi!
This is by design. Please see the issue https://github.com/QuantConnect/Lean/issues/2916 which has a detailed response and a suggested workaround too


Next release planning

Next release is currently planned to be v1.1.3. Aiming to release next week.

remaining open issues: https://github.com/mapbox/variant/milestone/4
closed issues: https://github.com/mapbox/variant/milestone/4?closed=1

Plan is to:

Release once #122 is closed (@artemp)
Re-assess if this should instead be called v1.2.x or v.2.x per https://github.com/mapbox/variant/issues/100#issuecomment-255449150 (@springmeyer)
Signoff: @jfirebaugh @kkaefer @daniel-j-h

if this should instead be called v1.2.x or v.2.x

No strong opinion, either is fine with me.

Signoff

👍

Sounds good :+1: - you can test the pre-release in osrm-backend, should be as easy as switching out the mapbox/variant directory and letting all tests /benchmarks on Travis run. From what I can see skimming the issues I expect no real differences.

👍 I confirmed osrm-backend builds fine @daniel-j-h

Ping - I just updated our libosmium dependency and remembered variant wanting to do a release, too ;) anything blocking? Anything new in the meantime?

Available at https://github.com/mapbox/variant/releases/tag/v1.1.3


feat(Algebra/Module): the tautological presentation of a module

Any A-module M admits a tautological presentation by generators and relation.
There is a generator [m] for any element m : M, and there are two types of relations:

[m₁] + [m₂] - [m₁ + m₂] = 0
a • [m] - [a • m] = 0.

[x] depends on: #18327
[x] depends on: #18408

Thanks!
maintainer merge

Thanks!
bors merge


Add roadmap for datafusion

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The issue just is a proposal.
As todos in the README file become less and less, I think it's better to have a clear roadmap for datafusion, like https://github.com/ClickHouse/ClickHouse/issues/17623.
Describe the solution you'd like
As a newer to datafusion, I don't have enough ability to complete the issue. But I'm very happy to participant in the development of roadmap！
Describe alternatives you've considered
There are two advantages to have a roadmap

Newcomers can clearly choose the tasks they can do, and then quickly participate in datafusion
Goals drive development and make datafusion stronger and stronger.

Additional context
Add any other context or screenshots about the feature request here.

Also related: https://news.ycombinator.com/item?id=28290616


Error preprocess_recipes5k

Hi
I have tried my best but without recipes5k dataset I am unable to pursuit my experimentation based on this wonderful work. Any help will be welcome.
Thanks

I found the exact copy of the database from kaggle. https://www.kaggle.com/datasets/terry9a9/recipes5k


chore: update security patch to cosmwasm

Description
Adding security patch to cosmwasm (https://forum.cosmos.network/t/upcoming-cosmwasm-security-patch-codename-cherry/10474)

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

I'll pr into your branh in a moment.


add typescript typings?

When use in a typescript project, this lib:

missing typescript typing file.
cannot find @types/ua-device package.

Please help add some d.ts file info into the lib.

please update a version and publish to npm after the PR.


MINOR: fix client_compatibility_features_test.py - DescribeAcls is al…

Kraft already supports DescribeAcls (see 5b0c58ed53c420e93957369516f34346580dac95). Hence, the flag describe-acls-supported should be True rather than False
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@rondagostino @ijuma Could you take a look?

Do the system tests pass with this change?

Do the system tests pass with this change?

yep. This system test shows following error message without this patch.
java.lang.RuntimeException: Did not expect describeAclsSupported to be supported, but it was.
	at org.apache.kafka.tools.ClientCompatibilityTest.tryFeature(ClientCompatibilityTest.java:525)
	at org.apache.kafka.tools.ClientCompatibilityTest.tryFeature(ClientCompatibilityTest.java:509)
	at org.apache.kafka.tools.ClientCompatibilityTest.testAdminClient(ClientCompatibilityTest.java:301)
	at org.apache.kafka.tools.ClientCompatibilityTest.run(ClientCompatibilityTest.java:238)
	at org.apache.kafka.tools.ClientCompatibilityTest.main(ClientCompatibilityTest.java:191)


tour: no output

Context: https://tour.golang.org/moretypes/13
After clicking the run, only

Program exited.

Cannot reproduce.


README needs "How to Lobby Steps"

I scrolled down to the caveat about the plug-in not being whitelisted on GitHub Pages, and I wanted to lobby to get this plug-in added. But how do I actually go about doing that? It would be great to give terse instructions about what passionate users can do to help asciidoctor get weight behind the movement.
I have a vested interest in lobbying for GitHub Pages Whitelist support because I use Jekyll and GitHub Pages exclusively on my tablet, so I don't have a way of post-processing the HTML using a local CI server.

But how do I actually go about doing that?

Whenever I ask GitHub about this, they always say the same thing. Send an e-mail to support using the contact form.
https://github.com/contact

I have a vested interest in lobbying for GitHub Pages Whitelist support because I use Jekyll and GitHub Pages exclusively on my tablet, so I don't have a way of post-processing the HTML using a local CI server.

There is a way to accomplish this by leveraging a combination of CI services like Travis and GitHub webhooks, but we are missing a dedicated guide on the topic. You can find some of the essential information in @eshepelyuk's blog post: http://eshepelyuk.github.io/2014/10/28/automate-github-pages-travisci.html. All we are doing is emulating the setup that GitHub Pages is using...expect we can add whatever plugins we want ;) There's no magic happening here, though GitHub Pages definitely leaves that impression.

Here's a template:

Dear GitHub,
Would you please whitelist the jekyll-asciidoc plugin for GitHub Pages? I would love to use AsciiDoc format on GitHub Pages seamlessly.

I'd be happy to add this information to the README. Great idea!

Maybe this response should be moved back up to the asciidoctor root. I'm
going to talk about my experience as a new user trying to decide between
MarkDown and AsciiDoc for my Jekyll GitHub Pages blog.
Set-up comparisons
Travis approach
I've taken a look at eshepelyuk's blog on Travis, and I'll confess I had to
read it about four times before I "got it'. Furthermore, I had to jump off
that page to two other pages with arguably just as much info. There's gotta
be a better way of easing folks into setting this up. ;)
jekyll-now approach

Fork the repo,
Make some _config.yml changes which are clearly explained in the file.

You're quite literally blogging in about 5 minutes tops. And not a PC in
sight.
Observations
I'll concede that this is because MarkDown transformation is native, and it
takes a pile of config out of the equation.
For the record, I'm not trying to blame AsciiDoc or AsciiDoctor for this,
I'm just commenting as a user which approach I'd prefer.
Suggestions
My feeling is that if you could somehow provide an "AsciiDoc-Jekyll" repo
with most of the config done or some sort of bootstrapper that folks on
supported AsciiDoctor platforms could run, it would be a really easy sell.
Maybe an Open Shift cartridge or something, with a start-up script that
guides you through could be an option?
I know Open Shift Online lets you set up a WordPress blog in this way, so
having an AsciiDoc Jekyll blog would be pretty cool to have alongside this
offering, right?
On Jan 16, 2015 7:39 PM, "Dan Allen"<EMAIL_ADDRESS>wrote:

But how do I actually go about doing that?
Whenever I ask GitHub about this, they always say the same thing. Send an
e-mail to support using the contact form.
https://github.com/contact
I have a vested interest in lobbying for GitHub Pages Whitelist support
because I use Jekyll and GitHub Pages exclusively on my tablet, so I don't
have a way of post-processing the HTML using a local CI server.
There is a way to accomplish this by leveraging a combination of CI
services like Travis and GitHub webhooks, but we are missing a dedicated
guide on the topic. You can find some of the essential information in
@eshepelyuk https://github.com/eshepelyuk's blog post:
http://eshepelyuk.github.io/2014/10/28/automate-github-pages-travisci.html.
All we are doing is emulating the setup that GitHub Pages is using...expect
we can add whatever plugins we want ;) There's no magic happening here,
though GitHub Pages definitely leaves that impression.
—
Reply to this email directly or view it on GitHub
https://github.com/asciidoctor/jekyll-asciidoc/issues/26#issuecomment-70229465
.

You can find some of the essential information in @eshepelyuk's blog post: http://eshepelyuk.github.io/2014/10/28/automate-github-pages-travisci.html.

I’ve used this as a starting point, but the presented script is not very good, so I’ve written this rake task: https://gist.github.com/jirutka/79d5810028b994018fc2
I’ll rewrite it as an includable library task and send PR to this repo.

Maybe an Open Shift cartridge or something, with a start-up script that guides you through could be an option?

Wait, what? This seems like a huge overkill for such a simple thing.

A related though this morning:  Could we create a start-up project with all the necessary files and maybe some embedded instructions that people could fork to get up and running quick?

Could we create a start-up project with all the necessary files and maybe some embedded instructions that people could fork to get up and running quick?

Good idea. I've been using a local site project to test the plugin but haven't gotten around to publishing it yet. We should join forces to put a nice starting point together (which would include some of the initial polishing that normally needs to be done). If we do it, I propose we name the repository something like jekyll-asciidoc-quickstart or something.

:+1: I can throw something together this weekend if you'd like.

Sounds great! This is exactly what the Jekyll-now repo did on the markdown
side of things. Makes that initial barrier to entry much lower.
On Jan 17, 2015 3:06 AM, "Dan Allen"<EMAIL_ADDRESS>wrote:

Could we create a start-up project with all the necessary files and maybe
some embedded instructions that people could fork to get up and running
quick?
Good idea. I've been using a local site project to test the plugin but
haven't gotten around to publishing it yet. We should join forces to put a
nice starting point together (which would include some of the initial
polishing that normally needs to be done). If we do it, I propose we name
the repository something like jekyll-asciidoc-quickstart or something.
—
Reply to this email directly or view it on GitHub
https://github.com/asciidoctor/jekyll-asciidoc/issues/26#issuecomment-70285939
.

John/Dan
Thank you both for taking on this task. Folks like me that are both new to
Jekyll and AsciiDoc will thank you for the effort.
If you can somehow make the repo you're collaborating on also compatible
with Blender and Travis, folks that primarily wanted to author on a device
other than a PC (like an Android or iOS tablet) would be well-served as
well.
At a top level:

Fork the repo.
Follow the readme.adoc which contains clear guidance how to

Configure the repo.
Configure blender.
Configure Travis CI.

Trigger a build.

Then from this point, a user could get the same functionality as the
jekyll-now repo offers except with the power of AsciiDoc:

Write .adoc on their device.
Commit using a mobile Git client.
Let Travis CI take it from there and build the site and push to
user.github.io

I'd be delighted to review the instructions and test them for you guys as a
"new user".
On Jan 17, 2015 3:10 AM, "John Ericksen"<EMAIL_ADDRESS>wrote:

[image: :+1:] I can throw something together this weekend if you'd like.
—
Reply to this email directly or view it on GitHub
https://github.com/asciidoctor/jekyll-asciidoc/issues/26#issuecomment-70286575
.

Not quite ready yet, but here's the repo: https://github.com/asciidoctor/jekyll-asciidoc-quickstart

Looks like it's coming along nicely John. Thanks for your work to get it
compatible for Travis CI.
On Jan 18, 2015 1:59 AM, "John Ericksen"<EMAIL_ADDRESS>wrote:

Not quite ready yet, but here's the repo:
https://github.com/asciidoctor/jekyll-asciidoc-quickstart
—
Reply to this email directly or view it on GitHub
https://github.com/asciidoctor/jekyll-asciidoc/issues/26#issuecomment-70372050
.

I’ll rewrite it as an includable library task, write some howto and send PR to this repo.

I eventually created a separate gem rake-jekyll with Rake tasks for Jekyll, currently just a robust task for deployment to git. I’ve already send PR to jekyll-asciidoc-quickstart.

Just my 5¢. Instead of creating separate gem containing rake tasks, we could implement Jekyll subcommand as described on their site.
This way jekyll-asciidoc would be a single dependency for having all required functionality for integrating AciiDoctor with Jekyll.

The responsibility of jekyll-asciidoc gem is converting of AsciiDoc pages using Asciidoctor to HTML. Deploying of a generated site using Git (or rsync, scp, FTP, pigeons…) is another task that is unrelated to AsciiDoc. That’s why I’ve packaged it as a separate gem — it can be used independently, not just with AsciiDoc and also not just with Travis or GitHub.

This way jekyll-asciidoc would be a single dependency for having all required functionality for integrating AciiDoctor with Jekyll.

It already is. Deploying of generated sites to GitHub Pages isn’t required to integrate Asciidoctor with Jekyll. Not everyone needs to deploy Jekyll site to GitHub Pages.
It’s just about adding one line to Gemfile and one line to Rakefile.

Instead of … rake tasks, we could implement Jekyll subcommand…

IMHO rake is better suited for a deployment task (more flexible).

Just my 5¢. Instead of creating separate gem containing rake tasks, we could implement Jekyll subcommand as described on their site directly in the current plugin.
This way jekyll-asciidoc would be a single dependency for having all required functionality for integrating AciiDoctor with Jekyll.

It would certainly make jekyll-asciidoc attractive to GitHub if it "just worked". I'm sure it would have the effect of cutting down any perceived adoption barriers on their end.

It already is. Deploying of generated sites to GitHub Pages isn’t required to integrate Asciidoctor with Jekyll. Not everyone needs to deploy Jekyll site to GitHub Pages. It’s just about adding one line to Gemfile and one line to Rakefile.

I'm not wanting to speak for @eshepelyuk here @jirutka . If I understand @eshepelyuk's intent, he wants to make jekyll-asciidoc the solution that GitHub pages uses to transform .adoc in --safe mode, and get it whitelisted. Do other whitelisted converters have the sub-command declared? If so, I would suggest adopting the idea.
@jirutka does raise a valid point that some folks just don't need this functionality. How about an option to turn this on or off? On by default?

…he wants to make jekyll-asciidoc the solution that GitHub pages uses to transform .adoc in --safe mode, and get it whitelisted.

Once GitHub whitelists the jekyll-asciidoc plugin, then the current complicated deploy task will not be needed anymore! So that’s just another reason to not copy&paste it to the plugin.

Once GitHub whitelists the jekyll-asciidoc plugin, then the current complicated deploy task will not be needed anymore! So that’s just another reason to not copy&paste it to the plugin.

OK, fair enough. Thanks for clarifying @jirutka
For the record, I've done my lobbying directly to GitHub:

Steven! Ragnarök wrote:
Thanks for the suggestion Jared. I've passed it on to our Pages team to review.
Cheers,
Steven!

Once the Repo has reached GA, I'll announce it internally at Red Hat (I really want to do it now, but don't want to "peak to early" ;) ). Things are moving towards AsciiDoc and Git for docs work, and it is currently being field tested by a docs team. I'm sure that other folks might be interested in experimenting with AsciiDoc, so what better way to do that than with a blog. ;)

Btw, I really like that we started with goals (from the blog post by @jaredmorgs)

Fork the repo: your default blog is live!
Make a few changes to the _config.yml file.
Commit and Push.
Your customized blog is live!

I wish ever issue had this level of clarity. Bravo!

I also enjoy the irony of you writing blog posts in Markdown to lobby for AsciiDoc. That makes my day :)

@mojavelinux You're welcome. Red Hat has drummed into me how to "talk to developers" and raise RFEs. I write far too many of these for the Android products I beta test ;)
And, yes,  writing blog posts in Markdown is exactly why I'm lobbying for AsciiDoc ;)
You might also be interested that I'm spreading this message to techy mailing lists inside Red Hat (you'd know the ones) and blogging about the initiative on the Customer Content Services blog. I'm pushing the message as far and wide as my networks allow. Let's make this happen!

The responsibility of jekyll-asciidoc gem is converting of AsciiDoc pages using Asciidoctor to HTML. > Deploying of a generated site using Git (or rsync, scp, FTP, pigeons…) is another task that is unrelated to AsciiDoc.

I agree, I use jekyll-asciidoc to generate my website and a bash script to push my website to amazon s3. I don't see how the publishing part directly relates to Asciidoc, it is more of a Jekyll compatibility thing.

You might also be interested that I'm spreading this message to techy mailing lists inside Red Hat (you'd know the ones) and blogging about the initiative on the Customer Content Services blog. I'm pushing the message as far and wide as my networks allow. Let's make this happen!

Thank you!!! That is really going to help add fuel to keep this :fire: burning strong.

 This is going to be awesome.

I looked at my local test site and I didn't really have anything to add, other than a sample post...though it looks like you have that underway already. Proceed!

A quick update, we're rounding out the jekyll-asciidoc-quickstart project and I believe we're close to an official release.  I went ahead and rebased and created a couple of sites off of this quickstart:
http://androidtransfuse.org
http://parceler.org
http://johncarl81.github.io
I have to say, this makes the site startup a breeze.
Any feedback would be appreciated.

By the way, it looks like newlines without spaces are triggering a <br>.  Is there a setting to only do this on double newlines?

Answered my own question regarding the linebreaks.  I need to read the READMEs better: https://github.com/asciidoctor/jekyll-asciidoc#hard-line-breaks

Anyone following this thread may be interested to note that GitLab Pages allows you to run Jekyll using a custom launch configuration (including the use of this plugin). In other words, you get exactly what you get on GitHub Pages, except you get to control how Jekyll is executed (no more black box). See https://about.gitlab.com/2016/04/07/gitlab-pages-setup/ for details.

Once GitHub whitelists the jekyll-asciidoc plugin, then this complicated deploy task will not be needed anymore!

 I have document this in the README.

I think this issue is complete. We have documented all the things mentioned in this issue and the quickstart project has been established. Anything else we need to do?

Except GitLab.com (hosted instance) is slow and unreliable as hell...

Certainly the performance and reliability of GitLab have to be taken into consideration. I was speaking purely in terms of functionality.

@jirutka : You can install a runner on your local machine: See e.g. https://github.com/sboekhoff/jekyll-asciidoc-docker#use-image-for-gitlab-ci-runner . If you use Docker, it's just 2 commands to get started.

I was able to find a number of different methods to host static sites on
GitLab.
https://gitlab.com/groups/pages
The concept of the GitLab Runner YML config file that lives in the repo is
truly an excellent way to describe how a project builds.
Was able to set up Middleman to continuously build a site we use internally
with a minimum of fuss.
On Sun, 29 May 2016 at 17:58 Dan Allen<EMAIL_ADDRESS>wrote:

Anyone following this thread may be interested to note that GitLab Pages
allows you to run Jekyll using a custom launch configuration (including the
use of this plugin). In other words, you get exactly what you get on GitHub
Pages, except you get to control how Jekyll is executed (no more black
box). See https://about.gitlab.com/2016/04/07/gitlab-pages-setup/ for
details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asciidoctor/jekyll-asciidoc/issues/26#issuecomment-222347930,
or mute the thread
https://github.com/notifications/unsubscribe/AA6J2ZEHbK8NsEA2OvJiP0ha5226wzlcks5qGUcagaJpZM4DTDr3
.

--
Sent from Mobile.

https://github.com/asciidoctor/jekyll-asciidoc/issues/209
https://github.com/asciidoctor/jekyll-asciidoc/issues/26
https://github.com/github/pages-gem/issues/624


chore: delete old workflow add sync-files

Related link: https://github.com/autowarefoundation/autoware-github-actions/pull/59

Done!

@kenji-miyake Thank you for your help!

@kenji-miyake Could you change main repository to tier4/universe?

Sure, done!


Fix the unit test and lint

/kind improvement

We're currently processing your upload.  This comment will be updated when the results are available.


feat:refactor dashboard

issue 76

Thanks, Bilin! There's a recent PR #81 which added a few functionalities on the dashboard. I'm not sure if your PR has considered it. If not, can you please double-check to support/beatify those as well?

ok, I will rebase...


cleanup workspace

This adds a astria- prefix to all crate names and their directories (matching astria-conductor) for consistency.
It also removes some stragglers.

It looks like this might not relocate some of the github workflows when directories renamed?

Yeah, I specifically left out the github workflows when doing the merge (or rather, deleted them). The next and hopefully final PR to bring this all together will be fresh github workflows.


Disable style analyzers

I love the refactoring capabilities of this extension but I'm using StyleCopAnalyzers with a custom style guideline so I'd like to disable all the style-related recommendations of Refactoring Essentials.

Disabling some analyzers would work through custom rule sets:
https://github.com/icsharpcode/RefactoringEssentials/wiki/Custom-Rule-Sets-for-Analyzers
Does it help?


plaxrun standard output report plugin is incorrectly named from goreleaser

rename report_stdout -> plaxrun_report_stdout

Fix name of the plaxrun-report-stdout plugin


Congratulations Akshay 🍻

I figured this is the best way to chat on GItHub :P

Hahaha.
Certainly @harshit-budhraja
Thank you so much.


15 vulnerabilities

~ % sudo npm install sails -g

changed 229 packages, and audited 230 packages in 1s
1 package is looking for funding
run npm fund for details
15 vulnerabilities (1 low, 7 moderate, 6 high, 1 critical)
To address all issues possible (including breaking changes), run:
npm audit fix --force
Some issues need review, and may require choosing
a different dependency.
Run npm audit for details.

Thank you @mutaebalqahtani, we are looking into these.


nested alternatives

I think I forgot to implement/test alternatives nested in other alternatives

After writing a test for this behavior based on the nested alt examples in WritingWithInk.md, I've mostly come to the realization that nesting in this manner gets complicated and unreadable. With that being the case, and the implementation being pretty tricky with the quick-and-dirty way I've implemented the Util.findEnclosure method family, this feature might hit the chopping block.

See this commit for the test I wrote, and why the syntax is problematic--I'm not even sure what the expected output from Inkle's nesting example is! Can you process nested cycles and sequences in your head? Because I sure can't.

This ended up implemented as part of the great Parsing Overhaul. It seems to work!