Is there any way to check if the video needs to embed the thumbnail before writing the video information to download_archive.txt?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
I use yt-dlp to download videos. After the video is downloaded, I use --embed-thumbnail to embed the thumbnail in video. However, sometimes the network is not good, the thumbnail is not downloaded, only the video is downloaded. yt-dlp can't find the thumbnail, so it won't embed the thumbnail in the video, but write the video information into download_archive.txt.
Does yt-dlp provide any parameter to check if the video needs to embed the thumbnail before writing the video information to download_archive.txt? If the video need to embed the thumbnail, but the thumbnail missing, skip the video, and don't record it in download_archive.txt.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

That should not happen afair unless you are passing -i. Pls show verbose log demonstrating the issue.

That should not happen afair unless you are passing -i. Pls show verbose log demonstrating the issue.

Sure. Here it is.
[debug] Command-line config: ['-f', 'bestvideo*', '-i', 'https://space.bilibili.com/330443044', '--embed-thumbnail', '--embed-metadata', '--download-archive', '/opt/yt-dlp/哔哩哔哩/训练吧/archive.txt', '--max-downloads', '100', '--windows-filenames', '--min-sleep-interval', '30', '--max-sleep-interval', '60', '--merge-output-format', 'mp4', '--cookies', '/opt/yt-dlp/cookies/www.bilibili.com_cookies.txt', '-o', '/opt/yt-dlp/哔哩哔哩/训练吧/[%(upload_date)s] %(title).200B [%(id)s].%(ext)s', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8 (No ANSI), error utf-8 (No ANSI), screen utf-8 (No ANSI)
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [ff0779267] (pip)
[debug] Python 3.8.10 (CPython x86_64 64bit) - Linux-5.4.0-171-generic-x86_64-with-glibc2.29 (OpenSSL 1.1.1f  31 Mar 2020, glibc 2.31)
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7
[debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2019.11.28, mutagen-1.47.0, requests-2.31.0, secretstorage-2.3.1, sqlite3-3.31.1, urllib3-2.0.5, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1810 extractors
[debug] Loading archive file '/opt/yt-dlp/哔哩哔哩/训练吧/archive.txt'
[BilibiliSpaceVideo] Extracting URL: https://space.bilibili.com/330443044
[BilibiliSpaceVideo] A channel URL was given. Only the channel's videos will be downloaded. To download audios, add a "/audio" to the URL
[BilibiliSpaceVideo] 330443044: Downloading JSON metadata
[BilibiliSpaceVideo] 330443044: Downloading page 0
[download] Downloading playlist: 330443044
[BilibiliSpaceVideo] 330443044: Downloading page 1
[BilibiliSpaceVideo] 330443044: Downloading page 2
[BilibiliSpaceVideo] 330443044: Downloading page 3
[BilibiliSpaceVideo] 330443044: Downloading page 4
[BilibiliSpaceVideo] 330443044: Downloading page 5
[BilibiliSpaceVideo] 330443044: Downloading page 6
[BilibiliSpaceVideo] 330443044: Downloading page 7
[BilibiliSpaceVideo] 330443044: Downloading page 8
[BilibiliSpaceVideo] 330443044: Downloading page 9
[BilibiliSpaceVideo] 330443044: Downloading page 10
[BilibiliSpaceVideo] 330443044: Downloading page 11
[BilibiliSpaceVideo] 330443044: Downloading page 12
[BilibiliSpaceVideo] 330443044: Downloading page 13
[BilibiliSpaceVideo] 330443044: Downloading page 14
[BilibiliSpaceVideo] 330443044: Downloading page 15
[BilibiliSpaceVideo] 330443044: Downloading page 16
[BilibiliSpaceVideo] 330443044: Downloading page 17
[BilibiliSpaceVideo] 330443044: Downloading page 18
[BilibiliSpaceVideo] 330443044: Downloading page 19
[BilibiliSpaceVideo] 330443044: Downloading page 20
[BilibiliSpaceVideo] 330443044: Downloading page 21
[BilibiliSpaceVideo] 330443044: Downloading page 22
[BilibiliSpaceVideo] 330443044: Downloading page 23
[BilibiliSpaceVideo] 330443044: Downloading page 24
[BilibiliSpaceVideo] 330443044: Downloading page 25
[info] There are no playlist thumbnails to download
[BilibiliSpaceVideo] Playlist 330443044: Downloading 752 items of 752
[download] BV16D421H7ME: has already been recorded in the archive
[download] BV12J4m1p7cg: has already been recorded in the archive
[download] BV1Vx4y1a7j7: has already been recorded in the archive
[download] BV1ax421m7NU: has already been recorded in the archive
[download] BV1mK421h7nt: has already been recorded in the archive
[download] BV16J4m1G7Hr: has already been recorded in the archive
[download] BV1qu4m1K7XD: has already been recorded in the archive
[download] Downloading item 723 of 752
[BiliBili] Extracting URL: https://www.bilibili.com/video/BV1Bt411g7cY
[BiliBili] 1Bt411g7cY: Downloading webpage
[BiliBili] BV1Bt411g7cY: Extracting videos in anthology
[BiliBili] 59590933: Extracting chapters
[BiliBili] Format(s) 1080P 高码率 are missing; you have to login or become premium member to download them. Use --cookies-from-browser or --cookies for the authentication. See  https://github.com/yt-dlp/yt-dlp/wiki/FAQ#how-do-i-pass-cookies-to-yt-dlp  for how to manually pass cookies
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[info] BV1Bt411g7cY: Downloading 1 format(s): 30080
[info] Downloading video thumbnail 0 ...
WARNING: Unable to download video thumbnail 0: (<urllib3.connection.HTTPConnection object at 0x7ff74c421520>, 'Connection to i1.hdslb.com timed out. (connect timeout=20.0)')
[debug] Invoking http downloader on "https://upos-sz-mirrorali.bilivideo.com/upgcxcode/92/53/103815392/103815392-1-30080.m4s?e=ig8euxZM2rNcNbdlhoNvNC8BqJIzNbfqXBvEqxTEto8BTrNvN0GvT90W5JZMkX_YN0MvXg8gNEV4NC8xNEV4N03eN0B5tZlqNxTEto8BTrNvNeZVuJ10Kj_g2UB02J0mN0B5tZlqNCNEto8BTrNvNC7MTX502C8f2jmMQJ6mqF2fka1mqx6gqj0eN0B599M=&uipk=5&nbs=1&deadline=1714054116&gen=playurlv2&os=alibv&oi=1974810531&trid=00000832d68791ce4878b083f5683ce0133bu&mid=339739774539&platform=pc&upsig=606bad9c5734cf5526cb546807855599&uparams=e,uipk,nbs,deadline,gen,os,oi,trid,mid,platform&bvc=vod&nettype=0&orderid=0,3&buvid=DF3DA0BF-19B0-EE25-D503-DD08B7C74AF915877infoc&build=0&f=u_0_0&agrr=1&bw=131577&logo=80000000"
[download] Sleeping 41.16 seconds ...
[download] Destination: /opt/yt-dlp/哔哩哔哩/训练吧/[20190717] 道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮 [BV1Bt411g7cY].mp4

[download]   0.0% of    9.79MiB at  Unknown B/s ETA 00:10
[download]   0.0% of    9.79MiB at  908.05KiB/s ETA 00:11
[download]   0.1% of    9.79MiB at    1.23MiB/s ETA 00:07
[download]   0.1% of    9.79MiB at    1.84MiB/s ETA 00:05
[download]   0.3% of    9.79MiB at    2.82MiB/s ETA 00:03
[download]   0.6% of    9.79MiB at    1.33MiB/s ETA 00:07
[download]   1.3% of    9.79MiB at    1.32MiB/s ETA 00:07
[download]   2.5% of    9.79MiB at    1.61MiB/s ETA 00:05
[download]   5.1% of    9.79MiB at    2.37MiB/s ETA 00:03
[download]  10.2% of    9.79MiB at    3.54MiB/s ETA 00:02
[download]  20.4% of    9.79MiB at    2.89MiB/s ETA 00:02
[download]  40.9% of    9.79MiB at    2.95MiB/s ETA 00:01
[download]  71.7% of    9.79MiB at    2.97MiB/s ETA 00:00
[download] 100.0% of    9.79MiB at    3.28MiB/s ETA 00:00
[download] 100% of    9.79MiB in 00:00:03 at 2.76MiB/s
[Metadata] Adding metadata to "/opt/yt-dlp/哔哩哔哩/训练吧/[20190717] 道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮 [BV1Bt411g7cY].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:/opt/yt-dlp/哔哩哔哩/训练吧/[20190717] 道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮 [BV1Bt411g7cY].mp4' -map 0 -dn -ignore_unknown -c copy -write_id3v1 1 -metadata 'title=道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮' -metadata date=20190717 -metadata 'description=道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮' -metadata 'synopsis=道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮' -metadata purl=https://www.bilibili.com/video/BV1Bt411g7cY -metadata comment=https://www.bilibili.com/video/BV1Bt411g7cY -metadata 'artist=训练吧' -movflags +faststart 'file:/opt/yt-dlp/哔哩哔哩/训练吧/[20190717] 道家养生动作：握固，改善失眠，睡前3分钟，一觉到天亮 [BV1Bt411g7cY].temp.mp4'
[EmbedThumbnail] There aren't any thumbnails to embed
[debug] Adding to archive: bilibili BV1Bt411g7cY
[download] Downloading item 724 of 752
[BiliBili] Extracting URL: https://www.bilibili.com/video/BV1zt411G7sT
[BiliBili] 1zt411G7sT: Downloading webpage
[BiliBili] BV1zt411G7sT: Extracting videos in anthology
[BiliBili] 59457668: Extracting chapters

unless you are passing -i

[debug] Command-line config: [..., '-i', ...

You are specifically asking yt-dlp to continue processing videos despite any errors

unless you are passing -i

[debug] Command-line config: [..., '-i', ...

You are specifically asking yt-dlp to continue processing videos despite any errors

I see what the problem was because I added -i, thank you very much!


vcpkg soci crashes on session::close()

#pragma once

//#include <soci/soci.h>
//#include <soci/postgresql/soci-postgresql.h>
#include "soci/soci.h"
#include "soci/postgresql/soci-postgresql.h"
#include <iostream>
#include <istream>
#include <ostream>
#include <string>
#include <exception>
#include <functional>

using namespace soci;
using namespace std;

int main()
{
    try
    {
        session sql(postgresql, "<conn string here>");
        if (sql.is_connected()) {
			cout << "Connected successfully\n";
		}
        else {
			cout << "Not connected\n";
		}

        sql.close();

        //int count;
        //sql << "select count(*) from users", into(count);

        //cout << "We have " << count << " entries in users.\n";
    }
    catch (exception const& e)
    {
        cerr << "Error: " << e.what() << '\n';
    }
    catch (soci_error const& e)
    {
		cerr << "Error: " << e.what() << '\n';
	}

}

this code snippet generates an access violation reading location from soci-test.exe (libcrypto-3-x64.dll) when sql.close() is called or the session object enters its destructor
(connection string has been hidden for obvious reasons)
#pragma once

//#include <soci/soci.h>
//#include <soci/postgresql/soci-postgresql.h>
#include "soci/soci.h"
#include "soci/postgresql/soci-postgresql.h"
#include <iostream>
#include <istream>
#include <ostream>
#include <string>
#include <exception>
#include <functional>

using namespace soci;
using namespace std;

int main()
{
    try
    {
        session* sql = new session(postgresql, "<conn string here>");
        if (sql->is_connected()) {
			cout << "Connected successfully\n";
		}
        else {
			cout << "Not connected\n";
		}

        sql = nullptr;

        //int count;
        //sql << "select count(*) from users", into(count);

        //cout << "We have " << count << " entries in users.\n";
    }
    catch (exception const& e)
    {
        cerr << "Error: " << e.what() << '\n';
    }
    catch (soci_error const& e)
    {
		cerr << "Error: " << e.what() << '\n';
	}

}

what i found is that initializing sql as a session* through the constructor of session and then later on instead of sql.close() doing sql = nullptr doesn't throw, with the only catch being that this is obviously a memory leak (delete sql before sql = nullptr throws the same error)
NOTE:
doing free(sql) works like a charm, so i suppose i'll be using that for now

Looks like a build options mismatch, I'm pretty sure that if you build SOCI yourself your problem would go away.
And I'm sorry, but problems like this are almost impossible to diagnose remotely, you need to ensure that you use the same compiler options for your code as were used for the package and there is nothing we can do about it, so it's not useful to keep this open.


Adds margins to InfoPannel for older OS

Previous PR that has been closed without merging: #539
Based on #540, older OS still using padding around ScrollView which results in a hard clip. Technically, it's possible to add margins inside ScrollView, so, of course, older OS deserves that margin🤣.
The code here uses safe area to add margins which might be the same with the new margin API, but supports older OS.

@LiYanan2004 can you show me what this looks like on MacOS < 14? Thanks

Unfortunately, I have no device running macOS 13. But that piece of code should look the same as the latest OS.


Add learning d4rl mujoco dataset for *-random-v0/v2

Hi,
thanks for the excellent repo, I would like to ask could you add the test of *-expert-v2 data?
I just tried to learning halfcheetah-expert-v0 dataset on AWAC, but unfortunately it learns nearly nothing, if you could add some tests on expert dataset, it would be quite helpful, thanks!

Thank you for your request. I'm focusing on filling -v0 datasets for journal submission. Once it's published, more datasets including -expert-v0 will be added.
Regarding AWAC training, I've observed that AWAC is not really robust for offline training. I'd recommend IQL unless you really need AWAC.


Using class properties not implemented in MUI components

When running this in my webpack configuration I had this happening:
Warning: Material-UI: the key `rootLabelIcon` provided to the classes property is not implemented in Tab.
You can only override one of the following: root,labelIcon,textColorInherit,textColorPrimary,textColorPrimarySelected,textColorPrimaryDisabled,textColorSecondary,textColorSecondarySelected,textColorSecondaryDisabled,textColorInheritSelected,textColorInheritDisabled,fullWidth,wrapper,labelContainer,label,labelWrapped

Warning: Material-UI: the key `rootInheritSelected` provided to the classes property is not implemented in Tab.
You can only override one of the following: root,labelIcon,textColorInherit,textColorPrimary,textColorPrimarySelected,textColorPrimaryDisabled,textColorSecondary,textColorSecondarySelected,textColorSecondaryDisabled,textColorInheritSelected,textColorInheritDisabled,fullWidth,wrapper,labelContainer,label,labelWrapped

Warning: Material-UI: the key `inkbar` provided to the classes property is not implemented in Input.
You can only override one of the following: root,formControl,focused,disabled,underline,error,multiline,fullWidth,input,inputMarginDense,inputDisabled,inputMultiline,inputType,inputTypeSearch

I don't know why this doesn't happen when running react-scripts start, but looking at the MUI code from beta36 I noticed that the components actually don't have those properties. They are defined inside their .d.ts counterparts, but I don't think that react-scripts are considering those...
Either way, I noticed that those props were actually removed after from the .d.ts so it is better to use the right ones even now.
I'm about to open a PR that will solve this.

Hello @hackedbellini ,
And thank your for your interest in using our product.
Sorry for the late response, this is due to the fact that our product is using<EMAIL_ADDRESS>and not beta 36. In beta 34 we have those properties.
Today or next week we are going to make an update to the latest version of material-ui (beta 41, or beta 42 if they are going to launch beta 42 before our update).
Best,
Manu

Hi @EINazare
Actually this was an issue even in beta34. Like I described, the properties are not in the .js files but only in the .ts files. Don't know if the react-scripts were using the .ts, but when using my custom webpack deployment I was getting those issues.
If you are going to update to the latest mui maybe you should take a look at my PRs first? I created a PR about 2 weeks ago updating this to the latest mui of that day: #13
Note that that PR requires my #12 to work also. I could have add both patches in the same PR, but wanted to separate this "already existing issue" from the "update mui" one.

Hello @hackedbellini ,
I've seen your PR and we are going to do the same as you've done in your #12.
In the #13, i've seen some changes which i think it's a matter of choice, and not going to add in our code.
Best,
Manu

@EINazare what exactly is a matter of choice? All changes there were made to keep the previous behavior.
If you are talking about the spacing=16, which is one change that looks like "a matter of choice", in v1.0.0-beta.39 they changed the default spacing from 16 to 0 and, whithout this, you theme would break. Try to CTRL+F for spacing in this page: https://github.com/mui-org/material-ui/releases.
Again, all I've done was to fix api changes to make your theme continuing to work and keep the same behavior/look'n'feel. All of them were described in the releases page also


ivy: stepper component does not render when being used in a web component

Reproduction
A minimal reproduction is available on this repository. Just run npm install and npm test.
You will notice that it will render properly when you add enableIvy: false property to angularCompilerOptions in tsconfig.json
Steps to reproduce:

Import MatStepperModule in you web component module
Create a <mat-vertical-stepper> or <mat-horizontal-stepper> component inside your component.
Build with Ivy enabled
Import the generated scripts in another HTML file
Serve the files using any web server

Expected Behavior
The stepper should render properly.

Actual Behavior
Only the root element is being rendered. Lifecycle hooks are not being executed either.

Environment

Angular: 9.0.1
CDK/Material: 9.0.1
Browser(s):

Chromium 80.0.3987.116
Firefox Developer Edition 74.0b4

Operating System: Arch Linux with Linux kernel 5.5.4-arch1-1

Hello! Looks like this works for me with Angular v9.0.7. Could it be possible that this just didn't work in the past due to a bug in Angular? (I haven't searched for related issues/commits).
On my end, I just cloned your repro, ran yarn and ran yarn test . The stepper renders as expected w/ ripples and behavior. Can you double-check and update the reproduction if needed? Please keep us updated here. I'm closing this in the meanwhile, but we're happy to re-open. Thanks!

It is indeed rendering properly with Ivy enabled on the latest version (9.1.9) of Angular. Thanks!


feat(shipper): add evri carrier

Proposed change

Add Evri carrier
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[x] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR fixes or closes issue: fixes #719

Codecov Report

Merging #720 (db5c78f) into dev (6f319a7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #720   +/-   ##
=======================================
  Coverage   97.75%   97.75%
=======================================
  Files           8        8
  Lines        1469     1469
=======================================
  Hits         1436     1436
  Misses         33       33

Impacted Files
Coverage Δ

custom_components/mail_and_packages/const.py
100.00% <ø> (ø)


Implement Clone for StorageChanges

Pretty simple PR. Implements Clone trait for StorageChanges struct.

bot merge

@crackcomm could you please merge master and fix the compilation?

@crackcomm please merge master and resolve the conflicts.

Closed due to it being stale for while.


Stremio IPTV by dexter21767

Addon Manifest URL
https://2ecbbd610840-stremio-iptv.baby-beamup.club/manifest.json
Addon Description
M3U list player for IPTV.

Uses https://github.com/iptv-org/iptv so it's obviously good


SimpliSafe alarm not showing up

Home Assistant release with the issue:

0.90.1
Last working Home Assistant release (if known):
0.80
Operating environment (Hass.io/Docker/Windows/etc.):

Raspberry Pi 2 running HASS.IO
Component/platform:

Simplisafe
https://www.home-assistant.io/components/simplisafe/
Description of problem:
Getting the following error:
Invalid credentials provided
7:58 PM components/simplisafe/init.py (ERROR)
Log Details (ERROR)
Fri Mar 22 2019 19:58:30 GMT-0400 (EDT)
Invalid credentials provided
However the login details are correct.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

# Alarm
simplisafe:
  accounts:
    - username<EMAIL_ADDRESS>      password: **********

Traceback (if applicable):

Additional information:

@bachya Is this a recurrence of #19530?

@robbiet480 Yes, it appears that it is.  It looks like removing the SimpliSafe entry from /config/.storage/core.config_entries and then restarting fixes the problem.  A potential remedy would be upon upgrade to a new version maybe kill that entry completely?

I haven’t experienced missing entities recently. @mbriney, confirming that deleting the config entry and re-adding it fixed the issue?

@bachya it's even easier than that.  If you just remove the entry in core.config_entries for SimpliSafe, upon reboot it will re-generate the entry with a new token that works.

Thanks for the report.


DATAJDBC-106 - Support to specify a database object name using annotation

Added @Table
Added @Column

I've fixed the DATAJDBC-106.
WDYT?

Could not create test container on Travis CI...

I've rebased.

Hi, we have a similar library as yours and watching improvements on this project. We had to make a decision about using annotations. We decided to use JPA annotations by providing extension clarifications in our team. The best part of this decision is that I could start to use Hibernate base code generators. Our entire ddl's of tables are generated by these annotations. These annotations are including index, not null, multiple primary column etc.. support on the fly. It might be worth to think about this decision. :)

That's merged. Thanks

@cemo I don't like the idea of using JPA annotations to much. They would include lots of stuff that does nothing for Spring Data JDBC and eventually we'd still have to add our own annotations.
Of course being able to leverage existing tools is nice.


Handle inbound SMS

See gist: https://gist.github.com/adambutler/2164da265280cc0be3970ddeb4c75576

https://gist.github.com/judy2k/763acbecaf9e324198e263a98851c5d0

Tutorials and documentation for handling inbound sms have been added to NDP(now ADP).


[FLINK-11801] [table-api] Port SqlParserException to flink-table-api-java

What is the purpose of the change
Port SqlParserException to flink-table-api-java
SqlParserException is used in FlinkPlannerImpl for sql parsing. We will have another FlinkPlannerImpl in flink-table-planner-blink.
Because SqlParserException is an API level exception, we should move it to flink-table-api-java to avoid coping it to flink-table-planner-blink.
As @twalthr mentioned in #7886, we would move it to api-java for now, and move to common when it is really required across many different modules.
Brief change log

Port SqlParserException to flink-table-api-java

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks @twalthr .
I accidentally pushed the wrong branch to apache/flink, so I have to create a new pull request for this ;-)

Will merge this when travis green.


encrypt hots、name、ip,not just passwords.

can you encrypt the whole ssh connection.

I think it's enough to encrypt the password.

Hi - sorry to comment on such an old post - but if I have a password in a login script it is showing in my config in plain text.
Can you please encrypt the login script too?


Create a Use Form Hook

Using the concepts of Hooks, create a one hook to control input field events.

Pull request approved


Update jquery v3.3.1 to v3.4.0

This is an enhancement.
Updated external file.
Summary
Update jquery library.
Previous version 3.3.1.
Current version 3.4.0.
Context
It's related to #2127

Thanks @torrocus.
Can you run npm run build:js and commit the updated main.min.js as well. That's the only thing I see missing at first glance.


Algolia query is empty

Now that I've gotten the index imported I have a few questions:

I can see that when I perform an ...entries(search...) in craft, algolia gets a request, but the query is always empty. Is there any specific config I've missed?

The contents of matrix elements aren't indexed, just the matrix element itself, is there any way to index this as well?

Scout doesn’t actually do the searches, only the indexing, this is better done using the JavaScript library as it’s faster or if you really need it in php you can always extend Scout for this. I don’t need this functionality so that’s why I didn’t build it

You can do this in the transformer by looping through your matrix and returning the fields you want.


Webhooks / Slack notifications

As a user
I want to be notified through webhooks / on slack about new activity
So I can stay up to date with activity without having to go to the website.

As a user
I want to get a mention in Slack if someone gave kudo's to me
As a user
I want to see how much kudo's are left until we reach our next goal in Slack
As a user
I want to get a Slack notification if we have reached our next goal
As a user
I want a link in the Slack message to the kudo's website


Wrapped errors diff output is confusing

Two errors with the same messsage but constructed differently when compared produce a diff that looks identical
https://play.golang.org/p/i3y-6_rqonr
package main

import (
	"fmt"
	"errors"

	"github.com/google/go-cmp/cmp"
)

func main() {
	e1 := errors.New("Hello world!")
	e2 := fmt.Errorf("Hello %w", errors.New("world!"))

	fmt.Println(cmp.Diff(e1, e2))
}

Results in
 interface{}(
- 	e"Hello world!",
+ 	e"Hello world!",
  )

Thanks for the report. It is a known issue with the reporter that it needs to do more work trying to disambiguate cases like these.

Closing as duplicate of #194


[Bug] Applying N entity operation(s) log block_hash broken on Substreams

Bug report
I'm running a Substreams only config https://github.com/streamingfast/graph-node-dev/blob/master/config/substreams-generic.toml.
I started Uniswap V3 Substreams powered Subgraph on this. When the log Applying 22 entity operation(s) is displayed, the block_hash value is wrong. We get the hex representation of a String hexadecimal value, essentially something like this happen: let input = b"61c558e1ba724af7924f849c0dc390037b529a0c1b37ff277c6b34c180d8d6ed"; hex::encode(input).
I imagine this is specific to chain/substreams, I never saw that before on other chain(s) implementation.
This is against master branch.
Relevant log output
Oct 27 16:49:57.987 INFO Applying 78 entity operation(s), block_hash: 0x31383536616466343230303235656561616330393963653762643532303266666266383836613533383536343638303235626666643634316462323433323133, block_number: 12388136, sgd: 1, subgraph_id: QmQJovmQLigEwkMWGjMT8GbeS2gjDytqWCGL58BEhLu9Ag, component: SubgraphInstanceManager
Oct 27 16:49:58.071 INFO Applying 72 entity operation(s), block_hash: 0x61346665633532336133383263353639313739303939656535623034366431636537363864306239366334316266326436343632393238613339373432616133, block_number: 12388137, sgd: 1, subgraph_id: QmQJovmQLigEwkMWGjMT8GbeS2gjDytqWCGL58BEhLu9Ag, component: SubgraphInstanceManager
Oct 27 16:49:58.140 INFO Applying 59 entity operation(s), block_hash: 0x37663831656262323139316663633262353433386631643930326139653735336435636330623439313430373635666632313237313062633061303934376562, block_number: 12388138, sgd: 1, subgraph_id: QmQJovmQLigEwkMWGjMT8GbeS2gjDytqWCGL58BEhLu9Ag, component: SubgraphInstanceManager
Oct 27 16:49:58.220 INFO Applying 56 entity operation(s), block_hash: 0x37623963333664663938393031343562333161383461666437643133646262336230373461363438373531363838346365633838336338656563646362613838, block_number: 12388139, sgd: 1, subgraph_id: QmQJovmQLigEwkMWGjMT8GbeS2gjDytqWCGL58BEhLu9Ag, component: SubgraphInstanceManager

IPFS hash
No response
Subgraph name or link to explorer
No response
Some information to help us out

[ ] Tick this box if this bug is caused by a regression found in the latest release.
[ ] Tick this box if this bug is specific to the hosted service.
[X] I have searched the issue tracker to make sure this issue is not a duplicate.

OS information
None

$ to_ascii<PHONE_NUMBER>6466343230303235656561616330393963653762643532303266666266383836613533383536343638303235626666643634316462323433323133
1856adf420025eeaac099ce7bd5202ffbf886a53856468025bffd641db243213

And 1856adf420025eeaac099ce7bd5202ffbf886a53856468025bffd641db243213 is the correct block hash for block number 12388136.

cc @mangas

Also ran into it. This PR should fix it I think: https://github.com/graphprotocol/graph-node/pull/4967

Much appreciated @YaroShkvorets

@maoueh from a near substreams I get the following on the proto Clock.id:
9822064: e311c8c19037135b5b645350d282d8ba452f55b7b8b96f8b16721817cce6d5de

How is this encoded? The block hash should be GHPGzu3sQxGUk4SAiCykUJT9hP9Bc89J188LNJ1R21VX
Are these encoded different per chain?

Yes indeed that's an interesting problem indeed and this is because substreams clock is chain agnostic and hence it couldn't know that it should base58 the block's hash and instead does a hex(block.hash).
$ to_base58 -hex 886d431b0ff918e8f21e38af93952176b8d0d3f14c85aab2941c386b0ea945dd
ABZ5aMBM8B1Y6a4WirQJgacBT5r4FDBaDNWr38mzyPKa

That's something I oversight when suggesting the clock thing.

Hashes are stored decoded as bytes, so it shouldn't matter how they arrive as long as they are decoded properly, no?
The issue is that Near wants block hash in Base58 so BlockHash::to_string() needs to be BlockchainKind-aware.


Separate kernel finders per setting

Codecov Report

Merging #12153 (3d04e35) into main (59225d4) will decrease coverage by 1%.
The diff coverage is 89%.

:exclamation: Current head 3d04e35 differs from pull request most recent head 73ceac2. Consider uploading reports for the commit 73ceac2 to get more accurate results

@@           Coverage Diff           @@
##            main   #12153    +/-   ##
=======================================
- Coverage     70%      68%    -2%
=======================================
  Files        498      499     +1
  Lines      31420    31544   +124
  Branches    4923     4931     +8
=======================================
- Hits       22088    21702   -386
- Misses      7453     7940   +487
- Partials    1879     1902    +23

Impacted Files
Coverage Δ

...lPythonAndRelatedNonPythonKernelSpecFinder.node.ts
84% <71%> (-6%)
:arrow_down:

...honAndRelatedNonPythonKernelSpecFinder.old.node.ts
90% <90%> (ø)

...raw/finder/contributedLocalPythonEnvFinder.node.ts
86% <100%> (-2%)
:arrow_down:

src/kernels/serviceRegistry.node.ts
100% <100%> (ø)

src/standalone/api/kernelApi.ts
9% <0%> (-63%)
:arrow_down:

src/kernels/errors/jupyterKernelDependencyError.ts
57% <0%> (-43%)
:arrow_down:

src/standalone/api/kernelConnectionWrapper.ts
6% <0%> (-42%)
:arrow_down:

src/notebooks/controllers/kernelSelector.ts
28% <0%> (-29%)
:arrow_down:

src/platform/common/dataFrameScriptGenerator.ts
62% <0%> (-29%)
:arrow_down:

src/kernels/variables/pythonVariableRequester.ts
32% <0%> (-24%)
:arrow_down:

... and 56 more


[Foundations] Improve Shadows documentation and DarkMode elevations

We don't provide DarkMode shadows and the shadows are not visible in DarkMode.

https://spark.adevinta.com/1186e1705/p/39675a-elevation

https://adevinta.slack.com/archives/C04LNCEMMUN/p1716819958409859

[ ] Improve the existing documentation based on RE work

[x] Create DarkMode shadows

[x] Update Foundations

[ ] Document in ZH

[ ] Share the improvement

New answers here: https://adevinta.slack.com/archives/C04LNCEMMUN/p1716819958409859

Spark Foundation branch can be found here:

https://www.figma.com/design/ezqkDE3LqYrek9MvYnr4dR/branch/IhuHDOyPbBmqUTXw3T5PG9/Spark-Foundations?m=auto

Design exploration:

https://www.figma.com/design/epxpKoREcESdwiXgqJPzZY/Test-Spark?node-id=1193-16781&t=SH8SyxlNu672kvND-0

Current solution - not perfect :

Android uses the material shadow
iOS uses white color in dark mode

assigned to @sarah hattab


microk8s service stop working on external devices on the same network

Summary

I have a microservice which works perfectly in my localhost. I'm able to access to it from my localhost and others external machines on the same network. However, after around 15 minutes it stopped working and I'm not able to access to the service from just external machines. (In local host it works fine, always can access to the service). Moreover, if i restart my localhost the service again is able to the external machines but just for 15 minutes.
What Should Happen Instead?

I should be able to access to the service from external devices always I need (as in my localhost that never stopped working) and not just for 15 minutes.
Reproduction Steps

Install microk8s 1.24/stable
Enable dns and metrics-server
Access to the service through http:my_ip_localhost:port
reboot

Introspection Report

inspection-report-20220926_110707.tar.gz

How do you access the service from outside the cluster?  What are you using, ingress? Or port forwarding? Or node port?

I'm using Node Port to access the service. The connection is refused when try it with Postman; moreover I notice that I can not access to the localhost via ssh after that 15 minutes also.

Hi, thanks for your answer. Im running microk8s in a VM with CentOs. I suspect it is a network problem because today I notice that If I just restart the network I have the same problem.

Yeah i guess it has something to do with the host rather than microk8s.


Question: Removing vehicle from database

I had been using Teslamate with 2 cars in my account. Got rid of one of the cars. Is it possible / how do I remove that car from the database?

Easiest way is to run docker exec -it postgresql psql -U teslamate -W teslamate
then just do a select * from cars; and find your old car... look at the id and then do a delete from cars where id = # replacing # /w the right car id.

Note that if you only delete the rows in the cars table, you'll run into internal errors when visiting TeslaMate's settings page. To fix this, run:
DELETE FROM car_settings WHERE id = 1234;

(where 1234 is the ID removed from the cars table).
To summarize:
docker exec -it my_database_container psql -U teslamate -W teslamate

SELECT id, vin FROM cars;

 id |        vin
----+-------------------
  1 | 5YJ3E1EA2HF123456
  2 | 5YJYGDEF7LF456789
(2 rows)

Assuming 5YJ3E1EA2HF123456 must be removed:
DELETE FROM cars WHERE id = 1;
DELETE FROM car_settings WHERE id = 1;

(Could we get a UI option? :))

@adriankumpf Can we re-open this feature request? :)

How is this still not implemented?
I mean you don't even need to own multiple vehicles to run into this problem. As soon as some of your friends or your workplace assign you to any other vehicle than yours, these will appear in the database and there is no "easy" way to remove or at least hide them.

How is this still not implemented? I mean you don't even need to own multiple vehicles to run into this problem. As soon as some of your friends or your workplace assign you to any other vehicle than yours, these will appear in the database and there is no "easy" way to remove or at least hide them.

Feel free to send a PR with a fix!


Use "read" value for General Access (#18496)

Backport of #18496

Dammit, I've given this backport the wrong name(now I've forced pushed it the backport for #18499....

I've forced pushed it back, should be all good now.


Very occasional lock-up on PdfDocument.save

ImageConverter.txt
We are experiencing very intermittent lock-ups when calling PdfDocument.save.
We are running your library from AWS lambda to create PDFs from image files (please find the impacted code attached).  The behavior we are seeing is an occasional time out in the lambda at 60 seconds (for an operation that typically requires 4-5 seconds).  Using log messages, we were able to isolate the point of failure at line 27 where we call PdfDocument.save.  The failure only appears to happen with png files, but typically cannot be reproduced with the same png file.  The lambda is not running out of memory when the failure occurs.  I have had no success reproducing the issue locally with thousands of executions.
We first saw the issue with version 1.3.1 of pdf-lib, using sharp 0.25.1 to determine the size and format of the incoming image.
I realize this isn't much to go on, but any guidance you can provide is greatly appreciated.

Hello @dmccoy42!
This is a strange issue. I'm not too sure what is going on here. Even if you aren't running out of memory when these lockups occur, do you find that the memory increases and stays allocated during the lockup? What does the CPU activity look like before and during a lockup?

Hi Andrew,
I’m afraid I don’t have detailed metrics on the failure.  Maximum memory is
512 mb, but maximum memory use was 239 mb.  In my attempts to reproduce the
issue locally the library was very well behaved – memory was returned
quickly and CPU use remained constant.  I was never successful at
reproducing the issue outside of AWS lambda.
I don’t know that there’s much you can do for me.  Just wanted to see if
anyone else has experienced similar issues or if you could see anything
problematic in the way we are using your library.
Thank you for your time and help, Andrew.
David
From: Andrew Dillon<EMAIL_ADDRESS>Sent: Thursday, April 30, 2020 5:52 PM
To: Hopding/pdf-lib<EMAIL_ADDRESS>Cc: dmccoy42<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [Hopding/pdf-lib] Very occasional lock-up on
PdfDocument.save (#431)
Hello @dmccoy42 https://github.com/dmccoy42!
This is a strange issue. I'm not too sure what is going on here. Even if
you aren't running out of memory when these lockups occur, do you find that
the memory increases and stays allocated during the lockup? What does the
CPU activity look like before and during a lockup?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Hopding/pdf-lib/issues/431#issuecomment-622179482, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APMPGBRFH54MLFUY4VFLKBLRPIFKZANCNFSM4MT5MMAQ
.

@dmccoy42 If you were able to solve this issue or have new information/findings, I would be very interested to know!

Hello,
I’m sorry – we did resolve the issue and I forgot to update the thread.
The issue was not related to pdf-lib.
The issue was actually with sharp and the amount of memory allocated to our
lambda.  Over time,  sharp would consume more memory until it eventually
hit the limit, causing the strange timeout behavior we were seeing in the
lambda.  We upped the memory available and eventually found a point where
sharp behaved well.
Thank you for your attention to this and I apologize for the red herring.
Best of health.
David
From: Andrew Dillon<EMAIL_ADDRESS>Sent: Sunday, September 20, 2020 3:01 PM
To: Hopding/pdf-lib<EMAIL_ADDRESS>Cc: dmccoy42<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [Hopding/pdf-lib] Very occasional lock-up on
PdfDocument.save (#431)
Closed #431 https://github.com/Hopding/pdf-lib/issues/431.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Hopding/pdf-lib/issues/431#event-3786412786, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APMPGBRBNTGPU5WNM752CBDSGZUQNANCNFSM4MT5MMAQ
.

No worries! Thanks for the update 👍


#26 Move to electron-builder

Related Issue: #26
Summary:
Moving from electron-packager to electron-builder.
electron-builder is pulling the files needed from '/build'. The electron starter script (main.js, now renamed to electron.js to prevent confusion) has shared dependencies with the main app, like references to 'kill-process-id.service' and 'electron-store.service'. To solve this, made an 'electron' entry for webpack. This way, it pulls whatever dependencies are needed, keeps build/electron.js and build/main.js separate, but allows code to be shared between them in the source.
Set yarn node_modules dependency to manually unpack from the 'app.asar' because node could not reference yarn to correctly spawn. This then needed some path correction.
Screenshots/GIFs: N/A

Hmm, I am hitting an issue mac-only when I try to run a project task where it spits out:
Yarn requires Node.js 4.0 or higher to be installed.
Task failed
Works fine on Windows. Seeing whether its from these changes, machine's on node v8.11.4

I remember that same error message coming up in #125, but I'm not at my PC right now to find exactly where.

Assets are coming in properly now, but haven't solved the 'Yarn requires Node.js 4.0 or higher to be installed.' problem yet. yarn start works fine still, just the bundled version is hitting it.

As I understand it, asar is some tool to make it so package contents can't be inspected

Not only. It also makes sure that the paths are not breaking on Windows: deeply nested files (like in node_modules for example) just don't work on Windows so having a archive fixes that

Not only. It also makes sure that the paths are not breaking on Windows: deeply nested files (like in node_modules for example) just don't work on Windows so having a archive fixes that

Ah, that's good to know.. but we shouldn't need deeply-nested paths, right? Especially now that we have a Webpack build for electron.js, it should just be a couple bundles that it needs.

possibly yes. Just wanted to point it out in case it causes some weird bug in the future ;)

I will try it without asar tonight and at least we can see if it solves the issue. I won't be able to do so until this evening, so anyone can feel free to try given the high priority.

Ahh thanks for the clarification @Jtfinlay, makes sense!

Hi @Jtfinlay,
Awesome, thanks for updating!
Did you have the chance to try it without asar? No worries if not, just asking in case it's a dead end.
Hope wedding planning isn't too stressful, I know it can involve a ton of work!

At the moment, I'm looking at the Node env. issue. But I'm not exactly sure what's causing the issue. DevServer runs correctly but build fails with react-scripts not found.
It seems like passing env to spawn is causing the issue. If I remove the env completely it's working. So the issue is not related to electron-builder setup.
One small thing I noticed is that in getBaseProjectEnvironment adding the path.delimiter is not needed because it's already at the end of process.env.path so there are two delimiters e.g. ;; on Windows. But that's not fixing the build issue.
A fix would be to modify getBaseProjectEnvironment function to:
export const getBaseProjectEnvironment = (projectPath: string) => ({
  ...window.process.env,
  NODE: 'C:\\Program Files\\nodejs\\node.exe',
  NODE_EXE: 'C:\\Program Files\\nodejs\\node.exe',
  PATH:
    window.process.env.PATH +
    path.join(projectPath, 'node_modules', '.bin', path.delimiter),
});

If we're adding it we need to add cross-platform support or if it's just Windows related I think it would be OK to just add NODE & NODE_EXE for Windows. I'm not sure why both keys are required but I've tested each combination. I also tested to add NODE_PATH and adding node path to PATH. But both wasn't working.
With the modified code each task & devServer is running in the Windows binary.

Another option with-out adding NODE to env would be to add shell: true to spawn for tasks & launchDevServer. This fixes the node env issue. Build and devServer is starting.
This feels better and is cross-platform. We just need to test task killing again. As this could be affected by adding shell.
@superhawk610 what do you think should we add shell: true again? Are there any drawbacks?

Another option with-out adding NODE to env would be to add shell: true to spawn for tasks & launchDevServer. This fixes the node env issue. Build and devServer is starting.

Right, so the project started with shell: true because there were weird env issues on Mac. The fix for that, IIRC, was just that we needed to specify window.process.env. Bummer to hear that it didn't totally fix it :/
If we want to move to shell: true, the only thing we need to ensure is that we can still have 2-way communication, to send additional commands once the process has started. This is needed now for eject, but even more in the future when we have custom UI for test running.

We can close this PR with-out merging as it was merged with PR #267 to master.


Add context menu to browse entries

I always miss the option to add browse entries (from spotify or other sources) to the queue like there is with search results.

This was fixed in the webclient in https://github.com/woutervanwijk/Mopidy-MusicBox-Webclient/pull/82

Since I checked yesterday with v 0.6.0. When (roughly) is this fix going to be in the master branch of the PI-MusicBox?

I'm afraid I really don't know what the next Musicbox release will be. But if you want, you could update to the latest development version of the webclient with pip install -U https://github.com/woutervanwijk/Mopidy-MusicBox-Webclient/archive/develop.zip. It should be stable.


DEX-710: multi-value customField values serialized as one value/string

Pull Request Overview

Add test to confirm multi-value CustomFields (in EDM) is working
A corresponding update in EDM is required

/rebase

/rebase

/rebase


Include SASS/SCSS files in output packages

Similar to https://github.com/fontsource/fontsource/issues/64
Is your feature request related to a problem? Please describe.
I am currently using roboto-fontface and would like to replace it with fontsource-roboto (+ fontsource-roboto-condensed, & fontsource-roboto-slab). However, the fontsource packages don't include SCSS files for easy inclusion into my project (though it's not terribly hard to work around).
Describe the solution you'd like
I would like to able to do something like this:
$roboto-font-path: './fonts'; /* if there're paths or parameters to be customized */
@import 'fontsource-roboto'; /* or @use */

Describe alternatives you've considered
I actually haven't thought much about this and am not a CSS expert by any means. It just seems like some of the benefits of using pre-processors are probably going to waste. What I currently do to make this work is:

@import 'fonts/foo/index.css'; (often needing to replace index with 700.css or all-700.css or duplicate to get additional weights, etc.)  in my app's SCSS
Copy files from node_modules/fontsource-foo/... into my app's assets folder under fonts/foo

Hey @jacobq! Appreciate the issue. However, I think I'll close and mark this as a duplicate as #64 addresses all the concerns you have and outlines a proper spec to approach this.
Thanks!


Compiling on FPComplete

Hi:
Is there a way to get Wreq to compile on FPComplete.  I have tried adding it to the extra packages, but seem to be caught in dependency hell (FPComplete seems to provide incompatible versions of http-client and lens library, and no PSQueue library).
Any way to get this to build on the FPComplete infrastructure?

You'll need to ask the FP complete people. This isn't the right place to ask for help with their platform.

@bos did you every get this figured out? I'm facing the same problem.

Folks, I don't use or support Stackage. Please send your support requests to @snoyberg or someone else who can actually help.


update docs for juju 3

Add-relation was depreciated in Juju 3 for integrate.
Also updating the relations to include the endpoints that are
connecting on the integration to help with setting spaces.

Failing tests are unrelated to this PR; pulling this doc change in and addressing failures in subsequent commit.


Added support for absolute file paths to body_from_path

One other thing I noticed when I ran into #17 is that body_from_file does not support absolute paths. I feel like this is common functionality people are going to want. I wrote this up in ~1 minute and haven't dug super deep into the code surrounding this but wanted to get some thoughts on the feature and suggestions for an approach (or hopefully inspire someone to implement a better solution or the 0.5.0 release 😄 )

Thanks for your PR as well! :-) 👍

I thought about this a bit more and the fact that this works outside of running in a debugger shows that there is support for absolute paths. It's likely all that needs to be done is find a fix for #17. I think it'd be safe to decline this PR 😃


Please remove Sensitivity Label

Describe the bug
Hi, the sensitivity label in the below file is enabled. Can you help to remove as we are not able to open and test it out
https://github.com/Azure/Microsoft-Defender-for-Cloud/blob/main/PowerBI/MDC Plan Coverage/mdcCoverrage-v1.pbit

Adding @gastori to review

I experience the same problem with the PBIT file on sensitivity. Please remove the label. Thanks

+1 to please remove sensitivity label. I have just downloaded the file and the label is still present. Thank you.

Closing as fixed in #911


Sub menus have empty rows which has clickable action

Open the application
Click on the top menu on View tab
There are some empty rows which has clickable action

Woaah @sseenivasan89 !

Will have these fixed in our upcoming release.

@sseenivasan89
I have fixed this in the latest v0.9.4 release
Please install the latest release and let me know if the issue still persists.


New Flag to be introduce with --nodatavalidate ( or something like this ) to not validate the content of the Repository while retrieve from org

Is your feature request related to a problem? Please describe.
Currently , If in my  CustomLabel i have any label1 which is not present to my environment 1 to which I have connected my repository , but it is present in another environment where I have previous selected connected my repository so lebel1 is not present in our org i am connected with but was present in another org where i was earlier connect. Now when I try to retrieve all the CustomLabels in my connected org , the retrieve command validate the content present in my repository and see that label1 is not present as an entity in org. I want a feature flag saying dont validate the content of the repository , only retrieve the selected metadata.
What are you trying to do
Expecting a new flag sfdx force:source:retrieve -m CustomLabels:CustomLabels --nodatavalidate , which will not validate data present in the repo and will only retrieve
Describe the solution you'd like
When I run the command with this new flag , cli should not validate the data present in the repo rather it just retrieve things from the organization.
Describe alternatives you've considered
No Alternatives for now , have to manually remove the unwanted data from the repo
Additional context

I'm quite confused on what you're trying to achieve with this. If you want to overwrite your local CustomLabels file, you can delete the file, and retrieve the new one from the new org?  If you're doing a force:source:pull or project retrieve start you'll be able to force override conflicts and write what's retrieved.


Add SpriteSheet Tag splitting

Add the ability to split tags into rows/columns for the exported sprite sheet. See below screenshots for reference.
This implements the corresponding feature from the default Sprite Sheet exporters "Sheet Type" selection with "Split Tags" enabled.
Hope the implementation is clean enough ;)
Thanks
Stone

Example output with "To Rows" selected

Nice addition, I'll review this :)


Search specifically for single-volume reporters

Single Volume Reports.xlsx
Current version of single-volume reporters

This is done and will be accomplished in #60 as well.


Add support for a mock client-side Fusion server

It is extremely valuable to let people run and tinker with example apps without having to set up any server infrastructure (for example via jsfiddle). Since the Fusion protocol is really simple, we should eventually add a mock client-side Fusion server.

I think that it would be very valuable to be able to set a "local" (or similiar) flag per collection. This way horizon could be used for client-side only data as well, making it capable to handle all of the application state. Users could start off by having all of the data locally, and then make some of them persistent when setting up a server.


stm32: nucleo_wl55jc: serial wakeup overlay sample

This PR adds an overlay sample for the nucleo_wl55jc demonstrating low-power serial wakeup capabilities by setting LSE as the clock domain and reducing speed to 9600bps.

tested on nucleo_wl55jc

@appnostic-io Thanks for this change, but a similar change is under review (with additional fix): https://github.com/zephyrproject-rtos/zephyr/pull/50100/files
I'm closing this ticket


Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added code for Assignment 2 to build a pipeline for preprocessing, model training, and evaluation on the Adult dataset.
What did you learn from the changes you have made?
Learned how to combine different data preprocessing steps in a pipeline and evaluate models with multiple metrics.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
not really
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Faced warnings on unknown categories; solved it by configuring OneHotEncoder to handle unseen categories.
How were these changes tested?
Tested through cross-validation and final metrics on a test set.
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

A2 complete


Fix Pythonx.initialize_once/1 with custom directory

Currently using Python.initialize_once("/my/python/dir") sets python home, but still uses the embedded libpython3, which results in init failure if the minor versions differ.

Hi @jonatanklosko thanks for the PR! Sorry it was quite busy before the Christmas holiday...This looks good, I'm going to merge it now.

@cocoa-xu thanks, and no worries! :)


Problem disabling for diffview.nvim

Hi,
I'm trying to use the diffview.nvim plugin and can't seem to disable focus for the view this plugin creates. It uses a side window with the file type DiffviewFiles and two other windows that display the file diff before/after, both with the filetype of the source file. Even though I can add DiffviewFiles to excluded_filetypes, the sizes of the two diff windows get changed. Is there a way to configure this more in detail?
Best,
Daniel

I've had a quick look and its a bit of a tough one. The two panes where the files are shown are standard, e.g they have a filetype of whatever file you are diffing.
I am thinking perhaps I can raise a PR with diffview, to set buftype variable to we can use that instead, that might work.
In the meantime, you can run :FocusToggle to get the split arrangement back. Then once you close diffview you can run :FocusToggle again

Maybe some TabEnter autocommand with detection for diffview which would disable Focus for that tab?

Thank you for your response. I am aware of the workaround I just wanted to bring this to your attention, I appreciate the effort, thanks for this great plugin.

This will work for now while I see if I can find a better way. Place in init.lua etc or if you want init.vim if you remove the vim.cmd wrapper
vim.cmd([[
function! DiffviewFocus()
    lua vim.bo.buftype = 'help'
    :DiffviewOpen
endfunction
cnoreabbrev DiffviewOpen call DiffviewFocus()
]])

Maybe some TabEnter autocommand with detection for diffview which would disable Focus for that tab?

That could work 👍

I'm thinking it would be nice to have a buftype that prevents setting of options, or perhaps just a special one for developers to use such as in this case. I find that the 'help' buftype allows saving etc so it seems fine for now. But it would be nice to have another one like 'special' for devs to use

This will work for now while I see if I can find a better way. Place in init.lua etc or if you want init.vim if you remove the vim.cmd wrapper
vim.cmd([[
function! DiffviewFocus()
    lua vim.bo.buftype = 'help'
    :DiffviewOpen
endfunction
cnoreabbrev DiffviewOpen call DiffviewFocus()
]])

Hi again. I tried your code snippet but I couldn't see a difference unfortunately. I put it in my lua config. If I'm not mistaken (I am a noob when it comes to actual vim code, be it vimscript or lua) the snippet defines a function that basically replaces DiffviewOpen. It sets the buffer type to help before using DiffviewOpen. I have then tried to integrate it into my workflow and directly call a function as part of my keys defined with which-key in the following way:
DiffviewFocus = function()
    vim.bo.buftype = "help"
    require("diffview").open()
end

d = { "<cmd>lua DiffviewFocus()<CR>", "Show the Git diff-view" }
It seems to work as I also tried to put a print command into the function and it did print but the buffer types don't seem to be changed and the focus behavior doesn't change. Can you tell me if I did something wrong?
Best,
Daniel

This will work for now while I see if I can find a better way. Place in init.lua etc or if you want init.vim if you remove the vim.cmd wrapper
vim.cmd([[
function! DiffviewFocus()
    lua vim.bo.buftype = 'help'
    :DiffviewOpen
endfunction
cnoreabbrev DiffviewOpen call DiffviewFocus()
]])

Hi again. I tried your code snippet but I couldn't see a difference unfortunately. I put it in my lua config. If I'm not mistaken (I am a noob when it comes to actual vim code, be it vimscript or lua) the snippet defines a function that basically replaces DiffviewOpen. It sets the buffer type to help before using DiffviewOpen. I have then tried to integrate it into my workflow and directly call a function as part of my keys defined with which-key in the following way:
DiffviewFocus = function()
    vim.bo.buftype = "help"
    require("diffview").open()
end

d = { "<cmd>lua DiffviewFocus()<CR>", "Show the Git diff-view" }
It seems to work as I also tried to put a print command into the function and it did print but the buffer types don't seem to be changed and the focus behavior doesn't change. Can you tell me if I did something wrong?
Best,
Daniel

Can you try update focus and try again. I added in support for the help buftypes yesterday. Let me know how you go 👍

Okay this definitely works. But only when run after opening lua require("diffview").open()
It is a naive way of solving the problem so that's mostly the issue
FocusEqualiseDiffview = function()
   vim.cmd([[
   wincmd w
   wincmd w
   ]])
   vim.bo.buftype = "help"
   vim.cmd("FocusEqualise")
end

Call it with lua require("init").FocusEqualiseDiffview() after running lua require("diffview").open()

This is not working either. Its all related to the same issue I believe with blocking/non-blocking and the synchronicity of the execution of code
autocmd TabEnter DiffviewFilePanel :FocusDisable

If you open diffview, first run the windows are not equalised, if you switch to the other tab, and back to diffview, it will then trigger the above autocommand. Basically, its no better than my first solution right now.

Hi,
thanks a lot for your commitment and help. For now I have just started do use a keybind to quickly disable/reenable focus when using diffview. Thanks again!

No worries. That's the most straight forward way for now. It's hard to deal with some plugins

Okay it will now equalise the windows when entering the diffview, see image below for how it should look

Hi. Thanks again but it doesn't work for me. The behavior is unchanged. Shouldn't the filetype be DiffviewFiles (with uppercase D and F)?, at least that's what is shown when I do :set filetype?.

Hi. Thanks again but it doesn't work for me. The behavior is unchanged. Shouldn't the filetype be DiffviewFiles (with uppercase D and F)?, at least that's what is shown when I do :set filetype?.

That is odd. I am using a :lower() function to process the filetype into lowercase.
I have just tried again, running :lua require("diffview").open() with the latest pull of focus.nvim and its working on my end. I am not sure why it is not on yours.
Just double checking you are on the latest pull yeah?

Hm strange it is working now. I have indeed checked that I have the latest version but something still had to be off at my end. Sorry for the inconvenience and thank you for your work!

Perfect! Thanks for letting me know and closing


Replace isomorphic-fetch with node http

This will make the bundle smaller

I think the bundle size is very important. I have a project that can be considered big a little bit and, after I have installed the pagarme package, it was the heaviest of all of my packages dependencies.
Follow the bundle modules size analysis ranking:

We really want to fix this problem. In the back end the bundle size is not much of a hastle, but in the front end the current size is unnaceptable and must be smaller. Thanks for this feedback :)

We have bigger concerns in this matter than this. I ran webpack-build-analyzer and what we need to get rid off is node-rsa and bluebird since they are about 40% of the bundle size.


Update needed after sspush change

Under "3.1. Backward-edge CFI instruction encoding", the text regarding "Encoding * as..." needs to be updated now that sspush is changed.
The text under the first table should probably be
Encoding rd as x0 is not supported for sspop and ssprr.
and under the second table
Encoding rd as x0 is not supported for ssamoswap. Encoding rs2 as x0 is not supported for sspush.
Also, it looks a bit confusing that rs1 is noted with contents "0" for sspop/ssprr/sspush and rs2 as "1" for sschkra, while rs1 for sschkra is "00101". Either have "5" in the latter case, or (better, IMHO) use "00000" and "00001" for the others.

Thanks. sspush does not need a restriction on source now. Updated with suggestion and corrections in PR #49

True, although since it does not make much sense to ever sspush x0, it would save a bit pattern for possible later use.

I am questioning if saving that one pattern is useful. There are 31 patterns available with rd=0 and one more with rd!=0 in mop.r.2 ..

Allowing sspush x0 will shorten some logic ever so slightly, so I'm certainly not against it. Just thought it perhaps should be considered.
By the way, wouldn't sspush normally (just about always?) be done with x1 or x5? Enforcing that would save more opcode space.


Make PlayHelper able to handle only a VJoyDevice on player 2

I was unable to only use player 2 in the VJoy configuration so I've changed the PlayHelper.py so it doesn't brake anymore. This makes me able to play against my bot in exhibition mode

Thanks for contributing!
This shouldn't stop us from accepting the pull request, but I want to point out that this conflicts with the own-controller branch, which we apparently never merged in to master.

We opted to merge in own-controller first, so now you're stuck with the conflict resolution, sorry. On the bright side, your change should require less code now, if it's even still necessary at all.

Yupp looks like this issue will also happen with the latest changes and needs to be fixed.  Code always assumes 2 vjoy controllers exist which is a bad assumption.

@tarehart I believe with your last code change this is taken care of.  We can close this now right?

I think there's still a weird spot here: https://github.com/drssoccer55/RLBot/blob/master/PlayHelper.py#L6
If the user has only one vJoy device configured, and chooses to disable p1 and enable p2 in rlbot.cfg, I imagine this code will break.
I think we can still close this though, since playing against your bot in exhibition mode is pretty easy at this point. (Just have 2 vjoy controllers configured, and disable one of the players in rlbot.cfg)


Compute shap value with tweedie objective function in xgboost

Following: /issues/454
Tested to see if I could get back the prediction with the shap values computed and it works.
only works with feature_perturbation = "interventional"
Would be nice to have it working with "tree_path_dependent".

Thanks @jfrery ! This looks good. The only chance is could you add a unit test into the test_tree.py file just to make sure this continues to work in the future?

@slundberg @jfrery Thanks for your work with the tweedie objective. Just wondering what the status of this is, and what contributions are needed to move this forward?

Hello, Just wanted to follow up on this. can we transform SHAP marginal values to original values when Tweedie is used?

@statgirl30 I haven't gotten a response from the contributors on this thread, but what I figured out is that Tweedie basically uses a log-link. So you can convert the shap values you get with link="identity" to Tweedie specific values by just exponentiating them. It will be great to merge this fix (as it is almost complete), but it would be great to get some feedback from @slundberg on what else remains to be done.

@narendramukherjee Thanks for your respond. I am using this  link to calculate the 5 highest contributions and simply exponentiating each value would not be correct.

@statgirl30 @narendramukherjee You can't use the exponential on the shap values obtained with the identity link to find the original shap values as this would assume the following:
X = s1 + s2 + ... sN
exp(X) = exp(s1) + exp(s2) + ... + exp(sN)
which is not true.
This fix allows you to have the correct shap values when xgboost uses the tweedie objective function but I did not dig enough to make the tree path dependent work (fastest method).

This doesn't work anymore. Seems like the sum of the shap_values + expected_value is off by a factor of 3.... Not sure what happens there :/. @slundberg  Should I close this PR?

At this point can anyone offer insight as to how we transform SHAP values for a given feature back to the native units of the response? I'm struggling with this in lightgbm's implementation. A generalized transformation formula would benefit not only this package, but the great community as well.

@mosscoder we can't really do this as I am not aware of any mathematical trick to get the shap values back on sync with the predictions. You could get a rough estimation considering that 1- the original shap values should follow the same order and 2- the sum of the original shap values should be equal to the prediction.

I last night found this somewhat old thread discussing the analog of transforming SHAP values to the probability space for binary classification, which appears to have been integrated into this package at this point? Anyway I encountered this function (slightly-modified):
from scipy.special import expit #Importing the logit function for the base value transformation

def shap_transform_scale(shap_values, expected_value, model_prediction):

    #Compute the transformed base value, which consists in applying the logit function to the base value
    #expected_value_transformed = expit(expected_value) #transform for binary classification
    expected_value_transformed = numpy.log(expected_value) #appropriate transformation for Tweedie and Gaussian?

    #Computing the original_explanation_distance to construct the distance_coefficient later on
    original_explanation_distance = sum(shap_values)

    #Computing the distance between the model_prediction and the transformed base_value
    distance_to_explain = model_prediction - expected_value_transformed

    #The distance_coefficient is the ratio between both distances which will be used later on
    distance_coefficient = original_explanation_distance / distance_to_explain

    #Transforming the original shapley values to the new scale
    shap_values_transformed = shap_values / distance_coefficient

    return shap_values_transformed, expected_value_transformed

Two years ago it was referred to as a 'hack', and I'm wondering how perspectives on this approach may have evolved?

@mosscoder this is the kind of trick I was referring to transform the shap values you would get from a model trained with a tweedie objective function. However, the problem is that this shap_transform_scale function assume a linear transformation of the shap values is possible which is wrong. The resulting shap values do sum up to the correct prediction however, their scale is completely wrong.
If we want to be able to work properly with tweedie models in shap, we need the shap values to be computed over the actual prediction and not the log ones as it's currently done. The branch I created does this well when feature_perturbation = "interventional".

So, for the raw scores of the SHAP values (those that aren't back-transformed to the native units of the response), are we safe to assume that negative values, by some unknown magnitude, subtract from the final prediction in native units, and positive values the converse? Can we also safely compare magnitudes across raw SHAP values?

So, for the raw scores of the SHAP values (those that aren't back-transformed to the native units of the response), are we safe to assume that negative values, by some unknown magnitude, subtract from the final prediction in native units, and positive values the converse?

You can find a solution where the raw shap values + the expected value multiplied by a factor give you the model prediction. However, these shap values will be wrong and I don't think you can use them to explain the model prediction as they are trying to explain the log(model_prediction) rather than the model_prediction. I don't even think that you can assume that the order of the raw shap values would be the same than the actual shap values.

Can we also safely compare magnitudes across raw SHAP values?
You can safely compare the magnitudes across the shap values but extrapolating these magnitude to your original problem of explaining the model predictions would be wrong.

To do this you will have to solve the following  equation:
y_pred = s_1 + s_2 + ... s_N + expected_value
such that:
exp(y_pred) = exp(s_raw_1 + s_raw_2 + ... + s_raw_N + raw_expected_value)
where N is the number of features. And y_pred is the actual model prediction.
But again, I don't think there is any mathematical tool to solve this as there isn't a unique solution.

Hello, after much digging I have found this [https://stackoverflow.com/questions/64793802/transformation-of-lightgbm-shap-values-necessary-with-tweedie-objective] (see under "Demo" in the answer) and it seems to be working for my xgboost with reg:tweedie. Any thoughts?

@SquaredS44 It works to get the original prediction. However you can't infer the value of the original shap values. The trick they use is simply the one I mentioned before:
original_prediction = exp(s_raw_1 + s_raw_2 + ... + s_raw_N + raw_expected_value)
They use exp(s_raw_1)exp(s_raw_2)...*exp(s_raw_N)*exp(raw_expected_value) in their code but this doesn't mean that exp(s_raw_1) = s1 (your original shap value for the first feature).

@jfrery I see, thank you for the clarification. But despite not being able to infer original shap value for the n-th feature, is it safe to assume that the relative importance of the s_raw_n value w.r.t. the other s_raw is the same of the n-th original shap values w.r.t to the rest of the original shap values? (I'm not sure if that's what you were referring to with "However, the problem is that this shap_transform_scale function assume a linear transformation of the shap values is possible which is wrong." and "the original shap values should follow the same order")

@jfrery thank you for working on this. I recently downloaded your shap branch and have two questions:

Does this...

explainer = shap.TreeExplainer(bst, dat, feature_perturbation="interventional", model_output="log_link")

...only work for XGBoost, or would it also work for lightgbm to get the SHAP values in native units?

Would the above work with categorical features, presuming a lightgbm model, or continuous only? I ask because I get the following:

@slundberg The demand for having the tweedie handled in shap seems to increase as I get many requests in that sense. It seems that this fix works for xgboost==0.90 but not for more recent versions (the sum of the shap values + expected value is higher than the model prediction by a factor of 3.3). Have you ever noticed a similar behavior before?

Are there any plans on getting this solved? Being able to use tweedie distribution while having shap values in native units would be really useful.

Follow up on this issue. Is there a solution available?


Please specify further how to manually set a persistent ip adress of a fronius inverter

Summary
I run 2 Fronius Symo in my home network. They are not connected together, only connected to my network.
Only one of them has a Smartmeter connected to it.
Sometimes it seems as if the script identifies the wrong inverter as the source for its SmartMeter Readings.
In the Readme, it is specified to start the script with --ip xxx.xxx.xxx.xxx - But where exactly can i specify this option?
Issue Type
Feature Idea
Additional Information
No response

should it be enough to add the param "--ip xxx.xxx.xxx.xxx" to the call in /data/FroniusSmartmeter/service/run?
I've tried it, but it looks as if it still does not run correctly

I'll look into it - not sure if that is still implemented. Need to take another look.

I had the same Problem: Two Fronius SmartMeter in the same Network.  Just add default='x.x.x.x' to the code.
parser.add_argument(
"--ip",
help='IP Address of Smart Meter, leave empty to autodetect, specify "test" to use canned data',
default='x.x.x.x'
)
works out fine for me.

I had the same Problem: Two Fronius SmartMeter in the same Network. Just add default='x.x.x.x' to the code.
parser.add_argument( "--ip", help='IP Address of Smart Meter, leave empty to autodetect, specify "test" to use canned data', default='x.x.x.x' )
works out fine for me.

Thank you SO MUCH tonhart! That works, now both of my Victron Systems start with the Fronius Smartmeter working :))


Redesign for Project Translation and Enhanced .jpg/.jpeg Support

1. Project Translation Redesign:

Redesigned the project structure to enable the translation of all markdown and image files within a project. This is achieved using the existing image and text translation features.
Implemented the translation logic through three key components: image_translator, text_translator, and project_translator, located in the src/translators folder.

[!NOTE]

image_translator.py: Handles the extraction, translation, and annotation of text within images, supporting various image formats including PNG, JPG, and JPEG.
text_translator.py: Handles the translation of text, particularly in markdown files, text in image.
project_translator.py: Handles the overall project translation workflow, coordinating the translation of both markdown and image files across the entire project directory. (Currently under development)

2. Notebook Modification and Testing:

Updated and tested the notebook to reflect the redesign, ensuring compatibility and functionality with the new structure.

3. Environment Variable Standardization:

Replaced environment variable names with universal ones, aligning with other Microsoft open-source projects such as Semantic Kernel.

4. Font Mappings Update:

Added and enhanced the font-mappings.yaml by referencing the GitHub-App repository. The mappings now support a wider range of languages, including those requiring specific fonts like Korean and Japanese.
Improved the handling of language codes by ensuring the correct language name and font are used based on font-mappings.yaml.

5. Enhanced Image Translation Support:

Extended the translation capabilities to include non-RGBA image file types such as JPG and JPEG, which were previously only supported for PNG files.

6. File Saving Improvements:

Improved the logic for saving translated image files, ensuring they are saved with a language code appended to the filename for clarity and organization.

I've verified that all changes work as expected by testing in the updated notebook.

Hi @timothycdc, if you have a moment, could you please review this PR?

I have reviewed the changes myself and everything looks good to me


Gekko Serving UI but can't connect. Running on AWS EC2 instance without NGINX as an upstream.

Note: for support questions, please join our Discord server

I'm submitting a ...
[ X] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
Here is the UIConfig file:

const CONFIG = {
headless: true,
api: {
host: '<IP_ADDRESS>',
port: 3000,
timeout: 120000 // 2 minutes
},
ui: {
ssl: false,
host: 'domain.com', //Public DNS of my EC2 instance
port: 3000,
path: '/'
},
adapter: 'sqlite'
}
if(typeof window === 'undefined')
module.exports = CONFIG;
else
window.CONFIG = CONFIG;

Expected result (what you hoped would happen)

I just want to set up gekko to run from an EC2 instance without NGINX as a reverse proxy. I know this is not recommended but I have no experience with servers and just want to make this as simple as possible.

Actual result (unexpected outcome)
Output of the node gekko --ui command:

node gekko --ui
______   ________  __    __  __    __   ______

/      \ /        |/  |  /  |/  |  /  | /
/$$$$$$  |$$$$$$$$/ $$ | /$$/ $$ | /$$/ /$$$$$$  |
$$ | $$/ $$ |_    $$ |/$$/  $$ |/$$/  $$ |  $$ |
$$ |/    |$$    |   $$  $$<   $$  $$<   $$ |  $$ |
$$ |$$$$ |$$$$$/    $$$$$  \  $$$$$  \  $$ |  $$ |
$$ _$$ |$$ |_____ $$ |$$  \ $$ |$$  \ $$ _$$ |
$$    $$/ $$       |$$ | $$  |$$ | $$  |$$    $$/
$$$$$$/  $$$$$$$$/ $$/   $$/ $$/   $$/  $$$$$$/
Gekko v0.5.12
I'm gonna make you rich, Bud Fox.

Serving Gekko UI on http://DNS.compute.amazonaws.com:3000/
Something went wrong when trying to open your web browser. UI is running on DNS.compute.amazonaws.com:3000/.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

This may be something simple because I do not have any server experience, but I have security groups inbound on TCP 3000 for my IP address (and everywhere).
Any and all help is appreciated, again this stuff is very new to me. Thanks.

I am pretty sure this has to do with the security group settings on AWS, by default all ports are blocked (except ssh and maybe port 80 and such).

if that doesn't solve it please reopen :)

Hi Mike, attached are my securtiy group settings for my AWS instance. Port 3000 (from anywhere), 80 (from my local machine), and 22 (from my local machine)  all allowed.


Restructuring and Cleanup

Restructuring and cleanup

Removed unused classes

Fixed code formatting issues

Better package structure

Foundational classes go to a foundation package

Content and registries in the base package

Moved some classes to new packages in anticipation of future work (e.g. integration)

Fixed some naming conventions

Renamed some classes to better names

What are we fixing?
Our old structure was inadequate for our usage. We ended up mixing content with base classes, and, in some cases, undesirable workarounds were needed (e.g. /blocks/block/)
What can we expect from the new structure?
The new structure was designed to be cleaner, and this will be necessary when we start adding content.
It also makes more sense to separate foundational classes from content classes.


Content-Length not in response header when content length exceeds MAX int value

There is a bug in pull request #1450 , useServlet31 is always false.
Which results in the fact that the max content-length is always checked whether it fits in an int value, only then it is returned. So for small response it is working well, for bigger file downloads it fails.
See my comment on the pull request:
https://github.com/spring-cloud/spring-cloud-netflix/pull/1450#pullrequestreview-55545301
According to the pull request, the code construction is used twice, so it has to be fixed at both locations.

Only needed in one place that checks set with the param vs. get, no param

Closed via c2aa60f29246a860653a2b8c04ed1bc844759025

Thanks for the quick fix. The other place is indeed a get, so need to change.


Usage: adding custom Toolbar by no overriding

I try to custom the toolbar.
Any convenient way to add a GraphiQL.Menu with the four default existed buttons?
Thanks.

Or how to easily import and reuse the existed button function like handlePrettifyQuery or handleCopyQuery?

@HermanZzz yes, you can use the function handleCopyQuery like this
 handleCopyQuery = () => {
    this.graphiQL = this.ref.current;
    const editor = this.graphiQL.getQueryEditor();
    const query = editor && editor.getValue();
    if (!query) {
      return;
    }

    copyToClipboard(query);
  };

Yes. But It's kinda pointless to re-implement all the four functions.
Is there any possible way to handle it, to add a new button based on the default toolbar?

AFAIK there isn't a way to do that. Am I right @acao ?

OK thanks @harshithpabbati . Rewrite the default functions though, duplicate code exists.

we have a new version 2.0.0 that will offer better customizations for this.

look forward to it. cheers~

I'm also trying to to add to the toolbar without deleting the default ones (Prettify, Merge, Copy, History). Is version 2.0.0 ready to be used? If so, where can I find how to accomplish this?
If not, could you share the functions handleHistory and handleMerge. I have already found handleCopyQuery and handlePrettify.
Thank you.

I found this is possible already: use toolbar.additionalContent prop in GraphiQL component:
ReactDOM.render(
  React.createElement(GraphiQL, {
    fetcher: fetcher,
    toolbar: {
      additionalContent: [
        React.createElement(GraphiQL.Button, {
          label: 'My button'
          onClick: () => alert('My button clicked')
        })
      ]
    }
  }),
  document.getElementById('graphiql'),
);


making root filesystems

couple of links to people talking about building kernels and making root filesystems. No mention of OCI images but this would be useful in the making of the userspaces.
Rob's talks on compiling simple linux systems

compilling simplest linux system
building linux via automated scripts
toybox vs busybox

Github repos of setting up userspace linux

mkroot - script for simple linux build
gokrazy - bootstraps go programs on raspberry pis

Alright. I'd look into them then we can have a meeting next week to discuss the way forward. What do you think?

Okay, after conducting thorough research and investigation, I have gained a deeper understanding of the components involved and even gained insights into how an initialization process for this system might look. When it comes to creating root filesystems for a Linux system, there are numerous approaches, some of which can be overwhelming, while others are deceptively simple. However, fortunately for us, Firecracker has specific requirements for its root drive, so as long as we meet those criteria, we should be fine. Whether you choose to use tools like mkroot, gokrazy, or deconstructed Docker images, as long as you provide it as a virtual drive, it will work. Nevertheless, I am particularly enthusiastic about supporting tooling related to OCI image-based root filesystems due to the ecosystem surrounding it. Creating your own becomes as effortless as writing a Dockerfile.
So, what prompted me to explore this idea further was a friend of mine who wanted to create something unique for his blog. I suggested adding interactive elements to it, such as providing a shell or some form of interface for his users to experiment with. That's when I proposed Firecracker as a backend for this project, aiming to make our tooling useful for his goals. I envision a scenario where a user can package everything into a Docker image and simply hand it over to us, and we take care of the rest. I believe that OCI image-backed root filesystem solutions would provide the optimal experience in such cases. I also delved into fly.io's init, which appears to be a perfect fit for a workload like this.
Here's the basic concept: we flash the init and its configuration onto a drive, similar to how we handle other Firecracker root filesystems, and mount the init as the root drive (e.g., '/dev/vda'). Then, we mount the actual rootfs as an additional drive (e.g., '/dev/vdb') and launch Firecracker. The purpose of the init is to perform initial setups and then pivot_root/chroot into '/dev/vdb'. Consequently, we don't need to install and configure something like rcinit or systemd into our root filesystem. We can simply provide it as is, add a few configurations, and it will boot seamlessly.
That's the progress I've made so far. What are your thoughts on this?"

fully support the idea of going with OCI image based rootfs, simpler to get images -- and various kinds of them.
another issue that's been eating away at my brain is how we manage the running system: can we add userspace software after initial setup or do we need to specify everything that needs  to run in the machine in the machine's config (dockerfile in this case). and is the system going to be flexible enough to use as a server (akin to how cloud virtual machines are used) or is it essentially just going to be a runner for docker images?

fully support the idea of going with OCI image based rootfs, simpler to get images -- and various kinds of them.
another issue that's been eating away at my brain is how we manage the running system: can we add userspace software after initial setup or do we need to specify everything that needs  to run in the machine in the machine's config (dockerfile in this case). and is the system going to be flexible enough to use as a server (akin to how cloud virtual machines are used) or is it essentially just going to be a runner for docker images?

Generally I want us to make this as flexible as possible. We're building tools that's going to be the core of other tools and stuff we're going to do.
So about the userspace software I think we can do both. We can even do something like what vagrant does so we specifically the packages you might need installed then we do it at setup time. We can also explore running commands at runtime through SSH. But the point is it has to be flexible enough to solve whatever problem we might have in future. Also I intend for them to be used as servers or runners for docker files. So fly's init might only be used for transfigured oci images but for traditional server like workloads we go with a regular init system or something of our own making. We don't have to lock ourselves in a box rn

This is a script to unpack OCI bundles
#!/usr/bin/env bash

oci_image_path=$1
rootfs=$2

blobs="$oci_image_path"/blobs/sha256
manifest_digest=$(cat "$oci_image_path"/index.json | jq '.manifests[0].digest' | grep -oP '(?<=:).*(?=")')
manifest="$blobs"/"$manifest_digest"

readarray -t layers <<< "$(cat "$manifest" | jq '.layers[].digest' | grep -oP '(?<=:).*(?=")')"
for el in "${layers[@]}"; do
  tar xf "$blobs"/"$el" -C "$rootfs"
done

Setting up the init
fallocate -l 100M tmpinit
mkfs.ext2 tmpinit
mkdir initmount
mount tmpinit initmount
mkdir initmount/fly
cp target/x86_64-unknown-linux-musl/release/init initmount/fly/init
cp run.json initmount/fly/init
umount initmount

run.json example
{
  "ImageConfig": {
    "Cmd": ["/bin/bash"],
    "Env": ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"],
    "WorkingDir": "/",
    "User": "root"
  },
  "IPConfigs": [],
  "TTY": true,
  "Hostname": "bxffour",
  "Mounts": [],
  "RootDevice": "/dev/vdb",
  "EtcResolv": {
    "Nameservers": ["<IP_ADDRESS>", "<IP_ADDRESS>"]
  },
  "EtcHosts": []
}

To run the vm using firectl
firectl --root-drive tmpinit --add-drive rootfs.ext4:rw --add-drive --vsock-device ./v.sock:3 --kernel-opts "ro console=ttyS0 noapic reboot=k panicOD=1 pci=off nomodules init=/fly/init"

cni config for the modified firecracker
{
  "name": "fcnet",
  "cniVersion": "0.4.0",
  "plugins": [
    {
      "type": "ptp",
      "ipMasq": true,
      "ipam": {
        "type": "host-local",
        "subnet": "<IP_ADDRESS>/24",
        "resolvConf": "/etc/resolv.conf"
      }
    },
    {
      "type": "firewall"
    },
    {
      "type": "tc-redirect-tap"
    }
  ]
}```


update documentation with odyssey changes

the API does not change for now but we should add information about that the user should expect from a visualization with odyssey

There has been no activity on this issue for several months and that's why are closing it (automatically). If you think this still needs to be addressed please reopen it. The good news is that we are now working on the next version of CARTO.js, stay tuned.


Implement smarter map layers for paths

Map should be able to recognize the different paths and and put them into different category eg: sport and transportation.
E.g.:

This is based on regexp basically: https://github.com/bpatrik/pigallery2/blob/61970c2025c24107f5a9154efbd79c35a9318286/src/frontend/app/ui/gallery/map/lightbox/lightbox.map.gallery.component.ts#L116-L142

This is fixed now.

Here is how gpx paths gets into categories (gets their icons):
https://github.com/bpatrik/pigallery2/discussions/667#discussioncomment-6942232


fix: runtime panic (via updating dependency)

This PR updates x/sys library so logrus can be used on Darwrin/go1.17
see: https://github.com/golang/go/issues/45702

This is related to #1272  and has an alternative solution as #1273

Perhaps someone could add go 1.17 to CI
In general, I think this is fine to update; that said, if your project uses Logrus and runs into this issue, you should be able to specify a more recent version of golang.org/x/sys in your project's go.mod (if needed with // indirect). This will force go modules to get a more current version than the minimum version required in the logrus go.mod

That's what I did atm, however, isn't a better solution is to fix the issue at the root?

duplicate of #1280


cloudcli cookbook does not work with Chef-Client 12.19.36

Ran into an interesting issue today.
cloudcli cookbook 1.0.0
chef-client 12.19.36
All cloudcli cookbook default settings on a CentOS 6.8 AWS VM:
Recipe: cloudcli::_aws_linux
  * yum_package[groff] action install (up to date)
  * python_runtime[2] action install
    * poise_languages_system[python] action install

      ================================================================================
      Error executing action `install` on resource 'poise_languages_system[python]'
      ================================================================================

      NoMethodError
      -------------
      undefined method `arch' for Chef::Resource::Package

      Cookbook Trace:
      ---------------
      /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:173:in `block in run_package_action'
      /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:162:in `each'
      /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:162:in `run_package_action'
      /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:100:in `action_install'
      /var/chef/cache/cookbooks/poise/files/halite_gem/poise/helpers/notifying_block.rb:69:in `notifying_block'
      /var/chef/cache/cookbooks/poise-python/files/halite_gem/poise_python/python_providers/base.rb:44:in `action_install'

      Resource Declaration:
      ---------------------
      # In /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/mixin.rb

       32:         poise_languages_system system_package_name do
       33:           # Otherwise use the default install action.
       34:           action(:upgrade) if options['package_upgrade']
       35:           parent new_resource
       36:           # Don't pass true because we want the default computed behavior for that.
       37:           dev_package options['dev_package'] unless options['dev_package'] == true
       38:           dev_package_overrides dev_package_overrides
       39:           package_version options['package_version'] if options['package_version']
       40:           version options['version']
       41:         end
       42:       end

      Compiled Resource:
      ------------------
      # Declared in /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/mixin.rb:32:in `install_system_packages'

      poise_languages_system("python") do
        action [:install]
        retries 0
        retry_delay 2
        default_guard_interpreter :default
        declared_type :poise_languages_system
        cookbook_name "cloudcli"
        parent # Declared in /var/chef/cache/cookbooks/cloudcli/recipes/_aws_linux.rb:21:in `from_file'

      python_runtime("2") do
        provider PoisePython::PythonProviders::System
        action [:install]
        retries 0
        retry_delay 2
        default_guard_interpreter :default
        declared_type :poise_languages_system
        cookbook_name "cloudcli"
        parent # Declared in /var/chef/cache/cookbooks/cloudcli/recipes/_aws_linux.rb:21:in `from_file'

      python_runtime("2") do
        provider PoisePython::PythonProviders::System
        action [:install]
        retries 0
        retry_delay 2
        default_guard_interpreter :default
        subresources [python_package[awscli]]
        declared_type :python_runtime
        cookbook_name "cloudcli"
        recipe_name "_aws_linux"
        pip_version true
        setuptools_version true
        version "2"
        virtualenv_version true
        wheel_version true
      end

        version "2"
        package_name "python"
        dev_package "python-devel"
      end

      Platform:
      ---------
      x86_64-linux

    ================================================================================
    Error executing action `install` on resource 'python_runtime[2]'
    ================================================================================

    NoMethodError
    -------------
    poise_languages_system[python] (/var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/mixin.rb line 32) had an error: NoMethodError: undefined method `arch' for Chef::Resource::Package

    Cookbook Trace:
    ---------------
    /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:173:in `block in run_package_action'
    /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:162:in `each'
    /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:162:in `run_package_action'
    /var/chef/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/resource.rb:100:in `action_install'
    /var/chef/cache/cookbooks/poise/files/halite_gem/poise/helpers/notifying_block.rb:69:in `notifying_block'
    /var/chef/cache/cookbooks/poise-python/files/halite_gem/poise_python/python_providers/base.rb:44:in `action_install'

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/cloudcli/recipes/_aws_linux.rb

     21: python_runtime node['cloudcli']['aws']['python']['version'] do
     22:   provider node['cloudcli']['aws']['python']['provider']
     23: end
     24:

    Compiled Resource:
    ------------------
    # Declared in /var/chef/cache/cookbooks/cloudcli/recipes/_aws_linux.rb:21:in `from_file'

    python_runtime("2") do
      provider PoisePython::PythonProviders::System
      action [:install]
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      subresources [python_package[awscli]]
      declared_type :python_runtime
      cookbook_name "cloudcli"
      recipe_name "_aws_linux"
      pip_version true
      setuptools_version true
      version "2"
      virtualenv_version true
      wheel_version true
    end

    Platform:
    ---------
    x86_64-linux

Not sure whether this should be an issue for this cookbook or the dependency poise_languages

FYI this does work fine with chef-client 12.18.31

Seems reasonable. @isuftin, feel free to put in a PR with the fix and added tests.

@cmlicata I'll see what I can do here as time allows. I'm hoping it can be fixed at this end and not have to be passed off to the poise_languages cookbook. Thanks, @cmlicata

This is still appearing in chef-client 12.21.3
Any idea how to fix this?

@naveenkumarjtg, I haven't worked on this in a bit, but could you please provide a stacktrace?

Is this a critical issue for you?

This cookbook is part of our base role for our nodes. Due to this issue, we are unable to move towards a newer version of the Chef client.

Update, this may be due to us using an older version of the cloucli-cookbook. Further testing will be done on our end.


custom background color & custom indictor  & lazyload bug

allow set pdf background color
allow custom indicator

@kaichii Hello, interesting fix bug lazy load, Do you know when it will be up?

Honestly i don't know，i use my fixed pdf_viewer in my project.

Honestly i don't know，i use my fixed pdf_viewer in my project.

Do you think i will be able to use your fix on my project and publish to the store?

Honestly i don't know，i use my fixed pdf_viewer in my project.

Do you think i will be able to use your fix on my project and publish to the store?

I will consider that.

Honestly i don't know，i use my fixed pdf_viewer in my project.

Do you think i will be able to use your fix on my project and publish to the store?

I published my fix to the pub, you can use this.

Unable to use this, as it has changed a lot. Thank you for your initiative though.