Weights not initialized warning in reward function

I tried RAFT alignment following the example at https://optimalscale.github.io/LMFlow/examples/raft.html and used following command to obtain the merge reward model:
python examples/merge_lora.py \
    --model_name_or_path output_models/sft \
    --lora_model_path output_models/rm \
    --output_model_path output_models/merge_rm

However, I encountered a warning while performing RAFT alignment:

Some weights of GPTNeoForSequenceClassification were not initialized from the model checkpoint at output_models/merge_rm and are newly initialized: ['score.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.

It seems that the last layer of the reward model was not loaded properly. Is this expected behavior? How should I test or evaluate the reward function?

Hi! Thanks for your interest!
Just to clarify. Do you meet this warning when you load the merged reward model when running raft?

You can also try out the following code.
import torch
from peft import PeftConfig, PeftModel
from transformers import AutoConfig, AutoTokenizer, HfArgumentParser, AutoModelForSequenceClassification

model = AutoModelForSequenceClassification.from_pretrained(base_model_name, num_labels=1, torch_dtype=torch.bfloat16)
model_lora = PeftModel.from_pretrained(model, adapter_model_name)
model_lora.merge_and_unload()
model.save_pretrained(output_name)

To test whether the reward model is merged appropriately, you can load the rm dataset and use your reward model to test the accuracy. For instance,
dataset = load_dataset("json", data_files="/home/usr_name/LMFlow/data/hh_rlhf/rm/the_name_of_rm_data.json", split="train", field="instances")
responses_j = dataset['positive']
responses_k = dataset['negative']
cnt = 0
rm_tokenizer = AutoTokenizer.from_pretrained(reward_model_or_path)
hf_pipe = pipeline(
    "sentiment-analysis",
    model=reward_args.reward_model_or_path,
    device="gpu",
    tokenizer=rm_tokenizer,
    model_kwargs={"torch_dtype": torch.bfloat16}
)
for i in range(len(responses_j)):
    r_j = responses_j[i]
    r_k = responses_k[i]
    texts_for_rewards = [r_j, r_k]
    pipe_outputs = hf_pipe(texts_for_rewards, **pipe_kwargs)
    rewards = [output[0]["score"] for output in pipe_outputs]
    if rewards[0] >= rewards[1]:
        cnt += 1

print(cnt / len(responses_j))

Hi! Thanks for your interest!
Just to clarify. Do you meet this warning when you load the merged reward model when running raft?

Yes, both setting pipeline or using AutoModel.get_model(reward_model_args) will meet this issue.

You can also try out the following code.
import torch
from peft import PeftConfig, PeftModel
from transformers import AutoConfig, AutoTokenizer, HfArgumentParser, AutoModelForSequenceClassification

model = AutoModelForSequenceClassification.from_pretrained(base_model_name, num_labels=1, torch_dtype=torch.bfloat16)
model_lora = PeftModel.from_pretrained(model, adapter_model_name)
model_lora.merge_and_unload()
model.save_pretrained(output_name)

I found that the model used in this approach is the GPTNeoForSequenceClassification model, which achieves an accuracy of about 71.8% when tested on the code you mentioned (only the first 1648 training data were run).
However, the examples uses GPTNeoForCausalLM, where the score layer is discarded and replaced by the lm_head layer, which is also ignored when saving.
Therefore, the models used in merge_lora.py and raft_align.py do not include the last layer of the reward model, and the output results will be random. Actually, I repeated a few times of merge_lora.py and tested them, and the accuracy fluctuated around 53%, instead of a fixed value.

For more information:
Method 1
model = AutoModel.get_model(model_args)
model.merge_lora_weights()
model1 = model.get_backend_model()
model1

> PeftModelForCausalLM(
  (base_model): LoraModel(
    (model): GPTNeoForCausalLM(
      (transformer): GPTNeoModel(
        (wte): Embedding(50257, 2560)
        (wpe): Embedding(2048, 2560)
        (drop): Dropout(p=0.0, inplace=False)
        (h): ModuleList(
          (0-31): 32 x GPTNeoBlock(
            (ln_1): LayerNorm((2560,), eps=1e-05, elementwise_affine=True)
            (attn): GPTNeoAttention(
              (attention): GPTNeoSelfAttention(
                (attn_dropout): Dropout(p=0.0, inplace=False)
                (resid_dropout): Dropout(p=0.0, inplace=False)
                (k_proj): Linear(in_features=2560, out_features=2560, bias=False)
                (v_proj): Linear(in_features=2560, out_features=2560, bias=False)
                (q_proj): Linear(in_features=2560, out_features=2560, bias=False)
                (out_proj): Linear(in_features=2560, out_features=2560, bias=True)
              )
            )
            (ln_2): LayerNorm((2560,), eps=1e-05, elementwise_affine=True)
            (mlp): GPTNeoMLP(
              (c_fc): Linear(in_features=2560, out_features=10240, bias=True)
              (c_proj): Linear(in_features=10240, out_features=2560, bias=True)
              (act): NewGELUActivation()
              (dropout): Dropout(p=0.0, inplace=False)
            )
          )
        )
        (ln_f): LayerNorm((2560,), eps=1e-05, elementwise_affine=True)
      )
      (lm_head): Linear(in_features=2560, out_features=50257, bias=False)
    )
  )
)

Method 2
model2 = AutoModelForSequenceClassification.from_pretrained('output_models/finetune', num_labels=1, torch_dtype=torch.bfloat16)
model_lora = PeftModel.from_pretrained(model2, 'output_models/rm')
model_lora.merge_and_unload()
model2

> GPTNeoForSequenceClassification(
  (transformer): GPTNeoModel(
    (wte): Embedding(50257, 2560)
    (wpe): Embedding(2048, 2560)
    (drop): Dropout(p=0.0, inplace=False)
    (h): ModuleList(
      (0-31): 32 x GPTNeoBlock(
        (ln_1): LayerNorm((2560,), eps=1e-05, elementwise_affine=True)
        (attn): GPTNeoAttention(
          (attention): GPTNeoSelfAttention(
            (attn_dropout): Dropout(p=0.0, inplace=False)
            (resid_dropout): Dropout(p=0.0, inplace=False)
            (k_proj): Linear(in_features=2560, out_features=2560, bias=False)
            (v_proj): Linear(in_features=2560, out_features=2560, bias=False)
            (q_proj): Linear(in_features=2560, out_features=2560, bias=False)
            (out_proj): Linear(in_features=2560, out_features=2560, bias=True)
          )
        )
        (ln_2): LayerNorm((2560,), eps=1e-05, elementwise_affine=True)
        (mlp): GPTNeoMLP(
          (c_fc): Linear(in_features=2560, out_features=10240, bias=True)
          (c_proj): Linear(in_features=10240, out_features=2560, bias=True)
          (act): NewGELUActivation()
          (dropout): Dropout(p=0.0, inplace=False)
        )
      )
    )
    (ln_f): LayerNorm((2560,), eps=1e-05, elementwise_affine=True)
  )
  (score): Linear(in_features=2560, out_features=1, bias=False)
)

We should use AutoModelForSequenceClassification as we train the rm by loading the GPTNeoForCausalLM as GPTNeoForSequenceClassification.  I think the accuracy 71.8% is normal for a 2.7b rm.

This issue has been marked as stale because it has not had recent activity. If you think this still needs to be addressed please feel free to reopen this issue. Thanks


Removed all RouteOverview functionality

RouteOverview functionality wouldn't compile because it used an internal Sun API not available in Java 9. The existing functionality also seemed to vary in results depending on Java environment.

Great, thanks!

I just noticed that the documentation here refers to the RouteOverview:
http://sparkjava.com/documentation.html
I think I can't change the docs. @perwendel could you please remove the RouteOverview section from that page?

Well, it's still in there for the current versions, so I think it's fine to keep it in the docs. I will remove it from the docs when I launch the new website.


ERROR in ./node_modules/react-native/index.js: Module parse failed: Unexpected token

🐛 Bug Report
I'm trying to use the library for my react native WEB app
I run it with webpack + babel but I get the following error:
ERROR in ./node_modules/react-native/index.js 14:7
Module parse failed: Unexpected token (14:7)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|
| // Components
> import typeof AccessibilityInfo from './Libraries/Components/AccessibilityInfo/AccessibilityInfo';
| import typeof ActivityIndicator from './Libraries/Components/ActivityIndicator/ActivityIndicator';
| import typeof Button from './Libraries/Components/Button';
<EMAIL_ADDRESS>12:23-46
<EMAIL_ADDRESS>3:31-79
<EMAIL_ADDRESS>7:9-24
 @ ./src/index.tsx 5:0-74 8:42-48 14:38-42 20:42-61

To Reproduce
Steps to reproduce the behavior:
Expected behavior

Link to runnable example or repository (highly encouraged)
https://github.com/belaziv/RN-WEB-EX

UI Kitten and Eva version

Package
Version

@eva-design/eva
^2.1.1

@ui-kitten/components
^5.1.1

Environment information

  System:
    OS: Linux 5.11 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
  Binaries:
    Node: 16.13.1 - /usr/local/bin/node
    Yarn: 1.22.15 - /snap/bin/yarn
    npm: 8.1.2 - /usr/local/bin/npm
  npmPackages:
    react: ^17.0.2 => 17.0.2
    react-native: ^0.66.4 => 0.66.4

i have same issue


Updates descriptions.

I made a small update to the description and fixed a bug in the mobile menu.

Thats ok!

Now is ok!


Update YamlCreate to Manifest v1.0.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

#9579
I'm by no means a pro, but at least the script works according to my 5:30 AM brain 🤷♂
I will add more features later, just wanted to get this out there.
Microsoft Reviewers: Open in CodeFlow

@OfficialEsco I've asked a couple of people to look at this PR to get it reviewed.

@palenshus take another look :)
Also i'm sure someone could make a amazing script with some fancy Functions and stuff, like @jedieaston.
I'm just trying to make a temporary script until then ¯_(ツ)_/¯

Cough i seem to have pushed another commit because of a bug after you approved the review

@OfficialEsco are you ready for this to be merged?

Yep it should be good to go now, no problems as far as i know of.


CI/CD pipeline integration

Add option and parameters to ease the use of the player in a CI/CD pipeline.

This is not perfect by now, but you can generate the graphs as usual, then use "player graph --output-type json" to generate the results as a JSON document on STDOUT.


Typescript module @types/react-form does not include hooks

Same problem here. I didn't see anything related to TS in documentation.

Same here.

Any update on this?

+1

+1

While waiting for this to be fix, I've removed the @types/react-form package and made a declarations.d.ts file with these contents:
declare module 'react-form' {
    var reactForm: {
	    Form: any
	    splitFormProps: any
	    useField: any
	    useForm: any
    }
    export = reactForm
}

In no way is this ideal, but it works

While waiting for this to be fix, I've removed the @types/react-form package and made a declarations.d.ts file with these contents:
declare module 'react-form' {
    var reactForm: {
	    Form: any
	    splitFormProps: any
	    useField: any
	    useForm: any
    }
    export = reactForm
}

In no way is this ideal, but it works

Hello! I have created a Pull Request to the DefinitelyTyped repository. Please, review it.

Hello! I have created a Pull Request to the DefinitelyTyped repository. Please, review it.

Hey all, I'm closing this issue as it appears to be related to a version of the old non-current @tanstack/react-form and friend APIs. We're looking to 1.x soon enough, and I want to more easily filter down to more recent issues.
Thanks for being early adopters of our tooling! We know that it can lead to issues like this being unresolved sometimes, but we're working hard on the new iteration of Form.
Maybe take a look and let us know what you think?
https://tanstack.com/form
Best,

Corbin


PBIP docs update

required files, limitations review, pbi_removechildren, unappliedChanges review, autocrlf

@Minewiskan
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


OpenAL not Loading on Linux

Version
3.3.2 (nightly)
Platform
Linux x64
JDK
openjdk-18 Oracle
Module
OpenAL
Bug description
OpenAL cant loading if I try to open a New Device
code:
String defaultDeviceName = alcGetString(0, ALC_DEFAULT_DEVICE_SPECIFIER);
            long j = ALC10.alcOpenDevice(defaultDeviceName);

Stacktrace or crash log output
ALSA lib ../../pulse/pulse.c:242:(pulse_connect) PulseAudio: Unable to connect: Connection refused

Hey @Snowiiii,
Could you please try the latest snapshot (3.3.2 build 2)? OpenAL Soft has been updated to 1.22.2, which includes some fixes related to the audio backends on Linux.

@Spasi Have Updated but no difference same Error

Hey @Snowiiii,
I still cannot reproduce this and there haven't been any other reports about audio issues on Linux. Have you verified that PulseAudio and/or other audio components are configured correctly in your setup?

I have tested many things Up/Down grading LWJGL and even the change from Ubuntu to Arch does not have a effect,I guess the Problem is maybe that im using Pipewire and not PulseAudio

2023 - Still No Audio On:

Arch
Ubuntu
PopOS
Manjaro
Fedora
I and my Friends tested them All

Hey @Snowiiii,
LWJGL 3.3.2-snapshot+9 is now available with OpenAL-Soft 1.23.0. I see some PipeWire-related fixes in the change log, could you please try it out?
(again, OpenAL works fine on my Linux machine with 1.23.0)

Hey i tested it our im current on Arch (6.1.11-arch1-1) and ye i tried to change some code but it dosnt work here the code & error
  private static long openDevice() {
        OptionalLong optionallong;

        String device = ALC10.alcGetString(0, ALC10.ALC_DEFAULT_DEVICE_SPECIFIER);
        LOGGER.info("Audio Device: {}", device);
        optionallong = tryOpenDevice(device);

        if (optionallong.isEmpty()) {
            throw new IllegalStateException("Failed to open OpenAL device");
        } else {
            return optionallong.getAsLong();
        }
    }

private static OptionalLong tryOpenDevice(@Nullable String p_193476_) {
        long i = ALC10.alcOpenDevice(p_193476_);
        return i != 0L && !ALUtils.checkALCError(i, "Open device") ? OptionalLong.of(i) : OptionalLong.empty();
    }

Error
java.lang.IllegalStateException: Failed to open OpenAL device
	at net.minecraft.client.audio.SoundSystem.openDevice(SoundSystem.java:128) ~[main/:?]
	at net.minecraft.client.audio.SoundSystem.init(SoundSystem.java:45) ~[main/:?]
	at net.minecraft.client.audio.SoundEngine.load(SoundEngine.java:76) ~[main/:?]
	at net.minecraft.client.audio.SoundEngine.reload(SoundEngine.java:70) ~[main/:?]
	at net.minecraft.client.audio.SoundHandler.onResourceManagerReload(SoundHandler.java:60) ~[main/:?]
	at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:87) ~[main/:?]
	at net.minecraft.client.Minecraft.startGame(Minecraft.java:338) ~[main/:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:271) ~[main/:?]
	at net.minecraft.client.main.Main.main(Main.java:108) ~[main/:?]
	at Start.main(Start.java:8) ~[main/:?]
ALSA lib ../../pulse/pulse.c:242:(pulse_connect) PulseAudio: Unable to connect: Connection refused

Hey @Snowiiii,
Bad news I'm afraid. Looks like we've been building OpenAL-Soft without the Pipewire backend, because it is not available on Ubuntu 18.04 (the version used by LWJGL-CI). I've tried several approaches, but couldn't get OpenAL-Soft to build with Pipewire on anything other than Ubuntu 22.04 amd64. That is, even on 22.04, the arm64 & armhf builds fail.
One option you have is building your own OpenAL-Soft binary and deploying your application with that. For reference, the LWJGL-CI workflow file is here. At runtime, you can override the loaded library with Configuration.OPENAL_LIBRARY_NAME (or -Dorg.lwjgl.openal.libname).

:c

Same Result Bro :c

@Snowiiii could you please post the output you get when running with the above build? Specifically, with:
export ALSOFT_LOGLEVEL=3
java <your app params here> -Dorg.lwjgl.util.Debug=true -Dorg.lwjgl.util.DebugLoader=true -Dorg.lwjgl.openal.libname=<path to custom build>/libopenal.so

[LWJGL] Version: 3.3.2-snapshot+11
	 OS: Linux v6.2.7-arch1-1
	JRE: Linux amd64 17.0.6
	JVM: OpenJDK 64-Bit Server VM v17.0.6+1-b653.34 by JetBrains s.r.o.
[LWJGL] Loading JNI library: lwjgl
	Module: org.lwjgl
	Using SharedLibraryLoader...
	Found at: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/liblwjgl.so
	Loaded from org.lwjgl.librarypath: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/liblwjgl.so
[LWJGL] Loading library: glfw
	Module: org.lwjgl.glfw
	Using SharedLibraryLoader...
	Found at: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/libglfw.so
	Loaded from org.lwjgl.librarypath: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/libglfw.so
[LWJGL] Loading JNI library: lwjgl_opengl
	Module: org.lwjgl.opengl
	Using SharedLibraryLoader...
	Found at: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/liblwjgl_opengl.so
	Loaded from org.lwjgl.librarypath: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/liblwjgl_opengl.so
[LWJGL] Loading library: libGL.so.1
	Module: org.lwjgl.opengl
	libGL.so.1 not found in org.lwjgl.librarypath=/tmp/lwjgl_snowii/3.3.2-snapshot+11/x64
[LWJGL] Warning: Failed to instantiate memory allocator: org.lwjgl.system.jemalloc.JEmallocAllocator. Using the system default.
[LWJGL] MemoryUtil allocator: StdlibAllocator
[LWJGL] Java 9 text decoding enabled
	Loaded from system paths: /usr/lib/x86_64-linux-gnu/libGL.so.1
[LWJGL] Java 10 multiplyHigh enabled
[LWJGL] Java 9 check intrinsics enabled

[LWJGL] Loading library: openal
	Module: org.lwjgl.openal
	Using SharedLibraryLoader...
	Found at: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/libopenal.so
	Loaded from org.lwjgl.librarypath: /tmp/lwjgl_snowii/3.3.2-snapshot+11/x64/libopenal.so
[LWJGL] [ALC] ALC_SOFT_reopen_device was reported as available but an entry point is missing.
ALSA lib ../../pulse/pulse.c:242:(pulse_connect) PulseAudio: Unable to connect: Connection refused

@Snowiiii Based on the output, it seems like libopenal.so is loaded from 3.3.2-snapshot+11. The LWJGL snapshot does not yet have the Pipewire backend. Have you overwritten that file with the build I linked above?
Also, there should be a lot more output from the OpenAL Soft logging enabled with export ALSOFT_LOGLEVEL=3. The first two lines should be:

[ALSOFT] (II) Initializing library v1.23.0-
[ALSOFT] (II) Supported backends: pipewire, pulse, alsa, oss, jack, port, null, wave

So here how my Intellij Startup looks, The Problem is that its still loading OpenAL from LWJGL and not the custom Build, And the Secound Problem is that i dont really understand where i should put in export ALSOFT_LOGLEVEL=3 i had but it in as Env var but Nothing changed

Hey @Snowiiii,
Try setting -Dorg.lwjgl.openal.libname= to the absolute path of the custom OpenAL build.
Also, the export command should be removed from the Environment variables field. It should be just ALSOFT_LOGLEVEL=3.

Okay now we have more Output yes
[LWJGL] Loading library: /home/snowii/Documents/development/java/Vent-Client-1.8.9-Hack/run/libopenal.so
	Module: org.lwjgl.openal
	Success
[LWJGL] [ALC] ALC_SOFT_reopen_device was reported as available but an entry point is missing.
[ALSOFT] (II) Initializing library v1.23.0-
[ALSOFT] (II) Supported backends: pipewire, pulse, alsa, oss, jack, port, null, wave
[ALSOFT] (II) Loading config /etc/openal/alsoft.conf...
[ALSOFT] (II) Loading config /etc/xdg/alsoft.conf...
[ALSOFT] (II) Loading config /app/etc/xdg/alsoft.conf...
[ALSOFT] (II) Loading config /home/snowii/.alsoftrc...
[ALSOFT] (II) Loading config /home/snowii/.var/app/com.jetbrains.IntelliJ-IDEA-Community/config/alsoft.conf...
[ALSOFT] (II) Got binary: "/app/idea-IC/jbr/bin", "java"
[ALSOFT] (II) Loading config /app/idea-IC/jbr/bin/alsoft.conf...
[ALSOFT] (II) Key disable-cpu-exts not found
[ALSOFT] (II) Vendor ID: "AuthenticAMD"
[ALSOFT] (II) Name: "AMD Ryzen 7 3700U with Radeon Vega Mobile Gfx"
[ALSOFT] (II) Extensions: +SSE +SSE2 +SSE3 +SSE4.1
[ALSOFT] (II) Key rt-prio not found
[ALSOFT] (II) Key rt-time-limit not found
[ALSOFT] (II) Key game_compat/reverse-x not found
[ALSOFT] (II) Key game_compat/reverse-y not found
[ALSOFT] (II) Key game_compat/reverse-z not found
[ALSOFT] (II) Key game_compat/nfc-scale not found
[ALSOFT] (II) Key resampler not found
[ALSOFT] (II) Key uhj/decode-filter not found
[ALSOFT] (II) Key uhj/filter not found
[ALSOFT] (II) Key uhj/encode-filter not found
[ALSOFT] (II) Key trap-al-error not found
[ALSOFT] (II) Key trap-alc-error not found
[ALSOFT] (II) Key reverb/boost not found
[ALSOFT] (II) Key drivers not found
[ALSOFT] (WW) PipeWire version "0.3.66" too old (0.3.67 or newer required)
[ALSOFT] (WW) Failed to initialize backend "pipewire"
[ALSOFT] (II) Key pulse/spawn-server not found
[ALSOFT] (WW) Failed to initialize backend "pulse"
[ALSOFT] (II) Initialized backend "alsa"
[ALSOFT] (II) Added "alsa" for playback
[ALSOFT] (II) Added "alsa" for capture
[ALSOFT] (II) Key excludefx not found
[ALSOFT] (II) Key default-reverb not found
[ALSOFT] (II) Opening playback device "OpenAL Soft"
[ALSOFT] (II) Key alsa/device not found
[ALSOFT] (II) Opening device "default"
ALSA lib ../../pulse/pulse.c:242:(pulse_connect) PulseAudio: Unable to connect: Connection refused

[ALSOFT] (WW) Failed to open playback device: Could not open ALSA device "default"
[ALSOFT] (WW) Error generated on device (nil), code 0xa004
[ALSOFT] (II) Freeing device 0x7f7b4d951f80
[18:43:10] [Client thread/INFO]: Audio Device: OpenAL Soft

That's great @Snowiiii. A new build is up, could you download it and try again please?

Same Result :c

Hmm, no change at this line?

[ALSOFT] (WW) PipeWire version "0.3.66" too old (0.3.67 or newer required)

The new build was built with PipeWire 0.3.50.

Ye looks like 0.3.67 or newer is required

@Snowiiii I checked again, it should be 0.3.50. Are you sure you downloaded the new build and replaced the old one?

[ALSOFT] (II) Found PipeWire version "0.3.66" (0.3.50 or newer)

[ALSOFT] (WW) Failed to initialize backend "pipewire"
[ALSOFT] (II) Key pulse/spawn-server not found
[ALSOFT] (WW) Failed to initialize backend "pulse"
[ALSOFT] (II) Initialized backend "alsa"
[ALSOFT] (II) Added "alsa" for playback
[ALSOFT] (II) Added "alsa" for capture
[ALSOFT] (II) Key excludefx not found
[ALSOFT] (II) Key default-reverb not found
[ALSOFT] (II) Opening playback device "OpenAL Soft"
[ALSOFT] (II) Key alsa/device not found
[ALSOFT] (II) Opening device "default"
ALSA lib ../../pulse/pulse.c:242:(pulse_connect) PulseAudio: Unable to connect: Connection refused

[ALSOFT] (WW) Failed to open playback device: Could not open ALSA device "default"
[ALSOFT] (WW) Error generated on device (nil), code 0xa004
[ALSOFT] (II) Freeing device 0x7fd3d8b73520

FWIW, I was able to get it working on my Linux machine. ALCDemo output:
[ALSOFT] (II) Found PipeWire version "0.3.58" (0.3.50 or newer)
[ALSOFT] (II) Key pipewire/assume-audio not found
[ALSOFT] (II) Ignoring metadata "settings"
[ALSOFT] (II) Ignoring metadata "route-settings"
[ALSOFT] (II) Ignoring node class Midi/Bridge
[ALSOFT] (II) Initialized backend "pipewire"
[ALSOFT] (II) Added "pipewire" for playback
[ALSOFT] (II) Added "pipewire" for capture

pactl info output:
Server String: /run/user/1000/pulse/native
Library Protocol Version: 35
Server Protocol Version: 35
Is Local: yes
Client Index: 264
Tile Size: 65472
User Name: *****
Host Name: *****
Server Name: PulseAudio (on PipeWire 0.3.58)
Server Version: 15.0.0
Default Sample Specification: float32le 2ch 48000Hz
Default Channel Map: front-left,front-right
Default Sink: alsa_output.pci-0000_26_00.1.hdmi-stereo-extra1
Default Source: alsa_output.pci-0000_26_00.1.hdmi-stereo-extra1.monitor

Maybe you could try another machine? Or reinstalling Pipewire and/or pulseaudio? Afaict the pulse library is required, because Pipewire is using it as a backend.

We've verified that the PipeWire backend works now, so closing this.


Render DAG and rendering modules architecture

Rebased onto Develop from PR 3680
Contains whole
GSOC 19 Render DAG
engine architectural changes for rendering: foundation for rendering modules, their ingame configuration, dependency connections foundation for expressing semantics of the dag edges and allow dynamic reconnecting of rendering pipeline.
This PR is accompanied by  new module repo for AdvancedRendering module, BasicRendering module and Peronal repo dag testing module
The progress of these changes as well as final summary (will be) is contained within this personal blog AND within this game forum thread.
One can also try to take a look and compare sketchboard graphs, but the new one ended up more as a helper thing and is not entirely accurate:
Sketchboard I used
Original state of the sketch board for dag.
To run the game with this PR: (edit 10.2019)
You will need at least BasicRendering module and ideally AdvancedRendering module too. Without these activated for a game the game will fail. Right now there is absolutely no check whether user has any kind of graphical settings on, so if your settings demand an advanced effect and you do not activate AdvancedRendering module, the game will fail.
UPDATE (November 5th 2019): Seems the game will crash without AdvancedRendering module now even if advanced effects are off due to DeferredPointLightsNode and DeferredMainLightNode accessing shadowMapNode to get shadowMapCamera while shadowMapNode is in AdvancedRendering module. This should be easily fixable.
Main areas of focus:
Architecture for DAG:

package org.terasology.rendering.dag

Rendering modules subsystem/manager/registry:

package org.terasology.engine.module.rendering;
package org.terasology.engine.subsystem.rendering

Rendering modules UI:

package org.terasology.rendering.nui.layers.mainMenu.videoSettings;

...assets\ui\menu\renderingModuleSettingScreen.ui

and updates in:

package org.terasology.rendering.nui.layers.*
assets: menu_cs.lang, menu_en.lang

Important: Rendering nodes together with some logic have been taken out to BasicRendering and AdvancedRendering modules. These are mandatory for the game as of this moment. AdvancedRendering module is optional but so far there are no guards that will prevent you from trying to turn these effects on, resulting in a crash.
https://github.com/Terasology/AdvancedRendering and
https://github.com/Terasology/BasicRendering to run
Some examples might be found here https://github.com/dave2s/dagTestingModule
How to add a rendering module

Create a new module
Any new rendering class in this module must now extend ModuleRendering and call super(context); in its constructor.
One can optionally call setInitializationPriority(init order to override default of super class -positive integer ); after the super() call.
To connecta new node, a node has to be created first, you can take a look at existing modules to see how it's done. For example Node ambientOcclusionNode = new AmbientOcclusionNode("ambientOcclusionNode", providingModule, context); . After the node is created by calling its constructor, it has to be added to the rendergraph by calling renderGraph.addNode() and for it to do something its output has to be connected and read somewhere - !! If a node is added to the renderGraph but not connected, the graph probably won't build !! (graph condition - amount of nodes visited == all added nodes' size).
ad 4 - new node: To see a minimal implementation of a node, take a look at some existing code - for example any Node in BasicRendering module and mainly their parent - AbstractNode.
ad 4 - connecting: To see an example of connecting the nodes, take a look at either BasicRendering or AdvancedRendering modules' main classes extending ModuleRendering. Interconnecting nodes trough rendergraph consists of calls such as renderGraph.connectFbo() or renderGraph.connectBufferPair(). To see how reconnecting api calls can be used, take a look at AdvancedRendering's addHaze() for example:

renderGraph.reconnectInputBufferPairToOutput(finalHazeNode, 1, opaqueObjectsNode, 1);
renderGraph.reconnectInputBufferPairToOutput(finalHazeNode, 1, opaqueBlocksNode, 1);
renderGraph.reconnectInputBufferPairToOutput(finalHazeNode, 1, alphaRejectBlocksNode, 1);
renderGraph.reconnectInputBufferPairToOutput(finalHazeNode, 1, overlaysNode, 1);

Here you can see an renderGraph api call being used to reconnect finalHazeNode 's output bufferPairConnection to essential block rendering nodes which have been previously connected to a backdropNode as shown here: Use this sketchboard!
If you wanted to do your own rendering modules, you could start by copying starting and OutputToScreenNode nodes from BasicRendering module and add some version of blocks rendering nodes otherwise the game crashes (i'll fill why later)
New node introduction: (edit 16.10.2019)
Node at this stage has to create empty output (data bearing) DependencyConnections in its constructor in order for subsequent nodes to be able to connect to these outputs before the graph gets built and propagates data.
addOutputBufferPairConnection(1);, addOutputFboConnection(1);
How renderGraph connects nodes via dependencies

Nodes are connected newly via their input/output DependencyConnection s. After all modules have been accounted for by the WorldRendererImpl.java, their postInit() and then setDependencies() methods are called. setDependencies being a crucial late initialization method which reads and sets data from/into connections previously connected in the stage of connecting the nodes in ModuleRendering extending class.
After this, based on the dependency connections of all nodes these are connected via legacy connect() of the renderGraph, which uses a private MutableGraph<Node> graph; the same was it used to. This calculation of connections is redone every graph rebuild. It's a naive implementation which might be subject to improvement in the future.

Rebased onto Develop from https://github.com/MovingBlocks/Terasology/pull/3680
Last commit pre GSOC deadline: commit 7aa344563bf4d7b24a6ac0063483c8e2a6c4ef9d

[ ] I'm considering adding Shader dependency type so one can swap shaders for existing nodes from another module without the need to implement any nodes. I recently found this to be more important than we had initialy thought simply because copying whole nodes creates problems sometimes. This is because there are occasionally  some code dependencies for said nodes and they cannot be easily reimplemented in another module. In such case a shader swap could be one of the ways to edit these nodes. Another being reconnecting trough some new nodes. Maybe a shader override could be supplied?
[ ] Fog (regular haze) can't be turned off without breaking visual output atm, though without having advanced rendering on in the first place it should work, but one has to disable all advanced effects first (ambient occlusion, shadows, fog/haze, light shafts, bloom)
[ ] To merge or not to merge?
[ ] Rendering module configuration should get reloaded when loading another game - causes errors if you start a game with some extra module and then try to load a game without it. It's still being initialized? investigate

**Followups: ** (edit 16.10.2019)

[ ] #3650 - Integrate into this PR before merge - RunOrderConnection will need recheck. The order of the nodes is still not correct after using RunOrderConnection() to plug overlay after opaque nodes.
[ ] #3604 - separate vignette node
[ ] #3351 - rendergraph ingame overlay as introduced by mkienenb
[ ] Create a new issue for wiki description of this system.
[ ] #3731 - for saving rendering module configuration per game
[ ] Create a new issue for updating templates with mandatory rendering modules
[ ] Either fix disabled Fog black output or create issue
[ ] Workaround for DeferredLightingNodes not to call shadowMap camera if AdvancedRendering is off and hence the shadowMap is not there. There's more ways to go around this.

This pull request introduces 4 alerts when merging f87eec4c18f70a950b28a078a86df465bf7d9680 into 6ce026dbc434d90fd63275a09fa4bbb06c7c9800 - view on LGTM.com
new alerts:

3 for Dereferenced variable may be null
1 for Unused format argument

Warning - Automated code review for MovingBlocks/Terasology will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 4 alerts when merging 4af9edc0651ae0c55b3275469b7a7c10fb7822c7 into 6ce026dbc434d90fd63275a09fa4bbb06c7c9800 - view on LGTM.com
new alerts:

3 for Dereferenced variable may be null
1 for Unused format argument

Warning - Automated code review for MovingBlocks/Terasology will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 2 alerts when merging 5e22eb5284c7b1492dddbf296efdb0b3c8c284e0 into 6ce026dbc434d90fd63275a09fa4bbb06c7c9800 - view on LGTM.com
new alerts:

2 for Dereferenced variable may be null

Warning - Automated code review for MovingBlocks/Terasology will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 5cd4524a4f44e9765d0dfffb919bd735b2041203 into 6ce026dbc434d90fd63275a09fa4bbb06c7c9800 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Warning - Automated code review for MovingBlocks/Terasology will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 7aa344563bf4d7b24a6ac0063483c8e2a6c4ef9d into 6ce026dbc434d90fd63275a09fa4bbb06c7c9800 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Warning - Automated code review for MovingBlocks/Terasology will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

Not sure if we are merging this now, but I'm commenting here to mark a gsoc end.
commit 7aa344563bf4d7b24a6ac0063483c8e2a6c4ef9d

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

updating description continually

Seems as though run order connections might not be working correctly.

Hooray Jenkins reported success with all tests good!

Uh oh, something went wrong with the build. Need to check on that

Contained and updated in https://github.com/MovingBlocks/Terasology/pull/3909


Updating to Chromium 89.0.4389.72

Please respond if you would like to update ungoogled-chromium to the new stable Chromium version.
Notes for the developer
Once you claim it, it is advisable that you create a Draft Pull Request for increased visibility:

Finally, make sure to reference this issue in your PR.
Feel free to ask questions and discuss issues here along the way. Thanks!
Notes for others
Feel free to raise issues or questions throughout the process. However, please refrain from asking ETAs unless no visible progress has been made here or on the developer's PR for a while (e.g. 2 weeks).

I am currently working on this right now.

My comment is bit off topic but when ungoogled is updated, the safe browser patch for Windows have to be checked upon availability.
The final releases of ungoogled for windows 87.0.4280.141-1 and 88.0.4324.182-1 have every file download with the message "This type of file can harm your computer", which probably is indication of problem with the patch.


Removing old scratch context

What happens when your PR merges?
An old scratch context script was accidentally included, which had a hard-coded (but not active) password for grafana in my scratch account. Removing.

So this should have no affect on staging / prod, correct?

Nope, not used


Hard to find notebooks in marimo homepage

Describe the bug
Using marimo edit in a top level directory, it's extremely hard to find notebooks because the listed notebooks don't appear to be sorted. Would be nice to sort alphabetically, and include the directory nesting structure. Or have a built in file explorer
Environment
0.6.19
Code to reproduce
No response

We can sort alphabetically as a minor enhancement.
A built-in file explorer would be more work. But I do think it would improve navigation, and it would also make marimo edit start up faster.

Closed by https://github.com/marimo-team/marimo/pull/1759


support generate workload certs using the generated intermediate ca

To support scenarios like VM expansion.
Fixes: https://github.com/istio/istio.io/issues/7168

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
beb42d92e49701886e2765a1aa3e2969222265b4
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio/release-managers, unfortunately, this is a release blocker, requiring a new build before the final release.
As is, virtual machines are unusable, hence @duderino 's question about virtual machine expansion being "broken for customers for 6 months or more". @irisdingbj had a PR which was meant to fix this using istioctl but it was reviewed late in the development cycle and a request was made to split up this function from the other function she had added. See https://github.com/istio/istio/pull/22384#discussion_r420425730 for more context.
While the current docs work if you are willing to jump through some serious hoops (including downloading our source tree, running make shell, then running some go code in the repo, then finding the output files) and spend 8-16 hours learning how to create these certificates from our vague documentation, the documentation does not provide a proper user experience.

Clarified workflow documentation: https://github.com/istio/istio.io/pull/7248

@sdake Thanks for the comments, PTAL

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3ef35b4f9ded2c864e62b8eddba27f626cd853ec
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
d2e7d3043f1d93ce885c17cae907eae43db60cbc
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks @costinm. Testing this makefile, with the simplified workflow yields a secure working cluster.

Thanks for the thorough review costin. Appreciate the assist. :)

/test unit-tests_istio

This is great work. Thank you Iris :)

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
d2e7d3043f1d93ce885c17cae907eae43db60cbc
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
d2e7d3043f1d93ce885c17cae907eae43db60cbc
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
d2e7d3043f1d93ce885c17cae907eae43db60cbc
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

In response to a cherrypick label: new pull request created: #23733

@costinm I can’t speak for @irisdingbj. I will ask her to file an issue an stay on top of these improvements.

@costinm @myidpt @sdake Many Thanks for your great review comments. Those make sense to me, I will submit a new PR to address those later(1.7)

Thanks Iris, I'm sure we'll iterate on this and I would love more people to get involved.
If we see any more PRs around support for ECC certs -  please ask them to add an example
to the makefile :-) And I have a make target to test VMs in docker creating certs in a different way -
will need to update it to use the makefile, plus the 'istiod running on a VM' which also requires
the intermediate-cert to be generated.

kubectl get secret istio-ca-secret -n istio-system -o "jsonpath={.data['ca-cert\.pem']}" | base64 -d > ca-cert.pem
kubectl get secret istio-ca-secret -n istio-system -o "jsonpath={.data['ca-key\.pem']}" | base64 -d > ca-key.pem

I am on this


Compilation error: 'connector' cannot appear in a constant-expression

Hi,
I tried my first automaton project and compiled the following sample code
#include <Automaton.h>
Atm_timer timer;
void timer_callback( int idx, int v, int up ) {}
void setup() {
timer.begin(1000)
.repeat(ATM_COUNTER_OFF)
.onTimer(timer_callback)
.start();
}
void loop() {
automaton.run();
}
Unfortunately, I get the following error during compilation:
...Atm_controller.cpp: In member function 'bool Atm_controller::eval_one(atm_connector&)':
...Atm_controller.cpp:47:10: error: 'connector' cannot appear in a constant-expression
case connector.REL_EQ:
(And a lot more of similar errors)
What is the reason of this error ?
Thanks,
John

It doesn't occur in my setup. It's been reported before, though. What's your setup? Which board are you using and what version of the IDE? Anyway, in the current version all the constant references have been changed like this:
    case connector::REL_EQ:
      return connector.pull() == connector.event;

changed to:
    case atm_connector::REL_EQ:
      return connector.pull() == connector.event;

So if you use the latest version of Automaton you should be OK. I'm guessing this is some C++ compiler version/setting problem.


fix: sycing receipt showing up even after expense is created

Description
copilot:summary
copilot:poem
Walkthrough
copilot:walkthrough
Clickup
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes

:rocket: This PR description was created by Ellipsis for commit e4b1d301add2aeca6a62f41550babcd2c57e6cbf.

Summary:
This PR updates the my-expenses.page.ts file to fix the syncing receipt issue and removes a previously added console log statement from the doRefresh() function.
Key points:

Updated my-expenses.page.ts to refresh the page and clear the pending transactions array when there are no pending transactions.
Removed a console log statement from the doRefresh() function in the my-expenses.page.ts file.

Generated with :heart: by ellipsis.dev

@Chethan-Fyle tests are fixed here - https://github.com/fylein/fyle-mobile-app/pull/2868


powershell_script move validation into one shell_out!

@jaym This reverts your change from https://github.com/chef/chef/pull/3815, but reduces the number of shell_outs to one, where we get validation and execution from one powershell process.  /cc @chef/client-windows

Got a failing functional test for the resource.. gonna fix that one

The travis failure appears unrelated to any changes in this PR.

And looks like my build failures match the state of master.

@chef/client-windows need a :+1: or two because this is over my head

Current output with a bonus quote:
[2015-11-23T18:51:36-05:00] FATAL: Mixlib::ShellOut::ShellCommandFailed: powershell_script[write-to-interpolated-path] ((chef-apply cookbook)::(chef-apply recipe) line 1) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of "powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -Command ". 'C:/Users/btm_000/AppData/Local/Temp/chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1'" ----
STDOUT:
STDERR: At C:\Users\btm_000\AppData\Local\Temp\chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1:4 char:25
+     $stream.WriteLine(''foo')
+                         ~
Missing ')' in method call.
At C:\Users\btm_000\AppData\Local\Temp\chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1:4 char:28
+     $stream.WriteLine(''foo')
+                            ~~
The string is missing the terminator: '.
At C:\Users\btm_000\AppData\Local\Temp\chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1:4 char:25
+     $stream.WriteLine(''foo')
+                         ~~~~~
Unexpected token 'foo')
    $stream.close()
}
' in expression or statement.
At C:\Users\btm_000\AppData\Local\Temp\chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1:1 char:1
+ {
+ ~
Missing closing '}' in statement block or type definition.
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : MissingEndParenthesisInMethodCall
---- End output of "powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -Command ". 'C:/Users/btm_000/AppData/Local/Temp/chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1'" ----
Ran "powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -Command ". 'C:/Users/btm_000/AppData/Local/Temp/chef_powershell_script-user-code20151123-24316-1ugk7hk.ps1'" returned 1

Output under this PR:
[2015-11-23T18:48:10-05:00] FATAL: Mixlib::ShellOut::ShellCommandFailed: powershell_script[write-to-interpolated-path] ((chef-apply cookbook)::(chef-apply recipe) line 1) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '5'
---- Begin output of "powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -File "C:/Users/btm_000/AppData/Local/Temp/chef-script20151123-3892-1yn6uqi.ps1" ----
STDOUT:
STDERR: New-UserScriptBlock : Exception calling "NewScriptBlock" with "1" argument(s): "At line:3 char:25
+     $stream.WriteLine(''foo')
+                         ~
Missing ')' in method call.
At line:3 char:25
+     $stream.WriteLine(''foo')
+                         ~~~~~
Unexpected token 'foo')
    $stream.close()
  # This assignment doesn't' in expression or statement.
At line:7 char:45
+   # This assignment doesn't affect the block's return value
+                                             ~~~~~~~~~~~~~~~
The string is missing the terminator: '."
At C:\Users\btm_000\AppData\Local\Temp\chef-script20151123-3892-1yn6uqi.ps1:38 char:22
+ $chefscriptresult = (New-UserScriptBlock).invokereturnasis()
+                      ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,New-UserScriptBlock
---- End output of "powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -File "C:/Users/btm_000/AppData/Local/Temp/chef-script20151123-3892-1yn6uqi.ps1" ----
Ran "powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -File "C:/Users/btm_000/AppData/Local/Temp/chef-script20151123-3892-1yn6uqi.ps1" returned 5

Looks pretty similar. There's some added noise from the wrapper which could be confusing, but it is all pretty noisy so I'm not that concerned. The return code of 5 is interesting.


calling closedconnection.close() should not throw exception.

this still have fix for #456, removed redundent call and minor cleanup


Print stylesheet

Does skeleton need a print stylesheet?  When printing with chrome, content runs off the side of the page.
Including the following fixes the problem:
@media print {
  .container {width: 100%}
  .container .sixteen.columns {width: 100%}
}

but that's obviously a crude hack for my special case.

@hadley Good suggestion, but outside the scope of Skeleton. I never intended for print styles to be a part of Skeleton (although I would encourage people to create one if their site is likely to be printed).
Thanks for the suggestion, but I don't feel like it matches with the purpose of Skeleton.
Cheers,
Dave

I think it's reasonable to expect that print a webpage prints the entire webpage, not something with cutoff edges.  I don't expect skeleton to support a full on print style sheet, but including the minimum so the page can actually be printed would be useful.

Here is a really simple print.css/@media print that ought should 99% of people’s needs, in case they search for a similar issue and aren’t comfortable with CSS:
.column,
.columns {
    width: 100% !important; /** 100% of 85% container */
    margin-left: 0% !important;
    page-break-inside: avoid;

In use at https://ndarville.com/projects/slack.
You might want to reduce font sizes amongst other things, but people can probably take it from here. :)


Issue #4059 - comments handling before and after long attrs or list

Resolve issue #4059  formatting when comments are before/after long attribute or at the end of long list or list, like:
fn a1 /* comment */ (#[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa] a: u8) {}
fn a1(#[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa] /* comment */ a: u8) {}
Also partly fixed following example.  Will be fully fixed with #2896 resolution:
fn main() {
use crate::formatting::{
    comment::{collect_comment_contents, combine_strs_with_missing_comments, rewrite_comment
	},/* COMMENT <<<<*/
}; }

Thank you for the PR! This has caused quite a lot of test failures, could you please take a look and adjust the proposed changes accordingly?
Also, we really shouldn't be moving comments down to a separate line, especially when there's no need to; the inline comments in these cases are associated with the line they are on, and moving them won't be strictly semantic preserving.
Lastly, please also add some test cases that cover the referenced issues.

Hopefully the issue was fixed.  It was related to extra whitespace that were at the end of the line when comment was moved to new line.  There are still some test errors, but none seem to be related to the changes I made (most of them are because of tests/parser/issue-4126/invalid.rs).
I don't understand the comment about "we really shouldn't be moving comments down to a separate line".  This is done when line width is not large enough to include the comment.
I will add related tests.

I don't understand the comment about "we really shouldn't be moving comments down to a separate line". This is done when line width is not large enough to include the comment.

If you look at the results from the failing tests, you can see that's not the case. The proposed changes in this PR are causing all sorts of comments to be moved down when they absolutely should not be moved. For example:
Mismatch at tests/source/enum.rs:68:
-    SkippedItem(String,String,), // Post-comment
+    SkippedItem(String,String,),
+    // Post-comment
     #[another_attr]
     #[attr2]
     ItemStruct {

OK. Thanks. I now see the problem (I have to learn how to better look at the tests results).  Will evaluate.

OK. Thanks. I now see the problem (I have to learn how to better look at the tests results).

No worries! The output from test failures is probably most easily viewed in your local terminal, but you can also see them (albeit without colorized diffs) in the CI logs https://github.com/rust-lang/rustfmt/pull/4390/checks?check_run_id=1008055033


Fix connectionState being incorrect

connectionState now relies on lifecyle and values of its javascript peer
Fixes #10

@cloudwebrtc Can you please review this?
Many thanks!


Exclude testing external certificates in version 22.2.x

Follow up to https://github.com/redpanda-data/helm-charts/pull/544 and https://github.com/redpanda-data/helm-charts/pull/553
The test failed https://github.com/redpanda-data/helm-charts/actions/runs/5298460320/jobs/9590824785 due to inability to verify schema registry as it doesn't exist in Redpanda configuration.

Nice, thank you


Detect callables in any static array

more generic version of https://github.com/TomasVotruba/unused-public/pull/139
based on a idea of jan Nedbal: https://x.com/janedbal/status/1865011327674003650

Thank you 🙏


Update for Cretonne reloc changes.

As a precursor to starting on clang2cretonne, I've been trying to get llvm2cretonne to compile. These are the last errors I ran into from changes to Cretonne reloc handling.
@sunfishcode, you might already have local changes that fix this, but I've chosen to pass the addend along with the offset in the relocs tuple.  Should addend be added to offset instead?

@djg Keeping the addend separate is the right way to go here. The offset refers to where in the code the relocation applies to, while the addend is added to the symbol value that is written there.

Thanks for review @sunfishcode. I'll update the patches soon.
On 23 Dec. 2017 09:53, "Dan Gohman"<EMAIL_ADDRESS>wrote:

@sunfishcode commented on this pull request.
This looks good. I indeed don't have local mods for this yet, so thanks
for updating this!
In lib/llvm/src/module.rs
https://github.com/sunfishcode/llvm2cretonne/pull/4#discussion_r158569854
:

@@ -69,8 +69,11 @@ impl<'a> fmt::Display for DisplayCompiledFunction<'a> {
write!(f, "0x{:02x}, ", byte)?;
}
write!(f, "\n")?;

       for &(ref reloc, ref name, ref offset) in &compilation.relocs.relocs {

           write!(f, "reloc: {}:{}@{}\n", reloc, name, offset)?;

       for &(ref reloc, ref name, ref offset, addend) in &compilation.relocs.relocs {

           match addend {

               0 => write!(f, "reloc: {}:{}@{}\n", reloc, name, offset)?,

               _ => write!(f, "reloc: {}:{}@{}{}\n", reloc, name, offset, addend)?,

Because the addend is added to the symbol value, it's best to print it
after the name, rather than after the offset.
In lib/llvm/src/reloc_sink.rs
https://github.com/sunfishcode/llvm2cretonne/pull/4#discussion_r158569897
:

 ) {

   self.relocs.push((reloc, name.clone(), offset));

   // TODO: How should addend be handled? Should it be added to

   // offset and stored in self.relocs or carried through beside

   // offset?

Carried through. Your code is doing the right thing.
In src/llvm.rs
https://github.com/sunfishcode/llvm2cretonne/pull/4#discussion_r158569991
:

             // FIXME: What about other types of relocs?

             // TODO: Faerie API: Seems like it might be inefficient to
             // identify the caller by name each time.
             // TODO: Faerie API: It's inconvenient to keep track of which
             // symbols are imports and which aren't.

           // TODO: How should addend be handled? Should it be added to offset here?

You can pass the added to faerie below, replacing the 0 in the addend: 0
below, which should do everything needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sunfishcode/llvm2cretonne/pull/4#pullrequestreview-85409662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJhrcn4fEL1fBkHAEfVdbxGbqX3g6J1ks5tDEDtgaJpZM4RKiP1
.

@sunfishcode, I updated based on your comments. This should be good to merge now.

Great, thanks!


bug: threshold ranges on ThinkPads

Computer: Lenovo ThinkPad T14 Gen 1 AMD (manufactured in 2021)
CPU: AMD Ryzen PRO 7 4750U
OS: Ubuntu 24.04
I could not set a battery threshold on my Lenovo ThinkPad T14 Gen1 (while it works on my Asus ROG Strix G15 2021). I got the following error:
$ sudo bat threshold 80
A fatal error occurred. Please rerun the command with the `--debug` flag enabled
and file an issue with the resulting output at the following address
https://github.com/tshakalekholoane/bat/issues/new.

with the debug flag:
$ sudo bat threshold 80 --debug
write /sys/class/power_supply/BAT0/charge_control_end_threshold: invalid argument

goroutine 1 [running]:
runtime/debug.Stack()
	/opt/homebrew/Cellar/go/1.22.0/libexec/src/runtime/debug/stack.go:24 +0x5e
main.main.func1()
	/Users/tshaka/x/bat/main_linux.go:111 +0x57
panic({0x5383a0?, 0xc000124270?})
	/opt/homebrew/Cellar/go/1.22.0/libexec/src/runtime/panic.go:770 +0x132
main.main()
	/Users/tshaka/x/bat/main_linux.go:247 +0x1125

When searching on the battery system path, I found the UbuntuHandbook page on setting battery threshold. Trying to set the end threshold manually failed as well:
$ sudo sh -c "echo 80 > /sys/class/power_supply/BAT0/charge_control_end_threshold"
sh: 1: echo: echo: I/O error

It led me to try manually setting the lower charging threshold to a lower value than the end value:
sudo sh -c "echo 20 > /sys/class/power_supply/BAT0/charge_control_start_threshold"

Which I unfortunately did before trying to read the current value. :-( I don't know what it was before. Afterwards, I could set the end threshold, manually or with bat.
I gather that the end threshold must not be lower than the start threshold.

Uh... actually, I think I got the threshold backwards. I'm comparing with values on my Asus ROG Strix G15. It only has one value: charge_control_end_threshold. And I set it to 80. There is no start threshold.
My Lenovo ThinkPad T14 G1 has two thresholds:

charge_control_end_threshold
charge_control_start_threshold

as well as two legacy APIs that are supposedly synchronized with those two.

Thank you for reporting this. Do you have any idea how charge_control_start_threshold should be handled? It seems like it could be set by the user, but maybe there is a sane default, depending on charge_control_end_threshold..?

Yes, I found the way it works in the Device Compatibility section on ThinkPad in the Battery Health Charging GNOME extension documentation. It depends on the direction of the movement of the thresholds: up or down. The threshold closest to the target must be modified first. That's why bat failed to lower my ThinkPad's threshold from 100 to 80. It was decreasing the end threshold to a lower value than the start. And manually setting the start threshold to a lower value allowed bat to set the end threshold.
Battery Health Charging supports 3 profiles and their defaults define 5 percent windows with the sart/end thresholds:

Maximum Lifespan:  55-60
Balanced: 75-80
Full Capacity: 95-100

If the thresholds are decreased (e.g. from 100 to 60), then charge_control_start_threshold must be set first (e.g. to 55), then charge_control_end_threshold (e.g. to 60):
echo '55' | sudo tee /sys/class/power_supply/BAT0/charge_control_start_threshold
echo '60' | sudo tee /sys/class/power_supply/BAT0/charge_control_end_threshold

If the thresholds are increased (e.g. from 60 to 80), then charge_control_end_threshold must be set first (e.g. to 80), then charge_control_start_threshold (e.g. to 75):
echo '80' | pkexec tee /sys/class/power_supply/BAT0/charge_control_end_threshold
echo '75' | pkexec tee /sys/class/power_supply/BAT0/charge_control_start_threshold

OK, I think just set the start value 5 lower than the end, and check which one needs to be set first.

I had a thought about how this could be implemented without breaking changes in the API.
We could change the threshold argument to accept a range such that the user could pass a range to the threshold subcommand e.g.,
bat threshold 55,60

To maintain backwards compatibility, setting a single value would imply 0 as a lower bound, on devices that have a start threshold setting.
# The following are equivalent.
bat threshold 60
bat threshold 0, 60

What do you think?

Personnally, I don't see the point of the start threshold either. I've been using the Battery Health Charging extension in GNOME for a few months and I never felt the need to customize the thresholds. I use the built-ins 60, 80 and 100, which set 55, 75 and 95 start thresholds on my ThinkPad T14. I would always set the start threshold 5 points below the end threshold.
I'm going to do some tests with that start threshold on my ThinkPad T14 because I don't understand what it does either.
By the way, I recently wrote over Ubuntu on that ThinkPad with another distro I wanted to try out, and I was suprised to see that the thresholds had persisted after the whole disk erasure. And I still could change them manually. Where could they be stored? In the TPM chip?

They get reset to 100/0 (no end threshold) when the module loads. When the module never loads again, the value must get stored somewhere in the UEFI/BIOS area.

OK, then start has to be set a little bit lower than end.

You can try the batlimit binary here to see if this works: https://github.com/pepa65/batlimit/releases/tag/0.6.0

I noticed in the Makefile that you use gofumpt for formatting, and it requires go 1.22, yet the go.mod file specifies version 1.21.  Which version of go should I be using?

You can disregard the requirements of gofumpt or any other tool in the Makefile. For the application, any version >= 1.18 should be fine and you're welcome to bump it to a later version if you need to.


Create increase-request-size.md

Description
Add documentation for the "--dapr-http-max-request-size" argument for the CLI and "dapr.io/http-max-request-size" annotation
Issue reference
#1099

@apuzyrevsky  Thanks for this. I have done a few changes on the description and format. Please take a look.

@apuzyrevsky Thanks for this. I have done a few changes on the description and format. Please take a look.

Looks good, thank you.


Adding travis runner

This PR adds a Docker container that simulates the environment in which the tests are run in Travis. It installs dotnetcore as well in case we will be able to test the packages in this environment.
The NuGet.Config file is now fixed to use Nuget v2 instead of v3, which will fail when using Mono.

LGTM


Parameterization stage

Originally discussed around lot size.
We have a number of economic and security parameters that we've left floating until we have proper simulations or rationale.

The standard lot size. We've talked about 0.1 to 1 BTC. 1 BTC has the most momentum but the question deserves settling before mainnet. -> there are now multiple governable lot sizes; see #415
[x] m and n for threshold wallets. These parameters are core to fund security and the cost of acting as a signer. -> this will be 3 of 3

We're all done here. Updated the description with final changes and closing.


(Request) add heroic-game-launcher

PackageIdentifier: Heroic
PackageVersion: 1.8.2
PackageLocale: en-US
Publisher: flavioislima
PackageName: Heroic-game-launcher
License: open source
ShortDescription: open source epic game client
Installers:
Architecture: x64
InstallerType: exe
InstallerUrl: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/releases/download/v1.8.2/Heroic.Setup.1.8.2.exe
ManifestType: singleton
ManifestVersion: 1.0.0

This should be sent to the Games bucket

This is not a game in the traditional sense. it is more like a third party wrapper/launcher to the online service called Epic games store

Yes, launcher or games, both belong in Games bucket


adjust Dockerfile

Description
A clear and concise description of what you're missing.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
If this issue requests multiple changes consider using checkboxes or lists.

For reference: https://github.com/tugraz-rdm/damap-backend-tugraz/blob/108a7de2ed7e351a4561e7c03759fd84a5707fc8/Dockerfile#L8-L16


src/utilities/index.js docblock

 * @param {Tag} tag - Tag Object to Write
Should be
 * @param {Promise} - promise to complete before the timeout

fixed this in PR #43


ZWO image works then black

Howdy do-
I have a ZWO camera attached, and I cant seem to figure out what setting is causing the issue I'm having (I think I've played with all the relevant nobs). The symptom I'm having is that I get one frame, and all the subsequent frames are black. If I restart the process, same thing happens again; one good frame and the resulting ones are black.
I'm running this off of a Raspi 4 with 4GB RAM on the USB3 port. I've tried different power supplies in an attempt to rule them out.
This is from the logs:
Aug  7 04:12:50 allsky allsky.sh[4436]: Starting allsky camera...
Aug  7 04:13:13 allsky allsky.sh[4595]: Making sure allsky.sh is not already running...
Aug  7 04:13:13 allsky allsky.sh[4595]: can't get debug descriptor: Resource temporarily unavailable
Aug  7 04:13:13 allsky allsky.sh[4595]: Trying to automatically choose between ZWO and RPI camera
Aug  7 04:13:13 allsky allsky.sh[4595]: ZWO camera found. Choosing ZWO
Aug  7 04:13:13 allsky allsky.sh[4595]: Settings check done
Aug  7 04:13:13 allsky allsky.sh[4595]: CAMERA: ZWO
Aug  7 04:13:13 allsky allsky.sh[4595]: CAMERA_SETTINGS: /etc/raspap/settings_ZWO.json
Camera is a ZWO ASI120MC-S

I installed it on my Windows box to play with the settings. I guess for daytime I need to do 1ms for each exposure, as it probably was overexposing.
Still working it out to share the setting values I resulted in.

Oh hey, just looked at the new git pushes... did a pull and it all works now! All the settings work again.


[Fix] Fix clang-18 and libc++ compile problems

Proposed changes
Issue Number: close #xxx
Fix clang-18 and libc++ compile problems
unique() of shared_ptr is deprecated in clang-18, it's not a strict implementation, can use use_count() instead.
And fixed some other compie errors in both using clang-18 and libc++.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...


linux系统安装 paddlepaddle一直有gcc错误，请问有什么快捷解决方法吗？

(paddle_fei) [root@czq-gpu uie]# /root/anaconda3/envs/paddle_fei/bin/pip  install --upgrade paddlepaddle==2.3.0 -i https://mirror.baidu.com/pypi/simple
Looking in indexes: https://mirror.baidu.com/pypi/simple
Collecting paddlepaddle==2.3.0
Using cached https://mirror.baidu.com/pypi/packages/92/25/c4dc9ab8364e4a885580bff95603d9f7a6252662d948cbed2a44ac3916f2/paddlepaddle-2.3.0-cp39-cp39-manylinux1_x86_64.whl (112.4 MB)
Requirement already satisfied: numpy>=1.13 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from paddlepaddle==2.3.0) (1.22.3)
Requirement already satisfied: requests>=2.20.0 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from paddlepaddle==2.3.0) (2.27.1)
Collecting opt-einsum==3.3.0
Using cached https://mirror.baidu.com/pypi/packages/bc/19/404708a7e54ad2798907210462fd950c3442ea51acc8790f3da48d2bee8b/opt_einsum-3.3.0-py3-none-any.whl (65 kB)
Collecting astor
Using cached https://mirror.baidu.com/pypi/packages/c3/88/97eef84f48fa04fbd6750e62dcceafba6c63c81b7ac1420856c8dcc0a3f9/astor-0.8.1-py2.py3-none-any.whl (27 kB)
Requirement already satisfied: decorator in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from paddlepaddle==2.3.0) (5.1.1)
Requirement already satisfied: protobuf>=3.1.0 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from paddlepaddle==2.3.0) (3.20.1)
Collecting paddle-bfloat==0.1.2
Using cached https://mirror.baidu.com/pypi/packages/b6/a0/c5208e7814666ff80f5e846e37f31db971429e18d4f13eeea0633b281d5e/paddle_bfloat-0.1.2.tar.gz (553 kB)
Preparing metadata (setup.py) ... done
Requirement already satisfied: six in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from paddlepaddle==2.3.0) (1.16.0)
Requirement already satisfied: Pillow in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from paddlepaddle==2.3.0) (9.1.0)
Requirement already satisfied: idna<4,>=2.5 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from requests>=2.20.0->paddlepaddle==2.3.0) (3.3)
Requirement already satisfied: charset-normalizer~=2.0.0 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from requests>=2.20.0->paddlepaddle==2.3.0) (2.0.12)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from requests>=2.20.0->paddlepaddle==2.3.0) (1.26.9)
Requirement already satisfied: certifi>=2017.4.17 in /root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages (from requests>=2.20.0->paddlepaddle==2.3.0) (2021.10.8)
Building wheels for collected packages: paddle-bfloat
Building wheel for paddle-bfloat (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [61 lines of output]
/root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages/setuptools/dist.py:757: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
warnings.warn(
running bdist_wheel
running build
running build_ext
building 'paddle_bfloat' extension
creating build
creating build/temp.linux-x86_64-3.9
gcc -pthread -B /root/anaconda3/envs/paddle_fei/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /root/anaconda3/envs/paddle_fei/include -I/root/anaconda3/envs/paddle_fei/include -fPIC -O2 -isystem /root/anaconda3/envs/paddle_fei/include -fPIC -I/root/anaconda3/envs/paddle_fei/include/python3.9 -I/root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages/numpy/core/include -c bfloat16.cc -o build/temp.linux-x86_64-3.9/bfloat16.o -std=c++11
bfloat16.cc:71:28: error: expected type-specifier
using Safe_PyObjectPtr = std::unique_ptr<PyObject, PyDecrefDeleter>;
^
bfloat16.cc:72:3: error: ‘Safe_PyObjectPtr’ does not name a type
Safe_PyObjectPtr make_safe(PyObject object)
^
bfloat16.cc: In function ‘bool paddle::{anonymous}::CastToBfloat16(PyObject, paddle::{anonymous}::bfloat16*)’:
bfloat16.cc:180:5: error: ‘Safe_PyObjectPtr’ was not declared in this scope
Safe_PyObjectPtr ref;
^
bfloat16.cc:180:22: error: expected ‘;’ before ‘ref’
Safe_PyObjectPtr ref;
^
bfloat16.cc:184:53: error: ‘make_safe’ was not declared in this scope
ref = make_safe(PyArray_Cast(arr, npy_bfloat16));
^
bfloat16.cc:189:15: error: ‘std::ref’ does not have class type
arg = ref.get();
^
bfloat16.cc: In function ‘bool paddle::{anonymous}::RegisterUFunc(PyObject*, const char*)’:
bfloat16.cc:1023:4: error: ‘Safe_PyObjectPtr’ was not declared in this scope
Safe_PyObjectPtr ufunc_obj = make_safe(PyObject_GetAttrString(numpy, name));
^
bfloat16.cc:1023:21: error: expected ‘;’ before ‘ufunc_obj’
Safe_PyObjectPtr ufunc_obj = make_safe(PyObject_GetAttrString(numpy, name));
^
bfloat16.cc:1024:9: error: ‘ufunc_obj’ was not declared in this scope
if (!ufunc_obj)
^
bfloat16.cc:1028:61: error: ‘ufunc_obj’ was not declared in this scope
PyUFuncObject *ufunc = reinterpret_cast<PyUFuncObject *>(ufunc_obj.get());
^
bfloat16.cc: In function ‘bool paddle::Initialize()’:
bfloat16.cc:1742:3: error: ‘Safe_PyObjectPtr’ was not declared in this scope
Safe_PyObjectPtr numpy_str = make_safe(PyUnicode_FromString("numpy"));
^
bfloat16.cc:1742:20: error: expected ‘;’ before ‘numpy_str’
Safe_PyObjectPtr numpy_str = make_safe(PyUnicode_FromString("numpy"));
^
bfloat16.cc:1743:8: error: ‘numpy_str’ was not declared in this scope
if (!numpy_str)
^
bfloat16.cc:1747:20: error: expected ‘;’ before ‘numpy’
Safe_PyObjectPtr numpy = make_safe(PyImport_Import(numpy_str.get()));
^
bfloat16.cc:1748:8: error: ‘numpy’ was not declared in this scope
if (!numpy)
^
bfloat16.cc:1892:64: error: ‘numpy’ was not declared in this scope
RegisterUFunc<BinaryUFunc<bfloat16, bfloat16, ufuncs::Add>>(numpy.get(), "add") &&
^
error: command '/usr/bin/gcc' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for paddle-bfloat
Running setup.py clean for paddle-bfloat
Failed to build paddle-bfloat
Installing collected packages: paddle-bfloat, opt-einsum, astor, paddlepaddle
Running setup.py install for paddle-bfloat ... error
error: subprocess-exited-with-error
× Running setup.py install for paddle-bfloat did not run successfully.
│ exit code: 1
╰─> [63 lines of output]
/root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages/setuptools/dist.py:757: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
warnings.warn(
running install
/root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_ext
building 'paddle_bfloat' extension
creating build
creating build/temp.linux-x86_64-3.9
gcc -pthread -B /root/anaconda3/envs/paddle_fei/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /root/anaconda3/envs/paddle_fei/include -I/root/anaconda3/envs/paddle_fei/include -fPIC -O2 -isystem /root/anaconda3/envs/paddle_fei/include -fPIC -I/root/anaconda3/envs/paddle_fei/include/python3.9 -I/root/anaconda3/envs/paddle_fei/lib/python3.9/site-packages/numpy/core/include -c bfloat16.cc -o build/temp.linux-x86_64-3.9/bfloat16.o -std=c++11
bfloat16.cc:71:28: error: expected type-specifier
using Safe_PyObjectPtr = std::unique_ptr<PyObject, PyDecrefDeleter>;
^
bfloat16.cc:72:3: error: ‘Safe_PyObjectPtr’ does not name a type
Safe_PyObjectPtr make_safe(PyObject object)
^
bfloat16.cc: In function ‘bool paddle::{anonymous}::CastToBfloat16(PyObject, paddle::{anonymous}::bfloat16*)’:
bfloat16.cc:180:5: error: ‘Safe_PyObjectPtr’ was not declared in this scope
Safe_PyObjectPtr ref;
^
bfloat16.cc:180:22: error: expected ‘;’ before ‘ref’
Safe_PyObjectPtr ref;
^
bfloat16.cc:184:53: error: ‘make_safe’ was not declared in this scope
ref = make_safe(PyArray_Cast(arr, npy_bfloat16));
^
bfloat16.cc:189:15: error: ‘std::ref’ does not have class type
arg = ref.get();
^
bfloat16.cc: In function ‘bool paddle::{anonymous}::RegisterUFunc(PyObject*, const char*)’:
bfloat16.cc:1023:4: error: ‘Safe_PyObjectPtr’ was not declared in this scope
Safe_PyObjectPtr ufunc_obj = make_safe(PyObject_GetAttrString(numpy, name));
^
bfloat16.cc:1023:21: error: expected ‘;’ before ‘ufunc_obj’
Safe_PyObjectPtr ufunc_obj = make_safe(PyObject_GetAttrString(numpy, name));
^
bfloat16.cc:1024:9: error: ‘ufunc_obj’ was not declared in this scope
if (!ufunc_obj)
^
bfloat16.cc:1028:61: error: ‘ufunc_obj’ was not declared in this scope
PyUFuncObject *ufunc = reinterpret_cast<PyUFuncObject *>(ufunc_obj.get());
^
bfloat16.cc: In function ‘bool paddle::Initialize()’:
bfloat16.cc:1742:3: error: ‘Safe_PyObjectPtr’ was not declared in this scope
Safe_PyObjectPtr numpy_str = make_safe(PyUnicode_FromString("numpy"));
^
bfloat16.cc:1742:20: error: expected ‘;’ before ‘numpy_str’
Safe_PyObjectPtr numpy_str = make_safe(PyUnicode_FromString("numpy"));
^
bfloat16.cc:1743:8: error: ‘numpy_str’ was not declared in this scope
if (!numpy_str)
^
bfloat16.cc:1747:20: error: expected ‘;’ before ‘numpy’
Safe_PyObjectPtr numpy = make_safe(PyImport_Import(numpy_str.get()));
^
bfloat16.cc:1748:8: error: ‘numpy’ was not declared in this scope
if (!numpy)
^
bfloat16.cc:1892:64: error: ‘numpy’ was not declared in this scope
RegisterUFunc<BinaryUFunc<bfloat16, bfloat16, ufuncs::Add>>(numpy.get(), "add") &&
^
error: command '/usr/bin/gcc' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> paddle-bfloat
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

建议使用conda来安装环境
https://www.paddlepaddle.org.cn/

感谢，牛的


Run and Debug and Run without debugging didn't respect environment from build preset

Brief Issue Summary
I have a library dependency which has same dll names for debug and release builds, but has different folder. So I need to have build configuration - dependent item in PATH.
It looks like it's not possible in v1.11.26.
Currently I have launch.json with ${input:configuration} so user can select which version to debug/run.
Native solution is to add it to CMakePresets.json. It supports environment for configuration and build presets. But looks like plugin doesn't respect environment from build preset, only from configuration.
CMakePresets.json
{
    "version": 3,
    "cmakeMinimumRequired": {
        "major": 3,
        "minor": 21,
        "patch": 0
    },
    "configurePresets": [
        {
            "name": "default"
            "environemnt": {"var1": "value1", "var2": "$env{configuration}"}
        }
    ],
    "buildPresets": [
        {
            "name": "Debug",
            "configurePreset": "default",
            "configuration": "Debug",
            "environemnt": {"configuration": "Debug"}
        },
        {
            "name": "Release",
            "configurePreset": "default",
            "configuration": "Realase"
            "environemnt": {"configuration": "Release"}
        }
   ]

With that file I'd expect to have

var1=value1
var2=Debug or var2=Release
configuration=Debug or configuration=Release

But when I start debug or just run it using cmake plugin I have only

var1=value1

CMake Tools Diagnostics
No response
Debug Log
No response
Additional Information
No response

What exactly are you trying to do here? It looks like you are trying to use a multi-config generator, In order to have two different values, you will have to define two different configure presets, because a multi-config generator will generate all the configurations at once.
Because configure happens before build, any variable you define on buildpreset, won't be available during configuration.


Could I use Chatterbot completed trained myself

Could I use Chatterbot completed trained by myself?
I want to let it  response the answers only in my training list,

Yes, you can create your own set of questions and answers an train chatterbot accordingly.

Yes, you can create your own set of questions and answers an train chatterbot accordingly.


Added the Animated Coffee Machine

Animated Coffee Machine
Successfuly resolved Issue #1050
Close #1050
Checklist:

[X] I have mentioned the issue number in my Pull Request.
[ ] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

https://github.com/priyankarpal/ProjectsHut/pull/1279
invalid PR


Plan/start migration from goodtables.io

Overview
@sapetti9 Once #6 is done we can start creating issues/PR for goodtables.io users with a recommendation to migrate

Should there be a migration guide of sorts from goodtables.io, especially for repositories containing goodtables.yml configurations file? Or is the .github/frictionless.yaml file 100% drop-in replacement compatible?
Even if it's not, at least a short note about it in the documentation would be warranted, I think. By searching the site I found this link, but it's broken.

Yes @augusto-herrmann, we will prepare a migration guide

DONE


avoid cleanup entire namespace in mc tests

Potential timesave for multicluster tests with multiple suites.
Probably only worth merging if we see a decent amount of time saved – the branching introduced with the istiod-less remote and external control plane logic can easily introduce edge cases with additional config that needs cleaning up.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
65da6f701c787f8b4aa8e7e16fc8c4cfc16c3fe9
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Some bugs need to be fixed.

The select box in the code box cannot be clicked if not set.
The cursor jump interval is too short, it is difficult to switch after a part is written.
Sometimes the cursor jumps suddenly when typing characters in a box.

Should be fixed in v0.0.10, feel free to reopen if you have further questions.


Inject ENV variables into build

Original Discussion: https://www.pika.dev/npm/snowpack/discuss/253
/cc @jiay0u, @FredKSchott
Currently, Snowpack has no good way to read env variables into your frontend application. Things like process.env.NODE_ENV won't work, since process is a Node thing that doesn't exist in the browser.
We should support either import.meta.env.FOO (Node-style) or import.meta.getEnv('FOO') (Deno style). Since this is a build-time transformation that gets converted to a string (and not an actual function call) I think Node-style makes the most sense.
The easiest way to test this would be as a 3rd party plugin that implements this in a transform() function. If we can get that working, then we can decide to integrate it into Snowpack directly.

See https://create-react-app.dev/docs/adding-custom-environment-variables/ for how CRA does it.
https://github.com/vitejs/vite seems to have first-party support for .env files, which is also interesting. I'd love to see a plugin that supports this as well.

How would you go about this?
I can easily see how a transform plugin would add this in to a file's content, however how would you go about determining which file to add it to. You surely don't want to add it to every file that is transformed?

I think the easiest way would be a REGEX find and replace to replace all references to import.meta.env with the actual string env value. This is what Webpack and others do today.

FIND: /import\.meta\.env\.(.*)/gm (.* isn't right, but you get the gist :)
REPLACE: the value of process.env.$1 when dev/build is run.

The plugin would implement something like:
{
  transform({ contents, urlPath, isDev }) {
      if (!urlPath.endsWith(".js")) {
        return null;
      }
      // DO FIND AND REPLACE, AND RETURN
}

This is a really interesting approach, although there are two issues that we'd need to solve for:

I don't think we have any examples of a plugin also being a frontend web dependency, and it's kind of messing with my brain. I'm not opposed to it, but it feels like a more advanced discussion of how can a plugin provide its own dependency into the app.
When we officially support this, we can't inject all process.env out into a module like that due to the high likelihood of leaking private keys, data, etc. Whatever we implement would need to be whitelisted to only include the keys actually used in your app (which is another reason that the find-replace system fits this model well).

Next.js just has an env key on their config file. https://nextjs.org/docs/api-reference/next.config.js/environment-variables

Next also uses the NEXT_PUBLIC_  prefix, which is making me rethink whether we should too. I'd feel terrible if someone used some private key in their app without realizing that it was going out to the world.
Maybe we just go full "dotenv" support and build that into Snowpack instead of pulling from process.env directly. That feels a bit safer, since anything in your system ENV probably isn't meant for a public website. Also https://github.com/motdotla/dotenv is actually really easy to integrate, in my past experience.

Yeah I'm not sure 1. is a problem in itself but I can see how it could cause confusion.

is definitely an issue, however the plugin options could easily be used to specify the variables, especially as the snowpack config can be a js file and has access to process.env. So you could have something like:

module.exports = {
  scripts: {
    'mount:src': 'mount ./src --to /',
  },
  plugins: [
    ['config/index', {
      NODE_ENV: process.env.NODE_ENV
    }]
  ],
}

I'm also a fan of dotenv and would like to see that support OOB as well. However I wonder if this would cause problems for some code bases if they are already using a .env file out of the same code base to run a node server and it has a bunch of not for public secrets in it.

Ah you're right, that must be why they still use NEXT_PUBLIC_ and REACT_APP_ even in the .env files.
If we do the same, then it would be fine to use one .env for both server and client since we could filter out anything that doesn't start with SNOWPACK_PUBLIC/SP_PUBLIC_/PUBLIC before passing it to the build-time transformer.

I'm interested in this topic.

Okay, took a stab at this: https://github.com/pikapkg/snowpack/pull/394
There are some open questions in the TODO section, would love any feedback.

Merged via #394

Eh, on second thought it looks like everyone (Next, CRA, etc) includes thier own name in the env variable, so I guess it makes sense for us to. We now use SNOWPACK_PUBLIC_ as the prefix.


TROJAN HORSE

This program immediately tried to install 6 trojans on my computer. Do not download.

It doesn't.
The only internet connection it opens is to dropbox to look for updates.

@ElTorodeAmor You may want to consider that your computer may simply have trojans on it.

Sure. I got six simultaneous Trojan alerts the instant I pressed install on
this. They were probably just waiting you're right.
On Thursday, January 5, 2017, Hussein Farran<EMAIL_ADDRESS>wrote:

@ElTorodeAmor https://github.com/ElTorodeAmor You may want to consider
that your computer may simply have trojans on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Berserker66/omnitool/issues/26#issuecomment-270819255,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATl90OHnvdpHl9FQNR4jGQvZinWneYksks5rPa0GgaJpZM4LbWAN
.

@ElTorodeAmor maybe you got it from a bad page that really added a virus to it.
Also, why 6? Shouldn’t it be one alert?
Can you paste the names of the alleged trojans here?

Sure thing. Hopefully this helps.

Sure thing. Hope this helps. I'd like to be able to use this program.

The .PYD files are nothing more than .dll files with a bit more dynamic to them.
They could easily be infected by malware that is already running, just using the pyd as container.
Your Softwareupdater.exe would appear to have done that to them.

I attempted to reinstall it, I received the exact same quarantine alerts. And the program has yet to successfully launch. Could I have downloaded a corrupted file from github?

Well, pretty sure github has it's own virus scanner anyway, as when I upload files it take a while to "validate and check" files. So, either you still have malware running, you didn't get it off github or something quite odd is going on.
Does it detect any .PYD as a virus? Maybe some heuristic is going nuts.

Oh, if someone enters the name of the alleged trojan and pyd into google, one finds that several programs have this issue in their bug tracker, where Norton false positives several python programs.
Case closed, it's norton beeing norton again. sigh


containsDocument with not flag still not working (v0.4.4)

Same issue as #145 on the same test after upgrading to v0.4.4.
The test, the underlying chart, and the template result listed in that issue are all identical.  I have also tried and failed to use any: true to no effect.
Test:
  - it: has no ScaledObject when autoscaling is disabled (default)
    set:
      commitSha: 12345
      autoscaling:
        enabled: false
    asserts:
      - containsDocument:
          kind: ScaledObject
          apiVersion: keda.sh/v1alpha1
        # invert the assertion
        not: true

Chart template:
{{- if .Values.autoscaling.enabled }}
{{ include "lib.autoscaling" .}}
{{- end -}}

(which obviously should not render any objects when autoscaling.enabled is false)
helm template output does not contain any autoscaling.yaml, as evidenced by this (correct) failure:
When running without not: true this is the failure (which is expected):
 FAIL  test autoscaling configuration	tests/autoscaling_test.yaml
	- has no ScaledObject when autoscaling is disabled (default)

		- asserts[0] `containsDocument` fail
			Template:	terminus-api-service/templates/autoscaling.yaml
			DocumentIndex:	0
			Expected to contain document:
				Kind = ScaledObject, apiVersion = keda.sh/v1alpha1, Name = , Namespace =

When running with not: true this is the failure (which is unexpected):
 FAIL  test autoscaling configuration	tests/autoscaling_test.yaml
	- has no ScaledObject when autoscaling is disabled (default)

		- asserts[0] NOT `containsDocument` fail
			Template:	terminus-api-service/templates/autoscaling.yaml

I just discovered this project and this is literally the first test I wanted to write. Is there a workaround for this available?

Hello @elangelo,
Based in the example of @jcogilvie, you can select the autoscaling.yaml as template and use the hasDocuments assertion with a count of 0, as the output will generate a empty document.
See https://github.com/helm-unittest/helm-unittest/blob/e251ba198448629678ff2168e1a469249d998155/test/data/v3/basic/tests/ingress_test.yaml#L93 as an example.
Greetings @quintush


feat: port the positivity_max extension

Ports the positivity_max positivity extension from mathlib3: https://github.com/leanprover-community/mathlib/blob/2f7b36ab1dffd22fcc18e8ad84340e7314abc819/src/tactic/positivity.lean#L389-L415

After this change, positivity still fails on the following testcase (about which @hrmacbeth expressed some concern): https://github.com/leanprover-community/mathlib4/blob/8ee6f39cb4ad54936a3ab03a53278bfec908df5c/test/positivity.lean#L194-L199
I believe the the problem does not lie in the new code in this PR, because the test case still fails even if the goal is just 0 < a, rather than 0 < max (a / b) c.

Thanks for looking in to this!
Mathlib3 discussion of that test case:
https://github.com/leanprover-community/mathlib/pull/15618#discussion_r928185366

bors r+