[Bug]: [SORA Card] iOS - There is no pending status for the Sora card banner

Preconditions
Complete sign up Sora card flow

Steps to reproduce

Approve documents in Admin panel
Check SORA Card banner status -> Log out
Login another number for Sora card
Reject documents in Admin panel
Check SORA Card banner status
Repeat reject flow 4 times

Actual behavior
There is no pending status for the Sora card banner.
Either zero is shown or the text get SORA card when you re-login to the app.

Expected behavior
Shimmers and pending status should be displayed while the SORA card status is changing.
https://www.figma.com/file/Rqm3Y2XAq3pg0zfProoaqe/🎨-SORA-Wallet-(In-Design)?type=design&node-id=4168-3842&mode=design&t=5NtR4eVjKPF4IzHI-0

Environment
{"label"=>"Development"}
OS version
16.2
Additional context
Sora Dev 1.0 (236) for iOS version

Verified on 1.0. (259) develop version.
We need add the case when no balance to display.

Verified on 3.8.3 (21) version.


[Peer Review] ViUInt8 support in Digital Pattern

What does this Pull Request accomplish?
Some APIs were using ViUInt8 type parameter which was not handled before by the tool, so I have added the support for it and also unit test for the same.
Note : Unit test for ViUInt8 [] requires some changes in mako script to handle typecasting, so I will raise a separate PR for it.
Why should this Pull Request be merged?
As per IviVisaType.h , ViUInt8 is unsigned char data type, so I am using uint32 for it which will cover a value range of 0-255.
What testing has been done?
Manual.

I am closing this because I will be creating 2 separate PRs, one for handling ViUInt8 support and other for adding metadata for functions using it.


Request Universal (arm64) version

The current SVG2Keynote-gui is Intel (Rosetta) only. Could you please remake it as Universal?

In particular, it looks like this might work if lib snappy and libkeynote had arm64 builds.


Product brand

This adds a brand element to the product feed XML, which satisfies the minimum requirements listed at
https://www.facebook.com/business/help/120325381656392

Needs a spec.

I added a spec on the helper.


Cannor reproduce results in paper

Hi,
Great work!
However, when I tried to reproduce the results reported in the paper, I got the following:
Evaluation loss and perplexity at step 11001 （60m）:
Loss: 6.293065547943115
Perplexity:<PHONE_NUMBER>237502
which are quite different from those reported in the paper.

Here are the details of my script
torchrun --standalone --nproc_per_node 1 torchrun_main.py
--model_config  configs/llama_60m.json
--lr 0.003
--peft_model sltrain
--optimizer adamw
--rank 128
--sp_ratio 0.03
--batch_size 256
--total_batch_size 512
--num_training_steps 11000
--warmup_steps 1100
--weight_decay 0
--dtype bfloat16
--eval_every 1000
--save_dir path/to/save
--lora_alpha 32
Are there any specific hyperparameters I should pay special attention to? （like lr？）
Thank you for your help!
Guinan

Hi, thank you for your interest in our work.
Your script and parameter settings are the ones we used to obtain the PPL in the paper. However, the PPL you reported seems strange. Could you provide more details about your training process, such as by sharing your WandB run?
For reference, here is our WandB run that reproduces the results in the paper: https://wandb.ai/andyjm3/test-sltrain?nw=nwuserandyjm3.

Thank you for your prompt response. Here is my Weights & Biases (wandb) run: https://wandb.ai/guinansu33/SLTrain/runs/q6ohziwv/overview. I noticed that the loss increases in the middle of the training process, which is quite wierld

Thank you for providing the training details. This occurs probably due to the unstable training with low rank factors. You may consider setting gradient clipping (for example --grad_clipping 1) or try with a different random seed.


Remove unneeded input for Jenkins instance size

What this PR does / why we need it:
We can remove this variable both from inputs.tf.template and modules.tf.template because we already template it in from instance_pool_variables.template. In iinstance_pool_variables.template we use GO templating to set the correct instance size. This change fixes that we always brought up Jenkins as an t2.large instead of the size we intended.
Before this change we always installed Jenkins as t2.large
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #311
Special notes for your reviewer:
Release note:

Fix to set correct instance size for Jenkins.

/assign @dippynark

/lgtm

/approve


Kafka source connector doesn't reconnect after kafka restart

Describe the bug
Kafka source connector doesn't reconnect with Kafka after Kafka node failed and boots up again.
To Reproduce
Steps to reproduce the behaviour:

Run Kafka
Run pulsar(2.6.1 pulsar-all image)
Create and run source connector in pulsar to connect with Kafka
Now it can be seen that source connector fetches the message from Kafka and put it back in pulsar topic
Bring down Kafka
Run Kafka
Source connector fails to connect Kafka with the below error and doesn't fetch the Kafka messages anymore

14:06:16.273 [kafka-coordinator-heartbeat-thread | 2.0] WARN  org.apache.kafka.clients.consumer.internals.AbstractCoordinator - [Consumer clientId=consumer-1, groupId=2.0] This member will leave the group because consumer poll timeout has expired. This means the time between subsequent calls to poll() was longer than the configured max.poll.interval.ms, which typically implies that the poll loop is spending too much time processing messages. You can address this either by increasing max.poll.interval.ms or by reducing the maximum size of batches returned in poll() with max.poll.records.
14:06:16.273 [kafka-coordinator-heartbeat-thread | 2.0] INFO  org.apache.kafka.clients.consumer.internals.AbstractCoordinator - [Consumer clientId=consumer-1, groupId=2.0] Member consumer-1-25a80c1d-78bc-4faa-b3d7-16bc259eaa07 sending LeaveGroup request to coordinator kafkaserver:9092 (id:<PHONE_NUMBER> rack: null)

source connector status is also showing as running without any error or restarts

root@c44d5fd34c32:/pulsar/bin# ./pulsar-admin sources status --name testsource
{
  "numInstances" : 1,
  "numRunning" : 1,
  "instances" : [ {
    "instanceId" : 0,
    "status" : {
      "running" : true,
      "error" : "",
      "numRestarts" : 0,
      "numReceivedFromSource" : 2,
      "numSystemExceptions" : 0,
      "latestSystemExceptions" : [ ],
      "numSourceExceptions" : 0,
      "latestSourceExceptions" : [ ],
      "numWritten" : 2,
      "lastReceivedTime" :<PHONE_NUMBER>740,
      "workerId" : "c-standalone-fw-localhost-8080"
    }
  } ]
}

Expected behaviour
Source connector should reconnect with Kafka.
If the failure is not recoverable, source connector status should throw the error/running=false

Is there any work being done to resolve this bug?

One thing to try is to enable "autoCommitEnabled" configuration for the Kafka source connector. It should be enabled by default unless it's explicitly disabled.
The reason why this might help is that Kafka Consumer API's commitSync method throws an unchecked exception according to this SO answer: https://stackoverflow.com/a/65193460 .
That case might not be handled in the Pulsar IO Kafka source connector around https://github.com/apache/pulsar-connectors/blob/master/pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java#L139 .
commitSync won't be called when auto commit is enabled in the Pulsar IO Kafka source connector.

Closed as stale. Please open a new issue if it's still relevant to the maintained versions.


Editor crashes on textures import

Godot version
v4.2.stable.official [46dc27791]
System information
Fedora 39 KDE Plasma 5.27.9
Issue description
Since upgrading my project from Godot 3 to 4, there is a recurrent bug with textures import that is present on some machines/OSes and not present on others (there is no system in its behavior as I can see). On my machine the editor prints this error for every imported texture and then crashes (sometimes it doesn't crash):
ERROR: Expected Image data size of 182x242x1 (DXT1 RGB8 with 7 mipmaps) = 30120 bytes, got 30216 bytes instead.
   at: initialize_data (core/io/image.cpp:2219)

On my coworkers' machines (both Linux and Windows) it may work fine for some time, but then suddenly it starts to show these errors too.
Steps to reproduce

Launch the attached project

Minimal reproduction project
Bug.zip

Errors still encountered on current master (f8a2a9193662b2e8c1d04d65e647399dee94f31e), it's emitted here:
https://github.com/godotengine/godot/blob/f8a2a9193662b2e8c1d04d65e647399dee94f31e/core/io/image.cpp#L2220
The size discrepancy originates between texture->alloc_width, texture->alloc_height vs. texture->width, texture->height.
Values are 184x244 for allocation, 182x242 for actual size.
https://github.com/godotengine/godot/blob/f8a2a9193662b2e8c1d04d65e647399dee94f31e/drivers/gles3/storage/texture_storage.cpp#L960
https://github.com/godotengine/godot/blob/f8a2a9193662b2e8c1d04d65e647399dee94f31e/drivers/gles3/storage/texture_storage.cpp#L988

I could try to debug this. Is there any instruction on how to build and debug the editor?

See here

In debugger I can see that p_image size here is already incorrect
https://github.com/godotengine/godot/blob/2d0ee20ff30461b6b10f6fdfba87511a0ebc6642/drivers/gles3/storage/texture_storage.cpp#L746
Unfortunately this function is called kinda indirectly in a CommandQueueMT instance and I can't find where is it (and its arguments including the image) passed to it.

If I understand correctly, the size is different because of the ETC compression used for the image which uses a block size of 4. Taking the width for example, 182 is not divisible by 4, but 184 is. Image::_get_dst_image_size does the corresponding calculation.
I am still not sure how exactly Godot should handle this.

If I understand correctly, the size is different because of the ETC compression used for the image which uses a block size of 4. Taking the width for example, 182 is not divisible by 4, but 184 is. Image::_get_dst_image_size does the corresponding calculation.
I am still not sure how exactly Godot should handle this.

The usual way to resolve this is to resize the image to a slightly greater size (i.e. from 182 to 184 pixels, preserving aspect ratio).

The usual way to resolve this is to resize the image to a slightly greater size (i.e. from 182 to 184 pixels, preserving aspect ratio). We can use Lanczos scaling during this operation to ensure crispness remains as close as possible to the original.

Should this happen during the initial import of image? And should the width/height be updated accordingly?

Should this happen during the initial import of image? And should the width/height be updated accordingly?

This should be done on import type, or at runtime if using Image.compress(). The width/height will have to be updated accordingly, although we could set a size override in 2D so that the physical sprite size doesn't change (we have a method/property for this currently not exposed in the inspector).

Can confirm that resizing source images to sizes divisible by 4 resolves the issue.  Would be great if Godot could do this for us though.


update imagestreams to registry.redhat.io

@spolti these changes are needed to switch to the new redhat registry.  Since openshift/library is pulling from a specific tag you have created in this repo, you'll need to get these changes associated w/ the tag you are using (7.0.1.GA) or update official.yaml in openshift/library to pull from a different branch/tag that has these changes.


[Bug] Failed to get inventory

[2022-09-17 14:07:02] [info] Watched stream for 11 minutes
[2022-09-17 14:07:04] [info] Found 9 good streams
[2022-09-17 14:07:05] [info] Watching stream: https://www.twitch.tv/snackey
[2022-09-17 14:07:17] [info] Waiting for page to load...
[2022-09-17 14:07:20] [info] Accepted mature content
[2022-09-17 14:07:20] [info] Set stream to lowest quality
[2022-09-17 14:07:20] [info] Set stream visibility to hidden
[2022-09-17 14:09:01] [info] Claimed community points!
[2022-09-17 14:12:32] [error] Failed to get inventory

Doesn't seem to disrupt anything, but maybe take a look.

[2022-09-17 14:12:32] [error] Failed to get inventory
[2022-09-17 15:58:13] [error] Failed to check stream count
[2022-09-17 17:24:33] [error] Failed to get drop campaign details
[2022-09-17 17:40:08] [error] Failed to check stream count

A few more appear on the latest dev branch.

I noticed this happening a bit more recently but it always seems to be due to some connection errors so not sure if Twitch is having issues or if it's something else. Like you said though, it doesn't disrupt the bot since it will just retry it so it's not really an issue.


[ISSUE #4012] fix logging module sql error

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4018 (9dbf679) into master (121f946) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4018      +/-   ##
============================================
- Coverage     70.02%   69.79%   -0.23%
+ Complexity     6705     6673      -32
============================================
  Files           927      927
  Lines         25295    25287       -8
  Branches       2283     2280       -3
============================================
- Hits          17713    17650      -63
- Misses         6192     6248      +56
+ Partials       1390     1389       -1

Impacted Files
Coverage Δ

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
68.75% <0.00%> (-31.25%)
:arrow_down:

.../client/server/consul/ShenyuConsulConfigWatch.java
58.33% <0.00%> (-27.09%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
54.54% <0.00%> (-4.55%)
:arrow_down:

...che/shenyu/admin/model/vo/DashboardUserEditVO.java
60.86% <0.00%> (-4.35%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
85.71% <0.00%> (-4.09%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.00% <0.00%> (-4.00%)
:arrow_down:

... and 30 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Implement SelfieSettings for python

Original API documentation: https://kdoc.selfie.dev/selfie-runner-junit5/com.diffplug.selfie.junit5/-selfie-settings-a-p-i/

Original junit5 implementation: https://github.com/diffplug/selfie/blob/main/jvm/selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SelfieSettingsAPI.kt

Original Kotest implementation: https://github.com/diffplug/selfie/blob/main/jvm/selfie-runner-kotest/src/commonMain/kotlin/com/diffplug/selfie/kotest/SelfieSettingsAPI.kt

SelfieSettings example: https://github.com/diffplug/selfie/blob/main/jvm/example-junit5/src/test/java/selfie/SelfieSettings.java

We now have a SelfieSettings, but there are two parts missing:
https://github.com/diffplug/selfie/blob/f1325e86308984401ecc86323f4d2d2e2b4f1d81/python/pytest-selfie/pytest_selfie/SelfieSettingsAPI.py#L15-L23
Users should be able to set them like so:
https://github.com/diffplug/selfie/blob/f1325e86308984401ecc86323f4d2d2e2b4f1d81/python/pytest-selfie/pytest_selfie/SelfieSettingsAPI.py#L10
Right now our docs say something like this:

If you want the disk snapshots to live in a different folder, set snapshotFolderName using

whatever we have to say there should be accurate


myCustomRedrawAccordingToNewPropsHandler not working

Expected Behavior
myCustomRedrawAccordingToNewPropsHandler to work and console.log(props.passedProp), trying test passing props is working by just logging it.
Actual Behavior
myCustomRedrawAccordingToNewPropsHandler not working at all, I added console.log(entered to function!), and this is not even logging in. The function isn't even running.
FYI- Sketch and set up is running fine!!!
Steps to Reproduce the Problem

import { ReactP5Wrapper } from "react-p5-wrapper";

inside the sketch function, I have const sketch = (p5) => {
p5.myCustomRedrawAccordingToNewPropsHandler = function (props) {
if (props.rotation) {
console.log("rotations", props.rotation);
}
};
}

Specifications
Package Version: 3.3.0
I see many examples importing it as import P5Wrapper from 'react-p5-wrapper'; and then <P5Wrapper sketch={sketch} rotation={rotation}/>
but when I do this, webpack fails to import react-p5-wrapper and it fails to build the app.. Pls help.

Since version 3 we no longer support that method and instead use updateWithProps.
Here is the example taken from the documentation:
import { ReactP5Wrapper } from "react-p5-wrapper";

function sketch(p5) {
  let rotation = 0;

  p5.setup = () => p5.createCanvas(600, 400, p5.WEBGL);

  p5.updateWithProps = props => {
    if (props.rotation) {
      rotation = (props.rotation * Math.PI) / 180;
    }
  };

  p5.draw = () => {
    p5.background(100);
    p5.normalMaterial();
    p5.noStroke();
    p5.push();
    p5.rotateY(rotation);
    p5.box(100);
    p5.pop();
  };
}

For a deeper dive into how prop reactivity works please read the documentation under the "Props" section in the Readme.me file.
Everything is covered within the readme including typescript, reactivity, abstraction of methods, etc.
Hope this helped! 😊

Thank you so much @jamesrweb !
Can I ask you one more question, please? If I pass a function as a prop to , how can I call this function inside the sketch.js?
p5.updateWithProps = (props) => {
    props.handleCurrentPose(poseLabel);
  };

For my code, it's ml5 inside P5 sketch that's creating a label of a pose, so I am trying to call the myFunc(label) with label value I got from sketch. Now I understand we can pass prop, but now I'm trying to send value to the parent component by calling a function that's passed as a prop. Please advise~ Thank you!

You can just pass the function via a prop of your choice like myHandlerProp={myHandlerFunction} then use the props passed to the update function to call it like props.myHandlerProp(arguments).
Does that make sense?


 Since this is my first Godot tutorial I was trying to use, hard to give you more specific information.

Seems to work for me (Godot 4.2 head self-compiled). I get an info message that the project has been built with Godot 3. I chose to convert everything to Godot 4 and so far it looks like it works. I am currently following the 3D-tutorial and will check in again if I find anything that does not work.
It would be nice to release a version of this project that is compatible with Godot 4 to make it less confusing for beginners who might not know what to do with the conversion warning.


reboots during day

I have 3 APS DS3 EU inverters, ESP32 + CC2531:
firmware 0.4
wifi: -70db
APS0: 59.6%
APS1: 49.4%
APS2: 36.9%
Everything works as it should, but I have a reboot every day (for example today at 11:56).
The main problem with that is -as far as I can see- that the cumulative total revenue also resets.

@JanBoos  Well the reboots is a problem but the total energy should not affected by that. That value comes form the inverter.
You can upgrade to v0_5, should be stable.

Only 1 reboot yesterday. Not clear why.
I have the website open on 3 devices (PC, laptop and mobile).
I am using MQTT format 2.
For the rest it works stable :)
I will upgrade to 0.5 today

I still see sometimes "strange" totals. With the "old" 0.5 I went on a holyday for a week. After this week the total was 80 kWh (max per day is 10-15 kWh). ZB reset counter was 1. No further ecu reboots.
After a reboot everything was back to normal.
Put the "new" 0.5 on it yesterday. After reboot the total was only 0.12 kWh where it should be 3.8 kWh.
Does the total come from the inverter itself of by your software anyhow?

The total comes from the inverter or from the software, the highest value of these two. So when the ESP reboots we have the value of the inverter and when the inverter reboots (happens sometimes in twilight) the software remembered the total.
If polling failes (inverter stopped working at sunset), every value is set to n/a. You can prevent that by putting a bigger value in poll offset. When the polling stops before the inverter goes down, there is no error situation, However, the total should be oke in all situations. In the ESP8266 this works oke.
Normally all values are reset to null at midnight so at that point there must be something wrong.
I am currently testing with th esp8266 implementation but i expect that within a week i can work on the esp32 again and correct the imperfections.

I mean totals per inverter.
The total of all inverters is (also wrong, but) indeed the sum of the inverters.

Thanks for 0.6. That indeed works better that you no longer have to refresh the browser.
Incidentally, after taking the PC out of sleep mode, sometimes a strange total (see photo). Refreshing the browser (google chrome) a few times and the values are correct again.
Furthermore, since 0.5a, no strange resets have been seen from both the ecu and the zigbee.
Also nice (for the administration) that the values are saved after the polling has stopped.

@JanBoos  I trust that this "impossible" phenomenon has gone in the newest version.


Investigate iOS template reloading data when offline sync enabled

Follow up from https://github.com/MicrosoftDocs/azure-docs/issues/13537

Hey!
We haven’t heard from you in a while, so we will close this ticket for now. We will reopen the ticket if you reply to it.
Thanks for using App Center!


Properly check for string type with support for unicode

The assertion fails if a unicode string is provided.

This breaks Python 3. Please, put some more thought into it. Perhaps, write some tests. Test with at least Python 2.7 and 3.4.


Feature GET, DELETE /Api/GamesToRedeemInBackground/{Bot}

This PR implements backend support for the feature requested in this comment

please review @JustArchi

can my PC please not say "failed to listen on prefix" when i want to test IPC? 🙄

good thing IPv6 works fine because somehow i couldn't test on <IP_ADDRESS> or any other IPv4-address 👍  good job, Archi ❤

better?

Much better 👍

I'm not entirely sure if that parallel execution in GET will work the way we want to. Add:
ArchiLogger.LogGenericDebug("Executed");
await Task.Delay(10000).ConfigureAwait(false);

In GetUsedAndUnusedKeys(), then execute GET with ASF as an argument (and multiple bots defined) and check if all of them print above "Executed" at once.

After you do above test and verify that parallel execution once like it should you can do Cleanup file in R# on each file you modified so it has proper order of functions and fields, on top of all other changes 🙂

Executed all at once. No problem there 👍

you can do Cleanup file in R#

As I do not have R# installed this will be left to you

Alright, that should be everything then. Thanks for your contribution! 🏆


Separate ReportScreenContext to prevent cyclic re-renders

Details
We are trying to optimize the ReportScreen. This is the first issue I found where a shared context to manipulate certain lists would cause parent components to re-render causing a cascade of cyclic renders.
By separating the context we limit the re-renders to the part of the tree that consume the specific contexts and win back some render cycles.
Fixed Issues

$ NONE YET
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console
[x] Debugged the render stack via React DevTools
[x] When long tapped a reaction emoji, the list of emojis should pop up
[x] Scrolling events on ReportActionList should still work

Offline tests

None needed in offline mode
QA Steps

[ ] Verify that no errors appear in the JS console
[ ] When long tapped a reaction emoji, the list of emojis should pop up
[ ] When editing an action in the Report screen, after saving the Action/Comment the list should scroll to the correct position

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android
Here is a video showing the Report screen emoji list is still working.
https://github.com/Expensify/App/assets/1634213/34290310-f414-41bf-992c-8c2650851dc9

I have read the CLA Document and I hereby sign the CLA

@ospfranco can you please link issue correctly in issue description? And please fix lint
Example:
### Fixed Issues

$ https://github.com/Expensify/App/issues/12345

@tgolen feel free to review this one if you interested

ReportScreen is now refactored to functional component. Please fix conflict and lint

Done! Thanks!

For commit 3be5e6909a86a33a9c7c749c2378b14ad1ab243c (separating the contexts to prevent cyclic re-renders), here is the react devtools trace, you can see before the change there are at least 7 renders, this is also a parent component, so it triggers a cascade of re-renders on the children. Afer the change this has gone down to 3.

For commit 6125c381cde29277f150f1a4156a6b96af05f150 (Get rid of full list re-render when marking messages as unread) Here is the trace before and after

You can see a reduction of 2 renders, but again this being a parent component it triggers a re-render of the entire list elements

Thanks for those images and showing the change to the re-renders!


Fix code snippet in raw-database-access

Describe this PR
Snippet under the $queryRaw section is referencing the wrong variable (desc), which should be ordering instead.
Changes
Changed desc to ordering in the code snippet.
What issue does this fix?
N/A
Any other relevant information
N/A

Thanks for spotting that @manassra!


appengine_flexible/endpoints: add Google ID example

Add an example for Google ID authentication.

I'm not sure why googlebot isn't seeing my google.com email address.

@rthellend you've got to set it with git config --global user.email<EMAIL_ADDRESS>then git commit --amend --reset-author
and/or set your GitHub username at http://github/

A few questions before I review the code...
Can you make the update here, instead?
https://github.com/GoogleCloudPlatform/golang-samples/tree/master/endpoints/getting-started
(I think appengine_flexible/endpoints should be removed, let me confirm)
Did you make similar changes to the openapi.yaml for other languages? They should be consistent. e.g., the name of the audience.

I created a new pull request: https://github.com/GoogleCloudPlatform/golang-samples/pull/189 . I'll close this one after this comment.
Moved to endpoints/getting-started.
I did not make any changes for other languages. I only made it here to be consistent between JWT and Google ID. In the case of Google ID, the token that's generated by the google api always has https://. I'm happy to change it back for JWT if you prefer.

@rthellend Yeah, best to keep it consistent.
Could you change the others, too? At the least, changing the x- keys would be good. If not, I can get the owners of those samples to do the updates.

I'd rather let the owners do the updates in the other repos, if you don't mind too much.
I can change the x-google keys back if you prefer. The old names are deprecated, but they still work.
Thanks.


fix(zsh): use the '=~' operator instead of grep

description
Close #3904
Using Apple's default grep version and assigning the GREP_OPTIONS environment variable with --color=always, unintended ANSI escape sequences causing mischief in the correct retrieval of the history entry.
export GREP_OPTIONS="--color=always"
export PATH="/usr/bin:$PATH"
grep --version
# grep (BSD grep) 2.5.1-FreeBSD
source <(fzf --zsh)

Solution

Use grep --color=never, or
use the =~ operator coupled with MATCH to catch the matched string in case of a success.

man 1 zshmisc | less --pattern BASH_REMATCH
# string =~ regexp
#   true if string matches the regular expression regexp.  If the option RE_MATCH_PCRE is set regexp is tested as a PCRE regular expression
#   using the zsh/pcre module, else it is tested as a POSIX extended regular expression using the zsh/regex module.  Upon successful match,
#   some variables will be updated; no variables are changed if the matching fails.

#   If the option BASH_REMATCH is not set the scalar parameter MATCH is set to the substring that  matched  the  pattern  and  the  integer
#   parameters MBEGIN and MEND to the index of the start and end, respectively, of the match in string, such that if string is contained in
#   variable var the expression `${var[$MBEGIN,$MEND]}' is identical to `$MATCH'.  The setting  of  the  option  KSH_ARRAYS  is  respected.
#   Likewise,  the  array  match  is  set to the substrings that matched parenthesised subexpressions and the arrays mbegin and mend to the
#   indices of the start and end positions, respectively, of the substrings within string.  The arrays are not set if there were no  paren-
#   thesised subexpressions.  For example, if the string `a short string' is matched against the regular expression `s(...)t', then (assum-
#   ing the option KSH_ARRAYS is not set) MATCH, MBEGIN and MEND are `short', 3 and 7, respectively, while match, mbegin and mend are  sin-
#   gle entry arrays containing the strings `hor', `4' and `6', respectively.

#   If  the  option  BASH_REMATCH is set the array BASH_REMATCH is set to the substring that matched the pattern followed by the substrings
#   that matched parenthesised subexpressions within the pattern.

Using Apple's default grep version and assigning the GREP_OPTIONS environment variable with --color=always, unintended ANSI escape sequences causing mischief in the correct retrieval of the history entry.

I expect this to be the reason for #3904, but it's probably good to wait until there is confirmation from the issue author.

Thanks. We can't even trust grep no more, 😭


Crash when incompatible units are entered for arrange loop

Caqtus version: 6.3.3
Python version: 3.12
OS: Windows 11

Describe the bug
When creating an arange loop for a sequence, if the units are incompatible between the start, stop and end, condetrol will crash.
This also happens for a linspace loop with incompatible start and end.
Expected behavior
Condetrol should not crash, it should either display an error message when editing the steps or when running the sequence.

Actually does not happen for linspace loop


Change "uproxy-lib/src/webrtc" into "transport" and make it a freedom module

Do a renaming refactor of "uproxy-lib/src/webrtc" into something that reflect more accurately what it is, maybe "transport".
Provide a nice IDL-compiler based implementation for the freedom-module boundary (depends on https://github.com/uProxy/uproxy/issues/338)
Replace the usage of "uproxy-lib/src/webrtc" in uproxy and sample apps with the module-separated version.

Closing this since we don't have an IDL compiler-baed implementation and I think webrtc is already a fine name for the folder, until we redesign the interface inside. Also I'm unclear on what advantages there would be in moving to a module for webrtc.


Question: is there a way for blocking external links?

Im wondering if I can block users to attach external link that can lead other users out of the page. Is there a way to accomplish it with react-markdown?

Yes. transformLinkUri allows you to rewrite links. You could also define a custom renderer for the link type, which would be the most flexible solution. This would allow you to render an error message, rewrite the link, just render the children of the link or any other thing you might want to do.

Awesome. Thanks for the quick answer.


Map key serialization doesn't work with custom converter

If you want to write entity
@Data
@Document(collection = "collection")
public class Document {

    @Id
    String id;
    Map<SomeId, SomeEntity> entityMap;

}

to aerospike with custom converters for the SomeId, it will write SomeId keys with help of Object#toString() method, but the desired behavior is conversation to String using custom converter, in my opinion.
The problem is localized here and the possible solution is just to replace this line
String simpleKey = key.toString();

with
String simpleKey;
if (conversationService.canConvert(type.getComponentType(), String.class)) {
  simpleKey = conversionService.convert(key, String.class);
} else {
  simpleKey = key.toString();
}

What do you think about this?

Hi @raman-babich,
If you have a custom converter on the Document class then you can simply convert the SomeId field (Bin) as you like. In this case the convertMap() method (that contains the code you suggested) won't be executed, the entire conversion logic will happen in convertToAerospikeWriteData().
Here is an example of using a custom converter to add "prefix!" on each key in a map bin when persisting data into Aerospike and remove the "prefix!" when reading the data back from Aerospike:
Object:
@Document
@Data
public static class MapWithKeyToConvert {
	@Id
	final long id;
	final Map<Object, String> mapWithDifferentKeyType;
}

Custom Converters:
@WritingConverter
public static class MapWithKeyToConvertToAerospikeWriteDataConverter implements Converter<MapWithKeyToConvert, AerospikeWriteData> {

	@Override
	public AerospikeWriteData convert(MapWithKeyToConvert map) {
		Map<String, String> newConvertedMap = map.mapWithDifferentKeyType.entrySet().stream()
				.collect(Collectors.toMap(e -> "prefix!" + e.getKey().toString(), Map.Entry::getValue));

		Collection<Bin> bins = new ArrayList<>();
		bins.add(new Bin("mapWithDifferentKeyType", newConvertedMap));

		return new AerospikeWriteData(new Key("custom-namespace", "custom-set", Long.toString(map.id)), bins, 0, null);
	}
}

@ReadingConverter
public static class AerospikeReadDataToMapWithKeyToConvertConverter implements Converter<AerospikeReadData, MapWithKeyToConvert> {

	@Override
	@SuppressWarnings("unchecked")
	public MapWithKeyToConvert convert(AerospikeReadData source) {
		long id = Long.parseLong((String) source.getKey().userKey.getObject());
		Map<String, String> mapWithKeyToConvert = (Map<String, String>) source.getValue("mapWithDifferentKeyType");
		Map<Object, String> newConvertedReadMap = mapWithKeyToConvert.entrySet().stream()
				.collect(Collectors.toMap(e -> e.getKey().substring(e.getKey().indexOf("!") + 1), Map.Entry::getValue));
		return new MapWithKeyToConvert(id, newConvertedReadMap);
	}
}

Test:
@Test
public void shouldWriteAndReadUsingCustomConverterMapKeys() {
	MappingAerospikeConverter converter =
			getMappingAerospikeConverter(new SampleClasses.MapWithKeyToConvertToAerospikeWriteDataConverter(), new SampleClasses.AerospikeReadDataToMapWithKeyToConvertConverter());

	AerospikeWriteData forWrite = AerospikeWriteData.forWrite(NAMESPACE);
	Map<Object, String> map = new HashMap<>();
	map.put("firstKey", "firstValue");
	map.put("secondKey", "secondValue");
	map.put("thirdKey", "thirdValue");

	Map<String, String> mapExpectedAfterConversion = map.entrySet().stream()
			.collect(Collectors.toMap(e -> "prefix!" + e.getKey().toString(), Map.Entry::getValue));

	SampleClasses.MapWithKeyToConvert mapWithKeyToConvert = new SampleClasses.MapWithKeyToConvert(999L, map);
	converter.write(mapWithKeyToConvert, forWrite);

	assertThat(forWrite.getKey()).consistsOf("custom-namespace", "custom-set", 999L);
	assertThat(forWrite.getBins()).containsOnly(new Bin("mapWithDifferentKeyType", mapExpectedAfterConversion));

	Map<String, Object> bins = of("mapWithDifferentKeyType", mapExpectedAfterConversion);
	SampleClasses.MapWithKeyToConvert read = converter.read(SampleClasses.MapWithKeyToConvert.class, AerospikeReadData.forRead(forWrite.getKey(), record(bins)));

	assertThat(read).isEqualTo(mapWithKeyToConvert);
}

If this doesn't help - please share a code example and more details about the provided SomeId type and the request results of what you are trying to accomplish.
Thanks!

Hi @roimenashe,
For example i have:
@Data
@Document(collection = "collection")
public class Document {

    @Id
    String id;
    Map<SomeId, SomeEntity> entityMap;
}

@Value
public class SomeId {

    String partA;
    String partB;
}

@Value
public class SomeEntity {

    SomeId id;
    String fieldA;
    Long fieldB;
}

I don't have custom converter on Document class and i don't want to do it because I want to let spring-data-aerospike serialize instance of Document with minimal effort from me. I want to declare that instances of SomeId class should be serialized as String so that is why i make
@WritingConverter
public class SomeIdToStringConverter implements Converter<SomeId, String> {

    @Override
    public String convert(SomeId id) {
        return id.getPartA() + "-" id.getPartB();
    }
}

and
@ReadingConverter
public class StringToSomeIdConverter implements Converter<String, SomeId> {

    @Override
    public String convert(String id) {
        String[] parts = StringUtils.split(id,"-");
        return new SomeId(parts[0], parts[1]);
    }
}

after registering converters and saving some test instances of Document class i want to observe in the aerospike records like (for simplicity i will write it in the json but please assume that this is equivalent bin structure in the aerospike, a key of the record will have _key field name):
{
  "_key": "someKey1",
  "entityMap": {
    "partA-partB1": {
      "id": "partA-partB1",
      "fieldA": "fieldA",
      "fieldB": 42
    },
    "partA-partB2": {
      "id": "partA-partB2",
      "fieldA": "fieldA",
      "fieldB": 42
    }
  }
}

but because converters will not be applied to the entityMap key the result will look like:
{
  "_key": "someKey1",
  "entityMap": {
    "SomeId(partA=partA, partB=partB1)": {
      "id": "partA-partB1",
      "fieldA": "fieldA",
      "fieldB": 42
    },
    "SomeId(partA=partA, partB=partB2)": {
      "id": "partA-partB2",
      "fieldA": "fieldA",
      "fieldB": 42
    }
  }
}

@raman-babich
Thanks for the detailed explanation, I see your point.
Opened a PR for this feature request (based on your example with few changes): https://github.com/aerospike-community/spring-data-aerospike/pull/313.
Once PR will be reviewed and hopefully merged this change will be included in the next version of Spring Data Aerospike.
Thanks you!

@raman-babich
Spring Data Aerospike 3.3.0 is out including support for custom conversions for map key.
You can see release notes at: https://github.com/aerospike-community/spring-data-aerospike/releases/tag/3.3.0.
It may take up to 24 hours for Maven Central to sync.


Compatibility with sublevel

This module is not compatible with sublevel anymore :(, it complains about missing isOpen() methods and so on. However, I'm not sure that compatibility with sublevel is still something we aim to achieve with this.
I also tried running it on top of different 'spaces', but with no luck, I'm not getting the right stuff out if it (I'm using a custom encoding for values).

@mcollina What's the status of this issue?

It will be solved by #25, as we remove level-spaces.

@mcollina #25 is superseded by https://github.com/rvagg/node-level-ttl/pull/27


[stable kiam] setting iptables: true the agent fails. On selinux enabled systems

Describe the bug
On Selinux enabled systems setting the iptables: true causing the agent to loop into CrashLoopBackOff
Version of Helm and Kubernetes:
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:50Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}```

**Which chart**:
stable kiam 2.5.1

**What happened**:
I have deployed the stable kiam version 2.5.1  with agent iptables: true.  on a RHEL system with SELinux in enabled mode.  but the agent is not starting.

[root@ip-10-0-8-141 ~]# k get pods
NAME                  READY   STATUS             RESTARTS   AGE
demo-8c4f9ffb-758cd   1/1     Running            0          19m
kiam-agent-45l2l      0/1     CrashLoopBackOff   7          11m
kiam-server-f6jlg     1/1     Running            0          28m
[root@ip-10-0-8-141 ~]# k logs -f kiam-agent-45l2l
{"level":"info","msg":"configuring iptables","time":"2019-09-20T05:43:16Z"}
{"level":"fatal","msg":"error configuring iptables:running [/sbin/iptables -t nat -C PREROUTING -p tcp -d <IP_ADDRESS> --dport 80 -j DNAT --to-destination <IP_ADDRESS>:8181 -i cni0 --wait]: exit status 4: Fatal: can't open lock file /run/xtables.lock: Permission denied\n","time":"2019-09-20T05:43:16Z"}```
What you expected to happen:
Agent POD should be running
How to reproduce it (as minimally and precisely as possible):
Install a helm chart on SElinux enabled machine. with iptables option set to true.
Anything else we need to know:
We can

@junaid18183 The kiam chart is now hosted by uSwitch.
Please open the issue in their repo and close here.
Thanks.

Thanks @ewbankkit  I have created the https://github.com/uswitch/kiam/issues/302 for same


vcpkg autcomplete bash stdout in binary mode

vcpkg autcomplete bash stdout should be in binary mode
Output  \n instead of \r\n

Steps to reproduce:
Assume vcpkg is in C:\vcpkg
Open Msys2 bash
cd /C/vcpkg
. scripts/vcpkg_completion.bash
./vcpkg install libf<Press tab>

Does this change affect what is displayed when using powershell?

No problem in powershell

Should be fixed.

No, it is not fixed! trailing ^M still present.

No, it is not fixed! Trailing ^M still present.
Please re-open this issue.

@linquiz, sorry for replying to you so late, I followed your steps to reproduce and got different results, can you see where it is different from yours?

open gitbash
. scripts/vcpkg_completion.bash
./vcpkg install libf

This is because Git Bash from Git for Windows misses some files about bash completion.

https://github.com/git-for-windows/git/issues/2562

Since this is a issue about Git, so I am closing this issue for now.


Mazumder - QC HPAI A(H5H1) Fasta files form GISAID

Please QC the following Fasta files (8 per GISAID ID)
Notes:
Circulating clade: <IP_ADDRESS>b
All known/recorded human cases since Jan 2020
CDC announcements and publications all obtained data from GISAID
No available raw data on NCBI and GISAID, despite exhaustive effort made by the data team
Next step: apply assemblyQC protocols to selected isolate IDs
| edit | Name | Isolate ID | Subtype | Passage | PB2 | PB1 | PA | HA | NP | NA | MP | NS | HE | P3
-- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
editNameIsolate IDSubtypePassagePB2PB1PAHANPNAMPNSHEP3A/Chile/25945/2023EPI_ISL_17468386H5N12,3572,3412,2361,7411,5811,4541,023886------A/Jiangsu/NJ210/2023EPI_ISL_17075759H5N1e12,3412,3412,2331,7761,5651,4581,027890------A/Jiangsu/NJ210/2023(H5N1)EPI_ISL_17075747H5N1original2,3412,3412,2331,7761,5651,4581,027890------A/CastillaLaMancha/3869/2022EPI_ISL_16813290H5N1Original sample---------1,7041,4971,410982838------A/CastillaLaMancha/3739/2022EPI_ISL_15542438H5N1Original sample2,2802,2742,1511,7041,4971,410982838------A/Colorado/18/2022EPI_ISL_12799972H5N1Original---8962,1511,704---877982838------A/England/215201407/2021EPI_ISL_8799552H5N1original2,2792,1782,1511,7031,4971,450982838---

You are logged in as Stephanie S Singleton - [logout](https://platform.epicov.org/epi3/frontend#)
[Registered Users](https://platform.epicov.org/epi3/frontend#)
[EpiFlu™](https://platform.epicov.org/epi3/frontend#)
[EpiCoV™](https://platform.epicov.org/epi3/frontend#)
[EpiRSV™](https://platform.epicov.org/epi3/frontend#)
[EpiPox™](https://platform.epicov.org/epi3/frontend#)
[My Profile](https://platform.epicov.org/epi3/frontend#)
© 2008 - 2023 | [Terms of Use](https://platform.epicov.org/epi3/frontend#) | [Privacy Notice](https://platform.epicov.org/epi3/frontend#) | [Contact](https://platform.epicov.org/epi3/frontend#)
Released files
edit
Name
Isolate ID
Subtype
Passage
PB2
PB1
PA
HA
NP
NA
MP
NS
HE
P3
editNameIsolate IDSubtypePassagePB2PB1PAHANPNAMPNSHEP3
A/Chile/25945/2023
EPI_ISL_17468386
H5N1
2,357
2,341
2,236
1,741
1,581
1,454
1,023
886

A/Jiangsu/NJ210/2023
EPI_ISL_17075759
H5N1
e1
2,341
2,341
2,233
1,776
1,565
1,458
1,027
890

A/Jiangsu/NJ210/2023(H5N1)
EPI_ISL_17075747
H5N1
original
2,341
2,341
2,233
1,776
1,565
1,458
1,027
890

A/CastillaLaMancha/3869/2022
EPI_ISL_16813290
H5N1
Original sample

1,704
1,497
1,410
982
838

A/CastillaLaMancha/3739/2022
EPI_ISL_15542438
H5N1
Original sample
2,280
2,274
2,151
1,704
1,497
1,410
982
838

A/Colorado/18/2022
EPI_ISL_12799972
H5N1
Original
896
2,151
1,704
877
982
838

A/England/215201407/2021
EPI_ISL_8799552
H5N1
original
2,279
2,178
2,151
1,703
1,497
1,450
982
838

[ ] A/Chile/25945/2023 EPI_ISL_17468386  @JingyueWu
[ ] A/Jiangsu/NJ210/2023 EPI_ISL_17075759 @JingyueWu
[ ] A/Jiangsu/NJ210/2023(H5N1) EPI_ISL_17075747 @JingyueWu
[ ] A/CastillaLaMancha/3869/2022 EPI_ISL_16813290 @JingyueWu
[ ] A/CastillaLaMancha/3739/2022 EPI_ISL15542438 @penningtonea
[ ] A/Colorado/18/2022 EPI_ISL_12799972 @penningtonea
[ ] A/England/215201407/2021 EPI_ISL_8799552 @penningtonea

Requested access to EpiFlu

Update: QUAST appears to be still under construction and gives me the same error message.

Commenting to keep track of updates. QUAST on AWS is working and seems to be a better work around than running the command line version. @JingyueWu and I will use QUAST on AWS in the mean time until the tool is functioning well on HIVE2.

Status update: will focus on finishing this up on Thursday and Friday.

@JingyueWu can we close out this ticket?

@JingyueWu backlogging this ticket because I have not had a status update since the beginning of June

@JingyueWu can we close out this ticket?

Since Raja's direction is for all to pause QC'ing new data, I think we can close this ticket. We already have influenza H1N1 and H3N2 in our datasets.

Complete


Add alert template expansion time to rule group evaluation time

We should add in alert template expansion time to the rule group evaluation time introduced in #3491 as this contributes the time taken to evaluate a given rule group.

I think we are already adding the expansion time in the group evaluation time.
Related code: link
@brian-brazil @conr

Yeah, this must have gotten fixed at some point.


PageView scroll physics to match Android (as an opt-in)

Fixes https://github.com/flutter/flutter/issues/38357
So, this is a new reland for a https://github.com/flutter/flutter/pull/95423
Previous reland https://github.com/flutter/flutter/pull/97166

Old physics
https://user-images.githubusercontent.com/39104740/146440807-50e10ab1-628c-4623-a9d3-3704bd5fd0d5.mp4
https://user-images.githubusercontent.com/39104740/205435343-57a338b8-f04c-4d6d-bec5-b677dbb6e1eb.mov

New physics
https://user-images.githubusercontent.com/39104740/146440570-ba140add-0411-454a-9456-34d6d62e9fc8.mp4
https://user-images.githubusercontent.com/39104740/205434169-8a7197cd-8c00-4d21-8f56-33cf6d58f838.mov

Opt-in
This change has been proven to be breaking for the customer tests.
To opt in, users should provide pageSnappingPhysics: const PageScrollPhysics(useNewPhysics: true)
If tests are broken, this is likely because of the change in minFlingVelocity or minFlingDistance.
Previous values are respectively 50.0 and 18.0.
New values are 400.0 and 25.0.
To migrate the tests, one should change the drag velocity/distance to match the new minimum values.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Adding pageSnappingPhysics also allows for customization of the simulation (and in particular, to use the old simulation).
This might be a sufficient fix for https://github.com/flutter/flutter/issues/55103

Is https://github.com/flutter/flutter/pull/97166#discussion_r874089028 really blocking us from landing this PR? Seems pretty harmless

It isn't a severe API break, it only breaks some tests, so should I really go through all the process outlined in the breaking change policy? https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
This seems a bit excessive, given that there's nothing to actually migrate here, after an opt-in is removed.

after an opt-in is removed.

How will folks know to migrate without guidance? :)
There is a lot here I'd like to look at closely, I don't recall the specific failures that caused it to be reverted before. I'll be able to take a close look at this tomorrow. Nice to see you back!

I'm sorry this is taking a long time for me to respond, but I do remember about this PR and will update it as soon as I can.

No worries at all @nt4f04uNd. I am going to close this for now so it is off our review queue. When you are ready to work on it again, please feel free to reopen it. I'll be here ready to review it. :)

@nt4f04uNd
Do you still have time to take another look at this PR?


Marines who have been cyrod still popup on the overwatch console, allowing command to gain IC knowledge of being in a simulation.

Title

Fixed in https://github.com/RMC-14/RMC-14/pull/3494


Feature Request : Support Python

Thanks for the request. It is under development.

Thanks for the request. It is under development.


Add JS sample for voice assistants

Purpose
Add a sample browser page demonstrating basic set up and interaction with a voice assistant, using the JS Speech SDK
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Recalling and submitting via carbon


Add automatic colour palette extraction to the Image Viewer

The built-in Image Viewer is cool, and mostly useless.  It shows you the file, and some basic size info:

It would be nice if it offered some useful tools to the user.  One idea would be to have it show you the main colours in the current image.  We could use http://jariz.github.io/vibrant.js/ to do it.
The code for this lives in:

https://github.com/humphd/brackets/blob/bramble/src/htmlContent/image-view.html
https://github.com/humphd/brackets/blob/bramble/src/editor/ImageViewer.js

Extracting the colour swatches looks pretty simple:
var img = document.createElement('img');
img.setAttribute('src', 'examples/octocat.png')

img.addEventListener('load', function() {
    var vibrant = new Vibrant(img);
    var swatches = vibrant.swatches()
    for (swatch in swatches)
        if (swatches.hasOwnProperty(swatch) && swatches[swatch])
            console.log(swatch, swatches[swatch].getHex())

    /*
     * Results into:
     * Vibrant #7a4426
     * Muted #7b9eae
     * DarkVibrant #348945
     * DarkMuted #141414
     * LightVibrant #f3ccb4
     */
});

Probably the code would need to go somewhere in the onload for the img in here: https://github.com/humphd/brackets/blob/bramble/src/editor/ImageViewer.js#L120-L149

hi @humphd I'm interested - is there a design of how it should look like if we do add this?

@gideonthomas
16:52 < errietta> gthomas: ok i'm working on https://github.com/humphd/brackets/issues/466
16:53 < errietta> gthomas: so far i have https://github.com/errietta/brackets/tree/errietta/466
16:53 < errietta> i added Vibrant and did vibrant = new Vibrant(..) but it says Vibrant isn't a function
16:53 < errietta> although i can see vibrant.js being loaded
I logged console.log(Vibrant) and it's undefined :open_mouth:

@errietta I pulled your branch to test (btw, I'd caution against using numeric names for branches--I've been burned before by this where the number overlaps with the first digits of a commit SHA, use issue466 or some other word prefix).  It looks to me like they have buggy code for doing the requirejs module wrapping.  I notice that Vibrant is undefined like you said (i.e., local variable in that module), but window.Vibrant exists.  So they are attaching it to the global instead of doing module loading.  For now, why don't you try building the rest of your prototype with window.Vibrant and we can send them a patch upstream if we decide to use their lib.

20:31 < errietta> it works fine
20:31 < errietta> but the thing is, the elements i'm generating with the colours are going underneath the image
20:31 < errietta> and i think i'm going to have to mess with lots of stuff's positioning to fix it
20:31 < errietta> D:
20:32 < errietta> also
20:32 < errietta> i tried with creating elements and appending them rather than doing strings
20:32 < errietta> but i had a really really weird result
20:32 < errietta> being http://imgur.com/CuEoYv9
20:34 < errietta> but yeah i'm more concerned about where to put that info
20:34 < errietta> elemnt wise

16:15 <~humph> errietta: it's neat how fast it is, eh?
16:19 <~humph> errietta: I'd do basically the same as they do here:
               http://jsfiddle.net/oskar/3479gj9e/light/
16:20 <~humph> put the <spans> directly in the html for the image viewer vs.
               doing a dynamic string
16:20 <~humph> we probably need to also figure out some way to show the hex as
               string, so <span> for circle but also some text below or
               something

@humphd got it working now https://github.com/humphd/brackets/pull/478
need design from @flukeout :smile:


Add walkthrough guide

This PR adds a walkthrough of all the bot's commands, in the walkthrough folder. It also adds device_list.md to the guide

Can you add in /delete_auto as well?

Can you add in /delete_auto as well?

Done.


Raspberry Pi/ARM version?

This is really great for amd64, but can you please add an arm version to run on devices like a Raspberry Pi?

I briefly looked into the feasibility of this. It looks like we run ARM Docker containers on Github Actions via qemu-user-static.

There are no plans for the forseeable future to add ARM support. It's technically possible, but building the necessary expertise, organizational infrastructure and testing infrastructure necessary for ARM support is not a priority at the moment.

Other use case is for M1 macs, and we also run Ruby on Graviton2 (ARM64) instances in production that would make good use of this

Looking forward to the arm version!

We want to use this in production but most of our devs run M1 macs so we're forced to break dev/prod parity if we want to use fullstaq-ruby, which seems like an unfortunate trade-off.

We're looking at Graviton2 instances for CI and production too. Not having a release wouldn't be a blocker for us, but would mean we'd have to build our own.

Same as @technicalpickles here, we are migrating from Opsworks with fullstaq-ruby and the most convenient instances are based on Graviton cpus, we would like to continue with fullstaq jemalloc version which gave us more RAM reliability on servers with puma.

We are also wanting to build arm64 images and migrate to Graviton2 instances. We've been using fullstaq-ruby for many years and would greatly appreciate ARM builds! It would be a shame if we have to go back to compiling Ruby or finding a different installation method.


add readme for performance tests with the current state of things

I tried to write down the what is the current state and what are the problems with it.
@hlinnaka @bojanserafimov anything you'd like to add or change?

Great! I added a commit with did some copy-editing and fixing typos, please take a look.


Fix: isBeta challenges should be hidden entirely from map

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #15705

Description

Beta challenges are being filtered out by filterComingSoonBetaChallenge in /common/app/redux/utils.js as expected but the Challenge component is handed all dashed names regardless if it is beta or not. So during the state selection you sometimes end up with a challenge that can't be found in the map (because it was filtered out as mentioned above) so you end up with a psuedo challenge enough to render a bullet but without a title.
A simple fix is to just make sure that the Challenge is not rendered if it receives non existing properties (like title), this means that the code made an attempt to find the challenge in the map but failed.
closes #15705

@mariusespejo nice work. An elegant fix. I like it; @BerkeleyTrue I tested this locally; fixes the problem and doesn't seem to cause anything to break. What do you think?

@dhcodes This looks elegant to me, too. I'm going to go ahead and merge it. Thanks, @mariusespejo!


Fix pull-kubevirt-apidocs

pull-kubevirt-apidocs had some problems with
asciidoctor and classpath.
Solution based on https://github.com/flutter/flutter/issues/23553#issuecomment-583104747
See failure on
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4354/pull-kubevirt-apidocs/1315673973295419393
Signed-off-by: Or Shoval<EMAIL_ADDRESS>None

passes
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4355/pull-kubevirt-apidocs/1315678628293382144

/approve

/lgtm


eslint-plugin-import doesn't work when load entire module

Hello, while using this packahe found that it doesn't work correctly when try to load entire module.
My configuration is
// .eslintrc

"extends": [
    ...
    "plugin:import/typescript"
],

"rules": {
    ...
    "import/order": [
            "error",
            {
                "groups": ["builtin", "external", "internal", ["parent", "sibling", "index"]],
                "pathGroupsExcludedImportTypes": ["builtin"],
                "pathGroups": [
                    {
                        "pattern": "core-config/**",
                        "group": "internal",
                        "position": "before"
                    },
                    {
                        "pattern": "core/**",
                        "group": "internal",
                        "position": "before"
                    },
                    {
                        "pattern": "config/**",
                        "group": "internal",
                        "position": "before"
                    },
                    {
                        "pattern": "inject!*/**",
                        "group": "internal",
                        "position": "after"
                    },
                    {
                        "pattern": "core-test/**",
                        "group": "internal",
                        "position": "after"
                    },
                    {
                        "pattern": "test/**",
                        "group": "internal",
                        "position": "after"
                    }
                ],
                "newlines-between": "always",
                "alphabetize": {
                    "order": "asc",
                    "caseInsensitive": true
                }
            }
        ]
}

"settings": {
        ...
        "import/resolver": {
            "typescript": {
                "project": [
                    "*/tsconfig.json"
                ]
            }
        }
    },

// core/tsconfig.json, other tsconfigs are similar

{
    "extends": "../tsconfig.json",
    "compilerOptions": {
        "baseUrl": ".",
        "paths": {
            "core-config/*": [
                "../core/config/*"
            ],
            "core/*": [
              "../core/src/*"
            ]
        }
    },
    "include": [
        "../core/src/**/*",
        "../core/config/**/*",
        "../core/typings/**/*"
    ]
}

So my example is
import Popup from 'core/popups/Popup';
import Interceptor from 'core/routers/interceptors/Interceptor';
import Router from 'core/routers/Router';

import 'core/plan/SomeManager';

import 'core/steps/some-step/SomeStep';
import 'core/steps/another-step/AnotherStep';

import 'core/popups/Popup1';
import 'core/popups/Popup2';

import 'core/controllers/Controller1';
import 'core/controllers/popups/PopupController';

import 'core/service/SomeService';

So I wonder why eslint argues only about first 3 rows if anything wrong, other stuff just ignores.
Interesting note, I tried to debug it a bit and all that modules are correctly detected as "internal" modules.
It quite looks like this plugin doesn't support such case
UPD. The example above is expected to be like below, but linter doesn't argue it
import 'core/controllers/Controller1';
import 'core/controllers/popups/PopupController';
import 'core/plan/SomeManager';
import Popup from 'core/popups/Popup';
import 'core/popups/Popup1';
import 'core/popups/Popup2';
import Interceptor from 'core/routers/interceptors/Interceptor';
import Router from 'core/routers/Router';
import 'core/service/SomeService';
import 'core/steps/another-step/AnotherStep';
import 'core/steps/some-step/SomeStep';

I'm really not sure what you're referring to. Can you provide the error output you're getting, versus what you expect?

@ljharb sorry, posted update

I'm not sure what the issue is, but I'll be happy to review a PR.
If a PR can be opened that adds failing test cases that would help as well.

The issue describes the case with the import/order rule, when, if you import an entire module, e.g.
import<EMAIL_ADDRESS>
the rule won't work compared to the case when you import a named/partial module with a from statement, e.g.
import styles from<EMAIL_ADDRESS>
In this case, the import/order rule will work as expected.

@evenfrost this is by design - that's not "importing the entire module", that's "evaluating it for side effects" - and as such, its order can never be safely changed programmatically.
"Importing the entire module" would be import * as something from 'specifier'.

Let's put the wording aside as this is rather irrelevant here. Sorry if I confused you with it but glad you understood my example.
As for the rule itself, I don't quite understand what you mean by "can never be safely changed programmatically", but I believe this one should support any import notation — including "importing the entire module", "evaluating it for side effects" etc. There are definitely cases where you should want to use import 'something' notation, like, in my case, importing scoped CSS with babel-plugin-react-css-modules.

It’s fine to use the notation - but it’s impossible to know if changing the ordering of a side-effecting import with respect to other imports that may implicitly depend on it will break code or not.

import 'x' can have side effects, so the order can not be changed in many cases AFAIK.


Option to stream response token by token

Although streaming wasn't in our original design since we felt like it was unnecessary for most academic and many production-system use cases, I've been thinking about methods to implement it with the following constraints:

No breaking changes - existing 0.x code should not need to account for a new return type, for example
Minimal added complexity to the Engine interface, optimally it should be an optional implementation s.t. streaming code can still interchange with non-streaming engines
Compatibility with function calling - this might end up piggybacking off the optional constraint above

In my mind the interface would look something like:
async for msg_stream in kani.full_round_stream(...):
	# design consideration: what message stream would function calls emit?
	# msg_stream should be a StreamManager object so that you can access header data like role before consuming
	async for token in msg_stream:
		# stream code here

	# to get the full content as a ChatMessage - this would consume the full stream if called before finished
	msg = await msg_stream.message()

I don't think this'll be implemented in 0.x but I'd like to implement this as a 1.x feature.


MSID: 94242 Version: 1 DOI: 10.1101/2<IP_ADDRESS>3936

MSID: 94242
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3936
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=94242
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3936

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/94242v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3936
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/94242/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Peer review content to load.
Bastard et al 2020, duplicate formatting in reference list.


source loaded but no completion

source is loaded but I am not getting any completion from cmp-dictionary. I am aware of the v2 changes and am not using any .setup()
This is my only reference to cmp-dictionary in my config file.
# cmp.lua
cmp.setup {
  sources = {
    { name = "dictionary" },
    ...
  },
  ...
}

:CmpStatus
# ready source names
- dictionary
- ...

Do you have 'dictionary' set?
You can specify the dictionaries you want to always use as global value, and the ones you want to use only under certain conditions as buffer-local (switcher is useful).
See help for details; :h cmp-dictionary and :h cmp-dictionary-utilities-switcher.
Example:
vim.opt_global.dictionary = "/path/to/en.dict"

local dict = require("cmp_dictionary")
dict.switcher({
  filetype = {
    lua = "/path/to/lua.dict",
    javascript = { "/path/to/js.dict", "/path/to/js2.dict" },
  },
})

Please try to update it. Is it fixed?

Hi!
I try to run the command CmpDictinaryUpdate, and I've got this error:
Error executing Lua callback: .../packer/start/cmp-dictionary/lua/cmp_dictionary/util.lua:40: handle 0x55fac3b41390 is already closing
stack traceback:
[C]: in function 'close'
.../packer/start/cmp-dictionary/lua/cmp_dictionary/util.lua:40: in function 'debounce'
...acker/start/cmp-dictionary/lua/cmp_dictionary/caches.lua:135: in function 'update'
.../packer/start/cmp-dictionary/lua/cmp_dictionary/init.lua:8: in function <.../packer/start/cmp-dictionary/lua/cmp_dictionary/init.lua:7>
Here is my config:
dict.setup({
	spelllang = {
		["*"] = "~/dotfiles/en.dict",
	},
	exact = 3,
	first_case_insensitive = false,
	document = false,
	document_command = "wn %s -over",
	async = false,
	max_items = -1,
	capacity = 5,
	debug = false,
})

Could anyone give me some light to sort this issue?
Thank you in advance!

@Joarell Sorry, it's bug. I fixed.
Also, the way you set it up is wrong. Please check the latest version of the doc.

I've tried this:
dict.setup({
	exact = 3,
	first_case_insensitive = false,
	document = false,
	document_command = "wn %s -over",
	async = false,
	max_items = -1,
	capacity = 5,
	debug = false,
})

dict.switcher({
	spelllang = {
		["*"] = "~/dotfiles/en.dict",
	},
})

The error was fixed!
Now I can run the CmpDictinaryUpdate.
Thank you a lot!
But the cmp, is not getting the words from the dict file when I'm typing.
I can figure it out what I'm missing:
cmp.setup({
	snippet = {
		expand = function(args)
			if not ls then
				return
			end
			ls.lsp_expand(args.body)
		end,
	},
	sources = {
		{ name = "luasnip" },
		{ name = "path" },
		{ name = "buffer", keyword_length = 3 },
		{ name = "cmdline", keyword_length = 3 },
		{ name = "dictionary", keyword_length = 3 },
		-- { name = "cmp_tabnine", keyword_length = 3 },
	},
	window = {
		completion = cmp.config.window.bordered(),
		documentation = cmp.config.window.bordered(),
	},
	formatting = {
		expandable_indicator = true,
		fields = { "kind", "abbr", "menu" },
		format = lspkind.cmp_format({
			mode = "symbol_text",
			maxwidth = 50,
			ellipsis_char = "...",
			menu = {
				nvim_lsp = "   ",
				luasnip = "   ",
				buffer = "  ",
				path = "  ",
				cmdline = " ",
				dictionary = "  ",
				-- cmp_tabnine = "[TabN]",
			},
			before = function(_, vim_item)
				return vim_item
			end,
		}),
	},

Thank you a lot for your prompt reply!
Now I can run CmpDictinaryUpdate, perfectly.
But... when I start neovim I got this error:
Error executing vim.schedule lua callback: .../packer/start/cmp-dictionary/lua/cmp_dictionary/util.lua:48: attempt to index upvalue 'timer' (a nil value)
stack traceback:
.../packer/start/cmp-dictionary/lua/cmp_dictionary/util.lua:48: in function ''
vim/_editor.lua: in function <vim/_editor.lua:0>
I try these settings, could you please let me know if it's right?
dict.setup({
	exact = 3,
	first_case_insensitive = false,
	document = false,
	document_command = "wn %s -over",
	async = false,
	max_items = -1,
	capacity = 5,
	debug = false,
})

dict.switcher({
	spelllang = {
		["*"] = "~/dotfiles/en.dict",
	},
})

cmp.setup({
	snippet = {
		expand = function(args)
			if not ls then
				return
			end
			ls.lsp_expand(args.body)
		end,
	},
	sources = {
		{ name = "luasnip" },
		{ name = "path" },
		{ name = "buffer", keyword_length = 3 },
		{ name = "cmdline", keyword_length = 3 },
		{ name = "dictionary", keyword_length = 3 },
	},
	window = {
		completion = cmp.config.window.bordered(),
		documentation = cmp.config.window.bordered(),
	},
	formatting = {
		expandable_indicator = true,
		fields = { "kind", "abbr", "menu" },
		format = lspkind.cmp_format({
			mode = "symbol_text",
			maxwidth = 50,
			ellipsis_char = "...",
			menu = {
				nvim_lsp = "   ",
				luasnip = "   ",
				buffer = "  ",
				path = "  ",
				cmdline = " ",
				dictionary = "  ",
			},
			before = function(_, vim_item)
				return vim_item
			end,
		}),
	},

@Joarell
You cannot use * for spelllang. If you have a dictionary that you want to always use, set values to a global 'dictionary'.
vim.opt_global.dictionary = "/path/to/en.dict"

And I could not reproduce that error on my end. Please start a new issue and let me know the detailed minimum configuration.

If you can give me as small an init.lua as possible that can reproduce the problem and the steps to reproduce it, I may be able to solve it.

Unfortunately, I tried that setting and could not reproduce it.
Could you try the following init.vim to see if you can reproduce it?
Place this file as ~/.config/minimal/init.vim and try starting it with NVIM_APPNAME=minimal nvim.
let s:plug_dir = expand('/tmp/plugged/vim-plug')
if !filereadable(s:plug_dir .. '/autoload/plug.vim')
  execute printf('!curl -fLo %s/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim', s:plug_dir)
end

execute 'set runtimepath+=' . s:plug_dir
call plug#begin(s:plug_dir)
Plug 'hrsh7th/nvim-cmp'
Plug 'uga-rosa/cmp-dictionary'
call plug#end()
PlugInstall | quit

lua <<EOF
local cmp = require('cmp')
vim.opt_global.dictionary = "/usr/share/dict/words"

cmp.setup({
  sources = {
    { name = "dictionary" },
  },
})
EOF

@madsonic
Since I haven't received any replies, it's time to close this issue. you can reopen it.


[MM-47966] Improve accessibility for user group popovers

Summary
Does the same thing as https://github.com/mattermost/mattermost-webapp/pull/11530 but for the new user group popovers. I decided to split this PR into two just to make merging easier.
Ticket Link
Jira ticket
Screenshots
https://user-images.githubusercontent.com/112951043/204305369-87c876bf-14f9-4c76-90a9-f3d167a8d0f6.mov
Release Note
NONE

Summary
Does the same thing as #11530 but for the new user group popovers. I decided to split this PR into two just to make merging easier.
Ticket Link
Jira ticket
Screenshots
Screen.Recording.2022-11-28.at.9.38.53.AM.mov
Release Note
NONE

That look awesome @cyrilzhang-mm! Nice one.

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

/update-branch

/cherry-pick cloud

Cherry pick is scheduled.


Versioning

Implement the new versioning scheme.

Pull Request Test Coverage Report for Build 230

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 91.349%

Totals

Change from base Build 228:
-0.03%

Covered Lines:
1605

Relevant Lines:
1757

💛  - Coveralls


Running setup.py install for scipy... error

Hi. I've been trying to install Linguistica on Windows with pip install linguistica, but I keep getting the above error. After trying to find several missing files, the command terminal comes back with an error code 1. Even after successfully installing scipy beforehand, installing linguistica automatically uninstalls scipy and tries to install it again with setup.py, coming back the the error again... Is there a solution to this? Thanks.

Hello, please try the following two commands:

pip install -U pip (to ensure pip is up-to-date)
pip install scipy>=0.19.0,<=0.19.99 (that's the scipy version pinned for the linguistica 5.2.0 release)

Hopefully everything goes with the above, and then please try pip install linguistica again.

@IvanAlvarez lxa5 should also work with any recent versions of scipy (currently v1.1.0). (I've updated my comment above.) It looks like from your output that your system was trying to install scipy from the source .tar.gz, which involved the rather error-prone stage of wheel building. If you're on {mini,ana}conda, would something like conda install scipy work instead?

Ah, I see. I think there might be an issue with detecting if valid dependencies are present. I can successfully install scipy (v1.1.0) via pip/conda, but when I try pip install linguistica it still attempts to pull various packages at specific releases, and install them from source:
Collecting networkx<=1.11.99,>=1.11 (from linguistica)
Collecting six<=1.10.99,>=1.10.0 (from linguistica)
Collecting scipy<=0.19.99,>=0.19.0 (from linguistica)
Collecting numpy<=1.12.99,>=1.12.1 (from linguistica)
Requirement already satisfied: decorator>=3.4.0 in ./anaconda3/lib/python3.7/site-packages (from networkx<=1.11.99,>=1.11->linguistica) (4.3.0)
Building wheels for collected packages: scipy, numpy
  Running setup.py bdist_wheel for scipy ... error
[...]

And it ends up with the same error I posted above.

That worked a treat, thank you!


Fixed info banner positioning issues

Refactored constraint usage and animation implementation details

And long-long living bug finally gone. Awesome!


ADB Connection closes on second device when I leave the house? Strange issue

[X] I have read the FAQ.
[X] I have searched in existing issues.

Environment

OS: Windows 10 22H2
scrcpy version: 2.3.1
installation method: Windows release
device model: OnePlus Nord N20 5G (GN2200)
Android version: 12

Describe the bug
I have been trying to research this weird issue that I have been having for a while. I am unable to find anything online about this particular problem. I'm currently testing out software and it runs smoothly with no issues while I'm home and while I am sleeping. However, when I go to work or the store, or anywhere outside my home I will use the google remote access to check in on it, and it's disconnected. I thought it might be the remote desktop somehow, but as long as I am home, I can still remote in and find out that it's still connected. Is the second phone somehow connected to my main phone?
I have also tried restarting the second phone, connecting it to USB, starting scrcpy and immediately go down the street, and it disconnects the second I get far enough away. I know the "WARN: Device disconnected" is the adb connection closing, but I can not figure out why it only closes when I leave. Any ideas?
Here is what I have for the 'scrcpy-console.bat'
scrcpy.exe --pause-on-exit=if-error %* -d

E:\scrcpy-win64-v2.3.1>scrcpy
scrcpy 2.3.1 <https://github.com/Genymobile/scrcpy>
INFO: ADB device found:
INFO:     -->   (usb)              fa9f2574            device  GN2200
E:\scrcpy-win64-v2.3.1\scrcpy-server: 1 file pushed, 0 skipped. 6.7 MB/s (66007 bytes in 0.009s)
[server] INFO: Device: [OnePlus] OnePlus GN2200 (Android 12)
INFO: Renderer: direct3d
INFO: Texture: 1080x2400
[server] INFO: Retrying with -m1920...
[server] INFO: Retrying...
[server] ERROR: Encoding error: java.lang.IllegalArgumentException: null
INFO: Texture: 864x1920
WARN: Device disconnected

Please do not post screenshots of your terminal, just post the content as text instead.

I know the "WARN: Device disconnected" is the adb connection closing, but I can not figure out why it only closes when I leave

Not sure I understand everything, but maybe wifi tethering? Anything that could "reset" the USB layer (similar to MTP, PTP, etc.)

I know the "WARN: Device disconnected" is the adb connection closing, but I can not figure out why it only closes when I leave

Not sure I understand everything, but maybe wifi tethering (or bluetooth)? Anything that could "reset" the USB layer (similar to MTP, PTP, etc.)
You might get some clues in adb logcat.

I checked and bluetooth tethering is turned off and the IP address on each phone is different

This is really weird and I am completely lost. I have it up and running now, and I turned of my main phone and scrcpy is still running. It only closes when I physically leave


Installation fails on macOS 12

Hi, I tried to install this on my macOS 12 machine and it fails during the Playwright installation:
Error: Failed to download chromium, caused by
Error: ERROR: Playwright does not support chromium on mac12

This is caused by the old Playwright version in the dependencies, macOS 12 is supported by >=1.13.0 If I see this correctly. The current version is 1.16.3 (1.17.0 coming very soon).

Hi there, this plugin only works with playwright '1.10' and storybook '6.3', unfortunately i don't have a time to maintain the project, so will archive it soon.

Too bad, this actually looks quite useful :(