fix/debug panic from kfc integration test

Coverage decreased (-0.06%) to 68.888% when pulling 88147adf84cea30729303d4c2278bb3d1f9f0416 on fix-kfc-test into 226fb2c55b7c5132ec23414996abee9d05b6b770 on master.

Coverage decreased (-0.002%) to 68.944% when pulling f08c922756d4a8c28af21906fba33ce06c9b25b8 on fix-kfc-test into 226fb2c55b7c5132ec23414996abee9d05b6b770 on master.


Split package into base and full packages

#6
I mostly copied what we did in https://github.com/conda-forge/openff-toolkit-feedstock/pull/3/files
The highlight is that the base package requires openff-toolkit-base and doesn't pull in OpenMM (I'd trust any user to know they need this), Pandas, or panedr (which could possibly be pulled out of required dependencies altogether). This is about as thin as I think I could make the base package.
cc: @simonboothroyd

@conda-forge-admin please rerender


[Perf] Cache the ModelMetadata for known type "object"

Fixes #4377
Scenario : https://github.com/aspnet/Performance/tree/dev/testapp/HelloWorldMvc
Before Optimization

After Optimization

I don't think the data included here is sufficient to conclude anything, 6ms of sampling data is a tiny amount. I'll start reviewing the changes and let's talk tomorrow about how to gather more data.

:up::date:

Is there updated perf data for this? Come by if you want help collecting data

@rynowak  I updated the profiles with more sampling data

Not getting a warm feeling from looking just at the time spent activating ViewDataDictionary properties in controllers. From #4377 we know that activation accounts for ~1.8% of execution time and the above data shows we save ~20% of that. But I'd prefer a more direct comparison.
On the other hand, I suspect we get the metadata for typeof(object) enough other places that there may be a larger change in the overall time spent inGetMetadataForType() relative to the rest of the app.

:watch:

:up::date:

Data looks much more convincing! Thanks :+1:

:shipit: but with fewer assertions.


Added simple implementation of NuMaker PFM-M2351

Howdy folks,
I own a NuMaker PFM-M2351 that I wanted to use with Zephyr.  I've tried to follow the previous NuMaker-PFM-M487 as an example for adding both a board and soc.
I'm very new to embedded/rtos' so I'd really appreciate a fine-tooth'd review.  Known-Unknowns I've called out with XXX to hopefully draw extra eyes to those lines.
I can say that both zephyr/samples/synchronization and zephyr/samples/hello_world both work, so at a minimum I have UART working ^.^. [edit -- I should say I have it working only with extra args to the west flash command, I wasn't sure how to specify special openocd settings as part of the config files]
I have added the numicro hal as part of my selects here, to use the already existing numicro_uart driver.  This does require a modification to the hal which is in a separate PR: zephyrproject-rtos/hal_nuvoton#3

Sorry it took me so long to get back to this, @galak.  I believe I've made the suggested changes!

We try to build but it seems to lack "NuMicro.h" file which causes build error.

Howdy @wschang0,
That was added to the separate repo hal_nuvoton -- https://github.com/zephyrproject-rtos/hal_nuvoton/pull/3

Hi Travis,
We suggest to enable the configuration in "nuvoton_pfm_m2351_defconfig" for download and debug message.
CONFIG_BUILD_OUTPUT_HEX=y
CONFIG_UART_NUMICRO=y
Adding openocd support by edit "openocd.cfg" file content by "target/numicroM23.cfg"
For m2351\soc.c, you may need to add "CLK_SetCoreClock(FREQ_64MHZ);" in z_arm_platform_init()
To enable PLL of M2351 for CPU speed.
Regards,
WS
From: Travis Beatty @.>
Sent: Thursday, November 11, 2021 9:37 PM
To: zephyrproject-rtos/zephyr @.>
Cc: MS20 WSChang0 @.>; Mention @.>
Subject: Re: [zephyrproject-rtos/zephyr] Added simple implementation of NuMaker PFM-M2351 (PR #39681)
Howdy @wschang0https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwschang0&data=04|01|wschang0%40nuvoton.com|b13a64a8b6564d29845308d9a5185da0|a3f24931d4034b4a94f17d83ac638e07|0|0|637722346344112491|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=4w2bQB0XNqivKE9IyJ1QGeQw442vzh5ZVtWzvG7HVPU%3D&reserved=0,
That was added to the separate repo hal_nuvoton -- zephyrproject-rtos/hal_nuvoton#3https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzephyrproject-rtos%2Fhal_nuvoton%2Fpull%2F3&data=04|01|wschang0%40nuvoton.com|b13a64a8b6564d29845308d9a5185da0|a3f24931d4034b4a94f17d83ac638e07|0|0|637722346344122489|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=6kaTgEs6oooqIdKJG4pWwFofQ8cJ4SSbordkHIPGV7o%3D&reserved=0

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzephyrproject-rtos%2Fzephyr%2Fpull%2F39681%23issuecomment-966308318&data=04|01|wschang0%40nuvoton.com|b13a64a8b6564d29845308d9a5185da0|a3f24931d4034b4a94f17d83ac638e07|0|0|637722346344122489|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=sd990BEZG4wb%2BBWyNc4paxKToXb1RjGmbLPue2Vz%2BU8%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEM3XD7PTVO437YOEZ7G2YDULPBILANCNFSM5GTRDQBA&data=04|01|wschang0%40nuvoton.com|b13a64a8b6564d29845308d9a5185da0|a3f24931d4034b4a94f17d83ac638e07|0|0|637722346344132492|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=qVxKYkk0v0cm2M99y3Mp5xBnvFRaDCg6ILMNTjl7PTA%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|wschang0%40nuvoton.com|b13a64a8b6564d29845308d9a5185da0|a3f24931d4034b4a94f17d83ac638e07|0|0|637722346344142474|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=UHid%2BmKywuYD5LMd5S8cwsGSM2MfmofCHLIMA637B0o%3D&reserved=0 or Androidhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|wschang0%40nuvoton.com|b13a64a8b6564d29845308d9a5185da0|a3f24931d4034b4a94f17d83ac638e07|0|0|637722346344142474|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yO9WajQ5wJ2FJnqm5AJAo%2FIiwhvfS3c9iGakYwpy180%3D&reserved=0.

The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.


Update Bolt Account Address to Bolt

When a new address is added in the user AddressBook it should be added to the bolt account through the API https://help.bolt.com/api-bolt/#tag/Account/operation/AddAddress

Note that Bolt's API only supports adding addresses right now, but we're updating our API to support updating and deleting addresses. I'll keep you posted when updating and deleting are available.

I have a small worry about this task. Since we already have implemented code that imports all address from Bolt and saves them locally, if we were to send all the local address to Bolt without the option to update existing ones we'd run the risk of an infinite loop. As far as I understand on Solidus' side it shouldn't be much of an issue as we always display only 2 addresses, but I wonder about Bolt's side.
In any case to deal with this task for the time being we could add a new column to address bolt_id and check its presence before syncing on either side.

Considering that Solidus doesn't allow to update the address, I think that adding a bolt_id on the address won't fix the problem. I think that the only way to avoid address duplication at Bolt side will be to check all the addresses related to the account and skip address creation if another similar address is already present.

Bolt's API should support updating and deleting addresses early next week.
@Naokimi, how would an infinite loop occur if syncing addresses from Bolt to Solidus detected when a Bolt address already exists in Solidus?
In Solidus, what's the relationship between a User and a User Address Book? Multiple addresses can be stored in an address book, but the Get User API returns a "bill address" and "ship address". Are those the default billing and shipping addresses that are set from a user's collection of addresses?

AFAIU yes, those two address are the ones that get displayed (on the app and in the API), and the address book has only those 2 addresses, but any address added or modified gets created as a separate record in the DB.


Bees aren’t spawning

Describe the problem
Beehives without bees… :(
What Should Happen
Bees should be spawning
What Biome

Object Id

Minecraft Version
1.17.1
Iris Version
1.6.6
Relevant log output. (IF APPLICABLE)
No response
Checklist

[X] I am using an unmodified version of the overworld. (If you modified the overworld and see an issue, contact support)
[X] I am using the latest version of the overworld OR I have made sure this issue was not already resolved on the latest version.
[X] I am using Spigot, Paper, Tuinity, or Purpur. (If you are not, and still think it is a valid issue, contact support)

What
I just made a PR for this, showed you how to download and use the PR, but you still opened this?
confusion
#197

What
I just made a PR for this, showed you how to download and use the PR, but you still opened this?
confusion
#197

You fixed for 1 biome, right?
But as I saw the other biomes had this issue too. I talked with Nextdoor who said open an issue.
Sorry if I misunderstood something.

I think I got all the birch trees with beehives, which other biomes/objects did you also see without bees?

I think I got all the birch trees with beehives, which other biomes/objects did you also see without bees?

I add it tomorrow! 🙂

I coudn't find beehies at oak forest but I found some in this biome: https://imgur.com/a/H5fCU5A
I found a lot of beehives but barely I found only 1 bee

latest!


Wrong device_hash, client_type and api_key combination

Combination of device_hash, client_type and api_key doesn't seem to be working

Thanks @tedschmidt, should be fine now


Feature request: Display time until code invalidation

I think it should be reasonably easy to print time in seconds that a code will still be valid, something that Google Authenticator displays with that pie icon.
Some providers will allow for a few seconds of 'delay', but the other would outright reject a code.
So the output would be something like:
totp-cli generate namespace account
Password: ***
889840 | 25s

Available in v1.7.0.
❯ go run . generate --show-remaining namespace account
Password: ***
465669 (remaining time: 26s)

Available in v1.7.0.
❯ go run . generate --show-remaining namespace account
Password: ***
465669 (remaining time: 26s)

Great! Didn't see it in the embedded help command and so I've assumed that it just isn't there

It wasn't there, it's there only since v1.7.0, which contains only the #89 pull request.


HMAC-SHA256 TOTP support

I have another case of an unfortunate and obscure OTP type, provided by an authenticator that my bank uses. They use the Entrust IdentityGuard authenticator. I attached an Android debugger to it and extracted the OTP key, but found that they use HMAC-SHA256 instead of the much more prolific HMAC-SHA1. I can use oathtool to generate Entrust IdentityGuard compatible OTP keys by doing:
$ oathtool -v --totp=sha256 --digits=8 fd33e2e8ad3cb1bdd3ea8f5633fcf5

NOTE: Not my real key -- just a truncated md5sum of 'hi there', since their seed size is 15 bytes.
Any chance you could implement HMAC-SHA256 for OATH?

out of curiosity, does anyone have a nice way to extract the secret?  i messed around with android studio in debug mode, but it's a total cluster-f.

No, there's no way to extract TOTP secrets from the YubiKey.

@emlun I think he meant from the Entrust IdentityGuard app.

Oh, ok. Thanks @tycho.
In that case, please move that discussion to the discussion channel(s) for that app instead.

Thanks.  I was hoping to pull the secret from entrust and put it on a yubikey instead, so I thought somebody might know how to do that.  Entrust isn't exactly helpful since they have their nice walled garden already.


ChainScript versioning

After breaking change or new mandatory fields, new client version will try to access to the new data but it has to keep backward compatibility for old segments.

Done by moving to go-chainscript.


Not working with Laravel Valet

Thank you for making this package. It comes at the perfect time for me, I'm just starting to use websockets on a project I've got running.
It might be an oversight on my part, but I can't get this to work with Laravel Valet. Using Pusher with Laravel's default config works, but as soon as I make the necessary changes in the config and try to broadcast an event I get an empty Illuminate\Broadcasting\BroadcastException.
config/broadcasting.php
'pusher' => [
            'driver' => 'pusher',
            'key' => env('PUSHER_APP_KEY'),
            'secret' => env('PUSHER_APP_SECRET'),
            'app_id' => env('PUSHER_APP_ID'),
            'options' => [
                'cluster' => env('PUSHER_APP_CLUSTER'),
                'host' => '<IP_ADDRESS>',
                'port' => 6001,
                'scheme' => 'https',
                'curl_options' => [
                    CURLOPT_SSL_VERIFYHOST => 0,
                    CURLOPT_SSL_VERIFYPEER => 0,
                ]
            ],
        ],

config/websockets.php
'apps' => [
        [
            'id' => env('PUSHER_APP_ID'),
            'name' => env('APP_NAME'),
            'key' => env('PUSHER_APP_KEY'),
            'secret' => env('PUSHER_APP_SECRET'),
            'enable_client_messages' => false,
            'enable_statistics' => true,
        ],
    ],

    'app_provider' => BeyondCode\LaravelWebSockets\Apps\ConfigAppProvider::class,

    'allowed_origins' => [
        //
    ],

    'max_request_size_in_kb' => 250,

    'path' => 'laravel-websockets',

    'statistics' => [
        'model' => \BeyondCode\LaravelWebSockets\Statistics\Models\WebSocketsStatisticsEntry::class,

        'interval_in_seconds' => 60,

        'delete_statistics_older_than_days' => 60,
    ],

    'ssl' => [
        'local_cert' => '/Users/ronflorax/.config/valet/Certificates/snookerscores.test.crt',

        'local_pk' => '/Users/ronflorax/.config/valet/Certificates/snookerscores.test.key',

        'passphrase' => null,

        'verify_peer' => false,
    ],

Are you seeing any errors in your browser console, like a closed connection or a 404 error? It's possible you just need to update your Echo config to use encrypted connections over wss.
window.Echo = new Echo({
    broadcaster: 'pusher',
    key: process.env.MIX_PUSHER_APP_KEY,
    wsHost: window.location.hostname,
    wsPort: 6001,
    wssPort: 6001,
    encrypted: true,
    disableStats: true
});

Also, in broadcasting.php, add 'encrypted' => true to your pusher config options.

you don't need to add encrypted => true to your broadcasting.php
however you do need to add wssPort: 6001 in your bootstrap.js and then rebuild the app using npm run prod
had the same problem yesterday and it's working now. This is all explained here too https://docs.beyondco.de/laravel-websockets/1.0/basic-usage/ssl.html#usage-with-laravel-valet

Thanks for the tips, however neither work, as it's actually going wrong before consuming the events, it goes wrong when dispatching them from an artisan command, so no javascript involved yet. I tried adding 'encrypted' => true either way and it made no difference.

I am having the same issue using Laravel Valet.

I tried every possible means to follow the docs with regards to SSL but just couldn't get it to work. However, this is how I finally got it working with SSL on homestead.
changed boostrap.js to listen on 6002 instead
window.Echo = new Echo({     broadcaster: 'pusher',     key: process.env.MIX_PUSHER_APP_KEY,     wsHost: process.env.MIX_PUSHER_WEBSOCKET_HOST,//window.location.hostname,     wsPort: 6002,     wssPort: 6002,     disableStats: true,     encrypted: true });
added these two keys to my .env file
MIX_PUSHER_WEBSOCKET_HOST="${PUSHER_WEBSOCKET_HOST}"
PUSHER_WEBSOCKET_HOST=socket.websocket-demo.app
note that the above, websocket host, is actually a subdomain,
'pusher' => [             'driver' => 'pusher',             'key' => env('PUSHER_APP_KEY'),             'secret' => env('PUSHER_APP_SECRET'),             'app_id' => env('PUSHER_APP_ID'),             'options' => [                 'cluster' => env('PUSHER_APP_CLUSTER'),                 'encrypted' => true,                 'host' => env('PUSHER_WEBSOCKET_HOST','<IP_ADDRESS>'),                 'port' => 6002,                 'scheme' => 'https',                 'curl_options' => [                     CURLOPT_SSL_VERIFYHOST => 0,                     CURLOPT_SSL_VERIFYPEER => 0,                 ]             ],         ],
in broadcasting.php
and then finally using the sample nginx config found at https://docs.beyondco.de/laravel-websockets/1.0/basic-usage/ssl.html#usage-with-a-reverse-proxy-like-nginx
except, adding the line in the config to listen on 6002
listen        443 ssl;   listen        [::]:443 ssl;   listen 6002;
and that's just about it

Why is this issue closed? 😳

I was thinking the answer of @anabeto93 solved the issue. Reopended.

@ronfloraxCT @Livijn
I was having trouble getting this to work with Laravel Valet and now everything works fine. The demo works fine and I also have it working with a standalone websocket app that is now handling web sockets for 5 of my apps (this is all on my macbook dev using Laravel Valet with --secure
My thread here might prove useful https://github.com/beyondcode/laravel-websockets/issues/8
I suggest you take a step back and try to get the demo working with Laravel Valet first. Once you have that working then you can try to get your own apps working.
Also I think @anabeto93's response has nothing to do with Valet.. correct me if I'm wrong but when you use Homestead you don't use Valet at all.

Adding this solved it for me!
'curl_options' => [
    CURLOPT_SSL_VERIFYHOST => 0,
    CURLOPT_SSL_VERIFYPEER => 0,
]

@vesper8 Unfortunately that thread doesn't help me, because most of it concerns Laravel Echo, and my problem occurs before that. The one post in it which does show the same error as me is somehow resolved by using the same settings I have been using from the start, which is weird. I copy-pasted them to be sure. So in short, I'm still stuck with this!

Turns out it does work if the server is running, but if it's not running it fails as described in the original post. I think it's quite misleading that it fails without any error to be honest! I don't have the server running permanently in my test environment, but it seems I'll have to keep an eye on this. Closing this for now.

@ronfloraxCT ah. Yes. The server does need to be running to be able to broadcast any events since the events are broadcasted over the http(s) API.
You will also get a exception if Pusher goes down for example since the broadcast API request fails.
You could for example add a check around each broadcast, for example if (env('ENABLE_BROADCASTS', true)) and add ENABLE_BROADCASTS=false to your .env locally to quickly disable broadcasting for your local environment.


Assign task -  We are able to open archived chat's description via deeplink

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open website
Click on plus icon > Assign task > Type something to title and click on btn > Choose assigners > Click on confirm task btn > After opening the chat for it , Click on Description and copy the deeplink
Cancel the task and paste the URL and open it

Expected Result:
We should not be able to open archived chat's description via deeplink
Actual Result:
We are able to open archived chat's description via deeplink
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture (94).webm
https://github.com/Expensify/App/assets/78819774/a070ac0c-69cb-4e56-a2ac-b0a25439302d
Expensify/Expensify Issue URL:
Issue reported by: @mahmudjontoraqulov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691402788238729
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ee1805503af10326
Upwork Job ID:<PHONE_NUMBER>712176128
Last Price Increase: 2023-08-18

This is BE issue. When we cancel the task BE returns the correct report's statusNum(2). But if we copy the deeplink and open it, the BE returns wrong report's statusNum(0).

Thanks @alphaboss1104! Getting eyes on this now 👍

@aldo-expensify Does this seem like a BE issue? Just wanted confirmation — TIA!

Maybe, I'll try to look into it later during the day

Ahh, @thienlnam seems to be working on this at the moment here: https://github.com/Expensify/App/pull/24137
I'm guessing we should HOLD until that is done or close this

On hold — so not overdue 👍
Going to set this as weekly

Still on-hold 👍

@aldo-expensify Just checking to see if thee is an update — TIA!

https://github.com/Expensify/App/pull/24137 is still a draft
@thienlnam that is still on progress right? or did we decide to go some other direction?

Still in progress - haven't had time to prioritize

Merged, we can try to see if this is still a problem on main

If we try to access the description using the link, we see now the not found message "Hmm... It's not here"

I guess this is fixed now?

Yup that looks correct

Thanks @thienlnam , closing then


free batchnormalization layer for resnet50

According to https://arxiv.org/pdf/2007.01434.pdf
appendix D,
"
For the architecture “Resnet-50”, we replace the final (softmax) layer of a ResNet50 pretrained on
ImageNet and fine-tune. Observing that batch normalization interferes with domain generalization
algorithms (as different minibatches follow different distributions), we freeze all batch normalization
layers before fine-tuning. We insert a dropout layer before the final linear layer.
"

freeze bathnorm:
can be done using

net_torchvision.<name of a batchnormalisation layer>.requires_grad_(False)

From short investigation I think the batchnormalisation layer are all called bn1, bn2, ...
One needs to also go into the deeper structures by using net_torchvision.layer1, net_torchvision.layer2, ...


[$1000] [Android] Font Line Spacing issue - "We’re here to clear your path to greatness” has less gap between the lines on Android vs mweb Chrome

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Android. Go to Settings. Go to any workspace.
Click on any workspace
Click on the ? icon on top and notice that the text ‘We’re here to clear your path to greatness’ has no gap between the lines
Repeat the same process on mweb Chrome and notice that the text has more of a gap between the lines.

Expected Result:
The text ‘We’re here to clear your path to greatness’ should have the same gap in Android as that of mweb Chrome
Actual Result:
The text has no gap between the lines on Android
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.90-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679909349765189
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cec29c2848619f3e
Upwork Job ID:<PHONE_NUMBER>282015232
Last Price Increase: 2023-03-28

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jliexpensify and I traded issues so that we can test more simply with our physical devices.

Can confirm on Pixel 3a:

Job added to Upwork: https://www.upwork.com/jobs/~01cec29c2848619f3e

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

Triggered auto assignment to @Julesssss (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Section title has less gap between the lines on Android
What is the root cause of that problem?
lineHeight is not set so line spacing depends on font family and size.
https://github.com/Expensify/App/blob/d3b380dfa84d15396735437ee7e6be5347221d49/src/components/Section.js#L46
this uses ExpensifyNewKansas-Medium font and line spacing is too small in Android by default. No issue in other platforms.
What changes do you think we should make in order to solve the problem?
We can manually set lineHeight for platform consistency.
The value can be adjusted by design team.

📣 @Milos213! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0159655756a85f561f

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Thanks for the proposals.
I don't love the idea of needing to call the styleUtils for every usage of the Text component. Manually setting lineHeight also isn't great.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace assistance’s title “We're here to clear your path to greatness!” has smaller line-spacing on Android vs mWeb
What is the root cause of that problem?
There is no lineHeight defined for this component, so it falls into the default line height, which is different for Android.
What changes do you think we should make in order to solve the problem?
An explicit lineHeight must be set in the CSS styles, to keep consistent styling and avoid different devices from appling their own default values.
Since there’s a defined convention for in the variables.js file for implementing Line Height, among other properties, a new property should be added to address this solution:
lineHeightXLarge: getValueUsingPixelRatio(20, 24),
lineHeightXXLarge: getValueUsingPixelRatio(27, 32), // <---- New property should be added to the variables.js module //
inputHeight: getValueUsingPixelRatio(52, 72),

Then this style variable should be passed to a new lineHeight property in the SyleSheet, so it can be reusable when needed:
lineHeightXXLarge: {
	lineHeight: variables.lineHeightXXlarge,
},

Finally, the specific style should be added to the Text component to implement the solution:
<View style={[styles.flexShrink1]}>
	<Text style={[styles.textHeadline, styles.lineHeightXXLarge]}>{props.title}</Text> // <--- New Style added to Text component //
</View>

What alternative solutions did you explore? (Optional)
Considered adding a separate assistanceTitle property to the StlyeSheet that would include the lineHeight style, similar to a solution implemented on the Sign in Page’s Footer Titles, but the chosen solution above wolud result in a more reusable solution.
Result:

📣 @ericsonrd! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

⚠ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~019285778280f36178

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Still waiting on better solutions

Can anyone explain the root cause in low level? Why does it happen in Android only? How does fontFamily affect platform?

From my research over the past several days (amazing how hard to find is this information) here's what I've gathered:
Font line height measurement system
Android uses a different measurement system for line spacing than web and other platforms.
Web and iOS
Most web browsers’ line height or leading is influenced by the font and font size used, and in the case of iOS, this value also depend on other factors such as text, alignment, paragraph style, context and layout of the text.
If no line height is specified in the code, these systems will use the default value of the font being used. As a general rule the default line height value for web browsers is around 1.2 times or 120% of the font size. in iOS this default line height is around 1.2 - 1.4 times, or 120% - 140% of the font size.
Android
Android uses lineSpaceMultiplier and lineSpacingExtra for specifying the line-height. lineSpacingMultiplier has a default value of 1.0, or the same size as the font, while lineSpacingExtra uses a default value of 0.0.
If no line height is specified in the code, no extra space will be added between lines of text other than the font’s leading that is built into the font.
How Font Family affects platform
When a font is rendered on a platform, the operating system calculates various metrics such as ascent, descent, x-height, and cap height, which are used to determine the line height of text.
Since different fonts can have different ascent and descent values, this can affect the line-height calculation and the line height rendering of a particular font family.
Additionally, a base amount of leading is built into the font files themselves, and this amount of leading vary from one font to the next.
...
Proposal
Updated

Thanks for providing such extensive information about the issue, @ericsonrd. However, do you think it would be more effective to set the lineHeight as "font size * 1.2" instead? This aligns with the original intent for all platforms and ensures future compatibility, as any changes to fontSize will automatically adjust the lineHeight accordingly.

@aman-atg Indeed!
Glad to be of help, proposal updated below.
...
Proposal
Updated

@Julesssss @jliexpensify @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Julesssss, @jliexpensify, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

@Julesssss @jliexpensify @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Julesssss, @jliexpensify, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

Hi @ericsonrd, the updated solution and explanation is looking good. But we'd try to avoid platform-specific conditionals:

Platform.OS === 'android'

Is there an alternative solution that could instead rely on an Android specific file to change the provided value?

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hi @ericsonrd, the updated solution and explanation is looking good. But we'd try to avoid platform-specific conditionals:

Platform.OS === 'android'

Is there an alternative solution that could instead rely on an Android specific file to change the provided value?

Sure @Julesssss
We can use Platform Specific files so it is selected by the corresponding platform, like lineSpacing.js and lineSpacing.android.js, then pass it to the styles.js file. Updated proposal below.
...
Proposal
Updated

No worries @jliexpensify !

@Julesssss @zanyrenney @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@Julesssss, @zanyrenney, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Thanks @ericsonrd. This is looking good to me.
@0xmiroslav would you mind reviewing this proposal again please?

Having lineHeight on all platforms sounds fine to me, I just wanted to be sure we didn't have a platform-specific conditional.

Having lineHeight on all platforms sounds fine to me, I just wanted to be sure we didn't have a platform-specific conditional.

In light of this, I've updated my proposal in case it's needed to address the issue while using the getValueUsingPixelRatio() function to keep the spacing proportionately according to user settings, as it intends:
// variables.js //

/*
 * Calculate the fontSize, lineHeight and padding when the device font size is changed, In most cases users do not change their device font size so PixelRatio.getFontScale() = 1 and this
 * method always returns the defaultValue (first param). When the device font size increases/decreases, the PixelRatio.getFontScale() value increases/decreases as well.
 * This means that if you have text and its 'fontSize' is 19, the device font size changed to the 5th level on the iOS slider and the actual fontSize is 19 * PixelRatio.getFontScale()
 * = 19 * 1.11 = 21.09. Since we are disallowing font scaling we need to calculate it manually. We calculate it with: PixelRatio.getFontScale() * defaultValue > maxValue ? maxValue :
 * defaultValue * PixelRatio getFontScale() This means that the fontSize is increased/decreased when the device font size changes up to maxValue (second param)
 */

Proposal
Updated

thanks both! @Julesssss let me know which proposal we'd like to accept so that I can get the job offer sent, please!

Hi all, thanks for the detailed proposals. This time we're choosing the first proposal that pointed out the bug and presented a simple solution.

📣 @Milos213 You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@0xmiroslav can you also apply to the job, when i search for you on upwork, you're not appearing. https://www.upwork.com/jobs/~01cec29c2848619f3e

Heading OOO, reapplying the Bug0 label for active management.

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.5-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17779

If no regressions arise, payment will be issued on 2023-05-03. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@0xmiroslav] Determine if we should create a regression test for this bug.
[ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

https://www.upwork.com/jobs/~01cec29c2848619f3e
Can folks please apply to this updated job? I will pay it out this week

ah wait, that job expired. Let me try to use automation magic to create a fresh one.

wow so that did nothing. :|

ill make it manually
😂

https://www.upwork.com/jobs/~012668d85896138131
External issue reporter - @priya-zha - $250
Contributor that fixed the issue - @Milos213 $2000
Contributor+ that helped on the issue and/or PR - @0xmiroslav $2000
Please accept my upwork invite so we can pay/close this!

@michaelhaxhiu submitted the proposal. Thanks

Edited the amounts in my prior comment to be correct.

@Milos213 can you apply for the job too?

All are paid, closing.


fix(refactor): refactor notification settings endpoints

Description

- Notification setting which is a settings route was written in a different file. This was moved into the setting file to enhance readability and modularization
How Has This Been Tested?

Every tests passed
The doc has no changes

Screenshots (if appropriate - Postman, etc):

Expected

Current

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@joboy-dev


Speed up installation

These two changes make a huge difference in some cases. I have an image that I am installing using Toradex Easy Installer on an apalis-im6. Before these changes, the install took about 30 min.  After this change it was about 6 min.

@TheYoctoJester @lluiscampos can you guys give this a quick review?

@drewmoseley: Great to see the speedups here!
With the removal of bz2 compression, the resulting raw image may be quite large (e.g. an 8GB raw vs. 100MB compressed).  This may introduce new bottlenecks in deployment.  Perhaps gz strikes a better balance between decompression speed and compression ratio?

Hi @ericrwx would it help if we compressed the entire mender_tezi.tar file instead of the sdimg payload? It will give you the speed up as well as the reduced size of the tarball.  The downside is if you extract the tarball to a TEZI server then it will be the large file but usually that's a local-area connection so may be a reasonable tradeoff.

@ericrwx see here for my proposal

would it help if we compressed the entire mender_tezi.tar file instead of the sdimg payload? It will give you the speed up as well as the reduced size of the tarball.

IIRC, the TEZI server uses the unpacked tezi.tar files, no?  So compressing mender_tezi.tar doesn't impact unattended flashing speeds.

The downside is if you extract the tarball to a TEZI server then it will be the large file but usually that's a local-area connection so may be a reasonable tradeoff.

Indeed.  For larger flash sizes (e.g. 8GB or more), the sdimg file transfer time may start to dwarf the bz2 decompression time, especially on slower transports like 100 Mbit LAN or USB 2.0.  Therefore, it seems preferable to keep some type of sdimg compression.


Help text on Windows misleading

Describe the bug
On windows the help message for -R option is somewhat confusing
Instead of:
  -R, --pack-root string   Specifies pack root folder. Defaults to CMSIS_PACK_ROOT environment variable (default "C:\\Users\\reikei01\\AppData\\Local\\Arm\\Packs")

It should be:
  -R, --pack-root string   Specifies pack root folder. Defaults to CMSIS_PACK_ROOT environment variable (default "C:\Users\reikei01\AppData\Local\Arm\Packs")

To Reproduce
Steps to reproduce the behavior:

Run the cpackget on Windows 10 with the following command line

cpackget add -h

Note that this issue might exist in other places too.

With the command cpackget index -h (on Windows) there is another misleading output.
Instead of:
Updates the public index in CMSIS_PACK_ROOT/.Web/index.pidx using the file specified by the given url.

it could be
Updates the public index in %CMSIS_PACK_ROOT%/.Web/index.pidx using the file specified by the given url.

I believe the %CMSIS_PACK_ROOT% notation also works on Linux

-R, --pack-root string   Specifies pack root folder. Defaults to CMSIS_PACK_ROOT environment variable (default "C:\\Users\\reikei01\\AppData\\Local\\Arm\\Packs")

The path is being escaped. I'll look into getting the path in this and other places un-escaped as well. The same for the environment variable notation.

Closing this for now, subscribed to the Cobra issue in case any relevant updates or the pending PR is pushed as not to add such additional complexity (the first part is already done ).


ROS2: Fix ROS2 build when clang is the system default compiler

fast-dds disovery-server is not building properly when clang14 is defined as /usr/bin/c++:
Some snapshots took on the machine where the error was reproduced:

Finally we adopted the solution about not building fastdds tools, see more details in the PR:


DLL build

Falcor needs to start pulling in Slang as a binary, rather than source, dependency. That means I need to implement some kind of shared-library build for things.
The API itself should be DLL-ready, so this is mostly a matter of putting together the build.

Implemented in #126.


Dev: Organize tests by namespace

Right now the bb tests task is hard-coded to run tests.clj.
To keep the test suite manageable going forward it would be helpful if we could support the standard clojure.test conventions with a test directory containing a _test.clj file for each namespace.
I think we could work around this temporarily by manually requiring more test namespaces inside this file, but it's not ideal.

Agreed


20231007 UX

new UI for dashboard using tabs
add end date to subscription cycle in billing section
replace address with phone number in BillingContact
add admin invites
replace  pdb authentication modal with banner
fix invites not carrying forward in sign-up form
fix password length validation error message

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8513ee1) 70.64% compared to head (450ed30) 70.95%.
Report is 2 commits behind head on prep-release.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           prep-release     #136      +/-   ##
================================================
+ Coverage         70.64%   70.95%   +0.31%
================================================
  Files               125      127       +2
  Lines              2163     2200      +37
================================================
+ Hits               1528     1561      +33
- Misses              635      639       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[DNM][PrivateTesting] CLI changes to validate ARC POC scenario

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

DNM

Robert wortham
On Sun, Sep 12, 2021, 9:04 PM kai ru @.***> wrote:

@.**** requested changes on this pull request.
Why you need to change some many API versions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cli/pull/19536#pullrequestreview-752257697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVROUE5LBFDHHZ6XODZUBHDUBVL25ANCNFSM5D3JFQDA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Why you need to change some many API versions?

This PR as the title says not to merge and only for for our POC purpose. Since we were not aware of what is the easiest way to get the build/MSI packages I just created the above PR for generation of build.
I will abandons the PR in couple of days.

Google not trusted bc-b5
On Sun, Sep 12, 2021, 9:36 PM Rohit @.***> wrote:

Why you need to change some many API versions?
This PR as the title says not to merge and only for for our POC purpose.
Since we were not aware of what is the easiest way to get the build/MSI
packages I just created the above PR for generation of build.
I will abandons the PR in couple of days.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cli/pull/19536#issuecomment-917788792,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVROUE7FC2THJDECOLXJQEDUBVPSNANCNFSM5D3JFQDA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Done with block api

Finally solved everything rebased my whole branch, hopefully I get no merge conflicts #21

Still has merge conflicts, pls run pytest

Try now

==== short test summary info====
FAILED tests/banks.py::BLACK
FAILED tests/banks.py::test_success_post_invalid_block - NameError: name 'bank' is not defined
FAILED tests/style.py::test_style - assert not 5
FAILED tnb/banks.py::BLACK

Hi @nishp77 , please share your account number so that we know where to send your coins. Every accepted PR gets paid. If you do not yet have an account then please download the account manager here https://thenewboston.com/download and follow these steps https://thenewboston.com/account-manager/create-an-account to create an account.

c81061eb20ee1379ab98b6f5a125ebd0955278e36513eabd8d319967bb61d7e8


Failed to compile.  Module not found: Error: Can't resolve 'redux-form'

After upgrading admin-on rest from 1.23 to 1.3.0, I got the error below everytime I run "npm run build"
Creating an optimized production build... Failed to compile.  Module not found: Error: Can't resolve 'redux-form' in '/Codes/access-ui/src'

Cant reproduce on the aor example and demo. This is likely a problem with your code. Did you use redux-form in your code? In this case, it should be declared in your project dependencies.
To get help about your code using aor, please head to StackOverflow.

I have import { Field } from 'redux-form';, as documented at https://marmelab.com/admin-on-rest/Inputs.html#writing-your-own-input-component

Yep, in this case, you must install redux-form with
npm install redux-form -S


[Server] Auto Register for Connections

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

Still draft?


True Start/Stop For ContinuousScanner

It would be great if there was true start/stop support for ContinuousScanner. Currently setStopped will stop the scanning (and freeze the webcam) but leave the webcam light on and the last image rendered to the scanner element.
Ideally ContinuousScanner would have a true start/stop which would:

[ ] Turn on/off the webcam light (looks like it would require destroying the MediaStreamTrack to force the webcam light off)

[ ] Hide the rendered image instead of leaving it frozen as the last image when disabled, like before render was called

The first one is the more important of the two, as users are uncomfortable with the webcam light staying on after whatever they needed to scan the QR code for is done. If it is part of a larger page, the webcam light may stay on a while, and is quite noticeable.
I'm willing to help with the changes, but I'm not familiar with the code yet so I figured I would create an issue first.

Hi,
dispose() might be what you are looking for. It's supposed to stop the stream / cleanup all other resources. You'll have to recreate the instance to scan again though.

I tested dispose(), and while it makes the rendered stream disappear, the webcam light stays on. If I use a breakpoint at where I want to stop the feed and use scanner.capturer_.stream_.getTracks()[0].stop(); that turns off the webcam light.
In my testing this is on the latest Chrome running on OS X.


Add support for multiple context values

This adds the ability for context values to be an array where merge precedence is in index order. While using multiple values will impact performance (less than adding a new dimension) this implementation ensures that using string values will continue to have the same performance characteristics.

Single
2 Values
3 Values

Base
40,924 ops/sec
invalid
invalid

New
40,247 ops/sec
32,181 ops/sec
29,697 ops/sec

+1
(I would say "update the README too" but there's nothing in there...)


Receiving a "element() may not be used with an empty list in" error

I'm receiving this error message after trying to spawn the multi region cluster, the only difference between the actual example is that I have two nodepools attached to the "google_container_cluster" resource.

module.glb.var.backends: element: element() may not be used with an empty list in:

${element(module.k8s_primary_cluster.instance_groups, 0)}
Once I run again apply it works normally as it is able to get the module.k8s_primary_cluster.instance_groups elements. As for the moment 4 instances are being provisiones.

This might be an upstream terraform issue as it sounds like it may not be waiting for the associated node pools to be created before updating it's instance_group_urls state.
Can you try again with the latest provider and terraform version? If it's still an issue, my suggestion would be to submit and issue to the terraform-provider-google repo.


Passing string to view() function generates warning that the type should be view-string|null

Larastan Version: 2.2.7
--level used: 9
Pull request with failing test: -

Description
PHPStan generates this warning for the given code:
Parameter #1 $view of function view expects view-string|null, string given.

The definition of the Laravel view() function describes the first parameter as string|null. The warning says it should be of type view-string|null. I do not understand why passing a string is not valid here.
Laravel code where the issue was found
    /**
     * @param string $fil
     * @param array<string, mixed> $dta
     * @return View
     */
    private function vw (
        string  $fil,
        array   $dta
    ): View {
        return view(sprintf(Settings::VW_BAS_TPL, $fil), $dta);
    }

    // Definition of Settings::VW_BAS_TPL:
    public const VW_BAS_TPL = 'path/to/templates/%s';

Hello @robopzet! 👋🏻
view-string is our specialty :)
https://github.com/nunomaduro/larastan/blob/master/docs/custom-types.md
Please suppress the error. It does not support generated view names.

Or you have force the type.
        /** @var view-string $viewName */
        $viewName = sprintf(Settings::VW_BAS_TPL, $fil);
        return view($viewName, $dta);

if this is merged you can use view()->exists($viewName) to check it is a view-string:
https://github.com/nunomaduro/larastan/pull/1464

Thanks for the suggestions, and the quick PR!


signald: 0.18.5 -> 0.19.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

All critical data now stored in database

    Avatars, group images, attachments, etc are still stored on the disk for now
    None of these need to be kept around for signald to continue working

New command line flag --migrate-data tells signald to preform all required data migrations and exist

Sounds like manual intervention might be needed on upgrade?

@dasJ, thanks! please consider making yourself a maintainer if you want :)

I don't :eyes:


Tests for DeDup Efixes

I think this consists of 2  steps:

Test Initial DeDup of Efixes (and ECands?)
DeDup results of Genetic Search

We use sets for winners now (#32), so no need to DeDup :D

Then we should test the dedup 😄

We're kind of doing that already. All the slow tests check that only one
result is returned, in stead of the previous version where it allowed for
duplicates. Not really sure how else to test it.
On Fri, 16 Jul 2021 at 18:12, L. Applis @.***> wrote:

Then we should test the dedup 😄
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Tritlo/Endemic/issues/15#issuecomment-881561272, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMXBV4SVV6RRSD7663JDV3TYBK67ANCNFSM47FGFJQA
.

--
Bestu Kveðjur/Best regards, Matthías Páll Gissurarson.


#101 Enable mermaid integration

Remove titles from mermaid charts since they're not supported in mermaid version 8.8.1
Now the charts are rendered as intended. For example:

🚀


Cannot import name state: from celery.events.state import state

I got this when trying to run celerymon:
# /usr/local/bin/celerymon
Traceback (most recent call last):
  File "/usr/local/bin/celerymon", line 9, in <module>
    load_entry_point('celerymon==1.0.3', 'console_scripts', 'celerymon')()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 337, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 2279, in load_entry_point
    return ep.load()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 1989, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/usr/local/lib/python2.7/dist-packages/celerymon/bin/celerymon.py", line 44, in <module>
    from ..service import MonitorService
  File "/usr/local/lib/python2.7/dist-packages/celerymon/service.py", line 3, in <module>
    from .consumer import EventConsumer
  File "/usr/local/lib/python2.7/dist-packages/celerymon/consumer.py", line 4, in <module>
    from celery.events.state import state
ImportError: cannot import name state

Problem is pretty simple:

Celery sources

/usr/local/lib/python2.7/dist-packages/celery/events/state.py:
...
class State(object):
"""Records clusters state."""
...

And celerymon sources:

/usr/local/lib/python2.7/dist-packages/celerymon/consumer.py:
...
from celery.events.state import state
...

Obviously, need to import State instead of state - or vice versa?
Can anybody comment on, confirm such bug and help to solve?
Ubuntu 11.10

# celery --version
/usr/local/lib/python2.7/dist-packages/celery/bin/base.py:149: UserWarning: Cannot load extension 'celerymon.bin.celerymon:MonitorDelegate': ImportError('cannot import name state',)
  'Cannot load extension {0!r}: {1!r}'.format(sym, exc))
3.1.0 (Cipater)

celerymon                 - Real-time monitoring of Celery workers.
  INSTALLED: 1.0.3 (latest)

Still running into this problem, one year later. That's not good.

Same error here too.

Same error here, after update celery and django-celery to:
celery==3.1.17
celery-with-redis==3.0
celerymon==1.0.3
django-celery==3.1.16

Same error here, as well.

Same error

Aparently, there's a pull request that solves this that's been waiting to be merged for quite some time.
https://github.com/celery/celerymon/pull/22

Same here
$ pip freeze | grep celery
celery==3.1.17
celerymon==1.0.3
django-celery==3.1.16

Update import statement from "from celery.events.state import state" to "from celery.events.state import State as state" in the below files.
/usr/local/lib/python2.7/dist-packages/celerymon/handlers/api.py
/usr/local/lib/python2.7/dist-packages/celerymon/consumer.py


fix: Preserve natural text cursor position after paste

Description
This fixes a small regression with the Quill WYSIWYG that causes the text cursor to jump back to the start of the pasted content:

With this fix, the text cursor position is preserved:

Related Issues
Related to: https://github.com/area17/twill/pull/1052
Original issue on Quill repository: https://github.com/quilljs/quill/issues/1374

Merged in 2.x, thanks for the quick fix!


rewrite MultiZarrToZarr to always use xr.concat

@ lsterzinger @rsignell-usgs - this applies what we discussed, to make to xr.concat explicit and pass a separate set of options to it. If this feels OK, I'll update the docstrings then.
example_ensamble() runs fine with this, quite fast (with the "minimal" and "override" arguments)

Great news @martindurant!  Which datasets did you try so far?   (I'll try the others)

Only the noaa-nwm-retro-v2.0-pds 10-file example, which is "example_multi" in the hdf module.

Can confirm that it works on my 1-day (144 files) of GOES netcdf data in Azure Blob storage. It took the processing time down from 55 minutes to 45 minutes, but only 25 of those minutes were CPU times so I'm not sure what's taking up the rest.

That's the time to create a reference set for each file?
On June 25, 2021 5:53:02 PM EDT, Lucas @.***> wrote:

Can confirm that it works on my 1-day (144 files) of GOES netcdf data
in Azure Blob storage. It took the processing time down from 55 minutes
to 45 minutes, but only 25 of those minutes were CPU times so I'm not
sure what's taking up the rest.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/intake/fsspec-reference-maker/pull/33#issuecomment-868851900

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

That's the time it takes to create a single reference with MultiZarrToZarr.translate() from 144 existing reference jsons, I'm using
mzz = MultiZarrToZarr(
    json_list,
#     "zip://jsons/*.json::combined.zip",
    remote_protocol='az',
    remote_options={
       'account_name' : 'goeseuwest'
    },
    xarray_open_kwargs={
        'decode_cf' : False,
        'mask_and_scale' : False,
        'decode_times' : False,
        'use_cftime' : False,
        'decode_coords' : False,
    },
    xarray_concat_args={
        "data_vars": "minimal",
        "coords": "minimal",
        "compat": "override",
        "join": "override",
        "combine_attrs": "override",
        "dim": "t"

    }
)

mzz.translate('combined.json')

I'm thinking this might be something to do with the azure support in fsspec. #31 and intake/filesystem_spec#681 did help my access time, but opening a filesystem from a single reference JSON pointing at 144 netcdf files (combined.json, created using the code above) takes 17min using
fs =  fsspec.filesystem('reference', fo='combined.json',
                      remote_protocol='az', remote_options={'account_name':'goeseuwest'})

Is that expected for a dataset of this size? Each file is ~300 mb.

Just opening the file only needs reading the JSON file. If you run a profile/snakeviz, you'll probably find that rendering the templates is taking a long time - what counts is the number of chunks, not the size of those chunks. Probably you can pass simple_templates=True to significantly improve the time. Also, do you have ujson installed?

To the earlier question of why it takes so long to do the combination - you should turn on logging in adlfs or referenceFileSystem, to see what remote objects are being fetched. With the "minimal" and "override" options, I would have thought there are not too many, but this might be mistaken. The fact that CPU time is only a fraction of the total time suggests that there is significant contribution from latency, waiting for the remote server.
Also note that the opening of the individual filesystems and datasets as input to the combine class could be done in parallel using dask, much as the parallel= option does in xarray.open_mfdataset.
I suggest in any case, that we merge this, so that we can iterate and move on with things such as the docs.

@martindurant and @lsterzinger , yes, let's merge this and keep on testing.

One optimisation I absultely should have mentioned is inline_threshold in SingleHdf5ToZarr. It's hard to know what the best value here is, it's a trade-off between small reads and inflating the output JSON, but I've typically been using 100-500bytes.
Finally, I have the comment in #25 that might be relevant: we make no attempt to join fetches with overlapping/contiguous/near-contiguous ranges. This would matter is several small pieces were being loaded from each of the files.

@martindurant specifying simple_templates=True in fsspec.filesystem() didn't seem to do much.
How do I turn on logging for adlfs? I'm specifying remote_protocol='az' instead of 'abfs', is there a difference between the two? It seems like they're both using adlfs.
I also ran fsspec.filesystem() with a profiler, but I'm 100% confident in my ability to interpret the results. I've attached the profile file here, I was able to visualize it with snakeviz ./profile
profile.zip

"az" and "abfs" are the same

Yeah I am using simple_templates=True. Not idea why it's still calling
jinja2 with it specified
On Mon, Jun 28, 2021 at 12:28 PM Martin Durant @.***>
wrote:

ALL of the time is spent in rendering templates with jinja2. Do use
simple_templates=True, this should avoid jinja entirely, I don't know why
it's not making a difference for you.
https://github.com/intake/filesystem_spec/blob/master/fsspec/implementations/reference.py#L229
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/intake/fsspec-reference-maker/pull/33#issuecomment-869964483,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTH32REAXFIKDXREO5XLKLTVDEO3ANCNFSM47G5MQ6Q
.

@martindurant looks like it's calling jinja2 from _process_references1() where jinja is used to render regardless
https://github.com/intake/filesystem_spec/blob/1e5263a3f38af4ba64a5dbaf0414707ed937826d/fsspec/implementations/reference.py#L286

At least the call stack says it's called from that function, but it seems like it would only go to jinja if there's '{{' in u

Hah! It looks like the following line should simply not be there, it takes time and has no effect. Doubtless this is a bad merge.

Okay yeah that makes sense. Should I open a PR to remove it?

Removing that line brought the time down from ~20 minutes to just 16 seconds, I think you found the culprit!

Yes please - once you've tried it
On June 28, 2021 5:18:50 PM EDT, Lucas @.***> wrote:

Okay yeah that makes sense. Should I open a PR to remove it?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/intake/fsspec-reference-maker/pull/33#issuecomment-870050469

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I can think of an even faster way to do it, if the 16s seems too long - if indeed most of the time is still spent in string substitution.


http2 does not support nttp requests

The web server does not accept HTTP requests when using the settings for EndpointDefaults: Protocols: Http2.
To Reproduce
I use an example for a grpc server: https://github.com/aspnet/AspNetCore.Docs/tree/master/aspnetcore/tutorials/grpc/grpc-start/sample/GrpcGreeter
With the changed host: http://localhost:5000
And add standard healtcheck.
GRPC requests are successful.
However HTTP with an error: ERR_INVALID_HTTP_RESPONSE .
Screenshot: https://s.mail.ru/FfM9/Bp5NCLGxM
ASP.NET Core 3 preview 7
Visual Studio 2019
Windows 10
A similar question was asked in a bug: https://github.com/aspnet/AspNetCore/issues/9847
To simplify the work of services, I do not want to depend on SSL certificates. And therefore it is important to raise the GRPC and healthcheck/metrics/etc on http://
.Net Core 2 works successfully

HTTP/2 is HTTPS only because all user browser agents have refused to do it over HTTP, hence making it a defacto standard. While it's possible to do it with a flag it's only meant for dev work on a Mac, because OSX doesn't support ALPN yet.

As per @blowdart 's comment, HTTP/2 is only supported on HTTPS (as it requires the ALPN extension to HTTPS in order to properly negotiate it). Most clients will refuse to allow "clear-text" HTTP/2 connections.
The .NET Core SDK and Visual Studio include SSL certificates for development time and should automatically install those properly so that they are used without additional work from you.
Closing, as this is by design.


[BEAM-886] Some performance improvements to NewDoFn but moving common code

The NewDoFN are still slower than the Old one but this improves the performance a bit.
R: @robertwb PTAL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Changes Unknown when pulling 532beacc05cdb00d6e4bc58eab0ac168b4d31f99 on sb2nov:BEAM-886-Add-NewDoFn-class-1-1 into ** on apache:python-sdk**.


Page scroll top when builder inside tabs

Package
filament/forms
Package Version
2.12.24
Laravel Version
9.16.0
Livewire Version
2.10.15
PHP Version
8.1
Bug description
I have builder inside tab. When I add some builder block, page scroll top. See video.
https://disk.yandex.ru/i/XCBCKpuEn7dGzw
Steps to reproduce

New laravel installation
New filament installation
Add model, resource and form schema:

  ViewField::make('notifications')->view('view')->columnSpan(2), // Something big for page scroll
  Tabs::make('Heading')
      ->tabs([
          Tabs\Tab::make('Label 1')
              ->schema([
                  Textarea::make('field_1')
              ]),
          Tabs\Tab::make('Label 2')
              ->schema([
                  Builder::make('content')
                      ->blocks([
                          Builder\Block::make('Block 1')
                              ->schema([
                                  Textarea::make('content_1'),
                              ]),
                          Builder\Block::make('Block 2')
                              ->schema([
                                  Textarea::make('content_2'),
                              ]),
                  ])
              ]),

      ])

Relevant log output
No response

Hi.
I was going to open a new issue but it seems related.
I can confirm the bug.

For me, it happens when hitting the ENTER key within the Markdown Editor.
It only happens under Firefox (I'm using 101), it seems to work under Chrome.
It's not tied to Tabs neither Builder, as it does the same with a regular MarkdownEditor::make within public static function form()

@yammycode, could you provide a repository with the minimal amount of code required to reproduce your issue? This allows us to fix the problem much quicker.

Hello, @zepfietje! Now i cant reproduce this bug. May be it was already fixed?

Thanks for getting back to this issue, @yammycode!
It's very well possible that the bug has been fixed in the meantime.
As you're no longer able to reproduce the problem, I will close this issue.
Let us know if you do run into it again!


Device help Avatto TRV TRV07 TS0601 _TZE200_bvrlmajk

Helle and first of all, thank you for your work so far.
I've the following TRV: Avatto TRV TRV07 TS0601 _TZE200_bvrlmajk and using homeassistant ZHA.
Here is the log file as requested in the readme.
home-assistant-1.log
Let me know if you need any more information or help.
PS: I stumbled of this: https://github.com/zigpy/zha-device-handlers/issues/2750 Maybe the additional information can help.
Thank you.

https://github.com/jacekk015/zha_quirks
Quirk name:
ts0601_trv_rtitek2.py
Test it if possible. In case of errors Debug level logs needed from pairing process or specific action.

Hey, a big thank you!
I've added the quirk and it works! It shows as a thermostat, in the dashboard, reacts to changes and can be used in schedulers.

If you need any more additional information, just let me know!
Thx again!


Custom Vertex Shader

Hi!
Is there a way to use a custom vertex shader and maybe also fragment shader later to do some distortion effect on the text?

Oh maybe this will work with Compute Shaders.


Use built in logger instead of debug

[ ] Use built in logger instead of debug

I decide not to use debug because I just want probot to use authentication.


create helper functions to move between domain size

In https://github.com/o1-labs/proof-systems/blob/master/kimchi/src/circuits/domains.rs#L1 we define 4 domains of different sizes: d1, d2, d4, and d8. Each domain having twice as many elements are the previous one.
Evaluations in a specific domain size can quickly be casted in a smaller domain by taking all the i-th elements, where i is the difference of size between the two domains. For example to go from d4 to d1, you'd pick every 4th element, and to go from d8 to d1 you'd pick every 8th element.
This results in a lot of code that looks like this and is hard to parse:
let s = (plnm.domain().size / domain.size) as usize;
let v: Vec<_> = (0..(domain.size())).map(|i| plnm.evals[s * i]).collect();

sometimes it is even interlaced with some scaling:
x + evals.evals[(scale * i + (domain as usize) * shift) % evals.evals.len()]

it would be good to create helper functions to hide the low-level manipulation and make the code around it easier to parse. I can try to find more example of this pattern being used in the codebase, but grepping for these would be a good starting point!

@mimoo
I would like to take this issue!

@mimoo
Atm, I found that the domain move is mostly done in [commitment.rs](https://github.com/o1-labs/proof-systems/blob/master/poly-commitment/src/commitment.rs) and [expr.rs](https://github.com/o1-labs/proof-systems/blob/master/kimchi/src/circuits/expr.rs).
I think these appearances are mainly attributed to that the domain move/conversion is needed for polynomial commitment & aggregation(shrinking the polynomial degree) processes.
It would be best if you can confirm above findings & indicate me more appearances anywhere.

@mimoo
I tried to create a helper function for the issue.
TBH, I think this is a bit of overkill.
The reason is that the most of these patterns are used in kind of shifting elements.
let scale = (domain as usize) / (res_domain.0 as usize);
assert!(scale != 0);
let v: Vec<_> = (0..n)
  .into_par_iter()
  .map(|i| {
     x + evals.evals[(scale * i + (domain as usize) * shift) % evals.evals.len()]
  })
.collect();

Please let me know if I am wrong.

the helper function could just take a scalar for shifting if needed no? The reason why I don't think it's overkill is that it's tedious to parse these lines of code every time AND sometimes people forget to optimize such code with par_iter
I think the locations you found are a good starting point, I can find more after : o

Thanks @mimoo
I will try to create create a helper.

@mimoo
Please check the PR #899 I created for the issue.

@mimoo
TBH, I think this helper function is a bit inappropriate.
The reason is that the helper function creates the extra Vecs & add more loops.
For example:
Here, the code is just creating the final result within one loop and no extra vec.
let scale1 = (d1 as usize) / (res_domain.0 as usize);
assert!(scale1 != 0);
let scale2 = (d2 as usize) / (res_domain.0 as usize);
assert!(scale2 != 0);

let n = res_domain.1.size();
let v: Vec<_> = (0..n)
    .into_par_iter()
    .map(|i| {
        es1.evals[(scale1 * i + (d1 as usize) * s1) % es1.evals.len()]
            + es2.evals[(scale2 * i + (d2 as usize) * s2) % es2.evals.len()]
    })
    .collect();

But, in the PR, the code creates 2 extra vecs & runs 3 loops.
  let v1 = evals_domain_size_cast(
    &es1.evals,
    d1 as usize,
    res_domain.0 as usize,
    res_domain.1.size(),
    s1,
);

let v2 = evals_domain_size_cast(
    &es2.evals,
    d2 as usize,
    res_domain.0 as usize,
    res_domain.1.size(),
    s2,
);

let n = res_domain.1.size();
let v: Vec<_> = (0..n).into_par_iter().map(|i| v1[i] + v2[i]).collect();

I worry if it would not affect the runtime/memory of the proving system, & efficiency of system.(maybe slower?)
Please let me know if I am wrong.

more occurences in that PR: https://github.com/o1-labs/proof-systems/pull/944/files

@duguorong009 I think I missed a number of notifications : o I'm just seeing this now sorry!

proposed this interface: https://github.com/o1-labs/proof-systems/pull/964

proposed this interface: #964

To help get this over the line, I've created PR #965 where I've branched from PR #964  and fully integrated it into the expression framework.  There were quite a few different use cases and scenarios in there, which necessitated some extensions to the proposed interface.
Hope this helps!

@mimoo @jspada
Thanks for the valuable guides & PRs!
I looked into the code & it looks great to me.
Please go for merge if you are confident about the PR #965 .
(I think PR #964 could also be closed thanks to PR #965)
Thanks again! :+1:


Python docs for RolePolicyAttachment do not work

What happened?
https://www.pulumi.com/docs/clouds/aws/guides/iam/#pre-defined-iam-managed-policies
Has a snippet:
role = ...
role_policy_attachment = aws.iam.RolePolicyAttachment('rpa',
    role=role,
    policy_arn=aws.iam.ManagedPolicy.IAMReadOnlyAccess,
)

But the correct snippet is:
role_policy_attachment = aws.iam.RolePolicyAttachment('my-rpa',
    role=role.id,
    policy_arn=aws.iam.ManagedPolicy.IAM_READ_ONLY_ACCESS,
)

Example
See above
Output of pulumi about
N/A
Additional context
N/A
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hey hey @t0yv0 ,
Closing as a duplicate of this issue.


Fixed bootstrap conversion in Reports-Schedules

Fixed fix PR #4467. Corrected CSS classes.
Before:

After:

@epwinchell @skateman please review

LGTM @martinpovolny

@dclarizio Good to go


Question about tagged BAM output

Is the tagged BAM output already corrected (i.e. adds/subtracts reads to account for GC bias based on correction weight matrix created)? Or does this need to be done after the fact?
Thanks!

Perfect! Thank you for the very thorough response! :)


Set resolver with subdomain

Merge after #47
This PR:

Allows the resolver to be set like in here: https://etherscan.io/tx/0xec92a480ecef2ca9a82d7420bd0df6cf4d12fcc3e14ab721025660c96e37d1c0
uses the up to date contract
renames the ref to match the name in the contract

opps, this should go into master. Hang on


Type BuildAndInstallRequest.

Work towards #899.

Depends on #1167 (2f2fadd) and #1168 (2229d24). Please just review 3ebfda2.

Depends on #1167 (2f2fadd) and #1168 (2229d24). Please just review 3ebfda2.

Depends on #1167 (2f2fadd) and #1168 (2229d24). Please just review 3ebfda2.

Depends on #1167 (2f2fadd) and #1168 (2229d24). Please just review 3ebfda2.


how I can install some extension to chrome for the remote version

Hello there, I just finish to configure chromeless in aws and is working fine, now how can I add some extension to chrome?, from where take the chrome bin in the aws lambda?
thanks for advance

Hi @chebyte Headless Chrome does not current support Chrome Extensions. The Proxy makes use of the serverless-chrome project which bundles and includes a chrome binary compiled specifically for the Lambda execution environment during deployment.


Issue with k8s.io/docs/tasks/debug-application-cluster/resource-usage-monitoring/

This is a Bug Report
Problem: Elasticsearch (Kibana/Metricbeat) do monitoring for Kubernetes. Elasticsearch is not referenced in the page.
Proposed Solution: Reference Elasticsearch (Kibana/Metricbeat) as solutions to do monitoring for Kubernetes.
Page to Update:
k8s.io/docs/tasks/debug-application-cluster/resource-usage-monitoring/

/kind feature
/language en

@clementlesne there are lots of ways to monitor a cluster. Do you recommend specifically adding Elasticsearch & Metricbeats? An alternative there could be to list each of the many monitoring options that exist.


Fix Python installs by adding 'import warnings' to setup.py

Currently setup.py crashes because it fails to import the warnings module; this PR fixes this problem.

Thanks, merged.


Does sharding-proxy support hint?

Question
How can I implement force master for select when using sharding-proxy?
Does sharding-proxy support SQL hint like:
/*master*/ select * from user

Not yet, will implement by #1240


Whenever someone press the submit button in contact page , an email should be sent to my mail

Fixed #IssueNumber
Check (put an 'x' between the square brackets) everything which applies:

[ ] I have added the issue number for which this pull request is created.

@nitin-pandita, please let me know about this update.

required mail is<EMAIL_ADDRESS>

do you mean IF someone tries to log in or sign in  in the contact you should receive an email
what information you wanna get in the email?

do you mean IF someone tries to log in or sign in in the contact you should receive an email what information you wanna get in the email?

yes if someone login or sign up, I should get the mail about the username and password

ok .I can do that,  i Know how to do it with JS
but, In order for you to receive emails you should sign in to emailJS and link your account Gmail to it .

Contributor

@naim16031988 I have signed in with my mail<EMAIL_ADDRESS>

I dont know how to do it with just e-mail adresse . The way i wanna do it is :
First, you need to create an account with EmailJS
Then creat a new service and link your gmail account .
Create a template with your service and configure the email form you want to receive .
Once you have your service id template id. We can set the service email . I done it in This way . If you have better ideas let me know

Let me know if I can help with this

Let me know if I can help with this

Need a good design and if you like we can work on it to


elaborate on how to run on HPC

demonstrate ClusterManagers.jl

important also to emphasise subtleties:
https://discourse.julialang.org/t/struggling-to-run-distributed-i-o-operations-on-slurm-cluster/84075

being worked on in #36


Discussion: How memlab supports NodeJS memory leak detection

Hi memlab devs, thanks for the great tool. I'm excited to try to integrate it into my current NodeJS app tests. I'm wondering what's current status or future road map is on supporting NodeJS memory leak detection.
Currently, most test cases and demos are running in browsers detecting front-end side memory leaks. Would you plan to give more support on NodeJS?

@foreseaz For node.js leak detection, you can take Node.js heap snapshots with takeNodeFullHeap, then use the following command to find memory leaks:
memlab find-leaks --baseline <FILE> --target <FILE> --final <FILE> --leak-filter <filter definition>

The built-in leak detector in MemLab is mainly for front-end memory leaks, so you need to defined a leak filter (API and example).
The most naive leak filter would be returning true for every objects allocated by target by never gets released, you can start from there and refine your self-defined leak detector for your node.js application.

@JacksonGL thanks for documenting this. Few questions, can you share an example of a filter definition syntax I can try? Do I pass it the filter definition file? Can you share the syntax. Also when taking takeNodeFullHeap do I write that to a file and then use the cli to compare?

@agaripian

can you share an example of a filter definition syntax I can try?

Here are a few leak filter examples.

Do I pass it the filter definition file?

Yes

Also when taking takeNodeFullHeap do I write that to a file and then use the cli to compare?

takeNodeFullHeap will return an IHeapSnapshot object. You can use dumpNodeHeapSnapshot to write the heap snapshot to disk. The native API from node.js will also do the job.

Also what is baseline, target, and final? Is that just 3 separate heapdumps?

Yes, they are 3 separate heap snapshots, for more information please check out:
https://facebook.github.io/memlab/docs/how-memlab-works
baseline, target, and final corresponds to snapshot of A, B, and A' in the following animation:

Leak filter documentation: https://facebook.github.io/memlab/docs/api/interfaces/core_src.ILeakFilter/

@JacksonGL Thanks for the detailed reply.
I have a question about how to debug memory leak problem in nodejs.
When should I take the three snapshots of my leaked nodejs application?
In my case, the memory occupation keeps rising in my application.
It is hard to choose the 'baseline' and the 'final' status to take snapshots.
Unlike in the browser, there is no go-to-url and I can't reuse the thread and the heap.
Should I somehow stop my application without killing my nodejs main thread and take a final snapshot?
Would you kindly write a example?

You can import and call this API to take heap snapshot from node.js:
https://facebook.github.io/memlab/docs/api/modules/heap_analysis_src/#takenodefullheap
In your case, just take three heap snapshots when the memory footprint is rising. For example, one heap snapshot when heap usage is 50MB (as baseline), another at 80MB (as target), and third heap snapshot at 100MB (as final).
If you are using the memlab find-leaks, something worth mentioning is that memlab's default leak detector is mainly written for detecting front-end JS leaks, so you may want to use memlab find-leaks --trace-object-size-above 1000000 to identify retained object with size over 1MB or large size.
Alternatively you can write your own leak detector for node.js:
https://facebook.github.io/memlab/docs/api/interfaces/core_src.IScenario/#-optional-leakfilter-leakfiltercallback
There are a few other heap anslysis commands that may be useful (check out by running memlab analyze -h)


Pass variable into html2canvas with Angular4

I'm using angular4, how can I pass a variable in to html2canvas for use with jsPDF. Here as  a test I am just trying to console.log the variable called this.problems.length both inside and outside html2canvas like this,
generatePDF(){
      console.log("outside: this.problem.length = " + this.problems.length);// works

    html2canvas(document.getElementById('graph')).then(function(canvas) {
      console.log("inside: this.problem.length = " + this.problems.length);// not working!!!

      var doc = new jsPDF();
      doc.text(50,100,'page 1');
      var img = canvas.toDataURL("image/png");
      doc.addImage(img, 'JPEG', 100, 100);
      doc.addPage();
      doc.text(50,100,'page 2')
      doc.save('test.pdf');
    });
    // doc.save('test.pdf');//fails to add image to pdf
  }

Also asked on stackoverflow

Ok I know how to get around this now using,
var self = this;
generatePDF(){
      console.log("outside: this.problem.length = " + this.problems.length);// works

    html2canvas(document.getElementById('graph')).then(function(canvas) {
      var self = this;
      console.log("inside: self.problem.length = " + self.problems.length);// working!

      var doc = new jsPDF();
      doc.text(50,100,'page 1');
      var img = canvas.toDataURL("image/png");
      doc.addImage(img, 'JPEG', 100, 100);
      doc.addPage();
      doc.text(50,100,'page 2')
      doc.save('test.pdf');
    });
    // doc.save('test.pdf');//fails to add image to pdf
  }