multiple instances of mocked objects

Hi,
When I was trying out ts-mockito I noticed that the instance() method does not create different instances of the mocked Class.
For example I have a class User with a field id. When creating two mocked objects:
let mockedUser = mock(User);
let user1 = instance(mockedUser);
let user2 = instance(mockedUser);
if(user1.id === user2.id)
  return true;
else return false;

This code yields true. Am I using the instance method in the wrong way?

instance() is a kind of getter for the instance object corresponding with the provided mock object. If you would like to get two mocks of the same class, just call mock() twice.

Hi @bjverhoe, as @michalstocki mentioned instance() method gets instance from specific mock. Because all behaviors are defined by mock, you should get one instance per one mock.
let mockedUser1 = mock(User);
let mockedUser2 = mock(User); // create second mock
let user1 = instance(mockedUser1);
let user2 = instance(mockedUser2);
if(user1.id === user2.id)
  return true;
else
  return false;

Please reopen issue if something is still wrong.

Hi @NagRock, thanks for the info!


pkg_resources.DistributionNotFound: The 'tensorflow' distribution was not found and is required by the application

Environment:

Python version  3.6.5
Spark version ,2.3.1
TensorFlow version  2.1.0
TensorFlowOnSpark version 2.2.4
Cluster version Standalone

Describe the bug:
I have installed python3.6.5, using  pip command to install the tensorflow-cpu= 2.1.0, but when I run the example(TensorFlowOnSpark/examples/mnist/estimator/), an error occurred: " pkg_resources. Distributions 'tensorflow' distribution was not found and is required by the application". I can't find a solution on the Internet. What should I ?
File "/usr/local/python3/lib/python3.6/site-packages/pkg_resources/init.py", line 466, in get_distribution
dist = get_provider(dist)
File "/usr/local/python3/lib/python3.6/site-packages/pkg_resources/init.py", line 342, in get_provider
return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]
File "/usr/local/python3/lib/python3.6/site-packages/pkg_resources/init.py", line 886, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/local/python3/lib/python3.6/site-packages/pkg_resources/init.py", line 772, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'tensorflow' distribution was not found and is required by the application
but i can import tensorflow successfully

Can you try using pip install tensorflow==2.1.0?

The problem was resolved and TensorFlow needed to be installed on each node, I only installed it on the primary node

Can you try using pip install tensorflow==2.1.0?

Can you try using pip install tensorflow==2.1.0?
I forgot to install TensorFlow on the other nodes.thank you


Adding a static label

We'd like to add these agents to every cloud sql instance in our gcp project. It is working well on one instance, but the "instance" label that is surfaced is just the IP address of the deployed pg-agent pod. It would be nicer and cleaner if we could add our own label that we could reference that would be the name of the sql instance the pg-agent is connected to. It seems like it would be fairly simple to add the ability in environment variables or otherwise to add a few static labels if needed/wanted.

From version 1.0.9 you can add multiple --label arguments, e.g. --label="key1:value1" --label="key2:value2" or set the STATIC_LABELS environment variable with a newline-separated list of labels.


[Backport 2.4] Fixes CVE-2022-42920 by forcing bcel version to resovle to 6.6

Backport of https://github.com/opensearch-project/security/pull/2275 to 2.4

Codecov Report

Merging #2303 (70125b5) into 2.4 (8031157) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.4    #2303      +/-   ##
============================================
- Coverage     61.08%   60.99%   -0.10%
+ Complexity     3251     3244       -7
============================================
  Files           258      258
  Lines         18125    18124       -1
  Branches       3231     3231
============================================
- Hits          11072    11054      -18
- Misses         5483     5495      +12
- Partials       1570     1575       +5

Impacted Files
Coverage Δ

...ecurity/configuration/StaticResourceException.java
0.00% <0.00%> (-25.00%)
:arrow_down:

...urity/ssl/transport/SecuritySSLNettyTransport.java
62.36% <0.00%> (-4.31%)
:arrow_down:

...nsearch/security/dlic/rest/api/AuditApiAction.java
63.82% <0.00%> (-4.26%)
:arrow_down:

...security/auditlog/sink/ExternalOpenSearchSink.java
59.25% <0.00%> (-2.47%)
:arrow_down:

...earch/security/ssl/util/SSLConnectionTestUtil.java
93.18% <0.00%> (-2.28%)
:arrow_down:

.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java
57.46% <0.00%> (-1.50%)
:arrow_down:

...iance/ComplianceIndexingOperationListenerImpl.java
61.76% <0.00%> (-1.48%)
:arrow_down:

...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java
84.78% <0.00%> (-0.33%)
:arrow_down:

...a/org/opensearch/security/tools/SecurityAdmin.java
35.75% <0.00%> (-0.25%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Rework for new website endpoints

Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another Pull Request opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Feature change (non-breaking change which changes behaviour of an existing functionality)
[x] Improvement (non-breaking change which improves functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Refactor (non-breaking performance or readability improvements)

Description

In the last few days there are new changes in website that has full broken the addon,
the new endpoints caused to force also the use of JSONGraph data to http responses making the use of falcor_server request header useless
last day they seem to have enabled the old endpoints again, but this back-and-forth situation is not clear,
to be aligned with the website now we support to read data as JSONGraph format by using also falcor_server header,
this is a quick adaptation in the future the handling of JSONGraph data via an ad-hoc class could be evaluated
Fix #1425
Fix #1428
In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

Interresting, the issue is fixed by this pull request on my coreELEC but every video freezes after around two minutes of playing... Have anoyone the same issue?

Hey @72ka, my apologies as this most likely wont be super helpful. But to answer your question, I personally haven't had any of my video's freeze @ ~2min. I too pulled down this pr to test out @CastagnaIT's fix for the login/user selection issue. After pulling the PR down, clearing my cache and a reboot, I could now login, select a user in the account and play some videos.
RE:Checking for freezing video's
I was only clicking play and watching the video's for a couple seconds to test. Knowing about your issue I am now running a longer set of tests, and so far all 6 video's have played successfully for at least 10 minutes before I've stopped them.
I also tried to load coreELEC on a machine to test with that instead of OSMC. However, I borked the install and gave up for now  as I need a nap. Sorry.
 Thank you so much for the quick fix to this issue. Not to mention the continous work you do on this repo. If there is every anything I can do, please let me know!  Cheers!

Just in case this helps anyone.
Right when the video's freeze for me at the 2 min mark, the following errors pop up in kodi's log file (~/.kodi/temp/kodi.log).
I am not sure if it's 100% related as I am way too sleepy atm. But looked like it could be important.
//Logs @ Freeze

2022-10-01 08:29:12.321 T:1063    ERROR : Window Translator: Can't find window True
2022-10-01 08:30:10.509 T:5119    ERROR : Skipped 1 duplicate messages..
2022-10-01 08:30:10.509 T:5119    ERROR : AddOnLog: inputstream.adaptive: DecodeVideo: kNoKey for key<PHONE_NUMBER>542EAA0000000000000000
2022-10-01 08:30:12.133 T:1138     INFO : Skipped 237 duplicate messages..
2022-10-01 08:30:12.133 T:1138     INFO : [plugin.video.netflix (0)] EVENT [keepAlive] - Executing request
2022-10-01 08:30:12.178 T:5119    ERROR : AddOnLog: inputstream.adaptive: DecodeVideo: kNoKey for key<PHONE_NUMBER>542EAA0000000000000000
2022-10-01 08:30:22.188 T:5119    ERROR : Skipped 239 duplicate messages..
2022-10-01 08:30:22.187 T:5119    ERROR : AddOnLog: inputstream.adaptive: DecodeVideo: kNoKey for key<PHONE_NUMBER>542EAA0000000000000000

Any chance to have this bug fix applied to the Leia branch?

Sorry guys i want keep the PR clean so i deleted your comments, all your answers are in Issue #1425
Users are allowed to comment on a PR only for development purpose
all other use cases please use threads in "Issues" or "Discussions" pages


NEW: Added support for config condition if PHP extension is loaded

This pull request implements the new config exclusionary rule for if the given PHP extension(s) are loaded, fixing #9096

Tests added :)


Question: How to properly use VarBuilder?

Hello everybody,
I am working on implementing LoRA and want to use the VarBuilder system. However, when I try to get a tensor with get_with_hints, I get a CannotFindTensor Err. To create the Tensor, I do:
vb.pp("a").get_with_hints(
...lora specific shape...
"weight",
...lora specific hints...
)

However, this fails with the CannotFindTensor error. How can I create the Tensor, or perhaps am I using the API incorrectly?
Thanks!
Eric

This depends on whether you're trying to run inference for a model where you can create the var builder from for example a safetensor file or whether you want to train a model in which case you want to create a var builder based on a varmap. In this last case, tensors are generated on the flight based on the hints that you provide, you can find some example using this in the mnist training.

I am trying to add tensors to a VarBuilder loaded from a safetensors file. Could this be the issue? If so, how can I modify the VarBuilder?

It looks like the VarBuilder is created with VarBuilder::from_tensors. How can I add tensors, or do I need to make another VarBuilder?

If your goal is to train the tensors loaded from the file, you should still use a varmap based var builder but you can use load on the var-map to get the values from the safetensors file (example here).
If you want to have both trainable variables, and tensors that come from a safetensor file, you can either use two var builders or write a custom var builder backend based on the backend trait).

Ok, thank you. In my case using LoRA with inference with the model when it is loaded from a safetensors does not make sense anyway. This also reinforces the immutability of non-trainable models.


Switch to the new event-generator

/kind feature
/cc @fntlnz
/cc @leodido
/cc @kris-nova

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: cacd06b2cfa32c62e6d18dcdadc1787788dfff75

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

falco/OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


move zlib package

https://abaplint.app/stats/abapGit/abapGit/package_coupling?folder=/src/zlib
zlib is only used by the git package, moving zlib to a subfolder

I'll redo this change, closing


fix(s3): Add control over nb of objects retrieved per batch (maxKeys)

This is the same PR as #364 for release 1.10 branch.

Thanks. This is for a minio like implementation - not for S3 directly. We get a 400 when max-keys is too big.


Images preprocessing

In the data_convention.md file, the preprocess script says that it generates the needed cameras.npz file.
The code loads an initial cameras.npz file, but how should we build this cameras.npz file to run the preprocess code on new images ?

The code generates the needed cameras.npz file which contains both the camera parameters and the normalization matrices. However,  it needs the camera matrices as an input which are stored in the input cameras.npz file in this example.
In more details, the input cameras.npz file contains the camera matrices, where P_i = cameras['world_mat_%d' % i][:3, :] is a 3x4 matrix that projects points from the 3D world coordinates to the 2D coordinates of image i (intrinsics and extrinsics, i.e. P=K[R | t] )
The output cameras.npz contains also a normalization matrix for changing the coordinates system such that the captured object is located inside the unit sphere.

How do you get the input cameras.npz (world_mat and scale_mat), not the output cameras_new.npz?


Support for multilines queries or external resources

Hi,
if I need to create a query a bit more complex it's difficult to keep it into a single line.
Dart support multi line String with """ but it's not working at the moment for the query.
It would be nice to have the possibility to provide the query as an external resource like a text file and use the query name as reference. Not sure is feasible.
Thanks in advance. :)

I'm investigating the issue right now. The next release will also contain a fix for multiline strings of query annotations.
Could you make the following a bit more precise?

... It would be nice to have the possibility to provide the query as an external resource like a text file...

Hi @vitusortner,
I think when the query became a bit more complex have multiline could be not enough.
The mix between code and sql will make the dao a bit messy.
I was thinking to have a separared text file for each query and in the dao the reference.
Here an example:
File for query : /queries/students_count_by_room.txt
Select roomId, roomName, count(*) as studentsCount
from tblRooms R
Inner Join tblStudents S on (S.RoomId=R.RoomId)

dao :
@Query(getQuery('/queries/students_count_by_room.txt'))
Future<List> getStudentsCountByRoom();
It's like a fake stored procedure. :)
What do you think?

Closing issue for now because multiline queries are supported now and it's not planned to implement the functionality for supporting external queries.


Invalid buffer id

When I execute :set background = light #or dark before opening NvimTree (e.g. no valid NvimTree buffers exists), I get the following error:
E5108: Error executing lua ...ack/plugins/opt/nvim-tree.lua/lua/nvim-tree/renderer.lua:344: Invalid buffer id: 2

Please report this in the NvimTree repository instead.

Oh, sorry, I sent it here by accident.


Site currently printing "No data available" responses

No idea if this project is still under active development but i was trying to look at some node stats and got this.

https://crawler.ethereum.org/v1/dashboard responds with
{"clients":null,"languages":null,"operatingSystems":null,"versions":null}

I faced the same issue locally when the DBs were not linked correctly.

@taxmeifyoucan  can you see if the DB is missing?

There is a bug because of which new crawled data won't make it to the database and when API throws away old nodes after 24h, db is wiped


Moving forward from beta blog post: clarify 9 month window

The 9 month window can be more explicitly translated to "three
releases", which may not always nine month (like for v1.19.0). This
should avoid confusion when users try to find out which release should
be targeted for the graduation to stable.
/assign @sftim
/cc @justaugustus

/sig architecture

Fixup for PR #21274

👋 @onlydole Are you around to review this blog update? Thanks!

/lgtm
/approve


File name inserted into paste input

Pasting in the following three lines causes the third line to insert the first tab completed file name (for me, it's .berkshelf):
function Get-Foo {
$defaultDisplayPropertySet = New-Object System.Management.Automation.PSPropertySet('DefaultDisplayPropertySet',[string[]]$defaultProperties)
$PSStandardMembers = [System.Management.Automation.PSMemberInfo[]]@($defaultDisplayPropertySet)
Please note, that there are one tab characters preceding the second and third lines.

I have same problem here, but ctrl+V only paste the first line of my clipboard ...? (I'm using powershell within ConEmu)

Closing in favor of #579 which covers all of the known issues with right-click paste.


Fix refresh cancelation

Changes drag release logic so that an armed refresh is only canceled if the user has scrolled back up beyond the point where the refresh indicator was armed. (Fixes https://github.com/flutter/flutter/issues/138848.)
This is the minimal change I found could be made to restore something like the behavior that I would expect.
This may still need a bit of work, because it only masks the second issue I mentioned, that releasing a drag can cause the scroll position to be animated back up from the release point. There is actually a bug about that: https://github.com/flutter/flutter/issues/6052. I would like to see that bug fixed too. This PR doesn't address that, but makes it harder to hit that issue.
@Piinks this is a recreation of #139015 (since I couldn't figure out some issue with a git detached branch, so I fixed the PR and I'm re-submitting it). This version includes one line that was somehow accidentally dropped from the original PR. This will hopefully fix the test failures.
However, I don't have a clue how to write a test for a Flutter UI widget. I'll try to figure that out, but also I don't have a lot of time to work on this. I would appreciate at least some user testing to verify that the new behavior is much more intuitive than the old behavior.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
[?] All existing and new tests are passing.

@Piinks I went over the test failures, and there's no usable information in the 5 failures, just Command exited with exit code 1 but expected zero exit code.
I suspect this is some failure in CI, and not a failure in the code change I made (which is extremely minimal)...

@Piinks thanks for providing more links to documentation.
As I mentioned, I looked at the bug dashboard, but the only info I could find was that the code had exited with error code 1.
I finally realized I have to drill down into the raw stdout output to see what actually failed. So now I can see the test that failed (it looks like it was just one test). How to find the source of failures like this is not described in either of the documentation links you sent -- maybe they should be updated.
As I mentioned in the previous version of the PR that I filed, I already followed the contributing guide (and the linked "Setting up the Framework development environment" page) to the letter, in trying to set up my Flutter environment, but even after following all the steps, I get almost 500k build errors in VS Code, when opening code at the root of the flutter directory. I have no idea what is causing this, but I assume VS Code is popular among the Flutter team, so I'm surprised this doesn't open properly out of the box.
The contributing guide also has no information at all about how to write or run tests (especially individual tests, which is what I need to be able to do here). I tried manually running the test's main function, but I get a lot of errors about packages not being available (even after I ran flutter update-packages).
I don't really know how to proceed at this point... I need to be able to run the single failing test, so that I can figure out why it's failing.

Hi @lukehutch unfortunately I am not able to debug your local environment. You should be able to run the tests from flutter/packages/flutter with just the flutter test command, or flutter test <path-to-test> for a specific test file.

@Piinks OK, I fixed the broken test, and I added two new tests to test the new behavior. PTAL -- thanks.

My patch makes the Flutter behavior match the native behavior on Android, albeit that the native behavior also shows the indicator as armed when it is armed, allowing a further draggable distance in the armed state (which Flutter does not yet support -- #139018).
Native behavior, which you can see by dragging down from the top of the messages list in Gmail for Android:

While dragging down to some distance X, the refresh indicator has a circular arrow of dark gray color ("unarmed state").
At distance X, the refresh indicator turns white ("armed state").
You can then drag the indicator a further distance Y downwards, in armed state.
Releasing in armed state causes the refresh.
If you drag down some distance X + b, where b >= 0, then drag back upwards by a distance of at least b + 1, then the refresh indicator goes back to unarmed state, and refreshing it cancels the refresh request.

Current Flutter behavior, before my PR:

You have to drag a minimum distance X from the top of the screen to arm the refresh indicator.
There is no indication that the refresh indicator is armed. (#139018)
Dragging any distance Y > 0 beyond that point does not cause the refresh indicator to be dragged any further down the screen.
No matter how much further (Y > 0) you drag down beyond the armed point, dragging even one pixel upwards before releasing cancels the refresh operation. (#138848)
Often there is a "bounceback" effect when you release the touch point that causes a slight upwards scroll, which means that it is annoyingly hard to actually cause the refresh to happen. (I describe this in #138848, although I never actually got to the bottom of what causes this -- it is a separate bug.

I did verify that the bounceback even happens with a perfectly still mouse while using the emulator, so it's not a touchpad driver artifact as the touchpoint centroid moves during a touch-up event.

What my PR does:

Dragging a distance X from the top arms the refresh indicator. (There is no indication of the armed state, because Flutter does not yet support it.)
When dragging a distance Y > 0 beyond the armed point, the refresh indicator does not move further down the screen (this is different from Android native behavior, because Flutter doesn't yet animate the armed state beyond the arm point, but it's a reasonable halfway step).
If you drag back any distance b <= Y before releasing, the refresh happens. If you drag back any distance b > Y before releasing, the refresh is canceled.

What my PR accomplishes:

Refresh can be reliably initiated, even with the slight bounceback effect (which should be separately fixed), because you can drag as far past the armed point as you want, creating a buffer region that is bigger than the bounceback distance.
Refresh can be reliably canceled, because you can just drag back upwards until you see the refresh indicator moving back upwards again before releasing, since at least this shows you that the indicator is unarmed (even if there is currently no armed indicator).

Thanks very much for the detailed analysis and explanation!
I think the change to the existing test is fine then.

The Flutter refresh indicator really does need an overhaul to make it work like the Android native indicator

I agree! If there is not an open issue for any of the bullet points you listed above, would you mind filing an issue for each one? I see some are already covered in the issues you linked.
I think all this PR needs then is a rebase, and it looks like there is a merge conflict to  resolve. After that it should be ready to land. 💯

Rebased and merged.
I will update the relevant issues, and may open one more "umbrella" issue to do a complete audit of the refresh indicator behavior.
Thanks!

@Piinks is there anything remaining that needs to be addressed relative to this comment?

Nope! We confirmed it, albeit not in that thread. Thanks for checking!

Thanks!


Fixed playground draggable block while scrolled

Last pull request did not include the fix for the actual on drop event, only for the placement of the target line. This adjusts the drop event to account for scrolling

I guess this PR is meant to supersede the #5839 ? So 5839 is closable?

Still not able to reproduce this issue in the current Playground

Just checked the deployments for the bug and it seems fixed!
Tell me if there is anything else I need to do before this can be pulled to main


Did the repository owner just change?

I swear that the owner was @neelance yesterday.... so what's going on with the change?

Yes, I transferred the repo to this new org and @tonyghita volunteered to become a maintainer (thanks!), since I am busy working on the WebAssembly support for the Go compiler.

Awesome, thank you very much for your work @neelance and thanks for taking over @tonyghita !


Namedspaces lookup is case sensitive

200 https://api.prod-preview.openshift.io/api/namedspaces/aslak/Home
404 https://api.prod-preview.openshift.io/api/namedspaces/aslak/home

Closing it! it was addressed by #1279. Feel free to re-open it otherwise


Tablename required with fromTable option

When trying to generate api, it gives message like
tablename required with fromTable option

In dev-master for laravel5.1

just fixed it.


Not all the spans rendered in the ui?

Given the following trace where I see a lot of ServiceA (there are 10), I only see two of them rendered in the UI which seems very weird, the UI in fact seems to keep space (time) to render them but does not render anything.
[{"traceId":"bd8283279c35f5e1","name":"get","id":"54f3362c23fd3423","parentId":"bd8283279c35f5e1","timestamp":1460956558786749,"duration":19353,"annotations":[{"timestamp":1460956558786761,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956558806099,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"b9a14937a2cfa97a","parentId":"bd8283279c35f5e1","timestamp":1460956558820804,"duration":21045,"annotations":[{"timestamp":1460956558820813,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956558841846,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"e2218aab4a57245a","parentId":"bd8283279c35f5e1","timestamp":1460956558892976,"duration":208907,"annotations":[{"timestamp":1460956558893007,"value":"sr","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559101880,"value":"ss","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"4c932d3d10182aa9","parentId":"e2218aab4a57245a","timestamp":1460956558897019,"duration":135474,"annotations":[{"timestamp":1460956558897037,"value":"cs","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559032491,"value":"cr","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[{"key":"http.status","value":"200","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"http.uri","value":"/v1/privileges/show","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"sa","value":"1","endpoint":{"serviceName":"SERVICEB","ipv4":"<IP_ADDRESS>","port":443}}],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"9c85a02c27fe70fd","parentId":"4c932d3d10182aa9","timestamp":1460956558899306,"duration":129897,"annotations":[{"timestamp":1460956558899312,"value":"cs","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559029196,"value":"cr","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[{"key":"http.status","value":"200","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"http.uri","value":"/v1/privileges/show","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"sa","value":"1","endpoint":{"serviceName":"SERVICEB","ipv4":"<IP_ADDRESS>","port":443}}],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"08a8444fc69d5ef3","parentId":"e2218aab4a57245a","timestamp":1460956559035581,"duration":57335,"annotations":[{"timestamp":1460956559035590,"value":"cs","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559092913,"value":"cr","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[{"key":"http.status","value":"200","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"http.uri","value":"/v1/study_environment_assignments","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"sa","value":"1","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":443}}],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"d785650bad29dd26","parentId":"08a8444fc69d5ef3","timestamp":1460956559036652,"duration":55860,"annotations":[{"timestamp":1460956559036658,"value":"cs","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559073798,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559092506,"value":"cr","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559093673,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[{"key":"http.status","value":"200","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"http.uri","value":"/v1/study_environment_assignments","endpoint":{"serviceName":"UI_APP","ipv4":"<IP_ADDRESS>","port":3000}},{"key":"sa","value":"1","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":443}}],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"da98a54de4632943","parentId":"bd8283279c35f5e1","timestamp":1460956559126139,"duration":18402,"annotations":[{"timestamp":1460956559126150,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559144538,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"7e9f40c9e40fb32c","parentId":"bd8283279c35f5e1","timestamp":1460956559158500,"duration":20238,"annotations":[{"timestamp":1460956559158507,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559178735,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"ca5621cc4f030223","parentId":"bd8283279c35f5e1","timestamp":1460956559196350,"duration":18378,"annotations":[{"timestamp":1460956559196358,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559214726,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"546c80de2ee3b593","parentId":"bd8283279c35f5e1","timestamp":1460956559228957,"duration":20401,"annotations":[{"timestamp":1460956559228964,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559249353,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"7d18c775164aea6e","parentId":"bd8283279c35f5e1","timestamp":1460956559272001,"duration":33826,"annotations":[{"timestamp":1460956559272011,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559305823,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false},{"traceId":"bd8283279c35f5e1","name":"get","id":"cc96b698a733d884","parentId":"bd8283279c35f5e1","timestamp":1460956559319752,"duration":20110,"annotations":[{"timestamp":1460956559319759,"value":"sr","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}},{"timestamp":1460956559339859,"value":"ss","endpoint":{"serviceName":"SERVICEA","ipv4":"<IP_ADDRESS>","port":3000}}],"binaryAnnotations":[],"debug":false}]

Thanks for the sample trace. Not that it matters, but is this the "raw"
output? Also I assume this is not zipkin-java (and using mysql storage type)

I got this output from the API, mysql backend

Did you click the "Expand All" button? (We should enable it by default)

Yes, clicked that, clicked each individually, clicked all clickable links 💃

this is a bug when there's no queryName parameter. Ex. the raw trace by id, like this: http://localhost:9411/traces/bd8283279c35f5e1, when you click expand all, the console shows this..

ok I think this does it.. https://github.com/openzipkin/zipkin/pull/1094

Yes! The new update solves my issue, thanks!

I have a similar case here, Hi, I'm not sure if this is a bug or a mis-configuration, I have the following json coming from some spring cloud services and the rendering seems to be missing some spans, the service named main-integration-unit is always not visible, even though it's present in the JSON, can you help me on understanding why or if it's a bug, should we re-open this case?


Site Settings

Is there a way to extend the site setting entity?  Currently only Name and Description appear to be editable?
i.e add Logo?
manager/sitetree/edit/

Yes! If you go to Settings > Sites in the manager and click on your site you'll see that you can add regions to it just like with any other page type. Save the site and then go back to editing it and you'll see that you can edit the different regions you created.
Regards


Implement automatic cleanup of .godot/ folder items (.import/ in 3.x)

Godot version:
Godot 3.0.2.stable.official
Issue description:
I really like Godot 3's new resource workflow with the .import files and .import folder.
I like that all the source files and settings can be kept in source control.
However, I don't like how Godot never deletes the .stex/.sample/.md5 files for deleted resources in the .import folder. It just feels like the .import folder is accumulating trash more and more until eventually I can't stand it anymore and decide to delete the whole folder and wait for a full re-import. It just bugs me and is something that kind of needs to be managed, when it's supposed to be something you can ignore.
Sometimes I'm also not sure if it affects the editor's knowledge of whether the actual file still exists. (Eg. it is using the .import cache but actually there is no resource file anymore) making me unsure if the image I see in the editor still actually exists. (But that is kind of a separate issue ... because currently even if I delete the resource file and the related .import folder files, the image in the editor is still there. I would expect it to disappear since the editor should know that the file doesn't exist anymore ... it even deleted the .import import settings file for it already! EDIT added as #17734)
It looks like the editor knows how to cleanup the .import import settings files that are in the res folder when the source resource is deleted. I would suggest also cleaning up the .stex/.sample/.md5 files in the .import folder at the same time.
Steps to reproduce:

Delete or rename a resource file in the res folder using an external file explorer.
Activate Godot
Go back to external file explorer to see that the .import file next to the resource file has been deleted (this is good)
Check inside the .import folder to see that the files related to that resource are still in there. (why not delete them too?)

Using the internal file manager actually results in the same thing when renaming. When deleting it does remove the imported resource but leaves the .md5 file.

pretty sure this is a regression. godot used to delete the old files in .import

This has been happening to me as well and after moving some music I spent this weekend bashing my head on the wall trying to figure out why it was trying to load music and saying that the resource didn't exist :)

I just moved up to Godot 3.1 and am doing some reorganisation (moving and renaming folders and scenes).  I just emptied my .import folder in Windows Explorer, and when I clicked back in the Godot editor it did a scan and repopulated the .imports folder with all the assets it currently knows about.
I agree the editor should do this cleanup automatically and keep .imports in sync, but at least there is this workaround in the meantime.

This is should be easy to implement. My simple logic:

Just make a String List called To_Be_Deleted_List of all filenames present in .import folder.
Compare each of the names to [deps] section of all the *.import files.
Remove from To_Be_Deleted_List, if match is found.
Only names of Artifacts that can be purged/cleaned will left be in To_Be_Deleted_List.
Is this bad approach to solve this issue?
I would implement it myself, but I don't know much about file system yet.

I think the way assets handle imports is changing, so this may become a non issue in the near future.

Wasn't it changed 3.0? So another big change for 4.0?

There's no big change to the import system planned for 4.0. (There are changes to texture flags, but AFAIK textures will still be imported to StreamTextures in the .import/ folder.)

Ah cool.  Thanks for clarifying.

The following Python script seems to work for clearing up .import/:
#!/usr/bin/python3

import re
from glob import iglob
import json
import os

used = set()
unused = set()

re_dest_files = re.compile(r'^dest_files=(\[.*\])$')

# for all *.import files in project:
for path in iglob("**/*.import", recursive=True):
    with open(path, 'r') as f:
        # find the dest_files line in the [deps] section
        deps = False
        found = False
        for line in f:
            if not deps:
                deps = (line == '[deps]\n')
                continue
            else:
                if line[0] == '[':
                    # new section encountered, somehow there's no dest_files
                    break

                # extract the imported file path(s)
                match = re_dest_files.match(line)
                if match:
                    paths_str = match.group(1)
                    paths = json.loads(paths_str)
                    md5s = set()
                    for i, p in enumerate(paths):
                        # remove 'res://'
                        paths[i] = p[6:]
                        md5s.add(os.path.splitext(paths[i])[0] + '.md5')

                    used |= set(paths)
                    used |= md5s
                    found = True
                    break

        if not found:
            print(f"warning: {path}: no deps.dest_files")

# find every file in .import/ that isn't referenced in a *.import file
for path in iglob('.import/*'):
    if path not in used:
        unused.add(path)

# do this alphabetically for nicer terminal output
unused = list(unused)
unused.sort()
n = 0

for path in unused:
    print(path)
    os.remove(path)
    n += 1

print('---')
print(f'removed {n} files from .import/')

I have the same problem and it is really weird - I deleted the .import folder and everything reimported and seems to work fine.
The big thing is: The project directory is now 31.5 mb large and before deleting the .import folder it was 127 mb large which is quite a bit on my small SSD. Are there plans to change that system?

The big thing is: The project directory is now 31.5 mb large and before deleting the .import folder it was 127 mb large which is quite a bit on my small SSD. Are there plans to change that system?

Imported textures will always take a fair amount of space because VRAM compression is designed to have a fixed compression factor. Using a size-optimized compression algorithm on top would slow down compression and decompression noticeably, which makes it a bad tradeoff in most scenarios.

I tried VRAM compression out once but also got back to lossless (the game is 2D) although I see it a lot in my 3D game (the assets in the project alone are only around 1 mb and the project folder is now 42.8 mb). Just out of curiosity: Why doesn't this have impact on the exported files?
Honestly, I think both solutions would be great/a big improvement :D Especially for people who don't know how to access hidden folders etc.

Just out of curiosity: Why doesn't this have impact on the exported files?

The exported project contains only the imported resources, not the source assets.

thank you very much!

Closing in favor of https://github.com/godotengine/godot-proposals/issues/3582, as feature proposals are now tracked on the Godot proposals repository.

https://github.com/godotengine/godot/issues/17733#issuecomment-786671208

Thanks @snoopdouglas for the code.
Also:
If you are on Windows, use this version. File path on Windows has the backslash problem, which can lead to file deletion by mistake. Also it solved an exception on non-utf-8 systems.
#!/usr/bin/python3

import re
from glob import iglob
import json
import os

used = set()
unused = set()

re_dest_files = re.compile(r'^dest_files=(\[.*\])$')

# for all *.import files in project:
for path in iglob("**/*.import", recursive=True):
    with open(path, 'r', encoding='UTF-8') as f:
        # find the dest_files line in the [deps] section
        deps = False
        found = False
        for line in f:
            if not deps:
                deps = (line == '[deps]\n')
                continue
            else:
                if line[0] == '[':
                    # new section encountered, somehow there's no dest_files
                    break

                # extract the imported file path(s)
                match = re_dest_files.match(line)
                if match:
                    paths_str = match.group(1)
                    paths = json.loads(paths_str)
                    md5s = set()
                    for i, p in enumerate(paths):
                        # remove 'res://'
                        paths[i] = p[6:]
                        md5s.add(os.path.splitext(paths[i])[0] + '.md5')

                    used |= set(paths)
                    used |= md5s
                    found = True
                    break

        if not found:
            print(f"warning: {path}: no deps.dest_files")

# find every file in .import/ that isn't referenced in a *.import file
for path in iglob('.import/*'):
    path = path.replace('\\', '/')
    if path not in used:
        unused.add(path)

# do this alphabetically for nicer terminal output
unused = list(unused)
unused.sort()
n = 0

for path in unused:
    print(path)
    # os.remove(path)
    n += 1

print('---')
print(f'removed {n} files from .import/')

I noticed that not only do the .import files not delete when deleting from the FileSystem tab in godot, but it seems lots to keep lots of iterations around for different versions of the same texture.  This might actually be because I was trying to import textures that were too large and caused the engine to become unstable, but I had a lot of junk accumulated in the .import folder.  Would be really nice to clean this up automatically when a texture changes or is deleted!

Hi everyone.
I think this is a very important topic : I agree that these *.import files should be removed once you delete its original file.
Until now, I was using this extension : https://godotengine.org/asset-library/asset/813
I think this extension shouldn't exist and that the file shouldn't be kept at all as I said.
Now, this extension is not available for 4.x, so I don't have so many options rather than checking myself for the duplicates of old files, and delete them, but it's a bit tedious. Maybe I'll try the script you mentioned above.
Anyway, if at anypoint a dev could make something for this, it could be great !

Here is a bash shell script which reports orphaned .import files in the specified $PROJECT_DIR.
#!/bin/bash

# report orphaned .import files; make sure to assign PROJECT_DIR
PROJECT_DIR=project
while IFS= read -r import_file; do
    filename="${import_file%.import}"
    if [ ! -f "$filename" ]; then
        echo "Found orphaned import file: $import_file"
    fi
done < <(find "$PROJECT_DIR" -type f -name "*.import")


[Issue #666] operator suggestion when adding a new link

This is the first part for Issue #666

show all the available operators to connect when creating a new link

Future: Need to update the validateOperatorConnection and validateOperatorMagnet functions to make the suggestion more precise.

Hello,
I have looked over the codes and the feature works perfectly. I have introduced a few changes in my commit for this PR.

From our discussion previously in weekly meeting, we have concluded that the user should not be able to connect multiple links into single port of an operator. During validating connection, I have added a new predicate to check this. For any port that already have a link, the suggestion will not appear.
When the suggestion shown, I have added a css so that the suggested operators will have colored border as well to facilitate better user experience.

@zuozhiw please give this PR a look.


Bug report e-mail address does not work

This page tells us we can report Git issues to<EMAIL_ADDRESS>It says that

Bug reports for git should be sent to this mailing list.
You do not need to subscribe: you will be Cc'd in replies.

But when I try to send a mail to that address, it bounces:

Undeliverable: .gitignore file does not work when saved as UTF-8 + BOM
<EMAIL_ADDRESS>Reply|
To:
<EMAIL_ADDRESS>Fri 1/22/2016 10:11 PM
To send this message again, click here.
This is an automatically generated Delivery Status Notification.
Delivery to the following recipients failed.
<EMAIL_ADDRESS>

So.... without further ado, here is the issue I am trying to report:
.gitignore file does not work when saved as UTF-8 + BOM #663

This mailing list's address is correct and it works...

I believe the address is correct, but it seems the spam filters may be set a bit too strict. I only sent two mails to this address (trying to report a bug) and they both bounced.
Are there other ways to report this bug that do not involve me changing my e-mail provider or bugging :) you with it?

If you'd like, I can forward your mail to the list.

not related with this git website, and it seems to have been addressed by @jnavila
close @peff ?

Yes, I don't think this is the right forum (for interactive help with mailing list issues, the IRC channel is probably a better venue). There's also some advice on the vger site. The thing that often trips people up is the HTML prohibition (which we also warn about on https://git-scm.com/community). The bounce snippets above don't have enough detail to know whether that's the case.


Built in Tokenizer

Describe the feature or improvement you're requesting
It would be great if you or someone else implemented a tokenizer for the different models or one that allowed you to pass in a parameter like 'cl100k_base'.
Means we don't need to balance different libraries that specialise in specific tokenisers.
Additional context
No response

I couldn't locate the cURL reference. Can you please reopen the issue if you find it?


How to keep track of unread conversation count?

I used this query to get the unread conversation count
Query query = Query.builder(Conversation.class)
                    .predicate(new Predicate(Conversation.Property.HAS_UNREAD_MESSAGES, Predicate.Operator.EQUAL_TO, true))
                    .build();

Long unreadCount = layerClient.executeQueryForCount(query);

Seems to work.  Question is how do I keep trace of the count change?
The iOS version has the query controller concept:
- (nullable LYRQueryController *)queryControllerWithQuery:(nonnull LYRQuery *)query error:(NSError * _Nullable * _Nullable)error;

I found the LayerChangeEventListener and implemented
public void onChangeEvent(LayerChangeEvent event) {
        boolean conversationUpdated = false;
        List<LayerChange> changes = event.getChanges();
        for (LayerChange change : changes) {
            if(change.getObjectType() == LayerObject.Type.CONVERSATION){

                conversationUpdated = true;
                break;
            }
        }
        if(conversationUpdated){
            updateUnreadConversationCount();
        }

The problem is this event is fired too often! updateUnreadConversationCount is called a lot than needed.
Any suggestions on how to do this efficiently?

Hi @kkgelu ,
For questions on Layer Android SDK, please contact Layer Support via https://support.layer.com/hc/en-us.
In this particular case, you can filter the changes using the LayerChange.Type and AttributeName.
Unread count will be affected by the following

Type ==  Insert and LayerObject == Conversation
Type ==  Delete and LayerObject == Conversation
Type == Update and LayerObject == Conversation and getAttributeName==totalUnreadMessageCount`

Hope this helps. Please contact support if you have any further questions using the instructions above.
Thanks
Amar


xchm: 1.23 -> 1.30

Motivation for this change

2019-02-24: xCHM has moved to GitHub
xCHM 1.26: wxWidgets 3.0 or newer is now required

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

$ nix path-info -Sh /nix/store/ygfp60ljxslzxr5sjwarzw5h9k2vhh58-xchm-1.23
/nix/store/ygfp60ljxslzxr5sjwarzw5h9k2vhh58-xchm-1.23	 298.9M
$ nix path-info -Sh /nix/store/ylkfmgvkii8f945z34pip5a59y6n4har-xchm-1.30/
/nix/store/ylkfmgvkii8f945z34pip5a59y6n4har-xchm-1.30	 166.8M

[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Built and tested locally :+1:

Backported as f13471dedd81ee7862783e64335f23523436a963.


D3D should not try to build when SDL is not found

Also should not try if GLEW is not found.

D3D should not require GLEW... if it does, then I've totally misunderstood the world of computer graphics...


Audio Conferencing can be added to Business Basic

Business Basic is not listed on the page as a qualifying plan for Audio Conferencing. However, you can add the Audio Conferencing plan to a Business Basic plan.
Please add Business Basic to the list of prereq plans.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59426612-8da4-be3e-f0c8-8c23e9178d7d
Version Independent ID: bd2d7426-06d6-5c18-7776-a50fc05c9ce9
Content: Configure Audio Conferencing settings - Microsoft Teams - Microsoft Teams
Content Source: Teams/deploy-audio-conferencing-teams-landing-page.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@jokruege Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@jokruege thank you for reaching out and helping improve MS Docs. Please could you be a bit more specific. I see Microsoft 365 Standard Business is reflecting there or am I misunderstanding something?

@lindspea Yes, M365 Business Standard is listed. However, the plan M365 Business Basic is not listed and Audio Conferencing can be added to that type of license.
https://docs.microsoft.com/en-us/microsoftteams/deploy-audio-conferencing-teams-landing-page#audio-conferencing-prerequisites

@LolaJacobsen please could you help confirm?

We recently updated our licensing content. The current authoritative resource is this article:
https://docs.microsoft.com/microsoftteams/teams-add-on-licensing/microsoft-teams-add-on-licensing
We'll be updating all of our documentation to point to this new article.


npm audit reports "Arbitrary Code Execution" vulnerability

This package depends on azure-storage which in turn depends on a highly vulnerable version of underscore (Arbitrary Code Execution): https://www.npmjs.com/advisories/1674
azure-storage has already been patched and will hopefully be released in the coming days: https://github.com/Azure/azure-storage-node/pull/677
I don't have high hopes this module will ever get a new release though… 😞 Are you still active, @Sliverb?

azure-storage 2.10.4 was released yesterday.  Upgrade the version of the dependency to 2.10.4, run npm audit and the warnings go away.


Modbus controller incorrectly set a read coil event as MB_EVENT_COILS_WR (IDFGH-951)

Into linked code line, and the next one (426), the event is set in a wrong way since in this case the variable eMode is equal to MB_REG_READ.
https://github.com/espressif/esp-idf/blob/c064e008424d6f87cc78ca93ed572d4b2ba346d9/components/freemodbus/modbus_controller/mbcontroller.c#L425
The proposed solution is to change, in both lines, the value MB_EVENT_COILS_WR in MB_EVENT_COILS_RD.

Hi domoticalabs-dev,
Thank you for reporting this. The change will be applied into current release and merged as soon as possible.
--
Alex

Is there any plan to implement a TCP slave too on the future? It seems there is not in the library, so we've tried to implement a simple example of it, still we don't have enough resources to make it completely working and we don't have any plan of doing it in the future.
Could you be interested in the work (very minimal) we've done so far? We have no problem in sharing it, still it's far from being ready. If you needs something to start with, we can share it with no problems.

Hi domoticalabs-dev,
Yes, there are plans to implement Modbus TCP slave and master. The work in progress common interface for master and slave is already implemented and can be found here: https://www.esp32.com/viewtopic.php?f=13&t=9527&hilit=master+modbus
This code will be merged soon. I already implemented the work in progress version of Modbus TCP slave and TCP master based on this interface code but complete implementation is postponed.
However it would be interesting for me to see your code too. Thank you.

domoticalabs-dev,
I am not sure if I can request your code and use it due to some regulations. Also I have already implemented code. Thank you for your proposal.

As you prefer, if you change your mind just ask me. I can also open a pull request if you need it and if it can help you.
I'll leave the issue open so you can close it when you merge it in the next release.


Adopt MarkdownRenderer UI component

Depends on https://github.com/containers/podman-desktop/issues/6900
See also https://github.com/containers/podman-desktop/issues/5757

Closing as https://github.com/containers/podman-desktop/issues/6900 is closed


Fix main function and error-handling

Sorry the indentation change in my previous commit broke the main function.

Yup, no problem.


resources on mega://enc2 links

Hey, thanks for your tool. I have one question: do you know of or have any resources about how mega://enc2 are created? I want to port this to node.js, but I'm not completely following all of the code. Any resource would be helpful. Thank you!

mega://enc2 are created (obviously) with the inverse of the operation performed for the decryption.
I'll provide a Node.js POC / example in the following hours / days

I have tried to build this repository using Crystal 0.23 and failing with some error pointing to llvm, my final intent was also creating a NodeJS version after i had checked that it does work to decrypt mega.//enc2 & mega://fenc2 links, so that POC will be greatly appreciated @denysvitali Thanks!

I'm so sorry, I still haven't got time to look into that 😞
@dimitryow what is your specific error?
It works well here, I'm using Arch Linux with Crystal 0.23.1 (2017-09-10) LLVM 5.0.0

You mention that you're "not completely following all of the code". Is there something in particular you're stuck on?

Hi @denysvitali! This is what i'm getting:
$ crystal build --release src/megadecrypter.cr
crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102:  9659 Aborted                 (core dumped) "$INSTALL_DIR/embedded/bin/crystal" "$@"

$ uname -a
Linux ubuntu 4.4.0-47-generic #68-Ubuntu SMP Wed Oct 26 19:39:52 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

That's Ubuntu 16.04, and my first time using crystal, but i did followed their installation instructions.

Can you provide the Crystal release?
crystal -v

After further checking, it seems like it is a common issue. As a workaround for now you can try with crystal build --release --no-debug src/megadecrypter.cr as mentioned in the issue

I've created a PR with a Dockerfile, so anyone can run without installing crystal ;)
Link: https://github.com/denysvitali/megadecrypter/pull/4


API Generator: Support position field

generate code to correctly update position fields in create, update and delete.

position missing for create: add at the end
position set for create: update all later entities
position set for update: move others
entity deleted: remove gap
position in input is always optional, min(1) and int
position in input to high: set current max value

Missing

support for position-grouping

We also need a changeset for this.

grouping will be needed I guess in most cases

It's definitely needed for each scope. Maybe we should even do this by default?

grouping will be needed I guess in most cases

It's definitely needed for each scope. Maybe we should even do this by default?

Added support for position-groups, and if scope-prop exists it's always added.

@Ben-Ho the generated service was removed in #2238 since it wasn't needed any longer. You'll have to re-add the generated service when necessary. You could even consider creating a dedicated <name>PositionService

Should this support fields named other than position?
If yes: this should be supported everywhere
If no: a error should be thrown if the decorator is used on another field. And I'm unsure if the decorator is the best api for this, as it looks like I can use it on any field.

Should this support fields named other than position?
If yes: this should be supported everywhere
If no: a error should be thrown if the decorator is used on another field. And I'm unsure if the decorator is the best api for this, as it looks like I can use it on any field.

currently it's supported to name it anything you like, all relevant places should already check for decorator instead of the field name. I used the decorator approach because I wanted the position-group feature to not pollute the Entity-Crud-Decorator config.
the freedom of naming it anything could probably be a problem for the admin-generator.

@nsams why do you want me to remove this decorator? I know it's not necessary for correct input-type but don't you think it's good to "describe" how to content of this field looks like? Probably because the name "position" is self-explanatory.

because it is unused code. I thought it must be an oversight.

currently it's supported to name it anything you like, all relevant places should already check for decorator instead of the field name.

not eg. here: https://github.com/vivid-planet/comet/pull/2255/files#diff-e801c6222494414cd200139c942575ca42d7e25e3dbd1250b5017d3369e671fbR512

I used the decorator approach because I wanted the position-group feature to not pollute the Entity-Crud-Decorator config.

I understand, but maybe that still would be the perfered way?

the freedom of naming it anything could probably be a problem for the admin-generator.

true!

I used the decorator approach because I wanted the position-group feature to not pollute the Entity-Crud-Decorator config.

I understand, but maybe that still would be the preferred way?

@johnnyomair @nsams what do you prefer? I don't think there are so many ways someone could name this field. probably pos, position, order. And there could be an exotic case where different ordering is required, but that should probably always be solved with a different data-structure...

We already have some other magic fields (e.g., id and slug). The question is if we want to move away from this approach or not.

I don't think there are so many ways someone could want to name this field. probably pos, position, order.

This should always be named position. No exceptions please.

The always existing (even if there is no position-field) but optional groupByFields-config in entity-crud-decorator is the only reason

imho we should go that way.
@CrudGenerator({
    positionGroupByFields: ["parent_id"]
})
//or
@CrudGenerator({
    position: { groupByFields: ["parent_id"] }
})

@nsams @johnnyomair refactored to work with field name instead of decorator

The grouping feature is neither in Demo nor in the unit tests. We should add this IMO

I looked into it again but product-category would need some field like scope to allow using the grouping. I hope it's enough to spread the word how to use it. (it's not really that complicated...)


Postgres NOW() + interval generating NOW()

Bug Description
When using the query! macro to insert NOW() + '1 hour'::interval then inserted value is just NOW().
Minimal Reproduction
Create a table with a timestamp column.
sqlx::query!("INSERT INTO test_col (expire) VALUES(NOW() + '1 hour'::interval)")
.execute(&db).await?;

The inserted value will be equal to NOW().
Info

SQLx version: 0.7
SQLx features enabled: "runtime-tokio-rustls", "postgres", "macros", "uuid"
Database server and version: Postgres 16
Operating system: Ubuntu 22.04
rustc --version: 1.76.0-nightly

This is not a SQLx bug per se.
By default, we set the timezone of the connection to UTC to ensure consistent behavior, regardless of the timezone setting on the server.
This means NOW() is going to return timestamps in UTC, and then inserting to a timestamp column (instead of a timestamptz column) simply erases the timezone and uses the date/time naively.
I'm guessing your server timezone is UTC+1. That would mean NOW() + '1 hour'::interval would look like it evaluated to NOW().
For this reason, we recommend always using timestamptz instead of timestamp because it avoids ambiguity with timezones. The storage cost is the same, as it stores the timestamp as UTC internally.


tls: fix typo, use clientCertSearchPath for clientcert.pem

clientcert.pem is located in /etc/pki/libvirt/clientcert.pem as per
https://www.libvirt.org/tlscerts.html
Fixes
level=error msg="Error: failed to dial libvirt: can't locate resource 'clientcert.pem' in [/home/kni/.pki/libvirt /etc/pki/libvirt/private]: file does not exist"

Thanks for the patch @rbbratta


Document everything and build with sphinx

Docstrings are needed for pretty much everything, and we want to make sure the docs work. There will also need to be some prose documenting the different design choices, how to extend the code, and some tutorials.

This work is almost complete for a first pass. We still need to:

[ ] Update the installation instructions, and add some comments on how to install for a dev build
[ ] Give the docs a quick once over to make sure there is nothing super outdated in the example codes.

A running log of issues I've found in the documentation as of 20 Nov 2023:

relentless.optimize.RelativeEntropy gradient equation is broken
relentless.model.TriclinicBox the links to HOOMD & LAMMPS convention are broken


Wrap function in parenthesis to properly mark as escaping

There appears to be a compiler bug that applies the escaping to the first argument (which is also a function) and not the entire function.

Current coverage is 100% (diff: 100%)

Merging #151 into master will not change coverage

@@           master   #151   diff @@
====================================
  Files           8      8
  Lines         190    190
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          190    190
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update fd77f36...4c70fa8

🎉  Thanks!


How can I run different models on same nlu server ?

if I prepared restaurant search model and ran it on the NLU server
and if i had one more model like hospital_serach and how can I run that model in the NLU server which is up and running restaurant_search model ?
just changing the port number make sense ?

You can either spin up multiple instances or you can server both models with one instance of Rasa NLU. To do so, make sure to properly set the project directory of the server and put both models in there. When using the /parse endpoint specify the models & projects as shown in the docs http://nlu.rasa.ai/http.html#post-parse-no-emulation.


Create a Docker nitro example

Separate docker example from I-poc and create a linear-regression example that is easy to run using docker

Is this still relevant?


Set alpha parameter for regularization of RidgeRegression

Is your feature request related to a problem?
It's not possible to set the alpha parameter for regularization of ridge regression.
Desired solution

Add a new parameter alpha: float to the initializer of safeds.ml.regression.RidgeRegression
Raise a value error if alpha < 0
Warn if alpha == 0 -> Users should use LinearRegression instead
Pass it along to alpha of the wrapped scikit-learn model in the fit method

Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)

Use warnings.warn to warn.
Use with pytest.warns to test that the warning is created.

:tada: This issue has been resolved in version 0.12.0 :tada:
The release is available on:

v0.12.0
GitHub release

Your semantic-release bot :package::rocket:


Bump Alluxio version to 2.4.0

Alluxio 2.4 supports Java11, see https://github.com/Alluxio/alluxio/issues/9856

@apc999 would you want to take a look?

CI failed -- https://github.com/prestosql/presto/issues/4948

Thanks!


Add a mechanism to get the version on the CLI

Currently you can't determine the version of parlay from within the CLI. It would be useful to add a --version or version command.

/assign


Problems running with javafx:run in a project with cross-platform fat JAR settings

Hi!
I'm working on a project where building a cross-platform JAR is required. This is our pom.xml: https://github.com/lielfr/lilach/blob/master/lilach-client/pom.xml
Whenever trying to run it using mvn javafx:run, maven refuses to run it on my Mac. However, when commenting out the linux javafx-graphics dependency it runs properly. Is there any way to get around that? Is it a bug?
Thanks

I got the same issue.
 The jar is not running OS different from my macOS if i dont include os specific modules, but when i do the plugin wong start using mvn javafx:run

Since JavaFX requires platform-specific libs in order to run your app in different OSs you need to build the fat JAR for each target OS.
The problem here is the classes overlapping if you add manually many OS-specific modules.
So, my advice is: build each os-specific fat JAR from your macOS adding manually OS-specific javafx maven dependency instead generic one.
<!-- use this -->
<dependency>
    <groupId>org.openjfx</groupId>
    <artifactId>javafx-graphics-mac</artifactId>
    <version>14</version>
</dependency>

<!-- instead this -->
<dependency>
    <groupId>org.openjfx</groupId>
    <artifactId>javafx-graphics</artifactId>
    <version>14</version>
</dependency>

Thanks for you answer,
That is what i'm trying to do - Having generic libraries in my dependencies, but when using maven-assembly to package the jar, all the os specific dependencies needs to be available on the classpath. How can i do that ?

Here are my solution to generate a cross-platform JavaFX app JAR: cross-platform-app-fx.
IMPORTANT!
You cannot run the example using this plugin because it use the MODULE_PATH and the maven project is only compatible with CLASS_PATH (more details in repository's README).

You cannot run the example using this plugin because it use the MODULE_PATH and the maven project is only compatible with CLASS_PATH (more details in repository's README).

I am wrong about the above. The plugin is able to detect if our app is modular and run it in the right way. But javafx:run fail on windows for this app (I developed it in this OS) because it cannot load the DLLs and I don't know why. In linux run without problems.
I am working on this. Wait for updates.

I have opened an issue (#72) about of the impossibility to run the application using javafx:run and added a PR (#73) that fixes it.
See the issue #72 for more details on the underlying problem.

Great work.  What you did in cross-platform-app-fx with creating a launch class making the application loading the classpath modules is a great hack. I also found this on the internet, but it is good to have a repo illustrating this.
Good with the PR. Any idea when to expect this release?
So for now I am able to run the fat jar generated with maven assembly from any OS - if I include all dependencies as you did in the above repo, but javafx:run does not work, and so does the debug not work. Or am i doing something wrong?

Great work. What you did in cross-platform-app-fx with creating a launch class making the application loading the classpath modules is a great hack. I also found this on the internet, but it is good to have a repo illustrating this.

Thanks a lot

Good with the PR. Any idea when to expect this release?

It has to be approved first and I am not part of the company, so I don't know.

but javafx:run does not work

PR #73 fix that, but we have to wait for it to be included in the next release.

and so does the debug not work. Or am i doing something wrong?

For me debug work fine in IntelliJ IDEA. What are you doing?

Well,
I was just using the plugin with run some options i googled:

javafx:run@debug.
But from now on i do as you illustrate in your screen dump - simply just run the main class.
This actually fixes all my problems (thank you x 1000). But i am not utilizing the javafx-maven-plugin then?

This actually fixes all my problems (thank you x 1000). But i am not utilizing the javafx-maven-plugin then?

My answer is yes. Remember you really don't need the plugin in order to run the app from an IDE, it is useful to do it from terminal.
I've never used debugging from Maven, and I've never really needed it.

Yea it is usefull for the terminal, and a few of my co-workers swear to Visual Studio. So need to take care.

Ok, I will take a look

I've came upon the same problem as well. Is this a JavaFX issue or is this a plugin issue?


Add preflight command

Adds the preflight command using the fork at https://github.com/croomes/troubleshoot/tree/remote-host-collector
Run as: bin/kubectl-storageos preflight preflight/preflight.yaml --collector-image croomes/troubleshoot:latest

@mhmxs thanks for the review - I agree with all your comments.  The code was copied from the troubleshoot repo with only the required changes, but there's no reason not to improve it here.


Update fs2-core to 3.0.2

Updates co.fs2:fs2-core from 3.0.1 to 3.0.2.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #228 (bbf93ee) into master (87310ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   43.72%   43.72%
=======================================
  Files          25       25
  Lines         263      263
  Branches        6        6
=======================================
  Hits          115      115
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87310ce...bbf93ee. Read the comment docs.

Superseded by #246.


Contributions: look up default_branch in GitHub API

The repos/ endpoint has default_branch information. Look it up and use it.
At the moment, HowIs hard-codes it to "master".
https://developer.github.com/v3/repos/#get
    "default_branch": "master",

I poked at this real quick. Not sure how to get the github_api gem that HowIs uses to return information from that endpoint.


Implement unit test cases for firmware protocols

This PR:
Includes unit test cases for:

firmware/protocols

rebased on top of develop, fixed build errors after https://github.com/pez-globo/pufferfish-software/commit/917ac6302ce011d83b881628b6083f6b4d406e88

I'm seeing that CMakeLists has been updated to add code coverage tooling. This would explain why the Github Actions tests which involve doing CMake builds (scan-build and catch2) are failing on the "Run CMake" step - for example:
CMake Error at cmake/CodeCoverage.cmake:204 (message):
  lcov not found! Aborting...

As a fix, can you try editing https://github.com/pez-globo/pufferfish-software/blob/develop/.github/workflows/firmware.yml to add lcov to the sudo apt-get install commands in lines 94 (for the scan-build job), 141 (for the catch2-clang-tidy job), and 165 (for the catch2 job) and doing a commit+push to see if the Github Actions checks will pass afterwards?

I'm seeing that CMakeLists has been updated to add code coverage tooling. This would explain why the Github Actions tests which involve doing CMake builds (scan-build and catch2) are failing on the "Run CMake" step - for example:
CMake Error at cmake/CodeCoverage.cmake:204 (message):
  lcov not found! Aborting...

As a fix, can you try editing https://github.com/pez-globo/pufferfish-software/blob/develop/.github/workflows/firmware.yml to add lcov to the sudo apt-get install commands in lines 94 (for the scan-build job), 141 (for the catch2-clang-tidy job), and 165 (for the catch2 job) and doing a commit+push to see if the Github Actions checks will pass afterwards?

Yep lcov is required, will try that ! Thanks

yes the suggested changes worked @ethanjli , will fix format and catch2-clang-tidy as well

Added changes for issue #279
https://github.com/pez-globo/pufferfish-software/pull/269/commits/3891af43ed8e90940a3a213c37dd0f3d534ccdea
do we still need to use this function https://github.com/pez-globo/pufferfish-software/blob/develop/firmware/ventilator-controller-stm32/Core/Inc/Pufferfish/Application/States.tpp#L23 for backend.tpp ?
if yes then in terms of test scenarios, we wont be able to test different message types for StateSynchroniser::output, as we would have to then implement that in states::input
maybe https://github.com/pez-globo/pufferfish-software/pull/269/commits/3891af43ed8e90940a3a213c37dd0f3d534ccdea#diff-758fdfe036be60a3797af2c480e7dee6ca6a9263f42fc8186670345f53826e73R69 return invalid_type in the switch block or rewrite the input method to incorprate it.

Closing this PR (these tests are merged in parts separately in other PR's) :
Tests for CRCElements: #281
handling data input for states: #289
handling of delimiter in chunks: #290
Tests for Datagrams: #285
Tests for chunks: #297
Tests for Messages: #298
Tests for states: #306


Set the correct SpanContext in continue_trace

This commit makes incoming distributed tracing work and finishes implementing continue_trace

Updates the span processor to consider remote parents as root spans
Adds a simpler start_span to POTelScope for now that is a simplified version of the original that just creates a POTelSpan
continue_trace now adds a fake remote NonRecordingSpan with the correct trace_id, parent_span_id and parent_sampled fields taken from the PropagationContext
fix the trace_id and span_id properties on POTelSpan

working distributed trace
tested with

svelte frontend with sentry
flask + sqlalchemy backend


feat: add text error to reducer

Codecov Report

Merging #52 (a8f27f2) into main (84da936) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   91.81%   91.81%
=======================================
  Files          13       13
  Lines         464      464
=======================================
  Hits          426      426
  Misses         29       29
  Partials        9        9

Files Changed
Coverage Δ

goval.go
97.70% <100.00%> (ø)


[Enhancement] BeEqual("") -> BeEmpty()

Is your feature request related to a problem? Please describe.
Instead of BeEqual("") it would be better to use BeEmpty(). It supports strings and makes the intent and failure message clearer.
Additional context
https://github.com/kubernetes/kubernetes/pull/120403#pullrequestreview-1623915358

I've not checked whether this is already supported - at least the version in the latest golangci-lint doesn't seem to have it.

Hi @pohly, thanks for this idea. I think many developers will find go  Equal("") better readable than BeEmpty().
It like in a regular go condition, that many developers prefer
if s == ""
Over
if len(s) == 0

Yes, let's do that.

This is too contentious, let's not do this.


[BUG] GetJsonObject sees a double quote in a single quoted string as invalid

Describe the bug
With input data of {'a':'A"'}, and a json path of $, Spark will output {"a":"A\""}, but we output null, meaning it was an error and we could not parse it. I'm not sure if it has something to do with it being a single double quote and quote matching is a problem or what because ['a','b','"C"'], will fail because of https://github.com/NVIDIA/spark-rapids/issues/10218 not because it returned None.

@SurajAralihalli put in some help trying to debug this on the CUDF side and it looks like single quote support is off by default. And wouldn't you know it. The java API does not support configs so we get the default configs that do not support single quotes.
https://github.com/rapidsai/cudf/blob/57bbe94e995b9a0365276e4cb26853dce219e22a/java/src/main/native/src/ColumnViewJni.cpp#L2451
We need to fix the JNI API to let configs be passed in. We need to enable single quote support in our operator, and we need to add more tests to verify that it is working properly with single quotes.


message header changes

hmm, i think they should be expandable on their own.
sometimes you may need to see the message body and the complete recipient list but don't care for the whole other stuff in the header.

Merged with some changes.


Successfully run a simple script using the react-diagrams library

Even if it's just the simple sample from the docs, the important is to make the library work. And please, document it, so that i can also be able to use it.
Links :
https://github.com/projectstorm/react-diagrams
https://projectstorm.gitbook.io/react-diagrams/

Ouh, learning that i needed to use webpack in order to use compiled TypeScript in a browser was not obvious --'


Discovery - can metacontroller benefit from building atop of some tooling

Description
There is several options to build controllers in kubernetes :

kubebuilder - https://github.com/kubernetes-sigs/kubebuilder
operator-sdk - https://github.com/operator-framework/operator-sdk
controller-runtime - https://github.com/kubernetes-sigs/controller-runtime

Metacontroler currently does not use any of those, this issue is about discovering if any of those would fit as something which can be adopted to simplify metacontroller architecture etc.
Actions

quickly go over each of mentioned frameworks and check if it fits metacontroller.

A while back I implemented a metacontroller for TTL controllers using controller-runtime alone and found it to be fully sufficient. A lot of the object watching and controller management boilerplate was done by the library itself. The code can be found here: https://github.com/fpetkovski/k8s-ttl-operator/. I hope it will be useful in making the decision.

thanks:) , will take a look. I know metacontroller use case is specific (as it is "generic" controller) but I believe it can be simplified

I just saw that there is also now crossplane-runtime from the Crossplane project. It seems to be more suitable for dynamically spinning up and tearing down controllers.

thanks for hint @fpetkovski  :) . Adding to the list

I created a PR which demonstrates how controller-runtime would help for reducing the codebase of the project. So far it is scoped to the two top-level controllers (decorator and composite). The dynamic ones are not touched. I would be happy to get any feedback on it.

also found https://github.com/kubernetes-sigs/controller-tools , need to check whats is in there

Implemented in https://github.com/metacontroller/metacontroller/pull/221 at least first step. Closing.


Docs: build permission docs with sphinx (supp/1.0.x)

Signed-off-by: Mikhail Boldyrev<EMAIL_ADDRESS>

Description of the Change
Permissions descriptions are generated automatically during sphinx build. Generators are wrapped into custom sphinx directives.

Benefits
Remove responsibility of rebuilding permissions from maintainers.

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

probably support branch can get along without this change because permissions or their docs will most likely not be touched here. so it's not worth reviewing time.


Hide 'Alliance' agenda on index page to prevent misalignment

When an Alliance deck is shown in index page, the house/agenda line it's too long and causes misalignment. Here is an example:

This quick fix solves it. If you see 3 houses you can guess it's using Alliance agenda... (by the moment...)

Thanks!


Integrate flake8 with GitHub Actions

Integrate the Flake 8 library, as documented in the README in the GitHub actions continuous integration workflow. The action should "fail" if flake8 finds issues.

@klwhaley @LisaWellman @cragun47 - I would recommend working locally with autopep8 and flake8 for a bit before we enforce a linting rule on the repository. That will allow us to fine tune the rule's we're using.


[BUG] Missing IonicModule and HttpModule in components.module.ts

Ionic version:
[ x ] 3.x
I'm submitting a ...
[ x ] bug report
Current behavior:
Now, generating components in 3.6.0 is excellent and easy. However, shared module for all lazy-loaded components doesn't import IonicModule and HttpModule. That causes problems such as:

Can't bind to 'ngClass' since it isn't a known property of 'button'

I have solved the problem by importing the above two classes IonicModule and HttpModule
Expected behavior:
The following two lines should be added to the import list of components.module.ts
import { IonicModule } from "ionic-angular";
import { HttpModule } from "@angular/http";

Steps to reproduce:
Generate components using CLI

ionic info

cli packages:
    @ionic/cli-plugin-cordova       : 1.5.0 (MYPROJDIR/nod
e_modules/@ionic/cli-plugin-cordova)
    @ionic/cli-plugin-ionic-angular : 1.4.0 (MYPROJDIR/nod
e_modules/@ionic/cli-plugin-ionic-angular)
    @ionic/cli-utils                : 1.6.0 (MYPROJDIR/nod
e_modules/@ionic/cli-utils)
    ionic (Ionic CLI)               : 3.6.0 (MYPROJDIR/nod
e_modules/ionic)

global packages:
    Cordova CLI : 7.0.1

local packages:
    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : none
    Ionic Framework    : ionic-angular 3.6.0

System:
    Node       : v6.11.0
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b
    ios-deploy : 1.9.1
    ios-sim    : 5.1.0
    npm        : 5.3.0

Thanks a lot to IONIC Team

Hello, thanks for opening an issue with us. We are currently discussing the best way to handle this situation internally.


improved UI of navbar

resolves #6
this PR improves the UI design of the Navbar.
I have made the Navbar responsive by making a menu icon that toggles only while in screen lesser than 960px
Changed the font of LOGO to a more elegant font and changed the color of the navbar from existing black to a newer glassmorphism.

resolves #6 this PR improves the UI design of the Navbar. I have made the Navbar responsive by making a menu icon that toggles only while in screen lesser than 960px Changed the font of LOGO to a more elegant font and changed the color of the navbar from existing black to a newer glassmorphism.

Assignee: @SumitMangrati
Hi Sumit,
Thank you for your efforts in improving the UI design of the Navbar. I appreciate your work on making the Navbar responsive and incorporating the Glassmorphism effect.
However, I noticed a couple of issues in the code you submitted:

Classname Issue: In the code snippet you provided:
<div class={click ? "menu-links active" : "menu-links"}>
   <Navlink/>
 </div>

Please replace class with className to correctly set the class name.

Navbar Size on Tablet and Phone: It appears that the Navbar for tablet and phone sizes is smaller than expected. To ensure a better user experience, let's make it full-screen on these devices.

Maximum Navbar Width: We also need to set a maximum width for the Navbar to maintain a consistent layout on larger screens. Please ensure the Navbar doesn't expand beyond a certain width.

Bug: Scrolling down in safari browser, hide the navbar

shall i make the navbar for all sizes by removing the "disappearing navbar while scrolling" feature. Because i think so a static Navbar would be more good than a dynamic one and it would also remove the bug in smaller sizes where the menu bar keeps toggling on but the navbar disappears while scrolling

shall i make the navbar static for all sizes by removing the "disappearing navbar while scrolling" feature. Because i think so a static Navbar would be more good than a dynamic one and it would also remove the bug in smaller sizes where the menu bar keeps toggling on but the navbar disappears while scrolling

Ok, Make static


docs: adding overview files

Hi @Philip-Larsen-Donnelly ! I am still not 100% finished, but more than a half way through now.


Addon keeps spamming logs with errors

Recently, in the supervisor logs these two errors keep appearing
Registratore: homeassistant.components.hassio.data
Fonte: components/hassio/data.py:497
Integrazione: Home Assistant Supervisor ([documentazione](https://www.home-assistant.io/integrations/hassio), [problemi](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+hassio%22))
Prima occorrenza: 11:29:44 (363 occorrenze)
Ultima registrazione: 21:26:16

Could not fetch changelog for 6b87c29e_speedtest_addon:

and
Registratore: homeassistant.components.hassio.handler
Fonte: components/hassio/handler.py:612
Integrazione: Home Assistant Supervisor ([documentazione](https://www.home-assistant.io/integrations/hassio), [problemi](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+hassio%22))
Prima occorrenza: 11:29:44 (363 occorrenze)
Ultima registrazione: 21:26:16

Client error on /addons/6b87c29e_speedtest_addon/changelog request 0, message='Attempt to decode JSON with unexpected mimetype: application/octet-stream', url=URL('http://<IP_ADDRESS>/addons/6b87c29e_speedtest_addon/changelog')

Thank you for bring me this issue to my attenttion. In the next release I'll add a changelog file and should stop this error message.

In the latest release I added a changelog file.

Thanks!


incorporate asset sources into pipeline

The more I look at this, the more messy it seems.  The scss sources are not self-contained.  They have dependencies on an external css framework called inuit.css. We could copy the inuit.css sources directly into the project as has previously been done with the classie and html5shiv dependencies.  We will also need to copy the scss sources from the Core-Frontend and each application-specific frontend into the MyopicVicar project, reorganise the directory structure some, and update the rake task that copies the app-specific assets/sources into the correct place.
We will also likely need to make some modifications to the the asset pipeline manifest files / directives to reflect the changes and make sure things are included in the right order (and not multiple times).  I guess my lingering question is whether I am the right person to be doing this.  @AlexAvlonitis , are you more experienced than I am with the asset pipeline and organising scss?  If not I can keep at it, but if you are more experienced with that than I am, we should reconsider whether this is the best use of my time now that you are aboard full time.

The front-end styles are now compiled from the source .scss files instead of using the .min.css directly (except for the app/assets_freexxx/styles/css/icons.data.*.css files that are copied directly from the frontend projects). I changed a couple of files to .scss.erb so we can handle  app-specific color schemes, etc. in a single set of files instead of three separate sets of files.
Deployed to test2.
Although the majority of this story is now done, there are still a couple minor things still to be done before I mark this task as ready for user test, primarily:
1 - a couple of frontend bugs we previously fixed directly in .min.css are back because they have not yet been fixed in the source .scss files that are now being used instead
2 - static files in /public that are app-specific need handling by the rake task that copies site-specific assets.
I plan to finish those last couple of items at beginning of Jan before the scrum.

I did some searches on test2 and find the response extremely good.

Deployed Doug's latest changes to production.

Did the last couple of remaining things related to this task and deployed to test2.


python3Packages.httpx: 0.23.3 -> 0.24.1

Description of changes
https://github.com/encode/httpx/blob/master/CHANGELOG.md
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Would you mind adding a commit updating pytest-httpx to v0.22.0? It seems intended to move in lockstep with httpx.

As noted in https://github.com/NixOS/nixpkgs/pull/237274, frogmouth is also affected and will need its dependency on httpx to be relaxed.

Would you mind adding a commit updating pytest-httpx to v0.22.0? It seems intended to move in lockstep with httpx.

Please also update httpcore for the same reason

Thank you for pushing this along, @mweinelt!  It's much appreciated.  I've had a really busy week at work so I haven't had time to follow-up, and probably won't this week either.

I added the relaxed deps on frogmouth as requested.

#240135 updates frogmouth with updates its httpx dependency

I rebased away the changes that have already been merged.  I think the rest is now good for review?
dropping b1aeda150799209be82285f9fdf86d291200abbf python310Packages.pytest-httpx: 0.21.3 -> 0.22.0 -- patch contents already upstream
dropping 7a81cb6803390d183924df84f420eded64288ea5 python310Packages.frogmouth: relax dependency on httpx -- patch contents already upstream


Fix typos

Sorry, couldn't resist. Just fixing some very obvious typos.

Thank you for your help, Mas @jaybaeta


null is display for namespace when editing workload

Rancher versions:
rancher/server:master 04/23
Steps to Reproduce:

Create a GKE cluster
Move namespace cattle-system to project Default
Edit the workload cattle-cluster-agent. The namespace is null:

Version - 2.0 master 4/24
Verified fixed


Fix "Contribution Guideline" button

i would like to work on this issue, can you assing it with hacktoberfest tag

@Hiresh23 go for it

can you once describe the issue

Check the resource page @Hiresh23 . The upper and lower spaces is too much. You need to reduce that. Also, in the upper space, there is a hidden button that can be clicked. You need to remove that. Thanks :)

let me try once again

made the changes please check


Train with examples with and without entities

Currently trying to train with examples with and without entities. So my training dataset looks like this:
{'ner': [(4, 5, 'PER'),], 'tokenized_text': [...]}
{'ner': [], 'tokenized_text': [...]}
...

Training with this dataset produces RuntimeError: cannot reshape tensor of 0 elements into shape [-1, 0] because the unspecified dimension size -1 can be any value and is ambiguous in model.SpanGLiNER.forward() in this line:
# loss for filtering classifier
logits_label = scores.view(-1, num_classes)

Training without labels is important though, as I need the model to recognize when not to identify spans too. What's the canonical way to train with examples without entities?
Thanks for the help!

Hi @rmitsch, gliner needs at least entity names. you can set it like this: {'ner': [], 'tokenized_text': [...], 'label':['person', 'location', ...]}

Works. Thank you!


Fragment - Why Choose Shred-it Rendering

The Why Choose Shred-it Fragment should be rendering with the text aligned center but it is showing left aligned when rendered

Icons should also be larger (desktop & mobile)

Should match live site rendering

@colinvlasak Where do I find this fragment?

The first one is an easy fix on the authoring side: The centered text style on sections will only apply to default content within the section. For blocks you need to apply it to the block styles.


Doesn't install - amphtml-validator not matched

Trying to install this straight from the repo
git clone https://github.com/ampproject/ampstart
cd ampstart
npm i
It fails.  It keeps failing.
Any help?

postinstall-windows.js: amphtml-validator not matched.

$ npm i

><EMAIL_ADDRESS>postinstall C:\Users\augdo\ampstart\node_modules\amphtml-validator
> /bin/sh -c "exit 0" 2> NUL && rm NUL || node postinstall-windows.js

postinstall-windows.js: amphtml-validator not matched.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `/bin/sh -c "exit 0" 2> NUL && rm NUL || node postinstall-windows.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.

I've used the most recent version of amphtml-validator, downloaded via npm i -g amphtml-validator.  I also explicitly chose 1.0.21 but that makes no difference, same error.

looking into his

@erwinmombay can this be closed?

Closing - just installed tonight and it worked.  Thanks!