Hot reload stoped working after updating laravel mix

Laravel Mix Version: 0.11.3
Node Version:  6.10.2
NPM Version: 4.5.0
OS: windows 10

My composer json script for hot:
"hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",

After updating laravel mix, hot reload stoped working. Scripts cannot be loaded, and when I visit http://localhost:8080/ or http://localhost:8080/js/app.js I get message: Cannot get / or Cannot get /js/app.js
Nothing else was changed and npm run dev still works.
If I use the fix that was posted in https://github.com/JeffreyWay/laravel-mix/issues/599 I can get it to work, but I need to disable extract because they suffer from the same error of Cannot GET /js/manifest.js.
Was there a breaking change and docs don't reflect it?

Having the same problem. From what I have gathered it's a webpack problem. Sadly would not know where to start to try and fix it.

Also having this problem. I've been searching around and it does seem to be a webpack issue indeed. I suddenly started getting No Access-Control-Allow-Origin header is present when hot-reload is triggered.

It's because of security fix in webpack-dev-server 2.4.3. More information -  https://github.com/webpack/webpack-dev-server/releases/tag/v2.4.3

I added the headers option to the following in setup/webpack.config.js:
module.exports.devServer = {
    historyApiFallback: true,
    noInfo: true,
    compress: true,
    quiet: true,
    headers: {
        'Access-Control-Allow-Origin': '*'
    }
};

This allows CORS requests from all hosts, which is ideal for Laravel Mix IMO (since it's designed to be portable with minimal config, and allow for dev environments with random local domains). However, this defeats the purpose of the aforementioned patch.

I have the same alert by CORS policy. Access-Control-Allow-Origin: '*' header in devServer solves the issue.

Same issue here.
Fixed: just changed "webpack-dev-server" in package.json to "2.4.2" without ^.

meh, it's not working again. don't know what is changes. get in touch.

I am on hackathon now and it's very big trouble for me.

I just merged a PR to fix this.


Fix #868: Option to ignore globally-namespaced classes from MissingImport

Type: feature
Issue: Resolves #868
Breaking change: no
See #868 for motivation. Adds a property ignore-global to the MissingImport rule that will cause it to ignore classes in the global namespace (i.e. classes that do not contain a backslash in their FQN).
This still needs tests but I'd like maintainer approval and guidance before proceeding with that, since I'm a little intimidated by the unit test architecture. I don't know how to incorporate an optional flag into the test cases.
As an aside, kudos on maintaining a very well-organized and documented codebase, it was pretty easy to grok.

@danepowell thanks for the PR. Maybe you already got an notification / email from the GitHub actions but there are failing test. If I take a quick look it is the result of not having a default value. Can you check check and update it? (Not having a default value that keeps the current logic should also make it a breaking change)

Thanks, I fixed the broken test and also added a test case for the new option.

Thanks for the PR


static analysis fix for PR 2314

Pull Request Functional Test Report for #2382 / 427e8a13a617833c0e19820de6edecb9ffd83224
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Cisco 8000E

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Cisco XRd

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Juniper cPTX

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Juniper ncPTX

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Nokia SR Linux

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Openconfig Lemming

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Cisco 8808

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Juniper PTX10008

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Nokia 7250 IXR-10e

RT-3.1: Policy based VRF selectionRT-3.2: Multiple <Protocol, DSCP> Rules for VRF SelectionTE-3.1: Base Hierarchical Route InstallationTE-14.1: gRIBI Scaling

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.7%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1536

Relevant Lines:
3154

💛  - Coveralls


(Base)ApiListingResource initialized field should not be static

Hello,
I'm creating a new issue, for the same reason as https://github.com/swagger-api/swagger-core/issues/1286
It's again, not working anymore since 1.5.5, due to those changes :
https://github.com/swagger-api/swagger-core/commit/e96fc248373c22129d79c394b01509918c39ff67
Should be fixed now in BaseApiListingResource i guess.
https://github.com/swagger-api/swagger-core/blob/v1.5.8/modules/swagger-jaxrs/src/main/java/io/swagger/jaxrs/listing/BaseApiListingResource.java
We should be able to instantiate multiple swagger in the same JVM !
static modifier is way too global.

Can we have a unit test for this too ? Thank you

Still not fixed in 1.5.10 :'(


fix assembly name for NETSTANDARD1_3 project

The assembly name for the NETSTANDARD1_3 project was left as the default name, which produced an assembly named HtmlAgilityPack.NETStandard1_3.dll, instead of HtmlAgilityPack.dll

The v1,5,9-beta91 has been released.


Sort control (arrow up and down) still present when orderable = false

Hello,
I try to init a DTs grid over a table and I can't be able to workaround the issue I face.
Doing this
"columnDefs": [
    { "orderable": false, "targets": 0 }
  ]

But the sort control arrow up and down are still active even if they don't make the column sort...
At the end of this section of documentation https://datatables.net/reference/option/columns.orderable
There is a comment saying that we need to specify a default sorting column with order like so
order: [[1, 'desc']],

But combining this with the previous columnDefs doesn't help
There is also a this thread
https://datatables.net/forums/discussion/21164/disable-sorting-of-one-column
I try most thing the .no-sort css directive are working, but I didn't be able to set the no-sort class name neither as your last comment suggest
columnDefs: [
  { targets: 'no-sort', orderable: false }
]

nor with the new API like so
 table
    .columns( '.sorting' )
    .header()
    .to$()
    .removeClass( 'sorting' );

and setting class name this way
"columnDefs": [
    { className: "my_class", "targets": [ 0 ] }
  ]

The last columnDefs didn't work and that trouble me alot...
Here how goes my init
response.files.append(URL('static', 'plugin_added/DataTables-1.10.5/extensions/Plugins-1.10.5/integration/bootstrap/2/dataTables.bootstrap.css'))
  response.files.append(URL('static', 'plugin_added/DataTables-1.10.5/extensions/FixedColumns/css/dataTables.fixedColumns.min.css'))
  response.files.append(URL('static', 'plugin_added/DataTables-1.10.5/media/js/jquery.dataTables.min.js'))
  response.files.append(URL('static', 'plugin_added/DataTables-1.10.5/extensions/Plugins-1.10.5/integration/bootstrap/2/dataTables.bootstrap.js'))
  response.files.append(URL('static', 'plugin_added/DataTables-1.10.5/extensions/FixedHeader/js/dataTables.fixedHeader.min.js'))
  response.files.append(URL('static', 'plugin_added/DataTables-1.10.5/extensions/FixedColumns/js/dataTables.fixedColumns.min.js'))

<script type="text/javascript" charset="utf-8">
        $(document).ready( function () {

            var number_of_fixed_column = parseInt({{=number_of_fixed_column}});
            var ordering_column = parseInt({{=ordering_column if 'ordering_column' in locals() else 0}});
            var sSwfPath_location = "{{=URL('static', 'plugin_added/DataTables-1.10.5/extensions/TableTools/swf/copy_csv_xls.swf')}}"
            var filename_export = "{{='{table}_{timestamp}'.format(table=request.args(0) if request.args(0) else request.function,
                                                                   timestamp=request.now.strftime('%Y-%m-%d_%H-%M-%S-%f'))}}"

                var oTable = $('.display').DataTable( {
                        "autoWidth": false,
                        "order": [[ ordering_column, "asc" ]],
// NOT WORKING and VARIANT MENTION ABOVE
//                        "columnDefs": [{"orderable": false, "targets": "no-sort"},
//                                       //{className: "no-sort", "targets": [0]},
//                                       //{"searchable": false, "targets": [0]}
//                                       ],
                        "lengthChange": false,
                        "scrollY": "500px",
                        "scrollX": "100%",
                        "scrollCollapse": true,
                        "processing": true,
                        "paging": true,
                        "pagingType": "full_numbers",
                        "pageLength": 40,
                        "orderClasses" : false,
                        "dom": 'T<"clear">lfrtip',
                "language": { "search": "{{=T('Search')}}" + ' :' },

            {{if request.function not in ('bulk_review', 'samples_list'):}}
                "tableTools": {

                    "aButtons": [{"sExtends": "copy",
                                  "sCharSet": "utf16le",
                                  "bSelectedOnly": true
                                  },
                                 {"sExtends": "csv",
                                  "sFieldBoundary": '"',
                                  //"sFieldSeperator": "-",
                                  "sCharSet": "utf16le",
                                  "sFileName": filename_export + ".csv",
                                  "bSelectedOnly": true
                                  },
                                 {"sExtends": "xls",
                                  "sFieldBoundary": '"',
                                  //"sFieldSeperator": "-",
                                  "sCharSet": "utf16le",
                                  "sFileName": filename_export + ".csv",
                                  "bSelectedOnly": true
                                  },
                                  ],
                    "sSwfPath": sSwfPath_location,
                    "sRowSelect":  "multi"
                    }
            {{pass}}
                } );

                new $.fn.dataTable.FixedColumns( oTable, {
                    "iLeftColumns": number_of_fixed_column,
                    "heightMatch": "auto"
                    });
        } );
        </script>

I don't know if there could be some sort of incompatibility caused by fixheader plugin??
Thanks

Can you link to a test case showing the issue please.

Here : http://jsfiddle.net/zk07bsso/4/
But I have issue making bootstrap css integration working, I don't know why...
Though the issue seems not there in the test case... That is really curious... But the test case is not really equivalent to what I have in my code (1.10.5 package and add the plugin 1.10.5). In jsFiddle, I had to use CDN that refer to latest Plugins and I am not sure about FixHeader and FixColumns version too...
Is it right that we don't need "jquery.dataTables.min.css" when using bootstrap integration??
Thanks

Hello,
You can close that issue... I found my mistake... I where setting some DTs attributes conditionnally and because of that I were overwrithing unproperly the columnDefs attributes...
Sorry for the inconvenience...
Thanks

Is it right that we don't need "jquery.dataTables.min.css" when using bootstrap integration?

This is correct. Including both is wrong - only include one of them.
Good to hear that you have this sorted out :-)
Allan

Sorry for this old post but can you show me how is your mistake?
I have this code, it seems to be correctly but still showing sortable icon on first column while it should not.
    $('#usersTable').DataTable({
        'dom': '<"table-controls">f<"clearfix">rtip<"clearfix">',
        'columnDefs': [{
            'targets': 0,
            'searchable': false,// make checkbox column can't search.
            'orderable': false,// make checkbox column not sortable.
            'className': 'column-checkbox',
            'render': function (data, type, row, meta) {
                return '<input type="checkbox" name="user_id[]" value="' + $('<div/>').text(row.id).html() + '">';
            }
        },
        {
            'targets': 1,
            'render': function (data, type, row, meta) {
                return row.first_name+' '+row.last_name;
            }
        }],
        //'order': [[1, 'asc']],// make sortable icon appears at second column (first is 0).

        'processing': true,
        'serverSide': true,
        'ajax': {
            url: XhrCommon.currentUrlRaw,
            data: function(d) {
                d.CSRFTOKEN = 'myCustomTokenAndAdditionalDataHere';
            }
        },
        'columns': [
            {'data': 'id'},
            {'data': 'name'},
            {'data': 'email'},
        ],

    });

//'order': [[1, 'asc']],

This is commented out, so the default of [[0, 'asc']] is still being applied.

So, this means that if there is no default sort at the beginning the order value must be [] like the code below.
    $('#usersTable').DataTable({
        'dom': '<"table-controls">f<"clearfix">rtip<"clearfix">',
        'columnDefs': [{
            'targets': 0,
            'searchable': false,// make checkbox column can't search.
            'orderable': false,// make checkbox column not sortable.
            'className': 'column-checkbox',
            'render': function (data, type, row, meta) {
                return '<input type="checkbox" name="user_id[]" value="' + $('<div/>').text(row.id).html() + '">';
            }
        },
        {
            'targets': 1,
            'render': function (data, type, row, meta) {
                return row.first_name+' '+row.last_name;
            }
        }],
        'order': [],// make sortable icon disappears from first column.

        'processing': true,
        'serverSide': true,
        'ajax': {
            url: XhrCommon.currentUrlRaw,
            data: function(d) {
                d.CSRFTOKEN = 'myCustomTokenAndAdditionalDataHere';
            }
        },
        'columns': [
            {'data': 'id'},
            {'data': 'name'},
            {'data': 'email'},
        ],

    });

Thank you.
However, this topic might be related to this document (https://datatables.net/reference/option/columns.orderable). Please desire to update the document about this sorting icon.


Crouch bugs

Multiple Things i noticed
Crouching transforms the body and collision from the center, which sometimes (more often than not) causes the player to float due to its shrunken size and then drop to the ground. I dont know if its possible to change the transform origin to the bottom of the player or if a different solution has to be found.
It also causes the camera to glitch into the body but i think thats because the distance the body shrinks and the camera moves is different.
Being crouched and releasing the key while being under something with a collision should stop the transform process back to normal until enough space is available. This can be done using 1 (or more if more presicion is needed) RayCast3D Node(s). Currently, the code doesnt check this and it will either stop the player from moving at all or cause other bugs.

https://github.com/ColormaticStudios/quality-godot-first-person/commit/daaf5107d0bcd7458b4169012c12902b8eb460b2

Nice, but what about the transform-origin/camera position bugs?

The camera bug i only noticed when changing
var base_player_y_scale: float = 0.95
var crouch_player_y_scale: float = 0.45

To make the player fit under 1 standing and .5 crouched.
https://github.com/ColormaticStudios/quality-godot-first-person/assets/15162905/b7a55a2d-c620-4132-ab5b-202cbaa315ee


Updates of gpg encrypt and decrypt scripts

Good morning, I hope you are doing well and thanks for the work on the scripts. The gpg scripts had not been updated in a while and they were not working anymore mainly due to a change in key format output by gpg. Instead of hard coding thought I would take the time instead to update the scripts. Feel free to merge them if you like, thanks again for the work.

Hi @user414 ! Check my scripts in:
https://github.com/cfgnunes/nautilus-scripts
They are updated.


Handling of ALT key release

Without having i3-focus-last installed (yes, not the ideal way for opening first issue, but most apps have this problem, which I will mention now), I want to ask about the ALT key release behavior.
Most implementations of similar software simply ignore the ALT key release for accepting the new MRU list. For example, https://github.com/altdesktop/i3ipc-python/blob/master/examples/i3-cycle-focus.py uses a delay as a workaround.
So, in my opinion, after an ALT+Tab is detected, the MRU should only be committed after the ALT key has been released. I found this to be a working solution for that (Key-up detection without interfering with other processes):
#!/usr/bin/env python3
import asyncio
from evdev import InputDevice, ecodes, list_devices

async def monitor_key_events():
    # Find the keyboard device
    devices = [InputDevice(path) for path in list_devices()]
    keyboard_device = None

    for device in devices:
        if "keyboard" in device.name.lower():
            keyboard_device = device
            break

    if not keyboard_device:
        print("Keyboard device not found")
        return

    print(f"Monitoring key events on {keyboard_device.name}")

    # Monitor key events
    async def read_events(device):
        while True:
            event = await device.async_read_one()
            yield event

    async for event in read_events(keyboard_device):
        if event.type == ecodes.EV_KEY:
            if event.code == ecodes.KEY_LEFTMETA:
                if event.value == 0:  # Key release
                    print("Left WIN key released!")

async def main():
    task = asyncio.create_task(monitor_key_events())
    await task

if __name__ == "__main__":
    asyncio.run(main())

With this approach, you can detect the ALT key being released, even when i3 is binding that key, and the key is not "grabbed" or the key event is not stolen.
I apologize for not writing a clear issue, but I only wanted to share some thoughts/issues that I came across during my research over the past few days.
By the way, the Rofi plugin idea could be exactly the right direction. Do you also display the workspace number and process names (+ window title) as in Rofi window mode?

Thanks for the ideas!
For the first point, I only use the simple Alt-Tab functionality as toggle, not full cycle through history as usually rofi is a better fit for that. So I've never considered it so far. The tool also supports sway on wayland, so I think the keyboard monitoring approach would not quite work. Using a timeout could be a possible but I would prefer it to be a client flag instead of a global server behavior.
For now, the window format is fixed https://github.com/lbonn/i3-focus-last/blob/master/src/lib.rs#L142 but that can be extended.


istio-operator OOM Killer

Bug Description

Operator logs

2022-10-13T17:16:41.682301Z	info	installer	Reconciling IstioOperator
2022-10-13T17:16:41.711029Z	info	installer	Updating IstioOperator
2022-10-13T17:16:41.711072Z	info	installer	Detecting third-party JWT support
2022-10-13T17:16:43.296676Z	info	kube	Starting Pilot K8S CRD controller
2022-10-13T17:16:43.296719Z	info	kube	Pilot K8S CRD controller synced 54.451µs
2022-10-13T17:16:43.301710Z	info	installer	EgressGateways is waiting on dependency...
2022-10-13T17:16:43.301710Z	info	installer	Cni is waiting on dependency...
2022-10-13T17:16:43.301768Z	info	installer	Processing resources from manifest: IstiodRemote for CR istio-istio-system-IstiodRemote-https://<IP_ADDRESS>:443
2022-10-13T17:16:43.301791Z	info	installer	Generated manifest objects are the same as cached for component IstiodRemote.
2022-10-13T17:16:43.301782Z	info	installer	Pilot is waiting on dependency...
2022-10-13T17:16:43.301768Z	info	installer	Processing resources from manifest: Base for CR istio-istio-system-Base-https://<IP_ADDRESS>:443
2022-10-13T17:16:43.301810Z	info	installer	IngressGateways is waiting on dependency...
2022-10-13T17:16:43.356247Z	info	installer	Generated manifest objects are the same as cached for component Base.
2022-10-13T17:16:43.356269Z	info	installer	Unblocking dependency Pilot.
2022-10-13T17:16:43.356282Z	info	installer	Dependency for Pilot has completed, proceeding.
2022-10-13T17:16:43.356291Z	info	installer	Processing resources from manifest: Pilot for CR istio-istio-system-Pilot-https://<IP_ADDRESS>:443
2022-10-13T17:16:43.371040Z	info	installer	Generated manifest objects are the same as cached for component Pilot.
2022-10-13T17:16:43.371057Z	info	installer	Unblocking dependency Cni.
2022-10-13T17:16:43.371066Z	info	installer	Unblocking dependency IngressGateways.
2022-10-13T17:16:43.371070Z	info	installer	Unblocking dependency EgressGateways.
2022-10-13T17:16:43.371075Z	info	installer	Dependency for EgressGateways has completed, proceeding.
2022-10-13T17:16:43.371073Z	info	installer	Dependency for Cni has completed, proceeding.
2022-10-13T17:16:43.371081Z	info	installer	Processing resources from manifest: EgressGateways for CR istio-istio-system-EgressGateways-https://<IP_ADDRESS>:443
2022-10-13T17:16:43.371081Z	info	installer	Processing resources from manifest: Cni for CR istio-istio-system-Cni-https://<IP_ADDRESS>:443
2022-10-13T17:16:43.371100Z	info	installer	Generated manifest objects are the same as cached for component Cni.
2022-10-13T17:16:43.371109Z	info	installer	Dependency for IngressGateways has completed, proceeding.
2022-10-13T17:16:43.371116Z	info	installer	Processing resources from manifest: IngressGateways for CR istio-istio-system-IngressGateways-https://<IP_ADDRESS>:443
2022-10-13T17:16:43.376128Z	info	installer	Generated manifest objects are the same as cached for component EgressGateways.
2022-10-13T17:16:43.376146Z	info	installer	Generated manifest objects are the same as cached for component IngressGateways.
- Pruning removed resources
- Pruning removed resources

pods error:

    Last State:     Terminated
      Reason:       OOMKilled
      Exit Code:    137
      Started:      Wed, 12 Oct 2022 02:18:53 +0000
      Finished:     Thu, 13 Oct 2022 17:16:43 +0000
    Ready:          True
    Restart Count:  1
    Limits:
      cpu:     2
      memory:  8Gi
    Requests:
      cpu:      2
      memory:   8Gi

Version
istio version:  1.15.2

kubernetes version: v1.22.8

Additional Information
No response

can you share the iop configuration?

I can not reproduce this with operator:v1.15.2, what's version of your image?

I can not reproduce this with operator:v1.15.2, what's version of your image?

Memory grows to keep growing until oom is triggered

can you share the output of following command:
kubectl get deploy -nistio-operator -oyaml | grep image

kubectl logs -l name=istio-operator -n istio-operator --tail=-1

can you share the output of following command:
kubectl get deploy -nistio-operator -oyaml | grep image

kubectl logs -l name=istio-operator -n istio-operator --tail=-1

My image is using the image in the private repository
The image is pulled from istio/operator and pushed to the private repository

I hide the part of the domain name

kubectl -n istio-system get deployments.apps istio-operator -o yaml |grep image

        image: reg.xxxx.com/public/istio/operator:1.15.2
        imagePullPolicy: Always

logs

kubectl -n istio-system logs istio-operator-5b55f5d667-7rtxl --tail=-1

.....
2022-10-14T08:50:19.279575Z	info	installer	Reconciling IstioOperator
2022-10-14T08:50:19.305062Z	info	installer	Updating IstioOperator
2022-10-14T08:50:19.305100Z	info	installer	Detecting third-party JWT support
2022-10-14T08:50:20.935800Z	info	kube	Starting Pilot K8S CRD controller
2022-10-14T08:50:20.935845Z	info	kube	Pilot K8S CRD controller synced 57.458µs
2022-10-14T08:50:20.940932Z	info	installer	Processing resources from manifest: Base for CR istio-istio-system-Base-https://<IP_ADDRESS>:443
2022-10-14T08:50:20.944548Z	info	installer	Processing resources from manifest: IstiodRemote for CR istio-istio-system-IstiodRemote-https://<IP_ADDRESS>:443
2022-10-14T08:50:20.944566Z	info	installer	Generated manifest objects are the same as cached for component IstiodRemote.
2022-10-14T08:50:20.944595Z	info	installer	Pilot is waiting on dependency...
2022-10-14T08:50:20.944619Z	info	installer	Cni is waiting on dependency...
2022-10-14T08:50:20.944633Z	info	installer	IngressGateways is waiting on dependency...
2022-10-14T08:50:20.944646Z	info	installer	EgressGateways is waiting on dependency...
2022-10-14T08:50:20.990424Z	info	installer	Generated manifest objects are the same as cached for component Base.
2022-10-14T08:50:20.990442Z	info	installer	Unblocking dependency Pilot.
2022-10-14T08:50:20.990455Z	info	installer	Dependency for Pilot has completed, proceeding.
2022-10-14T08:50:20.990462Z	info	installer	Processing resources from manifest: Pilot for CR istio-istio-system-Pilot-https://<IP_ADDRESS>:443
2022-10-14T08:50:21.003473Z	info	installer	Generated manifest objects are the same as cached for component Pilot.
2022-10-14T08:50:21.003491Z	info	installer	Unblocking dependency Cni.
2022-10-14T08:50:21.003499Z	info	installer	Unblocking dependency IngressGateways.
2022-10-14T08:50:21.003505Z	info	installer	Unblocking dependency EgressGateways.
2022-10-14T08:50:21.003511Z	info	installer	Dependency for EgressGateways has completed, proceeding.
2022-10-14T08:50:21.003517Z	info	installer	Processing resources from manifest: EgressGateways for CR istio-istio-system-EgressGateways-https://<IP_ADDRESS>:443
2022-10-14T08:50:21.003567Z	info	installer	Dependency for Cni has completed, proceeding.
2022-10-14T08:50:21.003577Z	info	installer	Processing resources from manifest: Cni for CR istio-istio-system-Cni-https://<IP_ADDRESS>:443
2022-10-14T08:50:21.003586Z	info	installer	Generated manifest objects are the same as cached for component Cni.
2022-10-14T08:50:21.003594Z	info	installer	Dependency for IngressGateways has completed, proceeding.
2022-10-14T08:50:21.003600Z	info	installer	Processing resources from manifest: IngressGateways for CR istio-istio-system-IngressGateways-https://<IP_ADDRESS>:443
2022-10-14T08:50:21.008139Z	info	installer	Generated manifest objects are the same as cached for component EgressGateways.
2022-10-14T08:50:21.008215Z	info	installer	Generated manifest objects are the same as cached for component IngressGateways.
- Pruning removed resources
2022-10-14T08:50:21.848933Z	info	installer	Reconciling IstioOperator
2022-10-14T08:50:21.874200Z	info	installer	Updating IstioOperator
2022-10-14T08:50:21.874237Z	info	installer	Detecting third-party JWT support

....

how do you apply the iop configuration? via argocd?

something odd
 cat istio-operator-logs.txt | grep "Reconciling IstioOperator" | wc -l
21299

it seems too much
how did you install the operator?

something odd
 cat istio-operator-logs.txt | grep "Reconciling IstioOperator" | wc -l
21299

it seems too much
how did you install the operator?

deployment   yaml

The memory always grows, and it will not be recovered until OOM,  Currently at the critical point again

can you remove the following from you IOP yaml file?
proxyMetadata: {}

and
env: {}

can you remove the following from you IOP yaml file?
proxyMetadata: {}

and
env: {}

OK, I will delete it immediately, and then observe

After the modification, it seems that the memory usage is back to normal, thank you very much

this should be fixed by https://github.com/istio/istio/pull/41449


eager: true not working anymore with self-referenced entity

Describe the bug
The problem is with parameter eager: true. If we have an entity with self-reference relationship and we want to load N levels (category with children category etc) with eager: true flag then in version 5 of mikroorm it doesn't work anymore
Stack trace
ERROR [ExceptionsHandler] Collection<Category> of entity Category[2] not initialized
                           | Error: Collection<Category> of entity Category[2] not initialized
                          |     at Collection.checkInitialized (/usr/src/app/node_modules/@mikro-orm/core/entity/Collection.js:302:19)
                           |     at Collection.count (/usr/src/app/node_modules/@mikro-orm/core/entity/Collection.js:152:14)
                          |     at Collection.get length [as length] (/usr/src/app/node_modules/@mikro-orm/core/entity/ArrayCollection.js:152:21)
...

To Reproduce
Steps to reproduce the behavior:

Create model

@Entity({
  customRepository: () => CategoryRepository
})
export class Category {
  @PrimaryKey()
  id: number;

  @ManyToOne(() => Category)
  parent: Category & NestedSetSubjectAbstract<Category>;

  @OneToMany({
    entity: () => Category,
    mappedBy: (category) => category.parent,
    cascade: [Cascade.ALL],
    orphanRemoval: true,
    eager: true
  })
  children = new Collection<Category>(
    this
  );
}

Try to load string entity with findOne method
You will get  "children: Collection { initialized: true, dirty: false }" at second nested level (name Newww Categorsdasdy)

5. Categories hierarchy in DB

Expected behavior
Initialized and loaded children collection at second and N levels
Additional context
Worked in version 4.x, doesn't work in 5.x
Versions

Dependency
Version

node
18

mikro-orm
5.6.11

Sure, here is whole reproduction as code
https://github.com/axotion/mikro-orm-4061-reproduction
All you have to do is run docker-compose up and the whole case will run. I've also added a comments to what was expected


Issues/issue 34261: enable using {% url model_object %} to work with get_absolute_url

Closing per ticket.


python3Packages.fastai: 2.7.10 -> 2.7.11

Description of changes
lastest version
change log https://github.com/fastai/fastai/blob/master/CHANGELOG.md#2711
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @benxiao

Result of nixpkgs-review pr 219645 run on x86_64-linux 1

1 package built:

python310Packages.fastai


Sum of all nodes values in a tree

i would like to contribute may i go ahead for this?

May i start contribution from 1 october?

@Manoj13-coder  You may start contributing right now


Edit pass complete

Edited content for publication.

@ajford76 I've finished my edits on this doc. You can merge it to your fork/branch.


Refactor: MappedDiagnosticsLogicalContext.Dispose

MappedDiagnosticsLogicalContext - SetScoped with IReadOnlyList (Refactor)
Minor refactoring to make sonar happy. See also  #2949

Thanks!


Will the auto_add_music feature be added for videos?

We can use auto_add_music feature for photos but what about videos? its not available according to documentation but its a valuable feature. So, will be added for videos too? Some of our customers want to upload videos to our platform directly after recording, without any editing, and have TikTok automatically add music and share them, just like it can be done with photos. We would really like to have this feature added.

Thanks for the insight and feedback. We have put forward this proposal before the team. Will update you if we move forward on this feature.


Versions below 5.81 are deprecated

Error: Invalid request: versions below 5.81 are deprecated. Version param should be passed as "v". "version" param is invalid and not supported.
Tell me how to change the version?

Hey. Update to the last version of the package. There is no "version" param in our implementation, we just use default one.

@greymag thank you for a quick reply. I already had a version 2.0.0+1, and this was a problem on the server.
However, now I know that version cannot be set.


Crashes on env

I have followed through the tutorial, and have come to running this script. The USB thumb drive is detected (and auto-mounts), but when I ran this script...
usr/bin/env: bash/r: No such file or directory
Any explanation?

I don't have a specific explanation, but this code definitely has not been updated in some time.
We should probably deprecate this project, as I believe you should now be able to use an external root filesystem, at least on the Pi 3.  That said, I'll take a deeper look at the issues here once I finish a few other projects.


Update Dockerfile for automated builds

So we can fix https://github.com/fusor/mig-ui/issues/342

Builds are already set up. https://quay.io/repository/ocpmigrate/mig-ui?tab=builds
Merging this should fix the failures and (hopefully if I didn't screw anything up) give us good images.

Image built with this Dockerfile appears to be serving properly.


refator(operator): use built in url parser instead of regex for sending rpc information to telemetry service

#1327


[9.x] Update schedule:work usleep from 0.1 seconds to 0.5 seconds

Howdy,
Its a minor thing, but do we need to poll every 0.1 second in artisan schedule:work? there could be a specific reason that I'm not aware of?
Its not a super scientific test, but I tested with a schedule to run $schedule->command('inspire')->everyMinute();, then tested the following sleep configurations for a total of 10 minutes.
100 = 0.1 seconds
500 = 0.5 seconds
1000 = 1 second

There is a minor decrease in CPU utilization shown in htop for both the 0.5 second and 1 second test

Personally I would be inclined to shoot for a straight 1 second sleep in the loop, but I figured there is probably a reason why this was initially not set as such, in which case 0.5 might be a nice middle ground.
Having said that, I'd understand if this PR gets knocked back because of how minor 0.1% cpu usage is, at the very least I figure its worth a shot to see if the sleep timer is worth discussion.

Kinda hard to gauge what the performance benefit is if 0.1% CPU could be 0.05 (rounded up) and 0.0% CPU could be 0.049 (rounded down). That being said I dont know what the reason is for 100ms intervals.

Just going to leave it as is if it's not broken and not hurting anything severely.


Optimize 'detailed' solver

While testing the implementation of the inclined FLS in #50 / #197, I found that the 'detailed' solver calculates the FLS between a borehole and itself in a for loop, so it is called once per borehole. This could be done in one call for all boreholes at the same time.
https://github.com/MassimoCimmino/pygfunction/blob/79e0198cd8e828797a6d6832f981b34288d36281/pygfunction/gfunction.py#L1907-L1924

Rectangular fields

Field of 100 boreholes with two different lengths

(master is from the 'similarities' solver)


Encode error text at HTML so it doesn't integrate into the DOM

Currently an error in the endpoint's response will integrate into the page's DOM (creating this odd looking header section).  This commit encodes the response as HTML elements, so it appears in the example output box as HTML code.

Good idea Bruce, I always wondered how that happened. Approved.


Heap out of bounds read - WASM_OP_I32_STORE16: wasm_interp_call_func_bytecode (wasm_interp.c:1226)

Environment

Questions
Answers

Related Binary
./iwasm (linux build)

Commit
commit 9a02c49d7c2bb2012fe8d2bd2b9cb2bdaf88ba79

Vulnerability/issue
Heap out of bounds read in wasm_interp_call_func_bytecode (wasm_interp.c:1226)
case: WASM_OP_I32_STORE16
Steps to reproduce the behavior

Download:
PoC.zip

Run:
./iwasm PoC.wasm

Additional Informations
Crash
[1]    14488 segmentation fault  ./iwasm

GDB
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.

[----------------------------------registers-----------------------------------]
RAX: 0x0
RBX: 0x555555781108 --> 0x4200000003
RCX: 0x555555578ea0 ("unaligned load/store in wasm interp, flag is: %d.\n")
RDX: 0x0
RSI: 0x0
RDI: 0x2
RBP: 0x7fffffffd6c0 --> 0x7fffffffd7b0 --> 0x7fffffffd800 --> 0x7fffffffd880 --> 0x7fffffffd8b0 --> 0x7fffffffd9a0 (--> ...)
RSP: 0x7fffffffcde0 --> 0x219000
RIP: 0x555555563e37 (<wasm_interp_call_func_bytecode+18936>:	mov    rdx,QWORD PTR [rax+0x18])
R8 : 0x21 ('!')
R9 : 0x7fffffffd1d0 --> 0x55555577f17d --> 0x6e0417000b00200b
R10: 0x0
R11: 0x246
R12: 0x55555577f17d --> 0x6e0417000b00200b
R13: 0x5555557810fc --> 0x100000000
R14: 0x0
R15: 0x0
EFLAGS: 0x10206 (carry PARITY adjust zero sign trap INTERRUPT direction overflow)
[-------------------------------------code-------------------------------------]
   0x555555563e25 <wasm_interp_call_func_bytecode+18918>:	jbe    0x555555563eb3 <wasm_interp_call_func_bytecode+19060>
   0x555555563e2b <wasm_interp_call_func_bytecode+18924>:	jmp    0x555555568495 <wasm_interp_call_func_bytecode+36950>
   0x555555563e30 <wasm_interp_call_func_bytecode+18929>:	mov    rax,QWORD PTR [rbp-0x4e8]
=> 0x555555563e37 <wasm_interp_call_func_bytecode+18936>:	mov    rdx,QWORD PTR [rax+0x18]
   0x555555563e3b <wasm_interp_call_func_bytecode+18940>:	mov    ecx,DWORD PTR [rbp-0x69c]
   0x555555563e41 <wasm_interp_call_func_bytecode+18946>:	mov    rax,QWORD PTR [rbp-0x4e8]
   0x555555563e48 <wasm_interp_call_func_bytecode+18953>:	mov    eax,DWORD PTR [rax+0x30]
   0x555555563e4b <wasm_interp_call_func_bytecode+18956>:	cdqe
[------------------------------------stack-------------------------------------]
0000| 0x7fffffffcde0 --> 0x219000
0008| 0x7fffffffcde8 --> 0x555555781060 --> 0x0
0016| 0x7fffffffcdf0 --> 0x555555780d90 --> 0x1000100000000
0024| 0x7fffffffcdf8 --> 0x555555781008 --> 0x0
0032| 0x7fffffffce00 --> 0xc50000019000
0040| 0x7fffffffce08 --> 0x47f7f3b01
0048| 0x7fffffffce10 --> 0x7fffffffd0e0 --> 0x7fffffffd110 --> 0x7ffff7fcf9c0 ("/lib/x86_64-linux-gnu/libc.so.6")
0056| 0x7fffffffce18 --> 0x11c00000000
[------------------------------------------------------------------------------]
Legend: code, data, rodata, value
Stopped reason: SIGSEGV
0x0000555555563e37 in wasm_interp_call_func_bytecode (self=0x555555781008 <global_heap_buf+8552>, cur_func=0x555555780d90 <global_heap_buf+7920>, prev_frame=0x555555781060 <global_heap_buf+8640>) at XYZ/wasm-micro-runtime/core/iwasm/runtime/vmcore-wasm/wasm_interp.c:1226
1226	        DEF_OP_STORE(uint32, I32, *(uint16*)maddr = (uint16)sval);
#0  0x0000555555563e37 in wasm_interp_call_func_bytecode (self=0x555555781008 <global_heap_buf+8552>, cur_func=0x555555780d90 <global_heap_buf+7920>, prev_frame=0x555555781060 <global_heap_buf+8640>) at XYZ/wasm-micro-runtime/core/iwasm/runtime/vmcore-wasm/wasm_interp.c:1226
#1  0x00005555555686fd in wasm_interp_call_wasm (function=0x555555780d90 <global_heap_buf+7920>, argc=0x0, argv=0x7fffffffd870) at XYZ/wasm-micro-runtime/core/iwasm/runtime/vmcore-wasm/wasm_interp.c:2158
#2  0x0000555555559447 in wasm_runtime_call_wasm (module_inst=0x555555780f08 <global_heap_buf+8296>, exec_env=0x0, function=0x555555780d90 <global_heap_buf+7920>, argc=0x0, argv=0x7fffffffd870) at XYZ/wasm-micro-runtime/core/iwasm/runtime/vmcore-wasm/wasm_runtime.c:102
#3  0x0000555555558842 in wasm_application_execute_main (module_inst=0x555555780f08 <global_heap_buf+8296>, argc=0x1, argv=0x7fffffffda90) at XYZ/wasm-micro-runtime/core/iwasm/runtime/vmcore-wasm/wasm_application.c:109
#4  0x0000555555557ad8 in app_instance_main (module_inst=0x555555780f08 <global_heap_buf+8296>) at XYZ/wasm-micro-runtime/core/iwasm/products/linux/main.c:54
#5  0x00005555555580eb in main (argc=0x1, argv=0x7fffffffda90) at XYZ/wasm-micro-runtime/core/iwasm/products/linux/main.c:217
#6  0x00007ffff7448b97 in __libc_start_main (main=0x555555557d8c <main>, argc=0x2, argv=0x7fffffffda88, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffda78) at ../csu/libc-start.c:310
#7  0x000055555555798a in _start ()

Valgrind
==14486== Memcheck, a memory error detector
==14486== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==14486== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==14486== Command: ./iwasm XYZ/wasm-micro-runtime/core/iwasm/products/linux/debug/triage/0x555555563ec8/PoC.wasm
==14486==
==14486== Invalid read of size 8
==14486==    at 0x117E37: wasm_interp_call_func_bytecode (wasm_interp.c:1226)
==14486==    by 0x11C6FC: wasm_interp_call_wasm (wasm_interp.c:2158)
==14486==    by 0x10D446: wasm_runtime_call_wasm (wasm_runtime.c:102)
==14486==    by 0x10C841: wasm_application_execute_main (wasm_application.c:109)
==14486==    by 0x10BAD7: app_instance_main (main.c:54)
==14486==    by 0x10C0EA: main (main.c:217)
==14486==  Address 0x18 is not stack'd, malloc'd or (recently) free'd
==14486==
==14486==
==14486== Process terminating with default action of signal 11 (SIGSEGV)
==14486==  Access not within mapped region at address 0x18
==14486==    at 0x117E37: wasm_interp_call_func_bytecode (wasm_interp.c:1226)
==14486==    by 0x11C6FC: wasm_interp_call_wasm (wasm_interp.c:2158)
==14486==    by 0x10D446: wasm_runtime_call_wasm (wasm_runtime.c:102)
==14486==    by 0x10C841: wasm_application_execute_main (wasm_application.c:109)
==14486==    by 0x10BAD7: app_instance_main (main.c:54)
==14486==    by 0x10C0EA: main (main.c:217)
==14486==  If you believe this happened as a result of a stack
==14486==  overflow in your program's main thread (unlikely but
==14486==  possible), you can try to increase the size of the
==14486==  main thread stack using the --main-stacksize= flag.
==14486==  The main thread stack size used in this run was 8388608.
==14486==
==14486== HEAP SUMMARY:
==14486==     in use at exit: 0 bytes in 0 blocks
==14486==   total heap usage: 0 allocs, 0 frees, 0 bytes allocated
==14486==
==14486== All heap blocks were freed -- no leaks are possible
==14486==
==14486== For counts of detected and suppressed errors, rerun with: -v
==14486== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
[1]    14486 segmentation fault  valgrind ./iwasm

Fixed with c47baf221fa8139ee45cd31e7dbf1a8310669d8e


Calculate number of commits based on HEAD, not master

Since we use release branches, the calculation of number of commits is not always based on master.  This, instead, looks at the current branch (aka HEAD).

👍

More readable:
--- first selection
+++ second selection
@@ -1,5 +1,5 @@
 git=$(sh /etc/profile; which git)
-number_of_commits=$("$git" rev-list master | wc -l | tr -d ' ')
+number_of_commits=$("$git" rev-list HEAD | wc -l | tr -d ' ')

 source_plist="`pwd`/Support/Info.plist"
 target_plist="$TARGET_BUILD_DIR/$INFOPLIST_PATH"
@@ -13,7 +13,6 @@

 for plist in ${sources[@]}; do
   if [ -f "$plist" ]; then
-      echo " warning: Setting $plist"  # this was for debugging
       /usr/libexec/PlistBuddy -c "Set :CFBundleVersion $number_of_commits" "$plist"
   fi
 done


fzf vim plugin prompting when swp file exists but open the file as empty in error

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
I'm still experiencing issues similar to #1365 when opening a file whose swp file already exists, but the behavior is different in that there is prompting but after choosing the option, the file is opened as empty and results in error state. :ls gives x flag on that buffer.
I guess the error may come from here:
https://github.com/junegunn/fzf/blob/ecc418ba77e52660ffdd9ed84727b12c3f377680/plugin/fzf.vim#L306-L316
The action key outputted at first line from fzf has been removed at line 306, but line 311 is still checking if a:lines 's length is greater than 1. Thus when selecting only 1 file, the augroup definition is skipped and prompting is showed to ask user for a swapchoice. However I don't know why after manually giving the choice, the file is opened in error state (maybe because of my other plugins).
Having tried commenting out the greater than 1 check, file can be opened successfully in read only mode.

Thus when selecting only 1 file, the augroup definition is skipped and prompting is showed to ask user for a swapchoice.

Yes, that's the intended behavior. See https://github.com/junegunn/fzf/commit/c4e5ee63bb4f68a80efd7f931b65c766281fbdea

However I don't know why after manually giving the choice, the file is opened in error state

I can't reproduce the problem.

(maybe because of my other plugins).

Probably. Can you check if you still have the issue with the following minimal vimrc?
vim -Nu <(curl https://gist.githubusercontent.com/junegunn/6936bf79fedd3a079aeb1dd2f3c81ef5/raw)

(https://gist.githubusercontent.com/junegunn/6936bf79fedd3a079aeb1dd2f3c81ef5/raw)

Using that minimal vimrc, it does successfully open a file with swp file. But there is no SwapExists prompting and the file is not opened in readonly mode. Is that expected?

It seems the problem is the coc.nvim plugin. Don't really know how it interacts with fzf and causes this bug though.

I have exactly the same issue, it seems to be caused by  vim-airline  in my case.


cmd, node/state: Move state-related flags and parsing functions into node/state subpackage

Based on #1016.

Codecov Report

Merging #1017 (aae9fee) into main (b595b74) will decrease coverage by 1.54%.
The diff coverage is 55.04%.

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   59.02%   57.47%   -1.55%
==========================================
  Files         133      134       +1
  Lines        8053     8275     +222
==========================================
+ Hits         4753     4756       +3
- Misses       2827     3044     +217
- Partials      473      475       +2

Impacted Files
Coverage Δ

cmd/env.go
76.47% <ø> (ø)

cmd/flags_core.go
42.37% <ø> (ø)

cmd/flags_header.go
46.42% <ø> (ø)

cmd/flags_misc.go
42.59% <ø> (ø)

cmd/flags_node.go
76.92% <ø> (ø)

cmd/flags_p2p.go
59.25% <ø> (ø)

cmd/flags_rpc.go
76.00% <ø> (ø)

node/node/config.go
89.58% <ø> (ø)

node/node/type.go
35.71% <ø> (ø)

node/state/opts.go
0.00% <0.00%> (ø)

... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Superseded by #1161


Fix NPE of RedissonConnectionFactory

When construct a RedissonConnectionFactory with Config argument, the Redisson client will not create before Spring calls afterPropertiesSet. Which means the factory must be registered as a Spring Bean or call afterPropertiesSet manually.
Registering multiple instances of same class to Spring is a bit inconvenient(@Qualifier everywhere) when the factory is only used by one service. Besides, afterPropertiesSet isn't designed to called manually so developer may forget to call it.
Better solution is creating the client at once when constructor is called.

All initialization logic should be invoked in afterPropertiesSet() not in constructor this is a rule of thumb.


v0.4.5

@benpatterson, @jzoldak ... Look ok?  I need to release again with the changes for the docs.

:+1:

:+1:


Make line length configurable

Hey @MaxOstrowski, this PR makes the maximal line length configurable.
clingofmt will read/create a .clingofmt file in TOML format, in this file you can define line_length = 20.
Would be nice if you give it a test round. :revolving_hearts:

Nice feature. Would be cool if you could also support configuration via pyproject.toml too. For some "inspiration" you can take a look at https://github.com/charliermarsh/ruff. It's a python linter written in rust.

I tested, and at least for my style-feeling this looks much better.
I'm still a bit puzzled about the newline after the head of a rule. Things like:
is_a(V, common) :- type(V).

come out as:
is_a(V, common) :-
    type(V).

which I think doesn't look as good.
Also:
a :- something_longer(X), foo(X).

with a long linelength will come out as:
a :-
    something_longer(X), foo(X).

.. I'm still a bit puzzled about the newline after the head of a rule. Things like:
is_a(V, common) :- type(V).

come out as:
is_a(V, common) :-
    type(V).

In most cases I prefer to separate head and body that is why the line break after the :- is a hard one. Otherwise it would allow things like that:
a(x) :- a_somehow_longer_predicate(X),
    short(X).

Which I think looks ugly too.
I'm not happy with the feature .. while it allows to have multiple body atoms on one line, it also often disallows having them on separate lines.
I tend to prefer the style with one atom per line also because it is more consistent .. I guess i prefer vertical reading .. one could also argue that the vertical style makes reading diffs easier.
Maybe you are interested in the feature discussed here PR #86

You are right, I guess this is a game of preference.
I still think that it could be a useful feature, and I also think that it should be extended to the head of the rule. Simply because of the fact that with '--linelenght=0' you will always have your head separated from the body and conserve your vertical reading.
With the diffs, I agree that your method is superior.


fix(TabBar): adds column container story for scrolling tab content

Description
This PR adds a story in TabBar to show how adding a container helps expected scroll behavior when  TabBar content has multiple rows
References
LUI-717
Testing

clone branch
go to Tabar Multiple Rows story
navigate to Tab 1
press down arrow to set focus on first row
continue pressing down, former rows should not be visiable

Automation
Checklist

[ ] all commented code has been removed
[ ] any new console issues have been resolved
[ ] code linter and formatter has been run
[ ] test coverage meets repo requirements
[ ] PR name matches the expected semantic-commit syntax

This is closer, but the Y position is still off.  The left side is good though!

Much better, thank you! Only weird thing I'm seeing now is that the TabBar itself scrolls. Can we make sure it has the right width on it so that doesn't happen? Or an autoResizeWidth: true?

Much better, thank you! Only weird thing I'm seeing now is that the TabBar itself scrolls. Can we make sure it has the right width on it so that doesn't happen? Or an autoResizeWidth: true?
This is fixed now


"movement/0.json" file did not generate properly.

After entering prompt "run 3", the demo has been working well until i got this error:
Klaus Mueller persona.scratch.importance_trigger_curr:: 145
150
aldhfoaf/????
the Ville:Dorm for Oak Hill College:Klaus Mueller's room:bed
Traceback (most recent call last):
File "D:\generative_agents\reverie\backend_server\reverie.py", line 468, in open_server
rs.start_server(int_count)
File "D:\generative_agents\reverie\backend_server\reverie.py", line 401, in start_server
with open(curr_move_file, "w") as outfile:
FileNotFoundError: [Errno 2] No such file or directory: '../../environment/frontend_server/storage/test-simulation3/movement/0.json'
Can anyone help me out of this pls?

check #2

check #2

thx, it works


[stable/graylog] Move hard coded parts of graylog.conf to values.yaml

Proposed fix for https://github.com/helm/charts/issues/13602, creates a more flexible ConfigMap for graylog.conf.
This allows pretty much every aspect of graylog.conf to be defined in values.yaml, instead of hard coding most of it in the ConfigMap template.

This should be superseeded by https://github.com/helm/charts/pull/12983, which allows additional content to be appened to graylog.conf using new entries in values.yaml.
Thank you for support.
Best regards.


Fails to get cookies on iOS

It works as expected on Android, but on iOS (11.0+) it returns empty array. Flutter code is equivalent for both platforms, so I suppose there is an issue when interacting with native iOS cookie manager.

Hi! I would like to help but I need some input from you.

Could you please share MRE(Minimum reproducible example)?
After setting cookies could you please add await Future.delay(Duration(seconds:3)), and then get cookies again. Any result appears?

HI @fryette, thanks for quick response.

Basically, I open a website in the webview (e.g. youtube.com). Then I use the cookie manager to get cookies from that website like in example final gotCookies = await cookieManager.getCookies('https://youtube.com');
When I do that on Android, everything works as expected and I get an array of cookies. Doing the same on iOS device returns an empty array.
I do not set any cookies manually, so not sure if adding a delay would help.

Thank you!

It would be nice to have a function like getAllCookies.
In hasCookies, something says there is a cookie...
I don't know what cookies are in flutter.

@JosephNK do you know a native way to implement it?

@fryette  I checked the ios native source.
When you call getCookies(null), you get all cookies. :)

Strangely, when calling getCookies(null) in ios, there are times when cookie cannot be fetched.

Please consider importing as HTTPCookieStorage.shared.cookies, not WKWebsiteDataStore.default().httpCookieStore.

@JosephNK but for android you cannot, right?

@fryette PR[#21] please check.

@JosephNK will check it today or tomorrow morning and will provide a new version if everything is OK

i have same issue. I can't get cookie from ios.

Same problem for me.

@seukaiwokeo @i-Senku could you please grab PR(https://github.com/fryette/webview_cookie_manager/pull/21) and check it?
It can be done with:
  webview_cookie_manager:
    git:
      url: https://github.com/JosephNK/webview_cookie_manager.git

@fryette  It's doesn't work. getCookies functions returned empty Cookie List.

@i-Senku
When you set getCookies(null), in the case of Android, an empty list is correct. The reason is that Android can't get all the lists. And in the case of iOS, a list should appear. Did you test on Android? Did you do it with iOS?

@JosephNK yep i tested on IOS with offical webview package. But it return empty list. Did you tested on IOS ? Because it's doesnt work on my project :(

@i-Senku yeb i tested on iOS. It works in my project with a modified version.
After modifying as below in the pubspec.yaml file
webview_cookie_manager:
    git:
      url: https://github.com/JosephNK/webview_cookie_manager.git
      ref: 65979e2064fcdf5d98c0b2159ca5f4873f0259d8

After executing the command as below
$ flutter clean
$ flutter pub get

Try build
Run build iOS

@JosephNK
Webview Scene. I added breakpoint to getCookies function and it looks empty. Where am i doing wrong ?
    return SafeArea(
        child: Scaffold(
      body: WebView(
        initialUrl: "https://www.instagram.com/accounts/login/",
        javascriptMode: JavascriptMode.unrestricted,
        onPageFinished: (url) async {
          var cookies = await cookieManager.getCookies(url);
          cookies.forEach((element) {
            print(element.name);
          });
        },
      ),
    ));

pubspec file.

@i-Senku
getCookies(url) to getCookies(null)
can u try?

@i-Senku
When flutter passes the url value as a parameter, if you check the iOS native code, there may be cases where the host of the url value does not match when searching for the cookie value in the cookie storage.  For example, in case of a wildcard, a case of mismatch occurs.

idk why i tried this code ( getCookies(null) ). What should I do now? Do you have a solution? I want to receive cookies from Instagram

@i-Senku @fryette
Oops... I think the error is... I think you need to check the Future<List> getCookies(String currentUrl) function.

@i-Senku @fryette
Fixed Invalid Char issue when creating a cookie for darts. https://github.com/fryette/webview_cookie_manager/pull/21/commits/70e8e0cbc7cfacfbb7abb7917e70a78a0744681b

ı fixed get cookies problem in ios. I founded problem in getCookies function. This code working
func getCookies(url : String,result: @escaping FlutterResult){
    var cookieList = [[String: Any]]()
    let cookieStore = WKWebsiteDataStore.default().httpCookieStore
    cookieStore.getAllCookies { (cookies) in
        for cookie in cookies {
            cookieList.append(cookieToDictionary(cookie: cookie))
        }
        result(cookieList)
    }
}

@JosephNK maybe we also can include @i-Senku changes to PR?
Or you fix it as well?

@fryette I don't know what kind of code he solved. I already PR the invalied char issue.

@fryette u check out the PR code. or try testing.

@JosephNK give me a few hours

@JosephNK merged and 1.0.4 version provided.
Thx for your contribution!
If anyone has problems with the new version, feel free to reopen an issue or create a new one

@fryette Might be a bit late, tried to raise PR with a fix right away but did not have permission for it. 🤣
In my particular case, the problem with was the part of logic that did URL check. it was too strict, so if you were on a website with a prefix (e.g. m.website.com), the .contains() check for URL match failed and no cookies were returned. The fix was about doing a mirrored check to account for website prefixes. Hope it could be helpful

@fryette Might be a bit late, tried to raise PR with a fix right away but did not have permission for it. 🤣
In my particular case, the problem with was the part of logic that did URL check. it was too strict, so if you were on a website with a prefix (e.g. m.website.com), the .contains() check for URL match failed and no cookies were returned. The fix was about doing a mirrored check to account for website prefixes. Hope it could be helpful

@fryette Actually It looks like the problem is still there (unless you set URL tonull). I can't add a branch or a PR with the fix, could you please allow it?

@fryette Actually It looks like the problem is still there (unless you set URL tonull). I can't add a branch or a PR with the fix, could you please allow it?

@iverc Feel free to fork repo and then you can create a PR with fix

@iverc Feel free to fork repo and then you can create a PR with fix

@fryette https://github.com/fryette/webview_cookie_manager/pull/29

@fryette https://github.com/fryette/webview_cookie_manager/pull/29

@iverc new version availbale (1.0.6)

@iverc new version availbale (1.0.6)


Keyboard shortcuts (Not inside the editor)

Describe the feature you'd like
I know there are shortcuts available inside the editor, but I'd love to see more added outside of the text editor.  For example

"E" to edit a page, chapter, book, (depending which screen you're on)
"N" to create a new page
"C" to create a new chapter
"M to move
SHIFT + DEL to delete
etc

Describe the benefits this feature would bring to BookStack users
This will greatly increase productivity.

They've been implementing Confluence at work.
Figured I'd share their Keyboard Shortcuts as Inspiration

Just adding an implementation note, Will need to consider accessibility:
https://www.w3.org/WAI/WCAG21/Understanding/character-key-shortcuts.html

Didn't notice this issue when I first posted my own, so I'll just include my suggestion here since it was closed as a potential duplicate.
BookStack is already going for the Bookshelf > Book > Chapter > Page aesthetic anyway, so for an end-user case, I think accesskey navigation would be nice. So that you can move between chapters, and pages under each chapter, using your arrow keys or similar.
@ssddanbrown pointed out to me that many users probably already use the arrow keys for navigation or similar anyway, so perhaps something like shift or control plus arrow keys instead of direct access would be better? I've seen sites use comma and period as a back and forward button, so that's also an option.

As a recent Confluence convert, I'm thrilled with BookStack but really miss the 'e'dit shortcut. While this feature request matures, here's a stopgap to get the 'e'dit shortcut today.
Settings -> Custom HTML Head Content
<script src="//cdnjs.cloudflare.com/ajax/libs/mousetrap/1.4.6/mousetrap.min.js"></script>
<script>
  Mousetrap.bind('e', function(e) {
    if (window.location.href.includes('/page/') && !window.location.href.endsWith('/edit')) {
      window.location.href=window.location.href+'/edit';
    }
  });
</script>

BookStack is already going for the Bookshelf > Book > Chapter > Page aesthetic anyway, so for an end-user case, I think accesskey navigation would be nice. So that you can move between chapters, and pages under each chapter, using your arrow keys or similar.
@ssddanbrown pointed out to me that many users probably already use the arrow keys for navigation or similar anyway, so perhaps something like shift or control plus arrow keys instead of direct access would be better? I've seen sites use comma and period as a back and forward button, so that's also an option.

Just a little thought about this, considering the apprehension for taking permanent control over the accesskeys could simply be a config setting. If it is left as disabled by default, people like me will still be able to make use of it instead of using potential hacky solutions to do it.
Personally, I prefer Ctrl + left or right accesskey to navigate.

BookStack is already going for the Bookshelf > Book > Chapter > Page aesthetic anyway, so for an end-user case, I think accesskey navigation would be nice. So that you can move between chapters, and pages under each chapter, using your arrow keys or similar.
@ssddanbrown pointed out to me that many users probably already use the arrow keys for navigation or similar anyway, so perhaps something like shift or control plus arrow keys instead of direct access would be better? I've seen sites use comma and period as a back and forward button, so that's also an option.

Just a little thought about this, considering the apprehension for taking permanent control over the accesskeys could simply be a config setting. If it is left as disabled by default, people like me will still be able to make use of it instead of using potential hacky solutions to do it.
Personally, I prefer Ctrl + left or right accesskey to navigate.

I also come from Confluence (use it at work).
I use Bookstack since 2 years for my private and freelancer IT Documentation and I'm still hitting E on my keyboard to enter editor when reading a page.

UI Shortcut system added via PR #3830. Will be part of the next feature release.

Thank you very much for this awesome release - I love it!


Translation files synchronization

both files has minor defects

https://gist.github.com/dbu/5883029


Add Bitnami to Application Definition

Bitnami logo can be found here:
https://bitnami.com/about-us/logos

Added Bitnami to v0.9.3.


Remove icon model from userAssetsCollection if upload fails

Fixes #11980

Acceptance

[ ] When the upload fails, the icon is not in "Your uploads" tab.

Why the loading appears at the bottom of the screen?

Because I only recorded half screen 😂

Working like a charm"ander".


Feature/backend functionality

Added boolean, string, number and function validation.
Also added assert.
Added alternatives.

Also eye candy:
> mocha -r test/_setup.js --compilers js:babel-register && eslint lib

  alternatives
    ✓ Validates with an array
    ✓ .try injects additional

  any
    ✓ works for any values
    ✓ takes optional values
    ✓ requires values correctly
    ✓ disallows forbidden values
    ✓ allows valid values
    ✓ disallows invalid values

  array
    ✓ invalidates items that are not arrays
    ✓ allows sparse arrays only when specified
    ✓ wraps single elements only when specified
    ✓ applies schemas to array items
    ✓ requires ordered values
    ✓ enforces min, max, and length
    ✓ checks unique items

  boolean
    ✓ will only validate booleans

  function
    ✓ will only validate functions
    ✓ checks arity
    ✓ checks min arity
    ✓ checks max arity

  number
    ✓ will only validate valid numbers
    ✓ only allows integers
    ✓ checks min value
    ✓ checks max value
    ✓ checks greater than
    ✓ checks less than
    ✓ checks positive
    ✓ checks negative
    ✓ checks multiple of
    ✓ checks max precision

  object
    keys
      ✓ restricts unknown
      ✓ allows unknown when flagged
      ✓ runs subvalidations

  string
    ✓ will only validate strings
    - will validate insensitive
    ✓ will validate min string length
    ✓ will validate max string length
    ✓ will validate string length
    ✓ will validate a credit card
    ✓ will match against a regex
    ✓ will validate alphanumeric
    ✓ will validate tokens
    ✓ will validate emails
    ✓ will validate IPs
    ✓ will validate URIs
    ✓ will validate GUIDs
    ✓ will validate HEX
    ✓ will validate hostnames
    ✓ will validate lowercase
    ✓ will validate uppercase
    ✓ will validate trim
    ✓ will validate iso dates

  validator
    assert
      ✓ throws jojen errors
      ✓ throws error with prefix
      ✓ throws does not throw on validation

  54 passing (142ms)
  1 pending

Running head-to-head benchmark for Joi vs Jojen
Jojen completed in 2682ms
Joi completed in 6415ms

Tests be broken, but looks good with fixes :)


Used ScheduledPurgeDate for both KV, MHSM

The previous property was calculated so didn't exist from the REST-based
call. Also updated the api-version to the latest stable control plane
version.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

@heaths: Before merging this PR, I'd like to try running the cleanup pipeline using this PR.

Fix prevents script from failing, but from the logs it appears we still need to do more to actually delete/purge the resources.

Fix prevents script from failing, but from the logs it appears we still need to do more to actually delete/purge the resources.

The script runs on a schedule as well, so it will keep trying and when the purge date expires, they will finally get cleaned up on the next run. That's how it was designed and has been working. What's concerning is how many vaults and HSMs have purge protection enabled. It should almost never be necessary. I started a thread internally to address going forward.

I thought it was supposed to merge automatically once the final pipeline was approved.


API - Clarify Upgrade Path for Deprecated Functionality

Reading through the loader documentation, I noticed that this.exec is deprecated, but the docs don't mention why it was deprecated or whether there is a different API that should be used in its place. This would be helpful information for loader authors, especially since webpack-maintained loaders that rely on this functionality (e.g.) still appear to use this API.

Sounds reasonable, thanks for pointing this out @smably. Once we figure out the answer to this would you be interested in submitting a pr to resolve this?
@webpack/documentation-team can someone point us to the replacement method or new workflow that replaced this.exec?

Yes, I'd be happy to open a PR to fix this!

You can replace it with the following function:
const Module = require("module");
function exec(code, filename) {
  const module = new Module(filename, this);
  module.paths = Module._nodeModulePaths(this.context);
  module.filename = filename;
  module._compile(code, filename);
  return module.exports;
}

@smably I know it's been a little while but does the above comment answer your question? Would you still be interested in submitting a PR?

I've been using floatdrop/require-from-string for this 🤷♂

This doesn't seem to work?
module.exports = function (content) {
    const result = exec.call(this, content, this.resource);
    console.log('RESULT', result);
}

const Module = require("module");
function exec(code, filename) {
    const module = new Module(filename, this);
    module.paths = Module._nodeModulePaths(this.context);
    module.filename = filename;
    module._compile(code, filename);
    return module.exports;
}

It can't handle export default:
ERROR in   Error: Child compilation failed:
  Module build failed (from ./loaders/js2json-loader.js):
  /home/mpen/Projects/crap/aaa-test-project/src/pwa.webmanifest.ts:18
  export default manifest;
  ^^^^^^
  SyntaxError: Unexpected token 'export


Version 4.1.1 is missing the build directory

The recently published version 4.1.1 does not contain the build dir

I'm on it. Didn't use npm for a century — turned out they changed the scripts lifecycle. Will publish a new version in a few minutes. Sorry for the fuckup and thanks for reporting this

Fixed and published


Scanner tweaks

After this land I'm going to start to work on the parser again.

Coverage increased (+0.05%) to 90.62% when pulling 7b9b4635c18953117840791aa201a40f625df6f2 on tweaks into 191d30a672e43a5b25dc4513e6c4191f6d54c697 on master.

This pull request introduces 1 alert when merging 7b9b4635c18953117840791aa201a40f625df6f2 into 191d30a672e43a5b25dc4513e6c4191f6d54c697 - view on LGTM.com
new alerts:

1 for Useless assignment to local variable

Comment posted by LGTM.com


Applying govuk-lint (just app folder)

should be also run it against /spec?

If we are doing this we should also set it up

as a pre-commit hook
as a check in travis CI

else it will just slowly rot again.

I agree with the check in Travis.

@arnau @gidsg Can you take another quick look? I've added the spec folder files too and addressed some of the comments.

@fjavierm LGTM. Will be happy to approve if you can do another commit adding same check in Travis CI. I think you can do something like this: https://github.com/alphagov/gsd-view-data/blob/399bb876820dae8e011c45a9c1a2a4787a00a666/.travis.yml#L38


buddy list: Create "away" feature.

The ~4 JS commits at the front here are probably candidates for a partial merge.

First ~5 commits look great, merged, thanks @showell!

Closing this since it was merged.  @timabbott I think the reason you didn't close this was a temporary GH outage.  I'll bump #11103, which I think will help us refine the feature a bit.


Addition of VRF pools or ranges

As we group customers and have thousands of VRFs, some kind of pool or reserved ranges for VRFs would be good. The name range for this feature would not interfere with current pools, hence I included it.

Do we want to have separate pools for VRF or should it be the same pools, just with some information pertaining to prefixes and other for VRFs? @garberg ??

A super sweet addition to this would be if tags or certain extra attributes could be connected to always appear when adding VRFs within these ranges.

I'll add to this request - would love to have pools of VRF RDs to automatically allocate from.


Can not register bubbleSets for core since bubbleSets already exists in the prototype and can not be overridden

hi there!
I used extension in  pageA.
I registered extension with:
   cytoscape.use(plugin)

when pageA loaded first time, it show what expected. But when leave pageA and back again. pageA crashed.
and it will throw this error when the component is hot replaced(by wepack-dev-server).
 Can not register `bubbleSets` for `core` since `bubbleSets` already exists in the prototype and can not be overridden

seems like you should ask the cytoscape guys directly since this plugin cannot influence the registration process


Adding framework tests to experimental gradle build

This pull request adds GearVRf-Tests/framework-tests and GearVRf-Tests/gvr-unittestutils to the experimental gradle build in GVRf/tools/Framework
GearVRF DCO: signed off by Nola Donato<EMAIL_ADDRESS>

I think I have the tests executing. Whew.
To get the change on top of your branch git fetch git@github.com:liaxim/GearVRf.git exgradle-test&&git cherry-pick b205b006075eb31097d9053927833830563fca49
Or here: https://github.com/liaxim/GearVRf/tree/exgradle-test

Thanks so much
Sent from my Verizon, Samsung Galaxy smartphone
-------- Original message --------
From: Mihail<EMAIL_ADDRESS>Date: 10/5/16 8:31 AM (GMT-08:00)
To: Samsung/GearVRf<EMAIL_ADDRESS>Cc: Nola Donato<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Samsung/GearVRf] Adding framework tests to experimental gradle build (#877)
I think I have the tests executing. Whew.
To get the change on top of your branch git fetch git@github.com:liaxim/GearVRf.git exgradle-test&&git cherry-pick b205b006075eb31097d9053927833830563fca49
Or here: https://github.com/liaxim/GearVRf/tree/exgradle-test

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/pull/877#issuecomment-251709602, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQw1SyGIMbFgRBqt_o21b3kt6KY-gC4Jks5qw8KXgaJpZM4KOOYi.

Planning to merge this so we can build upon it. I will add my fix afterwards. Will wait for comments until Tuesday morning.

Is this checked in?
Sent from my Verizon, Samsung Galaxy smartphone
-------- Original message --------
From: Mihail<EMAIL_ADDRESS>Date: 10/5/16 8:31 AM (GMT-08:00)
To: Samsung/GearVRf<EMAIL_ADDRESS>Cc: Nola Donato<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Samsung/GearVRf] Adding framework tests to experimental gradle build (#877)
I think I have the tests executing. Whew.
To get the change on top of your branch git fetch git@github.com:liaxim/GearVRf.git exgradle-test&&git cherry-pick b205b006075eb31097d9053927833830563fca49
Or here: https://github.com/liaxim/GearVRf/tree/exgradle-test
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/pull/877#issuecomment-251709602, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQw1SyGIMbFgRBqt_o21b3kt6KY-gC4Jks5qw8KXgaJpZM4KOOYi.

Yes, merged.


MudBaseInput: Make OnBlurred async

Description
Fixes: https://github.com/MudBlazor/MudBlazor/issues/6322
Wasn't catching exception since on blurr wasn't awaited (async void problem)
I believe since OnBlurred was protected internal it's not breaking change to change the signature
How Has This Been Tested?
New unit test + checked visually on https://try.mudblazor.com/snippet/QOwdkmvIplIxkslV
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Doesn't fixes the KeyDown down since the method isn't internal in MudBaseInput

It seems that my recent change resulted in a breaking change for those who inherit this type and previously used OnBlurred. I take full responsibility for this mistake. I was confused by the use of the word "internal" in the method signature and wrongly assumed that it would be a safe change since I thought the method was only visible within the library. However, it turns out that the method is actually marked as protected internal, which makes it visible to anyone who inherits MudBaseInput.

Well, the break already happened, and we don't guarantee that protected API won't be changed, so I think no revert is necessary.


Update Middleware::history() docblock to note $container type

Middleware::history() accepts as its single argument an array or an object implementing \ArrayAccess.
The docblock for this method currently states the type for the argument as: @param array $container. The current docblock lacks the \ArrayAccess type.
When passing in an object that implements \ArrayAccess, PHPStorm highlights to me that, due to the docblock, the wrong type is being passed. This is due to the docblock being incorrect.
This change updates the docblock for \Middleware::history() to correctly reflect the type for the argument.

Thanks!


Remove "refresh" thread and just set S3 user script ACL to public-read (resolves #1600, #1516)

Just throwing this out there, not really 100% sure that this is the best solution.
The refresh thread isn't really guaranteed to be scheduled within its 2 minute window, especially given the number of other threads that are running in the leader process. This would remove the refresh thread entirely, and set the ACL of the user script object to public-read instead. Unfortunately I can't seem to get a straight answer on the consistency of the PUT object?acl operation. It seems to take effect right away, but I'm not totally sure.

I would expect that the operation is eventually consistent, so this might also be racey. I'll look into it, it might make sense for the workers to just retry during hot deployment until the script is available.

On second thought, we only need the ACL to have taken affect by the time the IAM credentials expire, right? I think that's probably safe

Sadly, even if a link is public, you can't read it with an expired IAM token in the parameters. I did some testing and it looks like the credential expiry is checked before the ACL for the object is checked, which results in an early 403. In this PR, I make sure the link isn't authenticated with any credentials to avoid that. So if the PUT is eventually consistent, this is a race. I'll try to test this a bit today by rapidly creating objects & changing ACLs on them to see if I can trigger the eventually consistent behavior. It won't give a definitive answer, but it should at least provide some data.
(The lack of credentials also means there is no expiration on the public URL.)

@joelarmstrong, can key.set_canned_acl('public-read') be called when the job store is created?

Unfortunately I don't think so, because the file name (i.e. "key") isn't known at that time. We could potentially work around that by making sure the hot-deployed user script always has the same name, like "user-script", and set that to public-read on creation.  But then getPublicURL() would continue to have the same problem (though I'm not sure it's actually used anywhere else).
I could contact AWS and ask what the consistency on the "PUT acl" operation is. It seems to take effect immediately because it hasn't given me any trouble yet, but that doesn't mean all that much.

What do you suggest? Merge as is? Wait and think about it? You could also leave in the old code. Would that give two chances to avoid race conditions?

I would say merge as-is, I haven't run into any issues with it on my side and I use hot-deployment pretty heavily. The consistency issues are mostly theoretical.
Leaving in the old code won't help. It just refreshes the AWS credentials, but boto will do that automatically if needed.


Feature/routing updates

What? and Why?

What does this pull request change/fix? Why was it necessary?
Store should not be queuing notifications, this logic has been moved to sdx-collect.

Checklist

[x] CHANGELOG.md updated? (if required)

Codecov Report

Merging #72 into master will increase coverage by 6.67%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   85.74%   92.41%   +6.67%
==========================================
  Files           6        5       -1
  Lines         484      343     -141
==========================================
- Hits          415      317      -98
+ Misses         69       26      -43

Impacted Files
Coverage Δ

settings.py
100% <ø> (ø)
:arrow_up:

server.py
87.85% <ø> (+2.63%)
:arrow_up:

tests/test_store.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17ea37...e0a07d0. Read the comment docs.

 (5) Store/Collect Routing Updates


expression: disable constrant flod for control expressions

What problem does this PR solve?
solve the constrant fold case in https://github.com/pingcap/tidb/pull/19367
What is changed and how it works?
disable the constrant fold in control expressions, such as if(), ifnull() and case... when....
Check List
Tests

Unit test in tidb

Related changes

Need to cherry-pick to the release branch

unnecessary change parser to achieve it.


Improve Navbar and Scroll Effect

close #354
Hi, I've Improved the padding and margin in Navbar and add smooth scroll animation.
please consider merging with the main branch.

Can you share the screenshot of the changes as it will be easy to compare with them.


Android: Error occurred while copying

I am building an Ionic app with capacitor, and am trying to generate the resources as specified in the docs. It works great for iOS and I get all the icons correctly generated. When I run it for android, I get this error. Then when I run my app after a rebuild and sync it only copied the splash screen correctly. The app icon everywhere else is still the default capacitor icon.
This is the error I'm getting:
❯ cordova-res android --skip-config --copy
Generated 18 resources for Android
WARN:   Error occurred while copying resources/android/icon/mdpi-foreground.png
WARN:   Error occurred while copying resources/android/icon/hdpi-foreground.png
WARN:   Error occurred while copying resources/android/icon/xhdpi-foreground.png
WARN:   Error occurred while copying resources/android/icon/xxhdpi-foreground.png
WARN:   Error occurred while copying resources/android/icon/xxxhdpi-foreground.png
Copied 26 resource items to Android

In my resources directory I don't have files with these names. Instead they're named:
resources/android/icon/drawable-hdpi-icon.png
resources/android/icon/drawable-ldpi-icon.png
resources/android/icon/drawable-mdpi-icon.png
resources/android/icon/drawable-xhdpi-icon.png
resources/android/icon/drawable-xxhdpi-icon.png
resources/android/icon/drawable-xxxhdpi-icon.png

Which makes sense why they're not getting copied. Is there possibly something I'm doing wrong? My icon is following the directions. It's in the resources folder called icon.png, and it's 1024x1024. I get no errors with iOS, so I don't think it's something I'm doing wrong, but I'm absolutely not ruling that out.

I have been having exactly the same issue on v0.15.1. This was not an issue on v0.14.0, so I downgraded to that version.

@johnbwoodruff These are just warnings. It's because the copy process expecting generated Adaptive Icon foregrounds, but since you're not using Adaptive Icons, they aren't there. It's fine to ignore, and this won't be an issue by 1.0.0 (see https://github.com/ionic-team/cordova-res/issues/113).

This issue is still there.

I agree, this is still an issue. This a true problem because the launch app of the icon remains capacitor's picture, in my case.

I have the same issue

same issue here

the issue still exists...

I also encountered the same issue

the issue still exists...

After displaying the warning, the icon of the application is still the logo of the capacitor.

any body got how resolve this?
I could not make the foreground image. But android studio has an easy option
https://developer.android.com/studio/write/image-asset-studio?hl=es-419

How can I remove the standard ionic app icon then? Because the ic_launcher_foreground.png will be generated with the ionic icon instead of my own app icon..

I think this should be re-opened. I created a blank starter, added the android and ios platforms, and then did cordova-res with a new icon, which generated the warnings. Project is here: https://github.com/kensodemann/delete-me
You can verify here, for example: https://github.com/kensodemann/delete-me/tree/master/android/app/src/main/res/mipmap-xxhdpi
npx cap open android and then run on a device or emulator and it will use the default cap icon and not the updated tea icon, at least on modern versions of Android. I have not tried on older versions of Android yet.

if you generate the  ic_launcher_foreground.png with android studio it will overwrite this icon. You dont need to delete or if you want delete manaually. but is unnsecasary

Same issue, with a blank ionic/capacitor app..
Ios image splash and icon generates OK, but on android the icon is not replaced and it's still showing the capacitor one.
Splash screen works on both ios and android.
Run this:
cordova-res android --skip-config --copy
And also got bunch of warnings and icons didn't get replaced:
Generated 18 resources for Android
WARN:	Error occurred while copying resources/android/icon/mdpi-foreground.png
WARN:	Error occurred while copying resources/android/icon/hdpi-foreground.png
WARN:	Error occurred while copying resources/android/icon/xhdpi-foreground.png
WARN:	Error occurred while copying resources/android/icon/xxhdpi-foreground.png
WARN:	Error occurred while copying resources/android/icon/xxxhdpi-foreground.png
Copied 26 resource items to Android

@gregmeszaros - follow the instructions here to generate the *-foreground.png files: https://github.com/ionic-team/cordova-res#adaptive-icons

This issue is still there.

Use the following steps to generate. However, you need to create a file as mentioned.
Adaptive Icons
Android Adaptive Icons are also supported. If you choose to use them, create the following additional file(s):
resources/android/icon-foreground.png must be at least 432×432px
resources/android/icon-background.png must be at least 432×432px
A color may also be used for the icon background by specifying the --icon-background-source option with a hex color code, e.g. --icon-background-source '#FFFFFF'.
Regular Android icons will still be generated as a fallback for Android devices that do not support adaptive icons.
📝 Note: For Cordova apps, Cordova 9+ and cordova-android 8+ is required.
Link: https://github.com/ionic-team/cordova-res#adaptive-icons

This is not clear to me. Can you tell me the steps to avoid this issue?

Did you create the mentioned files and placed under the named folders? You need to create resources folder if not created

@stNamring Can you tell me how to create those 2 files? I have a resources folder and it has icon 1024x1024 and splash 2732x2732

@Sampath-Lokuge I have used my same icon file and created icon-foreground.png with the mentioned size. Also, created icon-background.png with the same size with background color of my icon.

@stNamring Can you tell me the other steps also after creating those 2 files?

@Sampath-Lokuge then, you fire that command to generate resources.

you can do it from android studio, just follow this steps from the developers page: https://developer.android.com/studio/write/image-asset-studio
I've made a short video on how to change the icon
https://www.youtube.com/watch?v=QOsDG5RSQ-Q&feature=youtu.be&ab_channel=RockyLon

I've created an icon with the name according to the documentation and in the resources/android/icon folder and then run the command cordova-res android --skip-config --copy
and that doesn't solve the problem.
You just copy from the documentation and it doesn't work

I'm also facing the same issue. Did anyone found the solution?

Guys, I believe it is a mistake when generating the images using cordova-res, I temporarily solved it as follows:
Go to: resources \ android \ icon
Copy the files:
"drawable-mdpi-icon.png"
"drawable-hdpi-icon.png"
"drawable-xhdpi-icon.png"
"drawable-xxhdpi-icon.png"
"drawable-xxxhdpi-icon.png"
Paste in the same folder: resources \ android \ icon
Rename the copied files to:
"mdpi-foreground.png"
"hdpi-foreground.png"
"xhdpi-foreground.png"
"xxhdpi-foreground.png"
"xxxhdpi-foreground.png"
I ran the command "ionic capacitor sync" to synchronize the images, and then "ionic capacitor run" to run on android.
As I said, it is a temporary resolution, I believe that the way in which images are generated today by cordova-res will be corrected

I've created an icon with the name according to the documentation and in the resources/android/icon folder and then run the command cordova-res android --skip-config --copy
and that doesn't solve the problem.
@stNamring You just copy from the documentation and it doesn't work

You may need script to copy if it does not copy to resource folder.

On the plugin page i.e [https://github.com/ionic-team/cordova-res](Cordova-res repo) , You need to look at this particular section. The adaptive icons are required for Android Platform and you need to put these image at resources\android directory.

Update, fix?

Update, fix?

@Hembi You need to do it manually. See: https://youtu.be/QOsDG5RSQ-Q

@Hembi You need to do it manually. See: https://youtu.be/QOsDG5RSQ-Q

@Hembi You need to do it manually. See: https://youtu.be/QOsDG5RSQ-Q

Thank you, I found this solution, but fix the command would be a better solution.

@Hembi You need to do it manually. See: https://youtu.be/QOsDG5RSQ-Q

Thank you, I found this solution, but fix the command would be a better solution.

@Hembi Yes, That will come with Capacitor 3+: https://github.com/ionic-team/cordova-res/issues/118

@Hembi Yes, That will come with Capacitor 3+: https://github.com/ionic-team/cordova-res/issues/118

Hello! Just in casy anywone is still struggling to find a solution this worked for me:
Step 1
Create a 432x432 black .png file. I used photopea.com.  Then save it as "icon-background.png".
Please note that I created a black image since I need a black background for my icon and I went for the minimum 432x432 since its only black I dont need it to scale well to other resolutions.
Step 2
Create a 1024x1024  .png file and save it as "icon-foreground.png".
In this case if you want the actual background you provided in the previous step to show your icon should have transparency.  In my case I just provided an exact copy of my icon since I dont mind it being placed on top of my black background .
Step 3
Now you can run cordova-res android command and it should work.

I have migrated to Capacitor 3.0 beta 1 and this problem still happens.

You need script to copy the generated resources to the designated Android and iOS folder.

@stNamring worked but this is an alternative to get past the issue but the issue persists on cordova-res
if you dont have medium premium then the readme for the solution linked by stNamring is here: https://gist.github.com/dalezak/a6b1de39091f4ace220695d72717ac71

I have the same problem for andorid platform

Thanks @RockyLon . Your solution worked perfectly. I hope that ionic can fix this issue.

@RockyLon thanks!

For clarity, the files needed for this to work should be organized like this:
resources/
├── android/
│   ├── icon-background.png
│   └── icon-foreground.png
├── icon.png
└── splash.png

I kept getting these copying errors even after adding the android-background.png and androind-foreground images, because I had added them to the resources folder, not resources/android because I misread the documentation, and it took me a while to figure it out.

resources/
├── android/
│   ├── icon-background.png
│   └── icon-foreground.png
├── icon.png
└── splash.png

thanks it is now working!

I lost several dollars that I had to return to customers just because of the changes in these icons, people do a lot of bestery.

Hello! Just in casy anywone is still struggling to find a solution this worked for me:
Step 1
Create a 432x432 black .png file. I used photopea.com. Then save it as "icon-background.png".
Please note that I created a black image since I need a black background for my icon and I went for the minimum 432x432 since its only black I dont need it to scale well to other resolutions.
Step 2
Create a 1024x1024 .png file and save it as "icon-foreground.png".
In this case if you want the actual background you provided in the previous step to show your icon should have transparency. In my case I just provided an exact copy of my icon since I dont mind it being placed on top of my black background .
Step 3
Now you can run cordova-res android command and it should work.

Thank you!!!!

Change your application icon manually
go to Android Studio
click on APP
after File > new  > imge Asset
and set Application icon manually after you get any error so read that line if it like  not found so remove and run that works Perfactally

If a folder 'android' does not exist within a resources, it must be created
create two image in resources/android
resources/android/icon-foreground.png must be at least 432×432px
resources/android/icon-background.png must be at least 432×432px

Will review for 1.0 milestone

resources/
├── android/
│   ├── icon-background.png
│   └── icon-foreground.png
├── icon.png
└── splash.png

thanks it is now working!

ERROR:  Missing valid source image for Android icons (sources: resources/android/icon.png, resources/android/icon.jpg, resources/android/icon.jpeg, resources/icon.png, resources/icon.jpg, resources/icon.jpeg)
encounter an error

I was missing sudo

resources/
├── android/
│   ├── icon-background.png
│   └── icon-foreground.png
├── icon.png
└── splash.png

thanks it is now working!

ERROR: Missing valid source image for Android icons (sources: resources/android/icon.png, resources/android/icon.jpg, resources/android/icon.jpeg, resources/icon.png, resources/icon.jpg, resources/icon.jpeg)
encounter an error

It says the mentioned files are not present in the desired location. Check the file names and the folder/directory again. The correct size for icon and splashscreen can be found in the ionicframework official website.

Closing as Cordova support was dropped in @capacitor/assets which does not have this same issue. Please let me know if I missed something.

yes i am facing issue

ok i checked some here
https://www.npmjs.com/package/cordova-res
and now seems it fixed,


Scroll doesn't work on Chrome

Hi,
I wanted to do a full page scroll in Gatsby and it doesn't work here's the default component and its scroll implementation:
import React from "react"
import { FullPage, Slide } from 'react-full-page';

function index() {
  return (

      <FullPage scrollMode>
        <Slide>

Inner slide content

        </Slide>
        <Slide>

Another slide content

        </Slide>
      </FullPage>

  )
}

export default index

When I try to scroll with the mouse, nothing works.

Warning: Failed prop type: Invalid prop `scrollMode` of value `true` supplied to `FullPage`, expected one of ["full-page","normal"].
    in FullPage (at pages/index.js:9)
    in index (created by HotExportedindex)
    in AppContainer (created by HotExportedindex)
    in HotExportedindex (created by PageRenderer)
    in PageRenderer (at query-result-store.js:86)
    in PageQueryStore (at root.js:56)
    in RouteHandler (at root.js:78)
    in div (created by FocusHandlerImpl)
    in FocusHandlerImpl (created by Context.Consumer)
    in FocusHandler (created by RouterImpl)
    in RouterImpl (created by Context.Consumer)
    in Location (created by Context.Consumer)
    in Router (at root.js:73)
    in ScrollHandler (at root.js:69)
    in RouteUpdates (at root.js:68)
    in EnsureResources (at root.js:66)
    in LocationHandler (at root.js:124)
    in LocationProvider (created by Context.Consumer)
    in Location (at root.js:123)
    in Root (at root.js:132)
    in StaticQueryStore (at root.js:138)
    in _default (at app.js:94)

Hello, you didn't specify the scrollMode prop. The warning message contains valid options - scrollMode should be "full-page" or "normal". And you are passing a boolean


Stack

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Added implementation of Stack in C.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#399

@Sohailsaifi fine structuring one small modification, please display a message after insertion operation & create a count function to count total number of elements present at that time.

Yeah Sure