imp: Snack example for Modal and Picker

Description
Yet another PR with snack examples. C:

@charpeni It works on Android and iOS simulators. It seems like there is no Modal implementation for web, so it is replaced with div.

I can add Platform check to this one, and on web render some kind of message.

Hmm yeah. Related to #1219. This seems odd to me to default to web with those unsupported components 🤔
Not sure what will be the best solution. cc @rachelnabors.

I think we are able to pass a parameter to our RemarkablePlugin. https://github.com/facebook/react-native-website/blob/master/website/core/RemarkablePlugins.js#L85 . I'll try to fix it tomorrow.

Folks, what's the status on this one? Looks like modal on web still isn't working.

@Esemesek can you revert the change to Modal?

Actually I just merged https://github.com/facebook/react-native-website/pull/1433 which adds the snack player to Picker, so let's just close this PR for now and take care of Modal later :)


[VS Code] Opening Server in Browser: Service not available: portForwarding

Error:
Opening Server in Browser: Service not available: portForwarding
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.471

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.35.1

platformName
Windows

platformVersion
10.0.17134

Thanks for reaching out. Your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.


refactor: apply #[ts(optional) to relevant fields

Description
When using the  #[ts(optional) attribute for fields in rust, the bindings will be produced much nicer for the frontend.
Motivation
Bindings will be easier to use in the frontend
Resources
No response
To-do List

[ ] Identify all optional fields
[ ] Add the attribute to all these fields

 [refactor: apply #ts(optional) to relevant fields


Revist git pre-commit hooks

https://cjolowicz.github.io/posts/hypermodern-python-03-linting/

Note - I'd rather do this "manually" than rely on a service to do this.


Better UI for 'Genres' and Landing page

Describe the bug
The carousels used under 'Read Genre Wise' overflows beyond 3 (as indicated ). Also this way it becomes hard/tricky for the user to select a particular Genre (as they have to keep searching).
Also we can rescale the image below navbar, to redirect the attention to the 'Genres' section.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://kitabe-app.herokuapp.com/'
Scroll down to 'Read Genre Wise'
Click on "next" arrow under any carousel
See error

Expected behavior
Expected to show me a list of similar Genres.
Screenshots

Are you willing to contribute to this issue?
Yes
I have made a mock-up design  here on how we can make the carousel part better :https://www.figma.com/file/quY3GKiD5RgWhsJAg2PKyE/Carousel-draft-Kitaabe?node-id=0%3A1
Being a book lover, I would love to work on this issue, as a GSSoC'21 participant.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
I feel the colour theme of the website can be made more vibrant/ cozy (to give modern day library vibes😄).
My design-mockup is just a suggestion. Feedback is welcome!
@maneprajakta @Praful932

Hi @Greeshma2903 Thanks for your interest in the project :)

Expected to show me a list of similar Genres.

Could you elaborate this?
In the mockup could you add how it would look when scaled to a mobile view? particulary the 1st one
For the 1st one it would be nice to have a one block auto scroll
As for the color scheme theres an ongoing issue #48
Check this out @maneprajakta

@Greeshma2903 From the mockup what I could see is that instead of having four carousels in the genre section it should be replaced by a single carousel seems great to me.
Yes, think for mobile view also.

Thank you assigning this to me😊!
Yes sure, I'll draft the interface for small screens and get back to you.
Regarding the expected behavior:
I expected each carousel block to show me a list of similar genres, which it did not. And moreover the genres where more than 3 (as indicated), which might confuse the user.

I am sorry but I couldn't understand, the 1st one means the first carousel block right?

@Greeshma2903 From the mockup what I could see is that instead of having four carousels in the genre section it should be replaced by a single carousel seems great to me.
Yes, think for mobile view also.

Yes ma'am, working on it😄

@Greeshma2903 not sure about what you meant by similar genres
First one as in this one

Just call me @Praful932 without any honorifics 😄 This is Open source

Um, actually I thought there were multiple carousels, so each carousel might be a group of similar genres (like fiction and its sub-genres). But that wasn't the case 😅.
@Praful932 @maneprajakta I have made 2 different prototypes for small screens. Pls check them and would love some feedback on the same. https://www.figma.com/file/quY3GKiD5RgWhsJAg2PKyE/Carousel-draft-Kitaabe?node-id=0%3A1
@Praful932 Okay so I'll implement auto-scroll for the 1st one. But regarding this, on one scroll, should I let it move forward by 1 block/ all 4 blocks?

@Greeshma2903 yep it's not like that 😅 we had arranged alphabetically in groups.
All three designs are Great 💫 but carousel each with 3 blocks seems perfect to me.

@Greeshma2903 yep it's not like that 😅 we had arranged alphabetically in groups.
All three designs are Great 💫 but carousel each with 3 blocks seems perfect to me.

Oh 😅
thank you! @maneprajakta I have enabled editing for you if you want to make particular changes in UI. should I now clone the project and start with the code part? OR should I start after you make the changes?

@Greeshma2903 No changes from my side you can start working on it.
Yes, Bootstrap 4 is used.
Go through Starter Guide once it will help you in setting up the project.

Um, actually I thought there were multiple carousels, so each carousel might be a group of similar genres (like fiction and its sub-genres). But that wasn't the case 😅.
@Praful932 @maneprajakta I have made 2 different prototypes for small screens. Pls check them and would love some feedback on the same. https://www.figma.com/file/quY3GKiD5RgWhsJAg2PKyE/Carousel-draft-Kitaabe?node-id=0%3A1
@Praful932 Okay so I'll implement auto-scroll for the 1st one. But regarding this, on one scroll, should I let it move forward by 1 block/ all 4 blocks?

Mobile view seems good to me. Let it move forward by 1 block You can start working on it :)
Happy hacking!

Great!
@maneprajakta I had a query regarding the steps after cloning! Since I am contributing only to the frontend part, do I still need to install virtualenv? can I just create a new branch and start fixing the issue?

@Greeshma2903
Yes as you need to view the changes you made locally right. If you don't set up a project like installing everything from requirements.txt the project won't run. You will not be able to view the changes done.

okay thanks!

Hey, when I tried installing virtualenv, it shows:
bash: pip: command not found
Do I need to download python env first?

@Greeshma2903 Have you installed pip ?
Also what OS you are using.
No issues :)

@Greeshma2903 Have you installed pip ?
Also what OS you are using.
No issues :)

Windows
Nope, didn't know about pip, will do so

@Greeshma2903 Have you installed pip ?
Also what OS you are using.
No issues :)

Windows
Nope, didn't know about pip, will do so

Sorry by mistake closed the issue😶

I think python has not come pre-installed on my OS. I was checking a guide to install it and realized that different versions of python have different requirements. Which one will I require for this project? Python 2.7 OR 3.9?

Yep, in windows, it doesn't come pre-installed. Go with the latest version of python.

The Project works seamlessly on Python version 3.8.6

CONTRIBUTING.md

Thanks!

@Praful932 can I dm you the SS on discord, the env is not getting activated

@Greeshma2903 any updates?

I would like to apologize for the delay (due to exams), but work is in progress😅
I made some changes, and the carousel now works something like this (shown in video)
https://www.loom.com/share/3ddc356773a14b73a5aa8e4de8c2ea50
I was not able to figure out how I can move the carousel forward by 1 block (Since Bootstrap doesn't provide a multi-image sliding option), so decided on doing 3 blocks at a time.
I am presently working on the carousel for the mobile view. But I realised since the text is in the picture if I reduce the height (for small screens), the text won't be visible to us.  Presently looks like this with block-sized pictures:
https://www.loom.com/share/87d9979b88944854a38eb94faea7264e
(Pls ignore the positioning of controls, WIP😅)
@maneprajakta

@Greeshma2903 No issues.
It's ok if you go by 3 blocks at a time.
Yep seems fine to me :100:

@Greeshma2903 No problem.
Also it's alright to open a WIP PR, and push commits so we can also track the progress :)


[CRASH + DISCUSSION] Should we request Twitter email transparently?

While working on another PR, I came across this crash:
12-03 12:05:15.217 16688-16688/com.firebase.uidemo E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: com.firebase.uidemo, PID: 16688
                                                                     java.lang.IllegalArgumentException: Given String is empty or null
                                                                         at com.google.android.gms.common.internal.zzac.zzdv(Unknown Source)
                                                                         at com.google.firebase.auth.FirebaseAuth.fetchProvidersForEmail(Unknown Source)
                                                                         at com.firebase.ui.auth.ui.idp.CredentialSignInHandler.onComplete(CredentialSignInHandler.java:73)
                                                                         at com.google.android.gms.tasks.zzc$1.run(Unknown Source)
                                                                         at android.os.Handler.handleCallback(Handler.java:751)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                         at android.os.Looper.loop(Looper.java:154)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:6088)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

It's caused by this line of code and occurs if a user has an existing account and there is a FirebaseAuthUserCollisionException.
To solve this problem, there are two solutions:

Check for a null email in CredentialSignInHandler and fail the sign in if the email is null.
Use TwitterAuthClient#requestEmail to show the request email activity.

I prefer solution 2 because we are being more transparent about requesting a user's email, but it requires more steps and a Twitter user might not have an email: https://docs.fabric.io/android/twitter/log-in-with-twitter.html#request-user-email-address
@samtstern @amandle What should we do?

I also just realized that with method 2, devs must follow the steps described in #433.

@SUPERCILEX does this crash happen currently or only in the context of the new PR you're working on?

It exists in master: create an email account using your twitter email -> log out -> log in using twitter to trigger the account linking.

Hi @SUPERCILEX, I face the same issue. Do we have any solution or plan?

Hi @bobshao, I created this issue because I was unsure how to proceed. @samtstern What do you think we should do?

We should probably go with option #2.  Does it require any additional developer configuration or just work on our side to integrate the flow?

@samtstern It would require developers to follow the steps described in #433 or we would have to cancel the sign in. Other than that, it should be fairly easy to integrate.

Aren't those steps already required to get Twitter sign in working in general?  Or am I missing a distinction?

No, without this change you could sign in with twitter and you just wouldn't receive an email. Now we would be forcing devs to request the email.

That seems reasonable to me, as it stands Firebase Auth requires email as the unique key so we need to enforce that data from IDPs.  Same reason we make Facebook request the email scope.  This change would just be formalizing the requirement.

@samtstern Sounds good! I'll see if I can a PR in today.

@SUPERCILEX I just created two Twitter test accounts, one with phone number only and one with email only.  I then used the quickstart-android project to try signing in with each one.  This code doesn't have any special flow to ask Twitter for the email.
In each case sign in succeeded, the only different being the result of FirebaseUser.getEmail() after sign in.  For one account it was null and for the other account it was the email as expected.
So I'm curious: in what situation will a Twitter account that does have an email associated with it not return an email during the normal sign in flow?  That's the case that's relevant for our purposes.

@samtstern I'm pretty sure that will only ever happen if the dev doesn't request the email permission in the Twitter console. However, I still think we should be concerned with Twitter users not having an email since we will still have to fail the sign in even after they press "Authorize". Because of that, I'm more concerned about the latter case... What should we do when a user doesn't have an email?

I guess the question is do we really have to fail the sign in?  Firebase Auth without FirebaseUI doesn't, so could we make FirebaseUI more lenient here?  Yes we'd have to skip some features in the flow (like SmartLock) but we should still be able to get the user signed in.
As for the developer not requesting email permission in the console, I think compensating for that with additional UI or reverse-engineered HTTP requests could be overcompensating.  After all, it's a developer error.

The only place we really need an email is for account linking: a Twitter user who tries to log in using another provider will not have their Twitter account linked with said other provider. @samtstern If you think that is a reasonable trade-off, then no, we don't have to fail the sign in. What should we do?

@SUPERCILEX can we attempt account linking only when the twitter user has an email and otherwise skip the linking check/attempt?  That seems very reasonable to me, do you agree?

Sounds good, we'll just have to check for null emails in CredentialSignInHandler.

I'm not sure if it is appropriate to interrupt here but I got this problem now and I want to tell you about my experience in case it could help.
In my case the problem happened when the email  was requested for Twitter but the email was already in use. Initially the login was done using google and then later using Twitter, the email is the same in both. The problem was fixed by deleting the google user.
Personally I think that forcing us (developers) to ask for Twitter email is ok, actually even better that ok, you should do it. You should force us to ask for Twitter email permission. This way the accounts created by any provider are always consistent. For adding Google login we must get the SHA1s (debug and release), there is nothing wrong into forcing us to do any step as long it create a quality login experience for the end user and sustainable for devs.
And if the email is already used, the user should be warn about it and redirected to the corresponding option. By example, if email/password login is enabled, and the user previously signed with that email, using Facebook or Google, the user is remind about and redirected. It should be the same behaviour.
Really sorry if I'm out of place, just trying to help.

@cutiko You're totally fine, that's why FirebaseUI has public issues! 😄

In my case the problem happened when the email was requested for Twitter but the email was already in use. Initially the login was done using google and then later using Twitter, the email is the same in both.

@samtstern Hopefully my comment and the above will help you understand why we need the email. Adding the null check in CredentialSignInHandler fixes the crash for Twitter users without an email, but we still need the email before the user is signed to perform linking for Twitter users with an email.
@cutiko Yes, the plan is to force you guys to request the email permission (or at least if you don't neither account linking nor Smart Lock will work).
The fix should be out by FirebaseUI v1.1.0! 🎉

A fix for this issue has been released in version 1.1.0


DOC: edit release notes regarding L-BFGS-B maxfun

in response to https://github.com/scipy/scipy/pull/6240#issuecomment-226138826

Thanks Alex, merged.


ERC721: Questions and thinking about Felt252 for Trait for URI for Token URI and Contract base URI.

🧐 Motivation
I'm starting to check the repo on Cairo Open Zeppelin.
New to Cairo, so I'm trying to build a few things.

Rising question:

Thinking about standards for the NFT token_uri and contract_uri, for the NFT marketplace, etc.
We can't use Ipfs hash for token_uri with Felt252.
How we can fix it or use it in another way?
I've seen the use of Array too, but I'm thinking also about implementing it with Bytes of: https://github.com/keep-starknet-strange/alexandria
Implement a way to use Ipfs Hash with Array, Bytes also Open Zeppelin?
What do you think @martriay?

Briefly addressed in our docs, tl;dr we're currently working on ByteArray support which will be the preferred format going forward.


Player movement

How the player moves in game.

player atlas done (.json file included)

player walking animation done (left and right)

player attacking animation (playing all frames) done

player idling when keys left and right are not pressed and only after attacking animation is done

player dying when it falls out of the world done

player respawning at start point with animation done


MAINT: remove deprecated for loop syntax from Cython code

according to the Cython user guide, the previous, Pyrex-style syntax is deprecated
http://docs.cython.org/src/userguide/language_basics.html#integer-for-loops

LGTM, merged. Thanks @grlee77


Modify History of Readme

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #729 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #729   +/-   ##
==========================================
  Coverage      32.75%   32.75%
  Complexity       924      924
==========================================
  Files            229      229
  Lines           8937     8937
  Branches        1088     1088
==========================================
  Hits            2927     2927
  Misses          5662     5662
  Partials         348      348

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cbd56...9f8cc4a. Read the comment docs.


remove sshd_config injection in an f5 platform

Can one of the admins verify this patch?

Jenkins test this please.

Originally this step was part of the hypervisor's host preparation steps. The F5 module included a hypervisor in-source but was migrated out to beaker's AWS hypervisor, which was then moved out to the beaker-aws gem. The code for correctly preparing root access on an F5 is built-in to the beaker-aws gem at https://github.com/puppetlabs/beaker-aws/blob/0.2.0/lib/beaker/hypervisor/aws_sdk.rb#L578-L591
Why did beaker start doing it again? Has this code been moved out of the hypervisors? Should the beaker-aws gem also be fixed up to account for that, or should the prep code be moved out of beaker-aws and back into beaker?

@hunner I am not aware of beaker-aws gem but I know puppetlabs uses it in their puppet modules. However, for a vagrant f5 box it was trying to configure sshd in a classic linux form. The way sshd is configured in f5 is through tmsh.

For some reason I cannot see the details of the jenkins failure.

@lmayorga1980 Ah vagrant, that would explain why I didn't run into this before. Even when I was developing on a vagrant f5 instance I always prepped the vm by hand in the webui (because licenses couldn't be automated afaict) and skipped beaker provisioning on it. I moved to aws for ephemeral instance testing because they had licensing built-in.
Unfortunately the jenkins is not accessible publicly. It looks like the only failure is unrelated to your change though so no worries.

@hunner hope this can be merged soon. :beer:

@lmayorga1980 Can you please pre-pend your commit message with (maint) and add a test so we can be sure not to break this in the future.  Thx!

@mchllweeks :thinking: Where do you suggest to add the tests?

Jenkins retest this please

Jenkins retest this please

Failures from the tests are unrelated to this change.  I can matrix reload the failing test and it passes.


Find/Ignore files by glob

Should have a --glob or -g option to specify patterns to find files with

Took a stab at implementing that here..

Thank you so much for contributing!
Can I ask, how long have you been using dump_dir ? Where did you hear about it? I only made one post on Reddit when I first started this.
Do you have any other pain points or things you wish it had?
For the record I am dramatically improving the test framework and adding a config file in https://github.com/fargusplumdoodle/dump_dir/pull/13


Feature request:  ES6 Private class field support

Please & thanks!

Sorry, this feature you should go to terser-js.


Update install-unifi.sh

Added some missing Packages.

New installation approved.

update version to:
UNIFI_SOFTWARE_URL="http://dl.ubnt.com/unifi/5.12.72/UniFi.unix.zip"

Thank you


[Feature Request]: Add alert for data limited reached for Log Analytics workspaces

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
Can we possibly get an alert added for when we reach the set daily cap limit on a Log Analytics workspace, and it stops accepting additional logs please?
Thanks!

Hi @SteveBurkettNZ this has recently been raised to us and is on our backlog, no timescales as of yet though as we have some pressing priorities to attend to.


Implement Blender-like pan mode

Enables pan mode in the editor by Shift + Right click dragging.
Resolves #70, refer to lines 180-197 and 246. Auto-formatting led to severe spacing issues due to mix.

Refactored a large portion of the movement logic, adjusting behaviour where necessary. Let me know if there are questions on the specific changes.

Issue was caused by the adjustment of orbitDistance after the zMovement was corrected in the movement code. Led to the value being shrunk by cos(rotation.y) at each move and deviating further from the actual distance to the pivot.


Show used/available size on tablespace view

Hi, I want to request a new feature in tablespace viewer on Oracle, to show total available/used size.
This can be done with the following query:
SELECT
	t.tablespace_name,
	SUM(f.bytes) available_space,
	SUM(s.bytes) used_space
FROM
	sys.dba_tablespaces t
LEFT JOIN sys.dba_data_files f ON
		t.tablespace_name = f.tablespace_name
	LEFT JOIN sys.dba_segments s ON
			t.tablespace_name = s.tablespace_name
		GROUP BY
			t.TABLESPACE_NAME

The object I'm referring to is this one:

Which currently shows only the block size and status (e.g. ONLINE) for each tablespace.
Also, having the ability to use a more suitable unit than bytes (e.g. MB, GB, TB) would be appreciated, both here and in the Files view (available if you select a single tablespace).

Good point and easy to do

I noticed that sizes get multiplied when there are many data files per tablespace. My query was wrong and should be split in 2:
SELECT
	t.tablespace_name,
	SUM(f.bytes) available_space
FROM
	sys.dba_tablespaces t
LEFT JOIN sys.dba_data_files f ON
		t.tablespace_name = f.tablespace_name
GROUP BY
	t.TABLESPACE_NAME;

SELECT
	t.tablespace_name,
	SUM(s.bytes) used_space
FROM
	sys.dba_tablespaces t
LEFT JOIN sys.dba_segments s ON
		t.tablespace_name = s.tablespace_name
GROUP BY
	t.TABLESPACE_NAME;


Build failure: python312Packages.iterfzf

Steps To Reproduce
Steps to reproduce the behavior:

build python312Packages.iterfzf (e.g. nix-shell -p python312Packages.iterfzf)

Build log
nix log /nix/store/7ylvl0di24yqaa7qn8rl8scsjy23mjyq-python3.12-iterfzf-<IP_ADDRESS>.0.drv
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/7ylvl0di24yqaa7qn8rl8scsjy23mjyq-python3.12-iterfzf-<IP_ADDRESS>.0.drv^*'
Sourcing python-remove-tests-dir-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing pypa-build-hook
Using pypaBuildPhase
Sourcing python-runtime-deps-check-hook
Using pythonRuntimeDepsCheckHook
Sourcing pypa-install-hook
Using pypaInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing python-namespaces-hook
Sourcing python-catch-conflicts-hook.sh
Sourcing pytest-check-hook
Using pytestCheckPhase
install: skipping file '/dev/fd/63', as it was replaced while being copied
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
unpacking source archive /nix/store/2nadp23vs3ngg0idp04bbv64y6bcfyhv-source
source root is source
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/tox.ini
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pypaBuildPhase
Creating a wheel...
* Getting build dependencies for wheel...
running egg_info
creating iterfzf.egg-info
writing iterfzf.egg-info/PKG-INFO
writing dependency_links to iterfzf.egg-info/dependency_links.txt
writing top-level names to iterfzf.egg-info/top_level.txt
writing manifest file 'iterfzf.egg-info/SOURCES.txt'
reading manifest file 'iterfzf.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'iterfzf.egg-info/SOURCES.txt'
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/iterfzf
copying iterfzf/test_iterfzf.py -> build/lib/iterfzf
copying iterfzf/__init__.py -> build/lib/iterfzf
running egg_info
writing iterfzf.egg-info/PKG-INFO
writing dependency_links to iterfzf.egg-info/dependency_links.txt
writing top-level names to iterfzf.egg-info/top_level.txt
reading manifest file 'iterfzf.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'iterfzf.egg-info/SOURCES.txt'
installing to build/bdist.macosx-11.0-arm64/wheel
running install
running install_lib
creating build/bdist.macosx-11.0-arm64
creating build/bdist.macosx-11.0-arm64/wheel
creating build/bdist.macosx-11.0-arm64/wheel/iterfzf
copying build/lib/iterfzf/test_iterfzf.py -> build/bdist.macosx-11.0-arm64/wheel/iterfzf
copying build/lib/iterfzf/__init__.py -> build/bdist.macosx-11.0-arm64/wheel/iterfzf
running install_egg_info
Copying iterfzf.egg-info to build/bdist.macosx-11.0-arm64/wheel/iterfzf-<IP_ADDRESS>.0-py3.12.egg-info
running install_scripts
creating build/bdist.macosx-11.0-arm64/wheel/iterfzf-<IP_ADDRESS>.0.dist-info/WHEEL
creating '/private/tmp/nix-build-python3.12-iterfzf-<IP_ADDRESS>.0.drv-0/source/dist/.tmp-lduoqnmy/iterfzf-<IP_ADDRESS>.0-py3-none-any.whl' and adding 'build/bdist.macosx-11.0-arm64/wheel' to it
adding 'iterfzf/__init__.py'
adding 'iterfzf/test_iterfzf.py'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/LICENSE'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/METADATA'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/WHEEL'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/top_level.txt'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/RECORD'
removing build/bdist.macosx-11.0-arm64/wheel
Successfully built iterfzf-<IP_ADDRESS>.0-py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for iterfzf-<IP_ADDRESS>.0-py3-none-any.whl
Finished executing pythonRuntimeDepsCheck
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Successfully built iterfzf-<IP_ADDRESS>.0-py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/WHEEL'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/top_level.txt'
adding 'iterfzf-<IP_ADDRESS>.0.dist-info/RECORD'
removing build/bdist.macosx-11.0-arm64/wheel
Successfully built iterfzf-<IP_ADDRESS>.0-py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
Running phase: pythonRuntimeDepsCheckHook
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for iterfzf-<IP_ADDRESS>.0-py3-none-any.whl
Finished executing pythonRuntimeDepsCheck
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pypaInstallPhase
Successfully installed iterfzf-<IP_ADDRESS>.0-py3-none-any.whl
Finished executing pypaInstallPhase
Running phase: pythonOutputDistPhase
@nix { "action": "setPhase", "phase": "pythonOutputDistPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pythonOutputDistPhase
Finished executing pythonOutputDistPhase
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
checking for references to /private/tmp/nix-build-python3.12-iterfzf-<IP_ADDRESS>.0.drv-0/ in /nix/store/kjywqkhib15h9322l96kbs137amzb3gv-python3.12-iterfzf-<IP_ADDRESS>.0...
patching script interpreter paths in /nix/store/kjywqkhib15h9322l96kbs137amzb3gv-python3.12-iterfzf-<IP_ADDRESS>.0
stripping (with command strip and flags -S) in  /nix/store/kjywqkhib15h9322l96kbs137amzb3gv-python3.12-iterfzf-<IP_ADDRESS>.0/lib
checking for references to /private/tmp/nix-build-python3.12-iterfzf-<IP_ADDRESS>.0.drv-0/ in /nix/store/c5cwp2zrqbanxwbrr8m01iqaby9q5yha-python3.12-iterfzf-<IP_ADDRESS>.0-dist...
patching script interpreter paths in /nix/store/c5cwp2zrqbanxwbrr8m01iqaby9q5yha-python3.12-iterfzf-<IP_ADDRESS>.0-dist
Executing pythonRemoveTestsDir
Finished executing pythonRemoveTestsDir
Running phase: installCheckPhase
@nix { "action": "setPhase", "phase": "installCheckPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
no Makefile or custom installCheckPhase, doing nothing
Running phase: pythonCatchConflictsPhase
@nix { "action": "setPhase", "phase": "pythonCatchConflictsPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Running phase: pythonRemoveBinBytecodePhase
@nix { "action": "setPhase", "phase": "pythonRemoveBinBytecodePhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Running phase: pythonImportsCheckPhase
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: iterfzf
Running phase: pytestCheckPhase
@nix { "action": "setPhase", "phase": "pytestCheckPhase" }
install: skipping file '/dev/fd/63', as it was replaced while being copied
Executing pytestCheckPhase
============================= test session starts ==============================
platform darwin -- Python 3.12.4, pytest-8.3.2, pluggy-1.5.0
rootdir: /private/tmp/nix-build-python3.12-iterfzf-<IP_ADDRESS>.0.drv-0/source
configfile: pyproject.toml
collecting ... ^Mcollected 3 items / 2 deselected / 1 selected

iterfzf/test_iterfzf.py F                                                [100%]

=================================== FAILURES ===================================
_________________________ IterFzfTest.test_select_one __________________________

self = <iterfzf.test_iterfzf.IterFzfTest testMethod=test_select_one>

    def test_select_one(self):
        choice = iterfzf.iterfzf(
            flavors, query="Vani", __extra__=["-1"], executable="/nix/store/v0pgkspnpxx8dj367bwkwjv4c0cl54qz-fzf-0.54.3/bin/fzf"
        )
>       self.assertEqual("Vanilla", choice)
E       AssertionError: 'Vanilla' != None

iterfzf/test_iterfzf.py:20: AssertionError
----------------------------- Captured stderr call -----------------------------
failed to open /dev/tty
=========================== short test summary info ============================
FAILED iterfzf/test_iterfzf.py::IterFzfTest::test_select_one - AssertionError: 'Vanilla' != None
======================= 1 failed, 2 deselected in 0.05s ========================

Additional context
Add any other context about the problem here.
Notify maintainers

@fabaff
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
❯ nix-shell -p nix-info --run "nix-info -m"
these 2 paths will be fetched (0.01 MiB download, 0.10 MiB unpacked):
  /nix/store/06pkgcwpf8q94fvwb21mpkhm5qwpqswy-DarwinTools-1
  /nix/store/rmf7c1pczsq36sl4sh4b5b8qg3cv9097-nix-info
copying path '/nix/store/06pkgcwpf8q94fvwb21mpkhm5qwpqswy-DarwinTools-1' from 'https://cache.nixos.org'...
copying path '/nix/store/rmf7c1pczsq36sl4sh4b5b8qg3cv9097-nix-info' from 'https://cache.nixos.org'...
install: skipping file '/dev/fd/63', as it was replaced while being copied
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.5.0, macOS 14.5`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/store/8akjd9ngyzhzi1412nxmw26rnj93l3gp-source`

Add a :+1: reaction to issues you find important.

https://hydra.nixos.org/eval/1808479?filter=iterfzf&compare=1808475&full=#tabs-still-fail and I can check linux (x86_64-linux, NixOS) builds fine. so This is very likely to do with darwin specific?


Add MD5 checksum

Add Checksum for pythainlp-data.

Hello @wannaphongcom! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/corpus/__init__.py:

Line 96:1: E302 expected 2 blank lines, found 1
Line 101:11: E225 missing whitespace around operator
Line 103:17: E225 missing whitespace around operator
Line 103:58: E231 missing whitespace after ','
Line 103:80: E501 line too long (83 > 79 characters)
Line 104:15: E225 missing whitespace around operator

Coverage decreased (-0.07%) to 86.473% when pulling dff9fec2881dfb43222ad1c84aa95fd8c42715c8 on md5-check into 97e0feea84be0ae92c4c1e4dd4b97950407c9565 on dev.


All links to repositories and api are dead in the main readme

https://github.com/googleads/googleads-dfa-samples/blob/master/README.md

Hi there,
Sorry for the confusion, this repo is actually no longer supported. The API these samples were written for was shutdown some time ago. If you're working with our newer DCM/DFA Reporting and Trafficking API, please see our other repo @ https://github.com/googleads/googleads-dfa-reporting-samples.
Regards,
-- Jonathon Imperiosi, DCM API Team


[ALBA] Almașu Mare village is not found in Almasu Mare commune from Alba county - Pending

Precondition
URL: http://zimbor.go.ro/solr/#/romania/query?q.op=OR&indent=true
Browser: Chrome
Steps to Reproduce:

Step
Action
Expected
Status

1
Open URL in Browser
SOLR is open in Browser without any errors
Pending

2
Type Almașu Mare in q field
You are able to type Almașu Mare in q field
Pending

3
Click on Execute Query
Almașu Mare village is found in Almasu Mare commune from Alba county
Pending

Actual Results:
Almașu Mare village is not found in Almasu Mare commune from Alba county

https://orase.testquality.com defect D28.

Este comuna Almasu Mare cu satul Almasu Mare.


Error: Requiring external module coffee-script/register

When gulp starts up, it brings up this error: Requiring external module coffee-script/register. I looked around to solve this error, but have not been able to. I made sure coffee-script is local in node_modules and have tried different versions of node to see if that would nail it down.
So this happens before a Gulpfile.coffee is even loaded.
gulp 3.9.1 and npm 2.14.20

Someone can correct me if I'm wrong but I'm pretty sure this is not an error. Gulp is just telling you it's using coffee-script/register to pre-compile your build scripts.
See here. No throw or error-related terms in sight, it's just logging it. ( unless of course it actually fails to load the module )

Yeah, not an error.

Thanks for the clarification this is not an error but a statement. Perhaps the logging text could be changed to be less ambiguous?

@tkellen ^

@contra this is in gulp CLI, not liftoff.  Also, it is red when it says "failed" but I think that is proper.  The message from the original issue is a success and it is colored the same as the rest of the output.  I see nothing to change here.

@phated @contra But what if it just said Loaded required module.. than there is no doubt about its meaning. For gulp newbies and non-natives like myself, it'll be very helpful.

How about:
`External module ${chalk.magenta(name)} loaded.`
chalk.red(`External module ${name} not found.`)

And in non-error messages no color with red in it, green?


String deprecated by ES5.x

Elastisearch 5.x don't use String on mappings anymore but text or keyword but current gem cannot define this attribute types as constants Text or Keyword doesn't exists.
What is the recommended way to do something like:
attribute :foo, Text
attribute :bar, Keyword

as I see here: http://www.rubydoc.info/gems/elasticsearch-persistence/Elasticsearch/Persistence/Model/Utils#lookup_type-class_method
there is not support for new mapping type in ES5 right now, but gem versoins claims to be 5.x compatible

I guess the workaround for now is to explicitly defien the mapping:
attribute name, String, mapping: { type: 'text' }

But I wonders if this keeps the defautl ES behaviour of creating a keyword subfield

@jalberto It has been fixed in https://github.com/elastic/elasticsearch-rails/commit/ffc1aa4e0a566d9deeee56e3f636ffc060c9ec07
So alternatively you can fix it by pointing to the master branch, but perhaps @karmi can cut a release or is planning something, after all the last release was May 2016

IMHO the AR pattern casue too many headaches, it's easier to get rid of it and use the repository pattern  as it's closer to ES

Hi all, I've recently fixed all the examples, and indeed changed the default type to text.
@mnoack, yes, I agree, the releases are really behind, apologies for that, I'll push new releases soon.
And agreed with @jalberto, the ActiveRecord pattern for persistance has been and is a source of so many headaches. I'm now working on rewriting the example application from ActiveRecord to the Repository pattern, and seriously considering deprecating the former in favour of the latter.

This change breaks compatibility with ES versions prior to 5.  The gem claims to support "Elasticsearch 1.0 (or higher)", but with the switch to use "text" instead of "string", it now actually only supports 5.x or higher.


Replace serde_cbor with ciborium

The crate serde_cbor is unmaintained and has not received any updates in the last 3 years. The author of serde_cbor proposes ciborium as an alternative.
This PR replaces the dependency on serde_cbor with ciborium.

@marlonbaeten @berendsliedrecht take a look and see if this would work

It does look to me like the minimum API version only increased to KitKat which is already under 1% of devices, so I'm not sure how necessary this restriction is. Maybe it's for compatibility with other libraries? @berendsliedrecht

I suggest merging this and bumping the images repo to whatever is new enough.

There were some issues we encountered without the custom images in quite recent Android APIs, not sure if that will impact it, but would be good to first test it thoroughly.
I think it was mainly the NDK version.
Berend would know more

There were some issues we encountered without the custom images in quite recent Android APIs, not sure if that will impact it, but would be good to first test it thoroughly.
I think it was mainly the NDK version.
Berend would know more

IIRC it was mainly due to rust 1.67+ not working for the Android builds. But I am not too sure anymore if that was because of cross or a subdependency.
I see that the CI fails on error: package half v2.4.1 cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.1. Which means we either have to run cargo update -p<EMAIL_ADDRESS>--precise 2.2.1 and see if that fixes it or see if we can update building android images with 1.70 and fix the occurring errors for that.

Merged as part of #326, thanks!


PLNSRVCE-1526: bump prod to staging level, including the remote-resolver,pac replica bumps

@redhat-appstudio/konflux-pipeline-service FYI
I'm curious if the same timing issue we saw in staging with gitops and tekton operator trying to update the tektonconfig concurrently takes hold now that the chains bump has been removed
it got resolved when the next, unrelated infra-deployments PR merged which sorted out the update ordering from those 2 items
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED

yep the bitnami image / postgreql / results hiccup that started today will block all are CI @redhat-appstudio/konflux-pipeline-service
@Roming22 since this is a prod only bump that CI does not actually cover, are you good with force merging ?

@gabemontero force merged.

@gabemontero force merged.

thanks @Roming22

deployments look good, gitops sync'ed, and several tenant pipelineruns have started and ran successfully since the new replicas were launched


python docs update.

Remove pre-req as its in the new samples repo (new links added to docs pages).

@givenscj : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This requires both App Insights and DevDiv product group tech review, which is in progress.

@givenscj : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@givenscj : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@givenscj : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@givenscj : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@givenscj
Are you still working on this?

Rebasing / Merge conflicts resolved in https://github.com/MicrosoftDocs/azure-docs-pr/pull/208554.
#please-close


Log messages for CASE and OpCreds

Need to log all the phases of the provisioning flow as shown in Fig 26 of section 5.3 (see images below). Since most of the messages exchanged during these phases are encrypted messages, we need to have verbose logs to make sure device completed all the phases mentioned in the provisioning flow
We need log messages that each of the phases in the commissioning flow is entered/completed.

Concurrent connection commissioning flow

Non-concurrent commissioning flow

Added logs for Operational Credentials provisioning flow, and CASE Session setup state machine.


Word Wrapping

Describe the issue
When viewing a user's profile and hovering over a piece of information that is longer than visible, it used to word wrap it and was viewable, but something changed and it's now showing all on one line and wider than the screen.
Expected behaviour
To be wrapped so that it doesn't flow off the screen and is visible.
Issue checklist

[X] The issue occurs with the [latest version] of the addon.
[ ] The issue occurs with Total RP 3 as the only enabled addon.
[ ] The issue occurs only with other addon(s) enabled (please provide a list).

Steps to reproduce
Give us a list of steps to reproduce the issue with.

Click a user with a TRP profile
Open their profile
Hover over an item that is truncated in the TRP window.
See error

Additional files

Those tooltips are meant to show the full text when the field value gets trimmed due to window size.
They are not however designed to allow people to write paragraphs in fields very clearly not intended for them.
The word wrapping change is probably an unintended consequence of unrelated tooltip changes, but if anything was to be done, we'd be more likely to add a hard cap on the additional information field values to prevent misuse of those fields.


requirements.txt

hi Barry,
where should I put requirements.txt so that petrel installs all the dependencies on actual apache storm cluster? In the same root directory where create.py is?

You should do the following:

Create a requirements.txt file listing your requirements.
Create a manifest.txt file.
Create a setup.sh file containing the command pip install -r requirements.txt

Place these files in the directory with create.py. These files will be included in the topology.jar, and Petrel will run setup.sh when the topology is initializing. Here's the code that does that:
https://github.com/AirSage/Petrel/blob/master/petrel/petrel/package.py#L314
If you have any issues, you will want to check the Petrel log file.

Closing since I answered the question and haven't heard back. Please reopen or create a new issue if necessary.


Random segfault on Azure

We're running into a segfault on Azure that seems to be happening randomly. I've created a PR on our repo with the fix given in #264 which seemed to run fine:
https://dev.azure.com/mun-lang/mun/_build/results?buildId=146&view=results
But once the PR was merged into the repo it segfaulted again:
https://dev.azure.com/mun-lang/mun/_build/results?buildId=148&view=results
https://dev.azure.com/mun-lang/mun/_build/results?buildId=152&view=results
The code between these commits is the same. I also cant figure out how to get any more information. Any help would be greatly appreciated!

Since #190 is now closed can you let me know if this is still an issue?

I'll close this since we are now using grcov since it also supports Windows and macOS.


Add About View & related tests

This PR contains the following changes:

Add API utilities.
Add About ViewModel bindings.
Add About View & related tests.

Screenshots / Video Recording

@nitin10s can you please first review this PR so that other API related PRs could be sent..

@nitin10s This is actually a web view, so this will actually be needed to rebuild as flutter view.

@nitin10s

ok, everything else LGTM 👍

@tachyons anything else over here ?


Add commits from the original repo

[x] The core code works as expected.
[ ] Some tests that require models to run don't work currently(i.e they fail) since the models are missing in the package. We could fix the issue by importing the package on the initial repo as a dependency. The other fix is to maybe remove the tests involving the models altogether.

@SilasKenneth Have you considered https://stackoverflow.com/questions/45764872/how-to-push-an-existing-branch-into-a-new-repo-using-git ? Pushing the old repo branch seems like a better way


KK: Update invoice form formatting

@TheBonface made some formatting and logic updates on the invoice/_form

Awesome thank you


Added views for button skipLogin in layout-land and layout-xLarge, bu…

…g fix issue#1864
LoginActivity used to crash when opened in landscape mode
Fixes #1864  and LoginActivity crashes when login screen is opened in landscape mode
Description (required)
LoginActivity used to crash when opened in landscape mode or devices supporting large density pixels
Fixes #1864  and LoginActivity crashes when login screen is opened in landscape mode
{Describe the changes made and why they were made.}
Added view btnSkipLogin (Button) in layout-land and layout-xLarge for activity_login (where there in activity login's default layout files but not in the mentioned files)
Tests performed (required)
Tested on {27 & name of pixel c tablet emulator}, with {build variant,  ProdDebug}.
Screenshots showing what changed (optional)

Codecov Report

Merging #1865 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1865   +/-   ##
======================================
  Coverage    3.61%   3.61%
======================================
  Files         192     192
  Lines        9848    9848
  Branches      871     871
======================================
  Hits          356     356
  Misses       9466    9466
  Partials       26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a059a3c...bf4a21e. Read the comment docs.

I went through the travis logs, seems the issue is this
commons/app/build/intermediates/res/merged/beta/debug/layout/fragment_media_detail.xml:314: error: Error: No resource found that matches the given name (at 'text' with value '@string/copy_wikicode while building, I verified that the string is there.  Can someone provide some insights ?

There was an issue with a string nominated_see_more (still is there in master), some one had used CDATA tag for the same and missed to closed it properly [Note I had taken pull from master]. and that is why certain remaining strings were not reachable, including the one for which Codacy bot was giving me error. I have added a fix, but I am still wondering that how such a commit could surpass and go to master. Please correct me if I am mistaken somewhere. This issue might need to be merged immediately (so that other people do not face build errors). Someone please review it.

Sorry about that, this has been fixed in #1868 . If you rebase on master it should work now.
Interestingly I'm not sure why the initial PR passed all the tests, both Codacy and Travis.


Logical and/or return booleans

Expected behavior:
$ cargo run
int main(int argc, char **argv) {
    return 0 || argc;
}
$ ./a.out three args; echo $?
3

Actual behavior: returns 1
Fix: need to implement arguments to EBBs

This is actually the intended behavior and I clearly have no idea how C works.


#418: Allow subtypes of Certificate and X509Certificate on LeshanServerBuilder

Signed-off-by: Alexis Hernandez<EMAIL_ADDRESS>

LGTM

integrated in master (commit e54f0a368d2df10525bb75b9b902779c17917348)


Do not handle push events for annotated tags

Avoids attempting to post commit statuses for annotated tags, which does not work.
Pushes for lightweight tags are still handled, because the SHA will refer to the head commit, whereas for annotated tags, the SHA refers to the annotated tag.

:+1:


[AA] Add Boba Goerli Testnet contract addresses

:clipboard:
Overview
Add AA contract addresses (Boba Goerli Testnet)
Changes

updated the deployment script to NOT deterministically deploy paymaster
added the compilation artifacts
added the deployed addresses

Testing
/

Codecov Report
Patch and project coverage have no change.

Comparison is base (51880c4) 51.78% compared to head (9b7cf7e) 51.78%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #803   +/-   ##
========================================
  Coverage    51.78%   51.78%
========================================
  Files          197      197
  Lines         7998     7998
  Branches      1651     1651
========================================
  Hits          4142     4142
  Misses        3856     3856

Flag
Coverage Δ

coverage
51.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Why the change from deterministic deployment?

Why the change from deterministic deployment?

beacuse owner is set to deployer and some contract logic on the constructor calls method that operates on msg.sender
(this is only for the paymasters, didn't want to change the contract logic)


API Validator

Providing access to Validator from callback function which onError and onValid

This feature was abandoned because unnecessary


Incorrect DOF limits for continuous joints

After loading the urdf files from ada, as specified in https://github.com/personalrobotics/ada/blob/master/adapy/src/adapy/adarobot.py, calling GetDOFLimits results in meaningless values:
robot.GetDOFLimits()
Out[1]:
(array([ 0.   ,  0.   ,  0.   ,  0.785,  0.65 ,  0.   ,  0.   ,  0.   ]),
 array([ 1.05     ,  1.05     ,  0.       ,  5.4981853,  5.6331853,
        0.       ,  0.       ,  0.       ]))

There were some major bugs in our handling of continuous joints. I fixed them in #11 and am currently testing this on the URDF model of ADA.

Fixed in #11. I was able to successfully load and plan with the ADA URDF model.


Extension does not work with ChatGPT Plus

I recently updated my chatgpt tot the plus version and the export button disappeared

I'm also running on plus plan. Please provide the following information for me to trace what happened:

Browser
OS
Script Version (Check in your script manager's dashboard)
Error Message (Press F12, go to console, take a screenshot)

Thank you so much for writing Exporter - it's so helpful!
I don't know if this is the same problem, but I have been using Exporter on the Plus plan for a week or two. I used it this morning and it worked fine. This afternoon the Export button has disappeared.
I have tried in both Chrome and Firefox, browsers are up-to-date.
I am running macOS 12.6.3.
I updated the script to 2.6.3.
I don't get any errors on the ChatGPT page.
On the script edit page in TamperMonkey, I get the error shown in this screenshot, in both browsers.

I'm also running on plus plan. Please provide the following information for me to trace what happened:

Browser
OS
Script Version (Check in your script manager's dashboard)
Error Message (Press F12, go to console, take a "complete" screenshot)

My Browser is Chrome Version 111.0.5563.149 (Official Build) (64-bit)
OS is Windows 11
Script version is 2.6.2

@peterkaminski ok, I might need you to refresh and monitor if there are any error messages in the console. I'm not sure if OpenAI is A/B testing you guys.

@patrickwitter Thanks. This is what I need. But can you scroll down to take another screenshot for all the error messages?

It's the same error repeated down @pionxzh

Getting fewer errors now, but now a different one

@peterkaminski @patrickwitter Based on the recent bug #119, I think they are the same one. Let me know if you guys still have problem with v2.6.4

v2.6.4 works for me, thanks!


jpath regex timeout support

from https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices

When using System.Text.RegularExpressions to process untrusted input, pass a timeout...you should use the timeout feature to ensure that excessive backtracking does not severely degrade regular expression performance...[or causes] a Denial-of-Service attack.

unfortunately timeouts aren't supported in System.Text.RegularExpressions until ~net4.5 or so... so i only really added support in for the frameworks that can accept a timeout.
also because SelectTokens runs the regex against every token that match some path, even if each token completes within some timeout, the sum of regex calls to all tokens may exceed some allotment. therefore i've added a global timeout parameter to SelectTokens to ensure the call completes roughly within the expected timeout.
also, i added support for the compiled regex option/switch, since that's the main use case we have and the speedup is important to us.

Thanks for the PR. This is something I've been meaning to do for a while.
I've modified your PR with some changes:

Put the timeout on a new settings object. Will allow for potential future settings.
Remove global timeout. This is kind of a weird feature. If someone wants to do this then they can implement it themselves when they foreach over the results.

New PR - https://github.com/JamesNK/Newtonsoft.Json/pull/2456

Thanks for the PR. This is something I've been meaning to do for a while.
I've modified your PR with some changes:

Put the timeout on a new settings object. Will allow for potential future settings.
Remove global timeout. This is kind of a weird feature. If someone wants to do this then they can implement it themselves when they foreach over the results.

New PR - https://github.com/JamesNK/Newtonsoft.Json/pull/2456


Incorrect (misleading) information is provided in this chart

[Enter feedback here]
In the Scalability and performance section
Minimum Share / Volume Size
Standard
No minumum.
Only SMB is available in Standard.  NFS is only available in Premium. So the information is correct for SMB Azure file -- but not true for NFS Azure File.
The minimum share / volume size is
Standard
No minimum (SMB).  Not available (NFS).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27132a89-4dee-aa95-1d0a-acb454b342c7
Version Independent ID: dc63897c-8280-d17b-7fdc-dd1f859e2574
Content: Azure Files and Azure NetApp Files Comparison
Content Source: articles/storage/files/storage-files-netapp-comparison.md
Service: storage
Sub-service: files
GitHub Login: @khdownie
Microsoft Alias: kendownie

@brianotte
I have assigned the issue to the content author for further review.

@brianotte @SatishBoddu-MSFT I have added a note to the table to clarify:
https://docs.microsoft.com/en-us/azure/storage/files/storage-files-netapp-comparison
No minimum (SMB only - NFS requires Premium shares).
This issue can now be closed.

Perfect.  Thank you good sir.


Postgres: Support inherited table schema

When using table inheritance in Postgres, sqlc can't reference any columns in the parent table.
Example setup (from pg_dump):
-- schema.sql
CREATE TABLE public.reservations (
    id character varying(255) NOT NULL,
);

CREATE TABLE public.flight_reservations (
    flight_id character varying(255)
)
INHERITS (public.reservations);

-- queries.sql
-- name: InsertFlightReservation :one
insert into flight_reservations (id, flight_id)
VALUES ($1,
        $2) RETURNING (id);

Result:
sqlc generate
# package data
queries.sql:111:38: column "id" does not exist

Expected:
The expected result should be to reference the inherited table columns.

Models created through inherited tables must either embed the parent table model or have all the columns the parent has.
CREATE TABLE transfer
(
    id           bigserial primary key        not null,
    txid         text                         not null,
    currency_id  int references currency (id) not null,
    from_address text                         not null,
    to_address   text                         not null,
    volume       decimal                      not null
);

CREATE TABLE transfer_eth
(
    txid text references raw_transaction_eth (txid) not null,
    UNIQUE (currency_id, txid, to_address)
) INHERITS (transfer);

expected result:
type Transfer struct {
	ID          int64
	Txid        string
	CurrencyID  int32
	FromAddress string
	ToAddress   string
	Volume      string
}

type TransferEth struct {
	Transfer
}
// OR
type TransferEth struct {
	ID          int64
	Txid        string
	CurrencyID  int32
	FromAddress string
	ToAddress   string
	Volume      string
}

actually generated result:

type Transfer struct {
	ID          int64
	Txid        string
	CurrencyID  int32
	FromAddress string
	ToAddress   string
	Volume      string
}

type TransferEth struct {
	Txid string
}

Is someone willing to look into this issue? We could really use a solution.


Improvements from code review

@Calvin-L I addressed all but one of your comments.  (Thanks for the feedback!)  Feel free to squash-and-merge, and to make that last change if you want to.

Thanks again for your help!


Metadata open for extension

Hi Luca and friends of MFEs.  I'll jump right in.
Question
Would you consider enabling the metadata object in the schema so it's open for extension. i.e. by removing or setting to true?
"additionalProperties": false
Rational
In the organisation that I work for, a MFE is identified using a convention; this looks something like {org}:{bc}:{mfename} ; reading from right to left mfename is the MFE name {bc} is the owning bounded context and {org} is the serving organisation.
Ideally it would be logical to place this meta information in the metadata section to make it easy to read from a human and machine perspective; adding this to another meta object in the extras section simply looks odd and kind of wrong.
If you look at another json schema CloudEvents (https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/formats/json-format.md), it is designed open to extension; meaning additional attributes can be added at the top level without impact to the convention; this enables an architecture to build upon a great standard but yet add additional characteristics as fits need.
Thank you kindly for considering.
Gareth.

Hey Gareth
thanks a lot for the request.
it's a fair comment, let me share back with the team and have a thought


MP Trademark work

Hi,
I want to contribute to the trademark work, please guide

Thank you, @manish2aug, for allowing us to move the Trademark's folder to the Community folder to enable your contributions to the project.
Edit is public so that contributors like you can help draft the document using the resources provided within the document from the past work.
https://drive.google.com/drive/folders/1wbn8mUPTjQMpHYuzh1swwPCBnuS7rg3o

Thanks, @aeiras, I will go through the ones for Jakarta EE and would make similar copies for MP though I am not sure about the following,

Brand usage handbook is a pdf, not sure about the content, can you please guide me to something to find out about the chosen logo, and typography etc which is required for the content.
The second document (trademark guideline) is hosted on the internet, can I create an MS\Google doc and attached it to this issue for review

Sorry, just confused a little bit never involved in such type of activities before, would appreciate your guidance here, thanks

Hola Manish,

Forget about brand handbook, that is only possible once the trademark guideline is approved and finalized.

Fantastic request on number 2. Example - Word  Trademark Document- Jakarta EE Trademark has been converted from online PDF to word.

You have nothing to apologize for. Thank you for choosing to do & asking questions on the spot. You are not alone, many others are right there beside you, ready to help.!

Thanks, Amelia,
Have added a drafted version (here),
Can you please confirm if it will have the same eligibility requirements & required information for inclusion in the official list of Compatible Software Products or this information would be different and relevant information can be found somewhere

Wow, Manish, you are amazing!
Thank you for stepping in. How wonderful!
I added comments in the document and quickly review the write-it, excellent draft. Kudos!
Things are still coming together with compatible implementations & TCK. Discussions are ongoing in the general forums.
Your time and effort have provided enough to move the community to tackle the stuff we haven't decided yet.
Can you please @manish2aug become a member of the MP general =1,200 Members or you could start small and send a message update to the Marketing forum + 26 members  and provide an update from your point of view as the leading contributor using this git issue? Doing so will help trigger notice on progress on such important MPWG task to other MicroProfilers who can help.

Thanks, Amelia!
Posted the msg.

I made a find/replace edit throughout the doc from Microprofile to MicroProfile as I believe the capital P is part of the trademark.

Awesome @debbiehoffman!

Hi @aeiras, I am not sure about the review or approval process. As there is no more suggestion on this can we mark this as closed?

Hey Manish, @manish2aug
This ticket can be closed as the 1st face of the trademark write up is completed.
Now, we move into group review before we start the technical API inserts that will need to be included.
While at it, we will also work in the creation of the trademark logos that are missing, the tickets were openned in 2020.
The trademark and all the work will end up for Steering Committee vote once all pieces are completed. Thats why the Trademark's handbook comes at the very end. :)
You are welcomed to close the ticket today or wait until Monday, show and tell update.  Your call!

oh and you can and ought/must vote on the MPWG mailing list when that vote goes out. MPWG are public and welcomes contributors' feedback. You leading the effort must own it beautifully on that vote!

Closing the issue as the planned work is done


Bug: SerializedTableRowNode type has height as required

Lexical version: v0.11.3
Steps To Reproduce
  const row: SerializedTableRowNode = {
    type: table
    children: [],
    version: 1,
    direction: "ltr",
    format: "left",
    indent: 0,
    height: undefined,
  };

The current behavior
TableRowNode has __height?: number  and everything works fine with an undefined height (with the row height based on its contents).
However we get a type error: Type 'undefined' is not assignable to type 'number'.ts(2322)
The expected behavior
No type error.

can I work on this

Hello, Have you made progress on the subject to date?

Was fixed in #5696


Add transposition table to alpha-beta and negamax search

Add is_empty, len and capacity methods for transposition table
Add struct SearchResult and use it as return type of Search::search

Codecov Report

Merging #45 (8e8d969) into main (a4c1fd2) will increase coverage by 0.00%.
The diff coverage is 89.56%.

@@           Coverage Diff            @@
##             main      #45    +/-   ##
========================================
  Coverage   94.71%   94.71%
========================================
  Files          30       31     +1
  Lines        5074     5246   +172
========================================
+ Hits         4806     4969   +163
- Misses        268      277     +9

Impacted Files
Coverage Δ

eval/src/eval.rs
92.98% <ø> (ø)

search/src/alpha_beta.rs
85.35% <80.74%> (-3.16%)
:arrow_down:

perft/src/performance_tester.rs
91.83% <93.75%> (+0.17%)
:arrow_up:

search/src/negamax.rs
97.09% <97.05%> (+10.35%)
:arrow_up:

movegen/src/transposition_table.rs
98.94% <100.00%> (+0.37%)
:arrow_up:

search/src/search.rs
100.00% <100.00%> (ø)

movegen/src/move.rs
94.96% <0.00%> (-0.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c1fd2...8e8d969. Read the comment docs.


vscode extension not working with rem-to-px preset nuxt

if i enable preset rem to px the extension stop working.
without preset:

with preset:

nuxt.config.ts:

I suggest you use unocs.config.ts file to configure UnoCSS.
If you use presets option, we consider you to have complete control over the presets.
https://github.com/unocss/unocss/blob/093e9273a385f155cb30a9f7ce747152286b4539/packages/nuxt/src/options.ts#L11-L27


keycloak authorization

How can we add user authorization ( user role mapping) for react router link?

You have to do this programatically on your own. I suggest doing this in a kind of HOC could be a good way.


docs(connector-fabric): add sequence diagram of run tx endpoint

Description
As a contributor I want to have a sequence diagram about how the transaction endpoint works internally so that I have a shot at understanding it without having to deep dive into the actual code itself.
(add more description and relevant links)
Acceptance Criteria

Use PlantUML
Be not too detailed, but still include everything (there is no correct answer to this, just trying to hit the right balance and accepting that it will never be perfect)
Include the sequence diagram in one of the sub-sections of the connector's README
Make sure not to use external links but instead rely on locally stored png exports

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz

I am working on this


Feature request: Make Series more prominent in the UI

There's a link to view all the books in a series from the book's information page, but the Series itself isn't surfaced elsewhere.  Consider some/all of the following enhancements around series:

A Series page that shows all the series for which books are in the library
Collapsing books in the Library page to show the series instead of the individual books
Ability for series to contain other series (e.g. Heralds of Valdemar, which is composed of many duologies/trilogies in the same world)

Another series related feature request (I think this belongs as an addition here, but I can make a new issue if needed):

Put books in series order when sorting by series


Combine multiple Options for reducing nested code

. (Note, this is not really an issue, more of a question)
Hello, so I have been using this library rather imperatively, rather than functionally because Im not too familiar with the concepts, but found good use for Option/Either.
However, I came upon some code that seemed rather unwieldy where I have multiple options that depend on other options and sometimes need to get a future to get the next option, as you can see here.
  return activeShiftOption.fold(
    () => ActiveShiftDetails.error('activeShift none'),
    (activeShift) async {
      final employeeOption = await database.getEmployee(activeShift.employeeId);
      return employeeOption.fold(
        () => ActiveShiftDetails.error('employee none'),
        (employee) async {
          final shiftOption = await database.getShift(activeShift.shiftId);
          return shiftOption.fold(
            () => ActiveShiftDetails.error('shift none'),
            (shift) async {
              final clockOption = await database.getClock(shift.clockIn);
              return clockOption.fold(
                () => ActiveShiftDetails.error('clock none'),
                (clock) async {
                  final checkOption =
                      await database.getCheck(clock.healthCheckId);
                  return checkOption.fold(
                    () => ActiveShiftDetails.error('check none'),
                    (check) async {
                      final userOption =
                          await userDatabase.getUser(clock.registeredById);
                      return userOption.fold(
                        () => ActiveShiftDetails.error('user none'),
                        (user) => ActiveShiftDetails.success(
                          employee: employee,
                          activeShift: activeShift,
                          shift: shift,
                          clockIn: clock,
                          check: check,
                          scannedByUser: user,
                        ),
                      );
                    },
                  );
                },
              );
            },
          );
        },
      );
    },
  );

As you can see there is a nesting of 6 option.folds. Is there some sort of cleaner way to do this with the library? I tried using the Option.map2,3  but there didn't seem to be any type safety.  Any guidance/concepts that could help?

Hi @linxydmhg!
I'm by no means an expert on any of this, but here's the way I've been approaching things. First, I think you want to use Either instead of Option, since you're basically trying to capture a multi-step validation process. Here's the code I came up with; I promise I'll try to come back and flesh out what's happening in detail.
    final M = EvaluationMonad<ActiveShiftDetailsFailure, Database, Unit, Unit>(UnitMi);

    final employeeEv = (String employeeId, Database database) => M.liftFuture(database.getEmployee(employeeId)).bind(M.liftEither);
    final shiftEv = (String shiftId, Database database) => M.liftFuture(database.getShift(shiftId)).bind(M.liftEither);
    final clockEv = (String clockIn, Database database) => M.liftFuture(database.getClock(clockIn)).bind(M.liftEither);
    final checkEv = (String healthCheckId, Database database) => M.liftFuture(database.getCheck(healthCheckId)).bind(M.liftEither);
    final userEv = (String registeredById, Database database) => M.liftFuture(database.getUser(registeredById)).bind(M.liftEither);
    final detailsEv = (Shift shift, Employee employee, Clock clock, User user) => M.liftEither(right(ActiveShiftDetails(shift, employee, clock, user)));

    Either<ActiveShiftDetailsFailure, Shift> activeShiftE = right(Shift());

    final Evaluation<ActiveShiftDetailsFailure, Database, Unit, Unit, ActiveShiftDetails> eval =
    M.ask().bind((database) => M.liftEither(activeShiftE)
        .bind((activeShift) => employeeEv(activeShift.employeeId, database)
        .bind((employee) => shiftEv(activeShift.shiftId, database)
        .pure(clockEv(activeShift.clockIn, database)).flatMap(id)
        .bind((Clock clock) => checkEv(clock.healthCheckId, database)
        .pure(userEv(clock.registeredById, database)).flatMap(id)
        .bind((User user) => detailsEv(activeShift, employee, clock, user))))));

    final Either<ActiveShiftDetailsFailure, ActiveShiftDetails> successE = await eval.value(GoodDatabase(), unit);
    expect(successE.isRight(), isTrue);
    successE.fold((l) => fail("Shouldn't Be Here!"), (r) => expect(r.shift.employeeId, equals("2222")));

    final Either<ActiveShiftDetailsFailure, ActiveShiftDetails> failedE = await eval.value(DatabaseWithClockFailure(), unit);
    expect(failedE.isLeft(), isTrue);
    failedE.fold((l) => expect(l.msg, equals("No Clock Found!!")), (r) => fail("Shouldn't Be Here"));

Wanted to go into more detail here, because this is where things get confusing without some of the syntactic sugar other languages have.
get() lets you access the State.
ask() lets you access the Reader.
( Why get, vs ask? I do not know. :) )
    M.get().bind((shift) => M.ask()
            .bind((database) => employeeEv(shift.employeeId, database)
            .bind((employee) => shiftEv(shift.shiftId, database)
            .pure(clockEv(shift.clockIn, database)).flatMap(id)
            .bind((Clock clock) => checkEv(clock.healthCheckId, database)
            .pure(userEv(clock.registeredById, database)).flatMap(id)
            .bind((User user) => detailsEv(shift, employee, clock, user))))));

    M.get().bind((shift) => doSomeEvaluation(shift.employeeId));

    M.ask().bind((database) => doSomeEvaluation(database));

We want the scope to include both, so we need to nest the binds:
    M.get().bind((shift) =>
        M.ask().bind((database) =>
            employeeEv(shift.employeeId, database)
        )
    );

That was a really great intro to Evaluation, @ibcoleman – thank you!

Means a lot coming from you, @spebbe. Thanks.


Limit the number of outbound connections to MaxConnections

This commit also fixes control channel shenanigans:

recover error in control channel Accept()

This is a bit of a hammer. Backbone nodes will basically only connect to local nodes in one cloud provider since they'll resolve via the registry first and retrieve 3 nodes and then after append the peers provided via option but ignore them.

We want the peer list via option to be used no matter what. So when we specify --nodes it uses all these addresses.
We want to limit number of nodes we use via the resolver so clients using the http resolver only make 3 connecfions. They will not specify --nodes so this works well.

So max connections should be applied to nodes resolved via the resolver only.

Via the network.Resolver you mean?

Yes you're right on that overloading part. The question is where we optimise that. Google rotates IPs returned by DNS records. We could do the same for the network api used by the http resolver but we could also internally do some level of randomisation. Have a feeling randomness is probably going to yield simila R results to anything we try cleverly do.


[FEATURE] Allow the last line of new structures to not end in a comma

Describe Your Feature
Structures should be allowed to have the last value not end in a comma.
Currently, it must always end in a comma or an error is thrown.
Provide a Code Snippet Using Your Feature
struct Test {
    value: u64;
}

fn main() {
    let test = new Test {
        value: 0
    };
}

Additional Information
Look at how CodeEnd handles returning with a value and how Structure changes the state of code parsing.

I'd like to work on this

It seems like the PR didn't fix the issue when I added a test for it, but I may have broken it.

This isn't fixed, closed incorrectly


last version

Is there an existing issue for this?

[X] I have searched the existing issues

I'm having the following issue:
Hi,
i would like try last version pyplumIO, but i got error:

and i test only simple code:

so, i got device status (but i dont check) and error
My environment is:
- OS: Ubuntu 22.04
- Python: 3.10

I have following devices connected:

[ ] ecoMAX 3xx series
[ ] ecoMAX 8xx series
[X] ecoMAX 9xx series
[ ] Expansion module B
[ ] Expansion module C
[X] ecoSTER 200/ecoSTER Touch
[ ] ecoLAMBDA
[ ] ecoNET 300

I'm connecting to my devices using:
USB to RS-485 adapter
I'm seeing following log messages:
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for your feedback! Judging by the error, this is is not a latest version which is v0.2.33, but a head of main branch. Please understand, that main branch can include changes, which are unstable or outright broken.
Thermostats support is still not done. At this stage I just committed all work done prior to holidays. This is not yet tested on real device, so errors are to be expected.

I'll really appreciate if you can help me to obtain frame message from real device though for testing purposes, as I'm currently away from home.
To do so, please run the following code and paste it's output (line of hex values) as the issue comment.
Thanks beforehand!
import asyncio

from pyplumio import open_serial_connection
from pyplumio.devices import Device
from pyplumio.frames.requests import ThermostatParametersRequest
from pyplumio.frames.responses import ThermostatParametersResponse
from pyplumio.protocol import Protocol

async def _force_protocol_shutdown(protocol: Protocol):
    """Force protocol producer and consumers tasks into shutdown
    without breaking the connection."""
    protocol.cancel_tasks()
    await protocol.wait_until_done()
    for queue in protocol.queues:
        while not queue.empty():
            queue.get_nowait()
            queue.task_done()

async def main():
    """Open the ecoMAX connection and output controller data."""
    async with open_serial_connection(device="/dev/ttyUSB0") as connection:
        ecomax: Device = await connection.get_device("ecomax")
        await _force_protocol_shutdown(connection.protocol)
        await connection.protocol.writer.write(
            ThermostatParametersRequest(recipient=ecomax.address)
        )
        while True:
            frame = await connection.protocol.reader.read()
            if isinstance(frame, ThermostatParametersResponse):
                print(frame.message.hex())
                break

asyncio.run(main())

hi,
sure, i understand that some errors can be. But maybe for dev version make secound branch and merge to main only working code.
response:
000025ffffff000007dc0064005e01960064005e01643c8c02003c01003c01003c0a003c090032de0064005e01d40064005e015a0032002c01ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff []

hi,
i check last main commit and errors are gone (from first comment).
i know, that is not finally version but i check this function:
thermo = await ecomax.get_value("thermostats");
await thermo[0].set_value("thermostat_day_target_temp", 22)
and i got this:
Traceback (most recent call last):
File "/home/barti/Pulpit/pyplum/test.py", line 19, in
asyncio.run(main())
File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
return future.result()
File "/home/barti/Pulpit/pyplum/test.py", line 10, in main
await thermo[0].set_value("thermostat_day_target_temp", 22)
File "/home/barti/Pulpit/pyplum/pyplumio/devices/init.py", line 80, in set_value
return await parameter.set(value)
File "/home/barti/Pulpit/pyplum/pyplumio/helpers/parameter.py", line 159, in set
raise ValueError(
ValueError: Parameter value must be between '24064' and '54273'

sure, i understand that some errors can be. But maybe for dev version make second branch and merge to main only working code.

Thank you for the message, it'll help a lot. As for dev branch I see no point in having two branches for now, as a whole project considered early beta and has a userbase of maybe 5-10 people :) Maybe later when we get to the first stable release. For now, to avoid errors it's better to stick to releases, they are at least tested with multiple devices via Home Assistant integration.
I'll really appreciate your help with debugging though, this should considerably speed up times between releases👍
For your second issue, that's where the message you provided will be very handy. Value error is raised because parameter was incorrectly parsed as having value between of 24064 and 54273 which is of course incorrect for thermostat_day_target_temp parameter. I'll plug the message you've provided into the test case and see what went wrong ASAP.

Everything should hopefully work now. At least thermostat parameter parser is fixed and working as expected with the message that you provided.
Thanks again for all your help!

Hi,
Sometimes on start app i got message like:
Can't process received frame: Incorrect frame checksum (1)
Can't process received frame: Incorrect frame checksum (22)

and when i try get regdata (or subscribe regdata),
i got nothing. ( connection can be open next 10, 20 min or more and still regdata (subscribe) will be not available)
I must restart app (reconnect) and try again get regdata (with timeout=15), when i got regdata message, then i know, that will be ok.

Thermostats fun check
ecomax = await connection.get_device("ecomax", timeout=10)
thermo = await ecomax.get_value("thermostats");
print( thermo[0].data)

message:
{'state': 0, 'current_temp': 21.367984771728516, 'target_temp': 21.200000762939453, 'contacts': False, 'schedule': False}
but when i make in next steps:
print(await thermo[0].get_value('hysteresis'))
print( thermo[0].data)

i got full message:
{'state': 0, 'current_temp': 21.367984771728516, 'target_temp': 21.200000762939453, 'contacts': False, 'schedule': False, 'mode': ThermostatParameter(device=EcoMAX, name=mode, value=0, min_value=0, max_value=7, extra=0), 'party_target_temp': ThermostatParameter(device=EcoMAX, name=party_target_temp, value=22.0, min_value=10.0, max_value=35.0, extra=0), 'summer_target_temp': ThermostatParameter(device=EcoMAX, name=summer_target_temp, value=15.0, min_value=10.0, max_value=35.0, extra=0), 'correction': ThermostatParameter(device=EcoMAX, name=correction, value=100, min_value=60, max_value=140, extra=0), 'away_timer': ThermostatParameter(device=EcoMAX, name=away_timer, value=2, min_value=0, max_value=60, extra=0), 'vent_timer': ThermostatParameter(device=EcoMAX, name=vent_timer, value=1, min_value=0, max_value=60, extra=0), 'party_timer': ThermostatParameter(device=EcoMAX, name=party_timer, value=1, min_value=0, max_value=60, extra=0), 'holiday_timer': ThermostatParameter(device=EcoMAX, name=holiday_timer, value=10, min_value=0, max_value=60, extra=0), 'hysteresis': ThermostatParameter(device=EcoMAX, name=hysteresis, value=6, min_value=0, max_value=50, extra=0), 'day_target_temp': ThermostatParameter(device=EcoMAX, name=day_target_temp, value=22.1, min_value=10.0, max_value=35.0, extra=0), 'night_target_temp': ThermostatParameter(device=EcoMAX, name=night_target_temp, value=21.2, min_value=10.0, max_value=35.0, extra=0), 'antifreeze_target_temp': ThermostatParameter(device=EcoMAX, name=antifreeze_target_temp, value=9.0, min_value=5.0, max_value=30.0, extra=0)}
that same i got by mixer
mixers = await ecomax.get_value("mixers", timeout=10);
 mixer = mixers[0]
 print(mixer.data);

message, but sometimes response is full
{'current_temp': 25.925567626953125, 'target_temp': 40, 'pump': False}

next:
hysteresis on start: 0.6
thermo = await ecomax.get_value("thermostats");
print(await thermo[0].get_value('hysteresis'))
await thermo[0].set_value("hysteresis", 8)
print(await thermo[0].get_value('hysteresis'))
6
Timed out while trying to set 'hysteresis' parameter
8

every paramater on thermostats, when i try change i got "Timed out"
i try change day_target_temp 22.1 >> 21.5
i got Timeout, but  day_target_temp changed to 47 (max 35)
i try one more time and still got Timeout but temp was 21.5

thermostat hysteresis is float but here we have int, is this behavior good?
that same by mixer.insensitivity, this value in ecomax is float but here is int

For first problem, that means that regdata schema response get corrupted during transmission, so PyPlumIO doesn't know what to do with regdata. For now there's no way to retry individual requests, but that is planned feature in the near future.
For second, that is expected behavior actually. Since both thermostats and mixers actually constructed from two requests. First is sub-device read-only sensor data, that is contained in MESSAGE_SENSOR_DATA response, and then editable parameters in RESPONSE_MIXER_PARAMETERS or RESPONSE_THERMOSTAT_PARAMETERS.
mixers/thermostats key of device.data becomes available as soon as sensors is available. By this point in time parameters might not be loaded yet. In order to ensure that both sensors and parameters are available I suggest awaiting them before getting their object like in example below.
await ecomax.get_value("mixer_parameters")
mixers = ecomax.get_value("mixers")
print(mixers[0].data)

This way your script will wait until parameters are available and only then request sud-device collection, which will make parameters available in Device.data. Otherwise always just use print(await thermo[0].get_value('hysteresis')) like in your example. This is preferred method, since directly accessing Device.data is not recommended.
As for thermostats I'll look into it. This will take some more reverse-engineering i think :)
P. S. If possible, next time please create separate issues as it is hard to answer and will be hard to find in future. This time, I'll do it for you😉


Can I use this in Angular2?

Is there a way to use this in angular2?
I tried doing something like var Brutusin = require('json-form') but not sure if this is how I can import it in my application.
Thanks,

Hi, yes it can be done.
I am waiting for a coworker response it this matter (he has used it with Angular 2).
I will let you know
Cheers

Yes please, as separating this lib away from angular makes me wanna cry :( as atm have to use iframe just to render the forms in my angular app. Would be nice if it can be imported :)

To add, does the plugin currently support $ref ?

Sorry man, it was Angular 1, and I do not know either of them.
Nevertheless, this google search gives promising results: https://www.google.es/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=angular+2+external+js
If you get some conclusions from all of this, please tell me, so I can improve the documentation.
Also, feel free to fork the project and send me a pull request if some coding is needed (for example for creating a module for Angular 2)

Sure, I've been trying tbh. Is the plugin available on npm by any chance?

I'am afraid is not. We have an open issue, maybe you can help with it: https://github.com/brutusin/json-forms/issues/12


--- FAIL: TestModifiedSince (0.00s)

--- FAIL: TestModifiedSince (0.00s)
    --- FAIL: TestModifiedSince/WithCreateSaveAndDelete (1.17s)
Error:         collection_test.go:956: should have modfied id 01f6qja077rszyvjp9tw4rw817

This failure happen intermittently. I remember this from ages ago... not sure if we introduced a regression somehow. cc @carsonfarmer can you take a look at this?

Taking a look now. Looks like a naive test that I can PR a fix for lickety split!