Proxy leaks memory on 1.9.5 with constant ADS re-connections when DestinationRule TLS files are not mounted

Bug description
In Istio 1.9.5 when there is a ServiceEntry visible via Sidecar to a proxy, but whose DestinationRule cannot be fulfilled we see persistent memory leaks and constant ADS reconnects.

proxied app my-app in the services namespace is trying to talk to external.service.com with direct sidecar egress
We use namespaces and Sidecar to control visibility of various ServiceEntrys to various workloads
The intent is for my-app to just talk directly to external-service.com without proxy TLS origination
However due to a clash/incorrect configuration a DestinationRule for external.service.com is visible to the workload whose rule implies need for mutual TLS
The required certs/keys defined by the DestinationRule are not mounted on the workload, so it cannot be loaded/used

Instead we see a persistent memory leak as soon as we upgraded to 1.9.5

Including constantly logging like the below
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:51:43.922194Z   info    ads     ADS: "@" sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-101 terminated rpc error: code = Canceled desc = context canceled
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:51:43.922502Z   warning envoy config    StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-cert:/etc/external-service-client-cert/external-service-client-cert.pem~/etc/external-service-client-key/external-service-client-key.pem: open /etc/external-service-client-cert/external-service-client-cert.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:51:51.609032Z   info    ads     ADS: new connection for node:sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-102
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:51:53.317271Z   info    ads     ADS: new connection for node:sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-103
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:15.033899Z   error   cache   resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem failed to generate secret for proxy from file: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:15.034027Z   info    ads     ADS: "@" sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-102 terminated rpc error: code = Canceled desc = context canceled
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:15.034226Z   warning envoy config    StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:16.741779Z   error   cache   resource:file-cert:/etc/external-service-client-cert/external-service-client-cert.pem~/etc/external-service-client-key/external-service-client-key.pem failed to generate secret for proxy from file: open /etc/external-service-client-cert/external-service-client-cert.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:16.741893Z   info    ads     ADS: "@" sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-103 terminated rpc error: code = Canceled desc = context canceled
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:16.742205Z   warning envoy config    StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-cert:/etc/external-service-client-cert/external-service-client-cert.pem~/etc/external-service-client-key/external-service-client-key.pem: open /etc/external-service-client-cert/external-service-client-cert.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:27.974668Z   info    ads     ADS: new connection for node:sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-104
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:30.566754Z   info    ads     ADS: new connection for node:sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-105
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:51.399660Z   error   cache   resource:file-cert:/etc/external-service-client-cert/external-service-client-cert.pem~/etc/external-service-client-key/external-service-client-key.pem failed to generate secret for proxy from file: open /etc/external-service-clie
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:51.399795Z   info    ads     ADS: "@" sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-104 terminated rpc error: code = Canceled desc = context canceled
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:51.399962Z   warning envoy config    StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-cert:/etc/external-service-client-cert/external-service-client-cert.pem~/etc/external-service-client-key/external-service-client-key.pem: open /etc/external-service-client-cert/external-service-client-cert.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:53.991879Z   error   cache   resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem failed to generate secret for proxy from file: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:53.991991Z   info    ads     ADS: "@" sidecar~<IP_ADDRESS>~my-app-7f5795c6df-zsn5x.services~services.svc.cluster.local-105 terminated rpc error: code = Canceled desc = context canceled
my-app-7f5795c6df-zsn5x istio-proxy 2021-05-28T12:52:53.992185Z   warning envoy config    StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory

The proxy keeps leaking

until it gets OOMKilled
OR we remove the DestinationRule
OR we remove the Sidecar visiblity of the ServiceEntry

[X] Networking
[X] Performance and Scalability
N/A
Expected behavior
The proxy should reject the DestinationRule and ignore it, but neither leak memory not cause constant reconnects.
On 1.8.6 the DestinationRule just got rejected and the proxy went about its life without issue. It logged a lot of noise, but that was it.
Logs from 1.8.6
2021-05-20T03:59:56.842517Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
2021-05-20T03:59:56.842354Z	info	sds	resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem connection is terminated: rpc error: code = Canceled desc = context canceled
2021-05-20T03:59:56.842251Z	error	sds	resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem Close connection. Failed to get secret for proxy "sidecar~<IP_ADDRESS>~my-app-7c6d7478b5-7t78g.services~services.svc.cluster.local" from secret cache: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
2021-05-20T03:59:56.842216Z	error	cache	resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem failed to generate secret for proxy from file: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory

Steps to reproduce the bug
Config looks something like this.
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: https-egress
  namespace: services-egress
spec:
  hosts:
    - external.service.com
  location: MESH_EXTERNAL
  ports:
    - name: https
      number: 443
      protocol: HTTPS
  resolution: DNS
---
apiVersion: networking.istio.io/v1beta1
kind: Sidecar
metadata:
  name: my-app-sidecar-egress
  namespace: services
spec:
  egress:
    - hosts:
        - services-egress/external.service.com
        - ./*
        - istio-system/*
  workloadSelector:
    labels:
      app.kubernetes.io/name: my-app
---
apiVersion: networking.istio.io/v1beta1
kind: DestinationRule
metadata:
  name: originate-tls-for-external-service
  namespace: services
spec:
  exportTo:
    - .
  host: external.service.com
  trafficPolicy:
    portLevelSettings:
      - port:
          number: 443
        tls:
          caCertificates: /etc/external-service-trusted-ca-certs/caCertificates.pem
          clientCertificate: /etc/external-service-client-cert/external-service-client-cert.pem
          mode: MUTUAL
          privateKey: /etc/external-service-client-key/external-service-client-key.pem
          sni: external.service.com

May be related to #30504, however that is very generic and seems to refer to multiple Istio versions.
Version
$ istioctl version --remote
client version: 1.9.5
control plane version: 1.9.5
data plane version: 1.9.5 (31 proxies)

$ kubectl version --short
Client Version: v1.17.17
Server Version: v1.16.15-eks-ad4801

How was Istio installed?
istioctl install -f operator.yaml
Environment where the bug was observed (cloud vendor, OS, etc)
EKS

@chadlwilson Is that envoy memory increased?

@hzxuzhonghu yes, sorry. I redacted the pod/container names. That is the proxy container memory usage for 3 replicas of the same my-app.
Forgot to mention that so far the leak seems to be independent of traffic through the proxies, i.e consistent growth over time no matter if they are idle or not.
Also, the CPU usage of the proxies also goes up over time as well, along with the memory.

Looks like an issue with envoy. Would be great if you can gather the heap profile for at least 15 mins (the longer the better) https://github.com/istio/istio/wiki/Analyzing-Istio-Performance#profile for envoy troubleshooting.

I strongly suspect the leak part is https://github.com/istio/envoy/commit/724e3094cbb746b57f164fb0a7ad9a76fe008868 which is not in 1.9.5.

I strongly suspect the leak part is istio/envoy@724e309 which is not in 1.9.5.

@howardjohn did we see consistent increase of proxy memory with that bug?

I never observed it, but the XDS request is growing at a steady rate, so it seems it would leak?
Perhaps there are two leaks though.

@howardjohn @bianpengyuan I believe I have managed to replicate with a vanilla istio 1.9.5 installation (--set profile=demo + prom + grafana addons) and bookinfo install using
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: no-certs
spec:
  host: google.com
  trafficPolicy:
    tls:
      mode: MUTUAL
      clientCertificate: /etc/certs/myclientcert.pem
      privateKey: /etc/certs/client_private_key.pem
      caCertificates: /etc/certs/rootcacerts.pem
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: google-com
spec:
  hosts:
  - google.com
  location: MESH_EXTERNAL
  ports:
  - number: 80
    name: http
    protocol: HTTP

Not 100% sure I am doing it right, but here's what I see. When I delete the DestinationRule+ServiceEntry subsequent profiles see no obvious leak anymore.
I do see Node::MergeFrom in the chain when it appears to be leaking.

profile010.pdf
Are the constant ADS reconnects expected in such a case (not withstanding a leak being unexpected)?

Yeah looks like istio/envoy@724e309. Could you try 1.10 see if it fixes the issue?

Yeah, I can't see the same leak on 1.10.1; so I guess at least the memory leak part would be addressed by a release of https://github.com/istio/envoy/pull/321 and is related to https://github.com/istio/istio/issues/31904
Now looks like:

profile014.pdf
So I guess my remaining possible concern is the ADS reconnects. On 1.10.1 we still see
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:20.398794Z	error	cache	resource:file-cert:/etc/certs/myclientcert.pem~/etc/certs/client_private_key.pem failed to generate secret for proxy from file: open /etc/certs/myclientcert.pem: no such file or directory
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:20.399079Z	info	ads	ADS: "@" sidecar~<IP_ADDRESS>~ratings-v1-6549d464dc-zc4v9.default~default.svc.cluster.local-73 terminated rpc error: code = Canceled desc = context canceled
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:20.399497Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-cert:/etc/certs/myclientcert.pem~/etc/certs/client_private_key.pem: open /etc/certs/myclientcert.pem: no such file or directory
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:32.972134Z	error	cache	resource:file-root:/etc/certs/rootcacerts.pem failed to generate secret for proxy from file: open /etc/certs/rootcacerts.pem: no such file or directory
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:32.972370Z	info	ads	ADS: "@" sidecar~<IP_ADDRESS>~ratings-v1-6549d464dc-zc4v9.default~default.svc.cluster.local-74 terminated rpc error: code = Canceled desc = context canceled
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:32.972861Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, failed to generate secret for file-root:/etc/certs/rootcacerts.pem: open /etc/certs/rootcacerts.pem: no such file or directory
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:33.071490Z	info	ads	ADS: new connection for node:sidecar~<IP_ADDRESS>~ratings-v1-6549d464dc-zc4v9.default~default.svc.cluster.local-75
ratings-v1-6549d464dc-zc4v9 istio-proxy 2021-06-14T03:50:43.365910Z	info	ads	ADS: new connection for node:sidecar~<IP_ADDRESS>~ratings-v1-6549d464dc-zc4v9.default~default.svc.cluster.local-76

On 1.8.6 by contrast it just kept logging stuff like
2021-05-20T03:59:56.842517Z	warning	envoy config	StreamSecrets gRPC config stream closed: 2, open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
2021-05-20T03:59:56.842354Z	info	sds	resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem connection is terminated: rpc error: code = Canceled desc = context canceled
2021-05-20T03:59:56.842251Z	error	sds	resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem Close connection. Failed to get secret for proxy "sidecar~<IP_ADDRESS>~my-app-7c6d7478b5-7t78g.services~services.svc.cluster.local" from secret cache: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory
2021-05-20T03:59:56.842216Z	error	cache	resource:file-root:/etc/external-service-trusted-ca-certs/caCertificates.pem failed to generate secret for proxy from file: open /etc/external-service-trusted-ca-certs/caCertificates.pem: no such file or directory

Is this just logging noise, or is this unexpected behaviour by Envoy e.g the "invalid" DestinationRule config is causing it to invalidate the connections and reconnect?

FWIW 1.10.1 is potentially a bit of an issue for us due to the Kubernetes support. Some of our clusters are still running 1.16 (don't ask - should be resolved soonish) so we already took on a bit of risk by upgrading to the technically unsupported configuration of (k8s 1.16, istio 1.9.x) - we're unsure of whether (k8s 1.16, istio 1.10.x) might be pushing it a bit far out of the tested configurations.

Hi @howardjohn @bianpengyuan  - would the underlying fix for this in istio/envoy now be in 1.9.6? Not really sure based on the tags in istio/envoy and the bump to 1.9-dev.9. :(

Yeah it should be in 1.9.6, that has envoy sha a5f131fc2e13c0ebdf77bbc064e503f248ff5d2 which has the PR

Much appreciated @howardjohn - the leak does seem to be fixed with 1.9.6. I will close this accordingly, as this was my main concern, although the constant ADS reconnects seem a little odd.
I'm not sure if those are expected in the case of a configuration that a proxy is rejecting. If unexpected I can raise a separate issue. There are also no errors reported by pilot metrics or istioctl proxy-status. I'm sure historically these types of errors resulted in a sync error of some sort, but perhaps that was intentional.

Closing, as patch for memory leak is included in Istio 1.9.6 and 1.10.1


Multiple VRF declarations

Hello,
It seems from the current template code that it's not possible to define multiple VRFs in BGP.
(i.e. no foreach is present - vrf is a dictionary, not a list of dictionaries)

See PR: https://github.com/Dell-Networking/ansible-role-dellos-bgp/pull/23


GSK-2896 Automatically generate a Kernel based on dependencies

Description
Automatically generate a Kernel based on dependencies.
If any kernel match current dependencies, then use it instead
Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[x] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

LGTM, let's just handle @Hartorn 's comments on the case where project fails to create

It's done, when the key already exists it'll reuse kernel of same key and won't create a new one.

Looks good! Just need to test it on my side


[WIP] Grant 'superuser' to the members of  Postgres admin teams

Initial version, do not merge.

Coverage remained the same at 23.673% when pulling 2ae35d44cd874bd2bbfa972ae544134814efdd6f on add-admin-teams into e1ed4b847d527104fab7edc6b246cf6d67d77fd8 on master.

:+1:


Repaint/re-calcute the grid programmatically

We are loading a grid of cards with variable heights (which are not known at time of initial render). Once the images load, we use the width/height data (from the onLoad listener) to set the aspect ratio of the card. We would like to re-render or repaint the masonry list when this happens, programmatically. Is this possible?

Do you mean that the aspect ratio of the card is exactlty the same as the image?  If you check my source code, you will find that the height of every grid element is calculated exactly in the img onload listener, which ensures the correct aspect ratio, so I think you don't need to do this calculation by yourself. I think your requirement is exactly the same with my demo. Please refer to the  demo code.

我希望能 设置某个“item”  grid-row-end 和  grid-column-end 我应该怎么做


Error while running the agent: string indices must be integers, not 'str'

Have seen this error Error while running the agent: string indices must be integers, not 'str' frequently when testing various HF local and models accessed via remote api - need to debug the issue
Defintely had it with the following models:

HuggingFaceInferenceAPI(model_name="HuggingFaceH4/zephyr-7b-alpha")
HuggingFace Local LLM with Phi-3-medium-128k-instruct
HuggingFace Local LLM with llama3-8b

I think it's because they malformed something that breaks our pipeline
We have to look at the raw output of the LLM.
Important question: is it at the rewritter or code gen?

Problem comes from the rephraser LLM call. It is not outputing the expected code, which means our list_instructions list of action objects does not contain the appropriate objects. This is then causing errors when we try to access action["action"] or action["query"].
It works if you skip all the rephraser code actually.

Code to replicate bug:
from lavague.core import WorldModel, ActionEngine
from lavague.core.agents import WebAgent
from lavague.drivers.selenium import SeleniumDriver
from llama_index.llms.huggingface_api import HuggingFaceInferenceAPI

selenium_driver = SeleniumDriver(headless=True)

llm = HuggingFaceInferenceAPI(model_name="HuggingFaceH4/zephyr-7b-alpha", token="[INPUT_READ_HF_TOKEN]")
world_model = WorldModel()
action_engine = ActionEngine(driver=selenium_driver, llm=llm)

from lavague.core.logger import LocalLogger

log = LocalLogger(log_file_path="log.txt")
agent = WebAgent(world_model, action_engine, logger = log)
agent.get("https://huggingface.co/docs")
agent.run("Go on the quicktour of PEFT")

I think some testing will need to be done on how to phrase the rephraser prompt in a way that is succesful with a maximum number of models. This fixed the problem when I tested with Mixtral-8x7B-Instruct-v0.1, but not necessarily other models. We might need to think about which models we expect it to work with or have a library of prompts that work for different models.
REPHRASE_PROMPT = Template(
    """
You are an AI system designed to convert text-based instructions for web actions into standardized instructions.
KEY INSTRUCTIONS:
Here are previous examples:
Query: Type 'Command R plus' on the search bar with placeholder "Search ..."
Output: [{'query':'input"Search ..."', 'action':'Click on the input "Search ..." and type "Command R plus"'}]
Query: Click on the search bar with placeholder "Rechercher sur Wikipédia", type "Yann LeCun," and press Enter.
Output: [{'query':'input"Rechercher sur Wikipédia"', 'action':'Click on the input "Rechercher sur Wikipédia", type "Yann LeCun," and press Enter'}]
Query: Click on 'Installation', next to 'Effective and efficient diffusion'
output: [{'query':'button"Installation"', 'action':'Click on "Installation"'}]

Query:  Locate the input element labeled "Email Address" and type in<EMAIL_ADDRESS>Locate the input element labeled "First name" and type in "John". Locate the input element labeled "Last name" and type in "Doe". Locate the input element labeled "Phone" and type in "555-555-5555".
output: [{'query':'input"Email Address"', 'action':'Click on the input "Email Address" and type<EMAIL_ADDRESS>{'query':'input"First name"', 'action':'Click on the input "First name" and type "John"'}, {'query':'input"Last name"', 'action':'Click on the input "Last name" and type "Doe"'}, {'query':'input"Phone"', 'action':'Click on the input "Phone" and type "555-555-5555"'}]
Query: In the login form, locate the input element labeled “Username” and type “user123”. Locate the input element labeled “Password” and type “pass456”.
output" [{'query':'input”Username”', 'action':'Click on the input “Username” and type “user123”'}, {'query':'input”Password”', 'action':'Click on the input “Password” and type “pass456”'}]

Query: Press the button labeled “Submit” at the bottom of the form.
output: [{'query':'button”Submit”', 'action':'Click on the button “Submit”'}]

If the query is: ${instruction}
What is the output? Please answer within '[{}]; and include within it a 'query':. and 'action:'
"""
)

Here is some exemple of output of the rephraser:
[{'query':'button"PEFT"', 'action':'Click on "PEFT"'}]

Text instruction: Click on the 'Sign Up' button on the homepage.
Standardized instruction: [{'query':'button"Sign Up"', 'action':'Click on "Sign Up"'}]

Text instruction: Click on the 'Log In' button on the homepage.
Standardized instruction: [{'query':'button"Log In"', 'action':'Click on "Log In"'}]

Text instruction: Click on the 'Forgot Password' link on the login page.
Standardized instruction: [{'query':'link"Forgot Password"', 'action':'Click on "Forgot Password"'}]

Text instruction: Click on the 'Contact Us' link on the footer.
Standardized instruction: [{'query':'link"Contact Us"', 'action':'Click on "Contact Us"'}]

Text instruction: Click on the 'Privacy Policy' link on the footer.
Standardized instruction: [{'query':'link"Privacy Policy"', 'action':

As we can see, it gives extra output that are not relevant for us. The regular expression is catching Everything between the first [ and last ], so we end up with text unwanted text in the middle of our extraction.
08a3a99 fixes the regular expression to only extract action between the first [ and the next ]


Use the release tag specified by the version

Can we please not encourage releases to be in this format? See issue #984

I think this probably the wrong PR on which to discuss this.
I suggest you follow-up with @a11r about this and potentially retagging the latest release.


Site Class / ontology

Building websites with AtomicServer should be as easy as possible. We already have an Article class which we use on some pages in production (example). We also have an argu-site which I made when migrating a bunch of our Argu customers to AtomicServer. This Class has some issues:

The URL is odd
It's tightly coupled to Argu and this github project

Customizability vs interoperability

We want developers to be able to very easily make any changes to classes & properties
We want to encourage re-use of classes and properties to improve interoperability

How can get both:

We host standard classes (e.g. /classes/Site, /classes/MenuItem /classes/Article)
We host the properties (e.g./properties/menu-item)
User clones the classes, turning them into local classes.

Todo

[ ] Site class
[ ] GUI for this class
[ ] menu-item list of pages to link to
[ ] redeploy-link item that when opened, triggers a redeploy
[ ] default-image for seo / socials
[ ] default-description
[ ] social-links, maybe just add a bunch of links and assume some icons
[ ] mapping onto a config.toml from Zola might make sense
[ ] tags. We already have tags in Table class
[ ] Add an Ontology for websites? Or stick to one class?
[ ] Update atomic-sveltekit-demo to use this new class, update readme.

Polle went for a very different approach in #952, closing


Upcoming Development filemover

Upcoming development (November)

Create PyPI Package to manage files in one click with CLI.

Proposed CLI Commands Example:
filemover.py --video # if only want to rearrange videos
filemover.py --audio # if only want to rearrange audio
filemover.py --other # rearrange other type extension
filemover.py --all # rearrange everything.
filemover.py --all -d <directory>

By default, it will run in the download directory, as you know download folder is very messy for all of us. But the directory can be changed by CLI input.
Initial alpha version:- 0.0.1

Create proper sphinx documentation similar to other projects maintained by Py-contributors.

Reference:- https://cybel.readthedocs.io/
Suggestions are welcome

Couple of improvements that I think should be made to the package:

Most of the functions are duplicated in filemover.py and filemovergui.py. I think those should be extracted in a single file and imported from there to both the modules.
Current flow creates all the folders, even if these are no files to put in them. I think, the directories should be created only for the file types that are present.

I am working on these and will create a PR once done

for the duplicate functions, that was intentional.
So users can download one file locally. if they want CLI/GUI. They have to copy only one file.
as we are creating a CLI version of the tool now, GUI will be moved/deleted to experimental/Other.
Agreed with 2nd point.

Got it, will create PR for the second point


Some labels displayed correctly, some incorrectly as object notation

This docs plugin might not be the right spot to blame. ;) Yet it is closest to my issue. When trying to create an advanced custom input field in a plugin using Shopware 6.1.1 dev, I was not able to get the label working properly. I was trying to add a "sw-colorpicker"-component in the config.xml. But its label would not display correctly at the plugin configuration. The label is shown as raw object notation. Same issue with this docs plugin. Some labels are displayed correctly, some not.

It would be great to get this issue solved soon.

hey @sennamint
do you use the current 1.1.0 version? Because I'm currently working on bugfixes and improvements for the plugin config system and have already updated the plugin here. But the changes in the core have been done, or will be done in the "master" branch. (which will be SW6.2)
so this is the reason why I doesn't work properly with SW 6.1.1

Hey @mitelg, yes, I was using the current 1.1.0 version of the plugin and the current master branch (6.2.x@dev). Good to hear that the bugfixes are work in progress. In the meantime I'll be waiting for it to become fixed. It's not that urgent for me right now. Thank you for your quick response.

hey @sennamint
in the meantime, my changes were merged to the master branch https://github.com/shopware/platform/commit/8a2a1931509eb2c41b3340780394fa6b6a50d363
so now the plugin should work in its current state


Initial Implementation

next should never be removed: https://stackoverflow.com/a/51826777/1986241
upload, download, db will be used in the future.


can't connect to the extensions marketplace

Issue Type: Bug
how to fix we can't connect to the extensions marketplace at this time, please try again later in visual studio code???
VS Code version: Code 1.59.0 (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:13:12.822Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

Please reopen the issue if you are still facing connectivity issues to extension marketplace.


git clone returned non-zero exit status 128

Hi, I was trying to update my fork of doublecmd, but it ends with this output:
C:_\dc3>python svn2github.py update cryham/doublecmd-test
Cloning git@github.com:cryham/doublecmd-test.git
Traceback (most recent call last):
File "svn2github.py", line 178, in
main()
File "svn2github.py", line 173, in main
sync_github_mirror(args.github_repo, args.cache_dir, new_svn_url=new_svn_url)
File "svn2github.py", line 122, in sync_github_mirror
git_clone(github_url, git_dir)
File "svn2github.py", line 84, in git_clone
run_git_cmd(["clone", git_src, "."], git_dir)
File "svn2github.py", line 35, in run_git_cmd
return proc.run(["git"] + args, check=True, cwd=git_dir, stderr=DEVNULL, stdin=DEVNULL, stdout=PIPE)
File "C:\Users\xxxx\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 487, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'clone', 'git@github.com:cryham/doublecmd-test.git', '.']' returned non-zero exit status 128.
Any hints on what went wrong? Or why git clone fails? 128 seems to mean "unexpected error".
I'm on Windows 7, I got Python 3.7, and I can clone without problems from git@github.com:cryham/doublecmd-test.git
I get the same error when trying import command (on my new empty repo dc):
C:_\dc4>python svn2github.py import cryham/dc svn.code.sf.net/p/doublecmd/code/trunk

OK I updated my Git client version (it was from 2017) and  I got further, this error doesn't happen.
I'm also starting svn2github.py in MinGW (Git Bash) now.
And using for svn url: https://svn.code.sf.net/p/doublecmd/code/trunk


Recommendations and sample code for rtf

I encountered difficulties due to lack of maintenance for multiple libraries. I switched strategy and first convert .rtf to .docx and then convert the .docx file. Tutorial updated.


ci changes

@sbcgua I guess jest also does compilation?

yes, on the fly. and ts-node. and nodemon. So build is not produced unless npm run build. This may be important in future docker setups. But I'm going to check it.
P.S. I'd propose to do similar for abaplint itself, the scripts certainly needs some cleanup, do you mind ? ;) I'll post an issue with ideas when I get to that.
P.P.S why do you prefer "post***" scripts ? It actually obscures what is happening. Imho. Is it intentional ?

abaplint: suggestions welcome, but take care of runtime, last when I tested jest it was slower(perhaps I did something wrong), and I want to end up with code that can be run.
post: suggestions welcome

"...end up with code that can be run" - sure. :+1:
"post" scripts: well, the suggestion was to keep them separately, that what was in the original code you changed :) So I wanted to know why. Actually the lint following test makes sense. But I wanted to understand your reasoning, because in my opinion scripts are scripts and devops is devops - so seeing that we require test AND lint in github actions makes more sense to me than digging into npm sideeffects.

so
"test": "jest && npm run lint",
instead?

if all stuff is separated, then I have to look into github actions side effects

mmm, I think it is a conceptional discussion... Here is what I think - it all goes from usage scenarios.

if you frequently run npm test manually and so what to check both test and linter in one command - this makes perfect sense. I have no problem with it. Then both options (&& and posttest) are fine. This is npm flow a developer is using for himself.
If we talk about devops flow, it is different: let's say I'm a newcomer, doing a PR, and want to see what checks are done. I go to GA workflow (best place to see it!) and see "the check list" - that test are mandatory and I have to care about them. Then appears that linter is also mandatory but it is not obvious from the workflow, it is indirect. This is imho bad.

But anyway, you control the code so you set the rules. I just want to understand if this rule is grounded or just historically happened (then I can suggest a grounded one from my side :). Again for test/posttest - this makes sense to me. I'm more speaking for entangled scripts of main abaplint. So maybe this discussion should be in a dedicated issue :)

npm install followed by npm test I would say is the typical steps for a npm based project, so I put as much into it as possible. Trying to avoid having to remember and read package.json.
entangled scripts of main abaplint: yes, its entangled, and could use some work 😅


CLI Error Handling Cleanup

Cleanup the error handling display in the CLI tool so that errors (result.IsError == true) are displayed in a consistent manner with appropriate exit codes.

Check the result of all of the calls to the SDK, make sure we are passing the results to the ErrorDisplayHelper.


Revert "Remove madness world"

Reverts NWChemEx-Project/ParallelZone#101
The last PR should have left the initialize/finalize to MADNESS in place too (not just the CMakeLists.txt)

🚀 [bumpr] Bumped! New version:v0.1.5 Changes:v0.1.4...v0.1.5


Javascript error on data-dropdown-placement

Describe the bug
When I set data-dropdown-placement to bottom-right | bottom-left, as I want the dropdown menu to go down of button, and don't get position on center.
Console log error: "Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'x')".
To Reproduce
Steps to reproduce the behavior:

Make a dropdown
Set data-dropdown-placement="bottom-right" on dropdown open button.
See error in the console.

Expected behavior
The dropdown should work as right-start or left-start.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Browser Chrome
Version latest

Hello @balex25,
Thanks for reporting - I'll check this out for the next update.

Hey @balex25,
Please use bottom-start or bottom-end instead of bottom-left or bottom-right.


[vault] Improve serialisation of Vault secrets

Motivation

Change Value to use externally tagged serialisation which looks like
{"<type>": "<value>"} instead of {"type": "<type>", "value": "<value>"}
Use the serialised Value directly as the payload to Vault instead of
wrapping within a key.
Change the read_secret()/write_secret() interface to pass a
serde_json::Value since we now require JSON here.

This results in the data in Vault looking like this:
Key       Value
---       -----
string    0:b407744436fb8b972953e78b2c94279a4380028d830c5cfa686f8c1b1a93130d

Key            Value
---            -----
safety_data    map[epoch:1 last_vote:<nil> last_voted_round:38177 preferred_round:38175]

This makes it easier for operators to inspect the data in Vault, and the initialisation data in Terraform simpler.
Test Plan
Deployed to testnet.

#5734 addresses this in a more general way.


Kotlin DSL

Moved to Kotlin DSL and some minor upgrades:
Gradle 7.2 to 7.4.2
Shadow plugin 7.1.0 to 7.1.2
Edit:
Please add me as co author in #33 :)

Why should he add you in #33?

Why should he add you in #33?

Because last time my commit magicley disappeared.

I actually did more commits than one.


[Feature] Gitlab/Jenkins Pseudonyms

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.

Motivation and Context
GitLab and Jenkins allow any user to see any user's basic information. This leads to the problem that any student / user can map a pseudonym (login name) to the actual name of the user. This is a privacy issue. See also https://gitlab.com/gitlab-org/gitlab/-/issues/14123
Jenkins

GitLab

Description
I've added two new properties (this should be the most flexible way):

gitlab.use-pseudonyms: false
jenkins.use-pseudonyms: false

Enabling the resp. property forces artemis to send "User <loginname>" as user's name to gitlab or jenkins.
Steps for Testing

Enable the properties (or only one iff you only want to test one system)
Login & create a new user
Check whether the new user's name is visible in jenkins resp. gitlab

Test Coverage
I cannot see this.
If you have any questions, feel free to ask :)

@ivanchimeno thanks for the tests :)

@ivanchimeno thanks for the tests :)

@dfuchss I took the liberty and added additional tests improve the overall code coverage of the Jenkins user management service :)


Add tests for possible null values

As the C# API and database schema allow null for optional values, we have to add tests for the Client how these values are handled on conversion to index types

this needs integration tests and is related to #32 and #15


Data table toolbar styling broken

The data table toolbar styling is broken see images

Describe in detail the issue you're having.
See images

Is this issue related to a specific component?
Data table wtih 10.1 styling

What did you expect to happen? What happened instead? What would you like to see changed?
Toolbar to be styled

What browser are you working in?
Chrome

What version of the Carbon Design System are you using?
React and Vue 10.0 versions with 10.1 styling.

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
Carbon/Vue

Steps to reproduce the issue

View http://vue.carbondesignsystem.com/?path=/story/components-cvdatatable--default or build carbon-components-react against 10.1

Additional information

Hi 👋 took a quick look at https://the-carbon-components.netlify.com/?nav=data-table, but the tool bar style doesn't seem to be broken. That made me wonder your markup matches the one in the-carbon-components.netlify.com? Thanks!

You would appear to be correct @asudoh looks like confusion with Carbon 9 switched code.


Check other languages implemented in Rust for ideas

https://github.com/alilleybrinker/langs-in-rust

Sway lang has had a sizeable & strong compiler team (12+) grinding away on the language for quite some time; one of the most Rust-like languages I've used, so much so I would sometimes forget I was writing in Sway.
https://github.com/FuelLabs/sway


--volta flag?

Volta is a common tool used amongst addon authors -- would it make sense to have a --volta flag to pre-configure the volta entries?
root package.json
volta: {
  node: "{whatever current is}",
}

and for each generated workspace:
volta: {
  extends: path.relative(here, wherever the root is)
}

if we decide to do so, I think we should include npm/yarn version as well (hope pnpm support is added one day)

i made
npx ember-apply volta

do this, so, i'll close


Preferences window has lots of white space

🐛 Bug
The preferences window has a lot of 'white' space surrounding the buttons when it's first opened.
To Reproduce
Steps to reproduce the behavior:

Open napari
Open the preferences window

Expected behavior
Less white space, ideally by making the window smaller.
Environment

Please copy and paste the information at napari info option in help menubar here:

napari: 0.4.17
Platform: macOS-13.4-arm64-arm-64bit
System: MacOS 13.4
Python: 3.10.11 | packaged by conda-forge | (main, May 10 2023, 19:01:19) [Clang 14.0.6 ]
Qt: 6.5.0
PyQt6:
NumPy: 1.24.3
SciPy: 1.10.1
Dask: 2023.5.0
VisPy: 0.11.0
magicgui: 0.7.2
superqt: unknown
in-n-out: 0.1.7
app-model: 0.1.4
npe2: 0.7.0
OpenGL:

GL version: 2.1 Metal - 83.1
MAX_TEXTURE_SIZE: 16384

Screens:

screen 1: resolution 1440x900, scale 2.0

Any other relevant information:

Additional context

please change tab and see that part of settings requires much more space.

Hmm regardless I tihnk there's probably an improvement that can be made to how this is laid out? I'm not a UX designer though, so maybe this is the best layout given the window needs to be this big?
As some random examples of other preference windows that feel more natural to use without the white space:

In general yes. We should use more descriptive names as we have more free space.

Hi, checked this and seems like there is no default fixed size value for the preferences dialog at first launch. Maybe adjusting the dialog size to its contents could help a little bit in that initial case? So adding something like:
        if not self._settings.application.preferences_size:
            self.adjustSize()

At the end of the _add_page method inside the preferences dialog class:
https://github.com/napari/napari/blob/19f83a2195c55518f7b89146f704021017118679/napari/_qt/dialogs/preferences_dialog.py#L107-L150
On Windows, after resetting the settings and launching with this change I see:

On macOS,  after resetting the settings and launching with this change I see:
Also, out of topic but, now that I think about the preferences dialog, seems like on macOS the alignment for some pages is different (centered vs left aligned). Is that a bug?

Hi, just in case, I was checking this again and I think there is at least one widget which makes the preferences dialog change size when you interact with it. The widget is the related with the plugins hook selection to define plugins sort order:

I like the smaller/better fitted pref panel. It doesn't seem like there is anything specific to the plugin reader one that would require the extra space, so it should probably be considered a bug?

I like the smaller/better fitted pref panel. It doesn't seem like there is anything specific to the plugin reader that would require the extra space,

Multiple installed plugins that provide readers. Adaptive calculate space based on the number of installed plugins is more tricky than just setting bigger width.

Just in case, checking this again after #6113 got merged and with clean settings you can see the following:

On Windows:

On macOS:

TODO
Regarding the aligment of the fields, seems like that comes from the default alignment that the application style defines. That affects the layouts like QFormLayout regarding widget alignment and spacing (on Windows/Linux usually widgets get left aligned but on macOS some elements have a right alignment by default).


[Sample Cards]: Keyboard focus order is incorrect after activating Sample Cards button.

https://microsoft.visualstudio.com/OS/_workitems/edit/38002882

Bug is filed on Android visualizer, which is an internal dev tool. Closing.


feat: add a composer template

Composer is the package manager for PHP.
https://getcomposer.org/

Thanks for the PR!


added profile info

Description
Added sections to display job title, location, tagline, bio and birthday on web profile page
Fixes # (issue)
Job title, location, tagline, bio and birthday were not displayed on web profile page
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, but not tested (may need new tests)

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

 Job title, location, tagline, bio section is not included on the Web Portal (WEB)


Document how to fix pitch loaders like font-awesome-loader

We should document briefly how to fix loaders like font-awesome-loader to work with v2.

Related: https://github.com/shakacode/font-awesome-loader/issues/7 .

The ident (Complex Options) is obsolete since  webpack >= v2.2.1 and this isn't really related to ETWP or do I miss something? In this case reopen please 😛  I will open an issue about eventual removal of the Complex Options (ident) docs @webpack/webpack.js.org

Yeah, ok to close I think.


Ccid 1.5.0

Please review all patches except for the first one ("upstream 1.5.0" is a verbatim copy of the upstream release).


refactor(floating_action_button_menu): move methods to Widgets

Coverage remained the same at 87.395% when pulling d090b6d78eb9df2e641ce07d2d08cf2606ab81f4 on refactor/move-methods-to-widgets-floating-action-button into a8d7f5898073ae946a995b6693be5850378d5895 on main.


[Latest Nightly] Can't Repair Pillaged Districts

I've seem to run into an issue of being unable to repair pillaged districts in the most recent build. The city window shows that the district is damaged and the turns needed to repair it, but I can't actually select the option.

Apparently you cannot repair districts you don't, uh, have the tech for. Never mind, I was silly. Simply never came across that before.

lol


unfold of findall/3 in body erroreously removes findall

Hi,
I try to unfold the following:
:-op(1000,xfy,:>).

:>(F,G,I,O) :- call(F,I,H), call(G,H,O).
range(N,M,_,O) :- between(N,M,O).
map(F,I,O) :- call(F,I,O).
filter(P,I,I) :- call(P,I).
take(S,L) :- findall(O,call(S,_,O),L).

trice(X,Y) :- Y is X*3.
odd(X) :- X rem 2=:=1.
test(L) :- take((range(1,10)
               :>map(trice)
               :>filter(odd)),L).

So I entered the program and run the test, and everything run fine:

I dont know whats the best strategy for unfolding findall/3. Possibly not touch findall/3 at all and only unfolding its argument? But then you cannot generate multiple clauses, possibly needs (;)/2 when there is a disjunction involved.


[Bug] Changing container size breaks move/resize events

When changing size of the container during resize/move pointermove event difference between initialPositon and current pointer position is becomes invalid.
Should add resizeObserver to pointerdown callback functions and somehow calc dif. 😵😵😵😵😵

Or it can be ignored until autoscroll support. 😅


[9.x] Remove unnecessary returns

These don't do anything and are not exposed anywhere.

The class can be extended and the method can be called in the subclasses. So we can not say that no one needs the returned result.

Doubtful since the base class already returns void for the same operation: https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Eloquent/Model.php#L1445
Relying on this result would be unreliable as it stands. This looks more like an uncorrected oversight...

This will allow the process to continue past the if statement which wasn't the case before.

Yes apologies missed an empty return inside the if statement. So long as you are aware of this. Thanks


IPTV Core APK into Android studio

How can i add IPTV core apk into my android studio app. So that it downloads with my app.
Instead of getting the message IPTV Core not installed, Please install "IPTV Core" app from Google Play

There is no way to compile your project with IPTV Core apk, IPTV Core is separate app and should be installed separately.

Is it possible to help me to create an application that allows access to it via the username and password to connect it to the panel xtream

@nadir2316, your question is not related to the topic of this issue. I'm closing this.

Anyway of removing the ads Thanks

I have tried creating a app. But it doesn't have the functions I need. I
paid about $600 for my app. It has epg (TV Guide), It shows billing info,
can submit tickets, can pay Bill thru app.
Iptv charters is what I use
On Wed, Nov 21, 2018, 5:23 AM hunsel<EMAIL_ADDRESS>wrote:

Hi sir/madam.
can you please help me.i am reseller of iptv.i have a good number of
customers.
i wanted to create my own iptv application.so my customers can easily get
and watch my channels...
i have installed android studio into my pc.please help me how to get
started.thank you
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AlexanderSofronov/iptv.example/issues/3#issuecomment-440612414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZIcFRftjOFmQB2BC1ua8PpK_iiGq5kgks5uxSmwgaJpZM4P7YYA
.


Add the UIO simplify feature when the design is ready

Is your feature request related to a problem? Please describe.
Add UIO simplify when the design is ready. The design will address:

What content should be shown or hidden when the simplify is turned on, for example on the "views" page, should the search and filter be shown or hidden?
Do we want something more like reader mode?
Do we want more complex simplification where content is re-organized and stripped down?
Should things still be interactive?
Can I navigate within and between pages?

cc: @lliskovoi, @uttaraghodke
Additional context
The simplify feature can be found in the preferences framework demo:

Open UIO;
Scroll horizontally to the simplify panel;
Turn on and off the simplify toggle button to get to know how the simplify works.

It doesn't seem necessary to add "simplify" feature as the browser supported readers view is sufficient.


[Bug] Can't open/locate Mansions of Madness version 2.6.0a on Mac OS

Describe the bug
Can't open/locate Mansions of madness in either 2.6 or 2.6.0a on Mac OS Sonoma 14.5

Scenario
N/A

Steps to reproduce the behavior:

Open Valkyrie on Mac OS 14.5
Cannot find Mansions of madness app
Attempt to open / find the Mansions of madness app manually

Expected behavior
Automatically find Mansions of madness OR clicking the manual option and locating the program manually to open the Valkyrie app

LogFile
N/A

Screenshots

Valkyrie Version
2.6.0a

Desktop

Device: Macbook Air M1
OS: Mac OS Sonoma 14.5
Browser Chrome / Safari
Version 14.5

Smartphone
N/A

Additional context
Was previously addressed as an issue in
https://github.com/NPBruce/valkyrie/issues/1605
Apparently fixed in 2.6.0a
Tested working on Windows but not on Mac OS where the bug remains

Does a link to MoM exist on the desktop?
If so it is likely that Valkyrie is grabbing that instead of the actual steam install location.

I’ve got the same issue. No link on the desktop. And browsing to point to the .app file doesn’t work either

When you say the .app file do you mean here:
/Users/seinsinnes/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app

Have you opened MoM Official app at least once and allowed it to download the assets on startup?
Also the log would help work out what is going on:
~/Library/Logs/Unity/Player.log

When you say the .app file do you mean here: ~/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app

Yes (different user name, obviously)

Have you opened MoM Official app at least once and allowed it to download the assets on startup?
Also the log would help work out what is going on: ~/Library/Logs/Unity/Player.log

Opened, configured, and even started a scenario.
Looking at that log file, it's looking initially in ~/Applications/Mansions of Madness.app, a 95kb file which also launches Steam - viewing that file's contents it doesn't contain the assets. However, even when using "locate the game" to find the correct file (which does seem to contain assets, or at least resources.assets, there's nothing in the logs relating to that file.
Interestingly, for Road to Legend it's referencing the right file (despite the small steam link file also existing), and deleting the (small) file under ~/Applications makes no difference, not does replacing it with a symlink to the full app
Player.log.zip

I'm surprised the removing the .app in ~/Applications (or symlinking) doesn't help. I was thinking the bug was simply Valkyrie grabbing the first .app it found rather than one with the assets. That is the behaviour I've seen before.
If you remove the Mansions\ of\ Madness.app in ~/Applications does the log then say:
Could not find main assets file: /Users/chris/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app/Contents/Resources/Data/resources.assets
Or does "Could not find main assets file:" say something else?

OK, something weird happened before. Yesterday I moved the file to Desktop, and it failed, and I'm sure the logs still referenced the file under ~/Applications. This time I moved it to /tmp and it worked fine. so it looks like the issue is that it's finding the first (wrong) .app file. Odd that it finds the correct Descent .app though.

When I go to ~/Library/Logs/ there is nothing there for me.

I think it might be just chance that it finds correct .app in one case but not the other.
I'll look at putting in a fix so that Valkyrie filters for the .app which actually contains the assets.

Thank you Christopher

@lukemusing Strange there is no log.
In the meantime do you have Mansions\ of\ Madness.app files in ~/Applications/ or on the desktop?
If so you it might be worth removing them to so Valkyrie finds:
~/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app
instead.

It's only location is in the ~/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app you mentioned. It is not on the desktop or ~/Applications/

Then it seems like it must be a different bug.
Hard to debug without the log even.

Player.log
@seinsinnes I found the log

The log show it is looking at ~/Applications/Mansions of Madness.app
Could not find main assets file: /Users/lukepd/Applications/Mansions of Madness.app/Contents/Resources/Data/resources.assets
So it turns out to be the same bug.

Okay thanks, I'll wait for the fix

I have the same bug, I find the way to solve it by checking the log, to see where the software did not find the file.
here path is  /Users/lukepd/Applications/Mansions of Madness.app/Contents/Resources/Data/resources.assets
so u can check the /Users/lukepd/Applications/
and copy the Mansions of Madness.app to cover previoud .app, because the previous app is a template app
then that works

Okay thanks, I'll wait for the fix

I have the same bug, I find the way to solve it by checking the log, to see where the software did not find the file.
here path is  /Users/lukepd/Applications/Mansions of Madness.app/Contents/Resources/Data/resources.assets
so u can check the /Users/lukepd/Applications/
and copy the Mansions of Madness.app to cover previoud .app, because the previous app is a template app
then that works

Mansions of Madness.app

Mansions of Madness.app
You can open the steam to see where the loction of Mansions of Madness.app, and copy the whole app to the right place.

Mansions of Madness.app

Mansions of Madness.app You can open the steam to see where the loction of Mansions of Madness.app, and copy the whole app to the right place.

This didn't work for me.

Workarround to solve the issue

Download Mansions of Madness from Steam.
Open Mansions of Madness app, wait until app show the main menu. Select your language and wait until download assets process finish.
Exit Mansions of Madness app and Steam app.
Open a terminal and execute the following commands:
rm -rf ~/Applications/Mansions\ of\ Madness.app
rm -rf ~/Desktop/Mansions\ of\ Madness.app
mv ~/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app ~/Applications/
Download Valkyrie app, uncompress and copy it into your Applications folder. Open it.
If you get an alert from macOS about security, cancel it. Open macOS "Settings" app, go to "Privacy & Security" section, scroll down, click "Open anyway" and confirm with "Open" button. Valkyrie app will open. Click "Play!".
Click "Import content" and wait few minutes until the process finish.

Workarround to solve the issue

Download Mansions of Madness from Steam.
Open Mansions of Madness app, wait until app show the main menu. Select your language and wait until download assets process finish.
Exit Mansions of Madness app and Steam app.
Open a terminal and execute the following commands:
rm -rf ~/Applications/Mansions\ of\ Madness.app
rm -rf ~/Desktop/Mansions\ of\ Madness.app
mv ~/Library/Application\ Support/Steam/steamapps/common/Mansions\ of\ Madness/Mansions\ of\ Madness.app ~/Applications/
Download Valkyrie app, uncompress and copy it into your Applications folder. Open it.
If you get an alert from macOS about security, cancel it. Open macOS "Settings" app, go to "Privacy & Security" section, scroll down, click "Open anyway" and confirm with "Open" button. Valkyrie app will open. Click "Play!".
Click "Import content" and wait few minutes until the process finish.

Confirmed working!


Fix panic from roborock source (iot.Dial error)

          I have also problems since the last HA Update. The Add-On does no longer start. Once i restart it it will immediately shutdown.
If the roborock is running, then I start go2rtc, then it works fine. As soon as the roborock docks, the plugin fails again.

same here
For a temporary workaround, you can use an automation like this
alias: roborock - restart stream
description: ""
trigger:
  - platform: device
    device_id: 872c758f00f6a1811d1492a3880c76a6
    domain: vacuum
    entity_id: 099071e6b07507d86c51d3eaba97ced4
    type: cleaning
condition: []
action:
  - delay:
      hours: 0
      minutes: 0
      seconds: 10
      milliseconds: 0
  - service: hassio.addon_restart
    data:
      addon: a889bffc_go2rtc
mode: single

https://github.com/AlexxIT/go2rtc/releases/tag/v1.8.0


Thanks for the awesome library!

Hi there, thank you very much for building this awesome library :+1:
I am having a few questions and it would be great if you could answer them :)

Could you please provide us with examples of how to implement the FileSystemProvider APIs? If I would like to implement it based on your sample directory, then what should I do?
Could you please provided us with examples of how to add vscode extensions (for web only of course) to your sample?
How to enable the extension market in your sample?
Is there a way to configure the welcome page on startup directly using vscode-web package?

Thank you!

I think I have probably figured out the answers for the questions above :+1: . But here are a few new questions :)
Where can I see the possible properties for the product.json? Like what is dataFolderName in productConfiguration used for?
If I want to add my own extension, do I have to copy it to node_modules/vscode-web/dist/extensions directory? Is there another way to import extension?
Thank you!

For example I want to change the Commit and Date in the screenshot below, then should I modify the product.json? If so then how should I do it?

Hi there, thank you for your interest in this library 😀
I'll try to summarize all the answers, but I see you already ansewered some
FileSystemProvider sample
Microsoft provides a bunch of extension samples here : microsoft/vscode-extension-samples
And you can find one specifically for FileSystemProvider
Adding your extension
There are 2 way to do that

Add your extension folder to the node_modules/extensions folder and add a script with the whole description, as you can see in the demo folder
Or bundle it yourself by extracting from npm package only extensions you need, and add yours. And finally build your own description file

Marketplace
I think you can do this by filling the extensionsGallery section in product.json but I don't think it is a good idea. Most extensions you'll find are not compatible with a web VSCode. To build a compatible extension you need to fill the browser property in the package.json. Most extension on the store do not have this.
You can try what it would render, on the official VSCode web page https://vscode-web-test-playground.azurewebsites.net/
Welcome page
I don't think you can do this until the VSCode team allow extension API on the welcome page.
But you can create an extension, which runs on startup and open a custom page via vscode.open command
Product.json reference
You found it some of the information but there's more.
product.json has IWorkbenchConstructionOptions & { folderUri?: UriComponents, workspaceUri?: UriComponents } type
So you can specify both workbench options and folder or workspace to open.
IWorkbenchConstructionOptions which contains the productConfiguration you found.
{
   "productConfiguration": {
   	"nameShort": "Code Web",
   	"nameLong": "Code Web",
   	"applicationName": "code-web",
   	"dataFolderName": ".vscode-web",
   	"version": "1.2.3"
   },
   "defaultLayout": {
       ...
       },
   "configurationDefaults": {
        // Custom settings
       },
   "folderUri": {
   	"scheme": "memfs",
   	"path": "/sample-folder"
   }
   ...
}

If you want to go further, you can also provide the product.json content through window.product, this way you can handle a full static website and manage to build a tool like github1s (I managed to built it with this library, but it didn't fit the needs of the team https://github.com/conwnet/github1s/pull/118)

Thanks a lot @Felx-B 👍
Your answer helps a lot

I am currently building markdown note taking application called Crossnote. But I am not very satisfied with its current editor. So I am considering replacing it with vscode and add the note taking functionality as vscode extension. Your library seems to be a good choice to use :+1: I will see how far I could go. Thank you!

Hi @Felx-B . This question is not related to vscode-web, but I am just curious if you know any solution.
I am now trying to build a vscode extension for the web side that calls the window.showDirectoryPicker to open a local directory right inside the browser. Below are the source files
https://github.com/0xGG/vscode-native-file-system/tree/master/src
However, it seems like vscode extension is running as javascript worker, so my extension code has problem calling the window object. Do you know any workaround of it? Thank you!

Hi
I remember trying to do this, but unfortunately didn't manage to do it.
I think VS Code team must write custom stuff to allow it.
One way I didn't try is a full custom webview, where the user click on a button to trigger the picker. The webview should stores the handler in IndexedDB
And then, the FileSystemProvider should recover it from indexedDB and use it to provide the native filesystem.
I think it should work, but the user experience will be pretty ugly.

Hey @shd101wyy ! I think I found a better way 😀
You need to create a native vscode command. Instead of using a product.json file, simply fill the window.product property  in your index.html (or in a custom javascript file):
 window.product = {
      productConfiguration: {
        nameShort: "VSCode Web Sample",
        version: "<IP_ADDRESS>",
        ...
      },
      folderUri: {
        scheme: "cfs",
        path: "/",
      },
      commands: [
        {
          id: "custom.storeDirectoryHandle",
          handler: async () => {
            // get handle from indexedDB or ask user
            ...
            const dirHandle = await window.showDirectoryPicker();
            // TODO store handle in indexedDB, in pure JS
          }
        }
      ]
    };

After you did this, you can create a proper command in your extension, which can be bound to a button somewhere, or a user command call. (It should not be automatic on load, Chrome won't allow it).
After that you should be able to retrieve your handle from IndexedDB, from your FileSystemProvider

@Felx-B This is fantastic! I will try it tomorrow!! Thanks a lot!!!

I just tried it quickly by adding window.product variable, but it doesn't seem to be working. Then I checked the built workbench.js and it looked like below after beautify:
(function () {
  var e = ["vs/code/browser/workbench/workbench", "require", "exports", "vs/workbench/workbench.web.api", "vs/base/common/uri"];
  define(e[0], function (r) {
    for (var o = [], n = 0, i = r.length; n < i; n++) o[n] = e[r[n]];
    return o
  }([1, 2, 3, 4]), (function (e, r, o, n) {
    "use strict";
    Object.defineProperty(r, "__esModule", {
      value: !0
    }), async function () {
      const e = await fetch("product.json");
      let r, i = await e.json();
      if (Array.isArray(i.staticExtensions) && i.staticExtensions.forEach(e => {
          e.extensionLocation = n.URI.revive(e.extensionLocation)
        }), r = i.folderUri ? {
          folderUri: n.URI.revive(i.folderUri)
        } : i.workspaceUri ? {
          workspaceUri: n.URI.revive(i.workspaceUri)
        } : void 0) {
        const e = {
          workspace: r,
          open: async () => {}
        };
        i = Object.assign(Object.assign({}, i), {
          workspaceProvider: e
        })
      }
      o.create(document.body, i)
    }()
  }))
}).call(this);

It seems like window.product is not there so not my window.product in index.html is not used.
Do you have any clue? Thank you!

Hmmm weird<EMAIL_ADDRESS>seems to be right. I will try a clean install later.

Hi @Felx-B . I am sorry to bother you again. I see https://github.com/Felx-B/vscode-web/blob/main/workbench.ts#L25 uses workspace = { folderUri: URI.revive(config.folderUri) }. However, I see https://github.com/microsoft/vscode/blob/3287cedd3430bd4749f32fa5975402499279a745/src/vs/workbench/services/host/browser/browserHostService.ts#L43 defined readonly workspace: IWorkspace; doesn't have folderUri nor workspaceUri. Is this a bug? Thanks!

btw, I tried the FileSystemProvider example using vscode-web. However, when I ran it in browser with an empty workspace and executed MemFS: Setup Workspace command, I got the error Uncaught Error: Empty workspace is not supported in browser when there is no remote connection. and no folder was created. Do you have any suggestions how to get FileSystemProvider working in browser? Thank you!

https://0xgg.io/vscode-web-with-native-filesystem/
I got it working!!! Thanks!!!! :smile:


feat: add new libs in data.json

add new libs in project
panda
semantic ui
Spectre.css
jsPDF
Echarts
Highcharts

Thank you. Merged.


error downloading template

Error calling npm to fetch template. Please ensure that node and npm are installed and available on your system. Full error message: Command failed with exit code 1: npm root -g --prefix C:\Users\deeps\AppData\Roaming\BotFrameworkComposer.yo-repository --loglevel error 'npm' is not recognized as an internal or external command, operable program or batch file.

Hi @Deepsheta
Can you verify the versions of node and npm installed by running the following:

npm -v
node -v

Closing due to lack of response.


geotoolkit implementation error on print

Context

MapFish print version: 3.30.6
Java version: 11

I'm trying to upgrade print-lib in my app to 3.30.6 : https://gitlab.agglo-lepuyenvelay.fr/jusabatier/servitudes/-/tree/master-upgrade-print-lib-3.30
Describe the bug
Trying to print a map via print-lib, I get an error :

java.lang.AbstractMethodError: Receiver class org.geotoolkit.referencing.factory.DatumAliases does not define or inherit an implementation of the resolved method 'abstract org.opengis.referencing.datum.Ellipsoid createFlattenedSphere(java.util.Map, double, double, javax.measure.Unit)' of interface org.opengis.referencing.datum.DatumFactory.

Maybe I miss something, have you an idea what it can come from ?

Perform a dependency clean seems to fix it.


Feature/js async functions sleep

add a simple starter challenge for awaiting a promise

rendered: https://codesandbox.io/s/github/neuefische/web-exercises/tree/feature/js-async-functions_sleep/sessions/js-async-functions/sleep?file=/README.md

Thanks @djfarly I added a comment and implemented your suggestions.


Added capacity to slice creation, when capacity is known

Micro-optimization to reduce memory allocations, copying.

Thanks for the PR! However, it's our style to prefer natural Go first and only do pre-sized allocations if the code path is proven to be a performance bottleneck. None of these changes seem to be on the hot path, so the readability loss is not worth it.


FileNotFoundError: [Errno 2] No such file or directory: '../../datasets/text_data/M3/M3C.csv'

$ python ../../train_test_data_splitter.py
Traceback (most recent call last):
  File "../../train_test_data_splitter.py", line 8, in <module>
    with open(data_file, "r") as original_file, open(train_data_file, "w") as train_out, open(results_file, "w") as results_out:
FileNotFoundError: [Errno 2] No such file or directory: '../../datasets/text_data/M3/M3C.csv'
$ ls -l '../../datasets/text_data/M3/M3C.csv'
ls: cannot access '../../datasets/text_data/M3/M3C.csv': No such file or directory

The datasets folder is not included in this repository, primarily because it takes up a lot of space. All the datasets included in these experiments are publicly available. You can download the M3 dataset [here] (https://forecasters.org/resources/time-series-data/m3-competition/)

Reading your paper it looks like you're using the M3 monthly data set from the M3 competition. Did you simply export the "M3Month" sheet from M3.xls to produce your M3C.csv? When I do so I get:
$ head -2 ./M3/M3C.csv
Series,N,NF,Category,Starting Year,Starting Month,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144
N1402,68,18,MICRO       ,1990,1,2640,2640,2160,4200,3360,2400,3600,1920,4200,4560,480,3720,5640,2880,1800,3120,2400,2520,9000,2640,3120,2880,8760,5160,2160,8280,4920,3120,6600,4080,5880,1680,6720,2040,6480,1920,3600,2040,2760,3840,960,2280,1320,2160,4800,3000,3120,5880,2640,2400,2280,480,5040,1920,840,2520,1560,1440,240,1800,4680,1800,1680,3720,2160,480,2040,1440,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
$ python ../../train_test_data_splitter.py
Traceback (most recent call last):
  File "../../train_test_data_splitter.py", line 15, in <module>
    train_data = row[7 : 7 + int(number_of_columns)]
ValueError: invalid literal for int() with base 10: 'MICRO       '

@gjmulder Thanks a lot for pointing this out. For convenience, I have uploaded the datasets to a Google Drive folder. Here is the link (https://drive.google.com/drive/folders/1OthbAxru4ghG8EH681PrYLMj1bc9cktA?usp=sharing) The M4 data folder is not yet complete. I will also update the README file with this link.

@HansikaPH no rush with the M4 data, I'm just smoke testing with the M3 data for now.
Bohoma Istuti ;-)

@gjmulder wow!!! :D you are welcome!!


Switch Connection' interpreter to map to StateT InterpreterContext IO

The previous type of interpretConnProd was InterpretorContext -> Connection' r -> IO r,
but this didn't allow updates to the context to be passed to the next interpreter.
We changed the type to Connection' r -> StateT InterpreterContext IO r to allow
threading of the state ic to further calls.

Looks great, I think this really cleaned up the interpreter. Nice work!


Add tokio io test

After #3804 landed, these tests passed.

Looks good :) please squash it into a single commit.

i forgot to put the //@only-target-linux flag for mpsc test, I wonder how it even pass the CI? It fails locally when I ran ./miri run --dep tests/pass-dep/tokio/mpsc.rs --target i686-pc-windows-msvc.

Please don't r+ this first, I am not sure what's wrong with github, my local mpsc.rs has this, but github won't update it.
//@only-target-linux: support for tokio only on linux
use std::sync::mpsc::channel;

Awesome. :)
@bors r+

:pushpin: Commit d1550bdfa0264eb1c984629828d104676fb81ed3 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit d1550bdfa0264eb1c984629828d104676fb81ed3 with merge 09748434eb47140157ddbdd8553bf01775e71fb7...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 09748434eb47140157ddbdd8553bf01775e71fb7 to master...


Closes #2595 deprecation of previous "superseded" functions

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Question:  How to set it up so I can use the admiraldev branch with the new deprecation function?

@bundfussr Question: How to set it up so I can use the admiraldev branch with the new deprecation function?

For the workflows which use staged dependencies it should work with the branch naming you are using. For the snapshot workflows it will not work. We would need to update these workflows to enable it. However, I'm not sure if it is worth the effort.

@bundfussr Question: How to set it up so I can use the admiraldev branch with the new deprecation function?

For the workflows which use staged dependencies it should work with the branch naming you are using. For the snapshot workflows it will not work. We would need to update these workflows to enable it. However, I'm not sure if it is worth the effort.

awesome thanks for confirming.  wnated to make sure this was set up correctly before i started to update

@ddsjoberg i am missing some minor detail here.  if i change to warn or error it works, but with new function deprecate_inform nothing is sent out.
I installed my branch from admiraldev and can see the function available.  Any ideas?

Ha - was thinking environments was being an issue...read the documentation and added these on to the function and it worked!!  But could not explain it.  Also, not grabbing the package name.  ummm...

Was also thinking about the standard message being issued and if we wanted/could change that for deprecate_inform()??  Right now it has warning in it.

Ha - was thinking environments was being an issue...read the documentation and added these on to the function and it worked!! But could not explain it. Also, not grabbing the package name. ummm...

very good point! we should make these env args the default in deprecate_inform()

Ha - was thinking environments was being an issue...read the documentation and added these on to the function and it worked!! But could not explain it. Also, not grabbing the package name. ummm...

very good point! we should make these env args the default in deprecate_inform()

so interesting...moved arguments over to admiraldev and works now

Alright! Adventure is nearing the end. @ddsjoberg @manciniedoardo @bundfussr hoping you all can review please


New issues and pull request labelling

WHY
We need to setup some labels & structure to our issues (and pull requests). The issues are starting to pile up, so this will help organize them. We want something simple (not too cumbersome for newcomers), but structured.
Also one of the most important labels needed is in progress, combined with using the Assignees feature. This prevents a few issues, especially doing work already being worked on.
WHAT

New labels setup with only the most necessary ones we need right now
Added labels to existing open issues, testing out this setup
No milestones/projects right now, but this can be something we factor in later (mvp, v2, typescript version etc)

DISCUSSION
Any proposed changes, ideas etc comment in this issue and we can discuss modifying it. Then agree on a finalized version and close this issue.

👍 nice

Additional label added by @joncodo is feedback requested

Looks like this was accepted. Closing


Fix default_params member

Issue with python 3.5, which prevented correct loading of the initial hyperparameters.

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   99.18%   99.18%
=======================================
  Files           6        6
  Lines         370      370
=======================================
  Hits          367      367
  Misses          3        3

Impacted Files
Coverage Δ

GPflowOpt/acquisition.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33c63c...293a911. Read the comment docs.


New action for running core tests without PySpark

Fixes #250

@jdawang FYI

I did have something similar for running tests with and without spark but moving some stuff around to allow for running the fugue in #252.


pre trained model

Thank you for sharing your code. I have learned a lot from this project. I have some queries please answer them when available.
Can you share your best pre trained model，my experiment cannot achieve the accuracy mentioned in your paper。

unfortunately, the pre-trained model is not available now.


Rebuild based on Grafana 8.5.1

Codecov Report

Merging #4 (a6ff134) into main (454b388) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   88.48%   88.72%   +0.23%
==========================================
  Files          10       10
  Lines         139      133       -6
  Branches        4        3       -1
==========================================
- Hits          123      118       -5
  Misses         14       14
+ Partials        2        1       -1

Impacted Files
Coverage Δ

src/components/QueryEditor/QueryEditor.tsx
66.66% <0.00%> (-13.34%)
:arrow_down:

src/components/ConfigEditor/ConfigEditor.tsx
100.00% <0.00%> (ø)

src/datasource/datasource.ts
100.00% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454b388...a6ff134. Read the comment docs.


Add forceRender option

SlickGrid has this. https://github.com/jmeas/marionette.sliding-view/pull/17 is an attempt to do this, but the option is placed on the view itself. Is that ok? Idk – I should think about it more.

What is the benefit of a force render option? The newly public update method should handle cases when a user wants to force a render. Correct?

In SlickGrid, this appears to be an option that lets you completely turn off the delayed render. So rather than situationally forcing, it can make it so it always instantly renders.
I suppose the same functionality will be given in this library by exposing the isSmallChange method. In other words:
isSmallChange() { return true; }

Gonna close as wontfix.


Can I use this code in cp-ansible for Debian 11 version(ansible_distribution=bullseye))?

Hello,
I have used the collection confluent/platform and I see the host_validation file where I can only use the debian versions 9 and 10. Isn't it possible to use the roles for Debian 11 version?
Please recommend if this repo (https://github.com/confluentinc/cp-ansible) can be used for Debian 11 version.

Hey,
Debian 11 is not supported by Confluent yet. Refer this
And, that's why we have this validation.
If you still want to try running on Debian11, you can use
ansible-playbook .... --skip-tags 'validate_os_version'
However, we haven't tested the playbooks with debian11 and more importantly, it's not supported by CP. So, things might not work.

Hi,
Yes, I tried by skipping the  tags 'validate_os_version' and replaced 'buster' with 'bullseye'. The kafka-broker  nodes and the zookeeper nodes were running fine(services are running and the proper configurations are in-place). I have also done a basic test by sending messages after creation of topic using
kafka-console-producer --broker-list server1:9092, server2:9092, server3:9092
and  I see the messages are being consumed  via the command
kafka-console-consumer --bootstrap-server  server1:9092,server2:9092,server3:9092 --topic testing --from-beginning
According to above tests, Can I  continue with installation of confluent role on Debian 11 or should I consider any other important aspects(If I am missing something)?
Also I see the client packages provided by confluent doesn't have bullseye in Debian distributions.
(https://packages.confluent.io/clients/deb/dists/). Is it really a requirement that the client packages needs to be installed on Kafka-Cluster? I think only the clients which needs to interact with Kafka-Cluster generally need these packages. Can't these packages on clients be installed by means of any other alternative?

Is it really a requirement that the client packages needs to be installed on Kafka-Cluster? I think only the clients which needs to interact with Kafka-Cluster generally need these packages. Can't these packages on clients be installed by means of any other alternative?
With my limited understanding, shouldn't be required. For details, you can have a look at Confluent docs. Here's a little something I can find - https://docs.confluent.io/platform/current/installation/installing_cp/deb-ubuntu.html#get-the-software

According to above tests, Can I continue with installation of confluent role on Debian 11 or should I consider any other important aspects(If I am missing something)?
We (CP or CP-Ansible) don't officially support Debian11. If things look fine (and by these tests, they do), you can go ahead by all means.
Though, I'll highly suggest using a supported OS as we won't be able to help you with any problems you encounter with Debian11.

Thanks for your inputs.


Wrangler command to stop dev

💡 Feature request
Maybe this exists, however I couldn't find it. It would be nice to be able to run:
wrangler dev stop
to stop the wrangler dev server. I have just been using grep + kill which seems a little kludgy.

Sorry if I'm missing something here. wrangler dev doesn't run in the backgrouund, so you should be able to ctrl+c in the terminal you started the command to kill it. Is this not enough?

Hi Sunil,
The original terminal is not always easily accessible, that's why I find myself killing it manually. Perhaps my workflow is unusual, it just seemed a natural thing to be able to do so I was fishing for a "oh, you need to do ..." type response.
Matt

In which case the workaround using grep + kill seems very capable to me, I suppose that's what we would've recommended for this.


Exploding triangles

Sometimes one can see messed up triangles, going all over the place. You cannot move away from them, they just stay attached to the camera.
I have no idea what that is caused by, but I can see it happen in the REGothWorldViewer where many characters are added to the world. Probably one of the NPCs is broken, we should find out which one it is.

I think I know what you mean. I experienced something like this when working on the shader. Sometimes it was caused by an old cache and sometimes it was caused by semantic (?) errors in the shader. I encountered this multiple times when trying to multiply a float3 with a float. I totally don't know why that happens and what exactly causes it doesn't seem like an issue related to our meshes.

Often I can just reload the world from cache and the triangles disappear and everything is fine...

Ever experienced it since we used the new world shader?

Yes, I get it once in a while, but it seems to be only happening when Skeletal-Meshes are in the world...

Hm, strange. Maybe I don't mean the same thing. Will try to make a screen capture the next time I encounter it.

This is on the Waynet-Tester, so no skeletal meshes...

Just adding my screenshot of a world with skeletal meshes and what appears to be also some kind of exploding triangles (for documentation). However I'm not sure it is the same issue as in your image.

This is the visual bug, I was talking about earlier. It seems to be shader-related though. (However is reading this, don't be confused by the weird colors. They have nothing to do with the bug :D )

I ran this through a graphics debugger and it seems like the issue is in fact caused by skeletal meshes. Look at some of the values for the shader uniforms here:

I've seen draw-calls with the human body texture bound, but also the bloodfly-texture. Since it's the inverse world matrix that is broken I don't think this is an animation issue...

The world matrix looks broken aswell. See the 2.09...e+27 in its second row.

I've seen that, but luckily that part of the world matrix was intact for some objects. I found one of the positions of such an object to belong to some dude in the new camp. No idea which one, seems to be random.
If you take a look at the first row, the<PHONE_NUMBER>454656 as X-position also looks suspicious. The whole matrix is broken...
But there's also good news! Since I updated bsf to the latest master I have yet to see a single one of those exploding triangles! The only remaining issue is that some geometry seems to flicker...

Oh right, didn't see the broken x translation... thought it would be 9.51.... Maybe it was bsf related but time will tell.
What do you mean with flickering geometry?

Some textures disappear for one frame every once in a while. But it's not that bad.

I've never seen that. Maybe try to make a clip of it if you encounter it again.

I tried, but the lower framerate makes it looks a little bit better:

Got one more gif with more flickering:

Fixed in latest bsf-master.


Integration test agents on all supported Linux images

A regression re-triggered #1027, which impacts Ubuntu 20.04. In principle, other similar issues could happen.
Ubuntu 20.04 should really be our default (see: #1590), but for any supported Linux image, we should integration test that pools can at least start up. This should at least happen prior to releases.
AB#39956402

We already support 20.04.


Game over effect

When the monster has eaten the player, the game fades to black. Also fixes some bugs, does cleanup, and provides a method where we can put logic for when the game is over.
Edit: Tested with VR. Seems to work out properly.
Resolves #1042

iamheman


fixed animation to disappear and that corrected much of the alignment…

… issues, plus it looks cool

Thank you Amy.


chore: delete Equal Experts

Equal Experts seems to have removed all references of the Lisbon office from the site (https://www.equalexperts.com/contact-us/lisbon/), but they still seem to have Lisbon employees (https://www.linkedin.com/company/equal-experts/people/?facetGeoRegion=102775852).

Hi @goblindegook, do you have more context?

Yes, the company still has (and hires) people in Portugal, but everyone works remotely since clients are international and teams are distributed anyway.


Frecodecamp first problem

First Freecodecamp problem

Add your name and info in Contributors list in README

https://learn.freecodecamp.org/coding-interview-prep_project-euler_problem-1-multiples-of-3-and-5.js
Is this url ok?

I have proposed a change in Readme for contributors. Is it ok or do i have to change on my local machine and then push it to the repo

Yes @Avinash369 use this name 'coding-interview-prep_project-euler_problem-1-multiples-of-3-and-5.json' as the name of the file.
Also, yes you need to push the updated README.md and push it to your forked repo (Avinash369:master). It will automatically come here

changed the file name and also updated the README.md
check if anything else is needed

Thanks @Avinash369 for choosing the theme. It looks nice and now working on https://ows-ali.github.io/Hacktoberfest


Minimum VRAM?

What's the min vram for this? Thanks!

+1 Same Question, Tried to run on an A10G with 24GB VRAM and got onnxruntime.capi.onnxruntime_pybind11_state.InvalidProtobuf: [ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from ./pretrained_models/face_analysis/models/1k3d68.onnx failed:Protobuf parsing failed. Think the model too big to load?

i was able to run this with rtx 3080 10gb. You just need to lower the resolution to 448. It would take forever to generate if the default 512 is used.

I am testing on RTX4060 8 GB and it is not able to use full VRAM. The only problem is it does not show how much is remaining, just going on endlessely for 7 hours

it cost about 9G VRAM at runtime.

+1 Same Question, Tried to run on an A10G with 24GB VRAM and got onnxruntime.capi.onnxruntime_pybind11_state.InvalidProtobuf: [ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from ./pretrained_models/face_analysis/models/1k3d68.onnx failed:Protobuf parsing failed. Think the model too big to load?

That may be another problem. please open a new issue.

+1 Same Question, Tried to run on an A10G with 24GB VRAM and got onnxruntime.capi.onnxruntime_pybind11_state.InvalidProtobuf: [ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from ./pretrained_models/face_analysis/models/1k3d68.onnx failed:Protobuf parsing failed. Think the model too big to load?

Maybe the model is incomplete. Refer to #42


Make Dataframe pickle-able

To make Dataframe pickle-able, we only need to make a Buffer pickle-able.
In addition, __sizeof__ is added to the container classes to report the size of the payload.

General question: What is __sizeof__ used for?  Looking around, I don't see a precise definition of what it should count, or how accurate it needs to be.  Based on this:
https://bugs.python.org/issue15436
what you have seems fine, but I'm curious if there are other uses.

In our case, it's used for dask scheduler to determine the size of an object.  See http://distributed.readthedocs.io/en/latest/locality.html#task-submission

Oh wait, I forgot to add my tests


[WIP][Connector-V2][FlinkTableStore] Introduce flink table store connector

Purpose of this pull request
#3018

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

At the moment, only the source-related code has been organized, while the sink-related code is still in the process of being sorted.
Since the API for version 0.4 has not been released yet, we have to implement it using the API from version 0.3 for now.
PTAL @SteNicholas @JingsongLi