"Significant differences" for plot_compare_evoked

As suggested by @kingjr :

Don't know if it would be useful or over-the-top, but in my plotting functions, I typically add an optional sig parameters to highlight the significant parts of the curve.
When confronted to multiple curves I bold the curves that are sig. different from chance
fill between the two curve when the two curves are sig. from one another
e.g. example
https://cloud.githubusercontent.com/assets/4881164/16731694/74e20ca8-4747-11e6-8507-f1495430024d.png

I can imagine this being useful. If people agree, I would go about implementing it.

I'm not sure. In my opinion, we should teach people on how to make these
kind of plots, and master matplotlib, else we'll run into
specificity/support issues. But that's just a feeling
On 24 November 2017 at 11:02, jona-sassenhagen<EMAIL_ADDRESS>wrote:

As suggested by @kingjr https://github.com/kingjr :
Don't know if it would be useful or over-the-top, but in my plotting
functions, I typically add an optional sig parameters to highlight the
significant parts of the curve.
When confronted to multiple curves I bold the curves that are sig.
different from chance
fill between the two curve when the two curves are sig. from one another
e.g. example
https://cloud.githubusercontent.com/assets/4881164/16731694/74e20ca8-
4747-11e6-8507-f1495430024d.png
I can imagine this being useful. If people agree, I would go about
implementing it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4779, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEp7DDT-Um5qDUoBeJ-QGy67ifbBJrUMks5s5uiGgaJpZM4Qp_Rh
.

You're turning into Alex :|

I take this as a compliment ;)
On Friday, 24 November 2017, jona-sassenhagen<EMAIL_ADDRESS>wrote:

You're turning into Alex :|
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4779#issuecomment-346865870,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEp7DOZbOgthTrhPfYB9kMhe97jcIYgiks5s5vDvgaJpZM4Qp_Rh
.

+1 :)
fully agreed with JR

I also agree, although it could be useful to provide some simple function(s) for highlighting portions of 1d / 2d data I wouldn't build it into any existing function - rather show in a tutorial how to write such highligting code.

Could not agree more. Teach people to use matplotlib. They have the
bandwidth to actually support viz and its documentation.
On Sat 25 Nov 2017 at 20:56, Mikolaj Magnuski<EMAIL_ADDRESS>wrote:

I also agree, although it could be useful to provide some simple
function(s) for highlighting portions of 1d / 2d data I wouldn't build it
into any existing function - rather show in a tutorial how to write such
highligting code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4779#issuecomment-346962394,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0fioKVTBwTxXSo8t9wGwJLHGhR-eOYks5s6HD2gaJpZM4Qp_Rh
.

Thanks for the input!


[Feature] Add default text when search is empty

Feature

Add default text when search is empty

Screenshots

Note to reviewers
feature has been updated and tested its working perfect.
please verify the feature and let me know if there is any other modification required.
thank you

Maybe you forgot to remove console.log after testing

yes my bad !!
thanks


fix: remove overflow-hidden from div#content

Allows position="sticky" items to attach to the viewport instead of the #content element.
Fixes #3666

The failing test is the one fixed in efc87dc35b16b25210c64d703528c26669ab313d


Prompt "Are you sure?" on window close

Should help prevent accidental loss of data :(

Saaawry Simon. If you were using jbt.github.io/markdown-editor then you could just Cmd+Shift+T and get everything back because it's all wonderful and still in the url but I'm assuming you were on the S3-backed version which doesn't have autosave, right?

If you close the entire window (rather than just the tab) would Cmd+Shift+T still work?
I was on the S3 version, luckily it appears to have saved into my history - one solution might be to use pushstate and actually push the saved hash into the history rather than just using a hash.

cmd+shift+t brings back the whole window unless you were in an incognito.
For the everything-in-the-hash version I think pushState would be overkill because then you're creating a new history state for literally every keystroke. I'll add an autosave thing somewer and a onbeforeunload that shouts at you if you've made edits since the last save :)

Apparently, all the issues are getting pretty cold right now... I'm adding this one as well, with a button to copy the current URL to clipboard. Pretty small, I know, but then again, this editor is fun to work on.
To test it, check out aero31aero.github.io/markdown-editor by tomorrow. I'm working on the branch bug-fixes in case you decide to pull early on.


Always run all tests

Fixes a small annoyance that you don't know if, for example, stylelint would return any errors until eslint comes all clean. This makes it so all tests are ran, and only return failure at the end.
I had to add a small script because the only ways to make this work with normal shell commands is kinda ugly. This makes it so commands are simply separated by the + character, and in the event someone totally needs to use + in a command, \+ can be used instead to insert a literal + in the command.

Extra info:

16:32	+xPaw	what about using concurrently?
16:34	+Max-P	I thought about it, it would be doable and would speed up the tests a lot, but then the output will be broken or we'll have to buffer it and spit it all out at the end

16:35	+Max-P	|| will have the same issue as &&, and ; doesn't keep the exit code so if the first test fails but not the second then npm thinks it's all good

I found a much better way, closing this.


Search Engine

Hello, I need that feature...
Search Module
There's no search module on pagekit, I think that an important feature for this great CMS.

Hello All !
Search Module
First alpha release Comming soon
Now, i cleen up code and prepare send prject to GitHub.

First release
https://github.com/neicv/pagekit-search

Unable to activate "friendlyit/search". A fatal error occurred.

tux-86 plz say about you server (php, database, system... etc)
I not have any problem on Ubuntu Server Edition, Denwer (windows), OpenServer (windows)

PHP 5.6.23 (fpm)
MariaDB 10.1.14
nginx 1.11.2
OS Ubuntu 12.04

thx!
if you enable debug mode on site - see additional message like "Array to string conversion" ?

Yeah, I got the same error.

This bug is not Pagekit related. Please discuss it with the extension developer (https://github.com/neicv/pagekit-search).

Yes, Please discuss it in the (https://github.com/neicv/pagekit-search).

Now Search extension available in the built-in official Marketplace Pagekit.

Would be a Native Extension

+1, on a native function as erikperin suggests.
Future core code changes have a way of messing with things like plug-ins/extensions for basic and necessary site functions, and 3rd party maintainers are left scrambling to find and fix bugs. I've seen it happen with Drupal, Joomla, and others often enough and it's a real pain to deal with when universally expected functionality breaks a site.
I have 2 sites that I'm developing and am struggling with the search plugin working. Kudos to neicv on taking the initiative to fill the void, but IMHO this needs to be core code.


Sample Hyper Server

Works the hyper_server spec'd in #29

@cybergeek94 chuggin' along

You shouldn't be having problems with type mismatches unless the hyper versions for multipart and the sample project aren't exactly the same. I would check that.
I'm thinking of moving sample projects to being just single files under examples/ that can be run with cargo run --example. That's what I'm doing with multipart-async, anyway. It's much simpler and you don't have to deal with version mismatch. Wanna try that?

@cybergeek94 this is on a branch?

@puhrez I'm sorry, I don't understand. Is what on a branch? I haven't started moving sample projects to Cargo examples yet, I was just wondering if you thought it was a good idea.
The other samples have outdated versions of multipart as well. I'll need to fix that manually or move them to being examples so that I don't have to keep up on that.

I meant the analogous work you've done on multipart-async. But yeah, I think moving them to the manifest's standard is good idea.

@cybergeek94 So i migrated things over to examples, unfortunately now since they aren't standalone projects, this kinda breaks my emacs setup, but /shrug, its much easier to build and run them now.

@puhrez https://github.com/cybergeek94/multipart-async
It looks like a straight-up copy of this repo because that's how I chose to bootstrap it. The code itself is changed quite a bit, though. I'm still developing it and the Cargo.toml is still configured to use local buf_redux because I was working on additions to that crate simultaneously.
The usage becomes more clear in the examples/ directory. The server-side Hyper usage is a bit clunky because you don't get the request object until after you construct the handler, so you have to do some gymnastics with Option. I think I might develop a wrapper around Option that derefs directly to the contained value and panicks if it is None, to minimize that boilerplate since the handler methods are semi-guaranteed to be called in a consistent order..

@puhrez Looks good, only nit is in comment on examples/README.md.

@puhrez Thanks!


feat: Backlog/clean up docs

Resolves FT-de9dd14f-fbc5-4199-9ee2-db03e7c1cb51

[ ] I have added automatic tests where applicable.
[x] The PR contains a description of what has been changed.
[ ] The description contains manual test instructions.
[ ] The PR contains updates to the release notes.
[ ] I have verified that the documentation is still up to date.

Changes

removes docs sections but API reference, decided to keep them and migrate them in the future as sphinx output cannot be rendered by our new docs tooling out of the box

Test

build the docs and inspect the page

Tests are failing but that is unrelated to this pr, so we can merge this anyways.


F#: Broken // comments... because of "and"?

(Original issue 1061 created by FrankShearar on 2014-11-13T09:12:18.235069+00:00)
https://github.com/frankshearar/Fred/blob/8762ef42d4e11d43b3c2b12a9057e49f7835a5b3/Fred/Regex.fs#L11-17 shows a highlighting gone wrong. The broken lexing then breaks the rest of the file's highlighting. The start of the problem is this line:
// Pull out the *-semiring interface, and generalise the derivative to work on *-semirings.
in which the "and" word is highlighted. You can find ther examples of "and" highlighting being the possible cause of other lexing problems here:

https://github.com/frankshearar/Fred/blob/32f36288f15dd7eecb2bf7073977f60286bd5ee9/Fred/Parser.fs#L45
https://github.com/frankshearar/Fred/blob/32f36288f15dd7eecb2bf7073977f60286bd5ee9/Fred/Parser.fs#L67
https://github.com/frankshearar/Fred/blob/360c5e109eba1d5b3eade43afb89f6e3c2c63d8a/FredTest/RegexDerivingTest.fs#L57
https://github.com/frankshearar/Fred/blob/3a0640c91b7b7d661ba3a83422677d25f8d36162/Fred/RegularParser.fs#36

(Original issue 1061 last updated on 2014-11-13T14:28:54.097658+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2014-11-13T09:20:27.242520+00:00)
I can't reproduce this highlighting with the F# lexer in either Pygments 1.6 or 2.0. See http://pygments.org/demo/859724/ for how the current version highlights the same file.

(Original comment by FrankShearar on 2014-11-13T14:28:54.091956+00:00)
Fabulous! I'll chase GitHub to upgrade then. Thanks!


Cannot read property 'setVisible' of undefined

Steps to Reproduce:

Install Gitlens extension
Open SCM View and make sure Gitlens view is shown
Hide Gitlens view by right clicking and hide
Click on Explorer

Expected: No Errors and explorer should be shown
Actual: Errors are shown and explorer is empty
I've seen this constantly when I switch viewlets, since Thursday's Insiders. I can't repro when running out of sources but I think it's related to an extension treeview.

Also lots of weird glitches in the sidebar:

Stack:
t.setVisible (scmViewlet.ts:1207)
(anonymous) (compositePart.ts:301)
then (winjs.base.js:1581)
t.showComposite (compositePart.ts:247)
(anonymous) (compositePart.ts:152)
then (winjs.base.js:1581)
t.doOpenComposite (compositePart.ts:128)
t.openComposite (compositePart.ts:111)
(anonymous) (sidebarPart.ts:122)
then (winjs.base.js:1581)
t.openViewlet (sidebarPart.ts:122)
e.openViewlet (viewletService.ts:74)
t.run (viewlet.ts:135)
(anonymous) (actions.ts:114)

i'm also experiencing this issue and @roblourens suspects a relation to GitLens which I do have installed. I'm seeing the scm-viewlet in the DOM on top of the explorer-viewlet at the same time.

I'm seeing this with CTRL+B to toggle Explorer.

GitLens users are seeing this too (I can't seem to reproduce it though): https://github.com/eamodio/vscode-gitlens/issues/378
This comment seems to provide the culprit:
https://github.com/eamodio/vscode-gitlens/issues/378#issuecomment-390546686
Which lines up with this code -- somehow a panel is undefined?
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts#L1205-L1208
/cc @roblourens @joaomoreno

FYI, people are reporting it on stable as well as insiders.

Here is something weird I found for replicating the issue

enable GitLens (for me its GitLens, it may or may not be the same for you.)
switch to the Source control tab
switch back to Explorer tab
at first you will see an empty explorer, click on the explorer icon again to see all your files.
after this if you click one time on any icon from the left sidebar some weird behavior  is seen on the UI
the 'setVisible' issue will be visible in the developer tool is visible in the console.

i am on latest release for both VSC insiders and GitLens
VSC -
Version 1.24.0-insider
Commit a521c01d56ec7f07bea2471880f28a77f37983af
Date 2018-05-21T05:18:01.058Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
GitLens- 8.3.2

Thanks for the steps. I could reproduce it and update the description with steps.

Workaround is to enable gitlens view and not disable it at all.

Thanks @sandy081!


Support AWS IoT thing shadow rest API.

Describe the feature
AWS IoT thing shadow rest API.
Use Case
Most IoT use case need this thing shadow feature.
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

A note for the community

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

Hello @overheat. Because this API is unmodeled, we'd have to hand-write a crate for this. We likely won't get to this for a while, if ever. However, since it's a REST API, you can probably get pretty far constructing and sending HTTP requests manually using reqwest.

We have decided this would need to be it's own sdk like the aws-iot-device-sdk's (java-v2, js-v2, python-v2, and cpp-v2). This is not something that we currently have plans to do so I will close this issue


Add the DPDDI model

Realized that this is not relevant as it does message passing on a DDI graph and created a decoder - it has nothing to do with molecules in the traditional sense. Closing after I removed from the docs and the library in a PR.


ISSUE#4.2.1- BRIAN - README DOCUMENTATION

Weekly Build Documentation Template - Issues 2, 3, and 4
Repository: TheAlgorithms - Java

Week [Insert Week Number] - Documentation for Issues 2, 3, and 4
Objective:
Document the progress for the following issues:

Issue #4.2: Algorithm Development
Issue #4.3: Algorithm Testing
Issue #4.4: Pull Request Preparation

Issue #4.2: Algorithm Development
Week [Insert Week Number] Tasks:

[ ] Define the core components of the Hare and Tortoise Algorithm.
[ ] Implement the algorithm in Java using modular design.
[ ] Ensure that input/output specifications are correctly handled.

Progress Summary:

Algorithm Development:

The initial design of the algorithm is complete, and the basic implementation has been written.
Code is modularized to enhance readability and maintainability.

Challenges Encountered:

Edge case considerations for small or empty linked lists needed extra handling.

Key Commit:

feat: implemented core functionality of Hare and Tortoise Algorithm

Next Steps:

Focus on refining edge cases and improving the algorithm's error handling for invalid inputs.

Issue #4.3: Algorithm Testing
Week [Insert Week Number] Tasks:

[ ] Develop comprehensive test cases (typical, boundary, and edge cases).
[ ] Use JUnit for automated testing.
[ ] Debug the implementation using test-driven development.

Progress Summary:

Test Case Development:

Basic tests for detecting cycles in linked lists have been written.
Boundary cases (e.g., single-node and empty lists) are also covered.

Challenges Encountered:

Identifying rare edge cases where the algorithm might fail (e.g., linked lists with circular dependencies).

Key Commit:

test: added basic and edge case tests for cycle detection

Next Steps:

Conduct performance tests and stress tests to ensure the algorithm functions well with large datasets.

Issue #4.4: Pull Request Preparation
Week [Insert Week Number] Tasks:

[ ] Prepare the code for submission in a pull request.
[ ] Ensure the repository follows coding guidelines and best practices.
[ ] Create documentation for reviewers.

Progress Summary:

Pull Request:

The pull request draft is ready, with all changes documented and code commented for clarity.
Linked all relevant issues for proper tracking.

Challenges Encountered:

Ensuring all necessary tests pass before submission and integrating feedback from code reviews.

Key Commit:

chore: prepared pull request and linked relevant issues

Next Steps:

Finalize the pull request submission and ensure that the algorithm passes all required tests.

Commit Guidelines for This Week:
Each commit will adhere to the following format for consistency:

Commit Message Format:

feat: [description of feature]
fix: [description of bug fix]
test: [description of test]
refactor: [description of refactoring task]

Example Commit Messages for this Week:

feat: implemented cycle detection logic for linked lists
fix: handled edge cases for empty linked lists
test: added JUnit test cases for single-node edge cases

Next Steps and Upcoming Tasks:

Continue refining the algorithm based on peer feedback.
Finalize testing and documentation for the final pull request.
Conduct performance testing with larger datasets.

Version Control Summary:
This section summarizes all commits made during the week to ensure proper tracking of changes.

Date
Changes Made
Commit ID

[Insert Date]
Implemented basic algorithm functionality
[Commit ID]

[Insert Date]
Added test cases for typical and edge cases
[Commit ID]

[Insert Date]
Refactored code and prepared pull request
[Commit ID]

Documentation Guidelines and References:
For more information on how to structure the repository, make effective commit messages, and ensure security, refer to:

How to Write READMEs for Repositories
How to Write Effective Commit Messages
How to Secure Repositories

Additional information
No response

Weekly Build Documentation Template - Issues 2
Repository: TheAlgorithms - Java

Week [Insert Week Number] - Documentation for Issues 2, 3, and 4
Objective:
Document the progress for the following issues:

Issue #4.2: Algorithm Development
Issue #4.3: Algorithm Testing
Issue #4.4: Pull Request Preparation

Issue #4.2: Algorithm Development
Week [2] Tasks:

[ x ] Define the core components of the Hare and Tortoise Algorithm.
[ x ] Implement the algorithm in Java using modular design.
[ x ] Ensure that input/output specifications are correctly handled.

Progress Summary:

Algorithm Development:

The core components of the Hare and Tortoise Algorithm have been defined and implemented.
The algorithm uses a two-pointer technique (slow and fast pointers) to efficiently detect cycles in a singly linked list.
The implementation includes a helper class ListNode to represent the nodes in the linked list.
The algorithm is modularized into functions to enhance readability and maintainability, and the input/output specifications are well handled, ensuring the algorithm can detect cycles correctly.

Key Components:

ListNode Class:

Represents the structure of nodes in the singly linked list, each containing an integer value and a reference to the next node.

HareAndTortoise.hasCycle() Method:

Implements Floyd's Cycle Detection algorithm.
Uses two pointers (slow and fast), where slow moves one step at a time and fast moves two steps at a time.
If there is a cycle in the list, the slow and fast pointers will eventually meet, confirming the presence of a cycle.
If fast reaches the end of the list, there is no cycle.

Challenges Encountered:

Edge Case Considerations:

Handling small or empty linked lists required special attention:

Linked lists with only one node cannot form a cycle.
The algorithm must return false for null or single-node lists.

Ensuring that the algorithm behaves correctly even in edge cases like two-node cyclic lists where the second node points back to the first.

Key Commit:

feat: implemented core functionality of Hare and Tortoise Algorithm

Commit includes the implementation of the hasCycle() method and the ListNode structure.
Basic functionality of the algorithm has been tested to ensure correctness.

Next Steps:

Refine the algorithm to handle additional edge cases, such as:

Large linked lists with more complex cycles.
Better error handling for potential invalid inputs.

Improve the algorithm's efficiency by profiling it with large datasets and ensuring minimal overhead in memory and CPU usage.

Focus on writing additional unit tests to confirm the algorithm's robustness, especially under stress conditions and large inputs.
Key Points Filled:

Issue #4.3: Algorithm Testing
Week [Insert Week Number] Tasks:

[ ] Develop comprehensive test cases (typical, boundary, and edge cases).
[ ] Use JUnit for automated testing.
[ ] Debug the implementation using test-driven development.

Progress Summary:

Test Case Development:

Basic tests for detecting cycles in linked lists have been written.
Boundary cases (e.g., single-node and empty lists) are also covered.

Challenges Encountered:

Identifying rare edge cases where the algorithm might fail (e.g., linked lists with circular dependencies).

Key Commit:

test: added basic and edge case tests for cycle detection

Next Steps:

Conduct performance tests and stress tests to ensure the algorithm functions well with large datasets.

Issue #4.4: Pull Request Preparation
Week [Insert Week Number] Tasks:

[ ] Prepare the code for submission in a pull request.
[ ] Ensure the repository follows coding guidelines and best practices.
[ ] Create documentation for reviewers.

Progress Summary:

Pull Request:

The pull request draft is ready, with all changes documented and code commented for clarity.
Linked all relevant issues for proper tracking.

Challenges Encountered:

Ensuring all necessary tests pass before submission and integrating feedback from code reviews.

Key Commit:

chore: prepared pull request and linked relevant issues

Next Steps:

Finalize the pull request submission and ensure that the algorithm passes all required tests.

Commit Guidelines for This Week:
Each commit will adhere to the following format for consistency:
Commit Message Format:

feat: [description of feature]
fix: [description of bug fix]
test: [description of test]
refactor: [description of refactoring task]

Example Commit Messages for this Week:

feat: implemented core Hare and Tortoise cycle detection algorithm
fix: handled edge cases for empty and single-node linked lists
test: added JUnit test cases for detecting cycles in various list configurations
refactor: improved algorithm modularity and enhanced readability of the code

Next Steps and Upcoming Tasks:

Continue refining the algorithm based on peer feedback and code review comments.
Finalize testing and documentation for the final pull request submission.
Conduct performance testing with larger datasets to ensure scalability and robustness under different conditions.

Version Control Summary:
This section summarizes all commits made during the week to ensure proper tracking of changes.

Date
Changes Made
Commit ID

10/18/2024
Implemented basic algorithm functionality
[Commit ID]

10/18/2024
Added test cases for typical, boundary, and edge cases
[Commit ID]

10/18/2024
Refactored code and prepared pull request
[Commit ID]

Documentation Guidelines and References:
For more information on how to structure the repository, make effective commit messages, and ensure security, refer to:

How to Write READMEs for Repositories
How to Write Effective Commit Messages
How to Secure Repositories

Additional information
No response


Add SAND and LAND Token

SAND
Token Address: 0x3845badAde8e6dFF049820680d1F14bD3903a5d0
Token Name: The Sandbox SAND Token
Token Decimals: 18
Token Symbol: SAND
LAND
Token Address: 0x50f5474724e0Ee42D9a4e711ccFB275809Fd6d4a
Token Name: The Sandbox LAND Token
Token Decimals: 0
Token Symbol: LAND
Etherscan (SAND): https://etherscan.io/token/0x3845badade8e6dff049820680d1f14bd3903a5d0
Etherscan (LAND): https://etherscan.io/token/0x50f5474724e0ee42d9a4e711ccfb275809fd6d4a
Coingecko: https://www.coingecko.com/en/coins/the-sandbox
Coinmarketcap: https://coinmarketcap.com/currencies/the-sandbox/
Project website: https://www.sandbox.game/en/
Twitter: https://twitter.com/TheSandboxGame
Telegram: https://t.me/sandboxgame
Github: https://github.com/thesandboxgame
Medium: https://medium.com/sandbox-game

Hi,
I would double check - for 0x3845badAde8e6dFF049820680d1F14bD3903a5d0 there should be sandbox in name field as well?

@xrn Sorry for the confusion. Are you suggesting the name property I have listed for SAND, "The Sandbox SAND Token", be changed to something else?

Correct
For address - https://etherscan.io/token/0x50f5474724e0Ee42D9a4e711ccFB275809Fd6d4a - we have name interface in contract which returns Sandbox's LANDs
For address - https://etherscan.io/token/0x3845badAde8e6dFF049820680d1F14bD3903a5d0 - name interface returns SAND
I would like to double-check if name in this PR should be SAND or The Sandbox SAND Token

@xrn Made the required changes


fix: OBC StorageClass for external cluster

When deploying an external Rook-Ceph cluster, the OCS-operator does not
deploy an CephObjectStore CR, this means the StorageClass parameter
objectStoreName becomes invalid. We must remove it otherwise, the user
creation on OBC will fail.
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

/retest

/test ocs-operator-e2e-aws


Unable to stay connected to BT

Running on a Raspberry Pi 4 using a pre-compiled image.
I've tried using my phone to pair to the Pi, and tried using bluetoothctl to pair / trust to the phone.
Previously used Android Auto with this car, and this cable. Have tried multiple cables. Have also powered the pi via GPIO pins 4 and 6 to make sure it's getting proper power separate from the cars dedicated AA usb port.
2022 Volvo V60CC with Sensus infotainment
Phone says looking for Android Auto the whole time
Car displays Raspberry Pi 4 as a list of Android Auto devices
[bluetooth]# devices
Device 08:8B:C8:2F:XX:XX Pixel 9 Pro Fold
[bluetooth]# connect 08:8B:C8:2F:XX:XX
Attempting to connect to 08:8B:C8:2F:XX:XX
[CHG] Device 08:8B:C8:2F:XX:XX Connected: yes
[CHG] Device 08:8B:C8:2F:XX:XX ServicesResolved: yes
Failed to connect: org.bluez.Error.NotAvailable br-connection-profile-unavailable
[CHG] Device 08:8B:C8:2F:XX:XX ServicesResolved: no
[CHG] Device 08:8B:C8:2F:XX:XX Connected: no
[bluetooth]# info 08:8B:C8:2F:XX:XX
Device 08:8B:C8:2F:XX:XX (public)
Name: Pixel 9 Pro Fold
Alias: Pixel 9 Pro Fold
Class: 0x005a420c (5915148)
Icon: phone
Paired: yes
Bonded: yes
Trusted: yes
Blocked: no
Connected: no
LegacyPairing: no
UUID: OBEX Object Push          (00001105-0000-1000-8000-00805f9b34fb)
UUID: Audio Source              (0000110a-0000-1000-8000-00805f9b34fb)
UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb)
UUID: A/V Remote Control        (0000110e-0000-1000-8000-00805f9b34fb)
UUID: Headset AG                (00001112-0000-1000-8000-00805f9b34fb)
UUID: PANU                      (00001115-0000-1000-8000-00805f9b34fb)
UUID: NAP                       (00001116-0000-1000-8000-00805f9b34fb)
UUID: Handsfree Audio Gateway   (0000111f-0000-1000-8000-00805f9b34fb)
UUID: SIM Access                (0000112d-0000-1000-8000-00805f9b34fb)
UUID: Phonebook Access Server   (0000112f-0000-1000-8000-00805f9b34fb)
UUID: Message Access Server     (00001132-0000-1000-8000-00805f9b34fb)
UUID: PnP Information           (00001200-0000-1000-8000-00805f9b34fb)
UUID: Generic Access Profile    (00001800-0000-1000-8000-00805f9b34fb)
UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb)
UUID: Telephony and Media Audio (00001855-0000-1000-8000-00805f9b34fb)
UUID: Vendor specific           (a82efa21-ae5c-3dde-9bbc-f16da7b16c5a)
Modalias: bluetooth:v00E0p5013d0000
Error log:
Jan  1 00:14:06 buildroot user.info aawgd[273]: Found 1 bluetooth devices
Jan  1 00:14:06 buildroot user.info aawgd[273]: Trying to connect bluetooth device at path: /org/bluez/hci0/dev_08_8B_C8_2F_XX_XX
Jan  1 00:14:06 buildroot user.info aawgd[273]: Bluetooth device already connected, disconnecting
Jan  1 00:14:11 buildroot daemon.err bluetoothd[174]: src/profile.c:record_cb() Unable to get HSP HS SDP record: Host is down
Jan  1 00:14:11 buildroot user.info aawgd[273]: Failed to connect device at path: /org/bluez/hci0/dev_08_8B_C8_2F_XX_XX
Jan  1 00:14:11 buildroot user.info aawgd[273]: Failed to connect to any known bluetooth device
Jan  1 00:14:31 buildroot user.info aawgd[273]: Found 1 bluetooth devices
Jan  1 00:14:31 buildroot user.info aawgd[273]: Trying to connect bluetooth device at path: /org/bluez/hci0/dev_08_8B_C8_2F_XX_XX
Jan  1 00:14:31 buildroot user.info aawgd[273]: Bluetooth device already connected, disconnecting
Jan  1 00:14:36 buildroot daemon.err bluetoothd[174]: src/profile.c:record_cb() Unable to get HSP HS SDP record: Host is down
Jan  1 00:14:36 buildroot user.info aawgd[273]: Failed to connect device at path: /org/bluez/hci0/dev_08_8B_C8_2F_XX_XX
Jan  1 00:14:36 buildroot user.info aawgd[273]: Failed to connect to any known bluetooth device
Jan  1 00:14:56 buildroot user.info aawgd[273]: Found 1 bluetooth devices
Jan  1 00:14:56 buildroot user.info aawgd[273]: Trying to connect bluetooth device at path: /org/bluez/hci0/dev_08_8B_C8_2F_XX_XX
Jan  1 00:14:56 buildroot user.info aawgd[273]: Bluetooth device already connected, disconnecting
Jan  1 00:15:01 buildroot daemon.err bluetoothd[174]: src/profile.c:record_cb() Unable to get HSP HS SDP record: Host is down
Jan  1 00:15:01 buildroot user.info aawgd[273]: Failed to connect device at path: /org/bluez/hci0/dev_08_8B_C8_2F_XX_XX
Jan  1 00:15:01 buildroot user.info aawgd[273]: Failed to connect to any known bluetooth device

I've tried using my phone to pair to the Pi, and tried using bluetoothctl to pair / trust to the phone.

This is generally not required, any reason you're trying to manually pair and connect? With the pre-built image, you can boot up and simply connect from phone.

The attempt to manually connect was done to try and troubleshoot why it wasn't maintaining a connection when trying to just connect via the phone, to see what was happening when the phone was connecting and subsequently being disconnected.

That is normal. It connects via bluetooth to exchange wifi connection information. Once that is done, bluetooth is turned off on Pi. So disconnecting after a brief while is okay.
Once wifi information is exchanged, phone should connect via Wifi and Usb connection should start. If it is not working, issue is with wither of these steps and likely not with bluetooth connection.


Please use Discussions for questions and feature requests

Now that the new Discussions feature is publicly available, I'd like to use it to separate bugs and feature requests. Bugs should still be added to the issue tracker, while questions & feature request should now be added to GitHub Discussions.
Summary

Issues will strictly be for Bug Reports

Issues that are not bugs will be closed and redirected to Discussions

Discussions is for questions, feature requests, show and tell, TIL, and everything else

Discussions can be turned into issues if they appear to be issues

If you are unsure whether if issue or question, please choose question (and we can migrate it to issue later)
Discussion Categories
We will be using GitHub Discussions for Questions and Feature Requests (which have been considered "Issues" in the past) but there a few other categories that can used as well.

Updated Issue Templates
The "New Issue" screen has been updated to the following point_down

There is now only one issue type, Bug reports. Any issues that aren't bug reports will be closed and redirected to Discussions.
Ask a Question and Feature Request will link to Discussions!
note: if you have added a feature request as an issue in the past & it is still open, I have migrated it to the Discussions section

Just installed this and it looks great. Is there any way to move a project from personal into a team project?

Just installed this and it looks great. Is there any way to move a project from personal into a team project?


unmap with size 0x1

Hi, I have implemented a mapper, and my kernel gave me an error originating from the unmap function. I've logged the allocations and deallocations that the mapper wants to perform, and I get
allocated interval at 0x0000111111110000 size 0x1000
allocated interval at 0x0000111111111000 size 0x1000
allocated interval at 0x0000111111112000 size 0x1000
allocated interval at 0x0000111111113000 size 0x1000
allocated interval at 0x0000111111114000 size 0x1000
allocated interval at 0x0000111111115000 size 0x1000
allocated interval at 0x0000111111116000 size 0x1000
allocated interval at 0x0000111111117000 size 0x1000
allocated interval at 0x0000111111118000 size 0x1000
allocated interval at 0x0000111111119000 size 0x1000
allocated interval at 0x000011111111a000 size 0x1000
allocated interval at 0x000011111111b000 size 0x1000
allocated interval at 0x000011111111c000 size 0x1000
allocated interval at 0x000011111111d000 size 0x1000
allocated interval at 0x000011111111e000 size 0x1000
allocated interval at 0x000011111111f000 size 0x1000
allocated interval at 0x0000111111120000 size 0x1000
allocated interval at 0x0000111111121000 size 0x1000
allocated interval at 0x0000111111122000 size 0x1000
allocated interval at 0x0000111111123000 size 0x1000
unmap: 0x0000111111110000 size 0x1

My kernel does all of these allocations, but then the mapper wants to deallocate a valid pointer with an invalid size.
My mapper is the following:
impl Mapper for XhciMapper {
    unsafe fn map(&mut self, phys_start: usize, bytes: usize) -> NonZeroUsize {
        let frames = {
            let start = PhysFrame::<Size4KiB>::containing_address(PhysAddr::new(phys_start as u64));
            let end = PhysFrame::<Size4KiB>::containing_address(PhysAddr::new(phys_start as u64 + bytes as u64 - 1));
            PhysFrameRangeInclusive { start, end }
        };

        let interval = vmm().reserve(bytes).unwrap().leak();
        serial_println!("allocated interval at {:#p} size {:#x}", interval.start(), interval.size());

        for (i, frame) in frames.enumerate() {
            let vaddr = interval.start() + (i as u64 * frame.size());
            map_page!(
                Page::containing_address(vaddr),
                frame,
                Size4KiB,
                PageTableFlags::PRESENT
            );
        }

        NonZeroUsize::new(interval.start().as_u64() as usize).unwrap()
    }

    fn unmap(&mut self, virt_start: usize, bytes: usize) {
        serial_println!("unmap: {:#p} size {:#x}", VirtAddr::new(virt_start as u64), bytes);
        assert!(vmm().release(Interval::new(VirtAddr::new(virt_start as u64), bytes)));
    }
}

To me, it seems like the mapper is called incorrectly from inside the xhci crate, but I may be wrong. I'd be thankful for any help.

Thanks for the report. Do you have a public repository for this code? I'd like to check what's going on there.

https://github.com/tsatke/devos/blob/7098ccd5a70c35ec455a36362f6b590b7ace4bb0/kernel/src/main.rs#L58
You should be able to run/debug with lldb if you want to. Let me know if you need any more info.

Adding more output:
expand...

allocated interval at 0x0000111111110000 size 0x1000
mapping phys PhysFrame[4KiB](0x800000000) to virt 0x0000111111110000
done mapping, returning 0x0000111111110000
allocated interval at 0x0000111111111000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111111000
done mapping, returning 0x0000111111111000
allocated interval at 0x0000111111112000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111112000
done mapping, returning 0x0000111111112000
allocated interval at 0x0000111111113000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111113000
done mapping, returning 0x0000111111113000
allocated interval at 0x0000111111114000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111114000
done mapping, returning 0x0000111111114000
allocated interval at 0x0000111111115000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111115000
done mapping, returning 0x0000111111115000
allocated interval at 0x0000111111116000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111116000
done mapping, returning 0x0000111111116000
allocated interval at 0x0000111111117000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111117000
done mapping, returning 0x0000111111117000
allocated interval at 0x0000111111118000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111118000
done mapping, returning 0x0000111111118000
allocated interval at 0x0000111111119000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111119000
done mapping, returning 0x0000111111119000
allocated interval at 0x000011111111a000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x000011111111a000
done mapping, returning 0x000011111111a000
allocated interval at 0x000011111111b000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x000011111111b000
done mapping, returning 0x000011111111b000
allocated interval at 0x000011111111c000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x000011111111c000
done mapping, returning 0x000011111111c000
allocated interval at 0x000011111111d000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x000011111111d000
done mapping, returning 0x000011111111d000
allocated interval at 0x000011111111e000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x000011111111e000
done mapping, returning 0x000011111111e000
allocated interval at 0x000011111111f000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x000011111111f000
done mapping, returning 0x000011111111f000
allocated interval at 0x0000111111120000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111120000
done mapping, returning 0x0000111111120000
allocated interval at 0x0000111111121000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111121000
done mapping, returning 0x0000111111121000
allocated interval at 0x0000111111122000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111122000
done mapping, returning 0x0000111111122000
allocated interval at 0x0000111111123000 size 0x1000
mapping phys PhysFrame4KiB to virt 0x0000111111123000
done mapping, returning 0x0000111111123000

It looks like the mapper is being told to map the same frame repeatedly to different addresses (without unmapping before re-mapping).

Looking into it even further, this behavior doesn't surprise me anymore.

During creation, a Capabilities register is created as ReadOnly<CapabilityRegistersLength, _> - that's effectively a Generic<u8, _, _>
In drop, the Capabilities register is dropped, calling drop on the ReadOnly<u8, _>
The essence of that impl isimpl<T, M, _> Drop for Generic<T, M, _>
{
    fn drop(&mut self) {
        let bytes = mem::size_of::<T>(); // this is 1, since T is u8
        self.mapper.unmap(self.virt, bytes);
    }
}

This doesn't seem correct to me, but then I also don't know the design behind the crate, or I am missing something.

Thanks for the investigation, and sorry for the late reply and for bothering you. I believe your investigation is correct.
The current design, one accessor per register, is intentional. If we pack some registers into one accessor, writing through the packed one may result in an undesired behavior (see https://github.com/rust-osdev/xhci/pull/142 for example.), and thus the mapper implementation needs to handle this kind of per-byte memory allocation/deallocation.

I think this is reasonable given how easy it makes the underlying implementation of the xhci crate, however I think this should be well documented, and could probably also be implemented (maybe in the accessor crate?) so that the crate consumer really just has to implement mappings as the Mapper trait seems to describe it right now.

For the documentation, I agree that a little more docs are needed for the xhci crate, like "the mapper and unmapper must be able to deal with per byte mappings."

and could probably also be implemented (maybe in the accessor crate?) so that the crate consumer really just has to implement mappings as the Mapper trait seems to describe it right now.

I'm sorry, but I couldn't understand it. Could you tell me a bit more?

The accessor crate could already implement a structure such that a user doesn't have to handle single byte deallocations. Everyone would probably implement it in the same way.


certs: add helpers to unify cert format

We use this in must-gather and we should make the output consistent across all tools.
/cc @deads2k
/cc @sttts

/lgtm
/approve


Song info overlay

Overlay like this https://github.com/TheNoNinja/beat-saber-overlay
Replace total score with Score % and Rank
Replace Score % and rank with Misses amount.
To song info at the top add !bsr code

DONE


[testing-karma-bs] Setup user + key documentation incomplete

Documentation on Browserstack setup user + key is incomplete. The example listed is not written for Windows users. See recommended edit below:
#Write in Terminal or Command Line

#for one-time use only (on mac)
export BROWSER_STACK_USERNAME=xxx
export BROWSER_STACK_ACCESS_KEY=xxx

#or for one-time use only (on windows)
set BROWSER_STACK_USERNAME=xxx
set BROWSER_STACK_ACCESS_KEY=xxx

#or add them to your .bashrc
echo "export BROWSER_STACK_USERNAME=xxx" >> ~/.bashrc
echo "export BROWSER_STACK_ACCESS_KEY=xxx" >> ~/.bashrc

#to verify, run:
echo "User: $BROWSER_STACK_USERNAME"
echo "Key: $BROWSER_STACK_ACCESS_KEY"```

looks good 👍
care to create a PR 🙏

The PR was merged, thanks!


Change callbacks to the swifty way of reporting success and errors.

Change callbacks to use enums to report success/failure.
This makes it possible to add reporting the PHAsset result of storing an image to the photo library.
It might be better to put the enums in a separate file... I can do that if needed.

Wonderful. Thanks for this. This will be shipped in a few hours. Please just remove the team from the file.

Please just remove the team from the file.

My PR actually removes the team reference from the project file. Or are you referring so something else?

@jpalten thanks for the PR. Everything is 👌

Excellent! Thanks for the fast review, and glad I could contribute.

Correct me if I am wrong, but there doesn't seem to be a way to obtain the PHAsset reference. I had to add the following to make it work:
extension CaptureContent {
    public var asAsset: PHAsset? {
        switch self {
        case .image: return nil
        case .imageData: return nil
        case let .asset(asset): return asset
        }
    }
}

Yes, you can add such extension, or use this in your code:
            // use asset
            ...


Issue body maximum is 65536 characters

This Action should note that maximum size of an issue body is 65536 characters. Attempting to create an issue larger than this results in:

422 Validation Failed [{Resource:Issue Field:body Code:custom Message:body is too long (maximum is 65536 characters)}]

It probably makes sense to emit a warning and truncate issue bodies which exceed this limit.

+1
Deployment workflow shouldn't fail due to this , better to give a warning and omit the exceeded characters.

+1

+1

+1

i suggest to split the issue in multiple comments when the body size exceed the maximum issue body.

Please stop commenting "+1" (it triggers unnecessary notification for others). Upvote the first post instead.

The workflow is practically unusable for any environments of a meaningful size. The suggestion of automatic splitting into multiple comments is a good one and shouldn`t be too hard to implement.


Poor readibility due to Markdown not supported

Check how the help text is rendered below the first textarea:

How it should look like:

Attribute name/values to match. All matches must be met to add the additional attributes. Each entry should be of the form:

key operator value

Where key is the attribute name, operator is one of:

== equality match
!! not present match
=~ regular expression match
!= inequality match
!~ negative regular expression match

https://github.com/rundeck-plugins/attribute-match-node-enhancer/blob/fffc024fba47bed0d31c80dd3d9ef29061ae94e8/src/main/java/org/rundeck/plugins/nodes/attributes/AttributeNodeEnhancer.java#L29
This might help with #1

@arturmartins thanks, I think this is a rundeck issue, as markdown is supported for other types of plugins in the plugin property descriptions.  I will transfer this issue to rundeck/rundeck

Thanks, @gschueler. Should this issue be closed then?


Typings issues with version 8.0.0 -  Cannot find name 'Lowercase'

Steps to reproduce
Tell us about your environment:

Puppeteer version: 8.0.0
Platform / OS version: Mac OS Big Sur
Node.js version: 12.20.1

What steps will reproduce the problem?

Install, npm i (with the 8.0.0 version)
Build, npm run build

What is the expected result?
Project build successfully
What happens instead?
Typings issues :
node_modules/puppeteer/lib/types.d.ts:24083:36 - error TS2304: Cannot find name 'Lowercase'.

When I target the issue in thetypes.d.ts file, my IDE redirects me on a lib.es5.s.ts typings. I tried to add the "ES5" on the extra lib tsconfig options but it does not help.

Just ran into the same issue on our CI after upgrading to 8.0.0. Rolled back to 7.1.0, and don't have the issue anymore.

I confirm the 7.1.0 does not trigger the issue.

Puppeteer just release breaking changes on v.8.0.0.
https://pptr.dev/#?product=Puppeteer&version=v8.0.0&show=api-release-notes
To fix that, downgrade to v7.1.0 for now.

I have the same issue using TypeScript 4.3.0-dev.20210223. Do you think this might be a TypeScript bug more than a Puppeteer bug?

I have the same issue using TypeScript 4.3.0-dev.20210223. Do you think this might be a TypeScript bug more than a Puppeteer bug?

Using Typescript 3.9.7 as mentioned above. Same issue. At some point, it has "compiled with a version of typescript "

Anyone managed to fix that issue?

Still using the 7.1.0. But thanks for the workaround 👍

Lowercase<T> was introduced with TypeScript 4.1, so using any version newer then that should fix this problem.

I have the same issue using TypeScript 4.3.0-dev.20210223. Do you think this might be a TypeScript bug more than a Puppeteer bug?

@adam-s  Check your global tsc --version - in my case I've had an old v3.9, so running tsc from command line would fail, while yarn buld would work. Now, both work at version 4.2.3.

@SPodjasek Thanks, I'll give it a try ASAP and confirm the solution.

Confirmed updating Typescript from v3.9.x to ^4.0 resolves this issue
npm i -D<EMAIL_ADDRESS>I would suggest updating the package dependencies to suit

Updating typescript solve the problem.
Thanks @dbryar !

I confirm upgrading typescript to 4.2.4 works. Closing the issue. Thanks all.

Updated typescript to 4.4.4 - didn't fix the problem.


Investigate Travis CI for production release binaries for all platforms

https://github.com/soniah/awsenv uses https://github.com/laher/goxc
https://docs.travis-ci.com/user/osx-ci-environment/
http://stackoverflow.com/questions/31830461/build-golang-release-binaries-for-github
https://docs.travis-ci.com/user/deployment/releases

Hand built is simple enough for now.


Vim9: unpack notation can be abused to bypass type checking

Describe the bug
In Vim9 script, the unpack notation can be abused to bypass type checking.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        [x, y] = [1, 'string']
        x = {a: 0}
        echo x
        x = [2, 3]
        echo x
    enddef
    Func()
EOF
)

Vim echo'es a dictionary and a list:
{'a': 0}
[2, 3]

Expected behavior
Vim doesn't echo anything.  E1012 is raised:
E1012: Type mismatch; expected number but got dict<number>

Environment

Vim version: 8.2 Included patches: 1-2262
OS: Ubuntu 16.04.7 LTS
Terminal: xterm(363)

Additional context
Regression introduced in 8.2.2114.

This can be used to bypass type checking on an arbitrary variable.
Example:
vim9script
def Func()
    var x = 1
    x = 'string'
enddef
Func()

E1012: Type mismatch; expected number but got string

We correctly failed to change the type of x.
vim9script
def Func()
    [x, _] = [1, v:none]
    x = 'string'
enddef
Func()

This time, we incorrectly succeeded.

Patch adding a test:
diff --git a/src/testdir/test_vim9_assign.vim b/src/testdir/test_vim9_assign.vim
index 83c26a417..9cdd961b7 100644
--- a/src/testdir/test_vim9_assign.vim
+++ b/src/testdir/test_vim9_assign.vim
@@ -267,6 +267,12 @@ def Test_assign_unpack()
       [v1, v2] = ''
   END
   CheckDefFailure(lines, 'E1012: Type mismatch; expected list<any> but got string', 3)
+
+  lines =<< trim END
+      [v1, v2] = [1, 'string']
+      v1 = {a: 0}
+  END
+  CheckDefFailure(lines, 'E1012: Type mismatch; expected number but got dict<number>', 2)
 enddef

 def Test_assign_linebreak()

I guess the code was not unreachable, and needs to be re-included.  If so, maybe this patch will fix the issue:
diff --git a/src/vim9compile.c b/src/vim9compile.c
index 045061e1c..a03112f77 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -5578,6 +5578,16 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx)
 			    }
 			}
 		    }
+		    else if (name[1] == ':' && name[2] != NUL)
+		    {
+			semsg(_(e_cannot_use_namespaced_variable), name);
+			goto theend;
+		    }
+		    else if (!is_decl)
+		    {
+			semsg(_(e_unknown_variable_str), name);
+			goto theend;
+		    }
 		    else if (check_defined(var_start, varlen, cctx) == FAIL)
 			goto theend;
 		}

I guess the code was not unreachable, and needs to be re-included.  If so, maybe this patch will fix the issue:
diff --git a/src/vim9compile.c b/src/vim9compile.c
index 045061e1c..a03112f77 100644
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -5578,6 +5578,16 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx)
 			    }
 			}
 		    }
+		    else if (name[1] == ':' && name[2] != NUL)
+		    {
+			semsg(_(e_cannot_use_namespaced_variable), name);
+			goto theend;
+		    }
+		    else if (!is_decl)
+		    {
+			semsg(_(e_unknown_variable_str), name);
+			goto theend;
+		    }
 		    else if (check_defined(var_start, varlen, cctx) == FAIL)
 			goto theend;
 		}

I guess the code was not unreachable, and needs to be re-included. If so, maybe this patch will fix the issue:

Yes and no.  It does correctly reintroduce an error, but it's not the right error.
E1089: Unknown variable: x

It should be E1012.

I guess the code was not unreachable, and needs to be re-included. If so, maybe this patch will fix the issue:

Yes and no.  It does correctly reintroduce an error, but it's not the right error.
E1089: Unknown variable: x

It should be E1012.

It should be E1012.

Or:

it's the right error
it's not the right error, but E1012 is not the right one either, because [x, y] = ... should already have raised one, since neither x nor y were declared before

It should be E1012.

Or:

it's the right error
it's not the right error, but E1012 is not the right one either, because [x, y] = ... should already have raised one, since neither x nor y were declared before

Describe the bug
In Vim9 script, the unpack notation can be abused to bypass type checking.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        [x, y] = [1, 'string']
        x = {a: 0}
        echo x
        x = [2, 3]
        echo x
    enddef
    Func()
EOF
)

Vim echo'es a dictionary and a list:
{'a': 0}
[4, 5, 6]

Expected behavior
Vim doesn't echo anything.  E1012 is raised:
E1012: Type mismatch; expected number but got dict<number>

Well, the actual error is declaring a variable without "var".
This is both in a compiled function and at the script level.
It takes some more effort to get it right.
--
hundred-and-one symptoms of being an internet addict:
82. AT&T names you Customer of the Month for the third consecutive time.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Describe the bug
In Vim9 script, the unpack notation can be abused to bypass type checking.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        [x, y] = [1, 'string']
        x = {a: 0}
        echo x
        x = [2, 3]
        echo x
    enddef
    Func()
EOF
)

Vim echo'es a dictionary and a list:
{'a': 0}
[4, 5, 6]

Expected behavior
Vim doesn't echo anything.  E1012 is raised:
E1012: Type mismatch; expected number but got dict<number>

Well, the actual error is declaring a variable without "var".
This is both in a compiled function and at the script level.
It takes some more effort to get it right.
--
hundred-and-one symptoms of being an internet addict:
82. AT&T names you Customer of the Month for the third consecutive time.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Well, the actual error is declaring a variable without "var".

Yes, sorry, I'm not sure what I was thinking when I wrote that.  The real issue was that there was no declaration before the assignment.  Otherwise, there is no bug, because the rhs of the assignment has the type list<any>, therefore, anything in the lhs has the type any.  Thus, it's not unexpected to later be able to store any type of value in the variable.
Now I wonder whether we should have kept this syntax working.  It could have been used to tell Vim that we want to assign a few values to some variables, and that we don't care about their types.  We can already do it like this:
vim9script
var x: any
var y: any
var z: any
[x, y, z] = [1, 'x', true]

But with this special syntax, it would have been less verbose:
vim9script
[x, y, z] = [1, 'x', true]

Although, it would violate the rule which requires that a variable must be declared before being assigned, so maybe not a good idea if we want to stay consistent.

This is both in a compiled function and at the script level.

True, there might be another issue at the script level, but I thought the report would become too confusing with it.
This works:
vim9script
var [x, y] = [123, 'string']

It shouldn't according to :h E1092.
https://github.com/vim/vim/blob/edc10b541b468f5f5aa2e2d5ef58a3e17e043bff/runtime/doc/vim9.txt#L320-L325
Unless this restriction is limited to a :def function.  In which case the helps might need an update:
diff --git a/runtime/doc/vim9.txt b/runtime/doc/vim9.txt
index b21b7bfad..8d81c0d09 100644
--- a/runtime/doc/vim9.txt
+++ b/runtime/doc/vim9.txt
@@ -319,7 +319,7 @@ The constant only applies to the value itself, not what it refers to. >

 <							*E1092*
 Declaring more than one variable at a time, using the unpack notation, is
-currently not supported: >
+currently not supported inside a `:def` function: >
 	var [v1, v2] = GetValues()  # Error!
 That is because the type needs to be inferred from the list item type, which
 isn't that easy.

Although, it's really convenient that it works at the script level.  And it really works well; that is the variables are not inferred with the type any simply because the rhs has the type list<any>.  They are inferred with the proper types, which are enforced later on:
vim9script
var [x, y] = [123, 'string']
x = true

E1012: Type mismatch; expected number but got bool

So, ideally, this should not be fixed; the help just needs a minor update.  Later, maybe we'll be able to leverage the mechanism which allows this syntax to work at the script level and make it work in a :def function too; at which point :h E1092 might be removed.

Well, the actual error is declaring a variable without "var".

Yes, sorry, I'm not sure what I was thinking when I wrote that.  The real issue was that there was no declaration before the assignment.  Otherwise, there is no bug, because the rhs of the assignment has the type list<any>, therefore, anything in the lhs has the type any.  Thus, it's not unexpected to later be able to store any type of value in the variable.
Now I wonder whether we should have kept this syntax working.  It could have been used to tell Vim that we want to assign a few values to some variables, and that we don't care about their types.  We can already do it like this:
vim9script
var x: any
var y: any
var z: any
[x, y, z] = [1, 'x', true]

But with this special syntax, it would have been less verbose:
vim9script
[x, y, z] = [1, 'x', true]

Although, it would violate the rule which requires that a variable must be declared before being assigned, so maybe not a good idea if we want to stay consistent.

This is both in a compiled function and at the script level.

True, there might be another issue at the script level, but I thought the report would become too confusing with it.
This works:
vim9script
var [x, y] = [123, 'string']

It shouldn't according to :h E1092.
https://github.com/vim/vim/blob/edc10b541b468f5f5aa2e2d5ef58a3e17e043bff/runtime/doc/vim9.txt#L320-L325
Unless this restriction is limited to a :def function.  In which case the helps might need an update:
diff --git a/runtime/doc/vim9.txt b/runtime/doc/vim9.txt
index b21b7bfad..8d81c0d09 100644
--- a/runtime/doc/vim9.txt
+++ b/runtime/doc/vim9.txt
@@ -319,7 +319,7 @@ The constant only applies to the value itself, not what it refers to. >

 <							*E1092*
 Declaring more than one variable at a time, using the unpack notation, is
-currently not supported: >
+currently not supported inside a `:def` function: >
 	var [v1, v2] = GetValues()  # Error!
 That is because the type needs to be inferred from the list item type, which
 isn't that easy.

Although, it's really convenient that it works at the script level.  And it really works well; that is the variables are not inferred with the type any simply because the rhs has the type list<any>.  They are inferred with the proper types, which are enforced later on:
vim9script
var [x, y] = [123, 'string']
x = true

E1012: Type mismatch; expected number but got bool

So, ideally, this should not be fixed; the help just needs a minor update.  Later, maybe we'll be able to leverage the mechanism which allows this syntax to work at the script level and make it work in a :def function too; at which point :h E1092 might be removed.


Used Retry to backoff when processing tablet locator failures

Closes #3323

I don't think it buys us anything since there are infinite retries and it does not get used in the call to Retry.waitForNextAttempt.


Canceled request causes NullPointerException and perf issue.

This PR adds changes to the Indy proxy man in the middle server.
Using a shared field the request and response threads work together more effectively. Responsibility to cleanup is assigned to the request thread.
Whereas the response handler thread can be initiated when a timeout happens.  The response thread sets a field as suggested in #1521
Also set on the ServerSocket object is a timeout. Ensures that if a timeout occurs during the window then the call to .accept() will timeout. Allowing the proxy server to recover from the timeout.

You may want to rebase or redo it based on latest master? I am lost...

You may want to rebase or redo it based on latest master? I am lost...

Thanks for spotting that. I rebased the canceled-request-NPE-perf-issue-#1521 branch.


Xpand.Persistent.BaseImpl.JobScheduler classes missing after migrating from 20.2.503 to 21.1.401

𝗤𝘂𝗲𝘀𝘁𝗶𝗼𝗻
After migrating eXpand from version 20.2.503 to 21.1.401 we are missing the Xpand.Persistent.BaseImpl.JobScheduler namespace classes we have used so far in job scheduling.
I can see that the sources have been removed from version 20.2.601.0 to 20.2.602.0 in commit 4dab2370723e4412dd1503ba4001842cdc8d8345, are the classes just moved to another namespace or are they being replaced by another implementation for the jobscheduler?
Thanks in advance for your support.
𝗛𝗼𝘄 𝘄𝗲 𝗽𝗿𝗶𝗼𝗿𝗶𝘁𝗶𝘇𝗲 𝗶𝘀𝘀𝘂𝗲𝘀
We will try to answer all questions that do not require research within 24hr.
To prioritize cases that require research we use the following labels in order.

❇ Exclusive-Services
❤ Bronze Sponsor
❤ Sponsor
❤ Backer
Installation
ShowStopper
Nuget
Contribution
BreakingChange
ReproSample
Deployment
Must-Have

For all other issues the posting time is respected.

the old module is now removed as there are no tests and was build before 10+ years. The hangfire  is way better alternative


Errors on insert and update in certain situations

Hello, I am experiencing irregular errors in a Python project using Supabase and would appreciate your advice.
Summary of the problem
When using the Supabase client to update the database and insert data, the process is successful at the start, but after multiple processes, when the same code is executed, an error occurs. The content of the code has not changed, only the position at which it is executed is different.
Error Details
Expecting value: line 1 column 1 (char 0)
At the start of processing, I can update the status of the models table and insert a new record in the results table.
However, if the same update and insert code is executed after multiple operations, an error will occur.
Code Abstraction Explanation
As shown in the following code snippet, we are using the Supabase client to perform database operations.
update_response = supabase.table("models").update({"status": "finished"}).eq("model_id", model_id).execute()
insert_response = supabase.table("results").insert({"model_id": model_id, "result": ""}).execute()
Tried Solution.
Checked error messages and status codes and logged API responses in detail.
Rechecked that environment variables were set correctly.
Checked transaction management and connection status.
Question
Are there any recommended troubleshooting steps in this situation? Also, any advice on a general approach to resolving this issue?
Any small tips are welcome. Best regards.

I cannot recreate the issue from the code provided. It's best to create a reproducible github repo with the issue so we can investigate this further.

Closing this out as there has been no reply in over a month.

experiencing same issue. data getting posted to Supabase table. but it is raising exception


Feature request: Google Gemma support

Hi, are there any plans to add Google Gemma? Recently released versions works pretty well on LM Studio!

No plans currently but it can be added


Improve workshop content

New topics to cover

Up and Running

git is a command-line utility, you type the commands into the terminal
git-bash for windows users
when git will see changes for a file

Git as a Standalone User

using git rm to remove files and git mv to move files

Git as a participant

git checkout in depth
git remote in depth
git stash
common hackathon pitfalls

git rebase can prevent ugly merges when you pull files
how to fix conflicts
files larger than 100mb with git-lfs
set-up a domain with GitHub pages: project page vs profile page
setting collaborators in a repository
student pack & private repositories

GitHub's network view

GitHub as a git user

Issue Tracker
Pull requests

Presentation format ideas:
On each slide show a list of related commands and then use the basic ones live; have toggle-able gifs on the rest of them so people can see them in use without having to demo them in every case.  Add an id to every command so any viewer can have a link directly to that command.  Having groups of commands ensures the audience can easily see multiple uses for a command at the same time without having to go to a basement slide.
Place only truly supplementary material in basement slides, like content for people with lower experience levels.
Re-order everything so the demo follows clear stages with the slides, and focus on keeping the slides as supplementary material.

Focus especially on common hackathon pitfalls.

Content improvement coming with #23, brings new information on merge and rebase necessary to effectively use the commands.


Kylin 4243

KYLIN-4243 read function in NoCompressedColumnReader is wrong

Can one of the admins verify this patch?


Recall problems (Sync history)

Check that model can recall information that's in prompt history during chat session (not post reset).
Current suspicion is that chat history is not synced internally with model.
https://github.com/getnamo/Llama-Unreal/blob/6da6d73dcc8fb984438f5cf0e7774a56d07d3c52/Source/LlamaCore/Public/LlamaComponent.h#L113 to https://github.com/getnamo/Llama-Unreal/blob/6da6d73dcc8fb984438f5cf0e7774a56d07d3c52/Source/LlamaCore/Private/LlamaComponent.cpp#L127?
At https://github.com/getnamo/Llama-Unreal/blob/6da6d73dcc8fb984438f5cf0e7774a56d07d3c52/Source/LlamaCore/Private/LlamaComponent.cpp#L388 for input

Chat history is indeed synced during the session.
Only parts of the conversation which is done during the session pre-reset is maintained however. Setting the value of ModelState.PromptHistory to a template wrapped string prior to activating the component has no effect it seems, the model discards prior conversations post reset, only newly appended tokens during the active session are remembered.
If this is the expected behavior then there are no bugs.
However, the ability to save and load the conversational history would be really powerful. Currently, the way I am doing it is by storing a value of ModelState.PromptHistory to a string variable that is retained between resets. Prior to activating the component, the initial prompt (ModelParams.Prompt) is set to this value which then allows the model to load that information into session memory.
A better way of doing this would be to actually take the template wrapped history string and append the new prompt to it and send this whole string for generation but do it every prompt, causing the prompt string to get longer and longer as the session progresses. In this circumstance, it is required that the context is reset with each prompt so that the context length doesn't grow unnecessarily. Because the whole message history is being sent, the model remains coherent and can recall information from prior conversations even in between resets.
From my understanding, it's how the OpenAI API does it which has been adapted by some of the llamacpp implementations that I have used so far, take a look here -
https://github.com/oobabooga/text-generation-webui/wiki/12-‐-OpenAI-API#chat-completions
In the case of the webui, whole conversational history is sent with each API request and it generates a new context each time if I recall correctly.
The advantage of this approach is that it allows the prompt messages to be edited at runtime to guide the conversation towards a certain direction, preventing the model from hallucinating and maintaining a certain writing style by replacing choice words.
In my current solution, the conversation messages can only be modified once prior to activating the component instead of being able to modify it before sending each new prompt.
I think an ability to reset the context easily without unloading the model or resetting the static parameters would allow for a better way to retain prompt history by resetting the context before sending the prompt history string with the new prompt appended to it.

There's a performance implication with recalculating the whole prompt each time (compute bound -> generating KV cache). That said supporting history storage and reply regeneration is absolutely an API that should be supported.
This might need a naive implementation to start where if the history changes, run full recalculation, otherwise continue with current kv cache.

I think in the original API approach I was largely seeing FLLMModelState as a pure transform accessible on the game thread of the internal model state. Not sure if modifying it won't convolute the access patterns expected. In contrast FLLMModelParams are the settings you push into the model before inference. That said it might make more sense to just have FLLMModelState be a modifyable state, but it should probably be a function call e.g. ModifyModelState() or something of the like.


Implement namespacing from RFC-0002

Simply moving code around, nothing new or added, just different namespaces in accordance with #240

Closing in favor of #242
I thought opening this PR would assist with review, but I now see that was futile


Adds support for macro-aware transcoding from binary to text.

Description of changes:
Supports macro-aware transcoding from binary to text, preserving symbol tables, encoding directives, and e-expression invocations. Support for transcoding from text and to binary will be added in a future PR.
All of the API design and behavior introduced by this PR is negotiable. This is not considered a "public" API, so we have room to change it if necessary.
I deliberately did not try to build this into IonWriter.writeValues(IonReader), which could be used for system-level transcoding of Ion 1.0 streams. That works well in Ion 1.0 because symbol tables are still part of the data model, and at the system level they just look like regular structs. E-expressions are different because they occur only in the encoding, not in the data model, and as a result there are no user-exposed IonWriter APIs to preserve them. Accordingly, I've proposed a solution in this PR that hooks into the core-level reader (via the new MacroAwareIonReader interface), and can rely on encoding information to manipulate a MacroAwareIonWriter appropriately. The MacroAwareIonReader will need to be implemented by the text reader in the future to enable macro-aware transcoding from text.
The transcoding is performed using:
try (
  MacroAwareIonReader reader = ((_Private_IonReaderBuilder) IonReaderBuilder.standard()).buildMacroAware(data);
  MacroAwareIonWriter writer = (MacroAwareIonWriter) IonEncodingVersion.ION_1_1.textWriterBuilder().build(out);
) {
  reader.transcodeTo(writer);
}

And produces output like the following, when provided with the equivalent binary stream:
$ion_1_1
(:$ion::add_symbols
  (::
    "Pi"
  )
)
(:$ion::add_macros
  (
    macro
    $66
    ()
    3.14159
  )
)
$66
(:Pi)
(:$ion::set_symbols
  (::
    "Pi"
    "foo"
  )
)
(:$ion::add_macros
  (
    macro
    $2
    ()
    "bar"
  )
)
(:foo)
$1
(:$ion::set_macros
  (
    macro
    $2
    ()
    "baz"
  )
)
(:foo)
$2

When transcoded using IonWriter.writeValues(IonReader), the same input produces:
Pi
3.14159
"bar"
Pi
"baz"
foo

This can be used as a debugging tool and will be leveraged in ion-java-benchmark-cli to perform faithful re-writes of input data during write benchmarking.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

See how this is used in ion-java-benchmark-cli here: https://github.com/amazon-ion/ion-java-benchmark-cli/pull/66


chore: Break down query runner into multiple files

Describe your changes
Breaking down query runner into multiple files.
How best to test these changes
Issue ticket number and link

Codecov Report
Base: 32.42% // Head: 35.44% // Increases project coverage by +3.01% :tada:

Coverage data is based on head (2241f73) compared to base (050d47a).
Patch coverage: 43.31% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   32.42%   35.44%   +3.01%
==========================================
  Files         128      144      +16
  Lines       14367    16117    +1750
==========================================
+ Hits         4659     5713    +1054
- Misses       9277     9945     +668
- Partials      431      459      +28

Impacted Files
Coverage Δ

api/server/v1/cache.go
0.00% <0.00%> (ø)

api/server/v1/search.go
0.00% <0.00%> (ø)

api/server/v1/validator.go
0.00% <0.00%> (ø)

internal/data.go
35.80% <0.00%> (ø)

query/filter/logical.go
51.53% <0.00%> (-5.25%)
:arrow_down:

query/read/fields.go
26.31% <0.00%> (-0.57%)
:arrow_down:

schema/reserved.go
100.00% <ø> (ø)

server/metadata/errors.go
25.92% <0.00%> (+25.92%)
:arrow_up:

server/metadata/tenant_tracker.go
0.00% <0.00%> (ø)

server/middleware/auth.go
29.37% <0.00%> (-0.85%)
:arrow_down:

... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


ERROR ITMS-90596: "Invalid Bundle...."

Issue Description
I getting this error when trying to upload the build to iTunes Connect. Using "fastlane pilot upload --skip_submission true --skip_waiting_for_build_processing true" command
ERROR ITMS-90596: "Invalid Bundle. The asset catalog at 'Payload/.../Watch/.../Assets.car' can't be read. Try rebuilding the app with a non-beta version of Xcode and submit it again."
I use a non-beta version of Xcode and I can upload the very same build with the Application Loader.
Any suggestions?
Environment
'🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.11.5

Ruby
2.3.1

Bundler?
false

Git
git version 2.7.4 (Apple Git-66)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.11.5 (15F34)

Ruby Lib Dir
/usr/local/Cellar/ruby/2.3.1_2/lib

OpenSSL Version
OpenSSL 1.0.2j  26 Sep 2016

Is contained
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
7.3.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.13.0
🚫 Update available

Loaded fastlane plugins:
No plugins Loaded
Loaded gems
| Gem                       | Version      |
| ------------------------- | ------------ |
| did_you_mean              | 1.0.0        |
| slack-notifier            | 1.5.1        |
| i18n                      | 0.7.0        |
| json                      | 1.8.3        |
| thread_safe               | 0.3.5        |
| tzinfo                    | 1.2.2        |
| minitest                  | 5.8.3        |
| activesupport             | <IP_ADDRESS>      |
| CFPropertyList            | 2.3.3        |
| claide                    | 1.0.1        |
| colored                   | 1.2          |
| nanaimo                   | 0.2.2        |
| xcodeproj                 | 1.4.1        |
| rouge                     | 1.11.1       |
| xcpretty                  | 0.2.4        |
| terminal-notifier         | 1.7.1        |
| terminal-table            | 1.4.5        |
| plist                     | 3.1.0        |
| addressable               | 2.3.8        |
| multipart-post            | 2.0.0        |
| word_wrap                 | 1.0.0        |
| babosa                    | 1.0.2        |
| highline                  | 1.7.8        |
| commander                 | 4.4.0        |
| excon                     | 0.54.0       |
| faraday                   | 0.9.2        |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20161021 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 1.6.8        |
| gh_inspector              | 1.0.2        |
| uber                      | 0.0.15       |
| representable             | 2.3.0        |
| retriable                 | 2.1.0        |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| hurley                    | 0.2          |
| little-plugger            | 1.1.4        |
| multi_json                | 1.12.1       |
| logging                   | 2.1.0        |
| jwt                       | 1.5.6        |
| memoist                   | 0.15.0       |
| os                        | 0.9.6        |
| signet                    | 0.7.3        |
| googleauth                | 0.5.1        |
| httpclient                | <IP_ADDRESS>      |
| google-api-client         | 0.9.19       |
| mini_magick               | 4.5.1        |
| multi_xml                 | 0.5.5        |
| rubyzip                   | 1.1.7        |
| security                  | 0.1.3        |
| xcpretty-travis-formatter | 0.0.4        |
| dotenv                    | 2.1.1        |
| bundler                   | 1.13.6       |
| faraday_middleware        | 0.10.0       |
| io-console                | 0.4.5        |

*generated on:* **2017-02-07**
'

get same error

Oh I see that agent is using XCode 7, could that be the problem? The project was built on an agent that uses XCode 8.

how can I verify that? I make it with Xcode 7.3.1 and organizer and loader tell me that message

i am not sure if it is still supported to use 7.3.1 to submit - when using extensions like watchapp.
if you are using gym, be sure to set use_legacy_build_api to false (if using extensions you have to disable it)


[Fix] Update mmcv_maximum_version

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Update mmcv_maximum_version.
Modification
Update mmcv_maximum_version to 2.3.0.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

这是来自QQ邮箱的自动回复邮件。您的来信已收到，我将及时处理。本邮件自动回复。                                                            ——lzs

这是来自QQ邮箱的自动回复邮件。您的来信已收到，我将及时处理。本邮件自动回复。                                                            ——lzs


rust build error

FYI I get this error when building the etc-snapshot.
https://github.com/sigp/lighthouse/issues/3654
Downgrading to rust 1.64.0 seems to fix it for now!
So you might want to update your script to forcefully install rust 1.64.0 using rustup
rustup install 1.64.0
then
rustup default 1.64.0-aarch64-unknown-linux-gnu

Thank you for the notice and doing the work to figure out what specific version to use, it saved me a bit of time :-)

Of course, thanks for putting together the amazing bsc/eth snapshot repos!!


NewRelic agent is broken in 0.13

Hi,
Looks like this support depends on monkey patching ::Padrino::Routing but it is not defined
https://github.com/newrelic/rpm/blob/03ab1989954f0e9d19d81de3ac3b930ed1d4d7be/lib/new_relic/agent/instrumentation/padrino.rb#L12
I will try to fix this, but I am not sure how :(

Can you show us a Padrino application with not defined?(::Padrino) && defined?(::Padrino::Routing::InstanceMethods)?

Hi again,
Looks like something in my code makes that the first time 'defined?(::Padrino::Routing::InstanceMethods)' returns nil, I'm re-running NewRelic::Agent.manual_start on Padrino.after_load and this part is fine now.
but the real problem is that new relic is not getting the routes names, it was working perfectly on padrino 0.12.x
On my debugging I found that this code never get executed
https://github.com/newrelic/rpm/blob/14cfb6b60f900f85cfab2dc53e46562bf509e225/lib/new_relic/agent/instrumentation/sinatra/transaction_namer.rb#L14
that is why i thought it was because it wasn't monkey patching 'dispatch!' method, I created a new project to test if the name transactions works there but it doesn't, so any help is appreciated
Thanks for your time

On the constant thing: where is npm mentioned in you Gemfile? It needs to be below padrino.

Having the same issues.  Got Padrino apps in 0.11 and 0.12 working fine with New Relic reporting, but my 0.13 app is not reporting the transaction names (route names) in the New Relic dashboard.
Upgraded my 'newrelic_rpm' to the latest version as per advice from the NR support team, and also moved gem 'newrelic_rpm' to below gem 'padrino' in my Gemfile, but no change.
Is the new router within 0.13 not compatible with the NR gem?

I'm investigating that issue as well.
I've boiled it down to this: newrelic_rpm hooks into sinatra's process_route and route_eval methods to determinate the matched route. It looks like none of both is getting called when using padrino 0.13 with default mustermann router.
My current way of going further would be to additionally hook into padrino's invoke_route method.  I'm not quite sure if this is really the way to go, but at least it get's the route_obj.
(discussion in the New Relic forum: https://discuss.newrelic.com/t/missing-route-details-in-transaction-log/34989)

This seems to work for me (with a quite simple app):
https://github.com/fnordfish/rpm/commit/6fbbf2e4fdebcc3c4b6532a3212abb9dcbdcd2dc

fixed in newrelic_rpm 3.15.2


Knife 17.x is incompatible with test-kitchen 3.4+ because of an overly-restrictive net-ssh version specifier

Description
I believe this change, which is available in knife 18.x, should be backported to the 17.x series.
Right now knife 17.x specifies net-ssh < 7.x, but that version of net-ssh is not compatible with newer versions of test-kitchen (at least when using vagrant with test-kitchen). A user should be able to use chef/knife 17.x and latest test-kitchen, but currently that's not possible because of the net-ssh dep version conflict.
Chef Version
17.10.0
Platform Version
Linux
Replication Case
n/a
Client Output
n/a
Stacktrace
n/a

seems like this duplicates https://github.com/chef/chef/issues/13337
closing


--process-dependency-links is removed in pip 19.0

process_dependency_links option is used in https://github.com/poise/poise-python/blob/master/lib/poise_python/resources/python_package.rb#L73, and it's removed in pip 19.0, so using python_package is giving us an error:
STDERR: Traceback (most recent call last):
  File "<stdin>", line 33, in <module>
AttributeError: Values instance has no attribute 'process_dependency_links'

@tnguyen14 Do you have a workaround for this?

Dupe of #140


Change button to link for sidebar elements.

Fixes https://github.com/rupali-codes/LinksHub/issues/56
Changes proposed
Changes the sidebar elements to use  instead of A to correctly follow coding guidelines and remove HTML warnings.

Apologies did not realise contributing guidelines have now been added.

@JoshHargreaves thanks for quick changes, what's the difference between using  and  ?

The anchor tag generally represents a link to another page or section within a page whereas the button is more meant to represent an action resulting from a click.
The Link tag I have added here is a Next JS element that enables client-side transitions and removes the need for custom routing code at the top of the page.

Got it. Thank You


Added toFinish callback when there are x seconds to end

This looks like an awesome feature, but I'm concerned the event won't fire on mobile. How has this been tested?

The code was tested basically adding something like:
$scope.audio.toFinish(10, function() {alert('10 second to finish')});
Is tested on:
Mac with Chrome, Firefox and Safari updated.
And Chrome on Android 6.0, Android 4.3 and Android 4.4

@BreixoAM OK, this code is good. Could you also please update the docs accordingly and we'll get it merged

Sure. Update version on package.json and README file right?

@BreixoAM As well as the official docs,
http://danielstern.github.io/ngAudio/#/
Which are located in the gh-pages branch of this repo

Anyone want to finish this off by updating the docs?

Sorry for the delay, I just forget it. lol
Not sure if it is all ok now.

I'm going to go ahead and merge this and if anyone finds a problem let me know to undo


Install openssl when missing

RKE2 https://github.com/replicatedhq/kURL/pull/1069

RKE2 https://github.com/replicatedhq/kURL/pull/1069


Possible to move the completed files to a subfolder instead of the parent-root?

Been running into some trouble with a couple of files that have packed subtitles where the subtitle archive have the same name as the main movie archive. Example scenario:
Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup
└--Subs
|  └--some-movie.2160p.subs.rar
|     └--some-movie.2160p.idx
|     └--some-movie.2160p.rar <------ Shares the same name as the main movie archive below
|        └--some-movie.2160p.sub
└--Proof
└--some-movie.2160p.rar <-----------------------------------------------------------------
└--some-movie.2160p.r00
└--some-movie.2160p.r01

Looking at the log, the subtitle archive gets copied over to the main folder and that in turn overwrites the main movie archive.
2020/07/27 13:39:39.191494 handlers.go:99: Extraction Started: Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup, items in queue: 0,
2020/07/27 13:39:39.280461 start.go:85: [DEBUG] Extracting File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/Subs/some-movie.2160p-subs.rar to /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred,
2020/07/27 13:39:44.019320 start.go:85: [DEBUG] Extracting File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred/some-movie.2160p.rar to /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred,
2020/07/27 13:39:59.684392 start.go:85: [DEBUG] Extracting File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/some-movie.2160p.rar to /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred,
2020/07/27 13:40:06.394948 start.go:85: [DEBUG] Renamed Temp File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred/_unpackerred -> /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/_unpackerred,
2020/07/27 13:40:06.512903 start.go:85: [DEBUG] Renamed Temp File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred/some-movie.2160p.idx -> /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/some-movie.2160p.idx,
2020/07/27 13:40:06.675444 start.go:85: [DEBUG] Renamed Temp File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred/some-movie.2160p.rar -> /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/some-movie.2160p.rar,
2020/07/27 13:40:06.824229 start.go:85: [DEBUG] Renamed Temp File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred/some-movie.2160p.sub -> /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/some-movie.2160p.sub,

A solution to this would be to put the files in a subfolder instead of copying the files to the parent-root or have the option to exclude the subs-folder from extraction.
Renamed Temp File: /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup_unpackerred/some-movie.2160p.rar -> /downloads/Some.Movie.2020.2160p.UHD.BluRay.x265-SomeGroup/_unpackerred/some-movie.2160p.rar
Other then this very specific scenario, the software have been working flawlessly.
Thanks for putting together this awesome project, have tried so many different archive solutions and unpackerr just solves it all!
Edit: Did some checks and it seems most movies that comes with subtitles have this problem.

Interesting. I'll look into this in next few days. Thank you for the report!!

I'm pretty sure what I'm going to do here is.. not move .rar files back into the download folder. I think the people packing these movies are to blame here. Hiding a file inside another file that will overwrite your main file seems sketch to me, but it is what it is, and I'll try to work around that bug.

Sweet, much appreciated.

I'm pretty sure what I'm going to do here is.. not move .rar files back into the download folder.

That sounds good!

Hiding a file inside another file that will overwrite your main file seems sketch to me, but it is what it is, and I'll try to work around that bug.

Yeah, it could have been easily avoided by the releasegroups that does it, weird one indeed.

I took the approach of: do not overwrite any existing files when moving things back. If you're using my docker image, try the bugs tag.

I saw this new code in action with a file_id.diz file. It refused to overwrite it. I think this should be fixed now.

Sweet, havent had the time to test it, but this sounds great! Thanks for the fix.

It's only in master atm. If you use docker, pull the master tag.

Can confirm that it is working, thanks again!


adding quick sort  algorithm

Closes #4

Description:
Checklist

[ ] I've followed the Contributing guidelines provided in the repository.
[ ] I've made the changes which were demanded in the linked issue.
[ ] My code gave a clean output on debugging. (NO warnings/errors)

Thanks @shaurysrivastav27 for contributing.
You can also help by reviewing PRs.


Up-to-date RC plugin implementation

Thought you merge this by yourself :laughing:. Have you write access?


Can't create new event when edit time interval set to 1440

Just as the titles says.  We have multiple calendars on multiple pages.  The last change I made was to change the edit time interval to 1440.  After that, creating a new event freezes up.  The editor doesn't load, the page falls on its face and refuses to load.
Back out, change the setting back to 60 minutes and everything is fine again.

I mark this as an error.
Time interval tries to divide a day into timeslots. If the timeslot is specified as a day (1440 min), I think there is an edge case where it loops.

This seems to still be an issue.


NIFI-7385 - Added a secondary token cache for download and UI extensi…

…on tokens as reverse lookups. This allows us to return the same token that was already issued to a user if it has not been used or expired. This eliminates issues with users being able to generate too many tokens.
NIFI-7385 - Added some comments.
NIFI-7385 - Fixed checkstyle error.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

I opened a new PR which includes these changes here: https://github.com/apache/nifi/pull/4271 because I can't modify this one directly and I don't want to merge code that isn't in an active PR. I suggest closing this PR though.

@thenatog and I merged the fix in PR 4271. I am closing this PR.


Methylation viewing in igv-reports

Hello,
Is it possible to view methylation-tagged BAM files in igv-reports? I can view the haplotagged bam files via using the "HP" tag, but unclear if BAM CpG coloring is possible as well.
If not, I can attempt to work with a bedgraph/bigwig showing methylation frequency instead.
Thanks,
Phil

Is the BAM tagged with base modifications (MM/ML tags)?    I'm not clear on what you mean by "BAM CpG coloring".

Or perhaps you are referring to bisulfite sequencing data?

Yes they are nanopore BAMs with MM/ML tags.

Yes, you can use "colorBy > base modification..." from the track menu.   If you have more than one modification you can choose to color by all or a specific one.   You can also choose mono-color or two-color.  To emulate the bisulfite sequencing red/blue scheme choose 2 color.
But this being igv-reports,  I assume you want the coloring to come up by default.  For that you will need to use the track configuration option (--track-config) as described in the readme, as opposed to just listing the bam files.    An example is below.   See the igv.js documentation for more details.   The important property is "colorBy" and the possible values are "basemod" (for monocolor) and "basemod2" (for 2-color)
I am assuming you are using the latest version of igv-reports.
[
    {
      "type": "alignment",
      "format": "bam",
      "url":      "https://www.dropbox.com/s/q32hk7tvsejryjt/HG002_chr11_119076212_119102218_2.bam?dl=0",
      "indexURL": "https://www.dropbox.com/s/ax1ljny7ja5fdcu/HG002_chr11_119076212_119102218_2.bam.bai?dl=0",
      "height": 400,
      "name": "PacBio - 5hmC 2 Color",
      "colorBy": "basemod2"
    }
  ]

Oh no problem.   Actually igv-reports itself doesn't change often,  it is just a wrapper around igv.js.    The only change to igv-reports generally is the reference to igv.js in the template (e.g. igv_reports/templates/variant_template.html),  which looks like this.   Making this change manually to your generated reports will update them.
    <!-- igv -->
    <script<EMAIL_ADDRESS>

Question again, can I use the --track-config if I don't specify the BAM file as a URL? Could these instead be passed as relative filepaths on the system I'm using?
I'm currently using this within a nextflow pipeline and passing the BAM file as a track specifically. Currently the code chunk looks something like this:
process make_igv_report_cnv{
	publishDir params.output_dir, mode: 'copy', overwrite: true, pattern: "*html"

	input:
	val(sample_id)
	path(genome_fasta)
	path(genome_index)
	path(genome_gtf)
	path(bam)
	path(bamindex)
	path(cnv_vcf)
	path(cnv_vcf_index)
	val(output_filename)

	output:
	path("${output_filename}"), emit: html

	script:
	"""
	create_report \
		--fasta $genome_fasta \
		--output "${output_filename}" \
		--tracks $genome_gtf  cnv.vcf  $bam  \
		--flanking 5000 \
		$cnv.vcf
	"""
}

If I use the track config, I can swap the --tracks $bam for:
--track-config bam_config

where the config is
[
    {
      "type": "alignment",
      "format": "bam",
      "url":      "/path/from/nextflow/sample.bam",
      "indexURL": "/path/from/nextflow/sample.bam.bai",
      "height": 400,
      "name": "sample-id",
      "colorBy": "basemod2"
    }
  ]

And then the code chunk would be:
	script:
	"""
         <some bash code to create the config given the paths to the bam and bai and the sampleid> > bam_config.json

	create_report \
		--fasta $genome_fasta \
		--output "${output_filename}" \
		--tracks $genome_gtf  cnv.vcf  \
                --track-config bam_config.json \
		--flanking 5000 \
		$cnv.vcf
	"""

Would that work?
Thanks!
Phil

The URL can be a local file path.   In your example I see an absolute, not a relative, path (it starts with "/").
Relative paths are tricky,  what does python consider it relative to?  I don't know the answer, but you could try it, it would probably be relative to the directory the script is run from.    In any case a leading slash is not a relative path, it is going to consider that an absolute path.

An absolute filepath on the system is tracked via nextflow work directories so this should be fine. Thanks for confirming that the URL can be a local filepath!
I'll close the ticket again.
Cheers,
Phil