Height of new touch-screen-compatible CMS toolbar problematic

The new CMS toolbar is higher than the old one, which, in 'overlay' mode, makes it difficult to reach the breadcrumb links, as they are almost hidden by the toolbar. The toolbar cannot always be hidden using the little triangle button at the right.

Django 1.8.7., Django-cms 3.2.0

@Moini we recommend using djangocms-admin-style that is also referred in the installation instructions for optimal results: https://github.com/divio/djangocms-admin-style


refactor getty into getty + writer

We should separate the getty-specific code into a module and make writer generic, so that it can accept JSON directly

so just to clarify before I dive in any deeper...
the writer module accepts raw data and then calls out to a translation module (e.g. getty)?  and the getty module's job is to transform the raw data into a collection of mediachain records (Entity, Artefact, etc) and hand them back to the writer to actually send to the transactor...
Is that basically how you're thinking of this?

I think the "write" function accepts tuples of "raw" (text blob) + "mediachain metaschema" (json) metadata, which is written to transactor. Getty ideally takes a raw blob and outputs the the json as a pure function (but maybe not rn due to the author preprocessing)
So presumably writer has two entrypoints, one takes raw + translator name, one takes raw + processed.

okay cool, that sounds good

FYI, there's a collection of dataset iterators here too, if that's of any use.

@parkan do you have any thoughts about how to model relationships in the output of the translation module?  Meaning for things like creating an entity + artefact + creation cell from one raw blob...
One way would be to have the translator basically create the Entity, etc objects directly, and return them in a dictionary with temporary ids...
something like
{
  "artefact_0": {
     "type": "artefact",
      "meta": { ... }
  },
  "entity_0": {
     "type": "entity",
     "meta": { ... }
  },
  "cell_0": {
    "type": "artefactCreatedBy",
    "ref": "artefact_0",
    "entity": "entity_0",
    "meta": { ... }
}

That gets a little tricky though... since the writer would have to basically make a DAG out of that and insert the entities from the top to get valid refs to use for the dependent objects.  So in the example above, artefact_0 and entity_0 would have to be inserted before cell_0
Or we could do something like the "hub and spokes" model we had with l-space, where the artefact is considered the center, and we have a few relationship types defined.
In which case the translator would return something like
{
  "artefact": { ... },
  "related": {
    "artefactCreatedBy": {
       "type": "entity",
       "name": "fooman bar"
    }
  }
}

or something... the actual format would probably differ.

Right, this is the issue we wrestled with in L-SPACE. Let me think about it.

cool.  I started a branch here: https://github.com/mediachain/mediachain-client/tree/yn-getty-detangle
but it needs a lot of work still.  I'll aim to have a PR open tomorrow.

Thinking about it again I arrive at more or less the same conclusion. I still believe that the translator per se should be stateless and pure and emit a "best effort" representation w/o hitting any indexes.
I think having a r=2 DAG (hub and spokes) is probably a nice complexity/expressiveness tradeoff; if we really need to extract 3+ layers of relationships from a schema we can add a preprocessing step.
So we'd have like (assuming embedded/named authors):
{
  "artefact": { ... },
  "related": {
    "artefactCreatedBy": {
       "type": "entity",
       "object": { id: 1234, name: "fooman bars" }
    }
  }
}

and if the author is only specified by id, we get a stripped down version:
{
  "artefact": { ... },
  "related": {
    "artefactCreatedBy": {
       "type": "entity",
       "object": { id: 1234 } // just id
    }
  }
}

Then the next step tries to upgrade these objects in a stateful way. Basically, I want to decouple translation and lookups as much as possible so there's a simple way to express the former.
I suspect that this will be a bit easier to realize in python where we have much more arbitrarily shaped data.

(protip: using js instead of json as the quote type fixes highlighting)

yeah, I think that's a good way to go.   having the translator be a pure function makes things a lot simpler, and the writer is necessarily stateful anyway, since it has to interact with the transactor, etc. and it's whole purpose is producing side effects

I think the getty package will eventually migrate to a translator project, also

Making pretty good progress on this with #17, but it still needs a bit of cleanup and testing.  The big missing piece is artist deduplication; the original getty importer did that locally by scanning through the whole local dataset and inserting a single Entity for each unique artist name.
That strategy really only works if you're importing an entire large dataset upfront into an empty blockchain.  If there are Entities already in the system, we should be querying against those too.
The local dedup is also a bit harder to fit into this new modular design, although it could be done by having the Writer hang onto the translated output from the whole dataset and "collapsing" similar entities before sending the whole batch off to the transactor.
I can set that up for now, but I'd like to sort out the long-term strategy.  At the moment I basically see two main approaches.

for each artist parsed from the getty json, the writer calls out to an indexer (which has global knowledge of the blockchain) and asks for artists matching the parsed name.  If none exist, it inserts a new one.
the writer always inserts an Entity and doesn't try to do any deduplication.  When the whole batch is finished, it issues a request to the indexer to go through and dedup everything in one batch, and the indexer writes new cells out to "collapse" the duplicates, by linking deprecated Entities to a single "chosen one".

Both approaches have issues...
The first way involves a lot of back-and-forth between the writer and the indexer. Also it means that we need to wait for the indexer to update between each insert, because the next insert might depend on the previous one.
The second way leads to a bunch of immediately deprecated Entities in the blockchain, and we need to figure out how that deprecation / deduplication works, implement reader support, etc.  This is something we need to figure out anyway, because this problem is bound to come up again in other contexts (e.g. same person exists in two datasets and we need to combine their chains).
@parkan, @tg - any thoughts on this?

Alternative you can deterministically produce the entity (without a timestamp) and use the reference returned, either on first insert or the one returned from duplicate inserts.

yeah, that's a great point vyzo.  if we put the timestamp, etc into a cell instead of the main canonical, we could make the canonical hash deterministic but keep the timestamp

That seems like the simplest way forward; the indexer will still be needed for more sophisticated deduplication (across datasets, etc).  But for identical records from the same translator, we can just get the ref from the duplicate insert error and not clutter up the blockchain with a bunch of records that only differ in timestamp

You mean putting timestamp into an update?

I'm not sure tbh... it seems like it would need its own cell type; something that indicates that this canonical was the result of a translation step at a particular point in time.  Then if two translation passes result in an identical canonical, you'd end up with two "translatedBy" (or whatever) cells, but that seems better than two canonicals for the same raw metadata + translator.

have we decided on a path forward?

not really.  i've been side-stepping the issue in #17 by not adding a timestamp at all, which results in deterministic translation output.  Then I've just been catching the duplicate insert errors for identical Entities.
I'm not sure what to do about timestamping, tbh.  I kind of feel like having a client-generated timestamp is weird, since we have no way of controlling or verifying that their clock is set to a sane value.  It seems like timestamps in the journal Insert and Update events makes more sense, since at least there's a closed set of transactors.

I agree that timestamping should be either generated or validated by trusted system components (stale or future writes not accepted into quorum)
Let's defer on this for the moment.


Update circe-core, circe-generic, ... to 0.14.5

Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-parser
io.circe:circe-testing

from 0.14.4 to 0.14.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
Patch coverage has no change and project coverage change: -0.08 :warning:

Comparison is base (95748f0) 95.38% compared to head (b2662d8) 95.31%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   95.38%   95.31%   -0.08%
==========================================
  Files           6        5       -1
  Lines          65       64       -1
  Branches        3        3
==========================================
- Hits           62       61       -1
  Misses          3        3

Flag
Coverage Δ

2.12.17
95.31% <ø> (ø)

2.13.10
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...n/scala-2.13+/io.circe.config/compat/package.scala

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


test: Don't reuse bridge addresses straight away

Please note in the commit message for the bridge address fix that it should fix the ssh hangs.

@titanous comments addressed

LGTM


Jest/Enzyme snapshots show 'Component' instead of the native component

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: x64 Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
      Memory: 189.02 MB / 8.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 8.11.4 - /usr/local/bin/node
      Yarn: 1.10.1 - /usr/local/bin/yarn
      npm: 6.4.1 - ~/.config/yarn/global/node_modules/.bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        Build Tools: 27.0.3, 28.0.1, 28.0.3
        API Levels: 27, 28
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.1/10O23u - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.0-alpha.8af6728 => 16.6.0-alpha.8af6728
      react-native: 0.57.3 => 0.57.3

Description
In React Native 0.57, the snapshots taken by Jest and Enzyme show Component instead of the actual native component (e.g. View, Text). See diff. This is not only an issue when used with Jest, but also with Enzyme (https://github.com/airbnb/enzyme/issues/1743).
Reproducible Demo
This can be reproduced by simply upgrading react-native as shown here.
A full example is located at https://github.com/rajivshah3/rn-broken-snapshot. The master branch is the latest version of React Native with a working snapshot test, the 0.55 branch is v0.55 of React Native, and broken-example is an example of a project that is trying to upgrade from v0.55 to the latest version.

It seems like Button and Switch don't have this issue. Is it possible that https://github.com/facebook/react-native/commit/e708010d18f938e2d6b6424cfc9485d8e5dd2800 or https://github.com/facebook/react-native/commit/3e534b9aab5156adac67762877b2457408fe8934 caused this?

Yes; you’d have to explicitly set a displayName property on the forwardRef to get it to show up.

Still seeing this issue in 0.57.8. <Image> showing as <Component> in my debug. Any ideas?

Good shout @rajivshah3 - PR: https://github.com/facebook/react-native/pull/23287


nixos/security/acme: fix acme folder permissions WIP

Motivation for this change
I try to fix https://github.com/NixOS/nixpkgs/issues/25182 and implement @nh2 suggestion from the issue. Feedback is appreciated.

This indeed looks like what I had in mind.

can we get this into master to be the one cool distro which has a working  services.nginx."example.com".enableACME = true;?

@ToxicFrog can you check if this fixes the issue for you?


MSID: 96713 Version: 1 DOI: 10.1101/2<IP_ADDRESS>6260

MSID: 96713
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>6260
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=96713
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6260

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/96713v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>6260
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/96713/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

error: [indistinct-ref-labels] Duplicate labels in reference list - 21.. Have there been typesetting errors?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c9) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c66) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c83) has a publication-type='other'. Is that correct?
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'BACKGROUND'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'DATA DESCRIPTION'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'ANALYSES'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'POTENTIAL IMPLICATIONS'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'AVAILABILITY OF SOURCE CODE AND REQUIREMENTS'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'DECLARATIONS'


[reactjs] Icons have a margin offset which leads to their wrong alignment

Icons have a margin offset, that's why they wrongly aligned: https://react.semantic-ui.com/elements/icon

Hi, could you please provide a test case as per our contributing guidelines? You can fork this JSFiddle.

@Banandrew Thank you for your response, actually this problem is reproduced for all icons exactly on the page which I mentioned (you can inspect icons on the page): https://react.semantic-ui.com/elements/icon
I also have made it reproducible on JSFiddle: https://jsfiddle.net/t0w4fwm9/3/

@akscram Thank you, I asked, because I wasn’t sure in what context you used an icon. The margin exists, so that you could place some text next to an icon, and it was aesthetically correct; the menu component has got the .icon.item variation that you can use to remove the margin, and the icon component itself has got the .fitted variation that should help in other use cases. The following is a standard reply.
Thank you for posting, but although it’s a valid usage question, we’ve limited GitHub Issues to bug reports and feature requests, keeping the board more manageable for maintainers; see the contributing guidelines for more information on what kind of posts should find themselves into the GitHub Issues board.
To get answers or feedback that might allow you to repost or reopen this issue, please use one of our other support resources:

Gitter chatroom
Official forums
StackOverflow


Fix VS merge

fix #49539
https://github.com/istio/istio/blob/171a216dd6eb72d95c8c89090ee074bf3495a030/pilot/pkg/model/virtualservice.go
L206 append the normal VS-es first, L254 append the delegate VS-es. This cause the normal VS-es are always be placed before the delegate VS-es.
This PR make VS merge without changing order.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

/test all

@wulianglongrd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
5b453bbb7c1794ad3f3c7eded02cd7977416f45f
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Will take a look

In response to a cherrypick label: new pull request created: #49621

In response to a cherrypick label: new pull request created: #49622

In response to a cherrypick label: new pull request created: #49623


Connection timed out后无法重连

rtsp://11111.com:554/: Connection timed out56 bitrate= 842.3kbits/s dup=0 drop=85 speed=   1x
rtsp://11111.com:554/: Connection timed out00 bitrate= 842.2kbits/s dup=0 drop=85 speed=0.999x
rtsp://11111.com:554/: Connection timed out08 bitrate= 842.2kbits/s dup=0 drop=85 speed=0.998x
rtsp://11111.com:554/: Connection timed out16 bitrate= 842.2kbits/s dup=0 drop=85 speed=0.997x
rtsp://11111.com:554/: Connection timed out24 bitrate= 842.2kbits/s dup=0 drop=85 speed=0.995x
frame=96495 fps= 12 q=1.0 Lsize=  836102kB time=02:15:32.32 bitrate= 842.2kbits/s dup=0 drop=85 speed=0.993x
video:763489kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 9.510688%

What is the question?

do u have any solution to fix it?


SSA with binary operation with operands of type reference

Aim
The references test (tests::prove_and_verify_test_data_ssa_refactor_references):
fn main() {
    let mut x = 2;
    add1(&mut x);
    assert(x == 3);

    let mut s = S { y: x };
    s.add2();
    assert(s.y == 5);

    // Test that normal mutable variables are still copied
    let mut a = 0;
    mutate_copy(a);
    assert(a == 0);

    // Test something 3 allocations deep
    let mut nested_allocations = Nested { y: &mut &mut 0 };
    add1(*nested_allocations.y);
    assert(**nested_allocations.y == 1);

    // Test nested struct allocations with a mutable reference to an array.
    let mut c = C {
        foo: 0,
        bar: &mut C2 {
            array: &mut [1, 2],
        },
    };
    *c.bar.array = [3, 4];
    assert(*c.bar.array == [3, 4]);
}

should compile even if x is passed as parameter (reducing SSA simplifications before ACIR gen)
fn main(mut x: Field) {
    add1(&mut x);

Expected Behavior
The test should pass
Bug
The application panicked (crashed).
Message:  internal error: entered unreachable code: References are invalid in binary operations
Location: crates/noirc_evaluator/src/ssa_refactor/acir_gen/mod.rs:576

The issue seems to be in the add2 function:
struct S { y: Field }

impl S {
    fn add2(&mut self) {
        self.y += 2;
    }
}

That seems to generate SSA with a binary op with parameters of Type::Reference.
To Reproduce

Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

I was thinking this may be an issue with a dereference operation not getting inserted somewhere but the generated SSA code actually looks correct to me:
After Dead Instruction Elimination:
acir fn main f2 {
  b0(v0: Field):
    v14 = add v0, Field 2
    v15 = eq v14, Field 5
    constrain v15
    return
}

It may be that x is registered as having a reference type rather than a Field type.


[Feature Request] Add more languages to the Quick settings

It would be nice to have quick settings for Chinese and Korean language too, since Japanese, Korean, and Chinese (Simplified) are the most common languages used by raw manga/manhwa/manhua.
May be using a dropdown menu to select the language if it became too space-consuming when using large buttons.

Hello!
MORT didn't include the Tesseract OCR Chinese version because it is not built-in by default.
I will consider receiving additional downloads or checking the WIN OCR settings and proceeding with the function.


Add public method to return 'input' from Deserializer

Hi, thanks for the library! I have been trying to extend it in a way that requires using the Deserializer directly, and I've been running into trouble with the 'input' field being private without any accessors. I would love to be able to implement something equivalent to take_from_bytes() using the Deserializer itself, maybe with a .into() method that consumes the Deserializer.

Hey @scanlime, I'm not sure if I totally grok what you are proposing, but if there is a straightforward way to implement it, I'm open to a PR for this! I'm happy to discuss any details if you're unsure on the side effects.


Added new language ST

This is one of the 5 languages of IEC-61331 standard for PLC program development.  It is usually not used as individual files of code but used in examples in articles or blog posts.

What should I do to solve travis checks.

@Serhioromano, @meseta has fixed it, he must receive the approval of us.

@gusbemacbe I'm not sure what's going on. Is there anything I can do to help?

@gusbemacbe so what should I do so my addition pass the tests? I spent like 12 hours on that. I checked all other PRs that passes the test and they are the same like mine. I have no idea why it does not go through.
PS: Conflicts are resolved

You have to keep the 9.12 as @l has suggested.
And remove AUTHOR.ru.txt because it has been discarded by @isagalaev and @ldct.

Please, read the rules of @ldct: https://github.com/highlightjs/highlight.js/pull/1724#pullrequestreview-139299268
You should not commit package.json.

I think I'll just make another PR. You can decline this one. BИусфгыу  cannot understand even with your explanation how to fix this AUTHOR file now adds all strings as new.

@Serhioromano, BИусфгыу? What is it?

I understood now. You wrote "because" in Russian keyboard.

@ldct, is there this to decline this PR that he will create a new PR?

closing as requested by @gusbemacbe
@Serhioromano thanks, and looking forward to a separate PR without the merge conflicts!


MRG, FIX: Expose problems with orientations

While working on #7348 I found a problem with ambiguity resulting from our make_inverse_operator function when using free orientations. I've added tests that show the following problems (considering here only surface source spaces, not vol/discrete/mixed):

VectorSourceEstimate with a loose-orientation inverse operator seems not to "do the right thing" -- specifically, doing stc.normal() does not give the normal component.
apply_inverse(evoked, inv_free, pick_ori='normal') picks the surface normal direction for a free orientation inverse operator if and only if the forward operator passed to make_inverse_operator was in surface orientation. If fwd was not in surface orientation (i.e., was just in global RAS) then pick_ori='normal' will just return the Z direction of the inverse. This seems like a bug.

To fix these, I have the following proposals:

make_inverse_operator with a surface source space should always convert to surface orientation. Currently it will do this under all conditions (fixed/loose/free) anyway except loose=1. and fwd['surf_ori'] is False. The alternative would be to try to keep track of when there's a free ori inv not in surf ori, but looking at what we return in inv in make_inverse_operator, I don't see a way to be able to tell if surface orientation was used or not during inverse creation, so I don't think that's viable.
Ensure VectorSourceEstimate are always in XYZ/RAS, not surface orientation. I think that this is how it is meant to be used (right @wmvanvliet ?) based on how it seems to undo the assumed surface orientation rotations, but in any case it makes life simpler down the line because to get the .normal() we always just multiply by the normal direction.

Okay with you @agramfort ? If so I'll work on implementing the fixes.

Actually I'm not sure about this... I'll keep looking.

Ensure VectorSourceEstimate are always in XYZ/RAS, not surface orientation. I think that this is how it is meant to be used (right @wmvanvliet ?)

Right!

So it looks like there were indeed two bugs:

VectorSourceEstimate.normal(src) did not take into account use_cps, now it does. The default is True -- since use_cps=True has been our default for fwd computation for a while, it should be safer / a bug fix for most people even though it's a change in behavior.
pick_ori='normal' is broken for free orientation loose=1. inverses created with forward solutions not in surface orientation.

(1) was an easy fix. (2) requires changing behavior or adding a warning. For now I've added a warning just to show the extent of the changes (since it's less invasive), but I think I lean toward changing the behavior to always use surface orientation so that pick_ori='normal' and vec_stc.normal(src) work properly.
It might be possible to detect the non-surf-ori-ness when pick_ori='normal' and do the rotation on the fly (I need to check), but even if that's possible then vec_stc.normal(src) still wouldn't be fixable without additional parameters (e.g., actually passing inv instead of src).

Okay I think I mananged to fix this by detecting the lack of surface orientation, fortunately inv['source_nn'] is just a tiled np.eye(3). So this should now be hopefully a straightforward bug fix PR, ready for review/merge from my end.


CASMPET 6721

Upgrade Istio Images to 1.19.10
[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[x] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes.

Since we take changes from upstream and then add our build commits over them so the branch history is fully different than previous and so it can't be merged normally.
I had a chat with @mtupitsyn regarding this and finally we merged the changes by renaming the branch and updating the default branch.
This is how @bo-quan has also done the last time as evident from his upgrade notes which he has shared!

Since we take changes from upstream and then add our build commits over them so the branch history is fully different than previous and so it can't be merged normally.
I had a chat with @mtupitsyn regarding this and finally we merged the changes by renaming the branch and updating the default branch.
This is how @bo-quan has also done the last time as evident from his upgrade notes which he has shared!


Refs #23919 - Remove Jython and pypy workarounds

Ticket
Seeing as Django currently doesn't support Jython or PyPy we should perhaps also remove references them to from the documentation?

I think I would open a proper ticket for this issue. You didn't touch the docs in your patch. Any reason?

I thought we are still supporting Jython, PyPy. Since when did we stop?

Jython does not yet support Python 3, and master is Python 3 only. I'm not sure about PyPy.

Pypy is 3.3 or 3.2 iirc. I can update the docs as well, not sure why I left
them out.

I have very little pypy/Jython experience but I'm not sure if the removal has much benefit. I'd expect those projects to support Python 3 at some point. If this code is removed now, it's more likely that released versions of Django will be incompatible. If we leave this code in, other incompatibilities may arise in new Django code, but at least these issues may not have to be fixed again (though I realize they may not still be relevant in the Python 3 versions of Jython/pypy).

@timgraham  Agreed.

I would be more enclined to let the PyPy part, which has already Python 3 support than Jython. If we cleanly remove Jython support, the patch can be used later to reintroduced that support. Jython on Python 3 is announced for many years now, but has seen few progress.

Good point. Shall I change this MR to remove the documentation instead?

Please let's discuss that on a ticket instead.

https://github.com/jython/jython3 has some activity as of July but as there's no activity at http://www.jython.org/ and https://github.com/beachmachine/django-jython since 2015, removing the documentation might be fine. I'd create a ticket and put "2.0" in the keywords field. If there's no change in Jython's Python 3 status before the Django 2.0 release, I'll remove docs/howto/jython.txt or at least add a note that this is only supported in older Django releases that support Python 2.


Feat(frontend): add icons in offers

Resolves #605
What does this PR do?
A sponsor can choose among different icons to add to their offers
How should this be tested?

Make run
Login as Sponsor
Add offer in Offers Management
Check offers list

still getting the non icon for an offer that already existed in the database

There is already a default

Still getting the error if I dont set up the permissions, you should merge the changes too and check the conflicts.

Still getting the error if I dont set up the permissions, you should merge the changes with the master too and check the conflicts.

Thanks!


[docs] Update the getting-started documentation, includes the compose…

…r setup.
Summary
Update the getting-started documentation, includes the compose setup and clearer instruction.
Relevant Technical Choices
N/A
To-do
N/A
User-facing changes
N/A
Testing Instructions
N/A

Fixes #

In the future, please create branches in the existing naming convention e.g. feature/name-of-feature or fix/bug-number.


Add hold option for timepicker mode

When time-picker mode enabled - it is an option to choose time from additional menu by clicking on time number
I think it will be also nice to have an option just hold mouse on arrow for updating time

@Jasenkoo any updates? I see that issue is closed but as i get - it is not realized yet

@0SilentFox0 It is added, you need to enable it via  config.timeArrowHoldThreshold


Need performance test for exponential time complexity.

Our problem has a time complexity of exponential. And we need performance test for this.

Which problem?

@williamgong2015 ping? Please clarify the issue thread.

Superseded by #255. (This looks like the "strobogrammatic numbers" problem.)


Add the option to render partial videos in the command line?

Currently, rendering partial videos (as in videos with a specified start and end time) is not allowed though the command line. I understand why this may be the case, as before the warning dialog in the GUI was put in place, I used to mistakenly render partial videos all the time. However, I think it would at least be useful to add an option to override this check in the command line, as in some cases, trimming excess silence from the start and/or end of a project is much more convenient when done from corrscope, as opposed to editing software.

I'm aware you can currently do this with the "trim" and "atrim" ffmpeg filters. This may be adequate, but I'm leaving the suggestion out there.

partial video rendering is currently implemented by setting begin/end times in the yaml file, so you want to set it temporarily over the cli rather than by editing the file?

I'm fine with setting start and end time in the GUI. But least for me, trying to render a project in the command line with start and end times set doesn't work.

Works on my machine? IDK.

Ah, it works now, I wasn't setting up the command properly.


Question: How to generate a table with cell word wrap?

Hi, I'm trying to create a table where each cell can be word wrap. How can I do that? I tried using MultiCell but it goes to the next line for each cell and CellFormat does not seem to support MultiCell.
Something like this.

Name
Description

John
John has a cat.John has a dog.

Jane
Jane has a cat.

This can be done with SplitLines(). The limitation is that only one font and attribute are supported.
For each row, you will need to loop through each column twice. The first time, call SplitLines() to calculate each cell's height. The second time, use the maximum cell height from the previous loop as the
row height. Apply padding as needed to vertically center the text of cells that have a height less than the row height.

I've tried your suggestion and manage to get the max height but i couldn't word wrap using CellFormat like MultiCell

The example accompanying the documentation for SplitLines() shows how each of the substrings (of type []byte) returned by SplitLines() has to be passed to CellFormat() individually. It's really SplitLines() that determines where the wrap breaks are; after that the substrings are manually rendered.
I'll try to find some time tomorrow to augment the table example to demonstrate this.

Cool thanks

Demonstrated in 4491d0fe5997270270f8e4023786afd99251f604

Awesome. I'll have a go on your example. Thanks

Your example works. Thanks

Hi @jung-kurt, thank you for this awesome lib!
I think it would be awesome if the lib had that abstracted in a function or struct. It's a pretty common use case.
Thanks again! 😃

Thanks, @andreynering. I agree, an abstraction of word-wrapped table cells make sense. If it is done at the table level, then it could facilitate alternate row shading and page breaks with header rows. I'll reflect on various approaches and put something together in the days ahead.

I tried the approach it works fine with only one page. If the table is longer than one page and auto break is enabled the layout gets messed up. I'm working on a solution.

Thanks, @jacobfederer -- I look forward to seeing what you come up with.

hi i want to ask how i can text wrap a value from html input? TIA

hi @jung-kurt
Can merge the cell's in the table? How would you do?

Can merge the cell's in the table? How would you do?

Tables in gofpdf are built up of individual cells. You can merge them manually with something like this:
package main

import (
  "fmt"

  "github.com/jung-kurt/gofpdf/v2"
)

func main() {
  const (
    colCount = 4
    rowCount = 3
    margin   = 32.0
    fontHt   = 14.0 // point
  )
  pdf := gofpdf.New("L", "mm", "A4", "")
  cellWd := (297 - margin - margin) / colCount
  cellHt := pdf.PointToUnitConvert(fontHt) + 10.0
  pdf.SetFont("Arial", "", fontHt)
  pdf.AddPage()
  pdf.SetXY(margin, margin)
  for rowJ := 0; rowJ < rowCount; rowJ++ {
    for colJ := 0; colJ < colCount; colJ++ {
      pdf.SetXY(margin+float64(colJ)*cellWd, margin+float64(rowJ)*cellHt)
      if rowJ == 1 && (colJ == 1 || colJ == 2) {
        if colJ == 1 { // Merged cells
          pdf.CellFormat(cellWd*2.0, cellHt, fmt.Sprintf("Merged cells"), "1", 0, "CM", false, 0, "")
        }
      } else {
        pdf.CellFormat(cellWd, cellHt, fmt.Sprintf("Row %d, Col %d", rowJ, colJ), "1", 0, "CM", false, 0, "")
      }
    }
  }
  err := pdf.OutputFileAndClose("colmerge.pdf")
  if err != nil {
    fmt.Printf("%s\n", err)
  }
}

very very Thankful
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
27/03/19,
7:06:46 pm
On Sat, Mar 23, 2019 at 7:45 PM Kurt Jung<EMAIL_ADDRESS>wrote:

Can merge the cell's in the table? How would you do?
Tables in gofpdf are built up of individual cells. You can merge them
manually with something like this:
package main
import (
"fmt"
"github.com/jung-kurt/gofpdf/v2"
)
func main() {
const (
colCount = 4
rowCount = 3
margin   = 32.0
fontHt   = 14.0 // point
)
pdf := gofpdf.New("L", "mm", "A4", "")
cellWd := (297 - margin - margin) / colCount
cellHt := pdf.PointToUnitConvert(fontHt) + 10.0
pdf.SetFont("Arial", "", fontHt)
pdf.AddPage()
pdf.SetXY(margin, margin)
for rowJ := 0; rowJ < rowCount; rowJ++ {
for colJ := 0; colJ < colCount; colJ++ {
pdf.SetXY(margin+float64(colJ)*cellWd, margin+float64(rowJ)cellHt)
if rowJ == 1 && (colJ == 1 || colJ == 2) {
if colJ == 1 { // Merged cells
pdf.CellFormat(cellWd2.0, cellHt, fmt.Sprintf("Merged cells"), "1", 0, "CM", false, 0, "")
}
} else {
pdf.CellFormat(cellWd, cellHt, fmt.Sprintf("Row %d, Col %d", rowJ, colJ), "1", 0, "CM", false, 0, "")
}
}
}
err := pdf.OutputFileAndClose("colmerge.pdf")
if err != nil {
fmt.Printf("%s\n", err)
}
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jung-kurt/gofpdf/issues/129#issuecomment-475873331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad0bauryaJCz2ZehXL_Z4xYxAGEqGa_3ks5vZjcHgaJpZM4O_c_v
.

But here we can't be merge corner cell.
Like:-
Merged cell
Name:
Class:
Sub Mark1 Mark2 Mark3
SUB1 1 2 3
SUB2 4 5 6
SUB3 7 8 9
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
27/03/19,
7:25:34 pm
On Wed, Mar 27, 2019 at 7:07 PM Dinesh kumar S<EMAIL_ADDRESS>wrote:

very very Thankful
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& 27/03/19,
7:06:46 pm
On Sat, Mar 23, 2019 at 7:45 PM Kurt Jung<EMAIL_ADDRESS>wrote:

Can merge the cell's in the table? How would you do?
Tables in gofpdf are built up of individual cells. You can merge them
manually with something like this:
package main
import (
"fmt"
"github.com/jung-kurt/gofpdf/v2"
)
func main() {
const (
colCount = 4
rowCount = 3
margin   = 32.0
fontHt   = 14.0 // point
)
pdf := gofpdf.New("L", "mm", "A4", "")
cellWd := (297 - margin - margin) / colCount
cellHt := pdf.PointToUnitConvert(fontHt) + 10.0
pdf.SetFont("Arial", "", fontHt)
pdf.AddPage()
pdf.SetXY(margin, margin)
for rowJ := 0; rowJ < rowCount; rowJ++ {
for colJ := 0; colJ < colCount; colJ++ {
pdf.SetXY(margin+float64(colJ)*cellWd, margin+float64(rowJ)cellHt)
if rowJ == 1 && (colJ == 1 || colJ == 2) {
if colJ == 1 { // Merged cells
pdf.CellFormat(cellWd2.0, cellHt, fmt.Sprintf("Merged cells"), "1", 0, "CM", false, 0, "")
}
} else {
pdf.CellFormat(cellWd, cellHt, fmt.Sprintf("Row %d, Col %d", rowJ, colJ), "1", 0, "CM", false, 0, "")
}
}
}
err := pdf.OutputFileAndClose("colmerge.pdf")
if err != nil {
fmt.Printf("%s\n", err)
}
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jung-kurt/gofpdf/issues/129#issuecomment-475873331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad0bauryaJCz2ZehXL_Z4xYxAGEqGa_3ks5vZjcHgaJpZM4O_c_v
.

Hi,
Thank you... I got it!.... by the way
package main
import (
"fmt"
"github.com/jung-kurt/gofpdf"

)
func main() {
const (
colCount = 4
rowCount = 3
margin = 32.0
fontHt = 14.0 // point
)
pdf := gofpdf.New("L", "mm", "A4", "")
cellWd := (297 - margin - margin) / colCount
cellHt := pdf.PointToUnitConvert(fontHt) + 10.0
pdf.SetFont("Arial", "", fontHt)
pdf.AddPage()
pdf.SetXY(margin, margin)
for rowJ := 0; rowJ < rowCount; rowJ++ {
for colJ := 0; colJ < colCount; colJ++ {
pdf.SetXY(margin+float64(colJ)cellWd, margin+float64
(rowJ)cellHt)
if (rowJ == 0 || rowJ == 1) && (colJ == 0 || colJ == 1) {
if rowJ == 0 && colJ == 0 {
pdf.CellFormat(cellWd2.0, cellHt2.0, fmt.Sprintf("Merged
cells"), "1", 0, "CM", false, 0, "")
}
} else if (rowJ == 0 || rowJ == 1) && (colJ == 2 || colJ == 3) {
if (rowJ == 0 || rowJ == 1) && colJ == 2 {
pdf.CellFormat(cellWd*2.0, cellHt, fmt.Sprintf("Merged
cells"), "1", 0, "CM", false, 0, "")
}
} else {
pdf.CellFormat(cellWd, cellHt, fmt.Sprintf("Row %d, Col %d",
rowJ, colJ), "1", 0, "CM", false, 0, "")
}
}
}
err := pdf.OutputFileAndClose("colmerge.pdf")
if err != nil {
fmt.Printf("%s\n", err)
}
}
Result:-
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
27/03/19,
8:10:59 pm
On Wed, Mar 27, 2019 at 7:26 PM Dinesh kumar S<EMAIL_ADDRESS>wrote:

But here we can't be merge corner cell.
Like:-
Merged cell
Name:
Class:
Sub Mark1 Mark2 Mark3
SUB1 1 2 3
SUB2 4 5 6
SUB3 7 8 9
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& 27/03/19,
7:25:34 pm
On Wed, Mar 27, 2019 at 7:07 PM Dinesh kumar S<EMAIL_ADDRESS>wrote:

very very Thankful
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5& 27/03/19,
7:06:46 pm
On Sat, Mar 23, 2019 at 7:45 PM Kurt Jung<EMAIL_ADDRESS>wrote:

Can merge the cell's in the table? How would you do?
Tables in gofpdf are built up of individual cells. You can merge them
manually with something like this:
package main
import (
"fmt"
"github.com/jung-kurt/gofpdf/v2"
)
func main() {
const (
colCount = 4
rowCount = 3
margin   = 32.0
fontHt   = 14.0 // point
)
pdf := gofpdf.New("L", "mm", "A4", "")
cellWd := (297 - margin - margin) / colCount
cellHt := pdf.PointToUnitConvert(fontHt) + 10.0
pdf.SetFont("Arial", "", fontHt)
pdf.AddPage()
pdf.SetXY(margin, margin)
for rowJ := 0; rowJ < rowCount; rowJ++ {
for colJ := 0; colJ < colCount; colJ++ {
pdf.SetXY(margin+float64(colJ)*cellWd, margin+float64(rowJ)cellHt)
if rowJ == 1 && (colJ == 1 || colJ == 2) {
if colJ == 1 { // Merged cells
pdf.CellFormat(cellWd2.0, cellHt, fmt.Sprintf("Merged cells"), "1", 0, "CM", false, 0, "")
}
} else {
pdf.CellFormat(cellWd, cellHt, fmt.Sprintf("Row %d, Col %d", rowJ, colJ), "1", 0, "CM", false, 0, "")
}
}
}
err := pdf.OutputFileAndClose("colmerge.pdf")
if err != nil {
fmt.Printf("%s\n", err)
}
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jung-kurt/gofpdf/issues/129#issuecomment-475873331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad0bauryaJCz2ZehXL_Z4xYxAGEqGa_3ks5vZjcHgaJpZM4O_c_v
.

hi @jung-kurt
One more question..!
If the table exists the 1-page alignment is missed... This is a bug or else need to configure anything?
like:

Sorry to bump this issue, but I ran into this too! The above was a complete dealbreaker, so I actually solved it a rather different way - by creating a writeRow() function. Do you think, if I flesh it out and fix it a little, this might be merged into the library?
type rowContents struct {
	Contents            string
	ColumnWidthFraction float64
}
...
    usablePageWidth = pageWidth - 2*margin
...

func writeRow(pdf *gofpdf.Fpdf, lineHeight int, contents ...rowContents) {
	var maxHeight float64

	for _, cellContent := range contents {
		textSpaceInColumn := cellContent.ColumnWidthFraction * (usablePageWidth)

		splitStrings := pdf.SplitText(cellContent.Contents,
			textSpaceInColumn) // -2 for table divs
		if newHeight := float64(len(splitStrings)) * float64(lineHeight); newHeight > maxHeight {
			maxHeight = newHeight
		}
	}
	fmt.Println("Maxheight:", maxHeight)

	for i, cellContent := range contents {
		if len(contents)-1 != i { // not last cell
			pdf.CellFormat(cellContent.ColumnWidthFraction*usablePageWidth, maxHeight,
				cellContent.Contents, "1", 0, "L", false, 0, "")
		} else {
			pdf.MultiCell(cellContent.ColumnWidthFraction*usablePageWidth, float64(lineHeight),
				cellContent.Contents, "1", "L", false)
		}
	}
}

Do you think, if I flesh it out and fix it a little, this might be merged into the library?

Definitely! Thanks, @sk0g.


[Put it back again]: Revert "Revert "generate-bundles.py renamed to bundles-to-charts.py (#22)""

Reverts stolostron/installer-dev-tools#23 (which was itself a revert)

/lgtm


JobStoreSupport.triggersFired not using txValidator compensation logic

I've been digging into a .NET version's problem when database encounters a transient error, like a connectivity problem and thus should be retried. If you look at the code:
https://github.com/quartz-scheduler/quartz/blob/d42fb7770f287afbf91f6629d90e7698761ad7d8/quartz-core/src/main/java/org/quartz/impl/jdbcjobstore/JobStoreSupport.java#L2976-L3020
All exceptions are caught in main txCallback and thus I don't see a way how the txValidator logic would ever be called. This will mean that this operation is not retried, unlike the acquireNextTriggers which allows exceptions to bubble up:
https://github.com/quartz-scheduler/quartz/blob/d42fb7770f287afbf91f6629d90e7698761ad7d8/quartz-core/src/main/java/org/quartz/impl/jdbcjobstore/JobStoreSupport.java#L2802-L2826
So before changing the behavior on .NET side I was hoping to get some feedback from Java side. Should the errors be allowed to bubble up or is the txValidator just redundant?

This is relevant and I would like to discuss whether it requires a fix.

This is relevant and I would like to discuss whether it requires a fix.

I'm seeing connection pool leaks through this stack.  Wonder if it's related?
2021-09-27 05:08:39.015 [admin_json.adminJsonEndpointJetty-1284] DEBUG R:7uJpuSm0o0kFtccm c.c.l.connection_pool_troubleshooting - 	at org.springframework.scheduling.quartz.LocalDataSourceJobStore$2.getConnection(LocalDataSourceJobStore.java:136)
2021-09-27 05:08:39.015 [admin_json.adminJsonEndpointJetty-1284] DEBUG R:7uJpuSm0o0kFtccm c.c.l.connection_pool_troubleshooting - 	at org.quartz.utils.DBConnectionManager.getConnection(DBConnectionManager.java:108)
2021-09-27 05:08:39.015 [admin_json.adminJsonEndpointJetty-1284] DEBUG R:7uJpuSm0o0kFtccm c.c.l.connection_pool_troubleshooting - 	at org.quartz.impl.jdbcjobstore.JobStoreCMT.getNonManagedTXConnection(JobStoreCMT.java:165)
2021-09-27 05:08:39.015 [admin_json.adminJsonEndpointJetty-1284] DEBUG R:7uJpuSm0o0kFtccm c.c.l.connection_pool_troubleshooting - 	at org.quartz.impl.jdbcjobstore.JobStoreSupport.executeInNonManagedTXLock(JobStoreSupport.java:3854)
2021-09-27 05:08:39.015 [admin_json.adminJsonEndpointJetty-1284] DEBUG R:7uJpuSm0o0kFtccm c.c.l.connection_pool_troubleshooting - 	at org.quartz.impl.jdbcjobstore.JobStoreSupport.triggersFired(JobStoreSupport.java:2977)

This is relevant and I would like to discuss whether it requires a fix.

.

.

Oh for fuck's sake.

@lahma Is this problem relevant? if not, what solution did you implement? I'm currently using quartz 2.6.2 for .net, and would like to adopt an up-to-date solution.

This hasn't been addressed on either side to date.


[flash_ctrl] HWIP Technical Specification - Adding JTAG feature

Please add JTAG feature if it is used in Flash Controller. Currently only pins are mentioned.

the flash jtag feature will not be added.
This is part of the proprietary flash only, and will not be emulated as part of the open source modeling.
From verification perspective, only a connectivity test needs to be done to the boundary of the "prim_flash".
Actual verification of correct jtag behavior should be left to the proprietary simulations.

actually i should ask, what do you intend to verify if the jtag function is actually there?

actually i should ask, what do you intend to verify if the jtag function is actually there?

@sriyerg : if there is no jtag mux inside design in order to support testing operations of controller or anything else, there is nothing to be tested. Therefore i close this issue.


Suggestion: dom-recursive element for tree structured data

Usage would be as follows:
var animals= {
    title: "mammal",
    subspecies: [ {
        title: "tiger",
        subspecies: [ {
            title: "white tiger"
        } ]
    }, {
        title: "wolf"
    } ]
}

<template is="dom-recursive" tree="{{animals}}" children="subspecies">
{{item.title}}
{{depth}}
{{parent.title}}
</template>

while depth and parent are automatically calculated

There are various elements available on webcomponents.org at https://www.webcomponents.org/search/tree. For example I found https://www.webcomponents.org/element/nuxeo/nuxeo-ui-elements/elements/nuxeo-tree which might fit your usecase. Therefore I am closing this issue, as the community has some ready-made solutions.


$http cache, why are params not checked?

I know caching issues are a pain, but I wonder why request params are not part of the caching system.
Is it to save memory client side? or for other design issue I'm unaware of? Could this be a configuration parameter?
Would be great to suggest some cache compression as well, like https://github.com/pieroxy/lz-string/ could be a mere option, obviously.
Thanks for your hard work,
Ben

Request params are part of the caching system since 1.0.0rc3 (Mar 2012), so this comment is no longer relevant.
Cache compression built into the angular core would be a lot of additional bytes for people that don't need to use it and could be implemented themselves by those who do.
@apneadiving This is quite an old issue, can it be closed?

Ok no problem :)


Server doesn't check ConnectionToken's server address

What
When receiving a connection request packet, the server does not check the "server addresses" part of the connect token. The code that does so is commented out.
https://github.com/cBournhonesque/lightyear/blob/7d714079a540f3d0233a084de5a0603c7fc5caa9/lightyear/src/connection/netcode/server.rs#L567-L568
We cannot just use the UdpSocket address, as that would return the local ip, whereas we should be checking against the public ip of the server, as that is what the client would be connecting to. On LAN servers, the local ip would also play the role of the public ip.
Therefore, in order to implement this, we would need to add a value in the server config for the public server address.
Renet has something like this:
https://github.com/lucaspoffo/renet/blob/ffdcb1a2b0d509f73670aa0d46a9011ec9f61876/renetcode/src/server.rs#L109-L110
Why
This check is necessary for ensuring that the connection token that was generated was meant for this server. Otherwise someone could obtain a connection token for a specific server and use it on any server (not good). See the spec for more. Specifically the line,

If the dedicated server public address is not in the list of server addresses in the private connect token, ignore the packet.

Things to Consider
Right now the lightyear tries to keep things "transport-agnostic", so it might not be a good assumption that the transport will use IP addresses. For instance the LocalChannel enum varient of ClientTransport. However, in the Transport trait, there is a method for obtaining the address, so perhaps it is an okay assumption. See:
https://github.com/cBournhonesque/lightyear/blob/7d714079a540f3d0233a084de5a0603c7fc5caa9/lightyear/src/transport/mod.rs#L73-L75
Perhaps we could still allow the user to bypass this check in the case of a transport that doesn't have ip addresses.

I can confirm this issue exists by hosting a server on port 6000, setting up a local relay for UDP traffic with the command socat UDP4-LISTEN:6001,fork UDP4:<IP_ADDRESS>:6000 and then connecting on the client to 6001. The server lets this connection through, even though the Auth specified the address <IP_ADDRESS>:6001.
Implementing this would have breaking changes to the ServerConfig struct. I would be willing to try to take a stab at it, though I'm not sure if I understand the codebase enough to do so.

Thanks for the issue, I think everything you said makes sense!

btw, when you deploy game servers to Edgegap you listen on <IP_ADDRESS> and you have to retrieve your actual public IP from an environment variable or api call. Edgegap maps a high numbered public port onto your listening port.
please consider this if you add a server ip check to the connect token logic.. as long as you can specify the IP that connect token uses to check, rather than just trying to enumerate addresses on the machine, it should be ok.


benchmark against rust?

any difference between c++ tessil vs this rustlang crate?
https://lib.rs/crates/hat_trie
any benchmarks?

It'd be interesting to compare but I currently have little time to work on it. Would be interested if you have any comparison results.


/list endpoint needs to provide mapping for all permission levels

https://github.com/irods/irods_client_rest_cpp/blob/8500d64dfd4846b98bd091156a4d10c7bc5347e9/irods_specific_implementation/irods_rest_list_api_implementation.h#L196-L201

This will not be implemented in this repository.
Please see the new HTTP API:
https://github.com/irods/irods_client_http_api


PIP package for version 1.2.3 missing utils folder

Installed 1.2.3 on Windows 10 with python 3.6.5.
>>> import duplicate
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".virtualenvs\Duplicates-1Bkne2Yf\lib\site-packages\duplicate\__init__.py", line 13, in <module>
    from .core import CACHE
  File ".virtualenvs\Duplicates-1Bkne2Yf\lib\site-packages\duplicate\core.py", line 17, in <module>
    from .structs import Cache, DupInfo, FileInfo, FilterType, SkipException
  File ".virtualenvs\Duplicates-1Bkne2Yf\lib\site-packages\duplicate\structs.py", line 13, in <module>
    from .utils.fs import blkdevice, blksize
ModuleNotFoundError: No module named 'duplicate.utils'

I was able to download the source package and just copy into my virtualenv at least.

I ran into this too, and don't know what to download from where and copy where in a Python 3.6 install.

I am also getting the same error. Please fix it ASAP

Same error,
Python 3.8.1 (tags/v3.8.1:1b293b6, Dec 18 2019, 22:39:24) [MSC v.1916 32 bit (Intel)] on win32
deplicate in c:\program files (x86)\python38-32\lib\site-packages (1.2.3)

I'm sure I solved this some unpythonic way but I have to get past the problem. Here's what I did:
Go to wherever pip installed this package on your system
In my case this was
C:\Users\Alex P. Novickis.QCE3X\AppData\Roaming\Python\Python310\site-packages\duplicate
make a folder called utils
download this entire package from here as zip, and copy out the contents of the zip's utils folder to this new folder you made

import duplicate


Error on Code for Delete Queue

To delete a queue and all the messages contained in it, call the delete_queue method.
Python
Copy
print("Deleting queue: " + queue_client.queue_name)
queue_client.delete_queue()
I think that azure has to know which queue to Delete. I think the bolded line of code should be queue_client.delete_queue(q_name)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59cdec64-6b86-6e2b-db74-5952d825bea4
Version Independent ID: e41416cc-85b4-743b-7bcf-ac2a97297a9d
Content: How to use Azure Queue Storage from Python
Content Source: articles/storage/queues/storage-python-how-to-use-queue-storage.md
Service: storage
Sub-service: queues
GitHub Login: @twooley
Microsoft Alias: twooley

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for reporting this. I have assigned the issue to the content author to investigate further and update the document as appropriate.

#reassign: @tamram

GitHub user twooley has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#please-close
This issue already been addressed in the article.


Authenticated Webservice Activities

As a modeler, I want to use APIs that require (header based) authentication, e.g. Bearer and OAuth. As discussed in the Bookshelf project this activity should:

offer common authentication methods
take user credentials as input objects
authenticate and execute a webservice call
fully configurable.

This activity must also be added (with all configurations) in Gryphon.

This is the "big solution" we discussed yesterday, that is low priority. I will add a user story for the "lightweight" solution that just adds a header attribute in Gryphon.


Bug when using the full panel and notification

Hi,
I am using the full panel to create a form. On the left hand-side each label has own text for notification. After clicking the label, notification is shown, and if at this moment I click  the notification, then the whole panel closes.
Thank you.

Hi,
Thank you for reporting this issue. I will check this problem asap.

The latest release fixes this issue, please reopen this issue if it is not the case for you!

Thank you very much.
Downloaded the new release,  checked, all it works.
Antho Meiz<EMAIL_ADDRESS>�����(�) � ����� ������ Mon, 04 Jan
2016 17:58:19 +0200:

The latest release fixes this issue, please reopen this issue if it is
not the case for you!

Reply to this email directly or view it on GitHub:
https://github.com/quark-dev/Phonon-Framework/issues/54#issuecomment-168715078

--
Best regards,
Sergey Shevchenko


👻 Cemeteries

This is an initial implementation of cemetery rendering.  Starting this as draft so folks can play with it as we don't have an agreement on the styling yet.  This implementation uses the same fill and stroke as parks, and adds a grave POI icon.  However, based on the initial slack discussion, there is a preference towards rendering cemeteries in a color distinct from parks.

Location: https://www.openstreetmap.org/relation/8551292

The tombstone icon is very strong. I don’t see many icons like that in the current deployment. In Openstreetmap Carto there is a repeating pattern across the area, and it changes it based on the religion of the cemetery, rather than showing an icon next to the name. A similar idea is also used in Opencyclemap and CyclOSM.
Most cemeteries are mapped as areas so an icon is not needed by the name if the area rendering is understandable. I would recommend using a different color, not the same as parks.

Below are the cemetery treatments I found in my map collection, previously posted in the Slack thread linked above. In the future, let’s open a separate issue for features we want to render so we can more easily discuss the possibilities independently of a particular implementation.

Depending on the publisher, I’ve seen a green fill matching parks or something more drab; a repeating religious symbol pattern, or a solid fill juxtaposed with a tree cover–like pattern for parks.
The icon is probably only necessary at low and mid zoom levels where the label has the potential to overflow outside the bounds of the cemetery, making the location less obvious. In most maps that symbolize cemeteries with icons at smaller scales, the icon is a religious symbol matching the symbol for a place of worship, or it’s just a square or dot matching any other POI.
Arlington National Cemetery demonstrates the need for the vector tiles to represent cemetery sectors differently than cemeteries. Currently, they’re tagged as nested landuse=cemetery areas, which is unfortunate. One approach that openstreetmap-carto seems to accommodate well is nested amenity=grave_yard areas, though OpenMapTiles conflates these tags. The proposed cemetery=sector tag isn’t supported, but that’s probably the best outcome for now.

I don’t see many icons like that in the current deployment

At the moment, we don't have any POIs rendered, so the map is effectively blank of icons, with the exception of places and highway shields.  I'm working behind the scenes to set up the infrastructure for POI icons with recolorable SDFs in an efficient way but that's a bit off.  So I wouldn't consider the lack of other icons to be a stylistic choice but rather an indicator of incompletion.

it changes it based on the religion of the cemetery

Religion tagging is not available in OpenMapTiles.  This is not a deal-breaker if we decide we want to render it, but if we do, we would either have to get it added to OpenMapTiles or else render a custom layer (for example using the new customizability feature implemented in onthegomap/planetiler#160) and get it hosted somewhere.  If we do want religion-specific tagging rendered, we'll probably want something generic to render as a temporary measure until the tagging can get added to the tiles.

Religion tagging is not available in OpenMapTiles

In that case, a solid color without a pattern would be fine.

Blocked by #387

The infrastructure is now in place for POIs, however, no icons in the "green" class have been implemented yet.

Updated imagery showing potential differentiated park/cemetery rendering:

I'm finding that if I darken the colors too much, it clashes with cased roads.


PHP: add two macro for reduce duplicate code

@ZhouyihaiDing  the two macro can reduce some dup-codes and make code better clear.
Please review the PR, thanks!
The PR includes:

Add macro PHP_GRPC_DECLARE_OBJECT_HANDLER to reduce code duplication
Add macro PHP_GRPC_GET_WRAPPED_OBJECT to replace Z_WRAPPED_GRPC_XXX_P to unify all macro start with PHP_GRPC_, and delete Z_WRAPPED_GRPC_XXX_P in each header file

So far, I think that all macro have complete and are wrapped in php7_wrapper.h file.

The code looks cleaner, Thanks! Can you please rebase the PR and then I will run the tests?

The new method in line 629 added a Z_WRAPPED_GRPC_CHANNEL_P, which lead to the compile error.

sorry, rebase OK but commit log error, so close the pr, please #15401 review, thanks a lot!


Polish the documentation some

The goal here was to wipe out the custom wordlist for the spellchecker
and then see what was actually out there. A few things came out of this:

Put bits of code into code blocks more consistently so we don't
need to put e.g. module names into the dictionary.
Choose consistent capitalizations for things like gevent (based on
what upstream calls itself).
Reword things that were using awkward, abbreviated, or made up words.
Fix broken reStructuredText syntax that the spellchecker picked up
as words.

Thanks for all the feedback. Really appreciate having things that aren't clear pointed out!

:haircut_man:

:fish:


feat: added simple pkce and state checks for auth0

I don't if that's something that something in the scope of a "Minimalist Authentication module" but I added simple PKCE and state checks in the auth0 provider for extra security.
The crypto methods and check logic could easily be extracted and reused in other oauth provider. I think that Google and Spotify accept the PKCE flow and Google and Twitch both accept a state check.

The other providers could definitly benefit from a universal util that allows state checks and a pkce check.
If we can get this into like a importable util, i'd happily add it to the Discord and LinkedIn provider too.

You should probably use uncrypto instead of crypto here, as crypto might not be available in all server runtimes 😁

I would indeed leverage https://github.com/unjs/uncrypto
Also here we use randomUUID to create a random string: https://github.com/nuxt/nuxters/blob/d77b0e92092c39710aeb36d604d85b886bdc87b7/server/routes/connect/[provider].get.ts#L12

Tanks for the feedback 👍, I updated the checks to use uncrypto.
I also moved the logic in a separate util file so that other providers can simply call
const authParam = await checks.create(event, config.checks)

to get extra query param to be passed in the authorization request and
const checkResult = await checks.use(event, config.checks)

to verify the checks and get back the code_verifier if applicable.

I would like to build upon this PR and add a generic OIDC provider. I already started but these utils would be super helpful for supporting pkce flow.

Hey @Azurency,
the current implementation in the security utils file is not RFC 7636 compliant. There are some issues with the generation of the verifier and the challenge, the verifier is saved server side, which should be the challenge and the hash validation doesn't take place.
I could create a PR to adjust your implementation to the spec, but I have some questions:

What is the target of the current handler implementation for PKCE? There is currently no identity provider in this repo that would need a verification of the PKCE challenge or verifier on the server side, as we are not issuing tokens to the user
What is the target of the state check? The referenced auth0 documentation refers to SPA flow, but as we are using Nuxt SSR, we have a confidential client scenario. For simple CSRF protection, setting a fixed CSRF header value would be enough, as this would force all client to make preflight requests

@itpropro  There is currently no identity provider in this repo that would need a verification of the PKCE challenge
As @Azurency states in the PR description: The crypto methods and check logic could easily be extracted and reused in other oauth provider. I think that Google and Spotify accept the PKCE flow and Google and Twitch both accept a state check. Also #25 relies on this
@itpropro I think it would be great if you could improve the implementation.

Hey,
I think I wasn't clear with my statement. I didn't mean that there is no authentication provider that would use PKCE, but they would validate the verifier on their end, so that there is no need to verify at the Nuxt server side. I was just talking about the right place and level of PKCE in the implementation as it's about having a "PKCE client" no a PKCE server implementation.
I think it makes sense to have some kind of pipeline where the requests go through and the supported/configured features are applied (like PKCE, Nonce, State, etc.).

Thanks @itpropro I was exactly getting confused by the same issue all along while reading code changes and discussion.
What I would suggest is adding those utils on client side, there by allowing this module to work with SPAs and nuxt generate. Then we can have a separate set of clients which work client side. I think it should be a separate discussion. Work done in this PR is extemely valuable but should be ported to client side.


Error Running Captcha22 In Terminal after installing on UBUNTU 20.04.1 LTS

Installing captcha22 using both pip install captcha22 and install from the source seem to work fine, but when running right after installing, I get this error:
user@user-Predator-G3-571:~$ captcha22 Traceback (most recent call last):   File "/usr/local/bin/captcha22", line 11, in <module>     load_entry_point('captcha22==1.0.1', 'console_scripts', 'captcha22')()   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 490, in load_entry_point     return get_distribution(dist).load_entry_point(group, name)   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2854, in load_entry_point     return ep.load()   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2445, in load     return self.resolve()   File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2451, in resolve     module = __import__(self.module_name, fromlist=['__name__'], level=0)   File "/home/user/.local/lib/python3.8/site-packages/captcha22/__main__.py", line 12, in <module>     from lib.core.client import (api_basic, api_full, captcha_labeller, ModuleNotFoundError: No module named 'lib.core' user@user-Predator-G3-571:~$

Hi there,
I tried to replicate your error but was unable to. I was using a clean Ubuntu 20.04 image, installing Python3.8 and pip before installing captcha22 and I'm able to get the prompt.
The issue seems to be that it can not load the specified modules of captcha22.
Are you running this in a virtual environment? As indicated by  #3, captcha22 does not currently support virtual environments.

No, It is running natively.

I've found the issue in the import. Initial tests show that it has been resolved. I'll upload a new pip package version and update the repo.


Some error but working site

Since the update today (29.02) it seems to be working all good but I have seen the following errors since some time already.
2020-02-29 14:13:21,321 INFO Included extra file "/etc/supervisor/conf.d/supervisord.conf" during parsing
2020-02-29 14:13:21,329 INFO RPC interface 'supervisor' initialized
2020-02-29 14:13:21,329 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2020-02-29 14:13:21,330 INFO supervisord started with pid 6
2020-02-29 14:13:22,332 INFO spawned: 'python' with pid 9
2020-02-29 14:13:22,332 INFO spawned: 'fr24feed' with pid 10
2020-02-29 14:13:22,333 INFO spawned: 'piaware' with pid 11
error | Local time: 2020-02-29 14:13:22 +0100
error | GMT+0 time: 2020-02-29 13:13:22 +0100
error | Your machine should be set as GMT+0 time zone!
warning | Time zone is not set to GMT+0
2020-02-29 14:13:22 | [main][i]FR24 Feeder/Decoder
2020-02-29 14:13:22 | [main][i]Version: 1.0.24-5/generic
2020-02-29 14:13:22 | [main][i]Built on Oct 30 2019 07:23:36 (static-i386_amd64-builds-and-macos-dump1090-update-c308dae.git/Linux/amd64)
2020-02-29 14:13:22 | [main][i]Running on: debian10
2020-02-29 14:13:22 | [main][i]Local IP(s): <IP_ADDRESS>
2020-02-29 14:13:22 | [main][i]Copyright 2012-2019 Flightradar24 AB
2020-02-29 14:13:22 | [main][i]https://www.flightradar24.com
2020-02-29 14:13:22 | [main][i]DNS mode: LIBC
2020-02-29 14:13:22 | [main][i]Automatic updates are DISABLED
2020-02-29 14:13:22 | ERROR: bash: /sbin/rmmod: No such file or directory
2020-02-29 14:13:22 | [w]Detected --net argument for dump1090, disabling internal RAW feed!
2020-02-29 14:13:22 | [w]Detected --net argument for dump1090, disabling internal BS feed!
2020-02-29 14:13:22 | info | [httpd]Server started, listening on <IP_ADDRESS>:8754
2020-02-29 13:13:22Z warning: /etc/piaware.conf:7: unrecognized option flightaware-user
2020-02-29 13:13:22Z warning: /etc/piaware.conf:8: unrecognized option flightaware-password
2020-02-29 14:13:22 | [i]PacketSenderConfiguration::fetch_config(): Yoda configuration for this receiver is disabled
2020-02-29 14:13:22 | [d]TLSConnection::ctor(): Enable verify_peer in production code!
2020-02-29 14:13:22 | [main][i]Reader thread started

I would ignore the error with the different false time zone, but this "bash error" could be maybe fixed and "piaware.conf:7: unrecognized option" seems to be a problem since I got my piaware.conf like this, which should correct.
# This file configures piaware and related software.
# You can edit it directly or use piaware-config from the command line
# to view and change settings.
#
# If /boot/piaware-config.txt also exists, then settings present in
# that file will override settings in this file.
flightaware-user user123
flightaware-password password123456
feeder-id b***b645-****-****-****-d59ab6f***3c

The flightaware feeder seems to be working when I visit the "My ADS-B" page.

I got the same error for the configuration, you can remove username and password it's deprecated.
I do not have the time error.
And it looks like it missing a library for rmmod

fixed 66ce1feb66d2126f57ac2cf09a71e341ebb8ccf8


pytorch-directml does not support torch.nn.gru yet?

import torch
import torch.nn as nn

if __name__ == '__main__':
    device = torch.device("dml")
    gru1 = nn.GRU(input_size=50, hidden_size=50, num_layers=2, bidirectional=True, dropout=0.3)
    gru1=gru1.to(device)
    embed = nn.Embedding(3, 50)
    x = torch.LongTensor([[0, 1, 2]])
    x_embed = embed(x).to(device)
    out= gru1(x_embed)
    print(out.size())

It's error on out= gru1(x_embed) :

CHECK failed: ((((HRESULT)((dml_device_->GetDeviceRemovedReason()))) >= 0)) == (true):

and GRU not shown in Roadmap
so is this error caused by that the DML does not support nn.gru?
My setup

Windows 10 Professional
Version 10.0.19044 Build 19044
Intel Core i5-12400F
AMD Vega 64

@Adele101 @smk2007 - can you respond, since this is related to PyTorch, not DirectML?

Hi @RegimenArsenic,
Thank you for the request, we will consider this for an upcoming release of pytorch-directml, and will update this thread when more information is available.

Hi @RegimenArsenic, we have implemented float32 support for the GRU operator in torch-directml-0.1.13.dev221216. Please give it a shot and let us know if you're facing any other issues.


jump to next prev diagnostic throws an error

Describe the bug
https://user-images.githubusercontent.com/20822372/213921686-12d461be-8be1-432a-a1cc-cb3707aaec04.mov
Jump to next or prev diagnostic gives me an error message.
Steps to reproduce
in video
Expected behavior
go to where the diagnostics come from without an error.
Neovim version (nvim -v)
0.8.2
lspsaga commit
goto_next, goto_prev error
Terminal name/version
kitty 0.26.5

if you use diagnostic function to jump now you.need use diagnostic:goto_next. command no need change

if you use diagnostic function to jump now you.need use diagnostic:goto_next. notice not dot symbol. command no need change

I don't quite get what you're saying. My keymap for goto_next, goto_prev. what is the dot symbol you meant by?
keymap.set("n", "[d", function() 	require("lspsaga.diagnostic").goto_prev({ severity = vim.diagnostic.severity }) end)
	keymap.set("n", "]d", function() 		require("lspsaga.diagnostic").goto_next({ severity = vim.diagnostic.severity }) 	end)

if you use diagnostic function to jump now you.need use diagnostic:goto_next. notice not dot symbol. command no need change

Oh okay I found the problem. I think you need to change the doc on " :Lspsaga diagnostic_jump_next " section.

I kept looking at this code, so I couldn't find the difference from mine.
It is correct on " Example Configuration "


fix(es/minifier): Fix mapbox

Description:
swc_ecma_minifier:

mangler: Handle the identifiers of class expresions correctly.

As shown above, name mangler assigns i to a class expression and uses it again inside the class, as the name of a parameter.
This results in an exception from new i.

This is a fixed version.

(I copy-pasted it to js beutifier)
Related issue (if exists):

https://github.com/vercel/next.js/discussions/30237?sort=new#discussioncomment-2109335

I'll merge it as code changes are quite trivial


Add Readme for the operator helm chart

Is this the right place to submit this?

[X] This is not a question about how to use the sail-operator

Feature Description
We are publishing our operator helm chart but it's missing a Readme.
It should contain information how to install on K8s and OCP.
Additional Information
No response

Hi @FilipB
Are we publishing the sail-operator help charts to some place?
I haven't found it on ArtifactHub.
Or should I define charts deployment from the repository in a readme file?
Thanks.

Currently it's only published as a part of GH release. I'm not sure what's the plan with ArtifactHub, let's discuss on next team call.


Create method for tallying items in QuestionList results

The results tally() method is not working - here for checkbox results:

Modify to work for lists of lists

Still getting this error after other PR merged

tally() should allow user to select results based on tally count eg exclude results where tally < 10

@rbyh: Can you create a simple, ok-to-share results object on coop + post URL here that has a tally fail? It will help me write agains that.


FF4J.org IS DOWN

Waiting for my internet provider to release the domain name (I changed provider)

Site is back, some elements to add like the REST API sample


Real-time ping plugin

I would really like an expansion of the ping plugin in the world hopper.  What I mean by this, is to have the option to also have your ping displayed on screen (perhaps with the FPS).  This ping indicator will also display your current ping in real-time, rather than having to manually check your ping.  Currently the ping plugin for the world hopper has to test every single world and because of this it can take a while before it even show the world you are on.  It also only tests the ping once and will display what it gets back, this can lead to it saying that your ping to the world you are on is only 25ms when you are actually spiking to 200ms every now and then.  With a real-time ping plugin it shows ping that is actually relevent and accurate to your osrs experience.
Pros-
Can see the stability of your connection.
Could possibly save a HCIM from lag related deaths.
Automatic and accurate.
Shows your ping to that world instead of having to bother with 90+ worlds you may never play on.
QoL.
On-par with most games that have the same ping displayer.
Cons-
As far as I know, none.
There might be client stability issues from it but I'm no coder so this one may very well be entirely inaccurate.

Duplicate of #2640 (It's closed because ping was added to the World Hopper, but there  is #8871 which will do what you want)


🛠 Update Contributors Guidelines

About
The Contributors guidelines need to be updated and "de-jargonified" so that it is clear how new members of the community can add to the Glossary of Terms.
Is your task request related to a problem with the website or Glossary?
Contributors Guidelines
What Needs to be Done

[x] Consolidate feedback from TPS CommM session
[x] Update Contributors Guidelines in both repositories

Done. Addressed in this commit.

Done. Addressed in this commit.


Variable _s leaking in bin/vows

Lines 381ff
    function getMatchingTest(file, join) {
        join || (join = '-');
        var testFile;
        if (specFileExt.test(file)) {
            testFile = path.join(testFolder, file);
        }
        else {
            var root, extension;
            _s = file.split('.'), root = _s[0], extension = _s[1];
            testFile = path.join(testFolder, root + join + testFolder + "." + extension);

_s is not being declared and might leak...

This isn't the case in 1.x, so I'm closing this.


Lang block isn't formatting HTML

add bx-def-vanilla-html  class for Lang block.

Duplicate #4578

Duplicate https://github.com/unacms/una/issues/4578


Prevents usage of unsupported texture shader types in GLES2

GLES2 supported only sampler2D and samplerCube, all other types lead to the shader crash.

Thanks!


Icon

How to change the appearance of the system tray icon?

At this point, looks like only changing the icons and building the app yourself.


class file for com.google.android.gms.internal.zzbej not found

Expected Behaviour
The application crashes immediately after the splash screen.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
cli packages: (C:\Users\lsantaniello\AppData\Roaming\npm\node_modules)
    @ionic/cli-utils  : 1.19.2
    ionic (Ionic CLI) : 3.20.0

global packages:
    cordova (Cordova CLI) : not installed

local packages:
    @ionic/app-scripts : 3.1.8
    Cordova Platforms  : android 7.1.0 browser 5.0.3 ios 4.5.4
    Ionic Framework    : ionic-angular 3.9.2

System:
    Node : v8.9.4
    npm  : 5.6.0
    OS   : Windows 10

Environment Variables:
    ANDROID_HOME : not set

Misc:
    backend : pro

Plugin version
phonegap-plugin-push 2.2.2 "PushPlugin"
Logs taken while reproducing problem
* Where:
Script 'C:\myapp\platforms\android\phonegap-plugin-push\weareenergy-push.gradle' line: 35

* What went wrong:
A problem occurred evaluating project ':app'.
> Failed to apply plugin [class 'com.google.gms.googleservices.GoogleServicesPlugin']
   > For input string: "+"

I tried to modify android.properties...
old
target=android-27
android.library.reference.1=CordovaLib
android.library.reference.2=app
cordova.gradle.include.1=cordova-fabric-plugin/weareenergy-build-extras.gradle
cordova.system.library.1=com.squareup.okhttp3:okhttp-urlconnection:3.10.0
cordova.system.library.2=com.android.support:support-v4:24.1.1+
cordova.system.library.3=com.google.android.gms:play-services-analytics:+
cordova.system.library.4=com.android.support:support-v13:27.+
cordova.system.library.5=me.leolin:ShortcutBadger:1.1.17@aar
cordova.system.library.6=com.google.firebase:firebase-messaging:11.6.2
cordova.gradle.include.2=phonegap-plugin-push/weareenergy-push.gradle
cordova.gradle.include.3=cordova-android-play-services-gradle-release/weareenergy-cordova-android-play-services-gradle-release.gradle

I changed  com.google.android.gms:play-services-analytics:11.6.2
target=android-27
android.library.reference.1=CordovaLib
android.library.reference.2=app
cordova.gradle.include.1=cordova-fabric-plugin/weareenergy-build-extras.gradle
cordova.system.library.1=com.squareup.okhttp3:okhttp-urlconnection:3.10.0
cordova.system.library.2=com.android.support:support-v4:24.1.1+
cordova.system.library.3=com.google.android.gms:play-services-analytics:11.6.2
cordova.system.library.4=com.android.support:support-v13:27.+
cordova.system.library.5=me.leolin:ShortcutBadger:1.1.17@aar
cordova.system.library.6=com.google.firebase:firebase-messaging:11.6.2
cordova.gradle.include.2=phonegap-plugin-push/weareenergy-push.gradle
cordova.gradle.include.3=cordova-android-play-services-gradle-release/weareenergy-cordova-android-play-services-gradle-release.gradle

but now I have this error:
C:\myapp\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:74: error: cannot access zzbej
    String from = message.getFrom();
                         ^
  class file for com.google.android.gms.internal.zzbej not found
Note: Some input files use or override a deprecated API.
 FAILED

Been having this problem since yesterday. Thought it was the older version of the plugin (I was using 1.10.7, and tried upgrading to 1.11.0) but had the same issue. I was in the process of upgrading to 2.2.2, since I assumed that this problem would be solved there - but since it's not I am going to wait a bit longer.

I don't understand. Could you please support me?

@lsantaniello yeah, this is a duplicate of #1718. Sadly the way Android dependencies have evolved and the Cordova plugin ecosystem includes shared libraries we run into a lot of these problems. You are doing the right thing by matching your play services and fcm versions.
With your latest build error I'd look at cleaning out the android platform completely, then making sure all your android dependencies are up to date, then trying a re-build.

I followed all these steps but the issue persists is there perhaps a newer solution?

@Ross-Rawlins I can fix my build by changing cordova.system.library.11=com.google.firebase:firebase-messaging: to 12.0.0 in the project.properties.
All my play-services are running on google-play-service version 12.0.0.
Themes like they removed message.getFrom in the higher releases.

Same issue here.
I have the following message when I try to build:
platforms/android/src/com/adobe/phonegap/push/FCMService.java:74: error: cannot access zzbej
    String from = message.getFrom();
                         ^
  class file for com.google.android.gms.internal.zzbej not found

My android.properties is like this:
target=android-26 android.library.reference.1=CordovaLib cordova.gradle.include.1=cordova-android-play-services-gradle-release/egnosapp-cordova-android-play-services-gradle-release.gradle cordova.system.library.1=com.squareup.okhttp3:okhttp-urlconnection:3.10.0 cordova.system.library.2=com.android.support:support-v4:24.1.1+ cordova.system.library.3=com.android.support:support-v4:26.+ cordova.system.library.4=com.android.support:appcompat-v7:26.+ cordova.system.library.5=com.android.support:support-v13:26.+ cordova.system.library.6=me.leolin:ShortcutBadger:1.1.17@aar cordova.system.library.7=com.google.firebase:firebase-messaging:11.6.2 cordova.gradle.include.2=phonegap-plugin-push/egnosapp-push.gradle
My plugin version is 2.1.2

@AlbertoGomezMartin yeah, as you can see in the android.properties two different plugins add v4 support libs at different API levels. That's going to cause a problem. What plugins are you using?

Hi @macdonst
My plugin list is as follows:
com.lampa.startapp 0.1.4 "startApp" cordova-android-play-services-gradle-release 1.4.1 "cordova-android-play-services-gradle-release" cordova-android-support-gradle-release 1.4.2 "cordova-android-support-gradle-release" cordova-custom-config 3.0.14 "cordova-custom-config" cordova-open 1.0.12 "Open" cordova-plugin-advanced-http 1.11.0 "Advanced HTTP plugin" cordova-plugin-app-version 0.1.9 "AppVersion" cordova-plugin-device 1.1.7 "Device" cordova-plugin-file 6.0.1 "File" cordova-plugin-file-transfer 1.7.1 "File Transfer" cordova-plugin-geolocation 3.0.0 "Geolocation" cordova-plugin-globalization 1.0.8 "Globalization" cordova-plugin-inappbrowser 2.0.2 "InAppBrowser" cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard" cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview" cordova-plugin-network-information 1.3.4 "Network Information" cordova-plugin-screen-orientation 3.0.1 "Screen Orientation" cordova-plugin-splashscreen 4.1.0 "Splashscreen" cordova-plugin-statusbar 2.4.1 "StatusBar" cordova-plugin-whitelist 1.3.3 "Whitelist" cordova-plugin-wkwebview-engine 1.1.4 "Cordova WKWebView Engine" cordova.plugins.diagnostic 4.0.5 "Diagnostic" es6-promise-plugin 4.2.2 "Promise" ionic-plugin-keyboard 2.2.1 "Keyboard" phonegap-plugin-push 2.1.3 "PushPlugin"
I just removed the 'cordova-plugin-camera' that included the 'com.android.support:support-v4:24.1.1+ ' library (I don't need access to camera),
So my android.properties updated is
target=android-26 cordova.gradle.include.1=cordova-android-support-gradle-release/egnosapp-cordova-android-support-gradle-release.gradle cordova.system.library.1=com.squareup.okhttp3:okhttp-urlconnection:3.10.0 cordova.system.library.2=com.android.support:support-v4:26.+ cordova.system.library.3=com.android.support:appcompat-v7:26.+ cordova.system.library.4=com.android.support:support-v13:26.+ cordova.gradle.include.2=cordova-android-play-services-gradle-release/egnosapp-cordova-android-play-services-gradle-release.gradle android.library.reference.1=CordovaLib cordova.system.library.5=me.leolin:ShortcutBadger:1.1.17@aar cordova.system.library.6=com.google.firebase:firebase-messaging:11.6.2 cordova.gradle.include.3=phonegap-plugin-push/egnosapp-push.gradle
And it is still showing the following when trying to build in Android (btw, in ios it works perfectly)
`platforms/android/src/com/adobe/phonegap/push/FCMService.java:74: error: cannot access zzbej
String from = message.getFrom();
^
class file for com.google.android.gms.internal.zzbej not found
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':compileDebugJavaWithJavac'.`

Any help would be really appreciated

To whom it may concern, I uninstall these plugins and the error dissapeared:
cordova-android-play-services-gradle-release 1.4.1 "cordova-android-play-services-gradle-release"
cordova-android-support-gradle-release 1.4.2 "cordova-android-support-gradle-release"

👍

FYI, cordova-android-play-services-gradle-release can be used in conjunction with the newly created cordova-android-firebase-gradle-release to resolve build issues where another plugin in the project specifies a different version of the Play Services and/or Firebase libraries.
For example:
cordova create test && cd test
cordova platform add<EMAIL_ADDRESS>cordova plugin add<EMAIL_ADDRESS>cordova plugin add<EMAIL_ADDRESS>cordova build android
> :app:compileDebugJavaWithJavacD:\Temp\test\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:74: error: cannot access zzbej
>    String from = message.getFrom();
>                         ^
>  class file for com.google.android.gms.internal.zzbej not found
> FAILURE: Build failed with an exception.

:cry:
cordova plugin add cordova-android-play-services-gradle-release  --variable PLAY_SERVICES_VERSION=15.+
cordova plugin add cordova-android-firebase-gradle-release  --variable FIREBASE_VERSION=15.+
cordova build android
> BUILD SUCCESSFUL

:sunglasses:

@dpa99c This got me closer (I think), but now I'm getting this new error
The library com.google.android.gms:play-services-measurement-base is being requested by various other libraries at [[15.0.2,15.0.2]], but resolves to 15.0.4. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies

I tried specifying 15.0.2 (instead of 15.+), but then I get an error that that version of the plugin doesn't exist. 😭
Any ideas?

@itslenny : have u fixed this? am facing it and tried many many solutions uselessly :(

@dpa99c  i have installed both command but i got below error:

What went wrong:
The library com.google.android.gms:play-services-measurement-base is being requested by various other libraries at [[15.0.2,15.0.2]], but resolves to 15.0.4. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies.

I fixed it by specifying the firebase version FCM_VERSION when adding the plugin.
cordova plugin add phonegap-plugin-push --variable FCM_VERSION=17.1.0

I fixed it by specifying the firebase version FCM_VERSION when adding the plugin.
cordova plugin add phonegap-plugin-push --variable FCM_VERSION=17.1.0

This solved my issue too. Thanks.


support FindCoordinatorReqV0 encode and FindCoordinatorRespV0 decode

Codecov Report

Merging #34 (f799fb4) into main (c7548ea) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   94.17%   94.21%   +0.03%
==========================================
  Files          55       55
  Lines        3127     3146      +19
==========================================
+ Hits         2945     2964      +19
  Misses        129      129
  Partials       53       53

Impacted Files
Coverage Δ

codec/find_coordinator_req.go
100.00% <100.00%> (ø)

codec/find_coordinator_resp.go
94.82% <100.00%> (+0.59%)
:arrow_up:

codec/util_kafka_string.go
91.37% <100.00%> (+0.15%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


include (sql N+1) issue

class User extends Model {
}

@BelongsTo(parent = User.class, foreignKeyName = "user_id")
class Book extends Model {
}

List<User> users = User.findAll().limit(1).include(Book.class)
User user = users.get(0);
List<Book> books = user.getAll(Book.class)

the expect sql only is:
SELECT * FROM users limit 1;
SELECT * FROM books where user_id in ("user_id");
But when user has not books, Will be re execute:
SELECT * FROM books where user_id = ("user_id");
The cause of the problem is:
// at LazyList.processChildren(OneToManyAssociation association)
for(T parent : delegate){
  List<Model> children = childrenByParentId.get(parent.getId());
  // parent not set children when children is null!
  if(children != null){
     parent.setChildren(childMetaModel.getModelClass(), children);
  }
}

parent not set children when children is null
and when execute Model.getAll()
public <C extends Model> LazyList<C> getAll(Class<C> clazz) {
  List<Model> children = cachedChildren.get(clazz);
  // children is null
  if(children != null){
    return (LazyList<C>) children;
  }
  return get(clazz, null);
}

re execute sql when children is null
return get(clazz, null);

@ivancxj sorry, I do not fully understand what the issue is. Are you experiencing a problem, or reporting a bug?

table users data

id
name

1
user name1

2
user name2

3
user name3

4
user name4

table books data

id
user_id
name

1
1
book name

we run:
List<User> users = User.findAll().include(Book.class)
for(User user: users){
  List<Book> books = user.getAll(Book.class)
}

we expect sql only is:
SELECT * FROM users ;
SELECT * FROM books where user_id in (1,2,3,4);

But because user(id=2), user(id=3) and user(id=4) has not books,  it will execute :
SELECT * FROM users ;
SELECT * FROM books where user_id in (1,2,3,4);
SELECT * FROM books where user_id = 2;//   *should not appear!*
SELECT * FROM books where user_id = 3;//   *should not appear!*
SELECT * FROM books where user_id = 4;//   *should not appear too!*

Fixed in https://github.com/javalite/activejdbc/pull/667