Activity in ScrollPosition may fails to update drag status.

Hi, anyway better to solve this?
details in https://github.com/flutter/flutter/issues/115426

This does not looks like an appropriate solution for https://github.com/flutter/flutter/issues/115426. I appreciate the contribution though! Can you describe why the issue is happening? Or what the root cause is?

Hi - @Piinks, I found the setPixels is called when the ballistic animation is over, and the applyUserOffset isn't called at this time, which lead to the current ScrollView can still accept gesture events, even the pixels, minScrollExtent and maxScrollExtent are 0.0. Is there any soution better to solve this? Thanks.

Is there any soution better to solve this?

I am not sure, and unfortunately I can't look into this issue right now. This current proposal appears to be breaking a lot of tests, so I am not sure it is the right way to go.

Any progress? @endless7 @Piinks


Update wiki

Hi
I want to update the wiki but I don't think it's letting me.
I want to change this page:
https://github.com/stevenschobert/instafeed.js/wiki/Managing-Access-Tokens
specifically where it says: "Follow the instructions to deploy the Instagram Token Agent app, providing the starting token"
I think this should be a new sub list with multiple options as I tried the linked Instagram Token Agent but this is currently not usable. See here.
The solution is to use: https://www.instant-tokens.com/
Thanks, this js plugin is amazing :)

I raised a PR for this exact purpose :)
https://github.com/stevenschobert/instafeed.js/pull/718

Oh, amazing, thanks @AnaFCPreto


Add automatic deploy to PyPI workflow

Added deploy to PyPI as per https://github.com/marketplace/actions/pypi-publish
Not possible to test without merging and making a release?
Should be ok I guess..
Closes #9

THis did not work.. Forgot a line :(


refactor(client): modify the enabled version to v1.11.0 of "delete_data"

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.025%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5258

Relevant Lines:
6333

💛  - Coveralls


DOC: ADD requirements section

What's wrong with the existing documentation
I want to add requirements section to code assign it to me
Add ScreenShots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

What will you add in Requirements section @hasmithagunda123 ?


reference-selector

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: reference-selector
Document link: reference-selector.md
My Issue/Suggestion
The Constrained By function should get it's own header (so 3.10.3) since it is completely independent of XPath constraints. See also the doumentation of Mx7 (https://docs.mendix.com/refguide7/reference-selector/) where it does get it's own header. Now when searching on Constrained by you will always see the Mx7 version first.

Hi Ronald.
Thanks for your suggestion.
I have taken the opportunity to restructure this section a bit in #7380 . Unfortunately, I don't think I can restructure it enough to have the section for Mendix 10 found before the Mendix 7 version. That would mean completely restructuring the Mendix 7 page to use lower-level headings, which is not worth it since it is not supported any more.
We are looking at improving Google's sorting of our pages to try to improve this, but this is likely to be a fairly long project as SEO is a bit of a black art.
Thanks for reporting this and helping improve the Mendix documentation.
Yours
Mark van Ments


Feature - Colors

Problem
A design might not only contain textstyles but also colors. Ideally, i will want to generate the colors also.
Request
Plugin should have capability to generate color class. Somewhere in the options menu, i should be able to say exactly what i want to generate (textstyles or colors).

Closed in 5b180634f165eacade25fc3e02763f098454df74


Broken typescript generated, when using dots in method names

Describe the bug
Incorrect methods names when using typescript client generator on a schema that has dots in method names.
To Reproduce
Steps to reproduce the behavior:

run npm install -g @open-rpc/generator
Create file openrpc.json with the following content using dots in method names:

{
  "openrpc": "1.0.0-rc1",
  "info": {
    "title": "test",
    "version": "1.0.0"
  },
  "methods": [
    {
      "name": "foo.bar",
      "summary": "test",
      "params": [],
      "result": {
        "name": "fooBarResult",
        "schema": {
          "type": "object"
        }
      }
    }
  ]
}

run open-rpc-generator generate -t client -l typescript -n test-d ./openrpc.json -o ./generated
go to ./generated/client/typescript/src/index.ts
See typescript error on line 153 due to incorrect syntax.

  public foo.bar: FooBar = (...params) => {
    return this.request("foo.bar", params);
  }

Expected behavior
Dot replaced with '_' (or somehow removed, like fooBar) for typescript method name:
  public foo_bar: FooBar = (...params) => {
    return this.request("foo.bar", params);
  }

Desktop

OS: Windows 10
@open-rpc/generator version ^1.18.11

I encounter the same problem just in a hour, I use zenrpc to build server side rpc server. And I try to convert its smd schema into openrpc and generate client from the converted one. But the problem is zenrpc have the concept called namespace, which just add namespace in from of the method name. And cursed the openrpc generator generated invalid typescript like this.
/**
   *
   */
  // tslint:disable-next-line:max-line-length
  public user.Login: UserLogin = (...params) => {
    return this.request("user.Login", params);
  }

I figured out a workaround - I just wrote a post-generation script, that replaces dots with underscores in the final file. Here is the function, it's quite naive, but works:
import { readJson, readFile, writeFile } from "fs-extra";
import { OpenrpcDocument as OpenRPC, MethodObject } from "@open-rpc/meta-schema";

const fixMethodsWithDots = async (openrpcFilePath: string, generatedFilePath: string, finalOutputPath: string) => {
  const openrpcDocument: OpenRPC = await readJson(openrpcFilePath);
  let generatedFileContents: string = await readFile(generatedFilePath, "utf-8");
  const methodNames: string[] = openrpcDocument.methods.map(method => (<MethodObject>method).name);

  const methodNamesReplacements: [string, string][] = methodNames.map(methodName => (["public "+methodName, "public "+methodName.replace(".", "_")]));

  for (const [withDot, withUnderscore] of methodNamesReplacements) {
    generatedFileContents = generatedFileContents.replace(withDot, withUnderscore);
  }

  await writeFile(finalOutputPath, generatedFileContents);
}

I'll keep it for now, so it just works, but I'm really looking forward to this bugfix.

I modify the master to generate code I want. https://github.com/Laysi/open-rpc-generator
It would generated nested class to move the method into its own namespace class. and add some tweak to made it working under angular environment and ci. Compare to openapi generator it still lack some custom field for further usage in template.

Thanks for the issue and nice catch.
Im happy to implement or take a PR for the initially suggested fix. The nesting fix is very interesting, and I don't want to completely dismiss it, but its quite a bit bigger of a change. Great work on creating a fork to implement it though - really nice!
Let me know if you wanna make a PR, otherwise Ill get to it sooner or later :)

Thanks for the issue and nice catch.
Im happy to implement or take a PR for the initially suggested fix. The nesting fix is very interesting, and I don't want to completely dismiss it, but its quite a bit bigger of a change. Great work on creating a fork to implement it though - really nice!
comment if you want to make a PR, otherwise ill put one together soon.

Thanks, I didn't made PR in first place because it seems out of the scope of jsonrpc spec have with namespace concept. But now I thought it would be fine to treat it as a extension in ts-client implement.
I glad to make a PR. :) I will remove these specified env tweak to made a new branch which have purer change.


bc-jmail Bundle does not import jakarta.mail packages where bc-mail imports javax.mail packages

Hello,
I am trying to move from javax.mail to jakarta.mail thanks to owner of Java Trademark.
I tried to replace the bc-mail with bc-jmail but I get the following exception:
Caused by: java.lang.ClassNotFoundException: jakarta.mail.MessagingException not found by bcjmail [41]
        at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1591)
        at org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:79)
        at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1976)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
        ... 15 more

I have seen that bc-jmail Bundle does not import jakarta.mail packages where bc-mail imports javax.mail packages.
I have following packages on the runtime:
38|Active     |    3|bcpkix (1.78.1)|1.78.1
39|Active     |    3|bcprov (1.78.1)|1.78.1
40|Active     |    3|bcpg (1.78.1)|1.78.1
41|Active     |    3|bcjmail (1.78.1)|1.78.1
42|Active     |    3|bcutil (1.78.1)|1.78.1

Can you fix the error in the bc-jmail Bundle and import jakarta.mail packages, please?

I guess this Import was wrong in the 1.78.1 Version but fixed on the main by this change, which is not yet released:
https://github.com/bcgit/bc-java/commit/0b17828e62a8f7510978d167fd7d9a62109f249d#diff-59f78c5fd86156da09a8e5a69c77a80cbfcf4b7ffb5a20155a927fd059621512
1.78.1 Version without Jakarta Imports:
https://github.com/bcgit/bc-java/blob/1.78.1/jmail/build.gradle#L87
Latest on main Version with Jakarta Imports:
https://github.com/bcgit/bc-java/blob/main/jmail/build.gradle#L88
Are there any snapshots or daily/weekly builds which we can use?

Try what's on https://www.bouncycastle.org/betas

I had tried Beta from Apr 13, 2024 but it was still not containing any jakarta import statement in the META-INF/MANIFEST.MF and commit I found seems later than Apr 13, 2024.
Currently Betas Page is giving 404 when I try the link:
https://downloads.bouncycastle.org/betas/bcjmail-jdk18on-1.78.1.jar
If there are new betas building then I can try them.

Might be a caching issue. The current page has 1.79-SNAPSHOT in it.

Thank you very much, it seems like now it is working as expected.
On the pure OSGI setup I still get an error due since MailCap can not load MIME Parsers but it is probably an error on the jakarta.activation side, which I already have a workaround. Bouncy Castle part is working as expected.


Use UTF-8 instead

CloudWatch Logs API can accept UTF-8 but this plugin sets force_encoding('ASCII-8BIT') and it prevents us from sending messages that has valid UTF-8 string.
Changes

Use String#encode to encode strings to UTF-8 and set :invalid => :replace to ensure that invalid UTF-8 strings will be replaced and let the plugin continues working
Use String#bytesize instead of String#length

:+1: I ran into this issue today--the current code not only won't send UTF-8 but raises an exception (and makes the plugin stop working) if any non-ASCII characters are present.

+1
015-10-22 15:14:52 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-10-22 15:14:53 +0000 error_class="Encoding::UndefinedConversionError" error="\"\\xE2\" from ASCII-8BIT to UTF-8" plugin_id="object:3fe3cf130b44"
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/2.2.0/json/common.rb:223:in `encode'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/2.2.0/json/common.rb:223:in `generate'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/2.2.0/json/common.rb:223:in `generate'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/2.2.0/json/common.rb:394:in `dump'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/json.rb:36:in `dump'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/json/builder.rb:14:in `to_json'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/json/handler.rb:30:in `build_body'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/json/handler.rb:23:in `build_request'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/json/handler.rb:10:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/plugins/user_agent.rb:12:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/seahorse/client/plugins/endpoint.rb:41:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/plugins/param_validator.rb:21:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/seahorse/client/plugins/raise_response_errors.rb:14:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/aws-sdk-core/plugins/param_converter.rb:21:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/seahorse/client/plugins/response_target.rb:21:in `call'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/seahorse/client/request.rb:70:in `send_request'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.1.30/lib/seahorse/client/base.rb:207:in `block (2 levels) in define_operation_methods'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:136:in `put_events'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:123:in `put_events_by_chunk'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:91:in `block in write'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:49:in `<<'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:49:in `each'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:49:in `each'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluent-plugin-cloudwatch-logs-0.1.1/lib/fluent/plugin/out_cloudwatch_logs.rb:49:in `write'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.16/lib/fluent/buffer.rb:325:in `write_chunk'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.16/lib/fluent/buffer.rb:304:in `pop'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.16/lib/fluent/output.rb:321:in `try_flush'
  2015-10-22 15:14:52 +0000 [warn]: /ruby/lib/ruby/gems/2.2.0/gems/fluentd-0.12.16/lib/fluent/output.rb:140:in `run'
2015-10-22 15:14:53 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-10-22 15:14:55 +0000 error_class="Encoding::UndefinedConversionError" error="\"\\xE2\" from ASCII-8BIT to UTF-8" plugin_id="object:3fe3cf130b44"
  2015-10-22 15:14:53 +0000 [warn]: suppressed same stacktrace
2015-10-22 15:14:55 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-10-22 15:14:59 +0000 error_class="Encoding::UndefinedConversionError" error="\"\\xE2\" from ASCII-8BIT to UTF-8" plugin_id="object:3fe3cf130b44"
  2015-10-22 15:14:55 +0000 [warn]: suppressed same stacktrace
2015-10-22 15:14:59 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-10-22 15:15:07 +0000 error_class="Encoding::UndefinedConversionError" error="\"\\xE2\" from ASCII-8BIT to UTF-8" plugin_id="object:3fe3cf130b44"
  2015-10-22 15:14:59 +0000 [warn]: suppressed same stacktrace
2015-10-22 15:15:07 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-10-22 15:15:22 +0000 error_class="Encoding::UndefinedConversionError" error="\"\\xE2\" from ASCII-8BIT to UTF-8" plugin_id="object:3fe3cf130b44"
  2015-10-22 15:15:07 +0000 [warn]: suppressed same stacktrace

Thank you!

v0.1.2 released

running 0.4.5 and still seeing this issue
2019-03-27 16:48:01 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2019-03-27 16:47:12 +0000 error_class="Encoding::UndefinedConversionError" error="\"\\xE2\" from ASCII-8BIT to UTF-8" plugin_id="object:2ac8eebb65fc"


New Feature Query: Parameterized profile pic mask

Personally, I think it adds to the theme:

[params]
profilePicture = "images/profile.jpg"
profilePictureMask = "images/star.svg"

Just let me know, implementation is already done but hiding behind my other pull request because I messed up my master branch over here. I'll make some more sample masks to put into the theme.
Carmine

@cdichiara  Thanks for bringing up this idea! Custom image shapes are even currently possible, by using a custom CSS.
I don't quite see the need for it, as in the past most users either had a round, or completely squared image. Both looked fine in my opinion. If someone really wants to go wild, then they could always use custom CSS to give it let's say a star shape. If you want, we could add a description to the documentation on a custom mask could be used to change the appearance of the profile image.  Does that sound like a viable alternative to you?

@cdichiara  Thanks for bringing up this idea! Custom image shapes are even currently possible, by using a custom CSS.
I don't quite see the need for it, as in the past most users either had a round, or completely squared image. Both looked fine in my opinion. If someone really wants to go wild, then they could always use custom CSS to give it let's say a star shape. If you want, we could add a description to the documentation on a custom mask could be used to change the appearance of the profile image.  Does that sound like a viable alternative to you?

@lxndrblz
Thanks for reviewing. I'll comment on the font idea more completely. What you say here makes sense to me.
Carmine

@lxndrblz
Thanks for reviewing. I'll comment on the font idea more completely. What you say here makes sense to me.
Carmine


Be able to drag components up and down

E.g. In a to-do list you can prioritise tasks by dragging them up or down.

I was searching for this ability. Did you find a way to do drag&drop using pynecone? I'm evaluating pynecone for a Kanban-like UI, where that would be essential.


chore: update smr only when visible

What does this PR change?
Set the updateWhenOffscreen flag to false for SMR. In GP it was creating an unnecessary overhead
It goes from this

to this

440 SMR renderers where updated unnecessarily just by standing on the clouds in GP
How to test the changes?

Launch the explorer
Walk around for GP and look for robots/characters. They should all behave normally
Check the shark in Goerli at 73,-8. Check that it swims, and bites when clicked

Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Amazing!


RATIS-1052. Fix the testDisconnectLeader assertion

What changes were proposed in this pull request?
Fix the testDisconnectLeader assertion in LeaderElectionTests.java, now the logic of that assertion is forever success, so, I fix it by this PR.
What is the link to the Apache JIRA
RATIS-1052
How was this patch tested?
It is already a test.

@runzhiwang Please take a look at this PR, I think the related test have a wrong assertion.

+1

@maobaolong Thanks the patch. I have merged it.

+1!


firefox/wrapper.nix: Fixed issue #118860

Motivation for this change
Since https://github.com/NixOS/nixpkgs/commit/eedee46f2fff823147d1b9aaa767397737bdea11 pkgs.firefox is always "managed by your organization". This is because the Extensions section of enterprisePolicies is always set.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

It would be great to not only have the issue number in the commit message because if it disappears we have no idea what happened here.

So semantically this looks good to me, but I find the indentation a bit confusing as is.

So semantically this looks good to me, but I find the indentation a bit confusing as is. Could you improve that maybe while touching the file?

How do you think it could be improved? I was about to merge this.

So semantically this looks good to me, but I find the indentation a bit confusing as is. Could you improve that maybe while touching the file?

How do you think it could be improved? I was about to merge this.

Around https://github.com/NixOS/nixpkgs/blob/94d7d46e20ad1673d73d4a4e53883f8e216807ec/pkgs/applications/networking/browsers/firefox/wrapper.nix#L111, but its ok to merge this as is I think. We can fix that in a separate pr.


Make non-license (non-)permissions more explicit

Building on/abbreviation of #422 by @bill-auger

thank you for your prompt attention - this PR satisfies my primary concern which was to make these two paragraphs more harmonious and less apparently contradictory by somehow making more clear that the GitHub TOS alone is insufficient for a repo that is intended to be widely and regularly used
.... as fostered by a copyleft or open-source license.

i do wish that the word "copyleft" had not been omitted - i specifically included both "copyleft" and "open source" as a compromise but these are not equivalent - if only one term were to be used "open source" should be replaced with "copyleft" because a non-copyleft-style license does not actually foster collaboration - in its current form this qualifier is a mis-statement and would be better removed entirely because only a subset of the licenses listed on this site suggest that anyone share their improvements or contribute back to the project
secondly - though it is not my main concern - the warnings that were removed should be of great concern to GitHub and users should be aware of this trap that GitHub has laid out - perhaps my assumptions are incorrect (that is why that section was perhaps more verbose than necessary) but the issue seems pretty clear

default copyright does not allow copying
the TOS grants exceptions to the default copyright allowing users to "view" and "fork" on the server only (but not to "copy" locally)
GitHubs place an un-removable "download" button on all public repos regardless of the license or lack thereof
therefore anyone who clicks that button (or clones locally) does so in violation of the TOS

it seems to me that GitHub could avoid this trap by simply adding ".... and download" to the permission granted in section F1 and i dont think many would object
again that was not my main concern but i would be interested to know if the line of reasoning above is accurate - and if so the users should definitely be wary and some warning should remain in this document - an abbreviation would be something like: "... and you are not permitted to download even if the website makes this easy to do"  - this edit is a complete omission of perhaps the most important issue

non-copyleft-style license does not actually foster collaboration

So the collaboration that happens to build many thousands of non-copyleft but open source (which includes copyleft) projects is something other than collaboration, or not fostered by the license?
99% of what a license needs to do to foster collaboration is remove the possibility of collaborators suing each other; that's why open source and free software definitions mandate freedoms; regulations such as copyleft are optional and their different impacts on fostering collaboration subject to evidence, which is lacking.

you are not permitted to download even if the website makes this easy to do

This interpretation is probably not correct and in any case choosealicense.com tries mainly to document express provisions not interpret what is not stated. In any case I'll pass along your feedback about the GitHub TOS.


Image alignment broken after last update (1.2.16)

Apparently now images are aligned out of bounds in my theme (minimal) as well as a quirky animation when I try to use the align feature.
Please make an option so that this can be disabled entirely - it seems to interact with lots of other things regarding the alignment of images.

Hey, it was only one of a few updates which deals with alignment.
Because of how codemirror works, and considering how complicated it is, I needed to temporarily set some generic CSS classes. These will be patched in future updates.
Do you know exactly part is exactly gets broken?
For time being if you dont use crop, batch processing or annotation tools -> just comment out or simply delete whole styles.css
Next patch should be out maybe tonight or tomorrow morning.

Ah I see. So I tried to look into the CSS/HTML but I found that it's too hard to directly make out the difference just from glancing. And my css-kung-fu is not good enough here :)
I will wait for your update, for the time being I have manually reverted to the previous version and will give the next release a try.
Thanks a lot for providing this great tool!

Same here. The plugin is loaded with Lazy Plugins with 'long' setting so one can easily see this plugin makes the modification. I thought this plugin is triggered on demand. Why would it interfere with the CSS?

That is not how plugins work in Obsidian. And I don't recommend Lazy plugin, as it is known to interfere with functionality of certain plugins.
In Obsidian, all plugins load during startup. And then if plugin is optimized, its startup will be delayed (Obsidian team calls it "deffered") until layout change. This improves Obsidian load time drastically.
Only after plugin is loaded, then plugin usually sits in the background listening for various events... like whether you open a new window, open new file, rename, delete file, interact with a note etc. etc. that is why if you have many plugins installed it might also slow down your Obsidian vault.
As for what Image Converter loads after layout-change, you can inspect it in its onload() - most of its functionality  is commented out and I think should be self explanatory.
CSS in Image converter is needed for Resizing, Crop/Annotation tool to work, and now it will be needed for Image Alignment and wrapping.
Because I mainly use vanilla Obsidian, I can't troubleshoot and foresee all incompatibilities with other plugins/themes etc.. thus, if you encounter any issues that Image Converter is breaking, please send me over some screenshot so I could patch it 🙏

with the 1.2.17 update the behaviour is back to expected/prior. It does not break the alignment now for me. Thanks a lot!

Sorry, I am not sure what I am looking at 😅  do you mean the character in the brackets?

How does it supposed to look?

Can it be that the image is smaller than the lines height itself? thus it simply resizes to the top corner as per defaults?
For example, below 10px is much smaller than lines height, and because when using e.g. drag or scroll-wheel  resizing  we go from bottom right to top left - we go all the the to the corner - so it appears as if it is floating.

In one of the versions I set resizing to minimum of 50px~, but considering your use-case I might lower it to 20px~ so then it will reduce confusion, and still appear centered.


esp32c2 uses 26M crystal oscillator, resulting in delay errors

I should configure the crystal frequency in "menuconfig" mode, but I don't know how to do this under "esp-rs"

If using a std project, which seems like you are since you opened this issue in std-training: https://docs.esp-rs.org/book/troubleshooting/espflash.html#if-you-are-building-an-esp-idf-sys-based-project
If using a no_std project, it should be automatically detected.

in sdkconfig.defaults add CONFIG_XTAL_FREQ_26=y，cargo clean cargo run is ok!


Replace Prototype.js with native JavaScript

See JENKINS-70906. Jenkins core currently uses Prototype 1.7, released on November 15, 2010. The latest version is Prototype 1.7.3, released on September 22, 2015. When an attempt was made to upgrade to 1.7.3 in 2018 in JENKINS-49319, the change had to be reverted. Since this library has been unmaintained for the past 8 years, this PR removes any usages of it in favor of native JavaScript APIs. To test this, I installed this plugin on a custom build of Jenkins that had Prototype ripped out (a local project branch), loaded a build in the UI, and verified that there were no exceptions in the browser console log. Before this PR I got a number of exceptions regarding undefined $$ methods and the like.

Note that the maintainers appear to be cherry-picking PRs, as #357 was merged and released before this PR despite this PR being filed first.

We are planning to review all the prototype.js PRs at the same time.


Add Visual Studio 2015 download link to the readme

Hi @gregg-miskelly, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Gregg Miskelly). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

:+1:


product:format

Would it be possible to add "format" in the list of properties (as a string) ?  Could then be used to encode the $.properties.productInformation.format from https://docs.ogc.org/is/17-003r2/17-003r2.html#table_22. Is useful for collections as well.

@ycespb Can you clarify what that field is meant to contain?

Native product format.

The description ir pretty ambiguous. Is that the media type? We have that for assets (type), so not so sure about this.

The actual values used not always match with a media type, or a media type is not precise enough.  Here an example (OGC 10-157r4)  from an ESA GOCE collection (GOCE_Level_2): eop:nativeProductFormatGO-MA-HPF-GS-0110</eop:nativeProductFormat>.


add new option surround_links_with_brackets

this option allows to disable surrounding the link text
with brackets
actually there are only a few lines changed, but my editor formatted the file differently

Hello!
Thank you for your contribution. Unfortunately I won't be able to accept it with all the whitespace changes - I recommend installing something like EditorConfig to fix the whitespace in your editor. Can you install EditorConfig and either (a) force push, so we don't lose history, or (b) create a new MR?
Can you also add some tests, to demonstrate the behaviour when the option is enabled?

Hi there. Dont have much time right now, but hope to find it in the future. Then I will resubmit


jobsub_lite should not assume it is the only provider of decode_token.sh

Originally diagnosed by @hgreenlee.
Microboone ran into an issue (FNAL ServiceNow ticket INC000001153625) whereby if IFDH was set up in a user environment, jobsub_lite might pick up the IFDH version of decode_token.sh, rather than its own.  Indeed, we can see that this is expected behavior in lines like this:
https://github.com/fermitools/jobsub_lite/blob/e105b7095458be58d25f2434e13ea6909cde7805/lib/fake_ifdh.py#L79
Have this module find decode_token.sh in its own bin directory, so we're ensuring that jobsub_lite is using its own decode_token.sh (and thus jobsub_lite would be using a presumably bug-free version).

Closing in favor of #475


Rule proposal: validate PropTypes aren't typos

Rule would check that calls to React.PropTypes.whatever are valid. For instance, I have a bad habit of typing disabled: PropTypes.bools.isRequired instead of disabled: PropTypes.bool.isRequired. I've also done disabled: propTypes.bool.isRequired and disabled: propTypes.bool.isRequired() by accident.

+1, I have the same problem. I also type React.propTypes instead of React.PropTypes,  function instead of func, booleaninstead ofbooland I'm sometimes tempted to typeobjinstead ofobject`.

:+1: I have done this a lot. The abbreviations are inconsistent.
I was presenting on how to write lint rules at my React user group last night, and we live coded a first pass: https://github.com/willklein/scaling-best-practices/commit/901534ba2cdb2f4a1de190e018d4a5bb4b1c9833
Needs more test cases and a few conditions. I'll see if I can get this wrapped up in the next week.

@willklein have you made any progress on wrapping up this rule?

Bumping an old issue with a new case:
class A extends React.Component {
  render() {
    return {this.props.children};
  }
}
A.PropTypes = {
  href: React.PropTypes.string.isRequired,
  children: React.PropTypes.node.isRequired,
}

This code will be linted by react/prop-types as missing prop types for href and children. The subtle problem here is that A.PropTypes = ... should be A.propTypes = ....
Could this rule find and warn/error on a case where prop types are being set in a component property other than propTypes?


執行CUDA_VISIBLE_DEVICES=0 python deep_3drecon/test.py 出現error

error 訊息:
Traceback (most recent call last):
File "/home/GeneFace/deep_3drecon/test.py", line 68, in
main(0, opt, 'deep_3drecon/datasets/examples')
File "/home/GeneFace/deep_3drecon/test.py", line 52, in main
im_tensor, lm_tensor = read_data(im_path[i], lm_path[i], lm3d_std)
File "/home/GeneFace/deep_3drecon/test.py", line 27, in read_data
_, im, lm, _ = align_img(im, lm, lm3d_std)
File "/home/GeneFace/deep_3drecon/util/preprocess.py", line 204, in align_img
trans_params = np.array([w0, h0, s, t[0], t[1]])
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (5,) + inhomogeneous part.
請問一下，這個問題該如何處理呢? 是我那個步驟有出錯嗎?  謝謝~

後來我發現把出錯那行裡面所提的那5個變數，全部轉型成為int資料型態就可以了，已解決!

@jerry4308 How did you resolve it, can you please explain

w0, h0, s, t[0], t[1]
I remember I just changed the type of the above variables as the same type.
^^

请问是在哪一步转换的呢，为什么我直接转换了还是报这个错？

try this code
trans_params = np.array([w0, h0, s, t[0][0], t[1][0]])

好的，谢谢~

Why this bug author has not fixed so far

try this code
trans_params = np.array([w0, h0, s, t[0][0], t[1][0]])

YES,this method works very well.


search with inline comments are treated like macros

If you have triple back-tick inline comments in your search contentctl tries to parse it as a macro and throws an error.

this is from 3.6.0, testing 4.0.3 now to confirm if its still an issue


Default Codes missing off gender items

Maxine has asked "has the default code on person stated gender code been removed? Can't see it on the website"
I have checked both websites and the default codes are missing for version V+ form the gender items below. I am not sure if there are any other default codes missing. Can something be run to check?
PERSON STATED GENDER CODE
https://v3.datadictionary.nhs.uk/data_dictionary/data_field_notes/p/pers/person_stated_gender_code_de.asp?shownav=1
https://datadictionary.nhs.uk/data_elements/person_stated_gender_code.html
PERSON STATED GENDER CODE (NATIONAL JOINT REGISTRY)
https://v3.datadictionary.nhs.uk/data_dictionary/data_field_notes/p/pers/person_stated_gender_code_(national_joint_registry)_de.asp?shownav=1
https://datadictionary.nhs.uk/data_elements/person_stated_gender_code__national_joint_registry_.html
PERSON STATED SEXUAL ORIENTATION CODE
https://v3.datadictionary.nhs.uk/data_dictionary/data_field_notes/p/pers/person_stated_sexual_orientation_code_de.asp?shownav=1
https://datadictionary.nhs.uk/data_elements/person_stated_sexual_orientation_code.html
PERSON STATED SEXUAL ORIENTATION CODE (AT DIAGNOSIS)
https://v3.datadictionary.nhs.uk/data_dictionary/data_field_notes/p/pers/person_stated_sexual_orientation_code_de.asp?shownav=1
https://datadictionary.nhs.uk/data_elements/person_stated_sexual_orientation_code__at_diagnosis_.html

James thinks he has fixed this.
I am running the new Dita file through Oxygen.

Items fixed: new version added to the website today.


Trigger feed Update and Locking Creation/Deletion of OpenWhisk entities

Closes #480
Closes #574

@mrutkows
After getting rid of concurrency measurement, wskdeploy fails with:
--- FAIL: TestPackageInManifest (4.28s)
	Error Trace:	validate-package-in-manifest_test.go:32
	Error:      	Not equal:
	            	expected: <nil>(<nil>)
	            	actual: *utils.TestCaseError(&utils.TestCaseError{errorMessage:"Error: /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/manifestreader.go [101]: Invalid input of Yaml format =====> /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/manifestreader.go [146]: Invalid input of Yaml format =====> open /home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/Packages/myhelloworlds.master.zip: no such file or directory\n\n"})

I think we should introduce a timestamp under like /Packages/<timestamp>/ to avoid accessing the same dependent package or package name like /Packages/<dependent-package-name>/

One more failure:
==> Executing: wskdeploy undeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-packages-in-manifest/manifest.yaml -d /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-packages-in-manifest/deployment.yaml
==> Error: Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go [883]: OpenWhisk Client Error =====> The requested resource does not exist. (code 37488170) Error code: 148.

.
--- FAIL: TestPackagesInManifest (8.34s)
        Error Trace:    validate-packages-in-manifest_test.go:32
        Error:          Not equal:
                        expected: <nil>(<nil>)
                        actual: *utils.TestCaseError(&utils.TestCaseError{errorMessage:"Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go [636]: OpenWhisk Client Error =====> The requested resource does not exist. (code 37487742) Error code: 148.\n\n"})
        Messages:       Failed to deploy based on the manifest and deployment files.
        Error Trace:    validate-packages-in-manifest_test.go:34
        Error:          Not equal:
                        expected: <nil>(<nil>)
                        actual: *utils.TestCaseError(&utils.TestCaseError{errorMessage:"Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go [883]: OpenWhisk Client Error =====> The requested resource does not exist. (code 37488170) Error code: 148.\n\n"})
        Messages:       Failed to undeploy based on the manifest and deployment files.
FAIL

more (deletePackage):
==> Executing: wskdeploy undeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validateSequencesCreation/sequence_test_mani_563555208 -d /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validateSequencesCreation/sequence_test_deply_032817479
==> Output: WARNING: using package inside of manifest file will soon be deprecated, please use packages instead.
.
==> Error: Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go [867]: OpenWhisk Client Error =====> Package not empty (contains 2 entities) (code 37524740) Error code: 153.

Failure at createAction:
==> Executing: wskdeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-packages-in-manifest/manifest.yaml -d /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-packages-in-manifest/deployment.yaml
==> Output: WARNING: using package inside of manifest file will soon be deprecated, please use packages instead.
WARNING: using package inside of manifest file will soon be deprecated, please use packages instead.
WARNING: using package inside of manifest file will soon be deprecated, please use packages instead.
WARNING: using package inside of manifest file will soon be deprecated, please use packages instead.
.
==> Error: Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go [636]: OpenWhisk Client Error =====> Sequence component does not exist. (code 37536134) Error code: 144.

==> Executing: wskdeploy undeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-packages-in-manifest/manifest.yaml -d /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/validate-packages-in-manifest/deployment.yaml
==> Error: Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go [889]: OpenWhisk Client Error =====> The requested resource does not exist. (code 37549490) Error code: 148.

.
--- FAIL: TestPackagesInManifest (2.99s)
        Error Trace:    validate-packages-in-manifest_test.go:32
        Error:          Not equal:
                        expected: <nil>(<nil>)
                        actual: *utils.TestCaseError(&utils.TestCaseError{errorMessage:"Error: /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/manifestreader.go [101]: Invalid input of Yaml format =====> /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/manifestreader.go [146]: Invalid input of Yaml format =====> open /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/Packages/hellowhisk.master.zip: no such file or directory\n\n\n"})

I am wondering why suddenly so many concurrency issues ...

@mrutkows there aren't any more changes left in this PR now except fixing issue #574, I have created separate PR for that, closing this one.

@pritidesai  thanks!


Fix #3222: Emit a .sjsir for anon JS functions in 2.11/-Xexperimental.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4429/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/5977/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4432/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/5980/
Test PASSed.


Add sent from/to account titling to transaction items

Description
When you send tokens from WalletA to WalletB (both belong to the same account)
firefly should recognize the name of your wallet and posting the name in the transaction history.
Now in the transaction history the adress is posted.
E.g.: atoi1qrd5f6zjlj64tj8hxj4nt5keayuezzwetlmyzt0hz7pjt2qq7uahc3as4ms sent 10 MIOTA to atoi1qqjvpyuv2xyqgusezg04p9ydund39gxfdjyg9sw5ac5qmqk9d6kzswpakex
But its a better user experience if the firefly wallet would write the name of the wallet instead of the adress like:
Sparemoney sent 10 MIOTA to Holidaywallet
Motivation
Better user experience and easier to understand the transaction history

Hey @ForrestPamp, iiuc this change has been made, so I am going to close this issue. Thank you for the suggestion! 👍


data-tablesaw-priority="persist"

Could it be that the data-tablesaw-priority="persist" is broken?
I'm trying to use it in the last column, but what it does is it hides the column when the browser gets smaller.

have same issue, but https://codepen.io/joranovski/pen/NqoBKN?editors=1000 works fine (v1.0.4)

workaround(sass)
.tablesaw-swipe
  .tablesaw-swipe-cellpersist
    display: table-cell !important


Skip properties that are functions

Thanks for the great library!
I was running into this error:
/Users/Kyle/Documents/www/base-element/node_modules/vdom-to-html/create-attribute.js:26
    name = (attributeNames[name] || name).toLowerCase();
                                          ^
TypeError: (attributeNames[name] || name).toLowerCase is not a function
    at createAttribute (/Users/Kyle/Documents/www/base-element/node_modules/vdom-to-html/create-attribute.js:26:43)
    at openTag (/Users/Kyle/Documents/www/base-element/node_modules/vdom-to-html/index.js:69:16)
    at toHTML (/Users/Kyle/Documents/www/base-element/node_modules/vdom-to-html/index.js:27:12)
    at BaseElement.toString (/Users/Kyle/Documents/www/base-element/index.js:55:10)
    at index (/Users/Kyle/Documents/www/base-element/examples/server-side.js:30:19)
    at Server.<anonymous> (/Users/Kyle/Documents/www/base-element/examples/server-side.js:10:5)
    at emitTwo (events.js:87:13)
    at Server.emit (events.js:172:7)
    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:474:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)

Which is because I define my elements just using prototypes and pass down h('div', elementInstance, 'text'). All works fine until a function is defined, in this case toString() on my element.
I think it should instead just skip any properties that are functions. Thanks!

looks good, +1

Why are you defining functions as virtual-dom properties instead of using hooks?

@bitinn
I use plain JS prototypes to compose elements like this example:
function Element () {
  this.className = 'my-element'
  this.style = {}
}
Element.prototype.render = function (children) {
  return h('div', this, children)
}
Element.prototype.hide = function () {
  this.style['display'] = 'none'
}

Which all works fine until trying to serialize with this lib. Previously I was just using require('min-document/serialize') and am looking to switch to a module geared specifically for this: https://github.com/shama/base-element/commit/128c8862d23876358aab9c6dfef459673bcb6b9f
Thanks!

@shama I think it would be a good idea to avoid passing the general this, but instead use an plain object like this.properties, and provide setter/getter on your Element if necessary.
The way virtual-dom check for special hooks and widgets can be hacky, if you don't follow its VNode documentation and you may run into issues in future, see https://github.com/Matt-Esch/virtual-dom/tree/master/vnode for some examples on how they check for special properties.
While you PR will certainly help in your case, it would be a lot more reliable to take control in your own hands and avoid passing functions as properties because they are really intended for hooks and widgets, you won't know if virtual-dom owner will suddenly decide to add some more special properties that break your code.
see https://github.com/Matt-Esch/virtual-dom/tree/master/docs for VNode, Hook and Widget.

In any case toString is not a valid property. This issue can be also fixed by using hasOwnProperty here instead of just checking if it's truthy.

This should be fixed in 2.1.1. Let me know if you have any other issues!

Thank you for the advice @bitinn! and thanks for the fix @nthtran! :)

Coverage remained the same at 100.0% when pulling 5894b0e3e2b478838ee0b5dc26053443fc379881 on shama:skip-function-attr into 0895bcc2118cc998e7dbad0482337d2ee0de3d71 on nthtran:master.

Coverage remained the same at 100.0% when pulling 5894b0e3e2b478838ee0b5dc26053443fc379881 on shama:skip-function-attr into 0895bcc2118cc998e7dbad0482337d2ee0de3d71 on nthtran:master.


[BUG] Building Failed Then Success?

Describe the bug
Every time i download the latest version then i build in visual studio i get some errors :(,
BUT! after closing vs, then waiting some minutes, then retrying it successfully builds.
To Reproduce
Steps to reproduce the behavior:

Clone openbullet
Open OpenBullet.sln
Change to release version.
Build the solution.

Expected behavior
No errors, Just build.
Error Screenshot

Success Screenshot

Version
Latest, After this commit: https://github.com/openbullet/openbullet/commit/abdc7e4e1024728f498133f02a7ca1acdf0ff17b
Additional Information
I do have .NET framework (dev) 4.6.1 installed!

u scrape files from link or download file ?

u scrape files from link or download file ?

I use git clone https://github.com/openbullet/openbullet.git

maybe i can solve ur problem add me on discord Teals53#1508

Teals53#1508

hmm, i actually prefer here. cuz i don't talk about this stuff on discord.

The chmod error is solved after switching to the other build type (Release or Debug, the one you don't have selected). Also I STRONGLY suggest to not do git clone each time but rather simply do git pull when there is a new version (close VS before doing it). So solving the problem once will suffice for any further build.

lol

The chmod error is solved after switching to the other build type (Release or Debug, the one you don't have selected). Also I STRONGLY suggest to not do git clone each time but rather simply do git pull when there is a new version (close VS before doing it). So solving the problem once will suffice for any further build.

ofc i selected release mode.

here is a video
https://streamable.com/kqozq


Export the current Polymer version in polymer-element.js

Potential solution for exposing the Polymer version in polymer-element.js. Not sure if this is the desired solution, but it seemed like the best option we have.
Reference Issue
Fixes #5211

@kevinpschaaf This is ready for review again


Improved robustness of aliquot equivalence check

The previous version of the check compared hard-coded
attributes when checking equivalence. This resulted in
newer columns, such as primer_panel_id getting missed
from the check.
To avoid the need to remember that this method needs to
be updated when extending Aliquot, the columns to compare
are now generated dynamically from the database columns.
Columns which are permitted to change are now whitelisted.
This should substantially reduce the risk of future bugs
being introduced, and will ensure that the comparison
remains conservative, rather than permissive.
Closes #
Changes proposed in this pull request:

...

Relates with: https://github.com/sanger/limber/issues/410


Updated VM restart text

Add RCA context
Add Diagnose and Solve content

@zjalexander : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@genlin please review , this is a small change.


CiviForm Admin UX: Change "Edit" to "Add" on the TI tab

Is your feature request related to a problem? Please describe.
When a CiviForm adds a TI on the TI tab, the user's action (to add) does not match the button's name that allows them to perform that action.
Describe the solution you'd like
Change "Edit" to "Add" on the TI tab
Additional context

@cassandralfernandes Add looks confusing here. Is it "Add members"? maybe something a bit more descriptive?

Looking at this again, the edit button actually takes you to a place where you can add or delete members. So let's label the button "Edit members" (not add). The delete button next to edit is confusing, because that deletes the whole group. I suggest we add the word group there so it says "Delete group". WDYT?


Vision: Allow users to limit weight spent in categories of calls

FRAME is mostly centered around purpose-built chains, where all pallets or calls a runtime exposes have equal priority, in the sense that a chain's blockspace is allocated to all its pallets with equal priority.
As chains evolve, they may choose to allocate more or less weight to specific pallets or bundles of Calls. The easiest example of this would be chains that expose some specialized functionality, but wish to enable smart contracts as well. Such a chain might want to allow smart contract calls for both pallet-contract or some pallet-evm, but only cumulatively up to e.g. 20% of the block's Weight.
The node-side code looks to already accommodate this use-case with TransactionValidityError::Future, but we need an easy way to plug into pallet-transaction-payment or some other entry point to return this.

Sounds like this https://github.com/paritytech/substrate/issues/11309
DispatchClass already allow reserve x% of block space for operational transaction.

@xlc Nice, I missed #11309 - looks like it was closed, but wondering if you think this is worth keeping open to make it simpler

AFAIK #11309 doesn't fully cover this use-case, as I understand that DispatchClass is set by the pallet author, whereas I would want transactions to be categorizable by the runtime builder.

A meta comment that comes to mind about this is that we have really mis-worded the term DispatchClass. It makes little sense that something like on_initialize registers some weight with dispatch class mandatory.
While doing this, we should consider:

renaming this whole thing to WeightClass
make WeightClass extensible, such that arbitrary classes can be defined and used.

This might actually make the migration easier. We can leave the existing DispatchClass as-is and mark it as deprecated.


Missing items in some feeds

For instance Cyanide and happiness
http://pipes.yahoo.com/pipes/pipe.run?_id=9b91d1900e14d1caff163aa6fa1b24bd&_render=rss
My Recipe for this is:
"explosm.net": {
    "type": "xpath",
    "xpath": "img[@id='main-comic']",
    "force_charset": "utf-8"
}

This works nicely until commit 7728e91. After that the article is empty.

I wonder this worked ever before. Because feediron used getInnerHtml since the beginning.
But this should work for you:
"explosm.net": {
    "type": "xpath",
    "xpath"<EMAIL_ADDRESS>    "force_charset": "utf-8"
}

This works for me. Thanks!


Reference in referenced parameter is resolved in wrong file

What are the steps to reproduce this issue?
spec.yaml
openapi: 3.0.2
info: {}
paths:
  "/path":
    get:
      parameters:
        - $ref: "refs.yaml#/components/parameters/switch"
      responses:
        '200':
          content:
            application/json:
              schema:
                type: string

refs.yaml
components:
  schemas:
    Switch:
      type: string
      enum:
        - on
        - off
  parameters:
    switch:
      name: switch
      in: query
      schema:
        $ref: "#/components/schemas/Switch"

What happens?
Orval fails.
What were you expecting to happen?
Orval completes without errors.
Any logs, error output, etc?
🛑  backend - Oups... 🍻. Ref not found: #/components/schemas/Switch

Any other comments?
When I added another Switch schema to spec.yaml code was generated but the parameter from refs.yaml was used.
What versions are you using?
Package Version: 6.7.1

Same issue here.
So far I have tried:

Pointing the $ref to a a relative path in the project root using ./spec.json
Pointing the $ref to a a relative path in the project root using spec.json (no leading period)
Pointing the $ref to a relative path in a nested directory
Pointing the $ref to an absolute path, e.g. /Users/me/something.../spec.json
Pointing the $ref to an external web URL, e.g. https://something.../spec.yaml
Using a spec in yaml format
Using a spec in JSON format
Using a $ref with a $1 instead of / for the nested ref, e.g. spec.yaml#/components$1/schemas/Geometry
Using a $ref with / characters intact
Pointing to a $ref in the same folder as my transformer
Pointing to a $ref in a different folder

If it helps, here is my config:
// eslint-disable-next-line import/no-extraneous-dependencies
import { defineConfig } from 'orval'

import transformer from './src/lib/api/django/overrides.django'

export default defineConfig({
  'django-backend': {
    input: {
      target: './scratch/portal-api.json',
      converterOptions: true,
      override: { transformer },
    },
    output: {
      client: 'react-query',
      mock: false, // TODO
      mode: 'tags-split',
      schemas: 'src/lib/api/django/model',
      target: 'src/lib/api/django/types.django-api.ts',
      prettier: true,
      override: {
        mutator: {
          path: 'src/lib/api/django-axios-instance.ts',
          name: 'djangoAxiosInstance',
        },
      },
    },
  },
})

And my transformer:
// eslint-disable-next-line import/no-extraneous-dependencies
import { OpenAPIObject, SchemaObject } from 'openapi3-ts'

function transformer(inputSchema: OpenAPIObject): OpenAPIObject {
  const { components } = inputSchema
  const { schemas } = components || {}
  const { Field } = schemas || ({ properties: {} } as SchemaObject)

  return {
    ...inputSchema,
    components: {
      ...inputSchema.components,
      schemas: {
        ...schemas,
        Field: {
          ...Field,
          properties: {
            ...Field.properties,
            geometry: {
              oneOf: [
                // None of these work 😞
                { $ref: 'geojson-spec.yaml#/components~1schemas~1Point' },
                { $ref: 'geojson-spec.yaml#/components~1schemas~1LineString' },
                { $ref: 'geojson-spec.yaml#/components~1schemas~1Polygon' },
                { $ref: 'geojson-spec.yaml#/components~1schemas~1MultiPoint' },
                { $ref: 'geojson-spec.yaml#/components~1schemas~1MultiLineString' },
                { $ref: 'geojson-spec.yaml#/components~1schemas~1MultiPolygon' },
              ],
            },
          },
        },
      },
    },
  }
}

export default transformer

It works if I hard-code the refs:
...into the other file ('./scratch/portal-api.json' in my config above) using the oneOf syntax.
Hardcoding isn't a realistic option, of course, I just wanted to point out that orval works except for using refs in the transformer (other overrides worked fine).
I don't know enough about the source code for a PR, but I love this repo and appreciate the work so I'd be happy to troubleshoot/answer questions! Maybe it will alleviate some of the other issues that pop up in a "ref not found" search.

As workaround for this you might add redocly bundle spec.yaml --ext json -o spec.json and input is the spec.json file.
Orval doesn't have a hook like beforeReadSpecs but you could add a scripts command like "generate-api-clients": "redocly bundle spec.yaml --ext json -o spec.json && orval --config orval.config.ts"


If there already exists a filename in the folder, the program crashes.

If you have a filename "download.jpeg" in the jpeg folder and you run the program again to add another download.jpeg in the jpeg folder, the program will crash.

Thanks for the information. I will look into it.

But could you please send some screenshots.

I hope this helps

Ok. I know what to do now. It will have to be handled by the system to where it will automatically make increments of the same name. Such as follows:
If one file is already in the downloads folder of this name:
download.jpeg
And then you run it again with a file in the downloads directory you will get:
download_1.jpeg or download(1).jpeg
I will add this as another thing todo.
Thanks @thearnavgarg


Question - ODE State at time of event

Hello Martin,
I have a question concerning the detection of events.
I see that to detect events I need to provide a closure that has a zero crossing at the event and then I need to use the return value of OdeSolverMethod::step to check if an event has been detected.
In the documentation for OdeSolverStopReason it states:
RootFound(t_root): The solver has found a root at time t_root. Note that the internal state of the solver is at the internal time step self.state().t, not at time t_root.
In my case I would like to know both t_root and also the state at time t=t_root. Is there an easy way to obtain this information?
I would then restart/continue the integration from the event onwards.
I am sorry if this has an obvious answer, but I am new to the Rust programming language and it is not immediately obvious to me.
Thanks,
James Housden

Hi @JEMH, you can use OdeSolverMethod::interpolate to get the state vector at the time of the event (i.e. t_root), then you would have to mutate the state (using OdeSolverMethod::state_mut) and set it to the interpolated state.
Perhaps something like this (I havn't tried compiling/running this!)
let t = loop {
    match solver.step() {
        Ok(OdeSolverStopReason::InternalTimestep) => continue,
        Ok(OdeSolverStopReason::TstopReached) => panic!("We didn't set a stop time"),
        Ok(OdeSolverStopReason::RootFound(t)) => break t,
        Err(e) => panic!("Solver failed to converge: {}", e),
    }
};
println!("Root found at t = {}", t);
let new_state = solver.interpolate(t).unwrap();
solver.state_mut().unwrap().copy_from(&new_state);
solver.step();

Note that this is inefficient for some solvers (the BDF one) as it needs to be re-initialised after the call to state_mut, so if your event is time-based then its preferable to use OdeSolverMethod::set_stop_time (or you could try using the SDIRK solver which is fine with restarting)

note I've just put together some docs on this: https://martinjrobins.github.io/diffsol/solving_the_problem.html


Can't start visualization on MacOS with Loopback

System:
MacOs Big Sur
NodeMCU v3
Led-strip WS2812
Loopback
Hey there, trying to use your library but when i trying to start python3 python/visualization.py i get following error and GUI doesn't starts:

on screenshot command is python3 python/visualization.py but i getting same error with python3 python/visualization.py /tmp
seems that your lib can't find Virtual Audio Input of Loopback (i were getting same error when just installed all python dependencies and tried to run python3 python/visualization.py without Loopback setup). Didn't found any issues like mine, any advice please.

I had a similar issue, something to do with Big Sur.
Run these:
brew uninstall portaudio
brew install portaudio --HEAD
Should fix it

@osbash yeah, reinstalling portaudio helped


feat: Improve biome config

use schema from node_modules - makes biome schema, by definition, always be in sync with installed biome version
use .jsonc to support comments
standardize to single quotes for JSX as well
only run checks against files changed relative to main branch
inherit ignored files from .gitignore
upgrade usage of soon-to-be deprecated --fix command

use schema from node_modules - makes biome schema, by definition, always be in sync with installed biome version
use .jsonc to support comments
standardize to single quotes for JSX as well
only run checks against files changed relative to main branch
inherit ignored files from .gitignore
upgrade usage of soon-to-be deprecated --fix command

Nice, this is great!


Steps for post-compilation?

What feature or improvement do you think would benefit Files?
I managed to get all the tools installed needed to compile Files on my own but I'm not sure what steps are next? I see an *.exe that upon launch does nothing.   Can you please explain how I go from the output files to an *msix installable package for my PC?
Requirements

This proposal will accomplish encouraging other people/would be developers to contribute to your project

Files Version
3.0.8
Windows Version
19045.3693
Comments
No response

You don't get an install package for it. You go to Debug > Start debugging or press F5

So that is the only way to launch the application once built?  There's nothing I can do with the files.exe to get it to execute?

No, dev builds aren't meant to be used as a normal install there for testing your changes.


Poof state loses last alive frame

introduced in #142

Previous animation implementation was capturing texture of last alive state.
So if entity was shot in running pose it was squashing in this position.
So there's no sudden graphical switch to idle texture.


Add option 'initialIndex'

This allows the user to specify an initial slide that should display when lory is first initialized.
Please ignore the files in dist, since they're generated with a build command.

CR 👍

Should we open a pull on the parent repo too?

I did! :) https://github.com/meandmax/lory/pull/630

CR 👍


Make install and update command more consistent

Fix typo in package name Dotnet-aspnet-codegenerator
Use -g instead of --global to be consistent with update command

Thanks!


broken links to source in docs

Some links from function documentation in the API reference to the function definition in the source code are broken.  For example, on this page: https://mne-tools.github.io/dev/generated/mne.stats.spatio_temporal_cluster_1samp_test.html
the link text [source] to the right of the function signature links to http://github.com/mne-tools/mne-python/blob/master/doc/%3Cstring%3E#L1210-L1339 (note the <string> near the end of the URL)
Also occurs for spatio_temporal_cluster_test, permutation_t_test, permutation_cluster_1samp_test (but is not a sitewide problem --- it works fine for e.g., fdr_correction; maybe it's only broken for functions in cluster_level.py?)

It will be broken for anything that uses the verbose decorator. We need to make the linking function smarter


Argument with task

Love the lib, even though it is a bit hard for me to follow some of the examples (so many callbacks).
In any case, I was wondering if there was a way to pass an argument with a task:
e.g.
Task tUpdateRtc(1UL * 60UL * 1000UL, TASK_FOREVER, &updateRtc(true), &hpr); // every 1 minute

No easy way to do it with Dynamic Tasks calling static callback methods.
You can use Local Task Storage pointer for this.
Wiki: here
Example: here


As a software developer of scientific software, I need a native Haskell implementation of the daxpy function so that I can linearly combine two vectors in a type-safe, thread safe manner.

Documentation for the daxpy function can be found at BLAS.

[x] create native implementation of function
[x] create haddock documentation of function
[x] create unit test to demonstrate byte equivalence to FORTRAN BLAS library function
[x] create benchmark(s) to quantify time performance relative to FORTRAN BLAS library function
[ ] demonstrate that native has a relative time performance of no more than 100x the FORTRAN blas function.

Implementation Strategy:

This function can be implemented easily by polymorphising the single precision version.

Attached is the raw benchmark data:
daxpy.zip

DAXPY BENCHMARK ANALYSIS
Special Case inc=1
When the increment of traversal is equal to unity, the time performance of both the unsafe and pure implementations are well described by a linear model:
PURE
lm(formula = PURE ~ N, data = dat[dat$INC == 1, ])

Residuals:
     Min       1Q   Median       3Q      Max
-0.60543 -0.07155  0.06697  0.07570  0.65397

Coefficients:
             Estimate Std. Error t value Pr(>|t|)
(Intercept) 2.421e-02  4.186e-02   0.578    0.566
N           5.804e-03  6.362e-06 912.236   <2e-16 ***
---
Signif. codes:  0 ‘***’ 0.001 ‘**’ 0.01 ‘*’ 0.05 ‘.’ 0.1 ‘ ’ 1

Residual standard error: 0.2362 on 37 degrees of freedom
Multiple R-squared:      1,	Adjusted R-squared:      1
F-statistic: 8.322e+05 on 1 and 37 DF,  p-value: < 2.2e-16

UNSAFE
lm(formula = UNSAFE ~ N, data = dat[dat$INC == 1, ])

Residuals:
    Min      1Q  Median      3Q     Max
-1.1030 -0.1527  0.2170  0.2522  0.9794

Coefficients:
              Estimate Std. Error t value Pr(>|t|)
(Intercept) -1.839e-01  8.380e-02  -2.194   0.0346 *
N            1.101e-03  1.274e-05  86.476   <2e-16 ***
---
Signif. codes:  0 ‘***’ 0.001 ‘**’ 0.01 ‘*’ 0.05 ‘.’ 0.1 ‘ ’ 1

Residual standard error: 0.4728 on 37 degrees of freedom
Multiple R-squared:  0.9951,	Adjusted R-squared:  0.9949
F-statistic:  7478 on 1 and 37 DF,  p-value: < 2.2e-16

ASYMPTOTIC PERFORMANCE
In the limit as n becomes very large, the relative time performance should approach:
5.804e-03
--------- = 5.2x
1.101e-03

which is within the 100x performance threshold for this project milestone
Special Case inc/=1
When the increment of traversal is not equal to unity, the time performance of both the unsafe and pure implementations are well described by a multi-linear model:
PURE
lm(formula = PURE ~ N + Z, data = dat[dat$INC != 1, ])

Residuals:
    Min      1Q  Median      3Q     Max
-0.8875 -0.2509  0.1208  0.2933  0.8693

Coefficients:
              Estimate Std. Error t value Pr(>|t|)
(Intercept) -1.690e-01  6.475e-02   -2.61    0.012 *
N            1.513e-02  1.511e-04  100.15   <2e-16 ***
Z            7.696e-04  1.155e-05   66.66   <2e-16 ***
---
Signif. codes:  0 ‘***’ 0.001 ‘**’ 0.01 ‘*’ 0.05 ‘.’ 0.1 ‘ ’ 1

Residual standard error: 0.3936 on 48 degrees of freedom
Multiple R-squared:  0.999,	Adjusted R-squared:  0.999
F-statistic: 2.519e+04 on 2 and 48 DF,  p-value: < 2.2e-16

UNSAFE
lm(formula = UNSAFE ~ N + Z, data = dat[dat$INC != 1, ])

Residuals:
    Min      1Q  Median      3Q     Max
-1.3590 -0.1767  0.1472  0.2908  1.1798

Coefficients:
              Estimate Std. Error t value Pr(>|t|)
(Intercept) -2.535e-01  8.256e-02  -3.071  0.00351 **
N            5.493e-03  1.926e-04  28.518  < 2e-16 ***
Z            4.533e-04  1.472e-05  30.792  < 2e-16 ***
---
Signif. codes:  0 ‘***’ 0.001 ‘**’ 0.01 ‘*’ 0.05 ‘.’ 0.1 ‘ ’ 1

Residual standard error: 0.5018 on 48 degrees of freedom
Multiple R-squared:  0.9925,	Adjusted R-squared:  0.9922
F-statistic:  3165 on 2 and 48 DF,  p-value: < 2.2e-16

ASYMPTOTIC PERFORMANCE
In the limit as both n and inc become very large, the relative time performance should approach:
7.696e-04
--------- = 1.7x
4.533e-04

which is within the 100x performance threshold for this project milestone.

Closed as DONE after approval of pull request #80.


Change visibility of private member variables to protected in Forms renderers

For people who would want to extend the Xamarin.Forms renderers with more of their own stuff, it would be really helpful if the member vars were protected, so they are accessible without having to use reflection.
Would you accept a PR marking them protected?

yeah i don't see why that would be a problem


Documentation: What to use for resultsTableName for DbDiagnostics executeDbDiagnostics?

I'm running DbDiagnostics base on the instructions at https://ohdsi.github.io/DbDiagnostics/index.html and the guide for creating the dataDiagnosticsSettingList at https://ohdsi.github.io/DbDiagnostics/articles/DataDiagnosticsSettings.html.  For the "Run the executeDbDiagnostics" script, I'm not sure what to use for resultsTableName.  What table needs to be specified for this?
    dbDiagnosticResults <- DbDiagnostics::executeDbDiagnostics(
      connectionDetails = dbProfileConnectionDetails,
      resultsDatabaseSchema = "demo_cdm_ach_res",
      resultsTableName = "",
      outputFolder = outputFolder,
      dataDiagnosticsSettingsList = settingsList
    )

(Question posted to the forum here: https://forums.ohdsi.org/t/what-to-use-for-resultstablename-for-dbdiagnostics-executedbdiagnostics/19579)

Hi @NACHC-CAD that resultsTableName should be the table where you uploaded your dbProfile results.


v. 2.1.0 throws 'Could not get frontmost application' error all the time

With version 2.1.0 of the workflow, summoning the workflow always results in the message 'Could not get frontmost application' being displayed. Prior versions did not have this issue for me.
I tried looking at the workflow's log, which did not contain any Interesting Info. So here's the log for All Information upon summoning the workflow:
Starting debug for 'AppScripts'

[STDERR: alfred.workflow.input.scriptfilter] 13:05:18 workflow.py:2140 DEBUG    Workflow version : 2.1.0
13:05:18 workflow.py:1543 DEBUG    Reading settings from `/Users/<myusername>/Library/Application Support/Alfred 2/Workflow Data/net.deanishe.alfred-appscripts/settings.json` ...
13:05:18 workflow.py:2401 DEBUG    Update check not due
13:05:18 appscripts.py:117 DEBUG    args : {u'--debug': False,
 u'--help': False,
 u'--quiet': False,
 u'--verbose': False,
 u'--version': False,
 u'<key>': None,
 u'<query>': u'',
 u'config': False,
 u'search': True,
 u'toggle': False,
 u'userpaths': False}
13:05:18 workflow.py:1778 DEBUG    Loading cached data from : /Users/<myusername>/Library/Caches/com.runningwithcrayons.Alfred-2/Workflow Data/net.deanishe.alfred-appscripts/__workflow_update_status.cpickle
13:05:18 workflow.py:2349 DEBUG    update_data : {u'available': False}
13:05:19 appscripts.py:344 ERROR    AppleScript error : dyld: Library not loaded: @rpath/libswiftAppKit.dylib
  Referenced from: /Users/<myusername>/Dropbox/Alfred/Alfred.alfredpreferences/workflows/user.workflow.A0303EFC-4372-4D2B-93D9-81BCF6BF968D/ActiveApp
  Reason: image not found
13:05:19 workflow.py:2331 DEBUG    Set last run version : 2.1.0
13:05:19 workflow.py:2176 DEBUG    Workflow finished in 0.232 seconds.
[INFO: alfred.workflow.input.scriptfilter] <?xml version="1.0" encoding="utf-8"?>
<items><item valid="no"><title>Could not get frontmost application.</title><subtitle /><icon>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/AlertStopIcon.icns</icon></item></items>

I'm using Alfred 2 v2.8.1 (425) on Mac OS X 10.10.5 (14F1021).

I can't replicate the issue. I've tried to fix it in v2.2.
Could you install that version and let me know if it's working again? If not, I'll revert it to the old method.

The issue I'm experiencing is fixed in v2.2. Thanks.


Add code coverage

Currently, PR requests seem to fail due to a missing codecov.io key:
Please provide an upload token from codecov.io with valid arguments

Since that's free for open-source projects, and because seeing code coverage on a project like this is probably a good idea, we should add one :)

PS: It seems this can only be added by main contributers.


voice Cloning RU

Hi! there are models based on HuBert, but for the Russian language, I'm not sure that this is what is needed, but if so, then it would be good to add them.
https://cloud.ru/ru/datahub/rugpt3family/rubert-base
https://habr.com/ru/companies/sberbank/articles/567776/

It seems to have a different format, there also needs to be a model that translates the tokens for use by Bark, perhaps gitmylo who made the HuBert based voice cloning used in this project can weigh in on it: https://github.com/gitmylo/bark-voice-cloning-HuBERT-quantizer/issues


Character limit on branches

Kubernetes imposes a 63 character limit on namespaces, therefore branch names cannot be more than 55 characters due to the prefix of dirtviz- to the namespace

Possible fix is to use git with pre-* to give warning if this is the case
https://medium.com/leantaas-engineering/why-are-we-limiting-git-branch-name-length-to-28-characters-c49cb5f4ff9a

I also found out that periods (.) are not accepts as part of characters. The following is the error from the action
The Namespace "***-66-update-sqlalchemy-to-2.x" is invalid: metadata.name: Invalid value: "***-66-update-sqlalchemy-to-2.x": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')