Feature/zip api

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'll just write this here to keep track of it:

[ ] Filter for file extensions on the API endpoint to simplify logic for the front end
[ ] Add support to use archive/extract as an operation (used in templates)

I am pretty open to most changes at this point, anything else you'd like to add?

Ends up being that the library already filters extensions for us
https://github.com/mholt/archiver/blob/074da64920d3c1188f608a92eceb61e83b31317b/archiver.go#L438

Not totally sure how the frontend is made aware of operations but other than that this is good to go

Needs to be rebased, since the go.mod changed in master with the other PR

@LordRalex should be safe to merge now


Touching a file in src/test/resources triggers test:fastOptJS

If I touch a file in src/test/resources, it causes a rebuild of my test JS and taking about 5 seconds.
webapp-client> last test:fastOptJS
[info] Fast optimizing .../target/scala-2.11/webapp-client-test-fastopt.js
[debug] Linker: Read info: 25703 us
[debug] Linker: Compute reachability: 475989 us
[debug] Linker: Assemble LinkedClasses: 859315 us
[debug] Linker: cache stats: reused: 15325 -- invalidated: 0 -- trees read: 0
[debug] Linker: 1367511 us
[debug] Inc. optimizer: Batch mode: false
[debug] Inc. optimizer: Incremental part: 18493 us
[debug] Inc. optimizer: Optimizing 0 methods.
[debug] Inc. optimizer: Optimizer part: 50 us
[debug] Inc. optimizer: 32347 us
[debug] Refiner: Compute reachability: 364890 us
[debug] Refiner: Assemble LinkedClasses: 19782 us
[debug] Refiner: 384803 us
[debug] Emitter: Class tree cache stats: reused: 4193 -- invalidated: 0
[debug] Emitter: Method tree cache stats: resued: 20894 -- invalidated: 0
[debug] Emitter (write output): 278975 us

I think this is separate from the incremental linker issue in that regardless of how fast linking can be, it shouldn't be triggered if the underlying compilation units haven't changed.

It definitely is separate from the incremental linker issue. But it is actually pretty hard to solve in our current classpath model.
@sjrd what do you think about that one? It is definitely fixable, the question is more how backwards compatible can we make the tools API...

I'll try and have a look at this one.

No need to change or classpath utilities, nor should we.
We can supply have the Linker short-circuit right after updateFiles if no file has been read again from disk, nor disappeared. The rest of the pipeline can be short-circuited as well from there. At this point we should still probably touch the final .js file, though, or this much will be repeated over and over again until some sjsir finally changes.

This is harder than it sounds, notably because of the builder abstraction: Once we instantiate a builder for a file, that file is gone, even before we start the compilation pipeline.
An option is to add the following method to JSTreeBuilder:
/** Tells the builder, that the resulting tree is unchanged.
  *
  *  If the builder replies true, the building terminates.
  *  If the builder replies false, the caller must rebuild the tree.
  */
def unchanged(): Boolean = false

This will effectively allow the client of the pipeline decide whether it wants the pipeline to continue (e.g. file was deleted).
However, this also requires to change the JSFileBuilder (and friends) to not take streams but files (or probably virtual files), since otherwise they are unable to deal with the unchanged method.
Further, I considered implementing the change propagation by adding a version field to the linking unit. It seems better than having each method in the Linker return an optional value (and pushing force parameters down the callstack). Again, this allows the client to decide, whether it wants to continue the pipeline anyways a posteriori.
The downside is, that we now hold on to the last linking unit produced by the Linker, which can be memory heavy. Although I have not benchmarked this (I don't have a running version of this yet).

WIP branch here: https://github.com/gzm0/scala-js/tree/no-link-unchanged

@sjrd I was hoping on a comment form your side, whether you think the above is a reasonable approach. It seems to be a more fundamental change than the ticket initially suggests.

I think you are over-engineering it. It's not necessary to pipe stuff through the pipeline. It's fine to rerun the whole pipeline if one IR file changed in the beginning, even if that leads to producing the same LinkedUnit somewhere in the middle. That event should be rare enough that it doesn't matter.
What we want to avoid is rerunning the pipeline if the set of IR files hasn't changed a bit (but other stuff on the classpath, such as resources, have been touched).
Therefore, I think the version in LinkedUnit is overkill. Generalizing JSTreeBuilder also seems too broad.
Instead of changing Linker.link to return (linkingUnit, hasChanged), I would separate the operation in two methods:
  def prepareLink(irInput: Traversable[VirtualScalaJSIRFile], logger: Logger): Boolean
  def link(logger: Logger,
       reachOptimizerSymbols: Boolean, bypassLinkingErrors: Boolean,
       noWarnMissing: Seq[NoWarnMissing],
       @deprecatedName('checkInfos) checkIR: Boolean): LinkingUnit

The first one does updateFiles and returns whether something has changed or not. With that ScalaJSOptimizer can decide what to do; it already works with a VirtualFileWriter, so it should know how to test whether it's deleted or not, etc. If ScalaJSOptimizer wants the linker to proceed, it calls link with the rest of the parameters.
A cleaner separation of concerns would be to simply extract the VirtualScalaJSIRFile cache into a separate class, separated from Linker. Linker.link would take a cache as a parameter. ScalaJSOptimizer would maintain its own instance of the cache, and use that to first update it with the new classpath, then optionally calling Linker.link.
This way, we avoid complicating the entire pipeline.
(We can also keep the old link method, which calls the other two; so we keep full compatibility here.)

I really like that idea! Actually, we can even make it better: With a separate cache, we can do this:

A PersistentIRFile is just a VirtualIRFile
The linker keeps its method taking VirtualIRFiles, but doesn't care about caching (also we lift it from an immutable traversable to a basic one).

This does not change the linkers interface at all, but simply rips out the caching. Further, we avoid a couple of intermediate collections.

Sounds good :)


Weekly Rule

Hello,
I'm using ice_cube with RoR but I can't seem to get weekly rules to work. I've stripped out all the user input and hard coded the inputs and here is the code:
rule_inst = IceCube::Rule.weekly(1).day(4)
st = DateTime.new(2011,12,1,18,0,0)
fin = DateTime.new(2012,1,19,18,0,0)
schedule = IceCube::Schedule.new(st, :end_time => fin)
schedule.add_recurrence_rule rule_inst

occurrences = schedule.all_occurrences

But occurrences only gets filled with an array of 1 element pointing to the time/date for the start time. What I would expect is the dates of every Thursday between the start and end date.

You should be using instances of Time or TimeWithZone instead of DateTime.
I've added a test that takes your logic and just replaces with Time so you can see how it works, and the desired output.

Many thanks :)

Any time :)


Error for 05 local execution notebook in Colab

When running in Colab I see this error for llama.cpp

Hey @jamescalam , I can't replicate this on ae18c7. Can you provide some more information please?

Fixed in: https://github.com/aurelio-labs/semantic-router/pull/157


WIP: Attempt to fix Cmi_format error in voodoo-do, by checking in prep that the magic numbers match

Is there a better way to check that we won't get a Cmi_format error? I really don't understand everything that's going on here and if this is a useful check.
The other possibility to fix the Cmi_format error that's caused by copying files generated by the wrong OCaml compiler version would be to catch the Cmi_format error in voodoo-do and discard it, if I understand it correctly.

The other way would be to catch it at source - ie, in prep.

This patch is trying to catch it in prep. I think if there's a reliable way to catch it there, that would be preferable.


Compilation fails with Xcode 14 and Xcode 13.4.1, is this repository still being maintained?

maybe it not compile for iOS15 and higher?

Doesnt look like it.    Not sure what to do now.

This library not updated to support iOS 15 and higher, try to make some changes manually in the library from this merge request. Or you can try to find fork of this library with fix.


Should this work in UWP or not?

Thank you for this library.
We're having issues and before we chase them, it's just not clear: Should it work?

Hi @JerryNixon,
I'm the friendly issue checker.
It seems like (100.00 %) you haven't used our issue template :cry: I think it is very frustrating for the repository owners, if you ignore them.
If you think it's fine to make an exception, just ignore this message.
But if you think it was a mistake to delete the template, please close the issue and create a new one.
Thanks!

The latest pre release includes the uwp verison (2.2.0-pre.*)


Native OP pause + Navbar/Topbar icon

Added the following:

Added option for allowing to use the native OctoPrint pause function instead of Gcode - some printers, my Anycubic included, reports support Gcode pause both dont honor them, so I added this option. Its default is to use Gcode. (Under settings "Filament out action")
Implemented an navbar/topbar icon to show filament status - when not printing the UI will poll every 65 seconds. The backend caches results and will reply with that. The cache is expired when older than 60 seconds
Did a bit of refactoring in the backend - made a setupGPIO function to enable handling the GPIO setup when polled
Small settings changes to support the new native OP pause

Oh, and don't forget to update documentation

And one maybe stupid question, does octoprint pause feature park the printing head? Never tried it.

Also, when using OP change and resuming without filament in it cancels the print, this needs to be fixed.

Why not just merge this so people can get the new function and then we can rewrite the other stuff in another release.
I agree that when starting again without filament the plugin cancels the print - thats the way its always been as far as I can tell

I like to have things done first time right but ok, I will merge it and then simplify it. Thanks for your work, really appreciate it :)


Make WebView use TS

Currently, we use JS to write on the webview, but it's tiresome to do so.
We'd like for it to compile on publish from ts files.

As per the github pull requests extension, we have to bundle it before bundling the whole thing. It probably requires a webpack file in the root.
It's also interesting if we can use React instead of plain Jquery.

+1 for React. 3 months later we have a better idea of what's useful and what not to people. Therefore it's justifiable to evolve.

Will close as stale


SFX-299: Fix container size of components

This adds display: block to most components. Note that in any component that can be shown/hidden, the block display must be active only when shown.
Caveats:

The following components do not have a correct container size when used in isolation:

List
Product
Base
(None of the above components are currently used in isolation, so this is technically not yet a problem. Additionally, Base should never be used in isolation.)

@ChantalDesrochers My impression is that, given that we're still in the "unreleased" category, we don't really need to add changes. If a component splits into two, or something else major, we can consider recording that. Until then, we are just 'adding' the relevant components. Later we'll be officially changing them.


Where can I edit language?

Where can I edit language?

There are no "official" translations. If you want to change the language, feel free to fork and manually go through all files in src/renderer/Components and translate the strings.


Failures on [cfe] Compute correct type for read of late lowered variables

There are new test failures on CL [cfe] Compute correct type for read of late lowered variables.
The tests
dartdevc_native/debugger/debugger_test RuntimeError (expected Pass)
lib/collection/failing_list_test RuntimeError (expected Pass)

are failing on configurations
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome

Nick, feel free to close if these issues have already been addressed.

I have reprioritized because I don't think this should be a release blocker but we do need to take a look at dartdevc/debugger/debugger_test and dartdevc_2/debugger/debugger_test. The former needs to be migrated to null safety still. The later was already failing with a runtime error and we haven't decided what to do about it yet.
lib/collection/failing_list_test has been fixed.

These tests were fixed in e352744fa4a8c97c384694861f3ffd8e1dceabef and all are passing now.


connect falied due to unexpected behaviour

I had written a testing script that connect to the PostgreSQL port of MyDuck Server repeatedly and performed some insertions. After performing this procedure serveral times, i.e. connect -> multiple insert SQLs -> disconnect, MyDuck Server seemed to be function unexpectedly. The packages captured depicts that the authentication had already done successfully(Shown in the first picture), but finally it informed the client that "database "mysql" does not exist".
This issue might be reproduced by performing the "connect -> multiple insert SQLs -> disconnect" serveral times.

Uploading myduck_vec.pcap.zip…


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/virtual-machine-images/image-template
Module Details
Migrated from CARML as part of this PR: https://github.com/Azure/bicep-registry-modules/pull/756
@ahmadabdalla is owning the module.
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
ahmadabdalla
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @ahmadabdalla,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @ahmadabdalla,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

PR: https://github.com/Azure/bicep-registry-modules/pull/756

[x] Module published.
[x] GitHub teams are available and assigned to their parents.
[x] CODEOWNERS file updated.

Thank you for your work @ahmadabdalla and @AlexanderSehr! I'm closing this issue now.


Twitter ingest format v0.9.0

For v0.9.0 an extension to provide ingest of twitter API tweets. Each tweet is expected to well formed json with no newlines in a (possibly compressed) text file.

Although the CI says it builds successfully, the twitter plugin was not included in the build. It must be refactored.

refactored to support latest on master, pulled in #899


Pull #1247 must be revoked, code on pull #1247 solves Issue #1117 instead of Issue #1097, Issue #1117 must be closed and Issue #1097 must reopen

What would you like to share?
I was running up some tests for the code I submitted.
I ended up on issue #1117  and when I was about to implement it I realized that it's the same code that was merged on pull #1247 . My program that I committed on #1247 does not check whether or not the output number is divisible by any other number. The output is just odd. So the commit that fixes issue #1117 is in pull #1247 and issue #1097 should be opened again.
Additional information
No response

Hey @SpirosArk
the code submitted in #1247
(rand() % (upper - lower + 1)) + lower)

generate random number (even and odd both) that's why it closes the issue #1097 , I may misunderstood that but I didn't know why to reopen that issue

code on pull https://github.com/codinasion/codinasion-programme/issues/1247 solves Issue https://github.com/codinasion/codinasion-programme/issues/1117

code on pull #1247 solves Issue #1097

Sorry, Pull #1250 not #1247

random-prime-number.c on Pull #1250 solves issue #1117
issue #1127 must reopen


ISPN-11020 Max Idle Take 2

Scattered cache should be fixed now too.

Addressed review comments and rebased.

The new tests should be pretty good now and also fixed a few other issues.
However the remaining issue is if I have to start a new transaction to lock a key or if I am able to use a non tx context to do the required locking with the touch command. @danberindei mentioned the latter may be possible. Otherwise I will have to use a new transaction (currently gets ClassCastException since SingleKeyNonTxInvocationContext is not a TxInvocationContext.

Need to make sure to add in the change from https://github.com/infinispan/infinispan/pull/7706#discussion_r364720300 in this PR.

@wburns lots of failures in InvalidatedNearCacheTest

The InvalidatedNearCacheTest failures are likely a problem of the test itself, because testGetNearCacheAfterConnect calls assertClient.resetEvents() instead of waiting for all the events that the server could generate.

The InvalidatedNearCacheTest failures are likely a problem of the test itself, because testGetNearCacheAfterConnect calls assertClient.resetEvents() instead of waiting for all the events that the server could generate.
I re-ran the build and the InvalidatedNearCacheTest failures are gone, but now there's a failure in ClusterExpirationLoaderFunctionalTest:
https://ci.infinispan.org/job/Infinispan/job/PR-7722/11/testReport/junit/org.infinispan.expiration.impl/ClusterExpirationLoaderFunctionalTest/testWriteExpiredEntry_DIST_SYNC__tx_true_/

Looking into it.

Integrated, thanks Will!


Support mocking multiple interfaces

Based on SO question: Mocking a class with an explicitly implemented interface using Foq it would be nice to be able to Mock "As" another interface in a similar fashion to Moq.
This has been implemented in the Mercurial repository on CodePlex.

Fix now replicated to Git repository


[CLI] Support service/endpoint upstream/downstream dependency

As the topology is nearly impossible to show on the console, CMIIW, I suggest we change it to upstream/downstream dependency for specific service(s), multiple services topology supported on the backend, CLI could make the call.
Also, we need to consider, how to provide metrics query of the dependency relationship. We could do further discussion when we do that.

Service and Endpoint dependency have been supported through https://github.com/apache/skywalking-cli/pull/107 and https://github.com/apache/skywalking-cli/pull/113 in 0.8.0


Seed for launch

5941193551318898364

New Seed is "Caco's Secret Love-Room" per the donation drive.


The tutorial url does not work anymore https://www.lizeyan.me/Install-K8s-6af38c1ff4e04b6d9ea9387a7a198b5b

The tutorial url does not work anymore https://www.lizeyan.me/Install-K8s-6af38c1ff4e04b6d9ea9387a7a198b5b

@lizeyan please help me :crying_cat_face:

@lizeyan please help me 😿

Try this: https://www.notion.so/Install-K8s-6af38c1ff4e04b6d9ea9387a7a198b5b

Thank you @lizeyan.
Another concern. It seems like the README below is outdated. Basically, after cd train-ticket, there is no es-jaeger.yml file.
Please help me :bow:
https://github.com/lizeyan/train-ticket/tree/master/deployment/kubernetes-manifests/k8s-with-jaeger

es-jaeger.yml is here: https://github.com/lizeyan/train-ticket/tree/master/deployment/kubernetes-manifests/k8s-with-jaeger


nightly-main hasn't updated recently

I noticed nightly-main hasn't updated recently.
Is SwiftFiddle using this docker image? It says it hasn't been updated in three months. I wonder if this is an outdated reference, or if its build pipeline is broken.

Thank you for reporting. nightly-main-bionic tag seems no longer maintained. I use nighly-main-focal instead. https://github.com/SwiftFiddle/swiftfiddle-runner/commit/112614ff446d1ee6595622ca0f442a291cac315d
Could you check if it is fixed?
I didn't notice, thank you. @calda

Working now, thanks!


Release 0.2.0.

Codecov Report

Merging #111 (0009cb3) into master (4dd5a6e) will decrease coverage by 0.16%.
The diff coverage is 94.87%.

:exclamation: Current head 0009cb3 differs from pull request most recent head 3dda821. Consider uploading reports for the commit 3dda821 to get more accurate results

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   95.04%   94.87%   -0.17%
==========================================
  Files          57       68      +11
  Lines        9215     9526     +311
==========================================
+ Hits         8758     9038     +280
- Misses        457      488      +31

Impacted Files
Coverage Δ

src/archetype/identifier/mod.rs
94.88% <ø> (ø)

src/archetypes/impl_serde.rs
98.13% <ø> (ø)

src/entities/mod.rs
100.00% <ø> (ø)

src/entity/allocator/impl_serde.rs
98.76% <ø> (ø)

src/entity/allocator/slot.rs
82.85% <ø> (ø)

src/entity/mod.rs
100.00% <ø> (ø)

src/lib.rs
100.00% <ø> (ø)

src/registry/seal/storage.rs
99.91% <ø> (-0.02%)
:arrow_down:

src/system/mod.rs
0.00% <ø> (ø)

src/system/null.rs
0.00% <0.00%> (ø)

... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update external deps examples dvc run command

Since the change to v1 of DVC, the description of generating a separate DVC file is no longer true

thanks @Robbie-Palmer !!


Foundry : cast storage slot argument length issue

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (2f4a77e 2023-08-31T00:32:46.319290372Z)
What command(s) is the bug in?
cast storage
Operating System
Linux
Describe the bug
When I try to get the private variable stored at storage slot 0 of the contract storage using the cast storage command,
cast storage <my-contract-address> 0 --rpc-url <my-rpc-url>

I get this error
Error:
(code: -32602, message: Errors encountered in param 1: Storage slot argument must have a length of 66 ("0x" + 32 bytes), but '0x0' has a length of 3, data: Some(Object {"message": String("Errors encountered in param 1: Storage slot argument must have a length of 66 (\"0x\" + 32 bytes), but '0x0' has a length of 3")}))

for example,

I already tried to pad 0 as 0x000...0 (32 bytes) but still getting the same error.

@blueh4mster
I think the problem is with the --rpc-url or the contract itself.
Because I did the same thing with another RPC URL and it works.

Thankful for your notice, however, I think there is rather some configuration issue with my system and all the other systems I've recieved the same error on because this rpc url belongs to a private blockchain of a ctf event and there are various solves on this challenge. So i think it is highly unlikely that the issue is with the rpc url.
Also other commands seem to work just fine with the same rpc-url.

After checking, foundry is compliant with https://eips.ethereum.org/EIPS/eip-1474#quantity

Using the trace on cast or forge script we can see that the padding value is cast to U256 and complies with the EIP1474.

But seems this is not possible to not comply with the EIP with foundry because this will convert automatically.

So... I didn't notice the activity here but I did solve the issue through someone's help.
According to him, it's some problem in the getStorageAt function of the web3js library, latest version of which ignores all zeroes(?).
He solved the issue by changing the getStorageAt function internally for his system after installing web3js library such that no matter what input param for storage slot you provide it will have some predefined storage slot (for example 0) and it will only give the value stored at that slot.

So apparently the issue is not with the rpc url or wirh foundry but the getStorageAt function.

@blueh4mster @Ethnical : I'm also trying to do mevsec challenge by using foundry and I have this issue.
Do you guys find the solution for this?

@piavgh We will fix it in the next days (on the RPC side). As this is related to the RPC issue we can stop comments here (this is NOT related to foundry) ahah.
Thanks for the info btw.
One workaround: to make some padding as mentioned there:

So... I didn't notice the activity here but I did solve the issue through someone's help.
According to him, it's some problem in the getStorageAt function of the web3js library, latest version of which ignores all zeroes(?).
He solved the issue by changing the getStorageAt function internally for his system after installing web3js library such that no matter what input param for storage slot you provide it will have some predefined storage slot (for example 0) and it will only give the value stored at that slot.

So apparently the issue is not with the rpc url or wirh foundry but the getStorageAt function.


speedtest: Update to speedtest 1.2.0

Description
This updates the Ookla Speedtest CLI used in the Speedtest extension to 1.2.0, which is a universal binary.
Checklist

[ ] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

Works on my intel mac 🎉. @pernielsentikaer can you check it on your M1 please.
Before merging this we should also remove the Compatibility in the Readme.md about Apple Silicon, because it is not required anymore 😄


"git commit" seems to break the transaction interface

If I create an empty database:
mkdir database
cd database
git init .

then start datakit:
com.docker.db --git <path>/database  -url file:///var/tmp/foo

and then run the Go unit tests:
cd go-datakit
go test

-- everything passes.
If I make a commit to the database directory with git:
cd database
echo foo > bar
git add bar
git commit -m test

then (whether I restart the server or not) running the tests hangs committing a transaction:
$ go test
2017/09/27 22:17:38 Testing the client interface
2017/09/27 22:17:38 Dialling unix /var/tmp/foo
2017/09/27 22:17:38 Remove [branch master transactions foo rw a b c]
2017/09/27 22:17:38 Testing the configuration interface
2017/09/27 22:17:38 Dialling unix /var/tmp/foo

The test which triggers this seems to be:
$ go test -run TestTransaction
2017/09/27 22:18:00 Testing the transaction interface
2017/09/27 22:18:00 Dialling unix /var/tmp/foo

If I add some printfs:
$ git diff .
diff --git a/api/go-datakit/transaction_test.go b/api/go-datakit/transaction_test.go
index f59aaef..b49912f 100644
--- a/api/go-datakit/transaction_test.go
+++ b/api/go-datakit/transaction_test.go
@@ -24,8 +24,10 @@ func TestTransaction(t *testing.T) {
        if err != nil {
                t.Fatalf("Transaction.Write failed: %v", err)
        }
+       log.Println("Commit")
        err = trans.Commit(ctx, "Test transaction")
        if err != nil {
                t.Fatalf("Transaction.Commit failed: %v", err)
        }
+       log.Println("Done")
 }

then I get
$ go test -run TestTransaction
2017/09/27 22:19:09 Testing the transaction interface
2017/09/27 22:19:09 Dialling unix /var/tmp/foo
2017/09/27 22:19:09 Commit

which means that the Commit operation is hanging.

This used to work with the very old version 6f0421318ae30a81b78629bfc27323fa96578c00 but seems broken with 97b3d230535397a813323902c23751e176481a86
Could you let me know what you think, @samoht @talex5?

I've written a test script which demonstrates the problem. The script assumes that

your $GOPATH is $HOME/go and you have a checkout of github.com/moby/datakit there. Modify the top of the script to change this assumption
you run  go get github.com/docker/go-p9p

The script is:
cat <<EOT > test-datakit.sh
#!/bin/sh

DB=${DB:-/Applications/Docker.app/Contents/MacOS/com.docker.db}
DATAKIT=${DATAKIT:-${HOME}/go/src/github.com/moby/datakit/api/go-datakit}

if [ ! -e "${DB}" ]; then
  echo "Datakit binary not found at ${DB}: please set DB environment variable"
  exit 1
fi
if [ ! -e "${DATAKIT}" ]; then
  echo "Datakit source tree not found at "${DATAKIT}". Note it has to be on the GOPATH".
  exit 1
fi

echo Using datakit from: "${DB}"
echo Using test cases from source tree: "${DATAKIT}"

database=$(mktemp -d)
echo Created temporary database dir "${database}"

DB_PID=0
TEST_PID=0
clean_up () {
    rm -rf "${database}"
    kill "${DB_PID}" 2> /dev/null
    kill "${TEST_PID}" 2> /dev/null
}

trap clean_up EXIT

pushd "${database}"
git init .
echo foo > bar
git add bar
git commit bar -m test
popd

"${DB}" --git "${database}" --url file:///var/tmp/foo&
DB_PID=$!

sleep 1 # easier than performing fd passing in a shell script

cd "${DATAKIT}"
go test -run TestTransaction 2>/dev/null >/dev/null &
TEST_PID=$!

retries=5
while [ "${retries}" -ne 0 ]; do
  if kill -0 "${TEST_PID}" 2> /dev/null; then
    echo Test is still running
    retries=$(( retries - 1 ))
    sleep 1
  else
    echo Test has finished
    echo Success
    exit 0
  fi
done

echo Test has timed out
echo Failure
exit 1
EOT

If you have a Docker for Mac install with a working (old) datakit, the test passes like so:
$ ./test-datakit.sh
Using datakit from: /Applications/Docker.app/Contents/MacOS/com.docker.db
Using test cases from source tree: /Users/djs/go/src/github.com/moby/datakit/api/go-datakit
Created temporary database dir /var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.M04AzKw9
/var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.M04AzKw9 ~
Initialized empty Git repository in /private/var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.M04AzKw9/.git/
[master (root-commit) af2828f] test
 1 file changed, 1 insertion(+)
 create mode 100644 bar
~
Starting com.docker.db 0.7.0-34-g6f04213 ...
Test is still running
com.docker.db: [INFO] accepted a new connection on file:///var/tmp/foo
com.docker.db: [INFO] Using protocol TwoThousand msize 16384
Test has finished
Success

If you have the latest master datakit then it fails like so:
DB=~/go/src/github.com/docker/pinata/mac/build/Docker.app/Contents/MacOS/com.docker.db ./test-datakit.sh
Using datakit from: /Users/djs/go/src/github.com/docker/pinata/mac/build/Docker.app/Contents/MacOS/com.docker.db
Using test cases from source tree: /Users/djs/go/src/github.com/moby/datakit/api/go-datakit
Created temporary database dir /var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.mRISPXGH
/var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.mRISPXGH ~
Initialized empty Git repository in /private/var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.mRISPXGH/.git/
[master (root-commit) 692e305] test
 1 file changed, 1 insertion(+)
 create mode 100644 bar
~
Starting com.docker.db %%VERSION%% ...
Test is still running
com.docker.db: [INFO] accepted a new connection on file:///var/tmp/foo
com.docker.db: [INFO] Using protocol TwoThousand msize 16384
Test is still running
Test is still running
Test is still running
Test is still running
Test has timed out
Failure
com.docker.db: [ERROR] Uncaught exception handling tag 72 Write(fid: 126, offset: 0, len(data): 6):
                       Exception: (Sys_error
  "/var/folders/5q/xqlk9dzn5jz7_hn2j31brc0r0000gn/T/tmp.mRISPXGH/.git/lock/refs/heads: No such file or directory")
                       No backtrace available.

I did a simple bisection of the binary PR builds from CircleCI and have:

#566 ❌
#546 ❌
#536 ❌
#533 ❌
#529 ❌
#528 ✅
#527 ✅
#474 ✅
#398 ✅
#356 ✅

My guess is that it was introduced in #529

I have identified the cause: there is a regression in the way we compare the contents of reference files. For some reasons, we do not trim the contents anymore, so <hash>\n -- which is created by git commit -- is in conflict with <hash> -- as understood by Datakit/Irmin: thus the transaction can never be resolved.
I am trying to understand where does the regression come from exactly and will push a fix shortly. Thanks a lot for the nice reproduction case, it helped a lot to track that down!


Log Segmentation Design

One of the prerequisites for compaction implementation is the division of Ambry's log into segments. This issue tracks the design of log segmentation in Ambry.
This is the design document.

This implementation is now complete.


[STORM-2472] kafkaspout should work normally in kerberos mode with kafka 0.9.x API

https://issues.apache.org/jira/browse/STORM-2472
storm 1.0.x-branch didn't support kafkaspout to consume from kafka in kerberos mode with we can't  set kafka's parameter ,'java.security.auth.login.config', in storm's process .So I solve it via preparing a kafkaspout.

@liu-zhaokun you can set it via topology.worker.childopts or worker.childopts. Lets is not put work-around for this when there is viable option to set it. Also 0.9 consumer API is for Alpha and its not been used by anyone.

@harshach
It doesn't work even I have set system property in the topology.But we can do it by setting the path to "java.security.auth.login.config" in the 'open' method of kafkaspout.

Hello, @harshach
Looking forward to your reply.

@HeartSaVioR
Could you help me to review this PR?

@vesense
Hello,could you help me to review this PR?

@liu-zhaokun I am still not sure why are we adding this code. One shouldn't be using 0.9 kafka clients and this storm-kafka-client will not work with 0.9 as the interface changed in 0.10 and we made changes to storm-kafka-client to start working only from 0.10 kafka clients only. As I said before 0.9 kafka clients shouldn't be used as they are alpha quality.
If you look the kafka client docs https://kafka.apache.org/documentation/ ,  you'll see "sasl.jaas.config" this is consumer config one can pass and the storm-kafka-client will allow you to pass this config. So there is necessity to add this code.

@liu-zhaokun following upon my previous comment , do not use stom-kafka-client from 1.0.x-branch as there are lot of bug-fixes went into storm-kafka-client in Storm 1.1 release

@liu-zhaokun Are you planning on following up on this PR?

@liu-zhaokun how did you manage to solve this? Currently new storm-kafka-client isn't very stable and doesn't support the transactional spout. I've to connect to Kafka (<IP_ADDRESS>) via. Kerberos on Storm (1.0.6)
Any ideas?, it will be a great help!

@aniketalhat
You can look through my PR，and my intention was to export java.security.auth.login.config=the path to your keytab,and it works.You can try it.

Hello Liu,
Thanks for your quick reply, my one concern is that your PR is for
storm-kafka-client(new consumer) where as I'm looking for storm-kafka(old
consumer) solution, what do you think ?
On Tue, May 15, 2018 at 4:40 PM, zhaokun liu<EMAIL_ADDRESS>wrote:

@aniketalhat https://github.com/aniketalhat
You can look through my PR，and my intention was to export
java.security.auth.login.config=the path to your keytab,and it works.You
can try it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/storm/pull/2066#issuecomment-389073805, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADcPbLdznyCju9ESv2_z3xh4xhWoGpDRks5tyoZ3gaJpZM4M8Nf7
.

--
Aniket Alhat


Add help section in the app

Help section displays -> webpage (mobile friendly) content.
Angela can keep webpage information updates with FAQ's and other useful info. We can show the onboarding screens again, etc..

Add (i) icon to the nav for this help section.


Audio Splitting from Video

Audio not merging with video file after being converted. I have uninstalled and re-downloaded but still having the same issue. Worked fine for over 4 weeks but hasn't worked for the last 2 weeks. Thanks

Are there any errors in the console?
Also, check if you have enough space in the destination storage you selected as the download path. Technically, you require double the size of the video you're downloading since it needs to be merged as a separate file.

Hi, Thank you for the quick reply and your work on this.
No error messages on console and 700gb free on the ssd drive it's going to. Just weird how it was working, then stopped. No update on the pc which have affected it. Thanks

@FylnnLives My apologies for abandoning this issue. I went on vacation and completely forgot about this. If I may ask, what was the issue actually?

I'm sorry for the seriously later reply. Just purged my e-mails and saw you had replied. I just uninstalled it and left it for weeks and tried again and this time it worked. I think one of the third party downloads you do in the install had an issue. It worked perfectly fine, then it didn't. Think something else I had might of corrupted a file or something. Thanks again for the Ripper, it's a God send


pari: 2.11.4 -> 2.13.1, update sage test expectations

Motivation for this change
Fixes #102699 without breaking Sage. We will wait until the Sage patch is upstreamed, though (see https://github.com/NixOS/nixpkgs/pull/122592#pullrequestreview-657112637).
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg eval

@timokau This the upstream ticket now has a positive_review. There are many options: wait for the next Sage beta, wait for the 21.05 branch to be cut, and so on. Let me know what you prefer :)

@timokau Thank you for caring deeply about Sage stability, and thank you for the review!


fix scope override

The following does not work:
Rails.application.config.middleware.use OmniAuth::Builder do
  provider :discord, ENV['DISCORD_APPID'], ENV['DISCORD_SECRET'], scope: 'identify guilds'
end

This is because the value gets overridden to nil.
This PR fixes that issue.

Fixes https://github.com/adaoraul/omniauth-discord/issues/4


Created Packery Typings

Completed Typings for Packery v1.4.1

packery/packery.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/packery
http://bower.io/search/?q=packery
others?

[X] has a test file? (packery/packery-tests.ts or others)
[ ] pass the Travic-CI test?

@piraveen thanks mate!

my pleasure to contribute :+1:


Update readme, dev insights and contribution guidelines

README is wrong about the notebooks, similar section on website might be lagging behind, and we need more details on versioning.

Add contributor third-party consumer guidelines


Removed text from rules banner.

I got a failure on npm start here:
`STACovidDashboard/reactDashboard/node_modules/watchpack/lib/chokidar.js:17
throw new Error(
^
Error: No version of chokidar is available. Tried chokidar@2 and chokidar@3.
You could try to manually install any chokidar version.
chokidar@3: Error: Cannot find module 'chokidar'
`
The build happens on master too, so likely the issue is me. If npm start works for you, then don't worry about it :)


[Design kit] update modals

Update modals to include varying sizes, reference the Carbon kit for size specs

Sizes

xd
small
default
large
mobile

Types
passive
transactional
danger
Acceptance criteria
Added to all Themes

[ ] white
[ ] gray 10
[ ] gray 90
[ ] gray 100

not stale


x/pkgsite: search results show incorrect latest version if the latest version of the module and package do not match

The search result list for a query will include a Version and Published in the results that may not match the version that will be loaded when following the link due to the most recent module aware version being numerically lower than the +incompatible version that was released before the package converted to support Go modules.
As an example, searching for stripe results in the top result listing "Version: v70.15.0+incompatible | Published: Apr 14, 2020 | Imported by: 1171 | License: MIT"
If you follow the link, the result page is for v1.0.3 with a publication date of Oct 22, 2014.

/cc @julieqiu @jba @jamalc

I believe the current state is that the code is in place and deployed, but the search data needs refreshing. Will confirm on Monday.

The first result for https://pkg.go.dev/search?q=stripe is now fixed. github.com/stripe/stripe-go shows v1.0.3, which matches the latest version on https://pkg.go.dev/github.com/stripe/stripe-go.
The second result, github.com/stripe/stripe-go/form, has a bug that needs to be fixed.
Currently, it shows v70.15.0+incompatible. The latest version of github.com/stripe/stripe-go/form is actually v1.0.4-0.20190107233620-02a95e768d9b, which is shown on https://pkg.go.dev/github.com/stripe/stripe-go/form.
The reason is because the isLatestVersion logic in InsertModule only takes into account the module path, not each individual package path:
https://github.com/golang/pkgsite/blob/master/internal/postgres/insert_module.go#L118
Thanks for filing this @Deseao! We'll work on a fix.

The latest version of github.com/stripe/stripe-go/form is actually v1.0.4-0.20190107233620-02a95e768d9b, which is shown on https://pkg.go.dev/github.com/stripe/stripe-go/form.

Um... The go command resolves both github.com/stripe/stripe-go@latest and github.com/stripe/stripe-go/form@latest to v70.15.0+incompatible, not v1.0.3.
example.com$ go version
go version devel +150bd4ff Wed Sep 23 07:51:17 2020 +0000 linux/amd64

example.com$ go mod init example.com
go: creating new go.mod: module example.com

example.com$ go list -m github.com/stripe/stripe-go@latest
go: downloading github.com/stripe/stripe-go v1.0.3
github.com/stripe/stripe-go v70.15.0+incompatible

example.com$ go get -d github.com/stripe/stripe-go/form@latest
go: downloading github.com/stripe/stripe-go v70.15.0+incompatible
go: found github.com/stripe/stripe-go/form in github.com/stripe/stripe-go v70.15.0+incompatible

Note that github.com/stripe/stripe-go has a go.mod discontinuity. Its go.mod file has been added and removed three times; however, because the latest version of that module compatible with semantic import versioning (v1.0.3) lacks an explicit go.mod file, the latest version is considered to be the latest +incompatible release.

This has been fixed. Both https://pkg.go.dev/search?q=stripe and https://pkg.go.dev/github.com/stripe/stripe-go now show  v70.15.0+incompatible.


Automatic recommendations based on calibration data

Currently, user need to interpret the calibration plots manually. It would be great if we could automatically give them recommendations based on the calibration data.

This is a great idea but lacks detail to be actionable. Let's close this and create a new issue with concrete ideas later.


Changed date picker color

Follows app colors

Current coverage is 31.50% (diff: 0.00%)

Merging #58 into master will decrease coverage by 0.04%

@@             master        #58   diff @@
==========================================
  Files            33         33
  Lines          1350       1352     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            426        426
- Misses          924        926     +2
  Partials          0          0

Powered by Codecov. Last update 064e727...ac5f80d


Update create-first-pipeline.md

Removed space K8sCluster Connector
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[x] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@ravilach when you changed the Id of the K8s cluster connector you didn't update the YAML of the Infra Def that uses that connector, so it will fail.

@michaelcretzman thanks for the catch. Updated.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@ravilach Approved. You can merge.


'rdau' RDF namespace is not registered

config/install/rdf.mapping.node.islandora_object.yml defines the following mapping:
  field_edition:
    properties:
      - 'rdau:P60329'

but the rdau namespace is not registered (or at least isn't known to the rdf_get_namespaces() function). Should we add that namespace to islandora_rdf_namespaces()?
I think rdau is used as the namespace for http://www.rdaregistry.info/, but I can't find P60329 in any of the ontologies registered there. Metadata IG folks, any suggestions?

Perhaps also co?
https://github.com/Islandora/islandora_defaults/blob/8.x-1.x/config/install/rdf.mapping.node.islandora_object.yml#L106

Nevermind, co is defined in core islandora

Maybe we should do a review to see if all the namespaces for all the default mappings are registered?

Maybe we should finally just make this namespace thing configurable....
Note: this is untested code... just something that popped into mind and written up real quick.
rdf_map.schema.yml
rdf_map:
    type: config_object
    mapping:
        rdf_mappings:
            type: sequence
            label: 'RDF Mappings'
            sequence:
                type: mapping
                mapping:
                    prefix:
                        type: string
                        label: 'RDF Prefix'
                    namespace:
                        type: string
                        label: 'Fully Qualified RDF Namespace'

rdf_map.yml
rdf_mappings:
    -
        prefix: 'ldp'
        namespace: 'http://www.w3.org/ns/ldp#',
    -
        prefix: 'dc11'
        namespace: 'http://purl.org/dc/elements/1.1/',
    -
        prefix: 'dcterms'
        namespace: 'http://purl.org/dc/terms/',
    -
        prefix: 'nfo'
        namespace: 'http://www.semanticdesktop.org/ontologies/2007/03/22/nfo/v1.1/',
    -
        prefix: 'ebucore'
        namespace: 'http://www.ebu.ch/metadata/ontologies/ebucore/ebucore#',
    -
        prefix: 'fedora'
        namespace: 'http://fedora.info/definitions/v4/repository#',
    -
        prefix: 'owl'
        namespace: 'http://www.w3.org/2002/07/owl#',
    -
        prefix: 'ore'
        namespace: 'http://www.openarchives.org/ore/terms/',
    -
        prefix: 'rdf'
        namespace: 'http://www.w3.org/1999/02/22-rdf-syntax-ns#',
    -
        prefix: 'rdau'
        namespace: 'http://rdaregistry.info/Elements/u/'
    -
        prefix: 'islandora'
        namespace: 'http://islandora.ca/',
    -
        prefix: 'pcdm'
        namespace: 'http://pcdm.org/models#',
    -
        prefix: 'use'
        namespace: 'http://pcdm.org/use#',
    -
        prefix: 'iana'
        namespace: 'http://www.iana.org/assignments/relation/',
    -
        prefix: 'premis'
        namespace: 'http://www.loc.gov/premis/rdf/v1#',
    -
        prefix: 'premis3'
        namespace: 'http://www.loc.gov/premis/rdf/v3/',
    -
        prefix: 'co'
        namespace: 'http://purl.org/co/',

islandora.module
/**
 * Implements hook_rdf_namespaces().
 */
function islandora_rdf_namespaces() {

    $rdf_map_config = \Drupal::config('rdf_map');
    $rdf_mappings = $rdf_map_config->get('rdf_mappings');
    if (!is_array($rdf_mappings)) {
      throw new \Exception("RDF Map config is not an array.");
    }
    $maps = [];
    foreach ($rdf_mappings as $rdf_map) {
      $maps[$rdf_map['prefix'] = $rdf_map['namespace'];
    }

  return $maps;
}

This is, of course, less efficient that simply returning a hard-coded list, but much easier for sites to update; especially with Features. Also, I recently learned that we can add weight to our module so it's module file is processed after others, making it more likely that our config will override other mappings set.

I like the idea of auto-discovery. Having to manage the mappings and their corresponding namespaces separately is going to be a PITA in the long run.

P60329

I think rdau is used as the namespace for http://www.rdaregistry.info/, but I can't find P60329 in any of the ontologies registered there.

See http://www.rdaregistry.info/Elements/u/#P60329

Specifically, rdau is the suggested prefix for the unconstrained properties RDA element set (namespace URI: http://www.rdaregistry.info/Elements/u/ )
I find http://www.rdaregistry.info to be kind of an unstable site in general. Maybe it was being weird when you were looking at it? Currently the link above (http://www.rdaregistry.info/Elements/u/#P60329) does resolve to the "has edition statement" property.
It is also registered at http://metadataregistry.org/schemaprop/show/id/14925.html

I can take this for the sprint. Simply adding the namespace is simple enough, but would folks like me to go ahead and move the namespaces to config as I suggested above? If so, should it go in the islandora module or in the JSON-LD module?
Thoughts, @Islandora/8-x-committers ?

I am not a committer, but +1 on making the namespaces configurable (preferably via the UI in such a way that metadata managers will be able to add namespaces as needed).

Resolved via https://github.com/Islandora/islandora/commit/56444554ef69e050e985f23ec5af688e753a8535 and https://github.com/Islandora/jsonld/commit/b7acb80a8793a35f3d688acbf12c9334a9fc59b8
You can now configure namespace prefixes through the UI in jsonld's config page.  Be sure to run the update hook after fetching the newest code.
We should make note to that effect in https://github.com/Islandora/documentation/pull/1789 as well.


[BACKLOG-31459] Update Salesforce driver to version 46 in Salesforce …

…plugin

:gear: Build finished in 1m 53s with command:
mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -P !assemblies -pl plugins/salesforce/core

:ok_hand: All tests passed!

Total
Failed
Skipped

87
0
0

Details

:information_source:  This is an automatic message

@bmorrise @mdamour1976


WIP: .travis.yml: make package pulls conditional.

it seems to need some rework :

2.54s$ sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install clang-3.6
..
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
clang-3.6 : Depends: libclang1-3.6 (= 1:3.6.2~svn240577-1~exp1) but it is not going to be installed
Depends: libllvm3.6 but it is not going to be installed
Depends: libstdc++6 (>= 4.9) but 4.6.3-1ubuntu5 is to be installed
Depends: libstdc++-4.9-dev but it is not installable
Depends: libgcc-4.9-dev but it is not installable
Depends: libobjc-4.9-dev but it is not installable
Depends: libclang-common-3.6-dev (= 1:3.6.2~svn240577-1~exp1) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Well, it appears that I've figured it out, i.e. it works as latest red cross from travis is unrelated. But after melt-down and make-over travis removed "profiling" information from [raw] log files. I mean earlier there were 'duration' fields recorded for each step and one could see what are the gains, but not anymore :-( I'd also like to argue in favour of configuring with no-makedepend (makedepend makes lesser sense in build-test-and-throw-away) and omitting test_fuzz in mingw tests (it's grotesquely wasteful).

I agree it's not needed to do 'make depend' on a clean CI build.  But maybe doing it once finds bugs in make depend?  Also agree on the others.  So a preliminary plus-one from me on your PR when you do it :)

There is "fun" dependency between no-makedepend and --strict-warnings. On related note there was report that it fails to recognize gcc if it's command line doesn't have gcc in name. Anyway, rationale behind no-makedepend is that I/O seems to be expensive (for example in attempts to include Android builds quite a time was spent on just unpacking stuff, more time than just downloading it), and makedepend is a bunch of small files...

exit in before script make job "successful" and it takes less than a minute. Unfortunately one still has to load new compilers, which would be a waste... As mentioned in #2661 idea is to formulate a criteria by which to short-circuit most of the jobs pretending that they were successful. Additional criteria, i.e. in addition to easy-to-forget tag in commit, can be to tell apart merge requests and "official" repo commits.

I'm not sure what that exit 0 in the before script is supposed to accomplish.  Does it stop that section there?

what that exit 0 in the before script is supposed to accomplish.

Idea is to opt-in commits for full tests, right? For this you need a way to terminate a job and mark it as "success". And you want to terminate it as early as possible. exit 0 in beginning of before script seems to allow that. So now I have to figure out how to identify opt-in tag and not call exit...

So the suggestion is to mark specific targets with EXTENTED_TEST=yes in .travis.yml and idea is to execute them only if last commit has [extended tests] tag. It's still quite wasteful in sense that it takes 40 seconds to 1 and half minute to decide if test is to be executed. It might be appropriate to reverse the logic and mark non-extended targets with REQEUIRED_TEST. It make sense to arrange order of execution so that extended and non-extended are grouped together on web page. So that you don't have figure out which one is extended, you'd only need to figure out where non-extended tests end...

Re-based and squashed.

So the suggestion is to mark specific targets with EXTENTED_TEST=yes in .travis.yml and idea is to execute them only if last commit has [extended tests] tag. It's still quite wasteful in sense that it takes 40 seconds to 1 and half minute to decide if test is to be executed. It might be appropriate to reverse the logic and mark non-extended targets with REQEUIRED_TEST. It make sense to arrange order of execution so that extended and non-extended are grouped together on web page. So that you don't have figure out which one is extended, you'd only need to figure out where non-extended tests end...

I'm not sure I follow...  What's the intended practical difference between EXTENDED_TEST and REQUIRED_TEST?  Also, the .travis.yml in this PR doesn't show much how you intend this to work, all it does is exit early from before_script, but that doesn't show how you intend tests to be affected by this exercise...  Yes, I know, it's still in WIP, but thing is that as long as there's just that early exit, the intention remains unclear (at least in my mind) and it becomes an academic discussion...

What's the intended practical difference between EXTENDED_TEST and REQUIRED_TEST?

None. It's just a preference question. Do we want to mark "extended" tests or do we was to mark non-extended one in .travis.yml. I.e. goal is the same, to limit execution of same group of tests. And we can say that defining of the said group by tagging tests with EXTENDED_TEST sucks, and decide to describe the complementary group instead by tagging non-extended tests with REQUIRED_TEST. That's all.

all it does is exit early from before_script,

And that is all one can do(*). I wish it could be solved by simply not running selected subset. In dreamland commits not tagged with [extended tests] would be presented with shortened list of jobs at https://travis-ci.org/openssl/openssl/builds/203241005. But it doesn't work like that, and there is nothing we can do. Early exit is simply the way that is available to us. Once again, idea is simply to abstain from running most expensive tests by default, because it's wasteful in most cases. And wasteful not only from travis-ci resource utilization viewpoint, but it's waste of our time waiting for the outcome. By latter I mean that one of points of having ci is that you wait for its results to evaluate them, isn't it?
(*) Well, of course one can solve the problem by arranging different branches to be watched by travis. Main trunk would be with minimalistic .travis.yml, then there could be branch with extended tests. Question here is who would keep it up-to-date? What would users have to remember to do? I understand that it's probably not as complicated. But so is [skip ci], not complicated that is, but how many times people used it say with just documentation update? In other words I'd say that opt-in directly for master branch should be preferred option...

Errrr...  I think there's a misunderstanding here, we seem to be talking about very different things.  My concern is that if this line does exit 0, it breaks off too early, leaving you with an unconfigured build tree and will make the build fail.  Can't you simply set up a variable with content depending on if [extended test] was found or not, and then use that variable where applicable?

... misunderstanding ... exit 0

exit 0 there is supposed not terminate just before_script, but whole job. And in such way that it's marked green. It should never come to configuration, let alone make... At least that's what preliminary tests have shown... Now it's seems to not work anymore... Point was that jobs tagged with EXTENDED_TEST should take like 40 seconds to "complete"... Looking...

It doesn't happen because you do a git log -2, and one of the commit messages you get contains [extended test]...

Duh... Thanks!

So I've amended last commit replacing [extended tests] with ~extended tests~ and as you can see already now extended tests come out green. This also shows that if you were on the other side you can change opt-in by simply amending last commit. Yes, non-extended test results would be wasted, i.e. executed twice, but overall it should be saving... Well, it's still rather wasteful, because just to come to point of decision you update and install packages and it's at least 40 seconds. Do keep in mind that it's not alternative to #2661, rather complement...

Suggestion : git log $TRAVIS_COMMIT_RANGE
See https://docs.travis-ci.com/user/environment-variables/

Suggestion : git log $TRAVIS_COMMIT_RANGE

Cool! Thanks! I'll be having a look at ordering builds on page so that "extended" and "minimal" are not intermixed, and will incorporate the suggestion. But not today. Thanks again.

I get an idea, while following this PR ; please check  #2692...

Suggestion : git log $TRAVIS_COMMIT_RANGE

After additional consideration I'm leaning toward git log -1 $TRAVIS_COMMIT_RANGE, i.e. equivalent of gilt log -2, just more accurate. Rationale is that if you address an issue as part of review, it's not given that it classifies for expensive tests, even if request initially did. I.e. rationale is that you would still have to make judgment and explicitly opt-in even follow-up commits.

This is finalized. Besides conditional package install, it limits test coverage unless last commit is tagged with [extended tests].

So, uhmmmm, if I understand correctly, the purpose of [extended test] does not just cover testing (as in running make test), but everything including building in the first place.  Was that the intention?  That's the effect as currently implemented.

Also, you mentioned somewhere else (email?) that the cross compiled builds could do without test_fuzz.  I totally agree with that idea, +1 for adding a TESTS="-test_fuzz" on those.

purpose of [extended test] does not just cover testing (as in running make test), but everything including building in the first place. Was that the intention?

Yes. Even though you are correct implying that lack of [extended test] tag could translate to build-only thing, it makes lesser sense to compile a number of targets, sanitizers of course, without actually executing the outcome. Second counter-argument is to define bare-minimum amount of tests, as for majority of pull requests just few builds really suffice, and doing more would probably be overkill when it comes to resource consumption, i.e. it's about being cooperative. [I do wish there was a way to cancel part of jobs without them being started, or earlier than it's done now, but in a way that doesn't result in red cross]. Third counter-argument is that since you can "request" extended testing afterwards, by amending last commit and adding the tag, skipping jobs in their entirety would result in lesser waste. [I mean requesting extending testing afterwards would effectively waste resources taken for bare-minimum and skipped jobs in the initial request. If lack of [extended test] tag translated to build-only, the waste would be higher.]

cross compiled builds could do without test_fuzz

It done implicitly in if [ -n "$CROSS_COMPILE" ]; then clause.

Yes. Even though you are correct implying that lack of [extended test] tag could translate to build-only thing, ...

Noted, and I don't disagree with that, just wanted to be clear what we mean with "test" in this context.

cross compiled builds could do without test_fuzz

It done implicitly in if [ -n "$CROSS_COMPILE" ]; then clause.

Ah.  Actually, I would prefer a more explicit approach, i.e. requiring it be explicitely declared in the matrix.  More explicit == less magic == goodness, in my mind.

cross compiled builds could do without test_fuzz

It done implicitly in if [ -n "$CROSS_COMPILE" ]; then clause.

Ah. Actually, I would prefer a more explicit approach, i.e. requiring it be explicitely declared in the matrix. More explicit == less magic == goodness, in my mind.

Pushed.


@cliffy/internal isn't internal

I'm guessing @cliffy/internal shouldn't be visible on JSR?

https://github.com/c4spar/deno-cliffy/blob/33b01f838f5cf84cac86d271b0b4c00311bef0de/internal/deno.json#L4-L20

Is there a way to hide it on jsr?

Is there a way to hide it on jsr?

Not including exports in the per-directory deno.json. But maybe that prevents it from working as a common dependency for the various other packages? If there's no good fix then I'll just close this.

I don't think there is a solution rn.


add comments to procedures

Add a comment button, which inserts a line into the procedure
The line will allow you to insert any comment
The comment will not be executed

done


Deploy multiple clusters in parallel and few other fixes

This is done as part of effort to migrate federation cluster bring-up method to k8s-anywhere Ref: kubernetes/test-infra#3858
This PR mainly does 3 things.

Configurable username for sshing to deployed OS. This was an issue while testing out this PR and this is one way to solve the issue as discussed in https://github.com/kubernetes/kubeadm/issues/219#issuecomment-293110132
Configurable context names in kubeconfig. This is required since we deploy multiple clusters and then merge them to one kubeconfig.
Deploy multiple clusters in parallel by specifying different config files like below:

# make CONFIG_FILE=.config-c1 deploy &
# make CONFIG_FILE=.config-c2 deploy

/assign @pipejakob
/assign @madhusudancs
/assign @luxas
p.s: After the merging of this pr, we can takeup updating kubernetes-anywhere deployer in kubetest to be able to deploy multiple clusters.

@pipejakob, request to PTAL. This pr is important to continue to work on updating k8s-anywhere deployer in kubetest.

@pipejakob, i included one of your commit from your repo to this pr, which i felt is good to be there in upstream. Hope you don't mind.

Thanks! Taking a look at the updates now.


⚠ Bofrost.de has degraded performance

In 07ec69f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1627 ms

Resolved: Bofrost.de performance has improved in 2f73934 after 27 minutes.


feat(coverage): support for coverage folder

Changes proposed:
I've based the icon in this kind of coverage report for libraries:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

I'm still not convinced that we should cover this folder name.

That doesn't mean it doesn't exist. I mean, I don't usually delete it after running the tests so it's always there even it's not committed. Lots of people don't commit vscode or idea folders and we support it.

Not the best point but in order to not get into a meaningless debate, go ahead.


[SourceKit/CodeFormat] Fix multi-line array literal elements not indenting relative to their first line.

Previously each item in an array literal wasn't considered to be an indent context, so we under-indented their continuation lines as in the example below:
doStuffWithList([
    firstItem
    .map {$0}       // This line should be indented further.
    .append(\.foo),   // And so should this one.
    secondItem
    .filter {$0 > 5}
])

After this change, each item is an indent context so we get the below:
doStuffWithList([
    firstItem
        .map {$0}
        .append(\.foo),
    secondItem
        .filter {$0 > 5}
])

Resolves rdar://problem/64834040

@swift-ci please test

@swift-ci please test


Add identifier and identification date to observations + rename uncertainty to confidence [REPLACEMENT ISSUE]

The original issue
Id: 3
Title: Add identifier and identification date to observations + rename uncertainty to confidence

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @peterdesmet on Aug 17, 2020, 16:52
Note, we now use user_id to populate identified_by, to be GDPR compliant.

In GitLab by @kbubnicki on Aug 27, 2020, 00:12
I think both pieces (who + method) of information are relevant -> Thats right!
I would prefer a term classification (as I find it better describing the entire process) and the following derived terms: classified_by, classification_date, classification_method, classification_confidence but I understand the argument of compatibility with Darwin Core.

In GitLab by @kbubnicki on Aug 27, 2020, 00:14
OK but then whats the point of sharing an internal/platform specific user_id with the others? I think the point of having real names of people that classified data is to give them some credits, right?

In GitLab by @peterdesmet on Aug 27, 2020, 10:33
Yes, credit vs privacy is not easy to tackle: I would leave that to the publisher to decide. It is something we have yet to decide for Agouti. Camtrap should allow that freedom in my opinion.
Sharing user_id allows the user to have an idea if e.g. all observations were identified by the same person, a large or small group of people, the same persons as those in deployment setup_by/pickup_by. It also allows the user to contact the project owner for person names that can then be cross referenced with the data he/she already has.

In GitLab by @peterdesmet on Aug 27, 2020, 10:38
I think using classification would still make it compatible with Darwin Core, it just takes a bit more mental juggling for those who know the two (and can be confused with taxonomic classification). Let's maybe ask what others prefer?
Option 1. An observation has identified_by, identification_date, identification_method, identification_confidence
Option 2. An observation has classified_by, classification_date, classification_method, classification_confidence

In GitLab by @yliefting on Aug 27, 2020, 11:21
I think the main reason to use a hash or internal ID is that we do not violate GDPR requirements. We would have to ask explicit permission from all users to publish their name. That means the even if just one person does not agree, the data package cannot be published. For analysis purposes the name of the person making the classification is not relevant: only that classifications were done by the same person. Therefore, an unique hash or internal ID should suffice.

In GitLab by @yliefting on Aug 27, 2020, 11:24
Both terms could work, but I prefer to use classified. You cannot really identify an observation, but you can classify one. Also, identify implies that it relates to an unique individual, whereas classify is more generic and also works for amount/sex/age/behaviour etcetera.
But I'm happy with both options, it all boils down to proper descriptions of the meaning.

In GitLab by @milotictanja on Aug 27, 2020, 15:15
I could live with both terms, but imo identification would be a better definition. Of course, you can't identify an observation, but the workflow is rather like this:

there is a picture containing something (or not)
someone identifies it, on a certain time and using a certain method
this leads to an observation of something (or nothing)

It's a thin line between both terms, but classification is highly associated with taxonomy and in fact you could put observations in classes as an additional step, e.g.,

observations are classified as valid or invalid according to the identification_confidence

In GitLab by @kbubnicki on Sep 2, 2020, 15:08
I still think that classification is better as it is a more generic term already including identification i.e. to classify the content (and this is the process I think) you also have to identify (visually or using some algorithm) all objects on a picture. In the AI world you also have other terms like recognition, detection etc but I find them, as well as identification just a first step leading eventually to classification of image content. This is all semantics but we have to decide for sth or label this issue as community:feedback.

In GitLab by @peterdesmet on Sep 2, 2020, 17:08
I agree, there are many terms for the same process:
classification
identification
annotation
observation
recognition
detection

I can agree with classification, it seems to be the most used term for camera trap data.
Question:

Should observations.csv than be called classifications.csv?
Should observation_type then be called classification_type?

Or do we consider observations the result of classifications? I.e. result vs method.

In GitLab by @kbubnicki on Sep 2, 2020, 17:23
Good question :) result vs method interpretation sounds reasonable but renaming is also an option. As I mention this already a couple of times maybe it will be best when we simplify things just to end up with the first draft and then we can solve this kind of issues with a help of the community. So for now I would (again) leave it like it is now (i.e. classification & without renaming).

In GitLab by @peterdesmet on Sep 2, 2020, 19:57
Good!

In GitLab by @kbubnicki on Sep 3, 2020, 00:41
mentioned in commit 1cf8d960d276ce21e6b3f2f75e918b241f04545d

In GitLab by @kbubnicki on Sep 3, 2020, 00:46
mentioned in merge request !9

In GitLab by @peterdesmet on Sep 4, 2020, 13:30
Implemented in !9.


tapgarden: batch restart fixes

Should fix https://github.com/lightninglabs/taproot-assets/issues/940.
Likely caused by changes in https://github.com/lightninglabs/taproot-assets/pull/866.

I ran this pull request as part of litd. I might need some help verifying that I really did run this code, though.
First I checked out this branch on the litd repo:
git checkout 0-19-staging
I'm on commit 980ee938aa1e7a45633216aff8775ca8d05c12aa
Then I modified the go.mod file. I changed the /taproot-assets line to github.com/lightninglabs/taproot-assets 3159ec9448670552a2c39ae94d7a1d6b5c3178e2
Then I ran go mod tidy. The go.mod file now read:
github.com/lightninglabs/taproot-assets v0.3.3-0.20240610035446-3159ec944867
Then I compiled litd with make install
I then ran litd with litd
Unfortunately, litd crashed:
2024-06-10 09:35:18.120 [DBG] GRPC: [core] [Channel #143 SubChannel #144] Subchannel created
2024-06-10 09:35:18.120 [DBG] GRPC: [core] [Channel #143] Channel Connectivity change to CONNECTING
2024-06-10 09:35:18.121 [INF] RPCS: Trader server is now active
2024-06-10 09:35:18.122 [DBG] STAT: Setting the pool sub-server as running
2024-06-10 09:35:18.122 [INF] SSVR: Opening sqlite3 database at: /home/ubuntu/.tapd/data/testnet/tapd.db
2024-06-10 09:35:18.130 [DBG] GRPC: [core] [Channel #143 SubChannel #144] Subchannel Connectivity change to CONNECTING
2024-06-10 09:35:18.131 [DBG] GRPC: [core] [Channel #143 SubChannel #144] Subchannel picks a new address "test.pool.lightning.finance:12010" to connect
2024-06-10 09:35:18.131 [DBG] GRPC: [core] [pick-first-lb 0xc003ea52c0] Received SubConn state update: 0xc003ea53e0, {ConnectivityState:CONNECTING ConnectionError:<nil>}
2024-06-10 09:35:18.131 [DBG] RPCS: [/lnrpc.Lightning/SubscribeChannelEvents] requested
2024-06-10 09:35:18.131 [DBG] RPCS: [/lnrpc.Lightning/ChannelAcceptor] requested
2024-06-10 09:35:18.160 [INF] TADB: Applying migrations from version=18
2024-06-10 09:35:18.173 [INF] SSVR: Configuring testnet.universe.lightning.finance:10029 as initial Universe federation server
2024-06-10 09:35:18.174 [INF] SRVR: Version: 0.3.2-alpha commit=v0.3.3-0.20240610035446-3159ec944867, build=production, logging=default, debuglevel=info
2024-06-10 09:35:18.175 [INF] SRVR: Active network: testnet3
2024-06-10 09:35:18.175 [INF] RPCS: Validating RPC requests based on macaroon at: /home/ubuntu/.tapd/data/testnet/admin.macaroon
2024-06-10 09:35:18.186 [INF] GRDN: Starting ChainPlanter
2024-06-10 09:35:18.194 [INF] GRDN: Retrieved 2 non-finalized batches from DB
2024-06-10 09:35:18.194 [INF] GRDN: Launching ChainCaretaker(024613161ec23c8140dc613e2d2b01d806c523a562db206b435afc9e7fdd7ff090)
2024-06-10 09:35:18.198 [INF] GRDN: Starting asset custodian
2024-06-10 09:35:18.200 [INF] GRDN: Starting re-org watcher
2024-06-10 09:35:18.198 [INF] GRDN: BatchCaretaker(024613161ec23c8140dc613e2d2b01d806c523a562db206b435afc9e7fdd7ff090), advancing from state=BatchStateFrozen to state=BatchStateBroadcast
2024-06-10 09:35:18.199 [INF] GRDN: Gardener for ChainPlanter now active!
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1a7ac14]

goroutine 3411 [running]:
github.com/lightninglabs/taproot-assets/tapgarden.(*BatchCaretaker).stateStep(0xc0002d5340, 0x60?)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240610035446-3159ec944867/tapgarden/caretaker.go:577 +0xb4
github.com/lightninglabs/taproot-assets/tapgarden.(*BatchCaretaker).advanceStateUntil(0xc0002d5340, 0x1, 0x3)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240610035446-3159ec944867/tapgarden/caretaker.go:292 +0x210
github.com/lightninglabs/taproot-assets/tapgarden.(*BatchCaretaker).assetCultivator(0xc0002d5340)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240610035446-3159ec944867/tapgarden/caretaker.go:351 +0x23e
created by github.com/lightninglabs/taproot-assets/tapgarden.(*BatchCaretaker).Start.func1 in goroutine 1
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240610035446-3159ec944867/tapgarden/caretaker.go:155 +0x67
	```

@Roasbeef will review
it's uncertain if this PR genuinely fixes #940 but it is known that #941 is a genuine fix

So the issue seems to be that you have a batch on disk that is in state BatchStateFrozen, with an empty GenesisPacket.
This could happen if you crashed while minting with v0.3.3, as there the batch was frozen before funding and sealing.
This could also happen on main if you crashed while finalizing the batch, as we write the batch to disk as Frozen before funding and sealing are started and succeed.
On restart, if the batch has state Frozen, later code in the caretaker assumes that it has a GenesisPacket.
The open question IMO is what to do with a batch in state Frozen that still needs changes (like funding and sealing). My intent for this PR is to have that handled before the caretaker starts so that we don't need a bunch of extra checks in the caretaker.

Awesome, I'm running this patch, so far no issues!

But running tapcli --tlscertpath ~/.lit/tls.cert --rpcserver=localhost:8443 --network=testnet assets mint batches still results in a crash:
[tapcli] unable to list batches: rpc error: code = Unavailable desc = error reading from server: EOF
2024-06-12 03:26:26.579 [INF] LITD: Handling gRPC request: /mintrpc.Mint/ListBatches
2024-06-12 03:26:26.583 [DBG] RPCS: [/mintrpc.Mint/ListBatches] requested
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x47b9fa]

goroutine 27193 [running]:
github.com/btcsuite/btcd/btcec/v2/schnorr.SerializePubKey(...)
	github.com/btcsuite/btcd/btcec/v2@v2.3.3/schnorr/pubkey.go:47
github.com/lightninglabs/taproot-assets/taprpc.MarshalScriptKey({0x0?, 0x0?})
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/taprpc/marshal.go:111 +0x4f
github.com/lightninglabs/taproot-assets.marshalSeedling(0xc00191ea00)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/rpcserver.go:4010 +0x37e
github.com/lightninglabs/taproot-assets/fn.MapErr[...]({0xc006750740?, 0x2, 0xc003713350}, 0x352f2e0?)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/fn/func.go:71 +0x5f
github.com/lightninglabs/taproot-assets.marshalSeedlings(0xc0090f2630)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/rpcserver.go:4063 +0x14b
github.com/lightninglabs/taproot-assets.marshalMintingBatch(0xc00191e980, 0x0)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/rpcserver.go:3947 +0x45d
github.com/lightninglabs/taproot-assets.marshalVerboseBatch({0x37c35b0, 0xc0025b9620}, 0xc006750620, 0x0, 0x0)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/rpcserver.go:3859 +0x38
github.com/lightninglabs/taproot-assets.(*rpcServer).ListBatches.func1(0x5?)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/rpcserver.go:860 +0x2b
github.com/lightninglabs/taproot-assets/fn.MapErr[...]({0xc00abb9470?, 0x5, 0x0}, 0xc003713600?)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/fn/func.go:71 +0x5f
github.com/lightninglabs/taproot-assets.(*rpcServer).ListBatches(0xc000683810, {0x37c35b0, 0xc0025b9620}, 0xc002b75c00)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/rpcserver.go:856 +0x3c5
github.com/lightninglabs/taproot-assets/taprpc/mintrpc._Mint_ListBatches_Handler.func1({0x37c35b0?, 0xc0025b9620?}, {0x2226ea0?, 0xc002b75c00?})
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/taprpc/mintrpc/mint_grpc.pb.go:335 +0xcb
github.com/lightningnetwork/lnd/rpcperms.(*InterceptorChain).CreateServerOpts.(*InterceptorChain).middlewareUnaryServerInterceptor.func7({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00}, 0xc004703400, 0xc0048012c0)
	github.com/lightningnetwork/lnd@v0.18.0-beta.rc3.0.20240607141010-393d6829ca7d/rpcperms/interceptor.go:832 +0x111
google.golang.org/grpc.getChainUnaryHandler.func1({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00})
	google.golang.org/grpc@v1.59.0/server.go:1163 +0xb2
github.com/lightningnetwork/lnd/rpcperms.(*InterceptorChain).CreateServerOpts.(*InterceptorChain).MacaroonUnaryServerInterceptor.func5({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00}, 0xc004703400?, 0xc002b86980)
	github.com/lightningnetwork/lnd@v0.18.0-beta.rc3.0.20240607141010-393d6829ca7d/rpcperms/interceptor.go:689 +0x7d
google.golang.org/grpc.getChainUnaryHandler.func1({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00})
	google.golang.org/grpc@v1.59.0/server.go:1163 +0xb2
github.com/lightningnetwork/lnd/rpcperms.(*InterceptorChain).CreateServerOpts.(*InterceptorChain).rpcStateUnaryServerInterceptor.func3({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00}, 0xc004703400, 0xc002b86880)
	github.com/lightningnetwork/lnd@v0.18.0-beta.rc3.0.20240607141010-393d6829ca7d/rpcperms/interceptor.go:781 +0xfc
google.golang.org/grpc.getChainUnaryHandler.func1({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00})
	google.golang.org/grpc@v1.59.0/server.go:1163 +0xb2
github.com/lightningnetwork/lnd/rpcperms.(*InterceptorChain).CreateServerOpts.errorLogUnaryServerInterceptor.func1({0x37c35b0?, 0xc0025b9620?}, {0x2226ea0?, 0xc002b75c00?}, 0xc004703400, 0xc0048012c0?)
	github.com/lightningnetwork/lnd@v0.18.0-beta.rc3.0.20240607141010-393d6829ca7d/rpcperms/interceptor.go:605 +0x52
google.golang.org/grpc.NewServer.chainUnaryServerInterceptors.chainUnaryInterceptors.func1({0x37c35b0, 0xc0025b9620}, {0x2226ea0, 0xc002b75c00}, 0xc004703400, 0x78?)
	google.golang.org/grpc@v1.59.0/server.go:1154 +0x85
github.com/lightninglabs/taproot-assets/taprpc/mintrpc._Mint_ListBatches_Handler({0x238fb80, 0xc000876330}, {0x37c35b0, 0xc0025b9620}, 0xc002ac9700, 0xc000873160)
	github.com/lightninglabs/taproot-assets@v0.3.3-0.20240612001918-76ec8ac232e1/taprpc/mintrpc/mint_grpc.pb.go:337 +0x143
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0003d2f00, {0x37c35b0, 0xc0025b9530}, {0x37d4ba0, 0xc0008cb520}, 0xc002d790e0, 0xc0008b5b00, 0x4ba3858, 0x0)
	google.golang.org/grpc@v1.59.0/server.go:1343 +0xdd1
google.golang.org/grpc.(*Server).handleStream(0xc0003d2f00, {0x37d4ba0, 0xc0008cb520}, 0xc002d790e0)
	google.golang.org/grpc@v1.59.0/server.go:1737 +0xc47
google.golang.org/grpc.(*Server).serveStreams.func1.1()
	google.golang.org/grpc@v1.59.0/server.go:986 +0x86
created by google.golang.org/grpc.(*Server).serveStreams.func1 in goroutine 75
	google.golang.org/grpc@v1.59.0/server.go:997 +0x136

But running tapcli --tlscertpath ~/.lit/tls.cert --rpcserver=localhost:8443 --network=testnet assets mint batches still results in a crash: [tapcli] unable to list batches: rpc error: code = Unavailable desc = error reading from server: EOF

I updated this branch, can you try it out again? I think marhsalling for batches made before #866, was broken by #866. Should be fixed now.
I had added some assumptions in the marshalling code that all seedlings would have a script key set, which wouldn't be true for batches already stored in the DB before that PR.
Also added an extra check at the beginning of the caretaker so we exit gracefully in case on restart resume issues.

Yes I'm able to run tapcli assets mint batches without any issues on commit 3b3b4864778889cc1542062402e19cac1f66b44b
thank you!


Add back navigator for the solutions

currently, if the user is in any solution and wants to go back to select another solution, there is no way to go back, and have to go solution from the sidebar. It will be easier for the user to go back from the same page.

done and waiting for review

applied change instead of calling component in each solution i will just check on path from component.
so there won't be duplicated code.
waiting for review.

working on another change is to add small navigation bar with breadcrumbs.
add back button in weblets.
nav bar can be used anywhere.

Work Completed:
Added second navigation bar leads to solutions page.

Work Completed:
updated colors on navigation bar in both dark and light mode to be more clear.

Work in Progress (WIP):
Trying to solve that when use chooses solution at bottom of solutions page and go back to solutions page, user will be redirected at same position at bottom of page.

Work Completed:
Solved issue of scrolling down, so now when user navigates to solutions pages will always be navigated at the top.

Can't we add a back button on the left side? I have been using the site for a while, and it wasn't clear that the solution is the back button.

Work Completed

Added back button at most right so user can go back from it also

Work Completed

Swapped positions of path with button.

please check https://github.com/threefoldtech/tfgrid-sdk-ts/pull/1623#issuecomment-1848912190


remove spurious debugging print

[x] I have removed a debugging leftover from LayerSpec

Comments
No relevant changes

bors r+


Error URI order

Hi!
I'm using your library for a coap-based client.
I created 2 db_path with different uri: /Mobius/test_coap/pontoon_titania/data and /Mobius/test_coap/pontoon_titania/camera/blue (oneM2M compliant).
When i sent request to data, my request is received from server correctly and the URI order is:
Mobius, test_coap, pontoon_titania, data.
But when i sent request to blue, server get error and the URI order is:
Mobius, pontoon_titania, camera, blue, test_coap (so url si /Mobius/pontoon_titania/camera/blue/test_coap that doesn't exist).
Why am i facing this error?
Thanks!

@Saifer707 Hi! Have you been able to resolve the issue in the end? Or was it still a problem?

@JKRhb Hi! Unfortunaly, my job on Mobius was stopped. I didn't try to resolve the issue anyway, I'm sorry. If you have good news, please tell me!


CurseForge is out of date

The curseforge does not have an accessible version of CCA for 1.18.1, even though 4.0.1 has already been released for a while.

Right, it's back with 4.1.0 and up


Clean up a few things for ReFlar

Cleaned up README
Updated LICENSE
Updated extension icon
Compiled dist JS

Nice, thank you :) I'll merge it asap


Jae/chartgen

Remove the auto-release in the current workflow. Going forward, it'll be a manual trigger when a release is made via GitHub.


[FLINK-26953] Introduce Operator Specific Metrics

Adding Operator specific metrics. For the time being FlinkDeployment and FlinkSessionJob related metrics are introduced. The metrics are grouped by namespace, and metric groups grow dynamically as new CRs show up in new namespaces.
localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkDeployment.Count: 1
localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkDeployment.DEPLOYED_NOT_READY.Count: 0
localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkDeployment.DEPLOYING.Count: 0
localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkDeployment.ERROR.Count: 0
localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkDeployment.READY.Count: 1
localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkDeployment.MISSING.Count: 0

localhost.k8soperator.default.flink-kubernetes-operator.ns.default.FlinkSessionJob.Count: 2

localhost.k8soperator.default.flink-kubernetes-operator.ns.ns1.FlinkDeployment.Count: 1
localhost.k8soperator.default.flink-kubernetes-operator.ns.ns1.FlinkDeployment.DEPLOYED_NOT_READY.Count: 0
localhost.k8soperator.default.flink-kubernetes-operator.ns.ns1.FlinkDeployment.DEPLOYING.Count: 0
localhost.k8soperator.default.flink-kubernetes-operator.ns.ns1.FlinkDeployment.ERROR.Count: 0
localhost.k8soperator.default.flink-kubernetes-operator.ns.ns1.FlinkDeployment.READY.Count: 1
localhost.k8soperator.default.flink-kubernetes-operator.ns.ns1.FlinkDeployment.MISSING.Count: 0

fyi @wangyang0918 @Aitozi I added a simple counter for the FlinkSessionJob too, let me know what you think.

We discussed offline with @morhidi and agreed to refactor the metrics related logic into a single MetricManager component to avoid polluting the controllers with the details. That should be included here before merging :)

@gyfora I've refactored the code according to your request, PTAL


Feature request - make pop-ups actual pop-ups/floating windows

Hey guys,
I'm just trying this plugin so see if it could be modern Fugitive replacement. One thing I realized is that many windows are called "pop-up"  (e.g. commit, stash, ...) but they aren't really. At least not for me using NeoVim. Is the naming "wrong" or is it a hint that it is only implemented for Vim (I think to remember that there this feature is called pop-up while floating windows in NeoVim). If none of these applies it would be cool to actually make these windows pop-ups/floating.

The name popup comes from magit before they renamed it to transient.

If none of these applies it would be cool to actually make these windows pop-ups/floating.

Should be possible 👍

Quick question: is this plugin meant to be NeoVim only or does it require to always support both Vims?

@weilbith Neogit is Neovim only. We're making heavy use of Neovim's lua integration, the exposed event loop of libuv and Neovim's api for creating signs and floating windows.
Neogit's core idea could potentially work in standard vim, but there are no plans for that and would essentially entail a complete rewrite of the plugin, seeing as we'd need to port the code over to viml.

Okay, perfect. Then this whole feature is way simpler to implement. :+1:

Yep :) This is also kind of related to #63, so we might want to reconcile these 2 and find some common ground for a solution.

@RianFuro based on my current understanding these two issues have different problems. This one is just about modifying one buffer to be a floating window and the other one is about being able to split a floating window (which currently is not possible I think?)

@TimUntersberger Yeah, the being not possible part is what makes those issues semi-related again.
One way to work around the problem would be to "manually split" the floating status buffer, by reducing it's height and opening a second floating window below; which is where the issues would overlap.

Stash is interesting, eventho it works I need to reopen neovim to see the changes.


versioning support

Current usage looks something like this:

def test_on_versioned_s3(tmp_s3_path, versioning):
    assert tmp_s3_path.fs.version_aware
    ...

def test_versioning_generic(tmp_upath_factory):
    tmp_versioned_path = tmp_upath_factory.mktemp("s3", version_aware=True)
    assert tmp_versioned_path.fs.version_aware

Only gcs and s3 are currently supported.

Codecov Report
Base: 87.28% // Head: 68.06% // Decreases project coverage by -19.23% :warning:

Coverage data is based on head (a6de266) compared to base (407dbad).
Patch coverage: 76.66% of modified lines in pull request are covered.

:exclamation: Current head a6de266 differs from pull request most recent head 4db746f. Consider uploading reports for the commit 4db746f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #100       +/-   ##
===========================================
- Coverage   87.28%   68.06%   -19.23%
===========================================
  Files          11       12        +1
  Lines         346      382       +36
  Branches       54       56        +2
===========================================
- Hits          302      260       -42
- Misses         35      118       +83
+ Partials        9        4        -5

Impacted Files
Coverage Δ

src/pytest_servers/fixtures.py
60.78% <64.28%> (+6.23%)
:arrow_up:

src/pytest_servers/factory.py
66.32% <66.66%> (-20.20%)
:arrow_down:

tests/test_fixtures.py
75.00% <75.00%> (ø)

src/pytest_servers/utils.py
43.13% <83.33%> (-41.18%)
:arrow_down:

src/pytest_servers/s3.py
100.00% <100.00%> (ø)

tests/test_factory.py
100.00% <100.00%> (ø)

tests/test_utils.py
100.00% <100.00%> (ø)

src/pytest_servers/gcs.py
34.61% <0.00%> (-65.39%)
:arrow_down:

src/pytest_servers/azure.py
45.16% <0.00%> (-54.84%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@dtrifiro Sorry, I accidentally merged main into your branch 🙁 Could you rebase, please?

Nice! But how could I write a test that works with both versioned and unversioned buckets?

@rlamy
Something like this will work:
@pytest.mark.parametrize("version_aware", [False, True])
def test_stuff(tmp_upath_factory, version_aware):
    tmp_path = tmp_upath_factory.mktemp("s3", version_aware=version_aware)
    assert tmp_path.fs.version_aware
    ...

If that's too clunky, we could modify the versioning fixture so that it works like this:
@pytest.mark.parametrize("versioning", [False, True], indirect=True)
def test_stuff(s3_tmp_path, versioning):
    assert tmp_s3_path.fs.version_aware is versioning
    ...

Currently it is enough to use the versioning fixture to enable versioning support for the s3_tmp_path and gcs_tmp_path fixtures.

I don't have strong opinion to this PR, but I think there are two parts to versioning: one on the server side, and other on client-side.
The server already supports this right? And the client side is as simple as following on dql side:
def s3_path():
    return tmp_upath_factory.s3(..., version_aware=True)

And this is already possible, right?

@dtrifiro Actually, I'm more interested in making a fixture that handles bucket creation, but I guess something like this works:
@pytest.fixture(scope="session", params=[False, True])
def version_aware(request):
    return request.param

@pytest.fixture
def cloud(tmp_upath_factory, version_aware):
    tmp_path = tmp_upath_factory.mktemp("s3", version_aware=version_aware)
    return do_something(tmp_path)

And the parametrisation can be overridden with:
@pytest.mark.parametrize("version_aware", [True], indirect=True)
def test_versioned_only(cloud):
    assert cloud.is_versioned

So that works.


Unable to connect a second set of tracker on another PC/Server on the same network.

My wife and I bought a set of 5+3 each. She started her setup and enabled her tracker. As I was doing the same, I found out that instead of adding the tracker to my list, it just stalled.

Later on, we found out that my trackers were instead connected on my wife's PC/Server instead of mine, despite the Tracker being connected physically on my PC and not hers.
After communicating this in the discord server, it's been suggested that SlimeVR Server just have one instance and therefore, the first server to open is the only one to work. (Asuming they both just use the same port to work.)
This brings me to this question, how would I set MY server to a different port OR dissociate it from my network so that I can pair an use my tracker at the same time as my wife, being on her own server/PC?
Eager to recieve some help so that I don't feel like I've been cheated of a few hundred bucks.

we have fixed this in the current code but we havent released the new version yet, but we are thinking of doing it soon
This is the relevant fix if you are interested #900


Add option to compute ci for function field

Figure1 shows plot_ci (plot credible interval) for KLExpantion type samples. Figure2 shows plot of the samples themselves. The discrepancy between how the ci looks and how the samples look is because for computing the ci, the ci is computed on the coefficient and then converted to function values (par2fun). We want to add an option for plot_ci to compute the ci for the function values rather than for the coefficients (Figure3).

Figure1

Figure2

Figure3

I like this idea. We should consider if there are other use cases for computing statistics on the function values rather than parameters. For example, I could imagine it would be useful to compute the mean, std, ci etc. and plot the mean, std, and ci on both parameters and function values.
In a way pretty much any statistics could be useful to do on either parameters or function values. Perhaps Samples should have a method to convert (or maybe create a new samples object) with the function values rather than samples.

Thanks @nabriis for your comment. Agreed! for plotting ci for example, I needed also to covert the samples to function values before computing the mean. and this can apply to other statistics.
I am thinking of two approaches:

Add a flag in these methods: to_func for example. and possibly cash the funvals when computed.
Without adding a flag, just do something like: funval_samples= samples.funvals and apply methods on the new object funval_samples.

Let's bring this up in the stand-up today.