macOS dock icon is miniscule

If you zoom way, way in you can see that it's in between VirtualBox and Activity Monitor:

VSCode Version: Version 1.30.0-insider (1.30.0-insider) c72cb129f2a0b8117c9b01f3767026041d7d1d31
OS Version: macOS 10.14.

Steps to Reproduce:

Launch VSCode.
Observe the dock icon.

Does this issue occur when all extensions are disabled?: Yes

Restarting the dock with killall Dock seems to have reset the icon to normal size. Still not sure how or why it ended up tiny in the first place.

That's... weird. Let us know if that happens again.

Happens to me too. Restarting VS Code does not help. killall Dock does.

Just happened to me on stable version. Lots of time could not figure out what it is.
VSCode Version: 1.29.1
OS Version: macOS 10.14

This just happened to me, just after upgrading and restarting VS Code.

I am also having this issue.  I have:

disabled all extensions
ensured I am running the current stable build: 1.29.1
removed all themes, am running the default Light (Visual Studio)
removed all custom settings from settings.json
quit the app and relaunched

See screenshot:

Anyone still seeing it, try killall dock or restarting the mac.

Yes, killall Dock fixes it.
Here's hoping there will be a fix that doesn't include restarting your dock or your Mac to have an icon work.

Is there an open dupe for this @bpasero or @joaomoreno? I also see https://github.com/Microsoft/vscode/issues/59578

Sounds like a bug in Mojave to me, but I never saw that.
Are people seeing any suspicious output when running "code --verbose"?

And has anyone seen it with any other apps?

I have not seen it in any other apps. This post on Stack Exchange seems to be indicating an identical issue:
https://apple.stackexchange.com/questions/338881/there-is-a-tiny-icon-on-macos-dock-that-is-not-clickable

Just got this again on VSCode Version 1.31.0-insider (1.31.0-insider) and macOS 10.14.2.

@roblourens I took a copy of my com.apple.Dock.plist before and after. I have diffed it but if I'm honest I have no idea what I'm looking at!
It seems as though some of the different lines might be caused by the fact that the order changed but they’re both here for you if they might mean anything to you
https://gist.github.com/leggsimon/58e9da1708a2d0f4c47f83fde1e1f5da

It's happening for me too. killall Dock does work, but it's an annoying bug.

Experiencing this issue still with macOS 10.14.2 and VS Code 1.31.1

I have this issue with macOS 10.14.3 and VS code 1.32.3

This issue continues to pop up, and it's very annoying. Latest versions of everything.

Same issue here with macOS 10.14.4 and VS code 1.33. killall Dock fix it.

Not much of a difference upon Dock restart. I was expecting a lot of noise, but no:
--- b.plist	2019-05-11 16:56:15.000000000 +0200
+++ a.plist	2019-05-11 16:56:22.000000000 +0200
@@ -1,27 +1,27 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
 	<key>autohide</key>
 	<false/>
 	<key>last-messagetrace-stamp</key>
 	<real>579029752.02692497</real>
 	<key>loc</key>
 	<string>en_GB</string>
 	<key>mod-count</key>
-	<integer>2173</integer>
+	<integer>2174</integer>

Me too, just updated.

Fix it please.
Yes, I can do killall Dock and it works,
but issue catches humans again and again

This is extremely annoying.

I am having the same issue. macOs 10.14.5 VS Code: Version 1.36.0 (1.36.0)

Ever since the icon rebrand recently I haven't had this issue. (I'm on 1.37.0-insider at the moment.) No idea if that means it's actually been resolved, but for whatever reason it hasn't happened to me yet.

@samuela , I similarly thought so just as well, before this morning, since when I have the same problem as with the old icon. So, no worries, it will happen eventually. killall Dock is our friend.

"Watching the Earth between the Saturn and the Jupiter"

I get this all the time. Doesn't happen to any other app, just VSCode.

Still happening macOS 10.14.5, VS Code Version: 1.37.1
Screenshot (adorable but annoying):

LOL @ this still happening on 1.38.0

killall Dock works - showed up after a macos restart recently.

killall Dock works
VSCode version 1.38.1
MacOS version 10.14.6 (18G95)

killall Dock works
VSCode version 1.38.1
MacOS version 10.14.6
noticed it happening after a hard reboot of the system.

Same for me
1.39.1
10.14.6

I added the "help wanted" label recently as I am clueless what this is. If anyone has contacts to Apple devs to ask for help that would be cool 👍

Same for me
1.39.2
10.15

Same for me
VS Code: 1.39.2
Mac: 10.14.5
Here's a repo with a before and after of ~/Library/Preferences/com.apple.Dock.plist. It's in binary so git diff wasn't very helpful, but hopefully it's of use to someone (@roblourens): https://github.com/aliblackwell/vscode-broken-icon

@aliblackwell can you explain what exactly this diff is telling? Are you suggesting that the diff would reveal what setting the dock was changing to to make the issue go away?

Hey @bpasero this was posted in response to @roblourens' request (https://github.com/microsoft/vscode/issues/63068#issuecomment-444548823) for a diff. I'm not a Mac developer so I couldn't really tell you what it's telling – I just posted it on the off-chance it was helpful to someone qualified to fix this bug!

But yes @bpasero, it's essentially a before and after of my com.apple.Dock.plist where in the state before running killall Dock the icon was tiny, and the state after it was fixed.

Happens to me on VSCode Version 1.39.2
Details Here:
Version: 1.39.2
Commit: 6ab598523be7a800d7f3eb4d92d7ab9a66069390
Date: 2019-10-15T15:33:00.827Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.6.0

It gets resolved only by doing killall Dock

Haven't seen it for a while but after updating to 1.40.1 it happened again. killall Dock fixed it.
Version: 1.40.1
Commit: 8795a9889db74563ddd43eb0a897a2384129a619
Date: 2019-11-13T16:47:44.719Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.7.0

Same thing.
VS Code 1.40.1
macOS 10.15

Happened to me as well, super cute. (but slightly unproductive)

Happened over here too
MacOS 10.14.5
VS Code:
Version: 1.40.2
Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
Date: 2019-11-25T14:52:45.129Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.6.0
killall Dock fixed it

Happened to me today:
VS Code version: Code 1.40.2 (f359dd69833dd8800b54d458f6d37ab7c78df520, 2019-11-25T14:52:45.129Z)
OS version: Darwin x64 19.0.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
3, 2, 2

Memory (System)
16.00GB (1.03GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

aws-toolkit-vscode
ama
1.4.0

python
ms-
2019.11.50794

I have returned to the error after killall Dock previously "fixed" it. I noticed that the icon is tiny once again after a number of months where it didn't appear to be happening.  However, I often don't use the dock, and use Alfred to launch apps, then Cmd+Tab to switch between them.  I just happened to notice it today when the Dock popped up.

VS Code 1.40.2
OS 19.0.0

Add me to the list of those experiencing it
Version: 1.40.2
Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
Date: 2019-11-25T14:52:45.129Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.0.0

Still experiencing tiny icon problem in dock with version information below.  killall Dock repairs the problem until the next time it occurs.

Version: 1.41.0
Commit: 9579eda04fdb3a9bba2750f15193e5fafe16b959
Date: 2019-12-11T17:58:38.338Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.0.0

It happened just now after vscode update. Dock restart has fixed the problem

Same for me.

Version: 1.40.2
Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
Date: 2019-11-25T14:52:45.129Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.2.0

Is this normal?

Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:57:51.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.7.0

I had this happen regularly, but now the icon is not in the dock at all. Not even the running indicator underneath it.

#metoo I have never seen this with any other app in all my years running macOS, and it just happened to me also. No one has a clue?

happens to me as well. killall Dock works. Thanks.

I just had this issue. killall Dock fixed. Thanks.

same here on:
Version: 1.43.0-insider
Commit: 4c9161a3f125f5a788aafa73a4ecfcb27dcfc319
Date: 2020-02-14T05:26:38.779Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
killall Dock fixed it, but really annoying - and this thread wasn't easy to find :)

same issue:

Version: 1.42.1
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:44:27.652Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.2.0

killall Dock fixed it

Same here. killall Dock fixed it too.

I am seeing this issue too. I just started evaluating whether I to switch to VS Code from Sublime and this is not a good start. Ive used Macs for 20+ years and never had this happen with an app.

Well, that's a bit unfair, @newlegendmedia, I've used macs for 10 years and discovered all kind of weird things. I moved from Sublime to VSCode, too, and I would not go back ever again. It is so much more lightweight and there is an extension for everything!

@codepo8 I would agree except this appears to have been reported over a year ago.

It's ridiculous. Took me a few days to understand what was actually happening. It's funny, I'm looking at switching back to Sublime. My text is rendering weird, and this seems like just another item in a growing list of weird things that this web-app-pretending-to-be-an-app does poorly (and seemingly unfixable) that native apps do not.
Of course, I say that, but fast-forward to 3 days after switching: "I'm BAAACK!" We'll see...

Same issue here. Running killall Dock fixed it (for now).
Version: 1.43.0
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:34:44.548Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0

Restarting the dock with killall Dock seems to have reset the icon to normal size. Still not sure how or why it ended up tiny in the first place.

happen to me either on the latest stable version

I experienced this first time now, in macOS Mojave 10.14.6. As for others, killall Dock fixes the issue for me too.
vscode:
Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:41.240Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:41.240Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
Happened again.

it happens for me too
Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:41.240Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
killall Dock fixes it

I have the same issue :D
Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:41.240Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0

Running killall Dock fixed it.

First time for me seeing this issue. But I have no running indicator, but the icon does appear in the app switcher. Nice to see this has been an issue for two years.

Version: 1.43.2
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:34:57.037Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0
``` same issue here. Spent 2 hours finding the icon on my Dock.

Version: 1.43.2
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:34:57.037Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

Had the same issue. Running killall Dock fixed it.

This is an issue with Electron. Colleague ran into this today after reinstalling our newly built Electron 8.x app in production. If I find a workaround before the VS Code team does, I'll make certain to share.
We currently utilize Electron's app.dock API which is not playing too nicely with macOS Catalina. A random combination of app.dock.show(), app.dock.hide() and app.dock.* can trigger this dock-breaking payload. Needless to say, this API's are critical to an Electron app feeling like an app and we can't just stop using them.
A very humous albeit frustrating bug. Hope to see it through soon.

I've been bitten as well:
Version: 1.44.0
Commit: 2aae1f26c72891c399f860409176fe435a154b13
Date: 2020-04-08T08:23:56.137Z (6 days ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0
macOS Catalina v 10.15.4
Something interesting to note in my case is that it started happening immediately after adding a secondary monitor.

I've been bitten as well:
Version: 1.44.0
Commit: 2aae1f2
Date: 2020-04-08T08:23:56.137Z (6 days ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0
macOS Catalina v 10.15.4
Something interesting to note in my case is that it started happening immediately after adding a secondary monitor.

I also use both the internal screen and an external monitor.

I'm using an external monitor and have nearly identical specs to @austinjhunt, which leaves me scratching my head as to why I can't trigger this bug?

It happened to me on a macbook pro. It's been like this for a while actually,  but I just didn't see the small icon and I thought vscode was just gone from the taskbar for some obscure macos reason and so I got kind of used to it. (I tried googling vscode missing from dock)
I tried to diff the plist mentioned above but the only thing that changed was an increment of <integer> in the dict entry. (I had to convert the binary plist to xml)
I have no external monitor.
Version: 1.44.0
Commit: 2aae1f26c72891c399f860409176fe435a154b13
Date: 2020-04-08T08:23:56.137Z (1 wk ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.2.0

Just thought I'd share this with the internet:

I'm using Catalina 10.15.5 (beta) and the problem persists. Issuing killall Dock fixes it fortunately.

Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:07:18.473Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.6.0
killall dock fixes this

For the record, I just had a similar issue where the vs code icon didn't appear in the dock at all. There was no tiny icon and no dot on the bottom to indicate a running app (so I wasn't just overlooking the icon). com.apple.dock.plist did show that there should've been something there for vs code.
killall Dock fixed it.
Just thought I'd mention it in case someone outright has no icon.

Happened to my mac too.

See that miniscule vscode in the dock.
Version: 1.45.0
Commit: d69a79b73808559a91206d73d7717ff5f798f23c
Date: 2020-05-07T15:57:33.467Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

Can people seeing this issue please report back if it reproduces in todays insider build were a change went in yesterday:

Download or update from https://code.visualstudio.com/insiders/
Check Help > About you are on Commit: e88b8d32aa7233f6cb3665f6dae9fa78b1e8aafb

Thanks

ping @samuela

@bpasero I'll keep a look out for it!

Closing optimistically, we can reopen if this comes back.

Can people seeing this issue please report back if it reproduces in todays insider build were a change went in yesterday:

Download or update from https://code.visualstudio.com/insiders/
Check Help > About you are on Commit: e88b8d32aa7233f6cb3665f6dae9fa78b1e8aafb

Thanks

@bpasero Thanks. Looks good for me so far ...
Version: 1.46.0-insider
Commit: da3bf754c3c0eabda1dc80ed9d627679ee560697
Date: 2020-05-19T10:04:14.981Z (8 hrs ago)
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

I am not on insider build, so cannot check the above commit. Still happening for me with the latest update though:
Version: 1.45.1
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:33:47.663Z (1 wk ago)
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

+1
Version: 1.45.1
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:33:47.663Z (1 wk ago)
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

You need our insiders version to benefit from the fix: https://code.visualstudio.com/insiders/

what's the timeline for this fix to drop outside the insiders build?

~1.5weeks from today.

Just to mention it happened to me but with Azure Data Studio, also based on VSCode.
Their issue: https://github.com/microsoft/azuredatastudio/issues/8107
I tried uninstalling the app, download again and reinstall, but that doesn't fix it.
When it was uninstalled, the icon still appeared in the Dock (in the Recents list).
Reopening Finder doesn't work. killall Dock works tough.
I'm on Mojave 10.14.6 (18G4032)
Azure Data Studio
Version: 1.18.1
Commit: 5b3b97f4a34018f3b37b0fce30e32f2af7ad78fa
Date: 2020-05-26T21:11:42.467Z (1 wk ago)
VS Code: 1.45.0
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

killall Dock helps

Optimistically adding verified label based on users comments with VS Code insiders

This has just occured to me for the very first time. Only happens when I have certain plugins installed. (postgres ones)

@bpasero For others affected with this issue in Electron, would you kindly point to the specific commit or code changed?

@alectrocute the change is https://github.com/microsoft/vscode/commit/f8f0c0ec5499cf5d210b12672d71784e93d42f0d and it was basically not using any app.dock.* methods whatsoever.

got a recent update and the issue went away for me:
Version: 1.46.0
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-10T08:59:06.977Z (1 wk ago)
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0


feat: check for available node resources before building injector pod

Description
Addresses https://github.com/defenseunicorns/zarf/issues/2144 to check if node has enough resources before the injector runs
Related Issue
Fixes #2144
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

Description
Addresses #2144 to check if node has enough resources before the injector runs
Related Issue: #2144
Fixes #2144

Resolved all your suggestions in latest commit, thanks!

Pushed those changes!

@lucasrod16 I would tend to agree with you on that. Wasn't sure about creating new global variables but not changing the function signature would be more ideal since it's public facing and would be a breaking change for usages.

@chrishorton thanks for submitting this PR 🙂

I think we should try to avoid changing the function signatures of GetAllImages and GetImagesWithNodes because they are public facing APIs.
var (
	injectorRequestedCPU    = resource.MustParse(".5")
	injectorRequestedMemory = resource.MustParse("64Mi")
	injectorLimitCPU        = resource.MustParse("1")
	injectorLimitMemory     = resource.MustParse("256Mi")
)

These variables are static and will likely not change often, so we could move them to the k8s package, make them public, and use them directly in the functions that need them instead of passing them in as parameters.
@Racer159 @Noxsios thoughts?

I suggested this direction since it would be relatively easier to implement than a larger refactor that is likely warranted for how the injector pod gets built - we only use these functions for this purpose so they could ultimately be tailored more to the injector node selection process and removed from k8s if we wanted.  Currently IMO it would make more sense to move things into cluster than to k8s because no Zarf-specific logic is in k8s today (the only "zarf" thing it imports is helpers and that also has a rule to not import anything else from Zarf.
The injector* variables are global to the cluster package so we could mess things up in the future but they are private so people importing cluster won't be able to mess them up without something like go:linkname which is why I was ok with them being there for now (would just be up to the Zarf maintainers to make sure that they aren't modified).
I do agree the function signature is a little odd taking in the node resource quantities though so we could refactor both GetImagesWithNodes and GetAllImages into a function with a better signature (potentially something like func  GetImagesFromAvailableNodes(timeoutDuration time.Duration, minResources corev1.ResourceList)  (ImageNodeMap, error) that would check all resource types and be a bit better named.

For historical context, these functions are also a bit appendix-like - they had more of a purpose back when Zarf performed more node checks on init but we removed some of those to reduce the permissions Zarf needs to run in a cluster.

That would work. When I was working on this, trying for an elegant solution (not changing func signatures) everything produced a circular dependency because of how the logic is intertwined and used in the two packages.

For historical context, these functions are also a bit appendix-like - they had more of a purpose back when Zarf performed more node checks on init but we removed some of those to reduce the permissions Zarf needs to run in a cluster.

I think this is also a good reason to refactor getAllImages and GetImagesWithNodes out of the k8s package.
Would be happy to work on this, if a new issue is created to refactor/migrate.

@chrishorton thanks for submitting this PR 🙂

Glad I can help a bit! I'm struggling to manually deploy a lot of our software over an air-gap so any tooling that helps is gold to me :D

I don't have much to add aside from echoing that the relationship between pkg/k8s and pkg/cluster needs to be re-evaluated. A bit ago we moved pkg/cluster from internal to pkg (https://github.com/defenseunicorns/zarf/pull/2162) to support external usage of cluster. IMO cluster should be the de-facto library export and k8s's functions should be merged in (as cluster is a utility for interacting w/ Zarf specific cluster needs.). Users should be using the Kubernetes K8s lib otherwise.
Doing some cursory checks, I can also see that there are some public receivers on k8s that are not used in Zarf, IMO those should be removed during this refactor (yes a breaking change, but 99% of them are bare abstractions on top of the core k8s lib).

Created this issue to capture the above feedback - https://github.com/defenseunicorns/zarf/issues/2222 (feel free to pick it up if you want @chrishorton !)
Going to approve this as is for now though with the intent that the tech debt gets addressed in the future.


Add a new collector, prfDist, for distribution port statistics

The statistics include the number of packets sent and receive on all
distribution ports and the idle time in both send and receive
directions. The latter can be useful when investigating netsplits.

The CI failure with R15B03 is due to an OTP bug. erl_bif_types should say t_sup([t_pid(), t_port()]) instead of t_sup([t_pid(), t_port]).
I can't fix or work around the problem, because Dialyzer will crash on any code calling erlang:system_info(dist_ctrl), and I can't avoid using this specific BIF.

I'll remove r15 from travis


License missing

Your project looks nice and well-written, but there is no license info.
Please be so kind and publish your project under a (hopefully) permissive open source license (MIT, GPL, ...), as the lack of such makes your project rather useless.

Added LICENSE.md to the code.


Batch size: Not a valid integer value. Number None must be at least 1.

After most recent commit I always get the following error when creating a new Classification Model:

And the network parameters are (automatically) set as:

Reverting to 7f484b9bfc0181161790368dbd4ab13e31fefd7d fixes this

Duplicate of https://github.com/NVIDIA/DIGITS/issues/717.


[WIP] Adding the Task Manager info to the UI doc

Adding the step showing the new Task Manager tab capabilities.
Tracked under MTA-3110.
The latest preview:

Analyzing an application
Configuring and running an application analysis
Reviewing analysis details
Downloading an analysis report
Controlling MTA tasks by using Task Manager
Reviewing a task log
Controlling the order of task execution

I would like to see more details about how the user can actually interact with the task manager. This is also in the wrong section of the docs.
Could you provide more detail on how the user can navigate the task manager page?

I would like to see more details about how the user can actually interact with the task manager. This is also in the wrong section of the docs.
Could you provide more detail on how the user can navigate the task manager page?

Thanks for your input, @dymurray!
Hi @mguetta1, as per Dylan's input, the section is wrong.  So, to determine the section, I need to know when exactly would the user want to interact with the Task manager? We can also discuss which details the user would benefit from.

@mguetta1, I attempted to provide some changes to the existing procedures and also created a new section as we discussed in our meeting. Could you please check? Let me know if you need me to send a preview of the doc :-)
Thank you!

@mguetta1, I added the screenshot (not visible in the html preview, unfortunately) to the procedure and applied our suggestions. Please, could you check this PR once more as the final QE review? If you have no further suggestions, I'll send it to Dylan :-)

Hi @mguetta1, thanks for your suggestions! I incorporated your feedback and updated the preview links above. Is there anything else I should fix for this PR or is it ready in your opinion?
Thanks!


fix: RSSfeed get added without backend connection

Fixes #197
Describe the changes you have made in this PR -
Gist: Checking if the backend is connected when clicking on the save option if not show a snack bar with a msg.
Implementation:

Created a checkClientOnline function that makes calls to the backend and checks whether the status code is 200 or not.
The function is implemented in the save button of the RSS feed bottom sheet

Demo of the changes-
https://github.com/CCExtractor/Flood_Mobile/assets/91112485/4d4dee61-b75e-48f0-bd27-29a12291f958

@amitamrutiya2210 check my comment in files changed tab

I am not able to see any comment on files changed tag.

check this line. What do u mean by 43?

@amitamrutiya2210 resolve the conflicts as well

 check this line. What do u mean by 43?

I think I mistakenly did this. There is no such meaning to that. I have fixed this issue, so now you can proceed with the review.


Feature Request: Only center non-pinned items

I don't know if this is even possible, but I think it'd be more visually consistent if only non-pinned icons were centered (as an option). This would leave the pins aligned with the system icons (search/cortana/task view), and leave running applications centered/separated visually, which I like the idea of.
Thanks for the tool! Didn't even know I wanted something like this.

I have tried to move them individually but i can't get them to move anywhere. They just stick together, i don't think it's possible :(


[doc/book] Add introduction page and other enhancements

Preview: http://code.behnam.es/rust-cargo/book/

Reorganize files to use folders instead of numbered files. This will allow us to add new sections and pages without breaking a numbering system or the URLs.

Rename "Cargo In Depth" to "Cargo Reference", as those pages are considered the reference for cargo behaviors.

Add introduction.md, as the landing page with the book title and Cargo logo on top.

Expand installation.md: Import install text and links from https://crates.io/install, as we
want to drop that page and redirect it to here. (See https://github.com/rust-lang/crates.io/issues/1029)

Sync SUMMARY.md titles (and sub-pages lists in section pages) with page titles and fix some wordings and casings.

Expand Introduction and section pages with some intro text.

Set lang for some of the code blocks.

Add book.toml to get the title in HTML head title, etc.

Tracker: https://github.com/rust-lang/cargo/issues/4040

cc @alexcrichton, @carols10cents, @istankovic, @steveklabnik.

r? @alexcrichton

@bors: r+

:pushpin: Commit 2ad45a5 has been approved by alexcrichton

:hourglass: Testing commit 2ad45a563ef60819360ecd54d6eccc5b588e6401 with merge 55695e53e53584efa8f8acbbd399826199242624...

:broken_heart: Test failed - status-travis

This is so awesome, thank you so much for working on this stuff!

@bors: retry
On Fri, Sep 1, 2017 at 11:25 AM, Steve Klabnik<EMAIL_ADDRESS>wrote:

This is so awesome, thank you so much for working on this stuff!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/cargo/pull/4455#issuecomment-326624444, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PWvWo-7SD8AF-PX0D5ANLipjspfks5seC_tgaJpZM4PJdgT
.

:hourglass: Testing commit 2ad45a563ef60819360ecd54d6eccc5b588e6401 with merge 61ca3022bca2c9e627d2ee523d7bd736e2bcaa2a...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 61ca3022bca2c9e627d2ee523d7bd736e2bcaa2a to master...


fundingmanager: fixes range-goroutine scoping bug

This commit fixes an issue in funding manager startup,
where a goroutine reads from a range value. The method in
question could cause a channel to be announced at the
wrong time.
This may have been a cause for certain channels having
phantom HTLCs before they had even received the funding
locked message from the remote peer.
This is fixed simply by using the locally scoped
variable passed in as an argument to the goroutine.

Potentially addresses #1053


[$1000] Offline - Can't leave public room after send message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login 2 account on 2 browsers
A create a public room and copy share url
B open room url
B force offline
B send message in a room
6, B click header => leave room
B toggle offline => Online, Observed that the public room reappeared in LHN

Expected Result:
public room does not reappear in LHN does not reappear after leaving the room
Actual Result:
public room reappeared in LHN does not reappear after leaving the room
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.45-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/9fda113b-fc3b-4187-9b8e-a4d1cd0d7f99
https://github.com/Expensify/App/assets/43996225/c3b772e6-d11d-4530-8986-9a26d856f616
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690263033683239
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c85f976eb6d66e14
Upwork Job ID:<PHONE_NUMBER>739585024
Last Price Increase: 2023-07-28

Not overdue

@mollfpr bump for review on these proposals thanks

Reviewing

@mollfpr can you confirm if either of the solutions are 👍

Sorry for the delay, the BE changes will take longer to fix, and it's clearly set null to the report; we can do it in the E/App instead.
The proposal from @tienifr looks good to me 👍
🎀 👀 🎀 C+ reviewed!

@laurenreidexpensify, the PR was merged late because I missed assigning another engineer here before I went OOO on Aug 3rd.
@tienifr should still be eligible for the bonus since the PR was ready for review and approved by @mollfpr within 3 working days.

all payments have been issued in Upwork
@mollfpr can you please confirm checklist steps above thanks

Thanks, @laurenreidexpensify I'll complete the checklist ASAP.

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is a one-time bug, so a regression test should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.


EMI Compatibility [Feature Request]

Hey, will Primal Stage will get EMI compatibility in the future? or is that something you will not add?
If not, would you mind if I made a PR to integrate that into your mod?
I wish you a lovely day and thanks for reading <3

Thank you! I wish you a lovely day

Thank you! I wish you a lovely day

Integration added


Added dashed line support for canvas stroke

Added an argument line_dash for stroke which is called by set_dash to allow for dashed lines to be made in a canvas widget for gtk users. I'm not sure if this needs documentation as the PR Checklist indicates.
Fixes #581.
PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

@Connor-Rowland Congrats on submitting your first PR! :+1: Please don't squash your commits, we like to see the history of how you got to your final implementation, silly fixes are OK, we all do them. You are on the right track, but right now your implementation doesn't reset the line dash for a different stroke context. For example, if you set a line dash for Tiberius' head in Tutorial 4, it keeps it set for drawing the rectangle around the text as well, even though they are in different stroke contexts.

Congrats on your first contribution! :heart: :sparkles: :sparkling_heart: :clap: Hopefully the first of many more to come :+1:


Schema errors with OpenAPI documents

Describe the bug
Open API documents into /openapi directory report several schema errors with common validator tools. An example of these is https://editor.swagger.io/.
With errors it's difficult to use API documentation with OpenAPI realated tools.
EDIT: same also for downloadable documentation at https://fairos.io/bzz/fairos.eth/api/
Expected behavior
OpenAPI specifications should not have schema issues.

I'm also having issues with internal file $ref composition with documentation at https://fairos.io/bzz/fairos.eth/api/.
This is an example of received error from tool:
Could not resolve the path '#/paths/~1user~1login/post/requestBody/content/application~1x-www-form-urlencoded/schema/properties/user'.

I'm trying to manually fix the schema, but I'm not able to solve these references, even if this documentation is generated with a single file.
For context, I'm using NSwagStudio trying to generate a client.

There are also semantic errors, very often is used "requestBody" for parameters that should be passed in query. Also with GET and DELETE calls that can't have a body by specifications.

hi, check this https://github.com/fairDataSociety/fairOS-dfs/issues/526


Application Extensions

Someone very clever invented the Padrino::Mounter::ApplicationWrapper. It automatically wraps the class of anything mounted in Padrino, so that, theoretically, you can easily mount a non-padrino app, and it will respond in a nice way to all of the methods that Padrino expects to be there with a mounted app.
To do this, it's a SimpleDelegate. That very much solved the problem from the Padrino angle, where we assume no application author would want to spend any time getting Padrino compatibility.
The issue is, as I'm trying to fix up an easy adapter for Grape in Padrino.. and so far it's a nightmare to get everything working together.  EWWWWW. Why so much shit? Because, when you use SimpleDelegate, the delegated application can override a single function, but cannot use any of the other predefined functions.
For instance, here's some code in Padrino's ApplicationWrapper:
      def dependencies
        @__dependencies ||= Dir["#{root}/**/*.rb"]
      end

      def prerequisite
        @__prerequisite ||= []
      end

From what I've read in the code, I have no idea what the actual difference is between prerequisites and dependencies.... But, in this case, I know the Reloader is referencing prerequisites (plural, but that was another issue), but the files I want reloaded are in dependencies. So, you'd think in my Grape app, I could just do...
    def prerequisites
      dependencies
    end

But, nope. You can't. You see, this class has no idea about who or what is wrapping it... which is just a reference to this class. I can't call the nice default dependencies method from ApplicationWrapper. To get this to work, I need to copy and paste the already written function. BOO!
Or, I wanted to add another line to the setup_application! method, but when I do that, I can't call super. I have to copy and paste.
NOoooooo!!!!
I recommend that we build an ApplicationMethods module, allow that module to get included into the ApplicationWrapper. Then, in my application, if I want to inherit and customize the methods, then I can just include the same set of methods and live my life out in happiness.
Patch following.

This is a first implementation for super method.


View nested within a  must ave width and height

Hi,
I get this problem with my Markdown file.
Please note that with the sample in the Readme in works.

What was the markdown text causing this bug?

Here's a sample text (same structure, I just invented a language due to NDA):
https://pastebin.com/eu6pUi6k
At the moment I solved it using react-native-easy-markdown.

Hi! This should be fixed at the same time as #60


Added a New Algorithm Wahaj Raza

Thanks for reading my PR

Just add the time complexity and will close the request.


Completion of error handling

Would you like to add more error handling for return values from functions like the following?

pa_mainloop_new ⇒ InitCNFAPulse
strdup ⇒ InitALSADriver

I suggest to avoid ignorance of return values a bit more.
Would you like to detect every error situation as early as possible?


Major version warning

Give a warning when wanting to upgrade to a new major version

Hi @cophilot , Loved your work on templify.  Your tool is a game-changer for the community, as it saves us from the tedious task of creating files in the same format over and over again. It's been a huge help in many situations. In your journey of making developers life easier, I want to come along and contribute to take this tool to what you have dreamt of.
In an attempt of that I have tried to solve this issue, and I have mostly done with writing code, I just have doubts in the warning message which we want to show as a part of warning. In my view , we should use two separate warning messages for these cases

When user has explicity mentioned the major version update (through flag)
ex:-

When user are updating to the latest stable version, which might have major version change, something like this

Please confirm , if you are okay with these messages or want some changes in them.
Thankyou,

Hey @RounakJoshi09 , thank you very much for your warm words, I am happy to hear that templify makes your life easier :)
I think both the idea of two warning messages and the messages itself are great and should definitely be added. Only one suggestion: Maybe add the link to the CHANGELOG (https://github.com/cophilot/templify/blob/master/CHANGELOG.md) to the message, to make it easier for the user to look up the changes.
Thank you and I am looking forward to your PR!


Update Example 2 to add .Identity to _$

Whithout the .Idendity the powerwell fail with :
Cannot process argument transformation on parameter 'Identity'. Cannot convert value "XXXXXX" to type
"Microsoft.Exchange.Configuration.Tasks.MailboxLocationIdParameter". Error: "Cannot convert hashtable to an object of
the following type: Microsoft.Exchange.Configuration.Tasks.MailboxLocationIdParameter. Hashtable-to-Object conversion
is not supported in restricted language mode or a Data section."
+ CategoryInfo          : InvalidData : (:) [Get-TextMessagingAccount], ParameterBindin...mationException
+ FullyQualifiedErrorId : ParameterArgumentTransformationError,Get-TextMessagingAccount
+ PSComputerName        : outlook.office365.com
Whit it it work ;-)
Good day

Docs Build status updates of commit 20cb6b8:
:clock10: Full build: the average full build time is 14 min(s) 15 sec(s), this is based on the last 64 build(s) for this repository.
:warning: This is a FULL build due to the incremental build being disabled in configuration file (.openpublishing.publish.config.json in 'live' branch). For more detailed info, please click here.

Docs Build status updates of commit 20cb6b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access/Get-TextMessagingAccount.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Debugging Does not Find Project Dependencies - But it Runs fine.

Environment data

VS Code version: 1.22.2
Extension version (available under the Extensions sidebar): May 2, 2018
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Anaconda 3.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: Custom Package

Actual behavior
Import custom package.  Fails with error below.
PS C:\projects\robolabs\RoboInvestWebApp> cd 'c:\projects\robolabs\RoboInvestWebApp'; ${env:PYTHONIOENCODING}='UTF-8'; ${env:PYTHONUNBUFFERED}='1'; & 'python' 'C:\Users\DrCrook\.vscode\extensions\ms-python.python-2018.4.0\pythonFiles\PythonTools\visualstudio_py_launcher.py' 'c:\projects\robolabs\RoboInvestWebApp' '58210' '34806ad9-833a-4524-8cd6-18ca4aa74f14' 'RedirectOutput,RedirectOutput' 'c:\projects\robolabs\RoboInvestWebApp\Jobs\CalculateExchangeStats\run.py'
Traceback (most recent call last):
  File "c:\projects\robolabs\RoboInvestWebApp\Jobs\CalculateExchangeStats\run.py", line 5, in <module>
    from RoboInvestCore.data.mongo.stocks.symbol import StockSymbol, DayTick, StockWindowMetric, YearMetrics, StockMetrics
ModuleNotFoundError: No module named 'RoboInvestCore'

Sample of some code:
import sys
sys.path.append('../.')
sys.path.append('../../.')
import ssl
from RoboInvestCore.data.mongo.stocks.symbol import StockSymbol, DayTick, StockWindowMetric, YearMetrics, StockMetrics

The Highest level directory contains: Deploy, Jobs, NoteBooks, RoboInvestCore, WebApp.  This run.py is located in Jobs -> CalculateExchangeStats.
The debug launcher for this file is launching from the root of the entire project and not the location this file is actually sourced from as according to its docker configuration.  Even if this file were launched from the top level directory; it Should find RoboInvestCore since it is a top level module and is defined as a module.
Expected  behavior
Import properly
Steps to reproduce:

Create a project with structure as defined and attempt to debug.

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
XXX

Can you provide your settings.json and your launch.json?

Please could you also provide the following info:

Out put from the command python -c "import sys;print(sys.exevutable)"
Please run this command in the terminal
What is the fully qualified path to the anaconda python executable?

Also please note, you can change the directory from which the code runs (cwd), by seeing the cwd in the launch.json file (please do try that).
Finally, please could you also provide the sample code (repo) do we could try this at our end.

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


Update gradle build to fail on license header errors

this change enables the license plugin for Groovy files as well as failing the build in case a license header is missing. Since I know license headers are already missing in some places, the build for this is likely to fail

This change is

@blackdrag As far as I understand it the build would fail if a header is missing. This is fine for me but in that case you should add all the missing headers at least in this PR so that a merge in master will not kill the build. ./gradlew licenseFormat will do it.

Coverage remained the same at 64.853% when pulling acbc9648e2fd0d5311a5669f990eace61d542968 on license_missing_fail_build into 350005b940aab35dc25f9cc9329f5519956b4d37 on master.

Coverage increased (+1.5%) to 66.372% when pulling c7020d2e8124c7273852adeaeb5eba9f6eb24535 on license_missing_fail_build into 350005b940aab35dc25f9cc9329f5519956b4d37 on master.

Coverage remained the same at 66.289% when pulling 1c8f9651db883f614b777be40ec1bff675569592 on license_missing_fail_build into b79b578cbde5e2d10098b1917054b7b0a2fcabad on master.

Can we expect progress here?


Full Page Cache cache 404 on pbxep/payment/redirect/

When it comes that a request on pbxep/payment/redirect/  respond 404 error, the page is full page cached and next request all respond 404 !!

Hi,
we integrated the fix proposal in the new 1.0.8 release.
Regards,
BM Services

Great Thank's


Error parsing Angular.js expressions inside brackets

Hi,
I am trying to use gulp-slim in Angular.js app. I have problem with some Angular expressions inside brackets ().
Taking the working example, this:
small ({{248.12 | currency}})

would not be properly parsed by slim parser (and should result in (248.12USD)). The only solution I have found is to escape expressions like this with apostrophe ' like:
small '({{248.12 | currency}})

I suppose this maybe be fixed by providing Custom Parser Extension (like https://github.com/slim-template/sliq/blob/master/lib/sliq.rb), but I did not manage to make it working. Help will be appreciated.

@matfiz - why are you putting your angular expression in side parenthesis ()?  Slim is taking your () as a set of attributes on the html element - there is nothing @cognitom can do about that - it's the way Slim works.  We/I have tons of Slim markup with Angular, I have never had to put {{...}} inside ().
The only alternative to not using the () I can think of is to force Slim to not see them as attribute delimiters by putting a blank set of attribute delimiters directly after your html element.

@bitencode - thank you for clarification, you are absolutely right that Slim is taking string inside () as set of attributes and that was causing the error! As simple as it is, shame on me I did not see it myself!
Just to clarify: I also have tons of Slim markup with Angular and it works great. Only in this particular case I put the Angular code inside brackets just because I needed to have it formatted like that: (248.12USD), no mysterious magic here ;-)
I close the issue.


Disk var

Tested with bm OCP 4.13 and SNO OCP 4.12 - thumbs up here. SNO OCP 4.13 still pending.

Closing in favor that the original pr was merged #335


remove unnecessary empty build.gradle files

Description
these have no impact, as the targets are added by the parent build.gradle. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area.
see also the discussion on https://github.com/opensearch-project/opensearch-build/issues/99 for some details.
Signed-off-by: Ralph Ursprung<EMAIL_ADDRESS>Issues Resolved
n/a
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:
* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/4242/

* **CommitID:** [17170ec](https://github.com/opensearch-project/OpenSearch/commit/17170ec11c12bc365c930501e0215873777e5eec)

this might be a relevant failure:
FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':distribution:docker:docker-export:exportDockerImage'.
> A problem occurred starting process 'command 'docker''

however, i sadly currently don't have a linux box with docker on it (and a connection to the internet) available to test this... could somebody else maybe briefly try to run this with --info to see more details? thanks!

I just kicked it to see if it's transient.

Does ./gradle :distribution:docker:docker-export:exportDockerImage fail the same way for you locally?

i wouldn't know, our infrastructure doesn't support having a local docker installation 😞  (and the OpenSearch gradle build doesn't support using Docker CLI with a remote docker server)

Does ./gradle :distribution:docker:docker-export:exportDockerImage fail the same way for you locally?

i wouldn't know, our infrastructure doesn't support having a local docker installation 😞 (and the OpenSearch gradle build doesn't support using Docker CLI with a remote docker server)

i've now temporarily patched the gradle build to use Docker CLI, then it works. i've also raised #4883 to get a more long-term solution for this.
i can confirm that the gradle target builds just fine for me locally. so i've now rebased and pushed that again in the hopes that the jenkins build will now run through.

Gradle Check (Jenkins) Run Completed with:
* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/5337/

* **CommitID:** [695b01f](https://github.com/opensearch-project/OpenSearch/commit/695b01f40eb7e8ca2ec728511364c6f3cb462391)

see my comment above: in my environment this gradle target runs just fine, so this might be linux-specific. if somebody with access to a linux box (where they can build this project) could test if they can reproduce this error that'd be great, thanks! otherwise i'm a bit stuck here.
however, this is also not an important PR, it's just a minor cleanup...

rebased in the hopes that this can now be merged (previously it failed with some unrelated false-rejects...)

this failure seems to be a false reject, i can run the specified gradle target locally with no issues:
* What went wrong:
Execution failed for task ':distribution:docker:docker-export:exportDockerImage'.
> A problem occurred starting process 'command 'docker''

@rursprung: Are you still working on this PR ?

not sure what i can do here if it always hits false rejects... (i don't think that there was a single PR i tried to contribute to the OpenSearch repo which didn't get hit with several false rejects before passing through CI - it's not exactly encouraging to contribute this way 😞).
i've rebased the PR once more, let's see whether that helps... 🤷

not sure what i can do here if it always hits false rejects... (i don't think that there was a single PR i tried to contribute to the OpenSearch repo which didn't get hit with several false rejects before passing through CI - it's not exactly encouraging to contribute this way 😞).

@rursprung Completely agree this is not good! We have been making steady improvements to the tests and CI infrastructure to make this more reliable, so hopefully things have improved since this PR was initially opened.

well, removing that changelog entry (& rebasing) was a mistake... we're back to a random build failure 😠

@rursprung No worries, we can help you re-run the failed build job.

This seems to reliably fail with:
* What went wrong:
Execution failed for task ':distribution:docker:docker-export:exportDockerImage'.
> A problem occurred starting process 'command 'docker''

I have no idea why this PR would cause that, but it does not seem to be flakiness.

@rursprung this will need a rebase to get past the following Gradle check failure, to determine if exportDockerImage is still failing:
* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.8.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.8.0-SNAPSHOT-linux-x64.tar.gz

I'm able to reproduce this failure locally.
$ ./gradlew --stacktrace :distribution:docker:docker-export:exportDockerImage
...
* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':distribution:docker:docker-export:exportDockerImage'.
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:149)
        at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:282)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:147)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:135)
        at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
        at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74)
        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
        at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:337)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:324)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:317)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:303)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:463)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:380)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
Caused by: org.gradle.process.internal.ExecException: A problem occurred starting process 'command 'docker''
        at org.gradle.process.internal.DefaultExecHandle.execExceptionFor(DefaultExecHandle.java:241)
        at org.gradle.process.internal.DefaultExecHandle.setEndStateInfo(DefaultExecHandle.java:218)
        at org.gradle.process.internal.DefaultExecHandle.failed(DefaultExecHandle.java:370)
        at org.gradle.process.internal.ExecHandleRunner.run(ExecHandleRunner.java:87)
        at org.gradle.internal.operations.CurrentBuildOperationPreservingRunnable.run(CurrentBuildOperationPreservingRunnable.java:42)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
Caused by: net.rubygrapefruit.platform.NativeException: Could not start 'docker'
        at net.rubygrapefruit.platform.internal.DefaultProcessLauncher.start(DefaultProcessLauncher.java:27)
        at net.rubygrapefruit.platform.internal.WrapperProcessLauncher.start(WrapperProcessLauncher.java:36)
        at org.gradle.process.internal.ExecHandleRunner.startProcess(ExecHandleRunner.java:98)
        at org.gradle.process.internal.ExecHandleRunner.run(ExecHandleRunner.java:71)
        ... 3 more
Caused by: java.io.IOException: Cannot run program "docker" (in directory "<redacted-OS-root-path>/distribution/docker/docker-export"): error=2, No such file or directory
        at net.rubygrapefruit.platform.internal.DefaultProcessLauncher.start(DefaultProcessLauncher.java:25)
        ... 6 more
Caused by: java.io.IOException: error=2, No such file or directory
        ... 7 more

Through empirical testing, I've narrowed down the failure to be related to the removal of the distribution/docker/docker-export/build.gradle file. I'm going to push an additional commit to restore the file and verify that Gradle check succeeds. I'm not sure why/how the absence of this file causes the failure, so a deeper dive is probably required before we can merge this in.

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([77F537DC32B80579:7083E217093E7324]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:129)

https://github.com/opensearch-project/OpenSearch/issues/1703, will refire

Gradle check passes (the failure above is a known flaky test failure), and this change is ready to merge. Flipping to draft so we can dig deeper into why the distribution/docker/docker-export/build.gradle file is required.

Flipping out of draft so this can be merged. I've opened https://github.com/opensearch-project/OpenSearch/issues/8112 to track the investigation/removal of the docker-export/build.gradle file.


feat(CI): enhance pipeline

PR description
Describe your changes in detail here
This enhances the CI pipeline with runners for different platforms (mac, win), artifact downloading and various optimizations.
Definition Of Done (DoD)
This PR can be squashed / merged if

[x] a developer is assigned
[x] the PR is NOT estimated
[x] the PR is labeled
[x] the PR is NOT assigned to the current sprint
[x] a meaningful title has been set according to https://www.conventionalcommits.org/
[x] the PR is described in detail
[x] the PR links to an issue
[ ] the PR has been reviewed

Add additional conditions here if necessary for this PR
fixes #157

merging for testing purposes


Last Database Log Backup throwing error when opening the properties window

Azure Data Studio Version:
OS Version:

It is a known issue in SSMS and mentioned here: https://learn.microsoft.com/en-us/sql/ssms/release-notes-ssms?view=sql-server-ver16#known-issues-191 with workaround.
Steps to Reproduce:

Open properties of database on SSMS/ADS(still under development)
Error window pops out with the below message.
SSMS:

ADS:

Does this issue occur when all extensions are disabled?: Yes/No

@ssreerama Are there any action items here, or should this be on the backlog?


Added encoding option to recording

I added an encoding option to recording.  I had a hard time figuring out which encoding type to use for .caf files.  You used a hard coded number, 16 which I think translates to kAudioFormatMPEGLayer2.  That might be worth double checking.  I tried to create a pull request but I can't figure out how to just pull this commit (https://github.com/wootwoot1234/react-native-audio/commit/43df597b48de72f7e51212321e4a67a9d78b1d11) and not all the changes in my fork.  Hope it helps.

Oops, and this small change too.  https://github.com/wootwoot1234/react-native-audio/commit/d85d7b33603305938a9522e3327485cf838b302a

@wootwoot1234 - awesome. yeah i just added some of the options i needed. @jsierles has asked me to support all the options.  if you want i can just create a new PR based on your additions?

Added as PR https://github.com/jsierles/react-native-audio/pull/39

I'll check on this in the next few days. thanks!

Looks like this has been merged already :smile:

It's been a while since this thread was commented on and now I'm forgetting where we left it.
@jsierles I have a fork of the code that adds a playWithPath() method and an encoding option to change how recorded audio is encoded.  Would you mind taking a look at my code and letting me know if you would be interested in a pull request?  I'm also going to start working on a method to determine if the app has permission to use the microphone.

Sure - feel free to submit a PR!

@jsierles after looking closer at the code, a playWithPath doesn't make sense.  We should just add the ability to play files from the documents, library and main bundle directories using play.  I can think of three ways to do it.

Pass a parameter to play with either "Documents", "Library", or "MainBundle".  Then the path parameter would be relative to the directory specified.

Instead of passing the relative path to play like we do now, pass the absolute path.  We would also supply paths to the documents, library, and main bundle directories as constants.  This is how react native fs does it here: https://github.com/johanneslumpe/react-native-fs#constants.  I like this approach best but it would be a breaking change to the code.

The last option I can think of is to add two more methods playFromDocuments and  playFromLibrary.  We wouldn't need one for the main bundle because play handles that.

What do you think?

I agree that #2 is the best option, so I'd say we go with that.

Opening a new issue to track this!


Updates for installation on RHEL 9

Updated devs.sh to explicitly pass -fPIC to CFLAGS. This prevents a linking error when building on RHEL 9.
Updated Readme to include new script / dep in RHEL 9.

I may attempt to add a CI job to build in UBI9 if you don't mind. That will capture this alternate env.

I may attempt to add a CI job to build in UBI9 if you don't mind. That will capture this alternate env.

Much appreciated, thanks!
The remainder of this PR is ready for re-review when you have a moment.


add new packages hsexif & app-settings

i'm the author & hackage uploader.

hmm not sure about that fail. hspec appears to be supported on stackage, and app-settings doesn't have any constraint version on hspec.

@emmanueltouzery the test-suite does

huh. the git version, whose cabal file i was looking at, doesn't, but i did not upload the new version on hackage. i'll do it now. after I do it, how do I trigger a new travis test?

aha read i can retrigger a test by closing then reopening the PR, did it now. the new package is already on hackage.

hmm it didn't pick up my new release <IP_ADDRESS>. i'll wait till tomorrow and try to retrigger i guess.

The testsuite failed in stackage build => app-settings#6


drivers: nrf: rtc: Add driver for nordic SoC's RTC (Real Time COUNTER)

The driver is implemented under counter API because nordic RTC
peripheral does not support tracking real time with its internal
registers.
JIRA: ZEP-1808
Signed-off-by: Michał Kruszewski<EMAIL_ADDRESS>

It is not ready yet but I think only small changes are required. For example I would like to add some define to convert between MS and ticks, something like COUNTER_MS_TO_TICKS(MS, FREQ, DIVIDER) but I am not sure where it should be placed. I can imagine adding it to counter.h or to one of nordic headers and there name it NRF_RTC_MS_TO_TICKS.
I also think of removing
u32_t *alarms_table; /* Pointer to array with alarm values */
counter_callback_t *cb_fns; /* Pointer to array storing alarms
			     * callback functions
			     */
void **user_data_table; /* Pointer to array of user data pointers */

from data struct and add array to that struct directly with the maxium number of CCs from all RTC peripherals. It would lead to avoid dereferencing pointer and less memory usage as long as the difference between number of CC registers between RTC peripherals is small (1 or 2), what is actually true right now.


Wrong release name

https://github.com/cloudflare/wildcard/releases/tag/v0.2.0
Tagged as v0.2.0, titled 0.1.0. There's currently two releases listing their version as 0.1.0.

Fixed. Thanks!


enterprise runner horizontal scale error with webhook

Describe the bug
enterprise runner Horizontal auto scale error . and its not scaling
but repo and org level horizontal scaling is working
controller log
2021-10-14T12:20:09.659Z        INFO    controllers.Runner      Scale target not found. If this is unexpected, ensure that there is exactly one repository-wide or organizational runner deployment that matches this webhook event  {"event": "workflow_job", "hookID": "45", "delivery": "12c4eb20-2ce9-11ec-9840-f5605bef85ef", "workflowJob.status": "in_progress", "workflowJob.labels": [], "repository.name": "repo", "repository.owner.login": "ROK-ACTION-TEST", "repository.owner.type": "Organization", "action": "started"}
2021-10-14T12:20:36.734Z        INFO    controllers.Runner      finding repository-wide runner  {"event": "workflow_job", "hookID": "45", "delivery": "22e8b180-2ce9-11ec-8058-205f3fdaa6e0", "workflowJob.status": "completed", "workflowJob.labels": [], "repository.name": "repo", "repository.owner.login": "ROK-ACTION-TEST", "repository.owner.type": "Organization", "action": "completed", "repository": "ROK-ACTION-TEST/repo"}
2021-10-14T12:20:36.734Z        ERROR   controllers.Runner      handling check_run event        {"event": "workflow_job", "hookID": "45", "delivery": "22e8b180-2ce9-11ec-8058-205f3fdaa6e0", "workflowJob.status": "completed", "workflowJob.labels": [], "repository.name": "repo", "repository.owner.login": "ROK-ACTION-TEST", "repository.owner.type": "Organization", "action": "completed", "error": "cache contained , which is not an Object"}
net/http.HandlerFunc.ServeHTTP
/usr/local/go/src/net/http/server.go:2046
net/http.(*ServeMux).ServeHTTP
/usr/local/go/src/net/http/server.go:2424
net/http.serverHandler.ServeHTTP
/usr/local/go/src/net/http/server.go:2878
net/http.(*conn).serve
/usr/local/go/src/net/http/server.go:1929
deployment yaml

apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: dot-runner
spec:
  replicas: 1
  template:
    spec:
      enterprise: test
      labels:
      - dot-enterprise-runner
      env: []
      dockerEnabled: false
      dockerdWithinRunnerContainer: false
      image: gha-caas-runner-generic
      dockerEnabled: false
      securityContext:
        runAsUser: 1000
---
apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
   name: ent-runner-auto-scaller
spec:
  scaleTargetRef:
    name: myrunners
  scaleUpTriggers:
  - githubEvent: {}
    duration: "3m"

Checks

[ ] My actions-runner-controller version (v0.x.y) does support the feature
[ ] I'm using an unreleased version of the controller I built from HEAD of the default branch

Expected behavior
enterprise runner should scan based on workflow run
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Controller Version [e.g. 0.20.2]
Deployment Method [e.g. Helm and Kustomize ]
Helm Chart Version [e.g. 0.13.2, if applicable]

Additional context
Add any other context about the problem here.
autoscalling of runner is working at repo level and Org level with webhook

@mumoshu thanks a lot for your replay and great work on this topic.
i have only one runner deployment and HRA as per above yaml and the HRA is pointing to Enterprise runner deployment and its not scaling the enterprise runner .
when i point the HRA to a repo runner deployment it works perfectly well.
but we are looking for the HRA to scale an Enterprise runner in our on-prem github enterprise servers.
pls find the description of below avaliable resouce.
[root@devops-runner repo]# k get RunnerDeployment
NAME         DESIRED   CURRENT   READY
dot-runner   1         1         1
[root@devops-runner repo]# k get HorizontalRunnerAutoscaler
NAME                      MIN   MAX   DESIRED
ent-runner-auto-scaller   1     30    1

[root@devops-runner repo]# k get HorizontalRunnerAutoscaler
NAME                      MIN   MAX   DESIRED
ent-runner-auto-scaller   1     30    1
[root@devops-runner repo]#
[root@devops-runner repo]#
[root@devops-runner repo]#
[root@devops-runner repo]# k describe RunnerDeployment dot-runner
Name:         dot-runner
Namespace:    github-runner-pool
Labels:       <none>
Annotations:  <none>
API Version:  actions.summerwind.dev/v1alpha1
Kind:         RunnerDeployment
Metadata:
  Creation Timestamp:  2021-10-14T18:11:48Z
  Generation:          1
  Managed Fields:
    API Version:  actions.summerwind.dev/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:replicas:
        f:template:
          .:
          f:spec:
            .:
            f:dockerEnabled:
            f:dockerdWithinRunnerContainer:
            f:enterprise:
            f:env:
            f:image:
            f:labels:
            f:securityContext:
              .:
              f:runAsUser:
    Manager:      kubectl-create
    Operation:    Update
    Time:         2021-10-14T18:11:47Z
    API Version:  actions.summerwind.dev/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:availableReplicas:
        f:desiredReplicas:
        f:readyReplicas:
        f:replicas:
        f:updatedReplicas:
    Manager:         manager
    Operation:       Update
    Time:            2021-10-14T18:11:48Z
  Resource Version:  22648215
  UID:               36056c7f-3da5-4926-9da5-253d4385a0f9
Spec:
  Replicas:  1
  Selector:  <nil>
  Template:
    Metadata:
      Creation Timestamp:  <nil>
    Spec:
      Docker Enabled:  false
      Dockerd Container Resources:
      Dockerd Within Runner Container:  false
      Enterprise:                       daimler
      Image:                            caas-runner-generic
      Labels:
        dot-enterprise-runner
      Resources:
      Security Context:
        Run As User:  1000

[root@devops-runner repo]# k describe HorizontalRunnerAutoscaler ent-runner-auto-scaller
Name:         ent-runner-auto-scaller
Namespace:    github-runner-pool
Labels:       <none>
Annotations:  <none>
API Version:  actions.summerwind.dev/v1alpha1
Kind:         HorizontalRunnerAutoscaler
Metadata:
  Creation Timestamp:  2021-10-14T18:11:48Z
  Generation:          1
  Managed Fields:
    API Version:  actions.summerwind.dev/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:spec:
        .:
        f:maxReplicas:
        f:minReplicas:
        f:scaleTargetRef:
          .:
          f:name:
        f:scaleUpTriggers:
    Manager:      kubectl-create
    Operation:    Update
    Time:         2021-10-14T18:11:48Z
    API Version:  actions.summerwind.dev/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:cacheEntries:
        f:desiredReplicas:
    Manager:         manager
    Operation:       Update
    Time:            2021-10-14T18:11:48Z
  Resource Version:  22830920
  UID:               042e20a3-a0d9-4833-b41c-ac5a8aacb1c0
Spec:
  Max Replicas:  30
  Min Replicas:  1
  Scale Target Ref:
    Name:  dot-runner
  Scale Up Triggers:
    Duration:  10m
    Github Event:
Status:
  Cache Entries:
    Expiration Time:  2021-10-15T03:18:04Z
    Key:              desiredReplicas
    Value:            1
  Desired Replicas:   1
Events:               <none>

@roshvin Thanks for your confirmation and help! Glad to hear it worked.
Re the timeout, HRA.spec.scaleUpTriggers[].duration is the duration until the added runner is removed. But it doesn't work for workflow_job based autoscale.
For workflow_job based autoscale, we add 1 replica for each new workflow_job of queued status and remove 1 replica for each new workflow_job of completed status. So there's no really a notion of "timeout" there.
Do you have any real issues with it? AFAIK, a completed workflow_job triggers a workflow_job webhook event of completed regardless of it was successful or not.
Depending on your goal, scaleDownDelaySecondsAfterScaleOut would help, though. It "delays" the removal of added runners until the duration specified by scaleDownDelaySecondsAfterScaleOut passes since the last runner addition.


Add remaining activation messages

I saw that only the first 4 activation messages were implemented right now (ButtonActivation, SoftKeyActivation, PointingEvent and SelectInputObject). Since there are 11 in total at this time, that means that there are still 7 missing. For the sake of convenience, do we want to implement these as well? I don't mind spending some time on this myself to get this done.

I'm talking about the callbacks here

You are correct that support for some of them are missing, and we definitely need to add the others. If you're interested in working on them, that would be very helpful! Things have been busy on my end recently so I've spent a bit less time on this as the holidays grow near.

The numeric value and string ones are probably the most important if I had to guess

No worries I'll work on this

The numeric value and string ones are probably the most important if I had to guess
Yup these are exactly the ones I needed on my end


Dark theme

Graphics do not display properly when Dark theme is applied.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7cc0f224-e957-d1a0-1217-200eab95871b
Version Independent ID: b33066c0-6c04-815b-1487-be70a66491bd
Content: Design Details - Assembly Order Posting - Business Central
Content Source: business-central/design-details-assembly-order-posting.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Thank you for the input. I will forward your finding to the team responsible for rendering on the Docs site.


Add react-native-draggable-view to reactnative.gallery 🎨

Hi @yaraht17!
Sorry, this is not an issue...
I'm Xavier and I’ve been working as a freelance React Native developer for more than 2 years.
I try to help community when I can: sharing my works on open-source, like you do!
I want to help developers to have more visibility.
So, I've created a website where developers can share with entire
world their React Native projects, components, apps...
This website allow developers to show their works and get feedback.
Just like a Dribbble but for React Native developers.
https://reactnative.gallery
Or chat about it?
https://slack.reactnative.gallery

It's good


Extend launch config

Description
[WIP] Extend launch config to support both in-editor and cloud.
Release note
REQUIRED: Add a release note to the ##Unreleased section of CHANGELOG.md. You can find guidance for writing useful release notes here. Documentation changes are exempt from this requirement.
Tests
Tested with local deployment.
TODO: Test with cloud deployment.
STRONGLY SUGGESTED: How can this be verified by QA?
Documentation
TODO
Reminders (IMPORTANT)
If your change relies on a breaking engine change:

Increment SPATIAL_ENGINE_VERSION in Engine\Source\Runtime\Launch\Resources\SpatialVersion.h (in the engine fork) as well as SPATIAL_GDK_VERSION in SpatialGDK\Source\SpatialGDK\Public\Utils\EngineVersionCheck.h. This helps others by providing a more helpful message during compilation to make sure the GDK and the Engine are up to date.

If your change updates Setup.bat, Setup.sh, core SDK version, any C# tools in SpatialGDK\Build\Programs\Improbable.Unreal.Scripts, or hand-written schema in SpatialGDK\Extras\schema:

Increment the number in RequireSetup. This will automatically run Setup.bat or Setup.sh when the GDK is next pulled.

Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Closing as wrong branch selected.


mutect problem

Hi!
I'm having issues with mutect; a traceback below. I wonder if it might have something to do with mutect running under the systems java (v. 1.8) instead of java version 1.7 that is included with bcbio-nextgen? Apparently mutect requires java 1.7.
That is, if I interpret things correctly from what google has given me.
//Pär
2016-01-21T12:00Z] multiprocessing: combine_sample_regions
[2016-01-21T12:00Z] Identified 18 parallel analysis blocks
Block sizes:
  min: 3119006
  5%: 14716894.75
  25%: 24449223.5
  median: 55115255.0
  75%: 107665416.25
  95%: 136408514.25
  99%: 138213897.25
  max: 138665243
Between block sizes:
  min: 789
  5%: 794.25
  25%: 1284.75
  median: 2273.5
  75%: 4487.75
  95%: 26178028.9
  99%: 37452135.38
  max: 40270662

[2016-01-21T12:00Z] Timing: structural variation initial
[2016-01-21T12:00Z] Timing: hla typing
[2016-01-21T12:00Z] Resource requests: freebayes, gatk, mutect, picard, vardict, varscan; memory: 2.00, 3.50, 2.50, 3.50, 3.00, 2.00; cores: 16, 1, 1, 1, 1, 1
[2016-01-21T12:00Z] Configuring 1 jobs to run, using 1 cores each with 3.50g of memory reserved for each job
[2016-01-21T12:00Z] Timing: alignment post-processing
[2016-01-21T12:00Z] multiprocessing: piped_bamprep
[2016-01-21T12:00Z] Timing: variant calling
[2016-01-21T12:00Z] multiprocessing: variantcall_sample
[2016-01-21T12:00Z] MuTect: MuTect
[2016-01-21T12:00Z] ##### ERROR ------------------------------------------------------------------------------------------
[2016-01-21T12:00Z] ##### ERROR stack trace
[2016-01-21T12:00Z] java.lang.ExceptionInInitializerError
[2016-01-21T12:00Z] 	at org.broadinstitute.sting.gatk.GenomeAnalysisEngine.<init>(GenomeAnalysisEngine.java:167)
[2016-01-21T12:00Z] 	at org.broadinstitute.sting.gatk.CommandLineExecutable.<init>(CommandLineExecutable.java:57)
[2016-01-21T12:00Z] 	at org.broadinstitute.sting.gatk.CommandLineGATK.<init>(CommandLineGATK.java:66)
[2016-01-21T12:00Z] 	at org.broadinstitute.sting.gatk.CommandLineGATK.main(CommandLineGATK.java:106)
[2016-01-21T12:00Z] Caused by: java.lang.NullPointerException
[2016-01-21T12:00Z] 	at org.reflections.Reflections.scan(Reflections.java:220)
[2016-01-21T12:00Z] 	at org.reflections.Reflections.scan(Reflections.java:166)
[2016-01-21T12:00Z] 	at org.reflections.Reflections.<init>(Reflections.java:94)
[2016-01-21T12:00Z] 	at org.broadinstitute.sting.utils.classloader.PluginManager.<clinit>(PluginManager.java:79)
[2016-01-21T12:00Z] 	... 4 more
[2016-01-21T12:00Z] ##### ERROR ------------------------------------------------------------------------------------------
[2016-01-21T12:00Z] ##### ERROR A GATK RUNTIME ERROR has occurred (version 3.1-0-g72492bb):
[2016-01-21T12:00Z] ##### ERROR
[2016-01-21T12:00Z] ##### ERROR This might be a bug. Please check the documentation guide to see if this is a known problem.
[2016-01-21T12:00Z] ##### ERROR If not, please post the error message, with stack trace, to the GATK forum.
[2016-01-21T12:00Z] ##### ERROR Visit our website and forum for extensive documentation and answers to
[2016-01-21T12:00Z] ##### ERROR commonly asked questions http://www.broadinstitute.org/gatk
[2016-01-21T12:00Z] ##### ERROR
[2016-01-21T12:00Z] ##### ERROR MESSAGE: Code exception (see stack trace for error itself)
[2016-01-21T12:00Z] ##### ERROR ------------------------------------------------------------------------------------------
[2016-01-21T12:00Z] Uncaught exception occurred
Traceback (most recent call last):
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 21, in run
    _do_run(cmd, checks, log_stdout)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 95, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
CalledProcessError: Command 'java -Xms454m -Xmx3181m -XX:+UseSerialGC -Djava.io.tmpdir=/home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/tx/tmpSya1Vp -jar /usr/local/share/bcbio/toolplus/mutect/1.1.7/mutect-1.1.7.jar -R /usr/local/share/bcbio/genomes/Hsapiens/GRCh37/seq/GRCh37.fa -T MuTect -U ALLOW_N_CIGAR_READS --read_filter NotPrimaryAlignment -I:tumor /home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/bamprep/CRC204-A_tumor/1/CRC204-A_tumor-sort-1_0_115252404-prep.bam --tumor_sample_name CRC204-A_tumor --dbsnp /usr/local/share/bcbio/genomes/Hsapiens/GRCh37/variation/dbsnp_138.vcf.gz --cosmic /usr/local/share/bcbio/genomes/Hsapiens/GRCh37/variation/cosmic-v68-GRCh37.vcf.gz -L /home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/mutect/1/CRC204-A-1_0_115252404-raw-mutect-regions.bed --interval_set_rule INTERSECTION --enable_qscore_output --vcf /home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/mutect/1/tx/tmpLcYj_z/CRC204-A-1_0_115252404-raw-mutect-orig.vcf.gz -o /dev/null
##### ERROR ------------------------------------------------------------------------------------------
##### ERROR stack trace
java.lang.ExceptionInInitializerError
	at org.broadinstitute.sting.gatk.GenomeAnalysisEngine.<init>(GenomeAnalysisEngine.java:167)
	at org.broadinstitute.sting.gatk.CommandLineExecutable.<init>(CommandLineExecutable.java:57)
	at org.broadinstitute.sting.gatk.CommandLineGATK.<init>(CommandLineGATK.java:66)
	at org.broadinstitute.sting.gatk.CommandLineGATK.main(CommandLineGATK.java:106)
Caused by: java.lang.NullPointerException
	at org.reflections.Reflections.scan(Reflections.java:220)
	at org.reflections.Reflections.scan(Reflections.java:166)
	at org.reflections.Reflections.<init>(Reflections.java:94)
	at org.broadinstitute.sting.utils.classloader.PluginManager.<clinit>(PluginManager.java:79)
	... 4 more
##### ERROR ------------------------------------------------------------------------------------------
##### ERROR A GATK RUNTIME ERROR has occurred (version 3.1-0-g72492bb):
##### ERROR
##### ERROR This might be a bug. Please check the documentation guide to see if this is a known problem.
##### ERROR If not, please post the error message, with stack trace, to the GATK forum.
##### ERROR Visit our website and forum for extensive documentation and answers to
##### ERROR commonly asked questions http://www.broadinstitute.org/gatk
##### ERROR
##### ERROR MESSAGE: Code exception (see stack trace for error itself)
##### ERROR ------------------------------------------------------------------------------------------
' returned non-zero exit status 1
Traceback (most recent call last):
  File "/usr/local/bin/bcbio_nextgen.py", line 226, in <module>
    main(**kwargs)
  File "/usr/local/bin/bcbio_nextgen.py", line 43, in main
    run_main(**kwargs)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 39, in run_main
    fc_dir, run_info_yaml)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 82, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 149, in variant2pipeline
    samples = genotype.parallel_variantcall_region(samples, run_parallel)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/variation/genotype.py", line 169, in parallel_variantcall_region
    "vrn_file", ["region", "sam_ref", "config"]))
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/split.py", line 32, in grouped_parallel_split_combine
    final_output = parallel_fn(parallel_name, split_args)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"])(joblib.delayed(fn)(x) for x in items):
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 804, in __call__
    while self.dispatch_one_batch(iterator):
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 662, in dispatch_one_batch
    self._dispatch(tasks)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 570, in _dispatch
    job = ImmediateComputeBatch(batch)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 183, in __init__
    self.results = batch()
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 72, in __call__
    return [func(*args, **kwargs) for func, args, kwargs in self.items]
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 51, in wrapper
    return apply(f, *args, **kwargs)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multitasks.py", line 147, in variantcall_sample
    return genotype.variantcall_sample(*args)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/variation/genotype.py", line 254, in variantcall_sample
    call_file = caller_fn(align_bams, items, sam_ref, assoc_files, region, call_file)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/variation/mutect.py", line 129, in mutect_caller
    broad_runner.run_mutect(params)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/broad/__init__.py", line 293, in run_mutect
    do.run(cl, "MuTect: {0}".format(prog), None)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 21, in run
    _do_run(cmd, checks, log_stdout)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 95, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command 'java -Xms454m -Xmx3181m -XX:+UseSerialGC -Djava.io.tmpdir=/home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/tx/tmpSya1Vp -jar /usr/local/share/bcbio/toolplus/mutect/1.1.7/mutect-1.1.7.jar -R /usr/local/share/bcbio/genomes/Hsapiens/GRCh37/seq/GRCh37.fa -T MuTect -U ALLOW_N_CIGAR_READS --read_filter NotPrimaryAlignment -I:tumor /home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/bamprep/CRC204-A_tumor/1/CRC204-A_tumor-sort-1_0_115252404-prep.bam --tumor_sample_name CRC204-A_tumor --dbsnp /usr/local/share/bcbio/genomes/Hsapiens/GRCh37/variation/dbsnp_138.vcf.gz --cosmic /usr/local/share/bcbio/genomes/Hsapiens/GRCh37/variation/cosmic-v68-GRCh37.vcf.gz -L /home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/mutect/1/CRC204-A-1_0_115252404-raw-mutect-regions.bed --interval_set_rule INTERSECTION --enable_qscore_output --vcf /home/lindak/Data/LiquidBiopsies/TruSight15/160115/calling/work/mutect/1/tx/tmpLcYj_z/CRC204-A-1_0_115252404-raw-mutect-orig.vcf.gz -o /dev/null
##### ERROR ------------------------------------------------------------------------------------------
##### ERROR stack trace
java.lang.ExceptionInInitializerError
	at org.broadinstitute.sting.gatk.GenomeAnalysisEngine.<init>(GenomeAnalysisEngine.java:167)
	at org.broadinstitute.sting.gatk.CommandLineExecutable.<init>(CommandLineExecutable.java:57)
	at org.broadinstitute.sting.gatk.CommandLineGATK.<init>(CommandLineGATK.java:66)
	at org.broadinstitute.sting.gatk.CommandLineGATK.main(CommandLineGATK.java:106)
Caused by: java.lang.NullPointerException
	at org.reflections.Reflections.scan(Reflections.java:220)
	at org.reflections.Reflections.scan(Reflections.java:166)
	at org.reflections.Reflections.<init>(Reflections.java:94)
	at org.broadinstitute.sting.utils.classloader.PluginManager.<clinit>(PluginManager.java:79)
	... 4 more
##### ERROR ------------------------------------------------------------------------------------------
##### ERROR A GATK RUNTIME ERROR has occurred (version 3.1-0-g72492bb):
##### ERROR
##### ERROR This might be a bug. Please check the documentation guide to see if this is a known problem.
##### ERROR If not, please post the error message, with stack trace, to the GATK forum.
##### ERROR Visit our website and forum for extensive documentation and answers to
##### ERROR commonly asked questions http://www.broadinstitute.org/gatk
##### ERROR
##### ERROR MESSAGE: Code exception (see stack trace for error itself)
##### ERROR ------------------------------------------------------------------------------------------
' returned non-zero exit status 1

Pär;
That's right, you need Java 1.7 for MuTect and GATK runs. We've just started shipping Java 1.7 with bcbio in the last week but haven't tested it at scale so don't use it by default for these parts yet. If you swap over to have java 1.7 in your path MuTect should work cleanly. Hope this helps

Hi Brad,
I just met the same error as above although I have updated the vardict java by
bcbio_conda install -c bioconda vardict-java
on my current bcbio-nextgen 0.9.6 development version.
Is there anyway to fix it?
Thanks.

Sorry I'm a bit confused. Is this the same problem as you've been discussing in #1225 with VarDict, or a different problem with MuTect?


fix avatar can not download

Could you please also bump the npm version, so that we can publish an updated new version after this PR is merged?


Allow the software to run alongside rekordbox

Currently rekordbox takes exclusive control of the UDP socket used to receive status information about the CDJs.

Hi @EvanPurkhiser does this mean that I cannot use prolink-overlay for example with Rekordbox in link export mode, I can only use it when playing from USB etc?
Is this a hard limit due to the way Rekordbox works or the DJ Link protocol etc, or could it be worked around?
I typically avoid playing from USB except when there's no alternative, because I find the export mode a lot more convenient
Thanks 🙂

There is no way to work around this. Only one program can implement the DJ link protocol per IP address, sadly.

Seems like a workaround would be to run prolink-go in a Docker container if you wanted Rekordbox and prolink-go running on the same machine. The Docker container's network traffic would appear to be coming from the Docker host IP rather than localhost.
Is there any technical reason why this wouldn't work that I'm not aware of? Would be happy to submit a pull request with a dockerfile, instructions, etc...

I’m not familiar enough with docker networking to be certain it would handle all of the subtleties of broadcast traffic, but it certainly could work. The best way to find out is to try.

@diemonster would love to see if that works. I've 100% thought about running this in a docker container.


Add support for low-level request method

Add a request(url, fetchOptions) low-level method that can be used to make any API request without having any special method for it. It will need to support the optional token & baseUrl properties that can be passed in when configuring the SDK object.
Something like:
import eventbrite from 'eventbrite';

const sdk = eventbrite({token: 'FOO'});

// create an event
sdk.request('/events/', {
    method: 'POST',
   data: JSON.stringify(eventProperties)
})

Eventually all of the endpoint methods in the SDK will call this low-level request method.

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SVG Resolution Not Working

When I try to create a texture using SVG, passing a resolution makes no difference to the size.
PIXI.Texture.fromImage('assets/image.svg', true, 0, 2);
I would have expected the above to double the size of the SVG when the texture is created. However regardless of the DPR of the  @screen, the texture if being created at the same size.
http://pixijs.download/release/docs/core_textures_BaseTexture.js.html - line 235/6
Am I misunderstanding how the resolution of SVG's are being handled?
Thanks, Nick

Seems to be working for me;
https://codepen.io/staff0rd/pen/egVYaR?editors=0010
Are you using latest?

Hi, sorry about the delay.
I'm preloading my SVG as an SVG file, not the data URI. However, when I try to convert my SVG to Data URI, nothing loads.
I shared the SVG here, as I can't upload it because the file type is not supported. sharesvg.
May I ask how you generate your URI?

Still works with URLs; http://codepen.io/staff0rd/pen/ggBRVL?editors=0010
Check the console on your pen - doesn't look like you can use that host.  Also, your svg doesn't seem to display anything.  Not sure how I got the URI, think I just googled a conversion service and used the first one.

@staff0rd Hey, so I was finally able to debug the issue. You were correct, there is nothing wrong with how it works in PIXI.
The issue was with Webpack. When serving SVG files over a webpack-dev-server, the scaling wasn't working, however when I ran a production build, or pulled the file in from an external resource, then it worked fine.
I hope this saves someone else some time as I've spent too many hours realising that Webpack was the issue. Thanks guys!

@Pandan Hey, sorry to hear you're having the same issues! I didn't dig deep enough to know what in the file was actually being changed, though.. I might take a guess and say it's encoding. I'm unsure if webpack-dev-server is handling files gziped to speed things up.
My work around actually isn't much of one. I ended up creating an abstract class for my SVG's, and bundling them with the code, so there is no need to load them at all (reducing xhr calls).
The class looks a little something like this...
export default class SVG {     public static get hourGlass():string {         return 'data:image/svg+xml;charset=utf8,<svg></svg>';     } }
You can place the actual contents of your SVG file in between the SVG tags, you should see them when you open the file with any ide. Then to use, I simply did:
var texture = new PIXI.Sprite.fromImage(SVG.hourGlass); var x = new PIXI.Sprite(texture);
Hope this is some help!

@megmut Thanks for the tip! I think I am going to see if I can configure webpack to just copy the svg files or something. Have alot of svgs. But if I don't solve it I will try your solution.


Adapted link structure to new menu level.

What are your changes?
What type of changes does your doc introduce?

[x] Bug fix
[ ] New feature

What is the urgency level of this change?

[x] Blocker
[] High
[ ] Medium

I have completed these items:

[x] I have tested all commands and code snippets.
[x] I have built locally and tested for broken links and formatting.
[x] I have made this change for all affected versions (e.g. 1.7, 1.8, and 1.9).
[x] My doc follows the style guide: https://github.com/dcos/dcos-docs#contributing.

Ping @emanic, @sascala, or @joel-hamill for reviewing pull request changes.
If you included a comment with your commit, it appears here:

Looks good, thanks.


Update for bluesky-kafka 0.1.0

Update for bluesky-kafka 0.1.0 release.

@jklynch, FYI, it's not going to upload anything as the meta.yaml was not changed.

I forgot to push the new meta.yml. I opened a new PR. :(