screenshot not saving; comparison always fails

NOTE: Be aware of the fact that this module is only a plugin that provides all functionality from webdriver-image-comparison. So please check if this is an issue with this plugin or with webdriver-image-comparison.

Environment (please complete the following information):

Node.js version: v14.18.2
NPM version: 6.14.15
Browser name and version: Chrome 97
Platform name and version: Windows 10
WebdriverIO version: 7.16.13
wdio-image-comparison-service version: 3.1.0

Config of WebdriverIO + wdio-image-comparison-service
services: [
        ['chromedriver',{}],
        ['image-comparison',
        {
            baselineFolder: join(process.cwd(), './tests/Baseline/'),
            formatImageName: '{tag}-{logName}-{width}x{height}',
            screenshotPath: join(process.cwd(), '.tmp/'),
            savePerInstance: true,
            autoSaveBaseline: true,
            blockOutStatusBar: true,
            blockOutToolBar: true,
        // NOTE: When you are testing a hybrid app please use this setting
            isHybridApp: true,
        // Options for the tabbing image
            tabbableOptions:{
                circle:{
                    size: 18,
                    fontSize: 18,
                // ...
            },
                line:{
                    color: '#ff221a', // hex-code or for example words like `red|black|green`
                    width: 3,
            },
        }
        // ... more options
    }],
    ],

Describe the bug
It seems that no baseline images are ever saved, so the comparison always fails
To Reproduce
    xit('Screenshot of vendors page taken', async () => {
        browser.saveFullPageScreen('fullPage');
    });
    it('Screenshot matches baseline', async () => {
        expect(browser.checkFullPageScreen('fullPage')).toEqual(0);
    });

Expected behavior
I should be able to take/save screenshots, but it doesn't appear to be saving anything to baseline or any tmp folder, so of course the comparison fails.
Log
[chrome 97.0.4692.99 windows #0-0] expect(received).toEqual(expected) // deep equality

Expected: 0
Received: {}

Additional context
My tests are in TS. Yes, I have added the comparison service types to my TS config.

wdio-image-comparison-service by default saves the baseline image in ./.tmp/actual.
If you remove  baselineFolder: join(process.cwd(), './tests/Baseline/') from wdio.conf.js file and update it block of image comparison as mentioned below
it('Screenshot matches baseline', async () => {
const testOptions = {
    actualFolder: path.join(process.cwd(), './.tmp/checkActual'),
    baselineFolder: join(process.cwd(), './.tmp/actual'),
    diffFolder: path.join(process.cwd(), './.tmp/testDiff'),
    returnAllCompareData: true,
 };

expect(browser.checkFullPageScreen('fullPage', testOptions)).toEqual(0);
});

Then it works

I still got:
`[chrome 97.0.4692.99 windows #0-0] expect(received).toEqual(expected) // deep equality
Expected: 0
Received: {}
[chrome 97.0.4692.99 windows #0-0] Error: expect(received).toEqual(expected) // deep equality
[chrome 97.0.4692.99 windows #0-0]
[chrome 97.0.4692.99 windows #0-0] Expected: 0
[chrome 97.0.4692.99 windows #0-0] Received: {}`

Hi @lvxwrkr777
I'm currently on vacation and can't verify it, I'll check it when I'm back. I have the feeling this is related to Windows only because on Mac/Linux this just pases

@wswebcreation Any update on this?

Encounter similar issue, I guess there no fix on this?

Can someone provide a minimal reproducible example as GitHub project I can clone and use to investigate?

Can someone provide a minimal reproducible example as GitHub project I can clone and use to investigate?

I'ma call you 'Christian Brogrammer', if you can't figure this out.
I don't work for the company where I had to operate within that context anymore, but it was an MS-DOS environment with node.js. Weird, I know. I found some port bugs in modules originally written for Linux.


[FEATURE] Set event name suggestion on Variable Changed event creation

Is would be really nice to have an automatically set up name for the event when creating a new event for a variable (could be fancy and try to understand what naming convention is being used or just force some naming convention such as appending " changed" or "_changed", or some middle ground such as a setting regex for it?)
This makes the process of creating new events for variables less repetitive (especially in the case mentioned in #66 )

Great idea! I think that just adding the postfix "Changed" to the Event as the default name will suffice for now or what do you think @mutmedia? The tricky part implementing this would be to get the parent of of the SerializedProperty in the AtomDrawer. You would then use the name of the parent Atom (if there is one) + the name of the property of the Atom you are creating. Eg: if you have a Variable called MyVariable and you click Create for the Changed event of that Variable the default name would be MyVariableChanged.

(untested):
in the event drawer, you can get property.serializedObject.Name which should yield the Scripts's name or the scriptableObjects's asset name.
and of course you could get the property.Name to get the variable name itself.

scenario 1: you're in an IntVariable AtomVariable named "fooBar" you click "create" for the "changed" event of type IntEvent.
** scenario 2*: you're on an GameObject Player in a Script named Health you click "create" for the "reachedZero" event of type BoolEvent.
| pattern | scenario 1 | scenario 2 |
| On | IntVariableOnChanged | HealthOnReachedZero |
| Changed  | IntVariableChanged | HealthChanged |
| Changed  | fooBarChanged | PlayerChanged |
| Changed  | IntVariablefooBarChanged | PlayerHealthChanged |
| On  | IntVariablefooBarOnChanged | PlayerHealthOnReachedZero |

I think pattern 3 (row 3) works best for scenario 1, however it isn't great for scenario 2. Maybe we could via reflection see if the parent is an Atom Variable or not? If it is we use the <object name>Changed pattern, otherwise we just default to AtomEvent or maybe <property name>?

Fixed in #317


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73520

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73780


Discussion: how about adding some of the fields in Pod spec to the RisingWaveComponentGroupTemplate?

Though I designed the RisingWavePodTemplate, I find it hard to use, especially when the requirements are fair simple. Therefore, I'm considering adding some frequently used fields in Pod spec to the RisingWaveComponentGroupTemplate.
The following fields are under consideration:

metadata.{labels, annotations}, to support setting labels/annotations on RisingWave's Pods.
envs
securityContext in container spec.
terminationGracePeriodSeconds
tolerations
priorityClassName
priority
dnsConfig

What do you think?

Any contexts for what these lables for? 🤔

Any contexts for what these lables for? 🤔

Labels on RisingWave's Pods

Sounds like a good idea. Could you please explain a bit how our templating works here?

Sounds like a good idea. Could you please explain a bit how our templating works here?

Yes, for sure. RisingWaveComponentGroupTemplate is the template for building the Pod template in workload objects of RisingWave itself, e.g., the Deployment of meta. Currently, common template fields like resources, image, and imagePullPolicy are included in the struct. Thus we have a template like the following:
spec:
    global:
      image: ghcr.io/risingwavelabs/risingwave:nightly-20221107
      imagePullPolicy: IfNotPresent
      resources:
        limits:
          cpu: 1
          memory: 4Gi
        requests:
          cpu: 100m
          memory: 100Mi

Then we'll get RisingWave Pods with image ghcr.io/risingwavelabs/risingwave:nightly-20221107 and other options set in this template.
The RisingWaveComponentGroupTemplate is used in both .spec.global and .spec.components.*.groups, you can find the definition here.
And if we add more fields, we can have more control over the Pods. For example, if we want to set toleration of some taints, we can just set it in the template, rather than using a pod template.
spec:
  global:
      tolerations:
      - key: spot
        operator: Exists
        effect: NoSchedule


401 status error in Here Maps API request

Search for adress is not working in Comma Connect.
Looks like the API Key from Here maps are not working properly, I tested on PC to inspect and the API keys are being not authorized, 401 error.

HERE cancelled our account for some reason. Fix has been deployed.


chore: update e2e readme

Description:
Adds more clear goals to run e2e tests
Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 72.134%

Files with Coverage Reduction
New Missed Lines
%

src/domain/utils/DER.ts
3
35.14%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.07%

Covered Lines:
2774

Relevant Lines:
3655

💛  - Coveralls


ArgumentOutOfRangeException with OdinsQOL's quick slots

Hello,
When putting an item into any of the quick slots provided by OdinsQOL i get the following exception spam logged:
ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
  at System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) [0x00029] in <695d1cc93cca45069c528c15c9fdd749>:0
  at System.ThrowHelper.ThrowArgumentOutOfRangeException () [0x00000] in <695d1cc93cca45069c528c15c9fdd749>:0
  at BetterUI.GameClasses.BetterHotkeyBar.PatchHotkeyBar (HotkeyBar& __instance, Player& player) [0x0003a] in <ba9fa52f025a4f1aab3fa5a0598003a4>:0
  at (wrapper dynamic-method) HotkeyBar.DMD<HotkeyBar::UpdateIcons>(HotkeyBar,Player)
  at HotkeyBar.Update () [0x000d3] in <035307060cbb4b30b916cd82ebd80490>:0

I have not yet tested if this happens with Randyknapp's EAQS too since he's still working on updating that one anyways.
Edit: Confirmed not happening with EAQS 2.1 (pulled directly from his repo).
Love the mod and been using it for practically ages, thanks for the quick update for Mistlands!
Kind regards
Fallen

@FallenUpwards would you be willing to try the latest pre-release version with OdinQOL? The issue should be fixed now.
https://github.com/thedefside/BetterUI/releases/tag/v2.3.3-pre-release

@FallenUpwards would you be willing to try the latest pre-release version with OdinQOL? The issue should be fixed now.
https://github.com/thedefside/BetterUI/releases/tag/v2.3.3-pre-release

Yep, can confirm no errors with Odin's quickslots anymore - at least during the small test i did just now.
I'm usually using EAQS anyways and was only trying out Odins' module while Randy was still working on the Mistlands compatibility update but i thought i'd report it anyways.

resolved by #41


Resolve mouse lag issue in Android VM.

Add render_sync=false to resolve mouse lag issue.
Tracked-On: OAM-121159

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web  for more details. For Binaries: /cactus-absp-or-local/celadon_smr0_vertical-merge/13


Does this support Django 1.8 ?

Right now, i can see in setup.py that it provide support only for 1.4 < Django < 1.8 ?
Any plans to add support for Django 1.8 .
Thanks

Hey @muzaffaryousaf and sorry for the late reply. It's fixed now in 0.4.1 and should work just fine.

Thanks a lot..


Directory path handling with symlinks

The current working dir is something like /export/.., where /export is a link to mounted file system /export0.
The tslint output contains the canonical path (/export0/..) where as the FileSystem implementation by SonarQube provides the "simple" path (/export/...).
This leads to a warning during analysis "TsLint reported issues against a file that isn't in the analysis set - will be ignored: /export0/...".

Why did you revert the fix on your branch but leave the PR, out of interest?

As this is my first attempt on juggling branches, I messed things up. I reverted the change on another branch as it ended up there also. But as far as I can tell, the commit is still on the canonical-path branch.

Cool, no worries - as mentioned on the PR I'll need some time to test on a couple of environments (assuming this is a Linux-specific issue?), want to make sure nothing's regressed anywhere.

Yes, we ran into the issue on Linux.


ISPN-6214 Fix DistributedExecutorBadResponseFailoverTest

The JGroupsTransport is already started by the time we wrap it
in our CacheNotFoundResponseTransport, so we should not start it
a second time.
Caused by https://github.com/infinispan/infinispan/pull/4011

Pushed, thanks


Use DSCP instead of tun_metadata0 in Traceflow

This patch changes Traceflow dataplaneTag from tun_metadata0 to DSCP, and
removes the tunnel/encap mode restriction for inter-Node Traceflow.
This PR closes #1357

Codecov Report

Merging #1466 into master will decrease coverage by 25.65%.
The diff coverage is 13.33%.

@@             Coverage Diff             @@
##           master    #1466       +/-   ##
===========================================
- Coverage   67.82%   42.16%   -25.66%
===========================================
  Files         159       85       -74
  Lines       12744    10405     -2339
===========================================
- Hits         8643     4387     -4256
- Misses       3193     5630     +2437
+ Partials      908      388      -520

Flag
Coverage Δ

#integration-tests
?

#kind-e2e-tests
?

#unit-tests
42.16% <13.33%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/agent.go
13.54% <ø> (-36.32%)
:arrow_down:

pkg/agent/openflow/client.go
9.28% <0.00%> (-58.58%)
:arrow_down:

pkg/controller/traceflow/controller.go
62.58% <ø> (-2.59%)
:arrow_down:

pkg/agent/openflow/pipeline.go
23.08% <17.39%> (-60.58%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/controller/networkpolicy/tier.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-85.72%)
:arrow_down:

... and 128 more

/test-all

FYI. - I think OVS folks are evaluating the tun_metadata fix and promised to give us an update today. It might still be possible to have the fix for Antrea 0.11.

/test-all

OVS made a fix on kernel<EMAIL_ADDRESS>

@jianjuns @antoninbas , The fix made by OVS team requires the latest kernel version, I think it's a strict limitation for users to enable Antrea Traceflow. I still prefer to leverage DSCP to support Traceflow for both encap and no-encap. Please share your concerns about this solution.

@vicky-liu that was my original concern, that the fix would require a patch to the OVS kernel datapath
yes, we should move forward with the DSCP workaround

Sure. Let us go the PR for 0.11. We can decide if we want to change to DSCP + INT in future releases.

/test-all

/test-all

/test-all

/test-all

/test-networkpolicy

Do you plan to support TF for NoEncap and NetworkPolicyOnly mode? If so, we should update the AgentOptions.validate(), and also the antrea-agent.conf.

Seems I forgot to confirm this one. Could you answer? @gran-vmv

Do you plan to support TF for NoEncap and NetworkPolicyOnly mode? If so, we should update the AgentOptions.validate(), and also the antrea-agent.conf.

Seems I forgot to confirm this one. Could you answer? @gran-vmv

I checked Traceflow in noEncap mode, and it can work. I think AgentOptions.validate() doesn't validate traceflow options, and the validation in agent/traceflow/traceflow_comtroller is removed by this PR.

Then at least change the yaml and documentation.

Then at least change the yaml and documentation.

Currently no changes needed for yaml and doc.
In current Traceflow doc, the low level tech is not mentioned such as tun_metadata/DSCP, and the interNode restriction is not mentioned too. After this PR merged, the interNode restriction is removed and we don't need to change this unless we want to add some details into this doc.

Ok. You are right. I thought we commented in the yaml that TF requires encap and Geneve.


Many UI changes for events

Themeing

most UI elements now have the godot4 LineEdit styleboxes for normal and focus
I've reduced the line length for end Branch events, we can discuss this later. I wanted all the events to be shorter so this one had to be shortened too

Custom Number field

smaller, good style
saves not only on enter
should allow implementing string editing in number fields later
-> better Vector field for Position event

Complex Picker

now allows to navigate suggestions with up and down keys
now has a focus style
better aligns icon
better supports focus enter and exit
suggestion function is now passed as a callable not an array (before: [object, method_name])
-> this has resulted in a change in many events, some settings, the character editor as well as the toolbar (everything that uses ComplexPicker)
suggestion function now should not filter the results anymore, this is done by the complex picker itself. The input is still passed, so it can be used in special cases (e.g. Value field in Conditions).

Misc

some print statements where removed

Event field changes

many texts in front of fields have been removed/changed. Usually the header should read like a sentence or contain very little, while the body contains settings more like a list.
some fields where moved from header to content or vice versa. Only basic information should be in the header for a clean timeline.
some events are now folded by default

Wouldn't it be better to have the x and the y to live outside of the editable field?

I really like all the changes 👏


Longer explanation of INTERNAL folder

I read the original words but did not get the full meaning until reading a comment in an issue. Perhaps this version is more approachable.

done !


Support to set owner/group for cert and key

This PR depends on #6 but the commit Support to set owner/group for cert and key can be reviewed.


Retry on initial connect unblocked

This is continue of #148.  The solution for #148 blocks the thread on natsConnection_Connect() forever or depends of values natsOptions_SetMaxReconnect(), natsOptions_SetReconnectWait() are set up.
Is it possible to process  natsConnection_Connect() asynchronously and call reconnection callback, for example, if client successfully connects to server?

How would the connection calls behave while the connection is not connected then? For instance, at the moment, a publish call checks that the message size is not greater than the max payload, value which we get only from the INFO of the server we connect to. I could of course disable this test, or fail all connection tests until the connection is first connected, or buffer (as in reconnect) while the library tries to connect.
Also, should the connect then return OK while trying to connect in the background or return an error, say NATS_NOT_YET_CONNECTED?
The feature is in master but no release was made yet, so I could change the semantic no problem. The thing is I am not sure how things should behave if I allow async connect.

Also, should the connect then return OK while trying to connect in the background or return an error, say NATS_NOT_YET_CONNECTED?

Just OK cause a misunderstanding for user because connection is not really established.  NATS_NOT_YET_CONNECTED looks good.
Also I think it will be good idea to support async, sync and "no retry" behaviors for natsConnection_Connect() and  allow the user to select appropriate mode by natsOptions_SetRetryOnFailedConnect().

We could have something like: natsOptions_SetRetryOnFailedConnect(stanConnOptions *opts, bool retry, bool blocking) to cover all cases. My question is what about Publish and Subscribe calls while the connection is not yet connected for the first time. Should these calls fail or behave as during a reconnect event, I don't know.

IMHO in user point of view Pub and Sub during first connection or reconnections should operate in similar way. If sub fails in first connection attempts user should think about retrying of subscription but don’t think about it in reconnection. It won’t be consistent behavior of cnats.


Incorrect install on raspberry pi 4

when running pip3 install -r requirements.txt it errors out with
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-cih8b9_z/flask_73e9fcc6aaef45e892bab6c7352ea254/setup.py'"'"'; __file__='"'"'/tmp/pip-install-cih8b9_z/flask_73e9fcc6aaef45e892bab6c7352ea254/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-59rx5xio
         cwd: /tmp/pip-install-cih8b9_z/flask_73e9fcc6aaef45e892bab6c7352ea254/
    Complete output (6 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-cih8b9_z/flask_73e9fcc6aaef45e892bab6c7352ea254/setup.py", line 62
        print "Audit requires PyFlakes installed in your system."
              ^
    SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Audit requires PyFlakes installed in your system.")?
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

which is python2 syntax. it also seems to install every version of flask possible, so that's another error

This seems to be a problem with flask on aarch64, no? At least, it's not pointing out a syntax error with Pastey itself.
I saw you forked the repo and removed the tensorflow requirement; does it seem like an impossible task right now to build with guesslang on a Pi?

This seems to be a problem with flask on aarch64, no? At least, it's not pointing out a syntax error with Pastey itself.
I saw you forked the repo and removed the tensorflow requirement; does it seem like an impossible task right now to build with guesslang on a Pi?

the issue is that by just putting flask in requirements.txt, it wants to install every single version of flask it can. you need to specify a version. tensorflow seems unreasonable to me for a designed to be simple pasting tool. there's also languages with quite similar syntax which it could struggle with

the issue is that by just putting flask in requirements.txt, it wants to install every single version of flask it can. you need to specify a version.

While pinning versionso is a good idea and something I will indeed add to the requirements file per your pull request, that's not the reason pip is going through each version of the package. Under normal circumstances, it will install the latest version, unless it encounters dependency resolving issues, in which case it will keep trying until one fits the requirements.
Are you saying that when you run pip install flask it attempts every version (including 1.1.2) and fails, but pip install flask==1.1.2 works for you?

yes that's what i'm saying


How to get this index

I used this index in BFM 2009. It's really useful, thanks a lot.
Recently, I turn to use BFM 2017, and it has a version with only face cropped(model2017-1_face12_nomouth.h5), which the index could not be used directly. Hence, could you teach me how to get the index, and I would do it by myself in BFM 2017. Thanks again.

I used this index in BFM 2009. It's really useful, thanks a lot.
Recently, I turn to use BFM 2017, and it has a version with only face cropped(model2017-1_face12_nomouth.h5), which the index could not be used directly. Hence, could you teach me how to get the index, and I would do it by myself in BFM 2017. Thanks again.

Did you figure out it? I want to know how to get the index in BFM 2017 as well....

I used this index in BFM 2009. It's really useful, thanks a lot.
Recently, I turn to use BFM 2017, and it has a version with only face cropped(model2017-1_face12_nomouth.h5), which the index could not be used directly. Hence, could you teach me how to get the index, and I would do it by myself in BFM 2017. Thanks again.

Did you figure out it? I want to know how to get the index in BFM 2017 as well....

Not yet. I'm using data from my tutor now. I'm sorry I couldn't share it with you because of privacy. But I found an alternative method, which might be practical.

First, generate a average face, and write it into a file (such as .ply);
Use PickPoint function of MeshLab to pick these points by yourself;
And write a simple script to find model' points nearest to these picked points. And corresponding index are what you want.

Not very accurate, but if just for estimation, it's enough.
Hope that it could help you :)

I used this index in BFM 2009. It's really useful, thanks a lot.
Recently, I turn to use BFM 2017, and it has a version with only face cropped(model2017-1_face12_nomouth.h5), which the index could not be used directly. Hence, could you teach me how to get the index, and I would do it by myself in BFM 2017. Thanks again.

Did you figure out it? I want to know how to get the index in BFM 2017 as well....

Not yet. I'm using data from my tutor now. I'm sorry I couldn't share it with you because of privacy. But I found an alternative method, which might be practical.
1. First, generate a average face, and write it into a file (such as .ply);

2. Use PickPoint function of MeshLab to pick these points by yourself;

3. And write a simple script to find model' points nearest to these picked points. And corresponding index are what you want.

Not very accurate, but if just for estimation, it's enough.
Hope that it could help you :)

Thanks, I will try it!!

I used this index in BFM 2009. It's really useful, thanks a lot.
Recently, I turn to use BFM 2017, and it has a version with only face cropped(model2017-1_face12_nomouth.h5), which the index could not be used directly. Hence, could you teach me how to get the index, and I would do it by myself in BFM 2017. Thanks again.

Did you figure out it? I want to know how to get the index in BFM 2017 as well....

Not yet. I'm using data from my tutor now. I'm sorry I couldn't share it with you because of privacy. But I found an alternative method, which might be practical.
1. First, generate a average face, and write it into a file (such as .ply);

2. Use PickPoint function of MeshLab to pick these points by yourself;

3. And write a simple script to find model' points nearest to these picked points. And corresponding index are what you want.

Not very accurate, but if just for estimation, it's enough.
Hope that it could help you :)

Thanks, I will try it!!

Hello,did you try it?
I meet a similar problem now.
And I want to know how to get the index of model (which is not belong to the 68 keys)


Can hugo install on windows 11 ???

What version of Hugo are you using (hugo version)?

$ hugo version

Does this issue reproduce with the latest release?

Yes.
In the future, please use the forum (https://discourse.gohugo.io) for questions and troubleshooting. We prefer to use GitHub for verified bugs and vetted enhancements. Thanks.


Avoid ConcurrentModificationException

Closes #2061
Fixes #2061  .
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Does this really fix the problem?
ConcurrentModificationException has nothing to do with concurrency, really, it's usually just a symptom of the fact a collection is being iterated twice, usually in the same stack frame. Nothing to do with threads.

@cbeust - The fix was not to prevent the collection from being altered while its being altered but more in terms of avoiding that exception...
Moving to ConcurrentHashMap helps resolve that because it's failsafe..
Quoting https://javapapers.com/java/java-concurrenthashmap/

ConcurrentHashMap does not throw ConcurrentModificationException if the underlying collection is modified during an iteration is in progress. Iterators may not reflect the exact state of the collection if it is being modified concurrently. It may reflect the state when it was created and at some moment later. The fail-safe property is given a guarantee based on this.


ObservedCollection() breaks when collection is shared between multiple clients

First of all, thank you for this library, it's great!
Unfortunately, I've ran into a pretty big issue with it. When using ObservedCollection(collection), where the collection is a part of a singleton service and is thus shared between multiple clients (tabs/browsers), it only seems to update once and and further changes result in what seems to be a deadlock. It becomes impossible to update the collection any further. It's mostly likely caused by some threading issues.

It seems that this happens when you subscribe to multiple different collections in a single reactive component. Subscribing to the same collection multiple times (for example to run a linq filter on it) works fine.

I've put together a small demo project. Open 2 browser tabs and go to fetch data on both of them. Then click add several times on one of the tabs. The other tab only updates once and will not update until add is clicked on it.
This is a simple case, but in my real-world application, multiple uses updating it not only does not update, it completely locks all functionality that uses those collections.
PhorkTest.zip

@wihrl v1.1.2 is supposed to fix this issue. Just update the package reference version to "1.1.2" and you will most probably be good to go.
Details: This problem had nothing directly to do with observed collections. The problem was with the way the library detected an observed value/binding getting out of the render tree and therefore getting rid of its related subscriptions. The library relied on the OnAfterRender method of the ComponentBase class to update the subscriptions, assuming it will only get called after each time Blazor creates the render tree of a component. It was a wrong assumption, as proved by your test project. Blazor apparently calls OnAfterRender for reasons other than recreating the render tree. In the current version, the library uses reflection to make the reactivity manager update its subscriptions after each time the BuildRenderTree of the component is called. Using reflection to access a private field of ComponentBase is not something I'm satisfied with, but until dotnet/roslyn#57239 gets fixed, I can't think of a better way of doing it.

Thanks, I can confirm that the issue is fixed.
Just yesterday I was actually thinking about eventually using source generators to optimize parts of the library, I guess that will have to wait.

Yeah, the library can benefit a lot from source generators if the issue gets resolved. Regarding the pull request you linked, I don't think it's going to be merged as it does not solve the main problem.


As a receiver, I want to receive a welcoming card

As a receiver, the thank you item can look more like getting a phone-number. It does not look so welcoming. And maybe the request what I want from the other is not so clear either.
What is it I want to give to others? What is the gift of the code?
Change code to password, or something less technical
Make a request on the card: Geef door

The card also should look more professional. Maybe with stickers that you can stick on a card. It should be typed, not hand written. When it is hand-written, it raises more suspicion with the receiver

When you put your need-learninggoal on it, then the request is more clear. For now, hand-written is ok as a prototype. The code is needed to have it more safe. Therefore, this is something not planned for now


Improve :contains

If the ( ) balancing is not correct, it is impossible to clearly determine the actual end of the pseudo-class. For example:

:contains((aa)
:contains(aa))

In the above cases, parenthesis must be escaped as follows:

:contains(\(aa)
:contains(aa\))

But the following cases are fine, since balancing is fine:

:contains((aa))
:contains((aa)(bb)(cc)dd(ee))

The following cases are currently problematic in ECSSTree (throws parsing error):

:contains('(aa')
:contains('aa)')

This is because ECSSTree overrides CSSTree's default algorithm while parsing :contains() and currently ONLY parses the argument as raw (and not takes string into account like CSSTree). If we introduce the string node management here, the following case must also be taken into account:

from :contains('aa"aa'), 'aa"aa' is parsed as string node by CSSTree, but when generating, CSSTree always uses double quotes, so it generate this selector as :contains("aa\"aa") (reference)
:contains('aaa) - handle as unclosed string or parse 'aaa as raw?
:contains("aaa) - handle as unclosed string or parse "aaa as raw?
:contains('(aa) - invalid

See https://github.com/AdguardTeam/FiltersCompiler/issues/156#issuecomment-1442892854
@slavaleleka What do you think about this?

@slavaleleka It seems ExtendedCSS also throws an error for

:contains('(aa')
:contains('aa)')
:contains("(aa")
:contains("aa)")

But not for

:contains('(aa)')
:contains("(aa)")

This should also be fixed:
:contains(/(\(| |^)EqG[) ]/)

(square brackets should also be included in the balancing when searching)

will fix once we integrate @adguard/css-tokenizer


Fix periodic transformation to avoid dx==0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.92%. Comparing base (850d846) to head (706d394).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   97.92%   97.92%   -0.01%
==========================================
  Files           7        7
  Lines         965      963       -2
==========================================
- Hits          945      943       -2
  Misses         20       20

Files
Coverage Δ

interpax/_spline.py
97.72% <100.00%> (-0.01%)
:arrow_down:


MINOR : Fixed KAFKA-6764; Update usage for console-consumer whitelist option

Fix for KAFKA-6764.

With group-id, always subscribe() and auto-assign. Seek based on partition/offset config(Not sure if seek should be supported by console-consumer when a group-id is specified. Because assign() and subscribe() can't be used together for the same topic-consumer-group combination).
Without group-id (Auto Commit Offset is always disabled):

Partition/Offset specified, then assign.
Partition/Offset not specified, then subscribe.

Correct if I am wrong.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@guozhangwang  @bbejeck  @vvcephei  @apurvam  Review and merge.

Thanks, @sumannewton.  LGTM once comment is addressed

@hachikuji @cmccabe

@omkreddy

Any update on this?

@sumannewton : sorry for my slow response on this PR.
I thought about this a little bit more.  I think if the user passes both group and partition, that should be an error.  The combination just does not make sense.  Choosing one option arbitrarily to honor, and ignoring the other, is confusing for users.  So let's just have an error message when this happens.

@cmccabe Sure makes sense. An error is thrown when group and partition are specified together.

@cmccabe @guozhangwang @ijuma

Thanks, @sumannewton .  I'll commit this once the last comment is addressed.

@cmccabe Addressed the review comment.

Thanks, @sumannewton .  Will commit as soon as the JUnit tests finish.

retest this please

Hmm.    Can you rebase the PR on the latest trunk?

retest this please

retest this please

retest this please

I ran kafka.server.DynamicBrokerReconfigurationTest locally and it passed with this patch.  Thanks, @sumannewton.


MklEltwiseFwdPrimitive implemented twice (same class name used)

In files tensorflow/core/kernels/mkl/mkl_eltwise_activation_base_op.h and tensorflow/core/kernels/mkl/mkl_relu_op.cc there are two classes with the same name: MklEltwiseFwdPrimitive. We have noticed that this can lead to segmentation fault at runtime when method is called on different instantiation of the class then what is expected (i.e calling Execute() on implementation in mkl_eltwise_activation_base_op.h instead of one in mkl_relu_op.cc). Since implementation are slightly different this patch renames MklEltwiseFwdPrimitive in mkl_eltwise_activation_base_op.h to MklEltwiseFwdActivationPrimitive to avoid the issue.

Hi @penpornk Can you please review this PR ? Thank you!

@milpuz01 Thank you for the changes, looks good to me.

Sachin from Intel-Tensorflow team


Multiple e-mail support

Coverage decreased (-0.35%) when pulling 9089ea2e36aa0670fa875d59d77e5646abc1d034 on johngian:alternate-email-dev into 2e91716897819beaeb51c8d3293feaa7a8df9240 on mozilla:master.

@akatsoulas r?

Coverage decreased (-0.35%) when pulling 8ef2d7edb838be1be5956694a0d707acd5ec8023 on johngian:alternate-email-dev into 1a049d2a138a54129a124d7f7b5c0910068b2720 on mozilla:master.

Personally I would organize the commits into undo-able chunks - commits that easy and meaningful  to revert. For example maybe it makes sense to be able to revert to the old and new functionality with just one commit, thus merging the first three. Either way it totally up to you how you are going to handle this.

Regarding commits I would prefer to have small atomic commits. It makes sense for me to either squash 71192ea7bce0e37ede958bf8f80f0ad32b2b2229 d318a04505346dbb9989aae60e34a1819bb725b3 or split them to even more commits.

Coverage increased (+0.1%) when pulling 2940d9bda72a244364f0279df1be50d57cc2c72f on johngian:alternate-email-dev into 1a049d2a138a54129a124d7f7b5c0910068b2720 on mozilla:master.

Coverage increased (+0.1%) when pulling ce45177f8d16b97cd3c0fe19b781d59ec9391801 on johngian:alternate-email-dev into 1a049d2a138a54129a124d7f7b5c0910068b2720 on mozilla:master.

@akatsoulas @comzeradd PR updated

Coverage increased (+0.1%) to 92.88% when pulling 3e3c865c4a53fddeada61de5657f6da44e82117d on johngian:alternate-email-dev into 3b834fb9c38fd86dded1b87950815c271bde4adf on mozilla:master.

Coverage increased (+0.1%) to 92.88% when pulling 3e3c865c4a53fddeada61de5657f6da44e82117d on johngian:alternate-email-dev into 3b834fb9c38fd86dded1b87950815c271bde4adf on mozilla:master.

Looks good. r+

Coverage increased (+0.1%) to 92.88% when pulling b21bbb6959af1ccabc8424e65e21de825d463857 on johngian:alternate-email-dev into 3b834fb9c38fd86dded1b87950815c271bde4adf on mozilla:master.

@glogiotatidis PR updated


Display bread board

Hi.
How does it work to display the bread board in simulator area.
for example...
The BB is displayed only when the block is connected in case of LCD extension.

But The BB is displayed by adding Game extension. (even though blocks are not connected.)

Could you share programs that reproduces both of the issues?

Repro: https://makecode.com/_7ioMg2b6Efka

https://makecode.seeedstudio.com/#editor

I don’t think you want to use the breadboard so board.json is irrelevant to your editor. You need to design your simulator first.


Skills Display theme menu background should respect the configure background color

Skills Display theme menu background should respect the configure background color

PR: https://github.com/NationalSecurityAgency/skills-service/pull/440

:+1:


Data Preparation for TUMTraf Intersection Dataset does not generates any train and val samples in tumtraf_i_processed directory.

@walzimmer
Hi, thank you for your great work.
I want to do data preparation code for Intersection dataset.
I succeeded in splitting the intersection dataset into train and val as README in tum-traffic-dataset-dev-kit repository says.
However, data preparation by create_tumtraf_data.py in this repository does not generates any train and val samples in tumtraf_i_processed directory.
How can I fix these things?
The output of create_tumtraf_data.py is displayed as below:
`split:  ['training', 'validation']
Start converting ...
Converting split: training...
train sample: 0
Converting split: validation...
val sample: 0
Finished ...
creating groundtruth database
Create GT Database of TUMTrafNuscDataset
DATASETS:  Registry(name=dataset, items={'CustomDataset': <class 'mmdet.datasets.custom.CustomDataset'>, 'CocoDataset': <class 'mmdet.datasets.coco.CocoDataset'>, 'CityscapesDataset': <class 'mmdet.datasets.cityscapes.CityscapesDataset'>, 'CocoPanopticDataset': <class 'mmdet.datasets.coco_panoptic.CocoPanopticDataset'>, 'ConcatDataset': <class 'mmdet.datasets.dataset_wrappers.ConcatDataset'>, 'RepeatDataset': <class 'mmdet.datasets.dataset_wrappers.RepeatDataset'>, 'ClassBalancedDataset': <class 'mmdet.datasets.dataset_wrappers.ClassBalancedDataset'>, 'MultiImageMixDataset': <class 'mmdet.datasets.dataset_wrappers.MultiImageMixDataset'>, 'DeepFashionDataset': <class 'mmdet.datasets.deepfashion.DeepFashionDataset'>, 'LVISV05Dataset': <class 'mmdet.datasets.lvis.LVISV05Dataset'>, 'LVISDataset': <class 'mmdet.datasets.lvis.LVISV05Dataset'>, 'LVISV1Dataset': <class 'mmdet.datasets.lvis.LVISV1Dataset'>, 'XMLDataset': <class 'mmdet.datasets.xml_style.XMLDataset'>, 'VOCDataset': <class 'mmdet.datasets.voc.VOCDataset'>, 'WIDERFaceDataset': <class 'mmdet.datasets.wider_face.WIDERFaceDataset'>, 'Custom3DDataset': <class 'mmdet3d.datasets.custom_3d.Custom3DDataset'>, 'NuScenesDataset': <class 'mmdet3d.datasets.nuscenes_dataset.NuScenesDataset'>, 'TUMTrafNuscDataset': <class 'mmdet3d.datasets.tumtraf_dataset.TUMTrafNuscDataset'>, 'TUMTrafV2XNuscDataset': <class 'mmdet3d.datasets.tumtraf_v2x_dataset.TUMTrafV2XNuscDataset'>, 'CBGSDataset': <class 'mmdet3d.datasets.dataset_wrappers.CBGSDataset'>})
completed: 0, elapsed: 0s
`

I think the paths in tools/data_converter/tumtraf_converter.py are wrong which are set from the line 97 to 104.
tumtraf_i directory includes train and val directories.
Each of the two directories has three directories (images, labels_point_clouds, point_clouds).
However, the line from 97 to 104 try to access to labels directory which is not included in train and val directories.

@Uchan1996 are you training TUMTraf-i dataset successfully?

@lacie-life
No. I've gave up using TUMTraf-I dataset.
I was able to use TUMTraf-V2X dataset for training and evaluation.
However, I found the following problems on TUMTraf-V2X dataset.

There are many bugs in TUMTraf-V2X code. You need to fix them by yourself.

The dataset size is very small as follows:
train: 800 frames
val: 100 frames
test: 100 frames

The data split of train, val and test are composed of the frames sampled from the same sequences.
I think this data split is not suitable for evaluation of trained models. The trained models just overfit the specific sequences.


Help with testing autoupdate

I followed the instructions here, however, it is not clear which manifest file I need to edit to test checkver at the end, or if that is even what needs to be run anymore, as when I ran it, there was no output and nothing changed.

What exactly do you mean? Each manifest/app has its own checkver and autoupdate information.

I mean that I'm not sure which manifest file I should be editing the version info on before running the command to check if auto-update works as intended. (For reference, I am trying to test this manifest.)

By the way, if you're not committing to the main bucket or the extras bucket there's no need to use checkver or autoupdate. Having said that, we would appreciate apps like this in extras.
Since you're not currently using main or extras, you would need to run something like ~/scoop/apps/scoop/current/bin/checkver -dir ./ love (if your current working directory is your ScoopBucket-ThirdParty source directory.
If you get output about the version then it's working, and you can add the -u parameter to do an update.
If you don't get output that means checkver couldn't find the JSON manifest, i.e. love in this case. So check the -dir parameter is pointing to the directory that contains the JSON manifest you want to check.
You can also do run it without a manifest, and it will check everything in the directory specified by -dir.

By the way, if you're not committing to the main bucket or the extras bucket there's no need to use checkver or autoupdate.

Why?

Having said that, we would appreciate apps like this in extras.

I intend to submit this and other manifests once I have them working with autoupdate, but I am making my own copy first so that if they are not accepted I will still have personal access to them.
Thank you for the detailed answer. I will try that, and assuming it works, I will close this and soon enough be opening a pull request for it. :D
(I'm not sure how to word it, but I think the wiki needs a clarification for this.)

One related question since I'm about to potentially have two buckets with the same manifest in them, how does scoop decide priority?

Why?

Because checkver and auto-update are tools to help the Scoop team maintain the main and extras buckets. If you're maintaining your own bucket then you're free to maintain it however you like.

... how does scoop decide priority?

If you don't pass an explicit bucket prefix (e.g. scoop install extras/oraclejdk), Scoop will check the main bucket first, then any other buckets in alphabetical order. The first match will be used.

Do you accept manifests without autoupdate?
(I am comfortable just using my own if you don't, but a project I'm making a manifest for only allows downloads from a browser by generating a unique URL for downloads and using a redirect.. so I'm hosting a copy of the file myself, and using that in the manifest, which would mean autoupdate wouldn't be functional unless I set up some other stuff (which I may do in the future, but requires active maintaining on my part).)

Yes we accept manifests without autoupdate, especially when it's hard or impossible to do an autoupdate as it seems in the case of this project you mentioned. It's better to have a potentially out of date manifest than none at all.

Cool, I'll be passing that one along as well then. :D


Ref #106 - Automatically attach the debugger once ready

fixes #106
Motivation
Thanks to https://issues.apache.org/jira/browse/CAMEL-18217, it is now possible to suspend the message processing by setting an environment. This feature can be leveraged to avoid having to explicitly add a sleep in the code in order to ensure that all the breakpoints have been added.
Modifications:

Add the support of configuration done to be able to automatically attach the debugger once ready
Upgrade the version of Camel to have access to the changes for https://issues.apache.org/jira/browse/CAMEL-18217
Add junit-pioneer as test dependency to be able to set the system property within the context of a unit test
Rewrite the tests to close the context after the server to prevent warnings of type java.io.IOException: Failed to get a RMI stub: javax.naming.CommunicationException [Root exception is java.rmi.NoSuchObjectException: no such object in table]
Add the maven repository allowing to access to snapshots
Ignore IntelliJ files (not related to the initial issue)

Result
I could debug following the steps define in the blog post without the need of adding explicitly a sleep in the test case.
The configuration is then as next:
{
	"version": "2.0.0",
	"tasks": [
		{
			"label": "Start test with camel.debug profile",
			"type": "shell",
			"command": "mvn", // mvn binary of Maven must be available on command-line
			"args": [
				"test",
				"-Pcamel.debug", // This depends on your project. The goal here is to have camel-debug on the classpath.
			],
			"problemMatcher": "$camel.debug.problemMatcher",
			"presentation": {
				"reveal": "always"
			},
			"options": {
				"env": {
					"CAMEL_DEBUGGER_SUSPEND": "true" // Must be set to suspend the message processing
				}
			},
			"isBackground": true // Must be set as background as the Maven commands doesn't return until the Camel application stops.
		}
	]
}

NB:  With the latest changes in Camel, in case of Unit tests, it is no more needed to override the methods isUseDebugger and useJmx to return respectively false and true.

We need to wait for the Jenkins Job to complete to have the snapshot available with the additional methods. It should end in about 7 hours.

Thank you for the review. My answers below

I'm not at ease to switch back to a snapshot version, it will block potential intermediate release with other features. Do you know when the 3.18 release is planned?

AFAIK it should be released in July

Do the debugger now requires the Camel application under debug to be 3.18+? I think not as if i understood well, we will just have an exception logged in this case (and the feature to wait for all breakpoints to be set not working but that would be normal) If 3.18 is required, also need to update readme in the requirements section

With old versions, you get a warning in the log file and the sleep is mandatory to make it work.

using Environment variables seems not to fit advanced use cases such as remote debugging and maybe debugging several Camel application at the same time with some that doesn't need to be suspended, or to which the debugger is not attached.

I don't get what preventing you from doing that, could you please clarify a little bit more?

For next time, creating different PRs for warning fix and side code improvements and the implemented feature could ease the review.

The warning fixes have been removed from the PR

To ease the review, you may review the commits individually

BTW, any reason why the code of the methods of CamelDebugAdapterServer is executed synchronously instead of asynchronously? Do I need to do the same for configurationDone?

BTW, any reason why the code of the methods of CamelDebugAdapterServer is executed synchronously instead of asynchronously? Do I need to do the same for configurationDone?

mostly for the sake of simpler code. For now, we did not have issues of performance spotted so good enough with synchronicity.
That's good for the configurationDone to use asynchronuous calls, I think it is more in the philosophy of the Debug Adapter protocol. Also I do not think that we have to synchronize this call with another action so it remains simple enough.

There are some failing tests in the Camel build that prevent the snapshots from being published. They need to be fixed first.

Works fine with Eclipse Desktop:

and with VS Code:

If you prefer System properties, your preLaunchTask can be:
{
	"version": "2.0.0",
	"tasks": [
		{
			"label": "Start test with camel.debug profile",
			"type": "shell",
			"command": "mvn", // mvn binary of Maven must be available on command-line
			"args": [
				"test",
				"-Pcamel.debug", // This depends on your project. The goal here is to have camel-debug on the classpath.
				"-Dorg.apache.camel.debugger.suspend=true" // Must be set to suspend the message processing
			],
			"problemMatcher": "$camel.debug.problemMatcher",
			"presentation": {
				"reveal": "always"
			},
			"isBackground": true // Must be set as background as the Maven commands doesn't return until the Camel application stops.
		}
	]
}


pmessage now properly returns pattern, channel, message

In Redis Cluster mode, arg3 (message) was not getting passed to pmessage/pmessageBuffer.

Awesome! Thanks for the patch.


RAT registration via link (EXPOSUREAPP-6313)

RAT QR code registration via link
Registration can now be triggered from the consent screen as well in case the qr code is already present.
How to test:

Click on a RAT qr code (link) -> CWA should be offered, open up on the consent screen and move forward without having to pass the scan screen
Register a test (pcr, ra) via scan -> should work as before
Scan a check-in qr code with camera app-> should still work as before

Works really nice. But don't we need a different text in the consent screen in this case? It says things like "Scannen Sie nun per QRCode Ihren eigenen Test ..." and "Jeder Test kann nur einmal gescannt werden. " Although no scanning happens in this flow.

Works really nice. But don't we need a different text in the consent screen in this case? It says things like "Scannen Sie nun per QRCode Ihren eigenen Test ..." and "Jeder Test kann nur einmal gescannt werden. " Although no scanning happens in this flow.

Yes, the text does not make sense. Should probably be adapted to work for both scenarios. Will ask for a solution tomorrow.


Refactoring the Linux module: first try.

So this is a first try of the refactoring proposed in #371. It sets the tree structure up, and gives a go at the fcntl.h header. It is an interesting choice because it has type and structure definitions, generic and platform specific macros, and also POSIX and Linux specific definitions, as well as glibc and musl specific ones. So it covers more or less all possible cases.
For clarity’s sake, all definitions of this header have been placed at the end of their respective sections, along with a comment saying:
/* Header <fcntl.h> */

Doing so with all headers should make sure that a specific definition is easier to find than in the mess we have for now.
A few notes on unexpected issues.

Generally speaking, glibc and uclibc are closer together than with musl. So, for definitions found in glibc but neither musl nor uclibc, I created a gnu submodule under other (and a uclibc one, that remains empty for now).
The glibc has a structure named file_handle whose last element is a zero-sized array. This is rendered by a dynamically-sized array in Rust, but then, the struct cannot implement the Copy trait, and makes the s! macro bug. I commented that line out, but a better solution would be wished.
I use a feature file_offset64 that should be equivalent to __USE_FILE_OFFSET64. This feature must be defined in musl targets (!), but I don’t know how to make sure it is the case. As a palliative, I added the condition target_env = "musl" everywhere file_offset64 is used, but this cannot be definitive. Advice strongly wished here.

PS: I can’t test every platform at home, so there might be some remaining bugs. Will add some commits when I know where they are.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

I haven't looked carefully, but "reuse more code" and "+760 −316" diff look a bit contradicting, no? Is some new stuff added?

Yes, there is indeed some added stuff. And a part of it are comments.

So, I finally managed to put most of the bugs out. There are only three remaining, for which I have no clue. So, asking for help.
On i686-unknown-linux-musl (job 9), the test script doesn’t find the flock type, although it is undoubtedly defined in common/b32/x86.rs. Is there something weird going on with the cfg_if macro? Am I missing something?
On aarch64-unknown-linux-gnu (job 11), 5 macros seem not to be defined in the library against which the tests are done. These macros are defined here and here, each time gated by a __USE_GNU macro, so I don’t get it why the AArch64 version doesn’t have them.
On mipsel-unknown-linux-musl (job 17), if I understand the error messages correctly, the script complains about struct flock having no l_sysid field, but the musl definition has no such field: only the glibc definition has it (and uClibc too).
I don’t really understand how the tests are done so, maybe I’m missing something, or maybe the tests are wrong somehow, I don’t know. I would really use some insight here.

Thanks for the PR @GuillaumeLestringant!
Before going much farther, though, I think we may want to get on the same page about the motivation of this refactoring. Could you help walk me through what you're thinking?
Today this crate optimizes for readability rather than writing new bindings themselves. That is, we greatly favor duplication over a jungle of #[cfg]. Additionally this crate favors simple-as-possible bindings, avoiding comments/organization/otherwise. These aspects mean that working within one particular platform is almost always a breeze as there's a "path to the root" in the module hierarchy where you just pick up more bindings as you go along. Additionally when binding a new platform, you frequently just start fresh in a new module and add in everything until it starts compiling.
Finally, the duplication is all validated through the CI infrastructure on this repository. That is, basically all definitions/constants/functions are automatically verified, so there's no risk of duplication silently introducing bugs.
So given all that, could you walk me through the high level goals and rationale of this refactor? Additionally, I'm curious where this'll all end up eventually!

:umbrella: The latest upstream changes (presumably #377) made this pull request unmergeable. Please resolve the merge conflicts.


Removing clarity/_version.py

Closes #284
May want to wait for #276 and #283 to be merged (and to automate this we could perhaps enable the Pull Request Merge Queue on the repository).

Merged.
I think with local repositories it might be worth leaving the clarity/_version.py in place which can be done with git rm --cache clarity/_version.py which will just remove it from the Git database but not remove the file.
I've enabled the merge queue option on the main branch with the default options for now (they're under the Settings > Branches > branch protection rules). :+1:

Great. Thanks for fixing that.
On Thu, 13 Apr 2023 at 08:14, Neil Shephard @.***>
wrote:

Merged.
I think with local repositories it might be worth leaving the
clarity/_version.py in place which can be done with git rm --cache
clarity/_version.py which will just remove it from the Git database but
not remove the file.
I've enabled the merge queue option on the main branch with the default
options for now (they're under the Settings > Branches > branch
protection rules). 👍
—
Reply to this email directly, view it on GitHub
https://github.com/claritychallenge/clarity/pull/285#issuecomment-1506467464,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACO7SJHTAO3YJHNOUDZNMO3XA6RURANCNFSM6AAAAAAW3TLKSE
.
You are receiving this because your review was requested.Message ID:
@.***>

--
Professor Jon Barker,
Department of Computer Science,
University of Sheffield
+44 (0)<PHONE_NUMBER>


Connect Twitter Account

We should have a way to connect a Twitter account to a collective. This will enable us to:

publicly acknowledge and welcome new backers: "@xdamman thanks for backing us!"
send a monthly tweet to thanks the sponsors: "We would like to thanks our sponsors @gitlab, @yahoo and @skycatch. Become a sponsor: https://OpenCollective.com/RailsGirlsAtl/sponsors"

For now, we don't need to worry too much about the UX. We just need a way to connect the Twitter account.
We should have page /:collective/connect/:service, e.g. https://opencollective.com/RailsGirlsAtl/connect/twitter with a button "Connect your Twitter account". This should create a new row in the ConnectedAccounts table with a link to the GroupId of the collective.
Then at the API level, we should have an easy to use function to send a tweet on behalf of a collective.

I would also add Github to help with https://github.com/OpenCollective/OpenCollective/issues/33

Github ongoing in
https://github.com/OpenCollective/api/pull/324
https://github.com/OpenCollective/website/pull/204

You should probably use Vorpal.js and do all the twitter stuff via the command line. Vorpal.js is epic.

Tweeting done in https://github.com/OpenCollective/opencollective-api/pull/450
Still to-do monthly thanking of sponsors in separate PR


How to revert to previous location after auth-loginCancelled?

When event:auth-loginRequired event is fired on a route change promise, the location has already changed to the new route. How can i revert that location change on the auth-loginCancelled event?

Hi, I was recently faced with the same problem. My solution is pretty simple:
app.run([ '$rootScope', '$location', function ($rootScope,$location) {
    $rootScope.previousLocation = '/';
    $rootScope.currentLocation = '/';
    /** Simply switch the Locations and save the new to current */
    $rootScope.$on("$locationChangeStart", function (e, currentLocation, previousLocation) {
        $rootScope.previousLocation = $rootScope.currentLocation;
        $rootScope.currentLocation = $location.path();
    });
    /** Switch back */
    $rootScope.$on("event:auth-loginCancelled", function (data) {
        $location.path($rootScope.previousLocation);
    });
}]);

I hope it helps :)

This is useful solution and I may use it.  But I might expend it to something that keeps track of entire history of routes, providing better functionality for a back/forward buttons.  Yes I know browsers can do this, but on mobile I'd prefer to render my own buttons (or rather map it to drag left/right).

Hi @wcyrek-comrise the history remains intact.

I think it all goes too far. My experience is that we should never tinker with location on authentication events. This module works best when used as in demo:

you do something,
then controllers or services ask for data,
then server returns 401 (o something else),
then we just hide (without destroying the DOM content and anything attached to it) the application and show the login dialog (or something else),
finally we find out the user is now authenticated, so we fire authenticated event and unhide the application,
it continues where it was blocked by 401 as nothing happened, so the mentioned controllers or services does not even know there was an issue in the meantime.

The only exception to this rule is when the newly logged user is not the same as previously, so we discard all the cached requests and everything and redirect to a landing page.


Feature Request: Apply-Changes should have flag to run errands

When running the apply-changes command, it would be nice to be able to specify which errands to run on-the-fly, similar to Triggering-an-install-process allows.
We could form the  json string similar to below, and the tool would substitute the product-name for the product-guid:
{
  "enabled_errands": {
    "<product-name, i.e. cf>": {
      "post_deploy_errands": [
        "smoke-tests",
        "push-apps-manager",
        "notifications",
        "notifications-ui",
        "push-pivotal-account",
        "autoscaling",
        "autoscaling-register-broker"
      ]
    }
  }
}

Hi @DonBower, can I ask for a clarification for how this is different that your earlier request in #92?

Hey @ryanmoran!
Great question!
My answer is... uh,... er,... ok, I just forgot I put it in, and for whatever reason I did not see it..
Let me clarify #92 with how it might be implemented with the comments I made in this one, and we can close this one out.

This issue is duplicated here: https://github.com/pivotal-cf/om/issues/92


xvcd "works", but Vivado says "No devices detected on target"

I'm trying to get an artyboard a7 working; it shows up in lsusb as having the compatible device (vendor 0x0403, product 0x6010). xvcd starts up okay, doesn't complain about missing devices, and patiently begins to listen on 2542. When I open Vivado in the container, in the hardware manager, the auto-connect feature quickly finds a "target" at host.docker.internal:2542. However, I get an error saying no devices are detected, and hence I'm unable to flash my bitstream.
I saw that @james-kollross had this exact issue, in the somewhat unrelated thread https://github.com/ichi4096/vivado-on-silicon-mac/issues/20#issuecomment-1716804381. I don't know if it was ever resolved though?
Any help would be greatly appreciated! Thanks for the amazing project :)

Oh, also to add, I ran xvcd with extra verbosity, and from the moment I hit auto-connect in Vivado, I see a bunch of "shift" commands coming through to the xvcd server, with some inscrutible binary payload. It seems to be the same command(s) over and over. Maybe it's some kind of probe to determine what device is on the other end?

This is because the FT2232HQ USB bridge chip in your board is not supported by this version of xvcd, which only supports the FT2232C chip. Since I have a board with your FTDI chip, I may add support for it in the future.

Ah thanks, I did not realize there were different chips with the same VID/PID. I might be able to send a PR, will give it a go 👍

So, I was able to get xvcd working with my a7 board. After much experientation, it turns out all that needed to change was the value of PORT_MISC here:
https://github.com/ichi4096/vivado-on-silicon-mac/blob/50f820f097ee3febf12be7931e13a9d595d05acf/scripts/xvcd/src/io_ftdi.c#L16
Setting this constant to 0x80 solved my issue. As far as I understand, this just toggles whether or not pin 4 (a.k.a. GPIOL0) is configured for bitbang output. If the 0x80 value works for the other board(s) you test on, perhaps we can set this as the default? Otherwise, we can use ftdi->type to determine whether the resolved peripheral is FT2232C or FT2232H, and automatically set the appropriate value.
Let me know which one you prefer, and I'd be happy to send a PR.

I'm actually not familiar with how FTDI chips work, so I can't really reason about which bitmask makes sense. But according to this document, the xvcd code follows neither the asynchronous nor the synchronous bitbang mode bitmasks. See this and the immediately following line of code and the relevant libftdi documentation. Since it all seems a bit inconsistent to me anyway, I'd be fine with changing the value to 0x80. I myself no longer have access to an FPGA with a FT2232C chip, so I can't test with it.

Yes, I saw that line setting initially all pins to CBUS, and then only select pins to SYNCBB. And after staring at the datasheets and the not-so-informative libftdi documentation, I don't really understand what's going on either.
I assume at some point you had tested this xvcd implementation on a FT2232C chip? If so, the existing value is a known-good-configuration for that board. So instead of potentially breaking compatibility, I will just send you a PR that automatically chooses between 0x90 and 0x80 based on the detected hardware. It might be helpful anyway for supporting any other chips people come across in the future.

I did originally have access to an FPGA with the FT2232C chip. Maybe I'll get around to testing it in a week or two, but I can't promise that since it's my universitiy's property.
I take some issue with introducing control flow into an application we don't fundamentally understand to support a device we can't test with. But if it's only minor changes and it works with the FT2232H chip, I'll accept your PR.


[BUG] Shouldn't have to define which are primary and co-benefit for "none" and "unknown"

Question 3.1, 3.2, 3.3
When you select "none" and/or "unknown", it still prompts you to select how stakeholders benefit. This doesn't make sense for none and unknow options since there are no aims for the stakeholders to benefit from.

@mmnoo not sure if you want to tackle this one since you worked on this section - but if you're deep in other tasks I can take a look at this one


[PLT-8662] Fix paste upload issue

Summary
Fix paste upload issue
When image from clipboard is pasted into the post textbox, the filename of the image gets posted to the textbox as well. Not sure if that's expected but maybe worth checking from the PM.
@esethna Could you please help validate? Thanks!
Ticket Link
Jira ticket: PLT-8662
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0fe79ab6f3543dfae.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1

@stephenkiers Yeah, I'm seeing issue when pasting image but not sure if we support it or a regression. I've tried older version but looks the same behavior. Issues like:

copying image file from local and pasting to textbox uploads the image but filename is pasted into the textbox as well
same when I copy image from the web (e.g. google image), the image uploads but the link is also pasted into the textbox

@esethna Could you please test pasting images and let me know what issues that needs to resolve? Thanks!


How to specify the running working directory?

+1

There is no supported way to do this currently. Feel free to submit a patch!


test: extract prometheus rules for tests

Our Prometheus rules are stored as Kubernetes objects, but promtool which is used for unit tests requires them to be on their own. This change extract the rules to a rule file as part the script that runs the unit tests.

LGTM, very useful

Our Prometheus rules are stored as Kubernetes objects, but promtool which is used for unit tests requires them to be on their own. This change extract the rules to a rule file as part the script that runs the unit tests.

Same thing with pint.
Looking at promtool's documentation, I see this:
https://prometheus.io/docs/prometheus/latest/configuration/recording_rules/#syntax-checking-rules
I wonder how much it overlaps with pint... we might be fine just with one of them.

 ):

Was thinking the same myself, and then found this thread: https://stackoverflow.com/a/15437697


WIP: fix: cookie-less auth cleanup. remove credentials: include

Since the AEM Sidekick no longer uses cookies for authentication to Admin, we can remove the credentials: 'include' option from fetch requests to Admin.
WIP: need to do more manual E2E testing directly in the browser to confirm that everything still works as expected.

@andreituicu we're going to have to merge this into a feature branch on the original repo to make sure all checks are being run before we merge it into main.

@rofe I pushed the branch directly in the repo https://github.com/adobe/helix-sidekick-extension/tree/remove-credentials-include , looks like this triggered the checks. If you'd like I can close this PR and re-open it directly from the branch in the repo to have everything cleanly executed.

Did the same level of testing as on the new sidekick.
As mentioned in https://github.com/adobe/aem-sidekick/pull/353#issuecomment-2474182346 , I would maybe give it a few more days before merging to see if there are any reports of problems in the new sidekick.

@andreituicu is this one good to merge now?

@rofe I think yes. The new sidekick has the same code already in place for 2 weeks and there were no complains, so I think it should be safe. thank you!

Continued in #853


Update copyright years of auto-generated header files to 2021

Apparently I've been the only one since New Year who has been submitting or updating PRs.
It turns out there is an issue with make update,
and this PR just provides a quick workaround for 2021.
I've labeled this urgent since without it the CI check_update fails.

This was really quick (and sufficiently trivial) - thanks @mspncp.
Merged.

This was really quick (and sufficiently trivial) - thanks @mspncp.
Merged.

Don't folks do a "make update" as part of doing a complete build before submitting a PR?  You should; it would catch this.

Don't folks do a "make update" as part of doing a complete build before submitting a PR?  You should; it would catch this.

Don't folks do a "make update" as part of doing a complete build before submitting a PR? You should; it would catch this.

I thought so, too, and had tried it, but it did not help in this case.

Don't folks do a "make update" as part of doing a complete build before submitting a PR? You should; it would catch this.

I thought so, too, and had tried it, but it did not help in this case.

but it did not help in this case

oh, that's disappointing.  I'll add some comments to #13765 and not this closed thread.

but it did not help in this case

oh, that's disappointing.  I'll add some comments to #13765 and not this closed thread.


Don't silence errors when loading tasks

This changes the behavior of exceptions encountered when loading tasks, so that they are just thrown immediately. It includes an example task that imports a module that doesn't exist.
Before this PR, the behavior is that if a module has an error, it will not be loaded, and a message will be printed with the DEBUG log level (which by default means no output). If you try to use the task, you will get an error that it doesn't exist.
After this PR, the exception will be thrown when loading tasks, even if this specific task is invoked.
I'm suggesting this PR because I believe the current behavior is very confusing. In particular, when adding new tasks, getting an error that the task doesn't exist suggests that there's a typo in the name, or that it needed an extra step to be registered, or some other problem, instead of a problem with the task itself. (This is also the only time in adding new tasks that I had to change the verbosity level, and I only figured out I needed to do it by digging through the code.)
A more moderate change would be to make the warning level WARNING or higher. Given that the WARNING level is used even for things like using the default "higher is better" option for metrics, I think errors should have at least that level.
On the other hand, I think it's better to just have these errors be raised - I can't imagine a situation in which it makes sense to have tasks in the repo where the code isn't functional. Is there some case this is designed to handle?
Note this should not be merged without removing the failing task.

You can use --verbosity DEBUG to see the errors. Silencing was meant so that if any task were to suddenly break (for example, a dataset from hf was changed or removed) it would not bother users who may not be using that specific task.

I figured out that I can use --verbosity DEBUG to see the errors, but I don't understand why the log level is so low.
Would a change to a dataset cause errors for tasks you aren't using?

This changes the behavior of exceptions encountered when loading tasks, so that they are just thrown immediately. It includes an example task that imports a module that doesn't exist.

Some tasks have specific dependencies (e.g. importing the prompts from promptstore or sympy for processing results) and we should avoid throwing an exception just because one task encounters an error. I guess this logging behaviour was chosen as a compromise between cluttering the logger and providing detail in cases where there are issues with specific tasks. We could improve the default error message with better signposting, I guess:
https://github.com/EleutherAI/lm-evaluation-harness/blob/3ab5a262ce32af71a3c9e17959a61a56242652d9/lm_eval/__main__.py#L204-L206

As mentioned by @baberabb the reason we did this was so that tasks which require especially promptsource as a dependency (which we don’t want to make mandatory)
Would signposting the use of DEBUG when adding a new task in particular resolve this confusion and nonintuitiveness? If not, we could merge your fix / make the log level of registration errors WARNING and handle promptsource-requiring tasks separately with a more concise log message, or simply raise the importError only when a task is called by a user.

Given that the WARNING level is used even for things like using the default "higher is better" option for metrics, I think errors should have at least that level.

We should probably downgrade this message to INFO.

Thanks for the feedback, that makes the kind of errors you're dealing with more clear to me.

Would signposting the use of DEBUG when adding a new task in particular resolve this confusion and nonintuitiveness?

I think that would definitely help. When you say signposting, do you just mean in the docs though? I think that would still be easy to miss, unfortunately. At a minimum I would suggest handling Import or ModuleNotFound errors from syntax errors or other bugs - the main point of confusion for me here was trying to figure out if I'd done something wrong registering my task, when actually the error was something else entirely.

If not, we could merge your fix / make the log level of registration errors WARNING and handle promptsource-requiring tasks separately with a more concise log message, or simply raise the importError only when a task is called by a user.

This would be great from a usage perspective. When I was working on spaCy, we used a similar approach where language-specific imports were not called until strictly necessary, and had an error message that explained the dependencies. You can see an example for Japanese here.
I wondered how many tasks currently have issues, so I checked which tasks can't be loaded with my current install and found only two, both using promptsource:

t0_eval
flan_cot

So it looks like if special handling was added for promptsource, these warnings could be made more prominent without affecting normal usage.

Great, it sounds like we have a path forward on this!
(making ImportErrors or ModuleNotFoundErrors handled separately, with one single warning or info message stating that if a task you expect to find can't be registered/found, you may need to install dependencies (promptsource/[ifeval] extra/sympy/etc...). And setting other error types to a Warning level)
Would you be interested in making some of these changes in a PR? If not, we can make a separate PR carrying out this fix.

It would probably be better to separate this and let this PR handle the new task.

My understanding is that the task added in this PR is a temporary demo failing-registry task and shouldn't be merged?

Oh, I misread what the yaml was for. 😂

Would you be interested in making some of these changes in a PR? If not, we can make a separate PR carrying out this fix.

Sure, I'd be glad to put this together - I'll try to get to it tomorrow.

Sorry for the delay in reviewing this, been away for the holidays!
This looks good to me, thank you very much for the contributions and feedback!


Error in the lite-xl version

Changed the issue because the original issue was fixed

It looks like this


Copy to clipboard component - minor issues

The react implementation highlighted some changes needed:

[x] Right-hand border on focus for the expand button is cut off by the input
[x] When using expandable content and after speaking with @mcarrano, we should disable the top input and use a contenteditable div for the section below.  Not sure what the treatment of the div should be (readonly/leave white?)

:tada: This issue has been resolved in version 2.12.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Css transform property is not working

transform="skew(0deg, -7.5deg)"
Where  can i get the complete list supporting css property in mjml?

Hey @sinhasagar01, you can see in the documentation the list of MJML attributes for a given MJML element: https://mjml.io/documentation/#standard-body-components
Note that you can use your own custom css (and even inline it automatically) with mj-style: https://mjml.io/documentation/#mjml-style


API: Support glob pattern "**/!(*.min).js" for file watchers

I am trying to write an extension, and I am wondering how I can take this pattern:
glob(vscode.workspace.rootPath + '/**/!(*.min).js', (err, files) => {
    console.log(files);
})

And use it here:
let watcher = vscode.workspace.createFileSystemWatcher('**/!(*.min).js', true, false, true);

It seems as if the !(*.min) is not supported. It would be nice if either:
A !() was supported
OR
B There is another parameter for ignoring files similar to vscode.workspace.findFiles()

Our glob patterns currently do not support negation.

+1 on this, was wondering why my standard globs weren't working

@jpike88 and @Xunnamius It looks like they have added it to the docs: https://code.visualstudio.com/docs/extensionAPI/vscode-api#GlobPattern

Is there going to be future support for negation?
E.g. I have a situation where I want a language client (which also uses VS Code APIs to match file globs) to conditionally send LSP traffic to a server, based on where the document that's involved lives in the file-system. See this code pointer.
I would like to exclude certain subdirectories from my glob.  Currently, to my understanding, I can't do this, unless I use per-character negation (as the vscode documentation indicates is supported), to do something like is mentioned in the following comment.

cc: @bpasero

What is the status on this issue? It would be very helpful to be able to exclude certain folders and files from the file watcher. I agree that having another parameter to specify exclusions would be one nice solution.

Well, please reconsider. I've got a case where I need to exclude node_modules from source map lookups, but I've got my own module that I'm developing and this one needs to not be excluded. I think that it's a valid case and inability to negate path fragment from outFiles and resolveSourceMapLocations prevents from doing that. @bpasero


KYLIN-3721 modify sourceCacheKey for RDBMS

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 3969

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0004%) to 25.81%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-metadata/src/main/java/org/apache/kylin/source/SourceManager.java
0
2
0.0%

Totals

Change from base Build 3967:
-0.0004%

Covered Lines:
17823

Relevant Lines:
69055

💛  - Coveralls


Add a confirmation when publishing a non-existing crate on crates.io

Right now, executing cargo publish automatically publishes the crate on crates.io without any confirmation.
This could lead to "oops, I just wanted to try the command" or "oops, I was in the wrong directory and accidentally published my super-top-secret repo instead of my public project" moments.

Accidentally publishing a super-top-secret repo came to my mind as well today. It would be nice to be able to add something like publish = false to the [package] section and prevent any publishing at all.
Maybe even the other way around: since almost every project will be using cargo to manage dependencies, but people most probably don't want to publish everything, publishing could be disabled by default unless you explicitly turn it on with publish = true.

@zargony npm has a private field for this, which would be really nice to have in cargo.

If you set "private": true in your package.json, then npm will refuse to publish it.
This is a way to prevent accidental publication of private repositories. If you would like to ensure that a given package is only ever published to a specific registry (for example, an internal registry), then use the publishConfig dictionary described below to override the registry config param at publish-time.

https://docs.npmjs.com/files/package.json#private

Related: #2202 (RFC: Add option to mark a crate "private" so it's not publishable to crates.io)

A common UI-solution is to have the user confirm his intend by re-typing the name of the crate instead of just hitting some please-go-away-message on the head.

Almost done! Cargo is about to publish a the new crate "foobar" to http://crates.io for people around the world to use it. Please confirm that this is what you want by typing "foobar" down below or hit Ctrl+C to cancel.
The crate about to be published will go by the name... > foobar
All done...

I would go as far as making publish = false a default setting for new crates.

The private option seems to have been merged into Cargo (though I can't seem to find it documented), and I think that addresses this bug.

It's documented here: https://doc.rust-lang.org/cargo/reference/manifest.html#the-publish--field-optional

@ehuss Ah, thanks!


Tabs Overflow Example

Description

Updated the example of how to handle overflowing tabs based on the updated guidelines. "When there are too many tabs to fit horizontally across the viewport, the tabs component can be displayed as a quiet dropdown."
Related Issue

https://github.com/adobe/spectrum-css/issues/58
Motivation and Context

This example is necessary to aid in proper implementations across component libraries
How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.

Well that's a whole heck of a lot simpler. Thanks @NateBaldwinDesign!


confusion about bic calculation

xmeans.py (line 119):
t4 = (fRn - 1.0) / 2.0

why not
t4 = (fRn - len(clusters)) / 2.0

according to the paper (3.2 BIC Scoring)

Hey @porcobosso... I'd love to give you an answer, but this code was written a while ago and to tell you the truth I just don't recall.  I did just run the benchmark with the proposed change and got better resulting clusters.  Care to make a pull request?

its ok the way it is. there is a typo in the xmeans paper.
t4 is in a loop summing over all clusters so sum_n(Rn-1) = R-N
however, as explained here:  https://github.com/bobhancock/goxmeans/blob/master/doc/BIC_notes.pdf
i think there should be an additional factor num_dims in t4 as well as in the denominator of the variance. see eq 16 and 19 in paper. should i open a new issue for this?

@eyaler Good research!  It'd be great if you could open a new pull request for that.  I'll close this request due to inactivity and wait for yours... thanks!


Migrate to Django 4.2 storage object syntax

Description
Django 4.2 changed the way storage objects can be defined. A subclassing in the storages.py is not necessary anymore and storages can be defined like so in the settings file instead:
STORAGES = {
    "default": {
        "BACKEND": "storages.backends.s3.S3Storage",
        "OPTIONS": {
          ...your_options_here
        },
    },
}

Django-storages "strongly encourages" the switch to this way of defining the storage objects, as written in the documentation.
Rationale
This would be in line with django-storages documentation, simplify the code base by deleting the storages.py file, and would give an easy possibility to add more storage objects.
Solution
If it needs to be changed, I can do it.

Duplicate of #4443


Power infusion Cooldown

Describe the bug
Power Infusion (discipline priest tier7 talent) does not use the WOTLK cooldown of 2 minutes (tested in Shadow Priest and Smite Priest Sim the casts are 3 min apart even when selecting cooldowns manually).
Also the cd is not affected by the cd reduction when speccing into Aspiration (discipline priest tier8 talent)
To Reproduce
Run any Sim with Power Infustion active.
go to detailed results > timeline > DPS and verify cd usage
Expected behavior
Power Infusion should be up every 2 minutes (or less when speccing into aspiration)
Sim Links and Screenshots
If applicable, add links to your sim settings or screenshots to help explain your problem.
Desktop (please complete the following information):

Device: PC
OS: Win10
Browser Firefox
Version 103.0.2

Smartphone (please complete the following information):
N/A
Additional context
Add any other context about the problem here.

This was fixed a few hours ago. Thanks!


python311Packages.google-i18n-address: 3.0.0 -> 3.1.0

Diff: https://github.com/mirumee/google-i18n-address/compare/refs/tags/3.0.0...3.1.0
Changelog: https://github.com/mirumee/google-i18n-address/releases/tag/3.1.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240203 run on x86_64-linux 1

8 packages built:

python310Packages.google-i18n-address
python310Packages.google-i18n-address.dist
xml2rfc (python310Packages.xml2rfc)
xml2rfc.dist (python310Packages.xml2rfc.dist)
python311Packages.google-i18n-address
python311Packages.google-i18n-address.dist
python311Packages.xml2rfc
python311Packages.xml2rfc.dist


How do you sample frames for training?

Hi @jonathancstroud
The example code reads the first 64 frames of kinetics video as input.
I wonder how do you sample frames from videos during training? e.g. how many frames do you sample per video, what frame rate, do you randomly sample a clip, do you have different settings for Kinetics400, UCF101 and HMDB51?
Thank you very much!

Hello, and thank you for you interest in this work. During training, we sample 64 frames per video at 25 frames per second. The clips are randomly chosen from the 10-second video (250 frames total). The video frames are each resized to 256x256 and then we take a 224x224 random crop. We use the same settings for training on all datasets, padding the clips if necessary.

So you randomly sample 64/25=2.5 seconds from each 10-second video, right?

Yes, that is correct.


GL_INCOMPATIBLE & WEBCAM_UNAVAILABLE issues coming up in couple of mobiles for my application but the demo works fine

Hi there!! First of all, Thank you so much for this wonderful library with so many useful features. I've integrated it in my Angular 10 project and it's working absolutely fine for most of the cases. But, I'm getting issues for couple of mobile devices I've tested on and I wonder why.
Before I begin with the issue, my application is a 2-step Proof of Identity verification process where user is requested to take an image of the POI document and once done, user facing camera opens up and with the help of JeelizFaceFilter, system tries to track a face in the video feed. Once tracked, an image is taken automatically then user is requested to turn head towards right or left and once that activity tracked, again an image is taken and the process completes.
For most of the mobile devices it works fine. But, for OnePlus 1 (Android 6, Chrome  86.0.4240.75) it's not working and throwing error "GL_INCOMPATIBLE". The device has no WebGL2 and here's extentions available for WebGL.

Curious is, the demo of jeeliz threejs/cube works fine on the device but through application, it always throws error as 'GL_INCOMPATIBLE' do you have any idea why this could happen?
For Samsung Galaxy S10  (Android 9, Chrome  85) it always shows "WEBCAM_UNAVAILABLE" even after user refreshes the page quite a few times. For this device also, the demo of jeeliz threejs/cube works fine.
I'm having no clue why these issues are keep popping up. Any suggestion would be great help. I've already checked all the related closed issues but nothing helped.

If the demo of threejs/cube works fine, it is not a problem with this library but an integration error.
Maybe the dimensions of your canvas are null or the video is not ready to play or there is something wrong with the canvas (a context already created, ...). Unfortunately, I don't use Angular.

Thanks @xavierjs for your feedback. I also suspect so, but the apllication runs smooth on most of the mobiles I've tested(iphone 5,6, Realme 3pro, Redmi note 5, Samsung A31). If the canvas had any issue, it would occur for all devices I've tested with.

Can you share your code so that I can see


{CI} Bump certifi from 2021.10.8 to 2022.12.7

Certifi 2022.12.07 removes root certificates from "TrustCor" from the root store. These are in the process of being removed from Mozilla's trust store.
TrustCor's root certificates are being removed pursuant to an investigation prompted by media reporting that TrustCor's ownership also operated a business that produced spyware. Conclusions of Mozilla's investigation can be found here.
Dependabot alerts:
https://github.com/Azure/azure-cli/security/dependabot/10
https://github.com/Azure/azure-cli/security/dependabot/11
https://github.com/Azure/azure-cli/security/dependabot/12

Bump certifi

😲

This is actually a duplicate of https://github.com/Azure/azure-cli/pull/24842


Provide a path when uploading

The widget automatically uploads to the current working directory.

[x] Have an option to upload to a custom directory.

Would you like me to make a pull request? @tmtabor
I can do that this week.

Sure! That would be great.

@tmtabor I have the changes, but I am unable to push my branch for pull request.  I need permission to push my branch for pull request.

Test code I used @tmtabor
import ipyuploads
import ipywidgets

output = ipywidgets.Output()

def chunk_complete(name, count, total):
    """Callback to be executed when a chunk finishes uploading

       name - Name of the file being uploaded
       count - A counter of which chunk just finished uploading
       total - The total number of chunks in this file"""
    with output:
        print(f'CHUNK CALLBACK! {name} {count} {total}')

def file_complete(name):
    """Callback to be executed when a file finishes uploading

       name - Name of the file that was just uploaded"""
    with output:
        print('FILE CALLBACK! ' + name)

def all_files_complete(metadatas):
    """Callback to be executed once all selected files finish uploading

       metadatas - A list of metadata objects, one for each file. Each contains:
                   { 'name': 'the file's name',
                     'type': 'mime-type of the file',
                     'last_modified': last modified data as an integer
                                      (number of milliseconds since the epoch) }"""
    with output:
        print(f'ALL FILES CALLBACK! {metadatas}')

custom_path = "./test_folder"
a = ipyuploads.Upload(accept='txt',           # Accept only text files
                  multiple=True,          # Upload multiple files at once
                  disabled=False,          # Disable the widget
                  icon='cloud-upload',    # Change the upload icon
                  button_stye='primary',  # Change the button style
                  error='Bad Error',      # Set the error message
                  busy=False,             # Whether an upload is in progress
                  chunk_complete=chunk_complete,     # Callback when a chunk upload completes
                  file_complete=file_complete,      # Callback when a file upload completes
                  all_files_complete=all_files_complete, # Callback when all files complete
                  custom_path=custom_path
                  )

a.custom_path
display(a, output)

You should be able to fork the repository, check in the code to your fork and then send a pull request from your fork back to the upstream repo. At least, that's the pull request workflow I'm familiar with on Github.

You should be able to fork the repository, check in the code to your fork and then send a pull request from your fork back to the upstream repo. At least, that's the pull request workflow I'm familiar with on Github.

Ahh copy that. Done. https://github.com/g2nb/ipyuploads/pull/4

Any chance your team can have a new version .0..2.3 deployed next week once the PR gets reviewed/approved? I currently have to modify the code from pip install to get it working to use custom paths. @tmtabor

No problem. I'll get it reviewed and released on Monday.

Thanks for the quick reply from you and your team @tmtabor !