Initial HA support for MT Kafka source

Fixes #463

Proposed Changes

Controller has new env var to control "scheduler policy type",
Stateful set adapter has new anti-affinity rules for pods to be placed on new nodes in new zone topology,
"scheduler policy type" is an enum with two values currently MaxFillup and EvenSpread. For EvenSpread, scheduler places vreplicas for HA by spreading replicas equally across zones. Within a zone, vreplicas are filled up in each pod upto capacity. If MaxFillup strategy is chosen, scheduler places vreplicas in existing pods and fills them up before creating new pods (zones aren't considered)
Placement type in KafkaSource status has a new type for ZoneName when EvenSpread scheduling
HA controls are also shared with autoscaler, and state accessor
State accessor computes the number of zones in cluster and stores a map of node name to zone info

Release Note

Testing continues on my end....
Few more things remaining to solve in this PR, (or in separate future ones):

Implementing HA across pods within a zone (# of pods is not static unlike # of zones, so spreading equally may also mean rebalancing) [TBD]
When multiple kafkasources with large # of consumers are installed, a race condition creates pods to have more vreplicas than capacity (non-HA problem too?) Error msg: {"level":"info","ts":"2021-05-03T20:53:31.852Z","logger":"kafka-controller","caller":"statefulset/state.go:126","msg":"pod is overcommitted","podName":"kafkasource-mt-adapter-5"}
Using kubeclient to get pod info doesn't always work. Some times error is returned. Trying again may cause it to succeed. https://github.com/knative-sandbox/eventing-kafka/pull/587#discussion_r623980525 Not sure why this happens from researching on kubernetes issues opened.
Currently, number of zones and node to zone information is computed and stored in State accessor when state() is called. We need a watch for zone/node changes to recompute.
cc: @lionelvillard

/retest

/retest

/retest

Test files in this PR depend on https://github.com/knative/eventing/pull/5360

/retest

Let's get this in so we can move forward with the issues raised during the review.
Thanks @aavarghese this is amazing work!


Replace usage of fresh names with friendly names

When creating an ops class for a kind 1 type constructor, we parameterize the ops class by 2 type parameters -- the type constructor and a kind 0 type parameter that's applied to the type constructor.
For example, the Ops for a Functor type looks like:
trait Ops[F[_], fresh$macro$3] { ... }

We generate a fresh name for the kind 0 type in order to handle cases where different methods on the type class use different type parameter names. For instance, consider this pathological case:
@typeclass trait Functor[F[_]] {
  def map[A, B](fa: F[A])(f: A => B): F[B]
  def as[B, A](fb: F[B])(f: => A): F[A]
}

When generating the ops class, A must be lifted out of map's signature while B must be lifted out of as's signature. So currently, we generate a fresh name for the lifted type param and rewrite all references to it.
However, ScalaDoc and compiler error messages end up with a lot of noise as a result of the fresh names.
Instead, we could use a strategy that tries to use one char type names, A through Z. We'd select the first name that doesn't conflict with a type param in any of the methods on the ops class.
In the example above, this would result in:
trait Ops[F[_], C] {
  def map[B](fa: F[C])(f: C => B): F[B]
  def as[A](fb: F[C])(f: => A): F[A]
}

More typical type classes would result in Ops[F[_], A].

This seems good to me. I think unless you were nesting type class definitions inside of parameterized classes there is basically no downside to this approach.
:+1:


Change Roboto Slab Thin OS/2 usWeightClass?

see googlefonts/fontbakery#1355

can be ignored here


Feature/dx 1624 add border to accordion table

This PR aim to make to accordion component more visible. Especially when .hide is active.
The build process is failed. I can't quite figure out why. Could you assist @asbjornu?

We can’t merge this to main before the sidebar is done.


added dynamic cover photo

Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

This pull request resolves issue #3.

Hi @akshgpt7, could you have a look when you are free? Thanks :)

LGTM!
Thanks for taking this up.

@akshgpt7 just resolved the merge conflicts, thanks!

Perfect, thanks a lot!


Visually distinct UI elements for enabled/disabled widgets

I reviewed and updated the PR by @tdgunes as I saw fit.
All open issues should be fixed now.
Supersedes and includes #2288
Fixes #2277

Hooray Jenkins reported success with all tests good!


added Enfys the Rainbow elephpant

https://www.kickstarter.com/projects/1817732114/the-phpdiversity-rainbow-elephpant
Based on https://github.com/MarkBaker/afieldguidetoelephpants/commit/a813bb0b14ddd4222e29d2ba1dd67357c5c8d0c6

I like to wait until the campaign is finished before adding any Kickstarted elephpants. I'm going to leave this open until then.

@philipsharp But if we add it now it may help raise awareness of the campaign, which still has a ways to go to meet its goal.

@philipsharp this project was successfully funded 42 days ago.

👍  For the Diversity Elephpant


fix: Change command gsutil to gcloud storage.

gsutil is not the recommended CLI for Cloud Storage.
Use gcloud storage commands in the Google Cloud CLI instead.
ref) https://cloud.google.com/storage/docs/gsutil
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Follow the CONTRIBUTING Guide.
[x] You are listed as the author in your notebook or README file.

[x] Your account is listed in CODEOWNERS for the file(s).

[x] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[x] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[x] Appropriate docs were updated (if necessary)

@bearfield Thanks for the PR, please fill out the Google CLA here: https://cla.developers.google.com/

Closing due to inactivity. Please re-open once the CLA is signed


Switch to travis-ci.COM

Migrated from travis-ci.ORG to travis-ci.COM for faster builds

Add the following to .travis.yml should be able to elimiate duplicate branch build:
# Build master branch only
branches:
  only:
    - master


[CSM] Enable dump auto suppression by default

What does this PR do?

This PR enables the dump auto suppression feature by default.
Motivation

This feature is ready to be enabled by default.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Bugfix for document

Description
This PR applied Jun's comments about product page.

wait please.

wait please.

@LinlinCui-NOAA please add this argument -p number of pressure levels for run_graphcast.py. Thanks

@LinlinCui-NOAA Now you can merge it. Thanks


Require stunnel in mariadb image

SST transfers can be encrypted with socat when the transfer method is mariabackup or rsync_tunnel. Starting mariadb 10.5, the later can be replaced by the rsync transfer method, which gain support for encrypted SST via stunnel.
Add stunnel in the mariadb image to be able to deprecate rsync_tunnel, which was implemented before rsync supported encryption.

/lgtm


Fix deadlock issue when source dependency has buildSrc

https://github.com/lacasseio/vscode-gradle-plugin/tree/lacasseio/exemplar has a source dependency on https://github.com/gradle/exemplar, which has a buildSrc.  With the single project lock, this causes the buildSrc project to be built here while the project state registry lock is being held.  This then creates a deadlock while the buildSrc build executes.

PR https://github.com/gradle/gradle/pull/7411
@lacasseio I verified that it fixes the issue with vscode-gradle-plugin - can you take a look at ☝ ?

Looks good, Sterling already reviewed it and merged it. I merged release in master so I will close the issue.


Running kubescape on clusters yaml produces "empty list of workloads"

While kubescape scan framework nsa works as expected getting the clusters yaml first and then running it through kubescape produces empty list of workloads - no workloads found:
$ kubectl get all -o yaml --all-namespaces | kubescape scan framework nsa -
ARMO security scanner starting
[progress] Downloading/Loading policy definitions
[success] Downloaded/Loaded policy
empty list of workloads - no workloads found

This issue is because the object returned from kubectl is of kind List while kubescape does not support that kind.
I fixed the issue in our dev branch this should be supported next release.
Thank you @JDemler  for finding the issue.
FYI, I do not recommend scanning a cluster this way. Normally when scanning a cluster, Kubescape removes duplications of resources e.g. when testing whether a deployment contains a hostPath, the Kubescape will test only the deployment by filtering out the replicasets and pods so the risk-score is not effected from the same miss configurations. But when you pass the resources as input file/stdin, kubescape does not filter out anything so the same resource is tested more than once.
e.g.
Testing "Allowed hostPath" control on cluster:

Testing "Allowed hostPath" control on stdin input:

Works as expected! Thank you @dwertent for this fast fix!


Mark Duplicates in Lookups/Mining Dialogue

This would be a useful feature to have similar to Yomitan's implementation for a few reasons. I feel duplicate cards are useful for some words that require a lot of different context to really undersand. Few other reasons..

Just knowing that you've added a card can give you some insight on how important that word is to you.
Mining with "Allow Duplicates" would become a lot more useful, as of right now you just mine the card and you won't know it's a duplicate until you take a look at the card or have some kind of way of notifying you that there is a duplicate.

I might look at adding this and PRing, since it would be super helpful for my setup, but no promises.

I am not familiar with how Yomitan is displaying that information, including that detail would make it easier for me to visualize exactly what is being asked here.
Regardless, here are a few things to keep in mind if you intend to create a PR for this:

Users who don't wish to use it (including me, since I don't mine at all) shouldn't have to pay for it. In other words, the existence of this feature shouldn't make lookups any slower for users who don't wish to use it.
Even for users who choose to opt into using it, its performance impact should be minimal. If a user has lots of dictionaries and happens to look up a word written in kana, JL might list lots of results. If you want this information to be shown for all results without any interaction, its performance impact might not be acceptable. Of course, this may depend on whether Anki Connect allows us to fetch the required information in batches, etc. However, if such an approach proves to have an unacceptable performance impact, then a different approach should be taken, such as requiring a button press on a specific result to show whether it's a duplicate.

I probably won't be implementing this feature myself because I don't personally have a use for it, and its performance characteristics might not be acceptable. So, if you decide not to make a PR for it, feel free to close this issue.

Sure,

Here is how Yomitan displays it. It also allows you to open the anki note with the button to the left of that (the book), which would also be nice to have, but I don't want to add any buttons, JL seems to be more focused on playing rather than mining, which i totally agree with.
This will likely just end up being an icon somewhere along this line with a hover over to show a tooltip saying there already exists a card in the deck configured. This would only be processed/shown when the "mining" button is clicked, so there is no impact whatsoever to normal lookups.

Just theoretically speaking the performance impact should be minimal, but I will have to test some to know concretely.

By no means is done, but seems to be mostly working with what I slapped in there. If you have any general design asks let me know.

This would only be processed/shown when the "mining" button is clicked

Do you mean it would only be shown when you click on the primary spelling that allows you to mine the word (e.g., 屋 written in orange in your screenshot)? Or do you mean it would only be shown when the "Mining mode" button/hotkey (e.g., middle mouse button/Alt+M), that enables the mining mode, is pressed?
If you mean the former, then what's the plan exactly? Currently, when you click on the primary spelling JL will try to mine it and will close the popup regardless of the success of the operation. If there was an error it will be shown as an "alert" in the upper right side of your screen and if it was a success. Do you want the popup to remain open if the card you try to create is a duplicate to show the "it's a duplicate" icon? Would an alert like "Mined duplicated card" suffice in that case?
If you mean the latter, I am afraid it does count as a normal lookup because Mouse click/Touch and Text select lookup modes do enable mining mode by default and especially Mouse click/Touch is being used by many people.

If you have any general design asks let me know

Go with a design that would have the least impact on the performance.
For example, showing an alert like "Mined {Primary Spelling} (Duplicate)" after we mine the term would be pretty trivial and it would have basically zero performance overhead. Asking "This card is a duplicate, are you really sure you want to mine it anyway?" after user clicks on the primary spelling would also have basically zero performance overhead. If any of these designs would suffice for your use-case, please prefer them over checking the duplicate-ness of every result in mining mode.
If the abovementioned approaches wouldn't be useful for your use-case and you need to see the duplicate-ness of every result in mining mode with a glance, then make create an option to enable this feature and make the default value of that option false. I'd also appricate it if you can test this feature's performance impact with lots of dictionaries.

JL allows users to mine to a text file as well but we probably shouldn't check the content of the file to detect if the result we are trying to mine is a duplicate or not. So the duplication check should only be done if Preferences -> Advanced -> Mine to file instead of Anki is disabled.

Make sure your code doesn't introduce a new warning/suggestion in Visual Studio/Rider.

I have the latter implemented currently, i did think about just changing the notification to show that it's a duplicate, but for me there is still useful information in the mining screen that would come from checking "everything" for duplicates.
Simple example, if i have an existing card for 目標 and the word is 目標的, that might influence my decision to mine 目標的 (like, i absolutely don't need a card)
I will check out what you mentioned about left click counting as mining mode when i get home, all my logic is hidden under if miningmode as of right now, but i just threw it in there without much care just for my personal use.


scala-2.13 build

Pull Request Test Coverage Report for Build 15

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 91.304%

Totals

Change from base Build 14:
-0.4%

Covered Lines:
21

Relevant Lines:
23

💛  - Coveralls


Add unlicense

https://unlicense.org/

Looks good! Would be welcome to accept a PR with the license added as my schedule is pretty choked right now 😄


Unable to Add Email Provider Information and Encountering Error Message and 405 Browser Network Error When Updating

Describe the issue:
encountering an error message along with a 405 Browser Network Error when attempting to update their email provider information
How to reproduce:

Navigate to email provider Page (Console > Branding > Notification Channels)
Attempt to update the email provider information.
Encounter an error message and observe a 405 Browser Network Error in the network tab of the browser's developer tools.

Expected behavior:
Users should be able to update their email provider information without encountering errors.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version:Alpha 7.0
OS: Mac
Database: Mysql
Userstore:JDBC
Browser: Safari

[
emailProvider.webm
](url)

This is happening for the super tenant and according to few discussions, this is the expected behaviour (UI needs to provide a readonly view). Since the SMTP configs are added through config files, this feature is allowing to override it from tenants. Need to finalize if the UX is correct.

We can improve the issue in super tenant in 2 steps.
Step 1:
Config view option. This is a mandatory requirement.
Step 2:
Config edit option. This is optional for this release.
If this not added for the release, step 1 should provide a readonly view with a notice indicating how to update them through the config files.
Considering the technical complexities, I believe we can onboard the step 1 only for this release.

Since we don't allow making changes to the super.tenant email provider in the product or haven't come across a requirement to do it in the dynamically as of now we do not need to show the email provider config in super.tenant console.
For other tenants, the option should be available over COnsole.

Well, we decided super tenant to be just another tenant. Above statement contradicts with that.
Compromising this for timelines is fine. But IMO it needs to be fixed later

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Getting started guide (alternate version)

Derived from #2
@dharmab this includes a few CSS suggestions to make the content more readable and easy to focus on, including mobile fixes. What do you think?

Discussed in Discord, @ricmzn fixed some issues in Safari 👍🏼


[Feature request] add cuRAND support

Please!

I've added partial support for cuRAND (setting seed, curandGenerate* functions).
Please check that it suits your needs (you can find some examples in test_curand.py).


Email Addresses

Email addresses in tweets aren't linked, and the link parser converts the domain to a Twitter link.
For example<EMAIL_ADDRESS>becomes<EMAIL_ADDRESS>Any way to either:

Link email addresses correctly
Not touch it at all

Thanks!

Hi Shaw -- does this fix do the trick for you? I've elected to leave (apparent) email addresses untouched rather than try to identify them and convert into "mailto:" links, though I might revisit that choice in due course.
-Steve

Yes! That got it. Thanks for the quick response.


Fixed warning

Fixed warning Animated: useNativeDriver was not specified. This is a required option and must be explicitly set to true or false

This is a good fix. I tried this and it worked.

I am getting this issue
Failed to compile
./node_modules/react-native-circular-action-menu/ActionButton.js
SyntaxError: /home/punters360/node_website_react/node_modules/react-native-circular-action-menu/ActionButton.js: Unexpected token (104:6)
102 |   renderButton() {
103 |     return (

104 |       <View
|       ^
105 |         style={this.getActionButtonStyle()}
106 |       >
107 |         <TouchableOpacity
This error occurred during the build time and cannot be dismissed.

I am just running the example code ???


3xx shouldn't count as failed visitors

In the following JSON example output I fail to understand why 304 corresponds to a failed request:
https://gist.github.com/overnine/efcdba67409fe054f6dc
It should be clear that the client did not recieve a unwanted response, but instead already had the correct response in cache?
Would you consider changing this sometime or alternatively enlighten me as to what I'm missing?

Could you please post the original JSON output? or if you have the 8 requests from your access log, that would work too. Thanks.

This is the original, simply with some names replaces as i would like those to be confidential ;)The u's are just unicode labels from python!
You can try these logs, those should be able to recreate the behaivour: https://gist.github.com/overnine/50cfc2c398511c063d4d

From your sample log, I get only 1 failed request which is the blank line. https://gist.github.com/allinurl/c21e38db39eaeb1c0839
Do you get the same output?

Hmm, okay wow, I guess i wasn't expecting goaccess to handle those as failed requests, you're right that this is the cause. I guess you consider that an error from my programming then?

It seems like the number of failed requests are not being mapped correctly during the post-processing that you are doing to the JSON file. Feel free to compare the original JSON report to yours to identify the issue.

Closing this since it doesn't seem to be an error on the JSON report. Feel free to reopen it if needed.


completion type infer: second variable not getting assigned in for, etc

golang/complete.go:263
		for _, sy := range *scopes {
			fmt.Printf("scope: %v  reg: %v  pos: %v\n", sy.Name, sy.Region, pos)
			return sy.Kind
		}

2nd or later vars in multiple assignment are not getting registered by parser:
pi/golang/complete.go: start, last := gl.CompleteAstStart(lfs.ParseState.Ast) -- shouldn't be too hard to fix parser -- not sure why not working.

first it was DePtrExpr for *scopes, then it was that we need to get container element type for scopes..


OK upper chamber committees

Note: all committee members' names in the format "LastName, FirstName". That was also the case for all of the OK lower chamber that was merged last month, and is the same for upper chamber comms now as well.
We will fix the scraper either way (since there are also other issues with getting legislature chamber comms, etc.) but we should decide whether we want that fix before or after merging upper chamber comms.

Closing this because a new PR was opened for OK committee data import.


Improve signaling to users around message edit being disabled after 10m

I think we need to add a clear notice in the message edit content indicating why message editing is disabled in the event that the timer has run out.
While we're at this, it probably makes sense to add a "Show original" option for messages that you didn't write in place of the "Edit" option.  This is a somewhat commonly requested feature as well.

(For context, we've been getting a nontrivial number of reports from folks who are confused as to why they can't edit their messages due to this feature)

@brockwhittaker the "Show original" feature seems like a nice, high-visibility, quality-of-life thing along the lines of what you've been doing recently.  I think basically we want to show that button exactly when "Edit" is not an available option on a message.
We'll need to patch json_fetch_raw_message to allow users other than the sender to fetch the raw content; the logic I think we want is in https://github.com/timabbott/zulip/tree/fetch-raw-messages (it needs tests before we can merge, since this is security code, but it should be enough for you to develop this feature on top of).

It looks like the "show original" feature is being discussed in #1604 (and @namratab94 is interested in working on it, so feel free to hold off on working on this @brockwhittaker ).

I merged the backend support in fetch_raw_messages, so we now only need to do frontend changes to finish this.

Is someone working on the front-end changes for this issue?

If not, how could I contribute? Any guidance will be helpful.

@Katy310 Go ahead! I am not able to work on it.

Any pointers on how to get started?

Hi @Katy310! I actually just started working on this this morning. We do have another issue related to the message edit box that I'll post in a sec, in case that is of interest :).

Oh alright, that would be great!

Never mind, the issue turned out to be intended behavior :). If you're looking to help with Zulip,
a) awesome, and welcome!
b) we'd love to help find a good issue over at our developers' server at zulip.tabbott.net; just say hi on the "general" stream!

I had originally planned to apply for the current round of Outreachy, but later decided to apply in the next round, after strengthening my association with Zulip.

@Katy310 Same here! Been reading the code from weeks now.

This feature has been added and merged via #2100. Thanks @rishig!


Renewal, Change Address and Cancel buttons + magazine descriptions on Magazine pages

PRODUCTION:

DEVELOPMENT:

 Reskin: Magazine page update


Rails.logger.info shows no timestamp

My lograge configuration look as below
    config.lograge.enabled = true
    config.lograge.base_controller_class = ['ActionController::Base']
    config.lograge.formatter = Lograge::Formatters::Logstash.new

But whenever i use Rails.logger.info("this is my log string"), in log files it comes like this
this is my log string
{"method":"GET","path":"/some-api","format":"json","controller":"controller-some","action":"ping","status":200,"duration":3.72,"view":0.41,"db":0.0,"transaction.id":null,"span.id":null,"trace.id":null,"params":{},"exception":null,"exception_object":null,"remote_ip":"<IP_ADDRESS>","@timestamp":"2019-11-26T09:53:12.184Z","@version":"1","message":"[200] GET /some-api"}

I want to append timestamp before all Rails.logger. entries.

Any update on this?


Move plugin to ANTLR organization

This is a useful plugin and I think it should be moved to ANTLR organization for the community support. @parrt what do you think about it?

I'd like to avoid adding things to the main repository if possible.

I think the suggestion was to move it to the github.com/antlr/ project, as a peer of the main repo.  So, for example, it would be moved from:
https://github.com/teverett/antlr4test-maven-plugin
to
https://github.com/antlr/antlr4test-maven-plugin

oh, sorry. I read that too fast and didn't see the organization part. I'm okay with that. @teverett  do you want me to create the repo and pull from your remote then sever the link?

Perfect.  :)
On Mon, May 15, 2017 at 11:40 AM, Terence Parr<EMAIL_ADDRESS>wrote:

oh, sorry. I read that too fast and didn't see the organization part. I'm
okay with that. @teverett https://github.com/teverett do you want me to
create the repo and pull from your remote then sever the link?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/teverett/antlr4test-maven-plugin/issues/7#issuecomment-301548432,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK1Zi2PnJnWdGy0lUvQqZBQvatThWnzks5r6I4SgaJpZM4Na5J1
.

--
A better world shall emerge based on faith and understanding  - Douglas
MacArthur

@parrt it can be completed by @teverett:
Settings -> Danger Zone -> Transfer ownership -> Select ANTLR organization.

hmmmmmm.  what can go wrong.....
:)
On Mon, May 15, 2017 at 11:43 AM, Ivan Kochurkin<EMAIL_ADDRESS>wrote:

@parrt https://github.com/parrt it can be completed by @teverett
https://github.com/teverett:
Settings -> Danger Zone -> Transfer ownership -> Select ANTLR organization.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/teverett/antlr4test-maven-plugin/issues/7#issuecomment-301549169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK1Zqua8W7Zmy8-2KwOBng9wlZ9NuViks5r6I7DgaJpZM4Na5J1
.

--
A better world shall emerge based on faith and understanding  - Douglas
MacArthur

On Mon, May 15, 2017 at 11:43 AM, Ivan Kochurkin<EMAIL_ADDRESS>wrote:

@parrt https://github.com/parrt it can be completed by @teverett
https://github.com/teverett:
Settings -> Danger Zone -> Transfer ownership -> Select ANTLR organization.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/teverett/antlr4test-maven-plugin/issues/7#issuecomment-301549169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK1Zqua8W7Zmy8-2KwOBng9wlZ9NuViks5r6I7DgaJpZM4Na5J1
.

--
A better world shall emerge based on faith and understanding  - Douglas
MacArthur

Did you do it in settings of your repository antlr4test-maven-plugin?

He doesn't have right privileges...i'll just create the repo and pull it in

Done https://github.com/antlr/antlr4test-maven-plugin

ok so at this time, do i delete my version of the repo, and branch the
antlr one when there are changes to make?
On Mon, May 15, 2017 at 12:02 PM, Terence Parr<EMAIL_ADDRESS>wrote:

Done https://github.com/antlr/antlr4test-maven-plugin
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/teverett/antlr4test-maven-plugin/issues/7#issuecomment-301555525,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK1Zi-EzSd0POpPykcyY3_2gnPx381-ks5r6JNKgaJpZM4Na5J1
.

--
A better world shall emerge based on faith and understanding  - Douglas
MacArthur

I guess you can delete it, but do we know how this new repo will get pulled in by the grammars repository?

It won't.  Currently I deploy PROD builds of the plugin to the maven repo.
The plugin will have to be updated with new maven coordinates and someone
who has permissions on the com.antlr maven repo will have to deploy it.
On Mon, May 15, 2017 at 12:07 PM, Terence Parr<EMAIL_ADDRESS>wrote:

I guess you can delete it, but do we know how this new repo will get
pulled in by the grammars repository?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/teverett/antlr4test-maven-plugin/issues/7#issuecomment-301556880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK1Zs1iwEj9jLWi3OhQuBShoel5WtSfks5r6JR4gaJpZM4Na5J1
.

--
A better world shall emerge based on faith and understanding  - Douglas
MacArthur

ok, I will deploy when needed.   Just give a shout when it is time.

cool.
On Mon, May 15, 2017 at 1:02 PM, Terence Parr<EMAIL_ADDRESS>wrote:

ok, I will deploy when needed. Just give a shout when it is time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/teverett/antlr4test-maven-plugin/issues/7#issuecomment-301572052,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK1ZjQIyzz59rcokD-hLlXCdu4zJKkZks5r6KE6gaJpZM4Na5J1
.

--
A better world shall emerge based on faith and understanding  - Douglas
MacArthur


Config: simplify JSON validation and make it typecheck

Use types-jsonschema and update the code to validate.
In the process refactor the validation method to avoid nesting logic and make it more clear

bors merge

bors merge


[F 6.1.2] Bug calculation property width with ie

On IE the width are bad , Why ???

The Foundation forum would be a great place to seek some help with troubleshooting what might be going on here. If it turns out to be a defect, you'll have some more info to provide here which will help prioritize and get it fixed.
We're trying to keep the issue list focused on confirmed defects in Foundation, so any help everyone can provide to differentiate between usage / troubleshooting and actual defects is appreciated!


download error

Explain the problem here ...

curl does not connect to the server Error: curl: (7) Failed to connect to raw.githubusercontent.com port 443: Connection timed out

Type:

[ y] Bug
[x] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[y] Linux
[ ] OS X
[ ] Windows

Vim:

[y] Terminal Vim
[ ] GVim
[ ] Neovim

https://github.blog/2018-02-01-crypto-removal-notice/#known-incompatible-clients
Upgrade your environment to use TLS 1.2+

No, this isn't necessarily caused by TLS issues. As known elsewhere, the poster is lived in mainland China. And recently raw.githubusercontent.com is blocked by China (DNS pollution), causing timeouts or certificate mismatch or connection refused (or anything else when connecting to a wrong IP, e.g. <IP_ADDRESS>). This might be the cause.

https://github.blog/2018-02-01-crypto-removal-notice/#known-incompatible-clients
Upgrade your environment to use TLS 1.2+

How to update to 1.2 +, and how to view the current version


ubuntu 20.04 requires non root user to be render group to use GPU acceleration

Hi,
I want to use non-root user to use GPU plugin. And found /dev/dri is in render group. I found following links. So i added follow in dockerfile. On my fresh install ubuntu 20.04 desktop, render group id is 109.
RUN groupadd -g 109 render &&
useradd -ms /bin/bash -G video,render,users openvino &&
chown openvino -R /home/openvino
https://jellyfin.org/docs/general/administration/hardware-acceleration.html
...
VAAPI may require the render group added to the docker permissions.
...
https://docs.unified-streaming.com/documentation/capture/media-sdk.html
...
Each non-root user which is supposed to be doing hardware transcoding must be made a member of the video and render groups.
...
Could you check to add openvino user to render group for non-root user to use GPU plugin?
Thanks and Regards,
Chungyeh

Hi, @chungyehwangai  We know about this limitation, render group doesn't have a strong groupID like video, and we can't setup it during Docker build, but we will post instructions on how to fix it in the Dockerfile or Docker container in the next few days.

Thanks for the information. Looking forward to documentation update.

Please read the instruction on how to configure a container in that case: https://github.com/openvinotoolkit/docker_ci/blob/master/configure_gpu_ubuntu20.md


"mouse_entered" and "mouse_exited" signals are broken while holding down a mouse button

Godot version:
fbb5ca4
OS/device including version:
Linux Manjaro
Issue description:
The "mouse_entered" and "mouse_exited" signals of control nodes don't get fired while holding any mouse button down when the click (any mouse button down) started on a control that does not ignore the mouse.
it's actually because in viewport.cpp in line 1843 to 1850 "over" get's set to the mouse_focus
if (gui.mouse_focus) {
	over = gui.mouse_focus;
	//recompute focus_inv_xform again here
} else {
	over = _gui_find_control(mpos);
}

and shortly after (  line 1884 to 1893 ) the mouse_exited and mouse_entered signals get not fired because the gui.mouse_focus and the gui.mouse_over are the same
if (over != gui.mouse_over) {

	if (gui.mouse_over)
		gui.mouse_over->notification(Control::NOTIFICATION_MOUSE_EXIT);

	_gui_cancel_tooltip();

	if (over)
		over->notification(Control::NOTIFICATION_MOUSE_ENTER);
}

This may be a desired behavior, for a lot of cases.
But there are also cases where it is very useful to send those signals. (I'll update this post soon to show such a case)
Steps to reproduce:

Connect the "mouse_entered" or "mouse_exited" signal of any control node
add another control node, that does not ignore the mouse
start your drag on the control element of point 2 and drag over the control element from point 1
notice that no "mouse_entered" and no "mouse_exited" signals get fired

Confirmed on my master build too. Note: if you set mouse filter to "ignore" on the parent control the color rectangle signals works as expected.

linked to #23296

Note from #32727, this does also happen for is_hovered()

Still an issue in Godot 3.2.2beta ed27b7e6b973eb6be6fdac4439e99a1907b9cb58

Still in 3.2.4RC2.
Try to click on bottom element. With out relesing it move cursor away from element!
New Game Project.zip

managed to get around this by making my own _input(event:InputEventMouseButton) function.
I then had to make sure these two lines were executed as part of the code:
event.set_pressed(false)
set("mouse_filter", Control.MOUSE_FILTER_STOP)

This only worked with an _input() function, not a _gui_input() function

удалось обойти это, создав мою собственную функцию _input (event: InputEventMouseButton).
Затем мне нужно было убедиться, что эти две строки выполняются как часть кода при нажатии мыши:
event.set_pressed(false)
set("mouse_filter", Control.MOUSE_FILTER_STOP)

Затем я сбрасываю mouse_filter на ..._ PASS при отпускании мыши.
Это работало только с функцией _input (), а не с функцией _gui_input ()

Could you show full code pls?

Ok, take a look an attachment, it's works well :)
Mouse pressed signals bug.zip

FIX :)
Mouse pressed signals bug.zip

Can not get this to work. The line get_global_rect().has_point(get_global_mouse_position()) does not take into account either scale or rotation of the node :(

get_global_rect().has_point(get_local_mouse_position())

You literally just reposted the code line I mentioned... As I said, it doesn't work.

@Banderi Local mouse position, rotating, scaling
Mouse pressed signals bug.zip

Wasted hours thinking it was my code :-( v3.3.1
Appreciate the work around but hoping this gets a fix/resolution

This is probably related to a common UI behavior called "mouse capture". The idea is to make it easier to implement dragging logic, by making the widget receive mous events and appear pressed as long as the mouse was pressed inside and remains pressed even if it exits the area of the control.
For example, take a scrollbar. Press it, keep the mouse held, and move away from it. It will remain pressed, and will still respond to your movements, while every other control will ignore the mouse. You can reproduce this behavior on non-Godot UIs as well, even on controls that are not usually draggable (see how buttons remain pressed when you do this too). Things can differ a bit though, sometimes hover effects don't follow this, while pressed effects do.
About mouse_entered and mouse_exited: if these were changed to always fire when the mouse goes out of the control's area, regardless of what's actually happening, then likely a bunch of existing code might need to be fixed somehow, without being able to rely on them. Or maybe controls can have an option to turn off mouse capture.

This is probably related to a common UI behavior, which I saw called "mouse capture" on Windows. The idea is to make it easier to implement exclusive dragging logic, by making the control receive mouse events and appear pressed as long as the mouse was pressed inside and remains pressed even if it exits the area of the control. I would not be surprised if this wasnt documented because it's a subtle behavior happening with many widgets, and has no associated option.
For example, take a scrollbar. Press it, keep the mouse held, and move away from it. It will remain pressed, and will still respond to your movements, while every other control will ignore the mouse. You can reproduce this behavior on non-Godot UIs as well, even sometimes on controls that are not usually draggable (see how some buttons remain pressed when you do this too). Things can differ a bit though, because there are many UI systems around. Sometimes hover effects don't follow this, while pressed effects do. Godot happens to do both, including enter/exit.
About mouse_entered and mouse_exited: arguably, many widgets probably don't need mouse capture. But if these were changed to always fire when the mouse goes in and out of the control's area, regardless of what's actually happening, then likely a bunch of existing code might need to be fixed somehow, without being able to rely on them. Or maybe controls can have an option to turn off mouse capture.

Thanks for that, makes sense.  If this is the case then I would def upvote an option to switch it off for certain scenarios.

Out of curiosity, does this behavior happen with CollisionObject2D/3D's mouse_enter/mouse_exit signals too?

This is also a huge problem for gui_input(event) signals from any Control based node.
For example when trying to trigger an animation when the left-mouse is released over the Control:
func _on_Control_gui_input(event):
	if event.is_action_released("LMB"):
		$AnimationPlayer.play("New Anim")

This should trigger the animation only when the left mouse is released over the Control, but if clicked onto the Control then dragged the mouse away from the control (while still being pressed) the animation will play, regardless of where the mouse is  released.
This seems to be connected to the mouse_enter and mouse_exit signal, as can be easily tested with this:
var mouse_hover = false

func _on_Control_gui_input(event):
	if event.is_action_released("LMB") and mouse_hover:
		$AnimationPlayer.play("New Anim")
		print("gui ",mouse_hover)

func _on_Control_mouse_entered():
	mouse_hover = true
	print("mouse_hover = true")

func _on_Control_mouse_exited():
	mouse_hover = false
	print("mouse_hover = false")

Both "gui True" and "mouse_hover = false" will print only after mouse release.

This is also a huge problem for gui_input(event) signals from any Control based nodes.
For example when trying to trigger an animation when the left-mouse is released over the Control:
func _on_Control_gui_input(event):
	if event.is_action_released("LMB"):
		$AnimationPlayer.play("New Anim")

This should trigger the animation only when the left mouse is released over the Control, but if clicked onto the Control then dragged the mouse away from the control (while still being pressed) the animation will play, regardless of where the mouse is released.
This seems to be connected to the mouse_enter and mouse_exit signal, as can be easily tested with this:
var mouse_hover = false

func _on_Control_gui_input(event):
	if event.is_action_released("LMB") and mouse_hover:
		$AnimationPlayer.play("New Anim")
		print("gui ",mouse_hover)

func _on_Control_mouse_entered():
	mouse_hover = true
	print("mouse_hover = true")

func _on_Control_mouse_exited():
	mouse_hover = false
	print("mouse_hover = false")

Both "gui True" and "mouse_hover = false" will print only after mouse release.

https://github.com/godotengine/godot/issues/20881#issuecomment-841614529

@MadDogMayCry0
I can't get your workaround to work with my gui_input(event) example. I suppose it would be possible if I copy it line by line, use _input(event) instead of gui_input(event) and separate scripts like you did, but this is way too complicated for what I want to do.

@MadDogMayCry0 I can't get your workaround to work with my gui_input(event) example. I suppose it would be possible if I copy it line by line, use _input(event) instead of gui_input(event) and separate scripts like you did, but this is way too complicated for what I want to do.

@MadDogMayCry0 even though it works, what you do with if event.is_pressed(): event.pressed = false is to by pass the code that starts here : https://github.com/godotengine/godot/blob/3.x/scene/main/viewport.cpp#L1861 and thus break dragging modal windows and some yet unclear to me gui focus related code.

Natürlich müssen Sie meine Logik an das anpassen, was Sie mit Ihnen vorhaben. Meine Logik erklärt und demonstriert nur, wie dieses Problem umgangen wird.

see my 2 pull requests #54565 and #54552 and also #67791 from @Sauermann

Can confirm this problem in 3.5.2 Stable

Can't reproduce in 4.1.
Can someone confirm?

Tested in v4.2.dev.custom_build [c3b0a92c3].
I can't reproduce the problem in the simple case, that starting Control and hovering Control are in the same Viewport. That seems to be fixed.
However, when starting Control and hovering Control are in different Viewports (SubViewport or Window), then I can reproduce the problem in many cases.
MRP for this is available in: https://github.com/godotengine/godot/pull/67791#issue-1419768978

Closing then. The more complex case is a separate issue.

I didn't test it, but It is likely that this got fixed by #59555.

Experiencing this on Godot 3.5.2
I am using using this to feature for drag & dropping items in my inventory system.
Move move over item slot -> Triggers MOUSE ENTERED (Good)
Hold down LMB -> Triggers DOWN (Good)
Move mouse outside item slot -> Triggers Nothing (Bad) Expected: MOUSE EXITED
Let go of LMB -> Triggers UP, and MOUSE EXITED (Half correct)
        public void _on_Button_button_down()
        {
            GD.Print("DOWN");
        }

        public void _on_Button_button_up()
        {
            GD.Print("UP");
        }

        public void _on_Button_mouse_entered()
        {
            GD.Print("MOUSE ENTERED");
        }

        public void _on_Button_mouse_exited()
        {
            GD.Print("MOUSE EXITED");
        }

The issue is only fixed in Godot 4.1.

Does anyone know if it will be fixed in 3.5.x ?

Just hit this issue. Doesn't look fixed in 3.5.3 stable. Bummer.

Can confirm this bug is still not fixed in 3.5.3 stable.


(docs) added devguide template syntax

This includes "acceptable" stub pages for docs that are referenced by Template Syntax and the Glossary. These stub pages will be made real by AC.
This seems also to include the commit for the Glossary which I submitted as PR #280. I guess that wasn't accepted. It will be by incorporation of this PR.  I'd like that to land because there are a backlog of fixes to it, mostly from Pascal


refactor: rename "bulk" to more accurate "dynamically created"

refactor: deleteBulkResource -> deleteTargetResource
refactor: remove unneeded key parameter
refactor: remove unneeded key parameter
refactor: rename bulk to dynamically created to be more accurate
refactor: remove now unneeded class
refactor: more renaming

@metacosm  I don't agree that dynamic is more accurate, actually misleading, synce every resource is is dynamically created by an operator nothing is  "static". Bulk better describes that we are creating here a set of similar resources.

@metacosm I don't agree that dynamic is more accurate, actually misleading, synce every resource is is dynamically created by an operator nothing is "static". Bulk better describes that we are creating here a set of similar resources.

That's not necessarily true anymore, though. It could be anything depending on what the primary spec says. Bulk was only appropriate when things were restricted to index-based similar resources but that's not the case anymore.

@metacosm I don't agree that dynamic is more accurate, actually misleading, synce every resource is is dynamically created by an operator nothing is "static". Bulk better describes that we are creating here a set of similar resources.

That's not necessarily true anymore, though. It could be anything depending on what the primary spec says. Bulk was only appropriate when things were restricted to index-based similar resources but that's not the case anymore.

Don't understand what do you mean, we still have BulkDependentResource interface, to describe that we are managing those resource is bulk.

We agreed to keep the bulk name because we couldn't find a better one and "dynamically created" is confusing. Replaced by #1544.


Consider using standard Go project structure

It appears there is now a standard that Go projects follow: https://github.com/golang-standards/project-layout
Perhaps it would be a good idea to move to it.

pr's always welcome :smile:


Can't open Web View of novel that requires Cloudflare verification

Steps to reproduce

Open novel from NovelUpdates that requires a Cloudflare verification (in my case, I was caught up in a Hero summoning but that world is at peace WN)
Go to chapter that translated by Foxaholic
Open chapter and get Cloudflare error
Try to open up buttom bar

Expected behavior
Bottom bar should open to allow you to open the webview
Actual behavior
No matter where you tap, you cannot get any of the LNReader UI to show
LNReader version
1.1.18
Android version
Android 13
Device
ZFold 4 (Happens on both layouts)
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 1.1.18.
[X] I will fill out all of the requested information in this form.

No matter where you tap, you cannot get any of the LNReader UI to show

This is the expected behaviour as the bottom bar isn't present in the error state.

Then should it might not want to say to open it in Webview then unless it is a generic error message since even if you open the chapter in Webview from the novel's Webview, the error doesn't go away

Then should it might not want to say to open it in Webview then unless it is a generic error message

Ideally there should be a way to open WebView from that state so added the Feature Request label.

even if you open the chapter in Webview from the novel's Webview, the error doesn't go away

It's probably a NovelUpdates issue, try using the Foxaholic source instead.


Show statistics about grid

Menu option to see:

Validity
Word count
Words by length

Currently this information is only seen when the grid is saved.

Fixed with commit 6c9df44


Use the official Ubuntu vagrant image

...to cut down on disk space usage (if people already have this image
downloaded), and use the "official" image.
I believe this is what the Vagrantfile was already doing, and doing correctly;
with the introduction of "vagrantcloud" the semantics just changed a bit.

@RsrchBoy, have you had a chance to test your updates?

@RsrchBoy This pull request has been open for a long time now. Can you please confirm if you have tested your updates ?

I'm closing as this PR has been dead for too long. Just reopen if you update.


Update tools and benchmark datasets to read compressed json

What does this PR do?
This PR

updates the [logs|traces|metrics] datasets to read files that are in a compressed json format. Files are read line by line. This logic is similar to how the otel contrib filereceiver component will read compressed json.
updates the [logs|traces|metrics] test data generating tools to write compressed json format. Telemetry is written one at a time followed by a newline. This logic is similar to how the otel contrib fileexporter will write compressed json.

@moh-osman3 there is an issue in the build process preventing us to merge this PR. Could you fix it and I will merge this PR. Thanks.

@lquerel Ahh forgot to update one of the test files with the updated function signature. I think it should be fixed now. Thank you!

@moh-osman3 thanks for this PR.


🔌 Plugin: LeanIX - Application Portfolio Management

Summary
LeanIX is a SaaS-based architecture tool that allows you to model your organizations landscape (people, process, technology) as fact-sheets (ie: applications, it components, business capabilities, user groups etc).
Each fact-sheet type has a series of metadata attributes you can capture, such as lifecycle milestones (phase in, phase out, retire), successors, predecessors and relationship between fact-sheets (ie: which applications depend on which it components)
The platform has a really rich set of APIs available (GraphQL or REST) to interface with.

Project website (if applicable)

https://www.leanix.net/en/
https://docs.leanix.net/docs/api-guide

Context
It would be really powerful to be able to link a backstage component to its corresponding LeanIX fact-sheet, so that different viewpoints (especially any relationships to other fact sheet types, or lifecycle statuses) could be displayed within  Backstage automatically

this would be handy to have

Any plan for implementation in recent releases ?

would still be nice to have

This would be valuable to my organization as well.


Module object has no attribute 'find_bulbs'

When I am in python and try to run the script bulbs=lazylights.find_bulbs(expected_bulb=2), I go module object has no attribute 'find_bulbs".  Do I miss something during installation?

I'm having the same problem. This happens when I'm trying to call lazylights from lifxscreen2.py. I would love to get this working. Any clues?

You are using the 1.0 branch of lazylights. You need to use version 2.0
Uninstall/delete what you have and use this instead:
pip install<EMAIL_ADDRESS>

thanks a lot frak. this solved the problem.


fix: typos in documentation files

This pull request contains changes to improve clarity, correctness and structure.
Description correction:
Corrected cfi_def_cfa_regiser to cfi_def_cfa_register
Please review the changes and let me know if any additional changes are needed.

Hi, @dot-asm! I’ve just submitted a pull request. Could you please review it when you have a chance? I’d appreciate your feedback and any comments. Thank you!


[Migration Tools] Copy Neo SDK to Registry

Copy the content of the resources-neo-sdk module into the Registry, so that the neo.sh and all relevant scripts are accessible as executable files instead of being packaged into a JAR file only (xsk-resources-neo-sdk-0.8.0-SNAPSHOT.jar).
In the end it should be possible to execute the neo.sh by the following script:
var response = require("http/v4/response");
var config = require("core/v4/configurations");
var exec = require("core/v4/exec");

let neoSdkPath = config.get("user.dir") + "/target/dirigible/repository/root/registry/public/resources-neo-sdk/neo-sdk/tools/neo.sh";

let result = exec.exec(neoSdkPath, null, null);

response.println("Neo SDK Result: " + result);
response.flush();
response.close();

Proposal: This logic should be executed once at XSK startup, reference implementation for such functionality could be found here:

IDECoreSynchronizer.java
IDECoreSynchronizerJob.java
IDECoreSynchronizerJobDefinitionProvider.java
org.eclipse.dirigible.core.scheduler.api.IJobDefinitionProvider

Related to: https://github.com/SAP/xsk/issues/440


Allow existing styles to work with tailwind reset

I believe this is a remnant of our Tina + Tailwind project and was addressed throughout that:
https://github.com/tinacms/tinacms/issues/2267
https://github.com/tinacms/tinacms/issues/2353


Bug Report: Editor crash after reload current world

Describe the bug | Bug描述
Very clear, run editor, get into game mode, switch back to editro mode, then reload current world, the editor will crash immediately
Steps to reproduce | 如何复现
Steps to reproduce the behavior:

Open piccolo editor
Click 'Menu->Reload Current Level'
Crash

Expected behavior | 预期行为
The level should reloaded as written in the json file
Actual behavior | 实际行为
Editor crash
Screenshots/Logs | 截图/日志
In debug mod, console:
[info] [Piccolo::WorldManager::reloadCurrentLevel] reload current evel succeed
Exception: Exception 0xc0000005 encountered at address 0x7ff75e59153b: Access violation reading location 0x00000000

Call stack info:

It seems caused by clean up particle resource

Guess from the result of search everywhere, the rhi buffer object 'm_particle_storage_buffer' seems never  allocated, buf access when delete buffer

Desktop | 桌面环境
CPU: Intel Core i7 12700H
Memory: 32G
Graphics Card: Nvidia Gefore RTX 3060 Laptop, Driver: 517.00
System: Windows 11
Additional context | 补充信息
Nothing

duplicate with #378


Introduce Retry to CI

In what area(s)?
/area test-and-release
Describe the proposal
Now we have some tests may fail due to network issue or other we do not know, they can pass after some retry. Sadly, Github Action does not support retry a single test officially, contributors need to re-commit to trigger it, which means rerun all not only failed.
Add Retry can make CI smarter, only rerun failed tests, and make truly flaky tests more quickly found.

Add Retry can make CI smarter, only rerun failed tests, and make truly flaky tests more quickly found.

👎
Flaky tests must be fixed, not "patched" with retries.

It is a way to find them :)

I'm confused — the precondition for retrying is failure, right? Isn't that visible even without a retry?

Retry make PRs quicker merged, reduces duplicate tests run, and we can fix the flakiest things first.
To be honest, I also do not want any flaky tests to exist, but for now, with Retry do benefit.
/cc @artursouza @yaron2

Retry make PRs quicker merged, reduces duplicate tests run, and we can fix the flakiest things first

😕 What? How? You explicitly don't want to merge PRs that exhibit flaky tests.

Yeah, I'm very against automatic test retries. Much awfulness can be hidden that way.

I agree with @peterbourgon and @wcs1only here. We retry (manually) as a shortcut for known flaky tests. The fact that we manually retry those also serves as a way to catch which ones are flaky - if we retry, we will be hiding those under the rug.


Problem builing wfreerdp with CHANNEL_URBDRC_CLIENT on Windows 10

Discussed in https://github.com/FreeRDP/FreeRDP/discussions/7918

Originally posted by johnosbb May 24, 2022
Hi,
I am trying to build the latest FreeRDP code on windows 10.
If I enable CHANNEL_URBDRC_CLIENT I get the following error
C:\Users\BBOX\SDKVM\FreeRDP\FreeRDP\channels\urbdrc\client\libusb\libusb_udevman.c(961): error C2440: 'function': cannot convert from 'DWORD (__cdecl *)(LPVOID)' to 'LPTHREAD_START_ROUTINE'
C:\Users\BBOX\SDKVM\FreeRDP\FreeRDP\channels\urbdrc\client\libusb\libusb_udevice.c(1247): error C2440: 'function': cannot convert from 'void (__cdecl *)(libusb_transfer *)' to 'libusb_transfer_cb_fn'
C:\Users\BBOX\SDKVM\FreeRDP\FreeRDP\channels\urbdrc\client\libusb\libusb_udevice.c(1348): error C2440: 'function': cannot convert from 'void (__cdecl *)(libusb_transfer *)' to 'libusb_transfer_cb_fn'
C:\Users\BBOX\SDKVM\FreeRDP\FreeRDP\channels\urbdrc\client\libusb\libusb_udevice.c(1355): error C2440: 'function': cannot convert from 'void (__cdecl *)(libusb_transfer *)' to 'libusb_transfer_cb_fn'
I tried different versions of libusb as outlined  here, but the error persists.
I saw one previous discussion where someone was advised to disable libusb in order to build.
Any suggestions or insights.

@johnosbb thank you for pointing this out, fixed with latest master and stable-2.0 branches


feat: log error message when no resources in deploy preview

I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components

[x] CLI
[ ] Create CLI
[ ] Test
[ ] Docs
[ ] Examples
[ ] Other

Notes for the Reviewer

Currently npx checkly deploy --preview has no output at all when no checks or other resources are detected. This output could be a bit misleading for new users.
This PR adds some output for this case:
$ npx checkly deploy --preview

No checks were detected. More information on how to set up a Checkly CLI project is available at https://checklyhq.com/docs/cli/.

This issue could happen for a number of reasons, so I'm not sure if it makes sense to give any other info in the output for now.

@clample we need to add more of these messages on different spots.

no checks configured in otherwise correct setup
no config at all, but user runs npx checkly test (when installed globally) in a project.

See also https://checklyhq.slack.com/archives/C04PFSV5W3B/p1677003160430209

@tnolet having a messages.ts makes sense, good idea 👍

I think that it could still be nice to merge this one in the meantime

@clample yes please


Identify Math Theorems Update

This PR has two contributions:

It updates the citation info for the task.
It credits Austin Herrick as a third contributor to the task. While Austin did not commit any code to the repo, he did review and edit the theorems as mentioned in #367.

Thanks for making these changes! Merging.


[Face API] SslStream.CheckDisposed () in Xamarin forms >> Android

Describe the bug

System.Threading.Tasks.TaskCanceledException: Cannot access a disposed object. Object name: 'SslStream'.
We get this issue while uploading image DetectWithStreamAsync method

Actual behavior (include Exception or Stack Trace)
System.Net.Http
HttpConnection.SendAsyncCore (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken)
System.Net.Http
HttpConnectionPool.SendWithNtConnectionAuthAsync (System.Net.Http.HttpConnection connection, System.Net.Http.HttpRequestMessage request, System.Boolean doRequestAuth, System.Threading.CancellationToken cancellationToken)
System.Net.Http
HttpConnectionPool.SendWithRetryAsync (System.Net.Http.HttpRequestMessage request, System.Boolean doRequestAuth, System.Threading.CancellationToken cancellationToken)
System.Net.Http
RedirectHandler.SendAsync (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken)
Microsoft.Rest
RetryAfterDelegatingHandler.SendAsync (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken)
Microsoft.Rest
RetryDelegatingHandler+<>c__DisplayClass15_0.b__0 ()
Microsoft.Rest
RetryDelegatingHandler.SendAsync (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken)
System.Net.Http
HttpClient.FinishSendAsyncBuffered (System.Threading.Tasks.Task1[TResult] sendTask, System.Net.Http.HttpRequestMessage request, System.Threading.CancellationTokenSource cts, System.Boolean disposeCts) Microsoft.Azure.CognitiveServices.Vision.Face FaceOperations.DetectWithStreamWithHttpMessagesAsync (System.IO.Stream image, System.Nullable1[T] returnFaceId, System.Nullable1[T] returnFaceLandmarks, System.Collections.Generic.IList1[T] returnFaceAttributes, System.String recognitionModel, System.Nullable1[T] returnRecognitionModel, System.String detectionModel, System.Collections.Generic.Dictionary2[TKey,TValue] customHeaders, System.Threading.CancellationToken cancellationToken)
Microsoft.Azure.CognitiveServices.Vision.Face
FaceOperationsExtensions.DetectWithStreamAsync (Microsoft.Azure.CognitiveServices.Vision.Face.IFaceOperations operations, System.IO.Stream image, System.Nullable1[T] returnFaceId, System.Nullable1[T] returnFaceLandmarks, System.Collections.Generic.IList1[T] returnFaceAttributes, System.String recognitionModel, System.Nullable1[T] returnRecognitionModel, System.String detectionModel, System.Threading.CancellationToken cancellationToken)
How to reproduce

upload the image stream with less timeout

Hi @glintpursuit, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

test


Val Accuracy prediction with D-VAE

Hey @crwhite14
how do you predict val accuracies with D-VAE? Do you use a similar setting as in the experiment in section 4.2 of the D-VAE paper (i.e. using a sparse GP)?

Hi Simon,
Thanks for the interest. We used the code straight from the D-VAE repo. Specifically we set the "predictor" flag here to true. If I remember correctly, I needed to adapt the code from the ENAS search space to the NASBench-101 search space. Currently the VAE code is here https://github.com/naszilla/naszilla/tree/vae/naszilla/vae, and I’m planning to run some tests on it. If the performance improves, I will update the paper accordingly.
Best,

Colin

why get_cell is return NONE


Dashboard should not display error when have no data

In GitLab by @luotian-github on Jun 21, 2018, 17:58

In GitLab by @luotian-github on Nov 8, 2019, 07:53
please help to reproduce it. Thanks.

In GitLab by @yhua123 on Nov 8, 2019, 07:53
can't reproduce, please close it.

In GitLab by @sokril on Nov 8, 2019, 08:23
closed

In GitLab by @sokril on Nov 8, 2019, 08:23
assigned to @Robin-Mao


opam release with optional caml4p

Would it be possible to do another opam release? We're using this library to do conversion between CP1252 and UTF-8, but the caml4p dependency is causing problems for us on OCaml 4.09 and 4.10. It looks like that was made optional in https://github.com/vbmithr/ocaml-text/commit/abf9b3d5e9192147a796ed1f2c0a4d313c75682c but it's not available in opam.

This is really ancient code, if you could try the [uu*] packages for unicode at https://erratique.ch/software, it would be much better as those will be supported.

But sure for a quick release without camlp4 I can do that.

Unfortunately Uutf doesn't support CP1252 :( At some point we might try contributing more codecs to that library or making a basic UTF-8 <-> CP1252 converter but Text really is basically what we want.

Thanks! https://opam.ocaml.org/packages/text/text.0.8.1/


test: more precise way to assert resolved path to plugin

Sorry, I just suddenly remembered that I put hardcoded project folder name to tests. This test case will fail if somebody will clone repo to folder with different name
https://github.com/so1ve/prettier-plugin-pkgsort/blob/6b22c3cb73170a28febe7d9bb2a1e91bdf344d5d/test/package.test.ts#L24
I hope new URL("../dist/index.cjs", import.meta.url) won't fail on Windows
upd: it works!

Thanks!


Make file name of attachment available as key

Given the list of keys from the option page, there is no option to use the original filename of the attachment, i.e. what I want to have file.pdf renamed to 2023-05-16 file.pdf.
What be cool to have {{attachmentFileName}} available.

Need a variable to represent the old name of attach (before last rename operation)?
Or the original name before using this plugin?
i.e.
origianl name: file.pdf
after first time renamed name: 2023-05-16 file.pdf
after second time renamed name: 2023-05-17 2023-05-16 file.pdf or 2023-05-17 file.pdf

What I need is the original file name, i.e., the name before I moved it into Obsidian.

This feature need to persisten the attachment name, with the growing of vault, the cost of this plugin will be heavy.
Btw, we could add a option to enable append the attachment name (set in settings) to prefix or suffix of the attachment that need to be renamed.

My intention was not keep the original name for later renamings, but only use for the initial renaming when a file is added to the vault. Later, of course, the original file is lost.
Best!

I have know you request.
We could add a variable like ${attachmentFileName} in Attachment format field, and if the variable was used for one note, the auto rename will disable for it.
Currently, If you don't need to renaming the file in future but only for first adding to vault, your can turn off the Automatically rename attachment, of cause it will close the auto rename globaly right now.

It is maybe possible to keep the original filename on a variable, the first time the file is added to a vault, and during the renaming, in place of using the date (for example), apply the original filename? Or maybe rename it "two times" ?
I think you can apply the new path & apply the original name right after ?

Hi, @floli.
You can use ${originalname} as the original name in attachment name in 0.5.0.
Tks for @Lisandra-dev's work.

I'm sorry to bother you.
Your software is very practical, but I encountered a little problem in the process of use, I would like to consult you.
I used {originalname}}, copied the image in Explorer, then pasted it twice in OB editor, there was always no renames, and the two photos were stored in different paths.

I'm sorry to bother you.很抱歉打扰你。 Your software is very practical, but I encountered a little problem in the process of use, I would like to consult you.你们的软件很实用，但是在使用过程中遇到了一点问题，想咨询一下。 I used {originalname}}, copied the image in Explorer, then pasted it twice in OB editor, there was always no renames, and the two photos were stored in different paths.我使用了{originalname}}，在资源管理器中复制了图像，然后在OB编辑器中粘贴了两次，始终没有重命名，并且两张照片存储在不同的路径中。

The ${originalname} will be replace with the filename that you pasted. And what's your filename? Snipaste_2023-07-25_11-51-41 1.jpg?
Have you modifed the Attachment format between twice paste?
I have try to set Attachment format as IMG-${originalname} and paste a png with name Crayon.png in same file. The result is below

Can you explain more detail of your situation

Thank you very much for your reply.
The source file name is: 'Snipaste_2023-07-25_11-51-41.jpg', copy and paste from the Explorer to the ob editor, do not make any changes, continue to paste to the ob editor, there is no rename situation, and the paths of the two images are different.
attachment-format: IMG-${originalname}-${date}


Update README.md to include a hint for WSL

added a little bit of text which hints WSL users to run cargo install spotify_player with --locked so it'll work.
This should avoid further issues being created to find this solution.

(I rarely work with github, I hope I did not press any annoying buttons, If I did, I'm very sorry)

(I rarely work with github, I hope I did not press any annoying buttons, If I did, I'm very sorry)

all good, thanks for the PR!


Quickstart Documentation changes

Hi Carto.js team! I ran into these issues while following the Quickstart documentation and wanted to log them here.
Quickstart Documentation issues:
<script src="https://cartodb-libs.global.ssl.fastly.net/carto.js/%VERSION%/carto.min.js"></script>

Consider changing %VERSION%  to the latest carto.js version (v4.0.0-beta.10) in the code example in the Quickstart guide, or make a clear note that the user should replace the version with the latest.

Couldn't find documentation on carto.layer.events.FEATURE_OVER (found in the Quickstart guide) in the References... is this the equivalent of 'featureOver'?

When adapting the Quickstart code to create a pop-up when mousing over contiguous polygons, I found that the pop-up content never disappears or updates! My solution was to remove the if (!popup.isOpen()) statement in the pop-up code, which made me wonder if it was necessary in the first place?

Finally, it would be nice to see the final map from the Quickstart guide to understand expected behavior 😄

Hi @michellemho!
Thanks a lot for reporting!

As you said %VERSION% should be the latest carto.js version so, you found a bug!
Fixed right now!
There's also an open ticket here -> #2013 regarding the same topic. Let's see if by tackling/ solving that issue your doubts are cleared out too.
Maybe if you contact @IagoLast or @Jesus89 to show them what you've been working they can help you with that!
Yes! Done!

Hi Michelle!
Regarding your popup question, it's true that the code it's only updating contents when showing the popup again, which is OK with the example dataset, sparse points. Every time you hover a point you're sure that the popup has been closed before. In your case, with continuous polygons or a dense network of point, it won't work. Good catch!


Add oss bool to default/mock project data

This doesn't seem right.

PR-Codex overview
This PR adds a new field oss of type boolean to socialLinks in oas_v1.yaml and sets oss to true in getProjects.ts.
Detailed summary

Added a oss field of type boolean to socialLinks in oas_v1.yaml
Set oss to true in the getProjects.ts file

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Don't merge this.

See #325 , #328


cop_helpers should be deprecated

As a followup to #7970, I feel that all of the methods in cop_helper should be deprecated. Here is why:
inspect_source and autocorrect_source seem too low level and don't lead to the right patterns. Among other things, they don't use lets for anything. So some things get duplicated (e.g. building the processed_source). No instance is shared by default, so many specs are calling inspect_source and then autocorrect_source, which is a really bad pattern: the same cop is called twice, with different source_buffer (although the same source code), with settings that has been hacked (via instance_variable_get 😱), something that won't even work currently if the cop is constructed with auto_correct set to true.
Example: this spec checks 78 cases (59 with offenses, 19 without).  The inspect_source is called 118 times for nothing. Each case with offense also calls autocorrect_source twice.
I feel these (at least) should be officially deprecated (at least in the doc) in 1.0, in favor of expect_offense/expect_no_offense or better.
inspect_source_file is used in one spec, I don't know if there's a good reason for it at all.
Maybe parse_source could remain as is, although it is still very low level and I'd still favor processed_source (in shared context).
autocorrect_source_with_loop => I checked the one cop spec that uses it. Unless I'm mistaken, this isn't really about the cop but simply that some autocorrected cases may lead to another autocorrectable offense. Would be best handled with two expect_offense with correction or similar.

No objections from me. Those are all remnants from the early days of RuboCop and we certainly have better APIs at our disposal today.

autocorrect_source_with_loop => I checked the one cop spec that uses it. Unless I'm mistaken, this isn't really about the cop but simply that some autocorrected cases may lead to another autocorrectable offense. Would be best handled with two expect_offense with correction or similar.

I am actually working on adding looping to the expect_correction method.

I am actually working on adding (optional) looping to the expect_correction method.

Sounds great!

I originally posted this info in #8127. I think it makes more sense here since it is a more technical discussion.
I haven't found a way to use expect_offense on any test that points to blank line. expect_offense doesn't have a way to process highlight that doesn't really point to anything https://github.com/rubocop-hq/rubocop/blob/3b0552b9989db97104cfe0fc30515e9b6ae549f2/spec/rubocop/cop/layout/empty_lines_around_method_body_spec.rb#L42-L51
  it 'registers an offense for class method body starting with a blank' do
    expect_offense(<<~RUBY)
      def Test.some_method

      ^ Extra empty line detected at method body beginning.
        do_something
      end
    RUBY
  end

Failures:

  1) RuboCop::Cop::Layout::EmptyLinesAroundMethodBody registers an offense for class method body starting with a blank
     Failure/Error: expect(actual_annotations.to_s).to eq(expected_annotations.to_s)

       expected: "def Test.some_method\n\n^ Extra empty line detected at method body beginning.\n  do_something\nend\n"
            got: "def Test.some_method\n\n Extra empty line detected at method body beginning.\n  do_something\nend\n"

       (compared using ==)

       Diff:
       @@ -1,6 +1,6 @@
        def Test.some_method

       -^ Extra empty line detected at method body beginning.
       + Extra empty line detected at method body beginning.
          do_something
        end

     # ./lib/rubocop/rspec/expect_offense.rb:125:in `expect_offense'
     # ./spec/rubocop/cop/layout/empty_lines_around_method_body_spec.rb:43:in `block (2 levels) in <top (required)>'

Finished in 0.04196 seconds (files took 1.03 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/rubocop/cop/layout/empty_lines_around_method_body_spec.rb:42 # RuboCop::Cop::Layout::EmptyLinesAroundMethodBody registers an offense for class method body starting with a blank

I think there might be a couple of other oddities to work through in order to convert everything. It's been a while since I worked on converting tests.
It might be worth while to document some of the tricks to handling white space and interpolation with different types of HEREDOCS. For instance,

    <<~RUBY
      puts 'foo' +
           "#{bar}"
      puts 'a' +
        'b'
      "#{c}"
    RUBY

# vs

    # The markdown syntax highlighting is incorrect here.
    # This does not actually perform string interpolation
    <<~'RUBY'
      puts 'foo' +
           "#{bar}"
      puts 'a' +
        'b'
      "#{c}"
    RUBY

A bit cryptic, but we could use ^{} to signify en empty marker here, or another special character.

I like ^{} as it reflects the existing ^ and ^{name} format. I've submitted a PR with this but happy to change it up if there are any preferred suggestions.

As we say that inspect_source_file is useless, here is my suggestion to inline it https://github.com/rubocop-hq/rubocop/pull/9273


2-pass alignment guidelines

In the default Stringtie pipeline with Hisat2, it utilizes a 1-pass alignment.  Other transcript discovery methods that utilize STAR have shown improved accuracy with a 2-pass workflow.  Is there any reason to believe a 2-pass alignment (from the output of Stringtie, back into Hisat2) would help Stringtie's accuracy?  Just thought I would ask in light of Stringtie's new abundance estimation method.

I don't think it would help, novel junction discovery is already performed by Hisat2 "on the fly" in the first run, and StringTie does not add any new junctions by itself, and I suspect the exon coverage would not even change (not significantly anyway) with a 2nd alignment pass.

Thank you!  For what it's worth, I came across this article which agrees exactly.  I guess it can make some difference for intron discovery, but makes virtually no difference for exons.


[FEATURE] Add language option for google chart api

Add the language option for the chart api for number format etc
#15 related

Thanks!


bug: Heater Shaker API set shake speed when the latch is open does not behave as expected

Overview
When I send a shake command to a HS that has a latch not closed, the HS should not shake.
The HS does not shake but the command does not say forbidden or return an error that the command is not allowed.
Ultimately the command fails
Steps to reproduce
repository
test test_shake_blocked_by_open_latch
Current behavior
command
{'data': {'commandType': 'heaterShaker/setAndWaitForShakeSpeed', 'params': {'moduleId': 'a83c65e79b3713c851b133533757b10ec8cb2d95', 'rpm': 400}}}

response
status_code = 201
POST http://<IP_ADDRESS>:31950/runs/1b0e6113-0b3a-4579-a477-79deee6792b8/commands?waitUntilComplete=true&timeout=59000
40.264476
{
    "data": {
        "id": "cadaff43-abe0-4854-a3e3-7f2562228976",
        "createdAt": "2022-06-16T21:02:34.044774+00:00",
        "commandType": "heaterShaker/setAndWaitForShakeSpeed",
        "key": "cadaff43-abe0-4854-a3e3-7f2562228976",
        "status": "failed",
        "params": {
            "moduleId": "a83c65e79b3713c851b133533757b10ec8cb2d95",
            "rpm": 400.0
        },
        "error": {
            "id": "36c3ddbd-b476-44fd-a8de-a26beebf465f",
            "errorType": "UnexpectedProtocolError",
            "createdAt": "2022-06-16T21:03:14.238014+00:00",
            "detail": "/dev/ot_module_heatershaker4: No response to 'M3 S400 \n'"
        },
        "startedAt": "2022-06-16T21:02:34.047083+00:00",
        "completedAt": "2022-06-16T21:03:14.238014+00:00",
        "intent": "setup"
    }
}

robot log
Jun 16 21:03:14 kansas opentrons-api-serial[231]: /dev/ot_module_heatershaker4: Read <- b'ERR126:main motor:plate lock not closed (required)\n'
Jun 16 21:03:14 kansas opentrons-api-serial[231]: /dev/ot_module_heatershaker4: retry number 0/0
Jun 16 21:03:14 kansas opentrons-api-serial[231]: /dev/ot_module_heatershaker4: Write -> b'M105 \n'
Jun 16 21:03:14 kansas opentrons-api[231]: Execution of cadaff43-abe0-4854-a3e3-7f2562228976 failed
                                           Traceback (most recent call last):
                                             File "/usr/lib/python3.7/site-packages/opentrons/protocol_engine/execution/command_executor.py", line 84, in execute
                                               result = await command_impl.execute(command.params)  # type: ignore[arg-type]
                                             File "/usr/lib/python3.7/site-packages/opentrons/protocol_engine/commands/heater_shaker/set_and_wait_for_shake_speed.py", line 63, in execute
                                               await hs_hardware_module.set_speed(rpm=validated_speed)
                                             File "/usr/lib/python3.7/site-packages/opentrons/hardware_control/thread_manager.py", line 78, in wrapper
                                               return await call_coroutine_threadsafe(loop, attr, *args, **kwargs)
                                             File "/usr/lib/python3.7/site-packages/opentrons/hardware_control/thread_manager.py", line 46, in call_coroutine_threadsafe
                                               return await wrapped
                                             File "/usr/lib/python3.7/site-packages/opentrons/hardware_control/modules/heater_shaker.py", line 344, in set_speed
                                               await self._driver.set_rpm(rpm)
                                             File "/usr/lib/python3.7/site-packages/opentrons/drivers/heater_shaker/driver.py", line 132, in set_rpm
                                               await self._connection.send_command(command=c, retries=DEFAULT_COMMAND_RETRIES)
                                             File "/usr/lib/python3.7/site-packages/opentrons/drivers/asyncio/communication/serial_connection.py", line 119, in send_command
                                               data=command.build(), retries=retries, timeout=timeout
                                             File "/usr/lib/python3.7/site-packages/opentrons/drivers/asyncio/communication/serial_connection.py", line 140, in send_data
                                               return await self._send_data(data=data, retries=retries)
                                             File "/usr/lib/python3.7/site-packages/opentrons/drivers/asyncio/communication/serial_connection.py", line 176, in _send_data
                                               raise NoResponse(port=self._port, command=data)
                                           opentrons.drivers.asyncio.communication.errors.NoResponse: /dev/ot_module_heatershaker4: No response to 'M3 S400
                                           '
Jun 16 21:03:14 kansas opentrons-api-serial[231]: /dev/ot_module_heatershaker4: Read <- b'M105 C:25.13 T:None OK\n'

Expected behavior
The command returns immediately telling me it failed and indicates in the error detail it was due to being unable to shake when the latch is open.

See https://github.com/Opentrons/opentrons/issues/10814#issuecomment-1158879843
Fix coming up


[Add] Guide on how to run this project locally on host machine

Some fixes need to be done in the requirements.txt

I have some questions.

[Add] Guide on how to run this project locally on host machine

This is to be added in Readme, isn't it?

Some fixes need to be done in the requirements.txt

Can you specify the changes?

After creating Environment
python -m venv env
Activate the environment
Source env/bin/activate
Install the required packages
pip install -r requirements.txt
there is some error showing up, try from your en

Update Package Versions: If the issue involves outdated package versions or conflicts between packages, consider updating the package versions in the requirements.txt file. You can specify the desired version of a package using the format package-name==version.
Remove Unnecessary Packages: If there are packages listed in the requirements.txt file that are no longer needed for the project, remove them to simplify the dependencies.

Thanks for the reply @SimardeepSingh-zsh will update and try to close the issue.


save session in example

Thanks. It seems somwhere in time, I updated the example to use autoSave: true and never uncommented that line. I'll merge this.


chore: add end-to-end tests

This PR adds end-to-end tests for the following endpoints:

subscribe
verify
unsubscribe

How to test
Github actions workflow has been updated to reflect the test setup.
If running on local,

create a envelop_test database, with the exact same schema
yarn global add dotenv-cli
start the app with dotenv -e test/.env.test yarn dev
test the app with yarn test:e2e

Running yarn test (unit tests) does not require any changes, and works like before.

Please test and confirm that the merge conflict resolution did not break anything


Need to remove default submit button in form builder

When new form is built, how to disable automatically adding 'submit' button in a new form?
We would like to start from a blank form without submit button.
Passing defaultTemplate = { display: 'form', components: [] }; creates submit button.
it would be nice if the code below would not be default  behavior:
/**

Adds a submit button if there are no components.
*/
addSubmitButton() {
if (!this.getComponents().length) {
this.submitButton = this.addComponent({
type: 'button',
label: this.t('Submit'),
key: 'submit',
size: 'md',
block: false,
action: 'submit',
disableOnInvalid: true,
theme: 'primary'
});
}
}

This is not a bug but works as designed. If you would like to include a configuration to not include this, then please feel free to add a pull request.

{ noDefaultSubmitButton: true } is added to FormDesigner options meantime.

For any who might be use custom JS in the Form Module, here is what the JSON needs to look like. The setting goes in the first "builder" node, not the second "builder" node.
{
"options": {
"builder": {
"noDefaultSubmitButton": true,
"builder": {
"resource": false,
"advanced": false,
"premium": false,
"data": false,
"layout": false
}
}
}
}

We're currently addressing a backlog of GitHub issues, and as part of this effort, some inactive issues may be marked as closed. This isn't a dismissal, but a step toward more efficient tracking.
If you feel the issue is still relevant, please re-open and we'll ensure it gets the attention it deserves. Your understanding is appreciated as we work to enhance our open-source responsiveness.


document no_ssl_verify for Github API ssl validation disable

Replaced it with skip_ssl_validation.

Will be in next release.


notification issue in sim mode

I had pushbullet notification on in the config, and i was running a sim with sar strategy,
and suddenly 100s of new tabs popped up in my chrome (with the location pushbullet.com). and it was keep on coming continuously. system became very slow and i had to force quit my chrome.

yes, because at the moment it sends notifications for each buy/sell op even if you are in sim mode. We can bind this behaviour to trade or paper running modes.

yea. i would suggest trade mode only

In zenbot/lib/engine.js, there are 3 places where notify.pushMessage happens. If the notify.pushMessage is wrapped inside a conditional statement (something like below), it will send notification only in live mode.
if (so.mode === 'live') {
  notify.pushMessage(......)
}

I would leave paper mode for testing and I think it's not necessary to put the condition at line 187, because a few lines before there was a return for all mode not equal to 'live'


Dictionary keys by variable do not store correctly

Godot version:
Godot Engine v4.0.dev.custom_buld.f97280a01
OS/device including version:
Mac OSX 10.15.5
Vulkan
Issue description:
Passing a variable key to a dictionary does not place values in the correct key.
Result:
{A:[A entry 0, B entry 1, A entry 2, B entry 3, A entry 4, B entry 5], B:[...]}

Expected Result:
{A:[A entry 0, A entry 1, A entry 2], B:[B entry 0, B entry 1, B entry 2]}

Steps to reproduce:
extends Node

var _entries = {}

func _ready():
	var key
	key = "A"
	_entries[key] = []
	key = "B"
	_entries[key] = []
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	print(_entries)

func _add_entry(key):
	_entries[key].append(key + " entry " + str(_entries[key].size()))

Minimal reproduction project: DictionaryBug.zip

Seems to be with the initialization of the values. This gives the expected output:
extends Node

var _entries = {}

func _ready():
	_entries = {
		"A": [],
		"B": []
	}
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	print(_entries)

func _add_entry(key):
	_entries[key].append(key + " entry " + str(_entries[key].size()))

Additionally, expanding this to:
	_entries = {
		"A": [],
		"B": []
	}
	_entries["C"] = []
	var key = "D"
	_entries[key] = []
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	_add_entry("C")
	_add_entry("D")
	_add_entry("C")
	_add_entry("D")
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	print(_entries["A"]) # [A entry 0, A entry 1, A entry 2, A entry 3, A entry 4]
	print(_entries["B"]) # [B entry 0, B entry 1, B entry 2, B entry 3, B entry 4]
	print(_entries["C"]) # [C entry 0, D entry 1, C entry 2, D entry 3]
	print(_entries["D"]) # [C entry 0, D entry 1, C entry 2, D entry 3]

"A" and "B" remain correct, but "C" and "D" get mixed up. However, they do not get values from "A" and "B" even when they are added after.

Initializing each array with UNIQUE values seems to give the expected output, but only if it's unique. Otherwise, Godot writes to the same array, e.g.
	var key
	key = "A"
	_entries[key] = [1]
	key = "B"
	_entries[key] = [2]
        key = "C"
        _entries[key] = [2] # Same as B
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	_add_entry("A")
	_add_entry("B")
	_add_entry("C")
	_add_entry("C")
	_add_entry("C")
	print(_entries["A"]) # [1, A entry 1, A entry 2, A entry 3]
	print(_entries["B"]) # [2, B entry 1, B entry 2, B entry 3, C entry 4, C entry 5, C entry 6]
	print(_entries["C"]) # [2, B entry 1, B entry 2, B entry 3, C entry 4, C entry 5, C entry 6]

A simplified version of the issue
func _ready():
	var v1 = []
	var v2 = []  ## both arrays are reduced to Array const and shares the same memory in constant map.

	v1.append(42)
	print(v2)   ## prints [42]

In 3.2 the literal array doesn't reduced to variant (even if all elements are compile time const) but it was ArrayNode and constructed at runtime (OPCODE_CONSTRUCT_ARRAY) but in 4.0 it's reduced to Array constant at GDScriptAnalyzer::reduce_array() and since it's a constant value every other similar array will points to the same location in the local constant map.
similar issue : https://github.com/godotengine/godot/issues/20436
adding constant to constant_map first search if it already exists, is it okey to ignore that existence search for arrays/ and dictionaries @vnen ?

adding constant to constant_map first search if it already exists, is it okey to ignore that existence search for arrays/ and dictionaries

Yeah, I was thinking about that. Though I'm not sure if we actually want to keep arrays/dictionaries in the constant map. It is theoretically faster (since it doesn't need to be built at runtime) but the space needed might not be worth it.


Fix ThreadError occuring on Signal.trap SIGHUP

Fix https://github.com/fluent/fluentd/issues/540
This is the first easiest implementation to fix the issue.

If works on @jperville environment, I will merge it.
These code are replaced with ServerEngine's in v0.14.

I have applied the patch by hand (wrapping the reloading code in a Thread) and it seems to be working.
Here is the fluentd output after applying the fix:
2015-01-19 07:59:37 +0000 [info]: restarting
2015-01-19 07:59:37 +0000 [info]: reading config file path="/etc/fluentd/fluentd.conf"
2015-01-19 07:59:38 +0000 [info]: shutting down fluentd
2015-01-19 07:59:38 +0000 [info]: process finished code=0
2015-01-19 07:59:38 +0000 [error]: fluentd main process died unexpectedly. restarting.
2015-01-19 07:59:38 +0000 [info]: starting fluentd-0.12.3
2015-01-19 07:59:38 +0000 [info]: gem 'fluent-mixin-config-placeholders' version '0.3.0'
2015-01-19 07:59:38 +0000 [info]: gem 'fluent-plugin-elasticsearch' version '0.7.0'
2015-01-19 07:59:38 +0000 [info]: gem 'fluent-plugin-exclude-filter' version '0.0.1'
2015-01-19 07:59:38 +0000 [info]: gem 'fluent-plugin-record-modifier' version '0.2.0'
2015-01-19 07:59:38 +0000 [info]: gem 'fluentd' version '0.12.3'
2015-01-19 07:59:38 +0000 [info]: gem 'fluentd' version '0.10.58'
2015-01-19 07:59:38 +0000 [info]: using configuration file: <ROOT>
  <match docker.filtered.**>
    type elasticsearch
    host localhost
    port 9999
    index_name fluentd
    type_name fluentd
    logstash_format true
  </match>
</ROOT>
2015-01-19 07:59:38 +0000 [info]: adding match pattern="docker.filtered.**" type="elasticsearch"

The fluentd main process died unexpectedly. restarting message is logged as expected.
I have also tried spamming sv hup restart to see how the program behaves when the HUP signal is received while the reloading code is still working, and it seems to behave sanely.

@jperville Thanks for the confirmation!
@sonots Is this no problem on regular environment? If so, please merge this patch!

It seems sending multiple HUP invokes bad situation with this code. I need SignalThread maybe. Please wait.

I need SignalThread

In v0.14, we have a plan to replace supervisor code with ServerEngine.
At that time, we use SignalThread for these signal handling.
So there is no additional patch for this problem.

Okay

Thank you very much @sonots and @repeatedly . Any chance for a new gem release with the fix?

I want to include https://github.com/fluent/fluentd/pull/542 for next version.
I will merge https://github.com/fluent/fluentd/pull/542 soon.

cherry-picked to v0.10 branch

@jperville I released v0.12.4. Please try!


DOC: Correct dual annealing visiting param range.

Dual annealing's visiting parameter cannot be less than 1, lest one
encounters domain errors in constructing VisitingDistribution.
Reference issue
Addresses #11781, which is premised on incorrect docs. Does not address #12384, which deserves some investigation into the actual numerical details of this implementation and the distribution it aims to sample.
What does this implement/fix?
This corrects documentation, which incorrectly implies that visiting parameters between 0 and 1 are valid.
Additional information
Numerical divergence in this logarithm when self._visiting_param is less or equal to 1: https://github.com/scipy/scipy/blob/master/scipy/optimize/_dual_annealing.py#L61

Merged, thanks @gregor-robinson


Message Encrypter and Decrypter

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
This extension would help secret messages to be encrypted which could only be decrypted using the same extension. It's next to impossible for someone to decrypt the messages because it doesnt uses any defined hashing techniques. The hashing technique and logic is designed solely by me without any external interference. It would have an advanced decryption feature also which would make the encryption more tough to decrypt for a normal person.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Encryption and decryption of private messages. Can be used by private services, couples, friends and anyone for a variety of purpose.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
As this is a newly designed logic without any existing hashing techniques, this would take alot of effort to be created so please consider this in level3 or level2 contribution of GSSoC'24.
What problem is this feature trying to solve?
Privacy invasion in messaging.
How do we know when the feature is complete?
When the user gets a encrypted message which gets decrypted to the same original message on decrytion.
Assign under GSSoC'24.
Thank You :)

Successfully merged 🥳


Generate ROR ID matches CSV report

https://docs.google.com/document/d/1fyYkVLoswWQFCW4YjEpFUYxJJeGuezE2zIhtegUKK8c/edit#heading=h.5y0g3ggqd38s
After performing the cleanup steps above, attempt to match organization names in the affiliations and funders tables that don’t already have an external ID to ROR IDs using the ROR API.
Output should be a report in CSV format with candidate matches from the ROR API. Do not actually update the external_id field at this point.
The report should include the following fields:
Organization name in corpus DB
ROR match 1 name
ROR match 1 ID
ROR match 1 score
ROR match 2 name
ROR match 2 ID
ROR match 2 score
…Include above fields for up to 5 ROR matches

@ashwinisukale Maria requested that this report also include the value of the "chosen" field for each result, which is either True or False. Can you add this after the score col for each of the top 3 results and re-run the report?


[Question]: WS in entrypoint.sh cannot accelerate file processing

Describe your problem
I compared ws of 1 and 5, the deepdoc model is not running concurrently and the processing time for the same file is longer with ws set to 5. It is not normal. Is it because there is some shared resource in the code that causes the context switch to take longer?

Both OCR and embedding consume 10+ CPU. It's normal that enlarging WS makes the whole procedure slower.


Arch Linux - Just updated containerd, broke docker.service

Hello,
I'm fairly certain this issue has to do with containerd, rather than docker proper.
I just updated containerd on my Arch linux distro and just after that update, the docker.service broke and all docker commands hang.
I tried stopping the service, rebooting, and restarting the service and now it's saying Unit auditd.service could not be found.
Any advice?
(I apologize if this is a simple fix, or even a user-error, but it's waaaaay outside my regular scope of expertise)
Thanks in advance.

Nevermind: This is probably an issue with the arch package, rather than containerd. I pruned all my state=not-found services and rebooted and everything is ostensibly working now.


states are a mess

after the rework, the states are a terrible mess ... please redesign this 🙏

a lot to rewire here ...

got a bit better now


With recompose

Add an example of how to use Next.js with recompose to wrap pages and still use getInitialProps.

I know we already have an example with recompose but it also use redux and reselect, this is a simpler example only with recompose and use a HOC to set the getInitialProps static method instead of defining it after enhancing the component


[code-infra] Move next plugin to @mui/docs

Start moving more docs infra into @mui/docs

make the main export of @mui/docs the next.js plugin
start a @mui/docs/components folder for docs specific components
move docs/config in there
IMPORTANT: I removed the initialization of process.env.DEPLOY_ENV in next.config.js. The program will get its value through the next.js who's setting this value as part of the env config. Would like to avoid this plugin from changing global state

[ ] Canary on X

Will redo this