Call pthread_sigmask() as early as possible so Xwayland SIGUSR1 is not caught by GPU driver threads

Supersedes/replaces https://github.com/swaywm/sway/pull/4537

Hmm, this isn't a good place for this piece of code.
Can't the Mali driver ignore SIGUSR1?

Hmm, this isn't a good place for this piece of code.
Can't the Mali driver ignore SIGUSR1?

No.

No.

Why not?

No.

Why not?

This patch is how you make the Mali driver ignore SIGUSR1.
When a thread receives a signal it wasn't expecting, the process terminates. The way you indicate that the signal is not unexpected is by calling pthread_sigmask() before the thread is created, which is what both this patch and Weston do.

If there's no way to move this inside wlr_xwayland, I'd prefer this patch to be in sway's main function.

If there's no way to move this inside wlr_xwayland, I'd prefer this patch to be in sway's main function.

I agree. Messing with signal masks in the library will only cause more problems. We're   doing this in phoc
https://source.puri.sm/Librem5/phoc/blob/master/src/main.c#L116
to avoid having the wrong thread receive the signal.

https://source.puri.sm/Librem5/phoc/blob/master/src/main.c#L116

In your code:
  sigprocmask(SIG_BLOCK, &mask, NULL);

$ man 2 sigprocmask
...
The use of sigprocmask() is unspecified in a multithreaded process; see pthread_sigmask(3).
...

Mali is in the wrong here. They should not be doing this.

Yeah, I don't see why Mali would have issues with this, yet many of the Mesa drivers (which are multithreaded) don't.
We've have next to no interest in supporting proprietary drivers. It's fine if they happen to work with standard interfaces or with things like GBM, but going out of our way to have workarounds for them is not something I want to carry. That's not even something I would want to do with an open driver.

We've have next to no interest in supporting proprietary drivers

I would say we have less than zero interest.

They should not be doing this.

Not be doing what, exactly?


Can you be more specific how to set makeprg and errorformat to normal?

When running :Neomake, nothing comes back.
When running :Neomake!, it says Neomake: makeprg complete with exit code 2. But nothing happens to my file, no warning, no error.
I tried all, ESlint, JShint and JSCS.

What versions of vim and neomake are you using?  I'm on neovim 0.1.3 and the latest version of this plugin.
I setup a little test file and installed jshint:
$ cat test.js
function test(a, b) {
	return a;
	return b;
}
$ npm install -g jshint

Then I opened test.js with neovim, ran :Neomake and jshint does indeed put an error in the gutter.  Maybe you have an old version of something?
Note that I didn't have to change errorformat or makeprg -- I also didn't have to setup any Neomake "makers."  It worked out of the box despite what the docs say.

Yeah, the problem I have before was I am trying to lint with Airbnb, now it works without Airbnb.
Thanks.


chore: improve test coverage for ibc connection

changes made

add additional test coverage for ics-03 connection
optimized previous test coverage for ics-03 connection by using test context setup

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.67%. Comparing base (3767742) to head (262bde0).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #842      +/-   ##
============================================
+ Coverage     70.25%   70.67%   +0.41%
  Complexity      414      414
============================================
  Files           155      155
  Lines         14028    14028
  Branches        292      292
============================================
+ Hits           9856     9914      +58
+ Misses         4022     3964      -58
  Partials        150      150

Flag
Coverage Δ

rust
68.86% <ø> (+0.48%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes


[FATAL ERROR] With binaries for Windows_x64 from nightly builds, "SecureRecv() Disconnect" occurs, "SSL Fatal Error on ASYNC socket !!!" occurs. No connection made.

Prerequisites

[ ] Can you reproduce?
Yes
[ ] Are you running the latest version of SoftEtherVPN?
Yes. I am running the binaries from "Nightly builds".

SoftEther version:
SoftEther VPN Developer Edition (Ver 5.02, Build 0)
Component: [Server, Client, Bridge, etc.]
Nightly  builds
VPN Client (vpntest.exe)
Created on SEP.15,2023   Refer to "vpntest.exe property"
Operating system: [Windows, Linux, BSD, macOS, etc.]
Win 10 PRO 22H2 BUILD 19045.3448 (VPN Client)
Architecture: [64 bit, 32 bit]
64 bit
Description
[Description of the bug]
64 Bit VPN Client can  not connect to VPN server.
32 Bit VPN Client works fine.
Expected behavior:
[What you expected to happen]
Debug() does not display the error message.
Actual behavior:
[What actually happened]
Debug() displays the error messages below.
D:\a\1\s\src\Mayaqua\Network.c 12282 SecureRecv() Disconnect
--- TCP Connection Decremented: 0 (D:\a\1\s\src\Cedar\Connection.c Line 2013)
            |
D:\a\1\s\src\Mayaqua\Network.c 12300 SSL Fatal Error on ASYNC socket !!!
--- TCP Connection Decremented: 0 (D:\a\1\s\src\Cedar\Connection.c Line 2013)

Steps to reproduce

[First step]
Run vpntest.exe
TEST>C

[Second step]
Run vpncmgr.exe
Click the button to connect to the VPN server
VPN server: public-vpn-233.opengw.net/tcp

[And so on...]
Debug() in VPN client displays the error messages

Appendix
20231001_NIGHTLY_BUILDS_X64_ERROR.txt

I tried to repro, no crash on my side.
I interested in "opengw.net" domain in your report. it is vpngate. do you have vpngate plugin installed ?
maybe it crashes with that plugin (I haven't test yet)

@hiura2023 , may I ask you to enable crash dumps https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
and possibly analyze dump with WinDBG?

I interested in "opengw.net" domain in your report. it is vpngate. do you have vpngate plugin installed ?

I haven't installed vpngate plugin.
Thanks a lot for dump information.

I write incorrect information.
Pipeline is PR, not nightly.
Try this here.
Appendix

This is the second time.
Same error.
32 Bit applications are included in Windows_64 artifacts. This is a bug.
Please try here.
Appendix

Same error occurs with 32 bit vpntest.exe. In addition to it, 32 Bit executable files are included in Windows_64 artifacts. This is a bug. Please try here.
Appendix A
This is the third time.

Appendix B
This is the fourth time.

thank you for the report.
looks like it is still the same bug

were you able to collect crash dump ?
as far as I understand, there are 2 issues:

crashing      --> not fixed
wrong arch --> fixed

?

Same error occurs
①executable files:
https://github.com/SoftEtherVPN/SoftEtherVPN/actions/runs/8953193265?pr=1988
Binaries-x64
public-vpn-243.opengw.net/tcp
②result:
`
Additional Connect Succeed!
TCP Connection Incremented: 5
New Half Connection: TCP_SERVER_TO_CLIENT
D:\a\SoftEtherVPN\SoftEtherVPN\src\Mayaqua\Network.c 12313 SSL Fatal Error on ASYNC socket !!!
--- TCP Connection Decremented: 4 (D:\a\SoftEtherVPN\SoftEtherVPN\src\Cedar\Connection.c Line 2013)
LIST_NUM(tcp->TcpSockList): 0
Additional Connection #5
ClientConnectGetSocket(): Using cached IP address <IP_ADDRESS>
ClientConnectGetSocket(): Additional source port number 20005
`

interesting.
I've an idea. give me some time

@hiura2023 , I tried to repro using provided steps. no luck.
fortunately, there's similar issue with another repro steps
https://github.com/SoftEtherVPN/SoftEtherVPN/issues/1995
hopefully these issues will be fixed altogether

@chipitsine Can you please test it ? Use the VPN server with version 4.0, not 5.0. Use the VPN client https://github.com/SoftEtherVPN/SoftEtherVPN/actions/runs/8953193265?pr=1988 Binaries-x64
No connection to VPN servers below. ①SoftEther VPN 4.0 (Ver 4.38, Build 9760) in my PC. ②VPN Gate public-vpn-243.opengw.net/tcp vpn511818512.opengw.net/tcp

it is not clear what do you mean by "use 4.0 Server" and "use vpngate"
as far as I understand, vpngate is server itself, so it make sense to use client to connect to it, but what it the idea of using own server together with vpngate ?

@hiura2023 , I tried to repro using provided steps. no luck.

Really ?
I would like to confirm your test environment.

hopefully these issues will be fixed altogether

hopefully ?
You are responsible to fix this bug.

also, I tried binaries with asan enabled (I rebuilt locally)
https://learn.microsoft.com/en-us/cpp/sanitizers/asan?view=msvc-170
asan did not find any issue

As to the stable edition,
getting error code for SSL_* () function has been changed.
I think that making same modification wiil dissolve.

it is down to backporting https://github.com/SoftEtherVPN/SoftEtherVPN_Stable/commit/fdc2bf771beb3f108be48ad516fd0a56cb43deb4#diff-3436ee06aade7beaa24b00d1a4b971a0882873d46c25bff749863b8d24b4036c
@hiura2023 , if you have an appetite for backporting, I would appreciate.
I plan to have a look myself, maybe around the next weekend

About artifact binaries after making modification with same ssl error handler of stable edition
Still having the same problem.
D:\a\SoftEtherVPN\SoftEtherVPN\src\Mayaqua\Network.c 12321 SSL_ERROR_SSL on ASYNC socket !!! ssl_err_no = 167773230: 'error:0A00042E:SSL routines::tlsv1 alert protocol version'
①My vpntest.exe as client works successfully. Executables created by my PC looks fine.
②Artifact vpntest.exe as client does not work.
Undefined signature algorithms are sent to VPN Server.
Is the ssl library updated ?

LOG_THREAD: MsSetThreadPriorityIdle
Uploading Signature...
Downloading Hello...
LOG_THREAD: MsSetThreadPriorityIdle
Server Version : 432
Server String  : SoftEther VPN Server (64 bit)
Server Build   : 9729
Client Version : 502
Client String  : SoftEther VPN Client Developer Edition
Client Build   : 0
session_name: SID-VPN-237626-291519B8D8, connection_name: CID-1518765-AF043B3D4E
EnableBulkOnRUDP = 0
EnableHMacOnBulkOfRUDP = 0
EnableUdpRecovery = 0
BulkOnRUDPVersion = 0
UseUdpAcceleration = 0
SessionMain: SID-VPN-237626-291519B8D8
LOG_THREAD: MsSetThreadPriorityIdle
LOG_THREAD: MsSetThreadPriorityIdle
D:\a\SoftEtherVPN\SoftEtherVPN\src\Mayaqua\Network.c 12321 SSL_ERROR_SSL on ASYNC socket !!! ssl_err_no = 167773230: 'error:0A00042E:SSL routines::tlsv1 alert protocol version'
--- TCP Connection Decremented: 0 (D:\a\SoftEtherVPN\SoftEtherVPN\src\Cedar\Connection.c Line 2013)
LIST_NUM(tcp->TcpSockList): 0
Additional Connection #1


Add jlx

This could be similar to npx, i.e. to run Julia applications. I haven't thought much about it, but I think my main scenario would be something like:
jlx Foo

would automatically install a package called Foo from the general registry, and then run some well defined entry point (say Foo.main).

https://github.com/Roger-luo/IonCLI.jl has a full set of such features that you might be interested to get inspiration from. But I think it's better to solve https://github.com/JuliaLang/Pkg.jl/issues/1962 first before we actually work on this.

I personally would prefer this to be separated from juliaup implementation, I have been thinking about how to install CLIs, I find for Julia it would be much easier if we can assume there is a Julia locally for various reasons (e.g we can have deamon process to reduce latency if we are able to assume there is a Julia available). And this is now possible with juliaup.
I think with juliaup we will be able to simplify the logic in a manager like Ion that let it depends on Julia, and get updated by juliaup (similar to cargo to rustup). so I'm now rewriting IonCLI here https://github.com/Roger-luo/Ion.jl/ to make use of this assumption, I'm happy to chat if anyone is interested in this direction


Trying to convert to json with mapper using the type Mappable directly doesn't work

Hello,
I'm trying to be as generic as possible with my network requests but cannot figure out why the following is not working:
`
private func postAuthInfo(url: NSURL, payload: Mappable) {
let payload = Mapper().toJSONString(obj)

Alamofire.request(.POST, url, parameters: payload, encoding: .JSON).responseString(completionHandler: {
    response in
    if response.result.isSuccess {
        TokenManager().saveToken(response.result.value!)
    }
    else {
        NSNotificationCenter
            .defaultCenter()
            .postNotificationName(ERROR_TO_DISPLAY_IN_ALERT, object: "Error posting request \(response.result.description)")
    }
})

}
`
I intended to pass my instances of model objects implementing Mappable to that function, convert it to json and process it in the network request.
The error I get is:  "cannot invoke 'toJSONString' with an argument list of type '(Mappable)'
Invoking my concrete Mappable implementation (e.g. User) works without any problem.

I believe this should work if you change your function definition to the following:
private func postAuthInfo<T: Mappable>(url: NSURL, payload: T)

Ok, thanks a lot, will try asap

Closing this for now, you can reopen if you are still having issues.


Support GHE in new workflow link in Actions Plugin

Feature Suggestion

Currently the link to create new workflows is hard coded to github.com. Can we instead read the integrations.github.host config so that this will link correctly to GHE instances?
Possible Implementation

Build the url using the integrations.github.host config and default to github.com if not defined.
Context
https://github.com/backstage/backstage/blob/073bba7151adb463a6d62d30c802cf41019ce79a/plugins/github-actions/src/components/Cards/RecentWorkflowRunsCard.tsx#L84

This might be an easy one. Just a few lines above where the owner and repo var are defined, is the hostname:
https://github.com/backstage/backstage/blob/073bba7151adb463a6d62d30c802cf41019ce79a/plugins/github-actions/src/components/Cards/RecentWorkflowRunsCard.tsx#L56-L61
I don't have GHE actions running, but maybe you'd be willing to give it a shot and if it works, file a PR for it @kuangp ?

Thanks @adamdmharvey I made the changes according to your suggestion and its working correctly linking to my GHE instance


How to get XICs when we running Mzmine3 in batch mode on a cluster

Hello, I have created a batch from GUI and can run on CLI. But Iam wondering how to get visualization in CLI mode.  I want to see peaks and their shapes and XIC plots after running the batch on the command line interface in MzMine 3. If you could help. Many Thanks.
Also, curious to know feature list we get from running the batch in cli, how it can be imported to MZMine back to visualize?
Please help. Thanks.

MZmine 4 has a batch export of charts like chromatograms and spectral library matches. We will soon publish a new version with user support and CLI.

Thank you. That would be wonderful.


Autocomplete on search

After updating my react lib + react toolbox, the search query doesn't seems to work anymore.
<Autocomplete           label={props.label}           onChange={props.onChange}           source={props.data}           value={props.value}           disabled={props.disabled}           multiple={false}         />
it doesn't seems to work on sandbox either, http://react-toolbox.com/#/components/autocomplete
seems like const rawQuery = this.state.query || this.props.multiple ? '' : this.props.value; in suggestion method line 166 is causing the issue. it's always returning an empty string
does this make sense const rawQuery = this.state.query || (this.props.multiple ? '' : this.props.value); > this will work. do correct me if i am wrong. thank you

and one more thing, not sure if it make sense to include in name props for the Autocomplete component. seems like it's not being passed on to the input component

Fixed and released, thanks! Btw, I think the name prop should be passed down. Maybe I'm missing something but a name prop is unknown to the Autocomplete so it takes it in a rest operation along with other unknown props and spread them to the input.


can't use ida to generate .cfg file

I'm can't use ida to generate cfg file,it always show this error, but bin_descend.exe is fine!!!
when i test dll_test_6.bat, it will crash by use bin_descend.exe, also ida does't work!

how can i solve it???

You must patch to skip spaces in Python CFG generate script file.
It is contain spaces in the cfg file generated by the IDA Pro.

sorry, i don't understand how to operate it. could u show me a piece of modify code?

@AmesianX

It is a compiled package for mcsema.
only Debug / x64 mode.
pre-cmaked visual studio 2015 mcsema
[mcsema.7z]
https://www.dropbox.com/s/tcg4xv9rcw3y5wi/mcsema.7z?dl=0

@AmesianX  thank you very much!!!!

:)-
You must extract to "c:\mcsema"


chore(Makefile): use bash as default shell

https://stackoverflow.com/a/589300
Fixes:
➜  ~ cd projects/sumologic-otel-collector
➜  sumologic-otel-collector git:(main) ✗ git reset --hard
HEAD is now at 1e0f157 docs(known-issues): describe filelog multiline issue
➜  sumologic-otel-collector git:(main) ✗ export TAG=v0.0.59-beta.1 ; make add-tag
Adding tag v0.0.59-beta.1
/bin/sh: 2: Bad substitution
make: *** [Makefile:126: add-tag] Error 2

I have $SHELL set either
5.3.1 Choosing the Shell
------------------------

The program used as the shell is taken from the variable `SHELL'.  If
this variable is not set in your makefile, the program `/bin/sh' is
used as the shell.

There is nothing about using shell's SHELL env


Collect software versions, help message

It would be nice to collect software versions at run time, as recently implemented in the NGI-MethylSeq and NGI-RNAseq pipelines.
See how this was done in SciLifeLab/NGI-RNAseq#141.

Done in #49


fix: don't panic when v2 scans end early (reader is dropped)

If the reader is dropped during a scan then the scheduler thread is ended after the decoder thread and the io thread.  This means the scheduler thread might get an error sending to a closed receiver.  Previously we would panic on these errors.  With this change we simply log a debug message and end early.

Seems reasonable. Though surprised there is no unit test as I expect this should be testable?

The panic was on the scheduler thread which is fire and forget.  So it just logged a message to console there was no other indication (e.g. it did not panic parent thread)
So I wasn't sure how to test it.  I did have a unit test I used for manual testing but wasn't sure about checking in something with no asserts.

@wjones127 I've added some unit tests.  I also now check the scheduler thread when the decode stream drops and propagate any panic that occurred on the scheduler thread.

Actually, is the CI failure relevant?

Actually, is the CI failure relevant?

Hmm, looks like it.  I'll investigate

Actually, is the CI failure relevant?

Yep.  When the user requested an empty range (e.g. 10..10 the scheduler would panic, this would cause the sending side of the scheduler->decoder link to drop, which made the decoder think the scheduler was done, and an empty batch would be returned)
This is all "technically correct" I guess but we can handle it better.
I was a bit torn on whether the reader should return an error (attempt to read an empty range) or an empty batch.  I went with returning an error (better to advise the user they are doing something fishy) but I could be convinced otherwise (more convenient to tolerate empty ranges).  @wjones127 any particular opinion?

Codecov Report
Attention: Patch coverage is 90.38462% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.44%. Comparing base (cf39bbb) to head (cb10214).
Report is 1 commits behind head on main.

Files
Patch %
Lines

rust/lance-file/src/v2/reader.rs
92.74%
9 Missing :warning:

rust/lance-index/src/vector/storage.rs
81.25%
0 Missing and 3 partials :warning:

rust/lance-io/src/scheduler.rs
0.00%
2 Missing :warning:

rust/lance-encoding/src/decoder.rs
92.85%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2690      +/-   ##
==========================================
+ Coverage   79.42%   79.44%   +0.02%
==========================================
  Files         227      227
  Lines       66855    67011     +156
  Branches    66855    67011     +156
==========================================
+ Hits        53099    53240     +141
- Misses      10630    10648      +18
+ Partials     3126     3123       -3

Flag
Coverage Δ

unittests
79.44% <90.38%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Changed file writes to append rather than write.

As the tests currently operate the test string will be overwritten on each loop.

That's what is supposed to happen.
Each strings gets written to a file, that file gets scanned, at the end of each string check the "assert" checks that it got detected.

My mistake. Thanks for reviewing.

No problem


CSS source maps no longer being output

At some point, extract-text-webpack-plugin, style-loader, and/or css-loader stopped outputting CSS source maps.
I've created a repo to demonstrate: css-source-map-test
If you run the webpack config from the example directory of this project, or the zip from issue #24, you can see the same result.
Steps to test:
git clone https://github.com/jordansexton/css-source-map-test.git
cd css-source-map-test
npm install
webpack

Expected output:
index.js
index.css
index.js.map
index.css.map

Actual output: (example gist)
index.js
index.css
index.js.map

I've verified this on three machines running node 0.12.2, iojs 1.6.4, and iojs 1.6.2. I believe CSS source maps were being output as of my testing last week, but something broke and I don't know what.
I've also tested this with css-loader 0.9.1 to check if recent changes broke it with no luck.

The SourceMapDevToolPlugin has a default test of /\.js$/... (We may need to change this)
As workaround you can add the SourceMapDevToolPlugin with test: /\.css(\?|$)/
http://webpack.github.io/docs/list-of-plugins.html#sourcemapdevtoolplugin

That worked, thanks!


currentNavigate is not immutable

it seems currentRoute is immutable while currentNavigate is not, so when it is used with immutablecontainer, it gives a corresponding warning.

currentNavigate is regenerated every time, so while it is not an immutable.js object, it is actually immutable. I don't know that it's worth the overhead to make this object an immutable.js object every time.
Which immutablecontainer are you using that throws this error?

I am using fluxible-immutable-utils/lib/createImmutableContainer in this way
class Container extends React.Component { ... }
Container = createImmutableContainer(Container, {
getStateFromStores: (context, props) => {
//using props.currentRoute here
}
});
Container = handleRoute(Container);

it's undocumented, but you can pass an ignore option to have the immutable container ignore certain props.
so:
class Container extends React.Component { ... }
Container = createImmutableContainer(Container, {
    getStateFromStores: (context, props) => {
      //using props.currentRoute here
    },

   ignore: ['currentNavigate']
 });

Container = handleRoute(Container);

Closing this since there is a workaround for use with the immutable utils. I think in the future we may rethink whether we should have immutable.js in the core library. It may make more sense for us to use reducers in the RouteStore and use raw immutable objects instead.

+1 for remove immutable.js from core lib. Much savings.

Me too, I'm for RouteStore using reducers.


Allow time period to be changed in the View Details/Find User overlays

View sessions and views may precede the boundary of the active period. It would be very useful to be able to change the active period directly with in the overlays without having to return to the main app and changing the time picker there.

This is impacted by the inability for a nerdpack to affect the platform time picker - we can't implement something custom and have it change the platform time picker.
Will investigate if the timepicker can be made available in an nerdlet overlay.


FIX Coreg GUI scaling error

@Eric89GXL this fixes the MRI scaling problem with Mayavi 4.5 mentioned in https://github.com/mne-tools/mne-python/issues/3934 for me. I now get a long list of errors like the one below, but they don't seem to have a negative impact:
ERROR: In /Users/ilan/minonda/conda-bld/work/VTK-6.3.0/Common/ExecutionModel/vtkExecutive.cxx, line 784
vtkCompositeDataPipeline (0x7fb020cc48e0): Algorithm vtkAssignAttribute(0x7fb020cc2d60) returned failure for request: vtkInformation (0x7fb020cc2ee0)
  Debug: Off
  Modified Time: 1184422
  Reference Count: 1
  Registered Events: (none)
  Request: REQUEST_DATA_OBJECT
  ALGORITHM_AFTER_FORWARD: 1
  FORWARD_DIRECTION: 0

Current coverage is 85.90% (diff: 100%)

No coverage report found for master at 4f948fa.

Powered by Codecov. Last update 4f948fa...6fc0b43

Ouch, yeah I get a lot of those errors. It will make any meaningful errors disappear. Is it possible there is a better way? Have you looked into what causes the error by any chance?

Looks like the error was caused by calling update on the scalar_scatter source; the last commit removes it for me.

Works great over here. Have you tried on older Mayavi 4.4.0?

I opened it and scaled the MRI in my old Mayavi 4.4 env, that worked

On Jan 30, 2017, at 11:46 AM, Eric Larson<EMAIL_ADDRESS>wrote:
Works great over here. Have you tried on older Mayavi 4.4.0?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-python/pull/3940#issuecomment-276115979, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI5a-GWpJS8aZLK6ktb-OykE8vOC_Rwks5rXhP2gaJpZM4LwamV.

Thanks @christianbrodbeck


Add support for prepared queries

This adds support for prepared queries destinations in addition to
service ones: an upstream can now target a prepared query and benefit
from features such as fallback between DCs.
Since prepared queries do not support bloquing requests this uses polling
to periodically check for changes. The default polling rate is 30s: the
same as the one consul uses, and can be overriden with the "poll_interval"
config option.

Can you force-push again to pass the unit tests?


Network mapped drive support?

Thanks for the excellent crate! It's nice to have such a feature-filled file browser for egui.
Just one issue - apologies if I missed something in the config, but I am not seeing mapped drives on Windows 10.

I don't really expect egui-file-dialog to find network paths, but if we have mapped them to a drive letter, I would have naively assumed they'd show up when enumerating drive letters.
Most of the files I need to access via my program are on my NAS, mapped to V:

Hey, thank you for the issue!
I would personally also expect network file systems to be included in the file dialog. Could you please try entering the path to a network filesystem directly via path edit in the top panel?
The file dialog is currently using the sysinfo crate to fetch the individual disks. So it seems that sysinfo::Disks does not contain any network-based disks 🤔

I'm doing something wrong in my code as when I click the pen icon I see the path edit turn into an edit control for one frame then switch back...
It works in the save file example, although there are some issues.
immediately after entering V:\  it goes there, but the path edit is blank:

going down one dir shows a path:

so I assume in the first example we should see 'UNC\synologynas\Vault' by itself.
The other issue, is that this directory contains 2,000+ items (directories and files).  The widget becomes basically unresponsive at that point.

I assume the reason the first segment of the path is not displayed is because the file dialog currently assumes that the path prefix "\\?\ exists on windows. I have to look into making the code more robust in this area. I've had problems with this in general on Windows.
Are you currently building the binary in debug or release build? With 2000 elements there should be no problems in the release build 🤔

But even in the debug build this shouldn't cause any problems. It could be that loading the directory elements over the network simply takes too long. If the dialog becomes unresponsive, have the elements already been loaded?

Yes, it's very sluggish in release mode.
It's still working, technically, you can scroll, although it takes a few seconds to update.
It does seem to be network-related, as I can view a similar directory on my SSD without so much lag (although there is a bit)

If it helps any, I was hoping to migrate from egui-file (https://crates.io/crates/egui_file)
It's not quite as nice looking, but it does show drive V: in the drive list, and after a second to initially load the Kryoflux directory, it scrolls through every item in there with no issues.

Ye that doesn't sound right. I have to see if I can reproduce this.

Before I start reproducing - which file dialog and egui version are you on?

Does egui_file load the available system drives?

yes, it shows all drives.
I was attempting to use 0.6.1 with 0.28.1 of egui in my project, because I don't use eframe and I am stuck on winit 0.29 for the moment due to custom rendering code that has to be completely rewritten for 0.30's api changes.
But I compiled the 'save_as' example to reproduce using a fresh clone of the repo:
egui-file-dialog v0.7.0 (D:\newdev\egui-file-dialog)
|-- directories v5.0.1
|   `-- dirs-sys v0.4.1
|       |-- option-ext v0.2.0
|       `-- windows-sys v0.48.0
|           `-- windows-targets v0.48.5
|               `-- windows_x86_64_msvc v0.48.5
|-- egui v0.29.1
|   |-- ahash v0.8.11
|   |   |-- cfg-if v1.0.0
|   |   |-- once_cell v1.20.2
|   |   `-- zerocopy v0.7.35
|   |   [build-dependencies]
|   |   `-- version_check v0.9.5
|   |-- emath v0.29.1
|   |-- epaint v0.29.1
|   |   |-- ab_glyph v0.2.29
|   |   |   |-- ab_glyph_rasterizer v0.1.8
|   |   |   `-- owned_ttf_parser v0.25.0
|   |   |       `-- ttf-parser v0.25.0
|   |   |-- ahash v0.8.11 (*)
|   |   |-- ecolor v0.29.1
|   |   |   `-- emath v0.29.1
|   |   |-- emath v0.29.1
|   |   |-- epaint_default_fonts v0.29.1
|   |   |-- nohash-hasher v0.2.0
|   |   `-- parking_lot v0.12.3
|   |       |-- lock_api v0.4.12
|   |       |   `-- scopeguard v1.2.0
|   |       |   [build-dependencies]
|   |       |   `-- autocfg v1.4.0
|   |       `-- parking_lot_core v0.9.10
|   |           |-- cfg-if v1.0.0
|   |           |-- smallvec v1.13.2
|   |           `-- windows-targets v0.52.6
|   |               `-- windows_x86_64_msvc v0.52.6
|   `-- nohash-hasher v0.2.0
|-- serde v1.0.213
|   `-- serde_derive v1.0.213 (proc-macro)
|       |-- proc-macro2 v1.0.89
|       |   `-- unicode-ident v1.0.13
|       |-- quote v1.0.37
|       |   `-- proc-macro2 v1.0.89 (*)
|       `-- syn v2.0.85
|           |-- proc-macro2 v1.0.89 (*)
|           |-- quote v1.0.37 (*)
|           `-- unicode-ident v1.0.13
`-- sysinfo v0.32.0
    |-- libc v0.2.161
    `-- windows v0.57.0
        |-- windows-core v0.57.0
        |   |-- windows-implement v0.57.0 (proc-macro)
        |   |   |-- proc-macro2 v1.0.89 (*)
        |   |   |-- quote v1.0.37 (*)
        |   |   `-- syn v2.0.85 (*)
        |   |-- windows-interface v0.57.0 (proc-macro)
        |   |   |-- proc-macro2 v1.0.89 (*)
        |   |   |-- quote v1.0.37 (*)
        |   |   `-- syn v2.0.85 (*)
        |   |-- windows-result v0.1.2
        |   |   `-- windows-targets v0.52.6 (*)
        |   `-- windows-targets v0.52.6 (*)
        `-- windows-targets v0.52.6 (*)

rustc 1.79.0 (129f3b996 2024-06-10)
Microsoft Windows [Version 10.0.19045.5011]

I created a directory with 50,000 elements. The performance in the debug build is not good, in release build you can notice that the file dialog runs a little slower, but its definitely still usable with minimal input lag.
But I also tested on Linux. I'll run the same test on Windows.

Ye alright on Windows, a directory with 50,000 elements is not usable at all. Interesting 🤔
So to summarize the todos of the issue:

[ ] Fix performance issues on Windows
[ ] Fix path prefix on Windows
[ ] Show network devices

Is something missing?

did you make files or directories? I noticed I can access a directory on my NAS that has about 1000 files in it, and it seems okay (after an initial pause) vs the directory that has lots of subdirectories.  I'll have to test a bit more.
I can test in linux as well, at least in a VM
your list looks good. I appreciate you taking the time to look at this!

Found the performance issue. It's because the directory items are filtered every frame. Interestingly, this doesn't cause any performance problems on Linux, but on Windows. I will now change it so that the file filter and show hidden files/folders are applied when loading the directory. This means that every time these filters are changed the directory needs to be reloaded. However, the performance will be significantly improved. The text-based search will still take place every frame. As far as I could test it on Windows, with 50,000 directory items this does not lead to performance issues.

edit: on Windows, the file name entry field of the native dialog sort of works as editing the path selection too. So if I hit V:\ as a filename and hit enter, it will change drives. I am not sure if that's something you'd want to implement, but it was my first instinct to try initially!

Do you mean that if you enter "V:\" as the filename in a file save dialog in Windows, the partition will be loaded instead of the file saved? This is interesting, but I don't think it fits the file dialog here. Because we have the path edit at the top, which can also be opened with / :)

Do you mean that if you enter "V:" as the filename in a file save dialog in Windows, the partition will be loaded instead of the file saved? This is interesting, but I don't think it fits the file dialog here. Because we have the path edit at the top, which can also be opened with / :)

yes, see below

of course, your call whether to implement that or not.  it may be something windows users are in a habit of taking advantage of.

I created an issue at sysinfo for the network mapped drives: https://github.com/GuillaumeGomez/sysinfo/issues/1384
I'll wait for the maintainer's response there before I implement my own version here.

@dbalsom All todos are now fixed on develop. Are you able to test the changes?

i'll let you know as soon as i can

Tremendous improvement! I see my NAS mapped V:, and the loading-spinner keeps egui responsive while it chews through the file listing, and once it is loaded it is very responsive.
one minor suggestion (don't shoot me) would be to cache the directory contents , if i go into a subfolder and then back out, it looks like it has to load everything again.
not a huge deal though. Thanks for your hard work.  Now I just need to update my winit so I can use this :)

Awesome, thanks for testing!
Caching is not quite so easy, because we do not know whether something has changed in the directory. This means that we would then have to work with modify timestamps of the directory, which depends on the platform and filesystem.
But I think that's something we can think about in the future. Can this issue be closed for now? If you have any further ideas or problems, feel free to create new ones :)

I'd say we're good. Thanks again.


misc/open_pdks.sky130a build should include sram

flag: ./configure --enable-sram-sky130
upstream:  https://github.com/efabless/sky130_sram_macros
branch: main

These files are fairly large, maybe they should it be in a separate package or "extras" (https://peps.python.org/pep-0508/#extras) in some way?

maybe simply a subpackage of open_pdks.sky130a?  open_pdks.sky130a.sram.

open_pdks.sky130a.sram could work...

Altogether, xz compressed, it's 177 MB. That's nothing.

we could do both!
We could have individual subpackages for each of the invidual cells library, as well as higher level variants that capture popular combinations (high density, low voltage, high voltage, everything)

I came to this thread because I wanted the end-user to have the other standard cell libraries exposed.
So what I was thinking was, whether it'd be possible to modularly install different libraries.
With an usual build environment, you'd do by that cloning the different libraries first, as desired, then running open_pdk's make. Clearly that's not an option in this case, with the intent being that everything is pre-packaged and doesn't require user build time.
What's the worst that can happen if we commit the blasphemous solution of:

Have a baseline conda package that clones the sky130 models and open_pdks, and then runs the open_pdks Makefile
Have additional conda packages, one for each library. All they contain is the libs.ref/sky130_fd_* folder that corresponds to the library in question.
End-user can install these additional conda packages as desired.
Each one of these packages is copied over on top of the pre-existing open_pdks install.

This assumes things like that the user does not change install path (or if they do, they change it for all packages). It can lead to over-written files. That sounds bad.
Is it that bad though? Can it be an acceptable solution?

yep, that's what I was leaning toward too with https://github.com/hdl/conda-eda/issues/203#issuecomment-1096815134
the current set we have with open_pdks.sky130a is:

sky130_fd_sc_hd
sky130_fd_sc_hvl
sky130_fd_io
sky130_fd_pr

are there other popular combinations that can be used as an alternative base? or are the following always installed individually?

sky130_fd_pr_reram
sky130_fd_sc_hdll
sky130_fd_sc_hs
sky130_fd_sc_lp
sky130_fd_sc_ls
sky130_fd_sc_ms

Personally, I would see the following packages being useful.

Base:  sky130_fd_pr, sky130_fd_sc_hvl, sky130_fd_io, sky130_fd_sc_hd.
All cells with 3.33um height: sky130_fd_sc_hs, sky130_fd_sc_ms, sky130_fd_sc_ls, sky130_fd_sc_lp
Stand-alone sky130_fd_pr_reram
Stand-alone sky130_fd_sc_hdll
Stand-alone sky130_fd_sc_hs
Stand-alone sky130_fd_sc_ms
Stand-alone sky130_fd_sc_ls
Stand-alone sky130_fd_sc_lp
Full: everything together in one package.

And I'd assume you'd also recommend for sram and fonts to be separate package?

For sram, yeah, I believe that would be best (?)
fonts I am not familiar with.


#138 fix

Change list
#138 fix: The ability to start an Appium node server using OpenQA.Selenium.Remote.DesiredCapabilities
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

##Details
Change list:

all capabilities were added.
Capabilities were added according to https://github.com/appium/appium/blob/1.5/docs/en/writing-running-appium/caps.md. Therea three classes:
OpenQA.Selenium.Appium.Enums.remote.MobileCapabilityType (just modified),
OpenQA.Selenium.Appium.Enums.AndroidMobileCapabilityType (android-specific capabilities),
OpenQA.Selenium.Appium.Enums.IOSMobileCapabilityType (iOS-specific capabilities).

Some existing capabilities were marked Obsolete and they are going to be removed at the next java client release:
    public sealed class MobileCapabilityType
    {
        [Obsolete("Moved to AndroidMobileCapabilityType.DeviceReadyTimeout and it is going to be removed from here")]
        public static readonly string DeviceReadyTimeout = "deviceReadyTimeout";

        [Obsolete("Moved to IOSMobileCapabilityType.LaunchTimeout and it is going to be removed from here")]
        public static readonly string LaunchTimeout = "launchTimeout";

        [Obsolete("Moved to AndroidMobileCapabilityType.AppPackage and it is going to be removed from here")]
        public static readonly string AppPackage = "appPackage";

        [Obsolete("Moved to AndroidMobileCapabilityType.AppActivity and it is going to be removed from here")]
        public static readonly string AppActivity = "appActivity";

        [Obsolete("Moved to AndroidMobileCapabilityType.AppWaitActivity and it is going to be removed from here")]
        public static readonly string AppWaitActivity = "appWaitActivity";

        [Obsolete("Moved to AndroidMobileCapabilityType.AppWaitPackage and it is going to be removed from here")]
        public static readonly string AppWaitPackage = "appWaitPackage";

        [Obsolete("Moved to AndroidMobileCapabilityType.SelendroidPort and it is going to be removed from here")]
        public static readonly string SelendroidPort = "selendroidPort";

    }

some server options were marked Obsolete because they are deprecated since server node v1.5.x. These flags are going to be removed at the next .Net client release:

    public sealed class GeneralOptionList
    {
        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> App(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> UIID(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> NoReset()

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> DeviceName(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> PlatformName(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> PlatformVersion(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> AutomationName(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> BrowserName(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> Language(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> Locale(string value)

        [Obsolete("This flag is deprecated because it is moved to AndroidOptionList.ChromeDriverPort(value)")]
        public static KeyValuePair<string, string> ChromeDriverPort(string value)

        [Obsolete("This flag is deprecated because it is moved to AndroidOptionList.ChromeDriverExecutable(value)")]
        public static KeyValuePair<string, string> ChromeDriverExecutable(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> CommandTimeOut(string value)
    }

   public sealed class AndroidOptionList
    {
        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> Package(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> Activity(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> AppWaitPackage(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> AppWaitActivity(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> AndroidCoverage(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> Avd(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> AvdArguments(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> DeviceReadyTimeout(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> UseKeyStore()

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> KeyStorePath(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> KeystorePassword(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> KeyAlias(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> KeyPassword(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> IntentAction(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> IntentCategory(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> IntentFlags(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> IntentArgumants(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> DoNotStopAppOnReset()
    }

    public sealed class IOSOptionList
    {
        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> LocalizableStringsDir(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> LaunchTimeout(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> UseNativeInstruments()

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> CalendarFormat(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> Orientation(string value)

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> ShowSimLog()

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> ShowIosLog()

        [Obsolete("This flag is obsolete since appium node 1.5.x. It will be removed in the next release. Be careful. Please use capabilities instead")]
        public static KeyValuePair<string, string> KeepKeychains()
    }

The ability to start Appium node programmatically using desired capabilities. This feature is compatible with Appium node server v >= 1.5.x.

It is the addition to usecases which have been provided here: #126. Now it is possible to do something like that:
DesiredCapabilities serverCapabilities = new DesiredCapabilities();
//the filling of server default capabilities is going below

DesiredCapabilities clientCapabilities = new DesiredCapabilities();
//the filling of server default capabilities is going below

OptionCollector argCollector = new OptionCollector().AddCapabilities(serverCapabilities);
AppiumServiceBuilder builder = new AppiumServiceBuilder().WithArguments(argCollector);
AppiumLocalService service = builder.WithArguments(args).Build();

then
AndroidDriver<AppiumWebElement> driver = new AndroidDriver<AppiumWebElement>
(service, clientCapabilities);

or
AndroidDriver<AppiumWebElement> driver = new AndroidDriver<AppiumWebElement>
(builder, clientCapabilities);

or
service.Start();
AndroidDriver<AppiumWebElement> driver = new AndroidDriver<AppiumWebElement>
(service.getUrl(), clientCapabilities);

@Astro03
Please take a look at this feature

looks clean man. you're so nice to inform everyone that the next release will remove all those :)


fix(#minor); Gamma Strategy; upgrade to 1.3.0 schema; RE PR 792

Context
Gamma Strategies schema version was at 1.2.1. The most recent version is 1.3.0 and we wanted to upgrade to this version.
Changes
Added totalPoolCounts to usage metrics and protocol entities. Required slight refactoring of the Vault getter.
Added cumulative revenues to the Vault entity.
Added cumulative, daily, and hourly revenues to the vault snapshots.
Added subgraph.yaml to gitignore

I'll take this one.

Nice work!


Use Immutable to manage mounted instances

Closed in favor of using a Set to manage instances. See: #16


Add help sidebar to the statistic page

Questions
Answers

Description?
Help sidebar was disabled on statistics page

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/27134.

How to test?
Go on statistic page in the BO and try to click on the help button

Hi @NeOMakinG,
It is ok :heavy_check_mark:
I checked with PS1782 and the develop branch

Thanks!

Thanks @NeOMakinG & @khouloudbelguith


Fix Fix the transaction is not removed in abnormal situations by removing transaction in finally block.

Proposed changes
Backport #36705.

run buildall


[REVIEW] CPU Dask-SQL q02 and q04

Can confirm both 2 and 4 return the correct results with GPU and CPU so this is ready for another round of reviews


How to get the demo working?

demo/index.html includes build.js
How to generate that?
Thanks

yarn dev in the demo folder should take care of it.
Check the scripts in package.json, both the library and the demo one 👍

On 26 Jul 2018, at 11:22 AM, Marius Andreiana<EMAIL_ADDRESS>wrote:
demo/index.html includes build.js
How to generate that?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


feat: limsup u ⊤ = ⨆ i, u i in a conditionally complete lattice

From LeanAPAP

Did you forget some aliases?

bors merge


issue #5915 fixed

Issue Reference
#5915

Translation added for notificatios

Hi @Anmol-Chauhan,
Please resolve conflicts.


After update with HA 0.89, Smartthings integration stopped working

Home Assistant release with the issue:
Home Assistant 0.89.0
Last working Home Assistant release (if known):
0.88.2
Operating environment (Hass.io/Docker/Windows/etc.):
Home Assistant, environment Python 3.5.3
Component/platform:

Description of problem:
In version 0.88, I have configured the smartthings integration. But after the update, integration has not stopped working. I tried to create smartapps again.
I created a new token.
I configured again Home Assistant, i entered the personal access token. I tried to add Smartapp in "My Apps", then choose ‘Home Assistant’. But again I get an error. I added screenshots.
Smartthings app doesn't work. An old app is writing: Something's Wrong. We can't load your screen right now. After I removed the smartapp from api.smartthings.com.
I rebooted the phone, deleted the application data and cache in the phone. Rebooted hub. But nothing helped. Home assistant does not create a Smart app in the API or in the classic Smartthings application.
In the previous version, everything worked. All conditions are met- base_url, SSL and so on.
I edded logger in congiguration file, but i don't know where to watch the logs. I did not find anything in the home-assistant.log.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

There was a breaking change introduced in 0.89 for SmartThings did you make sure to follow the steps outlined in the blog? https://www.home-assistant.io/blog/2019/03/06/release-89/#noteworthy-breaking-changes

I'm sure I did everything right.

I have generate a new token.
i have set up a new integration and сlicked the button ‘Configure’.
I have entered the token and click ‘Submit’
After, i have opened the SmartThings Classic mobile app.
But the Home Assistant application did not appear in it.
Old ones remained, but new applications did not appear.
I have a feeling that the Smartthings component is not workin

I am seeing the same behavior as well with the 0.89 hassio instance.  Smarthings integration was working with previous version.
I tried everything from regenerating the token.. but still getting the "something is wrong" sort of message when using the home assistant smartapp

It started working now all of a sudden... not sure if it just needs time.. !!! i restarted hass and then tried the same sequence as before, and now it connected successfully.

Depending on where you are on the ST cloud a few people noticed theres a lag in when the old app is removed and to when the recreated one shows up.  There have also been ST availability issues today which probably hasn’t helped.
One note to others, there’s no beed to create a new token, you can use the previous one.
If it coubtines to not work, it’s possible the webhook wasn’t entirely working before (like certain messages getting blocked, which weren’t required before but are now).  Let me know and I’m happy to help you troubleshoot.

I am also having trouble with this. It was working in 88.2, I tried generating a new token, I've restarted HASS at least 100 times. I also tried reverting back, that did not work. I tried using the troubleshooting steps in Smartthings component page but I have no idea how to access the NGINX configuration file. I'm using Hass.io if that make a difference.

Unfortunately, I deleted the old token and cannot use it.

For folks still having issues try this:

Use this utility to complete remove all HASS automations/apps.  It will output the IDs of the items removed.  If it outputs nothing, there was nothing to remove.
Ensure you do not see any HASS apps or automations in the ST Classic App.  If you still see items in your account after running the utility, you are affected by cached data/synchronization lag.  Wait until the items no longer show up.
Start the integration setup in Home Assistant.  If you don't see the SmartApp to install, then you're affected by synchronization lag again.  Wait until it shows up.  It's OK to exit out of the integration setup meanwhile, just go back into it BEFORE trying to add the SmartApp to your account.

The Home Assistant integration setup logic didn't change in this release (it just captures more data than before).  As I mentioned earlier, there's been AWS issues today that affected SmartThings which is likely contributing to the synchronization lag.

Slightly off topic but new and struggling to find stuff.  When do you expect to get the Axis function working on the Smartthings open/close sensors ?

@hunterdiver please open a seperate issue and specify the device brand and model you have and what you’re looking to be able to do.  If you’re using a custom Device Type Handler to control it in SmartThibgs, please include the link to the source.

I executed the command -
pi@raspberrypi:~ $ sudo hass_smartthings_remove PERSONAL_ACCESS_TOKEN
Traceback (most recent call last):
File "/usr/local/bin/hass_smartthings_remove", line 10, in
sys.exit(main())
File "/usr/local/lib/python3.5/dist-packages/hass_smartthings_remove/remove.py", line 16, in main
loop.run_until_complete(remove_apps(args.token))
File "/usr/lib/python3.5/asyncio/base_events.py", line 466, in run_until_complete
return future.result()
File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
raise self._exception
File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
result = coro.send(None)
File "/usr/local/lib/python3.5/dist-packages/hass_smartthings_remove/remove.py", line 25, in remove_apps
apps = await api.apps()
File "/usr/local/lib/python3.5/dist-packages/pysmartthings/smartthings.py", line 89, in apps
resp = await self._service.get_apps(params)
File "/usr/local/lib/python3.5/dist-packages/pysmartthings/api.py", line 156, in get_apps
return await self.get_items(API_APPS, params=params)
File "/usr/local/lib/python3.5/dist-packages/pysmartthings/api.py", line 375, in get_items
'get', self._api_base + resource, params, None)
File "/usr/local/lib/python3.5/dist-packages/pysmartthings/api.py", line 366, in request
resp.raise_for_status()
File "/usr/local/lib/python3.5/dist-packages/aiohttp/client_reqrep.py", line 942, in raise_for_status
headers=self.headers)
aiohttp.client_exceptions.ClientResponseError: 401, message='Unauthorized'

@andrewsayre OK will do but it is the Samsung open/close device

Should I re-run the Configure Smartthings?
In Smartthings, nothing has changed.
All  Home Assistant Smartapps in place. I closed and opened the Smartthings app.

@oleg-78 You have to replace PERSONAL_ACCESS_TOKEN with your access token...

Everything worked out.
Old SmartApp have been removed from Smartthings. And without any problems everything was integrated.
Thank you so much for your help and patience. You saved me a lot of time.


Unfurl Redirects

Closes #1933.

[x] Blocked by python-discord/workers#20.
[x] Blocked by python-discord/site#625.

Description
This PR implements the URL unfurling filter feature described in #1933. It adds a service to do so, the filtering logic, and a command. To prevent the filtering logic from being slow, and to handle the fact that this filter calls another filter, I've had to make modifications to the core filtering logic to allow for delayed processing and modified the alert logic to allow customization of the output.
I've also kaizened in a small change to remove http and https from URLs when being added to the filter lists, after a brief discussion in mod-meta.
See the next comment for the output of the command.

Success

Too many redirects

Long URL

Unhandled Error (on the worker end, logs a warning)

I believe I've addressed all comments on Tizzy's review, but I can probably clean the commit history before merging.

@onerandomusername Perhaps, though that would require changes to the worker itself. It's also not the goal of this PR at the moment, since the shadysites is only a concern for moderators as far as this command is concerned, but we don't care for moderation purposes.

While testing this I can't get the auto-filtering to work..

Add YouTube with b!blacklist add domain_name https://youtube.com/
Log in with my alt and paste https://tinyurl.com/materialgworlbustdown which redirects to YouTube.
Nothing happens even though the domain is blacklisted?

@TizzySaurus did you add tinyurl to the unfurl filter list?

I'm working on reviewing this. Might take me a couple of review sessions.

This PR is incompatible with #1889, and will likely require conscious review before merging main. Whichever PR is merged second will need to make those changes.

@HassanAbouelela good to know, I'll keep that in mind should mine be merged after.

I've asked Xith to remove me from this issue and put it up for grabs, but an important note for whoever merges this:
The change to the insert/delete command will make any URLs in prod inaccessible if they have https in the name. I've already deleted a majority of the ones that existed at the time, but before you merge, it's a good idea to go through and clean up any that have been added since.

According to a vote we held with the mods, the alert should always ping if the unfurl fails, but otherwise ping only if the destination is blacklisted.

According to a vote we held with the mods, the alert should always ping if the unfurl fails, but otherwise ping only if the destination is blacklisted.

Cool, that means I won't need to do anything since it's current behaviour :D

I've been request for review but I do not think all my previous comments have been addressed.

I've been requested for review, but I do not think all my previous comments have been addressed.

You're right, this isn't quite ready for review just yet. It's on my list for after the d.py bump in bot-core and bot.

Given https://github.com/python-discord/bot/pull/2390, implementation of the new filtering list won't be addressed in this PR (relevant code needs to be removed) and will wait until after the mentioned PR is merged. This PR will focus on the unfurling mechanic itself, and is up for grabs.

Bumping this PR, #2390 has been merged.

This PR has been open for around 2 years. Doesn't seem to be needed at the moment to continue, so I'll close this, at least for now.


I have a question about my collection

I can get au information about my collection with box python sdk.
my_collection = client.collection(collection_id="1234567890").get().
But with box-python-sdk-gen, I only can get the favorites collection with,
collections = client.collections.get_collections().
So I can't get the name of my collection by id like old python sdk.
Do you have any way to get my collection information like file or folder,
client.folders.get_folder_by_id(folder_id) ?
Thanks for any advises.
Versions Used
Python SDK: 1.5.1
Python: 3.10.12

It seems that this endpoint is not documented in the specification, and most SDK code (including most endpoints) is generated based on it. We will inform the owners of the specification about this problem.

Hi @c-rei,
we have added support for the required endpoint. It will be soon available in v.1.7.0 release.
Best,
@lukaszsocha2

Hi @lukaszsocha2,
Thanks for your support, I'll try it, and let you known the result.

I've tried this "client.collections.get_collection_by_id(collection_id)" with version 1.7.0, and I got the informations for personal type collection.
Thank you very much.
Best.


@angular-devkit/schematics: error

Hi,
I just installed angular/cli 1.7.4 when I run the command
ng g c test --module app
I got the following error
Cannot find module '@angular-devkit/schematics'
Error: Cannot find module '@angular-devkit/schematics'

When I run ng -v I got the following
@angular/cli: 1.7.4
@angular-devkit/build-optimizer: error
@angular-devkit/core: 0.5.4
@angular-devkit/schematics: error

Versions
1.7.4
Repro steps
Run ng -v
or Run ng g c test --module app
Observed behavior
Errors with @angular-devkit/schematics
Nothing happened
Desired behavior
Generate new component
Mention any other details that might be useful (optional)

@jimmy-khalifa I think the error is accurate: you don't seem to have the packages installed. Something probably went wrong during installation.
Please try to remove your node_modules, package-lock.json and reinstalling dependencies via npm install.

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.

I have this issue with Angular 6.2.3
Angular CLI: 6.2.3
Node: 10.10.0
OS: win32 x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.8.3
@angular-devkit/core         0.8.3
@angular-devkit/schematics   0.8.3
@schematics/angular          0.8.3
@schematics/update           0.8.3
rxjs                         6.2.2
typescript                   2.9.2

Reverting to angular 6.1.1 fixed the issue.

@alan-agius4  does this information suffice?

Same issue.
`Angular CLI: 6.2.5
Node: 8.12.0
OS: darwin x64
Angular: 6.0.7
... animations, common, core, forms, http, language-service
... platform-browser, platform-browser-dynamic, platform-server
... router
Package                           Version
@angular-devkit/architect         0.8.3
@angular-devkit/build-angular     0.8.3
@angular-devkit/build-optimizer   0.8.3
@angular-devkit/build-webpack     0.8.3
@angular-devkit/core              0.8.5
@angular-devkit/schematics        0.8.5
@angular/cli                      6.2.5
@angular/compiler                 6.1.10
@angular/compiler-cli             6.1.10
@ngtools/webpack                  6.2.3
@schematics/angular               0.8.5
@schematics/update                0.8.5
rxjs                              6.3.3
typescript                        2.7.2
webpack                           4.20.2`
I run command ng generate store State --root --statePath store/reducers --module app.module.ts
And get the follwoing
Cannot find module '@angular-devkit/schematics' Error: Cannot find module '@angular-devkit/schematics'     at Function.Module._resolveFilename (module.js:548:15)     at Function.Module._load (module.js:475:25)     at Module.require (module.js:597:17)     at require (internal/module.js:11:18)     at /Users/champton/git/sp/sp-system-checkout/node_modules/@ngrx/schematics/src/store/index.js:50:24     at Object.defineProperty.value (/Users/champton/git/sp/sp-system-checkout/node_modules/@ngrx/schematics/src/store/index.js:41:17)     at Object.<anonymous> (/Users/champton/git/sp/sp-system-checkout/node_modules/@ngrx/schematics/src/store/index.js:47:3)     at Module._compile (module.js:653:30)     at Object.Module._extensions..js (module.js:664:10)     at Module.load (module.js:566:32)


extract_ir_lengths: handle 101x IR scans

Some devices return 10100 during JTAG IR scan. Previously, the n_taps == 1 case was supposed to handle these, but the ESP32-P4 will have two JTAG TAPs, and the IR scan is<PHONE_NUMBER>. This PR essentially special-cases the 101 prefix to support such devices.

This is standing on somewhat weak foundations I guess. This shouldn't break existing devices, but allow handling more, although it will probably also result in false positives the way it is. (in case some device scans out 10010 for the first TAP - if that's even possible)


fix: resolve @types/react@18 break change, React.FC

Description

In @types/react@18 children was removed from FC type.
I get type errors in createReducerContext, createStateContext
Changes of this PR are compatible with 17 and 18 typings versions.
Detail in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/56210
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

:tada: This PR is included in version 17.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update develop-tools.md

add remix online IDE URL

sure, I will add more content in this pr

sure, I will add more content in this pr

Thanks for your contribution, you can also fix our English readme.

I will close it and send another pr.


Fix a false positive for Style/RedundantReturn when a rescue has an else clause

Closes #8767

Thanks!


AttributeError

Logger: homeassistant.config_entries
Source: custom_components/tesla/init.py:155
First occurred: 10:45:30 AM (1 occurrences)
Last logged: 10:45:30 AM
Error setting up entry<EMAIL_ADDRESS>for tesla
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 239, in async_setup
result = await component.async_setup_entry(hass, self)  # type: ignore
File "/config/custom_components/tesla/init.py", line 155, in async_setup_entry
await coordinator.async_config_entry_first_refresh()
AttributeError: 'TeslaDataUpdateCoordinator' object has no attribute 'async_config_entry_first_refresh'

You'll need to be on 2021.4.0 or above unfortunately. https://github.com/home-assistant/core/releases/tag/2021.4.0
I'll add it in as a minimum requirement.


Update dead README URL to hexy time

Hi @ninest, I noticed that the readme needs an updated app url to https://hexytime.now.sh/ so figured this would be the best way to reach out. Very cool project btw

Thank you so much for letting me know! I've fixed it


🚀[FEA]: Have better instructions for installing from source

Is this a new feature, an improvement, or a change to existing functionality?
Improvement
How would you describe the priority of this feature request
Medium
Please provide a clear description of problem you would like to solve.
The Modulus build currently require a lot of dependencies that are not currently fully supported via pip. The alternative to this is a Dockerfile, but this does not help the users who cannot use Docker due to other restrictions. While the Modulus pip experienece is being continuously improved, it would be good to have a robust source build instructions that mimic the same behavior as docker if built from source. This can include adding the dependencies unsupported via pip etc. as a submodule in the thirdparty folder (similar to a few other projects like https://github.com/pytorch/pytorch/tree/main/third_party )
Describe any alternatives you have considered
No response

Docs and also readme have additional details now, so I think this can be closed


Export froms

In this spirit of #3374, if we're exporting fromPromise, we should export these as well.
HOWEVER: I still find the "smallness" of fromPromise to be dubious, as things like defer, switchMap, concatMap, mergeMap, exhaustMap, forkJoin, etc, all pull in the majority of from's logic.
cc @IgorMinar @jasonaden @kwonoj
... this is, of course, at the expense of more API surface area.

Coverage increased (+0.001%) to 97.518% when pulling 6c759dee70ec0881ddea0d2a4743f014da81fa1b on benlesh:export-froms into 1e4ca05ab247eedc3d7db233874e650439f09fbd on ReactiveX:master.

After further discussion, this should be closed and the fromPromise fix (#3375) should be reverted.


what is require('../../src/middleware') meant to reference?

I am using Fastify.
In the docs you have
const inputValidation = require('../../src/middleware');
I don't understand what this is?

This is a typo in the docs.
../../src/middleware should be openapi-validator-middleware

Thanks for the quick reply.
It's also not that clear to me what is meant by "Fastify support requires uri-js dependency". Does that mean I just need to npm install uri-js, or do I also need to import it? No import statement is included in the example code. It's not a dependency that I've used before.

@o-t-w Thanks, fixed that in the PR as well.


initial benchmarking of building and compiling models and MCMCs

This PR adds inst.test-benchmark-building-steps.R.
It benchmarks the steps of:

building model (with check = FALSE and calculate = FALSE in first cases)
compiling model
configuring MCMC
configuring MCMC without conjugate
building MCMC (not allowing conjugacy, in the initial cases)
compiling MCMC

It outputs a table with a row for each case and a column for the time used by each step.
Currently there are two cases:

a model with 1 top-level parameter, 1000 random effects, and 1000 data (each depending on 1 random effect).

a model with 1 top level parameter, 100 random effects, and 2000 data (20 data depending on each random effect).

This is in the testing directory but is not needed as a test, so it is on the omission list of run-tests.R
It will be easy to expand to other cases and consideration of check = TRUE, calculate = TRUE, and use of conjugacy.

If you exclude this from the test suite, it will eventually break. If you're worried about tests taking too long, you can e.g. parameterize them with an environment variable that defaults to something small, or you can use small numbers based on Sys.getenv('CI').

BTW the reason I turned off the "test" was that it is not intended to test a feature.  Instead it is a benchmark that uses basic features that should be probed by other tests.  However I get your point and followed your suggestion and parameterized it (directly in the test file) to be always on but small during routine use.  When working on features to be evaluated by the benchmarks, larger parameters (sizes of model variables) can be used.
Also I messed up the branch flow for this PR.  A subsequent PR that received 👍 included the changes in this PR and hence have been merged already, a few moments ago.  I will close this PR and make a new PR to turn the "test" on and parameterize it to be small in routine use.


need files of structures to activate abap2xlsx : TT_ALV_TYPES ...

Hi and thanks,
could you provide me the structure of those types please:
class-data WT_OBJECTS type TT_ALV_TYPES .
data WT_SORT_VALUES type TT_SORT_VALUES .
data WT_SUBTOTAL_ROWS type TT_SUBTOTAL_ROWS .
data WT_STYLES type TT_STYLES .

first one: https://github.com/sapmentors/abap2xlsx/search?q=TT_ALV_TYPES

but fields are inside of those structures?

oh sorry - now I got it

@dorenthe can the issue be closed?

yes thank you!


add var so that it is smartapi v3 compatible

add OPENAPI_SERVER_URL=icees.renci.org so that the json provides servers

FYI, OPENAPI_SERVER_URL has to be modified for each instance. This will add a servers block to the OpenAPI schema, but it won't work unless it's actually the right URL.

yeah, this is just an example, like other env vars that are already there which needs to be modified for instances.

yeah, this is just an example, like other environment variables that are already there which need to be modified for other instances.


'Cancel' operation works weird in Preferences

In the Proferences,
I checked an option under Preview.
And I clicked 'Cancel'.
But if I open Preference dialog again,
the option I checked (but cancelled without applying) remains checked.
(Really, the option is not applied in run-time)
Please check.
It was originally reported by @yoonhyung.

@cimfalab @yoonhyung I'll check it.Thanks.


[ENH] Add pushed based operators, centralized dispatch, hardcode query plan as state machine

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

#1888  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on  Graphite

@Ishiihara this is draft, not ready for review yet. will ping you once i've cleaned it up


solved empty cart feedback

issue
closes: #6
This PR does:

When the cart is empty they should receive a clear and informative message indicating that their "cart is empty".
A navigation button for exploring the app.

Looks good

Looks good


SSR Issues with ConnectedRouter and server-side Redux.

Version
react-router 4.1.2
react-router-redux next
Steps to reproduce
Set up SSR using ConnectedRouter to reflect state in the store.
    if (!Object.keys(cachedRoutes).includes(ctx.path)) {
      debug.log('We are going to do full SSR, here...')

      const { store, client, history } = await configureRedux(ctx)

      const context = {}
      const component = (
        <ApolloProvider store={store} client={client}>
          <ConnectedRouter location={ctx.path} history={history}>
            <ActionContainer />
          </ConnectedRouter>
        </ApolloProvider>
      )

      try {
        const root = await renderToStringWithData(component)
        const apolloState = client.store.getState()['apollo'].data
        const reduxState = store.getState()
        const html = <Html assets={assets} root={root} apolloState={apolloState} reduxState={reduxState} />
        cachedRoutes[ctx.path] = `<!DOCTYPE html>\n${ReactDOM.renderToStaticMarkup(html)}`
      }
      catch(e) {
        debug.error('RENDERING ERROR:', e)
        ctx.status = 500
        return
      }
    }
    ctx.status = 200
    ctx.body = cachedRoutes[ctx.path]

Expected Behavior
After rendering the root, root should contain the appropriate route, which it doesn't, and store.getStore()['router'] should contain a location object with the correct information, which it doesn't.
Actual Behavior
The wrong path is being rendered and reported mismatch on client:

And above you can see that the location object is indeed populated with information, but the issue is that this is the wrong path. In this instance, the path is:

Additional Notes
I have tried using StaticRouter, but this is not rendering the markup correctly and of course does not update the store.
For instance, with StaticRouter, I am getting these SSR errors client side:

Also, the context is not being updated with any information--is this up to components? This would put a heavy burden on the developer to essentially support two instances, where it seems to me that ConnectedRouter being used with createMemoryHistory(ctx.url) and server-side redux should suffice, no?

Woot, woot! I got it to work! I needed to add the following to the createMemoryHistory(...) call:
const memoryHistory = createMemoryHistory({
  initialEntries: [ctx.path],
})

Et voilà!! No more SSR issue with ConnectedRouter and state are correctly handled.

@Panoplos  I am faing some weird problem with react-router-redux and SSR
Turns out that the SSR seems to be working but on the client the rendering fails
client.js
import 'babel-polyfill';
import React from 'react';
import { render } from 'react-dom';
import { Provider } from 'react-redux';
import { Route, Switch } from 'react-router-dom';
import { ConnectedRouter } from 'react-router-redux';
import _ from 'lodash';
import createHistory from 'history/createBrowserHistory';
import routes from './routes';
import configureStore from './store';
import './styles/style.css';

const element = document.getElementById('app-container');

const initState = window.__PRELOADED_STATE__;
const history = createHistory();
const store = configureStore(history, initState);

render(
  <Provider store={store}>
    <ConnectedRouter history={history}>
      <Switch>{routes.map(route => <Route key={_.uniqueId()} exact={route.exact || false} path={route.path} render={props => (<route.component {...props} routes={route.routes || null} />)} />)}</Switch>
    </ConnectedRouter>
  </Provider>,
  element,
);

store.js
import { routerMiddleware } from 'react-router-redux';
import thunk from 'redux-thunk';
import { createStore, compose, applyMiddleware } from 'redux';
import rootReducer from './reducers';

const composeEnhancers = process.env.NODE_ENV !== 'production' && typeof window !== 'undefined' && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ ? window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ : compose;

export default (history, initState) => {
  const store = createStore(
    rootReducer,
    initState,
    composeEnhancers(applyMiddleware(thunk, routerMiddleware(history))),
  );

  return store;
};

@rahulbasu710 Not sure I can help you, as I am using ApolloProvider, not react-redux's Provider.

Not a problem. Thanks

I was having the same problem.  yarn add react-router-redux@next did the trick


Soft navigation detection

My site primarily uses soft navigation links, and those don't seem to trigger a request as far as Debugbar is concerned. Is there a way to still use this tool?

If I understand correctly, you have an SPA in the frontend and changing pages doesn't trigger any call to the backend. The debugbar will only see request made to the backend. For anything happening in React, Vue and such, you would need a dedicated too.
Let me know if I misunderstood something.

I'm using Rails 7 and <%= link_to %> links mostly, but maybe I have some kind of config or setting turned on that makes everything a soft navigation?

All Ajax/spa requests will still get logged. Can confirm that it works with Inertia.js and Vue.
Could you open a browser dev tools network tab and see if there is a new request when you navigate? It may also be that you have caching preventing the request from firing.


Contribute to OOP's Python

Create classes explaining different concepts of OOP's Python in OOP's folder.

Create a class with the name of book. And these are their codes. OOP programming.zip

Hey Umakshi, you can fork this repository and add your contributions, and then raise PR's.

Hi, I can take on this issue if you assign it to me, thank you!

Hi, I can take on this issue if you assign it to me, thank you!

Sure


⚠ Bofrost.lu has degraded performance

In 1e9bd16, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1570 ms

Resolved: Bofrost.lu performance has improved in df65134.


Update all LTS libraries

Description
Update all LTS libraries to point to the latest LTS release.

FreeRTOS-Kernel V11.1.0
FreeRTOS-Plus-TCP V4.2.1
coreMQTT v2.3.0
coreHTTP v3.1.1
corePKCS11 v3.6.1
coreJSON v3.3.0
coreSNTP v1.3.1
Cellular Interface v1.4.0
SigV4 v1.3.0
backoffAlgorithm v1.4.1
AWS IoT Device Shadow v1.4.1
AWS IoT Device Defender v1.4.0
AWS IoT Jobs v1.5.1
AWS IoT Fleet Provisioning v1.2.1

Test Steps

Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Issue with tip of main as some UTs are fixed in kernel and kernel submodule pointer has been moved which is not LTS release version, hence moving before these commits.


Remove version: Datadog.Agent version 7.59.0-rc.1

This is a beta version
Microsoft Reviewers: Open in CodeFlow

URL: https://s3.amazonaws.com/dd-agent-mstesting/builds/beta/ddagent-cli-7.59.0-rc.1.msi
OK
(Automated message - build 923)

Hi @PckgrBot,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 897.)

[Policy] Needs-Attention

[Policy] Needs-Manual-Merge

Hi @PckgrBot,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 897.)

Hi @PckgrBot,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 897.)

It is the beta release of the application


add upgrade unit test

add unit test in service/src/upgrade.rs
Details
add function test_failover_policy to test FailoverPolicy::try_from
Types of changes
What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Go over all the following points, and put an x in all the boxes that apply.

[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.

Also please remove the unnecessary commits.

@hijackthe2 Let's remove the unnecessary commits and merge it, thanks!


fix tutorial.md

fix quickstart link error

Codecov Report

Merging #342 (7af6dd1) into main (48f0352) will decrease coverage by 0.12%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   92.38%   92.26%   -0.12%
==========================================
  Files          30       30
  Lines        1445     1423      -22
==========================================
- Hits         1335     1313      -22
  Misses        110      110

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks!


Prevent negative values in Goto Line

This should fix https://github.com/google/xi-editor/issues/531

LGTM


please add get-last_activity_on in user-api

please add get-last_activity_on in user-api
"last_activity_on": "2012-05-23",

The last_activity_on and shared_runners_minutes_limit fields have been added to User.  Release 4.3.5 has been pushed to the Maven repositories.


Add Steps component to cleavr.mdx

Add Steps component to cleavr.mdx
Adds the Step component where needed.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/deploy/cleavr.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

!coauthor


SUBMARINE-1152. Submarine UI support i18n

What is this PR for?
UI support translation by @ngx-translate/core
What type of PR is it?
Feature
Todos

[x] - Add @ngx-translate/core lib
[x] - Translate Experiment page

What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1152
How should this be tested?
See Screenshot
Screenshots (if appropriate)
https://user-images.githubusercontent.com/12069428/201573071-bcf2d4f5-7e79-4fef-a9ad-7dd695697f13.mov
Questions:

Do the license files need updating? No
Are there breaking changes for older versions? Yes
Does this need new documentation? No

@pingsutw
Hi~ There are a few changes that depend on this PR, so I've gone ahead with the merge for now.


What license is this code under?

Hello.
I found this project via a link in your blog post (https://blog.tonari.no/rust-simple-hardware-project). Thank you for sharing your work.
I'm currently working on a refactor of the serial port protocol code for a project that I'm working on with my housemate (https://github.com/hoverkite/hoverkite/issues/5). I noticed that our current wire format is very similar to yours, but your code structure is much cleaner than ours.
I think it would be good to share ideas between our projects. GitHub recommends adding a license to your repository, to make this easier.
If you haven't decided on a license, I can recommend the Apache 2 + MIT scheme that the Rust compiler uses. A patch to add this license would look similar to this: https://github.com/hoverkite/hoverkite/commit/01fb3f7ab8d1eca9be7df2d5481eb69a03281158 . I can make a pull-request to do this if you would like.
David.

Hi @alsuren ! Thanks for the reminder, I'm still not in the habit of attaching licenses to my new projects. I typically use the MIT license, I hope that works for your project.
#17


feat: expose tags vars

Description
Add support for attaching tags to security groups.
(https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_security_group#tags)
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Add support for attaching tags to security groups.
(https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_security_group#tags)
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

Can add "access_tags" for the example and tests?

/run pipeline

/run pipeline

/run pipeline

/run pipeline

Doesn't destroy existing resource by adding tags

/run pipeline

:tada: This PR is included in version 2.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create Kunai private NPM package

Merged without approval since it's just initial configuration to set up a private Kunai NPM package in the Github Packages NPM registry.


process killed by computer

Hello, when I run the command
./tools/dist_train.sh configs/softgroup_scannet.yaml 1
I met the following problem: my process got killed by my computer after running several epochs.

I searched for the issue, and found it was caused by oom.
I was using the single 3090 GPU, and set batchsize=4, num_workers=4, and I think it shouldd't cause out of memory, noting that it can run some epochs.
Do u konw why and how to deal with the issue?
Hoping for your reply, many thanks!

I am not very sure. Could you check with --skip-validation flag. You can also resume training with --resume

Thank you for your advice. But I have no intention of training and want to test on point cloud data.

@wsk12345  which dataset are you using

@thangvubk Thank you for your prompt reply. I am using a custom dataset. A single scene has about 5e6 points.

I ran into "illegal memory access error", it was caused by the radius being too large for the dataset I was training on, it may also have the same effect while testing

If you have memory errors with custom datasets, i suggest checking the input spatial_shape. Spconv2 may not support the input with too large spatial shapes (e.g., 3000x3000x1000).

I am getting the OOM error while testing for S3DIS dataset on a single RTX6000.


Update and not add

For issue #8
Changed:
When we want to add a group, if there exists CourseGroup with the same (CourseOccurence, class_type, mark), this group will be updated and wont be added along side.
For the classes: those who didn't changed will not be changed, those who don't exist in the db will be added, and those who exist and not to be added - they are irrelevant and will be deleted.

all of your comments were resolved

@matanel-oren Something here has changed, and now the test test_simple_base_models fails. It receives 13 classes instead of 14 classes. Can you check it out?

Yes, it's not a bug, it's a feature.. It's related to the "מועדים מיוחדים" issue . Until we refer that issue, this is the expected behavior. Is't because two classes have the same day and hour (and not the date), hence for us they are the same. See course 96203, 4th and 10th classes. Actually if this test was pass it was a bug.
I hope I will have time next week to try adding the handling of "מועדים מיוחדים" cases.

I just added מועדים מיוחדים, and it passes. Nice catch.

Because it assigned to them a different teachers, and this PR do exactly this - doesn't let you add the same class with different teacher as different classes.