Terminal is sometimes blurry, even when window.zoomLevel is 0

We have written the needed data into your clipboard because it was too large to send. Please paste.

/needsMoreInfo
Please provide a screenshot that illustrates the problem.

This is occurring for me too, here are screenshots comparing the output window to the terminal window, note the terminal version is blurry. the images are not inline as github does some scaling on image:
Clear Output: https://user-images.githubusercontent.com/50384876/69197798-a3cf0c80-0b86-11ea-8e3d-a80bebfcf1bb.png
Blurry Terminal: https://user-images.githubusercontent.com/50384876/69197799-a7629380-0b86-11ea-9a5c-3ed0228f87d3.png

@tick-rick has some great examples attached, I can attach some more if these were not enough.

Do you set window.zoomLevel?

Here is a screenshot of my terminal, It does seem to be getting worse the closer to the center of the screen it gets. The zoom level is set to 1.

I had my zoomlevel set to -1, it seems setting it to 0 fixes the blurryness, very odd.

This is expected, we can't guarantee non-blurriness in this case because there's a 1-off rounding error that I don't think is specced out as browser zoom is not a web platform feature.

Since it seems all other issues are being closed as a duplicate of this one, I will put my comment here. On VSCode 1.50.1 on Linux, this is happening at window.zoomLevel = 0 but not at window.zoomLevel = -1 though the latter makes everything a little too small. Switching to the dom renderer also resolves the issue but in my opinion the defaults should work and I shouldn't have to override them.

I confirm the issue about the terminal font being blurry at the middle of the line at 1920x1080 resolution. Below some window size the blurriness disappears.
Zoom level 0, font Cascadia Mono or Consolas.

Thought it was worth mentioning I'm also seeing the same thing. Both the canvas and experimentalWebgl renderers produce blurry text in the terminal.

config.json
{
    "editor.fontSize": 20,
    "editor.fontFamily": "Fira Code Retina, Consolas, 'Courier New', monospace",
    "editor.cursorBlinking": "smooth",
    "editor.fontLigatures": true,
    "workbench.iconTheme": "Monokai Pro Icons",
    "workbench.colorTheme": "Monokai Pro",
    "files.insertFinalNewline": true,
    "workbench.editor.enablePreview": false,
    "workbench.editor.closeEmptyGroups": false,
    "terminal.integrated.shellArgs.linux": [
        "-l"
    ],
    "terminal.integrated.rendererType": "dom"
}

Reproduces on latest VS Code for Windows.

This still looks like the xterm.js issue which I got mixed reports about being fixed. The left-most side of @uhthomas's screenshot shows correct rendering:

While moving to the right blurs it still:

Will reopen but still not sure how to fix.

My Conclusion:
(1) add "window.zoomLevel":-1 in setting.json.
(2) multiply every fontsize terms in setting.json by the zoom level of your Windows 10. (Get it at Start > Windows Setting > Display > Scale and Layout).

It seems that we have to disable vscode applying zoom setting of Windows 10 and set font size by ourselves. json file should look like this:
{     "workbench.colorTheme": "Github Light Theme - Gray",     "remote.SSH.remotePlatform": {         "Lab": "linux",         "Lab_Root": "linux"     },     "workbench.editorAssociations": [         {             "viewType": "jupyter-notebook",             "filenamePattern": "*.ipynb"         }     ],     "python.insidersChannel": "daily",     "python.languageServer": "Pylance",     "editor.codeLensFontFamily": "Hack",     "editor.fontFamily": "Hack, 'Courier New', monospace",     "editor.fontSize": 20,     "editor.inlineHints.fontFamily": "Hack, 'Courier New', monospace",     "scm.inputFontFamily": "Hack",     "scm.inputFontSize": 15,     "debug.console.fontSize": 20,     "markdown.preview.fontSize": 20,     "markdown.preview.fontFamily": "Hack, -apple-system, BlinkMacSystemFont, 'Segoe WPC', 'Segoe UI', system-ui, 'Ubuntu', 'Droid Sans', sans-serif",     "terminal.integrated.fontSize": 20,     "terminal.integrated.shell.windows": "${env:windir}\\System32\\cmd.exe",     "terminal.integrated.profiles.windows": {         "PowerShell": {             "path": "C:\\ProgramFiles\\PowerShell\\7\\pwsh.exe",             "icon": "terminal-powershell",             "args": ["-nologo"]         },         "Command Prompt": {             "path": [                 "${env:windir}\\Sysnative\\cmd.exe",                 "${env:windir}\\System32\\cmd.exe"             ],             "args": ["-nologo"],             "icon": "terminal-cmd"         },         "mingw64": {             "path": [                 "C:\\ProgramFiles\\Git\\bin\\bash.exe",                 "C:\\ProgramFiles\\Git\\bin\\sh.exe",                 "C:\\ProgramFiles\\Git\\usr\\bin\\sh.exe"             ],             "args": ["--login"]         }     },     "markdown-preview-enhanced.automaticallyShowPreviewOfMarkdownBeingEdited": true,     "editor.suggestSelection": "first",     "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",     "terminal.integrated.fontFamily": "Hack",     **"window.zoomLevel":-1** }
I got a 2K screen and scale setting in Windows 10 is:

Previously I changed every "14" fontsize to "16"  in VScode to display better, but it's blurry as others.
Then I add "window.zoomLevel":-1 to setting.json file, and changed "16" fontsize to 16*1.25=20, and it works now.

That's an interesting observation.
For the record, though, I am not using any scaling options on this display.
However I am using scaling on a secondary display. It's 3840x2160, scaled to 150% in Windows 10.

Resolved the problem on Linux by setting
"terminal.integrated.gpuAcceleration": "off"
No more blurriness no matter the fontsize or zoom level.

Resolved the problem on Linux by setting
"terminal.integrated.gpuAcceleration": "off"
No more blurriness no matter the fontsize or zoom level.

This worked for me on Debian 10.8. ymmw

Resolved the problem on Linux by setting
"terminal.integrated.gpuAcceleration": "off"
No more blurriness no matter the fontsize or zoom level.

worked for me also in linux mint 20

Resolved the problem on Linux by setting
"terminal.integrated.gpuAcceleration": "off"
No more blurriness no matter the fontsize or zoom level.

This worked for me on windows too. Zoom level is 0.

No need to keep repeating the same thing; "terminal.integrated.gpuAcceleration": "off" will remove the blurriness on any platform as the blurriness is exclusive to rendering via canvas.

Well, disabling the gpuAcceleration then results in the other bug which is annoying. No more underscores :sweat_smile: Now one has to decide, blurry text vs. underscores!

@realvictorprm cannot reproduce on recent VSC on Win8.1 with remote connect to Linux; underscores are rendered correctly. May depend on the fonts used?

No need to keep repeating the same thing:
"terminal.integrated.gpuAcceleration": "off" will remove the blurriness on any platform as the blurriness is exclusive to rendering via canvas.

Thank you!

"terminal.integrated.gpuAcceleration": "off" however fixes the blurryness for me.

That worked for me too +++
Linux Mint if it's matter

Addendum: While - like I posted above - "terminal.integrated.gpuAcceleration": "off" indeed fixes the blurryness, it induces another problem (unsurprisingly): the terminal becomes unbearably slow.
So working without GPU acceleration is not an option, apparently. The blurryness is really bugging me, though. What can we do about it? I am totally willing to help fixing this. Is anybody working on it atm?

@carlfriedrich no one's working on it, the action item here is to reproduce the problem in the xterm.js demo and investigate a fix.
Here's the upstream issue tracking the general problem of blurriness (with or without zoom level) https://github.com/xtermjs/xterm.js/issues/2662.
I suspect this is the relevant code:

Canvas renderer: https://github.com/xtermjs/xterm.js/blob/6c18b7f2cc91b923e765b03e572f9038e294d368/src/browser/renderer/Renderer.ts#L199-L213
Webgl renderer: https://github.com/xtermjs/xterm.js/blob/6c18b7f2cc91b923e765b03e572f9038e294d368/addons/xterm-addon-webgl/src/WebglRenderer.ts#L459-L481

@Tyriar thanks for the quick reply. I will try to reproduce the behavior with xterm.js.
In a quick direct comparison in VS Code between GPU and non-GPU rendering, I noticed that the font looks a bit condensed when GPU acceleration is enabled:

Might that be a hint to something?

@carlfriedrich I suspect you may be using the canvas renderer, because of how the w in PowerShell is cut off on the right in your screenshot (I could be wrong though). The WebGL renderer is much better, using "on" should force the webgl renderer which may improve the looks, lack of hardware support could be causing that if so.

Non-GPU renderer just uses  elements, so the characters are blended together just like any other web document.

@Tyriar Thanks for coming back on this. You mean I should set terminal.integrated.gpuAcceleration to on? I tried that and it does not affect the rendering in my case, just looks identical to auto and canvas. The only choices I have here are:

on
auto
canvas
off

The first three all result in the same rendering. I am on VS Code 1.63.2.

@Tyriar I think I was able to reproduce at least part of the behaviour directly with xterm.js, see my comment there.
An observation is that the blurryness only occurs with the canvas renderer, not with the dom renderer. Why is the dom renderer not available in VS code? What are the differences?

In another upstream comment I found out that the problem in my case is tied to Windows's DPI scaling setting. I am using a DPI scaling of 125%.
My observations above from three weeks ago were taken with this DPI scaling as well. I can confirm that the displayed behaviour does not occur with a DPI scaling of 100%.
However, when I set a scaling factor of 125% in VS Code instead, the behaviour is back. So it does not seem to make a difference, where the scaling is set. Scaling just leads to blurry rendering in any case.

@carlfriedrich dom renderer is used when you set gpuAcceleration to off.

I did some research on this topic and documented it along with a proposal for a solution in the upstream issue.
For now, the only workaround to have a guaranteed crisp font in the terminal is the one proposed by @YuanfengZhang in a comment above: Set your VS code zoom level in a way that the overall zoom level results in 100% when multiplied by your Windows DPI zoom level.
Examples:

Windows DPI zoom level 100% -> set VS Code zoom level to 100%.
Windows DPI zoom level 125% -> set VS Code zoom level to 80%.
Windows DPI zoom level 150% -> set VS Code zoom level to 67%.

Only then the terminal does not apply any zooming, resulting in a crisp font.
I hope that my proposal can be implemented, though, then we would be able to have crisp fonts on common zoom levels as well.

For what it's worth, I found that using the Nerd Font 'CaskaydiaCove NF' was actually the main culprit of having blurry text - adding Cascadia Code back to the top of the font-stack list in settings made an immediate difference - I'm guessing this is because it handles weights better.
As a bonus, which I didn't realize beforehand, the glyphs that I wanted a Nerd Font for (Git symbols etc) will still be handled by the nerd font, while most normal characters will be handled by Cascadia Code - so the best of both worlds, and generally clear.

Adding verified as there is a test plan item associated with this one https://github.com/microsoft/vscode/issues/158833


add blueballs theme

Did you just change the color scheme of one of the pre existing themes? In that case add just the colors to an existing color.ini

I'm not sure where else to put it, there are already themes that have no user.css like Adapta-Nokto. This one has a minor change in the CSS.


top banner and style changes

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--hubblehomes-com--aemsites.hlx.live/
After: https://issue-101--hubblehomes-com--aemsites.hlx.live/

Banner breaks mobile rendering.


Background image of main page renders fine on localhost but after uploading to netlify it does not render

Make sure you have set baseURL properly in your config.yaml file.

@amanprakash59 are you still facing the issue? If not, please close this.


Can't run two platforms together - config.json issue?

I have installed Homebridge, along with plugins for Nest thermostat and Harmony Hub.
I can control either of them perfectly well with Siri when using a config.json file specifically for either the Nest platform or the Harmony Hub platform, but can't seem to create a config.json file which will allow me to control both at the same time. At the moment, I have been swapping the config.json files in the .homebridge folder to achieve this.
I guess what I want it something like this (below - xx's replace sensitive info etc), but I can't make it work together. How can I run two platforms together?

{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "987-65-432"
},
"platforms": [{
    "platform": "Nest",
    "username"<EMAIL_ADDRESS>    "password": "xxxxxxxxx",

    "platform": "HarmonyHub",
    "name": "Lounge",
    "ip_address": "xx.xxx.xx.xx"
}]

}

This issue is that your platform block should look like this
"platforms": [
{
"platform": "Nest",
"username"<EMAIL_ADDRESS>"password": "xxxxxxxxx",
}
{
"platform": "HarmonyHub",
"name": "Lounge",
"ip_address": "xx.xxx.xx.xx"
}
]

The "platforms" is expecting an array of platforms. In your example, you created an array with only 1 platform …
Sent from my iPhone

On Jan 17, 2016, at 12:36 PM, danwalton84<EMAIL_ADDRESS>wrote:
I have installed Homebridge, along with plugins for Nest thermostat and Harmony Hub
I can control either of them perfectly well with Siri when using a configjson file specifically for either the Nest platform or the Harmony Hub platform, but can't seem to create a configjson file which will allow me to control both at the same time At the moment, I have been swapping the configjson files in the homebridge folder to achieve this
I guess what I want it something like this (below - xx's replace sensitive info etc), but I can't make it work together How can I run two platforms together?
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "987-65-432"
},
"platforms": [{
"platform": "Nest",
"username": "dxxxx@xxxxxcom",
"password": "xxxxxxxxx",
"platform": "HarmonyHub",
"name": "Lounge",
"ip_address": "xxxxxxxxx"

}]
}
—
Reply to this email directly or view it on GitHub.

@AppleTechy you missed the comma between two😏

Thanks! So where should the missing comma be?

@KhaosT whoops  I just copied and pasted their example and forgot to add the common after adding the brackets in the correct spot. Guess I can't be trusted to fix every thing

@danwalton84 I fixed by example above in my original comment

Great, I'll give this a go now.

@danwalton84 Let me know if that works

I'm really sorry to come back to this, but I can't get it to validate.
I've replaced the platform block, but it gives me parse errors on a few different lines when I try to validate it.
This is the best I can get - but i'm still getting an error I can't work out on the last line:
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "987-65-432"
},
"platforms": [{
	"platform": "Nest",
	"username"<EMAIL_ADDRESS>	"password": "xxxxxxxxx"
}, {
	"platform": "HarmonyHub",
	"name": "Lounge",
	"ip_address": "xx.xxx.xx.xx"
}]

Oops another mistake... {
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "987-65-432"
},
"platforms": [
{
"platform": "Nest",
"username"<EMAIL_ADDRESS>"password": "xxxxxxxxx"
},
{
"platform": "HarmonyHub",
"name": "Lounge",
"ip_address": "xx.xxx.xx.xx"
}
]
}

@danwalton84 ^

@danwalton84 Did that fix the son validation error?

Worked like a charm, thanks a lot - much appreciated :+1:

No problem, glad I could help!

Hi Appletechy,
I have been having the same issue that @danwalton84 has been having an I have followed your instructions above on numerous occasions but I simply can't seem to get it to work.
I would really appreciate any help you can give as this is driving me mad. I can get both Platforms to work independently but when I try and combine and then check the code it is not good. ( I have also tried loading it in homebridge and it does not work )
See screenshot below and under that the full config file.

 Can't validate my json and trying to add multiple platforms. My config is simple really, don't know what I am missing?
`{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"description": "This is an example configuration file with one fake accessory and one fake platform. You can use this as a template for creating your own configuration file containing devices you actually own.",

"accessories": [
    {
        "accessory": "WeMo",
        "name": "Coffee Maker"
    }
    ],

"platforms": [
    {
        "platform": "netatmo",
        "name": "netatmo weather",
        "ttl": 5,
        "auth": {
        "client_id": "xxxxxxx",
        "client_secret": "xxxxxxxx",
        "username": "magnxxxxx",
        "password": "xxxxx"

    },
    {
        "platform": "Arlo",
        "name": "Arlo",
        "email"<EMAIL_ADDRESS>        "password": "xxxxxx",
        "stay_arm": "mode2",
        "night_arm":"mode3"
    }
    ]
    }

`

I am having a problem can anyone tell me what i am doing wrong im getting an error message Thank you
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"platforms": [{
		"platform": "TplinkSmarthome",
		"name": "TplinkSmarthome"
	},
	{
		"platform": "tcc",
		"name": "Thermostat",
		"username": ".....",
		"password": ".....",
		"devices": "deviceID": "1234567",
		"name": "Other Floor"
	}
]

}

For the tcc plugin you need [] brackets around devices and name.  Look at the tcc readme sample closely
Sent from my iPad

On Feb 23, 2018, at 1:17 AM, owtritebrawla<EMAIL_ADDRESS>wrote:
I am having a problem can anyone tell me what i am doing wrong im getting an error message Thank you
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"platforms": [{
"platform": "TplinkSmarthome",
"name": "TplinkSmarthome"
},
{
"platform": "tcc",
"name": "Thermostat",
"username": ".....",
"password": ".....",
"devices": "deviceID": "1234567",
"name": "Other Floor"
}
]
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"platforms": [{
"platform": "TplinkSmarthome",
"name": "TplinkSmarthome"
},
{
"platform": "tcc",
"name": "Thermostat",
"username": ".....",
"password": ".....",
["devices": "deviceID": "1234567",]
["name": "Other Floor"]
}
]
}

When I added the[] brackets I am still getting an error.
Sent from my iPhone

On Feb 23, 2018, at 7:13 AM, Northern Man<EMAIL_ADDRESS>wrote:
For the tcc plugin you need [] brackets around devices and name. Look at the tcc readme sample closely
Sent from my iPad

On Feb 23, 2018, at 1:17 AM, owtritebrawla<EMAIL_ADDRESS>wrote:
I am having a problem can anyone tell me what i am doing wrong im getting an error message Thank you
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"platforms": [{
"platform": "TplinkSmarthome",
"name": "TplinkSmarthome"
},
{
"platform": "tcc",
"name": "Thermostat",
"username": ".....",
"password": ".....",
"devices": "deviceID": "1234567",
"name": "Other Floor"
}
]
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

please see image

I got it to work. Is Siri able to turn heat over to AC or all you can do is change the temperature?

I have never tried

On Feb 23, 2018, at 1:33 PM, owtritebrawla<EMAIL_ADDRESS>wrote:
I got it to work. Is Siri able to turn heat over to AC or all you can do is change the temperature?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry a bit new to this stuff... Been struggling for few hours... I have my config.json set up for nest thermostat working perfectly. But I'm trying to add 2 lift master garage doors to the home bridge and having no luck at all... I got it to display my IDs for each door but I still get an error when following the guide about Having an existing uuid. Any assistance would be great!


Clear Invalid Filename Error Message

Provide a clear error message. State exact error, if a filename is invalid.
Fixes #22

Codecov Report

Merging #280 into master will decrease coverage by 0.09%.
The diff coverage is 28.57%.

@@            Coverage Diff            @@
##           master     #280     +/-   ##
=========================================
- Coverage   81.19%   81.09%   -0.1%
=========================================
  Files          23       23
  Lines        3106     3111      +5
  Branches      729      729
=========================================
+ Hits         2522     2523      +1
- Misses        450      454      +4
  Partials      134      134

Impacted Files
Coverage Δ

pyxform/survey_element.py
86.76% <28.57%> (-1.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb69c79...4e61a28. Read the comment docs.


I implement a ssd. It can run without Exception, but zhe gradients are allways zeros

Description
I implement a ssd. It can run without Exception, but zhe gradients are allways zeros. djl version is 0.12.0
Expected Behavior
there should be some gradients which is not all zeros.
Error Message
no error message
How to Reproduce?
below is my code.
`try (GradientCollector gc = Engine.getInstance().newGradientCollector()) {
			 NDList results = net.forward(parameterStore, X, true);

			 if(firstTime == 0) {

				 requiresGrad(net.getParameters());
			 }

			 MultiBoxTarget mt = MultiBoxTarget.builder().build();
			 NDList inputs = new NDList(results.get(0));
			 inputs.add(Y.get(0));
			 inputs.add(results.get(1).transpose(0,2,1));

			 NDList outputs =  mt.target(inputs);

			 NDArray l = calc_loss(cls_loss,bbox_loss,new NDList(results.get(1)),new NDList(outputs.get(2)),new NDList(results.get(2)),new NDList(outputs.get(0)),new NDList(outputs.get(1)));

			 gc.backward(l);

			 acc_sum += cls_eval(new NDList(results.get(1)),new NDList(outputs.get(2)));
			 n += outputs.get(2).size();
			 mae_sum += bbox_eval(new NDList(results.get(2)),new NDList(outputs.get(0)),new NDList(outputs.get(1)));
			 m += outputs.get(0).size();

		 }`

What have you tried to solve it?

I have tried to use version 0.11.0 ; I was very happy, beacuse one day, it works very well suddenly. After happy some day, it works badly(all gradients are allways zeros).

Environment Info
IDE: eclipse
jdk: jdk11

@hyandell can you give me a answer?

Apologies @kameronren - I'm a part of the AWS OSPO and am not a domain expert on this project. The project has a Slack channel at deepjavalibrary.slack.com, that might be a good place to raise this. I'll also mention this on there.

@zachgk Can you take a look?

As a first suggestion, I recommend using the Trainer. It is the main training session API and should make it easier to get everything right. You can refer to our SSD example at https://github.com/deepjavalibrary/djl/blob/master/examples/src/main/java/ai/djl/examples/training/TrainPikachu.java to see what that might look like.
Otherwise, the only thought I have on a first glance is that you may need to move the requiresGrad call to before you create the gradient collector. I also don't see how you are initializing the parameters or where the code uses the gradients is.


Configure static PulsarByteBufAllocator to handle OOM errors

Motivation
In BK 4.9 we introduce a ByteBufAllocatorBuilder to configure all the aspect of the Netty ByteBuf allocator, including having a hook to handle the situation of OOM (for direct memory).
Here we create a static wrapper and make sure we use that from all the places in the codebase to ensure we can restart a broker whenever we're out of direct memory.

run cpp tests

run java8 tests
run integration tests

run cpp tests


feat req: ability to set version and appVersion on helm chart save

This is with respect to the experimental support for OCI registries.
When you package up a chart the old-fashioned way using helm package, there are --version and --app-version flags that can be used to specify that information.
There are no analogous options with helm chart save, so in practice, something like this needs to happen:
$ sed -i "s/^version:.*/version: ${VERSION}/" Chart.yaml
$ sed -i "s/^appVersion:.*/appVersion: ${APP_VERSION}/" Chart.yaml
$ helm chart save ...
$ helm chart push ...

Obviously, that's pretty clunky and something like the following would be much more elegant:
$ helm chart save --version ${VERSION} --appVersion ${APP_VERSION} ...
$ helm chart push ...

/cc @jdolitsky

As part of HIP 6, the helm chart commands will soon be deprecated. Instead, the flow will be something like the following:
$ helm create mychart
Creating mychart

$ helm package mychart/
Successfully packaged chart and saved it to: /home/user/mychart-0.1.0.tgz

$ helm push mychart-0.1.0.tgz oci://example.com/some/root/namespace
The push refers to repository [oci://example.com/some/root/namespace/mychart]
ref:     oci://example.com/some/root/namespace/mychart:0.1.0
digest:  1b251d38cfe948dfc0a5745b7af5ca574ecb61e52aed10b19039db39af6e1617
size:    2.4 KiB
name:    mychart
version: 0.1.0
0.1.0: pushed to remote (1 layer, 2.4 KiB total)

Since the helm package supports custom version and app version, I believe what you're asking for will be supported.

@jdolitsky that looks fantastic!
Thanks for the prompt response.


Ocean Node - Wrapper for Auth Policy Server

Needs api for Auth Policy Server

The wrapper for the Policy Server was implemented in the Ocean Node community version, in this PR


Update pyproject.toml

[x] add project dependencies
[x] specify plugin entry point

Closing this issue as completed by merging #72


WMS-1 JAX-RS bean support

-@Produces @Consumes support
-@Produces @Consumes inheritance
-Bean - json conversion
-Bean - xml conversion
-Match resource method by media types
-Inject bean as parameter to resource methods
-Return beans from resource methods
-Respond status code via runtime for unsupported media types
-Tests

Consider sqashing local commits before making a PR to public repository (- reduces git log getting cluttered)


[nemo-qml-plugin-contacts] Package documentation. Fixes JB#58601

Just a question, various packages transitioned from org.nemomobile.foo QML import to Nemo.Foo in the past. Do you plan to continue this transition ? I mean in the context of opening it to harbour. I can think of sailfishos/nemo-qml-plugin-email for instance. The old notation is still allowed though for backward compatibility.

A good question, the answer is a definite maybe. As you can see, we are not doing that transition here and now, so this package is going to be allowed as it is now. If we make the transition later, the old notation will be not be dropped overnight, more likely we will allow both notations for some time.


more module.exports...

:tada: This PR is included in version 2.152.20 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change create and update to allow description field

Codecov Report
Base: 72.72% // Head: 73.30% // Increases project coverage by +0.58% :tada:

Coverage data is based on head (6c4bd60) compared to base (4e099a1).
Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage     72.72%   73.30%   +0.58%
- Complexity      532      533       +1
============================================
  Files            90       90
  Lines          1661     1656       -5
  Branches        178      180       +2
============================================
+ Hits           1208     1214       +6
+ Misses          386      374      -12
- Partials         67       68       +1

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/UpdateCommand.java
93.54% <87.50%> (-0.77%)
:arrow_down:

...eedu/address/logic/parser/CreateCommandParser.java
100.00% <100.00%> (ø)

...eedu/address/logic/parser/UpdateCommandParser.java
87.17% <100.00%> (+0.69%)
:arrow_up:

...n/java/seedu/address/model/person/Description.java
75.00% <100.00%> (ø)

...c/main/java/seedu/address/model/person/Person.java
93.33% <100.00%> (+12.87%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


updateNgModel CPU Usage

I am having major performance issues with angular-summernote. 0.7.3 had much better performance but still almost unusable. updateNgModel gets called 8-15 times per key stroke. Even with ng-model-options. After typing about 15 characters, updateNgModel was called over 2000 times and browser froze (latest chrome). I am using the latest Summernote and latest Angular-Summernote.
<summernote
ng-model-options="{ updateOn: 'blur' }"
config='{"toolbar":[["style",["bold","italic","underline","clear"]],["para",["ul","ol"]],["view",["fullscreen","codeview"]]]}'
height="180"
ng-model="m.Title"></summernote>

Changing the link function to this works as intended. Debouncing doesn't work because you are updating the model anyway using the onchange callback. You were also attaching a watch every time the model value changes. I also didn't understand why you were appending the data every time it changed. This new link function works perfectly and the performance is perfect.
  link: function(scope, element, attrs, ctrls, transclude) {
      var summernoteController = ctrls[0];
      var ngModel = ctrls[1];

      if (!ngModel) {
          transclude(scope, function(clone, scope) {
              // to prevent binding to angular scope (It require `tranclude: 'element'`)
              element.append(clone.html());
          });
      }
      summernoteController.activate(scope, element, ngModel);
  }

yup, the frequent DOM mutation blow me off

I guess that recent pull requests decrease performance. Sorry for that fixing the issue takes a pretty long time. Thank you for deeply test for it. I will fix it soon.

@lJakel Your snippets are very helpful to fix this issue. Thank you.

Great @outsideris
Now let's fix the debounce! :D

@lJakel I will make an issue for it.


python310Packages.textdistance: 4.5.0 -> 4.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.textdistance is: Python library for comparing distance between two or more sequences
meta.homepage for python310Packages.textdistance is: https://github.com/life4/textdistance
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.6.0 with grep in /nix/store/syvdilp1a78k187g4maahxnpbyzdhzlv-python3.10-textdistance-4.6.0
found 4.6.0 in filename of file in /nix/store/syvdilp1a78k187g4maahxnpbyzdhzlv-python3.10-textdistance-4.6.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.spyder
python310Packages.textdistance
python311Packages.spyder
python311Packages.textdistance
spyder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/syvdilp1a78k187g4maahxnpbyzdhzlv-python3.10-textdistance-4.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.textdistance https://github.com/r-ryantm/nixpkgs/archive/3c850146ee8728f77db29bfa6554baec2d033300.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3c850146ee8728f77db29bfa6554baec2d033300#python310Packages.textdistance

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/syvdilp1a78k187g4maahxnpbyzdhzlv-python3.10-textdistance-4.6.0
ls -la /nix/store/syvdilp1a78k187g4maahxnpbyzdhzlv-python3.10-textdistance-4.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

spyder (python310Packages.spyder)
python310Packages.textdistance
python311Packages.spyder
python311Packages.textdistance

Maintainer pings

Result of nixpkgs-review pr 258772 run on x86_64-linux 1

8 packages built:

spyder (python310Packages.spyder)
spyder.dist (python310Packages.spyder.dist)
python310Packages.textdistance
python310Packages.textdistance.dist
python311Packages.spyder
python311Packages.spyder.dist
python311Packages.textdistance
python311Packages.textdistance.dist


Prisma MongoDB Connector findMany query failing (CursorNotFound)

Bug description
Querying a big collection, or getting all documents from a big collection results into a connection error thrown by Prisma.
Error Stack:
Failed to connect to the database. PrismaClientUnknownRequestError2 [PrismaClientUnknownRequestError]:
Invalid `prisma.verifiedBots.findMany()` invocation:

  Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: RawError { code: "unknown", message: "Command failed (CursorNotFound): cursor id<PHONE_NUMBER>204108651 not found)" } })

Possible related Stack Overflow thread(s):

MongoDB CursorNotFound Error on collection.find() for a few hundred small records
MongoDB - Error: getMore command failed: Cursor not found

How to reproduce

Connect to the MongoDB Connector
Query a big collection (the collection on hand contains about 400 documents, with varying document sizes) using findMany()
See error

Expected behavior
Prisma will throw PrismaClientUnknownRequestError2
Error Stack:
Failed to connect to the database. PrismaClientUnknownRequestError2 [PrismaClientUnknownRequestError]:
Invalid `prisma.verifiedBots.findMany()` invocation:

  Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: RawError { code: "unknown", message: "Command failed (CursorNotFound): cursor id<PHONE_NUMBER>204108651 not found)" } })

Prisma information

datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["mongoDb"]
}

model dataset {
  id                   String   @id @default(dbgenerated()) @map("_id") @db.ObjectId
  clientid             String   @unique
  data                 String   @default("")
}

Environment & setup

OS: Windows 10 Pro 21H1
Database: MongoDB 5.0
Node.js version: v16.5.0

Prisma Version
prisma               : 2.27.0
@prisma/client       : 2.27.0
Current platform     : windows
Query Engine         : query-engine cdba6ec525e0213cce26f8e4bb23cf556d1479bb (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli cdba6ec525e0213cce26f8e4bb23cf556d1479bb (at<EMAIL_ADDRESS>Introspection Engine : introspection-core cdba6ec525e0213cce26f8e4bb23cf556d1479bb (at<EMAIL_ADDRESS>Format Binary        : prisma-fmt cdba6ec525e0213cce26f8e4bb23cf556d1479bb (at<EMAIL_ADDRESS>
Default Engines Hash : cdba6ec525e0213cce26f8e4bb23cf556d1479bb
Studio               : 0.410.0

Same error here. The above error occurs when querying 100+ objects from a collection with 500 objects

Hmm, I wasn't able to reproduce. Anyone willing to share a sample dataset that I can use in a reproduction?

Hmm, I wasn't able to reproduce. Anyone willing to share a sample dataset that I can use in a reproduction?

Heyo! Here's a dataset that i generated, which threw the error above:
Hastebin
Insert the dataset above to your database.
The schema is as follows:
datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["mongoDb"]
}

model dataset {
  id   String @id @default(dbgenerated()) @map("_id") @db.ObjectId
  data String
}

Thanks for the dataset, I can reproduce this issue with that.
code/reproductions/issue_8389 is 📦 v1.0.0 via  v14.17.0
❯ yarn start
yarn run v1.22.5
$ ts-node main.ts
(node:14052) UnhandledPromiseRejectionWarning: Error:
Invalid `prisma.dataset.findMany()` invocation:

  Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: RawError { code: "unknown", message: "Command failed (CursorNotFound): cursor id<PHONE_NUMBER>408957573 not found)" } })
    at cb (C:\Users\harshit\code\reproductions\issue_8389\node_modules\@prisma\client\runtime\index.js:34804:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at main (C:\Users\harshit\code\reproductions\issue_8389\main.ts:6:16)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:14052) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing ins
ide of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To termin
ate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodej
s.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:14052) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Terminate batch job (Y/N)?
^C

Can confirm the query works normally up to v2.26.0. Only fails in v2.27.0 and v2.28.0

Hey.
Did You find a solution for this issue? Everything works on my test environment but when on production I get error:
PrismaClientUnknownRequestError3 [PrismaClientUnknownRequestError]:  gql_1  | Invalidprisma.twilio_users.findMany()invocation: gql_1  |  gql_1  |  gql_1  |   Error occurred during query execution: gql_1  | ConnectorError(ConnectorError { user_facing_error: None, kind: RawError { code: "unknown", message: "Command failed (CursorNotFound): cursor id<PHONE_NUMBER>84969514 not found)" } }) gql_1  |     at cb (/app/node_modules/@prisma/client/runtime/index.js:36067:17) gql_1  |     at runMicrotasks (<anonymous>) gql_1  |     at processTicksAndRejections (internal/process/task_queues.js:95:5) gql_1  |     at async emergencyCallAllUsers (/app/helpers/emergencyCallAllUsers.js:9:29)
Prisma version: 2.24.1

Also getting this issue with version 2.30.3 and when I downgrade to 2.26 I get this issue instead: https://github.com/prisma/prisma/issues/6998

Prisma 3.0.2 here. Taking more than 100 records yields this error.

I have the same issue,
Prisma 3.1.1

True. But I think is something related explicitly to MongoDB implementation which is a topic relatively new in the Prisma world and still in experimental stage.

In all my tests, findMany() seems to fail in any subsequent query on the same dataset when applying select: {...} clause which relates to some collections with 100+ records inside. It doesn't matter if cursor: {id: ...} is present or not in the query. Maybe this helps.

Hey @redbaron76, yes the reason for that problem is laid out in this issue
On that note, a fix on the MongoDB Rust driver was just pushed, effectively closing https://github.com/mongodb/mongo-rust-driver/issues/482. I've been told a new version of the driver would be released tomorrow, meaning that this issue might be fixed in time for the next Prisma release.


There is Nothing to Compare

Since I started the Excercise series T09.... I get the Therre is Nothing to Compare message

Should be resolved now, sorry for the delay


Scholars can change their payout address using a command

!address ronin:123 will change scholars payout address

Also combine this with #92


Object scripting doesn't seem to run normally

Hi, found your blog post (also a happy YNAB user =]) and tried following the steps to generate object definitions.
PM> install-package dbup-sqlserver-scripting
Attempting to gather dependencies information for package 'dbup-sqlserver-scripting.1.0.4' with respect to project 'DbUpTest1', targeting '.NETFramework,Version=v4.6.1'
Attempting to resolve dependencies for package 'dbup-sqlserver-scripting.1.0.4' with DependencyBehavior 'Lowest'
Resolving actions to install package 'dbup-sqlserver-scripting.1.0.4'
Resolved actions to install package 'dbup-sqlserver-scripting.1.0.4'
Adding package 'dbup.3.2.1' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'dbup.3.2.1' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'dbup.3.2.1' to 'packages.config'
Successfully installed 'dbup 3.2.1' to DbUpTest1
Adding package 'dbup-consolescripts.1.0.9', which only has tools group, to project 'DbUpTest1'
Adding package 'dbup-consolescripts.1.0.9' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'dbup-consolescripts.1.0.9' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'dbup-consolescripts.1.0.9' to 'packages.config'
Executing script file 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages\dbup-consolescripts.1.0.9\tools\init.ps1'
Successfully installed 'dbup-consolescripts 1.0.9' to DbUpTest1
Adding package 'Unofficial.Microsoft.SQLServer.SMO.2<IP_ADDRESS>0.8' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'Unofficial.Microsoft.SQLServer.SMO.2<IP_ADDRESS>0.8' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'Unofficial.Microsoft.SQLServer.SMO.2<IP_ADDRESS>0.8' to 'packages.config'
Successfully installed 'Unofficial.Microsoft.SQLServer.SMO.2014 12.0.2000.8' to DbUpTest1
Adding package 'dbup-sqlserver-scripting.1.0.4' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'dbup-sqlserver-scripting.1.0.4' to folder 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages'
Added package 'dbup-sqlserver-scripting.1.0.4' to 'packages.config'
Executing script file 'C:\Users\Juliano\documents\visual studio 2015\Projects\DbUpTest1\packages\dbup-sqlserver-scripting.1.0.4\tools\init.ps1'
Successfully installed 'dbup-sqlserver-scripting 1.0.4' to DbUpTest1

Pasted the int Main from the README.md file.
Tried running Start-DatabaseScript pointing to an existing database:
PM> Start-DatabaseScript
Building...
Fetching list of already executed scripts.
The [SchemaVersions] table could not be found. The database is assumed to be at version 0.
Beginning database upgrade
Fetching list of already executed scripts.
The [SchemaVersions] table could not be found. The database is assumed to be at version 0.
No new scripts need to be executed - completing.
Success!

Nothing showed up, no folders were created, so I thought "maybe I have to create a migration first, which makes no sense since I'm starting with an existing database but oh well".
PM> New-Migration
Created new migration:<PHONE_NUMBER>24.sql
PM> Start-DatabaseScript
Building...
Fetching list of already executed scripts.
The [SchemaVersions] table could not be found. The database is assumed to be at version 0.
Beginning database upgrade
Fetching list of already executed scripts.
The [SchemaVersions] table could not be found. The database is assumed to be at version 0.
Executing SQL Server script 'DbUpTest1.Scripts.160111174724.sql'
Creating the [SchemaVersions] table
The [SchemaVersions] table has been created
Upgrade successful
Success!

Still nothing... so I dug around the source code and found that ScriptAll is called when args has --scriptAllDefinitions, so I added it:
var result = upgradeScriptingEngine.Run(new [] { "--scriptAllDefinitions" });

Tried Start-DatabaseScript and voila! It works. All my stuff got dumped. But why only when I set --scriptAllDefinitions?
Maybe it kickstarted the whole thing, IDK, so I took out the hardcoded --scriptAllDefs, created a migration with a simple table and ran Start-Migrations. Scripting definitions didn't run again.
PM> Start-Migrations
Building...
Fetching list of already executed scripts.
Beginning database upgrade
Fetching list of already executed scripts.
Executing SQL Server script 'DbUpTest1.Scripts.160111175327.sql'
Upgrade successful
Success!

My table got created on the target database but it was not written to the Defitions\Tables folder.
I tried putting back the --scriptalldefs arg but then no migrations are executed, I'm forcing some Dump-Only mode.
Halp?

Hi, I have the same problem as the above:
New-Migration was successfully executed from PM console and the table is created in the DB, but the database definitions were not written to anywhere in the project folder (file system).
It was a Create Table script inside a C# Console App. (VS Prof 2013.4, SQL 2008 R2 SP3)
Note, it is not a new database, did the above in an existing database.
PFB step and details:

PM> New-Migration
Created new migration:<PHONE_NUMBER>56.sql

Saved the above SQL file with:
Create table Test (Id int)

PM> Start-Migrations
Building...
Fetching list of already executed scripts.
Beginning database upgrade
Fetching list of already executed scripts.
Executing SQL Server script 'xx.Scripts.160121093356.sql'
Upgrade successful
Success!

Table is created in DB but couldn't find the database definitions anywhere in the project folder (file system). :worried:

I have this same issue (migrations work, but no definitions folder or scripts generated). I'm in the process of switching from EF Migrations to DbUp and this package would be extremely helpful for my team. Looking forward to a resolution.

I have just confirmed the latest release fixed the issue and it works now. =]

Great to hear!

@omnibs Also, glad to hear you're a happy @ynab user!


Plugin stopped working a and cannot be anymore installed

I was using your plugin successfully then stopped working the minification "Error on CLI execution" and even reinstalling the plugin is impossible because the google closuse compiler cannot be extracted after install.
I stopped Bitdefender but error was the same.

Related to #104
The workaround is to extract the custom-packages.zip manually and please take care that you have the latest custom-packages version which is 1.5.1 which you can find in the package.json. I'm thinking about another solution but the workaround should work. And the end path where the CLIs should be is %user%/.netbaens/minifierbeans/custom-package/. so make sure that there is no custom-packages/custom-packages/...

Thanks !

If you want to help me, figure out the problem, just play around. I wanted to create another solution but this takes more time than maybe identifing the bug. So it would be very cool, if you want, to play around to figure out what the problem is to help me here.

If you want to help me, figure out the problem, just play around. I wanted to create another solution but this takes more time than maybe identifing the bug. So it would be very cool, if you want, to play around to figure out what the problem is to help me here.

I would be happy but I am currently in trouble as well... also I can't understand why it stopped working ... a mistery.
Btw, I tries to unzip but once I reload Netbeans it is trying again to unzip the package and a notification appear with a link to retry the unzip and this error is available in the IDE log:
java.lang.NullPointerException: Cannot invoke "java.util.concurrent.Future.get(long, java.util.concurrent.TimeUnit)" because "task" is null
at io.github.chris2011.netbeans.minifierbeans.javascript.JsMinify.jsMinify(JsMinify.java:125)
at io.github.chris2011.netbeans.minifierbeans.javascript.JsMinify.lambda$execute$0(JsMinify.java:75)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1419)
at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2034)

Yeah, because it couln't find the cmd file, which seems you have an old custom-package.zip archive. Please check the version as mentioned. above and also try the workaround.

Yeah, because it couln't find the cmd file, which seems you have an old custom-package.zip archive. Please check the version as mentioned. above and also try the workaround.

Yes Chris, I checked the version is 1.5.1

Please check the path of the unziped package. It needs to be in just one custom-package folder. If you see a custom-packages/custom-packages, this is wrong.

Please check the path of the unziped package. It needs to be in just one custom-package folder. If you see a custom-packages/custom-packages, this is wrong.

Ok, now I have all inside custom-package as follows:
C:\Users....netbeans\minifierbeans\custom-package
\node_modules
...
But when I try to minify a js I obtain this notification:

I think I misspacked smth. First the path is wrong which needs to be custom-packages and not custom-package. For the overall extracting problem, I will dive into it and add logging for myself.

I think I misspacked smth. First the path is wrong which needs to be custom-packages and not custom-package. For the overall extracting problem, I will dive into it and add logging for myself. I also mentioned it incorrect in the other post "custom-package" which is wrong.

Ok. Thanks Chris... it was my fault as I missed the final s.  Now it works fine !
So the reason for stopping working remains unknown, but the unzip process was starting the unzip without creating the custom-packages folder, but then was interrupted and unable to unzip the sub-folders.  Anyway, it looks it was unable to create the custom-packages folder before unzipping.

We had 2 problems. First was that I missed to zip the custom-packages folder as full one so inside the custom-packages.zip the folder custom-packages needs to be there. Second problem is that it seems to have problems to create folders as you said it correct. This is the exception, that I get
java.nio.file.NoSuchFileException: C:\Users\clenz\.netbeans\minifierbeans\custom-packages\google-closure-compiler
	at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:85)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108)
	at java.base/sun.nio.fs.WindowsFileSystemProvider.newByteChannel(WindowsFileSystemProvider.java:235)
	at java.base/java.nio.file.Files.newByteChannel(Files.java:371)
	at java.base/java.nio.file.Files.createFile(Files.java:648)
	at io.github.chris2011.netbeans.minifierbeans.util.FileUtils.extractArchive(FileUtils.java:277)
	at io.github.chris2011.netbeans.minifierbeans.util.FileUtils.lambda$downloadFile$0(FileUtils.java:235)
	at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1420)
	at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
	at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
	at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2035)

But I dunno why this happens now. Maybe a problem with rights? I can remember this problem with linux: #99 but this was already for the files that are exist. I will try to find a fix for that.

Ok the problem seems the compression algorithm (I guess). The last times it seems that I used 7z with compression strength 9 - Ultra. The last time (couple of days ago) I just used windows zip to create the archive. After I played with 7z it worked again but the decompression took veeeeeeeeery long.

So all in all, the first problem was, that I zipped the archive with a wrong compression strength. I just used windows zipping, before I used 7z with highest compression strength (9 - Ultra). The second problem was, that I removed the custom-packages folder from the zip and added the files to the root path which is wrong.
This is fixed in custom-packages 1.5.2 and it should work now out of the box, after opening NetBeans. If not, please empty the folder .netbeans/minifierbeans and restart NetBeans.
With Minifierbeans 3.5.1 I also increased the performance of extracting the archive.


(Chore) #1609 Dashboard top bar remove support icon

Description
Remove the support icon from the top bar on dashboard. Rename FAQ menu item to 'Support & FAQ' in side menu which leads to support.
About #1609
Alert
The REACT_APP_DASHBOARD_SHOW_INVITE environment should be set as true on server configurations to show the invite button on the dashboard's topbar.
How Has This Been Tested?
Go to dashboard ad see topbar. Open the side menu and see the new item.
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[x] I have added screenshots related to my pull request ( for frontend tasks)
[x] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

Screenshots:

Dashboard
SideMenu

Video: https://drive.google.com/a/nordwhale.com/file/d/1TBeUZsUVYI4vlJ_YaKVc0uDOwFFqkouk/view?usp=drivesdk

@yaroslav-fedyshyn-nordwhale
Should I ignore the magic link icon in the settings?

@yaroslav-fedyshyn-nordwhale
Should I ignore the magic link icon in the settings?

@LiavGut Yes


Getting issue in payment Successful alert

I'm getting issue in getting a successful message after i click on pay a webPage opens and it autometicly come back to the app and does not give any alert of error or success and the ui of presentPaymentSheet remain open .

Hi! You're probably not handling the return URL appropriately: https://stripe.com/docs/payments/accept-a-payment?platform=react-native&ui=payment-sheet#react-native-set-up-return-url


Navigation HTTP error handling

Describe the problem
I have a "form" like this:
<script>
let value = "";
</script>

<input type="text" placeholder="Game ID..." bind:value/>
<button type="button" on:click={async () => await goto(`/game/${value}/`} disabled={!value}>Join game</button>

Currently, if some error occurs while trying to join the game (e.g: if the game doesn't exist), the error will be shown by the /game/[gameId]/ route, meaning the user needs to navigate back. Ideally, the error message would be displayed as part of the form.
Describe the proposed solution
I'm not sure exactly how the flow from beforeNavigate to onNavigate to afterNavigate works, but I assume SvelteKit would be aware of errors during onNavigate in which case $page.error should be set before the onNavigate callback is called and then onNavigate should have a cancel method similarly to beforeNavigate. Alternatively, there could be a dedicated onNavigationError
Alternatives considered
Have a route which checks if a game exists, then call that before calling goto. However, this means I need to check if the game exists twice, which isn't ideal.
Importance
would make my life easier
Additional Information
No response

Would preload fit your use case? For example:
<script>
import { preload, goto } from '$app/navigation';

let value =  '';

async function customGoto(href) {
  try {
    await preload(href);
  } catch (error) {
    alert(error.message)
  }
  await goto(href);
}
</script>

<input type="text" placeholder="Game ID..." bind:value/>
<button type="button" on:click={async () => await customGoto(`/game/${value}/`} disabled={!value}>Join game</button>

I hadn't actually seen preload so thanks for showing me this! However, I couldn't get it working.
await preload doesn't throw an error. This seems like it should be the working customGoto (with some debug information)
async function joinGame(href: string) {
	const preloadResult = await preloadData(href);
	if (preloadResult.type === "loaded" && preloadResult.status !== 200) {
		alert(preloadResult.status);
	} else {
		await goto(href);
	}
}

However, it doesn't work. preload.status always seems to be 200. If I put a console.log(preloadResult) and look in the console, I see this which clearly shows that the page is throwing a 403 error, but preloadResult shows 200.

If I look in the network tab, I can see that no 403 status is actually being returned for any requests and that the client is only being informed of the error via the response to the corresponding __data.json request.
{
    "type": "data",
    "nodes": [
        {
            "type": "skip"
        },
        {
            "type": "skip"
        },
        {
            "type": "error",
            "error": {
                "message": "You do not have access to this game!"
            },
            "status": 403
        }
    ]
}

Sorry for getting back to you late! I found some time to play around and can confirm there's no obvious way to detect errors because it's been explicitly excluded from the preloadData function return.
Here's a "workaround" in the meantime: you can check the data property of the returned result and if there are no keys, then it's probably an error (or the load function just doesn't return data on success).
https://stackblitz.com/edit/sveltejs-kit-template-default-czurm9?description=The default SvelteKit template, generated with create-svelte&file=src/routes/+page.svelte&title=SvelteKit Default Template

@Rich-Harris should preloadData know about thrown errors from load functions or should it primarily be used to load the code / data for the next page?

That's an interesting workaround. It doesn't work if the target route uses a layout which returns data but, to get around that, I can pass the number of keys in the layout of the target route to customGoto and check against that. Ideally, though, I'd be able to show the user the specific error message.

It does feel like result.type should be 'loaded' | 'redirect' | 'error' rather than 'loaded' | 'redirect'. This feels like an oversight. Would fixing that be a breaking change, do we think?

This is a very simple reproduction:
https://stackblitz.com/edit/sveltejs-kit-template-default-7retxz?file=src%2Froutes%2F%2Bpage.svelte

Unfortunately, @eltigerchino's workaround doesn't quite work, since preloadData still returns the layout data even if it couldn't load the page data. I've encountered this issue using {#await} in a shallow loaded dialog. It looks like the best workaround for now is to explictly check if a particular key exists on the result.data object.

I've drafted a PR for this fix. I think we can agree it's not a breaking change since it never worked in the first place (status always returned 200 even on errors). The new return type should look something like below:
export function preloadData(href: string): Promise<{
	type: 'loaded';
	status: number;
	data: Record<string, any>;
} | {
	type: 'redirect';
	location: string;
} | {
	type: 'error';
	status: number;
	error: App.Error;
}>;

Any thoughts on this?

Awesome! This was an existing issue so it might be worth creating a separate issue/PR for this, but you providing the PR has made me notice that the status is missing is there's a redirect, which seems a bit pointless. For one, if the status is always provided then it makes any logic dependent on the status a lot simpler since it doesn't need to check the type first. But also, there are many redirect HTTP status codes (300 - 399) which could be used by developers to quickly indicate information which the client might want to know before checking the location.

the status is missing if there's a redirect, which seems a bit pointless. For one, if the status is always provided then it makes any logic dependent on the status a lot simpler since it doesn't need to check the type first. But also, there are many redirect HTTP status codes (300 - 399) which could be used by developers to quickly indicate information which the client might want to know before checking the location.

Currently, the server doesn't return those status codes in the __data.json payload, so we would need to change that if we decide to standardise this.

Hm, that's a bit annoying, but would I be correct in saying that wouldn't be a breaking change since it would just mean adding (not removing/changing) a property? Or is the keyset used for validation or something?

It shouldn't be. I haven't heard any objections yet so I tried adding it. The new interface looks something like this:
	(
		| {
				type: 'loaded';
				data: Record<string, any>;
		  }
		| {
				type: 'redirect';
				location: string;
		  }
		| {
				type: 'error';
				error: App.Error;
		  }
	) & {
		status: number;
	}


[WIP][GIT PULL] Always use -fpic -fPIC flag for nolibc build

Hi Jens,
This PR only contains 1 commit from me.
Bob reports linking time error for nolibc build:
  relocation R_X86_64_PC32 against symbol `memset' can not be \
  used when making a shared object; recompile with -fPIC

When we statically link liburing.a into a shared object, we need to
make sure it's built with -fpic -fPIC flag.
Note:
liburing.a can be used to create a new shared object (*.so) or a
non shared object ELF. When we use it to create a shared object,
it needs to be compiled with the above flag.
Always using this flag for nolibc build even if the target is not
a shared object ELF is still fine.
Link: https://github.com/axboe/liburing/issues/443#issuecomment-975493681
Fixes: c7d03dc2c123bc2ee85582d8f922acd268d6ac78 ("configure: Add CONFIG_NOLIBC variable and macro")
Fixes: f48ee3168cdc325233825603269f304d348d323c ("Add nolibc build support")
Reported-by: Bob Chen<EMAIL_ADDRESS>Tested-by: Bob Chen<EMAIL_ADDRESS>Signed-off-by: Ammar Faizi<EMAIL_ADDRESS>
Cc: @beef9999

git request-pull output:
The following changes since commit df9a741895028204b130b6cbe03c5c3dda3cf1a9:

  Rename man page (2021-11-18 07:27:17 -0700)

are available in the Git repository at:

  https://github.com/ammarfaizi2/liburing tags/pic-issue-nolibc

for you to fetch changes up to bfb8975dda09f39d9f947f7b431f3dc01cb74b78:

  src/Makefile: Always use `-fpic -fPIC` flag for nolibc build (2021-11-23 16:23:40 +0700)

----------------------------------------------------------------
pic-issue-nolibc

----------------------------------------------------------------
Ammar Faizi (1):
      src/Makefile: Always use `-fpic -fPIC` flag for nolibc build

 src/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

By submitting this pull request, I acknowledge that:

I have followed the above pull request guidelines.
I have the rights to submit this work under the same license.
I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

@ammarfaizi2 The new .a lib caused memory leak in my old program. I didn't even start to use this lib yet, just linked it.
Please hold merging this PR until I figured out what happened.

@ammarfaizi2 The new .a lib caused memory leak in my old program. I didn't even start to use this lib yet, just linked it.
Please hold merging this PR until I figured out what happened.

Sure, please send any update with the progress.

@ammarfaizi2 I realized that the symbols from this liburing.a will replace the global glibc malloc memset, which might be the root cause of the mem leak. So I started to wonder there are better options than --nolibc.
After some dig, I found that gcc has a --version-script parameter, which will export symbols for a minimum requirement based on liburing.map. No symbols conflicts any more.
So .a static lib is working now.

@ammarfaizi2  My opinion is --version-script could solve everything we discussed. The nolibc seems not required any more.

The nolibc seems not required any more.

What do you mean by "The nolibc seems not required any more."?
--version-script can't replace --nolibc. --nolibc is arch dependent build that does not link libc shared object.

@ammarfaizi2 I mean usually people need an independent lib because they don't wish to meet symbol conflicts. Once this problem solved, the independency is not needed.
But perhaps due to my limit knowledge, I didn't come up with other scenarios that --nolibc is needed. Would you elaborate?

@ammarfaizi2 I mean usually people need an independent lib because they don't wish to meet symbol conflicts. Once this problem solved, the independency is not needed.

You are correct. Apart from that, there is also another case, people may also not want to link libc to their project.

But perhaps due to my limit knowledge, I didn't come up with other scenarios that --nolibc is needed. Would you elaborate?

The dependencies are not only malloc() and memset(), it includes every syscall used in that project. Like mmap(2), close(2), munmap(2), syscall(2), etc.
Apparently, those syscalls need libc wrapper to work with. What if we don't want libc to be linked in our project?
--nolibc comes as a solution to that question. If people don't want to use libc, they have to build with --nolibc flag, it will construct Assembly code directly to implement those syscalls. Unlike libc wrapper, Assembly code is not portable, so we have to code every single architecture. Currently supported arch to build nolibc is only x86-64.

See the discussion in this issue for detail https://github.com/axboe/liburing/issues/443#issue-1007905107

Let's close this, now I think always using -fpic -fPIC is not a proper solution. We should prevent malloc(), memset() replace libc function in case the target is compiled with libc. That's not what we do here.


Change model index d.ts file generation to builder and simplify inter…

…face comments
The builder classes are the same as the ones in autorest.typescript, so there isn't really a need to look at those. Please just focus on the model classes (CodeModelJS, CompositeTypeJS, PagedCompositeTypeJS, etc.).

🤖 AutoRest automatic feature coverage report 🤖
feature set version 2.6.0
❌ General: 97%
13 out of 540 features are not covered by tests
additionalPropertiesSubclass, animalNotFoundError, expectedNoErrors, expectedPetHungryError, expectedPetSadError, getArrayEnumValid, getArrayStringEnumValid, getDateTimeRfc1123MinUtc, intError, linkNotFoundError, putArrayEnumValid, putArrayStringEnumValid, stringError
❌ Azure: 96%
4 out of 122 features are not covered by tests
LROPostDoubleHeadersFinalAzureHeaderGet, LROPostDoubleHeadersFinalAzureHeaderGetDefault, LROPostDoubleHeadersFinalLocationGet, PagingMultipleLRO


Metadata filter

Add metadata filter to lancedb storage

@pmeier Thanks for all the comments. Ran into a couple quirks with LanceDB's add_columns method, but otherwise all your suggestions worked out. Do you know what's happening with mypy in this commit? It's complaining about missing types in LanceDB but I thought that the overrides in pyproject.toml would take care of that.

Do you know what's happening with mypy

Yes. If you have code like this
from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from ragna import Rag

def foo() -> Rag:
    from ragna import Rag

    return Rag()

it looks like this should work. Running mypy on this succeeds. But running this script fails with
Traceback (most recent call last):
  File "/home/philip/git/ragna/main.py", line 7, in <module>
    def foo() -> Rag:
NameError: name 'Rag' is not defined

The reason is that Python evaluates the annotations at definition. For example
from ragna import Rag

def foo() -> Rag:
    return Rag()

print(foo.__annotations__)

{'return': <class 'ragna.core.Rag'>}

And since at definition in the top script, the Rag object is not available, you face the error.
That being said, there is an easy solution for it: turn the annotation into a string.
from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from ragna import Rag

def foo() -> "Rag":
    from ragna import Rag

    return Rag()

print(foo.__annotations__)

{'return': 'Rag'}

Now mypy and Python are happy. Internally mypy resolves the string back to its actual type with typing.get_type_hints() and so does Ragna as well:
https://github.com/Quansight/ragna/blob/2066dcdeb949060873a8552449b848b245e0e985/ragna/core/_components.py#L73-L75
Finally, because it is a little tedious to always stringify the annotations, there is a shortcut. If you from __future__ import annotations at the top of your module, the stringification is applied automatically in the background:
from __future__ import annotations

from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from ragna import Rag

def foo() -> Rag:
    from ragna import Rag

    return Rag()

print(foo.__annotations__)

And this is what I did in 4a3b32e22fde58274206529585b41f4c0a8e9b22.


fix: set version well-known label with specified value

Fixes #173
before:
❯ helm template test charts/cloudnative-pg | grep app.kubernetes.io/version
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"

❯ helm template test charts/cloudnative-pg --set image.tag=1.20.2 | grep app.kubernetes.io/version
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"

after:
❯ helm template test charts/cloudnative-pg | grep app.kubernetes.io/version
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"
    app.kubernetes.io/version: "1.22.0"

❯ helm template test charts/cloudnative-pg --set image.tag=1.20.2 | grep app.kubernetes.io/version
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"
    app.kubernetes.io/version: "1.20.2"

@itay-grudev @phisco - poke poke 🙏🏾

That's a default from Helm, when you create a new chart using helm create my_chart, you get a set of helpers, one of them is for common labels and the version is set to the AppVersion.
Looking at other widely used charts it looks like no one is changing that. Which I think makes, as the image tag has nothing to do with the version of the app, the tag could be whatever you like (in our case it has to be a semantic version, because we use that, but for most other projects it doesn't) and if that's actually an older or more recent version of the application the chart was meant for, even if it might work, that's not the version the chart was meant to work with.

Actually @phisco I think @nareshov might have a point. According to the docs:

app.kubernetes.io/version - The current version of the application (e.g., a SemVer 1.0, revision hash, etc.)

The chart here supports overriding the operator version by specifying a different image.tag, and it genuinely makes sense to override the labels.
As to the argument that this is a Helm default - it is - one that makes sense as a default. Not necessarily the best implementation. I get gunienly upset by people doing stuff a certain way only because everyone else is. This way we might end up in a local maximum within the field of success.

Exactly:

app.kubernetes.io/version - The current version of the application (e.g., a SemVer 1.0, revision hash, etc.)

What you mean by application is the key point here. AppVersion is the application version, so it looks fitting here. That default assumes the helm chart IS the application, which I agree with. And, as I was saying, the image tag has little to do with the actual version being deployed, you should not use the chart with a version of the operator different from the one it was meant for.

This is the chart version:
https://github.com/cloudnative-pg/charts/blob/42ab86f7be5d65df87ae03cce255e8ff6a1905a7/charts/cloudnative-pg/Chart.yaml#L21
This is the application version running inside the chart:
https://github.com/cloudnative-pg/charts/blob/42ab86f7be5d65df87ae03cce255e8ff6a1905a7/charts/cloudnative-pg/Chart.yaml#L26
And importantly, the helm chart is not application. The CNPG operator it is provisioning is. And just to prove that there is a precedent for this, here is an excerpt from the Grafana Helm chart:
https://github.com/grafana/helm-charts/blob/674b94682f1a2ebf8a72ca9a698f181b52c05592/charts/grafana/templates/_helpers.tpl#L64

@nareshov I think @phisco's argument makes a lot of sense. In fact I think it makes much more sense to either:

Remove image.tag overrides, although that could lead to problems on its own with users who need to host their own docker image.

Indicate explicitly that the version is overridden and outside of normal operating parameters. Consider this for example:

app.kubernetes.io/version: {{ ternary .Chart.AppVersion (printf "0.0.0-%s" .Values.image.tag) (empty .Values.image.tag) | quote }}

This would produce the following:
app.kubernetes.io/version: "1.22.2" # when no image.tag is set
app.kubernetes.io/version: "0.0.0-yourtag" # when an override is specified

Here is a repl.
I also now think this MR should remain closed.


Setup transfer server account for new AM data drop

Renamed the main.tf file to transfer_server_accounts.tf for clarity.
Added new ip/ssh keys for capita.

@pricemg Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance
Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs


Expo 51 + React Native 0.74.5 + New Arch Enabled: "Failed to install react-native-bignumber"

Reproduction steps:

npx create-expo-app@latest -e with-new-arch
npm install react-native-bignumber
npx expo prebuild --clean -p ios
npm run ios
watchman watch-del-all
npm run start --reset-cache

Versions:

expo 51.0.31
react-native-bignumber 0.2.3
react-native 0.74.5

System:

XCode 16
Sequoia 15

When I disable the new architecture, everything works properly.
I've created a repo as well (with the ios directory committed): Base Repo URL
Thank you!
React Native Config:
   "reactNativeVersion": "0.74",
  "dependencies": {
    "expo": {
      "root": "~/Projects/new-arch-bignumber-test/node_modules/expo",
      "name": "expo",
      "platforms": {
        "ios": {
          "podspecPath": "~/Projects/new-arch-bignumber-test/node_modules/expo/Expo.podspec",
          "version": "51.0.34",
          "configurations": [],
          "scriptPhases": []
        },
        "android": {
          "sourceDir": "~/Projects/new-arch-bignumber-test/node_modules/expo/android",
          "packageImportPath": "import expo.modules.ExpoModulesPackage;",
          "packageInstance": "new ExpoModulesPackage()",
          "buildTypes": [],
          "componentDescriptors": [],
          "cmakeListsPath": "~/Projects/new-arch-bignumber-test/node_modules/expo/android/build/generated/source/codegen/jni/CMakeLists.txt",
          "cxxModuleCMakeListsModuleName": null,
          "cxxModuleCMakeListsPath": null,
          "cxxModuleHeaderName": null
        }
      }
    },
    "react-native-bignumber": {
      "root": "~/Projects/new-arch-bignumber-test/node_modules/react-native-bignumber",
      "name": "react-native-bignumber",
      "platforms": {
        "ios": {
          "podspecPath": "~/Projects/new-arch-bignumber-test/node_modules/react-native-bignumber/react-native-bignumber.podspec",
          "version": "0.2.3",
          "configurations": [],
          "scriptPhases": []
        },
        "android": {
          "sourceDir": "~/Projects/new-arch-bignumber-test/node_modules/react-native-bignumber/android",
          "packageImportPath": "import com.margelo.bignumber.BigNumberPackage;",
          "packageInstance": "new BigNumberPackage()",
          "buildTypes": [],
          "componentDescriptors": [],
          "cmakeListsPath": "~/Projects/new-arch-bignumber-test/node_modules/react-native-bignumber/android/build/generated/source/codegen/jni/CMakeLists.txt",
          "cxxModuleCMakeListsModuleName": null,
          "cxxModuleCMakeListsPath": null,
          "cxxModuleHeaderName": null
        }
      }
    }
  },

Screenshot:

@Szymon20000 can you take a look at this? 🙏


✨[FEATURE] NewsScraper with Gemini AI

News Scraper
A Python-based web scraper designed to extract news articles from various sources, analyze their sentiment, and provide summaries of the content. This project leverages Selenium for web scraping and advanced Natural Language Processing (NLP) techniques, including Gemini AI for sentiment analysis and summarization.
Features

Web Scraping:

Efficiently extracts articles from Google News and other news websites.
Retrieves full content by following article links.

Sentiment Analysis:

Merges titles and content of articles for comprehensive analysis.
Utilizes Gemini AI for advanced sentiment analysis, providing accurate sentiment scores (positive, negative, neutral).

Summarization:

Employs Gemini AI to generate concise summaries of the articles, helping users quickly grasp the main points.

Data Storage:

Organizes and saves extracted data in structured formats, such as CSV or JSON.

@suryanshsk can you assign me this issue :)

Sorry , Your issue is not related with our project


Raise warning for infinite recursion

Patching #7
Raises humanly-understandable warning for infinite recursion.

Is there a risk that this patch would lead to uninformative output for RuntimeErrors that aren't due to infinite recursion? Should raise RuntimeError be simply raise in the event of a non-recursion error?

@nschneid The error would still be raised as in L48 regardless. But if the maximum recursion occurs, it should be due to infinite recursion, as noticed the error message "maximum recursion depth exceeded".

That's fine in the case of infinite recursion; I'm worried about other kinds of RuntimeErrors that might arise. The current solution would remove the traceback and error message. How about:
except RuntimeError as _error:
    if _error.message == "maximum recursion depth exceeded":
        # more helpful error message (and don't distract the user by showing the recursion stack)
        raise StandardError('The grammar has rule(s) that yield infinite recursion!!')
    else: # don't handle non-recursion errors
        raise

@nschneid let me test out all possibly and output them, then we can choose depending on informative they are. I'll do that later today, got to go to work soon =)

@nschneid If we're raising error for the recursion, I think raising RuntimeError to be consistent with the catch might be better than StandardError.
Proposal 1: With StandardError
def _generate_all(grammar, items, depth):
    if items:
        try:
            for frag1 in _generate_one(grammar, items[0], depth):
                for frag2 in _generate_all(grammar, items[1:], depth):
                    yield frag1 + frag2
        except RuntimeError as _error:
            if _error.message == "maximum recursion depth exceeded":
                # Helpful error message while still showing the recursion stack.
                raise StandardError("The grammar has rule(s) that yield infinite recursion!!")
            else:
                raise
    else:
        yield []

[out]:
>>> from nltk.parse import generate
>>> generate.demo_grammar = """
... A -> A B | 'a'
... B -> 'b'
... """
>>> generate.demo()
Generating the first 23 sentences for demo grammar:

A -> A B | 'a'
B -> 'b'

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "nltk/parse/generate.py", line 79, in demo
    for n, sent in enumerate(generate(grammar, n=N), 1):
  File "nltk/parse/generate.py", line 42, in _generate_all
    for frag1 in _generate_one(grammar, items[0], depth):
  File "nltk/parse/generate.py", line 58, in _generate_one
    for frag in _generate_all(grammar, prod.rhs(), depth-1):
  File "nltk/parse/generate.py", line 42, in _generate_all
    for frag1 in _generate_one(grammar, items[0], depth):
  File "nltk/parse/generate.py", line 58, in _generate_one
... (repeating errors)
  File "nltk/parse/generate.py", line 48, in _generate_all
    raise StandardError("The grammar has rule(s) that yield infinite recursion!!")
StandardError: The grammar has rule(s) that yield infinite recursion!!

Proposal 2: With RuntimeError
def _generate_all(grammar, items, depth):
    if items:
        try:
            for frag1 in _generate_one(grammar, items[0], depth):
                for frag2 in _generate_all(grammar, items[1:], depth):
                    yield frag1 + frag2
        except RuntimeError as _error:
            if _error.message == "maximum recursion depth exceeded":
                # Helpful error message while still showing the recursion stack.
                raise RuntimeError("The grammar has rule(s) that yield infinite recursion!!")
            else:
                raise
    else:
        yield []

>>> from nltk.parse import generate
>>> generate.demo_grammar = """
... A -> A B | 'a'
... B -> 'b'
... """
>>> generate.demo()
Generating the first 23 sentences for demo grammar:

A -> A B | 'a'
B -> 'b'

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "nltk/parse/generate.py", line 79, in demo
    for n, sent in enumerate(generate(grammar, n=N), 1):
  File "nltk/parse/generate.py", line 42, in _generate_all
    for frag1 in _generate_one(grammar, items[0], depth):
  File "nltk/parse/generate.py", line 58, in _generate_one
    for frag in _generate_all(grammar, prod.rhs(), depth-1):
  File "nltk/parse/generate.py", line 42, in _generate_all
    for frag1 in _generate_one(grammar, items[0], depth):
  File "nltk/parse/generate.py", line 58, in _generate_one
... (repeating errors)
  File "nltk/parse/generate.py", line 48, in _generate_all
    raise RuntimeError("The grammar has rule(s) that yield infinite recursion!!")
RuntimeError: The grammar has rule(s) that yield infinite recursion!!

Thanks for the feedback @nschneid


Add Fondest landing page to showcase

I think you need to add a screenshot if you want to be in the showcase. There is a task to help you: deno task screenshot <url> <id>


Improve workflow name validation for argo

OpenBio allows users to enter workflow names which are invalid in the argo environment, rendering the resulting argo yaml file unusable.
Steps to reproduce:
(1) Create a new workflow named eg. ABC1
(2) Export to argo yaml
(3) Try uploading to an argo instance. Output is:
Bad Request: Workflow.argoproj.io "ABC1--1qmf6v" is invalid: [metadata.generateName: Invalid value: "ABC1--1": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), metadata.name: Invalid value: "ABC1--1qmf6v": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')]: Reload
Proposed solution: Validate name using provided regex before allowing workflow creation

I believe changing the validation process for all tool names is a very drastic change. Since argo executor (as all other executors) take as input a DAG we could simply traverse the DAG and change the tool names. Since all components (tools/steps/...) communicate through BASH variables this shouldn't generate any side effect.
Proposed solution: change all tool names with a function that looks like this:
def argo_tool_name(tool_name):
   return 'tool_' + tool_name.lower()

This brings forward another issue! tool_names are not validated at server side. Someone could deliberately manipulate local javascript to create invalid tool names and corrupt the database!

Proposed PR: #219


fix Enable common expr pushdown in the restore inverted idx case #45547

cherry pick from #45547

run buildall


Add SagaLogger to automatically log context in sagas

@keybase/react-hackers opening this as a draft to discuss. This adds a third parameter passed in to sagas by chainAction and chainGenerator, a SagaLogger. SagaLogger is a lil convenience wrapper for the four log fcns that prefixes them with the action type and the name of the saga function.
Right now we add the context ourselves which 1. makes logging harder which makes us less likely to do it and 2. isn't in any consistent format which makes logs harder to read. This PR shortens some of our log messages with this in mind (e.g. log messages like Error writing config stellar.lastSentXLM: ${err.message} become Error: ${err.message}).
One caveat: originally this used function.name so all this context came to the saga writer for free. In minified code function names get mangled, so we can't do this. I added an optional last parameter to chainAction and chainGenerator for the name of the function. Most of the +diff comes from prettier expanding these all out into separate lines 😞

This seems like it's useful. I think it's different than the saga logging middleware because it attaches context to the log line.
Can you give an example of what the log line would be outputted?

Here are some lines @MarcoPolo
3633 ["Info","2019-04-01T19:38:29.617Z","markThreadAsRead [route-tree:navigateTo]: marking read messages 0000d15d6c50fdd130a3ed3e2306afab8da162ffbd0f25fd03c7f2d3df8af591 40391"]
3634 ["Info","2019-04-01T19:38:29.625Z","loadMoreMessages [chat2:selectConversation]: calling rpc convo: 0000d15d6c50fdd130a3ed3e2306afab8da162ffbd0f25fd03c7f2d3df8af591 num: 20 reason: inboxBig"]
3635 ["Info","2019-04-01T19:38:29.718Z","markThreadAsRead [chat2:updateUnreadline]: marking read messages 0000d15d6c50fdd130a3ed3e2306afab8da162ffbd0f25fd03c7f2d3df8af591 40391"]
3636 ["Info","2019-04-01T19:38:29.851Z","markThreadAsRead [chat2:messagesAdd]: marking read messages 0000d15d6c50fdd130a3ed3e2306afab8da162ffbd0f25fd03c7f2d3df8af591 40391"]
3637 ["Info","2019-04-01T19:38:29.890Z","onNewChatActivity [engine-gen:chat1NotifyChatNewChatActivity]: Got new chat activity of type: 2"]
3638 ["Info","2019-04-01T19:38:30.251Z","queueMetaToRequest [chat2:metaNeedsUpdating]: skipping meta queue run, queue unchanged"]
3640 ["Info","2019-04-01T19:38:32.105Z","loadMoreMessages [chat2:selectConversation]: bail: no conversationIDKey"]
3641 ["Info","2019-04-01T19:38:32.105Z","getUnreadline [chat2:selectConversation]: Load unreadline bail: no conversationIDKey"]
3642 ["Info","2019-04-01T19:38:32.108Z","markThreadAsRead [route-tree:navigateUp]: marking read bail on not in meta list. preview?"]
3694 ["Info","2019-04-01T19:40:33.931Z","writeLastSentXLM [wallets:setLastSentXLM]: Writing config stellar.lastSentXLM: true"]
3695 ["Info","2019-04-01T19:40:33.986Z","markThreadAsRead [route-tree:navigateTo]: marking read bail on not in meta list. preview?"]
3696 ["Info","2019-04-01T19:40:34.109Z","onNewChatActivity [engine-gen:chat1NotifyChatNewChatActivity]: Got new chat activity of type: 1"]

Many of these log messages could be shorter now. (from the bottom of this)
@chrisnojima yeah, I did see the existing middleware - what Marco said. The goal of this is to make logger more useful inside the sagas.

Also not sure if you are aware of this: https://github.com/keybase/client/blob/master/shared/logger/action-transformer.js#L57, but we could use that to transform the action to a log-safe version so we can output more useful context

@MarcoPolo yeah I have seen that - do you think there's a way here to encourage people to write those more often?

@keybase/react-hackers this is ready for review!

Add SagaLogger as third parameter to sagas
Replace global logger uses with SagaLogger in chat, teams, and wallets

Did you think about the performance implication of adding this?
I think we'll pay for more space to store the new SagaLogger objects, but we pay for that at the beginning when we startup the sagas. After that I think it should be the same in terms of performance.
And the startup cost is probably pretty low.
does that sound right?

@MarcoPolo there's a runtime implication too, the SagaLoggers are created every time a saga runs, not just at the beginning. Should be easy to make them only once though, I'll make that change

Hm, actually, it's not as easy as I thought. At first I thought we could create them outside the chainActionHelper and then set the prefix inside, but sagas could step on each others' toes and the prefixes could get mixed up. So I think the best we can do is to make the SagaLogger outside and create new closures inside to use every time. Do you think that's worth it?

[ ] Merge after release


Added getDataTypeManager to GhidraScript

I wasn't sure if it would be more appropriate to add this to GhidraScript or FlatProgramAPI.

Hey,
just had a little peek at this by pure chance.
From what I have seen the only change here is making the method
public DataTypeManager getDataTypeManager(String name)
directly available in the GhidraScript class.
So far I have seen that this only would avoid a method hop, since you can already call this from a GhidraScript (should even have been available back then when this PR was raised):
DataTypeManager dtm = getCurrentProgram().getDataTypeManager();
Maybe the author or someone with more knowledge about the entire codebase can tune in, but I think this is probably obsolete.
Best regards,
BMC

Hey,
just had a little peek at this by pure chance.
From what I have seen the only change here is making the method
public DataTypeManager getDataTypeManager(String name)
directly available in the GhidraScript class.
So far I have seen that this only would avoid a method hop, since you can already call this from a GhidraScript (should even have been available back then when this PR was raised):
DataTypeManager dtm = getCurrentProgram().getDataTypeManager();
Maybe the author or someone with more knowledge about the entire codebase can tune in, but I think this is probably obsolete.
Best regards,
BMC

That would only get the data type manager for the current program and not any open data type manager.