Issue with "wrongly-placed shaded zones?"

I'm seeing reports on Talk that a large number of images are being served with the shaded zones being placed "in the foreground or on the sides of the site." I don't fully understand, but it seems to be causing a lot of concern and inability to mark properly?
http://talk.penguinwatch.org/#/boards/BPZ0000001/discussions/DPZ0000c2c?page=3&comment_id=554a5765a77a1b126200000c
Zuzi tells me that she spoke with Tom and Caitlin yesterday about this, and Tom said it sounded like a major concern.
Is anyone looking into this? Does anyone understand the issue better than I do?

Yes, forgot to mention this to Cam – Cam those images we gave you don’t need any shaded areas, and I think for a couple of cameras the view might have changed slightly.
Can you see which images? We can do new ROIs.
Cheers,
Tom
Dr Tom Hart, Penguinologist.
Department of Zoology,
South Parks Road,
Oxford,
OX1 3PS.
+44 1865 600 170
www.penguinwatch.orghttp://www.penguinwatch.org/
www.penguinlifelines.orghttp://www.penguinlifelines.org/
From: DarrenMcRoy<EMAIL_ADDRESS>Sent: 07 May 2015 16:22
To: zooniverse/Penguins
Subject: [Penguins] Issue with "wrongly-placed shaded zones?" (#70)
I'm seeing reports on Talk that a large number of images are being served with the shaded zones being placed "in the foreground or on the sides of the site." I don't fully understand, but it seems to be causing a lot of concern and inability to mark properly?
http://talk.penguinwatch.org/#/boards/BPZ0000001/discussions/DPZ0000c2c?page=3&comment_id=554a5765a77a1b126200000c
Zuzi tells me that she spoke with Tom and Caitlin yesterday about this, and Tom said it sounded like a major concern.
Is anyone looking into this? Does anyone understand the issue better than I do?
—
Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/Penguins/issues/70.

Hi Darren,
I think there is a problem with the ROI. All of the images that she flagged are from one site- Booth Island. The camera is named BOOTb. Is there an easy way to change the ROI to the whole image?
Cheers,
Caitlin Black
DPhil Student
Ocean Research and Conservation Group
University of Oxford
Department of Zoology
South Parks Rd.
Oxford OX1 3PS
UK
+44 (0) 1865 281 329
www.penguinlifelines.org
www.penguinwatch.org
From: DarrenMcRoy <notifications<EMAIL_ADDRESS>Reply-To: zooniverse/Penguins <reply<EMAIL_ADDRESS>Date: Thursday, May 7, 2015 at 4:22 PM
To: zooniverse/Penguins <Penguins<EMAIL_ADDRESS>Subject: [Penguins] Issue with "wrongly-placed shaded zones?" (#70)
I'm seeing reports on Talk that a large number of images are being served with the shaded zones being placed "in the foreground or on the sides of the site." I don't fully understand, but it seems to be causing a lot of concern and inability to mark properly?
http://talk.penguinwatch.org/#/boards/BPZ0000001/discussions/DPZ0000c2c?page=3&comment_id=554a5765a77a1b126200000c
Zuzi tells me that she spoke with Tom and Caitlin yesterday about this, and Tom said it sounded like a major concern.
Is anyone looking into this? Does anyone understand the issue better than I do?
—
Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/Penguins/issues/70.

@camallen can you work with Tom and Caitlin on this?
If you're looking for examples of images that are having this issue, there are a ton provided by users here: http://talk.penguinwatch.org/#/boards/BPZ0000001/discussions/DPZ0000c2c?page=3&comment_id=554a5765a77a1b126200000c
Thanks!!

Sso you can see the general shape of the existing ROI's here, http://www.penguinwatch.org/rois.html and this is the file we need to fix the coords for https://github.com/zooniverse/Penguins/blob/master/public/roi.tsv
I assume that the camera moved between seasons? If so will, which sites have moved? Also do new sites need ROI filters?

Hey Cam,
I don’t think any of the sites need the new filters. Is it possible to make BOOTb2015 undefined for now? We will look and see if any ROIs have shifted from last year, but let’s assume they haven’t. The one exception is LOCKa (the one you asked about earlier), which has definitely moved, but can be set as undefined.
Hope that helps,
Caitlin Black
DPhil Student
Ocean Research and Conservation Group
University of Oxford
Department of Zoology
South Parks Rd.
Oxford OX1 3PS
UK
+44 (0) 1865 281 329
www.penguinlifelines.org
www.penguinwatch.org
From: Campbell Allen <notifications<EMAIL_ADDRESS>Reply-To: zooniverse/Penguins <reply<EMAIL_ADDRESS>Date: Thursday, May 7, 2015 at 4:28 PM
To: zooniverse/Penguins <Penguins<EMAIL_ADDRESS>Cc: CEB <caitlin.black<EMAIL_ADDRESS>Subject: Re: [Penguins] Issue with "wrongly-placed shaded zones?" (#70)
I assume that the camera moved between seasons? If so will, which sites have moved? Also do new sites need ROI filters?

@penguintom79 said:

Yes, forgot to mention this to Cam – Cam those images we gave you don’t need any shaded areas, and I think for a couple of cameras the view might have changed slightly.

@caitlinblack said:

I don’t think any of the sites need the new filters. Is it possible to make BOOTb2015 undefined for now? We will look and see if any ROIs have shifted from last year, but let’s assume they haven’t. The one exception is LOCKa (the one you asked about earlier), which has definitely moved, but can be set as undefined.

Can you verify all the site filenames you gave me do not correlate to any of these roi names here? If none match then they will not have roi filters applies to them. E.g. image APZ00049me had the filename "BOOTb2015/BOOTb2014b_001620.JPG" which matched BOOTb2014b roi.
I fixed the BOOTb2014b image to have no ROI as per the closed ticket above. Can you verify which LOCKa site in the ROI's you want to remove?


Add index for slides rendering in Github Pages

I added index.html to preview slides using Github pages with an url parameter to choose which markdown file to load.
Example : https://benoit.rospars.me/scikit-learn-tutorial/slides/?file=slides.md
I don't think CI is needed for now.

Great!
So, the idea is that we could turn on github pages and use it to display human-readable version of the MOOC?
I like very much the idea. What do we need to do in the repository to enable it?

I'll merge this, to facilitate iterations

I enabled Github Pages for the gh-pages branch. Let me know if I need to do something else.

@lesteve Could you enable it on the master branch ? It's easier to keeping up to date
We could add the link to the readme also.

OK it's on master now.
Just curious, do you have the rights to change this. Go to https://github.com/lesteve/scikit-learn-tutorial/settings and then scroll down until you find "Github Pages". Not sure I can add admin permissions to someone since the project is under my username and not in a org repo.

No I do not have access to settings but I don't mind.

Good to know.

Benoit, it seems that the slides on the web page are rendered at a
different aspect ratio than the one I use.
The target aspect ratio should be 16:9 (that's the one used for the
videos).
Thanks a lot!

Indeed remarker uses 16:9 by default. I'll fix it in a new PR.

Ideally the slides would be produced by the same procedure as the one locally (i.e. by using make).
I originally created the gh-pages branch because I thought this is where slides.html would go.


python: can't open file 'manage.py': [Errno 2] No such file or directory

Hi,
I follow the doc and this article
But I unable to do this
$ docker-compose -f dev.yml run django python manage.py migrate
Postgres is up - continuing...
python: can't open file 'manage.py': [Errno 2] No such file or directory

I redo the job 3 times to be sure I didnt miss something.
Do you have any idea ?
Regards

Did you use docker-compose -f dev.yml build to build the whole system? Could you please post the output of docker ps and docker-compose -f dev.yml run django ls -la.
Furthermore this tutorial does not seem up to date anymore, as the current Dockerfile should create a data partition by itself and the whole $ echo 'ln -sfn /mnt/sda1/data /data' >> /var/lib/boot2docker/bootlocal.sh command is obsolete.
What version of Docker are you using and on which operating system? Windows, macOS, Linux?

i'm going to retry and will skip the step with the symbolic link.
I use Debian 8.6 and docker 1.12.3
docker --version
Docker version 1.12.3, build 6b644ec

so here I am, you have everything from the creation of the vm (except cookiecutter https://github.com/pydanny/cookiecutter-django.git I didnt restart from scratch)

If you're running Debian, you should use native Docker instead of using Docker Machine.
Docker Machine on Debian is probably not correctly mapping your project directory into the virtual machine you are running, that's why you get the error.

ok so I skipped the docker-machine part and now it's running.
But ! If I say I use Postgresql 9.6, docker-compose -f dev.yml up never found the database at all

Facing the same issue within a different scenario:
Added cookiecutter-django project under backend folder.
docker-compose -f local.yml run django ls -la
... drwxrwxr-x    5 1000     1000          4096 May 17 21:01 backend -rw-rw-r--    1 1000     1000          1534 May 17 21:06 local.yml ...
Why it is copying the files in backend instead of django folder.
Thanks in advance.

@Devansh3790 the project has changed a lot since this issue was opened, if you need help, please file a new issue the options you've selected, some details about your machine (Linux, Windows, Mac) and what command is failing.
Thanks


network: Don't try to recreate Quilt network

Before, we tried to create the Quilt Docker network whenever the minion
started. However, if it already existed (e.g. if the minion were
restarted and the previous instance already created the network), the
call to CreateNetwork failed, and the minion crashed.
Note that restarting the minion still doesn't always work. There's some race conditions in the supervisor code that @Baisang will probably improve with his current work.

Why were the minions restarting?

I was manually restarting the container. I used to be able to push a new version of my dev build, and use it just by restarting the minion containers. You could imagine this happening if the minion crashed, though, and systemd restarted it, like in the integration test failure a couple days ago.

Current coverage is 58.13% (diff: 81.25%)

Merging #732 into master will increase coverage by 0.11%

@@             master       #732   diff @@
==========================================
  Files            89         89
  Lines          7018       7032    +14
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4072       4088    +16
+ Misses         2625       2622     -3
- Partials        321        322     +1

Powered by Codecov. Last update 34db600...d6558ff

My other question is ... could we just check the error that CreateNetwork returned, and swallow it silently if it was "already exists" or some equivalent?  Would be a lot easier than listing the networks if possible.

Ping, what do we need to do to get this merged?

The exact error is failed to allocate gateway (<IP_ADDRESS>): Address already in use. I feel like checking for that error message is less direct than checking that the Quilt network hasn't already been created.
I don't feel that strongly about it, though, so if you'd prefer to just check the error I'm fine with that.

Ah no that error isn't as clear as I'd like. I'd say merge it as is.


Updated deployment scripts to work on hardened ubuntu

- What I did
I have updated install_software.sh, create.sh, atsign.sh to work correctly on hardened ubuntu in GCP cloud. Main change was explicate execution of permissions and ownership of dess files.
- How I did it
Change from execution under atsing user to root followed by reassigning of ownership of files and change of permissions.
- How to verify it
execute deployment on fresh machine
- Description for the changelog
Update of deployment scripts to support hardened OS.

I think I resolve the ownership issues with #8 what specific hardened ubuntu image caused the issues?

@XavierChanth I can confirm your curl script works perfectly on Hardened ubuntu. Closing my PR


Issue053 intermediary initial step in reset

Motivations:

Introduction in issue #53
The idea of computing the first time step of all functions introduced by @DaluS in PR #50 is extended here, the associated function is incorporated into an section of Solver.reset(), as I assumed it would be logical and perhaps simpler for the user.
As a result of this (pre-computing t=0 for intermediary functions), the solving order for time step ii in run() has to be reversed: before it was intermediary then ode, now it must be ode then intermediary
I also propose several minor changes and code clean-up, some of which result in a minor acceleration of the simulation time :-)

Main changes:

A few redundant lines removed in Solver.__init__()
Solver.runIntermediaryAtInitialState() is deleted and the code is incorporated in Solver.reset()
In Solver.run(), ode are now solved before intermediary
In Solver.run(), there is now an option (compute_auxiliary) to activate / deactivate on-the-run computation of auxiliary functions (set to True by default, but that can be changed)
Since now a computation of the dict of input kwdargs for each function is necessary both in reset() and in run(), I propose to compute this dictionary in self.set_dparam(), once and for all, as a hidden attribute. This way is called in reset() and run() instead of being re-created in each of them (faster, simpler, single-sourced). Also it now contains directly the values to be used and not just the keys.
This it also allows the lambda exception to be dealt with there instead of dealing with it at every time step inside the time loop, which seems to result in a non-negligibly faster run time :-)

Issues:

Fixes issue #53

Results / examples:

unit tests unchanged and passing
user -interface unchanged (no new method, but all you wanted to do is done)

In [1]: import _class

In [2]: sol = _class.Solver('GK')
Suggested order for intermediary functions (func_order):
['Y', 'L', 'Pi', 'lambda', 'omega', 'phillips', 'kappa', 'I']

At this point the first time step of all functions has been computed
In [7]: sol.get_summary()
Numerical param.  value  units  comment
----------------  -----  -----  -----------------------------------------------
Tmax              100    y      Duration of simulation
dt                0.01   y      Time step (fixed timestep method)
nt                10000  None   Number of temporal iteration
nx                1      None   Number of similar systems evolving in parrallel

Model param.  value                  units   group       comment
------------  ---------------------  ------  ----------  -----------------------------------------------------------
r             0.03                   y^{-1}  Prices      Interest at the bank
k0            -0.0065                None    Keen        Percent of GDP invested when profit is zero
k1            0.006737946999085467   None    Keen        Investment slope
k2            20                     None    Keen        Investment power in kappa
alpha         0.02                   y^{-1}  Population  Rate of productivity increase
delta         0.005                  y^{-1}  Capital     Rate of capital depletion
beta          0.025                  y^{-1}  Population  Rate of population growth
nu            3                      None    Production  Kapital to output ratio
phinull       0.04                   None    Philips     Unemployment rate that stops salary increase (no inflation)
phi0          0.04006410256410257    None    Philips
phi1          6.410256410256412e-05  None    Philips

function  source                         initial    units               eqtype  comment
--------  -----------------------------  ---------  ------------------  ------  --------------------------------------------------
a          alpha * itself                1.00e+00   Output Humans^{-1}  ode     Exogenous technical progress as an exponential
N          beta * itself                 1.00e+00   Humans              ode     Exogenous population as an exponential
K          I - itself * delta            2.70e+00   Real Units          ode     Capital evolution from investment and depreciation
W          itself * phillips             8.50e-01   Dollars             ode     Wage evolution through phillips curve
D          I - Pi                        1.00e-01   Dollars             ode     Debt as Investment-Profit difference
Y          K / nu                        9.00e-01   Real units          inter   GDP in output quantity
L          K / (a * nu)                  9.00e-01   Humans              inter   Workers
Pi         Y - W * L - r * D             1.32e-01   Dollars             inter   Absolute profit
lambda     L / N                         9.00e-01                       inter   employment rate
omega      W * L / Y                     8.50e-01                       inter   Wage share of the economy
phillips   -phi0 + phi1 / (1 - lamb)**2  -3.37e-02  y^{-1}              inter   Wage inflation rate
kappa      k0 + k1 * np.exp(k2*Pi/Y)     1.20e-01                       inter   Part of GDP in investment
I          Y * kappa                     1.08e-01   Dollars             inter   Investment
g          (1 - omega) / nu - delta      4.50e-02   y^{-1}              aux     Relative growth
d          D / Y                         1.11e-01                       aux     relative private debt
pi         1 - omega - r * d             1.47e-01                       aux     relative profit
i          Y * 0                         0.00e+00   y^{-1}              aux     Inflation rate
time       1.                            0.00e+00   y                   ode     Time vector

And are all re-computed using sol.reset()
The execution time of the simulation, which was, on my PC, around 1.30 seconds in the previous version (see https://github.com/DaluS/GEMMES/pull/46#issuecomment-880465885), is now faster both with and without computing auxiliary functions on-the-run, with respectively a 20 % and 28 % gain:
In [5]: %timeit sol.run(compute_auxiliary=False)
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
931 ms ± 9.07 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

In [6]: %timeit sol.run(compute_auxiliary=True)
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
time step 10000 / 10000
1.03 s ± 6.25 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

Hello @Didou09! Thanks for opening this PR.

In the file _class.py:

Line 99:56: W291 trailing whitespace
Line 199:11: E225 missing whitespace around operator
Line 278:25: E231 missing whitespace after ','
Line 320:50: E231 missing whitespace after ','
Line 366:33: E203 whitespace before ':'
Line 369:78: W291 trailing whitespace
Line 406:28: E203 whitespace before ':'
Line 407:47: E203 whitespace before ':'
Line 412:27: E225 missing whitespace around operator
Line 423:30: E226 missing whitespace around arithmetic operator
Line 427:50: E226 missing whitespace around arithmetic operator
Line 430:56: E226 missing whitespace around arithmetic operator
Line 441:30: E226 missing whitespace around arithmetic operator
Line 454:34: E226 missing whitespace around arithmetic operator
Line 474:53: E226 missing whitespace around arithmetic operator
Line 474:57: E226 missing whitespace around arithmetic operator
Line 475:53: E226 missing whitespace around arithmetic operator
Line 475:57: E226 missing whitespace around arithmetic operator
Line 476:53: E226 missing whitespace around arithmetic operator
Line 482:24: E226 missing whitespace around arithmetic operator
Line 482:32: E226 missing whitespace around arithmetic operator
Line 482:74: E226 missing whitespace around arithmetic operator
Line 485:5: E303 too many blank lines (2)
Line 489:5: E301 expected 1 blank line, found 0

In the file utilities/_class_utility.py:

Line 116:31: W291 trailing whitespace

Do see the Hitchhiker's guide to code style

Conflicts solved @DaluS , you can merge if you agree
Have a nice weekend

Perfect Thank you ! Have a nice weekend :)


Translated using Weblate (Portuguese)

Currently translated at 100.0% (134 of 134 strings)

Can one of the admins please verify this patch?


[Event Request] Page 5098 "Task Card" - New publisher OnBeforeGetEndDateTimeEnableFields

Hello, we need a new Event publisher in procedure EnableFields(). Can you please check that? Thank you!
local procedure EnableFields()
begin
    RecurringDateIntervalEnable := Recurring;
    CalcDueDateFromEnable := Recurring;

    if not Recurring then begin
        Evaluate("Recurring Date Interval", '');
        Clear("Calc. Due Date From");
    end;

    if Type = Type::Meeting then begin
        StartTimeEnable := not "All Day Event";
        EndingTimeEnable := not "All Day Event";
        DurationEnable := not "All Day Event";
        LocationEnable := true;
        AllDayEventEnable := true;
    end else begin
        StartTimeEnable := false;
        EndingTimeEnable := false;
        LocationEnable := false;
        DurationEnable := false;
        AllDayEventEnable := false;
    end;

    OnBeforeGetEndDateTimeEnableFields(Rec, StartTimeEnable, EndingTimeEnable, DurationEnable, LocationEnable, AllDayEventEnable);

    GetEndDateTime;
end;

[IntegrationEvent(true, false)]
local procedure OnBeforeGetEndDateTimeEnableFields(var ToDo: Record "To-Do"; var StartTimeEnable: Boolean; var EndingTimeEnable: Boolean; var DurationEnable: Boolean; var LocationEnable: Boolean; var AllDayEventEnable: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Consensus: Remove files which record status when be stopped

I'am not sure. Need research firstly.
IMHO, maybe we can remove the wal files for consensus.
Get the current status from chain.
So, we can avoid a lot of compatibility problems, such as changes of wal format.

@KaoImin


undefined: graphql.UseFieldRootResolvers with go mod

After turning my project into a module, graphql.UseFieldRootResolvers is undefined.
I am quite new to modules, so any common mistake I could have made?
Import:
graphql "github.com/graph-gophers/graphql-go"
"github.com/graph-gophers/graphql-go/relay"

go.mod
github.com/graph-gophers/graphql-go v0.0.0-20200309224638-dae41bde9ef9

@flofeld
Please where did you find this graphql.UseFieldRootResolvers?

graphql.UseFieldRootResolvers I assume is actually meant to be graphql.UseFieldResolvers? https://github.com/graph-gophers/graphql-go/blob/master/graphql.go#L89:L94


Fetch Custom logs From Plain Text File To EFK Stack

Hi Guys,
I have collected some logs/data from my server and stored in a text file. Now I want to display these logs/data to my own Kibana. After a detailed googling I could understood that, its possible by the basics of indexing/inputing my logs/data text file to Fluentd. How can I do this. Please help me.
Regards,
Subin

Could you post your question into mailing list or community slack?
Thanks.

I have already posted  mailing list or community slack.. But no response. Any one please help.


Parquet magic bytes not found in footer

Describe the bug
Hi, unfortunately I cannot share this dataset. But I generated a parquet file from a job and crawled it with glue. I can read the parquet file directly (it is only one), but not through the awswrangler

wr.s3.read_parquet_table(database=DATABASE, table=TABLE)
---------------------------------------------------------------------------
ArrowInvalid                              Traceback (most recent call last)
<ipython-input-13-e9f8f38e5027> in <module>
      1 # Read the table into Pandas
      2
----> 3 wr.s3.read_parquet_table(database=DATABASE, table=TABLE)

~/.local/lib/python3.7/site-packages/awswrangler/_config.py in wrapper(*args_raw, **kwargs)
    437                 del args[name]
    438                 args = {**args, **keywords}
--> 439         return function(**args)
    440
    441     wrapper.__doc__ = _inject_config_doc(doc=function.__doc__, available_configs=available_configs)

~/.local/lib/python3.7/site-packages/awswrangler/s3/_read_parquet.py in read_parquet_table(table, database, filename_suffix, filename_ignore_suffix, catalog_id, partition_filter, columns, validate_schema, categories, safe, map_types, chunked, use_threads, boto3_session, s3_additional_kwargs)
    961         use_threads=use_threads,
    962         boto3_session=boto3_session,
--> 963         s3_additional_kwargs=s3_additional_kwargs,
    964     )
    965     partial_cast_function = functools.partial(

~/.local/lib/python3.7/site-packages/awswrangler/s3/_read_parquet.py in read_parquet(path, path_root, path_suffix, path_ignore_suffix, version_id, ignore_empty, ignore_index, partition_filter, columns, validate_schema, chunked, dataset, categories, safe, map_types, use_threads, last_modified_begin, last_modified_end, boto3_session, s3_additional_kwargs, pyarrow_additional_kwargs)
    768             use_threads=True,
    769             boto3_session=boto3_session,
--> 770             s3_additional_kwargs=s3_additional_kwargs,
    771         )
    772     return _union(

~/.local/lib/python3.7/site-packages/awswrangler/s3/_read_parquet.py in _validate_schemas_from_files(paths, sampling, use_threads, boto3_session, s3_additional_kwargs, version_ids, pyarrow_additional_kwargs)
    154         s3_additional_kwargs=s3_additional_kwargs,
    155         version_ids=version_ids,
--> 156         pyarrow_additional_kwargs=pyarrow_additional_kwargs,
    157     )
    158     _validate_schemas(schemas=schemas)

~/.local/lib/python3.7/site-packages/awswrangler/s3/_read_parquet.py in _read_schemas_from_files(paths, sampling, use_threads, boto3_session, s3_additional_kwargs, version_ids, pyarrow_additional_kwargs)
    118                     itertools.repeat(use_threads),
    119                     versions,
--> 120                     itertools.repeat(pyarrow_additional_kwargs),
    121                 )
    122             )

/home/ubuntu/anaconda3/lib/python3.7/concurrent/futures/_base.py in result_iterator()
    584                     # Careful not to keep a reference to the popped future
    585                     if timeout is None:
--> 586                         yield fs.pop().result()
    587                     else:
    588                         yield fs.pop().result(end_time - time.monotonic())

/home/ubuntu/anaconda3/lib/python3.7/concurrent/futures/_base.py in result(self, timeout)
    430                 raise CancelledError()
    431             elif self._state == FINISHED:
--> 432                 return self.__get_result()
    433             else:
    434                 raise TimeoutError()

/home/ubuntu/anaconda3/lib/python3.7/concurrent/futures/_base.py in __get_result(self)
    382     def __get_result(self):
    383         if self._exception:
--> 384             raise self._exception
    385         else:
    386             return self._result

/home/ubuntu/anaconda3/lib/python3.7/concurrent/futures/thread.py in run(self)
     55
     56         try:
---> 57             result = self.fn(*self.args, **self.kwargs)
     58         except BaseException as exc:
     59             self.future.set_exception(exc)

~/.local/lib/python3.7/site-packages/awswrangler/s3/_read_parquet.py in _read_parquet_metadata_file(path, boto3_session, s3_additional_kwargs, use_threads, version_id, pyarrow_additional_kwargs)
     74     ) as f:
     75         pq_file: Optional[pyarrow.parquet.ParquetFile] = _pyarrow_parquet_file_wrapper(
---> 76             source=f, coerce_int96_timestamp_unit=pyarrow_args["coerce_int96_timestamp_unit"]
     77         )
     78         if pq_file is None:

~/.local/lib/python3.7/site-packages/awswrangler/s3/_read_parquet.py in _pyarrow_parquet_file_wrapper(source, read_dictionary, coerce_int96_timestamp_unit)
     41         try:
     42             return pyarrow.parquet.ParquetFile(
---> 43                 source=source, read_dictionary=read_dictionary, coerce_int96_timestamp_unit=coerce_int96_timestamp_unit
     44             )
     45         except TypeError as ex:

~/.local/lib/python3.7/site-packages/pyarrow/parquet.py in __init__(self, source, metadata, common_metadata, read_dictionary, memory_map, buffer_size, pre_buffer, coerce_int96_timestamp_unit)
    230             buffer_size=buffer_size, pre_buffer=pre_buffer,
    231             read_dictionary=read_dictionary, metadata=metadata,
--> 232             coerce_int96_timestamp_unit=coerce_int96_timestamp_unit
    233         )
    234         self.common_metadata = common_metadata

~/.local/lib/python3.7/site-packages/pyarrow/_parquet.pyx in pyarrow._parquet.ParquetReader.open()

~/.local/lib/python3.7/site-packages/pyarrow/error.pxi in pyarrow.lib.check_status()

ArrowInvalid: Parquet magic bytes not found in footer. Either the file is corrupted or this is not a parquet file.

Environment
Python 3.7
pyarrow                            5.0.0
pandas                             1.3.4
awswrangler                        2.12.1
boto3                              1.20.16

Oh, I figured the other files were bothering! using filename_suffix=".parquet" works excellent. Not sure if this error is handled by awswrangler perhaps it could guide a bit? Issue can be closed :)

Did you create the table manually w/o .parquet suffix in the location? Anyways, happy that it's been resolved. Feel free to reopen if there are any questions.

Hi @kukushking - No, some automated process that not only produces parquet files but other commit files as shown in the picture. Apparently awswrangler tried to read them too as parquet.


completerService call from constructor

@oferh
I have a question do we need to make completerService call always from constructor?
For example, from the demo completerService is called from AppComponent Constructor(), Can i call the service from different method?
Reason is the remote url (or even if i use custom data) has some parameter other than the search parameter(from completer input) , the parameter will be at appComponent which can be changed.
Since I'm calling the service from constructor, I'm not able to pass the additional parameter which is part of appcomponent. Please advise.

@pdinesh80 you can call completerService in any section of the code that you need, from your question I guess that you'd probably want to initialize it in ngOnInit.

Thanks @oferh for your reply.
For example if I'm calling the service from a method inside appCOmponent for example callService(), how callService() will be invoked whenever we type on completerInput.

@pdinesh80 can you add a code sample?
completerService is a factory that generates  CompleterData objects, the CompleterData object is the one that performs the search and emits the data to the component.

@oferh I figured the way, Thanks.


update landing page for POC2 launch

@ChialiT can I close this? 😊

update the https://channel4.wtf/

@ChialiT can I close this? 😊

yep, I finally updated.


Strip whitespace from file content

The new functionality added in https://github.com/m-lab/go/pull/142 to read values from named files, failed to strip extra whitespace from the file content. This change strips extra whitespace to prevent strange values.

This change is

Pull Request Test Coverage Report for Build 1102

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.065%

Totals

Change from base Build 1099:
0.0%

Covered Lines:
2013

Relevant Lines:
2140

💛  - Coveralls


Fix babel-macros has been renamed to babel-plugin-macros

Fix #2

@leoasis please merge...

@leoasis and release... :)

@mufasa71 what do you think?

@frederikhors As I know jest require for babel-core. I can remove ^, but since yarn.lock is there

@mufasa71 I tried on my WIndows with both yarn and npm: babel-core is a problem for both. I removed it and everything works good.

@frederikhors I tried to remove and its not working on linux. Also I found official documentations related to this https://jestjs.io/docs/en/getting-started#using-babel Any suggestions?

I went ahead and found Leonardo on Facebook, asked him to add a few maintainers to merge this PR asap. Stay tuned!

@frederikhors I tried to remove and its not working on linux. Also I found official documentations related to this https://jestjs.io/docs/en/getting-started#using-babel Any suggestions?

Can you retry? It works on my PC.

Any way for us to install this ourselves? I was going to point to the branch but I figure there is a build step

@zackify you have to build it yourself and use github.com/some in package.json until any of use can be mantainer and to all the work.
We are waiting for @leoasis.
I also opened this: https://github.com/apollographql/apollo-feature-requests/issues/58

@frederikhors this is listed as MIT maybe we should fork and publish ourselves?

@zackify I think we should wait a little more time.

No news from Leonardo yet.
I ended up adding a prebuild script which simply replace the name of the import in node_modules/graphql-tag.macro/dist/index.js prior to we pack compilation.
Let's wait a couple more days, then forking under a new package seems best.

I was chatting with him on Twitter today, he said tomorrow he might add me as a contributor :)

Sorry for not being active, I was actually on vacation this last week. I'll get this sorted out with the help of @zackify today 💃

Thanks for the PR @mufasa71! It seems to be working fine, I'll make a release for this. Sorry again for taking so long to get to this


Fix #11797 upadte @svgr/webpack to version 6.0.0

Fix: Log in - Leave the login input when the user hits back from the password page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/11797
PROPOSAL: https://github.com/Expensify/App/issues/11797#issuecomment-1277480981
Tests

Open the app
Make sure there's no console error

[x] Verify that no errors appear in the JS console

QA Steps

Open the app
Make sure there's no console error

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/16502320/199019911-a9088137-0936-46f4-8b01-325e881a32e0.mov
Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Thanks @Santhosh-Sellavel. I updated my PR.

Can you explain breaking changes or any impacts like for the new library also? And how it doesn't affect us.

In react-native-svg-transformer 1.0.0. there are 2 breaking changes:

Breaking: drop support for react-native versions older than 0.59
Breaking: drop support for react-native-svg versions older than 12
It won't affect our application since we are using react native version 0.70.5 and react-native-svg version 13+.

Thanks.

Screenshot:

@hungvu193

Fix: Log in - Leave the login input when the user hits back from the password page

What's this in PR description?

@Gonals can you run the workflows above?

Screenshots

#### iOS
![Simulator Screen Shot - iPhone 13 - 2022-11-02 at 01 21 51](https://user-images.githubusercontent.com/85645967/199330779-e62381fc-848a-4504-8004-72fd6d23c355.png)
#### Android
![Screenshot_1667332124](https://user-images.githubusercontent.com/85645967/199330786-a5702192-cab8-4e03-bd1d-6de67f99d71d.png)
#### Desktop

#### mWeb
![Simulator Screen Shot - iPhone 13 - 2022-11-02 at 01 40 34](https://user-images.githubusercontent.com/85645967/199331483-a64ef136-287c-4688-9468-0fbc27a60b22.png)
#### Web

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@hungvu193

Fix: Log in - Leave the login input when the user hits back from the password page

What's this in PR description?

Sorry, I've just updated the PR description.

@Gonals Can you initiate workflow checks?

Done

@Gonals sorry I've just rebase and signed my commit again.

@Gonals looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

No an emergency, everything was passing

Great job getting your Expensify/App pull request over the finish line! I'll merge it assuming all the tests pass.
I know there's a lot of information in our contributing guidelines, so some points to take note of:
Once your PR is merged, you can be hired for another issue. Once you've completed a few issues, we may start hiring you for more than one issue at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that this doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically we would revert this PR and give you another chance to create a similar PR without causing a regression. (I don't imagine this will happen with this PR, but it's something to be aware of)
Once your PR is deployed to production, we start a 7-day timer. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job.
So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo!

Great job getting your Expensify/App pull request over the finish line! I'll merge it assuming all the tests pass.
I know there's a lot of information in our contributing guidelines, so some points to take note of:
Once your PR is merged, you can be hired for another issue. Once you've completed a few issues, we may start hiring you for more than one issue at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that this doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically we would revert this PR and give you another chance to create a similar PR without causing a regression. (I don't imagine this will happen with this PR, but it's something to be aware of)
Once your PR is deployed to production, we start a 7-day timer. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job.
So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo!

@Gonals Thank you so much for the detail :).

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Gonals in version: 1.2.24-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.24-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.24-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.24-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


GitHub PR automation: account for already open PR

This is a workaround for job failures caused by a PR already existing for v.next <- main. An unhandled return code 1 was to blame. We want to account for this so the job is a success in this common case.

See test50 which demos this case.

Closing - this logic has been added to wbohr/cherry-pick-from-main


Remove remaining (really) juttled references.

I missed some juttled references in my first search, so removing the
remainder.
@go-oleg @demmer

lgtm


UnknownMethodException DynamicModel - each custom validator

After update the Yii2 version to 2.0.35 from 2.0.34 the each validator doesn't work with custom validation function. I suspect #18012 to have cause this problem (or #17944?).
What steps will reproduce the problem?
Set up custom validation function with each within a model class:
public $staff_ids;

public function rules()
{
    return [
        ...
        ['staff_ids', 'each', 'rule' => ['string']],
        [['staff_ids'], 'each', 'rule' => ['validateStaffIds']],
        ...
    ];
}

public function validateStaffIds($attribute, $params, $validator)
{
   ...
}

What is the expected result?
For each id within the staff_ids the custom validater validateStaffIds is called.
What do you get instead?
Error:
yii\base\UnknownMethodException: Calling unknown method: yii\base\DynamicModel::validateStaffIds() in /srv/http/ig-net/vendor/yiisoft/yii2/base/Component.php:300
Additional info

Q
A

Yii version
2.0.35

PHP version
v7.4.5

Operating system
Manjaro 5.4.39

Webserver
Nginx 1.18

@ricardomm85, @bizley would you please take a look?

That should be #17944 when the model was replaced with dynamic model.

I think I have a solution. Let me test it a bit before PR.

Looks like it works, let me know what you think.

@1Luc1 please check if it is OK with master version.

With v2.0.34 i used the attribute within the costume validator as follow (continuing the example from above):
public function validateStaffIds($attribute, $params, $validator)
{
   ...
   if (is_numeric($this->$attribute)) {
      ...
   }
}

Where this custom validator function is called for each element within staff_ids.
With v2.0.36-dev it doesn't work like that anymore and i have to change it as follow to at least don't get any errors:
public function validateStaffIds($attribute, $params, $validator)
{
   ...
   if (is_numeric($this->$attribute[0])) {
      ...
   }
}

As i can see from debug logs, validateStaffIds is only called once and $this->$attribute has the same values as staff_ids.
I don't know if this is indented to work like that? If so, i have to run through all values with a loop within the custom validator function.

Indeed one more thing was missing for this to work like before the change (fingers crossed).

Unfortunately it's more complicated now that I thought. Please check the PR above for more info.


Remove Azure.Queues.dll from CC report

Fixes #5703
Description
This is a follow-on to PR #5723
Specific Changes
Remove Azure.Queues.dll from CodeCoverage.runsettings CodeCoverage Include list.

Pull Request Test Coverage Report for Build 254404

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.05%) to 76.383%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs
1
90.91%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
2
90.91%

Totals

Change from base Build 254261:
0.05%

Covered Lines:
23009

Relevant Lines:
30123

💛  - Coveralls

/azp run BotBuilder-DotNet-CI-PR-yaml


Support for Swift Package Manager

Flutter now supports Swift Package Manager, a CocoaPods alternative for managing iOS and macOS native dependencies that come built-in with Xcode.

Integration with Xcode: With new versions of Xcode that break the CocoaPods compatibility, this is not an issue with SPM—fewer files to manage (no need to Podfile, Podfile.lock).
Simplifies Flutter installation: No need to install Ruby and Cocoapods or sometimes Homebrew and RVM.

CocoaPods should still be supported in case SPM is unsupported or disabled, currently, it's only available with the main branch of Flutter. Flutter plugins have already migrated and support SPM including other community plugins. SPM support is subject to change for app developers but not plugin authors.
The flutter_quill itself is not a plugin but it uses plugins that don't support SPM:

quill_native_bridge
flutter_keyboard_visibility_temp_fork
gal (a dependency of flutter_quill_extensions) Replaced by quill_native_bridge in https://github.com/singerdmx/flutter-quill/pull/2403

Swift package manager is now supported in Flutter stable. The PR #2403 closes this issue.


pdf.worker.js needed but not that is not clearly stated

Hello,
Thanks for all this work, I am trying-out your pdf-viewer, it is very good btw.
Just a note, I think the file pdf.worker.js is needed when implementing the pdf viewer (my browser was looking for it and the issue was gone when I added it in /js/libs/) while it was not obvious (for me) that I would need it. Maybe a line in the Readme to remember us that we need it would be helpful.
Thanks again.

Thanks for pointing that out. Added the file in the Dependencies section.


Create additional windows kitchen tests for command line install options

What does this PR do?
Expands on the existing kitchen tests;
Tests the existing command line options
Also, fixes bug where the process agent command line explicit disable was setting the wrong keyword
Motivation
Not wanting to do it manually every time.
Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2694 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
+ Coverage   56.73%   56.74%   +<.01%
==========================================
  Files         380      380
  Lines       24118    24118
==========================================
+ Hits        13684    13685       +1
+ Misses       9519     9518       -1
  Partials      915      915

Impacted Files
Coverage Δ

pkg/logs/auditor/auditor.go
71.83% <0%> (+0.7%)
:arrow_up:


Helm chart installation failed - nil pointer evaluating interface {}.clientSecret

Hi. Had a need for a BRMS/DMN system within a new project, so thought I'd take GoRules for a spin. Was following the kubernetes quick start, here https://gorules.io/docs/developers/brms/deployment/kubernetes-helm - and have run into the following on the final helm deploy of GoRules:
Error: INSTALLATION FAILED: template: gorules-brms/templates/secrets.yaml:13:16: executing "gorules-brms/templates/secrets.yaml" at <.Values.brms.sso.oauth2.clientSecret>: nil pointer evaluating interface {}.clientSecret

While we have a resident instance of OIDC via Keycloak, this was initially a local deployment to demonstrate PoC, and as such I have no specific need (locally) for SSO. Is this an unmentioned pre-requisite for installation?
Can I disable SSO, if so?

Closing. Upon reflection of writing this, I noticed that SSO.oauth2 vars within values.yaml were commented out. Uncommenting fixes the issue.

@loki-sinclair-hdruk Great to hear. If you face any issues or have any questions feel free to reach us at<EMAIL_ADDRESS>

Also @loki-sinclair-hdruk just a note, please refer to the latest version here: https://hub.docker.com/r/gorules/brms/tags (1.13.0 is the latest).


Avoid iterating metrics in container while adding to it

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Instead of using this, we decided to go with a lock-based change: https://github.com/apache/beam/pull/13526


Cannot have two HTML5 backends at the same time

Describe the bug
I use different react-table draggable in different react-tabs
My Index.js contains:
import { HTML5Backend } from 'react-dnd-html5-backend';
import { DndProvider } from 'react-dnd';

ReactDOM.render(
   <DndProvider backend={HTML5Backend}>
      <BrowserRouter basename={baseUrl}>
         <App />
      </BrowserRouter>,
   </DndProvider>,
  rootElement);

each time I navigate into my components insinde  and come back to the component with the react-table inside react-tabs, this following error is triggered:
HTML5BackendImpl.js:423 Uncaught Error: Cannot have two HTML5 backends at the same time.
    at HTML5BackendImpl.setup (HTML5BackendImpl.js:423)
    at DragDropManagerImpl.handleRefCountChange (DragDropManagerImpl.js:21)
    at Object.dispatch (redux.js:222)
    at HandlerRegistryImpl.addTarget (HandlerRegistryImpl.js:101)
    at registerTarget (registration.js:3)
    at registerDropTarget (useRegisteredDropTarget.js:23)
    at commitHookEffectListMount (react-dom.development.js:19731)
    at commitLifeCycles (react-dom.development.js:19787)
    at commitLayoutEffects (react-dom.development.js:22803)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)

I also try those workaround:

issue#3119
issue#1558

But both doesn't solve my problem
Expected behavior
I would like to change tab without trigger this error, I am unable to use it without having this error.
Desktop (please complete the following information):

OS: Win10
Browser: Chrome Version 89.0.4389.114 (Build officiel) (64 bits)
Version: ["react-dnd": "^14.0.2", "react-dnd-html5-backend": "^14.0.0"]

I found a way that fix the problem but it's not satisfying:

Downgrade react-dnd and react-dnd-html5-backend to the same version used by our version of react-sortable-tree (11.1.3)
create a file like dnd-context.js:import React, { useRef } from 'react';
import PropTypes from 'prop-types';
//import { createDragDropManager } from 'dnd-core';
import { DndProvider } from 'react-dnd';
import { HTML5Backend } from 'react-dnd-html5-backend';

//const DNDManager = createDragDropManager(HTML5Backend);
export const GlobalDndContext = (props) =>
{
   //const manager = useRef(DNDManager);
   return <DndProvider backend={HTML5Backend} key={1}>{props.children}</DndProvider>
}

GlobalDndContext.PropTypes = { children: PropTypes.node };

export default GlobalDndContext;

In index.js that render <App/>:ReactDOM.render(
   <GlobalDndContext>
     <BrowserRouter basename={baseUrl}>
       <App />
     </BrowserRouter>
  </GlobalDndContext>,
rootElement);

Help source: MJGang answer, milban answer

I found a way that fix the problem but it's not satisfying:

Downgrade react-dnd and react-dnd-html5-backend to the same version used by our version of react-sortable-tree (11.1.3)
create a file like dnd-context.js:import React, { useRef } from 'react';
import PropTypes from 'prop-types';
//import { createDragDropManager } from 'dnd-core';
import { DndProvider } from 'react-dnd';
import { HTML5Backend } from 'react-dnd-html5-backend';

//const DNDManager = createDragDropManager(HTML5Backend);
export const GlobalDndContext = (props) =>
{
   //const manager = useRef(DNDManager);
   // the following line solve the problem only with key property
   return <DndProvider backend={HTML5Backend} key={1}>{props.children}</DndProvider>
}

GlobalDndContext.PropTypes = { children: PropTypes.node };

export default GlobalDndContext;

In index.js that render <App/>:ReactDOM.render(
   <GlobalDndContext>
     <BrowserRouter basename={baseUrl}>
       <App />
     </BrowserRouter>
  </GlobalDndContext>,
rootElement);

Help source: MJGang answer, milban answer

Thanks for the suggestion! I use ^10.0.2 for react-dnd and react-dnd-html5-backend and it works fine.
but why key={1}? how does it solve the issue? also, why not key={Math. random()}?

@ffan0811 I have absolutely no idea why key={1} solve the problem, and it works too with Math.random() but as I try first with 1 and it were working, I let it.

i tried like above, but still same error, any way to fix it, it take me along time

@vitrinh282 Have you other component that use react-dnd ? And what version do you use, and in the case of you have component use it... what version too ?

if (window.__isReactDndBackendSetUp) {
window.__isReactDndBackendSetUp = false
}

关联 https://github.com/react-dnd/react-dnd/issues/3257
一般都是嵌套了两个  试试  context={window}

const myFirstId = 'first-DnD-Containier';
const mySecondId = 'second-DnD-Containier';
export const DndWrapper = React.memo((props) => {
const [context, setContext] = useState(null);
useEffect(() => {
setContext(document.getElementById(props.id))
},[props.id])
return context ? (
<DndProvider backend={HTML5Backend} options={{ rootElement: context}}>
{props.children}

) : null;
});
export default function App() {
return (

);
}

Happens in my project too, when react-dnd is used in multiple forms and more than one of them is rendered at the same time

I'm having this issue too. I tried every solution that could find, but nothing works.
This footgun makes react-dnd basically unusable².

I'm also having this issue in our project

This is extremely frustrating. Just had users report this error in production. I now have to remove ract-dnd 😞

I am now trying to circumvent this problem. The basic idea is:

create a HTML5Backend only once
save it in an appropriate place (in my case: as volatile state in the mobx store)
when a component needs a HTML5Backend:

check if there is one in the store. If true: use it
if false: create one and save it in the store

These are the changes I made in our project: https://github.com/barbalex/apf2/commit/4011e3d30b35c57ba41b679d5222e779d02cb722

I think this may be manifesting in https://github.com/sanity-io/hierarchical-document-list as a totally broken experience when trying to drag and drop a hierarchical document.

The answer is here!
https://github.com/react-dnd/react-dnd/issues/3257#issuecomment-1239254032

I did it like this:  adding a key that is a random number

I did it like this:  adding a key that is a random number

I did it like this:" " adding a key that is a random number


properly get native asset price when calculating gas price

What is the purpose of the change

In the bridging UI certain assets were not returning Skip quotes because it was failing to get the gas asset price. This updates the SkipBridgeProvider to successfully get this price.
One example is depositing USDC.axl from Ethereum.
ClickUp Task
ClickUp Task URL
Brief Changelog

Fix SkipBridgeProvider quote functionality

Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected
Documentation and Release Note
No user-facing behavior changes.

@thal0x I'm closing this PR since this was resolved on #2778


Make Transform Handle movable even if Input.simulateMouseWithTouches disabled

Add getPos() and GetMouseButton(Up, Down)Expl(), so if a mouse click or movement is recognized, it will use that, else fallback to touch.
I'm making an open-source cross-platform Unity game, which needed keyboard, mouse, and touch support. The way we achieved that is to disable simulateMouseWithTouches, but that made this package unusable. So I of course forked this repository, then modified it to account for that.

Thank you for your effort. However, I won’t be merging this PR due to the following reasons:

Instead of duplicating functions like getPos(), create a static utility class that can be reused across the project.
To handle input differences (mouse vs. touch), conditional compilation would be more efficient than mixing input logic. Take a look at: https://docs.unity3d.com/Manual/PlatformDependentCompilation.html
Local functions add unnecessary overhead and reduce code maintainability. Standard methods are more suitable.
I plan to decouple input handling from the Transform Handle Manager, so adding more input functions here doesn’t align with that vision.

I value the work you’ve put in and encourage you to revise these changes based on this feedback.


[Request] Remove Non-Player chat bubbles

Like the title says, but there are multiple dimensions to this request that can be considered.
It might be a tall order, but possibly a mod to just remove any NPC or monster chat bubbles from appearing at all? Like the Ctrl+N function, but without removing the name of the monster/NPC or other player's chat bubbles/names, and also having it separate from the Ctrl+N function so that the option to toggle off names/other player's chats is still possible.
If that's not possible to keep it separate from the Ctrl+N function, then would it be possible to change the Ctrl+N function to remove chat bubbles but not names?

I'm not sure how to do this myself, but I do have some info for people that might.
NPCs have an underscore at the beginning of their name (that the client removes for display), I don't remember of this applies to monsters or not, if not I don't know if there's anything else obvious about them to set them apart.  Could do a racial ID check, 10001 and 10002 are human players for example, should be able to whitelist players outside of roleplay quests.


[Bug]: Unsupported value: 'messages[0].role' does not support 'system' with this model.

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
Run anything with o1-preview
There was an unexpected error while running the agent
litellm.BadRequestError: AzureException BadRequestError - Error code: 400 - {'error': {'message': "Unsupported value: 'messages[0].role' does not support 'system' with this model.", 'type': 'invalid_request_error', 'param': 'messages[0].role', 'code': 'unsupported_value'}}

OpenHands Installation
Docker command in README
OpenHands Version
openhands:0.12
Operating System
WSL on Windows
Logs, Errors, Screenshots, and Additional Context
Ubuntu nor Docker had any errors in the logs.
UI Error Message:
There was an unexpected error while running the agent
litellm.BadRequestError: AzureException BadRequestError - Error code: 400 - {'error': {'message': "Unsupported value: 'messages[0].role' does not support 'system' with this model.", 'type': 'invalid_request_error', 'param': 'messages[0].role', 'code': 'unsupported_value'}}

Thanks @twhite54! It seems that you're running through Azure. Could you try running the following program, replacing the key with your Azure key?
import litellm

messages = [
    {"role": "system", "content": "Respond in pirate speak."},
    {"role": "user", "content": "What is 2+2?"},
]

response = litellm.completion(
  api_key="sk-XXX",
  model="azure/o1-preview",
  messages=messages,
)

print(json.dumps(response.model_dump(), indent=2))

If this fails, then it's probably a problem that should be reported directly to LiteLLM: https://github.com/BerriAI/litellm/
If it works, then we'll need to investigate further, as it may be an error on our side.

I think litellm has fixed this a while ago. Please reopen or add a new issue if it happens again.


Fatal internal error v1.2.5

Getting "fatal internal error". Error log says: [Full log attached]
2017-05-01 20:25:04 ERROR: CheckProofOfWork(): nBits below minimum work
2017-05-01 20:25:04 ERROR: ReadBlockFromDisk: Errors in block header at CBlockDiskPos(nFile=0, nPos=537812)
2017-05-01 20:25:04 *** Failed to read block
2017-05-01 20:25:08 scheduler thread interrupt
2017-05-01 20:25:08 Shutdown: In progress...
2017-05-01 20:25:08 StopNode()
2017-05-01 20:25:08 Shutdown: done
debug.log.docx

This error shows an issue with reading/writing the databases that Bitcoin Classic maintains.
From the log it seems you use microsofts 'onedrive' which is likely the reason it failed.
The initial error was this the reason the client shut down the first time;
2017-05-01 20:10:52 Unable to open file C:\Users\peter\OneDrive\BTC\blocks\blk00000.dat
2017-05-01 20:10:52 ERROR: WriteBlockToDisk: OpenBlockFile failed
2017-05-01 20:10:52 *** Failed to write block

You should have better luck running the full node while using your local hard drive.

Closing this issue due to inactivity.


[HOLD for #26141] [$500] Android- IOU-When user changes Stop address, the Request money amount is not updated

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch app
Tap profile icon
Tap Workspaces
Tap any Workspace
Tap Reimbursements
Tap Track distance
Enter Rate and Unit
Tap Save
Navigate back to LHN
Tap Fab
Tap request money
Tap distance
Tap Start and select an address
Tap Finish and select an address
Tap Add stop
Tap Finish and select an address
Tap next
Select a workspace
Note the distance details and request money amount is correct (15.39*2=₹30.78) i. e shown as ₹30.77
Tap back to distance money request page
Tap Stop
Replace the entered address with a new one
Tap next
Select a Workspace
Note the distance field and request money amount (9.68*2=₹19.36)

Expected Result:
When user changes Stop address, the Request money amount should be updated based on new distance.
Actual Result:
When user changes Stop address, the Request money amount is not updated. The distance amount(15.39*2=₹30.78) before changing address is shown even after changing the address.
For new distance when address changed (9.68*2=₹19.36) , but still old amount ₹30.77 is displayed.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/464e7837-cbd6-40a0-ab51-1edbc6b623e8
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team / @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693984012665899
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f82f14ed7e096782
Upwork Job ID:<PHONE_NUMBER>206653952
Last Price Increase: 2023-09-15

Have posted this before,
https://expensify.slack.com/archives/C049HHMV9SM/p1693984012665899

Proposal
Please re-state the problem that we are trying to solve in this issue.

Amount is not recalculated when the distance is changed.

What is the root cause of that problem?

The shouldCalculateDistanceAmount flag is not set to true when the distance is changed. due to the props.iouAmount === 0 condition.

What changes do you think we should make in order to solve the problem?

We can simply remove the shouldCalculateDistanceAmount flag and replace it with props.isDistanceRequest.

Keeping the shouldCalculateDistanceAmount flag doesn't make sense anymore since we are always calculating the amount when its a distance request.

This will solve two problems:

The amount will be recalculated when the distance is changed.
The amount will be recalculated when the rate is changed.

What alternative solutions did you explore? (Optional)

N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
distance - Amount isn't recalulated on changing waypoints
What is the root cause of that problem?
In the code below, the shouldCalculateDistanceAmount is true only when props.iouAmount === 0
this is good when we calculate the amount for the first time in const formattedAmount =
But when we re-calculate the amount in the useEffect we stop re-calculate by it, because shouldCalculateDistanceAmount is true only on the first time.
https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L173-L188
What changes do you think we should make in order to solve the problem?

keep props.iouAmount === 0 in shouldCalculateDistanceAmount condition, I think it intended because it is good to only calculate amount once here, then use props.iouAmount which calculated by the useEffect (will fix in step 2).

https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L176-L179

replace the condition and deps in the useEffect to re-calculate the amount when any of its deps change, and the updated amount will pass to formattedAmount in props.iouAmount

useEffect(() => {
    // if (!shouldCalculateDistanceAmount) {
    if (!props.isDistanceRequest) {
         return;
    }

    const amount = DistanceRequestUtils.getDistanceRequestAmount(distance, unit, rate);
    IOU.setMoneyRequestAmount(amount);
}, [props.isDistanceRequest, distance, rate, unit]);

What alternative solutions did you explore? (Optional)
N/A

@dukenv0307 @jeet-dhandha @ahmedGaber93
Did you explore an alternative involving using useMemo (to calculate the amount) in tandem with useEffect (to call setMoneyRequestAmount), re-solving this problem cleanly? Is there some catch with that?

@ahmedGaber93

keep props.iouAmount === 0 in shouldCalculateDistanceAmount condition, I think it intended

This is a good point, I asked here

If we keep props.iouAmount === 0 in shouldCalculateDistanceAmount, the formattedAmount that is used to display in the UI will not be updated when the distance is changed.

No, it will work fine after update useEffect to
useEffect(() => {
    // if (!shouldCalculateDistanceAmount) {
    if (!props.isDistanceRequest) {
         return;
    }

    const amount = DistanceRequestUtils.getDistanceRequestAmount(distance, unit, rate);
    IOU.setMoneyRequestAmount(amount);
}, [props.isDistanceRequest, distance, rate, unit]);

The useEffect will call IOU.setMoneyRequestAmount(amount) which change the props.iouAmount that will update the formattedAmount without recalculating it because shouldCalculateDistanceAmount now is false and will use  props.iouAmount that updated by use effect
https://github.com/Expensify/App/blob/1eafc7dff1cb609e72a97d6f1d1993a2bf22aaa6/src/components/MoneyRequestConfirmationList.js#L177

This is a good point, I asked here

I remember I read before the amount can be editable manually by user in MoneyRequestConfirmationList.js, but we temporarily disable this feature.
So I think shouldCalculateDistanceAmount with props.iouAmount === 0 maybe added for that, to prevent reset the amount by recalculating it after manually edit it and use props.iouAmount.
Let us wait the answer here.

@cubuspl42 Re-post proposal from https://github.com/Expensify/App/issues/27051
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect Amount after updating distance rate
What is the root cause of that problem?
https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L173
We only calculate the amount if the props.iouAmount === 0. So when the rate is changed, we don't re-calculate the amount
What changes do you think we should make in order to solve the problem?
I think props.iouAmount === 0 condition is added to reduce the redundant computation.
In here
https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L173-L188
we should remove the shouldCalculateDistanceAmount variable and to avoid redundant re-calculate we can create a new variable called amount in a useMemo and use it instead of calling getDistanceRequestAmount function
this is demo code change
const amount = useMemo(() => DistanceRequestUtils.getDistanceRequestAmount(distance, unit, rate), [distance, unit, rate])
const formattedAmount = CurrencyUtils.convertToDisplayString(
        props.isDistanceRequest ? amount : props.iouAmount,
        props.isDistanceRequest ? currency : props.iouCurrencyCode,
);

useEffect(() => {
        if (!props.isDistanceRequest) {
            return;
        }
        IOU.setMoneyRequestAmount(amount);
}, [props.isDistanceRequest, distance, rate, unit, amount]);

What alternative solutions did you explore? (Optional)

Hey everyone, we've got a response from the original author of the PR. It seems that @ahmedGaber93 had good intuition here.

@cubuspl42 what do you think of using Onyx store to save this value? are this option available?
// IOU.js > add new function to set the value.
function setIsDistanceAmountOverridden(isDistanceAmountOverridden) {
    Onyx.merge(ONYXKEYS.IOU, {isDistanceAmountOverridden});
}

// IOU.js > edit this function and add isDistanceAmountOverridden rest value.
function resetMoneyRequestInfo(id = '') {
    const created = currentDate || moment().format('YYYY-MM-DD');
    Onyx.merge(ONYXKEYS.IOU, {
        ...
        isDistanceAmountOverridden: false,
    });
}

// in NewRequestAmountPage.js > navigateToNextPage
if(isDistanceRequestTab) {
    IOU.setIsDistanceAmountOverridden(true);
}

// in MoneyRequestConfirmationList.js > shouldCalculateDistanceAmount
const shouldCalculateDistanceAmount = props.isDistanceRequest && !props.isDistanceAmountOverridden;

result
https://github.com/Expensify/App/assets/41129870/ad71b235-fc85-454e-a273-12ad3daf7a41

Everyone, the thread in the original PR is still open, but for now I'll assume that the safe option is to keep being open to a possibility of manual edition of the IOU amount by the user.
@ahmedGaber93 I actually marked your original proposal as non-matching the expectations; although you gave attention to the === 0 check, your code still would override the manually entered amount. Please correct me if I'm wrong.

@ahmedGaber93 That sounds like something that would need to be done, but I'm actually negotiating to postpone this work for a later time.

@cubuspl42 Re-post proposal with new expectation
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect Amount after updating distance rate
What is the root cause of that problem?
Let's see here
https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L181-L187
When coming MoneyRequestConfirmationList we will set iouAmount. Besides, we only calculate the amount if the props.iouAmount === 0. So we don't re-calculate the amount after iouAmount is set
What changes do you think we should make in order to solve the problem?
We shouldn't update iouAmount when coming MoneyRequestConfirmationList, We only update iouAmount If user confirm the request or the user manually edits amount (it is temporary as mentioned here)
To do that, we need to move the code to update iouAmount
https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L181-L187
to confirm function
https://github.com/Expensify/App/blob/b11bddc054f54bb46d5fb5aaf05e25b8a7df7faf/src/components/MoneyRequestConfirmationList.js#L333
To safe, in MoneyRequestConfirmationList we can use DistanceRequestUtils.getDistanceRequestAmount(distance, unit, rate) as fallback of iouAmount
Result

@CortneyOfstad If you don't mind, I would suggesting rising this issue to $1k
I justify this by:

we had to clear up the requirements
some contributors already suggested multiple solutions
the internal engineer decided to extend the scope of this issue to handle re-addition of currently disabled feature
what seemed like a strictly UI-related problem in the beginning we'll likely need a solution which adds new persistent state and, possibly, a beta

@cubuspl42 Could you help to check my proposal here? As this comment, @tgolen is implementing another PR to allow the user to edit the amount. With my solution, we can fix the issue separately

@DylanDylann Whatever the solution we go with, I would feel much more confident if we test this after the manual edition feature is re-enabled. I believe this issue is not so critical so it can't stand it.
@CortneyOfstad Could we hold this on https://github.com/Expensify/App/pull/26141?

Sounds good @cubuspl42! Going to update the title and adjust the frequency of the issue from daily to weekly 👍

@izarutskaya I reported this bug first
https://expensify.slack.com/archives/C049HHMV9SM/p1693858446228419

I suggest re-evaluating the behavior of this with the changes of https://github.com/Expensify/App/issues/22715 which I am hoping to have merged today or tomorrow. A lot of this code was refactored in my PR.

@tgolen You're right. We'll do that once it gets merged.

It is merged now 👍

Hi @tgolen @cubuspl42 we have a new blocker. Let's see my below video
https://github.com/Expensify/App/assets/141406735/45e6f0a5-693d-497e-9603-3d1e2311250b
It is caused by this PR: https://github.com/Expensify/App/pull/27797 when go to the confirmation page we add reportID into id of iou field. It makes the iou is re-set here
https://github.com/Expensify/App/blob/9795ba4451a15446a9f731d5baab2a54b11f5d78/src/libs/actions/IOU.js#L2274
So the transactionID is changed and the data is lost

I think you can disregard that. All of the shouldReset logic is going to go away as I refactor this in https://github.com/Expensify/App/issues/26538

@CortneyOfstad So we can hold this issue until https://github.com/Expensify/App/issues/26538 is done

The functionality is changing under our feet. It might turn out that the bug goes away after the related PRs are gone... Still, let's track it here. Let's change the HOLD to https://github.com/Expensify/App/issues/26538.

Not overdue — on hold

@CortneyOfstad Actually, the current HOLD status is outdated.

Thanks for the heads up @cubuspl42! Changed the title 👍

No update 👍

FFR, we're still holding on https://github.com/Expensify/App/issues/26538

No update — still waiting on https://github.com/Expensify/App/issues/26538

Heading OoO until Oct. 25, so reassigning BZ to keep an eye on things while I am out 👍

Still on hold

I'm back @garrettmknight so I can take this back — thanks for holding down the fort while I was gone!

Still on-hold — not overdue 👍

Still on-hold. Going to change this to weekly

For what it's worth, there's an active movement in the issue we're holding on

Not overdue 👍

(Holding on https://github.com/Expensify/App/issues/26538)

Going to switch this to monthly as the priority on the holding issue is Low 👍

@CortneyOfstad  The PR of https://github.com/Expensify/App/issues/26538 is merge.  Please remove the hold label
@cubuspl42
Updated proposal

I approve the proposal by @DylanDylann
I think we should ensure that the code is commented properly or even consider extracting 0 as a constant like iouUserSetAmount, to ensure that this logic is clear for people reading it in the future.
C+ reviewed 🎀 👀 🎀

Our first pull request, https://github.com/Expensify/App/pull/33397, got reverted because of the regression.
@DylanDylann is working on a solution.

Payment is not set until the 17th 👍

Payments have been completed!
Payment Summary
@cubuspl42 paid $250 as C+ (-50% due to regression) in Upwork
@DylanDylann paid $250 as Contributor (-50% due to regression) in Upwork

@cubuspl42 any update on the checklist above? Thanks!

@CortneyOfstad Waiting for payment.
I'm the issue reporter.
Thanks.

The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/25707

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/25707/files#r1322653311

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for additional discussion

Determine if we should create a regression test for this bug.

Up to the QA team

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Create new distance request
Fill start point and end point
Go to confirmation page and observe the amount field
Click back to the distance page and edit waypoint
Go to confirmation page and verify that the amount is updated

Thanks @cubuspl42!
@ashimsharma10 any update on the proposal so I can get the payment processed? Thanks!

@CortneyOfstad I'm not able to apply.
my upwork is this : https://www.upwork.com/freelancers/~018a92cf13e1e88eed

@Cornerstone  accepted, thank you! .


Throw MisconfigurationError on unknown mode

Potential closes  https://github.com/PyTorchLightning/pytorch-lightning/issues/5252
When an unknown mode is passed to EarlyStopping or ModelCheckpoitn, raise a misconfiguration error instead of just a runtime warning.

Hello @alanhdu! Thanks for updating this PR.

In the file tests/callbacks/test_early_stopping.py:

Line 310:1: E302 expected 2 blank lines, found 1

Hello @alanhdu! Thanks for updating this PR.

In the file tests/callbacks/test_early_stopping.py:

Line 310:1: E302 expected 2 blank lines, found 1

@ydcjeff: Done (sorry for the delay -- I was out during the holidays)!
Rebased onto the latest master as well.

@ydcjeff: Done (sorry for the delay -- I was out during the holidays)!
Rebased onto the latest master as well.

@alanhdu mind rebase on PyTorchLightning:release/1.2-dev 🐰

@alanhdu mind rebase on PyTorchLightning:release/1.2-dev 🐰

Rebased to fix the merge conflict.

Rebased to fix the merge conflict.


Change app-port to 5001 to match README

Change the SDK example to run the app on 5001 to match the dapr run command in the README

Thanks Nick!  @greenie-msft .  The port is in a few places in index.js including default initializer and the comment at top.  how about we change the readme instead? to match the code? :)


🐛 [BUG]: Fit view doesn't work if tab is not in focus while VueFlow is loading

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
When you refresh the page and switch to another tab while VueFlow is loading, then come back, the view is not centered (fitView is not working). I suppose the window bounding box might not be correct while the tab is not focused.
Expected Behavior
When you refresh the page and switch to another tab, and come back, the view should be centered if fitView is called.
Steps To Reproduce

Refresh page - wait until old page is unloaded and new page starts loading
Switch tab while VueFlow is loading
The view is not centered (fitView is not working)

https://github.com/user-attachments/assets/5b9f48b4-b1d3-4b8c-840d-b62c8d53c5ae
Relevant log output
No response
Anything else?
No response

This isn't really a bug of VueFlow but one of the way the docs are using the repl.
Can't work around this atm so I'm closing it since it's a no-fix issue.
Might switch to remote examples with a sandbox link at some point though, which would resolve the issue.

It's not only in the docs. We're seeing this behaviour consistently in n8n, which has a bit longer async loading times.
I'm able to reproduce it using a simple example here: https://stackblitz.com/edit/sb1-ndokqv?file=src%2FApp.vue

Mhhh okay, I’ll give it a look once I’m back from my vacation since I don’t have my Mac with me and can’t really check it now.
I’ll reopen the issue for now :)

I can't reproduce this issue locally.
Any chance you're updating the container size after loading is done and VueFlow is mounted?
If the container size changes by the time fit view is triggered it would only try to fit around the size of the view that it recognized during the mounting process and not afterwards, which I'm thinking is what happens (same thing happens in the docs for example ^^).

Also another thing I notice in the repro is that you use vueFlowInstance.fitView() but from what I can tell there is no variable available called vueFlowInstance.
Either you use sth like this:
const { fitView } = useVueFlow();

onMounted(async () => {
  await new Promise((resolve) => {
    setTimeout(() => {
      nodes.value = initialNodes;
      edges.value = initialEdges;

	  setTimeout(() => {
		fitView();
	  }, 0)
      resolve();
    }, 1000);
  });
});

or you try simply setting <VueFlow fit-view-on-init ...>

@alexgrozav ping :)

Hey! Trying the suggestion out now 🙏

Yup, the suggestion works. Wasn't able to reproduce. The workaround I came up with is this one:
onNodesInitialized(() => {
    fitView();
});

I suppose it's pretty much the same. Thanks a lot for taking the time to look into it!


strange 'cannot read property 'update' of null' issue

this is a strange thing i have come across lately in kha and also KS - but using the same code 1 comes up with an error message
Uncaught TypeError: Cannot read property 'update' of null
now i copied the exact code and placed in a new/clean project folder, then it started working. i have no idea as to why this is happening. i even deleted the build folder that was created, but does not help the error
here are 2 project [zipped], which are the same, but somehow one does not build. really weird
KITTENCULL.zip
MOVINGENTITY.zip

In MOVINGENTITY you call updatePlayer before loadAll is called - hence _player is still null.
KITTENCULL works because it does not contain any assets, so the loadEverything call finishes instantly.


Hotfix issue with nav-container attributes

Incorporates fixes from @BarakaAka1Only in #600

Still without a Mac but :+1:


Create legal user is natural endpoint

Hey @jalik! Thanks for building this package :+1:
I'm using it on a client's project and I just noticed that the endpoint you use for the creation of legal user is the natural endpoint.
https://github.com/jalik/jalik-mangopay/blob/master/api/user.js#L42
I'm forking your package in order to fix this and of course to help you in this work in progress! :) I'll do my some modifications if I see any trouble with it. I'll do a PR later !
Cheers

@xavizalote thank you for spotting the bug and sorry for that. Do you want to propose a PR or do I fix it myself ?

Well, here it is: #2 :+1:
I've don't see any other trouble, the package works great!

Thx, I am gonna publish it now.


Revert GridSplitter size for default theme

What does the pull request do?
Change minimum size for Default (Simple) theme to 1
What is the current behavior?
Minimum size is 6 pixels, which breaks old apps
Fixed issues
Fixes #4412

@danwalmsley