Use of native controls is impossible for now?

class Button : Widget is not contains ability to draw native Button (its onDraw only draws background and displays text).
This works for SDL platform, for consoles etc. But if we need to show native widget it is unacceptable.

DlangUI not uses native controls.

I think it doesn't make sense to add native controls. And it's too hard to implement.
Custom theme can help to make almost native look&feel.

And it's too hard to implement.

Why?

Custom theme can help to make almost native look&feel.

Every GUI library provide almost native look&feel...

Why?

Use of native widgets needs not only a lot of time to wrote but also a lot of resources for maintain. For example simple situation - new version of native widgets api and a lot of things needs be rewritten and tested again.
But that makes more work also to you when you write app using widgetset that use native widgets for different platforms. You need then test every platform and make a lot of ifs because some things looks good on platform A  but looks bad on platform B.
Support for that app will be more complicated too (example: casual people often don't know what system they have and then try explain how to open file when file dialog looks different on different platforms).
Native widgets on different platforms has its own limitations so you need implement/maintain a list of features that are cross platform and emulate some thing on others.
Big widgetsets do the same - for example QT draws widgets itself.

Use of native widgets needs not only a lot of time to wrote but also a lot of resources for maintain. For example simple situation - new version of native widgets api and a lot of things needs be rewritten and tested again.

My proposal is add to ability to implement native controls (as external platform).

Support for that app will be more complicated too (example: casual people often don't know what system they have and then try explain how to open file when file dialog looks different on different platforms).

I am isn't understan this case

Native widgets on different platforms has its own limitations so you need implement/maintain a list of features that are cross platform and emulate some thing on others.

Trying to implement this will not cost anything for dlangui community if native platform will be added as external.

I am isn't understand this case with file dialog

I have just too big experience with users and theirs problems ;) Open files and lost files is very frequent software support case.

I am not GUI guru :-)
I just can't understand this case with file open dialogs

I just can't understand this case with file open dialogs

When user of your multiplatform app calls to you and ask "How to open file?" or "Where are my files?"
Is it simpler to answer when file dialog in your app looks the same on all platform.
The same with other app functions. When your app looks the same on platform A and B its easier to explain someone how to do something in your app. You don't need ask "What platform you use?"
Creating docs its easier too. So for me not native widgets have advantages.

When user of your multiplatform app calls to you and ask "How to open file?" or "Where are my files?"
It's simpler to answer when file dialog in your app looks the same on all platform.

Why?! File open dialog it is just file open dialog.

That's why programmers are bad testers :) For you it's easy but not for all. For some users using files is difficult. And when you start help you need first know is it Windows 10? Windows XP? Linux? or MacOS? Because it looks different you can't just say "click second icon on left panel then go to xyz folder". That's only example but from real life :)
BTW. When you want 100% native look&feel maybe better is just use native widgets. Cross platform solution will always do something in other way. So it can be 99,999999% but never 100% native look&feel.
Or better make you own theme that will looks attractive/marketable for your users on all platforms. See how anti viruses software look:) Native widgets look is not "sexy" these days.

That's why programmers are bad testers :) For you it's easy but not for all. For some users using files is difficult. And when you start help you need first know is it Windows 10? Windows XP? Linux? or MacOS?

Why this is important? I heard that some systems (ios) isn't allow users to work with files. In this case we can just leave assert(0) at base Widget class and isn't implement native control for it.

Because it looks different you can't just say "click second icon on left panel then go to xyz folder".

I don't understan what do you mean

BTW. When you want 100% native look&feel maybe better is just use native widgets.

This is same as I am propose!

Cross platform solution will always do something in other way. So it can be 99,999999% but never 100% native look&feel.

But currently dlangui provides only 80% look&feel from native.

File dialog is a special thing. I actually would prefer dlangui to provide option to create a native dialog on Windows and OSX. (Linux and other freedesktops don't have native one)
The problem with native widgets in general is that it's harder to get the same behavior on all platforms, it also means additional maintenance cost. And the last one - I guess dlangui just was not planned to support native widgets from the start.
Actually dlangui has many other problems right now. And I would not consider native widgets as high priority.

Linux and other freedesktops don't have native one

Linuxes have excellent KDE and GTK file dialogs: with previews, path line search, mkdir, etc

Maybe it will be useful to extract abstract windows-layouts-widgets engine from dlangui with ability to use it separate from dlangui? I just realized that I really just like this thing which automatically arranges widgets on windows.

Probably method like Platform.showFileDialog() may be useful.
For some platforms, it can be implemented using native dialogs.
Native dialogs and native widgets are different things.
Dialogs are much easier to implement than widgets.

Closing.
Probably it makes sense to create issue for implementing native dialogs for some platforms.

For future googlers: it is possible to implement full widgets hierarchy (with addition of any custom widgets) by using native OS components. Just use external platform implementation with addition of custom methods to dlangui widgets by openmathods.
More details you can found in https://github.com/denizzzka/formoshlep source


Add src files in build

What do you think about adding src files to the build? I often browse library code when trying to understand the library, but with the current build setup I only get some minified code.

The newer release build files are not minified https://github.com/poppinss/indicative/releases/tag/v7.2.0


Add option to support NativeScript event handling

In the exploration of using preact with nativescript I had to adjust eventHandling to get events working.
In this pull request I added a boolean called nativeScript in the options. I also added a test to cover the correct behaviour if said option is truthy.
I am unsure wether:

platform specific code like this should even be in preact
this way to solve this is mergeworthy but it seemed like the most uninitrusive solution for exisiting behaviour to me

Thank you for your PR 👍 As @developit said, we're only focusing on the DOM for now.


How can I get slide index in on-change?

This is the code I am using.
<swiper [config]="adslide" class="ad-slider" #adSlider (indexChange)="onIndexChange($event)" [initialize]="isBannerLoaded">

                  keyboard_arrow_right                 keyboard_arrow_left              </swiper>
adslide: SwiperOptions = {
pagination: '.swiper-pagination',
autoHeight:true,
preventClicks: false,
preventClicksPropagation: false,
spaceBetween: 0,
speed: 600,
};

Not sure I understand the question you already have the (indexChange) which is the way.

it was not working in angular2-useful-slide , Now I updated to ngx-swiper-wrapper and it is working. Thanks for the quick reply. :)
I have another doubt, I want to loop swiper for multiple swiper in one page. But next and previous button working only for first slider. Can you help me to sort out it ? Thanks

You need to either use different classes or give the HTMLElement directly since the logic how Swiper searches those components with class is bit inaccurate.

but the swipers coming from loop (*ng-for) how can I give multiple classes and how do I manage it in ts file ?

You can define the used classes in the config object. So you just use different config for each swiper and then use different class names for the components.

So I should loop the config in the ts file right?

If you generate the swipers with ngFor loop you can use the index, so something like:
`
<ng-container *ngFor="......; let i">
<swiper [config]="{nextButton: 'swiper-button-next-' + i}">
...

`
I will be soon releasing new version that uses Swiper 4.x and I am trying to fix this need for different class names so that everything would just work. But the above should work in the mean while.

I just released new pre-release 5.0.0-5 which uses Swiper 4.x and at least with that I did not need to use different classes when using multiple swipers.

Thank you sconix


Issue with Cocoapod 1.0 and DKImagePickerController.bundle

I'm having issues with this pod when building for distribution/release, stack trace comes to:
DKImageResource.swift  Line 15
static NSBundle.imagePickerControllerBundle() -> NSBundle

This is the line where DKImagePickerController.bundle is loaded, however, with optimizations enabled the bundler is not included or doesn't match any bundle included in the app.
I noticed we're using .resource https://github.com/zhangao0086/DKImagePickerController/blob/master/DKImagePickerController.podspec#L13 where we're supposed to be using resource_bundles instead, does that have something to do with this?
Anyway the pod works in locally but not for distributing apps, any tips?

Looks like this issue has been fixed in 1.0.1

@bithavoc Let me know if you have any questions 😄

我也有這個問題
已經是1.0.1了 降到之前可以正常使用的本版也不能用了


Introduce KEGG ID conversions to BridgeDB service

Added support for KEGG ID conversions to BridgeDB service.
Close #101.

Did you test it? Maybe we can add a single unit test and convert a single kegg number or so?

No, we removed all tests which actually rely on the contents of a service response, I think we shouldn't go back to that.


Dynamic Injection of Connection Parameters for Modbus RTU Slave

This pull request introduces a new feature that allows dynamic injection of connection parameters into the Modbus RTU Slave node. This enhancement enables users to configure connection settings like slaveId, baudRate, dataBits, stopBits, and parity programmatically through message payloads, rather than setting them statically in the node configuration.
Changes Introduced

Users can now pass a message payload containing connection parameters (slaveId, baudRate, dataBits, stopBits, parity, and connection) to dynamically configure the Modbus RTU Slave.
The feature supports both establishing and closing connections dynamically.
Added validation to ensure that incoming payloads have the correct structure and data types for the connection parameters.
Implemented error handling to manage incorrect or incomplete configuration data gracefully.

Hey! Sorry for the delay. Thanks for the PR! I will merge it soon.


Support both alpha & beta RBAC API

Use rbac.authorization.k8s.io/v1beta1 if the cluster supports it, otherwise fall back to rbac.authorization.k8s.io/v1alpha1.
Published as v0.7.1 and confirmed still working in K8s v1.5, but I don't yet have a K8s v1.6 cluster to test against. Recommend we wait for @peterrosell (or other) to deploy & confirm before merging.

Fixes #253

Minikube supports 1.6, does it work on that?

I'm wondering how we should handle the versioning of this. It should be along with the version of the Prometheus operator I feel, that would mean it shouldn't be v0.7.1 ... maybe it should be entirely independent then to not confuse people. Wdyt @fabxc @mgoodness @mxinden ?

Totally forget about minikube. Tested & working!

Re: versioning, current best practice is to de-couple the chart from the upstream application. Only requirement is that it follow SemVer. I've jumped around in my own repo without causing any complaints so far, but we should stabilize before we publish to an "official" CoreOS repo.

Then I would like to start versioning with a preview release version like v0.0.1 for now and bump to v0.1.0 when we have everything in place we think we want for a start and then bump minor versions when we bump minor versions of the Prometheus Operator, makes sense?

SGTM

generally lgtm


htlcswitch: clean up test resources and temporary files

Hi there, first time contributor :wave:
Change Description
Fixes #6707
The htlcswitch tests were creating temporary database files but failing to close them or remove them.
We fix this by making it obvious when temporary db files are created, and cleaning up those resources where necessary in the tests.
Steps to Test
go test -tags dev ./htlcswitch

Afterwords, confirmed in /tmp that no temporary files were left behind by the test suite.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[x] Tests covering the positive and negative (error paths) are included.
[x] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[x] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[x] Commits follow the Ideal Git Commit Structure.
[x] Any new logging statements use an appropriate subsystem and logging level.
[x]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

Noticing there are a few other resources which aren't cleaned up, beyond the scope of #6707. Putting this in draft until I can clean that up as well.

Fixed. Now all temp files created in htlcswitch are closed & cleaned up.

Hi there, first time reviewer 👋
tested ACK
My steps:
## Replicating issue on master
~/lnd/htlcswitch# git checkout master
~/lnd/htlcswitch# rm -r /tmp/*db*
~/lnd/htlcswitch# go test -tags dev
~/lnd/htlcswitch# ls /tmp | grep db | wc -l
# channeldb total tmp files: 237
# switchdb total  tmp files: 147
# total tmp files: 384

# Running again to see if tmp files stack even more (they do)
~/lnd/htlcswitch# go test -tags dev
~/lnd/htlcswitch# ls /tmp | grep db | wc -l
# channeldb total tmp files: 504 (267 more this run)
# switchdb total tmp files: 330 (183 more this run)
# Not sure why same run can generate different amounts of tmp files

## Checking if PR fixes issue
~/lnd/htlcswitch# git checkout pr/kklash/6832
~/lnd/htlcswitch# rm -r /tmp/*db*
~/lnd/htlcswitch# go test -tags dev
~/lnd/htlcswitch# ls /tmp | grep db | wc -l
# Returns nothing, looks like it works
# Execution time takes about the same time as master branch ~125s

Rebased on master, and updated initSwitchWithTempDB to use t.TempDir() in the same fashion as #6710.

this might have already (partially) been addressed by https://github.com/lightningnetwork/lnd/pull/6710.

This PR is still needed to ensure test file descriptors are closed, as that was the original intent behind issue #6707, which motivated this PR. Even if the temp directory is removed, file descriptors pointing to files inside that directory might still be open.

@yyforyongyu Glad to help! Rebased & squashed :)

@yyforyongyu Should i submit review changes with fixup commits, or always keep everything squashed into one commit? (docs suggest the former)

@yyforyongyu Should i submit review changes with fixup commits, or always keep everything squashed into one commit? (docs suggest the former)

Since GitHub tracks the diffs of force-pushes, it's okay to always squash.

Roger, changes re-squashed


last: 1045 -> 1047

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/last/versions.
meta.description for last is: '"Genomic sequence aligner"'.
meta.homepage for last is: '"http://last.cbrc.jp/"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1047 with grep in /nix/store/zjlar6wr9n947nmhkcrzrf9xpchdvrs8-last-1047

directory tree listing: https://gist.github.com/4762ab0b35ae31b3ec700e23aafaeed7

du listing: https://gist.github.com/299677ff3eef88e9b83791f5d2a0c04f

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
last
tebreak

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zjlar6wr9n947nmhkcrzrf9xpchdvrs8-last-1047 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A last https://github.com/r-ryantm/nixpkgs/archive/dae266aa6627151e51a4f7e2cfca4d6ace7a3030.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zjlar6wr9n947nmhkcrzrf9xpchdvrs8-last-1047
ls -la /nix/store/zjlar6wr9n947nmhkcrzrf9xpchdvrs8-last-1047/bin

cc @jbedo for testing.

lgtm


autocomplete does not work

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Version: 1.64.2 (system setup)
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:28.252Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043
OS Version: Win 10

Steps to Reproduce:

Installed Python extension and  IntelliSense extension
autocomplete does not work

/extPython


Update exception handling

Add two kind of exceptions:

AnonymizerRuleNotApplicableException (inherit from AnonymizerConfigurationErrorsException)
AnonymizationProcessFailedException (Runtime exception)
We plan to  support skipping the second exception in the future.

Generalization methods will throw these two exceptions, while other methods will not throw exceptions for now.

Let's update the description of the PR accordingly (exception names, etc).


TIM-116 feat: Animation on Burger Icon (Mobile)

#63  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tamrivera05 and the rest of your teammates on  Graphite


[docs] Add TS demo for DynamicCSSVariables

[x] I have followed (at least) the PR section of the contributing guide.

TS demo for DynamicCSSVariables #14897

@netochaves Much appreciated, thanks!


SAK-29144 Allow hidden/disabled to be enabled/disabled.

This changes allows a deployment to disable functions of the Page Order Helper tool.

okay +1


pkgs.haskell.packages.ghc7103.vector-algorithms is not building

Issue description
pkgs.haskell.packages.ghc7103.vector-algorithms is not building on current master (or in the nixos-unstable channel).
The package pkgs.haskell.packages.ghc801.vector-algorithms  does build, however.
Steps to reproduce
nix-build . -A pkgs.haskell.packages.ghc7103.vector-algorithms

Leads to
Setup: At least the following dependencies are missing:
mtl -any, mwc-random -any

These dependencies seem to be needed for benchmarking only.
Technical details

System:
NixOS 16.03.909.f199be0 (Emu)
(but same thing on other systems)

Nix version: (run nix-env --version)
nix-env (Nix) 1.11.2

Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
master & nixos-unstable

It doesn't seem to build on the stable channel either.
Paging @peti ..

Please, disregard the above message, nixos-16.03 channel is fine -- a configuration issue creeped in.

If someone submits a PR to fix this I'd be happy to merge it.

This bug still exists in master, does it not?

@LnL7 took care of it with b8a3174

@obadz coincidentally I was looking into it this morning and just filed an issue with cabal2nix:
https://github.com/NixOS/cabal2nix/issues/238


Adding GABSync functionality

Providing extra container with z-push-GABSync run every 15 minutes to keep GAB for Kopano Outlook Extension in sync

I have added some additional lint checks. Please rebase.

making new PR


Set bazel version to 5.4.0

We used to take the latest and when when bazel released 6.0.0 it broke us. It's better to set a specific version so we won't break in such cases.

@liranr23 if you refer to the fact that 5.4.0 is specified then yeah, we should eventually upgrade to 6.0.0, but I think it's a good idea in general to set an explicit version rather than using the latest - updated to commit message

@liranr23 once https://github.com/kubev2v/forklift/pull/59 is ready, we can update USE_BAZEL_VERSION to v6


Allow user to define their own test-id's for components

Describe the feature in detail (code, mocks, or screenshots encouraged)
I am testing my app and currently the testId is already defined for modal, I'd like this to be customizable.
So I'd like the modalSettings type to allow for passing in a test id for playwright, or just allow restprops to be passed through.
What type of pull request would this be?
Enhancement
Provide relevant links or additional information.
No response

@Hugos68 we actually implement test ids for all components as part of our standard practice. This is done for Vitest, but Playwright should be able to utilize these as well. The format is as follows:

You'll just need to query by the data-testid.
Additionally every component has ID-like classes if you need to navigate through the component template. We call them "selector classes", since they're primarily geared towards creating global style selectors:
https://www.skeleton.dev/docs/styling#global-styles-overrides
For custom modals you have full control over the template within the modal. I'd recommend you set your own IDs there.
I could -maybe- see a need to set a unique ID per the standard (alert, confirm, prompt), but given there's only ever one modal displayed at a given time, an ID might be a bit redundant for testing purposes.

@Hugos68 we actually implement test ids for all components as part of our standard process. This is done for Vitest, but Playwright should be able to utilize these as well. The format is as follows:

You'll just need to query by the data-testid.
Additionally every component has ID-like classes if you need to navigate through the component template. We call them "selector classes", since they're primarily geared towards creating global style selectors: https://www.skeleton.dev/docs/styling#global-styles-overrides
For custom modals you have full control over the template within the modal. I'd recommend you set your own IDs there.
I could -maybe- see a need to set a unique ID per the standard modals (alert, confirm, prompt), but given there's only ever one modal displayed at a given time, an ID might be a bit redundant for testing purposes. At that point it sounds like you're testing our implementation rather than your app.

@Hugos68 we actually implement test ids for all components as part of our standard process. This is done for Vitest, but Playwright should be able to utilize these as well. The format is as follows:

You'll just need to query by the data-testid.
Additionally every component has ID-like classes if you need to navigate through the component template. We call them "selector classes", since they're primarily geared towards creating global style selectors: https://www.skeleton.dev/docs/styling#global-styles-overrides
For custom modals you have full control over the template within the modal. I'd recommend you set your own IDs there.
I could -maybe- see a need to set a unique ID per the standard modals (alert, confirm, prompt), but given there's only ever one modal displayed at a given time, an ID might be a bit redundant for testing purposes. At that point it sounds like you're testing our implementation rather than your app.

That makess sense for my use case yeah but does that cover all testing software, and maybe these testing id's can be exposed on the documentation? Because I had to dig through the source code to find them. Testing is become more and more doable for frontend apps so maybe something to consider in the future.

Sorry for the incredibly late reply on this issue Hugos, but between the Store launch and v2 my time has been very limited lately!

and maybe these testing id's can be exposed on the documentation
Unless Sveld updates to support something like this, we don't have a way to automate this. Which means it would have to be done manually. We go out of our way to avoid manual documentation, because while it's simple for one component. Keeping this data accurate for an entire library becomes a BIG lift. So this is not likely to happen. The source will remain the best source for this info. But we do provide the "source" button on each doc page for quick access.

Testing is becoming more and more appropriate for frontend apps so maybe something to consider in the future.
User should never be testing third party libraries. It's our responsibility to test our components and features to ensure they work. I understand you're talking about testing in a more e2e manner in your own app, using our features, but want to make sure the where that line should be drawn.

That said, we do provide ids on the top level of each wrapping parent in component. Access the children of any target element should be trivial for any testing suite (ex: .avatar img). I'm not sure we can really do any more to improve this situation beyond what's provided now.
If you (or anyone else) is interested in improving the testing story in Skeleton though, the literal single oldest ticket in our backlog is related to this. Unfortunately neither myself or any volunteers have made headway on it. But I do think it's something important that should be revisited in the near future:
https://github.com/skeletonlabs/skeleton/issues/150


feat: linting yaml files

This PR adds yaml linting, as well as linting all yaml files in the project.
See yamllint for more information.

After thinking a while I am not think it is worth to add this to this template (I want to keep it pretty minimalistic). You can still add an issue.
Personally, I like https://github.com/igorshubovych/markdownlint-cli very much but I decided to not add it to this template.

For sure, I get it.
Thanks anyway for your awesome project :100:


Does ctc requires a blank character ?

Does in the alphabet I have to add a blank character to have ctc working properly ? Or can I use the same alphabet as the same one foe the attention prediction?

Note: I'm not one of the authors
If you look at the CTCLabelConverter class, you can see a blank character is added to the character dictionary.

How to recognize blank between two English words?
for my current model, if I input one English sentence then the output will concatenate all the English words together. for example:
inputed image:

recognized result:

A------l-ll-t-h--e--r-e-c--o--g-n-i-tiio---n--a-c-cc--ur-a--c-i-e-s---o--n--t-h---e => Alltherecognitionaccuraciesonthe

So how to recognize the blank between two English words?
Thank you so much.


Added a test for color contrast

This adds a new test to check the contrast of all colors against a background color.
It works via checking all color properties against a fixed background color which is set via a comment for the current scope. The background color can be set for a whole file or just a specific rule. The whole file is processed from top to bottom, so it's also possible to override a background color within the scope. Example:

/* @contrast-background: white */

.token.foo {
    color: white; /* this will not pass the check */
}

/* @contrast-background: black */

.token.foo {
    color: white; /* this will pass the check */
}
.token.bar {
    /* @contrast-ignore */
    color: black; /* this will be ignored */
}

@media (something) {
    /* Set the background color only within the @media rule.
     * @contrast-background: white
     **/
    .token.bar {
        color: black; /* pass */
    }
}

The actual color checking is implemented using color which conveniently can calculate the contrast for us and even supports LAB color mode.
For each low-contrast color, it will output the line of the low-contrast color, the contrast and a suggest color with the same hue but higher contrast (corrected in LAB color space). (See the ensureContrast function.)
That being said: I'm not a designer and have no idea about color, so the correction might not be optimal.

I didn't fix any low-contrast colors as there are quite a few to fix.
Here's the current output of the test (only 2/8 themes pass):

  Contrast
    1) - ./themes/prism.css
    2) - ./themes/prism-dark.css
    √ - ./themes/prism-funky.css
    3) - ./themes/prism-okaidia.css
    √ - ./themes/prism-twilight.css
    4) - ./themes/prism-coy.css
    5) - ./themes/prism-solarizedlight.css
    6) - ./themes/prism-tomorrow.css

  2 passing (489ms)
  6 failing

  1) Contrast
       - ./themes/prism.css:
     AssertionError: There are 4 contrast issues:

Line 75: Background #FFFFFF: The color slategray has a contrast of 4.05 < 4.5. Use #697988 (4.50) instead.
Line 103: Background #FFFFFF: The color #690 has a contrast of 3.43 < 4.5. Use #508400 (4.50) instead.
Line 123: Background #FFFFFF: The color #DD4A68 has a contrast of 4.00 < 4.5. Use #D34060 (4.50) instead.
Line 129: Background #FFFFFF: The color #e90 has a contrast of 2.28 < 4.5. Use #AE6500 (4.50) instead.
      at Context.<anonymous> (tests\contrast-test.js:143:12)
      at processImmediate (internal/timers.js:456:21)

  2) Contrast
       - ./themes/prism-dark.css:
     AssertionError: There are 5 contrast issues:

Line 68: Background #4D4033: The color hsl(30, 20%, 50%) has a contrast of 2.69 < 4.5. Use #C4A98E (4.50) inst
Line 85: Background #4D4033: The color hsl(350, 40%, 70%) has a contrast of 4.04 < 4.5. Use #DB9DA7 (4.50) ins
Line 109: Background #4D4033: The color hsl(350, 40%, 70%) has a contrast of 4.04 < 4.5. Use #DB9DA7 (4.50) in
Line 114: Background #4D4033: The color #e90 has a contrast of 4.40 < 4.5. Use #F09B05 (4.50) instead.
Line 130: Background #4D4033: The color red has a contrast of 2.52 < 4.5. Use #FF9061 (4.50) instead.
      at Context.<anonymous> (tests\contrast-test.js:143:12)
      at processImmediate (internal/timers.js:456:21)

  3) Contrast
       - ./themes/prism-okaidia.css:
     AssertionError: There are 2 contrast issues:

Line 57: Background #272822: The color slategray has a contrast of 3.67 < 4.5. Use #7F8FA0 (4.50) instead.
Line 73: Background #272822: The color #f92672 has a contrast of 3.93 < 4.5. Use #FF4283 (4.50) instead.
      at Context.<anonymous> (tests\contrast-test.js:143:12)
      at processImmediate (internal/timers.js:456:21)

  4) Contrast
       - ./themes/prism-coy.css:
     AssertionError: There are 6 contrast issues:

Line 114: Background #FDFDFD: The color #7D8B99 has a contrast of 3.43 < 4.5. Use #697785 (4.50) instead.
Line 139: Background #FDFDFD: The color #2f9c0a has a contrast of 3.51 < 4.5. Use #0D8900 (4.50) instead.
Line 147: Background #FFFFFF: The color #a67f59 has a contrast of 3.62 < 4.5. Use #956F4A (4.50) instead.
Line 155: Background #FDFDFD: The color #1990b8 has a contrast of 3.61 < 4.5. Use #007FA6 (4.50) instead.
Line 160: Background #FDFDFD: The color #e90 has a contrast of 2.25 < 4.5. Use #AD6400 (4.50) instead.
Line 166: Background #FFFFFF: The color #a67f59 has a contrast of 3.62 < 4.5. Use #956F4A (4.50) instead.
      at Context.<anonymous> (tests\contrast-test.js:143:12)
      at processImmediate (internal/timers.js:456:21)

  5) Contrast
       - ./themes/prism-solarizedlight.css:
     AssertionError: There are 8 contrast issues:

Line 35: Background #FDF6E3: The color #657b83 has a contrast of 4.13 < 4.5. Use #5F757D (4.50) instead.
Line 89: Background #FDF6E3: The color #93a1a1 has a contrast of 2.48 < 4.5. Use #677474 (4.50) instead.
Line 107: Background #FDF6E3: The color #268bd2 has a contrast of 3.41 < 4.5. Use #0076BB (4.50) instead.
Line 117: Background #FDF6E3: The color #2aa198 has a contrast of 2.93 < 4.5. Use #007F77 (4.50) instead.
Line 121: Background #FDF6E3: The color #657b83 has a contrast of 4.13 < 4.5. Use #5F757D (4.50) instead.
Line 128: Background #FDF6E3: The color #859900 has a contrast of 2.97 < 4.5. Use #647A00 (4.50) instead.
Line 133: Background #FDF6E3: The color #b58900 has a contrast of 2.98 < 4.5. Use #926B00 (4.50) instead.
Line 139: Background #FDF6E3: The color #cb4b16 has a contrast of 4.27 < 4.5. Use #C64712 (4.50) instead.
      at Context.<anonymous> (tests\contrast-test.js:143:12)
      at processImmediate (internal/timers.js:456:21)

  6) Contrast
       - ./themes/prism-tomorrow.css:
     AssertionError: There are 2 contrast issues:

Line 72: Background #2D2D2D: The color #6196cc has a contrast of 4.42 < 4.5. Use #6297CD (4.50) instead.
Line 123: Background #2D2D2D: The color green has a contrast of 2.68 < 4.5. Use #42A832 (4.50) instead.
      at Context.<anonymous> (tests\contrast-test.js:143:12)
      at processImmediate (internal/timers.js:456:21)

I added this to the 2.0 milestone. My thinking is these tests are a good idea, but we should bring the themes into compliance if we're going to add them (no good adding failing tests). Because these could be considered a breaking change (cuz these are changes in the theme), we could add the tests along with the (suggested or otherwise) color changes needed to bring them into compliance.

v2.0 seems reasonable to me. A few themes (e.g. Solarized Light) have to be substantially changed in order to pass the tests.

Great idea to improve contrast, looking forward to it.
A suggestion:  Consider aiming for a contrast ratio of 4.6 instead of 4.5, to avoid rounding errors that would make web browsers flag a color combination as low contrast.  (It seems like Stack Overflow uses approx. 4.6 or higher for their syntax highlighting, for example).
See the explanation in the first "Note" at this link (quoted below), which says 4.5 is a lower threshold, and computed values shouldn't be rounded up to 4.5:

The 3:1 and 4.5:1 contrast ratios referenced in this Success Criterion are intended to be treated as threshold values. When comparing the computed contrast ratio to the Success Criterion ratio, the computed values should not be rounded (e.g., 4.499:1 would not meet the 4.5:1 threshold).

I'm bringing this up because, in the "Details" dropdown of the original post, the first suggested color combination (#697988 on #FFFFFF) has a contrast ratio of 4.47 instead of 4.50 (maybe a rounding error?):
Line 75: Background #FFFFFF: The color slategray has a contrast of 4.05 < 4.5. Use #697988 (4.50) instead.

Here's a link to a contrast checker for this color combination.  See screenshot below.  Chrome dev tools also shows 4.47 for this color combination.

Might be worth mentioning on the site which themes pass the contrast checks?

I just noticed that for the twilight theme, .punctuation inside a .tag adds opacity .7 which means the contrast fails the check.  Removing that opacity allows it to succeed (as per the text of the tag)


Remove the https -> http hack when operator properly supports https in various cases

Remove the hacks that forces http even if apihost is https:
$ grep -n  https *.go
k8s_utils.go:117:               if host == "https://pending" || host == "" {
k8s_utils.go:162:       //TODO remove temporary workaround to replace https with http
k8s_utils.go:163:       wskPropsEntries["APIHOST"] = strings.ReplaceAll(apihost, "https", "http")
k8s_utils_test.go:35:                   "apihost":                  "https://localhost:3232",
setup_wskprops.go:60:   apihost = strings.ReplaceAll(apihost, "https:", "http:")

I am working on another version of nuv that rebuild without hacks.


Posts are not generated in production mode

Hello everyone!
Everything works fine in dev environment (gatsby develop) but when I build for production there is an issue. When I run gatsby build and then gatsby serve every post page is not generated. You can't open any post, you get a 404.
In fact at build time it prints this warning:
warning The GraphQL query in the non-page component "/Users/anagstef/repos/test-gatsby-build/src/templates/post.js" will not be run.
Exported queries are only executed for Page components. Instead of an exported
query, either co-locate a GraphQL fragment and compose that fragment into the
query (or other fragment) of the top-level page that renders this component, or
use a <StaticQuery> in this component. For more info on fragments and
composition, see http://graphql.org/learn/queries/#fragments and for more
information on <StaticQuery>, see https://next.gatsbyjs.org/docs/static-query

Happy to help with this, if I can do it (I have no experience with GraphQL).

@chmac Just tried that and nothing changed :(

@anagstef Have you changed the WordPress site to your own URL? Are you using authentication?
I've just retested this repo, without making any changes, and yarn build && yarn serve gives me the expected result. I can see multiple posts, no error messages.
Is your repo public? Can you share the URL to see your code? I'm at a loss as to what to suggest otherwise I'm afraid.

@anagstef Ignore my last message, on a fresh install, I see the same bug locally. Investigating now.

@chmac Yes, I was talking about a fresh install from this repo, no changes at all. I think it worked a few days ago. Maybe some dependency update broke something?

@anagstef Arg, bug was in 638379a42d0829f1eba71433ada5fadd10206822. Added filtering but forgot to add the required field for the filter. The fix is one line in ef8ccc14185c34a09383110dc3f2e572c6e0ca46.
Hopefully that change works. I'll close this issue now, but if it doesn't, please reopen and I'll look again. Thanks for taking the time to report the issue, I appreciate it.


[docs] Reference use-wagmi for vue

What is the type of issue?
No response
What is the issue?
I would like to shout out to the amazing work done by unicape that maps very closely the wagmi react hooks to vue. Repo here: https://github.com/unicape/use-wagmi.
Perhaps it can be mentioned somewhere in the docs?
Where did you find it?

Feel free to create a new show and tell discussion thread for now! Maybe in the future, we can highlight community projects, like we did in awesome-wagmi. The challenge with lists is it's often a lot of work to keep them up-to-date.


Old links for "DeFi Wallet desktop app" on downloads/

https://github.com/DeFiCh/defichain.com/blob/5ba09bc1c1407eb9bc2bc21e39083703cdc47460/layouts/downloads/single.html#L79
where:
defichain.com/downloads/
what:

"DeFi Wallet desktop app"

"Mac"
"Windows"
"Linux (AppImage)"

resolve to the old desktop app
https://github.com/DeFiCh/defi-app/releases -> https://github.com/DeFiCh/defi-app-old/releases
should be
https://github.com/DeFiCh/app/releases
no wonder, that there are that many old nodes... I should get a bounty in DFI for telling you ;)

Thanks @swiesend for the report. Fix for this issue has been completed.


Not working in Lumen 5.2

The problem is that in Lumen 5.2 (for some reason) Laravel\Lumen\Application no longer implements \Illuminate\Contracts\Foundation\Application.
This causes the providers LucaDegasperi\OAuth2Server\OAuth2ServerServiceProvider and LucaDegasperi\OAuth2Server\Storage\FluentStorageServiceProvider to fail, since they expect the $app to implement that contract.
I would say that the best solution is to remove that type hint $app var from the several functions and use $this->app instead, as that is the most common usage.
I am trying that now and PR in case of success.
Thanks!

Done.
In case anyone needs this, the fork is fixed and tested here.

Thanks for this, I'll check the PR.

That fix looks wrong to me.

You should just change the contract to use the container contract.


Laravel 5.8 Shift

This pull request includes the changes for upgrading to Laravel 5.8. Feel free to commit any additional changes to the shift-13083 branch.
Before merging, you should:

Checkout the shift-13083 branch
Review all pull request comments for additional changes
Update your dependencies for Laravel 5.8
Run composer update (if the pre-scripts fail, add --no-scripts)
Thoroughly test your application

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

:x: Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.8 configuration files and merge any changes:

[ ] config/app.php
[ ] config/mail.php
[ ] config/services.php

:warning: Laravel 5.8 introduced a set of AWS environment variables to help consolidate configuring the various AWS services. You should rename the following native environment variables to their new names. While you don't have to rename any custom environment variables you created for AWS services, you should consider following the new naming convention.

SQS_KEY to AWS_ACCESS_KEY_ID
SQS_SECRET to AWS_SECRET_ACCESS_KEY
SQS_REGION to AWS_DEFAULT_REGION
SES_KEY to AWS_ACCESS_KEY_ID
SES_SECRET to AWS_SECRET_ACCESS_KEY
SES_REGION to AWS_DEFAULT_REGION

:x: Laravel 5.8 has a dependency for php of ^7.1.3. You have a modified dependency for php in your composer.json. You should review your dependency and ensure it meets the new version requirement.

:warning: Laravel 5.8 changed several of the core contracts with new implementations and methods. You should review the Upgrade Guide for more detail on these respective changes:

Illuminate\Contracts\Validation\Validator

Shift found references to these contracts within:

[ ] app/Http/Controllers/Auth/RegisterController.php

:warning: If you are using JSON values in your MySQL or MariaDB tables, the query builder now returns unquoted JSON values in Laravel 5.8.

:information_source: Laravel 5.8 changed the minimum requirement for password length from 6 characters to 8 character. While this change is not required, you should consider this opportunity to review the password policy for your application.

:warning: If you are using SQLite, the oldest supported version in Laravel 5.8 is SQLite 3.7.11. Laravel recommends running SQLite 3.8.8 or higher.

:warning: The Nexmo and Slack notification channels have been extracted into first-party packages. To use these channels in your application, run the following command to require the respective packages:
composer require laravel/nexmo-notification-channel
composer require laravel/slack-notification-channel

:warning: Laravel 5.8 correctly pluralizes multi-word model names ending in a word with an irregular pluralization. For example, Laravel 5.7 incorrectly pluralized the table name for the UserFeedback model as user_feedbacks. Laravel 5.8 correctly pluralizes this table name as user_feedback.
If you were relying on this irregular pluralization, you should rename your table name or set the $table property for your model. If you were overriding this behavior by setting the $table property, you may remove it and now rely on the framework.

:information_source: Shift noticed you have additional namespaces in your project. You should consider using the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

:tada: Congratulations, you're now running the latest version of Laravel. You can now use some of the micro Shifts to ensure your app is fully upgraded and following the Laravel recommended and community practices.

Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
Laravel Fixer automates many of the suggestions found by the Analyzer and Linter.
Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.


Sling Rewriter Pipelines use deprecated generator / serializers

Hey guys,
When I have a look at the presentations (@justinedelson that would be your mastering of the sling rewriters) and the docs, I see that it states you should use the generatorType htmlparser and serializerType htmlwriter. But looking at the javadocs they seem to be deprecated:
https://helpx.adobe.com/experience-manager/6-3/sites/developing/using/reference-materials/javadoc/com/day/cq/rewriter/htmlparser/HtmlParser.html
Are there other generators / serializers that should be used now? There is a nasty bug in the htmlparser and I'm not sure what will happen when I create a daycare ticket for it, they might state its deprecated code...
Greets
Roy

@royteeuwen As near as I can tell, the htmlparser & htmlwriter components are not actually the classes in the JavaDoc, but are non-API classes.

Hey @justinedelson ,
Can you please elaborate before closing? If i look at the source code it shows the following:
@Deprecated
@Component(factory="com.day.cq.rewriter.pipeline.Generator/htmlparser")
public class HtmlParser
and
@Component(label="CQ Rewriter HTML Parser Factory", description="HTML Parser Factory for CQ Reqriter", metatype=true, immediate=true)
@Service({GeneratorFactory.class})
@Properties({@org.apache.felix.scr.annotations.Property(name="pipeline.type", value={"htmlparser"}, propertyPrivate=true), @org.apache.felix.scr.annotations.Property(label="Additional Tags to process", name="htmlparser.processTags", cardinality=100, value={"HEAD", "/HEAD"}, description="Add additonal tags which need to be processed { default tags processed: A,IMG,AREA,FORM,BASE,LINK,SCRIPT,BODY,HEAD}"), @org.apache.felix.scr.annotations.Property(label="Preserve Camel Case", name="htmlparser.preserveCamelCase", boolValue={false}, description="Preserve Camel Casing of HTML Attributes")})
public class HtmlParserFactory
public class HtmlParserFactory
implements GeneratorFactory
{
private static String[] includedTags;
private static boolean preserveCamelCase;
private static final String INCLUDE_TAGS = "htmlparser.processTags";
private static final String PRESERVE_CAMELCASE = "htmlparser.preserveCamelCase";
public Generator createGenerator()
{
final HtmlParser parser = new HtmlParser(includedTags, preserveCamelCase);
new Generator()

...

@royteeuwen please do not post proprietary source code in a public Github comment. I close this because it isn't an issue for ACS AEM Commons -- we don't reference either the deprecated or the non-deprecated HtmlParser classes.
But to answer your question, the htmlparser generator is referring to com.day.cq.rewriter.processor.impl.HtmlParserFactory (at least on AEM 6.4). You can see this by looking at the Services web console plugin and using the filter (&(objectClass=org.apache.sling.rewriter.GeneratorFactory)(pipeline.type=htmlparser))

@justinedelson Okey, sorry, that was not what I was going for. Sorry if I made an infringement of licensed code.
Anyways, seeing as the HtmlParserFactory uses deprecated code (yes, even in AEM 6.4). What do you use for html parser if its not that one?

The documentation recommends to copy the default pipeline configuration and edit it to suit, so that would be whatever AEM uses by default. If that is deprecated, it would have to be fixed in AEM (or maybe the deprecation was incorrectly done).


[RFC] Add a 'Create ticket' link to the AVG detail page

This is an RFC PR for the generate a bugreport link, a few things need to be considered.

Do we like the UI?
Do we want to link to be opened in a new tab?
Do we want to fill in more information in the summary/guidance?
Should the link_encode/add_bug_link code go in app.util?

And yes the code can be a lot nicer, maybe it should use a jinja template to create the bug description?

applied via 89482a2861127ac7ebca460c436074cc9a933110


Add Executable document toolbar

This PR adds a <stencila-executable-document-toolbar></stencila-executable-document-toolbar> component as well as several related fixes.

Closing in favour of https://github.com/stencila/designa/pull/75


Unable to get host resolution to work with echoserver example

Would be awesome to get some help with a hiccup of mine!
When I don't define the hostname (host) the ingress routes as expected (meaning wildcard), but when I specify the hostname to route.me.com (for example) and add an entry to my lovely local /etc/hosts file - it doesn't route!
Would appreciate help on this!
The echoserver example project is deployed with the following configuration:
apiVersion: v1
kind: Namespace
metadata:
  name: echoserver
---
apiVersion: v1
kind: Service
metadata:
  name: echoserver
  namespace: echoserver
spec:
  ports:
    - port: 80
      targetPort: 8080
      protocol: TCP
  type: NodePort
  selector:
    app: echoserver
---

apiVersion: v1
kind: Service
metadata:
  name: echoserver
  namespace: echoserver
spec:
  ports:
    - port: 80
      targetPort: 8080
      protocol: TCP
  type: NodePort
  selector:
    app: echoserver
---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: echoserver
  namespace: echoserver
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: echoserver
    spec:
      containers:
      - image: gcr.io/google_containers/echoserver:1.4
        imagePullPolicy: Always
        name: echoserver
        ports:
        - containerPort: 8080
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: echoserver
  namespace: echoserver
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/tags: Environment=dev,Team=test
    alb.ingress.kubernetes.io/target-type: instance
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP":80}]'
    alb.ingress.kubernetes.io/success-codes: '200,404'
spec:
  rules:
    - host: echoserver.example.com
      http:
        paths:
          - path: /
            backend:
              serviceName: echoserver
              servicePort: 80

Output from kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-07T09:55:27Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.6-eks-d69f1b", GitCommit:"d69f1bf3669bf00b7f4a758e978e0e7a1e3a68f7", GitTreeState:"clean", BuildDate:"2019-02-28T20:26:10Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Hi, how did you setup your /etc/hosts? you need to map echoserver.example.com to the IP bind alb_DNS

@M00nF1sh Can't I simply direct towards the elastic ip?

Hi, you can direct it toward the elastic ips 😄


Add label to instructor field in section detail component

Currently, all form fields in the section detail component have labels except for the instructor field. Without a label, this form field is not read properly by screen readers.

Was this already resolved? I know the issue is shown as open but it looks like instructor does have a label.


Use enums for hash algorithm and use them in all messages

Codecov Report

Merging #53 (debac0e) into main (1c59105) will decrease coverage by 0.61%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   87.06%   86.44%   -0.62%
==========================================
  Files           8        8
  Lines         572      583      +11
  Branches      140      146       +6
==========================================
+ Hits          498      504       +6
- Misses         72       76       +4
- Partials        2        3       +1

Impacted Files
Coverage Δ

src/factories.ts
93.84% <66.66%> (-2.93%)
:arrow_down:

src/engine/index.ts
83.53% <71.42%> (-0.63%)
:arrow_down:

src/utils.ts
92.30% <85.71%> (-1.35%)
:arrow_down:

src/types/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c59105...debac0e. Read the comment docs.


Improve mobile usability #7

Fix CSS

@youngjun827 please, fix merge conflicts

Hey @youngjun827  I request you to create PRs from a new branch rather than main branch. To do that you can use the command git checkout -b <Your branch name>


Updates to App Launcher

use --pf-global--icon--FontSize--lg for the icon size
reduce height of expanded demo

:tada: This issue has been resolved in version 2.13.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Example of appScope

Could you please provide some examples of appScope? For now, it's too abstract term and I couldn't find any blog or examples what everything can be appScope.
Some other parts of the Graph API doc mention only AccessPackageCatalog as an example of appScopeId
/AccessPackageCatalog/{catalog id}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6e310667-fe92-98e7-9612-91ea27e7dcf0
Version Independent ID: f54ab59a-1f99-d23f-756d-03874fa857bb
Content: appScope resource type - Microsoft Graph v1.0
Content Source: api-reference/v1.0/resources/appscope.md
Product: applications
Technology: microsoft-graph
GitHub Login: @FaithOmbongi
Microsoft Alias: MSGraphDocsVteam

Thank you @MartinM85 for raising this issue.
@markwahl-msft , @DougKirschner - Can you assist here? Thanks.

I notice when creating role assignments, appScope is the only allowed object for access package catalog. Role assignments for the directory provider seems to only support directoryScope

Correct, example 4 of https://learn.microsoft.com/en-us/graph/api/rbacapplication-post-roleassignments?view=graph-rest-1.0&tabs=http#example-4-create-a-role-assignment-with-access-package-catalog-scope illustrates the use case where an appscopeid field is used when creating a role assignment.

@markwahl-msft If I want to request role activation for a user with access package catalog scope, I need to call
https://graph.microsoft.com/v1.0/roleManagement/entitlementManagement/roleAssignmentScheduleRequests and specify appScopeId
And there is no case to specify appScopeId when calling https://graph.microsoft.com/v1.0/roleManagement/directory/roleAssignmentScheduleRequests.
When calling https://graph.microsoft.com/v1.0/roleManagement/entitlementManagement/roleAssignmentScheduleRequests is there any role which requires directoryScopeId?
Maybe some remark that directory provider requires directoryScopeId and entitlementManagement provider requires appScopeId would be useful for developers.

Closing this issue in readiness for deactivation of GitHub issues. See this post for more information https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/9146.
I'm following up with @markwahl-msft on the doc update request relating to this statement "Maybe some remark that directory provider requires directoryScopeId and entitlementManagement provider requires appScopeId would be useful for developers."


SANTA-4A: Update Analyzers, fix warnings

SANTA-4

@DemeSzabolcs I might reroll these then to the values set in dev and suppress them for now. This in my mind really should cause problems as they are instantly populated with new List(). I check it tomorrow.

@DemeSzabolcs I might reroll these then to the values set in dev and suppress them for now. This in my mind really should cause problems as they are instantly populated with new List(). I check it tomorrow.

Suppressing them shouldn't be the first thing. Try to find a solution, ask on the dev channel, etc. Ask if it's a valid warning or not etc. If it's hard and you can't find a solution in a reasonable time, don't suppress them (so I can find them later), just set back every IList to List in this module and in the other modules like Events and in the main module too. You can easily find all of it with Ctrl + Shift + F, no need to reroll changes.

By rerolling I meant what you said that search and replace them


2 coffee BatchService separation

related to:

https://github.com/i-Cell-Mobilsoft-Open-Source/coffee/pull/661
https://github.com/i-Cell-Mobilsoft-Open-Source/frappee/pull/3
https://github.com/i-Cell-Mobilsoft-Open-Source/backend-sampler/pull/121

Compile-ok elhasaltak hozza, azt nézted?


add tests for sort_by_key function in FixedArray

Pull Request Test Coverage Report for Build 4085
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 80.526%

Totals

Change from base Build 4083:
0.04%

Covered Lines:
4375

Relevant Lines:
5433

💛  - Coveralls


Added logo route to home page

This route is very useful for any website specially for mobiles. If anybody want to move to home page, he should have to open drawer and then route. So this is must... in my opinion.
This is just my starting i see problems and solve them.. Thanks Team

This route is very useful for any website specially for mobiles. If anybody want to move to home page, he should have to open drawer and then route. So this is must... in my opinion.
This is just my starting i see problems and solve them.. Thanks Team

Makes sense!
Nice job @GoelVaibhav009 pointing this out


fixed problem in store remote categories

Coverage decreased (-0.02%) to 36.394% when pulling f90969546d54ba21ade5b8a5c2a427e0b737cfe0 on CON-4880 into 0bed22b07d20de10a45f4c0a4c7886a9662fa041 on master.

Coverage decreased (-0.02%) to 36.394% when pulling ff638c01bb99ad52cb97aa1b005f99f72fdcb9b7 on CON-4880 into 0bed22b07d20de10a45f4c0a4c7886a9662fa041 on master.

Coverage decreased (-0.02%) to 36.394% when pulling ff638c01bb99ad52cb97aa1b005f99f72fdcb9b7 on CON-4880 into 0bed22b07d20de10a45f4c0a4c7886a9662fa041 on master.

Coverage decreased (-0.02%) to 36.243% when pulling c2106b037e3063c52acb09c1ba7963765c0443e1 on CON-4880 into e02f184c8854e0c26790f016c04677e525ed0bca on master.


Add option to parse single objects at a time

This pull request is built on top of PR #194 and PR #195 (thus the commits for those branches are showing as well). If those PRs are not accepted but there is interest in this one, I can rebase this branch onto master.
This PR allows parsing one object at a time:
Normally, jsmn parses the entire input string. If multiple objects are present, it will parse all of them consecutively into the tokens array. If the last object is incomplete, jsmn returns JSMN_ERROR_PART, even if there were one or more complete objects before it. This can make parsing a stream of JSON objects difficult. The input reader must ensure the input buffer passed to jsmn ends on an object boundary.
This PR adds a new macro, JSMN_SINGLE, to provide a solution to this. When defined, jsmn will only parse one object at a time. Once it has parsed a complete object, it returns immediately, ignoring the rest of the input string. The parser state will be reinitialized, so to parse the next object, simply advance the input buffer pointer ahead by tokens[0].end and call jsmn_parse() again.

Apologize for the history rewrite. Rebased onto the latest changes from the pull requests this was built on top of.


Adds integration test

Whereabouts depends on Multus, which means that the integration test is deploying Multus as well.
Depends-On: https://github.com/canonical/whereabouts-rock/pull/8
Depends-On: https://github.com/canonical/k8s-test-harness/pull/9
Depends-On: https://github.com/canonical/k8s-test-harness/pull/10

Please use the k8s-test-harness now that we have it.

done

/hold


hyperlink of node_modules from .ts file to js modules without definition

VSCode Version: 1.17.0
OS Version: mac

Steps to Reproduce:
For example following code  var Kafka = require('node-rdkafka');.

When this code is in a js file, I can cmd+click to go to the index.js file in node_modules and hovering over shows definitions.
When this code is in a ts file, nothing happens when I hover to click. tsc compiles without any complaint so tsconfig.json should be fine.
I tried import * as Kafka from 'node-rdkafka' and it is the same behavior

here is tsconfig.json
{
    "compilerOptions": {
        "target": "es5",
        "lib": [
            "es2017"
        ],
        "outDir": ".dist",
        "sourceMap": true,
        "removeComments": false,
        "alwaysStrict": true
    }
}

Reproduces without extensions: Yes

This issue was moved to Microsoft/TypeScript#20182


DELETE /workflow/{workflowId}/remove

why I can not delete workflow when I used api " DELETE /workflow/{workflowId}/remove" ,return 204 not context,but when I  search all , it is exist.

This is because the workflow is archived in elasticsearch and the search functionality looks up the workflows in the archive as well. I've a PR which makes archiving optional. Please refer to https://github.com/Netflix/conductor/pull/381 for additional details


Add ability to disable pivot columns in select statement for many to many relationship "belong to many"

in belong to many relationship every query should include the aliased foreign keys of the pivot table, this may cause problems when using GROUP BY, suggest add function in builder to remove these columns in select statement
Thanks

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


getessaymaker.com is not available

This looks like a neat project, but when I went to try it out at getessaymaker.com, it appeared that the domain was not registered. Is this just an oversight?

Sorry it took so long to respond. It works great. Thanks!


Proxy fixes and UI tweaks

Changing the proxy updates both the global client and the API client.
Proxy is re-applied after app restart.
Port defaults to 80 when unspecified (instead of crashing).
Current proxy is pre-filled into the dialog and selected.

lgtm


[Chat]: Allow specifiying primary response language for Cody Chat

It seems like that by default Cody Chat seems to detect the display language of the system (or Visual Studio Code perhaps?) and response in that language (in my case it's zh_CN), but sometimes I may want to have Cody Chat defaults to using for example English for its response disregarding any display language sort of thing.
### Tasks

Hi @shanoaice. Thanks for bringing this to our attention. We have seen this issue with other languages (German).
@abeatrix do you want me to put together a list of other similar issues?


Make the { } on home page more visible

Currently, the { } on the home page surrounding the h2 titles are barely visible. I have changed the colour to something that increases the contrast and makes them more visible.

I don't think they need to be more visible, they don't mean anything.
I'd be OK with dropping the {}'s entirely, but I'm not sure what design thing they were supposed to fulfill initially.
Feel free to comment with any further insight, anyone, but for now I'm closing this.

I personally think they should either be removed or made at least a little more visible. At the moment they are kinda sitting on the fence and they kinda look out of place once you notice them.


Better technical documentation for API

Let's try and break up a way to make the new phases and hooks easier to understand.
Public API (for Tapable instance)
Public API for a plugin registered to an instance.
How each hook works
Explanation of evals in code
Description of Interceptors

@TheLarkInn Do we have a date for this or any reference material after the issue was created?

any updates? really hard to figure out the different between each hook.

I've created a simplified version of tapable so it's easier to understand the behavior for each hook: https://github.com/malcolm-kee/naive-tapable.
It's still a WIP as I have not implemented interceptor and object options, but should be good enough if you want to figure out what each hook do.


log line "NodePublishVolume failed at attempt NNNNN" repeated many times

I detected a pattern contributing to #563
In big log of #561 run-1, There are about 1.5 million lines, and about 0.3 million are
"NodePublishVolume failed at attempt NNNNN" where NNNNN rolls up to high numbers, max=209153
During one sampled second 14:40:06, there are 23551 lines about worker-1-volume-61:
~ $ grep "NodePublishVolume failed at attempt" log-pr561 |grep 14:40:06 |grep worker-1-volume-61 |wc
  23551<PHONE_NUMBER>301

But that volume is not the only one, at least one more different Volume has similar ongoing at same time and clocks 22817 attempts:
~ $ grep "NodePublishVolume failed at attempt" log-pr561 |grep 14:40:06 |grep worker-9-volume-62 |wc
  22817<PHONE_NUMBER>067

Means, the retry rate is quite high, like 23 kHz per volume, and 46 kHz overall during given second.

What is the error returned?
In many cases there is "all SubConns are in TransientFailure, latest connection error: connection closed"
In these cases the retry count rolls up to few thousands, like 5 or 6 thousands, and lasts for short time.
But there is also a case where retry count gets up to 208k and handling response has:
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.024141       1 nodeserver.go:126] NodePublishVolume request: VolID:worker-b3750ab271e8b5acd2ce36e30a4f76f8fb34373769c9bf2ea67\
bf837 targetpath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pmem-sanity-target.BCkKfJ/worker-1/target sourcepath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pmem-sanity-staging.aNnjMC/worker-1 re\
adonly:false mount flags:[] fsType: context:map["name":"worker-1-volume-61-289E24D3-8D2FC8EA"]
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.024179       1 pmem-exec.go:12] Executing: file -bsL /dev/ndbus0region0fsdax/worker-b3750ab271e8b5acd2ce36e30a4f76f8fb3437376\
9c9bf2ea67bf837
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.031763       1 pmem-exec.go:15] Output: Linux rev 1.0 ext4 filesystem data, UUID=23cdd964-747c-479b-8641-139567556175 (needs \
journal recovery) (extents) (64bit) (large files) (huge files)
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.031794       1 pmem-exec.go:12] Executing: blkid -c /dev/null -o full /dev/ndbus0region0fsdax/worker-b3750ab271e8b5acd2ce36e3\
0a4f76f8fb34373769c9bf2ea67bf837
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.034512       1 pmem-exec.go:15] Output: /dev/ndbus0region0fsdax/worker-b3750ab271e8b5acd2ce36e30a4f76f8fb34373769c9bf2ea67bf8\
37: UUID="23cdd964-747c-479b-8641-139567556175" BLOCK_SIZE="4096" TYPE="ext4"
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.034589       1 nodeserver.go:222] NodePublishVolume[worker-b3750ab271e8b5acd2ce36e30a4f76f8fb34373769c9bf2ea67bf837]: existin\
g: RO:false TargetPath:, mountFlags:[] fsType:ext4
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.034601       1 nodeserver.go:231] NodePublishVolume[worker-b3750ab271e8b5acd2ce36e30a4f76f8fb34373769c9bf2ea67bf837]: paremet\
ers do not match existing, return ALREADY_EXISTS
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: E0331 14:44:55.034622       1 tracing.go:23] GRPC error: rpc error: code = AlreadyExists desc = Volume published but is incompatible
[2020-03-31T14:44:55.414Z] pmem-csi-node-b7bmq/pmem-driver: I0331 14:44:55.036797       1 tracing.go:19] GRPC call: /csi.v1.Node/NodePublishVolume
[2020-03-31T14:44:55.414Z] Mar 31 14:44:55.062: INFO: worker-1-volume-61: NodePublishVolume failed at attempt 208776, will try again: rpc error: code = AlreadyExists desc = Volume published but is inc\
ompatible

Is it so that 1st pattern (few thousands) is actually a normal case, but we see a log stmt about retry that we should not print? Was log of retry changed in recent e2e change set?
But the 2nd case (208k retries) is different, there we could check does pmem-csi handle this case correctly. If "published but incompatible" response creates a retry loop which seem to go on for long time, is everything correct about it.
Also, is 23kHz rate for retries really justified, or could it be slower.
And can we reduce logging about it.

Looks like some of the assumptions ("operation is slow" and "unlikely to fail") did not hold in https://github.com/intel/pmem-csi/blob/da7c9991944d55dd349385656497f7cd69b8429c/test/e2e/storage/sanity.go#L894-L913
After a lost connection, each call will fail quickly and quite often. But the question remains why this happened in that run.
One thing that has changed recently is that the tests run multiple times inside a single e2e.test invocation. If for some reason we are left with dangling goroutines from one test, those will keep running much longer than they used to. But it is not obvious why that should happen.
One problem might be in https://github.com/intel/pmem-csi/blob/da7c9991944d55dd349385656497f7cd69b8429c/test/e2e/storage/sanity.go#L473-L497
Here we kick of goroutines and let them run to success or timeout. But if the test aborts early, we still let the goroutine continue. This can be fixed my making the test context the parent of the function context.

Also, is 23kHz rate for retries really justified, or could it be slower.
And can we reduce logging about it.

We should switch to exponential backoff. I'll prepare a PR.


Limit version of soap4r-ng

The controller does not start with version 2.0.4.

https://ocd.appscale.com:8080/job/Daily Build/5140/

Demo
With master: https://ocd.appscale.com:8080/job/Hawkeye/14823/
With branch: https://ocd.appscale.com:8080/job/Hawkeye/14835/ (Controller starts)


add unsafe variants

at least now this is only draf and use case is https://github.com/MatejMagat305/Vsimulations

@MatejMagat305 hey! I really appreciate your efforts improving VCL, but will be great if you can create issues or discussions after creating the PRs so I can guide you on the best path or the expected usage of the lib 😊
I think we don't need to add extra methods. We just need to make this more flexible here https://github.com/vlang/vsl/blob/4dc518a6172a8c1127a713efbeec0b45902aea59/vcl/kernel.c.v#L146

@MatejMagat305 I just did this commit. It makes it possible to pass the underlying buffer as argument 😊 so It fixes your issue!
vector_of_planets := . . .

<-kernel.run(vector_of_planets.buffer())

@MatejMagat305 I just did this commit. It makes it possible to pass the underlying buffer as argument blush so It fixes your issue!
vector_of_planets := . . .

<-kernel.run(vector_of_planets.buffer())

I'll close the PR as soon as you can confirm this unblocks you 😊

sorry, next time I open .....


Update config

/merge

:tada: This PR is included in version 3.2.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to connect to repository https://dbeaver.io/update/debug/latest/content.xml

Description
I update dbeaver  to the latest version (Version <IP_ADDRESS>406021658) and I got error:
Unable to connect to repository https://dbeaver.io/update/debug/latest/content.xml
when I try to 'Help->Install New Software... ' and e.g. Dakest Dark Theme.
When I open  https://dbeaver.io/update/debug/latest there is no content.xml but content.xml.xz:

DBeaver Version
Community Edition <IP_ADDRESS>406021658
Operating System
Windows 10 64bit
Database and driver
No response
Steps to reproduce

Help->Install New Software...
2 Select Dakest Dark Theme

Additional context
No response

Also I was able to successfully install Darkest Dark theme on DBeaver Community Edition 24.1.0

Step 2.:

Result:

Do you have internet connection on that PC?
Is it under the firewall?

Yes I have internet connection on that PC.
E.g Checking for version updates has no problem:

Problem was with firewall - after I manually set it up it works:


Can we use Prettier for formatting nocode?

I believe you may need to open an issue in Prettier's project to build a plugin for formatting nocode.

Prettier already supports formatting nocode

Great.
Another concern I have with this is that Node.js support is not fully baked yet (per release notes)

Oh, that's sad.
JavaScript is the most popular programming language in the world right now. This will seriously impact nocode's usage!
Is Node.js support planned in future versions?


Stress: Capture Full Stack Traces

Description
The partial stack we currently see in stress can make debugging very difficult. Trying this out to see if errors with better stacks are more actionable.

Oooh cool! Navin and I faced this too in GC stress and worked around it for an investigation by catching and throwing a new Error. Eager to see if this works!
We need something for this same problem for Loop prod logs too IMO. Assuming this wouldn't be appropriate to suggest though.

@markfields we may be able to learn something here, like what our stack depth are, which could inform product changes, either increasing the capture depth, or reducing stack depth overall. Reducing depth overall would likely bring benefits, as i'm not sure we always need as much layering as we have, and ideally, we can simplify things by reducing it.


Fix/2.0/chunk sizes

this PR depends on #870 to be merged first.
this PR set out to fix the bug for chunk sizes not being exactly = chunk_size. however, it is deemed the problem actually doesn't exist! :) when looking at the s3 dashboard, sizes are shown as 15.3MB however, because s3 console uses ls -lah ${dir} to get this sizing information, it is inaccurate. because if you use wc -c ${filename} it shows that the file size is actually exactly = chunk_size!
this PR does however still add explicit size assertion for chunk sizes (in case this problem does arise in the future). assert_chunk_sizes now doesn't just check incomplete chunk sizes, but it also checks every chunk (except last) and asserts that it is exactly equal to chunk_size.

@McCrearyD I don't get it. If I only upload 1MB of data and flush my cache, will the chunk be padded out to 16MB? If not, why is this not an issue?
What was the (supposed) issue in the first place?

@benchislett the original issue was that when i was looking at the s3 console and on my local machine, chunk sizes appeared to be 15.3MB when they should be exactly 16MB.

also @benchislett i don't think the cache will pad the chunk (@AbhinavTuli for visibility in case im wrong)

@benchislett the original issue was that when i was looking at the s3 console and on my local machine, chunk sizes appeared to be 15.3MB when they should be exactly 16MB.

MiB = mebibyte
MB = megabyte
under the hood we are using MB, however here's a screen shot of the s3 console:

again, there is no problem here. all is working just fine.

https://forums.aws.amazon.com/thread.jspa?threadID=14146
@McCrearyD
You're not the first to have this problem. You won't be the last.

right, it's marked as ready for review @benchislett


Taking advantage of ROS header to store timestamps and frame_id

Whenever we use a ROS message with a header there is a timestamp and a frame_id.  We should take advantage of this both when receiving from ROS and when sending to ROS.
In general, it would be good to see if the VTK MRML nodes already has some kind of timestamp.  If they do, we should provide some conversion methods.
In subscribers, the callback could preserve both the timestamp and the frame_id along the last message.  We can then add methods to retrieve these, something like GetLastTimestamp and GetLastFrameId.  I implemented something similar for cisst-ros, see https://github.com/jhu-cisst/cisst-ros/blob/devel/cisst_ros_bridge/include/cisst_ros_bridge/mtsROSToCISST.h#L72.
In publisher, if the VTK data we're sending has a timestamp, we should use it and convert to ROS.  If it doesn't, we should use the current ROS time.

It seems VTK objects all have an object name, see https://vtk.org/doc/nightly/html/classvtkObject.html#a596da3ed5dfb4179182c7868bf915178


Seeking Clarification: Impact of having both billing models configured

Given that some features are per-seat and some are only for pay-as-you-go, what would the impact be for those that have both licensing/billing models implemented?
According to the Message Center post in the M365 Admin Center (https://admin.microsoft.com/?source=applauncher&ref=MessageCenter/:/messages/MC666614), the "Taxonomy Tagging" feature should be fully rolled out by now, but we are not seeing it in Setup. Could this be because, even though we have configured pay-as-you-go billing, we still have per-seat licenses assigned to users?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a755140b-0f04-a452-cfc7-adf7b67fa81f
Version Independent ID: a755140b-0f04-a452-cfc7-adf7b67fa81f
Content: Licensing for Microsoft Syntex - Microsoft Syntex
Content Source: microsoft-365/syntex/syntex-licensing.md
Service: microsoft-syntex
GitHub Login: @chuckedmonson
Microsoft Alias: chucked

@sparkitect -- Thank you for letting us know. Please let me look into this and I'll get back you.

In case it helps: Though we have definitely used some Syntex features since configuring pay-as-you-go roughly a month ago, we've yet to see a single cent billed in the Cost Analysis area of the configured Resource Group in Azure.

@sparkitect -- It looks like taxonomy tagging is still rolling out. You will be able to see the service when it gets completely rolled. Thanks for checking, and I regret the delay.


CUDA out of memory After 74 epochs

🐛 Bug
I am using the pytorch-lighting to run on 8 V100GPUs，and I set a seed in my train srcipt, everything went well at beginning, but encountered  CUDA out of memory while running the 74th epoch. This  can be steadily reproduced since  I have run the experiment 4 times with the same result.  The detailed log information is posted in the Additional context section.
Expected behavior
It will be great if you can give me some suggestion! Thank you!
Environment

PyTorch Lightning Version : 1.3.0
PyTorch Version : 1.7.1
Python version : 3.8
OS : Linux
CUDA/cuDNN version:11.0
GPU models and configuration: V100 32GB
How you installed PyTorch (conda, pip, source): conda

Additional context

cc @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7 @borda

@ZwormZ I believe there're quite a number of fixes/improvements since 1.3.0 released a year ago, so could you try a newer version? Also, if the problem still persists, would it be feasible for you to share a reproducible script?

Thanks for replying to me!
I have update pytorch-lighting to 1.5.10 version, and try to run twcie. This time I encountered CUDA out of memory while running the second epoch. I have not encountered this when running smaller models, but when I try to deepen the model by one layer, this happens and instead of CUDA out of memory at the beginning of training, I get an error at some epoch, which I am confused about.
After update, the detailed log information is posted in the Additional context section.
Here is my boring model:
class BaseProteinModel(pl.LightningModule, ABC):
    def __init__(
        self,
        vocab: Vocab,
        optimizer_config: OptimizerConfig = OptimizerConfig(),
        contact_train_data: Optional[TRRosettaContactDataset] = None,
    ):
        super().__init__()
        self.vocab = vocab
        self.optimizer_config = optimizer_config

    @abstractmethod
    def forward(
        self, tokens
    ):
        return NotImplemented

    def training_step(self, batch, batch_idx):

        src, tgt = batch
        logits = self(src)["logits"]
        valid_mask = tgt != self.vocab.pad_idx
        logits = logits[valid_mask]
        tgt = tgt[valid_mask]

        loss = nn.CrossEntropyLoss(reduction="none")(logits, tgt)
        loss = loss.mean()
        self.log("train_loss", loss, prog_bar=True, on_epoch=True)

        return loss

    def validation_step(self, batch, batch_idx):
        src, tgt = batch
        logits = self(src)["logits"]
        valid_mask = tgt != self.vocab.pad_idx
        logits = logits[valid_mask]
        tgt = tgt[valid_mask]

        loss = nn.CrossEntropyLoss(reduction="none")(logits, tgt)
        loss = loss.mean()
        self.log("val_loss", loss, prog_bar=True, on_epoch=True)

        return loss

trainer = pl.Trainer(
        logger=logger,
        callbacks=[lr_logger, checkpoint_callback],
        accumulate_grad_batches=1,
        accelerator="gpu",
        strategy=DDPPlugin(find_unused_parameters=True),
        fast_dev_run=False,
        gpus=8,
        gradient_clip_val=0,
        log_every_n_steps=50,
        max_epochs=1000,
        min_epochs=500,
        num_nodes=1,
        precision=32,
        progress_bar_refresh_rate=1,
        resume_from_checkpoint=None,
        track_grad_norm=-1,
    )

trainer.fit(model, train_dataloader=train_loader, val_dataloaders=valid_loader)

Additional context

Can you also add the implementation of forward? It seems this would be causing the error.

Here is the  the implementation of forward:
During Training, parameter: repr_layers=None, need_head_weights=False, return_contacts=False
    def forward(
        self, tokens, repr_layers=[], need_head_weights=False, return_contacts=False
    ):
        if return_contacts:
            need_head_weights = True

        assert tokens.ndim == 3
        batch_size, num_alignments, seqlen = tokens.size()
        padding_mask = tokens.eq(self.vocab.pad_idx)  # B, R, C
        if not padding_mask.any():
            padding_mask = None
        x = self.embed_tokens(tokens.long())
        # x = self.embed_tokens(tokens)
        x += self.embed_positions(
            tokens.view(batch_size * num_alignments, seqlen)
        ).view(x.size())
        if self.msa_position_embedding is not None:
            if x.size(1) > 1024:
                raise RuntimeError(
                    "Using model with MSA position embedding trained on maximum MSA "
                    f"depth of 1024, but received {x.size(1)} alignments."
                )
            x += self.msa_position_embedding[:, :num_alignments]

        x = self.emb_layer_norm_before(x)

        x = self.dropout_module(x)

        if padding_mask is not None:
            x = x * (1 - padding_mask.unsqueeze(-1).type_as(x))

        repr_layers = set(repr_layers)
        hidden_representations = {}
        if 0 in repr_layers:
            hidden_representations[0] = x

        if need_head_weights:
            row_attn_weights = []
            col_attn_weights = []

        # B x R x C x D -> R x C x B x D
        x = x.permute(1, 2, 0, 3)

        for layer_idx, layer in enumerate(self.layers):
            x = layer(
                x,
                self_attn_padding_mask=padding_mask,
                need_head_weights=need_head_weights,
            )
            if need_head_weights:
                x, col_attn, row_attn = x
                # H x C x B x R x R -> B x H x C x R x R
                col_attn_weights.append(col_attn.permute(2, 0, 1, 3, 4))
                # H x B x C x C -> B x H x C x C
                row_attn_weights.append(row_attn.permute(1, 0, 2, 3))
            if (layer_idx + 1) in repr_layers:
                hidden_representations[layer_idx + 1] = x.permute(2, 0, 1, 3)

        x = self.emb_layer_norm_after(x)
        x = x.permute(2, 0, 1, 3)  # R x C x B x D -> B x R x C x D

        # last hidden representation should have layer norm applied
        if (layer_idx + 1) in repr_layers:
            hidden_representations[layer_idx + 1] = x
        x = self.lm_head(x)

        result = {"logits": x, "representations": hidden_representations}
        if need_head_weights:
            # col_attentions: B x L x H x C x R x R
            col_attentions = torch.stack(col_attn_weights, 1)
            # row_attentions: B x L x H x C x C
            row_attentions = torch.stack(row_attn_weights, 1)
            result["col_attentions"] = col_attentions
            result["row_attentions"] = row_attentions
            if return_contacts:
                contacts = self.contact_head(tokens, row_attentions)
                result["contacts"] = contacts

        return result

I have the same issues. Anything updates? Thx

@yuhongyu0721 @ZwormZ Do you have a full script and env detail that reproduces the behaviour?

@yuhongyu0721 @ZwormZ Do you have a full script and env detail that reproduces the behaviour?

I figure out my problem is caused by Pytorch and its compilation. It's fixed by reinstall Pytorch with clean environment.


Modsetting.lsx file not updating with any mods

Describe the bug
I do all of the proper steps to deploy, but when I look in
"Lampray/Lamp_Data/Deployment/Baldur's Gate 3/PlayerProfiles/Public/"
and open the 'modsettings.lsx' I get this below. I think that this is what is causing my mods to not work.
<?xml version="1.0"?>
<save>
	<version major="4" minor="2" revision="0" build="100" />
	<region id="ModuleSettings">
		<node id="root">
			<children>
				<node id="ModOrder">
					<children />
				</node>
				<node id="Mods">
					<children>
						<node id="ModuleShortDesc">
							<attribute id="Folder" type="LSString" value="GustavDev" />
							<attribute id="MD5" type="LSString" value="" />
							<attribute id="Name" type="LSString" value="GustavDev" />
							<attribute id="UUID" type="FixedString" value="28ac9ce2-2aba-8cda-b3b5-6e922f71b6b8" />
							<attribute id="Version64" value="36028797018963968" type="int64" />
						</node>
					</children>
				</node>
			</children>
		</node>
	</region>
</save>

Error message
None
To Reproduce
Steps to reproduce the behaviour:

Follow the wiki guide on how to use Lampray.
Go to "Lampray/Lamp_Data/Deployment/Baldur's Gate 3/PlayerProfiles/Public/"
Click on 'modsettings.lsx'
The output I wrote above.

Expected behaviour
The mods and their load order being written to the 'modsettings.lsx'
System Info (please complete the following information):

Arch Linux, Kernel 6.9.3-arch1-1
Window Manager: Kwin (x11)
Lamp Version: 1.3.2

Same thing on version 1.3.1, 1.3.0, and I did not dare to try the older ones...

I was having the same issue while I was setting up a campaign with my wife. I had to make sure I selected the Mod Type for each mod.  It's the 3rd column in the UI.  After that it generated a valid modsettings.lsx.  Also on an Arch Linux distro.
By default, Mod Type just says "Select Type".  My screenshot shows how it should be(dependent on mod, mine are just standard in this scenario) and I left one as "Select Type" just to show what it was originally.  Hope this helps!

I did change the type... I may have chosen the wrong mod type on one of them.
I forgot to mention in the original post that, it has no problem with sending the mods to the game mod folder.
A folder I have for all of the mod zips(separate from Lampray and baldurs gate):

The baldurs mod folder:

The reason it says 26 instead of 27 is because one of the "mods" is a dll so it doesnt get placed in the mod folder.

I found the problem...

Above you can see the wrongful configuration that caused my problems. Below you can see the fix.


v4.1 Dependency Injection issues when using in Web application targeting full .NET framework

This was working in v4.0.7, broken in v4.1.0.
I'n my ASP.NET Core application targeting .NET 4.6.2, I've the below DI code that I call in Startup.cs:
var docColl = new DocumentCollectionBuilder<ProjectDocument>()
	.AddSolrExpress<ProjectDocument>()
	.UseOptions(new DocumentCollectionOptions
	{
		CheckAnyParameter = true,
		FailFast = true
	})
	.UseHostAddress("http://SomeURL")
	.UseSolr5()
	.Create();

services.AddSingleton(typeof(IDocumentCollection<ProjectDocument>), sp => docColl);
return services;

In my controller, below code throws exception with Invalid URL format. I debugged the SolrExpress code and figured that the host address is getting set to NULL i.e. it is getting lost even though I set it up in DI container.
 select
                .Execute() <--- Throws exception (Invalid URI: The format of the URI could not be determined.)
                .Document(out documents)
                .Information(out information);

@stanuku Please, check v.4.1.1

@diegobrum: 4.1.1 works, thanks!


Zenodo demo update (lesson 10)

The first year, the Zenodo demo was archiving this repo on Zenodo.  Can't do that since it's already archived (could demo making a github release, but not "flipping the switch" on Zenodo.
Alternatives:

Zenodo sandbox (need to explore how well this will work)
Archive a repo for work with Theresa Crimmins or Dave Moore (need to get them to authorize Zenodo for their organization)
Ask a learner to volunteer to be walked through the steps for one of their repos

I think using Zenodo sandbox is going to work fine, and is probably a low-stakes way for everyone to follow along as well.

Still need to update slides/notes for that lesson


Elastic 6.0 support

Is there any work going on for elastic 6.0
https://github.com/olivere/elastic

Contributions are welcome. Will look at this.

I believe this can be closed :) https://github.com/sohlich/elogrus/pull/13


When we delete a select type attribute options, there we are unable to see the delete warning message.

Describe the bug
When we delete a select type attribute options, there we are unable to see the delete warning message.
Steps To Reproduce

Go to Admin -> Catalog -> Attrbites -> Create/Edit  new attribuite of  Select Type.
Scroll down to Add Options,-> Once Options are added and save the attribute.
Now Edit the same attribute -> Scroll Down for options -> Delete the options.
There we can see that warning message is not appearing.

Actual Issue
We are able to delete the attribute options without warning message.
Video
https://github.com/bagisto/bagisto/assets/92721837/15d48120-f205-456d-bbbb-52d4fd7a20da
Expected behavior
When we click on the delete button warning message or dialogue box must appear. Please check the video for reference.
Video
https://github.com/bagisto/bagisto/assets/92721837/0582042b-4281-4e8c-9b1d-d2ee6e03ce61

Checked and Found that the warning message has been added in the Attribute option is deleted, please check the video for reference.
Video
https://github.com/bagisto/bagisto/assets/92721837/621556c5-90ea-4635-9e08-c0d9fbdbae87


dm: download docker-compose in github action

What problem does this PR solve?

Issue Number: close #4287
What is changed and how it works?

download docker-compose in github action

Check List
Tests

Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/retest

/retest


Ability to rename organization elements "shelves", "books" and "pages"

As i already saw in multiple instances. It would be nice if there is a way to easily change the default organization naming from shelves/books to something custom.
In my case i would like to change it to "departments", "products" and "articles".
I guess this would be a very nice feature to have, so you can have your BookStackApp more customized to individual needs.
Thank you in advance!

Hi @towerplease,
It may be worth reading through #406 which was a previous request for such a feature.

Since I feel this has been explain enough within #406, with potential workarounds via the visual theme system, I'm going to go ahead and close this off.


PLEASE add search field to your documentation 🚨

Search Terms
typescript search documentation
Suggestion
🚨 PLEASE 🚨 PLEASE 🚨 PLEASE 🚨
Add a search field in your typescript documentation.
I love TypeScript, really, i evangelized it anytime in my company, i make talks in french conferences to do so too.
But there is one missing feature in the documentation: a proper search field.
This is the only missing feature to make more users use this useful langage.
Use Cases
Save the world
Examples
Bootstrap documentation does it well :  https://getbootstrap.com/docs/4.1/getting-started/introduction/

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

Duplicate of https://github.com/Microsoft/TypeScript/issues/26956


Use css logical properties to support both LTR and RTL languages

Decide on an approach to RTL support - T257829
The lib has to support RTL languages.
CSS Logical Properties[0] offers the ability to control the layout through logical, rather than physical, direction and dimension mappings. They are supported in all major browsers but IE11[1]. That's why this patch introduces two postcss plugins - css logical props and the :dir selector[2]
This should be sufficient for devs to write css that supports LTR and RTL languages.
[0] https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties
[1] https://caniuse.com/#search=logical properties
[2] https://caniuse.com/#search=%3Adir

Rebased (fingers crossed)