Added default PDF file name.

Change Profile

Question
Answer

New feature
yes

Bug fix
no

BC breaks
no

Passing tests
yes

Description
Set default file name to "untitled.pdf".
Reason
Having a "null" file name is strange and will cause unexpected side effects when not provided to the PdfModel view model.

Note: This change does in fact break BC. Existing behavior in 0.4.0 treats a "null" file name as a regular PDF resource. That is, Content-Disposition header with attachment disposition type is not presented in the response.
In 0.4.0, by setting a file name we assume, and we trigger, the Content-Disposition response header w/attachment disposition type.
A new change is on the way to handle these cases in a more robust fashion.

See related https://github.com/raykolbe/DOMPDFModule/pull/31


Revert "Apply clipping in save_image"

Reverts pytorch/vision#119
Sorry, found an error and let me revert it.

what was the error?

mistakenly used clip(), but should be clamp()
Now I have corrected and tested. Do you mind if I pull request again?

go ahead. those names are so similar, even I missed that mistake. :)

thanks. that makes me feel better :)


HDDS-2070. Create insight point to debug one specific pipeline

It depends on HDDS-2071

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDDS-2071 Compile Tests _

-1
mvninstall
42
hadoop-hdds in HDDS-2071 failed.

-1
mvninstall
38
hadoop-ozone in HDDS-2071 failed.

-1
compile
21
hadoop-hdds in HDDS-2071 failed.

-1
compile
15
hadoop-ozone in HDDS-2071 failed.

+1
checkstyle
60
HDDS-2071 passed

+1
mvnsite
0
HDDS-2071 passed

+1
shadedclient
852
branch has no errors when building and testing our client artifacts.

-1
javadoc
23
hadoop-hdds in HDDS-2071 failed.

-1
javadoc
20
hadoop-ozone in HDDS-2071 failed.

0
spotbugs
955
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
35
hadoop-hdds in HDDS-2071 failed.

-1
findbugs
21
hadoop-ozone in HDDS-2071 failed.

_ Patch Compile Tests _

-1
mvninstall
36
hadoop-hdds in the patch failed.

-1
mvninstall
37
hadoop-ozone in the patch failed.

-1
compile
25
hadoop-hdds in the patch failed.

-1
compile
19
hadoop-ozone in the patch failed.

-1
javac
25
hadoop-hdds in the patch failed.

-1
javac
19
hadoop-ozone in the patch failed.

+1
checkstyle
57
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
720
patch has no errors when building and testing our client artifacts.

-1
javadoc
22
hadoop-hdds in the patch failed.

-1
javadoc
20
hadoop-ozone in the patch failed.

-1
findbugs
32
hadoop-hdds in the patch failed.

-1
findbugs
21
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-hdds in the patch failed.

-1
unit
26
hadoop-ozone in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

2380

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f9c31f7fbbbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
HDDS-2071 / 65cb751

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-ozone/insight U: hadoop-ozone/insight

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1609/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Moved to the new repository:
https://github.com/apache/hadoop-ozone/pull/299


Adding i18next-ICU plugin gives an error

Describe the bug
When I add the i18next-ICU plugin it gives an error of
TypeError: Cannot read property 'type' of undefined
at PROJECT_DIRECTORY\node_modules\next-i18next\dist\commonjs\createClient\node.js:64:16

Occurs in next-i18next version
^8.5.0 with i18next-icu -> ^2.0.3
Steps to reproduce
Add the i18next-icu plugin
// next-i18next.config.js

const ICU = require('i18next-icu').default

module.exports = {
    i18n: {
        defaultLocale: 'en',
        locales: ['en', 'de'],
        use: [ICU],
    },
    serializeConfig: false,
}

then do the other steps for handling unserializable configs
Expected behaviour
It should work without giving an error
OS (please complete the following information)

Device: Desktop, Windows 10
Browser: Chrome 91.0.4472.101

That is this line it sounds like your const ICU import is actually undefined. You probably don't need the .default. Good luck!

I've tried using it without .default but it gave another error
Error: You are passing a wrong module! Please check the object you are passing to i18next.use()

@isaachinman i have the same issue.
SerializableError: Error serializing `._nextI18Next.userConfig.use[0]` returned from `getStaticProps` in "/".
Reason: `object` ("[object Object]") cannot be serialized as JSON. Please only return JSON serializable data types

it is error messages.
My guess is that 'UserConfig.use' should contain an object that can be decomposed into JSON.
and i18next-icuis return Class Function.
This is where the problem arises.
please check it. and fixed. 🙏

you need to set the config.serialzeConfig to false as mentioned here

oh my god. thankyou!

@flex-junwoo did it work for you after setting config.serialzeConfig? because after I set it, it gives me the error above.

Yes.  it is work!! try it.

Can you send your config? cause I've tried it and it doesn't seem to work

of course, here it is

i think your code doesn't fit the format.
// next-i18next.config.js

const ICU = require('i18next-icu').default

module.exports = {
    i18n: {
        defaultLocale: 'en',
        locales: ['en', 'de'],
        use: [ICU],
    },
    serializeConfig: false,
}

to
// next-i18next.config.js

const ICU = require('i18next-icu').default

module.exports = {
    i18n: {
        defaultLocale: 'en',
        locales: ['en', 'de'],
    },
    use: [ICU],
    serializeConfig: false,
}

Thanks @flex-junwoo 😄, will try your fix out!

I'm still getting the error
here are my configs
// next-i18next-config.js

const ICU = require('i18next-icu')

module.exports = {
    i18n: {
        defaultLocale: 'en',
        locales: ['en', 'de', 'ar'],
    },
    use: [ICU],
    serializeConfig: false,
}

// next.config.js

const { i18n } = require('./next-i18next.config')
const withPlugins = require('next-compose-plugins')
const withTM = require('next-transpile-modules')(['react-children-utilities'])

module.exports = withPlugins([
    [i18n],
    [withTM],
])

// _app.js
import App from 'next/app'
import { appWithTranslation } from 'next-i18next'
import nextI18nextConfig from '../../next-i18next.config'

function MyApp({ Component, pageProps }) {
    // ...
}

MyApp.getInitialProps = async (appContext) => {
    const appProps = await App.getInitialProps(appContext)
    return { ...appProps }
}

export default appWithTranslation(MyApp, nextI18nextConfig)

// page.js
import { serverSideTranslations } from 'next-i18next/serverSideTranslations'
import nextI18NextConfig from '../../next-i18next.config'

function Page() {
    // ...
}

export async function getStaticProps() {
    return {
        props: {
            ...(await serverSideTranslations(
                'en',
                ['common'],
                nextI18NextConfig
            )),
        },
    }
}

export default Page

and here is the error

my package versions
{
  "i18next-icu": "^2.0.3",
  "next-i18next": "^8.5.0",
  "next": "^10.2.3"
}

is there something wrong that I'm not seeing?

@hazem-osama did you manage to solve this issue? Facing the exact same.

@ecklf nope, didn't manage to solve it 😅

I've decided to use https://www.i18next.com/translation-function/plurals instead. This does not solve the issue but might be a good alternative without introducing a new dependency.


add text wrap to the post titles in the Tags section

Stack the lines instead of truncating them.
It will grows downwards, but won't grow horizontally.

2023-10-30
Tried adding the following options without results:

text-wrap: wrap;
overflow-wrap: break-word;
overflow-inline: visible;

Addressed in latest commit.


fix: The following assembly name can not be resolved automatically

Purpose
(FILL ME IN) for fix this issue:  "The following assembly name can not be resolved automatically..."
Trouble
When the CopyAndLoadAddin method is executed, the fileAssemblyTemp variable value is a temporary path, Only one file was copied
here should copy the original path and put all the dll files into the temporary directory so that the relevant .dll files can be found

Hi @yanggenjie , thank you for your pull request, did you tried test with rebuild assembly and run code again ? Copy and load from original file assembly is not allow because can't Unload assembly after loaded.

@chuongmep Well, this is indeed a bug, Let me try it again


android-maps-compose:2.11.4 IllegalArgumentException: Unmanaged descriptor in DefaultClusterRenderer

Thanks for stopping by to let us know something could be better!

PLEASE READ
If you have a support contract with Google, please create an issue in the support console. This will ensure a timely response.
Discover additional support services for the Google Maps Platform, including developer communities, technical guidance, and expert support at the Google Maps Platform support resources page.
If your bug or feature request is not related to this particular library, please visit the Google Maps Platform issue trackers.
Check for answers on StackOverflow with the google-maps tag.

Please be sure to include as much information as possible:
Environment details

Android-maps-compose:2.11.4
Pixel 6 pro API 33 android studio emulator, android studio Giraffe
Android-maps-compose:2.11.4, android

Steps to reproduce
This happens randomly after awhile playing around the map. zooming in and out and panning the map view.
I have had to switch to MapEffect and implement CustomCluster renderer because of this. I t seems this is caused by some caching issues for markers
Code example
clusterItemContent = {
Surface(
Modifier
.height(36.dp)
.width(36.dp),
shape = CircleShape,
color = okayColor,
contentColor = Color.White,
border = BorderStroke(1.dp, white)
) {
Box(contentAlignment = Alignment.Center) {
Icon(
//this is a vector drawable icon, works well when it is working but then this crash happens
painter = painterResource(id = R.drawable.icon_aed_pin),
contentDescription = "AEd icon",
)
}
}
}
)
example

#### Stack trace
FATAL EXCEPTION: main
                                                                                Process: com.myapp.app, PID: 2821
                                                                                java.lang.IllegalArgumentException: Unmanaged descriptor
                                                                                at com.google.maps.api.android.lib6.common.m.c(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190400-0):0)
                                                                                at com.google.maps.api.android.lib6.impl.w.c(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190400-0):1)
                                                                                at com.google.maps.api.android.lib6.impl.cy.u(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190400-0):2)
                                                                                at com.google.android.gms.maps.model.internal.p.ba(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190400-0):42)
                                                                                at fd.onTransact(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190400-0):4)
                                                                                at android.os.Binder.transact(Binder.java:1164)
                                                                                at com.google.android.gms.internal.maps.zza.zzc(com.google.android.gms:play-services-maps@@18.1.0:2)
                                                                                at com.google.android.gms.internal.maps.zzy.zzs(com.google.android.gms:play-services-maps@@18.1.0:3)
                                                                                at com.google.android.gms.maps.model.Marker.setIcon(com.google.android.gms:play-services-maps@@18.1.0:2)
                                                                                at com.google.maps.android.clustering.view.DefaultClusterRenderer.onClusterUpdated(DefaultClusterRenderer.java:972)
                                                                                at com.google.maps.android.clustering.view.DefaultClusterRenderer$CreateMarkerTask.perform(DefaultClusterRenderer.java:1091)
                                                                                at com.google.maps.android.clustering.view.DefaultClusterRenderer$CreateMarkerTask.access$1900(DefaultClusterRenderer.java:1027)
                                                                                at com.google.maps.android.clustering.view.DefaultClusterRenderer$MarkerModifier.performNextTask(DefaultClusterRenderer.java:738)
                                                                                at com.google.maps.android.clustering.view.DefaultClusterRenderer$MarkerModifier.handleMessage(DefaultClusterRenderer.java:710)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                at android.os.Looper.loopOnce(Looper.java:201)
                                                                                at android.os.Looper.loop(Looper.java:288)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:7872)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
# example

Following these steps will guarantee the quickest resolution possible.
Thanks!

If you would like to upvote the priority of this issue, please comment below or react with :+1: so we can see what is popular when we triage.
@charlesbukenyaqvik Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

@charlesbukenyaqvik is this still happening to you in the latest version?

Closing as possible duplicate of #332

@wangela I had to create my own CustomCluster renderer than I apply, had to many issues with your clustering composable

@kikoso see comment above


Improve error message for metamorphing actor locally

Describe the bug
Using Apify.metamorph locally produces ugly error
The function passed to Apify.main() threw an exception:
  Error: Environment variable APIFY_ACTOR_ID must be provided!

To Reproduce
This is code from user:
const Apify = require('apify');

Apify.main(async () => {
    // Get input of the actor. Input fields can be modified in INPUT_SCHEMA.json file.
    // For more information, see https://docs.apify.com/actor/input-schema
    const input = await Apify.getInput();
    console.log('Input:');
    console.dir(input);

    // Here you can prepare your input for actor apify/web-scraper this input is based on a actor
    // task you used as the starting point.
    const metamorphInput = {
        // ... some object config
    };

    // Now let's metamorph into actor apify/web-scraper using the created input.
    await Apify.metamorph('apify/web-scraper', metamorphInput);
});

Expected behavior
I think there is no reason to support metamorph locally, right? So we can just throw friendly error.
System information:
unknown
Additional context
Add any other context about the problem here.

addressed in v3


fix write_zarr and write_h5ad

https://github.com/theislab/anndata/issues/156

Hi, I deduplicated this a bit. My IDE just broke and I need to leave soon so I didn’t test it.

Actually it is pointless because of this line
https://github.com/Koncopd/anndata/blob/4c6dc4ca1566994cbe6ecc5f0e72c29c249348f2/anndata/readwrite/write.py#L266

We need to delete this line if we want all this commits to works. I'm not sure why it is there, but if it is really needed then we can just remove all these conditions as with this line they will never be active.

By the way, the previous version also worked with lists, i.e allowed multiple excluded attrs.

Huh? How? You had {excluded_attrs}, which creates a set containing “excluded_attrs” as its single element. excluded_attrs = ['a', 'b']; {excluded_attrs} will result in Error: A list object is not hashable and excluded_attrs = ('a', 'b'); {excluded_attrs} will be a Set[Tuple[str, str]]: {('a','b')}.

Need to test if this line is really required.

Yes. The line was introduced by @tomwhite implementing zarr storage in 2102629fbbc13c5948485c051bb6888680a681bf. Maybe he can help?

Yeah, you are absolutely right about the problem with {excluded_attrs}, i was so sure about this for some reason that didn’t even check. My mistake, thank you. {*excluded_attrs} also seems to work, but it will split a string into characters.

Hm, i see that these line was before that commit and i think it was just copied from write_h5ad to write_zarr.

Superseded by @ivirshup’s IO refector


An .esproj file has different properties than listed here

I just made a new React/ASP.NET project from the templates provided in Visual Studio 2022.
When I right click on the .esproj file, it does have the Build properties listed here, but when you talk about Debug and list the properties, they're actually called Deploy and not debug in the properties file.
In fact, there is actually NO way to set debug properties, which ends up breaking the program because no where does it explain that if you actually want to run the debugger in VS2022, you have to have the .vscode/launch.json file in the project, and in that specific location relative to the .esproj folder. This is unintuitive because why would a Visual Studio project need a hidden VSCode folder, and it's debugger launch?
I have been unable to find any explanation for this, but if I don't have the .vscode/launch.json file in it's proper spot, and committed to my codebase repository, then when I clone the repo later to a new environment, I'm unable to run the debugger out of the box by pressing the 'start' button as one would expect in VS2022.
Can we get some updates and clarity on all of this please?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0baa65b7-0a99-6368-06cf-48aab3919475
Version Independent ID: 0baa65b7-0a99-6368-06cf-48aab3919475
Content: Project Settings for React, Angular, and Vue projects - Visual Studio (Windows)
Content Source: docs/ide/reference/property-pages-javascript-esproj.md
Product: visual-studio-windows
Technology: vs-javascript
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

ok, finally I found one small blip of information: https://learn.microsoft.com/en-us/visualstudio/javascript/tutorial-asp-net-core-with-react?view=vs-2022

launch.json stores the startup settings associated with the Start button in the Debug toolbar. Currently, launch.json must be located under the .vscode folder.

But why is this? Can there be some kind of explaination please?

@glitchwizard -- C, thank you for your thorough feedback, research, and questions.  Please consider these resources, if you haven't already:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

@Mikejo5000 -- Mike, please look into this issue.

@glitchwizard Thanks for your feedback! I'll update the article. I believe the reason the settings are stored in /.vscode folder is to support the possibility of opening the same project in VS Code, if desired.

Update should be live by noon PST, 6/29/23.

@mikejo5000 yeah that's a pretty cool idea, but I think it should be a little more clear that it's absolutely needed to run the debugger in Visual Studio as well.
Thanks for the update!

@mikejo5000 yeah that's a pretty cool idea, but I think it should be a little more clear that it's absolutely needed to run the debugger in Visual Studio as well.
Thanks for the update!

@Mikejo5000

I believe the reason the settings are stored in /.vscode folder is to support the possibility of opening the same project in VS Code, if desired.

But what if launch.json contains multiple profiles used by VS Code. How to specify which one should be used by VS 2022 when *.esproj is started?


Critical dependency: the request of a dependency is an expression

When i build universal, i get this error. Please help me.
WARNING in ./node_modules/node-gyp-build/index.js 13:9-32
Critical dependency: the request of a dependency is an expression
@ ./node_modules/bufferutil/index.js
@ ./node_modules/ws/lib/buffer-util.js
@ ./node_modules/ws/lib/receiver.js
@ ./node_modules/ws/index.js
@ ./server.ts

Please use the issue template so we can properly help you. Closing this one, but feel free to open a new one that follows the template.


mognorestore: Don't know what to do with subdirectory "sources/jurisdiction-mongodb-dump/standards"

Trying to pull down a copy of the data using the steps in the Development section of the Readme:
~/Code/common-standards-project$ mongorestore sources/jurisdiction-mongodb-dump -d common-standards-project
2015-12-19T17:22:57.313-0800  building a list of collections to restore from sources/jurisdiction-mongodb-dump dir
2015-12-19T17:22:57.313-0800  don't know what to do with subdirectory "sources/jurisdiction-mongodb-dump/standards", skipping...
2015-12-19T17:22:57.313-0800  done

mongorestore version 3.0.7
Googled for that error, still not sure.
Any thoughts, perhaps on the way the dump was prepared?

Looks like it's expecting everything in a flat format: http://stackoverflow.com/questions/6770498/how-to-import-bson-file-format-on-mongodb
Running this works: mongorestore sources/jurisdiction-mongodb-dump/standards/ -d common-standards-project


Name of x86_64 Android11 project

Hello, can I ask what x86_64 Android11 OS do you use in the screenshot? And where to download it? Thanks.

Sorry, I missed your link in the README. Thank you!


Implement default CPU limits

Similar to #1142, we need to guide admins on how to set CPU limits per instance groups and jobs, which means:

enabling a feature in cf-operator to expose this
determining what the default limits would be

@troytop has seen problems on his test environment that highlight the importance of identifying this.


feat: add auto-height to textarea

Description
Add the optional property autoHeight to the TextArea component. It will calculate and adjust the hight of the text-area automatically based on user input
Related issue(s)

[Feature]: Textarea autoheight prop #791

What kind of change does this PR introduce? (check at least one)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New Feature (non-breaking change which adds functionality)
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
How has This been tested?

Storybook, baby, also made sure to update the docs.

Screenshots (if appropriate):
The PR fulfills these requirements:

[x] It's submitted to the main branch
[x] When resolving a specific issue, it's referenced in the related issue section above
[x] My change requires a change to the documentation. (Managed by Tremor Team)
[ ] I have added tests to cover my changes
[x] Check the "Allow edits from maintainers" option while creating your PR.
[x] Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
[x] By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

This is my first open-source contribution so any feedback will be really appreciated :)

Can you review the PR, please? @severinlandolt


Support for multiple independent Lutron systems

Like a Caseta and RRA2 install controlled from same Indigo system.  Or multiples of the same system.  Possibly useful for very large homes or multiple buildings on same property.
Or multiple independent systems, in conjunction with issue #31.

This one is not simple at all.  But I've done similar for many of my other plugins.

This will be 7.3.0.  Development is mostly complete.


chore: Only message Slack from main branch runs of integration tests

https://github.com/fal-ai/fal/actions/runs/2379555388


Remove orphaned files from the manual/ directory

They're turning up on google search and they're outdated docs.
Google for 'hasura ssh'
One user found this issue: https://docs.hasura.io/0.15/manual/SSH-cluster.html
and got super pained because the dashboard does not have that anymore.

Fixed this issue already. Orphaned docs used to be present in our sitemap.xml. This doesn't happen anymore.

We need to somehow make google forget already crawled links. Webmaster lets me remove pages one url at a time which is super painful.


Momentum calculator page is not responsive

Describe the bug
The mobile and tablet view for momentum calculator page is not responsive

I know how to fix this issue. Can you assign this to me?

@OmGole none of the calculators are responsive.

I can make the page responsive if you assign me.

@OmGole rectify the problems mentionedbin discord and then send the PR again


Add option to allow using pre-built Kubernetes binaries

This change adds a "DIND_K8S_BIN_DIR" environment variable to allow the dind-cluster.sh
script to use pre-built binaries on the host for hyperkube and kubeadm to be used in
node containers.
For example, if the 'hyperkube' and 'kubeadm' binaries are in the directory
/home/myname/k8s_bin_dir on the host, then a user would set the environment
variable:
export DIND_K8S_BIN_DIR=/home/myname/k8s_bin_dir

and then run 'dind-cluster.sh up' in the normal fashion.
With the proposed change, dind-cluster.sh would create a bind mount from
the '/k8s' directory on each node container to the Kubernetes binary directory
on the host, and there would be no build of Kubernetes binaries.
Note that the setting of DIND_K8S_BIN_DIR to a non-null string will cause
the BUILD_HYPERKUBE and BUILD_KUBEADM environment variables to be
ignored.
This change is required for Kubernetes IPv6 CI periodic tests, since all that is available
for these periodic tests are the binary builds based on Kubernetes latest master
(i.e. no source is available).

/assign @ivan4th

/approve

@ivan4th - Is this okay to merge? We'll need this feature for the IPv6 periodic (post-merge) CI tests.

/approve

/lgtm


Building fails with: error[E0557]: feature has been removed

relevant output of trying to run cargo build --example hello:
error[E0557]: feature has been removed
--> /home/frederik/.cargo/registry/src/github.com-1ecc6299db9ec823/panic-semihosting-0.3.0/src/lib.rs:59:12
|
59 | #![feature(panic_implementation)]
|            ^^^^^^^^^^^^^^^^^^^^
|
note: subsumed by #[panic_handler]
--> /home/frederik/.cargo/registry/src/github.com-1ecc6299db9ec823/panic-semihosting-0.3.0/src/lib.rs:59:12
|
59 | #![feature(panic_implementation)]
|            ^^^^^^^^^^^^^^^^^^^^
error[E0658]: The attribute panic_implementation is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642)
--> /home/frederik/.cargo/registry/src/github.com-1ecc6299db9ec823/panic-semihosting-0.3.0/src/lib.rs:71:3
|
71 | #[panic_implementation]
|   ^^^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(custom_attribute)] to the crate attributes to enable

Any news? This caught me as well.

I could move two step further. I changed the panic-semihostic dependency to 0.5.2 in cargo.toml
But then there is a failure on:
error: use of deprecated item 'hal::prelude::_embedded_hal_digital_OutputPin::set_low': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/led.rs:168:18
    |
168 |         self.pex.set_low()
    |                  ^^^^^^^
    |
note: lint level defined here
   --> src/lib.rs:40:9
    |
40  | #![deny(warnings)]
    |         ^^^^^^^^
    = note: #[deny(deprecated)] implied by #[deny(warnings)]

error: use of deprecated item 'hal::prelude::_embedded_hal_digital_OutputPin::set_high': Deprecated because the methods cannot return errors. Users should use the traits in digital::v2.
   --> src/led.rs:173:18
    |
173 |         self.pex.set_high()
    |                  ^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `f3`.

You can disable it by commenting offending lines in led.rs and by removing the deny warnings directive ine lib.rs.
But at this step there is a error with the linker:
  = note: rust-lld: error: unknown argument: -Wl,-Tlink.x
          rust-lld: error: unknown argument: -nostartfiles

I tested with both stable and nighlty.

Got it running by modifying .cargo/config to:
[target.thumbv7em-none-eabi]
runner = 'arm-none-eabi-gdb'
rustflags = [
  "-C", "link-arg=-Tlink.x",
#  "-C", "link-arg=-Wl,-Tlink.x",
#  "-C", "link-arg=-nostartfiles",
]

[target.thumbv7em-none-eabihf]
runner = 'arm-none-eabi-gdb'
rustflags = [
  "-C", "link-arg=-Tlink.x",
#  "-C", "link-arg=-Wl,-Tlink.x",
#  "-C", "link-arg=-nostartfiles",
]

[build]
target = "thumbv7em-none-eabihf"

I also add the following line to~/.gdbinit:
set auto-load safe-path /

This configuraiton might be unsafe.
Also, do not forget to install arm-none-eabi-gdb

Some other examples still won't compile. I guess this crate needs to be refactored to use the updated version of the hall. Any plans?


High weekly workload activity divides a weeks hours by a month

For example, if you have a workload that has high activity during 9am – 6pm weekday business hours, then the percentage of time at peak is: 45 hours at peak / 730 hours / month = ~6%.
This is calculating based on a week's high activity divided by a month. It should be 45 / 168 hours / week = ~27% (or 26.785%).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2d8819df-d530-4c13-e086-4deac6b99f32
Version Independent ID: 43002bb4-27f0-99cf-b87b-5f22b68ca5b9
Content: Estimate costs using the Azure Cosmos DB capacity planner - API for MongoDB
Content Source: articles/cosmos-db/mongodb/estimate-ru-capacity-planner.md
Service: cosmos-db
Sub-service: mongodb
GitHub Login: @deborahc
Microsoft Alias: dech

Hi @GreenReaper ,
Thanks for sharing this feedback. We will look into this and update as appropriate.
Hi @deborahc,
Could you please look into this, thanks.

Hello @GreenReaper, thank you for your feedback. We are publishing a correction to this article shortly.


JIRA SAML SSO Button Placement

I have integrated SSO with Azure on Jira by following your guide here: https://docs.microsoft.com/en-us/azure/active-directory/saas-apps/jiramicrosoft-tutorial however, I was wondering if it is at all possible for there to be a button placement option.
I would love it if we had the option for the "Login with Azure AD" button to be below the regular login form. The reason I request this is that the button does not display immediately and so sometimes when trying to click the username field right after the page loads, someone will click on the SSO button that just popped up.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d38cad90-6574-38c2-3262-059a9f975064
Version Independent ID: dd08d5c5-65a4-c2cc-8b51-7a35268dde68
Content: Tutorial: Azure Active Directory integration with JIRA SAML SSO by Microsoft
Content Source: articles/active-directory/saas-apps/jiramicrosoft-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@Weasnerb
Thanks for your feedback! We will investigate and update as appropriate.

I am pretty sure that this page is owned by Jira. You may be able to use the location property - ` this.button1.Location' and edit the login.xml https://confluence.atlassian.com/jirakb/how-to-customize-the-login-gadget-225122084.html
The conversation here might be helpful to you. https://community.atlassian.com/t5/Jira-questions/JIRA-Login-page-customization/qaq-p/388256
I would suggest asking this in the Jira Community or Jira documentation since this page and plugin is not owned by Azure.
(CC: @jeevansd for confirmation)

We will now proceed to close this thread. Please feel free to tag me in the comments if you have further questions and I will gladly continue the discussion.

Thanks, I'll take a look into it!

@weasnerb Please download the new plugin from the Download center and we have now implemented the force login option here. So now we can completely remove this Username and password option from the login page. Please let us know how this goes.

#please-close

@jeevansd Thank you for this, however I do not want to force login through this plugin, as we have some users on our Jira server that are a part of our internal Jira User Directory. Is there any way to just move the button below the login form without having to manually modify the login gadget?

@weasnerb No. I dont think we have an option to move the Login button here. This is the design what JIRA team came up with. If you want to move it then you need to modify the Login page and move that control. Unfortunately we cant do anything from the plugin here.


Add source for png images

How are the .png images like source/images/overview.png maintained? It would be good to include an svg source in this repo so that users can propose edits directly.

Did you create the originals? I am a little embarrassed to admit I updated the images a bit using powerpoint.

I created the originals in svg (see https://raw.githubusercontent.com/wiki/cds-hooks/cds-hooks/images/overview-with-decisions.svg). No cause for embarrassment; the current diagrams look good! Just add your PowerPoint to the repo, or import into Google docs (or make an svg) and link to that.. the goal is just to make sure nobody needs to recreated this from scratch to propose a change.

Thanks - added in PR #111

Fixed & merged in PR #111.
Check out https://github.com/cds-hooks/docs/tree/master/diagrams for the source diagram


More option for "Find My Mouse"

Description of the new feature / enhancement
我个人非常喜欢"查找我的鼠标"这个功能, 双击ctrl就能调用出来非常方便, 而且聚光灯的效果足够醒目, 以至于我常常在给别人展示内容时使用. 因此我希望聚光灯的效果能够一直存在, 你们可以在设置中提供更多可选项, 比如"不会自动淡去"的开关以及"x秒后自动淡去"这种选项.
I personally love the "Find My Mouse" feature very much. It is very convenient to call it up by double clicking on Ctrl, and the spotlight effect is eye-catching enough, which help me to lead others eyes when I displaying content on the screen. Therefore, I hope that the effect of the spotlight can always exist. You could provide more options in the settings, such as the switch that "will not automatically fade out" and the option that "will automatically fade out after x seconds".
Scenario when this would be used?
当该功能被当做"聚光灯"来使用的时候, 不需要"自动淡去", 这种情况下希望能手动设置.
There's no need to "fade out automatically", when the feature is used as a spotlight. So optional options should be provided in the settings.
Supporting information
No response

Thanks for your message. This is a Duplicate of an other issue. Additional comments may be added there. /dup #22561


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

 It is also a useful platform to collaborate on projects with other programmers.


Global Typings?

Can one add global typings? i.e a global 'JQuery typing': non-single-project based.

This is currently not possible and a limitation of the underlying TS compiler and language service infrastructure we are using. Pls open an issue at https://github.com/Microsoft/TypeScript


Https connection cannot use TLS_RSA_WITH_3DES_EDE_CBC_SHA cipher suite

Hi! I've noticed that an update in okhttp 2.3 removed TLS_RSA_WITH_RC4_128_SHA cipher suite support by default.
This removal made impossible to connect to https://service-payment.groceries.asda.com with no extra setup.
I find this bit surprising because all browsers connects to the domain using TLS_RSA_WITH_3DES_EDE_CBC_SHA cipher suite and it is declared in ConnectionSpec.MODERN_TLS. However for some reason connection fails if TLS_RSA_WITH_RC4_128_SHA is not defined in connection specs.
Can you please check that there is no mistake about ciphersuite use in okhttp? It also may be purely android specific thing but I don't know how to verify this.

We deliberately dropped support for RC4 because it's lost our trust. Best fix is to ask your server to upgrade to something more modern.

Yes, the server does support TLS_RSA_WITH_3DES_EDE_CBC_SHA and it even works in android emulator. However it doesn't work for unknown reason on real devices - that's what the task is about. Maybe you can check why does this happen or tell what can I do to gather this info. I've requested server encryption upgrade but it may be beneficial for others to figure out what's going on.

According to SSL labs, this site only supports 2 cipher suites, and both of them use RC4. You'll need to explicitly configure OkHttp to connect to it until they upgrade their crypto.
https://www.ssllabs.com/ssltest/analyze.html?d=https%3A%2F%2Fservice-payment.groceries.asda.com
Chrome says obsolete cryptography:

Firefox says it isn't encrypted:

No action for us to take here. Sorry about your old bad server!

okay, thank you for checking!

...You should give them a hard time about this. When the world's largest company uses obsolete crypto for URLs containing the word payment, somebody is doing a bad job.

Indeed. While practically it's still a pretty secure it does look like a very old server.


Added missing settings to mapping in routing.js so they will update the url

Closes #259

Thanks so much for the help!


Inverse references

If I have two schemas like this:
var personSchema = Schema({
  name    : String,
  age     : Number,
});

var storySchema = Schema({
  _creator : { type: Schema.Types.ObjectId, ref: 'Person' },
  title    : String,
  fans     : [{ type: Schema.Types.ObjectId, ref: 'Person' }]
});

It would be nice to be able to add a connection from person to stories that results in Story.find({_creator:...})

related to #64

+1!


github

Sails version:
Node version:
NPM version:
DB adapter name: N/A
DB adapter version: N/A
Operating system:

Omg, I was typing search query and opened an issue somehow (probably focus was not in the address bar). Sorry for that - remove plz.


gnome3/nautilus cannot browse smb:// paths

Trying to access a smb:// (or cifs://) path in nautilus yields Sorry, could not display all the contents of “win7 (smb)”: The specified location is not supported.
Another way to test this is to click "Connect to Server", and after typing "smb:", the dialog will say The file server type is not recognized.

Can we reopen this again? The smb support is missing again...

Ok, i can see gvfs getting compiled with samba support but nautilus does not allow me to use it for some reason

I'm getting this on 17.09.

Yep somehow this is missing again :(


Test for loggerd

this only tests rotations and its main goal is to verify #1953

Can we do this without actually starting camerad? Can we create a fake camerad that just outputs frames?

What is the benefit of using a fake camerad except from the real one occasionally not closing? I think that adds more code because it needs to be device specific and such.

Can we do this without actually starting camerad? Can we create a fake camerad that just outputs frames?

What is the benefit of using a fake camerad except from the real one occasionally not closing? I think that adds more code because it needs to be device specific and such.


build T4 int4 weight failed

t4_trt_log.txt
I tried to buildy int4 weight only but failed, here are the params:
python build.py -m chatglm3_6b --model_dir /home/trt_docker_home/ChatGLM3/chatglm3-6b/ --output_dir /home/trt_docker_home/ChatGLM3/chatglm3_6b_int4/engine/weight_int4_only/T4/ --use_weight_only --weight_only_precision int4 --max_input_len 512 --max_output_len 512 --max_batch 4
and the error:
[12/29/2023-10:35:28] [TRT] [W] TensorRT was linked against cuDNN 8.9.6 but loaded cuDNN 8.9.4
static void cutlass::gemm::kernel::GemmFpAIntB<Mma_, Epilogue_, ThreadblockSwizzle_, KernelArch, SplitKSerial>::KernelRunner<B, dummy>::run_kernel(const cutlass::gemm::kernel::GemmFpAIntB<Mma_, Epilogue_, ThreadblockSwizzle_, KernelArch, SplitKSerial>::Params &, cutlass::gemm::kernel::GemmFpAIntB<Mma_, Epilogue_, ThreadblockSwizzle_, KernelArch, SplitKSerial>::SharedStorage &) [with _nv_bool B = false; dummy = void; Mma = cutlass::gemm::threadblock::DqMmaPipelined<cutlass::gemm::GemmShape<32, 128, 64>, cutlass::transform::threadblock::PredicatedTileIterator<cutlass::MatrixShape<32, 64>, cutlass::half_t, cutlass::layout::RowMajor, 1, cutlass::transform::PitchLinearWarpRakedThreadMap<cutlass::PitchLinearShape<64, 32>, 128, cutlass::PitchLinearShape<8, 4>, 8>, 8, false, cutlass::layout::NoPermute>, cutlass::transform::threadblock::RegularTileIterator<cutlass::MatrixShape<32, 64>, cutlass::half_t, cutlass::layout::RowMajorTensorOpMultiplicandCrosswise<16, 64>, 0, cutlass::transform::PitchLinearWarpRakedThreadMap<cutlass::PitchLinearShape<64, 32>, 128, cutlass::PitchLinearShape<8, 4>, 8>, 16>, cutlass::transform::threadblock::PredicatedTileIterator<cutlass::MatrixShape<256, 32>, cutlass::integer_subbyte<4, false>, cutlass::layout::ColumnMajor, 0, cutlass::transform::PitchLinearWarpRakedThreadMap<cutlass::PitchLinearShape<256, 32>, 128, cutlass::PitchLinearShape<8, 4>, 32>, 32, false, cutlass::layout::NoPermute>, cutlass::transform::threadblock::RegularTileIterator<cutlass::MatrixShape<64, 128>, cutlass::integer_subbyte<4, false>, cutlass::layout::ColumnMajorTensorOpMultiplicandCrosswise<4, 64>, 1, cutlass::transform::PitchLinearWarpRakedThreadMap<cutlass::PitchLinearShape<64, 128>, 128, cutlass::PitchLinearShape<2, 16>, 32>, 16>, cutlass::transform::threadblock::PredicatedTileIterator<cutlass::MatrixShape<1, 128>, cutlass::half_t, cutlass::layout::RowMajor, 0, cutlass::transform::PitchLinearStripminedThreadMap<cutlass::PitchLinearShape<128, 1>, 16, 8>, 8, false, cutlass::layout::NoPermute>, cutlass::transform::threadblock::PredicatedTileIterator<cutlass::MatrixShape<1, 128>, cutlass::half_t, cutlass::layout::RowMajor, 0, cutlass::transform::PitchLinearStripminedThreadMap<cutl%s not implemented
not implemented

Hi. It looks like you are trying to build an engine for INT4 Weight-only for ChatGLMv3 ; which is not listed as a valid option in this table. It's not a bug. Can you open a feature request please?


[ci.yaml] Migrate bringup targets to cocoon scheduler

https://github.com/flutter/flutter/issues/92300
Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] All existing and new tests are passing.

Are we relying on the checkout retry to bypass the issue or any other actions we have taken? What is the long term plan here?

Yes, it should only add a minute to the recipe runs. The copybara team is working on a way to send notifications via pubsub of when mirrors complete (ETA a quarter)


fixed request->callback query param passing

Fixes a bug with extra params not being passed properly through to callbacks
See:  https://github.com/intridea/omniauth/issues/543

(not sure if fix is in exactly the right place, it was my best guess)


chore: make import path consistent

Summary
This is to make import path consistent across all packages.

This is to make import path consistent across all packages.

Feel like I'm missing some context. What's the motivation here?
What is going to stop it becoming "inconsistent" again straight away?

@keithbro-imx
This is not to make it consistent once for all but mainly for people trying out different approach to build our sdk, especially when touching baseurl or removing tsconfig giles, they won't be bogged down by fixing all the imports.

Can we set up an eslint rule to only allow relative imports to ensure this remains fixed?
Package here
Rule here

@zaidarain1 the baseUrl is their because I want to do the test fields separately in a different PR. also, that eslint rule is for absolute path tho. And I can't find a rule about "force relative path" in eslint.

@zaidarain1 the baseUrl is there because I want to do the test file separately in a different PR. they still use non-relative paths. also, that eslint rule is for absolute path tho. And I can't find a rule about "force relative path" in eslint.

@shineli1984
  "plugins": ["import"],
  "rules": {
    "import/no-unresolved": ["error"],

Running this rule with the above npm eslint-plugin-import packages errors out the imports for me as needed, but yeah the absolute path rule doesn't work.


Not compatible with labels for LTO7

This code has no possibility to be used with LTO-7 tapes.

There is no LTO-7 choices
It seems that the sticker get printed but not read by the tape loader, contrary to https://tapelabel.de/ .

Oh, wow. I didn't even remember this old repo. I haven't touched it since 2015. I have an updated version here:
https://kelvin.nu/barcode
I haven't gotten around to publishing the source code to it though.


adds style changes according to PEP8 on adding example

Docstrings are delimited with ''' throughout the codebase. Also we don't normally take PRs about style.


Update API version to the latest stable when accessing "microsoft.insights/activityLogAlerts" resource type

Preconditions

[X] No need to upgrade Python SDK or the Python SDK is ready.

Related command
Commands start with "az monitor activity-log alert ..", for example:
az monitor activity-log alert action-group add --name MyName --resource-group MyRg --action /subscriptions/abcd
Resource Provider
microsoft.insights/activityLogAlerts
Description of Feature or Work Requested
Currently az works with older version of the service. Some customers face issues with this, and obviously it has to be updated to the latest stable version. The tool uses "2017-04-01", and it has to use the latest stable version, which is "2020-10-01".
Minimum API Version Required
2020-10-01
Swagger PR link / SDK link
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json
Request Example
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/Microsoft.Insights/stable/2020-10-01/examples/ActivityLogAlertRule_CreateOrUpdate.json
Target Date
2020-10-01
PM Contact
@yagil
Engineer Contact
@grchris
Additional context
There's a related CRI, where the customer complains that he cannot update his rule using the CLI tool. After our investigation it turns out that the API version is not up to date.
Incident 425584794 : [Pending PG] || # [AzMonCRI] - Couldn't add action group to service health alert via Azure CLI

Thank you for opening this issue, we will look into it.

Hi @yonzhan , we tried to follow the aaz dev tools doc to try to update the CLIs using the self-service tools, and sent the following PRs:
aaz repo - https://github.com/Azure/aaz/pull/323
azure cli repo - https://github.com/Azure/azure-cli/pull/27612
From the azure cli PR validation failures, looks like we missed something in the process.
I would appreciate understanding if it was expected that our team would use these tools to update the CLI version, and if we could get some help with it.
Thanks!

Hi @asafst , we are evaluating upgrading the "microsoft.insights/activityLogAlerts" api-version to the latest stable one this week and may reply to this issue later.
Regarding the pr you pulled, there are some missing parts.

if api version is changed, related service live tests should be run and recorded locally and submitted to repo to ensure current functionality still works well
pull request has its own formatting and can be referred here
because previous execution has some customization, it should be inherited into new versions. Otherwise, "BREAKING CHANGE" label needs to be added into this pr release notes.

@asafst  related version upgrading pr is linked

Thanks @AllyW! The PR looks great. I closed my PR on the cli repo. should I also close the PR in the aaz repo?

@asafst, yes, we'll pull a new request in the aaz repo later after the code submit for azure cli main repo is ready

Thanks @AllyW, I closed the PR I opened in the aaz repo.


Bug 2045927: Add proxy for ironic-agent.service

Avoid the issue that ironic agent image cannot be downloaded due to network proxy.
See https://github.com/openshift/installer/issues/5552 for details.
Signed-off-by: Zhou Hao<EMAIL_ADDRESS>

/ok-to-test
You'll need to attach a valid bug to merge this change at this point.

/cc @dtantsur @andfasano

You'll need to attach a valid bug to merge this change at this point.

We are preparing BZ, I will update later.

/lgtm

@hardys @andfasano PTAL

/approve


WIP: HTTPCLIENT-2019: Introduce HttpRequestRetryStrategy

This is a prototype for the interface and the default impl to be discussed with the community, tests and ExecChainHandler are open.
Open questions:

Should the old interfaces, impls, and chain handlers be deprcated or simply removed? I opt for removal because having both is problematic.
Deprecate all of that in 4.5.x? For me: yes.
What about default values? They were different in both previous impls.
Do we still need getMaxRetries()?
Maybe others...

@ColinHebert Can you explain where you want to put the executionCount for/in getRetryInterval()

@michael-o We cannot change 4.5 but we can consider back-porting this chnage-set to 4.6 (once it has been started).

@michael-o I suppose if we are not going to have another BETA we might as well just remove the old interfaces without a migration path.

I do not intend to change 4.5.x actually, but we can deprecate, can't we? How can we backport this if the new interface replaces the old ones? I need to swap them in the client builder and old custom impls won't work anymore.

@michael-o I suppose if we are not going to have another BETA we might as well just remove the old interfaces without a migration path.

This might require another beta, doesn't it? Depreate in beta, remove in GA. I am equal to immediate removal in a separate ticket.

This might require another beta, doesn't it?

Then I suggest this change gets parked until 5.1.

This might require another beta, doesn't it?

Then I suggest this change gets parked until 5.1.

Deprecate now and remove in 5.1?

@michael-o No, we cannot deprecate functionality without providing a migration path to a non-deprecated equivalent.

@michael-o No, we cannot deprecate functionality without providing a migration path to a non-deprecated equivalent.

This is actually what I will do. Deprecate now and add new interface, release beta, remove before GA, release GA. The migration path will exist between the last beta and GA. Is that sufficient?

release beta

I am not sure what BETA you are referring to? I would like to cut a GA next week.

release beta

I am not sure what BETA you are referring to? I would like to cut a GA next week.

That's is my I have asked. Do we need another beta for this? If we do the beta, we could drop the old code in GA, if not we will have to wait until at least 5.1.

release beta

I am not sure what BETA you are referring to? I would like to cut a GA next week.

That's is why I have asked. Do we need another beta for this? If we do the beta, we could drop the old code in GA, if not we will have to wait until at least 5.1.

We can't "drop" code once we go GA, we can only deprecate. I would feel poorly done to release 5.0 only to deprecate code in the follow up release, especially if we know now that we want to replace that code.

release beta

I am not sure what BETA you are referring to? I would like to cut a GA next week.

That's is why I have asked. Do we need another beta for this? If we do the beta, we could drop the old code in GA, if not we will have to wait until at least 5.1.

We can't "drop" code once we go GA, we can only deprecate. I would feel poorly done to release 5.0 only to deprecate code in the follow up release, especially if we know now that we want to replace that code.

Exactly, that is is why I asked for another beta.

release beta

I am not sure what BETA you are referring to? I would like to cut a GA next week.

That's is why I have asked. Do we need another beta for this? If we do the beta, we could drop the old code in GA, if not we will have to wait until at least 5.1.

We can't "drop" code once we go GA, we can only deprecate. I would feel poorly done to release 5.0 only to deprecate code in the follow up release, especially if we know now that we want to replace that code.

Exactly, that is is why I asked for another beta.

Another beta is fine with me. I'd rather have an extra beta to solidify the API than release too quickly and deprecate.

@michael-o @garydgregory This ticket was sitting there for a month without any progress, no one gave a f**k and now you want me to do another BETA?

I reported the issue to have the case documented. I did not have any time before to work on that. Is that so unusual?

@michael-o We are all busy, I get that, so to me it is not unusual. I just went through a release cycle at work, so I've had almost no free time for FOSS.

@garydgregory It seems like @ok2c is upset about it...

What about the open questions guys?

What about the open questions guys?

Which one specifically? (Don't want to reread the whole pile now.)

What about the open questions guys?

Which one specifically? (Don't want to reread the whole pile now.)

These: https://github.com/apache/httpcomponents-client/pull/178#issue-346280555

@michael-o Any hope this PR being completed in any reasonably foreseeable future?

@michael-o I just created this draft to have everyone look at if whether this goes in the right direction or not. I will continue with the work in this PR on Thu.

@michael-o That does not answer the question, does it? You used this PR as a release blocker, so asking about a timeline for its completion is not something unreasonable in my opinion.

I have already answered your question:  I will continue with the work in this PR on Thu.

This PR has been closed in favor of #179.


Fix the error regarding except-syntax.

There is no configuration for "except-syntax" so when running the code sample Difference of two sets on 101-linq-samples/docs/sets-2.md it will throw an error. Thanks.

The original file has mixed line endings so when I committed changes the editor automatically normalized them to Windows-style (CRLF).
The only change is line 97:
"except-syntax"                 => new SetOperations().DifferenceOfSets(),

Hi, can we review this PR? Thanks.


VIH-10350 - Decommission obsolete feature flags

Jira link (if applicable)
VIH-10350
Change description
deleted code for FeatureToggleService
Checklist

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run


Readarr books and audiobooks support

Is your feature request related to a problem? Please describe.
I'd love for users to be able to request books and/or audiobooks to be thrown into readarr instance(s)
Describe the solution you'd like
An additional requests section for books where one could request ebooks and audiobooks
Describe alternatives you've considered
There really isn't a good solution for an alternative rather than just people giving me the requests and me filling them through readarr on my own.
Additional context
N/A

Hi, thanks for the feature request. These sounds like a doable suggestion, that is if there is a service or services that offers the ability to search for books/audiobooks and it's reliable and available for end users. I am not aware of any of these services, maybe google's book site, but their api is probably a paid service.
I'm open to any suggestions for services as I would love to add this in the future along with Lidarr support.


[Tools]Split COCO data for Semi-supervised object detection.

You can run python tools/misc/split_coco.py to split data/coco/annotations/instances_train2017.json to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Motivation
Split COCO data for Semi-supervised object detection.
Modification
Add a python file split_coco.py in tools/misc/.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

Hi, thanks for contributing the split script for the semi supervised learning. I wonder if the mmdetection supports the semi supervised learning for the object detection.


[zh-cn]Update content/zh-cn/docs/concepts/overview/working-with-objects/object-management.md

/lgtm
/approve


Make ContiguousMemory Equatable

I should be able to compare two slices with a[0...2] == a[3...5] or any two ContiguousMemory objects.

Fixed with https://github.com/aleph7/Upsurge/commit/e73257c30246c4ff0d9e1584806bac1aabc3c172


make slugify function configurable

See #198 #177

What’s the reasoning for this? Based on the previous tests with Japanese characters, the browser supported them fine as an anchor.

We closed it because no work needed to be done.
On Fri, Jul 27, 2018 at 2:26 PM Andy Wang<EMAIL_ADDRESS>wrote:

Because he closed his pull request, so I have to do it again.
At first I wanted to follow his solution(the uri-encoded solution), but
after I read your conversations, I think the raw and the uri-encoded
solution both have their own scenarios. Therefore, I don't want to
introduce a specific solution to the source code.
Also, the user can pass the same slugify function to both a toc-generator
and this renderer to make it consistent and controllable. By now I have to
copy your slugify function into my source code and pass it to the
toc-generator.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/probablyup/markdown-to-jsx/pull/199#issuecomment-408516574,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1p_oOE9w09gJ55T0uWCuGATsYBEGks5uK2l7gaJpZM4Vi_JC
.

Thanks! Will probably cut a release in the next day or two.


(GH-46) Enable tests to be run on Windows

Previously rubocop would raise warnings if git cloned all files LF as rubocop
always expects files on Windows to be CRLF.  This commit changes rubocop to
always expect ruby files to have LF line endings as per non-Windows OSes.

reviously only gems within the gemspec could be bundled however this prevents
developers using the preferred debug tools etc.  This commit adds the ability
for the Gemfile to include per profile and per project Gemfile additions via the
common ~/.gemfile and Gemfile.local files.  This commit also adds Gemfile.local
to the ignore list, so local files wil not be checked in.

Previously the rakefile always assumed in was on a non-Windows OS, using
/dev/null redirection.

Does this need a release?

I don't think so.   None of PRs I'll be doing will require a release as it's just test enablement.  No point doing ANY work until the tests are green on Windows.


Map dependency version ranges to Swift PM equivalents in generated Swift PM manifest

Currently, the dependency version is added directly to the generated manifest without translation. Instead, map the following:

latest.integration
version range.
version.+
dependency on a branch

Fix is here: https://github.com/gradle/gradle/pull/4299

This is done, I think we can close it.


Remove status from Chip

https://github.com/siliconcompiler/siliconcompiler/actions/runs/9292942165


refactor boost::python to avoid long compilation times

separate into different translation units so that irods_types doesn't need to completely recompile every time.

oops, reopening for cherry-pick to 4-2-stable


Normalize non-ASCII characters into Unicode characters

https://github.com/metanorma/bipm-si-brochure/issues/203
<completename language="en" script="Latn">de Mirand{\'{e}}s, Estefan{\'{\i}}a</completename>
That is LaTeX, and of course, I'm not expecting LaTeX. Very very very very strongly request that such characters be resolved into the correct UTF-8 characters; we can safely assume in 2022 that consumers can process UTF-8.

From @ronaldtse

This issue requires Relaton to deal with BibTeX parsing and semantics. As you remember the {...} means that capitalization should not be changed for the text in between. We've never dealt with those and will need to.

In any case, this issue is not part of the SI Brochure, this is for the MEPs, so should not be affected by the milestone.

This is the BibTeX syntax that we need to parse and we will need some library to do a reasonable job of normalizing them.

@opoudjis it seems the issue doesn't exist in the last relaton-bipm version 1.14.1.
relaton fetch "BIPM Metrologia 55 1 L13"
[relaton-bipm] ("BIPM Metrologia 55 1 L13") fetching...
[relaton-bipm] ("BIPM Metrologia 55 1 L13") found Metrologia 55 1
<bibdata type="article" schema-version="v1.2.1">
...
  <contributor>
    <role type="author"/>
    <person>
      <name>
        <completename language="en" script="Latn">E de Mirandés</completename>
      </name>
    </person>
  </contributor>

Could you check it please?

Confirmed, closing


feat(block): allow gridRowGap

Description
allow gridRowGap and alphabetize to be consistent with gridColumnGap
Scope

[ ] Patch: Bug Fix
[x] Minor: New Feature
[ ] Major: Breaking Change

Thanks @leyanlo !


[pcl:arm64-android] Build error

Package: pcl:arm64-android -> 1.13.0#3
Host Environment

Host: x64-windows
Compiler: Clang 12.0.8
vcpkg-tool version: 2023-06-15-8c254a5fb6c503615834fc66bd0717664a339a2e
vcpkg-scripts version: e9e0e9758 2023-10-24 (21 hours ago)

To Reproduce
vcpkg install pcl --triplet arm64-android
Failure logs
-- Using cached PointCloudLibrary-pcl-371a8e1373f7b2f66bbb92291be2f3e50dc19856.tar.gz.
-- Cleaning sources at C:/compiler/vcpkg/buildtrees/pcl/src/e50dc19856-02604d3cdb.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/compiler/vcpkg/downloads/PointCloudLibrary-pcl-371a8e1373f7b2f66bbb92291be2f3e50dc19856.tar.gz
-- Applying patch add-gcc-version-check.patch
-- Applying patch fix-check-sse.patch
-- Applying patch fix-numeric-literals-flag.patch
-- Applying patch pcl_config.patch
-- Applying patch pcl_utils.patch
-- Applying patch install-examples.patch
-- Applying patch no-absolute.patch
-- Applying patch add_bigobj_option.patch
-- Applying patch outofcore_viewer_remove_include.patch
-- Applying patch fix_opennurbs_win32.patch
-- Applying patch disable_kinfu_for_cuda12.patch
-- Applying patch devendor-zlib.patch
-- Using source at C:/compiler/vcpkg/buildtrees/pcl/src/e50dc19856-02604d3cdb.clean
-- Configuring arm64-android
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: C:/compiler/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe -v
    Working Directory: C:/compiler/vcpkg/buildtrees/pcl/arm64-android-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      C:\compiler\vcpkg\buildtrees\pcl\config-arm64-android-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:252 (vcpkg_execute_required_process)
  ports/pcl/portfile.cmake:46 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)

C:\compiler\vcpkg\buildtrees\pcl\config-arm64-android-out.log
[1/2] "C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" -E chdir "../../arm64-android-dbg" "C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" "C:/compiler/vcpkg/buildtrees/pcl/src/e50dc19856-02604d3cdb.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/compiler/vcpkg/packages/pcl_arm64-android/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DPCL_ALLOW_BOTH_SHARED_AND_STATIC_DEPENDENCIES=ON" "-DPCL_BUILD_WITH_BOOST_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_FLANN_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_QHULL_DYNAMIC_LINKING_WIN32=0" "-DPCL_SHARED_LIBS=0" "-DWITH_DAVIDSDK=OFF" "-DWITH_DOCS=OFF" "-DWITH_DSSDK=OFF" "-DWITH_ENSENSO=OFF" "-DWITH_OPENMP=OFF" "-DWITH_OPENNI=OFF" "-DWITH_PNG=ON" "-DWITH_QHULL=ON" "-DWITH_RSSDK=OFF" "-DWITH_RSSDK2=OFF" "-DBUILD_apps=OFF" "-DWITH_CUDA=OFF" "-DBUILD_CUDA=OFF" "-DBUILD_GPU=OFF" "-DBUILD_examples=OFF" "-DWITH_LIBUSB=OFF" "-DWITH_OPENGL=OFF" "-DWITH_OPENNI2=OFF" "-DWITH_PCAP=OFF" "-DWITH_QT=OFF" "-DBUILD_simulation=OFF" "-DBUILD_surface_on_nurbs=OFF" "-DBUILD_tools=OFF" "-DWITH_VTK=OFF" "-DBUILD_visualization=OFF" "-DCMAKE_MAKE_PROGRAM=C:/compiler/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DCMAKE_SYSTEM_NAME=Android" "-DCMAKE_SYSTEM_VERSION=21" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/toolchains/android.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-android" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=static" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/compiler/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/compiler/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DANDROID_ABI=arm64-v8a" "-DBUILD_apps=OFF" "-DBUILD_examples=OFF" "-DBUILD_tools=OFF"
FAILED: ../../arm64-android-dbg/CMakeCache.txt
"C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" -E chdir "../../arm64-android-dbg" "C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" "C:/compiler/vcpkg/buildtrees/pcl/src/e50dc19856-02604d3cdb.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/compiler/vcpkg/packages/pcl_arm64-android/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DPCL_ALLOW_BOTH_SHARED_AND_STATIC_DEPENDENCIES=ON" "-DPCL_BUILD_WITH_BOOST_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_FLANN_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_QHULL_DYNAMIC_LINKING_WIN32=0" "-DPCL_SHARED_LIBS=0" "-DWITH_DAVIDSDK=OFF" "-DWITH_DOCS=OFF" "-DWITH_DSSDK=OFF" "-DWITH_ENSENSO=OFF" "-DWITH_OPENMP=OFF" "-DWITH_OPENNI=OFF" "-DWITH_PNG=ON" "-DWITH_QHULL=ON" "-DWITH_RSSDK=OFF" "-DWITH_RSSDK2=OFF" "-DBUILD_apps=OFF" "-DWITH_CUDA=OFF" "-DBUILD_CUDA=OFF" "-DBUILD_GPU=OFF" "-DBUILD_examples=OFF" "-DWITH_LIBUSB=OFF" "-DWITH_OPENGL=OFF" "-DWITH_OPENNI2=OFF" "-DWITH_PCAP=OFF" "-DWITH_QT=OFF" "-DBUILD_simulation=OFF" "-DBUILD_surface_on_nurbs=OFF" "-DBUILD_tools=OFF" "-DWITH_VTK=OFF" "-DBUILD_visualization=OFF" "-DCMAKE_MAKE_PROGRAM=C:/compiler/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DCMAKE_SYSTEM_NAME=Android" "-DCMAKE_SYSTEM_VERSION=21" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/toolchains/android.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-android" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=static" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/compiler/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/compiler/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DANDROID_ABI=arm64-v8a" "-DBUILD_apps=OFF" "-DBUILD_examples=OFF" "-DBUILD_tools=OFF"
-- Android: Targeting API '21' with architecture 'arm64', ABI 'arm64-v8a', and processor 'aarch64'
-- Android: Selected unified Clang toolchain
-- The C compiler identification is Clang 12.0.8
-- The CXX compiler identification is Clang 12.0.8
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Users/rdecelis/AppData/Local/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/windows-x86_64/bin/clang.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Users/rdecelis/AppData/Local/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/windows-x86_64/bin/clang++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
-- Performing Test LIBATOMIC_NOT_NEEDED
-- Performing Test LIBATOMIC_NOT_NEEDED - Success
-- Could NOT find ClangFormat: Found unsuitable version "12.0.8", but required is at least "14" (found C:/Users/rdecelis/AppData/Local/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/windows-x86_64/bin/clang-format.exe)
-- Performing Test HAVE_MM_MALLOC
Access violation
[2/2] "C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" -E chdir ".." "C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" "C:/compiler/vcpkg/buildtrees/pcl/src/e50dc19856-02604d3cdb.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/compiler/vcpkg/packages/pcl_arm64-android" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DPCL_ALLOW_BOTH_SHARED_AND_STATIC_DEPENDENCIES=ON" "-DPCL_BUILD_WITH_BOOST_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_FLANN_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_QHULL_DYNAMIC_LINKING_WIN32=0" "-DPCL_SHARED_LIBS=0" "-DWITH_DAVIDSDK=OFF" "-DWITH_DOCS=OFF" "-DWITH_DSSDK=OFF" "-DWITH_ENSENSO=OFF" "-DWITH_OPENMP=OFF" "-DWITH_OPENNI=OFF" "-DWITH_PNG=ON" "-DWITH_QHULL=ON" "-DWITH_RSSDK=OFF" "-DWITH_RSSDK2=OFF" "-DBUILD_apps=OFF" "-DWITH_CUDA=OFF" "-DBUILD_CUDA=OFF" "-DBUILD_GPU=OFF" "-DBUILD_examples=OFF" "-DWITH_LIBUSB=OFF" "-DWITH_OPENGL=OFF" "-DWITH_OPENNI2=OFF" "-DWITH_PCAP=OFF" "-DWITH_QT=OFF" "-DBUILD_simulation=OFF" "-DBUILD_surface_on_nurbs=OFF" "-DBUILD_tools=OFF" "-DWITH_VTK=OFF" "-DBUILD_visualization=OFF" "-DCMAKE_MAKE_PROGRAM=C:/compiler/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DCMAKE_SYSTEM_NAME=Android" "-DCMAKE_SYSTEM_VERSION=21" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/toolchains/android.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-android" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=static" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/compiler/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/compiler/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DANDROID_ABI=arm64-v8a"
FAILED: ../CMakeCache.txt
"C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" -E chdir ".." "C:/compiler/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe" "C:/compiler/vcpkg/buildtrees/pcl/src/e50dc19856-02604d3cdb.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/compiler/vcpkg/packages/pcl_arm64-android" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DPCL_ALLOW_BOTH_SHARED_AND_STATIC_DEPENDENCIES=ON" "-DPCL_BUILD_WITH_BOOST_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_FLANN_DYNAMIC_LINKING_WIN32=0" "-DPCL_BUILD_WITH_QHULL_DYNAMIC_LINKING_WIN32=0" "-DPCL_SHARED_LIBS=0" "-DWITH_DAVIDSDK=OFF" "-DWITH_DOCS=OFF" "-DWITH_DSSDK=OFF" "-DWITH_ENSENSO=OFF" "-DWITH_OPENMP=OFF" "-DWITH_OPENNI=OFF" "-DWITH_PNG=ON" "-DWITH_QHULL=ON" "-DWITH_RSSDK=OFF" "-DWITH_RSSDK2=OFF" "-DBUILD_apps=OFF" "-DWITH_CUDA=OFF" "-DBUILD_CUDA=OFF" "-DBUILD_GPU=OFF" "-DBUILD_examples=OFF" "-DWITH_LIBUSB=OFF" "-DWITH_OPENGL=OFF" "-DWITH_OPENNI2=OFF" "-DWITH_PCAP=OFF" "-DWITH_QT=OFF" "-DBUILD_simulation=OFF" "-DBUILD_surface_on_nurbs=OFF" "-DBUILD_tools=OFF" "-DWITH_VTK=OFF" "-DBUILD_visualization=OFF" "-DCMAKE_MAKE_PROGRAM=C:/compiler/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DCMAKE_SYSTEM_NAME=Android" "-DCMAKE_SYSTEM_VERSION=21" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/toolchains/android.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-android" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/compiler/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=static" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/compiler/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/compiler/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DANDROID_ABI=arm64-v8a"
-- Android: Targeting API '21' with architecture 'arm64', ABI 'arm64-v8a', and processor 'aarch64'
-- Android: Selected unified Clang toolchain
-- The C compiler identification is Clang 12.0.8
-- The CXX compiler identification is Clang 12.0.8
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Users/rdecelis/AppData/Local/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/windows-x86_64/bin/clang.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Users/rdecelis/AppData/Local/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/windows-x86_64/bin/clang++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
-- Performing Test LIBATOMIC_NOT_NEEDED
-- Performing Test LIBATOMIC_NOT_NEEDED - Success
-- Could NOT find ClangFormat: Found unsuitable version "12.0.8", but required is at least "14" (found C:/Users/rdecelis/AppData/Local/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/windows-x86_64/bin/clang-format.exe)
-- Performing Test HAVE_MM_MALLOC
Access violation
ninja: build stopped: subcommand failed.

Additional context
### Related Issues
- [ ] https://github.com/microsoft/vcpkg/issues/28793
- [ ] https://github.com/microsoft/vcpkg/issues/32136

@dg0yt could we rename the issue #32136 with "[pcl:arm64-android] Build error" instead of "[<pcl] build failure". I think that is not enough specific issue title.
This error was reported and closed in January of this year according to issue #28793.
Maybe generating a task list enumerating related opened issues (like in this issue )could be useful to trace and solve the problem:

I continue the conversation in #32136.


Modify UI to allow the creation from the templates from the UI

Context
We would like to add the option of creating llm applications from the UI. We want to start with #254
See #214 for more details.
UI
https://link.excalidraw.com/l/6rfBpfMgkCb/7M0WTXRAkh1
Implementation
See #255 for how the UI will interact with the backend

@mmabrouk I would like to be assigned this. Looking to move the functions with comment TODO : move to api.ts to the appropriate file.

@witehound that's great! I will assign it to you.
Since this issue is dependent on lots of other things in the backend (see discussion #214 and project (https://github.com/orgs/Agenta-AI/projects/3)), I suggest you implement the UI with mockup functions in api.ts that return the list templates, and another creates the app. As soon as the backend part is done (hopefully end of this week), we can connect it to this.

@mmabrouk great

@mmabrouk can you help with these “ I suggest you implement the UI with mockup functions in api.ts that return the list templates, and another creates the app.” I don’t seem to be able to find them in the api.ts. Also can you explain #254 I believe the list from the mock-up function have them? Or do I have to worry about inputs as https://link.excalidraw.com/l/6rfBpfMgkCb/7M0WTXRAkh1 doesn’t have any inputs.

The mockup functions don't exist yet in the api.ts, but these would be trivial. We would need two functions:

getTemplates
which would return list of templates each an object that includes the template name as a string (we can add later information later).

startTemplate(appName, templateObj)
which would be an empty function that is called when the user click on start.

I don't think you have to worry about #254, these describe the internal api in the templates. The logic of translating these to the playground would be automatically taken care of the system when the docker image is started.
This issue is just about implementing the UI to enable the creation of a new LLM app from the UI using these two calls to the backend. What happens later is actually already implemented.

@mmabrouk great I’m right on track. For the modal that opens to “Write your own app” would it be redirecting to YouTube or playing the YouTube video in the app? If it plays in the app can I install a package called react-youtube to handle the video? If am adding a new package with npm install is there any other file I need to make changes to?

Awesome @witehound ! npm install is all you need. The video should be embedded.

@mmabrouk this is how the UI is looking let me know if anything should be fixed, tried to be consistency with UI.

<img width="1440" alt="Screenshot 2023-08-07 at 18 49

20" src="https://github.com/Agenta-AI/agenta/assets/26417477/21cc4553-d8a0-4ff8-80e5-8df2036b66e7">

Thanks a lot @witehound ! That looks great! I agree with the idea of leaving out the add_new button for consistency.
My only minor comment is about the UI. It would be nice if you could play around with the margins and padding to improve the spacing a bit.
I expect the backend logic to be finished by the end of the week, then we can integrate with your code, until then I suggest you park a PR that we can merge to a new branch where we can work for this new feature.

@mmabrouk made the padding much better but always open to change do I do a pr for that feature to main or you’d create a branch for that feature and I can make a pr to that?

Apologies for the late answer. I created a new branch called templates_from_ui that we can use for the integration, please do a PR for merge there. Thanks @witehound !


953 Normalize docket_number and case_name in FreeOpinionReport

This PR addresses issue #953 by standardizing the parsing of docket_number in the FreeOpinionReport, which previously differed from other reports. This discrepancy was causing inconsistencies in the Docket Number and triggering conflict errors in issue #3541.
Now, the parsing aligns with that of the BaseDocketReport. Additionally, I observed that the parsing of the Case Name in FreeOpinionReport did not match that in BaseDocketReport, occasionally leading to slight differences. Therefore, I adjusted it to use the same parser as BaseDocketReport.

I added local tests for this class. I noticed that this report diverges by returning a list of FreeOpinionRow instead of a dictionary containing the parsed data. The data from each row is accessed via properties in CL.
For test purposes, a metadata property with a data dictionary was introduced to facilitate JSON serialization.

Is there a reason to retrieve the docket metadata as properties in CL? Maybe we could standardize this class to return a dict too. It will just require a minor adjustment in CL.

The tests are failing; however, it doesn't seem related to the changes in this PR, as there are also other PRs where they've failed today. Perhaps a dependency needs to be updated or something similar.

Is there a reason to retrieve the docket metadata as properties in CL? Maybe we could standardize this class to return a dict too. It will just require a minor adjustment in CL.

No, not that I can think of. I guess we should do that too, because we can. Want to do that and then I'll review this one more time?

Thanks, I've applied the tweak, so now the FreeOpinionReport returns a dictionary containing the metadata instead of properties.

Added an additional test covering the case where a document belonging to the previous row (case) has some fields empty, and these are filled with values from the previous row.

This has also been updated and tested in  https://github.com/freelawproject/courtlistener/pull/3942

Great, thank you!

I think we can release this as version 2.6.0. We'll need to update the read me with the breaking change. We were so close to 2.5.100! Oh well!
Want to give that a go, Alberto?


Fix high precision mousewheel shortcuts in multiple actions on REAPER v6.76+

https://github.com/reaper-oss/sws/pull/1787#issuecomment-1934495777

v6.76 - February 28 2023

Mouse: improve precision of mouse gestures and mousewheel when bound to actions

The current SDK does not specify negative values other than -1:

val/val2 are used for actions triggered by MIDI/OSC/mousewheel
   - val = [0..127] and val2 = -1 for MIDI CC,
   - val2 >=0 for MIDI pitch or OSC with value = (val2|(val<<7))/16383.0
   - relmode absolute(0) or 1/2/3 for relative adjust modes

v5.99 & v6.75
mwdown val=63 val2=-1 relmode=2
mwup   val=65 val2=-1 relmode=2

v6.76 & v7.11 (typical, macOS)
mwdown val=127 val2=-161 relmode=1
mwup   val=1   val2=-161 relmode=1

REAPER v7.11 computes val2 (valhw in SWS) from WM_MOUSEWHEEL's delta in wParam the following way:
int MWDeltaToVal2(double delta)
{
#ifdef __APPLE__
  delta /= 16;
#elifdef _WIN32
  delta /= 8;
#endif
  delta = std::abs(delta);
  delta = std::ceil(delta) - delta;
  delta = delta * 256 + 0.5;
  return -1 - delta;
}

(On Linux, WM_MOUSEWHEEL with delta other than +-120 appear to be ignored.)
It then uses it like this in actions (validating that this PR is the correct approach for those values):
double AdjustRelative(const int relmode, int val, const int val2)
{
  switch(relmode) {
  case 1:
    if(val >= 0x40)
      val |= ~0x3f;
    break;
  case 2:
    val -= 0x40;
  case 3:
    if(val & 0x40)
      val = -(val & 0x3f);
  default:
    return val;
  }

  if(val == 0 || val2 >= -1)
    return val;

  const double fraction = static_cast<double>(-1 - val2) / 256.0;
  return val >= 0 ? val - fraction : val + fraction;
}

The following actions are affected by this commit (although most of them do not officially support the mousewheel):

SWS/BR: Adjust playrate
SWS/S&M: Live Config #n - Apply config
SWS/S&M: Live Config #n - Preload config
SWS/S&M: Select project
SWS/S&M: Trigger preset for FX n of selected track
SWS/S&M: Trigger preset for selected FX of selected track
SWS/wol: Adjust envelope or track height under mouse cursor
SWS/wol: Adjust selected envelope height
SWS/wol: Adjust selected envelope or last touched track height

:white_check_mark: Build sws 1056-master completed (commit https://github.com/reaper-oss/sws/commit/e3c7841ba7 by @cfillion)

Windows 64-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.dll
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-v6.76-mwheel-actions-e3c7841b.exe
build/sws_python64.py

Windows 32-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.dll
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-v6.76-mwheel-actions-e3c7841b.exe
build/sws_python32.py

macOS x86 64-bit

build/sws-<IP_ADDRESS>-Darwin-x86_64-v6.76-mwheel-actions-e3c7841b.dmg
build/reaper_sws-x86_64.dylib

macOS x86 32-bit

build/reaper_sws-i386.dylib
build/sws-<IP_ADDRESS>-Darwin-i386-v6.76-mwheel-actions-e3c7841b.dmg

macOS ARM 64-bit

build/reaper_sws-arm64.dylib
build/sws-<IP_ADDRESS>-Darwin-arm64-v6.76-mwheel-actions-e3c7841b.dmg

Linux x86 64-bit

build/reaper_sws-x86_64.so
build/sws-<IP_ADDRESS>-Linux-x86_64-v6.76-mwheel-actions-e3c7841b.tar.xz

Linux x86 32-bit

build/reaper_sws-i686.so
build/sws-<IP_ADDRESS>-Linux-i686-v6.76-mwheel-actions-e3c7841b.tar.xz

Linux ARM 64-bit

build/sws-<IP_ADDRESS>-Linux-aarch64-v6.76-mwheel-actions-e3c7841b.tar.xz
build/reaper_sws-aarch64.so

Linux ARM 32-bit

build/sws-<IP_ADDRESS>-Linux-armv7l-v6.76-mwheel-actions-e3c7841b.tar.xz
build/reaper_sws-armv7l.so


Backport #34 and make release into Galactic, Humble and Rolling

Done in
Backport: #39, #40
Release: rosdistro#34832, rosdistro#34833, rosdistro#34834


Small fix | Disable eslint warn about Slack reporter's console.log

Description :sparkles:
Figured new PR would not mess / have effect with other project specific PR as this file is under shared/.
Local prettier/Eslint wanted also to make one line look beautiful.
Fixes these issues:

API branch is deployed to platta: https://kesaseteli-pr2137.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

HANDLER branch is deployed to platta: https://handler-pr2137.dev.hel.ninja :rocket::rocket::rocket:

YOUTH branch is deployed to platta: https://youth-pr2137.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://handler-pr2137.dev.hel.ninja :laughing::tada::tada::tada:

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2137.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://kesaseteli-pr2137.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://youth-pr2137.dev.hel.ninja :laughing::tada::tada::tada:


Hot module Reload not reloading the page

Hot Module reload doesn't seem to be working correctly. It looks like the app is registering a change, but is not able to refresh. Not really sure where to start to debug this.
This is the browser console output:

Adding some more info - In my local webpack config, when I override the before function with the exact same code that is already set up in Vanir, I get different behaviour(!). It still picks up on the change, but instead realises it needs to do a full reload. Which is better than NO reload, but still not optimal. Here's the log with some more promising error messages:
Browser Console Log:
[HMR] Cannot apply update. Need to do a full reload!
[HMR] Error: Aborted because 59242 is not accepted
      Update propagation: 59242 -> 80186 -> 8376

webpack.config.js:
const webpack = require('@dolittle/vanir-webpack/frontend');
module.exports = (env, argv) => {
    return webpack(env, argv, '/_/my-microservice', config => {
        // copy&pasted from vanir codebase
        config.devServer.before= (app, server, compiler) => {
            app.get('*', (req, res, next) => {
                const match = req.originalUrl.match(fileTypes);
                if (match && match.length > 0) {
                    next();
                    return;
                }
                const html = require('./HtmlInterceptorPlugin').getGeneratedHtml();
                res.send(html);
            });
        }
        config.devServer.proxy = {
            '/_/my-microservice/graphql': 'http://localhost:3006',
            '/api': 'http://localhost:3006'
        };
    }, 8084, 'MyApplication');
};

I think we're touching on multiple problems.
The hot loading itself seems to be stopped somehow when running through the composition that we do with typically nginx. I noticed in a project yesterday that didn't use this that it was automatically responding - which it doesn't in other projects that uses the nginx composition.
The second problem is as you point on, the fact that it reloads the full page.
More investigation needed :)

Figured out what the main issue here is. The Hot Reload payload comes in the form of a JSON. The reason the workaround works, is that "fileTypes" is undefined.
The fix will be in the devServer.js file with going from:
const fileTypes = /\.(js|css|html|png|jpg|jpeg|gif)$/;

to
const fileTypes = /\.(js|json|css|html|png|jpg|jpeg|gif)$/;

Adding the JSON file as a known file type and one that it will then carry over to the next middleware.


[feature] Add art:remote commands to manage artifactory credentials

Partially implements #36

I realized that I am missing some documentation here, so I will be adding it in a future PR 🤞


Add Support Image Maker script

I've added a script that can make images that can be used with Auto Support Selection.

I've added the scaling script into it so I think it should also work fine on phones with a notch too.
To run the script, select it in AnkuLua, go to support selection screen and press Play.
The script ends almost immediately.
For images to be saved, the Servant+corresponding CE should be completely on screen.
Only 2 Servant+CE can be completely on screen at a time.
The images are stored in the same directory as the script and named as: ce_0.png, ce_1.png, servant_0.png, servant_1.png.
Some generated images:

Amazing. :o
My only nitpick is that I think the snapshots should be saved to a different folder.

Yeah, I was thinking of that too but couldn't settle on a location. Open for suggestions.

Since you would normally execute this script a few times in a row to collect different CE images, I would suggest creating a folder per script run with a folder name containing the current date and time.
I don't know if Ankulua supports creating folders, though.
My idea is to use something like this:
--gets current date and time in the format 20200412-221630
local datetime = os.date('%Y%m%d-%H%M%S')
local folder = 'support_' .. datetime
region:save(folder .. '/servant_' .. i .. '.png')

If Ankulua can't handle creating folders through save, you could also try os.execute('mkdir ' .. folder)

Also we could make the servant images less wide so the MLB star is automatically cut off. So instead of supportBound:getW() use 125

@reconman I've made the updates you suggested.
Do let me know if there is any other change to make.

The wiki page: How to take a screenshot and resize properly, has to be updated with info about how to use this script.

@MathewSachin @potchy Regarding the wiki changes, I'm currently creating a better documentation using Github pages + docsify. I'll create a Pull Request for that once I'm done.
Then everyone can suggest changes to the documentation.

@MathewSachin Do you mind adding documentation to https://29988122.github.io/Fate-Grand-Order_Lua/#/support-image-maker (support-image-maker.md) and also linking to it from the Extra Scripts page?
Right now the page is referenced by features.md at the "Follow this guide" part.

Sure!


Use OptionsLogFormatter for Options::Dump

This PR replaces the code in the Options::Dump method with code using the Options infrastructure.  A new "SerializePrintableOptions" method was added to the Configurable class which allows the values not serializable by the options to be included in the output.  A ConfigOptions::Depth::KPrintable was added to tell the classes to invoked this method as part of the serialization process.
The Options::Dump methods now use the this infrastructure to generate their output.  The code in the GetPrintableOptions methods of various was either deleted (because the values were serialized as Options) or moved into the SerializePrintableOptions method.

@ofriedma after #651

@mrambacher can you please solve conflicts so I can review it?

This PR fixes #692

lgtm

I manually tested the ARM compile, it worked fine

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 9 committers have signed the CLA.:white_check_mark: udi-speedb:x: git-hulk:x: ofriedma:x: Yuval-Ariel:x: mrambacher:x: GitHub Runner Bot:x: zaidoon1:x: maxb-io:x: ayulasGitHub Runner Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Updating fake migration data for testing purposes.

Modify migrater.py to reflect removal of slug field from Person.
Update db.sql with new data.

Looks okay.

BTW, @gvwilson there will be another update needed when we merge #243. I'll ping you then.

Sure - thanks.