[Bug]: Theme check doesn't detect missing translations for schema

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
Identifies missing or additional translations in locale files.
Actual behavior
Missing translations not found and no errors reported.
Actual output:

279 files inspected, 0 offenses detected, 0 offenses auto-correctable

Verbose output
2023-04-03T20:14:57.484Z: Running command theme check
  shopify:theme:check init version<EMAIL_ADDRESS>argv: [ '-c', 'translation', '--verbose' ] +0ms
2023-04-03T20:14:57.511Z:
Running system process:
  · Command: ruby -v
  · Working directory: /home/bmandl/shopify/dawn

2023-04-03T20:14:57.586Z:
Running system process:
  · Command: bundle -v
  · Working directory: /home/bmandl/shopify/dawn

2023-04-03T20:14:57.853Z: Reading the content of file at ../../.nvm/versions/node/v18.12.1/lib/node_modules/<EMAIL_ADDRESS>2023-04-03T20:14:57.861Z:
Running system process:
  · Command: bundle install
  · Working directory: /home/bmandl/.nvm/versions/node/v18.12.1/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-04-03T20:14:58.416Z:
Running system process:
  · Command: bundle exec ruby /home/bmandl/.nvm/versions/node/v18.12.1/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/bin/shopify theme check . --category translation --output text
  · Working directory: .

Checking . ...
279 files inspected, 0 offenses detected, 0 offenses auto-correctable
2023-04-03T20:15:01.769Z: Failed to report usage analytics: Couldn't find a a package.json traversing directories from /home/bmandl/shopify/dawn
2023-04-03T20:15:01.770Z: Completed command theme check

Reproduction steps

Add some new translation in en.default.schema.json file
run shopify theme check --category translation in theme folder

Operating System
wsl2 with Ubuntu 20.04 running on Windows 10
Shopify CLI version (check your project's package.json if you're not sure)
3.44.1
Shell
wsl2 - Ubuntu 20.04
Node version (run node -v if you're not sure)
v18.12.1
What language and version are you using in your application?
Ruby 3.0.6p216, Node.js v18.12.1

Hi @bmandl . Thanks for rising up this issue!. Let me ping @Shopify/theme-developer-tools so they can take a look at ir


comboStateStyles with unused state name will lead to unexpected rendering result

G6 Version: 3.5.1
Platform: macOS
Mini Showcase(like screenshots):
CodePen Link: codepen link

Solved by v3.5.3.


Changed checksum for Go pkg<EMAIL_ADDRESS>

Bug Report
Checksum for<EMAIL_ADDRESS>Go package seems to have changed. A project where go.sum mentions the old checksum fails to fetch dependencies since about 1 week:
$ go mod vendor
 verifying<EMAIL_ADDRESS>checksum mismatch
     downloaded: h1:ESV2s2oQsZPQiQ8VfC8S5DzEnO/azXF82Fj++5qpAkw=
     go.sum:     h1:Y/QS7FrEQ0KrURc0NYsbD9n6JhR2B4REs2Ki39RBDno=
 SECURITY ERROR

Yep, we had to re-release that version because our deploy jobs broken. Use v0.18.1 instead if possible.
We should document this issue in the migration guide and release notes.
/assign
/kind documentation

v0.17.2 has been released, and the release notes for v0.17.1 say to not use that version.


Newer sklearn version changes results completely

It appears that with sklearn version 1.1.1 the triplet classes not represented in the test sample will not be represented as nan anymore.
The following warning is shown as well:
../lib/python3.8/site-packages/sklearn/metrics/_ranking.py:877: UserWarning: No positive class found in y_true, recall is set to one for all thresholds.
The resulting classwise AP vector from average_precision_score does not have nan for unrepresented classes, but -0., which changes the results completely (significantly lower, e.g. 0.87 mAP to 0.24 mAP).
Tested with sklearn versions 1.0.2 and 1.1.1

Thank you for the information, we will inspect how the latest update of sklearn lib affects the behaviour of ivtmetrics. For the meantime, we encourage all users to stick with sklearn <= 1.02 for comparable results. Meanwhile, we will be rolling out a custom 'no library' implementation of AP metrics. This will replace the sklearn in our next release.

Great to hear, thank you.
I took some screenshots for illustration, maybe they'll help you as well:

Value issue with sklearn version update is now resolved in the ivtmetrics v0.1.1
Thank you


Letters are displayed uncompletely

Letters below the baseline of the selected font are displayed incompletely in input fields and output fields:

which browser?


[Pirk 38]: Update Javadocs for Schema Loaders

Whoops. Still a n00b, need to merge upstream first.


get_atomic_order in kucoin.client.Market is not working

The issue is self-explanatory. When you run get_atomic_order for any symbol, you get 404-{"code":"404","msg":"not exist"}.
https://github.com/Kucoin/kucoin-python-sdk/blob/9c4190c86fb749b945c0e7c4995b6b03b2c53359/kucoin/market/market.py#L178

Due to many changes in the SDK, please refer to our latest documentation. https://www.kucoin.com/docs/beginners/introduction
Please try updating to the latest version of the SDK and modify your code to try again.
If you encounter any issues, feel free to provide feedback.


Feature Request: ability to copy user message

Currently the copy icon only appears next to assistant message but if I want to ask the same question in a new chat I just can't select the text nor copy it.

I see this is fixed so closing


python312Packages.libknot: 3.3.7 -> 3.3.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.libknot is: Python bindings for libknot
meta.homepage for python312Packages.libknot is: https://gitlab.nic.cz/knot/knot-dns/-/tree/master/python/libknot
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.8 with grep in /nix/store/s4c3ck8g30ca5484mgwizzlriw08bzgc-python3.12-libknot-3.3.8
found 3.3.8 in filename of file in /nix/store/s4c3ck8g30ca5484mgwizzlriw08bzgc-python3.12-libknot-3.3.8

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

prometheus-knot-exporter
python311Packages.libknot
python312Packages.libknot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s4c3ck8g30ca5484mgwizzlriw08bzgc-python3.12-libknot-3.3.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.libknot https://github.com/r-ryantm/nixpkgs/archive/976ead65c8840afabeda804af90db9d12a56c674.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/976ead65c8840afabeda804af90db9d12a56c674#python312Packages.libknot

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s4c3ck8g30ca5484mgwizzlriw08bzgc-python3.12-libknot-3.3.8
ls -la /nix/store/s4c3ck8g30ca5484mgwizzlriw08bzgc-python3.12-libknot-3.3.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

prometheus-knot-exporter
prometheus-knot-exporter.dist
python311Packages.libknot
python311Packages.libknot.dist
python312Packages.libknot
python312Packages.libknot.dist

Maintainer pings
cc @mweinelt for testing.

Sounds OK.  Probably best in tandem with https://github.com/NixOS/nixpkgs/pull/329373


it looks like the isochrone app is down, can you please make it available again? thanks.

Hi,
Thanks for reporting the issue.
The app is back up and running.


New tag type not seen - M3 1.3" Peghook

Describe the bug
M3 1.3" Peghook tag is added & works with AP, but does not show up in HA
Similar to bug #133
I needed to add this json to the AP for it to show up there
https://github.com/jjwbruijn/OpenEPaperLink/blob/master/resources/tagtypes/43.json
Logs show
2024-05-06 10:26:54.597 WARNING (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] Id not in hwmap, please open an issue on github about this.67
2024-05-06 10:26:54.597 ERROR (Thread-11024 (connection_thread)) [websocket] error from callback <bound method Hub.on_message of <custom_components.open_epaper_link.hub.Hub object at 0x7f86576298b0>>: 67
2024-05-06 10:26:54.597 DEBUG (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] Websocket error, most likely on_message crashed
2024-05-06 10:26:54.597 DEBUG (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] 67
2024-05-06 10:26:58.635 WARNING (Thread-3 (connection_thread)) [custom_components.open_epaper_link.hub] Id not in hwmap, please open an issue on github about this.67
2024-05-06 10:26:58.635 ERROR (Thread-3 (connection_thread)) [websocket] error from callback <bound method Hub.on_message of <custom_components.open_epaper_link.hub.Hub object at 0x7f87385f9d60>>: 67
2024-05-06 10:26:58.635 DEBUG (Thread-3 (connection_thread)) [custom_components.open_epaper_link.hub] Websocket error, most likely on_message crashed
2024-05-06 10:26:58.635 DEBUG (Thread-3 (connection_thread)) [custom_components.open_epaper_link.hub] 67
2024-05-06 10:26:58.640 WARNING (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] Id not in hwmap, please open an issue on github about this.67
2024-05-06 10:26:58.640 ERROR (Thread-11024 (connection_thread)) [websocket] error from callback <bound method Hub.on_message of <custom_components.open_epaper_link.hub.Hub object at 0x7f86576298b0>>: 67
2024-05-06 10:26:58.640 DEBUG (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] Websocket error, most likely on_message crashed
2024-05-06 10:26:58.640 DEBUG (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] 67
2024-05-06 10:27:13.573 WARNING (Thread-3 (connection_thread)) [custom_components.open_epaper_link.hub] Id not in hwmap, please open an issue on github about this.67
2024-05-06 10:27:13.573 ERROR (Thread-3 (connection_thread)) [websocket] error from callback <bound method Hub.on_message of <custom_components.open_epaper_link.hub.Hub object at 0x7f87385f9d60>>: 67
2024-05-06 10:27:13.573 DEBUG (Thread-3 (connection_thread)) [custom_components.open_epaper_link.hub] Websocket error, most likely on_message crashed
2024-05-06 10:27:13.573 DEBUG (Thread-3 (connection_thread)) [custom_components.open_epaper_link.hub] 67
2024-05-06 10:27:13.574 WARNING (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] Id not in hwmap, please open an issue on github about this.67
2024-05-06 10:27:13.574 ERROR (Thread-11024 (connection_thread)) [websocket] error from callback <bound method Hub.on_message of <custom_components.open_epaper_link.hub.Hub object at 0x7f86576298b0>>: 67
2024-05-06 10:27:13.574 DEBUG (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] Websocket error, most likely on_message crashed
2024-05-06 10:27:13.574 DEBUG (Thread-11024 (connection_thread)) [custom_components.open_epaper_link.hub] 67

Interesting, I will add it of course. Where did you get your tag from?

Added with the latest release


Request to add pixhawk 2.4.8 in nuttx

I wanted to add pixhawk v2 to nuttx config for application development. Did a lot of effort following nuttx port guide but got error during make menuconfig . It would have been really appreciable if pixhawk could be added to nuttx.

@amitmanish this isn't immediately possible because the PX4 build is tightly integrated with NuttX. There's a NuttX defconfig for the pixhawk (https://github.com/PX4/Firmware/blob/master/platforms/nuttx/nuttx-configs/px4fmu-v2/nsh/defconfig), however nearly all of the board init lives on the PX4 side (https://github.com/PX4/Firmware/tree/master/src/drivers/boards/px4fmu-v2).
If you want plain NuttX on a pixhawk the easiest thing to do is build PX4, but disable all the modules here. https://github.com/PX4/Firmware/blob/master/cmake/configs/nuttx_px4fmu-v2_default.cmake


Address comments in PR #3997.

See https://github.com/kubernetes/kubernetes.github.io/pull/3997/files/f6eb59c67e28efc298c87b1ef49a96bc6adacd1e#diff-7a14981f3dd8eb203f897ce6c11d9828

This change is

@madhusudancs Just ping me when this is ready to be merged. Thx

@chenopis it's ready now. PTAL.


IE11 support

Would be great if IE11 could also be supported.
There is an error objectDOMexception when the page is loaded

my project:

<template>

      <q-media-player
        :sources="sources"
        background-color="white"
        type="video">
      </q-media-player>

</template>

 data() {
      return {
        sources: [
          {
            src: "./data/test.m4v",
            type: "video/m4v"
          },
          {
            src: "./data/test.mp4",
            type: "video/mp4"
          }]
      };
    }

qmediaplayer - exapmles.

Thanks for reporting this. :heart: I wish I had IE11 to test with. The UI looks a bit messed up. Not sure what I can do here, but I'll see if I can come up with something.

Just dicovered that IE11 does not support classList functionality. This is used when going in and coming out of fullscreen.
If you wouldn't mind trying some polyfill for it and letting me know how it goes, that would be appreciated.

I tried to add a polyfill for classList from Mozilla site as import "classListPolyfill" to the various places: QMediaPlayer or import it as  to index.templates.html file. It had a problem with function .remove.
I tried to comment all (6) classList events. Error remained the same (without polyfill)
I also tried to add binding for attaching events. No difference.
I tried to install with yarn your suggested polyfill but I don't know if it needs additional configuration. It was added to yarn.lock but after restart IE was at the same stage.

At this stage I don't know what else could be a problem.

I will try to get rid of the code using classList and re-code it in a different way. Give me a couple of days as I am slammed at work.

If it was a problem of classList then it would work after commenting those lines but it had no effect. There must be another thing before reaching classList functions. It is a Vue warning so something when it tries to mount the player.
I have a another HTML5 video player generated from Authoring SW Opus Pro (DigitalWorkshop) and it plays. So I can confirm that IE11 and local security configuration should be OK. When you have more time I can upload to my git example code. You might get better idea.
I’m not in hurry, so there is no rush with fixing it now. I’d like to help you but I don’t know what I should try the next. If you have idea let me know and I can try it.

I will try to do this by next weekend (new release). If I haven't, give me a nudge. Thanks.

@m0jimo Sorry, I can't find anything that will help me fix this. You're going to have to try and track down more info for me. :(

Was checking out the player and happen to see this issue. I am curious about potentially checking this out instead of my custom use of Howler, but ie11 is a must for me still. I'm in no hurry though. Anyway, I thought I'd share how I test in ie11 incase its helpful. I use the virtualbox VM from here: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

@smakinson I am currently actively working on this and may have a fix.

will be fixed in v1.0.10. Let me know if it is still an issue for you.

@m0jimo Let me know when you have tested so this can be closed.

@hawkeye64 Do you know if anyone has tested in cordova say back to android 4.4.4 and iOS to some extent?

Sorry, I haven't done cordova so wouldn't know. :(

Sorry, but the result is still the same with the latest demo.

Can you confirm Edge does work? And ie11 is still an issue. Crud. It doesn't give very good reasons as to why, which makes it more difficult.


Local SMTP TLS ERROR

Hi,
Would there be a way to prevent TLS/SSL certificate verification.
Seams that changes to the config.yml are not working.
Have set the following:
security:
pepper: '123456'
allow_signup: true
verify_users: false
verify_senders: false
But the system still attempts to send the verification email that subsequently fails due to the SMTP relay using a self signed certificate.
± |master ✓| → docker logs mailwhale
2022-05-25T10:09:57.380930606Z [INFO ] ---
2022-05-25T10:09:57.380955667Z [INFO ] This instance is assumed to be publicly accessible at: http://localhost:3000
2022-05-25T10:09:57.380958788Z [INFO ] User registration enabled: true
2022-05-25T10:09:57.380960534Z [INFO ] Account activation required: true
2022-05-25T10:09:57.380962025Z [INFO ] Sender address verification required: true
2022-05-25T10:09:57.380963458Z [INFO ] ---
2022-05-25T10:09:57.382765931Z [INFO ] web server started, listening on <IP_ADDRESS>:3000
.
.
.
2022-05-25T10:10:45.912522437Z [INFO ] created user<EMAIL_ADDRESS>2022-05-25T10:10:45.912593829Z [INFO ] [request] status=201, method=POST, uri=/api/user, duration=92.273016ms, bytes=119, addr=<IP_ADDRESS>:51922
2022-05-25T10:10:45.934366226Z [INFO ] [request] status=200, method=GET, uri=/login, duration=106.7µs, bytes=533, addr=<IP_ADDRESS>:51922
2022-05-25T10:10:46.124002533Z [INFO ] [request] status=304, method=GET, uri=/build/bundle.css, duration=58.916µs, bytes=0, addr=<IP_ADDRESS>:51922
2022-05-25T10:10:46.124411257Z [INFO ] [request] status=304, method=GET, uri=/build/bundle.js, duration=59.983µs, bytes=0, addr=<IP_ADDRESS>:51924
2022-05-25T10:11:07.18150931Z [ERROR] failed to send user verification to<EMAIL_ADDRESS>x509: certificate signed by unknown authority
Please advise if a way exists to disable that check or to trust that certificate or a method to disable the activation / verification requirements.

Is your SMTP server using TLS, but with a self-signed certificate?

Yes.
Its a local postfix instance used as a relay.
It does have a 'openssl' generated cert that is self signed.
Initially the error was as follows
2022-05-25T09:32:46.025029473Z [ERROR] failed to send user verification to<EMAIL_ADDRESS>x509: certificate relies on legacy Common Name field, use SANs instead
After the certificate was regenerated with the missing bits the error changed and now 'unknown' authority is the issue.
2022-05-25T10:11:07.18150931Z [ERROR] failed to send user verification to<EMAIL_ADDRESS>x509: certificate signed by unknown authority
This error is not a big issue but it would indicate that even if I manage to disable verification / activation it would be encountered while sending actual emails.

Agreed! Will add this soon.

Thank you.
In the meantime. Is there a way to disable activation / verification.
Account activation required: true
Sender address verification required: true
In my config.yml have this set to 'false' but the app seams to ignore these settings.

Environment variables override config variables and the Docker image has some set by default (https://github.com/muety/mailwhale/blob/065f29fa3b66d75a7ceaac5785ebad7ab079305e/Dockerfile#L29) (which we might rethink anyway). If you set these variables on your Docker container (using -e with docker run) things should work as expected.

Thank you for the advice.
That worked perfectly.

Please check if my recent changes fit your needs.

Yes.
Have rebuild the container image.
Picks up changes in the config.
And the newly introduced flag works.
Still receiving an error but it is unrelated. Simply the local relay is locked down via IP whitelists and provides no authentication.
[ERROR] failed to send user verification to<EMAIL_ADDRESS>smtp: server doesn't support AUTH
So if I enable AUTH that should work now. As there is no issue with the self signed certificate.
Unless there is an option to disable authentication attempts from the APP itself.

Good point, I created a new issue and will hopefully get to it soon.

Good point, I created a new issue and will hopefully get to it soon.

Awesome, thank you. Did not expect any work but appreciate as it would be useful.
Got the notification of the ticket created so can test whenever the future gets included.
I'm using this app for InfluxDB v2 as somehow it only works with HTTP APIs and does not have direct configuration for SMTP


Terraform getting error reading resources with URLs containing !A(MISSING)

For the last few days we've been getting this issue on resources such as kafka ACL, topic or identity pools:

│ Error: error reading Kafka ACLs: Get "https://lkc-redacted.eastus.azure.glb.confluent.cloud:443/kafka/v3/clusters/lkc-nwmndk/acls?host=%!A(MISSING)&operation=READ&pattern_type=LITERAL&permission=ALLOW&principal=User%!A(MISSING)pool-v6zE&resource_name=%!A(MISSING)&resource_type=GROUP": GET https://lkc-redacted.eastus.azure.glb.confluent.cloud:443/kafka/v3/clusters/lkc-nwmndk/acls?host=%!A(MISSING)&operation=READ&pattern_type=LITERAL&permission=ALLOW&principal=User%!A(MISSING)pool-v6zE&resource_name=%!A(MISSING)&resource_type=GROUP giving up after 5 attempt(s)

I'm wondering if the "User%!A(MISSING)" in the URL is causing an issue with the API but I can't be certain
This is only happening for one of our 12 clusters, which makes it even weirder.
So far I tried: reverting the provider to 1.83, we got the exact same error.

Thanks for creating this issue @penicaudm!
Could you check whether this comment helps to find the root cause? It seems like this issue can be caused by different factors.

@penicaudm could you also verify whether a direct API call from the same host works?

We're using az devops pipelines running on a virtual machine scale set. Our VMs running pipelines usually run for the day and get created at night. I just cleaned up our entire pool of VMs to create fresh ones and now the pipeline is working ok again (at least on the plan command).
I'm trying to figure out if anything has changed but its the same terraform version, same provider, same tasks,etc.

So we got the error again. I reran the pipeline and it worked, pretty hard to troubleshoot that..
I'm suspecting the go issue you reported previously with these topics:

https://stackoverflow.com/questions/17157836/gae-go-user-service-login-url-contains-amissing
https://stackoverflow.com/questions/24661862/url-escaping-producing-amissing-instead-of-3a

Is at play. So it could be in the fmt package or in Terraform directly.. I'm not good enough at go to provide an educated explanation.

Here is a sample of the formatting issue if needed:
provider.terraform-provider-confluent_2.1.0: Error reading Kafka ACLs "cluster/TOPIC#global.it4it.payload-message.payload-store-error-europe.v1#LITERAL#User:pool-xlg5#*#READ#ALLOW"
this resulted in the following URL:
https://cluster-g0yq0p.westeurope.azure.glb.confluent.cloud:443/kafka/v3/clusters/cluster/acls?host=%!A(MISSING)&operation=READ&pattern_type=LITERAL&permission=ALLOW&principal=User%!A(MISSING)pool-xlg5&resource_name=global.it4it.payload-message.payload-store-error-europe.v1&resource_type=TOPIC


Cannot (sometimes) find runner by label when multiple self-hosted runners are available

Description
I am running a self-hosted instance of Gitea with two runners both setup as host (no Docker), one is on the same server as my Gitea  instance, one is on another server. Both have ":host" at the end of their labels in .runner file.

I have a workflow that deploys to the local machine.
-- ci.yml --
...
jobs:
  build:
    uses: ./.gitea/workflows/reusable/build.yml
    secrets: inherit
...

-- reusable/build.yml --
...
jobs:
  build:
    runs-on: noxlabs_runner
    steps:
      - name: Git clone to work directory
        uses: actions/checkout@v4
...

With this setup, most of the time, not always the job fails with these logs:

On line 1 it seems to incorrectly find the runner by label (action above should have been executed on noxlabs_runner) and then proceeds to run docker images even though it should be run on the host.
If I try to manually rerun the job, after 10-15 attempts it finds the correct runner and completes the workflow.
It persists whether there is only one running job or multiple concurrent ones.
This issue was not happening when I ran multiple concurrent jobs with only one runner configured.
It seems to be connected simply to the fact that I have two active runners, not to the fact that I am running concurrent jobs.
Gitea Version
1.22.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
2.34.1
Operating System
Both servers are Ubuntu 22.04 x86_64
How are you running Gitea?
Gitea is deployed from oficial release binary, same as both runners.
Gitea and runners are being run with systemd.
Database
PostgreSQL

If I add runs-on: setting in the original workflow that calls reusable workflow, gitea has no problem finding the right runner.

Thank you for the tip, in the mean time I just moved all code from reusable workflows to the main workflows as it is not that big of a hassle and I get the added benefit of Gitea actually showing the individual steps in UI and not just combining them into "Set up job". With that I verified that it is an issue with reusable workflows specifically, as without them there seems to be no problem selecting the correct runner.


Merge dev into main

Add descriptions to payloads where available, addressing https://github.com/Frissi0n/GTFONow/issues/7
Fix minor workflow issues.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (71b020d) 29.32% compared to head (2727f3b) 30.00%.
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   29.32%   30.00%   +0.67%
==========================================
  Files           2        2
  Lines         491      490       -1
==========================================
+ Hits          144      147       +3
+ Misses        347      343       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


A question about "KITTI experiment"

Thank you very much for your well organized code.  May I ask how the KITTI experiment was conducted? Do you divide KITTI into multiple blocks, then perform upsampling separately?

yes, we divide the point cloud into blocks

yes, we divide the point cloud into blocks

Thank you. May I ask if point cloud sampling is not divided into object level and scene level? A scene point cloud (KITTI) can also be divided into multiple blocks and upsampled before merging, right? Compared to regular object level point clouds (ShapeNet), is point clouds like KITTI more challenging?

The main challenge is the generation of seed points, the proposed method is hard to process large-scale point cloud directly, thus we choose to divide it into small blocks.

The main challenge is the generation of seed points, the proposed method is hard to process large-scale point cloud directly, thus we choose to divide it into small blocks.

Thank you for your reply.  The existing point cloud sampling methods seem to be experiments conducted at the object level.  Is it meaningful to divide point cloud sampling into scene level and object level? Because a scene can also be divided into multiple point cloud blocks as input, and then merged.

Sorry, i have not seen any discuss about the divide method.

Sorry, i have not seen any discuss about the divide method.

Thank you.


The CLI might be too noisy.

For example:
$ t2 wifi -n Bocoup-Core -p jquery151
INFO Looking for your Tessel...
INFO Connected to bishop.
INFO Successfully connected!
INFO Wifi Enabled.
INFO Wifi connection successful. SSID: Bocoup-Core, password jquery151, security mode: psk2

I think:
INFO Successfully connected!
INFO Wifi Enabled.

...could be removed, without losing any important information

Eventually we can take a deeper look at all of the info logs

I agree. All that, and I still can't tell how it's trying to talk to my Tessel, too..

$ t2 wifi -n Bocoup-Core -p jquery151
INFO Looking for your Tessel...
INFO Connected to bishop via ____
INFO Wifi connection successful. SSID: Bocoup-Core, password jquery151, security mode: psk2

:+1:

Resolved https://github.com/tessel/t2-cli/commit/6131f62b54321ce046e67eb8242238467f2d17c8


Conditional clr-dg-row-detail

Select one ...  (check one with "x")
[ ] bug
[ ] feature request
[ X ] enhancement

Expected behavior
Currently there is no way to have a datagrid with expandable rows and some of them to not have the expand caret.
This is needed in the case where [clrDgReplace] is true and expanding actually won't be displaying anything more than currently displayed.
Actual behavior
The caret in case of datagrid with clr-dg-row-detail cannot be hidden.
Reproduction of behavior
Environment details

Angular version: 4.x.x

Clarity version: 0.10.6

OS and version:

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

I don't understand the request, it's entirely possible to have some rows expandable, and some not: https://plnkr.co/edit/8RhYgQrPmFdE5jHWsdm4?p=preview
Is that what you need?

Yes, that is exactly what I needed.
I've missed the ngProjectAs part with ng-container.
Thanks!


[azeventhubs] Adding in prefetch and far more stress tests

Adding in prefetch, making it the default. Event Hubs has no message expiration or server side locks (like Service Bus) so it's a great fit.
Adding in tests for more long running operations, adding variations for with and without prefetch, with and without the processor.
 Will address in next PR.


latest version of the mod not loading on fabric

when i try to launch i get this instantly

Update fabric api

Update fabric api


Bump reference circe version in quickstart.md

There are other places where 0.5.1 is used, I'll get them

Current coverage is 81.00% (diff: 100%)

Merging #409 into master will decrease coverage by 0.04%

@@             master       #409   diff @@
==========================================
  Files            62         62
  Lines          2006       2006
  Methods        1853       1853
  Messages          0          0
  Branches        153        153
==========================================
- Hits           1626       1625     -1
- Misses          380        381     +1
  Partials          0          0

Powered by Codecov. Last update a469ef4...c981439

🚜

Thanks for catching this, @nicolasdalsass!


FTBFS: error: ‘scalars_name’ was not declared in this scope

I tried to compile the latest version on master and it failed with the following error:
[ 51%] Building CXX object Applications/src/CMakeFiles/calculate-element-wise.dir/calculate-element-wise.cc.o
/home/francois/workspace/MIRTK/Applications/src/calculate-element-wise.cc: In function ‘int main(int, char**)’:
/home/francois/workspace/MIRTK/Applications/src/calculate-element-wise.cc:672:41: error: ‘scalars_name’ was not declared in this scope
       const char *output_scalars_name = scalars_name;
                                         ^
Applications/src/CMakeFiles/calculate-element-wise.dir/build.make:62: recipe for target 'Applications/src/CMakeFiles/calculate-element-wise.dir/calculate-element-wise.cc.o' failed
make[2]: *** [Applications/src/CMakeFiles/calculate-element-wise.dir/calculate-element-wise.cc.o] Error 1
CMakeFiles/Makefile2:2220: recipe for target 'Applications/src/CMakeFiles/calculate-element-wise.dir/all' failed
make[1]: *** [Applications/src/CMakeFiles/calculate-element-wise.dir/all] Error 2

Thanks, it is fixed now. It previously required that option WITH_VTK was set to ON. After the fix, you can compile it either with or without VTK.

:+1:


Added the POST to cancel the "authentication update" after login

I guess only commit https://github.com/lorenzh/FIFA-Ultimate-Team-Toolkit/commit/db1c159ac2fec3171e913fe42fd09c4806afdcb8 is relevant, since the other just pulls stuff from my repository?

only lorenzh@db1c159 is relevent for the login

Yeah, noticed it shortly after, so i deleted the message :smile: Will look at merging it once i return from NDC London.

Merge into master, thanks.


Action Data Exporter.py Issue

When using format --actions-sql, there is currently a bug where if the entry already exists, we get a primary key error on an insert and it doesn't update the row and ends the script execution.

Hi @JoemerRamos. We've released a new major version of iAuditor Exporter which includes updates to the way Actions are exported.
Take a look at https://github.com/SafetyCulture/iauditor-exporter and https://help.safetyculture.com/en_us/1064272525-rJ3PYPFEP for more details.

Going to try using the new version


CircleCI Partner Review

Hello Autify team 👋
I am from the @circleci Community and Partner Engineering team, here to help with a review for the CircleCI orb partnership. I have a few action items below for you:

Replace ! [ -z "${YOUR_VARIABLE}" ] with [ -n "${YOUR_VARIABLE}" ]

At the lines 26, 30, 37, 41, 45, 49, 53 and 57 empty strings are checked with ! [ -z ...]. Using -n will improve code readability and comply with SC2237.

Replace [ "${YOUR_VARIABLE}" = "1" ] with [ "${YOUR_VARIABLE}" -eq 1 ]

At the lines 18 and 22 numerical comparisons are done with = instead of -eq.

Double quote variables

The variable at the lines 7, 9, 11 and 61 should be double-quoted to comply with SC2086.

Feel free to ask me any questions, and please include me as a reviewer in the PR with the changes. Thank you!

@EricRibeiro Thank you for such a deep review! I fixed and released v2.1.1.


Support generating sub package

Resolve: #892
When generating sub package, go.mod will not be generated, module name and module version constants will not be generated for management plane and will use user-defined internal.ModelName and internal.ModelVersion instead.

Generally speaking, I think it would be preferable to support this outside of the code generator.  Can't we fix up the module name/version constants via a transform?


can't load the new state package in flexbe

Hello everyone,
i created a new state package, but can't see/load that in flexbe. i tried 'force Discover', but that didn't help.
any help will be highly appreciated.
Thanks in advance

Hello , I just had that problem too
If you are using ubuntu 20.04 ros1 noetic
try develop branch at flexbe_behavior_engine
https://github.com/team-vigir/flexbe_behavior_engine/tree/develop

Presume above comment fixed this.  If not, need more information about your set up including OS version, ROS version, and branches for flexbe_behavior_engine and flexbe_app.
I plan to close this issue shortly if I don't hear otherwise.

Behaviors already exist in source form under behavior packages in ros2 galactic are not discovered by flexbe_app.
Furthermore, newly created behaviors are saved under build and or install directory and not in source directory.
OS: Ubuntu 20.04
ROS version: ros2 galactic
flexbe_behavior_engine branch: ros2-devel
flexbe_app branch: ros2-devel

Yes, created behaviors are saved under build/install and must be manually copied to src for saving and distribution.
If you are defining new states in src, then you first need to make sure they are being installed properly in build/share with colcon before attempting to use them.
New source files need to copied using standard colcon for ROS 2, but we do not yet have a script in place for moving new behaviors that are saved in build over to the "src" folder for saving (e.g. under git repo).  Creating such a script is on our todo list this summer.  it will probably start as a regular script that you run manually, but then integrate into the UI with option to save this way.

If you are building from source, use the Noetic branch for both onboard and flexbe_app.
The standard versions of both should now be available as debian installs.
check console messages carefully.  There is a post build step that is required to install the Node JS libraries.  If you try to launch everything in one terminal you might miss the message about running the "nwjs_install" script.
If you have further issues, open a new issue and include some screen shots of your errors.

Hi deconner
Thank you for your advice!! I did use the Noetic branch and it worked well. However, by the time came I noticed the problem that the app couldn't connect onboard behavior (I saw that other people have the same problem as well on the flexBe bug report). I decided to delete both the flexBe app and onboard package and download again with the Noetic branch (same branch) this time it faced an error like this.
[cid:5d8a6f7f-712e-48f5-b27a-dbf60a744b28]
I assume that because I updated ubuntu maybe there is a problem with the version or something. If you find any solution, please inform me.
Thank you. I still use ubuntu 20.04 LST with Noetic version of ROS
Best
Panithan Rithburi

จาก: dcconner @.>
ส่ง: 5 มกราคม 2567 0:05
ถึง: FlexBE/flexbe_app @.>
สำเนาถึง: Panithan Rithburi @.>; Comment @.>
ชื่อเรื่อง: Re: [FlexBE/flexbe_app] can't load the new state package in flexbe (Issue #81)
If you are building from source, use the Noetic branch for both onboard and flexbe_app.
The standard versions of both should now be available as debian installs.
check console messages carefully. There is a post build step that is required to install the Node JS libraries. If you try to launch everything in one terminal you might miss the message about running the "nwjs_install" script.
If you have further issues, open a new issue and include some screen shots of your errors.
—
Reply to this email directly, view it on GitHubhttps://github.com/FlexBE/flexbe_app/issues/81#issuecomment-1877460661, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7QB7JVL7JINC4SSTTCHPLYM3OL3AVCNFSM6AAAAAAQMQMJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGQ3DANRWGE.
You are receiving this because you commented.

I'm not sure what the error code [cid:5d8a6f7f-712e-48f5-b27a-dbf60a744b28] means.
See you posted another comment in #53, possibly the same error.  I'll respond there.  If not, I'll need more information about the error referenced here.


Lighting

Getting some lighting going.

https://github.com/TatumCreative/mdn-lighting-models/tree/master/lessons


TypeError: forward() takes 2 positional arguments but 3 were given

❓ Question

Some errors have occurred when I use MPT-30B. The error code section is below:
trainer = Seq2SeqTrainer(
        model=model,
        tokenizer=tokenizer,
        args=training_args,
        **{k:v for k,v in data_module.items() if k != 'predict_dataset'},    # train_dataset, eval_dataset, datacollator
    )
trainer.train()

The information about error is below:
Traceback (most recent call last):
  File "/home/ksyer_/DB-GPT-Hub/src/train/train_qlora2.py", line 883, in <module>
    train()
  File "/home/ksyer_/DB-GPT-Hub/src/train/train_qlora2.py", line 845, in train
    train_result = trainer.train()
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/transformers/trainer.py", line 1662, in train
    return inner_training_loop(
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/transformers/trainer.py", line 1929, in _inner_training_loop
    tr_loss_step = self.training_step(model, inputs)
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/transformers/trainer.py", line 2699, in training_step
    loss = self.compute_loss(model, inputs)
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/transformers/trainer.py", line 2731, in compute_loss
    outputs = model(**inputs)  inputs: dict_keys(['input_ids', 'attention_mask', 'labels'])
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/peft/peft_model.py", line 912, in forward
    return self.base_model(
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/home/ksyer_/.cache/huggingface/modules/transformers_modules/modeling_mpt.py", line 271, in forward
    logits = self.transformer.wte(outputs.last_hidden_state.to(self.transformer.wte.weight.device), True)
  File "/home/ksyer_/.conda/envs/new/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
TypeError: forward() takes 2 positional arguments but 3 were given

Whatever, nothing gone wrong when I use other model,just like llama, falcon and so on. So can you give me a solution to sove the problem?
Thanks!
Additional context

Same issue happened, when I tried fine tuning mpt-30b model using accelerate with deepspeed.

Closing as we don't plan on making any more MPT modifications with respect to hugging face trainer compatibility.


property functions being flagged as invalid code in js files

VSCode Version: 1.2.1
OS Version:
windows 10
Steps to Reproduce:

create a js file
create a class file and add a property
get "[js] 'property declarations' can only be used in a .ts file." with the property code highlighted.
I am attempting to use code to do react coding and using the property functions keep me from littering my code with myfunc = myfunc.bind(this); unless I actually need to rebind something. It is more an annoying visual thing to have a lot of code underlined than anything else, but it would seem to be something you should allow in js/jsx files.

class MyClass {
  someFunction = () => {

  }
}

This issue was moved to Microsoft/TypeScript#9207

@jefflindholm Above issue got fixed in Typescript 2.0 which is TS Next version and VS code is currently shipped with always latest shipped Typescript which is 1.8.x.
You can install the latest Typescript 2.0 and point VS code to it by changing the settings typescript.tsdk


Roll Flutter Engine from b190f9015049 to a64ccad0d355 (3 revisions)

https://github.com/flutter/engine/compare/b190f9015049...a64ccad0d355
2023-08-22<EMAIL_ADDRESS>Roll Skia from c675298ddeda to bf6019be75ef (3 revisions) (flutter/engine#44974)
2023-08-22<EMAIL_ADDRESS>Make FontWeight an enum, Remove unused text classes (flutter/engine#44960)
2023-08-22<EMAIL_ADDRESS>Roll Skia from 9f4b81aac175 to c675298ddeda (2 revisions) (flutter/engine#44971)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


VS Code was unable to detect changes to HelloController.java

Using the Tiltfile from the beta-3 branch, my VS Code could not detect changes I made to HelloController.java even though I had AutoBuild set to Enabled.  I found when I updated the Tiltfile to include the ant-style wildcard, then the reload occurred as I expected...
['pom.xml', './target/classes'],
live_update = [
sync('./target/classes**/', '/workspace/BOOT-INF/classes')
],

The sync rule is just a plain old operating system path and as far as I know none support the ant-style matchers like that.  I am half surprised that actually worked.  I suspect the underlying OS is being lenient with you there.
Before it started working, did you see any errors in the tilt logs?

Also, do you mind sharing a few more details here:

Could you share what your Tiltfile & workload.yaml look like?
What Kubernetes cluster are you running against? And what all do you have installed on that cluster?
What steps did you take before you saw this behavior? (E.g. deployed from CLI then started live update from the IDE)

Thank you for the feedback.  I will be do a fresh round of testing with the upcoming beta-4 release on 12/2.  I'll get responses quickly.

Could you share what your Tiltfile & workload.yaml look like?

Workload file is available here: https://github.com/sample-accelerators/tanzu-java-web-app/blob/main/config/workload.yaml

2 What Kubernetes cluster are you running against? And what all do you have installed on that cluster?

k8s: 1.21 and TAP 1.0

What steps did you take before you saw this behavior? (E.g. deployed from CLI then started live update from the IDE)

I launched within VSCode : Tanzu Live Update Up (= tilt up)

Before it started working, did you see any errors in the tilt logs?

Error reported by buildpack during analyse phase was [analyze] ERROR: failed to get previous image: missing OS for image "[ghcr.io/halkyonio/tanzu-java-web-app-tap-demo](http://ghcr.io/halkyonio/tanzu-java-web-app-tap-demo)"

I am no longer facing this issue.  It must have been my local configuration and successive re-deploys of later TAP versions and cleaning up my environment, must have resolved the issue.


hi i want to know iris's real size

hi. thank you for your works.

i make [iris_tracking aar]

i build with [iris_tracking aar]  in new android studio project with "mediapipe\examples\android\src\java\com\google\mediapipe\apps\basic\MainActivity.java" and "mediapipe\examples\android\src\java\com\google\mediapipe\apps\iristrackinggpu\MainActivity.java" .

finally i can get the face landmarks data including iris from following code..("mediapipe\examples\android\src\java\com\google\mediapipe\apps\iristrackinggpu\MainActivity.java" )

byte[] landmarksRaw = PacketGetter.getProtoBytes(packet);
try {
NormalizedLandmarkList landmarks = NormalizedLandmarkList.parseFrom(landmarksRaw);
:
:
but that i really want is

img's iris real size
img's iris pixel size

because if i know that , i can know really size per pixel . it's my goal
so.. how can i get that infomation? plz something commet..

Hi @bwjoe, You wanted the Iris size through android platform?

yes.
real size and ( pixel size or pixel coordinate?)

Please assign this to the iris owners. Thanks.

hello thanks you for response
finally i found a following code in "iris_to_depth_calculator.cc"
[
// Avergae fixed iris size across human beings.
constexpr float kIrisSizeInMM = 11.8;
].
real iris's size is fixed by "11.8"
just i thought vaguely : "maybe i can get real iris size by tf.".
i misundestand.
thank you for your all regards.
something i have any another questions. i will write other issue. thank you


Docs_NavMenu_Reorder

Reordered the navigation menu for the MSFT Health Architectures GitHub Pages site.
Preview the changes here:
https://v-pbartley.github.io/health-architectures/

need to remove the cloud4health changes, then pull origin again to remerge


Fix Cursor::from_point to use the line's offset

This is effectively the opposite of #169.
I've also added a test. This test does use system fonts, and so is written so as to be relatively independent of the font, assuming it doesn't do any ligature fanciness.
In future, we'll likely want to us an in-repository small font (such as roboto).

Review requested because of the test


Please add support to other languages like Chinese, the page is all garbled

https://github.com/puppeteer/puppeteer/issues/1143
It's because of the lack of fonts for puppeteer.


Implemented YamlCollectionDump class

PR for #41

Coverage increased (+0.3%) to 91.93% when pulling e7c18625203d68484b0c051d80774e4b4425b141 on SherifWaly:#41 into 3c9b9bb682dda210910afaecfe61d6eaf1150687 on decorators-squad:master.

@amihaiemil please check this commit :)

@SherifWaly looks nice :)

@rultor merge

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@amihaiemil Done! FYI, the full log is here (took me 1min)


Fix microsite compile

Our microsite build has been broken and outdated while we've been moving to an Effect Agnostic Endpoint. This PR fixes the sbt docs/makeMicrosite command. The code examples in the docs all compile but the text that surrounds them is still out of date. My current thinking is that we can use this as a base to fix the text, although I'm open to alternative approaches to fixing our docs. If we decide to merge this, I don't think we should publish the docs to the website until all the text has been fixed.
Some things to note / questions:

I replaced the Server Sent Event example's use of AsyncStream with Fs2
The latest sbt-microsites seems to replace favicons and icons with its own. I've noticed this on other microsites like cats effect.
Set the docs compilation tool to Tut, but we should probably consider moving to mdoc in the future
contributing.md probably needs to get updated to no longer mention Waffle which no longer exists

Codecov Report

Merging #1231 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1231   +/-   ##
=======================================
  Coverage   81.07%   81.07%
=======================================
  Files          55       55
  Lines        1009     1009
  Branches       42       42
=======================================
  Hits          818      818
  Misses        191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b2f15...c9b28fe. Read the comment docs.

What I did in Odin is to compile docs on each PR, so it becomes a part of the check, as well as automatically compile and publish documentation back on GitHub during release. I guess we might onboard similar mechanism here to avoid severe discrepancy between documentation and actual code.

I like the sound of publishing on release. It might also be related to #1002. I'm going to merge this and will look at more fixes so we can get ready for a release.


fix oddly asymmetric layout of team

this looks weird to me because it is not centered. Feels like there should be 3 per row perhaps?

oddly, upstream at https://blackrockdigital.github.io/startbootstrap-agency/ the layout IS symmetric with 3 per row:

Which branch are you using?
What browser?
This should have been fixed in the dev branch.
The latest changes enabled centering of the team and the default with having 3 symmetric team members per line.

Sorry, this is Safari, and I am using the master branch.
But you mentioned that the dev branch isn't quite ready for prime time yet, correct?

Let's say it works and is in production with a subset of the features, but without documentation I would not recommend using it yet.
Will try to look into the issue in the next days and add a backport, if necessary.

Hi,
are there any news about this issue?
The left-alignment looks really strange if you have only one or two team members. So it would be great to have it centered.
Anyway, thanks for the great theme!
Best regards
Max

As hugo-agency-theme is mostly in maintainance mode and no new features will be added.
We created Syna as a more flexible iteration of this theme.
This should be fixed in Syna and it's corresponding member fragment


Small typo in JS snippet

Hello,
first run shows:
...and run it with ENTER:
(async()=>{eval(await(await fetch("http://localhost:9849/gadget")).text());})();
... after finish there comes another snippet which doesn't work. One \ too much in it
You can download another set of images using the below JS snippet or exit patreon-dl:
(async()=>{eval(await(await fetch(\"http://localhost:9849/gadget")).text());})();

Oh, that's a leftover from some older code.
Thanks for the report, fixed in 95c3ac3 and will be put into the next release.


DRAFT: Using msbuild project graph

This PR creates a WorkspaceLoader based on MSBuild's ProjectGraph.  This allows for MSBuild to do all the lookups/builds efficiently as it can for a given workspace's project graph rather than relying on building individually and caching them.  In my work project, initial load times went from 12 seconds to 7 seconds.
I've created a IWorkspaceLoader interface which will allow swapping of this so we can test in the field to find any weird edge cases this hasn't take into account.  See PRs the FSAC and Ionide for the feature flag changes.

Currently I still have some things left to finish.

[x] Using customProperties
[x] generateBinLog
[x] Equivalent tests for WorkspaceLoaderViaProjectGraph and fix current ones
[x] Cleanup/refactor

I think this is ready to go, just needs review/approval.


When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[x] Feature or performance improvement

Requirement or improvement
If the gateway does not have a agent installed, after configuring it in gateways.yml, the upstream and downstream of the gateway cannot be displayed in the topology. The topology display is incomplete.
For example:
Service A calls service B through the gateway. Select service A in the topology, it shows this:
A --> Gateway

Select service B in the topology, it shows this:
Gateway --> B

But I think the desired topology should be like this:
A --> B

Here is another complicated example:
Service A calls service B through the gateway. Service C calls service D through the gateway.
If services A, B, and D are in a group, and this group is selected in the topology, it shows this:

A --> Gateway --> B
         |
         ↓
         D

It is easy to be misunderstood that service A calls service D through the gateway.

But I think the desired topology should be like this:

I don't think this is expected. Could you explain your point?

Service A calls service B through the gateway. Service C calls service D through the gateway.
If services A, B, and D are in a group, and this group is selected in the topology, it shows this:

This is always what we expect to see, one-level-jump group topology never would be complete topology.

Besides all above, why you don't have an agent on Gateway? This uninstrumented setting is for a gateway not supported, but SkyWalking covers most popular gateway, even the ones we don't, I think you should add for them.

Thank you for such a quick response.
For example, when service A is called, it is called through gateway G.
In the topology, only the calls of service A and gateway G are shown.
However, which real services call service A through gateway G is very necessary from a business perspective.

Yes, I know. Your description is correct. My point is, topology is not about data flowing. From topology, you always could find this edge case, no matter how many jumps you are going to show.
You could try yo think in this way.

I got it, thank you for your answers.


UTF-8 encoding is not perfectly supported

When viewing a raw paste, special characters are not correctly displayed.
Example : https://paste.atilla.org/paste/IVQ69Y/raw

Thanks for reporting! Feel free to propose a patch, otherwise I'll take care of it during this weekend

Sure


Warning: React.jsx: type is invalid

Description
After upgrading from RN 0.71.12 to RN 0.72. when running the app showing error like
Warning: React.jsx: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: number.
Check the render method of Login.
in Login (created by SceneView)
in StaticContainer
in EnsureSingleNavigator (created by SceneView)
in SceneView (created by CardContainer)
in RCTView (created by View)
in View (created by CardContainer)
in RCTView (created by View)
in View (created by CardContainer)
in RCTView (created by View)
in View
in CardSheet (created by Card)
in RCTView (created by View)
in View
in Unknown (created by PanGestureHandler)
in PanGestureHandler (created by PanGestureHandler)
in PanGestureHandler (created by Card)
in RCTView (created by View)
in View
in Unknown (created by Card)
in RCTView (created by View)
in View (created by Card)
in Card (created by CardContainer)
in CardContainer (created by CardStack)
in RNSScreen
in Unknown (created by InnerScreen)
in Suspender (created by Freeze)
in Suspense (created by Freeze)
in Freeze (created by DelayedFreeze)
in DelayedFreeze (created by InnerScreen)
in InnerScreen (created by Screen)
in Screen (created by MaybeScreen)
in MaybeScreen (created by CardStack)
in RNSScreenContainer (created by ScreenContainer)
in ScreenContainer (created by MaybeScreenContainer)
in MaybeScreenContainer (created by CardStack)
in RCTView (created by View)
in View (created by Background)
in Background (created by CardStack)
in CardStack (created by HeaderShownContext)
in RCTView (created by View)
in View (created by SafeAreaInsetsContext)
in SafeAreaProviderCompat (created by StackView)
in RNGestureHandlerRootView (created by GestureHandlerRootView)
in GestureHandlerRootView (created by StackView)
in StackView (created by StackNavigator)
in PreventRemoveProvider (created by NavigationContent)
in NavigationContent
in Unknown (created by StackNavigator)
in StackNavigator (created by MainNavigator)
in MainNavigator (created by SceneView)
in StaticContainer
in EnsureSingleNavigator (created by SceneView)
in SceneView (created by CardContainer)
in RCTView (created by View)
in View (created by CardContainer)
in RCTView (created by View)
in View (created by CardContainer)
in RCTView (created by View)
in View
in CardSheet (created by Card)
in RCTView (created by View)
in View
in Unknown (created by PanGestureHandler)
in PanGestureHandler (created by PanGestureHandler)
in PanGestureHandler (created by Card)
in RCTView (created by View)
in View
in Unknown (created by Card)
in RCTView (created by View)
in View (created by Card)
in Card (created by CardContainer)
in CardContainer (created by CardStack)
in RNSScreen
in Unknown (created by InnerScreen)
in Suspender (created by Freeze)
in Suspense (created by Freeze)
in Freeze (created by DelayedFreeze)
in DelayedFreeze (created by InnerScreen)
in InnerScreen (created by Screen)
in Screen (created by MaybeScreen)
in MaybeScreen (created by CardStack)
in RNSScreenContainer (created by ScreenContainer)
in ScreenContainer (created by MaybeScreenContainer)
in MaybeScreenContainer (created by CardStack)
in RCTView (created by View)
in View (created by Background)
in Background (created by CardStack)
in CardStack (created by HeaderShownContext)
in RNCSafeAreaProvider (created by SafeAreaProvider)
in SafeAreaProvider (created by SafeAreaInsetsContext)
in SafeAreaProviderCompat (created by StackView)
in RNGestureHandlerRootView (created by GestureHandlerRootView)
in GestureHandlerRootView (created by StackView)
in StackView (created by StackNavigator)
in PreventRemoveProvider (created by NavigationContent)
in NavigationContent
in Unknown (created by StackNavigator)
in StackNavigator (created by ApplicationNavigator)
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner (created by ApplicationNavigator)
in RCTView (created by View)
in View (created by ApplicationNavigator)
in ApplicationNavigator (created by App)
in ToastProvider (created by App)
in PersistGate (created by App)
in Provider (created by App)
in App (created by CodePushComponent)
in CodePushComponent
in RCTView (created by View)
in View (created by AppContainer)
in RCTView (created by View)
in View (created by AppContainer)
in AppContainer
in WoW(RootComponent)
React Native Version
0.72.6
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 13.5.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 656.57 MB / 16.00 GB
Shell:
version: 3.2.57
path: /bin/bash
Binaries:
Node:
version: 18.18.0
path: ~/.nvm/versions/node/v18.18.0/bin/node
Yarn:
version: 1.22.19
path: /usr/local/bin/yarn
npm:
version: 9.8.1
path: ~/.nvm/versions/node/v18.18.0/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK:
API Levels:
- "30"
- "31"
- "33"
- "34"
Build Tools:
- 29.0.2
- 30.0.3
- 31.0.0
- 33.0.0
- 34.0.0
System Images:
- android-25 | Google APIs Intel x86 Atom
- android-30 | Google APIs Intel x86 Atom
- android-30 | Google Play Intel x86 Atom
- android-34 | Google APIs Intel x86_64 Atom
Android NDK: 22.1.7171670
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10811636
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.8
path: /Users/gsubramaniyan/.sdkman/candidates/java/current/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.6
wanted: 0.72.6
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
upgaded react-native from 0.71.7 to 0.72.6 with newArchEnabled = true.
Snack, code example, screenshot, or link to a repository

Can you provide a repro?

There was an issue with babel.config.js and fixed that and working fine. So closing this issue

Hi @gokul1099 ! I have the same warning. What was the issue with babel.config.js ?

Hi @gokul1099 ! I have the same warning. What was the issue with babel.config.js ?

while upgrading to new arch I messed up the babel.config.js file. then updated based on the documentation and it worked. I think i made the change for react-native-svg. but not sure.


Issues with Leaderboard Function

Your bug (What bug you found):
This bug makes the leaderboard data handling and leaderboard function unusable.
Potential fixes (Optional, write a potential fix):
Fixes can be applied through he code directly by following the crash reports on Heroku where the bot is deployed from.
Operating System (What OS you are using):
Windows 10
Additional Notes (Any additional notes about the issue):
None

API outage is causing a halt in fixing this issue, work should pick up soon. If needed, the update may be pushed back, however that is very unlikely.

Unfortunately, issues with the leaderboard module are not resolvable. The maximum length of a message is 2000 characters, which can support up to 90 users +- 1 user. This is not enough to support the bot in the long term. Everything on this issue will be dropped and the leaderboard will be shipped out with the dedicated server release.


Getting started hero

As found in:
https://www.vonage.com/unified-communications/getting-started-account-super-user/your-equipment/
https://www.vonage.com/unified-communications/getting-started-account-super-user/your-service/
https://www.vonage.com/unified-communications/getting-started-account-super-user/support-resources/
https://www.vonage.com/unified-communications/getting-started-account-super-user/key-features-and-services/

Per discussion with the customer, closing this issue as it's not necessary to replicate the getting-started-account-super-user pages.


insight answer after finishing a walk is not persisted or shown after finishing a walk

I don't know what you mean.
Which uri?
Which steps to reproduce?
What do you mean with "insight answer"?

It is a field which is called "Erkenntnisse..."


Extracting certain elements of a Variable

temp = Variable(5,5)
I'm interested in extracting certain elements of the expression matrix.
temp[[1,3],[2,4]] gives an error
IndexError: Index/slice out of bounds.

It should be temp.value[1:3, 2:4] or temp[1:3, 2:4].value.
See http://www.cvxpy.org/en/latest/tutorial/intro/index.html

Thanks for your reply. I want to extract certain elements of the matrix. For example, I wanted to extract (1,2) and (3,4) elements of the matrix i.e. the (1st row, 2nd column) element and (3rd row, 4th column) element. If I had a np.array matrix, I can extract it using temp[[1,3],[2,4]], but it doesn't work for cvx Variable matrix.

Oh, ok. You can't do that directly. If you want a vector of these elements, you can do this:
vstack(*[temp[i,j] for i,j in [(1,3), (2,4)]])

That works! But here is another problem I'm facing. I have a large matrix of expression, XX

XX
Expression(AFFINE, UNKNOWN, (200000, 200000))
I
(array([     0,      0,      0, ..., 199999, 199999, 199999], dtype=int32), array([199527, 191456, 191318, ...,   6428,   4967,   4646], dtype=int32))
I[0].shape
(75830978,)
I[1].shape
(75830978,)
temp = vstack(*[XX[i,j] for i,j in [I[0], I[1]]])
Traceback (most recent call last):
File "", line 1, in
ValueError: too many values to unpack

Is there a way to make it work for a large matrix? Am I getting the error because of memore problem?  Thanks a ton!

In fact, it does not work while extracting about 200K indices. So, I guess it's not a memory problem.

The error ValueError: too many values to unpack means your [XX[i,j] for i,j in [I[0], I[1]]] is incorrect.  The for i,j in  [I[0], I[1]] expects that [I[0], I[1]] is a list of tuples. If it's not a list of tuples, then you'll get the error. It has nothing to do with the size of the array. Probably you should write for i,j in  zip(I[0], I[1]).
 Make A using scipy sparse matrices, then wrap it like this Constant(A) so cvxpy can handle it.

I get the same error with the code below. However, I don't get any error if I use very small length of I[0] (about 50) no matter I use tuple or array. Larger length of I[0] gives the same error.
index1 = tuple(I[0])
index2 = tuple(I[1])
XX = vstack(*[XX[i,j] for i,j in [index1, index2]])

Your code is wrong. I meant tuples of two elements, because you unpack them into two elements in the for loop. This code should work:
temp = vstack(*[XX[i,j] for i,j in zip(I[0], I[1])])
``
But you should look at the array ``[(i,j) for i,j in zip(I[0], I[1])]`` and make sure it is giving you indices into the matrix.

works. Thank you so much!!


Add ASM and ARM VM DNS suffixes

/cc: @colemickens

(GitHub doesn't do any favors for reviewing these with these whitespace changes...)
Anyway, LGTM. Thanks again.

I could not find docs for most of the ARM suffixes, so they may be wrong.  ARM is new to Fairfax, which may be why I couldn't find the appropriate docs.

If you append ?w=1 to the URL, you will get some love, but it's not intuitive.


⚠ Bofrost.nl has degraded performance

In a062984, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1274 ms

Resolved: Bofrost.nl performance has improved in fc9b29d.


Add support for Ollama, Palm, Claude-2, Cohere, Replicate Llama2, CodeLlama, Hugging Face (100+LLMs) - using LiteLLM

This PR adds support for the above mentioned LLMs using LiteLLM https://github.com/BerriAI/litellm/
LiteLLM is a lightweight package to simplify LLM API calls - use any llm as a drop in replacement for gpt-3.5-turbo.
Example
from litellm import completion

## set ENV variables
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# cohere call
response = completion(model="command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

I believe we add Palm, Vertex, Ollama, VLLM, DeepInfra, Ai21, TogetherAI, Petals, OpenRouter, Replicate, NLP Cloud to griptape
I looked at https://docs.griptape.ai/griptape-framework/structures/prompt-drivers/
See LiteLLM providers here: https://docs.litellm.ai/docs/providers

@vasinov @collindutter @trish11953 can I get a review on this PR ?

This change doesn't make sense in the context of the Griptape framework: OpenAiPromptDriver should use the OpenAI SDK. There is also more nuance to supporting different models in Griptape due to how we integrate tokenizers and prompt generation logic.
Also, looks like this PR is part of a focused (automated?) effort to promote LiteLLM.

@vasinov I'm doing it manually and thought this would create value for griptape

OpenAiPromptDriver should use the OpenAI SDK.

Why not have one class for all LLM I/O, do you want to maintain all your LLM integrations on griptape ?

There is also more nuance to supporting different models in Griptape due to how we integrate tokenizers and prompt generation logic.

Was litellm missing something ? any feedback here would be useful


kitty keyboard protocol: AltGr+plus should produce a tilde, but produces a plus instead

On Linux with the DE keyboard layout the AltGr modifier is interpreted differently in Ghostty to Kitty.
Here is kitty's interpretation:
ENTER RELEASE
CSI 13 ; 1 : 3 u

ISO_LEVEL3_SHIFT PRESS
CSI 57453 u

~ PRESS ~
CSI 126 :  : 93 ;  ; 126 u
Alternate key: ]

~ RELEASE
CSI 126 :  : 93 ; 1 : 3 u
Alternate key: ]

ISO_LEVEL3_SHIFT RELEASE
CSI 57453 ; 1 : 3 u

And here is Ghostty:
ENTER RELEASE
CSI 13 ; 1 : 3 u

RIGHT_ALT PRESS
CSI 57449 u

+ PRESS ~
CSI 43 ;  ; 126 u

+ RELEASE
CSI 43 ; 1 : 3 u

RIGHT_ALT RELEASE
CSI 57449 ; 1 : 3 u

A similar issue (QWERTZ layout on a German keyboard) reported here https://github.com/neovim/neovim/issues/31045. In this case, C-] (Ctrl + AltGr + 9) is being encoded by Kitty as CSI 93 :  : 57 ; 5 u, but in Ghostty as CSI 57 ; 5 u.


Generate non-optional properties for all fields.

This updates the generator to generate non-optional properties for all fields, along with has properties and clear methods. Sadly this will increase the generated code size a little bit, but the alternative was not proto-behaviorally correct, so hopefully we can make that increase up elsewhere. In the future I hope that we can make this Swiftier again with resettable properties, property behaviors, or one of the other similarly proposed ideas on swift-evolution.
There's still some cleanup to be done here—the decoder can be simplified now that we're not using the full set of methods, but this change started getting unwieldy enough and that kind of cleanup can be done after the fact.
The commits in this PR have been broken up by file directory to make them easier to scan through. They will not build independently and will be squashed before merging.
Fixes #24.

My guess is this will also fix #22, but we can close that out after the fact once we add some tests to go with it.

@tbkka, please take a look at this as soon as you can; since it's a fairly significant change from your original design I want your sign-off. Because of the scope of this change I'm effectively blocked unless I want to pile up more conflicts (and this change is necessary for some of the other cleanup/enhancements that I want to do). Thanks!

Thanks for a spirited review! Landing it now.


Added definition name to the notifications and error messages

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #74   +/-   ##
========================================
  Coverage      2.69%   2.69%
  Complexity     1333    1333
========================================
  Files           207     207
  Lines          4341    4341
========================================
  Hits            117     117
  Misses         4224    4224

Flag
Coverage Δ
Complexity Δ

#php
2.69% <ø> (ø)
1333 <ø> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cd8b3...3af40a9. Read the comment docs.


Idea: Make the border radius more customizable

The border radius is currently hard-coded, possibly an option such as border-radius to customize may be useful

@HeyAnirudh Feel free to open a pull request for any issue :+1:

Hi @HeyAnirudh, any updates? Do you still plan on contributing to this issue?


Can you provide a bower component of the module.

Hi Team,
I tried to include the module in angular but was unable as i am facing issues while initializing the Excel variable in angular.Can you please provide the link of the bower component of the library or any documentation link in which the module is used with AngularJs.

I am interested in a bower package too. @SoniyaLadhani any luck getting it to work with angular?

@alabaki  Did you found a solution to use Exceljs with Bower?

exceljs needs to be fixed to run in the browser before bower can support it.  See https://github.com/guyonroche/exceljs/issues/31


Seeder failing when doing multiple assertion

Hi, I'm trying to create a seeder for my users, but when I try to load too much element at once it returns me an error (for example I don't have any problems with 10).
  WARNING: Adonis has detected an unhandled promise rejection, which may cause undesired behavior in production.
  To stop this warning, use catch() on promises or wrap await
  calls inside try/catch.

Error: aborted
    at PendingOperation.abort (C:\laragon\www\nodejs\adonis-api\node_modules\tarn\lib\PendingOperation.js:23:21)
    at Promise.all.pendingAcquires.map.acquire (C:\laragon\www\nodejs\adonis-api\node_modules\tarn\lib\Pool.js:138:25)
    at Array.map (<anonymous>)
    at utils_1.reflect.Promise.all.then.then (C:\laragon\www\nodejs\adonis-api\node_modules\tarn\lib\Pool.js:137:53)

Here is my run method
async run () {
        const users = await Factory.model('App/Models/User').createMany(20)
        users.forEach(async user => {
            try {
                const profile = await Factory.model('App/Models/Profile').make()
                await user.profile().save(profile)
                await Database.close()
            } catch (e) {
                throw (e)
            }
        })
    }

I read the documentation but could not find anything related to a seeder failing when 20+ assertions are made. The problem is related to my Database.close(), but if I'm not using it, the command is stuck.

@Cedric-Lefebvre Try to move await Database.close() outside of the foreach loop.
async run () {
    try {
        const users = await Factory.model('App/Models/User').createMany(20)
        users.forEach(async user => {
            const profile = await Factory.model('App/Models/Profile').make()
            await user.profile().save(profile)
        })
        await Database.close()
    } catch (e) {
        throw (e)
    }
}

@jayrchamp Hi, thanks for your answer.
I tried this solution, and the command gets stuck and doesn't quit if I don't have this Database.close() in the foreach.

@Cedric-Lefebvre A forEach loop with async/await will not wait until all items are finished.  To wait the result you can use “for-in loop”. The seeder command will also exit normally after all tasks have finished.
  async run () {
    try {
      const users = await Factory.model('App/Models/User').createMany(40)

      for (const i in users) {
        const token = await Factory.model('App/Models/Token').make()
        const user = users[i];
        await user.tokens().save(token)
      }

    } catch (e) {
        throw (e)
    }
  }

@jayrchamp Thanks a lot for your help, I learned something new today!


Chris

Pushing DFD and Report

After our discussion in discord about the conflict, it looks good to me


fix(415): atOp's writeHash doesn't panic anymore

This should fix #415

Coverage increased (+0.03%) to 64.599% when pulling 16dc78bcd3d5499bd35a2904d1aac0c1385b7a67 on issue/415 into 9f5ade00365405e5ee1ab5befd99d9f86eeb9bf8 on master.


Deployment scripts can easily accidentally clobber config file

We probably want to do something so that the /etc/sandcats-meteor-config.json file isn't as easily clobber-able by the Makefile.
Perhaps a symlink will be our friend.
It's an interesting challenge to want to bring up an entire production-like system in Travis-CI and yet want to avoid accidentally ruining the actual production system. (-:

I think we need this for 1.0 because otherwise I am going to ruin our production servers.


Deduplicate call_automate_event logic

Addressing Identical code found by CodeClimate

CodeClimate scores goes from D -> B 😍

@gmcculloug Updated based on your feedback.


Squid preparations

This PR doesn't have any actual Squid stuff, but just contains some of the changes that I did while trying to integrate Squid. I couldn't complete the Squid integration (https://github.com/emmalanguage/emma/issues/369), but I made some changes that could go into the master nevertheless.
The 1st commit just fixes some minor typos and such.
The 2nd and 3rd commits would have been necessary if we wanted to move addContext to the beginning of our pipelines. In the meantime, I realized that this is probably not needed even for the Squid integration. But they are still good to have, as they fix some bugs with implicit ValDefs that might pop up in other circumstances as well.
The 4th commit is needed for a transformation that we would need to do before we pass a tree to Squid. (see the first issue in https://github.com/emmalanguage/emma/issues/369) I think it is still good to have this in the master, since sooner or later we would try to integrate Squid again, and it is good if the master branch is not too far from https://github.com/ggevay/emma-1/tree/squid , where I tried to do the integration.

The Travis issue seems to be some irrelevant config issue on Travis. All tests run fine locally (even with -Pcompile-spec-pipelines).


Remove instrumentation

Description
Remove instrumentation calls and only keep expliciet spans. This reduces the performance overhead considerably. On a reference lsm test case:

Without any instrumentation: 13.16s
With master: 19.28s
With this pathc: 14.64s

Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in 659484eea646c66ba0f9bf4bc2775eb9322b5d28


Java renames for DI GA

API change check
APIView has identified API level changes in this PR and created following API reviews.
DocumentIntelligence


Replacing a variable's name with Ctrl+Alt+F causes some of the code I wrote before to disappear

Tested versions
4.2.2 stable
System information
Windows10
Issue description
When I use the ctrl+alt+F to replace a variable's name, some of the code I wrote before using the replace function in the currently open script disappears directly
Steps to reproduce

create a script, and add some code like below:

extends Node

var g_test: int
var b_test: int

func start() -> void:
	if g_test:
		print(g_test)

write some additional code below the 'star()' function, any code (or comments), it doesn't matter,
press ctrl+alt+F to replace for example, 'g_test' with 'a_test' and chose to replace them all.
then, what you just write in the 2th step will disappear~

Minimal reproduction project (MRP)
N/A

When you say CTRL+ALT+F, do you mean "Replace in Files"? Because that is bound to CTRL+SHIFT+R by default, with CTRL+ALT+F bringing up the "Jump to Function" modal, which doesn't seem to allow for any replacements.
Regardless, I was able to reproduce the issue with "Replace in Files". As the name implies, it looks for the provided text in the actual source files, while "Replace" looks at the contents of the text editor. This means that any replacement done with "Replace in Files" is going to result in a reload request from editor as the file is newer on disk. If you have any unsaved changes in the editor, they will be lost in the reload.
Can you confirm that the issue doesn't present itself if you save all changes before executing the replacement routine?

Yeah, you are right, I mean Ctrl+Shift+F. And I tried what you mentioned, my code won't disappear anymore if I saved the script before I replace something. However, I still wish my script can be saved automatically when I use the replacement function, since last time my code (a lot of code) disappeared, which made me very frustrated!

You may want to throw your support behind this proposal: godotengine/godot-proposals#9654.


chore: updates latest go mod lib and modifies the ginkgo install instruction

There was confusion to use ginkgo installation
Type of change:

[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches
[ ] Documentation
[x] Refactor
[x] Chore
[ ] CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Hi @tao12345666333 ! while working with make e2e-test, there is a little confusion to install the ginkgo cli . I added some extra info to address it. Hope that makes sense.

Codecov Report

Merging #1819 (46c1994) into master (2182a48) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 46c1994 differs from pull request most recent head 9670e35. Consider uploading reports for the commit 9670e35 to get more accurate results

@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   39.45%   39.45%
=======================================
  Files          91       91
  Lines        8043     8043
=======================================
  Hits         3173     3173
  Misses       4463     4463
  Partials      407      407

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hi @tao12345666333 ! when I try to install ginkgo from go install -mod=mod<EMAIL_ADDRESS>and type ginkgo version, it shows ginkgo not found. Hence, I have added some extra info to address it. What do you think? Thanks

You can add $GOPATH/bin to your $PATH

Thanks! So I have added to it using like below. Hope it makes sense.
https://github.com/apache/apisix-ingress-controller/blob/8eccd0f2142a7374dc1eb6bd15752ccc7bc1e438/Makefile#L154

@afzal442  I don't recommend doing it this way. We can simply export the environment variable instead. I don't want us to directly modify the user's configuration file.

Ah I see! Thanks for that. So what would you recommend doing instead that? any suggestion or I should revert it. 🍓

ping @tao12345666333 in case you missed it.

Closing this as no updates.
cc @tao12345666333


Remove unsupported shapes to make pipeline green

Ticket
No specific ticket
Problem description
T3K frequent pipeline failing
What's changed
Removed unsupported shapes
https://github.com/tenstorrent/tt-metal/actions/runs/12064287738
Checklist

[ ] Post commit CI passes
[ ] Blackhole Post commit (if applicable)
[ ] Model regression CI testing passes (if applicable)
[ ] Device performance regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

Thanks @Aswinmcw !


Update customising oscar docs

Customising oscar section is confusing. In "Fork the Oscar app" section
http://django-oscar.readthedocs.org/en/releases-1.0/topics/customisation.html
It is currently.
$ ./manage.py oscar_fork_app order yourproject/
It should rather be:
$ ./manage.py oscar_fork_app order yourappsfolder/

@codeinthehole @maikhoepfel can we merge this PR? Thanks.

Done


Queue subscriber performance

Reworked sublist to sort out normal subscribers from queue subscribers into
a result set that can be cached and easily iterated over.

Coverage increased (+0.07%) to 79.827% when pulling 96d9ce5048b98a9e92ab37d419fec6e62836ff8d on qsub_perf into fcd87b77c216c1f461068ee7a7d873f4916693dd on master.


Improper checking of token allowance.

Currently there seems to be an assumption that all users will set the token allowance to the maximum value on their first deposit. I set the token allowance to a relatively small just to be safe (around 20DAI)
I've just tried to put a little bit more in which would take me over the amount I have allowed the DEX contract to take. I noticed before sending the transaction but it could have resulted a reverted transaction if I wasn't careful which would be a pain.
I'm guessing there's a check being made somewhere which just tests if the allowance is greater than 0. This should be amended to check it in relation to the user's deposit in progress.
EDIT: further to this, a small ui element to ease setting the token approvals later would be greatly appreciated. Seems like I have to go to Etherscan and approve from the ABI interface which is pretty crap.

This is a good suggestion, going forward, we can provide an option to set approval equal to the amount of deposit. but we cannot set it even 1 larger than the required amount, otherwise, another deposit will have to cancel the existing too small allowance (according to ERC20 standard)  and set a new allowance, thus there will be 3 transactions for the next deposit.

Can you share an Ethereum address to receive the reward? Thank you.

sure, my address is tomfrench.eth. Thank you!


Unary negation happens on nats, not floats (parser issue)

So you can have lots of fun with this…
ergotop$ -2
{nat: -2.0}
ergotop$ -2.0
0.0
ergotop$ -0.2
0.2

Proposal: - for unary negation of floats, ~ for nats. Or somehow allow - for both nats and floats if possible.

Fixed in PR #252


Cloning over SSH using keys with passphrases

In my global git config, I have
[url<EMAIL_ADDRESS>
    insteadOf = https://github.com/

When I run :PlugInstall to get a new plugin, I intermittently am asked for the passphrase to my SSH key. When this happens, it is also impossible to enter said key correctly. I have to change the above lines in my gitconfig to prevent this. Is there a way that vim-plug could handle cloning over ssh with a passphrase protected key?
NVIM v0.1.2-483-g827e267
Build type: Debug
Compilation: /usr/bin/cc -Wconversion -g -Wall -Wextra -pedantic -Wno-unused-parameter
-Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto
-DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/home/siddharthist/Dropbox/code/misc
/clones/neovim/build/config -I/home/siddharthist/Dropbox/code/misc/clones/neovim/src -I
/home/siddharthist/Dropbox/code/misc/clones/neovim/.deps/usr/include -I/home/siddharthi
st/Dropbox/code/misc/clones/neovim/.deps/usr/include -I/home/siddharthist/Dropbox/code/
misc/clones/neovim/.deps/usr/include/luajit-2.0 -I/home/siddharthist/Dropbox/code/misc/
clones/neovim/.deps/usr/include -I/home/siddharthist/Dropbox/code/misc/clones/neovim/.d
eps/usr/include -I/home/siddharthist/Dropbox/code/misc/clones/neovim/.deps/usr/include
-I/home/siddharthist/Dropbox/code/misc/clones/neovim/.deps/usr/include -I/usr/include -
I/home/siddharthist/Dropbox/code/misc/clones/neovim/build/src/nvim/auto -I/home/siddhar
thist/Dropbox/code/misc/clones/neovim/build/include
Compiled by siddharthist@nova

Optional features included (+) or not (-): +acl   +iconv    +jemalloc
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/share/nvim"

Type: Bug
OS: Linux
Vim:

[x] Neovim

Hmm, I'm not sure if there's a perfect solution to this. The Ruby and Python installers execute git commands in parallel and Neovim installer starts the processes in the background, so getting the password is tricky.
As far as I know the only way to ignore ~/.gitconfig is to override $HOME. Maybe you can consider using a custom command that temporarily sets $HOME to an empty string like follows:
function! s:plug_update(bang, args)
  try
    let home = $HOME
    let $HOME = ''
    execute 'PlugUpdate'.a:bang a:args
  finally
    let $HOME = home
  endtry
endfunction

command! -bang -nargs=* MyPlugUpdate call s:plug_update('<bang>', <q-args>)

Does this answer your question?

I mean, there are definitely workarounds, I was just wondering if vim-plug could do anything. Maybe there could be a flag for passphrase encoded SSH keys that diables parallel git commands and allows user input on them?

On vim you can :PlugInstall1 and :PlugUpdate1 to use the synchronous, single-threaded installer so you can type in the password. On Neovim, it's always asynchronous, so um..
An easy workaround I think is to provide an option that tells vim-plug to always use synchronous, single-threaded installer. But I don't think there's a high demand for that especially when we already have workarounds. Theoretically, yes, vim-plug could do more, like detecting if any of the plugins require password prompt and switching the execution mode accordingly, but I'm afraid that it'll over-complicate the implementation.

Tim Pope’s vim-fugitive plugin also requires to input ssh passphrases from Neovim.
On Arch Linux and neovim, I use x11-ssh-askpass, that works great. It is also available on Debian and other distros as ssh-askpass, and it is built on X11 libraries.


TypeError: Converting circular structure to JSON  when trying to save BreezeJS object

I am trying to save a BreezeJS object to session storage that by design has circular references.  Is there a way to override the serializer used?

Use .setSerializer and .setDeserializer introduced with this commit 7df1d5333ff83d56a53e090608073bfc2cbc5ee0.

Hey!
Sorry, haven't gotten around to releasing a version with that one yet, but if you can manage to use master those are indeed available during the config phase!
I also have to write the documentation.
Thanks steven10172 for pointing it out!

Closing this. As steven10172 pointed out that you can now change serializer :)


Contributing Guidelines

This is a rough first draft of a CONTRIBUTING.md, as per https://github.com/rackt/redux/issues/443.
Still need to describe version, preversion, postversion, and prepublish scripts.
Also not sure what else needs to be covered.

Lol, I totally forgot I have these *version scripts.
I don't use them—I bump manually.
Maybe I should.

Ping @hedgerh. This looks great. I'd love to get it finished and merged. No pressure if you are too busy right now—if you like I could take what you've done and carry on from here.

We should add a section to this document about style changes and eslint-config-rackt which says basically what @timdorr said in the second paragraph of this comment https://github.com/rackt/redux/pull/1081#issuecomment-161725054.

Sorry for the delay.  Just started a new job.  I'll make revisions tonight.  @ellbee if I don't get it wrapped up tonight, I'd definitely appreciate some help

@hedgerh Cool, thanks. No need to apologise, I appreciate the effort you put into this.

@hedgerh I've squashed your commits and created a new PR #1124. Thanks again.


change release procedure and deprecation again

Go with a more telescope-like release process.  The head of main always supports nightly. There is a branch that support the most recent stable. When possible changes are back ported to the stable branch.

This seems to be the way many/most of the plugins I am familiar with work (more-or-less).


Why Cors AddPolicy doesn't allow *.example.com ?

From @AhmedRagheb on January 5, 2018 13:58
Hello,
Is there a reason (security may be) that prevent Cors AddPolicy from adding all subdomains of my domain in Origins list. As I think it doesn't make sense to add all my subdomains to the Origins list.
Thanks.
Copied from original issue: dotnet/coreclr#15753

Closing since this question has been answered.


Example Index Version 2

-Feedback from the community about Dash Example Index

Add annotations to code to explain difficult parts.
Wasn’t sure how to interact with each example (maybe put an additional tooltip that says ‘click to interact?’)
Overview button may be redundant because the Navbar Brand takes you back to the home page as well.
On the Navbar collapse, the overview button has a little overflow on mobile. Looks like a margin-left: 0.5rem does the trick
Create apps that tackle common error messages
Create apps that serve common/popular questions: hiding Dash DataTable columns based on screen size or  converting the html on the page to an image and downloading it.

Difficult apps will be refactored, as we would like to keep examples as simple as possible for beginners. If you identify an app that is too difficult for beginners, please let us know.
Potentially add a hover effect on each app card, just like the Dash Enterprise App Gallery, to make it clear.
Overview button is needed since it has a slightly different function than the Dash Example Index
This will be fixed (overview button has a little overflow).
Gathering content for error messages and apps that serve common/popular questions. This is on branch error-index

All done.


Create UnnecessaryAnnotationUseSiteTargetRule

Closes #1138
Extracted from the issue:

Quite often I see that the annotation use site targets are used inappropriately.
For instance:
class Presenter(
  ...
  @param:SchedulerMain private val mainScheduler: Scheduler,
  @param:SchedulerComputation private val computationScheduler: Scheduler
)

param: isn't required and hence it should be flagged.

This new rule flags that.

I'm having problems with ./gradlew generateDocumentation. I'm getting this error:
Exception in thread "main" io.gitlab.arturbosch.detekt.generator.collection.exception.InvalidDocumentationException: Rule Rule was specified in a provider but it was not defined.
        at io.gitlab.arturbosch.detekt.generator.collection.DetektCollector.findRuleByName(DetektCollector.kt:47)
        at io.gitlab.arturbosch.detekt.generator.collection.DetektCollector.resolveParentRule(DetektCollector.kt:53)
        at io.gitlab.arturbosch.detekt.generator.collection.DetektCollector.buildRuleSetPages(DetektCollector.kt:33)
        at io.gitlab.arturbosch.detekt.generator.collection.DetektCollector.getItems(DetektCollector.kt:19)
        at io.gitlab.arturbosch.detekt.generator.Runner.execute(Runner.kt:29)
        at io.gitlab.arturbosch.detekt.generator.Main.main(Main.kt:14)

Why? How can I fix it?

You haven't defined the rule in the config.yml file.

Do you mean default-detekt-config.yml? It's the only config.yml file that I find. I tried to debug the code a bit but I don't know what's going on.

Do you mean default-detekt-config.yml? It's the only config.yml file that I find. I tried to debug the code a bit but I don't know what's going on.

Looking over the changes I see that everything is okay in the default-detekt-config.yml file.
The received exception is strange, because everything looks fine.
Do you have any temporary files? Could you please try to execute git clean?

Do you mean default-detekt-config.yml? It's the only config.yml file that I find. I tried to debug the code a bit but I don't know what's going on.

Looking over the changes I see that everything is okay in the default-detekt-config.yml file.
The received exception is strange, because everything looks fine.

Thanks! That line was the only code that I didn't copy&paste from other rule... because intelliJ creted it for me.

Codecov Report

Merging #2099 into master will increase coverage by 0.07%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##             master    #2099      +/-   ##
============================================
+ Coverage     80.84%   80.92%   +0.07%
- Complexity     2008     2015       +7
============================================
  Files           336      337       +1
  Lines          5784     5808      +24
  Branches       1059     1060       +1
============================================
+ Hits           4676     4700      +24
+ Misses          546      545       -1
- Partials        562      563       +1

Impacted Files
Coverage Δ
Complexity Δ

...bosch/detekt/rules/providers/StyleGuideProvider.kt
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

.../rules/style/UnnecessaryAnnotationUseSiteTarget.kt
95.65% <95.65%> (ø)
7 <7> (?)

...kotlin/io/gitlab/arturbosch/detekt/api/Location.kt
81.48% <0%> (+3.7%)
4% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc7d14...c3b7279. Read the comment docs.

Do I need to change somthing in this PR to be merged? Or are we waiting the 1.2.2 release?

@BraisGabin 1.2.2 is only a patch release, which should only fix bugs. We currently have 2 bugs and 1 doc PR left to merge.
I’d merge this for v1.3.0. For me the PR looks fine. Big thanks for that!!


lbmap: Do not arping each service backend IP addr

Previously, we used to arping each service backend IP address to retrieve the mac address of the next hop to the backend IP addr. The IP => mac mappings were inserted into the Linux ARP table, so that NodePort's fib_lookup() could find the relevant mapping.
As the next hop mac addr is of a Cilium node, the mapping can be learned by arping'ing the Cilium node once it has joined the cluster (same as in the crypto case).
Tested on 20 nodes AWS cluster with vxlan and disabled tunnel by inspecting Cilium drop counters.

This change is

test-me-please

Coverage increased (+0.02%) to 44.165% when pulling ca7ce902d151ed1af582e589a6d4fe1564635bac on pr/brb/no-neigh-entry-per-backend into 683c087d043f028ba8a01dc1c1be5d8529f9d6e3 on master.