help for inverter  Voltronic Infini VII WP

Hello I wanted to ask the code for  Inverter voltronic Infini VII WP .... connected with the rs232-usb cable reads nothing and connects and disconnects ...I think it has the PI17 protocol ... I tried to change it in dbus-mppsolar.py but it does not work can you help me ? thank you very much

nverter voltronic Infini VII WP .... connected with the rs232-usb cable reads nothing and connects and disconnects ...I think it has the PI17 protocol ... I tried to change it in dbus-mppsolar.py but it does not work can you help me ? thank you very much

@legolas3107 Hi, Originally I planned to use this repo as a self-hosted project for me.
But given the wide interest, I think I will try to enable support for more inverters.
If you can give me more information about your inverter, I can try to draft supprot for it.
The current code, if the inverter is not PI30 protocol will exit, leaving the information data in VRM empty and showing as "disconnected". (as in your screenshots).

My inverter is a voltronic Infini VII WP - a hybrid inverter features IP65…. in the mpp-solar the PI17infini protocol exists but I think that in yours for venus it isn't there... I don't know if it's correct but with PI17 it doesn't read anything... tell me if do you need more data... thank you very much

if you run mppsolar with command "QPI" it should return back the protocol of the inverter.
I updated the main code to support multiple protocols, but only implemented PI30 and a pseudo support for PI17. Check if it at least doesn't crash, or prints something useful to /var/log.
If I knew the protocol I could draft a commit for the protocol.

this is the result of QPI

I hope I didn’t get it wrong , I can’t see the logs but it won’t crash. I reinstalled the package after your change is the same thing. if you tell me where to look I’ll send you the screens

thanks as you see in the screenshot the result is 0 , nothing is read

0 is the protocol or there is an error on the serial port ...the converter chip is FTDI

If there was a problem with the converter, then there should be no correct output.
I have seen that there is actually a protocol PI00 in mpp-solar:
root@raspberrypi2:~# mpp-solar -p /dev/ttyUSB1 --getDeviceId
usage: mpp-solar [-h] [-n NAME] [-p PORT] [--porttype PORTTYPE] [-P {PI00,PI16,PI17,PI18,PI30,PI30MAX,PI30REVO,PI41,VED,DALY,DALY40}]

I don't know if you have already read through the other issue #1, but it might also help you to manually set the protocol to PI00 in line 45 of the latest commit and reboot your system.

changing in line 45 with PI00 in the dbus-mppsolar , nothing has changed

looking at this test and the response of the serial should be the protocol PI17INFINI...  correct?

Depends.. the response means "ACK" or "NACK" and is common to PI17/PI17Infini/P18/P18sv.
If we could narrow down the inverter, then we can find out.
PI should return for your inverter the protocol.
Try the latest main branch and check the /var/log
However, looking at PI17, it only supports setting parameters, not reading data. So it might not be so useful to have the dbus interface working, unless you plan to control the inverter with it.

the protocol response as in screenshot is 0 ...does not read PI17 data?How do I try the last main branch ?

the protocol response as in screenshot is 0 ...does not read PI17 data?How do I try the last main branch ?

You can just to "git fetch" + "git reset --hard origin/main" to reset the git repo to the upstream latest one.
This will ovewrite all the local changes.
However, if the protocol returned is 0 I am not sure how to proceed from there.
Maybe we can update to latest mppsolar repo, but they changed too many things, and I am not too confortable coding on python to know how to fix it.

could you also add for the PI00 ... or maybe tell me where to put it ? thanks for the help

However, looking at PI17, it only supports setting parameters, not reading data. So it might not be so useful to have the dbus interface working, unless you plan to control the inverter with it.

I'm not sure, but I think it is actually possible to query the same values with PI17.
Checking all commands for the PI17, there are values, which should match those of PI30:
root@raspberrypi2:~# mpp-solar -P PI17 -c
Command: command help - List available commands for protocol PI17
------------------------------------------------------------
Parameter                       Value           Unit
PI                              Device Protocol Version inquiry -- queries the device protocol version
ID                              Device Serial Number inquiry -- queries the device serial number
VFW                             Device CPU version inquiry -- queries the CPU version
VFW2                            Device CPU 2 version inquiry -- queries the CPU 2 version
MD                              Device Model inquiry -- queries the device model
PIRI                            Device rated information -- queries rated information
GS                              Device rated information -- queries rated information
PS                              Device Power Status -- queries power status
MOD                             Device working mode inquiry -- queries the device working mode
WS                              Warning status inquiry -- queries any active warnings flags from the Inverter

Maybe it will help? Whereby the output of @legolas3107 does not refer to PI17, but rather to the PI00 protocol?
@legolas3107:
Can you query the data with the latest mppsolar release?
I think it would help to go this step first, then we know the protocol and the commands.
And knowing that @DarkZeros could implement the protocol to this project.

Hello @w0vka I also tried with a linux pc with only mpp-solar installed but I can't read any data with any protocol ... protocol_id 0 this is the resolute...I tried to look for solutions for the voltronic infini solar VII WP 5k but I can't find anything

Infini-Solar V&VII&VIII&VIV& V II 6K LV Split-Phase&TWIN protocol 202205....xlsx
This is what I was given by the store... it says it's voltronic owner

@legolas3107 I think it makes sense for you to submit your request/issue directly to jblance.
Maybe John or someone else from the project can integrate your device into mpp-solar. With the protocol documentation, that shouldn't be a problem for the guys.

@legolas3107 I think it makes sense for you to submit your request/issue directly to jblance.
Maybe John or someone else from the project can integrate your device into mpp-solar. With the protocol documentation, that shouldn't be a problem for the guys.

Followed your advice thank you

Once I have time i will take latest mppsolar from jblance.
If they implement the protocol by then then I can implement it here later on.

sometimes the command does not work but now with #jblance we have understood the protocol .... @DarkZeros can you make it work?

I think with that I can, yes, I will try to find time to implement it. First I need to update mpp-solar to the latest version (or does it work with the current one?) Also PIRI command gives the information about the specs, but is there any command that gives live data?

In the screen I think there are data that come out in real time ... the code is updated to 5 months ago so I do not know if even with the old version can work

I @DarkZeros  news?

hi @w0vka could you help me implement the PI18 protocol too, I'm not very experienced with pyton. You were also able to make yours work by changing a few lines

Hi Legolas sry but I did not have time to work on this.
First I need to update mppsolar to be on the latest version, and then add PI18 to the conversion interface.
And right now, the vscode remote into the venus OS does not seem to work, which makes testing this and developing even harder (and I don't have much spare time for this side project).
i will eventually come back and fix it , but I welcome any contributions to the project to help maintain it, and I will merge them if they work.


Renamed preprocessor directives

The USE_MIKIC and MIKIC_TEMPERATURE_FRACTION preprocessor directives have been changed to USE_JB and JB_TEMPERATURE_FRACTION. This is because HYDRAD uses the updated method of modifying the thermal conduction developed by Johnston & Bradshaw.

Great thanks! I'll get around to adding these soon. @cdj3 this will likely be of interest to you as well.


XML DTD ID/ID REF support for attributes.

Hi Steve,
Started work on support for XML IDs.

Smite has been slightly tweaked to have the is_id and is_idrefs properties
The taggedelem and emptyelem have been merged into a single "element" function, as they were mostly the same.
Attribute creation is now done in the new elem function, as the ATTList DTD declarations have to be checked before creation.
Have adjusted the parser to check for duplicate XML IDs as well as missing IDs for IDREFs
The ParserConfig has been updated to enable/disable this feature. It is on by default
The transformation steps have not yet been updated to handle these new capabilities, just setting is_id and is_idrefs to false when creating attributes. Will need to research some more about what needs to happen here.
Elements do not yet have IDs, will need to add that at a later stage.
xml:ID is not part of this pull request, I need to do a bit of reading on those.

Should mention, I'm happy to hold off on this one until after the latest version release, the namespace changes are big enough.

This is a good development, but we need to make sure the design supports ID/IDREF, xml:id, id(), and also is compatible with key().
Let's hold on to this PR until the 1.1 release is done.

Sounds good, I'll take a look into those points and come back with some updates.

Instead of having is_id, is_idrefs arguments to new_attribute(), could we use the Value being passed in as the attribute value? That is, Value::ID("x"), Value::IDREF("x"), Value::IDREFS("x y z")
If the attribute is declared to be of type ID or IDREF or IDREFS then the value being passed in must be that type (or coercible to that type).
This design might work better in future when we build support for XML Schema data types.

Yes we should! I'll get the changes made and we can look at this again when ready.

Closing this, gonna reopen with a cleaner git history.


There was an error installing the requested package.

Probably related to #6485
Repro:
Fresh 1.10 setup
Install module http://gallery.orchardproject.net/Packages/Orchard.Module.SH.Robots
Error:
"There was an error installing the requested package." + some text about folder permissions
Quick fix
Click 'download' instead of 'install' to get the module. Then install local module from /Admin/Modules
Cause:
The package cannot be found. PackageInstaller.cs, line 55
var package = packageRepository.FindPackage(packageId, packageVersion);

Result:
            if (package == null) {
                throw new ArgumentException(T("The specified package could not be found, id:{0} version:{1}", packageId, String.IsNullOrEmpty(version) ? T("No version").Text : version).Text);
            }

This throws an ArgumentException which will be caught as an Exception, giving the generic error message. Also the message localization is wrong; will never translate correctly.
Fix:
            if (package == null)
            {
                var message = String.Format(T("The specified package could not be found, id:{0} version:{1}").Text, packageId, String.IsNullOrEmpty(version) ? T("No version").Text : version);
                throw new OrchardException(new LocalizedString(message));
            }

Question remains why the package cannot be found, but can be downloaded from the NuGet feed.

Issue is fixed by in the Gallery module
Calling client code should still be fixed. PR to which branch? dev, master, 1.9.x, 1.10?

The issue was on the server code, any client should work fine now. So it should work with any Orchard version.

Closing the issue for now unless you can repro it since I updated the gallery.

Sebastien, there still is an issue on the client side. The server side failed with package == null. The code looks like it's handling the error, but it doesn't.

@sebastienros repro: Modify a package install URL under "/Packaging/Gallery/Modules" so that the package ID is invalid. Without change, the exception message will not be displayed as it's caught by PackageManager.DoInstall() and wrapped in an OrchardException. As suggested by the PR, throwing an OrchardException (instead of ArgumentException) will surface the original message, so the user will get a better understanding of what's happened.


Feature request: Support "file:" feeds

Trying to add a local file as a feed does not work. The error given is

Feed not found
Can’t add a feed because no feed was found.

RSCore's (NSString *)rs_normalizedURLString coerces the string to start with "http:" or "https:", so this is before the RSWeb side of things. A quick way to see the effect is to copy a "file:" URL to the clipboard and then use "File > New Feed". This happens with and without the "file:" URI scheme: /var/tmp/test.xml becomes http:///var/tmp/test.xml and file:///var/tmp/test.xml becomes http://file:///var/tmp/test.xml.

+1
Allows for custom feeds using web parsing scripts. Probably not a big change since the remote (http) xml feeds are aready supported.

+1


Restrict Property should not allow dot(.) if it is not mentioned in restrict

<s:TextInput restrict="0-9A-Z" maxChars="4" id="bmt_Code" width="250" tabIndex="1" x="205" y="141"/>

s:TextInput should not allow dot (.) if restrict is "0-9A-Z"
I removed slash between "0-9A-Z" because it was taking "/" as a character and allow it to be typed in
s:TextInput.
If restrict="0-9/A-Z" then it allows 0-9 A-Z "/" and dot(.)
If restrict="0-9A-Z" then it allows 0-9 A-Z and dot(.)

@aharui Thank u so much


Add Range Validation for SQFP16

Description
This PR adds range validation for Faiss SQFP16 where by default it validates the user input if it is in the FP16 range [-65504.0, 65504.0] and if it is out of range throws an exception. Users can still provide data that is out of fp16 range which will be clipped to fp16 range(without throwing any exception) when they set this encoder parameter, clip as true.
{
    "name": "sq",
    "parameters": {
           "type": "fp16",
           "clip": true
      }
 }

Issues Resolved
https://github.com/opensearch-project/k-NN/issues/1138
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The failing Rolling Upgrade Tests and CI on Windows is not related to these changes, created an issue to track it https://github.com/opensearch-project/k-NN/issues/1494

Instead of clip_to_range, what about truncate? Is clip used anywhere else?

I took numpy as a reference, where they call it as clip. As discussed offline will rename it from clip_to_range to clip.

Can we add bwc tests here?

@naveentatikonda what is clip parameter going to do?

@naveentatikonda what is clip parameter going to do?

If the clip parameter is set to true and if any of the input vector is outside of the FP16 range, it will be clipped to FP16 range.
Like if the vector value is > 65504.0, then it is indexed as 65504.0
if the vector value is < -65504.0, then it is indexed as -65504.0

@naveentatikonda what is clip parameter going to do?

If the clip parameter is set to true and if any of the input vector is outside of the FP16 range, it will be clipped to FP16 range.
Like if the vector value is > 65504.0, then it is indexed as 65504.0 if the vector value is < -65504.0, then it is indexed as -65504.0

So anything outside the range of fp16 is actually getting mapping to 1 single value. Can we do something better here? I am pretty unsure about this. What experiments we have done to understand the impact of this clipping?
cc: @jmazanec15 , @vamshin

@naveentatikonda what is clip parameter going to do?

If the clip parameter is set to true and if any of the input vector is outside of the FP16 range, it will be clipped to FP16 range.
Like if the vector value is > 65504.0, then it is indexed as 65504.0 if the vector value is < -65504.0, then it is indexed as -65504.0

So anything outside the range of fp16 is actually getting mapping to 1 single value. Can we do something better here? I am pretty unsure about this. What experiments we have done to understand the impact of this clipping?
cc: @jmazanec15 , @vamshin

Clipping out of range values to MIN or MAX values is also one of the standard quantization technique and we implemented this after discussing with Science team. Do you have any suggestions to implement it even better ?
As of now we didn't run any experiments with clipping as we don't have any standard datasets with data outside of Fp16 range. But, the impact depends on the distribution of vectors and if most of them lies outside of the range then the impact on recall will be high. In such scenarios we won't recommend customers to enable this field.

Alternative 2 I can think of is to take approach that can be taken with uint8 and Lucene. Where you more or less look at the distribution of the data and come up with a mapping scheme based on this from fp32 to 16-bit. This may offer a better tradeoff, but would require a good amount of work on our side as well as user side and benefit is unknown.

@jmazanec15 Do you mean normalizing the complete data and bucket them into the FP16 range ?

@naveentatikonda yes, but I dont think this is in scope for now

I think its good to merge to feature branch. Lets add IVF support once #1527  is merged.


Windows Documentation

I see here, http://capistranorb.com/documentation/getting-started/authentication-and-authorisation/, you don't have any windows documentation. Is this still true? I can contribute documentation if it still need and/or wanted. I use Windows for development and have my Capistrano setup (with rails) going and working.

That would be fantastic Ryan!
Sent from my Nexus 5.
On 14 Jan 2015 03:37, "Ryan Condron"<EMAIL_ADDRESS>wrote:

I see here,
http://capistranorb.com/documentation/getting-started/authentication-and-authorisation/,
you don't have any windows documentation. Is this still true? I can
contribute documentation if it still need and/or wanted. I use Windows for
development and have my Capistrano setup (with rails) going and working.
—
Reply to this email directly or view it on GitHub
https://github.com/capistrano/capistrano/issues/1324.

I want to clarify this would be a Windows Development Machine, deploying to Linux Server. Is this what we are needing?

Exactly, that'd be amazing. I don't know even enough about Windows (I haven't used a Windows machine since XP was the new hotness) to even know whether it makes sense to integrate that into our existing docs, or have a special FAQ/quick start Windows document linked from the sidebar, I defer to your wealth of experience on that front.

What the best way to submit the documentation? Should I create a Wiki Page on github, I ask because the github docs are for legacy 2.X of capistrano.

The repository that contains the docs are https://github.com/capistrano/capistrano.github.io - they are rendered with Jekyll (I think), and served under capistranorb.com by Github.

I am just coming back to this, should windows documentation be a separate page so it doesn't get confusing? I am finally putting my notes together on this and would like to get this done. Thanks.

Thanks, we should really have the Windows docs separated. Were you able to make much progress here?

Closing in favor of https://github.com/capistrano/documentation/issues/161


Hope，Add the function of the repository initialization, please

hi,
Hope，Add the function of the repository initialization, please

https://github.com/gogits/gogs/blob/master/.github/ISSUE_TEMPLATE.md


commitizen: 2.42.1 -> 3.5.2

Description of changes
https://github.com/commitizen-tools/commitizen/blob/master/CHANGELOG.md#v352-2023-06-25
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Superseeded by https://github.com/NixOS/nixpkgs/pull/240782


Airline Theme no longer working

Since updating to https://github.com/arcticicestudio/nord-vim/commit/73b3d340a735a2b6915f62a8904d6521251375cd the Airline theme no longer applies successfully on Neovim with vim-airline https://github.com/vim-airline/vim-airline/commit/b93492b40b068d4bb3020c123295061aaba7c846

Hi @heliostatic :wave:, thanks for your contribution :+1:
I've tried to reproduce the problem, but it works fine with the current develop branch, when explicitly checking out the 73b3d34 commit as well as the latest release version 0.13.0 that includes the change. I've used this minimal test vimrc:
call plug#begin(expand('~/.vim/plugged'))
Plug 'vim-airline/vim-airline'
Plug 'arcticicestudio/nord-vim'
call plug#end()

" Works with both enabled and disabled option.
let g:nord_uniform_status_lines = 0

syntax enable
colorscheme nord

Could you please provide a minimal vimrc and a small step-list how to reproduce the problem on your side? Also please post a screenshot of what's not working any more (or the exact error message) as well as more information about your setup like the Neovim version and the way plugins are installed and loaded.

I found the culprit -- I was also loading https://github.com/flazz/vim-colorschemes and the nord theme in there was causing the issue. I'm not sure how to specify loading the correct nord, but in the short term the problem is solved. Thank you so much for the minimal vimrc for testing.

Nice to see you found the root cause :smile:
„Collections” and „theme bundles” like these are always a problem when it comes to code maintenance since themes are copied once but never kept up-to-date with their upstreams. In general I'd recommend to avoid them and instead explicitly install plugins you really like to use, otherwise you'll also add like e.g. 200 files to your setup while only using one of them.
I guess the problem with the plugin is the fact that the nord_uniform_status_lines variable is not defined in the theme at all (last update was 23 Aug 2017 :astonished:)
Anyway, glad to see it works for you now.


How to encript auth cookie back

So using your decryptor from ASP.NET core app to decode an auth cookie created by my legacy WinForms app. This allows me to reuse the authentication created in my legacy app and reuse it in core app. The problem is that I need to advance the sliding expiration of the auth cookie forward so person is not automatically signed off if inactive on legacy app for more than 20min but active on core app. To do this I must rewrite the decoded auth cookie with new expiration datetime. How do I do this? Would I need an Encrypt function for that? If so do you have something like this or planing to add such a feature?

Sorry I'm not planning to add encryption. I'd suggest using the Forms Auth auth token created by your legacy WinForms app as proof of identity, but then create a new 'session' using currently supported ASP.NET security options. You probably don't want to tie your .NET core app to Forms Auth anyway.


Add option to transition to payload execution at specified refresh

This PR implements optional feature that allows to specify exact transition refresh command number (from start, as seen by RefreshCounter). It specifies the refresh at which the transition from Memory Controller to Payload Executor will take place. The feature is enabled via the dfi_switch_at_refresh CSR.
If dfi_switch_at_refresh it is set to 0, then the feature is disabled and we get the standard behavior: mode transition happens at the first refresh after the payload_executor_start CSR is written (to be exact, payload execution mode is active 1 cycle after the refresh has been sent on DFI).
If dfi_switch_at_refresh CSR value is other than 0, then we get the new behavior: mode transition is delayed until the current refresh count is equal to the value of dfi_switch_at_refresh. For example, settings wb.regs.dfi_switch_at_refresh.write(1000) means that after writing wb.regs.payload_executor_start.write(1) the transition will be delayed until the total number of refresh commands (since bitstream has been loaded) will be 1000. This means that payload execution mode will be active 1 cycle after the 1000th refresh has been sent on DFI.
Setting dfi_switch_at_refresh to a value lower than the current refresh count will result in the executor blocking (in practice) indefinitely. It can be unlocked simply by updating dfi_switch_at_refresh to a correct value of by setting it to 0 disabling the feature.
The feature can be tested by configuring the desired refresh count, e.g.
wb.regs.dfi_switch_refresh_update.write(1)
now = wb.regs.dfi_switch_refresh_count.read()
wb.regs.dfi_switch_at_refresh.write(now + int(1e7))

and then starting the payload executor, e.g. with python rowhammer_tester/scripts/hw_rowhammer.py --pattern 01_per_row --nrows 512 --read_count 10e6 --pattern 01_in_row --row-pairs const --const-rows-pair 6 8 --payload-executor.
I haven't added any command line switch for rowhammer.py/hw_rowhammer.py as this feature is probably more useful for automated tests, like the playbook, but if needed we could probably also add such an argument in those scripts.
@sqazi Do you think this behavior will be ok?

The description matches my expectations.  Thanks for doing this!  I will try to test this soon.

Sorry, I forgot to update this.  It works fine for me.  Thanks!


[BUG] Problem with optimizer update step

I keep having this trouble with the optimizer and I am not sure what is causing it. The error is below:
Traceback (most recent call last):
  File "02232022_kat_repr_train.py", line 89, in <module>
    first_exp.run_experiment()
  File "experiments.py", line 28, in run_experiment
    self.trainer.train(self.hyperparameters["epochs"], self.hyperparameters["eval_period"])
  File "trainer.py", line 90, in train
    self.optimizer.step()
  File "/anaconda3/envs/mmlm/lib/python3.8/site-packages/deepspeed/runtime/zero/stage_1_and_2.py", line 1633, in step
    self.check_overflow()
  File "/anaconda3/envs/mmlm/lib/python3.8/site-packages/deepspeed/runtime/zero/stage_1_and_2.py", line 1913, in check_overflow
    self._check_overflow(partition_gradients)
  File "/anaconda3/envs/mmlm/lib/python3.8/site-packages/deepspeed/runtime/zero/stage_1_and_2.py", line 1818, in _check_overflow
    self.overflow = self.has_overflow(partition_gradients)
  File "/anaconda3/envs/mmlm/lib/python3.8/site-packages/deepspeed/runtime/zero/stage_1_and_2.py", line 1837, in has_overflow
    overflow = self.local_overflow if self.cpu_offload else self.has_overflow_partitioned_grads_serial(
  File "/anaconda3/envs/mmlm/lib/python3.8/site-packages/deepspeed/runtime/zero/stage_1_and_2.py", line 1830, in has_overflow_partitioned_grads_serial
    for j, grad in enumerate(self.averaged_gradients[i]):
KeyError: 0

My training loop is nothing fancy, pretty standard:
outputs = self.model(**batch)
loss = self.loss_function(outputs)
loss.backward()
self.optimizer.backward(loss)
self.model.zero_grad()

I initialize deepspeed like this: self.model, self.optimizer, _, self.lr_scheduler = ds.initialize(model=self.model, config_params=self.deepspeed_config, optimizer=self.optimizer, lr_scheduler=self.lr_scheduler)
I am using the example configurations from here: https://github.com/microsoft/DeepSpeedExamples/blob/master/Megatron-LM/scripts/ds_zero2_config.json
Does anyone know why I am getting this issue?
Thank you!

@benjamin-reichman, thanks for reporting this error. That Megatron-LM code is quite old. Is it possible for you to use this version? This one is more actively used. Thanks!

@benjamin-reichman, did you solve this problem yet? I met the same problem and I wonder how to solve it.


Compiling the quickstart with C++20

I am following the Quickstart and can't seem to get it to compile with a standard version newer than C++0x. My workspace file is copy/pasted from the tutorial:
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "com_google_absl",
    urls = ["https://github.com/abseil/abseil-cpp/archive/98eb410c93ad059f9bba1bf43f5bb916fc92a5ea.zip"],
    strip_prefix = "abseil-cpp-98eb410c93ad059f9bba1bf43f5bb916fc92a5ea",
)

http_archive(
    name = "bazel_skylib",
    urls = ["https://github.com/bazelbuild/bazel-skylib/releases/download/1.2.1/bazel-skylib-1.2.1.tar.gz"],
    sha256 = "f7be3474d42aae265405a592bb7da8e171919d74c16f082a5457840f06054728",
)

http_archive(
    name = "com_google_googletest",
    urls = ["https://github.com/google/googletest/archive/011959aafddcd30611003de96cfd8d7a7685c700.zip"],
    strip_prefix = "googletest-011959aafddcd30611003de96cfd8d7a7685c700",
)

http_archive(
    name = "com_github_google_benchmark",
    urls = ["https://github.com/google/benchmark/archive/bf585a2789e30585b4e3ce6baf11ef2750b54677.zip"],
    strip_prefix = "benchmark-bf585a2789e30585b4e3ce6baf11ef2750b54677",
    sha256 = "2a778d821997df7d8646c9c59b8edb9a573a6e04c534c01892a40aa524a7b68c",
)

I further have a .bazelrc like the following (also tried the command-line flags):
build:c++20 --cxxopt=-std=c++20
build:c++20 --copt=-std=c++20

build --config=c++20

Then running:
bazelisk test --sandbox_writable_path=$HOME/.cache/ --test_tag_filters=-benchmark @com_google_absl//...

fails with:
ERROR: /home/tom/.cache/bazel/_bazel_tom/cdf5ab22dd3c27db056e899d731234c7/external/com_google_absl/absl/synchronization/BUILD.bazel:30:11: Compiling absl/synchronization/internal/graphcycles.cc failed: (Exit 1): gcc failed: error executing command /usr/lib64/ccache/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 33 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from external/com_google_absl/absl/synchronization/internal/graphcycles.cc:42:
external/com_google_absl/absl/base/internal/spinlock.h:156:21: warning: bitwise operation between different enumeration types 'absl::base_internal::SpinLock::<unnamed enum>' and 'absl::base_internal::SpinLock::<unnamed enum>' is deprecated [-Wdeprecated-enum-enum-conversion]
  156 |     ~(kSpinLockHeld | kSpinLockCooperative | kSpinLockDisabledScheduling) };
      |       ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
external/com_google_absl/absl/synchronization/internal/graphcycles.cc: In member function 'void absl::synchronization_internal::GraphCycles::RemoveNode(void*)':
external/com_google_absl/absl/synchronization/internal/graphcycles.cc:451:52: error: incomplete type 'std::numeric_limits<unsigned int>' used in nested name specifier
  451 |   if (x->version == std::numeric_limits<uint32_t>::max()) {
      |

As you can see in the error message, it's passing '-std=c++0x' to the invocation. I don't think this is the g++ default anyway.
I have g++ 12.2.1 which should support the newer standard. What am I missing?

The -std=c++0x is unfortunately a Bazel default, but you should be able to override it. I don't see anything obviously wrong in what you posted, but the example is incomplete. Can you post a git repo so we can try your exact setup ourselves?

It looks like you are just using an old version of Abseil that doesn't work with GCC 12 by default. The versions listed in the example WORKSPACE file aren't meant to be copied directly. You have to choose a newer version.


Quotation Maker

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
A sample quotation maker that can be modified and then can be used in any website.
Tech Stack
Web Development (HTML,CSS,JS)

Could you please assign this issue to me.


feat: port histogram model

This PR ports the work done in #52 to the v2-mvc branch, performing significant restructuring of the business logic. It does not (or shouldn't 😅) integrate with the existing model/view (yet), although the goal is to make it trivial to do so later via modular components.
Notably, this PR also currently includes support for Jupyter (no pygfx yet though 😢)

Thanks for taking a look @tlambert03!

One thing that's worth noting: if the histogram and all of its interactive elements like clims handles and stuff are purely vispy/pygfx objects, then we don't actually need Qt and Jupyter wrappers at all. That is already provided for us by vispy & jupyter_rfb directly. We only need these qt/jupyter views when we're adding additional sliders and buttons that are also controlling the model

As I mentioned above, the only reason those versions exist right now is to add the logarithmic range/vertical domain buttons that were added in the v1 example. I do think that we will want non-canvas controls for our histograms, so I'm hesitant to remove them, but at the same time I get where you're coming from. Maybe I'll have more ideas once I dive into #56 and rebase this PR on top...

Some remaining discussions, all of which I think are non-blockers that we could file issues for (reflecting the rapid iteration goal of the v2-mvc branch:

[ ] I find sporadic segmentation faults in CI, arising from tests/test_nd_viewer.py::test_ndviewer. I'd be surprised if this is related to my changes...

[ ] We should add some (public) API (at some points) for the PHistogramView methods for setting domain, range, domain axis, etc. While the histogram widget added in #52 had a button "Vertical" for setting the domain axis. Options include:

Access to the PHistogramCanvas via a public field or property.
Wrapper methods on the HistogramController.
Either way, we can add that later.

[ ] We may want some API to disable pan/zoom - maybe PHistogramCanvas.set_interactive(enabled: bool)?

[ ] We should decide on what it means to "reset zoom".

Should the zoom center around the data, or lut controls as well? Right now it's both, which I think I like.
There should probably be a margin on either side of the domain range, as right now if a clim is on the edge, it essentially becomes invisible:

[ ] There is a bug around setting logarithmic range where the domain also gets reset to the data extents - this would ideally be fixed before merge.

[ ] In logarithmic range, ideally the axis would scale logarithmically, instead of us computing the base-10 log of each bin height. But vispy doesn't support it (yet)

The only other TODO on my plate right now is increasing test coverage on the PHistogramView implementations and the HistogramController. I think that the API design is looking pretty good right now though!

heads up @gselzer, I pushed my conflict resolution in 102402c to this branch.  the intention wasn't to change anything here, but have a look just in case (and don't forget to pull before making changes)

thank you again, your work here is included in a joint commit in #65


how to push additionnal metrics

Hi,
I appreciate your work, but I was more willing to expand the capability of the "status history" per processor to be able to see usage during a larger timerange than 5 minutes.
Is there any chance that this reporter could expose some metrics from nifi.components.status.repository ?
If not, could you confirm that in order to add new metrics, you just use vanilla pushgateway and use a HTTP post processor within nifi ?
If so, any chance to have a template of such POST ?
Thanks and regards,
Julien

Did you get metrics? i have put nar file inside lib but i didnt get any metrics in pushgateway? can you give me steps how you got it?

Any metrics you got a process group?

Hi,
I appreciate your work, but I was more willing to expand the capability of the "status history" per processor to be able to see usage during a larger timerange than 5 minutes.
Is there any chance that this reporter could expose some metrics from nifi.components.status.repository ?
If not, could you confirm that in order to add new metrics, you just use vanilla pushgateway and use a HTTP post processor within nifi ?
If so, any chance to have a template of such POST ?
Thanks and regards,
Julien

A nifi reporting task is more of a global metrics generator. In our case, this reporter will provide metrics of the underlying jvm and the metrics you can also see in the UI for a process group. If you don't select a process group, you get the global metrics from all together. If you don't want these generic metrics from nifi, but rather some custom ones, you have to do exactly what you proposed. An example would be to use a PostHttp processor or something similar and transmit the metrics directly in the flow.
At the moment the following metrics are available:
public interface MetricNames {

    // Metric Name separator
    String METRIC_NAME_SEPARATOR = ".";

    // NiFi Metrics
    String FLOW_FILES_RECEIVED = "FlowFilesReceivedLast5Minutes";
    String BYTES_RECEIVED = "BytesReceivedLast5Minutes";
    String FLOW_FILES_SENT = "FlowFilesSentLast5Minutes";
    String BYTES_SENT = "BytesSentLast5Minutes";
    String FLOW_FILES_QUEUED = "FlowFilesQueued";
    String BYTES_QUEUED = "BytesQueued";
    String BYTES_READ = "BytesReadLast5Minutes";
    String BYTES_WRITTEN = "BytesWrittenLast5Minutes";
    String ACTIVE_THREADS = "ActiveThreads";
    String TOTAL_TASK_DURATION_SECONDS = "TotalTaskDurationSeconds";
    String TOTAL_TASK_DURATION_NANOS = "TotalTaskDurationNanoSeconds";

    // JVM Metrics
    String JVM_UPTIME = "jvm.uptime";
    String JVM_HEAP_USED = "jvm.heap_used";
    String JVM_HEAP_USAGE = "jvm.heap_usage";
    String JVM_NON_HEAP_USAGE = "jvm.non_heap_usage";
    String JVM_THREAD_STATES_RUNNABLE = "jvm.thread_states.runnable";
    String JVM_THREAD_STATES_BLOCKED = "jvm.thread_states.blocked";
    String JVM_THREAD_STATES_TIMED_WAITING = "jvm.thread_states.timed_waiting";
    String JVM_THREAD_STATES_TERMINATED = "jvm.thread_states.terminated";
    String JVM_THREAD_COUNT = "jvm.thread_count";
    String JVM_DAEMON_THREAD_COUNT = "jvm.daemon_thread_count";
    String JVM_FILE_DESCRIPTOR_USAGE = "jvm.file_descriptor_usage";
    String JVM_GC_RUNS = "jvm.gc.runs";
    String JVM_GC_TIME = "jvm.gc.time";
}

If the metrics you want are part of a process group, you can extract them from ProcessGroupStatus. If you submit a PR we can implement them into the project.

Ok then, there is a problem with the installation process, because I did not have these metrics.
NB: I did not use docker. and used nifi 1.8.0
The only metrics I have are
go_gc_duration_seconds{quantile="0"}
go_gc_duration_seconds{quantile="0.25"}
go_gc_duration_seconds{quantile="0.5"}
go_gc_duration_seconds{quantile="0.75"}
go_gc_duration_seconds{quantile="1"}
go_gc_duration_seconds_sum
go_gc_duration_seconds_count
go_goroutines
go_info{version="go1.11.1"}
go_memstats_alloc_bytes
go_memstats_alloc_bytes_total
go_memstats_buck_hash_sys_bytes
go_memstats_frees_total
go_memstats_gc_cpu_fraction
go_memstats_gc_sys_bytes
go_memstats_heap_alloc_bytes
go_memstats_heap_idle_bytes
go_memstats_heap_inuse_bytes
go_memstats_heap_objects
go_memstats_heap_released_bytes
go_memstats_heap_sys_bytes
go_memstats_last_gc_time_seconds
go_memstats_lookups_total
go_memstats_mallocs_total
go_memstats_mcache_inuse_bytes
go_memstats_mcache_sys_bytes
go_memstats_mspan_inuse_bytes
go_memstats_mspan_sys_bytes
go_memstats_next_gc_bytes
go_memstats_other_sys_bytes
go_memstats_stack_inuse_bytes
go_memstats_stack_sys_bytes
go_memstats_sys_bytes
go_threads
process_cpu_seconds_total
process_max_fds
process_open_fds
process_resident_memory_bytes
process_start_time_seconds
process_virtual_memory_bytes
process_virtual_memory_max_bytes
promhttp_metric_handler_requests_in_flight
promhttp_metric_handler_requests_total{code="200"}
promhttp_metric_handler_requests_total{code="500"}
promhttp_metric_handler_requests_total{code="503"}
pushgateway_build_info{branch="HEAD",goversion="go1.11.1",revision="290ff867b4e55aad161e56786740802779d4de11",version="0.6.0"}


Python: Make top level entrypoint file not depend on the shortname (which could be a hyphenated)

What
I was generating the video-intelligence gapic and the shortname was hyphenated causing an error.

Codecov Report

Merging #1565 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

@@             Coverage Diff              @@
##             master    #1565      +/-   ##
============================================
+ Coverage     87.03%   87.03%   +<.01%
- Complexity     4207     4208       +1
============================================
  Files           408      408
  Lines         16882    16886       +4
  Branches       1834     1835       +1
============================================
+ Hits          14693    14697       +4
+ Misses         1697     1696       -1
- Partials        492      493       +1

Impacted Files
Coverage Δ
Complexity Δ

.../transformer/py/PythonGapicSurfaceTransformer.java
98.23% <87.5%> (-0.42%)
42 <2> (ø)

...ain/java/com/google/api/codegen/util/NamePath.java
90.24% <0%> (+2.43%)
18% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf0648...ce118d1. Read the comment docs.


content: add support for label storage in local content store

Allows us to fully test the content store interface using labels. Right now the behavioral change only effects tests since the label store is optional, however external users of the content store could take advantage of this interface.

Codecov Report

Merging #1663 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   48.92%   48.75%   -0.18%
==========================================
  Files          27       27
  Lines        4080     4080
==========================================
- Hits         1996     1989       -7
- Misses       1668     1672       +4
- Partials      416      419       +3

Impacted Files
Coverage Δ

metadata/snapshot.go
49.34% <0%> (-0.94%)
:arrow_down:

metadata/content.go
31.04% <0%> (-0.48%)
:arrow_down:

metadata/db.go
65.5% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992280e...8c154f0. Read the comment docs.

Should this be generalized to metadata or is there a sidecar label store?

Should this be generalized to metadata or is there a sidecar label store?

The only implementation is for testing the local store.  External users of the local content store can provide a sidecar label store, but we don't need to implement that. The metadata store already stores labels and is the only thing we need for the containerd daemon. If we want to make use of labels for the local content store in the future, we can add an implementation.

Added comment about use of NewLabeledStore as primarily for tests. This change has no functional changes to the content store as used by a container service with a metadata store.

LGTM

LGTM


Lock Workspace

An option to lock a Window workspace (cant make chages to any file, unless uncloked) , so i dont accidently disturb the code when copying a code from one window to another

I think you can get that done via the readonly settings we provide since a few months:


Stop row experiment name from being a toggle

Demo
https://user-images.githubusercontent.com/43496356/188204553-c8815901-533d-444a-8f75-f6a44dc9321f.mov
Part of #2241

Good stuff @julieg18 ! Have you increased the hover area? Can not really see it in the video :)

I still believe it's better to keep the toggle on the text and allow selection. The click target of the bullet might be enough, but it does not look like a toggle in my opinion and I don't think people will purposefully click on it. With the experiment name being in the toggle target, there is a lot more chance for discoverability.

@sroy3, we have no other option than to point the user to how exactly to select the EXPs for plots. This is something that is planned to be done.

there is a lot more chance for discoverability.

I am not sure that accidental discovery is good enough :) We need to. make sure it's intuitive. When we will decide how we handle the EXPs in the side panel this problem also going to be unlocked.

Agree with Stephanie

@mattseddon, my arguments are below.
What: we need to tell the user to add EXP to the Plots view.
How: we have the control that does it. Anything besides it is not clear (unless the user was educated before).
Conclusion: Have a special icon/control that does the job - not a cell or group of elements.
In addition:

We have no other option than to point the user to how exactly to select the EXPs for plots. This is something that is planned to be done.
Use a better symbol (eye). for example. We need to. make sure it's intuitive. When we will decide how we handle the EXPs in the side panel this problem also going to be unlocked.

In addition to the discussion, here is the basic row anatomy as I see it.

I still agree with Stephanie. All of the behaviour should change together. We should not be making it worse in the interim because This is something that is planned to be done. Design/approach has not been agreed.

All of the behaviour should change together.

By sharing the basic row anatomy I just wanted to express my vision. This particular ticked is about removing the toggle from the Name, which covers everything. What is "All of the behaviour"?

We should not be making it worse

Why worse? This is more logical I think https://github.com/iterative/vscode-dvc/pull/2321#issuecomment-1235898740 No? If this is not clear, would you like me to rephrase it?

Design/approach has not been agreed.

@mattseddon, this is a part of #2241
Please review the scope and let me know if there is something that needs to be re-discussed. Thank you!

I also take Matt's and Stephanie side on it. Even though I don't like the current implementation - selection is broken - it's a terrible and a very serious UX bug + it's far from being obvious what it toggles + when you toggle is selects/deselects text. It's really bad.
We should approach a bit more holistically I think (instead of patching it this way and spending time on making special zones to toggle, etc).
We can probably solve this by showing a tooltip on hover with actions + explanation. At least for now.

We can probably solve this by showing a tooltip on hover with actions + explanation. At least for now.

This is already included in the #2241
"Add tooltip: Add/Remove to plots (may be different wording) when the EXP's circle has hovered"


For a given .proto file, gosnappi client and gRPC server in non-go language may not always be compatible

We have hit this issue in multiple instances. Here's the reason why:
Let's take an exampe of otg.proto. The package name is defined as package otg;.

When we generate a C++ server skeleton, without any modification (in package name), we end up generating gRPC skeletons where URLs look like /otg.Openapi/SetConfig
When we generate gosnappi using openapiart, we modify the package name to be used as snappi, moreover openapiart further appends a suffix resulting in package name snappipb resulting in URL that looks like /snappipb.Openapi/SetConfig

This results in an incompatible API call.
There are two solutions that we need to choose from:

Ask any implementor of otg.proto to use snappipb as package name (or any other package name that's relevant to a given project). That's what we currently do for ixia-c gRPC server. https://github.com/open-traffic-generator/otg-grpc/blob/main/do.sh#L30

This may resolve the problem quickly but does not seem like a good solution (because how do we enforce this ?)
e.g. in this case, we didn't enforce this for ixia-c protocol-engine and ultimately we noticed the incompatibility

Modify the generated gRPC skeleton in gosnappi to use original package name in URL. We could also put some other restriction.

@ajbalogh need your input on this.

The otg.proto that is generated and pushed as part of the open-traffic-generator/models repo is considered to be the source of truth with the expectation that protobuf/grpc generation would use that artifact as the input.
The package name is otg not snappi as the snappi name is just a UX package naming convention.
The  build process for snappi should use the otg artifact or generate the same named artifact so that there would be no conflict.
Minor bugs would need to be fixed (copy files, message option extension number declaration).
Am i missing anything?

@ajbalogh that's about it, most probably change will be limited to snappi repo only, so will move this issue to that repo.


"review" chokes on old snapshots in test directory

Steps to reproduce

Create a snapshot like snapshot('audit.txt')
Run test
Rename snapshot like like snapshot('audit.json')
Run test
Now run test with --insta review

Expected behavior
Things work just fie.
Review works as expected or alternatively I am instructed to do some kind of cleanup.
Actual behavior
As audit.txt is still existing in the cache folder the last pytest call fails with an error like this:
FileNotFoundError: [Errno 2] No such file or directory: 'flaskapp/snapshots/views__cm_views__audit.txt'
Running --insta clear fixes the issue.
For new users, this behavior can be quite unexpected. Especially as one might not even remember anymore that a snapshot with the unexpected name once existed.

I managed to reproduce the issue. To fix this I'm going to make the review tool clear recordings that are no longer associated with any snapshot. This should make renaming snapshots completely transparent.

Alright, just released this. Let me know if you encounter any other problem 👍

Perfect, thanks!
 Will tell if anything comes up.


Issue/#147 refactor diagram builder

Hello @ceckoslab
Here is kind of refactoring for DiagramBuilder.php.
It is not ideal but probably it is better than what it was before. There is still room for optimization and refactoring but I am not sure if it's worth it keeping in mind that you currently working on more comprehensive refactoring.
Kindly review it

Hello @korzol
Could you check my comments of the review and fix them or comment if you have different opinion?
Thanks!


Need the ability to read the wishlist

As a customer
I need to get/view my wishlist
So that I can check what is the data that is present in the wishlist
Details and Assumptions
*The server should be up and running
Acceptance Criteria
Given the customer_id
When wishlist exists for the customer_id
Then return all the products that are part of the wishlist for the customer_id

Please add your planning poker estimate with ZenHub @lnv2150


ES-175: remove external publishing for simulator and it's dependencies

Use of the simulator module in CSDE brought in multiple runtime dependencies which over the course of development required us to make several corda-runtime-os jars publicly available.
With the retirement of simulator, this should be corrected.

Remove releasable = true extensions block from these modules, this property signals to our internal publishing gradle plugin to pick up these modules for external publishing.
Remove corda.javadoc-generation from these modules also, which is a BuildSrc plugin that controls JavaDoc generation this was only added as a requirement of Maven Central upload, now that we are no longer externally releasing these modules this can also be removed, this will have an added benefit of less build activity needed on CI runs.

@driessamyn FYI

LGTM ... I find it confusing that all the libs// belong to simulator implicitly ... Or ... maybe they don't and you've removed them as a side effect ?

These were on the transitive dependency graph of the runtime simulator. sue to how dependencies were handle within the simulator module


Add ability to re-attempt auto-funding swap if it failed

When operating multiple swaps, failure to autofund is quite frequent when operating (far) more swaps in parallel than UTXOs available and mostly ephemeral due to

Monero RPC: not enough unlocked money (E needed_money + min_fee > unlocked_balance_subtotal. THROW EXCEPTION: error::not_enough_unlocked_money)
Bitcoin: too many descendants from unconfirmed UTXO (too-long-mempool-chain, too many descendants for tx ... [limit: 25])

We should have the ability to re-attempt autofund whenever the block height gets incremented, but we also should not introduce the risk that the auto-fund does eventually succeed, but the user has already funded manually too (in which case, the swap should cancel in Alice's case, or in Bob's case only lock the amount negotiated).
So if the autofunding fails, user should either explicitly request another attempt, or it should reattempt until user requests auto-funding information, and then autofunding stops.

This is done in #686

#686 addressed failure if monero daemon didn't respond in time.
The cases described in this issue are related to too few mature outputs. I've renamed it to make explicit.
As I described in #686, I'm on the fence whether or not we want auto-funding in this case (slightly leaning towards not). So I'm fine with both keeping it open or closing it.


refactor js into more sensible structure

closes #75

@migurski so I'm implementing the code in #77, it's working for the /metro/ page but is breaking on the index. do you have any idea why this would be happening?


fix(sql lab): SQL Lab access restrictions not applied to default schema

SUMMARY
The schema level restrictions are not working properly in SQL Lab, when the default schema is used. Some DB Engines allow users to execute a query without specifying the Schema, in which default Schema will be queried.
In the permission check, we're assigning the schema from two sources: the query itself, or if it's not present, the schema selected on the left hand side in SQL Lab.
It's the second scenario that's not properly checked, because, if the user has schema permission for the one selected, and if the query can be executed in the engine without specifying the schema explicitly, then the permission check will allow said execution, since there's a permission for the schema.
This PR alters the order of checks, so that we validate that the default schema actually contains the table we're trying to query, and then check the permission on said datasource.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/17252075/172245754-0186181c-5bbb-46cd-8ae5-c104e0d6d965.mov
After:
https://user-images.githubusercontent.com/17252075/172245791-cda848a5-aa53-41ea-a53a-477e0b5a3269.mov
TESTING INSTRUCTIONS

Create a new user role with the following permissions:

can read on SavedQuery
can write on SavedQuery
can read on Database
can read on Query
can sqllab on Superset
can sqllab history on Superset
can sqllab viz on Superset
can sql json on Superset
can sqllab table viz on Superset
can validate sql json on Superset
can activate on TabStateView
can get on TabStateView
can put on TabStateView
can delete query on TabStateView
can post on TabStateView
can delete on TabStateView
menu access on SQL Lab
menu access on SQL Editor
schema access on [examples].[information_schema]

Create a new user and assign the above role to it.
Log in with that user.
Go to SQL Lab
Select examples as database and information_schema as schema

Execute these two queries:
select * from birth_names

select * from public.birth_names

Ensure both fail with a forbidden error.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@eschutho if you wouldn't mind checking/accepting/amending the change requests, that would be much appreciated. Looks like this'll need a little rebase action as well :D

I just checked with @yousoph on whether we should be fetching from the schema in the dropdown when not specified in the sql statement, which we're not doing.

Fixed via https://github.com/apache/superset/pull/23356 I believe (hat tip to @eschutho for the reference)


[ci] verify helm chart can be generated

As part of the CI pipeline, verify that there are no issues generating the helm chart yaml files from the template.
Something along the lines of
helm upgrade -i webhook apm-agent-auto-attach/ --dry-run --debug --namespace=elastic-apm --create-namespace

I haven't followed all the changes in the repo, but this seems outdated. cc @trentm

We do the helm install from main/branch as part of the integration test run against all changes


Add progress bar support to single audio file

When I tried to process only one music, I noticed that the progress bar jumped from 0% directly to 100%. This happened because the progress bar was created based on the number of files.
To address this, I added a progress bar within the two processing functions to display the processing progress of a single audio file. I also set leave=False, so that when processing multiple audio files, the progress of each audio file is displayed without affecting the overall appearance. After testing (using the model model_bs_roformer_ep_368_sdr_12.9628.ckpt), I found that adding the progress bar did not significantly impact processing speed.
Here are some screenshots. The progress bar is updated every second.

Hello. Thank you for commit. But your changes will affect train and valid too. I propose you to create independent functions like "demucs_track_with_pbar()" and place them directly in inference.py. Or change original functions in the way that progress bar is optional.
In current version I can't add your changes.


Security: Create functions for SHA checksums for a file

Create functions
int
pgmoneta_create_sha256_file(char* path, char** sha);

int
pgmoneta_create_sha384_file(char* path, char** sha);

int
pgmoneta_create_sha512_file(char* path, char** sha);

using the OpenSSL API

We likely need one for CRC32C as well...

Hello, I would like to work on this issue.

@shikharish Go for it

@jesperpedersen What is the role pgmoneta_generate_file_sha256_hash() in security.c?

@shikharish It is part of the foundation of https://github.com/pgmoneta/pgmoneta/issues/267

I did not quite get that. Where would pgmoneta_create_sha256_file(char* path, char** sha) be used? In the verify command in #267? Will the implementation be similar to pgmoneta_generate_file_sha256_hash()?

@shikharish Do you have a work branch for this ?

Related #291

@jesperpedersen I had created the functions(similar to the already existing pgmoneta_create_sha256_file(char* path, char** sha), but later realised that the functions used there were deprecated in OpenSSL version 3.0. So I am working on updating it.
Please check my current work here.

You can look here https://www.openssl.org/docs/man3.1/man3/SHA256.html

We just need to support OpenSSL 1.1 and OpenSSL 3.x

@jesperpedersen Don't we need a function for SHA224 as well?

Sure, we can add that as well - just to have the option


fastlane not changing bundle id

I have a beta lane with this info:
cert

pem(generate_p12: true)

sigh(output_path: "./fastlane/profiles",
      force: true) # Distribution Profile

# use the UDID of the newly created provisioning profile
ENV["PROFILE_UDID"] = Actions.lane_context[Actions::SharedValues::SIGH_UDID]

ipa({
  scheme: "MyScheme"
})

The problem is is fails building because it's not changing the bundle identifier, and so it complains that the prov. profile has a different app id than the bundle identifier. I am using Appfile and it has a app_identifier set. Should this just work, or is there any way to force ipa to change the project bundle identifier?

What do you mean it's not changing the bundle identifier? Where should it change the bundle identifier and why?

Nevermind, I thought that it would change the bundle identifier to match the app_identifier, and then I could just change the app_identifier and it would work. I have made a script to do that, so now I don't need it.


PP-4994: Update refund process for fee billing,

Remove refund_application_fee as we do not take application fees
during the capture process
Add the relevant Connect account to the refund metadata, this will
help Support follow the payment trail if required

Required:

[ ] fill in the gatewayTransactionId when a refund is created with the Stripe gateway

Depends on https://github.com/alphagov/pay-connector/pull/1159

Superseded by https://github.com/alphagov/pay-connector/pull/1199 -- refund process updated for net transfer method.


Feature/tclune/mapl3 service service

Description

Changes and tests for service-service.
Note - relies on new ESMF features - requires baselibs update.
Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[ ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[ ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Re-pressed the update branch button. If this works, we can pull it in for @tclune

Uh oh. Conflicts. And they are not simple ones. I think we need @tclune to resolve them.


select2Editor with createSearchChoice initialize value not right

I overload select2Editor.getSelect2Options
        getSelect2Options(): Select2Options {
            let opt = super.getSelect2Options();
            opt.createSearchChoice = data => {
                    return { id: data, text: data }
                };
                opt.createSearchChoicePosition = "bottom";
            }
            return opt;
        }

and ,yes , it works, I can set value not in the lookup list and save it correctly.
but there is still a little pity that when I open the dialog again, the saved value does not show correctly.
as I know nothing about select2 before, I can't figure it out yet, can you give me some advice?
BTW, I try to overload Select2Editor.getCreateSearchChoice function before,
getCreateSearchChoice(getName?: (p1: any) => string): (p1: string) => any {
            return data => {
                 return { id: data, text: data }
            };
        }

it doesn't work at all, I don't know why.

I think I finally find a way to figure it out, just relaod setEditValue function in editor:
public setEditValue(source, prop: Serenity.PropertyItem) {
            let val = source[prop.name] || [];
            if (!Q.isEmptyOrNull(val))
                if (this.options.createSearchChoice//enable createSearchChoice
                    && !this.itemById[val]) {
                    this.element.select2('data', { id: val, text: val });
                }
                else {
                    this.value = val;
                }
        }

The point is this.element.select2('data', { id: val, text: val });


feat: added Boots Viewpoint as hard

You have to email Boots Viewpoint to delete your account. Email address included in entry.

Thanks for your contribution!


[zeus] {foxy} (test-)osrf-testing-tools-cpp: disable branch check with nobranch=1

fixes https://github.com/ros/meta-ros/issues/815

Also in zeus-next:
42009a483..b5ca00cb6  zeus -> zeus-next


[WebToolsE2E][Aspire] Deploying Aspire-Samples/Metrics solution using 'azd up', the status of container app shows failed: ContainerCrashing.

REGRESSION INFO: Also repro on Aspire 8.0.0-preview.3.24105.21
INSTALL STEPS

Clean machine: Win11 x64 23h2 ENU
Install VS 17.10 Preview 2 [ includes Aspire 8.0.0-preview.4.24128.4 ]
Apply NuGet dotnet-tools Feeds
Install Docker Desktop for Windows
Install latest azd

REPRO STEPS

Clone aspire-samples repo from main branch
Checkout the Preview.4 branch
Update sdk version to 8.0.300-preview.24101.10 in global.json
Update Aspire version to latest 8.0.0-preview.4.24128.4 in Directory.Packages.props
Open samples\Metrics.sln
Build
Deploy using azd

Open the solution folder in a Command Prompt
Runing 'azd init', select 'Use code in the current directory' > Confirm and continue initializing my app, type a new environment name, press enter.
When running azd init choose to expose 'app' to the Internet
Run azd up to deploy to Azure

Open the resource group, click the 'app' container app.

ACTUAL:
The status shows failed: Failed:appContainerCrashing:
2024-03-01T10:18:49.18985  Connecting to the container 'app'...
2024-03-01T10:18:49.20481  Successfully Connected to container: 'app' [Revision: 'app--4wf4z1e-55f9b757f8-r55x8', Replica: 'app--4wf4z1e']
2024-03-01T10:14:25.505331382Z          at Microsoft.AspNetCore.Builder.ExceptionHandlerExtensions.<>c__DisplayClass5_0.b__0(RequestDelegate next)
2024-03-01T10:14:25.505333556Z          at Microsoft.AspNetCore.Builder.ApplicationBuilder.Build()
2024-03-01T10:14:25.505335430Z          at Microsoft.AspNetCore.Builder.ApplicationBuilder.Build()
2024-03-01T10:14:25.505337524Z          at Microsoft.AspNetCore.Hosting.GenericWebHostService.StartAsync(CancellationToken cancellationToken)
2024-03-01T10:14:25.505339668Z          at Microsoft.Extensions.Hosting.Internal.Host.b__15_1(IHostedService service, CancellationToken token)
2024-03-01T10:14:25.505351349Z          at Microsoft.Extensions.Hosting.Internal.Host.ForeachService[T](IEnumerable1 services, CancellationToken token, Boolean concurrent, Boolean abortOnFirstException, List1 exceptions, Func3 operation) 2024-03-01T10:14:25.514669806Z Unhandled exception. System.InvalidOperationException: An error occurred when configuring the exception handler middleware. Either the 'ExceptionHandlingPath' or the 'ExceptionHandler' property must be set in 'UseExceptionHandler()'. Alternatively, set one of the aforementioned properties in 'Startup.ConfigureServices' as follows: 'services.AddExceptionHandler(options => { ... });' or configure to generate a 'ProblemDetails' response in 'service.AddProblemDetails()'. 2024-03-01T10:14:25.514679083Z    at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl..ctor(RequestDelegate next, ILoggerFactory loggerFactory, IOptions1 options, DiagnosticListener diagnosticListener, IEnumerable1 exceptionHandlers, IMeterFactory meterFactory, IProblemDetailsService problemDetailsService) 2024-03-01T10:14:25.514683482Z    at Microsoft.AspNetCore.Builder.ExceptionHandlerExtensions.<>c__DisplayClass5_0.<SetExceptionHandlerMiddleware>b__0(RequestDelegate next) 2024-03-01T10:14:25.514687058Z    at Microsoft.AspNetCore.Builder.ApplicationBuilder.Build() 2024-03-01T10:14:25.514692368Z    at Microsoft.AspNetCore.Builder.ApplicationBuilder.Build() 2024-03-01T10:14:25.514695845Z    at Microsoft.AspNetCore.Hosting.GenericWebHostService.StartAsync(CancellationToken cancellationToken) 2024-03-01T10:14:25.514699692Z    at Microsoft.Extensions.Hosting.Internal.Host.<StartAsync>b__15_1(IHostedService service, CancellationToken token) 2024-03-01T10:14:25.514704010Z    at Microsoft.Extensions.Hosting.Internal.Host.ForeachService[T](IEnumerable1 services, CancellationToken token, Boolean concurrent, Boolean abortOnFirstException, List1 exceptions, Func3 operation)
2024-03-01T10:14:25.514708458Z    at Microsoft.Extensions.Hosting.Internal.Host.StartAsync(CancellationToken cancellationToken)
2024-03-01T10:14:25.514712145Z    at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
2024-03-01T10:14:25.514715752Z    at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
2024-03-01T10:14:25.514719278Z    at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
2024-03-01T10:14:25.514723346Z    at Program.$(String[] args) in C:\Users\v-sherryfan\source\repos\aspire-samples\samples\Metrics\MetricsApp\Program.cs:line 47
2024-03-01T10:14:25.514727984Z    at Program.(String[] args)

Note

Blocked by bug #3421 on Aspire 8.0.0-preview.3.24105.21
This issue can also be reproduced using VS deployment

EXPECTED
No issues

This sample is not supported for preview4:
Aspire does not support deploying container volumes to azd yet.
Closing this as expected-behavior.


Error when adding markers to map

Hello,
I integrated you very nice plugin to my Vaadin Application.
When I'm adding markers to the map, I get the attached error. The strange thing is, when I'm refresh the browser after getting the error it works.
Please let me know, If you need more informations.
Best regards,
Johannes

Any news? we had the exact same issue...

Hi magnusahlden,
I solved the problem by adding the markers after loading the page. A very ugly solutions, but it works.
`
// Start Polling when attaching this component
addAttachListener(attachEvent ->
{
if (pollListener.get()==null)
{
UI.getCurrent().setPollInterval(5000);
			Registration registration = UI.getCurrent().addPollListener(pollEvent -> {

// ADD OR UPDATE MARKERS HERE
});
			pollListener.set(registration);
		}
	});

	// Stop Polling when detaching this component
	addDetachListener(detachEvent ->
	{
		if (pollListener.get()!=null)
		{
			UI.getCurrent().setPollInterval(-1);

			pollListener.get().remove();
			pollListener.set(null);
		}
	});

`


unsupported architectures?

Recent release of rkt FTBFS on several architectures in Debian as follows:
configure: error: *** unsupported host architecture specified

Shouldn't it be a warning instead of fatal error?
Is there a strong enough reason to abort build on architectures where all build dependencies are satisfied? In any case is seems utterly wrong to exclude x86_32.
Affected architectures are armel, armhf, ppc64el, ppc64 and i386 (a.k.a. "i686") !!!.

I think the configure check can be changed to check if RKT_STAGE1_FLAVORS does not include kvm or coreos and if so, then set GOARCH to the correct value and set RKT_ACI_ARCH to something invalid.

This came as a by-product of arm64 support, where there was a need to bridge between golang and appc-spec usage of different labels (aarch64/arm64).
As not much changed compared to before (we still officially support amd64 and arm64, but acknowledge it should run everywhere else too) I think it is ok to introduce those kind of label bridging where we know about it (eg. x86) and turn the default behavior in a warning case where we set         "RKT_ACI_ARCH=GOARCH=host_cpu".
@onlyjob @glevand (or anybody else) interested in picking up this?

@onlyjob I see that MIPS is failing also.  MIPS is now supported by the go compiler, so could you get that fixed, or at least create a Debian bug report for it?
rkt build-depends on missing:
- mips64el:golang-go

@lucab I'll make a patch for configure.ac.

@glevand Debian bug for golang MIPS support is at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815998

@onlyjob @glevand (or anybody else) interested in brining up a patch doing this?

Don't count on me: I have neither skills nor time to produce valid fix to this problem. :(


Ionic 2 RC1: Loading dismissOnPageChange & ionViewDidLoad

Short description of the problem:
Creating a Loading via LoadingController with dismissOnPageChange: true on ionViewDidLoad(). The Loading will be dismissed on its own.
What behavior are you expecting?
I expect that when I create a Loading  on ionViewDidLoad(), it will continue open until I explicitly dismiss it or there is a page change (ionViewDidLoad should not trigger a page change).
Steps to reproduce:

In ionViewDidLoad() method
Create Loading via:
this.loginLoading = this.loadingController.create({         dismissOnPageChange: true  });
Loading closes on its own (if I remove dismissOnPageChange it stays opened).

`
Which Ionic Version?
2 RC.1
Run ionic info from terminal/cmd prompt:
Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.36
OS: Windows 8.1
Node Version: v4.4.7

Hello, thanks for opening an issue with us! Creating and opening components should actually be done in ionViewDidEnter and not ionViewDidLoad. The dom is not guaranteed to be ready in ionViewDidLoad and events are not guaranteed to be ready.

Sorry for the late response.
Tried it with ionViewDidEnter, exactly same behavior than ionViewDidLoad.... the loading modal still closes without a dismiss command (when dismissOnPageChange: true)

Same problem here. I tried with ionViewDidEnter and the loading is dismissed on its own. Any tipo for this?


functorch.grad slower than torch.autograd.grad

functorch.grad appears to be almost 2.5 times slower than torch.autograd.grad in my simple test below. Is this expected?
import timeit
import torch
import functorch

def test_func(z):
    return (z ** 2).sum()

def pytorch_grad(x):
    x.requires_grad_(True)
    return torch.autograd.grad(test_func(x), x)[0]

functorch_grad = functorch.grad(test_func)
z = torch.rand((2, ))

assert torch.allclose(functorch_grad(z), pytorch_grad(z))

%timeit functorch_grad(z) # 125 µs ± 369 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)
%timeit pytorch_grad(z) # 51.9 µs ± 531 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)

Versions
Collecting environment information...
PyTorch version: 1.13.0
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 12.6.1 (x86_64)
GCC version: Could not collect
Clang version: 14.0.0 (clang-14<IP_ADDRESS>)
CMake version: Could not collect
Libc version: N/A

Python version: 3.8.15 (default, Nov 24 2022, 09:04:07)  [Clang 14.0.6 ] (64-bit runtime)
Python platform: macOS-10.16-x86_64-i386-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

Versions of relevant libraries:
[pip3] mypy-extensions==0.4.3
[pip3] numpy==1.23.5
[pip3] pytorch-lightning==1.8.4.post0
[pip3] torch==1.13.0
[pip3] torchmetrics==0.11.0
[conda] numpy                     1.23.5                   pypi_0    pypi
[conda] pytorch-lightning         1.8.4.post0              pypi_0    pypi
[conda] torch                     1.13.0                   pypi_0    pypi
[conda] torchmetrics              0.11.0                   pypi_0    pypi

There is overhead associated with functorch.grad, so yes, it's expected that functorch.grad (by itself) is slower than autograd. The overhead is less noticeable the larger the program is. It is necessary because one can arbitrarily nest functorch.grad with other function transforms (like vmap), but one is not able to do the same with torch.autograd.grad.
Is the overhead a problem for you? There is likely some low-hanging fruit we can do to cut some of the overhead and it's on our roadmap to ensure that the upcoming torch.compile feature helps cut overhead of functorch transforms.

Thanks, I did look into the source code after posting this issue and realized that the behavior could be due to the additional bookkeeping. I am curious to know which bookkeeping operations slow things down though.
My use case was mainly the cleanliness of code provided by functorch API but I guess something similar could be achieved by writing a wrapping function over torch.autograd.grad.

If you're interested, https://docs.google.com/document/d/14qyaa3xIjmVxYiMLlIlQErunYgR_uR1WupsKMZlnGY4/edit# goes over the design (but it might assume knowledge about how PyTorch internals work). That and other information is linked over at the PyTorch Wiki for the curious (https://github.com/pytorch/pytorch/wiki/Core-Frontend-Onboarding)

Thank you!


[DataStorage] Build configuration files dynamically

Configuration files(configuration.toml and datastorage-device.yaml) are generated automatically
if the SERVICE environment variable contains DataStorage
Name in configuration files would be set to datastorage-{deviceID}

Signed-off-by: Taewan Kim<EMAIL_ADDRESS>Description
Fixes #302
Related to #306
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

Delete configuration files in /var/edge-orchestration/datastorage/
Run edge-orchestration with SERVICE environment variable.

$ docker run -it --rm --privileged --network="host" --name edge-orchestration -e SERVICE=DataStorage -v /var/edge-orchestration/:/var/edge-orchestration/:rw -v /var/run/docker.sock:/var/run/docker.sock:rw -v /proc/:/process/:ro edge-orchestration:coconut

Check the device profile from edgex-core-metadata from a web browser
ex) http://localhost:48081/api/v1/deviceprofile

RESULT

Test Configuration:

Firmware version: Ubuntu 20.04
Hardware: x86-64
Edge Orchestration Release: Coconut

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@suresh-lc PTAL! 😄

Since toml and yaml are being programmatically generated, how can a device manufacture add his own device configuration definition. Any thought process of supporting it in future. Or do we think we should only support the 6 pre-defined data types.

Since toml and yaml are being programmatically generated, how can a device manufacture add his own device configuration definition. Any thought process of supporting it in future.

As you pointed out, this PR is the initial source code and there is little way to configure it in terms of device manufacturers. It would be nice to implement source code to support your idea.

Or do we think we should only support the 6 pre-defined data types.

Yes. This is where we are. We can extend supporting data types! Please contribute ideas and source code!

Since toml and yaml are being programmatically generated, how can a device manufacture add his own device configuration definition. Any thought process of supporting it in future.

As you pointed out, this PR is the initial source code and there is little way to configure it in terms of device manufacturers. It would be nice to implement source code to support your idea.

Or do we think we should only support the 6 pre-defined data types.

Yes. This is where we are. We can extend supporting data types! Please contribute ideas and source code!

Might be we capture these in the issue to say we start off with 6 data types. Sure will contribute towards the idea and code.


pickatime issue with default value and view value

I am using a default value on the timepicker which i set with "select" and "view". I am setting this everytime the value changes.
My problem is that when i click on the timepicker the options list is not scrolling to the view value, but instead at the top.
If i the click a value in the options list myself an open it again it works fine. I have tried to also just hardcode the view value. Still only works on manually selecting a value from the options list.
I have tried afterwards to log get('view'), and it contains my provided value
My code looks like this:
element.pickatime('picker').set('select', totalMins);   element.pickatime('picker').set('view', [15,30]);

I have also tried to use render() on moving it to onOpen. Still with no success

@mikkelbergsoerensen It happened to me as well, I solved it by correct CSS. I found that if the linked stylesheet is disabled everything worked fine. Then I reenabled it and found the source of trouble.
For me it was .picker__holder{ display:none }, which I changed to display:inherit (or can simply remove). Secondly, .picker__list shouldn't have max height property, instead I removed from this class anything regarding to height and put the height into following:
.picker--time.picker--opened .picker__holder { max-height: 250 px; }

@trendoman thanks for your reply. I tried your suggestion and it unfortunately did nothing for me. I do not think it is  a css issue, because the view value actually works. You just have to click a value manaully in the timepicker one time. If you set default value through javascript with set "select and view" then it does not work, at least for me.

Perhaps data-value attribute can do the job better. $(element).data('value', '15:30'); Set this before init of timepicker and time should get selected.

I am not having trouble with the value. I only have problems with the scroll position of the overlay when setting the value and view from javascript. Im using the timepicker on an angular solution where i have made a directive for it. So i have a scope value that i can manipulate and then litsten for changes and then update the timepicker. This is where it goes wrong. (but only a problem with the scroll position)

@mikkelbergsoerensen  any success on this ?

@usmanlogin well, this was 2 years ago - I do not think that the person still knows how it was solved if it was solved.

you're right, but no one forgets the hard time :-P

Here is a workaround I found:
		$('.-timepicker').pickatime({ 			defaultTime: get_nearest_quarter_hour(), 			interval: 15, 			onOpen: (function () { 				var $pickerHolder = this.$holder.find(".picker__list"), 				$viewset = $pickerHolder.find('.picker__list-item--highlighted'); 				this.$holder.scrollTop(($viewset.index() - 3) * $viewset.outerHeight()); 			}) 		});
where get_nearest_quarter_hour() was necessary for my implementation but may not for yours
`
function get_nearest_quarter_hour() {
var date = new Date();
// Getting minutes
var mins = date.getMinutes();
    // Getting hours
    var hrs = date.getHours();
    var m = (Math.round(mins/15) * 15) % 60;

    // Converting '09:0' to '09:00'
    m = m < 10 ? '0' + m : m;
    var h = mins > 52 ? (hrs === 23 ? 0 : ++hrs) : hrs;

    // Converting '9:00' to '09:00'
    h = h < 10 ? '0' + h : h;
    return h + ":" + m;
}

`

$('.timepicker').pickatime({
defaultTime: get_nearest_quarter_hour(),
interval: 15,
onOpen: (function () {
var $pickerHolder = this.$holder.find(".picker__list"),
$viewset = $pickerHolder.find('.picker__list-item--highlighted');
this.$holder.scrollTop(($viewset.index() - 3) * $viewset.outerHeight());
})
});
function get_nearest_quarter_hour() {
var date = new Date();
var mins = date.getMinutes();

var hrs = date.getHours();
var m = (Math.round(mins/15) * 15) % 60;

m = m < 10 ? '0' + m : m;
var h = mins > 52 ? (hrs === 23 ? 0 : ++hrs) : hrs;

h = h < 10 ? '0' + h : h;
return h + ":" + m;

}

sorry about the shitty formatting couldnt get it to work.

I've updated the comment and added code fences (three backticks).


Godot can't create device on GTX 1060 (Laptop)

Godot version
master - eb318d3e04ac6d3bb01b0f2a8311d06ba55c3a2b
System information
Windows 10
Issue description
Godot can't create Vulkan device on this hardware. I'm checking drivers to see if this is a local issue but reporting this as to not loose the log and just in case someone else has run into this too :)
See following startup log:
Godot Engine v4.0.dev.custom_build.eb318d3e0 - https://godotengine.org
Vulkan API 1.2.162
WARNING: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
        ReadDataFilesInRegistry: Registry lookup failed to get layer manifest files.
        Objects - 1
                Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle<PHONE_NUMBER>616
     at: VulkanContext::_debug_messenger_callback (drivers\vulkan\vulkan_context.cpp:154)
Using Vulkan Device #1: NVIDIA - GeForce GTX 1060
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE, STAGE_RAYGEN_KHR, STAGE_ANY_HIT_KHR, STAGE_CLOSEST_HIT_KHR, STAGE_MISS_KHR, STAGE_INTERSECTION_KHR, STAGE_CALLABLE_KHR
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages
ERROR: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
        terminator_CreateDevice: Failed in ICD C:\WINDOWS\System32\DriverStore\FileRepository\nvcvi.inf_amd64_8248dd6d7254db0c\.\nvoglv64.dll vkCreateDevicecall
        Objects - 1
                Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle<PHONE_NUMBER>616
   at: VulkanContext::_debug_messenger_callback (drivers\vulkan\vulkan_context.cpp:157)
ERROR: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
        vkCreateDevice:  Failed to create device chain.
        Objects - 1
                Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle<PHONE_NUMBER>616
   at: VulkanContext::_debug_messenger_callback (drivers\vulkan\vulkan_context.cpp:157)
ERROR: Condition "err" is true. Returning: ERR_CANT_CREATE
   at: VulkanContext::_create_device (drivers\vulkan\vulkan_context.cpp:1011)
CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] vkGetDeviceProcAddr (D:\Godot\godot4-git\thirdparty\vulkan\loader\trampoline.c:88)
[1] VulkanContext::_initialize_queues (D:\Godot\godot4-git\drivers\vulkan\vulkan_context.cpp:1074)
[2] VulkanContext::_window_create (D:\Godot\godot4-git\drivers\vulkan\vulkan_context.cpp:1200)
[3] VulkanContextWindows::window_create (D:\Godot\godot4-git\platform\windows\vulkan_context_win.cpp:50)
[4] DisplayServerWindows::_create_window (D:\Godot\godot4-git\platform\windows\display_server_windows.cpp:3033)
[5] DisplayServerWindows::DisplayServerWindows (D:\Godot\godot4-git\platform\windows\display_server_windows.cpp:3289)
[6] DisplayServerWindows::create_func (D:\Godot\godot4-git\platform\windows\display_server_windows.cpp:3351)
[7] Main::setup2 (D:\Godot\godot4-git\main\main.cpp:1553)
[8] Main::setup (D:\Godot\godot4-git\main\main.cpp:1405)
[9] widechar_main (D:\Godot\godot4-git\platform\windows\godot_windows.cpp:153)
[10] _main (D:\Godot\godot4-git\platform\windows\godot_windows.cpp:187)
[11] main (D:\Godot\godot4-git\platform\windows\godot_windows.cpp:199)
[12] __scrt_common_main_seh (d:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[13] BaseThreadInitThunk
-- END OF BACKTRACE --

Steps to reproduce
Just compile Godot and start :)
Minimal reproduction project
n/a

Strange, I have Windows 10 / GTX 1060 and it runs correctly - however, I have a PC instead of a laptop

There's also #49656 for someone else having an issue w/a laptop GPU(765M) but their backtrace doesn't mention creating device. Unless the recent pull request Fix Context Validation Layer Errors changed it?

Yeah it was a friggen driver issue... Geforce had stopped updating and for some reason whenever NVidea releases a new driver the old one mysteriously breaks..

Can we handle the init failure gracefully to prevent the segfault, and throw an explicit error instead?

I got a similar stacktrace on 4.0.3 Linux. I was running Godot and SimpleScreenRecorder (I don't remember if I was actively recording). I moved/resized the editor window, and Godot slowed down, then hung for ~10s. After that, I got a crash in the console, but the editor appeared to keep running. I closed the editor, and now every time I try to reopen it crashes with this stacktrace. My driver versions should not have changed between when it was working and not (it happened all within the same boot, and I didn't upgrade during that time).
Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 3080
ERROR: Condition "err" is true. Returning: ERR_CANT_CREATE
   at: _create_device (drivers/vulkan/vulkan_context.cpp:1476)

Thread 1 "godot.linuxbsd." received signal SIGSEGV, Segmentation fault.
vkGetDeviceProcAddr (pName=0x55555ad45f11 "vkCreateSwapchainKHR", device=0x0) at /usr/src/debug/vulkan-icd-loader/Vulkan-Loader-1.3.255/loader/trampoline.c:133
Downloading source file /usr/src/debug/vulkan-icd-loader/Vulkan-Loader-1.3.255/loader/trampoline.c
133         const VkLayerDispatchTable *disp_table = *(VkLayerDispatchTable **)device;
(gdb) bt
#0  vkGetDeviceProcAddr (pName=0x55555ad45f11 "vkCreateSwapchainKHR", device=0x0) at /usr/src/debug/vulkan-icd-loader/Vulkan-Loader-1.3.255/loader/trampoline.c:133
#1  vkGetDeviceProcAddr (device=0x0, pName=0x55555ad45f11 "vkCreateSwapchainKHR") at /usr/include/vulkan/vulkan_core.h:4089
#2  0x00005555571b1feb in VulkanContext::_initialize_queues (this=this@entry=0x55555d7ebd10, p_surface=p_surface@entry=0x55555d9682e0) at drivers/vulkan/vulkan_context.cpp:1540
#3  0x00005555571be193 in VulkanContext::_window_create (this=0x55555d7ebd10, p_window_id=<optimized out>, p_vsync_mode=DisplayServer::VSYNC_ENABLED, p_surface=<optimized out>, p_width=1152, p_height=648) at drivers/vulkan/vulkan_context.cpp:1688
#4  0x000055555619a5bd in VulkanContextX11::window_create (this=0x55555d7ebd10, p_window_id=p_window_id@entry=0, p_vsync_mode=p_vsync_mode@entry=DisplayServer::VSYNC_ENABLED, p_window=<optimized out>, p_display=<optimized out>, p_width=p_width@entry=1152, p_height=648)
    at platform/linuxbsd/x11/vulkan_context_x11.cpp:56
#5  0x000055555616f602 in DisplayServerX11::_create_window (this=this@entry=0x55555d799920, p_mode=p_mode@entry=DisplayServer::WINDOW_MODE_MAXIMIZED, p_vsync_mode=p_vsync_mode@entry=DisplayServer::VSYNC_ENABLED, p_flags=p_flags@entry=0, p_rect=...)
    at platform/linuxbsd/x11/display_server_x11.cpp:5144
#6  0x00005555561707fd in DisplayServerX11::DisplayServerX11 (this=0x55555d799920, p_rendering_driver=..., p_mode=<optimized out>, p_vsync_mode=<optimized out>, p_flags=0, p_position=<optimized out>, p_resolution=..., p_screen=<optimized out>, r_error=<optimized out>)
    at platform/linuxbsd/x11/display_server_x11.cpp:5551
#7  0x0000555556171b6b in DisplayServerX11::create_func (p_rendering_driver=..., p_mode=DisplayServer::WINDOW_MODE_MAXIMIZED, p_vsync_mode=DisplayServer::VSYNC_ENABLED, p_flags=0, p_position=0x0, p_resolution=..., p_screen=-2, r_error=@0x7fffffffd2f0: OK)
    at platform/linuxbsd/x11/display_server_x11.cpp:4845
#8  0x00005555561b3c45 in Main::setup2 (p_main_tid_override=p_main_tid_override@entry=0) at main/main.cpp:2001
#9  0x00005555561bbe94 in Main::setup (execpath=0x7fffffffde54 "/home/rcorre/src/godot/godot/bin/godot.linuxbsd.editor.x86_64", argc=argc@entry=1, argv=argv@entry=0x7fffffffdb30, p_second_phase=p_second_phase@entry=true) at main/main.cpp:1879
#10 0x00005555561399eb in main (argc=2, argv=0x7fffffffdb28) at platform/linuxbsd/godot_linuxbsd.cpp:61


nestedSignal utility

A function used in a computed that allows a signal to be created  inside of it, but not recreated after it the first time so it's state isn't lost.
Essentially it will create a scope that checks if the signal was created and creates the signal.  The first param would be the signal and the other params will be the signal's params.

Here was a first attempt at the code, but it didn't really make sense.
Issue 1: A variable is needed that gets the current context the signal is in.  This is probably getActiveConsumer(). I don't know if this is available in Angular 16.
Issue 2: how are multiple calls distinguished?  An anonymous function would be the best, but it would be hard to distinguish from a signal, and what if somebody tries to reuse the same one more than once for some reason?
export function nestedSignal<V extends (...args: never[]) => Signal<unknown>>(fn: V, ...params: Parameters<V>): () => ReturnType<V> {
  let isReady = false;
  let source: ReturnType<V>;
  return () => {
    if (isReady) {
      return source;
    }
    source = fn.apply(fn, params) as ReturnType<V>;
    isReady = true;
    return source;
  };
}

There are too many questions and the juice isn't worth the squeeze.  Closing.


Notifications update sporadically

One user reported that they didn't get any notifications for stories they got comments on. When I left a test comment, they got all notifications for previous comments, but there wasn't a notification for the new comment.
Test comment was on
https://offprint.net/prose/6bzlrBWrg/the-birthday-cake

this should no longer happen, but we'll wait and see

i haven't seen any issue with notifications not popping when they're supposed to, so i'll consider this issue closed


Fix "similar-code" issue in pysendyit/errors.py

Similar blocks of code found in 7 locations. Consider refactoring.
https://codeclimate.com/github/0x6f736f646f/sendyit-python/pysendyit/errors.py#issue_5ecb01f11af5890001000022

#23 👍


Update ci.yml

Thanks for the contribution @ilyabrin! CI run seems to be failing with your change.

@vjgarciag96 let's re-run CI with new action params and see whats happen 🚀


Portal connectivity sould be based on biome

Currently, when a player enters a Nectere portal, they're just teleported to the same location, at the top of generated terrain, in the exit dimension.
The goal is to have each biome in the Nectere dimension have a different coordinate multiplier. Nectere portals should generate at the corresponding locations based on the Nectere-side biome-based coordinate multiplier.

I was looking into doing this with StructureFeatures alone, but it seems that is not possible because they do not have access to other dimensions when determining where to generate.
The current plan is to have a regular feature generate BlockEntities that check the correct conditions and then replace themselves with a portal in both the Nectere and non-Nectere dimension.

This is related to #7.

I found another way to do this which essentially just uses regular Features when not in the Nectere dimension, then using a Decorator that can calculate the position of a portal in the Nectere dimension and place the portal Feature in the non-Nectere dimension accordingly.


How to run examples in Regent

I installed legion/regent-lang as the tutorial told but failed to run the examples. I switched from master to stable branch. The failure is still there.
$ ./regent.py examples/stencil.rg
Expected must be checked before access or destruction.
Expected value was in success state. (Note: Expected values in success mode must still be checked prior to being destroyed).
$ echo $?
250
Do not know what happened inside regent-lang. Thanks in advance for your advice!

It looks like you build (or downloaded) a copy of LLVM with assertions enabled. This is an known issue with Terra. If you need to build your own LLVM, you can do so via the instructions here: https://github.com/terralang/terra#instructions-for-building-llvm-from-source

Closing due to inactivity.  @hailijuan please feel free to reopen the issue if you're still seeing a problem.


Migrate Marketplace listing cards on overview page to shadcn/tailwind

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR primarily focuses on updating the styling and structure of components in the MarketplaceDetails and ListingCards sections, replacing certain components with new ones and enhancing the layout.
Detailed summary

Changed rounded-xl to rounded-lg in nft-media.tsx.
Replaced TrackedLink with TrackedLinkTW in MarketplaceDetails.tsx.
Removed unused imports from MarketplaceDetails.tsx.
Updated layout in ListingCards with a new grid structure.
Enhanced Skeleton components with SkeletonContainer for better loading states.
Improved styling and structure of listing items.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5041  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on  Graphite


Exempt Approved Users function works in reverse

Approved users are checked if option is turned on, and ignored if turned off, which is the reverse of what should happen.

Wasn't actually a defect, closing.