az acr login - not working on windows server 1803

Describe the bug
When trying to perform login to ACR from Azure CLI on MS Windows Server 1803 nothing happens.
az acr login -n
To Reproduce
Install Azure CLI on MS Windows Server 1803 and try to login to ACR - Nothing Happens
Try to push image to repositry  <docker push /: - will return error docker : unauthorized: authentication required
Expected behavior
az acr login -n  - should return "Login Succeeded"
Environment summary
OS:
MS Windows Server 1803
Docker Version:
Docker version 18.06.0-ce, build 0ffa825
Azure CLI version:
azure-cli (2.0.43)
acr (2.1.2)
acs (2.2.2)
advisor (0.6.0)
ams (0.2.1)
appservice (0.2.1)
backup (1.2.0)
batch (3.3.1)
batchai (0.4.0)
billing (0.2.0)
cdn (0.1.0)
cloud (2.1.0)
cognitiveservices (0.2.0)
command-modules-nspkg (2.0.2)
configure (2.0.18)
consumption (0.4.0)
container (0.3.2)
core (2.0.43)
cosmosdb (0.2.0)
dla (0.2.0)
dls (0.1.0)
dms (0.1.0)
eventgrid (0.2.0)
eventhubs (0.2.1)
extension (0.2.1)
feedback (2.1.4)
find (0.2.12)
interactive (0.3.27)
iot (0.2.0)
keyvault (2.2.1)
lab (0.1.0)
maps (0.3.1)
monitor (0.2.1)
network (2.2.2)
nspkg (3.0.3)
policyinsights (0.1.0)
profile (2.1.1)
rdbms (0.3.0)
redis (0.3.0)
reservations (0.3.1)
resource (2.1.1)
role (2.1.2)
search (0.1.0)
servicebus (0.2.1)
servicefabric (0.1.0)
sql (2.1.1)
storage (2.1.1)
vm (2.2.0)
Additional context
Flow is working on MS Windows 10 with same account

Any news, It's possible to workaround it with "docker login", but I would like to updates on this.

@djyou

A lot of the login paths have been refactored. Consider closing due to inactivity and potentially not an issue unless there is a response.

Closing. Please reopen if still experiencing this issue.


Option for detecting f strings.

Issue Report Checklist

[x] Searched the issues page for similar reports

Enhancement proposal
Hello,
It would be nice to have an option in Spyder which, when turned on, detect when '{' or '}' are written in string. It would then add a 'f' in front of the string in order to set up a formatted string.
Hope to see this feature in Spyder one day.
Thanks for your amazing work !

Thanks for reporting. We'll take a look at this in a future release.

@ccordoba12 Isn't adding new substantive enhancements now frozen after 3.3.0? Or has that changed?

@dalthviz, please work on this one.

Hi,
I'm currently using Spyder version 4.2.1 and I noticed f-strings are not supported.
More specifically, there is not syntax highlighting in the editor, see screen capture below:

Compared to atom:

Is this feature coming to future versions ?

I am using Spyder 5.2.1 and f-strings are still not highlighted in editor.
For example code:
classname = "title"
html1 = f'''
Hello, world!
'''
classname = ["title","title-default"]
html2 = f'''
Hello, world!
'''

could look something like:

Instead it's all green as mentioned in previous comments.
Example code is valid python3.6:
>>> html1
'
Hello, world!
'
>>> html2
'
Hello, world!
'

This functionality will come in Spyder 6 because it requires that we integrate with a new syntax highlighting library.


PytorchStreamReader failed reading zip archive: failed finding central directory

how to figure it?
find model: /root/ComfyUI/models/insightface/models/antelopev2/scrfd_10g_bnkps.onnx detection [1, 3, '?', '?'] 127.5 128.0
set det-size: (640, 640)
ERROR:root:!!! Exception during processing !!!
ERROR:root:Traceback (most recent call last):
File "/root/ComfyUI/execution.py", line 152, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/root/ComfyUI/execution.py", line 82, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/root/ComfyUI/execution.py", line 75, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/root/ComfyUI/custom_nodes/comfyui-instantId-faceswap/node.py", line 195, in create_pipeline
pipe.load_ip_adapter_instantid(ipadapter)
File "/root/ComfyUI/custom_nodes/comfyui-instantId-faceswap/pipeline_stable_diffusion_xl_instantid_inpaint.py", line 70, in load_ip_adapter_instantid
self.set_image_proj_model(model_ckpt, image_emb_dim, num_tokens)
File "/root/ComfyUI/custom_nodes/comfyui-instantId-faceswap/pipeline_stable_diffusion_xl_instantid_inpaint.py", line 89, in set_image_proj_model
state_dict = torch.load(model_ckpt, map_location="cpu")
File "/root/miniconda3/lib/python3.10/site-packages/torch/serialization.py", line 993, in load
with _open_zipfile_reader(opened_file) as opened_zipfile:
File "/root/miniconda3/lib/python3.10/site-packages/torch/serialization.py", line 447, in init
super().init(torch._C.PyTorchFileReader(name_or_buffer))
RuntimeError: PytorchStreamReader failed reading zip archive: failed finding central directory

Did you download the correct ipadapter from readme and put it into the right place?
If so then you have to also select it in the loading node

Did you download the correct ipadapter from readme and put it into the right place? If so then you have to also select it in the loading node

thx, the model downloaded earlier was damaged, and it can be used after re-download


Fix one color

Hi there!
Firstly, THANK YOU for making such a beautiful software.
My doubt is can we make lolcat to have fixed colour of our choice, instead of picking up random colours?
Actually, I like one particular combination. So it would be nice enough to see only that one.
Thanks again

Yeah, by example, use only lighting colours, like as blue, yellow, green, and white. The pink and red color is very dark.

Try cal | lolcat -S 123.
With the number after -S you pick a specific rainbow. Otherwise lolcat picks at random.

ls -lah | lolcat -S 123 show a dark colors like as violet but need only light green, yellow and light blue.

Try other numbers than 123, too. 🪄


Panic 'invalid character '<' looking for beginning of value'

Here is the thing:

mosinting  28% |██████████████████████████                                                                   | (28/100, 8 it/s) [3s:8s]panic: invalid character '<' looking for beginning of value

goroutine 1 [running]:
main/modules.doRequest({0xc0000263c0, 0x49}, {0xa64ddc, 0x6})
	/home/x/tools/mosint/modules/ThreatCrowd.go:28 +0x670
main/modules.RelatedEmails({0x7ffd138353e8?, 0x12?})
	/home/x/tools/mosint/modules/ThreatCrowd.go:56 +0x65
main.main()
	/home/x/tools/mosint/main.go:261 +0xbcd
exit status 2

It is about the ThreatCrowd API. They are returning 504 when you try to get any report. There are no status code checks in the code.

Can you check if this fixes your problem? @d0znpp

yes, now it's OK!

I have same issue, can some explain me how to fix the problem


Daemonize SIAZ

I would like SIAZ to be able to be run as a daemon, to enable tighter timing than cron or systemd can typically provide, as well as to enable additional capabilities that I want to add later on.

This is implemented.
Automatically senses if it is being run by systemd, but can also be forced into daemon mode by using the --daemonize command line argument or setting Daemonize to true in configuration.


Restructure OpenAPI client generation

Description:
$Subject
Describe your task(s)
This is used in both contract first and code first. Additionally, this is heavily used in connector implementation efforts as well. Therefore, this is the feature that is mostly used. Following is the component diagram for this feature.

[ ] Refactor server URL implementation
[ ] Refactor Auth generator
[ ] Refactor Path parameter
[ ] Refactor Query parameter
[ ] Refactor Header generator
[ ] Refactor Request Body generator
[ ] Refactor Response generator
[ ] Refactor body generator

Close this issue with the favour of this PR https://github.com/ballerina-platform/openapi-tools/pull/1668


400 error after google sign in

Happens only for some users:
10:38:02.574 [error] Cowboy returned 400 because it was unable to parse the request headers.

This may happen because there are no headers, or there are too many headers
or the header name or value are too large (such as a large cookie).

You can customize those values when configuring your http/https
server. The configuration option and default values are shown below:

    protocol_options: [
      max_header_name_length: 64,
      max_header_value_length: 4096,
      max_headers: 100,
      max_request_line_length: 8096
    ]

Cowboy 2 defaults are higher: max_request_line_length -> 8000. https://ninenines.eu/docs/en/cowboy/2.4/manual/cowboy_http/


Interpolation in options.0.option_settings.value causes error

See comment here
Passing an interpolated value to the value field of option_settings causes an error:
options = [
    {
      option_name = "SQLSERVER_BACKUP_RESTORE"

      option_settings = [
        {
          name  = "IAM_ROLE_ARN"
          value = "${module.iam.rds_s3_integration_role_arn}"
        },
      ]
    },
  ]

Error: module.bike_db.module.db_option_group.aws_db_option_group.this: "option.0.option_name": required field is not set
Passing a hardcoded ARN removes the problem.

Can confirm this in 0.11, I also have this issue. Setting a fix ARN would solve this, but of course i need to use interpolation.
So this works:
  options = [
    {
      option_name = "SQLSERVER_BACKUP_RESTORE"

      option_settings = [
        {
          name  = "IAM_ROLE_ARN"
          value = "hardcoded ARN"
        },
      ]
    },
  ]

This not:
  options = [
    {
      option_name = "SQLSERVER_BACKUP_RESTORE"

      option_settings = [
        {
          name  = "IAM_ROLE_ARN"
          value = "${aws_iam_role.my_iam_role.arn}"
        },
      ]
    },
  ]

Forgot to mention the context, sorry.
So, i am using this within a module referencing "terraform-aws-modules/rds/aws" as source.
The only way i can work this around is that i create an aws_db_option_group resource, and set the options within, then i reference this aws_db_option_group instance.
resource "aws_db_option_group" "rds_op_grp" {
  name                     = "rds_op_grp"
  option_group_description = "Terraform Option Group"
  engine_name              = "${local.rds_engine}"
  major_engine_version     = "${local.major_engine_version}"

  option {
    option_name = "SQLSERVER_BACKUP_RESTORE"

    option_settings {
      name  = "IAM_ROLE_ARN"
      value = "${aws_iam_role.my_iam_role.arn}"
    }
  }

  tags = "${var.tags}"
}

hi all, this should be resolved on later versions of Terraform - 0.11.x is no longer supported by the module


0.35 release fails to load on windows

I downloaded and opened the 0.35 release. I get the following message on open:
screenshot

@ChrisJefferson Can you tell me about how you starting Extraterm and which kind of monitor/resolution you are using?

I've now been able to reproduce the problem here by setting the scaling factor to 150%.

It does work with scaling factor 200% and 100% though.

Fixed in version 0.35.1.


Version 0.15.0 missing on crates

Hi,
it seems like version 0.15.0 is missing on crates.io

Heyo - will you release a new version to support egui ? 0.29.0


Install kube ctl with brew

Just a suggestion, since you have brew instructions for cfssl: you might want to think about adding brew instructions on how to install kube ctl with brew:
brew install kubernetes-cli

I prefer the binaries from upstream.


Pin tools (Node.js, yarn cli, and Rust)

This PR adds the current versions used in the database-layer repository, the update of Rust will come separately.

ℹ  The update of the version of Rust will require additional changes. For example: an update of sqlx-cli that includes a deprecation of the sqlx-data.json file - ref: https://github.com/launchbadge/sqlx/commit/3f2ec6f91aa87db9f9f15adec1027b4126cde5f8).
With the intention of making the changes more clear to follow and review, a separate PR will come with the upgrade of the Rust version 🦀

For started sqlx upgrade see https://github.com/serlo/database-layer/tree/upgrade-sqlx-to-0.7.0. It needs some refactoring to compile again.

Why would a Rust version upgrade require changes like sqlx? I think it shouldn't. 🤔

Hi @AndreasHuber
Thank you for the review!

Why would a Rust version upgrade require changes like sqlx? I think it shouldn't. 🤔
After I changed the version of Rust to 1.70.0, I needed to re-install sqlx-cli and since I did not specify a version, the version  v0.7.0 was installed (since it's the latest release), if I specify the version (i.e. cargo install sqlx-cli --version 0.6.3) then we don't need to upgrade =)


Not working

Im looking for the rest api cli like this but unfortunantely this one is not working I think. You should update the video. I managed to get api working on heroku but Im unable to create new user... I always got 404. Same for the localhost..

Wich urls are you trying to access?

@stychu  Could you give us more info  ?
Currently we are working in a full review of the code and fix some bugs that there were not fixed before...
So if it would be possible, let us to know the steps that you was doing in order to reproduce this problem.
Thanks !

I'm closing this for now since the problem is probably related to #157, which was fixed in #160 and released as v0.12.
Let me know if the problem persists.


String cannot be cast to Integer if log property is set in maven pom.xml

Hi,
I am using maven to run the TestNG tests. For this I created some suite.xml files like:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
<suite name="Suite Name" verbose="10" parallel="classes">
	<test name="Web Channel Tests for B2B">
		<packages>
			<package name="com.some.package" />
		</packages>
	</test>
</suite>

There I set the verbosity to 10, but the generated verbosity after running the test is 0.
So I thought, I could set the verbosity from maven to 10. This is possible by setting the properties parameter
<build>
	<plugins>
		<plugin>
			<artifactId>maven-surefire-plugin</artifactId>
			<version>2.16</version>
			<configuration>
				<properties>
					<property>
						<name>log</name>
						<value>10</value>
					</property>
				</properties>
				<suiteXmlFiles>
					<suiteXmlFile>Some_suite.xml</suiteXmlFile>
				</suiteXmlFiles>
			</configuration>
		</plugin>
	</plugins>
</build>

Unfortunately TestNG dumps when reading this property, because the code in TestNG 6.8.7 looks like this:
   Integer verbose = (Integer) cmdLineArgs.get(CommandLineArgs.LOG);
    if (null != verbose) {
      result.verbose = verbose;
    }

The cast seems to be wrong there. The code for the threadcount setting (which can also be set by a maven property) has a conversion from String to int:
    String threadCount = (String) cmdLineArgs.get(CommandLineArgs.THREAD_COUNT);
    if (threadCount != null) {
      result.threadCount = Integer.parseInt(threadCount);
    }

Could you please fix the conversion of the log parameter or the generation of the correct verbosity from the initial suite.xml files?
My used versions:

maven-surefire-plugin 2.18
TestNG 6.8.7

Thanks,
Iwan

I think it is a surefire issue.
What do you think @Tibor17? Should a create an issue (or update SUREFIRE-919)?


P2P sending does not conclude on one device

Scenario 1

Start p2p sync and wait until in finishes.
On one device, the sending completed dialog is shown on one of the devices while the other device continues to send

Scenario 2

Start p2p sync
Cancel on the receiving device
It is observed that the sending device continues sending

This is fixed


[7.0.0] Please ignore. This is for Automation testing

Forked from #233

Cherry-picked in https://github.com/bazelbuild/bazel/pull/19304


Interface fixes & enhancements

Fix start_time conversion imprecision bug
Rename client-side create request fields is_{active,dry_run}
Make .create() return the new created dispatch

Updated:

always return Dispatch in create now (no parameter
use dict of CreateRequest for attribute comparison
Added explanation for time bug

Oh dear, it seems like I lost a in-process review. I will try to recreate what I remember. I suggest opening a new PR with the new commits, as they are not really necessary to be in this PR and we were close to finish the review. I have a few comments for the new commits and that will make merging this Pr more time consuming.

I suggest opening a new PR with the new commits, as they are not really necessary to be in this PR and we were close to finish the review. I have a few comments for the new commits and that will make merging this PR more time consuming.

Added explanation for time bug

Awesome, thanks! Now I remember.

Responded to comment and removed the unrelated commits

Ok, LGTM then.

Re-opeening as github seems very bugged now.

Probably needs a rebase?


CI/CT php 8.1

fixes #8

@stevespringett could you vreview & merge this one?

Hi @sschuberth @stevespringett @pombredanne ,
it is I, the author of this package.
could you make me a maintaine of this repor, so i can do some maintenance? :-)
it is regarding issue 8 and some other things i am planning.

Hi @sschuberth @stevespringett @pombredanne , it is I, the author of this package.
could you make me a maintainer of this repository, so i can do some maintenance? :-) it is regarding issue #8 and some other things i am planning.

Done! Thank you++ :bow:


Implement NSLayoutManager and NSString+UIKit using CoreText

NSLayoutManager and NSString drawing and layout are changed to use CoreText rather than manually laying out and drawing glyphs.  Also does small cleanup through CoreText such as changing DWrite to use CFAttributedStringRef rather than a CFTypesetter, as well as fixing our descent which should be inverse of what DWrite gives us.
Fixes #1017

}

no longer needed.

Refers to: Frameworks/CoreText/CTLine.mm:44 in dfd8a8d. [](commit_id = dfd8a8d4dfa0104245b3ae4a092582db06ebce8b, deletion_comment = False)

@jaredhms is added to the review. #Closed

// float width = widthFunc(widthParam, 0, 0, fontSize);

This can be deleted now

Refers to: Frameworks/CoreText/DWriteWrapper.mm:266 in 796ad0a. [](commit_id = 796ad0ab700afa7bba8da99e5db7d9e250bb5d8f, deletion_comment = False)

CFRange CTFrameGetStringRange(CTFrameRef frame) {

use MACROs from result.h to take care of the default null cases.

Refers to: Frameworks/CoreText/CTFrame.mm:44 in 0f5a0f0. [](commit_id = 0f5a0f04e003edb260a6ffb8177dd83e4324114a, deletion_comment = False)

_CTFrame* framePtr = static_cast<_CTFrame*>(frame);

as mentioned above and other places.

Refers to: Frameworks/CoreText/CTFrame.mm:60 in 0f5a0f0. [](commit_id = 0f5a0f04e003edb260a6ffb8177dd83e4324114a, deletion_comment = False)

I prefer the current style without macros #wontfix

CFIndex CTLineGetStringIndexForPosition(CTLineRef lineRef, CGPoint position) {

needs to be checked for validity

Refers to: Frameworks/CoreText/CTLine.mm:335 in 0f5a0f0. [](commit_id = 0f5a0f04e003edb260a6ffb8177dd83e4324114a, deletion_comment = False)

:clock1:

_textStorage = storage;

copy and attach?

Refers to: Frameworks/UIKit/NSLayoutManager.mm:212 in 0f5a0f0. [](commit_id = 0f5a0f04e003edb260a6ffb8177dd83e4324114a, deletion_comment = False)

_needsLayout = TRUE;

YES.
Such that elsewhere

Refers to: Frameworks/UIKit/NSLayoutManager.mm:193 in 0f5a0f0. [](commit_id = 0f5a0f04e003edb260a6ffb8177dd83e4324114a, deletion_comment = False)

// Copyright (c) 2015 Microsoft Corporation. All rights reserved.

update copyright

Refers to: Frameworks/UIKit/NSString+UIKitAdditions.mm:3 in 0f5a0f0. [](commit_id = 0f5a0f04e003edb260a6ffb8177dd83e4324114a, deletion_comment = False)

:clock1:

we want to share the text storage I would think, given we're responding to changes in it #bydesign

CGSize ret = frame ? frame->_frameRect.size : CGSize{ 0, 0 };

Prefer CGSizeZero

Refers to: Frameworks/CoreText/CTFramesetter.mm:89 in 203967b. [](commit_id = 203967b69be530678c168f92ee33ab13c8115328, deletion_comment = False)

[_textStorage addLayoutManager:self];

Does this need to call an equivalent of removeLayoutManager: on the outgoing NSTextStorage?

Refers to: Frameworks/UIKit/NSLayoutManager.mm:213 in 203967b. [](commit_id = 203967b69be530678c168f92ee33ab13c8115328, deletion_comment = False)

Possibly, but I consider that outside of the scope of this CR

:shipit:


VM access was blocked when eBPF dataplane used

When I enabled the Calico eBPF dataplane for a K8s cluster, the VMs(for which the NIC was bridged on the physical NIC of the server) on the node which had been configured with the eBPF dataplane can't be accessed with normal ssh access.
When the kube-proxy was restored and eBPF DP disabled, the SSH access to VM was also restored.
Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

The following script was used to enable eBPF dataplane:
#!/bin/bash
set -x
WORKDIR=$(pwd)
TMP_DIR=$(mktemp -d)
MARCH=$(uname -m)
CALICO_VERSION=${1:-3.23.2}
if [ $MARCH == "aarch64" ]; then ARCH=arm64;
elif [ $MARCH == "x86_64" ]; then ARCH=amd64;
else ARCH="unknown";
fi
echo ARCH=$ARCH
k8s_ep=$(kubectl get endpoints kubernetes -o wide | grep kubernetes | cut -d " " -f 4)
k8s_host=$(echo $k8s_ep | cut -d ":" -f 1)
k8s_port=$(echo $k8s_ep | cut -d ":" -f 2)
cat < ${WORKDIR}/k8s_service.yaml
kind: ConfigMap
apiVersion: v1
metadata:
name: kubernetes-services-endpoint
namespace: kube-system
data:
KUBERNETES_SERVICE_HOST: "KUBERNETES_SERVICE_HOST"
KUBERNETES_SERVICE_PORT: "KUBERNETES_SERVICE_PORT"
EOF
sed -i "s/KUBERNETES_SERVICE_HOST/${k8s_host}/" ${WORKDIR}/k8s_service.yaml
sed -i "s/KUBERNETES_SERVICE_PORT/${k8s_port}/" ${WORKDIR}/k8s_service.yaml
kubectl apply -f ${WORKDIR}/k8s_service.yaml
echo "Disable kube-proxy:"
kubectl patch ds -n kube-system kube-proxy -p '{"spec":{"template":{"spec":{"nodeSelector":{"non-calico": "true"}}}}}'
if [ ! -f /usr/local/bin/calicoctl ]; then
echo "No calicoctl, install now:"
curl -L https://github.com/projectcalico/calico/releases/download/v${CALICO_VERSION}/calicoctl-linux-${ARCH} -o ${WORKDIR}/calicoctl;
chmod +x ${WORKDIR}/calicoctl;
sudo cp ${WORKDIR}/calicoctl /usr/local/bin;
rm ${WORKDIR}/calicoctl
fi
echo "Enable eBPF:"
calicoctl patch felixconfiguration default --patch='{"spec": {"bpfEnabled": true}}' --allow-version-mismatch
echo "Enable Direct Server Return(DSR) mode: optional"
#calicoctl patch felixconfiguration default --patch='{"spec": {"bpfExternalServiceMode": "DSR"}}'
Context

I try to access the VM(<IP_ADDRESS>) which was located in a server with Calico eBPF enabled from another server(<IP_ADDRESS>),  only the first ping packet can be received, and other ping packets were lost.
The conntrack for the Calico node showed the ssh access (from <IP_ADDRESS>) to VM(<IP_ADDRESS>):
# calico-node -bpf conntrack dump |grep "<IP_ADDRESS>"
2022-07-15 08:21:37.276 [INFO][13703] confd/maps.go 433: Loaded map file descriptor. fd=0x7 name="/sys/fs/bpf/tc/globals/cali_v4_ct2"
ConntrackKey{proto=6 <IP_ADDRESS>:61701 <-> <IP_ADDRESS>:22} -> Entry{Type:0, Created:17278773931441431, LastSeen:17278777015499210, Flags:  Data: {A2B:{Seqno:92691206 SynSeen:true AckSeen:true FinSeen:false RstSeen:false Whitelisted:true Opener:true Ifindex:2} B2A:{Seqno:959809259 SynSeen:true AckSeen:true FinSeen:false RstSeen:false Whitelisted:false Opener:false Ifindex:0} OrigDst:<IP_ADDRESS> OrigPort:0 OrigSPort:0 TunIP:<IP_ADDRESS>}} Age: 3.143463957s Active ago 59.406178ms ESTABLISHED
Your Environment

Calico version: v3.23.2
Orchestrator version (e.g. kubernetes, mesos, rkt): K8s 1.22.1
Operating System and version: Ubuntu 20.04 focal Linux kernel 5.10.0
Link to your project (optional):

CC @tomastigera

I first met this issue on an arm64 platform, but it seems there is no such issue on some other platforms or systems, e.g, for some x86  systems.  I checked the eBPF output log by setting bpfLogLevel to Debug, the output showed the differences between the 2 kinds of cases.
We met this issue on an arm64 platform, but it seems there is no such issue on x86 platform. I checked the log output carefully for these 2 systems:

For arm64 platform:

4869           -0       [088] d.s. 1810775.267212: bpf_trace_printk: enp9s0---I: New packet at ifindex=2; mark=0
4870
4871           -0       [088] d.s. 1810775.267213: bpf_trace_printk: enp9s0---I: No metadata is shared by XDP
4872
4873           -0       [088] d.s. 1810775.267215: bpf_trace_printk: enp9s0---I: IP id=13695 s=aa9d0e5 d=aa9d287
4874
4875           -0       [088] d.s. 1810775.267217: bpf_trace_printk: enp9s0---I: ICMP; type=8 code=0
4876
4877           -0       [088] d.s. 1810775.267218: bpf_trace_printk: enp9s0---I: CT-1 lookup from aa9d0e5:0
4878
4879           -0       [088] d.s. 1810775.267219: bpf_trace_printk: enp9s0---I: CT-1 lookup to   aa9d287:0
4880
4881           -0       [088] d.s. 1810775.267221: bpf_trace_printk: enp9s0---I: CT-1 Hit!  Program execution time: 31307ns
4944
4945           -0       [088] d.s. 1810775.267249: bpf_trace_printk: enp9s0---E: New packet at ifindex=2; mark=3000000
4946
4947           -0       [088] d.s. 1810775.267250: bpf_trace_printk: enp9s0---E: Final result=ALLOW (3). Bypass mark bit set.
4948
For other systems(x86 currently), the log showed:
      <idle>-0       [014] ..s. 17619198.981271: 0: eno1np0--I: New packet at ifindex=2; mark=0
      <idle>-0       [014] ..s. 17619198.981271: 0: eno1np0--I: No metadata is shared by XDP
      <idle>-0       [014] ..s. 17619198.981272: 0: eno1np0--I: IP id=53367 s=aa9d0e5 d=aa9d27f
      <idle>-0       [014] ..s. 17619198.981273: 0: eno1np0--I: ICMP; type=8 code=0
      <idle>-0       [014] ..s. 17619198.981273: 0: eno1np0--I: CT-1 lookup from aa9d0e5:0
      <idle>-0       [014] ..s. 17619198.981274: 0: eno1np0--I: CT-1 lookup to   aa9d27f:0
      <idle>-0       [014] ..s. 17619198.981275: 0: eno1np0--I: CT-1 Hit! NORMAL entry.
      <idle>-0       [014] ..s. 17619198.981275: 0: eno1np0--I: CT-1 result: 0x2
      <idle>-0       [014] ..s. 17619198.981276: 0: eno1np0--I: conntrack entry flags 0x100
      <idle>-0       [014] ..s. 17619198.981276: 0: eno1np0--I: CT Hit
      <idle>-0       [014] ..s. 17619198.981277: 0: eno1np0--I: Entering calico_tc_skb_accepted_entrypoint
      <idle>-0       [014] ..s. 17619198.981277: 0: eno1np0--I: IP id=53367 s=aa9d0e5 d=aa9d27f
      <idle>-0       [014] ..s. 17619198.981278: 0: eno1np0--I: Entering calico_tc_skb_accepted
      <idle>-0       [014] ..s. 17619198.981278: 0: eno1np0--I: src=aa9d0e5 dst=aa9d27f
      <idle>-0       [014] ..s. 17619198.981279: 0: eno1np0--I: post_nat=0:0
      <idle>-0       [014] ..s. 17619198.981279: 0: eno1np0--I: tun_ip=0
      <idle>-0       [014] ..s. 17619198.981279: 0: eno1np0--I: pol_rc=1
      <idle>-0       [014] ..s. 17619198.981280: 0: eno1np0--I: sport=0
      <idle>-0       [014] ..s. 17619198.981280: 0: eno1np0--I: flags=20
      <idle>-0       [014] ..s. 17619198.981280: 0: eno1np0--I: ct_rc=2
      <idle>-0       [014] ..s. 17619198.981281: 0: eno1np0--I: ct_related=0
      <idle>-0       [014] ..s. 17619198.981281: 0: eno1np0--I: mark=0x1000000
      <idle>-0       [014] ..s. 17619198.981281: 0: eno1np0--I: ip->ttl 64
      <idle>-0       [014] ..s. 17619198.981282: 0: eno1np0--I: IP id=53367 s=aa9d0e5 d=aa9d27f
      <idle>-0       [014] ..s. 17619198.981283: 0: eno1np0--I: FIB family=2
      <idle>-0       [014] ..s. 17619198.981283: 0: eno1np0--I: FIB tot_len=0
      <idle>-0       [014] ..s. 17619198.981283: 0: eno1np0--I: FIB ifindex=2
      <idle>-0       [014] ..s. 17619198.981283: 0: eno1np0--I: FIB l4_protocol=1
      <idle>-0       [014] ..s. 17619198.981284: 0: eno1np0--I: FIB sport=0
      <idle>-0       [014] ..s. 17619198.981284: 0: eno1np0--I: FIB dport=0
      <idle>-0       [014] ..s. 17619198.981284: 0: eno1np0--I: FIB ipv4_src=aa9d0e5
      <idle>-0       [014] ..s. 17619198.981284: 0: eno1np0--I: FIB ipv4_dst=aa9d27f
      <idle>-0       [014] ..s. 17619198.981285: 0: eno1np0--I: Traffic is towards the host namespace, doing Linux FIB lookup
      <idle>-0       [014] ..s. 17619198.981287: 0: eno1np0--I: FIB lookup failed (FIB problem): 7.
      <idle>-0       [014] ..s. 17619198.981287: 0: eno1np0--I: Traffic is towards host namespace, marking with 0x1000000.
      <idle>-0       [014] ..s. 17619198.981288: 0: eno1np0--I: Final result=ALLOW (0). Program execution time: 16040ns

vhost-3084463-3084499 [008] .... 17619198.981418: 0: eno1np0--E: New packet at ifindex=2; mark=0
vhost-3084463-3084499 [008] .... 17619198.981419: 0: eno1np0--E: IP id=42046 s=aa9d27f d=aa9d0e5
The test process is the same for 2 systems: we just ping a VM in a host which had enabled Calico/ebpf dataplane from another host.
For arm64 platform, the ping packet can't reach the VM since it had been falsely forwarded by the eBPF program (forward_or_drop function).
The differences here lies on the result of FIB lookup, for x86 platform, the FIB lookup failed with code 7, then marked with 0x1000000; for arm64 platform, the FIB lookup succeeded with neigh given, then marked with 0x3000000 and re-appeared on the egress direction of the same interface.
I think for the packet destined for VMs instead of the host itself, it should be checked if it's actually for the host itself by checking the eBPF route map first. If the lookup result for route is unknown, it should be thought as NOT destined for this host and to be ok(TC_ACT_OK) to skip subsequent eBPF processing here.
I saw there is a similar processing for the unrelevant traffic in Cilium eBPF implementation:
ep = lookup_ip4_endpoint(ip4);
https://github.com/cilium/cilium/blob/master/bpf/bpf_host.c#L571
and
if (!from_host)
return CTX_ACT_OK;
https://github.com/cilium/cilium/blob/master/bpf/bpf_host.c#L586
Here the endpoint of Cilium eBPF is similar to the route of Calico eBPF.
I will put up a PR to address this issue and thanks for your review.
The used versions of Calico:
v3.23.2, v3.24.1 and v3.25.0-0.dev.

@TrevorTaoARM sorry for not responding sooner, totally missed this, :eyes:  now! And thanks for a great analysis! :pray:

@TrevorTaoARM I commented at your patch :arrow_up:

The differences here lies on the result of FIB lookup, for x86 platform, the FIB lookup failed with code 7, then marked with 0x1000000; for arm64 platform, the FIB lookup succeeded with neigh given, then marked with 0x3000000 and re-appeared on the egress direction of the same interface.

It seems like the packets ultimately ended up on the egress of the same device regardless of whether the FIB failed or not. But I am not quite sure how the packet looks like in the ARM case as that is missing in the logs when the BYPASS mark is set. Perhaps the host mangled that packet?

The differences here lies on the result of FIB lookup, for x86 platform, the FIB lookup failed with code 7, then marked with 0x1000000; for arm64 platform, the FIB lookup succeeded with neigh given, then marked with 0x3000000 and re-appeared on the egress direction of the same interface.

It seems like the packets ultimately ended up on the egress of the same device regardless of whether the FIB failed or not. But I am not quite sure how the packet looks like in the ARM case as that is missing in the logs when the BYPASS mark is set. Perhaps the host mangled that packet?

The differences here lies on the result of FIB lookup, for x86 platform, the FIB lookup failed with code 7, then marked with 0x1000000; for arm64 platform, the FIB lookup succeeded with neigh given, then marked with 0x3000000 and re-appeared on the egress direction of the same interface.

It seems like the packets ultimately ended up on the egress of the same device regardless of whether the FIB failed or not. But I am not quite sure how the packet looks like in the ARM case as that is missing in the logs when the BYPASS mark is set. Perhaps the host mangled that packet?

@tomastigera Yes, the difference of fib lookup results between the 2 platforms really confused me. But it looks like only when eBPF is enabled, the packet flow for a certain VM would be blocked. I didn't know when the BYPASS mark is set, what the subsequent data path for the packet is. The only trace I saw was:
4945           -0       [088] d.s. 1810775.267249: bpf_trace_printk: enp9s0---E: New packet at ifindex=2; mark=3000000
4946
4947           -0       [088] d.s. 1810775.267250: bpf_trace_printk: enp9s0---E: Final result=ALLOW (3). Bypass mark bit set.
which showed the packet had been transfered to the egress direction, but for x86, the packet is still in the ingress direction:
-0       [014] ..s. 17619198.981287: 0: eno1np0--I: Traffic is towards host namespace, marking with 0x1000000.
-0       [014] ..s. 17619198.981288: 0: eno1np0--I: Final result=ALLOW (0). Program execution time: 16040ns

@tomastigera Fixed but not complete
schema
eth0(without IP) ---- bond0(<IP_ADDRESS>/24) ---- app(port 2200)
<idle>-0       [005] dNs3.   220.318140: bpf_trace_printk: eth0-----I: New packet at ifindex=2; mark=0           <idle>-0       [005] dNs3.   220.318151: bpf_trace_printk: eth0-----I: No metadata is shared by XDP           <idle>-0       [005] dNs3.   220.318152: bpf_trace_printk: eth0-----I: IP id=0 s=a97d428 d=ad0c90f           <idle>-0       [005] dNs3.   220.318153: bpf_trace_printk: eth0-----I: TCP; ports: s=50634 d=2200           <idle>-0       [005] dNs3.   220.318153: bpf_trace_printk: eth0-----I: CT-6 lookup from a97d428:50634           <idle>-0       [005] dNs3.   220.318154: bpf_trace_printk: eth0-----I: CT-6 lookup to   ad0c90f:2200           <idle>-0       [005] dNs3.   220.318155: bpf_trace_printk: eth0-----I: CT-6 Miss for TCP SYN, NEW flow.           <idle>-0       [005] dNs3.   220.318156: bpf_trace_printk: eth0-----I: CT-6 result: NEW.           <idle>-0       [005] dNs3.   220.318156: bpf_trace_printk: eth0-----I: conntrack entry flags 0x0           <idle>-0       [005] dNs3.   220.318157: bpf_trace_printk: eth0-----I: NAT: 1st level lookup addr=ad0c90f port=2200 protocol=6.           <idle>-0       [005] dNs3.   220.318158: bpf_trace_printk: eth0-----I: NAT: Miss.           <idle>-0       [005] dNs3.   220.318160: bpf_trace_printk: eth0-----I: Host RPF check src=a97d428 skb iface=2 strict if 3           <idle>-0       [005] dNs3.   220.318161: bpf_trace_printk: eth0-----I: Host RPF check src=a97d428 skb iface=2 fib rc 0           <idle>-0       [005] dNs3.   220.318161: bpf_trace_printk: eth0-----I: Host RPF check src=a97d428 skb iface=2 result 0           <idle>-0       [005] dNs3.   220.318162: bpf_trace_printk: eth0-----I: Final result=DENY (0). Program execution time: 10037ns
dropped by RPF check
with BPFEnforceRPF=Disabled
<idle>-0       [005] d.s3.  6710.121268: bpf_trace_printk: eth0-----I: TCP; ports: s=52905 d=2200           <idle>-0       [005] d.s3.  6710.121269: bpf_trace_printk: eth0-----I: CT-6 lookup from a97d428:52905           <idle>-0       [005] d.s3.  6710.121270: bpf_trace_printk: eth0-----I: CT-6 lookup to   ad0c90f:2200           <idle>-0       [005] d.s3.  6710.121271: bpf_trace_printk: eth0-----I: CT-6 Miss for TCP SYN, NEW flow.           <idle>-0       [005] d.s3.  6710.121274: bpf_trace_printk: eth0-----I: CT-6 result: NEW.           <idle>-0       [005] d.s3.  6710.121275: bpf_trace_printk: eth0-----I: conntrack entry flags 0x0           <idle>-0       [005] d.s3.  6710.121277: bpf_trace_printk: eth0-----I: NAT: 1st level lookup addr=ad0c90f port=2200 protocol=6.           <idle>-0       [005] d.s3.  6710.121280: bpf_trace_printk: eth0-----I: NAT: Miss.           <idle>-0       [005] d.s3.  6710.121282: bpf_trace_printk: eth0-----I: Host RPF check disabled           <idle>-0       [005] d.s3.  6710.121284: bpf_trace_printk: eth0-----I: Post-NAT dest IP is local host.           <idle>-0       [005] d.s3.  6710.121285: bpf_trace_printk: eth0-----I: About to jump to policy program.           <idle>-0       [005] d.s3.  6710.121285: bpf_trace_printk: eth0-----I: HEP with no policy, allow.           <idle>-0       [005] d.s3.  6710.121287: bpf_trace_printk: eth0-----I: Entering calico_tc_skb_accepted_entrypoint           <idle>-0       [005] d.s3.  6710.121288: bpf_trace_printk: eth0-----I: Entering calico_tc_skb_accepted           <idle>-0       [005] d.s3.  6710.121289: bpf_trace_printk: eth0-----I: src=a97d428 dst=ad0c90f           <idle>-0       [005] d.s3.  6710.121290: bpf_trace_printk: eth0-----I: post_nat=ad0c90f:2200           <idle>-0       [005] d.s3.  6710.121291: bpf_trace_printk: eth0-----I: tun_ip=0           <idle>-0       [005] d.s3.  6710.121297: bpf_trace_printk: eth0-----I: pol_rc=1           <idle>-0       [005] d.s3.  6710.121298: bpf_trace_printk: eth0-----I: sport=52905           <idle>-0       [005] d.s3.  6710.121299: bpf_trace_printk: eth0-----I: flags=24           <idle>-0       [005] d.s3.  6710.121300: bpf_trace_printk: eth0-----I: ct_rc=0           <idle>-0       [005] d.s3.  6710.121301: bpf_trace_printk: eth0-----I: ct_related=0           <idle>-0       [005] d.s3.  6710.121302: bpf_trace_printk: eth0-----I: mark=0x1000000           <idle>-0       [005] d.s3.  6710.121304: bpf_trace_printk: eth0-----I: ip->ttl 57           <idle>-0       [005] d.s3.  6710.121307: bpf_trace_printk: eth0-----I: Allowed by policy: ACCEPT

@Dimonyga Not sure whether this is related to the original issue, however, if you apply bpf programs to eth0 in this setup, then surely you cannot pass a strict RPF because routing says that the return path is via bond0 and not eth0. So the bpfDataIfacePattern must not include eth0 and must include bond0 Note that is also much more logically correct. However, there is an issue that if you change the pattern, programs from eth0 are not cleared. You can either remove them manually or reboot the nodes. This issue is addressed by https://github.com/projectcalico/calico/pull/7008


Support plugin arguments

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
Description:
Currently, we only support configuration on plugin's callback; it's better to support customized arguments to plugins. For example:
actions: "reclaim, allocate, backfill, preempt"
tiers:
- plugins:
  - name: priority
  - name: gang
  - name: conformance
- plugins:
  - name: drf
  - name: predicates
  - name: proportion
  - name: nodeorder
    arguments:
    - affinity.weight: 2

@thandayuthapani , would you help on that?

@k82cn we can handle arguments as map instead of parameters being slice, since those parameters can have different keys for different plugins. affinity.weight might be only suitable for nodeorder plugin. So we can handle it as map, so in code we can try to get it from map.

Expected YAML should of this form, arguments are handled as map instead of slice.
actions: "reclaim, allocate, backfill, preempt"
tiers:
- plugins:
  - name: priority
  - name: gang
  - name: conformance
- plugins:
  - name: drf
  - name: predicates
  - name: proportion
  - name: nodeorder
    arguments:
      affinity.weight: 2
      affinity.enable: true


Sometimes Dungeon Generator create rooms in wrong places.

I noticed, that sometimes generator gives a level with 1 or 2 black color rooms, which are placed in the wrong place and are not connected properly. How am I supposed to fix that?

Hard to say. Is this using the default settings from the demo (with no changes?) If so, do you have the seed/dungeon size params so I can regenerate it?
My best guess otherwise is there's something wrong with the data - either door orientations are incorrect, or voxels have not been set up correctly for the room size, or something along those lines.
Never seen this happen before!

Hard to say. Is this using the default settings from the demo (with no changes?) If so, do you have the seed/dungeon size params so I can regenerate it?
My best guess otherwise is there's something wrong with the data - either door orientations are incorrect, or voxels have not been set up correctly for the room size, or something along those lines.
Never seen this happen before!

Clone repo and try any random seed. Sometimes this happen. I thought, that I made some bad changes in code, but after a try with default source code and settings (with random seed) the issue appeared again.

I'll take a look. Can't guarantee anything though unfortunately. Rooms that are marked in black have been spawned as "loop rooms". Rooms that add a loop to the dungeon, connecting two different paths on the graph, and this "feature" was never fully functional (as I didn't like how it worked, didn't give great results, etc).
Looks like it's finding valid rooms that "fit" without collisions in the voxel grid, but ignoring the fact that the doors are not aligned/facing each other properly, and probably just needs an extra check somewhere to ensure that we hook up the two looping doors correctly. Thought this already worked, but must not have been as bulletproof as I thought.


139 dict filter value

Primary purpose of the branch is to allow stix2.Filter to take Python dictionary as a value. Could not be done previously as we would internally use Python sets to pass around filters, and dicts can not be added to sets. Main component changes for this:

FilterSet class ( uses a list to maintain filters but acts like a set , for internal use only)
removal of _assemble_filters() as FilterSet can handle same functionality

Additionally, made some changes to FIlters to allow for more seamless comparison of datetimes. Now a Filter created with a datetime as its value will store the datetime in str format, and any datatime object being compared (to the filter) will have its str format used. So all datetime comparisons are done str to str. Component changes:

Filter class
added tests to check for this

Along the way, found a bug in the parsing of observables, essentially the original dictionaries being passed to parse were having their nested observable properties converted to STIX objects.  This required some changes (deep-copying) of supplied user data before altering and further parsing. Also made the utility get_dict() private as part of the reason for the oversight. Main component changes for this:

changing to _get_dict()
deepcopy'ing being done in ObservableProperty and ExtensionProperty
added tests for this

#139

Codecov Report

Merging #166 into master will increase coverage by 0.11%.
The diff coverage is 96.52%.

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   98.73%   98.85%   +0.11%
==========================================
  Files          58       58
  Lines        6028     6288     +260
==========================================
+ Hits         5952     6216     +264
+ Misses         76       72       -4

Impacted Files
Coverage Δ

stix2/v20/observables.py
100% <100%> (ø)
:arrow_up:

stix2/datastore/__init__.py
100% <100%> (ø)
:arrow_up:

stix2/environment.py
100% <100%> (ø)
:arrow_up:

stix2/v20/common.py
98.66% <100%> (ø)
:arrow_up:

stix2/workbench.py
100% <100%> (ø)
:arrow_up:

stix2/core.py
100% <100%> (ø)
:arrow_up:

stix2/datastore/memory.py
98.86% <100%> (-0.03%)
:arrow_down:

stix2/properties.py
100% <100%> (ø)
:arrow_up:

stix2/test/test_utils.py
100% <100%> (ø)
:arrow_up:

stix2/__init__.py
100% <100%> (ø)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b8bfe...4734711. Read the comment docs.


Bug fix/imap defect fixes

Emails  needed to be sorted in descending order
Thank you for your contribution.
Before submitting this PR, please make sure:

[x] PR description and commit message should describe the changes done in this PR
[x] Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
[x] Latest Code from master or specific release branch is merged to your branch
[x] No unwanted\commented\junk code is included
[x] No new warning upon build solution
[x] Code Summary\Comments are added to my code which explains what my code is doing
[x] Existing unit test cases are passed
[ ] New Unit tests are added for your development
[x] Sanity Tests are successfully executed for New and Existing Functionality
[x] Verify that changes are compatible with all relevant browsers and platforms.
[x] After creating pull request there should not be any conflicts
[ ] Resolve codacy comments
[ ] Builds and checks are passed before PR is sent for review
[ ] Resolve code review comments
[ ] Help Libray document is updated accordingly for Feature changes.

It is handled in another PR


When I set__ C. TRAIN.EXEMPLAR_ SIZE=512.. my loc loss is always 0

When I set__ C. TRAIN.EXEMPLAR_ SIZE=512，__ C. TRAIN.SEARCH_ SIZE=800，__ C. TRAIN.OUTPUT_ When size = 37, my loc loss is always 0. What other parameters do I need to change

Could you provide more details, e.g. the config file used for training.

I solved this problem by using pretrained model


Add support for pubsub in adapter of valkey-go similar to go-redis pubsub.go

Discussed in https://github.com/orgs/valkey-io/discussions/797

Originally posted by royatanu94 July 17, 2024
Currently we have used :
rcOptions = &redis.UniversalOptions{
rc = redis.NewUniversalClient(rcOptions)
and
func GetRedisClient(conf *RedisConfig) (redis.UniversalClient, error)
What will be the compatible code for above two in valkey-go?

Hi all, the PubSub adapter has been merged into the latest version.


x/image/font/gofont: poor quality on windows 7 firefox

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
https://blog.golang.org/go-fonts
What operating system and processor architecture are you using (go env)?
Windows 7
Firefox 49.0.2 or 50.0
Chrome 54.0.2840.99 m
What did you do?
Read the article https://blog.golang.org/go-fonts
What did you expect to see?
New nice fonts
What did you see instead?
The experience differs quite a lot with zoom factor and browser supplier
While I strongly appreciate the work that lead to the new fonts for go, the experience on firefox is rather poor.
Please see the screenshots below.
Specialy 90% zoom factor looks not very nice, but also the (most imporant) 100% could be a lot better.
On chrome, the fonts look just different, a little lighter over all.
This is on windows 7 and it might be different with other operating systems.
Chrome 80%:

Firefox 80%:

Chrome 90%:

Firefox 90%:

Chrome 100%:

Firefox 100%:

Chrome 150%:

Firefox 150%:

This seems not to reproduce on Mac OS X 10.11.6 w/Firefox 50.0, MacBook Air, display 1440x900.
At 90%:

It also looked okay (the same, more or less) at 90% on Ubuntu.recent, and on both platforms it looked okay at other magnifications.
Can you try this on a more recent version of Windows?

It seems better with windows 10:
Firefox 90%:

Firefox 100%:

Windows 7 is very old and the font technology there is old too. I doubt there's much we can do.

Srsly? This is the "solution" to the problem? What about people working with a windows 7 computer given by the company?


Merge sequence annotation into master

Pull request for sequence annotation from topic branch.
This impacts several other task teams, so please examine and vote.

-1, this PR is backwards. You're trying to merge the master commits onto the topic branch (updating the topic branch), when I think you wanted to merge the topic branch onto master (updating master).

I'm going to close this one to allow a re-issue of the PR


Upgrade peer dep to use theo@^8

Fixes https://github.com/salesforce-ux/gulp-theo/issues/6

Thanks for your patience regarding this issue. We ended up updating this last July, although it didn't get a full release. We've rectified that as of Feb 3rd, 2020, with v2.0.1.


added better wrap support to LeftRightArranger

Enyo-DCO-1.1-Signed-off-by: Derek Anderson<EMAIL_ADDRESS>the current left and right arranger gets direction handling mixed up when index values change from Finish to End, and End to Finish.
Added variable 'w' which will check to see if the rotator is 'wrapping' during arrangement.

@dmikey Do you think you can fix the merge conflict? Thanks!

Closing, looking again - this doesn't look like it is currently fixing what I originally intended for it to fix.


Add api-fuzzer corpus

Log for testing: http://pastebin.com/fMWDfEqH
After looking at https://github.com/google/sanitizers/issues/333, I think I can make the stack trace more detailed and will try to do so over the weekend. I'll update on Monday.

No new bugs, but looks like we're exposing something in the fuzzing stack.
Still, corpus expansion is probably warranted (it's been a while).


Moving to VB.NET

Although Python is great and superior to any other programming language, I want to shift the domain chooser from being written in python to VB .NET for maximum compatibility. Plus compiling python apps in the way I do now, results in too many files, which reduces the user friendliness. Plus some of those components are coming up with unpatched bugs and vulnerabilities and I don't want to risk it on a service that people will be exposing to the internet.

Nearly have this done

Well I just completed this: Hopefully I can now start focusing on V4 where I will add a Graphical Interface.


Shorten QC messages - remove repeated terms

Suggested enhancement: edit QC messages to remove repeated terms.
For warnings:
"WARNING: Low Coverage: Low coverage for all tiles (18.200 < 20 expected)" -> change to: "WARNING: Low coverage for all tiles (18.200 < 20 expected)"
For missing tiles:
"FAIL: Missing Tiles Error 1: 11.11% missing tiles; more than 5.00% missing tiles threshold. Low coverage depth (19.1 < 20.0 expected); you may need more WGS data." -> change to: "FAIL: 11.11% missing tiles > 5.00% QC setting. Low coverage depth (19.1 < 20.0 expected); you may need more WGS data."
For mixed samples:
"FAIL: Mixed Sample Error 2: Mixed subtype detected. Positive and negative tiles detected for the same target site "2417681" for subtype "1"."  -> change to: "FAIL: Mixed subtype detected. Positive and negative tiles detected for the same target site "2417681" for subtype "1"."

Hi @glabbe! Welcome to GitHub :wave:
Thanks for taking the time to create an issue about this. I've created a pull request to fix this issue in #47
I'll get @gcttong to review the code before merging into the development branch and creating a new release of bio_hansel.

Awesome, thanks Peter!


Expose readwrite struct members to python

Hi!
Currently, the Lanelet2 python interface uses add_property to expose public struct member variables. This leads to read-only access. An example is the ArcCoordinates class whose attributes are read-only.
Here I propose a fix that exposes all public struct member variables in the python interface with read-write access. It may not make practical sense for all classes, but is at least consistent.
Thanks!

I restored read-only access for member variables of no_init classes. I guess, write access does not make sense there.

Thanks! Merged with 94d94a54cf577dc1b030d5e60507c03948d10661


New qfit ligand

Pull Request Checklist

[x] Will your PR merge into the dev branch?
Exceptions will be made for urgent bugfixes.
[x] Have you forked from dev?
If not, please rebase your PR onto the most recent dev tip.
[x] Does your PR title succinctly describe the changes?
Explain to a new user by completing the sentence: 'This PR will: ...'
[x] Fill out the template below.

Description of the Change
The updated ligand sampling in qFit replaces the previous local_search() and internal_dof() methods with multiple conformer generation functions using RDKit. Now, users must provide a SMILES string (--smiles) along with the model, map, labels, and selection to run qFit. There is an option to specify the number of conformers to generate (--numConf), defaulting to 10,000. Additionally, there's an optional flag to enable MIQP solvers with BIC (--ligand_bic), which is set to false by default.
Our algorithm processes the input ligand through 3 to 6 conformer generation functions, depending on the ligand's structure. These include unconstrained, terminal atom constrained, and spherically constrained conformer generation. If the ligand features a side chain, a branching search is also conducted. For side chains longer than 30 atoms, a long chain search is performed. Conformers from these processes are pooled together, QP scored, and then subjected to further sampling through rotation and translation. The total number of conformers generated is distributed equally among the utilized functions. For example, if no side chains are present and only three functions are used prior to rotation and translation, each function would generate approximately 3,333 conformers out of a total of 10,000.

Release Notes
Replace the existing ligand sampling strategy with several conformer generation functions using RDKit.

Things to add:

README- provide instructions on how to run. Also suggest how user should generate SMILES.
Examples folder - provide instructions on how to run.
please provide a default for --numConf.
Put in a fail message if qFit ligand input argument does not contain SMILES string.
Delete old qFit ligand code (a lot of this is only commented out).

refinement script:

why do we need ligand only file?
Let's output: The output can be found at ${pdb_name}_qFit_ligand.(pdb|mtz|log).
remove: redistribute_cull_low_occupancies -occ 0.09 "${pdb_name}_002.pdb"
mv -v "${pdb_name}_002_norm.pdb" "${pdb_name}_002.pdb"
rename final refinement -> Refinement (as this is the only refinement we are doing)
Make sure all of this goes to the appropriate params (you are refining with final_refine.params)

"refinement.input.xray_data.r_free_flags.label=${field}" >> ${pdb_name}_refine.params
echo "refinement.input.xray_data.r_free_flags.generate=${gen_Rfree}" >> ${pdb_name}_refine.params

remove or put in params file (but this will duplicate lines if 5 is worked out):
"refinement.input.xray_data.r_free_flags.generate=True"
"refinement.input.xray_data.labels=${xray_data_labels}" \

In qFit.py:
This looks like it is hardcoded. If people need to have ligand.pdb specify that, but I think it should be able to read in any PDB as long as it is labeled correctly with args.
Read in ligand pdb file
self.ligand_pdb_file = "ligand.pdb"
put this print into logger info with details over which search it is.
if mol.GetNumConformers() == 0:
print("NO CONF GENERATED")


Add Imagenav baseline into main + update object search in semantic map

Motivation and Context

Changelog

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Rebased
Addressed comments (thanks for the reviews!)
Ensured simulation performance is as expected
Reused existing home-robot modules (eg DiscretePlanner)

@exhaustin

done
fixed
I don't understand the CI errors and I can't reproduce them locally. Could you take a look?
discussion continued on slack


Button: to/href needs implementation

to: {
   required: false,
   type: String | Object,
},
href: {
   required: false,
   type: String,
},

Open to a pull request :+1:

Before I take this one, @kaidesu do you know if the intention for the to/href is just for linking to a page or if it's meant to act as a formaction? Curious if we want to implement HTML5 global attributes for Buttons which includes using `formaction:

The URL that processes the information submitted by the button. If specified, it overrides the action attribute of the button's form owner.

If we're to match the HTML5 specification for attributes on the component, should we clarify that href/to are meant to enable the button as a link?

Just linking :+1:


Send all telemetry over HTTPS

Use https://dc.services.visualstudio.com/v2/track endpoint.

FYI actual PR is https://github.com/Microsoft/ApplicationInsights-node.js/pull/105


Notebooks: Ensure WYSIWYG Mode for Keyboard Shortcuts

Fixes #14404.
We were incorrectly capturing keyboard shortcuts even outside of WYSIWYG mode, causing some functionality to not work (such as tab moves focus).

Pull Request Test Coverage Report for Build 596845331

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 43.262%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts
0
2
0.0%

Totals

Change from base Build 596829025:
-0.004%

Covered Lines:
25018

Relevant Lines:
52998

💛  - Coveralls


feat: support scale video

Codecov Report

Merging #3 (019d918) into master (430fff1) will increase coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   96.00%   96.72%   +0.72%
==========================================
  Files           2        2
  Lines          50       61      +11
==========================================
+ Hits           48       59      +11
  Misses          1        1
  Partials        1        1

Flag
Coverage Δ

unittests
96.72% <100.00%> (+0.72%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/executor/pool.go
95.91% <100.00%> (+1.18%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Repo-Review

The PhasorPy project loosely follows the Scientific Python Library Development Guide, pyOpenSci Python Package Guide, and GitHub Community Standards.
The Scientific Python Library Development Guide offers a Repo-Review tool to check if a repository follows guidelines.
This issue serves as a reminder to occasionally revisit the guides.
See also the discussions in #51, #114, #115, #116.

In #119, filterwarnings = ["error"] was disabled for pytest because it broke debugging tests in VSCode due to a bug in Pylance.


ENH: Adding additional keywords to read_html for #13461

[x] closes #13461
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

@gte620v The suggestion in #10534 was to add dtype argument (although the converters keyword will be able to achieve a similar goal). Can you have a look if it is easy to pass through that keyword as well?
In the same line, I think it would be useful to at once evaluate the other keywords to see which ones could be useful for html parsing.

Can you have a look if it is easy to pass through that keyword as well?

My initial impression is that dtype can not be easily dropped in since it is not supported by the python engine parser: https://github.com/pydata/pandas/blob/master/pandas/io/parsers.py#L463-L470
For reasons I haven't poked around enough to understand, the read_html function uses the FileParser function which uses the python engine: https://github.com/pydata/pandas/blob/master/pandas/io/parsers.py#L1600-L1601

In the same line, I think it would be useful to at once evaluate the other keywords to see which ones could be useful for html parsing.

Sure, I'll take a look.  It seems a bit cumbersome having to copy over args in 3 or 4 places to add them to read_html.  I poke through the code to see if there is a better way to add all applicable args.  Even without finding a better way to do things, it should be straightforward to use all of the FileParser args.
Please let me know if you have any suggestions.

It would be easiest to just pass around kwargs from TextParser in https://github.com/pydata/pandas/blob/master/pandas/io/parsers.py#L1546-L1601
Is there a better way to do that other than explicitly calling out the arguments in each of these places?

https://github.com/pydata/pandas/blob/0c6226cbbc319ec22cf4c957bdcc055eaa7aea99/pandas/io/html.py#L719-L721
https://github.com/pydata/pandas/blob/0c6226cbbc319ec22cf4c957bdcc055eaa7aea99/pandas/io/html.py#L743-L750
https://github.com/pydata/pandas/blob/0c6226cbbc319ec22cf4c957bdcc055eaa7aea99/pandas/io/html.py#L757-L760

[Current coverage][cc-pull] is 84.34%

Merging [#13575][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master     #13575   diff @@
==========================================
  Files           138        138
  Lines         51133      51133
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          43130      43130
  Misses         8003       8003
  Partials          0          0

Powered by Codecov. Last updated by [cc0a188...cfe786c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/cc0a188addb46f7b4986dce32947e66295f1bb3b...cfe786c7018ac4b7e322898c0e5c31fda56e6973?src=pr
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13575?src=pr

@jorisvandenbossche I added support for a few more arguments: keep_default_na, squeeze, and date_parser.
I also consolidated the argument definitions from being called in several places to only being enumerated in the read_html function.  This should make it easier to add more arguments to that function in the future.
I could not easily add dtype support since read_html uses the python engine.
Let me know if you want me to make more changes.

@gte620v The way of passing through looks good! Thanks
Regarding the extra keywords, maybe we should evaluate each keyword on its usefulness to add (sorry if I was a bit fast in pushing you to add more keywords):

keep_default_nan -> certainly good to add (needed if we also add na_values, which was the original issue)
squeeze / date_parser -> those are maybe less essential (the same effect can be easily obtained after parsing), so is maybe not worth the additional clutter in the long list of possible arguments

OK regarding not adding dtype for now (it's indeed not supported with the python engine), but can you then remove the note that it closed that issue?

Sure, will do!
Let me know definitively about squeeze and date_parser.  I can leave or remove.

@jreback Opinion on adding squeeze and date_parser keywords to to_html?
("it's easy to support" (just passing through to TextParser) vs "not essential keywords so only cluttering long list of possible keywords" (in contrast to the NaN handling keywords, the effect of squeeze and date_parser are easily obtained manually after parsing))

squeeze should not be added; its purpose is to return a Series; while this method returns a list of dataframes (always), I would raise if its not-None.
date_parser is kind of useless. you already have parse_dates to auto parse most dates, otherwise you use .to_datetime (usually with a format). To be honest I would blow that away from the csv parsers, but that's another thing. So raise here if its passed as well (a ValueError)

@jreback Thanks.  I removed squeeze and date_parser.  I think it is good to go.  Let me know if I misunderstood.

Sure, I can do that.

I added examples to the docs.  Let me know if you want a modification or if I need to add something someplace else.

minor comment. ping when green.

@gte620v Thanks a lot!

My pleasure!


Add support for whatsapp contacts

Is your feature request related to a problem? Please describe.
At the moment I can only bridge group chats from whatsapp. Giving the JID code of a contact in the form [country code + phone<EMAIL_ADDRESS>results in an error: please specify group's JID from the list above instead of the name<EMAIL_ADDRESS>Those group chats are of the form<EMAIL_ADDRESS>Describe the solution you'd like
The possibility of bridging whatsapp contacts is essential and shouldn't be too much work, since one of the used libraries already supports it: https://github.com/Rhymen/go-whatsapp. Adding support for the JID codes of plain phone numbers would be a big step forward.

I also would like to bridge single contacts. I tried using the JID code suggested with no luck. Does anyone know if it is only a matter of finding the correct whatsmeow JID?


⚠ Jenkins Plugins Artifactory has degraded performance

In 71a7433, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1183 ms

Resolved: Jenkins Plugins Artifactory performance has improved in c53e8ec after 15 minutes.


Fix edge cases with incompatible Xcode versions

This started as the fixes from #204 but that sort of fell apart. However, to test those changes I installed Xcode 8.3 but was running macOS 10.11. The Xcode app downloaded and worked but LSMinimumSystemVersion is 10.12 so some weird edge cases started cropping up. The technical details are in the commit messages.
To illustrate the problem, prior to these changes I saw:
$ ./bin/xcversion installed
Executable requires at least macOS 10.12, but is being run on macOS 10.11.6, and so is exiting./Users/justinscott/dev/xcode-install/lib/xcode/install.rb:515:i
n `fetch_version': undefined method `split' for nil:NilClass (NoMethodError)
        from /Users/justinscott/dev/xcode-install/lib/xcode/install.rb:460:in `version'
        from /Users/justinscott/dev/xcode-install/lib/xcode/install.rb:70:in `block in installed_versions'
        from /Users/justinscott/dev/xcode-install/lib/xcode/install.rb:69:in `sort'
        from /Users/justinscott/dev/xcode-install/lib/xcode/install.rb:69:in `installed_versions'
        from /Users/justinscott/dev/xcode-install/lib/xcode/install/installed.rb:18:in `run'
        from /usr/local/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'
        from ./bin/xcversion:12:in `<main>'

and with them I see:
$ ./bin/xcversion installed
Executable requires at least macOS 10.12, but is being run on macOS 10.11.6, and so is exiting.0.0      (/Applications/Xcode-8.3.app)
8.1     (/Users/justinscott/Downloads/Xcode.app)
8.2.1   (/Applications/Xcode.app)

It's probably worth squashing this all into one commit on merge. There's no need to have a history of the Spotlight replacement stuff.

Oh, I also wonder if somehow we can add these edge cases to the test suite. I probably should have thought about that already...

Only Rubocop is failing and after the last commit I don't think it has to do with any of the code I introduced.

Nice 👍  Is this ready to be tested and merged?

Sure is. For the record, here's what I see from my manual testing after the fixes: https://gist.github.com/JScott/b1c83d066986879edf12dcf6ae29ee17

Should I push a new release for this?

A new patch version would be nice. It vastly improves the user experience for someone with an incompatible Xcode.app somewhere on their system. Beyond the scary red text, the most disruptive problem I saw this fix was not being able to list Xcodes or simulators regardless of the Xcode you have selected. I don't know how much of a fuss it is to get a new version out but it feels more Ruby-like to have it gracefully handle a bad situation :)


Include logical/physical block size in BlockDevice API

Add new fields in BlockDevice API

DriveType
LogicalBlockSize
PhysicalBlockSize
HardwareSectorSize

PR #388 adds the fields to API.

PR #392 contains changes to fill in the new fields with details from sysfs probe.

PR #393 and #395 backports the api changes and sysfs changes to v0.4.x branch

All the changes required for the feature has been merged.
#388, #392, #393 , #395 are the related PRs


Avoid mocks reuse on test cases

More context on https://github.com/5afe/safe-client-gateway-nest/pull/291#discussion_r1169745379
This PR:

Moves the mappers' initialization to beforeEach functions on each test suite, so the potential risk of sharing state between tests gets removed.
Changes the related usages of mockResolvedValueOnce by mockResolvedValue so we assure we're not depending on the execution order and we're always clearing the state between tests.
Changes one resetAllMocks call by clearAllMocks, since it's not needed to reset the mocked functions implementations (the mocked instance itself gets recreated).

Coverage: 90.062% (-0.02%) from 90.082% when pulling 1ffc1eca27f8ddc8788c3b7424c2938edc500381 on respawn-instances-per-test into 9a7c0520b79e7dc676f0ed85711ceb7542a52766 on main.


Don't include "doc" folder into /Applications

I just use this puppet installer & got a "doc" folder into my /Applications folder containing a README & the licence. Maybe rename that folder into Limechat or put it somewhere else ?

Closing due to inactivity.


Exercises-w1

Exercises
Name
Marc Kunst
Class
Tech 4
GitHub username
MarcKunst
Bootcamp exercises
(https://github.com/MarcKunst/js-bootcamp)
Bootcamp notes
Komen er aan

👋 Thanks, we'll look at the exercises from exercises-w2 for your final grade!


How to integrate with torch data?

If a torch data is
a = torch.rand(3)
b = jt.float(a)

this can convert torch data to jittor, but how to convert jittor data to torch ?

Firstly, convert jittor var to numpy. Then you can use it in torch.
a = torch.rand(3)
b = jt.float(a)
c = b.data    # numpy array
d = torch.from_numpy(c)


[composer] textbox (grid) loses focus on each key stroke

create grid
create card and type in textbox
loses focus on each key press
also:

controlled component state change error (likely undefined value)
editor does not expand to fill space
focus ring issue

This also applies to the editor in Prompts.


System volume and player volume disparity

Occurs in Soundcloud plugin version 1, Nuvola player version 3.0.0 on Debian Sid.
Appears that system volume is set to player volume, but player volume is never adjusted to match system volume. Upon a new track starting playback or a paused track resuming playback, system volume is set to player volume.
This does not occur in the other Nuvola-wrapped services I use, namely Google Play Music.
Resulted in music being initially played at max volume, which was fairly unpleasant.
Glanced through source but couldn't immediately see what was the issue. Not very familiar with codebase though.

hi @a-johnston,
Thank you for taking the time to write about this bug.
On my computer, SoundCloud/WebKit default volume set to 100% never was a problem, as I implicitly set my other applications volumes based on it (I realise that now...). This "chance" setting of course cannot be a solution to this issue.
AFAIK, Nuvola API does not give access to system volume from a plugin. I am not sure it would be an appropriate solution either anyway.
I think some internal SoundCloud script resets the "system" volume on its own accord to match this set in the web page. I know there is SoundCloud API that allows setting the volume by user script. I will look into it and try at least to save the volume as set from the SoundCloud volume control.
In any case, the solution I have in mind may not allow you to set the volume from any "system" interface in a permanent way, you might have to set it from Nuvola/SoundCloud interface.

It's of course difficult to read through minified JS but I didn't see anything going on with the volume upon playback resuming in the various scripts the button fires events on the soundcloud webpage. It would be interesting if it were able to, anyways. I'll definitely play around with it, but for now setting the volume manually saves my ears.

Also I'm not sure how I missed this earlier because I'm sure I tested it, but it seems like the system volume is set to max volume even when the player volume is lower. You may have already observed this, but I figured I'd post it in case it would help pinpoint the issue.

hello @a-johnston
I observed the following:

the player volume is saved between sessions (probably in a cookie or such) and thus does not need to be saved in Nuvola configuration files
whenever the track being played changes (manual skip by pressing forward or backward button or picking a track, or automatic skip at the end of previous track) the system volume is reset to 100%, ignoring the player volume
if the played track is paused then resumed (with "enough" delay between the two actions), the system volume is set according to the player volume

My understanding of SoundCloud's API is that it is supposed to work with their widget, that it itself is supposed to be embedded (using an <iframe>) within a page provided by a third party. Maybe I do not have to embed it really, but anyway, this would mean to start over, because so far the plugin is based on SoundCloud main, "normal" page, which I assume to be different from the widget page.
So, instead of overhauling my code or trying to reverse engineer SoundCloud's JS, I propose to provide an option that, when the user enables it, pauses-waits-plays the current track whenever the 2 following conditions are met:

a track is currently being played
the [artist, title] pair has changed

Before that, could you confirm the observations I made are valid in your environment too?

I haven't been able to recreate having the system volume set to the player volume. What is "enough" delay for your observation? This is having pulled + reinstalled the latest two updates. I also haven't observed the behavior when pausing/playing via the console on the soundcloud page.

I observed that in Firefox (out of Nuvola), the system volume is briefly set to 100% (during a few milliseconds) before it is reset to player volume. This does not happen in Nuvola, but pausing then playing the track does it, if you wait a dozen milliseconds or more (delay seems to depend on some refresh cycle, I am still investigating). There are still many things I do not understand about SoundCloud volume... I observe none of this in Deezer, either on Firefox or Nuvola, and Nuvola's Deezer plugin has no line of code involved in volume control AFAIK.
Just so we are clear, what I call "player volume" is the vertical volume bar at the bottom player bar on SoundCloud web page (this bar does not appear until you start playing a track). The "system volume" is, to me, the volume of WebKit application in pavucontrol (I am using PulseAudio).
Anyway, if you cannot reproduce this on your system, I have to look somewhere else.

I have the issue that everytime the songs changes, the volume goes up again to 100% also when i pause and play music again but systemwide. The volumecontrol within soundcloud does not change at all. Iam on
KDE opensuse 42.1 Soundcloudplugin 1.1 Nuvolaplayer 3.0

I really do not understand this bug. It seems to me that it is related to or happening at WebKit backend, which is far from being accessible from a plugin. I can reproduce it on one of my computers and have been looking into it, but really I do not see a clean solution so far, just some JS tricks like a fast pause/play or such...
@fenryxo would you have any idea or advice as to where I could look at ?

Hello everybody. Thanks for your feedback. I'll probably get around to this issue as a part of the ticket "Check whether a web app volume slider is synchronized with a PulseAudio stream volume" tiliado/nuvolaplayer#139, currently tentatively scheduled for May 2016. For now, I recommend setting an appropriate volume directly in SoundCloud web interface.

Is the issue still present in the latest flatpak builds?


remmina: support building on macOS

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 244258 run on x86_64-darwin 1

1 package failed to build:

remmina

FAILED: src/remmina
: && /nix/store/12qf8ib757q3lvyssgrx9zvrpc525k2s-clang-wrapper-11.1.0/bin/clang -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno->
Undefined symbols for architecture x86_64:
  "_utimensat", referenced from:
      _remmina_file_touch in remmina_file.c.o
ld: symbol(s) not found for architecture x86_64
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

Would be great if you could throw in a desktopToDarwinBundle hook to make it extra shiny!

@ofborg build remmina remmina.passthru.tests


Elixir module references in references provider

We can try to register alias_expansion events in tracer. Nothing can be done for erlang modules though

Addressed in https://github.com/elixir-lsp/elixir-ls/pull/854


Update package.json for compat with Sencha tools

Removes the -dev suffix from version and adds attribute namespace which is created by the Sencha Cmd tool upgrading the package. As all components reside in that namespace anyway, this should be good to go.

Looks good to me. Please merge.

Please merge.

Ahh you don't have sufficient rights, correct?


Public version of RawTable::try_with_capacity

We already expose RawTable::try_reserve, but do not expose RawTable::try_with_capacity. The latter should probably also be public (though without the fallible argument).

I don't have any objection to exposing this as well.

Fixed in https://github.com/rust-lang/hashbrown/pull/174


Issue 631 run services with supervisor

Use the supervisor as the main process. The start-mailserver is started
from the supervisord and then this process triggers others.
Defined some default variable in the Dockerfile. In order for
supervisored to build the command lines the ENV variable need to be set.
Therefore the defaults are defined.
Some processes are not single processes like postfix and fail2ban and
they have a wrapper. The wrapper takes care of proper shutdown and checking
if the process is running or not. Supervisored will restart the wrapping
script if the process is gone.
Increased some delays between tests because sometimes they where to short
for all containers to be running.

Restarted build.

@tomav pushed the changes you requested.

@tomav I set the delay back to 20 seconds but some first check (and now to) fails when it is to low. I think it should be 40 (is was good for my testing, 30 didn't do it for me).

@tomav @alinmear I have updated the PR with tests and they pass all now.
Can someone review and accept if ok?

Thanks!
I'll release a new version soon with these changes.


Enable MQTT in default broker config

I have merged this.
you will probably have to close it since the apache-github integration seems broken


[Site Settings page] Wrong error message in Site Settings for files more than 500K

Wrong error message in Site Settings view if Admin chose as a Favicon file  more than 500K
Steps to reproduce:

Go to Admin user to Site Settings.
Chose file as a Favicon whose size is more than 500K
Click Apply button.

Expected Result:
Error message: "Favicon has %{file_size} that is not between required range"
Actual Result:
Error message: "Favicon Translation missing: uk.account.site_settings.validations.size"

did you mean more than 500kB?))

Fix issue. The problem was resolved.


Consider splitting windows_gen crate to improve build time

https://github.com/microsoft/windows-rs/pull/661#issuecomment-813733198

I looked at this briefly but it would add undesirable complexity and complexity is a bigger problem right now. Ultimately, #432 should solve the build time issues more effectively anyway.


[mysql] make sure that all tests pass for mysql warehouse

https://github.com/sodadata/soda-sql/commit/ca9c44e66dc0858cacb6fd899f98c5ef50988591


OSD-2417 letsencrypt maintenance error metric

/hold

@cblecker @dustman9000 any changes to this you'd like to see?

Looks good to me, Christoph did have a question about checking an error code that I think we can address later when we know more about LE response codes.
/lgtm


Trouble with statsite on fresh install

I've just done a fresh install on Ubuntu 14.04 using synthesize and my metrics aren't appearing in graphite. I think it might be something to do with statsite but I'm having having difficulty figuring out what.
(Using netcat) metrics I send to port 2003 appear as expected and metrics from collectd are appearing.
(Using tcpdump) I can see incoming metrics on port 8125.
My application works when pointing to another graphite instance but not the fresh install.
All configuration is default.
Any help would be greatly appreciated.

I've just reinstalled on another fresh aws instance. *.wsp are now appearing on disk but looking at the json return from graphite-web using format=json it looks like all values are null.
This is at odds with the inbound traffic I can see which looks like: tcpdump metric.name:45|ms

Apologies for letting this issue go untouched for so long. I doubt this is still a valid issue but if it is, please try the latest release and report back.
https://github.com/obfuscurity/synthesize/releases/tag/v4.0.0


ossl_decoder_cache_flush(): Do not raise an error if there is no cache

This function can be called during OPENSSL_cleanup() when the cache was already flushed and deallocated.
Fixes #22939

This pull request is ready to merge

Merged to the master and 3.2 branches. Thank you for the reviews.


Remove some dead/unused code

None of our current particles use setBusy and it's probably better for
this tracking to be the responsibility of the inner-pec. If a particle
is able to defer execution the PEC should be aware that it is happening.

Wasn't the purpose of setBusy/setIdle that they were a lightweight (lo-fi) way to do that?
At any rate, no objection to removing these if they're unused.


post translation - check instance translation languages

enable translation only if matching instance translation language is available

but leave guess translation up


Communicates with virtual machine over SSH

This PR removes the need for mounting a shared folder in the virtual machine to transfer credentials and the start command from the host machine to the virtual machine. Instead, Tartelet now has the host machine communicate with the virtual machine using SSH. This fixes #64.
As a consequence of this, the pre- and post-scripts are no longer supported as the old approach of transferring the pre- and post-scripts is not compatible with the new approach. If there is demand for Tartelet to support pre- and post-scripts, then we'll figure out a way to support this again.
The PR also brings a lot of modifications to the codebase that I've been meaning to make for a long time. Specifically, the codebase has become much simpler and smaller with fewer packages and targets.
I'm fully aware that it's bad practice to put a ton of unrelated changes in a single PR, and I'm sorry that's where we're at. My priority has been to get these changes out ASAP rather than following best practices.

@simonbs the release don't include the .app file

@leohidalgo Sorry! I was in a rush to get this update out before heading on vacation next week. I've just uploaded the .app file to the release.


Declarations are not generated for a high order component

TypeScript Version:  3.2.0-dev.201xxxxx, 2.9.1, 3.1.3

Search Terms:
declaration, high-order, hoc
Code
export function Executor(func: () => any) {
  class ExecutingClass {
    execute() {
      func();
    }
  }

  return ExecutingClass;
}

Expected behavior:
Running both tsc and tsc -d produces no errors.
Actual behavior:
When I'm running tsc on this code, everything works fine.
When I'm running tsc -d on this code, I have this error:
hoc.ts:1:17 - error TS4060: Return type of exported function has or is using private name 'ExecutingClass'.

1 export function Executor(func: () => any) {

It is still possible to generate typings for this if you change code to this:
export function Executor(func: () => any) {
  const ExecutingClass = class {
    execute() {
      func();
    }
  }

  return ExecutingClass;
}

export default Executor;

We were hit by this when we were migrating to use project references (composite enables declaration). We have several React higher-order components and each one returned an error similar to the one above.
import React, { Component, ComponentType } from 'react';

// ERROR ❌
// Exported variable 'hoc' has or is using private name 'WrapperComponent'.
export const hoc = <ComposedProps,>(ComposedComponent: ComponentType<ComposedProps>) => {
  class WrapperComponent extends Component<ComposedProps> {
    render() {
      return <ComposedComponent {...this.props} />;
    }
  }

  return WrapperComponent;
};

We worked around it by switching from class declarations to class expressions (as per above), or from class components to function components.


Side navigation links (en-us)

There are some link pointing to the zh-cn documentation in: https://github.com/neo-project/docs/blob/master/docs/en-us/toc.yml
Not sure if toc.yml is auto generated so opened issue.

Fixed in  #1264. Thank you for reporting the mistake.


Ensure that apps can be installed on the latest version of Android

This will help test PRs like this: https://github.com/flutter/flutter/pull/98076.
Ideally, we use Android emulators to test these type of changes.
The device lab doesn't have a device running Android S to my knowledge.
cc @GaryQian

Closing because the bug has not been updated for more than one year.
Feel free to reopen any bugs that you believe are important but please provide updates on how to resource the fix of the bug and what can be done to prevent the issue from not getting updates for another year.


Add details for building V8 on p/z linux

We should add an appropriate license to the Dockerfiles.

@joransiu  Good suggestion. Looking at other nodeshift projects, they only have a single LICENCE file in their repo with Apache License content. Should we do the same or provide headers per file.

@joransiu Good suggestion. Looking at other nodeshift projects, they only have a single LICENCE file in their repo with Apache License content. Should we do the same or provide headers per file.

I think you'd want both a LICENSE file, and a copyright with license info and/or reference, in each file header.

a LICENSE file as well as headers are now added to Dockerfiles and scripts.

Please review this PR once more when you have a chance.


$serverMFALevel "undefined" issue

Type

[x] Functions: $serverMFALevel

Example code used:
$serverMFALevel[$guildID]

The unexpected error message or issue:
undefined

Information:

aoi.js version: v5.5.5
node.js version: v17+

v5 will no longer receive updates, due to v6.0.0 being worked on.
Within less than a month, it should be released.


Expect Scheduled Deadline based on Deadline name

Currently, it is not possible to define a deadline name in Aggregate and Saga fixtures. However, it is possible to achieve deadline name matching using matchers which is not very convenient. We should add overloads for checking the deadline name.

Closing this issue as it has been resolved in pull request #1306


Azure Devops Pipeline

Hi there,
I am trying to use Azure Devops Pipeline to switch installed node package versions on our build machine. Running a very basic script "nvm use 6.10.0" in a powershell script, I get the successful "using 6.10.0" message, however when checking nvm list on the build machine, it is still using version 10.10.0 (also shown in the screenshot).
It appears only manual nvm use script works, is this a matter of credentials?
Thanks in advance,
Script:
nvm use 6.10.0
nvm list

nvm does not support powershell; the only way it works on windows is on WSL/BashOnWindows.
I believe you’re using nvm-windows, which is a different project.

nvm does not support powershell; the only way it works on windows is on WSL/BashOnWindows.
I believe you’re using nvm-windows, which is a different project.

Oops, you are correct, wrong repo!


Patient Counts being invoked for too many patients at a time

I've just noticed what I believe is an error - at the very least an inefficiency - in the patient counts API as used by the Leeds PHR UI (and probably in Ripple too).  This is the API I'm referring to:
GET /api/patients/{patientId}/counts
The original idea was that this API should be invoked for ONLY those patients currently displayed in the Patient Listings screen - ie the current (up to) 10 on display at any one time, so we can as quickly as possible, with the minimum of overhead, fetch and display the numbers of orders and results for each patient displayed for the selected setting (eg Neighbourhood).
What is actually happening is that requests are being sent for ALL patients in that setting.  So, if you select Neighbourhood, around 30 requests are sent out, instead of just the 10 currently on display.  This hammers the back end, largely unnecessarily, and slows down the screen.
Can I suggest this is fixed?  It will help improve the responsiveness of these screens

@robtweed
Rob, do I understand correctly, that I need to send requests only for current 10 patients depending on pagination position? Instead of requests for all patients?

Yes that is what it should do - only retrieve the counts for the patients currently on display.  So each time you select a next page it should fetch the counts for the new page of patients.
Currently, if there are 200 patients in a group, then it's sending out 200 count requests, which is very wasteful and hammers the back-end needlessly.

Hi @robtweed

Is there a way to receive from backend the total number of users corresponding to the search parameter?
And also, is there a way to receive these users with some limit?
(For instance, if I pass the parameter offset0 -> backend send the first 20 users, from 0 to 19)?

Could you please advise?

@tony-shannon
Oleg reduced the number of counts so that they are only dedicated to the certain page only.
When I do testing I see that it gets all the patients but not by page - https://prnt.sc/jzv62s
Do we need to get only that number of patients which is corresponding to the search parameter ? so it sends only 10 requests per one page and all the rest by going through next pages ?

@tony-shannon Sorry, we might have to check this issue one more time: last time I checked it, it was working but now it again loads all counts. I'll try to update you today till evening regarding this problem.

OK thanks @kuvakina

thank you

@kuvakina  will update this issue with more feedback
NB This issue can be parked for now, as focus on PHR aspects currently

@tony-shannon
UPD:
I've just checked this issue on the site: it's working correctly.
I'll move it to Testing and will monitor it.

@tony-shannon
It's still working correctly. Could we move this issue to Done?

Working fine.


[TALK]talking with sit

How to treat the decline of computing power caused by version update and bug?
About the income after 0.125, why hasn't it been sent to the wallet for a week?

You need to claim your 0.875 manually in "NFT" tab or in command line after a week.


iOS 9 Support: Research NativeScript for iOS Build Using Bitcode

As part of an "app thinning" incentive apple introduced "bitcode submission". At its current state, bitcode submission is mandatory for watchOS, and optional, but default, for iOS. We should research if we can submit the NativeScript for iOS framework build with bitcode enabled. Our current concerns are we may have problems with our FFI implementation.

App Thinning
HN Bitcode

We've done the research, and the results will flow naturally as subtasks in #182.


.yaml file for JRA55-DO dataset

.yaml file for JRA55-DO dataset is added to DataAtm GC.

@mfmehari, I'll have more updates on this file later. I can't do it now because I can not copy the data into the make_bcs location.

@mfmehari, I'll have more updates on this file later. I can't do it now because I can not copy the data into the make_bcs location.

@zhaobin74 okay I have changed the status of the PR into draft.

I have updated the JRA55-DO yaml file.
Note: to be able to use this version, one must update MAPL to at least 2.51.2.


Breadcrumbs :hover showing underline under separator when using  instead of list

Showing underline under a seperator

@cvrebert This issue was already closed by #18789 ?

Indeed.


Update Slack link

same as #2619

the link is still now working

the link is still now working

It is working for me, what error did you see?

@vancexu

For https://join.slack.com/t/uber-cadence/shared_invite/enQtNDczNTgxMjYxNDEzLTQyYjcxZDM2YTIxMTZkMzQ0NjgxYmI3OWY5ODhiOTliM2I5MzA4NTM4MjU4YzgzZDkwNGEzOTUzNTBlNDk3Yjc

For https://join.slack.com/t/uber-cadence/shared_invite/enQtNDczNTgxMjYxNDEzLTQyYjcxZDM2YTIxMTZkMzQ0NjgxYmI3OWY5ODhiOTliM2I5MzA4NTM4MjU4YzgzZDkwNGEzOTUzNTBlNDk3Yjc

I see.
Can you try https://join.slack.com/t/uber-cadence/shared_invite/zt-dvjoiacm-1U2UM4R4mMxKhaRogEx_OQ ?


request translations for sync switching backup

Task/Issue URL: https://app.asana.com/0/72649045549333/1208849498157786/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5321  👈 (View in Graphite)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.