Documentation & Code review

Risk of recit repository
line 3: importing dataset:  column error when importing via read_csv(url(...)). No problems from raw data on user desktop.

Risk of recit repository
line 7: are -1 values in tibble missing data? was that explained anywhere I missed?

Risk of recit repository
line 12: suggestion : maybe explain AIC scores a bit.. Lowest score is best, yeah?

Risk of recit repository
line 14 : suggestion : could we explain, in a non-technical way, what the estimate score illustrates?

Risk of recit repository
Summary: this is brilliant statistical coding. If we can attach a down to earth narrative to these data, functions, and outputs, the workshop will be a breakthrough A++ IMO.
~Avery

pt. 2, Risk of violent recit
Data import has verbose warning script. dim() output is == on local environment.

Line 9 in part 1 & Line 8 part 2:
Good place to explain or re-iterate narrative about what the recidivism score is.

pt. 2, Risk of violent recit
Line 12: a lot is going on in the line. As elegant as the code is, it may help to include an explanation of what (with categorical DV) and (with continuous DV) are.

Algorithm Accuracy Analysis
line 7: include narrative explanation of what these organized decile scores are expressing?
line 8: you are employing a cox hazard model here? Is there a simple way to describe it? what is Surv()? What is survival rate in this context? Why so much variance with Native Amer. category?
line 10-12: awesome visuals, excellent opportunity to distill findings into simple, "one sentence" type statement?
line 13: awesome that you went into python here. This transition may pose challenges if people are following in workshop. I think it is really cool myself. 👍
line 13: may help us to explain what a false positive /negative implies in this circumstance.
Again, super brilliant stuff. Imagining a workshop: the code speaks for itself, explaining a bit about the statistics and implications of outputs, "what it means" from a model -> reality standpoint would be valuable narrative threads to support the body of work here. +1000 overall. :)

01_compas_analysis_revisited-checkpoint.ipynb
Intro: could we add links to the PBS video clip and background articles as prep material, something we circulate in our registration email? It may help us to have participants queued in on context before we begin.. It's possible participants enroll and not prepare, this narrative intro is key to everything else making sense to a beginner's eyes.
Line 5: change ae to ea in 'two_yaers_violent' ?
Line 28:  It may help to add narrative explaining differences in these stratified outputs. What is being expressed here in the decile scores?
Line 30: in the other notebooks you evaluated different modeling methods with an AIC score. Could that be applied here? If so, should it?
Line 37: concordance is advanced stat terminology? Would there be a concise way to explain concordance and the difference of values reported?
Line 47: It would be awesome to explain concepts of overprediction and underprediction here.
Line 54: change "two year" -> "two years"
All together awesome stuff +1. Again pushing accessibility, explanation of stat methods, particularly the surv() functions, adding ylim(.25) to the output, a summary at the end of notebook is all I can suggest on my end.

@Averysaurus I think these comments are all great and related to accessibility issues. Can you add some multimedia references (e.g., YouTube video clips) to the R markdown files? Also, please feel free to edit those markdown files if some parts are too dense, etc.

Part 3: notes, interpretation challenge.
what are hazard ratios?
Hazard is the instantaneous potential for change in an outcome per unit of time at a specific time, relative to the size of the  population (where the event has not occurred yet), at time t. Hazard ratios compare hazard values between exposure status,(in this case race or other identity category).
ln 84 - 93: we should explain what the x-axis is, what those numeric values mean.
ln 102: we may want to restructure hazard ratio visualizations to look more like this:
typical HR vis
also Python in an r-markown. Can we make it work simply?


Revert "remove version number for shared package (#1838)"

This reverts commit 317755d10c1f054e128fd75a82e08849b60cca42.

Codecov Report

Merging #1853 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1853   +/-   ##
=========================================
  Coverage     84.74%   84.74%
  Complexity     4610     4610
=========================================
  Files           438      438
  Lines         18316    18316
  Branches       1936     1936
=========================================
  Hits          15521    15521
  Misses         2127     2127
  Partials        668      668

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bafb66...d42bd48. Read the comment docs.


[Feature] Dropdown Checkboxes for theme options

Before Requesting

[X] I found no existing issue matching my feature request
[X] This request is related to Millennium, and not a request for a specific theme/addon

Describe the feature you'd like!
Dropdown with checkboxes inside which the user can select according to his wishes.
of course, the individual options should also be bound to a CSS or JS file
like this:

Anything else?
No response

Suggest a skin.json formatting you'd like to see it use.

here i have no idea
maybe:
        "What's New": {
            "description": "Customize the What's New section",
            "default": "Compact",
            "type": "dropcheck",
            "values": {
                "Show": {},
                "Compact": {
                    "TargetCss": { "affects": ["^Steam$"], "src": "options/whatsNew/compact.css" }
                },
                "Hide": {
                    "TargetCss": { "affects": ["^Steam$"], "src": "options/whatsNew/hide.css" }
                }
            }
        }

closing in favor of #93, since it seems like the perfect purpose for that

uh? but they are 2 different things

what could be the difference between that and making a tab specifically for that dropdown ? it just seems redundant with tabs

the dropdown checkboxes have nothing to do with the tabs, these are 2 completely different requests
#93 is for tabs and #92 is for checkboxes in dropdowns

actually, this could *maybe* be repurposed to applying css properties for specific elements, i.e.
"Hide titlebar buttons": {
	"type": "checkboxdropdown",
	"description": "Removes titlebar buttons from the main window",
	"property": "display: none !important",
	"values": {
		"Big Picture": {
			"default": true,
			"selector": "._3cykd-VfN_xBxf3Qxriccm > :nth-child(4)",
			"patch": {
				"TargetCss": {
					"affects": ["^Steam$"],
				}
			}
		},
		"Steam News": {
			"default": true,
			"selector": "._3cykd-VfN_xBxf3Qxriccm > :nth-child(1)",
			"patch": {
				"TargetCss": {
					"affects": ["^Steam$"],
				}
			}
		},
	}
}

Yeah, two very different requests, not sure what @ricewind012 is talking about.


Upload application logs to artifacts from test_suites

Problem
In CI, the application logs are interleaved with the controller logs. Sometimes when the controller fails due to an error, it doesn't upload all the application side logs.
Change overview
This change will upload the applications logs to CI artifacts. So the logs should be isolated and complete.
Testing
Ran test_suites.sh locally to ensure the logs are getting copied to the correct file and folder.
The CI run will test that the logs get uploaded to artifacts.

Fast tracking this, as this will add logs to our failing suites we're tying to debug.


chore(tests) add stream_rpc listener to custom template

Some plugin tests rely on the stream_api to pass

Summary
SUMMARY_GOES_HERE
Full changelog

[Implement ...]
[Add related tests]
...

Issues resolved
Fix #XXX

duplicate of #6686


Add a CONTRIBUTING.md for contributors

At Robothon @benkiel put out a request for contributors to write tests and documentation for FontParts. So I would like to answer the call.
The problem is that I think that the prospect is a little bit daunting to someone like me who has not done such things on a "professional" level before. Maybe one of the team here could write a short guide for contributors (I don't know, similar to https://github.com/electron/electron/blob/master/CONTRIBUTING.md)? So we can contribute but not dirty up your house, so to speak.

@colinmford Yes, 100% agree. I'm working on getting things organized in Projects and putting together a doc on this. Look for something later on in the week.

count me in!
im a bit late with adopting the latest version of RF, but I will catch up quickly

💥💥💥


UI Pages - All broken

hello @barreraalexander
All pages linked in the navigation bar should work.
Please take a look. Ty!

Validated. Closing.


How does one create the aggregate table in the first place?

I think it would be good to have more information on how to add the aggregate table, not just adding aggration.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 651949b2-ae84-a7c1-d012-e41891e5931c
Version Independent ID: bb6928af-2e51-320e-e69b-577f9bbdcd17
Content: User-defined aggregations - Power BI
Content Source: powerbi-docs/transform-model/aggregations-advanced.md
Service: powerbi
Sub-service: pbi-transform-model
GitHub Login: @Minewiskan
Microsoft Alias: owend

Thanks for your comment, @JonathanBrune. This issue has been assigned to the doc author for review.

Clearing backlog. This issue will not be addressed.


Fix mysensors overwriting gateway in GATEWAYS

Description:
GATEWAYS was a dict, so would overwrite item if key was the same. This
would happen when using multiple MQTT gateways, since the device id is
the same (mqtt).

Fix by changing GATEWAYS from dict into list.

Example entry for configuration.yaml (if applicable):
mysensors:
  gateways:
    - device: mqtt
      topic_in_prefix: 'mygateway1-out'
      topic_out_prefix: 'mygateway1-in'
    - device: mqtt
      topic_in_prefix: 'mygateway2-out'
      topic_out_prefix: 'mygateway2-in'
  version: 2.0

Checklist:
If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

You can earn 💯  internet points if you migrate from GATEWAYS to storing it on hass.data.

Ok, I'll do it.

@balloob Can I cash out my :100: points?

Beautiful !


Use PATCH not PUT for updating objects

Hello!
I want to use skip property in Weaviate, so some properties on my schema are not part of the generated vector.
I then want to be able to update a skip'd property, and it should not regenerate the vector, because that was the only property I updated, and it is not part of the vector.
It doesn't work currently. This is because weaviate-ruby is sending PUT rather than PATCH. I.e. it's replacing the entire object, which results in it regenerating the vector anyway, even if I'm only wanting to update a single, skipped property.
Suggest you have separate update and replace methods, which trigger PATCH and PUT respectively.
I forked the repo, and made this change myself, and it seems to work OK for me.

@asgeo1 Would you be open to issuing a PR for this change please?

Any progress on this? Just ran into the same issue. @andreibondarev maybe you can pull the changes from Adam's fork?

@obie I didn't see @asgeo1's fork. Is there one?

Sorry I didn’t actually check, just going off what he said
On Nov 18, 2023 at 11:29 AM -0600, Andrei Bondarev @.***>, wrote:

@obie I didn't see @asgeo1's fork. Is there one?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hello, sorry I hadn't gotten back to looking at this issue. My fork is here: https://github.com/bluefrogsoftware/weaviate-ruby, I sent a PR if you want to look at my changes. If it doesn't pass CI, I'll take a look at the specs tomorrow.
The change I made is a breaking change though, since is changes how the existing update method works. Not sure if you're OK with that?
I think there was also some issue with replacing existing properties on a class, but I haven't resolved that one yet.


Generating wrong sql code

I got the following SQL:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'sort' in 'where clause' (SQL: select * from `clients` where `clients`.`deleted_at` is null and `sort` in (created_at, desc) order by `created_at` desc)
When using return $this->model->pimp()->get(); on my ClientRepository, also I'm using the following url api/clients?sort=created_at,desc

I'm trying to reproduce that but so far no luck. Did you customize the package in any way, like changing default names of sortable fields? Or did you just add "use Pimpable" to your model?

Using version ´"jedrzej/pimpable": "^0.0.3"´´, also, just added use Pimpable and and pimp() behide some queries.

Could you check what version of "jedrzej/searchable" are you using? It's one of the dependencies, maybe you have some older version. If it's not 0.0.7, run composer update

Well, since Im using the pimpable package..
  "require": {     "jedrzej/sortable": "0.0.*",     "jedrzej/searchable": "0.0.*",     "jedrzej/withable": "0.0.*"   },
That shoud get the latest version, right? Also, I've ran composer update and everthing is updated.

Could you execute "dd(Input::all());" before the return statement and paste the result? As I said, I'm not able to reproduce this issue, I added the trait to one of my models, put the same parameters in the URL and the generated query is ok, so maybe there are some more parameters in the input.

Nop.
array:1 [
  "sort" => "created_at,asc"
]
````

Let me show my code is made.
Client
class Client extends Model
{
    use SoftDeletes;
    use PimpableTrait;

    protected $table = 'clients';
}

AbstractEloquentRepository.php
abstract class AbstractEloquentRepository
{
    /**
    * Return all results
    *
    * @return Illuminate\Database\Eloquent\Collection
    */
    public function allPimped()
    {
        return $this->model->pimp()->get();
    }
}

EloquentClientRepository.php
class EloquentClientRepository extends AbstractEloquentRepository implements ClientRepository
{
    protected $model;

    public function __construct(Client $model)
    {
        $this->model = $model;
    }
}

ClientRepository.php
interface ClientRepository
{

}

ClientController.php
class ClientController extends Controller
{
    use Helpers;

    protected $repository;

    public function __construct(EloquentClientRepository $repository)
    {
        $this->repository = $repository;
    }

    public function getClients()
    {
        return $this->response->collection(
            $this->repository->allPimped(),
            new ClientsTransformer()
        );
    }
}

And the error given
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'sort' in 'where clause' (SQL: select * from `clients` where `clients`.`deleted_at` is null and `sort` in (created_at, desc) order by `created_at` desc)

Thanks for the code, I'll try it out locally later today.
In the meantime... Query that is passed to searchable package is built (incorrectly in your case) in PimpableTrait::scopePimp().
There is a line
$query = $query ?: array_except(Input::all(), [$this->sortParameterName, $this->withParameterName]);

Could you add
dd(Input::all(), $query, $this->sortParameterName);

after that and paste the output?

Here we go
array:1 [
  "sort" => array:1 [
    0 => "created_at,desc"
  ]
]
[]
"sort"

Thanks, I think I know what's going on, I'll fix it this week.
The reason it didn't work for you but worked for me is that I have defined list of searchable fields for my models, and you don't, so all fields are searchable in your case.
As a workaround, till the issue is fixed, you should define a list of searchable fields in your model and it will solve the issue - you can see example here: https://github.com/jedrzej/searchable#setting-up-searchable-models

First, we made a little mess here.
The issue is with sortable package - this is why I made the pull request, totally mess, haha -, Now I'm using only the sortable trait and worked well.
Thanks a lot for your help. :+1:

I have the same problem with the query:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'sort' in 'where clause' (SQL: select * from `clients` where `clients`.`deleted_at` is null and `sort` in (created_at, desc) order by `created_at` desc)
Is this issue still open, because I saw that the pull request has been merged?
It is not possible to use:

public $searchable = ["*"];

on the models.

@inov the issue is still open. It's not trivial to fix, as the fix might not be backwards compatible.
As a workaround, till the issue is fixed, please explicitly list the searchable columns in $searchable attribute.

Ok. thank you for the answer. With the workaround the package is working perfectly. With the fix it would be more dynamically implementable for me, so hope you will be able to fix it sometime. Thanks.

Hey @inov @pedrommone,
I've just pushed new version of searchable bundle that excludes parameters used by related sortable/withable packages from the query. It should solve the issues you had.
Cheers
jedrzej


intensity scaling in construct-atlas

Sorry, is there is a way to switch off intensity scaling for atlas construction?
Thank you.
Best wishes,
Alena

Hi Alena, yes, there is. In the configuration file of the atlas, the rescaling entry is simply passed on to average-images. I think you can set this configuration entry to "none" (null might also work instead of a string value) to disable the rescaling.
See average-images help on -rescale option.
See example construct-atlas configuration with rescaling parameter.


init release-0.6

Hello,
Just wanted to get the discussion started for cutting a new release to include changes since 0.5: #49, #50, and #51. I am not sure what the process is exactly... There was PR #47 for 0.5, but that went to release-0.5 branch... So I imagine this should go into release-0.6 branch that someone should create? Anyway just looking for guidance and to get the process going for a release if it's agreeable with everyone to publish a new release. Thanks.

@wanjunlei Would you create a doc to elaborate how to release a version?

@wanjunlei Would you create a doc to elaborate how to initiate a release?

Hello,
Just wanted to get the discussion started for cutting a new release to include changes since 0.5: #49, #50, and #51. I am not sure what the process is exactly... There was PR #47 for 0.5, but that went to release-0.5 branch... So I imagine this should go into release-0.6 branch that someone should create? Anyway just looking for guidance and to get the process going for a release if it's agreeable with everyone to publish a new release. Thanks.

@bojand I had created a branch release-0.6, the version 0.6.0 will be released based on this version. Do you still have to make changes to version 0.6.0? If not, I will release 0.6.0 later.

@bojand I had to write a release doc to elaborate on how to release a version. Do you want to release the v0.6.0?

@bojand I had to write a release doc to elaborate on how to release a version. Do you want to release the v0.6.0?

As @wanjunlei  mentioned,  @bojand you can follow the https://github.com/kubesphere/fluentbit-operator/blob/master/RELEASE.md to make necessary changes and then submit your PR to release-0.6 branch, and we'll push the docker image and create v0.6 release for you.


Moar perf

benchstat:
goos: darwin
goarch: arm64
pkg: github.com/cristalhq/builq
                 │   old2.txt   │              new2.txt               │
                 │    sec/op    │    sec/op     vs base               │
BuildSimple-10      298.5n ± 3%    273.6n ± 1%  -8.36% (p=0.000 n=10)
BuildManyArgs-10    665.6n ± 1%    651.6n ± 1%  -2.10% (p=0.002 n=10)
BuildCached-10     0.6232n ± 0%   0.6232n ± 0%       ~ (p=0.469 n=10)
geomean             49.84n         48.07n       -3.56%

                 │    old2.txt    │                new2.txt                │
                 │      B/op      │     B/op      vs base                  │
BuildSimple-10       864.0 ± 0%       752.0 ± 0%  -12.96% (p=0.000 n=10)
BuildManyArgs-10   1.188Ki ± 0%     1.078Ki ± 0%   -9.21% (p=0.000 n=10)
BuildCached-10       0.000 ± 0%       0.000 ± 0%        ~ (p=1.000 n=10) ¹
geomean                         ²                  -7.55%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                 │   old2.txt   │              new2.txt               │
                 │  allocs/op   │ allocs/op   vs base                 │
BuildSimple-10     7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=10) ¹
BuildManyArgs-10   14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=10) ¹
BuildCached-10     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                       ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

Codecov Report
Patch coverage: 100.00% and project coverage change: +4.76 :tada:

Comparison is base (195ba9b) 95.23% compared to head (9c7c35c) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #25      +/-   ##
===========================================
+ Coverage   95.23%   100.00%   +4.76%
===========================================
  Files           2         2
  Lines         147       165      +18
===========================================
+ Hits          140       165      +25
+ Misses          6         0       -6
+ Partials        1         0       -1

Impacted Files
Coverage Δ

builq.go
100.00% <100.00%> (ø)

write.go
100.00% <100.00%> (+7.95%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Show long file and folder names on hover in the file explorer

VSCode Version: 1.3.1
OS Version: Win10 Build 14393

Steps to Reproduce:

Expand a couple folders deep (such as the contents of bower_components)
Watch your file and folder names get cut off
Profit

I'd like to see a tooltip or something that displays the full file or folder name on hover if it's cut off. This also makes multiple files that start with the same value impossible to tell which is which since they're clipped.
A horizontal scrollbar in the explorer might be nice as well, but the tooltip would be enough.

Can't reproduce both in Windows and macOS.
File labels do have tooltips, are you sure you are waiting enough time in order for them to appear?

@joaomoreno I get tool tips when the file is in the Open Editors section, but if I open a folder then none of that tree view, aside from the top level item, has tooltips. Once I open one of the files then I'll get a tooltip, but only in the Open Editors section, the entry in the folder tree view still lacks a tool tip.

This is odd. Can you open the Developer Tools, and inspect the DOM nodes in there? I'm pretty sure they have a title attribute.

There's no title attribute on those elements.
I just installed the insider build and that has title attributes. It looks like this was fixed a few days ago in 8cf6ff05c266ab310e52878d040ba9d6e5490ad3 and just hasn't made it into a stable release yet.

Oh wow! My bad, I just assumed this had always been there. Thanks for looking into it, great investigative skills. 👍


How to deal with text?

When drawing stuff with OpenGL, you would normally use something like FreeType to render text and use that in your rendered output. How should I approach that with this library (or, for that matter, @kmamal/gl directly), given that we're not working in C here? What would the most practical integration point be? As I couldn't find any text-related APIs within this library.

Ah, well, I'm not using FreeType in any particular way yet - as I wasn't sure what the most effective (and especially performant) approach would be here :)
I assume that combining the canvas approach with OpenGL would take the form of just using the canvas target buffer as an OpenGL texture, or something along those lines?

I assume that combining the canvas approach with OpenGL would take the form of just using the canvas target buffer as an OpenGL texture, or something along those lines?

Yeah, that's what I was thinking. It's the simplest method I'm aware of. If you plan to use text for gui elements only then you can pre-render all the canvas buffers. If you use a fixed-width font you only have to make a single texture containing all characters and render text using uv coordinates. Performance should be excellent for both these cases.


Pass date to renderDay()

renderDay() method receives date prop, that was passed to Calendar. This feature allows rendering of special day cell style when date param is pointing to that cell

Compare day to the date you started with (when the mutation fix is applied (v3 release) to achieve the same result?


closes #542 Create "AWS SAM" SVG

Looks great, thanks.

Deploy preview for landscape ready!
Built with commit 200b11e884eaad81f69c02cd601dc746ec07aabe
https://deploy-preview-544--landscape.netlify.com


Consistent permutation test results in existing release (1.0.1) vs project head (1.1.0)

Hi - Wanted to know if the results of a ttest permutation test pvalues are consistent between both versions (conda installer gives me version 1.0.1) which is different from code in project head (which is 1.1.0). My question relates the output of the test; in the 1.0.1 version the calculation is made using np.mean(permute_t <= t) while in the head version the pvalue is obtained by np.mean(np.abs(ts) > np.abs(t)). It seems that the comparisson logic is flipped between both (so not sure if pvalue in 1.0.1 version would be obtained by 1-np.mean(permute_t <= t).
Thanks for clarifying!

@asalcedo29 Thank you very much for the comment, I will check this. I recently did a rewrite of the tests and I noticed some discrepancies between the implementation and what I found in references. So it may be that, but I will check again. Perhaps I just introduced a mistake.

Thanks for the response @HDembinski . Wondering if when you tested this the results you got were consistent between the new version and the existing release. Also, is there a plan to update the version to 1.1.0?

Yes, once the work on the permutation tests is finished.

Ok, I finally checked this. The new implementation is consistent with scipy.stats.ttest_ind, so the change was intended. Either way, I hope there was no change in the p-value even if the definition of the test statistic is now different.
>>> from resample.permutation import ttest
>>> from scipy.stats import ttest_ind
>>> rng = np.random.default_rng(1)
>>> x = rng.normal(5, 2, size=100)
>>> y = rng.normal(3, 2, size=100)
>>> z = rng.normal(5, 2, size=100)
>>> ttest(x, x)
<PermutationResult statistic=0.0 pvalue=1.0 samples=[-1.0777184701737819 -0.5745783892613265 0.5535158154032149 ... 0.363142920966484 0.07527169151096517 0.5200998397771814]>>>> ttest(x, y)
>>> ttest(x, y)
<PermutationResult statistic=8.023556336493108 pvalue=0.0 samples=[-1.003702204153944 -2.235627507559989 -1.2326224127000487 ... 1.901142803116256 0.2923358962730485 0.26104067024073224]>
>>> ttest(x, z)
<PermutationResult statistic=-0.4048640806245116 pvalue=0.702 samples=[0.7605887004737174 1.1012141703433986 2.0505963468370663 ... -0.087491970163202 0.3842311706617004 -0.5125530333345881]>
>>> ttest_ind(x, x)
Ttest_indResult(statistic=0.0, pvalue=1.0)
>>> ttest_ind(x, y)
Ttest_indResult(statistic=8.023556336493108, pvalue=8.868335948218041e-14)
>>> ttest_ind(x, z)
Ttest_indResult(statistic=-0.4048640806245117, pvalue=0.6860144778466251)


Capture double dashes in process args

Changes were made in https://github.com/sbt/sbt-launcher-package/pull/259 to add double dashes for process_args, but in a different file that got deleted over the course of time. This change re-instates double dashes

Fixes https://github.com/sbt/sbt/issues/5079


3D observation + Resnet

@silverlight6 Change the observation to be 3D, updated the networks to be resnets. Sizes are hardcoded a bunch, this is a test, will train it for some days

Observation space

Action space


Update set-resource-limits.md

Clarifying Karpenter behavior if the CPU and Memory limit are not set
1. Issue, if available:
2. Description of changes:
Clarifying karpenter default behavior if CPU and Memory limit are not set
3. How was this change tested?
4. Does this change impact docs?

[ x ] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Implement CFPeriodIndex

A CFPeriodIndex supporting non-standard calendars would be useful to facilitate climate analyses. The use case for me would be to find the start and end date of a resampling group. This is useful to spot missing values in a resampled time series, or to create time_bnds arrays in a netCDF file.
import xarray as xr
import pandas as pd

cftime = xr.cftime_range(start='2000-01-01', periods=361, freq='D', calendar='360_day')
pdtime = pd.date_range(start='2000-01-01', periods=361, freq='D')

cf_da = xr.DataArray(range(361), coords={'time': cftime}, dims='time')
pd_da = xr.DataArray(range(361), coords={'time': pdtime}, dims='time')

#cf_c = cf_da.resample(time='M').count()
pd_c = pd_da.resample(time='M').count()

#cf_p = cf_c.indexes['time'].to_period()
pd_p = pd_c.indexes['time'].to_period()

#cf_expected_days_in_group = cf_p.end_time - cf_p.start_time + pd.offsets.Day(1)
pd_expected_days_in_group = pd_p.end_time - pd_p.start_time + pd.offsets.Day(1)

Depends on #2191

I think this would be a fair amount of work to implement :), but in principle it would be a natural step forward in the pattern we have been following in porting time series functionality from pandas for use with calendars supported by cftime.
In the short term, at least for the use-case you describe above, I think a potentially simpler option would be to use a call to CFTimeIndex.shift; based on your example I'll illustrate with the DatetimeIndex version, since resample doesn't exist yet for a CFTimeIndex:
In [1]: import xarray as xr; import pandas as pd

In [2]: times = pd.date_range('2000', periods=361)

In [3]: da = xr.DataArray(range(361), [('time', times)])

In [4]: monthly_count = da.resample(time='M').count()

In [5]: end_time = monthly_count.indexes['time']

In [6]: start_time = end_time.shift(-1, 'M')

In [7]: expected_days_in_group = end_time - start_time

In [8]: expected_days_in_group
Out[8]:
TimedeltaIndex(['31 days', '29 days', '31 days', '30 days', '31 days',
                '30 days', '31 days', '31 days', '30 days', '31 days',
                '30 days', '31 days'],
               dtype='timedelta64[ns]', name=u'time', freq=None)

Note that currently subtracting one CFTimeIndex from another (analogous to end_time - start_time in the example above) raises an error (I think it should also return a TimedeltaIndex), but that's probably a straightforward fix (I'll create a separate issue):
In [8]: a = xr.cftime_range('2000', periods=12, freq='M')

In [9]: b = a.shift(-1, 'M')

In [10]: a - b
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-10-09bd029d0285> in <module>()
----> 1 a - b

/Users/spencerclark/xarray-dev/xarray/xarray/coding/cftimeindex.pyc in __sub__(self, other)
    365
    366     def __sub__(self, other):
--> 367         return CFTimeIndex(np.array(self) - other)
    368
    369

TypeError: unsupported operand type(s) for -: 'numpy.ndarray' and 'CFTimeIndex'

As a side note, support even for standard PeriodIndexes in xarray needs some work -- see the following existing open issues: #1270, #1565.  Serialization to netCDF files would also be nice to support (but I don't see an existing issue for that).  I'm sure work to fix these issues would also be appreciated!

Got it, thanks for the workaround !


Python 3.9 AttributeError: 'Thread' object has no attribute 'isAlive'

When I run python downloader.py -t YOUR_DATACAMP_AUTH_TOKEN -l C,
I receive AttributeError: 'Thread' object has no attribute 'isAlive'
I changed isAlive to is_alive on line 115 of downloader.py and everything works.
isAlive is deprecated as of Python 3.9, use is_alive instead.

Closing this issue since it has been solved.


Chapter: Update your status

M = Maintainers (@rebeccawoodbury @lukefretwell @marlena-medford)
C = Contributors
Reference:

Chapter doc
Questions? Ask in chapter doc using comments feature or via contact form

To do
Set-up

[ ] Review contributor request (M - @rebeccawoodbury, @lukefretwell @marlena-medford)
[ ] Create a new issue (M - @lukefretwell)
[ ] Send contributors 'Welcome contributors' email (M - @rebeccawoodbury)
[ ] Schedule kick-off meeting (C)
[ ] Add @rebeccawoodbury @lukefretwell @Marlena-Medford to meeting invite (M - @rebeccawoodbury)
[ ] Create new chapter doc from chapter template (M - @rebeccawoodbury)
[ ] In file title and doc h1, replace 'TITLE' with the title of the chapter (example chapter) (M - @rebeccawoodbury)
[ ] Add link to GitHub issue in chapter doc (@rebeccawoodbury)
[ ] Meet for kick-off (C / M - @rebeccawoodbury @lukefretwell @marlena-medford)
[ ] Share edit rights with contributors and maintainers (M - @rebeccawoodbury)
[ ] Set two-week [calendar deadline reminder for writing chapter draft (+ add contributors in Proudly Serving calendar / template text (M - @rebeccawoodbury)
[ ] Set three-week calendar deadline reminder for maintainer review (+ add contributors in Proudly Serving calendar / template text) (M - @rebeccawoodbury)
[ ] Set five-week calendar deadline reminder for public feedback (+ add contributors in Proudly Serving calendar / template text) (M - @rebeccawoodbury)
[ ] Set six-week calendar deadline reminder to finalize chapter (+ add contributors in Proudly Serving calendar / template text) (M - @rebeccawoodbury)
[ ] Add contributors to GitHub contributors team (M - @lukefretwell)
[ ] Add contributors to this GitHub issue (M - @lukefretwell)
[ ] Add doc link to this issue 'Reference' above (M - @lukefretwell)
[ ] Review style guide (C)
[ ] Review code of conduct (C)
[ ] Add headshots to GitHub issue (C)
[ ] Add contributor(s) to contributor list (doc/GitBook/website (M - @lukefretwell)
[ ] Add 'Proudly Serving contributor' to LinkedIn profile (C)
[ ] Send contributors 'Kick-off follow-up' email (M - @rebeccawoodbury)

Write draft

[ ] Add bios/social media links to ‘Contributors’ section (C)
[ ] Complete first draft (2 weeks after kick-off)  (C)
[ ] When ready for review, highlight doc h1, add a ‘Ready for review’ comment and assign it to<EMAIL_ADDRESS>(C)
[ ] Review/edit/comment (M - @rebeccawoodbury, @lukefretwell @marlena-medford)
[ ] Select icon, add to colophon (M - @lukefretwell)
[ ] Notify contributors to review/approve final edits (M - @rebeccawoodbury)
[ ] When ready for public feedback, highlight doc h1, add a ‘Ready for feedback' comment and assign it to<EMAIL_ADDRESS>(C)

Promote feedback

Content templates

[ ] Blog (M - @rebeccawoodbury)
[ ] Substack (M - @rebeccawoodbury)
[ ] Twitter (M - @rebeccawoodbury)
[ ] LinkedIn (M - @rebeccawoodbury)
[ ] Send email to Contributor asking them to help promote on social (M - @rebeccawoodbury)
[ ] Share on social (C)

Finalize feedback

[ ] Respond to all comments and incorporate where appropriate (C)
[ ] When ready for final publish, highlight doc h1, add a ‘Ready to publish' comment and assign it to<EMAIL_ADDRESS>(C)
[ ] Review for copy edits ( M - @marlena-medford)
[ ] Deprecate doc (set to view only, add ‘This document has been deprecated. Visit the Proudly Serving website (https://proudlyservingbook.com/) to learn how to give feedback on this chapter.‘) (M - @lukefretwell)

Publish

[ ] Doc (M - @lukefretwell)
[ ] GitBook (M - @lukefretwell)

Promote published

Content templates

[ ] Blog (M - @rebeccawoodbury)
[ ] Substack (M - @rebeccawoodbury)
[ ] Twitter (M - @rebeccawoodbury)
[ ] LinkedIn (M - @rebeccawoodbury)
[ ] Send email to Contributor asking them to help promote on social (M - @rebeccawoodbury)
[ ] Share on social (C)
[ ] Send contributors 'Thank you' email (M - @rebeccawoodbury)

Reference
To keep residents informed, the city posts monthly ‘Done/Doing’ status reports on accomplishments and upcoming work.
Example: https://www.cityofsanrafael.org/donedoing-10/

Closing as it's a dupe of #83.


Add export modes and example for export

Adds the GPG export modes as listed on https://www.gnupg.org/documentation/manuals/gpgme/Exporting-Keys.html, mainly to allow exporting secret keys
Added a basic example for key export
Added a simpler override for Export, taking a filename instead of having to pass an instance of GpgmeData

@Daniel15 Speaking of import/export, do you plan adding the ability to import keys directly from Keybase?

Speaking of import/export, do you plan adding the ability to import keys directly from Keybase?

That seems like feature creep for a GPGME library 😄 Maybe there could be a separate assembly and NuGet package for it, like GPGME.Keybase.
I don't need it for my particular use-case... I'm adding GPG support to my SecureSign project: https://github.com/Daniel15/SecureSign

@Daniel15 Haha for sure, maybe a bit overkill to have it integrated in this library indeed. But I would love to have this feature added as an addon :)
But right now for example in GnuPG, we still have the ability to download keys from old KPK servers which (most of the time) are failing due to DNS resolution issues, etc. This is why I wouldn't be surprised if GnuPG was implementing some 2019-era addon solution to download pub keys :)


Upgrade cats to 2.10.0 / http4s to 0.23.23

Upgrade cats to 2.10.0 / http4s to 0.23.23

Codecov Report

Merging #68 (ea83a73) into main (9774b59) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   84.50%   84.50%
=======================================
  Files          17       17
  Lines         342      342
  Branches        3        3
=======================================
  Hits          289      289
  Misses         53       53


Error when running for first time on production

Describe the bug
When running in production users receive an error when searching for the first time. Second time around the users it works fine (most likely some properties are not properly set in local storage on first run).

Fixed in #95


Add pseudo-unbounded for loop and improve non-constant for loop error message

Problem
A common issue for users is trying to run a for loop only to discover the loop is over non-constant indices, resulting in a compiler error message:
error: Could not determine loop bound at compile-time                                                                                ┌─ /home/rndmprsn/Code/Noir/noir/short/src/main.nr:4:19
│
│     for i in 0 .. x {
│                   -
│
= Call stack:
  1. /../short/src/main.nr:4:19

The two common solutions to this problem would be to either
A. Debug why the for loop bound is not constant by sprinkling calls to assert_constant everywhere
B. Or if the loop is meant to be non-constant, choose an arbitrary maximum bound and loop over that instead.
Happy Case
We should add syntax sugar for solution B so users can fix their error faster and get back to programming. The syntax could be only a slight departure from normal for loops:
for <i> in <start> .. <end> max <max_iters> {
    <body>
}

This syntax would desugar to:
let $MAX_ITERATIONS = <max_iters>;
let $START = <start>;
let $ITERATIONS = <end> - $START;
assert($ITERATIONS < $MAX_ITERATIONS, "Maximum iterations exceeded in for loop!");

for $J in 0 .. $MAX_ITERATIONS {
    if $J < $ITERATIONS {
        let i = $J + $START;
        <body>
    }
}

Where each $ signifies a variable created by the compiler. The real benefit of this solution though comes in that it allows us to add a help message to our error messages suggesting this solution. With that change, the first error message would now be:
error: Could not determine loop bound at compile-time                                                                                ┌─ /home/rndmprsn/Code/Noir/noir/short/src/main.nr:4:19
│
│     for i in 0 .. x {
│                   - help: try adding a maximum bound: `for i in 0 .. x max 1000 {`
│
= Call stack:
  1. /../short/src/main.nr:4:19

Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

In the short term we should probably add a line from that error message to a page in the docs which describes the issue in more detail.


ci: update build image

Signed-off-by: Lizan Zhou<EMAIL_ADDRESS>Description:
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:

@lizan is this (the mac build) hanging?

@lizan failing clang_tidy on CI.

Hi @htuch @lizan, can we move forward with this cl? Is there a concrete problem or just lack of time and more urgent priorities?
Regarding --incompatible_disable_legacy_cc_provider, is seems https://github.com/grailbio/bazel-compilation-database/issues/25 is fixed.
Regarding incompatible_remove_old_python_version_api and gcovr, what exactly is the issue? Can we just migrate for that flag? https://github.com/bazelbuild/bazel/issues/7308 has decent migration instructions.
Thanks!

Happy to rubber stamp if we can get CI passing @hlopko @lizan

/retest

/retest


HCVault: refactor test to avoid using docker

The test cases in internal/sops/hcvault/keysource_test.go use "github.com/ory/dockertest" to spin up a test vault server.
We want to replace this to avoid having a dependency with docker. Instead we want to use a HVCault test server like https://pkg.go.dev/github.com/hashicorp/vault/vault#TestCluster.

This would be amazing, testing this is kinda a nightmare; having to install etcd and kube-apiserver and having to pollute our dev environment with temporary directories which may or may not be cleaned up on exit makes it kinda necessary to run them in containers, which IntelliJ thankfully supports, but having to somehow wire some container engine into the container just because some tests need this vault makes it kinda impossible again.
I've resorted to just commenting out https://github.com/fluxcd/kustomize-controller/blob/96a772293a5d34d6577b23dbdb5343e61cc21616/internal/controller/suite_test.go#L130 the panic and hoping it works in CI 😅


Added dependency with gradle and basic automation framework code.

What type of PR is this?
Automation framework written in java using gradle build tool.

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
This will add basic automation framework with required gradle dependency for multicloud api.
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

@Click2cloud-Wadhai Few  generic comments:
a) There are multiple utils classes/files defined..can they be combined into some logical groups..?
b) the path name contains 'opensds' ex. */opensds/util/utils.java.. Can they be renamed as */soda/util/utils.java. Basically removing opensds reference as its new code completely. @skdwriting  Please suggest
c) Wherever the code has been taken from some external place, please mention that as part of comment or put the copyright

@Click2cloud-Wadhai Few generic comments:
a) There are multiple utils classes/files defined..can they be combined into some logical groups..?
b) the path name contains 'opensds' ex. */opensds/util/utils.java.. Can they be renamed as */soda/util/utils.java. Basically removing opensds reference as its new code completely. @skdwriting Please suggest
c) Wherever the code has been taken from some external place, please mention that as part of comment or put the copyright

Is it the version from gradle? Not for every changes. If we follow maintained build version or we need to track in future then. Other wise in testing no need to change as per my knowledge.

@skdwriting do we need to keep the auto generated code to github? Will it not get generated during the build process, if we give the steps to build?  This file we need to push first time only. If this file i have not push then some one will be facing build issue when import this code.

@Click2cloud-Wadhai i think it's better to put reasons for the comment. Offline discussions will not make sense


[Design] Provide the color scheme generators to produce color schemes for your chart.

First, we provide color schemes of single-hue, multi-hue,  different order schemes.
Then, you can choose the kind of scheme based on the type of data.

And customize the number of values using the forms below.  According to the number of series, you can increase the number of color subdivision steps. Support up to 20 colors.

Finally, use it in your chart and make it live!

It should be implemented with theme editor.

Any update on this?


istio-proxy websocket log configuration error

Bug Description
I set the pod's annotations as sidecar.istio.io/componentLogLevel: conn_handler:debug,mongo:debug,websocket:debug. However, I encountered an error saying error: invalid component specified 'websocket'.
I'm curious about the reason, as it seems logging is possible based on the following document: https://github.com/envoyproxy/envoy/blob/main/source/common/common/logger.h.
Version
$ istioctl version
client version: 1.15.4
control plane version: 1.15.4
data plane version: 1.15.4 (20 proxies)

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

it's introduced by https://github.com/envoyproxy/envoy/pull/22542, should be envoy v1.24.
base on https://istio.io/latest/docs/releases/supported-releases/#supported-envoy-versions
I think it's avaiable in istio v1.16.

You can try istioctl pc log <podname> to see a list of available loggers for the proxy


Create an injectUpgrade function to help facilitate future upgrade testing.

Description
Create an injectUpgrade function that can be used to create an executable that forces an upgrade to run.
The function is not meant for any sort of official use and only exists to help facilitate testing of an upgrade handler. I don't think it should have a changelog entry because of this.
I'm making this PR, really, because I'm tired of having to dig it up out of an old branch so I can copy/paste it into a newer branch.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Had to tweak it. RunMigrations needs to happen before trying to set the params for the newly added module.


Update alter-database-transact-sql-set-options.md

Note there are many options that are not supported in SQL MI per this link:  https://docs.microsoft.com/en-us/azure/azure-sql/managed-instance/transact-sql-tsql-differences-sql-server#alter-database-statement  including RESTRICTED_USER and READ_ONLY.  There are several others so this document should be updated to accurately reflect those options we do not support.  Please consider reviewing the full list of what is not supported and including that here to reduce confusion for our customers.

Thanks @kodaksmile for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your suggestion. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.


Fix use of deprecated abstract collections import

Abstract collections have been moved to module collections.abc since Python 3.3 (using aiodataloader triggers a deprecation warning on abstract collections import from collections).
Since aiodataloader targets Python 3.5+, this has no impact.
This should be merged and published to PyPI before Python 3.8 hits, since compatibility import from the collections module will be removed.

Coverage increased (+0.09%) to 90.654% when pulling 3b8b3b7d4b9a872279c818053f66770a8cbab3f3 on Hellzed:fix-deprecated-collections-import into 2977814a20f5729fbe3fbaf97f437cc7a73878e9 on syrusakbary:master.

Coverage increased (+0.09%) to 90.654% when pulling 3b8b3b7d4b9a872279c818053f66770a8cbab3f3 on Hellzed:fix-deprecated-collections-import into 2977814a20f5729fbe3fbaf97f437cc7a73878e9 on syrusakbary:master.


Issue using dartls

Hi!
Found a small issue in navigator.lua, while using nvim-lsp-installer, when using dartls. Unfortunately, cmd_env.PATH, is not set in case of dartls.
Should this issue be in nvim-lsp-installer? Or should it be here?
Error log:
Error executing lua callback: /tmp/.mount_nvimuzldHi/usr/share/nvim/runtime/filetype.lua:20: Vim(lua):E5108: Error executing lua .../start/navigator.lua/lua/navigator/lsp
client/clients.lua:680: attempt to index field 'cmd_env' (a nil value)
stack traceback:
        .../start/navigator.lua/lua/navigator/lspclient/clients.lua:680: in function 'lsp_startup'
        .../start/navigator.lua/lua/navigator/lspclient/clients.lua:864: in function 'setup'
        .../start/navigator.lua/lua/navigator/lspclient/clients.lua:908: in function 'on_filetype'
        [string ":lua"]:1: in main chunk
        [C]: in function 'nvim_buf_set_option'
        /tmp/.mount_nvimuzldHi/usr/share/nvim/runtime/filetype.lua:20: in function </tmp/.mount_nvimuzldHi/usr/share/nvim/runtime/filetype.lua:11>
stack traceback:
        [C]: in function 'nvim_buf_set_option'
        /tmp/.mount_nvimuzldHi/usr/share/nvim/runtime/filetype.lua:20: in function </tmp/.mount_nvimuzldHi/usr/share/nvim/runtime/filetype.lua:11>

thank you for such a great project!

Seems lspinstaller dose not install dart in its default path.
It was fixed in latest version.

@ray-x thank you for the quick fix, it seems I now have some issue in my vimrc with the new codepath. Will try to debug later.
Error executing lua callback: /tmp/.mount_nvimyZHbUL/usr/share/nvim/runtime/filetype.lua:20: Vim(lua):E5108: Error executing lua .../start/navigator.lua/lua/navigator/lsp
client/clients.lua:480: Vim(lua):E5108: Error executing lua .../start/navigator.lua/lua/navigator/lspclient/clients.lua:480: Vim(lua):E5108: Error executing lua .../start
/navigator.lua/lua/navigator/lspclient/clients.lua:480: Vim(lua):E5108: Error executing lua .../start/navigator.lua/lua/navigator/lspclient/clients.lua:480: Vim(lua):E510
8: Error executing lua .../start/navigator.lua/lua/navigator/lspclient/clients.lua:480: Vim(lua):E5108: Error executing lua .../start/navigator.lua/lua/navigator/lspclien
t/clients.lua:480: Vim(lua):E5108: Error executing lua .../start/navigator.lua/lua/navigator/lspclient/clients.lua:480: Vim(lua):E5108: Error executing lua .../start/navi
gator.lua/lua/navigator/lspclient/clients.lua:480: Vim(set):E218: autocommand nesting too deep

I have some autocmd / augroup / au but I have to dig further on the specific issue.
thank you for the quick fix!

maybe some conflict with FileType event.
I also push an update to prevent callback to be called multiple times.

its perfect now, thank you @ray-x!


Mac: Tile can't be pageable

Describe the bug
Mac: Tile can't be pageable
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Drag "set tilemap to" block
3.Observe tile page
Expect behavior
It can be pageable and has the next button.

Actual behavior
Mac: Tile can't be pageable because the screen is small. It doesn't have the next button.

Additional context
1.OS: Mac
2.Browser: Safari

@Sheila111 still repros?


Add the support class for the Adjoint Jacobian to the new device

Before submitting
Please complete the following checklist when submitting a PR:

[X] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[X] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[X] Ensure that the test suite passes, by running make test.

[ ] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[X] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Migrate the lightning.kokkos device to the new device API.
Description of the Change:
The 'jacobian' and vjp` methods are necessary to achieve full functionality with the new device API.
We are going to follow the same recipe used with LightningQubit.
Benefits:
Add two of the essential methods for the new device API into LightningKokkos.
Possible Drawbacks:
Related GitHub Issues:
Partial / Freezzed PR ⚠ ❄
To make a smooth integration of LightningKokkos with the new device API, we set the branch kokkosNewAPI_backend as the base branch target for this development.
The branch kokkosNewAPI_backend has the mock of all classes and methods necessary for the new API. Also, several tests were disabled with
if device_name == "lightning.kokkos":
    pytest.skip("Kokkos new API in WIP.  Skipping.",allow_module_level=True)

Additionally, the CI testing from PennyLane for LKokkos is temporally disabled through commenting on the following lines in .github/workflows files
: # pl-device-test --device ${DEVICENAME} --skip-ops --shots=20000 $COVERAGE_FLAGS --cov-append
: # pl-device-test --device ${DEVICENAME} --shots=None --skip-ops $COVERAGE_FLAGS --cov-append

However, these tests will unblocked as the implementation progresses.
After all the developments for integrating LightningKokkos with the new API have been completed then the PR will be open to merging to master
[sc-68808] [sc-68814]

LGTM as far as I can tell. Would now be a good time to re-enable the tests: tests/test_*.py?

Not yet because the LightningKokkos class is empty then the majority of the test will fail. I am planning to re-enable the test/new_api in the next PR when the LightningKokkos' functionality is covered. :thinking:


[Feature Request] Add button autofocus on title entering

Currently user has to click add then click name to enter.
Most users want to enter text fast so focusing on name seems like good improvement.
Especially as empty(null) title are not allowed.

Thank you for your feedback, I will implement it in the next release


[FEATURE]Should we display logging nav tabs if there are no logging resources

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

cc @joshmeranda , your suggestion is tracked here, thanks.


Replace the imports for the new InertiaJS with vue3

@krekas can you please approve if it's a needed change?

@PovilasKorop looks good

@lartisan thanks for the contribution!

Glad I could help 👍


Instant withdrawal failing when error status code 500

This could be due to the fact that a liquidity provider has not yet seen the commitment that needs to be withdrawn. A deeper investigation to under the source might be required.

Seems to not recur


Incompatibility between Tensorflow and Theano models using Conv1D layers

Hello, I am trying to save a portable definition of a network using Conv1D layers. By portable I mean being able to save an .h5 file that I can load on different Keras instances using different backends.
However, despite the documentation on Conv1D not giving any indication that it is dependent on particular backends, I run into issues.
To replicate the issue:
keras.version : '2.0.3'
tensorflow.version : '1.1.0'
theano.version : '0.9.0'
"""
{
    "image_dim_ordering": "tf",
    "epsilon": 1e-07,
    "floatx": "float32",
    "backend": "tensorflow"
}
"""

from keras.models import Sequential
from keras.layers import Conv1D, Flatten, Dense

model = Sequential()
model.add(Conv1D(filters=6, kernel_size=3, input_shape=(15,1), padding="same"))
model.add(Flatten())
model.add(Dense(3))
model.compile("adam","categorical_crossentropy")

model.save("test.h5")

I then restart, using theano backend...
"""
{
    "image_dim_ordering": "th",
    "epsilon": 1e-07,
    "floatx": "float32",
    "backend": "theano"
}
"""

from keras.models import load_model

model = load_model("test.h5")

However, I get the following error:
ValueErrorTraceback (most recent call last)
 in ()
10 from keras.models import load_model
11
---> 12 model = load_model("test.h5")
/usr/local/lib/python2.7/dist-packages/keras/models.pyc in load_model(filepath, custom_objects)
241
242     # set weights
--> 243     topology.load_weights_from_hdf5_group(f['model_weights'], model.layers)
244
245     # instantiate optimizer
/usr/local/lib/python2.7/dist-packages/keras/engine/topology.pyc in load_weights_from_hdf5_group(f, layers)
   2898                                                        weight_values,
   2899                                                        original_keras_version,
-> 2900                                                        original_backend)
   2901         if len(weight_values) != len(symbolic_weights):
   2902             raise ValueError('Layer #' + str(k) +

/usr/local/lib/python2.7/dist-packages/keras/engine/topology.pyc in preprocess_weights_for_loading(layer, weights, original_keras_version, original_backend)
   2839                        'Conv2DTranspose']
   2840         if layer.__class__.__name__ in conv_layers:
-> 2841             weights[0] = conv_utils.convert_kernel(weights[0])
   2842         if layer.__class__.__name__ == 'ConvLSTM2D':
   2843             weights[0] = conv_utils.convert_kernel(weights[0])

/usr/local/lib/python2.7/dist-packages/keras/utils/conv_utils.pyc in convert_kernel(kernel)
     80     """
     81     if not 4 <= kernel.ndim <= 5:
---> 82         raise ValueError('Invalid kernel shape:', kernel.shape)
     83     slices = [slice(None, None, -1) for _ in range(kernel.ndim)]
     84     no_flip = (slice(None, None), slice(None, None))

ValueError: ('Invalid kernel shape:', (3, 1, 6))

In the documentation, it says:
Input shape

3D tensor with shape: (batch_size, steps, input_dim)

Output shape

3D tensor with shape: (batch_size, new_steps, filters) steps value might have changed due to padding or strides.

So the way that the input shape is defined is fixed. I don't understand why it fails then.
Is this a bug?

Did you manage to figure this one out?
...
    raise ValueError('Invalid kernel shape:', kernel.shape)
ValueError: ('Invalid kernel shape:', (5, 50, 128))

Same error please help how to resolve this:
Error log:
model = load_model('/data/sandeep/TLDClassification/tld_classification_model.h5')
File "/data/tensorflow/local/lib/python2.7/site-packages/keras/models.py", line 243, in load_model
topology.load_weights_from_hdf5_group(f['model_weights'], model.layers)
File "/data/tensorflow/local/lib/python2.7/site-packages/keras/engine/topology.py", line 2957, in load_weights_from_hdf5_group
original_backend)
File "/data/tensorflow/local/lib/python2.7/site-packages/keras/engine/topology.py", line 2898, in preprocess_weights_for_loading
weights[0] = conv_utils.convert_kernel(weights[0])
File "/data/tensorflow/local/lib/python2.7/site-packages/keras/utils/conv_utils.py", line 83, in convert_kernel
raise ValueError('Invalid kernel shape:', kernel.shape)
ValueError: ('Invalid kernel shape:', (5, 300, 128))

Upgrading to keras 2.0.5 solves the issue

I am still facing the same even though I have keras 2.1.6 version


Backspace on Flounder multiselect does not delete the most recent selection

Currently
When one or more elements have been added to a multiselect, and there is no new item being selected by typing text, then backspace does not do anything.
Wanted
Delete the most recent selection on backspace in case there is no text entered for selecting another item.

you mean on tagged multiselect?

@mousemke yes multipleTags : true

so.  i dont think i'll get to this til after the weekend, but i have a proposed interaction.  this will also help in accessibility of multiTag flounders.

make tags tab able

they will each need a tabindex of 0
they will each need a role (deselect )
they will need a focus border
now is a good time to give them a hover border

backspace on an empty search will focus the last selected tag

a second backspace, a space, or enter will remove the tag

after tag removal, focus will return to either: (this is the interaction i'm unsure of)

the input
the next last tag

thoughts? @zsolt-nagy-sociomantic

@mousemke

regarding tabbing, not all browsers will accept it, especially if Safari users ban it in their settings. Yet, in most browsers, it will be fine.
the second and the third point make perfect sense, and it highlights the importance of the first point (selecting via tagging) too
in my opinion, after tag removal, focusing on the "next last tag" makes slightly more sense, and if there are no more tags left, then we fall back to focusing on the input field. This will save some backspace keys for the user in case they want to delete multiple tags.

One more remark is that suppose you have 4 tags, you focus on the second, then you delete it, which tag will then be focused afterwards?

tabbing is super important as some people cant use mic.  if people have it disabled, that's their issue
i would say that if the second one is deleted it goes back to the first, (i.e. the same direction that the input to last one, etc is)

@mousemke, based on your rule, suppose you have 4 tags, A, B, C, D, and before pressing backspace, you are focused on:

A. Then the newly selected item will be B
B. Then the newly selected item will be A
C. Then the newly selected item will be B
D. Then the newly selected item will be C

In other words, the index of the selected item stays the same if you delete the first item, and is decreased by one otherwise.

Thank you, @mousemke.

for sure.  to be clear, you wont see this until 1.0.0 but feel free to pull the branch and check it out. lemme know if you have any observations on the interaction
in addition to the above, if you type until there's only one option and hit enter, that will be selected

@mousemke coolio! when's ca. the ETA for eagerly awaited 1.0.0?

well.... refactoring is still an issue, as well i'd really like to get to 100% test coverage.  If I think I can find time to make solid progress then I'll do them for 1.0.0, but I wont let it sit untouched for a long time.  In that case would drop the tests and release earlier


Use ghost viewer from gepetto-viewer

Use the new 'ghost viewer' introduced in https://github.com/Gepetto/gepetto-viewer-corba/pull/140.
Add a 'ghost' argument to ViewerFactory.createViewer if True and the creation of a viewer client fail, it use a 'ghost' client : with the same methods as the real client but always return None.
Also remove the definition of the Color class in viewer.py, this class was duplicated here: https://github.com/Gepetto/gepetto-viewer-corba/blob/master/src/gepetto/corbaserver/init.py#L8

I would also modify the hpp.gepetto.Viewer constructor, although it is not necessary.

Done in my latest commits.


[DOCS]: Clarify that the Planetscale Driverless Driver is compatible with Relational queries

Describe what you want
Hello Drizzle Team,
just like the title suggests, clarifying that you can use the Driverless Planetscale Driver without any adjustments on the drizzle connection would really be helpful since myself and other users where confused since it only shows mysql2 with a custom planetscale setting in the Docs.
That would be it :)
Keep up the great work!

I'm trying to use Drizzle with PlanetScale, I assumed it would just work but I did not know that PlanetScale doesn't support foreign keys, or rather I had heard that but didn't know exactly what that meant until I read this article. I spent a long time converting my code, but now I'm stuck and I can't make any progress in my app. it's so confusing. The Drizzle docs on relations briefly mention this but there is no mention of how you're supposed to deal with it. The code I've seen on Github uses uniqueIndex, but there is hardly any documentation on this. It feels like magical hand-waving. It would be nice to see a basic example of how to create a simple blog with comments with PlantScale.

Not tried it myself yet, but this article may be what you're missing: https://planetscale.com/blog/working-with-related-data-using-drizzle-and-planetscale


Explain what "Stable" label means for OpAMP

We need a precise definition of stability, what exactly we promise by labeling the protocol "Stable".

We can likely borrow the definition from OTLP once it is ready: https://github.com/open-telemetry/opentelemetry-proto/issues/400


Race condition in ParallelForEachAsync when exceptions are thrown

ParallelForEachAsync sometimes does not throw an exception if individual iterations did throw exceptions.
It reproduces with the following code (derived from the scenario where I noticed it):
while (true)
{
    Console.WriteLine();
    IReadOnlyList<int> input = Enumerable.Range(0, 10).ToList();
    ConcurrentQueue<int> output = new ConcurrentQueue<int>();

    try
    {
        await input.ParallelForEachAsync(
            async item =>
            {
                if (item == 0)
                {
                    throw new AggregateException(new Exception("Individual task failed."));
                }

                await Task.Delay(1);
                output.Enqueue(item);
            },
            maxDegreeOfParallelism: 10,
            cancellationToken: default);
    }
    catch (Exception)
    {
        continue;
    }

    Console.WriteLine($"No exception. {input.Count} - {output.count}.");
}

The cancellation token does not get canceled, and the default values of breakLoopOnException: false and gracefulBreak: true are used. The first task always throws an exception, therefore the expectation is that remaining tasks would finish, and ParallelForEachAsync would throw an exception.
However, the code above will eventually reach the case where exception is not thrown, and only 9 items are added to the queue (Console.WriteLine() statement above).
In the ParallelForEachAsync implementation the main task that schedules individual iterations, as well as continuations of individual tasks all call OnOperationComplete() of ParallelForEachContext. OnOperationComplete() adds exception to the list of tracked exceptions if it was supplied, releases the semaphore and at the very end calls CompleteLoopNow() if all tasks have completed or cancellation was requested (in this specific case I was not cancelling any tasks, so it was only called when all tasks finish).
public void OnOperationComplete(Exception exceptionIfFailed = null)
{
    // Add exception to the list
    // Release the semaphore

    if ((_semaphore.CurrentCount == _maxDegreeOfParallelism + 1) || (IsLoopBreakRequested && !_gracefulBreak))
        CompleteLoopNow();
}

The problem occurs when the last few tasks release the semaphore at the same time, in which case
_semaphore.CurrentCount == _maxDegreeOfParallelism + 1 condition can be evaluated as true for multiple tasks, so CompleteLoopNow() can be called more than once.
public void CompleteLoopNow()
{
    Console.WriteLine("CompleteLoopNow - Start");
    _cancellationTokenRegistration.Dispose();

    try
    {
        if (_semaphore != null)
            _semaphore.Dispose();
    }
    catch
    {
    }

    var exceptions = ReadExceptions();
    var aggregatedException = exceptions?.Count > 0 ? new ParallelForEachException(exceptions) : null;

    if (_cancellationToken.IsCancellationRequested)
    {
        Console.WriteLine("CompleteLoopNow - OperationCanceledException");
        _ = _completionTcs.TrySetException(
            new OperationCanceledException(
                new OperationCanceledException().Message,
                aggregatedException,
                _cancellationToken));
    }
    else if (exceptions?.Count > 0)
    {
        Console.WriteLine("CompleteLoopNow - TrySetException");
        _ = _completionTcs.TrySetException(aggregatedException);
    }
    else
    {
        Console.WriteLine("CompleteLoopNow - TrySetResult");
        _ = _completionTcs.TrySetResult(null);
    }
}

Which means that multiple tasks can also enter ReadExceptions() concurrently.
public List<Exception> ReadExceptions()
{
    Console.WriteLine("ReadExceptions - Start");
    bool lockTaken = false;
    while (!lockTaken)
        _exceptionListLock.Enter(ref lockTaken);
    try
    {
        Console.WriteLine("ReadExceptions - Returning");
        return _exceptionList;
    }
    finally
    {
        _exceptionList = null;
        _exceptionListLock.Exit(useMemoryBarrier: false);
        Console.WriteLine("ReadExceptions - End");
    }
}

However, in the finally block the exception list is set to null, so the first task calling it will get the full list of exceptions back, and subsequent tasks will get a null. Then in CompleteLoopNow() it is possible that a task with null exception list calls TrySetResult() before the a task with the correct exception list calls TrySetException().
I debugged with the same Console.WriteLine statements as above, and in cases where ParallelForEachAsync() did not throw I saw the following output
CompleteLoopNow - Start              // Task A entering CompleteLoopNow()
ReadExceptions - Start               // Task A entering ReadExceptions()
ReadExceptions - Returning           // Task A returning a full list of exceptions
ReadExceptions - End                 // Task A setting the list of exceptions to null
CompleteLoopNow - Start              // Task B entering CompleteLoopNow()
ReadExceptions - Start               // Task B entering ReadExceptions()
ReadExceptions - Returning           // Task B returning null as the list of exceptions
ReadExceptions - End                 // Task B setting the list of exceptions to null
CompleteLoopNow - TrySetResult       // Task B setting result on the task completion source since it got null from ReadExceptions()
CompleteLoopNow - TrySetException    // Task A setting exception on the task completion source since it got a non-empty list of exceptions from ReadExceptions()

I'm not sure whether ReadExceptions() needs to reset exception list to null. One possible reason is to prevent a race condition for the case where the loop was canceled, in which case continuations of tasks that are still running can keep adding exceptions to the list, but the same list is returned from ReadExceptions() to CompleteLoopNow(). However, in this case it's possible to return a copy of the exception list from ReadExceptions(), i.e.
public List<Exception> ReadExceptions()
{
    bool lockTaken = false;
    while (!lockTaken)
        _exceptionListLock.Enter(ref lockTaken);
    try
    {
        // Return a copy, so the list being returned will not be modified
        // by tasks that are still running if the loop was canceled
        return new List<Exception>(_exceptionList ?? Enumerable.Empty<Exception>());
    }
    finally
    {
        _exceptionListLock.Exit(useMemoryBarrier: false);
    }
}

Another option is to prevent tasks from re-entering CompleteLoopNow().

Here's a PR with the proposed change to ReadExceptions()
https://github.com/Dasync/AsyncEnumerable/pull/58

@danylofitel hi! Do you know why this could be unaddressed issue? No one answered  on your PR, we have faced similar issue in production we couldn't understand why exception was not thrown, but in our case this occurred with 1 task that was throwing an exception. Is there any alternative package from Microsoft?

@marvel16 it seems like the owner hasn't checked the repo for a while, previously he was super responsive and merged my PR within a day.
While waiting for a fix I'm using a wrapper in which I'm adding a try/catch around the async action and if an exception is thrown. Equivalent to:
        public static async Task ParallelForEachAsync<T>(
            this IAsyncEnumerable<T> collection,
            Func<T, long, Task> asyncItemAction,
            int maxDegreeOfParallelism,
            bool breakLoopOnException,
            bool gracefulBreak,
            CancellationToken cancellationToken = default)
        {
            ConcurrentQueue<Exception> exceptions = new ConcurrentQueue<Exception>();

            await Dasync.Collections.ParallelForEachExtensions.ParallelForEachAsync(
                collection,
                async (item, index) =>
                {
                    try
                    {
                        await asyncItemAction(item, index).ConfigureAwait(false);
                    }
                    catch (Exception exception)
                    {
                        exceptions.Enqueue(exception);
                        throw;
                    }
                },
                maxDegreeOfParallelism,
                breakLoopOnException,
                gracefulBreak,
                cancellationToken).ConfigureAwait(false);

            if (!exceptions.IsEmpty)
            {
                if (exceptions.All(exception => exception is OperationCanceledException) && cancellationToken.IsCancellationRequested)
                {
                    throw exceptions.First();
                }
                else
                {
                    throw new AggregateException("ParallelForEachAsync exception", exceptions);
                }
            }
        }

The idea is that once this issue is resolved you won't need any code changes (except perhaps cleaning up namespace usings - potentially remove the namespace in which you keep this wrapper and add the Dasync namespace).
Another option is to use the new Parallel.ForEachAsync. Note that it is available only in .NET 6 which is in preview until November, so if you're able to switch to it - you don't really need this package.


Healed nodes not finishing re-interview

Checklist

[ ]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Z-Wave JS UI version
8.15.0.f48c52b
ZwaveJS version
10.17.1
Describe the bug
When I attempt to heal any (or all) nodes on my network, the healing completes successfully, but then the node's interview status changes to "none" and has a forever spining wheel and I loose all ability to control the device as all of its functions are no longer accessible. Rebooting zwave brings all this back. I looked in the logs and just after any individual node heals, I see the following (error at the end):
This is what I see before a repair:

and after (until a reboot occurs)

The error occurs twice in the logs once during and once just after the heal process has finished. It doesn't occur outside of this process and is referencing provisioning which I believe is related to the interview process this is stuck on.
2023-05-09 08:35:00.965 ERROR APP: Unhandled Rejection, reason: TypeError: Cannot use 'in' operator to search for 'provisioning' in undefined
To Reproduce
Heal any node and wait for the heal to complete
Expected behavior
I'd expect to be able to use the node after healing and for the interview to complete as expected.
Additional context
Not sure if this is the UI or the driver, but we'll start here since the error is "APP". Below is an extract from my logs of the start of the heal and the error after it is successful.
z-ui_current.log

That's super strange. The error comes from a method that's called during inclusion, it accesses a value that should be set (and it seems never gets unset).
2023-05-09 08:33:50.285 INFO Z-WAVE: [Node 004] Found

This looks like there's another (or the same???) node getting included via SmartStart using the same node ID as the problematic one. Driver logs may give a better hint what's going on, but something fishy is happening in that network.

You did assist me with migrating from a 500 series stick to a 700 series, so not sure if that's related. You had to modify a backup from my stick because there was something screwy going on. This issue is new in that as of a few releases ago I could heal without issue (at least from a gui perspective). I'll roll back a few versions and see if I can confirm this.
I don't use smart start at all, but I'd be happy to grab the driver logs. Where can those be found?
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: AlCalzone @.>
Sent: Wednesday, May 10, 2023 2:35:53 AM
To: zwave-js/node-zwave-js @.>
Cc: Justin C. Hoover @.>; Author @.>
Subject: Re: [zwave-js/node-zwave-js] Healed nodes not finishing re-interview (Issue #5781)
That's super strange. The error comes from a method that's called during inclusion, it accesses a value that should be set (and it seems never gets unset).
2023-05-09 08:33:50.285 INFO Z-WAVE: [Node 004] Found
This looks like there's another (or the same???) node getting included via SmartStart using the same node ID as the problematic one. Driver logs may give a better hint what's going on, but something fishy is happening in that network.
—
Reply to this email directly, view it on GitHubhttps://github.com/zwave-js/node-zwave-js/issues/5781#issuecomment-1541789218, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4PCFHYMOGVDG3KU6XCSTXFNOPTANCNFSM6AAAAAAX3P53LM.
You are receiving this because you authored the thread.Message ID: @.***>

I did roll back to a January release and no change, so sure I had that wrong. In case its related, the issue you helped me with the migrating from the 500 stick to the 700 stick: https://github.com/zwave-js/node-zwave-js/issues/5549.
Here is the driver log. Its after a fresh reboot. Node being healed is 004
zwavejs_current.log

I'd still like to get this looked at if at all possible to avoid having to rebuild the network entirely, but if this isn't something others are seeing, which appears to be the case, it can be changed form a bug to some other classification.

Also, not seeing any options to reopen this, so not sure what to do there.

This seems like a bug in the controller firmware, but no one else seems to run into it. I'll change our code so it just ignores those inclusion messages for nodes that are clearly part of the network already.


glass material in sceneviewer

I'm using a texture with alpha blend for the glass material and it works well in 3d view, webxr, and quick look modes. However, I get a weird shade with scene viewer on Android (like in 2nd screenshot). Is there is a recommended fix for this issue?

@tpsiaki for the Scene Viewer bug.

@devhims Can you please put a link to your repro URL so we can inspect your GLB? It'll be hard to repro otherwise.

@elalish @tpsiaki you can download the GLB on this link:
https://cdn.glitch.com/5a4e620e-8d0d-4d82-a44f-08f272f0dd9d%2FBenzGLB3.glb?v=1616183257719

Hey @devhims
I download your model and checked in blender it looks like there is no problem on shading.
This is demo link for your model
https://relaxed-neumann-b6600b.netlify.app/orjinal.html
and opened in scene viewer Android as you see in the picture below the result is good. Which device did you tried your project? Maybe something is wrong on your codes.

Hi @sercandemirtas, I tested the link. I'm pretty sure the mode is webxr and not scene viewer. On Android with model viewer, that's the default mode unless you change it.


Shellcheck

See commit messages.
Related issue(s)
https://github.com/nextstrain/.github/pull/37
Testing

[x] Checks pass

With a temporary commit to point to the shellcheck action on the not-yet-merged branch, checks here pass.
Checks show as failed now because I dropped the temporary commit.


something wrong with geometry on middle zooms

Something strange happens with data in tegola (firsts screens by tegola and seconds by tilezen backend)

9/346/160.mvt or something like that - no part of road, duplicating of village name, no part of river

same place still bad - no part of road, no part of river

place on map - https://www.openstreetmap.org/#map=11/55.3567/64.4980

I wonder if adding dont_simplify to your config file might resolve this.
Here's an example:
[[maps.layers]]
name = "country_lines"
provider_layer = "ne.ne_50m_admin_0_boundary_lines_land"
dont_simplify = true
min_zoom = 3
max_zoom = 4
http://tegola.io/documentation/configuration/

Not a perfect reference, but the tegola demo for OSM rendering the same location

version is 0.6.x, try it with 0.6.0 and 0.6.2(now 0.6.2 as backend) with new simplification - same results, on 0.5.0 this holes was too. disable simplification for this and...same(check now with param in layer, earlier checked via global param), don't know why this happens. can execute wkt line of this road(and/or river) for you, if need sure. on yours demo lines are more simplified, maybe coz this?

Is there any data on top of the road and river lines? Or perhaps labels for the road and river lines that are masking the underlying features?

nope, i add tilezen backend screens for showing this, still tilezen returns me more simplified linestrings in this zooms (not so hard simplified, that's why it's look like linestrings in tegola), maybe it wrong when points of line too close for tile border. Oh didn't wrote that this hole on road becomes smaller and smaller while zoom in, i guess problem of point duplication (village name) has same roots as problem with lines

Can you share the tegola endpoint with this data? I want to inspect the tile edges to see if this is possibly a clipping issue on line strings.

i think sharing can be a...problem :) can only mvt load i think

ok we will do virtual machine with some access for you, DB and backend will be there, but need time for it :)

http://maps01.taxsee.ru/tangram-dev/index.html - render client
http://maps01.taxsee.ru/vector-dev/maps/test_map/{z}/{x}/{y}.mvt - for access to data

virtual machine versions:
centos 7.4, tegola 0.6.3, postgresql-9.6, postgis-2.4

using LAYER_SQL:EXECUTE_SQL opts, can execute log if need

update, i do version with simplified(myself) data and hole on road now very small on zoom 11 (but still exists)

@FallenKain can you expose the TileJSON for the map at http://maps01.taxsee.ru/vector-dev/maps/capabilities/test_map.json? I want to check your map rendering in Mapbox GL to make sure it has nothing to do with Tangram.

First of all, thank you for tegola.
@ARolek try to use this url: maps01.taxsee.ru/vector-dev/capabilities/test_map.json

that's not tangram for sure, as i show earlier, we have 2 backend with same DB and same render client with different results, that's why it's backend issue for sure

Are the tile endpoints still up? It looks like the capabilities endpoint is but the tiles are now returning 403 Forbidden status codes.
I might need you to dump the tile with our debug tools so we can take a look at the various stages of the data. @gdey can you provide the steps necessary to dump the offending tile to SVG for review?

Tegola is still up and working, for example this url returns 200 status code:
http://maps01.taxsee.ru/vector-dev/maps/test_map/10/696/321.mvt

@ARolek 1) screens are with simplification of tegola and not simplified data 2) disabling tegola's simplification returns same result's in map 3) version with simplified data (via postgis functions in DB) returns another result (tegola's simplification enabled) 4) variant with simplified data and disabled tegola's simplification didn't check
still thinking that not simplification trouble, but trouble with math in separation near borders(lines are cuted in tiles, right?), and still point can't be simplified but has problem when near tile border

Sorry for the delay in reply:
To get the tool with go get (need to have go installed)
go get github.com/go-spatial/tegola/cmd/xyz2svg

You will find the xyz2svg in your $GOPATH/bin directory.
To use it you will need to know the feature id, if you provide the feature id it will generate a svg file for each feature in the z,x,y you give it.
To run the command:
xyz2svg --config $path_to_tegola_config -t '$z/$x/$y' -p '$provider.$layer' [-g $feature_id]

This will output files into the a directory called _svg_files. The svg will have three versions of each of the features, the original, the simplified, and the clipped.

@FallenKain if you can follow @gdey's steps and then send us the SVG we can take a look at the various steps in the geo processing to see if it's obvious when the error is manifesting. If it's not clear, we're going to need to standup the data on this end and recreate the problem.

https://drive.google.com/open?id=1io4soYuI8Pt-aiLx5lzEnCKCzpMjaWqM

create 10 zoom for road and river and 9 zoom for place name

@FallenKain Thanks, just want to let you know that this is still on my radar. I was able to download the svg files; I'm trying to finish up some code I'm working on right now. Then I can get back to fixing these rendering issues.

1 more question - is tegola has buffer for tiles or can i somehow to set it in cofig file, maybe this can repair this problem

@FallenKain yes you can configure the tile buffer. This is done as a top level config
tile_buffer = 32  # set as desired

I need to document this. I have an open issue to do so. Planning on doing a round of documentation updates soon.

hm, good, thx :) also documentaition link on get started page http://tegola.io/documentation/getting-started/ is broken (in the end of 3 step), it's redirect to old url %)

@FallenKain thanks for the docs bug report. Fixing now.

@gdey @ARolek hi there :) something founded?)

@FallenKain unfortunately not. Progress is slow as we're also juggling a few other things.

okay(


Correctly detect Maven dependency versions when project version present

Observed a bug in the Maven detector where the project version defined in the <parent> tag in the pom.xml is overriding the versions detected for all dependencies in that pom.
This issue is still pending investigation--it might be due to a malformed pom rather than an error in the detector itself.

Spoke offline with a repo owner that reported the bug. Their build system was unique, but CD was acting as expected so am closing this item.


I hope to see Decoder soon.

Thanks for making such a great plugin.
Although the current version is only ENCODE,
I hope to see Decoder soon.
I'm looking forward to image decoding.

Hi!
Thank you for your positive feedback.
A Decoder will come soon, also other formats.
Could you please explain what you think of when mentioning „image decoding“?

It would be convenient to encode the image in one note and decode it when needed.
Then I can do all the processing in a single note, without having to pass the image files around when deploying.
The image file is easily viewable by anyone, but I'd like to encode it so it's more secure.

Could you give me an example which encoding you mean?
so you type in a text and you want what kind of picture as an Output?

Could you give me an example which encoding you mean? so you type in a text and you want what kind of picture as an Output?

The target of the image can be anything.
The size is a bit of an issue if you attach it to an MD file, but it's easy to distribute and it's nice to have one file to manage.
Let's attach a base64 image created in HTML.
ThankU.md

Oh, now I got your point... :)
OK, I will try to see what's possible!


add super.so fingerprint

resolve #423

@GDATTACKER-RESEARCHER Thank you for reviewing! Could you merge it?

That can not be done by me because not a repository manager in this repo i guess


feat: add contract reference policy

Description
Adding ContractReference policy with attributes and all links
Why
Part of the new standard
Issue
#176
Checklist

[x] I have followed the contributing guidelines

Definition of Done

[x] New "contractReference" policy added to the system
[x] Right operand set to "{bilateralContractName}"
[x] Policy applicable for any useCase type
[x] Policy can get used for "Usage" types only
[x] Policy active as of today's date
[x] No regex or transactional attributes required

why was main merged in this branch? it's going to the release branch and in the diff, I see loads of things not related to this change

Anwenderfehler. Schauen gerade ob wir das noch raus bekommen oder nen neuen PR benötigen

why was main merged in this branch? it's going to the release branch and in the diff, I see loads of things not related to this change

I did rebase to the rc.2 branch.
@jjeroch fyi


Support %run magic for IPython

This is a conceptually similar task to the task of the code extractor, but instead of extracting some code from the file it adds code at each virtual document refresh operation.
We would need to open the file, process the included notebook into a virtual document and embed it in the current virtual document. This definitely goes to the future jupyterlab-lsp-python (or ipython) extension.

This could be simplified by replacing %run xyz.ipynb with from lsp.xyz import * and keeping a virtual document under lsp/xyz.py in LSP server (not an actual file), though this would require reserving a python name for the package

@krassowski Hello! I also encountered the same problem, is there any progress now?

No, but pull requests are welcome.


Loop-Visualization adjustments

Prof. Mössenböck suggested adjusting the loop into an empty line through and the loop's content on the back-edge. See:

Had a quick meeting with Markus today. He spoke with Prof. Mössenböck regarding the visualization of repetitions. These are the results:

Only TS in repetition - Move To back edge

Compressed Loop with TS as separator - If the stuff before a loop is the same as the stuff at the end of a loop, then it can be on the normal LTR line, with the non-common symbol being used as the separator. This only works if the "separator" is a TS. Examples of use based on MicroJava: VarDecl, ActPars, Condition, ConstTerm. Examples where it does not work: FormPars (because of Type)

Otherwise, loops as before (ZeroOrMore or OneOrMore) should be used.
Sorry for the shitty screenshots, I made them during a brief meeting.

Added in #89


Patch covers all cases except when idle

First of all thank you for this great patch that made my computer usable.
All cases seems to be covered now, so no more random restarts, except for one case, is when coming back from a sleep with the following error report:

*** Panic Report ***
panic(cpu 3 caller 0xffffff7f88795705): "GPU Panic: mux-regs 3 3 7f 0 0 0 severity 3 switch-state 0 IG FBs 0 EG FBs 1:0 power-state 0 3D idle HDA idle : \n"@/Library/Caches/com.apple.xbs/Sources/AppleGraphicsControl/AppleGraphicsControl-3.14.49/src/AppleMuxControl/kext/GPUPanic.cpp:149

The Patch worked fine and SIP is disabled:
 | Checking compatibility
 MBPModelVersion :  MacBookPro6,2 ➔ Compatibility : OK ✓
  | macOS version :
 macOS 10.12
  | Checking SIP Status
 SIP Disabled
  | Searching for AppleGraphicsPowerManagement.kext
 AppleGraphicsPowerManagement.kext found
  ********** Starting MBP GPU Fix **********
 Disabling Kext Signing verification :  ✓
 Copying Info.plist file
 Patching Info.plist
  - FindChild  - key|MacBookPro6,2
  - NextSibling  - dict
  - FindChild  - key|LogControl
  - ModifyIntValue  - integer|1
  - FindSibling  - key|Vendor10deDevice0a29
  - FindSibling  - key|BoostPState
  - FindSibling  - key|BoostTime
  - FindSibling  - key|Heuristic
  - FindSibling  - key|IdleInterval
  - ModifyIntValue  - integer|10
  - RemoveSiblingLabel - P3HistoryLength Not found
  - FindSibling  - key|SensorSampleRate
  - ModifyIntValue  - integer|10
  - FindSibling  - key|Threshold_High
  - FindSibling  - key|Threshold_High_v
  - FindSibling  - key|Threshold_Low
  - FindSibling  - key|Threshold_Low_v
 Info.plist successfully patched
  | Loading Kernel Extension
 Removing existing kext in tmp :  ✓
 Copying actuel kext into tmp :  ✓
 Copying patched Info.plist into kext :  ✓
 Changing permission of kext :  ✓ /tmp/AppleGraphicsPowerManagement.kext/Contents/_CodeSignature/CodeResources
/tmp/AppleGraphicsPowerManagement.kext/Contents/_CodeSignature
/tmp/AppleGraphicsPowerManagement.kext/Contents/Info.plist
/tmp/AppleGraphicsPowerManagement.kext/Contents/MacOS/AppleGraphicsPowerManagement
/tmp/AppleGraphicsPowerManagement.kext/Contents/MacOS
/tmp/AppleGraphicsPowerManagement.kext/Contents/version.plist
/tmp/AppleGraphicsPowerManagement.kext/Contents
/tmp/AppleGraphicsPowerManagement.kext

 Removing existing kext :  ✓
 Copying patched kext into Extension :  ✓
 Loading modified kext :  ✓
 ********************* MBP GPU Fixed Successfully *********************

As noted in that output, it is a macOS 10.12.
Not sure how macOs is structured, I see the reported panic related to a file under /Library/Caches. Does that mean the OS is using older version of files before being patched? Is there a way to remove cached files? If yes, would that fix it? Thank you for any suggestion.

Hi ! Your issue has been reported in #32, unfortunately I don't know how to fix this.
My only recommandation would be to power the MacBook off instead of putting it into sleep mode.


Unable to build Perl using unprivileged id because can't tag /usr/include/errno.h as EBCDIC

The code right now tags untagged files being read as 1047. Instead, we need to copy errno.h, then tag it (longer term, perhaps get the OS to tag their header files)

After making a change to copy the errno.h header file to a local file and then tagging it as IBM-1047, I get the following results when running on a restricted general user account:
Failed 29 tests out of 2477, 98.83% okay.
	../cpan/File-Temp/t/object.t
	../cpan/File-Temp/t/security.t
	../cpan/File-Temp/t/tempfile.t
	../cpan/IO-Compress/t/050interop-gzip.t
	../cpan/IPC-Cmd/t/01_IPC-Cmd.t
	../cpan/IPC-Cmd/t/03_run-forked.t
	../cpan/Socket/t/getnameinfo.t
	../cpan/Test-Harness/t/harness.t
	../cpan/Test-Harness/t/source_handler.t
	../cpan/libnet/t/datasend.t
	../cpan/libnet/t/ftp.t
	../cpan/libnet/t/nntp.t
	../cpan/libnet/t/nntp_ipv6.t
	../cpan/libnet/t/nntp_ssl.t
	../cpan/libnet/t/pop3_ipv6.t
	../cpan/libnet/t/pop3_ssl.t
	../cpan/libnet/t/require.t
	../cpan/libnet/t/smtp.t
	../cpan/libnet/t/smtp_ipv6.t
	../cpan/libnet/t/smtp_ssl.t
	../cpan/podlators/t/general/basic.t
	../cpan/version/t/07locale.t
	../dist/ExtUtils-CBuilder/t/04-base.t
	../dist/IO/t/io_pipe.t
	../lib/ExtUtils/t/Embed.t
	lib/croak.t
	op/magic.t
	porting/pod_rules.t
	porting/podcheck.t

Oddly, I get a different number of failures running under IBMUSER (an account with extended privileges):
Failed 33 tests out of 2479, 98.67% okay.
	../cpan/File-Temp/t/object.t
	../cpan/File-Temp/t/security.t
	../cpan/File-Temp/t/tempfile.t
	../cpan/IO-Compress/t/050interop-gzip.t
	../cpan/IPC-Cmd/t/01_IPC-Cmd.t
	../cpan/IPC-Cmd/t/03_run-forked.t
	../cpan/Socket/t/getnameinfo.t
	../cpan/Test-Harness/t/harness.t
	../cpan/Test-Harness/t/source_handler.t
	../cpan/libnet/t/datasend.t
	../cpan/libnet/t/ftp.t
	../cpan/libnet/t/nntp.t
	../cpan/libnet/t/nntp_ipv6.t
	../cpan/libnet/t/nntp_ssl.t
	../cpan/libnet/t/pop3_ipv6.t
	../cpan/libnet/t/pop3_ssl.t
	../cpan/libnet/t/require.t
	../cpan/libnet/t/smtp.t
	../cpan/libnet/t/smtp_ipv6.t
	../cpan/libnet/t/smtp_ssl.t
	../cpan/podlators/t/general/basic.t
	../cpan/version/t/07locale.t
	../dist/ExtUtils-CBuilder/t/04-base.t
	../dist/IO/t/io_pipe.t
	../dist/Net-Ping/t/520_icmp_ttl.t
	../ext/POSIX/t/mb.t
	../lib/ExtUtils/t/Embed.t
	../lib/locale.t
	lib/croak.t
	op/fork.t
        op/magic.t
        porting/pod_rules.t
        porting/podcheck.t

Results running 8 builds:
blead.64.dynamic.ascii Summary: Failed 33 tests out of 2479, 98.67% okay.
blead.64.dynamic.ebcdic Summary: Failed 98 tests out of 1949, 94.97% okay.
blead.64.static.ascii Summary: Failed 44 tests out of 2357, 98.13% okay.
blead.64.static.ebcdic Summary: Failed 98 tests out of 1829, 94.64% okay.
blead.31.dynamic.ascii Summary: Failed 36 tests out of 2475, 98.55% okay.
blead.31.dynamic.ebcdic Summary: Failed 98 tests out of 1945, 94.96% okay.
blead.31.static.ascii Summary: Failed 47 tests out of 2353, 98.00% okay.
blead.31.static.ebcdic Summary: Failed 100 tests out of 1825, 94.52% okay.

These are the non cpan failures for EBCDIC dynamic 64-bit:
 	../dist/ExtUtils-ParseXS/t/002-more.t
 	../dist/Net-Ping/t/520_icmp_ttl.t
 	../dist/Unicode-Normalize/t/fcdc.t
 	../dist/Unicode-Normalize/t/func.t
 	../dist/Unicode-Normalize/t/norm.t
 	../dist/Unicode-Normalize/t/split.t
 	../dist/Unicode-Normalize/t/test.t
 	comp/require.t
 	lib/croak.t
 	porting/podcheck.t
 	porting/readme.t


'Loading' animation when switching between API list pages in Publisher

When switching between API list pages (next/back in pagination) in Dev portal, we show a 'loading' animation. It would be user friendly to show the same in Publisher.

Fixed with https://github.com/wso2/carbon-apimgt/pull/8776


Fix: Operate on a cloned Hash when specifying param presence

Operate on a cloned Hash when specifying presence: true for parameters to prevent issues with re-used entities. Includes spec and the minor fix.
Should be self explaining this time :)

Thx