POC: optionally throttle requests per second

Initial implementation of requests/second throttle. Fix #90
@TODO:

fix shutdown process; currently shutdown is affected/delayed by the throttle
general cleanup / optimization of implementation
integration test

Example of it working:
jandrews@piccolo:~/devel/rust/goose$ cargo run --example drupal_loadtest -- --host http://apache.fosciana/ -u10 -r25 -t10s -v --throttle-requests 20
   Compiling goose v0.8.3-dev (/home/jandrews/devel/rust/goose)
    Finished dev [unoptimized + debuginfo] target(s) in 7.73s
     Running `target/debug/examples/drupal_loadtest --host 'http://apache.fosciana/' -u10 -r25 -t10s -v --throttle-requests 20`
08:08:23 [ INFO] Output verbosity level: INFO
08:08:23 [ INFO] Logfile verbosity level: INFO
08:08:23 [ INFO] Writing to log file: goose.log
08:08:23 [ INFO] run_time = 10
08:08:23 [ INFO] global host configured: http://apache.fosciana/
08:08:23 [ INFO] initializing user states...
08:08:23 [ INFO] throttle allowing 1 request every 50ms
   ...
------------------------------------------------------------------------------
 Name                    | # reqs         | # fails        | req/s  | fail/s
 -----------------------------------------------------------------------------
 GET (Anon) front page   | 33             | 0 (0%)         | 2      | 0
 GET (Anon) node page    | 11             | 0 (0%)         | 0      | 0
 GET (Anon) user page    | 3              | 0 (0%)         | 0      | 0
 GET (Auth) front page   | 2              | 0 (0%)         | 0      | 0
 GET (Auth) login        | 2              | 0 (0%)         | 0      | 0
 GET static asset        | 210            | 0 (0%)         | 16     | 0
 POST (Auth) login       | 2              | 0 (0%)         | 0      | 0
 ------------------------+----------------+----------------+--------+---------
 Aggregated              | 263            | 0 (0%)         | 20     | 0
-------------------------------------------------------------------------------

Unfortunately mpsc stands for Multi-Producer-Single-Consumer, and we're looking for the opposite. See https://github.com/tag1consulting/goose/issues/90#issuecomment-653363182 where I explored some options, and ended up with async-std.

Maybe we could use a leaky bucket instead then?
It works the same way, but the client threads push tokens into the bucket and block while the bucket is full.
The consumer then removes tokens from the bucket a the given rate.

The only thing I'm not sure how to address w/ the Leaky Bucket method is exiting in an efficient and timely manner.
In the current implementation, the throttle thread passes true to children until the parent exits then (not yet implemented) passes false telling GooseClients to cancel. With a leaky bucket, I'm not sure how we'd tell clients to cleanly exit mid-request.
Possibly a slow shutdown isn't a big enough problem to worry about. Removing a big dependency is certainly nice.


[Feature Request[ Use two different sets of initial parameters, then average out the results

This version doesn't use splits, so instead I propose a different approach. Obtain 2 different sets of initial parameters by running this version on 70+ collections of users, taking the number of reviews and the optimal parameters, and calculating optimal parameters weighted by n_reviews and ln(n_reviews). Since the weighting is different, those 2 sets will also be different.
Then use these 2 sets of parameters to run the optimizer twice. First, using one set (say, the one that was obtaiend by weighting by n_reviews) of initial parameters, then using the other set. Then average the result.
The key idea is that instead of using one starting point in the space of all possible configurations of parameters, we use two starting points. This could improve convergence without using splits.
Preparing the sets of initial parameters:

Run the optimizer on each available collection
Record optimal parameters and n_reviews for each user
Obtain set 1 by using a weighted average (weighted by n_reviews)
Obtain set 2 by using a weighted average (weighted by ln(n_reviews))

Deployment:

The user chooses a preset/deck/collection
Optimization starts with initial parameters from set 1
Optimization ends, optimal parameters are recorded (optimal parameters for this user, set 1)
Optimization starts with initial parameters from set 2
Optimization ends, optimal parameters are recorded (optimal parameters for this user, set 2)
Use a simple arithmetic average to obtain the final set of optimal parameters by averaging the values in two sets of optimal parameters, return that final set to the user

Before we improve the Rust version optimizer, we should develop an automatic evaluation tool. Without evaluation, we cannot determine whether the idea works. But I’m still not skilled in Rust, it would take a long time. By the way, I have tested many methods to make the optimal parameters stable, but they don’t work. And the float point number calculation is not consistent in different platforms, it is possible that the final parameters are different even when you use the same code and data.

some thoughts:

could that automatic evaluation tool be developed in an easy language like python ? (I am not sure how it will be used though). And if it has a python prototype, rewrite (if necessary) would be much easier, I guess.
And the float point number calculation is not consistent.
https://github.com/paupino/rust-decimal or https://github.com/mamrhein/fpdec.rs ? But I am not sure about the performance.

could that automatic evaluation tool be developed in an easy language like python

https://github.com/open-spaced-repetition/fsrs-benchmark

This issue is out-of-date.


[Feature]: tspa (TSP script application) support

Pre-check

[X] I have searched the existing issues and discussions to make sure my problem has not already been addressed.
[X] I have looked at the "Known Issues" Section of the marketplace page of all TSP Toolkit extensions.

Feature Idea
As a user, I would like to write a tsp application (accessible via the "APPS" button). The TSPA extension is currently not supported and the loadscript command is underlined as an error. "endscript" and the loadimage section (and the whole base64 encoded image) are also marked as errors.
As an example for a tspa script, you can use Brad's "probe hold script from https://www.eevblog.com/forum/testgear/new-keithley-dmm6500/msg1889276/#msg1889276
I am using the extension with VSCodium on Manjaro Linux. Had to install it from the .vsix file, but does seem to work and did find my K6500 (even though that is not in the list of supported instruments).

Thanks for entering this request! I will bring it to my team to discuss.


SuggestedActions not working for me

Hello,
I can't seem to make SuggestedActions work.
This is my code:
SuggestedActions suggestedActions = new SuggestedActions()
        .withActions(
            new ImmutableList.Builder<CardAction>()
                    .add(new CardAction().withType(ActionTypes.IM_BACK).withValue("hello").withTitle("Hello"))
                    .add(new CardAction().withType(ActionTypes.IM_BACK).withValue("byebye").withTitle("Byebye"))
                    .build()
        )
        .withTo(
                new ImmutableList.Builder<String>().add(user.id()).build()
        );

Activity newActivity = new Activity()
        .withType(ActivityTypes.MESSAGE)
        .withText("Choose an action")
        .withRecipient(user)
        .withFrom(bot)
        .withInputHint(InputHints.EXPECTING_INPUT)
        .withSuggestedActions(suggestedActions);

client.conversations().sendToConversation(conversationId, newActivity);

The user gets the message, but the quick reply buttons don't appear (Tested with MicrosoftTeams).
Thanks

fyi: i'm checking into this..

Here's a tool to understand what features are supported under what channel.  My understanding is this reflects a snapshot of what was supported several months ago, but according to this tool, SuggestedActions aren't supported under Microsoft Teams yet.
https://docs.botframework.com/en-us/channel-inspector/channels/Teams?f=SuggestedActions&e=example1
Thanks


Add support for customName (custom container DID)

Fixes #11734
Status
In development
Description
Add support for new customName attribute (custon container DID)
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
External dependencies / deployment changes

Alan, Todor, I made initial changes which are ready to review. I see one Rucio test failing which I think is not related to this PR. Please review and provide your feedback of what else need to be done.

Alan, also please clarify if something needs to be done in WMCore codebase for new group scope you mentioned. I also see on original ticket mention of Rucio DID and lexicon rules. But for both items I interpreted that it is outside of WMCore codebase and will be done externally. Please advise if I'm wrong.

@vkuznet Valentin, these changes look good to me. However, we still have to contact Eric/Rucio developers to decide which scope we want to create for this new data. Perhap we could use the DMWM mattermost channel for that discussion (or DM Dev Forum)?
And with that, it just occurred to me that, whenever we are dealing with a custom pileup dataset name, we need to also provide the new scope name to the Rucio queries. In other words, instead of using the standard cms scope, we should pass the scope used for customName pileups. For that, I would suggest to have a separate commit in this PR not to change what has already been reviewed.

@ericvaandering , could you please either provide necessary scope or let us know your availability and channel for further discussion. I think offline actions/exchange will be still work just fine.

test this please

I haven't made a scope for you yet. Here are the non-user, non-tier2/3 scopes:
[ewv@lxplus806 ~]$ rucio list-scopes | grep -v user | grep -v group.t                                                                                cms                                                                                group.offcomp_sitesupport                                                                                group.pog_tau                                                                                group.crab_test                                                                                logs                                                                                group.pdmv                                                                                group.pog_tau_group                                                                                ```

So I'd propose group.SOMETHING WMAgent? WMCore?

Alan, even though your statement seems logical it is not clear how it should be done in a code. For example, we pass around a spec which may contains the custom name. It is a JSON object used across different MSPilupe tasks. Now, when such object is passed to a specific task we invoke rucio client API, delete rule. Now, how we should pass around a scope? to such task. Please see the code to understand the question, e.g.

in MSPileupTasks codebase we invoke inactive tasks
get get set of pileup specs and pass it to ascyncrhonously pass it ti inactiveTask function, e.g. https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/MicroService/MSPileup/MSPileupTasks.py#L320
in this function we know the spec and have rucioClient object, therefore only here we can read custom Name, and therefore we should know how to get the scope. Where it comes from? Should it be a global variable which we setup in MSPileup initi ctor? If so, should it be unique or we may need to support different scopes?

Once you'll clarify these questions it would be clear what should be implemented.

@ericvaandering do you think we should stick with a group scope e.g. group.wmcore or a non-group scope would be fine? Depending on your answer, we might want to rename the logs scope to something like group:wmcore_logs. Just an idea...
@vkuznet custom scope will be unique, probably group.wmcore (see above). Said that, I would be in favor of making it a service configuration parameter (string type, as it will be unique).

I think it needs to be a group scope. That's because of the legacy mapping of scope to PFN where we would have to either ban the scope from being used in file DIDs or carve out a part of the name space for them. That's all take care of with a group scope.
Of course, I expect this scope will NOT be used with any files, but we'd still have to account for it.
What is the Rucio account that is going to mostly use this scope? We should add that as the owner. But I think your accounts are sufficiently privileged that they could all use the scope if needed.

Of course, I expect this scope will NOT be used with any files, but we'd still have to account for it.

@ericvaandering you mean creation of new data/DID? The way we are going to use this scope is: given a pileup container, we are going to pick X% of its rucio datasets (and the files in it), then we create a new container DID, and attach these X% rucio datasets and their file to this new custom container. The new/custom container would be created under this new group scope. Do you see any problem with that?
The owner - and for the moment only user - of this functionality is wmcore_pileup account.

@ericvaandering you mean creation of new data/DID? The way we are going to use this scope is: given a pileup container, we are going to pick X% of its rucio datasets (and the files in it), then we create a new container DID, and attach these X% rucio datasets and their file to this new custom container. The new/custom container would be created under this new group scope. Do you see any problem with that?
The owner - and for the moment only user - of this functionality is wmcore_pileup account.

This is exactly as expected from my discussions with Alan. No problem.

Done in both integration and production.  rucio-admin scope add --scope group.wmcore --account wmcore_pileup

Alan, kind reminder, I'm still awaiting your review.

Alan, the new input you give completely change the logic I already implemented. Originally you asked to pass scope through configuration and I did that, e.g.
...
   rucioScope = spec.get('rucioScope', 'cms')
...
    pname = doc.get('customName', '')
    if pname == '':
        pname = doc['pileupName']
    kwargs = {'scope': rucioScope, 'account': rucioAccount}
    rules = rucioClient.listDataRules(pname, **kwargs)

Since now you shown a different approach which will take hard-coded group.wmcore scope I doubt that the logic I put will be used at all since now you want to use specific scope when there is custom name. Should I remove rucioScope configuration now? If not, please clarify how it will be used.

Valentin, I am not changing any logic and I could try to clarify it again. However, I prefer not to repeat myself and would ask you to carefully read again the explanation I provided in these 2 comments:
https://github.com/dmwm/WMCore/pull/11765#pullrequestreview-1695069593
https://github.com/dmwm/WMCore/pull/11765#pullrequestreview-1709996246

Alan, I re-read your comments and I find them confusing:

from https://github.com/dmwm/WMCore/pull/11765#pullrequestreview-1709996246 I read if using custom pileup name, we MUST pass the new scope that Eric has created / is creating for us.
from https://github.com/dmwm/WMCore/pull/11765#issuecomment-1791472826  I read custom scope will be unique, probably group.wmcore (see above). Said that, I would be in favor of making it a service configuration parameter (string type, as it will be unique).
and, from https://github.com/dmwm/WMCore/pull/11765#pullrequestreview-1728310187 I read that # meaning, we are using customName pileup name   then use the service configuration scope, named "group.wmcore"

So, in other words you ask to provide mandatory scope, then ask to use configuration to define it, and then ask to use scope group.wmcore. I'm honestly do not understand how all of that can be combined togther. If we must use group.wmcore then I do not see any reason to provide configuration parameter. If we use configuration parameter, then its default would be cms because we'll use this scope through the code. If code should dynamically change scope and this scope can be configured with default group.wmcore then this scope should not be used by default in rucio APIs. Is this is what you want, i.e. define custom scope in configuration, then put group.wmcore as default for it, and then only use when customName is defined. I only try to understand how to implement stuff to avoid wasting time on iteration through implemrntaion.

If code should dynamically change scope and this scope can be configured with default group.wmcore then this scope should not be used by default in rucio APIs. Is this is what you want, i.e. define custom scope in configuration, then put group.wmcore as default for it, and then only use when customName is defined.

exactly!

Alan, I implemented requested logic, please have a look. The failed unit test is unrelated (it is throttling again).

Alan, per your request I added unit test but it requires lots of changes. Here how I committed them:

6af39890a (HEAD -> fix-issue-11734) Add unit test for custom container
d3e11f6f3 Added rucioParams to mock API as it is used in tests
ffbfc740c Allow usage of mock tokens
aa362551f modify pileupSizeTask to return containers (used in unit test)
5b67cfa34 Add new mockup data to use custom rucio scope

I do not know if you want to squash them together or not, please let me know. Botton line, I fixed Rucio mock API which was lack of rucioParams used in MSPIleup code, I added mock token support for getPileupContainerSizesRucio API and use it in unit test, I also was need to modify pileupSizeTask to return container's dicts in order to use them in unit test. Said that, now unit test covers custom name containers and I know for sure that it is used. The fixes to mock Rucio API also fixed couple of exceptions I found in unit test since mock Rucio API was lack of proper parameters.

Thank you for providing these changes, Valentin.
Honestly speaking, I always avoid adapting the actual source code providing a given functionality with code that is not necessary for a production environment (emulation/test related logic).
The only options I see though are:

keep the mock/emulation code in the actual production function as is
create an integration unit test running on real data. By "integration" here, it means not running in the Jenkins CI.

Any thoughts?

I understand your concern and I was trying to find best solution which I implemented as option 1. I doubt that option 2 is feasible since it will require a-prior knowledge of dataset presence, setting up MongoDB backend for testing, etc. I see it much more expensive. The changes I made to code are minimal and if you want they can be further separated into production and mock functions, i.e. getPileupContainerSizesRucio  can be split into two with appropriate wrapper. I still in favor of option 1 as it provides a way of testing through Jenkins/unit tests without setting up MongoDB, Rucio, DBS services.

I thought the mocking was isolated to the Pycurl module, but I see it also changes the other MSPileup module.
Why do you think we need to setup MongoDB? I see no difference between the mock rucio or real rucio, given that none of those depend on MongoDB. On what concerns finding a pileup dataset, that's easily achievable by:
https://cmsweb-testbed.cern.ch/ms-pileup/data/pileup
for the custom dataset, it will of course fail unless we create a custom container ourselves.
Said that, I am inclined to removing emulation code from the actual production baseline code and run a unit test as integration. Once you are happy with the result, just flag the unit test as integration not to have it executed by Jenkins.

Oh, I didn't see that there was a mongodb record update within that function. At the moment we do not have MongoDB in our test setup. A few alternatives for that would be:

have a localhost mongodb instance for unit tests
use mongodb cmsweb-testbed in a controlled and isolated way
mock the few mongodb calls in MSPileup

I would suggest to do that in a future ticket/pull request though.
For now, we can move forward with this code and once it gets deployed in testbed, I would ask you to cross-check whether these developments are Okay. Does it look good to you?

ok, so the plan would be:

remove this commit https://github.com/dmwm/WMCore/commit/ffbfc740c09d10907d034c510f0e0c0c098379ac
merge this PR
deploy to testbed
change records on testbed mongodb to include custom Name
perform integration test on testbed using newly deployed code and new records
if test is successful we may move to production, i.e. include this PR in WMA release, or if test is not successful, I need to debug it and revert records in MongoDB on testbed cluster.

Is this plan correct?
BTW, we already have mocking for MongoDB, and my unit test which I provided does that.

ok, mock code which emulates the rucio token has been removed. And, I adjusted unit test to not check cmsDict/cusDict records to allow test to pass and use logger instead to print how many we will have. This behavior will allow unit test to be successful but also will allow to perform integration tests when we'll add customName into MongoDB records.
Please have a look and proceed with this PR review (or merge). Then I can move towards testbed testing.

test this please

Alan, for the record, the commit name was auto-generated after I squashed changes and re-order commits. Turns out the order was important and I resolved different conflicts and final commit message was auto-generated by github. I did not want to mess more with it, as it provided reference to previous commits in order they were committed.
Thanks for final approval and merge though. I'm glad we made it before holidays.

@amaltaro , I tried to run integration test and encountered the following error. I took one dataset from https://cmsweb-testbed.cern.ch/ms-pileup/data/pileup and put it into integration test, when I run it I see the following exception:
2023-11-22 15:24:02,270:ERROR:PycurlRucio: getPileupContainerSizesRucio function did not return a valid response for container: /MinBias_TuneCP5_14TeV-pythia8/PhaseIITDRSpring19GS-106X_upgrade2023_realistic_v2_ext1-v1/GEN-SIM. Error: {'ExceptionClass': 'DataIdentifierNotFound', 'ExceptionMessage': "Data identifier 'group.wmcore:/MinBias_TuneCP5_14TeV-pythia8/PhaseIITDRSpring19GS-106X_upgrade2023_realistic_v2_ext1-v1/GEN-SIM' not found"}

So, to proceed I need to know a dataset name which exist in Rucio int instance, or should I use Rucio production one?

@vkuznet Valentin, now that we have upgraded central services, could you please add customName attribute to all pileup documents in CMSWEB production?
I was about to create a GH issue to fix a KeyError exception in WorkflowUpdater code, but it's likely better if we just make everything consistent and update the pileup documents in production as well (all the testbed documents already contain that attribute).


added Bot#run puzzle for DefaultBot;

Codecov Report
Base: 82.85% // Head: 82.85% // No change to project coverage :thumbsup:

Coverage data is based on head (e8dda28) compared to base (9f77712).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     82.85%   82.85%
  Complexity       12       12
=========================================
  Files             8        8
  Lines            35       35
=========================================
  Hits             29       29
  Misses            6        6

Impacted Files
Coverage Δ

...ain/java/com/l3r8yj/elegramapi/bot/DefaultBot.java
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@rultor merge

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 1min)


Are you sure it is working?

docker run -it mcr.microsoft.com/windows/nanoserver:1903 cmd.exe
Unable to find image 'mcr.microsoft.com/windows/nanoserver:1903' locally
1903: Pulling from windows/nanoserver
docker: no matching manifest for linux/amd64 in the manifest list entries.
See 'docker run --help'.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a1c4c54-7721-58ce-f77d-be0ef0c687bf
Version Independent ID: 70e52446-1c7b-78ff-67f2-1f6c0d058788
Content: Run your first Windows container
Content Source: virtualization/windowscontainers/quick-start/run-your-first-container.md
Product: windows-server
Technology: windows-containers
GitHub Login: @v-susbo
Microsoft Alias: viniap

I updated the example in Run your first Windows container as it appears Nanoserver 1903 has reached its end date. Thank you for filing this issue.

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Bug 2214023: Fixes Provider ID to show the complete id in node details

Screenshot:

/test odf-console-e2e-aws

/cherrypick release-4.14-compatibility


Remove Netlify?

Should we revisit removing Netlify (form the CI / auto-deploy for docs)? Not sure what the latest on this was, but I don't think it's used anywhere any more.
cc @sabbyanandan

@janniks: Some context -> https://github.com/hirosystems/devops/issues/1267#issuecomment-1648468472
Still, we can and should consolidate if we can make Algolia also work alongside with Vercel, and only that.

Can someone explain the dependency between Algolia and Netlify? I don't get it

@diwakergupta: I don't. You can dig-in, perhaps.

@janniks: Some context -> hirosystems/devops#1267 (comment)
Still, we can and should consolidate if we can make Algolia also work alongside with Vercel, and only that.

@CharlieC3 do you remember the context here?
I'm going to remove the integration and see what happens.

Yeah, I think we didn't need Netlify to get Algolia to work in the end. But I can't say for certain 😬

do you remember the context here?

Not much more than you may already know. I removed Netlify a couple months back, after which Lavanya found that Algolia requires Netlify for some reason and then she owned that effort ever since. She added Algolia configuration in this PR, but I'm not sure if that severed the tie between it and Netlify.

closing as this is no longer an issue


Crash: "signal: killed"

All plugins are up to date.
Scanning putty.exe (7afb56dd48565c3c9804f683c80ef47e5333f847f2d3211ec11ed13ad36061e1) results in the following output from floss:
>> docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v `pwd`:/malice/samples --network="host" malice/engine scan --logs putty.exe

...

time="2018-11-29T10:12:38Z" level=fatal msg="signal: killed" category=exe path=/malware/7afb56dd48565c3c9804f683c80ef47e5333f847f2d3211ec11ed13ad36061e1 plugin=floss

...

The same crash happened with multiple exe files i tested, but some also outputted the expected result. May be an upstream bug.
Docker version:
Docker version:
Client:
 Version:           18.09.0
 API version:       1.39
 Go version:        go1.10.4
 Git commit:        4d60db4
 Built:             Wed Nov  7 00:49:01 2018
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.0
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.4
  Git commit:       4d60db4
  Built:            Wed Nov  7 00:16:44 2018
  OS/Arch:          linux/amd64
  Experimental:     false

Docker info (with some info removed):
Docker info:
Containers: 6
 Running: 1
 Paused: 0
 Stopped: 5
Images: 26
Server Version: 18.09.0
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: c4446665cb9c30056f4998ed953e6d4ff22c7c39
runc version: 4fc53a81fb7c994640722ac585fa9ca548971871
init version: fec3683
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.15.0-39-generic
Operating System: Linux Mint 19
OSType: linux
Architecture: x86_64
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false
Product License: Community Engine

WARNING: No swap limit support

You are running malice in a Mint Linux VM?

I wasn't able to recreate this bug?

No i'm not running malice inside a VM, it's running inside docker directly on my computer with Mint Linux.
You can download the file i'm scanning here: https://the.earth.li/~sgtatham/putty/latest/w64/putty.exe

It's timing out because that file is so big:
docker run --rm -v `pwd`:/malware malice/floss --timeout 300 -V Downloads/putty.exe

I will add better error logging.

added better timeout detection please try again and you can use: MALICE_TIMEOUT=300 malice scan to increase all the plugins timeouts

please re-open if that doesn't fix for you. (remember to docker pull malice/floss first

Now docker run --rm -v `pwd`:/malware malice/floss --timeout 300 -V putty.exe works and it actually also works running the plugin without --timeout 300.
Currently running malice without setting the new timeout results in the Floss section being empty:
>> docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v `pwd`:/malice/samples --network="host" malice/engine scan --logs putty.exe

...

#### Floss
>>

Thank you for the help!


gatsby: window is not defined

Rendering filestack using gatsby throws the following error. Please help.
WebpackError: ReferenceError: window is not defined

  - filestack-react.js:1 Object../node_modules/filestack-react/dist/filestack-react.js
    [lib]/[filestack-react]/dist/filestack-react.js:1:452

@bfine9618
Can you provide version of filestack-react which are you using?

getting the same thing. i am using Next.js and the newest version of filestack-react

Ive partially figured this out. the 'window' object is not available on SSR react projects,  so you need to dynamically import the module on componentDidMount or with a library. Next.js has dynamic imports-- im sure gatsby has something similar. This would be nice if it were mentioned in the docs

I found a solution without dynamic imports:
use the Client import from filestack-js. You have to import the js script into the gatsby-ssr file. I do it in the onRenderBody
export const onRenderBody = ({ setHeadComponents }) => { 	return setHeadComponents([ 		<script key="filestack" src="//static.filestackapi.com/filestack-js/2.x.x/filestack.min.js"/> 	]) }
Then in your file you can import the filestack client in the component like this:
const client = filestack.init('API_KEY')
then you can use a normal html file import with the onChange function that looks like:
onChange={ (e) => client.upload(e.target.files[0]).then(data => console.log(data.url))}


Convert

avoid requiring customers to use utility methods when passing interactions into Relay methods like say_and_wait, etc.

I'm curious what you think of this.

I think it looks pretty straight forward and the logic makes a lot of sense, I don't think it should be too difficult to try to implement something similar in the other SDKs


Fix: Fix process case name on mac/unix.

We were not matching on the right case on mac/unix in ProcessHandler.
Also a minor change to throw illegal state exception for Grid.Driver()
in a method missing a webstest.

:+1: LGTM. Will merge in a bit


fix: Set correct gatsby peer dep

Hello @kremalicious, Gatsby maintainer here 👋
First and foremost, thanks for creating the plugin & maintaining it. Much appreciated!
While looking at your plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.
At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.
Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.
Thanks!

Hi @LekoArts & @pragmaticpat, thanks for dropping by and thanks for the patience with this change


Last page bug due to Pagination

Describe the bug
Right now if the last page does not have all 20 members (the number of people we request per page). The members get repeated. This is probably due to a small bug in hasReachedMax, to fill the 20 limit.
PS: The data is getting called for all the pages (including the last one) as expected, you can see it in the logs when you scroll to the end. Only the members aren't shown on the app.
To Reproduce
Steps to reproduce the behavior:
Go to members page and scroll to the end.
Screenshots

Can I take this ?

Hey @Anirudhk07  sure. assigning it to you

@Anirudhk07  Any update on the issue?

Making this issue available for others as there's no response from @Anirudhk07.

@bharat-1809 can you take this up?

@Techno-Disaster Sure, thanks :)

Hey @bharat-1809  any updates?

@Techno-Disaster I am still working on it. Sorry for the delay.

no problem, we just need a update every 3 days  :) feel free to ask of you are stuck somewhere.

@Techno-Disaster I think the issue is already solved. The list didn't get repeated. Please have a look.

Yes, i looked into this and found out an issue on the backend, lets keep this on hold for now. Will raise an issue on the backend repo


Angular Support

Any Plans on bringing this to Angular?

Hi 👋, unfortunately I have zero experience with Angular so I'm not confident in taking on an Angular version right now. I'll leave this open as a discussion though in case someone else is interested in collaborating 👍


Fix SLURM's publish_pending cron job to push the correct metric

Until now, we seemed to have been publishing the number of pending jobs
to CloudWatch when running with SLURM. This inadvertently caused really
slow scale up.
Signed-off-by: Raghu Raja<EMAIL_ADDRESS>

This isn't correct either. I ran this with a running job that required 2 nodes and it still returned 2.
[ec2-user@ip-172-31-62-167 ~]$ /opt/slurm/bin/squeue -r -h -o '%t %D'
R 2
[ec2-user@ip-172-31-62-167 ~]$ /opt/slurm/bin/squeue -r -h -o '%t %D' | awk '$1 = "PD" {total = total + $2} END {print total}'
2
[ec2-user@ip-172-31-62-167 ~]$ squeue
             JOBID PARTITION     NAME     USER ST       TIME  NODES NODELIST(REASON)
                56   compute hellowor ec2-user  R       4:25      2 ip-172-31-52-51,ip-172-31-53-10


fix capture files in lint workflow

proof this works: https://github.com/wakamex/evm_bots/actions/runs/5615253136/job/15215138827?pr=19#step:9:1

what dis do?


Update importing section in doc

There is a very small issue with the importing file mentioned in the importing section.
The only small update required is to change selectise.bootstrap4 to selectize.bootstrap4

Discovered this one too the other day, made a PR https://github.com/const-se/selectize-bootstrap4-theme/pull/6

PR #6 was merged.


update to golang 1.11

Signed-off-by: Zhou Hao<EMAIL_ADDRESS>

@opencontainers/image-tools-maintainers PTAL

@q384566678
commit 4775f434bc5a5f1a55505b2adddf0101d3dc46b2 might better to be another PR, right?
To update to golang 1.11 one, I'm OK.

@xiekeyang The previous mistakes were all before go1.10, and I don't think there is any change. So I think it is better to have two commits in the same pr.

I added some instructions to the commit.　@xiekeyang PTAL

Got it!
LGTM


Checking if any user workloads before making storage network change

Before making changes for storage network, webhook would check if there are any attached volumes other than system volume. If yes, webhook should prohibit the change from happening
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

Once there is any attached volume (other than system volumes) accessed by the user workload, applying storage network changing would got stuck
Solution:

Webhook would first collect the system volumes list, and check if there is any attached volume not in such list. If yes, webhook should prohibit the change from happening
Related Issue:
#3867
Test plan:

Apply the following yaml by $kubectl apply -f pod_with_pvc.yaml to create a pvc and user workload

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: longhorn-volv-pvc
  namespace: default
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: longhorn
  resources:
    requests:
      storage: 2Gi
---
apiVersion: v1
kind: Pod
metadata:
  name: volume-test
  namespace: default
spec:
  restartPolicy: Always
  containers:
  - name: volume-test
    image: nginx:stable-alpine
    imagePullPolicy: IfNotPresent
    livenessProbe:
      exec:
        command:
          - ls
          - /data/lost+found
      initialDelaySeconds: 5
      periodSeconds: 5
    volumeMounts:
    - name: volv
      mountPath: /data
    ports:
    - containerPort: 80
  volumes:
  - name: volv
    persistentVolumeClaim:
      claimName: longhorn-volv-pvc

Enable Addon -> rancher-logging and rancher-monitoring
Enable Addon -> vm-import-controllercontroller with reasonable volume size
Confirm there are 4 system volumes and 1 user workload volume

System volumes: Prometheus volume, AlertManager volume, Grafana volume and VM importer volume

Apply storage network setting
We should find the operation is prohibited by Webhook with the message please stop all workloads before configuring the storage-network setting
Delete user workload and related pvc by $kubectl delete -f pod_with_pvc.yaml
Apply storage network configuration again, the change would successfully applied

Just FYI:
If we are planning to backport to v1.1.2/v1.1.3, then please consider:
In v1.1.2/v1.1.3, the rancher-monitoring is a managedchart defined per https://github.com/harvester/harvester-installer/blob/v1.1/pkg/config/templates/rancherd-13-monitoring.yaml,  the alertmanager can be disabled on the fly, but prometheus and grafana can't.
It will mean those PVC/PV are always there, and it will block setting storagenetwork when this commit is merged.

v1.2.0 does not have this limitation, those are all addons and they can be disabled/enabled freely.

@Mergifyio backport v1.2


fix: spanner integration test conflict resolution

This resolves the issue https://github.com/GoogleCloudPlatform/dotnet-docs-samples/issues/2021

Hi @amanda-tarafa ,
Opened this PR for internal lex review.
Will let you know once the internal review get competed.
Thanks

I 'll have a look at it tomorrow morning. Thanks.

Hi @amanda-tarafa ,
We are done with the internal review on this one. Please have a look and share your feedback.
Thanks,

Please fix the conflicts so I can review, thanks!

Hey @amanda-tarafa ,
The conflict is now resolved. Please review and provide your feedback.
Thanks


trying to interact with rinkeby contract

added a contract 0x5Dd2321058b4CC9de197D53A8d1C332457a52bB8 but i do not seem to be able to load it on https://remix.ethereum.org/
whenever i click the at address button i get this error
app.js:286155 Uncaught TypeError: Cannot read property 'getAttribute' of undefined
    at ContractDropdownUI.getSelectedContract (app.js:286155)
    at app.js:286245
    at DropdownLogic.loadContractFromAddress (app.js:286349)
    at ContractDropdownUI.loadFromAddress (app.js:286234)

metamask is on rinkeby and my address shows up in the dropdown

Hi @maikelmclauflin , Please make sure you have the contract file corresponding to contract address selected in file manager and compiled using same version. This helps to get the ABI for the contract.

is it resolved? @maikelmclauflin

The same thing happened to me too. After some searching, I found a solution that worked for me. Adding memory into the parameters. I don't know what your contract looks like though so I don't know if this will help.
function Inbox(string memory initialMessage) public {
message = initialMessage;
}


Is "retest this please" (and other comments) case sensitive?

Is matching against this pattern case sensitive?

It looks like it isn't! Question answered :)


Build error related to XLA and absl

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
2.16.1
Custom code
No
OS platform and distribution
Linux Ubuntu 22.04
Mobile device
No response
Python version
3.11.7
Bazel version
6.5.0
GCC/compiler version
11.4.0
CUDA/cuDNN version
11.8.0/<IP_ADDRESS>
GPU model and memory
No response
Current behavior?
When building TF from source using the Spack package manager, I see the following build failure:
ERROR: /tmp/spackkiy_sjk0/dfa266778fb055fec5b77ad2acb73759/external/local_xla/xla/service/gpu/kernels/BUILD:157:13: Compiling xla/service/gpu/kernels/topk_kernel_bfloat16.cu.cc failed: (Exit 1): crosstool_wrapper_driver_is_not_gcc failed: error executing command (from target @local_xla//xla/service/gpu/kernels:topk_kernel_cuda)
...
external/com_google_absl/absl/strings/internal/str_format/bind.h: In constructor ‘absl::lts_20230802::str_format_internal::FormatSpecTemplate<Args>::FormatSpecTemplate(const absl::lts_20230802::str_format_internal::ExtendedParsedFormat<absl::lts_20230802::FormatConversionCharSet(C)...>&)’:
external/com_google_absl/absl/strings/internal/str_format/bind.h:172:1: error: parse error in template argument list
  172 |     CheckArity<sizeof...(C), sizeof...(Args)>();
      | ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_absl/absl/strings/internal/str_format/bind.h:172:63: error: expected ‘;’ before ‘)’ token
  172 |     CheckArity<sizeof...(C), sizeof...(Args)>();
      |                                                               ^
external/com_google_absl/absl/strings/internal/str_format/bind.h:173:147: error: template argument 1 is invalid
  173 |     CheckMatches<C...>(absl::make_index_sequence<sizeof...(C)>{});
      |                                                                                ^
external/com_google_absl/absl/strings/internal/str_format/bind.h:173:151: error: expected primary-expression before ‘{’ token
  173 |     CheckMatches<C...>(absl::make_index_sequence<sizeof...(C)>{});
      |                                                                                ^
external/com_google_absl/absl/strings/internal/str_format/bind.h:173:151: error: expected ‘;’ before ‘{’ token
external/com_google_absl/absl/strings/internal/str_format/bind.h:173:153: error: expected primary-expression before ‘)’ token
  173 |     CheckMatches<C...>(absl::make_index_sequence<sizeof...(C)>{});
      |                                                                                ^
Target //tensorflow/tools/pip_package:build_pip_package failed to build
INFO: Elapsed time: 1238.631s, Critical Path: 57.51s
INFO: 17066 processes: 6004 internal, 11062 local.
FAILED: Build did NOT complete successfully

Standalone code to reproduce the issue
See the below build log for steps to reproduce the issue.
Relevant log output

build log
build env

Note: this only occurs when I build with CUDA support. I doesn't occur if I build for the CPU.

Hi @adamjstewart ,
Could you update the CUDA version, For tensorflow-2.16.1 we need to update CUDA 12.3. Please refer source here.
Can you please execute your code using Latest CUDA Version (12.3) and let us know if the issue still persists?
Thank you!

Thanks, that seems to have done the trick!


Remove ImproveOSM

It looks like the ImproveOSM project is being shut down and Grab is requesting that editors remove it.
https://github.com/openstreetmap/iD/issues/10302
We should remove it from Rapid too.

done in #1483


Add logging, clean up some exception handling.

This pull request primarily adds logging to python-etcd.
However, while I was writing it, I spotted that some of the exception handling appeared to be incorrect: only certain urllib3 and httplib exceptions were triggering a reconnect to another server in the cluster.  I cleaned that up while I was adding the logging.  Please correct me if I've misinterpreted the expected exception-handling behaviour!
The NullHandler idea is recommended here as a good way to prevent spurious output if the user isn't expecting your library to log:  https://lukasa.co.uk/2014/05/A_Brief_Digression_About_Logging/
Fixes #32.

Looks like this has a bug on Python 3, I'll investigate.

Fixed the import error, unit tests now pass.

Thaks this is a great patch, I'll integrate it manually onto the current master, which has slightly changed.

Great, thanks!


Sweep: add public home page

Details
Copy and convert from vue/vuetify to laravel blade and livewire all of the home layout, layout components and home page from the repository github.com/liberu-genealogy/genealogy-nuxt3
Write in clean sections so that the layout can be reused for future pages. The old home page is written in vue 3, nuxt 3 and vuetify. The current project is laravel livewire 3 using filament 3.2 and blade.
It needs to be placed under the public panels pages and the blade new home layout in standard location.

Checklist

[X] Create resources/views/layouts/home.blade.php ✓ https://github.com/liberu-genealogy/genealogy-laravel/commit/c482328ff5dc6ef66a1eb3e1713b11d2e09fd984 Edit
[X] Running GitHub Actions for resources/views/layouts/home.blade.php ✓  Edit
[X] Create resources/views/home.blade.php ✓ https://github.com/liberu-genealogy/genealogy-laravel/commit/2026c968967cc4ebe7d37d7198bec76cdc4ed903 Edit
[X] Running GitHub Actions for resources/views/home.blade.php ✓  Edit
[X] Create app/Http/Livewire/HomePage.php ✓ https://github.com/liberu-genealogy/genealogy-laravel/commit/31efe0f2ab284868251a92fad5d42b851dd3ad17 Edit
[X] Running GitHub Actions for app/Http/Livewire/HomePage.php ✓  Edit
[X] Modify routes/web.php ✓ https://github.com/liberu-genealogy/genealogy-laravel/commit/4beba268e322c3d2421643974f1be946c759ed5e Edit
[X] Running GitHub Actions for routes/web.php ✓  Edit
[X] Create public/css/home.css ✓ https://github.com/liberu-genealogy/genealogy-laravel/commit/1a5d0d1dad2f5482b475cc8dff875ad30d3db66f Edit
[X] Running GitHub Actions for public/css/home.css ✓  Edit
[X] Create public/js/home.js ✓ https://github.com/liberu-genealogy/genealogy-laravel/commit/4701ed6441492a7115721ddb69b752cfd9b59416 Edit
[X] Running GitHub Actions for public/js/home.js ✓  Edit

Must use design from files under layouts/home, header, home and footer from components/ and pages/home.vue at https://github.com/liberu-genealogy/genealogy-nuxt3


Livewire tmp path

Bug description
when upload using livewire, file will be store in tmp folder (livewire_tmp) before store permanently into storage. when upload using tenant route, all upload file will store in central storage and not in tenant aware storage.

error when to store permanently into storage:
fopen(C:\laragon\www\auditapptenant\storage/tenant_79aafb48-98ca-4f71-9b44-90b558a224f1/app\livewire-tmp/cIMWmTcd2HNBQumlrMf6mZYK9HYyl0-metaRGF0YSBJbXBvcnQueGxzeA==-.xlsx): Failed to open stream: No such file or directory
tenant identification using Stancl\Tenancy\Middleware\InitializeTenancyByDomainOrSubdomain
Steps to reproduce
use Stancl\Tenancy\Middleware\InitializeTenancyByDomainOrSubdomain
upload using subdomain tenant route
store file permanently into storage
Expected behavior
livewire_tmp folder exist in tenant aware storage
Laravel version
10.43.0
stancl/tenancy version
3.7.4

If you're on Livewire 3, try this in TenancyServiceProvider::boot():
FilePreviewController::$middleware = ['web', InitializeTenancyByDomain::class]; // specify the right identification middleware

And set the livewire.temporary_file_upload.middleware config key to ['throttle:60,1', InitializeTenancyByDomain::class] (again replacing your identification middleware there).

Thanks you. This has fix the issue. Maybe this need to documented in V4.

Updated in docs


FI: Kotipizza

Brand : Kotipizza
Category : restaurant
Opening rule : shops open with adapted opening hours: only take-away or by delivery
Wikipedia / Wikidata : https://fi.wikipedia.org/wiki/Kotipizza
Opening hours : https://www.kotipizza.fi/ravintolat
Source : https://www.kotipizza.fi

Integrated, thanks :+1:


Provide CHANGELOG

Hi,
The latest update has breaking changes, but I can't figure out what changed. Can you you perhaps add a CHANGELOG.MD to let user know what has been changed!
Thanks

Never mind, I got it from the releases page


OAuth2: random username

Hi,
I noticed the username is random. I wonder if that is because my OAuth does not provide a user ID, so I use the email instead, which contains invalid characters. The invalid characters could just be replaced, if that is the problem.
It would be nice to have usernames that are based on the desired username, instead of having random usernames.

aud and sub cannot be used to identify the user, unluckily
name seems a good idea to me, actually, but it would still fail with non-ascii characters: Must use the character set "a-z", "0-9", " - . _"; therefore names containing "øåæ" and other valid characters are not allowed


describe GitOps Toolkit

@hiddeco I feel the features section still describes Flux v2
Would you prefer a detailed discussion of features (which would likely require a bit more background...?) - WDYT?
Addresses: #32

@dholbach it does not highlight any of the features as lead out in https://toolkit.fluxcd.io/#more-detail-on-whats-in-flux


UI Fixes

Switch to using textContent instead of innerText as it's the standard, more performant and FF 35-45 doesn't support innerText.
Fix block drag opacity to apply just on the block and not the stack
Fix dropdown text to apply the monaco font instead of the default
Pull a pxt-blockly release that has further offline fixes (including the dropdown arrow svg)
Fix card width in side doc

What is the data of FF version usage?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Sam El-Husseini<EMAIL_ADDRESS>Sent: Wednesday, September 27, 2017 7:11:47 AM
To: Microsoft/pxt
Cc: Subscribed
Subject: [Microsoft/pxt] Switching to using textContent instead of innerText + UI fixes (#3060)

Switch to using textContent instead of innerText as it's the standard, more performant and FF 35-45 doesn't support innerText.
Fix block drag opacity to apply just on the block and not the stack
Fix dropdown text to apply the monaco font instead of the default
Pull a pxt-blockly release that has further offline fixes (including the dropdown arrow svg)

You can view, comment on, or merge this pull request online at:
https://github.com/Microsoft/pxt/pull/3060https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=cSBtKtWJwQ6rsjmLFgy9GqVQXD1YhD1T1KhVjx%2B5Q9c%3D&reserved=0
Commit Summary

Switching to using textContent instead of innerText + UI fixes

File Changes

M pxtblocks/blocklyloader.tshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-0&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=4thRRokFHm35003%2BIZzMn7rWwuOZN1ESPpOOV36SCBI%3D&reserved=0 (6)
M pxtblocks/codecardrenderer.tshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-1&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=Kc1KI7gBy2%2BBkLcnP7JPeUMEKEv3RVnv0tKkQDDctx4%3D&reserved=0 (2)
M pxtblocks/fields/field_note.tshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-2&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=wnZHm9yq2Ucwdz3X54ZHGe89XgqaI8myqI6QoaJWINQ%3D&reserved=0 (18)
M theme/blockly-core.lesshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-3&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=pLxzRZkyXx595eo7hFIgFppoU%2Fjc9cJgivKvflnjJj0%3D&reserved=0 (8)
M theme/common.lesshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-4&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=ZnIljc7PlwhyhpOAYoLHB3Tzq9zxpWY7faZDRX8DOSA%3D&reserved=0 (12)
M theme/fieldeditors.lesshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-5&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=kCE02LOtGeyQIZp39tdnD9T8XRUXDfzO26Zd2uyOFH0%3D&reserved=0 (99)
M theme/themes/pxt/globals/site.variableshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-6&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=JUVSkHcYD%2B7MxuX7ZpWcpAcUSZMXKQ5BRpY6OWSDbLw%3D&reserved=0 (4)
M webapp/public/blockly/blockly_compressed.jshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-7&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=7AxZd8i6ponwKLLy5XDeDqRI0YYiF3vLNgMmupivouE%3D&reserved=0 (4)
M webapp/public/run.htmlhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-8&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=tSK9RGC%2FgGzRNmmEEb3TrBf73QxGniiYNMhAlMHEVJM%3D&reserved=0 (2)
M webapp/src/app.tsxhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-9&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095746896&sdata=y58wi49Jr5YB2AmHyB0YlKqfaYg19Q3A4ZWFQVQ%2FgPk%3D&reserved=0 (4)
M webapp/src/monaco.tsxhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%2Ffiles%23diff-10&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095903141&sdata=pLL%2F%2FYZkf6FR09PdD3ocf7O%2BuPuONZB5R6px%2FWLJEEo%3D&reserved=0 (10)

Patch Links:

https://github.com/Microsoft/pxt/pull/3060.patchhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060.patch&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095903141&sdata=fEVWqs51dgMQFeby9iIx5GZjvH6MRYxydvfe%2Bptlazg%3D&reserved=0
https://github.com/Microsoft/pxt/pull/3060.diffhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060.diff&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095903141&sdata=FNaxr8cn0mir7hvMlTFDtWWxbYtPdKQVORuWYomrGWY%3D&reserved=0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095903141&sdata=ngnldg4EXyz3Sy9bQcgkXP9E1T%2FZI8K0PypPrpEgNzw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KSQKw3dQ1xebF1zPUL-5ywTx2Tkcks5smleigaJpZM4Pl1VN&data=02|01|jhalleux%40microsoft.com|e21415fdc0ed4d142e8408d505b1b12d|72f988bf86f141af91ab2d7cd011db47|1|0|636421183095903141&sdata=Vv1oHlpywiTMfRJ6X5rSY3zJ%2F9lJg%2FcMSUbSM9h3Qr0%3D&reserved=0.

Roughly 50% on FF 55.
2% on 38
2% on 45
1% on 43
< other <40 account for about 2%
so roughly 5-7% of FF users affected by the innerText issue.
Granted as described in http://kellegous.com/j/2013/02/27/innertext-vs-textcontent/ the fix here is not only to standard, but also more performant. For something like the monaco toolbox that we continually call this, it makes sense to make that change.

LGTM
Get Outlook for iOShttps://aka.ms/o0ukef

From: Sam El-Husseini<EMAIL_ADDRESS>Sent: Wednesday, September 27, 2017 7:50:12 AM
To: Microsoft/pxt
Cc: Peli de Halleux; Review requested
Subject: Re: [Microsoft/pxt] UI Fixes (#3060)
Roughly 50% on FF 55.
2% on 38
2% on 45
1% on 43
< other <40 account for about 2%
so roughly 5-7% of FF users affected by the innerText issue.
Granted as described in http://kellegous.com/j/2013/02/27/innertext-vs-textcontent/https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fkellegous.com%2Fj%2F2013%2F02%2F27%2Finnertext-vs-textcontent%2F&data=02|01|jhalleux%40microsoft.com|bf55fc65b7424cac75fc08d505b70f3f|72f988bf86f141af91ab2d7cd011db47|1|0|636421206148386827&sdata=DNjKHszehX8bq8oXPYd5tWm7w03KuuPes8qnNVXIOyo%3D&reserved=0 the fix here is not only to standard, but also more performant. For something like the monaco toolbox that we continually call this, it makes sense to make that change.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fpull%2F3060%23issuecomment-332546878&data=02|01|jhalleux%40microsoft.com|bf55fc65b7424cac75fc08d505b70f3f|72f988bf86f141af91ab2d7cd011db47|1|0|636421206148386827&sdata=GDbBkS3kCcUkJlRbWZbYrr99y%2FBZddU1GUq7cTtOxsg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KZgfAEGVzRfbxQJFL9JVT3l0Bk5gks5smmCkgaJpZM4Pl1VN&data=02|01|jhalleux%40microsoft.com|bf55fc65b7424cac75fc08d505b70f3f|72f988bf86f141af91ab2d7cd011db47|1|0|636421206148386827&sdata=lTK0tv24O%2Fh0ZALnUnbD02%2FJFPe1S5vFLnDqLhx7NpQ%3D&reserved=0.


New Device: Sonoff Pow

devices.txt
Hi,
Currently I have a couple of sonoffs (but most are flashed to different firmware). There is one I would like to use in home assistant (and which is currently not supported by your script :)). The sonoff pow is basically a sonoff basic with power measurement capabilities (which also means that if flashed to alternate firmware you will need to recalibrate).
Attached is my output file (note I noticed my wifi password being in there so it is replaced by xxxx). Would be great if you could add the sonoff pow (and would be even better if power measurement is also presented in home assistant).
With kind regards,
StaticCube / Ferry

hi there,
thanks for providing the output! (and sorry about the password showing part, it's the first time someone mentions it :| as it's not present in all the devices it seems. i'll update the debug script to remove that too in the future)
by your description, i'm still uncertain if you tried the component and it's not working at all or you just consulted the compatibility list? taking a quick look at the file the switch should at least show up in HA and i'm having a good feeling that you should be able to toggle it also (as you said, it's pretty much a copy of sonoff basic and those work for sure)
nonetheless, your device dump has valuable information and I definitely plan to include the power usage measurement also, i was just waiting for someone to request it :D ( + as soon as i figure out how the data is laid out 😉 ) but this will happen sometime next year

Thanks guys.
+1
Is Sonoff Pow R2 will be same ?

@SergeyAnokhin as stupid as this might sound I'm still trying to figure what are the physical differences between Pow and Pow R2 😄
but give it a try and let me know if it works! it wouldn't hurt if you could provide also the devices.json dump file also. in theory you should at least be able to toggle on/off the device if it follows the same structure as the one listed above

As far as I can see this is the original sonoff pow (not the r2). As far as I can see on various sites this is the difference:
offering 99% measurement accuracy, overload protection defined by the user, and various other features like the ability to export data


SimpleRtspPlayer - Should audio work?

I am testing the SimpleRtspPlayer under vs2017, video works fine but should audio work?
I am using a rtsp feed that works with audio in VLC. I have debugged it and I can see the audio frames being decoded but nothing gets played?

sorry I see this issue
https://github.com/BogdanovKirill/RtspClientSharp/issues/35
says its not currently impliemented, any pointers on whats required? From debugging it appears that the audio is being decoded by ffmpeg so I assume I just need to send the decoded bytes to a something like NAudio to play them? or as its already decoded is it simpler than that?


Fix #116 param bugs (based on @monkoose patch)

It fixes jedi param bugs in #116.
@monkoose Please check it.

Just for reference: it seems to come from here: https://github.com/davidhalter/jedi/blob/5427b02712828b2875d35b5ee1c8b5e58f820537/jedi/api/classes.py#L542-L543 ?!
@davidhalter
Is this the correct way to approach this?  (getting rid of the param prefix for params)

Fixed.

Just for reference: it seems to come from here: https://github.com/davidhalter/jedi/blob/5427b02712828b2875d35b5ee1c8b5e58f820537/jedi/api/classes.py#L542-L543 ?!

So as i said - its a feature. But does @davidhalter know that it is looking ugly in completion engines?
@Shougo as work patch - works perfectly for me. And the part if desc: - removes blank-wrong parameters just as needed.
But i don't sure you need to check explicitly if desc.startswith('param ') or desc == 'param': In my opinion if desc.startswith('param') does the same thing.

But i don't sure that you need to check explicitly if desc.startswith('param ') or desc == 'param':

This is hack.
So it should be checked explicitly.
It may be fixed in the later version.

Ok. I agree.

@davidhalter
Is this the correct way to approach this? (getting rid of the param prefix for params)

The problem is actually that there is no API for this. What we've been using was the description. The description IMO is just there to give you a better impression with what you're dealing with. If you just want the name of a parameter, there's an API for that. But there's definitely no API for stuff like **kwargs.
So in conclusion if you want that, try to propose an API for it :)

Merged


[Bug]:

What happened?
When running backend with npm only, I have setup my keys I believe correctly and try to interact with OpenAI but upon
submitting my question, the socket to openai closes without much explanation but I do see this in the logs of /api
I see this in error log only:
{"level":"error","message":"There was an uncaught error: Cannot convert a Symbol value to a string","stack":"TypeError: Cannot convert a Symbol value to a string\n
at Object. (/usr/local/LibreChat/api/config/parsers.js:138:43)\n
at walker (/usr/local/LibreChat/node_modules/traverse/index.js:169:16)\n
at /usr/local/LibreChat/node_modules/traverse/index.js:190:17\n
at Array.forEach ()\n
at forEach (/usr/local/LibreChat/node_modules/traverse/index.js:19:30)\n
at walker (/usr/local/LibreChat/node_modules/traverse/index.js:185:4)\n
at walk (/usr/local/LibreChat/node_modules/traverse/index.js:208:3)\n
at Traverse.forEach (/usr/local/LibreChat/node_modules/traverse/index.js:255:15)\n
at Printf.template (/usr/local/LibreChat/api/config/parsers.js:132:18)\n
at Printf.transform (/usr/local/LibreChat/node_modules/logform/printf.js:11:26)"}
and this in debug log only:
2023-12-29 22:57:32 info: Connected to MongoDB
2023-12-29 22:57:33 debug: [indexSync] There are 0 messages in the database, 0 indexed
2023-12-29 22:57:33 debug: [indexSync] There are 0 convos in the database, 0 indexed
2023-12-29 22:57:33 info: Server listening at http://<IP_ADDRESS>:3080
2023-12-29 22:57:35 debug: [validateJson] files
[""Ai_PDF.json"",""BrowserOp.json"",""Dr_Thoths_Tarot.json"",""DreamInterpreter.json"",""VoxScript.json"",""askyourpdf.json"",""drink_maestro.json"",""earthImagesAndVisualizations.json"",""image_prompt_enhance
2023-12-29 22:57:37 debug: [validateJson] files
Steps to Reproduce
npm run backend:dev
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The same error message was reported on discord: https://discord.com/channels/1086345563026489514/1190419554376110120

what is your node.js version?

v18.18.2

The same error message was reported on discord: https://discord.com/channels/1086345563026489514/1190419554376110120

Can you send me an invite to view link or paste contents I'm not authorized to view it

The same error message was reported on discord: https://discord.com/channels/1086345563026489514/1190419554376110120

Can you send me an invite to view link or paste contents I'm not authorized to view it

here it is: https://discord.librechat.ai

v18.18.2

Ok, I can't really reproduce it, this is why I asked for the node version in case that was the culprit. Need a bit more context.
Is this just upon running the server? How exactly did you install LibreChat?

v18.18.2

Ok, I can't really reproduce it, this is why I asked for the node version in case that was the culprit. Need a bit more context.
Is this just upon running the server? How exactly did you install LibreChat? Also what is your operating system?

I tried earlier the docker-compose method but I could not seem to connect to the local port or get it to actually use the host and domain and port values from .env so I embarked on manually building it for Linux/Digital Ocean docs generally.
It is on Rock Linux 9.2  and aforementioned Node version running from /usr/local/Librechat
I wish this was as easy to get running as PandoraAi was (btw thanks to you Danny) but its just so simple, Libre looks worthwhile to get integrated and running.
If you want to dm me on discord I can add your pk to ssh if you want to have a look.

I wish this was as easy to get running as PandoraAi was (btw thanks to you Danny) but its just so simple, Libre looks worthwhile to get integrated and running.

I do think it's easy and I will have a one-click setup solution soon for DigitalOcean.
If you have node/npm setup and running, can you try npm run reinstall from the project directory?

Done then just rerun api:dev?

Oh and btw I did see this one warning only:

This can be ignored. It's planned to optimize bundles but it's a non-issue at this point.

Done then just rerun backend:dev?

Yes, then run the app.

➜ npm run backend:dev

<EMAIL_ADDRESS>backend:dev
cross-env NODE_ENV=development npx nodemon api/server/index.js

[nodemon] 3.0.2
[nodemon] to restart at any time, enter rs
[nodemon] watching path(s): .
[nodemon] watching extensions: js,mjs,cjs,json
[nodemon] starting node api/server/index.js
2023-12-29 23:55:14 info: REDIS_URI not provided, or USE_REDIS not set. Redis module will not be initialized.
2023-12-29 23:55:15 warn: Meilisearch error, search will be disabled
2023-12-29 23:55:16 info: Connected to MongoDB
2023-12-29 23:55:16 error: [indexSync] error fetch failed
2023-12-29 23:55:16 info: Server listening at http://<IP_ADDRESS>:3080

So I then go here http://kro.ma:3080/c/new
and type 'hi' in chat or whatever and it immediately gives aforementioned error on backend:dev console
and stops till restarted

As discussed on discord, traverse npm module at version 0.6.7 may be causing the issue, and you might've updated the package somehow. I was able to reproduce with this version, as well as took other measures to completely avoid the issue. I will avoid bumping that package for now, too.


Feature request: waitUntil(condition, timeout) for ElementCollections

Should have method $$().waitUntil(collectionCondition, timeout) which allows to set timeout for a single action.

Duplicate of https://github.com/codeborne/selenide/issues/601
Was released in Selenide 4.13.0


doing something at client disconnect (onClose) and maybe phpdoc to update?

Hello,
trying to learn this async stuff by extending the example in the readme to make a small game, going quite ok so far.
Now in the server I wanted to detect the disconnection of one client in order to remove all the player's data from the server so I went for a callback to pass to the $client's onClose() method:
use Amp\Http\Server\Driver\RemoteClient; // added for onClose(...)

// ...

public function handleHandshake(Request $request, Response $response): Promise
{
    global $logger;

    $client = $request->getClient(); // Amp\Http\Server\Driver\RemoteClient

    // ... stuff ...
    // ... stuff ...
    // ... stuff ...

    $client->onClose(function (RemoteClient $remoteClient) use ($logger) {
        $logger->warning(sprintf('CLOSED'));
    });

    return new Success($response);
}

// ...

Is that the right way to go? It seems to work but I don't know if it's the right optimal way :)
Also, the phpdoc of Amp\Websocket\Client onClose interface says:
/**
 * Attaches a callback invoked when the client closes. The callback is passed this object as the first parameter,
 * the close code as the second parameter, and the close reason as the third parameter.
 *
 * @param callable(Client $client, int $code, string $reason) $callback
 */

But it seems only one parameter is passed instead, the first. I get a Fatal Error if I include $code and $reason. In the implementation of Amp\Http\Server\Driver\RemoteClient's close():
        foreach ($onClose as $callback) {
            Promise\rethrow(call($callback, $this));
        }

Did you debug the code with Xdebug ?

@elovin
Indeed the difference in the class was was exactly the reason.
Because the $client returned by $request->getClient() inside ::handleHandshake of the example in the readme.md is an Amp\Http\Server\Driver\RemoteClient, whereas the $client passed as parameter of ::handleClient is an Amp\Websocket\Client (or Amp\Websocket\Rfc6455Client as var_dump reports at runtime) and that provides the close callback with the three parameters.


fix(errorRetryCount): Make sure fetcher doesn't run endlessly when errorRetryCount is set to 0

The following is sample code using<EMAIL_ADDRESS>and<EMAIL_ADDRESS><template>
  <div>{{ data }}</div>
</template>

<script lang="ts">
import { defineComponent } from '@vue/composition-api';
import useSWRV from 'swrv';

const fetcher = () => {
  console.count('fetcher');
  return Promise.reject(new Error('rejected!'));
};

export default defineComponent({
  name: 'App',
  setup() {
    const { data } = useSWRV('/api/v2/foo', fetcher, {
      errorRetryCount: 0,
    });

    return {
      data,
    };
  },
});
</script>

When you run the code above, you'll see the following in your browser's console:
fetcher: 1
fetcher: 2
fetcher: 3
fetcher: 4
fetcher: 5
fetcher: 6
fetcher: 7
fetcher: 8
fetcher: 9
fetcher: 10
fetcher: 11
fetcher: 12
fetcher: 13
fetcher: 14
fetcher: 15
fetcher: 16
fetcher: 17
fetcher: 18
fetcher: 19
fetcher: 20
...(endlessly)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


OneDrive: "Sign in to turn on offline access to your lists" pointing to removed work account

Hi Team
As already reported in the community by forty-two other suffering customers in a thread viewed over a thousand times, this BUG is haunting me every single day and it drives me CRAZY.
https://answers.microsoft.com/en-us/msoffice/forum/all/remove-sign-in-to-turn-on-offline-access-to-your/94c46653-75b7-4447-9bc4-0542b7637822

Please have a look into this.
Best regards,
Remo Glanzmann
Logol AG
6300 Zug, Switzerland

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1787d668-b65b-8de4-a182-2b22b43e429e
Version Independent ID: 64957a69-2f4b-3947-d631-ac9c29e6f68b
Content: Introduction to SharePoint and OneDrive - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/introduction.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

I opened a support case (TrackingID#2303141420000146). They have no clue. Support suggested to just switch off List Sync
•	Navigate to HKLM\SOFTWARE\Policies\Microsoft\OneDrive] "DisableNucleusSync" = "dword:1"
But in the meantime I found the formers employers servers listed in this file:
"C:\Users\remog\AppData\Local\Microsoft\OneDrive\ListSync\Business1\settings\Microsoft.ListSync.db"
As other users already found out, simply deleting the folder seems not to solve the issue, there seems to be a cloud-side reference somewhere as well.
How on earth can we get a developer to properly investigate this issue? 54 users need a solution. The community thread has over 1300 views and counting ...
https://answers.microsoft.com/en-us/msoffice/forum/all/remove-sign-in-to-turn-on-offline-access-to-your/94c46653-75b7-4447-9bc4-0542b7637822


Option "Always Use Working Directory" doesn't work well

Version: 1.0.92
Platform: win32 10.0.18362
Shell: Powershell
New terminal doesn't open where the previous terminal was working, it opens home ~. And option "Always Use Working Directory" is disabled.
When I enabled "Always Use Working Directory"  and then disabled it, it works sometimes...

Please see #1703


tests: don't use hardcoded kubevirt namespace

What this PR does / why we need it:
Some tests use hardcoded "kubevirt" namespace when looking for KubeVirt resources.
As a result, those tests fail to run an a cluster installed using hyperconverged-cluster-operator which create kubevirt resources in "kubevirt-hyperconverged" namespace.
This PR improve failing tests to make them use the value of the argument --installed-namespace instead of hardcoded "kubevirt".
Release note:

NONE

/cc @stu-gott @davidvossel

These are needed to run the tests in non-standard namespaces.

ci test please

Updated with make generate results.

/retest

/retest

/retest


Supporting input type=email

Just checked and it isn't working with input type email, i have modified the line 995 in Autosuggest.js to this
if (input.tagName === 'TEXTAREA' || (input.tagName === 'INPUT' && input.type === 'text') || (input.tagName === 'INPUT' && input.type === 'email')) {
still no avail, any ideas?

@anandphulwani can you explain what do you mean by no avail? Please post the expected behavior and actual behavior

@anandphulwani can you explain what do you mean by no avail? Please post the expected behavior and actual behavior

@anandphulwani can you explain what do you mean by no avail? Please post the expected behavior and actual behavior.

Enviroment Details:
Windows 10
Firefox, Firefox Developer Edition
I am swapping the input types of "email" with "text", it works on "text" but not on "email"
Expected Behaviour: Dropdown of suggestions should load.
Actual Behaviour: Dropdown does not load.
I have further debugged and found out that the function var getCursorPosition = function getCursorPosition(input) contains input.selectionStart, input.selectionEnd which is not permitted on input type "email", as mentioned in the first comment on the stackoverflow link, and i quote

Selection is only permitted with text/search, URL, tel and password.

Any further suggestions?

@anandphulwani can you explain what do you mean by no avail? Please post the expected behavior and actual behavior.

Enviroment Details:
Windows 10
Firefox, Firefox Developer Edition
I am swapping the input types of "email" with "text", it works on "text" but not on "email"
Expected Behaviour: Dropdown of suggestions should load.
Actual Behaviour: Dropdown does not load.
I have further debugged and found out that the function var getCursorPosition = function getCursorPosition(input) contains input.selectionStart, input.selectionEnd which is not permitted on input type "email", as mentioned in the first comment on the stackoverflow link, and i quote

Selection is only permitted with text/search, URL, tel and password.

Any further suggestions?

I have gone through the issue you have mentioned, looks like as of now there is no easy way to get current selection in email type fields, I will have to dig deeper to find a solution which might take some time.
For now you can use type="text" with a pattern or custom validation function to get it working

I have gone through the issue you have mentioned, looks like as of now there is no easy way to get current selection in email type fields, I will have to dig deeper to find a solution which might take some time.
For now you can use type="text" with a pattern or custom validation function to get it working

I have gone through the issue you have mentioned, looks like as of now there is no easy way to get current selection in email type fields, I will have to dig deeper to find a solution which might take some time.
For now you can use type="text" with a pattern or custom validation function to get it working

Do you mind if i dig more into this, i want to understand why do you need selection, if you just need caretposition, there are a lot of jquery plugins alternative we can use like this one, i can work out the code for caretposition, but i need to do know the requirement for the selection functionality.

I have gone through the issue you have mentioned, looks like as of now there is no easy way to get current selection in email type fields, I will have to dig deeper to find a solution which might take some time.
For now you can use type="text" with a pattern or custom validation function to get it working

Do you mind if i dig more into this, i want to understand why do you need selection, if you just need caretposition, there are a lot of jquery plugins alternative we can use like this one, i can work out the code for caretposition, but i need to do know the requirement for the selection functionality.

@anandphulwani the selection is not just for caret position, I am using selectionStart & selectionEnd to support autosuggest over selecting multiple characters too, when there is a selection the logic will ignore everything inside the selection and considers the text before the selection as trigger and upon choosing a value selection will be replaced

@anandphulwani the selection is not just for caret position, I am using selectionStart & selectionEnd to support autosuggest over selecting multiple characters too, when there is a selection the logic will ignore everything inside the selection and considers the text before the selection as trigger and upon choosing a value selection will be replaced

@chandrasekhar-ambula Tried a lot of libraries for caret position, but no avail, the thing which was most close to the solution, was this , see if it helps.
Another cheeky workaround, could be change it to type="text" on focus and change it back to type="email" on blur.

@chandrasekhar-ambula Tried a lot of libraries for caret position, but no avail, the thing which was most close to the solution, was this , see if it helps.
Another cheeky workaround, could be change it to type="text" on focus and change it back to type="email" on blur.


Add possibility to lazy-load translations after switching locale

Save preloaded locales and lazy-load locales if current locale was not preloaded

Resolved #38


[RUNTIME][OBJECT] Introduce static slots for common objects.

The _type_child_slots can be used to enable quick type checking optimization
by checking the whether the type index is within the bound.
This PR enables these static slots:

Introduce a static assert to avoid the scenario when a developer forget to
_type_child_slots when the field is set for the type's parent.
Revamp and assign static type index to common runtime objects
Add a DumpTypeTable call to allow developer monitor the current situation
of type table and offers suggestions for the slots(ideally the slots equals
the number of children so there is no overflow.

cc @jroesch @zhiics @wweic @junrushao1994 @yzhliu

current summary of the type table(non leaf nodes)
$python  -c "import tvm; tvm.runtime._ffi_api.DumpTypeTable(1)"
[9] BaseExpr	parent=runtime.Object	num_child_slots=58	num_children=58
[10] PrimExpr	parent=BaseExpr	num_child_slots=34	num_children=34
[11] tir.Var	parent=PrimExpr	num_child_slots=1	num_children=1
[45] RelayExpr	parent=BaseExpr	num_child_slots=22	num_children=22
[49] BaseFunc	parent=RelayExpr	num_child_slots=2	num_children=2
[52] relay.TempExpr	parent=RelayExpr	num_child_slots=0	num_children=2
[68] IntSet	parent=runtime.Object	num_child_slots=0	num_children=1
[71] Type	parent=runtime.Object	num_child_slots=14	num_children=14
[73] relay.BaseTensorType	parent=Type	num_child_slots=1	num_children=1
[84] TypeConstraint	parent=Type	num_child_slots=1	num_children=1
[86] Attrs	parent=runtime.Object	num_child_slots=0	num_children=93
[98] transform.Pass	parent=runtime.Object	num_child_slots=0	num_children=4
[102] printer.DocAtom	parent=runtime.Object	num_child_slots=0	num_children=2
[106] Operation	parent=runtime.Object	num_child_slots=0	num_children=7
[107] BaseComputeOp	parent=Operation	num_child_slots=0	num_children=2
[116] IterVarRelation	parent=runtime.Object	num_child_slots=0	num_children=4
[131] Stmt	parent=runtime.Object	num_child_slots=15	num_children=15
[256] relay.Pattern	parent=runtime.Object	num_child_slots=0	num_children=4

I am a bit concerned about the current strategy that we allocate the exact number of children slots: A third party library may inherit some of those objects, which makes their #children increase. Shall we allocate a bit more, like align to 2^k, to make 3rd party inheriting less troublesome?

The inhertitance will still work for 3rdparty, because overflow is enabled in all these cases, the support path will be like the same before this PR. we could discuss whether or not we want to reserve some slots when we have a good idea of potential additional inheritence.

I think it is good for now. We can discuss about the additional slots later for potential inheritance.

My one worry is that this is a bit fragile, what happens if the number of children changes but we forget to update the bound?

The code still works, the overflow children will need to go through the overflow path, and call https://github.com/apache/incubator-tvm/blob/master/include/tvm/runtime/object.h#L889(which is slightly slower than bound checking).
Note that the original code set all the child_slots to 0, so everything overflows.

ping @jroesch


Added 100 Days of LeetCode

@Krest-Coder this is really a great contribution ✨
Please give this repo a star and follow me for follow back 😊


Makka / #1957 sort dropdown not updating with table sort

Description
Sorting the table in the "list view" by the sortable columns (Price & Vintage) the sort dropdown should update to match the sorted column. This currently isn't working in production.
Related Ticket
Closes #1957
Notes For QA

[ ] When sorting the table by price newest (up arrow icon) - the sort dropdown value should update to "Price Newest"
[ ] When sorting the table by price oldest (down arrow icon) - the sort dropdown value should update to "Price Oldest"
[ ] When sorting the table by vintage newest (up arrow icon) - the sort dropdown value should update to "Vintage Newest"
[ ] When sorting the table by vintage oldest (down arrow icon)- the sort dropdown value should update to "Vintage Oldest"

Specific pages, components or journeys that might be affected:

Projects View

Looks like we can no longer sort using the dropdown

@biwano Hmm, your right - it doesn't look to be working at all now.
Genuinely puzzled with this, I tested it lots before opening the PR. Will move it back to draft and investigate. Thanks for taking a look @biwano


[Bug] Fix the visibility of scroll to top icon

Description
Here scroll to top button symbol is not showing
Can you please assign to me and label it.
I am a GSSOC'24 contributor
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[x] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

hey,
I'm GSSoC'24 contributor , I have experienced on HTML, CSS, JS, and react.js , so I want to work on this issue,
so, kindly requested to you to assign me the task.

The button is clearly visible on my end. Please check from your side using a different browser; there might be an issue on your end @gaddevinay


SyntaxError: Unexpected token } in JSON at position 47

I am migrating this project:
https://github.com/atais/lpuradio
master branch.
and I got:
npx react-native-rename "LPU Radio Puławy"
npx: installed 56 in 1.953s
Something went wrong:  SyntaxError: Unexpected token } in JSON at position 47
    at JSON.parse (<anonymous>)
    at /home/atais/.npm/_npx/437494/lib/node_modules/react-native-rename/lib/index.js:123:17

You can actually clone my repo and try out.
atais@Nasus:~/Documents/lpuradio$ npm --version
6.14.9
atais@Nasus:~/Documents/lpuradio$ node --version
v14.15.1

@atais hey, project contains an invalid JSON file
https://github.com/atais/lpuradio/blob/master/app.json, please change to
{
  "name": "MyApp",
  "displayName": "MyApp"
}

oh. That is how it was generated :facepalm:
Thanks!


Thank you very much for sharing，can you explain the purpose of this step!

Thank you very much for sharing，can you explain the purpose of this step!
week_period = 7 / (2 * np.pi)
dow_norm = features_days.dayofweek.values / week_period
dow = np.stack([np.cos(dow_norm), np.sin(dow_norm)], axis=-1)

@roerwod , thanks for explanation!


getUrl() is there but | fileExists is false

Newest Craft.
Newsst Plugin.
{{ d(opt.image.getUrl()) }}
{{ d(opt.image.getUrl() | fileExists) }}
{% if opt.image.getUrl() | fileExists %}
...
{% endif %}

![image](https://user-images.githubusercontent.com/764292/68743056-e4acab80-05f1-11ea-9217-8a330338f3e6.png)

Strange :)

The Asset could have a URL - as far as Craft is concerned it is all OK.
The fileExists filter is actually checking for the "physical" presence of the file at that URL.
Is there actually a file present at that URL?

Yes I know. But with asset.getUrl its always false. When i put asset.getVolume.path ~ asset.filename it works. It’s a bit weird cause the readme it sounds like you check just the asset like
craft.assets.one().getUrl() | fileExists
or do i miss something? Would be nice when the plugin does the stuff by itself (checking the image path).

@fantasticmachine maybe you can merge this: https://github.com/moresoda/existential/pull/2 :)