Problem including the DFU lib in another lib that is distributed over Carthage

Hi,
We're developing the Crownstone, which uses the NRF52. I'm developing the iOS lib and consumer app for the product. I'd like to include the Nordic DFU lib as part of my lib so I can wrap all Crownstone related operations in our native lib. This lib is distributed via Carthage and used by a number of different applications.
My lib's cartfile looks like this:
# Crypto related functions and helpers for Swift
github "krzyzanowskim/CryptoSwift" "0.6.1"

# We code in Asynchronous world. We promise. [http://promisekit.org/]
github "mxcl/PromiseKit"

# JSON Parser
github "SwiftyJSON/SwiftyJSON"

# DFU code from Nordic
github "NordicSemiconductor/IOS-Pods-DFU-Library"

I added a run script to my lib:
# required to build framework in xcode
rm -rf Carthage/Checkouts/IOS-Pods-DFU-Library/Example/Pods/

in order to avoid the issue posted in #49. The lib compiles to a framework now! Hurray!
Carthage build --no-skip-current --platform iOS also works fine:
Alexs-iMac:BluenetLibIOS alex$ carthage update --platform iOS --no-use-binaries
*** Fetching IOS-Pods-DFU-Library
*** Fetching SwiftyJSON
*** Fetching PromiseKit
*** Fetching Zip
*** Checking out CryptoSwift at "0.6.1"
*** Checking out PromiseKit at "4.1.3"
*** Checking out SwiftyJSON at "3.1.4"
*** Checking out Zip at "0.6.0"
*** Checking out IOS-Pods-DFU-Library at "3.0.4"
*** xcodebuild output can be found in /var/folders/lv/t0vwd5w9211_mrcjqvc1gcdw0000gn/T/carthage-xcodebuild.aqTdFJ.log
*** Building scheme "CryptoSwift" in CryptoSwift.xcworkspace
*** Building scheme "PromiseKit" in PromiseKit.xcodeproj
*** Building scheme "SwiftyJSON iOS" in SwiftyJSON.xcworkspace
*** Building scheme "Zip" in Zip.xcodeproj
*** Building scheme "iOSDFULibrary" in iOSDFULibrary.xcworkspace
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetLibIOS/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetLibIOS/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetLibIOS/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetLibIOS/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
Alexs-iMac:BluenetLibIOS alex$

I have my dev app, my consumer app, and thrid party apps which uses the lib through carthage. The only entry in those cart files is the lib git repo:
# BluenetLibIOS
# link to the local repo so I don't have to tag releases for experimenting with Carthage.
git "file:///Users/alex/Dropbox/DoBots/Projects/XCode/BluenetLibIOS/.git" "master"

# BluenetLibIOS on github
#github "crownstone/bluenet-lib-ios"

If I now run carthage update --platform iOS --no-use-binaries I get this:
Alexs-iMac:BluenetRuntime alex$ carthage update --platform iOS --no-use-binaries
*** Fetching
*** Fetching IOS-Pods-DFU-Library
*** Fetching SwiftyJSON
*** Fetching PromiseKit
*** Fetching Zip
*** Checking out CryptoSwift at "0.6.1"
*** Checking out PromiseKit at "4.1.3"
*** Checking out SwiftyJSON at "3.1.4"
*** Checking out Zip at "0.6.0"
*** Checking out IOS-Pods-DFU-Library at "3.0.4"
*** Checking out  at "6b576bb8e5b2cc7c4f76ac25cac0c0dc877843b9"
*** xcodebuild output can be found in /var/folders/lv/t0vwd5w9211_mrcjqvc1gcdw0000gn/T/carthage-xcodebuild.9fXSgA.log
*** Building scheme "CryptoSwift" in CryptoSwift.xcworkspace
*** Building scheme "PromiseKit" in PromiseKit.xcodeproj
*** Building scheme "SwiftyJSON iOS" in SwiftyJSON.xcworkspace
*** Building scheme "Zip" in Zip.xcodeproj
*** Building scheme "iOSDFULibrary" in iOSDFULibrary.xcworkspace
*** Building scheme "CryptoSwift" in CryptoSwift.xcworkspace
*** Building scheme "SwiftyJSON iOS" in SwiftyJSON.xcworkspace
*** Building scheme "BluenetLibIOS" in BluenetLibIOS.xcodeproj
*** Building scheme "iOSDFULibrary" in iOSDFULibrary.xcworkspace
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
/Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/CryptoSwift/Sources/CryptoSwift/ChaCha20.swift:16:21: warning: property should not be declared fileprivate because its type uses a private type
A shell task (/usr/bin/xcrun xcodebuild -workspace /Users/alex/Dropbox/DoBots/Projects/XCode/BluenetRuntime/Carthage/Checkouts/IOS-Pods-DFU-Library/Example/iOSDFULibrary.xcworkspace -scheme iOSDFULibrary CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean -showBuildSettings) failed with exit code 65:
xcodebuild: error: The workspace named "iOSDFULibrary" does not contain a scheme named "iOSDFULibrary". The "-list" option can be used to find the names of the schemes in the workspace.

I would assume that the package manager will just build the dependencies as it did before using the iOSDFULibrary.
Regards

That is true, i'll take a look right now and let you know my findings soon !, thanks for the tip

On a side note, when I used the following run script phase
# required to build framework in xcode
rm -f ./Carthage/Checkouts/Zip/Zip/minizip/module.modulemap

I got different errors mentioning minizip. I tried adding minizip to carthage explicitly, but that did not work either.

Yeah that's understandable, I'm still working on it, builds are extremely slow, I also forked your project in case i need to do any changes, if i find an issue with your configs that i manage to resolve will just send you a PR, if not we will fix iOSDFULibrary and let you know 👍

Great! I hope this can be resolved soon since we need to push an update to our users that will update their firmware in a few weeks.
Cheers!

Thanks a lot!

Just a quick heads up, 3.0.5 have introduced an issues that might affect your build, she Zip scheme wasn't shared and wasn't built by carthage, however if you already had it in your project, things should work.
but if you were building from scratch carthage wouldn't pick up the zip framework and you'll get a runtime like this: https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/issues/78
This has been resolved in 3.0.6 and i would recommend testing that out :)

Cool Thanks! I'll give it a try!

On 20 Jan 2017, at 09:56, Mostafa Torbjørn Berg<EMAIL_ADDRESS>wrote:
Just a quick heads up, 3.0.5 have introduced an issues that might affect your build, she Zip scheme wasn't shared and wasn't built by carthage, however if you already had it in your project, things should work.
but if you were building from scratch carthage wouldn't pick up the zip framework and you'll get a runtime like this: #78
This has been resolved in 3.0.6 and i would recommend testing that out :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, I tried it just now and while the carthage update works, the actual building of the project itself (using the play button) does not work unless I remove the checkout folder.
Project example:
https://github.com/crownstone/bluenet-example-ios
<snippit>/Carthage/Checkouts/IOS-Pods-DFU-Library/Example/Pods/Zip/Zip/minizip/module.modulemap:1:8: Redefinition of module 'minizip'

could not build Objective-C module 'Zip'

Ironically carthage build does work. Any ideas other than adding a remove script again?
Regards

@AlexDM0 That's interesting, do you by any chance have a Zip.frmework lingering around in your project ?

@AlexDM0, I did take a look now, Zip was a submodule still causing the issue you're seeing, that's why the Carthage build would work, but Xcode would notice a redefinition of the Zip module.
i sent you a PR https://github.com/crownstone/bluenet-example-ios/pull/1 give it a shot and let me know if you still encounter issues, if you do i would say try to clear all Carthage related files/directories, and make sure you no longer have any extra references in the project, then do a new bootstrap

Hi,
While the solution works, it is kind of against Carthage protocol. From their README:
The basic workflow looks something like this:

Create a Cartfile that lists the frameworks you’d like to use in your project.

Run Carthage, which fetches and builds each framework you’ve listed.

Drag the built .framework binaries into your application’s Xcode project.

 Carthage does not automatically modify your project files or your build settings.

I don't mean to make an issue of things that essentially work fine, but given that we're providing our lib to others as well, I'd like it to be working according to the normal Carthage workflow. Is this a feasible goal?
Regards

Maybe I'm misunderstanding something ? this is how the workflow is, my fix was only removing an extra Zip module, not the actual one that is exported, I see your Cartfile has the correct dependencies, our library has the Zip module dependency and does build it as it should, so I'm not sure where this breaks the proper workflow, can you elaborate a bit more ? We do care about having a proper library so I'd like to fix anything that doesn't seem right ofcourse:)

Hi, sorry, turns out it's something else...
If I just open the xcodeproj file for the example app, it all works. If I have an XCode workspace, for some reason I cannot compile the app. Because this went wrong I misunderstood the changes you provided.
I'll try to further look into the workspace issue. I made a new workspace and added the bluenetioslib xcodeproj and the bluetnet example ios xcodeproj files and then it does not compile.
Regards

Ah workspace, that's a bit different yes, I didn't do any changes except in the actual files and haven'd changed the XCode project, if you need help with the Workspace problems let's take it in a new issue, might be helpful for someone else in the same situation later :)


fix(common) - changed let keyword in all affected demos.

Closes #313

Coverage remained the same at 98.455% when pulling 81ffb794fc0b1d15fe1e010dab15c84659edf765 on s-KaiNet:issue-313 into 7f1fd86a2c68418526339c1ae9dd05207809247d on ngOfficeUIFabric:dev.


Updates to rekor chart

Updates to the rekor chart to align with version updates

will close/reopen to see if that triggers ci


Support Laravel 9

I couldn't see anything that would mean this wouldn't be supported in L9

Could you also update the GitHub Action test workflow to make sure the tests pass on Laravel 9?

Closing because of non-activity.


dyld: Library not loaded: @rpath/libclntsh.dylib.12.1

hi, something was wrong when I run the program on mac:

oci8.pc:
prefixdir=/Users/proclinu/Oracle/instantclient_12_2
libdir=${prefixdir}
includedir=${prefixdir}/sdk/include
Name: OCI
Description: Oracle database driver
Version: 12.2
Libs: -L${libdir} -lclntsh
Cflags: -I${includedir}
GOROOT=/usr/local/Cellar/go/1.9.2/libexec #gosetup
GOPATH=/Users/proclinu/GoLang #gosetup
/usr/local/Cellar/go/1.9.2/libexec/bin/go build -i -o /private/var/folders/g4/qk5035gn3fj1919kzrqj5c940000gn/T/___go_build_query_go /Users/proclinu/GoLang/src/locale/oracle/query.go #gosetup
/private/var/folders/g4/qk5035gn3fj1919kzrqj5c940000gn/T/___go_build_query_go #gosetup
dyld: Library not loaded: @rpath/libclntsh.dylib.12.1
Referenced from: /private/var/folders/g4/qk5035gn3fj1919kzrqj5c940000gn/T/___go_build_query_go
Reason: image not found
Process finished with exit code 134 (interrupted by signal 6: SIGABRT)
I used a makefile to test,it's ok:
objects = test.o
test: ${objects}
gcc -o test ${objects} $(pkg-config --libs --cflags libclntsh)
so I guess, maybe some wrong happened in oci8

libclntsh can not be loaded correctly.

my ide goland have some problems，DYLD_LIBRARY_PATH can not be loaded.
must add manualy

Since recent versions of macOS ignore DYLD_LIBRARY_PATH in subshells, and therefore it isn't useful or reliable, you may just want to install Instant Client following the instructions and put it in ~/lib or /usr/local/lib

It's important to put it in ~/lib/, at least that worked for me after I put libclntsh.dylib in

/usr/local/lib

I used ln -s <pathTo_libclntsh.dylib> ~/lib/ as it's done here https://oracle.github.io/odpi/doc/installation.html#macos
Also do not do this as "sudo su" as then you would put the libs under /var/root/lib. You should put it under ~/lib while being the same user that runs your programs.


Fixed index.html redirect and found missing closing backquotes

I aIso moved the *.ex files into lib/graphmath
There are some warnings about unsafe variables I did not touch.
It was easy to identify the filename and the line of the missing backquotes thanks to the usage of my forked version of ex_doc. But this is a kludge of course I have only forked ex_doc for the PR of this particular feature.

Coverage remained the same at 100.0% when pulling f7d9c0d2bf57a92533f820a18355019855695d18 on RobertDober:master into d35f3f9769fe7bf2994e491094abb44b03b66246 on crertel:master.

Thank you so much @RobertDober !


PC channel still there, doing an unlink of  instanceName

Required information
Operating system:
Ubuntu 20.04 LTS
Compiler version:
GCC 8.4
Eclipse iceoryx version:
v2.0.2
Observed result or behaviour:
how to fix this error
Expected result or behaviour:
2024-03-01 10:40:23.817 [Warning]: IPC channel still there, doing an unlink of smq-server-rtu-slave
Conditions where it occurred / Performed steps:
Frequent restart service

rodui log:
2024-03-01 10:40:25.356 [Warning]: Application smq-server-rtu-slave not responding (last response 1538 milliseconds ago) --> removing it
2024-03-01 10:48:14.377 [Warning]: Application smq-request-response-client-listener not responding (last response 1539 milliseconds ago) --> removing it
2024-03-01 10:48:32.047 [Warning]: Application smq-request-response-client-listener not responding (last response 1503 milliseconds ago) --> removing it
2024-03-01 10:48:48.299 [Warning]: Application smq-server-rtu-slave not responding (last response 1593 milliseconds ago) --> removing it
2024-03-01 10:48:53.303 [Warning]: Application smq-request-response-client-listener not responding (last response 1507 milliseconds ago) --> removing it
2024-03-01 10:49:01.809 [Warning]: Application smq-server-rtu-slave not responding (last response 1599 milliseconds ago) --> removing it
2024-03-01 10:49:05.512 [Warning]: Application smq-request-response-client-listener not responding (last response 1513 milliseconds ago) --> removing it
2024-03-01 10:49:21.223 [Warning]: Application smq-server-rtu-slave not responding (last response 1549 milliseconds ago) --> removing it

The IPC channel still there, doing an unlink of smq-server-rtu-slave comes the the applications are not shut down gracefully, e.g. with kill -9. In this case they cannot clean up their resources so it happens on restart.
The RouDi log also just states that the application was killed and not shut down properly.
It might also happen when no signal handler is used. You can have a look at the examples on how to do it properly.

thanks,I found the problem。
If I call right away : iox::runtime::PoshRuntime::initRuntime(runtime_name), Resources are not allocated。I invoke the request-response mode and create the service.
the service will be  panic.

I'm not sure what you mean. Can you describe your problem in more detail?

@guojun08512 the original issue was cleared. If there are more problems please create a new issue. Closing this issue


Support zeebe:UserTask

Related to https://github.com/camunda/camunda-modeler/issues/4087

This is missing the implementation for "keep only one form-related property".


More wireless drivers ?

Hello, and first: Thank you for the amazing work done here !
For background, I'm a linux noob and I don't understand clearly most of the 'module' things yet... Feel free to point me to appropriate documentation if you realize my questions are irrelevant.
I'm running into the issue of searching for a USB wireless (WIFI) adapter that supports monitor mode (for AP), with a driver that allows to attach interface to a network namespace (docker)...
I have two usb sticks I'd like to test, here is what lsusb reports when plugged in:

0cf3:7015 Atheros Communications, Inc. TP-Link TL-WN821N v3 / TL-WN822N v2 802.11n [Atheros AR7010+AR9287]
0cde:0008 Z-Com XG-703A 802.11g Wireless Adapter [Intersil ISL3887]

After some "googling", I think that these adapters rely on 'ath9k_htc' and 'p54usb' drivers respectively.
By default, the adapters don't show up when using iwconfig.
I tried installing theit 'non-free' firmware files but that didn't help.
I think their drivers are just not included in the kernel nor available as modules. Does that sound correct ?
Then I tired that:
https://forum.pine64.org/showthread.php?tid=6799
The goal was to download and compile the kernel by myself after including appropriate drivers with make menuconfig but I just messed up y config and I now have to reinstall everything from scratch...
My request: would it be possible to include some more wireless adapters drivers in the default build so we can experiment with a broader range of hardware ?
Thank you so much and sorry if this questions appears vague or not documented enough.
Feel free to ask any questions.

For info if useful, I was using the release named: 'stretch-openmediavault-rock64-0.8.0rc9-1120-arm64.img'


LPAL-1097 Update LB ssl_policy

Purpose
Update the ALB SSL policies to require modern cipher suites.
Fixes LPAL-1097
Approach
Use AWS predefined security policy ELBSecurityPolicy-FS-1-2-Res-2020-10. This allows ECDHE-ECDSA-AES128-GCM-SHA256, ECDHE-RSA-AES128-GCM-SHA256, ECDHE-ECDSA-AES256-GCM-SHA384, ECDHE-RSA-AES256-GCM-SHA384 cipher suites and continues to require TLSv1.2 (ALBs do not yet supported TLSv1.3)
Learning
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/create-https-listener.html#describe-ssl-policies
Checklist

[X] I have performed a self-review of my own code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] I have added mandatory tags to terraformed resources, where possible
[ ] If I have a new OPG component dependency, I have updated the metadata.json with the repo location.
[ ] If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
[ ] The product team have tested these changes

Given the following browsers will now be unsupported

Safari 8 / OS X 10.10 and earlier
Chrome 49 / XP SP3 and earlier

According to caniuse
Safari 8 - 0% (or so low it cannot be registered)
Chrome 49 - 0.05%
Our other services also use this so I am comfortable with this change.


Openload issue

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.03.24. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2017.03.24

Before submitting an issue make sure you have:

[x ] At least skimmed through README and most notably FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The script is crashing while trying to download the following openload video https://openload.co/f/8uuyOoR0Cz8/Naruto_Shippuden_-001-_Homecoming-r197.1-r371-r277.mp4
C:\Users\edwar\Downloads>youtube-dl -v https://openload.co/f/8uuyOoR0Cz8/Naruto_Shippuden_-_001_-_Homecoming-r197.1-r371-r277.mp4
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://openload.co/f/8uuyOoR0Cz8/Naruto_Shippuden_-_001_-_Homecoming-r197.1-r371-r277.mp4']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.03.24
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: none
[debug] Proxy map: {}
[Openload] 8uuyOoR0Cz8: Downloading webpage
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp7c11i4w7\build\youtube_dl\__init__.py", line 464, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp7c11i4w7\build\youtube_dl\__init__.py", line 454, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp7c11i4w7\build\youtube_dl\YoutubeDL.py", line 1884, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp7c11i4w7\build\youtube_dl\YoutubeDL.py", line 761, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp7c11i4w7\build\youtube_dl\extractor\common.py", line 428, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp7c11i4w7\build\youtube_dl\extractor\openload.py", line 92, in _real_extract
ValueError: invalid literal for int() with base 8: '7d9'
...
<end of log>

Duplicate of #10408


Missing items: [ITEMS]

Links to WOTLK Wowhead for each item: https://www.wowhead.com/wotlk/item=40417/valorous-frostfire-leggings

This is now added!


Cannot login

Keybase GUI Version: 1.0.41-20180221184830+80361c9
I tried to generate a paperkey but it seemed not to work and shut keybase gui down.
I got this message when i try to login back to keybase gui.

Cc @zanderz
On Thu, Feb 22, 2018 at 3:25 PM Antso Laza<EMAIL_ADDRESS>wrote:

Keybase GUI Version: 1.0.41-20180221184830+80361c9
I tried to generate a paperkey but it seemed not to work and shut keybase
gui down.
I got this message when i try to login back to keybase gui.
[image: image]
https://user-images.githubusercontent.com/7102435/36562272-c42e9e10-1816-11e8-8246-514dfd2ffe13.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/10661, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_1w7xWPCcyfQ9GLTvUTkzm3k3cL9ks5tXc1OgaJpZM4SP7pW
.


Should add example usage of rmw_isolation in ros2_example_apps/test

Motivated by @sloretz's question in #75 - https://github.com/robotlocomotion/drake-ros/pull/75#pullrequestreview-961180890
At present, Miche's awesome isolation work is presently only tested / shown in bazel_ros2_rules. For simplicity, we should show simple examples of isolation in a more app-oriented usage (and less about unit/stress-testing it).
C++
https://github.com/RobotLocomotion/drake-ros/blob/e34b93b396e8af7ae938f9ce0f3ac775488dc0e5/bazel_ros2_rules/ros2/resources/rmw_isolation/test/isolated_talker.cc#L32-L35
https://github.com/RobotLocomotion/drake-ros/blob/e34b93b396e8af7ae938f9ce0f3ac775488dc0e5/bazel_ros2_rules/ros2/resources/rmw_isolation/package.BUILD.bazel#L32-L47
Python
https://github.com/RobotLocomotion/drake-ros/blob/e34b93b396e8af7ae938f9ce0f3ac775488dc0e5/bazel_ros2_rules/ros2/resources/rmw_isolation/test/isolated_talker.py#L23-L26
https://github.com/RobotLocomotion/drake-ros/blob/e34b93b396e8af7ae938f9ce0f3ac775488dc0e5/bazel_ros2_rules/ros2/resources/rmw_isolation/package.BUILD.bazel#L62-L73
This reflects our LCM-style testing philosophy - we explicitly let tests denote how they wish to isolate, but provide utilities to facilitate it.

Will see if I can do this in ~10min - if not, @sloretz, can I pass this to you?

Will see if I can do this in ~10min - if not, @sloretz, can I pass this to you?

I can give it a shot. I could use the practice with it.

Sounds great - thanks!!!

For both C++ and Python, I'd suggest just keeping it single-node, and perhaps just do a single-process talker / listener.
No need to stress test here, as I believe Miche already handled that in @ros2

Closed as duplicate of #115


How can I use profiling API with NetCore SDK

Hello, I need to implement some interfaces supported by .NetCore 2.2 (and above), but I am unable to find an article that explains how exactly to use ProfilerAPI as a part of NetCore SDK. Many thanks in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d991b449-600d-2135-0db4-4d62b8104be3
Version Independent ID: 33d4c6ef-3808-d107-a3de-93df77995840
Content: ICorProfilerInfo10 Interface
Content Source: docs/framework/unmanaged-api/profiling/icorprofilerinfo10-interface.md
Product: dotnet-framework
GitHub Login: @davmason
Microsoft Alias: davmason

@davmason Can you help with this question?

Hi @ivo-stoilov
We have some docs over in the runtime repository: https://github.com/dotnet/runtime/tree/main/docs/design/coreclr/profiling
This one might be particularly interesting on how to get a profiler attached to the runtime: https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/profiling/Profiler Loading.md
For getting started building a profiler, the easiest way would be to grab one of the profiler samples from the samples repo and modify it to your needs: https://github.com/dotnet/samples/tree/main/core/profiling

Hello @davmason, many thanks for the useful articles. My question is more liely related to

The coreclr headers are not shipped as part of the Windows SDK. You can find the latest profiler header at https://github.com/dotnet/runtime/blob/main/src/coreclr/pal/prebuilt/inc/corprof.h.
The headers besides corprof.h don't change much, so most people I talk to copy corprof.h in to their project and use the Windows SDK headers for the rest (e.g corhdr.h).

Thanks @davmason, it is exactly what I did and now I have the confirmation that it is the right approach. The issue can be closed as resolved.

Thanks, feel free to file another issue if you have any more questions.


SwiftUI Updated -> RealityKit: realityView [BETA]

Doc: https://developer.apple.com/documentation/RealityKit/RealityView

We cannot support this View because it requires writing imperative Swift code.


⚠ ClamAV has degraded performance

In 732310d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in 1801703.


Refresh access request even after deauth caused by expired refresh token

Client place a refresh token request in place of auth even after deauth caused by refresh token expiring ( That is after half hour. If app is not being used). But working properly with manual Logout.
On click of "authorize" button. Following HTTP request made.
POST /auth/realms/hawkular/protocol/openid-connect/token HTTP/1.1
Accept: application/json
Content-Type: application/x-www-form-urlencoded
User-Agent: Dalvik/2.1.0 (Linux; U; Android 5.1; XT1022 Build/LPC23.13-34.8)
Host: <IP_ADDRESS>:8080
Connection: Keep-Alive
Accept-Encoding: gzip
Content-Length: 1107
client_secret=&client_id=hawkular-ui&grant_type=refresh_token&refresh_token=eyJhbGciOiJSUzI1NiJ9.eyJqdGkiOiIyZDA4ZDg0OC0yZWJmLTQ3MWItYTY4Zi1jMDg0MDdkZDE5MmUiLCJleHAiOjE0NTYyMzAzODksIm5iZiI6MCwiaWF0IjoxNDU2MjI4NTg5LCJpc3MiOiJodHRwOi8vMTkyLjE2OC4xLjI2OjgwODAvYXV0aC9yZWFsbXMvaGF3a3VsYXIiLCJhdWQiOm51bGwsInN1YiI6ImE3MDBlMThiLTkzMjQtNDA4Ni04N2IyLTI2MzlmOWE3NDM1MyIsInR5cCI6IlJlZnJlc2giLCJhenAiOiJoYXdrdWxhci11aSIsInNlc3Npb25fc3RhdGUiOiI5ZGMyODkxNi03MDJiLTRmNTktYmIzNi0zNzVjMzI5ZTVhMTkiLCJjbGllbnRfc2Vzc2lvbiI6ImZjYTkwZjc1LTViNWEtNDQ3Mi1iZDM1LTJlZjBkZTQzYTI5MiIsInJlYWxtX2FjY2VzcyI6eyJyb2xlcyI6WyJ1c2VyIl19LCJyZXNvdXJjZV9hY2Nlc3MiOnsiaGF3a3VsYXItYWNjb3VudHMtYmFja2VuZCI6eyJyb2xlcyI6WyJ1c2VyIl19LCJhY2NvdW50Ijp7InJvbGVzIjpbIm1hbmFnZS1hY2NvdW50Iiwidmlldy1wcm9maWxlIl19fX0.iooz0ThCa-NbOHVhAp0K_Jq0xXPCiDG7ucPxHqzclow_lTbDzsTPjVt2g1eos90297cjNpgSgoiwbccvVOEvVbWUrz5qaHa0oZOfhR-YRtfXC27ijjGJ9qlT6it3f_IPt8SD1Xxr-J-nfRtdaMg8XQFkox40kwbKXuaP0k64l0C4wKHKvtThPJIEj6FPrSjycWYrD2UQ28J5BYAVJnQzUX-U6u4VLYqAiBKc9NsvXT05WN9KdLZyOS0OiXPQk3bxuvgONuBwqArlcNbLODy_wtW3uufbeHE7N_Gb3A6SEUxWqZ2Bno4-YToCSR7iXPKN_-8pLUDow11P9EXpty6Jlg
And response is
HTTP/1.1 400 Bad Request
Content-Encoding: gzip
Connection: keep-alive
X-Powered-By: Undertow/1
Server: WildFly/10
Content-Type: application/json
Content-Length: 84
Date: Thu, 25 Feb 2016 04:50:18 GMT

This should be caught by the Android client and the login form should be shown again to the user. The response body from Keycloak includes an error code and message, so, this could be used to parse this situation.
But isn't the Android client using key/secrets now, instead of OAuth tokens?

@jpkrohling Yeah Its right that it is to be caught by android client. But not able to know where its going wrong So placed the issue so every knows about it.
Key / Secret is still not implemented as auth module implementation pull request  was getting a bit difficult to be merged and there were some stuff to be fixed in the client. So I had to close that pull request. i will work around solution for that and then I will place pull request again :)

Solved with #56


Suggest ..< instead of until

Fixes https://github.com/detekt/detekt/issues/6262
Fixes https://github.com/detekt/detekt/issues/6263

@atulgpt can we fix detekt with type resolution?

Updated the code. It should be green now

This sadly can't be picked on the 1.x release branch as it contains a breaking change.


Reads CDN_URL to populate webpack publicPath

closes #647
Previously we only allowed settings the pathname via the "homepage" key
in package.json
Allows user to configure the full base URL via a $CDN_URL env
variable
Development has the same behaviour.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

I’m going to make significant changes in #703 but I think this PR could complement those pretty nice by allowing PUBLIC_URL to be set from outside. I will ping you after #703 lands so that you could rebase on top of that.

#703 has landed.
Can you please send a new PR on top of it that honors PUBLIC_URL environment variable?
This would make it consistent with how the code already works (that’s the name of the variable we expose).
Thanks!

Hi there! react-scripts v0.9.0 was just released which adds support for specifying a CDN url. You may read how to configure it here.
Please test it and don't hesitate to reach out if this doesn't solve your specific use case!


Compile Rust application for Windows with cross and sqlite3 dependecy

Hello !
I'm trying to compile my Rust application for Windows with cross. I got this error :
   Compiling trsync v0.1.3 (/project)
error: linking with `x86_64-w64-mingw32-gcc` failed: exit status: 1
  |
  = note: "x86_64-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-m64" "-Wl,--high-entropy-va" "/rust/lib/rustlib/x86_64-pc-windows-gnu/lib/rsbegin.o" "/target/x86_64-pc-windows-gnu/debug/deps/trsync-36594acb4f0db109.trsync.69d5ec1a-cgu.0.rcgu.o" [...] "-Wl,--gc-sections" "-no-pie" "-nodefaultlibs" "/rust/lib/rustlib/x86_64-pc-windows-gnu/lib/rsend.o"
  = note: /usr/bin/x86_64-w64-mingw32-ld: cannot find -lsqlite3
          collect2: error: ld returned 1 exit status

error: could not compile `trsync` due to previous error

How to compile my application for Windows with cross ?

Hi!
You'll need to provide a custom docker image that includes sqlite. See the readme
https://github.com/cross-rs/cross#custom-docker-images
Note that the example won't work right now as the latest tag has not been pushed to yet, use a specific sha or simply the main tag instead in the from step. Or use the old dockerhub images
Note that if you decide to compile cross from current main branch, be aware that it's currently broken on windows pending #665


Typo on .Net version 4.5.1 name from .5.1

Title
.Net Framework 4.5.1 incorrectly labelled as .5.1
Summary
Corrected typo which showed .Net Framework version 4.5.1 as .5.1

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Ensure additional fitting works after loading models

This PR adds some tests to verify that we're able to fit loaded, serialized models on additional data for fine-tuning.

[X] Add a tests for fitting after loading for MultipleTrueFalseMemoryNetwork, which should already be implemented correctly
[ ] Fix _set_max_lengths_from_model for BiDAF and the TrueFalseModel
[ ] Add tests for fitting after loading for BiDAF and the TrueFalseModel

@matt-gardner  --- theano tests seem to fail on my machine for even MultipleTrueFalseMemoryNetwork, which is interesting considering TF is fine / this model should already be correct. I'm looking into it, but wanted to let you know just in case you had any idea off the top of your head why this could be the case.

interesting, seems like TF is failing on the CPU as well when trying to fit MultipleTrueFalseMemoryNetwork after loading.

@matt-gardner this is (finally) ready to be looked at. a more real-world test would be to load an actual weights file from one of the training epochs of BiDAF on SQuAD (still running...) and see if I can get fitting after loading to work on that.

merging this, thanks for looking @matt-gardner


[Bug]: Modifier Value References are not resolved

What happened?
Using token references for example for the alpha modifier gets not resolved, resulting in the alpha value just being missing without any warning/error. This might be related more to issue #198, rather than #164.
Consider following token data:
{
  "core": {
    "alpha": {
      "30": {
        "value": "0.3",
        "type": "opacity"
      }
    },
    "color": {
      "inverse": {
        "200": {
          "value": "#ffffff",
          "type": "color",
          "$extensions": {
            "studio.tokens": {
              "modify": {
                "type": "alpha",
                "value": "{core.alpha.30}",
                "space": "srgb",
                "format": "hex"
              }
            }
          }
        }
      }
    }
  }
}

Reproduction
TokenStudio Configurator Reproduction
Expected output
Instead of
:root {
  --sd-core-alpha-30: 0.3;
  --sd-core-color-inverse-200: #fff;
}

I would exect
:root {
  --sd-core-alpha-30: 0.3;
  --sd-core-color-inverse-200: #ffffff4d;
}

Version
0.11.6

Just noticed that as soon as the value on which the modifier is applied to, also is a token reference, it works in the TokenStudio Configurator, but unfortunately not in my code. Would be cool to see the sd-transform and maybe the style-dictionary versions that the TokenStudio Configurator currently uses at that moment.

Hi, acknowledged as bug, I'll try to find some time to look into this one this week.
But of a hidden feature (more like a bug, but actually really useful 😅) but you can adjust the version of sd-transforms import { registerTransforms } from '<EMAIL_ADDRESS>and this should work for any package.
However, it does not work for the style-dictionary import, that one is unfortunately hardcoded at the moment and not really possible to dynamically fetch from the CDN for the Configurator's internal usage, although I will consider making that a feature in the future and change this from a bug (unintended feature) to something officially supported. Will also need to adjust the "Eject" functionality to keep into account these versions that the user may specify when creating the eject output.

@jorenbroekema Thanks a lot for your answer. For me right now, having the possibility to change Style-Dictionary and SD-Transform versions, would be a very welcomed feature of the configurator. So cool feature idea IMO. As a quick improvement, just displaying the versions somewhere in the configurator, would also already help.
Besides that, I just stumbled over another case regarding this bug, where it is not working correctly. As I mention in my comment before, as soon as you have a token reference as the color value the alpha is applied to, it works in the configurator. I also wrote, that it does not work for me in my project. The reason for this is, that the token definition is spread across multiple JSON files. This then is also a reproducible bug in the configurator.
If you have test cases, then these would probably be interesting cases to automatically test against, what do you think?

@jorenbroekema @DarioSoller I think there is a bug in modifier. I did short investigation:
It's not a problem of multiple files. My analysis indicates that the issue does not stem from handling multiple files; rather, the modifier appears to fail when a value uses a reference to another one (from this file or another).
Here is the link to the configurator
Let's take a closer look at the code:
{   "semantic": {     "alpha": {       "default": {         "value": "0.3",         "type": "opacity"       },       "disabled": {         "value": "{semantic.alpha.default}",         "type": "opacity"       }     },     "color": {       "surface": {         "default": {           "disabled": {             "value": "{core.color.blue.100}",             "type": "color",             "$extensions": {               "studio.tokens": {                 "modify": {                   "type": "alpha",                   "value": "{semantic.alpha.disabled}",                   "space": "srgb",                   "format": "hex"                 }               }             }           }         }       }     }   } }
As you can see from the code, disabled uses the reference to the default
If we use "value": "{semantic.alpha.disabled}" in modifier, then it doesn't work, and we'll have the result:
  --oaSemanticColorSurfaceDefaultDisabled: #f0f7fc;
One interesting finding: result for this token is lower-cased, but for core.color.blue.100 it is upper-cased.
If we use "value": "{semantic.alpha.default}" in modifier, then it works:
  --oaSemanticColorSurfaceDefaultDisabled: #f0f7fc4d;

Besides that, I just stumbled over another case regarding this bug, where it is not working correctly. As I mention in my comment before, as soon as you have a token reference as the color value the alpha is applied to, it works in the configurator. I also wrote, that it does not work for me in my project. The reason for this is, that the token definitions are spread across multiple JSON files.

@DarioSoller I actually identified this bug yesterday as well, see https://github.com/tokens-studio/sd-transforms/issues/217. It is a separate bug though as @yanguly mentions, the references not working on color modifiers is its own bug. Looking into it https://github.com/tokens-studio/sd-transforms/pull/219 , got a failing test to confirm the bug

Update, I had to dive pretty deep into style-dictionary to figure out what's going on with transitive transforms and the resolving of references.
https://github.com/amzn/style-dictionary/blob/v4/lib/exportPlatform.js#L59 the "offending" code is somewhere in this while loop.
Some observations:

When there are reference chains, this while loop can run more than once until all deferred prop transforms have ran, which means the cycle of two steps, 1. transform -> 2. resolve, can run multiple times when there are transitive transforms (allows references to be transformed and resolved in order of chain) in combination with token references applying to a token. https://amzn.github.io/style-dictionary/#/transforms?id=transitive-transforms explains this a bit, but it's quite tough to wrap your head around it, or at least for me it is.
https://github.com/amzn/style-dictionary/blob/v4/lib/transform/object.js#L59 coincidentally also line 59, in this function which is called by exportPlatform while loop, there is an if statement that checks for the existence of a "value" property. Traversing further down the token tree only happens if there is no value property, which means that references further into the token tree (e.g. metadata -> $extensions.['studio.tokens'].modify.alpha) never get traversed. Let's pretend for a second to remove the else, and traverse further into the tree regardless of whether we've already found a "value" property key.
The next issue is now https://github.com/amzn/style-dictionary/blob/v4/lib/transform/object.js#L73 which checks if the token value uses a reference, if it does, then it gets added to the list of deferredPropValueTransforms, to be transformed in the next transform cycle (after reference is resolved). However, our reference isn't inside the token.value, it's inside $extensions somewhere. So we'll need to traverse the whole token to account for that to get it added to the deferred list of props to transform in the next cycle.

So, this is quite a rabbit hole for me to fix in style-dictionary in its current architecture. I might try... but I have also raised an issue to discuss the style-dictionary architecture with regards to references and transforms on a more broad level. In my opinion this use case / issue is more easily tackled in the architecture changes that I propose here https://github.com/amzn/style-dictionary/issues/1032
I'll update this issue if I manage to find an acceptable workaround fix in Style-Dictionary's current structure, but I think I'll then have to look at this again with a fresher mind.

@jorenbroekema thanks for going down the rabbit hole and your detailed updates on it!
I think the big challenge with the current architecture is, that @tokens-studio/sd-transform is getting to the limits of what is made possible for a transformer within Style-Dictionary. Previously when I relied on the token-transformer I have done the transformation as a preprocessing step for the actual Style-Dictionary build. I still keep to have a preprocessing step, even after the switch to @tokens-studio/sd-transform, in which I manually resolve the compositional token references, described in #217 . But as you can imagine, I pretty much rewrote my on token-transformer, in order to resolve these compositional tokens, so nothing I would actually recommend. This also takes into account, that you have to resolve the right token types for the respective tokens being combined within the compositional token.
Another use case I ran into, has been, that you might want to introduce extra tokens, if a certain condition is met, something like i.e. when a token has a specific value. That's also something which is really hard to do or probably not even possible with Style-Dictionary's current architecture!?
As this modifier value references issue seems not to be solved easily and quick, I will most likely add another step to my preprocessing, which resolves the references under $extensions deeper in the token object tree.
PS: Thanks @yanguly for your example and contribution to this discussion!

@DarioSoller since you're doing a preprocessing step outside the scope of Style-Dictionary to work around the current issue of "references inside sibling properties to the value property are not being resolved", it might be interesting for you to test Preprocessors, which is a new lifecycle hook that you can use to do such processing after token files have been parsed and merged, but before any transforming/resolving happens: https://github.com/amzn/style-dictionary/blob/v4/docs/preprocessors.md (as of<EMAIL_ADDRESS>

Created a draft PR where I fix this problem https://github.com/amzn/style-dictionary/pull/1069 by allowing a transformer to return undefined, which would defer the transformation until after references are resolved. This is very similar to when the value prop contains references, except now it also would work if metadata that the transformer relies on contains references. Needs a bit more discussion/tests but there's progress on this issue at least :)


Enforce all user ops have GPU versions?

We have some nice user ops and more coming through. There is the potential that they will improve performance on CPU but make it worse on GPU. We need to think about how to deal with this. One option is to only depend on user ops where we have both CPU and GPU implementations.

Related to #170

So the performance hit is more that data would have to be loaded off GPU memory into CPU memory, right? This would be an issue even considering @jameshensman's point that the current ops are mostly reshapes and are fast.
I don't think it's unreasonable to require a GPU implementation. Especially for simple ops, it doesn't look too hard.

@markvdw , if you could make a GPU edition of the tri2vec/vec2tri ops, that would be amazing.
If you have a look at my RemoveRowElements op, it's completely based on yours. I reckon I could plagarize a GPU op similarly :)

Fixed in #430 we don't have any user ops any more.


Improved handling of network manager statistics

Corrected issue where an exception occurs when Method is not specified in the connection message.
Added handling for collective connections.
Address the issue that not all connection statistics were recorded.
Replaced a few 'magic numbers' in the message parsing logic with core instructive variables.
Closes #256

Looks good.


Added the ability to optionally set the keyPath and networkId for localnet

Fixes https://github.com/near/near-cli/issues/884
I've added the option to set the keyPath and networkId for localnet.

Thank you for the contribution @BenKurrek !


~/.bash_profile not being loaded on startup

I know I could use .bashrc, but why isn't .bash_profile being loaded?
The original Termux loaded the .bash_profile by the way.
How was bash invoked in this version?

It's at the end of /data/data/com.termux.nix/files/usr/usr/lib/login-inner, and yes, it's not invoked as a login shell. Should it be?

Should it be?

Yeah, I guess since termux is supposed to be tty login screen IMO.
Anyway if you're not going to fix it, can you tell me how to make bash being invoked as login shell?
Passing -l maybe?

I have no opinion on fixing it yet.
Yeah, you can try -l. Will it prevent it from reading bashrc?

Can I make it permanent to /usr/lib/login-inner?
Also I've noticed that it doesn't source /path/to/nix/profile/etc/bash_completion.d/* either, probably because of the missing /etc/bashrc (which sources it) which NixOS has it. But I think, this is Nix issue, since Nix (not NixOS) doesn't seem to have it.

You can fork this repository, change it in your fork and set the channel to point to your repository instead. Or just use a local checkout. Lots of other ways, probably.
Losing bashrc support and sensible defaults doesn't sound that great. What would be other benefits of switching to a login shell?
Not sure not shipping /etc/bashrc a Nix issue. Nix just provides bash.

What about introducing a new option called something like user.shellArgs? You could add -l in this array and use it in login-inner.
For the bash_completion issue you could create a new module that creates a /etc/bashrc with the necessary content.

What would be other benefits of switching to a login shell?

Well, I have .bash_profile sourcing .bashrc so I get the same environment either I run shell from tty or terminal.

Not sure not shipping /etc/bashrc a Nix issue. Nix just provides bash.

Right, but isn't nix-on-droid supposed to be NixOS, not just Nix? It even has similar functionality to nixos-rebuild.

Yeah, modules and options solve everything, but one-size-fits-all defaults are always better.

I think it would be better to start a login shell as this is this is the first process started in the nix-on-droid environment. And as termux uses a login shell, we should maybe stream-line it because this is probably the correct usage.
But I think it would be straight forward to add a module for writing /etc/bashrc.

This should be fixed by via https://github.com/t184256/nix-on-droid/pull/139. Please reopen if this is still an issue.


Strings RFC

This is an RFC for how we'll handle the many types of Strings in Rust and Windows and how they interact with each other.
This is a complicated question, so I imagine we'll probably not get it right, but I do believe this is an improvement over the status quo not only in terms of useability but also safety.

I would also add that there are some more rough edges with functions that take even more variations on strings.
There's UNICODE_STRING which is roughly equivalent to the Rust types &[u16], &mut [u16] or Vec<u16> depending on the function being used and the value of MaximumLength. This can support interior nulls.
Also there are functions such as CompareStringOrdinal that can take a null terminated LPCWCH string but also optionally take a length so the strings need not be null terminated (and may therefore include nulls).
And some functions such as SetFileInformationByHandle that take structures which require both a null terminated string and the length of the string.
While these should not be too difficult to support, I think it's worth noting there are a number of variations on the basic ptr + length string.

Right, which is why I'm reluctant to add some new synthetic string type like CWString when we already have so many to contend with. If anything, something like CWString belongs in the standard library alongside CString while the windows crate should focus on those that are specific to Windows, like HSTRING and BSTR, as it does.
To @ChrisDenton's point, it is also not the goal of the window crate to smooth over every last detail of string handling in the Windows API. There will always be APIs that are harder to call directly and possibly deserve some specialized crate to provide a more idiomatic experience if the API is that important. Many are not. 😏

This PR's pretty old. Can we move it along or just close it for now?


[Request] Is Budgie still planning switching its desktop architecture to Qt?

Budgie version
any
Use-cases
Hi.
This is not a request for the actual desktop, but instead for the desktop homepage.
But first: Is Budgie still planning switching its desktop architecture to Qt in v11?
If so, i believe there should be some reference to it or any kind of roadmap mentioning the transition to Qt on the homepage... (i could not find it anywhere...)
Proposal
No response
References
No response

No plans on detailing anything of the sort on the Budgie website.
Other information about Budgie 11 will be fleshed out as we iterate and solidify architectural and technical decisions on it, via #4

There have been several preemptive announcements about Budgie 11's use of basically all the toolkits (EFL, Qt5 back in the day, GTK4)

ahah! Nice one!!!
So no decisions on toolkit change... i'll just count it as gtk-based then :)

No we already have announced it won't be GTK. Plenty of other choices though ;)

No we already have announced it won't be GTK and that is a certainty. Plenty of other choices though ;)

oh, that part is decided! Ok... Will wait to see which toolkit is chosen, then :)
Thank you for your clarifications :)


support handling event process error

make test
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -v
./pkg/...
./cmd/...
EMPTY pkg/api
EMPTY pkg/api/openapi
EMPTY pkg/api/presenters
EMPTY pkg/auth
EMPTY pkg/client/cloudevents
EMPTY pkg/client/ocm
PASS pkg/config.TestConfigReadStringFile (0.00s)
PASS pkg/config.TestConfigReadIntFile (0.00s)
PASS pkg/config.TestConfigReadBoolFile (0.00s)
PASS pkg/config.TestConfigReadQuotedFile (0.00s)
PASS pkg/config
PASS pkg/controllers.TestControllerFramework (0.00s)
PASS pkg/controllers
EMPTY pkg/dao
EMPTY pkg/dao/mocks
EMPTY pkg/db
EMPTY pkg/db/db_context
EMPTY pkg/db/db_session
EMPTY pkg/db/migrations
EMPTY pkg/db/mocks
EMPTY pkg/db/transaction
PASS pkg/errors.TestErrorFormatting (0.00s)
PASS pkg/errors.TestErrorFind (0.00s)
PASS pkg/errors
EMPTY pkg/handlers
EMPTY pkg/logger
PASS pkg/services.TestSQLTranslation (0.02s)
PASS pkg/services.TestResourceFindByConsumerID (0.00s)
PASS pkg/services
EMPTY pkg/util
EMPTY cmd/maestro
EMPTY cmd/maestro/clone
PASS cmd/maestro/environments.TestLoadServices (0.18s)
PASS cmd/maestro/environments
EMPTY cmd/maestro/migrate
EMPTY cmd/maestro/servecmd
EMPTY cmd/maestro/server
EMPTY cmd/maestro/server/logging
DONE 10 tests in 11.391s
make test-integration
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -ldflags -s -v -timeout 1h
./test/integration
I1211 14:35:58.955682   43392 framework.go:76] Initializing testing environment
I1211 14:35:59.115150   43392 framework.go:161] Using Mock OCM Authz Client
I1211 14:35:59.118208   43392 framework.go:199] Disabling Sentry error reporting
{"level":"info","ts":1702276559.118377,"logger":"fallback","caller":"v2@v2.0.0-20231030012137-0836a524e995/protocol.go:124","msg":"subscribing to topics: map[sources/clusters/+/specresync:{1 0 false false} sources/maestro-integration/clusters/+/status:{1 0 false false}]"}
I1211 14:35:59.140364   43392 api_server.go:145] Serving without TLS at localhost:8000
I1211 14:35:59.140487   43392 healthcheck_server.go:56] Serving HealthCheck without TLS at localhost:8083
PASS test/integration.TestConsumerGet (0.17s)
PASS test/integration.TestConsumerPost (0.16s)
PASS test/integration.TestConsumerPaging (0.22s)
PASS test/integration.TestControllerRacing (1.69s)
PASS test/integration.TestControllerReconcile (1.30s)
PASS test/integration.TestControllerSync (1.17s)
PASS test/integration.TestResourceGet (0.19s)
PASS test/integration.TestResourcePost (2.20s)
PASS test/integration.TestResourcePatch (1.21s)
PASS test/integration.TestResourcePaging (0.32s)
PASS test/integration.TestResourceListSearch (0.31s)
PASS test/integration.TestUpdateResourceWithRacingRequests (0.35s)
PASS test/integration
DONE 12 tests in 16.673s

@markturansky would you help to take a look at this pr, we want to use this pr to handle the failed event and ensure the each event can be handled, thanks

go clean --testcache
➜  maestro git:(event-error-handling) make test-integration
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -ldflags -s -v -timeout 1h
./test/integration
I0108 10:10:59.738155   10258 framework.go:76] Initializing testing environment
I0108 10:11:00.021244   10258 framework.go:161] Using Mock OCM Authz Client
I0108 10:11:00.023856   10258 framework.go:199] Disabling Sentry error reporting
{"level":"info","ts":1704679860.024102,"logger":"fallback","caller":"v2@v2.0.0-20231030012137-0836a524e995/protocol.go:124","msg":"subscribing to topics: map[sources/clusters/+/specresync:{1 0 false false} sources/maestro-integration/clusters/+/status:{1 0 false false}]"}
I0108 10:11:00.043576   10258 api_server.go:145] Serving without TLS at localhost:8000
I0108 10:11:00.043733   10258 healthcheck_server.go:56] Serving HealthCheck without TLS at localhost:8083
PASS test/integration.TestConsumerGet (0.18s)
PASS test/integration.TestConsumerPost (0.17s)
PASS test/integration.TestConsumerPaging (0.22s)
PASS test/integration.TestControllerRacing (1.73s)
PASS test/integration.TestControllerReconcile (1.43s)
PASS test/integration.TestControllerSync (1.30s)
PASS test/integration.TestResourceGet (0.20s)
PASS test/integration.TestResourcePost (2.21s)
PASS test/integration.TestResourcePatch (0.24s)
PASS test/integration.TestResourcePaging (0.31s)
PASS test/integration.TestResourceListSearch (0.31s)
PASS test/integration.TestUpdateResourceWithRacingRequests (0.40s)
I0108 10:11:08.776068   10258 api_server.go:151] Web server terminated
PASS test/integration
DONE 12 tests in 13.076s

go clean --testcache
➜  maestro git:(event-error-handling) make test-integration
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -ldflags -s -v -timeout 1h
./test/integration
I0110 09:22:37.872341   46485 framework.go:76] Initializing testing environment
I0110 09:22:38.420911   46485 framework.go:161] Using Mock OCM Authz Client
I0110 09:22:38.425648   46485 framework.go:199] Disabling Sentry error reporting
{"level":"info","ts":1704849758.425864,"logger":"fallback","caller":"v2@v2.0.0-20231030012137-0836a524e995/protocol.go:124","msg":"subscribing to topics: map[sources/clusters/+/specresync:{1 0 false false} sources/maestro-integration/clusters/+/status:{1 0 false false}]"}
I0110 09:22:38.443624   46485 api_server.go:145] Serving without TLS at localhost:8000
I0110 09:22:38.443730   46485 healthcheck_server.go:56] Serving HealthCheck without TLS at localhost:8083
PASS test/integration.TestConsumerGet (0.20s)
PASS test/integration.TestConsumerPost (0.20s)
PASS test/integration.TestConsumerPaging (0.38s)
PASS test/integration.TestControllerRacing (1.74s)
PASS test/integration.TestControllerReconcile (1.18s)
PASS test/integration.TestControllerSync (1.29s)
PASS test/integration.TestResourceGet (0.21s)
PASS test/integration.TestResourcePost (2.22s)
PASS test/integration.TestResourcePatch (0.24s)
PASS test/integration.TestResourcePaging (0.31s)
PASS test/integration.TestResourceListSearch (0.45s)
PASS test/integration.TestUpdateResourceWithRacingRequests (0.38s)
I0110 09:22:47.285738   46485 api_server.go:151] Web server terminated
PASS test/integration
DONE 12 tests in 19.228s


Next.js Enable Source maps?

What version of @tailwindcss/jit are you using?
0.1.18
What version of Node.js are you using?
14.16.0
What build tool (or framework if it abstracts the build tool) are you using?
Next.js 10.1.3
What browser are you using?
Chrome
What operating system are you using?
Windows
Reproduction repository
https://github.com/vercel/next.js
When using Tailwind JIT with Next.js, the source map is not enabled. Instead, it shows <no source> while inspecting.
It would be great if we could see the source while developing.

Check out the example template Nextjs have for Tailwind and JIT https://github.com/vercel/next.js/tree/canary/examples/with-tailwindcss

@carlitorweb I have no problem setting up with Next.js but only the source map not working. it shows no-source on chrome. it was working fine with normal tailwind.


Config.py and registry.py comment and doctstring updates

Updated comments, docstrings within the config.py and resgistry.py files.

Hi. Sorry but we don't include comments that simply describe what the code is doing like "These are imports" & "These are global variables", as a maintainer can read the code instead of reading the comment 🤷.


"Send to messenger" plugin in email

I want to add "send to messenger" plugin in email instead of using the plugin in my website. Is this possible?

Closing, not sure if this is a botkit feature.


Added some default site icons

Summary of Changes

Added a range of site icons based upon the logo. Just a simple implementation that suitably covers most modern devices without going crazy with a generator that generates out icons for every historic OS & scenario.
Removed old unused logo image.

Netlify build originally failed here. Had to add the GIT_LFS_ENABLED=true environment variable to the build settings Netlify interface as detailed here: https://docs.netlify.com/configure-builds/environment-variables/#netlify-configuration-variables


Turn on buffered logging by default

Also adjusts the docs accordingly.

I just kickstarted a 0.7.28 release with this PR, it may take a while for the CI to complete and the artifacts to become available on Maven Central

https://github.com/scalameta/munit/releases/tag/v0.7.28


fix: Set targetSDK for helloDagger to 28

Drops the targetSDK and compileSDK to version 28 from 29.
This is a simple fix for the failing build for the helloDagger module.

Failing Build
Successful Build after this change

It would be better to add 29 support in our travis file: https://github.com/airbnb/MvRx/blob/master/.travis.yml

I've updated .travis.yml file with support for build-tools-29.0.2 and android-29.
Here's the log of a successful build using this config: Log


refactor: replaced built-in crypto library with @web5/crypto

What type of PR is this? (check all applicable)

[x]  ♻ Refactor
[ ]  ✨ New Feature
[ ]  🐛 Bug Fix
[ ]  📝 Documentation Update
[ ]  👷 Example Application
[ ]  🧑💻 Code Snippet
[ ]  🎨 Design
[ ]  📖 Content
[ ]  🧪 Tests
[ ]  🔖 Release
[ ]  🚩 Other

Description
This PR replaces the built-in crypto library with @web5/crypto in the encryption.ts file
Related Tickets & Documents
Resolves https://github.com/TBD54566975/dwn-sdk-js/issues/672
Mobile & Desktop Screenshots/Recordings
Added code snippets?

[ ]  👍 yes
[x]  🙅 no, because they aren't needed

Added tests?

[ ]  👍 yes
[ ]  🙅 no, because they aren't needed
[ ]  🙋 no, because I need help
[x]  🥺 I ran unit tests for encryption.ts file and it passed

[optional] Are there any post-deployment tasks we need to perform?
Please run npm install or make sure @web5/crypto package is installed before testing
[optional] What gif best describes this PR or how it makes you feel?

Hi @Toheeb-Ojuolape! Thanks for this 🙏.
It seems like the tests are failing around encryption, please see:
https://github.com/TBD54566975/dwn-sdk-js/actions/runs/11186574275/job/31314960415?pr=816#step:9:1057

Hi @Toheeb-Ojuolape! Thanks for this 🙏.
It seems like the tests are failing around encryption, please see: https://github.com/TBD54566975/dwn-sdk-js/actions/runs/11186574275/job/31314960415?pr=816#step:9:1057

Hi @LiranCohen thanks for your message. I have refactored my code for encryption using web5/crypto and ran the failing npm run test:node command on my local and all tests passed. I think all should be well now. Looking forward to your feedback

Hi @LiranCohen I've refactored the code it seems all should be fine now. I ran the browser test locally before I pushed and it worked fine

Hi @Toheeb-Ojuolape - can you resolve to the comments above so that @LiranCohen may review/merge? Thank you!

Hi @Toheeb-Ojuolape - can you resolve to the comments above so that @LiranCohen may review/merge? Thank you!

Hi @taniashiba I think I've resolved all the comments now and I think the PR is ready. Fingers crossed 🤞🏽

Hey @LiranCohen - could you please review this PR and if approved, add the hacktoberfest-accepted label to it as well as soon as you can? Thank you!


"Chromium revision is not downloaded" Error

Hi! When I'm trying to use the buildpack on heroku, I'm seeing the following error message:
Error: Unable to launch browser for worker, error message:
Chromium revision is not downloaded. Run "npm install" or "yarn install"

I'm using puppeteer-cluster which calls into puppeteer with the --no-sandbox argument as suggested in this buildpack's readme. Has anyone else run into this issue or know what could be going on?
  const cluster = await Cluster.launch({
    monitor: true,
    concurrency: Cluster.CONCURRENCY_BROWSER,
    // see https://devcenter.heroku.com/articles/node-concurrency
    maxConcurrency: WEB_CONCURRENCY ? +WEB_CONCURRENCY : 5,
    // see https://github.com/GoogleChrome/puppeteer/blob/v1.5.0/docs/api.md#puppeteerlaunchoptions
    puppeteerOptions: {
      // see https://peter.sh/experiments/chromium-command-line-switches/
      args: ['--no-sandbox'],
    },
  });

$ grep -i \"version\" ../../node_modules/puppeteer/package.json
  "version": "1.15.0",

$ grep -i \"version\" ../../node_modules/puppeteer-cluster/package.json
  "version": "0.17.0",

Haven't seen it before. Is your code running ok locally?

Yes, runs locally OK and it "works" after I run yarn again inside a one-off dyno (it says lockfile saved, not sure why since when I run it locally, there are no lockfile updates).
The problem is that I would expect the heroku/nodejs buildpack to have ran yarn already. Also, I'm using lerna and this is a sub-package.

I can only venture some guesses here as I've never dealt with this issue.
Is your lockfile being sent to heroku when its being pushed? It isn't part of your .gitignore correct?
I've run into weird issues in the past with caching problems, so clearing your build cache is at least worth a shot: https://help.heroku.com/18PI5RSY/how-do-i-clear-the-build-cache
Since this issue doesn't have to do with the buildpack itself, as all that is supposed to help with is getting Puppeteer running on heroku, I'm going to close the issue, but still happy to talk through it or throw out more random guesses as you try new things. Good luck!

@jontewks yes, the build is succeeding, sending the yarn.lock, and i've tried clearing the build cache.


Override InputProps too

https://github.com/dohomi/react-hook-form-mui/blob/d8cefc9cbef0f19178059039c15e6d19d95d203b/packages/rhf-mui/src/DatePickerElement.tsx#L94
Add also InputProps with big "i"
                            InputProps={{                                 ...params.InputProps,                                 ...inputProps?.InputProps,                             }}

this should be handled with https://github.com/dohomi/react-hook-form-mui/blob/d8cefc9cbef0f19178059039c15e6d19d95d203b/packages/rhf-mui/src/DatePickerElement.tsx#L85 already?

Thing is, that renderInput params passes InputProps, which overrides inputProps.InputProps. Specific scenario is that next to endAdornment (which is DatePicker button) I need to also add startAdornment. If I do it now, inputProps.InputProps are overriden by InputProps from params. I admit that it is a little bit messy since you are playing with DatePicker but I am not able to do it with current Impl

will try to work on this asap

@Drezir after migration to v6 of Datepicker is this issue still present, as the API changed entirely?


Remove "LTS" from the AMI release tag

According to Ubuntu, 15.04 isn't an LTS release; 15.10 will be.

LTS is scheduled every two years (every fourth release), the most recent being 14.04 and the next being 16.04… unless there's some big changes I'm not seeing.
So yeah… :+1: for this PR removing it, but :-1: for 15.10 being the next :wink:

:+1: for @pda's reasoning

:-1: for 15.10 being the next

:joy: Fight the good fight, @pda!

Ugh, my bad. For some reason I thought that all .04's were LTS. From that graph, 16.04 is the next LTS, right?


Confirm that we use cloud provider EAR for CC

Add to FAQs as well as the security section here https://www.cockroachlabs.com/docs/cockroachcloud/security-overview.html
Some context https://cockroachlabs.slack.com/archives/CHKQGKYEM/p1609698452215500
This one is time sensitive, so if we can add this week, that would be great.
cc @piyush-singh

Notes on our encryption at rest in Cockroach Cloud:

We do not enable EAR within CockoachDB by default. Note that this means in the CockroachDB admin UI, encryption will appear disabled. This is only for CRDB specific EAR - the Admin UI is not aware of cloud provider encryption. Note: This problem should go away after we embed admin UI pages into Cloud as we are not planning to embed advanced/debug pages.
All data is encrypted at rest using the encryption tools provided by the cloud providers that a customer's cluster is running in
End users cannot enable EAR as it requires access to the CLI which is not possible in Cloud. EAR requires starting nodes in the cluster with specific encryption flag, and rotating keys also requires a rolling restart with keys swapped in flags on restart.

Notes on our encryption at rest in Cockroach Cloud:

We do not enable EAR within CockoachDB by default. Note that this means in the CockroachDB admin UI, encryption will appear disabled. This is only for CRDB specific EAR - the Admin UI is not aware of cloud provider encryption. Note: This problem should go away after we embed admin UI pages into Cloud as we are not planning to embed advanced/debug pages.
All data is encrypted at rest using the encryption tools provided by the cloud providers that a customer's cluster is running in
End users cannot enable EAR as it requires access to the CLI which is not possible in Cloud. EAR requires starting nodes in the cluster with specific encryption flag, and rotating keys also requires a rolling restart with keys swapped in flags on restart.


QueenTranspilerTestCase.java: Also assert that javaClass co...

The puzzle -900333646 originating from #10 has to be resolved:
https://github.com/jvmqueen/queen-of-java/blob/a60ec81762a8022572ec7784043b9d903b17150b/src/test/java/org/queenlang/transpiler/QueenTranspilerTestCase.java#L63-L63
"Also assert that javaClass compiles.".
The puzzle was created by amihaiemil at 2022-12-05 11:27:52 +0200.
Estimation is 40 minutes.
If you have any technical questions, don't ask me, I won't be able to help. Open new issues instead.

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2022-12-15T09:30:22.427751.
Estimation here is 40 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@amihaiemil Don't forget to close this ticket before the deadline (2022-12-15T09:30:22). You are past the first half of the allowed period.

Puzzle disappeared from the code, that's why I closed this ticket.

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Enhancement: Integrate Pycookiecheat into web scraping pipeline

As a user, I would like the application to be able to use my existing cookies/sessions from my web browser without me having to manually fuss about with them.
Using pycookie, this can be done programmatically.
Pycookie does not support windows by default, so I will need to add support for it.
https://github.com/rmusser01/pycookiecheat/blob/dev/README.md

Screw pycookiecheat. Claims to not support windows, yet has support for windows, but is broken, but tests run?
....


Please tag your release

The 0.2.0 bump was not tagged. Could you please tag it?

Looks like it's tagged now. I think this can be closed?
https://free.law/2023/02/16/webhooks-for-legal-data/


Update sqlite to 3.29.0

Hi,
Can you update sqlite to 3.29.0?
There is a new version with the sqlite3 update? If yes, answer here when it is updated to we update the conan repository.
Thanks.

Thanks, I update to sqlite 3.29.0 and will mark the result as a new release of SQLiteCpp 2.4.0

https://github.com/SRombauts/SQLiteCpp/releases/tag/2.4.0 :)


Mods are not working

Hi there.
I tried to set up a docker container with mods enabled. Therefor I used the exactly same files like in your examples directory. Unfortunately the mods won't be installed or enabled.
Here's my log:
[00:00:00]: PersistRootStorage is now /var/lib/dsta//./cluster/shard/
[00:00:00]: Starting Up
[00:00:00]: Version: 194420
[00:00:00]: Current time: Tue Nov  1 08:21:33 2016

[00:00:00]: System Name: Linux
[00:00:00]: Host Name: dst
[00:00:00]: Release(Kernel) Version: 4.4.0-36-generic
[00:00:00]: Kernel Build Timestamp: #55-Ubuntu SMP Thu Aug 11 18:01:55 UTC 2016
[00:00:00]: Machine Arch: x86_64
[00:00:00]: Don't Starve Together: 194420 LINUX
[00:00:00]: Build Date: 1378
[00:00:00]: Parsing command line
[00:00:00]: Command Line Arguments: -persistent_storage_root /var/lib/dsta -conf_dir . -cluster cluster -shard shard -backup_log_count 0
[00:00:00]: Initializing distribution platform
[00:00:00]: ....Done
[00:00:00]: THREAD - started 'GAClient'<PHONE_NUMBER>)
[00:00:00]: CurlRequestManager::ClientThread::Main()
[00:00:00]: ProfileIndex:8.41
[00:00:00]: [Connect] PendingConnection::Reset(true)
[00:00:00]: Network tick rate: U=15(2), D=0
[00:00:00]: Network tick rate: U=15(2), D=0
[00:00:00]: Error trying to change cluster setting (NETWORK->cluster_intention) from '' to 'cooperative'
[00:00:00]: OnLoadPermissionList: /var/lib/dsta//./cluster/blocklist.txt (Failure)
[00:00:00]: THREAD - started 'ConsoleInput'<PHONE_NUMBER>)
[00:00:00]: OnLoadPermissionList: /var/lib/dsta//./cluster/adminlist.txt (Failure)
[00:00:00]: OnLoadUserIdList: /var/lib/dsta//./cluster/whitelist.txt (Failure)
[00:00:00]: Token retrieved from: /var/lib/dsta//./cluster/cluster_token.txt
[00:00:00]: Token retrieved from: /var/lib/dsta//./cluster/cluster_token.txt
[00:00:00]: cGame::InitializeOnMainThread
[00:00:00]: Renderer initialize: Okay
[00:00:00]: AnimManager initialize: Okay
[00:00:00]: Buffers initialize: Okay
[00:00:00]: cDontStarveGame::DoGameSpecificInitialize()
[00:00:00]: FMOD Error: An invalid object handle was used.
[00:00:00]: GameSpecific initialize: Okay
[00:00:00]: cGame::StartPlaying
[00:00:00]: LOADING LUA
[00:00:00]: DoLuaFile scripts/main.lua
[00:00:00]: DoLuaFile loading buffer scripts/main.lua
[00:00:00]: running main.lua

[00:00:00]: Could not load modindex
[00:00:00]: ModIndex: Beginning normal load sequence for dedicated server.

[00:00:00]: DownloadMods(0)
[00:00:00]: FMOD Error: An invalid object handle was used.
[00:00:00]: LOADING LUA SUCCESS
[00:00:00]: PlayerDeaths could not load morgue
[00:00:00]: PlayerHistory could not load player_history
[00:00:00]: bloom_enabled	false
[00:00:00]: Could not load saveindex
[00:00:00]: OnFilesLoaded()
[00:00:00]: OnUpdatePurchaseStateComplete
[00:00:01]: 	Load FE
[00:00:01]: 	Load FE: done
[00:00:01]: ModIndex: Load sequence finished successfully.
[00:00:01]: Reset() returning
[00:00:02]: [200] Account Communication Success (6)
[00:00:02]: Received (KU_GWmhvzEo) from TokenPurpose
[00:00:02]: Starting Dedicated Server Game
[00:00:02]: Network tick rate: U=15(2), D=0
[00:00:02]: About to start a server with the following settings:
[00:00:02]:   Dedicated: true
[00:00:02]:   Online: true
[00:00:02]:   Passworded: false
[00:00:02]:   ServerPort: 10999
[00:00:02]:   SteamAuthPort: 8766
[00:00:02]:   SteamMasterServerPort: 27016
[00:00:02]:   ClanID: false
[00:00:02]:   ClanOnly: false
[00:00:02]:   ClanAdmin: false
[00:00:02]:   LanOnly: false
[00:00:02]:   FriendsOnly: false
[00:00:02]:   EnableAutosaver: true
[00:00:02]:   PVP: false
[00:00:02]:   MaxPlayers: 4
[00:00:02]:   GameMode: survival
[00:00:02]:   OverridenDNS:
[00:00:02]:   PauseWhenEmpty: true
[00:00:02]:   VoteEnabled: true
[00:00:02]:   InternetBroadcasting: true
[00:00:02]:   Intent: cooperative
[00:00:02]: [Shard] Shard server mode disabled by configuration file
[00:00:02]: Online Server Started on port: 10999
[00:00:02]: Not applying level data overrides.
[00:00:02]: Not applying world gen overrides.
[00:00:02]: Collecting garbage...
[00:00:02]: lua_gc took 0.02 seconds
[00:00:02]: ~ShardLuaProxy()
[00:00:02]: ~ItemServerLuaProxy()
[00:00:02]: ~InventoryLuaProxy()
[00:00:02]: ~NetworkLuaProxy()
[00:00:02]: ~SimLuaProxy()
[00:00:02]: lua_close took 0.02 seconds
[00:00:02]: ReleaseAll
[00:00:02]: ReleaseAll Finished
[00:00:02]: cGame::StartPlaying
[00:00:02]: LOADING LUA
[00:00:02]: DoLuaFile scripts/main.lua
[00:00:02]: DoLuaFile loading buffer scripts/main.lua
[00:00:02]: running main.lua

[00:00:02]: loaded modindex
[00:00:02]: ModIndex: Beginning normal load sequence for dedicated server.

[00:00:02]: LOADING LUA SUCCESS
[00:00:02]: PlayerDeaths could not load morgue
[00:00:02]: PlayerHistory could not load player_history
[00:00:02]: bloom_enabled	false
[00:00:02]: OnLoad slot	2	: World options was nil! Populating with default.
[00:00:02]: OnLoad slot	3	: World options was nil! Populating with default.
[00:00:02]: OnLoad slot	4	: World options was nil! Populating with default.
[00:00:02]: OnLoad slot	5	: World options was nil!  DONE
[00:00:03]: Checking Tags
[00:00:03]: Populating voronoi...
[00:00:03]: Warning! Could not find a spot for Maxwell2 in node Magic meadow:BG_17:Clearing
[00:00:03]: disconnected tiles...	0
[00:00:03]: Done forest map gen!
[00:00:03]: Checking map...
[00:00:03]: Generation complete
[00:00:03]: WorldSim::SimThread::Main() complete
[00:00:03]: Serializing world: session/C567D93603547EEE/0000000002
[00:00:03]: 	Unload FE
[00:00:03]: 	Unload FE done
[00:00:04]: 	LOAD BE
[00:00:05]: 	LOAD BE: done
[00:00:05]: Begin Session: C567D93603547EEE
[00:00:05]: saving to server_temp/server_save
[00:00:05]: MiniMapComponent::AddAtlas( minimap/minimap_data.xml )
[00:00:05]: Loading Nav Grid
[00:00:09]: Reconstructing topology
[00:00:09]: 	...Sorting points
[00:00:09]: 	...Sorting edges
[00:00:09]: 	...Connecting nodes
[00:00:09]: 	...Validating connections
[00:00:09]: 	...Housekeeping
[00:00:09]: 	...Done!
[00:00:09]: Halloween Trinkets added: 59
[00:00:09]: 1 uploads added to server. From server_temp
[00:00:09]: Telling Client our new session identifier: C567D93603547EEE
[00:00:09]: [Steam] SteamGameServer_Init(8766, 10999, 27016)
[00:00:09]: [Steam] SteamGameServer_Init success
[00:00:10]: Validating portal[1] <-> <nil>[1] (inactive)
[00:00:10]: Validating portal[2] <-> <nil>[2] (inactive)
[00:00:10]: Validating portal[3] <-> <nil>[3] (inactive)
[00:00:10]: Validating portal[4] <-> <nil>[4] (inactive)
[00:00:10]: Validating portal[5] <-> <nil>[5] (inactive)
[00:00:10]: Validating portal[6] <-> <nil>[6] (inactive)
[00:00:10]: Validating portal[7] <-> <nil>[7] (inactive)
[00:00:10]: Validating portal[8] <-> <nil>[8] (inactive)
[00:00:10]: Validating portal[9] <-> <nil>[9] (inactive)
[00:00:10]: Validating portal[10] <-> <nil>[10] (inactive)
[00:00:10]: Sim paused

Thanks for reporting! :+1: I'm on it.

The actual problem is that our image creates all the configuration files for the server, including the file dedicated_server_mods_setup.lua which gets overwritten afterwards, if a game-update is available.
In detail; we actually run build/static/boot/mods.sh which creates the mod-configuration, and afterwards we run build/static/dst/update.sh, which installs a new game-version, if available, which overwrites the dedicated_server_mods_setup.lua file again.
I believe we should move most of the logic in build/docker-entrypoint.sh to build/static/bin/start.sh, to ensure a consistent creation of the files.

This has been fixed and will be released with version 0.7. Thanks again for reporting!

Still not working with current origin/develop branch. Again I'm using exactly the same files like in the docs/examples/mods/ directory. Maybe it's related to https://github.com/dst-academy/docker-dontstarvetogether/pull/70?
world    | 0]: PersistRootStorage is now /var/lib/dsta//./cluster/shard/
world    | [00:00:00]: Starting Up
world    | [00:00:00]: Version: 194420
world    | [00:00:00]: Current time: Thu Nov  3 09:00:31 2016
world    |
world    | [00:00:00]: System Name: Linux
world    | [00:00:00]: Host Name: world
world    | [00:00:00]: Release(Kernel) Version: 4.4.0-36-generic
world    | [00:00:00]: Kernel Build Timestamp: #55-Ubuntu SMP Thu Aug 11 18:01:55 UTC 2016
world    | [00:00:00]: Machine Arch: x86_64
world    | [00:00:00]: Don't Starve Together: 194420 LINUX
world    | [00:00:00]: Build Date: 1378
world    | [00:00:00]: Parsing command line
world    | [00:00:00]: Command Line Arguments: -persistent_storage_root /var/lib/dsta -conf_dir . -cluster cluster -shard shard -backup_log_count 0 -skip_update_server_mods
world    | [00:00:00]: Initializing distribution platform
world    | [00:00:00]: ....Done
world    | [00:00:00]: THREAD - started 'GAClient'<PHONE_NUMBER>)
world    | [00:00:00]: CurlRequestManager::ClientThread::Main()
world    | [00:00:00]: ProfileIndex:4.00
world    | [00:00:00]: [Connect] PendingConnection::Reset(true)
world    | [00:00:00]: Network tick rate: U=15(2), D=0
world    | [00:00:00]: Network tick rate: U=15(2), D=0
world    | [00:00:00]: Error trying to change cluster setting (NETWORK->cluster_intention) from '' to 'cooperative'
world    | [00:00:00]: THREAD - started 'ConsoleInput'<PHONE_NUMBER>)
world    | [00:00:00]: OnLoadPermissionList: /var/lib/dsta//./cluster/blocklist.txt (Failure)
world    | [00:00:00]: OnLoadPermissionList: /var/lib/dsta//./cluster/adminlist.txt (Failure)
world    | [00:00:00]: OnLoadUserIdList: /var/lib/dsta//./cluster/whitelist.txt (Failure)
world    | [00:00:00]: Token retrieved from: /var/lib/dsta//./cluster/cluster_token.txt
world    | [00:00:00]: Token retrieved from: /var/lib/dsta//./cluster/cluster_token.txt
world    | [00:00:00]: cGame::InitializeOnMainThread
world    | [00:00:00]: Renderer initialize: Okay
world    | [00:00:00]: AnimManager initialize: Okay
world    | [00:00:00]: Buffers initialize: Okay
world    | [00:00:00]: cDontStarveGame::DoGameSpecificInitialize()
world    | [00:00:00]: FMOD Error: An invalid object handle was used.
world    | [00:00:00]: GameSpecific initialize: Okay
world    | [00:00:00]: cGame::StartPlaying
world    | [00:00:00]: LOADING LUA
world    | [00:00:00]: DoLuaFile scripts/main.lua
world    | [00:00:00]: DoLuaFile loading buffer scripts/main.lua
world    | [00:00:00]: running main.lua
world    |
world    | [00:00:00]: Could not load modindex
world    | [00:00:00]: ModIndex: Beginning normal load sequence for dedicated server.
world    |
world    | [00:00:00]: FMOD Error: An invalid object handle was used.
world    | 1]: LOADING LUA SUCCESS
world    | 1]: PlayerDeaths could not load morgue
world    | [00:00:01]: PlayerHistory could not load player_history
world    | 1]: bloom_enabled    false
world    | 1]: Could not load saveindex
world    | [00:00:01]: OnFilesLoaded()
world    | [00:00:01]: OnUpdatePurchaseStateComplete
world    | 1]:  Load FE
world    | 1]:  Load FE: done
world    | 1]: ModIndex: Load sequence finished successfully.
world    | [00:00:01]: Reset() returning
world    | 2]: [200] Account Communication Success (6)
world    | [00:00:02]: Received (KU_GWmhvzEo) from TokenPurpose
world    | [00:00:02]: Starting Dedicated Server Game
world    | [00:00:02]: Network tick rate: U=15(2), D=0
world    | 2]: About to start a server with the following settings:
world    | [00:00:02]:   Dedicated: true
world    | [00:00:02]:   Online: true
world    | [00:00:02]:   Passworded: false
world    | [00:00:02]:   ServerPort: 10999
world    | [00:00:02]:   SteamAuthPort: 8766
world    | [00:00:02]:   SteamMasterServerPort: 27016
world    | [00:00:02]:   ClanID: false
world    | [00:00:02]:   ClanOnly: false
world    | [00:00:02]:   ClanAdmin: false
world    | [00:00:02]:   LanOnly: false
world    | [00:00:02]:   FriendsOnly: false
world    | [00:00:02]:   EnableAutosaver: true
world    | [00:00:02]:   PVP: false
world    | [00:00:02]:   MaxPlayers: 4
world    | [00:00:02]:   GameMode: survival
world    | [00:00:02]:   OverridenDNS:
world    | [00:00:02]:   PauseWhenEmpty: true
world    | [00:00:02]:   VoteEnabled: true
world    | [00:00:02]:   InternetBroadcasting: true
world    | [00:00:02]:   Intent: cooperative
world    | [00:00:02]: [Shard] Shard server mode disabled by configuration file
world    | 2]: Online Server Started on port: 10999
world    | 2]: Not applying level data overrides.
world    | [00:00:02]: Not applying world gen overrides.
world    | 2]: Collecting garbage...
world    | 2]: lua_gc took 0.01 seconds
world    | [00:00:02]: ~ShardLuaProxy()
world    | [00:00:02]: ~ItemServerLuaProxy()
world    | [00:00:02]: ~InventoryLuaProxy()
world    | [00:00:02]: ~NetworkLuaProxy()
world    | [00:00:02]: ~SimLuaProxy()
world    | 2]: lua_close took 0.02 seconds
world    | 2]: ReleaseAll
world    | [00:00:02]: ReleaseAll Finished
world    | [00:00:02]: cGame::StartPlaying
world    | 2]: LOADING LUA
world    | [00:00:02]: DoLuaFile scripts/main.lua
world    | [00:00:02]: DoLuaFile loading buffer scripts/main.lua
world    | 2]: running main.lua
world    |
world    | 2]: loaded modindex
world    | [00:00:02]: ModIndex: Beginning normal load sequence for dedicated server.
world    |
world    | 2]: LOADING LUA SUCCESS
world    | 2]: PlayerDeaths could not load morgue
world    | [00:00:02]: PlayerHistory could not load player_history
world    | 2]: bloom_enabled    false
world    | 2]: OnLoad slot      2       : World options was nil! Populating with default.
world    | [00:00:02]: OnLoad slot      3       : World options was nil! Populating with default.
world    | 2]: OnLoad slot      4       : World options was nil! Populating with default.
world    | [00:00:02]: OnLoad slot      5       : World options was nil! Populating with default.
world    | 2]: loaded saveindex
world    | [00:00:02]: OnFilesLoaded()
world    | [00:00:02]: OnUpdatePurchaseStateComplete
world    | [00:00:02]: Load Slot: ... generating new world
world    | 2]: WorldSim::SimThread::SimThread()
world    | [00:00:02]: ABOUT TO INSTALL STACKTRACE
world    | [00:00:02]: DoLuaFile scripts/stacktrace.lua
world    | [00:00:02]: DoLuaFile loading buffer scripts/stacktrace.lua
world    | 2]: INSTALLED STACKTRACE
world    | [00:00:02]: WorldSim::SimThread::SimThread() complete
world    | [00:00:02]: THREAD - started 'WorldSim'<PHONE_NUMBER>)
world    | [00:00:02]: WorldSim::SimThread::Main()
world    | [00:00:02]: DoLuaFile scripts/worldgen_main.lua
world    | 2]: DoLuaFile loading buffer scripts/worldgen_main.lua
world    | 2]: ModIndex: Load sequence finished successfully.
world    | [00:00:02]: Reset() returning
world    | 2]: DLC enabled :    false
world    | 2]: running worldgen_main.lua
world    |
world    | [00:00:02]: SEED =<PHONE_NUMBER>
world    | 2]: Generating world with these parameters:
world    | [00:00:02]: level_type       SURVIVAL
world    | [00:00:02]: level_data:
world    | [00:00:02]:  K:      1        V:     table: 0xf125d130
world    | [00:00:02]:          K:      desc     V:     The standard Don't Starve experience.
world    | 2]:          K:      hideminimap      V:     false
world    | [00:00:02]:          K:      id       V:     SURVIVAL_TOGETHER
world    | [00:00:02]:          K:      location         V:     forest
world    | [00:00:02]:          K:      max_playlist_position    V:     999
world    | [00:00:02]:          K:      min_playlist_position    V:     0
world    | [00:00:02]:          K:      name     V:     Default
world    | [00:00:02]:          K:      numrandom_set_pieces     V:     4
world    | [00:00:02]:          K:      ordered_story_setpieces  V:     table: 0xf125d158
world    | [00:00:02]:                  K:      1        V:     Sculptures_1
world    | [00:00:02]:                  K:      2        V:     Maxwell5
world    | [00:00:02]:          K:      override_level_string    V:     false
world    | [00:00:02]:          K:      overrides        V:     table: 0xf125fd68
world    | [00:00:02]:                  K:      layout_mode      V:     LinkNodesByKeys
world    | [00:00:02]:                  K:      roads    V:     default
world    | [00:00:02]:                  K:      season_start     V:     default
world    | [00:00:02]:                  K:      start_location   V:     default
world    | [00:00:02]:                  K:      task_set         V:     default
world    | [00:00:02]:                  K:      world_size       V:     default
world    | [00:00:02]:                  K:      wormhole_prefab  V:     wormhole
world    | [00:00:02]:          K:      random_set_pieces        V:     table: 0xf125dc58
world    | 2]:                  K:      1        V:     Sculptures_2
world    | [00:00:02]:                  K:      2        V:     Sculptures_3
world    | [00:00:02]:                  K:      3        V:     Sculptures_4
world    | [00:00:02]:                  K:      4        V:     Sculptures_5
world    | [00:00:02]:                  K:      5        V:     Chessy_1
world    | [00:00:02]:                  K:      6        V:     Chessy_2
world    | [00:00:02]:                  K:      7        V:     Chessy_3
world    | [00:00:02]:                  K:      8        V:     Chessy_4
world    | [00:00:02]:                  K:      9        V:     Chessy_5
world    | [00:00:02]:                  K:      10       V:     Chessy_6
world    | [00:00:02]:                  K:      11       V:     Maxwell1
world    | [00:00:02]:                  K:      12       V:     Maxwell2
world    | [00:00:02]:                  K:      13       V:     Maxwell3
world    | [00:00:02]:                  K:      14       V:     Maxwell4
world    | [00:00:02]:                  K:      15       V:     Maxwell6
world    | [00:00:02]:                  K:      16       V:     Maxwell7
world    | [00:00:02]:                  K:      17       V:     Warzone_1
world    | [00:00:02]:                  K:      18       V:     Warzone_2
world    | [00:00:02]:                  K:      19       V:     Warzone_3
world    | [00:00:02]:          K:      required_prefabs         V:     table: 0xf125d298
world    | [00:00:02]:                  K:      1        V:     multiplayer_portal
world    | [00:00:02]:          K:      substitutes      V:     table: 0xf125f558
world    | [00:00:02]:          K:      version  V:     3
world    | [00:00:02]:
world    | #######
world    | #
world    | # Generating SURVIVAL Mode Level
world    | #
world    | #######
world    |
world    | [00:00:02]: Prefab Swap Selection: grass gekko
world    | [00:00:02]: Prefab Swap Selection: regular twigs
world    | 2]: Prefab Swap Selection: regular berries
world    | 2]: Maxwell2 added to        Make a pick
world    | [00:00:02]: Warzone_2        added to        Mole Colony Rocks
world    | [00:00:02]: Chessy_3 added to        Speak to the king
world    | [00:00:02]: Warzone_3        added to        Squeltch
world    | 2]: New size:        425     default
world    | [00:00:02]: Creating story...
world    | 2]: LinkNodesByKeys
world    | 2]: Finding valid start task...
world    | [00:00:02]:    ...picked     Make a pick
world    | [00:00:02]: Has start node   Clearing
world    | 2]: Baking map...    425
world    | [00:00:02]: [WorldSimActual::GenerateVoronoiMap]
world    | [00:00:02]: GenerateVoronoiMap [1]:
world    | 0:02]: ...Done.
world    | 2]: [AddEmptyNodes]
world    | 2]: GenerateVoronoiMap [100]:
world    | ...20....30....40....50....60....70....80....90....100
world    | [00:00:04]: ...Done.
world    | 4]: [WorldSimActual::GenerateVoronoiMap] complete [success]
world    | 4]: [WorldSimActual::ConvertToTileMap]
world    | 4]: [ConvertToTileMap]
world    | 4]: [WorldSimActual::ConvertToTileMap] complete
world    | [00:00:04]: [WorldSimActual::SeparateIslands]
world    | [00:00:04]: [SeparateIslands]
world    | 4]: [WorldSimActual::SeparateIslands] complete
world    | [00:00:04]: Map Baked!
world    | [00:00:04]: [WorldSimActual::ForceConnectivity]
world    | [00:00:04]: [GenerateLandmasses]
world    | 4]: [MergeConnectedLandmasses] true
world    | 4]: [WorldSimActual::ForceConnectivity] complete
world    | [00:00:04]: [GetWormholesExtra] connected 0 unconnected 1
world    | [00:00:04]: [GetWormholesExtra] after: connected 1 unconnected 0
world    | [00:00:04]: [GetWormholesExtra] pushed 0 wormholes
world    | [00:00:04]: [WorldSimActual::DrawRoads]
world    | [00:00:04]: [DrawRoads]
world    | 4]: [WorldSimActual::DrawRoads] complete
world    | 4]: Encoding...
world    | 4]: Encoding... DONE
world    | 4]: Checking Tags
world    | 4]: Populating voronoi...
world    | 4]: Warning! Could not find a spot for Maxwell2 in node Make a pick:5:Plain
world    | 4]: disconnected tiles...    0
world    | 4]: Done forest map gen!
world    | [00:00:04]: Checking map...
world    | [00:00:04]: Generation complete
world    | 4]: WorldSim::SimThread::Main() complete
world    | 4]: Serializing world: session/9F5D45DBCA6B1372/0000000002
world    | 4]:  Unload FE
world    | 4]:  Unload FE done
world    | 5]:  LOAD BE
world    | 6]:  LOAD BE: done
world    | 6]: Begin Session: 9F5D45DBCA6B1372
world    | 6]: saving to server_temp/server_save
world    | 6]: MiniMapComponent::AddAtlas( minimap/minimap_data.xml )
world    | 6]: Loading Nav Grid
world    | 9]: Reconstructing topology
world    | [00:00:09]:  ...Sorting points
world    | 9]:  ...Sorting edges
world    | 9]:  ...Connecting nodes
world    | 9]:  ...Validating connections
world    | 9]:  ...Housekeeping
world    | 9]:  ...Done!
world    | 9]: Halloween Trinkets added: 77
world    | 9]: 1 uploads added to server. From server_temp
world    | [00:00:09]: Telling Client our new session identifier: 9F5D45DBCA6B1372
world    | 9]: [Steam] SteamGameServer_Init(8766, 10999, 27016)
world    | [S_API FAIL] SteamAPI_Init() failed; SteamAPI_IsSteamRunning() failed.
world    | breakpad minidump AppID = 322330
world    | [00:00:09]: [Steam] SteamGameServer_Init success
world    | 9]: Validating portal[1] <-> <nil>[1] (inactive)
world    | 9]: Validating portal[2] <-> <nil>[2] (inactive)
world    | 9]: Validating portal[3] <-> <nil>[3] (inactive)
world    | [00:00:09]: Validating portal[4] <-> <nil>[4] (inactive)
world    | [00:00:09]: Validating portal[5] <-> <nil>[5] (inactive)
world    | [00:00:09]: Validating portal[6] <-> <nil>[6] (inactive)
world    | 0]: Validating portal[7] <-> <nil>[7] (inactive)
world    | 0]: Validating portal[8] <-> <nil>[8] (inactive)
world    | 0]: Validating portal[9] <-> <nil>[9] (inactive)
world    | 0]: Validating portal[10] <-> <nil>[10] (inactive)
world    | 0]: Sim paused

@ColorizedMind For now you need to adapt the docker-compose.yml file a bit to get the current development version of the image. Try to use this docker-compose.yml file and be sure to start your Docker container by using the provided start.sh file in the directory.
version: "2"
services:
  world:
    image: dstacademy/dontstarvetogether:next
    container_name: world
    hostname: world
    tty: true
    stdin_open: true
    env_file: world.env
    command: --update=all
    ports:
      - "10999:10999/udp"
    volumes:
      - ./world:/var/lib/dsta/cluster
```

Please report back if this works for you consistently. Thanks!

I have similar issue:

I just pull the latest image, seem like the latest version which include the 0.7 changes (let me know if it's wrong
the command --update=all is in compose file
Similar logs, seem like mods downloaded and set up, but when i load game, there is nothing. The server list also shows that game does not have mods

@SharkIng Would you mind sharing your setup? Thanks!

# MODS
MODS=378160973,492173795,407705132,376333686,345692228,459280938
MODS_OVERRIDES

return {
	['workshop-378160973'] = { enabled = true },
	['workshop-492173795'] = { enabled = true },
	['workshop-407705132'] = { enabled = true,
		configuration_options = {
			title = 'Welcome To DST!',
			message = 'This is a private DST server!',
		},
	},
	['workshop-376333686'] = { enabled = true },
	['workshop-345692228'] = { enabled = true },
	['workshop-459280938'] = { enabled = true },
}

The most config are default and/or copy-paste from example.
I am still debugging and I may need rebuild entire server for a clean installation. I'll let you know when I found anything useful.
And something for other users:

DS mods are not working, and some DST mods seem like not configurable.
Some mods not working at ALL (Maybe) and remove it may solve problem
Edit configuration seem like need clean build/launch new DST docker.(?)

Tried it and in my case the server installs the mods, although not all mods are showing up.


[MEDIUM] Axios Cross-Site Request Forgery Vulnerability

Github reported a new dependabot security alert at: https://github.com/cdk8s-team/cdk8s-plus/security/dependabot/14

Stale


Fixes #3859

A small change in the carousel js file as mentioned in issue #3859

Hey there 👋
We are happy to see, that you have created a pull request to fix a problem or add a feature or did something else.
Unfortunately does your PR include compiled files. Please do not edit materialize.css, materialize.js or any .html file directly! Those files are automatically generated. You should edit the source files in the locations below instead. Also make sure to check out our CONTRIBUTING GUIDE!
/materialize/sass/
/materialize/js/
/materialize/jade/page-contents/

We won't look into this, unless you modify your PR, so that it matches with our CONTRIBUTING guidelines.