Fix various minor issues in the Shelley & Babbage specs

Description
Closes #4278 and #4280. I noticed that PRTCL in Shelley also had a minor issue, so I fixed them both in the same way.
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

https://github.com/IntersectMBO/cardano-ledger/blob/5bc5c147c7a744c393cdceb4f6acdae0431a8bfe/eras/babbage/formal-spec/remove-overlay.tex#L167
This is a new mistake I hadn't spotted before: $slot$ is not defined; my guess is that there should be a new assignment $slot := \mathsf{bslot}\;bhb$.

Ah, the missing slot is also missing from the Shelley spec. In that case it does make sense to have bhb defined in both cases.

I just spotted a new mistake in the Shelley spec: In Figure 5, the function $\mathsf{vrf}_\mathsf{T}$ returns a value of type $\mathsf{T} \times \mathsf{Proof}$ but the function $\mathsf{verifyVrf}_\mathsf{T}$ expects a value of type $\mathsf{Proof} \times \mathsf{T}$, therefore the expression $\mathsf{verifyVrf}_\mathsf{T}\;vk\;seed\;(\mathsf{vrf}_\mathsf{T}\;sk\;seed)$ is ill-typed. When fixing this, we shall take into account the uses of $\mathsf{verifyVrf}_\mathsf{T}$ in Section 12.9. I'll update the description of #4278 to include this new mistake.

$vrf_T$ appears to be unused, which makes sense since we don't need to generate new VRF values to verify a block. So I think I'll just change the type of that to make the correctness expression type check, and then nothing else needs adjustment.

I hope you're done finding issues 😅

I hope you're done finding issues 😅

The only remaining issue is the following: In Figure 9 of the Babbage spec, we should change $(value, proof)$ to $(proof, value)$ in the definition of $\mathsf{vrfChecks}$.


I won't merge. Could you remove the respective code and stash the PR so any history of the alien code is gone?
Please add a big HEADS UP in the future to the PR whenever you include code from any source other than your own brain;)


When selecting a huge chunk of text (possibly over the character limit), the chat doesn't recognize the selection.

VS Code Version: 1.79.0-insider
OS Version: 11

Steps to Reproduce:

Select a huge chunk of text
Try asking it to do something

[...] and if you select nothing copilot interacts only until the limit is reached.

Same for me. I see no reason why I should use Github Copilot Chat, when I have exactly the same user experience on https://chat.openai.com/ It would be a game changer if I could ask it questions regarding the whole codebase.

Duplicate of #173


TLA

Adds initial support for TLA with some basic tests, resolving https://github.com/bytecodealliance/StarlingMonkey/issues/14.
There is still work to do on improving errors and unhandled rejections.
Also expands the test suite to better support error output testing to enable these follow-ups.
Note, this requires https://github.com/bytecodealliance/StarlingMonkey/pull/25 to land first for CI to pass.

Oops, hit the button without leaving a comment. This looks really great, thank you!
I requested a few changes, but I think they should all be fairly minor.


BUG: feedback in nav bar doesn't redirect to page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
there are two tabs - contact us and feedback , feedback doesnt direct to any page and contact us has feedback feature.
So , remove contact us from nav bar.
also can add phone no. and mail id for contact in footer section(please provide them).
@Its-Aman-Yadav please assign this to me and provide necessary details.
I am GSSOC'24 contributor.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

can you assign me this issue


Run Linux Images

Is there a way to switch to running a Linux Container on the Windows Server 2016?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a1c4c54-7721-58ce-f77d-be0ef0c687bf
Version Independent ID: 70e52446-1c7b-78ff-67f2-1f6c0d058788
Content: Windows and Linux Containers on Windows 10
Content Source: virtualization/windowscontainers/quick-start/run-your-first-container.md
Service: windows-containers
Product: windows-containers
GitHub Login: @cwilhit

There is not. We do support running Linux containers on Windows 10 through Docker Desktop for Windows (more info here: https://docs.microsoft.com/en-us/virtualization/windowscontainers/quick-start/quick-start-windows-10-linux)

I had to install a Windows 10(1903) D2s_v3 machine, enabled Hyper-V and Containers Windows Features, then installed Docker Desktop for Windows to this to work.

Yep, glad you found a solution!


How

How to use the Global Add Tokens

go to the url bar when you are in blooket

type   "  javascript:  "
then paste your code in
it should look like this

then, refresh your page and you should be good to go

or, if u are on windows, click inspect (Ctrl-Shift-C), and paste it into console

then refresh the page

@KimaKween  its easier this way, its faster.


Fix  color lights, Tuya specific commands

Implementation of Tuya specific Color control cluster and Tuya specific Zigbee light driver.
This solves the following problems for light devices:

Switch between color and temperature
Setting color temperature
Correct colors ( Tuya colors are always a little off, this also for wifi devices and their own app)
Dim when in color mode

Tested with the Lidl Garden light.
Garden light needs correct pictures and Icon!

Thanks for all the help and cooperation @jurgenheine !
Lots of fun and quite som new grey hairs ;)
Code and credits/attribution added to the app! 🥇 👍

I glad I could help


http error: Client died

I'm not sure I'm actually putting this in the correct repo in terms of root cause, since it could be down to an HTTP or TLS error :) but gRPC is what I'm directly interacting with
So I'm trying to write a Rust client for one of our products, which uses gRPC.  I've managed to get everything to compile, but when I try to interact with either of the two gRPC services I'm importing, the requests seem to be failing with "http error: Client died"
Both are unary requests and unary responses.  One of the responses is an Empty, the other is a real thing.
I'm not opposed to digging in and debugging, since I'm sure I'm just doing something wrong, but I'm not sure where to start - any direction to kick that off would be very appreciated.
Thanks!

When I was testing I got this error when I was pointing at the wrong port for example.
Not sure if it helps.


Checkstyle classpath is set incorrectly for multi-project builds

Expected Behavior
If project A depends on project B, then the javadoc for a function defined in A should be able to reference an exception defined in B.
Current Behavior

If a function's javadoc has more than one @throws tag, one of which references an exception in a different project, then the Gradle Checkstyle task shows an error:

[ant:checkstyle] [ERROR] .../checkstyle-bug/client/src/main/java/csbug/BarInterface.java:10:22: Unable to get class information for @throws tag 'FooException'. [JavadocMethod]

This doesn't happen if there's only a single @throws tag
This only happens for Checkstyle newer than 6.11.2 (including the most recent release 7.2)
This happens for Gradle 2.12 - 3.1
This can be fixed by manually adding dependencies to the Checkstyle classpath:

tasks.checkstyleMain.classpath += configurations.compileClasspath

Context
It's reasonable to have a project that contains API classes (interfaces, data formats, exception types) and dependent projects that reference API classes. Functions that throw (and document) multiple exception types are common as well.
Steps to Reproduce (for bugs)
https://github.com/punya/checkstyle-bug minimally demonstrates the problem. Uncomment these two lines to fix the problem manually.
Your Environment

Build scan URL: https://scans.gradle.com/s/umlviaz4noymq

@punya Thank you for the excellent bug report.

@eriwen I'm thinking of submitting a PR to fix this, which amounts to
-        task.setClasspath(sourceSet.getOutput());
+        task.setClasspath(sourceSet.getOutput().plus(sourceSet.getCompileClasspath()));

in CheckstylePlugin.java. Before diving in to write integration tests, etc, I wanted to check if further discussion (on the mailing list) or a design doc would be necessary for this change.

@punya Thanks for asking. I don't think that a design doc is necessary given the scope of this bug. If we have sufficient test coverage, I'm 100% good with that.

Moving to Ready To Deliver with changes in #863


ci: Fix permission on E2E for the release-v0.31.x

Fixes #N/A
Description

Update the Permission for E2E testing

How was this change tested?

N/A

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.216%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6872

Relevant Lines:
8160

💛  - Coveralls


Use pgx in controller instead of pq

We're standardizing on pgx in the codebase, so all uses of pq in the controller should be converted to pgx.

An easy way to start on that is to set the sql driver to pq.


Proposal: New Revit conversion Logic + Validation

It's been proposed to restructure the converter class into multiple classes.
Let's get a proposal in place and discuss it together.

https://www.notion.so/speckle/Revit-Converter-Refactor-0d8bb9858f4a405998fd4a19c7016652

Closing for now


GitLab pull request formatter

Hi @mmozuras,
thank you for the awesome gem!
I use it with GitLab instance.
I noticed that only commit formatter exists for GitLab. But GitLab API contains endpoints to work with comments on pull requests (merge requests as they call them).
Is it possible to enable pull request commenting for GitLab (maybe there are some restrictions I don't know about) ?
If it is I would happily start to working on it.

Seems like I understand the problem now.
Merge request API allows to create a note for the entire merge request. We can't specify particular line of code.
And comment for commit API allows to do per-line commenting.
😞

Hi, the Merge request API should have per-line commenting soon, it is already implemented https://gitlab.com/gitlab-org/gitlab-ce/issues/20901
It will be released in 9.2 version at May 21.

@mikes01 cool, thank you!
Then I will continue work on PR after API updates.

Looks like implementing this feature will also close #106

It seems like the GitLab issue was moved to 9.3 milestone which has due date on June, 21.

@mmozuras to be honest I didn't read all the discussions because the are huge enough.
As I can see 9.2 (initial milestone for the issue) still has very much to do. And it should be closed 3 days ago, on May 21 😕

And it is moved to 9.4 😞

This API seems to be implemented in 10.8 release :-D https://docs.gitlab.com/ce/api/discussions.html

PR https://github.com/prontolabs/pronto/pull/308  ;)


switch to pytest?

github action supports pytest only?
look into it

I happen to have one repo using pytest, see config here: https://github.com/norkator/nx100-remote-control/blob/master/.github/workflows/python-app.yml

Now I noticed you already have something but you are missing "requirements" file which in this case is like "package.json" dependencies.


Fix connection from service to gregord

Use real authentication
Provide error wrapper
Add hooks to authenticate upon login
Retry the connection
Don't try to make a gregord connection in production
Revendor

r? @maxtaco

Had some questions....

Made it so service only connects to gregord when it is logged in.  OnLogin, OnLogout hooks to maintain the connection on login state changes.
PTAL @maxtaco

👍


Added two Python Playlists

I have added name of two YouTube channel on  Python Playlists on YouTube. Also added thenewboston(Buckey Robert)  on Top YouTube Creators list. He is one of the oldest and with 2.66M subscribers.

Your PR has been merged. Thanks for the contribution. Looking forward to some more contributions in future.


Layouts (stored in local storage) are being reset every reload

Hi! Regarding Demo 8 - Responsive with LocalStorage,
Is react-grid-item accept data(an array) fetched from Firebase?
Below is my class component of a memo app:
...
...
...
render(){
 return (

    <ResponsiveReactGridLayout
        className="layout"
        breakpoints={{lg: 1200, md: 996, sm: 768, xs: 480, xxs: 0}}
        cols={{ lg: 12, md: 10, sm: 6, xs: 4, xxs: 1 }}
        rowHeight={40}
        layouts={this.state.layouts}
        onLayoutChange={(layout, layouts) =>
            this.onLayoutChange(layout, layouts)
         }>
        {this.props.addedMemos.map(memo => (
            {/* 1st div */}

 this.memoClicked(memo)}>

{memo.title}

{memo.content}

            {/* 2nd div */}

Title

Content

                ))}
    </ResponsiveReactGridLayout>

 );
}

Because it seems that the layouts(stored in local storage) for fetched data (from Firebase) are being reset every time I reload. That means the postitions of those data are stack on the top-left corner in every reload.
2nd div:
However, the hard-coded 2nd div doesn't lost its layouts in local storage. The position of the 2nd div memo remains after reload. That's why I am wondering if react-grid-item support data fetching from Firebase(or other online db).
1st div:
I have tried axios and fetch() to get the data(an array) from Firebase via Redux ( this.props.addedMemos is an array from Redux store ). The data from Firebase is fetched successfully tho. If I don't reload the page and resize the grid items, the layouts are changed successfully in local storage. The local storage functions saveToLS and getFromLS are working fine too.
Thank you for your time~

Would it be possible to get a working version of your code somewhere? It's hard to troubleshoot something like this, let alone with screenshots and code snippets.
I recommend adding a lot of console.log() in various parts and try to pinpoint where it is being overwritten.
From what I can gather you're saying that you are able to load the memo correctly from firebase with the correct layout, but as soon as you reload the page it changes to a different size... Do the values saved to firebase change to the wrong ones? Where do you grab the data from Firebase, because your code just shows that you're using local storage.

Here is my current memo app from Google Drive that has the mentioned problem. Please execute npm install and npm start to investigate🙏.
In my current memo app:
All gridLayout is saved to localStorage.
There are two types of memo:

The title and content of memo are stored on Firebase.
The title and content of memo are stored on local array.

Both type of memo can store the layout to localStorage successfully while resizing or dragging.
However, Type 1 of the memo will lose the layout after reload, while Type 2 of the memo will NOT lose the layout after reload.

Hey @hkKevin, I verified that when you modify your Firebase widget it does save to localStorage properly and is called back properly when your page reloads.
Here is what I've tracked down so far...

mapStateToProps is called immediately, even before componentDidMount() which returns an empty array for your state.memos
onLayoutChange() is being called before your component mounts, with your firebase widgets missing. This is causing the layout that you load from localStorage to be overwritten, thus the firebase widget isn't maintaining size & position.
I wouldn't return data from mapStateToProps until you know that you have a response from firebase. If you don't get a response from firebase then perhaps fallback on localStorage? I believe this is the primary cause of your problem. You're trying to generate firebase widgets before you have a response. If you don't have a response yet then use the widget saved to localStorage and don't overwrite it with onLayoutChange
this.props.onFetchMemos() is being called in componentDidMount() I moved it up to componentWillMount()  so that it can get started in the process a little earlier.

Here are the changes I made to your code.
  componentWillMount() {
    console.log('componentWillMount');
    console.log(this.state.layouts);
    this.props.onFetchMemos();
  }

  componentDidMount() {
    console.log('componentDidMount');
    console.log(this.state.layouts); // layout is correct here
    ...
  }

  onLayoutChange(layout, newLayout) {
    console.log('onLayoutChange');
    console.log(this.state.layouts); // correct first time

    console.log(layout); // missing the firebase widget here
    saveToLS("layouts", newLayout);
    this.setState({ layouts: newLayout });
  }

  generateAddedMemos = () => {
    console.log('generateAddedMemos');
    console.log(this.props.addedMemos);
    if(this.props.addedMemos.length > 0) {
      return this.props.addedMemos.map(memo => (

 this.memoClicked(memo)}>

{memo.title}

{memo.content}

      ));
    } else {
      console.error('no firebase widgets available yet.');
    }
  }

  generateDummyMemos = (dummyMemos) => {
    console.log('generateDummyMemos');
    return dummyMemos.map(memo => (

 this.memoClicked(memo)}>

{memo.title}

{memo.content}

    ));
  }

I suggest breaking out your widget mapping into their own functions to clean up your component code. I included generateAddedMemos() and generateDummyMemos() above. Here is the modified component render code.
  <ResponsiveReactGridLayout
    className="layout"
    breakpoints={{ lg: 1200, md: 996, sm: 768, xs: 480, xxs: 0 }}
    cols={{ lg: 12, md: 10, sm: 6, xs: 4, xxs: 1 }}
    rowHeight={40}
    layouts={this.state.layouts}
    onLayoutChange={(layout, newLayout) =>
      this.onLayoutChange(layout, newLayout)
    }>
      {this.generateAddedMemos()}
      {this.generateDummyMemos(dummyMemos)}
    </ResponsiveReactGridLayout>

I did it! Working great.
Thank you very much @CWSites!!!
The solution is to execute the follow code until the memos are fetched successfully from Firebase.
<ResponsiveReactGridLayout
    className="layout"
    breakpoints={{ lg: 1200, md: 996, sm: 768, xs: 480, xxs: 0 }}
    cols={{ lg: 12, md: 10, sm: 6, xs: 4, xxs: 1 }}
    rowHeight={40}
    layouts={this.state.layouts}
    onLayoutChange={(layout, newLayout) =>
      this.onLayoutChange(layout, newLayout)
    }>
      {this.generateAddedMemos()}
      {this.generateDummyMemos(dummyMemos)}
    </ResponsiveReactGridLayout>

Also, I fetch the memos in function componentWillMount.

Hi,
I am having a similar issue in getting my react-grid-layout to read from local storage when it loads. I want to save it and access the layouts using the username key which is specific to each different user. I can save the layouts into local storage, and have had no problem doing that, however when I try to 'getLayout' from LS, I get an error everytime. I was wonderign if you'd be able to help, my code for al is below:
const ReactGridLayout = WidthProvider(Responsive);

//Find username form localstorage (uuid string)
const username = localStorage.getItem('username')

const Dash = (props) => {
  //Variable used for id of grid component:
  const id = uuid()

  //Hook to set layout state
  const originialLayouts = getLayout("layouts") || {}
  const savedLayout = JSON.parse(JSON.stringify(originialLayouts))
  console.log(JSON.parse(JSON.stringify(originialLayouts)))

  //column size is static
  //layouts taken from local storage via function
  const [ state, setState ] = React.useState({
    cols: { lg: 12, md: 10, sm: 6, xs: 4, xxs: 2 },
    rowHeight: 30,
    layouts: JSON.parse(JSON.stringify(originialLayouts)) || state.layout,
    layout: [].map(function(i, list) {
      return {
        i: i.toString(),
        x: i * 2,
        y: 0,
        w: 3,
        h: 3,
        add: i === (list.length - 1)
      }
    })
  })

  //function ammends layout array with additional grid item
  const addItem = (item) => {
    console.log('adding: ' + id);
    const newLayout = state.layout;
    newLayout.push({
      i: `${id}`,
      x: (state.layout.length * 3) % (state.cols || 12),
      y: 0,
      w: 3,
      h: 3
    })
    setState({layout: newLayout})
  }

  //function to remove grid item on click
  const removeItem = (i) => {
    console.log(i)
    setState({ layout: _.reject(state.layout, { i:i }) })
  }

  //function to save layout to LS everytime a grid item is moved.
  const onLayoutChange = (layout, layouts) => {
    console.log(layouts)
    saveLayout("layouts", layouts)
    console.log(state.layout)
  }

  return (

      <button onClick={addItem}>Add Item</button>
        <ReactGridLayout
          className="layout"
          breakpoints={{ lg: 1200, md: 996, sm: 768, xs: 480, xxs: 0 }}
          onLayoutChange={(layout, layouts) => onLayoutChange(layout, layouts)}
          cols={{ lg: 12, md: 12, sm: 6, xs: 4, xxs: 2 }}
          resizeHandles={['s', 'w', 'e', 'n', 'sw', 'nw','se', 'ne']}
          compactType={"vertical"}
          draggableHandle=".dragHandle"
      >
        {_.map(state.layout, (item, i) => (

Drag From Here

            <DashItem>
            <button onClick={() => removeItem(item.i)}>Remove Item</button>
                 <CreateGraph key ={i} data={state.layout[i]}/>
            </DashItem>

Drag From Here

        ))}
        </ReactGridLayout>

  );
}

//function to get user layout from LS
const getLayout = (key) => {
  let ls = {};
  if (global.localStorage) {
    try {
      ls = JSON.parse(global.localStorage.getItem(username)) || {};
    } catch (error) {
      console.log('error with getLayout')
    }
  }
  return ls[key]
}

//function to save user layout to LS
const saveLayout = ( key, value ) => {
  if (global.localStorage) {
    global.localStorage.setItem( username, JSON.stringify({ [key]: value}) );
  }
}

export default Dash;

Thanks in advance


Adding nested levels to Outline -> how to?

In the JsonColorsAndNavigation description you wrote:
Json outline for better code navigation
A clickable list of idented keys will be shown. Additionally, JCAN adds one space per nested level with the symbolTransformation property to display identation.
The questions are:

where is the symbolTransformation located?
how to edit the symbolTransformation ?
please provide an example for adding nested levels to the Outline Panel?

Thank you in advance!

In the JsonColorsAndNavigation description you wrote: Json outline for better code navigation A clickable list of idented keys will be shown. Additionally, JCAN adds one space per nested level with the symbolTransformation property to display identation. The questions are:

where is the symbolTransformation located?
how to edit the symbolTransformation ?
please provide an example for adding nested levels to the Outline Panel?

Thank you in advance!

<symbolTransformation> is an XML key located in the *.tmPreferences. I chose to save them all in the symbols folder. I believe sublimes uses cosmic config, and it will check for all folders to load and parse configuration files.
You edit its value by changing the contents of the <string> key immediately following the <symbolTransformation> key. This is a Regular Expression. Multiple Regex are accepted, one per line within that key.
The symbols folder contains 8  *.tmPreferences files. Read them, change stuff around and you will learn how it affects the outline.

Could the nested levels be added to Verilog files? Where should the symbolTransformation be found for Verilog files?

I haven't explored much about the nesting myself. I know there's a key used for nesting, however, I chose to use a pseudo-nesting. Eg. the regex s//      / will replace an empty match with 6 spaces (thus adding a 6 space ident like effect at the beginning of the line.


Exclude nested functions

Describe the bug
When we have a function which has nested functions and if parent function is excluded, the inner functions should also be excluded
Expected behavior
Nested functions should be excluded when parent function is excluded
Reproducer
Repo: Focus Launcher
Reports

Environment

Kover Gradle Plugin version: 0.7.0
Gradle version: 8.0.2
Kotlin project type: Kotlin/Android

Please, try version 0.7.1

I still see it


Error: Could not load plugin wdio from module './plugin/wdio': Cannot find module './plugin/wdio'

What are you trying to achieve?
I tried to use codecept js with webdriver as helper to run visual testing.
What do you get instead?
When ran the test with specific config file, ran into below error:

Provide test source code if related
package.json as below:

config.js as below

Details

CodeceptJS version:
NodeJS Version: v8.11.3
Operating System: MAC OS High Sierra
webdriverio
Configuration file:

# paste config here

Can anybody give any support on this? Thanks in advance.

I got the same issue
Here is my configuration
const { setHeadlessWhen } = require("@codeceptjs/configure");

// turn on headless mode when running with HEADLESS=true environment variable
// HEADLESS=true npx codecept run
setHeadlessWhen(process.env.HEADLESS);

exports.config = {
  tests: "./*_test.js",
  output: "./output",
  helpers: {
    WebDriver: {
      url: "http://localhost",
      browser: "chrome",
      host: "<IP_ADDRESS>",
      port: 4444,
      restart: false,
      windowSize: "1920x1680"
    }
  },
  include: {
    I: "./steps_file.js"
  },
  bootstrap: null,
  mocha: {},
  name: "googlecalendar",
  plugins: {
    retryFailedStep: {
      enabled: true
    },
    screenshotOnFail: {
      enabled: true
    },
    wdio: {
      enabled: true,
      services: ["selenium-standalone"]
    }
  }
};

{
  "name": "googlecalendar",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "devDependencies": {},
  "dependencies": {
    "@wdio/selenium-standalone-service": "^6.0.4",
    "codeceptjs": "^2.5.0"
  }
}

Notes: already install selenium-standalone

Facing the issue :
Could not load plugin wdio from module './plugin/wdio':
Cannot read property 'outputDir' of undefined
"devDependencies": {
"@wdio/cli": "^6.0.14",
"@wdio/selenium-standalone-service": "^6.0.12",
"codeceptjs": "^2.6.1",
"webdriver": "^6.0.14"

why is it closed?

Use version 5.16.10 of @wdio/selenium-standalone-service
    "@wdio/selenium-standalone-service": "^5.16.10",

Use version 5.16.10 of @wdio/selenium-standalone-service
    "@wdio/selenium-standalone-service": "^5.16.10",

TSError: ⨯ Unable to compile TypeScript:
src/specs/e2e/main.spec.ts:1:1 - error TS2304: Cannot find name 'Feature'.

1 Feature('My First Test')
  ~~~~~~~
src/specs/e2e/main.spec.ts:3:1 - error TS2304: Cannot find name 'Scenario'.

3 Scenario('test something', I => {
  ~~~~~~~~

It crash on Typescript environment.

exports.config = {
tests: '././*_test.ts',
//output: './output',
timeout: 10000,
helpers: {
WebDriver: {
url: 'https://localhost.com/dummy',
browser: 'chrome',
smartWait: 5000,
windowSize: '1920x1680',
desiredCapabilities: {
chromeOptions: {
useAutomationExtension: false,
// args: [
//   '--headless',
//   '--disable-gpu',
//   '--disable-web-security',
//   '--window-size=1200,1000',
//   '--no-sandbox'
// ]
}
}
}
},
plugins: {
wdio: {
enabled: true,
services: [
['selenium-standalone', {
installArgs: {
version: '3.141.59',
baseURL: 'https://selenium-release.storage.googleapis.com',
drivers: {
chrome: {
version: '84.0.4147.30',
baseURL: 'https://chromedriver.storage.googleapis.com'
}
},
proxy: 'http://http.corporateproxy.com:port'
},
args: {
drivers: {
chrome: {
version: '84.0.4147.30'
}
}
}
}]
]
}
},
include: {
I: './steps_file.js'
},
bootstrap: null,
//mocha: { },
name: 'e2e'
}
"@wdio/cli": "^6.3.6",
"@wdio/selenium-standalone-service": "^6.1.14",
"codeceptjs": "^2.6.6",
"webdriverio": "^6.1.23"
Experiencing this Error :
Could not load plugin wdio from module './plugin/wdio':
name.toLowerCase is not a function
could someone help us i resolving this

Hi
I got same error. and this error occurs here:
https://github.com/codeceptjs/CodeceptJS/blob/master/lib/plugin/wdio.js#L100
I think we should modify here:

services: [
['selenium-standalone', {
installArgs: {

What we should modify? It still throws the error


added support for nvidia jetson camera

Hi,
I've added support to the videostream class for the in built nvidia jetson tx2 camera using gstreamer functionality.
I've provided a switch in the videostream class to enable this support in the same way as you do for the raspberry pi camera, but am happy to enable the support any other way.
Regards,
Alex

This is a really cool contribution, thanks @al3xsh. I would definitely like to include it in imutils; however, since the NVIDIA Jetson is so niche specific I'd like to keep it from the VideoStream class factory and instead use just JetsonVideoStream. If you can update the PR I'll merge it in.

@jrosebr1 thanks for the feedback!  I have no problem adding it to it's own class - i'll try to make those changes this week and will update the PR once it's done.
Cheers,
Alex

Thanks @al3xsh!

Hey @jrosebr1, This PR looks good to be merged, the flag useJetsonCamera  flag can definitely be used in VideoStream and it will not alter the existing functionality of this class but rather adds to it, will be a nice addition to imutils library in my opinion. 👍

I agree that it will be a nice addition, I just don't want it called from the VideoStream factory, that's all 😄 If it's a standalone class I'm 100% on board with it.

I have no problem splitting it out as a standalone class. I'm afraid the day job has got in the way recently though!
It's on my to-do list for Christmas! 🤣
Alex

Right, I think I've managed to successfully update the pull request to keep the JetsonVideoStream class in a separate class.
I've tested it on a couple of examples and it seems to work!
Have a good Christmas!
Cheers,
Alex

Thanks so much for this al3xsh! Although there were some problems, this really helped me along. Initially, jetsonvideostream.py throws multiple errors and doesn't work for me because it uses the nvcamerasrc plugin, which is deprecated in my version L4T. To make it work, I changed it to use nvarguscamerasrc instead and made some other modifications to the pipeline based on this forum thread (https://devtalk.nvidia.com/default/topic/1042892/jetson-agx-xavier/nvarguscamerasrc-opencv-solved-/).
Here's the modified pipeline code:
               			'video/x-raw(memory:NVMM), '
               			'width=(int)1920, height=(int)1080, '
               			'format=(string)NV12, framerate=(fraction)30/1 ! '
               			'nvvidconv ! '
               			'video/x-raw, width=(int){}, height=(int){}, '
               			'format=(string)BGRx ! '
               			'videoconvert ! appsink').format(width, height)

I'd like to push this to your pull request, but I don't know if that's possible so I'll just leave this here in case you want to add it. Thanks!


Currently the SSH Key Pair isn't used by the worker nodes

Just going over this to steal some ideas I noticed that the aws_key_pair isn't actually used in the launch configuration.

Hello @cablespaghetti,
Yes, you are right. I'll remove it now if you want to create a pull request let me know.
Thanks

Unfortunately I've got my own similar project I started last week (not on github). I'm working on spot fleet support at the moment. When I've got it working I'll see if I can send some PRs your way.

Cool, Thank You @cablespaghetti

Fixed


Add CREEDS analysis

Several previous approaches have used transcriptomics for drug mechanism of action deconvolution and drug repositioning. Iorio et al., (2010) and later Emon et al., (2020) suggested using expert-curated pathway databases as a means of dimensionality reduction.
This notebook demonstrates doing this in practice using differential gene expression profiles curated in the CREEDS database based on drug perturbations, gene knockouts, gene overexpressions, and diseases.
Notably, it uses PyBioPAX to acquire and process Reactome as an example pathway database.
Notebook link (will work until this PR is merged and the brach is deleted): https://nbviewer.org/github/indralab/pybiopax/blob/add-creeds-analysis/notebooks/Pathway Anticorrelation Analysis.ipynb
TODO

[x] Find some examples from the top hits
[x] Consider using INDRA-style explanation of some of the chemical-gene relationships

The test is failing because the NetPath website is currently timed out on downloads so I'm going to merge anyway. Hopefully later it won't be an issue anymore, otherwise I will circle back and look into what's going on (e.g., on http://netpath.org/pathways?path_id=NetPath_2 you can try clicking the biopax download button and I think there's an issue on the server)


added drag and drop feature

drag and drop feature of HTML, CSS, and javascript.
resolved issue #76

@atapas please check and merge


Fix dimer alignment

Intro
Although alignment seems to have worked for monomer systems, for dimers there are stochastic errors.
The api to run this is here:
https://github.com/choderalab/covid-moonshot-ml/blob/add-seqres-protein-prep/covid_moonshot_ml/modeling.py#L264
And a script to run this protein prep is here:
https://github.com/choderalab/covid-moonshot-ml/blob/add-seqres-protein-prep/scripts/prep_proteins.py
Related to these issues:

#34
#47

And this PR:

#58

ToDo

[ ] ascertain when/how it is failing
[ ] implement a fix!

Examples:
posit_hybrid_no_relax_keep_water_filter/ALP-POS-ecbed2ba-12_0A/dimer/rcsb_4RSP_B

Here is a list of the alignments where chain B looks like this:

4RSP
5WKJ
5WKK
5WKL
5WKM
7T40
7T41
7TQ7
7TQ8
8CZT
8CZU
8CZV
8DGY

thanks for catching this! I'm looking into it, I'll be working in the bug-60-dimer-alignment branch

I just checked - all of these PDBs only have a single chain anyway, so we just need a way to catch that before trying to run the alignment.

When you're ready do you want to add a PR from that branch to https://github.com/choderalab/covid-moonshot-ml/tree/add-seqres-protein-prep? That way we can add all the protein-prep related stuff at once?


cannot upgrade runtime on chain from 2.0.0 to 2.0.1

we are building zero, a videogame network, based on parity substrate and run a network since ~ august 2020 with around 4m blocks produced – until last week:
when upgrading a network through sudo / setCode, which previously worked like a charm many times, we end up with a broken chain when uploading a new runtime based on substrate 2.0.1 into a chain based on substrate 2.0.0. we are using all by default included pallets.
the first error we get after an upgrade is: FATAL: Unable to initialize the API: -32603: Unknown error occurred: Client, VersionInvalid, Other, \"Instantiation: Export ext_default_child_storage_storage_kill_version_2 not found\
we already checked for additional code rendering the new build defect, but separately, both builds work flawless.
as the newer chainspec contains more details for the contracts pallet, and multiaddress format, it seems there are some changes, which the old runtime cannot chew, but coming from the error, we cannot identify, what the original problem is and could not find any documentation explaining eventually breaking changes included in the 2.0.1 patch version bump.
changing the genesis chainspec renders the following builds incompatible with the old runtime, therefore a chain cannot be upgraded if we change the chainspec.
using the old chainspec, results in the following error message after a successful build and starting the node:
Error: Service(Client(Storage("Error parsing embedded file: missing field limits at line 200 column 5")))
prior to the recent updates, the build never complained about missing data in the spec, therefore the question is, where is this introduced or how can we disable this or is it a breaking change we do not know about?
even though we cannot roll back to a previous state anymore, we would like to understand the problem and a correct migration path.
thanks in advance for any pointers, @NukeManDan
marco

Did you update your nodes before trying the new wasm file with the new host function?

there aren't any new functions, we just wanted to bump the versions to prepare for our orml stuff. therefore we thought, uploading the new wasm would be sufficient. only the changed chainspec which seems to require a more verbose config of the contracts pallet caught our eye.

run old node with old chainspec -> upload new wasm -> FATAL: Unable to initialize the API
run new node with old chainspec -> Error parsing embedded file
run new node with new chainspec -> node works, but breaks chainstate

isolated, both worked fine, to verify, i have built another vanilla node from substrate using the original chainspec which leads to above mentioned second error. therefore the confusion.
maybe i am missing something :) thanks!

There are new host functions, that is the reason I mentioned this. You need to upgrade your old nodes before to provide this new host function.

* run new node with old chainspec -> Error parsing embedded file

This sounds like you don't use the raw chainspec? If you deploy any network, you need to use the raw chainspec! Otherwise it can break when you change your native runtime!

okay, understood. actually we somehow did not use the raw spec until now. therefore i double checked with a raw version of the original spec with our old chain and your mint 2.0.1 tagged version and it seems to work.
what would be the correct/recommended upgrade path, considering e.g. no added pallets or the same pallets with respective types/state exist in the old and the new version? is it possible at all to migrate between two different chainspecs like this, from the old 2.0.0 based, non raw spec to e.g. 2.0.1 with the raw spec?
as it is a testnet, it is meant to break, therefore i wouldnt mind to reboot the net once more, as the old state is lost anyway, but we need a feasible upgrade path for coming migrations.
thanks a lot for looking into this!

You always keep the same genesis normally and just do runtime upgrades. If there are runtime upgrades that will use a new host function, you will need to update the nodes before applying the runtime upgrade on chain.
Migrating between chainspecs is not really possible, I'm also not 100% sure what you mean by this :D
If this is solved, please close it.

Thanks, this is exactly how I understood it.

Hey @bkchr
We received the same error after applying the forkless upgrade with v3.0.0 to the network with v2.0.1.
Could you add more details about you will need to update the nodes before applying the runtime upgrade on chain?
Thanks.


Bug: Swagger querying Emissions API incorrectly

Test Case
Context
There is bug in the Emissions APIs where the year, month, and quarter parameters explode in swagger. On swagger system is querying month=1&month=2 instead of month=1|2 in the url. This is causing a server error for monthly, quarterly, annual, and ozone endpoints when entering multiple values for those parameters. This issue is only applicable to swagger and it does not impact CAMPD or if users programmatically interact with the API endpoints.
The scope of this ticket does not include the aggregation endpoints.
Steps to Reproduce

Navigate to the emissions swagger page
Make a GET request to the  monthly, quarterly, annual, and ozone endpoints with multiple values for the month, year, and quarter parameters
Swagger returns a 500 error

Monthly (Month & Year)
Quarterly (Quarter & Year)
Annual (Year)
Ozone endpoints (Year)

Monthly (Month & Year)
Quarterly (Quarter & Year)
Annual (Year)
Ozone endpoints (Year)


Client doesn't close connection properly

Hi,
I'm trying to exchange data between one server and one client. At the first connection, it works well but after few seconds (around 5s, could it be the server time out?), the connection is closed and the client only return error (pipe broken).
Using wireshark, I can see this communication : server  => FIN + ACK, client => ACK, server => RST. Is it normal that the client doesn't send FIN message? Is this why I get this error after?

The client keeps the connection open in case you will do another request. This is for optimisation purposes, since opening another socket for a second request is more expensive than doing another request on the same socket. On the other hand, if you would like to close the connection, you should use the Connection: close header field when performing a request.

In client_http.hpp, I don't see any Connection: close, may it be ClientBase::stop ?
Is there an option on Server to don't let it close the connection?

To close a connection after a request, you can either do:
HttpClient client("localhost:8080");
auto r = client.request("GET", "/match/123", "", {{"Connection", "close"}}); // Server will close the connection
cout << r->content.string() << endl;

or:
HttpClient client("localhost:8080");
auto r = client.request("GET", "/match/123");
cout << r->content.string() << endl;
client.stop(); // Client closes the connection

or combining them might be the most clean approach:
HttpClient client("localhost:8080");
auto r = client.request("GET", "/match/123", "", {{"Connection", "close"}});
cout << r->content.string() << endl;
client.stop();

Ok. I used the second option. I think this issue can be closed. Thank you.


fix: crash on macOS

What kind of change does this PR introduce?

Fix: crash on macOS

Detail
When cargo run on macOS, the neovide crashed with crash log:
'called `Option::unwrap()` on a `None` value'. (File: src/renderer/renderer.rs; Line: 109, Column: 18)

It is mainly because call DX12 on all platform.
After change to conditional choose GPU, macOS require get METAL in UI thread
KNOWN ISSUE: the window is transparent in macOS, only the titlebar is presented

Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.

No

Those logs reveal one possible reason why the window is transparent. I'll dig into it.
ERROR [wgpu_core::present] No work has been submitted for this frame
ERROR [wgpu_core::present] No work has been submitted for this frame
ERROR [wgpu_core::present] No work has been submitted for this frame
ERROR [wgpu_core::present] No work has been submitted for this frame
ERROR [wgpu_core::present] No work has been submitted for this frame

I think the render process need to be restructured.
currently,
renderer/mod -> renderer.render (inside renderer.render, function, the code submits the render_pass to queue,
which is contract to renderer.render's callback, the callback want the render_pass data back to renderer/mod
to passed to window.draw function. I guess submit to queue should placed in window.draw function?

I think the main reason of the empty window body could be reuse of render_pass. Maybe instead of reuse one MainRenderPass, we can create one pass for each part of the view, saying background_render_pass, foreground_render_pass, cursor_render_pass, etc.


Avoid modifying the default dtype on exception

What does this PR do?
Since torch.set_default_dtype modifies the global state, we need to make sure that the default dtype is restored if an exception happens while we are modifying it.
An example where this is a problem is tests, if one test fails, the default dtype will be different for others, possibly creating a chain of failures
cc @carmocca @justusschock @awaelchli

@awaelchli Do you want a test for each class for both trainer and fabric?

That's a possibility yes. Or a parameterized test for the class in a test_all.py file in the plugins folder if the assertion is the same for all.

Done


Notion links that open in browser rather than Notion desktop app

This is a very minor, nonurgent but hopefully easy-to-implement request: I’d like the attachments added to synced items in Zotero to open Notion in the browser, rather than be local links to the Notion desktop app.
It should be as simple as removing the “notion://“ part of the current hyperlinks. For those who have a workspace name assigned, you would also need to add “{workspace_name}/“ after notion.so/.
So for example, this link would be changed from:
notion://www.notion.so/Wood-et-al-2019-b26e3927eee74a3583134ebed285efa1
to
https://www.notion.so/{workspace_name}/Wood-et-al-2019-b26e3927eee74a3583134ebed285efa1.
Again consider it a low-priority but low-effort request. I would do it myself if building my own notero version had worked!
(and an obligatory ‘thank you’ to the excellent work you’ve done here dvanoni)

@louaymd, thanks for the feedback! I'm going to mark this as a duplicate of #53. Though, I like the title you used, so I'm going to copy that over to the other issue. Please follow along there!


Add a design note describing the 'weak reference' proposal for managing 'circular reference' instances.

Describe the bug
We need a design note describing the 'weak reference' solution for managing 'circular reference' instances.  The implementation and additional details are provided by this PR.
OS information
No response
Steps taken to reproduce bug
N/A
Expected behavior
N/A
Actual outcome
N/A
Additional details
No response

Not required due to a subsequent design change.


Support Common Parameters

Hi,
I'm using an OpenAPI 3.0.0 specification with common parameters for all methods of a path.
Example:
paths:
  /user/{id}:
    parameters:
      - in: path
        name: id
        schema:
          type: integer
        required: true
        description: The user ID
    get:
      summary: Gets a user by ID
      ...
    patch:
      summary: Updates an existing user with the specified ID
      ...
    delete:
      summary: Deletes the user with the specified ID

With this specification I observed following error:
Newtonsoft.Json.JsonSerializationException: Unexpected initial token 'String' when populating object. Expected JSON object or array. Path ..
Thank you in advance for looking into this!

Can you post some generated code, and where this exception happens?

I would expect that these "global" parameters are taken into account in the generated client...

Sorry, you are right, this works perfect!


Java 7 is required, but discontinued by Oracle

The projects README still mentions Java 7 as a requirement, but it's discontinued. Please consider to add a description how to work with Java 8.

Both my computers are already on Java 1.8, I'll update the docs and look into any limitations with sun setting 1.7. In my knowledge, openJDK 1.8 is still busted.


ipa processing failed ad hoc

Environment
MacBook M1
Steps to Reproduce

Run xcode archive, select Ad Hoc.
ipa processing failed

Log
2021-02-05 03:21:07 +0000  Scanning IPA...
2021-02-05 03:21:07 +0000  Assertion failed: Expected 4 archs in otool output:
/var/folders/jk/87_370js6z9bld46ppj5q6380000gn/T/IDEDistributionOptionThinning.~~~7OiIsl/Payload/Runner.app/Frameworks/libswiftAVFoundation.dylib:
Mach header
      magic  cputype cpusubtype  caps    filetype ncmds sizeofcmds      flags
MH_MAGIC_64    ARM64        ALL  0x00       DYLIB    36       3952   NOUNDEFS DYLDLINK TWOLEVEL NO_REEXPORTED_DYLIBS APP_EXTENSION_SAFE
Load command 0

Hi @Adrift001
I see there's an open issue addressing the case you described. https://github.com/flutter/flutter/issues/72622
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Aggregate wifi scan entries

I will look into the failed checks soon, but not there yet

Is it possible that we don’t touch the functions in the optimizer in this PR? Could we let still those functions use wifiScanEntry? The following are my concerns:

We might consider to use both latest wifiscanentry and aggregated wifiscanentry later on. Let’s get the aggregated one ready in this PR, and then work on the design choice later. (Also, once the aggregation is done, we don’t need unixTimeMs anymore. Therefore, we can always fall back to use the parent class. Just FYI.)
Unless we could guarantee all these changes working very well in real setups, let’s separate it out so it is easier for us to debug.

Please let me know if you have any other concerns. Thanks. Cc @elludraon @paulvarkey

Thanks for improving the PR and refactoring many places in the existing code. :) Is it possible that we don’t touch the functions in the optimizer in this PR? Could we let those functions still use wifiScanEntry? The following are my concerns:

We might consider to use both latest wifiscanentry and aggregated wifiscanentry later on. Let’s get the aggregated one ready in this PR, and then work on the design choice later. (Also, once the aggregation is done, we don’t need unixTimeMs anymore. Therefore, we can always fall back to use the parent class. Just FYI.)
Unless we could guarantee all these changes working very well in real setups, let’s separate it out so it is easier for us to debug.

Please let me know if you have any other concerns. Thanks. Cc @elludraon @paulvarkey

I agree about splitting the PR into multiple, I can do that. @elludraon what are your thoughts about using the old class vs the new class?

Thanks for improving the PR and refactoring many places in the existing code. :) Is it possible that we don’t touch the functions in the optimizer in this PR? Could we let those functions still use wifiScanEntry? The following are my concerns:

We might consider to use both latest wifiscanentry and aggregated wifiscanentry later on. Let’s get the aggregated one ready in this PR, and then work on the design choice later. (Also, once the aggregation is done, we don’t need unixTimeMs anymore. Therefore, we can always fall back to use the parent class. Just FYI.)
Unless we could guarantee all these changes working very well in real setups, let’s separate it out so it is easier for us to debug.

Please let me know if you have any other concerns. Thanks. Cc @elludraon @paulvarkey

I agree about splitting the PR into multiple, I can do that. @elludraon what are your thoughts about using the old class vs the new class?

I think maybe I could split it into 5 PRs (maybe the last two could be combined):

combining literals and duplicate variables into constants
documentation (code comments)
creating those util methods to more easily generate ht_oper and vht_oper and the corresponding tests
stuff relating to creating ProcessedWifiScanEntry
implement the aggregating method and the corresponding tests

Thoughts? @elludraon @paulvarkey

Thanks for improving the PR and refactoring many places in the existing code. :) Is it possible that we don’t touch the functions in the optimizer in this PR? Could we let those functions still use wifiScanEntry? The following are my concerns:

We might consider to use both latest wifiscanentry and aggregated wifiscanentry later on. Let’s get the aggregated one ready in this PR, and then work on the design choice later. (Also, once the aggregation is done, we don’t need unixTimeMs anymore. Therefore, we can always fall back to use the parent class. Just FYI.)
Unless we could guarantee all these changes working very well in real setups, let’s separate it out so it is easier for us to debug.

Please let me know if you have any other concerns. Thanks. Cc @elludraon @paulvarkey

I agree about splitting the PR into multiple, I can do that. @elludraon what are your thoughts about using the old class vs the new class?

I think maybe I could split it into 5 PRs (maybe the last two could be combined):

combining literals and duplicate variables into constants
documentation (code comments)
creating those util methods to more easily generate ht_oper and vht_oper and the corresponding tests
stuff relating to creating ProcessedWifiScanEntry
implement the aggregating method and the corresponding tests

Thoughts? @elludraon @paulvarkey

The list looks good. I think the first two can be one as they are related to code refactoring. The following three can be another one as they are more related to the wifiscan aggregation.
If you think using the new class makes more sense to you, you could just rename the parent class to something else (e.g., rawWifiScanEntry) and then let the child class use wifiScanEntry so you don’t touch the interface between Optimizer and Modeler (and you don’t modify too many files all at once). Thanks.

Thanks for improving the PR and refactoring many places in the existing code. :) Is it possible that we don’t touch the functions in the optimizer in this PR? Could we let those functions still use wifiScanEntry? The following are my concerns:

We might consider to use both latest wifiscanentry and aggregated wifiscanentry later on. Let’s get the aggregated one ready in this PR, and then work on the design choice later. (Also, once the aggregation is done, we don’t need unixTimeMs anymore. Therefore, we can always fall back to use the parent class. Just FYI.)
Unless we could guarantee all these changes working very well in real setups, let’s separate it out so it is easier for us to debug.

Please let me know if you have any other concerns. Thanks. Cc @elludraon @paulvarkey

I agree about splitting the PR into multiple, I can do that. @elludraon what are your thoughts about using the old class vs the new class?

I think maybe I could split it into 5 PRs (maybe the last two could be combined):

combining literals and duplicate variables into constants
documentation (code comments)
creating those util methods to more easily generate ht_oper and vht_oper and the corresponding tests
stuff relating to creating ProcessedWifiScanEntry
implement the aggregating method and the corresponding tests

Thoughts? @elludraon @paulvarkey

The list looks good. I think the first two can be one as they are related to code refactoring. The following three can be another one as they are more related to the wifiscan aggregation.
If you think using the new class makes more sense to you, you could just rename the parent class to something else (e.g., rawWifiScanEntry) and then let the child class use wifiScanEntry so you don’t touch the interface between Optimizer and Modeler (and you don’t modify too many files all at once). Thanks.

Re: doing 2 PRs, that sounds good.
Re: renaming the parent class - we should not do that because the name (and class) is defined by the open wifi team, and Jeffrey also mentioned he wanted to keep that interface clean... We'll wait to see his thoughts on this as well.

Jeffrey mentioned to me (and I agree) that using WifiScanEntry in some places and ProcessedWifiScanEntry in others may be difficult (e.g., it is hard to cast between List and List. As I mentioned in my previous comment, we also don't want to rename the parent class.
Also, as for not needing unixTimeMS after the aggregation - I think it could still be useful, e.g., for some kind of diagnosis or root cause analysis later.
So all in all, I will keep the current structure, unless you have more concerns Po-Han :) (or perhaps I misunderstood you).

Jeffrey mentioned to me (and I agree) that using WifiScanEntry in some places and ProcessedWifiScanEntry in others may be difficult (e.g., it is hard to cast between List and List. As I mentioned in my previous comment, we also don't want to rename the parent class.
Also, as for not needing unixTimeMS after the aggregation - I think it could still be useful, e.g., for some kind of diagnosis or root cause analysis later.
So all in all, I will keep the current structure, unless you have more concerns Po-Han :) (or perhaps I misunderstood you).

No, I believe the structure is defined by the OpenWiFi team but not the name. The class name is flexible (I might be wrong :) ). If everyone agrees with the change, then I am okay with that.

I am closing this PR due to the fact that I am splitting this into two separate PRs. One of those is already merged in, and one of them is coming soon.


Increase logo size and make it clickable everywhere

re this conversation: https://github.com/openfarmcc/OpenFarm/pull/860
Make the logo clickable from everywhere it is displayed. Now, the logo refreshes the home page when clicked from the home page (and still redirects to the home page when clicked from elsewhere). Increase the logo size to 210x41 and add margin: 20px 10px 10px 30px. Increase the top bar height to accomodate the taller logo. Vertically align the other elements in the re-sized top bar so that the bottom of each element lines up with the bottom of the text in the logo.

Coverage remained the same at 99.352% when pulling 3c82abca6425b4e974e400a7005780e736fc3074 on nicholasedwards:master into bbd7b079fd27d2e211a39b21861b7b2b39833895 on openfarmcc:master.

Hey @nicholasedwards, this looks awesome. Thanks a bunch. Could you have a look at the hound errors? They keep the project looking tidy :)

@simonv3 Thanks! I'll clean this up based on the Hound errors and make another pull request.


EXTENDED_ENDSTOP_PHASE_CALIBRATE not working

I found some "syntax" errors in EXTENDED_ENDSTOP_PHASE_CALIBRATE.cfg that I was able to fix but now I'm stuck with math functions like sin not found by klipper, there's something I'm missing?

Currently I ripped out rPi from it and waiting till CB1 and Manta M4P arrive, I will do swap and resume work on this. Not sure if I will support stock HW anymore but I will have a look once it is here.


clarify CONTRIBUTING guide for adding values to README

title

+1

@gsemet unrelated to this PR, I have now made it so that we don't have to release the chart on each commit.
That is, the chart will only be automatically released when we update the version in Chart.yaml.
https://github.com/airflow-helm/charts/commit/6fff4d19164c43df6b398d15c226100f379519eb


State transition names in UI are misleading for VMs (maybe others too)

Describe the bug
In the TRE UI, when I disable a VM, it shows itself as updating. This is misleading, and I consider it a bug.
The activity name displayed when a resource is changing state should accurately reflect the transition it's executing. How hard can that be???

See #123 for the lead on this issue


POC ToC

based on this doc

An interactive version deployed to: https://stampy-ui.ai688.workers.dev/toc
I couldn't be bothered to keep the navigation bar floating on the left, so for now it's just a normal element. Should be ok, seeing as this is just to check if it makes sense?

changed to:


Add NPR Dataset to Python Directory

Code and materials for the generation of a dataset encompassing NPR's All Things Considered Podcast. Also contains code for working with a test episode of the Behind the Tech podcast. Additional files allow for testing the dataset using RAG and comparing against Structured RAG outputs.
The NPR dataset encompasses all podcasts in the All Things Considered Archive after 2011. This includes:

713 Episodes
11125 Sections
223726 Turns

Further details about the dataset are included in the README.md file.
The generate_chunks.py file contains code for generating chunks from this dataset mechanically using dialogue turns as chunks. This directory is self contained and does not modify files anywhere else in the repo.

Data not included.  Just the code for working with the data.


Tests/unit/update

Changed updating pet, and pet's photo. Added update pet unit tests.

Outdated, merged with feature/user&shelter_pets


No direct migration path for whoami::hostname

Is your feature request related to a problem? Please describe.
whoami::hostname is deprecated. The suggested replacement is whoami::fallible::hostname, but this is not functionally identical. In principle the case of hostname shouldn't matter but in practice it means that we can't just directly replace calls to whoami::hostname() to whoami::fallible::hostname().unwrap_or_else(|| "localhost".to_string()) (or just expect/unwrap) without worrying about introducing a regression.
Describe the solution you'd like
Maybe whoami::fallible::hostname_lower() which is functionally identical to the infallible version (aside from returning a Result).
Describe alternatives you've considered
Open-coding a replacement in a local library, which is awkward. Disable warnings/errors for deprecated functions.
Additional context
I'm trying to migrate a large amount of code from 1.4 to 1.5 to work around the security issue.

Thanks for the issue, and PR!
Yeah, that function isn't functionally identical (on purpose).
I'm not sure what the purpose of adding that function to whoami would be.  Converting to lowercase should probably only be done for certain display purposes (and even there I'm not sure), and hostname casing should otherwise be kept.
If possible, can you tell me what you're trying to do with a lowercase-normalized hostname, and why the casing shouldn't be preserved?  Is a bug caused by not making it lowercase?
The reasoning for this change is discussed here: https://github.com/ardaku/whoami/issues/82

I'm doing a mass change of other people's code, I'm not exactly sure what the precise requirements are in each case. It's quite possible that it makes no difference at all, but I'm not in a position to be able to evaluate every callsite. We have had problems in the past from strange failures relating the case-mismatches in hostnames (eg case-sensitive string cmp & mismatch in case between hostname() and a hostname in a config file), so I'd be hesitant about just assuming the case issue can be ignored.
BTW This is to resolve the possible security issue arising from #91.

I'm doing a mass change of other people's code, I'm not exactly sure what the precise requirements are in each case.

Without a requirement, I'm hesitant to add this as a new function to whoami.  It seems like an okay function for consumers of the library to have to write, if they really need it.

We have had problems in the past from strange failures relating the case-mismatches in hostnames (eg case-sensitive string cmp & mismatch in case between hostname() and a hostname in a config file), so I'd be hesitant about just assuming the case issue can be ignored.

To me, this sounds like switching to the new API would have fixed some of those old issues, so I'm questioning the value of the additional API in whoami besides as an intermediate step in addressing tech-debt.

BTW This is to resolve the possible security issue arising from #91. So I really want a very direct migration path without having to worry about any semantic differences.

While that function is deprecated, it's not going away any time soon (whoami 2.0 will likely be released in mid-2025, and 1.0 will still be maintained).  I think it would be okay to #[allow(deprecated)] until that upgrade if you want the quickest migration path (unless you want to avoid the #[allow] handle the Result case).

I've fallen back to scattering a pile of #[allow(deprecated)] around for now.

Closing as not planned


Add robustness to ActiveSnapshot::Config

Added: Improved ActiveSnapshot::Config for better clarity, maintainability, and robustness
Changes include:

Introduced constants for storage methods
Added a custom error class for invalid storage method errors
Refactored predicate methods to reduce code duplication
Enhanced error messages for invalid storage methods

I've reviewed this. The only piece of this PR that I am in favor of is: the use of constants for the storage methods.

Im closing this PR as I am rejecting most of the suggested changes. Please open a new PR if you want to add the constants for the storage methods.

Thx for feedback


Sort service-names in a human readable way

- What I did
Change the way the service-names are displayed in docker stack ls.
- How I did it
Implemented IsLess that defines "xxx--2" as smaller than "xxx--10".
- How to verify it
Run unit-tests and integration-tests:
$ TESTFLAGS='-check.f DockerSwarmSuite.TestStackDeploy*' hack/make.sh test-integration-cli
$ TESTDIRS='cli/command/stack/' TESTFLAGS='-test.run ^TestIsLess*' hack/make.sh test-unit

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "stack_ls_human_readable_way" git@github.com:ripcurld0/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

I think we should have the natural sort as a separate package, so that we can reuse it for other lists as well.
Would it make sense to use, for example https://github.com/skarademir/naturalsort (which is already used by some other docker projects) or https://github.com/fvbommel/util/tree/master/sortorder (noticed that one a while back)
Perhaps we should benchmark these options to decide (although performance is probably not a big issue for these purposes)

@thaJeztah cool!

It looks like sortorder has taken the lead by far.
These are the benchmark tests I ran and the results I got: https://gist.github.com/ripcurld0/c50a56aa7ed6ea733e9660773d3cf486

Grrr! I have no idea why sortorder can't be found... 😢

hm, would it work if you used the github.com URL?

oh, looks like you didn't update https://github.com/docker/docker/blob/master/vendor.conf, and ran vndr to update the vendored file

OMG! Thanks 🍻

Sorry for the delay. I will figure it out on Sunday.
😀 🐸

@thaJeztah I am going to close this as the cli part was moved to docker/cli.
I will open there the PR.
Thanks 😀

Thanks in advance @ripcurld0 :heart:

It looks like sortorder has taken the lead by far.
These are the benchmark tests I ran and the results I got: https://gist.github.com/ripcurld0/c50a56aa7ed6ea733e9660773d3cf486

The slow packages have Less functions that allocate memory. It's not surprising they would be very slow to sort.


Debugging PowerShell scripts yeilds an error in text that no longer exist in the file!

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:34:09.706Z)
OS Version: Windows_NT ia32 10.0.16257
Extensions:

Extension
Author (truncated)
Version

python
don
0.7.0

beautify
Hoo
1.1.1

rest-client
hum
0.15.1

prettify-json
moh
0.0.3

PowerShell
ms-
1.4.1

vscode-nginx
sha
0.3.1

Steps to Reproduce:
1.Open vScode
2. Debug PS Script

Reproduces without extensions: Yes/No
N/A as native PS is not supported for debugging
The issue is that when I attempt debug a file, VScode throws an error, however, it points to code that no longer exists in the file. In addition, thing like bracket highlighting is not working.
TBH, I have to shutdown and restart VScode every few minutes as after debugging I often find something breaks, perhaps the terminal won't scroll or the debugger will crash.

Please file this issue against the PowerShell extension.


bug(Angular YouTube Player): Class constructor YouTubePlayer cannot be invoked without 'new'

I installed the component @angular/youtube-player in a new angular 9 application. When I include the package I get these errors:
youtube-player.js:388 Uncaught TypeError: Class constructor YouTubePlayer cannot be invoked without 'new'
at<EMAIL_ADDRESS>(youtube-player.js:388)
at webpack_require (bootstrap:79)
at Module../src/app/app.module.ts (app.module.ts:1)
at webpack_require (bootstrap:79)
at Module../src/main.ts (main.ts:1)
at webpack_require (bootstrap:79)
at Object.0 (main.ts:12)
at webpack_require (bootstrap:79)
at checkDeferredModules (bootstrap:45)
at Array.webpackJsonpCallback [as push] (bootstrap:32)
This is my package.json
{
"name": "yt-app",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"@angular/animations": "~9.1.9",
"@angular/common": "~9.1.9",
"@angular/compiler": "~9.1.9",
"@angular/core": "~9.1.9",
"@angular/forms": "~9.1.9",
"@angular/platform-browser": "~9.1.9",
"@angular/platform-browser-dynamic": "~9.1.9",
"@angular/router": "~9.1.9",
"@angular/youtube-player": "^10.0.1",
"rxjs": "~6.5.4",
"tslib": "^1.10.0",
"zone.js": "~0.10.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.901.7",
"@angular/cli": "~9.1.7",
"@angular/compiler-cli": "~9.1.9",
"@types/node": "^12.11.1",
"@types/jasmine": "~3.5.0",
"@types/jasminewd2": "~2.0.3",
"codelyzer": "^5.1.2",
"jasmine-core": "~3.5.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~5.0.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage-istanbul-reporter": "~2.1.0",
"karma-jasmine": "~3.0.1",
"karma-jasmine-html-reporter": "^1.4.2",
"protractor": "~7.0.0",
"ts-node": "~8.3.0",
"tslint": "~6.1.0",
"typescript": "~3.8.3"
}
}

Same Problem

Had same issue, as a temporary workaround, I used version:
npm i<EMAIL_ADDRESS>and it worked fine

Here's a working instance with v10: https://stackblitz.com/edit/angular-ivy-abnbxa?file=src%2Findex.html
Can anyone provide a reproduction?

Had same issue, as a temporary workaround, I used version:
npm i<EMAIL_ADDRESS>and it worked fine

What's your current angular cli version?

Hi mahmoudshawkat,
What's you current Angular Cli version?

@mahmoudshawkat What's you current Angular Cli version?

@jelbourn I updated to Angular CLI 10.02 and the player works the first time the angular project starts. Afterward when the page refresh I got a new error.
core.js:4081 ERROR TypeError: YT.Player is not a constructor
at youtube-player.js:511
at ZoneDelegate.invoke (zone-evergreen.js:364)
at Zone.run (zone-evergreen.js:123)
at NgZone.runOutsideAngular (core.js:27076)
at ScanSubscriber.syncPlayerState [as accumulator] (youtube-player.js:511)
at ScanSubscriber._tryNext (scan.js:49)
at ScanSubscriber._next (scan.js:42)
at ScanSubscriber.next (Subscriber.js:49)
at MapSubscriber._next (map.js:35)
at MapSubscriber.next (Subscriber.js:49)
This is the project yt-app.zip

I just got the solution...after updating Angular CLI to the latest version 10.0.2 and installing youtube-player latest version 10.0.1. The component was working first time only, then when refreshing the page I was getting "ERROR TypeError: YT.Player is not a constructor". It looked like a synchronism issue between the iframe API and the youtube-player component when the iframe API Js code has executed the component didn't exist yet.
The solution was removing  from the head section and adding OnInit hook to the main angular component:
ngOnInit(): void {
const tag = document.createElement('script');
tag.src = "https://www.youtube.com/iframe_api";
document.body.appendChild(tag);

}

Had same issue, as a temporary workaround, I used version:
npm i<EMAIL_ADDRESS>and it worked fine

I installed the exactly same version for @angular/google-maps and worked!
Thanks

It looks like this issue mixes two separate problems. i.e. one time about YT.Player not being available, and the YoutubePlayer class not being "new-able". This issue seems to be about the latter here. For the other one please create a separate issue.
Either way, I think this might have been a past issue with the Angular compiler where it didn't emit the proper new keyword. Running the youtube-player now with the latest version of ngcc, I can see the use of the new keyword as expected.
YouTubePlayer.ɵfac = function YouTubePlayer_Factory(t) {
  return new (t || YouTubePlayer)(ɵngcc0.ɵɵdirectiveInject(ɵngcc0.NgZone),
     ɵngcc0.ɵɵdirectiveInject(PLATFORM_ID));
};


SampleGen: Print names of enum fields in PHP using Protobuf 3.7 helper method

PTAL

cc/ @googleapis/samplegen

Recommend adding [Do Not Merge] label (doesn't look like y'all have one) or add [DO NOT MERGE] to the title or... something :)
Having this in a branch is really nice so I can test this locally. Very very very very very much looking forward to this.

Codecov Report

Merging #2622 into master will decrease coverage by 0.19%.
The diff coverage is 63.63%.

@@             Coverage Diff             @@
##             master    #2622     +/-   ##
===========================================
- Coverage     86.77%   86.57%   -0.2%
+ Complexity     5584     5504     -80
===========================================
  Files           466      465      -1
  Lines         22191    21969    -222
  Branches       2426     2413     -13
===========================================
- Hits          19256    19020    -236
- Misses         2079     2094     +15
+ Partials        856      855      -1

Impacted Files
Coverage Δ
Complexity Δ

...api/codegen/transformer/py/PythonSurfaceNamer.java
91.84% <ø> (-0.14%)
76 <0> (-3)

...m/google/api/codegen/transformer/SurfaceNamer.java
72.56% <ø> (-0.88%)
206 <0> (-8)

...gle/api/codegen/transformer/OutputTransformer.java
89.88% <100%> (-0.06%)
51 <0> (-2)

...e/api/codegen/transformer/php/PhpSurfaceNamer.java
88.17% <55.55%> (-2.84%)
47 <3> (-1)

...sformer/csharp/CSharpGapicUnitTestTransformer.java
88.28% <0%> (-4.69%)
17% <0%> (-1%)

...transformer/csharp/CSharpApiMethodTransformer.java
93.02% <0%> (-3.16%)
5% <0%> (-13%)

...m/google/api/codegen/util/CommonRenderingUtil.java
80.55% <0%> (-2.78%)
18% <0%> (-2%)

...n/transformer/ruby/RubyModelTypeNameConverter.java
84.21% <0%> (-2.64%)
17% <0%> (-1%)

...api/codegen/discogapic/DiscoGapicGeneratorApp.java
53.84% <0%> (-1.84%)
6% <0%> (ø)

.../com/google/api/codegen/metacode/InitCodeNode.java
85.77% <0%> (-1.78%)
82% <0%> (-4%)

... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3132f4b...00af259. Read the comment docs.

@hzyi-google Is this unblocked now?

@vchudnov-g Yes!

YAAAASSSSSSSSSS 🎉🎉🎉🎉🎉

Will we need to bump the protobuf requirement in PHP libraries to pick this up?
I'm guessing a regen will carry this over?
I'll try to play with this soon~ish!

I don't know actually... @michaelbausor Do you think we need to bump up protobuf runtime at all?

A regeneration with the latest artman will pick up the changes in the generated protobuf classes. Each library will also need to depend on the latest protobuf - but actually I think that is already done, as the dependency on gax-php has been bumped to 1.0 (here: https://github.com/googleapis/google-cloud-php/blob/master/composer.json#L53) and that requires protobuf 3.7.1 or above.


Creating a Khronos glad fork based off of @Jericho's.

Needed for #97 to work.
The primary glad repository contains not an instance of glad, but code for a glad generator.  In theory I could have integrated the main repository and used CMake to execute the generator to produce the appropriate GL loader, but that would have made the build process significantly more fragile and added a dependency on Python to execute the generator.
Instead I opted to create a fork of glad, and then create branches with the output of the generator needed for the two specific API's, OpenGL and OpenGL ES.
There are a few possible paths...

Leave it as it is
Leave the glad dependencies as submodules, but switch to a fork of Glad owned by KhronosGroup
Switch to embedding the glad dependencies as files under third-party instead of submodules

Unfortunately this would require fixing the CI servers to ignore these files in the linting and copyright headers checks

Switch to the main glad repository and modify the CMake process to call the generator appropriately and create these files at configure or build time.

Originally posted by @jherico in https://github.com/KhronosGroup/Vulkan-Samples/pull/97#issuecomment-613671240

Feel free to ping me (author of glad) if you have questions, need support or changes in glad.

As this feature is only for a single sample it has been suggested that we simply copy the required files into the sample.
@Dav1dde Thanks for such a quick reply! I was wandering if you have had any experience with adding GLAD to an android native application. I've been searching for some detailed examples and cannot find any. My attempts have all ended in the project not compiling.

Should have closed with #97 merge.


[hyprpm] Specify the commit id in the hyprpm update command

Description
I want to do something like :
hyprpm update hyprland-plugins e45066d0741a1a4b9298a4c5ec43a5e57b059a4e
instaid of removing and reinstalling hyprland-plugins with the wanted commit

Or also, in my dreams :
hyprpm update --match-hyprland-version (I don't think it's possible for this one but who knows...)

Thanks in advance

wdym?

I think they want the same thing as the add [rev] command, but for updating a plugin. So 'update to this revision'.
The second thing and the fact they are adding and removing plugins to get a specific rev makes me think they are using a plugin with no commit pins and HEAD is broken on older hyprland versions.
OP, you should bother the plugin author to add commit pins. If you know the commits that work for a particular hyprland version also let them know that too. Or just PR their repo and add pins to their hyprpm.toml ;)

Ok, strange. I did this some time ago and it didn't work, but now, it works, like magic. And there was no commit on the plugin's repo since. Strange...


Unable to initialize program

flatpak run com.github.micahflee.torbrowser-launcher
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.5
https://github.com/micahflee/torbrowser-launcher
Traceback (most recent call last):
  File "/app/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/app/lib/python3.8/site-packages/torbrowser_launcher/__init__.py", line 76, in main
    common = Common(tor_browser_launcher_version)
  File "/app/lib/python3.8/site-packages/torbrowser_launcher/common.py", line 61, in __init__
    self.discover_arch_lang()
  File "/app/lib/python3.8/site-packages/torbrowser_launcher/common.py", line 123, in discover_arch_lang
    locale.setlocale(locale.LC_MESSAGES, "")
  File "/usr/lib/python3.8/locale.py", line 608, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

I don't know if it will work with the flatpak version, but try to run those commands before running the launcher:
export LC_ALL="en_US.UTF-8"
export LC_CTYPE="en_US.UTF-8"
flatpak run com.github.micahflee.torbrowser-launcher

or you can do:
LC_ALL="en_US.UTF-8" LC_CTYPE="en_US.UTF-8" flatpak run com.github.micahflee.torbrowser-launcher


[INJIWEB-965]: Translate Online Sharing

Translate Online Sharing in english in all languages. Some sentences has been paraphrased by i18n translate api. I have personally translated all the paraphrased sentencs & in all the languages & their meaning is exactly the same as it was earlier.


fix(cni-enable): change flag parse position

variable enableCNI will not init because of wrong position of flag.Parse()

Codecov Report

Merging #187 (9c7d97f) into main (af60881) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   63.41%   63.31%   -0.10%
==========================================
  Files          38       38
  Lines        6073     6074       +1
==========================================
- Hits         3851     3846       -5
- Misses       1909     1915       +6
  Partials      313      313

Impacted Files
Coverage Δ

pkg/agent/proxy/route.go
0.00% <0.00%> (ø)

pkg/controller/policy/cache/rule.go
88.48% <0.00%> (-5.76%)
:arrow_down:

pkg/controller/group/group_controller.go
73.33% <0.00%> (-0.56%)
:arrow_down:

plugin/tower/pkg/controller/policy/controller.go
82.31% <0.00%> (+0.49%)
:arrow_up:

pkg/controller/policy/policy_controller.go
75.68% <0.00%> (+0.51%)
:arrow_up:

ed to add some test cases to cover this kind of scen

@KeyongSun This scenario could not be test in UT, cni e2e test will find this problem.

@KeyongSun This scenario could not be test in UT, cni e2e test will find this problem.
Sure, open an issue to track the fix and link to the e2e case.


chore(#965): fix compiler warnings

Description
Short description or comments
Reference
Issues: closes #965
Check-List

[ ] All Acceptance criteria of user story are met
[ ] JUnit tests are written (60% CodeCov)
[ ] Internal Review is maintained
[ ] Documentations external and internal are completed
[ ] Smoketest successful (Manual E2E-Test depending on Change)
[ ] No Branch waste left
[ ] Board is up-to-date
[ ] Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

WARNING] The following options were not recognized by any processor: '[mapstruct.defaultComponentModel]'

Every module that does not use mapstruct shows this warning. We could fix it by removing the option from our root pom.xml and setting it only for modules that use mapstruct. But I would leave it like it is right now. Otherwhise we have to declare plugins for each module.


Force Password Change Status Not Updating

Hi,
I've managed to create a user and get redirected to my password change form after login but I'm having a couple of issues.

When I attempt to reset my password and thus update the user's status to "confirmed", I get a validation error. The request I'm sending has the following payload.

  '_token' => 'hKVIQyW4hEJmd7Q1Bs3QiOyfYv8gDui2wC9L1AdH',
  'email' =><EMAIL_ADDRESS>  'password' => '**********',
  'password_confirmation' => '********',

This fails because the validation rules are looking for "token".
        return [
            'token'    => 'required_without:code',
            'code'     => 'required_without:token',
            'email'    => 'required|email',
            'password' => 'required|confirmed|min:8',
        ];

What is "token" supposed to be? Is that the temporary password that I was emailed?
Just for testing, I removed the "token" and "code" from the validation rules and then continued on to the next issue.

Currently, my user in Cognito has a confirmation status of "FORCE_CHANGE_PASSWORD" which is identified by the constant AwsCognitoClient::FORCE_CHANGE_PASSWORD. The if statement that runs to determine whether password should be updated does not include this constant. See below.

            if (($user['UserStatus'] == AwsCognitoClient::USER_STATUS_CONFIRMED) ||
                ($user['UserStatus'] == AwsCognitoClient::RESET_REQUIRED_PASSWORD)) {
                $response = $client->resetPassword($request[$paramToken], $request[$paramUsername], $request[$passwordNew]);
            } else {
                $response = false;
            }

However, even if I add in a check for AwsCognitoClient::FORCE_CHANGE_PASSWORD, I still get a failed update due to the missing token.
Some guidance would be greatly appreciated. This seems like a great package and I would love to be able to use it.
Thanks,

Hi,
I've managed to create a user and get redirected to my password change form after login but I'm having a couple of issues.

When I attempt to reset my password and thus update the user's status to "confirmed", I get a validation error. The request I'm sending has the following payload.

  '_token' => 'hKVIQyW4hEJmd7Q1Bs3QiOyfYv8gDui2wC9L1AdH',
  'email' =><EMAIL_ADDRESS>  'password' => '**********',
  'password_confirmation' => '********',

This fails because the validation rules are looking for "token".
        return [
            'token'    => 'required_without:code',
            'code'     => 'required_without:token',
            'email'    => 'required|email',
            'password' => 'required|confirmed|min:8',
        ];

What is "token" supposed to be? Is that the temporary password that I was emailed?
Just for testing, I removed the "token" and "code" from the validation rules and then continued on to the next issue.

Currently, my user in Cognito has a confirmation status of "FORCE_CHANGE_PASSWORD" which is identified by the constant AwsCognitoClient::FORCE_CHANGE_PASSWORD. The if statement that runs to determine whether password should be updated does not include this constant. See below.

            if (($user['UserStatus'] == AwsCognitoClient::USER_STATUS_CONFIRMED) ||
                ($user['UserStatus'] == AwsCognitoClient::RESET_REQUIRED_PASSWORD)) {
                $response = $client->resetPassword($request[$paramToken], $request[$paramUsername], $request[$passwordNew]);
            } else {
                $response = false;
            }

However, even if I add in a check for AwsCognitoClient::FORCE_CHANGE_PASSWORD, I still get a failed update due to the missing token.
Some guidance would be greatly appreciated. This seems like a great package and I would love to be able to use it.
Thanks,

Thank you for reaching out. A demo application using the same package is available on https://github.com/ellaisys/demo_cognito_app. This has the forgot password feature implemented. Request you to check this out and us know if the issue is resolved or not. Cheers !!

Issue resolved


Update README.md

Update readme. Add need or importance of portfolio site for developers

Hi my friend @SoulCoder65
I really like the idea of adding this quick section before starting the reading the docs.
PR Approved ✅  🎉


WASM Build on windows

https://github.com/floooh/cimgui-sokol-starterkit#build-and-run-wasmhtml-version-via-emscripten-linux-macos
Regarding the uncertainty of the Windows build, I want to confirm it does work on Windows.
PS C:\Users\phcre\Documents\c\cimgui-sokol-starterkit\build> emcc --version
emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.44 (bec42dac7873903d09d713963e34020c22a8bd2d)

PS C:\Users\phcre\Documents\c\cimgui-sokol-starterkit\build> emcmake cmake -DCMAKE_BUILD_TYPE=MinSizeRel ..
configure: cmake -DCMAKE_BUILD_TYPE=MinSizeRel .. -DCMAKE_TOOLCHAIN_FILE=C:\Users\phcre\Documents\c\emsdk\upstream\emscripten\cmake\Modules\Platform\Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=C:/Users/phcre/Documents/c/emsdk/node/16.20.0_64bit/bin/node.exe -G Ninja
-- Configuring done (1.7s)
-- Generating done (0.0s)
-- Build files have been written to: C:/Users/phcre/Documents/c/cimgui-sokol-starterkit/build
PS C:\Users\phcre\Documents\c\cimgui-sokol-starterkit\build> cmake --build .
[11/11] Linking C executable demo.html
cache:INFO: generating system asset: symbol_lists/a460b8c467a6274ccfd29a4196fa5b9e3f688a91.json... (this will be cached in "C:\Users\phcre\Documents\c\emsdk\upstream\emscripten\cache\symbol_lists\a460b8c467a6274ccfd29a4196fa5b9e3f688a91.json" for subsequent builds)
cache:INFO:  - ok

Thanks! I should have tested this myself in the meantime. I'll just remove that part from the readme.


Total segmentatorv2

Update the Slicer module to use TotalSegmentator v2.x
@rbumm I've accidentally closed your TotalSegmentator v2 pull request and cannot reopen it. So, I've created a new one from the same branch content. Please test.
Remaining tasks:

[x] Update TotalSegmentator to a new version that contains the fix for the redownloading of fast weights
[x] Update TotalSegmentator to a new version that contains a fix for the whole around the heart issue
[ ] Get confirmation from @fedorov that the terminology mapping csv and terminology json are reasonable
[ ] Get confirmation from @rbumm that installation is robust (SimpleITK is not reinstalled)

Get confirmation from @fedorov that the terminology mapping csv and terminology json are reasonable

I started working on this. The mapping will definitely need to be fixed for some terms.

To be able to work on this, I forked the whole project again including the v2 branch.
This was prpobably wrong. What should I have been doing instead ?
Good news is that before the Bump to 2.0.5 TS and lungmask worked both fine, no SimpleITK issues.

No need to fork the project again.
The simplest is to just use the "propose change" option in the code review comment. To suggest small changes.
If you want to propose substantial changes (many places or multiple files) then you can use GitHub's web interface to modify files in this branch. Github will offer to create a branch and create a pull request. Accept those and then you'll have your branch. You can then make any changes in that branch because it is in your own fork. Then I can merge those changes into my branch.

I started working on this. The mapping will definitely need to be fixed for some terms.

Thanks a lot @fedorov!
It is really interesting to see how useful these codes can be. For example, it seems that different people want to use different English names for the same things. By relying on standard codes, we can let everyone to use whatever name they prefer, yet allow computational algorithms to accurately interpret the data, automatically harmonize nomenclature, etc.

I have the current changes so far here: https://docs.google.com/spreadsheets/d/1aeTGUjZJNxw6fd2Mu0L32m8KP2suky5iboQ8M4ocfqM/edit#gid=844414326.
First sheet contains new codes for v2, and those in orange modified by me.
Second sheet contains v1 codes.
Third sheet is automatically generated, and contains only those structures that are new in v2 (just for convenience).
I am almost done, and also reviewed these revisions with @dclunie. I am waiting to clarify one issue and have the final review by David, and once finalized I will submit a PR.

@lassoan note that because (what a weird decision) there is a separate code for cyst in left and right kidney, the CSV now will have 3 new columns to introduce AnatomicRegionModifierSequence, which will have repercussions on the parser and the code propagating those attributes through the data structures.

Everything seems to work well now.
@rbumm please test the installation. If everything goes well then we can merge this.
@fedorov feel free to send a pull request with terminology fixes whenever you are ready.

I have tested the installation, everything works fine. The holes in FAST mode are gone, downloads are only done once and the licensing mechanism works.
Appendicular bones produced a good segmentation resullt but the following messages:
Saving segmentations...
  Saved in 1.37s
Importing segmentation results...

Processing completed in 566.60 seconds

Processing finished.

The initial download for the "total" task in non-fast mode can be very long, maybe a message would be good.
lungmask is working, so the SimpeITK problem is solved.
Excellent work!

@lassoan I see that the terminology you are using includes the structures that are covered by a restrictive license (the below is from https://github.com/wasserth/TotalSegmentator#subtasks. You are not including the model that generates those restrictively licensed items in Slicer, right?

Thanks for the updates @fedorov
We'll support all models, so it would be great if you could add terminology items for all the structures. But the most important are the structures of the "total" task.

I reviewed all of the structures that were on the list.

@rbumm I see that you have changed the TotalSegmentator weights folder to be the scripts folder. This can be an issue, because it means that the weights are re-downloaded for each Slicer release, which may take a really long time and significant cost for some users; and it also takes up gigabytes of space for each Slicer release. Was there any specific reason for this? Was this needed for the license setting?

@rbumm I see that you have changed the TotalSegmentator weights folder to be the scripts folder. This can be an issue, because it means that the weights are re-downloaded for each Slicer release, which may take a really long time and significant cost for some users; and it also takes up gigabytes of space for each Slicer release. Was there any specific reason for this? Was this needed for the license setting?

This was just a Test in a moment when the weight download did not seem to work and was repetitive. Any other solution is welcome.

It would be nice to be able to display the terminology upon checkbox action but this is probably too much.

Just see that the name of the segment is displayed under "Data probe" which is already a good solution.

I've tested this branch with latest Slicer Preview Release and fixed all the issues that I've found. I've now merged this branch into the main branch and updated the Slicer Extensions Index so that Slicer-5.4 still uses TotalSegmentator v1, while latest Slicer-5.5 will use TotalSegmentator v2. This was needed because Python packages in Slicer-5.5 were too new to be compatible with TotalSegmentator v1 dependencies.


Create EKS Anywhere documentation

Create EKS Anywhere Curated Packages documentation

[x] Tasks: Create cluster install
[x] Tasks: CLI install
[x] Tasks: kubectl
[ ] Package spec
[ ] PackageController spec
[ ] PackageBundle spec
[ ] PackageBundleController spec

Not covered! https://anywhere.eks.amazonaws.com/docs/reference/clusterspec/

Ivy finished the last item


Add a pyright test suite

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
With PEP 747: TypeExpr hopefully just around the corner, we will be able to update our type hints related to TypeAdapter, and perhaps in other places as well.
While we currently have mypy tests running, we use pyright as a type checker. It would thus be great to add tests to assert that our type hints behave as expected. We should get inspired by how tests are setup in typeshed, namely using assert_type.
Tasks:

Add type checking tests. We should run pyright and mypy on it.
Move the existing mypy tests that don't relate to the plugin.
Document that we support mypy and pyright as type checkers. It might be that some features we use are unsupported by mypy, we do our best on that end.
Drop some old mypy versions in the test suite.
Maybe rework the test logic?

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

@Viicos,
We have a few - https://github.com/pydantic/pydantic/tree/main/tests/pyright

Ah nice! Will continue working on this then


Plugin sets modifiable for buffer which plugin is attached to

When function tags.flush_to_bufs() is executed, it sets my current file buffer state to false.
I guess the intended purpose was to specific some target buffer, but on my environment it does that to whatever structure is attached to.
How to reproduce:

open file
toggle structure
 on anything
<\-p> to exit
switch to file
voila, modifiable set to false

When function tags.flush_to_bufs() is executed, it sets my current file buffer state to false.
I guess the intended purpose was to specific some target buffer, but on my environment it does that to whatever structure is attached to.
How to reproduce:

open file
toggle structure
on anything
<-p> to exit
switch to file
voila, modifiable set to false
Fixed it.

Just checked, change broke preview functionality.

Just checked, change broke preview functionality.

I checked that the preview is available, I just turned off the modifiable option of the preview buffer

Noticed It did happen only once for now. I'll keep an eye on this and try to get fully reproducible example.


python 3.12 versioner incompatible

Is this project deprecated?
With python 3.12, there is an issue with configparser in versioneer.py.

Looks like there is a pull request to fix this, but it has not been applied yet: https://github.com/quantopian/empyrical/pull/137

Plus one on this. This issue blocks people from being able to use the package easily and effectively.

Hey, it seems like Quantopian is no longer maintained so I decided to bundle empyrical with one of my libraries to keep it working. See more here: https://github.com/santoshlite/EigenLedger/discussions/128

FYI this issue is fixed in https://github.com/stefan-jansen/empyrical-reloaded

ah interesting


Advertise that we may write icon pixmal/title/tooltip

Basically a compliant DBus client would assume these never change, fix that.
Fixes #3

Replaced by #8


provide programmatic access to status code if client connection fails

Currently, if client.connect() fails, there doesn't seem to be a programmatic way to get the HTTP status code when applicable.  For example, in the case of a 404, the following traceback occurs. The status code occurs in the error text but not otherwise:
Traceback (most recent call last):
  ...
  File "/.../lib/python3.6/site-packages/websockets/py35/client.py", line 12, in __aenter__
    self.websocket = await self
  File "/.../lib/python3.6/site-packages/websockets/py35/client.py", line 19, in __await__
    return (yield from self.client)
  File "/.../lib/python3.6/site-packages/websockets/client.py", line 165, in connect
    extra_headers=extra_headers)
  File "/.../lib/python3.6/site-packages/websockets/client.py", line 83, in handshake
    raise InvalidHandshake("Bad status code: {}".format(status_code))
websockets.exceptions.InvalidHandshake: Bad status code: 404

The relevant line of code is here.
One possible solution would be to define an HttpError exception class that has a status_code attribute. This would be similar to urllib.error's HTTPError class.

Yes, that part of the API isn't convenient. Your proposal works for me.

I posted PR #209 for this.


Check for and warn on uncommitted git changes when running an igniter task.

We want to protect users from getting into bad states, so we should warn them about uncommitted changes.

I was thinking of doing this task?
What if I ran git status -s --porcelain and if that returns any output then we can show a warning? Obviously I will check if the folder is a valid git repo before running this command.
Does this approach work?

That sounds like a good approach to me 👍

We will want to be defensive, and check for access to the git executable as well. If it is not a git repository, or the git executable could not be found, we should warn that we were unable to check project status and require confirmation, I think. If there are changes, we should stop and tell them that there are uncommitted changes, and require that they confirm before continuing.

makes sense

Completed in 84e20aa3331269c0cd9b076c7166d3dda939c802