Allow fully independent debugging

Can a feature be added that allows a participant to use the debugger and it not effect the productivity of other participants?
When working in vscode with live share...
We find it very kool that we can share the debugger between participants...
Because we work using TDD if a participant is using the debugger and a breakpoint is hit ...
all participants are directed to the breakpoint.
If possible we would like other participants to be able to carry on coding while the debugger is being used by one participant

Adding @lostintangent.

This is really great feedback! In the meantime, guests are actually able to detach from a debug session. So if the host wants to debug, but a guest doesn’t, then that situation would be currently supported. However, the host is always put into debug mode as soon as any guest wants to debug, so we don’t fully support an isolated debugging experience. We’ll use this issue to track this discussion.

In current state, if a participant doesn’t want the debugging, they just unfollow the host?

I'm going to close this for now since we haven't heard significant customer feedback for this. If this is something that folks would like to see us prioritize, please let us know by re-opening/commenting on this bug. Thanks!


tinycbor is failing in nightly CI

In nightly ci having some issue with tinycbor:
https://app.shippable.com/github/zephyrproject-rtos/ci-test/runs/2844/8/tests

Attempted fix:
https://github.com/zephyrproject-rtos/ci-test/pull/14

This is not fixed zephyrproject-rtos/ci-test#15


Convexity Done

@xiaotinghe  我只是粗略地看了一下，数学表述（特别是术语）可能还得仔细review一下

Can we remove the following if they are unnecessary:

Job d2l-zh/PR-688/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/5 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/6 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/7 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/8 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/9 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/10 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

Job d2l-zh/PR-688/13 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-688/

@xiaotinghe could you take a look? Thanks!


[BUG] Does not seem to be working anymore :(

I installed the extension from the chrome webstore and it does not seem to be playing the notification sound as it used to before. I have tried to reinstall and disable all the other ChatGPT extensions that I have.

Did you get to see this @Correia-jpv

Did you get to see this @Correia-jpv

Yes, it is fixed in the newest version that is already published to the chrome store


[Feature:Translator] OpenAI translator

Appreciated your work!
Is it possible to add an OpenAI API to the translator?
Thank you.

Thanks for your feedback!
I'll reaserch this api


chore(master): release 0.9.0

:robot: I have created a release beep boop
0.9.0 (2024-01-01)
Features

updating from newer svd2rust (#79) (41b162d)

Bug Fixes

moving to 2021 edition (23cda19)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/xmc-rs/xmc4200/releases/tag/v0.9.0 :sunflower:


Update Gemfile.lock to eliminate known vulnerabilities

Coverage remained the same at 100.0% when pulling e4ee2f975432042c171c21d0e5b7a43be30ffeb1 on update-gemfile-lock into f34e5699f5b19eddcc1052ecc022227ddbe1a36a on master.


Running knife produces NoMethodError

Description
This is relatively minor, but when you run knife without any arguments, you get an error at the bottom of the help message.
When you run knife --help, you do not see the error.
My use case was that I wanted see what was available, and typed knife instead of knife --help.
$ knife
ERROR: You need to pass a sub-command (e.g., knife SUB-COMMAND)

Usage: knife sub-command (options)
    -s, --server-url URL             Chef Server URL
        --chef-zero-host HOST        Host to start chef-zero on
        --chef-zero-port PORT        Port (or port range) to start chef-zero on.  Port ranges like 1000,1010 or 8889-9999 will try all given ports until one works.
    -k, --key KEY                    API Client Key
        --[no-]color                 Use colored output, defaults to enabled
    -c, --config CONFIG              The configuration file to use
        --config-option OPTION=VALUE Override a single configuration option
        --defaults                   Accept default values for all questions
    -d, --disable-editing            Do not open EDITOR, just accept the data as is
    -e, --editor EDITOR              Set the editor to use for interactive commands
    -E, --environment ENVIRONMENT    Set the Chef environment (except for in searches, where this will be flagrantly ignored)
        --[no-]fips                  Enable fips mode
    -F, --format FORMAT              Which format to use for output
        --[no-]listen                Whether a local mode (-z) server binds to a port
    -z, --local-mode                 Point knife commands at local repository instead of server
    -u, --user USER                  API Client Username
        --print-after                Show the data after a destructive operation
    -V, --verbose                    More verbose output. Use twice for max verbosity
    -v, --version                    Show chef version
    -y, --yes                        Say yes to all prompts for confirmation
    -h, --help                       Show this message

/opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/lib/chef/application/knife.rb:212:in `print_help_and_exit': private method `list_commands' called for Chef::Knife:Class (NoMethodError)
	from /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/lib/chef/application/knife.rb:176:in `validate_and_parse_options'
	from /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/lib/chef/application/knife.rb:154:in `run'
	from /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/bin/knife:25:in `<top (required)>'
	from /usr/bin/knife:57:in `load'
	from /usr/bin/knife:57:in `<main>'

ChefDK Version
$ chef --version
Chef Development Kit Version: 0.18.26
chef-client version: 12.14.89
delivery version: master (d86679335580be3de22996ef294b20d525889d8d)
berks version: 5.1.0
kitchen version: 1.13.0

Platform Version
Ubuntu 14.04
Replication Case
Run knife.
Stacktrace
/opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/lib/chef/application/knife.rb:212:in `print_help_and_exit': private method `list_commands' called for Chef::Knife:Class (NoMethodError)
	from /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/lib/chef/application/knife.rb:176:in `validate_and_parse_options'
	from /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/lib/chef/application/knife.rb:154:in `run'
	from /opt/chefdk/embedded/lib/ruby/gems/2.3.0/gems/chef-12.14.89/bin/knife:25:in `<top (required)>'
	from /usr/bin/knife:57:in `load'
	from /usr/bin/knife:57:in `<main>'

dup of https://github.com/chef/chef/pull/5386 and already fixed in master and will be released in the next chef-dk release


Don't trace anything if the backend is not available.

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[x] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Don't trace anything if the backend is not available.

Do you check the code style? Please check the CI logs.

Do you check the code style? Please check the CI logs.

so sorry, not code style, some test will force check segment size when OAP backend not start. i will fix it.

I don't remember there is segment size test.

I don't remember there is segment size test.

like this,
org.apache.skywalking.apm.agent.core.remote.TraceSegmentServiceClientTest#testSendTraceSegmentWithoutException
    public void testSendTraceSegmentWithoutException() throws InvalidProtocolBufferException {
        grpcServerRule.getServiceRegistry().addService(serviceImplBase);

        AbstractSpan firstEntrySpan = ContextManager.createEntrySpan("/testFirstEntry", null);
        firstEntrySpan.setComponent(ComponentsDefine.TOMCAT);
        Tags.HTTP.METHOD.set(firstEntrySpan, "GET");
        Tags.URL.set(firstEntrySpan, "<IP_ADDRESS>:8080");
        SpanLayer.asHttp(firstEntrySpan);
        ContextManager.stopSpan();

        serviceClient.consume(storage.getTraceSegments());

        assertThat(upstreamSegments.size(), is(1));
        SegmentObject traceSegmentObject = upstreamSegments.get(0);
        assertThat(traceSegmentObject.getSpans(0).getRefsCount(), is(0));
        assertThat(traceSegmentObject.getSpansCount(), is(1));

        SpanObject spanObject = traceSegmentObject.getSpans(0);
        assertThat(spanObject.getSpanType(), is(SpanType.Entry));
        assertThat(spanObject.getSpanId(), is(0));
        assertThat(spanObject.getParentSpanId(), is(-1));
    }
``

Keep trace should be OFF, I think. Is there a case open this?

@wu-sheng sorry, origin code is ok, this Config.Agent.KEEP_TRACING means Keep tracing even the backend is not available... sorry.


test_dice

After the prediction code is run, only the output image is obtained. How to use these outputs to obtain the dice coefficient?  Did you calculate the dice coefficient of the prediction set?How do you calculate that?

I run predict.py file with my own configuration arguments, but it outputs error: NameEooor: name 'unet' is not defined. If I write "import unet', it also outputs error:
model = Model(unet, checkpoint_folder=args.results_path, device=args.device)
TypeError: init() missing 2 required positional arguments: 'loss' and 'optimizer'


25 October sources

Hi, it possible to have the 25 october 2023 sources?? I've lost it... Thanx!

Click below and choose whichever commit you're interested in.
https://github.com/OneOfEleven/uv-k5-firmware-custom/commits/main


✨ [Feature] #102: In filter modal creator dropdown should be a card list with image

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I worked on adding support for creator images in the creators select dropdown.
For Consistency, I have changed the other select inputs to @mui/material <Select/> Component.
Added fallback option if avatar URL is not present.

Fixes #102
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

https://user-images.githubusercontent.com/59080942/184501770-b64c336b-4269-43cc-993b-08a124cc077a.mov

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@koustov @atapas, PR is ready for review.

@koustov @atapas, PR is ready for review.

@Sachin-chaurasiya We need to do something about the UI that list all the creators.. It seems to be very lengthy when it opens up. Can we put a scroll and limit the height?

@koustov @atapas, PR is ready for review.

@Sachin-chaurasiya We need to do something about the UI that list all the creators.. It seems to be very lengthy when it opens up. Can we put a scroll and limit the height?

Sure @atapas, I will look into it.

@koustov @atapas, PR is ready for review.

@Sachin-chaurasiya We need to do something about the UI that list all the creators.. It seems to be very lengthy when it opens up. Can we put a scroll and limit the height?

@atapas, I have fixed the height issue.

@Sachin-chaurasiya this is definitely very cool however I see one challenge. As the names are not sorted and there is no filter, it will be very tough to find the intended creator as the list grows. So, can you

convert this control to typeahead or autocomplete
sort the list by user name

@koustov , Can we do that in separate PR, because it will take more time and testing?
The main issue was to show the creator's profile picture and for that, I think PR is good enough.
Please create a ticket and assign it to me I will work on your suggestions.
cc : @atapas.

Ok, I am approving this one. Let's get it thorough and create another one for update.

@atapas , awaiting for your approval.


added rank level conflict check to taxon swap commit

closes #1911

made requested changes and travis appeased

Since this change, I'm unable to commit a swap like this: https://www.inaturalist.org/taxon_changes/39845
(a species swapped into a variety per POWO). Neither taxon has descendants.
I get your error "Output taxon rank level finer than rank level of input taxon Brickellia mosieri". Is that intentional?


hugo mod vendor doesn't work for modules that only import other modules

Sometimes it's useful to create modules that just packages a GitHub repository. For example: I was trying to create a Hugo Module that just packages Splide JS repository:
[module]
[module.hugoVersion]
extended = true
[[module.imports]]
path="github.com/splidejs/splide"
[[module.imports.mounts]]
source = "dist"
target = "assets/splide"

That works fine: the module doesn't have any files, it just imports some files from somewhere else. The problem: when I use this module, and try to vendorize it, Hugo complains that the module doesn't have any mounts. That's bad, because now I can't vendozire the repository that's getting imported through the module...
This isn't super bad, and can be solved somewhat easily: I just have to include some random file in the module and mount it. But it would be nice if we didn't need this hack to get the module vendorized...
I suspect that this either an intended behavior, or it's at least a go issue, but maybe it's possible to solve on Hugo's side... Not sure.

Yea, we should try to to fix this. I guess this is the reason why I created this at some point in time:
https://github.com/bep/empty-hugo-module


incorrect link to core 1 version of

In this note the link to Core 1.x version is incorrect, it point to the 2.1 version
"The ManifestEmbeddedFileProvider is available in ASP.NET Core 2.1 or later. To access files embedded in assemblies in ASP.NET Core 2.0 or earlier, see the ASP.NET Core 1.x version of this topic."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d8787c1-1a02-ae68-aa59-7c0e2e823dde
Version Independent ID: 3e799e5d-a89c-cd03-999f-92ae431f4657
Content: File Providers in ASP.NET Core
Content Source: aspnetcore/fundamentals/file-providers.md
Product: aspnet-core
GitHub Login: @guardrex
Microsoft Alias: riande

Thanks for reporting this @saadis01.
The link is correct in the topic ...

[ASP.NET Core 1.x version of this topic](xref:fundamentals/file-providers?view=aspnetcore-1.1).

... but renders as ...

<a class="xref" href="https://docs.microsoft.com/en-us/aspnet/core/fundamentals/file-providers?view=aspnetcore-2.1" data-linktype="relative-path">ASP.NET Core 1.x version of this topic

@Rick-Anderson @scottaddie Thoughts?

We have an internal bug (1270316) tracking this. query string versions will be supported eventually, but not now. You'd need to use the full URL for versions.

full URL for versions.

Relative is ok?


Bad typings for Observable.create

5 beta 11
The typings for Observable.create simply return Function. Should they instead return Observable with a generic?

Unfortunately can't by Typescript doesn't support reference class type parameters from static methods. It is not complete precise definition but limitation to work with TypeScript's syntax. If there's workable proposal supports better typing that have been missing, it's always welcome.

/cc @david-driscoll as well. AFAIK I don't see neat way to support this, but I could be wrong - adding for visibility.

There isn't a great way to support this until https://github.com/Microsoft/TypeScript/issues/4628 (PR https://github.com/Microsoft/TypeScript/pull/6381) is merged in.

Seems given PR for compiler side support does not have immediate foreseeable milestones yet, I think there's few rooms in codebase to fix this behavior. Instead of handcrafting based on current limitation, rather visit later once have proper compiler support seems more feasible option for me, closing this issue for now and reopen. What do you think? @david-driscoll @OliverJAsh

Seems it works in<EMAIL_ADDRESS>write like below
class Observable<T> {
  static create<T>(): Observable<T>
}

returning Function will broken type check.
So I have to ignore them in my bundle helper (https://github.com/morlay/my-rx-addons) 😢

I changed @reactivex/rxjs/dist/cjs/Observable.d.ts like below:
// add this:
import { Observer } from './Observer';

//...

// change this:
// static create: Function;
// to:
static create: (subscribe: (observer: Observer<T>) => void) => Observable<T>;

Am I doing this right?

It really comes down to a conflict between Observable.create and Subject.create since Subject inherits from Observable.  There may be some wacky work around, that we can do after the build to make it work, so perhaps we should investigate those.  However it would be much better if we had language level support for this 😞.

I'm marking this as upstream related, as this isn't really easy changes with current support of compiler we're using. I'll leave issue opened since problem's still there, but probably won't have immediate support for this at this moment.


Remove type annotations from exception

This removes the expectation on the Thrift IDL parser
that all exceptions have type & message annotations.
These annotations do not really make sense in other
languages so it would make it difficult to parse
thrift IDLs from other languages.
r: @kriskowal @abg

:ok: feedback advisory


On language change, instant still returns previous language values

Context
Our Application currently supports 2 languages, German and English. German is default language.
Users are able to switch language in Profile Settings, this triggers an API call to update the profile which returns the new User data with the current language, we then reset the language using use.
99% of our App uses the pipe method to translate everything, this works perfect.
We have a special case for our dropdown with a list of countries, since we want to sort this list Alphabetically and this depends on the current language.
We have a special component for this dropdown. It's subscribed to the onLangChange event, to know when the language is switched, and updates the country list when triggered. This involves manually translating each country using instant, once the translated list is ready we can sort it Alphabetically using simple localeCompare (This is why we need a Sync method for translations).
When the component is created it updates the list aswell.
app.component.ts
    constructor(private _translate: TranslateService) {
        _translate.setDefaultLang('de');
        _translate.use('de');
    }

country.component.ts
    // Array of Country objects, Country.value is the translate key
    countries: Country[] = [];

    constructor(private _translateService: TranslateService) {
        // Generate country list on start up
        this.updateCountries();

        // Regenerate country list on language change
        this._onLangChange = this._translateService.onLangChange.subscribe((event: LangChangeEvent) => {
            this.updateCountries();
        });
    }

    private updateCountries() {
        // We get all the countries with their translation key
        let allCountries = COUNTRIES;
        // This returns the correct language!
        let lang = this._translateService.currentLang;
        // Translate all countries
        allCountries.forEach(country => {
            country.value = this._translateService.instant(country.value);
        });
        // Sort the new list
        this.countries = allCountries.sort(function (a, b) {
            return a.value.localeCompare(b.value, lang);
        });
    }

users.service.ts (simplified)
    private doGetUserData() {
        // fetch logged in.. user info
        return this._http.get(USER_API_BASE_URL + '/user')
            .map(res => {
                let user = new User(res);
                // set locale
                if (null !== user.locale) {
                    this._translateService.use(user.locale);
                } else {
                    this._translateService.use('de');
                }
                this.setUser(user);
                return user;
            })
            .catch(error => {
                this.logout();
                return ServerUtil.handleOtherError(error);
            });
    }

Current behavior
When the country component is displayed for the first time, it generates the list in the current language and sorted. (Good)
Refreshing the App generates the list in the current language. (Good)
When the user switches to a different language, the list is updated but the translations are the same. (Bad)
Going to a different page, and back to the country list still shows old translations. (Bad)
Expected behavior
When the user switches to a different language, the list is updated with the new translations.
Going to a different page, and back to the country list still shows the new translations.
Environment
ngx-translate version: 9.0.2
Angular version: 5.1.2
I had a look at other issues and it seems that since use works Async, calling instant may not work correctly if the language is not yet loaded. But I think the point of using OnLangChange is to be sure that the langauge files have been loaded, and then I should be able to call instant.
I tried using get just to see if the translation part was working but it isn't.
I even tried to reset the same language again using use and then subscribe to it to execute updateCountries, also didn't work.
Any help would be appreciated. Thank you in advance.

You can try to call _changeDetectorRef.detectChanges() manually to see if it fixes your problem. Like this:
import { ChangeDetectorRef, Component } from '@angular/core';
import { TranslateService, LangChangeEvent } from '@ngx-translate/core';

@Component({
  selector: 'foo',
  templateUrl: 'foo.component.html'
})
export class FooComponent {
  public currentLang: string;

  constructor(private _changeDetectorRef: ChangeDetectorRef, public translate: TranslateService) {
    this.currentLang = translate.currentLang;

    translate.onLangChange.subscribe((event: LangChangeEvent) => {
      this.currentLang = event.lang;
      // TODO This as a workaround.
      this._changeDetectorRef.detectChanges();
    });
  }
}

This helped me working around a similar issue.
On the other hand, it would be helpful if you could provide a working example to reproduce your issue.
You can take the official StackBlitz example as a starting point: https://stackblitz.com/github/ngx-translate/example

I fixed the issue. It was actually related to this line:
let allCountries = COUNTRIES;
My COUNTRIES list was being overwritten by the changes in allCountries, replacing all the Translation Keys with translated strings. So the next time it tried to read the keys, they were not there. Silly mistake.
Fixed via Deep Cloning of the array:
let allCountries = JSON.parse(JSON.stringify(COUNTRIES));


fixed linter warnings due to Json function names

fix(helm): fixed linter warnings due to Json function names:
==> Running linters <==

pkg/chartutil/files.go:214:6:warning: func ToJson should be ToJSON (golint)
pkg/chartutil/files.go:229:6:warning: func FromJson should be FromJSON (golint)

This PR resolves the above warnings.
Signed-off-by: Arash Deshmeh<EMAIL_ADDRESS>

Given that we have been avoiding changing function names in pkg for Helm 2, we cannot accept this PR. However, if you were to make these changes for Helm 3 that'd be much appreciated. Thanks!


Ability to control scenes and effect for LED Strips (H7021)

Is your feature request related to a problem? Please describe.
First Thank you for this integration.   It would be great if we could import scenes and/or effects from the Govee App
Describe the solution you'd like
It would be great if it worked similarly to wled.   In which you can import scenes and effects

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Would love to have this scene options for the H6076


Captcha is not displayed

Hi,
We use a CMS page for our contact form, so that we can use our own custom URL.
On this CMS page in the XML layout I added this:
< reference name="content">
< block type="core/template" name="contactForm" template="contacts/form.phtml">
< action method="setFormAction">/contacts/index/post
< block type="studioforty9_recaptcha/explicit" name="studioforty9.recaptcha.explicit" template="studioforty9/recaptcha/explicit.phtml">
< action method="setAllow">true
</ block>
</ block>
</ reference>
In our custom form.phtml file I added this line at the bottom:
getChildHtml('studioforty9.recaptcha.autorender'); ?>
And off course in the extention settings I enabled the extention and also the contact form.
What am I doing wrong?

Hi,
It looks like your code sample is incomplete, so it's difficult for me to say.
Can you please edit and make sure you prefix ```xml and suffix with ```.
Are you using the most recent version v1.2.0?

Sorry my mistake! Got the problem and it works fine now. Thanks for your work

Great, glad you're up and running.


On translations: The word Open

Hello, the word Open in english can be used on both "Open a file" and "Status: Open" but in Portuguese for example:
"Open a file" > "Abrir um ficheiro"
"Status: Open" > "Estado: Aberto"
Can you split those?

You have now the "open file" translation in master.


Logout issue with response status code 204

This is the behavior I am seeing with v2 SNAPSHOTs:

Request goes to /logout
Logout is handled by an application controller of some kind. Processes stuff
ApplicationLogoutController provided by pac4j webmvc that is also mapped to /logout kicks in and does its job.
Response status code is set to 204. Response cleared.
The application then takes over and attempts to render a logout [htm|jsp] page.
Server errors out, reporting a status code of 204.

This exact sequence/behavior works perfectly fine with the latest 1.9.x.
So issues:

This is a very sneaky error. Took me a good couple of hours to track this down and understand why. Time is money?
An HttpAction that seemingly does ok should not produce a 204?
Something should WARN in the logs?
Does the switch to 204 actually solve a problem?

My solution was to bypass what ApplicationLogoutController does and do it manually. This may be something pac4j webmvc ends up fixing, but as far as I can tell, this is very much a regression that breaks "user space" in an invisible way.

I think the problem is that pac4j is not built to be used in conjunction with another controller for the response of logout (and callback).
pac4j expects that it will be the sole responsible of rendering and answer (in jax-rs-pac4j, I added an option so that, by configuration, the application developer can handle the response himself).
Until the 204, it worked as a side effect of the fact that the response wasn't committed by pac4j.
One solution at the application level (i.e. step 4) would be to set the response status back to 200 before rendering the logout page (and hoping that in the future pac4j doesn't decide to do something else to the response that would prevent it to work, since, I repeat, pac4j expects to be the sole responsible of the response). another could be to simply use logout redirect mechanism to do the redirect but that's not the best I guess.
There is no problem with 204 in itself until we decide that pac4j is not the sole responsible of the response.
I.e., it would mean to go back to @millross proposition where instead of letting pac4j decide how to respond, the developer would provide its own implementation of the response. In that case he could decide to answer 204 or to render a page or ot redirect or to let another controller take over as in your example.
A simpler version of it would be to specify the default response in case there is no redirect, so that one could either do nothing (and let the application take over just after) or one could use the default which is, for now a 204, or could change in the future (who knows).
So issues:

it's not a sneaky error, it is a misinterpretation of the behaviour of pac4j from the application developer, it's too bad,  and the HTTP specification was there pac4j even existed, sorry :)
if there is no content, it should be 204, the question is: should it be pac4j that is responsible of the response? for now it is the case...
WARN what? I think documentation would be preferable to better document what is expected of the user of pac4j on these cases (the same happens with callback and even the security filter on some cases, since it takes care of redirecting on behalf of the application).
you really don't like this issue, right? :P v2.0.0 is meant to break things, what if we stopped focusing on the past and tried to find elegant solution to real problems please?

Could you try the proposed solution at the application level and see if at least it solve your problem while continuing to use pac4j's abstractions? Then we could document this kind of use case and the proper solution to it (see point 3)
And in the long term, we can start thinking how this can also be solved at pac4j level (see point 2).
(point 1 and 4 are just us trolling, let's stop it, no?)

I feel like I may need to repeat myself: I don't really have to try any of the proposed definitions/solutions because my solution was to remove usage of ApplicationLogoutController  that takes advantage of this 204-setting. That turned out to be a much simpler solution than writing abstractions and interfaces, etc for something that takes 2 lines.
If there a need for someone to really use that controller in conjunction with the change applied here, hopefully they will bump into this thread and figure out what to do.

Then we could document this kind of use case and the proper solution to it...

This simply could have been avoided with a WARN entry that says: "XYZ is happening. Change in behavior. Be aware.". Devs are way more inclined to read logs than to google search for docs. You are familiar with the history of RTFM, right? Ever wondered how that acronym came into existence? Ever wonerdered why RTFL (Logs) does not exist? :)

it is a misinterpretation of the behaviour of pac4j from the application developer

This statement is exactly why I dislike this issue. The change resulted in a change in behavior that is sneaky and invisible. Nothing breaks the application, except strange discoveries at runtime. That is definition of sneaky behavior. Even IF this was an actual bug, it really seems the change was made for the sake of making the change to make things "compliant" with the specification.

v2.0.0 is meant to break things,

This is also a strange statement, no offense. I am sure you can jump into a cacti field with arms wide open too. Just because you can do something, doesn't mean you should. Breaking changes should be avoided AT ALL COSTS where/when possible or they are just going to leave a poor taste. Change for the sake of change is bogus specially if the everyone relies on the "buggy" behavior and is perfectly fine with. That line of thinking will just make upgrades more difficult and will deter people from using the library. So stop that.
I don't mind breaking changes, IF they do serve a purpose and solve a real problem...and as long as the changes are LOUD and explicit such that they produce warnings/errors in the logs or break the application upfront and prevent it from building. This change did none of those. It simply resulted into wasted time tracking it down and fixing it to be more compliant with the spec supposedly where in practice, it provided zero pragmatic benefit. There is no evidence I have read that says the change fixes a problem, removes pain and provide benefits other than: hey it looks better this way 'cause this document says so.

point 1 and 4 are just us trolling

I am only trying to have a rational conversation about our approach to development...and I reserve any and all rights to loudly complain about breaking behavioral changes [and less about API changes] that waste dev time.

I feel like I may need to repeat myself: I don't really have to try any of the proposed definitions/solutions because my solution was to remove usage of ApplicationLogoutController that takes advantage of this 204-setting.

I was just asking for your help finding a clean solution that did not involve removing pac4j code...

(and the change was motivated, it wasn't compliant with the HTTP specification)

@mmoayyed let's be cool, tomorrow it's black Friday ;-)
I understand your concerns and frustration in wasting time for such a change. I'm in line: we should not change things just to change things.
But the idea here was fairly simple: it's better to return a 204 (instead of 200) when the logout returns no content (which is one of our use case), so we made this change in 2.0.0 (because it's still a runtime breaking change, the response status code changes) and even I don't think it was a priority, I was really confident it would not cause trouble.
The ApplicationLogoutController is meant to be used alone but we should be able to wrap it in another controller. I'm surprised by the problem caused by the 204 status code, it feels really strange that the server fails on that. I'd like to have some details on this.
I still think it was a good idea to change the 200 into a 204, but the reality has proven it may cause issues and as it's not a very important / really required change, I'm in favour of reverting it.

No disagreement for reverting it as we weren't previously deluged with requests to make it 204 anyway. However, I think it's important that we should understand (maybe with a very small piece of sample code) why it changed. If we're wrapping in a way which should return content, then in that case a 204 is incorrect and our "Pac4j will either redirect or return an empty response" approach is not the right one. The bottom line is that it should be possible to switch off the "empty response" behaviour if that is not what is desired (which it seems to me is this scenario) rather than using a 200 for an empty response. In short, the desire to return content which is step 5 above is inconsistent with what the DefaultApplicationLogic does, as specified at http://www.pac4j.org/docs/how-to-implement-pac4j-for-a-new-framework.html#c-application-logout  which says:

after logout, the user is redirected to the url defined by the url request parameter if it matches the logoutUrlPattern

or the user is redirected to the defaultUrl if it is defined

otherwise, a blank page is displayed.

I think (3) should be "delegates to the application to determine what to display".

Good idea!
Actually, the way the logics are written, they already give the wrapper the possibility to override what happens, this is the role of the HttpActionAdapter passed to the perform method! This is what I use in jax-rs-pac4j to give the user the possibility to let the jax-rs framework take care of the request.
But I needed to make the wrapper responsible of this, which isn't the case currently with most of the wrappers, and the HttpActionAdapter is not exploitable by users for now.

By the way, this situation also exists for the callback logic IMHO. If we start changing the line where pac4j stops taking responsibility and leave the application take care of things, then it should be coherent for all the logics I guess…

Callback is slightly different as you can define the 401/3 response body. And in any login process involving a callback you either get redirected to the page you requested (following profile population) or a forbidden/unauthorized response. However there is no “Http Action” status code corresponding to “Logged out”. I wouldn’t see a need to change callback. However, if a 200/with body response is an outcome then if Pac4j wants to own the response, it has to accommodate this outcome.

On 24 Nov 2016, at 10:11, Victor Noël<EMAIL_ADDRESS>wrote:
By the way, this situation also exists for the callback logic IMHO. If we start changing the line where pac4j stops taking responsibility and leave the application take care of things, then it should be coherent for all the logics I guess…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/pac4j/pac4j/issues/755#issuecomment-262738838, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQfzgHVCR9UoesNiSztD96EpFjKyX9Gks5rBWLagaJpZM4K607H.

Also uncomfortable with saying "let's intercept 204 responses in the HttpActionAdapter and do something else" - that's not intuitive for someone reading the code as it doesn't tell that person that this is how to exert control over logout behaviour. Plus what happens if we identify another scenario where 204 is correct that isn't logout-related? Then you're also rewriting that response too. Of course we could implement a special subclass of HttpAction called "LogoutFallbackHttpAction" (to be thrown where we currently spit out a 204) which could be specifically intercepted in that adapter if required. That would make the intent clear.

Callback is slightly different as you can define the 401/3 response body. And in any login process involving a callback you either get redirected to the page you requested (following profile population) or a forbidden/unauthorized response.

Yep it's true, it's not the same!

Also uncomfortable with saying "let's intercept 204 responses in the HttpActionAdapter and do something else" - that's not intuitive for someone reading the code as it doesn't tell that person that this is how to exert control over logout behaviour.

Agree, I was just stating what already existed :)
Personally I really don't like this HttpAction thing, I don't get why we use these half-values / half-exceptions that on top of giving information also modify the http response implicitly, it's really problematic!
It would be better to have the logics return in a way or another their response, and then the wrapper would decide what to do with them. Or the logic could simply modify the response and return nothing.
But doing both is kind of strange, even more because we are not always sure in which form this information arrives (exception or return value).

For sure, I'd like to know more about the error Misagh encountered because it feels really strange.
As I said in another issue, we must careful in extending things. It's like premature optimization, you should not make components customizable if it doesn't make any sense.
I think the logics are the pillars of the pac4j model. I don't think they should be easily changed (subclassing is more than enough for me). Most other components are already extensible. Seeing questions and inquiries in the mailing list, my feeling is that we have open pac4j enough (the ProfileDefinition is for me one of the latest changes for that).
Apart from the 204 vs 200 debate, I haven't seen any inquiry about being able to override our logout mechanism. I've seen inquiries to handle central logout, but that's all and we'll work on that.
I tend to say that if you want to customize our logout, you just need to create your own controller, instantiate a ProfileManager and call the logout method and do your own logic.
I'm reluctant to the proposed change.
About the HttpAction thing, it may feel strange but it perfectly matches the way pac4j is designed.
Spring Security or Shiro have concepts: filters, tokens, providers... and authentication mechanisms are built on them.
To make pac4j easy, things are driven by two use cases: web services or UI login and the logics implement that. When it comes to customizing the behavior, there is one way: throw a HttpAction to break the flow. And yes, sometimes, a HttpAction may be also returned as indeed, it's an HTTP action to perform.
pac4j has been built almost only from my own reflection so other opinions are really necessary.

I'd like to close a few issues before the RC1.
This was a long discussion.
@mmoayyed what was the issue with the 204 code?
PR to revert this change: https://github.com/pac4j/pac4j/pull/808


How to add bash shell to a docker azul/zulu-openjdk-alpine image to execute run-java.sh

Hi. No Linux expert here.
I'm trying to execute the run-java.sh script from an azul/zulu-openjdk-alpine:8u232-jre-headless docker image. The last command of my dockerfile is:
CMD JAVA_OPTIONS="${JAVA_OPTS} ${ENV_JAVA_MODULES_FOR_HAZELCAST}" \
    JAVA_APP_DIR=/app \
    JAVA_CLASSPATH=/app/WEB-INF/classes:/app/WEB-INF/lib/*:/app/WEB-INF/lib-provided/* \
    JAVA_MAIN_CLASS=${ENV_JAVA_MAIN_CLASS} \
    /app/run-java.sh

(it previously had a COPY command from another staging step which copies all my app files to /app/)
However I'm getting next message when running the container:
/bin/sh: /app/run-java.sh: not found

Which is expected since there is no bash shell coming within the zulu's image.
So I tried to download a bash by adding next docker command:
RUN apk add --no-cache bash

But same error message appears.
So, what in addition to bash tool do I need to add in order to fully support all internal commands used in run-java.sh script?
Thanks in advance.

Alpine typically comes with ash instead of bash, but run-java.sh should also work with ash seamlessly (so no need to install bash).
The error you get indicates, that you forgot to add the script into your image. I suggest to add a
ADD run-java.sh /app/run-java.sh

to your Dockerfile after you have download run-java.sh and stored it in your local directory.

The script is already on the image. I'll try with ash. Thanks for the reply!

you can also try to run docker run -it yourimage ash and then try the script interactively. I suspect that the path is wrong (so no /app/run-java.sh is there as the error message indicates).

Hi. Definitely is an issue with the mini java 11 runtime built in a previous stage. The java executable is only 8888 bytes. When running an interactive shell over the container and calling $JAVA_HOME/bin/java -version it throws /bin/ash: java: not found. The executable is there, but its size tells me something went wrong during the creation of the java mini runtime in previous stage.
I'll close the issue since is not related to azul's zulu jvm nor run-java.sh script.


Zod .nullish() not supported

When attempting to use .nullish() I receive an error:
Input parser key: "searchTerm" must be ZodString, ZodNumber, ZodBoolean, ZodBigInt or ZodDate
zod Key -> searchTerm: z.string().nullish()
the type ends up being: z.ZodNullable<z.ZodOptional<z.ZodNumber>>

Inputs cannot be null. Use z.string().optional().

@jlalmes why though? it should accept null since JSON have support for it


[macOS] Return the correct minor version on 11 and later OS.

The OS returned from 11.0 and later is:
11.* = <IP_ADDRESS> (for 11.6)
12.* - <IP_ADDRESS> (for 12.2 beta)
The minor in those versions is correct. This fix ensures that Agent
capabilities can match the minor version too.

/cc @fadnavistanmay

/azp run

@alexander-smolyakov cab we land this?

This should also fix #3655

/azp run

@alexander-smolyakov can we land this?

@mandel-macaque, sorry for the delay on this one, our team is currently on holiday until next week. We are planning to finish the testing of these changes and merge them next week.

/azp run

/azp run

@alexander-smolyakov / anatolybolshakov anything else needed to get this merged?

/azp run

/azp run

@mandel-macaque thanks! We've merged the PR and going to roll out these changes with the next agent release.

Quick Update: Agent v2.198.3, which contains the related changes, has been fully rolled out.
cc @mandel-macaque @nycnewman


Fix Gradle error "finished with non-zero exit value 1"

It was fixed by removing the ic_launcher.png

Is there any issue if the ic_launcher file exists?
Sorry for the late reply


NO-ISSUE: merge main into KOGITO-8015-feature-preview

Sync KOGITO-8015-feature-preview branch.

Closed in favour of: https://github.com/kiegroup/kie-tools/pull/1590


Can't upload to Teams - works fine in local host

I have the same error 0 Can't upload to Teams. Are there any variables that we have to enter in the env file? You mentioned adding the domain above "Please make sure you are adding your site domain inside the validDomain list of your manifest." Can you give instructions on this please.
I have validated the manifest in Teams and it has passed.  Sideloading is enabled on the tenant

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42e0cad5-f762-c253-7d3b-b23ae3cb5b1c
Version Independent ID: f1babe27-cbc7-f757-11b4-fc8fa1e36873
Content: Get started with the Yeoman generator for Microsoft Teams - Teams
Content Source: msteams-platform/tutorials/get-started-yeoman.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@Minxpinx could you please share a screenshot the issue?

Hi
Here are the screenshots. I have also attached the manifest. Do I need to
add details to the environm
ent env file?
[image: image.png]
env
[image: image.png]
The domain name of where you host your application
HOSTNAME=hellopnp2.azurewebsites.net
App Id and App Password ofr the Bot Framework bot
MICROSOFT_APP_ID=00000000-0000-0000-0000-000000000000
MICROSOFT_APP_PASSWORD=
Port for local debugging
PORT=3007
Security token for the default outgoing webhook
SECURITY_TOKEN=
ID of the Outlook Connector
CONNECTOR_ID=
Application Insights instrumentation key
APPINSIGHTS_INSTRUMENTATIONKEY=
NGROK configuration for development
NGROK authentication token (leave empty for anonymous)
NGROK_AUTH=
NGROK sub domain. ex "myapp" or  (leave empty for random)
NGROK_SUBDOMAIN=
NGROK region. (us, eu, au, ap - default is us)
NGROK_REGION=
Debug settings, default logging "msteams"
DEBUG=msteams
MICROSOFT_APP_ID=00000000-0000-0000-0000-000000000000
On Thu, 14 May 2020 at 09:10, Gousia-MSFT<EMAIL_ADDRESS>wrote:

@Minxpinx https://github.com/Minxpinx could you please share a
screenshot the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/msteams-docs/issues/1651#issuecomment-628469931,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK2YX5BT45VNDS3EX3JUVNLRRORQHANCNFSM4NANHUKA
.

@Minxpinx I cant view the screenshots. Could you please attach them here?

Please re-open with requested information


Package for Java

I am evaluating to either package this project for Java or create a separate simplistic Java CDK Construct for OpenNext.
As I am unfamiliar with JSII, do you know how much more effort is needed in this project to be packaged for Java using JSII?
Thanks in advance!

@matusfaro, great idea! I don't have any experience publishing to maven, but it looks like it's relatively simple with projen. See here.
Could you test out deploying it to maven and then if there are no hiccups we can publish it officially within this repo?

@bestickley It was surprisingly easy to compile and package a JAR file, so the two outstanding issues are to test that it actually works and publishing to Maven Central.
Within a week or so I should confirm whether I can successfully deploy a NextJS site, I will post back when I do.
As for Maven Central publishing, this is something you would have to do on your own (I can guide you). Alternatively, I could publish it to Maven Central if you don't have the time, but it would be under my own group id, not com.jetbridge.
I posted the high-level steps in https://github.com/jetbridge/cdk-nextjs/pull/121 first would be to send a request to Sonatype to get permission to publish a package under com.jetbridge which takes a few days. Also to confirm, I assume you are able to add a DNS entry for jetbridge.com for verification purposes on Sonatype?

@revmischa, are you able to do the above? I don't want to speak out of turn for JetBridge.

I would just use your own identifier instead of com.jetbridge

@revmischa @bestickley  Which option do you prefer?

Bestickley could create his own identifier under his domain and publish it from this repo
I can use my existing identifier io.dataspray, fork this repository and publish from there (No additional work for you)

@matusfaro, I'd say we go with 2. for now. This is a 2-way door decision. We can create an "official" com.jetbridge later if desired.

2 sounds chill to me

@matusfaro, I see you've made good progress on open-next-cdk. But I think it would be smart to consolidate efforts. Is there any way you could incorporate your changes upstream?
If the only reason for creating the new package is for you to be able to publish packages to other registries, could we make you a maintainer of this project so you can do the same here?
What do you think?

did the above happen? also interested in using these constructs outside of js, specifically looking for a python release (happy to help make that happen if additional effort is needed).

@jaismith, the above did not happen. However, I will create a package in PyPI for you. I'm targeting to get it done within the week.

Fantastic, appreciate it. Agreed re: your naming related issue, these are deployment constructs and the "standalone" option may not be relevant to future nextjs releases this supports.

@jaismith, you're welcome! That's a great reason to ditch standalone. Do you mind commenting that on discussion?

@jaismith, the above did not happen. However, I will create a package in PyPI for you. I'm targeting to get it done within the week. Related: #191

Hello, i happened to run into this Repo today and was amazed by the results and the effort that has went into the NextJs Construct.
One thing that I would like to see is a pip package of cdk-nextjs.
I've tried packaging it using projen for PyPi which worked without any issue, I now locally have my own gzip which I was able to use in my python CDK Application without any issues.
Seeing as I've already made the needed changes locally, can I submit a PR? A maintainer would have to supply the credentials to be able push the package to PyPi. Is this something you would be interested in doing?

Hi @MohanadAbugharbia, PR would be great! Thank you.


eza: 0.20.9 -> 0.20.11

Things done
changelog: https://github.com/eza-community/eza/releases/tag/v0.20.11

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

closed in favor of https://github.com/NixOS/nixpkgs/pull/362043


Not able to hyperlink the paragraph with left align image

When i having image align to left and paragraph to right, i couldn't create link for the first word. Please refer to the attached image below.

Thanks for the report, could you create a quick jsfiddle to reproduce the error ?

In fact the screen captured was reproduced in the demo site http://linkesch.com/medium-editor-insert-plugin/.

You're right, in fact, as soon as an image is inserted before a paragraph, you can't make a link for the first world.
I guess it's a problem related to selection which shouldn't be well restored after submit the form with the url ..

We made some improvement on the link creation in MediumEditor. Could you try again with the latest MediumEditor version (ie 5.5.3) ? You will need to force bower to fetch this version since medium-editor-insert-plugin restrict to the 4th version.

Thanks for the improvement, i have tested the MediumEditor latest version 5.6.2 and the link creation is working now.

@wwchen21227 thanks for the feedback !


Add cyrillic turkic lang classification

Checklist for adding MMTEB dataset

Reason for dataset addition:

[x] I have tested that the dataset runs with the mteb package.
[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.

[x] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
[x] intfloat/multilingual-e5-small

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
[x] I have filled out the metadata object in the dataset file (find documentation on it here).
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.
[ ] I have added points for my submission to the points folder using the PR number as the filename (e.g. 438.jsonl).

A few comment on metata otherwise it looks good. Feel free to add point for yourself and review as well.

I added 14 point for me because there are three new languages:
"chv-Cyrl",  # Chuvash
"krc-Cyrl",  # Karachay-Balkar
"sah-Cyrl",  # Yakut
3*4+2 = 14 and 2 points for you for the review. Let mer know if it looks good.


Add development banner

I can do something like this:

but I realized it may not actually be necessary, given that we always have the Django Debug Toolbar tab showing in development mode too.
@danlamanna What do you think?

The code for the banner is:
{% if debug %}
Development Mode
{% endif %}

I'm fine with closing this out then. I would at some point like to tackle the issue of not accidentally making changes on production since prod/sandbox/dev tabs are often open at the same time.

Closing for now.


Feature/Add validation for prohibit sharing Attributes of pending Relationships

In this PR, the added validation prevents a RelationshipAttribute, which was created as part of a pending Relationship by accepting a Request, from being shared with a third party before the Relationship is activated. The following module and the following processors are affected by this validation:

AttributeListenerModule
ReadAttributeRequestItemProcessor
ShareAttributeRequestItemProcessor

Detail: Please note that when accepting a Request contained in a RelationshipTemplate, the RelationshipAttributes  are created first, and only then is the pending Relationship created. For this reason, it is not enough within the coding to simply check whether there is currently a pending Relationship and only then to prevent the RelationshipAttribute from being shared further. However, it may be that certain checks can or must be adjusted again as soon as a pending Relationship is prevented from being created if both peers have not yet been decomposed.
Open question: It must also be considered whether RelationshipAttributes of terminated but not yet mutual decomposed Relationships should still be able to be shared with third parties.

Why isn't it necessary to adjust the ProposeAttributeRequestItemProcessor, too?
ThirdPartyRelationshipAttributes no longer play a role in the processing of ProposeAttributeRequestItems as of release/v5, see also the updated documentation https://github.com/nmshd/documentation/pull/229/files#diff-68fc5ca7e063208ef0fd50053e3262f501cce9c0e8ca8c555e38b01afd637c46.


Fixes unavailable webhooks

Motivation:
Chuck would continue attempting to send webhooks and logging every single one of them, causing stability issues due to the sheer number of logs being generated every second.
This polls the webhooks every interval (5s default) set in the config to check if they're online. If they aren't online, the webhooks aren't sent, increasing stability.

Also a warning should be logged if all webhooks are offline.

Added both.

I think the original value is returned when it's synchronized vs async.


Misc WebGL Example Fixes

Changes:

In the Passing Shader Uniforms example I've fixed an issue where the geometry was being displayed mostly off-screen. It should now be centered.
The Primitives example was missing an ellipsoid shape.
Multiple Lights example was missing a spotLight().

Additionally I added describe() in each of these example sketches.
For GSOC 2022
mentor: @kjhollen

Thanks @aceslowman and @kjhollen for working on this. Please let us know if you need any help to get this PR merged.

@aceslowman I think I figured out what's happening with the center item in the shader uniforms example. I must have been looking at the example on my laptop, which has a 2x retina display. I was able to get the object to center by changing the code to:
theShader.setUniform('resolution', [width * displayDensity(), height * displayDensity()]);

If you make this change, I think we'll be ready to merge from there.

Just committed the fix you described and it seems to work well on my end. Quick question, I merged 'main' before making this commit, should I have held off on that?

@aceslowman should be fine, I'll build this on my end before I merge it just to be sure!


exec:"./manage.py": permission denied: unknown

docker-compose exec django ./manage.py migrate
OCI runtime exec failed: exec failed: container_linux.go:367: starting container process caused: exec:"./manage.py": permission denied: unknown
I don't know how to deal with this error

docker-compose exec django ./manage.py migrate
OCI runtime exec failed: exec failed: container_linux.go:367: starting container process caused: exec:"./manage.py": permission denied: unknown
I don't know how to deal with this error
You can run this code
chmod -R 777 ./

permission denied: unknown
It is just a permission denied error. I guess you can run as sudo, or change the permissions of some files, or add your used to the docker group using sudo usermod -aG docker $user.


rtabmap_ros: 0.20.22-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository rtabmap_ros to 0.20.22-1:

upstream repository: https://github.com/introlab/rtabmap_ros.git
release repository: https://github.com/introlab/rtabmap_ros-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.20.20-2

Merge https://github.com/ros/rosdistro/pull/35607 before this one.


Add High Volume SMS support to Go SDK

SDK Version: Latest
Description: There are a few new APIs for RingCentral High Volume SMS. Please update the Go SDK to include these.

Duplicate


dataset view (show/edit) did not show identifier(type) when manually created

In the current dev branch, if you create a dataset manually, the fields identifier_type and identifier are missing
in the description (both show/edit).
Reason for this is the if-statement to get identifier and identifier_type out of the map Identifiers:

https://github.com/ugent-library/biblio-backoffice/blob/dev/views/dataset/details.templ#L68
https://github.com/ugent-library/biblio-backoffice/blob/dev/views/dataset/edit_details.templ#L67

(P.S. there is no other way to assign variables in templ)
I replaced the identifierType != "" by true which is always true.
Not sure if we should keep storing the identifier like this
@verheyenkoen detected this

@nicolasfranck no if's that are always true; just add a method to dataset or something

@nics ok, I have done the following:

dataset.Identifier is always required, even if status is not public
add errors for both identifier_type and identifier, because one of both can be missing during edit, and we need to show an error for the field where the error is.
in the form, use key and value "as is" instead of only using the value when the identifierType is in the valid list, as it was done in production. This caused the form to clear the filled in value for "identifier" when "identifier_type" was not a valid value, or was empty.
generate display/fields in a golang function and then add the components in the form.

@mietcls @nicolasfranck why should identifier be required for a draft? this was a simple issue about 2 fields that didn't get rendered

It isn't required indeed for drafts, no need to change it - only on publish.
Sorry @nicolasfranck if I caused any confusion - for datasets it is mostly useless without an identifier but we don't need to stop people from making a draft without it.

@nics updated for review


Fixed typographical error, changed abritrary to arbitrary in README.

alexraasch, I've corrected a typographical error in the documentation of the docpad-skeleton-impress.js project. You should be able to merge this pull request automatically. However, if this was intentional or you enjoy living in linguistic squalor please let me know and create an issue on my home repository.

Thanks for the correction.


[Bug]: EIP1193Provider incompatible with ethers ExternalProvider

Current Behavior
No response
Expected Behavior
I was expecting the wallet.provider, which is a EIP1193Provider to be compatible with ethers ExternalProvider, but I get the following error:
Steps To Reproduce
No response
Onboard Version
2.0.4
Node Version
16
What browsers are you seeing the problem on?
No response
Relevant log output
Argument of type 'EIP1193Provider' is not assignable to parameter of type 'ExternalProvider | JsonRpcFetchFunc'.
  Type 'EIP1193Provider' is not assignable to type 'ExternalProvider'.
    Types of property 'request' are incompatible.
      Type '{ (args: EthAccountsRequest): Promise<ProviderAccounts>; (args: EthBalanceRequest): Promise<string>; (args: EIP1102Request): Promise<...>; (args: SelectAccountsRequest): Promise<...>; (args: EIP3326Request): Promise<...>; (args: EIP3085Request): Promise<...>; (args: EthChainIdRequest): Promise<...>; (args: EthSignTr...' is not assignable to type '(request: { method: string; params?: any[] | undefined; }) => Promise<any>'.
        Types of parameters 'args' and 'request' are incompatible.
          Type '{ method: string; params?: any[] | undefined; }' is not assignable to type 'EthAccountsRequest'.
            Types of property 'method' are incompatible.
              Type 'string' is not assignable to type '"eth_accounts"'.ts(2345)

### Anything else?

`"ethers": "^5.5.4"`

Going to take a look at this today and see if we can update the types to be compatible. If you ignore the compiler did you find that the functionality was working correctly?

Closed via #869


Ensure returned value of retrieveAzureVMMetadata is not null

ref: https://github.com/mackerelio/mackerel-agent/blob/b346699b247364717240c9a35bbfa10748e67ce6/spec/cloud.go#L282-L284
When first retrieveAzureVMMetadata fails but second succeeds. second retrieveAzureVMMetadata tries to access metadata, which became nil by first retrieveAzureVMMetadata.
With this change, returned values of retrieveAzureVMMetadata is guaranteed not be nil (unless metadataMap parameter is nil initially), so that parameter of retrieveAzureVMMetadata in L284 will be always non-nil.

LGTM

Thank you.


Windows build

This fixes some errors on MSVC and replaces some gnu-y and unix-y code with more agnostic variants that are compatible with MSVC as a compiler and Windows as a platform.
Also adds CI build for windows (just running tests, no coverage yet).

@bdash, could you please check to see I haven't butchered the CMake scripts or anything else too badly? Thanks!

@bdash @tgoyne could you please give this a look when you've got the time? thanks!

Thanks, everyone!


Duplicated icons when using Icon Shortcodes in admonitions

I originally posted this issue on the Icon Shortcodes plugin page (aidenlx/obsidian-icon-shortcodes#37), but it seems like it might be related to the Admonition plugin.
If I add an icon shortcode into an admonition, the icon is added twice.
For example, the code below:
> [!info:]
> - :fas_running: [[Activities]]
> - :far_calendar_plus: [[Planner]]
> - :fas_dumbbell: [[Gym Timetable]]

:fas_running: [[Activities]]
:far_calendar_plus: [[Planner]]

- :fas_dumbbell: [[Gym Timetable]]

> :fas_running: [[Activities]]

Displays like this:

At the moment I'm using CSS to hide the second icon, but it would be great if this could be fixed. I understand that the icons work correctly for the new callouts, but I don't yet have access to those.

This should be resolved as the issue was pertaining to the updating rendering of callouts. If the issue is persisting, a new thread can be created.


feat: spark dataframe integration

Tell us about the problem you're trying to solve
Add spark data frame integration
Describe the solution you’d like
A clear and concise description of what you want to see happen.
Describe the alternative you’ve considered or used

Resolved by #207


Shoulda's matcher validate_uniqueness_of(:name) does not work

My env:

Rails 3.1
Ruby 1.8.7

I've got the next model:
class Submodel < ActiveRecord::Base
  acts_as_enumerated :name_column => :code

  validates :code, :presence => true, :uniqueness => true
  validates :name, :presence => true, :uniqueness => true
end

I've got the next RSpec test:
describe Submodel
  before(:all) do
    Vehicle::Make.enumeration_model_updates_permitted = true
    @make = Factory('vehicle/make')
  end

  it { should validate_presence_of   :code }
  it { should validate_uniqueness_of :code }
  it { should validate_presence_of   :name}
  # NOTE: validation for :name column don't work when acts_as_enumerated is used
  it { should validate_uniqueness_of :name}
end

When I run it I've got the 4th test failed (all other are passed):
1) Submodel validations
   Failure/Error: it { should validate_uniqueness_of :name}
     Expected errors to include "has already been taken" when name is set to "unique_string_5", got errors: code can't be blank (nil)name can't be blank (nil)
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-expectations-2.6.0/lib/rspec/expectations/fail_with.rb:29:in `fail_with'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-expectations-2.6.0/lib/rspec/expectations/handler.rb:21:in `handle_matcher'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-expectations-2.6.0/lib/rspec/expectations/extensions/kernel.rb:27:in `should'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/subject.rb:54:in `should'
   # ./spec/models/submodel_spec.rb:29
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example.rb:48:in `instance_eval'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example.rb:48:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example.rb:107:in `with_around_hooks'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example.rb:45:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:294:in `run_examples'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:290:in `map'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:290:in `run_examples'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:262:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `map'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:24:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:24:in `map'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:24:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/reporter.rb:12:in `report'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:21:in `run'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/runner.rb:80:in `run_in_process'
   # ~/.rvm/gems/ree-1.8.7-2011.03@gems/rspec-core-2.6.4/lib/rspec/core/runner.rb:69:in `run'

I'm having a very simular issue: https://github.com/thoughtbot/shoulda-matchers/issues/58

I switched to a supported fork (power_enum): https://github.com/albertosaurus/enumerations_mixin


Run build command somewhere other than root

Potential customer: "It would be great if I could run the build command elsewhere so I don't end up copying all the build outputs from there to the place i need them"

workarount is use cp


Implementation of Unpooling operator

As discussed in #2169

Re @rmlarsen  friendly pinging about cide review.

@protoget @nio1814 sorry about the delay. I'll review this in more detail on Monday.

Updated the documentation.

Nagging Assignee @rmlarsen: It has been 27 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 50 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 65 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 80 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 95 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 119 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 137 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

The PR had no recent activity partly probably because I haven't reviewed. Will try to review soon. Sorry about that. Removing the stall label for now.

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

Again, will try to review soon. So sorry for my delay!

It has been 32 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

It has been 61 days that this pull-request has stalled. Please create a new pull-request with the requested changes.


SimpleSchema.RegEx.Email.test('asasdf@sdfsdf') == true

Looks like SimpleSchema.RegEx.Email regex has a bug for
SimpleSchema.RegEx.Email.test('asasdf@sdfsdf') == true

That is a valid address. From the readme:

SimpleSchema.RegEx.Email for emails (uses a permissive regEx recommended by W3C, which most browsers use)

If you want something more specific, you can write your own, but the only way to truly validate an email address is to send an email to it.

Got it. Just wanted to confirm. Thanks.
On Sun, Mar 22, 2015, 5:53 PM Eric Dobbertin<EMAIL_ADDRESS>wrote:

Closed #306 https://github.com/aldeed/meteor-simple-schema/issues/306.
—
Reply to this email directly or view it on GitHub
https://github.com/aldeed/meteor-simple-schema/issues/306#event-261792211
.


Blog post link

The URL to Y0av's blogpost is dead. Looks like the article has been taken down

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69882e91-6bef-d524-7059-20ba67129f4e
Version Independent ID: ee0f2eb3-97da-4306-5cd1-2b6ae1858ed9
Content: Configure Surface Hub Start menu - Surface Hub
Content Source: devices/surface-hub/surface-hub-start-menu.md
Product: surface-hub
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

I create PR to remove invalid link and I add a similar corresponding information link

The link will be deleted for now. A new blog link is pending.


add-javascript

@simonnineteen90 @rtasalem thanks for looking at this, I have noticed a couple of things if you're able to help me please? These are all on the single business view.

Unread message label/tag - I noticed on the 'your businesses' screen it updates on the label within the tab selection but not on the inline label by the business name. I tried to work it out in the code but I can't figure it out, please can you have a look? See image:

'permissions-for' screen - I've added a comment on line 52 of the javascript file. It is just the class for 'permissions-column-selected-xl' also needs adding to the list on the script you wrote on line 51. I tried to add this like this:
columnTypeRegular  ?  column.classList.add('permissions-column-selected') : column.classList.add('permissions-column-selected-short') : column.classList.add('permissions-column-selected-xl')
but it triggered an error. Please can you look at that?


Remove external render blocking dependencies?

Currently using Streamlit in an air-gapped system (no external network access).
The component takes a long time to render (~10s), Streamlit flags that the component is taking a while to load. Eventually the component loads and a few errors are shot into the browser console.
The following resource cannot be loaded:

http://fonts.googleapis.com/css?family=Source+Sans+Pro

Further investigating, this resource is listed in the file streamlit_pills/frontend/public/index.html
<!DOCTYPE html>
<html lang="en">
  <head>
    <title>streamlit-pills</title>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <meta name="theme-color" content="#000000" />
    <meta name="description" content="streamlit-pills" />
    <link href='https://fonts.googleapis.com/css?family=Source+Sans+Pro' rel='stylesheet' type='text/css'> <----
    <link rel="stylesheet" type="text/css" href="./styles.css" />
  </head>
  <body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
  </body>
</html>

Is this external dependency required? Can the component not just utilise the locally bundled Source Sans Pro within Streamlit?

Streamlit has pills as a built-in feature now, using st.pills. See docs. Please use that instead of this component! I think the problems you're describing above shouldn't exist with this new feature anymore.


Corregidos errores de traducción y comentarios

Se tradujeron comentarios y se tradujeron los nombres de variables/clases al español para mejor entendimiento. Se corrigieron errores de estilo y redacción.

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@Kirajav Thank you for  creating this PR.  However, since it was created, the underlying document has changed.  Can you please review and resolve the current merge conflicts?  It could be the changes to the underlying document are so significant that your changes are no longer relevant.  If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.
If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.
Thank you.

We are restructuring a lot of the code and learning resources referenced in your pull request, so for now I am going to go ahead and close this pull request. Thanks again for opening this pull request and for contributing to the community.


IO::FileDescriptor & Socket finalizers do far too much

The initial idea for the finalizer was to avoid leaking file descriptors when you'd call File.new instead of File.open(&) and then forgot to close it. See https://github.com/crystal-lang/crystal/issues/780 and https://github.com/crystal-lang/crystal/commit/3bfd62aa2b7b5771dabbdc9064a8a491f3cb7cce.
The actual implementation called the #close method, and it hasn't changed ever since, and... it's actually doing a lot more things than the original idea meant to:

it flushes any buffered data;
it re-enqueues pending readers & writers;
it finally closes the file descriptor.

When called from regular code, this is the expected behavior, but let's contemplate that it may happen in a GC finalizer, that is be called during a GC collection, while the world is stopped and we want/need to resume it ASAP.
Note: while I think the unflushed buffer can happen in practice (we can write to a socket, forget to flush, then lose the reference) I don't think the pending reader/write can happen: it would mean a fiber got suspended trying to read or write, and they must have the file/socket reference in the function call somewhere (i.e. at least one pointer on the fiber stack) so the GC won't collect it.
Trying to flush means that it can try to write, hence call into the event loop, that may have to wait for the fd to be writable, which means calling into epoll_wait :scream: (while the world is stopped). The event loop implementation may need to allocate, or we get an error and try to raise an exception that will also try to allocate memory... during a GC collection :scream:
Proposal: I'd merely call #file_descriptor_close in the finalizer and either always print a warning to STDERR when we do, or maybe only when there was pending buffered data (that won't be sent).

We need non-raising variants of file_descriptor_close. The default implementations raise if the system close errors. In a finalizer we shouldn't care about this error though (and it would involve an allocation for the exception).
I don't think printing a warning is a good idea. Closing in the finalizer doesn't really contribute to whether the buffer is flushed. If there was no finalizer, the file descriptor would never be closed (and no data flushed).
Maybe warnings could be useful as a tool while transitioning away from the current semantics with flush. But it shouldn't be an eternal thing. And then I don't see a good mechanism to decide when to enable it and when not. So I'd rather leave it away. Maybe we can provide an opt-in for such warnings.


training code

Hi! Great work!
I noticed that you released training code two weeks ago, but there haven't been updates to the relevant sections in the README. Could you confirm if this training code is usable? If so, could you provide the command used for training on the Epic-Kitchens dataset?

I have the same request 👀

Hey @CleyLyChen, @yuezih, thanks for showing interest in our work! :) I'll make sure to release the code relevant for EPIC in a few days (after CVPR deadline, unfortunately)...I'll keep you posted!

Hey, we've released the multimodal knowledge distillation training code. The only thing remaining to reproduce the experiments in our paper are the datasets (Epic-Kitchens, Something-Something/Else). We store these as large HDF5 files which we cannot upload anywhere (together they're around 1000GB). This gives us two options:

We provide you a link from our servers from where you can wget them.
We release a script, such that once you download Epic-Kitchens and Something-Something/Else, you can pack them as HDF5 files.

Let us know what do you prefer. Cheers!

Hi! Your work is very nice!
I found that there is no dataset. In the two options you provided, I hope that you can provide me a link of dataset from your servers from where I can wget them if it's convenient for you. Or could you please provide me with demo of dataset so that I can try to reproduce your work and learn from you.
Thank you so much for your attention!

Hi! Your work is very nice!
I found that there is no dataset. In the two options you provided, I hope that you could provide the script. Because downloading the dataset of 1000GB  is too difficult for me. At the same time, I would be very grateful if you could provide me with demos of the dataset to help me reproduce the work and learn from you.
Thank you so much for your attention!

@Alice123DH, @yuezih @CleyLyChen I can forward the datasets (HDF5) only via email using Belnet so please post where should I send you the files.

Dear Gorjan，
    Thank you so much for your asking. I received the dataset you sent on my 163 @.***). I am truly grateful for your kindness, and thank you very much!
文津@
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "gorjanradevski/multimodal-distillation"                                                                                @.>;
发送时间: 2024年1月4日(星期四) 晚上11:10
@.>;
抄送: "文津<EMAIL_ADDRESS>主题: Re: [gorjanradevski/multimodal-distillation] training code (Issue #1)
@Alice123DH, @yuezih @CleyLyChen I can forward the datasets (HDF5) only via email using Belnet so please post where should I send you the files.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Update: I'll update the README by Friday next week with a permanent download link to obtain the HDF5 files for all datasets and modalities we use in the paper.

Hello, we've just updated the README with a download link for the datasets. Closing this issue now.


Staging SRE-SE2 is not rejecting wrong submissions

I'm submitting a Challenge re-using the URL from another Challenge #number contract.
In LIVE it's rejecting it, but in Staging it stays as Submitted.
Example: https://staging.speedrunethereum.com/builders/0x60f6692727B8a92b0AC5eC7db30DD83448F18aAf

This should be fixed now! Can you check @Pabl0cks ?

This should be fixed now! Can you check @Pabl0cks ?

Yes! Now is rejecting without problem, tried re-submitting one of the pending challenges and got rejected also 🙌
Found a problem with "Updated" column in this version, on all my profiles it's always trying to load the date, but never finishes. Maybe it's a problem with the staging server, it's been a bit slow during the tests. Tried different networks but didn't fix it.
Here is a screenshot.

Yep, you are right, this was only an issue on the staging server. I needed to create some indexes on Firebase (staging) for this to work. It should be fixed now!

Great! Now is working like a charm 🙌
Tried all challenges with correct code, all being accepted. Also tried some rejected challenges (Chal 3 - 4 - 5) and we're getting the same reject reasons as with old SRE challenges.
Closing! 🔥🚀


Thanks for pointing that out!


Features

General Notes

A checked item means it has been implemented in the 2.0 development branch.
Features subject to change during development.
The breaking change list is not guaranteed to be complete during development.
There are some upgrade tips at the end.

High Level Changes

The template parser no longer relies on the DOM (unless you are using the real DOM as your template), so as long as you are using string templates (

In the example child.$parent would return component Foo instead of Bar, which si correct but if the parent and child are dependent of each other a direct communication between them could be through the context.

@miljan-aleksic I'll leave this one to @yyx990803. I would say that just like with $parent, reaching for $context will probably be the wrong way 99.9% of the time and I think I'd probably never use it.

I have a situation with v-show and transitions. In this scenario there is a modal which by default is to 'display: none' in the CSS. When combined with v-show it would never be shown becasue the directive removes the display property, the CSS ones then persist. I can't change the CSS (project requirements) and I can't use a custom directive as seems Vue transitions relies specifically on it.
I am thinking now that a directive that evaluate right after v-show could set the display property to block. Need to try that out but anyway it could be a good idea to add a modifier to v-show to allow setting display to block or inline-block. Just a thought.

@chrisvfritz, it is expected that for functional components the parent reference is not the immediate parent where they are being used as slots, but the context component instead?

Compilation of template fails if it contains "<" (and possibly other html-sensitive characters) in 2.0.0-beta7
https://jsfiddle.net/x0r59ur1/
This worked in 1.0.26.
Escaping "<" with "<" solves the issue.

@GlurG it's expected to escape "<" properly.

@yyx990803, if I want to use transitions on a list of components of the same type and keep their state, how should I do it? Following the docs I only see how when the components are different.
Lets say a Tab component and transition its items. I can't find a way :(
<tabs>
  <transition>
    <tabs-item>Content 1</tabs-item>
    <tabs-item>Content 2</tabs-item>
    <tabs-item>Content 3</tabs-item>
  <transition>
</tabs>

@miljan-aleksic <transition> is for single element only. You need <transition-group> for multiple items.

@yyx990803, tried that one as well, but still don't see how to achieve it. Transition-group works by adding/removing elements but while doing so the components would be inited again, losing the state. Beside the idea of a Tab is to show only one component at a time, its not exactly a list :)

@miljan-aleksic

When toggling between elements that have the same tag name, you must tell Vue that they are distinct elements by giving them unique key attributes.

https://github.com/vuejs/vuejs.org/blob/2.0/src/guide/transitions.md#transitioning-between-elements

<tabs>
  <transition>
    <tabs-item key="tab-1">Content 1</tabs-item>
    <tabs-item key="tab-2">Content 2</tabs-item>
    <tabs-item key="tab-3">Content 3</tabs-item>
  <transition>
</tabs>

@yyx990803, @LinusBorg I appreciate the help but the solution is not obvious. I know have the transitions are applied, what I can't figurate out is how to keep-alive the transitioned components.
I have created a new issue for clarity sake with jsfiddle example on it how the components are created each time.

@yyx990803, thank you so much for improving the keep-alive feature, now it works as expected.
You are literally changing my life, with your products and works ethics I am able to learn, build and deliver products that I had long time in standby. With your keep it simple approach, high tech is available to everyone to use and build upon. For all that and more I am eternally gratefull.

@miljan-aleksic There's a Patreon campaign *wink wink*.

You know what @phanan, you are totally right. I have starting supporting Evan personally and as soon as the company products start giving results will make sure the support becomes more noticable :)

The ready lifecycle hook is deprecated in favor of mounted; but according to the changelog there is no guarantee that the component will be rendered before mounted is called. This causes sporadic errors when I want to initialize certain jquery components (like selectize) after the component has initialized. Which lifecycle hook should I use instead? Can the "ready" hook be emulated like this:
function mounted() {
  Vue.nextTick(() => {
    //...
  });
}

@GlurG Yes, that will work. And by the way, that was also nessessariy with ready'() in 1.0 in many cases.

Is there any reason there can't be a hook for this regardless? I've also
across this...even in 1.0, and resorted to things like looping with raf to
check if its in the dom, etc.
On Aug 10, 2016 6:26 PM, "Thorsten Lünborg"<EMAIL_ADDRESS>wrote:

@GlurG https://github.com/GlurG Yes, that will work. And by the way,
that was also nessessariy with ready'() in 1.0 in many cases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue/issues/2873#issuecomment-238903012, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACounAoI8p65soUUrbdaiwteDXKgMGJks5qee25gaJpZM4IedHC
.

When using the render functions the core directives are ignored, which is reasonable. But some models are not so easy to reproduce using plain js, as the v-model which has workarounds for IE9 and probably solves other edge case issues.
It makes you reconsider using a template instead, but thats not possible or the best option in some situations. The docs could definitely offer more guidance on this topic and besides it could be a good idea to have some helper when working with render functions which would help solving these common situations and make no one miss a template.

@miljan-aleksic it needs documentation, but the syntax looks like this:
render(h) {
  return h('div', {
    directives: [
      {
        name: 'show',
        value: this.isVisible
      }
    ]
  }, 'hi');
}

Right @sqal, that way is possible to emulate v-show but for v-model it also requires an input or change event listener that will keep the data synced. And those are tricky parts I was referencing.
Maybe I am doing something wrong? Are you able to set a v-model behaviour with only declaring it on the directives array?

@miljan-aleksic sorry, i deleted my comment because i noticed it's only works for v-show or custom directives, and yeah, as you said in case of v-model, it's required to add input/change listener and update our data manually

is the new activated hook supposed to be called when a route is fired that activates/mounts a router-view?

@wprater no, it's solely related to <keep-alive> and nothing else.

@yyx990803 Im wrapping my router-view in a keep-alive, but I cannot seem to find a hook for when I route back to the pervious view.  mounted nor activated are called.  I need to be certain the dom is rendered.

@wprater please avoid using this thread for unrelated questions. If there's a bug, file issue at corresponding repo with reproduction.

Does Vue JSX support the object spread operator ? I've tried it but it doesn't work.

It does and @yyx990803 put in a lot of effort to get it working.
I'm doing this <Component {...{ props } }></Component> and it works as documented.

@blocka Thanks ! I thought the property name props was not needed 😂

@yyx990803
components options don't support array type, but 1.x is work.
e.g.
var Parent = Vue.extend({
  name: 'parent',
  template: '
<slot></slot>
'
})

var Child = Vue.extend({
  name: 'child',
  template: 'hello'
})

new Vue({
  el: '#app',

  components: [
    Parent,
    Child
  ],

  replace: false,

  template: '<parent><child></child></parent>'
})

It's bug?

@QingWei-Li they are simply not supported anymore, since it was never an officially documented feature. The reason is that with ES2015 you can just write components: { Parent, Child }.

just a small feature request,
is there any chance for the normal array iteration we use v-foreach and for range we use v-for.
which will make more sense for users coming from php and even consistent with .each in JQ or foreach in JS

@ctf0 We are in RC stage, the API will not change anymore. And we won't introduce alternative syntax for doing the same thing either.
I don't think that the mental overhead of v-for="item in items" is significant enough to warrant that.

With this new version, i would you handle this case.
I have a calendar component (coming from semantic ui), which uses a classic text input, and show the date in a human format (like "July 10, 2016" for example). With v1.0, i was using a two-ways filter to convert that string into a proper date so my object data was directly ready for submit. But since filters won't work anymore in v-model, how could i do the same thing now in v2.0 ?
Thanks

@shadowRR would it be possible to see some code?

@p-adams Sure. Here you go.
First, my filter, which is use on my v-model for my calendar input. It's only purpose is to write, when the value change, a proper date type to my data (postgres date).
Vue.filter( 'formatDate', {
        read( date ) {
            return date;
        },
        write( date ) {
            if( !date ) return null;
            return moment( date, 'D MMMM YYYY' ).format( 'YYYY-MM-DD' );
        }
    } );

And i would you use it like this on my component (the input has a calendar system which return my date in the human readable format)

        Start date

                      <input v-model="section.start | formatDate" type="text">

I'd recommend reading @yyx990803's post here: https://github.com/vuejs/vue/issues/2756 where he discusses two-way filters on v-model.

I missed the post you're talking about, gonna see that, thanks ;)

Hi,
I have some doubts in new life cycle hooks.
If I want to register an event handler when mounted, and deregister it before unmount, how should I make it work?
In Vue 1.x I would use attached & detached hooks.
But in 2.0 there is mounted hook but no unmount hook. Feels a bit not corresponding.
Is there any reason why no unmount hook is provided?

@f15gdsy mounted corresponds to destroyed. There's no attached/detatched counter parts in 2.0 - you need to do the in-dom check yourself. If your events don't care about in-dom/off-dom then mounted and beforeDestroy are the appropriate places to do that.

When used on a custom component, v-on now only listens to custom events $emitted by that component. (no longer listens to DOM events)
I may have missed a few posts here, but what's the design decision behind this?
It would make binding simple click events on components very verbose..

Original:
<foo @click="bar"></foo>

2.0:

  <foo></foo>

@fnlctrl, use the native modifier: @click.native="bar".

@miljan-aleksic Thank you very much!

Could I use Koa(1.x or 2.x) as the server? Is there any problem on vue-server-renderer with Koa?

@yyx990803
import Vue from 'vue'

Vue.component('expanding', {
  functional: true,
  render (createElement, { children }) {
    const data = {
      props: {
        name: 'expanding',
      },
      on: {
        beforeEnter ($el) {
          $el.classList.add('collapse')
          console.log('beforeEnter')
        },
        enter ($el) {
          $el.classList.remove('collapse')
          $el.classList.add('collapsing')
          $el.style.height = `${$el.scrollHeight}px`
          console.log('enter')
        },
        afterEnter ($el) {
          $el.classList.remove('collapsing')
          $el.classList.add('collapse', 'in')
          console.log('afterEnter')
        },
        beforeLeave ($el) {
          $el.classList.add('collapsing')
          $el.classList.remove('collapse', 'in')
          $el.style.height = 0
          console.log('beforeLeave')
        },
        leave ($el) {
          console.log('leave')
        },
        afterLeave ($el) {
          $el.classList.remove('collapsing')
          $el.classList.add('collapse')
          $el.style.display = 'none'
          console.log('afterLeave')
        }
      }
    }
    return createElement('transition', data, children)
  }
})

  <expanding appear="true">

              <router-link to="/tables/basic">Basic</router-link>

              <router-link to="/tables/handsontable">Handsontable</router-link>

        </expanding>

Why do not call the enter hook?

@fundon You should ask the question on the forums or the gitter chat

Locking this thread because:

We are now in API freeze in RC so this document will no longer be updated.
Too many people are using this as a general FAQ thread, which is not what it is for.

If you have a bug, please open a separate issue following the issue reporting guide, if you have a question, please use the forum or gitter.

Update: For a more definitive and detailed list of changes in 2.0, see the new migration guide.