Using Razor comment out key map does not comment out properly

Issue Type: Bug

Edit a cshtml file
Select html code to comment out
Use comment out keymap (CTRL K + C)

Expected Behavior:
Proper comment is used based on syntax
Select Html only line should use
Select Razor should use @* *@
Actual Behavior:
After comment out keymap is pressed, the selected area has // at beginning of each line.
https://www.screencast.com/t/mxAOaHv7qV
VS Code version: Code - Insiders 1.21.0-insider (1a84a882737184488d965426747a05474f54a759, 2018-02-27T09:01:48.555Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz (8 x 2394)

Memory (System)
15.88GB (3.92GB free)

Process Argv
C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

gitlens
eam
8.0.2

mssql
ms-
1.3.0

python
ms-
2018.1.0

csharp
ms-
1.14.0

PowerShell
ms-
1.6.0

vs-keybindings
ms-
0.1.7

team
ms-
1.122.0

vscode-icons
rob
7.20.0

Reproduces only with extensions

This does not seem to be a VS Code specific issue. Please open an issue in the extension's repository.

@tsalinger , i disabled all of my extension and it still have the same behavior.

@tsalinger, @bpasero, not sure even a moment went in to actually investigate


Intl translations for error messages stops to work

Hi!
I've noticed that when using your addon intl translations for error messages stops to work. Is there some way to overcome this issue? Have anyone had similar problem?
Cheers MM

Do you have any more specific information like an actual error you're seeing, details on your setup etc.?

Hi,
for validation / translations I'm using:
ember-intl,
ember-cp-validations,
@ember-intl/cp-validations,
ember-bootstrap-cp-validations,
ember-validated-form-buffer

there is no error message. All translations works perfectly except for validation errors. If I remove ember-validated-form-buffer and restart the app translation of validation errors start to work again. I'll try to make an example over weekend.

I've changed order of addons in package.json such that  ember-validated-form-buffer
go before @ember-intl/cp-validations and it works.
I'm closing issue.


CHCI chci_visit_occurrence_datasprint_2.csv missing

Hi
I submitted the visit file on 1-15-17 but it is not listed on the report.
Thank you
Tyler
2-14-17 visit file email.pdf

In the screenshot there appears to be a typo (missing 'r'). Unfortunately, the tool is very picky about spelling. It won't process a file that is misnamed; it will just say it couldn't find it. Renaming the file and resubmitting it should correct the issue.

Hi
Thank you
Just resubmitted it with the correct spelling ☺
Tyler
From: Mark Velez<EMAIL_ADDRESS>Sent: Tuesday, February 14, 2017 3:00 PM
To: cumc-dbmi/pmi_sprint_reporter<EMAIL_ADDRESS>Cc: Philips, Tyler<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [cumc-dbmi/pmi_sprint_reporter] CHCI chci_visit_occurrence_datasprint_2.csv missing (#18)
In the screenshot there appears to be a typo (missing 'r'). Unfortunately, the tool is very picky about spelling. It won't process a file that is misnamed; it will just say it couldn't find it. Renaming the file and resubmitting it should correct the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cumc-dbmi/pmi_sprint_reporter/issues/18#issuecomment-279818611, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AUKgOVmpeuhj6e47gDafoK0HMCWJjSunks5rcgfNgaJpZM4MAnCp.

This message originates from Community Health Center, Inc.. The information contained in this message may be privileged and confidential. If you are the intended recipient you must maintain this message in a secure and confidential manner. If you are not the intended recipient, please notify the sender immediately and delete all copies of this message. Thank you.


Port algebra and number systems

Overall I'm quite happy: porting didn't break too much files. There are a couple of places where I had to give the elaborator extra hints, for example because it couldn't unify 1 with succ 0 (a couple of examples are in homotopy/sphere.hlean).

Some comments:

I changed two files in src: src/frontends/lean/elaborator.cpp and src/frontends/lean/notation_cmd.cpp to ensure that the HoTT library also uses the new way of parsing numerals. This might make some code obsolete, which you might want to remove, Leo. (I also commented out the code instead of deleting it; I will fix that tomorrow.)
I made a couple of compromises for the HoTT library:

Almost all algebra-stuff is in the algebra namespace. I didn't want to overload too many things, such as inv_inv, which we also have for equality. I will test at some point whether this is really necessary.
+ is permanently overloaded as add and sum (the sum of two types). I think it was unacceptable to also put + (add)  in algebra, because then you had to open algebra to even write  postfix `#`:(max+1) := foo On the other hand, + is also used all the time for sum.

I still have to use the classes has_zero and has_one in a couple of places where I currently define the notation 0 or 1.

Wow, that was fast! Was the port entirely uneventful? I see that you used the porting script, and that you use the new elaborator in the algebra files. I take it you haven't noticed any performance problems?
Here is a funny side effect of the port:
https://github.com/fpvandoorn/lean/blob/porting/hott/algebra/field.hlean#L6
I plan to work on modules and vector spaces over the winter break. Should I do them in the standard library and port them to HoTT using the script?


[BUG]Azure.Identity not working with Powershell module .net framework project running in windows powershell

Library name and version
Azure.Identity 1.8.0
Describe the bug
I have a .net framework c# project implementing powershell module.  I'm trying to migrate from Microsoft.Azure.Services.AppAuthenication to Azure.Identity.  Everything works fine with AppAuthenication; however, once Iperformed the migration, we got the following error during runtime
Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
I checked all the references in the solution, and there's no references to version <IP_ADDRESS>.  Also, the bindingRedirect is setup correctly.   Somehow, it's still trying to use <IP_ADDRESS>

I also attempt to perform the bindingRedirect manually through powershell script (*.psm1), which also doesn't help
$Unsafe = [reflection.assembly]::LoadFrom((Join-Path $PSScriptRoot System.Runtime.CompilerServices.Unsafe.dll))
$OnAssemblyResolve = [System.ResolveEventHandler] {
param($sender, $e)
if ($e.Name -eq "System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a") { return $Unsafe }
foreach($a in System.AppDomain::CurrentDomain.GetAssemblies())
{
if ($a.FullName -eq $e.Name)
{
return $a
}
}
return $null
}
Expected behavior
System.Runtime.CompilerSerivces.Unsafe should use the redirect version (<IP_ADDRESS>) during runtime
Actual behavior
Getting the following message during runtime
Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
Reproduction Steps
public static async Task AcquireTokenAsync(string resourceId, string tenantId, CancellationToken cancellationToken = default)
{
var tokenCredential = new DefaultAzureCredential();
var tokentRequestContext = new TokenRequestContext(scopes: new string[] { resourceId + "/.default" }, tenantId: tenantId) { };
var token = await tokenCredential.GetTokenAsync(tokentRequestContext, cancellationToken).ConfigureAwait(false);
return token.Token;
}
fail at GetTokenAsync
Environment
No response

//cc: @christothes

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

This sounds similar to this issue - does this approach for setting up the binding redirect help in your case? https://github.com/Azure/azure-sdk-for-net/issues/21361#issuecomment-849634754


Create logo for the project

There's a logo from @konrad and an alternative logo from @aleimba here: https://github.com/OKScienceDE/Open_Science_101/tree/master/logo
Both have room for improvement ;-).
From @matthiasfromm: However, before we proceed, we should probably decide on a final name for our project (see #56). Also, the logo might then be adapted for each Open Science topic ...

I just would like to mention that the logo that I developed was created in a rush for the MozSprint and should be seen as a place holder. :)


Changes to timezone using timedatectl are not reflected in the clock

I use sway. When I travel, I set whatever new timezone I am in using timedatectl, but the waybar clock does not update to reflect this. Interestingly, if I then connect a monitor the clock on the new screen does reflect the new timezone.

I got the same issue too. Restarting waybar fixes it though, so it's not very annoying.
Question to maintainers: would you be interested in a PR to fix that?


v1.0.3 release

Hi, I'm using rails-assets to get bower packages into my application, and I get an error message because the bower.json file is not included in the package. I can see you included it with v1.0.3 but it's not released (tagged) yet and thus not available from rails-assets.org
It'd be great if you could release it so we could get rid of those errors ;)

+1

+1, release it please.

Released!
https://github.com/MoonScript/jQuery-ajaxTransport-XDomainRequest/releases/tag/1.0.3
Sorry for the delay, guys.  I think I was waiting on cdnjs when I first had this release ready, then forgot to back and tag it in my repo.


Fix broken ProxiedIdentityProvider test

The test was broken because a feature was merged back while tests
were broken.

Strange, the PR where this test was introduced did not have a problem with this test
https://github.com/OpenConext/OpenConext-engineblock/pull/807
It must have been broken in a successive merge action.

@MKodde you did a force-push after a successful build and that broke the build. After that the PR was merged back.
MKodde force-pushed the bugfix/use-real-idp-data-in-idps-metadata branch from 32d7e8e to f3e29fa yesterday


[New Port Request]

Library name:
cityhash
Library description:
CityHash provides hash functions for strings.  The functions mix the
input bits thoroughly but are not suitable for cryptography
Source repository URL:
https://github.com/google/cityhash
B.R

why so many requests? don’t even look that they are repeated
https://github.com/microsoft/vcpkg/pull/7879

sorry 'bout that ;)

I'm not in this sense, the rest of the queries are similar, you can query the whole DEBIAN
Is there any windows \ msvc support?

not sure about libprotoident, but rest of them should be compatible with windows ( as i know ! )

Hi @regexizer  thanks for posting this request. The PR #7879 has been merged to master. Please try to update vcpkg and use it.


EPIC: Compact Blocks

This issue is a placeholder to track more specific issues as we flesh out what our implementation of compact blocks will look like in tendermint.
Tendermint's p2p stack is restricting how big of blocks we can safely come to consensus on. One of the causes of inefficiency is that we are gossiping transaction data twice, once in the mempool and then again when gossip the proposal block. Instead, we can gossip the transactions and blobs in the mempool, then only gossip the hashes of those things in the proposal block. If validators or full nodes do not have a given transaction or blob already in their mempool, they will ask their peers for that data.
There have been other similar implementations of compact blocks, but those implementations still fallback on the normal gossiping mechanism if only a single transaction is missing from the node's mempool. We want to not rely on current block parts mechanism at all. This will require a robust mechanism to pull specific transactions from peers, which does not yet exist (see push pull mempool epic)
Ideally this implementation could be upstreamed, but we will implement it here first.

closing in favor of https://github.com/celestiaorg/celestia-core/issues/1334


Add EXLA to enable use of at least CPU-based ML

From working with Paulo Valente and Jonatan Klosko it seems we need to run from unreleased versions right now. Not sure what fix it is we need but that was the case when I tried to run Whisper.

I think this is all that's needed. I didn't build and run it. If you need me to, I can.

I rebased on main and updated to use hex.pm versions of everything now that they've been released. It seems really close, but still doesn't compile on CI. I'm able to build on MacOS with a manual change to the exla Makefile. That change shouldn't be needed on Linux, so I'm surprised CI didn't work, but will have to look into more later.

Let me know if you need me to try this on anything.

@lawik Could you check it? I think it works, but it's pretty easy to hang my RPi5 when using Bumblebee, so I'm not sure.

I'll give it a bash :)

This PR requires https://github.com/elixir-nx/nx/pull/1543 to build on MacOS and on Linux machines that have CUDA tools installed. There are a couple ways this could be fixed, but that's why I haven't merged it yet.

I rebased again.


Chaos experiment in docker containers

At present litmus is supporting chaos experiments in k8s. Can we enhance to support running chaos in docker hosts as well. Example I have a kafka cluster hosted in docker(no k8s). I want to try kafka chaos experiments on this kafka running on docker.

@ksatchit Any update on this?


Large number of crashed sessions on Android

Package version: 0.1.0-alpha.16
We recently launched an updated version of our React Native app with snowplow tracking enabled. Over the following days we observed a significant increase in the number of crashed sessions, with the following stack trace:

Ultimately crashing on this line: https://github.com/snowplow/snowplow-android-tracker/blob/0ab5eeaf15eea7ca9562cf96dd28a034b97c668c/snowplow-tracker/src/main/java/com/snowplowanalytics/snowplow/tracker/Tracker.java#L91
After a couple of wrong turns we were able to come up with the following process for reproducing it:

Freshly install the app
Open the app and see if it crashes
If not, delete app and restart the process

This gives us a crash rate of approximately 20% on launching the app for the first time. Once the app has successfully opened once, we are unable to reproduce the problem further.
Whilst the the problem is in the native Android snowplow tracker, I suspect the problem actually lies in the way the RN bindings interact with it. We speculate that this is probably a threading issue, from the official docs:

Native modules should not have any assumptions about what thread they are being called on, as the current assignment is subject to change in the future.

We suspect something is going awry with the install tracking and how it calls back into the main instance here: https://github.com/snowplow/snowplow-android-tracker/blob/master/snowplow-tracker/src/main/java/com/snowplowanalytics/snowplow/tracker/tracker/InstallTracker.java#L99
Which is initially triggered in the constructor of that instance: https://github.com/snowplow/snowplow-android-tracker/blob/master/snowplow-tracker/src/main/java/com/snowplowanalytics/snowplow/tracker/Tracker.java#L465
Workaround
For now, we have setInstallEvent set to false and this has resolved the problem for us by short-circuiting the install tracking.

Thanks for reporting @jdmunro.
Short term, the most obvious thing to do seems to be to remove install tracking from react-native for now, unless we can come up with a way to make it stable.
Longer term I'll knock heads together with the team to see if there's a solution to be found in the native tracker(s).

Quick update on this one - a patch for the crashing itself is in the latest release of the Android tracker.
So bumping to that version would be the plan as far as resolving for this project goes I think. However while this will prevent crashes, the cases where it currently crash would still lead to missing install events unfortunately - this is something we're looking for a solution for also.


feat (@vtmn/css): be able to choose the duration of display for snackbar (& toast)

Describe the bug

We are implementing the snackbar in our application and for accessibility purpose our UI/UX team recommended that the snackbar should be displayed for 8 seconds.
We see that the duration is hardcoded in the --vtmn-animation_overlay custom property of animations design-tokens so we manage to override it, but we think it would be good to be able to set it more "gracefully".

Steps to reproduce
1. Go to https://decathlon.github.io/vitamin-web/@vtmn/showcase-css/?path=/docs/components-overlays-snackbar--demo
2. Click on a demo button
3. See the snackbar appear and disappear after about 5 seconds
Expected behavior
We should be able to set the duration time

Hello Pauline,
Normally, you can totally control the display duration of the VtmnSnackbar on your own. Here is an example I made with @vtmn/react: https://stackblitz.com/edit/vitejs-vite-rnupye?file=src%2FApp.jsx

it works if you put a value smaller than 4,5 second, but if you put 8000 as timeout value the snackbar will still disappear after 4,5 second and not 8

Hi @Z26PGOBL, oh you're right, sorry!
That's a good catch. We take this feedback for our new implementation of Vitamin (currently inner source) & I've put this issue with "community" label. Feel free to contribute, I'll be there to review.
Thank you!


perf: variables.styl: remove unsued Taskview prefixes

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] It does not introduce a breaking change or has description for the breaking change

Can one of the admins verify this patch?


New version: Oracle.VirtualBox version 6.1.34

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

Well thats not good

@wingetbot run

@denelon what can be done about this kind of blocking-issue?
Would it be considered a bug?

• Unattended install: Improvements
• Windows guest: Make driver install smarter

Kinda weird how its not trusting Microsoft Windows Hardware Compatibility

@OfficialEsco, I don't think I've ever seen this before.
@JohnMcPMS do you have any clues on this one?

It's definitely signed by Microsoft: https://docs.microsoft.com/en-us/answers/questions/438415/driver-certification-on-windows-10-2016-server-201.html
I think the certificate they are using to sign it isn't shipped with Windows, which is why it's asking about it.

@denelon

@msftbot Blocking-Issue

@msftbot Interactive-Only-Installer


Want to buy a coffee

I really appreciate the work and timeyou put in to this app and would like to buy you a coffee. However, I can't find the link. Can you post it here?

Hi, you can buy me a coffee via this link: https://www.paypal.com/donate/?business=N6PWH859NY7W6&no_recurring=1&item_name=Buy+me+a+coffee&currency_code=EUR
Thank you!


LoginManager.token_loader removed from flask-login.

LoginManager.token_loader has been removed in flask_login in commit f4ff19c, but it is used in flask_user, causing an error like this in my app:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mostafa/source/dt/app.py", line 13, in <module>
    user_manager = UserManager(db_adapter, app)
  File "/home/mostafa/source/dt/venv/lib/python3.5/site-packages/flask_user/__init__.py", line 53, in __init__
    self.init_app(app, db_adapter, **kwargs)
  File "/home/mostafa/source/dt/venv/lib/python3.5/site-packages/flask_user/__init__.py", line 166, in init_app
    self.setup_login_manager(app)
  File "/home/mostafa/source/dt/venv/lib/python3.5/site-packages/flask_user/__init__.py", line 199, in setup_login_manager
    @self.login_manager.token_loader
AttributeError: 'LoginManager' object has no attribute 'token_loader'

I just removed the token_loader and it seems to work ok.

From CHANGES:
Version 0.4.0
Released on October 26th, 2016

Fixes OPTIONS exemption from login. #244
Fixes use of MD5 by replacing with SHA512. #264
BREAKING: The login_manager.token_handler function, get_auth_token method
on the User class, and the utils.make_secure_token utility function have
been removed to prevent users from creating insecure auth implementations.
Use the Alternative Tokens example from the docs instead. #291

Released in v0.6.9.


AIRFLOW-3508: add slugify env to build.sh script

See AIRFLOW-3508 Jira ticket
docker build script fails because of the existing areski/python-nvd3 dependency.
incubator-airflow/scripts/ci/kubernetes/docker/build.sh fails to start setup because of the existing areski/python-nvd3 dependency that requires python-slugify which installs unidecode (GPL) for its decoding needs.
The
python setup.py sdist -q
fails with the following error:
"By default one of Airflow's dependencies installs a GPL dependency (unidecode). To avoid this..."
Many experience the same issue, so its better to avoid it by adding SLUGIFY_USES_TEXT_UNIDECODE=yes env to install and use text-unidecode

Related also to : https://issues.apache.org/jira/browse/AIRFLOW-3400

Test are failing cos Cloudflare are having issues :(

ERROR: error pulling image configuration: Get https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/c1/c188f257942c5263c7c3063363c0b876884eb458d212cf57aa2c063219016ace/data?verify=1544687920-4x9vDIdsWCdPsFeS%2B%2FnKninhw50%3D: read tcp <IP_ADDRESS>:56400-><IP_ADDRESS>:443: read: connection reset by peer

What is this change needed for? Travis already sets that env var globally https://github.com/apache/incubator-airflow/blob/457ad83e4eb02b7348e5ce00292ca9bd27032651/.travis.yml#L25

@ashb
we need this change otherwise the build.sh fails - it executes the followig:
python setup.py sdist -q
and verify_gpl_dependency() in setup.py throws a runetime error

can we re-run the travis build as soon as cloudflare issues fixed? it seems like build failed for all PRs

Something on master broke the Kube tests - we're working on fixing/reverting that break.
But before that the Kube tests were running fine, so I'm a little bit confused why this change is needed? Where is this script being run from?

the kube tests are running fine because in travis this slugify env variable is set, see logs:
Setting environment variables from .travis.yml
$ export DOCKER_COMPOSE_VERSION=1.20.0
$ export SLUGIFY_USES_TEXT_UNIDECODE=yes
...
Anyway, as I said before, in order to run airflow on minikube its needed to execute the build.sh script as described in the following:
https://github.com/apache/incubator-airflow/tree/master/scripts/ci/kubernetes
see in the script, its executing the following command:
python setup.py sdist -q
which fails with the following error: "By default one of Airflow's dependencies installs a GPL dependency (unidecode). To avoid this..." - it happens because this env variable not set

@eran-levy , please take a look at the release note for 1.10(https://github.com/apache/incubator-airflow/blob/master/UPDATING.md) which requires setting this env.

@ashb @feng-tao thanks, see my last commit. I know the release notes (https://github.com/apache/incubator-airflow/blob/master/UPDATING.md), but still I think that whenever anybody wants to build a docker image for k8s deployment, we should provide him with the relevant env vars as part of the script to enable easy packaging.


Avoid unnecessarily restarting Bing Maps sessions

There was some confusion in a previous attempt to implement this, but now I think it works.

@kring I applied your review suggestions I think this is ready now. The only thing is the extraneous change in the one comment with the copyright sign, I can't tell why it's still marked as changed after I copy-pasted in the old comment.

Thanks @nithinp7!


[Apple Reminders] ...Menubar - filter by smart list

Extension
https://www.raycast.com/raycast/apple-reminders
Description
I have countless to do tasks in Reminders, and I've got it sorted out in 1 smart list for the day - the stuff that really needs to get done on that day (I filter by date, today or overdue, and if the task is flagged, and eventually by priority). It would be fantastic if the extension would allow to show just these filtered tasks, both on the menu bar part and the "normal" part.
Who will benefit from this feature?
Everybody!
Anything else?
Thanks! Really looking forward to it!

Thanks for the feature request! It's unfortunately not feasible for the same reasons described https://github.com/raycast/extensions/issues/11482#issuecomment-2025428313, so I'll mark this issue as not planned.


add void type in jd

Codecov Report

Merging #94 into release-0.2 will decrease coverage by <.01%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release-0.2     #94      +/-   ##
================================================
- Coverage          39.41%   39.4%   -0.01%
  Complexity           576     576
================================================
  Files                136     136
  Lines               4359    4360       +1
  Branches             313     313
================================================
  Hits                1718    1718
- Misses              2516    2517       +1
  Partials             125     125

Impacted Files
Coverage Δ
Complexity Δ

.../wecross/stub/jdchain/JDChainContractResource.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a9c63...b5d0323. Read the comment docs.


Switch the featured case study to SW in Production

R: @gauntface @PaulKinlan all
Swaps out CDS 2014 case study for the I/O 2015 as featured on the landing page.

+1, although this is likely to change again next week ;)

I would like this to be automated-a bug should be raised
On Thu, 15 Oct 2015 at 15:50 Paul Kinlan<EMAIL_ADDRESS>wrote:

Merged #2127 https://github.com/google/WebFundamentals/pull/2127.
—
Reply to this email directly or view it on GitHub
https://github.com/google/WebFundamentals/pull/2127#event-436471724.


Including the JS files?

It would be nice to add the js files into this package. Also, what version of jquery-ui is this using? I don't see it anywhere in the files.

This is only the styles and no more, and the installation goes through npm dependence on Jquery UI https://github.com/Alex5646/jquery-ui-sass/blob/master/package.json#L32


Manually update version number in README.rst

Updated the version number in README.rst so it matches the version
of the release.  Also corrected some documentation formatting errors
in gradebook.py
@pdpinch @bdero

The updated documentation can be viewed here:
http://pylmod.readthedocs.org/en/fix-pw-update-version-number-in-docs/

Ok. :+1: Are we going to follow a release process for this?


Fresh import from Asset store. Kills editor.  Every time.

This form is for reporting issues in the Twitter Kit for Unity library. For all other developer questions/issues about Twitter please visit Twitter Community.
Bug Report
We work constantly to fix bugs, tweak functionality and improve device support. Providing detailed feedback will help us to quickly resolve your issue.

Steps to reproduce the problem (include logs and/or sample code where appropriate):
Expected behavior:
Can import
SDK Version:
Latest
Unity Version:
2018 Beta b13
Device name and OS version:
Windows10 64 desktop build config

fresh import from Asset store.
Kills editor.  Every time.

reported.  Just in case it isn't you

Please try a stable 2017 release.

Re: (Case 1027026) The Editor crashed in FileAccessor::Read when importing Twitter Kit for Unity asset
Vxxx Lxxxs
Tue 17/04, 15:30You
Hey,
We have been able to reproduce this bug and have sent it for resolution with our developers.
We highly appreciate your contribution. If you have further questions, feel free to contact us.
Sincerely,
Vxxx
Unity QA Team


PROJECT MAINTENANCE.

I've been having a lot going on for a while now, and it's just not going to be easy maintaining this project as well.
If anyone wants to help maintain it, please feel free to contact me on twitter @anubra266.
There are lots of open issues right now, and I can't promise that I can fix them soon.
If the open issues are affecting your work's progress. I'll recommend React Aria's combobox. It handles majority of usecases, handles accessibility too. And an example built in chakra UI is here: https://codesandbox.io/s/dreamy-burnell-3i2jy?file=/src/App.tsx
I'm really sorry that I can't give more attention to this.
Thank you.

Hi @anubra266 ,
I'm using this library in a project in production, I'd like to continue using it, can I help to maintain it?
Let me know, thanks

Yes you can @Richi2293

Hi @anubra266
I would also like to help maintain the project.  I have opened a handful of PRs to fix some issues and add a couple of feature requests.  Let me know if there's anything else I can help with.  Thank you for this great package!

@Kysluss Can you send your email, I'll give you access to the repo.
Also your username on npmjs.com so you have permissions publish the package

@Kysluss Can you send your email, I'll give you access to the repo. Also your username on npmjs.com so you have permissions publish the package

Attempted to email you via your blog.  If you don't get it, let me know.  Thank you again!

@Kysluss I've sent the invites


Product should be added into the mechandise which is ProductVariant

The product variant comes within the product so, adding a product inside the variant again looks like a cycle. It should ba handled from the logical end

But that ProductVariant doesn't include the actual Product Title, If we access the title it gives the variant title which is different than the Product title itself.
BTW, I've added it in my repo. If it will require by any other person. I'll create PR


L2-norm for diagonal paths

Suggestion:
Please add the option to use the L2-norm (euclidean distance) for diagonal paths. It does not matter in those maze examples. But for more open environments, as shown in the example below, the path is not optimal on the L2-norm.

I fixed it by replacing the infinity norm with
// L_2 norm
inline float l2_norm(int i0, int j0, int i1, int j1) {
  return sqrt(pow(i0 - i1, 2) + pow(j0 - j1, 2) * 1.0);;
}

I am not sure if the * 1.0 is really needed, as I am not very familiar with C++.
I got it from here: https://www.geeksforgeeks.org/program-calculate-distance-two-points/

You might want to add that as an option and not replace it like I did.
Here is the result I got with this change:

This implementation follows the definition that the shortest path on the grid is the set of vertices (i, j) such that the sum of the values associated with the vertices in the set is minimized. The reason for this is that it was written for the purpose of extracting contours from images rather than uniform grids.
By replacing the L_{\inf} norm with the L_2 norm you are not changing the cost of the shortest path, but only the heuristic estimate of the path.  You'll still get the optimal path (it's still an admissible heuristic), but you'll pay for it in terms of efficiency because the L_2 norm doesn't eliminate high-cost paths as well.   Taken to the extreme, you could use the trivial heuristic of 0 and arrive back at Dijkstra's algorithm.
If you're only interested in uniform grids and prefer paths that resemble L_2 optimal paths, the simplest thing to do may be to break ties by adding non-diagonal neighbors to the priority queue before the diagonal neighbors (I haven't checked this – caveat emptor.)
But of course, if you're only interested in shortest paths on uniform grids, you should be using jump point search instead of A* :)

Thank you for your suggestion, I will take a look at jump point search.


ALT codes

Whenever I use characters with accents, the word 'clear keeps' being added to the field.
For example: When typing ALT + 0235, the word 'clear' appears after pressing the 3, followed by the 'ë' after pressing the 5.
https://i.gyazo.com/1102e229e5fa6bfb7ff987e097ab423d.png

OS: Windows 11 Home 64-bit
Browser: Opera, Edge and Chrome
Inputmask version: demo page & Inputmask-5.0.9-beta.45

I'm not able to input characters using Alt codes in Edge, Chrome or Firefox in any Inputmask field on my system. Which language is your OS?

It's set to English (United States).

Can you try to reproduce this on another PC?

On the PC, the ALT codes work appropriately on any other input field, no matter the website or app. And only on the inputmask fields, does it add the word 'clear', with the ë behind it.
On a laptop, the ALT codes work everywhere. No matter the website or app, except for the inputmask fields. Where it doesn't seem to even register the ALT functionality. It just outputs the numbers (0235).

OS: Windows 10 Home 64-bit
Browser: Firefox

I tested this with a very basic rule.
$("#field_name").inputmask({ casing: "title" });

Ok, the clear happens when you have numlock toggled, and type ALT + NUM5. I didn't know I had it active, and I never knew there was a ALT + NUM5 clear thing. Especially confusing since the ALT codes still appear.
ALT+ NUM2 and ALT + NUM 8 seem to be tied to scrolling through the autofill information, for certain fields. So, I'm guessing NUM0 turns into INS, causing for even more headaches.
Sorry for the inconvenience.

@daniel4ing ,
Version 5.0.9-beta.52 should fix the issue.  Can you have a try and give feedback.
Beste regards,
Robin

With the Numlock on and off, the ALT codes seem to work perfectly.
In the first few tests, there were still some issues when the NUMLOCK was deactivated, but after working with it for a bit, I've not been able to reproduce those same concerns before. The clear doesn't appear any more, but there were still some issues regarding the autofill becoming the prominent functionality of the field, but as stated, that seems to not be the case any more either.
I'll keep testing, and if any issues occur, I'll let you know. But it seems that you've fixed my issue :)

@daniel4ing ,
Ok great, I will close this issue then.


feat: add config that causes Serverless to halt if no .env file is found.

This change is very similar to https://github.com/colynb/serverless-dotenv-plugin/pull/34, but it was old enough that resolving the merge conflict was difficult, so I went with a new PR. This version of the change is backwards compatible and does not change default behaviour.
This change requires https://github.com/colynb/serverless-dotenv-plugin/pull/66 to work properly. The quality notes below were done with both changes.
Quality notes:

Functional:

Confirmed that if .env file is not found and custom.dotenv / custom.dotenv.require / custom.dotenv.require.file is not set, Serverless continues without issues
Confirmed that if .env file is not found and custom.dotenv.require.file is set to false, Serverless continues without issues
Confirmed that if .env file is not found and custom.dotenv.require.file is set to true, Serverless halts

custom.dotenv.require.file not set:
Serverless: Load command upgrade
Serverless: Load command uninstall
Serverless: DOTENV: Could not find .env file.

custom.dotenv.require.file set to true:
Serverless: Load command upgrade
Serverless: Load command uninstall

  Error --------------------------------------------------

  Error: DOTENV: Could not find .env file.

Sorry for the delay. I have updated the pull request based on our discussion and updated the testing notes in the pull request description.
This pull request is ready for a re-review when you haev a chance @colynb.


Update to "Dumpping SPI Chip Contents (your current BIOS)" in the PDF

When I was dumpping the bios content via this command
flashrom -p linux_spi:dev=/dev/spidev0.0,spispeed=10000 -r z620_bios_1.bin
then take sha256 I was not able to get same sha256 on multi runs of the above command!
I tried the repining many times and never worked! which puzzled me as I was I able to communicate with the chip why it's not fetching same content!
I then changed the speed to spisped=5000 and to my surprise it worked from first time (without even reconnecting the pins or the clamp!)
I tried 5 times and I get same sha256 every time! and you may think reducing the speed to 5000 may take ages, it didn't (it took a bit longer but was not significant)
So I recommend changing the speed of reading and writing to spisped=5000 instead of spisped=10000

Forgot to say my thanks for the guide as I was able to successfully upgrade my z620 to v2 (with the mod mentioned in here) 🙂
Cheers

@EazyServer
No clip approach
https://github.com/bibikalka1/HP_Z420_Z620_Z820_BOOTBLOCK2013_BIOS_mod


Slot support?

Hello,
preactement supports the slots?
Example:
In the HTML (DOM):
<slot name="test">test1</slot>

In the component JSX:
<slot name="test">test2</slot>

Both are displayed.

Hi @Nicolab,
As of right now, <slot /> is not supported. If you could explain how you would like these to work, and what you're trying to solve I can look into supporting them.
Thanks!

Hi @jhukdev,
Thanks for your reply.
I use the custom element (Preactement) to render on the server side the raw HTML, then take over with the front. Example (ideally):
  <x-article articleId="1">

<slot name="title">Article title</slot>

<slot name="content">Article content</slot>

  </x-article>

  <x-article articleId="2">

<slot name="title">Article title 2</slot>

<slot name="content">Article content 2</slot>

  </x-article>

This could also have the form of
Article title 2
, why not, it's shorter.

The article title and/or content can be edited in Article component (<x-article> tag). With a onClick, a form is displayed and after the submit, <slot name="title">{state.title}</slot> and/or <slot name="content">{state.content}</slot> should be rendered instead of the original content rendered by the server.
There are plenty of practical uses that would bring another dimension to deal between static content returned by the server and dynamic content generated by the front end (including REST requests, user interactions, ...).
preact-custom-element could do this but it renders 2 times the content of slots and props.children. This makes it impractical to handle static server-generated content via front-end dynamism.
There are some closed issues on preact-custom-element about this, but it is advised to go through the shadow DOM, which I want to avoid to not mess me with the CSS (especially with CSS frameworks that have no effect on the shadow DOM. It seems that this behavior will not be changed in preact-custom-element.
preactement works as desired, if there is slot support it would be perfect :rocket:
* I hope I am clear, my English is not great

Hi @Nicolab,
Thanks for taking the time to outline what you're looking for.
This sounds totally doable, I've noticed the code in preact-custom-element that handles <slot />'s, so based on your description above, I should be able to get a PR together from this.
When I get some time, I'll make a start on this. I'll ping you here with an update 👍

Hi @Nicolab,
Just so I'm clear, I see that preact-custom-element is assigning the value of the element with a slot attribute to the components props, e.g:
https://github.com/preactjs/preact-custom-element/blob/5790765ec0227ebb16add2f1469aef648e9f9f9e/src/index.js#L154
const example = `<x-article><span slot="testSlot">Hello</span></x-article>`;

/*[...]*/

function Article({ testSlot }) {
  console.log(testSlot); // <-- Will equal element value, e.g "<slot name="testSlot">Hello</slot>"

  return (

      {testSlot}

  );
}

Is this correct?

Excellent, thank you!

Will equal element value, e.g "Hello"
....
Is this correct?

Yes, I'm pretty sure that this is the same behavior.

https://github.com/preactjs/preact-custom-element/blob/master/src/index.test.jsx#L139-L164
https://github.com/preactjs/preact-custom-element/blob/master/src/index.test.jsx#L170

This requires a little trick if we want to get the content only (Hello here) but it looks fine!

@Nicolab Hey!
By popular demand, a working PR with slot support:
https://github.com/jhukdev/preactement/pull/5
This works in a few ways (to my preference, tell me if I'm wrong!). I've allowed the slot value to be either a string primitive if that's the only content type (saves having to parse VDom), or a VDom tree if there's some more complex HTML structure within.
I've outlined a couple of examples below.
Primitive String
/**
  * Example HTML custom element
  */
<x-article>
  Hello
</x-article>

/**
  * Example component defined as <x-article />
  */
function Article({ testSlot }) {
  console.log(testSlot); // <-- Will equal string primitive "Hello"

  return (

      {testSlot}

  );
}

VDom Tree
/**
  * Example HTML custom element
  */
<x-article>

    Well, Hello!

</x-article>

/**
  * Example component defined as <x-article />
  */
function Article({ testSlot }) {
  console.log(testSlot); // <-- Will equal VDom "Well, Hello!"

  return (

      {testSlot}

  );
}

Let me know what you think, and whether this is something that would work. It's also worth noting that the <* slot="{key}" /> elements are removed from this.props.children to avoid duplicate content, or having to mitigate that.

Very nice. Yes, I prefer this way because it's more clean and flexible. We are able to get only the content Hello without element, it's handy. We can also get all elements if we want.
It's perfect, thanks! :+1:

@Nicolab Ok, merged and published:
https://github.com/jhukdev/preactement/releases/tag/1.6.0
Let me know how you get on 👍

@Nicolab I'm going to mark this as done, let me know if you have any issues.
Thanks for the suggestion!

Hey, sorry I didn't see your messages. I have seen the demo, this is perfect, thank you very much! Really :+1:
I will integrate in my projects after the holidays :smiley:
Have a good end of year!


shameless plug: use db-hafas JavaScript lib

Hey, just came across your project. Is it deployed somewhere to check it out?
db-hafas is a JavaScript client for the Deutsche Bahn mgate.exe API. Based on hafas-client, it has been used for years in several apps, supports many HAFAS features, and – most importantly – covers many edge cases.
In https://github.com/kennell/schiene/issues/1#issuecomment-445468008, we've discussed on how you can use it with a language other than JS: spawn hafas-client-rpc with the stdin/stdout transport and send JSON-RPC from your Python code.
I'm aware that using a lib with another runtime (Node.js) is somewhat ugly, but given a complex, barely documented and ever-evolving system like HAFAS, we should try not to re-implement HAFAS clients everywhere.

I can see that you started writing a separate Python lib: pyhafas.
Even though this is another project that needs to keep up with the constant stream of changes of HAFAS endpoints, IMHO it is worth it to let Python projects access HAFAS data in a reliable & future-proof way. 🎉
There are lots of hidden pitfalls with HAFAS systems, and many reasons why the hafas-client repo has the structure that it currently has. I'd like to share them and collaborate with you!
There are now 4/5 projects that try to become general-purpose "access layers" to HAFAS:

public-transport-enabler – oldest project, written in Java, core behind the Öffi Android app; covers HAFAS & non-HAFAS endpoints, but doesn't support many HAFAS features
TripKit – recent project, written in Swift, core behind the ÖPNV Navigator iOS app
marudor.de – written in Typescript, tightly coupled with its HTTP API & website; Deutsche-Bahn-focused, combines multiple APIs, supports many HAFAS features
kpublictransport – written in C++, fetches public transport data for KDE Itinerary; aims for worldwide coverage, HAFAS is one of its backends
hafas-client – written in JavaScript, medium-aged; used by many other public-transport libraries that I wrote; supports only HAFAS systems, but many of their features

To the first question: There is a deployment on fahrplandatengarten.de, but it's WIP
The second question is @n0emis task

https://community.kde.org/KDE_PIM/KPublicTransport/Endpoint_Configuration


fix unit tests related to new serialization api

Description

This PR updates dbt-spark to use new serialization API that is the result of using Mashumaro in dbt-core. It also addresses failing unit tests as a result of updated the dbt-core version to 0.19.1b2
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

This looks good, but unfortunately the Mashumaro likely solution for handling omit_none columns is to go back to using 'omit_none', something which I'm going to switch to in dbt core this week. We might want to wait for a few days for that.

@jtcohen6 100% agree, I'm interested in how we create and enforce this contract in core for different plugins. Will keep this in mind

@gshank will the changes involve just renaming keep_none to omit_none? If so, I'm happy to merge this as is so we can release dbt-spark 0.19.1b2 and update the code with the mashumaro changes once they are merged. Let me know if that is not the case, I will hold off from merging

Decided to merge this, I'm happy to update with any 0.19.1 changes


Group names aren't unique

I have tried and created the same group twice with the same exact data, this is very confusing as there's no way for users to know each and all different groups.

@ArisTsevrenis We spoke about this request on standup today and have agreed it makes sense to change the default server behaviour to require unique group names rather than just group id determine uniqueness. We'll make this change as part of the 0.12.0 release of the server.

Agreed, User IDs and handles are a good precedent for that and exist for the same reasons. I think that pattern makes sense for Group IDs and names as well.

Added in https://github.com/heroiclabs/nakama/commit/a3f6988b264fb6f6c8ebb6ef7d998bc9469a2133.
@ArisTsevrenis You will have to wipe your database and reapply the migrations for this to take effect. You should run nakama migrate redo with the newest Nakama release which will be out shortly.


Does it work for flutter web

Tried using it for flutter web, keeps throwing errors
    final clientOptions = ably.ClientOptions(key: 'api key');

// Use ClientOptions to create Realtime or REST instance
    ably.Realtime realtime = ably.Realtime(options: clientOptions);

    ably.RealtimeChannel channel = realtime.channels.get('channelname');

    StreamSubscription<ably.Message> subscription =
    channel
        .subscribe()
        .listen((ably.Message message) {
      print("Got a message");
    });

@microcoder-py current SDK doesn't support web : (

You can check #95

Closing the issue in the interest of duplication. You can continue the requirement on https://github.com/ably/ably-flutter/issues/95


Updated system routes

A portion of https://github.com/ethyca/fidesplus/issues/681
Part of the requirements for that ticket were:
/add-systems/new -->  /add-systems/manual
/system --> /systems
I split this part out because for the most part this is just a refactor, but it touches a lot of files, and I thought it'd be easier to review this way.
I'll make another PR to do the actual work of giving systems their own page.
Code Changes

[ ] Rename /add-systems/new -->  /add-systems/manual and all references to those paths
[ ] Rename /system --> /systems and all references to those paths
[ ] Use constants for these paths as much as possible instead so that if we have to change these in the future, it'll be in the one place.

Steps to Confirm

[ ] Everything hopefully works the same as before

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

Description Of Changes
Write some things here about the changes and any potential caveats

Oof I just realized this requires a plus change too to make sure the nav redirects to the systems page properly. will make a separate PR in plus


rename ds-load exec to import

This changes ds-load exec into ds-load import but does not update the providers; for example, ds-load-auth0 is still named exec, the lack of symmetry does not make sense to me, we either rename all exec to import or none.
@ogazitt since you requested this change and you cast your opinion on this?

I like the symmetry of using import for both ds-load and ds-load-*.

In plugins, the exec commands combine fetch and transform, but it does not load data in the directory. Renaming it to import might not be the best option.
Do we still want to keep the exec command and rename it or remove it altogether from the plugins?


Add sidenav tag filtering

Bug/issue #, if applicable: 88001866
Summary
Allows filtering in the sidebar, using a pre-defined list of Tags
Dependencies
NA
Testing
Steps:

Serve a doccarchive that has articles or tutorials
Click on the filter and select Tutorial or Article tag
Assert only those are shown + their parents are open

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@swift-ci test

@swift-ci test


clarify concepts of levels in EBML context

As discussed here https://github.com/Matroska-Org/ebml-specification/pull/3/files#r29920563.

started to do this here: https://github.com/MediaArea/ebml-specification/commit/d27d4a3f266bb4907e0a95431e48b2db2eeedd5b

I think this issue was resolved here: https://github.com/Matroska-Org/ebml-specification/blame/master/specification.markdown#L191


Can't write "input function" using typewrite()?

I want to input password through input function.
x = input('password: ')
pyautogui.typewrite(x)
However, this results to error.
OS: Windows
Python: 3.8

This works for me on Windows 10 and Python 3.7.4. Could you elaborate on the error message that you saw?

This seems to work, and unless I can find further information or repro steps, I'm going to close this issue. Thanks for filing it though.


Error.captureStackTrace is not supported by firefox

https://github.com/apache/incubator-openwhisk-client-js/blob/master/lib/openwhisk_error.js#L7
this line assumes that Error.captureStackTrace is defined. it is not on Firefox, and perhaps in other browsers. i suggest that we at least protect against it being undefined.

Interesting, I hadn't even thought about using the library from a browser, does it work? PR LGTM.

yes indeed. the only limitation i see at this point is here:
https://github.com/apache/incubator-openwhisk/pull/4010

This is now fixed.
https://github.com/apache/incubator-openwhisk-client-js/blob/master/lib/openwhisk_error.js#L21-L24


8 add 500 server html

#8 create 500 server down page
[x] add html
[x] add css

It can be made better. Include name of website and little improvement in design would make it good.

okay will do!

how about this one? if there are still need some improvements just tell me

include homepage yellow background and only go back button
I would suggest you to use bootstrap to make sure it is responsive, or you can do by making a copy of homepage code and working on it.

oh okay i'll try

I already made the content with boostrap, please review it and notify me

LGTM :+1:
It will work fine for now.


Rancher crashes when navigating between local and downstream clusters

I saw this error in the latest version of master. To reproduce,

Provision a downstream RKE2 cluster in Rancher.
Using the hamburger menu in the top left corner, navigate to the local cluster.
Using the hamburger menu in the top left corner, navigate to the downstream RKE2 cluster.
Rancher crashes with the error Cannot read properties of undefined (reading 'spec').

The workaround is to refresh the page.

That's a developer only crash page. Is there a juicy stack trace in the console?

There's a stack trace in here https://github.com/rancher/dashboard/issues/6324#issue-1301407146


Added Workiva

The application had minimal text entries, took well under 5 minutes!

Thanks for the PR! Could you instead link to Workiva's main career page?

Yep - added!

Merged in! Thanks for contributing and your fast replies :)

And ironically this was my slower reply :). Absolutely, this is a great idea for a repo, I'll try to contribute others as I come across them.


Feature: Start to authenticate with Chainguard registry.

:gift: This change adds setup-chainctl to start authenticating with our registry.
A subsequent change will start to take advantage of this, but we want to try authenticating as the first baby step.
/kind feature

I still can't get over how easy that is.


Make it easier to copy code blocks

While reviewing ticket #252  we debated the best way for users to get examples of conda package yaml files.
I realized that a copy button on code blocks would be useful like many other online platforms have.
There is an extension for sphinx https://sphinx-copybutton.readthedocs.io/en/latest/ but I don't know what steps are required to make it work with ReadTheDocs
Acceptance Criteria:

[x] Determine a ReadTheDocs compatible method for adding a copy-button
[x] Implement the feature

example: https://docs.maap-project.org/en/code_copy_button/science/GEDI/GEDI_L2A.html


torchvision.roi_align does not support TPU

Hello.
We are using TPU in GCP.
We are currently modifying the code to allow the TPU to return to Detectron2.
However, there is an error that roi_align in Torchvision is not supported by TPU.
Please check the bottom. Can you solve it for me?
File "/anaconda3/envs/torch-xla-1.7/lib/python3.6/site-packages/torchvision/ops/roi_align.py", line 51, in roi_align     return torch.ops.torchvision.roi_align(input, rois, spatial_scale, output_size[0], output_size[1], sampling_ratio, aligned) RuntimeError: Could not run 'torchvision::roi_align' with arguments from the 'XLA' backend. 'torchvision::roi_align' is only available for these backends: [CPU, BackendSelect, Named, AutogradOther, AutogradCPU, AutogradCUDA, AutogradXLA, AutogradPrivateUse1, AutogradPrivateUse2, AutogradPrivateUse3, Tracer, Autocast, Batched, VmapMode].

@CheonJiEun currently torchvision do not provide any support for TPU. Certain ops (like transforms) could work out-of-the-box, but others not.
cc @fmassa for more details.


New branch

Newly integrated functional modules related to the FFA-NET model and the repo has been modified as submitted

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Newly integrated functional modules related to the FFA-NET model and the repo has been modified as submitted, fixed some small bugs.

还有加一下tipc


Question about hibernate reactive release schedule

Hi,
Our team is trying to build hibernate in the reactive application.
We have checked hibernate-reactive and seem nice to use.
but we also notice that it still in alpha release.
Does anyone have a rough idea of when will have a 1.0.0 release?
Thanks

Not precisely at this stage. But I can explain our thinking.
Right now we are doing performance testing to validate that we can reach interesting scalability models (better than Hibernate blocking). That will validate our work.
Then we will have a relatively long period of feedback on the API (what’s missing, what should be improved etc). As this is new territory for a lot of people.
If you already have feedback, I’d love for you to send an email to the hibernate-dev mailing list. The team will appreciate it a lot.

Cc @gavinking

Cc @Sanne

Come to think of it, you can put your feedback here. Let me reopen it :)

Hello @emmanuelbernard
I am with @semistone , we are testing the lib and it looks quite good.
I guess the main thing which disturbs us is the non-support of the @Version annotation for the optimistic lock management and ... the fact that is not released yet :)

Welcome @avillev and @semistone :)
I saw your forum questions as well, sorry for the delay.

I guess the main thing which disturbs us is the non-support of the @Version annotation for the optimistic lock management ...

I'll assume that's #201 ? I think we can handle the internal changes needed to support it, but it would be really helpful to get your input to define the API and semantics.
Regarding release timelines: we've been releasing many Alpha releases recently on an "as needed" base for our own testing and integration needs. But things are looking good now and I suppose we could switch to regular Beta releases, and work on a proper project announcement.
So you can already find e.g. org.hibernate.reactive:hibernate-reactive-core:1.0.0.Alpha6 on both JCenter and Maven Central; I assume you're asking for a "Final" stable release?
To make it a "final" release I'd hope to have more user feedback; TBH this is the first time someone not from our immediate team seems to have tried it out - which is great as we hadn't announced the project yet!
Some ballpark estimates:
You might have noticed the project development slowed down a bit; the reason is we're focusing on benchmarking and load testing to verify some aspects. I expect after that - so in a couple of weeks? - we'll be able to announce the project and then we might need ~2 to ~3 more months of community feedback and API polishing to make it final.

Hi. I think you’ve misinterpreted #201. The @Version annotation and optimistic locking in general works perfectly well as far as I know. What’s described in #201 is something very specific: a feature of JPA that i’ve never used myself and I doubt many people use.

Thanks for your reply.
let me share our testing result of comparing different SQL client libs
1000 QPS with spring webflux
simple select query return 3 records only
connection pool: 16
| r2dbc | r2dbc+spring | vert.x | hibernate rx + vertx | hikari + jdbc | hibernate old + hikari + jdbc
-- | -- | -- | -- | -- | -- | --
mean | 6 | 10 | 4 | 2 |2 |5
99th pct |  59 | 75 |  8 | 5 | 21| 72
95th pct | 39  |56 | 6 | 3 | 3 |7
75th pct |  3 |3 |4 |3 |2 |2
50th pct |  2 | 2 |3 |2 |2  |2
system| 7.8 | 12 | 8 | 7 | 6.7 |14
process | 3.6 | 3.6  | 3 | 2.8 | 3.1 |4
threads | 114 | 132 | 83 | 75 | 103 | 150
in 1000 QPS, active connection about 13 (R2DBC metrics)
in 3000 QPS, all failed due to connection pool size.

@gavinking
Good to know for the optimistic lock. That is great news.
Thanks to @semistone 's table up there you can see that the rx hibernate api is faster than the other alternatives.
At that point, I think the only limitation we have is ... that it is an alpha :).
At least the JPA part of the interfaces would not change (annotations and stuff). But I guess the main concern would be stability. Of course if we choose to use it, we'll probably have a lot of feedback to do.

Nice data, thanks a lot for sharing. That looks indeed encouraging; now of course that might change as we stabilize, but I suspect it might improve as we've been analysing our results and identified some issues, such as the fact that we're using a sub-optimal connection pool.
We didn't share our benchmarks yet as it's usually a bit tricky to get people to not take those numbers too seriously, when we're still making many changes - but I look forward to share it all soon. FWIW, we're focusing on "fully reactive systems" end-to-end: it should make the benefits more visible when you have both a web front end modelled using a reactive technology, all the way to the DB. You'll soon be able to see one such example in the Quarkus quickstarts repository - it's not there yet but it will be in a few days.
Regarding "stability" : I suppose you mean API, such as us stopping to move packages? Stuff is certainly getting more stable now.

Thx @Sanne
We decided to give it a go for the next months. We are using it in a Reactive Spring webflux application.
Worst case scenario we could roll back to a blocking hibernate if everything fails :).
But anyway, you can expect some news from us in the future.
I guess we could close that issue ?

Great, thanks @avillev


Update README.md

Specifying Pip version will be more suitable for people with older versions. Feel free to change minimum pip version requirements. Recommended version is 10.1,

I believe pip version 10.1 doesn't support the manylinux format, so some linux distros might not work with it. Too much hassle to see which is actually the minimum pip version.


action triggered on connection to relay

not sure if this is something you can help with, but here goes:
as soon as i connect the relay to the garage door trigger (COM and NO), it triggers an action. at this point, i can control the garage door via MQTT, but the physical button stops working. i am not sure if i'm connecting something wrong, but this happens even if the relay is not corrected to power. and i've tried it with 2 different relays.
help. please.

Strange, normally this would happen if you connect the wires to COM and NC, maybe the relay is broken. Test it with a multimeter, there shouldn't be continuity between COM and NO (when the relay is not powered).

I had this same issue.  My relay was active-low (which I didn't realize) and I hadn't set ACTIVE_HIGH_RELAY to false.  I updated the .h, uploaded the new sketch and it worked perfectly (physical buttons work again).

I had this same issue. My relay was active-low (which I didn't realize) and I hadn't set ACTIVE_HIGH_RELAY to false. I updated the .h, uploaded the new sketch and it worked perfectly (physical buttons work again).

That just saved my day. I was in the same case using an ESP-01/01S
And here is how to set ACTIVE_HIGH_RELAY to false in ESPHome: https://esphome.io/components/switch/gpio.html#active-low-switch
Thank you!


Changing syntax highlighting

Hello there! I have just started using this theme and I have noticed that the base syntax highlighting is very lacklustre. The language which I use the most and which will be featured the most on the site, C#, has only 3 colours, and the comment colour and the actual code have the same colour, making it look horrible. I have already tried changing the syntax_highlighter option in _config.yml to coderay with no dice (I added the gem to Gemfile, the gem seems to work there is just no difference in syntax highlighting)
Thanks!

Thank you so much for reaching out, I'll try my best to fix this asap.
If you find a solution feel free to make a PR

In the meanwhile this could work:
{% highlight csharp %}
/// <summary>
/// Main class of the project
/// </summary>
class Program
{
    /// <summary>
    /// Main entry point of the program
    /// </summary>
    /// <param name="args">Command line args</param>
    static void Main(string[] args)
    {
        //Do stuff
    }
}
{% endhighlight %}

I came up with this 2 things:

The easiest one is to change the rouge highlighting via rougify
Or manually edit the /assets/css/syntax.css

alright, Ill try that!


Exception thrown with Laravel 7 when running php artisan test

After following the installation guide, I was trying to run my tests with php artisan test. This triggered the following error:
> php artisan test

  RuntimeException

  Running Collision ^5.0 artisan test command requires Laravel ^8.0.

  at vendor/nunomaduro/collision/src/Adapters/Laravel/Commands/TestCommand.php:71
     67▕         }
     68▕
     69▕         // @phpstan-ignore-next-line
     70▕         if ((int) \Illuminate\Foundation\Application::VERSION[0] < 8) {
  ➜  71▕             throw new RuntimeException('Running Collision ^5.0 artisan test command requires Laravel ^8.0.');
     72▕         }
     73▕
     74▕         $options = array_slice($_SERVER['argv'], $this->option('without-tty') ? 3 : 2);
     75▕

      +14 vendor frames
  15  artisan:37
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

At the moment of writing this report, Laravel 8 is not yet released, so I cannot simply update Laravel.
I can run my tests with ./vendor/bin/pest but it would be great if I can just use the built-in artisan commands.

Yeah - no plans for having Collision supporting two versions of dotenv dependency.
You can run ./vendor/bin/pest directly.


Check account status

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

...beneficiaries/operations/check_eversend_account.rs
100.00% <100.00%> (ø)


Providing fast NS lookups: evaluating provider records, querying strategies

The underlying DHT (utilizing the libp2p Kademlia DHT spec) allows peers to query by a TOPIC for a RESULT, or query by TOPIC for all PROVIDERS that have RESULT. In the name system, we use a sphere's identity (DID) as a TOPIC and expect a UCAN auth token (or CID, TBD) as the RESULT, that can be verified and resolved into the sphere's latest revision (CID). DHT nodes handle these queries by sharing key/value records between peers. These records can be interpreted in two ways:

Value Records: The value is the RESULT. Using Value Records is a push model, where the RESULT is propagated to peers.
Provider Records: The value is a PROVIDER (specifically PeerId and Multiaddr) that provides RESULT. Using Provider Records is a pull model, where a node announces it has the RESULT for TOPIC by propagating that record to peers. Nodes querying in this model query for a list of providers of this record (discovery), and can subsequently dial each other. The process of retrieving RESULT from PROVIDER is outside of the scope of the DHT's spec, though the rust-libp2p implementation allows us to hook into this via e.g. Bitswap

Currently, the name system uses Value Records for simplicity as we shape out how the system works. The DHT RESULT is a UCAN token verifying a sphere's key delegate with "sphere/publish" capabilities, along with the final value the name system is responsible for, the sphere's revision address. When a new revision is published, the gateway/NS hosts and sends the new record to its peers, and in intervals to possibly different peers. Currently in the v1 name system, querying the network for results, we grab the first valid record we can find (which in small networks, may be already on the node) -- though there may be many valid/verifiable records for a single identity within TTL. We may want several options during lookups specifying just wanting the first record found (fast!), versus waiting for 3 or more and taking the latest. There's no guarantee that there's not a newer revision that has not yet been discovered in either case.
Using provider records instead, as pragmatically only a sphere's corresponding gateway would be propagating records, could mean a single PROVIDER for a TOPIC. As the actual RESULT is pulled on-demand, the gateway with fresh records will always be the found peer, e.g. fresh results when querying outside of the local cache. This does of course require the gateway to be always available, and still possible for other nodes to announce themselves as providers for the same records a gateway is hosting.
It could be possible the gateway's key has "sphere/publish" capabilities to sign the UCAN auth token, which lowers resilience a bit if permission is needed to be a PROVIDER. There may be an alternative where each gateway must sign its records (only to bind token to gateway, no auth) wrapping the underlying sphere-blessed publish token. This would look like, in the scenario of a non-updated sphere, multiple providers with unique tokens (signed by gateways) containing the same underlying sphere-signed token with identical sphere revision address. In the case where underlying sphere revision address differs, the original sphere's authority could specify the gateway's key, not to restrict permission to publish, but for tie-breakers in record resolution, opting for the token from the "definitive source".
This is getting long, but after thinking through the last part, we could add some facts to the UCAN token with the gateway's key, which should be resolvable into a PeerId e.g. directly addressable via the network. Even using the current Value Record implementation, adding the gateway's key to records could result in the experience of fetching records from peers like currently, and if wanting to confidently get the latest revision, take the gateway key from a possible stale record, and directly dial the gateway for the latest (and storing it, strengthening the network).

Just linking to few possibly relevant threads in regards to naming systems

IPNS over PubSub proved to be far more reliable and faster option than IPNS over DHT. IPFS uses both (as some records may not be published over IPNS) but last time I checked pubsub was clear winner.
Fast lane IPNS was a proposal that never got to be implemented, yet might be worth a consideration. tldr; Names update are frequent, but who we trust to keep them up to date is far less frequent. Instead of publishing new name records, name owner could publish address where latest record can be read. That way name record updates are point-to-point with transactional guarantees and record holders can still be decentralized and updated through more resilient means like DHT. Furthermore agents could cash name holder addresses permanently.


AppImage not starting on Debian Sid

Bug Report
App Version: sleek-1.3.1.AppImage
Platform: Debian Sid
Installation Method: Direct Download
Bug Description:
$ ./sleek-1.3.1.AppImage
dlopen(): error loading libfuse.so.2

AppImages require FUSE to run.
You might still be able to extract the contents of this AppImage
if you run it with the --appimage-extract option.
See https://github.com/AppImage/AppImageKit/wiki/FUSE
for more information

libfuse2 is still available in repos, but the default is libfuse3-3
Steps to Reproduce:
See above
Expected Behavior:
App starting
Actual Behavior:
App doesn't start
System Information:

OS Version: Debian Sid
Processor: Intel® Core™ i5-8250U × 8
RAM: 8GB
Graphics Card: Intel® UHD Graphics 620 (KBL GT2)

Reproducibility:

Works in Debian Stable, not in Debian Sid (I did no tests on other linux systems)

Impact:

?

Thanks for the report. Can I ask you to check the AppImage of the latest developer preview of v2.0? https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev9
It's built based on significant new dependencies. I'm curious if the issue persists.

@ransome1
Same issue with v. 2.0

mmhh I dont know. But if it runs on Debian Stable and asks for FUSE to be required but not found on Debian Sid, doesn't it indicate that there is something missing on Debian Sid? I wouldn't know how to fix this in sleek.

@ransome1
Yes, I think that it is missing libfuse2, replaced by libfuse3-3.
libfuse2 is still available in Debian Sid repositories: https://packages.debian.org/it/sid/libfuse2
Here its history: https://tracker.debian.org/pkg/fuse
The question is: how long will it be available?

Ok! This is not a bug strictly speaking.
I don't know if an AppImage can be build to work with fuse3. If so, consider what is best to do, otherwise, please close this bug report,
Cf. https://docs.appimage.org/user-guide/troubleshooting/fuse.html
Many thanks in any case,
Domenico

I'm not actively deploying FUSE so I assume it's a dependency Electron Builder (within my building pipeline this creates all the releases of sleek) use to build the AppImage. There is probably nothing I can actively do about it. But if anybody proves me wrong I'm happy to adjust sleek. But as for now I hope you understand I can't make research on this a priority for me. I'm happy to keep your report in the backlog though.

@ransome1
Yes, sure! I understand!
In the meantime, I can confirm that installing libfuse2 solves everything.
We'll see what the future holds for us. :smile:

@Doc73 shall we close here? I don't think there is anything I can do about it.

Yes! You can close this issue.
If you want, you could add somewhere here the suggestion to install libfuse2.
When one day libfuse2 will be completely missing from the repositories, well!... then we'll see whot to do! :smile:


Allow enabling HTTP, the default is off

I have opened backports for this:

https://github.com/openshift/library-go/pull/1588
https://github.com/openshift/library-go/pull/1589
https://github.com/openshift/library-go/pull/1590
https://github.com/openshift/library-go/pull/1591


Code improvements and settings module

Improved some logic in different areas of the codebase, fixed some flake8 issues and created a module to store settings and definitions to be used across the the project.
Still have to go through other files, but i'm submitting this PR since it can conflict a lot with other code and it would be good to get it merged as soon as possible (if you like the changes).
Please let me know if you want to change anything.
I also couldn't test everything, so you should probably merge it locally and test it before.

Sorry about that, totally forgot to stage the settings file.
The imports, spacing and all "style" related changes are pep8 friendly (pep8 is a style guide for python code), and it is pretty good to follow it.
I still want to go through the whole codebase and improve whatever i can, but i made the changes during a work break and didn't want to hold them.. The chances of conflicting code when changing styles and those kind of things is big.

Also just saw that we could simplify a lot the logic behind the key_check function.
Please make sure you test the code before merging it, i can not fully test it cause i'm not on my PC.

Genuinely curious where in PEP 8 the parenthesis on the imports are? I assumed you were following PEP 8, but just never seen the parenthesis in PEP 8 I must be missing out on something.

It's one of the ways to import many things from one module. I usually use cause the number of things you import normally grows and will need to go to the next line (If you follow the nax characters per line, of course).
Anyway, if the parentheses are the only thing blocking the PR to get merged, i can commit the removal of them.
Please let me know :)

For mac, If you use PIL to take screenshot, it will take almost 1 second to grab the image and use imshow to display, but if you use os.system("screencapture -x -R 0, 40, 800, 600 screen.png") then use imshow to show the picture, it will be much faster, approximately 10 frames per second.

This is unfortunately one of the worst experiences i've had when trying to contribute to something. @Sentdex any feedback or conclusions on this?


Go To implementation

Implements the Go To Implementation function.
If there is just one result, navigate to the implementation. If there are multiple, load up the results into the Find window.
My only question is what the keybinding should be. Looks like the Sublime version is win-l, which doesn't seem ideal. Any ideas?
Closes #12

@sgwill  / @david-driscoll  - can you guys look at getting this changed over to TS?

This should be complete, now.

Works great! Tested on an interface with a single implementation and one with multiple implementations.


Enable placing ProxyActor to specific Nodes

ProxyActor need a external port to send / recv RPCs across parties, and in many senarioes, the port can only be opened on certain Nodes for safety reasons.
However, as a Ray Actor, the inner proxy actor is hidden by RayFed and can't be explicitly placed.

The solution is: using ActorClass.options to declare ProxyActor's resources so that it can be scheduled (by Ray) to certain Nodes having that resources.
The plan is:

[1/N] Gives a parameter to set ProxyActor's resource.
[2/N] As there're too many ProxyActor related configs in fed.init, merging them into one "XXConfig" entity and exposing as a whole to user.


Fix the calculation of a non-integer block number

If the last_updated_block column contains None values, then max returns a value of type float.
The caller should therefore verify that this value is nevertheless integer, and then convert it to type int.
Note that this PR also includes a technical refactoring of function get_start_block, aimed at simplifying the logical flow in this function, as well as the removal of log messages in this function (which were designated for the investigation of the non-integer-block-number issue).

Couple things:

Let's add sub-functions (similar to int_max()) which handle each logical condition separately in a way that can be more easily unit-tested for each case, and include the corresponding unit tests for each case.
There needs to be handling for the case when the current_block - last_updated_block > 2000, in which case the correct return value should be current_block - 2000. Without this handling, alchemy will throw errors and we cannot assume frequent events occur on obscure blockchains.

OK, but there are two issues regarding the 2nd bullet:

This is a logical change, which is outside the context of this PR, so it should probably be handled on a different PR.

The 2000 constant might be relevant for Alchemy but not for other providers (and in fact, even for Alchemy it may change occasionally as a result of new subscription-rules, or perhaps depending on the subscription-plan of each specific bot user, and so on). So it should not be forced here in this way, and perhaps it should not be forced here at all, but rather at a different point in the program, when blocks are actually fetched (for example, at the point where the program is about to fetch 8500 blocks, it can split that into 4 consecutive iterations of 2000 blocks each, followed by an additional iteration of 500 block).


Missing indicator in flatpak

Hi,
as noted a while back in #6
the indicator icon is missing in ubuntu-mate. This time the issue is in the flatpak.
The solution however is the same: add the env variable XDG_CURRENT_DESKTOP=$XDG_CURRENT_DESKTOP:Unity:Unity7
I can't really test how it works in other distros/DEs however

Tested latest build on Ubuntu 22.04 it works as expected.


VS Code Plugin - Run test - Error as http://localhost:65104/chat/completions is always used.

After updating both VS Code and BAML Package (NPM) to 0.70.1:
- At BAML Playground -> Run Test -> Error:
Unspecified error code: 404 Request failed: http://localhost:65104/chat/completions
404 page not found

If I turn the Option 'Raw cURL' on, it shows me the correct curl -X POST 'http://my_server_with_ip/v1/chat/completions' ....
It is noted that there is no change in my clients.baml.
I also updated the version in generators.baml to 0.70.1.
In runtime, everything just works as usual.

As I cannot test the .baml file in design time, it is very hard to check whether the promp and result work properly. :-/

Can you set "baml.enablePlaygroundProxy" to false in vscode settings, relod window and try again?

i think this is an issue with our latest release. See if using 0.70.1 of the playground fixes it -- I'm working on a fix now!

I did checked it -- surely that I am using 0.70.1. I am also using the latest version of BAML VS Plugin -- i think 0.70.3, as I could see in VS.

ah yes, for VSCode you'll want it to be 0.70.1 as well (there's a way to install a specific version in VSCode). Either way, willl hopefully have a fix out in the next hour or so

Try out 0.70.4 and let me know if you still have issues there.

I'm still running into the same issue, but for me I tried 0.70.4 and it's telling me I'm on VSCode Runtime Version 0.70.1, even though the extension itself says it is on 0.70.4:

Is vscode on 0.70.4? Check the version on extensions tab. It is ok if it says runtime is 0.70.1

Make sure to reload the window after updating

Yeah, I've re-opened the window and tried it on both cursor and vscode (I haven't installed it in the first place on vscode, so that was a fresh install).

Here's my version on the extension tab:

Which provider are you trying to call? It seems they are down with a 503

I was trying my workplace api, which is up currently. It shouldn't be localhost, but an actual url to a custom openai endpoint.

The curl command it generates is correct, just not that url that is seen in the error.

Do you use a container to run vscode?
You can also try to set the "baml.enablePlaygroundProxy": false

Not a container, and I'll try that

Apologies, just tested it and yes it was my API, thank you for the help though!

Apologies, just figured it out and yes it was my API, thank you for the help though!

no worries!

Yes, the newest Version 7.0.5 worked well.


Feature/72 typography fontstack edits

Hey @joolswood, these are my minor edits to the guidance around the sans-serif font family choice, and the font-stacks.

Whops. Includes something else accidentally.


UI improvement :: when Chart.Tooltip text is empty the tooltip should not be shown

hello chartjs dev team
I was preventing a tooltip for a segment from shown and using "simplified code to repro.ui experince"
       chartOptions = {            tooltipTemplate: function() {                 return "";             }         }
The attached image show the outcome. The code i used for sample is
https://gist.github.com/anonymous/afc1b0ce902b7b306cbc
https://output.jsbin.com/lotirehuxa

I fixed my case by preventing draw in Chart.Core.js line 1111
	if(template(this.options.tooltipTemplate, Element).length>0){ 						var tooltipPosition = Element.tooltipPosition(); 						new Chart.Tooltip({ .... 						}).draw(); 						}
hope someone can fix this, maybe else where in code

Another possible solution:
if (this.text === "") {
	return;
}

in Chart.Tooltip.draw().

Hello, today I am closing all issues that are only affecting version 1 of Chart.js as WONTFIX.
If this issue does affect version 2 as well, I apologize for the error. Please create a test case against Chart.js 2 using on of the below websites and we will be happy to reopen the issue and update its classification:

http://jsbin.com/
http://jsfiddle.net/
http://codepen.io/pen/
Premade template: http://codepen.io/pen?template=JXVYzq


Decide how to handle different data types

If we not have identical types in the same Channel, Grafana will burn down

InfluxDB will burn down before Grafana.
Trying to write a value of a type not matching the previous types will result in an error

Maybe we should give the option to define the Channel-Types per Sensor in the control panel? If the first value for a new Sensor is in the wrong type (which is possible trough debugging a sensor), the sensor-id is lost.

Maybe we should give the option to define the Channel-Types per Sensor in the control panel? If the first value for a new Sensor is in the wrong type (which is possible trough debugging a sensor), the sensor-id is lost.

The data input should work as fast as possible. Any additional database access would create a large speed impact. I think the easiest way would be just to let the database create errors, what wouldn't impact the performance significantly. In case of an error, we could try an automatic type adjustment, and in case this is not working, the user should be informed. Although listing the type of the channel on the control panel would be a good idea.


370 | Fix: Deleting variant of a detached container

fixed FE error while removing a variant with deleted container
Resolves #730

Thanks! part of the error is gone.
But still, why do we have many error messages ? why not only one ?
https://github.com/Agenta-AI/agenta/assets/6608260/aa1c3bd5-15fe-4e83-b51b-060b65ac9918

Thanks! part of the error is gone. But still, why do we have many error messages ? why not only one ?
Screen.Recording.2023-10-12.at.09.08.53.mov

@aakrem there was a redundant useEffect dependency in the useVariant hook causing it to make the API call one extra time. I've fixed that. Now, in dev mode, still 2 API calls are made due to React 18's new behavior. However, if you run in prod mode docker compose -f "docker-compose.prod.yml" up -d --build you will only get one error now, as only one API call is made on component mount.
I've verified it locally.


Tweak StatefulSet Basics tutorial

PR #40765 set out to:

Modify nslookup query output format in en doc

This PR copies the commit from PR #40765 and also makes important fixups.

This was important to me, but not enough to keep it open.
/close


More general way of adding getContext() to a mock canvas object.

The issue with the current way of doing it, is that the change is not global; i.e. the mock canvas object is reset during regular usage by any component. This makes it kind of useless for unit tests.
The following works for me, I hope you can adapt something similar:
var myHackedInCanvas;    // Use one global canvas instance for all calls to createElement('canvas');

function replaceCanvasContext (el) {
  // The previous export
}

/**
 * Overrides document.createElement(), in order to supply a custom canvas element.
 *
 * In the canvas element, getContext() is overridden in order to supply a simple
 * mock object for the 2D context. For all other elements, the call functions unchanged.
 *
 * The override is only done if there is no 2D context already present.
 * This allows for normal running in a browser, and for node.js the usage of 'canvas'.
 *
 * @param {object} the current global window object. This can possibly come from module 'jsdom',
 *                 when running under node.js.
 */
function mockify(window) {
  var d = window.document;
  var f = window.document.createElement;

  // Check if 2D context already present. That happens either when running in a browser,
  // or this is node.js with 'canvas' installed.
  var ctx = d.createElement('canvas').getContext('2d');
  if (ctx !== null && ctx !== undefined) {
    //console.log('2D context is present, no need to override');
    return;
  }

  window.document.createElement = function(param) {
    if (param === 'canvas') {
      if (myHackedInCanvas === undefined) {
        myHackedInCanvas = f.call(d, 'canvas');
        replaceCanvasContext(myHackedInCanvas);
      }
      return myHackedInCanvas;
    } else {
      return f.call(d, param);
    }
  };
}

module.exports = mockify;

This does change the object to pass in, so in a sense breaking. I personally do not care, but you may think different. Perhaps you know a better way.

For testcase of echarts-for-react, we should mock echarts which is a chart library based on canvas.
So do something by a jest mock plugin - jest-canvas-mock, and use it to test echarts, works fine.


Move project level settings to Project Settings Window

XRTK - Mixed Reality Toolkit Change Request
Is your change request related to a problem? Please describe
XRTK currently puts its settings into Unity's Preferences window, which is
for editor preferences. XRTK's project level settings should move to the Project Settings
window.
How would you classify your suggestion

UI / UX

Describe the solution you'd like
Move XRTK project level settings into Project Settings window instead of Preferences.
Additional context

These settings are in the correct place.
Project level settings are for project specific things.
I could see the need to move the generated profile and start scene.
@Jarodshow weren't you working on something for this?

They are most definitely not. XRTK is almost by definition a project level tool. It brings no benefit to the editor in general that is not tied to a project. So I can't see how they are in the right place here.

For some of the above I guess one can argue they are editor prefernces, yes.

I just didn't feel like there was enough to warrant two different menu screens.
I think @Jarodshow was working on an update to this window.

This is all in the fix/editorpref branch :)

I could see the need to move the generated profile and start scene.

This is in the project settings currently.
@FejZa feel free to push(or tell me) any additional settings you see fit


Change the readme to mark the repo as unused.

But leave a link to the elm-projects repository, since there are
some "help wanted" projects listed there still.
@evancz - Per discussion on the mailing list.
The simplest way to hang on to discussions in the history of issues is to just not delete the repository; nobody's been attempting to open issues or PRs here, and they probably won't start after the change to the README, so it doesn't hurt anything.  Otherwise, issues can be exported from Github's API.

Great, thanks you for doing this! Very clear and helpful :)


Make RazorViewEngine.GetNormalizedRouteValue easier to use outside of Mvc

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Razor/RazorViewEngine.cs#L151-L192 - it is marked as internal so that other components inside Razor can use it. This would be useful for any user writing a custom view location expander (for instance https://github.com/aspnet/Mvc/issues/3096 where he'd need to get to the area value) or a custom view engine.
Would it make sense to move this method to Core? There's nothing about it that requires it to be present in RazorViewEngine.
cc @rynowak

I don't get why it should move to Core, but it makes sense to make it public. In general if something is internal for any reason other than unit testing, it should be public.

OK to make this public.

:+1:


POC / Proposal: Package namespaces

Proposal / POC
Overview
It would be great to be able to create rules that do not collide with the org package namespace and that would directly be mapped to a specific meta condition.
Although it is possible today to write rules that apply to specific projects/branches using data.meta and toggling rule enablement, everything lives in one giant namespace: org.
This PR allows for new set of valid package names:

org
project[expression] // where expression can be the project UUID or a shell-expression of a project slug
branch[expression] // where expression is a shell-expression of a branch name

Some implications:

all rule name evaluations now get prefixed by their matched package. For example rule custom in package org will report as a rule violation of org.custom and rule custom in package branch.main will report as a rule violation of branch.main.custom and so on.
Rule name collisions cross packages supplement one another. One does NOT override an org level rule with a project or branch based rule of the same name.

Current implementation tradeoffs

The policy-agent in its current form has become overly specific to Config Policies. A serious backwards compatibility breaking refactor would need to take place for the agent to support other domain specific policies that do not follow org, project, branch semantics.
Pattern matching uses path globs for simpler expressions and less compute overheard. However it gives less power than a regexp would. A simple example of this would be: package branch.["^main"] to apply to any branch that is not main. However these kind of negative groupings can be easily expressed at the org level with rule guards. Regexp vs Glob support is still an undecided thing at this point. The POC goes with Glob support.

Examples
With this we could write a policy for a project without having to guard every rule and that can have symbols that conflict with org ones:
package project["b02c619e-5958-11ed-a1a4-ff0a876360a6"]

enable_rule["conflicts_with_org_but_thats_ok"]

or for a given set of slugs:
package project["prefix-*"]
...

or for a branch expression:
package branch["feature-*"]
...

Proposal V2
There's a secondary proposal (not implemented) for an alternative way of matching package to metadata.
This proposal has a more generic structure and is more expressive and can map packages to multiple metadata conditions but can a little more confusing from the user's perspective.
Simply put we can encode all of the metadata conditions as series of parameters like url query parameters in some predictable package structure, using the fact that we can have arbitrary strings as package name segments.
Therefore we could introduce a secondary valid package name like package org.filters[expr] or package filters[expr]
and let the expression be a set of meta conditions.
Thus we could have:
package org.filters["branch=main&project_slug=gh/team-prefix-*"]

And create packages based on multiple meta conditions.
Tradeoffs

More flexible and powerful
Not as predictable: multiple packages could express the same conditions but have different names
PRO & CON: Packages names are not semantic to the policy domain

Thank you for sharing @davidmdm !
Firstly, I like this proposal, I think scoping of packages is a great thing to figure out.  I don't see the current model technically challenge but a mental hurdle.  Explicit packaging that indicates scoping would help overcome that I think.
As for the 2 proposals, the concern I have with #1, is that they are not exclusive domains, where as a 'package' generally should be right? (how can a cat be in 2 boxes at once!?)
Anyway what i mean is while project is a logical subset of org (org.project), I am not convinced branch is, because the branch can only exist inside a project (org.????.branch).
So for proposal 1 I think to be clean means we would maybe want a global vs project package (org.branches.main, org.project.branches.main)  and I am  note sure that keeps the simplicity you endorsed.
Contrary, I agree very much with your concerns on #2, while it solves mine I suppose
Dumb question from the guy that doesn't have to implement, but couldn't we just assert canonical naming based on the query string?
i.e. what if we asserted that however you write it, we do some ordering and defaulting of those values (PS i do think we should limit how many filters we support vs expecting to be done as part of policy itself, I see limited value in solving for all possible filters in package names - tag? nothing else.)
| expression | our value |
| org.filters["branch=main"] |  {"projects":"","branches":"main"} |
| org.filters["project_slug=gh/team-prefix-"] |  {"projects":"gh/team-prefix-","branches":""} |
| org.filters["branch=main&project_slug=gh/team-prefix-"] |  {"projects":"gh/team-prefix-","branches":"main"} |
| org.filters["project_slug=gh/team-prefix-&branch=main"] |  {"projects":"gh/team-prefix-","branches":"main"} |
This solves my concern by being explicit about where branch rules are being applied.
SUmmary:
I probably lean towards #2 if we can get canonical, but
I think the branch filtering makes me uncomfortable given overlap across projects, I would rather see that defined within policy, not only for overlap reason above but also default branch and branch flow (i.e main, dev, current, etc) will vary by team within an org.


⚠ Fetchers has degraded performance

In 5a81717, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 347 ms

Resolved: Fetchers performance has improved in dd3bb85.


(At least) ExactSumConstraint doesn't handle negative numbers properly

myth1 python-constraint-master # python
Python 2.7.12 (default, Dec 17 2016, 17:32:09)
[GCC 4.9.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from constraint import *
>>> p = Problem()
>>> p.addVariable('a', [-1,0,1])
>>> p.addVariable('b', [-1,0,1])
>>> p.addConstraint(ExactSumConstraint(0), ['a', 'b'])
>>> print p.getSolutions()
[{'a': 0, 'b': 0}]
>>>

Shouldn't a==-1, b==1 and a==1, b==-1 also be solutions?
Thanks.

What is your opinion @niemeyer about this?

ExactSumConstraint implicitly assumes the inputs are non-negative and optimizes internally for that assumption. I didn't write it, but my guess is that finding exact sums from sets of non-negative numbers fits a certain problem domain, and this was intended for that.
It might be better to update the documentation for ExactSumConstraint than to change its behavior, and @ltskinol could write a separate constraint class for their problem domain.


Feature/xy zip

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.76%. Comparing base (4507a06) to head (65481c8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #85   +/-   ##
========================================
  Coverage    87.76%   87.76%
========================================
  Files           10       10
  Lines          793      793
========================================
  Hits           696      696
  Misses          97       97

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


AWS better check and election

Ensures that the Ubuntu image is developed by Canonical
Chooses the default VPC and not the very first one
Ensures that the subnet can create public IPs and it has available IPs still
Checks the iterative mapped regions to determine if ami is available.

Checks the iterative mapped regions to determine if ami is available.

This should close another issue that I remember we opened @0x2b3bfa0

#99?