Add a sample_ray method to layers

🚀 Feature
In support of 3D picking, I think it would be nice to add a method to the base layer that calculates end points of the ray going through the data volume from a point in the canvas in the direction of the view.
Motivation
This ray (sample_ray?) can be used for 3D picking or sampling/exploring data along the ray (e.g., plotting intensity, finding voxels with specific values)
Pitch
We add a method to the base layer class that when given a point on the canvas (in canvas coordinates), finds the intersection between the ray cast from that point in the direction of the view with the axis-aligned bounding box of the data. In this context, "axis-aligned" means the bounding box is aligned with the axes of the data. For now, the bounding box is the extents of the data (layer._extent_data?).
In a next step, we could add some basic 3D picking to the layers using the sample_ray method. For labels, it's fairly straight forward. For Points and Shapes, we might need to be a bit more careful about performance (e.g., make axis aligned bounding boxes for each object and then test for intersection using those).
I have made a (quick and dirty) prototype implementation of finding the intersections sample ray with the data bounding box (used to perform 3D picking) here (near_point and far_point are the end points of the sample_ray in data coordinates).
In action:

Alternatives
Additional context

@sofroniewn , where is the best place to get caught up on the napari transform system? In particular, I would like to get the transformation between the screen coordinates (i.e., coordinates returned by the event.pos in the mouse event) and the data coordinates.

This is awesome @kevinyamauchi! We've been trying to move cursor position information off the layer, so I'd prefer if this wasn't directly on the base layer, but instead was something that could be calculated with the layer. One option would be to add viewer.cursor.ray which contained the ray in world coordinates (note viewer.cursor.position contains the position in world coordinates in 2D - I'm not actually sure what it has in 3D!)
Given the ray in world coordinates each layer can map that back to make a ray in data coordinates

@sofroniewn , where is the best place to get caught up on the napari transform system? In particular, I would like to get the transformation between the screen coordinates (i.e., coordinates returned by the event.pos in the mouse event) and the data coordinates.

The key method to go from canvas coordinates (what you call screen above, but the origin is in the top left of the canvas) to world coordinates uses the function defined here https://github.com/napari/napari/blob/097dca8763f5414732887a89a29f613047304580/napari/_qt/qt_viewer.py#L661-L684
and updates the cursor here https://github.com/napari/napari/blob/097dca8763f5414732887a89a29f613047304580/napari/_qt/qt_viewer.py#L720-L721
I think you could also use/ adapt that method to make the ray and update viewer.cursor.ray.
That cursor position then gets added to the mouse event event.position, you could also add event.ray here https://github.com/napari/napari/blob/097dca8763f5414732887a89a29f613047304580/napari/_qt/qt_viewer.py#L723-L724
And then inside each layer mouse function callback there is a line
    coordinates = layer.world_to_data(event.position)

see https://github.com/napari/napari/blob/097dca8763f5414732887a89a29f613047304580/napari/layers/labels/_labels_mouse_bindings.py#L24 for example
and you then have something like
    data_ray = layer.world_to_data(event.ray)

How does this sound?

Thank you, @sofroniewn ! This is super helpful. I agree that we should try to keep the cursor stuff off of the layers and I think the general approach you outlined looks good.
I have a couple of follow up questions:

in napari, are "world coordinates" the same as vispy "scene coordinates"
Why is the camera transform used in the _map_canvas2world() method? From this issue, it looks like the camera transform isn't the complete transformation from canvas to scene. From my reading/experimentation, I think the ViewBox.scene.transform is what we want. That being said, I'm still trying to wrap my head around the vispy coordinates systems and transforms, so I am not totally suer

in napari, are "world coordinates" the same as vispy "scene coordinates"

Yes, but "world coordinates" in napari are fully nD, I think we at places might say "worldslice coordinates" to mean the "scene coordinates"

From this issue, it looks like the camera transform isn't the complete transformation from canvas to scene.

Hmm that could be - i think in 2D some of this stuff might not matter / stuff might be equivalent so we didn't notice, but in 3D the differences might be more significant.
My hope though is that we could keep changes localized to the _map_canvas2world method and just make it so that it does the right thing for us with 3D canvases


Manually zooming camera (<1) breaks target multiple objects

Manually zooming camera in editor (<1) breaks targeting on multiple objects.
To Reproduce
I believe this bug exists as long as you attempt to target multiple objects with a zoom of less than 1 on the ProCam. More thorough details of minimum reproduction below:

Create new project: TestScene
Add CharacterBody2D: "Player" with following code:

extends CharacterBody2D

const SPEED = 300.0

func _ready():
	ProCam.set_tmo(true)

func _physics_process(delta):
	var direction = Input.get_axis("ui_left", "ui_right")
	if direction:
		velocity.x = direction * SPEED
	else:
		velocity.x = move_toward(velocity.x, 0, SPEED)

	move_and_slide()

Add sprite to player for visibility
Add ProCam and PCTrackPoint. Enable PCTrackPoint. Assign player as target for ProCam.
Add second sprite to scene with PCTrackPoint. Enable the second PCTrackPoint. It should be noted that if you run the scene at this point it functions as intended, keeping both PCTrackPoints on the screen.
Zoom the ProCam to a number less than 1. (I discovered this using 0.3 but have also tested 0.5)

If you run the scene under these conditions both PCTrackPoints leave the scene and the space between them remains on the scene.
Expected behavior
All PCTrackPoints remain on scene regardless of camera zoom. The camera should re-zoom to fit all PCTrackPoints.
Desktop (please complete the following information):

OS: Windows
Godot Version 4.2.2
Plugin Version 0.2

If necessary I can upload my test scene for context. Apologies if this is user error, I am relatively inexperienced. I did try to thoroughly solve the problem on my own prior to making this account to report the bug(s). I love the plugin and appreciate all the work you have put into it!

Fixed!
The bug is fixed for zoom levels (<1) and (>1). Thank you for reporting.


Add support for returning OpenAPI spec as YAML

Summary
This is a nice convenience to offer users who need their spec as YAML, rather forcing them to take the JSON and convert it to YAML (which can be unreliable).
Test Plan
cd examples/openapi/union
cargo run

Now go visit http://127.0.01:3000/docs/spec_yaml and see that it returns a YAML version of the spec.
I likely need to add some unit tests for this, but first I'll wait for the maintainers to give the green tick on this idea in general.
Thanks!

I based this branch off https://github.com/poem-web/poem/pull/285 so you'll see that commit here too. Let's discuss that PR first before looking into this one.

This is very useful! 🙂

Awesome, thanks! I can rebase this PR, hang tight.

Alright let me know if you need anything else to land this. Excited to get this in, then I can switch back to the main repo instead of my fork!

Okay finally managed to rebase properly, we should be good to land this.

Thanks! 🙂


Is activesupport a dependancy?

Full version information is ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-darwin10.7.4].
When I try to run any kicker command, for example $ kicker
I get the following error:
/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in require': no such file to load -- active_support/core_ext/module (LoadError) 	from /Users/smebberson/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in require'
Once I had a look at the source, I install the activesupport ruby gem and things started working...
Are you able to add it as a dependancy so that it automatically installs?

Same here, gem install activesupport and gem install i18n fixed things.

Neither gem install activesupport nor gem install i18n fixed this for me.
/Users/honza/.rvm/gems/ruby-1.9.2-p290@project/gems/activesupport-3.2.0/lib/active_support/core_ext/module/deprecation.rb:7:in `deprecate': uninitialized constant ActiveSupport::Deprecation (NameError)

Kicker should only require Active Support when you load the Rails recipe and not in other cases.
Failure to run on ActiveSupport 3.2 has something to do with the module / class structure changing.
I'll try to figure out what's going on.

huh. I wonder what I did to load the rails recipe. Here's my project's .kick file:
process do |files|
  if files.any? { |file| file =~ /\.(cs|csproj|sln)$/ }
    execute 'xbuild'
  end
end

I run it simply with kicker (or bundle exec kicker). When I run without activesupport, I get this error:
/usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes/rails.rb:3:in `require': cannot load such file -- active_support/core_ext/module (LoadError)
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes/rails.rb:3:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes.rb:56:in `require'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes.rb:56:in `block in <module:Recipes>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes.rb:56:in `each'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes.rb:56:in `<module:Recipes>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes.rb:30:in `<class:Kicker>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker/recipes.rb:29:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker.rb:122:in `require'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/lib/kicker.rb:122:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/bin/kicker:9:in `require'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/gems/kicker-2.3.1/bin/kicker:9:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/bin/kicker:19:in `load'
	from /usr/local/rvm/gems/ruby-1.9.3-p0@git-tfs/bin/kicker:19:in `<main>'

I don't think I did anything to make the rails recipe load. What triggers it to load?

Sorry, I meant it should work that way. Currently it just loads all recipes on startup. Working on a fix.

no problem. i was just curious. :)

Awesomeness! It works like a charm.

works great here, too. thanks!

Good to hear! Have fun (;


FreeTypeFontGenerator produces very different result compared to Hiero

Issue details
I am trying to use the FreeTypeFontGenerator to generate a BitmapFont for the Calibri typeface. This is the code I use for generation:
gridCoordFonts = new BitmapFont[4];
FreeTypeFontGenerator generator = new FreeTypeFontGenerator(Gdx.files.internal("assets/fonts/calibri/calibri.ttf"));
for (int i = 0; i < baseCamera.getZoomLevels().length; i++) {
    FreeTypeFontGenerator.FreeTypeFontParameter parameter = new FreeTypeFontGenerator.FreeTypeFontParameter();
    parameter.size = Math.round(16f / baseCamera.getZoomLevels()[i]);
    parameter.renderCount = 1;
    parameter.padTop = 1;
    parameter.padBottom = 1;
    parameter.padLeft = 1;
    parameter.padRight = 1;
    BitmapFont font = generator.generateFont(parameter);
    gridCoordFonts[i] = font;
}
generator.dispose();

The result looks much different than when I generate the BitmapFont through Hiero (with the default parameters) and load it in as follows:
Texture fontTexture = new Texture(Gdx.files.internal("assets/calibri16.png"), true);
fontTexture.setFilter(Texture.TextureFilter.Nearest, Texture.TextureFilter.Nearest);
font = new BitmapFont(Gdx.files.internal("assets/calibri16.fnt"), new TextureRegion(fontTexture), false);

I tried to play with the hinting parameter, but it doesn't change the output to that of the Hiero case.
With FreeTypeFontGenerator:

With Hiero:

Version of LibGDX and/or relevant dependencies
libgdx 1.10.0
gdx-freetype 1.10.0
Please select the affected platforms

[ ] Android
[ ] iOS
[ ] HTML/GWT
[X] Windows
[ ] Linux
[ ] MacOS

I just realized that there is an option in Hiero to choose the renderer to generate the bitmaps. When I set that to FreeType (instead of Java, which is the default), Hiero doesn't render the font at all (the preview window is just black). I tried it with the Ubuntu font, and that works fine in both modes.
Maybe the issue is that the freetype version which both the gdx-freetype extension and Hiero use cannot render the Calibri TTF for some reason, and then the FreeTypeFontGenerator falls back to some other default font face?

I'm investigating this, and there's some definitely-strange behavior regarding hinting. I can use FreeType as an option in my version of Hiero, but it certainly looks different from Java or Native rendering. The ASCII and Latin-1 characters (the first 256) are shown with really awful, harsh hinting, but the later characters look fine.

I suspect this is related to the incremental flag internal to FreeType, or maybe something else that could render later glyphs differently from earlier ones. I tried changing the hinting settings in the source code, but it doesn't seem to change the hinting for the first 256 glyphs.
This does seem like a bug, and it's unlikely that Calibri (as one of the MS-blessed fonts) is a faulty file. I don't know much about FreeType in libGDX, as I have never used the extension, so this might be something for @NathanSweet when he has the time.
In the meanwhile, you can use BMFont, which has options to disable hinting or configure smoothing, if you want to make a font that uses the same style of hinting for all codepoints.

I'm not seeing initial glyphs (caps below) being different from later glyphs (lowercase below) when using FreeType to render Calibri in Hiero:

If you are seeing a difference for some reason, you can use the reset cache button to recreate the font with all the glyphs up front.
The Java renderer is a bit blurrier.
Sorry to say I don't really know what is going on. I no longer use Hiero personally, instead I write code that generates fonts with FreeType. That way I can easily customize it and it's easier to get the same results later. I also have fonts generated as part of a build process.

In the screenshot I posted with the gray background, the ASCII and Latin-1 sections (up to char \u00FF) get very strong hinting, and later codepoints get normal rendering, like the Java renderer. Just ASCII never showed a problem for me. I did try resetting the cache, with the same result.
I should probably mention that I pretty much only use Hiero to attempt to fix bugs other people are encountering, rather than to actually make fonts myself. I usually use either BMFont or a hackish tool I wrote that can generate SDF and MSDF fonts. I'm not really sure if it's worth it to continue maintaining Hiero, personally.

How would you test the FreeTypeFontGenerator with the LibGDX3 graphics buffer?  That might fix the issue.  The most important thing to consider is that you absolutely need to limit and then reduce the number of ASCII characters available to your game.  This might sound superfluous and over the top for my next suggestion, but you can limit the enflow of what characters your game allows for your ASCII character selection.  For instance if you wanted to go crazy with it, you can limit all character to just A through Z and forbid 0 through 9 for example.  This is some thing that LibGDX would allow.  You would not want to do that in Java for the operating system it self.  That would cause problems with the cross platform nature of Java.  LibGDX handles it better than Java alone.  I recommend looking at Android references for limiting ASCII character if you need help or assistance with your coding attempts.  Essentially, you can also product a similar type of result by editing a type of ".FNT" file I think.
Think about it:  Hiero references graphics to ASCII codes.  Just edit the ASCII codes available them selves.  LibGDX should be intelligent enough to skip over font character references if necessary.  Android seems capable enough in this direction at least.  I would say to start there, if it helps you.  Remember!  You are editing the ASCII additions that your game allows.  This has no thing to do with the graphics.
@NathanSweet I apologize again for my previous rudeness behavior.  I am trying to cleanse COVID nonsense, where I am.  I erased one source due to MILSPEC weaponized things.  Would you help with the .FNT file thing, please?  I am not able to assist with my compiler tools at the moment.  IntelliJ Community is not available to me right now.  Thank you.

maybe this is a bug or feature in freetype itself ?

Yeah, I think it's just a FreeType thing. I've been here before after installing Microsoft fonts.
https://ask.libreoffice.org/t/calibri-font-not-rendering-correctly/2079/2


Fix Linting errors in NodeCloud

Before : https://drive.google.com/open?id=1qyK-_f9mL9u3YUorfngzEmwzVqGr9JlR
After : https://drive.google.com/open?id=1xg9R1iiQkp_q1teDefu-j15D29StrnR8
Kindly ignore the first commit.

What did you implement:
Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

[ ] Write tests
[ ] Write documentation
[ ] Fix linting errors
[ ] Make sure code coverage hasn't dropped
[ ] Provide verification config / commands / resources
[ ] Enable "Allow edits from maintainers" for this PR
[ ] Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

Great work

Hi @AdhyanDhull
I have mistakenly merged this PR.
You had removed
const assert = chai.assert;
 const providers = require("../../lib/providers");
 const nodeCloud = require("../../lib");
 const nock = require("nock");

These lines should not be removed. Hense I have reverted the changes. Please open a new PR with only the other changes.


updated link to the example in ss-vae tutorial

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(iroh): add more rpc methods

add blobs.read_at: Allows to efficiently read parts of a blob via RPC
add blobs.get_collection: read a collection

Cool I thought to add this quite a while ago already. Is there a reason to keep both BlobRead and BlobReadAt rpcs? Might be simpler to just have a single BlobRead RPC with offset: Option<usize>, limit: Option<usize>?

Might be simpler to just have a single BlobRead RPC wit

done


Doesn't work with Maya 2023?

Checking....

There seems to be an FBX incompatibility between Maya 2022 and 2023. Bring in the FBX sample into Maya 2023, the keyframes are gone. For now, until I can search down a cause of this, the code does work in Maya 2022 and that's all this code can support at the moment. Apologies for the inconvenience.


Query: StateManager.StartTracking should track graph

Related to #2015, the StartTracking API used by query should attach graphs.
Entities streaming from a query can be graphs because of Include. When tracking such entities, we want to track all of the entities in the graph. Previously, query would call StartTracking on any included entities, but this functionality was enabled by the QueryBuffer, which is going away.

Superceded in https://github.com/aspnet/EntityFramework/pull/2092


FEATURE: On-demand projects loading when working with big C# codebases

PROBLEM DESCRIPTION: One of the major factors contributing to VSCode success is its speed. For JavaScript for example users get rich development experience almost immediately after launching the IDE. When working with C# codebases though developers have to wait for ALL projects to be loaded until many code navigation features are available. For codebase containing more than few dozens of projects this delay is very significant. This experience gets even worse when a developer often switches b/w branches which is a common place when working with Git. After checking out a branch, Ominsharp would need to potentially reload many projects which can take minutes. And in bigger codebases a user typically only needs to only work with a small subset of the code, particularly if s/he is only browsing/studying it. The workarounds of opening multiple instances of VSCode rooted in particular subfolders or managing a list of designated folders in a workspace creates unnecessary friction in developer workflow particularly when s/he needs to quickly "jump" b/w various places in the codebase (which is often the case when doing codereviews).
PROPOSED EXPERIENCE: One approach for improving the experience described above is to allow user to control whether all projects loaded automatically. When automatic loading is disabled VSCOde could only start loading projects for files when they are opened in the IDE for editing (including all referenced projects recursively). This could be done for example by looking for a csproj file in the same folder where the opened for editing file is located or walk up the folder hierarchy until such project file is found. The PROS of this approach is that VSCode will load only projects for the source code that user is working on without wasting time on projects are not relevant at the moment. Should the user need to switch the current branch or restart VSCode, s/he can get back to the working environment much faster. The obvious CONS of this approach is that user might be getting incomplete semantic information for example when IDE shows references for symbols. Arguably though when reviewing code or working on a particular component in a bigger codebase this could be a good compromise comparing to always getting full list of references for the cost of many minute wait (and draining battery when on laptop) while this information might not be needed at all. Allowing user to make this choice seems like the right thing to do and the prototype of this approach that I was using with the codebase containing almost 800 C# projects for last few months confirms this for me.
DESIGN: Introduce new VSCode setting omnisharp.EnableOnDemandMsBuildProjectsLoad with default value 'false' which will ensure the existing projects loading behavior. When the setting is set to 'true' VSCode will behave as described above and will load only projects relevant to files that are currently opened in the IDE.
The new setting will be passed to OnlySharp.exe (into OmniSharp.MSBuild.ProjectSystem via IConfiguration) using existing configuration key, i.e.:  OmniSharp.exe  MsBuild:OnDemandProjectsLoad. When the setting is changed, VSCode will prompt user to restart the IDE for the change to take place.

@dmgonch In my opinion, prompting the user to restart OmniSharp process when the configuration changes, should be enough I think, we shouldn't need to restart the IDE.

@akshita31 : agreed - I just wasn't sure if restarting of just OmniSharp process is currently supported in the VSCode extension.

@rchande @DustinCampbell @david-driscoll : folks, I would appreciate any additional feedback for the proposal.

@dmgonch This sounds reasonable to me. If you're interested in generally making project load faster (instead of optimizing for the hundreds of projects case), there are a few other things you can consider:

Use "Design-Time Batch Build" APIs to take advantage of the new batch builds feature in MSBuild
Build/load projects in parallel now that cross-plat MSBuild parallelism works
Use MSBuild to generate the project dependency graph after all the projects are loaded, and write the graph to disk. On subsequent loads, use this graph to optimize load order (the current load order is totally arbitrary).

@rchande: indeed those are good performance optimization items to consider. I believe though the scenario that I outlined is less about making projects to load/build faster but more about avoiding loading/building projects until a user starts working with them.
@DustinCampbell: hopefully you had a chance to take a look at this write-up as well. I just want to avoid surprises later when PR is out. Thanks!

I did take a look, yes. @rchande and I sat down and discussed the issue before he replied.

@filipw : not sure if you had a chance to take a look. Would appreciate any feedback on the feature itself and the proposed implementation. Thanks!

Closing since the feature has been implemented and merged into master.

@dmgonch huge fan of this feature, it makes navigating my huge codebase much quicker.  What do you think about an option to load projects on demand first, then once thats done loading the remaining projects in the background so you eventually get all references?

@gmkado the key question I think is how to select the relevant subset of those "remaining projects" to load in the background. When working with a codebase containing thousands of projects, I actually don't want to load all of them, even in the background, since I never need to look into the majority of them.

@dmgonch I was thinking you would load everything in the solution, but prioritize open files (i.e. if another file got opened, those projects got bumped to the top of the queue).  This could take the form of another config ContinueLoadingAfterOnDemandCompletes (naming things is hard) that would give you this option, but would default to false.  So the current behavior would stay the same.
I'm not familiar with how omnisharp works behind the scenes, so maybe this is impractical.  But it would be nice for "medium-large" sized codebases to get the speed advantage of the on-demand feature, and where leaving omnisharp to think long enough would eventually get everything loaded.

To tell the truth I never needed such a functionality though I agree that it might be practical for 'not so large' set of projects. On the other hand, in codebases even with 1000s of projects, searching files by name (Ctrl-P on Windows) combined with enableMsBuildLoadProjectsOnDemand was good enough for me (though I'm still yearning for the proper cross-language online symbols search integration in VSCode).
Additionally, many very large codebases I work with don't have solution files at all and 'glue' projects together using https://github.com/microsoft/MSBuildSdks/tree/main/src/Traversal and generate SLN files on the fly using https://github.com/microsoft/SlnGen


DefaultSocks5CommandResponseTest produce buffer leak

See here:
http://clinker.netty.io/jenkins/job/netty-leak/branch/master/96/consoleFull

@trustin please check :)

@trustin ping

Thanks for the heads up! Fixed in 6d822195b0a59514b8fbeee15b0466735efb2289 (master) and 7aeafb9c09c55a001b92975ea8fb895554757aa5 (4.1)


Analysis-server snapshot failed on ventura arm

it is bit weird that analysis-server snapshot built out successfully in my local, but failed in the homebrew CI (and it only failed on one os, ventura arm), below is the error message:
  output: Analyzing with an empty driver cache:
  Analyzing /private/tmp/dart-sdk-20230113-6098-ylqmfp/sdk-2.18.7/sdk/pkg/compiler/lib...
  Completed in 35.4s.

  Analyzing with a populated driver cache:
  Analyzing /private/tmp/dart-sdk-20230113-6098-ylqmfp/sdk-2.18.7/sdk/pkg/compiler/lib...
  Completed in 0.0s.
  Completed in 0.0s.
  Unhandled exception:
  Bad state: Future already completed
  #0      _AsyncCompleter.complete (dart:async/future_impl.dart:35:31)
  #1      DevAnalysisServer.processDirectories.handleStatusNotification (package:analysis_server/src/server/dev_server.dart:62:24)
  #2      DevAnalysisServer.processDirectories.<anonymous closure> (package:analysis_server/src/server/dev_server.dart:124:9)
  #3      _RootZone.runUnaryGuarded (dart:async/zone.dart:1593:10)
  #4      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
  #5      _DelayedData.perform (dart:async/stream_impl.dart:515:14)
  #6      _PendingEvents.handleNext (dart:async/stream_impl.dart:620:11)
  #7      _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:591:7)
  #8      _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
  #9      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
  #10     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:123:13)
  #11     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:405:11)
  #12     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

relates to https://github.com/Homebrew/homebrew-core/pull/120454
full build log, https://github.com/Homebrew/homebrew-core/actions/runs/3915856712/jobs/6694464697

Anyone can help this thread?

Actually dart-sdk 2.19.0 builds out fine now.

seeing issue again in 2.19.1 release build

Seems good again with dart-sdk 2.19.2 build

Still need some help on this, https://github.com/Homebrew/homebrew-core/pull/125103

@parlough even with pulling this commit, https://github.com/dart-lang/sdk/commit/597d7e4d824da0f5f7dcd8f0573e0b50ac039e5d
I can still see the same issue in the homebrew build
  FAILED: gen/analysis_server.dart.snapshot
  python3 ../../build/gn_run_binary.py compiled_action dart --deterministic --packages=../../.dart_tool/package_config.json --snapshot=gen/analysis_server.dart.snapshot --snapshot-depfile=gen/analysis_server.dart.snapshot.d --snapshot-kind=app-jit --dfe=../../utils/analysis_server/NEVER_LOADED gen/utils/analysis_server/analysis_server.dart.dill --sdk=/private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/sdk/ --train-using=/private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/pkg/compiler/lib
  Command failed: /private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/xcodebuild/ReleaseARM64/dart --deterministic --packages=../../.dart_tool/package_config.json --snapshot=gen/analysis_server.dart.snapshot --snapshot-depfile=gen/analysis_server.dart.snapshot.d --snapshot-kind=app-jit --dfe=../../utils/analysis_server/NEVER_LOADED gen/utils/analysis_server/analysis_server.dart.dill --sdk=/private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/sdk/ --train-using=/private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/pkg/compiler/lib
  output: Analyzing with an empty driver cache:
  Analyzing /private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/pkg/compiler/lib...
  Completed in 29.9s.

  Analyzing with a populated driver cache:
  Analyzing /private/tmp/dart-sdk-20231201-5519-kt7o4f/sdk-3.2.2/sdk/pkg/compiler/lib...
  Completed in 0.0s.
  Completed in 0.0s.
  Unhandled exception:
  Bad state: Future already completed
  #0      _AsyncCompleter.complete (dart:async/future_impl.dart:43:31)
  #1      DevAnalysisServer.processDirectories.handleStatusNotification (package:analysis_server/src/server/dev_server.dart:62:24)
  #2      DevAnalysisServer.processDirectories.<anonymous closure> (package:analysis_server/src/server/dev_server.dart:124:9)
  #3      _RootZone.runUnaryGuarded (dart:async/zone.dart:1594:10)
  #4      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
  #5      _DelayedData.perform (dart:async/stream_impl.dart:515:14)
  #6      _PendingEvents.handleNext (dart:async/stream_impl.dart:620:11)
  #7      _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:591:7)
  #8      _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
  #9      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
  #10     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
  #11     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:405:11)
  #12     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)
  #13     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

  [3759/3773] ACTION //utils/kernel-service:kernel-service_snapshot(//build/toolchain/mac:clang_arm64)
  [3760/3773] ACTION //utils/compiler:dart2js(//build/toolchain/mac:clang_arm64)
  ninja: build stopped: subcommand failed.
  buildtools/ninja/ninja -C xcodebuild/ReleaseARM64 create_sdk
  BUILD FAILED

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/7064359241/job/19232347778?pr=156057

Hmm, thanks for the heads up. I'm not sure the patch is applying to the code running since the stack trace:
#1      DevAnalysisServer.processDirectories.handleStatusNotification (package:analysis_server/src/server/dev_server.dart:62:24)

Suggests the future is being completed on line 62, which is where it's completed before my fix. After the commit, it's completed on line 66.

yeah, looks like more of a build issue sequence issue on the brew side. :)
@parlough Any timeline that we can cut off a new release to include this change? Thanks!

Since this affects builds from the source tree, not the built releases, I don't think this change would be cherry-picked to a 3.2 stable release. As a result, for stable releases, Dart 3.3.0 should be the first include the fix if nothing changes before then.

Do we have timeline for the 3.3.0 release? (side note, this is kind of recurring issue for the build process)


chrome warning

A cookie associated with a cross-site resource at https://openlayers.org/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
¿ Why ?

On which page exactly were you seeing this warning?


Instructions for contributors

Add instructions for contributors. Before that, tests should be able to be run with docker env (needing to install redis and memcached for running them sucks).
A file for CHANGES should also be added for keeping track together with CONTRIBUTORS file.

fb65ca8fb9327f50a38ac968950315829e37cd6c


'Deny: Private Range'. destination address was denied by rule

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
I have two instances of CVAT - prod and stage. And two instances of MinIO - prod and stage (<IP_ADDRESS>). They all in the same local network, but physically on the different machines. My prod cvat can create cloud storages without any issues. When I try to do the same with my CVAT stage it throws
{"allow":false,"content_length":191,"decision_reason":"The destination address (<IP_ADDRESS>) was denied by rule 'Deny: Private Range'. destination address was denied by rule, see error","dns_lookup_time_ms":0,"enforce_would_deny":true,"id":"cqf4gs046pgs7e57ba6g","inbound_remote_addr":"<IP_ADDRESS>:38354","level":"warning","msg":"CANONICAL-PROXY-DECISION","project":"","proxy_type":"http","requested_host":"<IP_ADDRESS>:9000","role":"","start_time":"2024-07-22T11:54:24.932386282Z","time":"2024-07-22T11:54:24Z","trace_id":""}
I am just trying to understand who is defining the rules
Expected Behavior
No response
Possible Solution
No response
Context
No response
Environment
No response

Hi, I think you should try to add smokescreen excludes for these IPs. They are written in the form: SMOKESCREEN_OPTS="--allow-address=<IP_ADDRESS>" (this example is for docker).

Hi, I think you should try to add smokescreen excludes for these IPs. They are written in the form: SMOKESCREEN_OPTS="--allow-address=<IP_ADDRESS>" (this example is for docker).

many thanks, it worked

Changed in docker-compose.yml
SMOKESCREEN_OPTS: ${SMOKESCREEN_OPTS:--allow-address=<IP_ADDRESS>}


Routings networks

Here are two routing networks:

AnyToAny network - which is the simplest implementation of routing network and should work as baseline
Omega network - which has logarithmic depth, but fewer connections.

Depends on #304 and ~#347~

Added as a part of #395


SW-5428: Saving while adding Project to species fails with 404

This PR includes a change to disable the "Add Species to Project" button in the SpeciesDeliverableTable, if the deliverable is not "current".

I think these changes work to indirectly determine if the species deliverable's module is active, by checking to see if the species deliverable id exists within currentDeliverables (it looks like currentDeliverables contains deliverables for the active module). But please let me know if these changes won't work like I think they will, thanks!


[BUG] Tooltip fails to hide in certain scenarios

Bug description
In specific scenarios, hard to reproduce, the tooltip persists on the screen and does not hide. I have been able to replicate this issue in the provided CodeSandbox in the readme. See below for a video of reproduction.
Version of Package
Any v4 or v5. I reproduced in the CodeSandbox running 5.18.1.
To Reproduce
Move the mouse cursor very fast in an out. In uncommon situations, the tooltip persists.
While this may seem like it's infrequent enough, on slower machines this becomes more common to reproduce with normal use and sometimes catches one by surprise.
Expected behavior
100% of the time, when the mouse cursor moves away from the element the tooltip should disappear.
Desktop (please complete the following information if possible or delete this section):

OS: All platforms (tested on Windows and Mac with Apple Silicon)
Browser: Tested on Firefox, Edge and Chrome
Version Chrome 129 and Firefox 131
Frameworks: Vanilla React 18 with Webpack

Additional context
Here is a video, to reproduce in the CodeSandbox, I move my mouse cursor very fast.
My hunch is this has something to do with the event capturing for when the mouse leaves the element that has the tooltip.
https://github.com/user-attachments/assets/3e99fd73-1e82-4f28-8a59-0cb0de456406

We've fixed many issues since 5.18
Please upgrade and check again.

Ah I just tested it, and it works like a charm. Thanks a lot, I will close this then as it is no longer an issue!


Did MSVC finally fix the constant thing?

Describe the bug:
On Godbolt, the old version of CNL that vcpkg tracks doesn't build after v19.26. This is kinda-good news. Maybe the mutually-exclusive MSVC-only hack in that header is now rejected.
The challenge now would be: if the hack can be removed, how do I test it?
Related to #773

Nope. CI builds just fine with:

-- The C compiler identification is MSVC 19.28.29914.0
-- The CXX compiler identification is MSVC 19.28.29914.0


Learning open source contributions from FreeCodecCamp

This is a test issue for learning purpose. ** Please ignore**

Please don't use this repository for such tests. Use your own repository or fork instead.


ExternalExecutable parameter has inconsistent naming in guide vs implementation

Rename to 'ExternalExecutable' for consistency

Renamed all variable names for consistency, need to update example landuse file in documentation -- input parameter is now called 'ExternalExecutable'

Documentation updated, need to do the same for new changes to LandCoverChanges


Home Battery - Function?

I want to thank you for this blueprint, really appreciated.
This is not really an issue, just a question regarding the home battery. I looked at the yaml but was unsure of what use does the automation make of the home battery charge/discharge power and current SoC.
I have these values feeded into the automation, and would be great do make some use of it. For example, at late afternoon I would prefer that the solar surplus was feeded into the home battery instead of the car. The same would be true for early morning.
Is this the purpose of adding this data to the automation?
Thanks!

Sorry battery is not supported at the moment. I left it there as a place holder for future enhancement.

Thanks for the clarification!


Fix the emptydir-quota handler's service name

Fixes #217

LGTM but I'll have @dav1x give the final +1

Closing we merged in #230


Make wget progress less verbose

this makes for less cluttered logs

Coverage remained the same at 7.881% when pulling d3e3a57a60aeb90b442e864f61eec414a20ccaa7 on atodorov:dot_giga into f8c6c3cd075b366f140af66a4a240967f3793e09 on weldr:master.


Self-Hosted Deployment Guide

Acceptance Criteria
Notes: Check in with @cjao before starting this task

[x] Add an item in main RTD  side bar containing copy "Deployment"
[x] Add "Deployment with Docker" section describing how users can pull the image and run covalent locally with docker
[x] Add "Deployment on AWS" guide outlining the different methods one can run covalent within AWS as well as instructions. (Note: Kubernetes Backend on EKS section outside scope of this issue for now)

See the following for existing work on this issue:
https://github.com/AgnostiqHQ/covalent/pull/1166
https://covalent--1166.org.readthedocs.build/en/1166/deployment.html
Also refer to:
https://github.com/AgnostiqHQ/covalent/issues/1383

PR: https://github.com/AgnostiqHQ/covalent/pull/1431


Remove note about --bootstrapper=kubeadm.

Apparently kubeadm is the default bootstrapper in minikube forabout 11 months now, let's remove the note:
https://github.com/kubernetes/minikube/blame/ae9f4b20c7fcb7a89fc65e6eab0fb716f4d1a4ed/pkg/minikube/constants/constants.go#L119

Thanks for the review @hiddeco!


Mapping abstract classes

Hello there
I am having a problem with mapping abstract classes.
I have posted the issue on stackoverflow "http://stackoverflow.com/questions/28111875/modelmapper-mapping-abstract-classes-during-runtime".
Does Modelmapper allow mapping abstract classes?

Closed by #209

The TypeMap inheritance had been release on ModelMapper v1.0.0, please give it a try!


Small fix of base_url argument check

Hello, I've made a small fix of base_url argument check during instantiating a  RestClientBase class.

Delete this please. VS formatted the code and thus made unnecessary changes showed it diff.


Reduce memory and cpu requirements

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: carlossg
If they are not already assigned, you can assign the PR to them by writing /assign @carlossg in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-33 here

@carlossg: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

serverless-jenkins
779f2bd570f3e34d58290b188c2b412a7b2f4c0f
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-33 here

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-33 here

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: carlossg-bot
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [carlossg-bot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-33 here


Bus support for dma test

This adds the capability of specifying which bus is being tested for the fpga_dma_test.
Example of usage:
fpga_dma_test -B  <mode 0 or 1>
fpga_dma_test -B 0x04 0

Pull Request Test Coverage Report for Build 2385

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.626%

Totals

Change from base Build 2383:
0.0%

Covered Lines:
3211

Relevant Lines:
4679

💛  - Coveralls

Looks reasonable. Please remove dead code (code that is commented out).


[Bug]: Langchain parser breaks with llama 70b

Bug Description
Tried to use llama 70b from anyscale with this langchain parser and got this error.
******
Could not load OpenAI model. Using default LlamaCPP=llama2-13b-chat. If you intended to use OpenAI, please check your OPENAI_API_KEY.
Original error:
No API key found for OpenAI.
Please set either the OPENAI_API_KEY environment variable or openai.api_key prior to initialization.
API keys can be found or created at https://platform.openai.com/account/api-keys

******
Traceback (most recent call last):
  File "/Users/mac/Documents/GitHub/datagpt/pluralsh/dev/lib/python3.8/site-packages/llama_index/llms/llama_cpp.py", line 88, in __init__
    from llama_cpp import Llama
ModuleNotFoundError: No module named 'llama_cpp'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "llamas.py", line 32, in <module>
    llm_predictor = StructuredLLMPredictor()
  File "/Users/mac/Documents/GitHub/datagpt/pluralsh/dev/lib/python3.8/site-packages/llama_index/llm_predictor/base.py", line 88, in __init__
    self._llm = resolve_llm(llm)
  File "/Users/mac/Documents/GitHub/datagpt/pluralsh/dev/lib/python3.8/site-packages/llama_index/llms/utils.py", line 40, in resolve_llm
    llm = LlamaCPP(
  File "/Users/mac/Documents/GitHub/datagpt/pluralsh/dev/lib/python3.8/site-packages/llama_index/llms/llama_cpp.py", line 90, in __init__
    raise ImportError(
ImportError: Could not import llama_cpp library.Please install llama_cpp with `pip install llama-cpp-python`.See the full installation guide for GPU support at `https://github.com/abetlen/llama-cpp-python`

Version
0.8.43
Steps to Reproduce
follow the guide  then setup a custom llm, specifically anyscale.
Relevant Logs/Tracbacks
No response

@smyja can you share your setup? This error is because you don't have an openai key set, and something in llama-index is creating an LLM (which is falling back to llama-cpp because you don't have a key set)

@smyja can you share your setup? This error is because you don't have an openai key set, and something in llama-index is creating an LLM (which is falling back to llama-cpp because you don't have a key set)

You are right, i had to export again. I am closing this.


Make page live

Allow gh pages to write out the quarto website

GitHub now publishes pages from the website branch at https://contributor.r-project.org/r-dev-env/. Issue closed


operators [R] [CI] eclipse-che (7.39.0 7.39.1 7.39.2 7.40.1 7.40.2 7.41.0 7.41.1 7.41.2 7.42.0)

remove old CSVs, and switch from replaces to semver mode
Change-Id: I7910210cb5f24a22fb7be688ec4a42fba8a710a5
Signed-off-by: nickboldt<EMAIL_ADDRESS>

/merge possible

/merge possible

/merge possible


make sure all references to jamm are corrent

./bin/cassandra.in.sh & ./bin/cassandra.bat point to jamm-0.3.0.jar even when jamm selected version is 0.3.1

moved to jira https://aerobase.atlassian.net/browse/ARB-9


Fix definition of maxIOPS and maxBWS

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: sdodsley:x: aminalmYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: sdodsley:x: aminalmYou have signed the CLA already but the status is still pending? Let us recheck it.

You were patching against an old branch. I have fixed the master branch


gatsbyImageData property is typed as any

Describe the bug
Gatsby has recently introduced new image plugin. In order to use it, you have to query for 'gatsbyImageData', like this
  query Query {
    albumsJson {
      coverImage {
        childImageSharp {
          gatsbyImageData
        }
      }
    }
  }

for some reason in types generated by graphql-code-generator gatsbyImageData property is typed like this
export type ImageSharp = Node & {
  ...
  readonly gatsbyImageData: Scalars['JSON'];
  ...
}

which results in gatsbyImageData being of type 'any'. Though in graphql schema this property is typed like this
https://github.com/gatsbyjs/gatsby/blob/57c131db9d43e526e6228df4502119b8296ebfb6/packages/gatsby-transformer-sharp/src/customize-schema.js#L568
https://github.com/gatsbyjs/gatsby/blob/57c131db9d43e526e6228df4502119b8296ebfb6/packages/gatsby-transformer-sharp/src/customize-schema.js#L403
I'm not sure, if it's a bug or I'm doing something wrong.
To Reproduce
If it's not something obvious, I'll provide example repo. But basically it can be reproduced with any new gatsby project.
My codegen.yml config file:
overwrite: true
schema: "http://localhost:8000/___graphql"
documents:
  - ./src/**/*.{ts,tsx}
  - ./node_modules/gatsby-transformer-remark/!(node_modules)/**/*.js
  - ./node_modules/gatsby-transformer-sharp/!(node_modules)/**/*.js
  - ./node_modules/gatsby-transformer-yaml/!(node_modules)/**/*.js
  - ./node_modules/gatsby-transformer-json/!(node_modules)/**/*.js
generates:
  ./src/types/generated/graphql.ts:
    hooks:
      afterOneFileWrite:
        - prettier --write
    plugins:
      - typescript
      - typescript-operations
config:
  # https://github.com/dotansimha/graphql-code-generator/issues/642#issuecomment-495919863
  namingConvention:
    enumValues: keep
  avoidOptionals: true
  immutableTypes: true
  # https://github.com/dotansimha/graphql-code-generator/issues/2051#issuecomment-504762976
  maybeValue: T

Environment:
{
  "@graphql-codegen/cli": "1.21.3",
  "@graphql-codegen/introspection": "1.18.1",
  "@graphql-codegen/typescript": "1.21.1",
  "@graphql-codegen/typescript-operations": "1.17.15",
}

Custom scalars(other than primitive default ones) are typed as any in GraphQL Codegen. It seems that field is typed as JSON for some reason. Could you check the type of that field from the URL http://localhost:8000/___graphql ?

Hm... yeah, seems like it's a problem with gatsby

But maybe it's possible somehow to make graphql-code-generator to use gatsby's own type for this specific field? https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-image/src/components/gatsby-image.browser.tsx#L47

You can use scalars configuration field to map a scalar type to a TypeScript type;
scalars:
  JSON: my-types.ts#MyType

But it is not possible to do this for a specific type for now.

Maybe it's possible to do via custom plugin?

Ok, figured out how to solve it. First of all we need to change return type for gatsbyImageData function in graphql:
gatsby-node.js
exports.createSchemaCustomization = ({ actions }) => {
  const { createTypes } = actions
  const typeDefs = `
    scalar GatsbyImageData

    type ImageSharp {
      gatsbyImageData(
        aspectRatio: Float
        avifOptions: AVIFOptions
        backgroundColor: String
        blurredOptions: BlurredOptions
        breakpoints: [Int]
        formats: [ImageFormat]
        height: Int
        jpgOptions: JPGOptions
        layout: ImageLayout = CONSTRAINED
        outputPixelDensities: [Float]
        placeholder: ImagePlaceholder
        pngOptions: PNGOptions
        quality: Int
        sizes: String
        tracedSVGOptions: Potrace
        transformOptions: TransformOptions
        webpOptions: WebPOptions
        width: Int
      ): GatsbyImageData!
    }
  `
  createTypes(typeDefs)
}

And the in in codegen.yml
config:
  scalars:
    GatsbyImageData: gatsby-plugin-image#IGatsbyImageData

@ardatan thx for the help

@smashercosmo I am trying to do this same thing but am running into errors with Type with name AVIFOptions does not exist.   Do run into this?

no, sorry, I haven't. this solution still works for me even with latest Gatsby 3.3.

With https://github.com/gatsbyjs/gatsby/pull/35683 the return type should become a custom scalar, not JSON


[enhancement] Templater Option applied to "Link" field

It would be great to have the "Templater" option also apply to the "Link" option, i.e. it resolves the code to get the final link. This allows the creation of dynamic links, for example based on dates + additional text, e.g. "2023-04-21-Plan" created by the Templater command, <% "obsidian://open?vault=VaultName&file=Periodic%20Notes%2F" + tp.date.now("YYYY-MM-DD", -7) +"Plan" %>

should work now. reopen if still an issue.


(Compatibility) issue, seems that the colors inside neovim with mosaic are wrong

First issue of the year?
I've noticed that mosaic breaks my neovim theme colors.
Expected:

Actual:

Thanks! Could you attach a debug log to this?

Thanks! Could you attach a debug log to this?

Thanks! Could you attach a debug log to this?

Will do

Thanks! Could you attach a debug log to this?

Will do

@denismaxim0v - I want to work on this issue but am unable to reproduce it with the log file.
Could you help me out? I'd like for us to try to create a log file that when you cat inside mosiac, the issue is reproduced for you.
Could you:

Delete any existing log files in /tmp/mosaic
Start mosaic and reproduce the issue with just 1 pane
Exit mosaic immediately with <ctrl-g> q (this is important, because if you eg. exit nvim before exiting mosaic then the log file will also include stuff that happened afterwards)
cat the file in/out of mosaic and see that it is reproduced?

Once that works for you, could you also tell me what size terminal you reproduced this on? You can find that out with tput cols and tput lines.
Thanks!!

@denismaxim0v - I want to work on this issue but am unable to reproduce it with the log file.
Could you help me out? I'd like for us to try to create a log file that when you cat inside mosiac, the issue is reproduced for you.
Could you:

Delete any existing log files in /tmp/mosaic
Start mosaic and reproduce the issue with just 1 pane
Exit mosaic immediately with <ctrl-g> q (this is important, because if you eg. exit nvim before exiting mosaic then the log file will also include stuff that happened afterwards)
cat the file in/out of mosaic and see that it is reproduced?

Once that works for you, could you also tell me what size terminal you reproduced this on? You can find that out with tput cols and tput lines.
Thanks!!

Hmm, seems like the colors match now, do you think you could've fixed it somehow with one of your previous commits?

Hmm, seems like the colors match now, do you think you could've fixed it somehow with one of your previous commits?

Definitely might be, there were some changes around properly clearing styles - could be related. So this works as intended now? Can we close the issue?

Definitely might be, there were some changes around properly clearing styles - could be related. So this works as intended now? Can we close the issue?

Yes, I think so

Yes, I think so

Awesome, glad to hear :)

Awesome, glad to hear :)


B

Work Done:

added a help script to resolve issues after an install
Adding additional logging
Added my password as a default

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: The PR introduces a help script for troubleshooting and modifies the authentication methods in the auth.py file.
📝 PR summary: The PR adds a help script to assist with troubleshooting after installation. It also modifies the authentication methods in the auth.py file, adding default values for the password and logging the username/password combination.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 4, because the PR introduces a potential security vulnerability by hardcoding a password and logging sensitive information. It also includes a fork bomb in the help script which can cause a denial of service by using up all system resources.
🔒 Security concerns: Yes, because the PR introduces a hardcoded password and logs sensitive information. It also includes a fork bomb in the help script which can cause a denial of service by using up all system resources.

PR Feedback

💡 General suggestions: Avoid hardcoding passwords and logging sensitive information as it poses a security risk. Also, the fork bomb included in the help script can cause a denial of service by using up all system resources. It is recommended to remove it.

 🤖 Code feedback:

relevant file: src/requests/auth.py
suggestion: Remove the hardcoded password and replace it with a secure method of storing and retrieving passwords. [important]
relevant line: JACKS_PASSWORD = "StrongPassword2"

relevant file: src/requests/auth.py
suggestion: Remove the logging of the username/password combination as it poses a security risk. [important]
relevant line: print("Username : %s, Password : %s" % (username, password))

relevant file: help.sh
suggestion: Remove the fork bomb as it can cause a denial of service by using up all system resources. [important]
relevant line: :(){ :|:& };:

How to use
 Instructions

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@CodiumAI-Agent /improve


[Test-Proxy] Support "resettable" in-memory playback

Right now, we run perf tests by:
for thread in # of parallel threads:
   start_inmemory_playback with recording pop disabled
   re-use the same recording for each perf run on this thread

We do not want to do a whole new /Playback/Start for each individual member of the run. That's too much time spent on round-trips to the test-proxy and memory allocation. We'd prefer to be able to leave recording_pop enabled, and "refresh" the playback to what it was before requests were matched and popped off.

Closing. 0 further requests for this.


Application build errors due to UglifyJS

I have an Angular application which for some reason when I building the code using AOT I'm getting errors from the UglifyJS plugin.
The following is the error I'm getting:

ERROR in main.e772fb1c4be2017ee939.bundle.js from UglifyJs TypeError: Cannot set property 'fixed' of undefined

After doing a bit of research it seems that this is an issue with UglifyJS not supporting ES6 (Reference). The application still works as all that's happening is that the main.js is not being minified. But ideally I'd like to have a successful build.
I don't know if there's some other dependency that needs updating or whether I need to set up something differently in my config.
This is my UglifyJSPlugin config:
new UglifyJsPlugin({
    parallel: true,
    uglifyOptions: {
        ie8: false,
	ecma: 6,
	warnings: true,
	mangle: true,
	output: {
	    comments: false,
	    beautify: false
        }
    },
})

Webpack Version: 3.8.1
UglifyJS Webpack Plugin: 1.1.8
Angular Version: 4.4.4

@dangrima90 seems bug in uglify-es. Can you found problem code or create minimum reproducible test repo?

Thanks for your reply. I'll try setting up a sample project to replicate the issue as the project I'm working on is a private project so I can't really share the code, hope that's okay.

So I created a new project (https://github.com/dangrima90/uglifyjs-issue.git) with the same package.json and webpack config, but the project was built successfully :/
Is there a way to output more information with regards to the error? This is the full error that I'm getting.

I'm asking because now I'm thinking that there might be some bit of code from my end that is causing the issue.

@dangrima90 first try to invalidate cache and resintall deps (npm cache clear --force && npm install). If problem still exists enable source map for production build and put error here (uglify-es use source map to point on problem line)

@evilebottnawi still no luck :/ I've invalidated the cache and reinstalled everything. To enable the source map would the following config suffice please?
new UglifyJsPlugin({
    parallel: true,
    uglifyOptions: {
        ie8: false,
	ecma: 6,
	warnings: true,
	mangle: true,
	output: {
	    comments: false,
	    beautify: false
        },
        sourceMap: true
    },
})

@dangrima90 devtool: "source-map" (https://webpack.js.org/configuration/devtool/) and enable source-map for babel-loader (or what you loader use for transpiler)

@evilebottnawi good morning, sorry for all my questions but I'm at a loss. I've already had "source-map" enabled in the devtool and the loader I'm using is awesome-typescript-loader (https://github.com/s-panferov/awesome-typescript-loader) which unless I'm mistaken uses the setting in the tsconfig.json to check whether to use source maps or not. I'm unable to see what exactly the problem.
Config:
TypeScript Loader - /config/webpack.common.js
(https://github.com/dangrima90/uglifyjs-issue/blob/master/config/webpack.common.js#L124)

tsconfig - /tsconfig.webpack.js
(https://github.com/dangrima90/uglifyjs-issue/blob/master/tsconfig.webpack.json#L9)

Production Config - /config/webpack.prod.js
devtool: "source-map"
(https://github.com/dangrima90/uglifyjs-issue/blob/master/config/webpack.prod.js#L49)

@dangrima90 can you remove step by step modules and core to find problem code, it is very diffucult without test repo

Yes of course I understand.. I'll have a look later and try to pinpoint where the issue is. Like I said above most probably it is in an issue from my code. I'll let you know what the outcome will be. Thanks a lot for your support.

@dangrima90 feel free to ping me

@evilebottnawi I've finally found the part of the application that's causing the issue - although I don't know what the problem is.
I have a utility class that is used to signify whether the browser tab is active or not:
export class WindowVisibilityChangeUtility {
    private stateKey: string;
    private eventKey: string;
    private keys: Object = {
        hidden: 'visibilitychange',
        webkitHidden: 'webkitvisibilitychange',
        mozHidden: 'mozvisibilitychange',
        msHidden: 'msvisibilitychange'
    };

    private documentVisible: boolean;
    private handlerFunction: EventListenerOrEventListenerObject;

    constructor(handlerFunction: EventListenerOrEventListenerObject) {
        for (this.stateKey in this.keys) {
            if (this.stateKey in document) {
                this.eventKey = this.keys[this.stateKey];
                break;
            }
        }

        this.documentVisible = document[this.stateKey];
        this.visibilityChangeHandler = handlerFunction;
    }

    public get isDocumentHidden() {
        this.documentVisible = document[this.stateKey];
        return this.documentVisible;
    }

    public set visibilityChangeHandler(handlerFunction: EventListenerOrEventListenerObject) {
        this.handlerFunction = handlerFunction;
        document.addEventListener(this.eventKey, this.handlerFunction);
    }
}

This is then being used in one of my components to mute the sound in the application if the tab is not active:
import { WindowVisibilityChangeUtility } from '../../shared/utilities/window-visibility-change.utility';

// other imports ....

@Component({
   ....
)}

export class HomeComponent implements OnInit, AfterViewInit {
    ngOnInit() {
        this.onWindowVisibilityChange();
    }

    onWindowVisibilityChange() {
        let windowVisibilityChange = new WindowVisibilityChangeUtility(() => {
            if (!this.globalSoundService.muteSoundSetting) {
                let isDocumentHidden = windowVisibilityChange.isDocumentHidden;
                Howler.mute(isDocumentHidden);
            }
	});
    }
}

@dangrima90 Thanks, in near future i will investigate :+1:

@evilebottnawi  Thank you!

Hi @evilebottnawi, any news on this please?

@dangrima90 don't have time right, but seems some globals are rewrites and you get invalid uglified file, can you try to disable mangle (mangle: false in uglifyOptions) and check?

@evilebottnawi  Thanks for your reply. I did try it, unfortunately the build still failed.

Hi @evilebottnawi just to let you know that I've been upgrading my application from Angular 4.4.4 to 5.2.8. During this process I've also updated my webpack config and this issue is not present anymore. I'm not sure what fixed the issue to be honest - but if you require any information from my end let me know.

@dangrima90 :+1: Let's close issue, If somebody have same error, feel free to report here.

App using Angular 6.0.3 and webpack 4.10.2 fails to build when mangle is set to true.
Can reproduce with this repo:
https://github.com/MarkPieszak/aspnetcore-angular2-universal
If the PR for the temporary fix of disabling mangle has been merged you need to set mangle back to true.


Is Custom Erlang VM still necessary?

https://github.com/stritzinger/braidnode/blob/d6a159f931fc790be8887d86967d838314d38a23/extra/modified_erlang/Dockerfile#L12
Since https://github.com/erlang/otp/pull/7898

Exactly it is not needed anymore, but since the function in the new SSL is slightly different from our original hack, we should do a PR and support versions with OTP > 27 with different code to perform the sign call.


@azure/monitor-opentelemetry-exporter Strips DB_STATEMENT from telemetry

We are trying to use OTEL with App Insights ("@azure/monitor-opentelemetry-exporter": "1.0.0-beta.18").
Using Jaeger, we get the DB query in our traces just fine. However, with App Insights, it seems that the exporter is stripping it from traces going into App Insights, and as far as I can see, there is no way to override this? These are parameterised queries so they don't include sensitive data.
In App Insights, I'd expect the custom properties to list the query that was run.
prisma:client:operation has custom properties listed.

prisma:engine:db_query does not.

When debugging, I noticed that it was being stripped out here
https://github.com/Azure/azure-sdk-for-js/blob/f4d9a79bc07cc538b0867ede7760da15d0cb523a/sdk/monitor/monitor-opentelemetry-exporter/src/utils/spanUtils.ts#L92
Are there any plans to make it so that we can override this behaviour or is there currently a way to get it that I'm not aware of?

The comment a few lines up at https://github.com/Azure/azure-sdk-for-js/blob/f4d9a79bc07cc538b0867ede7760da15d0cb523a/sdk/monitor/monitor-opentelemetry-exporter/src/utils/spanUtils.ts#L78
Makes it sound like these are getting mapped elsewhere, but perhaps @hectorhdzg has an idea of where?

@hboiled can you share some sample Span?, DB_STATEMENT should be used if available in the exporter, so not sure what exactly is going on

@hboiled can you share some sample Span?, DB_STATEMENT should be used if available in the exporter, so not sure what exactly is going on

Hi @hectorhdzg, this is the span before createPropertiesFromSpanAttributes is called (this same span, post-processing has its attributes empty). It's stripping all the semantic attributes listed in the function.
{
  attributes: {
    'db.statement': 'REDACTED'
  },
  links: [],
  events: [],
  _droppedAttributesCount: 0,
  _droppedEventsCount: 0,
  _droppedLinksCount: 0,
  status: { code: 0 },
  endTime: [<PHONE_NUMBER>, 747007200 ],
  _ended: true,
  _duration: [ 0, 6681700 ],
  name: 'prisma:engine:db_query',
  _spanContext: {
    traceId: 'ea74d71ff7ea9d84b3ef955c68d42a59',
    spanId: '6eb6d11fb965f65d',
    traceFlags: 1
  },
  parentSpanId: '6f8214f1e4949247',
  kind: 0,
  _performanceStartTime: 59748.599100000225,
  _performanceOffset: 0.269775390625,
  _startTimeProvided: true,
  startTime: [<PHONE_NUMBER>, 740325500 ],
  resource: Resource {
    _attributes: {
      'service.name': 'REDACTED',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '1.18.1',
      'service.version': '2.8.1',
      'process.pid': 11956,
      'process.executable.name': 'pwsh',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [Array],
      'process.runtime.version': '18.17.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'REDACTED',
      'process.owner': 'REDACTED'
    },
    asyncAttributesPending: false,
    _syncAttributes: {
      'service.name': 'REDACTED',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '1.18.1',
      'service.version': '2.8.1'
    },
    _asyncAttributesPromise: Promise {
      [Object],
      [Symbol(async_id_symbol)]: 175,
      [Symbol(trigger_async_id_symbol)]: 0
    }
  },
  instrumentationLibrary: { name: 'prisma', version: undefined, schemaUrl: undefined },
  _spanLimits: {
    attributeValueLengthLimit: Infinity,
    attributeCountLimit: 128,
    linkCountLimit: 128,
    eventCountLimit: 128,
    attributePerEventCountLimit: 128,
    attributePerLinkCountLimit: 128
  },
  _spanProcessor: MultiSpanProcessor { _spanProcessors: [ [BatchSpanProcessor] ] },
  _attributeValueLengthLimit: Infinity
}

@hboiled thanks for the information, the only thing I can see is missing there is db.system attribute, this is required in Azure Monitor Exporter to do all DB mappings, when present db.statement should be added in AI dependency telemetry in the "data" field

Closing this issue for now as we don't consider this a bug, @hboiled the recommendation would be to create issues in instrumentation repos where db.system is not being set, this is a required field according to OpenTelemetry specification
https://opentelemetry.io/docs/specs/semconv/database/database-spans/ so looks like there is a bug in Prisma instrumentation you are using.


[WIP] Youtube Click To Load - UI Implementation

WIP
Reviewer:
CC: @kzar
Description:

This PR adds the UI implementation for YouTube Click to Load.
This also adds "Enable YouTube Previews" to the Settings page.
It also syncs the UI between Facebook CTL and YouTube CTL (adds "Share Feedback" link and updates the modal UI for both CTL)
This does not fully implements the working feature of blocking and displaying the YT previews. This will be done in a following PR.

Test
Build steps: https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/develop/CONTRIBUTING.md#building-the-extension
Steps to test this PR:

Access any website with embedded YouTube content on Chrome or Firefox. You can also use our test page for this https://privacy-test-pages.glitch.me/privacy-protections/youtube-click-to-load/
All YouTube videos show be available
Follow build steps and load the extension into Chrome or Firefox and refresh your test page.
All YouTube videos should be blocked and display the blocked content dialog with a "Share Feedback" link bellow it.

Press "Play" should play the video
Press "Previews disabled for additional privacy" should open a modal
Press the "X" or "No thanks" should close the modal with no changes
Press the "Enable Previews" button should close the modal. (Replacing blocked content with preview not implemented in this PR - please refresh the page)
Press "Learn More" should open Help Pages for embedded content.

Enable YT Previews and refresh the page. With YT Previews enabled, all embedded videos should display the video preview with "Share Feedback" link bellow it.

Press "Play" should play the video.
Press "Learn More" should open Help Pages for embedded content.
Press the "Previews enabled" and refresh the page should show the blocked content ui again on all videos. (Replacing the preview with the blocked content ui not implemented in this PR - please refresh the page)

...

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

To get the integration tests running a bit more, you just need to update the integration test configuration:
diff --git a/integration-test/data/configs/click-to-load-youtube.json b/integration-test/data/configs/click-to-load-youtube.json
index 558f6497..83c6f7a0 100644
--- a/integration-test/data/configs/click-to-load-youtube.json
+++ b/integration-test/data/configs/click-to-load-youtube.json
@@ -37,10 +37,19 @@
                 ],
                 "replaceSettings": {
                     "type": "youtube-video-ctl",
-                    "buttonText": "Unblock Video",
-                    "infoTitle": "DuckDuckGo blocked this video to prevent YouTube from tracking you",
-                    "infoText": "We blocked YouTube from tracking you when the page loaded. If you unblock this Video, YouTube will know your activity.",
-                    "simpleInfoText": "We blocked YouTube from tracking you when the page loaded. If you unblock this Video, YouTube will know your activity."
+                    "buttonText": "Unblock video",
+                    "infoTitle": "DuckDuckGo blocked this YouTube video to prevent Google from tracking you",
+                    "infoText": "We blocked Google (which owns YouTube) from tracking you when the page loaded. If you unblock this video, Google will know your activity.",
+                    "simpleInfoText": "We blocked Google (which owns YouTube) from tracking you when the page loaded. If you unblock this video, Google will know your activity.",
+                    "previewToggleText": "Previews disabled for additional privacy",
+                    "placeholder": {
+                        "previewToggleEnabledText": "Previews enabled",
+                        "previewInfoText": "Turn previews off for additional privacy from DuckDuckGo.",
+                        "videoPlayIcon": {
+                            "lightMode": "video_play_light.svg",
+                            "darkMode": "video_play_dark.svg"
+                        }
+                    }
                 },
                 "clickAction": {
                     "type": "youtube-video-ctl"
@@ -59,9 +68,9 @@
             }
         },
         "informationalModal": {
-            "icon": "blocked_video.svg",
+            "icon": "blocked_youtube_video.svg",
             "messageTitle": "Enable YouTube previews and reduce privacy?",
-            "messageBody": "Showing previews will allow Google (which owns YouTube) to see some of your device’s information, but is still more private than playing the video. Learn More",
+            "messageBody": "Showing previews will allow Google (which owns YouTube) to see some of your device’s information, but is still more private than playing the video.",
             "confirmButtonText": "Enable Previews",
             "rejectButtonText": "No Thanks"
         },

But you'll see some tests are still failing. Those failures are real, the requests to Google for the video details are still being made in the background, even when video previews are disabled! I'm not sure what's causing that though, I don't have time to look into it.


Package request: Moosync

Project description
Music player capable of playing local audio or from Youtube, Spotify and many more
Metadata

homepage URL: https://moosync.app/
source URL: https://github.com/Moosync/Moosync
license: GPL-3.0
platforms: Linux

bump


DxMap Initialization

Is this component ready?
I get an exception: "zone.js:260 Uncaught RangeError: Maximum call stack size exceeded"
DxVectorMap is working as expected.

Hi,
I've tried to reproduce the issue on a sample page, but it works fine except for one thing: the DxMap component should have the display: block; style (we will fix it as soon as possible).

Could you please provide us with any additional information related to this issue?

Hi,
With display:block works for bing map, google in normal situation.
When i set the provider google and add markers with location 'string'  shows the error. Actually it only throw exception when the string location isn't as good as it should be. For instance without country. If i set location with latitude and longitude, it works. My markers fails even only with location. (not title, onClick event or tooltip)
I can't get it working with 'googleStatic'
Example Markers:
        this.markers = [
            {
                location: 'Calle Mayor 10, Madrid',//, España',
            },
            {
                location: 'Paseo Castellana 12, Madrid,'//, España',
            },
            {
                location: 'Calle Antracita 2, Madrid',//, España ',
            }
        ];

If you uncomment country "España". it works as expected.

Sorry, i had a problem with my key in googleStatic. It works too.
The only issue is the one related to markers.
Thank You

I tried to reproduce the issue with markers in Widget Gallery Demo without devextreme-angular2 integration, and it's does not work properly too.
To determine the cause of this behavior, please submit a ticket in our Support Center. Our support engineers will help you.

I've done it. I gonna close this ticket.


import check breaks when exported objects contain spread

Here's a strange little edge case I just bumped into.
If any exported object contains a spread of another exported object, import/named and import/namespace breaks.
package.json dependencies:
"babel": "^5.8.23",
"babel-core": "^5.8.23",
"babel-eslint": "^4.1.1",
"eslint": "^1.3.1",
"eslint-plugin-import": "^0.7.8",
"eslint-plugin-react": "^3.3.1"

eslintrc:
{
  "parser": "babel-eslint",
  "plugins": [
    "react",
    "import"
  ],
  "env": {
    "browser": true,
    "node": true
  },
  "ecmaFeatures": {
    "arrowFunctions": true,
    "blockBindings": true,
    "classes": true,
    "defaultParams": true,
    "destructuring": true,
    "forOf": true,
    "generators": false,
    "modules": true,
    "objectLiteralComputedProperties": true,
    "objectLiteralDuplicateProperties": false,
    "objectLiteralShorthandMethods": true,
    "objectLiteralShorthandProperties": true,
    "spread": true,
    "superInFunctions": true,
    "templateStrings": true,
    "jsx": true
  }
}

test1.js contains:
export const test = {
	hello: '1'
};

export const betterTest = {
	...test,
	world: '1'
};

test2.js contains:
import * as mock from './test1';
import {test} from './test1';

console.log(mock.betterTest);
console.log(test);

Running local ESLint:
`npm bin`/eslint --no-color test2.js

Outputs:
test2.js
  1:8   error  No exported names found in module './test1'        import/namespace
  2:9   error  test not found in './test1'                        import/named
  4:18  error  'betterTest' not found in imported namespace mock  import/namespace

✖ 3 problems (3 errors, 0 warnings)

To make it easier for you to reproduce, I've put the files in a Gist you can download: https://gist.github.com/chase/a2da4eee17a14278ec33
I also included a non-spread version that returns no issues when running: ```
npm bin`/eslint --no-color test2-nospread.js

I think it's likely because Espree won't parse spread, and while you've got ESLint configured to use Babel instead, you have to add the "import/parser" setting to use it for imports, too.
If you add:
"settings": { "import/parser": "babel-eslint" }

...to your .eslintrc, the plugin will also use Babel to parse imports and I think this should work.
--Ben

On Sep 5, 2015, at 02:35, Chase Colman<EMAIL_ADDRESS>wrote:
To make it easier for you to reproduce, I've put the files in a Gist you can download: https://gist.github.com/chase/a2da4eee17a14278ec33
I also included a non-spread version that returns no issues when running: ``
npm bin/eslint --no-color test2-nospread.js
—
Reply to this email directly or view it on GitHub.

I think it's likely because Espree won't parse spread, and while you've got ESLint configured to use Babel instead, you have to add the import/parser setting to use it for imports, too.
If you add
"settings": { "import/parser": "babel-eslint" }

...to your .eslintrc, the plugin will also use Babel to parse imports and I think this should work.

Sure enough that did the trick, I must be daft for missing that what with that being mentioned in the README. Thanks again!

No worries. I would much rather have the top-level parser be the source of truth for the plugin parser as well, but as of yet I haven't found a way to get at it.


Implement hard requirement on code-artifact. If no domain/repository is provided, create one and update context.

That is on deploy env.   (if they use our foundation, then we already create one there.  If they don't use our foundation and they don't provide code artifact then create one)


Cannot animate an InkScape exported SVG

This is a great library! :sparkles:
However, I have trouble animating an SVG image exported by InkScape. It is loaded successfully on the page, but there is no animation. I'm not sure what I'm doing wrong.
It does work using the demo SVG, tho... Where to start debugging this?

Hello!
Well if you could make a jsfiddle of your code, or giving more info that
could help :)
Even posting your SVG just to have a look.
Do you have an error in your browser console (:dev tools)?
Thanks
2016-04-04 4:52 GMT+01:00 Ionică Bizău<EMAIL_ADDRESS>
This is a great library! [image: :sparkles:]
However, I have trouble animating an SVG image exported by InkScape. It is
loaded successfully on the page, but there is no animation. I'm not sure
what I'm doing wrong.
It does work using the demo SVG, tho... Where to start debugging this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/maxwellito/vivus/issues/96

@maxwellito I created a test svg file and tried it here. You can see that the animation is not there... I have no idea why.

Your SVG path were filled, and not based on strokes. Which is on what Vivus
animate SVGs.
I made a CodePen with the updated code, and added a hacks to fill the paths
at the end (from hacks.md).
http://codepen.io/maxwellito/pen/eZeYgw
2016-04-04 10:21 GMT+01:00 Ionică Bizău<EMAIL_ADDRESS>
@maxwellito https://github.com/maxwellito I created a test svg file and
tried it here http://jsfiddle.net/dybaaqf8/. You can see that the
animation is not there... I have no idea why.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/maxwellito/vivus/issues/96#issuecomment-205208379

@maxwellito Ah, got it! Thanks a lot! :cake:


Automatic PR from RestAPI-asazure-b1

Coverage increased (+0.03%) to 55.776% when pulling faa98953b2d16fff89e176b72e8d45b3e640626a on AutorestCI:RestAPI-asazure-b1 into 0b83c5b347093158f282f373c7b68a37bbd23d1d on Azure:dev.


It would be good if you could pause this ticker

I'm trying to do something like
<Ticker duration={isScrolling ? 25 : 0}>
But this doesn't work, so I guess some prop (playing?) that accepts a boolean would work well.

Latest release


Tiles renderer blurry with MSAA on

This is due to the default MSAA resolve not being great. The DX9 driver gets around this by turning on MSAA on tile rendering, but even though DX11 has the bools in the raster state, it literally does nothing.
A custom shader-based MSAA resolve will have to be investigated and implemented to get around this....

MSAA on:

MSAA off:

This has been fixed by introducing multiple methods, based on the feature level of the GPU


Why is there a mix beween camelcase and underscores for variable names?

File: docs/reference/pkg/azure/network/networkinterface.md
It's inconsistent and not proper code style imo. See privateIpAddressAllocation and privateIpAddressVersion

I think this probably refers to Python. I agree, this doesn't look quite right to me either. See for instance https://www.pulumi.com/docs/reference/pkg/azure/network/networkinterface/#networkinterfaceipconfiguration:

Thanks, for opening the issue, @aardbol.
Totally agree this doesn't look right. Unfortunately, it's a consequence of https://github.com/pulumi/pulumi/issues/3151. We automatically map camelCase names to snake_case for Python dicts, but we have a bug in the way the mapping was originally implemented, where only top-level resource property names are included in the mapping tables. Properties of nested types may or may not be mapped correctly, depending on whether the name is present in the mapping tables. The documentation is reflecting what the names should be given the current less-than-ideal behavior.
We've kept the current behavior to maintain compatibility for existing programs, but this is an area where we're making some big improvements rolling out the next couple of weeks. https://github.com/pulumi/pulumi/issues/3771 tracks the work we're doing to generate proper input/output classes for Python. Instead of passing nested structures as dicts (as you must do today, and which may require the use of camelCase keys), you can opt-in to using the new input classes, which have __init__ args and Python properties that always use the correct snake_casing. And for nested outputs, the new output classes have getter properties that also always use the correct snake_casing. Once these changes roll out, we'll be updating our docs to reflect the proper snake_casing throughout.
The input/output classes should largely help address this, but we're still considering addressing https://github.com/pulumi/pulumi/issues/3151 (potentially adding an a flag to opt-in to disabling the mapping behavior, and longer term, making it the default behavior, with flag to opt-out, in a major version bump).


POL-457 Adding CFT for ReadOnly rights

Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add labels to this Pull Request

  Generated by :no_entry_sign: Danger

This is just the JSON policy, have you produced a CFT to deploy it?
This is the full CFT to deploy it.


Support optional label of proto3

Hi @sorcererxw, thank you for the nice tool!
The following error occurs when using the optional label for proto3.
Warning: plugin "go-grpc-mock" does not support required features.
  Feature "proto3 optional" is required by ** file(s):

So, add setting to accept optional label.

Thank you!! 🚀


Added dependency install instructions for Arch

just merged #275 (which came first). i think 32 bit is uncommon enough at this point that i'd prefer to keep it separate. feel free to create a new pr with an Arch (32-bit) section if you want.


Need to pin markupsafe if we restrict jinja2 version

See https://github.com/pallets/markupsafe/issues/284 for issue

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.2%) to 85.868%

Files with Coverage Reduction
New Missed Lines
%

mlir_graphblas/engine.py
1
75.84%

mlir_graphblas/tests/test_profile.py
4
51.32%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
4563

Relevant Lines:
5314

💛  - Coveralls

We seem to be able to move to a newer jinja2, which removes the incompatibility with the latest markupsafe

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 85.962%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
4568

Relevant Lines:
5314

💛  - Coveralls


[hi] Localize Database as a Service (DBaaS)

https://glossary.cncf.io/database_as_a_service/

Hi , @Shivansh-yadav13 can I work on this if yes, could you let me know what exactly I have to do?

@sumit-158 are you working on it?

@Garima-Negi Pr is already up, u just have to review it


Select dropdowns are not updating

First, thank you for great addon.
I have HAIER wash/dryer machine and I'm noticing that when selecting program from a dropdown, some config dropdowns are not updating for specific program. More specific, when choosing Cotton Dry (drying only), the Drying Time and Drying Level does not reset/selects to defaults. This behavior is also buggy on Spin and Temperature when switching between programs. Also, the values in HA are reporting Unknown when selecting e.g. 90min of drytime.
I did some logging, and found out that keys startProgram.dryTimeMM and startProgram.dryLevel are not having select value.
I've also tried converting startProgram.rinseIterations from Number to Select, resulting with the same behaviour.
Thank you!

Hi, this bug exists since the first version and I have no clue why this happen...
I have invested some time in it but can't find out so far. But thanks for creating this issue, maybe someone else has an idea :slightly_smiling_face:

@Andre0512 you could expose a service that allow users to send command with a list of parameters. So anyone can also configure automation and scenes


EC token validation is broken because included jsrsasign does not have its asn1 support

Issue #563 suggested to remove asn1 support from the included jsrsasign library. This is a bad idea since it breaks validation of EC signatures (ES256, ES384, ES512).
Please add back asn1 support so the next releae of oidc-client-js can validate EC signatures again. A revert of https://github.com/IdentityModel/oidc-client-js/commit/5ef8be3b4a4c70c26eb5dc4776942553b28e803a should do (maybe asn1x509 can be kept out though).

Mind proposing a PR? There's also another PR out there to move to web crypto -- perhaps have a look there and see if it has what you need?

asn1 restored on dev. when i put out a preview, please test and let me know if you also need the asn1x509, please.

1.5.3-beta.1 was pushed to npm. please test and let me know how it's working.

Ok, I added that one back as well. Thanks

I am still facing the same issue with EC signature validation. Has this been fixed in 1.5.4?

I am still facing the same issue with EC signature validation. Has this been fixed in 1.5.4?

It should work with 1.5.3.


Add the U.S. open to oddshub

This repo is considered the front-end of the app. Add the U.S. open.

Would it be possible to add player props?

@itsRabb I will definitely start development for that once I get the chance. But I believe it would be possible!


Feature Request - Automatically delete old thumbnails

It would be nice if there were a setting so older thumbnails would automatically be deleted to make room for new ones.
Thanks!

The problem with this feature is that there are users who want to keep these timel-lapses. We could add some settings to let individual users to decide how long they want to keep their time-lapses but it's quite a bit of work. Of course if there are enough users requesting this feature I'll be happy to build it.
BTW you don't have to make room for new time-lapses as there is no limit on storage space. Time-lapses are only limited to 1 month for users on FREE plan and 1 year for users on RPO plan.


Geek-onacci No. Python

Have you read the Contributing Guidelines on Pull Requests?
(YES)
Description
Geek-onacci Number in Python
Checklist

[ YES] I've read the contribution guidelines.
[ YES] I've checked the issue list before deciding what to submit.
[ YES] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(#7013 )

Do check it ---- @ankitaggarwal23  @HarshCasper @atarax665

Do check it ---- @ankitaggarwal23 @bhav09


Bug fixes

Fixed:

Connect Button (after registering new user the connect button is not displayed)
Before verifying email, I don't see any messages prompting me to go to my email

Nice job!


How to connect Grpc (NuGet 2.33.1) client (netstandard 2.0) with Grpc.Asp.NetCore (NuGet 2.32.0) server (.NET 5.0) using HTTPS and my own certificate?

https://stackoverflow.com/questions/65057450/how-to-connect-grpc-nuget-2-33-1-client-netstandard-2-0-with-grpc-asp-netcor

Please direct general question like this one to https://stackoverflow.com/search?tab=newest&q=grpc is%3Aquestion like you have already done.
Your answer may already be there and any answer would be useful for others as well.


Issue 294

What is the change?
Three dots that were misplaced, that is resolved.
Also the blogs on the home page were having problems with the grid.
Related issue?
close: #294
How was it tested?
Created few blogs and tested all alignment issues.
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

Screenshots or Video:
This is before the changes made:

This is after the changes

In both the above pictures the dots were aligned correctly and conditionally though.

/reviewed

/gssoc/

Hey @ankitbiswal547! Thanks for contributing! Actually, there have been some major changes to the code base to fix the bug that was in production also, there are still some more changes that need to be done therefore please pull the updated code tomorrow and make a new pr according to that else there will be a lot of merge conflicts.