Migrate to C++17

Here is my attempt to migrate libpointmatcher to C++17. Unlike https://github.com/norlab-ulaval/libpointmatcher/issues/511 , I didn't encounter any errors related to gtest version. It should compile on Ubuntu18.04 and the following releases.
Supporting Bionic is, at the moment, the only thing holding us back from going straight to C++20.

I will test it on my computer today, but the code looks good, good job!

@boxanm I'm bypassing the branch protection rule since all test has passed and @simonpierredeschenes approved the the change as a code owner.  The missing check was due to a miss-configuration in the CODEOWNERS file that required an approval by @pomerlef  on all changes to the codebase. I'll push a fix so that he receive request for selected files that require admin oversight and keep the rest of the codebase under the responsibility of the maintainer group


Split configuration into config.yml and database part.

Now all configuration is config.yml based. It means that we can't e.g. turn off plugin or change configuration without restarting application.

#80 moved plugin setup into database, yet still it's required to restart app.


Log in with username

For example, if I want a login method with user name instead of e-mail.
@sportfogadas in https://github.com/delight-im/PHP-Auth/issues/11

You can't just provide a login with usernames as they are stored currently. The reason is that usernames are (intentionally) not required to be unique. The unique identifier with this library is the email address.
We didn't want to require usernames to be unique as well, since usernames could also be used as display names or nicknames that don't need to be unique.
But there's definitely something we could do in order to provide that feature nonetheless:
We could add an additional method named registerWithUniqueUsername that, as the name suggests, ensures that the username that you sign up with is always unique.
Having added that new safeguard then, we could add another new method named loginWithUsername that does just what you want. Of course, if there were two accounts with the same username, e.g. because you forgot to use registerWithUniqueUsername once and used the simple register instead, it would throw an exception.
What do you think?

That can be an option of course, but wouldn't it be simpler to simply make the username column unique in the database? I didn't check all the code but I could see there was an IntegrityConstraintViolationException caught at insert, that could just as well work in case of unique usernames. Of course, if you do this and somebody upgrades their older library, it will break it.
That's why I think extending it if you want something done differently is a better option. I did change all private methods to protected in my own downloaded version and extended it overriding the login method and extending it with a couple of new ones. For example I needed a special add function that didn't have throttling (importing an existing user database). This way all this can be done with ease. It's just an idea.

but wouldn't it be simpler to simply make the username column unique in the database? I didn't check all the code but I could see there was an IntegrityConstraintViolationException caught at insert, that could just as well work in case of unique usernames.

That's correct, well spotted! Your solution would work, but it's just not that portable and maintainable.

For example I needed a special add function that didn't have throttling (importing an existing user database).

Another great use case for additional methods that need to be added. Thank you!
I agree that there are several methods that need to be added in the future, e.g. logging in with username and creating accounts without throttling, which you mentioned. But as I said, changing the database structure as needed or opening up everything for inheritance are just not the most elegant solutions.
For the login with username, I had already proposed a solution above.
Regarding the new feature of adding (multiple) accounts without throttling, I think that could be part of an administration suite. Why not let a new $auth->admin() expose an administration interface that allows for accounts to be created, viewed or deleted? We could add this to this library, freeing everyone from the need to add those features themselves through inheritance.

Surely there are many possible solutions to one problem. Maybe the whole admin part should be separated into a different class and Auth should only handle the public side (login, registration, password change etc). These are just some random thoughts. What I like about this class is that it's lightweight and simple. For me it was a great starting point on which to build. Other will have different needs.

Maybe the whole admin part should be separated into a different class and Auth should only handle the public side (login, registration, password change etc).

Absolutely agree! The accessor $auth->admin() was meant to return an instance of that new Administration class where methods such as $auth->admin()->createUser(...) or $auth->admin()->deleteUser(...) will be available.

What I like about this class is that it's lightweight and simple.

It's really meant to stay that simple and lightweight. With a proper design, this is possible.

For me it was a great starting point on which to build. Other will have different needs.

Well, that's certainly right, but the ultimate goal of this library is to unify all features and abstractions that most people need, so that (almost) nobody has to do the work of extending the feature set (which you just have done). It can save everybody some effort and time.
Let's leave this issue here open. At least the two features of logging in with one's username and creating users as an administrator will definitely be added.

The new registerWithUniqueUsername method has been added in https://github.com/delight-im/PHP-Auth/commit/dac2850aba8126e8594bff609dda029e8c8fe4c3, as a first step.

... and the new method loginWithUsername is now available as well: https://github.com/delight-im/PHP-Auth/commit/3cb2284870acf83e374f32c5358ad3c31c84ed9c
Throttling can practically be disabled by calling setThrottlingOptions as documented here. Nevertheless, the new administration interface described above will be added as well.


[Snyk] Security upgrade python from 3.13.0a2-slim-bullseye to 3.13.0rc1-slim-bullseye

Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

Dockerfile

We recommend upgrading to python:3.13.0rc1-slim-bullseye, as this image has only 75 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Improper Verification of Cryptographic Signature SNYK-DEBIAN11-GNUTLS28-6159417
  614

Information Exposure SNYK-DEBIAN11-GNUTLS28-6159419
  614

Out-of-bounds Write SNYK-DEBIAN11-PERL-6085272
  614

Information Exposure SNYK-DEBIAN11-GNUTLS28-6062102
  514

Out-of-bounds Read SNYK-DEBIAN11-TAR-3253527
  514

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):
* `Dockerfile`

We recommend upgrading to python:3.13.0rc1-slim-bullseye, as this image has only 75 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:
Issue 	Score
 	Improper Verification of Cryptographic Signature
SNYK-DEBIAN11-GNUTLS28-6159417 614
 	Information Exposure
SNYK-DEBIAN11-GNUTLS28-6159419 614
 	Out-of-bounds Write
SNYK-DEBIAN11-PERL-6085272 614
 	Information Exposure
SNYK-DEBIAN11-GNUTLS28-6062102 514
 	Out-of-bounds Read
SNYK-DEBIAN11-TAR-3253527 514
Important
* Check the changes in this PR to ensure they won't cause issues with your project.

* Max score is 1000. Note that the real score may have changed since the PR was raised.

* This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:  🧐 View latest project report 📜 Customise PR templates 🛠 Adjust project settings 📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


Call redirect function on dashboard layout if user not found

This is not really an issue but a suggestion :
You probably should call redirect to login for users on the dashboard if the user is not in the session :
import { redirect } from 'next/navigation';

// ... rest of the code

export default async function DashboardLayout({
  children,
}: DashboardLayoutProps) {
  const user = await getUser()

  if (!user) {
	// here
    redirect('/login');
  }

  return ( ... );
}

The docs on redirect are here : https://beta.nextjs.org/docs/api-reference/redirect

I've updated next-auth and fixed this using middleware. Thanks @Fredkiss3 :)


Suggestion on the styling

Suggestion !
Hey, first of all i really like this concept. But some things could be done to make it more great ! What if the mouse blob color also changes according to the color you update ? Would be very great !

Added yay


use proto if Object.setPrototypeOf() doesn't exist

Fixes #4

@petkaantonov pinging you in case you missed this.


withProperties function and changes same array?

I am using blow function for my project but i want to insert db also changes attributes an array. How can i do it ?
Like this: {"attributes":{"photo_id":420},"old":{"photo_id":418,{"activityCSS":"

"}}}
activity()
->performedOn($user)
->causedBy($user)
->withProperties(['activityCSS' => ' '])
->log('profile photo changed.');

The package can log changed attributes for you.
Take a look at the relevant docs: https://docs.spatie.be/laravel-activitylog/v2/advanced-usage/logging-model-events#logging-model-events

Yes , but i want to be log with custom property and changes in same time. Can you write me an example?


Is this project active?

If yes, it is usable in production (stable)?
Who is using it?
Where I can find a demo or  at least videos or screenshots?

Not ready for production
VyControl need someone to finish it


Travis build failed as Listen dependency does not support Ruby 2.2.x

Scenario/Intent
Travis build failed as Listen dependency does not support Ruby 2.2.x.  Click here
Below is the summary:
Gem::RuntimeRequirementNotMetError: listen requires Ruby version ~> 2.2, >=
2.2.7. The current ruby version is 2.2.0.
An error occurred while installing listen (3.2.0), and Bundler
cannot continue.
Make sure that gem install listen -v '3.2.0' --source 'https://rubygems.org/'
succeeds before bundling.
Environment Details

Ruby Version: 2.2.6

Steps to Reproduce
Do some code changes and commit your code. Tarvis build will fail for Ruby 2.2.6
Expected Result
Should be able to pass the Travis build without any issues.
Actual Result
Travis build failed for Ruby 2.2.6 version only.

Just adding one more thing here that support for Ruby 2.2 has ended. Please refer to this link. It would be great if we support latest ruby versions and remove versions which are no longer supported.


Analyze Wallet Transactions

Look for direct trades, contracts and donations

Stuff to look for:

RefTypeID 1 (Direct Trade)
RefTypeID 10 (Player Donation)
RefTypeID 37 (Corp Donation)

Contracts if possible.

Wallet API Reference
RefType Reference


Sprint 2 - Requirements from Manulife

Requirements and use cases mapped to Sprints:
Requirements.docx

For readability, the requirements are listed here from the attached word document.

Use case 1:  As a operator I should be able to map a PCF foundation to one or multiple Organization in Atlas (Sprint 2)
Use case 2: As an Operator, I should have access to a complete documentation on how to deploy an configure the new Service Broker  (Sprint 2)

Use case 3: As a user, I should be able to create a service instance within a single-region  (Sprint 2)
Note: Backup should be enabled by default.
Use case 4: As a user, I should be able to create a service instance that spans multi-regions  (Sprint 2 or Sprint 3?)
Note: Backup should be enabled by default.
Use case 5:  As a user, whenever I create a service instance, the associated cluster should be in its own Atlas project. (Sprint 2)
Use case 6: As an Operator, I should be able to enable different plans for a service broker  (Sprint 2)
Use case 7:   As a user I should be able to configure PIT for my cluster (Sprint 3/4?)
Use case 8: As a user I should be able to delete an existing service instance (Spring 2)
Use case 9: As a user, I should be able to bind my app to a existing service instance   (Sprint 2)
cf 			update-service my-m20-cluster -c {"action":"pause"}

Use case 13: As a user, I should be able to specify the version of MongoDB when creating a new service instance (Spring 2)


FRI Interpolation Error

Hey,
First of all, thank you for your work on this nice interface. I recently discovered it.
However, when starting the command mode, I always get the "FRI interpolation error", which enables the brakes and then returns back to monitor mode. I tried to move the joints 1 (a1) and 3 (e1) to a bent position (~90 deg), but it doesn't change anything.
I've found this error in KUKA documentation, describing a possible cause :

"The setpoint command from the external computer does not match with the system status [...]"

A suggested remedy is to check if when the drives are switched off, we always have :
cmd.data.cmdJntPos = msr.data.cmdJntPos + msr.data.cmdJntPosFriOffset
However this seems to be already checked in the friRemote.cpp.
Do you know how to fix it?
Thanks for your help

Hi @nicocadart,
you mean joints a2 and a3, right? They are the only ones that can "bend" the robot; a1 and e1 are coaxial.
Do you have anything attached on the robot? I'm not totally sure, but that error could also pop up if you have a heavy tool which you didn't calibrate the robot for.

From what I see in the code highlighted by @marcoesposito1988 , you could use the JOINT_IMPEDANCE control strategy to perform a JOINT_EFFORT control, just set the stiffness to zero and the joint_set_point_command_ to the current joints position.
@marcoesposito1988 do you think it would work?

Hi @marcoesposito1988
By "bent" I meant that their angular position is greater than 45 degrees. However I tried with joints a2 and a3 and it doesn't change anything, the same error 'FRI Interpolation Error occurs'.
I don't have any tool yet on the robot, therefore the 'flange' tool is selected.
All controllers in any mode are doing the same error. After a few tries, the error occurs during the first loop in the lwr_hw_fri_node.cpp in the manager.update() function, whent the controller is loaded.

Hi, I am facing the same problem, any news on that?

Are you trying to start the robot with any controller which is not joint_trajectory_controller? As far as I remember, that is not going to work. You have to start in position control, then change to impedance, otherwise you will get that error.
Yes, I feel your pain.

Yes the robot is started with the joint_trajectory_controller.
I may have achieved to solve the problem. It was happening when the startegy was switched (or when the first controller is loaded at the beginning), in the first loop iteration. The FRI sends then during one step of time a command with cmdFlag 0 (see setToKRLINT() in friremote.h), which isn't recognized as a known strategy by the KRC, resulting in the FRI Interpolation Error.
To solve that, the FRI needs to be started after the strategy has been changed and the new controller loaded, or in other words cmdFlag != 0. I removed the call to startFRI() in doSwitch(), and added it at the end of the write(). I don't have the error anymore.
What do you think about this solution?

Very strange, that should not happen. Sounds like a bug, but I never encountered it.
Putting startFRI in write is conceptually wrong, since it's something you should do once and not every millisecond (or 10). But if that lets you use the robot, at least you have the time to solve the issue properly while you are able to work...

Yes I know this solution isn't ideal... However the startFRI isn't called every iteration. I added a bool needToStartFRI which is set to true only when doSwitch is called. Therefore, the call to startFRI in write() is done only if the controller has been switched just before.


python310Packages.bpycv: 0.2.43 -> 0.3.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.bpycv is: Computer vision utils for Blender
meta.homepage for python310Packages.bpycv is: https://github.com/DIYer22/bpycv
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.6 with grep in /nix/store/d1p25zk7pd74slhji6v747n0gy5r5phw-python3.10-bpycv-0.3.6
found 0.3.6 in filename of file in /nix/store/d1p25zk7pd74slhji6v747n0gy5r5phw-python3.10-bpycv-0.3.6

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.bpycv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/d1p25zk7pd74slhji6v747n0gy5r5phw-python3.10-bpycv-0.3.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.bpycv https://github.com/r-ryantm/nixpkgs/archive/353859c8fb494a5c99ba61266605181347f0eb0a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/d1p25zk7pd74slhji6v747n0gy5r5phw-python3.10-bpycv-0.3.6
ls -la /nix/store/d1p25zk7pd74slhji6v747n0gy5r5phw-python3.10-bpycv-0.3.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

python310Packages.bpycv

Maintainer pings
cc @lucasew for testing.

Approved :+1:
Tested with the following code:
let
  nixpkgs = builtins.fetchTarball https://github.com/r-ryantm/nixpkgs/archive/353859c8fb494a5c99ba61266605181347f0eb0a.tar.gz;
  pkgs = import nixpkgs {};
in pkgs.mkShell {
  buildInputs = with pkgs; [
    python3Packages.bpycv
    python3Packages.matplotlib
    blender
  ];
}

from matplotlib import pyplot as plt
import bpycv
import bpy

bpy.data.objects['Cube']['inst_id'] = 100

data = bpycv.render_data()
print(data)

plt.imshow(data['image'])
plt.show()
plt.imshow(data['inst'])
plt.show()
plt.imshow(data['depth'])
plt.show()


 My particular use case is a Storybook that runs in an iframe: Storybook's use of localStorage prevents me from configuring it in each iframe independently (unless I serve each iframed Storybook instance from a different domain).
Proposed API:
store.isFake(); // => false
store.get('foo'); // => "value"
store.forceFakeMode(true); // new API
store.isFake(); // => true
store.get('foo'); // => undefined

The actual localStorage would not be affected; the in-memory storage would just be used instead.

Aha, that works! Slightly modified for posterity:
// Register forceFake extension
store._.fn('forceFake', function() {
  this._area = store._.storage('fake');
});

// Force fake localStorage
store.local.forceFake();

// Force fake sessionStorage
store.session.forceFake();

Thanks for your help. 👍

Reopening re:

leave this issue open until i do that or change my mind. :)


Support source generating values with Utf8 formatting/parsing

JsonSpanSerializableValueConverter

There is already JsonUtf8SpanSerializableValueConverter, I just need to switch them over.

There is already JsonUtf8SpanSerializableValueConverter, I just need to switch them over.

Then, value implementer will have to remember which to use, even though not explicitly marking Utf8 support.
Might be better for JsonSpanSerializableValueConverter to do type check and switch strategy if it can use Utf8?

Might be better for JsonSpanSerializableValueConverter to do type check and switch strategy if it can use Utf8?

Although I think that might not be straightforward

Stick with Plan A for now

There are more (i.e. the AsciiChars) but they're not values backed by another so I'll do them in a separate PR.


Migrate project from Webpack to Vite

Description
After ditching Nuxt and upgrading to Vue3, migrate bundler to use Vite to reduce development time and improve DX.
Context
Given the premises that Webpack module federation is not necessary, but we rather rely on Yarn Workspaces, the migration to Vite seems now possible.
This will require to update all the configuration, which is usually generated by the Vue3 CLI in a prompt.
Build and CI pipelines will also require to be reviewed.
A particular attention will have to go to the Webpack configuration (at the moment present in the Nuxt configuration) and the use of the NormalModuleReplacementPlugin() as it will have to be replaced by the Vite Plugin API (Thanks @catherineluse for the mention)
Storybook can also be migrated to Vite and speed up a lot development time, as explained in their article.

Some notes from @rak-phillip about Vite integration while updating Vue to 2.7.

At the current time, further Webpack implementations have been added and the description requires to be updated.


Implement function list in the control panel

With the following features:

Select all/none.
Filtering displayed functions based on function names.
For all selected functions, setting which user to sync from.
For each function, display which user it is syncing from (or if it is syncing from another user at all).

Closing this as the idea is a little deprecated. Will reopen with the new setup we are basing things on.


Swift 5 update

i have a branch working here called swift5: https://github.com/prolificinteractive/Yoshi/tree/swift5

@hkellaway 👍🏼


Revert fastcgi persistent connections

1. What does this change do, exactly?
Reverts FastCGI to remove persistent connection pool.
This is a direct revert to the commit before the introduction of persistent connections, with attempts to add the features introduced after persistent connections.
Because the newer features are tightly coupled with persistent connections dialer, some rewrite had to take place but they are still direct port of the features.
2. Please link to the relevant issues.
https://github.com/mholt/caddy/issues/1736
3. Which documentation changes (if any) need to be made because of this PR?
fastcgi. pool config will be removed.
4. Checklist

[x] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I am willing to help maintain this change if there are issues with it later

Erm.... who knows how I can get rid of this long list of merge commits.

Excellent! I can't wait to take a look at this. It's a big holiday here in the US for the next few days, so I won't be online much.
Pinging @taylorotwell and @adamwathan -- this is the PR where we would like to get Caddy in a usable state again for Laravel Valet, and other PHP apps. Would you please try this for a while in your local development environment? Abiola and I would greatly, greatly, greatly appreciate it if you would try this branch and see if it works. I will ping you again after the holiday if you'd like a reminder. :smile: Let me know if I can help you get going with it (e.g. compile it for you, just let me know OS + arch to build for).

For anyone willing to try this but having issues with GOPATH and forks, these are the build steps.
git clone -b revert-fastcgi https://github.com/abiosoft/caddy \
    $GOPATH/src/github.com/mholt/caddy
go install github.com/mholt/caddy/caddy

Run
$GOPATH/bin/caddy

Hey @mholt! Can you shoot me a build of this for macOS Sierra? I'll try and get to playing with it today or tomorrow. Thanks!

@adamwathan there you have it https://drive.google.com/open?id=0BzeObmqmbSY0MTNaM3N3M0Z6Qnc.
Built on macOS Sierra 10.12.5.

Hey guys sorry for the delay, I don't think I'm going to get a chance to make the necessary changes to Valet to try this build until at least the first week of August due to some travelling and conference preparation. Don't wait on me to release, but I'll still do my best to provide some feedback when I get a chance.

@adamwathan No problem, but please do when you have a chance, and let us know how it goes. I'll try to merge this today or ASAP if @taylorotwell has continued to have good results, then.

Thank you, @abiosoft. This is greatly, greatly appreciated.


etl begin blocks executed twice

Another issue of the etl tool seems to be the double execution of the begin blocks. Looking on the OETLProcessor code seems that the following line generates this problem:
https://github.com/orientechnologies/orientdb-etl/blob/master/src/main/java/com/orientechnologies/orient/etl/OETLProcessor.java#L231
Thank you ... waiting for feedback !

Hi, why do you think  that begin block are executed twice? The line is inside a for cycle that execute each begin  block in order.
Have you got a test case or even a json config with sample import files?

Hi, because it is executed again in the execution methods, here:
https://github.com/orientechnologies/orientdb-etl/blob/master/src/main/java/com/orientechnologies/orient/etl/OETLProcessor.java#L434
The wrong execution statement (line 231) is located in the parse method which is only for parsing and configuring things, no execution needed there.

Ok, thank you very much for your report, I'll work on that.
If you  want to collaborate, feel free to submit PR on develop branch.

Thank you for the report. I fixed on develop and 2.1.x branches. Please close the issue if all is ok.

10x, closing it ...

Thanks, for fixing this.


Fixed the GET operation failure for dispatcher action.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code passes the code style as defined by ESLint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Fixed by #93


Update riseup-vpn 21.11 -> git

Description of changes
riseup-vpn was updated from the unusable 21.11 version (details in this issue) to track the main branch. The package was ported to qt6.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The .qrc file needs to manually added because qmake (located at qtbase/bin) searches for the qmlcachegen binary in qtbase/libexec while the binary is located in qtdeclarative/libexec. Hence this particular .qrc file cannot be built automatically. If anyone know how to fix this in qt6, please let me know.
For now, the hack of adding the .qrc file manually does the job.

+1

Let's get this merged! :D

bump

bump

bump

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1958

The changes look good, but could you tidy up the commits a bit? Assuming this is all part of the package upgrade, maybe a single commit with message bitmask-vpn: 0.21.11 -> 0.24.5-unstable-2024-07-08 would be good? https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

Mass ping & merge conflict. Please reopen your PR with the correct branch.


IML should bump config_version when changing corosync.conf

When IML edits the corosync.conf, it should observe and increment the config_version so corosync can understand what the authoritative version is.
By implementing the parser in #1553, we can also make it easier to read / update this version num.

Fixed in #1551


Use specifc namespace

The tutorial should create a specefic kubernetes namespace, otherwise the current default namespace will be used.

Namespaces are only defined if they are needed (e.g. for kube-system) in order to keep the example as simple as possible.


fix c_glib ssl make cross

I was able to get c_glib ssl make cross to pass against java and cpp servers.   I removed the "server" branches since this code is client only for now.  We don't have any tests in "make cross" for handling invalid certificates so the authorization stuff may not be fully vetted.  In any case, this proves it works in some fashion at least... if you could merge this in, we can get a CI run and see if all the servers pass it.
I think the big change was that in open() I call handshake() and I removed handshake branches from the other calls.  I also fixed up the logic in authorize.

Hi Jeking3,
I saw your changes. They seem ok. I'm little worried about the handshake calls you removed. I will take a look doing my own tests later. Thank you a lot for your patches, they seems to be pretty good.
I will merge now.


if shardingsphere can create tables  automatically?

Description：
Data Node Configuration：
spring.shardingsphere.sharding.tables.t_basic_up_msg.actual-data-nodes=
sharding-test.t_basic_up_msg_20${19..24}0${1..9},sharding-test.t_basic_up_msg_2019${19..24}${10..12}
Sharding_test
├── t_basic_up_msg_2019_01
├── t_basic_up_msg_2019_02
├── t_basic_up_msg_2019_03
├── t_basic_up_msg_2019_04
├── t_basic_up_msg_2019_05
├── t_basic_up_msg_2019_06
├── t_basic_up_msg_2019_07
├── t_basic_up_msg_2019_08
├── t_basic_up_msg_2019_09
├── t_basic_up_msg_2019_10
├── t_basic_up_msg_2019_11
├── t_basic_up_msg_2019_12
………
├── t_basic_up_msg_2024_07
├── t_basic_up_msg_2024_08
├── t_basic_up_msg_2024_09
├── t_basic_up_msg_2024_10
├── t_basic_up_msg_2024_11
├── t_basic_up_msg_2024_12
（There are 72 tables in total.）
Sharding Key
receipt_time  (type :datetime)
Actual behavior of creating tables
A、Use MySQL stored procedures or sql script.
B、By springboot：
spring.jpa.properties.hibernate.hbm2ddl.auto= create
Expected behavior
sharidngsphere can help create tables  automatically.
For example,
we don't need to create so many tables at first.
May be we can just create tables from  t_basic_up_msg_2019_01 to  t_basic_up_msg_2019_12.
Wait until 2020.01.01 ，and then shardingsphere can create tables from  t_basic_up_msg_2020_01 to  t_basic_up_msg_2020_12.
And so on.
It's a mechanism like this for  creating tables automatically.
My environment：
springboot + JPA + mysql +sharding-jbdc
I think this is a problem that we may face in the production environment
（when the type of sharding key is datetime and the number of tables is too big）.
It's a little inconvenient  although we can create tables first.
That's what I want to suggest.
Thank you.

If user execute DDL will create table for all sharding nodes;
Is there any reason to let ShardingSphere create table without any user call?

Sharding-JDBC of ShardingSphere is a JDBC extension;
Sharding-Proxy of ShardingSphere is a MySQL/PostgreSQL proxy.
Auto create tables is not ShardingSphere's scope, it should be do at orm or other database framework. ShardingSphere is a driver layer, do not focus user's business logic.

Ok, I get it , thanks！


README: Change link numbers to short names

I noticed in @peternowee 's logging PR that the link numbers in the README ended up getting renumbered — IMHO numbering links is a great way to drive yourself crazy.
This PR replaces all link numbers with short names (the longest being wiki_example, most are much shorter, some only 2 or 3 characters), ensuring they never need to be renumbered.

Hmm. The CodeQL scanning should probably have the same paths-ignore as CI.yml, there's as little point to scanning for code issues after a README change as there is running the CI.
https://github.com/pydot/pydot/blob/425d847f596dff77ab5dbb92ce5e36d563a3266b/.github/workflows/CI.yml#L3-L16

(Tho, the fact that it completed here in only 2 seconds makes me think it's internally applying similar ignore rules.)


Release azure cosmos 4.47.0 and azure cosmos spark 4.20.0

Release branch with version updates for azure-cosmos and azure-cosmos-spark

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-cosmos


Mac High Sierra, Swiss German Keyboard: cannot use [], , {} and other keys

Hi,
I cannot use any of the keys that are accessed via ALT in the terminal.
This concerns for example #, [, ], |, {, }, and \
Whenever trying to use one of those, the row beginning turns into a (args: int), e.g.
(args: 5)
in Atom, the characters are working properly, but in the terminal, they do not behave correctly.
Any tips on how to fix that?
my system:
Atom 1.24.1
platform-ide-terminal 2.8.0
Mac OS High Sierra 10.13.3
Swiss German Keyboard

Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js
if issues persist open a new ticket with required information.
Thx =)


pcl_msgs: 1.0.0-2 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository pcl_msgs to 1.0.0-2:

upstream repository: https://github.com/ros-perception/pcl_msgs
release repository: https://github.com/ros2-gbp/pcl_msgs-release.git
distro file: foxy/distribution.yaml
bloom version: 0.9.7
previous version for package: null

pcl_msgs
* Trim README
* ros2 port of pcl_msgs (#11 <https://github.com/ros-perception/pcl_msgs/issues/11>)
  * Migrated From ROS1 to ROS2
  * Update CHANGELOG.rst
  * Migrated pcl_msgs from ROS1 to ROS2
  * Updated Readme.md
  Added Migration changes information and How to build and test information.
  * Update README.md
  * Update README.md
  * Update README.md
* Migrated From ROS1 to ROS2 (#10 <https://github.com/ros-perception/pcl_msgs/issues/10>)
  * Migrated From ROS1 to ROS2
  * Update CHANGELOG.rst
  * Migrated pcl_msgs from ROS1 to ROS2
* Add service file to update filename
* Contributors: Kentaro Wada, Paul Bovbel, Sandip Rakhasiya

@jacobperron done, though this looks exactly the same

It's subtle, but the difference is in what rosidl type supports get injected by bloom, ensuring that the message packages ships with libraries for all core type support packages.

Huh ok - maybe there should be something in this repos CI to check for that.

Huh ok - maybe there should be something in this repos CI to check for that.

Maybe, though I'm not sure exactly what would be involved. If a released message package does get into rosdistro without the necessary dependencies, I think we'll notice as the debian packaging jobs will fail.


receiveNotification: notification discarted [iOS]

Hello,
I am using awesome_notification and flutter_local_notifications both of them in my project for different functionalities in my project.
I get the error receiveNotification: notification discarded when i try to execute a notification from flutter_local_notifications plugin.
Also i saw other issues regarding this problem but with FCM which is not my case, but anyway i made the required configuration on AwesomeServiceExtension on iOS, and still the error persist.
Am i missing smth ?

awesome_notification and flutter_local_notifications must not be used simultaneously. Since both make global functionality, one ends up interfering with the other.
Notification Discarded happen when the data package are not in the expected format. This could happen when you send an wrong json data or when you missconfigured the target extensions for iOS.

awesome_notification and flutter_local_notifications must not be used simultaneously. Since both make global functionality, one ends up interfering with the other.
Notification Discarded happen when the data package are not in the expected format. This could happen when you send an wrong json data or when you missconfigured the target extensions for iOS.

I don't use the plugin at the same time to run 2 notifications, i use both of them in different conditions.
From what i saw on swift code, when the notification from flutter_local_notification was launched. The json data of the awesome_notification was nil.
A question that i had when i debuged my code is that, should the awesome_notifcation plugin be triggered when i launch a notification from other plugins?
Because if i can bypass the triggering of awesome_notificatiom swift code, this will solve the problem.

I don't use the plugin at the same time to run 2 notifications, i use both of them in different conditions.
From what i saw on swift code, when the notification from flutter_local_notification was launched. The json data of the awesome_notification was nil.
A question that i had when i debuged my code is that, should the awesome_notifcation plugin be triggered when i launch a notification from other plugins?
Because if i can bypass the triggering of awesome_notificatiom swift code, this will solve the problem.

Theres some functionality to receive the notification action that you can only do using flutter_local_notifications?

Theres some functionality to receive the notification action that you can only do using flutter_local_notifications?

Sorry i don't think i understood your question.
But the notification from flutter_local_notification plugin doesn't pop up at all.

Sorry i don't think i understood your question.
But the notification from flutter_local_notification plugin doesn't pop up at all.

There is something that you cannot to do using only awesome_notifications? There is something that only flutter_local_notifications can do?

There is something that you cannot to do using only awesome_notifications? There is something that only flutter_local_notifications can do?

Yes in fact i am using flutter_local_notification only because it allows me to add soundSource for each notification instead of adding it only in the channel.
If you can add this feature for awesome_notificatiom too it would be so nice.

Yes in fact i am using flutter_local_notification only because it allows me to add soundSource for each notification instead of adding it only in the channel.
If you can add this feature for awesome_notificatiom too it would be so nice.

If you noticed i opened an issue for this feature request.

If you noticed i opened an issue for this feature request.

So your wish will become true on next update! 🎉

So your wish will become true on next update! 🎉

Thanks a lot 🚀

Thanks a lot 🚀

Can i ask if you have any estimation about this feature or how can i help ?

Can i ask if you have any estimation about this feature or how can i help ?

I gonna try to deliver this new version today, but im facing problems to develop using Mac on a virtual machine, and i can only deliver it after test on both platforms.

I gonna try to deliver this new version today, but im facing problems to develop using Mac on a virtual machine, and i can only deliver it after test on both platforms.

I gonna try to deliver this new version today, but im facing problems to develop using Mac on a virtual machine, and i can only deliver it after test on both platforms.

@rafaelsetragni I have a macOS on my office, i can help you with the development :)

I gonna try to deliver this new version today, but im facing problems to develop using Mac on a virtual machine, and i can only deliver it after test on both platforms.

@rafaelsetragni I have a macOS on my office, i can help you with the development :)

Of course! I will finish the coding and share with you on GitHub to you test it for me

Of course! I will finish the coding and share with you on GitHub to you test it for me

Okay great

Okay great

Try to use the parameter customSound, inside your notification's content.

Try to use the parameter customSound, inside your notification's content.

Did you pushed on any branch?

Did you pushed on any branch?

Im not beeing able to set the sound to work for each notification on Android Oreo and above. Seems like the notification channel is disabling and overrinding the sound customization for each notification, and it seems that the google team  was intented to be like that.
The source that i made until now is on https://github.com/rafaelsetragni/awesome_notifications/tree/content-custom-sound

Im not beeing able to set the sound to work for each notification on Android Oreo and above. Seems like the notification channel is disabling and overrinding the sound customization for each notification, and it seems that the google team  was intented to be like that.
The source that i made until now is on https://github.com/rafaelsetragni/awesome_notifications/tree/content-custom-sound

https://stackoverflow.com/a/31398504/13189028
Does this answer help you, looks like for the Android above 7.0 a check of sdk is needed ?
Also the way how its made on the Android side of flutter_local_notification might help you.

https://stackoverflow.com/a/31398504/13189028
Does this answer help you, looks like for the Android above 7.0 a check of sdk is needed ?
Also the way how its made on the Android side of flutter_local_notification might help you.

On the NotificationCompat.Builder()
you can add this line?
setSound("your sound uri",AudioManager.STREAM_NOTIFICATION)

On the NotificationCompat.Builder()
you can add this line?
setSound("your sound uri",AudioManager.STREAM_NOTIFICATION)

I already done that, but seems like my changes are being ignored by Android.
On iOS it's already all done, but not tested yet. You can test it right now. Just on Android the setSound and the channel's update are not working.

I already done that, but seems like my changes are being ignored by Android.
On iOS it's already all done, but not tested yet. You can test it right now. Just on Android the setSound and the channel's update are not working.

soundSource

soundSource parameter is working fine. We have to give complete path of custom sound or ringtone like below
soundSource: 'resource://raw/res_s4_ringtone',
Please copy your custom sound or ringtone in res -> raw folder. It should work.
If you simply assigh soundSource: 'res_s4_ringtone', it will throw you error audio not found.

soundSource

soundSource parameter is working fine. We have to give complete path of custom sound or ringtone like below
soundSource: 'resource://raw/res_s4_ringtone',
Please copy your custom sound or ringtone in res -> raw folder. It should work.
If you simply assigh soundSource: 'res_s4_ringtone', it will throw you error audio not found.

@MaheshPeri19 We are not speaking about the parameter of soundSource, that works for only one Notification channel.
We are trying to add another customSound parameter to each notification to play different sounds for different notifications.
@rafaelsetragni Hello, So for the iOS did u encountered any problems ?.
I will try to see how i can help for the Android code to make it possible to work on Oreo and above. Very strange behavior.

@MaheshPeri19 We are not speaking about the parameter of soundSource, that works for only one Notification channel.
We are trying to add another customSound parameter to each notification to play different sounds for different notifications.
@rafaelsetragni Hello, So for the iOS did u encountered any problems ?.
I will try to see how i can help for the Android code to make it possible to work on Oreo and above. Very strange behavior.

For iOS everything should work just fine. You can test it with the git branch that i let for you.
If you got some difficult to put it on your pubspec.yaml tell me here than i help you too.

For iOS everything should work just fine. You can test it with the git branch that i let for you.
If you got some difficult to put it on your pubspec.yaml tell me here than i help you too.

On iOS works fine.

On iOS works fine.

Any idea how flutter_local_notifications plugin, manages the issue on Andoroid, seem to work fine there with 8.1 and up

Any idea how flutter_local_notifications plugin, manages the issue on Andoroid, seem to work fine there with 8.1 and up

Its not changing the notification sound, and it seems to be intented by Android team to be like that.
Take a look at this topic

Its not changing the notification sound, and it seems to be intented by Android team to be like that.
Take a look at this topic

There is a solution, but i cannot put it inside the plugin. You need to implement it by yourself.
Changing sound and vibration for Notification Channel on Oreo 8.1

There is a solution, but i cannot put it inside the plugin. You need to implement it by yourself.
Changing sound and vibration for Notification Channel on Oreo 8.1

I get it! I had created a new channel inside Android OS for every channel's data change, calculated with the MD5 over all fields. Its transparent for the plugin users, but allows  now to fully update the channels, even on Android Oreo and above.
Please, test it for me again. I had upload a new version on https://github.com/rafaelsetragni/awesome_notifications/tree/content-custom-sound

I get it! I had created a new channel inside Android OS for every channel's data change, calculated with the MD5 over all fields. Its transparent for the plugin users, but allows  now to fully update the channels, even on Android Oreo and above.
Please, test it for me again. I had upload a new version on https://github.com/rafaelsetragni/awesome_notifications/tree/content-custom-sound

Okay, im testing it now

Okay, im testing it now

Its working!! Tested on debug & release mode.

Its working!! Tested on debug & release mode.

The test in iOS passed successfully.
But some errors should be fixed on the swift code. On the function channelMethodGetNextDate before its released on the next version.

The test in iOS passed successfully.
But some errors should be fixed on the swift code. On the function channelMethodGetNextDate before its released on the next version.

@rafaelsetragni Any idea when this branch will be merged with the main one ?

@rafaelsetragni Any idea when this branch will be merged with the main one ?

I've red-evaluate this method and i found a problem. When the channel is updated, every active notification is closed.
So, I cannot keep the customSound field, because it can induce the developers to mistakes. Instead, i gonna create a updateChannelMethod and warning the developers about his downside on Android oreo and above.
For you, theres not a big change at all. I gonna release an new version in this weekend.

I've red-evaluate this method and i found a problem. When the channel is updated, every active notification is closed.
So, I cannot keep the customSound field, because it can induce the developers to mistakes. Instead, i gonna create a updateChannelMethod and warning the developers about his downside on Android oreo and above.
For you, theres not a big change at all. I gonna release an new version in this weekend.

I've added forceUpdate option on setChannel method, to allows to full update an channel on Android Oreo and above without need to reinstall the app, with the downside to close all current notifications.
This functionality will be availabe on next release.


authentication helper function

Add helper function to create x509 credentials to access LIGO data.

Two questions:

Would it be possible to integrate with kerberos as the mention here for authentication so scripts won't get interrupted to prompt for passwords
It might be helpful to have environment variables infer the username if it's not provided so that someone can just set this in their .bashrc and then not have to encode any of this info in any calling scripts at all (though I guess this could be achieved with .env support in the downstream scripts as well)


serialize

given a URL:
https://docs.rs/url-parse/0.5.11/url_parse/url/struct.Url.html
can your serialize to a string or similar?

Give me an input and an expected output, maybe I could.

Are you asking about serializing a URL object to a String?\

yes

thank you!


Dynamically add data to geoJSONShape

I'm very happy with ui-leaflet, but now I'm stuck. I had all my geojson data in an object which looked like this:
map.map.geojson = {
    data: {
        type: 'FeatureCollection',
        features: []
    },
    style: {...},
    onEachFeature: {...}
}

The data gets loaded in the background and is then pushed to map.map.geojson.data.features.
The map.map.geojson is passed to the leaflet directive <leaflet geojson="map.geojson"></leaflet>.
Now I want to split the data into different geojson layers. Therefore I get a list with different element groups which are my different layers. I set up these layers as so:
for(var i=0; i<list.length; i++) {
    var elem = list[i];
    var currentLayer = {};
    currentLayer.name = elem.name;
    currentLayer.type = 'geoJSONShape';
    currentLayer.data = {
        type: 'FeatureCollection',
        features: []
    }
    currentLayer.layerOptions = {
        style: {...},
        onEachFeature: {...}
    }
    ...
    map.map.layers.overlays[elem.id] = currentLayer;
}

But I don't see anything on my map. onEachFeature doesn't get called. I couldn't find any tutorial or code on how to update a layer of type geoJSONShape. Is this even possible? Did I miss something?
regards
v1r0x

I think the layers directive doesn't support geoJson layers. If you want to have multiple geo-json layers, you need to add the attribute  geojson-nested="true" to you're angular directive.
And then, you'll need to add a new property/key on your geojson object, with each geoJson layer.
So, instead of having this:
map.map.layers.overlays[elem.id] = currentLayer;
You'll end up with something like this:
map.map.geojson[elem.name] = currentLayer;


Add Buttons

Is your feature request related to a problem? Please describe.
I feel this repo would benefit from having button components also.
Describe the solution you'd like
A page containing button components
Describe alternatives you've considered
Nil
Additional context
Nil

Is your feature request related to a problem? Please describe. I feel this repo would benefit from having button components also.
Describe the solution you'd like A page containing button components
Describe alternatives you've considered Nil
Additional context Nil

I will surely assign this issue to you tomorrow! As Hacktoberfest is starting from tomorrow.

Alright then

Alright then

Surely I will assign this to you as soon as Hacktoberfest starts.

Happy contributing 🎊🎊🤭


Implement scalable distributed joins

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The main issue limiting scalability in Ballista today is that joins are implemented as hash joins where each partition of the probe side causes the entire left side to be loaded into memory.
Describe the solution you'd like
To make this scalable we need to hash partition left and right inputs so that we can join the left and right partitions in parallel.
There is already work underway in DataFusion to implement this that we can leverage.
Describe alternatives you've considered
None
Additional context
None

Here is some additional information. When I run TPC-H query 5 in the benchmarks, against DataFusion, I see that the physical plan used partitioned joins.
For example,  I see that both inputs to the join are partitioned on the join keys, and the join mode is Partitioned.
HashJoinExec: mode=Partitioned, join_type=Inner, on=[("c_custkey", "o_custkey")]
  RepartitionExec: partitioning=Hash([Column { name: "c_custkey" }], 24)
    ParquetExec: batch_size=8192, limit=None, partitions=[...]
  RepartitionExec: partitioning=Hash([Column { name: "o_custkey" }], 24)
    FilterExec: o_orderdate >= CAST(1994-01-01 AS Date32) AND o_orderdate < CAST(1995-01-01 AS Date32)
      ParquetExec: batch_size=8192, limit=None, partitions=[...]

This means that the join can run in parallel because the inputs are partitioned. So partition 1 of the join reads partition 1 of the left and right inputs, and so on.
When I run the same query against Ballista, I see.
HashJoinExec: mode=CollectLeft, join_type=Inner, on=[("c_custkey", "o_custkey")]
  ParquetExec: batch_size=8192, limit=None, partitions=[...]
  FilterExec: o_orderdate >= CAST(1994-01-01 AS Date32) AND o_orderdate < CAST(1995-01-01 AS Date32)
    ParquetExec: batch_size=8192, limit=None, partitions=[

Here, we see join mode CollectLeft, which means that each partition being executed will go and fetch the entire left-side of the join into memory. This is very inefficient both in terms of memory and compute and potentially gets exponentially slower the more partitions we have.
What we need to do is apply the same "partitioned hash join" pattern to Ballista.

I created a Google doc to discuss the design, and planned work, in more detail.
https://docs.google.com/document/d/1yUnGWsHKYOAxWijDJisEFYU4dIym_GSRSMpwfWjVZq8/edit?usp=sharing


Feature Reguest

Hi,
I had this installed for a few months but it wouldn't load correctly. When I did the update to 2023.2.4 it started working for me, yippee!
One feature request I'd like to suggest. Would it be possible to add a sensor similar to connected_clients, that indicates the number of "Other" connected clients?
I have all my normal devices categorized in Eero (Home, Entertainment, etc) but I'd like to know the number of uncategorized devices that on the network.
I use Eeros in a vacation rental and I'd like to know when guests are at the house and when they have left.
Thanks!

Added as attributes to the Connected Clients sensor entity in 1.2. Let me know if this is sufficient.

That's exactly what I was looking for! Thanks so much