Sidekick Library issues

https://main--bitdefender--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks
a few issues
duplicated columns example:

modal link not correct

Unnamed item

Duplicate and unnamed item

vpn presentation looks weird. I don't think it's correct :)

missing blocks in library:

vs

Cleaned up the sidekick library. Note that I have removed/unpublished the cards block as it is not used (probably the code should be deprecated as well).


Players with a negative balance can blind bet..

Once the game is over and someone lost everything to zero, they still at the table.
And the player with zero balance can press ready(!), the game begins, zero balance will turn into a negative (because of the blind bets).
Can server throw players with a negative or zero balance from the table, after the game ends?

Also this situation throw the error (then no cards are dealt) in Holdem poker
main.js:1003
Holdem.sort = function(cards) {
if(cards.length != 5) return cards;  // Uncaught TypeError: Cannot read property 'length' of null
...
I'm understand that is a front-end error, but i type it just for info reason. The easest cure - add cards array check before comparing. (  if(!cards) return;  )
thx.

@G-h-o-s-t thanks for the bug report. Will look into the first two issues.
As to Holdem.sort(), the param cards should be an array, which means a set of cards, should not be null, if no cards, just pass an empty array.

Okay, got you.
Thanks for you support!

@floatinghotpot did you solve this issue?


Networking problems after second kubeone run

I am using kubeone to set up a cluster on Hetzner cloud. After the initial run, things mostly work. There is a problem reaching kube-dns-upstream from pods on the worker nodes, but that can be fixed by doing a rolling restart of coredns.
However, after I run kubeone for a second time, canal gets redeployed, which then renders the cluster unusable. Every request seems to be taking 10 seconds (which of course makes debugging a pain).
This is how I execute kubeone (on both runs). kubeone.yaml  and tf.json are identical on both runs. I am using kubeone 1.2.2 (and have also tried 1.2.1) and have tried with kubernetes 1.20 as well.
kubeone appl --auto-approve --debug --manifest kubeone.yaml -t tf.json

-- kubeone.yaml
apiVersion: kubeone.io/v1beta1
kind: KubeOneCluster
versions:
    kubernetes: 1.19.11
cloudProvider:
  hetzner: {}
  external: true
containerRuntime:
  containerd: {}

-- tf.json
{
  "kubeone_api": {
    "sensitive": false,
    "type": [
      "object",
      {
        "endpoint": "string"
      }
    ],
    "value": {
      "endpoint": "x.x.x.x"
    }
  },
  "kubeone_hosts": {
    "sensitive": false,
    "type": [
      "object",
      {
        "control_plane": [
          "object",
          {
            "bastion": "string",
            "cloud_provider": "string",
            "cluster_name": "string",
            "network_id": "string",
            "private_address": [
              "tuple",
              [
                "string",
                "string",
                "string"
              ]
            ],
            "public_address": "dynamic",
            "ssh_agent_socket": "string",
            "ssh_port": "number",
            "ssh_private_key_file": "string",
            "ssh_user": "string"
          }
        ]
      }
    ],
    "value": {
      "control_plane": {
        "bastion": "xxx.xxx.xxx.xxx",
        "cloud_provider": "hetzner",
        "cluster_name": "test-001",
        "network_id": "xxx",
        "private_address": [
          "x.x.x.x",
          "x.x.x.x",
          "x.x.x.x"
        ],
        "public_address": null,
        "ssh_agent_socket": "env:SSH_AUTH_SOCK",
        "ssh_port": 22,
        "ssh_private_key_file": "/builds/infrastructure/infrastructure.tmp/TF_VAR_CLUSTER_PRIVATE_KEY",
        "ssh_user": "root"
      }
    }
  },
  "kubeone_workers": {
    "sensitive": false,
    "type": [
      "object",
      {
        "test-001-pool1": [
          "object",
          {
            "providerSpec": [
              "object",
              {
                "cloudProviderSpec": [
                  "object",
                  {
                    "firewall": "string",
                    "image": "string",
                    "labels": [
                      "object",
                      {
                        "test-001-workers": "string"
                      }
                    ],
                    "location": "string",
                    "networks": [
                      "tuple",
                      [
                        "string"
                      ]
                    ],
                    "serverType": "string"
                  }
                ],
                "operatingSystem": "string",
                "operatingSystemSpec": [
                  "object",
                  {
                    "distUpgradeOnBoot": "bool"
                  }
                ],
                "sshPublicKeys": [
                  "tuple",
                  [
                    "string"
                  ]
                ]
              }
            ],
            "replicas": "number"
          }
        ]
      }
    ],
    "value": {
      "test-001-pool1": {
        "providerSpec": {
          "cloudProviderSpec": {
            "image": "ubuntu-20.04",
            "labels": {
              "test-001-workers": "pool1"
            },
            "location": "nbg1",
            "networks": [
              "x"
            ],
            "serverType": "ccx12"
          },
          "operatingSystem": "ubuntu",
          "operatingSystemSpec": {
            "distUpgradeOnBoot": false
          },
          "sshPublicKeys": [
            "ssh-ed25519 xxxxxxx"
          ]
        },
        "replicas": 1
      }
    }
  }
}

Does anyone have an idea what might be causing this? What logs should I look at specifically for debugging?

@exolab please try this PR (you will have to compile it): https://github.com/kubermatic/kubeone/pull/1380, this PR will be release as kubeone v1.2.3.

@kron4eg Thank you for the swift reply and PR. We did build kubeone ourselves and have since migrated to the released v1.2.3. However, we still see the same thing happening.

We deploy the cluster.
We start a container on a worker node, log in and can do nslookup google.com just fine, we get fast responses
We run kubeone a second time. All the canal pods get terminated and restarted.
We try to do nslookup again and get no response ;; connection timed out; no servers could be reached
Looking at the node-local-dns logs on the worker node, we see that the kube-dns-upstream pod cannot be reached: [ERROR] plugin/errors: 2 route53.amazonaws.com.cluster.local. A: dial tcp <IP_ADDRESS>:53: i/o timeout

This only happens after the second kubeone run.

We run kubeone a second time. All the canal pods get terminated and restarted.

are you using kubeone apply each time, or kubeone install?

I can't reproduce this issue. Can you please share the deployment used to spawn the pods.

We run kubeone a second time. All the canal pods get terminated and restarted.

are you using kubeone apply each time, or kubeone install?

We are using apply in both cases...

I can't reproduce this issue. Can you please share the deployment used to spawn the pods.

I am not entirely sure what you mean. This is how we are spawning the pod on the worker node:
kubectl run -i --tty dnsutils --image gcr.io/kubernetes-e2e-test-images/dnsutils:1.3  --kubeconfig terraform/credentials/kubeconfig --restart=Never -- sh

@kron4eg I can confirm that after deploying a fresh cluster using the most recent patched version and then running kubeone apply a second time no longer leads to the problem I had.
Thank you so much for your impressively swift reaction and resolution, @kron4eg!


[cluster test] Bring back effect API

Currently this api only covers network effects, not bringing Actions back just yet
There is known caveat that network effect deactivation is a bit of a broken abstraction currently - deactivating any network effect on instance deactivates all of them, but it's a good start.

@bors-libra r=zekun000

:pushpin: Commit 79bc574 has been approved by zekun000

:hourglass: Testing commit 79bc57451dd92421034d57ba19ca95840fa79ced with merge<PHONE_NUMBER>e4aa3e5e3cb73aed4261916817faa0...

@bors-libra r-

@bors-libra r=zekun000

:pushpin: Commit cab7074 has been approved by zekun000

:hourglass: Testing commit cab7074334ac2250b9ea679095b901216dfe55a1 with merge f4982909c6e0b04752c391dfe25c3eb093164873...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: zekun000
Pushing f4982909c6e0b04752c391dfe25c3eb093164873 to master...


Could IGListBindingSectionControllerDataSource also use a covariant?

Now that IGListBindingSectionController has covariant types, could the data source also use it so that we get types for its object params?
Also change MonthSectionController to use Month, would be cleaner.
Follow up from #608

@rnystrom Unfortunately Objective-C doesn't support generics on protocols.

Bummer


Use protobuf content type instead of JSON for k8s API calls

The Kubernetes docs say this about content type for API requests:

Although JSON is the default, clients may request the more efficient binary Protobuf representation for better performance at scale.

Based on a quick search here I don't think agent-stack-k8s is doing that (and it is not enabled by default in the k8s go client) -- would you consider either defaulting to protobuf or allowing it to be switched on with some configuration?  It appears the implementation would be relatively simple e.g. https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2138/files
Thanks!

Hey @bpoland! Looks like it could be a possible improvement! It's not going to be something on our immediate radar, but we'd be happy to review a PR if you put one together.


Question: forced structure rotation

Is there a way to force the rotation of structures?
I make a datapack but there is no json argument for rotation. But if my structures are rotated, they contain glitched blocks like the Create mod train track which can´t really rotate. The only solution would be disabling rotation of the structure.

I think the best ideal solution is report the issue to the create devs and ask them to fix their block rotation. That’s ultimately a mod issue. The rotation is randomly chosen within the jigsaw piece generator code which is not easy to adjust.

Thank you for your quick answer. I reported the issue and hope they'll fix it.

Sorry to disturb again, but unfortunately, they seem to not fix this soon and when I set my mind to something, I'm determined to see it through.
So I found your answer at r/feedthebeast and clicked the link where you said "Or you can copy the JigsawPlacement.addPieces method and just remove the start piece rotation part of it". I skimmed the code, although I don't really know how Java works, but I didn't see something like "start piece rotation"
Would you mind explaining that?

It's the line that is getting a random rotation in jigsawPlacement's addPieces method. But requires copying the whole method to your own code and setting the rotation to a specific kind.

Which file is that?

net\minecraft\world\level\levelgen\structure\pools\JigsawPlacement.java

I can´t find it

What Minecraft version are you on and are you using yarn mappings?
(This class is what SkyStructure Java file is calling for creating the piece layout)

Minecraft Version 1.20.1 with Forge Modpack

That´s the folder of the modpack

And this is the world folder I placed my datapack in

Uhh. This StructureTutorialMod is for modders. Not players or packmakers. What I was describing is something only a modder can do by writing custom code to change how a structure generates. A datapack has no ability to change direction of a structure.

A modder would have their own structure class and basically unwrap out this method and change the rotation for their structure type. Then call that structure type in their Structure json file.
https://github.com/TelepathicGrunt/StructureTutorialMod/blob/187fc889b840f273bec64f9d811e8850b510afca/src/main/java/com/telepathicgrunt/structuretutorial/structures/SkyStructures.java#L118
This would have to be done by a modder since the mod will need to be compiled and ran to in order to work in production.

Ok, I thought it would be something easy to change in some files in addition to the datapack, but if I have to make a mod myself, then I think I can´t do it.
thank you anyway for the help

Yeah it’s a limitation of the vanilla structure json system. Sorry about that


Terrform Bug : Multiple results with a query - Show DB command

Provider Version
0.56.0
Terraform Version
0.56.0
Describe the bug
Customer is having issue with two databases due to their names since the query used by Terraform (SHOW DATABASES LIKE '') returns more than one value generating a Terraform plan with unexpected replacements (image attached)
Expected behavior
It should be presenting 1 result instead of 2 .
Code samples and commands
SHOW DATABASES LIKE ''; --return 2 rows
Additional context

Customer wants Snowflake  to enhance the terraform script.
The underscore wild card is SQL standard, and works in oracle, mysql, sql server and postegresql .They are not willing to change the database name but rather wants us to make the Terraform script changes.They want to make Terraform provider for Snowflake, wildcard proof.
SQL wildcards are supported in pattern:
An underscore (_) matches any single character.
A percent sign (%) matches any sequence of zero or more characters.
Wildcards in pattern include newline characters (\n) in subject as matches.
LIKE pattern matching covers the entire string. To match a sequence anywhere within a string, start and end the pattern with %.
We asked customer  to use account_usage.databases view or information_schema.databases view, and filter by the DATABASE_NAME='dbname'.
SHOW DATABASE is doing "LIKE" condition and querying the account_usage.databases view where DATABASE_NAME='dbname' will provide the exact match.
The above suggestion was rejected since the same query cannot be injected into Terraform’s source code.

https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/1666
This was fixed in following PR, and is released in 0.60

Closing after #1666 merge.


Drop Travis as our CI provider

Since travis changed its pricing policy it has become more limited in
what we can accomplish with it. It now uses a limited credit model for
open source projects which besides being cumbersome puts the project in
a precarious position where we may be unable to run tests if we dont
have any credits left.
For this reason we will be moving to github actions since they seem to
be the best alternative at the moment
I also dropped flake8 from our tox tests in favor of reviewdog
Review dog is an incredible project that makes linting and formatting
review a breeze by commenting inline what is wrong in a pull request.
This makes the review process easier for the maintainer and also
provides a clearer feedback to the contributor
This new test workflow utilizes a few interesting projects to make this action
easier to maintain such as the coveralls github action
and the tox-gh-actions project
This PR, as mentioned in #252, is necessary to get back our CI pipeline and to confidently make a new pipreqs release

just a disclaimer that this is a work in progress, testing this CI is complicated because there is no way (afaik) of testing it locally.
I'm currently working on de-duplicating checks and investigating why some tests are being cancelled

Codecov Report

:exclamation: No coverage uploaded for pull request base (next@c8ab8cb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #272   +/-   ##
=======================================
  Coverage        ?   87.50%
=======================================
  Files           ?        2
  Lines           ?      256
  Branches        ?        0
=======================================
  Hits            ?      224
  Misses          ?       32
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ab8cb...3189fc4. Read the comment docs.

ok, so I cant find a way to keep using coveralls which sucks because we loose our coverage history. Uploading to coveralls without using the github action is really buggy, however the github action only supports reports in lcov format which i couldn't manage to create. See https://github.com/coverallsapp/github-action/issues/30
After 3 hours trying I gave up and tried codecov which just worked in 5 minutes. So unless someone finds a way to keep using coveralls, we will be using codecov from now on

I tested this new CI with a dummy PR and everything seems to be working as expected! https://github.com/bndr/pipreqs/pull/273
This PR should be ready to be merged but I will wait a while in case anyone wants to give some feedback on this.

also, our tests do not respect flake8, changing CI made this evident. I will be opening an issue about this


Module path mapping is not working in generated js files

TypeScript Version:  2.4.0
Code

I have a config

"paths": {
      "pages/*": ["./app/pages/*", "../../pages/*"],
      "helpers/*": ["./app/helpers/*", "../../helpers/*"]
}

Expected behavior:
var element_helpers_1 = require("../../helpers/element-helpers");
var manage_documents_page_1 = require("../../pages/manage-documents-page");

Actual behavior:
var element_helpers_1 = require("helpers/element-helpers");
var manage_documents_page_1 = require("pages/manage-documents-page");

path does not change the emit... it simply allows TypeScript to resolve dependencies at design time that would otherwise not be automatically resolved.  Whatever run-time module loader you are using would need to support any run-time configuration you need to reflect your desired run-time configuration.

@kitsonk but actually I don't use webpack so that i cannot use alias for mapping, can we automatically generate the correct path from mapping table ?

Simple answer is no.  TypeScript does not re-write module names.  You will need to move the modules via external tooling or use a loader that allows mapping (e.g. like RequireJS or SystemJS).

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Cannot obfuscate with tsyringe package

Expected Behavior
Obfuscate without errors
Current Behavior
Uncaught Error: tsyringe requires a reflect polyfill. Please add 'import "reflect-metadata"' to the top of your entry point.
Steps to Reproduce

Create a TypeScript project with this webpack.config.js

const path = require('path');

const HtmlWebpackPlugin = require('html-webpack-plugin');
const WebpackObfuscator = require('webpack-obfuscator');

const ROOT = path.resolve(__dirname, 'src');
const DESTINATION = path.resolve(__dirname, 'dist');

module.exports = {
    context: ROOT,
    mode: 'development',
    entry: {
        main: './index.ts',
    },
    output: {
        filename: '[name].bundle.js',
        path: DESTINATION,
    },
    resolve: {
        extensions: ['.ts', '.js'],
        modules: [
            ROOT,
            'node_modules',
        ],
    },
    module: {
        rules: [
            {
                enforce: 'pre',
                test: /\.js$/,
                use: 'source-map-loader',
            },
            {
                enforce: 'pre',
                test: /\.ts$/,
                exclude: /node_modules/,
                use: 'eslint-loader',
            },
            {
                test: /\.tsx?$/,
                use: 'ts-loader',
                exclude: /node_modules/,
            },
        ],
    },
    plugins: [
        new HtmlWebpackPlugin({
            hash: true,
            template: 'index.html',
            filename: 'index.html',
        }),
        new WebpackObfuscator({
            renameGlobals: true,
            renameProperties: true,
            sourceMap: false,
        }),
    ],
};

Add some singleton classes
Resolve the main class

Your Environment

Obfuscator version used: ^1.9.0
Node version used: v12.18.0

Stack trace
main.bundle.js?7e5cfb4895e0441db1df:1 Uncaught Error: tsyringe requires a reflect polyfill. Please add 'import "reflect-metadata"' to the top of your entry point.
    at Module.<anonymous> (main.bundle.js?7e5cfb4895e0441db1df:1)
    at _0x2bf07c (main.bundle.js?7e5cfb4895e0441db1df:1)
    at Object.<anonymous> (main.bundle.js?7e5cfb4895e0441db1df:6)
    at _0x2bf07c (main.bundle.js?7e5cfb4895e0441db1df:1)
    at main.bundle.js?7e5cfb4895e0441db1df:1
    at main.bundle.js?7e5cfb4895e0441db1df:1

Code to reproduce
index.ts
import 'reflect-metadata';
import { container } from 'tsyringe';
import { Foo } from './Foo';

const foo = container.resolve(Foo);

Foo.ts
import { singleton } from 'tsyringe';
import { Bar } from './Bar';

@singleton()
export class Foo {
    public constructor(
        bar: Bar,
    ) {
        console.log(bar.name); // Bar
    }
}

Bar.ts
import { singleton } from 'tsyringe';

@singleton()
export class Bar {
    public name: string;

    public constructor() {
        this.name = 'Bar';
    }
}

Cannot reproduce. I created a project with your source code and slightly changed webpack config:
const path = require('path');

const HtmlWebpackPlugin = require('html-webpack-plugin');
const WebpackObfuscator = require('webpack-obfuscator');
const nodeExternals = require('webpack-node-externals');

module.exports = {
    context: path.resolve(__dirname, '..'),
    mode: 'development',
    entry: {
        main: './src/index.ts',
    },
    output: {
        filename: '[name].bundle.js',
    },
    resolve: {
        extensions: ['.ts', '.js'],
    },
    module: {
        rules: [
            {
                test: /\.tsx?$/,
                use: 'ts-loader',
                exclude: /node_modules/
            },
        ],
    },
    plugins: [
        new HtmlWebpackPlugin({
            hash: true,
            template: './src/index.html',
        }),
        new WebpackObfuscator({
            renameGlobals: true,
            sourceMap: false,
        }),
    ],
};

It runs fine:
import 'reflect-metadata';
import { container } from 'tsyringe';
import { Foo } from './Foo';

const foo = container.resolve(Foo);

console.log(foo);

Try to remove renameProperties option, because it can break your code. If it won't help, seems it something on your side with your project build configuration.

Yea, without renameProperties I can also get that to work but I want to rename all properties so there's no evidence of what does what.

renameProperties option is very dangerous. If your code does not work with it. Disable it. Or disable vendors bundle from obfuscation completely.

That's actually not a solution, you cannot say "disable it" because that should work, even disabling vendors bundle from obfuscation doesn't work so actually it's not my fault.

I can say that because renameProperties option may break code in most cases. Especially if you are using 3rd party libraries.
https://github.com/javascript-obfuscator/javascript-obfuscator#i-enabled-renameproperties-option-and-my-code-broke-what-to-do
If library exports object like:
exports = {
    foo: 'bar'
};

And in your code you imported this object:
import object from 'foobar';

console.log(object.foo);

Obfuscated code will looks like:
console['log'](object['_0x38eeb4']);

Property name will be renamed and it won't be the same.


The documentation links in tis repo DON'T work

@skasimalla I updated the reference to the new documentation location - https://catalog.workshops.aws/security-hub/.  thanks for raising this issue.


build: fix undefined symbol errors, link to libm

Fixes: https://github.com/saghul/qjsuv/issues/1

Oopsie! (I've been only testing on macOS for now). Nice to see you here Ben, cheers!


Add support for RPM-based distros for docker and rootfs images scanpipe

There is no easy way to access the RPM database but through librpm and the rpm executable.
The installed RPMs database comes in three formats:

bdb: a legacy Berkeley DB hash used as a key/value where the value is a binary blob that contains all the RPM data. The format of this blob should be the same as the RPM header format and scancode-toolkit can parse the headers.  This is the format that was/is used in older RH, CentOS, Fedora and most every RPM distros.
sqlite: a SQLite database where one table is used as a key/value store where the value is a binary blob that contains all the RPM data in the same binary format as in 1. and the RPM header. This is the format that is used in newer RH, CentOS and Fedora versions.
ndb: a new key/value store that is built-in librpm. This is the format used by newer openSUSE distros

librpm provides support for each of these formats and also contains a built-in read-only handler for the 1. bdb format such that librpm can be built without Berkeley DB and still can read an older RPM db (for instance to convert it to a newer format).
It needs to be built with specific flags to enable all these formats (typically a given build of a distro does not nee to support all the formats).
The installed DBs locations are:

Distro
Path
Format

CentOS 8
/var/lib/rpm/Packages
Berkeley DB (Hash, version 9, native byte-order)

CentOS 5
/var/lib/rpm/Packages
Berkeley DB (Hash, version 8, native byte-order)

Fedora 30
/var/lib/rpm/rpmdb.sqlite
SQLite 3.x database

Fedora 20
/var/lib/rpm/Packages
Berkeley DB (Hash, version 9, native byte-order)

openMandriva
/var/lib/rpm/Packages
Berkeley DB (Hash, version 10, native byte-order)

RHEL 8
/var/lib/rpm/Packages
Berkeley DB (Hash, version 9, native byte-order)

openSUSE 20200528
/usr/lib/sysimage/rpm/Packages.db
data, but this is the ndb format

In addition on Fedora distros there are files under /etc/yum.repos.d/* that contains base and mirror URLs for the repo used to install RPMs. Each file is in .ini format. On openSUSE and SLES, these are under /etc/zypp/repos.d
The licenses (when not deleted as in some CentOS Docker images) are found in /usr/share/licenses/<package name>/<license files> or /usr/share/doc/<package name>/<license files>
If using the rpm cli, this can create an XML like output:
./rpm --query --all  --qf '[%{*:xml}\n]' --rcfile=./rpmrc  --dbpath=<path to>/var/lib/rpm > somefile.xml
The .rcfile option may not be needed, but when using a fresh RPM build this is needed.
The RPM db may need to be rebuilt first when this is a bdb format from an older version than the bdb with which librpm was built.

To parse simply the XML output of the rpm command
>>> import xmltodict
>>> rpm=open('rpm.xml.txt','rb').read()
>>> rpm=rpm.decode('utf-8', errors='ignore')
>>> rpms = ['<rpmHeader>' + val for val in rpm.split('<rpmHeader>') if val]
>>> parsed=[xmltodict.parse(r) for r in rpms]

I have also attached that sample XML created with:
rpm --query --all --qf '[%{*:xml}\n]' --dbpath=<path to RPM DB directory typically some /var/lib/rpm/ > ~/rpm.xml.txt
rpm.xml.txt

To parse simply the XML output of the rpm command
>>> import xmltodict
>>> rpm=open('rpm.xml.txt','rb').read()
>>> rpm=rpm.decode('utf-8', errors='ignore')
>>> rpms = ['<rpmHeader>' + val for val in rpm.split('<rpmHeader>') if val]
>>> parsed=[xmltodict.parse(r) for r in rpms]

I have also attached that sample XML created with:
rpm --query --all --qf '[%{*:xml}\n]' --dbpath=<path to RPM DB directory typically some /var/lib/rpm/ > ~/rpm.xml.txt
rpm.xml.txt

Note that for the odd cases where the rpmdb is not in the format that the current rpm tool can analyze, the process could be to rebuild the database, though it is not entirely clear if this may not be missing out some RPMs (if so we may need to either read the RPM db directly OR use multiple older version of the RPM exe)

make a copy of the DB and work on that copy since this is destructive
Run rpmdb --rebuilddb --dbpath=<path to RPM DB directory typically some /var/lib/rpm/ where the copy was made> --root=<path to the pseudo root of the filesystem>

Note that for the odd cases where the rpmdb is not in the format that the current rpm tool can analyze, the process could be to rebuild the database, though it is not entirely clear if this may not be missing out some RPMs (if so we may need to either read the RPM db directly OR use multiple older version of the RPM exe)

make a copy of the DB and work on that copy since this is destructive
Run rpmdb --rebuilddb --dbpath=<path to RPM DB directory typically some /var/lib/rpm/ where the copy was made> --root=<path to the pseudo root of the filesystem>

@pombredanne I have written a simple parser to parse the above XML file and convert to a JSON file.
See https://github.com/nexB/spats/blob/rpm_xmltodict_parser/src/spats/parse_rpm_db.py
Attached the parsed result:
parsed.json.txt
There are some logical things that need to be done for
Dirindexes, Dirnames and Fileclass, Classdict
but I don't know what's the desire output that the pipeline need.
Suggestion and feedback are welcome.

@pombredanne I have written a simple parser to parse the above XML file and convert to a JSON file.
See https://github.com/nexB/spats/blob/rpm_xmltodict_parser/src/spats/parse_rpm_db.py
Attached the parsed result:
parsed.json.txt
There are some logical things that need to be done for
Dirindexes, Dirnames and Fileclass, Classdict
but I don't know what's the desire output that the pipeline need.
Suggestion and feedback are welcome.

@pombredanne running a docker pipeline on a rpm-centos-latest.tar image with the latest 6-rpm-support branch (scancode-toolkit[packages]==21.3.31):
collect_installed_rpmdb_xmlish_from_rpmdb_loc: Failed to execute RPM command: /usr/local/lib/python3.9/site-packages/rpm_inspector_rpm/bin/rpm --query --all --qf [%{*:xml}
] --dbpath /var/scancodeio/workspace/projects/rpm-eb756fcb/codebase/50-rpm-centos-latest.tar-extract/cbab9bd72bc8f39dfc72b687ab56cd464589268d2a468ea8104fee89e4ca8b84/var/lib/rpm
/usr/local/lib/python3.9/site-packages/rpm_inspector_rpm/bin/rpm: error while loading shared libraries: libpopt.so.0: cannot open shared object file: No such file or directory
Traceback:
  File "/opt/scancodeio/scanpipe/pipelines/__init__.py", line 95, in execute
    step(self)
  File "/opt/scancodeio/scanpipe/pipelines/docker.py", line 79, in collect_and_create_system_packages
    docker.scan_image_for_system_packages(self.project, image)
  File "/opt/scancodeio/scanpipe/pipes/docker.py", line 122, in scan_image_for_system_packages
    for i, (purl, package, layer) in enumerate(installed_packages):
  File "/usr/local/lib/python3.9/site-packages/container_inspector/image.py", line 329, in get_installed_packages
    for purl, package in layer.get_installed_packages(packages_getter):
  File "/opt/scancodeio/scanpipe/pipes/rpm.py", line 30, in package_getter
    packages = rpm.get_installed_packages(root_dir, detect_licenses=detect_licenses)
  File "/usr/local/lib/python3.9/site-packages/packagedcode/rpm.py", line 163, in get_installed_packages
    xmlish_loc = rpm_installed.collect_installed_rpmdb_xmlish_from_rootfs(root_dir)
  File "/usr/local/lib/python3.9/site-packages/packagedcode/rpm_installed.py", line 401, in collect_installed_rpmdb_xmlish_from_rootfs
    return collect_installed_rpmdb_xmlish_from_rpmdb_loc(rpmdb_loc)
  File "/usr/local/lib/python3.9/site-packages/packagedcode/rpm_installed.py", line 456, in collect_installed_rpmdb_xmlish_from_rpmdb_loc
    raise Exception(msg)

I pushed a new RPM plugin for the toolkit https://pypi.org/project/rpm-inspector-rpm/<IP_ADDRESS>.210404/ and two commits:

https://github.com/nexB/scancode.io/commit/52bbe6a7514149a95f8188cea987007776e0fc97
https://github.com/nexB/scancode.io/commit/8bc9b4a0fec76a1c12428f7df637428e9343f34c
and this make things work on Linux. I still need to have a few more refinements to also run on macOS with RPM in the path

I tested locally on a centos: latest docker image with success


Main Page Tweaks

Link to openhumansfoundation.org. Right now, OHF is mentioned but not linked under “About our organization” which is under “Are you a researcher?” and above “Website Policies”. Could also link to PG.org and GET here.
Put “You decide when to share…..” before “Be a part of research….” and add the header "Your data is more powerful when you're a part of it."
Change "Through Open Humans, you can gather valuable data about yourself and find cool projects to share it with." to "Through Open Humans, you can gather valuable data about yourself and find cool projects with which to share it. The data you provide will be private by default."

This will also be done in the larger redesign efforts 👍


Show tag values poor performance

System info: [InfluxDB 0.13.0, CentOS release 6.8 (Final)]
Total rows: 680k~700k
Number of tag value for "my_key": 27
curltime "http://<IP_ADDRESS>:8986/query?q=SHOW+TAG+VALUES+FROM+"my_measurement"+WITH+KEY+%3D+"my_key"&db=my_udp_db"
Expected behavior: < 1000ms
Actual behavior: 29,677(ms)
curltime "http://<IP_ADDRESS>:8986/query?q=select+count(a_field)+from+22my_measurement&db=my_udp_db"
Expected behavior: < 1000ms
Actual behavior: 35,498(ms)
Current, I have 4 tag key. two of them is username and user id (these tag may be have more than 100k difference values and even more), and the rest may have <= 1000 values.
I'm tested on other measurements, even if the number of row in other measurement is quite big (>30 million) but the show tag values on those measurements still very fast. (number of tag values ~40)
Is the any problem with my db (in design)?
// My curltime function:
function __curl_time(){
       curl -o /dev/null -s -w %{time_total}\(ms\)\\n  "$1"
}

Update:
Currently, I've delete all of these measurements. Moving username and uid to field instead of key.
But I think there still an issue, esspecially when I query on these measurement like:
select * from my_measurement limit 1
drop measurement my_measurement (this query take very long in admin dashboard, and something likely to shutdown influxdb)
It crash my influxdb instance (I'm running in single mode).

This was fixed by #6792 is in the current 1.0beta releases.


Hello, i tried to update the logo for my token but it seems that it needs a manual review, can you please check it? thank you

Hello, i tried to update the logo for my token but it seems that it needs a manual review, can you please check it? thank you
Originally posted by @kisscoins in https://github.com/solana-labs/token-list/issues/11247#issuecomment-1002735975

see comment in PR

merged

Thank you so much @keone, I really apreciarte it.


Location service LWC

This is a LWC that uses Nimbus location service to fetch GPS coordinate.
https://user-images.githubusercontent.com/42476999/231016604-35ddf311-a3d0-4316-a8b2-f2f15d0a090c.mov

Updated error handling according to the feedback.
https://user-images.githubusercontent.com/42476999/231293812-f8849d56-338d-43e2-b587-acf550cd0e25.mov
https://user-images.githubusercontent.com/42476999/231293814-b1a1fe96-9e9e-438d-b69b-09089a9e7d38.mov


add statement position to error info

PostgreSQL can return the position of an error which is useful when
executing arbitrary SQL statements. Include this position in the
DatabaseErrorInformation implementation for PG.

This is really a string value containing a decimal integer, per: https://www.postgresql.org/docs/13/libpq-exec.html:

PG_DIAG_STATEMENT_POSITION
A string containing a decimal integer indicating an error cursor position as an index into the original statement string. The first character has index 1, and positions are measured in characters not bytes.

Question is if @sgrif would see the problem with it returned as per postgresql definition, as a string, containing a decimal integer.

This is really a string value containing a decimal integer, per: https://www.postgresql.org/docs/13/libpq-exec.html:

That sounds like an implementation detail then. If it essentially returns a integer we should return an integer from this function.

Closed as #2652 took over this PR


How to use this module with Node.js ?

Hello,
I try to use this module with node but i get the following error :
    Error: Cannot find module 'axis.js'

Step to reproduce :
    npm install axis.js
    node -e "console.log(require('axis.js'))"

any thoughts ?

I did some search, and i think this is because there is no "main" property in your package.json file and node is looking for an index.js file in project root.


Ensure PodSecurityPolicy controller is enabled on the Kubernetes Engine Clusters

Possible check to target the following resource

[ ] google_container_cluster

closing, tracking in spreadsheet


Add .github/ops-bot.yaml config file [skip ci]

In the near future, the rapidsai/ops-bot GitHub application that we use for GitHub automation will be enabled on all repositories in the rapidsai GitHub organization. Since not all features of the application are applicable to all repositories, this PR adds a new file, .github/ops-bot.yaml, which can configure which features are enabled per repository.

@gpucibot merge


Writing files > RAM

Feature request
A (documented) method for writing files with more tensor data than can be fit into RAM
Motivation
The documented method for writing files is to pass a dict of tensors. This requires having all the tensors in RAM.
However, it should be possible to write safetensors files larger than RAM by either adding tensors to existing files (without reading the files into memory).
That will enable some code like (function names are just to explain, could be different):
safetensors.extend_file(tensors, filename)

# Alternatively, writing in chunks
with safetensors.create_file(filename) as s_file:
    for i in range(len(indices)):
         # Only one tensor loaded in RAM at a time
         s_file.write(create_tensor(i))

Your contribution
Won't be able to work on this myself for a while. If this doesn't get picked up, I'll try implement this in a few weeks

It's trickier than you think.
We need ALL metadata to be able to write the header. Since the data comes after the metadata, you cannot write the first tensors before having the entire header.
Making the API for such a thing relatively confusing (also lots of sanity checking because you need to write the proper tensors at every proper location, and not miss tensors for your final file to be correct.
Is there any reason you cannot just split the tensors over multiple files ? (This is what we do in distributed training for instance).
Fusing existing on disk files is much much simpler (just take all headers, add offsets whereever they might need to be, and copy the buffers next to each other in the new file (for which you can require as low ram as you want).

Well, you can in fact stream a safetensors file to disk so long as you have a good guesstimate of the length of your header and reserve space for it in advance. You'll just need to pad the JSON with whitespace at the end; serde chokes on null bytes, but not spaces...
import json
import random
import struct

import safetensors.torch

header_size = 65536
data_start_offset = header_size + 8
header = {}
filename = "test.safetensors"
with open(filename, "wb+") as f:
    f.seek(data_start_offset)
    for x in range(3):
        data = random.randbytes(4 * 4)
        start = f.tell() - data_start_offset
        header[f"tensor-{x}"] = {"dtype": "U8", "shape": [4, 4], "data_offsets": [start, start + len(data)]}
        f.write(data)
    f.seek(0)
    f.write(struct.pack("<Q", header_size))
    header_bytes = json.dumps(header).encode()
    assert len(header_bytes) < header_size
    f.write(header_bytes.ljust(header_size))
print(safetensors.torch.load_file(filename))

happily prints out
{'tensor-0': tensor([[ 16, 220, 170, 117],
        [202, 128,  68, 122],
        [ 70, 210,  61, 194],
        [177, 196, 130, 206]], dtype=torch.uint8), 'tensor-1': tensor([[ 32, 147,  97, 129],
        [147,  24, 193, 143],
        [241, 122, 232, 210],
        [245,  99,  79,  27]], dtype=torch.uint8), 'tensor-2': tensor([[ 74, 117, 201, 217],
        [ 27,  57,  60, 128],
        [136,  15, 230, 158],
        [ 47, 220, 168, 159]], dtype=torch.uint8)}

That works !
However I wouldn't be ok implementing that in the core library because the failure mode when not enough space has been reserved is a pretty bad experience (and it's not easy to determine how much space you need without knowing all the tensors you need).
Futhermore, reserving way too much space is likely to occur and therefore that's a lot of wasted space for everyone if that becomes the standard.
Feel free to use that trick, it does work, but I'm not sure I would want to add such a surface in the lib without strong motivation.

Yeah, it's a Weird Trick alright, but as discussed in the linked PR, I think allowing trailing whitespace padding for the header will be a good idea in the long run. (But that discussion is there :) )


Add pascal triangle to example

Test Result:
一
一。一
一。二。一
一。三。三。一
一。四。六。四。一
一。五。一十。一十。五。一
一。六。一十五。二十。一十五。六。一
一。七。二十一。三十五。三十五。二十一。七。一
一。八。二十八。五十六。七十。五十六。二十八。八。一
Please kindly let me know:

if there's better coding style
if I should be using "杨辉三角" as opposed to "贾宪三角" for awareness

Nice, thanks for the new example!

賈憲三角 is fine, we should insist on the right credit :)
Your coding style is good

One request though, could you make it print so that the overall shape is an equilateral triangle instead of a right angle one, like this image: https://upload.wikimedia.org/wikipedia/commons/c/c0/Jiaxian.jpg ? Current is also fine if you don't want to change or think it will over-complicate the code.
Thanks!

@LingDong- Good suggestion. I tried to add the padding after you brought up, but right now all the implementations I can think of are very verbose and take away the main point here. I think it might be easier to come back after we have array.toString() method (then we just have to pad spaces). Or let me know if you have an easy implementation in mind.
噫。吾嘗思文言之難，方悟python之易！ :)

Makes sense. I'll merge it now, and perhaps if later I have time I can see if there's an easy implementation for padding.
Thanks again for the example!

@LingDong- thanks. We can keep thinking about it. Let me know if you have some scheme and I can write it out as well.


Class list for overview members is off

Generates class="["public"]"  instead of class="public". This is because declStyleClasses returns a list of strings instead of a white space separated string of entries and diet-ng removed a convenience special case for the class attribute.

PR: https://github.com/rejectedsoftware/diet-ng/pull/41


Set a constant name for the har file created by net export addon on fire bug

it would be nice to be able to set the name of the exported file.
if would be even nicer if i were able to issue a command like this:
save_now(under_this_name)
if maybe i wanted to save the requests between two clicks on the same page
thank you!

I wonder whether there is an option to set the file name of the exported har file or not now?

Yes it is now possible to provide a custom name.

There is a new pref:  extensions.firebug.netexport.defaultFileName
You can set it to a string that is used as a format string for generating the name
An example: myname-%Y-%m-%d-endofthename

Read more about the format:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat

You can pass name into NetExport.triggerExport() API

NetExport.triggerExport({
fileName: "myFileName"
})
NetExport is currently bundled in Firebug.next, this new feature available in alpha 10
https://github.com/firebug/firebug.next/releases/tag/firebug-3.0.0-alpha.10
Honza

Here is the screenshot of my about:config. There isn't a pref named extensions.firebug.netexport.defaultFileName.
What's more, it did not show up in https://github.com/firebug/netexport/blob/master/defaults/preferences/prefs.js, either.
Can you have a look at this?
Many thanks!
Yui

Now I use Selenium + FirefoxWebdriver(FF for mac 37.0.2 ) + Firebug 3. I wrote a Har file generator in Java and take the use of the code on your blog as the following. However, the new pref:  extensions.firebug.netexport.defaultFileName dosen't work. Is there some thing wrong? Or is it necessary for me to use a format as you mention above?
Many thx!
Yui
Here is the Java code:
   String url ="www.google.com";
    // Set default Firefox preferences
    profile.setPreference("app.update.enabled", false);

    String domain = "extensions.firebug.";

    // Set default Firebug preferences
    profile.setPreference(domain + "currentVersion", "3.0.0");
    profile.setPreference(domain + "allPagesActivation", "on");
    profile.setPreference(domain + "defaultPanelName", "net");
    profile.setPreference(domain + "net.enableSites", true);

    // Set default NetExport preferences
    profile.setPreference(domain + "netexport.alwaysEnableAutoExport", true);
    profile.setPreference(domain + "netexport.showPreview", false);
    profile.setPreference(domain + "netexport.defaultLogDir", "~/project/har");
    profile.setPreference(domain + "netexport.defaultFileName", url);// Set the name of the har log file

  //Set up the browser
    WebDriver driver = new FirefoxDriver(profile);
    driver.get(url);

Here is the screenshot of my about:config. There isn't a pref named extensions.firebug.netexport.defaultFileName.

There is for me, make sure you have Firebug 3 alpha 11 installed (the latest)
http://getfirebug.com/releases/firebug/3.0/
(look in this directory)

What's more, it did not show up in https://github.com/firebug/netexport/blob/master/defaults/preferences/prefs.js, either.
You don't need the NetExport at this point.

Honza


feaTools.parser.FeaToolsParserSyntaxError: u'lookupflag format B is not supported for any value other than 0'

I got this error while processing, using pipeline delivery, of Noto Serif Hebrew font.
Is this a fontmake issue or a problem with the delivered files or a compatibility issue?
< >>> Parsing .glyphs file
< >>> Casting parsed values
< >>> Loading to RFonts
< >>> Writing masters
< >>> Building instances
< >> Removing overlaps for NotoSerifHebrew-Thin
< >> Removing overlaps for NotoSerifHebrew-Light
< >> Removing overlaps for NotoSerifHebrew-Regular
< >> Removing overlaps for NotoSerifHebrew-SemiBold
< >> Removing overlaps for NotoSerifHebrew-Bold
< >> Removing overlaps for NotoSerifHebrew-ExtraBold
< >> Removing overlaps for NotoSerifHebrew-Black
< >> Removing overlaps for NotoSerifHebrewCondensed-Thin
< >> Removing overlaps for NotoSerifHebrewCondensed-Light
< >> Removing overlaps for NotoSerifHebrewCondensed-Regular
< >> Removing overlaps for NotoSerifHebrewCondensed-SemiBold
< >> Removing overlaps for NotoSerifHebrewCondensed-Bold
< >> Removing overlaps for NotoSerifHebrewCondensed-ExtraBold
< >> Removing overlaps for NotoSerifHebrewCondensed-Black
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-Thin
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-Light
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-Regular
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-SemiBold
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-Bold
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-ExtraBold
< >> Removing overlaps for NotoSerifHebrewSemiCondensed-Black
< >> Saving OTF for NotoSerifHebrew-Thin
< Traceback (most recent call last):
<   File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
<     "main", fname, loader, pkg_name)
<   File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
<     exec code in run_globals
<   File "build/bdist.linux-x86_64/egg/fontmake/main.py", line 51, in
<   File "build/bdist.linux-x86_64/egg/fontmake/main.py", line 39, in main
<   File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 184, in run_from_glyphs
<   File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 212, in run_from_ufos
<   File "build/bdist.linux-x86_64/egg/fontmake/font_project.py", line 120, in save_otf
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/init.py", line 29, in compileOTF
<     featureCompilerClass, mtiFeaFiles, kernWriter, markWriter)
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/init.py", line 18, in _compile
<     featureCompiler.compile()
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/makeotfParts.py", line 37, in compile
<     self.setupFile_features()
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/makeotfParts.py", line 73, in setupFile_features
<     autoFeatures["kern"] = self.writeFeatures_kern()
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/makeotfParts.py", line 97, in writeFeatures_kern
<     return writer.write()
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/kernFeatureWriter.py", line 61, in write
<     self._collectFeaClasses()
<   File "/usr/local/lib/python2.7/dist-packages/ufo2ft/kernFeatureWriter.py", line 99, in _collectFeaClasses
<     parser.parseFeatures(self, self.featxt)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 657, in parseFeatures
<     _parseUnknown(writer, text)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 309, in _parseUnknown
<     _parseFeature(writer, featureTag, featureText)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 438, in _parseFeature
<     parsed = _parseUnknown(featureWriter, feature)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 327, in _parseUnknown
<     _parseLookup(writer, lookupName, lookupText)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 442, in _parseLookup
<     parsed = _parseUnknown(lookupWriter, lookup)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 339, in _parseUnknown
<     text = _executeSimpleSlice(precedingMark, text, subType1And4RE, writer)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 432, in _executeSimpleSlice
<     _parseUnknown(writer, precedingText)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 407, in _parseUnknown
<     _parseLookupFlag(writer, lookupflagValues)
<   File "/usr/local/lib/python2.7/dist-packages/feaTools/parser.py", line 621, in _parseLookupFlag
<     raise FeaToolsParserSyntaxError("lookupflag format B is not supported for any value other than 0")
< feaTools.parser.FeaToolsParserSyntaxError: u'lookupflag format B is not supported for any value other than 0'

I'm unable to reproduce it after I rebuilt the pipeline on Thursday 2016-03-31 evening (about 10pm PDT)
The problem was either fixed or my build problem.
now my diff of logs says
8175,8361c8175,8217
< >> Saving OTF for NotoSerifHebrew-Light
< >> Saving OTF for NotoSerifHebrew-Regular
< >> Saving OTF for NotoSerifHebrew-SemiBold
< >> Saving OTF for NotoSerifHebrew-Bold
< >> Saving OTF for NotoSerifHebrew-ExtraBold
< >> Saving OTF for NotoSerifHebrew-Black
< >> Saving OTF for NotoSerifHebrewCondensed-Thin
< >> Saving OTF for NotoSerifHebrewCondensed-Light
< >> Saving OTF for NotoSerifHebrewCondensed-Regular
< >> Saving OTF for NotoSerifHebrewCondensed-SemiBold
< >> Saving OTF for NotoSerifHebrewCondensed-Bold
< >> Saving OTF for NotoSerifHebrewCondensed-ExtraBold
< >> Saving OTF for NotoSerifHebrewCondensed-Black
< >> Saving OTF for NotoSerifHebrewSemiCondensed-Thin
< >> Saving OTF for NotoSerifHebrewSemiCondensed-Light
< >> Saving OTF for NotoSerifHebrewSemiCondensed-Regular
< >> Saving OTF for NotoSerifHebrewSemiCondensed-SemiBold
< >> Saving OTF for NotoSerifHebrewSemiCondensed-Bold
< >> Saving OTF for NotoSerifHebrewSemiCondensed-ExtraBold
< >> Saving OTF for NotoSerifHebrewSemiCondensed-Black
< >> Converting curves for NotoSerifHebrew-Thin
< New spline lengths:
< 3: 1042
< 4: 377
< 5: 8
< 6: 9
.......... and many more


Add Languages

Hello, I would like if its possible to add languages, I will contribute translating it to spanish
Regards

After months of struggling trying solutions, I found Weblate being a fitting solution. I added the Spanish language so you can start translating if you want.
Here is the link: https://hosted.weblate.org/projects/gumbo/extension/es/
I have applied for a Libre hosting plan and hope to be approved in the next few days.
If a language is not in the list, you can request the one you like from there so I can add it to the list.

Hello, I've translated most of the strings, I left some without translation
because I don't know where does that string go, so I can see it when
updated, and get the proper translation
Regards
El sáb, 28 may 2022 a las 16:27, Alexandre Breteau (<
@.***>) escribió:

After months of struggling trying solutions, I found Weblate being a
fitting solution. I added the Spanish language so you can start translating
if you want.
Here is the link: https://hosted.weblate.org/projects/gumbo/extension/es/
I have applied for a Libre hosting plan and hope to be approved in the
next few days.
If a language is not in the list, you can request the one you like from
there so I can add it to the list.
—
Reply to this email directly, view it on GitHub
https://github.com/Seldszar/Gumbo/issues/30#issuecomment-1140274776, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACTQBM66THMDISX37OV2CJLVMIUMFANCNFSM5SEZXNNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


App crash when using BackgroundGeolocation.stop()

Your Environment

Plugin version: 0.5.0-alpha.50
Platform: Android
OS version: any
Device manufacturer and model: any

Running in Simulator: yes
React Native version: 0.52.0
Plugin configuration options:
Link to your project: yes

Context
On calling
BackgroundGeolocation.stop()

app got freezed then crash after sometime
Expected Behavior
BackgroundGeolocation service should stop without any side effects
Actual Behavior
App got freezed then crash after sometime
Possible Fix
Steps to Reproduce
On calling
BackgroundGeolocation.stop()

Context
Unable to stop background geolocation service
Debug logs
2018-12-19 17:16:24.167 1641-1654/? E/ActivityManager: ANR in drivezy.admin
PID: 23144
Reason: executing service drivezy.admin/com.marianhello.bgloc.service.LocationServiceImpl
Load: 1.7 / 1.43 / 0.99
CPU usage from 26372ms to 0ms ago (2018-12-19 17:15:56.983 to 2018-12-19 17:16:23.355):
10% 23144/drivezy.admin: 8.4% user + 2.4% kernel / faults: 4304 minor
5.1% 1299/surfaceflinger: 0.4% user + 4.6% kernel / faults: 1 minor
4.2% 1641/system_server: 2.2% user + 1.9% kernel / faults: 4819 minor
1.4% 1343/audioserver: 0.1% user + 1.2% kernel
1% 1972/com.google.android.gms.persistent: 0.8% user + 0.2% kernel / faults: 132 minor
0.6% 1935/adbd: 0.1% user + 0.5% kernel / faults: 1145 minor
0.4% 1715/com.android.systemui: 0.2% user + 0.2% kernel / faults: 3 minor
0.3% 22405/kworker/u5:2: 0% user + 0.3% kernel
0.2% 21036/kworker/u5:0: 0% user + 0.2% kernel
0.2% 1324/dmcrypt_write: 0% user + 0.2% kernel
0.1% 1840/com.android.phone: 0% user + 0.1% kernel / faults: 2 minor
0.1% 23112/kworker/0:0: 0% user + 0.1% kernel
0.1% 563/kswapd0: 0% user + 0.1% kernel
0.1% 1336/jbd2/dm-0-8: 0% user + 0.1% kernel
0% 3/ksoftirqd/0: 0% user + 0% kernel
0% 8/rcu_preempt: 0% user + 0% kernel
0% 1242/kworker/0:1H: 0% user + 0% kernel
0% 12/ksoftirqd/1: 0% user + 0% kernel
0% 1249/logd: 0% user + 0% kernel
0% 1298/servicemanager: 0% user + 0% kernel
0% 1352/netd: 0% user + 0% kernel / faults: 63 minor
0% 1434/dhcpclient: 0% user + 0% kernel
0% 22591/com.android.vending: 0% user + 0% kernel / faults: 14 minor
10% TOTAL: 5.6% user + 3.5% kernel + 0.3% iowait + 0.4% softirq
CPU usage from 303ms to 808ms later (2018-12-19 17:16:23.658 to 2018-12-19 17:16:24.163):
9.9% 1641/system_server: 7.9% user + 1.9% kernel / faults: 2593 minor
7.9% 2069/Binder:1641_8: 3.9% user + 3.9% kernel
1.9% 1648/FinalizerDaemon: 1.9% user + 0% kernel
5.7% 1935/adbd: 0% user + 5.7% kernel / faults: 572 minor
1.9% 1935/adbd: 0% user + 1.9% kernel
9% TOTAL: 4% user + 5% kernel

I have the same exact issue.

@hackyxicor Hi did you find any solution or workaround?

I have the same exact issue.

@hackyxicor Hi did you find any solution or workaround?

add a delay of at least 1 sec before the next action.

I did setTimeout(this.stopTracking.bind(this), 1000). Still crashes. These are my intervals
interval: 60000,
fastestInterval: 120000,
activitiesInterval: 100000

@joppeel
I am also having the same issue. My application not responding after calling BackgroundGeolocation.stop(). Have you found any solution?

@dhrupalG Hi, I'm still having the problem on a simulator so unfortunately I haven't found any solution.

@dhrupalG Okay now I managed to produce this error on a real device, but I solved by hackyxicor's workaround so by just setting a timeout for the stop function call. I hope this helps you too!

I'm still struggling with this problem although I thought I had solved it. I noticed that the app crashes at some point after repeatedly starting and then stopping the backgroundgeolocation on a real device(OnePlus 3T, Android 8.0.0). On a simulator(Nexus 5X, Android 8.1) it crashed immediately after calling the stop function producing the same error log as described on the issue description. I created a simple app mostly based on the sample app from the documentation to demonstrate this problem, could you tell if I'm doing something wrong @mauron85 ? I'm now running version 0.5.0 of BackgroundGeolocation.
`import React, { Component } from 'react'
import { Alert, View, Platform, Button } from 'react-native'
import BackgroundGeolocation from 'react-native-mauron85-background-geolocation'
class BgTracking extends Component {
componentDidMount() {
BackgroundGeolocation.configure({
desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
stationaryRadius: 50,
distanceFilter: 10,
notificationTitle: 'Background tracking',
notificationText: 'enabled',
debug: true,
startOnBoot: false,
stopOnTerminate: true,
interval: 60000,
fastestInterval: 120000,
activitiesInterval: 100000,
stopOnStillActivity: false,
url: 'http://<IP_ADDRESS>:3000/location',
httpHeaders: {
'X-FOO': 'bar',
},
activityType: 'AutomotiveNavigation',
// customize post properties
postTemplate: {
lat: '@latitude',
lon: '@longitude',
},
locationProvider:
Platform.OS === 'ios'
? BackgroundGeolocation.RAW_PROVIDER
: BackgroundGeolocation.DISTANCE_FILTER_PROVIDER,
pauseLocationUpdates: false,
})
BackgroundGeolocation.on('location', location => {
  BackgroundGeolocation.startTask(taskKey => {
    console.log('LOCATION:')
    console.log(location)
    BackgroundGeolocation.endTask(taskKey)
  })
})

BackgroundGeolocation.on('authorization', status => {
  console.log(
    '[INFO] BackgroundGeolocation authorization status: ' + status
  )
  if (status !== BackgroundGeolocation.AUTHORIZED) {
    setTimeout(
      () =>
        Alert.alert(
          'App requires location tracking permission',
          'Would you like to open app settings?',
          [
            {
              text: 'Yes',
              onPress: () => BackgroundGeolocation.showAppSettings(),
            },
            {
              text: 'No',
              onPress: () => console.log('No Pressed'),
              style: 'cancel',
            },
          ]
        ),
      1000
    )
  }
})

}
componentWillUnmount() {
BackgroundGeolocation.removeAllListeners()
}
render() {
return (
<View style={{ flex: 1, justifyContent: 'space-around' }}>
<Button
onPress={() => BackgroundGeolocation.start()}
title={'start tracking'}
/>
<Button
onPress={() => BackgroundGeolocation.stop()}
title={'stop tracking'}
/>

)
}
}
export default BgTracking
`

Okay now I managed to solve this problem for good, the Android Gradle Plugin that I was using forced the application to use a version of Android SDK Build-Tools which was different from the one that was specified in this plugin's documentation.

@joppeel can you post how solve this problem?  I have same issue in a real device.  :(

@WilliamPeralta So I think at least in my case the issue was due to the fact that I had specified the Android Gradle plugin that I was using like this:
dependencies {
  classpath 'com.android.tools.build:gradle:3.1.4'
}

This version(3.1.4) of the plugin forced the app to use the build tools version of 27.0.3, but as I was using the experimental Android Orio support, I needed to use the version 26.0.2 of the build tools as it is defined in this background tracking plugin's documentation like this:
ext {
  compileSdkVersion = 26
  targetSdkVersion = 26
  buildToolsVersion = "26.0.2"
  supportLibVersion = "26.1.0"
  googlePlayServicesVersion = "11.8.0"
  oreoEXPERIMENTAL = "yes"
}

So by downgrading to using Android Gradle plugin version 3.0.1 fixed this problem, since it allowed me to use the correct version of the build tools. I can't say if this is the only solution to the problem or whether it's a good or bad solution(I guess it depends on the case) but this is how I fixed it :)

Hi
App crashes on calling Background.stop() function,
please anyone help on this?

Adicione o seguinte em android/build.gradle:
ext {
googlePlayServicesVersion = "9.8.0"
}

Clear the Application storage.

Using following permission fixed it.

I am still facing this issue, even after adding permission as @tawsifalam  suggested didn't help. Here are my build.gradle and package configuration.
build.gradle:
buildscript {
ext {
googlePlayServicesVersion = "17.0.0"
firebaseMessagingVersion = "+"
buildToolsVersion = "29.0.2"
minSdkVersion = 16
compileSdkVersion = 29
targetSdkVersion = 29
supportLibVersion = "28.0.0"
}
repositories {
google()
jcenter()
}
dependencies {
classpath("com.android.tools.build:gradle:4.0.1")
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
classpath 'com.google.gms:google-services:4.2.0'
}
}

Configuration:
BackgroundGeolocation.configure({
desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
stationaryRadius: 5,
distanceFilter: 1,
notificationTitle: 'Tracking',
notificationText: "Don't mind me just watching",
notificationsEnabled: true,
startForeground: true,
debug: false,
startOnBoot: true,
stopOnTerminate: false,
locationProvider: BackgroundGeolocation.ACTIVITY_PROVIDER,
interval: 10 * 1000,
fastestInterval: 5000,
activitiesInterval: 10000,
stopOnStillActivity: false,
url: 'http://<IP_ADDRESS>:3000/location',
httpHeaders: {
'X-FOO': 'bar',
},
// customize post properties
postTemplate: {
lat: '@latitude',
lon: '@longitude',
foo: 'bar', // you can also add your own properties
},
});

I Add on Manifest
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
and in BackgroundGeolocation.configure() add:
url: null
Thanks to @rosnaib11
https://github.com/mauron85/react-native-background-geolocation/issues/487#issuecomment-651943013


add filter

Codecov Report
Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.00%. Comparing base (4902512) to head (e3533bd).

Files with missing lines
Patch %
Lines

cmd/root.go
93.75%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   71.95%   75.00%   +3.04%
==========================================
  Files           2        2
  Lines          82       92      +10
==========================================
+ Hits           59       69      +10
  Misses         15       15
  Partials        8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ImportError: No module named handler.Handler

Mac OS X Lion, installed Diamond from git.  Running it gives this error:
$ diamond
Traceback (most recent call last):
File "/usr/bin/diamond", line 40, in
from diamond.server import Server
File "/Library/Python/2.7/site-packages/diamond/server.py", line 21, in
from diamond.handler.Handler import Handler
ImportError: No module named handler.Handler
Seems like I'm missing something?

if you make run in the git checkout, does it work?

It doesn't. If I git clone, then modify a conf to point to my graphite server, and then:
Bruces-MacBook-Air:Diamond blysik$ make run
./bin/diamond --configfile=conf/diamond.conf --foreground --verbose
Traceback (most recent call last):
File "./bin/diamond", line 18, in
from diamond.server import Server
File "/Library/Python/2.7/site-packages/diamond/server.py", line 21, in
from diamond.handler.Handler import Handler
ImportError: No module named handler.Handler
make: *** [run] Error 1
Bruces-MacBook-Air:Diamond blysik$
--
Bruce Z. Lysik<EMAIL_ADDRESS>
From: Rob Smith<EMAIL_ADDRESS>To: blysik<EMAIL_ADDRESS>Sent: Tuesday, February 21, 2012 11:03 AM
Subject: Re: [Diamond] ImportError: No module named handler.Handler  (#27)
if you make run in the git checkout, does it work?

Reply to this email directly or view it on GitHub:
https://github.com/BrightcoveOS/Diamond/issues/27#issuecomment-4081622

Okay, if I remove /Library/Python/2.7/site-packages/diamond and try again, I get farther. I must have installed something previously.
Looks like I just need to enable some collectors to test more:
Bruces-MacBook-Air:Diamond blysik$ sudo make run
./bin/diamond --configfile=conf/diamond.conf --foreground --verbose
[2012-02-21 12:04:01,441] [MainThread] Changed UID: 0 () GID: 0 ().
[2012-02-21 12:04:01,444] [MainThread] Loaded Handler: diamond.handler.GraphiteHandler.GraphiteHandler
[2012-02-21 12:04:01,517] [MainThread] Established connection to graphite server seostats.apple.com:2003
[2012-02-21 12:04:01,519] [MainThread] Loaded Handler: diamond.handler.ArchiveHandler.ArchiveHandler
[2012-02-21 12:04:01,523] [MainThread] Loading Collectors from: /usr/share/diamond/collectors/
[2012-02-21 12:04:01,523] [MainThread] Skipped loading disabled Collector: cpu_collector
[2012-02-21 12:04:01,523] [MainThread] Skipped loading disabled Collector: disk
[2012-02-21 12:04:01,523] [MainThread] Skipped loading disabled Collector: disk_space_collector
[2012-02-21 12:04:01,523] [MainThread] Skipped loading disabled Collector: disk_usage_collector
[2012-02-21 12:04:01,524] [MainThread] Skipped loading disabled Collector: filestat_collector
[2012-02-21 12:04:01,524] [MainThread] Skipped loading disabled Collector: load_average_collector
[2012-02-21 12:04:01,524] [MainThread] Skipped loading disabled Collector: memory_collector
[2012-02-21 12:04:01,524] [MainThread] Skipped loading disabled Collector: network_collector
[2012-02-21 12:04:01,524] [MainThread] Skipped loading disabled Collector: sockstat_collector
[2012-02-21 12:04:01,524] [MainThread] Skipped loading disabled Collector: tcp_collector
[2012-02-21 12:04:01,525] [MainThread] Skipped loading disabled Collector: user_scripts_collector
[2012-02-21 12:04:01,525] [MainThread] Skipped loading disabled Collector: vmstat_collector
[2012-02-21 12:04:01,527] [MainThread] Started task scheduler.
--
Bruce Z. Lysik<EMAIL_ADDRESS>
From: Bruce Lysik<EMAIL_ADDRESS>To: Rob Smith<EMAIL_ADDRESS>Sent: Tuesday, February 21, 2012 11:29 AM
Subject: Re: [Diamond] ImportError: No module named handler.Handler  (#27)
It doesn't. If I git clone, then modify a conf to point to my graphite server, and then:
Bruces-MacBook-Air:Diamond blysik$ make run
./bin/diamond --configfile=conf/diamond.conf --foreground --verbose
Traceback (most recent call last):
File "./bin/diamond", line 18, in
from diamond.server import Server
File "/Library/Python/2.7/site-packages/diamond/server.py", line 21, in
from diamond.handler.Handler import Handler
ImportError: No module named handler.Handler
make: *** [run] Error 1
Bruces-MacBook-Air:Diamond blysik$
--
Bruce Z. Lysik
<EMAIL_ADDRESS>
From: Rob Smith<EMAIL_ADDRESS>To: blysik<EMAIL_ADDRESS>Sent: Tuesday, February 21, 2012 11:03 AM
Subject: Re: [Diamond] ImportError: No module named handler.Handler  (#27)
if you make run in the git checkout, does it work?

Reply to this email directly or view it on GitHub:
https://github.com/BrightcoveOS/Diamond/issues/27#issuecomment-4081622

I don't believe anything other then the exampleCollector and the service collectors work on OS X directly. I'm not sure if OS X exposes the needed info for us to collect in all cases.

Doh.  That's too bad.  Thanks for the assistance.


Suggestion: Add a link to the official defnitions of the parameters.

Hi,
I needed to know what "InternalName" meant and stumbled upon this page by Microsoft.
https://docs.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block
It may be worth adding to the ReadMe file.

Thank you for the feedback! That makes sense, I will add it.

Would you like a pull request?
I'll add a subsection in "Background" and put in a table.

Sure, a PR would be much appreciated! Adding it to the Background section is fine.

@DudeNr33 I added the table and opened PR #12.
Sorry if the PR is a little sloppy.


Define coordinate system

As far as I can tell, the spec doesn't define the coordinate system in use (e.g. which direction is positive in each axis, what point on the entity is represented by its {x,y} position.
For interoperability, it would be good to tie this down explicitly.

I think it's safe to assume this coordinates system is based on the webview one.
x axis: negative values go left, positive right
y axis: negative values go up, positive go down.
But I agree, it should be said explicitly

And to clarfiy which point does it specify on the node: Top-left? Center? Bottom-left?


vimPlugins.vim-clap: 0.44 -> 0.45

Diff: https://github.com/liuchengxu/vim-clap/compare/v0.44...v0.45
Changelog: https://github.com/liuchengxu/vim-clap/blob/v0.45/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 244237 run on x86_64-linux 1

1 package built:

vimPlugins.vim-clap


[WIP] More image problems, including MOO

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue
We need real MOO problems.
A second modification is coming, with a specifically MOO evaluation function.
How Has This Been Tested (if it applies)
Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[x] All tests passed, and additional code has been covered with new tests.

I'm doing soooo dirty things for the OOM issues in the ci...

please merge master, there are unrelated changes in it


[Key Vault] formatting

The result of running rush format.

Okay, let's wait for https://github.com/Azure/azure-sdk-for-js/pull/10280 to be merged.

@ramya-rao-a I rebased this on the renaming work.


Added test for GET request

Thanks @milancurcic, i have made the required changes

Yes, when you write(stderr, *) "error message", it merely prints it to standard error stream, but the program can still complete with a 0 status, so we need error stop 1.


[BOOM-3780] Module "Legal compliance" needs multishop capacities in PS 1.7

This issue has been migrated from the Forge. Read the original ticket here.

Reporter: comfuse
Created at: Tue, 5 Sep 2017 09:17:00 +0200

We run a multishop installation with four shops.
We need different CMS links for terms and conditions, imprints et cetera for each shop.
The "Legal compliance module" for german/austrian shops does not provide overall multishop capacities.
The problem goes beyond a simple functional nice-to-have:

You choose "terms and conditions" for shop A in module settings. The page you choose comes from a set of CMS pages specific to shop A (When you try to choose different pages for shop B they overwrite the settings for shop A).
You fill your cart in shop B. During checkout you click on "terms and conditions". The modal stays empty because CMS pages from shop A are not shared with shop B.
This renders the module useless in a multishop setting.

This is an urgent request.

This module has been archived, it’s no longer maintained but you still can fork it if you need it for your shop. This issue is closed then.


Configure OUs using AD Connect wizard only.

Hello team,
please update this part: "Organizational unit–based filtering" to ensure the modification is done through AD Connect wizard only.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: faed3c33-d05e-7a05-1327-27a79325f677
Version Independent ID: 151a61e3-ea34-7716-bbc8-66177f768b7b
Content: Azure AD Connect sync: Configure filtering
Content Source: articles/active-directory/hybrid/how-to-connect-sync-configure-filtering.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@tariqjaber Thank you for your feedback! We will review and provide an update as appropriate.

@tariqjaber
We do recommend the AD connect wizard as the primary method for making the changes. The details in the section OU based filtering already state the same.

The page also says that you should only resort to changing connector config only if you are unable to run the AD connect wizard. There was an internal conversation on making OU filtering a wizard only thing but that is still in discussion with the Product group . Once that is announced publicly, this page would be updated . hope the information helps. We will now close this issue. Should you have any further queries , please tag me or @billmath to your reply and we can gladly continue the conversation.


fullWidth not work in RaisedButton when upgrade to 0.15.0

Problem description
fullWidth not work in RaisedButton when upgrade to 0.15.0.
In 0.15.0-beta.2, it works.
Steps to reproduce
Just set fullWidth to true in RaisedButton.
<RaisedButton label="add section" fullWidth={true}  />

Versions

Material-UI: 0.15.0
React: 15.0.1
Browser: Chrome 50

Since this prop is being used, lets get the fix in to 0.15.1, and we can deprecate in favour of style in 0.16.0.

can confirm. All it needs is a  width: 100% on the div container.

@s-ol #4226 (as referenced above).

@mbrookes @oliviertassinari
Hello, I just upgrade to 0.15.1, and I have the same issue.
I've check the RaisedButton's source code, it should work as expect.
...
return {
    root: {
      display: 'inline-block',
      transition: transitions.easeOut(),
      minWidth: fullWidth ? '100%' : button.minWidth,
    },
    button: {
      position: 'relative',
      height: buttonHeight,
      lineHeight: `${buttonHeight}px`,
      width: '100%',
      padding: 0,
      borderRadius: borderRadius,
      transition: transitions.easeOut(),
      backgroundColor: backgroundColor,
      // That's the default value for a button but not a link
      textAlign: 'center',
    }
...

But when I check node_modules/material-ui, there is something wrong. Please have a look:
$ pwd
/Users/scarlex/Projects/testlibs/node_modules/material-ui

$ tail package.json
    "react-tap-event-plugin": "^1.0.0"
  },
  "readme": "ERROR: No README data found!",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/callemall/material-ui.git"
  },
  "scripts": {},
  "version": "0.15.1"
}

$ cat RaisedButton/RaisedButton.js
...
return {
    root: {
      display: 'inline-block',
      transition: _transitions2.default.easeOut()
    },
    button: {
      position: 'relative',
      minWidth: fullWidth ? '100%' : button.minWidth,
      height: buttonHeight,
      lineHeight: buttonHeight + 'px',
      width: '100%',
      padding: 0,
      borderRadius: borderRadius,
      transition: _transitions2.default.easeOut(),
      backgroundColor: backgroundColor,
      // That's the default value for a button but not a link
      textAlign: 'center'
    },
...

I have no idea why root.minWidth miss.

@scarletsky some commits are missing from the v0.15.1 release. We are going to address it with a v0.15.2 one. That should be done soon. You can track https://github.com/callemall/material-ui/pull/4572 to keep you up to date.

@oliviertassinari 😃  Oh, I see, thanks for your reply !


fix naming / revert modificationMark field about dirty or can retry

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Patch coverage has no change and project coverage change: -19.32 :warning:

Comparison is base (2e12760) 63.91% compared to head (d6defea) 44.60%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #644       +/-   ##
===========================================
- Coverage   63.91%   44.60%   -19.32%
===========================================
  Files         226      152       -74
  Lines       21794    15621     -6173
===========================================
- Hits        13930     6967     -6963
- Misses       7142     8335     +1193
+ Partials      722      319      -403

Flag
Coverage Δ

1.16.x
?

1.17.x
44.24% <ø> (?)

1.19.x
44.66% <ø> (-18.82%)
:arrow_down:

1.20.x
?

insecure
?

integration
?

macOS-latest
44.54% <ø> (ø)

secure
?

ubuntu-latest
44.59% <ø> (-19.29%)
:arrow_down:

unit
44.60% <ø> (-0.08%)
:arrow_down:

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.