Adding endpoint parameters to multipart form data

According to issue : #1137

          2 Warnings

:warning:
Any changes to library code should be reflected in the Changelog. Please consider adding a note there.

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues
Warnings

File
Line
Reason

MoyaProvider+Internal.swift
285
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #1139 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1139      +/-   ##
=========================================
- Coverage   76.51%   76.3%   -0.21%
=========================================
  Files          22      22
  Lines         728     730       +2
=========================================
  Hits          557     557
- Misses        171     173       +2

Impacted Files
Coverage Δ

Sources/Moya/MoyaProvider+Internal.swift
61.71% <0%> (-0.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7c8f6...10e8dd2. Read the comment docs.

Hey @syegin, just checking if everything is alright. Let me know if you need some help or you just don't have time to do it right now.

Is this merge? I have the same problem.

It is not yet merged, @codwam. I can take it from here (filling the tests & changelog), if @syegin won't in the near future.

@sunshinejr
Hope you add it soon🍺

@sunshinejr Could you help @syegin finish this PR and release it asap? We also have the same problem for several APIs.
At the moment, I have to manually create MultiFormData like PR in API Target.

@dangthaison91 It might be the case that this PR won't make it into 9.0.0 release, since we are in the middle of changing the parameters/encoding/Task in #1147. Basically the API will be more verbose and you would specify what to do based on a task.

This can be closed as #1147 is merged into 9.0.0-dev and will be into the new release soon. Thanks for your time, @syegin!


big data, small RAM

@kylechampley thanks for making such an amazing set of CT tools available! I've been playing around with LEAP for some of my research projects and I am very happy with the high-quality results.
But now I've been asked to reconstruct some data from our bench top CT system, and I am having trouble because the data is very large. Our detector is 4096^2 and we collected 1800 projections. For now, all I want to do is flat field the projection data and reconstruct with FBP, but my computer has only 64 GB of CPU RAM. I think FBP would require almost 400 GB of RAM.
Does LEAP have tools to process this data on my computer?

Hello.  Glad you find LEAP useful!
The short answer to your question is currently LEAP does not yet have the capability to handle this automatically, but I am actually working on a framework to handle this which should be ready in about 1-3 weeks.
You could of course, divide up the data yourself and feed chunks of it to LEAP.  See the following demo script for how to do this: d13_cropping_subchunking.py.
LEAP will automatically divide the data in small enough chunks for GPU processing, but LEAP requires you to have enough CPU memory to run any LEAP algorithm.  Removing CPU memory constraints requires one to process the data in chunks and save each chunk to disk.
Anyway, the new UI I am working on is here.  It is definitely NOT ready yet, but when ready all you'll have to do is specify the file names of the data you want to process and tell it the maximum amount of CPU memory that LEAP is allowed to use and it will process any LEAP algorithm in chunks and save results to disk.  I can let you know when this is ready.


Project rust-tsp proposal for consideration

Also adding Folkert de Vries, GitHub ID, forkertdev, to the contributor list.

Approved at the May 15, 2024 meeting


Response body to large

While using this for a server and when the response body is bigger than 4096 bytes, an error occurs.
Buffer too large for blocking-write-and-flush (expected at most 4096)
We need to flush the body contents as soon as it is at 4096 bytes, so a good idea is to chunk the output.
Suggestion is to change the handle_response  method in response.rs  to the following:
pub fn handle_response(response_out: ResponseOutparam, response: Response) {
    let outgoing_response = OutgoingResponse::new(response.headers.try_into().unwrap());
    outgoing_response
        .set_status_code(response.status_code)
        .unwrap();
    let outgoing_body = outgoing_response.body().unwrap();
    ResponseOutparam::set(response_out, Ok(outgoing_response));

    let body = response.body.bytes().unwrap();
    if !body.is_empty() {
        let out = outgoing_body.write().unwrap();
        let chunks = body.chunks(4096);
        for chunk in chunks {
            out.blocking_write_and_flush(chunk)
                .unwrap();
        }
    }

    OutgoingBody::finish(outgoing_body, None).unwrap();
}

Hi @usergood, thanks for your feedback, would you mind submitting a PR for this? And add a new test case for the large body, something like:

https://github.com/wacker-dev/waki/blob/main/test-programs/src/bin/server_query.rs
https://github.com/wacker-dev/waki/blob/main/waki/tests/all/server.rs#L52

Or I can do that in a few days.

I have released v0.4.1, please give it a try.


Fix/post publish

:tada: This PR is included in version 1.1.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update CHARTER.md

Issue #

changes typos
### Changes
-
  -
-
Flags

Related Issues

Issue #
Pull Request #

These changes aren't necessary.


currently not working

Still works for me. May be there is some additional trigger or you just didn't use it the right way. I know I should bypass AC the other way to completely disable it but currently it is what it is


[Question] How to do scaffold a module with doodba

Hello
How is the correct way to scaffold a module with doodba with copier?
Odoo scaffold is:
./odoo-bin scaffold your_module_name addons/
¿How can I achieve this?
Thank you

No idea, I never did that, and I doubt it's supported due to filesystem permissions.
I guess the best would be to have a copier template for odoo modules, something I've been missing for a long time. But that would be better as an OCA repo probably.
Closing, as this is not really an issue.


Deepspeed not killing process if script exits due to error?

I've been debugging my code to run with deepspeed, and I started noticing cuda out of memory errors. I check nvidia-smi and see that most of my GPU memory is still being used. I check my python processes and see a bunch of instances of my deepspeed scripts, I think for each attempt at running my script.
https://snipboard.io/R9DVu3.jpg
I had to stop each one directly using kill -9. After that, I saw that the GPUs memory was released.

It looks like just running one deepspeed script results in around 40 processes being created.

I have the same problem when I use deepspeed.init_inference. Did you solve the problem?

I have the same issue here for larger huggingface model (i.e. 30B) using the deepspeed init_inference.
but has no problem with smaller model (6.7B)

Hi @allanj - do you know what signal is being sent to your processes?  We just added support to clean up gracefully for SIGINT and SIGTERM.  Could you try with the latest DeepSpeed from source that should have those?

Merged PR that added SIGINT and SIGKILL support - since the original issue is old, closing this.  If someone with this issue can open a new issue, link this one, and provide repro steps, I'd love to get this fixed.


PropType warning when passing React.lazy in component Route prop

Version
"react-router-dom": "4.3.1"
Test Case
https://codesandbox.io/s/7kjzjow9r6
Steps to reproduce
Pass a React component to the component property on a Route which was loaded with React.lazy.
Expected Behavior
No propType warning.
Actual Behavior
Console:

Warning: Failed prop type: Invalid prop component of type object supplied to Route, expected function.

Notes
The code sandbox link about displays the described prop type warning in the console window.

See #6420.


Update the install doc with OSTree >= v2017.8

See original issue on GitLab
In GitLab by [Gitlab user @rafaelff] on Sep 6, 2017, 01:10
The documentation "doc/source/install.rst" states that

OSTree >= v2016.8 (preferrably >= v2017.6 -- see below)

but setup.py requires at least v2017.8
Please update the info in the documentation.

In GitLab by [Gitlab user @tristanvb] on Sep 6, 2017, 01:39
closed via commit 42294fe64e685f311a0799b49cfc1c1000a8fd7d

In GitLab by [Gitlab user @tristanvb] on Sep 9, 2017, 04:13
mentioned in commit 42294fe64e685f311a0799b49cfc1c1000a8fd7d


add terms for increased megakaryocyte number

Currently the increased megakaryocyte number (MP:0008254) term in MP is specific to bone marrow but in COVID-19 these cells are found in elevated numbers outside the bone marrow (PMID:32443177, PMID:32458044) particularly in the lungs. We should consider adding
increased pulmonary megakaryocyte number
increased alveolar megakaryocyte number

also look into a term for impaired megakaryocyte maturation (PMID: 32453877)
How does this relate to 'abnormal megakaryocyte differentiation' (MP:0000229)


explain non-element data in master-elements and suggestion for 4-octe…

…t level 1 ids
as discussed in this cellar thread https://mailarchive.ietf.org/arch/search/?email_list=cellar&q=test4.mkv+and+EBML+Elements+with+Unknown+Size

updated to …then all contained Elements must be valid at level 3

Thanks.


[main] Upgrade to latest dependencies

running for release -dprotaso
/cc knative-sandbox/api-core-wg-leads
/assign knative-sandbox/api-core-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg 768f44f...77555ea:
  > 77555ea upgrade to latest dependencies (# 2398)

/lgtm
/approve


Multi word search in NLTK

I am trying to implement a python grammar checker on python. I already have the part of the code that needs modification. What I need is the code to search for multiple words instead of two words.
Please tell me the parts that need modification or changing:
class WordReplacer(object):
def init(self, word_map):
self.word_map = word_map
    def replace(self, word):
        return self.word_map.get(word, word)

class CsvWordReplacer(WordReplacer):
def init(self, fname):
word_map = {}
for line in csv.reader(open(fname)):
word, syn = line
word_map[word] = syn
super(CsvWordReplacer, self).init(word_map)
class YamlWordReplacer(WordReplacer):
def init(self, fname):
word_map = yaml.load(open(fname))
super(YamlWordReplacer, self).init(word_map)
class AntonymReplacer(object):
def replace(self, word, pos=None):
antonyms = set()
for syn in wordnet.synset(word, pos=pos):
for lemma in syn.lemmas:
for antonym in lemma.antonyms():
antonyms.add(antonym.name)
if len(antonyms) == 1:
return antonyms.pop()
        else:
            return None

    def replace_negations(self, sent):
        i, l = 0, len(sent)
        words = []
        while i < l:
            word = sent[i]
            if word == 'not' and i+1 < l:
                ant = self.replace(sent[i+1])
                if ant:
                    words.append(ant)
                    i += 2
                    continue
                words.append(word)
                i += 1
            return words

class AntonymWordReplacer(WordReplacer, AntonymReplacer):
pass

This is not an appropriate use of the NLTK issue tracker. Please consult the NLTK book, or other resources on regular expressions, for information about searching for multiple words.

Why are you so hateful stevenbirds? You have always answered my questions rudely.


[tflite] tflite file with single ADD op produces duplicated outputs

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Linux Ubuntu 16.04

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:

TensorFlow installed from (source or binary): binary

TensorFlow version (use command below): r1.13

Python version: 3.6

Bazel version (if compiling from source):

GCC/Compiler version (if compiling from source):

CUDA/cuDNN version:

GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
I have created .tflite with single ADD op. It has two inputs and one output.
When reading this .tflite with interpreter(e.g. tensorflow.lite.python)
import sys

import numpy as np

from tensorflow.lite.python import interpreter as interpreter_wrapper

interpreter = interpreter_wrapper.Interpreter(model_path=sys.argv[1])
interpreter.allocate_tensors()

input_details = interpreter.get_input_details()
output_details = interpreter.get_output_details()

print(input_details)
print(output_details)

[{'name': 'input0', 'index': 0, 'shape': array([2, 5], dtype=int32), 'dtype': <class 'numpy.float32'>, 'quantization': (0.0, 0)}, {'name': 'input1', 'index': 1, 'shape': array([2, 5], dtype=int32), 'dtype': <class 'numpy.float32'>, 'quantization': (0.0, 0)}]
[{'name': 'output0', 'index': 2, 'shape': array([2, 5], dtype=int32), 'dtype': <class 'numpy.float32'>, 'quantization': (0.0, 0)}, {'name': 'output0', 'index': 2, 'shape': array([2, 5], dtype=int32), 'dtype': <class 'numpy.float32'>, 'quantization': (0.0, 0)}]

Code using  C++ interpreter also reports duplicated outputs(2 2), even though outout of ADD(builtin code 0) shows one output.
Interpreter has 3 tensors and 1 nodes
Inputs: 0 1
Outputs: 2 2

Tensor   0 input0               kTfLiteFloat32  kTfLiteArenaRw         40 bytes ( 0.0 MB)  2 5
Tensor   1 input1               kTfLiteFloat32  kTfLiteArenaRw         40 bytes ( 0.0 MB)  2 5
Tensor   2 output0              kTfLiteFloat32  kTfLiteArenaRw         40 bytes ( 0.0 MB)  2 5

Node   0 Operator Builtin Code   0
  Inputs: 0 1
  Outputs: 2

Describe the expected behavior
get_output_details() returns unique list of outputs.
Code to reproduce the issue
Use attached .tflite file to reproduce the issue.
add.tflite.zip

If you load your .tflite model with Netron(https://lutzroeder.github.io/netron/), it will show exactly two outputs. I'm wondering how you build & convert this model. Could you share the code for the model and the command you used to convert the model?

@haozha111 I have created .tflite using python binding(generated from on r1.14 schema.fbs) with our own converter.
Here is a code snippet for serializing ADD op.
def SerializeOpAdd(serializer, x_id, y_id, output_id):

    opcode_id = serializer.RegisterBuiltinOpcode(
        tflite.BuiltinOperator.BuiltinOperator.ADD)

    # Inputs
    num_inputs = 2
    tflite.Operator.OperatorStartInputsVector(serializer.builder, num_inputs)
    serializer.builder.PrependInt32(y_id)
    serializer.builder.PrependInt32(x_id)
    inputs = serializer.builder.EndVector(num_inputs)

    # Outputs
    num_outputs = 1
    tflite.Operator.OperatorStartOutputsVector(serializer.builder, num_outputs)
    serializer.builder.PrependInt32(output_id)
    outputs = serializer.builder.EndVector(num_outputs)

    # Options
    activation_function = 0  # 'NONE'
    tflite.AddOptions.AddOptionsStart(serializer.builder)
    tflite.AddOptions.AddOptionsAddFusedActivationFunction(
        serializer.builder, activation_function)
    tf_options = tflite.AddOptions.AddOptionsEnd(serializer.builder)

    tflite.Operator.OperatorStart(serializer.builder)
    tflite.Operator.OperatorAddInputs(serializer.builder, inputs)
    tflite.Operator.OperatorAddOutputs(serializer.builder, outputs)
    tflite.Operator.OperatorAddBuiltinOptionsType(
        serializer.builder, tflite.BuiltinOptions.BuiltinOptions.AddOptions)
    tflite.Operator.OperatorAddBuiltinOptions(serializer.builder, tf_options)
    tflite.Operator.OperatorAddOpcodeIndex(serializer.builder, opcode_id)
    op = tflite.Operator.OperatorEnd(serializer.builder)

    serializer.operators.append(op)

    return op

Whole part of our converter is W.I.P. and difficult to cut out for creating minimal & reproducing the issue atm.

May I know why do you need to create a converter yourself and not using the TOCO? Given that the graph visualization of your model has two outputs, I wonder if it's a bug in your converter implementation?

@haozha111 Ah, it was a bug in my converter. Sorry for disturbing you.
FYI, there was a mismatch in writing out output vector in my serializer. And it looks tflite interpreter treat it as a valid .tflite file.
        # len(inputs) = 2, len(outputs) = 1
        # [Inputs]
        tflite.SubGraph.SubGraphStartInputsVector(self.builder, len(inputs))
        for i in reversed(inputs):
            self.builder.PrependInt32(i)
        tf_inputs = self.builder.EndVector(len(inputs))

        # [Outputs]
        tflite.SubGraph.SubGraphStartOutputsVector(self.builder, len(outputs))
        for o in reversed(outputs):
            self.builder.PrependInt32(o)
        tf_outputs = self.builder.EndVector(len(inputs))  # <-----


cmd/compile: [ssa] invalid instruction: 00027

I'm not sure if it's alright to report SSA bugs yet, however using go version devel +bc1fb32 2016-02-17 16:31:44 +0000 linux/amd64, I end up with : <autogenerated>:9: invalid instruction: 00027 ($GOPATH/src/github.com/OneOfOne/xxhash/native/xxhash32_native.go:112) ADDL    $-3688676312, AX
To reproduce:
➜ env GOPATH="/tmp/x" go get -x github.com/OneOfOne/xxhash
➜ env GOPATH="/tmp/x" go test github.com/OneOfOne/xxhash

Yes, please report bugs.  Thanks for this one.
19740 is an immediate fix, but I think we need something more generic here.  This will almost certainly happen for more than just ADD.
@tzneal

Somehow gopherbot didn't close the issue.  Todd's change is in, this should be fixed.


Add Page#has_featured_video?

Coverage remained the same at 100.0% when pulling af399a63c03739e7e751d4b230c6383e2dbb7807 on featured_video into 1bff3e964e40970e9686a80f7d035d68a52b944b on master.

@kangkyu 🚢


[signing] Create a keyset definition for handling keys

Description
Introduction
Currently, we have a number of private keys present in the codebase for the earlgrey product under //sw/device/silicon_creator/rom/keys/fake.  These keys are used by the sign_bin rule (//rules:opentitan.bzl`) to apply RSA signatures to firmware images.
Soon, we will need to generate the real earlgrey product keys in an HSM and import the public components of those keys into the codebase.  Part of the key generation process will be to initialize personal security tokens (e.g. Nitrokey or Yubikey) that hold the less privileged DEV and TEST keys, thus allowing developers to unilaterally sign firmware for DEV and TEST devices.  Such signing will be required in order to run test code on sample silicon (ie: the so-called "fake keys" will no longer work).
In order to facilitate automated build and test flows, we'll need to have a better management strategy for the keys than "a bunch of files on disk".  I'm assuming that we'll want building test code for silicon to be no more complicated than "insert your signing token into the usb port and type bazel build //the/target.
Background
Keys stored in an HSM are accessed and wielded via their HSM label.  Signing a firmware image generally consists of 4 steps:

Preparation: the software binary is built and the manifest header is updated with various information, including the public modulus of the signing key.  This is called the "pre-signed binary".
Creation of the digest: after the pre-signed binary is prepared, we compute a SHA256 digest over the signed region of the payload.
Signing: the digest is signed by an RSA private key.
Finalization: the signature is injected into the manifest header of the pre-signed binary, yielding the signed binary.

Proposal
In order to make this process easy, we should always refer to keys by a nickname.  The nickname refers to the public component of the key during the preparation step and refers to the HSM resource during the signing step.  I'd suggest that the nickname should be the same as the HSM label; I think the existing key names like test_key_0 (etc) are perfectly good nicknames.
We should group these keys together into a keyset that encapsulates the properties of a group of keys together.  I've been thinking about something like this:
keyset(
    name = "fake_keys",
    keys = {
        # Mapping of key files to nicknames.
        "test_key_0_rsa_3072_exp_f4.der": "test_key_0",
        ...
    },
    # Locations are either "local" (private keys on disk) or "offline" (private keys in an hsm)
    location = "local",
    # Which tool is used to perform signing with this keyset: opentitantool or hsmtool.
    tool = "opentitantool",
)

When we want to sign something, we'll give the keyset name and key nickname to the sign_bin rule.  To maintain compatibility with existing bazel infrastructure, the sign_bin rule will also accept a private key file and key nickname.
The opentitan_flash_binary rule currently accepts a dict of key nicknames to key files.  This can easily be changed to a dict of key nicnames to keyset names.
The main advantage of migrating to using keysets is that the keyset carries with it the tooling information to perform the signing.  The signing rules can use that information to invoke the correct tool to perform the signing operation (ie: opentitantool for fake keys, hsmtool for keys held in HSMs or tokens).
To discuss

[ ] What should go in a keyset?
All of the intermediate artifacts produced by the signing process have filenames that incorporate the key nickname.
[ ] What sort of naming scheme should we apply to key nicknames?
[ ] Should the nickname distinguish between fake and real keys? (ie: fake_test_key_0 vs test_key_0?)
[ ] Should we include the product name (e.g. earlgrey) into the filename transformation?

This is great.
Does this proposal need to consider access controls to a given keyset as well, or is that orthogonal (or somehow implied by location==offline)?
At the risk of stating something that is probably really obvious to everyone - we want signing anything with PROD keys to be a significant choice and not one that can easily be triggered by a typo / wrong-argument (or likely automated at all, in all honesty).
DEV and TEST keys I am far less concerned about, though we might have to have some access controls there ultimately as well.

Access control to key material is implied by location = "offline".

In order to sign with the real TEST or DEV keys, the user will need to be in possession of a secure token that holds the private key (ie: a Nitrokey or Yubikey type device).
In order to sign with the PROD key, signing artifacts will have to be taken offline to a secure facility.  A K-of-N quorum will have to present credentials to an HSM to authorize signing.  Signatures will then be brought back to the codebase and integrated into the binary artifacts.

Any user can attempt to sign with offline keys, but unless that user has a token and the unlock credentials for that token, such signing is impossible -- they will only ever get as far as generating the pre-signing artifacts.

Thanks for the extra info.  That all sounds like best practices to me.

@cfrantz anything to update here?

#19072 was a first attempt at addressing this, but I was not confident about merging it.
I'd like to address this as part of the current build rules refactoring and SiVal enablement.

Ok triaging into SV0. Please move to another SV milestone as appropriate.


chef-workstation: Add version 22.4.861

Relates to Excavator checkver failing for chefdk package: https://github.com/ScoopInstaller/Extras/runs/5954605801?check_suite_focus=true#step:3:210

This is due to ChefDK reaching End of Life - see https://www.chef.io/downloads/tools/chefdk

That page says to upgrade to Chef Workstation, which this PR adds. I will make a PR to add a note to chefdk afterwards.

Very similar manifest to chefdk, adds bin directory to path as that is where the cli programs are stored - plus a shortcut to the gui program

[x] I have read the Contributing Guide.

/verify


undefined method `write_inheritable_hash' for ActiveRecord::Base:Class (NoMethodError)

For Rails 3.2 write_inheritable_hash is Depricated change with
class_attribute :attribute_name
self.attribute_name = value

Hi bhushangahire, unfortunately this plugin is deprecated. Perhaps you can find a working fork?


mv geo-related plots with PyPlot dependency to separate package

Consider a GGplot.jl package for use with TMI and ECCOtour. Not to be confused with ggplot.R.

See https://github.com/ggebbie/GGplot.jl


Test 5.5 say my container have mounted /lib /etc ... from host but this is not true

if i inspect my running web container i got this:
"Volumes": {
                "/db": {},
                "/etc/ssh": {},
                "/home/user/.pycharm_helpers": {},
                "/home/user/files": {},
                "/home/user/app": {}
            },

but if i run the benchtests i get the information that my containers have mounted sensitive dirs from host:
[WARN] 5.5  - Do not mount sensitive host system directories on containers
[WARN]      * Sensitive directory /etc mounted in: web_1
[WARN]      * Sensitive directory /lib mounted in: web_1
[WARN]      * Sensitive directory /proc mounted in: web_1

If i use the recommended audit command from CIS i got this error:
Template parsing error: template: :1: unclosed action
if i run this "docker inspect --format '{{ .VolumesRW }}' "web_1" 2>/dev/null 1>&2;" command from the tests i get the error:
Template parsing error: template: :1:3: executing "" at <.VolumesRW>: map has no entry for key "VolumesRW"
I don't unterstand why the tests says that /lib and /proc are mounted. i run the tests on a ubuntu:trusty system.
Maybe i make something wrong?!
Thanks

Hi again @immae1,
The .VolumesRW error is depending on the version you're using. I don't get /proc but /lib is a false positivt due to  /var/lib/docker/volumes/.
Could you paste your docker inspect --format '{{ .VolumesRW }}' web_1 output?
$ docker inspect --format '{{ .VolumesRW }}' test_FAIL_5_5
Template parsing error: template: :1:3: executing "" at <.VolumesRW>: map has no entry for key "VolumesRW"
$ docker inspect --format '{{ .Mounts }}' test_FAIL_5_5
[{bind  /tmp /tmp/htmp   true } {bind  /etc /tmp/etc   true } {volume 7ab5747b595e1e0ea0690d6fb0edb2493c3096ea4dfefd0bc769702e8b263515 /var/lib/docker/volumes/7ab5747b595e1e0ea0690d6fb0edb2493c3096ea4dfefd0bc769702e8b263515/_data /etc/ssh local  true }]

HI @konstruktoid,
sorry for the late response.
root@vagrant-ubuntu-trusty-64:~/docker-bench-security# docker inspect --format '{{ .VolumesRW }}' web_1

Template parsing error: template: :1:3: executing "" at <.VolumesRW>: map has no entry for key "VolumesRW"

The /lib false positive is due to the fact /var/lib/ is in there, but does the script warn about /proc when you're running docker inspect --format '{{ .Mounts }}' app_web_1?

The the skript does warn about:
[WARN]      * Sensitive directory /etc mounted in: app_web_1
[WARN]      * Sensitive directory /lib mounted in: app_web_1
[WARN]      * Sensitive directory /proc mounted in: app_web_1
if i run your command i got:
root@vagrant-ubuntu-trusty-64:/tmp/docker-bench-security# docker inspect --format '{{ .Mounts }}' app_web_1
[
{volume app_files /var/lib/docker/231072.231072/volumes/app_files/_data /home/user/files local rw true }
{volume app_db /var/lib/docker/231072.231072/volumes/app_db/_data /db local rw true }
{volume app_ssh-config /var/lib/docker/231072.231072/volumes/app_ssh-config/_data /etc/ssh local rw true }
{volume app_helpers /var/lib/docker/231072.231072/volumes/app_helpers/_data /home/user/.pycharm_helpers local rw true }
 {bind  /home/vagrant/appdir /home/user/app  rw true }
 ]

i think /proc and /etc is wrong - i don't see that are mountes in container.
I run this this project in a vagrant vm - maybe this is the problem?
Greetings

Sorry for the late reply @immae1, and yes the test should only check the first part of the path.

@immae1 could you try with https://github.com/docker/docker-bench-security/pull/216?

@konstruktoid
after i fetched your pull request i run the test:
[PASS] 5.5  - Do not mount sensitive host system directories on containers
but if i test to mount a sensitive volume with this:
$ docker run -d -P -v /:/etc/test ubuntu:trusty tail -f /dev/null
the test output is  [PASS] 5.5  - Do not mount sensitive host system directories on containers
i think there is bug in your pull request or i make a mistake to test it?
Greetings

#216 updated


docs: added blog about website migration

Description
Wrote blog on the "Migration of AsyncAPI Website to Next.js v14 and TypeScript"

/rtm


index_m.html not found

Hello foxdriver76,
thanks for the development of the ocpp adaper !
Just wanted to test the adapter, unfortunately I only get the output "index_m.html not found" in the configuration.
Am I doing something wrong ? I have installed the adapter normally via npm.
Thanks

!

admin version?

Admin 5.1.25

Then maybe you just need to upload, because it's not installed via iob. So ìob upload ocpp should fix it

No, I have also completely reinstalled the adapter and tried "Upload". Still "not found
In the log is not much to see, the adapter itself seems to run

!

Yes, adapter UI is based on JSON config which should be supported by your admin version afaik. Only thing which is configurable in the UI is the port of the server, so yes it runs on deafult port 9220.

Thanks for the answer.
But I think I just do not understand the connection....
I can not configure anything in the adapter and when I call port 9220 I get now only "Update Required".
I guess that I am just the layer8 problem ! :-)

if you have an OCPP compatible wallbox, then you have to specify your ioBroker host ip and the selected port as OCPP server

Thanks for the info ! I will try again tonight !
Super project !!!


Download Links broken

After trying to figure out why the links are broken, I stumbled upon a newer version than what is listed in this doc: https://support.microsoft.com/en-us/help/4469694/hotfixrolluppackagebuild452860isavailableformicrosoftidentitymanager20.  Hope this helps someone trying to get an actual hotfix.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 84d8b69a-c572-fff1-6559-632ded8f9060
Version Independent ID: 0cbcbb62-a0ee-de8f-8d1f-497a919d30ea
Content: Identity Manager version history
Content Source: MIMDocs/reference/version-history.md
Product: microsoft-identity-manager
GitHub Login: @billmath
Microsoft Alias: billmath

download link/s are still broken 👎

Updated.


reordering models; only show active

Currently you see all models in the little "configure models" popup, even if 90% of them are deactivated, making it hard to know which ones are even relevant and with a lot of models loaded it becomes also tedious to find ones that are even active in the "models" view. Thanks!

should be already the case here, try refreshing the webui!


amazon .node file blocked by corporate firewall

It seems that the .node file is hosted on amazonaws and I get a ECONNRESET error when trying "npm install -g gulp-sass". This is because I'm behind a corporate firewall at the moment. I have access (via proxy) to github and npm registry but aws isn't allowed . I appreciate that this is a "me" problem. However, other npm packages install fine. I'm wondering if there's an alternate hosting option?

The binaries are downloaded from the GitHub release and are hosted on https://github.com.
For people with restrictive firewalls you can configure a proxy via the standard HTTP_PROXY and HTTPS_PROXY environment variables, or via the npm config CLI.
Alternative the node-sass installer has a couple of configuration options for self-hosting the binaries.

Great, thanks. I'll give the self-hosting a go. Just FYI, GitHub uses AWS as the end point store for the binaries. So that's why even though I have Github whitelisted, because AWS isn't, the install fails.


JS completions are... too complete

Testing https://github.com/Microsoft/vscode/issues/12598
Two files server.js and a.js. server.js has no references to a.js, but foo nevertheless appears in the completion list.

May be related to #12849

This issue was moved to Microsoft/TypeScript#11231


RUMM-2931 prevent reporting ANR when app is in background

What does this PR do?
Fixes #1067
This PR prevents reporting false positive ANRs when the application is in background.
Motivation
In some cases (#1067) the host application is in background and the SDK detekts multiple SDKs that are not actually perceived by the end user.

Codecov Report

Merging #1239 (9d3221b) into develop (a54ed7a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1239      +/-   ##
===========================================
+ Coverage    82.50%   82.53%   +0.04%
===========================================
  Files          353      353
  Lines        11832    11833       +1
  Branches      2015     2016       +1
===========================================
+ Hits          9761     9766       +5
+ Misses        1461     1460       -1
+ Partials       610      607       -3

Impacted Files
Coverage Δ

...d/rum/internal/domain/scope/RumViewManagerScope.kt
98.17% <100.00%> (+0.02%)
:arrow_up:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
92.82% <0.00%> (-0.55%)
:arrow_down:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
87.19% <0.00%> (-0.49%)
:arrow_down:

...in/com/datadog/android/log/internal/LogsFeature.kt
88.71% <0.00%> (ø)

...android/log/internal/logger/TelemetryLogHandler.kt
85.71% <0.00%> (ø)

...android/v2/core/internal/DatadogContextProvider.kt
83.82% <0.00%> (ø)

.../kotlin/com/datadog/android/v2/core/DatadogCore.kt
90.32% <0.00%> (+0.46%)
:arrow_up:

...android/log/internal/domain/DatadogLogGenerator.kt
97.39% <0.00%> (+0.65%)
:arrow_up:

...ndroid/telemetry/internal/TelemetryEventHandler.kt
73.77% <0.00%> (+1.64%)
:arrow_up:

...d/v2/core/internal/storage/FileEventBatchWriter.kt
97.62% <0.00%> (+2.38%)
:arrow_up:

... and 1 more


Correcting the PR templates that are not showing up when create the PR

@k4yt3x could you help me with this? I couldn't make it work.


Quicker update of audio progress on delegate

Hi
I want to update audio progress when I'm playing sound. Now when I'm updating via the delegate
it works and updates it with rate of 0.5 second which is not very smoothly
can you make a config property on player object so I could modify it easily
see this
https://github.com/delannoyk/AudioPlayer/blob/master/AudioPlayer/AudioPlayer/event/PlayerEventProducer.swift#L138

@vaderdan I think it's kind of smooth enough. How much would you want? I'm not really willing to add this property as it would require more work around - the already complicated - state (remove observer and maybe recreate a new one - with everything that implies).

Closing this.
Re-open if you really feel like 0.5 is not enough.


Button font

Some buttons have slightly different font. From memory specifically submit buttons.

this has been addressed 😁


bug ValueTag: Object.value resolved as undefined

bug ValueTag: an Object with an attribute value, gets resolved as undefined after a DomeChange
fix in websocket.js findThroughObjectPath

please check changes in JS before merging ;-)

LGTM. Added key check, since the same issues would happen there.


Properly set ServerLimit on 2.4

ServerLimit was not set for apache 2.4. I assume that was an omission, but perhaps not. We have hosts that need > 256 MaxRequestWorkers, which is the apache compile time default for ServerLimit.

Thanks!


Eloquent OrderBy() not working after call to eloquence search method

When i used the search() method ordinarily, it works fine based on the field $searchableColumns.
But when i combine it with eloquent method orderBy('title','asc') ....the result is not sorted by the column i want which is not part of the fields i am using to search.
// result is not sorted by title. $product =  $product->search($keywords)->orderBy('title','desc')->get();

That is happening because Eloquence assigns weighting inside the SQL query and the uses 'ORDER BY' in order to sort the results using the SQL server. When you then add your own "->orderBy()", yours get appended after the weighting.
I have this issue in some contexts (sortable columns in a table interface). This is crude, but you can scrub the orderBy out of the query after Eloquence adds it to the stack but before the SQL is generated.

       $query= product->search($keywords);

        $subquery = $query->getQuery();
        $subquery->orders = [];
        $query->setQuery($subquery);
        $product = $query->orderBy('title', 'desc')->get();

Keep in mind that Eloquence is running much more complex SQL queries for the sake of weighted results, so they take longer to execute, then the above trick nullifies the value of this. So, as is the case for me, this might work when you want the first result in a tabulated view of data produced by a search query to be presented on a weighted basis, but then allow the user to apply a column sort and refresh without having two separate query methods in your code.

Agree with SirLamer - sorting by anything else but relevance score ruins the idea of whole searchable feature.


alphabetize, indent, clarify

I thought there was a bug in #420 but perhaps there wasn't:

for clarity I changed the !var to var === 0 because as far as I can tell is the only scenario that can happen there 😅

Besides that:

I've alphabetized certain sections for ease of reference
I added indentation where appropriate
I removed InjectionToken as it is not getting used anywhere in the code 🤔

Biggest change is that README.md has been massively updated:

Cleaner layout for the API table

sorted alphabetically
moved default value to Type column (for clarity)
moved long functions into descriptions (to keep middle column thinner and more-readable)

emphasize key words for reading ease
break up large paragraphs into meaningful sections
show some <text> that got hidden because markdown hides things that are surrounded by < >
switched tabs to spaces (else indentation is rendered with too much white space)
etc

I was careful when editing the code, but please confirm I broke nothing just in case  😅
I'm happy to undo / update / change my code as recommended 🤝
Perhaps it would be better to undo the changes to all the code and simply make this PR about Readme 🤷♂

Thanks for submitting this!
The only thing I'd like to revert is this:
if (!animationMilliseconds) {

if (animationMilliseconds === 0) {

It's just a personal preference. The code should function identically (unless animationMilliseconds === null, but that's not really a valid value)

Glad all other changes are beneficial 😁
I hope you don't mind the comment I added to the line; though I'm happy to remove it 👌


Incompatible types error with increased global precision

Hello,
Thank you for this amazing library. It's been a while I am using this package for our project. I have started facing the following issue:
'''
/home/dubey/anaconda3/envs/jaxenv_qiskit/lib/python3.11/site-packages/jax/_src/ops/scatter.py:93: FutureWarning: scatter inputs have incompatible types: cannot safely cast value from dtype=int64 to dtype=int32. In future JAX releases this will result in an error.
warnings.warn("scatter inputs have incompatible types: cannot safely cast "
'''
I want increased precision for my experiments and so I set the following global variable as:
'''
jax.config.update("jax_enable_x64", True)
'''
Unfortunately, I have tracked down the bug to
gumbel_mu_zero_policy function
and within these functions the

action_selection package - Line 140 explicitly sets the dtype to "jnp.int32" which I believe creates the above issue.
search package - Line 172, 288, 364, 367 and 375 also explicitly set the dtype to "int32".

I am not sure how to resolve this issue but kindly let me know if this does not make sense.
Update: I tried keeping "int32" everywhere but as expected that does not make sense since when you specify the global config to x64 it does change precisions of everything.

Thanks.
With jax_enable_x64, the argmax output was int64. I changed the code to use the expected int32.
The implementation is not tested jax_enable_x64. Check that your results are sensible.

Hello @fidlej ,
Thanks for the solution. With the corresponding changes it works without any warnings or errors. Although I still have to check if the results with tax_enable_x64 are sensible. I think we can close the issue with this.
Thanks again.


Fix for setting protected attributes on NetCDF variable objects

I hit an issue trying to save cubes with variable attributes including 'name', which is related (but not the same as #1167) when using netcdf4>=1.2. This is a test which reproduces the problem and an associated fix.

Seems reasonable enough. If you want to make a head start on the CLA it may avoid delays later.
There is a test fail on coding standards, you just need to change the year in the copyright statement of the test file from 2015 to 2016. The other fails look to be timeouts from the always irritating regrid tests.

I've submitted the CLA just waiting for a response now :-)

Thanks, that's what I get for editing it in GitHub!

I've never dared try that option, it looks super convenient for small changes.

Thanks @duncanwp, can you squash this into a single commit please? After that I'm happy to merge once the CLA is confirmed by the MO.

Great, I'm pretty sure you can squash-on-merge in Github though? I would do it locally but I'm not on my work machine and don't have it checked out locally (hence editing in Github!).

Squash on merge is disabled for this repository.

Just noticed this work is done on your master branch. Not a problem here, but in future it may be worth working on a feature branch, particularly if you have a few things on the go at any one time.

Yeah, I should get into the habbit of that - I didn't think it was really necassary for this though.
Why is squashing on merge disabled out of interest?

Not sure, @rhattersley will be able to provide the answer to your question.

CLA approval
https://github.com/SciTools/scitools.org.uk/pull/131

Why is squashing on merge disabled out of interest?

i think this has not been turned on on this repository so far.  I don't have a good reason why not and I would support implementing this feature
@bjlittle @pelson
would you agree?
do you think this would reduce the PR noise?

Would anyone more familiar with the netcdf backend like to take a look at this before merge? @pp-mo perhaps?

i'm having a look into this, i'll try to report back tomorrow on my conclusions

Thanks for the mention @ajdawson !
It makes sense to me.

i agree, this looks like a sensible change
many thanks @duncanwp


No touch feedback on interactive elements

Hey, cool library you have here. I tried Hermes as a demo, and it seems like none of the interactive UI elements (buttons, etc) have touch feedback. It'd be great to add that.

1+ for touch feedback

Nice idea, I'm working on it :)

Apologies if I miscommunicated, but by touch feedback I meant touch ripples (for API 21+) and highlights (for < API 20).

I can send a pull request if you want me to, just let me know :)

Woops, now you have both features :P

Great, thanks! I hope the vibration doesn't eat battery, and besides, it's not standard behaviour on Android. You may want to re-consider that :)


v1.12 backports 2022-07-05

[ ] #20286 -- images: Bump Hubble CLI to v0.10.0 (@gandro)
[x] #20357 -- Update values.yaml.tmpl (@michi-covalent)
[ ] #20316 -- labels/cidr: use netip types to improve GetCIDRLabels and IPStringToLabel performace (@tklauser)
[ ] #20264 -- test: Fix make target for k8s tests (@ysksuzuki)
[ ] #20304 -- Fix config map options validation (@pippolo84)

Trivial conflict on first commit, solved by regenerating install/kubernetes/cilium/README.md.

[x] #20308 -- Add support for disabling ENI PD at node level (@hemanthmalla)

Conflict: Jumping CustomResourceDefinitionSchemaVersion from 1.25.3 instead of 1.25.4 in pkg/k8s/apis/cilium.io/v2/register.go.

[ ] #20132 -- test/runtime: remove disabled memcache test (@tklauser)

Trivial conflict: CODEOWNERS, trimmed for 1.12 release, is left untouched.

[ ] #19932 -- ipsec: fix stale keys reclaim logic (@jibi)
[ ] #20361 --  fix identity gc  to return correct  max/min id (@dkhachyan)
[ ] #20360 -- ci: pick up cilium-cli v0.11.10 for master, v1.11 and v1.12 workflows (@tklauser)

Most workflow files have been removed in preparation of the 1.12 release, and were therefore skipped on this branch.

[ ] #20371 -- go.mod, vendor: update cloud provider SDK Go modules for July 2022 (@tklauser)
[ ] #20241 -- docs: Add more envoy supported extensions (@sayboras)
[ ] #20373 -- Restore patch in ciliumnetworkpolicies/status ClusterRole (@pippolo84)
[ ] #20328 -- daemon: Deprecate KPR=probe (@brb)
[ ] #20379 -- bpf: Provision HostPort also for case of Maglev (@borkmann)
[x] #20245 -- bpf: Don't emit policy verdict post-L7 (@joestringer)
[ ] #20149 -- api: re-sync bpf drop reasons (@julianwiedmann)
[x] #20269 -- daemon, option: Fix MTU when egress gateway is used (@pchaigno)
[ ] #20392 -- nodediscovery: make LocalNode return a deep copy of localNode (@jibi)
[ ] #20282 -- daemon, option: Fix vlan bpf bypass ids loading (@pippolo84)
[ ] #20388 -- ctmap: Do not use nil locks (@jrajahalme)
[x] #20399 -- docs: Improve policy troubleshooting guide (@joestringer)

Once this PR is merged, you can update the PR labels via:
$ for pr in 20286 20357 20316 20264 20304 20308 20132 19932 20361 20360 20371 20241 20373 20328 20379 20245 20149 20269 20392 20282 20388 20399; do contrib/backporting/set-labels.py $pr done 1.12; done

or with
$ make add-label BRANCH=v1.12 ISSUES=20286,20357,20316,20264,20304,20308,20132,19932,20361,20360,20371,20241,20373,20328,20379,20245,20149,20269,20392,20282,20388,20399

/test-backport-1.12

/test-backport-1.12

/test-1.20-4.9

/test-gke

This seems to have hit https://github.com/cilium/cilium/issues/18595.

/ci-aks-1.12

GKE hitting known flakes. AKS workflow currently broken, though no Azure-related changes were included. Another round of backports needs to be started, merging.


Add Implementation Guide Da Vinci Payer Data exchange 0.1.8 #1488 and  Add Implementation Guide Da Vinci Health Record Exchange (HRex) 0.2.0 - STU R1 - 2nd ballot #1490 #1491

Signed-off-by: Paul Bastide<EMAIL_ADDRESS>

I'm wondering if we should change our packaging strategy so that we only include published IGs in the server's userlib directory (by default).
Users could still add additional IGs by grabbing our released jars and dropping them in user lib.
Or maybe we shouldn't include any by default?
Thoughts?

I'm wondering if we should change our packaging strategy so that we only include published IGs in the server's userlib directory (by default).
Users could still add additional IGs by grabbing our released jars and dropping them in user lib.
Or maybe we shouldn't include any by default?
Thoughts?

Good question, I think we should include it as I think PDEX is coming soon. HREX I'm not sure about.
Maybe we add a comment in the release notes?


computedFrom rules do not get revalidated if a computation property changes

Take the following code snippet:
...
.ensure('password')
    .isNotEmpty()
    .hasLengthBetween(8, 16)
    .isStrongPassword()
.ensure('passwordConfirm', (config) => { config.computedFrom(['password']) })
    .isEqualTo(() => { return this.password }, 'the entered password');

Case 1)
Writing in the password field turns passwordConfirm to success.
Wirting in passwordConfirm then turns it to warning until it is equal to password (success then).
Case 2)
Writing in the passwordConfirm field first turns it to warning.
Writing in password then leaves passwordConfirm in warning, even if both are equal.
Case 3)
Writing in password field. Then typhing in passwordConfirm. Both are success now.
Now, change password again (e.g. add two digits). passwordConfirm is still success.

Hmmm, I need to see what's going on.  We have tests on this, so it's either a timing issue or I've made some weird assumptions in the test. Will definitely check this weekend!
Thank you for reportin!

Currently computedFrom is not working in a lot of cases, which makes it unusable. I fixed it in the project I'm working on as in PR #150.
This change has worked very well for us, in several cases including some tricky ones.

This seems still not working in 0.6.0
Any progress on this issue?

@paranoxx My PR #150 has not been merged yet, and probably won't be any time soon because of the ongoing refactoring of this library.
If you need validation with computedFrom in your project today, your best option is to apply the PR yourself.

Patching this plugin by my own and find a way to share it with my team is not a way we want to go.
If aurelia is not able to patch it, i will switch do another validation library or write my own.

@paranoxx feel free to do as you'd like!
But I can't help but smile at the irony of your post...
On one hand, you already have a github account... Forking this repo is just one click away. Applying the PR is just a few more clicks. Then you can point (bower / jspm / whatever package manager you use) to your fork instead of this feed. All of this would take you 10 minutes to be ready to easily share with your team.
On the other hand you suggest that you want to "write your own". Sure... you'll spend at least several days for something that nobody else but you uses / maintains.
As I said -- your choice!

You already did a PR and nobody cares.

People care. However, we are right in the middle of releasing the Beta 1 of the core framework. We have also announced that major re-factorings on being worked on for this library. So, you will have to be patient while we work through a major release cycle and a big refactoring of this library.

@paranoxx I know for sure that @EisenbergEffect does care.
But you should know that aurelia-validation is not even beta at this point. I can tell you from my own experience that this package is still very rough and not mature. That's why it's undergoing a deep refactoring.
When using such "alpha" libraries there are caveats that you need to accept, and be ready to do some tweaking.

Thanks for submitting this / commenting on this.  At this time we are closing this because we have completely re-written and are deprecating the previous feature set.  If you feel this should be re-opened please feel free to review this blog post and submit either again on this repository, or on the new validatejs bridge repository
Thanks again!


bump Python baseline 3.7 -> 3.9

Debian stable (bullseye), latest macOS (12), and PyPy all support Python 3.9.
Bumping this will help with the soon-to-arrive type hinting efforts (#222) and reduce the number of compute minutes we use on the free-tier for GitHub Actions.

Codecov Report
Base: 76.48% // Head: 76.42% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (d7c1c09) compared to base (6c2e869).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   76.48%   76.42%   -0.06%
==========================================
  Files          19       19
  Lines        1297     1294       -3
  Branches      252      252
==========================================
- Hits          992      989       -3
  Misses        245      245
  Partials       60       60

Impacted Files
Coverage Δ

setup.py
0.00% <ø> (ø)

onyo/commands/history.py
93.75% <100.00%> (-0.37%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


camera IMOU IPC-S42F and  IPC-A42-B does not work HA

Hello, I have two cameras installed imou models: IPC-A42-B and IPC-S42F of 4mpx, I have managed to make them work by RSTP through VLC, but in HA they do not work.
I have tried by onvif and dahua integration, but none works.
Can you help me to integrate them in HA??
Thanks a lot

I have been able to prove that the two cameras work through this protocol through VLC, but in HA they do not work through onvif and neither through dahua nor directly in configuration.yaml,
in configuration.yaml : not work
camera:

platform: ffmpeg
input: rtsp://admin:xxx@ipxxx:554/cam/realmonitor?channel=1&subtype=1

in VLC: Work
rtsp://admin:xxx@ipxxx:554/cam/realmonitor?channel=1&subtype=1
In case it helps
Thank you

please check issue no 6, for all related problems to imou cameras
https://github.com/rroller/dahua/issues/6


Add the ability to use response wrapping for AppRole secretId responses

Related to #164.
This is a first shot, let me know what you think.
Sample use-case

At deployment time, a configuration management tool / deployment tool generates a wrapped secret id response using something like vault write -wrap-ttl=10m -f auth/approle/role/some_role/secret-id.
The tool injects (environment variable, file, whatever) the unwrapping token in the application
The application hits sys/wrapping/unwrap with the unwrapping token to retrieve its AppRole secret ID. If the call fails, the application would typically raise an alert because it can mean two things:

the application took to much time to start, and the TTL of the unwrapping token expired
the unwrapping token was compromised and used by a malicious party to retrieve information it shouldn't have had access to

@christophetd Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@christophetd Thank you for signing the Contributor License Agreement!

I'm unsure whether this is the appropriate branch for Spring Vault 2.0.X, but I didn't find a 2.0.X branch-

One of the Travis builds seems to have errored but the other pass correctly. Could someone trigger a new build?

Thanks for your pull request. master is the appropriate branch. Initially, we wanted to introduce dedicated types for SecretId and RoleId to specify whether these are to be obtained, wrapped or provided. Introducing additional tokens increases the complexity without actually expressing how to properly configure the individual components of AppRole authentication.
I'd take your pull request from here and adjust it to properly encapsulate the various configuration aspects.

Great job on the pull request. That's merged and polished now.


Update verify-first-party-apps-sign-in.md

Added AEM-DualAuth \ 69893ee3-dd10-4b1c-832d-4870354be3d8 after customer support case on this 1st party app

Learn Build status updates of commit 5c7ba95:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/azure/active-directory/verify-first-party-apps-sign-in.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Setup GitHub Action for building website

Website can be build in seperate branch for GitHub Pages

done with #15


protobuf equals comparisons

the equals method on protobuf message classes seemed like a useful feature, but in practice it's been the root of subtle and complex issues, due to the presence of default/optional/nullish/empty values and the innate complexities of deep object comparison.
there are 29 files, excluding tests, that presently call equals. each of these calls should be checked for correctness. https://github.com/search?q=repo%3Apenumbra-zone%2Fweb+".equals("+path%3A*.ts*+-path%3A*.test.*&type=code
possibly we should restrict use of equals in favor of specific utility methods with documented reasoning.
now that message types are using local codegen, it may be possible to implement custom equals methods on selected classes.
just glancing over, many of these are AssetId comparisons, which are known to be problematic.
high priority
in idb

[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/storage/src/indexed-db/index.ts#L479
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/storage/src/indexed-db/index.ts#L518
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/storage/src/indexed-db/index.ts#L567
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/storage/src/indexed-db/index.ts#L568
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/storage/src/indexed-db/index.ts#L777

in block processor

[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/query/src/block-processor.ts#L372
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/query/src/block-processor.ts#L449
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/query/src/block-processor.ts#L457

in query

[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/query/src/helpers/price-indexer.ts#L73
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/query/src/helpers/price-indexer.ts#L83

in services

[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/notes.ts#L16
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/notes.ts#L19
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/swap-by-commitment.ts#L24
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/util/asset-priority-score.ts#L27
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/fees.ts#L122
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/note-by-commitment.ts#L24
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/nullifier-status.ts#L50
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/nullifier-status.ts#L54
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/broadcast-transaction.ts#L22
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/broadcast-transaction.ts#L43
[ ] https://github.com/penumbra-zone/web/blob/b732bc580e16d827e55d25a64b1d5d05d85b93a0/packages/services/src/view-service/transaction-planner/assert-swap-assets-are-not-the-same.ts#L12

might relate to #1622


Licence URL "autopopulation" is American-centric

https://preview.nuget.org/packages/Fred/0.1.0/ has an automatically populated "License Info" field. That's great... except that it gets the URL wrong. It puts "https://github.com/frankshearar/Fred/blob/master/LICENSE" when the correct URL is "https://github.com/frankshearar/Fred/blob/master/LICENCE". (Note the "C", because this is a noun. I'm not an American English speaker, and this is the correct spelling for my English dialect.)
There is no way to simply correct the error myself.
Perhaps the licence info can be detected and recorded by a GET on LICENSE and LICENCE and selecting the one that doesn't 404.
Or just let a package maintainer set the URL.

The license url can be set freely in the package metadata (nuspec) when you create the package.

@frankshearar, how do you produce this package? I would like to help you identify the tool that is defaulting to LICENSE instead of LICENCE. Perhaps that tool could become more aware of the user's context and pick a different default. That being said, if GitHub is itself not clever enough to switch the default license URL based on English dialect when creating a new repository, then we would need to balance the options.
There's a variety of ways to produce a NuGet package (.nupkg). NuGet.org just reads the license URL that is already present in the .nuspec (which is inside the .nupkg) and shows it on the package details page, which you have linked above.
Your .nuspec looks like this right now:
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
  <metadata>
    <id>Fred</id>
    <version><IP_ADDRESS></version>
    <authors>Frank Shearar</authors>
    <owners>Frank Shearar</owners>
    <licenseUrl>https://github.com/frankshearar/Fred/blob/master/LICENSE</licenseUrl>
    <projectUrl>https://github.com/frankshearar/Fred/</projectUrl>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>Parsing with derivatives</description>
    <summary>Parsing with derivatives</summary>
    <releaseNotes />
    <copyright>Copyright Frank Shearar 2014</copyright>
    <tags>F# regular expression</tags>
  </metadata>
</package>

Perhaps you can get all the information you need from the NuGet documentation on how to create a NuGet package.

Clearly I need to catch up on my sleep. You're quite right. There's no need for the UI to do anything re licence URI because the nuspec is what defines it. Apologies for wasting your time :/.


the workaround should no longer be needed with the fix in upstream

Signed-off-by: Yu Cao<EMAIL_ADDRESS>

/hold


[MB-17008] Add left zero padding to LOA L1 segment values to meet 6 char validation

Jira ticket
Summary
We received feedback from DFAS about the EDI 858 LOA segments we were sending that the LOA L1 segment should always be six characters in length.  While some of the LOAs in our dataset have six character values for the LoaInstlAcntgActID others can be as small as three digit numerals (stored as string types).
This PR uses the format string to ensure we're left padding with zeroes to exactly 6 characters of length everytime unless we get a null value from the database.  In the case of a null value we will omit the L1 segment from the EDI like other fields instead of say sending "000000".  There is already a test that nil values get omitted so I didn't add a test for that.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
The easiest way to validate this PR is using the new test harness data:

Go to the test harness data: http://officelocal:3000/testharness/list
Click MakeMoveReadyForEDI
Search for and retain the payment request number it should look like: "payment_request_number": "6841-8898-1"
Build the generate-payment-request-edi cmd with make bin/generate-payment-request-edi to ensure you've compiled the latest changes.
Generate an EDI locally for the retained payment request number bin/generate-payment-request-edi --payment-request-number <payment_request_number>
Inspect the FA2 lines of the EDI, they should all contain the same data so verifying the first section is fine. You should see that the L1 value is now "000102" instead of "102", which is the value in the lines_of_accounting database table.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Messages

:book:
:link: MB-17008

  Generated by :no_entry_sign: dangerJS against<PHONE_NUMBER>5f6a2c994ae35e32f7d3b3bdfcd27e

since it's only used in one place in the codebase, and wouldn't be flexible if the character requirements change in the future

Agreed, I'm on the side of the DB reflecting accurate data and formatting only being done for the output.

Just one non-blocking comment, otherwise looks reasonable to me.
I was wondering if this requirement should be enforced at the database level (it's currently a varchar(6)), but then decided against it since it's only used in one place in the codebase, and wouldn't be flexible if the character requirements change in the future. Curious on others' thoughts though.

Thanks for reviewing @melissathai. Yea that discussion came up a week or so back during refinement about possibly backfilling the data.  It felt like extra effort that just made things a bit more inflexible.  For context too, there is a future 3rd party TGET integration that is going to supplant some of our data loading that we have had to do manually so far.
We tried to model some reasonable defaults in the database columns like you saw with a max 6 chars but it's unclear if those will hold going forward.  The best documentation we have is linked on the Jira story (TRDM File Layout - FA2 Values highlighted.pdf) that shows L1 is a mandatory field and that the min/max are both length 6.
I'll put a comment in the code too to make it clearer.


Targeting OpenWrt mipsel-unknown-linux-musl

Perhaps unintended for support, so please close if necessary.
I'm able to build OpenWrt mipsel-unknown-linux-musl targets for my Rust projects, so I thought I'd try it against wasmi. I'm discovering problems during the linking of the wasmi_cli. FIrstly, this is how I set up my OpenWrt environment:
export STAGING_DIR=/Volumes/OpenWrt/openwrt/staging_dir
export PATH=$STAGING_DIR/toolchain-mipsel_24kc_gcc-11.2.0_musl/bin:$PATH
export MIPSEL_UNKNOWN_LINUX_MUSL_OPENSSL_DIR=$STAGING_DIR/host

...then to compile:
CC="mipsel-openwrt-linux-musl-gcc" cargo build --release --target=mipsel-unknown-linux-musl

...which ultimately yields:
  = note: clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument]
          ld: warning: directory not found for option '-Lsrc/backend/linux_raw/arch/outline/release'
          ld: unknown option: --as-needed
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

However, it does appear that I can build wasmi/crates/wasmi itself, so I am able to continue my experiments.

Hi @huntc
The wasmi interpreter was designed to run on embedded platforms such as wasm32-unknown-unknown and in our CI we also build for the thumbv7em-none-eabi since it has no std library support. This is true for all crates but the wasmi_cli crate. The wasmi_cli crate is special in that it is a CLI tool and therefore requires the use of std in Rust. At least to my knowledge building a CLI tool in Rust without std support is going to be a rough experience. Please feel free to teach me wrong. :)
I am not sure if that is the problem here since we do not directly control flags such as -pie and ld's --as-needed flag. Therefore I am probably missing the information to help you out with your endeavor.
If you come up with an idea how wasmi_cli can be build on more platforms and especially yours, then I am happy to hear that. :)

Hi @huntc The wasmi interpreter was designed to run on embedded platforms such as wasm32-unknown-unknown and in our CI we also build for the thumbv7em-none-eabi since it has no std library support. This is true for all crates but the wasmi_cli crate. The wasmi_cli crate is special in that it is a CLI tool and therefore requires the use of std in Rust. At least to my knowledge building a CLI tool in Rust without std support is going to be a rough experience. Please feel free to teach me wrong. :)

Thanks for getting back to me! To be clear, OpenWrt is a std target for Rust, and I've built a number of CLIs for it.

I am not sure if that is the problem here since we do not directly control flags such as -pie and ld's --as-needed flag. Therefore I am probably missing the information to help you out with your endeavor.
If you come up with an idea how wasmi_cli can be build on more platforms and especially yours, then I am happy to hear that. :)

Wilco. Thanks!

Hi @huntc, trying to clean up the backlog. This issue seems to be inactive and also I kinda feel like it isn't something that can be resolved in wasmi itself but rather in the Rust tech stack for the OpenWrt mipsel-unknown-linux-musl target.
Do you confirm? If so I'd like to close this and if needed we can re-open or start a discussion in a GitHub discussions thread.

Yeah, sorry I’ve not hard time to pursue this. I will close. Thanks for the dialogue.

Months later, I came back to this. I simply required a .cargo/config.toml file in the cli folder with:
[target.mipsel-unknown-linux-musl]
linker = "mipsel-openwrt-linux-musl-gcc"


Job requirement

I would like to write code which will scan the resume and show the perfect job that fits to that resume of a person. Please assign this issue to me under GSSoc'24.

@Passionatelytoooadorable  what specific steps will you take to accomplish that task? Please break down your proposed solution into individual parts and create separate issues or tasks for each part. To start, list out the different parts or stages of your solution.


Fsi fails to augment a type constructor

The following script
type AugmentMe = val _i : int
type AugmentMe with member i.I = i._i
type AugmentMe with new(i) = { _i = i }
printfn "AugmentMe instance: %i" (AugmentMe(42).I)

when interpreted by fsi at once works as expected.
When being interpreted in new fsi session line by line, last two lines produce the following diagnostic messages:
warning FS0073: internal error: pop on empty stack during code generation, methodName = AugmentMe..ctor
error FS0039: The value or constructor 'AugmentMe' is not defined

so apparently in the second case type augmentation with constructor has failed.
The artifact can be observed both in F# 4.0 and F# 3.1.

Already fixed by https://github.com/Microsoft/visualfsharp/pull/704


Add functionality to AgentScheduler and its factory to make it easier to use as a child instance

AgentScheduler historically has been used globally as a root data store.  However, it's reasonable to want to use it as a child instance and some of our partners are interested in doing so.
There are two challenges in doing so:

AgentScheduler isn't using DataObjectFactory so it doesn't have the nice functions available like createChildInstance
AgentScheduler doesn't create its own handle (no agentScheduler.handle property) so the customer has to create their own handler from the outside.  This is particularly awkward since it wants access to the AgentScheduler's IFluidDataStoreRuntime to get the objectsRoutingContext.

So to do this currently, it looks something like:
protected async initializingFirstTime() {
    const packagePath = [...this.context.packagePath, AgentSchedulerFactory.type];
    const router = await this.context.containerRuntime.createDataStore(packagePath);
    const agentScheduler = await requestFluidObject<IAgentScheduler>(router, "/");
    const handle = new FluidObjectHandle(
        agentScheduler,
        "",
        // kind of a nasty cast, but we know createDataStore will return the DS's runtime
        (router as IFluidDataStoreRuntime).objectsRoutingContext,
    );
    this.root.set("agentScheduler", handle);
}

This PR instead mimics the handle property from PureDataObject and createChildInstance from PureDataObjectFactory to simplify, such that the above becomes:
protected async initializingFirstTime() {
    const agentScheduler = await AgentSchedulerFactory.createChildInstance(this.context);
    this.root.set("agentScheduler", agentScheduler.handle);
}

Do we have example or documentation on how to instantiant AgentScheduler somewhere.  Do we need to update those?

Do we have example or documentation on how to instantiant AgentScheduler somewhere. Do we need to update those?

Added to the README in latest regarding the parts changed in this change.  Opened #8321 to go further with architectural changes, documentation, and testing.


Add project, replication policy deletion and pagination of projects.

Add project, replication policy deletion and pagination of projects.

Coverage remained the same at 31.353% when pulling bc38b8175f526f16cd8048544a871aa8cd02f7bf on wknet123:dev into 569e3aa32f3fe500ba53f193fe091f2ec530a850 on vmware:dev.


Save and properly remove notification observers in Barcoder.

The Barcoder class is improperly using the new block based notification API.
According to Apple's documentation, to properly remove observers, one must save a reference to the returned opaque object and then remove it before the observer is de-initialized.
https://developer.apple.com/documentation/foundation/notificationcenter/1411723-addobserver

To unregister observations, you pass the object returned by this method to removeObserver(:). You must invoke removeObserver(:) or removeObserver(_:name:object:) before any object specified by addObserver(forName:object:queue:using:) is deallocated.

This change may resolve a potential crash that consumers of the SDK are experiencing.

This looks good, and I see quite a bit of approval/star.  @adyen-git-manager can you double check, merged and tag a new version so we can start using them.


Create Kraken Version of prometheus-operator

Sub-issue of #876
Create a kraken specific version/deployment of: https://github.com/coreos/prometheus-operator
Using the full up working example provided by: https://github.com/camilb/prometheus-kubernetes/operator
This will require its own repo be created first.  (see corresponding issue).
Initial work has shown there are some namespace issues if the default "monitoring" namespace is not used.  That should be resolved so we can use something like "kube-monitor" or "kraken-monitor".
Also there are some specifics that should also be changed to make the source example more kraken (kraken-lib) friendly.
The deployment scripts should be set up to use a user provided kubeconfig and base directory (if applicable).   The deployment scripts should be implemented in terms of helm chart(s) if there is no blocking reason (such as startup timing). (See corresponding issue for that).

See initial start: https://github.com/mikeln/kraken-monitor

move to issues
p1

moved to samsung-cnct/issues#78


Introduce a "recording mode" that allows visually authoring tours

Currently, you can authors code tours "manually" by creating the JSON file. However, I plan to allow the user to "start recording", and then navigate across files, clicking on relevant lines, and adding comments visually. That way it's very quick to create new tours for a codebase.

Just checked this in.


The word "New" disappears when "On-premises data gateways" is selected in the body of the page

One of the instructions says "Select New at the top of the screen to add a new data source."
If the user presses "On-premises data gateways" within the page, the word "New" will disappear from the top of the page.
This is really more of a Power BI Service issue, but if this behavior is going to be in place, it could be documented.
If "New" is pressed when "Connections" is selected, one of the choices is "On-premises", so the UI is a bit confusing overall.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 92e0c038-1195-d758-ccf4-903b689139ca
Version Independent ID: 181904c0-1ec5-0a1d-4cbf-a5a639bbdfeb
Content: Add or remove a gateway data source - Power BI
Content Source: powerbi-docs/connect-data/service-gateway-data-sources.md
Service: powerbi
Sub-service: powerbi-gateways
GitHub Login: @arthiriyer
Microsoft Alias: arthii

Thanks for your comment, @wayne-at-DSN. This issue has been assigned to the doc author for review.

Thanks for your feedback.  Looks like this is product feedback, rather than documentation feedback – you can submit product feedback or feature ideas by going to https://ideas.powerbi.com. You can also engage with the Power BI engineering team by being active in the Power BI Community, found at https://community.powerbi.com.


Unable to install ICD / ImagingAndConfigurationDesigner

Description
I am trying to setup GitHub workflow to build a .PPKG
You can see my attempts here to use ADK setup to install ICD:
https://github.com/jetersen/test-windows-gh-runner/blob/main/.github/workflows/run.yml
I need to use ADK setup to also install the necessary Microsoft-Desktop-Provisioning.dat
running ./adksetup.exe without /quiet should show the error. I suspect that the workflow lack permissions to modify the C:\Program Files (x86)
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
https://github.com/jetersen/test-windows-gh-runner/runs/3913989855?check_suite_focus=true
Is it regression?
No response
Expected behavior
No response
Actual behavior
No response
Repro steps
See workflow 👍

Oh, I feel silly 🗡 @al-cheb cheers for the hint 😅


review-10: ChartComponent.jsx and DisplayAudBalData.jsx

Overview
In a separate document create a list in accordance with the checklist of issues you find. It may be helpful to link the code and include the checklist section it fall under.
Example
Review Branch
review-10
Files to review
ChartComponent.jsx
DisplayAudBalData.jsx
Checklists
Design
JS
Due date
11/18/24
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414f24/morea/review/reading-idpm-review.html

DisplayAudBalData.jsx

Design-05: Comments please
Design-08: Could there be a way to simplify the code a little

ChartComponent.jsx

Design-05: More comments please

DisplayAudBalData.jsx

Design-01: A helper function to calculate totals from an array could be used instead of repeating the reduce calls
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/DisplayAudBalData.jsx#L62
ESLint-01: Error handling in case audBalData is not properly defined
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/DisplayAudBalData.jsx#L24

ChartComponent.jsx

Design-01: For the renderChart function, another helper function to render each line (which can be called to generate lines for a single, dual, or triple chart type as needed) may be helpful
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/ChartComponent.jsx#L19

Review Issue - 10
DisplayAudBalData.jsx
Design-01: Refactor to Reduce Duplication

The code contains a lot of duplication with the rows & columns. Consider using mapping to reduce this duplication and iterate over data, rendering the fields dynamically.

Design-05: Ensure comments are appropriate

While the code is mostly clearly readable consider adding in few comments to code

ChartComponent.jsx
Design-01: Refactor to Reduce Duplication

There is a lot of duplication when it comes to the graphs. You should refactor them into one graph and then add a function that is in charge of displaying the lines based on the chartType.

CharComponent.jsx
Design-01/08 Make so it takes any key type with out having to have single double triple so its less repetitive
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/ChartComponent.jsx#L15
Design-02 if blocks for the types of graph can be addressed in the previous
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/ChartComponent.jsx#L17
JS-01 key can be more specific
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/ChartComponent.jsx#L15
JS-08 Can add more JSdoc
ChartComponent renders a line chart based on provided data and configuration…
ESLINT no errors
DisplayAudBalData.jsx
Design-07 maybe use an array to reformat so not so many row col
https://github.com/visualizing-your-future/visualizing-your-future/blob/e36aa59a59995c35c6f041ff33b0a6998b4fe54c/app/imports/ui/components/DisplayAudBalData.jsx#L103
JS-08 Add JSdoc comments
ESLINT no errors

ChartComponent.jsx
JS-01 - vars on line 15 could be more specific, but that's kind of nitpicking.
DisplayAudBalData.jsx
Design-05 - some comments could help


Kernel dying mac os Mojave 10.14

After grappling with installation of LightGBM, which I couldn't get an easy installation with anaconda, I couldn't run lightgbm on jupyter because it is crashing instantly. Please give me your feedback, I am stuck. :(
Environment info
Operating System: Mac Mojave 14
CPU/GPU model: 16 GB 2400 MHz DDR4, 2.2 GHz Intel Core i7
C++/Python/R version: python 3.7
LightGBM version or commit hash: 2.2
Error message
The kernel appears to have died. It will restart automatically.

Reproducible examples

Steps to reproduce
param = {'num_leaves': 111,
'min_data_in_leaf': 149,
'objective':'regression',
'max_depth': 9,
'learning_rate': 0.005,
"boosting": "gbdt",
"feature_fraction": 0.7522,
"bagging_freq": 1,
"bagging_fraction": 0.7083 ,
"bagging_seed": 11,
"metric": 'rmse',
"lambda_l1": 0.2634,
"random_state": 133,
"verbosity": -1}
folds = KFold(n_splits=5, shuffle=True, random_state=15)
oof = np.zeros(len(train))
for fold_, (trn_idx, val_idx) in enumerate(folds.split(train.values, target.values)):
train_mat = lgb.Dataset(train.iloc[trn_idx][features],
label=target.iloc[trn_idx],
)
val_mat = lgb.Dataset(train.iloc[val_idx][features],
label=target.iloc[val_idx],
categorical_feature=categorical_feats
)
num_round = 10000
clf = lgb.train(param,
                trn_data,
                num_round,
                valid_sets = [train_mat, val_mat],
                verbose_eval=100,
                early_stopping_rounds = 200)

oof[val_idx] = clf.predict(train.iloc[val_idx][features], num_iteration=clf.best_iteration)

feature_importance = clf.feature_importance()

@efago I seem to have the same problem. How did you remove the additional openmp packages/clean up afterwards? Thank you


Apply the Custom Script Extension step doesn't add custom script extension to instances or run the script.

Hello, team.  When I execute the command:
az vmss extension set --publisher Microsoft.Azure.Extensions --version 2.0 --name CustomScript --resource-group myResourceGroup --vmss-name myScaleSet --settings customConfig.json
in the step "Apply the Custom Script Extension"...  https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/tutorial-install-apps-cli#apply-the-custom-script-extension
...it does add the custom script extension to the VM Scale Set, but it doesn't actually add the custom script extension to the instances, and then run the script from the previously created file "customConfig.json" within the instances.  The article states that "Each VM instance in the scale set downloads and runs the script from GitHub", which seems to imply this will happen automatically.  The only way I've been able to get the custom script extension applied to the instances and then executed is by also running the command below, after the step "Apply the Custom Script Extension" to update the instances:
az vmss update-instances --name myScaleSet --instance-ids '*' --resource-group myResourceGroup
Once I execute this command, the custom script extension is applied to the instances and the script runs.  Should that be added to the article, or am I perhaps doing something incorrectly?  Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bf54fb22-6522-87f9-e63f-07ecee909abf
Version Independent ID: 5ec14ed2-693b-e98b-44d3-792d1a44be30
Content: Tutorial - Install applications in a scale set with Azure CLI - Azure Virtual Machine Scale Sets
Content Source: articles/virtual-machine-scale-sets/tutorial-install-apps-cli.md
Service: virtual-machine-scale-sets
Sub-service: extensions
GitHub Login: @ju-shim
Microsoft Alias: jushiman

@mbiver
Thanks for your feedback! We will investigate and update as appropriate.

@mbiver
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@ju-shim
Can you please check and add your comments on this doc update request as applicable.

Hello, I am on the content team that handles this area. I am looping in the correct PM to help address this issue and other related issues. I'll update once I know more information. Thank you!

Good call out! The instances will need to be updated to get the custom script. I will work on reworking this entire tutorial next week.

Submitted a fix for the CLI and PowerShell tutorial. Updates will be live around 3PM today. I tested and verified the workflow. Will close this for now but if you still experience issues with the updated tutorials, just let me know.
#please-close


Extract ChangeNotifier.debugAssertNotDisposed as extension

Making debugAssertNotDisposed an extension minimizes the API surface and makes it easier for subclasses to implement ChangeNotifier.
This method was recently made public (https://github.com/flutter/flutter/pull/103456), making it a breaking API change.
It can be prevented by making the method an extension.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

@justinmc @HansMuller Just FYI: Here's another case where implementing a class that isn't meant to be implemented is causing some trouble (related to our previous discussion, https://github.com/dart-lang/linter/issues/3353).

Closing this in favor of https://github.com/flutter/flutter/pull/104772.
@passsy Still interested in whether you could have just implemented Listenable instead (see comment above).

The main advantage of ChangeNotifier over Listenable is the dispose method that gets automatically called by ChangeNotifierProvider and friends.


#31: Added name validation

Names have been validated according to Django convention - lowercase letters and underscores only. Failing this, an error message will be displayed to the console and the application will exit.

AppVeyor shows the error:
ERROR: InvocationError: 'C:\\projects\\bottery\\.tox\\check\\Scripts\\flake8.EXE bottery'
I am working on a Linux machine, so I might not be able to address this?
Another error:
bottery/cli.py:57:14: W292 no newline at end of file
When I do insert a newline, it gives a different error. Please do advise, and I'm sorry about the inconvenience.

:/


Defer the creation of Error objects until they are thrown.

Errors capture the stack at the moment in which they are created. That means that any reported stack traces from these error constants are unhelpful, as they only report the state of the stack during the creation of their containing namespace.
This change makes these entities functions instead of error constants. That way, it is easier to diagnose what exactly triggered an error to occur.
@zhengbli @vladima

Actually, I wonder if a better approach is to make each of those functions throw. It is probably very easy to forget to actually call those functions before throwing. Thoughts?

This is already fixed (though not pushed) in my tsserver work

Alright, I'll defer to your implementation.


feat(proof): Include leaf that advances the namespace in absence proofs

Based on the Celestia nmt specification:
https://github.com/celestiaorg/nmt/blob/master/docs/spec/nmt.md#verification-of-nmt-absence-proof

Closing since it was merge with #5


Refactor cleanup handler for cabledrivers

The cleanup handler is replaced with event handlers
for cabledrivers
Required for : #1171
Signed-off-by: Aswin Surayanarayanan<EMAIL_ADDRESS>

I started reviewing, but I had an Idea, let me know what you think.
What if, instead of making different types of event handlers we could make them expose the list of drivers as:
"network-plugin/" or "cable-driver/" for the "all cases", or simply "*" for all (logger)
In that way you wouldn't need different types (network plugin vs cable driver), the code structure and interfaces would be slightly simpler, the complexity is moved into the matcher.
What do you think?

I was actually thinking of removing any knowledge of Handler types from the Registry altogether . Instead of the Registry filtering handlers statically on registration, we do it dynamically on notification via the pattern where the Registry asks the Handler if it can notify. So we remove the GetNetworkPlugins method and add CanNotify(eventType string). This removes knowledge of the network plugin from the Registry, especially since not all handlers are related to network plugin. So if we had a Handler dependent on the local cable driver type then it can obtain cable driver dynamically via the Endpoint and react to all events dynamically. I was going to prototype this in a separate PR.

Globalnet has a cleanup.Handler as well that isn't used. We can remove that and then the cleanup.Handler interface altogether.

Ya initially I removed it and realised it is being used in globanet and hence retained it.

Globalnet has a cleanup.Handler as well that isn't used. We can remove that and then the cleanup.Handler interface altogether.

Ya initially I removed it and realised it is being used in globalnet and hence retained it.

It exists but isn't actually used anywhere (GetGlobalnetCleanupHandlers).

Globalnet has a cleanup.Handler as well that isn't used. We can remove that and then the cleanup.Handler interface altogether.

Ya initially I removed it and realised it is being used in globalnet and hence retained it.

It exists but isn't actually used anywhere (GetGlobalnetCleanupHandlers).

Oh ok I will remove the  cleanup.Handler interface

I started reviewing, but I had an Idea, let me know what you think.
What if, instead of making different types of event handlers we could make them expose the list of drivers as:
"network-plugin/" or "cable-driver/" for the "all cases", or simply "*" for all (logger)
In that way you wouldn't need different types (network plugin vs cable driver), the code structure and interfaces would be slightly simpler, the complexity is moved into the matcher.
What do you think?

I was actually thinking of removing any knowledge of Handler types from the Registry altogether . Instead of the Registry filtering handlers statically on registration, we do it dynamically on notification via the pattern where the Registry asks the Handler if it can notify. So we remove the GetNetworkPlugins method and add CanNotify(eventType string). This removes knowledge of the network plugin from the Registry, especially since not all handlers are related to network plugin. So if we had a Handler dependent on the local cable driver type then it can obtain cable driver dynamically via the Endpoint and react to all events dynamically. I was going to prototype this in a separate PR.

Removed the cleanup handlers. Now there is a single cable cleanup handler, when we add VXLAN cable handler, it will be added to the same handler and it would try cleanup both without checking the cable driver type (no-ops).

@mangelajo this is ready for re-review.

@aswinsuryan it seems to need manual rebase.


Add an option to the rails c command, to launch the console without pry

When using the pry-rails gem, the rails console is always launch with pry.
I think it would be great to have an option to the rails c command, or an command with an other name, that launch the default rails console (ie: without pry).
It is useful sometimes, because pry is sometimes not the best option in the console. For example, when you work with long arrays/hashes. It also hide the ruby backtrace.
What do you think of this ?

Ok, didn't knew we could do that.
Is it somewhere in the docs ? Maybe it could be nice to add that information.
Thanks!
(I let you close this issue)

It is in the README, kind of, but could definitely be clearer (it's at the end of the example).


chore(.gitignore): Ignore virtualenv directories

Will you accept this, (or any variation of this pattern)?
This way contributors won't be prompted to stage .venv, .env, etc. virtual environment dirs.
Here's what I've used on another project for a while

@thisch Thoughts on this?  This makes it a lot easier to contribute for those that don't have a global gitignore file.
If it impedes I can close for now


fix: No panic

Remove log.panic

Codecov Report

Merging #334 (badb1ba) into master (586e489) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   74.55%   74.55%
=======================================
  Files          20       20
  Lines         900      900
=======================================
  Hits          671      671
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586e489...badb1ba. Read the comment docs.


to_parquet partitioned by 'date'

I'm trying to save a dask dataframe to_parquet and partition it by date. The system won't allow the naming of the file date=2022-01-01 00:00:00.
dates = pd.DataFrame({'date':pd.date_range(start='2022-01-01', end='2022-01-31', freq='D')})
ddata = dd.from_pandas(dates, npartitions=1)
ddata.to_parquet("dates.pq", partition_on="date")

OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: '***/dask/dates.pq/date=2022-01-01 00:00:00'

Getting rid of the  00:00:00 would solve the issue.
Workaround:
Save date as a string, but I would like it to be a date.
I'm using dask '2023.5.1'

Thanks for the report @marcdelabarrera!  I cannot reproduce on my end, so I'm thinking this is probably specific to windows. Can you confirm if you are using the "pyarrow" engine (by specifying engine="pyarrow")?

Thank you for the reply. @rjzamora.
I tried with pyarrow and I am getting the same error. I tried the same on Linxu and indeed worked. The problem is that on Windows, : is an invalid character to write in a directory name, while it does not seem to be the case with other OS.
I guess a partial fix is that the file was saved as yyyy-mm-dd, although this would drop information regarding hours, minutes, and seconds, or replacing : for some other allowed character.

The problem is that on Windows, : is an invalid character to write in a directory name

Yes, you are definitely correct about this. I'll try to see if pyarrow's native write_to_dataset (or other systems) do something special to handle this problem.

I guess a partial fix is that the file was saved as yyyy-mm-dd, although this would drop information regarding hours, minutes, and seconds, or replacing : for some other allowed character.

I'm not really finding any convenient ways to automatically handle the ":" problem while partitioning by a date_range column. In practice, most hive partitioning tends to be on a specific "day", "month" or "year" (the second is not typically something you want to partition on). Therefore, if you need to track the time information somewhere, you may want to split your "date" column into distinct "date" and "time" columns, and only use the "date" column for partitioning.  If you don't need the time information, then doing the following before the write is probably your best bet:
dates["date"] = dates["date"].astype("date64[pyarrow]")


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

Merging code-workflow to master

Deleting code-workflow brach post merging to master


Remove mapping types

As part of v2.0 release, mapping types are getting removed from OpenSearch engine. Below are the changes in the opensearch-engine.

Removal of type from rest end-points
Removal of include_type_name parameter from API requests.

As part of this issue, please verify if type removal change on OpenSearch engine impacts this repository. If yes, then please remove the type references/usage from this plugin.
Top level changes are captured in gist below:
https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3
For more detailed changes, please check meta issue below:
Related: OpenSearch-engine meta issue

I did a scan through the code base, and didn't find anything related to mapping type.
This repo mainly contains model classes and rest client security wrapper.