Blob API is not yet supported for hierarchical namespace accounts

Unfortunately it does not work with ADLS Gen2 where hierarchical namespaces are enabled. I tried it out and got following error message: "Details: "AzureDataLakeStorage failed to get contents from 'https://xxxxxxx.blob.core.windows.net/stg'. Status code: 400, description: 'Blob API is not yet supported for hierarchical namespace accounts.'"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f546a21-73c5-7165-e1ed-8d2a154ecb97
Version Independent ID: 934a7733-6951-fa5b-2b7f-44cdd6dde229
Content: Analyze data in Azure Data Lake Storage Gen2 by using Power BI
Content Source: articles/storage/blobs/data-lake-storage-use-power-bi.md
Service: storage
Sub-service: data-lake-storage-gen2
GitHub Login: @normesta
Microsoft Alias: normesta

Thanks for reporting the issue. @bensack Is there a whitelist or opt-in process for using the Power BI connector. Is this feature tied to the mutli-protocol access preview?

#assign:bensack

Hi @bensack not sure if you got it working, but I had the same issue, the account you create to access the ADLS Gen 2 should be assigned the Role of "Storage Blob Data Reader".

To use the new ADLS Gen2 connector, you want to use the new addressing scheme - this means using the DFS endpoint within the URL instead of the Blob endpoint. I wrote up a quick blog entry about this: https://www.coatesdatastrategies.com/blog/querying-data-in-azure-data-lake-storage-gen-2-from-power-bi

I have followed all the above steps and I am able to publish the report. But I am unable to see the report in the PowerBI service.  Here is the error in the PowerBI Service:
Sorry, we couldn't find that report
It may have been deleted or you may not have access to view it.
How do we resolve that issue?

Hi @yevhen-miro, to clarify, Blob APIs and Data Lake Storage Gen2 APIs can operate on the same data. I recommend reviewing this article for list of limitations for that specific feature: https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-known-issues#issues-and-limitations-with-using-blob-apis
This tutorial and associated connector (Azure Data Lake Storage Gen2) are for the filesystem endpoint (storageaccountname.dfs.core.windows.net.) i.e. if you want to access data via that interface you should use this connector. There is an Azure BLOB Storage connector available in Power BI to access the BLOB endpoint (storageaccountname.blob.core.windows.net.)

#please-close


Deploy contracts to special contract

The endgame for this is something like:

Then the node can check that a contract has been deployed via:
let mut key = vec![0];
key.extend(contract_addr);
query_state_inclusive_finalized(&conn, &DEPLOY_CONTRACT_ADDR, &key, block_num, solution_index).is_some();

So deploying a contract is just creating a solution to the above contract.

Storage layout for the contract deployment contract:
type Contract {
    salt: b256,
    len: int,
    predicate_addrs: b256[],
};

type Predicate {
    len_bytes: int,
    bytecode: int[],
};

storage {
    contracts: (b256 => Contract),
    predicates: (b256 => Predicate),
}

Query State Keys:

Get predicate:

[1, <predicate-address>, 0] to get the length bytes
[1, <predicate-address>, 1] gets the padded words, then truncate to bytes.

Get contract:

[0, <contract-address>, 0] to get the salt (optional).
[0, <contract-address>, 1] to get the number of predicates.
[0, <contract-address>, 2, predicate_addr_ix] to get the predicate address.

Contract Registry predicate will be an empty slices for state reads and constraints.
Contract Registry address will use salt sha256("contract registry").
Demo solution:
Solution {
    predicate_to_solve:  <contract-addr>, <predicate-addr> // from above
    decision_variables: [],
    state_mutations: ..., // A mutation for each key mentioned above.
    transient_data: [],
}

To-Do

[ ] Add registry contract in big-bang block.
[ ] Register contract registry in itself.
[ ] Update DB get_contract and get_predicate to work in terms of query_range::finalized.


Reboot unlikely to work (at least on GCE)

I haven't testing it yet, but given what I know of the configure-vm.sh script, it's exceedingly unlikely that the startup script will actually run on an already configured node. Apparently reboot is supposed to work.

Ah, @alex-mohr opened this already in #5666. Closing.


[ECO-4946] feat: typing indicators

Added typing indicators feature

Summary by CodeRabbit
Release Notes

New Features

Enhanced logging capabilities for chat rooms and typing functionality.
Introduced typing notifications to the chat interface, indicating which users are currently typing.
Updated the chat UI to display typing status and manage message input more effectively.
Simplified method signatures for presence and typing functionalities for easier usage.

Bug Fixes

Improved error handling in room management and presence functionalities.

Tests

Added a test to verify typing indication functionality for clients in a chat room.

Documentation

Updated method signatures and descriptions to reflect changes in parameters and functionality.

Overall, the implementation looks super good 👍 . I will review once again, if needed.


Search term has to be lowercase

I found that when I search for workspaces, I can't put in anything that is camel case or upper case, it has to be lowercase. The search should be case-insensitive.
Actual: CreateSIMSprint
Have to enter: createsimsprint

I took a look at the scripts in package.json, but yarn test doesn't seem to run tests.

Hi, sorry for not replying earlier. I had the wrong watch settings for this repo and never get notified about new issues. I shall address this in the next release.
To run tests you need to uses the test command via the debug panel. I shall update the documentation - this is how the extensions work and not due to my setup.

Done. Will be in the next release

In v1.5.0


⚠ Bofrost.de has degraded performance

In 0d6c0dc, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1419 ms

Resolved: Bofrost.de performance has improved in 4c3c9c7 after 7 minutes.


Cannot specialize a non-generic definition

AppDelegate:
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        let analytics = Analytics<EventTracking>() --> error: Cannot specialize a non-generic definition
        analytics.register(provider: FirebaseProvider())
        return true
}

How did you define EventTracking?

I had exactly the same issue. There is an Analytics class in firebase analytics and by default, it tries to initialize it.
You need to use the namespace Umbrella.Analytics<EventTracking>()


Store & retrieve DIDs, credentials, and presentations in EDV

Subtasks
[ ] #269
[ ] #285
[ ] #286
[ ] #267


Long-term goals

Hok is a CLI implementation of Scoop in Rust: https://github.com/chawyehsu/hok
Maybe nice to work together? (not the author of hok here)

At the very least, it would be nice to have benchmarks comparing them on the readme

Hok looks cool, and honestly, I might use libscoop in future.
I'll add benchmarks for now, but it seems like we're trying to accomplish different enough goals that the projects will probably remain separate.
I'll leave this issue open for now and I guess we'll see what happens.

I'll add benchmarks for now, but it seems like we're trying to accomplish different enough goals that the projects will probably remain separate.

scoop-search has been re-written in zig due to some issue with the go runtime flagged as virus: https://github.com/shilangyu/scoop-search/issues/44
It may be time to update the benchmarks.

I've updated the benchmarks, it's still about the same.


Fix issue with iterator variable in taint controller

Please provide a description of this PR:
This PR fixes bug with iterator variable sharing from #39155

Hi @RomanSerikov. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Documentation is confusing - Backup vault vs recovery vault

[Enter feedback here]
Backup vault and recovery vault documentation does not look accurate. Feature and screenshot say soft delete under recovery vault but in portal it shows under backup vault. It adds confusion and doubts on documentation. Also, there is no clear guidance when to use backup vs recovery vault.
https://learn.microsoft.com/en-us/azure/backup/backup-azure-recovery-services-vault-overview
https://learn.microsoft.com/en-us/azure/backup/backup-vault-overview

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4783cc28-5cf9-ad51-fcc3-6494fd0875ae
Version Independent ID: 5fc9f5e2-8b02-2911-e615-ecee34192f20
Content: Overview of Backup vaults - Azure Backup
Content Source: articles/backup/backup-vault-overview.md
Service: backup
GitHub Login: @v-amallick
Microsoft Alias: v-amallick

@patilsameer11 Thank you for posting your question here. I will look into the details of the documentation and get back to you soon.

@patilsameer11 Appreciate your patience in this matter. Please find the elaborated answer to your question.
Recovery Services Vault is the traditional service used by Azure Backup as a storage repository for your backup data.
It can back up:
VMs (via a backup extension)
File Shares (part of storage account)
SQL Server / SAP HANA databases, when deployed on an Azure VM
Backup Vault is a service that provides backup storage for newer workloads.
It can back up:
Managed disks (reads the disk directly, does not use VM extension)
Blobs (part of storage account)
Azure PostgreSQL databases
As far your question about soft delete, Soft delete protection is available for these services:
Soft delete for Azure virtual machines
Soft delete for SQL server in Azure VM and soft delete for SAP HANA in Azure VM workloads
Doc ref: https://learn.microsoft.com/en-us/azure/backup/backup-azure-security-feature-cloud
Hope this clarifies!

@patilsameer11 Checking in to see if the above answer helped. Let us know if there are still any additional issues we can help with.

@patilsameer11 We haven't heard back from you, so we will now close this issue. If this remains an issue, please reply and we will gladly continue the discussion.


Static package integrations

This PR adds support for creating "static" happo runs via the happo-static library.

Released in https://github.com/happo/happo.io/releases/tag/v7.0.0


Is anyone succeeded in other CPU types such as Tiger Lake-H ?

I'm not sure I did it right. I used the hugepages
sysctl -w vm.nr_hugepages=2048
./evsets -b 30 -c 24 -s 32 -a g -e 2 -n 12 -o 2097152 -r 10 -t 95 -C 0 --verify --retry --backtracking
The result is as follow:


Define hop colors

Defined colors for hop.nvim
Default hop colors  (with dark_catppuccino) :

After this PR:
dark_catppuccino

soft_manilo

neon_latte

light_melya

In my opinion these colors look good in the dark themes, but not so good in light_melya.  Is it possible to define different colors only for light_melya?

This looks sick man! thanks for the PR :)

In my opinion these colors look good in the dark themes, but not so good in light_melya

I personally feel like it's okay for the light theme? I mean, they are very distinguishable, aren't they?

Is it possible to define different colors only for light_melya?

Yes but in case you wanted to do this the best approach would be to determine whether the background is light or dark. To do that you can use Catppuccino's colors utils like so:
local colors_util = require("catppuccino.utils.colors")
if colors_util.assert_brightness(cpt.bg) then
	-- stuff
end

And then you'd use this to create a variable to change to if the background is bright.
In your opinion @SmiteshP, do you think it's hard to see?

In your opinion @SmiteshP, do you think the colors over the bright background are hard to see?

Yep, thats what I felt. I think that adding darker background for the hop highlights would make it better, something like in incsearch.

Yep I forgot... but anyways, a5a3d62f73eb2fe98b6353b62f26d51109c5e289 should've improved this :+1:

Welp, I actually don't like this change tbh 😅
Underlining the HopNextKey isn't necessary.
And HopNextKey2 should look subtle compared to HopNextKey1, thats why I had made it use a darker shade of blue and without any special style. Right now the 2 letter jumps seem like a lot of visual clutter.
That's just my opinion, if you like it this way its fine too 🤷🏽♂

Underlining the HopNextKey isn't necessary.

I saw that other plugins like hop use the underline for the first char thing.

Right now the 2 letter jumps seem like a lot of visual clutter.

But then they'd be hard to see in light backgrounds, wouldn't they?
Unlike you, I don't use Hop.nvim, so feel free to PR better colors :)

Unlike you, I don't use Hop.nvim, so feel free to PR better colors :)

Sure, I will try to make another PR with better colors for light_melya, while keeping the orange and blue combo for darker themes 😄


Removing SignedJwtAssertionCredentials.

This completes the consolidation of the two service account credentials implementations.
In the process, also adding test coverage for some untested code paths within the crypto helpers.
Fixes #211.
NOTE: Has #398 as diffbase.

Tell me about the Python2.6 failures in this?

Ah phooey! Needed to be unittest2 to use a context manager

I apologize that that's even an obstacle in our path over which to stumble.

Can't really change it. You could merge as-is and send a fixup right after or you could fork this branch

Superseded by #400.


HHH-15393 - Improve write-paths to use mapping model

HHH-15393 - Improve write-paths to use mapping model
HHH-15723 - Fix foreign-key modeling

Wow. Epic commit!


_.bind to Function.prototype.bind

this would technically close #4145 since it's the only thing I found that would break compat with upcoming lodash 5 changes, unless @jdalton has anything to say about here or through https://github.com/lodash/lodash/wiki/Roadmap

the CI is acting funny because it's trying to do es6/2015 using node 0.10.x

@akre54 @jashkenas @megawac @jridgewell please review


MKV and ass subtitle and fonts support

If the player will support subtitles in the future why not support MKV with embedded fonts and ass/ssa/srt subtitle, that will be cool feature

Not 100% sure, but I think MKV is supported in most browsers if using supported audio/video codecs. I'd have to test this... but at the moment we can play containers/codecs that are supported by browsers (not determined by us).
There was an interesting idea in Discord about using ffmpeg-wasm to transmux (i.e., repackage) clients-side to see if we can get unsupported formats working. Going a step further and transcoding would be too expensive client-side and introduce delays. Maybe if it can be done in segments and streamed but again that would need testing.


Handles Response when there is no content-type and body

Allows GetConnect to work with APIs that do not return Content-Type and/or Body equal to null
Fixes #884

Hope this can be merged soon, since it is a show stopper issue to my project. Thanks.

I'm not sure if this problem has already been resolved in the latest version. I will test, and if it was not, I will merge this PR.
Thanks for that Eduardo

LGTM!
Thanks for this

Has this bug been fixed on 3.24.0? I still encountered this bug on 3.24.0.

Has this bug been fixed on 3.24.0? I still encountered this bug on 3.24.0.

Has this bug been fixed on 3.24.0? I still encountered this bug on 3.24.0.

It is not, still waiting for the release.

Has this bug been fixed on 3.24.0? I still encountered this bug on 3.24.0.

It is not, still waiting for the release.

It has been resolved at Master for 16 days.
Publication in the pub should take place as soon as the null-safety version is ready

It has been resolved at Master for 16 days.
Publication in the pub should take place as soon as the null-safety version is ready

@jonataslaw @jasonlaw thanks

@jonataslaw @jasonlaw thanks


OCM-7049 | fix: allow proxy to be reset

OCM-7049
Change type

[ ] New feature
[x] Bug fix
[ ] Build
[ ] CI
[] Documentation
[ ] Performance
[ ] Refactor
[ ] Style
[ ] Unit tests
[x] Subsystem tests

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

/retest


Data Collection Practices

New Pull Request Checklist

[X] I have read and understood the CONTRIBUTING guide
[X] I have read the Documentation
[X] I have searched for a similar pull request in the project and found none

This merge request fixes / refers to the following issues: #1187
Pull Request Description
Add README section for the Data Collection Practices

@CocoaLumberjack/collaborators let's see some opinions here on how we can add more value to our framework's users with this section of the docs.

Cool @sushichop, thanks for looking into this.
I would like to also get @ffried's opinion before merging, just to be on the safe side :)

@bpoplauschi

I would like to also get @ffried's opinion before merging, just to be on the safe side :)

I feel the same way🙂

@sushichop I just wanted both your opinions before merging ;)

@bpoplauschi

@sushichop I just wanted both your opinions before merging ;)

Yeah, Thanks. Let's wait for a response🙂

@bpoplauschi
Am I right that you said about "docs" in related issue, but this PR only affects Readme.
Not sure if Readme is a document that is convenient for app developers.
Should we add additional document about data collection?

@ffried thanks for taking a look, I agree with your suggestions and have fixed those in a commit.
@lolgear once this PR is merged, I will regenerate the doc on https://cocoalumberjack.github.io which includes the content from our Readme, so that will also live on our documentation main page. I think this is enough.


Question about the baked in repos.

Would it be bad...
Currently when you run melange convert python, it adds the wolfi repos by default, here:
https://github.com/chainguard-dev/melange/blob/main/pkg/convert/python/python.go#L269
I think it would be nice to be able to pass a flag that those do not get added. Was thinking of just adding a flag --no-wolfi-repo (or something like that) and then a conditional right around the line above.
Context is to try to reduce manual mucking about after a file gets converted, and removing these for wolfi-dev/os repos is usually something that one always does manually. But maybe this assumption is wrong?

I think any wolfi-specific behavior should be encoded in wolfictl, not melange.

ok, but as a babystep:

Remove the hardcodes above (this also applies to things like gem, maybe others)
Add them as 'additional-repos' and 'additional-keyrings' in the "calling functions"
Add flag to not do ☝ to keep the existing behaviour as is

Then fix the other users to pass them in explicitly? WDYT?

Yep, exactly, sounds good to me.

This has been done.


Opportunity volume use case

Use cost distance to run the Hannibal opportunity volume example on AWS.
Need tobler raw surface:
mrgeo MapAlgebra -e "s = [s3://mrgeo/images/aster-30m]; kph = 6 * pow(2.718281828, -3.5 * abs(s + 0.05)); spm = 3.6 / kph;" -o s3://mrgeo/images/GlobalToblerWalkingRaw
OppVol map algebra:
source = RasterizeVector([s3://mrgeo/raw-vector/p1.tsv], "MASK", 0.00083333333333); destination = RasterizeVector([s3://mrgeo/raw-vector/p2.tsv], "MASK", 0.00083333333333); friction = [s3://mrgeo/images/flat-friction]; cost1 = CostDistance(source, friction, 1000); cost2 = CostDistance(destination, friction, 1000); opvol = 1000 - (cost1 + cost2); result = con(opvol < 0, 0, opvol);

Starting point: 32.692627, 68.424603
Ending point: 33.266602, 64.204102

Tobler Raw
Defined as the cost to traverse a pixel in units of seconds per meter assuming an average human walking speed across flat terrain of about 5 kilometers per hour (3.1 mph).
1). Create slope raster (dh/dx) ~ tan(theta). MrGeo's default slope output is radians.
slope = tan(slope([s3://mrgeo/images/aster-30m]))
2). Tobler equation, output is kilometers per hour
tobler = 6 * pow(2.718281828, -3.5 * abs([s3://mrgeo/images/aster-30m-slope-tan] + 0.05));
3). Convert units from kph to seconds per meter, optionally cap at 600.
spm = 3.6 / [s3://mrgeo/images/tobler-kph];
4). All together now
mrgeo mapalgebra -mm 16 -e "s = [s3://mrgeo/images/aster-30m-slope-tan]; kph = 6 * pow(2.718281828, -3.5 * abs(s + 0.05)); spm = 3.6 / kph;"  -o s3://mrgeo/images/GlobalToblerWalkingRaw

Cost Distance Small Test

Tobler Raw created on AWS then cropped by MrGeo WCS and re-ingested.
100km x 120km, east of Phoenix, AZ
Validated using WCS exported friction surface in grass r.cost.full on desktop

mrgeo mapalgebra -mm 16 -e "srcPoint = InlineCsv(\"GEOMETRY\", \"'POINT(-110.8090892 33.74918939)'\"); friction = [s3://mrgeo/images/tobler-tiny]; result = CostDistance(srcPoint, friction, 20000)" -o s3://mrgeo/images/cd-tiny2
MrGeo:

Grass, r.cost.full:

Completed Opportunity Volume example for Ryan's talk @ Strata. Pdf attached.
HannibalOpportunityVolume.pdf

mrgeo mapalgebra -mm 32 -e "srcPoint = InlineCsv(\"GEOMETRY\", \"'POINT(9.029234 45.223345)'\"); friction = [s3://mrgeo/images/tobler-raw-spm_nowater]; result = CostDistance(srcPoint, 9, friction, 2000000)" -o s3://mrgeo/images/vs-2_nowater
38min
mrgeo mapalgebra -mm 32 -e "srcPoint = InlineCsv(\"GEOMETRY\", \"'POINT(-0.996559 37.625565)'\"); friction = [s3://mrgeo/images/tobler-raw-spm_nowater]; result = CostDistance(srcPoint, 9, friction, 2000000)" -o s3://mrgeo/images/os-2_nowater
50min


Release 3.0.0

@rultor release it; the tag is 3.0.0.

@rultor release it; the tag is 3.0.0.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; the tag is 3.0.0.

@rafamizes Done! FYI, the full log is here (took me 2min)


binary search in c

Please assign this issue to me

Kindly assign me this task under Hacktoberfest2024, Thanku.

Please assign this issue to me


UI: Record button looks like it's disabled

The black "record" button icon blends into the dark background. When I did notice it, it's seemed like it was disabled (until I clicked on it).

weird one, it didn't used to look like this


ImportError: cannot import name 'TriangleMesh' from 'kaolin.rep'

Hi guys, does anyone encounter this error:
ImportError: cannot import name 'TriangleMesh' from 'kaolin.rep' (/home/testuser/miniconda3/envs/3dmesh/lib/python3.8/site-packages/kaolin/rep/__init__.py)

I just followed strictly with the instructions and my environments are as below:
linux
python 3.8
torch 1.13.0
cuda 11.7
kaolin 0.13
Moreover, I could not find 'TriangleMesh' in 'kaolin/rep'.

Hi guys, does anyone encounter this error:
ImportError: cannot import name 'TriangleMesh' from 'kaolin.rep' (/home/testuser/miniconda3/envs/3dmesh/lib/python3.8/site-packages/kaolin/rep/__init__.py)

I just followed strictly with the instructions and my environments are as below: linux python 3.8 torch 1.13.0 cuda 11.7 kaolin 0.13
Moreover, I could not find 'TriangleMesh' in 'kaolin/rep'.

Hey , I wonder how you solved the problem. I tried to use the Kaolin 0.1 but it remind me that:
ImportError: This is the kaolin placeholder wheel from https://pypi.org/project/kaolin/. Please follow https://kaolin.readthedocs.io/en/latest/notes/installation.html for installation.

Hi @yangqinhui0423 Unfortunately we only made wheels for v0.11.0 and above, for what usage are you trying to use v0.1?

Hi @yangqinhui0423 Unfortunately we only made wheels for v0.11.0 and above, for what usage are you trying to use v0.1?

In my code as follows:

kaolin.rep.Trianglemesh

This is the old version of the library no longer supported. Closing bug.
Note that for new code, we now support a SurfaceMesh class. Here's a video tutorial on how to use it, and visualization tutorial.


Add a temporary banner in the PR template to try and reduce the volume of spam PRs

This should be reverted once the initial wave of spam dies down.

/hold
/assign @mrbobbytables
We can't officially "not participate" in Hacktoberfest unless GitHub/DO explicitly doesn't consider our repos in their metrics. I'm not in favor of adding this banner because it makes it sound non-inclusive to contributors. I know that's not the intention btw :)...just comes across that way.
Adding a banner to the k8s website needs to go through a steering review too.

Adding a banner to the k8s website needs to go through a steering review too.

I misread! It adds a banner to the pull request template :woman_facepalming: (I should get more coffee :roll_eyes: :coffee: )
In this case, I'd leave it to SIG Docs maintainers :)

/sig contributor-experience
anyway

I don't think there'll be a big overlap between

people who read PR templates
people opening spammy PRs to claim a free T-shirt

No actual objection to this change but I'm not convinced it'll help

I don't think there'll be a big overlap between
* people who read PR templates

* people opening spammy PRs to claim a free T-shirt

No actual objection to this change but I'm not convinced it'll help

I'd rather not include a message about a single event in the PR template.
Would be more helpful to remind the relevant groups to be on the lookout for this type of contribution.

I'm up for trying this and seeing if it has measurable impact.
As others have pointed out, I don't know if the spam PRs even stop to read the template considering what we're seeing.
If we add this and it doesn't reduce after a couple days we could revert. Thoughts?
/cc @kbhawkey @sftim @onlydole @kbarnard10 @irvifa @zacharysarah

I'd be up for that, @jimangel! We could look at some automation tooling to help if this doesn't have any effect.

/approve
Related SIG Testing issue: https://github.com/kubernetes/test-infra/issues/19420

/hold cancel


includeDirs should default to true, as in D, python, unix find, unix ls, etc

@timotheecour hmm. It seems more common that I'd want to not match directories, and that's what I'm used to from most libraries in the JS realm. This is a possibility but I don't want to be consistent just for the sake of consistency — it should also be sane.

not a big deal ultimately whichever way you prefer, however here's 1 more argument:
with current default,
walkGlobKinds only entries with returns kind=file (real or symlink), so (with default options), the kind argument isn't particularly useful
with includeDirs defaulting to true, the kind becomes more meaningful


won't run on linux?

Any idea what's up there? I use Linux and would be willing to look into it!

I just read issue #8, let me know if you've got any other info, else I can just starting hacking and see what happens :P

right now, afaik, meteor-electron doesn't support linux (see https://github.com/electron-webapps/meteor-electron/issues/62), but the rest of the app should work just fine, so if you don't include the electron param in your settings.json file, the app should run without issue.
in any event, if you want to build the electron app for windows or mac, i suggest running the app from a mac or setting up a virtual machine
let me know how it goes!

right ok, feel free to close this ticket! If I get time to look at it I'll do so on meteor-electron, cheers.


wasi: removes manually run integration tests of tinygo+wasi

We recently added test files to ensure TinyGo is compatible with our
implementation of WASI functions. The presumed intent is that due to
unavailability or us not using an available WASI TCK, we had to
subsitute that manually ad-hoc with TinyGo.
Doing this ends up checking in even more binaries into our source tree
for very little gain. For example, it is nearly 400K to test only that
args are printed out. Meanwhile, we already test in multiple ways our
args functionality, both unit tests and also by accessing them in wasm.
The additional value of also adding a tree in the tests directory is
minimal at best, and doing this would only help if it were run on
change, and it wasn't. No automation built this directory, and I don't
suggest we "fix" that, because it is digging a hole.
If somehow we are able to express re-used text format signatures, test
our impl and also still get it wrong, we should figure out why and
correct it. Meanwhile, checking in binaries in an antipractice for
reasons including bloat of the source repo. The more extra work we do,
the longer change review takes and the more tech debt is accumulated in
the process. Stopping this now is the very best time to do it.

cc also @pkedy as you've been in this code lately, too!

PS one might argue that we shouldn't check in binaries for other things like the engine tests. agreed. this is mainly waiting on feature parity on the text compiler which is horsepower limited. Meanwhile the scale of that problem isn't much an issue tactically:
$ du -sk tests/engine/testdata/
44	tests/engine/testdata/

Thanks for the consideration, and looking forward to one less thing to have to ask contributors to do when implementing WASI also, something very easy to forget to ask


dropdown variable is not setting default selected value by property  .activeItem=index of item

var dropDownSelection;
dropDownSelection = Alloy.Globals.abx.createDropdown({
titles : ["First", "Second", "Third", "Fourth"],
color : "#fff"
});
dropDownSelection.activeItem = 2; // bydefault set Third variable to be selected

hii any updates..??

Hi, I've just pushed the 1.6.2 update.
You can now pass an index property to the creation object:
var dropDownSelection = Alloy.Globals.abx.createDropdown({
  titles : ["First", "Second", "Third", "Fourth"],
  index: 2
});

hi thankyou.... it is working perfectly fine... :)

I'll leave this open as this should work too but does not yet.
dropDownSelection.activeItem = 2;

Still need to figure out why that fails.


Add architecture tests for Provider API usage

So we don't add more non-provider methods to the public API.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Shouldn't this be "lastRecordError_"?

On this line: https://github.com/googlesamples/android-audio-high-performance/blob/master/howie/src/main/jni/private/StreamImpl.cpp#L372
shouldn't the variable be "lastRecordError_" instead of "lastPlaybackError_"?
@IanNiLewis @inl1ne

obsolete


Home loading view is broken

For some reason this is broken again.
The loading state needs to be on a white background.
I am not sure what changed.

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @bartv @Stijnkool


Cannot Proceed. Error says: Only change the first line

Challenge subtract-one-number-from-another-with-javascript has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

var difference = 45 - 33;

Already discussed, my bad!


Angular 14

Guess this package is no longer maintained - I'll probably fork it and migrate it to Angular 14 soon, in the meantime as it still works in 14 other than the dep issue on npm install you can override it with this in the package.json.
 "overrides": {   "ngx-monaco-editor": {     "@angular/common": "$@angular/common",     "@angular/core": "$@angular/core"   } }

can you please let me know the url of the forked version?Thanks

@here I've a new fork with latest angular 14, ngZone upgrade and fixed production missing assets, have a look, works for my company now:
https://www.npmjs.com/package/ngx-monaco-editor-v2

Thanks this seems to work mostly,
Alternative question, maybe you know... Why is formcontrol missing for ngx-monaco-diff-editor   ?
As I found here this is needed: https://github.com/angular/angular/issues/43821
Specially for ngx-monaco-editor it is done

@miki995, hi!
I've tried to use your fork and getting this error, what can be wrong? For some reason it called 2 time and second time this.themeData doesn't contain colors
Uncaught TypeError: Cannot read properties of undefined (reading 'editor.foreground')
    at get tokenTheme [as tokenTheme] (standaloneThemeService.ts:132:44)
    at S._updateThemeOrColorMap (standaloneThemeService.ts:366:58)
    at S._updateActualTheme (standaloneThemeService.ts:336:8)
    at S.setTheme (standaloneThemeService.ts:322:8)
    at new T (standaloneCodeEditor.ts:426:17)
    at g._createInstance (instantiationService.ts:110:13)
    at g.createInstance (instantiationService.ts:76:18)
    at Object.S [as create] (standaloneEditor.ts:40:30)
    at ngx-monaco-editor-v2.mjs:157:46
    at _ZoneDelegate.invoke (zone.js:372:26)

Thanks this seems to work mostly,
Alternative question, maybe you know... Why is formcontrol missing for ngx-monaco-diff-editor ?
As I found here this is needed: angular/angular#43821 Specially for ngx-monaco-editor it is done

Will check in couple of days, I'm busy these days, sorry...

Thanks this seems to work mostly,
Alternative question, maybe you know... Why is formcontrol missing for ngx-monaco-diff-editor ?
As I found here this is needed: angular/angular#43821 Specially for ngx-monaco-editor it is done

Will check in couple of days, I'm busy these days, sorry...

Hi, sorry, the problem is solved. It was due to missing colors property. Thank you!

@miki995
Ive copied the string into my angular.json for 14
{ "glob": "**/*", "input": "../node_modules/ngx-monaco-editor/assets/monaco", "output": "./assets/monaco/" }
but getting the 404
http://localhost:4200/assets/monaco/min/vs/loader.js net::ERR_ABORTED 404 (Not Found)

@rjf26 You have to add monaco-editor to your package.json, as now it is not shipped with ngx-monaco-editor anymore

@miki995 Ive copied the string into my angular.json for 14 { "glob": "**/*", "input": "../node_modules/ngx-monaco-editor/assets/monaco", "output": "./assets/monaco/" } but getting the 404
http://localhost:4200/assets/monaco/min/vs/loader.js net::ERR_ABORTED 404 (Not Found)

I had to add the loader in my assets from monaco-editor:
{
  "glob": "**/*",
  "input": "node_modules/monaco-editor/min",
  "output": "./assets/monaco/min"
}

@miki995 could you link to your github repo and update the repository/homepage links for your fork on NPM?

@allout58 Hello, I thought links were fixed, but I believe I only fixed them on github page, will update now

@here I've a new fork with latest angular 14, ngZone upgrade and fixed production missing assets, have a look, works for my company now:
https://www.npmjs.com/package/ngx-monaco-editor-v2

I have tried your version of ngx-monaco-editor but I get errors regarding css imports (Angular 14.1.0, ngx-monaco-editor-v2 14.0.4 and monaco-editor 0.34.1). Any idea what might be wrong?:
./node_modules/monaco-editor/esm/vs/base/browser/ui/actionbar/actionbar.css:6:0 - Error: Module parse failed: Unexpected token (6:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|  --------------------------------------------------------------------------------------------/
|

.monaco-action-bar {
|       white-space: nowrap;

@nhack Hello, can you provide simple example or not?
Did you follow all instructions in new fork?
Best

@miki995 I figured out what was wrong. I had the following import in my code: import {MarkerSeverity} from ‘monaco-editor; This import directly from monaco-editor broke the build, I guess it’s because in Monaco they are importing .css directly in .js and this is not allowed in by the new webpack anymore.

Had the same issue, here's what helped me:

Declare monaco as a symbol on Window for cases when I need to interact with it:

interface Window {
  monaco: typeof import('monaco-editor');
}

Use import type for types.

Thanks for your comments here, and I am trying to solve the same issue, but I am not very experienced with typescript. @Klaster1 would you be willing to expand on your solution here?

Thanks for your comments here, and I am trying to solve the same issue, but I am not very experienced with typescript. @Klaster1 would you be willing to expand on your solution here?

The issue happens because "monaco-editor" (or ngx-monaco-editor?) has its own loader for CSS, but you import "monaco-editor" into the app, trigerring the asset load, which you might not have a webpack loader. One of solutions is not to perform runtime imports from "monaco-editor". You can still import types from "monaco-editor", for example import type {editor} from "monaco-editor", which won't trigger asset loading. In cases where you have to access run-time monaco code and can't do that off the <ngx-monaco-editor> component instance - for example, for global configuration - use the monaco object that's added to the global scope - Window.monaco. The interface Window merely adds types, otherwise it would all be seen as any, but would work.

Hi, same issue here, and don't know how to use the Window interface you mentioned to interact with the library. Would you be so kind as to provide with some short example?

Thanks for the pointers @Klaster1! It took me a little bit to figure out the Window interface trick, so let me document how I got it to work.
// See https://stackoverflow.com/questions/12709074/how-do-you-explicitly-set-a-new-property-on-window-in-typescript
declare global {
    interface Window {
        monaco: typeof import("monaco-editor");
    }
}

// ...

setDiagnosticOptions() {
  window.monaco.languages.json.jsonDefaults.setDiagnosticOptions({
  //...
  });
}


HOSTEDCP-2067: [CPO Refactor] Refactor cloud-controller-manager

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/test e2e-aws-4-17

Hey @muraee which PR is the good one? could we close the other in the case those are overlapping between themselves?

https://github.com/openshift/hypershift/pull/5000
https://github.com/openshift/hypershift/pull/5007

/close
superseded by https://github.com/openshift/hypershift/pull/5007


DOC: Drop 2nd Numba link

Follow-up to PR ( https://github.com/scipy/scipy/pull/9820 )
Believe this should fix the doc failure that I accidentally introduced.
cc @tylerjereddy

Will have to wait for circleci to run through docs -- in the future, probably best not to skip circleci on doc changes.

Agreed. Sorry didn't realize the docs were being built here until looking at the build on master. Was hoping to save bandwidth on CIs used for test the code.
Side note: Was a little surprised that CircleCI respected [ci skip] (it was not previously well supported).

Ok, docs / CI are green again so merged.
No need for appveyor to run through test for a doc change, especially with Azure largely covering the same test territory now, so cancelled that.


use local files instead of downloading from the network

In some regions (like China), using curl to download files can be very slow and often interrupted. To solve this issue, you can pre-download the files locally and then use the following method. For example, to install the ant library, the default command is:
sdk install ant 1.9.7 [folder]

Set the parameter [folder] to the string "local" to enable local file installation. The actual command becomes:
sdk install ant 1.9.7 local

[ ] a GitHub Issue was opened for this feature / bug.
[ ] test coverage was added (Cucumber or Spock as appropriate).

Fixes #XXX

Hi @cary929,
this is already possible
https://sdkman.io/usage#install-local-versions


Copy new changes made to viz module into split

The first missing commit to viz that is not already in splot is commit 2374e60b32a3da (found by comparing in gitk). I used git cherry-pick -x <commit> to select all relevant new commits.  Maybe somebody can check that these imports are done in the right way.

Thank you for the comments @sjsrey I have implemented them.
In addition, the test was failing so I had to make some changes to remove Python 2 support (due to new release of libpysal) and get the dependencies on travis installed.

this was already merged in #6, closing the pull request


Add tap actions

Is your feature request related to a problem? Please describe.
I would like to allow a tap action to navigate to a url
Describe the solution you'd like
Support tap actions

In case you weren’t aware, this card supports tap actions. I use one along with browser_mod to open a pop up to display the alert descriptions. You just have to edit the card in yaml and add a tap action section.
I’m assuming you might be looking for tap action support in the UI. Which would be handy, though also likely complex.

Thanks, wasn't aware!
tap_action:
  action: url
  url_path: https://www.meteo.be/nl/weer/waarschuwingen/overzichtskaart-belgie


batch dropping 2.7

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check for azure-ai-anomalydetector
API changes are not detected in this pull request for azure-ai-anomalydetector

API change check for azure-iot-modelsrepository
API changes are not detected in this pull request for azure-iot-modelsrepository

API change check for azure-mixedreality-authentication
API changes are not detected in this pull request for azure-mixedreality-authentication

API change check for azure-agrifood-farming
API changes are not detected in this pull request for azure-agrifood-farming

API change check for azure-media-videoanalyzer-edge
API changes are not detected in this pull request for azure-media-videoanalyzer-edge

API change check for azure-security-attestation
API changes are not detected in this pull request for azure-security-attestation

API change check for azure-purview-scanning
API changes are not detected in this pull request for azure-purview-scanning

API change check for azure-purview-catalog
API changes are not detected in this pull request for azure-purview-catalog

API change check for azure-purview-administration
API changes are not detected in this pull request for azure-purview-administration

API change check for azure-core-tracing-opencensus
API changes are not detected in this pull request for azure-core-tracing-opencensus

API change check for azure-core-tracing-opentelemetry
API changes are not detected in this pull request for azure-core-tracing-opentelemetry

API change check for azure-mixedreality-remoterendering
API changes are not detected in this pull request for azure-mixedreality-remoterendering

@xiangyan99 I recommend filing an issue for the batch failure and check enforcer overriding.

/check-enforcer override


Autocomplete box doesn't work with fixed positioning

Description
When the search field has fixed positioning on the page and you scroll while the autocomplete box is open the box doesn't follow scroll.  The box scrolls out of view.
Related code is here:
https://github.com/algolia/autocomplete/blob/5fd58f6f9cdb6d3dc7ba02eb4b9e985f5e10d8f4/packages/autocomplete-js/src/getPanelPlacementStyle.ts#L25
The problem is that autocomplete uses absolute positioning.  To fix this, I suggest to have a configuration to allow it to use fixed positioning instead.
In my project, I was able to work around this issue by doing the following:

CSS

:root {
    --position-autocomplete-panel-top: 52px;
}

.aa-Panel {
    position: fixed;
    top: var(--position-autocomplete-panel-top) !important;
    z-index: 1000;
}

JS

    const fixPosition = () => {
      const rect = document.querySelector('.search-field').getBoundingClientRect();
      // Set css variable to be below the search box in case the search box moved when the window was resized
      setCSSVar('--position-autocomplete-panel-top', `${rect.bottom}px`);
    };

    document.querySelector('.aa-Input').addEventListener('focus', fixPosition);
    document.querySelector('.aa-Input').addEventListener('blur', fixPosition);
    window.addEventListener('resize', fixPosition);

Reproduction
My Sandbox: https://codesandbox.io/s/youthful-microservice-6km8p4?file=/style.css:843-880
Steps

Add this change to the css of the sandbox:

#autocomplete {
  position: fixed;
}

Now see that the search field follows you while you scroll in the frame
When you click in the search field then scroll you will see weird behavior.  See screenshot below:

Expected behavior
It should be possible to make fixed positioning work without a CSS hack using !important.
Environment

OS: macOS
Browser: Chrome
Autocomplete version: 1.11.1

Thanks for the hack!


add oom-kill-disable

Signed-off-by: 宁明晓10296073<EMAIL_ADDRESS>

fix https://github.com/containerd/nerdctl/issues/1105


importing error

from ensta import Mobile
ImportError: cannot import name 'Mobile' from partially initialized module 'ensta' (most likely due to a circular import)
how can i fix this issue ??
i use "pip install ensta" command

I think you've named your main python script either "ensta.py" or "Mobile.py". Or maybe you already have a folder with such name.

Yea. I change the file name and fix the issue thanks


ceremony box automated events (notifications and extrinsics)

It seems like we need to implement this with two components:

workmanager: Schedule background tasks to be executed at a predefined interval
flutter_local_notifications_pluging: Schedule the notifications that are shown.

The reason for this two phased approach is that the scheduling of the notifications does not allow dart code to be executed before firing the notification. This would lead to potentially showing and outdated notification. An example would be: the app was unable to fetch the assignment state after the transition to the assignment phase, and does therefore not know if the user was assigned.
Hence, we should use the workmanager to periodically fetch onchain data, to update the state. The workmanager would also handle scheduling the notifications. A nice side effect would be that the user tends to have a more recent state upon app startup.
I need a bit more time to investigate the complexity, the workmanager would introduce.

what about claiming automatically after a cycle?

First, I wonder if this is necessary, it will be the majority that actively early claims. I would argue that this should not be automated because we don't want to pre-emptively claim.
I wonder if we want to add this complexity for the few cases, where the early claim was not possible. If yes, and it is the only automated extrinsic, I would like to create a separate issue for that.


Fixed #24340 -- nested deconstruction should recursively deconstruct items within list, tuple and dict values

buildbot, test this please.

buildbot, ok to test.

Can you give the DeconstructableObject a bit more logic:
class DeconstructableObject(object):
    def __init__(self, *args, **kwargs):
        self.args = args
        self.kwargs = kwargs

    def deconstruct(self):
        return (
            self.__module__ + '.' + self.__class__.__name__,
            self.args,
            self.kwargs,
        )

and then add a test case that actually does some nested deconstruction. Something like this:
default=DeconstructableObject(
    DeconstructableObject(1),
    (DeconstructableObject('t1'), DeconstructableObject('t2'),),
    a=DeconstructableObject('A'),
    b=DeconstructableObject(B=DeconstructableObject('c')),
)

Added in 5d487f84dff10f7796e33834a14ad1c95a6baeb9. I could have gone forever testing minor variations on the structure, but hopefully all the meaningful cases are covered now...

Rebased and fixed above comments in #4711. Thank you for the PR!


Wiring policies with kuadrant backed services

The Kuadrant merge PR #48 changed how policy controllers are being deployed. However, the code remained mostly the same. And together with the code, the assumptions made initially when the policy controllers were part of the kuadrant instance deployment, not part of the operator’s deployment. The first spotted issue is explained in #69. It was fixed in #109. However, the fix does not cover all issues when the Kuadrant's namespace is not the default one, i.e. kuadrant-system.
Regarding Limitador
The rate limit controller needs to know the address of Limitador's endpoint to configure rate limiting in the gateways accordingly. The Limitador’s service endpoint URL is still provided to the rate limit controller via an environment variable. At boot time. That implies that the Limitador’s service endpoint URL needs to be known at the operator deployment time. Remember that the policy controllers are deployed as part of the operator as describe in #69. In other words, you need to deploy the kuadrant operator with an environment variable saying that kuadrant will be installed in namespace K and then create a Kuadrant CR in the very same K namespace. Clearly, this is an issue and needs to be fixed.
Regarding Authorino
Authorino is a k8s controller and the Kuadrant's operator deploys it in cluster-wide mode
without any sharding defined. When the user creates an auth policy, the auth policy controller does not need to know where authorino lives. The auth policy controller just creates the AuthConfig CR and expects Authorino to read it, even if they are not in the same namespace. There is room for improvement here. The AuthConfig CR managed by Kuadrant should only be used for Authorino instances managed by kuadrant. The cluster could have more authorino instances deployed and kuadrant managed AuthConfig CR's should not be read by other Authorino instances. Istio (or OSSM) needs to be configured with the Authorino endpoint address. But this is one-time registration is done by the kuadrant CRD controller, which is also responsible of deploying Authorino.
The current implementation lacks a required wiring mechanism between policies and Kuadrant backed services. The cluster admin should install the operator (without specifying any namespace for limitador), then install Kuadrant instance in some namespace K. The users of Kuadrant should create policies in their namespaces without knowing anything about the kuadrant backing services. When the controller gets notified about a new policy, the controller should have a way to know about deployed kuadrant's infrastructure (namespaces, services and endpoints) and use it for the the task needed to be done.
Related issues: https://github.com/Kuadrant/kuadrant-operator/issues/56
How it worked before #48
When an instance of Kuadrant, represented by a Kuadrant custom Resource (RC), was created, the following workflow was run by the Kuadrant operator:

Read the Kuadrant custom resource, paying attention to the namespace. Let's call K the namespace where the Kuadrant CR is created.
Deploy one Limitador instance in the K namespace
Deploy one Authorino instance in the K namespace
Register Authorino instance living in K in the Istio system as an external authorization service.
Deploy the RateLimitPolicy controller passing as env var the address of the limitador instance in the K namespace.
Deploy the AuthPolicy controller

When the user created a rate limit policy, the controller already knew about the Limitador's location (name and namespace) to configure it accordingly with the spec of the policy.

#109 actually implemented wiring mechanism where the gateway as well as the policies are annotated with kuadrant.io/namespace=NS. The rate limit controller no longer gets limitador endpoint address from an env var.
Using the annotation mechanism, only reading the policy, the controllers know where to find Limitador/Authorino.
This wiring mechanism has room for improvement. But good enough for now, so closing this issue.


Update MD file on new branch 2017-11-15_21-24-23

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MARXAN-545 - MARXAN-642 & MARXAN-652

Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets

Checklist before submitting

[ ] Meaningful commits and code rebased on develop.
[ ] If this PR adds feature that should be tested for regressions when
deploying to staging/production, please add brief testing instructions
to the deploy checklist (docs/deployment-checklist.md)
[ ] Update CHANGELOG file

Incudes https://github.com/Vizzuality/marxan-cloud/pull/416 & https://github.com/Vizzuality/marxan-cloud/pull/415 & refactoring application structure, with minor fixes as well.


Failure when mocking functions that are run in parallel

This test:
(ns test
  (:require [midje.sweet :refer :all]))

(defn my-func [x]
  (+ x 2))

(defn my-func-caller [data]
  (pmap my-func data))

(defn do-something []
  (my-func-caller [1 2 3]))

(fact "Test some pcalls"
  (do-something) => [2 4 6]
  (provided
    (my-func 1) => 2
    (my-func 2) => 4
    (my-func 3) => 6))

(fact "Test some pcalls 2"
  (do-something) => [2 4 6]
  (provided
    (my-func 1) => 2
    (my-func 2) => 4
    (my-func 3) => 6))

(fact "Test some pcalls 3"
  (do-something) => [2 4 6]
  (provided
    (my-func 1) => 2
    (my-func 2) => 4
    (my-func 3) => 6))

Leads to this error:
Actual: java.util.concurrent.ExecutionException: java.lang.Error: You seem to have created a prerequisite for
#'test/my-func that interferes with that function's use in Midje's
own code. To fix, define a function of your own that uses my-func, then
describe that function in a provided clause. For example, instead of this:
  (provided (every? even? ..xs..) => true)
do this:
  (def all-even? (partial every? even?))
  ;; ...
  (provided (all-even? ..xs..) => true)

It only breaks when there's more than one fact.
Changing from "pmap" to "map" on line 8 also fixes it.
Not sure how to proceed here.

In the current implementation, parallelism is just out of scope.


Bug with the Grids

Issue description: All Grids frozen
What happens: Tryining to search in the grids does nothing, the grid just stays as it is. New items thrown into the system don't apear on the grid, but the disks are filling. Still can take items out of the Grid and craft in it.  Tried to rebuild the system still doenst work. Even if just the controller and the Crafting grid ist there it shows the items in the grid. Even built a new controller and Grid, and still the same issue
What you expected to happen:
Steps to reproduce:

No idea how it happened, just simply started after i searched and crafted seconds before

...
Version (make sure you are on the latest version before reporting):

Minecraft:1.12.2
Forge:<IP_ADDRESS>27
Refined Storage:1.5.32

Does this issue occur on a server? [yes/no]
No
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

I can't do anything with bugs without reproduction steps.

hard to tell when there where no certain steps

it apeard out of the blue, the last thing i did was attach an exporter and importer to it, to get lootbags out of the system and pump the items bag in the system

Then try to reproduce and then report back. Easy as that


29344 cython stub generator

Hey @sshane, @jnewb1, @adeebshihadeh,
CythonPEG is a parser that was specifically developed for the automatic generation of Python stub files from Cython files. I forked it and implemented several changes and additions to enhance its usability and functionality. Below is the summary of its functionalities including both the original features and the ones that have been added or modified:

Object definition,
Expression definition,
Class definitions,
Function definitions,
Struct definition,
Enum definitions,
Alias definition,
Import statement definition,
External declaration definition,
Compiler directives definition,
Docstring definition,
Recursive definitions.

I've also implemented a script that utilizes this parser to generate stubs (.pyi) from Cython files (.pyx, .pxd). It has the capability to parse either all relevant Cython files within the openpilot repository or specific ones provided as arguments via the command line. I've also utilized the script to generate stubs and place each of them in a 'stubs' directory alongisde the original file. I'm looking forward to your feedback to ensure that this is something you wanted for this issue. Please let me know if there are any changes you would like me to make.
Thanks!

Diff is unreadable here. Can you gitignore the generated code so I can read the diff?

Diff is unreadable here. Can you gitignore the generated code so I can read the diff?

Hey, I ignored .pyi files, as you requested. If you want to see how they look I can post them here.

Indent is still wrong. This PR has required more review than it appears to be worth.
Feel free to open a new one once it's cleaned up and ready to go.


[Refactoring] Add refactoring action to move type members to extension

This adds a refactoring action to move selected members of a type to a new extension of that type. The extension is added right after the original type declaration.
Resolves SR-6297.
A toolchain with this refactoring action added can be downloaded here.

@swift-ci Please smoke test

Thanks for the review. I have addressed the comments. Can you have another look?
@swift-ci Please smoke test

Looking good! Merging.


Unexpected type error on hot-reload when using constructor tear-offs

Hello! Context: https://github.com/rrousselGit/riverpod/issues/1733
The reason why this error happens is a bit cryptic, so here's a reproduction example:
import 'package:flutter/material.dart';

typedef Create<T, R> = T Function(R ref);

class Base<Input> {
  Base(void Function(Create<void, Input> create) factory) : _factory = factory;

  final void Function(Create<void, Input> create) _factory;

  void fn() => _factory((ref) {});
}

class Check<T> {
  Check(Create<Object?, List<T>> create);
}

final f = Base<List<int>>(Check<int>.new);

void main() {
  runApp(MyApp());
}

class MyApp extends StatefulWidget {
  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    Future.microtask(() {
      for (int i = 0; i < 100; i++) {
        f.fn();
      }
    });

    Future.microtask(() {
      setState(() {});
    });

    return Container();
  }
}

Steps to reproduce:

start the project with flutter run
modify the source code (anything is fine)
perform a hot-reload

This will trigger the following exception:
E/flutter ( 5206): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: type '((List<Y0>) => Object?) => Check<int>' is not a subtype of type '((List<int>) => void) => void' of 'function result'
E/flutter ( 5206): #0      Base._factory (package:counter/main.dart)
package:counter/main.dart:1
E/flutter ( 5206): #1      Base.fn
package:counter/main.dart:10
E/flutter ( 5206): #2      _MyAppState.build.<anonymous closure>
package:counter/main.dart:33
E/flutter ( 5206): #3      new Future.microtask.<anonymous closure> (dart:as

This error seems to be directly related to constructor tear-offs. As changing:
final f = Base<List<int>>(Check<int>.new);

to:
final f = Base<List<int>>((fn) => Check<int>(fn));

makes the error disappear.
This error also seems to appear only after a hot reload.

Fixed in 88400bdc4249b592714fd76c61df251e212cca20.

Is there a workaround for this without upgrading to the Beta channel?

I have the following, how could I refactor it to not face this issue? It's something of a showstopper for development productivity while using the family modifier.
final blockFamilyProvider =
    NotifierProvider.family<BlockFamilyNotifier, CodeBlock, BlockWindowId>(() => BlockFamilyNotifier());

class BlockFamilyNotifier extends FamilyNotifier<CodeBlock, BlockWindowId> {
  void update(CodeBlock codeBlock) {
    state = codeBlock;
  }

  @override
  CodeBlock build(BlockWindowId arg) {
    return ref.read(blockProvider)[arg]!;
  }
}

If you want a dirty fix, have a look at https://github.com/rrousselGit/riverpod/issues/1733#issuecomment-1526076248


Consolidate create functions

It might make more sense to combine create full and create diff into a single function called create. The behavior of the app would be determined by the state of the metadata. If a new imageset (create full) is desired, then a new workspace would be specified. This would reduce cli complexity and provide a similar experience to publish.

When we add mirror2mirror support, we might need to further collapse the publish and create functions into a generic mirror subcommand: oc bundle mirror. The application should then infer which action to take given the cli flags passed and the state of the metadata.


Feature Request: User-Side Rate Limiter for Rate Limit Management in API Requests

Feature Request: User-Side Rate Limiter for Rate Limit Management in API Requests
Feature Summary:
Implement a user-side rate limiter to manage and control the frequency of requests sent to the Anthropic API. This feature would help prevent rate limit errors (e.g., litellm.RateLimitError: AnthropicException - {"type":"rate_limit_error"}) by dynamically adjusting the rate of requests based on the current usage and limit thresholds provided in the API response headers.
Problem Statement:
Currently, the application may encounter rate limit errors when the number of request tokens exceeds the daily limit set by Anthropic. This results in unexpected interruptions to agent functionality, causing users to experience downtime and delays. Users are unable to continue their workflows smoothly and are often unaware of their current usage until the error occurs.
Proposed Solution:
The solution involves implementing a user-side rate limiter that will:

Track the current request token usage by parsing the rate limit information from the response headers.
Dynamically throttle or queue requests based on the remaining available tokens, thereby preventing unexpected rate limit errors.
Provide feedback to the user (e.g., estimated time to send the next request or current usage vs. limit status) to inform them of their current API usage.

Feature Details:

Usage Tracking: Monitor the rate limit status in real time by reading the response headers after each request. Store the current request token count and limit for efficient tracking.
Adaptive Throttling: When the token count approaches the limit, reduce the request frequency to avoid hitting the daily threshold. Use an exponential backoff approach when the usage is close to the limit.
Queue Management: Allow queued requests when the limit is reached, holding them until more tokens become available.
User Feedback: Provide the user with information about the current rate limit status, including the number of remaining tokens and an estimated time for when the next request can be sent.

Benefits:

Prevents Interruptions: Avoids sudden errors by proactively managing request rates.
Optimized API Usage: Efficiently manages requests to maximize usage within the rate limit.
Enhanced User Experience: Informs users about their current usage and gives them control over request timing.

Potential Challenges:

Complexity in Queue Management: Managing queued requests efficiently may introduce additional logic for handling request timing and sequence.
Latency Considerations: Throttling may lead to slightly increased response times, but this is offset by the prevention of abrupt errors.

Thank you for bringing this up!
To address the rate-limiting issue, we could implement a queue handler that retries the last failed request after the rate limit cools down. Using the rate-limit headers provided by the API can help in setting up a structured retry mechanism. Here’s a brief outline of how it would work:
Rate-Limit Information: The following headers provide useful details for managing retries:

anthropic-ratelimit-requests-reset: This header shows when the request rate limit will reset, formatted in RFC 3339.
anthropic-ratelimit-tokens-reset: This indicates when the token rate limit will reset, also in RFC 3339.
retry-after: This provides the number of seconds until a request can be retried.
Queue Handler Logic: The handler would queue any failed requests due to rate limits and check these headers to determine when to retry. Specifically, it could use the retry-after value as a timer to trigger the next attempt, ensuring no additional rate-limit errors occur.

This setup would allow OpenHands to automatically reattempt failed requests without manual intervention, improving stability when handling bursts of requests.

Openhands has user configurable retries for rate limits. Please take a look at config.template.toml file, the relevant settings are in the [llm] section:
# Number of retries to attempt when an operation fails with the LLM.
# Increase this value to allow more attempts before giving up
#num_retries = 8

# Maximum wait time (in seconds) between retry attempts
# This caps the exponential backoff to prevent excessively long
#retry_max_wait = 120

# Minimum wait time (in seconds) between retry attempts
# This sets the initial delay before the first retry
#retry_min_wait = 15

# Multiplier for exponential backoff calculation
# The wait time increases by this factor after each failed attempt
# A value of 2.0 means each retry waits twice as long as the previous one
#retry_multiplier = 2.0

You can customize them in the config.toml file, or, if you're running with the docker app, you can add them with -e and the corresponding env var (uppercase, and with the LLM_ prefix). For example, -e LLM_RETRY_MIN_WAIT=20.
What we don't currently do, is read the API headers and adapt to them. We just do what you configure there.
I think we should, and we have a PR on it, but we haven't got it to work well yet.


Add "set" as a basic type in Calc

This would be implemented (probably) as  LinkedHashSet. Operations TBD.
As for syntax, I was thinking that [! ... !] would work in the sense of "exclusive list" or list that only contains one of each element.  There are no other suitable single char pairs (now that <> is "not equal" and '<' and '>' are themselves operators).

Another syntactic option, though maybe more confusing, would be to use { a, b, c } as a set, while (as at present) an object would still be { a:v1, b:v2 }  Could the grammar handle this?

Using { } or the Unicode "empty set" symbol leaves an amibiguity: the syntax for empty set and empty object are the same. This can be worked around, but it is a royal pain! However, it appears that there is no problem in the grammar using { } for sets as well as objects.
There are a LOT of changes necessary to deal with sets in all the appropriate places (i.e., where arrays and objects are already dealt with), plus the operations specific to sets (as in "union", "intersection", "set difference", etc.).
splice is difficult also, because there is specific syntax for arrays vs. objects, but now (probably) needs more syntax for sets.


[EXT-SEC-AUDIT] Quantity arithmetic is not thread safe

Issue transferred from an external security audit report.

Severity: Informational
Type: Timing
Target: go/common/quantity/quantity.go
Difficulty: Undetermined
Finding ID: TOB-OL-101
Description
Arithmetic on arbitrary precision non-negative integers is encapsulated in the quantity
module and used throughout the codebase for a number of calculations. Functions
operating on Quantity take the data as pointers and mutate it. Due to the shared mutable
state, it is possible to corrupt the state in a multithreaded scenario when arguments to the
quantity arithmetic are closed over multiple goroutines. An example of function which can
lead to state corruption can be seen on Figure TOB-OL-101.1. The n variable might change
on another thread between Sub and Add function calls, corrupting the balance. The code
uses Clone to prevent the same state to be mutated however this is a manual process
which can be error prone.

Figure TOB-OL-101.1 shows https://github.com/oasislabs/oasis-core/blob/f331a877721f44cc2412b4248d66e95f83f4cf9c/go/common/quantity/quantity.go#L216-L229

Exploit Scenario
An Oasis developer mistakenly writes code which shares data between quantity
computations. The execution corrupts the balance and causes a network fork due to
concurrency non-determinism.
Recommendation
Short term, modify the quantity module to use copied data instead of pointers.
Long term, avoid mutable state unless it is necessary.

Due to the shared mutable state, it is possible to corrupt the state in a multithreaded scenario when arguments to the quantity arithmetic are closed over multiple goroutines

There should be no concurrency inside the ABCI application. And even if there was, forcing a mutex on every Quantity seems wrong -- the caller should be responsible for that. Note that the same applies for Go runtime's big.* types which take pointers for all operations.
If anything, we should mention that Quantity is not safe for concurrent use.


Test with OpenOffice

Step 1: Adding jar to Libre Office

Open Libre Office
Go to menu > Tools > Options
In the new window, select in the tree  LibreOffice > Advanced
Click on the button Class Path button
Click on Add an archive and select the JDBC driver

Step 2 : Create a Neo4j database

Create a new database and choose the JDBC connection

Fulfill the datasource url and the driver class

Fulfill the username and test the connexion

Save your new LibreOffice database

Step 3: Make some queries

Click on Queries tab, and after on Create a query in SQL mode ...
The SQL editor should appears.  To allow you to make some Cypher queries, click on the button SQL (otherwise LibreOffice try to make a SQL validation of your query)
Make a query and execute it !


[BEAM-11092][Go SDK] Ack Harness monitoring requests

Respond to Harness Monitoring instructions with all the harness metrics currently in the Go SDK. (None).
This avoids potentially noisy logs from an unknown instruction. Metrics to be added at a later time.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


update documentation fxp/composer-asset-plugin to version ~1.1.2

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

This change doe snot make sense. Original requirement of ~1.1.1 includes 1.1.2 already.

Last time we updated requirement from ~1.1.0 to ~1.1.1 because v.1.1.0 was broken after changes in Composer.
As far as I see, there are no critical changes in 1.1.2 to increase minimum version


(feat): External Paging

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Disabling client-side-sorting is only possible by changing the comparator for each column
What is the new behavior?
Client-Side-Sorting can be disabled by using the externalSorting input
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
See issue #170

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


How to perform a least squares approximation with MFEM

Hello,
I would like to perform a least squares approximation of a function f, within a FEM framework.
This is an extension of a polynomial regression over a set of points.
The idea is to minimize the global classical squared error of least squares, which is based on the local error (difference between f and its FEM approximation) integrated over the all domain.
Differenciation of the global error provides a set of linear equations with unkowns corresponding to the FEM DoFs.
I tried to set up the linear system by hand, using a BilinearForm for the matrix, and a LinearForm for the RHS. The LinearForm corresponds to the integral of the function f (to be approximated) and the basis function associated to one DoF.
I managed to solve the linear system, but it appears that my solution on each DoF is exactly equal to the provided f function. So at the end, I just get a kind of FEM interpolator: the solution on each node is exactly equal the provided function, and I can interpolation in between.
This is not a "best" approximation in the sense of an average through an integral of f on each element. Looking more precisely at the LinearForm, I give the function f as a FunctionCoefficient. So I think that during the integration (rule) process, f is only evaluated at integration points, and the quadrature order is the same as the basis function order on each element. So even if my function f is very complexe, or oscillating, I just get a p-order approximation on each element, and the information on f is "lost" during integration.
Am I right?
And if I want to increase the accuracy on the integration of f on each element (for my RHS), what would you suggest to do? Increase the order of the test space?
Thank you
Pierre

Hello @pmguilcher,
If I understand correctly, what you want to do is equivalent to the L2 projection of the function f onto your finite element space (i.e. find the element u of your space V such that the L2 norm of (u-v) is minimized).
This can be accomplished by solving the system Mu = b, where M is the mass matrix, and b is the RHS you describe. As you mention, the RHS is computed using quadrature, and if your function f is very complex, it may require a quadrature rule with a high degree of precision to integrate accurately.
You can try something like the following:
// Given finite element space `fespace`, construct the mass matrix
BilinearForm m(&fespace);
m.AddDomainIntegrator(new MassIntegrator);
m.Assemble();
m.Finalize();

// Define an integration rule for the RHS
int quadrature_precision = 10;
Geometry::Type geom = mesh.GetElementGeometry(0);
const IntegrationRule &ir = IntRules.Get(geom, quadrature_precision);

// Make a "coefficient" given the function `f`
FunctionCoefficient f_coeff(f);
// Create the right-hand side
LinearForm b(&fespace);
b.AddDomainIntegrator(new DomainLFIntegrator(f_coeff, &ir)); // <-- here we give the integration rule to the RHS integrator
b.Assemble();

GridFunction x(&fespace);
x = 0.0;

SparseMatrix &M = m.SpMat();
DSmoother D(M);
PCG(M, D, b, x, 1, 200, 1e-12, 0.0);

Hello @pazner
You understood well! Indeed, I performed my least squares (or projection) approximation through the mass matrix.
I tried your solution, and it works very well.
Thank you so much for your help.
Pierre

Hello,
let me extend the question a bit more. Consider a function f which looks for some neighbourhood points around an actual point (integration point) in some point cloud representing discrete values of a scalar field and makes interpolation from those neighbourhoods. How this can be implemented with FunctionCoefficient?

let me extend the question a bit more. Consider a function f which looks for some neighbourhood points around an actual point (integration point) in some point cloud representing discrete values of a scalar field and makes interpolation from those neighbourhoods. How this can be implemented with FunctionCoefficient?

The best way to implement what you describe probably depends on the specifics of your problem. It is definitely possible to construct such a Coefficient, but FunctionCoefficient is not the right way to do it. FunctionCoefficient is usually designed for functions that are evaluated pointwise (e.g. using analytical formulas).
Perhaps you could use QuadratureFunctionCoefficient or something similar. If it is unclear how to proceed, feel free to open an issue with the details of your problem.


Feature/robot  app selection changes

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

Closing; @skristem says this was for testing and is no longer needed.


[Bug?]: CSS module styles injected after hydration; in dev?

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When using CSS modules, so
// text-field.tsx
import styles from './style.module.css';
const TextField = (props) =>
<input class={styles.input} />

const SomeRoute = () => {
  return (

    <TextField label="Field label" placeholder="Enter something" />

)
}

The TextField styles chunk is not included in the initial HTML, it's loaded lazily after the component is rendered.
See isolated example with text field:

I also see the warning form Seroval(?) when using CSS modules:

Expected behavior 🤔
CSS used for the elements on first render pass is included on the page (as inline styles or separate CSS file in prod env).
Steps to reproduce 🕹
Steps:

Create a component that uses CSS modules.
Use it in a route (maybe createAsync usage is required to reproduce).
See that while component is indeed rendered in the initial HTML on the server, its styles are not included.
This leads to flash of unstyled content.

Context 🔦
No response
Your environment 🌎
Node 20
Vite 5.0.10
vite-plugin-solid 2.8.0
vinxi 0.0.54
solid-start 0.4.2
solid-js latest

I see this too. Just to add to the repro steps, in the basic template changing the Counter.css to a css module Counter.module.css will trigger the warning

Yeah seems like our Module CSS handling is insufficient. Filing this issue in vinxi where it will need to be fixed.

Should be fixed in<EMAIL_ADDRESS>please try that and reopen this issue if it still doesn't work.

I tested it and it works. Thanks

Hmm I'm seeing this behavior now, on a new "bare" project scaffolded. Vinxi I have is 0.3.10
Looking at the SSR page source, it looks like the  tags with the styles are not being send down from the server.


Sensu server registry & API /info improvements

Description
Create and update a Sensu server registry. Expose Sensu server information via the Sensu API /info endpoint.
Related Issue
https://github.com/sensu/sensu/issues/1027
Motivation and Context
Exposes information that makes it easy to troubleshoot certain issues.
How Has This Been Tested?
RSpec and manual testing.
Screenshots:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Need to update /info specs.

HAWT!!!!!!!!!

👍

Looking for to it 👍


Docs 404

https://hexdocs.pm/sptfy/
Published but 404. I have no idea why.

now 200 🆗

now 200 🆗


success rate calculation

Hello, I ran the command for replicating results in your repo, but failed to find successs rate in the  exp_logs folder. Could you share with us how to get the success rate?

The experiment, if running successfully, will create two layers of subdirectories under your LOCAL_LOG_DIR  (described here). In the deepest subdirectory corresponding to your exp run, you will see a progress.csv file with a column named eval/env_infos/final/rewards Mean which will contain the success rates you are looking for. Each row is the value of that column metric for a given epoch number.
Note that the eval is only run every 10 epochs, so when plotting it, a lot of the eval metrics will look like "step functions" that only update every 10 epochs.

Do you mean column N ? After 300 epochs this value ends up being 0.02696. But I don't see how that can be related to the success rate. THis is the result of scenario A with CNN as demo encoder, miniLM as language encoder.

Not quite column N, since that is the total reward over the entire trajectory, instead of showing the proportion of trajectories that succeeded on the last timestep. If you don't have a column called eval/env_infos/final/rewards Mean, could you make sure you are on the latest commit (with the May 29 update)?

OK I see, I'll try with the latest update. Thanks for helping.

marking as resolved!


PWA implement update worker

Implement a PWA update worker & update prompt

closed with https://github.com/r2binx/heimboard/commit/e078fadc263cc2635d019c2c3fbbaed9429ab5a8


Model shifts vertical position after exiting scene viewer

Description
On my pixel 2 Chrome browser, after exiting scene viewer and returned to the website, the model would shift downward from center position.

Live Demo
https://googlewebcomponents.github.io/model-viewer/examples/augmented-reality.html
https://glitch.com/~storm-list
Browser Affected

[x] Chrome
[ ] Edge
[ ] Firefox
[ ] Helios
[ ] IE
[ ] Safari

OS

[x] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

Versions

model-viewer: vX.X.X
three.js: rXX

Confirmed, thanks for reporting!

Seem like the component is not handling resizes correctly.
I've put together a test where I'm resizing a viewer every frame:
https://model-viewer-tests.glitch.me/resize.html
The model should be visible and in the center all the time.

After further testing, horizontal resizing works as expected.
It's after vertical resizing when the component misbehave.

After further testing, horizontal resizing works as expected.
It's after vertical resizing when the component misbehave.
https://model-viewer-tests.glitch.me/resize-vertical.html

It's glitchy when resizing horizontally though.
https://model-viewer-tests.glitch.me/resize-horizontal.html

I think the vertical alignment issue only affects master, not the latest release (v0.3.1)
@mrdoob it's possible that the horizontal glitchiness is another issue that is exacerbated by the worst case scenario resize on every frame. We try to debounce the response to resize, so there might be a bug related to that as well.

I think the vertical alignment issue only affects master, not the latest release (v0.3.1)

/cc @elalish

I just finished a git bisect. Looks like the first bad commit was actually the r104 upgrade https://github.com/GoogleWebComponents/model-viewer/commit/5c4e0ebd4ca78124f804201b108c2544ac578cb3 🤔

This may solve the glitchyness:
https://github.com/GoogleWebComponents/model-viewer/pull/536#discussion_r281711489

We do set the render target back to its original value, it's just a few lines down from there

@mrdoob the vertical offset is pretty mysterious to me. I traversed the scene, and everything is positioned correctly. The camera is getting updated correctly. All our stuff to set the viewport and resize the renderer is the same, and seems to be using the right values.
Do you know of anything that might have changed between r101 and r104 in WebGLRenderer that might be relevant?

We do set the render target back to its original value, it's just a few lines down from there

Ah, I see.

The fix is actually simple, if you go to this line.
You have to had something like:
context.drawImage(
          this.renderer.domElement,
          0,
          this.height - height,
          widthDPR,
          heightDPR,
          0,
          0,
          widthDPR,
          heightDPR);

The problem comes from the fact that the renderer main framebuffer is not resized to the current viewer size for optimization purpose.

@DavidPeicho thanks for the feedback.
I've made a reduced reproductions of the problem that demonstrate that this new behavior was introduced in r102. Try these repros out and note that on resize, r101 works as we expect and r102 does not: r101, r102.
I appreciate that this may be a change that was made in the name of optimization, but we are explicit when sizing the viewport via Three.js' public API. Shouldn't that make a difference here?
On the other hand, the notion of the "viewport" is pretty vague according to Three.js' docs, so maybe I misunderstood what it is.
At any rate, it looks like this change took place between r101 and r102. Can you or @mrdoob point me to the PR for the relevant change?

@cdata For me, the problem is linked to the drawing coordinates of WebGL vs Canvas.
Canvas: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawImage
OpenGL / WebGL: https://learnopengl.com/Getting-started/Textures
Calling setViewport sets the viewport for sure, but if the framebuffer isn't at the same size of what you are drawing, you will still draw at a different place that you expected relative to the DOM element.

@DavidPeicho Thanks! I'll take a look.

Can either of you share the related PR where this change occurred?

We write change logs for every release. Please, search for "viewport" in that page.

Yes, the problem is related to [that](Make .setViewport(), .setScissor() relative to lower-left corner. #13593 (@WestLangley)).

Thanks!

It's probably this one. I'll test @DavidPeicho's suggestion.

For me, the problem is linked to the drawing coordinates of WebGL vs Canvas.

Thanks @DavidPeicho . Now that I have had a change to read the PR it makes a lot of sense.

Team work 💯

Okay, this took quite a while to figure out but https://github.com/GoogleWebComponents/model-viewer/pull/555 fixes the glitch/flashes when resizing.
https://model-viewer-tests.glitch.me/resize.html
https://model-viewer-tests.glitch.me/resize-horizontal.html
https://model-viewer-tests.glitch.me/resize-vertical.html


place concepts in etc/concepts.csv

Concepticon links are currently in json, they will be easier to check if added to etc/concepts.csv

I can take care of this - ok @SimonGreenhill ?

Hm. Guess we have to decide whether we want flexibility in concepts - i.e. the tng site can add new concepts and they will show up in the lexibank dataset after download, or whether the list is fixed - in which case it should rather go into concepticon right away, and not just in etc/concepts.csv?

I think it depends on the status of the concepts as a list themselves. Since TNG was conceptualized as an open-ended project, the concepticon links were then provided later on as a service, but not necessarily as something meant to be ever exhaustive. Individual subsets of the datta could be linked to concepticon, but not TNG itself, I'd say. Similarly, we would not link STEDT entirely to concepticon, right?

Ok, that's how I understood as well. But then the question is whether the tng site itself takes care of curating the concepticon links or whether that should be a service added in the lexibank dataset. If the former, we shouldn't add a full concepts.csv (maybe a short one to fix errata, though?), if the latter, yes, then the links should be in concepts.csv.

You're exactly right: we could say: this is TNG's responsibility, so it does not have primarily to do with lexibank. Maybe easiest way to handle this, I was just thinking, people from our calc group (including me), might throw a quick eye on the mappings, but it's not convenient from json of course...

I like the idea of tng.org maintaining the mapping itself -- that feels more natural to me? Given that it's not a standardised list, including it directly in concepticon seems odd as well.
I would love it if the CALCies could have a look at the mappings. I can easily make a table if you'd like.

Okay, that would be excellent. In fact, I saw that we actually HAVE one here: https://github.com/lexibank/transnewguineaorg/blob/master/cldf/parameters.csv
So no need to have the table for visibility even, I'll ask all calcies to have a look.

I should probably be involved, remember I did the Z'graggen Madang dataset/concept list (which is part of TNG, right?): https://concepticon.clld.org/contributions/Zgraggen-1980-380

I just assigned all calcies, so yes, @tresoldi, you are involved, and if you want to organize this amog the calcies, this would even be better

But we can close this issue now, I'd say.

Yes, we are on it and I'll organize.

I am reopening the issue, and just pushed an initial Concepticon mapping: https://github.com/lexibank/transnewguineaorg/blob/master/etc/concepts.tsv
This mapping should help TNGorg as an organization (I agree that they should maintain an initial mapping, as this list is clearly mixing different concept lists), but it should also be enough to get started with testing lexibank integration: 909 concepts are now mapped (74%), some wrong mappings were corrected, and new items (such as those I added in the past to Concepticon related to Z'graggen's Madang and Robinson's Alor-Pantar) were linked. I also included a column with some comments of my own (especially in terms of concepts that should be added to Concepticon, from my experience with the aforementioned datasets and others for Timor languages) and collected the unique annotations for each concept when available, separating them with slashes.
The next step would be for @laiyunfan , @MacyL and @Schweikhard to review my work -- you can decide how to do it (or just split in three parts) and I can help you explain some harder concepts.
For @SimonGreenhill , which I hope has access to all sources, two questions on items I was unable to map:

Item 69 has barl-noun, with the single source of Scott (1978). I have no idea what a "barl" could be, and given that this is annotated as a (noun) and is similar to bark (which not only has an edit distance of 1, but likewise a "keyboard distance" of 1 for L/K), @Schweikhard and I assumed it is probably a typo for "bark" as in "tree bark".

Items 666 and 667 are pubic nut and pubic shell. Again, no idea what these could be, but it sounds a lot like a "testicle" and "scrotum" pair.

Could you check your sources for those two? Besides taking a look at the concept list itself, of course.

I will have a look as soon as possible :)

This mapping should then be used to improve directly the mappings to Concepticon on TNG, right?

It is mostly @SimonGreenhill 's decision, but I suppose so. Still, we could use this for an initial workflow of integrating TNG data into lexibank, if so decided.

I guess, this was the agreement we had in this thread: TNG provides mappings, not lexibank, so @SimonGreenhill could take the mappings in etc/ and integrate them in TNG, and they'd be then deleted from lexibank again, right?

To be clearer: TNG should have one concept list per source, which could be used to compile raw data for lexibank (so that issues like areca- and betel-nut are fixed). These per-source concept list could very well be pre-populated from this mapping I provided, and the file itself could be trimmed down with time in order to become a common lexibank concepts.csv file.

Wait, in our discussion wiht @xrotwang we decided to have NO concepts.tsv file, as we said that TNG itself provides the mapping,s so we take them from there, right? This was the main discussion in this thread. If we link individual lists in TNG to concepticon, this is another story, and then one could make separate datasets, etc., but for now, this is unrealistic, but the concept list you provide could of course help in further development.
@SimonGreenhill, if you follow those change proposals, will it be quick to ingetrate them into TNG?

I was thinking of a local concepts.tsv to fix errata (as @xrotwang mentioned) or to collapse different TNG "concepts" into a single Concepticon concept, or just to select which one to map and which to skip over (like in the case of the multitude of palm trees). But doing so now is not realistic, as you say.
As for keeping the list here until TNG implements it, or move it right away to TNG, I'm fine with both. We can always revert the decision if necessary. :wink:

Thanks all, working through this now.
Re: "barl-noun" -- I've checked, this is "bark (noun)" which has now been fixed.\
Re: 666, 667 pubic nut and pubic shell, these are probably penis sheathes rather than the actual body parts themselves
Re: TNG and mappings -- yes, I'll update the mappings directly in tng.org.
Re: one dataset per source -- that is probably a discussion for another issue: see #5

So, no "barl"! It is going to be part of my list of words looking for a meaning, like dord.
As pubic nut and shell, I've already mapped 360 gourd-mans to PENIS SHEATH; it might be one more case where different lists are at play (as in #5 )

Thanks all, the concepts have been updated in tng.org


drag & drop: e.Data.GetDataPresent(DataFormats.StringFormat) does not return True while it should

In the following step of the walkthrough: To process the dropped data the first if-statement returns false when dropping the selected text "green" on the circle.
When debugging I added the following to check if the data was included in the DataObject:
         var color = e.Data.GetData(DataFormats.StringFormat);
This does return the string "green" (type: System.String). Yet the next line returns false:
if (e.Data.GetDataPresent(DataFormats.StringFormat))
This was a one on one copy of the steps in the walkthrough.
The project is using the following target framework:
<TargetFramework>net5.0-windows10.0.18362.0</TargetFramework>
Thank you in advance for your time.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23f605d0-6326-17d5-3087-4f6ef96ab9bb
Version Independent ID: 10411c7d-3586-4904-6d4f-79e84f0c9b98
Content: Walkthrough: Enabling Drag and Drop on a User Control - WPF .NET Framework
Content Source: dotnet-desktop-guide/framework/wpf/advanced/walkthrough-enabling-drag-and-drop-on-a-user-control.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @adegeo
Microsoft Alias: adegeo

@rubend30 Hi there! Sorry for the delay. We had a holiday yesterday and I wasn't available. I tried a simple test to just make sure it works as it should with a data object:
DataObject data = new DataObject();
data.SetData(DataFormats.StringFormat, "green");

var color = data.GetData(DataFormats.StringFormat);
if (data.GetDataPresent(DataFormats.StringFormat))
{
    System.Diagnostics.Debug.WriteLine("data was present");
}

And it does see the string data. Can you share more code? You must be setting something incorrectly in the drag events, or perhaps there is a bug in the article code, but I can't spot one.

Hello
When looking at the GIF in your answer I see that the class used is for System.Windows.Forms.DataObject but when looking at my code I have the System.Windows.DataObject class. (WPF vs. WinForms?)
I have added my project as an attachment for you to check.
DragAndDrop.zip
Below is a GIF of my debugging results:

Whoops yeah! I thought it was a generic data object, not tied to a UI system. HA! I'll look at it some more :) Can you paste your code that sets the data?

Hello
There is no code needed/provided in the walkthrough for this. I guess it is a build in functionality that when a user selects text from a TextBox that the DataObject gets set with the selected text.
There is a setData when the user presses the mouse on the circle itself but nothing for the TextBox
        protected override void OnMouseMove(MouseEventArgs e)
        {
            base.OnMouseMove(e);
            if (e.LeftButton == MouseButtonState.Pressed)
            {
                // Package the data.
                DataObject data = new DataObject();
                data.SetData(DataFormats.StringFormat, circleUI.Fill.ToString());
                data.SetData("Double", circleUI.Height);
                data.SetData("Object", this);

                // Inititate the drag-and-drop operation.
                DragDrop.DoDragDrop(this, data, DragDropEffects.Copy | DragDropEffects.Move);
            }
        }

But this is not even triggered (and shouldn't) when you drag the text on the circle. Can you test the project I attached in a previous message?

OH, whoops. I didn't even notice the project you attached, yes, I'll check it out!

I swapped the target framework to .NET 4.8 and it works as intended. This is a bug with .NET 5 :( I'll transfer this issue.

Oh duhhh.. This whole time I've been thinking this is familiar. That I've run through this before, but I thought it was on winforms. Turns own it was already reported! They've said it will be fixed in 6.0. https://github.com/dotnet/wpf/issues/3965

Duplicate of #160