feat(api): specify blowout_location for transfer + consolidate + distribute commands

Overview
As an OT-2 user, I would like to be able to utilize APIv2 to write my protocols that support specifying the blow location.
Acceptance criteria

User shall be able to specify in their protocol to blowout in trash or specified wells in a given labware
-The 3  transfer, consolidate, and distribute fns need to accept a new parameter that allows you to specify where to blow out called blowout_location.
Allowed values for blowout_location should be the: 'trash', 'source well', and 'destination well'
If blowout_location is specified but blowout=False, then the new blowout_location parameter is ignored and has no effect.
If blowout=True but blowout_location is not specified, the location defaults to 'destination well' (this should match existing APIv2 behavior)

Related
This ticket may indirectly address #4940 (?)

Blocked pending decision on reqs. See https://opentrons.slack.com/archives/CSCLVUW3C/p1601392745003300


Game/server crashes breaking hyperbox containing a ME controller from AE2

Minecraft version: 1.20.1 forge 47.2.0
Mod version: <IP_ADDRESS>
how to reproduce:
download AE2 and hyperbox mod
make a hyperbox
enter the hyperbox
place ME controller (AE2)
exit hyperbox
break hyperbox

Which version of AE2?
Can you show the crash log?

Which version of AE2?
Can you show the crash log?

AE2 15.0.15
I can’t get on my PC right now but when I’m able to get on to get the crash logs, I will

One other thing I forgot to add is you need to have the me controller powered (still not at a pc so still can’t share logs)

crash-2023-12-10_21.26.44-server.txt
Forge Version: 47.2.0
Mods: AE2, Mekanism, Hyperbox
setup:

After unloading the dimensions by breaking the hyperbox. The game proceeds to crash attempting to do something with transfering energy from a non existent entity
On top of that, it doesnt have to be just mekanism cables. Any FE energy cables can replicate that issue.

Does it crash with the aecapfix mod?
https://www.curseforge.com/minecraft/mc-mods/aecapfix

Closing -- resolved by installing aecapfix


[MSL] SPIRV-Cross emits undefined behaviour for OpShiftLeftLogical

Consider the following shader:
; SPIR-V
; Version: 1.3
; Generator: Khronos SPIR-V Tools Assembler; 0
; Bound: 15
; Schema: 0
               OpCapability Shader
               OpMemoryModel Logical GLSL450
               OpEntryPoint GLCompute %1 "main"
               OpExecutionMode %1 LocalSize 1 1 1
               OpDecorate %_struct_2 Block
               OpDecorate %3 DescriptorSet 0
               OpDecorate %3 Binding 0
               OpMemberDecorate %_struct_2 0 Offset 0
       %void = OpTypeVoid
          %5 = OpTypeFunction %void
        %int = OpTypeInt 32 1
  %_struct_2 = OpTypeStruct %int
%_ptr_StorageBuffer_int = OpTypePointer StorageBuffer %int
%_ptr_StorageBuffer__struct_2 = OpTypePointer StorageBuffer %_struct_2
      %int_0 = OpConstant %int 0
     %int_n1 = OpConstant %int -1
      %int_2 = OpConstant %int 2
          %3 = OpVariable %_ptr_StorageBuffer__struct_2 StorageBuffer
          %1 = OpFunction %void DontInline %5
         %12 = OpLabel
         %13 = OpAccessChain %_ptr_StorageBuffer_int %3 %int_0
         %14 = OpShiftLeftLogical %int %int_n1 %int_2
               OpStore %13 %14
               OpReturn
               OpFunctionEnd

It is seemingly valid in SPIR-V to apply an OpShiftLeftLogical to a negative base:

spirv-cross emits the following MSL:
#include <metal_stdlib>
#include <simd/simd.h>

using namespace metal;

struct _2
{
    int _m0;
};

kernel void main0(device _2& _3 [[buffer(0)]])
{
    _3._m0 = (-1) << 2;
}

This is an undefined operation as demonstrated by running the Metal validation layers:
interesting_shaders/right_shift_UB_msl.metal:13:19: warning: The result of the left shift is undefined because the left operand is
      negative
    _3._m0 = (-1) << 2;
             ~~~~ ^
1 warning generated.

This is a fuzzer-found bug using SPIRVSmith

This seems needlessly nitpicky. Is this actually undefined, or is just pedantic C89 behavior that has been inherited? There are similar cases with right shift logical that works fine on any compiler, but it's still undefined in C (which Metal inherits from).

@HansKristian-Work it's actually a bit unclear. I can't find anything about shifting introducing UB in the Metal spec. The Metal validation layers complaining about it might very well be due to behaviour inherited from C.
I don't know what's the course of action here for SPIRV-Cross since the spec and the validation layers seem to diverge. I'd err towards following the spec but I'll submit a ticket to the Metal bug tracker to clarify this behaviour.


[Windows] availability of _create_locale() function

I was trying to update my curl setup with OpenSSL 3.0.3 lib,  but was prompted of unavailability of _create_locale() function
as it seems _create_locale() function is available from windows 8...
What I can do for OS before - W7 and XP?

Does #18241 fix your issue?

BTW this function is not a system function but a function that is from MSVCRT.dll so it is not really depending on the system version but the Visual C runtime environment version installed.

I tryed configure openssl-3.0.3 with -DOPENSSL_NO_LOCALE, but it not worked - _create_locale() function is found in ctype.c and fipsprov.c and guarded with:
ifdef OPENSSL_SYS_WINDOWS
loc = _create_locale(LC_COLLATE, "C");

else
loc = newlocale(LC_COLLATE_MASK, "C", (locale_t) 0);

endif
i cannon find option OPENSSL_NO_LOCALE in sources of openssl-3.0.3 version
also - on my system _create_locale() function is not located in MSVCRT.dll, but in msvcr120.dll library and not getting picked up from there for some reason

i cannon find option OPENSSL_NO_LOCALE in sources of openssl-3.0.3 version

I am sorry I mislead you. You'll also need to apply the fix from https://github.com/openssl/openssl/pull/18241 in addition to using -DOPENSSL_NO_LOCALE.

Thanks! After appling #18241 everything works ok!


[sqlserver] Add option to aggregate azure sql database into one db host

What does this PR do?
This PR adds a new config option azure.aggregate_sql_databases to group multiple azure sql databases into one logical SQL Server database host.
Prior to this change, Azure SQL databases are monitored and reported as independent database instances due to the it's network isolation between databases. With the new config, user has the option to continue monitor Azure SQL databases independently but have them aggregated into one single database host in DBM.
This is an opted in option and not enabled by default.
Motivation
https://datadoghq.atlassian.net/browse/DBMON-4762
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

When azure.aggregate_sql_databases is set to true, user will see on database host in DBM with all monitored Azure SQL databases reports under the single database host.


drools-karaf-features: update cxf-specs version range to support Fuse 6.2

the commit needs to be cherry-picked into 6.2.x as well

We need to investigate if we still need to depend on the cxf-specs. For now the safest thing seems to be just updating the version range.


🔧 Changed my GitHub nickname, please update reference at 📇 README.md

Hello, can you please 🔧 change my profile link from 🐲 old to the 🎉 new one. Thanks

Done 🎉


Interceptor/Refresh in AoT (ng-cli)

Angular Version : 2.3.1
Problem : I'm trying to do a refresh request when my token expired but doesn't know where to do the request and put the interceptor. As far as i understand, it's part of the configuration so it should be in my app.module. But I can't execute a Restangular request inside the Config function ?
I'm a bit lost with this way of setting the configuration.
export function configFunc (RestangularProvider, http) {
  RestangularProvider.setBaseUrl('http://localhost:8888/v1');

  // I check before if there is a currentUser token available.
  let currentUser = JSON.parse(localStorage.getItem('currentUser'));
  if (currentUser && currentUser.token) {
    RestangularProvider.setDefaultHeaders({'Authorization': 'Bearer ' + currentUser.token});
  }

  // This is where i should request my refreshed token
  let refreshAccesstoken = function () { /* function here*/};

  // Provided exemple of interceptor inthe README
  RestangularProvider.addErrorInterceptor((response, subject, responseHandler) => {
    if (response.status === 403) {
      refreshAccesstoken()
        .switchMap(refreshAccesstokenResponse => {
          return response.repeatRequest(response.request);
        })
        .subscribe(
          res => responseHandler(res),
          err => subject.error(err)
        );
      return false;
    }
    return true;
  });
}

@NgModule({
    imports: [
      ...
      RestangularModule.forRoot([Http], configFunc),
    ]
...
})
export class AppModule { }

So basically i'm trying to do a simple post like this, but I don't know where to put the interceptor and the refresh function.
Restangular.one('token').post('refresh',{
      'refresh_token' : currentUser.refresh_token,
    })

Any idea how to solve this ?

I think that will solve your problem.
You can make all needed actions in this function.
let refreshAccesstoken = function () {
  return http.post("params to refresh access")
};

you can`t use restangular there now, we working on this.

Ok i'll do a simple HTTP.post for the moment, i'll wait new release, thanks.

Can´t you just use a customPOST for now?


Is that a bug?

What happened
can not run with a simple example
Stack trace

Steps to reproduce

pom.xml     <dependency>
         <groupId>com.swmansion.starknet</groupId>
         <artifactId>starknet</artifactId>
         <version>0.6.0</version>
     </dependency>

StarknetMain.javapackage test;

import com.swmansion.starknet.account.Account;
import com.swmansion.starknet.account.StandardAccount;
import com.swmansion.starknet.data.types.Call;
import com.swmansion.starknet.data.types.Felt;
import com.swmansion.starknet.data.types.InvokeFunctionResponse;
import com.swmansion.starknet.data.types.StarknetChainId;
import com.swmansion.starknet.data.types.transactions.TransactionReceipt;
import com.swmansion.starknet.provider.Provider;
import com.swmansion.starknet.provider.Request;
import com.swmansion.starknet.provider.rpc.JsonRpcProvider;

import java.util.List;
import java.util.concurrent.ThreadLocalRandom;

public class StarknetMain {
public static void main(String[] args) {
     Felt address = Felt.fromHex("0x0468b7AdAE55BE128D1e10D13075A0FFF7e1941014F1C0aC780a35D51658965E");
     Felt privateKey = new Felt(ThreadLocalRandom.current().nextLong(1, Long.MAX_VALUE));
     // tag: replace with rpc url
     Provider provider = new JsonRpcProvider("", StarknetChainId.TESTNET);
     Account account = new StandardAccount(address, privateKey, provider);

     Call call = new Call(Felt.fromHex("0x06f437b6624d8bb9455eedfb26fa99b8267846a05ed2d7f6a03710106f94fcac"), "mint", List.of(Felt.fromHex("0x0468b7AdAE55BE128D1e10D13075A0FFF7e1941014F1C0aC780a35D51658965E"), new Felt(1000)));
     Request<InvokeFunctionResponse> executeRequest = account.execute(call);
     InvokeFunctionResponse executeResponse = executeRequest.send();

     // Make sure that the transaction succeeded
     Request<? extends TransactionReceipt> receiptRequest = provider.getTransactionReceipt(executeResponse.getTransactionHash());
     TransactionReceipt receipt = receiptRequest.send();
     System.out.println(receipt);
 }

}

Run the main method
Got error as the stack trace shown above
Decompile Felt.kt, and I did find that it is annotated with @Serializable. Since I'm not familiar with Kotlin, I'm unsure whether it is a bug. If it's not, how can it be resolved?

SDK Version
jdk: corretto-17
Language
Java
Language
n/a
Language version
17
What operating system are you using?
Mac
Is there an existing issue for this?

[X] I have searched the existing issues and verified no issue exits for this problem.

And also, I found that InvokeTransactionPayload in TransactionPayload.kt is lacking some fields according to the JSON RPC defined in starknet_write_api. Is this library still in experimentation and not stable, even with releases such as v0.6.0?

It's only support invoke trasaction v1 and yet invoke transaction v0 is not supported? unsure if is I'm using the wrong starknet-jvm version which is v0.6.0
from TransactionPayload.kt

from starknet-spec/api

Hey, I'll take a look at it

Regarding the version of InvokeTransactionPayload, version 0 is deprecated and that's why we only support version 1.
https://docs.starknet.io/documentation/architecture_and_concepts/Blocks/transactions/#invoke_transaction

If that's not the case, what Felt format your rpc node uses? 0x or 0x0 prefixed?


Fix for secondary window's not respecting app's theme.

Summary of the pull request

Fixes issue where the secondary windows do not respect the app's theme when its set in the Dev Home settings page. Without this fix the secondary windows continue to keep the Windows system theme, and change when the system theme is changed. For example if Dev Home's theme was set to light theme in the app, but the system theme is dark theme, the secondary window will be in dark theme. Now with this fix, the secondary windows respect the theme set by Dev Home, whether that be light, dark or windows default.
Fixes secondary window's titlebar  flickering between the Windows default titlebar and our custom titlebar when the window activates.
Fixes issue where secondary window is not using a background, and thus appearing to be transparent.

here is a video of how the secondary window works with theme changes after this change.
https://github.com/microsoft/devhome/assets/105318831/06f2f58f-47b6-4962-b3fa-6b51dfe1ca05
References and relevant issues
Notice in this video at the end, the last time I close and relaunch the Dev Drive window, the minimize, maximize and close buttons, look like they have a light theme foreground. I checked the Dev Home app itself and it looks like an issue with all the windows of the app currently in Dev builds. So, I opened this issue #1882
Detailed description of the pull request / Additional comments
Validation steps performed
tested this locally.
PR checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

Just curious, would UseAppTheme ever be false (besides in the destructor?)

Just curious, would UseAppTheme ever be false (besides in the destructor?)

@krschau, UseAppTheme is a property I added when creating the SecondaryWindow and is configurable from a custom XAML window. Although it may be uncommon to use it, it simply allows us to create a SecondaryWindow that is theme-independent from the application, and instead follows the system theme.
MyWindow.xaml
<SecondaryWindow
    UseAppTheme="False"
   ....

More details on usage here: SecondaryWindow docs


GUI development for BSIP10 percentage based transfer fee

This ticket is for tracking GUI works of BSIP10.

The BSIP10 feature requirement/description is here.
main back-end develop branch is here.

Things to be done:

[ ] check whether the transfer feature in current GUI is compatible with new back-end
[ ] add an selection box on the "create asset" page and "update asset" page, so the issuer can set fee mode easily
[ ] show transfer fee mode on asset details page, and maybe somewhere related (please indicate)
[ ] use new transfer_v2_operation to do all transfers, or use new operation on assets with percentage fee mode but use the original transfer_operation on assets with flat mode
[ ] transaction history / Recent activity (should I list the pages which contain a list of history?)
[ ] block detail page (the page after click on a transaction in the history)
[ ] extend fee estimation to handle percentage fees (only needed if GUI estimates fees independently but not call get_required_fees API).
[ ] check if the fee schedule page work with new back-end
[ ] adjust "Fees and cashback" section of membership page, and maybe description of "Fee Division", and maybe some related pages (please indicate)
[ ] [optional] deal with the No. 4 issue described in BSIP10 document (overpay fee to avoid trx failure)

This issue was moved to bitshares/bitshares-ui#41


feat: flag to pull request create that allows update of existing PR

Automated use of jx-scm may lead to repeated calls to create a PR between feature branch and main branch. If an existing PR exists between these two branches, the create call will fail. Users may prefer that the existing PR is simply updated. These changes enable that behavior by adding an option --allowUpdate flag.
The new tests rely on code in this PR in go-scm.

/assign @rawlingsj

/retest

/ok-to-test
/lgtm

@waciumawanjohi rebase ur PR with the latest master/main, afte #22 is merged.

/test this

/hold
some minor comments ...

Remove the hold after you have figured out if 5000 will break anything for other providers (including github/gitlab).

I've been able to create a pull request and then update that pull request for repositories in both github and gitlab using the --allow-update flag. Is that sufficient? Or is there a list of SCMs that need manual testing?

Or is there a list of SCMs that need manual testing

github and gitlab should be fine (we anyways test with only github atm with automated tests). It would be good to test with bitbucket cloud (did u check the limits), but we can look at that later.

It would be good to test with bitbucket cloud (did u check the limits), but we can look at that later.

I've been trying to figure out how to work with bitbucket cloud at all. What is your workflow for generating a personal access token for bitbucket cloud?

Repository settings -> Access keys is about adding SSH keys
There are instructions for OAuth, but that doesn't seem applicable
I created an app password here, but using it returns error: failed to validate options: failed to validate options: failed to find current user: Not Authorized

The version of go-scm in this project is ancient. There were a few fixes that went in, that fix a few issues with bitbucket cloud. I also use app password when playing around with bitbucket cloud. Normally the interaction happens using lighthouse with go-scm. I have not used jx-scm before (did not even know this repo existed), but will give it a try with bitbucket cloud tonight, and update this thread. Can you send me the command you run to verify it with other cloud providers?

I decided to stop fighting the pagination and just use it. So the ridiculously large size value is gone.
One open question is how the different scm providers use that close value. E.g. Let's say that you have a repo where:

PR #1 (least recent) is open.
PR #2-#11 are closed.
PR #12 is open.

What will be the behavior when calling
scm.PullRequestListOptions{Page: page, Size: 10, Open: true, Closed: false}

?
Will it return the 2 open PRs in the single page? Or will it return PR #12 and not PR #1 (because PR #1 is outside the pagination).
I tested manually against Github and it returns the 2 open PRs. But I don't know about the implementation of all other SCMs.

My test command is:
./build/jx-scm pull-request create \
  --kind github \
  --server https://github.com/ \
  --token SOMETOKEN123 \
  --owner waciumawanjohi \
  --name demo-hello-world \
  --head hey \
  --title "It works, huzzah" \
  --body "Look here" \
  --base main \
  --allow-update

Run twice, it should succeed both times.

This PR is blocked on this fix in go-scm:
https://github.com/jenkins-x/go-scm/pull/328

/hold cancel


Just spits out the same output

Type: Bug
all the time this is constant the bot seems to just try the same crap and wrap with with random copy.
Less curt and more helpful prompts don't actually fix the problem as in my example I'm now frustrated and quitting using the product because it's wasting my time.
It creates the the same non-functional output, when prompted with the error tha tits output creates it simply spits out the same thing and erroneously asserts that its trash suggestion isn't worthless.
Extension version: 0.23.2
VS Code version: Code 1.96.2 (Universal) (fabdb6a30b49f79a7aba0f2ad9df9b399473380f, 2024-12-19T10:22:47.216Z)
OS version: Darwin arm64 23.5.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
7, 6, 6

Memory (System)
32.00GB (0.26GB free)

Process Argv
--crash-reporter-id 32c2f0bd-7066-44f4-8e24-dfba708c8c8f

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyt551:31179978
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupytercf:31046870
nativerepl1:31139838
pythonrstrctxt:31112756
nativeloc2:31192216
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
6074i472:31201624

this isn't a github issue it's AI model feedback


update CKeditor data on images upload

I had a problem on images upload because the CKeditor doesn't update retorne of getDate().
So, I maked it update its values on event "fileUploadResponse".

Thank you very much @rlfscin. I merged and write guide soon.


European HGV on CARLA 0.10.0

I migrated to the 0.10.0 version but wanted to use the European HGV truck.
Is it possible to import it in version 0.10.0 from 0.9.15?
I'm using the precompiled version.

No is not possible to use it right now with precompiled version.


Update README (Docker quickstart)

The Dockerfile source in the Docker Quickstart was incorrect.

Closing this as the change is already present in #46


High Contrast Management

To get more information about why it's required, you can browse #432.

[x] Support to enable/disable default browser behavior about high contrast.

[x] Chrome (Using --disable-features=ForcedColors command line flag)
[x] Edge (Using --disable-features=ForcedColors command line flag)
[x] Firefox (Using browser.display.document_color_use=1 on WebUI-NoHC profile)

[ ] Detect high contrast theme enabled

[x] Windows (Using HKEY_CURRENT_USER\Control Panel\Accessibility\HighContrast -> Flags)
[x] Linux (Using gsettings get org.gnome.desktop.a11y.interface high-contrast)
[ ] MacOS (I have not a Mac computer)

[ ] API to check OS high contrast theme from

[x] Backend
[ ] Frontend

I am not much knowledge about WebUI Frontend API. So I couldn't implement the API however since backend is exist of API, it should not be hard.
Also I have not a Mac computer, so I can not implement detecting on MacOS.


support custom dataset

Hi there， thanks for your brilliant work, well...i have a question that if that work support custom dataset? thansk for your work again.

Ideally, ContrastiveCrop should work well with single-object datasets.

Ideally, ContrastiveCrop should work well with single-object datasets.
thanks for your reply.


Error when using auto drafting mode on a document with no custom field names

  File "/usr/share/docassemble/local3.10/lib/python3.10/site-packages/docassemble/ALWeaver/interview_generator.py", line 1280, in interview_order_list
    question.field_list[0].trigger_gather(
IndexError: list index out of range

See #873 for where this was discovered, but it's a preexisting bug unrelated to that PR.

sample_word_template.docx

I can't actually reproduce this with the given document any more, with the current code on main at least


[BUG] Not compatible with latest python version

It doesn't work on latest python version, see the error i get from this commnad pip install lite-spleeter :
Defaulting to user installation because normal site-packages is not writeable
ERROR: Ignored the following versions that require a different python version: 1.0.0 Requires-Python <3.11,>=3.8; 1.0.1 Requires-Python <3.11,>=3.8; 1.0.2 Requires-Python <3.11,>=3.8; 1.0.3 Requires-Python <3.11,>=3.8
ERROR: Could not find a version that satisfies the requirement lite-spleeter (from versions: none)
ERROR: No matching distribution found for lite-spleeter

Sorry for the late respond :)
unfortunately, I am not that good in Python, and this was my first time writing Python.
this error happens because some packages that lite-spleeter depends on needs an older version of Python, and to fix this I have to update their versions, which they will probably have breaking changes :)
Try out Basset I have spleeter included in it... try it out.
Thanks

Sorry for the late respond :)
unfortunately, I am not that good in Python, and this was my first time writing Python.
this error happens because some packages that lite-spleeter depends on needs an older version of Python, and to fix this I have to update their versions, which they will probably have breaking changes :)
Try out Basset I have spleeter included in it... try it out.
Thanks

Oh i already use Basset, you added that feature? Great 😃
Did you use your lite version spleeter or the original one?

Did you use your lite version spleeter or the original one?

Actually, it is similar to lite-spleeter in the segment processing, but it is written in c++, so it is much better than lite-spleeter, and only uses 200-500 mb ram.

Did you use your lite version spleeter or the original one?

Actually, it is similar to lite-spleeter in the segment processing, but it is written in c++, so it is much better than lite-spleeter, and only uses 200-500 mb ram.

Nice, can you share the repo link of that tool which removes the music? I want to explore and later use it in my project someday.

In sha'a Allah I will

Did you use your lite version spleeter or the original one?

Actually, it is similar to lite-spleeter in the segment processing, but it is written in c++, so it is much better than lite-spleeter, and only uses 200-500 mb ram.

Nice, can you share the repo link of that tool which removes the music? I want to explore and later use it in my project someday.

In sha'a Allah I will


Rollover API support listed as experimental, is it safe for production?

We have recently have upgraded our Jaeger deployment to 1.18. As part of the deployment we are looking into using the Elasticsearch rollover feature. We have however noticed that in parts of the documentation, this is marked as experimental. This has brought up concern about using it in a production deployment. Our plan is currently to utilize it based on the max_size option to keep our indices below a specified size. We have a test cron job that runs every 15 min against the AWS manged ES cluster.
Is this feature one that is safe for production deployment? Are there any concerns we should keep in mind because of the experimental label?

Rollover is a stable feature. It's safe to be used in a production environment. I will remove the experimental labels from flags.
Where in the docs did you see experimental?

Rollover is a stable feature. It's safe to be used in a production environment. I will remove the experimental labels from flags.
Where in the docs did you see experimental?

Great to hear that it is stable.
It is listed as experimental in several places on the CLI flags page within the documentation: https://www.jaegertracing.io/docs/1.18/cli/#jaeger-collector as an example.

It has been removed from the CLI flags. Where else did you see it?

It has been removed from the CLI flags. Where else did you see it?

Noted here within this text as an example.
https://www.jaegertracing.io/docs/1.18/cli/#jaeger-collector-elasticsearch

--es.use-aliases
false

(experimental) Use read and write aliases for indices. Use this option with Elasticsearch rollover API. It requires an external component to create aliases before startup and then performing its management. Note that es.max-span-age is not taken into the account and has to be substituted by external component managing read alias.

That is derived from flags, It should be fixed now by #2290.
thanks for reporting


Administrative / silent install is borked

What is the issue?
For deployment scenarios like for classrooms or to regular managed devices the setup needs to perform an administrative / unattended install. For InnoSetup built installers this can normally be done via the command-line switches /SILENT (or /VERYSILENT) or via a response file via /LOADINF. (See: https://jrsoftware.org/ishelp/index.php?topic=setupcmdline )
If the setup can be performed by both, an unprivileged user and an administrator the switch "/ALLUSERS" helps to select the latter. If the install paths are (correctly) derived from the common environment variables this should automagically move the files to "C:\Program Files" or "C:\Program Files (x86)" instead of the users AppData folder.
Normally this would also lead the installer engine to register the application under the systems registry (HKLM:) and create a system wide start menu.
With Ollamas setup this does not work even though setting the install-path like mentioned in the documentation to 'C:\Program Files\Ollama' makes it look like it should.
Instead it creates a mix of both methods where the files are installed to the Program Files folder, but the registry and start menu entries are limited to the user (context) installing the software. And as most management system use a local system service as context this creates a rather weird state. And even if I could limit the permissions down - for a classroom for example I can never know which user will access the device...
OS
Windows
GPU
No response
CPU
No response
Ollama version
0.4.7

Our setup based installer is currently optimized for individual installation.  For system wide installation, please follow these instructions: https://github.com/ollama/ollama/blob/main/docs/windows.md#standalone-cli


Suggestion - GetWeaponSlot

Syntax:
int32 GetWeaponSlot( int WeaponID )
returns the slot which the weapon belongs to ingame.

Done with PR #40


Use only one scenario to test all kafka versions

Use only one scenario to avoid code duplicate on molecule tests.
@see https://travis-ci.org/ryarnyah/ansible-kafka-admin/builds/388979874 for build results

This is awesome! Thank you


Moving HomeObj field out of ScriptFunction

Only class member functions and object literal methods have home object set. So moving this field out of ScriptFunction should help us reduce the size of normal ScriptFunctions.
As part of this the SetHomeObj opcode is also removed. Instead we set the home object along with the creation of the function.

Backend changes look good.

@dotnet-bot test OSX static_osx_osx_debug please


userText cannot be null or empty caused by incomplete/incorrect check for messages in DefaultChatClientClass

DefaultChatClientClass is assuming that the last message in the messages array is of type "USER".
If the last message is not of type USER, userText is not being set and the subsequent null check will fail, although a USER message has been provided:
Pseudo-Code that causes the problem:
chatClient                 .prompt(                         new Prompt(                                 List.of(                                         createUserMessage(request),                                         createSystemMessage()                                 )))                 .call()                 .chatResponse();
will result in :
java.lang.IllegalArgumentException: userText cannot be null or empty
at org.springframework.util.Assert.hasText(Assert.java:240) ~[spring-core-6.1.10.jar:6.1.10]
at org.springframework.ai.chat.client.advisor.api.AdvisedRequest.(AdvisedRequest.java:87) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at org.springframework.ai.chat.client.DefaultChatClient.toAdvisedRequest(DefaultChatClient.java:129) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at org.springframework.ai.chat.client.DefaultChatClient$DefaultCallResponseSpec.doGetChatResponse(DefaultChatClient.java:483) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at org.springframework.ai.chat.client.DefaultChatClient$DefaultCallResponseSpec.lambda$doGetObservableChatResponse$1(DefaultChatClient.java:477) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at io.micrometer.observation.Observation.observe(Observation.java:565) ~[micrometer-observation-1.13.1.jar:1.13.1]
at org.springframework.ai.chat.client.DefaultChatClient$DefaultCallResponseSpec.doGetObservableChatResponse(DefaultChatClient.java:477) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at org.springframework.ai.chat.client.DefaultChatClient$DefaultCallResponseSpec.doGetChatResponse(DefaultChatClient.java:461) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
at org.springframework.ai.chat.client.DefaultChatClient$DefaultCallResponseSpec.chatResponse(DefaultChatClient.java:505) ~[spring-ai-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
Offending lines from DefaultChatClient, method toAdvisedRequest ll 109ff
 List<Message> messages = inputRequest.messages;         if (!StringUtils.hasText(userText) && !CollectionUtils.isEmpty(messages)) {             Message lastMessage = (Message)messages.get(messages.size() - 1);             if (lastMessage.getMessageType() == MessageType.USER) {                 UserMessage userMessage = (UserMessage)lastMessage;                 if (StringUtils.hasText(userMessage.getContent())) {                     userText = lastMessage.getContent();                 }
Please make no assumptions about the order of messages an external caller to your API may provide.

@github2atauhiq thanks for reporting this. Could you elaborate a bit more on this specific use case where there is no user message as the last one in a list of messages sent to an LLM?
ChatClient requires each AI workflow to have a user message well identified. Either directly (via .user()) or as part of a list of messages (via .prompt() or .messages()). In the latter case, ChatClient would try to find the user message as the last element of the list of messages (which is also what an LLM provider would do in the presence of multiple messages). If neither places contain a user message, the ChatClient cannot guarantee the integrity and consistency of its behaviour, so it's important to get the exception thrown. By design, a user message needs to be provided. Or else, all the augmentations that it could provide like memory, RAG or guardrails would not be predictable nor robust enough.
Besides ensuring a clear and consistent behaviour for ChatClient, this requirement also helps preventing mistakes when interacting with a model. LLMs expect to get a user message. If there's a list of messages, LLMs for the user message to answer to as the last one in the list. If that's not true, they would still answer something, but the outcome is even more unpredictable than it usually is, because the order of messages matters and therefore changes the LLM behaviour, sometimes in a very significant way. Some models would not process the misplaced user message at all and answer completely unexpected things.

Hello Thomas,
thank you for your feedback.
I wasn't aware of any particular order that the message must to be supplied in. There is no hint in the documentation that specifies that the prompts have to be ordered in a certain way. There weren't any issues so far with providing the user-message as the first message in the list.
Since spring-ai is meant to be an abstraction, why do I have to care about the order of the messages that the underlying LLM is expecting anyways?
I also find it odd, that i am able to construct an instance of Prompt although the order is incorrect. I would have expected the API to fail immediately and throw a more specific exception.
Of course, it is no problem for us to change the order (we are already doing that), but the behavior of spring-ai regarding this topic clearly changed between last week and this week and that was reason enough for me to indicate this to you.
Best regards
Manuel

Thanks a lot for providing additional context. Before, this same behaviour was happening, but in case no user message was found, one was created with empty content, which was leading to unpredictable outcomes (especially when using Advisors). Now, there is a check to ensure a proper user message is defined, so to ensure consistency and no surprises in the resulting behaviour.
The underlying ChatModel abstraction doesn't assume anything, so you can build the messages any way you want. The ChatClient is a higher-level API that brings some boundaries to be able to build such AI workflows in a robust way. For example, when using RAG via an Advisor, it will not work as expected if the user message is not identified correctly.
I wonder if there could be a way to make this more flexible, while maintaining the null-safety and predictability of the API. For example, would it work having ChatClient accept a lambda to use for customising the "user message identification" strategy? What do you think?

@ThomasVitale
What do you think about applying the builder pattern to the Prompt class? It seems that developers would find it easier to understand the message insertion order by looking at the API. Also, if we add the UserMessage to the list during the build() process, wouldn't it be possible to handle the order correctly internally?

Sorry for the mistake, this issue was mentioned by accident.

Some good ideas here, going to close an concentrate the discussion in #873


[FLOC-2504] OpenStack HTTPS

Support private CA's and self-signed certificates for OpenStack.  Some OpenStack implementations do not use public well-known CA's. This PR adds fields to the agent backend configuration:

verify_peer which determines whether to verify HTTPS connections, and
verify_ca_path which selects a CA bundle other than the system CA's.

There are two failure modes we can expect with this configuration option:

False positive: the client erroneously validates something it shouldn't. This is Very Bad since it means we can leak passwords to a MITM attack.
False negative: the client refuses to talk to a legitimate server. This is not good, but on the other hand we're no worse than we are now.

We should therefore at absolute minimum have functional test for the false positive case: in relevant storage-driver builders run a test that uses a known bogus CA cert (i.e. self-signed) to construct a Cinder IBlockDeviceAPI and tries to talk to whatever OpenStack API is configured by default. This should fail because the HTTPS API server will be using different CA cert.
As far as false negative, until we have a private OpenStack setup we can't really test this. I suggest a followup issue and for now we can just rely on user testing (i.e. once this is merged ask customer to test it; if it doesn't work for them then file a follow-up issue).

Did we hear back from customer about this?

OK, address minor comment and merge when buildbot is happy. Thanks!


Iconify then restore multiple window at the same time

Hi, Iconify then restore multiple window at the same time like below will result only one window to be restored. Win 7 x64, glfw 3.0.3, mingw4.8.1
GLFWwindow window;
GLFWwindow window2;
window = glfwCreateWindow(640, 480, "I wont come back", NULL, NULL);
window2 = glfwCreateWindow(640, 480, "I will come back", NULL, NULL);
//Some code here...
glfwIconifyWindow(window);
glfwIconifyWindow(window2);
//Some code here...
glfwRestoreWindow(window);
glfwRestoreWindow(window2);

But Twisting the Iconify order will result both window to be restored just fine.
GLFWwindow window;
GLFWwindow window2;
window = glfwCreateWindow(640, 480, "I will come back", NULL, NULL);
window2 = glfwCreateWindow(640, 480, "I will come back too", NULL, NULL);
//Some code here...
glfwIconifyWindow(window2);
glfwIconifyWindow(window);
//Some code here...
glfwRestoreWindow(window);
glfwRestoreWindow(window2);

Is this still an issue with 3.1?

Confirmed, its no longer an issue with 3.1+. (Sorry for the long delay, had no time)

@VaderY Thank you for the follow-up!


[TASK] Migrate various names to conform KubeVirt conventions

Due to the upcoming project migration schedule, we have some tasks that need to be done before the migration to ensure smooth progress.
One of the tasks is to renaming the CRD and change the API group of it to conform the KubeVirt convention:

Changing from KubeBMC to VirtualMachineBMC
Changing from zespre.com to kubevirt.org

Also, the components kubebmc-controller and kbmc should be renamed to virt-bmc-controller and virt-bmc, respectively.
Finally, the project's name will be changed to KubeVirtBMC to convey that this project is targeted to work with KubeVirt.
P.S. This is a follow-up issue of #1.

I can help in this one
/assign @kashifest

/assign

@kashifest
Thank you for volunteering to handle this issue! I really appreciate your help. I will assign this issue to you now. If you need any further information or assistance, please let me know.


Internal error detected. Please copy the above traceback and report at https://github.com/Microsoft/vscode-python/issues/new

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

import os
import os.path
import sys
import traceback

useCustomPtvsd = sys.argv[1] == '--custom'
ptvsdArgs = sys.argv[:]
ptvsdArgs.pop(1)

# Load the debugger package
try:
    ptvsd_lib_path = os.path.join(os.path.dirname(__file__), 'lib', 'python', 'old_ptvsd')
    if useCustomPtvsd:
        sys.path.append(ptvsd_lib_path)
    else:
        sys.path.insert(0, ptvsd_lib_path)
    try:
        import ptvsd
        from ptvsd.__main__ import main
        ptvsd_loaded = True
    except ImportError:
        ptvsd_loaded = False
        raise
except:
    traceback.print_exc()
    print('''
Internal error detected. Please copy the above traceback and report at
https://github.com/Microsoft/vscode-python/issues/new

Press Enter to close. . .''')
    try:
        raw_input()
    except NameError:
        input()
    sys.exit(1)
finally:
    if ptvsd_lib_path:
        sys.path.remove(ptvsd_lib_path)

main(ptvsdArgs)

🚫 Closing this, please open a new issue following the issue template describing the error as well as your environment and steps to replicate the issue. Thanks!


Update Modal message

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

we need to build UI files and push them, put it in draft maybe. I want to remove the build files from git


Update event-030.md

@Chilipp I have added the times to everything which I have details for. Some are in the pull request for the round 5 events and there are two separate ones, this is the last of them.
@eileen-kuehn We need to an entry in the software demos events for abstract number 7 which was on the waiting list and is now scheduled. Once we have that there are three indico events that can be created. They are the ones on the scheduling spreadsheet for week beg. 11th, 25th Jan and 8th Feb. The 8th Feb one is the one missing abstract 7.
Please let me know if you need any more details or I can do anything else to help with this.

thanks @catsmith! @eileen-kuehn, please let me know when you created the registration event on indico

@catsmith, @Chilipp, I added event 7 and the times as well as the links to Indico. Should be ready now.

I am just regenerating the PDF for event-007 and then we can merge this


config might not work

{
  "releaseChanger": [
    {
      "changer": "npm",
      "path": "package.json"
    }
  ]
}

not working

changetr type should be type


Create C programming

📝 Description
Add a brief description.
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

Dear user, we noticed that this PR is neither AI Agent nor ILLA App nor ILLA Builder Fixed, please check it.


[iOS] Scaffold resizes when you come from an app with the keyboard open

This problem occurs whenever the keyboard is raised in other apps and return to the app
Steps to Reproduce
Open an app like messages and tap in a field, when the keyboard is on the screen, slide back to your app. The flutter app will resize weirdly for a moment.
Demo with gallery app

Target Platform: iOS
Target OS version/browser: 12/13
Devices: Simulator/iPhone X
[✓] Flutter (Channel master, v1.10.15-pre.205, on Mac OS X 10.15 19A602, locale es-ES)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.5)
[✓] Connected device (4 available)

The workaround to avoid this is: in your Scaffold, set resizeToAvoidBottomInset property to false.
It desactives the resize of the scaffold when the keyboard pop ups. You should be careful in the scaffolds where you want to use the keyboard

I think this is the real cause of this other observed issue:
https://github.com/flutter/flutter/issues/41679

The workaround to avoid this is: in your Scaffold, set resizeToAvoidBottomInset property to false.
It desactives the resize of the scaffold when the keyboard pop ups. You should be careful in the scaffolds where you want to use the keyboard

Resolved, thanks
This problem occurs whenever the keyboard is raised  in other apps and  return to the app

This is fixed at 16270

I'm running an app from the latest Flutter dev branch and still seeing this issue.


ValueError: Unsupported model type phi3

Phi-3 is not supported.

when will this model be supported?


Task - Unify - I can select the same object on both sides. Remove the right object from the left search results.

It won't let you unify.  The overhead of catching this across all the smart selectors may not be worth it.

When I make a search, I see two identical items. It is a lot of guess work which one to select. It would be nice if one is already selected, the other one is not visible in the list (what we have in the unify people interface).

We already handle this, smart selectors and autocompletes won't allow you to pick the same option that was selected on the other side, but it wasn't working because a prop misspelling


Implement client cert auth

Description

For VMs, rotation of k8s service account token (istio-token) is not reliable
Reuse logic in Istiod which uses the peer cert to identify the workload on refresh
Fixes #279

/ok-to-test

Hey, thanks for raising this! I think this makes sense and it's a well made PR!
I don't really know how to evaluate the security impact of this (I'm not an istio expert). I don't know if having client cert auth enabled by default is a safe thing in all cases. It seems fairly safe in this context, though, since obviously the admin will have chosen which certs go into the trust store to use for checking client certs.
I'm reluctant to enable this by default just because it expands the auth surface area and as said above I'm nervous of that.
Do you think we could add a boolean flag (and a corresponding Helm chart bool) which allows users to opt-in to client cert auth? I feel like then it's super easy to merge this feature.

Added the flag in a separate authenticators block in case there comes a need for more authenticators in the future. Istio seems to support based on the highlighted code:

client cert
k8s sa token
jwt
cidrs
as well as toggles that disable authentication in a trusted network (my guess is they only need the cert for multicluster / SPIFFE federation).


Webhook Questions and Clarifications

Hello,
I have started using open collective for SunPy (as part of NumFOCUS) and am loving it so far, but I wanted to pull in collective notifications into our matrix chat.
I have managed to get quite far by just collecting some example payloads over time, but I have a few questions and comments:

Why does the "expense.comment.created" payload have no data? What's the expected way to be able to provide links to the comment etc with that event?
Why do the "collective.expense.approved" events not have a data.collective object with details about the receiving collective but "collective.transaction.created" payloads do?
Is there any way to link to a transaction for more information?
It would be super useful if a URL field could be added to most of the payloads to get a link back to the event in the web UI.
#4244 would be really lovely!
How do I get webhook events for things that happen in my sub-projects?

Thanks so much for an awesome platform!

Hi @Cadair!

Why does the "expense.comment.created" payload have no data? What's the expected way to be able to provide links to the comment etc with that event?

Expense comments are private, and we decided a while ago that webhook events wouldn't include any private data in order to facilitate the security aspects of this feature. With our team growing, that's something we may rediscuss but it's how it works now.
Our advice is usually to listen to webhooks to get notified about new activities, then use our public GraphQL API to retrieve the data.

Why do the "collective.expense.approved" events not have a data.collective object with details about the receiving collective but "collective.transaction.created" payloads do?

We could add that bit of information if it unblocks you, but keeping #3422 in mind it's probably better to use the GraphQL API here too.

Is there any way to link to a transaction for more information?

If you mean in the UI, an option is to search for #{transactionID} on the transactions page: https://opencollective.com/babel/transactions?searchTerm=%231238714.

It would be super useful if a URL field could be added to most of the payloads to get a link back to the event in the web UI.

Good call, I'm opening an issue for this one in https://github.com/opencollective/opencollective/issues/6020.

Provide Example Payloads for all webhook events #4244 would be really lovely!

We haven't documented all activity types yet, but this one is live already:

How do I get webhook events for things that happen in my sub-projects?

Currently, you need to add the webhook on each account individually.
In the future, we want to give you the option of choosing whether the webhook needs to run on them too: https://github.com/opencollective/opencollective/issues/4738.

Thanks so much for an awesome platform!

Thanks for providing this constructive feedback!

@shannondwray before closing this issue, I'd like us to update https://docs.opencollective.com/help/collectives/collective-settings/integrations#webhooks-generic-slack-discord to explain that payloads don't contain any private info and redirect people to https://docs.opencollective.com/help/contributing/development/api#graphql-api if they need more. Let me know if you need more details!

Hi @Betree thanks for answering my questions so quickly!

Expense comments are private, and we decided a while ago that webhook events wouldn't include any private data in order to facilitate the security aspects of this feature. With our team growing, that's something we may rediscuss but it's how it works now.

This makes perfect sense, for my use case just having a link to the comment would be great as then I could have a message which says "New comment posted: ".

Our advice is usually to listen to webhooks to get notified about new activities, then use our public GraphQL API to retrieve the data.

I don't think the way I am handling the webhook parsing allows me to make further calls out to anything (it's in a very restricted sandbox).

Why do the "collective.expense.approved" events not have a data.collective object with details about the receiving collective but "collective.transaction.created" payloads do?

We could add that bit of information if it unblocks you, but keeping #3422 in mind it's probably better to use the GraphQL API here too.

I am not sure I follow, I am talking about the receiving collective, i.e. to whom the money is being paid from (i.e. SunPy) rather than who it's being paid to. The information about the user who submitted the expense is already included.

Is there any way to link to a transaction for more information?

If you mean in the UI, an option is to search for #{transactionID} on the transactions page: https://opencollective.com/babel/transactions?searchTerm=%231238714.

Perfect thanks.

Provide Example Payloads for all webhook events #4244 would be really lovely!

We haven't documented all activity types yet, but this one is live already:

Oh excellent, I missed that. Might be worth including that or mentioning it here: https://docs.opencollective.com/help/collectives/collective-settings/integrations ?

How do I get webhook events for things that happen in my sub-projects?

Currently, you need to add the webhook on each account individually. In the future, we want to give you the option of choosing whether the webhook needs to run on them too: #4738.

Maybe I don't have the permissions to do this then, but I can't see any option to enable wehooks on this subproject for example?

This makes perfect sense, for my use case just having a link to the comment would be great as then I could have a message which says New comment posted: <link>.

I've created an issue to document the need for this: https://github.com/opencollective/opencollective/issues/6178.

Why do the "collective.expense.approved" events not have a data.collective object with details about the receiving collective but "collective.transaction.created" payloads do?

We could add that bit of information if it unblocks you, but keeping #3422 in mind it's probably better to use the GraphQL API here too.

I am not sure I follow, I am talking about the receiving collective, i.e. to whom the money is being paid from (i.e. SunPy) rather than who it's being paid to. The information about the user who submitted the expense is already included.

Sorry, I misread that part! I'm pushing an update in https://github.com/opencollective/opencollective-api/pull/8195 to add the collective info.

Oh excellent, I missed that. Might be worth including that or mentioning it here: https://docs.opencollective.com/help/collectives/collective-settings/integrations ?

Indeed! I've updated the docs page.

Maybe I don't have the permissions to do this then, but I can't see any option to enable wehooks on this subproject for example?

Looks like there's a bug on the menu, I'm working on it at https://github.com/opencollective/opencollective-frontend/pull/8396. If you need to access the feature today, you can do so by accessing the direct URL: https://opencollective.com/sunpy/projects/sunpy-nasa-80nssc22k1058-ostfl/admin/webhooks.
Closing the issue as this should address all the questions, but feel free to re-open if you have more.

Thanks so much!


Uf 5562 use requestid from incoming request

Added logic to re use request id from incoming request in the workers
that are executed asynchronously

Fixed PR comment

Rebased with develop


OSError: [WinError 126] The specified module could not be found

The code run fail right at the 3rd line "chip = cp2130.find()"
Below is all the log. I tried to disable "libusb1" to force it use "pyusb" but also failed to detect device.
I check the connection with hardware is OK. I also could see the SPI device in the device manager. I used the verified Application for my HW to check the SPI communication with HW, and everything is OK.
BTW, I'm using Windows 8 and python 3.6.2.
Traceback (most recent call last):
  File "31-cp2130.py", line 6, in <module>
    chip = cp2130.find()
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\cp2130\__init__.py", line 32, in find
    from cp2130.usb import libusb1 as usb
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\cp2130\usb\libusb1\__init__.py", line 17, in <module>
    from cp2130.usb.libusb1.core import *
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\cp2130\usb\libusb1\core.py", line 18, in <module>
    from cp2130.usb.libusb1.hotplug import HotplugListener, HotpluggedDevice
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\cp2130\usb\libusb1\hotplug.py", line 19, in <module>
    import usb1
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\usb1\__init__.py", line 61, in <module>
    from . import libusb1
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\usb1\libusb1.py", line 199, in <module>
    libusb = _loadLibrary()
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\site-packa
ges\usb1\libusb1.py", line 173, in _loadLibrary
    return dll_loader('libusb-1.0' + suffix, **loader_kw)
  File "C:\Users\user_name\AppData\Local\Programs\Python\Python36-32\lib\ctypes\__i
nit__.py", line 348, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] The specified module could not be found

Hi
do you have find a solution for this problem?


Inaccurate collision between Rigidbody (sphere) and StaticBody with a flat trimesh

Godot version
3.4.2 stable-mono-official
System information
Win 10 GLES3 Intel-i7-10875H RTX 2060 Max-Q
Issue description
Attempting to roll or bounce a RigidBody (sphere) across a StaticBody w/ flat trimesh collsion shape the collisions are not as anticipated. For example even though the trimesh is completely flat attempting to roll the Rigidbody will result in it "hitting bumps" and often deflecting from it's path. Bounces also often result in deflection and greatly reducing linear velocity.
Note - the vertex count of the StaticBody trimesh must be quite high. Lower vertex count trimeshes will not accurately reproduce the bug
Steps to reproduce
Create a RigidBody with a sphere collision shape and StaticBody with a collision shape that is a flat trimesh (with high vertex count). Use ApplyCentralImpulse() to "roll" the RigidBody across the StaticBody and observe the unexpected bounces/deflections.
An example project is included below. Three StaticBodies are present with trimeshes generated from Zyllan's terrain add-on at different LOD values (1 - highest vertex count, 5 - medium vertex count, 10 - lowest vertex count). The individual collision meshes can be tested by making sure all other StaticBody's CollisionShape > Disabled property is checked ( it also helps visually to hide the unused StaticBodies ). Notice as the vertex count of the trimesh collision shape increases the erroneous collisions between RigidBody/StaticBody increase in frequency. The last StaticBody included uses a trimesh generated from a cube and has a very low vertex count - it most closely demonstrates what "expected" collisions should be.
It will help to ensure Debug > Visible Collision Shapes is checked as well as View Information being checked in the editor's camera perspective menu (for showing vertex counts.
Minimal reproduction project
Trimesh Collision Bug Report.zip

Duplicate of https://github.com/godotengine/godot/issues/46596 and/or https://github.com/godotengine/godot/issues/50463.


Document Ferm usage

I think that this: https://github.com/roots/bedrock-ansible/blob/master/group_vars/all#L32
is really dangerous. I didn't check the indentation and assumed it was used to disable Ferm. Result, I'm now locked out of my instance. I think it should have at least an inline comment.
What do you think?

@louim I know this isn't the permanent answer you're looking for, but a temporary solution in the mean time is to reboot the server. That'll clear the IPTables rule blocking your specific IP.

If you have a web console or something where you can access the server, you can run ferm --flush /etc/ferm/ferm.conf

@nathanielks I tried rebooting the instance, but alas, that didn't clear the iptable rules. @swalkinshaw Since the instance is locked (SSH key access only), the web console trick didn't work. I ended up rebuilding the instance.
So, what would be the best option? Maybe remove the option from the allfile, and keep it documented so people changing this parameter will really know what they're doing?

@louim yeah it might be best to remove it. I assume that's the default anyway?

@swalkinshaw it's indeed the case. Since this is one of the more important rule (allowing SSH connection), and it normally default to false, I made pull request #211 to remove the option.

I think this can be closed, as Fern is already well documented in it's role folder and #211 has been merged.


undefined reference to symbol 'dgesvd_'

cmake works fine, but the problem occurs when linking dlib to another project.
After doing cmake ..  when I do make，error comes like this :
Scanning dependencies of target detect
[ 50%] Building CXX object CMakeFiles/detect.dir/detect.cpp.o
[100%] Linking CXX executable detect
/usr/bin/ld: CMakeFiles/detect.dir/detect.cpp.o: undefined reference to symbol 'dgesvd_'
//usr/lib/x86_64-linux-gnu/liblapack.so.3: 无法添加符号: DSO missing from command line
collect2: error: ld returned 1 exit status
CMakeFiles/detect.dir/build.make:100: recipe for target 'detect' failed
make[2]: *** [detect] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/detect.dir/all' failed
make[1]: *** [CMakeFiles/detect.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
How to solve it? Thanks~

cmake works fine, but the problem occurs when linking dlib to another project.
After doing cmake .. when I do make，error comes like this :
Scanning dependencies of target detect
[ 50%] Building CXX object CMakeFiles/detect.dir/detect.cpp.o
[100%] Linking CXX executable detect
/usr/bin/ld: CMakeFiles/detect.dir/detect.cpp.o: undefined reference to symbol 'dgesvd_'
//usr/lib/x86_64-linux-gnu/liblapack.so.3: 无法添加符号: DSO missing from command line
collect2: error: ld returned 1 exit status
CMakeFiles/detect.dir/build.make💯 recipe for target 'detect' failed
make[2]: *** [detect] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/detect.dir/all' failed
make[1]: *** [CMakeFiles/detect.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
How to solve it? Thanks~

Sorry, have you fixed it?

I fixed this by doing the following:
in my CMAKE:
find_package(dlib)

target_link_libraries(
    YOUR_LIB
        PUBLIC
            dlib::dlib
)

Instead of:
find_package(dlib)

target_link_libraries(
    YOUR_LIB
        PUBLIC
            dlib
)


Failed to modify file after modifying warehouse name

Gitea : 1.3.2
centos : 7.6
MySQL

When I push to gitea it was HTML 5
But when I modify the warehouse name HTML 50, modifying the file and deleting the created file will fail. I feel that the synchronization of modifying the warehouse name fails.

Could you reproduce that on https://try.gitea.io or https://gitea.com ?

[Unit]
Description=Gitea (Git with a cup of tea)
After=syslog.target
After=network.target
After=mysqld.service
[Service]
Type=simple
User=root
Group=root
ExecStart=/home/git/gitea web
Restart=always
[Install]
WantedBy=multi-user.target
I found that because of the use of svstemd boot mode, there is no problem with direct use of. / gitea boot now.

Did you configure your app.ini with absolute path?

Closing this now, please feel to re-open if you have additional information.


Pending pull reqs.

Hello, Who is the maintainer of your group, I see some pending pull requests. Thank you

@uarif  There are some works to be modified so I have not merged it


I followed the example code from https://github.com/eProsima/Fast-RTPS/tree/master/examples/C%2B%2B/HelloWorldExample and defined a simple vector message VecMsg.idl :
struct VecMsg
{
    unsigned long index;
    sequence<octet> data;
};

Current Behavior
If the size of vector larger than 128 (https://github.com/EgalYue/send_big_data_test/blob/d33ee5d7bec3c799108d932af13405f01c2d9a67/VecMsgPublisher.cxx#L44), the subscriber can not receive the message.
I already set  Wparam.qos.m_publishMode.kind = ASYNCHRONOUS_PUBLISH_MODE;
Steps to Reproduce
The link of my test code:
https://github.com/EgalYue/send_big_data_test
System information

Fast-RTPS version: 1.10.x branch
OS: Ubuntu 18.04
Network: Speed: 1000Mb/s Duplex: Full
Buffer size : sysctl -w net.core.rmem_max = 212992
sysctl -w net.core.wmem_max = 212992
sysctl -w net.core.rmem_default = 212992
sysctl -w net.core.wmem_default = 212992

Im not sure, do I still need to set some options for big data?
Please let me know if you need any additional information.

@EgalYue In order to assure the subscriber is able to receive full samples, you should set-up  receiveBufferSize at least to the size of the sample (2MB in your case). This can be set in the participant's transport attributes:
FastRTPS Transport Documentation
You should also increase your net.core.rmem_default and net.core.rmem_max at least to the same size, to assure OS allows that UDP buffer allocation.

@EgalYue Additionally to what @adolfomarver said, the main issue you are having is that your data is unbounded.
The default behavior of Fast-RTPS is to preallocate data. The preallocated size is taken from DataType::getMaxCdrSerializedSize. When there is an unbounded sequence, the generated code assumes 100 elements on that method. See the generated code on your test. You can either change that method to accommodate your real maximum size or change the memory policy of your history to a dynamic value like PREALLOCATED_WITH_REALLOC

@MiguelCompany @adolfomarver Thanks so much, i modified the preallocated size from DataType::getMaxCdrSerializedSize and it works now. Thanks!
I will close this one.


Feature/merge messaging

PIpelines to deploy artifacts (binaries and archetype) to jFrog artifactory

/azp run

Change done


[FEATURE] Improve documentation C/C++ / Python

Is your feature request related to a problem? Please describe.

documentation is poor and also outdated

I have an PR for C++ example here, hope it helps
https://github.com/EmbeddedRPC/erpc/pull/402


Program does not start when following the Readme

Indeed in appsetting there are 2 additional parameters to complete and their origin is not documented on the same page (newbie error);
"APIToken": "{APIToken}",
"OrgUrl": "{OrgUrl}"

OrgUrl and Token information configuration can be found in the nodejs docs for configuration
https://developer.okta.com/okta-sdk-nodejs/jsdocs/

Indeed but the section “Project configuration” of “read me” is incomplete. These 2 parameters are not described

@vletoux @torbenpedersen I just updated the readme and some of the code.
Can you let me know if it's clear now? If not, I'll reopen this issue.


feat: add logging durations for screenshot async service

Using the event_logger's context manager to log the duration of computing, caching and overall compute_and_cache

@gooroodev review


updating operation

Bug report
What I did
update operation
field 1 from null to 1 (with select2_from_ajax) and
field 2 from 1 to null
What I expected to happen
the update is performed
What happened
the update from 1 to null is not written to postgres db
db has a constraint field1 is null and field2 is not null or field 1 is not null and field2 is null.
due to use of 2 seperate queries for updating the 2 fields this gives an error.
both field are belongsTo relationships to other model
What I've already tried to fix it
Backpack, Laravel, PHP, DB version
PHP VERSION:
PHP 7.4.1 (cli) (built: Dec 18 2019 14:44:22) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.1, Copyright (c), by Zend Technologies
LARAVEL VERSION:
laravel/framework                     v6.17.0   The Laravel Framework.
BACKPACK VERSION:
backpack/crud                         4.0.41    Quickly build an admin interfaces using Laravel 6, CoreUI, Boostrap 4 and jQuery.
backpack/generators                   2.0.6     Generate files for laravel projects

Hi @Staedion ,
If I understand correctly, this case is very specific to your application, and it's an expected way for the Update process to behave. It failed because your DB constraints did not allow it. I recommend you take a closer look at your validation, in your CrudRequest - and make sure you cover this edge case there too.
That being said, please note that the attributes are NOT saved using two queries. They're saved using just one. The AJAX call from the select2_from_ajax field does not actually save anything - it just uses AJAX to fetch the entries. The saving is then done after you click the Save button.
Hope it helps. I don't think we can help in any way here, since it looks like an application issue, not a Backpack issue. Let me know if I'm mistaken.
Cheers!

@tabacitu if it's not intended to update one to many relations in more than a single query i suppose there is a bug.
Backpack\CRUD\app\Library\CrudPanel\Traits\Update functions different from the Create trait.
on creation there's one insert query on update all belongsto relations are updated in a seperate query one by one. I suppose this should only be the case with n-n relations.

Under here the correct function for n-n as 1-n to function properly
public function update($id, $data)

    {
        $data = $this->decodeJsonCastedAttributes($data);
        $data = $this->compactFakeFields($data);
        $item = $this->model->findOrFail($id);

        // omit the n-n relationships when updating the eloquent item
        $nn_relationships = array_pluck($this->getRelationFieldsWithPivot(), 'name');
        $updated = $item->update(array_except($data, $nn_relationships));

        // if there are any relationships available, also sync those
        $this->createRelations($item, $data);

        return $item;
    }

Hmm... thank you @Staedion , we'll investigate!

@tabacitu : the problem is that many to one relations are updated as they are many to many relations in seperate queries. They should be updated in a single update query after which the many to many realtions should be updated as happens at the create operations which works correctly.

Thank you @Staedion - I've just created PR https://github.com/Laravel-Backpack/CRUD/pull/3210 using your code, and have asked @pxpm to give his opinion and review, to make steps towards a fix on master. Let's move the conversation there, please.
Cheers!


Add new securly killing exploit

^

💀 they can't just find a new killer when requested

echo better review b4 new year


how to hide activity from specific feed group?

I see that we can use the TO field to push an activity to specific feed groups. Can we do the inverse?
For example, if I want to push an activity to the 'user' flat feed, but stop the propagation of that activity to some 'timeline' feed group? This is for implementing privacy features.

Did you check discard rules? https://getstream.io/docs/#discard-rules

Can we create custom discard rules?
For example, if a user posts an activity and wants to block 3 followers from receiving it, we could attach a blacklist array to the activity object.

@tbarbugli any updates on this? I really need custom discard rules to enable an 'activity audience' feature.

Anything on this?

bump

bump

Bump


have integers where possible

LGTM. This are in fact integer variables, correct?

Well. They are parameters you assume in the scheme. So right now they are integers. At some point you could assume differently later

bors r+

🔒 Permission denied
Existing reviewers: click here to make trontrytel a reviewer

@charleskawczynski - turns out I can't. Feel free to do it

bors r+


New version: twpayne.chezmoi 2.39.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service there is no output from your validation actions. How am I supposed to know what to fix?

Relevant links:

https://github.com/microsoft/winget-pkgs/pull/118850/checks?check_run_id=16458418214
https://github.com/microsoft/winget-pkgs/pull/118850/checks?check_run_id=16458413896

Not sure what else I can do here.

Automatic Validation ended with:

Standard error:  Installation failed with exit code -1978335187 2023-09-03 14:58:17.922 [FAIL] Installer failed security check. Url: https://github.com/twpayne/chezmoi/releases/download/v2.39.0/chezmoi_2.39.0_windows_i386.zip Result: 0x80004005

Thanks! https://go.dev/doc/faq#virus is likely relevant, but you surely already know about this.

Closing in favor of https://github.com/microsoft/winget-pkgs/pull/119009


Update variables.scss to fix breaking change

Breaking change caused by deprecation of node-sass.
New version sass (dart-sass) requires division be used differently [math.div()]. So updated this to use vanilla css.
I guess it is important to note that you only get this error if you upgrade to dart-sass from node-sass. However, this fix provides backwards compatibility.

@cutterbl changed it to Math.div in #2079. Rip.


USSD Public functionality - User identification

Reach main menu state

@imsickofmaps Please review.

Two little comment things then :+1:


Typesafe CanvasStrategy ids

We identify canvas strategies by names, which are simple strings. This is not typesafe, typos can cause problems, and uniqueness is not guaranteed.
In this PR I introduced an id field in CanvasStrategy, which has a string literal union type. This id is typesafe, and we can still use the name field to contain a user digestible name.
Questions:

uniqueness is still not guaranteed, but maybe it is not that important, we don't have that quarantee with actions neither.
do we need this at all? We could just store the strategy objects everywhere, they are constants and never recreated, so they always keep their references.

uniqueness is still not guaranteed, but maybe it is not that important, we don't have that quarantee with actions neither.

I think this is good enough, because it forces you to refer to the full list of IDs when adding a new strategy (like we have to with actions).

do we need this at all? We could just store the strategy objects everywhere, they are constants and never recreated, so they always keep their references.

I agree, we could just store the strategy objects themselves wherever we currently use these IDs, with the caveat that we'd want to ensure we only ever compare them with reference equality any time they are featured in a keedDeepEquality call

do we need this at all? We could just store the strategy objects everywhere, they are constants and never recreated, so they always keep their references.

I agree, we could just store the strategy objects themselves wherever we currently use these IDs, with the caveat that we'd want to ensure we only ever compare them with reference equality any time they are featured in a keedDeepEquality call

I think I prefer this ID, for example it makes the redux devtool a little bit better


Responsive web design

Why This PR Adds Value
This PR makes a standard, easily extendible Sass directory structure. Its easier to use than the system used before where a lot of unrelated styles were being mixed in together.
What This PR Adds

Better Scss directory structure
@imports have been shifted to main.scss instead of all.scsss
Media query mixins added which follow a mobile first design approach
page.scss refactored to a mobile first approach

How This PR Could Be Improved

Was going to fix the navbar, but i think #62 already covers that

Issue This PR Closes
This closes #8

Hey @kronaemmanuel! This is a great PR with lots of high quality changes in it.
However, I'm seeing a lot of merge conflicts and I think it's because your PR changes a lot of side-wide architecture and it's taken a few days to be fully ready for merging.
I've marked this Pull Request as a Draft. If you'd like me to review it, fix all the merge conflicts and re-request a review from me.
Alternatively, you might want to branch off the latest main branch and try and make some of your changes again from scratch.


Caching Megalinter ?

Hello!
Basically I'm pulling<EMAIL_ADDRESS>to run megalinter on pull requests. This is something I'd like to avoid doing repeatedly as I am now and would like to cache the the pulled image.
When I used your action it seemed to recognize the image but in the "Post Cache Docker Images" it said that it had "No docker images to save".
Could you help me with this bit or even tell me if what I am trying to do is possible using your action?
Thank you for your time!

What you are trying to do is possible to do with docker-cache. We use this action to cache various flavors of MegaLinter ourselves. The action automatically filters out any Docker images present before it is run, so my first instinct would be to move the step earlier in your workflow as described in the README. Please let us know if that isn't the solution in your case.

The order I have laid out in my workflow basically follows this logic:

Set up job
Pull oxsecurity/megalinter/terraform:v7.3.0
Cache Docker Images
Checkout the Code
Run Megalinter

I feel like it is in the correct place in the workflow, but as of today I still haven't managed to make it work.
If you have any suggestions I'd appreciate them.
Thank you very much for your time!

To reiterate, you need to swap steps two and three. Note the following excerpt of the README:

Filter out Docker images that are present before the action is run

I did notice it at first but I've been running into the same issue which is:
As I am running the "Run Megalinter" step, which is currently sort of as follows:
- name: megalinter
uses<EMAIL_ADDRESS>I believe this triggers the Pull of the image to always come after the Set up job and before the cache step
Do you know of another way for me to try and do this?
Or could you exemplify or show me how you go about it yourself as you've said previously that you also use the action to cache various megalinter flavors?
I apologize for the request in advance but I'm quite new to GitHub so all of this is pretty new to me 😅
Thank you for your time once again!

I would guess from the snippet you pasted that the problem is that you are pulling the Docker image in a pre-step, meaning it happens before any main steps are run. docker-cache checks for pre-existing images in its main step, so this would cause the MegaLinter Docker image to be filtered out. docker-cache logs the images it finds during both its main and post steps, so you can verify whether MegaLinter is listed in both, meaning it was filtered out. mega-linter-runner automatically pulls the appropriate Docker image if it isn't present, so there's no need to pull it manually. We run MegaLinter as a pre-commit hook, so I am not sure how helpful our approach will be to you unless you also wish to run MegaLinter locally.

I'm going to assume that solved your problem, but please let me know if it didn't.


Improve WRITE_EXTERNAL_STORAGE permission handling

I have the 3 following remarks about the WRITE_EXTERNAL_STORAGE permission:

[ ] Why this permission is requested when the Home activity is resumed? This request is displayed just after the login, it is not understood by the new users. Wouldn't there be a better place to do it?

[ ] If the user doesn't grant this permission, the export of the E2E encryption keys fails. This permission must be checked before exporting the keys

[x] When the user wants to add an attachment in a room by taking a picture, the operation failed silently if this permission is not granted (The camera preview is launched but the taken picture is not attached). This permission must be required before launching the camera.

I can confirm this is a bit confusing. I have got into the habit of only granting permissions only when I know what action of mine they are needed for. This definitely doesn't seem to be needed to display the home screen (and indeed, refusing to grant that permission at this stage doesn't result in any incorrect behaviour).
It would make much more sense to ask for this permission specifically when the user tries to add attachments or export keys.

Fixed by #2518


migration - undefined index error

migrate:refresh and migrate:rollback - undefined index fixed

Just ran into this issue and was about to submit a PR, then spotted you had - nice work!


Restore filename to follow the hosts-%Y-%m-%d-%H-%M-%S format

On 2d696a42d98212310b80f6085172bd6d67eea7ea the '-' separating hosts from timestamp in backup filename was removed. This pull request is to restore the separator.

Thank you Guilherme @gprestes!
Merging.


Misaligned pointer dereference in debug mode

let af_flags = AddressFamilyFlags::IPV4 | AddressFamilyFlags::IPV6;
let proto_flags = ProtocolFlags::TCP | ProtocolFlags::UDP;
let sockets_info = get_sockets_info(af_flags, proto_flags).unwrap();

this code causes panic:
'misaligned pointer dereference: address must be a multiple of 0x8 but is 0x7f598f31e48c', /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/netstat2-0.9.1/src/integrations/linux/netlink_iterator.rs:192:24
Doesn't happen in release mode.
Operating System: CentOS Linux 7 (Core)
Kernel: Linux 3.10.0-1160.92.1.el7.x86_64

I think the problem is that the line (netlink_iterator.rs:192)
let tcpi = &*(RTA_DATA!(attr) as *const tcp_info);

should actually be read_unaligned (I skimmed the docs but couldn't find if this is expected or not, but I assume you do get correct info when running in release so the address calculation is correct).
@Payn I would appreciate if you could test this and maybe open a PR? 🙏🙂

@ohadravid so i created a PR with the change, not sure if done correctly, but it works now in debug mode.
https://github.com/ohadravid/netstat2-rs/pull/10

Fixed as part of #17


Reach naming parity with the JavaScript and .NET

e.g. BotContext -> TurnContext

Closing via #92


Author Contributions

@takayabe0505 or @ubi15 could you give me a brief description of each author's contribution to the software/paper?
https://github.com/openjournals/joss-reviews/issues/5201

Sure, here it is:
Enrico Ubaldi -- code development, data analysis, visualization, writing
Takahiro Yabe -- code development, data analysis, visualization, writing
Nicholas Jones -- data analysis, review of writing, supervision
Maham Faisal Khan -- data analysis, review of writing
Alessandra Feliciotti -- data analysis, review of writing
Riccardo Di Clemente -- data analysis, review of writing
Satish V. Ukkusuri -- data analysis, review of writing, supervision
Emanuele Strano -- data analysis, review of writing, supervision


[GLUTEN-6887][VL] Daily Update Velox Version (2024_12_19)

Upstream Velox's New Commits:
fdb309f5a by Krishna Pai, misc(revert): Backout `Add toString() to OutputBuffer stats` (11562) (11906)
b4d1ce0f2 by Christian Zentgraf, fix(build): Add remote function benchmark under benchmark flags (11905)
2e94f9583 by Kk Pulla, build: Setup nightly run of cache fuzzer (11901)
efbf68eab by Jimmy Lu, feat: Add T-Digest data structure (11665)
01e755ccc by duanmeng, docs: Update tracing doc (11890)
a2f9e6499 by Daniel Hunte, feat(fuzzer): Change Join Fuzzer filter flag from boolean to double (11880)
97da9a9e4 by Jialiang Tan, refactor: Remove old Task::create API (11888)
6c731208b by Jacob Wujciak-Jens, build(ci): Fix build metrics report (11839)
2d2cdbd37 by Xiaoxuan Meng, fix: Use the right row container to extract rows in grouping set (11899)

@PHILO-HE @zhouyuan


Added Russian translation (values-ru)

Not sure everything is correct, but I've checked twice

Also I can help you to translate Google Play app info

Hey, I've just pushed to the repository a new version of the app with a brand new strings.xml file. I updated a few strings and reorganized the file to make it more readable.
I'm looking forward to inserting the missing translations in the next update so could you please update this pull request with the new changes? Thanks in advance!


Port check_for_impurity.se to Vyper LLL

Fixes #69.
Work in progress for @gitcoinbot.
Ports https://github.com/ethereum/research/blob/master/impurity/check_for_impurity.se from the deprecated Serpent to Vyper LLL.
I'm placing it under the test utils for now as a separate file. I'll check w/ repo maintainers to see if they want to keep the source here or just include the contract creation transaction in conftest.py

For anyone following along, the next step is to manually compile the repeat form as the Vyper compiler requires a static number of rounds in the loop (that ranges over the valcode bytecode) with this form. There should not be a restriction on the next lower-level form. Then I will add some tests to confirm behavior and then can finally integrate with the rest of this repo.

We might want to put it in /contracts even though it is a .py file.
Thoughts @ChihChengLiang ?

agree that this file should go to /contracts

Ok, I need to sort out some issue that arose after rebasing master and trying to run the tests but as long as I verify I don't need to update anything then the purity_checker is ready to go.
Once I'm ready I'll remove the [WIP] tag and submit this PR.

Ok, I've integrated w/ the latest testing updates. This is ready to go!

Hey, I've been having a look at this and it's epic. Nice work @ralexstokes.
I started making some notes, they might be useful for newcomers trying to understand the LLL. I'll turn it into a blog post once the code settles. If you've got feedback (or solutions to my TODOs) I'd be keen to hear them in the comments of that gist. They're incomplete, but I post them prematurely in the hope they might save someone some time.
https://gist.github.com/paulhauner/f9915100e80305ba81ebd977b88c616c
I was asked have a look at this as I wrote the existing tests for the purity stuff. I spent the last several hours nutting out the LLL, I'll come back with any comments tomorrow :smile:

Thanks to @paulhauner, your post is a lifesaver that really helps the review.

Awesome, thanks @ralexstokes! I have merged your updates into my Gist. I will format this into a tidy blog post in the near future.
I'll use this info to finish my review then leave any comments here :smile:

Reading through the code and the summary. Excellent work @ralexstokes  and @paulhauner. When I originally put up this issue, I did not quite comprehend the task that I was asking.. 😬
This is killer.
Sorry @ralexstokes that it's taken a while for us to review, but as you know it's complicated and we want to give it the review it deserves.

Hey all,
I've had a look over the LLL and the tests. I am still impressed! I just have a comment about the tests in the context of this repo.
There are two sets of tests:

test_purity_checker.py: tests the purity checker in isolation
test_valcode_purity.py: tests the purity checker when used by deposit().

Given that both sets of tests have the same outcome (assuming valid deposit() params) it makes sense to me that the test params are unified and applied to the purity checker both in isolation and in implementation.
There are cases where test_valcode_purity.py tests things that test_purity_checker.py does not (e.g., list of invalid opcodes) and vice-versa (e.g., externally-owned address) , so unification would "kill two birds with one stone" (for lack of a less violent metaphor).
I can see the test structure you have added @ralexstokes is more sophisticated in some aspects than the structure currently used in test_valcode_purity.py, so if unification is desired I would be happy to unify these two structures, ensuring nothing is lost from the tests you have written. I wrote the existing structure so I am familiar with it already.
I also have a few minor points/queries about the purity checker operation (which are inherited from the original serpent version), but I think they may extend beyond the scope of this pull request, which I understand to be "port the existing purity checker to LLL", not "produce an ideal LLL purity checker". If we're aiming for the latter, let me know.
Keen to hear thoughts from the official reviewers. :smile:

great @paulhauner !
Yeah I started developing the new tests in isolation from this repo and then later merged them in and it seemed different enough at the time to keep them separate. I see the test_purity_checker tests as "unit tests" for the contract itself and then the test_valcode_purity tests as more "integration tests" that are end-to-end, in some sense.  But I'm also open to merging the tests however makes the most sense!
And I'm happy to go over the remaining points although I'm guessing they get to some of the unresolved questions around what direction this thing should take. Would love to hear everyone's thoughts.

I was getting pretty deep into this thing over the long weekend. It stood up to all the attack vectors I could come up with during that time.
One thing I did notice is that it seems to rely on an implicit assumption that the 0x0 address will always be impure. This is also the case in the Serpent version.
I gather this from lines 70, 71: If the penultimate opcode (relative to the call-type opcode) does not have args, then an index_pushargs() call on that opcode will return 0. Because of this, 0 will be assumed to be the address supplied to the call and then tested against the approved_addrs map. (TL;DR address defaults to zero in some cases).
This seems like a pretty reasonable assumption to me. Vitalik wrote the original Serpent version so I guess it seemed reasonable to him too. I just wanted to bring it up for the sake of information synchronicity. :relaxed:

Finally reviewed code and @paulhauner's doc. Doing the merge. Thanks everyone!

How do I submit work?
I think @gdipri01 has to do it because he funded it.


Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-modified.json.gz

Hi Team,
We have downloaded DCT 5.0.0 and tried to run through CLI, but it is giving us the error as:
[INFO] Checking for updates
[ERROR] Unable to download meta file: https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-modified.json.gz
[ERROR] Failed to initialize the RetireJS repo
[WARN] Unable to update 1 or more Cached Web DataSource, using local data instead. Results may not include recent vulnerabilities.
[ERROR] Unable to continue dependency-check analysis.
[ERROR] One or more fatal errors occurred
[ERROR] Failed to initialize the RetireJS repo
[ERROR] No documents exist
Not sure what I am missing here.

My guess is you are behind a proxy that is blocking access to the NVD and github (two locations where data files are downloaded from); please see https://jeremylong.github.io/DependencyCheck/data/index.html.
To get a more detailed error report please execute:
dependency-check.sh --purge
dependency-check.sh --updateonly --log odc.log

More detailed error messages as to what exactly has gone wrong will be in the odc.log file.

I'm having exactly the same problem, except I'm self hosting the files offline. I can download the https://mysite/somepath/json/cve/1.0/nvdcve-1.0-modified.json.gz file no problem using dependency-check-maven:5.0.0-M2, but NOT with 5.0.0, so something must have changed between the two versions related to downloading files like this.
Looks Like I can do what you suggest above by doing these:
dependency-check-maven:purge
dependency-check-maven:update-only
Except I can't find how to enable/configure logging for the dependency-check-maven plugin at: https://jeremylong.github.io/DependencyCheck/dependency-check-maven/configuration.html
How do I turn on logging like you suggest above, but for the maven plugin? If you explain how, I'll look at those logs to see if I can find out what's going wrong. But the download IS available, so it's not a proxy blocking problem.

@davewichers logging for Maven is enabled by supplying -X as a parameter. This turns on debug logging for Maven.  Example:
mvn org.owasp:dependency-check-maven:5.0.0:check -X

With 5.0.0 you need to have the full mirror of the NVD JSON files (including the json.gz and the meta files).  This can be achieved using the nist-data-mirror.

Apparently it is the missing nvdcve-1.0-modified.meta file that is missing, not the nvdcve-1.0-modified.json.gz file, even though that is what the error message is actually saying. Something like:
Unable to download meta file: nvdcve-1.0-modified.json.gz
Which is obviously misleading. This is caused by a set of related bugs in this file:
https://github.com/jeremylong/DependencyCheck/blob/master/core/src/main/java/org/owasp/dependencycheck/data/update/NvdCveUpdater.java (lines 355-363) - where the set of error messages use the variable url, when they should be using the variable metaUrl instead.
One final question: I'll work on getting that file to fix my setup. Do I need ALL the meta files, i.e., modified.meta plus recent.meta, plus one for each of the years? Or just this modified.meta file?

You need all of the meta files - using the nist-data-mirror is the easiest way to ensure you have all the files.  And yes - I agree the error message is confusing and it will be updated.

Minor update - with regard to the meta data files. You do not need the recent meta data file. ODC does not use any of the "recent" files. Only the modified and then 2012-[current year].

Facing the same issue  :

@shubhankar1114 Please take a look at #2222 and try the Dcom.sun.security.enableAIAcaIssuers=true option.


feat: reset fork method

What I did
Adds method for hardhat_reset RPC
How I did it
https://hardhat.org/hardhat-network/guides/mainnet-forking.html#resetting-the-fork
How to verify it
See test!
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

cl


500 Error,delete and rebuild the same name of the repo

Delete and rebuild the same name of the repo, the system reported 500 error.
please, what is the reason? thanks!

I think it's same as https://github.com/gogits/gogs/issues/1738 ?

ping @cnwangzd

<EMAIL_ADDRESS>Best Regards,
Email<EMAIL_ADDRESS>2016-01-09 13:03 GMT+08:00 无闻<EMAIL_ADDRESS>
I think it's same as #1738 https://github.com/gogits/gogs/issues/1738 ?
—
Reply to this email directly or view it on GitHub
https://github.com/gogits/gogs/issues/2368#issuecomment-170195576.

Close due to lack of feedback.


Unexpected Behaviour with vm.expectRevert()

To summarize - vm.expectRevert(bytes("Custom Error Message")) will pass a test regardless of if the custom error message actually matches.
Contract function for reference:
function fund() public payable {
        require(msg.value >= MINIMUM_USD, "You need to spend more ETH!");
        s_addressToAmountFunded[msg.sender] += msg.value;
        s_funders.push(msg.sender);
    }

Test being run:
function testFailsWithoutEnoughETH() public {
        vm.expectRevert(bytes("Different Words!")); //expect a revert to happen
        fundMe.fund();
    }

Result in Terminal:
equious@DESKTOP-HTA2B2C:~/github-discussion-help/Foundry__FundMe$ forge test --mt testFailsWithoutEnoughETH -vvvv
[⠒] Compiling...
[⠃] Compiling 3 files with 0.8.21
[⠊] Solc 0.8.21 finished in 662.23ms
Compiler run successful!

Running 1 test for test/FundMeTest.t.sol:FundMeTest
[PASS] testFailsWithoutEnoughETH() (gas: 8672)
Traces:
  [8672] FundMeTest::testFailsWithoutEnoughETH()
    ├─ [0] VM::expectRevert(Different Words!)
    │   └─ ← ()
    ├─ [263] FundMe::fund()
    │   └─ ← revert: You need to spend more ETH!
    └─ ← Error != expected error: You need to spend more ETH! != Different Words!

Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 1.38ms

Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests)

The test seems to recognize the error is not what's expected, but passes anyway.
A further, perhaps related behaviour I can't explain is that removing the arguments passed to vm.expectRevert() - which should result in a pass for any revert - actually fails, despite catching the revert.
Function
function testFailsWithoutEnoughETH() public {
        vm.expectRevert(); //expect a revert to happen
        fundMe.fund();
    }

Result in Terminal:
  [8302] FundMeTest::testFailsWithoutEnoughETH()
    ├─ [0] VM::expectRevert(custom error f4844814:)
    │   └─ ← ()
    ├─ [263] FundMe::fund()
    │   └─ ← revert: You need to spend more ETH!
    └─ ← ()

Test result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 1.28ms

Ran 1 test suites: 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/FundMeTest.t.sol:FundMeTest
[FAIL. Reason: assertion failed] testFailsWithoutEnoughETH() (gas: 8302)

Encountered a total of 1 failing tests, 0 tests succeeded

What Foundry version are you on?

v0.2.0 @DaniPopes

@Equious Can you share your forge -v? We haven't updated the version in the CLI but the date should update

Here you are! @gakonst

Ah I see what's happening here, @Equious your test starts with "testFail" which expects the test to fail. Either rename the test to test_fails..., or remove the expectRevert


[Observation] Transition to peer macros instead of arbitrary members

This removes the arbitrary member emission from @Observable macro application and uses peer macros instead (but leaves member iteration to ensure initializers are satisfied till https://github.com/apple/swift/pull/66283 lands)
Resolves rdar://110327683

@swift-ci please test