rest parameter for destructuring assignments results as undefined variable

For code like this:
const [a, ...rest] = ['1', '2', '3'];
console.log(a);
console.log(rest);

I'm having an error:
13:12  error    'rest' is not defined                   no-undef

Fixed as of 1.0.10, thanks!


Support tenant wise configurations for Local and Multi-factor authenticators

Is your feature request related to a problem? Please describe.
Current for local authenticators such as TOTP and for authenticator we are defining certain configuration at the server level using the application-authentication.xml
For example, in TOTP we have,
[authentication.authenticator.totp.parameters]
authenticationMandatory=true
enrolUserInAuthenticationFlow=true
TOTPAuthenticationEndpointURL="totpauthenticationendpoint/totp.jsp"
TOTPAuthenticationEndpointErrorPage="totpauthenticationendpoint/totpError.jsp"
TOTPAuthenticationEndpointEnableTOTPPage="totpauthenticationendpoint/enableTOTP.jsp"
Issuer="WSO2"
UseCommonIssuer=true

Some of these params such as enrolUserInAuthenticationFlow need to decided tenant-wise. Currently, we do not have a way to do so generally. Noticed that in several connectors (TOTP, Email OTP) we have a mechanism to add key-value pairs to the registry to define these tenant-wise. But since we are moving away from the registry this might not be ideal.
Describe the solution you would prefer

One possible solution would be to make use of the IdentityConnectorConfig interface and approach we have taken to store and retrieve governance connector configurations. This will enable us to define configurations of tenants for these authenticators and retrieve them.

Additional Considerations

Need to evaluate whether we need to allow uses to define/override these configurations at the SP level too?

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Integration as itk remote

Here is the remaining of the changes to allow TubeTK to also be built as ITK remote module.
From: @LucasGandel @jcfr

Looks good.  Great code style and logical flow.   Only suggestion is to consider renaming the applications in the CompareTools folder for clarity and easy of discovery.

Thanks for the review.
@LucasGandel did an awesome job !

Perhaps the applications should be renamed to "CompareImages" and "CompareJsonFiles" and "CompareTextFiles"?

Good point. That will be a follow up PR.


Support passing context with AEAD interface

Help us help you
We are using Tink extensively to provide encryption for calls through out GRPC proxy as part of our platform offering.
Is your feature request related to a problem?
The problem we are seeing is that we are unable to link our encrypt and decryption lower level functionality, such as calling out to our KMS to our app workflow traces. This is because the tink.AEAD interface functions to not accept a context so the linking context back to the original GRPC request is lost.
What sort of feature would you like to see?
It would be very useful for the encrypt and decrypt functions under the tink.AEAD interface to support passing the context in.
This would support:

Properly linked spans and traces back to the parent spans of the higher functions
Cancel/timeout of external API calls, such as when a remote KMS is called during encrypt/decrypt

Passing the context is part of GCP/AWS cloud api calls and is generally a standard method for any remote API call.
Have you considered any alternative solutions?
I can't think of an alternative solution
Would you like to add additional context?
You can see this issue in the gpc-kms encrypt/decrypt functions that have lost context and therefore can

Note: https://github.com/google/tink/issues/255 asked for the same thing and is much older.

Hey I'm interested in working on this, does this proposal need to be approved? This interface change is breaking and looks like it would require a major bump.

We have planed to add this, but we don't have a timeline for it yet.


Add testing for read_parquet from HDFS

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): all
Modin version: 0.8.0
Python version: 3.7.7

Describe the problem
Currently read_parquet function hasn't any CI testing for HDFS.
Notes:
For including testing need to:

Install java
Install hadoop
Set environment vars:
3.1. HADOOP_HOME=whereis hadoop
3.2. ARROW_LIBHDFS_DIR=$HADOOP_HOME/lib/native
3.3. JAVA_HOME=whereis java
Possible test case:

def test_from_parquet_remote_hdfs():
    path = "hdfs://" + os.getcwd() + "/modin/pandas/test/data/hdfs.parquet"
    pandas_df = pandas.read_parquet(path)
    modin_df = pd.read_parquet(path)
    df_equals(modin_df, pandas_df)

Source code / logs

Looks like this has been added as of https://github.com/modin-project/modin/pull/2523


added flights model and mock data for flights

closes #8

Great formatting. Top notch work. Way to go. Keep it up.


Change event of scroll-on-focus directive to Click

Change the scroll-on-focus directive: focus to click
Add directive to meetup create.html page

I just wonder do I need to change directive name as well?
Because It is click event rather than focus
scroll-on-focus => scroll-on-click
@rong4188

@lizhen325 yes, you need to change directive name. also, the directive should be applied to meetup/edit.html


Add game manual and reorganize

Add sample docs and change stubs to docs
Add game manuals
Add Docker
Update usage.rst

Just curious, in what capacity is docker being used here?

For me it makes it really easy to just test across computers because all I need to do is a docker compose up and its running on a local port. Its a neat thing that I would entirely get not adding to the main repo but it does in my experience make development really easy though most people would prefer just doing a make html which probably makes sense. Its something I have though so I might as well offer it. It also makes it work well with docker dev environments which I also like using.

The whole point of the /stubs directory was to make it painfully obvious to anyone who is paying attention that the documentation stubs are actually stubs, and that nobody intends for that content to be "real". This also gives us a way to determine how many "fake" pages we have, as all "fake" pages should be stubs. I'm not okay with just moving the stubs out.

I wanted to add a bit of context here as well, if you're considering "fixing" the organization: I'd like to mimic the structure of the WPILib documentation. I want all pages organized within topics and be within their own directory, For instance, CAD should have a structure such as:
/docs/source/cad

index.rst
/ptc-onshape
/ptc-onshape/ptc-onshape.rst
/ptc-onshape/images
/autodesk-fusion
/autodesk-fusion/autodesk-fusion.rst
/autodesk-fusion/images
/dassault-systems-solidworks
/dassault-systems-solidworks/dassault-systems-solidworks.rst
/dassault-systems-solidworks/images

The index.rst explains what CAD is used for, why it's good, and so on, and contains links to each of the individual CAD system files. Then the individual .rst files in the directories help explain specifics for each CAD system, how to get and use for free, links to tutorials for that system, and so on. The /images directory would then store all the images that the .rst file needed.
I hope this makes sense. I do not want the main /docs/source directory to just be littered with .rst files with no organization and some master /images file for all the images we need. I want organization and cleanup to be simple, even if developing the organization takes a little elbow grease.


disable DebugOpcodes in evm contract

Description
Disable DebugOpcodes in burrow state,  it hurts performance seriesly
Type of change

[x] New feature (non-breaking change which adds functionality)

Codecov Report

Merging #225 (9ffd40c) into master (cd5e7dc) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.51%   47.25%   -0.26%
==========================================
  Files         133      133
  Lines       11371    11370       -1
==========================================
- Hits         5403     5373      -30
- Misses       4848     4873      +25
- Partials     1120     1124       +4

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/network/p2pv1/conn.go
54.83% <0.00%> (-6.46%)
:arrow_down:

bcs/consensus/tdpos/common.go
64.06% <0.00%> (-3.13%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
43.04% <0.00%> (-3.05%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
52.40% <0.00%> (-1.93%)
:arrow_down:

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
51.44% <0.00%> (-0.97%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5e7dc...9ffd40c. Read the comment docs.

Codecov Report

Merging #225 (9ffd40c) into master (cd5e7dc) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.51%   47.37%   -0.15%
==========================================
  Files         133      133
  Lines       11371    11370       -1
==========================================
- Hits         5403     5386      -17
- Misses       4848     4862      +14
- Partials     1120     1122       +2

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/consensus/tdpos/common.go
64.06% <0.00%> (-3.13%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
43.04% <0.00%> (-3.05%)
:arrow_down:

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
51.44% <0.00%> (-0.97%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5e7dc...9ffd40c. Read the comment docs.

Codecov Report

Merging #225 (da10dc8) into master (6cf4c02) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.45%   47.28%   -0.17%
==========================================
  Files         133      133
  Lines       11414    11413       -1
==========================================
- Hits         5416     5397      -19
- Misses       4863     4880      +17
- Partials     1135     1136       +1

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/network/p2pv1/conn.go
54.83% <0.00%> (-6.46%)
:arrow_down:

bcs/consensus/tdpos/common.go
64.06% <0.00%> (-3.13%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
40.16% <0.00%> (-1.61%)
:arrow_down:

bcs/network/p2pv1/server.go
56.46% <0.00%> (-1.37%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
55.06% <0.00%> (-0.89%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
50.46% <0.00%> (+0.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf4c02...da10dc8. Read the comment docs.

Codecov Report

Merging #225 (da10dc8) into master (6cf4c02) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.45%   47.41%   -0.04%
==========================================
  Files         133      133
  Lines       11414    11413       -1
==========================================
- Hits         5416     5412       -4
- Misses       4863     4865       +2
- Partials     1135     1136       +1

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/network/p2pv1/server.go
56.46% <0.00%> (-1.37%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
55.06% <0.00%> (-0.89%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
50.46% <0.00%> (+0.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf4c02...da10dc8. Read the comment docs.

Codecov Report

Merging #225 (02f2799) into master (6cf4c02) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.45%   47.34%   -0.11%
==========================================
  Files         133      133
  Lines       11414    11413       -1
==========================================
- Hits         5416     5403      -13
- Misses       4863     4876      +13
+ Partials     1135     1134       -1

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/network/p2pv1/conn.go
54.83% <0.00%> (-6.46%)
:arrow_down:

bcs/consensus/tdpos/common.go
64.06% <0.00%> (-3.13%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
40.16% <0.00%> (-1.61%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
56.82% <0.00%> (+0.88%)
:arrow_up:

kernel/consensus/base/driver/chained-bft/smr.go
50.46% <0.00%> (+0.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf4c02...02f2799. Read the comment docs.

Codecov Report

Merging #225 (00d1097) into master (6cf4c02) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.45%   47.35%   -0.10%
==========================================
  Files         133      133
  Lines       11414    11413       -1
==========================================
- Hits         5416     5405      -11
- Misses       4863     4872       +9
- Partials     1135     1136       +1

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/network/p2pv1/conn.go
54.83% <0.00%> (-6.46%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
40.96% <0.00%> (-0.81%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
50.46% <0.00%> (+0.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf4c02...00d1097. Read the comment docs.

Codecov Report

Merging #225 (00d1097) into master (6cf4c02) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   47.45%   47.40%   -0.05%
==========================================
  Files         133      133
  Lines       11414    11413       -1
==========================================
- Hits         5416     5410       -6
- Misses       4863     4869       +6
+ Partials     1135     1134       -1

Impacted Files
Coverage Δ

bcs/contract/evm/creator.go
26.98% <ø> (-0.39%)
:arrow_down:

bcs/network/p2pv1/conn.go
54.83% <0.00%> (-6.46%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
48.40% <0.00%> (-0.92%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
40.96% <0.00%> (-0.81%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
56.82% <0.00%> (+0.88%)
:arrow_up:

kernel/consensus/base/driver/chained-bft/smr.go
50.46% <0.00%> (+0.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf4c02...00d1097. Read the comment docs.


add a 3rd tile,sync form en version

add "ServiceAccount控制器 {#ServiceAccount controller}" to https://kubernetes.io/zh-cn/docs/reference/access-authn-authz/service-accounts-admin/#serviceaccount-admission-controller

Why did the build fail?

Please try to squash your commits into a single one: https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits

Please try to squash your commits into a single one: https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits
OK, finished

Please recommit to trigger the netlify gate.

Please recommit to trigger the netlify gate.

What should I do?

Please recommit to trigger the netlify gate.

What should I do?

In your local console do this:
git commit --amend --no-edit --allow-empty
git push -f

Please recommit to trigger the netlify gate.

What should I do?

In your local console do this:
git commit --amend --no-edit --allow-empty
git push -f

Thanks, finished.

/lgtm


option: readOnly doesn't work

version:
"vue": "2.3.3",
"vue-quill-editor": "^3.0.6"
option: {
readOnly: true,
theme: 'bubble'
}
but i can still edit, sorry to bother, have a nice day!

I have the same question and disable doesn't work either .
So I want to ask you how do you show the content generated by the editor.

:disabled='disabled'   doesn't work

use<EMAIL_ADDRESS>plz.

I set disabled,and it work!

The readOnly options isn't working but :disabled='disabled' is working as expected. Thanks!

readOnly: true not working for me as well. To enable/disable the editor, you have to bind the disabled to the component like this:
<quill-editor
      v-model='content'
      :options='editorOption'
      :disabled='disabled'
></quill-editor>

Then you can toggle the disabled in your data property.

This is a good idea and now I success to make it disabled.

What if readOnly: true and :disabled="disabled" both don't work?

yeah，the readonly property is not work，but :disabled='true' is worked

<quill-editor
      v-model='content'
      :options='editorOption'
      :disabled='disabled'
></quill-editor>

Then you can toggle the disabled in your data property.

With multiple editors on one page this does not work quite well. What did the trick for me was to initially disable all editors with :disabled='disabled' and then listen on the @focus-event.
onEditorFocus(quill) {
  if (!quill.isEnabled()) {
    quill.enable()
    quill.focus()
  }
}


The parameter entrypoints..http.tls.domains is not used if rules in routers are only PathPrefix

Do you want to request a feature or report a bug?
Bug
What did you do?

When I specify TLS domains for Letsencrypt in entrypoints section
and I have no domains specified for Letsencrypt in router section
and all of my router rules are based on PathPrefix
then the certificate is not requested from Letsencrypt

What did you expect to see?
I would expect domains for cert generation to be picked up from entrypoints section
My docker-compose file
version: '3'

services:
  reverse-proxy:
    # The official v2 Traefik docker image
    image: traefik:v2.3

    restart: always

    # Don't put comments in this block as it is a single long string
    command:
      - "--log.level=DEBUG"
      - "--providers.docker"

      - "--entryPoints.websecure.address=:443"
      - "--entrypoints.websecure.http.tls=true"
      - "--entrypoints.websecure.http.tls.certResolver=letsencrypt"
      - "--entrypoints.websecure.http.tls.domains[0].main=domain.example.com"   # put your domain name here

      - "--certificatesresolvers.letsencrypt.acme.email=your@emailcom"
      - "--certificatesresolvers.letsencrypt.acme.storage=/traefik/acme.json"
      - "--certificatesresolvers.letsencrypt.acme.caserver=https://acme-staging-v02.api.letsencrypt.org/directory"
      - "--certificatesresolvers.letsencrypt.acme.tlschallenge=true"

    ports:
      - "443:443"

    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro  # So that Traefik can listen to the Docker events
      - /traefik:/traefik

    labels:
      - "traefik.http.routers.dashboard.entrypoints=dashboard"
      - "traefik.http.routers.dashboard.tls=true"
      - "traefik.http.routers.dashboard.tls.certresolver=letsencrypt"
      - "traefik.http.routers.dashboard.rule=(PathPrefix(`/api`) || PathPrefix(`/dashboard`))"

  httpbin:
    # A container that exposes an API to show its IP address
    image: kennethreitz/httpbin

    restart: always

    labels:
      - "traefik.http.routers.app.rule=PathPrefix(`/`)"
      - "traefik.http.routers.app.entrypoints=websecure"
      - "traefik.http.routers.app.tls.certresolver=letsencrypt"
#      - "traefik.http.routers.app.tls.domains[0].main=domain.example.com"       # put your domain name here
      - "traefik.http.services.app.loadbalancer.server.port=80"

With this config certificates are not generated.
To trigger certificate generation do either of these:

comment out any of the lines containing PathPrefix
uncomment the line traefik.http.routers.app.tls.domains[0].main

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
$ docker-compose up
Creating network "ubuntu_default" with the default driver
Creating ubuntu_reverse-proxy_1 ... done
Creating ubuntu_httpbin_1       ... done
Attaching to ubuntu_httpbin_1, ubuntu_reverse-proxy_1
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Configuration loaded from flags."
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Traefik version 2.3.1 built on 2020-09-29T15:49:06Z"
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=debug msg="Static configuration loaded {\"global\":{\"checkNewVersion\":true},\"serversTransport\":{\"maxIdleConnsPerHost\":200},\"entryPoints\":{\"websecure\":{\"address\":\":443\",\"transport\":{\"lifeCycle\":{\"graceTimeOut\":10000000000},\"respondingTimeouts\":{\"idleTimeout\":180000000000}},\"forwardedHeaders\":{},\"http\":{\"tls\":{\"certResolver\":\"letsencrypt\",\"domains\":[{\"main\":\"mayak.timurb.ru\"}]}}}},\"providers\":{\"providersThrottleDuration\":2000000000,\"docker\":{\"watch\":true,\"endpoint\":\"unix:///var/run/docker.sock\",\"defaultRule\":\"Host(`{{ normalize .Name }}`)\",\"exposedByDefault\":true,\"swarmModeRefreshSeconds\":15000000000}},\"log\":{\"level\":\"DEBUG\",\"format\":\"common\"},\"certificatesResolvers\":{\"letsencrypt\":{\"acme\":{\"email\":\"erthad@gmail.com\",\"caServer\":\"https://acme-staging-v02.api.letsencrypt.org/directory\",\"storage\":\"/traefik/acme.json\",\"keyType\":\"RSA4096\",\"tlsChallenge\":{}}}}}"
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="\nStats collection is disabled.\nHelp us improve Traefik by turning this feature on :)\nMore details on: https://doc.traefik.io/traefik/contributing/data-collection/\n"
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Starting provider aggregator.ProviderAggregator {}"
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=debug msg="Start TCP Server" entryPointName=websecure
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Starting provider *docker.Provider {\"watch\":true,\"endpoint\":\"unix:///var/run/docker.sock\",\"defaultRule\":\"Host(`{{ normalize .Name }}`)\",\"exposedByDefault\":true,\"swarmModeRefreshSeconds\":15000000000}"
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Starting provider *acme.Provider {\"email\":\"erthad@gmail.com\",\"caServer\":\"https://acme-staging-v02.api.letsencrypt.org/directory\",\"storage\":\"/traefik/acme.json\",\"keyType\":\"RSA4096\",\"tlsChallenge\":{},\"ResolverName\":\"letsencrypt\",\"store\":{},\"ChallengeStore\":{}}"
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Testing certificate renew..." providerName=letsencrypt.acme
reverse-proxy_1  | time="2020-10-20T11:21:18Z" level=info msg="Starting provider *traefik.Provider {}"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Configuration received from provider letsencrypt.acme: {\"http\":{},\"tls\":{}}" providerName=letsencrypt.acme
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Configuration received from provider internal: {\"http\":{\"services\":{\"noop\":{}},\"models\":{\"websecure\":{\"tls\":{\"certResolver\":\"letsencrypt\",\"domains\":[{\"main\":\"mayak.timurb.ru\"}]}}}},\"tcp\":{},\"tls\":{}}" providerName=internal
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No default certificate, generating one"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Provider connection established with docker 19.03.8 (API 1.40)" providerName=docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Configuration received from provider docker: {\"http\":{\"routers\":{\"app\":{\"entryPoints\":[\"websecure\"],\"service\":\"app\",\"rule\":\"PathPrefix(`/`)\",\"tls\":{\"certResolver\":\"letsencrypt\"}},\"dashboard\":{\"entryPoints\":[\"dashboard\"],\"service\":\"reverse-proxy-ubuntu\",\"rule\":\"(PathPrefix(`/api`) || PathPrefix(`/dashboard`))\",\"tls\":{\"certResolver\":\"letsencrypt\"}}},\"services\":{\"app\":{\"loadBalancer\":{\"servers\":[{\"url\":\"http://<IP_ADDRESS>:80\"}],\"passHostHeader\":true}},\"reverse-proxy-ubuntu\":{\"loadBalancer\":{\"servers\":[{\"url\":\"http://<IP_ADDRESS>:80\"}],\"passHostHeader\":true}}}},\"tcp\":{},\"udp\":{}}" providerName=docker
httpbin_1        | [2020-10-20 11:21:19 +0000] [1] [INFO] Starting gunicorn 19.9.0
httpbin_1        | [2020-10-20 11:21:19 +0000] [1] [INFO] Listening at: http://<IP_ADDRESS>:80 (1)
httpbin_1        | [2020-10-20 11:21:19 +0000] [1] [INFO] Using worker: gevent
httpbin_1        | [2020-10-20 11:21:19 +0000] [8] [INFO] Booting worker with pid: 8
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="entryPoint \"dashboard\" doesn't exist" routerName=dashboard@docker entryPointName=dashboard
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="no valid entryPoint for this router" routerName=dashboard@docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating middleware" middlewareName=pipelining middlewareType=Pipelining entryPointName=websecure routerName=app@docker serviceName=app
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating load-balancer" serviceName=app entryPointName=websecure routerName=app@docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating server 0 http://<IP_ADDRESS>:80" entryPointName=websecure routerName=app@docker serviceName=app serverName=0
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Added outgoing tracing middleware app" middlewareType=TracingForwarder entryPointName=websecure routerName=app@docker middlewareName=tracing
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating middleware" middlewareName=traefik-internal-recovery middlewareType=Recovery entryPointName=websecure
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="entryPoint \"dashboard\" doesn't exist" routerName=dashboard@docker entryPointName=dashboard
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="no valid entryPoint for this router" routerName=dashboard@docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No default certificate, generating one"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="entryPoint \"dashboard\" doesn't exist" routerName=dashboard@docker entryPointName=dashboard
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="no valid entryPoint for this router" routerName=dashboard@docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating middleware" entryPointName=websecure serviceName=app routerName=app@docker middlewareName=pipelining middlewareType=Pipelining
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating load-balancer" serviceName=app routerName=app@docker entryPointName=websecure
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating server 0 http://<IP_ADDRESS>:80" serverName=0 routerName=app@docker entryPointName=websecure serviceName=app
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Added outgoing tracing middleware app" middlewareType=TracingForwarder entryPointName=websecure routerName=app@docker middlewareName=tracing
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="Creating middleware" entryPointName=websecure middlewareName=traefik-internal-recovery middlewareType=Recovery
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="entryPoint \"dashboard\" doesn't exist" entryPointName=dashboard routerName=dashboard@docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=error msg="no valid entryPoint for this router" routerName=dashboard@docker
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No default certificate, generating one"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No domain parsed in provider ACME" providerName=letsencrypt.acme routerName=app@docker rule="PathPrefix(`/`)"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No domain parsed in provider ACME" providerName=letsencrypt.acme routerName=dashboard@docker rule="(PathPrefix(`/api`) || PathPrefix(`/dashboard`))"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No domain parsed in provider ACME" providerName=letsencrypt.acme routerName=app@docker rule="PathPrefix(`/`)"
reverse-proxy_1  | time="2020-10-20T11:21:19Z" level=debug msg="No domain parsed in provider ACME" providerName=letsencrypt.acme rule="(PathPrefix(`/api`) || PathPrefix(`/dashboard`))" routerName=dashboard@docker

For successful certificate generation please comment/uncomment the appropriate loglines in the docker-compose.yaml and see it yourself.

Actually if I don't uncomment the line "traefik.http.routers.app.tls.domains[0].main=domain.example.com" the certificate is not requested as well (which is contrary to documentation here https://doc.traefik.io/traefik/reference/static-configuration/cli/) — the private keys is created but that's all.
With all router rules having PathPrefix even private key is not created and acme.json is an empty json file.

Hi @timurb ,
I suppose the issue comes from the configuration.
As said in the documentation:

If a TLS section (i.e. any of its fields) is user-defined, then the default configuration does not apply at all.

So, as you defined - "traefik.http.routers.app.tls.certresolver=letsencrypt", the default configuration will not be applied.
Try without any label with tls configuration or with all labels needed.
Could you please confirm this hypothesis ?

Thanks for confirming the issue. :+1:
So I close the issue accordingly.
If you want clues on your configuration, you can use api.
If you would like to discuss this further, please visit the community forum.

I don't think the issue is resolved and I'm sorry if I didn't do well with the new issue description.
The issue should be: produce debug/info message in logs if the configuration override is happening.
And probably one more: produce warning message in logs if incomplete TLS configuration is found for the endpoint.
Do you think we should reopen this issue to keep the context or create new one(s) for visibility and detailed discussion?

Actually I see the message No domain parsed in provider ACME but I'm able to understand its meaning only after you explained it so there still needs to be some clue in log messages that something is missing in the configuration:

producing a new logline that the override has happened for this config and parent configuration was ignored — as a standalone message
extending the current error message to something like No domain parsed in provider ACME. Did you define "domains" section? and/or probably raising the severity to warning/error.
producing warning message if TLS configuration for the endpoint is incomplete
mark the documentation snippet you quoted with a large /!\ or (i) symbol because a small note in the middle of a paragraph effectively nullifies it completely in certain circumstances

My idea and goal behind that is when the next person faces the same issue they are able to understand it without creating the ticket/forum thread etc. Currently you have to see (and have at hand) a couple of successful TLS installations to be able to understand what is happening in this scenario without external support.

Hi @timurb,
Thanks for the feedback.
The logging part is not easy because we can't know when the configuration is incomplete or if it is attended.
And if we choose to log any potential misconfiguration, it will be a spam mechanism :wink:
It would be great if you can open a specific issue for the documentation and then work on PR that will fix the documentation.
Then, if you think we can do more, you can create a more open issue on other improvements that needs more thought.
WDYT ?


'usage in our docs' link points to localhost

Another nit, but the 'usege in our docs' points to a localhost link!

submitted a PR to fix thanks for the catch!

🫡 Latest changes fixed this!


PIC-4149 do not bother to rewrite web service URL

The calling code from CGI does not follow redirects. We could investigate non-301 URL rewriting, or try this which does not rewrite the URL at all and just serves a response to the original request

We will check the retry strategy for crime-portal-gateway before merging this


Match multiple fields

match-sorter version: 2.3.0

I love this package, but I usually want to filter through multiple fields.
const objList = [
  {name: 'Janice', color: 'Green'},
  {name: 'Fred', color: 'Orange'},
  {name: 'George', color: 'Blue'},
  {name: 'Jen', color: 'Red'},
]

matchSorter(objList, 'ge bl', {keys: ['name', 'color']})

This example results in [], but I would expect the result to be [{name: 'George', color: 'Blue'}].
So it only tries to match one field, and ignores the other fields.

I'm confused... So you want the search to work across fields?

Yes exactly. I usually work with huge lists of objects and want to sort and filter across multiple fields with one input..

Hey @MatthiasF999,
You could do this:
function matchSorterAcrossKeys(list, search, options) {
  const joinedKeysString = item => options.keys.map(key => item[key]).join(' ')
  return matchSorter(list, search, {
    ...options,
    keys: [...options.keys, joinedKeysString],
  })
}

const objList = [
  {name: 'Janice', color: 'Green'},
  {name: 'Fred', color: 'Orange'},
  {name: 'George', color: 'Blue'},
  {name: 'Jen', color: 'Red'},
]

const matches = matchSorterAcrossKeys(objList, 'ge bl', {keys: ['name', 'color']})
// matches is: [{name: 'George', color: 'Blue'}]

This is not a typical use case so we wont be supporting it any better than that. I personally feel like this is a pretty good solution though. Good luck!


Add PGP/INLINE "compatibility" mode (WIP)

Another WIP PR. This adds pgp "compatibility" mode, i.e., pgp/inline.
Not happy with the UI at all, still thinking about how to do this better. It might be acceptable with this approach if we use a material style switch and not this ugly old thing, but not sure about that.
I'm thinking about adding another icon next to the crypto one while compat mode is enabled, and move the "enable compat mode" to the options. Ideally, use of pgp/inline should be an exceptional state, so it's not a huge problem with screen estate, and if the user clicks it they can be provided with an explanation of why it was enabled automatically (or disable it).

Do you think compatability means more to most people than inline? I'm not sure which we should be using both internally and in the UI.

+1 For material design. I'm unable to decrypt PGP/Inline in the latest alpha, is support for inline pgp dropped?

Worked on this one a bit. I moved the setting into the overflow menu, added a dialog with an explanation, and also an indicator next to the crypto status icon. Not quite happy with the icon itself I think, I used the only remotely suitable one for "compatibility" I could find (source). I also added a flag so the mode is preserved for drafts.
Have a screenshot:

Still missing:

display explanation only once
enable automatically based on replied to message
possibly: flag contact when message is sent and enable automatically for this contact in the future?
refuse to add attachments while enabled

I'm also still on the fence about the "compatibility mode" vs "pgp inline" deal.

Alternative icon suggestion:

Text improvement: "The e-mail will be sent..."
I'm ambivalent about the icon - both are fine.
The extra bits sound good - I guess you have to refuse attachments because they would be sent in plain-text?

I like the icon, but I'm not sure if it's obvious to the user that bandage represents compatibility

UI consistency issues:

We use "email" instead of "e-mail" everywhere else
In the overflow menu it's "Inline-PGP", in the dialog "Inline/PGP"
The compatibility icon is a different shade of grey than the action icons and the crypto indicator
The header of the dialog is sufficiently different from the other dialogs that it bothers me (a little)

Just two smaller comments: I like the medical Patch Icon, it shows that PGP/INLINE is an "ugly patch", which it is :)
I would prefer that it is always called " PGP/INLINE".

email it is
see below
crypto indicator is a "disabled"-grey, so that's sort of supposed to be different.
the headline is material dialog style, with an icon to reinforce the icon association. It's sort of a general issue I have that designing things holo now feels like a waste of time (and looks bad), but I can't make them properly material either...

@dschuermann  I dislike the typographic impression of "PGP/INLINE" in a text, particularly in the overflow menu it just looks bad. Also it's an acronym, followed by a slash, followed by a capitalized word? Is that last bit also an acronym? How do you pronounce a slash? Something like "Inline-PGP" is still recognizable to everyone who knows what "PGP/INLINE" is, but doesn't have that weird overly technical typographic vibe.
That said, I'm still not sure how to handle this everywhere. I definitely don't want PGP/INLINE in the overflow menu, in the text it's sort of fine but then also inconsistent. At the moment I use the notion of "compatibility mode" in some places, like the dialog title, which seems like a good layman's term and two-word-title for what PGP/INLINE really is.

@Valodim I still stand by my opinion that I would not use two notations for the same technical term, at least use "Inline-PGP" at both places.
I also like to see something like "compatibility mode" or "backward compatibility mode" in menu and dialog title.

"Compatibility mode" is not descriptive enough. As a user I'd have no idea what it refers to. So it'd have to be something like "PGP compatibility mode".

@cketti you are right. Unfortunately, "PGP compatibility mode" makes it sound like it needs to be enabled to make emails compatible to PGP :(
What about "PGP backward compatibility"?

Apart from wording issues and such, there is the question of when to show the explanatory dialog to the user, and with what buttons. There are three instances where the dialog may or may not appear:

when the user clicks the pgp/inline icon. this is a rather clear case: the dialog must be shown, and the standard action is "disable".
when the user enables pgp/inline from the overflow menu. this could be handled without showing the dialog, however a first-time explanation might be useful. the natural flow from there is "enable" (or possibly just one button, "got it")
when pgp/inline is enabled automatically, e.g. when replying to a pgp/inline encrypted e-mail. this definitely shouldn't happen every time, so maybe do the first-time thing there as well?

rebased, incorporated wording changes. this works acceptably now

When sending a PGP/Inline-encrypted email the decrypted message is quoted-printable encoded.
Also, the message doesn't seem to be signed.

about missing signature, I couldn't reproduce in a quick test. please test again with the compose-combined branch. it simplifies a lot of things in PgpMessageBuilder, which might very well fix this problem.

maintaining two PRs which depend on each other is quite annoying. closing this one, please see #1323 which builds on this branch but makes PgpMessageBuilder a lot simpler, adds tests, and fixes bugs from this one.


docs(advanced): add advanced section

Hi, @benlesh and @kwonoj , this PR is completely a suggestion. If you guys think there is no need fot it, please close it directly.

Description:
The doc/writing-marble-tests.md and doc/operator-creation.md are both so amazing, they are incredible useful rather than the basic topic(eg. Observable, Subject, etc) for the mid-level developer of RxJS. But in the officel document site, there's no entry for them at all, what a pity!
Now I suggest add a entry on the index.html for these advanced topic. I configure the manual.usage for now, I know it's not exactly for our need, but manual.advanced is available in the esdoc 0.5.0. If one day update the esdoc version beyond 0.5.0, you can use manual.advanced replace manual.usage.
Related issue (if exists):

Coverage remained the same at 97.735% when pulling 83b4d6dcf7f75fbc97e0a7eb1d9eaa8198863249 on SangKa:add-advanced-section-to-index into 279d7755974e7de06dbf4fb8e832747765ef52fe on ReactiveX:master.

Coverage remained the same at 97.734% when pulling 9840e04def6cc0ac2be013d369cbb2616bcebdba on SangKa:add-advanced-section-to-index into 70eaafc0c98482a37c623f7513af69e6d1b9dcdc on ReactiveX:master.


Create Terraform graphs for quoins

Using (Terraform Graph)[https://www.terraform.io/docs/commands/graph.html], create graphs for the following quoins, and upload them to the quoins GitHub repo:

[ ] etcd
[ ] vault
[ ] rethinkdb
[ ] kubernetes

Where do we want these .png images to live? The docs.md, or elsewhere?

How does our community repo with the docs? However, let's revisit this story after we finish the bootstrap scipian/community#20 epic. Some of the quoins are going to change and I rather document and walk the dependency graph once that is done.


link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-galley-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-galley-k8s-presubmit-tests-master

integ-framework-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-framework-k8s-presubmit-tests-master

integ-istioctl-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-istioctl-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-pilot-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-framework-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-framework-k8s-presubmit-tests-master

integ-istioctl-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-istioctl-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-pilot-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

integ-galley-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-istioctl-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-istioctl-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-pilot-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

integ-galley-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-galley-k8s-presubmit-tests-master

integ-framework-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn wasn't aware we upgraded KinD from 1.14 to 1.15. I updated the KinD config file to fix KinD setup failure. PTAL.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-istioctl-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-istioctl-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-pilot-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

integ-galley-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-galley-k8s-presubmit-tests-master

integ-framework-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-framework-k8s-presubmit-tests-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-istioctl-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-istioctl-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-pilot-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

integ-galley-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-galley-k8s-presubmit-tests-master

integ-framework-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-framework-k8s-presubmit-tests-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

istio-unit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests-master

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

integ-security-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-security-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
bb0dc7bb2b334a45d7f91d30556306907674c6b4
link
/test integ-new-install-k8s-presubmit-tests-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

istio-unit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-unit-tests-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

istio-unit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-unit-tests-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

istio-unit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-unit-tests-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-new-install-k8s-presubmit-tests-master

istio-pilot-multicluster-e2e-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-new-install-k8s-presubmit-tests-master

istio-pilot-multicluster-e2e-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-pilot-multicluster-e2e-master

istio-codecov-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-codecov-master

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-new-install-k8s-presubmit-tests-master

istio-pilot-multicluster-e2e-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-pilot-multicluster-e2e-master

istio-codecov-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-codecov-master

istio-racetest-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-racetest-master

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-new-install-k8s-presubmit-tests-master

istio-pilot-multicluster-e2e-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-pilot-multicluster-e2e-master

istio-racetest-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-racetest-master

istio-codecov-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_auth_sds_e2e-master
ef02e35c02f12d7d32916315a255fdfce2fdf48c
link
/test istio_auth_sds_e2e-master

e2e-simpleTestsMinProfile-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTestsMinProfile-master

e2e-simpleTests-distroless-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test e2e-simpleTests-distroless-master

integ-mixer-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test integ-new-install-k8s-presubmit-tests-master

istio-pilot-multicluster-e2e-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-pilot-multicluster-e2e-master

istio-codecov-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-codecov-master

istio-racetest-master
df34a8e9ec8c823c07223c9d3030bb77d8414f94
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-racetest-master

/test istio-codecov-master


[INTEL MKL] Replace tensorflow::bfloat16 with Eigen::bfloat16

This PR mainly changes tensorflow::bfloat16 to Eigen::bfloat16 to get benefit from its vectorization

@rmlarsen Can you please review this PR ? Thanks!

@ShengYang1 thank you for the PR! I had make a few trivial changes to internal code, but the PR looks good. I expect to submit it tomorrow.


Status meeting

What was the biggest task the group solved during the last week?

Move Travis to GitHub actions
Logging, (Still missing file system logs, and Nginx)

What is the biggest road block that the group has to sort out as soon as possible to proceed with work?

No large roadblocks currently
We can focus more on knowledge sharing, and other devops features (Monitoring, Logging, Open traceing, Documentation, Automation (CD))

We would like to share the following with the other groups: ...

Good with scrips so it is easy to port to a new place. (Travis -> Github Actions)
Documentation and task tracking with Issues (But we need to close some of the old issues, so tasks are more separate and clear)

Questions

How do they log
Provision alerts in Grafana
Features of Gin/Go?
CD? How do they do it? Monitoring? Rollback?

Group A

Missing features from UI
Implement Monitoring
Prometheus, Grafana
No major roadblocks

Group C

Solved logging (last week)
Many logs see them on kibana, (Elastic search)
Drowns in system logs
Refacturing and service layer might seem like a lot of work, but helps a lot.

Group L

API in Go, front end in React
Run locally but need atuh on elastic search
Write SLA
Readoblock: Many thing ready to deploy, needs to do taht code scanning is missing, Digital ocean ends in a few weeks needs to migrate.
Use Iris
Vagnrant as IaC

Group R

Hosted all services in Asure hosting to to asure managed kubernette service
Needs to implement logging
Try to go outside
Asure docker-compose is in beta there for the moved away.

Group N

Effective pipeline to make it work and local development
Hard to keep up

Migration of database (Might be a task for the course)

Tool to migrate (Pgloader)

CSV dump -> Import (recommended from Helge)

Manual write

Quick python script

[ ] Check Digital ocean credits

[ ] Links to  Fresh


Lightclient upgrade

This just provide method to upgrade state. More concerning issue is that we depend on epochCtx from fast transition in a rest of lodestar code and we should use regular one now.
Only solution I see is to add some logic in block processing to generate new epochCtx after state transition. It's slow, but we don't really care when prototyping lightclient with minimal spec. Is that ok?

We can always just use the "naive" lightclient/upgrade pieces of the state transition in the fast impl.
Since the naive impl just relies on the state, it should work no problem.

We can always just use the "naive" lightclient/upgrade pieces of the state transition in the fast impl.
Since the naive impl just relies on the state, it should work no problem.

Lightclient stuff adds additional state balance updates which needs to reflect in epoch ctx


Quick guide: online execution of sample apps

This PR, ready for merging, supersedes #1188.
This is my attempt to add online execution to the quick guide.
Please let me know how you like it.

Codecov Report

Merging #1196 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1196      +/-   ##
============================================
+ Coverage     94.26%   94.30%   +0.04%
  Complexity      455      455
============================================
  Files             2        2
  Lines          6674     6674
  Branches       1793     1794       +1
============================================
+ Hits           6291     6294       +3
+ Misses          105      102       -3
  Partials        278      278

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/picocli/CommandLine.java
94.14% <0.00%> (+0.04%)
314.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aeef45...fa6c8da. Read the comment docs.

Thanks for the PR.
I saw your PR but haven’t had time to look at it in detail. Probably not until this weekend...

Thank you very much!
Merged, still polishing a bit before publishing the rendered HTML.
I changed the titles a bit: instead of having to sections called "Online execution", there is now one section "ASCIIArt execution" and one section "ISOCodeResolver execution", similar for "Source code explained".
I also added a brief note above the embedded JDoodle.com section, in case something goes wrong, with a link that people can use to display the example in a separate browser tab.
TOC depth: I changed it back to only one level. I think this is less intimidating. The user manual has a very long TOC that allows more precise navigation, but also emphasizes that the document has a lot of detail. I thought it made sense to try to stay high-level in the Quick Guide.
I made Basic Example and Subcommand Example top-level sections in Quick Guide so they show up separately in the TOC.
The paramLabel in the executable examples suggest that users need to enter two codes:
// AsciiArt
paramLabel = "word1 [word2]" --> should be paramLabel = "word"

// ISOCodeResolver country
 paramLabel = "<country code 1> <country code 2>" --> should be paramLabel = "<country code>"

// ISOCodeResolver language
paramLabel = "<code> <code2>" --> should be paramLabel = "<language code>"

The reason is that picocli automatically adds an ellipsis ... behind any parameter (and its param label), when the parameter can be specified multiple times for that option. This is the convention, so it is not necessary to add additional param labels to suggest that multiple parameters can be specified.
Can you update the examples?

Merged, still polishing a bit before publishing the rendered HTML.

Great work I appreciate it!

Can you update the examples?

Yes. JDoodle examples are updated already. I will correct the samples in the .adoc and example section soon.
I willing to author another pull request adding JDoodle online execution for the checksum example in the user manual.
Would that be in your interest?

Yes, that would be great!
For the user manual I prefer to have a link to JDoodle rather than an embedded example, maybe in a TIP admonition?
FYI
I need to work on a picocli presentation for the Japan Java user group next week so I may be slow to respond.

I pushed the rendered HTML.
It looks very nice I think! Many thanks!
I thought it would be better to change the order and have the explanation first, and then allow people to play with execution.
That has a nice "flow" to it, I felt. What do you think?
One minor detail, the ISOCodeResolver  example has a typo in the paramLabel for language code>, there is a missing < opening fish bracket. Can you take a look?
paramLabel = "language code>",  --> missing `<` opening fish bracket

I pushed the rendered HTML.
It looks very nice I think! Many thanks!

You are welcome.

I thought it would be better to change the order and have the explanation first, and then allow people to play with execution.
That has a nice "flow" to it, I felt. What do you think?

I see the point. Looks good to me.

One minor detail, the ISOCodeResolver example has a typo in the paramLabel for language code>, there is a missing < opening fish bracket. Can you take a look?

This is fixed now.

Thank you for the quick fix!


Remove JFR expectation on AIX

...because JFR is not supported on AIX.
Signed-off-by: Adam Farley<EMAIL_ADDRESS>

Linked to https://github.com/AdoptOpenJDK/openjdk-build/issues/2582

Is this duplicate of https://github.com/AdoptOpenJDK/openjdk-build/pull/2598?

Yes, it is a duplicate. Just noticed. Will close.


Same tags on different languages cause builder crash

Imagine you have two posts. One has tag "bash" and another one has tag "баш", which transliterates to "bash".
In this case TaxonomyGenerator tries to generate 2 tag pages with same permalink and builder crashes with error:
  [RuntimeException]
  A previous item exists with the same id: "tags/bash/index.html". Generator: "taxonomy".

BTW case insensitivity doesn't work with cyrillic characters too. TaxonomyGenerator thinks "баш" and "баШ" are different tags and fails with same error.

A possible solution for this issue could be to add a suffix at the end of each term in case of conflict. e.g:

Term
Path

bash
/bash

баш
/bash-1

And if the term "баш" is found before "bash" term then the result will be the following:

Term
Path

баш
/bash

bash
/bash-1

Or just to merge posts to one collection. In most cases both terms have same meaning.

Bug fixed and merged on master. Thanks for the report


DSA

Describe the issue (if no issue has been made)
Engine is not using OpenGL's Direct State Access which allows us not to bind the buffer/texture/framebuffer to modify the state, like setting the data or configuring it.
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
Described above

Other PRs this solves
None

Proposed fix (Make sure you've read on how to contribute to Hazel)
The fix basically uses functions that take in renderer id, as such, I had to change VertexBuffer and IndexBuffer to allow to get renderer id. In framebuffer the static utils functions also take in fbo, but the binding inside Invalidate() function is left there, because of glDrawBuffers
Additional context
This has been tested on Windows and shouldn't affect compilability and runnability on other platforms such as Linux.

I wont merge this yet, as i think cherno might want to rework the renderer anyway...

I doubt that he will be reworking the internals of these objects, only adding additional functionality.

Obsolete (switching to Vulkan soon and removing OpenGL).


rewrite template.data keys

Describe the solution you'd like
When templating from multiple sources (data and dataFrom config), be able to render in the template all values from the dataFrom secret with the values from the data secret.
What is the added value?
This allow for a less verbose ExternalSecret object and more flexible, as adding / removing keys from the dataFrom secret source will be reflected in the secret without any object change
Give us examples of the outcome
Now we need to do the config below. Explicit list the keys from the dataFrom field, ENV1FROMDATAFROM and ENV2FROMDATAFROM, in this example.
apiVersion: external-secrets.io/v1alpha1
kind: ExternalSecret
metadata:
  name: my-server-env
spec:
  secretStoreRef:
    name: my-cluster-secret-store
    kind: ClusterSecretStore
  dataFrom:
  - key: /my-server
  data:
  - secretKey: S3_BUCKET
    remoteRef:
      key: /my-server/S3_BUCKET
  - secretKey: AWS_ACCESS_KEY_ID
    remoteRef:
      key: /my-server/AWS_ACCESS_KEY_ID
  - secretKey: AWS_SECRET_ACCESS_KEY
    remoteRef:
      key: /my-server/AWS_SECRET_ACCESS_KEY
  target:
    name: my-server-env
    creationPolicy: Owner
    template:
      data:
        ENV1FROMDATAFROM: |
          {{ .ENV1FROMDATAFROM | toString }}
        ENV2FROMDATAFROM: |
          {{ .ENV1FROMDATAFROM | toString }}
        S3_BUCKET: |
          {{ .S3_BUCKET | toString }}
        AWS_ACCESS_KEY_ID: |
          {{ .AWS_ACCESS_KEY_ID | toString }}
        AWS_SECRET_ACCESS_KEY: |
          {{ .AWS_SECRET_ACCESS_KEY | toString }}

Ideally if we could have the possibility to do templating directly in the template.data field:
    template:
      data:
        {{- range $key, $val := . }}
        {{ $key }}: {{ $val | toString }}
        {{- end}}

This is closely related to #975.


investigate task-end-to-task-end delays in Work Queue

Describe the bug
Performance is poor in the work queue executor when running sequential tasks: the time from one task ending to the next task starting is around 1 second. I'm not sure if this is inside the parsl wq executor code, or inside core wq.
To Reproduce
submit two tasks, one which depends on the other. observe a 1 second delay between task 1 completing on the worker and task 2 starting on the worker.
Expected behavior
This could be much faster.
Environment
my laptop
cc @khk-globus

looks like most of the time in the test case is being spent in this line: t = q.wait(1) waiting for a result (that will never come) for one second before submitting the next task.
Things I tried:

Make 1 smaller - that parameter is an int.
and that parameter can only go down to 1 (second) by the looks of it - setting the timeout to 0 seems to make the call wait up to 1 second. So I can't try a smaller value here.

Look at q.stats.tasks_with_results - this seems to be 0 always, so I can't poll for task readiness faster. I haven't investigated further what is going on there.

cc @dthain

link to that line:
https://github.com/Parsl/parsl/blob/99701e819f7a85a40194b201cb6a4baf06e91d84/parsl/executors/workqueue/executor.py#L965

In htex I've found this "poll one thing for 1s, poll another thing for 1s" behaviour awkward to deal with in one thread. I'm not sure with WQ the two different activities in that thread (submitting a task, and processing results) could happen in two different threads - are there issues accessing work queue from multiple threads?

@colinthomas-z80 please take a look at this.  Yes, it appears to be a classic example of the dual blocking wait problem.

I can reproduce the issue with the wq executor. I put together a similar test with plain work queue and didn't observe the issue. I will do some digging into the executor retrieval loop.

The above PR avoids the superfluous calls to wait() in between tasks. The performance is a good deal better, although I don't think we have seen the last of the timeout issue


Is there going to be support for obtaining the files from s3 to my device?

Hello. This library is very cool, but checking documentation and its source code it seems to be that it only supports to upload files to the s3 bucket, but not a way to obtain them into the device.
Is there going to be support for something like that? Because both are needed in day to day apps.

upload gives you a URL back, and you can save and use that URL to show the image.
try {
  const upload = await RNS3.put(file, options)
  return upload.body.postResponse.location // this gives you the URL
} catch (e) {
  //handle err
}


--silent option now surpresses messages

The --silent option was documented as useless before. Now Putting it
to be its intended use, which is to surpress output when
using the tool in a pipeline.

Awesome, thanks!


[Docs]: Translate to Hindi

in which language do you want to translate?
I want to translate documentation to Hindi
Code of Conduct

[X] I agree to follow this project's Code of Conduct

we already have Hindi docs https://github.com/priyankarpal/ProjectsHut/tree/main/translations/Hindi


Fleshing out Execution and Memory models

This update Intro.Defs earlier in the introduction and puts more detail into the SPMD programming model and memory model.
The PDF draft of this change is available here.

I've put in a bunch of word smithing and updates.
I think this is mostly in sane state now.
Updated PDF

@Keenuts, the last change I added here is in response to the discussion we had in email this week. Do you think that wording correctly addresses the concerns?

@Keenuts, the last change I added here is in response to the discussion we had in email this week. Do you think that wording correctly addresses the concerns?

Sure, this block as-is makes sense: no optimization should change the program behavior (except optimizations like fast-math? But maybe that's considered to be a codegen switch, not an optimization switch?)
What is IMO the important missing bit (but it's a whole subject) is to define what is expected for actual execution: the spec mentions lock-step is not mandatory, hence the spec as-is is allows the same CFG/shader to yield 2 different results. Example: running on Maxwell and Volta architecture, with the latter allowing not reconverging directly after a divergence.

Sure, this block as-is makes sense: no optimization should change the program behavior (except optimizations like fast-math? But maybe that's considered to be a codegen switch, not an optimization switch?)

Within the spec you can't change the program behavior outside what is specified. HLSL has fast-math by default, so that will be the specified behavior for floating point math operations.

What is IMO the important missing bit (but it's a whole subject) is to define what is expected for actual execution: the spec mentions lock-step is not mandatory, hence the spec as-is is allows the same CFG/shader to yield 2 different results. Example: running on Maxwell and Volta architecture, with the latter allowing not reconverging directly after a divergence.

Lockstep isn't strictly required by the spec for anything. Even wave operations can be emulated without lockstep execution if you have appropriate synchronization primitives.
For Volta, the expectation is that wave operations will effectively require warp synchronization. I think that's a driver problem for Nvidia more than anything else. Maybe that's the missing explicit wording.
I can add something like:

Wave, Quad, and Thread Group operations require execution synchronization of applicable active and helper Lanes as defined by the individual operation.

For Volta, the expectation is that wave operations will effectively require warp synchronization. I think that's a driver problem for Nvidia more than anything else. Maybe that's the missing explicit wording.
I can add something like:

Wave, Quad, and Thread Group operations require execution synchronization of applicable active and helper Lanes as defined by the individual operation.

Yes, and where those barriers are put should probably be described in the control-flow structures (here using Cuda's syntax mixed with HLSL)
switch (value) {
    case 0:
        WaveActiveSum(1);
   default:
       __syncwrap(MASK_FOR_ALL_THREADS);
       WaveActiveSum(10);
}

switch (value) {
    case 0:
        WaveActiveSum(1);
   default:
       __syncwrap(MASK_FOR_ALL_THREADS);
       WaveActiveSum(10);
}

I don't think this is correct. Every Wave* intrinsic needs to have a __syncwarp associated with it. In your example it may have only been required for the default: case, but in a more complicated example they're effectively needed for all Wave and Quad operations with a mask that represents all the participating lanes.

switch (value) {
    case 0:
        WaveActiveSum(1);
   default:
       __syncwrap(MASK_FOR_ALL_THREADS);
       WaveActiveSum(10);
}

I don't think this is correct. Every Wave* intrinsic needs to have a __syncwarp associated with it. In your example it may have only been required for the default: case, but in a more complicated example they're effectively needed for all Wave and Quad operations with a mask that represents all the participating lanes.

Yes, of course. If we add a case 1 which doesn't branch, then the mask has to be different, what I meant with this is the control-flow structure itself needs to define where synchronization is expected, not just the intrinsic:

we both agree the we must synchronize as soon as we can, when we fall-through. But this has to be made explicit IMO, and it's related to the control flow construct.
(Same for loops breaks, etc).

But It seems this goes beyond this initial PR, so probably not the best place to dive into this.

Yea, I think some of this will come down to the wording as we write the behavior of switch statements and case labels, but at the same time I don't think we need to define synchronization for control flow structures.
It isn't illegal to reshape control flow during optimization if it doesn't change program behavior, so synchronization of execution isn't really a property of the control flow structures. Even within the definitions of C, it is illegal to merge and hoist control flow if it changes the resulting execution. C doesn't have the SIMT/SPMD considerations that HLSL does, but we can lean on similar rules for HLSL and get the expected behavior.
The C spec defined case statements from ANSI C through until C17 (the wording is slightly different in the latest draft of C23) with the following statement:

Labels in themselves do not alter the flow of control, which continues unimpeded across them.

If that's the basis for how case labels are defined, and Wave* operations are defined to have wave sync behavior, I think that defines the expected behavior completely.
I don't want our spec to make statements about expectations for control flow structure that aren't required because we do want conforming compilers to be allowed to optimize in cases where they can.

I've marked the outstanding conversations as resolved. I think that I've addressed all the feedback. I'm happy to revisit anything in subsequent PRs. I'm sure this will all need some more work as we get further along.


JSON output, for automatical parsing

Or any other similar format, to be able automatically parse the output.

Hi,
we already offer json and csv format in the output folder. When you run the analysis, a folder called infer-out will be created. Inside you can find the files report.json and report.csv with the bugs.

@dulmarod sorry, didn't noticed them at first place. Closing this bug then. Thank you for a good work!


[FancyZones] Implement quick access keys, flashing

Summary of the Pull Request
What is this about:
See issue #10026
This PR currently does not add any extra telemetry or do anything if there is no layout with the desired key.
I'll add telemetry once we agree what should be included.
What is included in the PR:

Press Ctrl+Win+Alt+number to quickly switch layouts. Other shortcuts didn't work or are already in use by Windows.  This modifier combo might need to be updated.
The monitor is picked based on cursor position.
The layout will flash if the corresponding option is turned on. All layouts on the current VD will flash. If this is not desired, this can also be easily modified.

How does someone test / validate:
Try switching layouts while dragging and quickly switching layouts and activating zones to stress test the concurrency code controlling visuals.
Quality Checklist

[x] Linked issue: #10026
[x] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[x] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

I found a way to freeze FZ with a quick-switch. I have all FZ options on excluding spanning zones across monitors.

Assign window to a zone
Quick-switch to another layout
Try to assign a window to another zone.

The window doesn't change size corresponding to the zone, layouts are not shown if you drag the window with a shift pressed.
After PT restart window immediately fits the new zone size.

Another thing I noticed that when you have Flash zones on, it flashes on both monitors only the first time. After that zones are flashing on one monitor after another in turn. It looks weird when you switch to the layout on the first monitor and you see only another layout on the other monitor.
And I think it could be a frequent use case. Let's say if I don't keep in mind which key I assigned to the desired layout and I'll quickly check several until I get the right one.

@SeraphimaZ
You're right, I'll need to revisit code in ZoneWindowDrawing, because it's causing all these bugs.

Tested, works well! Very nice and solid work.
One detail to be polished is that spacing in grid layouts isn't taken into account.
I created a 4-zones grid without spacing and a priority grid with a default spacing. When I do a quick switch the spacing isn't changed with a layout. The spacing depends on the first (or not quick-switched) assigned layout on the monitor. If the first layout was canvas, it sets 0 spacing to the grid after the switch.

spacing in grid layouts isn't taken into account

I think this should be done in another PR, when we reorganize our data schema. It's happening because some of our functions such as FancyZonesData::SetActiveZoneSet aren't doing what exactly what they're supposed to, for example, it won't set spacing for the device based on the value stored in the layout.

@ivan100sic
OK let's merge this and then fix the spacing bug.


google-cloud-sdk: 452.0.1 -> 467.0.0

Updating the google-cloud-sdk nixpkg from version 452.0.1 to 467.0.0 Google released google-cloud-sdk version 467.0.0 on March-05-2024
Description of changes
Pull nixpkgs, and update google-cloud-sdk nixpkg

Action
Command

Pulled latest nixpkgs:master branch
cd src/nixpkgs; git pull

Created a new branch
git co -b google-cloud-sdk_update-nixpkg

Entered the package's directory
cd pkgs/tools/admin/google-cloud-sdk/

Set env variable required for update.sh
export UPDATE_NIX_OLD_VERSION=452.0.1

Ran the update scripts
./update.sh

Preliminary checks
After running update script, I checked components.json for new version number tail components.json and ensured that the only 2 files that should've been updated have been update, and nothing else.
>> $ tail components.json -n2
  "version": "467.0.0"
}

>> $ git status
  On branch google-cloud-sdk_update-nixpkg
  Changes not staged for commit:
      modified:   components.json
      modified:   data.nix

Push, build, and test

Committed changes to local branch, using contribution guidelines commit conventions (thanks @leona-ya!)

I locally built the updated package using the nixpkgs-review pkg:
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
(Not sure if this test was required for me to run, or it is for the approver of this PR, but for testing, I did it anyway.)

I tested that the built binaries worked and report back the expected updated version number:

# didn't actually run this cd, as nixpkg-review package script placed me in this dir after building
>> $ cd ~/.cache/nixpkgs-review/rev-04e6aee11d477e9485f37ee90a91410273f34eec/

# testing to ensure that the google-cloud-sdk works and is updated to the correct version
>> $ ./results/google-cloud-sdk/bin/gcloud --version
Google Cloud SDK 467.0.0
bq 2.0.101
bundled-python3-unix 3.11.8
core 2024.02.29
gcloud-crc32c 1.0.0
gsutil 5.27

# testing to ensure that the google-cloud-sdk-gce works and is updated to the correct version
>> $ ./results/google-cloud-sdk-gce/bin/gcloud --version
Google Cloud SDK 467.0.0
bq 2.0.101
bundled-python3-unix 3.11.8
core 2024.02.29
gcloud-crc32c 1.0.0
gsutil 5.27

Finally, I pushed the branch to my local fork and created this pull request on GitHub.

Final notes: In hopes of getting this PR merged soon, I am closing PR #291903 and am creating this pull request instead for two reasons:
a) Google has updated this package to a newer version, as reflected in this PR, and
b) To better adhere to this repo's commit conventions (as referred to by @leona-ya in #291903)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

LGTM. For the record, you don't have to create a new PR here when a newer version is released. You can just force push the new commit (make sure you only have one in the end) into your branch and change the PR title.

Yeah, I figured I would do that moving forward, but I didn't like having the (old) version number in the branch name and created a new branch with a more generic branch name (new branch: google-cloud-sdk_update-nixpkg vs old branch~: google-cloud-sdk-update-from-452.0.1-to-466.0.0)
Thank you for the +1👍🏼 and tips!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/113


save job specific token in sperate namespace

save job specific token in sperate namespace
revoke it in purge() function by check job state from DB

Coverage increased (+0.3%) to 34.203% when pulling 5d4e40e11fad3322f7a5b73b794a82207b1af186 on suiguoxin:job-token-pr into be386f0a8ccda0effbc154fa907f703f66a89775 on microsoft:master.


it doesn't work with gradle version <4.9

Is it possible to change the code to be used in gradle > = 3.0?
Thanks

This plugin is developed out of our needs. We do not need support for older gradle versions for now so we won't provide a backport.


feat: focus search input when opening settings

[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

What's the reasoning for this change?

It's mainly UX:

when a user open the settings using Ctrl + ,, he can type to search the setting without using the mouse to select the field
when a user come on the settings page using the mouse, he can directly type


Replace manual prefix formatting of elements with maybeAutoFormat

In order to get out of the business of manually setting whitespace (e.g. when building elements using something like Space.format(" ")), and to exercise our autoFormat'ing logic, evaluate visitors which do prefix setting and replace it with autoFormat.
Example:
https://github.com/openrewrite/rewrite/blob/a8f820b363ff6ebda19e81f387d044c0324284b2/rewrite-java/src/main/java/org/openrewrite/java/ImplementInterface.java#L46-L52
Feel free to close this. Just wanting to externalize it as a potential issue.

I'd say we've done this now

https://github.com/openrewrite/rewrite/blob/55dcef080a72ca881061f8f42b3d5b7f6b7f3124/rewrite-java/src/main/java/org/openrewrite/java/ImplementInterface.java#L57
Looks like we're still doing manual prefix formatting? Maybe not a big deal, though.


Example of using headers for vegeta library

Question
is there an example of using vegeta as a library that requires certain headers to send POST requests?
When sending POST we use the following code:
targeter := vegeta.NewStaticTargeter(vegeta.Target{
  Method: "POST",
  URL:    "http://localhost:9100/endpoint",
})

How to add the header?

Solved.
I'm using this code:
payload := map[string]string{
  "body": "body",
}
body, _ := json.Marshal(payload)
header := http.Header{}
header.Set("content-type", "application/json")

targeter := vegeta.NewStaticTargeter(vegeta.Target{
  Method: "POST",
  URL:    "http://localhost:9100/endpoint",
  Header: header,
  Body: []byte(body)
})


Use src-layout instead of flat-layout

Any reason why this project doesn't adhere to src-layout? One should still be able to invoke pip-tools through runpy afterwards.

Probably historic state of things. It doesn't matter, really. And I don't see any reason to change it.

Hmm, it would help to prevent any accidental importing of the code when it should be installed (also when developing, for that we have tox devenv). Besides, I found this line, it seems to have been intended: https://github.com/jazzband/pip-tools/blob/347fec59b418b6239e47dee8429e8401ac4330e6/pyproject.toml#L118

I wonder if that comment is wrong.. Explicitly setting includes is needed due to the distribution package name not matching the import package name isn't it?

I wonder if that comment is wrong..

I don't think custom discovery is needed, anyway, as setuptools will also try its best at detecting packages with flat-layout, and we don't have any that we would want to exclude.


rusoto_sts::ChainProvider

Looking at 0.43.0-beta.1; thanks for that by the way!
I could not find a ChainProvider that uses WebIdentityProvider; despite the following from AWS_CREDENTIALS.md
rusoto_sts implements a replacement ChainProvider which adds a credential source for web identities for use with Kubernetes.

Thanks

I ran into a similar issue. It was very hard for me to find the WebIdentityProvider in the first place.
I think it would be great to add the WebIdentityProvider to the ChainProvider and DefaultCredentialsProvider respectively. Would be similar how to works with other SDKs.

Also lost time to this issue. I ended up with the following block to support both environments, but as above this isn't hugely ergonomic, and less obvious:
if let Ok(role) = std::env::var("AWS_ROLE_ARN") {
    info!("creating S3 client (credentials: web identity for {})", role);
    let base_credentials_provider = rusoto_sts::WebIdentityProvider::from_k8s_env();
    let credentials_provider = rusoto_core::credential::AutoRefreshingProvider::new(base_credentials_provider).expect("create refreshing credentials provider");
    return SharedConnection {
        client: rusoto_s3::S3Client::new_with(http_client, credentials_provider, region),
    };
}

info!("creating S3 client (credentials: default provider)");
let credentials_provider = rusoto_core::credential::DefaultCredentialsProvider::new().expect("create default provider");
let client = rusoto_s3::S3Client::new_with(http_client, credentials_provider, region);

I don't even know at this point whether wrapping the k8s provider with the auto refreshing one is necessary.
If WebIdentityProvider needs to live outside rusoto_core, then can we, as mentioned above, add a default provider that chains back to other default mechanisms (only ones considered safe if desired) and document this in rusoto_core::credential ?


GitHub

This blog contains short introduction to GitHub for Student Developers. This blog should describe the main features of GitHub in short...
https://studentambassadors.microsoft.com/en-US/studentambassadors/profile/93003e0f-30aa-4da9-af4e-f5df1043c91d

review-requested:[@alischumacher]

review-requested:[alischumacher]


Hibernate when called as "ZZZ"

We used to check if argv[0] ended in "/ZZZ".  When called as "ZZZ"
(without further path components), we want to hibernate, too.

I’ve fixed the bug in 5cd17e0ea2652d4678ff62b6b14ed6b7d916e883. Thanks for reporting it and suggesting the fix!


Add golem-worker tests for JS fetch

This will be waiting for a proper fix on fetch - currently the behavior is flaky.


Filter Option

User stories
As a user I want to be able to filter all items in order to find the ones matching my categories.
Dependencies
Depends on:

#15
#16
#17
#73

UI Mockup
see #2
Acceptance Criteria

[ ] Filtering popup/page should open on click on filter button
[ ] Clicking on 'Ergebnisse ansehen' should close this page
[ ] When closing filter page, results should be adjusted in #16, all results must have attributes as described in filter
[ ] Filtering options should be in this order: Availability, Categories, (Groups)
[ ] Availability should show options, that indicate whether we want to search for all, only available or not available items
[ ] Categories should show all categories and the user can select 'all' or a specific category
[ ] Grouping option should be implemented with issue #168
[ ] In dropdown menu, user should be able to select one of the options or none (meaning no filter in this category)
[ ] Options for categories and groups should be loaded from database when loading filter page
[ ] Should represent Design Guide #2

Options for categories and groups should be loaded from database when loading filter page

(1.) Can we just load the filter options when the search page loads or  (2.) should we load them when the popup opens.
Both of the options have positive and negative sides. @LucasDerReisende
(1.)

Easy to implement
new options (added while you are on the search page ideling) are only available after page refresh

(2.)

complicated to implement (client is responsible for always updating the filters)
new options there when opening the popup
If we don't want to implement something like team red with their notification inbox, we would need a separate filter page.

We would recommend option (1.)

Categories should show all categories and the user can select 'all' or a specific category

Do we need a separate option all? We think a blank option communicates the same intent (I don't care)?

Options for categories and groups should be loaded from database when loading filter page

(1.) Can we just load the filter options when the search page loads or (2.) should we load them when the popup opens. Both of the options have positive and negative sides. @LucasDerReisende
(1.)
* Easy to implement

* new options (added while you are on the search page ideling) are only available after page refresh

(2.)
* complicated to implement (client is responsible for always updating the filters)

* new options there when opening the popup

* If we don't want to implement something like team red with their notification inbox, we would need a separate filter page.

We would recommend option (1.)

I think option one should work just fine.

Categories should show all categories and the user can select 'all' or a specific category

Do we need a separate option all? We think a blank option communicates the same intent (I don't care)?

I doesn't matter how it is labled, the user just has to understand, that leaving it blank or having a default option, will include all results

We will use the new filters when searching for an empty string.

What should happen when the user has selected filters but has an empty searchbar? @LucasDerReisende

What should happen when the user has selected filters but has an empty searchbar? @LucasDerReisende

Since we are displaying all items, when the search bar is empty, the user might wants filter all the items they see, so I think those filters should also update the results then.


Make a "read" command for easier querying.

See comment about querying events:
http://obfuscurity.com/2014/01/Graphite-Tip-A-Better-Way-to-Store-Events

alias gevents="curl -u $GRAPHITE_USER:$GRAPHITE_PASSWORD '$GRAPHITE_URL/get_data?from=-15minutes&until=now'"


Added all logo with url

I found all possible logo from official and some from wikipedia and other icon history website .
if any issue i will solve it

Heya - a good start.
Please can you:

Remove the .idea/ folder
Check the Samsung S and Swoop logos. I'm not sure if they're correct.
Teamspeak - should just be the icon
Ubisoft should also just be the icon

Thanks!


GeoIP mmdb too large to keep in repository

Currently we are embedding a GeoIP2 Lite mmdb to be able to run a single small GeoIP test. This is an overkill so we either need to think about git-lfs, or stripping down the sample binary to an acceptable size.

Will be replaced with submodule on 0.2.2-beta release.