Extend BC example for feat($compile) in > Angular 1.6.0 docs

Do you want to request a feature or report a bug?
issue in doc - wanted to create PR but couldn't.
What is the current behavior?
in CHANGELOG.md there is this BC description for feat($compile): https://github.com/angular/angular.js/blob/master/CHANGELOG.md#breaking-changes-1 regarding the 'binding' in 'components'
What is the expected behavior?
The same behaviour exists when you use the controllerAs pattern like e.g.
  angular
    .module('myApp')
    .directive('myDirective', myDirective);

  function myDirective() {
    return {
      restrict: 'E',
      scope: {
        value: '='
      },
      controller: 'myController',
      controllerAs: 'vm',
      bindToController: true,
      templateUrl: 'myTemplate.html'
    };
  }

You want have access to vm.value in your Controller.
What is the motivation / use case for changing the behavior?
Extend the example for the BC.
**Which versions of AngularJSare affected by this issue?
All version > 1.6.0

I don't think we need to extend the example (as it would get really verbose), but the current description can indeed be confusing, because it only mentions "component constructors".
👍 for changing the description to something like: component constructors --> component/directive controller constructors

Find with that as well - it took as a while to find out what's going on here - therefore I thought providing an additional example could help. But again as said, your approach seems good enough to me.


FIQuery<T, Line2, Line2> result wrong.

the result point should be [2.0,2.0] but got [-2.0,-2.0]
  Line2<float_t> line2_3({0.0, 0.0}, {0.5, 0.5});

    Line2<float_t> line2_4({2.0, 0.0}, {2.0, 1.0});

   IntrPointLine2AndLine2<float_t> intrLine2AndLine2;

    auto result6 = intrLine2AndLine2(line2_3, line2_4);

   Vector2<float_t> respect = {2.0f, 2.0f};
    assert(result6.point == respect);

Tests whether parallel lines intersect  fail.
 Line2<float_t> line2_5({0.0, 0.0}, {1.0, 0.0});

    Line2<float_t> line2_6({0.0, 1.0}, {1.0, 1.0});

    IntrPointLine2AndLine2<float_t> intrLine2AndLine2_2;

    auto result7 = intrLine2AndLine2_2(line2_5, line2_6);

    assert(result7.intersect == false);

Hello, I'm not sure, but I think the line2 objects are not defined by 2
points, but 1 point + direction unit vector. (distance between the two
points must be "1")
So... If your lines are not well defined, ofc the result is bad...
(this is just my opinion)
Le sam. 3 déc. 2022 à 09:16, Mr zhan @.***> a écrit :

Tests whether parallel lines intersect fail.
Line2<float_t> line2_5({0.0, 0.0}, {1.0, 0.0});
Line2<float_t> line2_6({0.0, 1.0}, {1.0, 1.0});

IntrPointLine2AndLine2<float_t> intrLine2AndLine2_2;

auto result7 = intrLine2AndLine2_2(line2_5, line2_6);

assert(result7.intersect == false);

—
Reply to this email directly, view it on GitHub
https://github.com/davideberly/GeometricTools/issues/49#issuecomment-1336111607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3BAQMFLKEP2CKTMTYXOJDWLL6W3ANCNFSM6AAAAAASSTTRD4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

thanks, yes, line 2 is defined by 1 point and direction instead of two points.


Custom Calendar Filter Component Size - Not Fitting Correctly

Hello,
I am currently trying to create a custom filter by using the filterOptions object.
I am able to get the filter to show up, however the calendar does not pop up like it normally would.
Note: referring to the "Date range" filter.

{     name: "date",     label: "Date",     options: {       filter: true,       filterType: "custom",       filterOptions: {         names: [],         display: (filterList, onChange, index, column) => {           return (             <FormControl fullWidth>               <Calendar                 // style={{ width: "100%" }}                 placeholder="Filter: Date Range"                 // selectionMode="multiple"                 // value={filters.dateRange}                 name="dateRange"                 showButtonBar={true}                 // onChange={handleDateFilter}               />             </FormControl>           );         }
Note: I've tried many various ways however I am unable to get the calendar to popup like it should (3rd picture expected behavior).

Tech
"@material-ui/core": "^4.7.2",
"@material-ui/icons": "^4.5.1",
"mui-datatables": "^2.13.3",
"react": "^16.10.2"
The calendar is a PRIMEREACT component.

Personally, I'm not too familiar with PRIMEREACT, and I can't guarantee that every part of this library works with every other library. What you might need to do is find a datepicker library that is built off of material ui, as is this library. Material-ui also has a datepicker component https://material-ui.com/components/pickers/.

Noted.
I was trying to get the prime react one to work since material ui does not allow for multiple dates to be selected.
Is it possible to override the mui-data table components? I couldn't figure out which classes, so I could at the very least do an online calendar.

Possible to override the styles? Sure! It works the same as it does in material-ui. You can take a look at the custom-styling example for some examples.


Not functional on touch screen devices

Any chance this can be converted to work on touch screens? On iphone, you can't move the crop area at all.
Also, is there a way to make the initial crop area larger? That could at least be a temp fix for me.

@petedrennan  This Demo used   jquery-imgareaselect .You can read its  document and custom it for you.


Add missing jest-validate to dependencies

Just published 0.13.1 with this fix.

We should probably add an end-to-end test that tries the published version via npm pack


fix(composer-app): proper env config

copilot:all

Current dependencies on/for this PR:

main

PR #3505   👈

This comment was auto-generated by Graphite.

@wittjosiah merged this pull request with Graphite.


Compliance phase: Make CLI reporter always run

Just like Infra always outputs to the CLI, we should always output compliance to the CLI. Always run the CLI reporter.

you mean like this?  27c70a4ac01

If you set you're own attribute it goes away though

ohhhhh gotcha
well we should do #11924 anyway, but that doesn't solve that problem.


Stub Chessboards don't have pieces showing

Not sure which versions don't have this or why, I thought maybe it never happened, but the ChessMod curseforge page has images of it and I think it works in 1.16.5. So, we probably want to figure out where it's broken, then fix it:

[ ] Check 1.20.1
[ ] Check 1.19.4
[ ] Check 1.18.2
[x] Check 1.17.1 - Broken, @Captaintom14 noted this while wrapping the version
[ ] Check 1.16.5
[ ] Check 1.15.2
[ ] Check 1.14.4

Once we make the determination of which versions have this broken, we should probably ticket that and then fix it.

The pieces do not show in 1.19.4.

The pieces do not show in 1.18.2


Cloud container builds

Adds Cloud Container Builder support. A cloud build can be started by running scripts/cloudbuild.sh.
Note that all local docker-dependent operations have been moved into an active-by-default maven profile named local-docker-build, which cloud builds will disable in order to perform an explicit "docker build" as a separate build step.
Regular maven builds for local development are not impacted by this change.
see also https://github.com/GoogleCloudPlatform/openjdk-runtime/pull/54

@meltsufin I think all the changes are in. Mind taking another pass at this?


errors compiling Ceylon SDK

When I opened the SDK project in IntelliJ, I got the following compilation errors:

Window.ceylon(60,4): dynamic is not supported on the JVM
CeylonWebSocketAbstractFrameHandler.ceylon(58,8): ambiguous invocation of overloaded method or class: there must be exactly one overloaded declaration of 'safeClose' that accepts the given argument types 'UtWebSocketChannel'
DefaultWebSocketChannel.ceylon(44,22): method or attribute does not exist: 'open' in type 'UtWebSocketChannel'
module.ceylon(5,7): module not meant for this backend: ceylon.interop.browser
CeylonWebSocketHandler.ceylon(56,24): method or attribute does not exist: 'resumeReceives' in type 'UtWebSocketChannel' (did you mean 'lastFrameReceived'?)
html.ceylon(8,18): dynamic is not supported on the JVM
arrays.ceylon(98,11): the 'ExpressionVisitor' caused an exception visiting a 'InvocationExpression' node: '"java.lang.ClassCastException: org.intellij.plugins.ceylon.ide.ceylonCode.model.PSIAnnotation cannot be cast to java.util.List"' at 'com.redhat.ceylon.model.loader.AbstractModelLoader.getTypeParametersFromAnnotations(AbstractModelLoader.java:4671)'
JavaList.ceylon(79,33): small annotation on parameter 'e' of 'remove' will be ignored: corresponding parameter 'o' of 'remove' is not small
DefaultTextSender.ceylon(29,56): the 'ExpressionVisitor' caused an exception visiting a 'QualifiedMemberExpression' node: '"java.lang.NullPointerException"' at 'com.redhat.ceylon.model.loader.AbstractModelLoader.obtainTypeParameterBound(AbstractModelLoader.java:5186)'
nativeObjects.ceylon(13,4): dynamic is not supported on the JVM
JavaList.ceylon(79,18): type of member must be assignable to type of refined member 'remove' in 'AbstractList': 'Boolean' is not assignable to 'E'
DefaultWebSocketChannel.ceylon(42,27): method or attribute does not exist: 'idleTimeout' in type 'UtWebSocketChannel'
CeylonWebSocketHandler.ceylon(55,24): method or attribute does not exist: 'receiveSetter' in type 'UtWebSocketChannel' (did you mean 'receiveFrame'?)
CeylonWebSocketHandler.ceylon(58,16): ambiguous invocation of overloaded method or class: there must be exactly one overloaded declaration of 'safeClose' that accepts the given argument types 'UtWebSocketChannel'
XMLHttpRequest.ceylon(106,18): dynamic is not supported on the JVM
JavaList.ceylon(79,33): type of parameter 'e' of 'remove' declared by 'JavaList' is different to type of corresponding parameter 'index' of refined member 'remove' of 'AbstractList': 'Object?' is not exactly 'Integer'

dynamic is not supported on the JVM

Easy fix, I checked Compile project to Javascript in the project settings and it fixed the problem. I suppose we could push .ceylon/ide-config to avoid this problem in the future.
I'll take a look at the other errors.

Ah, OK, that's a little strange because I don't need to enable that in Eclipse. Eclipse let's me compile the SDK just to Java.

Yes, it's because I did some specific stuff to avoid these messages afair. So you can assign the issue to me if you want.

I fixed the PSI mirrors and we can now open ceylon-sdk without errors. As for dynamic is not supported on the JVM, this was enough but @davidfestal if you want to add the same "specific stuff to avoid these messages" in IntelliJ, I'll reassign you the issue.

Excellent!

@davidfestal can we close this?

After looking a bit more into it, we can close this. dynamic is not supported on the JVM error messages are also there under Eclipse if uncheck the JS backend from the project properties.
The real thing here is that the enabled JS /JVM backends are not synchronized between Eclipse and Intellij configurations.
We can close this.


Observable pipe spread

Adds the ability to pass an array of operators to Observable.prototype.pipe without needing to spread them as arguments. TypeScript users will then need to supply the appropriate type like so:
const operators = getAMillionOperators();

source$.pipe<ResultType>(operators); // Observable<ResultType>

Coverage decreased (-0.2%) to 96.793% when pulling aa178af076085228c0a9eb811b39f4ca6f98fa29 on benlesh:Observable-pipe-spread into 02780dd41998b39c4e83ec8e8aa0724db2460f5f on ReactiveX:master.

The more I think about this one, the more I think it's an unnecessary concession for TypeScript.
Alterternatively, we could just expose pipeArray (which already exists), and then TypeScript users could "spread an array" into Observable.prototype.pipe like so:
import { of, pipeArray } from 'rxjs';
import { map } from 'rxjs/operators';

const ops = [
  map((x: number) => x + x),
  map((x: number) => x - 2),
];

of(1, 2, 3).pipe(
  filter(x => x % 2 === 0),
  pipeArray(ops),
)

Which in plain JavaScript could just be:
import { of } from 'rxjs';
import { map } from 'rxjs/operators';

const ops = [
  map((x: number) => x + x),
  map((x: number) => x - 2),
];

of(1, 2, 3).pipe(
  filter(x => x % 2 === 0),
  ...ops,
)


Add create image by url

Is there an issue linked to this?  Please squash commits and add helpful message.

Also, can we add an e2e for this?

Another improvement could be the resolution of Function sourcePath  which currently looks at the local filesystem. It will be nice if the CLI could try the local path else do a relative URL path while operating in this mode. I just realized the seed.yaml still won't work after this addition.

@pzmrzy Please add an E2E test for this. The test should use the seed.yaml that's part of the PR being tested by the CI job, otherwise, the yaml being tested may not be in sync with the API changes in that PR. This could lead to unnecessary CI failures.


feature: update lock policy for container management

Signed-off-by: Allen Sun<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
In the container manager, code usually use
c.Lock()
defer c.Unlock()

to avoid race condition. While I think it is not so preferred since it does have serious affect on performance.
This PR dis three types of things:

encapsulate all state management into a single file container_state.go;
make container.Lock much more grained granularity.
change log format to make it more explicit.

Ⅱ. Does this pull request fix one issue?

fixes #1244
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

"Networks": {
"bridge": {
"Aliases": null,
"EndpointID": "7ac33c5cb8b1451a463bff4878c1b02f0c220273ba2813af470b54c3a99d6fa2",
"Gateway": "<IP_ADDRESS>",
"IPAddress": "<IP_ADDRESS>",
"IPPrefixLen": 24,
"Links": null,
"MacAddress": "02:42:ac:11:00:02",
"NetworkID": "f243987a7525ddbce2e10a39cdea07faabd8dc73dc1ef1f8e63bb7298a7f15dd"
},
"net1": {
"Aliases": [
"1c37c7c5b0e2"
],
"EndpointID": "1882c867d0a862c2f38a345a63511ad8368d29cc9ad0fbb859d2734382ec480d",
"Gateway": "<IP_ADDRESS>",
"IPAMConfig": {
"LinkLocalIPs": []
},
"IPAddress": "<IP_ADDRESS>",
"IPPrefixLen": 24,
"Links": [],
"MacAddress": "02:42:ac:12:00:02",
"NetworkID": "49dd63b6edb1d621e9b4fe8ac36e245a2d93e925ec25930a501e3197ec9318bc"
}

Codecov Report

Merging #1307 into master will decrease coverage by 0.09%.
The diff coverage is 0.82%.

@@            Coverage Diff            @@
##           master    #1307     +/-   ##
=========================================
- Coverage   17.32%   17.23%   -0.1%
=========================================
  Files         189      190      +1
  Lines       11818    11892     +74
=========================================
+ Hits         2048     2050      +2
- Misses       9623     9695     +72
  Partials      147      147

Impacted Files
Coverage Δ

daemon/containerio/jsonfile.go
1.42% <ø> (ø)
:arrow_up:

daemon/mgr/container.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container_exec.go
0% <0%> (ø)
:arrow_up:

apis/server/image_bridge.go
15% <0%> (ø)
:arrow_up:

daemon/mgr/container_state.go
0% <0%> (ø)

daemon/mgr/spec.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container_types.go
34.92% <25%> (+5.06%)
:arrow_up:

What you said is totally right. @fuweid
This is just the first round. We need to make the locking much more fine-grained. In addition, the state management also needs improvement by adding more inter-states.
I would like t invite @HusterWan for review as well. Thanks.

Lock too big is  a problem, i do not know whether making lock management too complicated if we use lock like this PR ?

whether making lock management too complicated if we use lock like this PR

I think we have to, since for end-user, performance is the thing which matters rather than code complexity.
For us developers, goroutine collaboration is a thing we must do, it is a big difference from other program language. Since when using other program language, without routine, we seldom use shared memory to communicate among process/thread, but when we use, we still have to pay attention.
I do realized that this is not so good to read and a little bit complicated. Before figuring out other ways, I still insist the purpose and implementation of this pull request. @HusterWan

@allencloud Agree, we must move on, when merged this PR we may need add middle status handling  as soon as possible in case things go wrong in concurrent situation.

FAIL: /go/src/github.com/alibaba/pouch/test/cli_restart_test.go:34: PouchRestartSuite.TestPouchRestart
/go/src/github.com/alibaba/pouch/test/cli_restart_test.go:42:
res.Assert(c, icmd.Success)
/go/src/github.com/alibaba/pouch/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
... Error: at cli_restart_test.go:42 -
Command:  /usr/local/bin/pouch restart -t 1 TestPouchRestart
ExitCode: 1
Error:    exit status 1
Stdout:
Stderr:   Error: failed to restart container: {"message":"failed to create task for container(a68a1c9231df31926dbd6f89d47e3f97bd11061622762f0cac6258d0931cf647): OCI runtime create failed: container_linux.go:265: starting container process caused "process_linux.go:348: container init caused \"process_linux.go:331: running prestart hook 0 caused \\\"error running hook: exit status 1, stdout: , stderr: time=\\\\\\\"2018-05-18T09:11:59Z\\\\\\\" level=fatal msg=\\\\\\\"no sandbox present for a68a1c9231df31926dbd6f89d47e3f97bd11061622762f0cac6258d0931cf647\\\\\\\" \\\\n\\\"\"": unknown"}
Failures:
ExitCode was 1 expected 0
Expected no error

FAIL: /go/src/github.com/alibaba/pouch/test/cli_upgrade_test.go:41: PouchUpgradeSuite.TestPouchUpgrade
/go/src/github.com/alibaba/pouch/test/cli_upgrade_test.go:49:
res.Assert(c, icmd.Success)
/go/src/github.com/alibaba/pouch/vendor/github.com/gotestyourself/gotestyourself/icmd/command.go:61:
t.Fatalf("at %s:%d - %s\n", filepath.Base(file), line, err.Error())
... Error: at cli_upgrade_test.go:49 -
Command:  /usr/local/bin/pouch upgrade --name TestPouchUpgrade registry.hub.docker.com/library/busybox:1.25
ExitCode: 1
Error:    exit status 1
Stdout:
Stderr:   Error: {"message":"failed to create new container: failed to create task for container(9855f1fc58b1e9fd6cce1dc3c578b1b5f8cd05749873a9f3ee1f81e41af95ae9): OCI runtime create failed: container_linux.go:265: starting container process caused "process_linux.go:348: container init caused \"process_linux.go:331: running prestart hook 0 caused \\\"error running hook: exit status 1, stdout: , stderr: time=\\\\\\\"2018-05-18T09:15:38Z\\\\\\\" level=fatal msg=\\\\\\\"no sandbox present for 9855f1fc58b1e9fd6cce1dc3c578b1b5f8cd05749873a9f3ee1f81e41af95ae9\\\\\\\" \\\\n\\\"\"": unknown"}
Failures:
ExitCode was 1 expected 0
Expected no error

Thanks godness, this pr has passed all the ci tests. While to avoid if this is coincidence, I re-trigger the test to do a double check.

LGTM


Support for running new pest describe blocks inline?

Hey ya'll!
With new describe blocks for pest 2.9, I'm wondering if there's any intention of supporting running them inline with the play button and fixing issues with test inside these blocks not correctly running.
Currently, trying to single out tests inside describe blocks is broken, and there is no option to run the whole block.
That said, the blocks themselves are obviously being correctly executed at some point, as they run just fine when you test the whole file.
Just wondering what this would take and what the possible pitfalls are here!

Hey 👋
We have already outlined all the work needed. However nobody has started on it, but I am welcome to maintaining it in the plugin if you wanna contribute with support for it. (don't use describe block myself)
duplicate of #462


Group sessions from apps together into one volume control

I'm working on this improvement in my fork just as a heads up. Got all the code done and should have it integrated by this weekend.

Awesome, looking forward to it!
The next release is going to be packed!
Thanks.

Oh and @t3knomanzer good job on the updated encoder handling, I was going to tackle that next =D


[rewrite] migration path

Hi,
I just saw that there is a rewrite in progress here.
Given that it's not backward compatible with the 0.2.x API, are there any plans to support a migration path ? This could be a page on the wiki that explains how to upgrade to the new API, or even better a codemod, that is able to migrate the code base automatically, like for example react-codemod.
Another question: will it be possible to have a 0.2.x component interact with a 1.0.x component ?
If not, how will it be possible to migrate a large code base from 0.2.x to 1.0.x ?
Note that I don't expect to have all answers right now as the rewrite is still in progress. I just want to have your opinions on these to see how we could one day migrate to the new API.

We plan on eventually creating a migration path, but at the moment, the rewrite is still missing features, most notably component support. Given that, it doesn't quite make sense yet.
Closing for now, and when we get to that point, feel free to open a new issue.

Ok, thanks.


Discussion about Grapheme API

The Grapheme API for strings was introduced in #11472.
However, there is still a debate about the actual data format for graphemes. They are a sequence of codepoints, which is typically represented as String. But we chose to have a dedicated type, String::Grapheme for this. It's a wrapper around String and provides an optimization for grapheme clusters that consist of only a single code point. They are stored as Char to avoid lots of tiny string allocations for the very common single-codepoints graphemes.
This was already discussed in the introducing PR (#11472) and its precursor (#10720).
To summarize, I'm copying my original comment about representation options from https://github.com/crystal-lang/crystal/pull/11472#issuecomment-977178131 with some additions:

The Char | String union type is a huge improvement for grapheme clusters consisting of a single character. That should be most common in typical use cases, so it saves a big deal of allocations compared to String (or a collection of Char as in the initial propsal).
However, in some contexts, multi-character grapheme clusters are quite ubiquitous. Whether you're dealing with lots of composed emojis or scripts such as Thai, Hebrew or Arabic, or even just many decomposed diacritics, there might be a lot of string allocations for all these graphemes.
We can expose the method String#each_grapheme_boundary as part of the public API. That's trivial and basically cost-free. However, I'd consider it more a low-level API. It can be useful for custom grapheme-based implementations.
Employing a StringPool to avoid repeated allocations of identical grapheme clusters. There is no way to release values from a pool, so it would be a bad idea to use a global pool. But individual pools could be useful for single iterations. This could optionally be configurable and the API could allow specifying a custom pool to be used. This would be pretty easy to implement later. We just need to add StringPool parameters to Grapheme.new and the iteration methods.
A pool means we still need to allocate strings for every grapheme, but we can safe on duplicate allocations of the same graphemes. It is likely that the same graphemes show up repeatedly in longer texts of the same context, so that should be expected to be benefitial.
We could avoid allocating a string entirely by keeping a reference of the original string and making Grapheme essentially a pointer to a substring. String allocation would only happen in Grapheme#to_s. The big downside of this approach is that it keeps the original string in memory. That's a serious implication when working with large amounts of texts. If the Grapheme instaces are only used for iteration, this is not a problem. But if you start storing Graphemes somewhere, they keep pointers to the original strings alive. An example would be collecting frequencies of graphemes over a collection of texts. Assuming every evaluated texts contains a multi-character grapheme that was not encountered previously, all these strings will be kept in memory. The user would need to be aware of this behaviour and take action such as converting grapheme instances to self-owned cluster strings.
(https://github.com/crystal-lang/crystal/pull/11472#issuecomment-977799788) Clusters consisting of multiple codepoints, but still in a small number could also be stored on the stack, with something like Char | {Char, Char} | String or {size: Int32, data: Char[4]} | String. This would cover more cases, but there is technically no limit to the length of a single cluster, so String is always needed for those that exceed the length.
(https://github.com/crystal-lang/crystal/pull/11605#issuecomment-996649623) The simplest API would just use String instead of a dedicated Grapheme type. Elixir's string implementation takes this approach. The downside is that every grapheme cluster is heap allocated. This could be combined with 1. and/or 2. for some optimization. Another improvement would be a global pool for common grapheme clusters.

I think what's needed here is why one uses graphemes. What's the use case? Maybe it's for showing them in a text editor. I guess it must be something related to visual stuff. Maybe counting how many graphemes there are?
If those are the use cases, then adding more methods to Grapheme, like each_char and each_byte might not be needed. If one wants that, they can turn a Grapheme into a String. That allocates memory if the Grapheme stores a Char, but if these uses cases are rare then it should be fine.
So maybe keeping Grapheme like it's right now is fine.

Yes, graphemes are about presentation. But that's really in a very similar manner as characters. You only need them for visual stuff. Everything else really works well with the raw bytes (in UTF-8 encoding). The thing is just that many (most?) things we do with strings are related to visuals. Even if they don't directly deal with rendering stuff.
In fact, I'm pretty sure that when you do string operations based on characters, it very often should really be about graphemes. Using characters is a simplification when grapheme clusters are excluded in the domain or they just don't matter to the implementation.
I actually have a use case for each_char/each_byte: Fixing up https://github.com/crystal-lang/crystal/pull/11520 (see https://github.com/crystal-lang/crystal/issues/11478#issuecomment-996562879).
They are very useful and if we don't add these methods, we might just use String instead of a dedicated Grapheme type because it defeats the purpose if I have to allocate a string again for every single-codepoint grapheme.

In fact, I'm pretty sure that when you do string operations based on characters, it very often should really be about graphemes

Yes! I think this would be ideal.
Ideally:

Char should be renamed to Codepoint, or similar
Whatever is returning Char now, should return Grapheme, or even String if we consider these to be "the same thing"
Indexing a String would give you another string/grapheme
Same with taking a subrange: it would always break in grapheme boundaries, unless you don't want that
The size of a string should be the graphemes count
and so on...

But I think we are in a point where we can't make these changes without breaking backwards compatibility. Or maybe there's a way to do it?

(by the way, this is how Elixir and Swift work, I think, except that Swift has a Character type that's essentially a grapheme)

I think it's doable—and desirable—for 2.0, but not for 1.X.

I think we might be stepping away from the main topic into a different discussion. Of course, it's related and the future of grapheme vs. code point in the String API should influence the architecture of Grapheme API.
And honestly I'm not entirely sure if it's really doable - or even desirable - to essentially replace Char by Grapheme as the main constituent of strings.
Graphemes are technically more correct and probably never wrong. But there's a lot of additional complexity involved. One is memory representation, as described in this issue. The other is that the rules for grapheme clusters are not even static. They depend on the Unicode version. Programs using different Unicode versions may have different opinions whether a sequence of code points describes a single grapheme cluster or multiple graphemes. That's different from encoding codepoints in UTF-8, for example. The format is independent of Unicode versions and even implementations based on older versions can work with that. They may not understand the meaning of the code points, but there's no ambiguity about the byte representation of code points.

Some Unicode characters displayed in a terminal take up more than one column, and therefore can break the alignment of tables. So, it would be useful to have a method giving the "visual" length of a Unicode string.
For example, ruby has the following gem : ruby-unicode-display-width
Would it be appropriate to include this use case in this discussion ?

@hutou https://github.com/crystal-lang/crystal/issues/11038

@Blacksmoke16, Thanks


Import-DbaCsvToSql: the '++' operator works only on numbers. The operand is a 'System.String'

Before submitting a bug report:

[X] Ensure you are able to reproduce it on the latest released version (we release often)
[X] Verified this bug is not already reported in an issue
[X] Verified errors are not related to permissions
[X] Can reproduce in a clean PowerShell session (clean = powershell -NoProfile)

Steps to Reproduce
/*
    Any T-SQL commands involved or used to produce test objects/data.
*/

<#
    Import-DbaCsvToSql -table tablename -sqlinstance connectionstring -database DBName -Schema dbo -FirstRowColumns -csv Path\To\Csv
#>

Expected Behavior
Import data into table
Actual Behavior
I have been using this function for weeks, 10s of times a day no problem. Then today I started receiving the error "Import-DbaCsvToSql: the '++' operator works only on numbers. The operand is a 'System.String'" and now the function no longer works.
Environmental data

PowerShell: 5.1.14409.1012

SQL Server: 2016 SP2

@jrob24 - are you still having this issue? and can you repro at the command line?


Restructure code of dataset upload panel

This PR improves the code structure of prereview components. No visible change in the front-end.

Nice, will test this PR asap :)

Great!! Works like a charm.


TIFF LZW style - When to change the code length

Looking at the spec: https://www.fileformat.info/format/tiff/corion-lzw.htm

The function  GetNextCode() retrieves the next code from the LZW-
coded data.  It must keep track of bit boundaries.  It knows that
the first code that it gets will be a 9-bit code.  We add a table
entry each  time we get a code, so GetNextCode() must switch over
to 10-bit codes as soon as string #511 is stored into the table.
We need to change the code length as soon at #511 is stored.

However in the code the change is done at 510:
https://github.com/image-js/tiff/blob/73ca97100c0674855db1be3aa71bb5385785a09c/src/lzw.ts#L94-L96
I don't know what is the correct version but the confusion could be due to TIFF version:
https://stackoverflow.com/questions/26366659/whats-special-about-tiff-5-0-style-lzw-compression

LZW codes are written to the stream in reversed bit order.
"New-style" increases the code size one symbol earlier than "old-style" (so-called "Early Change").

The current implementation in 'debug-lzw' branch seems however correct based on the lzw images we have and the comparison with convert from imagemagick.
https://github.com/image-js/tiff/commit/199aa6da9d01df5d5a432339587c3d57aa83a5ec

However in the code the change is done at 510:

I think it's just because #511 is if you count from one, and we count from zero.


Typo in options dialog box for new PS option relates to #2272

Hello, this is a cosmetic bug for src/qt/forms/optionsdialog.ui The convention for PrivateSend is to capitalise the P and the S, but in this case we have not capitalised the S.
Should,
<string>Show popups for Privatesend transactions</string>
be instead,
<string>Show popups for PrivateSend transactions</string>
?
Cheers,
-X

fixed by https://github.com/dashpay/dash/pull/2315 closable @UdjinM6


gltfpack: Output GLTF is invalid if input scene has missing image files

When optimizing a GLTF file which has image entries referencing missing files, the exported image entries have neither their uri property nor their bufferView property defined.
According to this JSON schema in the specs, such entries are invalid.
When optimizing, gltfpack logs warnings about skipping these missing images entries to the console, which means it already is aware of this possibility.
As such, I would expect it to produce a valid GLTF file by simply copying these entries to the output file without any processing.
(related to KhronosGroup/glTF#2377)

I'm not sure if copying the URI unconditionally is always a good idea: if the output is a GLB file, I'd expect no external references and there might be issues if the target application doesn't expect that any URIs are preserved (eg maybe it's a URI that can be used maliciously somehow). Maybe in that case an empty URI would suffice...

@zeux i was able to get a model with this problem ( looks like it from the hubs exporter)
i send you  the glb per mail

Yeah I didn't include a sample (probably should have, sorry) but to confirm this issue, I used this one from the glTF-Sample-Assets repo and simply removed the png file.

One other potential cause here is that when using -tc, if the image path is valid but it refers to an invalid image (eg format encoding issues), Basis texture compressor will fail to process the image - as it should - and the image object will be left blank, which will also make the asset's JSON invalid.


Media kit android package issue

the new version of media kit
media_kit_libs_android_video: ^1.1.1

gives error in pub get
D:\Projects\Apps\Sanji.to\sanji>flutter pub get
Resolving dependencies... (5.6s)
Because no versions of media_kit_libs_android_video match 1.1.1 and no versions of media_kit_libs_android_video match >1.1.1 <2.0.0,
  media_kit_libs_android_video ^1.1.1 is forbidden.
So, because sanji depends on media_kit_libs_android_video ^1.1.1, version solving failed.

Just use packages given in the README.

Just use packages given in the README.

thats what i did

i overritten the previous versions in pubspec.yaml


Feature request - Add experimental

As specified in CIP30 we should add injecting the experimental API that a wallet can provide.
This would also make the implementation on par with the normal dApp Web bridge.

It was more work to get it working as needed, but here is the PR. https://github.com/fabianbormann/cardano-peer-connect/pull/22 😄
The commit and the newly created classes have a lot of text explaining what is happening.
Basically, I create a blueprint of the properties and functions that a wallet wants to inject and convert into a format easily shared between different systems. The DApp can then use this blueprint to interact with the wallet as if it had direct access.
All new functions can be already used with the demo implementation, see https://github.com/fabianbormann/cip-0045-demo-implementation/pull/2

Thx @marcuspuchalla the PR has been reviewed and merged 👍


Ensure the initial branch in git is master

There's many tests depending on this all around and default
branch is changing to main so it's better to be explicit.
Backport of https://github.com/apache/buildstream/pull/1648

Note we need this to merge https://gitlab.com/BuildStream/bst-external/-/merge_requests/147/


Clean markup and fix mobile view

Woot! I fixed some of the redundant markup and styles, and made the site mobile responsive!
Go Benny!

that is great thanks 👍 📱


unity demo is broken

-or at least, I can't get it to work. It spits out a load of errors like:
"Assets/YarnSpinner/Code/DialogueRunner.cs(461,74): error CS0234: The type or namespace name VariableStorage' does not exist in the namespace Yarn'. Are you missing an assembly reference?"
Any hints?

If you've just cloned the repo and opened the Unity project, the built DLLs that contain the Yarn Spinner classes won't be present, and you'll get that error. Grab the built package from the project's releases page, and install that package, and it should work.
I'll close this issue now, but if you're still seeing problems, please don't hesitate to re-open it!

Sadly - no - I downloaded the built DLL. Cloning the repo gives a different error. The classes that aren't present are:
VariableStorage
Dialogue
Line
Options
OptionsChooser
Command
and Value
Gonna try dl'ing an older build, see if that works.

9.9 works just fine.

Same problem here.

So I do not find a unity package to import...did i miss that in the clone?


Add GNS networking implementation

This adds the possibility to switch between steamworks' and Valve's GameNetworkingSockets implementation during development by defining the constant USE_DEV_NET.
GameNetworkingSockets/ValveSockets.cs is basically the C# binding from Valve extended by LoadNativeDll() which loads the GNS binaries. These binaries would have to be built by everyone as there's no binary release. We might however add some prebuilt binaries according to GNS's license.
Please feel free to give any feedback or refactor the code as needed.

Looks better and better! :)
First question:
What do you think about extracting GameNetworkingSockets to a separate repo and reference it via nuget?
In my opinion it shouldn't be a part of the mod (it is quite generic and can be used in other project).

Very good idea. However I would have to first learn how to do such things. Especially when it comes to questions like: How to package native libraries with a nuget package? And how to handle native libraries bundled in a nuget package correctly?
Also the way how the native library is currently provided, loaded and used really isn't that simple and intuitive and that would have to be changed to get a package that could easily be used. I am not sure if I could come up with a good solution in a reasonable amount of time due to my lack of expertise in that area.

I'm fine with that. Probably I'm not going to work on this in the foreseeable future. At least it's relatively easy to use to hopefully enable more contributions.
Maybe it makes sense to create an issue for this and mention the suggestions there.


Add nbn as a genesis validator :D

Please provide some contact info provided. Not merged for now due to no contact info


Allow setting of the cursor explicitly

The cursor can already be configured: #113.
Allow configuring omitting the cursor entirely through a setting.
show_cursor: bool

Implemented in #132


Organize Parent organization pull down.

Overview
Can the "parent organization" pull down be organized alphabetically? Long pull down menu and I need to fix some of the parent organizations.
Action Items
Reorganize list of parent organization in the template
Resources/Instructions

@emecas Example of what I want to fix: Code for Brasov is a part of Code for Romania, but its parent organization is Code for Poland. Several Romanian cities are showing Code for Poland as a parent. And Ok Lab Hannover is showing Australia as its parent org.

WIP, figuring out additional details about Django possibilities to reorganize organizations list by grouping parents first and reviewing issues in existent data

@emecas How about trying an autocomplete field? https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.autocomplete_fields

@emecas How about trying an autocomplete field? https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.autocomplete_fields

@cnk that sounds like a good alternative, I will research how that works!!

Reason for not showing in alpha - default in storage is hierarchical (nested).
@cnk to sort the damn list. : >

This issue requires an audit of Django to see if this still needs changing


chore(deps): update common-dev-assets digest to eec8f4a

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
ae92dfa -> eec8f4a

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

GitHub release
v5.1.0

Your semantic-release bot :package::rocket:


Give Eric push rights

Username: @yurrriq

I'm trying to clean up the branches/forks in preparation for an lfe_doc overhaul :grin:

Done! There's a new admin team, all repos have been added to it, and you have full rights :-)

Thanks!


60 entries max?

Is there a way to extend beyond the 60 entries on the players base url?  What if I want to scrape every player?

Nevermind, saw the post about user agent

@montorod can you elaborate? I am having the same question


Using custom components for cell editing

Hi there,
I was wondering if the ability of using custom components for cell editing wouldn't be a nice feature to have. Use cases could be file upload fields or date pickers. Adding such editors to the core would probably be out of scope but the ability to define and pass custom editor components to react-bootstrap-table certainly would be nice.
I already forked the project and had a go at it myself but I am not (yet!) a react.js pro, so I am unsure if my strategy for implement is the way to go or not :)

@markmywords, thanks you this component. I thinks the data picker can be included to the core, but upload field is a little bad idea, it need a custom component for user to define their editing component. So I need sometime to think about that :) In addition, if you have any questions, feel free to ask

Hi and thank you for your fast reply. Yeah, a file uploader might not be a use case for a lot of people and I just wanted to use it as an example. What I needed for example was a select field where I can store an object id as value and display the object name at the same time. For this I just added the following to Editor.js:
else if(editable.type === 'custom'){
    var CustomWidget = editable.widget;
          return(
                <CustomWidget {...attr} attr={attr} options={editable.options} defaultValue={defaultValue} />
            )
}

It works fine but I don't know if this a good solution in react.js. I posted this issue to see if there is interest and maybe someone else is looking for a way to do something similar :)
And thanks for providing this great library btw!

It's seems like good at my first seeing, maybe you can make a PR and I can help you to make this cool feature be better :)

+1 for the datepicker in editing + inserting new data.

Any file uploader on the horizon?

hi @battarro and @dannysindra, Hope I can support it in recently, but I'm busy on my work, so PR is welcome. I promise I'll keep these asking feature in my mind, but there're a lot of things to do so that any improvement will be slow currently. sorry guys ;(

Released on v2.4.0. Check this example

v2.4.1 enable to use date picker on row insert and cell editing, check this


Missing parcellation

I would like to extract averaged myelin values from the aparc and apar2009s parcellation. I've found dscalar.nii files in the repository, but there are no dlabel.nii files for the respective parcellation. I am not sure, but it seems like the individual parcellations are required to run the following command. Am I correct?
wb_command -cifti-parcellate xxx.dscalar.nii xxx.aparc.a2009s.32k_fs_LR.dlabel.nii COLUMN output.pscalar.nii

I think there's some epistemological confusion here. Please allow me to clarify:
subject-specific label files are typically annotations that leverage the subject's measured data in order to customize the parcellation scheme -- also known as precision functional mapping this leads to different ROIs and differently shaped systems from subject to subject. Examples can be found here:
https://doi.org/10.1101/2<IP_ADDRESS>5422
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5568802/
https://www.cell.com/neuron/pdf/S0896-6273(17)30613-X.pdf
In general, template label files that are applied consistently across multiple subjects are often derived a priori from independent data averaged across many subjects (not a literal average, of course). These label files are the same for each subject, and enable comparisons of the same ROI across mutliple subject -- at the cost of precision. These aren't actually specifically labeled for each subject, but in some pipelines, may be provided as a convenience.
As long as such label files are properly mapped to the same standard space (for ABCC data, this would be the MNI 2006 Nonlinear asymmetric atlas in volume, and freesurfer L/R 164/32k for the surface), the cifti parcellate command you have above should work just fine.
I'm curious why Rahul Desikan's (זכרונו לברכה) atlas?
We do have a collection of general ROI sets that can be used for this purpose, here's a link to a folder containing them:
https://drive.google.com/drive/folders/1XUNzIGblYroDvqcNb-GAXNRAfGlZGjek?usp=share_link
Finally, I would be cautious about using myelin maps in general and do some EDA on the stability first. Some normalization transforms to the data may be warranted.

Thank you for the prompt response. I appreciate the atlases you sent me to obtain the relevant statistics. However, I still have reservations about the redundancy of the DK parcellation for the specific participants. When I examined the output of the HCP-ABCD pipeline, I noticed a significant difference between "fsaverage" and the individual parcellation (for fsLR32k). I did not enable MPM registration for my data. Do you think that may have been the cause?
I would like to use the ABCD myelin data as a reference for my dataset. Could you please confirm if the file "sub-#/ses-#/anat/sub-#_ses-#_space-fsLR32k_myelinmap.dscalar.nii" corresponds to "#.MyelinMap.32k_fs_LR.dscalar.nii" or the bias-corrected "#.MyelinMap_BC.32k_fs_LR.dscalar.nii" from the HCP ABCD pipeline?
With kind regards,

The above link takes me to the NHP version of our pipeline -- we also have human child/adult and human infant . Given the repository, I was under the impression that the child/adult pipeline was being used -- is that correct or am I mistaken?
No worries either way, just want to make sure we're on the same page :)
Ok, I think I understand now -- you wanted to use the freesurfer naive bayes classified parcellations based on Rahul's manually drawn labels. We don't routinely pull these through to the derivatives -- though they are present in the processed output itself (prior to running file-mapper above).
The "fsaverage" will indeed be different from "fsLR32k". The fsaverage refers to freesurfer's fsaverage template as opposed to the freesurfer L/R resampled to 32k vertices.
Yes the correspondence should be the same to the 32k_fs_LR.dscalar.nii -- we have a list of all the correspondences here, if you're interested :)

Thank you again for the clarification. We used human child/adult. So, you're saying that the pipeline we ran is not the same one used for the NDA ABCD Collection?

the NDA ABCD collection used the human child/adult. If you're running the pipeline yourself, one can pull this in assuming one has not run the customclean stage.
Happy to walk this through in a quick zoom meeting if you'd like -- feel free to contact me at<EMAIL_ADDRESS>

Eric, tnanks a lot for these clarifications!


The PropGet trait has not been re-exported

Like PropSet makes setting styling properties much simpler, PropGet makes it a lot simpler to write widgets that need to be aware of their styling (for instance, to be able to subtract their borders from the total size, or to respect some common styling properties while doing custom rendering on a canvas). It would be nice to be able to use this for custom widgets.

I beleieve this issue may be fixed by the addition of the EventContext and DrawContext in #178 and #189. The style properties can be set on the current entity with the relevant methods on the EventContext and retrieved for custom drawing with the relevant methods on DrawContext.

Yes the new context methods indeed work great for the DrawContext. In the EventContext you can get the information as of #237, but there are no direct getters like PropGet provided.

Yes the new context methods indeed work great for the DrawContext. In the EventContext you can get the information as of #237, but there are no direct getters like PropGet provided.

You make a good point. I think it would be useful to be able to both get and set properties from the EventContext. Not sure if I'll go with a trait or not but my thinking is something like property_name for gettng and set_property_name for setting. So for example:
let background_color = cx.background_color().copied().unwrap_or_default();
cx.set_background_color(Color::red());


Connection closed by foreign host on RHEL VM running Routinator Docker Image

Hi,
I'm having an issue connecting to the WebUI on port 9556 when running the Routinator Docker container on RHEL v7.9. I keep getting "ERR_CONNECTION_RESET" error in the browser. I've verified there are no firewalls blocking my access. I stopped the container and used "nc" to open up port 9556 on my RHEL VM, then from a remote machine, I'm able to successfully telnet to port 9556 and send data back and forth. However, when I run the Routinator Docker image as instructed in the Readme it does not connect on port 9556 in the browser.
I then run the same Routinator Docker image on my Ubuntu 18 VM and everything works fine with no issues to get to the WebUI on port 9556.
I've disabled IP tables, selinux, and firewald on my RHEL VM but no luck. I'm not sure what else could be causing this issue.

I did a quick test with a CentOS 7.9 VM in AWS using latest Docker (installed using these instructions) and copy-pasted the README instructions for using Docker and was able to connect from my local machine via my browser to port 9556 on the AWS VM (and via that to the Routinator process inside the Docker container).
It took a few minutes before http://:9556/metrics responded with actual metrics rather than "Initial validation ongoing. Please wait." which is normal for Routinator.
I also tried running the Routinator Docker container inside a CentOS 7 LXC container on my Ubuntu 18.04 LTS machine and was able using SSH port forwarding (ssh -L 9556:<IP_ADDRESS>:9556 user@lxccontainer) to view the web UI of the Routinator container using a browser on my host.
So ... I'm not sure what the problem is, sorry.
Perhaps you could try passing --net host to the docker run command to cause Routinator to bind directly to the host network interface and see if that helps?
One common issue with Docker is that it doesn't by default support IPv6 so I wonder whether there could be an issue with a connection to the host via IPv6 not being forwarded to the Docker container port?

Hi @ximon18 ,
Just figured out the resolution today. I had to change the default Docker subnet from <IP_ADDRESS>/16 to <IP_ADDRESS>/24. Just followed these steps.
Thank you,
Mohsin

Thanks @mohsin106 for posting back here with the resolution, perhaps that will help someone else in future!


Add !=~ (regex match)

Like the =~ operator but "notted".
https://github.com/lefthandedgoat/canopy/blob/scaffold/src/canopy/canopy.fs#L456

Will do!

Available now!
https://www.nuget.org/packages/canopy/0.9.45


How to validate Webhook payload ?

How do I validate the marketplace webbook payload and reject the once that are not triggered by Microsoft ?
I could not find any API that will validate the webhook payload ?
Please provide an example on how to achieve this validation.

Hi @ameyasubhedar  please find more information on securing webhook here https://github.com/microsoft/Mastering-the-Marketplace/blob/main/saas/README.md#securing-a-simple-saas-webhook-in-net


Broken pipe (os error 32) on Macbook M1 pro

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (7398b65 2023-03-30T00:05:52.75238Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug

run forge init dex

edit foundry.toml with content :

[profile.default]
src = 'src'
out = 'out'
libs = ['lib']
solc = /Users/thanhlv/.nvm/versions/node/v16.15.0/bin/solcjs

run test forge test -vv

error :
[⠰] Compiling 21 files with 0.8.19
Error:
Broken pipe (os error 32)

Context:
- Broken pipe (os error 32)

Does anyone know how to fix this problem on Apple M1 Pro ?

Component
Forge
Have you ensured that all of these are up to date?

[x]  Foundry
[x]  Foundryup

What version of Foundry are you on?
forge 0.2.0 (7398b65 2023-03-30T00:05:52.75238Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug

run forge init dex
edit foundry.toml with content :

[profile.default]
src = 'src'
out = 'out'
libs = ['lib']
solc = /Users/thanhlv/.nvm/versions/node/v16.15.0/bin/solcjs

run test forge test -vv

error :
[⠰] Compiling 21 files with 0.8.19
Error:
Broken pipe (os error 32)

Context:
- Broken pipe (os error 32)

Does anyone know how to fix this problem on Apple M1 Pro ?

Hey, were you able to fix this?
i'm currently facing the same error


Set vertical space global alert when activated

Description
Describe the issue that you're seeing.
Steps to reproduce
Clear steps describing how to reproduce the issue. Please please please link to a demo project if possible, this makes your issue much easier to diagnose (seriously).
Expected result
What should happen?
Actual result
What happened.
Environment
Paste the information here as shown by hyas info

No longer relevant: https://getdoks.org/


Make the distribution file smaller

stampit v2 full minified is 13K.
The stampit v3 full minified is 44K.
We are using _.mergeWith. But stampit v2 uses lodash v3, and stampit v3 uses lodash v4.
Looks like lodash v4 is a bulky thing unlike lodash v3.
I've taken a look at the lodash implementation of the _.mergeWith. It does a lot of extra checks which in our case it really necessary. We should do the following:

Copy-paste the reference implementation of stamp specification.
Remove the stamp-specification dependency from stampit.
Use a different _.mergeWith implementation (e.g. lodash v3, or lodash.mergewith module, or some other thing).
(???) With the new rollup build we might even remove the lodash dependency altogether. Not sure about that one though.

P.S. Could be babel-polyfil fault too. :)

Dropping transform-runtime alone it went down to 30K minified. That's 14K for just polyfills.
Dropping mergeWith and we are down to 20K minified.
Dropping both of these and minifed bundle is at 5K.

Considering that transform-runtime is harder to replace. Finding alternative for mergeWith is indeed step in a right direction.

Do we get significant savings if we change all usages of lodash to lodash/function so that we're not bundling the entire library?
e.g.
// not this
const _ = require('lodash');
// _.mergeWith

// this
const mergeWith = require('lodash/mergeWith');

@JosephClay this might sound weird, but
const _ = require('lodash');

generates smaller distributive files than the
const mergeWith = require('lodash/mergeWith');

AFAIK the magic is cast by this line: https://github.com/stampit-org/stampit/blob/9bd809b55d872c91736641820851e9abfa35ee50/package.json#L35-L35

Personally I wouldn't be dropping stamp-specification as dependency. It would make it only harder to maintain if something changes.

compose() is moving from stamp-specification to stamp-utils. I agree it's OK to keep it as a dependency -- but stamp-specification is going to stop serving the compose() function.

@JosephClay Yea unfortunately lodash is not ready for real tree shaking yet, so it has to be hacked through that babel plugin.

compose() is moving from stamp-specification to stamp-utils. I agree it's OK to keep it as a dependency -- but stamp-specification is going to stop serving the compose() function.

Um so stamp-specification would be just written manual how to do it? I hope that stamp-utils don't become dependency of stampit, that sounds kinda weird to me.

Um so stamp-specification would be just written manual how to do it?

That would be ideal. But sounds complicated. :)

I am confused now, what would be complicated? There is already written manual of specification. By removing functional code from there makes it "written manual of how to do it".
I meant more like that making stamp-utils seems like bloating stampit package bit more with stuff that some people might not ever use. If they want it, they can use that dependency itself. However that means stampit will need to implement spec on its own. Is that the plan?

There is already a manual: https://medium.com/@koresar/fun-with-stamps-episode-4-implementing-stamps-in-30-loc-e52f5c17dcfe

However that means stampit will need to implement spec on its own. Is that the plan?

Yes.

stamp-specification is just the spec, going forward. stamp-utils is a tiny collection of low level tools for working with stamps that other libs (like stampit) should feel free to depend on.

stampit will need to implement spec on its own. Is that the plan?

I thought it was interesting to have different people working from the spec writing independent stamp implementations just to test the spec and make sure the core team understood it well enough to write compatible implementations, but I don't care whether or not we actually keep a bunch of independent implementations of the spec going forward.
We're all busy people. Let's do the simplest thing that works. =)

it was interesting to have different people working from the spec writing independent stamp implementations

Oh, yeah!
Btw, I already found problems in the check-compose module. Will talk about it later. :)

Alright, fair enough. Anyway that got bit side tracked here from main issue of size, but that needs to be tackled mainly in stamp-specification / stamp-utils first.

Removed lodash, polyfills, unused helper methods, etc. Now the minified stampit is 5.7K
$ ls -l dist/
-rw-r--r--  1 vasyl  staff  12784 Jun 12 22:23 stampit.es5.js
-rw-r--r--  1 vasyl  staff  18529 Jun 12 22:23 stampit.es5.js.map
-rw-r--r--  1 vasyl  staff  13682 Jun 12 22:23 stampit.full.js
-rw-r--r--  1 vasyl  staff  21246 Jun 12 22:23 stampit.full.js.map
-rw-r--r--  1 vasyl  staff   5874 Jun 12 22:23 stampit.full.min.js
-rw-r--r--  1 vasyl  staff   9872 Jun 12 22:23 stampit.js
-rw-r--r--  1 vasyl  staff  18244 Jun 12 22:23 stampit.js.map
-rw-r--r--  1 vasyl  staff   9788 Jun 12 22:23 stampit.mjs
-rw-r--r--  1 vasyl  staff  18241 Jun 12 22:23 stampit.mjs.map

Lodash.

Reimplemented isFunction and isObject. As the result no lodash dependencied in the src/stampit.js file.
The src/compose.js were using lodash/assign and lodash/mergeWith.

The assign was easy to replace. I copy-pasted the Sindre Sohus implementation proposed by @FredyC.
The merge was copy-pasted form deepmerge module found by @FredyC. It is implemented almost as we need it. But not exactly. There are tests still failing. Working on them now.

I'm pretty happy with 44->5.7 KB file size improvement. :)
We can squeeze 1KB more I think.
Let me know what you think. https://github.com/stampit-org/stampit/tree/v3_0
I'd like to thank @FredyC for doing all that rollup initial work. Very helpful!

I'm wasting too much time on that babel, lodash, ES6, etc. This pushes me to the conclusion that using ES6 for stampit is a bad idea.
Take a look at the React or lodash for instance. Their source code is ES5.
I'm tempting to rewrite stampit v3 using ES5.

I am sorry you had to go through with that, I could have helped me as I have much more experience with build systems and how it works.
I see you got rid of stamp-specification as well. I am still not convinced about this step as it could make things easier for changes to spec. Anyway I think those utility function should perhaps go to stamp-utils?

Which exactly utility functions?

Those you created instead of using lodash, but I guess that depends on if I can convince you of getting stamp-specification back into the mix. In case you want to keep it this way, it's not probably necessary.

The stamp-specification code was written in the most readable and easy ti understand way. It is very important to keep it like that. So, I'm going to supply a PR which improves the readability but degrades the performance.
The stampit is our main module. It should be as performant possible unlike the stamp-specification.
The stamp-utils is the small "utility belt" module for those people who don't want to bloat their (browser?) apps with all the powers of stampit, but wishes to write pretty code. So, stamp-utils would need the stamp-specification dependency to be replaced with something more optimized.

Ok I see, that makes sense. :+1:

I am thinking if it's actually necessary to place code for all these functions to the root. I placed the isComposable and isStamp there because they might want to be used separately, but are you sure that other function will be used also? I would to say to move them to src and lower a clutter there.

@FredyC true. My bad. Will fix that. Thanks

Talked with @FredyC in the gitter chat. As the result build system:

Works on all node.js and npm versions.
The minified browser version of stampit is 6K. The gzipped is 3.1K.
Things to do:

Support for Symbols.
Move files from root to src directory.

Closing this as Done.


Adding Events and Listener methods

Hello. I am using Vue form generator. How can i add events to switches like @change and toggle the display of another element based on the on/off value of switch?

Sorry my bad. Should have read the docs carefully.


oauth callback raise an error while use gitea with woodpecker

Gitea Version
1.15.7
Git Version
No response
Operating System
offical docker image gitea/gitea:latest
How are you running Gitea?
Just request an oauth permission form woodpecker after woodpecker first install. Then there is the bug.
both in docker
gitea/gitea:latest
woodpeckerci/woodpecker-server:v0.14.3
Log in gitea
2021/12/14 04:34:01 Started GET /login/oauth/access_token for *****
2021-12-13T20:34:01.159542506Z 2021/12/14 04:34:01 Completed GET /login/oauth/access_token 405 Method Not Allowed in 259.322µs

Log in woodpecker
time="2021-12-13T20:34:01Z" level=error msg="cannot authenticate user. oauth2: cannot fetch token: 405 Method Not Allowed\nResponse: "

Database
No response
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Description
No response
Screenshots
No response

Well gitea work as expected if it get's an GET request as it expect a POST

@zxcvbnm3057 can you paste your woodpecker server config?

closing this issue as it's more a configuration issue at woodpecker -> https://github.com/woodpecker-ci/woodpecker/issues/609#issuecomment-992979051

Sorry for duplicate issue because in fact I don't know who caused the problem in fact...


[Bug]: Crashing after game match start (on squad selection screen)

[X] read this document fully before sending the issue off.
[X] are running the latest commit from this repository clean without any modification.
[X] and I have installed all requirements for this project as required to run. (even if you have gdb/gcc/g++, you need at the least the version we have selected in the appropriate requirement installation commands in the README.)

What happened?
I don't know so much about this hack tool.
A few commands I have tested so far still no luck.
I am using pop-os (updated)
Things I do:
load using: -p -u -b -l        load successfully
config load: none              just crash when start to play
Pull request successfully updated:
./toolbox.sh -p
rm: cannot remove '/tmp/dumps': Operation not permitted
hint: Pulling without specifying how to reconcile divergent branches is
hint: discouraged. You can squelch this message by running one of the following
hint: commands sometime before your next pull:
hint:
hint:   git config pull.rebase false  # merge (the default strategy)
hint:   git config pull.rebase true   # rebase
hint:   git config pull.ff only       # fast-forward only
hint:
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
Already up to date.
If cannot be solved. Any other cheats that I can try ? (sends the working only)
-Fuzion ?
-Goesp ?
-Osiris ?
-I have tried these but seems they didn't show the "Full Guide For Linux"
Relevant log output or backtraces.
No logs since I am not load any configs

duplicate issue of #113 closing

See https://github.com/seksea/gamesneeze/pull/114 for a temp fix


fairseq dependency problem

Hello. I installed the project as there were too many conflicts in the .bat file. everything is fine but fairseq, it doesn't support hydra-core==1.1 && omegaconf==2.1.2, and both of these are needed for other packages. What should I do about this.
Plus the Installer (.bat file) has problems, it really needs reworking.
SideNote*, is step 8 just outdated and not true? there is nothing to clone in that location.

Why does it need reworking?
On Sat, Dec 9, 2023, 10:32 AM Astra060 @.***> wrote:

Hello. I installed the project as there were too many conflicts in the
.bat file. everything is fine but fairseq, it doesn't support hydra-core==1.1
&& omegaconf==2.1.2, and both of these are needed for other packages.
What should I do about this.
Plus the Installer (.bat file) has problems, it really needs reworking.
SideNote*, is step 8 just outdated and not true? there is nothing to clone
in that location.
—
Reply to this email directly, view it on GitHub
https://github.com/rsxdalv/tts-generation-webui/issues/229, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTRXIZKXQT6AOP47PMB2QLYIQOYNAVCNFSM6AAAAABANUNAVOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTGNZSHAZDGNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Why does it need reworking?
…
On Sat, Dec 9, 2023, 10:32 AM Astra060 @.> wrote: Hello. I installed the project as there were too many conflicts in the .bat file. everything is fine but fairseq, it doesn't support hydra-core==1.1 && omegaconf==2.1.2, and both of these are needed for other packages. What should I do about this. Plus the Installer (.bat file) has problems, it really needs reworking. SideNote, is step 8 just outdated and not true? there is nothing to clone in that location. — Reply to this email directly, view it on GitHub <#229>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTRXIZKXQT6AOP47PMB2QLYIQOYNAVCNFSM6AAAAABANUNAVOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTGNZSHAZDGNY . You are receiving this because you are subscribed to this thread.Message ID: @.*>

Has conflicts, and a lot of them! I tried initially with that file but it did not work.

The projects have conflicts. I have tried to go to those other projects and make them fix their packages, but sometimes that is difficult or unviable. The only way to have a pretty console output is almost always just to hide it.
I have set it up so that even though it reports conflicts (out of my control) I can still install and run the projects (although, there are still 3rd party things that can break - everything from interrupted internet connections to a small package being updated automatically).
But even though the projects have conflicts in their requirements.txt (but they can be run together), it still is desirable to have them together, i.e., a TTS + RVC combo. Another option would be to have a separate venv + python server for each project and then to coordinate them on top. That was not the original direction with a gradio interface, but it might be the direction of the future (which will probably mean that 16-32GB is recommended RAM for the system).

The projects have conflicts. I have tried to go to those other projects and make them fix their packages, but sometimes that is difficult or unviable. The only way to have a pretty console output is almost always just to hide it.
I have set it up so that even though it reports conflicts (out of my control) I can still install and run the projects (although, there are still 3rd party things that can break - everything from interrupted internet connections to a small package being updated automatically).
But even though the projects have conflicts in their requirements.txt (but they can be run together), it still is desirable to have them together, i.e., a TTS + RVC combo. Another option would be to have a separate venv + python server for each project and then to coordinate them on top. That was not the original direction with a gradio interface, but it might be the direction of the future (which will probably mean that 16-32GB is recommended RAM for the system).

Alright. Thanks for the fast and detailed reply. Closing this as nothing should be wrong. If I had anymore problems I'll try to cache the packages in another environment with a higher timeout as Internet Connection might have caused the Installer to fail.
Also Thanks for the awesome project!

The projects have conflicts. I have tried to go to those other projects and make them fix their packages, but sometimes that is difficult or unviable. The only way to have a pretty console output is almost always just to hide it.
I have set it up so that even though it reports conflicts (out of my control) I can still install and run the projects (although, there are still 3rd party things that can break - everything from interrupted internet connections to a small package being updated automatically).
But even though the projects have conflicts in their requirements.txt (but they can be run together), it still is desirable to have them together, i.e., a TTS + RVC combo. Another option would be to have a separate venv + python server for each project and then to coordinate them on top. That was not the original direction with a gradio interface, but it might be the direction of the future (which will probably mean that 16-32GB is recommended RAM for the system).

Alright. Thanks for the fast and detailed reply. Closing this as nothing should be wrong. If I had anymore problems I'll try to cache the packages in another environment with a higher timeout as Internet Connection might have caused the Installer to fail. Also Thanks for the awesome project!

If you see it failing, do report, it helps even if it's due to internet or something. I recently tried installing automatic1111 with a vpn and it took me like 3 tries. I wish it was more plug-and-play, but the competing projects in the AI open source space are less like an orchestra and more like an auction house. (i.e., bark and transformers' bark are different. similar, but different, even though it was supposed to be a replacement.)

The projects have conflicts. I have tried to go to those other projects and make them fix their packages, but sometimes that is difficult or unviable. The only way to have a pretty console output is almost always just to hide it.
I have set it up so that even though it reports conflicts (out of my control) I can still install and run the projects (although, there are still 3rd party things that can break - everything from interrupted internet connections to a small package being updated automatically).
But even though the projects have conflicts in their requirements.txt (but they can be run together), it still is desirable to have them together, i.e., a TTS + RVC combo. Another option would be to have a separate venv + python server for each project and then to coordinate them on top. That was not the original direction with a gradio interface, but it might be the direction of the future (which will probably mean that 16-32GB is recommended RAM for the system).

Alright. Thanks for the fast and detailed reply. Closing this as nothing should be wrong. If I had anymore problems I'll try to cache the packages in another environment with a higher timeout as Internet Connection might have caused the Installer to fail. Also Thanks for the awesome project!

If you see it failing, do report, it helps even if it's due to internet or something. I recently tried installing automatic1111 with a vpn and it took me like 3 tries. I wish it was more plug-and-play, but the competing projects in the AI open source space are less like an orchestra and more like an auction house. (i.e., bark and transformers' bark are different. similar, but different, even though it was supposed to be a replacement.)

Sure. Thanks! I'm not much a Programmer, but yes, Projects in AI open source space are quiet messy. unlike other places like games or software. Things are progressing too fast for having harmony...


Ability to assign/change keyboard shortcuts

Would need to be able to assign/change keyboard shortcuts to use this. Possibility of adding?

You can achieve this is in macOS. System Preferences > Keyboard > Shorcuts > App Shortcuts

You can achieve this is in macOS. System Preferences > Keyboard > Shorcuts > App Shortcuts

Also interested in the ability to reassign the keyboard shortcuts.

Designated keyboard shortcuts r in the compiled nib file so u can't simply change it. I also personally dont kno enough about native mac apps and cocoa to rebuild the entire thing


replace /call handler's os/exec call with go library http client call

While os/exec to curl is a quick fix for my MacOS, it's not applicable in a container environment.
Replace the os/exec call to curl with a go library client like net/http or fasthttp.

We wound up going with FastHTTP for consistency. Merged to master


System.numerics.vectors package does not install properly

Visual Studio 2015 Update 1, using Nuget to install the System.numerics.vectors library results in an incomplete installation that must be repaired by hand.  The package works correctly on C# projects suggesting it may be a specific F# issue in visual studio.
Specifically this line should be added to the project file but is completely missing:
 <Reference Include="System.Numerics.Vectors, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
      <HintPath>..\packages\System.Numerics.Vectors.4.1.0\lib\net46\System.Numerics.Vectors.dll</HintPath>
      <Private>True</Private>
    </Reference>

Internet sleuthing suggests others have been experiencing this for a few months, and that issue was reported to corefx team who closed it because they felt it wasn't their problem: https://github.com/dotnet/corefx/issues/3103

Sounds like this issue belongs into NuGet repo.
Does it install properly using paket?
On Feb 7, 2016 16:26, "JOHN MOTT"<EMAIL_ADDRESS>wrote:

Visual Studio 2015 Update 1, using Nuget to install the
System.numerics.vectors library results in an incomplete installation that
must be repaired by hand. The package works correctly on C# projects
suggesting it may be a specific F# issue in visual studio.
Specifically this line should be added to the project file but is
completely missing:

..\packages\System.Numerics.Vectors.4.1.0\lib\net46\System.Numerics.Vectors.dll
True

Internet sleuthing suggests others have been experiencing this for a few
months, and that issue was reported to corefx team who closed it because
they felt it wasn't their problem: dotnet/corefx#3103
https://github.com/dotnet/corefx/issues/3103
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/939.

Just gave paket a try. It looks like that works. I'll move this to Nuget.

See this issue on nugets repot:
https://github.com/NuGet/Home/issues/1510

Wow how can they close it?
On Feb 7, 2016 17:35, "JOHN MOTT"<EMAIL_ADDRESS>wrote:

Reopened #939 https://github.com/Microsoft/visualfsharp/issues/939.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/939#event-542202240.

Closing as issue is in Nuget repository


Satis Update and Build job not including dist in output

When I run bin/console satis:update --build in the repo I get the this in the output which I expect
"dist": {                     "type": "zip",                     "url": "https://gitlab.url.com/api/v3/projects/namespace%2Frepo/repository/archive.zip?sha=hash",                     "reference": "hash",                     "shasum": ""                 },
When it is triggered by the webhook in gitlab that section is always missing but everything else is the same.

Hey @bdandoy, I know I'm probably way too late, sorry for the silence! Are you still seeing this? I didn't think Packages generated the dist information, but I can see that being desirable.
Let me know if you have any thoughts on this. Thanks for your time!

This was given a proper going-over in #61. Thanks again!


Revert "feat(all): add viewbox scaling (#52)", fixes #55

This reverts commit f7f6534b6a5c72d643ec43bb87e2d9b1a5d2c6f1.
@brycedorn Having looked at this code again, and tried fiddling with some other examples I have on hand, I don't think this is going to work for all cases, and breaks existing animations, which is why i am reverting.
I'm happy to work with you on figuring out how to add this in again without breaking existing usage. If you want to do that, can you add a new file in the example folder the reproduces your one case that you had in mind while adding this, and we can work from there.

hiya, sorry for this; it worked for the examples that I tried but I should've done more exhaustive testing. if you could pastebin the SVGs that didn't work for you I can take another look!


MODEXPW-483 - User schema updating - new field preferredEmailCommunication

MODEXPW-483 - User schema updating - new field preferredEmailCommunication
Purpose
Change to preferredEmailCommunications
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[x] Code coverage on new code is 80% or greater
[x] Duplications on new code is 3% or less
[ ] Check logging
[x] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[x] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

you just need to rename column in a file, nothing else, preferredEmailCommunication is in user schema, not preferredEmailCommunications

you just need to rename column in a file, nothing else, preferredEmailCommunication is in user schema, not preferredEmailCommunications

I would prefer to have consistent names in the schema and column title to avoid possible confusion in the future.


Hangs on high concurency

Describe the bug
I have a small server and was wondering how stable it is. Tried JMeter and realized that webapp stops processing new requests. All of them just hanging.
Max throughput was about 3.5k per sec.
Versions
OS, D compiler, and Handy Httpd version numbers on which you have experienced the bug.
Ubuntu 20.04, dmd 2.098.1, Handy Httpd 5.2.1
Steps to Reproduce
A simple app on a local machine, that returns data from associative array under high loading using JMeter.

Yep, I've actually experienced something similar to this locally and have been working on it.  Is there any more information you can give about the nature of the request handler logic? Would simple endpoints that return plaintext be enough to reproduce the issue?

sure here are some code details
config
`auto pathHandler = new PathDelegatingHandler();
pathHandler.addMapping("/stream", (ref ctx) {MainService.instance.handleStream(ctx);});
ServerConfig config = ServerConfig.defaultValues;
config.reuseAddress=true;
config.port=8080;
config.hostname = "<IP_ADDRESS>";
config.connectionQueueSize = 100_000;
config.workerPoolSize = 25;
config.serverLogLevel = LogLevel.WARNING;

auto server = new HttpServer(pathHandler, config);`

handler looks like this
`void handleStream(ref HttpRequestContext ctx) {
string result="{}";
string url = ctx.request.getParamAs!string("url");
if(url.endsWith(url, ".aacp")){
ulong shiftMs = ctx.request.getParamAs!ulong("shift", 0);
try{
if(!url.empty){
string norm = normalizeUrl(url.urlDecode);
Nullable!StreamEntity stream = storage.getStream(norm, shiftMs);
if(!stream.isNull){
result = stream.get.serializeToJson();
} else {
storage.addStream(norm, "", "", "");
}
}
}catch(Error e){
info("Error: "~to!string(e));
}
}
	ctx.response.writeBodyString(result, "application/json");
}`

Okay, so I may have found the issue; I have been using an improved logging system though, and I'd like to bundle the changes into a minor version release. It should be out shortly.

Should be fixed as of v5.3.0 @oracle1wr
Do note that I have updated the logging setup for Handy-httpd to use SLF4D.
Test it out, and reopen if you still see issues.

yes, it is resolved
Thank you!


Cache should be updated if its key already exists

Required Information
Bug or Feature. (Not sure)
Enter Task Name: CacheBeta@0
Issue Description
The CacheBeta@0 task will output Cache with fingerprint 'cmake|Linux|out' already exists. and won't upload the new files to cache if the cache key already exists.
Is it by design? Anyway, I think it'll be more reasonable to update the cache instead of skipping.
Task logs
Information, ApplicationInsightsTelemetrySender will correlate events with X-TFS-Session f9d52ef7-5d7f-4afa-9d2d-64de012f83a4
Information, Getting a pipeline cache artifact with one of the following fingerprints:
Information, Fingerprint: `cmake|Linux|out`
Information, There is a cache hit: `cmake|Linux|out`
Information, Used scope: 554;86d018e2-e7e4-42c2-96c4-378013445708;refs/pull/14798/merge;fb34b90b-059d-4cb4-aad8-87645979d24c
Information, Missed on the following scopes: 554;86d018e2-e7e4-42c2-96c4-378013445708;refs/heads/pimpl-and-better-include;fb34b90b-059d-4cb4-aad8-87645979d24c, 554;86d018e2-e7e4-42c2-96c4-378013445708;refs/heads/master;fb34b90b-059d-4cb4-aad8-87645979d24c
Cache with fingerprint `cmake|Linux|out` already exists.
Information, ApplicationInsightsTelemetrySender correlated 1 events with X-TFS-Session f9d52ef7-5d7f-4afa-9d2d-64de012f83a4

Sources
https://github.com/microsoft/azure-pipelines-agent/blob/3d378d9ea9a34e535d2dc62dba6598396f2fb836/src/Agent.Plugins/PipelineCache/PipelineCacheServer.cs#L36-L47

I submitted an issues in another repo too:
https://github.com/microsoft/azure-pipelines-agent/issues/2534
I'm not sure which repo is more suitable for this issue. Feel free to close one.


Markdown readme

Looks better, and its easier to read the examples.

Thanks for this, @masylum.  @tsmith, I would love to see this pull request accepted!

Why close it?


Use of original filenames

In drafting the specification, we discovered multiple places where there is the potential for cross-platform filename issues. This is one downside to relying on filesystems for structure, as not all strings are valid file or directory names.
During the packaging of a mailbag, all messages are assigned a new Mailbag-Message-ID that must be filename-safe. These IDs can be UUIDs or merely be sequential numbers, and are used as filenames for new derivative files, such as when PDFs are created from an MBOX file. Unfortunately, we don’t feel that we can use the Message-ID field that’s usually included in emails as it may not be filesystem-safe.
The issue is that users may be packaging mailbags from EML files or even legacy use cases with PDF files and these files already have filenames for individual messages. While they should be coming from the same filesystem and thus be safe to use for derivative files as well, comments from the working meeting suggested that it may be simpler to even use Mailbag-Message-ID in these cases. Interestingly, commenters suggested that even filenames for EML files were not originally created by the user sending the messages. Still, we think Nicholas Garza and Gary Richardon in particular would be alarmed if these filenames were overridden during the creation of a mailbag. So we plan to keep the original filenames whenever possible.
Perhaps a bigger issue is for attachments. We plan to keep the original filenames for attachments, but files embedded within MBOX or EML files may not have been created in the same filesystem being used to package a mailbag. We still think it’s important to keep the original names here, but for cases when an attachment filename is invalid, it is now required to renamed the file using the Mailbag-Message-ID and document changes in an original_filenames.txt file.

We've found that any type of file system metadata that we would like to retain, including file names is far easier to preserve when copied to a separate text document like the proposed original_filenames.txt file.
Is the original-filenames.txt in the proposed spec yet? I'm curious whether it would be better to have a complete listing of all attachments, with option original-filenames, like an attachments.csv file with columns for mailbag-message-id, original-filename, mailbag-attachment-id.

Thanks for the feedback! I finally got to ask the advisory board about this and while we think keeping original attachment filenames when possible is important to our user personas, we agree that the current original_filenames.txt is insufficient. There's also some helpful comments in the 0.3 spec that I'm cross-linking. We've also discovered rare cases where we got a file were unable to extract a filename that this would help handle.
We're now planning to replace original-filenames.txt with attachments.csv before a release similar to what @nkrabben suggested. We're thinking of requiring an attachments.csv for all messages, this way implementations can either preserve the original names or not and mailbag consumers can safely rely on the CSV either way. They should all be tiny files so it shouldn't be much overhead. A CSV should add the necessary structure that original-filenames.txt was lacking, and we plan to apply the same rules as mailbag.csv Cases where we are unable to get a filename can be better documented in this CSV as well.

If possible, it might be nice to generalize the columns to something like "original-attachment" and "packaged-attachment" or similar, as that might allow for migrated attachments during packaging as per this comment.

addressed in the mailbagit tool by #187. attachments.csv is planned for the next release of the spec.


Update CONTRIBUTORS.md

Hi @KikyTokamuro, thanks for your PR! Please note that this repo is not included in the hacktoberfest, so this PR will not count towards it. Details here: https://hacktoberfest.digitalocean.com/resources


[Concurrency] Always downgrade concurrent_access_of_local_capture to a warning until Swift 6.

This error only happens if you mutate a var in a @Sendable closure, and all Sendable diagnostics should be warnings in Swift 5 mode.

@swift-ci please smoke test

@swift-ci please smoke test


[ISSUE] RAT reports some files with unapproved license

BUG REPORT

Please describe the issue you observed:

What did you do (The steps to reproduce)?

The following files need to exclude for the check list:
11 Unknown Licenses

Files with unapproved licenses:
rocketmq/.github/ISSUE_TEMPLATE/issue_template.md
rocketmq/.github/PULL_REQUEST_TEMPLATE.md
rocketmq/.travis.yml
rocketmq/remoting/src/test/resources/certs/badServer.key
rocketmq/remoting/src/test/resources/certs/badClient.key
rocketmq/remoting/src/test/resources/certs/client.key
rocketmq/remoting/src/test/resources/certs/server.key
rocketmq/CONTRIBUTING.md
rocketmq/broker/src/test/resources/META-INF/service/org.apache.rocketmq.broker.transaction.TransactionalMessageService
rocketmq/broker/src/test/resources/META-INF/service/org.apache.rocketmq.broker.transaction.AbstractTransactionalMessageCheckListener
rocketmq/distribution/bin/README.md

Please tell us about your environment:

Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

You can verify this with the mvn cmd:
mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle

@walking98 Some files does not need license check, so ignore it.


US-112 | fix: fix unknown and zero accessibility shortcoming counts

Description
fix: fix unknown and zero accessibility shortcoming counts
refs US-112
Tickets
US-112

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search sources branch is deployed to platta: https://kuva-unified-search-sources-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search sources branch is deployed to platta: https://kuva-unified-search-sources-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search sources branch is deployed to platta: https://kuva-unified-search-sources-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search sources branch is deployed to platta: https://kuva-unified-search-sources-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search sources branch is deployed to platta: https://kuva-unified-search-sources-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search graphql branch is deployed to platta: https://kuva-unified-search-pr107.api.dev.hel.ninja :rocket::rocket::rocket:

Unified search sources branch is deployed to platta: https://kuva-unified-search-sources-pr107.api.dev.hel.ninja :rocket::rocket::rocket:


Remove logging exporter references

This PR was merged recently which removed the logging exporter from the list of valid exporters: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30408. This results in the following errors when using the helm chart:
* error decoding 'exporters': unknown type: "logging" for id: "logging" (valid values: [logzio loki pulsar awsxray dataset googlemanagedprometheus sumologic awskinesis carbon coralogix dynatrace elasticsearch googlecloudpubsub logicmonitor prometheus awsemf skywalking splunk_hec sapm clickhouse opencensus opensearch signalfx awscloudwatchlogs otlp alibabacloud_logservice cassandra file influxdb sentry debug datadog googlecloud kafka mezmo awss3 azuremonitor instana prometheusremotewrite syslog tencentcloud_logservice zipkin alertmanager azuredataexplorer honeycombmarker loadbalancing otlphttp])
2024/02/16 19:25:03 collector server run finished with error: failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:

* error decoding 'exporters': unknown type: "logging" for id: "logging" (valid values: [logzio loki pulsar awsxray dataset googlemanagedprometheus sumologic awskinesis carbon coralogix dynatrace elasticsearch googlecloudpubsub logicmonitor prometheus awsemf skywalking splunk_hec sapm clickhouse opencensus opensearch signalfx awscloudwatchlogs otlp alibabacloud_logservice cassandra file influxdb sentry debug datadog googlecloud kafka mezmo awss3 azuremonitor instana prometheusremotewrite syslog tencentcloud_logservice zipkin alertmanager azuredataexplorer honeycombmarker loadbalancing otlphttp])

We should revert the changes made in this PR in order to remove references to the logging exporter: https://github.com/open-telemetry/opentelemetry-helm-charts/pull/907

@liustanley I believe you'll only run into this issue if you use the image created from make docker-otelcontribcol from the contrib repo.  The images published at https://github.com/open-telemetry/opentelemetry-collector-releases still contain the logging exporter

I was imagining we'd keep the logging export in the helm chart until it is officially removed.

@TylerHelmuth We're using a fork of opentelemetry-collector-contrib with these helm charts, so this broke our CI workflows when we updated our fork with upstream.

I think this config will remove it from the confmap:
config:
  exporters:
    logging: null

Thanks! That seems to work


fix template render issue in notifications

Can no longer pass Context object to Template, should be dict. Simplified by using render_to_string.

https://docs.djangoproject.com/en/1.11/releases/1.10/#features-removed-in-1-10

We were on Django 1.10 until recently so I'm surprised this issue has only popped up now that we're on 1.11.


ci:tests: Extend mfa-provider-selection-sso to ensure SSO is reused

When multiple MFA providers are globally enabled and there's an SSO
active, it's not reused as we expect. This test makes sure that after
we've authenticated and sent back to the service, if we attempt to login
to the same service again, the SSO is reused.
The last await page.waitForNavigation(); never returns since the
MFA provider selection menu is thrown at the user. If I am not mistaken, what's
expected here, is to redirect back to the service, since there's an active SSO that fulfills
the authentication requirements for the service.
This test covers what's described in https://github.com/apereo/cas/pull/5205.

Thanks much for the patch.

The last await page.waitForNavigation(); never returns since the MFA provider selection menu is thrown at the user. If I am not mistaken, what's expected here, is to redirect back to the service, since there's an active SSO that fulfills the authentication requirements for the service.

The test is invalid. You're correct about the expectation, and yet incorrect about the test behavior. The reason that call never returns is because there is no change in page navigation. You have already arrived at your destination, which is the github page with a service ticket. There is no other navigation event to handle, and the browser gets stuck. You can easily see this by watching the headless browser get to github and then wait forever.

The test is invalid. You're correct about the expectation, and yet incorrect about the test behavior. The reason that call never returns is because there is no change in page navigation. You have already arrived at your destination, which is the github page with a service ticket. There is no other navigation event to handle, and the browser gets stuck. You can easily see this by watching the headless browser get to github and then wait forever.

I have added another goto() call, after logging in and there should have been a redirect back to the github.com (along with the ticket), instead I get stuck at the MFA selection page

Could you update the test script so I can see the changes you made?

Hey @mmoayyed thanks for the prompt response! I meant that my original commit -as is- adds another goto() call, after the browser has logged in. Which leads me to the screenshot shown above. Did you run the test and you end up at github.com instead?

Yes, it should be.
Here is the passing test: https://github.com/mmoayyed/cas/runs/3180225375?check_suite_focus=true
Here is the script: https://github.com/mmoayyed/cas/blob/master/ci/tests/puppeteer/scenarios/mfa-provider-selection-sso-session/script.js
Make sure you are not running stale changes.

Alright, that makes sense, I've been running the test off of apereo/cas:master, whereas the passing test above runs off your master, which is several commit ahead of apereo/cas' master. There seems to be a fix for the testcase I wrote somewhere in those commits.
Cherry-picked a few commits from your branch that seemed related and verified it.


ImportError: No module named gridfs

this image explain it all....
i followed the Readme on this github...
Image

Same issue.

I am facing this issue too