Icons broken - auto-linking issue? - react-native 0.63.2

I have gone through these following points

[x] Check latest documentation: https://docs.nativebase.io/
[x] Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
[x] Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
[x] Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
[x] For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
[x] For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description
A recent update to Xcode introduced an issue in ReactNative causing images to not render. This was patched in React-Native. In order to get my project working again I had to upgrade my version of react-native (0.63.2). In doing that I have found that NativeBase auto-linking appears to be broken.  I get error Unrecognized font family 'Ionicons' when running my app in the iOS simulator. Which tells me the fonts were not linked correctly. Icons are also broken on Android but there is no error message.
node, npm, react-native, react and native-base version, expo version if used, xcode version
Node v12.18.2
Npm 6.14.8
react-native 0.63.2
react 16.13.1
native-base 2.13.14
xcode 12.0.1
Expected behaviour
Installing native base should auto link Icon fonts.
Actual behaviour
Errors related to missing fonts which indicates broken auto link functionality.
Steps to reproduce
Setup fresh react-native environment with latest react-native and latest native-base.
Is the bug present in both iOS and Android or in any one of them?
The error appears on iOS only but icons are also broken on Android which makes me think the same issues is affecting both iOS and android.

After upgrading to react-native 0.63.2 I've also noticed that icons are broken. I've created an example repo with a new RN project. As you can see in the screenshota below as well as in the example repo icons in iOS and Android are displaying the wrong icons.
The icons in the screenshots are:
<Icon name="arrow-forward" />
<Icon name="arrow-back" />
<Icon name="home" />

Example repo is https://github.com/akontaroudis/NativeBaseBrokenIcons
native-base version is 2.13.14

We are seeing this too.
#3194 which while closed, only solved in for android, but not really.
rm android/app/src/main/assets/fonts/*.ttf
cp ./node_modules/react-native-vector-icons/Fonts/*.ttf android/app/src/main/assets/fonts/

should not be the solution.
As far as I can tell it's due to the vector-icons and native base having different fronts in their folders... but there's some noise around this.
#3216 is a PR that is meant to fix this. but has been moved.
#3161 @hanykumar has said that running through the manual linking of the fonts may solve the problem, but this should all be handled by latest version of autolinking, which doesn't require any developer input.

Okay, while I haven't tested this for android if you yarn add react-native-vector-icons and do a pod install you should see it fixed
If you've manually added the fonts prior, you will need to remove them from the build phase as now vector icons will autolink the fonts into your project. see https://github.com/oblador/react-native-vector-icons/issues/1225
@fosteruk can you see if this works for you too?
I think if native base is going to let vector maintain the fonts then this is much better solution. As it auto links automatically, at least for ios.

@jahead I just tried but it doesn't fix it for me. Still getting an error on iOS and the icons are not displaying in either iOS or Android.

Here got the same native base issue. In my case, was trying to use the radio button, but seems that doesn't show well on android also.

i have the same issue

Same problem

@jahead I managed to get it working by installing react-native-vector-icons and then manually adding it to my ios/Podfile and also manually editing Info.plist to reference Ionicons.ttf. I have not tested it on Android yet but I imagine manual linking would be required for that also.
While it is possible to get it working. This linking step should be dealt with automatically. This still needs to be fixed.

I tried to link all the font files from the react-native-vector-icons into projects Build Phases in Xcode and it worked for me. And for android, I deleted all the fonts under android/app/src/main/assets/fonts and re-added them.

Hope this helps

@fosteruk Hey thanks for adding that extra step! I wasn't working from a completely clean environment.
@asyam1 Yep, it seems you have to follow the vector icons install guide to link the assets for ios and android.
https://github.com/oblador/react-native-vector-icons#option-with-gradle-recommended
If you don't want to copy the assets you can follow the above guide have gradle automatically copy the assets at build time. Which will mean you shouldn't see this out of date error in the future.
I think the documentation should reflect this step more explicitly. It also be nice to get some feedback from the maintainers on this issue, I'm happy to do a PR if the work aligns to their goals.
@Dheyson @sefamertkaya @haserta98 Are you still having issues, after following the comments here?

@jahead thanks so much for right solution!!

I am facing same issue RN:0.63.3 Xcode : 12.0.1

Did you follow the instructions on installing react-native-vector-icons?
Get Outlook for Androidhttps://aka.ms/ghei36

From: InfoAndroid<EMAIL_ADDRESS>Sent: Monday, November 2, 2020 9:43:17 PM
To: GeekyAnts/NativeBase<EMAIL_ADDRESS>Cc: jahead<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [GeekyAnts/NativeBase] Icons broken - auto-linking issue? - react-native 0.63.2 (#3262)
I am facing same issue RN:0.63.3 Xcode : 12.0.1
[Simulator Screen Shot - iPhone 11 - 2020-11-02 at 16 11 34]https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F21953527%2F97859075-15678280-1d26-11eb-9940-9acf39ec6a4a.png&data=04|01||ec9d213501ce4202dea108d87f1c1c63|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637399105993209520|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gYI67e1S2AGaXZu7wGI0efhJtoVzngQa%2F%2FL2uVLmqWk%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGeekyAnts%2FNativeBase%2Fissues%2F3262%23issuecomment-720391011&data=04|01||ec9d213501ce4202dea108d87f1c1c63|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637399105993209520|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Fez7ROX%2Fgi9CK7g9lrl61ZBeZjX4%2Bh9HST4%2FMVydV%2BU%3D&reserved=0, or unsubscribehttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGV5ACAB2FOHKQBA5ZPIEDSN2EMLANCNFSM4RZVR7CA&data=04|01||ec9d213501ce4202dea108d87f1c1c63|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637399105993219514|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kVsrIUOsz87ccL5ts5DMpxQ%2Bh5uH2IQM9TYLUXqQkj0%3D&reserved=0.

Having the same issue with Android (not tested on iOS) but with Native Base 2.13.14 React Native 0.62.2. Have everything setup correctly for the react-native-vector-icons.

Did you follow the instructions on installing react-native-vector-icons? Get Outlook for Androidhttps://aka.ms/ghei36
…

I am facing same issue RN:0.63.3 Xcode : 12.0.1

I am facing same issue RN:0.63.3 Xcode : 12.0.1

The issue has been resolved now
just Add react-native-vector-icons fonts in plist

same problem bro

This is rubish

Found an easy way to fix it on both iOS and Android.
For android on android/app/build.gradle
apply from: "../../node_modules/react-native/react.gradle"
apply from: "../../node_modules/react-native-vector-icons/fonts.gradle" // <= this line, needed for vector-icons

For iOS on ios/Podfile
pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'  # <= this line, needed for vector-icons

rebuild and reinstall, icons should display properly.
As for the reason this happens, react-native-vector-icons library doesn't properly link on newer react native versions. Using Gradle and Cocoapods ensure the files needed are in sync. See the following sections in their readme
https://github.com/oblador/react-native-vector-icons#option-with-gradle-recommended
https://github.com/oblador/react-native-vector-icons#option-with-cocoapods


Problem with U2F

Hi, I've tried using Your library on Chrome browser
First I've got the error that U2F Extension is required
then I've get error from below:
factory loading
u2f-api.js:523 Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('chrome-extension://kmendfapggjehodndflmmgagdbamhnfd') does not match the recipient window's origin ('null').
factory loaded
ledger NOT supported

const Web3Ledger = require('ledger-wallet-provider');
            var factory = Web3Ledger.default;
console.log('factory loading');
            factory().then((instance: any) => {
                console.log('factory loaded');
                if (instance.isSupported) {
                    console.log('ledger supported');
                    instance.getAccounts(console.log);
                }
                else{
                    console.log('ledger NOT supported');
                }
             });

I'm runing website giving the error on my localhost
Error is thrown before promise is resolved

You need to run your application on https in the browser. For webpack for example use the option --https then U2F will be supported.


Running again after code changes shows outdated results

Steps to reproduce:

Run cargo llvm-lines
Make code changes, such as renaming a function (and changing its body)
Run cargo llvm-lines again

Expected results: output similar to that of cargo build after code changes, then showing updated results for LLVM lines and instantiation count.
Actual result: output similar to that of cargo build after code changes (so code is indeed recompiled), but the lines and count results are exactly the same as the first time, including the renamed function’s old name.
Work-around: cargo clean && cargo llvm-lines

In a more recent version of the tool I am able to get updated results without cargo clean.


CONTACT: Add integration test for logging a contact

Scenario: I'm a case manager, and I have made a call to an existing patient which ended in leaving a voicemail, or talking to the patient, or the number no longer working. Should write an integration test confirming that this creates a record of the contact.

Taking this off the sprint too until we get slightly more of this constructed -- not appropriate to build this out at this time.

This is constructed and has an associated bug -- adding to sprint 4


auth.onAuthStateChanged triggers on tab switch

Bug report
Describe the bug
auth.onAuthStateChanged triggers on tab switch
To Reproduce

Create starter project using this guide https://supabase.com/docs/guides/with-vue-3

add lines to src/main.js

import { supabase } from "./supabase";
supabase.auth.onAuthStateChange(console.log);

run npm run dev
open http://localhost:3000 in browser
open dev console
Switch to another tab
Switch back to previous tab

Expected behavior
1 SIGNED_IN event in console
Actuall behaviour
2 SIGNED_IN event in console
Screenshots
https://www.loom.com/share/56993404e5f348d2bb23b68b0ad15096
System information

OS: macOS
Browser (if applies) brave
Version of supabase-js: 1.35.3
Version of Node.js: 16.14.0

We've added functionality to recover the session when the page becomes available. This was needed for example for mobile devices that have been in the background and need to recover the session and refresh the token when the page becomes visible.
Can you outline why receiving a SIGNED_IN event is problematic for you?

Same issue for me with another context.
To reproduce

I've created a basic project with Next.js.
I've added on top of _app.tsx a context like this one:

export const AuthProvider = ({ supabase, ...props }: any) => {
  const [session, setSession] = useState(supabase.auth.session());
  const [user, setUser] = useState(supabase.auth.user());
  const router = useRouter();

  useEffect(() => {
    const { data: authListener } = supabase.auth.onAuthStateChange(
      (event: any, currentSession: any) => {
        setSession(currentSession);
        setUser(currentSession?.user ?? null);
        handleAuthChange(event, currentSession);

        if (event === EVENTS.SIGNED_IN) {
          router.push("/courses");
        }
      }
    );

    return () => {
      authListener.unsubsribe();
    };
  }, []);

  const handleAuthChange = async (event: any, session: any) => {
    await fetch("/api/auth", {
      method: "POST",
      headers: { "Content-Type": "application/json" },
      mode: "same-origin",
      body: JSON.stringify({ event, session }),
    });
  };

  return (
    <AuthContext.Provider
      value={{
        session,
        user,
        signOut: () => supabase.auth.signOut(),
        signIn: () => supabase.auth.signIn({ provider: "google" }),
      }}
      {...props}
    />
  );
};

It was problematic for me because for each SIGNED_IN event I had a redirection.
I understand your point @thorwebdev and I've just moved my redirection out of this context.
But I agree with @noty-nick. Having a SIGNED_IN event for this edge case with mobile and recovered session, it's a bit confusing.
Hope this feedback can help!
Thanks!

This fix did not work for me because I need to sync session between tabs (and I think most apps as well want this behaviour)
So my current workaround is a wrapper function that filters out unwanted events
export function onAuthStateChange(callback: (u: User | null) => void) {
  // https://github.com/supabase/gotrue-js/issues/284#issuecomment-1128435838
  let currentSession: Session | null;
  supabase.auth.onAuthStateChange((event, session) => {
    if (session?.user?.id == currentSession?.user?.id) return;
    currentSession = session;
    callback(session && session.user)
  });
}

@thorwebdev I'd be happy to add this ability to gotrue-js, Just let me know if this is smth desirable and what should interface look like

This is intentional behavior since tabs can be forgotten for a very long time in certain cases, and when you come back to the tab the user is effectively "signed-in" again.

Even if it is effectively "signed-in" again, wouldn't it be more clear if we name this as a different event? Or at least have some way to distinguish between signing in via user action vs recovering a session

This fix did not work for me because I need to sync session between tabs (and I think most apps as well want this behaviour)
So my current workaround is a wrapper function that filters out unwanted events
export function onAuthStateChange(callback: (u: User | null) => void) {
  let currentSession: Session | null;
  supabase.auth.onAuthStateChange((event, session) => {
    if (session?.user?.id == currentSession?.user?.id) return;
    currentSession = session;
    callback(session);
  });
}

@thorwebdev I'd be happy to add this ability to gotrue-js, Just let me know if this is smth desirable and what should interface look like

Where should we add this code if we are using SessionContextProvider from supabase?
Since SessionContextProvider is already doing:
  useEffect(() => {
    const {
      data: { subscription }
    } = supabaseClient.auth.onAuthStateChange((event, session) => {
      if (session && (event === 'SIGNED_IN' || event === 'TOKEN_REFRESHED')) {
        setSession(session);
      }

      if (event === 'SIGNED_OUT') {
        setSession(null);
      }
    });

    return () => {
      subscription.unsubscribe();
    };
  }, []);

How do you "wrap" this function?
Thanks!

Why was this closed?
Intentional ≠ correct. As mentioned by others, it's a horrible UX on desktop. If you're fixing something to work on mobile but it breaks on desktop in the meantime, you're doing it wrong. Now all the components that rely on useUser() to do fetching and data presentation are re-rendered on refocus.

Agreed this is a massive pain - changing tabs re-directs the user as if they just signed in.

@ToniRV you can put it like this. It worked for me and you can check the browser console to check.
export function SupabaseProvider({ children }: { children: React.ReactNode; }) {
    const supabase = createPagesBrowserClient<Database>();
    const router = useRouter();

    const onAuthStateChange = (callback: (event : AuthChangeEvent) => void) => {
        let currentSession: Session | null;
        return supabase.auth.onAuthStateChange((event, session) => {
            if (session?.user?.id == currentSession?.user?.id) return;
            currentSession = session;
            callback(event);
        });
    }

    useEffect(() => {
        const { data: { subscription } } = onAuthStateChange((event : AuthChangeEvent) => {
            console.log(event)
            switch (event) {
                case 'SIGNED_OUT':
                    router.push('auth/login')
                    break;
                case 'SIGNED_IN' :
                    router.push('dashboard/home')
                    break;
                default:
                    // router.refresh()
                    break;
            }
        });

        return () => {
            subscription.unsubscribe();
        };
    }, [])

    return (
        <Context.Provider value={{ supabase }}>
            <>{children}</>
        </Context.Provider>
    )
}

@ToniRV you can put it like this. It worked for me and you can check the browser console to check.
export function SupabaseProvider({ children }: { children: React.ReactNode; }) {
    const supabase = createPagesBrowserClient<Database>();
    const router = useRouter();

    const onAuthStateChange = (callback: (event : AuthChangeEvent) => void) => {
        let currentSession: Session | null;
        return supabase.auth.onAuthStateChange((event, session) => {
            if (session?.user?.id == currentSession?.user?.id) return;
            currentSession = session;
            callback(event);
        });
    }

    useEffect(() => {
        const { data: { subscription } } = onAuthStateChange((event : AuthChangeEvent) => {
            console.log(event)
            switch (event) {
                case 'SIGNED_OUT':
                    router.push('auth/login')
                    break;
                case 'SIGNED_IN' :
                    router.push('dashboard/home')
                    break;
                default:
                    // router.refresh()
                    break;
            }
        });

        return () => {
            subscription.unsubscribe();
        };
    }, [])

    return (
        <Context.Provider value={{ supabase }}>
            <>{children}</>
        </Context.Provider>
    )
}

Adding Clarity - Session is imported from Supabase
import { Session } from "@supabase/supabase-js";


Allow for multiple foreign_key in CreateQueryBuilder

Fixes #665
This is my first time working with this codebase so please let me know if I should make any changes.

coverage: 98.387%. remained the same when pulling 41b2a5e842153483f47034c651b218be11571518 on SebastianBoyd:multiple_foreign_key into ded17ebda5bee8334430d1eda1ec3bf1a9385f76 on kayak:master.


[Task] Dynamic expansion and contraction bootstrap on k8s

Description
Capture bootstrap metrics in admin and dynamically scale up and down bootstrap on k8s based on metrics
Task List

In admin get metric from bootstrap
In admin scale up and down bootstrap on k8s based on metrics
Front-end page development

@misaya295 I want to have a try

assign me，pls


icons and other assets don't load if no working internet connection

As it's possible that there might be times when internet is not guaranteed (i.e. it's like a router rather than a public website) we need to store all icons, css, js, logos, images for the diagnostics locally rather than grabbing them over the internet.
So we will need to store them all locally rather than serving from cloudflare, font awesome etc
Foot example we currently are grabbing some stuff from remote sources:
https://github.com/NebraLtd/hm-diag/blob/5705da57ed8d8f3bc41edfe1c15fcdd18e55ee0f/hw_diag/templates/template_hyper.html#L14-L15
We need to remove all of these and serve locally.
Ref https://nebraltd.slack.com/archives/C024BNQ1Y6T/p1686232425142909?thread_ts=1686164871.136669&cid=C024BNQ1Y6T

Working on this now - https://github.com/NebraLtd/hm-diag/tree/%23603-Static-icons-and-assets

Closed by #608 and #615 and #616


Updates

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This triggers a huge number of rebuilds, please target staging in this case.

This triggers a huge number of rebuilds, please target staging in this case.

/rebase-staging

/rebase-staging

@SuperSandro2000 is everything OK?

@SuperSandro2000 is everything OK?

The joe commit has not been split. So for me it is still a NACK.

The joe commit has not been split. So for me it is still a NACK.

@otavio done

@otavio done


Problem with rendering of vowel mutations

When trying to render vowel mutations the rendering turns out weird.
"Überflächungsstörung" gets rendered as:

@colinc86 Any updates on this?

This looks to be an error with the underlying MathJaxSwift package. When I attempt to render that string with the package, I get a MathJax error from the JS conversion method. It has my attention and I'll keep digging in to it.


How to configure endpoints?

I've tried to input this resource URI: http://collection.britishmuseum.org/id/object/PPA82633, however this returns the error message "no endpoint configured for the resource". I recall being able to visualize resources from the British Museum LOD in the past on lodlive - has the software changed?

Hi,
lodlive is pure javascript so I use a "Sesame proxy" to extract data from any resources from "unknown" domain (with no sparql configured)
well, the proxy was offline
I have configured the proper endpoint (it works better now) but sadly britishmuseum uses a pure CIDOC approach so I cannot show the titles of the resources without changing the lodlive standard SPARQL queries. If you want it working better for this domain you have to download lodlive and configure it by yourself
bye

Hello,
I have downloaded lodlive and I am working on its configuration.
I am starting with something basic:

declare my localhost endpoint for my triple store
provide an example

I start from live on lodlive but maybe this is not applying to local stores?
Otherwise it says the endpoint is not configured for the query. I got the query from the "information" text attached to the node. I tested it on workbench and the query is rights and well formed returning the appropriate results.
I don't know what to try next.. Any hint?
I wish I could make it work (I am working on a PoC for sport) as lodlive is very appealing.
Jean-Pierre

I have made some progress but getting stuck again further down the line...

I have customised the orange box and can do the autocomplete and resource discovery
I have also modified the "default" profile and I can see in the console that the query is made and results returned as xml.

Still hovering over the default node returns a message saying "no endpoint has been configured"...
Is my profile definition incomplete?
thanks in advance for any hint.
jean-Pierre

I still have "no endpoint configured for that resource" but thing have been moving forward.
2 comments:

the example profile should include the declaration of the endpointType so that data is correctly returned in Json
the endpointType is not taken into account in lodlive.core.js and in my case all queries were wrongly returning xml from my sesame server

Hello @JPEvain, Did you succeed? I am also trying to use LodLive locally and got the "no endpoint'.


Video Player cannot play youtube URL

Initialize the controller with youtube URL
_controller = VideoPlayerController.network(
      'https://www.youtube.com/watch?v=fhWaJi1Hsfo,
);

The player is unable to play the stream with the following error logs:
E/ExoPlayerImplInternal(14727): com.google.android.exoplayer2.source.UnrecognizedInputFormatException: None of the available extractors (MatroskaExtractor, FragmentedMp4Extractor, Mp4Extractor, Mp3Extractor, AdtsExtractor, Ac3Extractor, TsExtractor, FlvExtractor, OggExtractor, PsExtractor, WavExtractor, AmrExtractor) could read the stream.
E/ExoPlayerImplInternal(14727): 	at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractorHolder.selectExtractor(ExtractorMediaPeriod.java:931)
E/ExoPlayerImplInternal(14727): 	at com.google.android.exoplayer2.source.ExtractorMediaPeriod$ExtractingLoadable.load(ExtractorMediaPeriod.java:853)
E/ExoPlayerImplInternal(14727): 	at com.google.android.exoplayer2.upstream.Loader$LoadTask.run(Loader.java:317)
E/ExoPlayerImplInternal(14727): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
E/ExoPlayerImplInternal(14727): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
E/ExoPlayerImplInternal(14727): 	at java.lang.Thread.run(Thread.java:818)

Youtube don't allow to use the link as stream url, there are  techniques to get a stream url from the youtube link on the server or on the device, but I think that is not allowed in they terms of use.
By the way there is a video that can help you: https://www.youtube.com/watch?v=7IG5kRFIMZw
I hope that youtube release an API to show inline videos actually the unique plugin that use the youtube api open the video in full screen.
https://pub.dartlang.org/packages/flutter_youtube

Merging with #13756

how can i stream youtube videos to unity?????


[SR-525] AnyObject unresolved dot expr fails oddly and intermittently

Previous ID
SR-525

Radar
None

Original Reporter
emanuel (JIRA User)

Type
Bug

Environment
Swift version 2.2-dev (LLVM 3ebdbb2c7e, Clang f66c5bb67b, Swift 85231a20ed)
Target: x86_64-apple-macosx10.9

Additional Detail from JIRA

Votes
1

Component/s
Compiler

Labels
Bug, TypeChecker

Assignee
None

Priority
Medium

md5: 8c50fc5d55b963182e98f665a18862a0

relates to:

SR-524 AnyObject unresolved dot expr does not work across files in the same module

Issue Description:
Description:
When refactoring test cases, unresolved dot expr seems as if it's not typechecking properly. Swift reports an error message that doesn't seem to make sense. Sometime the type checking succeeds by including top level expressions that don't appear to affect the statement in question.
Inputs:
Replace swift/validation-test/stdlib/Dictionary.swift with the following content:
// RUN: rm -rf %t
// RUN: mkdir -p %t
//
// RUN: %S/../../utils/gyb %s -o %t/main.swift
// RUN: %target-clang -fobjc-arc %S/Inputs/SlurpFastEnumeration/SlurpFastEnumeration.m -c -o %t/SlurpFastEnumeration.o
// RUN: %S/../../utils/line-directive %t/main.swift -- %target-build-swift %S/Inputs/DictionaryKeyValueTypes.swift %t/main.swift -I %S/Inputs/SlurpFastEnumeration/ -Xlinker %t/SlurpFastEnumeration.o -o %t/Dictionary -Xfrontend -disable-access-control
//
// RUN: %S/../../utils/line-directive %t/main.swift -- %target-run %t/Dictionary
// REQUIRES: executable_test

// XFAIL: linux

import StdlibUnittest
import Foundation

var DictionaryTestSuite = TestSuite("Dictionary")

func getCOWSlowDictionary() {
  var d = Dictionary<TestKeyTy, TestValueTy>(minimumCapacity: 10)
}

//DictionaryTestSuite.test("deleteChainCollision") {

//}

//===---
// NSDictionary -> Dictionary bridging tests.
//===---

func getAsNSMutableDictionary(d: Dictionary<Int, Int>) -> NSMutableDictionary {
  let keys = Array(d.keys.map { TestObjCKeyTy($0) })
  let values = Array(d.values.map { TestObjCValueTy($0) })

  return NSMutableDictionary(objects: values, forKeys: keys)
}

func getBridgedVerbatimDictionaryAndNSMutableDictionary()
    -> (Dictionary<NSObject, AnyObject>, NSMutableDictionary) {
  let nsd = getAsNSMutableDictionary([ 10: 1010, 20: 1020, 30: 1030 ])
  return (_convertNSDictionaryToDictionary(nsd), nsd)
}

DictionaryTestSuite.test("BridgedFromObjC.Verbatim.DictionaryIsCopied") {
  var (d, nsd) = getBridgedVerbatimDictionaryAndNSMutableDictionary()

  // Find an existing key.
  do {
    var kv = d[d.indexForKey(TestObjCKeyTy(10))!]
    kv.1.value == 1010
  }
}

runAllTests()

Then run this test case using lit, for example:
../llvm/utils/lit/lit.py -a ../build/Ninja-ReleaseAssert/swift-macosx-x86_64/validation-test-macosx-x86_64/stdlib/Dictionary.swift

It results in the error message:
/swift/swift/validation-test/stdlib/Dictionary.swift:52:16: error: binary operator '==' cannot be applied to operands of type '_' and 'Int'
    kv.1.value == 1010
    ~~~~~~~~~~ ^  ~~~~

where the underscore appears to be a type variable.
Uncommenting the empty delete chain collision test case causes this test case to pass like so:
[ RUN      ] Dictionary.deleteChainCollision
[       OK ] Dictionary.deleteChainCollision
[ RUN      ] Dictionary.BridgedFromObjC.Verbatim.DictionaryIsCopied
[       OK ] Dictionary.BridgedFromObjC.Verbatim.DictionaryIsCopied
Dictionary: All tests passed

This is odd because that statement should have no affect on the typing of other code in the module, but it appears to.
Results while minimizing this example oscillate back and forth between working and not. This is the smallest that I seem to easily be able to make this. Making it smaller still produces a version that consistently fails with the provided error message. Minimizing it even more produces an entirely different error message, which is reported in SR-524.

I cannot reproduce this, and judging by the example, the reason it once errored out is a mystery, to say the least. Closing w/o a regression test because there is little to no value in trying to reduce it to something palatable at this point.


Cant't make OpenCM communicate with sensors via I2C

Hello, @ROBOTIS-Will
I'm Yuya.
I use OpenCM9.04 C Type for my study.
I tried using MPU9250 (IMU sensor) with OpenCM via I2C.
I checked I2C with OpenCM your guide.
But I can't make it communicate with sensors via I2C.
First of all, without the below code, somehow I2C device was found at all addresses even though I connect only one I2C device to OpenCM.
pinmode(24, INPUT_PULLUP)
pinmode(25, INPUT_PULLUP)

If I add the above code, the result is below.

I did some tests to find the causes for this problem.
(1)
I suspected sensor failure for the first time. To check that, I did it with Arduino UNO.
I could make Arduino communicate with a sensor via I2C.

(2)
I suspected  VCC(3.3V) and GND on OpenCM.
This also succeeded.
From (1), and (2), I guessed this problem is related to OpenCM.

If you have any solution to this problem, please teach me.
I would like to I2C device with OpenCM9.04 C Type.
thank you for your attention

Hi @yuya-0411
I can't find any information about your code.
I'd recommend to review the MPU6050 example below and start from there.
https://emanual.robotis.com/docs/en/parts/controller/opencm904/#mpu6050-dmp
I'm sorry but I can't provide technical support for debugging custom libraries or source codes.
Thank you.

@ROBOTIS-Will
Thank you for your rapid response.
I'm sorry. I forgot to explain the code in detail.
I just ran Arduino example "Who Am I" and "I2C check" in order to check I2C communication because I suspected that the problem was related to not Software but Hardware.
Actually, the I2C device worked on Arduino Uno.
I will try what you suggested.
thank you


scheduling  pgbadger every day

PostgreSQL 11.5, pgabdger 11.1
Hello,
I want pgbadger to parse log every day between 8 AM and 18 PM.
I write :
perl.exe pgbadger c:/.../log/postgresql-3.log -I --retention 2 -d activite -b "08:00:00" -e "18:00:00" -O c:/.../pgbadger
It returns :

unrecognized signal name "USR2" at pgabdger line 3932.

What doest it mean ?
Thanks

These are the debugging lines. I noticed an out.html in the pgbadger directory instead of the one specified by -O.

I am a bit confused.

Hi,
Normally USR2 signal is not used on Windows operating system but there is still a call that do not respect this exception. Commit d5558c9 might fix it.
Please use latest development code and let me know if the issue with output dir persist.

It sounds good for USR2. Thanks
But I still can't get the log be parsed between 08:00:00 and 18:00:00 :

only index.html is created when I use the task scheduler :
perl.exe pgbadger C:/"Program Files"/PostgreSQL/11/data/log/postgresql-1.log -I --retention 2 -b "08:00:00" -e "18:00:00" -d activite -O C:/ms4w/Apache/site/pgbadger
perl.exe pgbadger C:/"Program Files"/PostgreSQL/11/data/log/postgresql-2.log -I --retention 2 -b 08:00:00" -e "18:00:00" -d activite -O C:/ms4w/Apache/site/pgbadger
...
I test in cmd line, here what I get and nothing is created :

The problem is that pgBadger port to Windows is broken, it still need to be fixed. I don't have time for the moment but this is a high priority for next release.

Fixed in last development code, a new release is coming.


[RAINCATCH-450] Use simple-store

Motivation
Utilize the new store implementation to allow for in-memory and mongodb storage
Changes

Add fh-wfm-simple-store
Bump mediator to 0.1.0-rc1 version (needs to be changed for release)
Update mocha
Update lib/user/store.js to delegate to simple-store
Update unit tests to target simple-store

Looks good 👍


fix: top to bottom (system first) changelog parameters search

Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This PR fixes regression introduced in #4267 and #2656 making it possible to inherit local properties from included changelogs while keeping "first wins" behavior for property definitions. Property search starts from system then global properties and continues for local properties from root changelog down to the current.

Things to be aware of

Things to worry about
Although it is considered as non-breaking change some expectations might be violated:
starting from v4.23.0 (#4267) local parameters behavior was changed to "last wins" making it possible to "inherit" properties in included changesets by assigning the same logicalFilePath for changesets.
This is no longer possible since properties in same logicalFilePath can't be changed once been set.
In order to inherit local properties they should be defined in distinct changesets as shown in the test changes.
cc @airon-assustadus

Additional Context
Some details provided in https://github.com/liquibase/liquibase/pull/4267#issuecomment-2380604946

PR adjusted according to the latest ChangeLogParameters changes


HTLC - the HTLC list isn't updated after creating a new HTLC #2886

https://github.com/bitshares/bitshares-ui/issues/2886

Same issue for Direct Debit component. And your new Prediction Market will have the same problem.


[github-actions] break up the 'build' and 'simulation' workflows

This commit breaks up the build and simulation github-actions
workflows into multiple separate smaller workflows. This allows re-run
of a smaller set of builds/tests in case of random/spurious failures.

I am putting this on hold for now (monitoring how often different workflow builds fail and need re-kick).

I am putting this on hold for now (monitoring how often different workflow builds fail and need re-kick).

The chance each workflow might fail varies over time? So it's less meaningful to divide workflows by fail chance, but more meaningful to divide by testing area?


chore: improve generators and presets

Description
Improve generators and presets:

render optional properties in TS class and interface,
improve typings in AbstractRenderer and AbstractGenerator,
add additionalContent preset to class, interface, enum renderers,
improve defaultSelf method in renderers,
move helpers method from Java enum to default preset.

Related issue(s)
See also https://github.com/asyncapi/generator-model-sdk/issues/50

@jonaslagoni Thanks for review! Could you accept again? I fixed linter warnings related only to changed files in PR.


Optional Options (part II)

Fixes #8.
Currently, ts-rs translates foo: Option<T> to foo: T | null in TypeScript, but a common pattern is to use #[serde(skip_serializing_if="Option::is_none")] for types that are represented in TypeScript like this: foo?: T. By implementing it this way, the types match how Serde actually serializes JSON. By default, a None is serialized as null, whereas this annotation also instructs the serializer to omit the property entirely.
(I have recreated this PR so it doesn't include commits from other PRs)

great work, thanks!


Traceback error?

Hi I've never had any issues with the bot however this is the first error I have faced after typing python hq_main.py this is what came back as an error
Traceback (most recent call last):
File "hq_main.py", line 49, in
raise RuntimeError("Connection settings invalid")
RuntimeError: Connection settings invalid
I don't know if any of you have had any similar issues but if there is a way to fix it please comment below and if you have no idea can you please give me a step by step instruction on how to uninstall and reinstall everything, thanks!

I would check your bearer token again and make sure its valid, they expire after 3 months

you can check it here https://jwt.io/

Thank you I believe that was the issue I used a bearer token I found here not really sure how to create one myself


Drop everything but awssqs

Fixes knative/community#232
Proposed Changes

Drop everything but the awssqs bits
Move eventing-contrib/awssqs to eventing-awssqs

/lgtm
Thanks!


running alvr_launcher does nothing on kubuntu 21.04

After building from source, launching alvr_launcher in the build/alvr_server_linux/bin/ folder simply does nothing. Not even an error code is returned...
I have reproduced this issue on release 15.2.1 and on this commit
According to the wiki the Linux build should be working on Ubuntu 20.04.
I have Kubuntu 21.04
Any idea how i could debug this ?
$ ./alvr_launcher # does absolutely nothing
$ echo $? # prints 0

Besides unused functions and imports warnings i only had this one thing
warning: In file included from src/bindings.cpp:1:
warning: src/openvr_driver_capi.h: In member function ‘virtual void DriverDirectModeComponent::GetNextSwapTextureSetIndex(vr::SharedTextureHandle_t*, uint32_t (*)[2])’:
warning: src/openvr_driver_capi.h:172:67: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
warning:   172 |             callbacks.context, (const SharedTextureHandle_t(&)[2])sharedTextureHandles, pIndices);
warning:       |                                                                   ^~~~~~~~~~~~~~~~~~~~
warning: src/openvr_driver_capi.h:73:9: note: in definition of macro ‘CLASS_C_INTERFACE’
warning:    73 |         interface;                                                          \
warning:       |         ^~~~~~~~~

Also I did try to build with and without the  --release flag. And I have already started SteamVR several times

Hi! You can try ss -elx | grep alvr to see if there's an alvr_launcher_mutex sticking around from a launcher crash. You can reboot your system or use rg(1) to change the instance where it's defined .

Thinking a bit more about this, it'd be nice if we had a message instead of silently exiting if this is, in fact, what my last comment theorized it is.

Same issue here, pretty sure it's not about locked mutex. After I commented out this block of code a window appeared. Then
lee@hp ~/A/t/debug (master) [SIGINT]> ./alvr_launcher
DEBUG [ureq::stream] connecting to <IP_ADDRESS>:8082 at <IP_ADDRESS>:8082
ERROR [alvr_common::logging] failed to get alvr dir from /home/lee/ALVR/target/debug/alvr_launcher compared to bin/alvr_launcher, path do not match
DEBUG [druid::localization] available locales [], current en-US
DEBUG [druid::localization] resolved: [en-US]
INFO  [druid_shell::platform::gtk::application] gtk: Activated application
DEBUG [ureq::stream] connecting to <IP_ADDRESS>:8082 at <IP_ADDRESS>:8082
DEBUG [ureq::stream] connecting to <IP_ADDRESS>:8082 at <IP_ADDRESS>:8082
DEBUG [ureq::stream] connecting to <IP_ADDRESS>:8082 at <IP_ADDRESS>:8082
DEBUG [ureq::stream] connecting to <IP_ADDRESS>:8082 at <IP_ADDRESS>:8082

@chutaklee You need to compile with cargo xtask build-server --release and run the binary in the build folder, not target.

@chutaklee You need to compile with cargo xtask build-server --release and run the binary in the build folder, not target.

Thanks that works!


[WIP] Fix resize error

@dansbecker I at least figured out what the issue is. Basically, in some of the random croppings, laplace distribution parameters end up giving us a random bounding box who's center is outside of the original image dimensions. This ends up leading to issues in terms of x0 being greater than x1, or similar issues for y0 and y1.
I've done my best to comment out the print statements that aren't currently relevant, and only include those that might demonstrate the problem. To that end, you should be able to run the generator from the main folder... python motion_tracker/utils/image_generator.py, at which point it will continue to run until a resizing error occurs. At that point, there'll be something like the output below:
--------------------------------------------------
(306, 500, 3) # Original Image size
0.10169054980587121 1.827571594469031 1.02451916969 0.948835020232 # laplace param results
Box for crop center x: 465.5
Box for crop center y: 507.0
Box_after_crop: 24, 0, 77, -60

I've commented the first two lines - original image size and the laplace param results. Then, after words I've shown the x/y centers for the randomly cropped box. As you can see, both centers are larger than the original image size (although this isn't always the case - sometimes when it breaks it's just one).
I think the easy solution here is to put some kind of test in here that makes sure the centers are not greater than the image size, and the redoes a random cropping if that happens. So, basically some kind of while loop. Now, this assumes that this is the only error causing this (which, when I ran this 5-10 times, was the only thing I could see causing this).
So, I'll plan on doing that Friday I think. I've got a plane flight that I could use some work to do.

Nice job!  I hadn't thought about that issue.  Were you thinking of catching that and adding the while loop in image_cropping or in the generator?
I assume you are thinking of doing it in image_cropping. Let me know if that's not right.
Handling this in a while loop sounds great to me.

Thanks! Just glad it's figured out. I had a hunch it might be something that was happening with the laplace parameters since it happened so infrequently, but didn't imagine that this would be the end issue.
Yeah, I was planning on doing this in a while loop in image_cropping. I'll plan on putting that together sometime this week. 👍


Failed to compile application because of pub.dev/r_scan-0.1.6+1/lib/src/r_scan_view.dart:38:18: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.

When trying to compile I receive this message:
_/C:/Users/thoma/AppData/Local/Pub/Cache/hosted/pub.dev/r_scan-0.1.6+1/lib/src/r_scan_view.dart:38:18: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.
SystemChrome.setEnabledSystemUIOverlays([SystemUiOverlay.top]);
^^^^^^^^^^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception
FAILURE: Build failed with an exception.

Where:
Script 'C:\Software\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 1159

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command 'C:\Software\flutter\bin\flutter.bat'' finished with non-zero exit value 1

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org/

BUILD FAILED in 2m 19s
Exception: Gradle task assembleDebug failed with exit code 1_
Flutter doctor says:
Flutter (Channel stable, 3.10.0, on Microsoft Windows [Version 10.0.22621.1702], locale en-DE)
• Flutter version 3.10.0 on channel stable at C:\Software\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 84a1e904f4 (4 days ago), 2023-05-09 07:41:44 -0700
• Engine revision d44b5a94c9
• Dart version 3.0.0
• DevTools version 2.23.1

I checked the Internet and found
_https://stackoverflow.com/questions/69326384/setenabledsystemuioverlays-is-deprecated-and-shouldnt-be-used-migrate-to-seten_
Hence I changed initState() in r_scan_view.dart

delete SystemChrome.setEnabledSystemUIOverlays([SystemUiOverlay.top])
insert SystemChrome.setEnabledSystemUIMode(SystemUiMode.manual, overlays: [SystemUiOverlay.top]);

same issue.


Add quiet option to migrations

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
#13853

Also refactors the echos in db/Migration.php into helper functions.

This quiet switch still will result quite a lot of output from migrations...

The result will be 3 lines per migration file. My goal is 1 line per file, which I proposed in the linked issue but cebe suggested I omit that change for now. I can make that change if there's some agreement :)

The result will be 3 lines per migration file. My goal is 1 line per file

It does not change main issue - quiet switch does not make command quiet. We should either suppress all output or introduce verbose switch with some levels.

Well, technically, this does make Migration quiet, it's the controller that's still making all the noise :P
But yeah I get what you're saying, but I'm not too sure what benefit there is to hiding all the output. It's pretty important to see what's going on with migrations I think. There's always the ability to pipe the output to /dev/null if you really want to see nothing.
My particular use-case is that the initial migration I have in my project inserts a lot of binary data into the db, so there's just a massive stream of garbage flying past the console when I run it. Plus, there's just a lot of commands being run, so the new maxSqlOutput option isn't enough for me. My project is installed on-prem by my customers, so I just want a nicer experience for them.
Anyways, I think the mode I implemented could be quiet = 1, and 2 could be trimming the migration controller output to one line per migration, 3 could be just removing all of the per-file output... something like that.

I would keep in mind issue #12862 here as well.
It is crucial to have an ability not just disable migration output, but actually redirecting it to another source.
For example storing output lines in array, so they can be displayed later at web page or something.

It would be better to have migration output actuall come through the View component.
It make sense to introduce base print() method to yii\base\View so any view (yii\console\View and yii\web\View) should have it.
Migration should pass its output via this method through the View related to migration runner (at the present state - MigrateController).
In order supress output a dummy view can be used, or there could be a View, which calls Yii::$logeer->log() instead of output and so on.

Hmm, those suggestions sound more complicated than I have time to work on. Feel free to take over if you want to do those things.
Is there any specific reasons for not merging this now and making those changes in a new PR? They seem a bit larger scope than what I did here.

It is crucial to have an ability not just disable migration output, but actually redirecting it to another source.

this is out of scope in this PR, and can be added later if needed.

This quiet switch still will result quite a lot of output from migrations...

@rob006 @yiisoft/core-developers how about naming it quieter or something similar to keep the possibilty to add a more general quiet option to console controllers later? Migration::$quiet is okay imo, as it supresses all migration output.

I'm for verbose option for command, like --verbose=3. Using --verbose=0 will suppress all output of command.

Migration::$quiet is okay imo, as it supresses all migration output.

I agree.

After reconsidering: ---muteSql or --quietSql switch will be simpler to use and more descriptive than verbose option and less magical than quieter.

Migrate command has an implementations for NOSQL databases, so not sql part can be used for option name.

brain storm: --lessDetail --fewerDetails --compact --compactInfo --compactOutput

--compact looks like a nice option name.

compact sounds good to me, should I make the change?

Yes.

I had -q for --quiet. Should we use -c for --compact or just not have an alias?

Also, anything I should do to make codeclimate not fail?

no, its okay.

Merged. Thank you!


Add LLaVA Support

Introduction
This implementation is based on my work for candle. However, it incorporates some notable differences:

I have completely removed support for the model format used in the liuhaotian/llava (original) repo. Instead, I adopted the model format from the llava-hf repo, providing a more standardized approach to utilizing the model, particularly the tokenizer.
Similar to the Python transformer library, I have segmented the original project into LLaVA (1.5) and LLaVANext (1.6). This reduction in the use of if-else statements simplifies the code.
I have revamped the process of concatenating text and image features. The updated method aligns closely with phi3v's implementation in this repo, ensuring a more uniform coding style.

Still Working!
Some Notes

The fused RoPE might cause issues, possibly due to precision-related matters. Please refer to this https://github.com/EricLBuehler/mistral.rs/issues/465. Therefore, I have implemented an alternative version in the llava-llm folder.
Certain modifications regarding cross-GPU mapping support [link] might result in significant memory usage problems.

Status

[x] Implement model

[x] LLaVANext (1.6)
[x] LLaVA 1.5

[x] Input processor
[x] Model structure

[x] Support for different LLM Backends

[x] LLaMA-like models (vicuna, Nous-Hermes-2-Yi-34B)
[x] Mistral

[x] Cleanup of some debug code
[x] Documentation
[x] Examples

Hi @chenwanqq! Please let me know when this is ready for review.

Hi @chenwanqq! Please let me know when this is ready for review.

Hhh I think it's ready. Maybe some docs and examples are a little bit hurry but I think we can review it🤣

Great, I'll take a look. I think that the recent merge of #476 caused some merge conflicts here, can you please take a look?

Great, I'll take a look. I think that the recent merge of #476 caused some merge conflicts here, can you please take a look?
Edit: Seems like they are trivial to fix.

The addition of AnyMOE (which modifies the dependencies of NormalModel) affects the LLaVA llm backend. However, the current solution based on copied code is just a temporary one, so I have removed the NormalModel trait from LLaVALLM altogether. Once the fusedRoPE is fixed, we should change LLaVA to rely on an ordinary model as soon as possible.

And LLaVANext is just LLaVA1.5 plus some multiple resolution trick(anyres). So they share some infrastuctres. If this causes any confusion, we can modify it.

Seem quite a lot for me to check!🧐 I will see it later, and just to explain something that:
(1) As I mentioned, I did not use the original image tag processing logic of llava, but instead adopted a processing logic similar to phi3v. This is due to compatibility considerations with the input of this repo. For example, the original logic of llava does not calculate num_img_tokens before encode_image, etc.; Additionally, phi3v's logic is better for handling multiple images. Since  in llava is just a placeholder, if we set up the chat_template correctly (the same as the backend llm), the effects of the two implementations will be the same. I think we should add some special notifications?
(2) llava supports multiple images, but this is only practically meaningful in version 1.5. In version 1.6, the introduction of multi-resolution processing has led to longer feature representations for each image, but the context length is only 4K, so multiple images will be truncated.
(3) Yes, it is only the rope problem that I copy the code of LLM.

Seem quite a lot for me to check!🧐 I will see it later, and just to explain something that:
(1) As I mentioned, I did not use the original image tag processing logic of llava, but instead adopted a processing logic similar to phi3v. This is due to compatibility considerations with the input of this repo. For example, the original logic of llava does not calculate num_img_tokens before encode_image, etc.; Additionally, phi3v's logic is better for handling multiple images. Since  in llava is just a placeholder, if we set up the chat_template correctly (the same as the backend llm), the effects of the two implementations will be the same. I think we should add some special notifications?
(2) llava supports multiple images, but this is only practically meaningful in version 1.5. In version 1.6, the introduction of multi-resolution processing has led to longer feature representations for each image, but the context length is only 4K, so multiple images will be truncated.

As I mentioned, I did not use the original image tag processing logic of llava, but instead adopted a processing logic similar to phi3v. This is due to compatibility considerations with the input of this repo. For example, the original logic of llava does not calculate num_img_tokens before encode_image, etc.; Additionally, phi3v's logic is better for handling multiple images. Since  in llava is just a placeholder, if we set up the chat_template correctly (the same as the backend llm), the effects of the two implementations will be the same. I think we should add some special notifications?

I see. I think we should use the Llava <image> token to avoid confusion, regardless that it is a placeholder. Should be an easy change, most of the comments I made are about that.

) llava supports multiple images, but this is only practically meaningful in version 1.5. In version 1.6, the introduction of multi-resolution processing has led to longer feature representations for each image, but the context length is only 4K, so multiple images will be truncated.

That makes sense. Given that we support multiple images, if we could document that it would be great! 😃

I've fix the image tag problem and anymoe problem accordingly. May we can have more review?

Hi @chenwanqq! I made some edits for some small updates to the model support matrix and model architecture docs.
This looks good, but it crashes when I run:
cargo run --release --features cuda -- --port 1234 --isq Q4K vision-plain -m llava-hf/llava-v1.6-mistral-7b-hf -a llava_next

And
python3 examples/server/llava_next.py

With
prompt step - Model failed with error: WithBacktrace { inner: DeviceMismatchBinaryOp { lhs: Cuda { gpu_id: 0 }, rhs: Cpu, op: "conv2d" }, backtrace: Backtrace [{ fn: "candle_core::error::Error::bt" }, { fn: "candle_core::storage::Storage::same_device" }, { fn: "candle_core::storage::Storage::conv2d" }, { fn: "candle_core::conv::<impl candle_core::tensor::Tensor>::conv2d_single_group" }, { fn: "candle_core::conv::<impl candle_core::tensor::Tensor>::conv2d" }, { fn: "<candle_nn::conv::Conv2d as candle_core::Module>::forward" }, { fn: "<mistralrs_core::vision_models::clip::ClipVisionEmbeddings as candle_core::Module>::forward" }, { fn: "mistralrs_core::vision_models::clip::ClipVisionTransformer::forward_get_hidden_states" }, { fn: "mistralrs_core::vision_models::llava::llava_next::Model::encode_images" }, { fn: "<mistralrs_core::vision_models::llava::llava_next::Model as mistralrs_core::pipeline::VisionModel>::forward" }, { fn: "<mistralrs_core::pipeline::vision::VisionPipeline as mistralrs_core::pipeline::Pipeline>::forward_inputs" }, { fn: "mistralrs_core::pipeline::Pipeline::step::{{closure}}" }, { fn: "mistralrs_core::engine::Engine::run::{{closure}}" }, { fn: "tokio::runtime::runtime::Runtime::block_on" }, { fn: "std::sys_common::backtrace::__rust_begin_short_backtrace" }, { fn: "core::ops::function::FnOnce::call_once{{vtable.shim}}" }, { fn: "std::sys::pal::unix::thread::Thread::new::thread_start" }, { fn: "start_thread", file: "./nptl/pthread_create.c", line: 442 }, { fn: "__GI___clone3", file: "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S", line: 81 }] }

It seems to come from the CLIP embeddings. Note that for ISQ models, the VBs are on the CPU and are cast using mapper.set_nm_device. Pass loading_isq as false if this is not going to be touched by ISQ, and otherwise, be sure to pass the correct parameter from the normal loading metadata.
I would reccomend that you check out the Idefics 2 model, as I do .set_device(text_model.device().clone()) several times, which will set it to the primary device. This may be what you want. Please let me know if you have any questions!
When I run without ISQ, it successfully produces the correct output though - great work here!

Hi @chenwanqq! I made some edits for some small updates to the model support matrix and model architecture docs.
This looks good, but it crashes when I run:
cargo run --release --features cuda -- --port 1234 --isq Q4K vision-plain -m llava-hf/llava-v1.6-mistral-7b-hf -a llava_next

And
python3 examples/server/llava_next.py

With
prompt step - Model failed with error: WithBacktrace { inner: DeviceMismatchBinaryOp { lhs: Cuda { gpu_id: 0 }, rhs: Cpu, op: "conv2d" }, backtrace: Backtrace [{ fn: "candle_core::error::Error::bt" }, { fn: "candle_core::storage::Storage::same_device" }, { fn: "candle_core::storage::Storage::conv2d" }, { fn: "candle_core::conv::<impl candle_core::tensor::Tensor>::conv2d_single_group" }, { fn: "candle_core::conv::<impl candle_core::tensor::Tensor>::conv2d" }, { fn: "<candle_nn::conv::Conv2d as candle_core::Module>::forward" }, { fn: "<mistralrs_core::vision_models::clip::ClipVisionEmbeddings as candle_core::Module>::forward" }, { fn: "mistralrs_core::vision_models::clip::ClipVisionTransformer::forward_get_hidden_states" }, { fn: "mistralrs_core::vision_models::llava::llava_next::Model::encode_images" }, { fn: "<mistralrs_core::vision_models::llava::llava_next::Model as mistralrs_core::pipeline::VisionModel>::forward" }, { fn: "<mistralrs_core::pipeline::vision::VisionPipeline as mistralrs_core::pipeline::Pipeline>::forward_inputs" }, { fn: "mistralrs_core::pipeline::Pipeline::step::{{closure}}" }, { fn: "mistralrs_core::engine::Engine::run::{{closure}}" }, { fn: "tokio::runtime::runtime::Runtime::block_on" }, { fn: "std::sys_common::backtrace::__rust_begin_short_backtrace" }, { fn: "core::ops::function::FnOnce::call_once{{vtable.shim}}" }, { fn: "std::sys::pal::unix::thread::Thread::new::thread_start" }, { fn: "start_thread", file: "./nptl/pthread_create.c", line: 442 }, { fn: "__GI___clone3", file: "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S", line: 81 }] }

It seems to come from the CLIP embeddings. Note that for ISQ models, the VBs are on the CPU and are cast using mapper.set_nm_device. Pass loading_isq as false if this is not going to be touched by ISQ, and otherwise, be sure to pass the correct parameter from the normal loading metadata.
I would reccomend that you check out the Idefics 2 model, as I do .set_device(text_model.device().clone()) several times, which will set it to the primary device. This may be what you want. Please let me know if you have any questions!
When I run without ISQ, it successfully produces the correct output though - great work here!

That's exactly the problem! With the new commit, I believe I fixed it (tested in llava-v1.6-vicuna-7b-hf, llava-v1.6-mistral-7b-hf, and llava-1.5-7b-hf). However, when I deal with llama-like models (such as Vicuna), there is a device mismatch problem with rmsnorm:
prompt step - Model failed with error: DeviceMismatchBinaryOp { lhs: Cuda { gpu_id: 0 }, rhs: Cpu, op: "rms-norm" }
^C

When I checked the code, I found that the Llama and Mistral code have slight differences in initialization:
https://github.com/EricLBuehler/mistral.rs/blob/c8b71e9b5894b4f43c58ab600a5144a70d52a4b1/mistralrs-core/src/models/llama.rs#L291-L299
https://github.com/EricLBuehler/mistral.rs/blob/c8b71e9b5894b4f43c58ab600a5144a70d52a4b1/mistralrs-core/src/models/mistral.rs#L288-L296
I change it as Mistral way in my copied version of backend llama llm. I don't have Llama weights right now (and it's not very easy for me to download them). I think maybe you can check if the Llama text model has this issue.


About coarse genneration and fine genneration in the paper

Hi I tried to use this code for a domain adaptation study on a polyp dataset, but ran into some problems.
I followed the suggestion in the paper to use the source domain model to convert the noise to a coarse genneration of the source-like style. Then I used the coarse genneration and the target domain image to perform a Fourier transform to obtain the fine genneration.
However, the generated coarse generation is still noisy and there is still a significant difference between the style of the generated fine generation and the actual target domain.
I would like to know if it is normal to have such coarse generation, and fine generation?

You can try to initialize the input noise with original target data. It will be much easier to convergence.

Thank you for your answer！


Check whether the task finishes before deferring the task for RedshiftDataOperatorAsync

Like the SnowflakeOperatorAsync, we try to verify if the submitted job has already completed before deferring it to prevent unnecessary deferring. This way, we can skip deferring the task if it has already been finished.


ECR on AWS is using GitHub Container Registry to store images

Which version of kubefirst are you using?
2.3+
Which cloud provider?
AWS
Which DNS?
None specific
Which installation type?
None specific
Which distributed Git provider?
None specific
Which Operating System?
None specific
What is the issue?
ECR on AWS is using GitHub Container Registry (GCR) to store images which means that further in the process, when kubefirst is trying to retrieve images on ECR, they are not there; they are in GCR.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have reached the same conclusion (the long way around)...


hash_join panics when join keys have different data types

Describe the bug
There are several places where hash_join can panic in version 9.0.0 when I run SQL queries.
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', /home/andy/.cargo/registry/src/github.com-1ecc6299db9ec823/datafusion-9.0.0/src/physical_plan/hash_join.rs:973:17
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', /home/andy/.cargo/registry/src/github.com-1ecc6299db9ec823/datafusion-9.0.0/src/physical_plan/hash_join.rs:979:17
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', /home/andy/.cargo/registry/src/github.com-1ecc6299db9ec823/datafusion-9.0.0/src/physical_plan/hash_join.rs:1045:17

To Reproduce
I am experimenting with SQL query fuzzing. Here is one query that failed:
SELECT _c438, _c439, _c440, _c441, _c442, _c443
FROM (
  (
    (SELECT test1.c0 AS _c438, test1.c1 AS _c439, test1.c2 AS _c440, test1.c3 AS _c441, test1.c4 AS _c442, test1.c5 AS _c443
      FROM (test1))
    FULL JOIN
    (SELECT test1.c0 AS _c444, test1.c1 AS _c445, test1.c2 AS _c446, test1.c3 AS _c447, test1.c4 AS _c448, test1.c5 AS _c449
      FROM (test1))
    ON _c438 = _c446)
  RIGHT JOIN
  (SELECT test0.c0 AS _c450, test0.c1 AS _c451, test0.c2 AS _c452, test0.c3 AS _c453, test0.c4 AS _c454, test0.c5 AS _c455
    FROM (test0))
  ON _c441 = _c451);

ArrowError(ExternalError("Arrow error: External error: Execution error: Join Error: task 5672 panicked"))

Data files are here - https://github.com/andygrove/sqlfuzz/tree/main/testdata
Expected behavior
Should not panic
Additional context

@andygrove I'd like to investigate this as part of #2910

Rev engineered data from sqlfuzz, quick test to reproduce the behavior
#[tokio::test]
    async fn hj_non_compat() -> Result<()> {
        let schema = Arc::new(Schema::new(vec![
            arrow::datatypes::Field::new(
            "column_1",
            DataType::Int32,
            false,
        ),
        arrow::datatypes::Field::new(
            "column_2",
            DataType::Int8,
            false,
        )

        ]));

        let data = RecordBatch::try_new(
            schema.clone(),
            vec![
                Arc::new(arrow::array::Int32Array::from(vec![
                    Some(1),
                ])),
                Arc::new(arrow::array::Int8Array::from(vec![
                    Some(1),
                ])),
            ],
        )?;

        let table = crate::datasource::MemTable::try_new(schema, vec![vec![data]])?;

        let ctx = SessionContext::new();
        ctx.register_table("test", Arc::new(table))?;

        let sql = r#"
        SELECT
            *
        FROM
            test a right join test b on a.column_1 = b.column_2"#;

        let df = ctx.sql(sql).await.unwrap();
        df.show_limit(10).await.unwrap();

        Ok(())
    }

Right, the problem is non compat downcast


Typo on flutter website

I'm sorry if that's not where to write for those issue, but I have no idea where to go for it.
There is a type in this page where involved is spelled invovled. Where can I write to signal it?

https://flutter.dev/multi-platform/desktop

/cc @csells


x/build: show, extend buildlet expirations with gomote

gomote should show you the lifetime of your buildlets, and let you renew them. Maybe any action implicitly renews them. Or maybe there's a "renew" command.
/cc @adg

This happened at some point:
bradfitz@go:~/go/src$ gomote list
user-bradfitz-linux-amd64-0     linux-amd64     host-linux-stretch      expires in 29m48.559613598s
bradfitz@go:~/go/src$ gomote list
user-bradfitz-linux-amd64-0     linux-amd64     host-linux-stretch      expires in 29m47.545819392s
bradfitz@go:~/go/src$ gomote ping user-bradfitz-linux-amd64-0
bradfitz@go:~/go/src$ gomote list
user-bradfitz-linux-amd64-0     linux-amd64     host-linux-stretch      expires in 29m59.1963596s


Sync our changes

We found a few bugs and fixed them. So did you. Let's sync!

Looks really nice! The modifying existing user is a nice addition :)
Saw that you added a commit earlier today, is there anything more you'd like to add?

This is now ready to go from my side.


server-icon.png does not show up in 1.13 client when selecting servers

What is the output link of /viaversion dump?
https://dump.viaversion.com/573219c69a5ea7638b42e73fe2add5828826e855bc8ef5450a6cb2200ffd752f
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
no bungeecord but using essentialsX and multiversecore
How does this error happen? login? Using an item?
when viewing servers in the Play Multiplayer screen in 1.13, instead of showing the server-icon.png image (which 1.12.2 clients see) the default server icon image is used.
Is there an error in the console? Use pastebin.com. Is there a kick message?
no, user has not connected yet

It's a minecraft bug, seems like the favicon in 1.12.2 are encoded to base64 with \n (new line character), and in 1.13 they are encoded properly, without \n.
It can be fixed in ViaVersion (https://github.com/yzimroni/ViaVersion/commit/20128a2309a8396da8d17553b5391ac962ce2726), the question is whether we want to fix it in ViaVersion or let mojang fix it, since its a minecraft bug.


How to change num_segments?

hello,I want to set num_segments to 16,I have  tried to change
args.num_segments=16,but it's wrong.Can you tell me what should I do?
and the base_model include one segments(input one  frame ) or four segment network?
thank you very much

Hi @shajie17 ,
Could you please show me the error log info?

@zhang-can sorry,I havn't log info,but
Traceback (most recent call last):
File "/home/shajie/PycharmProjects/ECO-pytorch/main.py", line 339, in
main()
File "/home/shajie/PycharmProjects/ECO-pytorch/main.py", line 139, in main
train(train_loader, model, criterion, optimizer, epoch)
File "/home/shajie/PycharmProjects/ECO-pytorch/main.py", line 185, in train
output = model(input_var)
File "/home/shajie/.local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/shajie/.local/lib/python2.7/site-packages/torch/nn/parallel/data_parallel.py", line 112, in forward
return self.module(*inputs[0], **kwargs[0])
File "/home/shajie/.local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/shajie/PycharmProjects/ECO-pytorch/models.py", line 324, in forward
base_out = self.new_fc(base_out)
File "/home/shajie/.local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 491, in call
result = self.forward(*input, **kwargs)
File "/home/shajie/.local/lib/python2.7/site-packages/torch/nn/modules/linear.py", line 55, in forward
return F.linear(input, self.weight, self.bias)
File "/home/shajie/.local/lib/python2.7/site-packages/torch/nn/functional.py", line 992, in linear
return torch.addmm(bias, input, weight.t())
RuntimeError: size mismatch, m1: [1 x 2048], m2: [512 x 101] at /pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:249
it's ok?

Hi @shajie17 ,
Please use our latest code, this can solve your problem:
https://github.com/mzolfaghari/ECO-pytorch


Leaving and rejoining does not re-grant the Linked role

If you leave, and then rejoin M.O.S.S., you do not receive the Linked role again.
This has a couple of issues with it:

You can't run link again, as it says you're already linked.
You cannot unlink your account to re-link it again.

Proposing easy fix: Ban all users who leave so we can't have this problem happen again! 🤣


[BUG]: AzureKeyVaultV2 randomly hangs while downloading secrets

Task name
AzureKeyVaultV2
Task version
2.223.0
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Ubuntu 22.04.2
Task log
2023-07-10T16:00:55.3185361Z ==============================================================================
2023-07-10T16:00:55.3185527Z Task         : Azure Key Vault
2023-07-10T16:00:55.3185608Z Description  : Download Azure Key Vault secrets
2023-07-10T16:00:55.3185707Z Version      : 2.223.0
2023-07-10T16:00:55.3185797Z Author       : Microsoft Corporation
2023-07-10T16:00:55.3185885Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-key-vault
2023-07-10T16:00:55.3186020Z ==============================================================================
.
.
.
2023-07-10T16:18:05.9938048Z ##[debug]Encountered a retriable error:ECONNRESET. Message: read ECONNRESET.
2023-07-10T16:18:07.9964752Z ##[debug][GET]https://REDACTED.vault.azure.net/secrets/REDACTED-password?api-version=2016-10-01
2023-07-10T16:20:08.8821278Z ##[debug]Encountered a retriable error:ECONNRESET. Message: read ECONNRESET.
2023-07-10T16:20:14.8875695Z ##[debug][GET]https://REDACTED.vault.azure.net/secrets/REDACTED-password?api-version=2016-10-01

Relevant log output
##[debug]Encountered a retriable error:ECONNRESET. Message: read ECONNRESET.

Aditional info
Issue seems to have started at the beginning of July 2023. Typically this task is able to download an entire key vault (~100 secrets) in under 10 seconds. Currently, the task will randomly take up to an hour to succeed, after several automatic retries. Running with debug tracing shows the `ECONNRESET` errors above. The Azure agent is Microsoft-hosted, and various key vaults have been attempted, reproducing the same issue.

It appears that the `AzureKeyVaultV2` task is using an older API, as it references `2016-10-01` instead of `7.4` as documented [here](https://learn.microsoft.com/en-us/rest/api/keyvault/secrets/get-secret/get-secret?tabs=HTTP).

Closing ticket: Microsoft has resolved the connectivity issue between the MS-hosted agents and Azure Key Vault. Updating the Key Vault API version was not necessary, but can be reconsidered if it becomes obsolete later.


syshud: 0-unstable-2024-11-04 -> 0-unstable-2024-11-12

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for syshud is: simple heads up display written in gtkmm 4
meta.homepage for syshud is: https://github.com/System64fumo/syshud
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0-unstable-2024-11-12 in filename of file in /nix/store/p8fma65nja73jn4f2sh05wp463rf4mav-syshud-0-unstable-2024-11-12

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

syshud

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p8fma65nja73jn4f2sh05wp463rf4mav-syshud-0-unstable-2024-11-12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A syshud https://github.com/r-ryantm/nixpkgs/archive/88a3df2ded6091ce91c717ae1c32d903f627d71d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/88a3df2ded6091ce91c717ae1c32d903f627d71d#syshud

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p8fma65nja73jn4f2sh05wp463rf4mav-syshud-0-unstable-2024-11-12
ls -la /nix/store/p8fma65nja73jn4f2sh05wp463rf4mav-syshud-0-unstable-2024-11-12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

syshud

Maintainer pings
cc @uninsane for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Distinguish between GCC optimization options for x86 and PowerPC [march-native-dev]

Switch between -march=native  (x86) and -mcpu=native -mtune=native (PowerPC) based on uname -m.
Resolves issue #216.

This looks good to me, thanks!


Support parsing messages with key-value strings such as queries and properties

Data Prepper should have a processor which can parse key-value strings from one field and save the results into another field as a map.
For example, on the input event:
{
  "query": "key1:value1&key2:value2&key3:value3"
}

Could update the event to include a field:
{
  "query_params" : {
    "key1" : "value1",
    "key2" : "value2",
    "key3" : "value3"
  }
}

This processor must allow configuration of:

The source field (query in the example above)
The destination field (query_params in the example above)
The delimiter between fields (& in the example above)
The delimiter between key and value (: in the example above)
non_match value - default null, the value to assign a key when it has no match
prefix - A prefix to all keys. default "".

It should also support regex expressions for both types of delimiters.

I searched GitHub for Logstash configuration files that use the kv filter. There were roughly 545 instances found. The most popular configuration options were:

source
field_split
prefix
target
value_split
field_split_pattern

Less popular configuration options were:

tag_on_failure
trim_key
trim_value
include_keys
remove_char_key
recursive
remove_char_value
allow_duplicate_values
exclude_keys
include_brackets
transform_key
whitespace
default_keys
tag_on_timeout
timeout_millis
ecs_compatibility
value_split_pattern

I plan to implement the following existing configuration options:

source

The default value would be message, any non-null string would be allowed

target (I refer to it as destination)

The default value would be parsed_message, any non-null string would be allowed

field_split_pattern (I refer to it as field_delimiter_regex)

The default value would be &, any non-null regex string would be allowed

value_split_pattern (I refer to it as key_value_delimiter_regex)

The default value would be :, any non-null regex string would be allowed

allow_duplicate_values

The default value would be true, any boolean would be allowed

prefix

The default value would be an empty string, any non-null string would be allowed

I also plan on implementing a configuration option called non_match_value, which defines the value to be used when a key/value split fails.

The default value would be null, any string or null would be allowed

@dapowers87 Some other configurations to consider are from Cargill (https://github.com/Cargill/OpenSIEM-Logstash-Parsing/search?q=kv). I see things like trim_key used in these a couple times. The user will probably want some way to ignore certain characters so things like
key1=value1 & key2=value2&    key3=value3

don't actually add those spaces to the keys or values. If they don't have that then we should make sure they understand how the processor works, and that they will have to use another processor to trim_keys or manipulate the keys and values (could be in either mutate or the string_manipulation processor.

Thanks @dapowers87 for putting this together.
Regarding the names, I'd like us to be consistent. So if we use target or destination here, I think we'd want to use that for copy or move in #508.
I think the default behavior should support a known and common scenario. A good one would be supporting HTTP query strings. So I'd like the default key_value_delimiter_regex to be a =. (Sorry that my initial example was somewhat unhelpful in this regard).

@dapowers87 Regarding non_match_value, do we have a use case to retain original value in target/destination ? I see default value is null. If we have use case we should have default value as original value and non_match_value can be nullable field.

@dapowers87 Regarding non_match_value, do we have a use case to retain original value in target/destination ? I see default value is null. If we have use case we should have default value as original value and non_match_value can be nullable field.

We are not able to get the original value as the split failed. For example, if the key_value_delimiter_regex were = and the message were {"message":"key1value1&key2=value2"}, the proposed output would be {"key1value1": null, "key2": "value2"}

I think that proposed approach is good. It would work for an HTTP query string like:
pretty&q=mysearch

Then we let the pipeline author decided what it is. They could set non_match_value=true which would be result in:
{"pretty":true, "q": "mysearch"}

In Logstash, there is a field_split and a separate field_split_pattern. field_split is used about three times as often as field_split_pattern on GitHub.
field_split splits on an array of characters (e.g. &? would split on either & or ?). Special regex characters such as [ or ] need a \ to escape it.
field_split_pattern splits on a regex expression. Special regex characters such as [ or ] need a \\ to escape it.
The question at hand is whether we should support analogs in Data Prepper for both field_split and field_split_pattern, or if we should just support the more robust field_split_pattern (this is the current implementation).

We should at least support the field_split at least in the Logstash configuration converter. This is certainly possible since it supports customization of field conversion.
It does appear that this could be a valuable feature for users. And it is probably the same amount of work to support it in the regular Data Prepper pipeline configurations as it would be to convert using the Logstash configuration converter.
So I tend to think Data Prepper should have it.
A few changes I might like to see:

Perhaps name it field_split_characters. This gives a sense of parity between the features in my mind.
I think using a string and splitting on any string is not terribly obvious. I wonder if an array of characters would be appropriate. This could even allow for splitting on larger strings.

I am going to go ahead and add in the analog of value_split to this processor.
One question is how do we handle it when field_split_characters and field_delimiter_regex are both defined? Logstash handles it by having field_split_pattern take precedence over field_split. Should we go that route or should we throw an error?

I think the best user experience would be for us to require either field_split_characters or field_delimiter_regex, and throw a well defined configuration error saying that both can't be defined at once if the user configures this. For Logstash conversion where they define both, we can just drop the field_split.


Upgrade k8s client lib to 1.19.8

Description

Upgrade client-go to v1.19.8. Relevant changes can be found in 4d800b5. These mainly consist of passing context to Kubernetes API calls.
The GetKubeClient logic has been slightly modified in 888269d. If kubeconfig is not specified, call InClusterConfig to get config. This is to avoid printing out warnings which would result in robotest failures.
Upgrade helm to v3.4.2. Relevant changes can be found in 363969f. Helm 3 no longer requires Tiller, and setup of directories and repositories is automated and does not need to be handled on initialization. The helm actions/cmds have been rewritten. They have been ported from https://github.com/helm/helm/tree/v3.4.2/cmd/helm with some minor tweaks.
Type of change

Internal change (not necessarily a bug fix or a new feature)

Linked tickets and other PRs

Requires https://github.com/gravitational/planet/pull/827, https://github.com/gravitational/rigging/pull/100

TODOs

[ ] Self-review the change
[ ] Perform manual testing
[ ] Address review feedback
[ ] Update upstream references / tags / versions after upstream PR merges (linked above)

Testing done

Looked through everything but the helm changes today.  I'll check those out further tomorrow.
Robotest does use a helm chart in its standard image, but it is quite basic.

Helm 3 note:
https://helm.sh/docs/faq/#name-or---generate-name-is-now-required-on-install seems like a gotcha.  We should make sure our documentation and examples are all updated for this.

https://helm.sh/docs/faq/#name-or---generate-name-is-now-required-on-install seems like a gotcha. We should make sure our documentation and examples are all updated for this.

Good catch. I've updated the install action to default to using --generate-name=true if a release name is not provided.
c98d72e

@wadells @knisbet
Can I move on with this change? It doesn't seem like helm integration is used much and shouldn't have a critical impact on the core functionality of gravity.

@wadells @knisbet
Can I move on with this change? It doesn't seem like helm integration is used much and shouldn't have a critical impact on the core functionality of gravity.

Sorry for the delay. The helm changeset is pretty large so I kept procrastinating on the review.
Aside: We should work on a better team process for reviewing large diffs -- e.g. some pointers in the PR description (look at section X, section Y doesn't need much attention due to Z) or doing a synchronous walk through. E.g. it seems like large chunks of 363969f was cut & pasted verbatim, and thus probably doesn't deserve the same level of scrutiny as tailor made new sections.  I can see you started to head down this road with your description, but I still was getting a bit lost within a single ~1K SLOC patch  I end up pulling the code locally and then reviewing with the convenience of go-pls, but then it became difficult to tell where your changes end -- as someone new to both this patch and the helm part of the codebase.

Aside: We should work on a better team process for reviewing large diffs -- e.g. some pointers in the PR description (look at section X, section Y doesn't need much attention due to Z) or doing a synchronous walk through

I agree, I try to minimize the scope of my PRs, but sometimes its difficult to do.
In future PRs with large changes, I'll try to include more comments and walk through important changes.


Add storage high level diagram

Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

Hey,
I agree. virtio-blk and nvme have some similar and some different APIs. I was also thinking how can we abstract this.
The proposed diagram is just a visualization draft to start a conversation. Many elements are still missing.
For example, the whole storage services section is missing, i.e.

compression APIs
encryption APIs
raid APIs
multipath APIs
lvm APIs
...


I can't connect the pi to the real ps3

I need someone to give a more detailed explanation on how to connect the pi with the ps3, when i try to, the emulated toy pad says that it can't see the game.

Make sure you're using a micro USB data cable, like what you'd use to plug your phone into a computer to transfer files. Nothing else will work properly. If you don't have one, you can get one for a few bucks on Amazon

Make sure you're using a micro USB data cable, like what you'd use to plug your phone into a computer to transfer files. Nothing else will work properly. If you don't have one, you can get one for a few bucks on Amazon

That's what i use but it keeps saying the same. I even used a 2nd cable on the side usb port to give it more power but it still says the same.
I commented on the issue that was posted before this one about 2 programs that it WARNs me to install. Could it be because i haven't installed thoes programs that it doesn't work?

Hey have you managed to do that?


Add a check if at least one layer has been added

For what?
If you haven't added any, throw an exception?

Yes. In lets-plot it leads to render-time exception (and displaying it looks bad)


Copy Button, Select Menu UI, and Multiple Selection

Copy Button like in clipboard.js should be cool, the selects should be have UI like in menus, like in Material Angular, and also multiple selection like in Material Angular.

Hi @LIGMATV ,
I think we already can handle that, See our "Reddit Template" https://www.beercss.com/reddit
Select Menu UI

Multiple Selection
In this example we add switches, but you can add checkboxes too:

Copy Button
I think the browsers already have an API for clipboard. But I never used it before 😅.
https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API

Hi @LIGMATV ,
I think we already can handle that. See our "Reddit Template" https://www.beercss.com/reddit
Select Menu UI

Multiple Selection
In this example we add switches, but you can add checkboxes too:

Copy Button
I think the browsers already have an API for clipboard. But I never used it before 😅.
https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API
Hope this helps

Ah, not know about before, but i just want to edit my issue to remove the clipboard.js but your response so fast. It fine now, thanks.


EC2 frontend doesn't support ssh keys

The EC2 frontend implementation doesn't handle SSH keys correctly. That is, it doesn't render multiple in the same fashion as the instance metadata specification (https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-categories.html).
Currently, we serve a single SSH key located at /2009-04-04/meta-data/public-keys when the specification stipulates /2009-04-04/meta-data/public-keys/0/openssh-key. This means not only do we serve from the wrong endpoint, we don't accommodate > 1 key.
Through manual testing it seems this likely won't impact cloud-init but it may result in keys not being added to the host.

See #166


multiple choice ballot not showing results

Visible at  https://sovereign.opensourcepolitics.eu/vote/decide-on-a-controversial-topic-for-medialab-prados-experiment
This feature seems, which is really cool, looks like a work in progress.
Lots of question raised : how votes are splitted between proposals. For example in the case below what happens if I allocate 5 votes and choose 2 options.

Is this issue solved yet?

Hey @thatsVishal ,
To my understanding, this functionnality hasn't been properly finished. So it's early to go on issue solving on this one.
In term of issue you can lookup to give us hand go check :

https://github.com/DemocracyEarth/sovereign/issues/187
https://github.com/DemocracyEarth/sovereign/issues/193
https://github.com/DemocracyEarth/sovereign/issues/195
https://github.com/DemocracyEarth/sovereign/issues/197
https://github.com/DemocracyEarth/sovereign/issues/59 (not sure if resolved yet)

Not relevant anymore with refactoring


Put dependencies under 'Dependencies' group instead of under 'Sources'

Yes, that is the one. I see that @abertelrud put in his PR (#777) just around the same time as I did :( Is there anything useful for you guys in this PR?

Sorry about that, @siemensikkema ... I marked the JIRA as In Progress to try to avoid that someone else would end up also start working on it, and mentioned it on Slack, but I'm sorry that you ended spending time on this.  @aciidb0mb3r, what do you want to do re: the two PRs?

I think we can close this one since the other one is complete and good to merge. Sorry @siemensikkema for the trouble :( FYI for future reference people usually assign the bugs to themselves when they start working on it.

@abertelrud @aciidb0mb3r no hard feelings! It was an instructive experience. Next time I'll know where to check :) The only thing that I see missing from #777 is updating the TODO.md file. If you decide to keep that file at all, that is.

We should remove that file and log bugs in JIRA instead


Tweets tweets tweets!

What's in here?
See the tweets/README, but in summary:

Python scripts that go and get tweets
An attempt at extracting useful information from those tweets

I haven't yet talked to everyone about this in any detail. I plan on doing so at some point, assuming people want to hear about it! But in the meantime I thought I'd stick the code up here so people can have a look through it by themselves if they want to.
I've taken my Twitter App keys out of the scripts, so to run them locally you'd need to pop your own in. Thinking about it now, I'm not sure whether I needed to take out my keys. I trust you guys. Let me know whether it would be better/easier to have them in.
(And I spotted a couple of typos in the python/README, so I've fixed them!)
Edit: there was also a leftover .travis.yml in the main directory, which has now been exterminated.

Hey, thanks for this, will have a look right away, but I'm sure it's all fine. Just so I don't miss your pull requests in the future (my Github timeline is more active than my Facebook feed), could you add me as a reviewer when you create the PRs going forward? Thanks!

Let me know what you think about the things I've left unchanged - I'm happy to change them if you think it would lead to big (or small) improvement!
Also did anything big happen in Bath yesterday? (Other than BMLM, obvs.) I only ask because when I had a look at the mLab database just now I noticed it seemed like an unusually large increase. Wondered if it was something to do with running these scripts locally, but double-checked the Heroku log form last night and saw this:
2017-09-21T03:01:24.734596+00:00 app[scheduler.4888]: Downloaded 3988 tweets

Normally we get ~500 a day. So this is weird!

I had a quick look around in the tweets collection in mongo and it looks like we have about 7k duplicates in there. (out of about 17.5k total) If you've been saving data you've already saved before then perhaps that could explain the increase in inserts?
I'll have a look through this PR again tomorrow

Interesting. Another ~4k last night too... we definitely weren't getting duplicates to start with, and I haven't changed anything. Very strange that this has only started happening in the last few days 🤔
In fact the Twitter archive (which we are searching) is a sample from the tweets from the previous week or so. And I think, when I ran the script for the first time (so there was no "most recent entry" in the database), it pulled in about 4k tweets. So maybe it's somehow stopped recognising since_id and is just pulling the whole archive every night.
As I say, I haven't changed anything on the deployment. Really confused...

Sorry to keep you waiting. It's gone in now


Divide by zero panic in Pack.auto_layout() [corner case]

An empty pack will divide by zero in auto_layout:
    let mut p2c_v = Pack::new(0, 0, 640, 25, "");
    p2c_v.set_spacing(4);
    p2c_v.set_type(PackType::Vertical);
    p2c_v.auto_layout();
    p2c_v.end();

thread 'main' panicked at 'attempt to divide by zero',...\fltk-0.15.4\src\group.rs:329:17
stack backtrace:
...snip...
   3: fltk::group::Pack::auto_layout
             at C:\Users\Danny\.cargo\registry\src\github.com-1ecc6299db9ec823\fltk-0.15.4\src\group.rs:329
   4: draw::main
             at .\src\main.rs:20
   5: core::ops::function::FnOnce::call_once<fn(),tuple<>>
             at C:\Users\Danny\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:227
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Not that anyone is likely to do this, but I encountered it when playing with Packs...

Hi,
Thanks for reporting it. I have added a check for 0 children in master which should appear in the next patch.

Thanks!


Backtick character unnecessary after the pipe character

The backtick '' character is unnecessary after the pipe "|" character because the pipe acts as a carriage return.  For the example on this page, Instead of "Get-AzVM -ResourceGroupName TestGroup |  ", please eliminate the backtick character to make it "Get-AzVM -ResourceGroupName TestGroup |".  The examples will be more helpful and less confusing for people beginning to use PowerShell.  Thank you, MM-MikeM

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23262a16-7bc8-646e-8143-2713e8a5afc9
Version Independent ID: 334ff617-a357-d6de-327e-49bc5ae36bc9
Content: Query output of Azure PowerShell cmdlets
Content Source: docs-conceptual/azps-1.8.0/queries-azureps.md
GitHub Login: @sptramer
Microsoft Alias: sttramer

@MM-MikeM - Thanks for brining this to our attention. We will investigate it further and update you shortly.

@MM-MikeM , Thanks again for bringing this to our attention. We have updated the Doc. It should merge the changes, Once the PR is approved.

@MM-MikeM , Thanks again for bringing this to our attention. We have updated the Doc and We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Deprecate SimpoLoss

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[ ] fix a bug
[ ] update tests and/or documentation
[x] other (deprecation)

Closes #2062. We could link to an example repo in a follow up.
Changelog
Added a deprecation message. To be removed in 0.6.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.60%. Comparing base (f3d8d3c) to head (0140dc5).

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #2063       +/-   ##
==========================================
+ Coverage   7.35%   65.60%   +58.24%
==========================================
  Files        277      323       +46
  Lines      15422    17963     +2541
==========================================
+ Hits        1135    11785    +10650
+ Misses     14287     6178     -8109

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

I've removed from the recipe. If the user tries to use this loss in the recipe, it will display the deprecation warning and error out (in a probably unhelpful way).


wrong database adapter in migration

db.uri config with ' postgres://postgres:123456@localhost/mydb'
when run emmett migrations up
it shows
sqlite3.OperationalError: unable to open database file

solved