Support predicate-pushdown for isin operations

Closes https://github.com/dask-contrib/dask-sql/issues/607
This PR adds predicate-pushdown support for dd._Frame.isin(values), and uses a somewhat-ugly workaround to account for the fact that dask.dataframe will produce a distinct MaterializedLayer object for the values argument to isin.
Note that this PR also addresses "not in" support. However, dask.dataframe will produce the wrong result for these filters until https://github.com/dask/dask/pull/10320 is merged.

Codecov Report

Merging #1160 (c45da57) into main (2df7476) will increase coverage by 0.23%.
The diff coverage is 92.50%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
+ Coverage   81.46%   81.70%   +0.23%
==========================================
  Files          78       78
  Lines        4403     4438      +35
  Branches      798      808      +10
==========================================
+ Hits         3587     3626      +39
+ Misses        640      631       -9
- Partials      176      181       +5

Impacted Files
Coverage Δ

dask_sql/physical/utils/filter.py
81.18% <92.50%> (+3.34%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ayushdg @randerzander - Note that I added isna support to this PR, but I'd be happy to split that change into a separate PR if you prefer.

@ayushdg - I'm thinking we should layer on something like #1140 as a follow up. Let me know what you think.

Yeah it makes sense to add something that conceptually achieves what #1140 does without some of the extra logic/handling in that pr. We can address that in a followup and some of the logic from #1140 should be redundant with dask-cudf 22.06 and newer


Fix the behaviour of validate_user() in validations.py

Closes: #1.
Added a check to only allow usernames which start with a letter.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Loadbalancer IP is (automatically) assigned on Node. This results in an IP conflict.

Describe the bug

On OKD Clusters, the Loadbalancer IP is assigned on the Node, that the loadbalancer picks.
Example Configuration:
the loadbalancer listens on <IP_ADDRESS> for api and api-int
and on <IP_ADDRESS> for *.apps
the configuration is as follows:
<IP_ADDRESS> -> <IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>
In vSphere I can see that one Master Node has the <IP_ADDRESS> assigned.
If I reboot this Master Node, the IP is assigned to a different Master Node instead
This generelly leads to an IP conflict, because the IP is now configured on the Loadbalancer and on an OKD Node.
Our Openshift Clusters do not have this issue.
Version

Install Method: Both UPI
1st Cluster (lab): Release: 4.10.0-0.okd-2022-06-10-131327 (install time) - updated to 4.11.0-0.okd-2022-07-29-154152 (current) ; Fedora Core OS OKD - 35.20220327.3.0
2nd Cluster (dev): Release 4.8 4.8.0-0.okd-2021-11-14-052418 ; Fedora Core OS OKD - 34.20210626.3.1
How reproducible

I setup 2 Clusters and both have this issue. If I restart a Node that has a LB IP on it, the IP moves to a different Node.
Log bundle

The complete Log-Bundle has 145MB and can not be attached. If you want specific Logs from must-gather please tell me which ones are most important for you. I will attach a subset.
must-gather.zip

If I reboot this Master Node, the IP is assigned to a different Master Node instead

that's expected, isn't it?

This generelly leads to an IP conflict, because the IP is now configured on the Loadbalancer and on an OKD Node.

Which "load balancer" do you mean here?
In IPI external LB (i.e. haproxy) for api. endpoint should point to the API VIP, which would move to a valid node. Internal LB - keepalived - will use the same IP to handle api-int endpoint. Your UPI setup should replicate it to work

The loadbalancer is external. The loadbalancer detects if a Node is not reachable and does not send any requests to it, until the interface is up again.
We use a ssl_bridge configuration on the LB if that matters, that sends the requests to specific IP addresses (for api and api-int - these IPs are the Master Nodes. For *.apps for example. it are 2 specific nodes that run the router pods)

So, just to clarify. You have configured an external Load Balancer, and you gave it the same IP address that Keepalived is using within OKD?
What are the IP's configured in your environment here:
❯ oc debug node/<your-master-node> -- grep -A1 address /host/etc/keepalived/keepalived.conf
Starting pod/okd-hm27m-master-2-debug ...
To use host binaries, run `chroot /host`
    virtual_ipaddress {
        <IP_ADDRESS>/32
--
    virtual_ipaddress {
        <IP_ADDRESS>/32

I'm using OpenStack and not VMware, but should be similar I assume.

root@jump ~]# oc debug node/master6101 -- grep -A1 address /host/etc/keepalived/keepalived.conf
Starting pod/bmcmaster6101rbgooeat-debug ...
To use host binaries, run chroot /host
virtual_ipaddress {
<IP_ADDRESS>/32
virtual_ipaddress {
    <IP_ADDRESS>/32

Removing debug pod ...
[root@bmcdeploy6101 ~]#

This sounds a bit confusing, you say that your cluster is installed as UPI, but have VIPs?
When installing via UPI (Infrastructure provider = none), you have an external load balancer, so the VIPs are not necessary. If you install using IPI then you have the VIPs as instead of an external load balancer, you have keepalived that maintains the VIPs.
You can add an external load balancer to your IPI cluster, as a post install exercise, but it still needs to point to the VIPs, you cannot reuse the VIP IP addresses for your external load balancer, that will need a unique IP address of its own.
Are you sure that the cluster is UPI, what does the Infrastructure Provider say in the console, None or bare metal?

Ironically, I can't find the info anymore on https://docs.okd.io/4.8/installing/installing_vsphere/installing-restricted-networks-vsphere.html#installation-vsphere-config-yaml_installing-restricted-networks-vsphere
but I thought it said to configure it that way.
The installation is a UPI in vSphere. Does it automatically assume the DNS names without providing the addresses for it? E.g. it searches for api.. and apps.. ?

Yes. A vSphere UPI 4.8 installation formulates the api and apps URLs  using the base domain you provide in the config file. It assumes you have configured a DNS server upstream to provide those respective records, which should point to your upstream load balancers.  The nodes should have that DNS server in their network config either through DHCP or manual networking configuration using k args.

It doesn't assume, those should be configured in your external DNS server prior to the install:
https://docs.okd.io/4.10/installing/installing_vsphere/installing-vsphere.html#installation-dns-user-infra_installing-vsphere
I guess the documentation you're referring to be this?
https://docs.okd.io/4.10/installing/installing_vsphere/installing-vsphere.html#installation-load-balancing-user-infra_installing-vsphere
There's a sample install-config.yaml here:
https://docs.okd.io/4.10/installing/installing_vsphere/installing-vsphere.html#installation-vsphere-config-yaml_installing-vsphere

Makes sense. Can I edit these settings after installation or should I reinstall my cluster?

Re-install.


Log real renew date on each run

Previously, the renew_at log message would be one month after the
current date instead of one month prior to the cert expiration date.
That meant it would always print out a different date each day. This
changes the logic to store the renewal date and compare that with the
current date, always printing the same renewal date.
Before:
2016/06/04 00:31:07 cert.ignore_update expires_at="2016-09-01 21:41:00 +0000 UTC" renew_at="2016-07-04 00:31:07.759794771 +0000 UTC"
2016/06/05 00:30:16 cert.ignore_update expires_at="2016-09-01 21:41:00 +0000 UTC" renew_at="2016-07-05 00:30:16.197600269 +0000 UTC"

After:
2016/06/05 16:22:37 cert.ignore_update expires_at="2016-09-01 21:41:00 +0000 UTC" renew_at="2016-08-01 21:41:00 +0000 UTC"

Good catch. Thanks.

@dmathieu great project btw, really useful!


Investigate RxSwift

Really cool functional reactive programming framework for Swift. We were going to move from RAC 2 -> RAC 3, but it might make more sense to switch to this, instead.

It would be great for the community if you could share the thoughts that led to continuing with RAC 3 instead of RXSwift.  Thanks!

To my knowledge, so far, that's not been decided. Roughly speaking this is a pretty big app, and either choice requires significant re-writing.

That is correct; we are still using the ReactiveCocoa 2 ObjC API, leading to a lot of forced casting. RxSwift is still too early to use, but RAC 3 is also in a constant state of flux. I'm leaning toward RxSwift, since I've been working with them on the project recently, but we've not had a chance to devote the effort to change Eidolon.
Does that answer your question? Happy to clarify anything.

Yes, that answers my question!  This app is one of the few shining examples of a modern, well-written codebase and tech stack with swift, so thank you immensely for sharing :)


Error reported after cancel query, unable to query

eclipse.buildId=unknown
java.version=11.0.3
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=zh
Command-line arguments:  -os win32 -ws win32 -arch x86_64 -data file:/C:/Users/Administrator/AppData/Roaming/DBeaverData/workspace6/
This is a continuation of log file C:\Users\Administrator\AppData\Roaming\DBeaverData\workspace6.metadata.bak_0.log
Created Time: 2019-08-14 09:40:38.271
org.jkiss.dbeaver.model
错误
Wed Aug 14 09:45:11 CST 2019
Error executing query
eclipse.buildId=unknown
java.version=11.0.3
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=zh
Command-line arguments:  -os win32 -ws win32 -arch x86_64 -data file:/C:/Users/Administrator/AppData/Roaming/DBeaverData/workspace6/
This is a continuation of log file C:\Users\Administrator\AppData\Roaming\DBeaverData\workspace6.metadata.bak_0.log
Created Time: 2019-08-14 09:40:38.271
org.jkiss.dbeaver.model
错误
Wed Aug 14 09:45:11 CST 2019
SQL 错误 [08S01]: org.apache.thrift.transport.TTransportException: SASL authentication not complete

unfortunately cannot reproduce the ticket.
there is to less information.
if it is still actual for you - feel free to reopen the ticl=ket or create a new one


Getting joined record data after sort

I have a one-to-many relation with my models, so I have setup an explicit sort in my widgets_controller:
smart_listing_create(:widgets, Widget.all.joins(:cogs), partial: "widgets/list", default_sort: {inventory_number: "asc"}, sort_attributes: [[:cog_height, "cogs.cog_height"], [:cog_width, "cogs.cog_width"]])
It works great and I get multiple entries in the list for each Widget with multiple Cogs. Each inventory number is listed X number of times if the widget has X cogs associated. This is good!
But how do I show the correct Cog height and width alongside each inventory number entry? For example, in my _list partial:
<% smart_listing.collection.each do |w| %>

<%= w.inventory_number %>
<%= w.[????].cog_height %>
<%= w.[????].cog_width %>
...
Where [????] is, I need some way to get a reference to the current Cog model being listed there. How do I do that? If my example doesn't make sense, please let me know. And apologies in advance if I am missing something obvious. Thanks!

Hello, thanks for using smart_listing.
If I understand this correctly, I think this should work just right:
<% smart_listing.collection.each do |w| %>

<%= w.inventory_number %>
<%= w.cog.cog_height %>
<%= w.cog.cog_width %>
...

Or You could use delegate method in Your model.
If I don't understand it correctly let me know.

This would work if I was listing cogs in my example, but unfortunately I am looking at the other side of the relation. For example, this would work if I redid the controller similarly:
<% smart_listing.collection.each do |c| %>

<%= c.widget.inventory_number %>
<%= c.cog_height %>
<%= c.cog_width %>
...

Is there any other way you can think of coming from the one side of the one-to-many relation, rather than the many side? Delegates are good to know about, but again I don't think they will help me here.


Flyout overlay WindowButtonCommands

When update from 1.4.3 to 1.5.0 the flyout is over the commands
1.4.3

1.5.0

MahApps.Metro __v<IP_ADDRESS>
Windows OS 10
Visual Studio 2013
.NET Framework 4.5

@tm69 what type of Flyout is this? Top or Right? Do you use some of the overlay behaviors?

The Flyout is Left, and yes i have IconOverlayBehavior="Always" in the window, but I just discover that happens when the Flyout is modal IsModal="True" if i set false the commands are visible again

@tm69 ah, yes this was a fix. IsModal = means really modal... -> #2841

@punker76 Thak you for you time :D


PR #77 - Coins orders not being cleared out

Description
The buy order is not being cleared after executed at Binance.
To Reproduce
Monitoring 40 coins at PR #77 (the machine that is running, is at 60% of CPU utilization)
Expected Behaviours
The buy order being cleared seconds after executed at Binance
Screenshots

Thanks, @elvishp2006
Can you run the following command in your server and see the log message?
reset; docker logs binance-bot -f --tail=100  | bunyan -c 'this.symbol === "INJUSDT" && this.job === "trailingTradeIndicator"'

What you should see is
TrailingTradeIndicator: Finish process...
...
...
...
      "indicators": {
        "highestPrice": 0.054492,
        "lowestPrice": 0.047308
      },
      "openOrders": []
...

Can you let me know whether openOrders is empty or not?

@chrisleekr I'm getting this error with this filter error from daemon in stream: Error grabbing logs: unexpected EOF

@elvishp2006 Yeah, that is because the log is limited to 50MB to outgrowing. And I assume you have lots of coins to monitor; hence, it will take some time to get INJUSDT turn. Try 2-3 times more and you should see the logs.

@chrisleekr I executed several times, and got this output
(node:36) UnhandledPromiseRejectionWarning: LockError: Exceeded 1 attempts to lock the resource "redlock:trailing-trade-symbols:BTSUSDT-latest-candle".
    at /srv/node_modules/redlock/redlock.js:431:20
    at processImmediate (internal/timers.js:461:21)
From previous event:
    at Redlock._lock (/srv/node_modules/redlock/redlock.js:359:9)
    at Redlock.lock (/srv/node_modules/redlock/redlock.js:180:14)
    at Object.hset (/srv/app/helpers/cache.js:84:30)
    at /srv/app/server-binance.js:32:11
    at ReconnectingWebSocket.w.onmessage (/srv/node_modules/binance-api-node/dist/websocket.js:203:7)
    at WebSocket.ReconnectingWebSocket._handleMessage (/srv/node_modules/reconnecting-websocket/dist/reconnecting-websocket-cjs.js:174:23)
    at WebSocket.onMessage (/srv/node_modules/ws/lib/event-target.js:132:16)
    at WebSocket.emit (events.js:315:20)
    at Receiver.receiverOnMessage (/srv/node_modules/ws/lib/websocket.js:825:20)
    at Receiver.emit (events.js:315:20)
    at Receiver.dataMessage (/srv/node_modules/ws/lib/receiver.js:437:14)
    at /srv/node_modules/ws/lib/receiver.js:394:23
    at /srv/node_modules/ws/lib/permessage-deflate.js:308:9
    at /srv/node_modules/ws/lib/permessage-deflate.js:391:7
    at afterWrite (internal/streams/writable.js:466:5)
    at onwrite (internal/streams/writable.js:446:7)
    at InflateRaw.afterTransform (internal/streams/transform.js:103:3)
    at Zlib.processCallback (zlib.js:586:8)
(node:36) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 174)

@elvishp2006 Yeah, that is when the Redlock couldn't get the lock for the Redis, which often happens.
That error is ok. It will eventually get the lock and update relevant data.
So you still didn't get other messages?
You said, there are other coins happening the same issue, right?
Can you try with that? Simply change INJUSDT to another coin symbol.

I removed the tail, now, I'm getting nothing as output:

What about without this.symbol?
 What I need is logs for trailingTradeIndicator
Put tail back because I just need to see the latest log.
ocker logs binance-bot -f --tail=100  | bunyan -c 'this.job === "trailingTradeIndicator"'

Something is wrong it this log output:

Hmm... That message is coming from a cronjob, which means one of the trailingTradeIndicator job is never finished - https://github.com/chrisleekr/binance-trading-bot/blob/feature-monitoring-simultaneously/app/server-cronjob.js#L34
Can you simply restart the container?
$ docker restart binance-bot

I got this error
Error response from daemon: Cannot restart container binance-bot: Cannot kill container 8a228d0664867a3957dda5c908d08f2b86cc0305a79de8cf53f7de3a74231adf: unknown error after kill: runc did not terminate sucessfully: container_linux.go:392: signaling init process caused "permission denied"
: unknown

That is new. I never saw that error.
I just quickly googled. Can you see this and try?
https://javahowtos.com/guides/124-docker/414-solved-cannot-kill-docker-container-permission-denied.html

Restarted:

Ok, let's get trailingTradeIndicator again to see whether that is working or not.

Yes, and It's now placing sell orders for this coins that was locked

Is it expected sell orders?
I can see from your account information, some of the coins are locked. It means there are some orders for the coin. The bot will display manual orders as well.

I don't place manual orders (just deposit FIAT), it's just the bot

Ah, so you had the last buy price. Ok. So that is expected then. Confirm?/

I think the last buy price is wrong, see:

And here, there is more that 1 order executed for this coin:

@chrisleekr Sorry, it's right, I was looking on trade, not orders

Hmm, if the last buy price is less than 19.924, then I would assume it could be the reason that the bot was not working properly. But the last buy price(19.934) is higher than executed price (19.924).
Ah! One possible scenario.
For some reason, your API exceeded the limit and couldn't place an order. But in that case, it should've thrown an error to Slack.  And it shouldn't record the last buy price.
https://github.com/chrisleekr/binance-trading-bot/blob/feature-monitoring-simultaneously/app/cronjob/trailingTrade/step/place-buy-order.js#L149

Sorry, it's right, I was looking on trade, not orders
Oh phew, gee you scared me. I couldn't figure out why it happened.

@chrisleekr Do you think that is possible to restart the job "trailingTradeIndicator" if this not finish in x minutes?

Ok, so assuming all working fine now, I will give you a temporary solution.
$ sudo su
$ crontab -e

0 * * * * /usr/bin/docker restart binance-bot

If you put this line, the bot will restart every hour, which is ok.
We still couldn't figure out why the trailingTradeIndicator was not running.
I couldn't guess any reason.
What I will do is, I will update the code to make sure it timeouts if it is running more than x amount of time.

I think I know what is happening. It's a local tunnel acting up.
Since we are using development, the nodemon is not restarting when there is crash.
What I will do, I will update nodemon to restart automatically after crash.

@chrisleekr I already disabled the local tunel, but I don't remember that was before or after this bug

@chrisleekr this also happening to me, local tunnel is crashing and I need to restart manually. Is there a quick workaround?

Sorry just saw this https://github.com/chrisleekr/binance-trading-bot/issues/144#issuecomment-831207002 I will try.

@gilmillasseau See this as well - https://github.com/chrisleekr/binance-trading-bot/pull/77#issuecomment-831915217

Thanks mate, I will give some feedback it's already set.
As for #77 I think it's stable to be merged, I am using for a couple of days and my only major error was the tunnel crash.
Now I am keen to have like a performance information for each pair, I am noticing some pairs are performing better than others, not sure if this should be included in each "card" or a new route like /performance/<pair> to have a list of trades and a PNL for the last 7 days, I think binance only have a general overview for all pairs.

@gilmillasseau
Yeah, once I add the final feature - Stop-Loss, then I will merge in after confirming stability.

Now I am keen to have like a performance information for each pair, I am noticing some pairs are performing better than others, not sure if this should be included in each "card" or a new route like /performance/ to have a list of trades and a PNL for the last 7 days, I think binance only have a general overview for all pairs.

It's kind of hard because of the API limit. The bot cannot track order status. So the bot itself wouldn't be able to give accurate PNL as well because executed trades may be a different price. The source of truth for orders is Binance. So for now, I think better rely on it to track PNL.


pr418 testing

This branch builds on https://github.com/jazzband/pip-tools/pull/418 and adds a basic test case to ensure that a setup.py file is parsed when present and no requirements.txt is offered.
@davidovich

@majuscule can you rebase on master ? I added Windows testing, and I suspect that the tempfile.NamedTemporaryFile() usage will break (because of the lack of delete=False parameter). On Windows, the file is deleted at context manager exit, breaking subsequent processing.

Rebased and it does look like tests on Windows are failing. I'm afraid I don't quite follow what the error is here. In fact the only tempfile.NamedTemporaryFile() instance I see does use the delete=False parameter:
tests/test_cache.py
4:from tempfile import NamedTemporaryFile
22:        cache_file = NamedTemporaryFile(mode="w", delete=False)

Regardless that doesn't seem related to this error:
<Result InstallationError("Could not open requirements file: [Errno 13] Permis...ed: 'c:\\\\users\\\\appveyor\\\\appdata\\\\local\\\\temp\\\\1\\\\tmpg362ei'",)>

I do see that in the pip_conf fixture, it explicitly prepends a tmpdir to the written file, however my code takes place within the isolated_filesystem, and needs to be relative to the cli invocation.
Do you have any further ideas as to what is going wrong?

I don't quite follow why that would be causing the error, but I appreciate your pointing it out. I've made the change and also removed it's use as a context manager which imo does imply it's auto-deletion. Might even be able to keep delete=True this way? I'm afraid I can't reproduce the error locally here without a windows machine to test on so will have to wait for AppVeyor.

Looks like it's all passing now. Please let me know if there's anything else I can do for this ticket or any of the others on the 1.9 milestone to get it released!

Good, thanks !
@majuscule In fact, if you have a little time, I want one bugfix for the 1.8.2 release, before 1.9, but @mattlong has not responded to add tests on https://github.com/jazzband/pip-tools/pull/476. Are you up for it ? :-)

Thanks @tysonclugg and @majuscule


Can I view the pixel values of images in the built-in image preview function of VScode?

I am looking for a feature to view pixel values, but I have not found it yet.

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


cshtml minifier tries to generate multiple min files.

Yes, I think this may have been broken in the RC2 upgrade. I'll take a look at it.

Fixed in the next release.


Server crash after many /pex reload

Hi !
I have a problem with my server.
Some server have to execute all 15 minutes: /pex reload.
I use this because the documentation of NetEvent is really bad and don't work so when a player have a new permission in my server (It's a hub with many server. I use MySQL to sync PEX but I only execute pex command in my lobby, not all the server)
An another dev found this problem and made this:
https://github.com/fubira/PermissionsEx/commit/bea4e71ac4e4203d792b4c47417429a34c446676
I have a report:
http://pastebin.com/hciigUDg
Thanks in advance !
I use PEX 1.22.x (1, 2 ... have the same problem) and spigot patched to support 1.8 player. But same problem with previous version of spigot for 1.7.x only !

I'll take a look at the issue mentioned in that commit you provided! Thanks for linking to actual code that resolves the issue (even tho the dev acknowledged it as a workaround)


Reform forms generator

Can we realise forms generator for rails? Something like:
rails g reform:form v1/user_form user_name password

That will produce:
class V1::UserForm < Reform::Form
  properties :user_name, :password
end

Go for it, in https://github.com/trailblazer/reform-rails :+1: !!

Good, will work on it at weekend :)

You can look up how to write and test generators in the cells-rails gem!

Ok, thank you!


Caching needs improvement

Currently we are doing caching only on the spread view. The cache is expired every 20 seconds, which is a balance between staleness and performance.
We should be able to improve both using a cache key that incorporates event.updated_at and a cascading touch strategy.

This is done.


1.19.4

When is the version for 1.19.4 coming?

I thought it was working for 1.19.4, I'm not using it anymore. Thanks for the report, I will update the 1.19.x version to 1.19.4

thank you so much!
5 May 2023 Cum 10:09 tarihinde Lilian Gallon @.***>
şunu yazdı:

I thought it was working for 1.19.4, I'm not using it anymore. Thanks for
the report, I will update the 1.19.x version to 1.19.4
—
Reply to this email directly, view it on GitHub
https://github.com/lilgallon/Bettercolors/issues/108#issuecomment-1535818744,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7SRV4DUXM43J5HHDG5UVUDXESRSZANCNFSM6AAAAAAXUIR5FY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Here you go: https://github.com/lilgallon/Bettercolors/releases/tag/7.4.1-MC1.19.4fa :)


Code Fix for ISSUE 2092 & 2064

Fix for below issues
https://github.com/sequenceiq/cloudbreak/issues/2092
https://github.com/sequenceiq/cloudbreak/issues/2064
Fix summary
Added new form under "Manage Security group" to add existing groups along with new security group.
Added 2 new columns to Securitygroup table, for adding cloudplatform and storing cloud existing security group id.
Added ability to provide custom image id for building cluster.

@marut-launch You should also update this class https://github.com/sequenceiq/cloudbreak/blob/master/core/src/main/java/com/sequenceiq/cloudbreak/service/securitygroup/DefaultSecurityGroupCreator.java

@marut-launch You should also create the securitygroup for the mock integration tests. Here is the security group which is not exist for the tests
https://github.com/sequenceiq/cloudbreak/blob/master/integration-test/src/main/resources/application.yml#L99

Updated code according to review comments, please review.


Attempts to deflake servlet after Jetty 9 update

After moving to Jetty 9, we get occasional flakes seeing errors in servlet
requests. This moves the atomic boolean around to help rule out redundnant calls
as a problem. Possibly, though it could be that something is eating the error
or that the request is completing prior to the error being visible somehow.
See #1207

ahah!
ITSpanCustomizingAsyncHandlerInterceptor>ITHttpServer.spanHandlerSeesException_async:513->ITHttpServer.spanHandlerSeesError:538 Span finished multiple times


oauth filter: set token cookies regardless of forward_bearer_token option + ability to disable bearertoken and refreshtoken cookie

Commit Message:
oauth filter: set token cookies regardless of forward_bearer_token option + ability to disable    refreshtoken and bearertoken cookie
Additional Description:
Unconditionally set the BearerToken, IdToken, and RefreshToken cookies in the response. The documentation of forward_bearer_token states "Forward the OAuth token as a Bearer to upstream web service." It's confusing for this behavior to affect response cookies as well.
This change alone would set the raw bearer token in the client browser which is undesirable by some.
Therefore introduced further properties to disable single cookies, if necessary:

disable_access_token_set_cookie
disable_refresh_token_set_cookie

Like it was done here: https://github.com/envoyproxy/envoy/issues/33825
Risk Level: Low
Testing: Included
Docs Changes: N/A
Release Notes: Included
Platform Specific Features: N/A
Fixes: https://github.com/envoyproxy/envoy/issues/32566

@markdroth I addressed your review comments

In the future, please don't force-push to the branch after the review has started, since that makes it hard for the reviewer to see what changed since their last review pass.

/lgtm api

cc: derekargueta

@mattklein123 thanks for the review. Can we already merge it?

/retest

I'm not sure why CI is failing. Is main fully merged? cc @phlax

Hi @mattklein123 ,
merged main again and removed that + char from the pr title. I think removing the + char did the trick...
Can we merge this pr?
Probably this line can not handle it ?

The template is not valid. envoyproxy/envoy/.github/workflows/_start.yml (Line: 90, Col: 17): Error reading JToken from JsonReader. Path '', line 0, position

hi @denniskniep - i think it was something slightly different
i changed Bearer to in the PR description to XXX - its a new failure mode triggered by a false positive in githubs secret scanning

Sorry needs a main merge then we are good to go.
/wait

@mattklein123  merged

Sorry needs merge again. :(
/wait


Add --version option

Perhaps, this can make writing tests for edgedb server easier. Regardless of that it looks like very expected thing on (almost) any executable.

@elprans I think we have some rather complicated versioning machinery, would this one liner do the correct thing?


Consume request body on early return

These code changes add consumption of request upon early return to many classes.
This is done in two ways:

Some classes are switched from HttpHandler to WebServiceHandler
Some classes use convenience methods from the new EarlyReturn class

Option 1 is preferred (and most such conversions have already been done in previous PRs), but in some cases, such as when branching can lead to propagation of LiveHttpRequest instead of early-return, option 2 has been used.
You may also see some unrelated files have automatically had their copyright notices updated. I advocate just allowing these changes in, since the build process is going to keep making the changes on each build and it wastes time removing them again after every end-to-end test run.

I would suggest you take ByteStreamAggregator class as a basis, to create a new class for discarding a body up to and until max N bytes. Then use that class to implement consume method just like we do for aggregate.
Have you explored this option?

Keeping this open for Kyle ;-)


PyQt 5.12 broken?

Issue:
On Windows, conda cannot resolve package conflicts for PyQt 5.12, even in a new environment:
(base) C:\Users\Jeffrey>conda create -n test -c conda-forge pyqt=5.12
Collecting package metadata (current_repodata.json): done
Solving environment: failed with current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Package vc conflicts for:
pyqt=5.12 -> vc[version='>=14,<15.0a0']
Package qt conflicts for:
pyqt=5.12 -> qt[version='>=5.12.5,<5.13.0a0']
Package python conflicts for:
pyqt=5.12 -> python[version='>=3.6,<3.7.0a0|>=3.7,<3.8.0a0|>=3.8,<3.9.0a0']

Environment (conda list):

$ conda list
# packages in environment at C:\Users\Jeffrey\Miniconda3:
#
# Name                    Version                   Build  Channel
anaconda-client           1.7.2                      py_0    conda-forge
asn1crypto                0.24.0                py37_1003    conda-forge
attrs                     19.1.0                     py_0    conda-forge
bzip2                     1.0.8                hfa6e2cd_0    conda-forge
ca-certificates           2019.6.16            hecc5488_0    conda-forge
certifi                   2019.6.16                py37_1    conda-forge
cffi                      1.12.3           py37hb32ad35_0    conda-forge
chardet                   3.0.4                 py37_1003    conda-forge
clyent                    1.2.2                      py_1    conda-forge
conda                     4.7.8                    py37_0    conda-forge
conda-package-handling    1.3.11                   py37_0    conda-forge
console_shortcut          0.1.1                         3
cryptography              2.7              py37hb32ad35_0    conda-forge
decorator                 4.4.0                      py_0    conda-forge
idna                      2.8                   py37_1000    conda-forge
ipython_genutils          0.2.0                      py_1    conda-forge
jsonschema                3.0.1                    py37_0    conda-forge
jupyter_core              4.4.0                      py_0    conda-forge
libarchive                3.3.3             h0005e80_1004    conda-forge
libiconv                  1.15              hfa6e2cd_1005    conda-forge
libxml2                   2.9.9                h9ce36c8_1    conda-forge
lz4-c                     1.8.3             he025d50_1001    conda-forge
lzo                       2.10              hfa6e2cd_1000    conda-forge
menuinst                  1.4.16                   py37_0    conda-forge
nbformat                  4.4.0                      py_1    conda-forge
openssl                   1.1.1c               hfa6e2cd_0    conda-forge
pip                       19.1.1                   py37_0    conda-forge
pycosat                   0.6.3           py37hfa6e2cd_1001    conda-forge
pycparser                 2.19                     py37_1    conda-forge
pyopenssl                 19.0.0                   py37_0    conda-forge
pyrsistent                0.15.3           py37hfa6e2cd_0    conda-forge
pysocks                   1.7.0                    py37_0    conda-forge
python                    3.7.3                hb12ca83_0    conda-forge
python-dateutil           2.8.0                      py_0    conda-forge
python-libarchive-c       2.8                   py37_1004    conda-forge
pytz                      2019.1                     py_0    conda-forge
pywin32                   224             py37hfa6e2cd_1000    conda-forge
pyyaml                    5.1.1            py37hfa6e2cd_0    conda-forge
requests                  2.22.0                   py37_1    conda-forge
ruamel_yaml               0.15.71         py37hfa6e2cd_1000    conda-forge
setuptools                41.0.1                   py37_0    conda-forge
six                       1.12.0                py37_1000    conda-forge
sqlite                    3.29.0               hfa6e2cd_0    conda-forge
tqdm                      4.32.2                     py_0    conda-forge
traitlets                 4.3.2                 py37_1000    conda-forge
urllib3                   1.25.3                   py37_0    conda-forge
vc                        14                            0    conda-forge
vs2015_runtime            14.0.25420                    0    conda-forge
wheel                     0.33.4                   py37_0    conda-forge
win_inet_pton             1.1.0                    py37_0    conda-forge
wincertstore              0.2                   py37_1002    conda-forge
xz                        5.2.4             h2fa13f4_1001    conda-forge
yaml                      0.1.7             hfa6e2cd_1001    conda-forge
zlib                      1.2.11            h2fa13f4_1005    conda-forge
zstd                      1.3.3                    vc14_1    conda-forge

Details about  conda and system ( conda info ):

$ conda info

     active environment : base
    active env location : C:\Users\Jeffrey\Miniconda3
            shell level : 1
       user config file : C:\Users\Jeffrey\.condarc
 populated config files : C:\Users\Jeffrey\.condarc
          conda version : 4.7.8
    conda-build version : not installed
         python version : 3.7.3.final.0
       virtual packages :
       base environment : C:\Users\Jeffrey\Miniconda3  (writable)
           channel URLs : https://conda.anaconda.org/conda-forge/win-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/win-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/win-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/msys2/win-64
                          https://repo.anaconda.com/pkgs/msys2/noarch
          package cache : C:\Users\Jeffrey\Miniconda3\pkgs
                          C:\Users\Jeffrey\.conda\pkgs
                          C:\Users\Jeffrey\AppData\Local\conda\conda\pkgs
       envs directories : C:\Users\Jeffrey\Miniconda3\envs
                          C:\Users\Jeffrey\.conda\envs
                          C:\Users\Jeffrey\AppData\Local\conda\conda\envs
               platform : win-64
             user-agent : conda/4.7.8 requests/2.22.0 CPython/3.7.3 Windows/10 Windows/10.0.18362
          administrator : False
             netrc file : None
           offline mode : False

Actually, I'm getting a similar issue with Qt 5.12, so that might be the real issue. I've opened a new pull request there: conda-forge/qt-feedstock#142

The issue is b/c we did not have jpeg 9c on the main label, only the old epoch, which was removed. I re-added it and I'll trigger a rebuild of jpeg 9c on Widows so we have one in main without the epoch.


python311Packages.llama-index: 0.10.14 -> 0.10.15

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.llama-index is: Data framework for your LLM applications
meta.homepage for python311Packages.llama-index is: https://github.com/run-llama/llama_index/
meta.changelog for python311Packages.llama-index is: https://github.com/run-llama/llama_index/blob/0.10.15/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.10.15 with grep in /nix/store/5ns1vdk9s73z081lbdxczv44qq4qbzzf-python3.11-llama-index-0.10.15
found 0.10.15 in filename of file in /nix/store/5ns1vdk9s73z081lbdxczv44qq4qbzzf-python3.11-llama-index-0.10.15

Rebuild report (if merged into master) (click to expand)

20 total rebuild path(s)

20 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.clarifai
python311Packages.llama-index
python311Packages.llama-index-agent-openai
python311Packages.llama-index-cli
python311Packages.llama-index-core
python311Packages.llama-index-embeddings-gemini
python311Packages.llama-index-embeddings-google
python311Packages.llama-index-embeddings-openai
python311Packages.llama-index-indices-managed-llama-cloud
python311Packages.llama-index-legacy
python311Packages.llama-index-llms-openai
python311Packages.llama-index-multi-modal-llms-openai
python311Packages.llama-index-program-openai
python311Packages.llama-index-question-gen-openai
python311Packages.llama-index-readers-file
python311Packages.llama-index-readers-json
python311Packages.llama-index-readers-llama-parse
python311Packages.llama-index-readers-weather
python311Packages.llama-index-vector-stores-chroma
python311Packages.llama-parse

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5ns1vdk9s73z081lbdxczv44qq4qbzzf-python3.11-llama-index-0.10.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.llama-index https://github.com/r-ryantm/nixpkgs/archive/5f4d406976e3fe9fa7aa3ad3ab3994d611edd4bd.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5f4d406976e3fe9fa7aa3ad3ab3994d611edd4bd#python311Packages.llama-index

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5ns1vdk9s73z081lbdxczv44qq4qbzzf-python3.11-llama-index-0.10.15
ls -la /nix/store/5ns1vdk9s73z081lbdxczv44qq4qbzzf-python3.11-llama-index-0.10.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

40 packages built:

python311Packages.clarifai
python311Packages.clarifai.dist
python311Packages.llama-index
python311Packages.llama-index-agent-openai
python311Packages.llama-index-agent-openai.dist
python311Packages.llama-index-cli
python311Packages.llama-index-cli.dist
python311Packages.llama-index-core
python311Packages.llama-index-core.dist
python311Packages.llama-index-embeddings-gemini
python311Packages.llama-index-embeddings-gemini.dist
python311Packages.llama-index-embeddings-google
python311Packages.llama-index-embeddings-google.dist
python311Packages.llama-index-embeddings-openai
python311Packages.llama-index-embeddings-openai.dist
python311Packages.llama-index-indices-managed-llama-cloud
python311Packages.llama-index-indices-managed-llama-cloud.dist
python311Packages.llama-index-legacy
python311Packages.llama-index-legacy.dist
python311Packages.llama-index-llms-openai
python311Packages.llama-index-llms-openai.dist
python311Packages.llama-index-multi-modal-llms-openai
python311Packages.llama-index-multi-modal-llms-openai.dist
python311Packages.llama-index-program-openai
python311Packages.llama-index-program-openai.dist
python311Packages.llama-index-question-gen-openai
python311Packages.llama-index-question-gen-openai.dist
python311Packages.llama-index-readers-file
python311Packages.llama-index-readers-file.dist
python311Packages.llama-index-readers-json
python311Packages.llama-index-readers-json.dist
python311Packages.llama-index-readers-llama-parse
python311Packages.llama-index-readers-llama-parse.dist
python311Packages.llama-index-readers-weather
python311Packages.llama-index-readers-weather.dist
python311Packages.llama-index-vector-stores-chroma
python311Packages.llama-index-vector-stores-chroma.dist
python311Packages.llama-index.dist
python311Packages.llama-parse
python311Packages.llama-parse.dist

Maintainer pings
cc @fabaff for testing.

Already on master.


Add support for noDeploy option

Add some checks and don't run any Lambda updateFunctionConfiguration calls if noDeploy is specified.

Coverage increased (+0.5%) to 96.923% when pulling 098da88cea19bc008c85eb1be49b0f35fe0edea5 on noDeploy into 4b7f1fd9c00dd51fe02dcafe8592df1e8c9182a7 on master.

Coverage increased (+0.5%) to 96.923% when pulling 098da88cea19bc008c85eb1be49b0f35fe0edea5 on noDeploy into 4b7f1fd9c00dd51fe02dcafe8592df1e8c9182a7 on master.


updated sample-pipeline and kyverno based on chains update. Added Sample-pipeline to integration test

Updated the sample-pipeline such that it can be deployed into the prod namespace. The Kyverno attestation checker policy will check that the image is signed and the provenance format matches. The integration test will help ensure that kyverno policy is always tested in each PR.

Updates being made for kyverno Image also as there are cosign errors:
I0112 21:26:20.939475       1 imageVerify.go:171] EngineVerifyImages "msg"="verifying image" "kind"="Pod" "name"="ssf-lab-pipelinerun-jvbcm-build-and-push-image-8sw4j-pod-mdkp6" "namespace"="default" "policy"="verify-image" "image"="gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.29.0@sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561"
I0112 21:26:21.677681       1 cosign.go:411] EngineVerifyImages "msg"="failed to extract image issuer from verification response" "kind"="Pod" "name"="ssf-lab-pipelinerun-jvbcm-build-and-push-image-8sw4j-pod-mdkp6" "namespace"="default" "policy"="verify-image" "image"="gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.29.0@sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561" "payload"={"critical":{"identity":{"docker-reference":"gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint"},"image":{"docker-manifest-digest":"sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561"},"type":"Tekton container signature"},"optional":{}}
I0112 21:26:21.678078       1 cosign.go:423] EngineVerifyImages "msg"="failed to extract image subject from verification response" "kind"="Pod" "name"="ssf-lab-pipelinerun-jvbcm-build-and-push-image-8sw4j-pod-mdkp6" "namespace"="default" "policy"="verify-image" "image"="gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.29.0@sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561" "payload"={"critical":{"identity":{"docker-reference":"gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint"},"image":{"docker-manifest-digest":"sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561"},"type":"Tekton container signature"},"optional":{}}

Updates being made for kyverno Image also as there are cosign errors:
I0112 21:26:20.939475       1 imageVerify.go:171] EngineVerifyImages "msg"="verifying image" "kind"="Pod" "name"="ssf-lab-pipelinerun-jvbcm-build-and-push-image-8sw4j-pod-mdkp6" "namespace"="default" "policy"="verify-image" "image"="gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.29.0@sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561"
I0112 21:26:21.677681       1 cosign.go:411] EngineVerifyImages "msg"="failed to extract image issuer from verification response" "kind"="Pod" "name"="ssf-lab-pipelinerun-jvbcm-build-and-push-image-8sw4j-pod-mdkp6" "namespace"="default" "policy"="verify-image" "image"="gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.29.0@sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561" "payload"={"critical":{"identity":{"docker-reference":"gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint"},"image":{"docker-manifest-digest":"sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561"},"type":"Tekton container signature"},"optional":{}}
I0112 21:26:21.678078       1 cosign.go:423] EngineVerifyImages "msg"="failed to extract image subject from verification response" "kind"="Pod" "name"="ssf-lab-pipelinerun-jvbcm-build-and-push-image-8sw4j-pod-mdkp6" "namespace"="default" "policy"="verify-image" "image"="gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.29.0@sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561" "payload"={"critical":{"identity":{"docker-reference":"gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint"},"image":{"docker-manifest-digest":"sha256:66958b78766741c25e31954f47bc9fd53eaa28263506b262bf2cc6df04f18561"},"type":"Tekton container signature"},"optional":{}}

Looks like these warning just needs to be suppressed. These will be fixed in later release.

Looks like the spire update broke this integration test. I will update

Fixed Integration Test


Issue with Not-Nullable text fields: forms don't let you leave them empty

This will sound similar to #1003, but the latter had to do with nullable fields, while this issue has to do with not-nullable fields.
For databases, NULL is not the same as an empty string. There are benefits to having NOT NULL fields that default to an empty string, and it's quite a common practice.
In this gist, some rows are successfully created that have NOT NULL fields populated with empty strings. For variety, for the nickname field the empty string is explicitly provided, while for the notes name it is populated by the database because the default value is set.
Now if you click edit on one of the rows, you won't be able to leave nickname or notes as an empty string, even though they are already empty. Likewise, if you try to create a new record, you can not provide an empty string.
This should be feasible for both fields, whether or not the default value is set to an empty string.
If you feel the user should understand that an empty string will be created for this required field (marked with a red asterisk), maybe a greyed out <empty string> could appear in the form.

For anyone who is not familiar with the common practice of NOT NULL fields with empty strings as default values, I have scanned this page from High-Performance MySQL, 3rd edition (a bible for MySQL).

Looks like this pull request is related: #964

Wow, yes, thanks, you are quite right!
One difference is that #1013 focuses on the default value being an empty string. But NOT NULL fields should accept empty strings even if their default value is Nicaragua.

@pawl Thank you you for the patch! Without testing extensively, when setting server_default=text("''"), your fix seems to be working perfectly. :)
Also, kudos to the rest of the flask-admin team on releasing 1.3!
Would you say that the list of closed issues is the best place to look for a change log between 1.2 and 1.3? Are there some particular new features that stand out in your mind?
Many thanks, will keep exploring.

@boolbag I've been working on a presentation with details about the 1.3.0 release: http://imgur.com/a/7ui6P
mrjoes also put release notes here: https://github.com/flask-admin/flask-admin/releases

Thank you @pawl ... That's terrific! :)


Fixed BackOffice Notification when Settings disable it

:warning: Test IT After PrestaShop/PrestaShop#19037

Questions
Answers

Description?
Fixed Favicon Notification number when Settings disable it

Type?
bug fix

Category?
BO

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/PrestaShop#18938

How to test?
1. Menu - Configure -> Advanced Parameters -> Administration2. Define Notifications On for new Messages, but Off for new Customers and Orders.3. On FO, make a new order4. BEFORE The number increase4. AFTER The number take settings for displaying notifications

I reuse Core notifications controller instead of this useless controller for https://github.com/PrestaShop/ps_faviconnotificationbo/pull/13 so change applied on your core pull request should be work with my work

@Matt75 In this case, I close my PR.


Support for new bcs output layout

This PR is addressing changes implemented in GEOSgcm_GridComp PR#729. Changes in that PR affect boundary conditions package output layout. To be able to do restart remapping using python tools we developed we had to add support for that new bcs output structure.
Updated 12 May 2023 by @gmao-rreichle: Applied "Contingent - DNA" label to indicate that this PR should be merged after PR #14.  @sdrabenh, please remove "Contingent - DNA" label when you're ready to merge this PR.

Sure I will work on this and let you know

My latest commit merged branch hotfix/mathomp4/fix-topo-link into branch feature/wjiang/new_bcs_structure associated with the present PR.  I manually resolved a conflict in pre/remap_restart/remap_upper.py.
The reason for the commit was to avoid the merge conflict when this PR is merged into main after PR #14  has been merged.
Keeping my fingers crossed that I didn't mess things up.  If I did, it only impact the  remap_restarts python package and would not impact 0-diff testing in any way.

@gmao-rreichle I've tested ten different cases, and all passed. Few to use the new BCS output layout. Few use the BCS legacy layout. Few stretched grids. Few to confirm regrid.pl and remap_restarts.py are zero diff for cases I've picked. I think this is good to go as it is. I didn't focus in this PR on testing very fine cases since those sometimes take a long time to start running with long q times when submitting to allnccs q.

@gmao-rreichle I've tested ten different cases, and all passed. Few to use the new BCS output layout. Few use the BCS legacy layout. Few stretched grids. Few to confirm regrid.pl and remap_restarts.py are zero diff for cases I've picked. I think this is good to go as it is. I didn't focus in this PR on testing very fine cases since those sometimes take a long time to start running with long q times when submitting to allnccs q.

Thank you all for testing.
Please confirm it includes ALL cases- including coupled, specifically MOM6.

Please confirm it includes ALL cases- including coupled, specifically MOM6.

@sanAkel:  I'm not sure where we are with coupled grids, but note that we still have the following pending:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/695
This probably still depends on some input from the coupled modeling team.

@sanAkel New BCS output layout won't work with coupled grids until we tweak few more things, merge PR @gmao-rreichle referenced, and further cleanup of Python code to eliminate MOM5/MOM6 option separation. With that one, I was waiting on a few things, one MIT grid, so we do all of them together. Two, don't forget we also wait on @lcandre2 to provide updated river routing information that will produce the correct TRN file so new BCS outputs have accurate coupled grids without the need for manual updating. The old BCS legacy layout works with regrid.pl since we didn't change that and it also work with python. In short coupled grids are on our to-do list if we want to have them and use them in new layout. But soon we should have those as well.

@sanAkel New BCS output layout won't work with coupled grids until

Ok, @gmao-rreichle, @biljanaorescanin, can I still run withOUT: New BCS output layout?

@sanAkel this PR doesn't break any capability remap_restarts.py already has.
New output layout bcs option is added feature for python code.
Since you use the python package you can test and check it yourself, the more people are testing something the more confidence we can have it works as we hope. I can't test all the cases and maybe in some case something is not right, I do my best to cover all the options but maybe I missed something. Please let me or @weiyuan-jiang if you find something is not right.

Now that I've checked I indeed didn't run any coupled cases. I can try those and update once I know more.

Now that I've checked I indeed didn't run any coupled cases. I can try those and update once I know more.

Thank you @biljanaorescanin
Tomorrow I'll clone this branch and test myself.
Will update when ✅.

Now that I've checked I indeed didn't run any coupled cases. I can try those and update once I know more.

Thank you @biljanaorescanin
Tomorrow I'll clone this branch and test myself.
Will update when ✅.

The algorithm searches the air grid and ocean grid for the BCs. But I found out there are too many subdirectories with the same agrid and ogrid.  For example here  /discover/nobackup/projects/gmao/ssd/aogcm/atmosphere_bcs/Icarus-NLv3/MOM6//   . I suggest to clean up the directories clean. i.e. , move those "bad", "save" to other location.


⚠ Bofrost.be has degraded performance

In 497e7cf, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2488 ms

Resolved: Bofrost.be performance has improved in 58fc7ac.


Split sign and verify packages

Move public key validation logic to signed package
Split signed package into sign and verify packages
Use Verifiers to check key validity instead of hard-coding Ed25519.

LGTM


Initialize custom_checks_status

We've recently hit this issue:
2021-03-12 16:32:40,706 [INFO] Exception: local variable 'custom_checks_status' referenced before assignment

The variable custom_checks_status needs to be initialized before so that we don't hang when custom_checks is disabled.

Can one of the admins verify this patch?


Adding terraform language server

Pull request for adding terraform language server. I hope it is enough to start it with ["/usr/bin/terraform-ls", "serve"] to integrate it with lspcontainers.
Thanks for greater making the lspcontainers integration with neovim it is nice to not need to install all the ls local on my computer..

Yeah of course! This is great as it is also the first LSP to use scratch as a final image. I'm curious to see how well this works as it's something I've been considering doing for LSPs that it would work with.


Add theme changer based on time

Description of the new feature / enhancement
The expected behaviour of this new feature is to automatically change the users Windows theme (Dark mode or Light mode) depending on the users time.
Here's my ideas for the new features settings:
The first option:
To enable it/disable it. Of course.
Second option:
The second option is supposed to have 2 fields (text fields/input fields, only accepting numbers and a colon divider, I'll explain why right now), the first field is supposed to be the time dark mode turns on (at that time), and the second one is supposed to be the time dark mode turns off and switches to light mode (... at that time)
Scenario when this would be used?
The scenario when this would be used is:

Everyday use. (Good for... eyes? I forgot.)
It's just so much better with this new feature.

How is this important to the workflow as a power user?
It's benefitial and it's going to be easier to see things when, I don't know, the sun shines at your screen for example, that would make it hard to see.
Supporting information
Let me know if this is a duplicate.
Anyway, here's some artwork for how its supposed to look like:

Hi @Hedreon.
Have you tried Windows Auto Dark Mode?

Hi @Hedreon. Have you tried Windows Auto Dark Mode?

I will use that for now, until PowerToys accepts this feature request and adds that feature.

Duplicate of #1331


Panel size change on dual screen when i swich

Hi,
I have a dual screen configuration with sway. One waybar panel is displayed on each of them. But when i switch from one screen to another, the size of waybar panel seem to loose one or two pixel on the screen i left.
Best regards,

Could you please attach your style.css so I can test this?

My style.css:

{
font-family: Iosevka Term Bold;
font-size: 13px;
font-weight: bold;
background: #111111;
color: #f4d3bd;
padding: 0 4px;
}
#workspaces button {
padding: 0 0px;
}

#workspaces button.visible{
border-bottom: 3px solid #dc5757;
}
#workspaces button.focused {
border-bottom: 3px solid #dc5757;
}
#mode {
background: #f9807a;
border-bottom: 3px solid red;
}

I tested some configurations of style.css since my first post and the problem disappeared. I'm not sure this is a bug and in that case, i can't reproduce it anymore...I closed the issue.

Glad you got it sorted out. I could also not reproduce it.
I can only imagine, that you had different styles for #workspaces button.visible and #workspaces button.focused that resulted in a different heigth.


Set of geohashes returned for polygon with narrow sections does not cover the full polygon

Hi! I have been using this library to convert administrative polygons into sets of geohashes. Before I describe my issue, I want to thank you for creating/contributing to this library - I am grateful that I don't have to write these kinds of functions from scratch for the work I'm doing!
I noticed that the set of level 7 geohashes I received for a polygon of the city of Boston, MA, omits a significant section of the city. The polygon is in blue, and the outline of the resulting level 7 geohashes is in orange.

I was wondering if the algorithm for converting polygons to geohashes is thrown off by the fact that there is a very narrow stretch of the polygon where it's possible that no level 7 geohashes fit. When I set inner=False, it worked as expected and gets me all the geohashes that cover the polygon. However, I would prefer to have the set of geohashes that are specifically within the polygon, even if there are no level 7 geohashes covering that one narrow stretch of polygon. In other words, it would be nice to have all geohashes within the polygon, even if they aren't all contiguous with other.
Attached below is a text file with the WKT string of the polygon I'm using, so that people can replicate the issue if needed. I am thinking of forking this repo and playing with the code myself once I have more time, so any response pointing out where the issues in the code the issue might be would be helpful. Even if other people don't have the capacity to debug this issue themselves, that would help me test some different approaches myself. I'll update this issue if I get the chance to work on this issue myself.
boston_wkt.txt

Upon further review, my issue was with another part of my code not having to do with the polygon-geohasher library. Closing this issue!

Thank you Ethan, I did not have to investigate it but thank you for closing
the ticket!
On Mon, Sep 19, 2022 at 8:40 PM Ethan McIntosh @.***>
wrote:

Closed #16 https://github.com/Bonsanto/polygon-geohasher/issues/16 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/Bonsanto/polygon-geohasher/issues/16#event-7418019685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACEE34WKRB6DMIZQABBUZBDV7EIZZANCNFSM6AAAAAAQNQB2BY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


Fix click-to-seek for audios which are not spanning the entire canvas

Solves #686

Coverage decreased (-0.04%) to 4.914% when pulling 0da329dbebc5f12225cf8518d076c246c0718bd2 on whenov:master into b0d8457837d346e20788294b74a32e93e91e7fdb on katspaugh:master.

Coverage decreased (-0.05%) to 4.908% when pulling c500aba6646f4744dba72817a9ee62bd02aea756 on whenov:master into b0d8457837d346e20788294b74a32e93e91e7fdb on katspaugh:master.

Nice, thanks!


fix: composing text input interruption when editor is at composing state

When I type some Chinese for appending text to HashtagNode (Editor is in composing state), lexical should prevent default action and stop inserting text for TextNode.
https://user-images.githubusercontent.com/1413056/181918441-07c6bcf2-785f-469e-b11e-07e2a11c2699.mov

This doesn't seem like the right fix. We definitely want composed text to not go to the default place, and instead modify the selection during compositionstart instead?

Closing due to inactivity - feel free to re-open if someone wants to pick this back up.


Remove a space at the end of the line.

Coverage remained the same at 100.0% when pulling 8b01a987900d981d696a9e7d2f735e9ae2190500 on eol-space into 4be01234d0e607d9869bc58511d1daa9a74217c9 on master.


tests fail when using getDerivedStateFromProps

Describe the bug
When using componentWillReceiveProps the enzyme tests run perfectly, however the moment we change the component to utilise getDerivedStateFromProps the component test fails.
To Reproduce
Steps to reproduce the behavior:

run test with component lifecycle

componentWillReceiveProps(nextProps) {
    this.setState({ activeTabIndex: nextProps.defaultActiveTabIndex || 0 });
}

test passes

run test with component lifecycle

static getDerivedStateFromProps(props, state) {
    if (props.defaultActiveTabIndex === state.activeTabIndex) {
        return null;
    }
    return { activeTabIndex: props.defaultActiveTabIndex || 0 };
}

test fails
Expected behavior
Test should pass?
Sorry if this is a crappy report, i tried to fill it in as best I could.

@Tasemu
Which API do you use? shallow or mount?
Could you create a test case to reproduce this?

@Tasemu in the future, please fill out the entire issue template.
Could you provide the full component code, and the relevant test?

i am seeing a similar issue when shallow rendering. Enzyme may only be calling the shallow component's getDerivedStateFromProps on mount but not again on re-renders (via component.update())

@swese44 "shallow component on mount" - are you using shallow(), or mount()?

@swese44 so you shallow render, it calls gDSFP, but then you call wrapper.update() after setting props, and it doesn't call it again?


Boolean Matrix

🚀 Feature
An article on Boolean Matrix
Have you read the Contributing Guidelines on Pull Requests?
Yes

Please assign me sir @HarshCasper @iamrajiv @atarax665 @ankitaggarwal23


DX213 not working on DS723+ after update

Hello,
I have been using your script for a while now with lots of pleasure on my DS723+ and DX213. So i can also confirm for you that your script is working on a DS723+ with a DX213.
Unfortunately, after updating to DSM version: 7.2.2-72806, i can not get it working anymore.
It gives a message that it found an incompatible expansion unit and that i need to replace it with a compatible one. This was also before i first started using your script.
I am using your script as a triggered task and it was working fine on DSM version: 7.2.1-69057 Update 5.
I have already deleted the task and made a new one but it doesn't help.
I hope you have a solution for me.
Kind regards.
PS. i am not a programmer so please forgive me if i don't understand all. Also the system language is in dutch on the screenshots ;-)

After updating DSM you need to run the script then reboot.

Thanks for your message.
I thought that i have already tested that but not sure.
I'll let you know.

I have tried your solution but still it's not working.
Any other suggestions?

Could it have something to do with the last DSM update?
Richard

So as a noob i started to work with terminal commands via putty and now i got it working. Still a huge thank you for this script so i can use the expansion unit on my DS723+.
Should have supported you earlier but better late than never:-)


Modules UI changes

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR primarily focuses on enhancing the user interface and functionality of the Transferable, Claimable, and Royalty modules. It introduces new components for sequential token IDs, updates the handling of royalty percentages, and improves user feedback mechanisms.
Detailed summary

Added conditional rendering for warning alerts in Transferable.
Introduced SequentialTokenIdFieldset for managing token IDs.
Updated Claimable to handle ERC20 alongside ERC721.
Modified royalty handling to use percentage instead of basis points (BPS).
Enhanced input fields with percentage display and validation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Linear ticket please


Does not work out of the box without termguicolors

Describe the bug
With my config, I can only get illuminate to visually work when I :set termguicolors.
Is there a specific set of highlight groups my colorscheme must define for illuminate to work?
To Reproduce
Steps to reproduce the behavior (include minimal init.vim or .vimrc):

Load https://github.com/kovasap/dotfiles/blob/master/.vim/init.lua
Open a file
Mouse over a symbol

Output from :IlluminateDebug
buf_should_illuminate 1 true
config {
  case_insensitive_regex = false,
  delay = 100,
  filetype_overrides = {},
  filetypes_allowlist = {},
  filetypes_denylist = { "dirbuf", "dirvish", "fugitive" },
  min_count_to_highlight = 1,
  modes_allowlist = {},
  modes_denylist = {},
  providers = { "lsp", "treesitter", "regex" },
  providers_regex_syntax_allowlist = {},
  providers_regex_syntax_denylist = {},
  under_cursor = true
}
started true
provider table: 0x7fdf32031330 treesitter
`termguicolors` false

Expected behavior
Common symbols should illuminate on mouse over.

That is not a minimal config, your colorscheme is likely the issue.

Yes I realize that - by filing this issue I was hoping to learn more about
what illuminate requires from a color scheme to work.  That would help me
figure out what I would need to change with my color scheme.  Are these
requirements documented anywhere?
On Tue, Jul 30, 2024, 2:31 PM Adam Regasz-Rethy @.***>
wrote:

That is not a minimal config, your colorscheme is likely the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/RRethy/vim-illuminate/issues/207#issuecomment-2259247167,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACC3NAUWI6A2UX3VZOPTCEDZPAA2ZAVCNFSM6AAAAABLW5TQ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGI2DOMJWG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Turns out my issue was that I was defining the illuminate highlight groups like in the readme:
vim.cmd('hi IlluminatedWordText gui=underline')
vim.cmd('hi IlluminatedWordRead gui=underline')
vim.cmd('hi IlluminatedWordWrite gui=underline')

When I should have been doing:
vim.cmd('hi IlluminatedWordText cterm=underline')
vim.cmd('hi IlluminatedWordRead cterm=underline')
vim.cmd('hi IlluminatedWordWrite cterm=underline')


Permision Denied S3 with admin user

Here is the terragrunt hcl.  This was for a demo so I am not worried about data
Generated by Terragrunt. Sig: nIlQXj57tbuaRZEa
terraform {
backend "s3" {
dynamodb_table = "terraform-state-dev"
encrypt        = true
key            = "./terraform.tfstate"
region         = "us-east-2"
bucket         = "terraform-dmitdemo-dev"
}
}
Here is the error I get.
1.) The user is an admin though so I am not sure how it is denied.
2.) Terragrunt created the S3 bucket to begin with.
Error refreshing state: AccessDenied: Access Denied
status code: 403, request id: 54448C00919BBEB4, host id: xXpmDCZDk/GmqQhoyraaQdLIBO1377BmYuV76+2XQ1nt5cBMhz7mWlWtZhhd4pja1KJaacswZBs=
[terragrunt] 2021/01/02 23:15:43 Hit multiple errors:

This is a bit hard to debug without seeing the terragrunt config (what you have in terragrunt.hcl, remote_state block), but I would sanity check your account config to make sure the bucket is in the right account.

This is a bit hard to debug without seeing the terragrunt config (what you have in terragrunt.hcl, remote_state block), but I would sanity check your account config to make sure the bucket is in the right account.

I'm having the same issue after upgrading terragrunt from 0.23.38 to 0.27.3: The bucket is in the same flat account as before and was created by the same user with the admin role (we don't use organisations, terraform get's it's api credentials from the environment)
My remote_state block is:
remote_state {
  backend = "s3"
  config = {
    bucket         = "some-name-tfstate"
    key            = "${path_relative_to_include()}/terraform.tfstate"
    region         = "eu-central-1"
    encrypt        = true
    dynamodb_table = "terraform-some-name-tflock"

    skip_metadata_api_check     = true
    skip_region_validation            = true
    skip_credentials_validation.   = true
  }
}

Found my issue which was not related to terragrunt: some idiot (me) disabled the wrong api credentials....

Closing this as the original question has been answered. If there are any follow ups, please open a new ticket with updated context. Thanks!


feat: event logs clean

Signed-off-by: xu.jingwen<EMAIL_ADDRESS>
What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #255
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

Merging #256 (6b1755c) into master (f1cb534) will decrease coverage by 0.01%.
The diff coverage is 30.55%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   13.12%   13.11%   -0.02%
==========================================
  Files          98       98
  Lines       15341    15362      +21
==========================================
+ Hits         2014     2015       +1
- Misses      13088    13108      +20
  Partials      239      239

Impacted Files
Coverage Δ

pkg/cli/deploy/deploy.go
5.69% <0.00%> (-0.03%)
:arrow_down:

pkg/models/platform/platformsetting.go
7.21% <0.00%> (-1.65%)
:arrow_down:

pkg/auditing/audit.go
28.50% <78.57%> (+0.77%)
:arrow_up:

pkg/apis/core/v1/handler.go
0.33% <0.00%> (-0.01%)
:arrow_down:

/cc @x893675

/cc @lixd

/milestone v1.3.1

/approve


A little mistake in HyperParams

Maybe the file "rome/rome_hparams.py", line 56 need to be modified into  gpt-j-6b.

Fixed.


Label resizing with dynamically loaded fonts

Hi,
This is more of a heads up than an actual issue (and this is probably more related to how dagre renders labels, but this may be of interest for mermaid), but if you use dynamically loaded fonts that are loaded through CSS, such as Google fonts, mermaid should wait for the whole page to have been loaded (dom + assets, particularly the font files).
Thus, developers that integrate mermaid into their own page should use
$(window).load(function() {
	mermaid.initialize();
});

over
$(document).ready(function() {
	mermaid.initialize();
});

Not doing so will most likely result in mermaid rendering graphs that have labels out of bounds.
Using ready

Using load

Thanks @tomzx. That's a good point. I think this should be pointed out in the docs.
Also I think the domContentLoaded used by mermaid should be changed to loadEvent.
So good input, thanks.

Using the load event in mermaid now.

Closing issue as it's resolution is included in release 0.5.6. Let me know if you do not agree.


ati_unfree: doesn't work with some display managers

Data so far:

OK: lightdm;
KO: kdm, gdm.

For details see https://github.com/NixOS/nixpkgs/issues/9903#issuecomment-223483656

related, a few months ago, i found that ati_unfree 'worked' with slim+xfce, but the instant i enabled dual-monitor, it segfaulted X and left the gpu in a bad state
attempting to restart X caused the kernel to hang solid
and then upon rebooting, slim worked fine, i logged in, and xfce restored the monitor state, crashing it again!

cc @ocharles

Thanks @domenkozar, this was exactly my problem. I'm now using ati_unfree with lightdm successfully. In the meantime, could we perhaps just throw an exception if someone tries to build a configuration.nix with ati_unfree and KDM or GDM?

Unsure if related, but prior to using ati_unfree I had services.xserver.enable = true; with XMonad enabled as my window manager. Seemed to be working fine, then I set:
nixpkgs.config.allowUnfree = true;

services.xserver.videoDrivers = [ "ati_unfree" ]

did a nixos-rebuild switch followed by a reboot, and now X doesn't seem to want to start anymore, I just get dropped into a shell as if X was never enabled.
Any ideas?

Are you using a display manager?  Do you see the same stack trace as in https://github.com/NixOS/nixpkgs/issues/9903#issuecomment-223483656?

Linux 4.9, LightDM and Xfce works, but performance is very bad. https://github.com/NixOS/nixpkgs/issues/49726#issuecomment-485301170

ati_unfree removed https://github.com/NixOS/nixpkgs/commit/7117588d2666f975e8239d0aebd8a9dc7d73a7cf


Java Compiler and Android error when build the project with RxGps

Hello, I got the error message below
Java Compiler
com.android.builder.dexing.DexArchiveBuilderException: Failed to process /Users/.gradle/caches/transforms-1/files-1.1/rxgps-1.0.2.aar/9ec52c309174054150f40843f57f8146/jars/classes.jar
com.android.builder.dexing.DexArchiveBuilderException: Error while dexing.
com.android.tools.r8.CompilationFailedException: Compilation failed to complete
com.android.tools.r8.utils.AbortException: Error: Invoke-customs are only supported starting with Android O (--min-api 26)
Android Error
Invoke-customs are only supported starting with Android O (--min-api 26)
My culprit is, I use both RxPermission and RxGps altogether.

This is my mistake. Only need to add compile option to solve this issue.
compileOptions {         sourceCompatibility JavaVersion.VERSION_1_8         targetCompatibility JavaVersion.VERSION_1_8     }


Fix linting

@RedHatProductSecurity/corgi-devs Copied from Adrian's recent MR: https://github.com/RedHatProductSecurity/osidb/pull/32

Fixes an issue with pip-compile which would add the index-url to requirements.txt files when compiling deps.
Adds the flake8-django plugin which provides extra checks for common Django mistakes
Removes unused ignored errors from the flake8 tox config
Removes various "type: ignore" and "noqa" annotations
Fixes various warnings from flake8, mypy, Pycharm, etc.

modulo open conversations, LGTM


Add a light bundle version

For people who don't need jQuery otherwise, it's a bit non-green to load the full jQuery script. Prepare a non-dependant bundle version (using jbone instead?).

Using Vue.js will lead to abandoning jQuery.


Add support for Django 5.0

This allows the test suite to pass. However this can't be merged as is. The command list_signals should probably be updated to include the is_async descriptor in its output somewhere. You can see how the Signal.receivers list of tuples was modified to include is_async here: https://github.com/django/django/blob/stable/5.0.x/django/dispatch/dispatcher.py#L116
If you want to make the change for list_signals on your own, I won't be offended. If you'd like me to make the change, I will try to make more time for it in the future.

I've hit an issue with Django 5.1, noticed that 5.0 support was missing and ended up finding this PR. I've opened a PR targeting this branch: https://github.com/django-extensions/django-extensions/pull/1842


pigpio daemon performance optimization

Hi,
I wanted to ask how it is possible to optimize performance of pigpio daemon and respective pigpio module used in a python script.
My specific goal is to have the best timing performance using the SPI function.
I looked at pigpio daemon launch option but it is still not clear to me what kind of effect they have on performance.
Thanks

best timing performance

This is very subjective so can you please start by telling us what your requirements are and what you have tried so far.

Please note that pigpio uses its own SPI driver (the Linux SPI driver was not available on the Pi at the time).  Now you may get better performance by using the standard Linux SPI driver.  Which is "better" will depend on the details of your SPI transfers.

If there is any issue or follow up question please re-open.


chore(docs): update Teleconsultation Service Frontend documentation

chore(docs): update Teleconsultation Service Frontend documentation

This is ready to be merged


Tabular: Added extra_metrics argument to leaderboard

Issue #, if available:
Description of changes:
Added extra_metrics argument to leaderboard
Example:
leaderboard = predictor.leaderboard(test_data, extra_metrics=['accuracy', 'log_loss', 'roc_auc', 'balanced_accuracy'])

Output:
                 model  score_test  accuracy  log_loss   roc_auc  balanced_accuracy  score_val  pred_time_test  pred_time_val  fit_time  pred_time_test_marginal  pred_time_val_marginal  fit_time_marginal  stack_level  can_infer  fit_order
0  WeightedEnsemble_L2    0.873784  0.873784 -0.292128  0.925894           0.780252     0.8816        0.100835       0.049910  1.098830                 0.003269                0.005020           0.283787            2       True          3
1             LightGBM    0.873375  0.873375 -0.278360  0.929259           0.789940     0.8800        0.049563       0.028269  0.637271                 0.049563                0.028269           0.637271            1       True          2
2           KNeighbors    0.773160  0.773160      -inf  0.670251           0.621414     0.7752        0.048003       0.016621  0.177772                 0.048003                0.016621           0.177772            1       True          1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1058-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1058/1/index.html


Update voice-design.md

OPS Build status updates of commit 0c8b02c:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 0c8b02c:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit 0c8b02c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/voice-design.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


AKV security is poorly covered.  Also Access Policies plane has been renamed

AKV can use KV security, or role based.  We need proper instructions more more than a warning box.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f84b158e-eebc-7d96-0992-8864316ddf5c
Version Independent ID: 8909ba9b-bf26-fb5c-29f0-76244984e75a
Content: Tutorial - Configure your tenant for Microsoft Entra Verified ID - Microsoft Entra
Content Source: articles/active-directory/verifiable-credentials/verifiable-credentials-configure-tenant.md
Service: decentralized-identity
Sub-service: verifiable-credentials
GitHub Login: @barclayn
Microsoft Alias: barclayn

@maurice-cote
I've delegated this to @barclayn , a content author, to review and share their valuable insights.

@maurice-cote thank you for your feedback. I have created a work item for us to track internally and update the screenshots #please-close


⚠ Bofrost.fr has degraded performance

In a1be895, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1093 ms

Resolved: Bofrost.fr performance has improved in 934a329.


invoke git_aggregate with --force.

Some repositories appear dirty to me without knowing the cause, downloading only for version 13.0 without any added repository.
git-aggregat has the --force option to continue even if there are dirty repositories.
How can we incorporate this parameter into invoke?
Regards.

First it has to be supported in the autoaggregate script.
Then we have to add it here to the task.
Then I'll release a new template version and you'll have to update your subproject.
PRs welcome!

I don't know how doodba works inside, I am trying to see the code and understand it, but I still lack knowledge, which I hope to acquire.
On the subject of --force maybe it should be included as an option, everyone doesn't like it anyway.
I would like to know how I can do a fork (that if I can do it), and test the changes locally. Can I look at some documentation about it?
Thank you very much for sharing this great project with the community.

@Yajo is on holidays. For forking, you have to fork the project and publish your fork in a Docker registry, but that's out of the scope of this issue tracker.

Fork is not the problem.
I hope @Yajo enjoys his well-deserved vacation.

What is the problem then?

The problem is my lack of knowledge to carry out a PR that includes that modifier, I still have a lot to learn.

OK, then you can do the reset manually meanwhile in your local environment. I don't get anyway why you get to that situation, as normal use shouldn't lead to that.

I don't know the reason but it always tells me it's dirty addons / website_membership / __ init__.py
odoo_1  | From https://github.com/OCA/OCB
odoo_1  |  * branch              13.0       -> FETCH_HEAD
odoo_1  |    2b58db81..3b43934c  13.0       -> ocb/13.0
odoo_1  | (INFO) [11:17:27] git_aggregator.repo  odoo   Checking repo status
odoo_1  | Traceback (most recent call last):
odoo_1  |   File "/usr/local/lib/python3.6/site-packages/git_aggregator/main.py", line 204, in aggregate_repo
odoo_1  |     repo.aggregate()
odoo_1  |   File "/usr/local/lib/python3.6/site-packages/git_aggregator/repo.py", line 189, in aggregate
odoo_1  |     self._reset_to(origin["remote"], origin["ref"])
odoo_1  |   File "/usr/local/lib/python3.6/site-packages/git_aggregator/repo.py", line 236, in _reset_to
odoo_1  |     self._check_status()
odoo_1  |   File "/usr/local/lib/python3.6/site-packages/git_aggregator/repo.py", line 223, in _check_status
odoo_1  |     raise DirtyException(status)
odoo_1  | git_aggregator.exception.DirtyException:  M addons/website_membership/init.py

That's probably due to permissions in the filesystem. Probably you are not using a native Linux filesystem, but other like FAT, NTFS, Samba, etc.
Anyway, closing this for having the issue tracker as there's no plan for now of adding this option and the source problem comes from other thing.

Hi, the issue is still valid.  That's a feature, otherwise the command could blindly remove some of your changes forever, and it's meant to be run in a development environment, so that's not very cool.
Adding a --force option makes sense in case you're conscient about what will happen.

I don't like to keep issues for wishlists forever if nobody is going to attend it, so please put this in any kind of roadmap and close the issue.

I've already solved my problems with dirty repositories, if the --force option can backfire, you can close this issue.


add file_type param for markdown files to call to excel_to_template

the build check is failing because of what I think is a change to EMLassemblyline's requirements having to do with taxonomyCleanr. I will need to fix the build on this end before I can merge the PR.


feat: Add support to include files in configs

This commit implements support for Butane configs that include local files as file or systemd-unit contents:
variant: fcos
version: "1.5.0"
storage:
  files:
    - path: /some/path
      contents:
        local: ./some.file
systemd:
  units:
    - name: some.service
      contents_local: ./some-unit.service

Since files are included relative to the directory specified by the FilesDir argument, this only works if said argument is set.
As it stands today, Butane configs as outlined above will throw an error message.

I've declined this before if you check PRs
https://github.com/poseidon/terraform-provider-ct/pull/151#issuecomment-1478758865

I see - I did not check PRs before opening this, my bad.
I have to agree with arlyon though; trying to produce valid YAML by using text templates, that feels just like Helm all over again ...


notifications are not shown when there are errors in the data of a new user

Hello, congratulations for this amazing project. The issue is when you want to register a new user when clicking on register the page only returns to the login page, but does not show any notification to the user of what happened so that he can know what the error is and can correct them , I also consider that it should not return to the login page if there is an error to give the user the opportunity to correct the errors and not rewrite all the fields again. I don't know if this only happens to me, anyway thanks for your attention. Regards

Hello, I think I found a solution, comment the line where a redirection to the login page is made, about the JwtAuthenticationHeaderHandler class, I think that the access control to pages that do not have anonymous access is done from App.razor.
It is not that there is an error in not showing the validations, but that before we can see them the application had already made the redirection to the login page, I consider that this change does not affect the complete operation of the application.

Ok, I was already thinking it had probably something to do with that... but I commented out the other part (in App.razor) in stead... but that got me nowhere... didn't think about the JwtAuthenticationHeaderHandler...
I see I actually made that change where that navigateTo("/login") happens. GetAccessToken returns null means that the user isn't authenticated, so it should redirect to login in that case...
I think the issue here is rather that the authorization header doesn't need to be set for the "SelfRegister" call, just like it isn't set for the "tokens" calls... so I think the change should be something like
    protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
    {
        // skip token and self-register endpoints
        if (request.RequestUri?.AbsolutePath.Contains("/tokens") is not true &&
            request.RequestUri?.AbsolutePath.Contains("/self-register") is not true)
        {
            if (await _tokenProviderAccessor.TokenProvider.GetAccessTokenAsync() is string token)
            {
                request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", token);
            }
            else
            {
                _navigation.NavigateTo("/login");
            }
        }

        return await base.SendAsync(request, cancellationToken);
    }

Actually it shouldn't be set for any requests that doesn't need the user to be signed in... that also includes the confirm-email, confirm-phone-number and forgot-password calls...

Ok, if someone has in the future the need to add an anonymous access page, they would have to add it there, also thinking of someone new to the project, you consider that it is the best way to maintain a simple configuration and maintain the
application security?...

Yeah I know... it's not the best way to handle this... It could be generated somehow by examining the swagger.json... or maybe there are other ways...
It's just that this is now the most pragmatic way... anything else would need some research/design first...

perfect, i'll do that, thanks for the help

Would you mind creating a PR with that change, once you get it working properly?

sure!


chore(deps): updated general dependencies

Fixes N/A
What

Grouped renovate bot dependencies upgrades

Why

Maintain project updated

Testing done

Tested the studio

Decisions made

Checks

[X] I have tested this code
[X] I have reviewed my own PR
[ ] I have created an issue for this PR
[X] I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Execute tests, test Studio frontend
User facing release notes

Dependencies across the whole project have been upgraded.

@AgustinRamiroDiaz unit, integration and e2e tests pass in local. Here they fail because there is no space left on device: https://github.com/yeagerai/genlayer-studio/actions/runs/12265932777/job/34244927585#step:7:2917
I'll make an issue to organize better the CI


Encode a few job classads from unicode to bytes

Fixes #10710
Status
ready
Description
Similar fix to the one provided in https://github.com/dmwm/WMCore/pull/10644
Some of our classads became unicode strings with the python3 modernization, so this PR encodes them to bytes strings to allow job submission to move forward.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None

Actually, given that we know it works in Python3, I think it's best if we only encode to bytes when running in Python2. Code updated accordingly.

I managed to test it with other types of workflows now (including pileup), so I consider it ready to be merged. Thanks to the T0 team for running a replay to test it as well.