[Question] Is there anyway to send the response before on_get function returns?

Hi,
I have a need to give the response before a on_get/on_post function returns.
For example，
I got a request from client, and give response to him immediately to let him know I got the response.
After that, my program begin to do some work. After the work is finished, I informed the client using some other methods.
I checked the falcon.after decorator, but it seems cannot fulfil this.
So it there any possible way to send/flush the response on demand?
Thanks

Start a new process to do other stuff seems to be an possible way.


libssl.so.1.1 library issue on Ubuntu 22.04.2 LTS

The service fails to start with "/crunch-bot/crunch: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory...". Why am I getting this error? how do I fix this?
I am using [Crunch v0.9.3]
Cheers!

Hi,
You could either build from source on your environment or try to install previous openssl version:
wget https://mirror.umd.edu/ubuntu/ubuntu/pool/main/o/openssl/libssl1.1_1.1.1f-1ubuntu2.17_amd64.deb
dpkg -i libssl1.1_1.1.1f-1ubuntu2.17_amd64.deb

That was it! Thanks!


Opening a image by zerochan will first load a sample image

Bug description
When you open the image viewer by zerochan it will first let you see the sample images and after downloading the fullsize image
Expected behavior
Like with the other sources you espect it to load directly the full size image (althought not yet loaded)
Screenshots
https://i.imgur.com/8KPCqYS.png
https://i.imgur.com/KCDnE4c.jpg
System information
Windows 10 with nightly version 797a4010

That's expected behavior 👌
By default, the image viewer will show the thumbnail image (the one from the results view), and resize it to the size of the image. If no size is found, it will simply take the double of the thumbnail size by default. That explains the very low quality of the image in your screenshot (as it's a small image that was upscaled and not the sample image).
The main issue is therefore that zerochan doesn't give the size information, so moving to issue #1385 :+1:


add support for mingw-std-threads

This allows socket.io-client-cpp to build successfully for me using the MinGW cross-compiler from mxe.cc:
i686-w64-mingw32.static-cmake \
  -DBOOST_INCLUDEDIR:STRING=/opt/mxe/usr/i686-w64-mingw32.static/include/boost \
  -DBOOST_LIBRARYDIR=/opt/mxe/usr/i686-w64-mingw32.static/lib \
  -DBOOST_VER:STRING=1.60.0 \
  -DMINGW_STD_THREADS=$(pwd)/../mingw-std-threads

Hi, it seems that recent implementations of MinGW already include std::thread support. Is this PR still relevant?


Try fixing CI build by disabling coverage of client

Current master failed with this
[error] /home/travis/build/fthomas/kartograffel/modules/client/js/src/main/scala/kartograffel/client/Client.scala:21:8:
  Found a dangling UndefinedParam at Position(1f84bbc8aea80e8d4b08/kartograffel/client/Client.scala,67,37).
  This is likely due to a bad interaction between a macro or a compiler plugin
  and the Scala.js compiler plugin. If you hit this, please let us know.
[error] object Client {
[error]        ^
[error] one error found

This problem is already known as https://github.com/scoverage/scalac-scoverage-plugin/issues/196


Create 3 .csv files

i made the files in excel and converted them into a cvs file to be added to the sql project

added internship , company and tag .csv files to the github
however i was unable to create a folder to add them to, i would like if they were organized in a folder. im not sure if i have access to create one

Reviewed .csv files and they are not conflicting with main branch. We will eventually move them to their own directories.


Question Regarding KeyboardToolsView Example

In the example, you have to pass TextView into KeyboardToolsView(textView:) and then assign it to the same TextView.inputAccessoryView. Doesn't that create a retain cycle (at least that's what I get)? I wasn't able to run the Example on my machine (I will try again). Just wanna know if I am doing something wrong within my implementation.

The KeyboardToolsView only holds a weak reference to the instance of TextView, and as such, there is no retain cycle.
Had the KeyboardToolsView held a strong reference to the instance TextView, then there would indeed have been a retain cycle.
Closing this issue as I suppose your question has been answered. Don't hesitate to reopen the issue if that is not the case.


Rewrite some tests after changes in eviction

Test rewrite suggestion per https://github.com/apache/spark/pull/10170#discussion_r47020540

Thanks for these changes. I'm going to merge this into my branch.


Bad demo. Error in task weighing_scales. Demo was completed, but was not successful.

When I run gen_demonstrations.sh
There are errors like this:
Bad demo. Error in task weighing_scales. Demo was completed, but was not successful. Attempts left: 8
Bad demo. Error in task weighing_scales. Demo was completed, but was not successful. Attempts left: 7
Bad demo. Error in task weighing_scales. Demo was completed, but was not successful. Attempts left: 6
......
Is it normal?

It spends quite a long time with no successful demo generated.

Is it a lengthy process to generate a successful demo for a predefined task?  I'm worried that some of my settings were not configured correctly for generating a successful one.

Yeh, it seems normal. I remember that the data generation process will take ~one day. Increasing the number of processes may accelerate it.

Thanks, I have gotten some successful demos today.

Cool!

The gen_demonstrations.sh cannot generate demos for 5 tasks, should I just ignore them?


Make detailed SQL support page filterable

The new Detailed SQL Standard Comparison table is very large. It'd be nice to give users the ability to filter the table based on the third column, CockroachDB Support. Ideally, the page would show all rows by default and then let users filter for just Yes, No, and Partial rows.
@j-low, how difficult would it be to reuse the filtering functionality on https://www.cockroachlabs.com/docs/dev/cockroachdb-in-comparison.html?
cc: @awoods187, @Amruta-Ranade

hey @jseldess for this issue (https://www.cockroachlabs.com/docs/v20.1/sql-feature-support.html) I'm seeing a lot of small tables, has this changed recently?
The original sort/filter solution outlined won't help us address this.

Link to designs in Figma: https://www.figma.com/file/6XcxaUdad2RkjpEqnVHKAG/Education-docs-redesign?node-id=2228%3A11640

The original solution doesn't work out-of-the-box here because the designs are different. https://www.cockroachlabs.com/docs/dev/cockroachdb-in-comparison.html has no column header, whereas https://www.cockroachlabs.com/docs/dev/detailed-sql-support.html has a column header ("CockroachDB Support"). Since https://www.cockroachlabs.com/docs/dev/cockroachdb-in-comparison.html has a custom JS script tailored specifically for that table, we can't just reuse the same JS for https://www.cockroachlabs.com/docs/dev/detailed-sql-support.html.

Looks like the relevant page has been archived: https://github.com/cockroachdb/docs/blob/master/archived/detailed-sql-support.md
Should we close this?

SGTM


Tidies code in preparation for 1.0.0 release

This changeset includes the following changes:

Removes RDF (closes https://github.com/eclipse-aas4j/aas4j/issues/108)
Removes warnings by either changing the code to prevent them or use appropriate @SuppressWarnings
Moves classes that are internally used but should not part of the public API to *.internal.* packages

For the Serializer projects, the following classes are considered public: Serializer (including MixIns, CustomSerializers), Deserializer (including MixIns, CustomDeserializers) and Validation
Classes supporting AasUtils (e.g., Visitor, ...) are moved to internal

Tidies AasUtils class

serializeEnumName/deserializeEnumName: Used by Enum(De)serializer, moved there
Made private due to internal usage:

asString(Reference): Needed by resolve, will be made obsolete by adding toString method for Reference class
keyTypeToClass: Used by resolve & sameAs
clone: Used by toReference, however, it should be addressed by generic copy constructors for all classes
getAasProperties: Used by resolve

Removed due to unclear use case:

parseReference
parseKey
getProperty
getCollectionContentType
getSubmodelTemplates
hasTemplate
isLocal (additionally, comment indicates that it may not be 100% accurate)

@mjacoby @twebermartins @sebbader-sap @arnoweiss as discussed. What are your thoughts on the changes?

The PR looks good and can we accepted.
However, I am not sure if simply moving classes to an .internal. package means they are no longer part of the API and can be safely changed without breaking any code using our library. One could argue, that everything that is accessible from outside code is part of our public API and therefore we should try to hide as much as possible by using the most strict access modifer possible.
When doing so, we need to agree if we would like to have/expose any kind of utility functions, i.e. functions like parseReference (which has been removed) or asString(Reference) (which has been made private). I see that not having this makes developing and maintining the library easier but on the other hand having these utility functions might significantly improve user experience. My proposal would be to have some kind of utility functions but keep them minimal and down to really useful and often needed functionality.

However, I am not sure if simply moving classes to an .internal. package means they are no longer part of the API and can be safely changed without breaking any code using our library. One could argue, that everything that is accessible from outside code is part of our public API and therefore we should try to hide as much as possible by using the most strict access modifer possible.

Moving classes to an internal package is proposed by https://jlbp.dev/JLBP-2. Of course, we can't prevent people from still using it. However, I would not consider classes in internal packages as part of the public API due to this best practice.

The alternative would be to copy the classes to each dataformat-repo and set them private there, right?

The alternative would be to copy the classes to each dataformat-repo and set them private there, right?

This would only work for inner classes, thus would require lots of replication. In consequence, making them private by convention (i.e., moving them to an "internal" package) is in my opinion the only feasible way.

I agree. There's two conflicting goals here: Avoid duplication and minimize API surface. Proposed solution is good compromise. Mergeable from my pov.

I agree, seems like the best solution at this time.


Perform lower case comparison for native currency

Ignores the checksummed state of the provided addresses – one address is provided by a 3rd party, and we should be able to correctly perform this comparison regardless of the representation of the respective address.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 92.201%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
6899

Relevant Lines:
7215

💛  - Coveralls


[AutoPR] cdn/resource-manager

Created to accumulate context: cdn/resource-manager

(message created by the CI based on PR content)

the code is generated by old autorest.


Use and test golang binary identification

Use golang binary identification brought to granulate-utils with PR https://github.com/Granulate/granulate-utils/pull/179.
Description
With new mechanism in granulate-utils it's now possible to identify golang binary looking only at ELF sections. This PR is adopting this mechanism.
Related Issue
#817
How Has This Been Tested?
Added new testcase for a stripped golang binary, proving identification of golang programs is possible.
Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have updated the relevant documentation.
[x] I have added tests for new logic.

I merged https://github.com/Granulate/granulate-utils/pull/179 - let's update the revision here and merge this


Implement DirectedEdge

DirectedEdge is a dependency for Dijkstra.
Resources

Shortest Paths

Moved to jkt: https://github.com/pcoet/jkt-patterns/issues/53


Outdated version 0.2.0 on Julia 1.6.1

I am using Julia 1.6.1. When I added SymbolicRegression, the version was very much outdated: 0.2.0. The first example in the docs didn't run because EquationSearch didn't exist. Can you fix the dependency so that the latest version supports Julia 1.6.1?

Thanks; I will look into this a bit more. I have the CI testing run on 1.6 here, but it seems this same error is coming up for a few people. Let me see what I can do.

I can't reproduce this. The SymbolicRegression.jl version downloaded for 1.6.1 is up-to-date for me. What package server are you pulling from?
Also related to #22. I think these issues are due to pulling an out-of-date package.
As a quick fix, do the following:
Delete ~/.julia/registries/General, then run the following commands in Julia:
ENV["JULIA_PKG_SERVER"] = ""
import Pkg
Pkg.update()

I was able to install the latest version by following your instructions. Thanks. It works now.

I have to re-open this issue because I still have it. When I followed the instructions above in a new environment, the installed version of SymbolicRegression was the latest. However, in the environment of one of my projects, even if I followed the instructions above, I still only got the version 0.2.0 of SymbolicRegression. I think there must be some kind of dependency conflicts in the installed packages, so ultimately it might not be an issue with SymbolicRegression but I don't know how to find out why and how to fix the issue. The status of the environment where I had the issue is given below (you can see the old version of SymbolicRegression).
  [336ed68f] CSV v0.8.4
  [f65535da] Convex v0.14.8
  [2445eb08] DataDrivenDiffEq v0.5.7
  [a93c6f00] DataFrames v1.1.0
  [28b8d3ca] GR v0.57.4
  [2e9cd046] Gurobi v0.9.12
  [682c06a0] JSON v0.21.1
  [961ee093] ModelingToolkit v5.16.0
  [91a5bcdd] Plots v1.13.2
  [438e738f] PyCall v1.92.3
  [ebc72ef8] SciPy v0.1.1
  [8254be44] SymbolicRegression v0.2.0
  [0c5d862f] Symbolics v0.1.25
  [1986cc42] Unitful v1.7.0

Hm, this is strange. Hopefully I can help solve it.
It seems like you might be installing SymbolicRegression into a different environment than the one you are using?
Can you launch julia with julia --project=my/julia/env, where my/julia/env is the directory containing the Project.toml file describing your environment? Then, you can do import Pkg; Pkg.update() to update packages.
Further, you can fix the version in Project.toml by adding:
[compat]
SymbolicRegression = "0.5.16"

at the end of the file.
My guess is the environment you are running from is different than the environment you are installing to.
If this still gives you problems, you could try the Python frontend: PySR, which does the environment setup for you automatically.

I know how to work with environments. I tried to figure out which package has version / dependency conflicts with SymbolicRegression. So I created a new, empty environment; added SymbolicRegression (version 0.5.16), then gradually added the other packages listed above, one by one. It turns out that the package Symbolics (link) caused SymbolicRegression to downgrade to version 0.2.0 as shown above. So, apparently, there is some conflict between SymbolicRegression and Symbolics.
I also noticed that if I forced SymbolicRegression to be at version 0.5.16 (by add<EMAIL_ADDRESS>not by editing the Project.toml file), then SymbolicRegression would be at the correct version but it forced several other packages to be downgraded, for example: ModelingToolkit down to 4.5.0 from 5.17.0, SymbolicUtils v0.11.2 ⇒ v0.6.3, LoopVectorization v0.11.2 ⇒ v0.10.0, and others. Perhaps the Project.toml file of SymbolicRegression can be updated to include more recent versions of its dependencies?

Thanks for taking the time to figure this out! Also, thanks for documenting this; this info is very helpful for me. This probably explains this issue that others have had as well.
So it looks like I will need to update the compatibility to the new Symbolics libraries. I was not aware that using older versions of Julia packages would result in this type of issue where Pkg will use such an old version of SymbolicRegression. SymbolicUtils has had several core API and type changes recently that will require a fair amount of rewriting - this is why I haven't implemented #21 / #20 yet. But it looks like I will need to get on this.
Thanks! I'll let you know when this is fixed. Until then, I would recommend keeping a separate Project.toml and fixing the SymbolicRegression version in it. Unfortunately, as you observed, this means the other package versions in the env will be downgraded.
Best regards,
Miles

Quick update: I tried to get this working, but the entire SymbolicUtils interface has changed down to the core types themselves.  e.g., an expression which used to be of type SymbolicUtils.Term{Number} is now the type SymbolicUtils.Add{Number, Float64, Dict{Any, Number}, Nothing} - and similar for multiplication and power, but not for user-defined operators. This makes things very complex to adapt to.
So, if I do want to update SymbolicUtils, I think it will be much easier for me to completely write my simplification backend from scratch, rather than update my calls to their new types, since it is very structurally different. I would want to move away from relying on these type definitions, and just use their interface. It will probably be a bit slower (that's why I used their internal types originally), but I think compatibility with their package is a good thing.
But this is a big change and I don't have a timeline on it. So for now, one unfortunately needs to fix the version of SymbolicRegression.jl in Project.toml.
Cheers,
Miles

Hi @nxtruong; Thanks to @AlCap23, this issue is now fixed. SymbolicUtils has been upgraded to the latest version.


Information on data format

I've downloaded the examples but I'm struggling to work out how to implement the data the charts. Is there any further documentation?
Thanks
Paul

it is my first practice in code. Sorry, but im understand how finish this project((( May be you help me?


Tweak wording for Workloads overview

Revise introduction to Workloads concept [preview].

Follows on from PR #23737

@sftim
Looking at the preview, there are many formatting changes.
Also, there is a lot of information pushed into an index page.
I'd almost rather see a one sentence description (hints) about each workload (and any additional links) to get the reader to the individual page/section.
What do I think about the code formatting?
There are twenty-three resources formatted as code , several glossary tooltips, and ~sixteen intra-site links.
The page somewhat excessively uses resource terms.
There are some instances where you could have used "ingress" over Ingress (node vs Node)?
Page preview:
https://deploy-preview-24602--kubernetes-io-master-staging.netlify.app/docs/concepts/workloads/

I invite reviewers to compare:

https://kubernetes.io/docs/concepts/workloads/
https://deploy-preview-24602--kubernetes-io-master-staging.netlify.app/docs/concepts/workloads/

Which is better? If it's the second one: merge this, then iterate.

/approve cancel

I'll move this back to Draft to mark that there's tweaks to make.

I'd like another review on this (not urgent).

@sftim. I think the updates look good. There are a few places where "Pod" and "pod" have been switched up.
I like the additional content, though, would push further details to the actual content pages.
@tengqm , What do you think about the latest changes?
/lgtm
/hold

/lgtm

/hold cancel


[CI] Restart Windows VM after reverting to snapshot

Signed-off-by: Zhecheng Li<EMAIL_ADDRESS>

/test-windows-conformance /test-windows-networkpolicy

@lzhecheng what issue this change fixes?

@tnqn this is for Windows VM time resync issue. Reset a VM should fix but it leads to other problem that docker client fails. So if another better approach is choice, this one will be closed.

@antoninbas I think we'd better close this PR and try some other approaches, like this one: https://github.com/antrea-io/antrea/pull/2815
I plan to merge that one and cherry-pick to release-1.2.

Closing this PR since other PRs are taking care of it.


Add Diandianbi.org's dnsseed

Diandianbi.org have kindly provided an auto dns seed service for peercoin. This change adds Diandianbi.org's dnsseed to the dnsseed list.
https://www.peercointalk.org/index.php?topic=4074.0

Hi sandakersmann, could you added #163 TheSeven's seed as well, that request was mine but others are probably too busy to review it. The two requests conflict I think, if you add it then I could merge yours.

@sunnyking Done :)


[AutoPR resources/resource-manager] Fix java code generation for resources

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2613

(message created by the CI based on PR content)

Codecov Report

Merging #2123 into master will increase coverage by 0.04%.
The diff coverage is 79.32%.

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
+ Coverage   53.08%   53.12%   +0.04%
==========================================
  Files        4774     4774
  Lines      119517   119621     +104
==========================================
+ Hits        63440    63544     +104
  Misses      56077    56077

Impacted Files
Coverage Δ

...2016_09_01/operations/resource_links_operations.py
94.87% <100%> (+0.22%)
:arrow_up:

...ures/v2015_12_01/operations/features_operations.py
95.74% <100%> (+0.18%)
:arrow_up:

...esources/v2017_05_10/operations/tags_operations.py
96.22% <100%> (+0.18%)
:arrow_up:

...s/v2017_05_10/operations/deployments_operations.py
96.44% <100%> (+0.15%)
:arrow_up:

...es/v2017_05_10/operations/deployment_operations.py
94.54% <100%> (+0.2%)
:arrow_up:

...v2016_06_01/operations/subscriptions_operations.py
94.52% <100%> (+0.23%)
:arrow_up:

...tions/v2016_06_01/operations/tenants_operations.py
93.75% <100%> (+0.2%)
:arrow_up:

...017_05_10/operations/resource_groups_operations.py
97.59% <100%> (+0.1%)
:arrow_up:

...ces/v2017_05_10/operations/providers_operations.py
94.84% <100%> (+0.22%)
:arrow_up:

...applications/operations/applications_operations.py
12.07% <50%> (+3.44%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f262d80...766a4c3. Read the comment docs.

PR is not intended for Python, but has side effect to regenerate the same thing with more recent Autorest. merge.


Feat: Decouple getSlugAndLang from the pages dir

Related : angeloocana/gatsby-plugin-i18n#6
This PR makes getSlugAndLang work with nodes not in the pages dir.

@Bouncey  Thank you a lot!!!
I think this solves the problem without adding any new config or breaking version. =D
I was thinking about adding a prop pagesPaths to gatsby-config, what do you think about this name? But this change is gonna take a while.
Thank you!!!


ARROW-2191: [C++] Only use specific version of jemalloc

rebased

Travis is happy (but red to the manylinux problem) and AppVeyor passed at https://ci.appveyor.com/project/xhochy/arrow/build/1.0.586


I had an error installing with Docker at step 27/29

Step 27/29 : COPY ./configs/${ENVIRONMENT}.py /powerdns-admin/config.py
ERROR: Service 'powerdns-admin' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder305309959/configs/.py: no such file or directory
I was in the PowerDNS-Admin/docker/PowerDNS-Admin directory and ran the command docker-compose build.  What went wrong here?

I edited the ,env file in the root PowerDNS-Admin directory for the repository and changed the passwords and the api key and set the environment to "production."
I got this error when running docker-compose built from the PowerDNS-Admin directory:
Step 27/29 : COPY ./configs/${ENVIRONMENT}.py /powerdns-admin/config.py
ERROR: Service 'powerdns-admin' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder817878175/configs/production.py: no such file or directory

It is obvious that you had unset variable ${ENVIRONMENT} (for the first time).
At second time you have no file production.py.

Thank you.  I realized that and I'm getting more familiar with Docker.  I have it running in a testing environment.


Java 12 and Operator detection

It appears that using Java 12, Reflections library does not detect the @Operator'ed class and says there are none. Any ideas? Probably Reflections does not support Java 12?
Best,
Mario

Mario,
abstract operator uses this Java library for finding all annotated classes. If I recall correctly, the library also has a feature for finding all the sub-classes of a certain class at run-time, and it should be also turned on in the abstract operator . This way one can create a operator in languages that doesn't support java annotations, like JavaScript (example).
Could you please provide a reproducer for this? Were you doing some module optimization with jlink? If I am not mistaken, reflection in some form should be still there in Java 12. However, there were some changes in the recent versions of Java so it is possible that the https://github.com/ronmamo/reflections may not work as expected in the newest Java.
It's possible that in the future, we will migrate to https://github.com/classgraph/classgraph or some other mechanism that actually also works for the native images in Graal VM.

Jiri,
The reproducing case is, just use openjdk 12 and you will see that the @Operator annotation is not getting scanned by the Reflections library, even though the class is extending AbstractOperator and has @Operator on it. Looking it through the debugger it just returns 0 as the List size for classes which are subclassing AbstractOperator and are annotated with @Operator.
Best,
Mario


Add hist_bucket_to_string method

Hit some problems with NaN handing on the way, and cleaned that up.

squashed updates.


Add a Personal information form

Description
Added a components folder in the src/ folder
Added PersonalInformation.js to  components/ folder
Created a form in PersonalInformation.js to get the user personal information

Related Issue

Acceptance Criteria

[X] Create a component called PersonalInformation.js and save it in a folder called components in the src directory
[X] Heading: Personal Information
[X] Form with above mentioned fields
[X]  Inputfields must be editable
[X]  Fullname throws error when not filled out
[X] Input fields are accessible
[X] Save button does not require functionality
[X] No stylings but plain html
[X] The new component is imported and displayed in the App.js component
[X]  Only the new component is displayed

Type of Changes

Type

:bug: Bug fix

✓
:sparkles: New feature

:hammer: Refactoring

:100: Add tests

:link: Update dependencies

:scroll: Docs

Updates
Before

After

Testing Steps / QA Criteria
-Provide information in forms
-if not full name is given then form would give an error to indicate it empty

Great work, Joseph. Thank you for contributing. 👍🏽

Your Welcome 😁 ,I would contribute even more


proposal: x/tools/godoc: add the ability to customize example_text

Version / OS / Processor:
go version go1.10rc2 linux/amd64 (Debian)
Does this issue reproduce with the latest release?
Yes.
What did you do?
While working on a PR for godoc2md I needed to customize the example_text function to make it available as markdown text: https://github.com/davecheney/godoc2md/pull/20
To do that I had to copy/paste quite big chunks of code for very minimal changes.
In fact I had a PR open on tool/godoc to add a new function that would allow people to change the example's title and add text surrounding the example code: https://github.com/golang/tools/pull/33
This would impact any of the existing functionnalities and would allow people to avoid having to create custom code for these kind of usage (can be reused for generating doc in languages like asciidoc, rst, etc).

Looking at the patch: https://github.com/golang/tools/pull/33/files I'm still a little confused about what you're proposing. Do you have screenshots maybe or a URL that contains a concrete example?

IIUC, you want to import  "golang.org/x/tools/godoc" and pass your own input into the example_text function in pres.FuncMap() to generate markdown.
IMO, this is shoe-horning the code base to satisfy a different purpose. If you look at the code change without external context, it is very hard to reason why this is being done, which is for external code to be able to generate markdown.
While I am not against generating markdown, this seems to be the incorrect approach. One should not have to import the godoc package at all to generate markdown. I would expect there to be a button in the package page which can be clicked and a .md file gets downloaded.

The idea was to be able to have the example_text2 builtin function that would allow you to change the title and add delimiters to wrap the code blocks without having to write a customized function.
For example, with https://github.com/golang/tools/pull/33 I could:

have a different title than "Example:" on my code block: {{ example_text2 $ .Name "" "Example for .Name" "" "" ""
generate the examples in markdown using (with titles to have the links working): {{ example_text2 $ .Name "" "#### Example .Name" "" "``` go" "```"
generate the examples in asciidoc format using (with titles to have the links working):  {{ example_text2 $ .Name "" "==== Example .Name" "[source,go]\n---" "---"
generate the example in restructuredText format using (with titles to have the links working): {{ example_text2 $ .Name "  " "==== Example .Name" ".. code:: go" ""

It just sounded dumb to me to have to rewrite a big function when the change I'd need to do in the core library would be really small.
I'm not really a big fan of having to duplicate entire chunks of code from the standard libraries I use just to be able to add 2 lines in it. It seemed more logical to me to propose the changes upstream directly.
The need of godoc is there because what is generated is the go documentation of the package. It's just in another format than the ones currently available.


Switch CoreHealthMonitor to use MI

https://dev.azure.com/dnceng/internal/_workitems/edit/6192

after looking into it a bit, it appears this crash dump never actually reported anything in all the years it's been running, Closing this PR to open a new one to remove it


Update User Provided Service Instance misdocuments payload parameter

The API documentation for Update User Provided Service Instance describes a name key that is listed as required. This parameter is not required as indicated by the example in the documentation.

Hi @nebhale ,
Thanks for another good catch! I just commited the change, and it will make its way to the docs in the normal timeframe.
Cheers,
@wendorf


[JDK18] Re-enable Security Manager Tests

The below tests have been fixed by eclipse-openj9/openj9#14329:

java/lang/System/AllowSecurityManager
java/lang/System/SecurityManagerWarnings

Signed-off-by: Babneet Singh<EMAIL_ADDRESS>

@llxia @renfeiw Can you please review this PR?


Update PopupMenuButton widget

Fixes #77915
Tests coming soon!
This change lets the popup menu can be updated after the button's position changed. CC @Piinks
Landscape change can trigger the issue.
Repro Steps on Phone
1, Run the code below;
2, Open the popup menu;
3, Rotate the phone and observe the menu's position;
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(
    home: Home(),
  ));
}

class Home extends StatelessWidget {
  const Home({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: PopupMenuButton(
          itemBuilder: (context) => ["apple", "orange",]
              .map((e) => PopupMenuItem(
                    child: Text(e),
                  ))
              .toList(),
          child: Container(
            height: 200,
            width: 300,
            color: Colors.green,
          ),
        ),
      ),
    );
  }
}

Tests coming soon!

@shihaohong Hey, would you like a look at this patch?
Of course, there is still some work that has not been completed, such as testing and documentation.

I took a quick video of how the fix works. There's like a slight "delay" where the menu itself "follows along" after a slight delay. This is still better than the incorrect behavior, but I just want to track everything
https://user-images.githubusercontent.com/27032613/114826354-fce1b500-9df9-11eb-90b4-9186d8167381.mov

Nice catch!
This is because we can not access the button's size during layout parse.
So have a frame delay.

Created a new issue to track the trailing issue: https://github.com/flutter/flutter/issues/80699


 These old package sets have been broken and unmaintained for a long time now. We keep the compilers around for the time being.
Also drop obsolete GHC version 7.10.2; we have 7.10.3.

In what sense were these package sets broken? It seems to me that they are still convenient to have around if you want to test a feature on an old compiler but I admit that most people will never use them.

In what sense were these package sets broken?

Well, any attempts to compile a non-trivial package in any of those package sets is going to fail. The old compilers cannot deal with the versions from LTS-10.x -- on which is main package set is based --, and the amount of effort it takes to configure manual overrides to fix all those issues is just  too big (i.e. I don't observe anyone doing it and I, personally, don't want to do it either). Hence, these package sets are very much unsupported and have been for years.

It seems to me that they are still convenient to have around if you want to test a feature on an old compiler.

You can do that much more reliably by running
nix-shell -p haskell.compiler.ghc784 --run "cabal new-build"

or something similar to it. That command has a MUCH higher chance of actually succeeding than trying to install a non-trivial working environment for GHC 7.8.4 with Nix.

Merged in eb0da3e8afebd017e8d93afabd213e095674cceb.


How to write interface for model in sub document.

i have a sub document struktur, like this:
name: {          fullname: string,          nickname: string, },  address: {         street: string,         city: string,         postCode: string, }
how i make interface for this model?

@ssembara sorry for the very late response.
I added the solution to your question to the user model.


Error running Hardwall simulation - Runtime error: Plan failed (Traceback from c++ library)

Surface Topography and Contact Mechanics packages have been successfully installed.
I am trying to run the example file Hardwall simulation  from Contact Mechanics using Jupyter, but I am getting the following error -

How can I solve this?

Similar errors while running [easy_hardwall_simulation]

(https://github.com/ContactEngineering/ContactMechanics/blob/master/examples/easy_hardwall_simulation.ipynb)
@sannant @pastewka @mcrot

Dear @sitangshugk95, sorry for all the mess
@jotelha built a docker image allowing to start a kind of virtual machine with SurfaceTopography, ContactMechanics and even Adhesion.
I think there is even a Docker application for windows but I never tried.
Please follow the instructions here: https://github.com/ContactEngineering/SurfaceTopography/tree/doc/instructions_for_docker_image
Sorry that we didn't come earlier to this solution.
I hope that using ContactMechanics via this image solves the problems.

Dear @sitangshugk95, sorry for all the mess
I'm just curious as to whether these errors were an issue only on my system, or is it a bug that you guys are facing as well? In case the docker images don't run, I might still need to fix this.
@jotelha built a docker image allowing to start a kind of virtual machine with SurfaceTopography, ContactMechanics and even Adhesion.
I think there is even a Docker application for windows but I never tried.
I don't need Windows anymore as we have a dedicated Linux system at our lab now :)
Please follow the instructions here: https://github.com/ContactEngineering/SurfaceTopography/tree/doc/instructions_for_docker_image
We don't have sudo access (whick seems mandatory to install Docker) at our university, but let me see what IT has to say.
Sorry that we didn't come earlier to this solution.
I hope that using ContactMechanics via this image solves the problems.

Hello @sannant ,
Thanks for the response.

Were the screenshots that I sent an error on my part only,  or are you seeinng the same errors too?
I don't really need Windows anymore, as we have purchased a Linux system solely for running Contact Mechanics via your packages.
The installation guide for Docker has a lot of sudo commands on it, but I don't have sudo rights. Are there any other alternatives?

@sitangshugk95 I am no SurfaceTopography expert, and I can't offer any third alternative next to the manual setup instructions or the docker image, but I am afraid without admin privileges on your machine, it will be difficult to get SurfaceTopography running properly either way. The docker image can help when you are having troubles putting together the right environment, but it will introduce many other inconveniences if you are not used to working with containers. If your machine does not have the docker engine installed and you don't have the privileges to do that, the docker image is of course useless anyway.

We could convert the Docker into a Singularity image which can be run without root priviledges.

Sure, but installing the singularity engine in the first place will of course still require root privileges, @sitangshugk95 . The docker recipe currently lives at https://github.com/IMTEK-Simulation/code-snippets/pull/20,
shall we move that into SurfaceTopography, @pastewka ? Originally, that was only intended as my "quick and dirty" personal environment documentation, and I am a bit worried that it will introduce more maintenance overhead than it will resolve support issues in the long run.

Hello @pastewka - that is what my IT dept suggested as well - use Singularity instead. IT has installed Singularity on my system, so I am able to download and open the Docker image using Singularity now. (My university has restricted Docker for security reasons, but Docker is available for use)
Hello @jotelha I have followed your instructions , and I am currently on this screen after opening the jupyterlab server in my browser:

Specifically, I want to run and modify the HardwallSimulations jupyter notebook file from the ContactMechanics git repo. What should be my next step?

I am not sure that is the simplest solution, but you can run wget https://raw.githubusercontent.com/ContactEngineering/ContactMechanics/1.0.0/examples/Hardwall_Simulation.ipynb
That will download it

Do you mean typing the command in the terminal of the window opened on the browser using Singularity? If yes, I have downloaded it :  What command should I use to run it?
I used jupyter notebook to run it.

I opened the link in a web browser, but when I try to run, I get the same error as I was getting on my own system (without using Singularity):

Am I doing something wrong?

@sitangshugk95 I am no SurfaceTopography expert, and I can't offer any third alternative next to the manual setup instructions or the docker image, but I am afraid without admin privileges on your machine, it will be difficult to get SurfaceTopography running properly either way. The docker image can help when you are having troubles putting together the right environment, but it will introduce many other inconveniences if you are not used to working with containers. If your machine does not have the docker engine installed and you don't have the privileges to do that, the docker image is of course useless anyway.

@jotelha The error that I am getting using the Docker image is the same as the one I was getting when using the manual steps -  which somehow makes me feel like it is not an issue with my system (I might be wrong though). If you can convert it into a Singularity image and send me, I can try running it again.

Has anyone been able to install it from scratch recently? Have they faced similar issues while installing, or is it just me?
If any of you can find some time out, we can schedule a quick Zoom/Teams meeting to walk you through the steps I am doing, and hopefully sort this out. I can also prepare a step-by-step documentation for future users.

P.S. I really appreciate you guys helping me out, as I am stuck in a project that needs BEM modeling. In fact, I made my advisor buy a dedicated Linux system just for running this code, so I really need to get this thing running asap.

Sorry for the mess . What you do wrong is that you do not need to start a notebook from the terminal in jupyterlab.
jupyter lab replaces jupyter notebook

@sitangshugk95 I see you got the container running with singularity. Unfortunately, it's not that straight forward to just run a docker container with singularity if the container engineer did not think about making it compatible with different container engines. The image builds on https://jupyter-docker-stacks.readthedocs.io/en/latest/, and those don't have singularity in mind. The main issue here is that these images introduce their own user "jovyan" and expect their home folder to be available with the permissions set properly, which is not the case when simply launching with
singularity run docker://imteksim/jupyterlab-surfacetopography:0.3.0

As in your screenshots, you won't see the SurfaceTopography Kernel then and likely encounter many other errors. What worked for me with singularity is the following, but again, if you do not have root privileges on your local machine, you will likely hit another barrier here:

you will likely need > 10 GB empty storage to begin with
run the image with
singularity exec --writable --fakeroot --no-home --containall --userns docker://imteksim/jupyterlab-surfacetopography:0.3.0 bash -c 'cd /home/jovyan && chown -R jovyan . && start-wrapper.sh start-notebook.sh'

This will do a few things, in particular it will unpack the image locally, isolate it completely from your system (any changes done within the running container will be lost after stopping singularity), change to the correct directory and modify the permissions to what the original service needs.
You should end up with a launcher offering two kernels,

you should be able to download Antoine's test script,

and you should be able to run it after choosing the kernel

at least down to cell 14, where I encounter this error,

@jotelha Thank you for the very detailed message. Once I get through the initial hurdle of getting to run the Docker image properly using singularity, the remaining steps look manageable.
For now, I tried  singularity exec --writable --fakeroot --no-home --containall --userns docker://imteksim/jupyterlab-surfacetopography:0.3.0 bash -c 'cd /home/jovyan && chown -R jovyan . && start-wrapper.sh start-notebook.sh' as per your suggestion, and I got the following error:

Also, if this does not work, is it possible to make a file compatible with Singularity directly? Would that make things simpler?
I have the following options available to me:

A windows PC with admin access
An Ubuntu system without admin access (but with Singularity installed)

@sitangshugk95 that's exactly what I expected. I gave the docker image an overhaul, and (at least on my machine) it now runs without root privileges with
singularity run docker://imteksim/jupyterlab-surfacetopography:0.4.0

would you give it another try?

@jotelha This works (yayy!!), thank you so much for going through all this. I do see the same error on cell 14, but that looks like a code error.
Just one final question - is there a way I can store the values that the program is executing somewhere on my local PC, so that I can use them as an input to another program (eg; calculate contact resistance in another FEM program based on the gap calculated by the SurfaceTopography package?)

at least down to cell 14, where I encounter this error,

Hello @sannant , so I was finally able to run the codes on my system using the Docker images. However, I also get the same error involving "prestol" that @jotelha gets; so it looks like a code error. Do you have any inputs as to what might be causing this error, and how to fix it?
What do prestol and pentol do? Is it mandatory to use prestol for force inputs (as that is what I am mainly interested in)?

This is just because we changed the function signature.
You need to find the definition of the function of the code.
You need to read the documentation of the function.
This should be fixed in the current master but it isn't in the release you have in the docker image.
You can find the file path where it is defined by calling minimize_proxy? and/or  minimize_proxy?? in a cell.
This will give you the docstring. That tells you that replaceing prestol by forcetol solves the problem.
It makes sense for you to learn to figure out were the code is defined, because our documentation is not perfect anyway.
I checked that after this change the whole example is executing properly.

The way I usually dump results is using NuMPI.IO.NetCDF.NCStructuredGrid.
That is probably closest to what we do in contact.engineering as well if you are used to those outputs.


Goto target problem

Hi,
Noticed a problem with Goto target function: when I turn off the switch it triggers another goto command, instead of going back to dock. Is it supposed to be like that? I have tried a few times the device goto target with an error (due to obstacles) but there is no way that I can ask it to go back to dock station. In my opinion the logic should be when switching off goto, it should send docking command.

cc'ing @luc-ass for awareness as he introduced the feature.

You are right. I'll try to find a solution.

Well, I found a fairly well written doc of the API here. From my understanding, the button should act like this:

Turn goToButton on → go to specified location (essentially the way it works right now)
Turn goToButton off → go back to dock (reference)
Button automatically turns off as soon as status is not 13: going-to-location or 3: waiting (source)

Additional thoughts?

@afharo Still wrapping my head around TS. Can you point me to the correct file, where for example goToLocation(){} is defined? It used to be in /src/miio/lib/devices/vacuum.js. Is that still true?

This would be my suggestion for now...

@afharo can you tell me how to test TS locally? I was able to clone the repo into a folder, as I do normally, but npm install or npm install typescript doesn't result in a working plugin.

Well, I think I nailed it. 🎉
Most parts, such as activateCharging() already existed and just needed to be pieced together.

Hi @luc-ass , thank you for looking into it. Yeah that sounds perfect!

this has been resolved by #544

Thank you @luc-ass and @maisun for working this out! You rock!!!
I'll go ahead and close this issue then. Feel free to reopen if anything else is missing.


PyroSnow-Map

ABOUT:
Pyro Snow: A World of Black and White
I heard from a YouTube video once that snowflakes were "completely unique" from one another. To challenge this statement, I created what I call a simple generator of such snow, with the ability to generate a set of a random kind of snowflake every time and display 30 on screen at random coordinates under a dark cloud. While obviously borne from illusions, see the different snowflakes right in front of you; the program has pentagons, heptagons, square-agons(?) and much more!
Quite honestly, I was surprised myself that such complex drawings resulted in illusions that highly resembled snowflakes. While the highly illusory effect was unintentional, the outcome is; so regardless of your country being in the equator or not, please enjoy the snow!
Originally, the colors were supposed to be inverted for an extra feeling of being unable to touch the snowflakes on zoom; then I realized the Blot machine probably can't handle it, and I was forced to return it to this color scheme. How unfortunate!
CODING EXPERIENCE:
I commonly use HTML, JS, and CSS (while I know they aren't exactly programming languages) to build websites. I also have experience in other languages such as Python and Java. While I have experience tinkering with JS to make website elements do wonders, it's only in Hack Club where I ever found myself doing these unexplainable kinds of things. Blot is quite challenging, especially on JavaScript! But it was quite fun getting to where the art is at right now, too! I never found myself to be an artsy type so this was quite an experience.

I think you could improve the cloud. How could you give it some texture?
I think this earns a Blot though. Congrats you can order it here.

Hmm I think I can probably create better clouds with more curves! I'll try revisit this project soon and post in the channel if I achieve anything
Thank you very much!


My Solutions For Advent Of Code 2022

Hi, Pretty solid contribution however unexpected. We're all talking about this offline and shared it here.
But if you want to remove the .cph/ noise and of course the .exe files I don't really have a problem with merging.


Fixed some sentences / missing words / grammar

Wow! @PeeHaa! Thanks for your contribution, I really appreciate it.
P.S. you are far more advanced than me, so it probably a reminder to further contributors that you may add [skip ci] to commit message to prevent triggering CI when editing project files that doesn't affects functionality, like readme, stubs, some examples.

Thanks @PeeHaa!


quay-enterprise: document set up of an ELB with Proxy Protocol for QE

Needed to replace older documentation on Quay.io
References product correctly (Quay Enterprise)
Provides exact cli commands needed to create ELB policy
Helpful Troubleshooting section with common issues

@josephschorr @jzelinskie @joshix please review.


full_path property is unused (doesn't override default path logic)

Cookbook version
v4.0.0
Chef-client version
v14.8.12 (applies to all)
Platform Details
Windows Server 2016 (applies to all)
Scenario:
Would like to specify exact path where extracted files should be :put, but resource.name is always apended.
Steps to Reproduce:
ark 'ResourceName' do
  action :put
  full_path   'C:/Desired/Path'
  url    'http://fileserver/path/file.tar`
end

Expected Result:
Contents of archive to be extracted to C:/Desired/Path.
Actual Result:
Contents extracted to C:/Desired/Path/ResourceName.
There is a :full_path property defined, with seems to be unused.  It would be great if this property could be utilized to override the default path-building behavior and instead use whatever value is provided as-is.
I'm happy to submit a pull request, but wanted to be sure it would be accepted before I do the work.
Thanks!

Hello, any response to this?  I really don't want to spend time working on a PR for it to sit unanswered...


Simple problem, can't figure it out :)

I am new to Django/Python and this is driving me absolutely insane for hours :)
I am trying to import XLS file that has column name with spaces, like: "this is column name:"
I tried using this:
class BookResource(resources.ModelResource):
    column_name_thats_defined_in_models = fields.Field(column_name='this is column name in XLS file')

It shows it in admin panel but it doesn't import from that column name.
I tried setting this "full column name" as string to variable to then use inside "meta, fields" but it's obviously very wrong idea.

Feeling dumb now :) Issue was easily resolved with:
newVAR = fields.Field(attribute='oldModel', column_name="column name with space")


As a frequent spender, I need the ease of splitting bills by percentages/number of people without the need of using a calculator.

This is an implementation of splitting expenses, and details of how to split. Closing this issue.


Image Registration qc figures

Generate image registration qc with the registered brain overlayed on the atlas for all datasets (SWU4, KKI2009, BNU1, HNU1)

example single brain registration fig:

More difficult to asses some brains (see below)

@vikramc1 this is great progress, i'm really excited about your QC package to be integrated into ndmg!


Feature Request: support updating alt-names

Currently, if you change the list of alt names in a certificate, the provider doesn't update the cert (or destroy and recreate it).
Not exactly sure how that'd work though.... can certs have their alt-names changed without being destroyed and recreated?

This is a valid request, but difficult to meaningfully implement. dns_alt_names in a cert can't be changed - a new cert would have to be issued. The Puppet CA will throw away CSRs for a common name that already exists and hasn't been revoked, and there's no way for a node to:

Request revocation for its own cert
Request a new cert for it's existing common name

Until a mechanism exists for something like that, there's not much we can do on this end.
What we COULD do would be to make noise if the existing cert's dns_alt_names don't match the desired dns_alt_names. That would be the approach to take today when/if someone starts working on this issue. A bigger picture fix would require new certificate-management features in Puppet.


Use timeout_height from signed amino doc

What is the purpose of the change:
In institutional cases, the signature process may take a while.
This is why we override:
  sequence: signedSequence

Since maybe the sequence number has changes since the dApp sent its requested sign doc to the wallet - the wallet may update the sequence number to a new value, and the dApp should use the returned value - which was signed on.
The same reasoning should follow for timeout_height which is a newer addition to the protocol than sequence number.

Linear Task
N/A
Brief Changelog
Use timeout_height from signed amino doc
Testing and Verifying

This change has been tested locally using our own extension wallet that modifies timeout height

@sam-utila how did you notice this?

Basically timeout_height bytes are part of the body not the auth_info (where sequence is located) - and generally they should not be touched by the wallet.
But memo is also in body.
So if there are multiple signers for the transactions - the wallet is not allowed to touch memo or timeout_height.
However - if I'm the only signer - why not?
I want to update the timeout_height to be something close to the point of the actual signing of the transaction.
In institutional wallets (like Utila) the TX may live for a while before it is approved and signed - so editing the timeout_height should be okay.

@sam-utila can you update to the latest branch of stage please


Kubernetes version unsorted in k3s cluster

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Create a k3s cluster

In our test, it was 1 master, 3 worker
kubernetes version v1.16

Import the cluster into Rancher
Result:
Kubernetes Version dropdown is not sorted:

In a RKE cluster, kubernetes version is sorted:

After upgrading cluster to v1.16.7, dropdown is in the correct order.

The bug fix is verified with Rancher server rancher\rancher:master-head version 926997017
Kubernetes Version dropdown is sorted:


Rename CR to proposal

and within a proposal are multiple proposed changes.
Entering a proposal should enable the use to see the list of proposed changes.
Each proposed change comes with a diff and an optional justification.
NOTE: CR is an IEC term that we no longer need to follow.

CR should never appear in GUI, if so that is a bug.
If regarding source code, that is by design for the time being.

The "CR" term is used in the first load screen when entering "proposal mode".


Rails 3.2 issue with undefined method 'write_inheritable_array'

/Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/activerecord-3.2.0.rc2/lib/active_record/dynamic_matchers.rb:50:in `method_missing': undefined method `write_inheritable_array' for #<Class:0x007f847e5442f0> (NoMethodError)
	from /Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/validation_reflection-1.0.0/lib/validation_reflection.rb:82:in `block in remember_validation_metadata'
	from /Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/validation_reflection-1.0.0/lib/validation_reflection.rb:81:in `each'
	from /Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/validation_reflection-1.0.0/lib/validation_reflection.rb:81:in `remember_validation_metadata'
	from /Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/validation_reflection-1.0.0/lib/validation_reflection.rb:60:in `block in validates_presence_of_with_reflection'
	from /Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/validation_reflection-1.0.0/lib/validation_reflection.rb:91:in `ignoring_subvalidations'
	from /Users/JD/.rvm/gems/ruby-1.9.2-p290@ab_reps/gems/validation_reflection-1.0.0/lib/validation_reflection.rb:58:in `validates_presence_of_with_reflection'

I have the exact same issue...

+1

+1

Try changing
    def remember_validation_metadata(validation_type, *attr_names)
      configuration = attr_names.last.is_a?(Hash) ? attr_names.pop : {}
      attr_names.each do |attr_name|
        write_inheritable_array :validations,
          [ ActiveRecord::Reflection::MacroReflection.new(validation_type, attr_name.to_sym, configuration, self) ]
      end
    end

to:
   def remember_validation_metadata(validation_type, *attr_names)
      configuration = attr_names.last.is_a?(Hash) ? attr_names.pop : {}
      self.validations ||= []
      attr_names.each do |attr_name|
        self.validations << ActiveRecord::Reflection::MacroReflection.new(validation_type, attr_name.to_sym, configuration, self)
      end
    end

and
  def self.included(base)
    return if base.kind_of?(BoilerPlate::ActiveRecordExtensions::ValidationReflection::ClassMethods)
    base.extend(ClassMethods)
  end

to
  def self.included(base)
    return if base.kind_of?(BoilerPlate::ActiveRecordExtensions::ValidationReflection::ClassMethods)
    base.extend(ClassMethods)
    base.send :class_attribute, :validations
  end

Untested, as I' still have to work through other issues with Rails 3.2 before getting it running... ;-)

Okay, one more change is required to get it working (now tested ;-):
Change the reflect_on_all_validations method to
# Returns an array of MacroReflection objects for all validations in the class
def reflect_on_all_validations
  validations || []
end

I'm not sure if you forgot to post some changes you made or if you didn't do the update off from master.  I tried to just create a Rails 3.2 branch for a pull request and can't get the updates to work.  Notably the code you want me to change away from doesn't match what you've got listed as what to change.

Ah, sorry, I might not have been on the latest version, yes... can you figure out what needs to be changed on master from my hints? Otherwise I can look if I can.

Okay, as far as i can see you only need to replace in my code:
return if base.kind_of?(BoilerPlate::ActiveRecordExtensions::ValidationReflection::ClassMethods)
in def self.included(base) to
return if base.kind_of?(::ValidationReflection::ClassMethods)
and attr_names.each do |attr_name|
to
attr_names.flatten.each do |attr_name|
to be conform with master

base.send :class_attribute, :validations

Isn't working properly for me.  I get:
/Users/JD/validation_reflection/lib/validation_reflection.rb:30:in `included': undefined method `class_attribute' for ValidationReflection::ClassMethods:Module (NoMethodError)
	from /Users/JD/validation_reflection/lib/validation_reflection.rb:62:in `include'
	from /Users/JD/validation_reflection/lib/validation_reflection.rb:62:in `<module:ClassMethods>'
	from /Users/JD/validation_reflection/lib/validation_reflection.rb:60:in `<module:ValidationReflection>'
	from /Users/JD/validation_reflection/lib/validation_reflection.rb:3:in `<top (required)>'
	from /Users/JD/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:55:in `require'
	from /Users/JD/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:55:in `require'
	from /Users/JD/.rvm/gems/ruby-1.9.3-p0/gems/activesupport-3.2.1/lib/active_support/dependencies.rb:251:in `block in require'
	from /Users/JD/.rvm/gems/ruby-1.9.3-p0/gems/activesupport-3.2.1/lib/active_support/dependencies.rb:236:in `load_dependency'
	from /Users/JD/.rvm/gems/ruby-1.9.3-p0/gems/activesupport-3.2.1/lib/active_support/dependencies.rb:251:in `require'
	from /Users/JD/validation_reflection/test/validation_reflection_test.rb:17:in `<top (required)>'

That shouldn't be looking for it on: ValidationReflection::ClassMethods:Module
It should just be ValidationReflection::ClassMethods right?

Okay, I was working on the old plugin version.
Here is the fix for master: https://github.com/redinger/validation_reflection/pull/13


Use futures for all API calls and add call timeouts

Current implementation perform the API calls on the same main thread, blocking the execution of the program. this should be changed to the use of futures with the appropriate timeouts.

appropriate timeouts have been added to all API calls.


Swipe Button add also in bottom of table

Hello,
How can add swipe button bottom of the table?
Any idea for this. Please give me the solution.
Thanks & Regards,
Nitin Patoliya

We very recently added support for moving the column chooser on the toggle table, but nothing for swipe yet. I’ll file this as an enhancement request.

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.
The enhancement backlog can be found here: https://github.com/filamentgroup/tablesaw/issues?utf8=✓&q=label%3Aneeds-votes+sort%3Areactions-%2B1-desc+
Don’t forget to upvote the top comment with 👍!


Run with tmpfs for speedup

I've tried to run a container with --tmpfs mount for oracle data. I way wondering to get some performance benefits for integration tests.
Has anybody tried it? I would like to use tmpfs for all possible database files for speedup.
I've tried --tmpfs /opt/oracle/oradata, but unfortunately get this result:
Total System Global Area<PHONE_NUMBER> bytes
Fixed Size		    9686424 bytes
Variable Size		  620756992 bytes
Database Buffers	  973078528 bytes
Redo Buffers		    7090176 bytes
ORA-00205: error in identifying control file, check alert log for more info

Thanks for the help or any advice.

Hey @Fleury93,
Thanks a lot for using these images!
While I cannot comment on how successful other users have been with using tmpfs for the /opt/oracle/oradata location (I'd also love to hear from users if they use it and how much benefit they see from it), I can confidently say that using tmpfs is possible and I believe the error you are receiving above is because of something else. Somehow the controlfile can no longer be found. The alert log should have more information as to why.
When I use tmpfs with Podman, the database comes up just fine:
[gvenzl@localhost ~]$ podman run --name test -p 1521:1521  --mount=type=tmpfs,tmpfs-size=4g,destination=/opt/oracle/oradata -e ORACLE_PASSWORD=LetsTest1 gvenzl/oracle-free:slim
CONTAINER: starting up...
CONTAINER: first database startup, initializing...
CONTAINER: uncompressing database data files, please wait...
CONTAINER: done uncompressing database data files, duration: 6 seconds.
CONTAINER: starting up Oracle Database...

LSNRCTL for Linux: Version <IP_ADDRESS>.0 - Production on 28-JAN-2024 02:30:28

Copyright (c) 1991, 2023, Oracle.  All rights reserved.

Starting /opt/oracle/product/23c/dbhomeFree/bin/tnslsnr: please wait...

TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
System parameter file is /opt/oracle/product/23c/dbhomeFree/network/admin/listener.ora
Log messages written to /opt/oracle/diag/tnslsnr/810a2268e147/listener/alert/log.xml
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC_FOR_FREE)))
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))

Connecting to (DESCRIPTION=(ADDRESS=(PROTOCOL=IPC)(KEY=EXTPROC_FOR_FREE)))
STATUS of the LISTENER
------------------------
Alias                     LISTENER
Version                   TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
Start Date                28-JAN-2024 02:30:28
Uptime                    0 days 0 hr. 0 min. 0 sec
Trace Level               off
Security                  ON: Local OS Authentication
SNMP                      OFF
Default Service           FREE
Listener Parameter File   /opt/oracle/product/23c/dbhomeFree/network/admin/listener.ora
Listener Log File         /opt/oracle/diag/tnslsnr/810a2268e147/listener/alert/log.xml
Listening Endpoints Summary...
  (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC_FOR_FREE)))
  (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))
The listener supports no services
The command completed successfully
ORACLE instance started.

Total System Global Area<PHONE_NUMBER> bytes
Fixed Size		    5313720 bytes
Variable Size		  738197504 bytes
Database Buffers	  855638016 bytes
Redo Buffers		    4530176 bytes
Database mounted.
Database opened.

CONTAINER: Resetting SYS and SYSTEM passwords.

User altered.

User altered.

#########################
DATABASE IS READY TO USE!
#########################

####################################################################
CONTAINER: The following output is now from the alert_FREE.log file:
####################################################################
===========================================================
Unable to obtain current patch information due to error: 20013
===========================================================
2024-01-28T02:30:37.685769+00:00
PDB$SEED(2):Opening pdb with Resource Manager plan: DEFAULT_PLAN
FREEPDB1(3):Autotune of undo retention is turned on.
2024-01-28T02:30:39.307884+00:00
FREEPDB1(3):Opening pdb with Resource Manager plan: DEFAULT_PLAN
Completed: Pluggable database FREEPDB1 opened read write
Completed: ALTER DATABASE OPEN
2024-01-28T02:30:46.512843+00:00
Thread 1 advanced to log sequence 14 (LGWR switch),  current SCN: 2337254
  Current log# 1 seq# 14 mem# 0: /opt/oracle/oradata/FREE/redo01.log

And I can confirm that the container is using tmpfs for the /opt/oracle/oradata location:
bash-4.4# mount | grep /opt/oracle/oradata
tmpfs on /opt/oracle/oradata type tmpfs (rw,nosuid,nodev,relatime,size=4194304k,uid=1000,gid=1000,inode64)
bash-4.4# df -h
Filesystem      Size  Used Avail Use% Mounted on
overlay         250G  189G   62G  76% /
tmpfs            64M     0   64M   0% /dev
tmpfs           794M  124K  794M   1% /etc/hosts
shm              63M     0   63M   0% /dev/shm
tmpfs           4.0G  2.9G  1.2G  72% /opt/oracle/oradata
devtmpfs        4.0M     0  4.0M   0% /dev/tty
bash-4.4#


Language selection drop-down doesn't seem to hold all languages?

What you were trying to do
See all 14-15 language options in the language drop-down under Player Settings
What actually happened
Only 8-9 options are shown. Making it more fun the language availability changes based on the chosen language so it isn't that the additional options don't exist they just aren't all fitting for some reason.
Unsure if it is an issue with the drop-down itself or the config but probably not a hard fix.
Not fixed by #2201 in its current shape but very close to it functionally so worth keeping in mind to avoid conflicts :-)

This is fixed now! Just didn't auto-close.


Fix typo in phenotype.js (fixes #992 & #963)

There was a typo in line 68 introduced in a recent PR. This fixes it.

good catch!


MINOR: Fix nonsense test line from TopicCommandTest

As the title.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@wenbingshen thanks for your patch. LGTM
Could you revise the title of this PR? I'd like to merge it tomorrow.

Of course, I will modify it now, thank you for your review. :)

Merge trunk to trigger QA again.

@wenbingshen thanks for your patch. LGTM
Could you revise the title of this PR? I'd like to merge it tomorrow.

I think the failed test  is unrelated to this PR, request to be merged into the trunk. Thanks. :)


Does pingora support dynamically adding services after startup?

For example, dynamically add listener, router, upstream, etc.

After modifying the configuration, stop the old process and start a new one.
https://github.com/cloudflare/pingora/blob/main/docs/quick_start.md#gracefully-upgrade-the-service

Right now it does not support adding new listeners or service without a (graceful) restart as mentioned above. But you can have dynamic routing and upstream without restarting.

pingora pulling config from a database on each request would add too much latency i suppose.

Not necessarily if done with a caching layer. There are two ways to make this fast

With https://docs.rs/pingora-memory-cache/latest/pingora_memory_cache/ you can pull and cache the user conf (either the entire conf or per user conf if your database supports it) out of the database and cache it. You only pay the latency every TTL seconds.
Put the user conf in a ArcSwap and refresh it in the background. In this case no request would pay for the latency. The background refresh logic can be either active (refresh every TTL seconds) or reactive (the external system will signal it to refresh when the conf is changed).

@eaufavor a followup question on this - what is the mental model of a large scale deployment. for e.g. 1000 users have deployed 2000 services and i want pingora to be the front for these services. Users will be constantly changing their configuration.
does this mean - each user has a pingora instance for them ? so whenever they update the config, it gets updated and redeployed ? or is there a smaller pool of pingora instances shared between all users ? in which case, a config update would mean all instances would get redeployed.
pingora pulling config from a database on each request would add too much latency i suppose.

You can add L4 nat proxy before the pingora and read both proxy info and service config at the begining of the pingora lifecycle.

Right now it does not support adding new listeners or service without a (graceful) restart as mentioned above. But you can have dynamic routing and upstream without restarting.

Is there a plan to support this in the future?


new method that selects a random question from an array of questions

🚀 What is the feature?
Write a function that accepts an array of question objects.
The function should randomly select one of those questions and return the chosen question object.
ℹ Additional info
Add a screenshot of your changes - if helpful.
Make sure the app works, otherwise the PR cannot be approved.
Link the PR with this issue (in the right panel "Development" -> select issue).

I would like to get to the ends of this one please.

Done


Redirect/create pages for old URLs

Pages to Create based off old content:
These pages don't exist on the new site, so here's a deep link to them on the old site.  If they get created on a different URL, be sure to add a redirect for them:

https://synshop.org/joining-syn-shop
https://synshop.org/donate # (tweak JS/HTML from /payment page)
https://synshop.org/teach-class
https://synshop.org/webform/teaching
https://synshop.org/covid-19-status
https://synshop.org/rules-and-guidelines-classes
https://synshop.org/payment
https://synshop.org/media
https://synshop.org/committees

Should Redirect
These URLs on the left should redirect to the ones on the right:

/past-events -> /events
/location -> /contact
/info -> /contact
/upcoming -> /events
/vote -> https://forms.gle/4rHcLy1uv1SHxurU8
/discord -> https://discord.gg/JKynwur
www.synshop.org/* -> synshop.org/*

Good go to
These work as is!

/
/contact
/robots.txt
/membership
/about

Research methodology
Looking at the access log file that goes back to 27/Dec/2021, I started by getting ALL URLs normalized:
grep " 200 " synshop.org-access_log| tr '[:upper:]' '[:lower:]'|cut -f7 -d" "|cut -d"/" -f1,2,3,4|cut -d"?" -f 1|sort|uniq -c|sort -nr > synshop.org.top.urls.ALL.txt

This results in synshop.org.top.urls.ALL.zip.
Then to get down to 47 URLs we run this and only take URLs that got more than 100 hits:
egrep -v "/user|/archive|/blog|/crss|/admin|/events|/node|/tags|well-known|/MarkUp|/modules|/taxonomy|/comment|/20|/xml|/misc|http" synshop.org.top.urls.ALL.txt

Which results in this list of 47:
4251578 /
1308667 /past-events
1239502 /sites/all/themes
 692035 /sites/default/files
 322373 *
 289596 /robots.txt
  84621 /contact
  66017 /rss.xml
  21248 /xrds
  18292 /contact/
  14187 /donate
   9352 /membership
   9048 /location
   8307 /joining-syn-shop
   8060 /about
   7525 /teach-class
   6051 /index.php
   3080 /lists
   1943 /covid-19-status
   1778 /info
   1561 /rules-and-guidelines-classes
   1518 /xrds/
   1419 /filter/tips
   1412 /payment
   1408 /synshoptalk
   1335 /webform/teaching
   1217 /media
   1170 /stripe-webhook
   1161 /livecam
   1153 /upcoming
   1124 /article/syn-shop-web-site-has-new-look
    966 //media/wp-includes
    957 /webform/syn-shop-talk-podcast-feedback
    939 /tracker
    921 /article/do-nato-money-vacuum-video
    916 /article/pre-first-friday-hack-fest-saturday-june-23
    890 /article/pre-first-friday-hack-fest-saturday
    880 /committees
    786 /paid-members
    745 /sites/all/libraries
    521 /aggregator/sources/2
    474 /openid/provider
    456 /about/
    320 //
    284 /install.php
    109 /themes/bartik/css
    107 /close/

Which we can further normalize/dedupe/cull into these 18:
/
/contact
/robots.txt
/membership
/about
/past-events -> /events
/location -> /contact
/info -> /contact
/upcoming -> /events
/joining-syn-shop
/donate (tweak JS/HTML from /payment page)
/teach-class
/webform/teaching
/covid-19-status
/rules-and-guidelines-classes
/payment
/media
/committees

Found a few redirects in the apache config for the old site which I added above.  Mainly /vote and /discord go to external sites
for posterity, here's the entire apache config:
<VirtualHost *:80>
        ServerAdmin<EMAIL_ADDRESS>        ServerName synshop.org
        ServerAlias www.synshop.org
        ServerAlias synshop.dorkbotlv.org
        ServerAlias synshop.synshop.org
        DocumentRoot /var/www/synshop
        ErrorLog ${APACHE_LOG_DIR}/synshop.org-error_log
        CustomLog ${APACHE_LOG_DIR}/synshop.org-access_log combined

        RewriteEngine on
        <If "%{REQUEST_URI} !~ m#^/.well-known/#">
                # Redirect all requests to ssl
                RedirectMatch 301 ^/(.*)$ https://synshop.org/$1
                RedirectMatch 301 ^/ https://synshop.org/
        </If>
</VirtualHost>
<VirtualHost *:443>
        ServerAdmin<EMAIL_ADDRESS>        ServerName synshop.org
        ServerAlias www.synshop.org
        ServerAlias synshop.dorkbotlv.org
        ServerAlias synshop.synshop.org
        DocumentRoot /var/www/synshop
        ErrorLog ${APACHE_LOG_DIR}/synshop.org-error_log
        CustomLog ${APACHE_LOG_DIR}/synshop.org-access_log combined

        SetEnvIf User-Agent ".*MSIE.*" \
                nokeepalive ssl-unclean-shutdown \
                downgrade-1.0 force-response-1.0
        CustomLog ${APACHE_LOG_DIR}/synshop.org-ssl_request_log \
                "%t %h %{SSL_PROTOCOL}x %{SSL_CIPHER}x \"%r\" %b"

        SSLEngine on

        # HSTS (mod_headers is required) (15768000 seconds = 6 months)
        Header always set Strict-Transport-Security "max-age=15768000"

        SSLCertificateFile /etc/letsencrypt/live/www.synshop.org/cert.pem
        SSLCertificateKeyFile /etc/letsencrypt/live/www.synshop.org/privkey.pem
        SSLCACertificateFile /etc/letsencrypt/live/www.synshop.org/chain.pem

        <Proxy *>
                Order deny,allow
                Allow from all
        </Proxy>
        ProxyPreserveHost Off
        ProxyPassInterpolateEnv Off
        <Location ~ "^/meetup-proxy/([A-z0-9]+\.meetupstatic\.com/.+)$">
                RequestHeader unset Cookie
                RequestHeader unset Host
                ProxyPassMatch http://$1
        </Location>

        RewriteEngine on

        #TODO: remove port number
        # Redirect requests to /wiki to wiki.synshop.org
        RedirectMatch 301 /wiki/(.*)$ https://wiki.synshop.org/$1
        RedirectMatch 301 /wiki https://wiki.synshop.org/

        #TODO: remove port number
        # Redirect all www requests to the base domain
        RewriteCond %{HTTP_HOST} ^www\.synshop\.org(:\d+|)$ [NC]
        RewriteRule ^/(.*)$ https://synshop.org/$1 [R=301,L]

        #voting
        RedirectMatch 301 ^/vote https://forms.gle/4rHcLy1uv1SHxurU8
        RedirectMatch 301 ^/smile http://smile.amazon.com/ch/45-4657308
        RedirectMatch 301 ^/discord https://discord.gg/JKynwur
        RedirectMatch 301 ^/zumo https://www.pololu.com/product/3126/resources
        RedirectMatch 301 ^/ZUMO https://www.pololu.com/product/3126/resources

        # vanity urls for covid page
        RewriteRule  ^/([cC]*)ovid([-sS]*)tatus([-19]*)$ https://synshop.org/covid-19-status  [R=301,L]
        RewriteRule  ^/([cC]*)ovid([-19]*)$ https://synshop.org/covid-19-status  [R=301,L]
        <Directory /var/www/synshop>
                Options +FollowSymlinks
                AllowOverride All
                Require all granted
        </Directory>
</VirtualHost>

Added in
/past-events /events
/location /contact
/info /about
/upcoming /events
/payment /donate
/joining-syn-shop /members
/teach-class /
/webform/teaching /
/covid-19-status /
/rules-and-guidelines-classes /
/media /
/committees /
And not sure how I forgot/didn't think about discord, but just went back and added it for your latest update.
/discord https://discord.gg/JKynwur
Skipping over smile, as it no longer exists, and vote as it links to a google doc from many years ago and presumably is not a url we actually use any more. It can always be added back in later if we choose to again though.

Awesome - thanks for the quick turn around.  Looking really good!
Fixes requested

URLs should word with and with out trailing slash.  I was confused for a bit why https://synshop-org.pages.dev/discord/ didn't work then saw it does work w/o trailing slash.
the 404 page doesn't have any navigation on it which makes it hard to find your to the content you're no doubt looking for ; )

Missing pages
Also, I saw we opted to not create any new pages but the "Donate" one.  Is this a tactic to just the site launched and then we can fix stuff later?  If yes, we should open tickets to track the things that are missing. For example, when some one needs to pay us, they can't have the page/receipt/form say "Donate" - we actually had to custom make that page to receive a many hundreds of dollar payment for services!  Also, while no one is teaching, we need to have them fill out that form etc.
If not and we never plan to create those page, we should let the board/vetted members know so there's no surprises.

* URLs should word with and with out trailing slash.  I was confused for a bit why `https://synshop-org.pages.dev/discord/` didn't work then saw it does work w/o trailing slash.

Odd, this worked fine for me in testing. Let me revisit it... there may be some nuanced differences between running it locally and on CF pages I need to take a look at

* the 404 page doesn't have any navigation on it which makes it hard to find your way to the content you're no doubt looking for ; )

This is due to complexity on how the 404.html file has to exist in the root of the directory and can't inherit the jekyll includes and had to be built by hand. The synshop icon works as a home link itself, as it does on the rest of the site, and a proper nav menu is on my todo list but is not listed as a must have for launch due to the complexity of getting it right. I don't find it particularly critical for launch, and am tracking it as #22

Missing pages

Also, I saw we opted to not create any new pages but the "Donate" one. Is this a tactic to just the site launched and then we can fix stuff later? If yes, we should open tickets to track the things that are missing. For example, when some one needs to pay us, they can't have the page/receipt/form say "Donate" - we actually had to custom make that page to receive a many hundreds of dollar payment for services! Also, while no one is teaching, we need to have them fill out that form etc.

I was unaware of the needed use-cases for any payments beyond donations and membership management flow payments. That said, the donate page/form should work just fine for this use case as it just routes to a Square submission form for a direct payment of a dynamic amount. I can just change the "donate" button to say something less prescriptive, like "pay" or "submit" and add a /payments redirect to the page, since all this page really does is act as a "Trigger" to fire off a stripe window to be filled in on their side, where you can even re-edit the dollar amount if desired.

Noting that the redirects with a trailing / still 404s:
curl -I https://synshop-org.pages.dev/discord/
HTTP/2 404
curl -I https://synshop-org.pages.dev/upcoming/
HTTP/2 404

Do we want to re-open or create a new issue?

d'oh - ignore me!!! you added a bunch of tickets ( like #24) and I wasn't reading close enough.  sorry!

also FWIW I already have the fixes staged, just haven't merged them in yet since I wanted to wait and combine any last changes I make today and tomorrow into the PR


Fixed #30491 - Made note on exception to UPDATE-v-INSERT logic

Ticket: https://code.djangoproject.com/ticket/30491
The docs for 'How Django knows to UPDATE vs. INSERT'
do not make any mention of a potentially confusing condition,
which is that updating a PK followed by a call to .save()
will always result in an INSERT rather than an UPDATE.
While this note is present in the primary key docstring
itself, it would be worthwhile to duplicate it to this section
as a gotcha.
See also: https://stackoverflow.com/q/56212145/7954504

I've amended this one based on your comment above @felixxm .  Do you think duplicating the short code example from topics/db/models/#field-options would be useful here too, or would it be overkill?

@bsolomon1124 Thanks! I think an example is not necessary, I rephrased your clarification.


Remove rspec and add minitest

Related to: https://github.com/rubocop-hq/rubocop-minitest/issues/1#issuecomment-518548748
PR fixes:

Removes rspec and initial specs added
Setups minitest and migrates the specs to minitest.

Screenshot:

We can remove .rspec file.
https://github.com/rubocop-hq/rubocop-minitest/blob/master/.rspec

@koic : Done with the changes.

Thanks 🎉


export getNeeded as depject/entry

change arguments to (sockets, needs) => api
use case is so this
var sockets = combine(modules)
sockets.app[0]()

can instead be
var sockets = combine(modules)
var api = entry(sockets, { app: 'first' })
api.app()

this (maybe) fixes the design question

Should combine have a way to specify the public interface?

Codecov Report

Merging #20 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   99.12%   99.13%   +0.01%
==========================================
  Files           4        5       +1
  Lines         114      116       +2
==========================================
+ Hits          113      115       +2
  Misses          1        1

Impacted Files
Coverage Δ

entry.js
100% <100%> (ø)

index.js
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d640338...27ecafd. Read the comment docs.

hmm, this is still backward compatible right? looks reasonable?
requiring two things is annoying. could it be
require('depject/init')(modules...)({app: 'first'}).app()?
where combine returns entry but already bound to sockets

could it be
require('depject/init')(modules...)({app: 'first'}).app()?
where combine returns entry but already bound to sockets

yeah that makes sense, however i have no problem requiring two things when it makes sense what is happening (i prefer clear over concise).
so good to merge @mixmix @mmckegg? is entry the right name for this function?

@ahdinosaur I'm using this branch in patchwork-next and it's great! Don't change a thing 😆

published as 3.2.0 :tada:


Remove deprecated funtions

1. Why is this change necessary?
It removes unused code, that is marked as deprecated in #2481
2. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: 84m:x: shyim:x: hlohaus:x: fivetideYou have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-26541
Please use this issue to track the state of your pull request.

thanks for your contribution @84m :+1: 🎉💙
it was merged on 5.8 with 910f96ac72599bfe4b4ce7550c72988ee3fbf6a0


[NEW ALGORITHM] Graham's Scan Algorithm in C

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:  Convex Hull using Graham's Scan
About:
This issue proposes the addition of the Convex Hull algorithm using Graham's Scan. The Convex Hull problem is essential in computational geometry, where the goal is to find the smallest convex polygon that encloses a given set of points in a 2D plane. Graham's Scan algorithm solves this problem with a time complexity of O(n log n) by sorting the points and processing them with a stack-based approach to ensure a counterclockwise traversal.
Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[X] Contributor in GSSoC-ext
[X] Want to work on it

@Sivasaiklu can you assign it to me?

@Sivasaiklu can you assign it to me?

@supreetkaursareen I cant assign, Project Admin have to assign, I am also a contributor

@Sivasaiklu assigned


deps: Run pod update sqlite3 to resolve pod install error

In f28dd0bfcb, we upgraded the Dart package sqlite3_flutter_libs past simolus3/sqlite3.dart@c16721003, which bumped the version of the sqlite3 pod published on CocoaPods (not to be confused with the Dart package with that same name on pub.dev).
So in flutter run targeting an iOS device, the pod install step would fail with output including the following:
    [!] CocoaPods could not find compatible versions for pod "sqlite3":
      In snapshot (Podfile.lock):
        sqlite3 (= 3.41.0, ~> 3.41.0)

      In Podfile:
        sqlite3_flutter_libs (from `.symlinks/plugins/sqlite3_flutter_libs/ios`) was resolved to 0.0.1, which depends on
          sqlite3 (~> 3.41.2)

    You have either:
     * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
     * changed the constraints of dependency `sqlite3` inside your development pod `sqlite3_flutter_libs`.
       You should run `pod update sqlite3` to apply changes you've made.

Flutter then gave its own output, along the lines of just that first bullet point:
Error: CocoaPods's specs repository is too out-of-date to satisfy dependencies.
To update the CocoaPods specs, run:
  pod repo update

Exception: Error running pod install

But actually, after studying both bullet points and trying their suggested fixes, it turns out the second one is right. So, follow it here by running pod update sqlite3.

Closing, as #148 was merged, superseding this.


python3Packages.furo: fix build

Motivation for this change
furo requires webpack since version 2021.11.12 and was recently updated in 7b890d59335f78ff3a06b237b3d06d06c7fe0e78. Without this dependency, the built package is broken as it is missing some important files. This can be seen when trying to build kitty on Linux. webpack doesn't work correctly in nixpkgs, see https://github.com/NixOS/nixpkgs/issues/42275. I wasn't able to fix this.
To make furo build correctly again despite the broken webpack, I switched to fetching the wheel instead of the source from PyPI, which has the necessary files already generated.
I also added a small test to make sure that this directory won't be empty again in the future.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 159255 run on x86_64-linux 1

3 packages built:

kitty
python310Packages.furo
python39Packages.furo


Drop line length lint which makes editing annoying

Setting a max-length means you have to break paragraphs into multiple lines which requires you to manually "rebalance" paragraphs when you edit them. One line, one paragraph works much better when maintaining existing docs - just turn on wrapping in your editor :)

I do not think this is a good idea.

I don't want to change my ide settings since most open-source projects don't follow this standard.
Limiting our self to 80 characters is something that feels very legacy, I can stretch my self to about 90 but I personally don't have anything against the current 200
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
https://youtu.be/wf-BqAjZb8M?t=260
Links in markdwon is long, so by adding a single link would almost reach the length. I know there is function that you can call on links that you can store in the bottom of the page. In general many people don't use it and it makes it really hard for people that don't use markdown readers to see where the link goes.

@NissesSenap I think you misunderstand? This PR turns off this lint, allowing rows to be of any length.

Haha yeah I did :)


Remove node.js dependency from tunnel service

The src/vs/workbench/services/remote/electron-browser/tunnelServiceImpl.ts is one of those few remaining things that currently require node.js in the renderer. To prepare for a sandboxed renderer, we need to start thinking how a non-node.js version would look like.
Some options:

switch to websockets (cc @alexdima)
create a service in the shared process that can establish the tunnel (similar to how terminals moved there)

The src/vs/workbench/services/remote/electron-browser/tunnelServiceImpl.ts is one of those few remaining things that currently require node.js in the renderer. To prepare for a sandboxed renderer, we need to start thinking how a non-node.js version would look like.
Some options:

switch to websockets (cc @alexdima)
create a service in the shared process that can establish the tunnel (similar to how terminals moved there)

LICENSE.txt

This has been done.


CodeCov for all the builds

Earlier, I added CodeCov code coverage using the Cobertura plugin which does not support the latest versions of Java.
Finally, I set up code coverage using JaCoCo plugin and it supports code coverage for all the versions of Java.

Codecov Report

Merging #191 into develop will decrease coverage by 4.67%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #191      +/-   ##
=============================================
- Coverage      69.02%   64.35%   -4.68%
- Complexity         0      501     +501
=============================================
  Files            151      151
  Lines           5366     5431      +65
  Branches         878      960      +82
=============================================
- Hits            3704     3495     -209
- Misses           974     1167     +193
- Partials         688      769      +81

Impacted Files
Coverage Δ
Complexity Δ

...sts/data/AbstractDataPagingCursorbasedRequest.java
42.85% <0%> (-14.29%)
0% <0%> (ø)

...otify/requests/data/AbstractDataPagingRequest.java
42.85% <0%> (-14.29%)
0% <0%> (ø)

...per/spotify/requests/data/AbstractDataRequest.java
62.5% <0%> (-12.5%)
1% <0%> (+1%)

...ts/data/library/RemoveUsersSavedTracksRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

.../requests/data/follow/UnfollowPlaylistRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

...equests/data/artists/GetSeveralArtistsRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

...s/data/tracks/GetAudioAnalysisForTrackRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

.../data/artists/GetArtistsRelatedArtistsRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

...racks/GetAudioFeaturesForSeveralTracksRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

...potify/requests/data/artists/GetArtistRequest.java
72.72% <0%> (-11.89%)
2% <0%> (+2%)

... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a4a1b...2e2ea99. Read the comment docs.

Thanks a lot!

Just a little hint: it's always a good idea to create a separate branch in your repo for PRs :)

I'll keep that in mind! :)

Just a casual question that keeps me bugging: When do the develop (and other) branches get merged into master, is there an interval when the develop branch gets reviewed or something else?
Curious to know. :)

Well, if there are changes to the source which require a new release for other projects, that depend in this, to include, then a new version is release = develop is merged into master. Or if someone would like me to. Do you want a new release? 😉

Looking at the fixes from the older PRs and the recent addition of code coverage results on the "home" page of the repo (README.md), yes! I think now would be a nice time to merge the changes into master, although, you have a better idea at this than me.
But yes, I want a new release :)

Actually, the development branch should be the default branch and thus displayed by default. I don't have the permissions to set this up though, maybe @thelinmichael finds a second to help us out.

As you have recently merged into master, the code coverage results are visible by default, and changing the default branch will result in the same, so, great.
But, there have to be some problems with the latest Travis build. It initially shows a build fail, I checked the build errors and a click to the 'current' tab on Travis CI unexpectedly shows a successful build.
If you know what's going on with it, or are familiar with such fails, I'd love to know why! :)

4.2.1 is on its way :)

Somehow 6f07c4fac6dc37ba194d4e70c44ef867806f9153 changed the before-deploy.sh script's permissions the other way around. I fixed this and force-pushed master (as no one else is working on it).

Thanks! This is the first repo I have contributed to, and it feels great. The experience was awesome!
Really looking forward to a lot more contributions. :)

Wow, you did a great job! Thank you for the feedback, that lightened up my day 😄

Who knew the first maintainer I have a conversation with would be a DJ! 🔥


Use make_module_from_file in gtc:numpy

Description
Use a load-retry loop with importlib instead of editing sys.path in the gtc:numpy backend.
Resolves https://github.com/GridTools/gt4py/issues/714.

bors try

Huh I just arrived at the same solution :D Can someone explain what is different in this case, and why it seems to solve #540 and #714 ?

This fix also works on a branch that does not have support for GT_CACHE_LOAD_RETRY_DELAY, and reading the m_computation file directly after writing in my reliable reproducer hints that it can immediately be read without problems and that a delay wouldn't help. Do we fully understand the issue?

Not fully, but the code that was there originally was quite poor :)
Here is one concern of mine with the original code:
                "path_backup = sys.path.copy()",
                "sys.path.append(str(pathlib.Path(__file__).parent))",
                f"import {comp_pkg} as computation",
                "sys.path = path_backup",
                "del path_backup",

What happens (I think, haven't checked) is that sys.path = path_backup is not actually doing a deep copy, so the del path_backup sets the path in an odd state. Even if that's fine, this is not thread safe.

Not fully, but the code that was there originally was quite poor :)

I agree, the original code was very error-prone (to say the least) and the code in this PR is simply better.


fedora-appstream license is GPL-2?

Your LICENSE file implies that the default license is GPL-2, but I think you mean for stuff here to be CC0-1.0?

Sure, all the metadata written by me is CC0-1.0. I guess the LICENSE needs updating.


docs (no particular scope): fix broken links

fix external link to uantwerpen.be
fix external link to python.org
fix external link to akka.io

@subotic It looks like something is going wrong with the GitHub CI checks here. The "Build Everything" check is missing. Could you please have a look?

@benjamingeer Ah, a PR from another organization/user. I will try to see what is wrong.

I was wondering if it's because this PR only changes documentation, not code.