Export react-scripts functionality

I started thinking about how I can extend the existing react-scripts functionality. E.g. I want to add some additional webpack plugins. I saw that #419 is the good move into an extendable system. But instead of forking react-scripts I want to extends or wrap it and benefit from the existing scripts.
My idea is to wrap the execution of the script in a function and pass the config and paths from outside:
function main (config, paths) {
  // ... build
}

This makes it possible to load the config and execute the script directly ...
if (require.main === module) {
  var config = require('./path/to/config');
  var paths = require('./path/to/paths');
  main(config, paths);
}

... or export the main function.
// ...
else {
  module.exports = main;
}

With this structure everyone can execute the script or use it like a library to provide own scripts.
I created a pull request (#776) with a few changes which make it possible to use it like a library. If someone want to checkout the code and has some hints what could be better feel free to let there a comment. :-)

I checked out the webpack config files in react-scripts and found out that these configuration also depends on ./config/paths.js. My thought was to reuse almost everything and extend the existing files by the missing stuff. But for me these would be also a change of the paths.
Maybe we could create a function which creates a webpack configuration like in react-boilterplate.

With this structure everyone can execute the script or use it like a library to provide own scripts.

Can you provide more specific use cases please?

Sure.
We need two additional tools for building our applications:

A custom webpack plugins which makes it possible to build our applications with some different functionality, resources, ...
scss-loader for the same reason like the plugin

My thought was how I can extend react-scripts instead of fork it because we want to benefit from the great work of create-react-app. (at this point a big thank you)
For this it would be nice to use react-scripts as a library to create my-react-scripts.
Example
./config/webpack.config.dev.js
var merge = require('webpack-merge');
// This is the "original" configuration from react-scripts
var base = require('react-scripts/config/webpack.config.dev');
var MyCustomWebpackPlugin = require('my-custom-webpack-plugin');

module.exports = merge(base, {
  loaders: [
    { test: /\.scss$/, loader: 'style!css!postcss!sass' },
  ]
  plugins: [
    new MyCustomWebpackPlugin()
 ]
});

This configuration file can be used in ./scripts/start.js of my-react-scripts:
var start = require('react-scripts/scripts/start');
var config = require('../config/webpack.config.dev');
var paths = require('../config/paths');

start(config, paths);

In my project I would install my-react-scripts and use it in my scripts.
Maybe we can extract the functionality of the react-scripts scripts into a lib/ folder instead of making the scripts usable in different ways. This would makes react-scripts into a library too.

I think you might have better luck with an approach like this custom-react-scripts.
Merging Webpack configs seems somewhat unsafe because we might move them or otherwise change them in incompatible ways.

Yes, the more I think about it I think it is not so useful and makes react-scripts more complicated and harder to maintain.
Thank you for you time. And thank you for your great work (not only for create-react-app).


Fixed dialyzer error in chef_wm_depsolver

I really didn't want to believe dialyzer on this one, but you can't ever reach
{timeout, Msg}

The timeout happens all the way down in ibrowse but it's returned as {error, req_timedout}, which is caught in oc_chef_wm_base:check_cookbook_authz and wrapped in erlang:error/1 so dialyzer was right!

:+1:

I should mention that pedant passes :D


vllm engine does not support quantization

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
vllm似乎已经支持了量化的模型？
Expected behavior
No response
System Info
No response
Others
No response

仅支持量化后的模型，不支持动态量化


Added more unsafe attributes

Added more unsafe attributes from this list  https://portswigger.net/web-security/cross-site-scripting/cheat-sheet

This change is

will send another pr


enable build on 2.2.2

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sharpeye096 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Adding error codes to ApiError

Feature request
Is your feature request related to a problem? Please describe.
I am building a website with supabase and the errors that is returned from supabase.auth only contains a general error code 400 and a message in english. This makes the different errors hard to distinguish from eachother.
Example:
User tries to create an account but the user is already registered so the error returned from supabase.auth.signUp  will be
{
  message: "User already registered",
  status: 400
}

Describe the solution you'd like
If the error included a specific error code mapped to particular error then providing a custom message would be easy.
Example:
{
  message: "User already registered",
  status: 400,
  errorCode: 1,
}

It would also be really awesome if the error codes was included in the documentation.
Describe alternatives you've considered
I've considered checking the string value returned in the error but if that would change in the future that would in turn break the application.

Over a year later and this has not been addressed. I thought features like this were standard practice.

no news on this? how people are handling authentication errors and internalization?

Thought this was industry standard and not something to implement upon request. Any developments on this?

This just made ditch supabase Auth for something else.
Its standard practise to return proper errors.
But till now over a year nothing has been done. There is no proper CURL documentation for us to implement the rest Auth into a SDK ourselves.
Even on the little examples, errors are not treated well. this is a no no for me,shows an unserious company in this aspect

+1 on this

I ran into the same issue and started collecting possible error messages by going through the GoTrue implementation.
I collect the errors for each endpoint in this Google Sheets doc. It's WIP so everything in this sheet is a little bit messy at the moment.
I also created a npm package that offers an error handler method for each function of GoTrue JS and therefore also Supabase JS.

Thx a lot Joel !
Le dim. 2 juil. 2023 à 15:24, Joel Domke @.***> a
écrit :

I ran into the same issue and started collecting possible error messages
by going through the GoTrue implementation.
I collect the errors for each endpoint in this Google Sheets doc
https://docs.google.com/spreadsheets/d/1GRFrER_WrleH7XgrzM_wHnZNNTtdH1Bc0cGa5kvyOQM/edit?usp=sharing.
It's WIP so everything in this sheet is a little bit messy at the moment.
I also created a npm package
https://github.com/joeldomke/supabase-errors-jsthat offers an error
handler method for each function of GoTrue JS and therefore also Supabase
JS.
—
Reply to this email directly, view it on GitHub
https://github.com/supabase/gotrue/issues/915#issuecomment-1616660491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABA5QT2GYVJ7FZHAZPVVMDXOFY7XANCNFSM6AAAAAAUGLI6EA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Running into the same issue – would love to have standardized error codes for auth (I'm using supabase.auth.signInWithOtp() specifically). Firebase has a doc about this: https://firebase.google.com/docs/reference/js/v8/firebase.auth.Error

+1 on this

Such improvement would be great for developer experience, +1 to this idea.

Any progress on this would be great help! Is there a way we can contribute ourselves?

+1, it's hard to use registration/signin manually with react native development using supabase lib, i am a js/ts library user but i would recommend having code status too...
I have already created feature request since Sept but no one have ever response to it

+1 on this, an error code it would be great to distinguish between errors and then we can make our own internationalization, but using a switch inside an effect its no option for a first class product, if we want to scale to millions we need that feature.
By the way all the good vibes to the supabase team, you're making a incredible work, with my team recently started a new project integrating it with next.js 14 and we are amazed.

Over a year later and this has not been addressed. I thought features like this were standard practice.

They have been busy with the unusable AI bs.

+1. Why is this not a standard already?

It's been two years and still no update?

Really, the lack of support for this is disappointing.
Being able to process errors in order to show users a customized (or localized) message is an essential feature.

@SamiChab @262hz Looks like the PR for this has been merged just recently:
https://github.com/supabase/gotrue/pull/1377
I believe it's in a release candidate at the moment.

It was already merged but i think its's for auth-js only is it different from supabase-js using supabase.auth?
is this only for auth-js ? and supabase-js not included?
            const response = await supabase.auth.signInWithPassword({
                email: email,
                password: password,
            })

Version: "@supabase/supabase-js": "^2.41.1"

How is this extremely basic and necessary feature still not implemented after more than 2 years???

How is this extremely basic and necessary feature still not implemented after more than 2 years???

That's why i stopped using supabase..

@Erybor This has been implemented (see https://supabase.com/docs/reference/javascript/auth-error-codes), but it's looks like there might be a bug for the "invalid login credentials" case?
For example, if I use the supabase.auth.admin.generateLink() function with an email address not in the database, I get this error (notice the code):
{
  data: { properties: null, user: null },
  error: AuthApiError: User with this email not found
      « stack trace » {
    __isAuthError: true,
    status: 404,
    code: 'user_not_found'
  }
}

However, if I try to log in (supabase.auth.signInWithPassword()) with invalid credentials I get this error back (missing a code):
{
  data: { user: null, session: null },
  error: AuthApiError: Invalid login credentials
      « stack trace » {
    __isAuthError: true,
    status: 400,
    code: undefined
  }
}

The docs pretty clearly state there should always be a code:

Errors originating from the server API classed as AuthApiError always have a code property that can be used to identify the error returned by the server.

@mashwishi I'd say you hit that exact same bug here: https://github.com/supabase/auth/pull/1377#issuecomment-2027954397
I've created a new issue to track that bug:
https://github.com/supabase/supabase-js/issues/1252
@kangmingtay I think this issue should be closed to avoid confusion about the status of this feature.

@haydn I'm using the Python client (latest version 2.5.3), went through the full source code and there's no "code" in AuthApiError. Only "name", "message" and "status". So I'm forced to check for the strings in messages which is very frustrating.
I think the Python documentation just has the JavaScript docs copy and pasted: https://supabase.com/docs/reference/python/auth-error-codes.

@Erybor That's not surprising, looks like the Python library isn't maintained by Supabase:

You probably want to go open an issue or PR in the repo to add support:
https://github.com/supabase-community/supabase-py


OLS-56: fix: ols switch schema parsing

Description
Cherry-picking commit to master. Doing it through PR to maintain merge history.
fix: replaced incorrect case conversion for device type
https://telecominfraproject.atlassian.net/browse/OLS-56
Summary of changes:

Replaced incorrect case conversion for device type.

Incorrect PR. Closing.


Cannot read property 'appendChild' of undefined

Jodit Version:  3.2.27
Code
import * as React from 'react';
import autobind from 'react-autobind';
import 'jodit';
import JoditEditor from 'jodit-react';

class Editor extends React.Component<any, any> {
   constructor(props) {
      super(props);
      autobind(this);
      this.state = {
         content: 'content'
      };
   }

   updateContent(value) {
      this.setState({content: value});
   }

   render() {
      return (
         <JoditEditor
            value={this.state.content}
            config={{
               readonly: false
            }}
            onChange={this.updateContent}
         />
      );
   }
}

export default Editor;

Expected behavior:
Shouldn't hit a type error
Actual behavior:
jodit.min.js:9 Uncaught (in promise) TypeError: Cannot read property 'appendChild' of undefined
    at Jodit.<anonymous> (jodit.min.js:9)
    at jodit.min.js:9
    at Object.next (jodit.min.js:9)
    at o (jodit.min.js:9)

When using the react wrapper, and without it - I end up with a cannot read property appendChild of undefined.
The editor still renders but it won't acknowledge the different button options.

Update - I tried without the react wrapper as well and ran into the same result.


fix uninitialized variable access by using the correct one

Signed-off-by: Markus Rathgeb<EMAIL_ADDRESS>

Merged, thank you.


Sidekiq instrumentation not creating child spans with SDK 1.2.1

Hi! I'm using the Sidekiq instrumentation with the option propagation_style: :child. This works fine with opentelemetry-sdk 1.2.0 but fails when upgrading to 1.2.1.
"Fails" here means that spans are not exported, tested with a minimal example using the console exporter.
Tracking down the problem, I think it all comes down to the same root cause of https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/535

opentelemetry-sdk 1.2.1 introduced this check in OpenTelemetry::SDK::Trace::Tracer#start_span (MR here):

https://github.com/open-telemetry/opentelemetry-ruby/blob/1159ec04aa62168c6a841273401b71c325fa5986/sdk/lib/opentelemetry/sdk/trace/tracer.rb#L32

In the Sidekiq instrumentation, unless you use the option trace_processor_process_one: true, the context is set as untraced:

https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/cc244b9a1fff8bb2c79be90dd6bafd1a4212a426/instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq/patches/processor.rb#L16

By the time the process span is going to be created, extracted_context is untraced. (Please note that for the default propagation_style: :link a new root span with its own context is created, and that works)

https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/cc244b9a1fff8bb2c79be90dd6bafd1a4212a426/instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq/middlewares/server/tracer_middleware.rb#L33

So for child spans tracer.in_span is used, which ends up calling the SDK start_span from point 1, which follow the untraced branch and, long story short, ends up creating a OpenTelemetry::Trace::Span instead of an OpenTelemetry::SDK::Trace::Span

OpenTelemetry::Trace::Span does nothing on finish, and spans are silently dropped:
https://github.com/open-telemetry/opentelemetry-ruby/blob/1159ec04aa62168c6a841273401b71c325fa5986/api/lib/opentelemetry/trace/span.rb#L154
(Edit: Not sure why some links are showing as snippets and others as huge links, sorry about that)

Related https://github.com/open-telemetry/opentelemetry-ruby/issues/1495

Upgrading to 'opentelemetry-instrumentation-sidekiq', '0.24.4' fixes the problem. Fix was added in https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/580


Convergence criteria not met...

@dgrzech
Thanks for uploading this, good work, man!
I've been trying to reproduce Killing/SobolevFusion results for over a year now. I have an implementation over InfiniTAM
Here is canonical in the first 65 frames of the Snoopy sequence: https://www.youtube.com/watch?v=0C2Djk4jo4I
Last frame:

Tracking kinda sucks and drifts a lot, that part is being worked on.
I've been capping the iterations at 200 frames and using voxel hashing to speed up the processing.
What really escapes me, though, is that, according to Mira Slavcheva herself in her emails to me, non-rigid alignment should converge within 30-150 iterations. Max-warp threshold was set to "0.1 mm" for KillingFusion (seems more like 0.1 voxel IMHO).
It seems like you've run into the same issue, i.e. your optimizations here for Snoopy are running (and are capped) to 2048 iterations.

You're seeing oscillations in warps for a small percentage of voxels across the voxel grid, no?
What is your take on this, is the whole convergence story just a story, i.e. convergence would work only if setting the max warp update threshold unreasonably high, resulting in bad reconstruction quality / high drift?

Thanks!

P.S. ultimately related to #1

hi!
your model in the canonical pose looks somewhat better than mine, good job.
in her e-mails Mira told me the same number of iterations till convergence. indeed, when running my code, warp for some of the voxels never really converges. the most troublesome area for me seems to be the voxels at the sdf truncation boundary.
i do think that 30-150 gradient descent iterations to guarantee convergence sounds very optimistic. i also don't really know why i wasn't able to exactly reproduce the results from the paper and i'd be really happy to learn what the problem is and fix it

Sure, I'm available for any correspondence regarding this now or in the future. TBH, Mira didn't sound completely sure in her emails about what was going on in her code, and some of the statements she made seem contradictory to the math given in the papers.
I'll take a dipper debug through your code later on and see if I notice anything that doesn't mesh with what I have. Maybe we could improve each-other's code. I wouldn't say that my result is better -- I used the masked version of the Snoopy sequence (masks as provided from Mira's website). Also, for some reason, the InfiniTAM rigid alignment / tracking that I used instead of Mira's SDF-2-SDF algorithm fails horribly beyond the first hundred frames (hence the result I give is only to frame 65).
I'm working on an alternative hierarchical schema and some more advanced filtering technique (than conventional bilateral filter) for the input data, the result is open source in one of my repos, and I'll let you know if I ever get anywhere with that.

Hi @Algomorph,
Thanks a lot for sharing the results. You got a very nice reconstruction! I am trying to re-implement SobolevFusion on InfiniTAM as well, can I ask how many iterations and the step size for this reconstruction? The screenshots are my results after 65 frames and I don't get as good result as yours (I am using 1000 iterations per frame and step size 0.05). I haven't got the sobolev gradient flow implemented so it's just data term and Tikhonov term in L2 space...
Without mask:

With mask:

@Ryan-Zirui-Wang , my result was with tikhonov term and sobolev smoothing on and I believe the specific one you're looking ad was done on the CPU with 200 iterations and step size 0.1 and with voxel block hashing. The tikhonov smoothing weight I believe was set to 0.2.
I propose for you to grab my code directly from https://github.com/Algomorph/InfiniTAM by forking & branching and start stripping off dependencies that aren't 100% necessary, like VTK, so you can build it easily. there is a lot of code I used for analysis that should simply be moved to a separate repository.
After this you can merge your code with my implementation (if necessary) to combine your effort with mine. As you know, I'm working on a separate codebase right now, but I can be responsive if you choose to go this route and any issues arise.

@Algomorph thanks for the input. I'll try your InfiniTAM branch and see what is different

@Algomorph hi guys,  Thanks for sharing the results, good job.
I've seen your code  in the branch feature/DynamicFusion, I have some questions to ask.

Are there some test results of InfiniTAM Teddy?And Do you have more detailed test results?
2)The result model of the Snoopy does not seem smooth enough,What are the possible reasons?

Thanks!


Forward Access Token and/or ID-Token to backend

For #13: Forward the access token and/or ID token as request header with custom names and prefixes.

Merge before #17 #15 #18

@miwig Done with the changes, tested it and works. Thanks.


The Hover Card example result in a  tag within a  tag

Current Behavior
The example in the docs:
...
  <HoverCardTrigger>
    <Button variant="link">@sveltejs</Button>
  </HoverCardTrigger>
...

This results in a <button> tag with a <a> tag, as HoverCardTrigger creates a <a> tag. This results in incorrect behavior.
A hover card will not appear if you switch to the trigger using the Tab key.
Similar to this issue.
Expected Behavior
As for now asChild prop is not implemented in radix-svelte I think Button component must be replaced with plain text or <span> tag with the necessary tailwind classes.
Steps To Reproduce

Add a hover card using the example in the docs (code tab in the docs).
View the code to see a <button> tag within a <a> tag
Attempt to Tab over elements

Link to Reproduction / Stackblitz
No response
More Information
No response

@huntabyte I can fix this issue. Assign this task to me if needed. Thanks.

@dcheglakov all yours! Thank you!


requiredText property in question types

When the user sets required=true the current "error" test that appears when a question is not answered is "This field is required". For some questions (at least for slider) this message is not perfect (slider is not exactly a field). So let users change this default message with a requiredText property (default "Please answer this question").

You can already do that using the errorMsg object
{
  type: 'slider',
  require: true,
  errorMsg: {
    required: 'my custom message'
  }
}

If you'd like a different default message, it is very simple to change...


Update RBAC policies

The service account has missing permissions for the GPM to be able to have read access to config.gatekeeper.sh apigroup.

Adding

- apiGroups: ["config.gatekeeper.sh"]
  resources: ["*"]
  verbs: ["get", "list", "watch"]

Tagging @ralgozino for review and merge for the next release.

Hello @kg-ops !
I wonder why I didn't notice this before... I'll have to investigate that.
Thanks a lot for spotting it and for the PR!

Thanks again @kg-ops for the help. Let us know if you find anything else to improve 🙂


[Cassandra]  Not all configurations exposed at package options level

Created a ticket, but also sharing here.   This was against the old framework but still seems to apply, the properties below are available for configuration but not exposed at the package options level.
https://jira.mesosphere.com/browse/DCOS_CASSANDRA-42
dcos package install --options myoptions.json cassandra
I receive the error below
Unexpected properties: ['endpoint_snitch', 'gc_warn_threshold_in_ms', 'key_cache_size_in_mb',
'memtable_cleanup_threshold', 'memtable_flush_writers', 'permissions_validity_in_ms',
'phi_convict_threshold', 'roles_update_interval_in_ms', 'roles_validity_in_ms']
myoptions file is
{{{ "service": { "name": "cassandra-c1", "data_center": "Cassandra", "principal": "cassandra_principal", "cpus": 0.1, "mem": 512, "heap": 256 }, "nodes": { "cpus": 2.0, "mem": 4096, "disk": 10240, "disk_type": "ROOT", "heap": { "size": 1024, "new": 100 }, "count": 1, "seeds": 1 }, "cassandra": { "authenticator": "PasswordAuthenticator", "authorizer": "CassandraAuthorizer", "concurrent_reads": 96, "concurrent_writes": 128, "compaction_throughput_mb_per_sec": 128, "endpoint_snitch": "GossipingPropertyFileSnitch", "gc_warn_threshold_in_ms": 500, "key_cache_size_in_mb": 256, "memtable_allocation_type": "heap_buffers", "memtable_cleanup_threshold": 0.6, "memtable_flush_writers": 8, "num_tokens": 64, "permissions_validity_in_ms": 60000, "phi_convict_threshold": 12, "roles_validity_in_ms": 60000, "roles_update_interval_in_ms": 5000 } }}}
It appears in issue #283 they were added to the application configuration. I also see them in the schedule.yml as environment replacements.
It appears they were never added to the universe config file so are being rejected at that point when used in the options file. They do not appear when you run
dcos package install cassandra --config
Environment was DCOS 1.8.7 and 1.9-rc3.
dcos package describe cassandra
{
"description": "Apache Cassandra running on DC/OS",
"framework": true,
"maintainer"<EMAIL_ADDRESS>"minDcosReleaseVersion": "1.7",
"name": "cassandra",
"packagingVersion": "3.0",
"postInstallNotes": "DC/OS Apache Cassandra has been successfully installed!\n\n\tDocumentation: https://docs.mesosphere.com/current/usage/service-guides/cassandra/\n\tIssues: https://dcosjira.atlassian.net/projects/CASSANDRA/issues",
"postUninstallNotes": "DC/OS Apache Cassandra service has been uninstalled.\nPlease follow the instructions at https://docs.mesosphere.com/current/usage/service-guides/cassandra/uninstall to remove any persistent state if required.",
"preInstallNotes": "DC/OS Cassandra Service default configuration requires 3 nodes each with 1.5 CPU shares, 5376MB of memory and 11264MB of disk for running Cassandra Nodes. And, 1 node with 0.5 CPU shares, 2048MB of memory for running the service scheduler.",
"selected": true,
"tags": [
"data",
"database",
"nosql"
],
"version": "1.0.25-3.0.10"

Hi Fran, thanks you for pointing this out.
This is a valid issue we plan to address.
At the moment our Engineering team is focused on delivering some important new features, but we are happy to accept a high quality PR.

I have already verified I can pass them in the JSON directly and they properly configure Cassandra, this is just for the universe package. I suspect it is substantially easier for you, but I can look into.  I'll see what I can do about a PR.
Cassandra tuning and being able to set those properties is very important to anyone using this framework for large write quantities.   We have seen substantial performance gains manipulating them.  Adding new features without fixing current problems really shouldn't be top priority.  I could see if this was a major code change, but its just packaging mistake.
Properties not in package options:
'endpoint_snitch',
'gc_warn_threshold_in_ms',
'key_cache_size_in_mb',
'memtable_cleanup_threshold',
'memtable_flush_writers',
'permissions_validity_in_ms',
'phi_convict_threshold',
'roles_update_interval_in_ms',
'roles_validity_in_ms'

This appears to be fixed in the latest version, I was able to pass in via options file.


Matterbridge doesn't bridge messages from Telegram Bot to WhatsApp

Describe the bug
Any bot messages doesn't get bridged to WhatsApp.
Expected behavior
I expected that every message in the group was bridged to the Whatsapp.
Screenshots
Telegram side:

Whatsapp side:

Environment

OS: Windows 10, 64 bits
Matterbridge version: 1.24.0-windows-64bit

Additional context
I have tested with other user on Telegram beside mine and the message arrive succefully. It's just the bot message that can't.
Configuration file
[telegram.mytelegram]
Token="MYTBOTID"
RemoteNickFormat=""
MessageFormat="HTMLNick"
[whatsapp.mywhatsapp]
Number="MYNUMBER"
SessionFile="session-MYNUMBER.gob"
QrOnWhiteTerminal=false
RemoteNickFormat=""
[[gateway]]
name="gateway1"
enable=true
[[gateway.inout]]
account="telegram.mytelegram"
channel="CHATID"
[[gateway.inout]]
account="whatsapp.mywhatsapp"
channel="GROUPID"

https://core.telegram.org/bots/faq#why-doesn-39t-my-bot-see-messages-from-other-bots

sad.


Failed to connect when there are more than 3 peers

Dear, actually the problem i am getting is when i connect user more than 3 in the conference call. It start behaving strange and random disconnects happens with multiple users. Can you help in that.

This is a continuation from https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-js/issues/95#issuecomment-695750849.

@naveedaziz  could you please provide detailed information on what's going on including debug logs. As is, this is not an actionable issue.

Resolving as stale


metric problem

i evaluated the checkpoint at task of referring object classification on LVIS, the reproduced results is so much higher your official paper,
your paper(LVIS, sim:87.06, IoU: 62.9 ), the reproduced results(sim:0.927,iou:0.698). Otherwise,  the reproduced results on RefCOCOg is (METEOR:28.8, CIDEr: 384.3),  your paper(METEOR:23.9, CIDEr: 162.5), where is the problem?

Hi there,
Actually, your procedure is correct. The ckpt provided in the repo is from a model trained with further improvements, whereas the ckpt used in our paper was from an earlier version that did not undergo extended training.

it's ok to give some details about the further improvements?


xterm hangs when using G2Explorer.py

I deployed a new Marketplace stack and tried testing G2Explorer.
(g2) help works.
(g2) search john smith returned 4 results, just like the web app.
(g2) compare 1200006, 2000001 works
(g2) get 1 (or any number) hangs.  with this error message in the logs:
2022-05-13 20:04:48,378 senzing-50240101I Senzing X-term version: 1.2.0 updated: 2021-08-30
--
2022-05-13 20:04:48,378 senzing-50240102I Senzing X-term serving on http://<IP_ADDRESS>:5000
2022-05-13 20:05:32,311 senzing-50240103I Connected. PID: None
2022-05-13 20:05:32,314 senzing-50240104I Started background task. PID: 8 Running command: 'bash'
Exception in thread Thread-4:
Traceback (most recent call last):
File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
self.run()
File "/usr/lib/python3.9/threading.py", line 892, in run
self._target(*self._args, **self._kwargs)
File "/app/app.py", line 131, in read_os_write_socketio
output = os.read(app.config["file_descriptor"], max_read_bytes).decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 4094: unexpected end of data

work around, kill the running xterm task and let another respawn and don't use get.
get <any number> will hang any xterm task.
Note this works in the SSHD container which is why I believe it's an Xterm issue.

Retested this with basic CFT, most recent marketplace CFT, and the marketplace CFT in S3 and I could not reproduce this error.  very odd.

Pull requests:

https://github.com/Senzing/docker-xterm/pull/74

Closing for now.

xterm is behaving badly again.
2022-06-09 19:37:22,170 senzing-50240101I Senzing X-term version: 1.3.0 updated: 2022-05-19
2022-06-09 19:37:22,170 senzing-50240102I Senzing X-term serving on http://<IP_ADDRESS>:5000/
2022-06-09 19:41:05,687 senzing-50240103I Connected. PID: None
2022-06-09 19:41:05,690 senzing-50240104I Started background task. PID: 8 Running command: 'bash'
Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.9/threading.py", line 892, in run
    self._target(*self._args, **self._kwargs)
  File "/app/app.py", line 153, in read_os_write_socketio
    output = os.read(APP.config["file_descriptor"], max_read_bytes).decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 4094: unexpected end of data
2022-06-09 19:44:38,132 senzing-50240103I Connected. PID: 8
beyond the error, it’s odd that it says it’s version 1.3.0 when the cloudformation is using Xterm:public.ecr.aws/senzing/xterm:1.3.1
[12:51](https://senzing.slack.com/archives/D0240TDD6E5/p1654804303415699)

when it got here i was running G2Explorer.py get 13 which is an id of a record.  it hung in xterm, but ran fine in sshd.  i closed the xterm tab and opened a new one, the prompt doesn’t come back… as if it’s still hung.

Pull requests:

https://github.com/Senzing/docker-xterm/pull/74
https://github.com/Senzing/docker-xterm/pull/78
https://github.com/Senzing/docker-xterm/pull/79
https://github.com/Senzing/docker-xterm/pull/80
https://github.com/Senzing/docker-xterm/pull/81


make sure metadata for logging is all strings

Promtail doesn't like some types of fields. And it happens to be binaries.

I'm not that familiar with lager. What problem is this solving? Is the gateway_mac field sometimes not formatted properly?

There is a promtail container following the logs. It expects the field=msg format for it's parsing.
It doesn't like binary fields, so it complains about things that look like gateway_mac=<<"asdf">>.


Streamline initialization and add Rviz goal height param

A few minor things here to generalize application and smooth out potential issues for new users:

The (infinite) wait for world->camera doesn't seem necessary for Faster (it doesn't seem to use this transform). If this is a requirement for system performance / flight in hardware, this check should probably happen elsewhere in the system, and definitely not within a class constructor. It also assumes a hardcoded "quad_name/camera" transform naming which is not entirely general.

Minor point to initialize the internal Faster object pointer before starting subscribers/callbacks that may rely on it.

Adds a ROS param rviz_goal_height to specify a desired z-value for 2d nav goals specified in Rviz (rather than the hard-coded 1m).

Thanks @mrkris13, just merged it!


RA-GZRS / RA-GRS documentation not accurate

Hi:
We were recently working on a multi region strategy. We use Storage Accounts for different purposes on application's architectures so we set strategies for failover and failback. On testing phase we notice that documentation is not accurate regarding read operations on event of failover on RA-GZRS / RA-GRS  Storage Accounts. We open a Support Ticket and they confirmed the documentation is not accurate or is really hard to understand that in fact it's not possible to read data from the secondary replica on event of failure on the primary region. Section below states that this is possible but it's not:
"If your applications require high availability, then you can configure your storage account for read access to the secondary region. When you enable read access to the secondary region, then your data is always available to be read from the secondary, including in a situation where the primary region becomes unavailable. Read-access geo-redundant storage (RA-GRS) or read-access geo-zone-redundant storage (RA-GZRS) configurations permit read access to the secondary region."
Also the full section "Design your applications for read access to the secondary" says that it's possible.
I think this document needs to be more precise regarding this matter because this can change the decisions and options we have for different strategies and it can impact planning and generate delays.
Documentation: https://learn.microsoft.com/en-us/azure/storage/common/storage-redundancy
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f618f40d-ae53-5c3b-d8bf-0e80614f66d3
Version Independent ID: 93083407-8f1e-b3e2-6a62-e30be5e1fbcb
Content: Data redundancy - Azure Storage
Content Source: articles/storage/common/storage-redundancy.md
Service: storage
Sub-service: common
GitHub Login: @jimmart-dev
Microsoft Alias: jammart

@icontreras7
Thanks for your feedback! We will investigate and update as appropriate.

@icontreras7
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

@jimmart-dev
Can you please check and add your comments on this doc update request as applicable.

Thanks for your contribution to our documentation
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
?
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


typings: not found

This module keeps on failing on my build system with the following errors
10:08:24.279 npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'typings install'.

+1

@Ellipizle  you willl need to install typings as global first.
npm install typings -g
It should probably be documented or automatically installed when you first run npm install, any ideas?

I think the issue could be in that the typings package is currently a devDependency and not a dependency, so it is not installed when a user includes ng2-inline-editor as a dependency. I would guess that if it is moved to dependencies, when running typings install, first it would look in ./node_modules/.bin/typings (relative to the ng2-inline-editor dir). However to try it a version with typings as a dependency would have to be published and then installed in an environment without typings in the global packages.


fix(ci): windows build

Looks like builds are broken on windows-latest: https://github.com/ipfs/ipfs-companion/actions/workflows/ci.yml
The reported error: gyp ERR! stack Error: Could not find any Visual Studio installation to use
I could not test this as I don't have perms to run CI nor do I have access to a windows machine atm, but there seems like two ways to fix this:

We can either move to node-v16 which ships with build tools.
Or add this dependency based on https://github.com/felixrieseberg/windows-build-tools

the github actions/setup-node@v1 is also 2 major versions behind, so should be upgraded as well, but I'm unsure of the breaking API changes between the two.
🤞🏽 this should fix the broken builds in theory.

@lidel looks like the build is stuck https://github.com/ipfs/ipfs-companion/runs/8139100657?check_suite_focus=true
Turns out this is an issue: https://github.com/felixrieseberg/windows-build-tools/issues/208
I added the suggested fix in the thread, sorry I couldn't test it locally without a windows machine. But that didn't kill the existing build.

@lidel @SgtPooki I just realized I can run GH Actions on my own fork as well. so now this passes: https://github.com/whizzzkid/ipfs-companion/runs/8143445527?check_suite_focus=true


Update OpenAI Default Model to 'gpt-3.5-turbo-instruct'

As per the guidance provided on the OpenAI model documentation page (https://platform.openai.com/docs/models/gpt-3-5), the text-davinci-003 model is scheduled to be discontinued as of January 4, 2024.

In response to this upcoming change, I have updated the default model in the langchain.llms.openai.OpenAI class from 'text-davinci-003' to 'gpt-3.5-turbo-instruct', following the recommendations provided by OpenAI.

Additionally, I have also updated the modelname_to_contextsize() method to include the maximum token count for the new models(gpt-4-1106-preview, gpt-3.5-turbo-1106)

Revised the previously modified openai.py file after its relocation to the following path, and submitted a new PR request: libs/community/langchain_community/llms/openai.py"

Revised the previously modified openai.py file after its relocation to the following path, and submitted a new PR request: libs/community/langchain_community/llms/openai.py"


As plugin

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: pengwei1024:white_check_mark: lomanyong:x: charvenhecharvenhe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.


problem

System Health details
2024-11-15 08:46:46.381 ERROR (MainThread) [custom_components.chime_tts.helpers.media_player_helper] Media file "%s" is not in a local media directory. See https://www.home-assistant.io/more-info/local-media/setup-media/
2024-11-15 08:46:46.382 ERROR (MainThread) [custom_components.chime_tts.queue_manager] Error processing service call {'function': <function async_setup..async_say_execute at 0x7fb6f0f5d580>, 'args': (<ServiceCall chime_tts.say (c:01JCQCKS5AM87C3HFKH27JB9C7): chime_path=bells_2, end_chime_path=bells, device_id=['a9920b6727ce84d3ed41f7064d001640']>, False), 'kwargs': {}, 'future': }:
2024-11-15 08:46:46.382 ERROR (MainThread) [custom_components.chime_tts] Error calling chime_tts.say service:
File "/config/custom_components/chime_tts/init.py", line 138, in async_say
File "/config/custom_components/chime_tts/queue_manager.py", line 57, in _process_service_call
File "/config/custom_components/chime_tts/init.py", line 186, in async_say_execute
File "/config/custom_components/chime_tts/init.py", line 293, in async_prepare_media
File "/config/custom_components/chime_tts/init.py", line 819, in async_get_playback_audio_path
File "/config/custom_components/chime_tts/helpers/filesystem.py", line 312, in async_get_external_url
File "/config/custom_components/chime_tts/helpers/filesystem.py", line 301, in get_external_address
Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
non esegue l'azione
Reproduction steps
1.cdd
2.cddd
3.cddd
...
c
Debug logs
2024-11-15 08:46:46.381 ERROR (MainThread) [custom_components.chime_tts.helpers.media_player_helper] Media file "%s" is not in a local media directory. See https://www.home-assistant.io/more-info/local-media/setup-media/
2024-11-15 08:46:46.382 ERROR (MainThread) [custom_components.chime_tts.queue_manager] Error processing service call {'function': <function async_setup.<locals>.async_say_execute at 0x7fb6f0f5d580>, 'args': (<ServiceCall chime_tts.say (c:01JCQCKS5AM87C3HFKH27JB9C7): chime_path=bells_2, end_chime_path=bells, device_id=['a9920b6727ce84d3ed41f7064d001640']>, False), 'kwargs': {}, 'future': <Future pending cb=[Task.task_wakeup()]>}:
2024-11-15 08:46:46.382 ERROR (MainThread) [custom_components.chime_tts] Error calling chime_tts.say service:
  File "/config/custom_components/chime_tts/__init__.py", line 138, in async_say
  File "/config/custom_components/chime_tts/queue_manager.py", line 57, in _process_service_call
  File "/config/custom_components/chime_tts/__init__.py", line 186, in async_say_execute
  File "/config/custom_components/chime_tts/__init__.py", line 293, in async_prepare_media
  File "/config/custom_components/chime_tts/__init__.py", line 819, in async_get_playback_audio_path
  File "/config/custom_components/chime_tts/helpers/filesystem.py", line 312, in async_get_external_url
  File "/config/custom_components/chime_tts/helpers/filesystem.py", line 301, in get_external_address

Diagnostics dump
No response

I have released a new version, v1.2.0, which has some fixes that may address this issue. Can you please upgrade to the new version and let me know if it is resolved?


Use single test Gemfile

What does this PR do?
After the work on #116, it allows to remove the multiple Gemfiles and allow to configure a chef version by environment variable.
Motivation
This would be more persistent and reliable in the future if we have to support more versions of Chef.

Mmmm, isn't the Gemfile.lock specifying different versions than the Gemfile now (for certain values of CHEF_VERSION)? Shouldn't that cause bundle install to fail? I don't get why it's not failing.
Note how on Puppet [1] we call rm -f Gemfile.lock to avoid this.
[1] https://github.com/DataDog/puppet-datadog-agent/blob/master/.travis.yml#L2


Use hierarchical structure in yaml file to specifiy data files

Re-organized the elements that define the input data files in survey_year_2019_config.yml to use a hierarchical structure that clearly groups elements by file type.
Partially addresses #109, and builds on the structure drafted in https://github.com/uw-echospace/EchoPro/issues/111#issuecomment-1751866907
Also includes a couple of minor cosmetic changes that improve readability.

Thank you @leewujung ! I've commented on your inline comments.
In this PR I was focusing solely on the parameters that specify file paths and Excel sheet names. I'm happy to expand the scope to the stand-alone parameters at the top, that you commented on.
One question for you: do you think we should group all the data-file parameters under a parameter like hake_data? Then, krill inputs would be under a header like krill_data. I can see pros and cons to doing that grouping.

One question for you: do you think we should group all the data-file parameters under a parameter like hake_data? Then, krill inputs would be under a header like krill_data. I can see pros and cons to doing that grouping.

I would prefer to not over-categorizing there, to make whatever that are in the yaml file not so hard-locked with the species. What I think we can do is to have yaml "template" for hake, and a different yaml "template" for krill. We can then add other species with data files that are relevant to those in the future. And of course with this approach we would have to have species-specific yaml checkers, for hake and krill, to start with.

PR #126 (merged) created the conflicts now seen in this PR. I'll fix the PR after I resolve the conflicts locally.

Sounds good. I'll merge main to #123 once you fix this one, and we can merge that at that time.
I'll continue my reading still based on the current code without #126, and if anything identified there (#125) have already been resolved by #126 we can just tick the boxes. If you could merge this PR today that'll still help significantly with avoiding redundant effort. Thanks!

I've merged main and moved species_id_mapping dict from yaml file to biological_data.LoadBioData. I'll go ahead and merge this PR now. Thanks for your review!


Fix/polychrome img

[x] I have tested my component
[x] I have updated the documentation or there is no documentation needed

:tada: This PR is included in version 1.4.0-rc.65 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG] Error: Null when using LLMSYS models

Describe the bug
Got the error message of "Error: null" when using LLMSYS models, including: claude-v1, alpaca, vicuna, chatglm.
Desktop (please complete the following information):

OS and version: [macOS 13.3.1], Apple M1 Pro

Additional context
I was able to use these models with the previous version 1.17.10. However, after I manually installed 1.18.11 to replace 1.17.10, the bug appeared. Even though I uninstall 1.18.11 and install 1.17.10 again, the bug is still there.

Same issues here........... With Window 11.
On previous version was working fine , now that I'm testing the ChatALL-1.18.11, (claude-v1, alpaca, vicuna, chatglm) are not warking .

Same issues here........... With Window 11.
On previous version was working fine , now that I'm testing the ChatALL-1.18.11, (claude-v1, alpaca, vicuna, chatglm) are not working .

Yeah, I used another window computer and came across the same issue too. Besides, I found that the Claude-v1 model is not supported in lmsys arena. I think it might be because the lmsys API has changed.

Just now I have tried to go back to different Chat-All versions, and I believe you are right, cannot communicate with chat Claude-v1 that was one of my favorite. I think sometigh wrong - as you said - with the API.

I am facing with same issue


Plant Machines stop functioning inside a colonie (Minecolonies)

Once a colonie is established, plant machines within range of the colonie will stop functioning, it gets power but that's about it.
Industrial Foregoing Version: industrialforegoing-1.12.2-1.8.1-120
TeslaCoreLib Version: tesla-core-lib-1.12-1.0.12
Crashlog (If Any): N/A

I can't do much about it, if Minecolonies stopa fake players from doing stuff I can't override it.

ah ok, ill trash minecolonies then :+1:

Disabling

B:enableColonyProtection=false

Allows fake players, this is safe on single player, or on a server where you build with friends.


Skeleton code for annotation processor.

Add build changes and skeleton code (with test harness) for
the Operator annotation processor. This change focuses on build
and test-related changes, and generates an empty Ops class.
Please see #7149 for the master tracking issue.

Can one of the admins verify this patch?

@asimshankar what do you think?
Jenkins, test this please.

@asimshankar ping

@tensorflow-jenkins test this please

Jenkins, test this please

Could a kindly member look at/restart the testing? Looks like the "Ubuntu CC" test didn't run, or stalled. Thanks!

Jenkins, test this please.


socket is not closing correctly

I can only connect once to the FTP in PASV, the connection is keep alive and I can get many files, if I end/destroy and connect again, once I try to GET i receive the connection REFUSED error since
socket.connect(port, ip);
fails.
How do I close the socket correctly ?
If I try to connect via FileZila I can reconnect as much as I want and still GET files.
Filezila returns
Status:	Disconnected from server
Trace:	CRealControlSocket::DoClose(66)
Trace:	CControlSocket::DoClose(66)
Trace:	CFtpControlSocket::ResetOperation(66)
Trace:	CControlSocket::ResetOperation(66)
Trace:	CFileZillaEnginePrivate::ResetOperation(66)
Trace:	CRealControlSocket::DoClose(66)
Trace:	CControlSocket::DoClose(66)
Trace:	CControlSocket::DoClose(66)
Trace:	CFileZillaEnginePrivate::ResetOperation(0)
when disconnecting

Did u find a solution? I need to upload a file every N minutes and the server refuses my connection due to concurrent connections. Did u find a way to close the socket correctly?


ARROW-5755: [Rust] [Parquet] Derive clone for Type.

Derive clone for type.

@sunchao @sadikovi @paddyhoran  Please help to review.

Codecov Report

Merging #4719 into master will decrease coverage by 9.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4719       +/-   ##
===========================================
- Coverage   86.42%   77.17%    -9.25%
===========================================
  Files         989       83      -906
  Lines      137498    23929   -113569
  Branches     1418        0     -1418
===========================================
- Hits       118834    18468   -100366
+ Misses      18302     5461    -12841
+ Partials      362        0      -362

Impacted Files
Coverage Δ

rust/parquet/src/schema/types.rs
89.35% <ø> (ø)
:arrow_up:

python/pyarrow/ipc.pxi

cpp/src/arrow/csv/chunker-test.cc

cpp/src/parquet/column_page.h

cpp/src/parquet/bloom_filter-test.cc

cpp/src/arrow/array/builder_decimal.cc

r/src/symbols.cpp

cpp/src/arrow/io/test-common.h

cpp/src/arrow/util/int-util-test.cc

cpp/src/arrow/python/io.cc

... and 897 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2264791...0a69836. Read the comment docs.

The coverage drop is because it was broken for a long period of time. Interestingly that it does work now - I thought the fix will not work in #4700. cc @fsaintjacques .

@sunchao seems like it didn't segfault: https://travis-ci.org/apache/arrow/jobs/551302470#L1943

@fsaintjacques yup - not sure what happened in the first run, but good so far :) (although the tests need to be fixed)


Remove all TypeVars

Fixes # (provide issue number if applicable)
Fix #1483
Fix #1482
Edit: It seems that it resolved all mypy issues except for the ones with other modules, so I am marking this PR as a fix to #1482.

Cool, thanks!


feat: user event submission form

As a user I want to be able to see a form where I can enter several fields to submit my independent/one-off tech event.
This data should be able to be:

validated (checked for potential trolling?)
parsed
connected to the master google calendar

Id: https://calendar.google.com/calendar/embed?height=600&wkst=1&bgcolor=%23ffffff&ctz=America%2FChicago&title=Nola Dev Events&src=NGE0MjQ3ZTExYjI1ZmRjZTY3NWEzMmRhNzI1MmZiYTBjZTcyOGY2YWUwZWM0NzYxNmYyZGUwMzM1OTJlODVjOUBncm91cC5jYWxlbmRhci5nb29nbGUuY29t&src=MWMyM2Q3ZmUxNDg0MGUzMjBlYzA3NjIyNDViZjU1Y2MzMmE2OTEwNDE3ZmNmNzZjYThiYTJkMWEzMDgxMTBmM0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t&src=ZDJjZTEzZDU2MDhhZWJlMGZmN2QzYmNlYzVlYTU4MWZlYThjYTI0ZDY2ZTVmNjVjMTEyZThjYzNkYWJkYmVjMUBncm91cC5jYWxlbmRhci5nb29nbGUuY29t&src=Y184MTdwc3A1ZW1sZ2g4dmdnNDMydWRydHYyMEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t&src=ZGdhc3BhcmRAZ21haWwuY29t&color=%23795548&color=%23EF6C00&color=%234285F4&color=%23616161&color=%239E69AF

this could easily be done by embedding a google form but currently the google cal is @codingMustache's personal calendar
we need to migrate off of his personal cal and into a Nola Devs cal or we can use the Front End Party Cal

[ ] #75
[ ] #76

Event Name
Organizer Name
Location
Time
Affiliated Organization (if any)
Event Short Description

[ ] #77
[ ] Route to Component same way app/calendar is routed with folder structure (Next.js) #77

Event Submission Form and Responses Spreadsheet:
Responder Form
Responses Sheet


use just one PVC for build-dir and context-dir

Using subPath for each task to mount build-dir
and context-dir allows us to use one PVC for both.
This helps halve the number of PVCs needed for each run,
effectively doubling number of pipeline runs we can do
at a time.

CLOUDBLD-9935

Signed-off-by: Harsh Modi<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Python type annotations added to new code
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

can you rename 'container-workspace' to same naming as 'ws-'
maybe ws-container

can you rename 'container-workspace' to same naming as 'ws-'
maybe ws-container

renamed


A real fix for: The client-side rendered virtual DOM tree is not matching server-rendered content.

Even after loading a plugin with ssr: false and using the plugin's components wrapped around <no-ssr></no-ssr> I still get this error and the component does not load unless I change the code to trigger a hot-update then it loads. Then, after doing a refresh through the browser button, the error does not show and the component does not show either.
I have to trigger a hot-update for the component to show and that's what's interesting.

<no-ssr></no-ssr> only works for the components which although not support 'ssr' but didn't use DOM related api in initialization.
If your component uses DOM, you can use async and dynamic component. such as:
<template>
  <div>
    <component :is="asyncComp"></component>
  </div>
</template>

<script>
export default {
  data: () => ({
    asyncComp: ''
  }),
  components: {
    'example': () => {
      import('@/components/example')
    }
  },
  mounted() {
    this.asyncComp = 'example'
  }
}
</script>


Will Epic rules be added at some point?

Love the work put into this game.
I was wondering if there were any plans for Epic Ships at some point or perhaps as a forked project.

I would absolutely love to add Epic. There are other priorities currently but it's on the roadmap (I'll be posting that here soon).

Added to roadmap, closing this issue as we will be tracking through the roadmap itself.


Version Issue

What went wrong:
Could not determine the dependencies of task ':firebase_core:compileDebugRenderscript'.

The library com.google.firebase:firebase-iid is being requested by various other libraries at [[18.0.0,18.0.0]], but resolves to 17.1.2. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies.

google_maps_flutter: 0.5.7
firebase_auth: 0.11.1+5
cloud_firestore: 0.12.1
firebase_messaging: 5.0.2
firebase_storage: 3.0.0
cloud_functions: 0.4.0
google_sign_in: 4.0.2
firebase_core: 0.4.0+3

it works when i remove firebase messaging, it seems that its not compatible.

I have the same issue. I need firebase messaging, what is the proposed solution?

Removing implementation 'com.google.firebase:firebase-core:17.0.0'
from <project>/android/app/build.gradle works for me.
According to PR https://github.com/flutter/plugins/pull/1766, and the flutter firebase_messaging code example, they neither have this dependency.
I guess the FCM Assistant isn't all correct for flutter project, at least not for android under flutter.
Here's what FCM Assistant shows for android setup:

It probably has something related to #33581 as well.

All of the packages are compatible as of now

Also as of now ensure the dependencies versions
https://github.com/flutter/plugins/blob/master/packages/firebase_messaging/example/android/build.gradle
dependencies {
    classpath 'com.android.tools.build:gradle:3.3.0'
    classpath 'com.google.gms:google-services:4.2.0'
}


Sticky saturation overflow tag

Sets value to minimum/maximum on overflow -- just like saturated_overflow_tag -- but then stays there -- much like IEEE 754 +/-ve infinity. Follows suggestion by David and inquiry by Jeff Y.
Assignment will reset the value. numeric_limits::min/max will be drawn 1 unit towards zero. Possibly implement only for 2's complement initially.
Consider whether MNN can be a NaN and if it should be a separate type, file a separate issue.

#391 gets the project a bit closer to making this happen. The sheer amount of work writing the logic for each operator remains the main obstacle.

There is no will to complete this task. Anyone who wishes -- and can afford -- to invest the resources is welcome to submit a PR.


PushNotificationsManager bug in P2P Call Sample

Specify the sample to which the issue belongs (use [x]):
[] Chat sample
[] P2P Call sample
MethodChannelFirebaseMessaging.requestPermission (package:firebase_messaging_platform_interface/src/method_channel/method_channel_messaging.dart:286:13)
E/flutter (26991):
E/flutter (26991): #2      PushNotificationsManager._initFcm (package:p2p_call_sample/src/managers/push_notifications_manager.dart:77:5)
[] Conference Call sample
Platform (use [x])
[] Android
[] iOS
[] macOS
[] Windows
[] Web
Device info
Manufacture:
Model:
OS version:
Describe the bug:
Steps to Reproduce:
1.
2.
3.
4.
Logs:
log here

or
Gist log
Actual result:
Expected behavior:
Additional info
Add any other context about the problem here.

Unhandled Exception: MissingPluginException(No implementation found for method Messaging#requestPermission on channel plugins.flutter.io/firebase_messaging)
E/flutter (26991): #0      convertPlatformException (package:firebase_messaging_platform_interface/src/method_channel/utils/exception.dart:13:5)

Do you have any issues with sample work? Or you just can see it in logs?

no activity for a long time, so closing


Open Source Reproducibility

Currently, this is not fully reproducible form the git code alone.
Detailed Description

.Run.sh --login option potentially points to non-bash depending on the system
module load options Leeds specific ecodes installation instructions not provided python yaml
Intel compiler, not open source. Swapping to gfortran would require alterations floating point flags different some formatting options different

Context

The goal of this system is to be easy to clone a build to run anywhere
Possible Implementation

Provide a Run_external.sh for now
Future could have flags:

Ifort or gfortran
System python or anaconda (try activate the environment or create it)
Out put to repo VIZ site code

use ldd to Tar EXE and Library files. Add to README about request of Tared executables


Remove or Change the "Add observation to place" link on Place pages

With the new threshold we've set for accuracy circles and places, I don't think the current default for the Add an observation link in Places works. It will start an add obs page with the accuracy circle that is significantly larger than the place (eg https://www.inaturalist.org/observations/new?latitude=38.3551613671&longitude=-87.8264970335&place_guess=Beall+Woods+State+Park&place_id=122831&positional_accuracy=1457.592957362052), which is leading people to add observations that don't actually get put in the place.
Personally I think we should just get rid of this feature, cause it is so old fashioned, but if anyone feels strongly about keeping it, the default accuracy needs to be changed.

I agree on remove. We really can't automatically create a point and radius that represents "somewhere in a place" unless that place has a perfectly circular boundary. Plus obs/new is not a page we should be encouraging.


[DRAFT] Philox offset

Fix for #234 for the philox engine.
Do not merge this yet

Replaced by #239


Adds storage account Quick Failover API

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

Automation for azure-sdk-for-node

Automation for azure-sdk-for-js

Can one of the admins verify this patch?

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

This has pass review in private repo in: https://github.com/Azure/azure-rest-api-specs-pr/pull/610


Support conda-forge pre-release channels

conda-forge makes it possible to publish pre-release builds to a specific channel (see https://conda-forge.org/docs/maintainer/knowledge_base.html#creating-a-pre-release-build). The channels are named conda-forge/label/<package_name>_rc or conda-forge/label/<package_name>_dev.
I'd like to proxy some of those channels (i.e. conda-forge/label/sardana_dev).

Underscore isn't allowed in the channel name. This is an issue to keep the same name as conda-forge.
I tried to define conda-forge/label/sardana-dev but it looks like using slash isn't well supported. Trying to delete that channel raises a 405.
Defining sardana-dev to proxy https://conda.anaconda.org/conda-forge/label/sardana_dev doesn't work either. Trying to get the repodata raises 500.

I think you are conflating some terms. conda-forge is a channel. I think what you are referring to here are labels: https://docs.anaconda.com/anacondaorg/user-guide/tutorials/#using-labels-in-the-development-cycle
They do seem to behave like channels under the hood, but I think the expected default behavior for Quetz would likely be that when I proxy/mirror a channel that all labels are proxied/mirrored, not that I would need to set up a channel for each label. Also, note that every channel has labels, the default is just "main" (example https://anaconda.org/conda-forge/nifty/labels)

Hi both, yes, indeed, that is something we haven't yet figured out / tackled.
I am not sure we want to completely follow the "labels" of anaconda.org, but having a way to get & mirror pre-releases would be nice.
Will think about this.

I think you are conflating some terms. conda-forge is a channel. I think what you are referring to here are labels: https://docs.anaconda.com/anacondaorg/user-guide/tutorials/#using-labels-in-the-development-cycle

You are correct, but my understanding is that labels is something that anaconda decided to implement on their server. It's not something that conda (the client) knows about.
So technically, a label is just another conda channel. And yes, the default channel on anaconda.org is kind of an alias for the main label.
There are other conda repositories solutions, like JFrog Artifactory that don't have the concept of labels.


Couldn't find an animation entry for routerTransition

Was caused my another package i added after this one, sorry my mistake.

Was caused my another package i added after this one, sorry my mistake.


Please delete two UChicago RTs in Sinopia (Stage)

We need a couple UChicago duplicates deleted from stage.sinopia.io. Our normal rare materials item test RT has been uploaded under a different name and is fine as it is.
But these two need to be deleted please.

Rare Materials Item (BIBFRAME)
UChicago:RT:bf2:RareMat:Item

Rare Materials Item (BIBFRAME)
UCHicago:RT:bf2:RareMat:Item

If you have questions, please e-mail me<EMAIL_ADDRESS>(Jesse Lambertson)
thank you
PS: I am attaching a screenshot that includes the 2 UChicago RTs that need deletion

Done, both RTs are now removed from Stage.


How to decorate all request? documentation missing

Decorate all request with param
hi how can i decorate a request adding params to all request?
configure("**", description: "auth") {
            $0.mutateRequests { req in

            }
        }

is the correct way? what to add?

I am doing it like this:
service.configure("**", description: "auth token") {
            if let authToken = self.authToken {
                print("Siesta:Networking Setting AuthToken: " + authToken)
                $0.headers["Authorization"] = "Bearer " + authToken         // Set the token header from a var that we can update
            }
            $0.decorateRequests {
                self.refreshTokenOnAuthFailure(request: $1)
            }

        }

Thanks, Lucas, though I think they’re asking about params and not headers.
@boardmain, I answered your post on Stack Overflow: https://stackoverflow.com/questions/47477280/how-to-decorate-a-request-with-parameters/47612722#47612722

Oh well, right.. I should have read more carefully


npm install current lib before travis, example scripts

Fixes #261
action should be imported from mobx-angular so we get the decorator metadata for angular AOT
This pr also adds an example with a mobx strict mode to facilitate testing.

I believe this error is preventing me from moving to Angular 4.  Is there a workaround now, or a fix on the near horizon?  Here is the message I'm getting:
ERROR in Error encountered resolving symbol values statically. Only initialized variables and constants can be referenced because the value of this variable is needed by the template compiler (position 78:13 in the original .ts file), resolving symbol action in /Users/dqj/Local/dev/apps/pl3/pepe/frontend/node_modules/mobx/lib/mobx.d.ts, resolving symbol TreeNodeCollectionComponent in /Users/dqj/Local/dev/apps/pl3/pepe/frontend/node_modules/angular-tree-component/dist/components/tree-node-collection.component.d.ts
Thank you.

I'd suggest installing & fixing the dep to 3.3.0 for now until this lands

Hello, can you merge the PR  ?

can anyone merge this please?

Hi @jskrzypek ,
I will add useStrict to the main example.
importing action from mobx-angular already solved in a different branch.
Can you leave only the travis fix and I will merge? Thanks

I'm leaving the npm i ../.. changes in the package.json scripts as well, since I believe that's what you intended

@adamkleingit Please let me know if you need anything else changed


CDS-78945 DRY Rampup

https://harness.atlassian.net/browse/CDS-78945
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[x ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

https://harness.atlassian.net/browse/CDS-78945

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Added ability to match many model labels to one task labels

Also fixed small bug with a share browsing

Resolved #1049

Thanks for openenigs the this task. I am a little bit confused. should the title be match one model labels to many task labels?

@test4fest
You can reckon do many to one mapping only in one direction: multiple model labels -> one task label.
Example:
Model labels: car, bike.
Task labels: vehicle
Mapping: car -> vehicle, bike -> vehicle
But if a model can recognize, for example vehicle, you cannot match it as both car and bike simultaneously. Only if to create N copies of the same object artificially.


Modify workflows to test on java17

Description:
Changes were made to do java workflow to test on multiple run times for now with refactoring.
Test run that only ensures the tests run as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

General guidance here from a review point of view. I find smaller mistakes harder to find with PRs that are mostly refactoring like this one. I would advise to keep PRs like this tightly scoped around one thing. You chose to include changes to the python workflows also which polluted the PR imo.

yeah my bad, i thought to clean up a little up and also aimed to get alarmed when the workflow fails.


samples/memfs: fix errors found by vet

This pull request was made with an automated tool.
The suggested change fixes one or more problems discovered by "go vet".
See https://github.com/functionary/functionary for more details on
the @functionary GitHub user.

Almost all of this was automated, but the specific change was done by human.

Cool. You should probably update the message to make that clear for the next time.

Thanks. Good feedback.


Add support for real-time subs for file changes

Any user of system can "subscribe" to "files" (by name or whole dir);
Subscribed user can receive real-time notification about file (or dir) changes - file deleted, file name changed, file added to dir;
Cache file/dir subs in memory and store to database;
Create cache after success connection and remove it after disconnect.

Sources:
https://blog.logrocket.com/building-pub-sub-service-go/


How to upgrade nix?

No matter what I try, I always get:
$ nix --version
nix (Nix) 2.4pre20201201_5a6ddb3

How can I upgrade nix version inside the container?
The closest I can get is change the channel as indicated in #26 and run nix-shell -p nix, but that removes the comfort of using nix from outside the container by creating a symlink from nix to nix-portable.
Thanks.

@Yajo You can produce the upgraded nix-portable declaratively by overriding the flake inputs.

Can you elaborate for beginners like me? My build script (for netlify) looks like
wget -nv https://github.com/DavHau/nix-portable/releases/download/v009/nix-portable
chmod +x nix-portable
./nix-portable nix-build

how would I change that to get a specific version of of nix?

@nomeata Sorry for late reply.
As nix-portable enables the flake features by default, you can make use it to build and run the Nix Flakes. You can find a Flakes introduction on the NixOS Wiki:
https://nixos.wiki/wiki/Flakes
There are several ways to build nix-portable from flake.
The most reliable one is to write a flake.nix. This one will work if you simply want to get an updated nix-portable.
{
  description = "My custom overrided nix-portable flake";

  # The nixpkgs revision to use
  inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-21.11";
  # The nix revision to use
  inputs.nix.url = "github:NixOS/nix/2.5.1";
  inputs.nix.inputs.nixpkgs.follows = "nixpkgs";
  # We don't need to benchmark Nix here.
  # Let's opt out the additional nixpkgs
  # that causes constant changes of `flake.lock`.
  inputs.nix.inputs.nixpkgs-regression.follows = "nixpkgs";
  inputs.nix-portable-flake.url = "github:DavHau/nix-portable/v009";
  inputs.nix-portable-flake.inputs.nixpkgs.follows = "nixpkgs";
  inputs.nix-portable-flake.inputs.defaultChannel.follows = "nixpkgs";
  inputs.nix-portable-flake.inputs.nix.follows = "nix";

  outputs = { nix-portable-flake, ... }: nix-portable-flake.outputs;
}

If the file is inside a Git repo, you can then run
$ nix build my/directory#nix-portable

to build the executable with the specified Nixpkgs and Nix versions.
If the file is not inside a Git repo, change to/directory to path:my/directory.


Screenshots with Hotkey

Taking true 240*136 screenshots isn't possible currently. The current process for me is to set the cover image, export then scale the image in a external image editor. But what if I'd like to take a screenshot of the code, sprite ect... editor? Maybe you could even have a "screenshot scale" option in config that will automatically scale the image saved. GIF recording would be amazing as well.

I vote for this, with Gif recording.

You can take 240x136 screenshot by pressing F8
also you can change the scale in config.lua
...
SCREENSHOT_SCALE = 1

it won't work with scanline effects
also I'll open GIF recording in a separate issue
done in .26


Error? or intent? Hitting enter on completion of tags moves cursor

Hi, first off i want to say i really like you extension. Makes my life a lot easier. Secondly not sure if this is an issue or should be regarded as a feature request.
On completion of html tag (final state).
eg.
|
 (using the pipe character to illustrate the cursor)
If you hit enter top open the structure as so:
eg.

What actually happens is that the cursor simply moves to the end of the closing tags
eg.

| (again pipe character for illustration)
Is this intent, error or simply and oversight ? I may be the only one who finds this a bit frustrating. Again thank you for taking the time to make this extension.

Hello, which version of the extention do you have? and what is your system?

-- Sorry for the English, I used Google Translator --
I would also like to hit enter if the line break was made, but different from what @fmrogers  said, I would have preferred it already formatted. In other words, a blank line was inserted between the tags (opening and closing) and the cursor already had the 'tab'.
eg.
|
 (using the pipe character to illustrate the cursor)
If you hit enter top open the structure as so:
eg.

    |

I have version 0.0.18 of the extension.

Hello @Tekbr
I dont understand what you are trying to do.
the div command gives you the following code:

    |

|

*the bar | is where the cursor can be, using the tab key to move between the positions.
can you explain further please.

things seams have changed for me, now i experience this after i hit enter.
eksample:

       |

I have just tested using:
OS:           OSX 10.11
VSCode:   1.8.1
Extension: 0.0.18
I have tested the three scenarios, and have provided a gif showing the output for each case, these are expected results, this is actually the design of VSC snippet engine I have no control over it.
If you are experiencing a behavior other than what is shown in the gif then I expect there is a bug in the VSCode engine.
// pressing Enter:
// will move to the next position and mark the previous position as complete

// pressing Tab:
// will allow you to circulate between positions endlessly

// pressing Esc:
// will mark all positions as complete and leave cursor where it is

-- Sorry for the English, I used Google Translator --
I tested using:
OS: Windows 10 v1611
VSCode: 1.9.0 - insider
Extension: 0.0.18
My problem is not necessarily with the div tag (I used it as an example), but its behavior must be the same for all, or there is a way to configure which tags should have this behavior, having to break the line automatically.
When using the div tag, I have the same behavior as you showed in the gif.
I do not know if it was clear ... Sorry for the English
When I use HTML Snippets and I click enter with the h5 tag

When I use HTML Snippets and I click tab with the h5 tag

Here when I use the Auto Close Tag extension and click enter with h5 tag

@abusaidm Did you undersand? Sorry for the above English.

hello,
what you experienced there is the VS Code html engine, in recent versions the VS Code added native support for html in html files, if you open a file that is deemed html by vscode, and you disable html snippets, you can simply use the '<' notation to unlock the html tags.
we cant replicate this with snippets as the api is limited in its ability.
Sorry for late reply, extremely busy past few days.


Bug: UI and Management endpoints not available

Describe the bug
If http/https/http2 protocols are disabled, Camouflage UI and management endpoints such as /ping and /restart are not available.
To Reproduce
Steps to reproduce the behavior:

Disable http/https/http2 protocols via config.yml
Start camouflage server.
Access Camouflage Homepage. eg. http://localhost:8080/

Expected behavior
Even though aforementioned protocols are disabled, UI and management endpoints should still be available.

Fixing it would require reserving an additional port for a 3rd express app

http/https/http mock server app;
Prometheus metrics server app;
UI and Management Endpoints app;

This adds unnecessary complexity in config.yml. Documentation updated necessary warnings. Might fix in future if absolutely required.


[regression] sink function calling fzf#run() puts vim in normal mode instead of terminal

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux

Shell

[x] bash

Env
NVIM v0.5.0-dev+1085-g52397aaa0
> nvim --version
NVIM v0.5.0-dev+1085-g52397aaa0
> vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jan 20 2021 22:47:34)
Included patches: 1-2380

Problem / Steps to reproduce
When the sink function calls fzf#run(), vim and neovim switch to normal mode instead of terminal mode.
This regression comes from this commit: https://github.com/junegunn/fzf/commit/1a76bdf8914195ab26ebac7e49a3ed8752dd69bd
minimal_vimrc:
call plug#begin('~/.vim/plugins')
Plug 'junegunn/fzf', {'dir': '~/.fzf','do': './install --all'}
call plug#end()

testcase.vim:
function! s:list_handler(...) abort
  call s:run_testcase()
endfunction

function! s:run_testcase() abort
  let opts = {'sink*': function('s:list_handler')}
  call fzf#run(fzf#wrap(opts))
endfunction

call s:run_testcase()

Steps to reproduce the issue:

nvim -u minimal_vimrc
source testcase.vim
press Enter

@ojroques what do you  think about this ?
Should your commit be kept, adapted or reverted ?

Can you test if this patch fixes the problem?
diff --git a/plugin/fzf.vim b/plugin/fzf.vim
index 763747c..1069af8 100644
--- a/plugin/fzf.vim
+++ b/plugin/fzf.vim
@@ -764,6 +764,10 @@ function! s:split(dict)
   endtry
 endfunction

+noremap  <silent> <Plug>(fzf-normal) <Nop>
+noremap! <silent> <Plug>(fzf-normal) <Nop>
+tnoremap <silent> <expr> <Plug>(fzf-normal) &filetype == 'fzf' ? "\<C-L>" : "\<C-\>\<C-n>"
+
 function! s:execute_term(dict, command, temps) abort
   let winrest = winrestcmd()
   let pbuf = bufnr('')
@@ -793,7 +797,7 @@ function! s:execute_term(dict, command, temps) abort
     else
       if bufnr('') == self.buf
         " Exit terminal mode first (see neovim#13769)
-        call feedkeys("\<C-\>\<C-n>", 'n')
+        call feedkeys("\<Plug>(fzf-normal)")
         " We use close instead of bd! since Vim does not close the split when
         " there's no other listed buffer (nvim +'set nobuflisted')
         close

@junegunn , the patch works like a charm on both vim and nvim.
Thanks a lot!

@junegunn note that this commit created a weird condition where some commands executed after wait for a key to be pressed to be executed.
The minimal testcase I found is using CocList.
CocList extensions won't execute before we press a key:
function! s:list_handler(...) abort
  let cmd = "CocList extensions"
  execute cmd
endfunction

function! s:run_testcase() abort
  let opts = {'sink*': function('s:list_handler')}
  call fzf#run(fzf#wrap(opts))
endfunction

call s:run_testcase()

Does it help to add x flag to call feedkeys("\<Plug>(fzf-normal)")?

Does it help to add x flag to call feedkeys("\<Plug>(fzf-normal)")?

I don't know what the issue of @antoinemadec , but wihtout x flag in the floating window layout, nvim can't fire a WinEnter event when fzf's window exits until I move the cursor.

The behavior of fzf-preview.vim when calling fzf#run again is also strange.
After running fzf#run for the second time, the floating window is not displayed, and fzf starts when some key is entered.

fzf starts when some key is entered

That's why I had to add <C-L> in the above patch.
 Run call s:run_testcase()
EOF
)

The above minimal settings will not cause any problems.
I was just verifying that in fzf-preview.vim, regardless of the recursive invocation of fzf#run, sink is not running unless some key is entered after every operation.
This may be due to the fact that it is being executed via TypeScript with async.

In this line, we are using RPC to run Node.
It doesn't work as it is, but you can fix it by inserting call feedkeys('', 'x') before the request.
https://github.com/yuki-yano/fzf-preview.vim/blob/0a9966475c5fcf3cad0798b3615089f7dac3bf9f/autoload/fzf_preview/rpc.vim#L57

Does it help to add x flag to call feedkeys("\<Plug>(fzf-normal)")?

@junegunn , adding the 'x' flags in fzf.on_exit's feedkeys() was creating a lot of side effects when using :Buffers to jump in a terminal.
The cleanest way to do it was to add call feedkeys('', 'x') before invoking CocList.
@yuki-yano code call RPC functions, like CocList. Maybe this bug only happens with RPC?

@antoinemadec @jakubgs @yuki-yano
Please test if dea950c2c82b8c44a123a1eb7a7cfa9c08048d8c fixes all the issues we have discussed so far. feedkeys will be called only when the destination buffer is a terminal buffer; if it's another instance of fzf, it will start insert mode, otherwise, normal mode. There shouldn't be any side-effect in other cases.

@junegunn , this is still not working for me.
It forces me to send a key between 2 terminal invocation before displaying the 2nd terminal.
 Run call s:run_testcase()

> nvim --version
NVIM v0.5.0-dev+1102-g595f6e4d6
Build type: RelWithDebInfo

That's strange. Have you tested it on Neovim 0.4.4?

I was able to reproduce the problem on Neovim HEAD (but not on Neovim 0.4.4 release). 29851c18aa47ad4b4cbf92358cfbe11935f0c033 will fix it.

@junegunn , works like a charm. Thanks !


Use treesitter or lsp for smarter highlighting

I think builtin treesitter and lsp for Neovim will be able to replace this plugin and make it smarter in terms of what it highlights. Will investigate this.

Uses documentHighlight from LSP server.
71ca663 Fix lua config snippet so it can be c/p
2cbbd57 Add lsp info to README
319d286 Update docs with lsp usage
c74e559 Disable normal vim-illuminate functionality if using lsp
14965fe Remove some old TODOs
0221eca Don't clear autocmds for other buffers when a new buffer is attached
50fe54d Fix logic around keeping old highlights if they're still valid
3668446 Don't flash cursor when moving around with lsp highlighting
2182544 Stop timers that aren't needed since new timers have been started
a9956d7 Add POC for smart lsp based highlighting
505de71 Remove experimental lsp documentHighlight in favour of adding it to nvim-lspconfig
24c43ff Override documentHighlight handler and print the highlights
adad26b Begin work on utilizing nvim lsp


feat: Allow to build an Enr with a public key and an existing signature

In Reth we need to create an Enr with an existing signature (see https://github.com/paradigmxyz/reth/pull/1394).

Adding a signature in this way allows for Enrs with invalid signatures, so I don't think this is the way forward.
Regarding this comment in the mentioned Pr

imo this is reasonable because there's already a add_public_key function https://github.com/sigp/enr/blob/master/src/builder.rs#L136

note that this function is private to the builder, so setting the public key in that way is not actually allowed.
If you could share what your use case is, we might be able to suggest a better approach

This change would allow creating Enrs with invalid signatures, so I don't think this is the way forward.
Regarding this comment in the linked PR

imo this is reasonable because there's already a add_public_key function https://github.com/sigp/enr/blob/master/src/builder.rs#L136

note that this function is private so this is actually not allowed.
If you can share a bit more of your use case we might be able to point to a different solution

I also had a quick look through and agree with @divagant-martian. The ENR crate is currently designed so that a user is not able to create invalid ENRs. This change would allow the creation of ENRs which would be registered as invalid by other implementations/users.
Furthermore, having this API and having a user of the ENR crate use it successfully is going to be pretty difficult. The input signature MUST match the RLP encoding of the fields. It should be noted that the ordering of the fields in ambigious. Each implementation can order the fields however they want. So if one implementation signs a bunch of fields, that signature can not necessarily be used in this ENRBuilder unless the exact ordering of the fields matches.
Therefore, the only use case of this API I can see, is for all of the following conditions to be met:

You have a bunch of data that looks like an ENR, but is not an ENR.
This data is signed, in exactly the same way and ordering as the ENRBuilder of this crate for all the fields
You do not have the private key relating to the signature

I would imagine this very specific use case implies you are converting something that looks like an ENR into an ENR. I think in general it would be hard to get 2 to match for all implementations outside of this crate. I would suggest a more general approach. This would be to get the data and encode it into a base64 rlp-encoded ENR. This way, you have control over the ordering of the fields and thus can make the signature work. You can then create and ENR by decoding this base64. The resulting ENR will have the field ordering matching that of the other implementation and it will include the signature (if it is valid and matches the field ordering).
This way it will be impossible to create invalid ENRs and incorrect encodings or invalid signatures (wrt to the field ordering) will all be rejected.

Thanks a lot for your quick and detailed answers!
I will explain more in detail what our use case is: When Reth shutdown, all known peers are persisted into a file. Previously NodeRecords were serialized and persisted, but we want to persists Enrs instead to be able to easily store more info (the announced fork id for instance). So yeah, you guess was right, we want to convert something that looks like an ENR into an ENR.
@mattsse Don't hesitate to correct me if I misunderstood something :)

thank you for your detailed response.
this was very helpful and I agree with that.
your suggested solution to save it as base64 makes more sense.

Would it be acceptable to add build_rlp_encoded_base64() to EnrBuilder? This way we won't have to duplicate all the code that populate the ENR content field, and just call something like that:
let mut builder = EnrBuilder::new("v4");

builder.ip(self.address);

if self.address.is_ipv4() {
    builder.udp4(self.udp_port);
    builder.tcp4(self.tcp_port);
} else {
    builder.udp6(self.udp_port);
    builder.tcp6(self.tcp_port);
}

let base64 = builder.build_rlp_encoded_base64(public_key);

Using the builder to do encoding is very much out of scope for this struct. This crate already provides a way to do the encoding to Enr via FromStr so you will need to implement this there. In any case, doing it in that way still has the issue that it adds functionality to create values that might be invalid since you are still giving the signature as a parameter

Understood, we will impl this on our side.

@divagant-martian has pointed out to me that the spec actually specifies the field ordering. My memory tells me that this wasn't always the case. I do recall having to make the rlp_content a separate field to handle the ordering from other implementations (I guess they all agree now).
But if the specification says that the field ordering is fixed, then my points about that are invalid and all implementations should have a fairly standard signature, so you don't have to mess around with the ordering. It should be fairly straight forward to do the base-64 encoding by borrowing a some of the code in this crate. Let us know if you need any help :)

Just read thru - appreciate your guys' detailed responses. We'll impl on our side.


The API calls should honor the RAILS_RELATIVE_URL_ROOT path

If RAILS_RELATIVE_URL_ROOT has been specified, then the API calls should prefix this value in the path.

I'm having the same issue as @phasenohr after deploying Portus from the latest image on DockerHub.
I've got RAILS_RELATIVE_URL_ROOT set to /portus and RAILS_SERVE_STATIC_FILES set to true.
Everything seems to function correctly, but the application is not correctly referencing the path to things in /assets, which should be /portus/assets.
In the examples below (formatted for emphasis), the stylesheet and script paths are correct, but all of the other icon references are not. The FontAwesome URLs in the CSS are also incorrect.
If this has been corrected, then I'm having a hard time understanding what I'm doing wrong.
HTML example
<head>
  <title>Portus</title>
  <link rel="stylesheet" media="all" href="/portus/assets/application-20f67d7832e7f80743d80b935441f204ab9a5cfdbfbc155027f330d6397aed28.css" />
  <meta name="csrf-param" content="authenticity_token" />
  <meta name="csrf-token" content="VyOPLrBvn4ILPxdn52Wc5+II51iSiF84A1dfq1PGWR/NF6c6KqSKsF3kdmNDLJvUPkMONcdTCceCa6xD/TtMcw==" />
  <meta content="width=device-width, initial-scale=1" name="viewport" />
  <link href="/favicon/apple-touch-icon-57x57.png" rel="apple-touch-icon" sizes="57x57" />
  <link href="/favicon/apple-touch-icon-60x60.png" rel="apple-touch-icon" sizes="60x60" />
...
  <link href="/favicon/favicon-32x32.png" rel="icon" sizes="32x32" type="image/png" />
  <link href="/favicon/manifest.json" rel="manifest" />
  <link color="#205683" href="/favicon/safari-pinned-tab.svg" rel="mask-icon" />
  <link href="/favicon/favicon.ico" rel="shortcut icon" />
  <meta content="Portus" name="apple-mobile-web-app-title" />
  <meta content="Portus" name="application-name" />
  <meta content="#da532c" name="msapplication-TileColor" />
  <meta content="/favicon/mstile-144x144.png" name="msapplication-TileImage" />
  <meta content="/favicon/browserconfig.xml" name="msapplication-config" />
  <meta content="#205683" name="theme-color" />
  <script src="/portus/assets/unmanaged-6cf4a1295ff6946a5e84e7ccee9d29838b7d173552a385e3f59eb5215abfbe73.js"></script>
  <script src="/portus/assets/webpack/application-76abd0e6b2530af98dd1.js"></script>
</head>

CSS example
@font-face {
  font-family: 'FontAwesome';
  src:url("/assets/fontawesome-webfont-7bfcab6db99d5cfbf1705ca0536ddc78585432cc5fa41bbd7ad0f009033b2979.eot");
  src:url("/assets/fontawesome-webfont-7bfcab6db99d5cfbf1705ca0536ddc78585432cc5fa41bbd7ad0f009033b2979.eot?#iefix") format("embedded-opentype"),
      url("/assets/fontawesome-webfont-2adefcbc041e7d18fcf2d417879dc5a09997aa64d675b7a3c4b6ce33da13f3fe.woff2") format("woff2"),
      url("/assets/fontawesome-webfont-ba0c59deb5450f5cb41b3f93609ee2d0d995415877ddfa223e8a8a7533474f07.woff") format("woff"),
      url("/assets/fontawesome-webfont-aa58f33f239a0fb02f5c7a6c45c043d7a9ac9a093335806694ecd6d4edc0d6a8.ttf") format("truetype"),
      url("/assets/fontawesome-webfont-ad6157926c1622ba4e1d03d478f1541368524bfc46f51e42fe0d945f7ef323e4.svg#fontawesomeregular") format("svg");
  font-weight: normal;
  font-style: normal
}

can you try with RAILS_SERVE_STATIC_FILES=false I think this feature is missing in 2.3 ?

Nope, sorry. Same problem when changing it to false.

I have the same issue that describe by @ghaberek with the docker head image.


Cannot distinguish the difference between multiple uses of a single quote.

Method's 'this' got read incorrectly. Probably, incorrect use of ' or ".

I think that this regex (in the picture) is causing it,
I'll check if it is resolved when we'll merge a fix.
Until then, can you put here the plain error so I can test it?

v0.3.0 with the fix is out!
You can update now 🙂


Clean up mitmproxy.models

mitmproxy.models is more or less a remnant from times where we didn't have netlib.http.Request/Response etc. We should probably remove this altogether.

First part completed in #921.

fixed by 24cf8da27eb56a65bf3e4ceb78bbeacdb1864597


File upload box falls off screen when scrolling

Steps to reproduce the issue
Attempt to upload a file to a community.
Scroll down when the upload modal appears.
Modal will fall off screen and doesnt come back until a page refresh
Screen shots
https://gfycat.com/linearwiltedcougar

Thanks Mitchell - have passed along to our periscope dev owner.

Fix was just merged in PR #51 - please try and confirm this resolves the issue.


Nice error message on .env file missing

This fixes #114 and also makes bin/advanced-script.js executable after created by rollup so it can be used with yarn link in development mode
This PR replaces #118 targeting the new refactoring branch.

Thanks


Add Screenshots client to database

Please add (and give to us) the Screenshots credentials and production URL for the watchdog service.

@oremj any news here?

I didn't get a notification for this issue, so this is the first I've heard of it. I can set this up today.

The production URL is https://watchdog-proxy.services.mozilla.com/

I have the watchdog credentials in our secrets store already, do you want them e-mailed to you as well?

No, we don't need them as long as Screenshots has them and can connect.  When we're ready to configure Screenshots we can just say "look in the secret store" and you'll know what that means? :)  If so, we can close this.

I think this is covered by: https://github.com/mozilla-services/cloudops-deployment/issues/2589

Cool.  Thank you!


JSON & API curriculum doesn't prepare students for Intermediate Front-End Challenges

JSON & APIs  --> Intermediate Front-End Projects
Issue Description
I've been leading my students through the FCC exercises. Thanks for the amazing curriculum! Today, I was going through the JSON & API section to prepare for our next class. I looked ahead to the first Intermediate Front-End Project, and see that the students are to use the Twitter API. FCC hasn't provided instructions or tutorials on API keys, keeping API keys secret, how to hit a live API endpoint, how to code an HTTP request, etc. (except for the limited cat API example). The way the curriculum is currently structured, it seems like a huge leap from the exercises provided to using the Twitter API. I'm very much in favor of letting the students puzzle things out on their own for awhile, but there seem to be some major concepts that are missing. Is this something FCC is already working on? Thanks!
Another student has discovered this and posted in the forum as well: https://forum.freecodecamp.org/t/where-to-learn-about-api-weather-api-resources-needed/80090/5

I agree with this, the json lessons were really unclear, it was just like copy and paste this didn't explain much, very unusual for freeCodeCamp Challenges. Another camper helped me learn how to properly insert json keys into HTML but it shows a bigger problem if campers don't understand after going thru the json challenges.


Missing Boot Chime

I've already managed to solve this by adding the needed files and entries in config.plist but it's missing from the new EFI provided. Not sure if this was done for a reason or a preference for the developer.

I've already managed to solve this by adding the needed files and entries in config.plist but it's missing from the new EFI provided. Not sure if this was done for a reason or a preference for the developer.

I did it on purpose. It was causing sound loss on boot for some people.

Never had that issue myself on T450 but thanks it works fine regardless!


[Bug] conflict with Stealth module

I'm having problems with the module in conjunction with the stealth module.
When selecting a token that tests vision it shows this error.
Foundry 11.309
DnD 5e
Stealth 3.13.2
Perceptive: 1.8.0

Thanks for reporting the bug. It should be fixed with v1.8.1.


Be able to set the minimum and maximum supported TLS protocol version…

Be able to set the minimum and maximum supported TLS protocol versions on Gateway servers. The respective changes on the API are under: https://github.com/istio/api/pull/636

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf
If they are not already assigned, you can assign the PR to them by writing /assign @ijsnellf in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ldounis. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add CDX export

It is required to add an opportunity to export drawn structure in two formats CDX and Base64 CDX.
These formats need to be added to "File format dropdown":

When user selects Base64 CDX preview shall show base64 representation of structure.
For CDX option preview shall show "Can not display binary content"

This task seems like it is related: https://github.com/epam/ketcher/issues/1897