TypeError: string indices must be integers

Description
Running AGiXT locally with the provided examples and text generation web ui's API gives the following cryptic error:
  You can now view your Streamlit app in your browser.

  Network URL: http://<redacted>:8501
  External URL: http://<redacted>:8501

2023-09-13 10:00:33.479 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/0-Agent_Interactions.py", line 37, in <module>
    agent_name = agent_selection() if mode != "Chains" else ""
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:00:39.200 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/1-Agent_Training.py", line 17, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:00:40.134 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:00:45.580 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:00:54.106 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:00:59.237 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/Main.py", line 35, in <module>
    agent_settings = agent_config["settings"]
TypeError: string indices must be integers
2023-09-13 10:01:08.213 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/Main.py", line 35, in <module>
    agent_settings = agent_config["settings"]
TypeError: string indices must be integers
2023-09-13 10:01:17.391 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/0-Agent_Interactions.py", line 37, in <module>
    agent_name = agent_selection() if mode != "Chains" else ""
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:01:21.705 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/0-Agent_Interactions.py", line 37, in <module>
    agent_name = agent_selection() if mode != "Chains" else ""
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:01:26.226 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/0-Agent_Interactions.py", line 37, in <module>
    agent_name = agent_selection() if mode != "Chains" else ""
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:01:28.959 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/1-Agent_Training.py", line 17, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:01:29.555 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:01:31.621 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/3-Memory_Management.py", line 24, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:01:33.156 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/4-Prompt_Management.py", line 44, in <module>
    index=prompt_categories.index("Default"),
ValueError: substring not found
2023-09-13 10:01:57.339 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:03:39.814 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:03:41.915 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
2023-09-13 10:04:26.235 Uncaught app exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/3-Memory_Management.py", line 24, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)
Error: Expecting value: line 1 column 1 (char 0)

Steps to Reproduce the Bug

Deploy with docker-compose and text generation web ui's API
Access the streamlit web interface
Errors occur

Expected Behavior
No errors, or at least useful errors that tell you what configuration might need to be changed.
Operating System

[X] Linux
[ ] Microsoft Windows
[ ] Apple MacOS
[ ] Android
[ ] iOS
[ ] Other

Python Version

[ ] Python <= 3.9
[x] Python 3.10
[ ] Python 3.11

Environment Type - Connection

[X] Local - You run AGiXT in your home network
[ ] Remote - You access AGiXT through the internet

Runtime environment

[X] Using docker compose
[X] Using local
[ ] Custom setup (please describe above!)

Acknowledgements

[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of AGiXT.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Hello! Which option in the installer are you running with?

Howdy 👋 , I'm just using the docker images (joshxt/agixt:latest, joshxt/streamlit:latest) with docker compose.
My env configuration looks like:
AGIXT_HUB=${AGIXT_HUB:-AGiXT/hub}
AGIXT_AUTO_UPDATE=true
AGIXT_URI=https://agixt.<redacted>
UVICORN_WORKERS=${UVICORN_WORKERS:-6}
TOKENIZERS_PARALLELISM=false

AI_PROVIDER_URI=https://localai.<redacted>
AI_PROVIDER=oobabooga
PROMPT_PREFIX="USER:"
PROMPT_SUFFIX="\nASSISTANT:"

DB_CONNECTED=true

POSTGRES_SERVER=agixt-db
POSTGRES_DB=agixt
POSTGRES_PORT=5432
POSTGRES_USER=agixt
POSTGRES_PASSWORD=<redacted>

Try with DB_CONNECTED=false - the postgres option may still have some issues to work out.
This block is unnecessary for the ENV file, these items are only referenced by agent config and are not used by env.

AI_PROVIDER_URI=https://localai.<redacted>
AI_PROVIDER=oobabooga
PROMPT_PREFIX="USER:"
PROMPT_SUFFIX="\nASSISTANT:"

Ah ok thanks, I've disabled the database and commented out that additional block.
The frontend still has error and this in the streamlit container logs:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 552, in _run_script
    exec(code, module.__dict__)
  File "/app/pages/2-Agent_Management.py", line 108, in <module>
    agent_name = agent_selection()
  File "/app/components/selectors.py", line 340, in agent_selection
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
  File "/app/components/selectors.py", line 340, in <listcomp>
    agent_names = [agent["name"] for agent in ApiClient.get_agents()]
TypeError: string indices must be integers

and the agixt container is throwing lots of errors with:
RuntimeError: Your system has an unsupported version of sqlite3. Chroma requires sqlite3 >= 3.35.0.
Please visit https://docs.trychroma.com/troubleshooting#sqlite to learn how to upgrade.
  File "/agixt/Interactions.py", line 8, in <module>
    from readers.website import WebsiteReader
  File "/usr/local/lib/python3.10/site-packages/chromadb/__init__.py", line 69, in <module>
    raise RuntimeError(
  File "/agixt/Memories.py", line 6, in <module>
    import chromadb
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/agixt/readers/website.py", line 3, in <module>
    from Memories import Memories
  File "/agixt/app.py", line 11, in <module>
    from Interactions import Interactions, get_tokens
  File "/usr/local/lib/python3.10/site-packages/chromadb/__init__.py", line 69, in <module>
    raise RuntimeError(
  File "/agixt/Memories.py", line 6, in <module>
    import chromadb
  File "/agixt/Interactions.py", line 8, in <module>
    from readers.website import WebsiteReader
  File "/usr/local/lib/python3.10/site-packages/chromadb/__init__.py", line 69, in <module>
    raise RuntimeError(
  File "/agixt/readers/website.py", line 3, in <module>
    from Memories import Memories
RuntimeError: Your system has an unsupported version of sqlite3. Chroma requires sqlite3 >= 3.35.0.
Please visit https://docs.trychroma.com/troubleshooting#sqlite to learn how to upgrade.
  File "/agixt/Memories.py", line 6, in <module>
    import chromadb
  File "/usr/local/lib/python3.10/site-packages/chromadb/__init__.py", line 69, in <module>
    raise RuntimeError(
RuntimeError: Your system has an unsupported version of sqlite3. Chroma requires sqlite3 >= 3.35.0.

I can see your image has sqlite 3.34.1 which indeed is unsupported by Chroma.

Please try using the AGiXT.sh script with option 1. I would recommend first renaming your .env file to something else and start with the quick start settings in the install script. You may have some old/strange dependencies there from an old version.

I don't really want to run an installer script on my servers host OS as there's lots of other containers running and everything is deployed in isolation with docker-compose, so I'll close this for now as.

I would try another VM. The installer script does a docker-compose pull and sets the environment variables properly. You can open the source of the script and see everything it does.


Stop Watch only working buttons should be visible

Reset Lap Reset Lap button are not needed when stop watch is not on.
Start button is not required during the running stopwatch.
Can I contribute on this issue?
Please assign me this issue.
[GSSOC'21]
@Vishal-raj-1 @urvashi-code1255

@urvashi-code1255 @Vishal-raj-1 @991rajat please view this

Good catch. Feel free to change UI as well if you like.


[fix] Add token as authentication for python gateway

separate from #6407. Authentication, add secret to ensure only trusted people could connect to gateway.
fix: #8255

Codecov Report

Merging #12893 (eced157) into dev (d324cce) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev   #12893   +/-   ##
=========================================
  Coverage     39.41%   39.42%
+ Complexity     4245     4241    -4
=========================================
  Files          1053     1052    -1
  Lines         39880    39828   -52
  Branches       4585     4568   -17
=========================================
- Hits          15718    15701   -17
+ Misses        22384    22352   -32
+ Partials       1778     1775    -3

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/python/PythonGateway.java
17.93% <0.00%> (-0.17%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
42.55% <0.00%> (-2.13%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.38% <0.00%> (-1.39%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
36.62% <0.00%> (-0.26%)
:arrow_down:

.../dolphinscheduler/plugin/task/spark/SparkTask.java
72.56% <0.00%> (-0.25%)
:arrow_down:

...dolphinscheduler/service/storage/impl/S3Utils.java
0.00% <0.00%> (ø)

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


playing a video on file System freezes the UI

I am trying to play a video stored on the file sytem, but when I attempt to play the video, the phone freezes, (until i remove the battery, and reinsert it)..
this is my code:
videoLayout.setVideoPath(savePath);' videoLayout.setShouldAutoplay(true);` (the problem still occurs even without autoPlay)
the video i am trying to play is 300kb in size
I am testing on a Samsung Galaxy S3, running Jelly bean
pls how can I fix this issue?

Hi @kcochibili
It is a little bit difficult without the code.
Can you test replacing your VideoLayout with the native android.widget.VideoView and see if it still happening?
If native android.widget.VideoView works, can you test replacing it with FullscreenVideoView (instead of Layout)
When the device freezes, are there any exception or anything in log?

When I  tested using  android.widget.VideoView the problem still occurred. So then i started thinking that there must be something wrong with my implementation, since the problem does not occur in the previous activity where I also played the same video.
The problem turned out to be that I did not call VideoView.stopPlayback() in the previous activity where I had a handle on this video file (The video was still playing when I launched a new activity that attempted to play the same video Using FullscreenVideoLayout).
So I was able to stop the freezing by first calling  VideoView.stopPlayback() before launching a new activity.
Thank you for the helpful diagnostic suggestion.that helped solved my problem.

Hi @kcochibili
Nice to hear that.
Best.
T


Python 3.12 experiments

TL:DR
Support for Python 3.12 is doable 😄
More info below.
Windows - user
Works out of the box.
Ubuntu (20.04) - user
Needed to use updated:

setuptools - tested with latest one 69.1.0, which has Python>=3.8
six - works only with the latest one 1.16.0
https://bugzilla.mozilla.org/show_bug.cgi?id=1857492

Windows - developer
Problem with Numpy. With Python>=3.8 set in package target versions, Numpy max version 1.24.4 is installed. It does not support Python 3.12.
Two possible solutions:

Release Mesh Python SDK 1.5 version with current changes, without explicit Python 3.12 support and add Python 3.8 deprecation warning. Then remove support for Python 3.8, add Python 3.12, and immediately release 1.6[^1].
Try to support both Python 3.8 and 3.12 in Mesh Python SDK 1.5 version by adding explicit numpy dependency to the project and use multiple constraints dependencies.  Haven't tested this approach yet.

[^1]: Assuming support for Python 3.12 is required by some customer.

After discussion with @torsannes we are going with option number 1:

Release Mesh Python SDK 1.5 version with current changes, without explicit Python 3.12 support and add Python 3.8 deprecation warning. Then remove support for Python 3.8, add Python 3.12, and immediately release 1.6.

BTW Python 3.8 end-of-life is scheduled for October 2024. See: https://devguide.python.org/versions/#supported-versions.


[stable/datadog] Bump Agent version following 7.21 release

What this PR does / why we need it:
Bump Agent version
Which issue this PR fixes
None
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/lgtm


mr discussion: allow to comment on specific lines in a diff

(the first two commits are independent updates but I included them here to avoid conflicts)

GitLab supports to comment on lines (or even ranges of lines) within a
commit diff.  This is standard practise when using the web interface,
and it's arguably friendlier to the MR author.
Add a bunch of --position-* parameters to "lab mr discussion" to implement this [1].
(This interface is awkward, because almost all of them are needed.
Maybe we could fit all of this in one parameter somehow? Then there'd
be less room for user errors.)
Given a commit diff like
--- a/README.md
+++ b/README.md
@@ -3,2 +3,5 @@
 line 3
 line 4
+line 5
+line 6
+line 7

this allows to run a command like this to comment on "line 6".
lab mr discussion origin branch --commit=commit-id --position-file=README.md --position-line-type=+ --position-line-number=6 --position-line-number-old=5

The parameters should be fairly self-explanatory, except maybe the
line numbers. They are the equivalent to the two columns of line
numbers that GitLab/GitHub display to the left of a diff.
We should document in the command line help how they are computed,
but I wasn't sure where to add it.
This feature is designed to work well with Tig,
because Tig readily exposes the correct line number parameters.
Adding this to your ~/.tigrc
bind diff C !lab mr discussion %(remote) %(branch) --commit=%(commit) --position-file=%(file) --position-line-type=%(text) --position-line-number=%(lineno) --position-line-number-old=%(lineno_old)

will allow you press C on a line inside a diff hunk to comment on that line.
This can be really convenient with Tig. I took the liberty to mention
Tig in the documentation; not sure if this is appropriate.
(Please note that the --position-file-old which I added to the
examples currently requires an unreleased version of Tig, see Tig
commit 5a23214c (Expose %(file_old), the filename before a rename or
deletion, 2021-10-04).)
One annoyance with this binding is that every "lab mr discussion"
touches the network, so can be noticably slow. That's easy to fix
though.
Background:
I have been using a similar workflow with Tig, see
https://github.com/krobelus/gitlab-offline-review
I'd love to eventually switch to lab (or something alike)
I only heard about it in the recent Linux Plumber's Conference.
Also I discovered today that there is yet another similar project
glab. however, they don't
have a "mr discussions" command, so I stuck to lab.
(Additionally, there is
bichon but that looks
less flexible than a command line tool).

OOC How does this work for new files

For "+" lines, the <old_line> parameter is ignored, so the user can put any number there.We only need both numbers for context lines, as a workaround for the GitLab API issue.

These should be declared in a single var block.

Done. Sounds like a job for a linter.


Incorrect Task NAme

Under the Continuous Integration section, Step 7b says to add a task called 'Azure Resource Group Deployment', but I can't find a task with this name. Should it instead be 'ARM Template Deployment'?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e22e4d6-366f-fbf8-e141-8905ca7ab7ae
Version Independent ID: 5be2acf2-66e7-cadf-6666-5a85a65b9771
Content: Continuous integration and delivery in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-deployment.md
Service: data-factory
GitHub Login: @djpmsft
Microsoft Alias: daperlov

@EHulburd, Thanks for the question! We are taking a look into this and will get back to you soon.

Why has this been closed? Question still stands?

@Ehulburd we made the doc change to fix the issue you reported. This github issue was referenced in it and thus closed once it was merged. You should see the changes apply today

Ah okay thanks, I am just impatient it seems :)


Everything Operation doesn't respond correctly to deleted resources #…

…2133
Signed-off-by: Paul Bastide<EMAIL_ADDRESS>

LGTM - might want to add a testcase

WIll do...

Added an Integration Test


podman-load not tagging image as documented in man page

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
podman load does not behave as documented.
Steps to reproduce the issue:

Take existing image such as example:1, save to image as something like "podman -o image.tar example:1".

Delete the image such as "podman rmi example:1

Load the image as "podman load -i image.tar example:1

Describe the results you received:
Image is loaded without being tagged.
Describe the results you expected:
"man podman-load" documents the command with "podman load [OPTIONS] NAME[:TAG|@DIGEST]". It should have essentially tagged the image as the command "podman tag id example:1" would do.
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
Version:       1.0.0
Go Version:    go1.11.4
Git Commit:    "49780a1cf10d572edc4e1ea3b8a8429ce391d47d"
Built:         Tue Jan 15 03:38:17 2019
OS/Arch:       linux/amd64

Output of podman info:
host:
  BuildahVersion: 1.6-dev
  Conmon:
    package: podman-1.0.0-1.git82e8011.fc29.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: 49780a1cf10d572edc4e1ea3b8a8429ce391d47d'
  Distribution:
    distribution: fedora
    version: "29"
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>6
  OCIRuntime:
    package: runc-1.0.0-66.dev.gitbbb17ef.fc29.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc6+dev
      commit: ead425507b6ba28278ef71ad06582df97f2d5b5f
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>8
  SwapTotal:<PHONE_NUMBER>6
  arch: amd64
  cpus: 16
  hostname: desk.mcneil.com
  kernel: 4.19.15-300.fc29.x86_64
  os: linux
  rootless: true
  uptime: 118h 57m 55.37s (Approximately 4.92 days)
insecure registries:
  registries: []
registries:
  registries:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /home/sean/.config/containers/storage.conf
  ContainerStore:
    number: 1
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mount_program=/usr/bin/fuse-overlayfs
  GraphRoot: /home/sean/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
  ImageStore:
    number: 4
  RunRoot: /run/user/1000

Additional environment details (AWS, VirtualBox, physical, etc.):

It would appear it is not related to podman command as it is fixed without that package changing. runc, however, has been updated:
from
OCIRuntime:
package: runc-1.0.0-66.dev.gitbbb17ef.fc29.x86_64
path: /usr/bin/runc
version: |-
runc version 1.0.0-rc6+dev
commit: ead425507b6ba28278ef71ad06582df97f2d5b5f
to
OCIRuntime:
package: runc-1.0.0-68.dev.git6635b4f.fc29.x86_64
path: /usr/bin/runc
version: |-
runc version 1.0.0-rc6+dev
commit: ef9132178ccc3d2775d4fb51f1e431f30cac1398-dirty


GHCJS support. Hydra Testing. DO NOT MERGE.

I'm going to close these PRs for now, since they both clearly need more work, and you're not working on them atm.


Deprecate default_path support in repoPaths configuration

Summary
Now that we support the more general :owner/:repo template configuration (https://github.com/dlvhdr/gh-dash/pull/343), the prior default_path functionality (https://github.com/dlvhdr/gh-dash/pull/327) is redundant - e.g. this configuration:
default_path: ~/code/repos

can be achieved equivalently with:
:owner/:repo: ~/code/repos/:repo

Thus, we are deprecating the default_path syntax. It's still supported but will be removed in the next major version.
How did you test this change?
This is just a documentation change.

Might be worth running a quick code search to see how many use this. Something like: path:gh-dash/config.yml default_path

There are 2 results (and one commented-out value) for that query:
https://github.com/search?q=path%3Agh-dash%2Fconfig.yml default_path&type=code
That said, I'm not sure how representative this is, given that many folks might not push their dash config to a public GItHub repo.

Ok cool, then given this not very scientific way, lets merge this 😀

Ok sounds good! I've opened a new PR to remove default_path instead: https://github.com/dlvhdr/gh-dash/pull/345


Suggestion: Allow users to set how many cards to show per page

Dropping the amount of Artifacts/Characters/Weapons that are shown per page has been great for load times.
While the filter options are fine to sort/find what you're after - some users would just like to have more on one page regardless of how long it takes to load.
Maybe have a drop down to the left of the page number links to set how many cards/tiles are shown per page in mutiples of 8 up to 48?

Each breakpoint(page width) has different number of cards. This would be too complicated to implement and use.


Recommend protocol-relative CDN URL in README

now that you point it out—i prefer this to just be https. thanks for the PR.
http://www.paulirish.com/2010/the-protocol-relative-url/


increase max battery charge gauge threshold to 101 in case of LFP

fixes #4184: visualization issue of gauge turning "red" in case of 100% battery charged on lfp teslas

looks good!


Allow configurable request logger in Store Gateway

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Follow up of #7356
Changes
Now Store Gateway internal logs don't contain any information about context information such as request ID because it is using either the instance level logger or block level logger.
This PR adds a hook RequestLoggerFunc so that downstream projects can configure how to initialize the request time logger. For example, different projects have different ways to propagate request ID, like Cortex.
Verification
Tested locally.

Thanks. Merging now


Download a list fail

I want to download this URL:
https://www.youtube.com/watch?v=SOrb5n5fy8w&list=UUZJJTxA36ZPNTJ1WFIByaeA
there are 244 videos on this list when I download, all status is pending and then to 'X Failed'
if I click the restart button to download one by one, it works well. click more than 100 items and start one by one its a hard work. I think maybe you can fix this problem.
I am in China, used this program with a VPN,  maybe it's the issue from.
Thank you for this downloader.

Hey.
If you right click on the download list, you can restart all failed downloads.

I know this function, but it didn't work for the list I post. when I clicked to restart all, then all task changed status to 'pending... ' then to 'X Failed'.
I try edit code to fix this problem, I add a event TaskEnded when 'IsCanceled ,IsSuccessful,IsFailed' changed to value true. but then in some case, the restart button didn't work. I don't know much about WPF, so I don't know how to fix it.
Now the program can download the list for me, only some times its crash. I think it is now godd to  pull until I fix all the bug

I think the problem is the fact that some videos can't be downloaded currently.
See #89. I'll fix it eventually.


Allow to access functions from FuncMap

Seems, that calling only works for built-in functions, because
#{foo($bar)}

transforms into {{call .foo $bar}}, but should be without . character.
It can cause #25 issue.
More elegant solutions are welcome :)

bump, and word on this pull request? I have the exact same issue.

I have the same issue, pull request appears to fix it for me. It would be great if this could get fixed.

+1

I also encountered this problem in algernon, but when using a template.FuncMap when rendering the template with Amber, it worked.


[macOS] Chinese inputs will be invalid after FlutterViewController closed

On macOS, the input will be invalid after I create an extra FlutterViewController and release it.
The bug as shown in the video:
https://user-images.githubusercontent.com/3714809/160815796-d37b5a5f-443b-456a-9128-cb1f8b72a323.mp4

Steps to Reproduce

Create a macOS demo
Copy and paste 'Code Sample' into MainFlutterWindow.swift.
flutter run --debug
The first window will be displayed after the Demo started, and the second window will show after 5 seconds.
At this moment, we can type Chinese word into input widget. But if we close another FlutterViewController, the input will not work anymore.

Expected results:
After FlutterViewController was closed, the input box of previous ViewController works fine.
Actual results:
The input box of previous ViewController becomes invalid.

Code sample
class DemoFlutterViewController: FlutterViewController {

    deinit {
        self.engine.shutDownEngine()
    }

    override func viewDidLoad() {
        super.viewDidLoad()
        let textField = NSTextField(frame: CGRect(x:10,y:10,width:200,height:30))
        self.view.addSubview(textField)
    }
}

class MainFlutterWindow: NSWindow {
    override func awakeFromNib() {
        let flutterViewController = DemoFlutterViewController.init()
        let windowFrame = self.frame
        self.contentViewController = flutterViewController
        self.setFrame(windowFrame, display: true)

        RegisterGeneratedPlugins(registry: flutterViewController)

        super.awakeFromNib()

        self.perform(#selector(showWindow2), with: nil, afterDelay: 3)
    }

    @objc func showWindow2() {

        let flutterViewController = DemoFlutterViewController.init()
        var windowFrame = self.frame
        windowFrame.origin = CGPoint.init(x: windowFrame.origin.x + 50, y: windowFrame.origin.y + 50)

        let sub1Window = NSWindow(contentViewController: flutterViewController)
        sub1Window.contentViewController = flutterViewController
        sub1Window.setFrame(windowFrame, display: true)

        RegisterGeneratedPlugins(registry: flutterViewController)

        sub1Window.makeKeyAndOrderFront(nil)
    }
}

Logs
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.1 21C52 darwin-arm, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.1)
[✓] VS Code (version 1.65.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 1 category.

Diagnosis
After debug, we found out this bug has something related to [FlutterInputPlugin dealloc] method. If we comment out these lines of code every will be fine:

Hi @Taijuk, Thanks for filing the issue. I was unable to reproduce the issue please take a look at the below reproduction.
No matter which window is closed first I am able to enter text into the textfield.
https://user-images.githubusercontent.com/31410839/160828225-74ebdd64-0363-4f94-8505-29ff2998a4f4.mov

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3 21E230 darwin-arm, locale en-GB)
    • Flutter version 2.10.4 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (3 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.65.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.37.20220301

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:55555                    • android-arm64  • Android 11 (API 30)
    • iPhone 12 Pro (mobile) • 535317A4-921C-488F-B234-C2CC6D4AE5A1 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.3 21E230 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 99.0.4844.83

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @maheshmnj  and thinks for you relay.
I saw your operation and I think the reason why you can't reproduce is that, before close the second window, you reforce the first window and make the input widget out of focus. You can try leave the cursor in the first input widget, and just kill the second window. By this way I think you can reproduce the bug.

Thanks for the clarification @Taijuk, I was able to reproduce the issue on stable channel. But on the latest master it looks like the issue is fixed Please take a look at the below output.
stable / beta  ❌
https://user-images.githubusercontent.com/31410839/161203767-0ac606e8-420e-40cd-9235-9822121908ff.mov
master ✅
https://user-images.githubusercontent.com/31410839/161203884-fe1b8089-eb84-4e6b-926f-ce6ed9bd4a26.mov
✅ : No Issue ❌: Issue reproduced

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3 21E230 darwin-arm, locale en-GB)
    • Flutter version 2.10.4 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (3 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.65.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.37.20220301

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:55555                    • android-arm64  • Android 11 (API 30)
    • iPhone 12 Pro (mobile) • 535317A4-921C-488F-B234-C2CC6D4AE5A1 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.3 21E230 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 99.0.4844.83

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 2.13.0-0.0.pre.277, on macOS 12.3 21E230 darwin-arm, locale en-GB)
    • Flutter version 2.13.0-0.0.pre.277 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 13d2381109 (6 hours ago), 2022-03-27 21:00:08 -0400
    • Engine revision 559e259c54
    • Dart version 2.17.0 (build 2.17.0-246.0.dev)
    • DevTools version 2.11.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! CocoaPods 1.10.2 out of date (1.11.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin
        usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.65.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.37.20220301

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:55555                    • android-arm64  • Android 11 (API 30)
    • iPhone 12 Pro (mobile) • 535317A4-921C-488F-B234-C2CC6D4AE5A1 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.3 21E230 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 99.0.4844.83

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[✓] Flutter (Channel beta, 2.12.0-4.1.pre, on macOS 12.3 21E230 darwin-arm, locale en-IN)
    • Flutter version 2.12.0-4.1.pre at /Users/mahesh/Documents/flutter_beta
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 680962aa75 (2 weeks ago), 2022-03-16 13:46:03 -0700
    • Engine revision e9f57b5d0f
    • Dart version 2.17.0 (build 2.17.0-182.1.beta)
    • DevTools version 2.11.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! CocoaPods 1.10.2 out of date (1.11.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart
        side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.65.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.37.20220301

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.3 21E230 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 100.0.4896.60

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Closing, as the fix is available on the latest master and it will land on the stable channel in future releases.


Deny missing Debug and Copy from data structures

You will see a few TODO's because the fields down impl copy or debug.

@sgrif I believe comments have been addressed.  Still need to look into compile test errors.

Doesn't look like there are any compile test errors?

👍 Thats weird.  I had them locally.  Must be my nightly version.

Yeah, make sure you're using the same version in .travis.yml. I'll bump it soon as there are breaking changes coming in libsyntax tomorrow. LGTM

Thanks for the help! 😄


added approval endpoint for delegator after they anchor seal in their KEL

Additions based on Phil's guidance and using his current PR

How does it work when the delegator is a multisig? Do all participants have to do the same thing?

Great questions @lenkan i'll need to add tests for the multi-sig case to be sure. The delegatee 'dip' event and the 'ixn' events will be thresholded, the multi-sig AID won't complete until enough signatures are provided.

Does the second POST with the approveDelegation field actually append an event? If not, I think this should move to a separate endpoint to avoid confusion. To me POST /identifiers/name/events says that you will append an event to the KEL.

Without the approval, the delegator AID won't process the 'dip' of the delegatee. It will sit in escrow until the approval is given. It is meant to be similar to the 'ixn' anchor being needed, but this is an additional check in order to protect the delegator AID from accidentally anchoring a seal that triggers an approval. So the delegation isn't complete until the 'dip' is finally processed by the delegator when the approval is sent, but that still depends on all the signature thresholds being met. Since it is a two step-process the correct functionality is that a threshold of approvals is met, I believe. I'll verify with tests if a threshold of approvals is needed for the multi-sig case. Thoughts?

I find the API little confusing.
What is the process?

Delegatee create delegated inception event dip
Delegator receives the inception event details out of band
Delegator create interaction event with delegation information in anchor data.
Delegator approves delegation by posting the same interaction event again?

What is the risk with having step 4 processed automatically?
If it is not possible to do automatically, can we add a flag to step 3 so it becomes
POST /identifiers/name/events
{
   ixn: [ anchor data ],
   approveDelegation: true
}

Another option if we need to explicitly call the server again, can we move it to another endpoint? What is it that is being created or modified here? Is it a "pending delegation request"?
Note: I am not saying any of my suggestion are objectively better, just trying to trigger discussion about how we design the HTTP API of KERIA so that we can improve it as we move forward.

Shifting over to a new PR, but will recap the needed changes based on @lenkan suggestions #248


Last changes on maven

Hello Gerrit,
is it posible to have the last changes/merges put on Maven central?
Thank you,
Claudio

Hi Claudio,
Sure, I was just not sure if there will be more pull requests coming :)
Will do a release later today and publish it to maven central (might take a day or two to appear).
Cheers,
Gerrit

Thank you


support in knowledgebase plugin

Lightbox works fine in wiki, but in knowledgebase doesn't work at all.
All preview links suggest download img instead popup preview or direct link to show img.
Can you fix it or direct me in wich file i need to solve this problem/

I haven't used this plugin before. Can you please post some screenshots and mark the placed where the lightbox should be working?
I haven't got much time lately to work on enhancements here as I'm a new dad.
So if you can write JavaScript and know jQuery, you can take a look at these lines here https://github.com/paginagmbh/redmine_lightbox2/blob/master/assets/javascripts/lightbox.js#L78-L91 and add CSS selectors for the images you'd like to view in a lightbox and then send the changes as a pullrequest.
If the knowlegebase plugin doesn't provide consistent classes for images or doesn't mention the filename in the href or title attribute, you would have to tweak those elements first, as you can see in some examples at the beginning of the file where I add thumbnail classes or tweak elements to work properly.

thanx for response.
I'm found that attachment.js not included in <head> section on knowledgebase articles. I'm add ArticleController to hook, and all works fine.
git diff
diff --git a/lib/hooks/view_layouts_base_html_head_hook.rb b/lib/hooks/view_layouts_base_html_head_hook.rb
index 2d82d7a..4fed18e 100644
--- a/lib/hooks/view_layouts_base_html_head_hook.rb
+++ b/lib/hooks/view_layouts_base_html_head_hook.rb
@@ -8,7 +8,8 @@ module RedmineLightbox2
                                       context[:controller].is_a?(DocumentsController) ||
                                       context[:controller].is_a?(FilesController) ||
                                       context[:controller].is_a?(MessagesController) ||
-                                      context[:controller].is_a?(NewsController))
+                                      context[:controller].is_a?(NewsController) ||
+                                     context[:controller].is_a?(ArticlesController))
           return stylesheet_link_tag("jquery.fancybox-2.1.5.css", :plugin => "redmine_lightbox2", :media => "screen") +
             stylesheet_link_tag("lightbox.css", :plugin => "redmine_lightbox2", :media => "screen") +
             javascript_include_tag('jquery.fancybox-2.1.5.pack.js', :plugin => 'redmine_lightbox2') +

I haven't got much time lately to work on enhancements here as I'm a new dad.

Congrats!

Awesome, thanks for having a look and chasing the issue down to the plugin hook!
I will certainly add this to the next release in a couple of weeks. Please bear with me ;-)

I'm glad to help usefull plugin. Thanx for your work.

Thanks guys! I'm also using the knowledgebase plugin and this certainly helped.

Support for alexbevi/redmine_knowledgebase plugin has been added. Can anyone test the current master branch in Redmine 3.4 and confirm that it works? Thanks!


feat: use infinite-scroll with grid or any custom container

Feature Request
Ionic version:

[x] 5.x
Describe the Feature Request

Currently, i'm working on a client's project where i need to use infinite-scroll but i'm unable to do so. I have a page where i got upper section 30% filled with filter controls (like search, sort etc) and remaining 70% page contains the grid. I cannot let my page scroll as i need full view, therefore i need infinite-scroll with grid, but it seems to work only with page.
It would be great to have this thing done.
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

Thanks for the feature request. What you described should already be possible with ion-infinite-scroll. If it is not working, it might be a bug in ion-infinite-scroll. Can you provide a repo with the code required to reproduce thie issue?

Thanks for the feature request. What you described should already be possible with ion-infinite-scroll. If it is not working, it might be a bug in ion-infinite-scroll. Can you provide a repo with the code required to reproduce this issue?

oh, sorry, i accidentally closed the issue. i just created a project, please have a look, hope it helps.
https://stackblitz.com/edit/ionic-v4-angular-tabs-dpk9gu?embed=1&file=src/app/tab1/tab1.page.html

Thanks for the follow up. The infinite scroll component looks to use the dimensions of ion-content, so you would likely need to move your card outside of ion-content in order to "block" 300px of the height. From there, you can remove the <div style="height: calc(100% - 220px); overflow: auto;"> element.
Can you give that a try and let me know if it works?

Yes, i worked the way you said and it solves the problem for now.
But shouldn't ion-infinite-scroll needs to be flexible enough, so that i don't need to put everything outside the ion-content except for my infinite-scroll ?
I mean, ion-content suppose to contain everything except for ion-header and ion-footer and that's how its in DOC, Isn't it ?

Yeah it should probably let you provide a custom reference element rather than assuming you are using ion-content. I will mark this as a feature request.

I was also working with ion-virtual-scroll and found it had the same problem like infinite-scroll.
Should i also provide a repo for this too, or create a new issue ?

Hey there,
We added support to Ionic that lets you use ion-infinite-scroll in any scrollable content through the use of the ion-content-scroll-host class. The intended usage here is with virtual scroll containers, but you can use it in any scrollable container.
We have usage docs here: https://ionicframework.com/docs/api/infinite-scroll#usage-with-virtual-scroll
In the StackBlitz you provided you would add the ion-content-scroll-host class to the div that is commented out, and then disable scrolling on the ion-content using scrollY="false".


[SPARK-31620][SQL] Use TreeTagNode to preserve inputAggBufferAttributes for agg function

What changes were proposed in this pull request?

Use TreeTagNode to preserve inputAggBufferAttributes for declarative aggregate function.
Why are the changes needed?

inputAggBufferAttributes from a partial agg can be referenced by a final agg. However, in case of an aggregate function contains a subquery,  the aggregate function will be transformed to a new copied node during PlanSubqueries and lost original attributes because TreeNode does not preserve "lazy val" during makeCopy. As a result, it fails final agg to resolve references through partial agg's input. Please check SPARK-31620 for details.
Does this PR introduce any user-facing change?

Yes, user hit error previously but run query successfully after this change.
How was this patch tested?

Added a regression test.

Test build #122492 has started for PR 28496 at commit bc1b7e5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27153/
Test PASSed.

Is there any material about makeCopy,  tag etc...

Is there any material about makeCopy, tag etc... To better know the TreeNode.

Just check the source code?

cc @AngersZhuuuu @cloud-fan @wangyum

fyi, tags could be copied along with makeCopy @AngersZhuuuu

thanks a lot, it's not clear to me that which one will be retained and which one will be reset in makeCopy, I will check the SourceCode detail.
And  for
private lazy val sum = AttributeReference("sum", sumDataType)()

In Sum, it will be change in PlanSubqueries too, and result in different ExprId,
Do we need to handle this ?

Do we need to handle this ?

I think no, because those attributes are not referenced by others.

Test build #122492 has finished for PR 28496 at commit bc1b7e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122492/
Test PASSed.

Test build #122506 has started for PR 28496 at commit cbd891d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27167/
Test PASSed.

Test build #122506 has finished for PR 28496 at commit cbd891d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122506/
Test PASSed.

I'm wondering if there could be a solution that doesn't involve using tree tags, but perhaps use a secondary constructor like the way AggregateExpression passes resultIds around, and make concrete derived types of DeclarativeAggregate use the explicitly set Id if defined.
So e.g. for Sum, instead of
private lazy val sum = AttributeReference("sum", sumDataType)(/* implicitly make new exprId every time)

maybe have some supporting utils in DeclarativeAggregate like:
+  val explicitAggBufferAttributeExprIds: Option[Seq[ExprId]] = None
+
+  // TODO... maybe put these in a mixin instead
+  override def otherCopyArgs(): Seq[AnyRef] = explicitAggBufferAttributeExprIds :: Nil
+
+  protected def makeAggBufferAttribute(
+      ordinal: Int,
+      name: String,
+      dataType: DataType,
+      nullable: Boolean = true): AttributeReference = {
+    explicitAggBufferAttributeExprIds match {
+      case Some(exprIds) => AttributeReference(name, dataType, nullable)(exprId = exprIds(ordinal))
+      case _ => AttributeReference(name, dataType, nullable)()
+    }
+  }

and make Sum agg buffer declaration as:
private lazy val sum = makeAggBufferAttribute(0, "sum", sumDataType)

I tried this and unfortunately it requires all the places that create a Sum to go from Sum( ... args ... ) to Sum( ... args ... )() for the secondary ctor. That's quite a few places touched :-(

Those attributes are mostly lazy. So does that mean we need to generate exprIds eagerly before create agg functions in this way?

Test build #122582 has started for PR 28496 at commit 882467b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27244/
Test PASSed.

Test build #122583 has started for PR 28496 at commit 9a0b788.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27245/
Test PASSed.

Test build #122585 has started for PR 28496 at commit 3fd39c5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27247/
Test PASSed.

Test build #122582 has finished for PR 28496 at commit 882467b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122582/
Test FAILed.

Test build #122583 has finished for PR 28496 at commit 9a0b788.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122583/
Test FAILed.

Test build #122585 has finished for PR 28496 at commit 3fd39c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122585/
Test PASSed.

Those attributes are mostly lazy. So does that mean we need to generate exprIds eagerly before create agg functions in this way? @rednaxelafx

I'd say "yes", generating exprIds eagerly shouldn't be a big overhead, and it'll help keep the AttributeReferences stable later on

Please note that we've switched to another way to fix the issue in order to avoid using TreeTagNode. @AngersZhuuuu @rednaxelafx

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27266/
Test PASSed.

Test build #122604 has started for PR 28496 at commit 64d13fc.

Test build #122605 has started for PR 28496 at commit 89ae4bf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27267/
Test PASSed.

Test build #122605 has finished for PR 28496 at commit 89ae4bf.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #122604 has finished for PR 28496 at commit 64d13fc.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122605/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122604/
Test FAILed.

Test build #122609 has started for PR 28496 at commit 8aecd57.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27271/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27281/
Test PASSed.

Test build #122619 has started for PR 28496 at commit 493157a.

Test build #122609 has finished for PR 28496 at commit 8aecd57.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122609/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122619/
Test FAILed.

retest this please

Test build #122642 has started for PR 28496 at commit 493157a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27304/
Test PASSed.

Test build #122642 has finished for PR 28496 at commit 493157a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122642/
Test FAILed.

retest this please

Test build #122662 has started for PR 28496 at commit 493157a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27324/
Test PASSed.

Test build #122662 has finished for PR 28496 at commit 493157a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122662/
Test PASSed.

thanks, merging to master/3.0!

thanks all!


Change mode when set off

Describe The Bug:

when I set one or more zone off, the mode change to stop. I have to go back into the Airzone app and change the mode to Heating or cold.
To Reproduce:

Set a zone to off on HomeKit
Go to airezone app
The mode set to stop
Expected behavior:

Correct the issue
Logs:
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version:
Homebridge Version:
Node.js Version:
NPM Version:
Operating System:

Hi @Pascal26120, I was analyzing it previously and the problem is how to become off the machine as the HomeKit only allows to expose thermostats for each zone, and then you never could switch it off, and also for turn it on the mechanism is similar the last thermostat set if will use hotter or cooler.
Anyway, I could add an option in the configuration to disable it.

But you only can switch off the zone, not the machine

Yes I just want to switch off/on one zone. But I do this from HomeKit, on Airzone app the cooler switch to STOP

Ok, I'm going to discard it because will be done in enhancement #8

Done in v0.3.6.


fix: refine the types more, to improve type extends behaviour

See also: #233 (i pulled the doc comment from here), #232, #231
The old types prevented
interface MyEventListeners {
  print(message: string): void
}

class MyEmitter extends EventEmitter<MyEventListeners> {
  emit<Event extends keyof MyEventListeners>(
    event: keyof MyEventListeners
    ...args: Parameters<MyEventListeners[Event]>
  ) {
    // customizations
    return super.emit(event, ...args);
  }
}

from working properly, as typescript borked where it fails to match
the arguments types with impossible-to-reach types.
The smallest change to achieve this fix is to change the any[] in Arguments<...> to never.
to understand this change, understand that the reference to the Arguments type will never reach the any[] case from within the EventListener type mapping, since K already must be a keyof T once we're in the alternate(else, after the :) branch of T extends string | symbol, since EventNames in this case will be specifically keyof T.
Typescript just isn't smart enough to them since this situation runs in parallel (not actually parallelism, just like, conceptually) in the type checker, the invariant i've attempted to describe is coincidental; the causation doesn't flow from one to the other or vice versa.
And the ArgumentMap type will already handle the any[] type for when the value in the object isn't a function or array.
Hope you can understand this explanation well enough to merge this change! I've done my best, i could do better with a whiteboard.
Also, i don't like having the type name Arguments because it's too close (IMO) to the builtin IArguments, so I felt it worthwhile to just remove that type, keep it smaller.

cc: @gfmio

Thank you.


[Bug]: The server does not start

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
OTG does not allow the server to start and writes an error
Expected Behavior
There will be no errors in OTG and the server will start
Which platforms have you reproduced this issue using?
Forge Multiplayer
OTG Version
OTG 1.16.5 0.1.10
Platform Version
Java Verison: 17.0.3, N/A This server is running Magma version 1.16.5-36.2.33-7cf72f3c (Implementing API version 1.16.5-R0.1-SNAPSHOT, Forge Version 36.2.33-7cf72f3c)
Steps To Reproduce

Create a server on the Magma core
Move Open Terrain Generator to the mods folder
Start the server

Log file
https://paste.denizenscript.com/View/96394
Anything else?
I'm trying to run a server with some other mods, including Dregora, which depends on Open Terrain Generator. (Without Open Terrain Generator and Dregora, the server starts normally). A log file that includes all mods: https://paste.denizenscript.com/View/96395
the sh script with which I start the server:
java -Xms128M -Xmx8192M --add-exports=java.base/sun.security.util=ALL-UNNAMED --add-exports=jdk.naming.dns/com.sun.jndi.dns=java.naming --add-opens=java.base/java.util.jar=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED -jar Forge.jar nogui

We do not support hybrid servers


sirf-contrib

SIRF-contrib needs to be git cloned and installed with the rest of the SIRF python code.
The end goal is so that we can do from sirf.contribs.kcl import Prior etc.

just copy SIRF-Contribs/src/Python/ to  PYTHON_DEST/

just tried this locally and cp -r SIRF-Contribs/src/Python/sirf/contrib to $PYTHON_DEST/sirf enables import sirf.contrib

@paskino have you had the chance to have a look at this yet? We'll need it for the symposium.

@paskino I'll do this now if you haven't already started


Use local profile for installing from source

README adjustment in order to use local profile for installing from source (performance increase).

Hmm do we want the local profile really? cargo install should be installing release mode, no? it's not for debugging?

installing locally with the release settings doesn't make much sense, but a better solution would be to rename the current release profile to something like publish I think


[Frontend] Integration Get Profile Page for Brand

Description

[ ] Complete the GET Profile API - https://github.com/Kajol-Kumari/InfluMart/blob/main/backend/controllers/brandController.js#L54
[ ] As soon as i log in using emailId and password as brand, I should be seeing my details instead of dummy Data. There should be Settings and inbox buttons instead of Follow and Message.

can you please assignn this to me I am working this page only.


fix(ui): menusave now gets called on menu toggle

Not sure if this is the proper way to solve this.
But my moving the son_menu_save call into the closing if-loop it will
get properly called on when closing the menu with toggle_quick_menu().
I think merging this change will resolve issue #49.

This is how the saving used to work. It was intentionally changed to match the semantics of saving in vim. :w and :wq should both save for you, while :q will close the menu but not save your changes. This is how @ThePrimeagen wanted it to function.
If w is not saving for you, please open an issue about that.

So what I perceived as an error is it's intended behavior. Should I close my issue and this PR?

Sorry for being out on this.  Let me review now.

@A-Daneel I have an idea
Could you add an option to the top level config, defaults to false
Check out project config
It has a top level key projects, it could have other top level keys as well.  Imagine ui and you could add a key that is saveOnWrite, which defaults to true.
Thoughts? @asbjornhaland

If we should have 'autosave' I think the best solution is as @ThePrimeagen mentions - an option in the config.

I also agree that an option for this is a good idea.
On Sat, Apr 3, 2021, 1:17 PM Asbjørn Håland @.***>
wrote:

If we should have 'autosave' I think the best solution is as @ThePrimeagen
https://github.com/ThePrimeagen mentions - an option in the config.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ThePrimeagen/harpoon/pull/50#issuecomment-812920126,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEEZZNWRR7A4AYWUIAVG23TG5ZXHANCNFSM4Z6I5EZA
.

@A-Daneel I may take a stab at this at some point, are you going to follow up on this?  Or should I consider this a task for me?

Kinda depends on how much of a priority it is for you. Think between study and work it'll take me a day to figure out what is going on where. If it's no rush I'd love to take take a stab at it.

I've done a very small change. if you manually edit your harpoon.json to match project config it only saves on close if save_on_menu_quit is true.
Feedback is more then welcome

Not sure how to proceed from here, and if what I did thus far is correct.
@ThePrimeagen @asbjornhaland could either of you tell me if I'm on the right track with this.

@A-Daneel I am so sorry.  I didn't see this!
Let me review!

@A-Daneel Last thing.
Could you rebase your commits to 1 commit!
git rebase -i HEAD~6   -- I think

@ThePrimeagen That was a learning experience and a half. Upside is I now understand rebasing and reverting git history.
Hope it's ready for merge


Existing resource blocks backend deployment

** Please describe which feature you have a question about? **
I need a correct aws-exports.js when building my frontend in Amplify Console, so I setup my amplify.yml like this:
version: 0.1
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - npm run build
        - hugo version
        - hugo
backend:
  phases:
    build:
      commands:
        - amplifyPush --simple

However it keeps failed due to resource already exists (did a amplify push from CLI).
2020-05-18T15:24:13.452Z [WARNING]: Error updating cloudformation stack
2020-05-18T15:24:18.461Z [INFO]: Following resources failed
                                 Resource Name: LambdaExecutionRole (AWS::IAM::Role)
                                 Event Type: create
                                 Reason: pinpointLambdaRole2c988b36-dev already exists in stack arn:aws:cloudformation:ap-southeast-1:254383410929:stack/amplify-site-dev-153651-analyticssite-1MUTPXZ28EJO0/377ac3b0-9841-11ea-a1ae-0a1335ff27ae
2020-05-18T15:24:18.462Z [INFO]: Resource Name: backend-20200517142442-authRole-idp (AWS::IAM::Role)
                                 Event Type: create
                                 Reason: Resource creation cancelled
                                 init failed
2020-05-18T15:24:18.463Z [WARNING]: ✖ An error occurred when pushing the resources to the cloud
                                    ✖ There was an error initializing your environment.
2020-05-18T15:24:18.465Z [INFO]: { ResourceNotReady: Resource is not in the state stackUpdateComplete

Why does this make my deployment fail? I can delete them from CloudFormation or start a new environment, but this baffles me.

Do you know what the state of your CloudFormation stack was before you tried this deploy? If it wasn't in 'stackUpdateComplete' or 'stackCreateComplete' then this could be why your re-deploy is failing.

The CloudFormation stack for backend, cognito and analytics was in 'CreateComplete' status after amplify push with CLI.
I removed all the environment and tried again, this time I only did amplify add analytics from CLI to generate code and did not push with CLI at all. Same amplify.yml.
It failed again but with fresh error:
2020-05-19T02:47:23.067Z [WARNING]: Error updating cloudformation stack
2020-05-19T02:47:28.075Z [INFO]: Following resources failed
2020-05-19T02:47:28.077Z [INFO]: Resource Name: UpdateRolesWithIDPFunction (AWS::Lambda::Function)
                                 Event Type: create
                                 Reason: The runtime parameter of nodejs8.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs12.x) while creating or updating functions. (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 8f26e7a4-f069-4ddd-acc5-fb70e338bc87)
                                 Resource Name: backe-Cogn-XE3AV3F367CW (AWS::IAM::Policy)
                                 Event Type: create
                                 Reason: Resource creation cancelled
                                 Resource Name: backe-Cogn-1DE5UYAVOH3WV (AWS::IAM::Policy)
                                 Event Type: create
                                 Reason: Resource creation cancelled
                                 init failed

Overriding the amplify-cli version in build image seems to fix the issue for me.
2020-05-19T02:57:23.534Z [INFO]: # Ensuring NPM package '@aws-amplify/cli' is version: 'latest'
2020-05-19T02:57:30.878Z [INFO]: # Patching NPM package '@aws-amplify/cli' from 1.12.0 to 4.20.0...
2020-05-19T02:58:19.498Z [INFO]: # Done patching NPM package '@aws-amplify/cli'

@lebenasa great, please feel free to re-open the issue if you have any more trouble. Thanks


Unable to create aliasified data packages

There have been some use cases for support for aliasified data package.  The recent changes to validation etc seems to made this non functional

+1


Update index.js

Coverage increased (+0.3%) to 91.176% when pulling dd65d91e911b9acaee9f0044d9be255384155958 on enlian:master into 21dd26f0310a2c58df35bb3d7e5f0b53a3751cfb on meinto:master.

Hi, what is your intention behind this pull request? Do you want to return something when the event is emitted?
Then you should return it outside the loop. And return a true or something...
Maybe you can explain a bit. Would be nice.
Thx, Tobias


Themekit's new command doesn't work well with Shopify 2.0 themes

It's frustrated me for awhile when I have local theme files and run the new command that it will still generate the Timber theme files, but now especially with the 2.0 theme template structure the new command is getting more annoying because it will generate the .liquid templates even though my theme has the .json template files.
I would love to see an option added to the new command where it only uses the local files and doesn't generate any Timber files. If there are some files that actually are required and theme creation will error out without them, the new command could just error out if those files do not exist locally (obviously this would have to handle original vs 2.0 theme formats).
Happy to discuss further

If you're going to create a new Shopify theme for OS2.0 using the current version of ThemeKit, unfortunately, you'll still have to manually convert all of the templates to JSON templates.
Personally, what I did is

I created a new project using ThemeKit
Then, converted all templates to JSON
Then, push them to a new repository

So whenever I create a new theme, I just pull those files from my repo, and viola, all templates are compatible with OS2.0 lol
So yeah, the current ThemeKit is not yet updated to this new OS2.0 and I didn't like Shopify CLI for themes because it just clones Dawn. It's just annoying having those files.
But yeah, hopefully, they work on this so we can easily create new themes for OS2.0


Getting 401 errors when running the Flood docker container

It gets stuck at the loading page. I get 401 errors in the server terminal. Can you please share the docker run command for the most basic setup I can use.

I noticed 401 errors on first startup as well. I created a user but the inteface hung with two checkmarks. I reloaded the page, got a login dialog. Logged in and everything worked as expected.


Add PBKDF2 encryptor via OpenSSL::PKCS5

Why: A strictly NIST/FIPS compliant encryptor.

Is there a reason not to just instruct users to set stretches = 100_000
On Thu, Sep 29, 2016 at 4:41 PM, Peter Karman<EMAIL_ADDRESS>wrote:

@pkarman commented on this pull request.
In lib/devise/encryptable/encryptors/pbkdf2.rb
https://github.com/plataformatec/devise-encryptable/pull/12:

@@ -0,0 +1,14 @@
+module Devise

module Encryptable
module Encryptors

 class Pbkdf2 < Base

   def self.digest(password, stretches, salt, pepper)

     digest = OpenSSL::Digest::SHA512.new

     len = digest.digest_length

     iterations = 2**stretches

or 2**(stretches + 4) ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/plataformatec/devise-encryptable/pull/12, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAADBPQ-BbRPZXGefInWXX_BVFJPWQm8ks5qvCJvgaJpZM4KKcf0
.

--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6

that would be easiest yes :)
I was going for swap-in-ability conformance.
Maybe iterations = 100_000 unless stretches > 1000 is safe and sane?

I'm not super familiar with the devise-encryptable aesthetic, but in
general parameters to one KDF will not be portable to another, so I think
making a user provide parameters that are germane to their selected
algorithm makes most sense.
On Thu, Sep 29, 2016 at 5:16 PM, Peter Karman<EMAIL_ADDRESS>wrote:

that would be easiest yes :)
I was going for swap-in-ability conformance.
Maybe iterations = 100_000 unless stretches > 1000 is safe and sane?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/plataformatec/devise-encryptable/pull/12#issuecomment-250593771,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAADBI7YhS3v-SSHDcT-tuULI8Tl8fJ_ks5qvCqXgaJpZM4KKcf0
.

--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6

I added a note about the value of stretches in ecd6adc


Added duration_cal column

I've added duration_cal column to the dataframe that is returned by calibration_and_holdout_data function.

To confirm: this represents the duration between the observation period end and the earliest purchase - and it's the same for everyone? What are some use cases of this?

This represents the actual duration of the calibration period(so time between the first purchase in the dataset up until the last purchase in the calibration period) . Which is in fact the same for everyone. I can imagine that it'll be useful in later stages when determining the length of calibration period for getting a good estimate on the observation period.

I don't think I like this addition. It is a redundant column if it's the same for everyone, and can be calculated outside of the function quite easily. It's also slightly misleading, as it looks like the individuals life so far (but it's really not). What are your thoughts?
When I was looking at this PR, even though it was only 1 line addition, I was super confused about what the variables and columns represented. For example, at first glance, I thought "what is T vs duration?" There's probably a better API for this.
Also, I appreciate your PRs and comments. Would you like to be a core contributor to lifetimes?

I don't think I like this addition. It is a redundant column if it's the same for everyone, and can be calculated outside of the function quite easily

True, however we have the same for the  duration_holdout  no? It is not possible for that column to have different values.
However it's indeed true that this can be calculated outside the function easily, it's totally fine for me to discard this pull request.

Also, I appreciate your PRs and comments. Would you like to be a core contributor to lifetimes?
Thank you! I'm learning about the model on the go, but I'd be honored to be mentioned as contributor


Yolo loss always zero when using batch size 1

I have the following when using batch size = 1 (loss = 0.0000e+00 for all batches and for all epochs)
1/1224 [..............................] - ETA: 11:37:36 - loss: 0.0000e+00 - yolo_layer_1_loss: 0.0000e+00 - yolo_layer_2_loss: 0.0000e+00 - yolo_layer_3_loss: 0.0000e+00
2/1224 [..............................] - ETA: 5:58:09 - loss: 0.0000e+00 - yolo_layer_1_loss: 0.0000e+00 - yolo_layer_2_loss: 0.0000e+00 - yolo_layer_3_loss: 0.0000e+00
3/1224 [..............................] - ETA: 4:04:44 - loss: 0.0000e+00 - yolo_layer_1_loss: 0.0000e+00 - yolo_layer_2_loss: 0.0000e+00 - yolo_layer_3_loss: 0.0000e+00
4/1224 [..............................] - ETA: 3:06:50 - loss: 0.0000e+00 - yolo_layer_1_loss: 0.0000e+00 - yolo_layer_2_loss: 0.0000e+00 - yolo_layer_3_loss: 0.0000e+00

The problem disappears if I use batch size = 2. Is this some kind of error computing the loss?
I would like to use gradient accumulation techniques, e.g. this one to cope with limited GPU memory.

Hello @DavideACucci,
Firstly, imageAI doesn't support gradient accumulation techniques.
secondly, concerning the batch size of 1 you are expected to always use batch sizes that of powers of 2 i.e 2, 4, 8, 16, . . . also using you are introducing very high variance into your train data by using a batch size of 1 and you might need to use other kinds of optimizers that are not currently available on imageAI for things to work.

Dear @AbimbolaOO,
I know that imageAI does not support gradient accumulation techniques, I wanted to create such extension to be able to train on GPUs with limited memory. Batch size 1 and gradient accumulation should do as far as I know, provided that the loss for the batch with size 1 is properly returned.
Am I wrong?


Visual Studio compiles fail from command line since last checkin.

Commit c96f3b9f8b3cdff58c0e788aa7f892781f0b352c supports command line overrides for various flags.  Unfortunately, overriding CC and CXX with Visual Studio (tested 2012) causes devenv.com to run instead of cl.exe.
The error "exception has been thrown by the target invocation" is seen while compiling from Scons.

Fix in testing

Fix in 6d3b1e2bde87f7c547dd8b64a5ae2e6925871439.


Summarize Lexical Features at Conversation Level

Currently, calculate_conversation_level_features does not summarize any of the lexical features (e.g., word counts for the various LIWC corpuses).
In part, this is due to the fact that lexical features take way too long to run anyway (see: https://github.com/Watts-Lab/team-process-map/issues/56). But also, when the lexical features do work, they will generate a bunch of columns with different names, and we need to summarize each one at the conversation level.

Thank you @yashveersinghsohi !!


Will "MilitarySymbologyWeb" web app be released?

@joebayles Will the web app SolutionsWeb\Apps\Military\MilitarySymbologyWeb be released? The associated portal item is owned by you. If it's not going to be released that please remove this app folder from the SolutionsWeb\Apps\Military so it's not shipped with the release. Alternatively, I can remove to another location on the server so it's not included, but you'll have a backup of this files. Thank you.

Assigning to @Dbarnes1 because I think this is his item that I just worked on.

@elinz this web app is referencing feature layers that no longer exist. I think that this web app can be deleted.

@joebayles @Dbarnes1 Moved this app to the following folder on the server so it's not going to be a part of this release:
c:\EricL\TEM2016Release\SolutionsWeb_files_removed_from_release\Apps\Military


Add notavarnex.github.io

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the GTMetrix report
[x] The domain is in the correct alphabetical order
[x] This site is not a ultra lightweight site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: notavarnex.github.io
  url: https://notavarnex.github.io/
  size: 1.37
  last_checked: 2022-07-12

GTMetrix Report: https://gtmetrix.com/reports/notavarnex.github.io/lNMKJ6ak/

Thanks for your submission. Unfortunately, this site falls in the "ultra minimal" category as defined by the FAQ, so we can't accept it.


Change applicationId

Set unique applicationId
The 'GradleException' issue started when I renamed the application ID, it seems gradle got stuck in a weird state and cannot recover, even after cleaning the caches and doing all sorts of what-nots.

LGTM, merging


Group tabs by windows

Hello,
In the tabs list, is it possible to add a feature to group by windows?
In order to see the all tabs that belong to the same window?
Thank you !

If a grouping feature is added, it should support grouping by any arbitrary attribute, thus enabling sorting and grouping to use similar logic and consume the same attributes.


cluster.yaml: Deprecate (or even remove) controller* and etcd* keys

and move those keys under the controller and etcd keys respectively.
Doing so would allow us to (1) remove duplicated code by reusing model.NodePoolConfig, which is currently used only for workers, also for etcd and controller nodes (2) provide users more consistent view of configuration among controller, etcd, worker nodes.
After the move, cluster.yaml would look like:
worker:
  nodePools:
    name: pool1
    count: 3
    instanceType: t2.medium
    # ...

controller:
  count: 3
  createTimeout: PT15M
  instanceType: t2.medium
  rootVolume:
    size: 30
    type: gp2
    iops: 0

etcd:
  count: 3
  instanceType: t2.medium
  tenancy: default
  rootVolume:
    size: 30
    type: gp2
    iops: 0
    ephemeral: false
  dataVolume:
    size: 30
    type: gp2
    iops: 0
    encrypted: false

instead of the current:
worker:
  nodePools:
    name: pool1
    count: 3
    instanceType: t2.medium
    # ...

controllerCount: 3
controllerCreateTimeout: PT15M
controllerInstanceType: t2.medium
controllerRootVolumeSize: 30
controllerRootVolumeType: gp2
controllerRootVolumeIOPS: 0

etcdCount: 3
etcdInstanceType: t2.medium
etcdRootVolumeSize: 30
etcdRootVolumeType: gp2
etcdRootVolumeIOPS: 0
etcdDataVolumeEphemeral: false
etcdDataVolumeSize: 30
etcdDataVolumeType: gp2
etcdDataVolumeIOPS: 0
etcdDataVolumeEncrypted: false
etcdTenancy: default

Do we want to layer it any more at the same time we remove some backwards compatibility? e.g. etcd.rootVolume.size, etcd.rootVolume.type

We may be able to share more code between worker/controller/etcd like this?

@c-knowles

Do we want to layer it any more at the same time we remove some backwards compatibility? e.g. etcd.rootVolume.size, etcd.rootVolume.type

Yes 👍

We may be able to share more code between worker/controller/etcd like this?

Probably yes

Updated the description to reflect https://github.com/coreos/kube-aws/issues/372#issuecomment-283519584
For example, etcd.rootVolumeSize is now etcd.rootVolume.size

Should we do the same clean up for worker* keys?

worker* settings are used to be inherited to worker node pools as the default values but existing code around that is fairly complicated and makes the PR significantly bigger.
I'll create an another issue and a PR to clean up worker* keys.


Fetching previous documents when using OFFSET and LIMIT in query

Package Name: @azure/cosmos
Package Version: 3.1.1
Operating system:
[ ] nodejs

version: 11.10.1

[ ] browser

name/version: Chrome

[ ] typescript

version: ^3.5.3

Describe the bug
I'm using the SDK via browser, when I made a query with an offset and limit parameter, all previous document get fetched anyways so the query takes a lot of time till is completed.
Expected behavior
The SDK should fetched just the documents in the position and in the amount that I'm requesting not all the previous ones.
SELECT * from docs c  ORDER BY c.PostingDate_ts DESC OFFSET 2475 LIMIT 25
Screenshots

Hi,
I think you are using the SQL service (@jaredmoo ), but a few different Azure services support a SQL like syntax. Which one is this?

We are using cosmos DB @maggiepint

Exactly same problem here

@christopheranderson has more context on this behavior.

This is expected. For cross partition queries, any OFFSET happens on the client as it is not distributable operation. The SDK has no way of knowing in advance which partitions contain results matching the query (or how many). In other words, there is no way the SDK can "skip ahead" in this context. We must skip over results on the client-side.
For containers with large numbers of partitions, the browser magnifies this problem as it limits the number of parallel requests the SDK can make.
My two recommendations:

Avoid cross partition queries entirely. Your app will perform much better if you structure your data in a way that each query hits a single partition.
If you do use cross partition queries, don't use OFFSET/LIMIT for pagination. Instead, use the maxItemCount option and rely on fetchNext() on the query iterator to page through results. The query iterator will maintain the state so each subsequent call is efficiently fetching the next page.

FYI OFFSET/LIMIT scoped to a single partition key can be done efficiently as the entire query is served by a single physical partition.


Unwrap a promise with AngularJS 1.2

I have an output of the following from my Go code, using json.Marshal(myData):
{"0":"hypertension","1":"blue","Name":"hypertension","Color":"blue","route":"rest/diseases","parentResource":null,"restangularCollection":true}
This is just one record, and I want a page in AngularJS to just display the "Name" field, so I did the following in the page:

        {{disease}}

My controller is:
function SecondCtrl($scope, Restangular){
var diseases = Restangular.all('rest/diseases');
diseases.getList().then(function(dis){
        $scope.allDiseases = dis;
    })
};

My page displays the following, I'd like to know how to get just "hypertension" to display:
hypertension
blue
blue
hypertension
true
rest/diseases

Closing. Please feel free to comment with code samples and we will investigate that again.