Repository: Object Storage Shows wrong Limit when used TB

Limit is set at 10TB, look at available space but in Limit it is shown as GB:

Could you let me know which s3 storage type this is in the backend?

Sure, it is Cloudian S3.

Thanks, looks like for S3 the correct number is the one between brackets (10TB). The API returns the other number in GB hence why it states 10 GB. I'll have to do some more testing to see where the main issue resides and solve it.

It looks like this is actually a bug within the VBO API. I've asked to verify this however it would be great if you could open a support case at Veeam and have this as an extra push for the solution. For now, I've hidden this field from the portal to not cause confusion.


Search and HTML Support do not work properly

The Support example in the Demo page does not display values in the table! Besides that, something is wrong with the Html support! In its example if I set the html-content="true" on other columns page gets frozen!

Fixed with v1.5.0


Deleting namespaced deployment returns with code=None

When invoking delete_namespaced_deployment_with_http_info(), the response looks like this:
{'api_version': 'extensions/v1beta1',
 'code': None,
 'details': None,
 'kind': 'Deployment',
 'message': None,
 'metadata': {'resource_version': '6894440',
              'self_link': '/apis/extensions/v1beta1/namespaces/default/deployments/my-nginx'},
 'reason': None,
 'status': "{u'observedGeneration': 1}"}

The deployment is successfully removed from the Kubernetes cluster, but the return code is None. @flavio mentioned in flavio/salt-kubernetes-demo/issues/1 that this is due the fact that this is an async operation internally.
How should we treat those cases? Is a None return code intended here? How do we know, that the request finally succeeded?
Tested with version 1.0.2 and 2.0.0.

Okay, reading the docs actually helps. I'm closing this this issue.

delete a Deployment This method makes a synchronous HTTP request by default. To make an asynchronous HTTP request, please define a callback function to be invoked when receiving the response.

@brejoc Unfortunately a callback doesn't help you. It will get the same structure. Deleting deployment can take a lot of time (stopping and deleting all replicasets). To be sure if deployment has been deleted you have to try to get it again. If it doesn't exist you will get error - not found.

@tomplus Okay, thanks for the heads-up.

@tomplus Do you know if there is something like an event bus I'd be able to subscribe to? Thx!

@brejoc Probably you can watch the method list_namespaced_deployment. You will get the event DELETE "immediately before deletion" (https://kubernetes.io/docs/api-reference/v1.7/#watchevent-v1-meta). I've not tested it yet.

Yes watch is the way to go.  https://github.com/kubernetes-incubator/client-python/blob/master/examples/example2.py

@tomplus @mbohlool That sounds awesome. Thanks guys!


added csm_Bump with psrdnoise example for procedural bump

Added csm_Bump per suggestion in https://github.com/FarazzShaikh/THREE-CustomShaderMaterial/issues/33
A couple of notes:

Requires projection in fragment shader
Did not test for backside (it's possible the normals are flipped)
Did not test combining this with a bump map / normal map / displacement map on the three.js material
Only tested with MeshStandardMaterial & MeshPhysicalMaterial as base material
For the perturb function I just used the difference normal = normalize(normal - ${keywords.bump}); which seems the same as what three.js does for bump maps (though I'm not 100% sure)
I did a nested #if defined IS_MESHNORMALMATERIAL in shaders.ts, which feels wrong.
I did confirm that this works as expected with clearcoat, which should not be affected by bump

While I think it works, I do wonder if it would be better if these lines in the example were somehow moved to patchMaps.ts so that users don't have to worry about projection and normal calculation, though doing that would also tradeoff against flexibility.
                // N_ is orthogonal to N.
                vec3 N_ = g - (dot(g, csm_vNormal) * csm_vNormal);

                // need to do projection, and multiply by bumpStrength
                csm_Bump = mat3(csm_vModelViewMatrix) * (bumpStrength * N_);

I'd also be remiss not to mention that the technique used in the example is from @stegu and the tutorial here

Can you provide this example used on the image above ? i'm trying to make csm_Bump work and i'm not having any luck with it lol


MqttRpcClient.ExecuteRpcAsync no longer works if MqttClient already has a message receive handler

Describe the bug
After updating from 3.0.12 to 3.0.14, MqttRpcClient.ExecuteRpcAsync no longer works properly if underlying MqttClient has its own MqttApplicationMessageReceivedHandler.
RpcAwareApplicationMessageReceivedHandler looks like it was changed to return immediately after OriginalHandler instead of also calling MqttRpcClient's handler.
Which project is your bug related to?

MQTTnet.Extensions.Rpc

To Reproduce
Steps to reproduce the behavior:

Using version MQTTnet '3.0.14'
Create a MqttClient or ManagedMqttClient
Add ApplicationMessageReceivedHandler handler to the client
Create a MqttRpcClient using this same client
Run 'ExecuteRpcAsync'
MqttClient message received handler is called
MqttRpcClient message handler is skipped
ExecuteRpcAsync fails

Expected behavior

MqttRpcClient.ExecuteRpcAsync should work if using a MqttClient or ManagedMqttClient that already has its own message receive handler.
Verified that RPC_Tests only work because the MqttRpcClient is using a response MqttClient without its own ApplicationMessageReceivedHandler so they do not exercise the OriginalHandler condition.

Screenshots
Bug appears to have been introduced with this change from awaits to returns...

Proposed Fix: ExecuteRpcAsynce works properly again by simply removing the immediate return after calling OriginalHandler
.
public Task HandleApplicationMessageReceivedAsync(MqttApplicationMessageReceivedEventArgs eventArgs)
{
    if (OriginalHandler != null)
    {
        OriginalHandler.HandleApplicationMessageReceivedAsync(eventArgs);
    }

    return _handleReceivedApplicationMessageAsync(eventArgs);
}

You're right, I guess. @chkr1011 please have a look at my pull request when you have time.

In my opinion the issue is that both handlers must be called in order to work correctly. Currently only one is called and the method returns. I fixed this in master. Now both handlers are invoked properly. Please let me know if this fixes your issue.

@chkr1011 I agree that both handlers should be called in order. However, I verified that @borigas is right, and believe the RpcAwareApplicationMessageReceivedHandler should be reverted back to an async Task with awaits. It is a subtle thing depending on what your message handlers are doing, but you can verify by...
Modify the RPC_Tests ExecuteSuccess() method with this...
var requestSender = await testEnvironment.ConnectClientAsync();
requestSender.ApplicationMessageReceivedHandler = new MqttApplicationMessageReceivedHandlerDelegate(async e =>
{
    for (int i = 0; i < 10; i++)
    {
        Console.WriteLine($"OriginalHandler loop {i}");
        await Task.Delay(50).ConfigureAwait(false);
    }
});

and also modify the RpcAwareApplicationMessageReceivedHandler back to async Task...
public async Task HandleApplicationMessageReceivedAsync(MqttApplicationMessageReceivedEventArgs eventArgs)
{
    if (OriginalHandler != null)
    {
        Console.WriteLine("Calling OriginalHandler...");
        await OriginalHandler.HandleApplicationMessageReceivedAsync(eventArgs).ConfigureAwait(false);
        Console.WriteLine("OriginalHandler finished.");
    }

    Console.WriteLine("Calling Rpc handler...");
    await _handleReceivedApplicationMessageAsync(eventArgs).ConfigureAwait(false);
}

You will then get the desired behavior of executing both handlers to completion in order...

If you run this same test with PR change OriginalHandler will not run to completion before test finishes and you will get something like this...

Let me know if this is fixed as I can close my pull request as invalid then :)

In my opinion this is fixed. You can close your pull request.

I haven't had time today to pull down master and test, but I think it is now fixed. Thanks to both of you for the quick response.

Ok, thanks :)

I will close this because it is fixed in 3.0.15-rc2.


Create Package.swift

Codecov Report

Merging #692 (d7169fd) into master (4306898) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   87.05%   86.98%   -0.07%
==========================================
  Files          52       52
  Lines        5308     5288      -20
  Branches      570      566       -4
==========================================
- Hits         4621     4600      -21
  Misses        515      515
- Partials      172      173       +1

Impacted Files
Coverage Δ

...torage-file/azure/storage/file/_upload_chunking.py
56.79% <0.00%> (-1.24%)
:arrow_down:

azure-storage-queue/azure/storage/queue/models.py
91.80% <0.00%> (-0.96%)
:arrow_down:

...orage-common/azure/storage/common/storageclient.py
92.17% <0.00%> (-0.42%)
:arrow_down:

...storage-common/azure/storage/common/_connection.py
94.44% <0.00%> (-0.08%)
:arrow_down:

...storage-blob/azure/storage/blob/baseblobservice.py
91.97% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4306898...d7169fd. Read the comment docs.


Consider all texture types for resource thumbnail generation

Fixes #100180
Changes the Texture preview plugin to consider all texture types for thumbnail generation

Thanks!


Increase KLV Fill margin at end of header partition

Updates to the header metadata when completing the write was found to consume more than 256 bytes, the original margin on top of the target KLV Fill size. This caused file validation failures. This commit changes the margin to 8K.
Fixes https://github.com/bbc/bmx/issues/37

Perhaps it makes sense for @matthewmarks-bbc to review this PR too?
It would be good to test that IMF Track Files made with this update have a KLV Fill at the end of the Header Partition where the "data" of the KLV Fill item is at least 8192 bytes in length.

MXF Explorer: "Pack #15" is "Fill Item"; next Pack is "Body partition". For VIDEO_33b68ff0-b42c-400f-ba1c-5d2288bfcf05.mxf (the ABCD123E_03 Video Track File), the length of this is 8027. Same if transwrapped with existing executable.
The Baton report says "KLVFill after header partition is 7.86 KB. It should be at least 8 KB as per specification".
8027/1024 = 7.84 which tallies with this.
If created using proposed raw2bmx it is 15902; if created using proposed bmxtranswrap, it is 15940. This is 15.5 kB.
Therefore the file is now compliant.


Unhelpful info

You put a link to a page to create a system topic (Create and deploy an Event Grid system topic.)    --     Without specifying the fact that the Topic Types dropdown for it need to be ACS.. this documentation needs to be rebuilt in the same step by step way that it was in 2022. This guide is not usable in its current form.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 32511a14-1703-d823-0262-0b2037d9c8d2
Version Independent ID: 32511a14-1703-d823-0262-0b2037d9c8d2
Content: Connect using an existing Azure resource
Content Source: ce/customer-service/voice-channel-connect-existing-resource.md
Service: dynamics-365-customerservice
GitHub Login: @neeranelli
Microsoft Alias: nenellim

Thanks for your comment, @anbhar. This issue has been assigned to the doc author for review.

@anbhar ,
Thank you for bringing the gap to our notice. The content is now updated as follows in step 6. Please note that for several reasons, we don't duplicate content or document other product content that's already covered in its own product docs.

I am closing this issue as the gap has been addressed.
Thank you.


Plugin crashes when trying to do any command (fl 1.16.2, latests)

When I type just st already it crashes flow launcher with the following log:
Flow Launcher version: 1.16.2
OS Version: 18363.752
IntPtr Length: 8

x64: True

Python Path: C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe
Date: 01/09/2024 09:47:26
Exception:
Statis Exception:
Websites: https://github.com/asmpro7/StatisFlow
Author: Ahmed ElSaeed
Version: 1.1.0
Flow.Launcher.Core.ExternalPlugins.FlowPluginException: An error occurred trying to start process 'C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\pythonw.exe' with working directory 'C:\Users\xvanhunen\AppData\Roaming\FlowLauncher\Plugins\Statis-1.1.0'. Access is denied.
 ---> System.ComponentModel.Win32Exception (5): An error occurred trying to start process 'C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.3056.0_x64__qbz5n2kfra8p0\pythonw.exe' with working directory 'C:\Users\xvanhunen\AppData\Roaming\FlowLauncher\Plugins\Statis-1.1.0'. Access is denied.
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.ExecuteAsync(ProcessStartInfo startInfo, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 244
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.QueryAsync(Query query, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 311
   at Flow.Launcher.Core.Plugin.PluginManager.<>c__DisplayClass22_0.<<QueryForPluginAsync>b__0>d.MoveNext() in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\PluginManager.cs:line 194
--- End of stack trace from previous location ---
   at Flow.Launcher.Infrastructure.Stopwatch.DebugAsync(String message, Func`1 action) in C:\projects\flow-launcher\Flow.Launcher.Infrastructure\Stopwatch.cs:line 40
   at Flow.Launcher.Core.Plugin.PluginManager.QueryForPluginAsync(PluginPair pair, Query query, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\PluginManager.cs:line 216
   --- End of inner exception stack trace ---
   at Flow.Launcher.Core.Plugin.PluginManager.QueryForPluginAsync(PluginPair pair, Query query, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\PluginManager.cs:line 216
   at Flow.Launcher.ViewModel.MainViewModel.<>c__DisplayClass139_0.<<QueryResults>g__QueryTask|2>d.MoveNext() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 849
--- End of stack trace from previous location ---
   at Flow.Launcher.ViewModel.MainViewModel.QueryResults(Boolean isReQuery) in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 850
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Log file:
2024-01-09.txt

I don't see any error in the plugin from log.
try to reinstall it, if the problem still appears ask in flow launcher community.

Reinstalling sadly did not fix the issue. Ill check up on the flow launcher comunity

Related to https://github.com/Flow-Launcher/Flow.Launcher/issues/1951


bootstrap container cannot use the CA cert

bash-4.2$ ls -l
total 16
-rw-------. 1 root root    7 Feb 24 15:09 key.txt
-rw-r--r--. 1 root root  330 Feb 24 15:09 mongod.conf
-r--------. 1 root root 2021 Feb 24 15:09 tls.crt
-r--------. 1 root root 3272 Feb 24 15:09 tls.key
bash-4.2$ whoami
nobody

the tls.crt and tls.key come from the mongodb-root-ca-cert which is mounted with ownership to the root user...we don't run as root so the install initcontainer needs to change ownership so everything else can use it. Those were commented out in the operator's installconfigmap
# chown -R 999:999 /work-dir
    # chown -R 999:999 /data

Why were they commented out, can they be added back in?
@chenzhiwei

Oh, I saw this problem in a test env, but cannot recreate it in my own

fixed here: https://github.com/IBM/ibm-mongodb-operator/pull/37


SVG icon not showing

Hi, I was using the svg icon and it wasn't work.
I realised that it was simple, I changed this line
md-svg-icon="$mdSidemenuContent.svgIcon"
for this
md-svg-icon="{{$mdSidemenuContent.svgIcon}}"
But I don't know exactly how to generate a new build. I should I do?

Would be great to get this merged!


Fix angular project compilition bugs.

Add remoteServiceBaseUrl and startConnection to SignalRAspNetCoreHelper.
Modify url in SignalRAspNetCoreHelper.

Hi, thanks for your PR!
This repository uses yarn.
Can you remove package-lock.json and run the following (instead of npm install) to update yarn.lock?
$ yarn upgrade<EMAIL_ADDRESS>


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed helm dependency: common to: 1.1.9

UpdateBot commands:
updatebot push-version --kind helm common 1.1.9

UpdateBot commands:
updatebot push-version --kind helm common 1.1.10


🐛 Bug Report: missing package dependencies

Which component is this bug for?
All Packages
📜 Description
Some explicit dependencies are only available through installing test (or dev) dependencies. Here is a list I found so far with the opentelemetry-instrumentation package first and the missing dependency second:

anthropic -> anthropic
bedrock -> botocore
chromadb -> chromadb
llamaindex -> llama-index
milvus -> pymilvus
openai -> openai
pinecone -> pinecone
qdrant -> qdrant_client
transformers -> transformers

👟 Reproduction steps
Here is an example for milvus (same when installing everything via traceloop-sdk):

create a venv
pip install opentelemetry-instrumentation-milvus
start python
from opentelemetry.instrumentation.milvus import MilvusInstrumentor

👍 Expected behavior
No error
👎 Actual Behavior with Screenshots
Python 3.11.9 (main, Apr  6 2024, 17:59:24) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
from opentelemetry.instrumentation.milvus import MilvusInstrumentor
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/mnt/c/Users/tibor/VENV/venv_wsl_pymilvus/lib/python3.11/site-packages/opentelemetry/instrumentation/milvus/__init__.py", line 4, in <module>
    import pymilvus
ModuleNotFoundError: No module named 'pymilvus'

🤖 Python Version
Python 3.11.9
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hey @tibor-reiss this is on purpose. The user installs the packages it actually uses and we detect that automatically in the SDK. If we added all these dependency it will force the user to install pymilvus for example even if they don't actually use it.

That's an interesting PoV. I might be wrong, but isn't the convention to have these packages then defined as optionals/extras, i.e. install them with the square brackets?

No, because this isn't an extension to the traceloop sdk package, but rather a separate package altogether.
This is also the convention other OpenTelemetry packages are using.

Thanks @nirga for the explanation, interesting to see different approaches in the open source community.


Question for Illuminate\Database\Query\Builder

I noticed that the functionality of get and getFresh function was inverted. Is there a reason for this change that I'm missing. We are using a 3rd party connector for another database and this change is breaking our codebase.
Thanks in advance!

Please ask Taylor directly. :)

GrahamCampbell ... please provide his contact info. Will call ASAP.


Making a new contributors experience

I just want to design this repo in a new way
•Making Responsive
•Designing UI
•Will Add Theming Kit
•Layout Modification
•Custom Handling of Avtar and username
•Will Add responsiveness
•will improve performance
•will add a section to faster setting up for repos to the contributors
•will work on Typescript format

Please assign me for such

Thanks for your ideas @shubham21155102   But we really have no need for any of it at this time.   This issue will be closed.


Fix unmocking functionality on knex 0.10.0

The code as-is doesn't unmock because it is still using the old object's references. Here's my humble fix, via mocking the knex properties on the objects and making a prop-by-prop copy where needed. This is not the prettiest mocking code but it gets the job done. PR also removes the leak warnings on tests for knex 0.10.

@maxArturo thank you for your hard work, I was pretty sure I attempted this path to try and solve the issue and your correct the changes do satisfy the test.  But if you alter your test to read;
it('should revert a single adapter back to the original', function revertSingle(done) {
      db = knex({
        dialect: 'sqlite3',
        connection: {
          filename: './data.db'
        },
        useNullAsDefault: true
      });

      mod.mock(db);

      expect(db.client.driverName).to.equal('mocked');

      db.raw('select sqlite_version();')
      .then(function(result) {
        console.log(result);

        mod.unmock(db);

        expect(db.client.driverName).to.equal('sqlite3');

        return db.raw('select sqlite_version();');
      }).then(function(result) {
        console.log(result);
        process.exit();
      }).catch(function() {
        console.log(arguments);
        process.exit();
      });
    });

The output will be
undefined
{ '0': [Error: select sqlite_version(); - Error calling all on connection.] }

When it should be
undefined
[ { version: '3.9.1' } ]

With this method I was able to resolve 0.7 version but 8-11 are not fixed with this method and I spent a few hours today trying to find out why but haven't been able to pin point the cause.

Feel free to take a look at https://github.com/colonyamerican/mock-knex/tree/bug/fix-unmock I am getting closer, have everything but transactions tests working on 0.7 through 0.10, 0.11 is failing atm. I may not have time until the weekend to pick it up again but will try.

@jbrumwell I will! Thanks for the heads up. What's interesting is that the mocking is functional - it works for us in Postgres with 0.10.0 running db.raw(), so I'm curious if its not a sqlite dialect issue. I might even drop an issue in the Knex repo to see if someone there can throw us a bone.
I see you updated to es6 and newest Lab version! Nice

Now that I think of it, I had previously got stuck in my PR in transactions as well. The issue with transactions comes up when we mess with the Runner, so we can focus on that. I'll take a stab at your branch.

@maxArturo I found the bug in the transactions, it was a mismatch in the connection object. acquireConnection was using 0.7 object and ensureConnection was using 0.8-0.10

@maxArturo 0.11 was because if you give an object constructor as a property name it is converted to a function. This was causing my spec's to fail on the replacement side. I have got all tests passing throughout the suite now.  If you have time to test with your setup that would be great, currently located under branch release/0.3.3

@maxArturo Thank you very much for the PR it put me on the track for the final solution and I used your code as a template for the final solution. I appreciate your help and contribution :+1:

Glad you found the issues! Also appreciate you help with the code. I'll give it a go and get back with the results.

Released 0.3.3 :)


Define F operator for Qudit and Boson

Description
Responding to this forum post, this PR defines the "F" operator for the "Boson" and "Qudit" site types by defining it just for "Qudit".
I explored getting the "Qudit" site type to use the "Generic" fallback approach, but it was fairly complicated to do without changing a lot of the pattern that "Qudit" currently uses. Currently, we aren't using "Generic" for many things anyway and might want to do away with it in the future since it's something of a 'magical' feature (though there's something also to be said for "Id" to be defined for any new site type).
How Has This Been Tested?
Added a new test to phys_site_types.jl
Checklist:

[X] My code follows the style guidelines of this project. Please run using JuliaFormatter; format(".") in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have added tests that verify the behavior of the changes I made.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] Any dependent changes have been merged and published in downstream modules.

Codecov Report

Merging #977 (379559c) into main (400a794) will decrease coverage by 0.12%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   66.54%   66.41%   -0.13%
==========================================
  Files          91       91
  Lines        9921     9922       +1
==========================================
- Hits         6602     6590      -12
- Misses       3319     3332      +13

Impacted Files
Coverage Δ

src/physics/site_types/qubit.jl
58.74% <0.00%> (-0.42%)
:arrow_down:

src/physics/site_types/qudit.jl
81.13% <100.00%> (+0.36%)
:arrow_up:

src/ITensorChainRules/ITensorChainRules.jl
84.61% <0.00%> (-7.70%)
:arrow_down:

src/physics/lattices.jl
95.65% <0.00%> (-2.18%)
:arrow_down:

src/mps/sweeps.jl
90.69% <0.00%> (-1.17%)
:arrow_down:

src/tagset.jl
86.95% <0.00%> (-1.09%)
:arrow_down:

src/ITensorChainRules/mps/abstractmps.jl
88.17% <0.00%> (-1.08%)
:arrow_down:

src/qn/qn.jl
88.51% <0.00%> (-0.86%)
:arrow_down:

src/LazyApply/LazyApply.jl
80.10% <0.00%> (-0.52%)
:arrow_down:

src/physics/sitetype.jl
90.78% <0.00%> (-0.44%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


increase default threading cutoff

With OPENBLAS_NUM_THREADS=1:
julia> a=rand(10,10); @time for i=1:100000; a*a; end
elapsed time: 0.11344099044799805 seconds
With OPENBLAS_NUM_THREADS=2:
julia> a=rand(10,10); @time for i=1:100000; a*a; end
elapsed time: 0.23067402839660645 seconds
This is openblas v0.1.1 on a core i5 650. There seems to be a slowdown for small matrices with threads enabled. In the same setup I see nice speedups for big matrices, e.g. over 100x100.
Can anything be done about this? Setting OPENBLAS_NUM_THREADS is easy, but we'd rather get the best of both worlds if possible :)

In Julia, we have been using 50 as the threshold which works well. Given that there is a way to address this in the build system, this could be closed.

I find it worrying that your threshold of 50 is so far from the current default, and if anything the threading behaviour has become more complicated with individual magic numbers used as threshold
values in specific BLAS functions. So I am hesitating to close this - at the very least, the description
of this parameter in Makefile.rule should be amended to make it clear that the sane range of values
extends to (or it seems some may think, begins around) 50.
On reviewing this thread, there was also a comment by jiahao https://github.com/xianyi/OpenBLAS/issues/103#issuecomment-38914601 about improvements seen with choosing a different OpenMP loop scheduler in blas_server_omp, which sadly elicited no response. Thoughts ?

I'm not familiar with the openmp work, but one issue is that openmp is not available on all the platforms/OS combinations.

one issue is that openmp is not available on all the platforms

I am certainly aware of that. I see OpenMP in this context as a subtopic that got buried quickly the first time it came up, and I would like to get some comment on it before it gets buried again. A speed gain
from switching away from the "static" scheduler would appear to suggest an unbalanced workload where some threads take longer than others  ?(Though the example given in https://github.com/JuliaLang/julia/issues/3239#issuecomment-38355077 was a bit vague in that it picked the auto scheduler without determining what the compiler chose).

My own experiments with the OMP scheduler were a bit inconclusive - which scheduler works best seems to depend very much on the functions and workload, so #1620 makes the choice available at
build time (or by picking the runtime scheduler, even at runtime through setting OMP_SCHEDULE).
I have also documented the changed meaning of GEMM_MULTITHREAD_THRESHOLD and Julia*s
use of the value 50 there.

Wouldn't it make sense to increase the default value of GEMM_MULTITHREAD_THRESHOLD? Given how far it is from Julia's choice, either OpenBLAS or Julia use a bad value.

So far there does not appear to be consensus on what the good value is. The last time the threshold was changed, it was reverted quickly (#216), though inconsistent use of the variable in GEMM vs GEMV may have been an issue back then. With new contributors taking a fresh look on the threading behaviour of OpenBLAS now I hope this will eventually be resolved.


Change strfmt.DateTime and strfmt.Date types to alias

Make consistent to strfmt.Duration type.
Closes #205.
Signed-off-by: Aleksandr Vinokurov<EMAIL_ADDRESS>

This pull request is now managed with CodeReviewHub. Refresh.

After adding missed fixes to tests, all seems to be ok

:shipit:


add cargo lock lint ci to mergify rule

This PR adds cargo-lock CI to mergify rule. Mergify bot will not merge PRs if they don't pass cargo-lock test or are stale

test

test


Fix rebase command args

Codecov Report

Merging #1196 (7392162) into main (d6dcb05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1196   +/-   ##
=======================================
  Coverage   67.58%   67.58%
=======================================
  Files         132      132
  Lines        7999     7999
=======================================
  Hits         5406     5406
  Misses       2164     2164
  Partials      429      429

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Notes

Hello,
I would like to know if this package is good to make it work with the Notes ios application ?
i.e. : When a user share a notes, my app would show up in the share list. If the user select it, the content of the Notes (pure text I guess) is sent to my app.
Is this supported ?

@Rictus  Yes it is Supported for text sharing


Use git sub-modules for external dependencies as much as possible

Are you talking about the proposal to use git sub-modules for external dependencies too?   Rather than WGETs of random ZIPs?   @anthony-cros

yes, exactly, to avoid (hopefully) the kind of issues we've had with MPFR and CRYPTOPP binaries! hopefully they all use a github or similar

Right, so in "best" to "OK" order, we would ...

Just use sub-module for the release branch in an existing github repo which is exactly the same as the ZIPs, if such exists.
Or some of them have mirrors which somebody has made other than the team themselves.   If those have the same content then we would go with that instead.    We're not guaranteed them will be maintained to the same degree, and they may become a burden in the future, but it saves us some work for now.
Worst-case we just un-ZIP the versions we need into our own doublethinkco/ and reference those as sub-modules.

yes, though from what i've seen most seemed to meet (1)! cryptopp might not, but it won't be around much much longer i think

See #46 and #47.

Covered just fine with #46 and #47.   Deleting this which is now just a dupe.


Setting Connect automatically to console removes this setting for other user

When I log as other user and set Connect automatically by Console, it removes this setting for previous user I logged in and set it.
See video
connect_automatically.zip
Tested in ovirt-web-ui-1.4.0-3.fc28.noarch, with ovirt-engine-<IP_ADDRESS>-0.1.el7ev.noarch

Old detail page no longer exists. Bug will be fixed in https://github.com/oVirt/ovirt-web-ui/pull/1088

This isn't reproduced anymore with new connect automatically implementation for user settings: https://github.com/oVirt/ovirt-web-ui/issues/1459 and therefore I'm closing this issue as Done


Submitting an empty search should take me to the beginning of the index

User story
As a user who is new to this application, when I first go to the front page, I see a "Go" Button. I push it and get an error. I'd rather see something meaningful, like the beginning of the card index. Anything but an error.
Acceptance criteria

[ ] If I submit an empty search, it is the same as if I submitted a "*" in the search box

Concrete example
Implementation notes, if any

Closed by #196


Repo sync for protected CLA branch

The pull request is created from main638072643431438978sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 4abf772:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


unable to reproduce repllama performance

Hello, thanks for sharing great work!
I tried trying repllama myself with the repllama branch but failed to reproduce the numbers.
Could you check whether any of my hyperparameters are wrong? I add the training script underneath
I am currently running on 8 A100 and the result I got is NDCG@10: 0.3959, NDCG@100: 0.4515
When I download the released model from hf I get the number in the paper, which I assume the issue is from the training not evaluation.

Notice that the training data Tevatron/msmarco-passage-aug is the data used to train repllama

Hi,
Thank you for the reply!
I tried training myself with the script but still had trouble with the reproduction.
I am currently training on top of 8 A100 80G so I changed the per_device_train_batch_size and gradient_accumulation_steps for faster training. Would this cause a problem? I considered # of GPU * per_device_train_batch_size * gradient_accumulation_steps to be the same as the reported number 128.

If i remember correctly, @ArvinZhuang previously found finetune with 128 batch size directly may has some unstable loss and may need further tuning the temperature.
@ArvinZhuang  correct me if I am wrong.

You're using a LlamaTokenizerFast tokenizer. Please note that with a fast tokenizer, using the __call__ method is faster than using a method to encode the text followed by a call to the pad method to get a padded encoding.
use_cache=True is incompatible with gradient checkpointing. Setting use_cache=False.
0%|                                                                                | 1/4162 [00:42<48:50:25, 42.26s/it]06/18/2024 18:13:42 - INFO - tevatron.retriever.trainer -   Saving model checkpoint to retriever-mistral/checkpoint-1
stage3_gather_16bit_weights_on_model_save=false. Saving the full checkpoint instead, use zero_to_fp32.py to recover weights
06/18/2024 18:13:42 - INFO - tevatron.retriever.trainer -   Saving model checkpoint to retriever-mistral/checkpoint-1
Traceback (most recent call last):
File "/tmp/.local/lib/python3.10/site-packages/transformers/trainer.py", line 3342, in save_model
self._save(output_dir, state_dict=state_dict)
File "/tmp/.local/lib/python3.10/site-packages/tevatron/retriever/trainer.py", line 31, in _save
raise ValueError(f"Unsupported model class {self.model}")
ValueError: Unsupported model class DenseModel(
(encoder): PeftModelForFeatureExtraction(
(base_model): LoraModel(
(model): LlamaModel(
(embed_tokens): Embedding(32000, 4096)
(layers): ModuleList(
(0-31): 32 x LlamaDecoderLayer(
(self_attn): LlamaSdpaAttention(
(q_proj): lora.Linear(
(base_layer): Linear(in_features=4096, out_features=4096, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=4096, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=4096, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(k_proj): lora.Linear(
(base_layer): Linear(in_features=4096, out_features=4096, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=4096, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=4096, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(v_proj): lora.Linear(
(base_layer): Linear(in_features=4096, out_features=4096, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=4096, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=4096, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(o_proj): lora.Linear(
(base_layer): Linear(in_features=4096, out_features=4096, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=4096, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=4096, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(rotary_emb): LlamaRotaryEmbedding()
)
(mlp): LlamaMLP(
(gate_proj): lora.Linear(
(base_layer): Linear(in_features=4096, out_features=11008, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=4096, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=11008, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(up_proj): lora.Linear(
(base_layer): Linear(in_features=4096, out_features=11008, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=4096, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=11008, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(down_proj): lora.Linear(
(base_layer): Linear(in_features=11008, out_features=4096, bias=False)
(lora_dropout): ModuleDict(
(default): Dropout(p=0.1, inplace=False)
)
(lora_A): ModuleDict(
(default): Linear(in_features=11008, out_features=8, bias=False)
)
(lora_B): ModuleDict(
(default): Linear(in_features=8, out_features=4096, bias=False)
)
(lora_embedding_A): ParameterDict()
(lora_embedding_B): ParameterDict()
)
(act_fn): SiLU()
)
(input_layernorm): LlamaRMSNorm()
(post_attention_layernorm): LlamaRMSNorm()
)
)
(norm): LlamaRMSNorm()
)
)
)
(cross_entropy): CrossEntropyLoss()
)
During handling of the above exception, another exception occurred:

Hi, is your DenseModel a class of  DenseModel(EncoderModel):? The save only support tevatron EncoderModel here, if the DenseModel is your own implemented model then you may need to add into the supported model list.

what is mean by train group size and how it important

@MXueguang I also had a similar experience with failing to reproduce using that script.  Using your suggested config above I get the 72.95 nDCG for DL19 and 70.6 nDCG@10 for DL20 (compared to the paper's 74.3 and 72.1).
Are you able to reproduce it with that code or did the recent updates to tevatron change some parameter that lowers performance?  If I wanted to exactly reproduce, do you have the command that works with the November codebase?

hi @orionw, which base llm were you using? llama2?

Yes, llama2

do you have msmarco dev set results of the ckpt you get, does it matches?

I didn't evaluate dev, I stopped at these two for compute reasons.

I see. I'll schedule a training to see how it goes on my end...

Thanks for looking into it!

one difference I observed is the lora_r parameters, it was set to 32 in original experiment, now the default one is 8. I am seeing  if this would affect trec dl results.

Hmm, could be @MXueguang! Let me know if that fixes it!
I was curious about potential discrepancies with the number of GPUs/batch size? I don't know the exact command you used, but your paper said it was trained with 16 V100 GPUs. Perhaps having the batches distributed larger makes it better (like @ArvinZhuang was saying).
Could also be related to the cross device negatives/group size (did that logic change in the recent version?).  I unfortunately don't have access to a node with 16 GPUs to test it out on.

yeah @orionw , I. am running it, but still need a day or so to get a number due to limited compute...
In the original 16 V100 GPUs, --per_device_train_batch_size is set to 2. so the setting regarding batch size should be equivalent here, and so does the cross device negatives.

Hi @orionw, my reproduce with lora_r=32, others keeps same, gives:
dev mrr@10: 41.6
dl19 ndcg@10: 74.6
dl20 ndcg@10: 71.4
dev/dl19 a bit higher and dl20 a bit lower than original experiments.

Awesome, thank you so much @MXueguang! Those differences could easily be due to random seeds. Really appreciate you looking into it :)


Update machine-translation-services-in-sharepoint.md

Category

[X] Content fix
[ ] New article

Machine translation services and the API are approaching the end of service by July 2022. Added a note that provides more detail and how to create multilingual sites/pages.

Docs Build status updates of commit 97b457e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/machine-translation-services-in-sharepoint.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 06d58f4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/machine-translation-services-in-sharepoint.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


refactor: Separating production dependencies from testing.

Separating production dependencies from testing.
BOM-2478

@awais786 This was billed as separating out the testing dependencies, but for Python now only the production dependencies are included in the dashboard.  Could you please add the rest of the dependencies back, either as a separate field or where they originally were?


[8.1.x] Fractal transformer includes not working

Summary of problem or feature request
Response does not include child items when use fractal transformer.
Code snippet of problem
        return DataTables::eloquent($shop->orders()->with(['items', 'shipping', 'billing']))
            ->setTransformer(new OrderTransformer)
            ->toJson();

class OrderTransformer extends TransformerAbstract {

    protected $availableIncludes = ['billing'];

    public function transform(Order $order) { }
    public function includeBilling(Order $order) { return ... }

System details

Operating System: Windows 10
PHP Version: 7.1.7
Laravel Version: 5.4
Laravel-Datatables Version: 8.1.1 (master)

If I recall this correctly, you should use include key on your request params.
laravel.dev/url?include=billing

Or I think you should use $defaultIncludes if you want it added by default. Check with fractal official docs.


exp run: internal data committing performance implications

Per https://github.com/iterative/dvc/pull/5859 (released in 2.1.0)
UPDATE: Jump to https://github.com/iterative/dvc.org/issues/2418#issuecomment-854183969

Data dependencies are now dvc commited internally when stashing an experiment so that any modifications to that data dep are preserved in both workspace and tempdir runs (previously the changes were dropped entirely by the exp run dvc checkout step).

Implications to consider documenting:

Mention the git stash "trick" somewhere
large changes to data dependencies in the workspace may slow down experiment queueing
Even if the run fails after this step, the new cached entries will remain, and metafiles will point to them (seen as Git changes)

Cc @pmrowla (forgot to tag you originally it seems). Thanks

Cc @dberenbaum do you think we should document any of this? Thanks

It would be nice to document how data dependencies are handled, but only if we have a document that goes in-depth about the experiments implementation. I don't see a good place for it today. Since it is now pretty consistent with dvc repro behavior, I don't think it's that important to document it unless/until we see that it becomes an issue.

I guess the title of this issue was misleading. I improved it now. This is in general about the whole staging->committing mechanism for tmp/queued experiments. It's not documented at all. The change in question (https://github.com/iterative/dvc/pull/5859) just reminded me of the feature? as a whole.
I think it should be added to https://dvc.org/doc/command-reference/exp/run#queueing-and-parallel-execution and maybe as an example too.

It seems like this comes down to the discussion of how much we want to expose the implementation details. With the changes in #5859, it seems like the behavior is consistent across temp and workspace runs with the exception of gitignored files (is that a separate issue?), and it's also consistent with dvc repro.
We also already have How are experiments queued there, so I'm not sure how much further we need to go. Are there particular concerns that you worry users might have?
I'm not against including it, but it doesn't seem high priority to me since I haven't heard much related feedback from users on it.

Maybe I'm confused about https://github.com/iterative/dvc/pull/5859 due to the language there "commited internally when stashing an experiment". Only tmp/queued exps are stashed internally right @pmrowla ? The original issue (https://github.com/iterative/dvc/issues/5593 point 2) had nothing to do with tmp/queued exps actually.

p.s. so yeah if https://github.com/iterative/dvc/pull/5859 just addresses iterative/dvc#5593 point 2 then the only thing to doc for that would be "that large changes to data dependencies in the workspace may slow down experiment queueing" per https://github.com/iterative/dvc/pull/5859#issuecomment-824952003 — which is why this issue exists in the first place 😬
The staging->stashing mechanics are a separate question, sorry for the confusion!

p.p.s. on

the whole staging->committing mechanism for tmp/queued experiments. It's not documented at all.
with the exception of gitignored files (is that a separate issue?)

Actually it was documented already by https://github.com/iterative/dvc.org/pull/2398 😅

large changes to data dependencies in the workspace may slow down experiment queueing

Update: the deeper info on queued exps in now in https://dvc.org/doc/user-guide/experiment-management/running-experiments#the-experiments-queue. Do we still want to add this note? In hindsight I feel like it should be intuitive (as long as we're explaining how experiments work correctly). WDYT @dberenbaum, close this?

feel like it should be intuitive

Wait why does this apply especially to queued exps and not all exps again? This isn't clear.

This affects all experiments, I'm not sure where the queue specific idea came from. One-off workspace or --temp runs are still queued internally, but they just get popped from the queue and run immediately afterwards.

Right, it's not about the queue, it's about clarifying that any "dirty" data in the workspace will be cached at the start of exp run. I think this is probably worth mentioning somewhere if it's not already.

It's about clarifying that any "dirty" data in the workspace will be (committed and) cached at the start of exp run. I think this is probably worth mentioning somewhere if it's not already.

It's about clarifying that any "dirty" data in the workspace will be (committed and) cached at the start of exp run. I think this is probably worth mentioning somewhere if it's not already.

The most obvious place is in https://dvc.org/doc/command-reference/exp/run since it currently does not go into execution details, deferring to the repro ref. for that. Do you guys want to take care of that update since it's the cmd ref?
If I find other places to mention this I'll make a quick PR.

UPDATE: Never mind, I added the note myself in #3271 since it's the same as the change I was doing for the guide anyway. Will just need your review and perhaps discussing other related questions there... Thanks

Mention the git stash "trick" somewhere

This seems like a separate issue. No strong opinion.

large changes to data dependencies in the workspace may slow down experiment queueing

True, but why is it slower than dvc repro? Both commands save the dependencies to the cache. AFAIK, the additional step is having to checkout that data into a temp directory. Can't remember if there is a checkout step in workspace runs.

Even if the run fails after this step, the new cached entries will remain, and metafiles will point to them (seen as Git changes)

This is also true for repro.

Mention the git stash "trick" somewhere

Oh that's already somewhere in there. I think in a hidden section.

is it slower than dvc repro? Both commands save the dependencies to the cache

Wait so repro behaves the same? I thought this was exp run-specific per https://github.com/iterative/dvc/pull/5859 ... Back to confusion state 😖

the additional step is having to checkout that data into a temp directory. Can't remember if there is a checkout step in workspace runs.

Let's discuss in #3271?


System containers don't show up if no hosts

Rancher Versions: 5/4
Steps to Reproduce:

Create a environment without hosts
Go to container page and check Show System

Results: The system containers do not show up.

That's because you don't have any hosts to have system containers on!
You need a minimum of one rancher host to have any system containers to show up.
So maybe what you are after is a UI element that says: oh no! No hosts have been set up! Set one up? <link to set up rancher host>


!stockpile user story

!STOCKPLIE USER STORY
User types in !stockpile
Bot replies:
Sharing is caring.
Stockpile
Stone [amount]
Sticks [amount]
Wood [amount]
Fiber [amount]
Coal [amount]
Mussels [amount]
Honey [amount]
Berries [amount]
Mushrooms [amount]
Fish [amount]
Meat [amount]
Bones [amount]
Feathers [amount]
Leather [amount]
Fur [amount]
Blood [amount]
Rope [amount]
Spear [amount]
Bow + Arrows [amount]
Armor [amount]
Advance Armor [amount]

If we want any emoji fanciness or anything like that we'll need to spell that out here.

K. I'll do some emoji digging on discord and see what I can figure out.


Support for envbc

In SearchGuard it is possible to use ${envbc.<ENV_VAR>} to get an bcrypt hash from an environment variable. This should be also possible for opendistro!

/close
It's supported in 0.9.1 as it seems


Expose the temperature sensors on the echo to HA

It would be very useful if this could expose the temperature sensor from the supported echo speakers.
The temperature data is located under Devices: Echo and Elexa: Your echo speaker: Device settings: Temperature Sensor. This does not seem to be very challenging to implement, and could be great for creating automations.

Please search.


Use uploadUrl for token upload flow

Fixes
https://issues.redhat.com/browse/HAC-2209

Description
Use uploadUrl for token upload flow instead of using a hardcoded URL.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
(No UI changes)
https://user-images.githubusercontent.com/20013884/192510486-66c34ece-feb5-4438-b596-6a1bba6fd390.mp4

How to test or reproduce?
Use token upload flow.

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/retest

/uncc

/retest


If namespace hasn't been used in the subscription bash install fails

During bash install deployFhirBulk.bash if a namespace hasn't been used (my ex. Microsoft.EventGrid), install will fail. Thankfully the failure message references the error message and a quick Google search will tell you how to register the unregistered namespace. But it would be nice if the installer handled this.

Hi @TerriblyVexed, thanks for your feedback. Are you able to provide repro steps and what the error message was? Thanks!


chore: Update About The App section and rename it to 'About Us'

Fixes #1903
GIF for the change:

What's the increase in app size
Everything is hardcoded. It should be configurable

Everything is hardcoded. It should be configurable

Configurable from where?

Package name can be queried programmatically. App name as well. Whatever cannot be coded should be configurable from build.gradle

Okay

What's the increase in app size

No increase.


Get support for EIP-712 across all connectors

Here are the connectors that does not support EIP-712, or does not support array type
Does not support typed data

Trezor https://github.com/trezor/trezor-firmware/issues/1272
Gnosis Safe https://github.com/gnosis/safe-apps-sdk/issues/204

Does not support typed data array type

WalletConnect https://github.com/WalletConnect/walletconnect-monorepo/issues/546
Portis https://github.com/portis-project/web-sdk/issues/140

Brave

Coinbase wallet typed data with array seem to work now, updated on Snapshot to default to typed data https://github.com/snapshot-labs/snapshot/commit/525748fcbbed24274e9128e35e62cd522ab4d2ea

Coinbase wallet typed data with array seem to work now, updated on Snapshot to default to typed data 525748f, Portis and WalletConnect with Argent is still not working for me with array typed data.

@bonustrack I can not vote with Coinbase wallet anymore after your change. I have the latest version of Coinbase wallet installed and I'm on snapshot 0.1.4#db6121e version.

No

That's super weird, I can reproduce the same issue now, while I'm sure it was working before, I can see my vote here with my Coinbase wallet address:
https://snapshot.org/#/fabien.eth/proposal/0x670f328d7cda120e9056ab19836592878fbc36fd0c3504ec9eebeeb9f780e691
https://cloudflare-ipfs.com/ipfs/QmZUYAfzZxKoeaAebvQRF3fcZcaVXZEwLrHHHAyJw2aU3t

btw, Trezor added support for EIP-712. Now the only missing piece is Metamask support for it: https://github.com/MetaMask/eth-trezor-keyring/pull/117

Took Inventory of what's missing and working
By v3 I just refer to typed data working.
Typed array support was included in v4.
Walletconnect
Trust - v4 Works
Rainbow - v4 Works
Metamask - v3 works, v4 Stuck After Signing in metamask
Argent - v3 and v4 gives wrong signature error
Gnosis - v3 and v4 does not working
Gnosis Safe App - v3 and v4 does not work
Trezor with Metamask - TBD
Coinbase - TBD
Portis - v3 works, v4 gives error

Remove fortmatic from UI
Update Code to use EIP712 for coinbase.

Not working right now
Gnosis
WalletConnect (Metamask)
Coinbase Wallet

WalletConnect PR was merged and released https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/1.8.0

Only missing Coinbase wallet and Gnosis safe
https://github.com/coinbase/coinbase-wallet-sdk/issues/508
https://github.com/safe-global/safe-react/issues/4027#issuecomment-1202622001

Waiting for https://github.com/safe-global/safe-apps-sdk/issues/363


Android developer associate

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7b965be6-8dfd-db91-84e3-345e70d7c302
Version Independent ID: 291bf1e4-c8f7-12e9-3f38-f54bbd822bc7
Content: Create an Android Native Activity App
Content Source: docs/cross-platform/create-an-android-native-activity-app.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

Never let this github away from me, please all of you.

@Nachiketa-Sharma, I'm closing your issue because it has no actionable content. If you have a documentation issue to report, please create it from the relevant page in the feedback section. Thanks!


FAQ: Running Flutter app on a Chromebook

We'd like to explicitly state if this is known to work, or not, and if we support it, or not.

It is known not to work.

Noteably https://github.com/flutter/flutter/issues/9695

Chrome OS systems supporting Android Apps: https://sites.google.com/a/chromium.org/dev/chromium-os/chrome-os-systems-supporting-android-apps

Did anyone test with the Samsung Chromebook Plus http://www.samsung.com/us/computing/chromebooks/12-14/xe513c24-k01us-xe513c24-k01us/?

Yes, and it works. https://github.com/flutter/flutter/issues/9695 is closed.
We are currently tracking open issues with it at https://github.com/flutter/flutter/labels/platform-arc

Addressed by https://github.com/flutter/website/pull/750


Incorrect support for @description decorator on keyword var

Bicep version
Bicep CLI version 0.9.1 (a2950a16df)
Describe the bug
The decorator @description() is currently supported on the keyword var, it does not generate any warnings or errors but the description is not part of the compiled ARM template.
To Reproduce
Steps to reproduce the behavior:
The following bicep code will build successfully without errors or warnings:
@description('myVarDescription')
var descriptionVar = 'varHasDescription'

output varValue string = descriptionVar

The resulting ARM template does not contain the description myVarDescription
Additional context
Can we add a FunctionFlag for SupportsDescriptionDecorator or something similar?
This would also apply for the keyword metadata and possibly import

Variables do not support description in ARM Templates, so this is by design. It still provides functionality (i.e. hovers) in bicep, so that's why it works and is allowed. If we feel it's critical, we can prioritize adding support for description in ARM templates.


also associate each target with the xcodeproj as a whole

That way, we can dedupe pods that are used in both the test targets and the app targets of the same project, if we want to

I do that :D
So you're right.


Model weights?

Hi, congratulations on the excellent work!  Where can be accessed the weights of the models presented in the results table?

Thanks. I will re-train some models and release them recently.

Excellent! Thank you. I'll stay tuned.

I have released several models. Please check README for more details.


⚠ Bofrost.be has degraded performance

In 1df7a89, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1763 ms

Resolved: Bofrost.be performance has improved in ca2cb90.


Backpropagation test fails on rare occasions

Test suite assertion fails on rare occasions.
1) tests\Phpml\NeuralNetwork\Training\BackpropagationTest::testBackpropagationForXORLearning
Failed asserting that 0.4491036029661862 matches expected 0.

Simple script to test after how many tries it fails (random):
#!/bin/bash

COUNT=1

while true
do
    bin/phpunit tests/Phpml/NeuralNetwork/Training/BackpropagationTest.php > /dev/null
    if [ $? == 1 ]; then
        echo "Test failed after $COUNT tries"
        break
    fi

    ((++COUNT))
done

Fixed with #89. Thanks @dmonllao :+1:

Problem still exist in:
There was 1 failure:

1) tests\Phpml\Classification\MLPClassifierTest::testBackpropagationLearningMultilayer
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'a'
+'b'

The problem seems different though, this one is narrowed to multilayer neural nets.

In any case I agree we need to narrow the backpropagation issue

Thanks again for @dmonllao :rocket: :+1:


ARROW-4365: [Rust] [Parquet] Implement arrow record reader.

RecordReader reads logical records into memory, this is the prerequisite for ColumnReader.

@sunchao @nevi-me @andygrove Please help to review this.

Also we should change the title of this PR: Implement Arrow record reader.

@sunchao Thanks for the review. Yes you are right, this is heavily inspired by c++ implementation. Currently c++ implementation can handle List<List<List> type, I'll extend this to handle more cases. Also I took a look at triple.rs. Though it's similar to record reader, they serve different purposes. The main goal of record reader is to help arrow array reader to find the boundaries of nested records and buffer them, while triple.rs is much simpler.

@liurenjie1024 Ouch.
The list collection is actually done in reader.rs. triplet.rs's goal is producing triplets of spaced values, accounting for definition levels. I am not familiar with arrow reader. Can c++ code handle List<List<List<List<List<...>>>>? It should not matter how many nested levels it has, the algorithm should just work (which might suggest that c++ code might be missing something).
I looked at the code, could you add more documentation around it, otherwise it is quite difficult to understand what is going on? Also would be good to add more tests around different complex schemas including deeply nested nullable lists and maps.
Thanks!

@sadikovi
Currently c++ code can handle any nested level of list, I just didn't express it clearly.
Just took a look at reader.rs. What record_reader.rs does for arrow_reader(which I'll send a PR later after this) is similar to what triplet.rs does for reader.rs. Seems like this name record_reader is misleading, it should be called something like record_splitter.
In fact I have tests for nullable lists, but not maps because currently arrow rust implementation doesn't support map. More nested lists may not help because the main logic is of splitting records are the same.

@sunchao @sadikovi The following code is from primitive array reader (WIP: read parquet column into arrow primitive array), it demonstrates usage of record reader.
impl<T: DataType> ArrayReader for PrimitiveArrayReader<T> {
    fn next_batch(&mut self, batch_size: usize) -> Result<Arc<Array>> {
        self.record_reader.reset()?;

        let mut records_read = 0usize;
        while records_read < batch_size {
            let records_to_read = batch_size - records_read;

            let records_read_once = self.record_reader.read_records(records_to_read)?;
            records_read = records_read + records_read_once;

            // Record reader exhausted
            if records_read_once < records_to_read {
                if let Some(page_reader) = self.pages.next() {
                    // Read from new page reader
                    self.record_reader.set_page_reader(page_reader?)?;
                } else {
                    // Page reader also exhausted
                    break;
                }
            }
        }

       // Convert buffer data in record_reader to array
       let record_data = self.record_reader.consume_record_data();
       let null_bitmap = self.consume_bitmap();
       .....
    }
}

Sorry for late review @liurenjie1024 !. I'll take another thorough look on this in the weekend.

@sunchao  Thanks for the review.
It seems that it's a little difficult to understand how this works without a full picture of the implementation. I'll submit a PR for initial version of arrow reader later.

@sunchao @sadikovi
I've completed most part of arrow reader and code is here: https://github.com/liurenjie1024/arrow/tree/arrow-4059/rust/parquet/src/arrow
Hope it will help reviewers to understand what record_reader.rs is doing.
I don't submit the whole reader in a huge PR because I think small PRs is more friendly for reviewing, so please take a look at this.

Nice @liurenjie1024 ! will take a look at this.

Codecov Report

Merging #4292 into master will increase coverage by 10.16%.
The diff coverage is 91.51%.

@@             Coverage Diff             @@
##           master    #4292       +/-   ##
===========================================
+ Coverage   72.26%   82.43%   +10.16%
===========================================
  Files         822       87      -735
  Lines      107713    24701    -83012
  Branches     1418        0     -1418
===========================================
- Hits        77844    20362    -57482
+ Misses      29507     4339    -25168
+ Partials      362        0      -362

Impacted Files
Coverage Δ

rust/parquet/src/arrow/record_reader.rs
91.51% <91.51%> (ø)

rust/parquet/src/encodings/encoding.rs
92.4% <0%> (-0.18%)
:arrow_down:

python/pyarrow/ipc.pxi

cpp/src/parquet/column_page.h

cpp/src/arrow/array/builder_decimal.cc

r/src/symbols.cpp

cpp/src/arrow/ipc/metadata-internal.h

cpp/src/arrow/python/io.cc

python/pyarrow/hdfs.py

cpp/src/parquet/column_scanner.cc

... and 730 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffb9cd...ee1ea5d. Read the comment docs.

@liurenjie1024 thanks again for the POC (sorry for being late as I was on vacation). I think I have a much better understanding on this now. Could you address the comments I had and update this PR?

@sunchao Sure, will fix it soon

@sunchao Fixed comments. Please take a look when you got a chance.

@sunchao  Thanks for the review. Fixed comments. Will take a look at the ci error later.

Thanks @liurenjie1024 . The PR looks good to me except one minor thing: can you rename records_num to num_records in the RecordReader struct? After the CI issue is resolved I think the PR can be merged.

@sunchao CI passed. I think the c++ build failure is unrelated.


Mac Support

Description of the new feature / enhancement
It would be great if we have this product available for Mac
Scenario when this would be used?
Daily use case
Supporting information
No response

PowerToys is too tightly coupled to the Windows OS APIs to port to MacOS.


Some tweaks to the API

Add a missing timestamp field - response_threshold_reached_at
Add caching to the show page
Add JSON templates for archived petitions

Nice to see archived petitions coming in as well. Merging


Add trace

Traces! /c @brynary

ping @brynary

Clarify default for stacktrace is false and then we can merge


squid:S1943 - Classes and methods that rely on the default system enc…

This pull request is focused on resolving occurrences of Sonar rule squid:S1943 - Classes and methods that rely on the default system encoding should not be used
You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1943
Please let me know if you have any questions.
M-Ezzat

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

Sorry, I've had no time to look at it.
/Pelle
On Tuesday, June 28, 2016, Mohamed Ezzat<EMAIL_ADDRESS>wrote:

I am not sure whether you do not agree with these changes or not. Please
close this PR if not.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/klarna/HiveRunner/pull/42#issuecomment-228946826, or mute
the thread
https://github.com/notifications/unsubscribe/AFtvJwIJ9CTmijDWXaWQsoYnp8oA1N1Sks5qQKZ0gaJpZM4Ixod0
.

Merged


Handle wallet version and network incompatibility

Story
As a user
I want to understand if / when my desktop wallet version is not supported by the network I am connecting to and what I can do about it
So that I can connect successfully
(There will be a brief period of time where Fairground and Mainnet networks are compatible with different versions of the desktop wallet app.)
Acceptance Criteria

[ ] When the network version is newer than the wallet: If I'm using a wallet app version that is not compatible with the network I have connected to (determined by the network configuration and nodes) - I am informed that I need to change version of the desktop wallet app e.g. Mainnet is running Vega version 1.32 - this app is running an older version 1.31 and no longer compatible. [Download Desktop Wallet version 3]
[ ] When the wallet version is newer than the network the user is prompted to import a new network configuration. "The network you are using is outdated, import the new network configuration here (link to network settings screen in app)

Tasks

[x] Catch up with Valentin to figure out how we can tell if an imported network is compatible with the desktop wallet version
[x] Consider what is shown on the dapp (connect wallet UI for example), what is shown in the wallet app itself and supporting information on the website and docs
[ ] Enable backend to share version compatibility + which version will work for each desktop release
[x] Sketch copy / interaction
[ ] Team and stakeholder review
[ ] Visual Design (if needed)
[ ] Develop
[ ] Review
[ ] Test

Sketch

Wallet version in desktop wallet app
When creating a wallet there is a field "Wallet version" which is a bit confusing as to what it means since this wallet is v0.1.1 and then it says 2 there, some context explaining what it is, e.g. (?) with popup info field.

Seen in build version: 0.1.1
Matt commented "Do we think its safe to remove this field entirely? As I understand it's likely to never change going forward? How many users do we think have the old version and what is the upgrade path for those users?"

Previously prompted user to download when there is a new release but we don't want the user to update every time while there are breaking changes, we want the user to use the wallet app version that  works with the network version.


chore: add GH action for standardized labels

Pulls in the label management action from https://github.com/honeycombio/oss-management/tree/v1/labels

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d56765d) 80.82% compared to head (3ce8d29) 80.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   80.82%   80.82%
=======================================
  Files          62       62
  Lines        4809     4809
=======================================
  Hits         3887     3887
  Misses        768      768
  Partials      154      154

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement PartialOrd for DateTime

Create a new function used in tests for comparing DateTime objects since the PartialEq implementation has changed :
fn check_equal_date_time(x: &DateTime, y: &DateTime) {
    assert_eq!(x.second, y.second);
    assert_eq!(x.minute, y.minute);
    assert_eq!(x.hour, y.hour);
    assert_eq!(x.month_day, y.month_day);
    assert_eq!(x.month, y.month);
    assert_eq!(x.year, y.year);
    assert_eq!(x.week_day, y.week_day);
    assert_eq!(x.year_day, y.year_day);
    assert_eq!(x.local_time_type, y.local_time_type);
    assert_eq!(x.unix_time, y.unix_time);
}

Create a new function used in tests for comparing DateTime objects since the PartialEq implementation has changed

Done.

A better implementation is to remove the Eq implementation for Datetime and compare only the Unix times for the PartialEq and PartialOrd implementations.

Closed in c4d7db5.


Use Remark beautifier for markdown files by default

What does this implement/fix? Explain your changes.
Tidy Markdown was the first and only markdown beautifier in atom-beautify until Remark was added two years ago. As of January 2018, Remark seems to be a more promising solution for markdown according to the state of its community:

Tidy Markdown
Remark

number of contributors
2
60

commits to master in 2017
11
50+

github stars
35
1235

downloads per months on npm
45K+
660K+

I'd like to propose switching to Remark by default and thus serve atom-beautify users with something they are more likely to be familiar with.
Does this close any currently open issues?
This may positively affect https://github.com/Glavin001/atom-beautify/pull/1990 because Tidy Markdown has some issues extracting code from code blocks. If Remark is made a default choice, we can simply disable code block beautification option for Tidy Markdown without any harm to most users.
Also, if the solution to https://github.com/Glavin001/atom-beautify/issues/965 is found, the default markdown beautifier will better integrate with custom markdown preferences that users may have.
Checklist
Check all those that are applicable and complete.

[x] Merged with latest master branch
[x] Regenerate documentation with npm run docs
[x] Add change details to CHANGELOG.md under "Next" section
[x] Added examples for testing to examples/ directory
[ ] Travis CI passes (Mac support)
[ ] AppVeyor passes (Windows support)

Thank you for this Pull Request, @kachkaev! Great work so far. Close to merging 😄 .

Thanks for your feedback @Glavin001! I tried to address the questions you've raised and am happy to hear what you think again!

CI fails, but according to the logs, the problem is with examples/simple-jsbeautifyrc/tsx/expected/test.tsx, not markdown files 🤔

Hmm... After checking out markdown formatting with prettier in the last couple of days, I'm in doubt that we should switch from 2/3 space indents to a fixed indent of four. Prettier also uses remark, but it's only for parsing. The details on how they generate the output is in this feature PR:
https://github.com/prettier/prettier/pull/2943
So what shall we do with list item spacing? 🤔

Thank you for contributing and your great work, @kachkaev !!

Published to v0.32.0


Is this plugin available at jenkins plugins?

Just tried to look for this plugin at jenkins plugins and the only record I got is GitHub Pull Request Coverage Status Addon 1.10.0, also all releases here are named as github-pr-coverage-status-* ? so I'm puzzled - should I manually replace existing extension with this one or something? why name starts with github not bitbucket/stash?

This plugin is currently not available at jenkins plugins. It is a fork of github-pr-coverage-status-plugin but I replaced all github related stuff with the bitbucket server / stash api.
I never created an official release, and never applied to be listed at jenkins plugins since I never got the time to give this repository the finishing touch. It is running in our company and doing its job - but I am not satisfied with the code.
I can provide an *.hpi file for manual installation in the jenkins - and with enough feedback I might even continue the development.

Sorry for the delay. I just uploaded an hpi file that is currently used at my company.
https://github.com/adiesner/bitbucket-pr-coverage-status-plugin/releases/tag/bitbucket-pr-coverage-status-0.0.1


OpenBLAS crash with VS2010 Release

Hello everyone, I compile an project on VS2010, finding out OpenBLAS crash in Release mode, any good advice?
IDE: MS VS2010;
OS: Windows XP sp3 on VirtualBox.
OpenBLAS version: v0.2.20, compiled using MSYS2 + gcc & gfortran 4.9.2.
Project runs in Debug mode is ok, but crash in  Release mode, calling cblas_sgemv or cblas_sgemm will crash, code jump to crtexe.c the 552 line: mainret = wmain (argc, argv, envp);.
Both modes use default configuration, except for the dll library config.
The test code is as follows:
#include "StdAfx.h"
#include "cblas.h"
#include <stdio.h>
void main()
{
int i=0;
double A[6] = {1.0,2.0,1.0,-3.0,4.0,-1.0};
double B[6] = {1.0,2.0,1.0,-3.0,4.0,-1.0};
double C[9] = {.5,.5,.5,.5,.5,.5,.5,.5,.5};
cblas_dgemm(CblasColMajor, CblasNoTrans, CblasTrans,3,3,2,1,A, 3, B, 3,2,C,3);
for(i=0; i<9; i++)
printf("%lf ", C[i]);
printf("\n");
}
In addition, the downloaded OpenBLAS v0.2.15 and v0.2.14 Win32 prebuilt have the same problem.
Thank you.

What build options did you use (multithreading, number fo threads in particular) ?
Also make sure that you got the arguments right in the cblas_dgemm call, at a glance it seems to me it should be ...,A,2, B... ?

I use the default options of debug and release mode of VS2010, no multithreading.
For release mode, compile commandline is  /Zi /nologo /W3 /WX- /O2 /Oi /Oy- /GL /D "WIN32" /D "NDEBUG" /D "_CONSOLE" /D "_UNICODE" /D "UNICODE" /Gm- /EHsc /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /Yu"StdAfx.h" /Fp"Release\blas_simple.pch" /Fa"Release\" /Fo"Release\" /Fd"Release\vc100.pdb" /Gd /analyze- /errorReport:queue
Link commandline is /OUT:"C:\project\blas_simple\Release\blas_simple.exe" /INCREMENTAL:NO /NOLOGO /LIBPATH:"C:\project\blas_simple\blas_simple" "libopenblas.dll.a" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "comdlg32.lib" "advapi32.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "odbc32.lib" "odbccp32.lib" /MANIFEST /ManifestFile:"Release\blas_simple.exe.intermediate.manifest" /ALLOWISOLATION /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /DEBUG /PDB:"C:\project\blas_simple\Release\blas_simple.pdb" /SUBSYSTEM:CONSOLE /OPT:REF /OPT:ICF /PGD:"C:\project\blas_simple\Release\blas_simple.pgd" /LTCG /TLBID:1 /DYNAMICBASE /NXCOMPAT /MACHINE:X86 /ERRORREPORT:QUEUE
The test code was directly copied from  the sample code here:https://gist.github.com/xianyi/6930656#file-test_cblas_dgemm-c, so I think it can't be wrong.
Thank you for reply.

Array parameters must be pointers (see cblas.h for detail)

@brada4 the code is correct (and runs on linux), guess we'd need to know the build options used for OpenBLAS (though it is a bit suspicious that xianyi's prebuilt binaries fail in the same way).

/Gd also seems correct....

I tried to replace the cblas_dgemm line into
cblas_dgemm(CblasColMajor, CblasNoTrans, CblasTrans,3,3,2,1,&A[0], 3, &B[0], 3,2,&C[0],3);
and nothing improved.

Thank you for reply, but that dosn't work.

I change my project to VS 2015, and every thing works fine.
Thanks guys!


Error with Deno 1.6.0

Describe the bug
input-deno fails with latest Deno 1.6.0 (worked with previous 1.5.x releases)
To Reproduce
Steps to reproduce the behavior:

Install Deno 1.6.0
Run the sample code

    import InputLoop from 'https://deno.land/x/input/index.ts';
    const input = new InputLoop();
    const accepting = await input.choose(["Accepting node", "Non-accepting node"]);

Program Output
error: TS2345 [ERROR]: Argument of type 'string | undefined' is not assignable to parameter of type 'string | PromiseLike<string>'.
  Type 'undefined' is not assignable to type 'string | PromiseLike<string>'.
		return new Promise((resolve) => resolve(value));
		                                        ~~~~~
    at https://deno.land/x/input@2.0.1/index.ts:24:43

Versions (please complete the following information):

OS: Ubuntu Linux 20.04
Deno Version 1.6.0

Thanks @emanueleg for this report! I'm going to try to get the proposed fix in this evening


[BUG] Terrain Doesn't Save

Draw terrain.
Switch to a different scene, then switch back.
Terrain is gone.

https://user-images.githubusercontent.com/99844555/232272613-2d252d11-bb70-4270-822d-235014285c2a.mp4
ETL 10.7
FTC Brand new world.

Just booted up my various worlds and the terrain I drew is there now?

Should be fixed in the latest version


Tailwind 0.1.2

Tailwind v0.1.2 was released. This PR updates the preset to download the lastest version.

0.1.3 is out :P

Just started reviewing :) :octocat: Sent from GH.


Switching tabs now fires an event

Switching tabs fires an event with the tab index and tab id, if it exists.  This allows the containing page to perform actions, when applicable (e.g. making lazy API calls).

@mdwragg Please take a look at this PR.

Tweaked it slightly to raise an event called px-tab-changed. Tests also added post-merge of PR. Thanks for your PR!


snowflake_account_grant fails silently

Provider Version
0.25.18
Terraform Version
1.0.4
Describe the bug
The resource snowflake_account_grant fails silently if not enough permissions are held.
Expected behavior
An error would be thrown if it is not successful.
Additional context
Certain account grants require the ACCOUNTADMIN role (see https://docs.snowflake.com/en/user-guide/security-access-control-privileges.html). If terraform is run with lower roles, running GRANT EXECUTE TASK ON ACCOUNT TO ROLE "EXAMPLE"; (for example) leads to a successful SQL result with 1 row => STATUS='Grant not executed: Insufficient privileges.'. The snowflake provider reports this as a success as the command completed.

Can you give an example of the terraform you're trying to create?

We use TF CDK so looks like
new snow.AccountGrant(scope, `grant_${dbName}-owner-exec`, {
  roles: [db_owner.name],
  privilege: "EXECUTE TASK"
});

but on plan:
  # snowflake_account_grant.grant_TEST_DB-owner-exec will be updated in-place
  ~ resource "snowflake_account_grant" "grant_TEST_DB-owner-exec" {
        id                = "ACCOUNT|||EXECUTE TASK|false"
      ~ roles             = [
          + "OWNER_TEST_DB",
        ]
        # (2 unchanged attributes hidden)
    }

seems to happen on any of the account grants that require ACCOUNTADMIN if run without.

I've also just ran into this issue while running on 0.31.0.

Also hit this

This happens when granting roles too.
Examples:
myuser#(no warehouse)@(no database).(no schema)>grant role ROLE1 to role ACCOUNTADMIN;
+----------------------------------------------+
| status                                       |
|----------------------------------------------|
| Grant not executed: Insufficient privileges. |
+----------------------------------------------+

myuser#(no warehouse)@(no database).(no schema)>desc role USERADMIN;
003001 (42501): SQL access control error:
Insufficient privileges to operate on role 'USERADMIN'
myuser#(no warehouse)@(no database).(no schema)>grant role USERADMIN to role ROLE1;
+----------------------------------------------+
| status                                       |
|----------------------------------------------|
| Grant not executed: Insufficient privileges. |
+----------------------------------------------+

Using 0.63, same issue. In fact, my Snowflake UI shows the same silent failure message (successful query but failed to grant).

I had a short discussion about this with Snowflake support, and the behaviour of the query state is indeed "by design". They explained it as the situation that is occurring is an "exception", instead of an "error" which would mark the query as "failed".
This also somewhat problematic from an auditing point of view (who tried to change what, and was it successful), but that's not very relevant here.
What makes this even more irritating is that there does not seem to exist a very clear list of which account grants require the escalated privileges, at least not in the first hit on Google.

This issue is addressed permanently in the 2023_05 bundle. Going forward, an explicit error will be thrown if a grant command can't go through due to insufficient privileges.


Flip Y and U player movement keys to better match diagonals

They were reversed from the behavior I would expect :)

That looks good - thank you! Sorry for the delay, I'm moving house. I'll get this merged and add you to the contributors page.

Thanks! Good luck on the move!


Error: Error: Cannot find where you keep your Bower packages.     at /home/ubuntu/meanjs/node_modules/wiredep/wiredep.js:30:56

it didnt used to happen before,  but now everytime i try to install new version of mean js  I get this error.

coz of node v5