Allow dynamic recompilation to access internal members

This is a bit of a proof-of-concept and I'm not sure on the viability of it going forward, ready for merge if you think it's fine. It fixes the TestSceneDrawableJudgement -> LegacyJudgementPieceNew case pointed out in Discord (accessing SkinInfo.DEFAULT_SKIN, etc).
See https://www.strathweb.com/2018/10/no-internalvisibleto-no-problem-bypassing-c-visibility-rules-with-roslyn/ for more info.
There is an internal compiler attribute IgnoresAccessChecksTo(assemblyName) which acts inversely to InternalsVisibleTo(assemblyName). However it:

Requires setting internal compiler option TopLevelBinderFlags, and thus the API surface may change.
Requires importing all internal symbols, which can be an issue because it means there is the possibility of type conflicts in matching namespaces. This already happens with JetBrains.Annotations, which libraries define themselves and conflict with the nuget JetBrains.Annotations package.

To get around this, I'm excluding all assemblies that contain a JetBrains.Annotations namespace themselves, and only including the nuget package.
This is not an exhaustive search - if two libraries included the same namespace+type combo that is not JetBrains.Annotations, DCC would fail.
Microsoft.EntityFrameworkCore assemblies all get excluded so types referencing EF symbols can't be dynamically recompiled. This isn't a huge issue for us because all of our EF stuff is done in manager classes that can't be recompiled anyway (they're too far-reaching).

I haven't yet found a way to get past (2), and if it becomes a problem then we may have to reconsider...

Is it fine if i gloss over the details in this one and exclaim "it works! (for now)" ?

I think there shouldn’t be any issues for us, at least.


Update the repository structure

Update the README:

Add badge with F# logo
Add a gif of the script execution

Update structure:

Create the src folder for the utils.fs, program.fs and fitch.fsproj files
Update script Setup.sh

Take a look 😃

This looks good to me. Thank you @Jonas-Lara 🙂


[release-4.16] OCPBUGS-36498:  Fix to ensure invalid catalogs are skipped

Description
This fix addresses the SIGSEGV violation error (causing oc-mirror to crash).
The root cause is the handling of invalid catalogs for oc-mirror v2 (only oci file base catalogs are valid and not SQLite (database) type catalogs
Fixes # reference to OCPBUGS-36445
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Verified locally using the following imagesetconfig (from case 03862148)
kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
  operators:
  - catalog: icr.io/cpopen/noi-operator-catalog@sha256:ae39015ec2161a982c85d66456f23883dc19f85c00d5f3b2058f385fc5eacd50
    packages:
    - name: noi
  - catalog: icr.io/cpopen/ibm-netcool-integrations-operator-catalog@sha256:f913349f3c05f02fb48b2faaa9959927266947b64be5884e49e64f8d1e0788a5
    packages:
    - name: netcool-integrations-operator
  - catalog: icr.io/cpopen/tncp-catalog@sha256:dcf3a021269f7900cac8e2e8dd51cd32e087c35b68cf956d8d14565a4b9e7c55
    packages:
    - name: ibm-tncp-bundle
  - catalog: icr.io/cpopen/ibm-cpd-cloud-native-postgresql-operator-catalog@sha256:b5debd3c4b129a67f30ffdd774a385c96b8d33fd9ced8baad4835dd8913eb177
    packages:
    - name: cloud-native-postgresql

Using the following command line
bin/oc-mirror --v2 -c ocpbugs-36445.yaml --dry-run file://ocpbugs-36445 --loglevel info

Expected Outcome
Before this fix we would get this panic output
panic: runtime error:
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x3ccf3de]goroutine 1 [running]:
github.com/openshift/oc-mirror/v2/internal/pkg/manifest.Manifest.GetCatalog({{0x7c?, 0x2?}}, {0xc000d10a80?, 0x1?})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/openshift/oc-mirror/v2/internal/pkg/manifest/oci-manifest.go:204 +0x9e
github.com/openshift/oc-mirror/v2/internal/pkg/operator.(*LocalStorageCollector).OperatorImageCollector(0xc000004300, {0x54978a8, 0x76b6180})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/openshift/oc-mirror/v2/internal/pkg/operator/local_stored_collector.go:221 +0x1092
github.com/openshift/oc-mirror/v2/internal/pkg/cli.(*ExecutorSchema).CollectAll(0xc000afe480, {0x54978a8, 0x76b6180})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/openshift/oc-mirror/v2/internal/pkg/cli/executor.go:923 +0x323
github.com/openshift/oc-mirror/v2/internal/pkg/cli.(*ExecutorSchema).RunMirrorToDisk(0xc000afe480, 0xc000ae6300, {0x0?, 0xc000ec9058?, 0x17d7f85?})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/openshift/oc-mirror/v2/internal/pkg/cli/executor.go:694 +0x1a5
github.com/openshift/oc-mirror/v2/internal/pkg/cli.(*ExecutorSchema).Run(0xc000afe480, 0xc000aacd20?, {0xc000aacd20?, 0x0?, 0x0?})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/openshift/oc-mirror/v2/internal/pkg/cli/executor.go:439 +0x149
github.com/openshift/oc-mirror/v2/internal/pkg/cli.NewMirrorCmd.func1(0xc000a7b200?, {0xc000aacd20, 0x1, 0x5})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/openshift/oc-mirror/v2/internal/pkg/cli/executor.go:203 +0x32a
github.com/spf13/cobra.(*Command).execute(0xc000ae6300, {0xc0000521f0, 0x5, 0x5})
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/spf13/cobra/command.go:987 +0xaa3
github.com/spf13/cobra.(*Command).ExecuteC(0xc000ae6300)
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/spf13/cobra/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(0x74be758?)
        /go/src/github.com/openshift/oc-mirror/vendor/github.com/spf13/cobra/command.go:1039 +0x13
main.main()
        /go/src/github.com/openshift/oc-mirror/cmd/oc-mirror/main.go:10 +0x18

With this fix  oc-mirror  v2 should not crash, expected output should show invalid catalogs as warning
$ bin/oc-mirror --v2 -c verizon.yaml --dry-run file://verizon --loglevel info

2024/07/03 11:24:42  [WARN]   : ⚠  --v2 flag identified, flow redirected to the oc-mirror v2 version. This is Tech Preview, it is still under development and it is not production ready.
2024/07/03 11:24:42  [INFO]   : 👋 Hello, welcome to oc-mirror
2024/07/03 11:24:42  [INFO]   : ⚙  setting up the environment for you...
2024/07/03 11:24:42  [INFO]   : 🔀 workflow mode: mirrorToDisk
2024/07/03 11:24:42  [INFO]   : 🕵  going to discover the necessary images...
2024/07/03 11:24:42  [INFO]   : 🔍 collecting release images...
2024/07/03 11:24:42  [INFO]   : 🔍 collecting operator images...
2024/07/03 11:24:46  [WARN]   : [GetCatalog] invalid catalog verizon/working-dir/hold-operator/tncp-catalog/dcf3a021269f7900cac8e2e8dd51cd32e087c35b68cf956d8d14565a4b9e7c55 : SKIPPING
2024/07/03 11:24:46  [WARN]   : [OperatorImageCollector] package ibm-tncp-bundle not found in catalog icr.io/cpopen/tncp-catalog@sha256:dcf3a021269f7900cac8e2e8dd51cd32e087c35b68cf956d8d14565a4b9e7c55
2024/07/03 11:24:47  [WARN]   : [GetCatalog] invalid catalog verizon/working-dir/hold-operator/ibm-cpd-cloud-native-postgresql-operator-catalog/b5debd3c4b129a67f30ffdd774a385c96b8d33fd9ced8baad4835dd8913eb177 : SKIPPING
2024/07/03 11:24:47  [WARN]   : [OperatorImageCollector] package cloud-native-postgresql not found in catalog icr.io/cpopen/ibm-cpd-cloud-native-postgresql-operator-catalog@sha256:b5debd3c4b129a67f30ffdd774a385c96b8d33fd9ced8baad4835dd8913eb177
2024/07/03 11:24:47  [INFO]   : 🔍 collecting additional images...
2024/07/03 11:24:47  [WARN]   : ⚠  12/12 images necessary for mirroring are not available in the cache.
2024/07/03 11:24:47  [WARN]   : List of missing images in : verizon/working-dir/dry-run/missing.txt.
please re-run the mirror to disk process
2024/07/03 11:24:47  [INFO]   : 📄 list of all images for mirroring in : verizon/working-dir/dry-run/mapping.txt
2024/07/03 11:24:47  [INFO]   : mirror time     : 5.429137541s
2024/07/03 11:24:47  [INFO]   : 👋 Goodbye, thank you for using oc-mirror

/label qe-approved

/lgtm

/label backport-risk-assessed

/label cherry-pick-approved


Responsive logo in Readme

Previously the logo had a fixed height which lead to it not being displayed properly on mobile devices. I changed the width to be relative and removed the height tag.
This way the image retains its aspect ratio independent of the display size.

Great! Thank you!


farrah/P2PS-3037/p2p guide

Added a new page for P2P Guide section.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

147 of 163 (90.18%)  changed or added relevant lines in 23 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 83.328%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/guide/screens/Blog/Blog.tsx
9
10
90.0%

src/pages/guide/components/Carousel/Carousel.tsx
17
22
77.27%

src/pages/guide/components/GuideTooltip/GuideTooltip.tsx
19
24
79.17%

src/pages/guide/screens/Videos/Videos.tsx
18
23
78.26%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
5182

Relevant Lines:
5766

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

148 of 164 (90.24%)  changed or added relevant lines in 23 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 83.33%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/guide/screens/Blog/Blog.tsx
9
10
90.0%

src/pages/guide/components/Carousel/Carousel.tsx
17
22
77.27%

src/pages/guide/components/GuideTooltip/GuideTooltip.tsx
19
24
79.17%

src/pages/guide/screens/Videos/Videos.tsx
18
23
78.26%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
5183

Relevant Lines:
5767

💛  - Coveralls


[Snyk] Upgrade @lifi/sdk from 2.2.3 to 2.5.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @lifi/sdk from 2.2.3 to 2.5.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 7 versions ahead of your current version.
The recommended version was released a month ago, on 2023-11-01.

Release notes

Package name: @lifi/sdk

2.5.0 - 2023-11-01No content.

2.4.3 - 2023-10-03

2.4.2 - 2023-10-03

2.4.1 - 2023-09-25

2.4.0 - 2023-09-20

2.3.1 - 2023-09-04

2.3.0 - 2023-08-17

2.2.3 - 2023-08-04

    from @lifi/sdk GitHub release notes

Commit messages

Package name: @lifi/sdk

2b1b516 chore(release): 2.5.0
0756631 fix: improve error handling during LiFi initialization (#171)
f1cde15 feat: upgrade to msw v2
bd3ebc9 chore: bump packages
4af0362 chore(release): 2.4.3
5877a78 chore(release): 2.4.2
e4a145d fix: wallet analytics API request changes (#167)
5066009 chore(release): 2.4.1
ee954b8 fix: type fix for transaction history response (#166)
c005f0a fix: publish workflow
551b6e1 chore(release): 2.4.0
a920791 chore: bump packages
bdcaad1 chore: add endpoint for transaction history (#165)
bb721cb feat: add multi-contract calls API endpoint (#164)
92309e6 chore(release): 2.3.1
79ea63b fix: remove updateTransactionRequestHook from allowance read call (#162)
7a9180a chore(release): 2.3.0
0df7aaa Merge pull request #163 from lifinance/bump-types-package
aaadb34 chore:  bump types package
43c277c chore: bump example packages
e9dc0fe feat: allow to pass api key to all requests (#159)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Closing this PR since its been upgraded to this version on the latest commit to master


Feature Request: Add "cloneModelsToScene" Method to AssetContainer Class

Hello,
I was wondering if it would be possible to add a new method to the AssetContainer class in Babylon.js that allows models to be cloned to another scene. Currently, we can clone individual meshes using the instantiateModelsToScene method, but there is no built-in way to clone all of the models in an AssetContainer to another scene.
I believe that adding a cloneModelsToScene method would be a useful addition to Babylon.js, as it would allow for more efficient use of resources and faster scene loading times when using multiple scenes with similar models.
Please let me know if this is something that could be considered for inclusion in a future release.
Discussion link：https://forum.babylonjs.com/t/multiple-scenes-with-one-asset-glb-and-multiple-views-scissors-cameras/18853

Can you create a specific thread on the forum as feature request and we can discuss adding it to our next release there ?
Github is reserved as the template mentions for validated issues.


Policy Marker- unable to enter code for vocabulary 99

Hi team,
This issue has just been flagged by a publisher. I also checked into my account and it does look like it is a bug on Aidstream.
If an organisation selects vocabulary  99- Reporting Organisation, they should be able to to add their own Policy Marker code. Currently that is not possible (see screenshot below).

Organisations should be able to enter/type their own code if they select  99- Reporting Organisation.
Could you look into this?
Thanks,
Petya

Hi team,
Is there an update on this? Léonore Rougemont from Drugs for Neglected Diseases initiative has been in contact with me again as they are awaiting this fix to be able to publish data to IATI.
Thanks,
Petya

Hello Petya,
Hope you are doing well.
If an organisation selects vocabulary 99- Reporting Organisation, they are now able to to add their own Policy Marker code.
Regards,
Karuna


🐛 [firebase_storage] Why cant I get the files inside my folders in Firebase Storage

I'm using Firebase Storage with this structure within:
Photos
-MyPhotos
--photo1.png
--photo2.png
With this code:
  Future<ListResult> loadLab() async {
    var result = await _storage.ref().child('Photos/').listAll();

    result.prefixes.forEach((Reference ref) {
      print('Found directory: $ref');

    });
    result.items.forEach((Reference ref) {
      print('Found file: $ref');
    });
    return Future.value(result);
  }

But my return is, "Found directory: Reference(app: [DEFAULT], fullPath: Photos/MyPhotos)"... Why it don't return my items inside myPhotos too? How can I do it?

This is because it returns a Reference object and by accessing its 'fullPath' property you will have to first get the full path to MyPhotos folder and then use the listAll() method on that full path.

This is because it returns a Reference object and by accessing its 'fullPath' property you will have to first get the full path to MyPhotos folder and then use the listAll() method on that full path.


[RFC] Split off bytecode compilation into a separate crate

Summary
Make a new crate, rustpython_bytecode, that holds the bytecode data structures and does the compilation from the AST from rustpython_parser to bytecode.
Detailed Explanation
This would likely be easy to implement, just move bytecode.rs and compile.rs into a separate crate. This would allow us to let rustpython_derive depend on rustpython_bytecode and we would be able to compile Python to bytecode at compile time. Then we would be able to create frozen modules more efficiently: just run the bytecode, no need to parse the source code at runtime.
Drawbacks, Rationale, and Alternatives
I believe @windelbouwman said that it would be nice to not fragment RustPython into too many crates, citing npm and left-pad as an argument against doing so. I believe that this is a fairly logical place to split up RustPython, allowing us separation of concerns. In addition, Rust's crate system and cargo allow many crates to be depended upon easily, and many large players in Rust's ecosystem have modularized, allowing consumers to only depend on what they need (see: tokio, actix, amethyst, wasmer, etc). We're not in that exact situation, but still.
An alternative to this would just be a build.rs file for rustpython that depends on rustpython_vm and compiles source code there, but that feels less elegant and would have to be copied for rustpython_wasm or anyone that wants to embed RustPython into their app.
Unresolved Questions
There may be some other solution to this compile-time compilation I haven't thought of, if anyone could think of something else I'd be interested to hear it.

There may be some other solution to this compile-time compilation I haven't thought of, if anyone could think of something else I'd be interested to hear it.

CPython has the make regen-importlib that created a small executable that compiles the code and write it to file.
I think you solution is probably better as you will not need to run a special command every time you will change the bytecode. Is your plan to compile the frozen modules every time we build rustpython?

I like this idea! I would suggest to create two extra crates next to rustpython_vm and rustpython_parser. I would call it rustpython_compiler and rustpython_bytecode.
My main problem with leftpad is that this was also a seperate git repository with all the branching, pull requests overhead etc. I believe having more smaller crates in a single repository is pretty okay.


C2ME ThreadLocalRandom accessed from a different thread errors - CaveSpiderMixin

[c2me-worker-2/ERROR]: ThreadLocalRandom accessed from a different thread (owner: Server thread, current: c2me-worker-2)
This is usually NOT a bug in C2ME, but a bug in another mod or in vanilla code.
Possible solutions:

Find possible causes in the stack trace below and

if caused by another mod, report this to the corresponding mod authors
if no other mods are involved, report this to C2ME

java.util.ConcurrentModificationException: ThreadLocalRandom accessed from a different thread (owner: Server thread, current: c2me-worker-2)
at knot/com.ishland.c2me.fixes.worldgen.threading_issues.common.CheckedThreadLocalRandom.handleNotOwner(CheckedThreadLocalRandom.java:55) ~[c2me-fixes-worldgen-threading-is0.299+1.21.1-34b0bb1feeddc57.jar:?]
at knot/com.ishland.c2me.fixes.worldgen.threading_issues.common.CheckedThreadLocalRandom.isSafe(CheckedThreadLocalRandom.java:38) ~[c2me-fixes-worldgen-threading-is0.299+1.21.1-34b0bb1feeddc57.jar:?]
at knot/com.ishland.c2me.fixes.worldgen.threading_issues.common.CheckedThreadLocalRandom.method_43156(CheckedThreadLocalRandom.java:86) ~[c2me-fixes-worldgen-threading-is0.299+1.21.1-34b0bb1feeddc57.jar:?]
at knot/net.minecraft.class_6566.method_43057(class_6566.java:56) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_1299.method_5888(net/minecraft/class_1299.java:440) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_1299.method_5899(net/minecraft/class_1299.java:413) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_1299.method_47821(net/minecraft/class_1299.java:408) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_1549.handler$ehn000$sihywtcamd_extensions$spawnBaby(com/github/charlyb01/sihywtcamd_extensions/mixin/spider/CaveSpiderMixin.java [sihywtcamd_extensions.mixins.json]:36) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_1549.method_5943(net/minecraft/class_1549.java:56) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3499.method_17917(net/minecraft/class_3499.java:427) ~[server-intermediary.jar:?]
at java.base/java.util.Optional.ifPresent(Optional.java:178) ~[?:?]
at knot/net.minecraft.class_3499.method_15179(net/minecraft/class_3499.java:422) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3499.method_15172(net/minecraft/class_3499.java:347) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3781.method_16626(net/minecraft/class_3781.java:143) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3790.method_27236(net/minecraft/class_3790.java:98) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3790.method_14931(net/minecraft/class_3790.java:94) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3449.mixinextras$bridge$method_14931$23(class_3449.java) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3449.wrapOperation$cjh000$frozenlib$frozenLib$placeInChunkB(net/frozenblock/lib/worldgen/structure/mixin/StructureStartMixin.java [mixin/frozenlib.worldgen.structure.mixins.json]:121) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_3449.method_14974(net/minecraft/class_3449.java:100) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_2794.method_38265(net/minecraft/class_2794.java:324) ~[server-intermediary.jar:?]
at knot/com.google.common.collect.ImmutableList.forEach(ImmutableList.java:422) ~[guava-32.1.2-jre.jar:?]
at knot/net.minecraft.class_2794.method_12102(net/minecraft/class_2794.java:323) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_9310.method_57610(net/minecraft/class_9310.java:103) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_9770.mixinextras$bridge$doWork$14(class_9770.java) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_9770.wrapOperation$bcj000$c2me-opts-chunk-access$runGenerationTask(com/ishland/c2me/opts/chunk_access/mixin/region_capture/MixinChunkGenerationStep.java [c2me-opts-chunk-access.mixins.json]:26) ~[server-intermediary.jar:?]
at knot/net.minecraft.class_9770.method_60560(net/minecraft/class_9770.java:33) ~[server-intermediary.jar:?]
at knot/com.ishland.c2me.rewrites.chunksystem.common.statuses.VanillaWorldGenerationDelegate.lambda$upgradeToThis$8(VanillaWorldGenerationDelegate.java:123) ~[c2me-rewrites-chunk-system-<IP_ADDRESS>9+1.21.1-c95ef437b6e3336f.jar:?]
at knot/com.ishland.c2me.base.common.scheduler.ScheduledTask.run(ScheduledTask.java:22) [c2me-base-0.3.0+alpha.0.299+1.21.1-4ad1ca956dec760d.jar:?]
at knot/com.ishland.flowsched.executor.WorkerThread.pollTasks(WorkerThread.java:57) [c2me-base-0.3.0+alpha.0.299+1.21.1-4ad1ca956dec760d.jar:?]
at knot/com.ishland.flowsched.executor.WorkerThread.run(WorkerThread.java:27) [c2me-base-0.3.0+alpha.0.299+1.21.1-4ad1ca956dec760d.jar:?]

I just ran into this issue on my server too if anyone has any fixes. Poking through the stack trace, could it be related to this bit?:
at knot/net.minecraft.class_1549.handler$ehn000$sihywtcamd_extensions$spawnBaby(com/github/charlyb01/sihywtcamd_extensions/mixin/spider/CaveSpiderMixin.java [sihywtcamd_extensions.mixins.json]:36) ~[server-intermediary.jar:?]
which might also be related to this bit: https://github.com/sf-inc/sihywtcamd_extensions/blob/7639dcd1312e178b7f769a0fe0aaf4d696b8deb7/src/main/java/com/github/charlyb01/sihywtcamd_extensions/mixin/spider/CaveSpiderMixin.java#L32


Clean task fails silently

Clean task failed if files didn't exist (my fault), so now it fails silently if a file doesn't exist or an error occurs.

@timdorr Good point, fixed

Thanks!


Hott755 dockerise backend

Jira link
HOTT-755
What?
I have added/removed/altered:

[ ] Build docker image for the backend app (DEV only)
[ ] Deploy docker backend service in blue-green (DEV only)
[ ] Deploy docker based worker (DEV only)

Why?
I am doing this because:

Moving to docker based deployment

Note before merging:  This PR is using temporary target apps (-docker suffixed) to avoid clash with the current ones.
This before merging, the apps need to be renamed in CF and this PR edited accordingly.

We bumped the docker version in Dockerfile, but the Gemfile is still behind.
Maybe it's best to deal with the Ruby version upgrade in a separate PR?


Feature/migration

automatic save file migration option.

factorio_rcon -> requirements.txt

how do I migrate from version 0.16?

replace the link with the proper version for windows. (probably full/win)
also you might have to remove the factorio folder before running -u.
benchmarker -u --version_link https://www.factorio.com/get-download/1.0.0/headless/linux64
benchmarker -mi
benchmarker -u
bemchmarker -mi


Rename schema::Object.builtin to is_builtin

We're using an is_ prefix pretty consistently for bool flags. @vpetrovykh please fix this one and take a close look if we have other inconsistencies.

So there are also the following:
CREATE TYPE schema::Annotation EXTENDING schema::Object {
    CREATE PROPERTY inheritable -> std::bool;
};

CREATE TYPE schema::Constraint
    EXTENDING schema::CallableObject, schema::InheritingObject
{
    CREATE PROPERTY delegated -> std::bool;
    ...
};

CREATE ABSTRACT TYPE schema::Pointer
    EXTENDING
        schema::InheritingObject, schema::ConsistencySubject,
        schema::AnnotationSubject
{
    CREATE PROPERTY required -> std::bool;
    ...
};

CREATE TYPE schema::Function
    EXTENDING schema::CallableObject, schema::VolatilitySubject
{
    CREATE PROPERTY session_only -> std::bool {
        SET default := false;
    };
};

Do we convert all of these to use is_ prefix, too?

Can you list all bool flags with is_ and without is_ here in one bullet point list?

Sure, let's mark which ones we want to have 'is_ prefix (this is from finding all boolean properties in system library):

[x] is_internal
[x] is_abstract
[x] is_final
[x] is_owned
[x] is_abstract
[x] is_superuser
[x] builtin
[ ] inheritable
[ ] delegated
[ ] required
[ ] session_only
[ ] allow_implicit
[ ] allow_assignment

Oh, so it's almost a 50/50 split (I thought is_ versions dominate the non-is ones.)
TBH, I don't like the is_ prefix and I think we can instead drop is_. Looks like abstract and final are unreserved keywords so it shouldn't be a problem.
@elprans green light from you to drop is?
Another question, what is is_internal?

I suspect that it's mainly force of habit that makes me want to keep required without a prefix. Ultimately consistent is_ for boolean flags appeals to my sense of strict formalism, as natural laguages are notoriously bad with everything boolean. I'd probably keep allow_ prefixes as is, though as they seem to follow the same pattern as is_.

I think that is_internal flag marks parts of the schema that are needed, but shouldn't be exposed for one reason or another, isn't that exactly the distinction between all of shcema and user-introspectible schema that @elprans talked about?
victor> WITH MODULE schema
....... SELECT ObjectType {
....... name
.......

That's correct.

So to clarify what I mean by "my sense of formalism is in strong opposition of actual natural language use" I mean that personally consistent is_ prefixes for bool flags seem appealing to me. However, having them as part of the names makes it awkward to write actual English sentences like "If the property in question is is_required ..." and forces re-wording like "If the property has an is_required flag set to true ...". In spoken English it's not a big deal, but in a written manual/example it becomes a bit awkward.
So 1 IF link.is_required ELSE 0 may look good in code, but it's awkward in docs. I think I just made a case against is_ prefix...


Database Write Times

Im not sure if this is actually an issue, but it seems like the longer I let the dr-import command run, the worse the write speed gets. I got about 3 hours in, and was getting about 18 tags/s. I stopped the import and restarted (hoping it saved progress and was just a bug), but it seems like the same thing is happening again. Any recommendations?

Update, found out that maybe running dr-db-create would be a good idea haha. I think that you should add that into the main readme after the dr-db-up part, as it isnt mentioned anywhere other then in up.sh, which generally wont be used for the pip users.  I'll mark this as closed, but just an idea.

Agreed. That was the design, too, so there must be a bug somewhere.

It was just user error. I didn't realize you had to use the dr-db-create as well dr-db-up. Once I did that it was all working. Im going to re-close this as its solved


Japanese Language Support (only)

This pull request adds 'japanese' to the list of languages (core), as well as, provides a japanese locale file (web). Adjustments to the existing locales were made to support this language as well.
This pull request slightly adjusts the web views (options and shortcuts) improving both the layout and locale support.
All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Does your submission pass tests?

REBOOT!
I changed the keys to be short english phrases. The phrases do not contain any special characters or special phrases, as those can be added to the locales if required to communicate.
@kaosat-dev Please veiw the changes to keys in src/ui/views.

Awesome @z3dev ! Looks good to me ! Any other changes or can I merge ?

@kaosat-dev please merge


Failed to download course.

I can't download courses from udacity although I can download nanodegrees
it pop up this massage

incorrect syntax has been used.


Unused sequence page horizontal resize gutter

Checked for duplicates
Yes - I've already checked
Is this a regression?
Yes - This worked in a previous version
Version
develop
Describe the bug
Cannot properly resize sequence page panels due to some incorrect setup of the gutters
Reproduction
Try to resize the sequence page panels
Logs
No response
System Info
All

Severity
Moderate

Closing as dupe of https://github.com/NASA-AMMOS/aerie-ui/issues/1457


avoid unnecessary import

there is no need to import auto_gptq if we're not going to use it. We're seeing issues downstream with the latest auto-gptq if it happens to be installed but not needed.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Include of non-modular header inside framework module Bond.Bond

Hi,
I had a running project configuration using Xcode 8 and Swift 2.3. Yesterday evening I tried to migrate finally everything to Swift 3. Since then I'm facing the problem Include of non-modular header inside framework module Bond.Bond while trying to build my project.
I already tried to clean several times the derived data including cleaning up the whole project in Xcode without any luck. The build setting Allow non-modular includes in Framework modules seems also not to do the trick.
Had anyone else of you this kind of problem and knows what the solution might be? Any information or tip is really appreciated!

Hi @pk1,
Are you maybe using CocoaPods? If yes, do you have latest version?

After updating CocoaPods to version 1.1.1 and running pod install it started to re-create CocoaPods and this finally did the trick. Bond is now compiling without any error.
Thanks @srdanrasic and keep up the good work!


Use https rather than http since TinyURL now support it

Fix #1

As mentioned in #1, I am waiting for TinyUrl team feedback before merging


open and closed event endpoint

Add is_registration_open field to events: https://github.com/belatrix/BackendAllStars/commit/052d8507f9b81b46ec3a1dd219ae2b2fc006142d

Added reopen and closed endpoints: https://github.com/belatrix/BackendAllStars/commit/63f4c85a43cb542919d20417fe2e35b9e1b4a623


Zoom behavior with custom scaling

I have added support for custom scaling while zooming with d3.behavior.zoom. Example and changes in d3 API are described at http://bl.ocks.org/jchlapinski/d51d9aca2084bc02f30b
A method scaleGenerator was added to the 'zoom' object as follows:
var zoom = d3.behavior.zoom();

zoom.scaleGenerator(function (scale, delta, usecase) { // below is the default implementation
  if (usecase === "mousewheel") {
      // delta = event.deltaY (or equivalent for different browsers);
      return Math.pow(2, delta * .002) * k;
    } else if (usecase === "dbltap") {
      // delta = 0
      return k * 2;
    } else if (usecase === "dblclick") {
      // delta = 1 or -1 if user double-clicks while holding SHIFT
      return Math.pow(2, delta < 0 ? Math.ceil(Math.log(k) / Math.LN2) - 1 : Math.floor(Math.log(k) / Math.LN2) + 1);
    } else if (usecase === "touchzoom") {
      // delta is equal to the distance change between touches (two-finger) in pixels
      return k * delta;
    }
    return k;
});

var sg = zoom.scaleGenerator(); // get current scale generator

zoom.scaleGenerator(null); // restore default scale generator

As with #2605 this feels to me like something that should probably be fixed internally, rather than exposed as a new public API.
Related #2426 #2589.

This is a duplicate of #2605, and probably not related to just fixing mousewheel events on Windows, since it’s more about adding greater control over the zoom behavior.
My first concern with both of these proposals is whether it’s better to intercept the input events yourself and then change the scale of the zoom behavior, rather than letting the zoom behavior handle the input events while exposing hooks for how the zoom behavior computes the new zoom level.
For example, maybe it makes sense to change the behavior of dblclick, since the default of doubling or halving is arbitrary. But it’s not hard for you to intercept the dblclick event and trigger a zoom transition instead of letting the zoom behavior handle it.
And, it probably doesn’t make sense to override the interpretation of touch gestures; those are designed such that the touch point coordinates remain consistent under pinch and pan.
Similarly, it’s questionable to change the behavior of mousewheel, since consistency is good for usability (aside from it being broken on Windows in some cases)… but sure, maybe it makes sense to override in some contexts for slower or faster zooming. You could also intercept the mousewheel events and do this outside the zoom behavior, though admittedly this is a bit harder to do than intercepting dblclick because a sequence of mousewheel events is typically aggregated into a zoom gesture (zoomstart, zoom+, zoomend) using a timer.

Well, this PR was created because I needed precise control of scale factor for one of my projects. My particular use-case was that I charted some financial data on a bar chart with time scale and then used some non-linear aggregations while zooming out or in; When zooming out the scale was represented in months, quarters, 6 months, years, 5 years and decades. I wanted to precisely control consecutive scaling factors especially for mouse-wheel zooming to achieve some nice animations - three month bars would gradually become one quarter bar, etc. The point of adding proposed API was that it currently is not possible to scale for exactly 1/3 after single mouse wheel event, and then scale for 1/2 after another.
I did not test nor think about using touch gestures. I agree that with pinching this approach might need some more thought.
IMO zoom behavior should never expose too much of its internals (like event handling), but it could allow for applying custom scaling factors.
I do feel however, that my proposed API is clumsy and non-elegant as proposed above and I am open to suggestions how this could look like. Perhaps this should be divided into several scaling factor generator functions for different zooming events (mouse wheel zooming vs pinch zooming vs double tap zooming)? That way this clumsy 'usecase' parameter could be removed from the API?

That sounds like a reasonable approach for discrete input events like dblclick, but I’m not sure it’s appropriate for mousewheel, which is a continuous gesture on some platforms (and some input devices), such as OS X with a Magic Mouse or a MacBook trackpad.
You can, of course, group a sequence of mousewheel events into a single discrete gesture, and this is exactly what Google Maps did before the great switch from raster to vector tiles. But we’d need to change how the zoom behavior interprets the sequence of mousewheel events if you want it to snap to specific zoom levels.
It sounds like maybe the API you want is the ability to specify specific allowed zoom levels, rather than allowing continuous zooming between any zoom level (within the scaleExtent).
Also, I wonder whether you’d want to temporarily allow being between the specified zoom levels, so as to make the transition between allowed zoom levels smooth and continuous.

I also thought at first about just supplying a discreet array of scaling factors for scaleExtent, however as much as this would more or less suit my particular use-case at the time I thought it is much better to be able to supply a function, since that way one can do some dynamic and continuous calculations dependent on a specific context. Just much more general and also very easy to support discreet values case.
Also I indeed used a continuous scaling so that when zoomed out the chart was scaled smoothly to the next aggregation level. It was a matter of controlling what those end-point scaling factors might be depending on the current aggregation level as they were non-linear.
As for @mbostock comment above, I do not understand why supplying custom scaling function would not be suitable for continuous mousewheel  gestures? With appropriate context supplied to the scaling function it could always at least behave exactly as the algorithm that is currently implemented, no?.
It seems to me that this scaling factor control is sometimes useful for some users (judging from those few PRs), although probably not that often, and if done well it should be absolutely harmless and unobtrusive to all.
Is it a worthy feature to add to API? I do not know, it is definitely nonessential, but I remember I felt a little bit disappointed that I could not do what I wanted with zoom behavior. You can control almost every computational aspect through this beautiful and simplistic API in d3, why can't You control just that?

My first concern with both of these proposals is whether it’s better to intercept the input events yourself and then change the scale of the zoom behavior, rather than letting the zoom behavior handle the input events while exposing hooks for how the zoom behavior computes the new zoom level.

Well when I think of it now, it does seem to be relatively easy to intercept input events, if slightly more difficult with the mousewheel, and simply use zoom.scale() to achieve custom scaling...
There is quite some code in zoom behavior source that deals exclusively with input events, so re-implementing that is not trivial but one can always reach for the code provided there to speed things up. It just seemed much easier to me at the time to patch d3 instead of re-implementing it altogether but now I am not sure whether this is worth it and whether there is a really good way of customizing scaling algorithms in that manner... After all if one wanted to do some more animation oriented and dynamic zooming it would probably be impossible to do properly without intercepting input events anyway.
If Your @mbostock concern is that this feature would bloat the API, which is a very important concern IMO, I will not insist on including this feature. I will close this PR for now, since the code needed work anyway. Thanks for the discussion and for Your insights.


Preprocessing videos: paper vs this implementation

I'm reading through the LipNet paper and trying to determine whether we're doing the preprocessing described there.
The things that stood out to me were:

“we train on both the regular and the horizontally mirrored image sequence”
The implementation seems a bit different--see the last question here.

“We augment the sentence-level training data with video clips of individual words as additional training instances.  These instances have a decay rate of 0.925”
This looks like it isn't currently in place in the non-curriculum training, since 'sentence_length' is -1 in unseen_speakers/train.py and overlapped_speakers/train.py, but by modifying this value we have the capability to train on different sentence lengths (though currently each epoch would have sentences of all the same length?)

“To encourage resilience to varying motion speeds by deletion and duplication of frames, this is performed with a per-frame probability of 0.05”
This looks done, with the deletion/duplication code in in videos.temporal_jitter()!

“We standardize the RGB channels over the whole training set to have zero mean and unit variance”
I found the line X_data = np.array(X_data).astype(np.float32) / 255 # Normalize image data to [0,1], TODO: mean normalization over training data in generators.py, sounds like it needs to be done :)

Is this an accurate description of the state of the project?

Yeah, all of that is correct.
(2) I have tried to clarify the meaning of the "decay rate" to the paper's author, but haven't gotten the answer yet. The current implementation allows us to tweak the length of the sentence arbitrarily, as to allow for more general variations of training. You may use curriculum learning to define how that should behave.
(4) This one should be very simple to implement. I leave the implementation that way to minimize the amount of computation that needs to be performed before each experiment. And I also personally don't think that it was required, as we would have computed per batch normalized data using Batch Normalization.


Required Help to Integration MS Bot framework + Node JS + Heroku

Please provide me guidelines to do the above mentioned combination that i am using Microsoft bot framework in node js language where i am planning to deploy it in heroku.

The same way you do to deploy any other node application on Heroku. You just need to change the endpoint on registered bot in Bot Framework Portal to point to your Heroku address.
e.g.: https://myapp.herokuapp.com/botframework/receive


How to deploy?

Hello, everyone!
I create a web site using laravel & inertia-vue. now I want to deploy it on a live server but I can't. can anyone provide me a solution.

What errors are you facing?

There is nothing particularly unique on the hosting side of things when it comes to Inertia apps. Simply deploy it as you would a standard Laravel/Vue application. I'd recommend looking into the Laravel documentation.
If you have any particular issues you're facing, feel free to post them here and we'll be happy to help. I am going to close this for now though, since I don't think this an Inertia issue.

Nice question!
I think a simple tutorial on some cloud provider like Digital Ocean or Linode would be very helpfull.
I DON'T use Inertia because I can't get it deployed on a Digital Ocean droplet.
I spent 4 months learning this Master Piece and got know idea how to deploy it on production. LoL.
I think most Gods of OpenSource (since they are special species) forget that most people are dummy like me!


Support any tiff file and gracefully handle missing geotiff data

If a tiff file without geotiff tags is loaded the latitude and longitude are filled with the number of rows and columns.  They should rather be filled with NA and eventually allow user editing to fill them in.

Fix pushed to my feature branch with a pull request created.

Tested on dev and everything works as expected now. Set ready for testing label to be tested on dev.

Incorrect and invalid north latitude and east longitude were still filled in on my test.  These should be NA.

Also the labeling of resource specific coordinates is incorrect.  The terms latitude and longitude should not be used to refer to projected quantities.  See the following suggested edits.

See following Alfresco document for details on editable fields for raster resource https://my.alfresco.com/share/s/DeXkAhEgS8GjrgTWOSpp0w

The problem of Spatial Reference Holding Spurious information when it is missing still persists.

Tested on dev and it appears this issue is fixed, so set it as ready for testing.

I tested this and it does not seem quite right.  When I loaded the Honduras tif file (which you can see at https://www.hydroshare.org/resource/c81142cbe23548718657c34099c3b254/) the coverage metadata tab is missing and under resource specific the cell sizes are 0.  In the current implementation on www the coverage element is there but with NA, and the cell sizes are 1.  This seems preferable to me.

@dtarb: @gantian127 indicated she had discussed this with you, and you kind of agreed what is currently on dev now sounds acceptable and right. I also agree what is on dev now seems to look reasonable with coverage tab missing when coverage info does not exist, and user always can edit the metadata and add coverage info as needed. @gantian127 will work on any further issues related to this if any. So I am assigning this issue to @gantian127 although this issue might be ready to close.

@dtarb @gantian127 Can this issue be closed?


Confusing elided-lifetimes-in-paths lint in bridge

Building the demo with -W elided-lifetimes-in-paths results in the following:
warning: hidden lifetime parameters in types are deprecated
  --> demo/src/main.rs:22:63
   |
22 |         fn new_blobstore_client() -> UniquePtr<BlobstoreClient>;
   |                                                               ^- help: indicate the anonymous lifetime: `<'_>`
   |
   = note: requested on the command line with `-W elided-lifetimes-in-paths`

warning: 1 warning emitted

However, neither cxx::UniquePtr nor BlobstoreClient have a lifetime parameter, so of course trying to add one is an error (and of course the lint still triggers too):
warning: hidden lifetime parameters in types are deprecated
  --> demo/src/main.rs:22:66
   |
22 |         fn new_blobstore_client() -> UniquePtr<BlobstoreClient<'_>>;
   |                                                                  ^^- help: indicate the anonymous lifetime: `<'_>`
   |
   = note: requested on the command line with `-W elided-lifetimes-in-paths`

error[E0106]: missing lifetime specifier
  --> demo/src/main.rs:22:64
   |
22 |         fn new_blobstore_client() -> UniquePtr<BlobstoreClient<'_>>;
   |                                                                ^^ expected named lifetime parameter
   |
   = help: this function's return type contains a borrowed value, but there is no value for it to be borrowed from
help: consider using the `'static` lifetime
   |
22 |         fn new_blobstore_client() -> UniquePtr<BlobstoreClient<'static>>;
   |                                                                ^^^^^^^

error[E0107]: this struct takes 0 lifetime arguments but 1 lifetime argument was supplied
  --> demo/src/main.rs:22:48
   |
22 |         fn new_blobstore_client() -> UniquePtr<BlobstoreClient<'_>>;
   |                                                ^^^^^^^^^^^^^^^---- help: remove these generics
   |                                                |
   |                                                expected 0 lifetime arguments
   |
note: struct defined here, with 0 lifetime parameters
  --> demo/src/main.rs:20:14
   |
20 |         type BlobstoreClient;
   |              ^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors; 1 warning emitted

Looking at the expanded output with cargo expand, I don't see any clues as to what missing anonymous lifetime the compiler might be intending to flag here. It's unclear to me if this is a lint bug, if the compiler diagnostic is just confusing due to the cxx::bridge proc macro, or something else.
This is an issue for us because our codebase uses both -W rust_2018_idioms and -D warnings by default. Worse, elided-lifetimes-in-paths can only be allowed at the crate level (https://github.com/rust-lang/rust/issues/71957) so we can't just allow it for the cxx::bridge module.

Ahhhh, I see what it's trying to indicate now. It's complaining about the generated UniquePtrTarget for BlobstoreClient impl, which includes a std::fmt::Formatter type that is missing the anonymous lifetime. Ok, that should be easily fixable.

I'm running into the same issue and wondering if there is any workaround for this?
@sbrocket
How did you go about fixing it?

I am not a fan of this lint and I don't think codebases should use it, but I've published support for it in 1.0.60.

Thanks for the fix. I’m not a fan of the lint either, but it’s grouped in  rust_2018_idioms and we get it from there, so it fits someone’s definition
of “idiomatic” 2018 edition usage.
On Fri, Dec 10, 2021 at 1:39 PM David Tolnay @.***>
wrote:

I am not a fan of this lint and I don't think codebases should use it, but
I've published support for it in 1.0.60.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtolnay/cxx/issues/907#issuecomment-991313362, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAEIBAN6JWAP3LEL2UCW2LUQJXP7ANCNFSM5BNVQRJA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Specify --mining-threads 1 in CI to see if execution will be faster

Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

For full LLVM coverage report click here!

https://github.com/gluwa/creditcoin/actions/runs/3418475302/jobs/5690817288 - took 11:27 mins to execute integration tests
https://github.com/gluwa/creditcoin/actions/runs/3363101584/jobs/5575756254 (older CI job) - took 10:24 mins to execute integration tests.
This change doesn't seem to have any effect.


Adding LisiasT's KSP-Recall to CKAN

Thank you.

The errors are here:

https://ci.ksp-ckan.space/job/NetKAN/9669/console

Enable edits by maintainers for help.

Damn it, I need to remember running NETKAN before submitting.
I'm trying to find where to allow maintainers edit, but this option doesn't appears to me. Parhaps a paid only option?
In a way or another, silly mistakes easily caught by NETKAN should render a kick on my balls, otherwise I will commit this mistake again - sometimes I do personal activities late night, when I mainly work by "muscle memory" - I need to internalize the need of using netkan.exe before submitting pull requests.
It would make your life easier.
Thanks for your efforts.

And I just burnt my dinner again....

Well, submitting the PR runs netkan in a container anyway, so if it's easier this way, that's fine.
The last thing I'd say is that the current abstract doesn't give me a strong sense of when I would want to install this. Is it stock bug fixes a la the old StockBugFixModules? Does it help me to fix my mistakes and blunders while flying ships? What's the angle?

(I will update the Add'On description to make it clear it also fixes some things without being called by third parties, thanks for that advice - it is not clear enough at the present time.

How many chars is considered acceptable on the abstract?

Schema:
        "abstract" : {
            "description" : "Short description of the mod",
            "type"        : "string"
        },
        "description" : {
            "description" : "Longer description of the mod",
            "type"        : "string"
        },

Spec:
##### abstract

A short, one line description of the mod and what it does.

So there isn't a specific character limit, but it should be a quick summary that the user can browse easily.

Updated the abstract. What you think?

So it is stock bug fixes a la the old StockBugFixModules? Just trying to make sure I understand.

Calling them fixes is a bit too much, because most of the time I will work around the bugs - reimplementing small bits of the feature, and then intercepting KSP events to trigger my reimplementation to overwrite the mishap.
On the specific case of the Resources on the 1.9.x, I detect when the Ship is changed, identify if a part had its resources changed (using the last known status quo for that part) and if yes, update an internal copy of that ResourceList. And then overwrite that list back when the Editor resets the Resource of a part (and when cloning parts using Alt+Click)
Some add'ons may need to call the event themselves, if they do a change without triggering the OnEditorShipChanged (as TweakScale), these ones will need to call the update event manually.
But this is what is being done now. There's at least two more workarounds on the plan - assuming that I manage to implement them, of course! :)

OK, everything looks in order now! Thanks for the submission, merging...

I'm trying to find where to allow maintainers edit, but this option doesn't appears to me. Parhaps a paid only option?

It's not paid-only, I don't pay GitHub anything and I don't think the CKAN project does either.
Here's where it appears while you're creating the pull request:


Fix reset-font-size

Identify the Bug
#9873
Description of the Change
If the user config is yet to be loaded oldValue equals the default font size 14px. This breaks the reset font size functionality. Fetching the font-size from the config object instead of using oldValue seems to fix the issue. I'm running:
macOS: 10.14.3
Node: v11.14.0
npm: 6.9.0
Alternate Designs
Not sure if this fix is needed at all TBH. It has been pointed out that it works fine on Windows and I know this has worked in previous versions of Atom on macOS as well. It could be an issue where the configuration hasn't yet be loaded for some reason.
Possible Drawbacks
N/A
Verification Process

Set the configured font size to e.g. 10
Increase or decrease the editor font size multiple times
Reset the font size window:reset-font-size
The font size should equal 10

Release Notes

Fix reset font size behaviour

One of the AppVeyor tests seem to fail. It seems unrelated to this pull request.

The AppVeyor tests failed. It seems unrelated to this pull request. Right?

Yes; this is another instance of #18991.

@50Wliu is there something I can on my end to rerun the tests without having to close and open the pull request? Just want to get rid of the red cross.

I restarted it :+1:

Thanks a lot for the contribution! Codewise it looks good to me, can you add a test to verify that the behaviour does not regress in the future? 🤗

Thanks for taking a look at the PR @rafeca!
I would like to add tests but I'm not really sure how I can replicate the behaviour since it now works as expected. It should be covered with this test:
https://github.com/atom/atom/blob/cdb5ac98caa511d7f157c7a91297d40eea40044f/spec/workspace-spec.js#L1729-L1730
What is expected is that we should only save the originalFontSize when the user updates the font size through the editor settings page. Right now the oldValue always returns 14 and ignores the user settings.

Ok nevermind, let's just merge this one then :shipit:


envoy filter proxy version match optimization

alternative way of doing https://github.com/istio/istio/pull/21325

@rshriram: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-local-tests_istio

unit-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test unit-tests_istio

lint_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test lint_istio

release-test_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test release-test_istio

integ-mixer-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-security-k8s-tests_istio

integ-galley-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
943018314f2e965907a6c253212d6b55f5d9ae71
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I don't think this is really moving us in the right direction. We're waiting on xDS client capabilities feature to make it through envoy, to properly provide semantic capabilities. The fact that it is a regex is a temporary, but useful, workaround.

I really don't think we should change the semantics of an existing api, alpha or not.

the whole point of keeping EnvoyFilter as perpetual alpha is so that we will not be over burdened by these API guarantees. The entire thing is internal detail (proxy version format inclusive). So we have the freedom to change as needed. This is no different from changing the route object name format or the filter chain name format.

We used to have language to say that EnvoyFilter was a perpetual alpha and
it was recently removed -- now it just says that the XDS config we are
applying patches to is subject to change, it does not say the API itself is
alpha.
On Mon, Feb 24, 2020 at 10:24 AM Shriram Rajagopalan <
<EMAIL_ADDRESS>wrote:

I really don't think we should change the semantics of an existing api,
alpha or not.
the whole point of keeping EnvoyFilter as perpetual alpha is so that we
will not be over burdened by these API guarantees. The entire thing is
internal detail (proxy version format inclusive). So we have the freedom to
change as needed. This is no different from changing the route object name
format or the filter chain name format.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/21416?email_source=notifications&email_token=AAEYGXNLH6W3SNPO5CY6733REQGGNA5CNFSM4K2NAEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMY7U6I#issuecomment-590477945,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJKZWXHZUSKKRHWRE3REQGGNANCNFSM4K2NAEVA
.

@rshriram Alpha does not mean it's OK to make breaking changes in the middle of the release. We have high-level features (telemetry v2) that depend on this API.
Can you just use caret to optimize the regex (e.g. ^1\.4\.)?

Let me see what happens with just the caret
On Mon, Feb 24, 2020 at 11:05 AM Kuat<EMAIL_ADDRESS>wrote:

@rshriram https://github.com/rshriram Alpha does not mean it's OK to
make breaking changes in the middle of the release. We have high-level
features (telemetry v2) that depend on this API.
Can you just use caret to optimize the regex (e.g. ^1.4.)?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/21416?email_source=notifications&email_token=AAEYGXNVVH73DPSLXD4J2CDREQK5XA5CNFSM4K2NAEVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZEEAQ#issuecomment-590496258,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXPSCRGIZ7CZBKHSL23REQK5XANCNFSM4K2NAEVA
.

As mentioned in https://github.com/istio/istio/pull/21325, the caret surprisingly does not improve this much

@rshriram Alpha does not mean it's OK to make breaking changes in the middle of the release. We have high-level features (telemetry v2) that depend on this API.

this change is backwards compatible - has hacks specifically for telemetry v2 from 1.4 series. The only question is if we will honor other users who may/may not be using this field. It is better to change early than late IMO.

@rshriram: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alternative was merged. thanks for the help


upload workflow

Another question is: do you intend to merge our changes directly to main, or create a long-lived "solarwinds" branch that would hold our custom code? The latter would require more branch management but allow us better control on what upstream pieces to merge in, visibility and code review of our changes (for example add a CODEOWNERS file for our branch).

Yes, I intend to merge to main.
To update with upstream, we just need to pull, and since these workflow files are new, so there won't be any file conflict.
For every new feature we have, I can create gem based on separate branches (these branches certainly will be up-to-dated with upstream)


Does the code of  StimulusVerification support the stimulus_type "both", i.e., "context+social"?

Thank you for providing the wonderful codes for modular trajectory prediction. I am trying to develop my code based on StimulusVerification. In Table 1 of the paper, it is possible to jointly consider the stimuls types "context" and "social". However, in the code, there is no such choice for "both". Since "context+social" achieves the most significant improvement in the paper, I wonder if it is easy to do this within the code you provide. Thanks in advance!

Hi, thank you for your interest in our work!
In verify_predictions.py, a list named all_verification_scores is defined at L61, which is used later to store both context and social compatibility scores, the scores are then added together in L235, i.e. verification with context+social.
Hope this answers your question.


Clean up usage of populate method

At the moment you cannot just assume this will work:
$db->table('table')->find(1)->populate(Thing::class);

As find() could return null.
Investigate cleaner solution.

use SimpleDb\Database;
$db = new Database('root:password@localhost/vokuro');
$db->table('user')->find(1)->populate(User::class);

The table 'user' is not empty.
Fatal error:  Uncaught Error: Call to a member function populate() on null
Also I did not find this function 'populate' in your source.

@DmitriyLanchakov This functionality exists in the 2.x releases. There is no written guide for the 3.x release set yet but your example would be done like:
$db = new Database('root:password@localhost/vokuro');

$user = User::find(1); // or
$user = User::from($db->table('users')->find(1));


logs table migration: skip on corrupted json and fail later

enhance  #1828

Codecov Report
Patch coverage: 45.45% and no project coverage change.

Comparison is base (ff01a9f) 39.25% compared to head (02da810) 39.26%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1856   +/-   ##
=======================================
  Coverage   39.25%   39.26%
=======================================
  Files         173      173
  Lines       10625    10633    +8
=======================================
+ Hits         4171     4175    +4
- Misses       6174     6177    +3
- Partials      280      281    +1

Impacted Files
Coverage Δ

.../store/datastore/migration/019_alter_logs_table.go
54.44% <45.45%> (-0.44%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Windows Support - Pandiff returned empty

The following issue was encountered in a VM running Tiny10 23H2 (x64), a stripped-down version of Win10, after installing Pandoc and Git for Windows via the default installation methods.  Additionally, it was ensured that the git and pandoc commands were accessible through the Windows PowerShell and Git Bash terminals wrapped inside VS Code.
Steps to reproduce:

Launch VS Code
Install Pandiff - Enriched Text Difference
Run 'Select two files for comparison via the Command Pallet
Select two different files
Throws  Pandiff returned empty

Which means the function runPandiffAndGetContent(file1.detail!,file2.detail!) is failing to write the tmp file or read it. Inner function debug is needed.

Adding the following code inside runPandiffAndGetContent resolves the problem with pandiff:
if(process.platform === 'win32' ){
            f1Path = vscode.Uri.file(f1Path).fsPath
            f2Path = vscode.Uri.file(f2Path).fsPath
        }

Since git is having the same problem of path resolution, its better to refactor all function that uses stringified versions of paths to use the vscode.Uri interface

Commit https://github.com/carafelix/pandiff-vscode/commit/84e62e6794de3bbc71f44612d675e40c01d473da implemented the aforementioned hotfix solution. Refactor of the codebase was moved into #3


Grid -  GroupView

Could we have in one of the next versions an  GroupView?
Vou can see here  what I mean.

Yes. This already in our backlog. We are going to add that in future versions.
I will leave this ticket open, until we add this feature.

We released a new version where this feature is available. You can see a demo at http://gijgo.com/grid/demos/grouping


Refactor validaton package

as title

->   #19479

Is this still WIP?

No time until next thusday to work on anything ...

Stale for long time, is it still in progress?
IIRC this is for some security problems, while these security problems have been fixed?

Kindly second ping ~~~

Maybe this PR could be closed? Feel free to complete the description and reopen.


Use basePath from schema when URL matching

https://github.com/gargol/swagger-express-validator/issues/1

nice work! goes straight into master. have an awesome weekend :)


Cloudmin Backup Schedule

The Cloudmin backup schedule popup window doesn't show the previously saved time selection.
It would be nice if the text could show on the actual Cloudmin backup page rather than having to popup the chooser window to see what it is.

Hi, Steff.
Do you man on this page?

It would be nice if the text could show on the actual Cloudmin backup page rather than having to popup the chooser window to see what it is.

I am not sure what you mean? It's standard behavior provided by Cloudmin itself?

Yes.

They are no longer set to the previous settings when shown.
I was saying it would be nice if whatever was in the dialog above was shown in plain text so the popup was not needed. I'm no cron guru to know what 5 0 * * 0,3 means. (the numbers in the pic)

Actually I fixed that in the near future, but it's on the latest theme, remember?
Could you update and see if you still have this issue?

I force updated to the beta and it works. Might be time to publish it.

I force updated to the beta and it works. Might be time to publish it.

Will do. Thanks, Steff!


Team update - May 24, 2023

This is a @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.
Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with foo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...

**My availability for next week**
- I'll be off on foo day...

**Important items for discussion 💬**
- I have a question about goal <link-to-goal>
- Can @foo give a comment on issue #NN ?
- I opened #NN for discussion, please chime in
- I need to discuss foo

:mag: Needs Triage
The Needs Triage issues require an initial assessment and labeling.
No issues need triage! 🎉
:dart: Project boards
Please make sure the boards reflect the current status of the project.
Jupyter a11y grant project

Thanks I'd like to give 🙌
Thanks to @trallard for help wrapping up testing logistics!
Updates from last week :heavy_check_mark:

#184 Finishing logistics and payment.
#147 (and also #18) test 2 results updated with issues found during the test. I also finished writing test 2 related issues finally.
Reviewed @steff456's open PRs on jupyter/accessibility.

Challenges I faced and things I'd like assistance with 🙏

I don't have anything right now.

My availability for next week

I'll be here all week.

Important items for discussion 💬

I don't think I have anything right now.

Thanks I'd like to give 🙌

@isabela-pf for timely and thoughtful encouragement
@steff456 also for team spirit and support at JupyterCon

Updates from last week :heavy_check_mark:
This week I worked on finishing the accessibility test I introduced at JupyterCon (focus visible):

https://github.com/Quansight-Labs/jupyter-a11y-testing/pull/33

I spent most of my time this week trying to fix focus issues in the Lumino MenuBar class (PR forthcoming)
Challenges I faced and things I'd like assistance with 🙏

A little under the weather this week, so a bit slower going than normal

My availability for next week

I'll be off tomorrow / Friday!


dynamic pivpn user home

Let's take into consideration the posibility that pivpn user won't be always in /home, and the use of other locations like /usr/local is possible.

Nice work, and well thought, however, I don't consider it a good option for a few reasons, most of them related to security.
1 - OVPN files are very sensitive files, so It is never a good idea to give them chmod 777 as you are doing in line 108 of install.sh, it should be at the most 660.
2 - It's well known and supposed to be common sense, that no one should ssh as root, having this said, it's recommended to have at least one unprivileged user, to access via ssh and then scale privileges either using sudo or su to become root, so the standard place for its home should be /home/$USER so makes sense to give the OVPNS to a user and only that user and root could reach those files, no one else on the system.
What I consider to be some good solutions to overcome the issue of users giving the wrong user to hold the OVPN files rather than supporting a dynamic home directory:
1 - detect available users, and check if there's a home directory for that user before presenting it to a user to choose.
2 - Create PiVPN user with password to hold the files, which eliminates the need for any user installing to choose a user and providing the wrong one, which makes a litle bit more secure to keep the OVPN files.
3 - Place the OVPN files in a fixed directory, and only a privileged user ( root or sudo ) can access to them, which can be a bit more problematic to overcome the file permissions in this case.
don't take me wrong, you did a good job, this is just my considerations, about it.
@redfast00 and @0-kaladin have the word here! ;)

@cfcolaco Thanks for the feedback.
I updated my branch with /home/$USER permissions I consider more suitable, but the main repo will need that as well.
Just to through my 0011 cents, I like your suggestion. I would cross out option 1 and go straight to option 2. The PiVPN user will be created anyways if it doesn't exist, so I'd get rid of the username prompt.

@orttez wait for @redfast00 or @0-kaladin come around here they might have a different opinion or something already in mind for that! =)

@redfast00 @0-kaladin what about this PR??

@redfast00 @0-kaladin shall we close this PR.. and open a ticket to find a better solution for this??

Yeah, sure. I think your suggestions are quite good, so please copy them over in the issue as well.


How to check if day.owner is from DayOwner.NEXT_MONTH?

Hi,
I have a condition to show user current month and next month only to add events, and in current month i don't allow user add event on past day like this:
if (day.day < currentDate)      toast("You can not add events on past days.") else      toast("You can add events on this day")
the problem i am facing is that when i scroll to next month and click on date to add event it goes to if (day.owner == DayOwner.THIS_MONTH) and i have also added the condition if (day.owner == DayOwner.NEXT_MONTH) but it does not check this condition how can i fulfill this condition?
I hope my question is clear to you :)

To be clear, do you want to be able to add events in the next month when you scroll?

Thanks for reply, I managed this myself :)


sample multiple datasets

Hi
I am dealing with multiple datasets, I need to have a dataloader over them with a condition that in each batch data samples are coming from one of the datasets. My main question is:

I need to have a way to sample the datasets first with some weights, lets say 2x dataset1 1x dataset2, could you point me how I can do it

sub-questions:

I want to concat sampled datasets and define one dataloader on it, then I need a way to make sure batches come from 1 dataset in each iteration, could you assist me how I can do?
I use iterative-type of datasets, but I need a method of shuffling still since it brings accuracy performance issues if not doing it, thanks for the help.

here I share my dataloader currently for multiple tasks: https://gist.github.com/rabeehkarimimahabadi/39f9444a4fb6f53dcc4fca5d73bf8195
I need to train my model distributedly with this dataloader, "MultiTasksataloader", currently this does not work in distributed fasion,
to save on memory I tried to use iterative datasets, could you have a look in this dataloader and tell me if this is indeed the case? not sure how to make datasets being iterative to not load them in memory, then I remove the sampler for dataloader, and shard the data per core, could you tell me please how I should implement this case in datasets library? and how do you find my implementation in terms of correctness? thanks

Hi @rabeehkarimimahabadi any luck with updating the multi-task data loader to work with distributed training?

Hi @pushkalkatara yes I solved it back then, here please find my implementation https://github.com/rabeehk/hyperformer/blob/main/hyperformer/data/multitask_sampler.py

Thanks @rabeehk for sharing.
The sampler basically returns a list of integers to sample from each task's dataset. I was wondering how to use it with two torch.Dataset of different tasks. Also, do I need to shard across processes while creating an Iterable Dataset?

We now have interleave_datasets in the API that allows you to cycle/sample with probabilities (with various stopping strategies) through a list of datasets. However, more specific behavior should be implemented manually.

Hi @mariosasko, @pushkalkatara
I have multi dataset for ASR task. I have multilingual such as: English, China, Japan, Vietnamese. Each dataset is loaded as dataset. Now I training, I want to equal sampler, it means each batch loader in training has equal number sampler in each language.
For example: Batch_size = 16:
English sample:4
China sample:4
Japan sample:4
Vietnamese sample:4
How can I do it? I saw that  interleave_datasets only splits data with probability an concatenates all of them after that, it not affect in training data loader. Forgiving me if I wrong.
Thank you for your help.


Better search result snippet

As a search engine, I want a better description of the front page which I can use in search results.

https://developers.google.com/search/docs/guides/mark-up-content


ACM-4237 Shows upgrade available under distribution version

Backport of https://github.com/stolostron/console/pull/2530

/retest

/retest


Game Select dropdown

Also fixes a bug when launching the client from the Command Line.

How does it look and work if you have way too many manual installed?
Leaving the text input to work as a search field might be a good idea.

We should probably tweak this a bit visually, too. The spinner options when shown have an inconsistent height compared to the spinner, and they're also the same color as the spinner (and the tabs underneath). We could probably go with a bit darker background on the options to visually distinguish them.

small issue with this if tracker is on thats what is loaded instead of manual client

I agree with both of these. Kivy does not make either easy.

Made them shorter, sorted alphabetically, and slightly darker.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.8 to before v4.19.222",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8bec4337ad4023b26de35d3b0c3a3b2735ffc5c7",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7e8645ca2c0046f7cd2f0f7d569fc036c8abaedb"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "8bec4337ad4023b26de35d3b0c3a3b2735ffc5c7",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "7e8645ca2c0046f7cd2f0f7d569fc036c8abaedb",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "firmware: arm_scpi: Fix string overflow in SCPI genpd driver\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.19.222 by commit 7e8645ca2c0046f7cd2f0f7d569fc036c8abaedb, it was introduced in version v4.8 by commit 8bec4337ad4023b26de35d3b0c3a3b2735ffc5c7. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002645


Cleaning browser storage

Hi everyone,
How would you purge the storage (localStorage, sessionStorage) using serenity?
I tried several task variations but always struggle with browser.executeScript('window.localStorage.clear();') not being an Activity basically. What would be your advise?
In general I feel like usecases such as cleaning cookeis or storage are important parts of a scenario, and as thus, if we find a solution for that, it would be worth getting it's own documentation page :).

What worked for me was this:
export class Authenticate implements Task {
  private static cleanTheBrowser() {
    return browser.driver.manage().deleteAllCookies();
  }

  @step('{0} authenticates himself in the platform')
  performAs(actor: PerformsTasks): PromiseLike<void> {
    const credentials = this.searchCredentialsFor(this.name);

    return new Promise<void>((resolve) => {
      Authenticate.cleanTheBrowser()
        .then(resolve);
      })
      .then(() => actor.attemptsTo(
        // Other commands to interact with the login form
      ));
  }

  // Other commands to interact with the login form
}

The key there was to treat the deletion of cookies as a promise. I don't have errors from web driver so far.

Hey @san-ouadghiri - you're on the right track! Check out the new TodoMVC demo project:
import { Task } from '@serenity-js/core';
import { ExecuteScript } from '@serenity-js/protractor';

export const ClearLocalStorage = () =>
    Task.where(`#actor clears local storage`,
        ExecuteScript.sync('window.localStorage.clear()'),
    );

To delete cookies use the DeleteCookies interaction.
Hope this helps!
Jan


Fix margin/padding on sponsoring page

add class to sponsor package cards
adapt CSS

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0%) to 96.975%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0%

Covered Lines:
3760

Relevant Lines:
3869

💛  - Coveralls


PSA: Use Moonjit in Regent for PPC64le

I was recently made aware of a LuaJIT fork called Moonjit that supports PPC64le. I have successfully used this fork to test Regent on PPC64le, and it passes all tests.
I would like some users with larger Regent codes to test them on PPC64le using this branch. In order to do this, you will need my fork of Terra here: https://github.com/elliottslaughter/terra with branch moonjit.
Assuming this works out I intend to make Moonjit the de-facto way to run Regent on PPC64le.

I'll try running soleil with this on Summit and let you know how it goes.

I was able to build and run Soleil on Summit with moonjit. I built Regent as follows:
USE_CMAKE=1 USE_CUDA=1 USE_OPENMP=1 USE_GASNET=1 USE_HDF=1 bsub -W 60 -nnodes 1 -P CSC397 -I scripts/setup_env.py --llvm-version 60 --terra-url https://github.com/elliottslaughter/terra --terra-branch moonjit

This merged upstream into Terra master.


htbf2019

@strifeex  try this year for Hacktoberfest and have a look at the updated repo and contribute.
HAPPY HACKING


Dracula for st

New Theme
I've ported the dracula theme to the awesome terminal emulator st

Here is my repository

Hey @jelohe, would you be interested in moving this theme to the official organization? You would still be the owner and maintainer, but the repo would live under https://github.com/dracula.
Let me know and I'll send further instructions.

Looks like the content of the repo and the suckless patch are identical. https://st.suckless.org/patches/dracula/
Would it make sense to link to the patch from the draculatheme website?


Remove colab dependency violation check

Now that we have colab like test, this old approximation is no longer necessary as the new tests should catch any fatal conflicts.

Could we keep it for a week or two to see if the new solution is actually much better at catching issues?

@micheldlebeau shall we merge this one now? We've had one false positives in this test already on a PR


DaCe GPU backend either crashes or gives compilation errors for hdiff benchmark

Hi, I'm trying to run the "hdiff" benchmark for different backends, but I run into a segfault if I set DACE_CONFIG. The cuda arch is set to "86" for A6000 GPU based on the information given here.
dace.conf file:
compiler:
  cpu:
   executable: 'nvc++'
   args: -std=c++14 -fPIC -O3
  cuda:
    cuda_arch: '86'
    default_block_size: 32, 4, 4
  use_cache: true

If I unset DACE_CONFIG, I get the attached error t.txt. My cudatoolkit version is 11.7.1 and cuda-version is 11.7
The DaCe CPU version works fine for me.
Could someone tell me what's missing in my setup/environment?

Thank you for reporting. This seems to have something to do with duplicate CUB installations. Which revision of DaCe are you using?

I'm using 0.14.4

Here's the list of packages in my Conda environment, if that helps. I don't see CUB installed. am I missing something?
t.txt

@tbennun mentioned that the fix for this issue is here, and that it didn't make it to 0.14.4. I installed the latest version from master and that seems to work. I don't even need the dace configuration file anymore.
Thanks for the quick followup!


Check MSSQL with windows authentication

Affected module
Ingestion Framework
Describe the bug
Check MSSQL with windows authentication
slack thread: https://openmetadata.slack.com/archives/C02B6955S4S/p1659447513402549

I will take this issue.

hi @NiharDoshi99 do you have any updates on this? Would you need any help? It would be great to ship this for 0.12 as some users are relying on this change.
Thanks!

Hi @pmbrull , working on https://github.com/open-metadata/OpenMetadata/issues/6563 it will be completed by today. Will take the above issue after that.

perfect thanks


Error with example

Hello,
when i run your example
from googleplaces import GooglePlaces, types, lang

YOUR_API_KEY = 'my_key'

google_places = GooglePlaces(YOUR_API_KEY)

query_result = google_places.nearby_search(
        location='London, England', keyword='Fish and Chips',
        radius=20000, types=[types.TYPE_FOOD])

i am getting this error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/googleplaces/__init__.py", line 542, in _generate_lat_lng_string
    else geocode_location(location))
  File "/usr/local/lib/python3.4/dist-packages/googleplaces/__init__.py", line 103, in geocode_location
    {'address': location, 'sensor': str(sensor).lower()})
  File "/usr/local/lib/python3.4/dist-packages/googleplaces/__init__.py", line 71, in _fetch_remote_json
    request_url, response = _fetch_remote(service_url, params, use_http_post)
  File "/usr/local/lib/python3.4/dist-packages/googleplaces/__init__.py", line 54, in _fetch_remote
    if type(v) in [str, unicode]:
NameError: name 'unicode' is not defined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/klofisch/PycharmProjects/Gmaps/Test01/test01.py", line 22, in <module>
    radius=20000, types=[types.TYPE_FOOD])
  File "/usr/local/lib/python3.4/dist-packages/googleplaces/__init__.py", line 260, in nearby_search
    lat_lng_str = self._generate_lat_lng_string(lat_lng, location)
  File "/usr/local/lib/python3.4/dist-packages/googleplaces/__init__.py", line 545, in _generate_lat_lng_string
    'lat_lng must be a dict with the keys, \'lat\' and \'lng\'')
ValueError: lat_lng must be a dict with the keys, 'lat' and 'lng'

I have the same issue.  Anyone has any idea how to fix this?

I'm looking at thios now. You guys are using python3, right?

I am facing the same prob.- " ValueError: lat_lng must be a dict with the keys, 'lat' and 'lng' ," since today.
I tried passing lat and lng as a dict with appropriate values and still the same problem.

I am also seeing the second half of the reported issue:
Traceback (most recent call last):
File "/home/klofisch/PycharmProjects/Gmaps/Test01/test01.py", line 22, in
radius=20000, types=[types.TYPE_FOOD])
File "/usr/local/lib/python3.4/dist-packages/googleplaces/init.py", line 260, in nearby_search
lat_lng_str = self._generate_lat_lng_string(lat_lng, location)
File "/usr/local/lib/python3.4/dist-packages/googleplaces/init.py", line 545, in _generate_lat_lng_string
'lat_lng must be a dict with the keys, 'lat' and 'lng'')
ValueError: lat_lng must be a dict with the keys, 'lat' and 'lng'
However, this only happens on one of my two computers, my other computer with the same exact version of python works flawlessly. Not sure what to say...

The issue seems to be resulted by incompatibility with Python 3. I tried to execute it with Python 2.7 and it works fine.
The unicode function is not part of the standard library for Python 3, and one of the potential fixes is to use a unicode = str workaround for Python 3.
After fixing this, there also seems to be an issue with the urllib module not having the urlencode function in Python 3.

Hello. There is already a pull request to fix py3 support: https://github.com/slimkrazy/python-google-places/pull/38
Please consider merging this pull request. Thanks!

I am facing the same problem, but I am running Python 2.7.
Strangely enough, the script was executing just fine this past week, and suddenly started raising this error.

I also originally  faced the problem in Python 2.7. I tried out Python 3.3 as well with the same exact error.

I am having the same problem on Python 2.7. The script was running fine and was actually in the middle of a large job when it started raising this error.  Has a solution been found yet?

Same problem here with python 3.4 ...

This has been resolved by merging in #38.
The changes are currently on the development branch. I am attempting to address a few issues today before merging to master and releasing over the next day or so.

Fixed and released in v1.1.0

This error points to your radius=50000 when the '''ValueError: lat_lng must be a dict with the keys, 'lat' and 'lng' ''' error is given. Basically, this says that the given location doesn't have a given Latitude and Longitude for your specified search relating to that area and therefore cannot draw a radius around that area because it doesn't have a point (lat,lng) in the google database to start from. Make sense?