pull request for e2e test at 01/25/2017 09:15:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


💡 [FEATURE] -Adding OS resource to the repo

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
OS is very useful in techincal interviews and also to understand the system as a whole so i would like to add a OS to the resources so it would be really helpful to the students using the repo
Explain your solution
No response
Any alternative approaches/features
No response
Additional Context
No response

Maybe I am not going to add OS for now, since there a lot of categories already in the project and some of them are not even completed yet. I will create another issue for adding new sections to these categories. I will close this issue for now, thanks for understanding :)

@jfmartinz do assign me that issue if you do that tho thank you

@jfmartinz do assign me that issue if you do that tho thank you

Ofc


day-of-week support for cron scaler

Proposal
We'd like to do 0 9 * * 1-5 to have a scaler perform scale-up on weekdays only. This seems to not work in Keda atm:
error parsing cron metadata: error parsing start schedule. map[desiredReplicas:3 end:0 17 * * 1-5 start:0 9 * * 1-5 timezone:Europe/Oslo]: range or hyphenated inputs are not allowed
Use-Case
No response
Anything else?
No response

Fair request - Are you willing to contribute this?

I'm not an expert go dev, but I can definetely make an attempt. Will report back here.

my bad. This seems to have been fixed as part of https://github.com/kedacore/keda/pull/2038 - I was on an older version. Closing.


Extract data from gzip html file

I use "Website Agent " extract gzip html, and I add unzip: gzip. I receive a error: Error when fetching url: not in gzip format.
Am I configured wrong?

unzip: gzip is only needed if the website does not handle the request headers properly. In almost all cases you can remove it and the request will work. Can you share the URL you are trying to fetch?


Overriding $logger variable in Bootstrapper

Using variable $logger in config file, like here:
<?php

declare(strict_types=1);

require_once __DIR__.'/vendor/autoload.php';

use Aerys\Host;
use Aerys\Request;
use Aerys\Response;
use function Aerys\router;

$logger = null;

$router = router()->get("/", function (Request $request, Response $response) {
    $response->end("OK");
});

(new Host())->expose("*", `8080)->use($router);

causes TypeError
[2017-07-03 19:04:53] critical TypeError: Argument 1 passed to Aerys\Bootstrapper::init() must implement interface Psr\Log\LoggerInterface, null given, called in /Users/pwc/src/aerys-example/vendor/amphp/aerys/lib/Bootstrapper.php on line 60 and defined in /Users/pwc/src/aerys-example/vendor/amphp/aerys/lib/Bootstrapper.php:70
Stack trace:
#0 /Users/pwc/src/aerys-example/vendor/amphp/aerys/lib/Bootstrapper.php(60): Aerys\Bootstrapper->init(NULL, Array)
#1 /Users/pwc/src/aerys-example/vendor/amphp/aerys/lib/WorkerProcess.php(93): Aerys\Bootstrapper->boot(NULL, Object(Aerys\Console))
#2 /Users/pwc/src/aerys-example/vendor/amphp/aerys/lib/Process.php(44): Aerys\WorkerProcess->doStart(Object(Aerys\Console))
#3 /Users/pwc/src/aerys-example/vendor/amphp/aerys/bin/aerys-worker(83): Aerys\Process->start(Object(Aerys\Console))
#4 [internal function]: {closure}('a', NULL)
#5 /Users/pwc/src/aerys-example/vendor/amphp/amp/lib/Coroutine.php(81): Generator->current()
#6 /Users/pwc/src/aerys-example/vendor/amphp/amp/lib/Loop/Driver.php(119): Amp\Coroutine->__construct(Object(Generator))
#7 /Users/pwc/src/aerys-example/vendor/amphp/amp/lib/Loop/Driver.php(70): Amp\Loop\Driver->tick()
#8 /Users/pwc/src/aerys-example/vendor/amphp/amp/lib/Loop/EvDriver.php(147): Amp\Loop\Driver->run()
#9 /Users/pwc/src/aerys-example/vendor/amphp/amp/lib/Loop.php(53): Amp\Loop\EvDriver->run()
#10 /Users/pwc/src/aerys-example/vendor/amphp/aerys/bin/aerys-worker(84): Amp\Loop::run(Object(Closure))
#11 {main}

Run with PHP version:
PHP 7.0.20 (cli) (built: Jul  2 2017 18:16:56) ( ZTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.0.20, Copyright (c) 1999-2017, by Zend Technologies
    with blackfire v1.17.3~mac-x64-zts70, https://blackfire.io, by SensioLabs

$logger is a magic variable in the config and can be used to access (and change) the logger.

It would probably be better to transpose the $logger variable into e.g. Bootstrapper::$logger (public static var) for the duration of the inclusion. That way we reduce accidental overwrites while still providing access to it from within the config file.

We should allow different loggers on a host-by-host basis, perhaps add a logger method to Host, i.e.: (new Host())->expose("*", 8080)->use($router)->logger($logger); using the default instance if none is provided.

There is are a few problems with this:

Bootables may be passed to multiple different Host::use(), but are only booted once.
Not every log message is Host bound, some are interface bound (e.g. the accept() calls), some are also not even identifiable as being part of a certain host, in particular PHP errors (e.g. an E_WARNING) happening in some Coroutine.

It would be possible to only bind access logs to a specific callback/logger/whatever. But not really an option for everything else.


WIP: add a 3rd argument to Huber function

I changed the huber function to add a 3rd argument T which represents the possible scaling of the function.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks so much for giving this a shot, @CSHugoM! Could you please add some tests to verify that it works as expected?
As a starting point, I suggest a test where you minimize this function where the input vectors and scale parameter are confined to a simple box in the positive orthant (say, all components in the interval [1, 2]). You should be able to work out an analytic solution for that problem. I also suggest looking at an existing test with the two-parameter Huber function, using a Variable scale input, but fixing scale == 1. Then you can check that the behavior is unchanged relative to the two-parameter Huber function.
(Also, sorry for not replying to your GitHub issue. I know I directed you here, and we really appreciated your enthusiasm.)

Thanks for your comments !
I wrote the first test in the test_problem.py file. However, when I try to run it with the command :
python -m pytest test_problem.py::TestProblem::test_huber_3_arg_min
I have an Error : Not Found.
Have you any idea why ?
Thanks,
Hugo

@CSHugoM I left a comment on the GitHub issue that provides more guidance. Take a look and let me know (on that thread) if those resources don't make total sense.

@rileyjmurray Thanks for that ! Are you talking about Issue #1377 ? I don't see any new comment on this issue, is this about one of your old comments ?

Huh, I swear left a comment, but it's not there. I just added one again.

 If not, maybe we could have a Skype / Zoom call.

Closing due to inactivity.


Support swift 5.1

@aiden-leong what is FoundationXML?

@MihaelIsaev Have a look at this: https://forums.swift.org/t/new-swift-corelibs-foundation-module-foundationxml/27544

@aiden-leong have you made any swift app using qlift? I really want to use it but can't work with it in Xcode cause can't link needed frameworks. So for now the only way for me is only to write code with qlift blind without ability to use autocompletion, building and debugging, cause I can compile it only via command line.
Would be great if you could share your experience. If you use discord you could find me as iMike#3049 I'd love to chat 🙂


[Data-table] sort style does not appear

I am using the data table as per the following code, column sorting works normally, but it does not display the pointers nor the column that was ordered in bold.
HTML:

TS:

Interface:

ah, you are missing the [active] input which has to be true on the sorted column.

Thank you, it worked perfectly.


Rename "history" to "activity"

We have an audit log called "history" (currently displayed for groups). @nicksellen had the idea to rename it to "activity", and I support this proposal.
Upside: more fitting name
Downside: would need some refactoring, including backend API
What do you think?
A quick solution could be to change only frontend strings, but that could cause confusion.

I think change is good, could leave it waiting here until somebody wants to do the work...

Hello @nicksellen, @tiltec ,
I am new to the process of contributing to open source community although I have been doing coding for quite some time. I would like to start contributing with this bug. I have read through the CONTRIBUTE.md. Is it okay if I start with this bug ..? Can you please explain further ..?

Hi @varu038, great to have you here! First of all, sorry for the late reply - I have patchy internet access due to travels.
I think this is a nice PR to start with, happy if you do so!
Do you have a tool to help you with the refactoring?
We will need to deploy frontend & backend at the same time, so there should a PR in each repo.
An area where some attention is needed are the translation strings (frontend locale-en.json). When we change the IDs, we need to take care to update all translated files as well and push them to transifex. Otherwise transifex will lose the translations ;)
Oh another thing: did you join our Slack already? slackin.yunity.org
It's our main communication tool, find us in the channel #foodsaving-tool

Hello @tiltec ,
What kind of tool are you talking about for refactoring ..?
I have joined the Slack.

grep history ./client/app/locales/locale-en.json -in
52:    "HISTORY": "History",
171:  "HISTORY": {
@tiltec
Are talking about renaming these to activity ..?

For example a good editor that can help with the renaming. But it can also be done with extensive search/replace.
I use PyCharm for the backend Python code and Atom for the frontend.
On 7 April 2017 10:05:49 WEST, varu038<EMAIL_ADDRESS>wrote:

Hello @tiltec ,
What kind of tool are you talking about for refactoring ..?
I have joined the Slack.

Yes, that's the messages (to sync with transifex). I guess you have seen that it's only the tip of the iceberg, most of the changes are in the code. Goal is a complete rename to "activity", so that future contributors won't be confused.
On 7 April 2017 15:58:19 WEST, varu038<EMAIL_ADDRESS>wrote:

grep history ./client/app/locales/locale-en.json -in
52:    "HISTORY": "History",
171:  "HISTORY": {
@tiltec
Are talking about renaming these to activity ..?

Hello @tiltec ,
I am trying to update the translation files but its not allowing me.
How do I do it ..?
tx push -s
Pushing translations for resource foodsaving-tool.frontend:
Pushing source file (client/app/locales/locale-en.json)
Exception: Only maintainers are allowed to update the source file.
tx pull -a
Pulling translations for resource foodsaving-tool.frontend (source: client/app/locales/locale-en.json)
-> ru: client/app/locales/locale-ru.json
Skipping 'fr' translation (file: client/app/locales/locale-fr.json).
Skipping 'eo' translation (file: client/app/locales/locale-eo.json).
Skipping 'de' translation (file: client/app/locales/locale-de.json).
Skipping 'it' translation (file: client/app/locales/locale-it.json).
Skipping 'es' translation (file: client/app/locales/locale-es.json).
Skipping 'sv' translation (file: client/app/locales/locale-sv.json).
Done.
git diff
diff --git a/client/app/locales/locale-en.json b/client/app/locales/locale-en.json
index cd6b650..32db70e 100644
--- a/client/app/locales/locale-en.json
+++ b/client/app/locales/locale-en.json
@@ -49,7 +49,7 @@
"PICKUPS": "Pickups",
"MEMBERS": "Members",
"STORES": "Stores",

"HISTORY": "History",

"ACTIVITY": "Activity",
"DESCRIPTION": "Description",
"ADDRESS": "Address",
"TIMEZONE": "Time zone of group"
@@ -168,7 +168,7 @@
"QUOTE": "quote",
"HELP": "What is Markdown?"
},

"HISTORY": {

"ACTIVITY": {
"GROUP_CREATE": "created this group",
"GROUP_MODIFY": "changed the settings of this group",
"GROUP_JOIN": "joined this group",

as of now, I am just looking at client/app. Once done I will look at the backend. I think it would be a good idea to also rename the files. what do you think ..?

Cool :) Yes, everything - as if it was never named "history".
On 11 April 2017 15:15:38 WEST, varu038<EMAIL_ADDRESS>wrote:

as of now, I am just looking at client/app. Once done I will look at
the backend. I think it would be a good idea to also rename the files.
what do you think ..?

@varu038 I added code formatting blocks to your post, otherwise you can't actually read the diff :)

@tiltec might be a silly question since this is my first push on git. On git push I am getting following error :
fatal: The current branch newBranchForIssue#427 has no upstream branch.
To push the current branch and set the remote as upstream, use
git push --set-upstream origin newBranchForIssue#427

When I try the above git push with upstream I am getting following error :
remote: Permission to yunity/foodsaving-frontend.git denied to varu038.
fatal: unable to access 'https://github.com/yunity/foodsaving-frontend.git/': The requested URL returned error: 403
Am I missing something ..?
Tried googling but none of the solutions worked for me.

Ah yeah, you create a fork in your account. There is a reasonable guide here https://gist.github.com/Chaser324/ce0505fbed06b947d962

Hi @tiltec , @nicksellen I have forked and cloned the backend. I am trying to activate the virtualenv with "source ./env/bin/activate" but I dont see this file in the project. How do I run this ..?

Did you create the virtualenv, e.g. with virtualenv -p python3 env?

Hey! Is this Issue still open? I'd like to work on it.

Yes, it is! There is work to be done in the frontend, as well as the backend. Are you familiar with Python, Django and perhaps even the Django REST Framework?

I am relatively new developer, as such I have experience with Python, some experience with Django, but none with the REST framework.

@nicksellen: would you be interested to support @HungryAdi here?
I would be happy to receive a Pull Request, but don't have enough capacities for providing guidance.

I'm happy to help out too. I could submit the changes for the frontend and @HungryAdi could fix the backend if that is ok with everyone.

@HungryAdi / @theresaslee - if you're both up for that then go for it, it would be best to schedule it to be completed at around the same time as it will touch quite a few files and keeping up to date with changes in master can be painful if you leave it for too long.
you can follow the guide I linked to above for how to manage the pull request workflow - https://gist.github.com/Chaser324/ce0505fbed06b947d962

Hello! @theresaslee just so I know, are you and @HungryAdi already on it? I see your task as far as the front-end it seems. If not I can help with the back-end.

@HungryAdi - are you still interested in altering the backend?

@vinibiso / @theresaslee - if you are up for making the backend changes, I suggest you should proceed! You can create an issue in the backend and assign it to yourself so it's clear :)
Ping me if you want any guidance!

@vinibiso seemed interested in it, so he can do it.
If he doesn't respond within 3 days, then I can work on it.

Hello, sorry for my absence. As far as the back-end goes, I think it might be beyond by capabilities at the moment, so if @vinibiso  wants to work on it, he should.

Hey! alright! I'm gonna get to it then. It's gonna take me a little while cause I have a project on the way right now, but I should be done with it by the end of the week.

I'm closing this because it seems much more effort than it's worth. The back-end PR was missing a migration test and the frontend PR got out of date because we rewrote the whole frontend with another framework.


[MONIT-27778] Relay chain Proxies checking info

Java11 build failing due to
com.wavefront.agent.PushAgentTest.testRelayPortHandlerGzipped
PushAgentTest.testRelayPortHandlerGzipped:1666 » Socket Unexpected end of file...

Is this related to changes in RelayPortUnificationHandler.java?


Fix bug in dmac where software triggers didn't work

Summary
I realized that the dmac examples were no longer working. After running git bisect, I narrowed down the bug to #432, where the register proxy architecture introduced a bug preventing DMAC software triggers from working. This PR fixes that, along with removing an unnecessary unsafe block in the dmac module.
Checklist

[x] CHANGELOG.md for the BSP or HAL updated
[x] All new or modified code is well documented, especially public items
[x] No new warnings or clippy suggestions have been introduced (see CI or check locally)

Hmm, looks like GHA is having problems. But the tests ran successfully just before merging #626, and that PR doesn't touch any of the same files, so I think it is safe to merge anyway.


linux-asahi from 2023-08-25 does not build with Rust support enabled

After today's update, I am unable to build the kernel. I am running NixOS 23.05, flake input updated just a couple of minutes ago (github:nixos/nixpkgs/fc944919f743bb22379dddf18dcb72db6cff84aa).
The kernel seems to build if I disable Rust support or use unstable.
Build log:
error: builder for '/nix/store/yg8a5k5g1zn8yysi32ial27074cciq0r-linux-6.4.0-asahi.drv' failed with exit code 1:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/b27f62ngi8b36l60zirx9djxc237xhqp-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
applying patch /nix/store/j217pbp9pqv3z336nv6lx8fhrzdb5pmj-rust-bindgen-version.patch
patching file scripts/rust_is_available.sh
applying patch /nix/store/f3yvg9zp5lisfrfdw5szqn6v4h47nx6h-default-pagesize-16k.patch
patching file arch/arm64/Kconfig
Hunk #1 succeeded at 1197 (offset 161 lines).
applying patch /nix/store/a6jy7ivg8dljlap45ccwrx93j3bh05zb-rust-bindgen-0.63-fix.patch
patching file rust/Makefile
Hunk #1 succeeded at 321 (offset -12 lines).
applying patch /nix/store/fc3pfhi9cxzgiwdwf32w96hpl78imwis-rust-bindgen-0.65-fix.patch
patching file rust/Makefile
Hunk #1 succeeded at 301 (offset 13 lines).
applying patch /nix/store/zac8l1vmba0kzl6md10anps8ay9dn798-rust_1_71_0.patch
patching file rust/Makefile
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file rust/Makefile.rej
patching file rust/compiler_builtins.rs
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file rust/compiler_builtins.rs.rej
patching file rust/alloc/alloc.rs
Hunk #1 FAILED at 337.
1 out of 1 hunk FAILED -- saving rejects to file rust/alloc/alloc.rs.rej
patching file rust/alloc/boxed.rs
Hunk #1 FAILED at 380.
Hunk #2 FAILED at 410.
Hunk #3 FAILED at 445.
Hunk #4 FAILED at 486.
Hunk #5 FAILED at 517.
Hunk #6 FAILED at 558.
Hunk #7 FAILED at 577.
Hunk #8 FAILED at 591.
Hunk #9 FAILED at 609.
Hunk #10 FAILED at 828.
Hunk #11 FAILED at 863.
Hunk #12 FAILED at 1109.
Hunk #13 FAILED at 1121.
Hunk #14 FAILED at 1140.
Hunk #15 FAILED at 1182.
Hunk #16 FAILED at 1460.
Hunk #17 FAILED at 1898.
Hunk #18 FAILED at 1908.
18 out of 18 hunks FAILED -- saving rejects to file rust/alloc/boxed.rs.rej
patching file rust/alloc/lib.rs
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file rust/alloc/lib.rs.rej
patching file rust/alloc/vec/mod.rs
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file rust/alloc/vec/mod.rs.rej
patching file rust/kernel/allocator.rs
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file rust/kernel/allocator.rs.rej
patching file rust/kernel/driver.rs
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file rust/kernel/driver.rs.rej

I suspect the version chosen for the Rust patch check is wrong - I attempted to skip the patch and the kernel seems to be building. I'll report later whether the compilation managed to finish.

Build was successful, running the new kernel now.

Thanks, fixed in the latest release.


rtmp_player example is broken

Heya,
Cool package, i'm looking into recording rtmp and tried the rtmp_player, but it seams the example is broken ? Any chance you could update it ?

You can send the RTMP stream URL to my email.  I will check the player to download the stream.

@zhangpeihao 一样的问题
rtmp://huangshifb.live.cjyun.org/video/s10200-hsxwzh
只能读前两个message后，conn就被断开了，OnClosed被调用


Issue #4359

Description 📜
I have covered the following topics in detail in the video file:

What are substrings?
Examples of substrings
Implementation of substrings using 3 different approaches

Fixes #4359

Type of change 📝

[x] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)

Domain of Contribution 📊

[x] DSA

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Thankyou @sneha-nitdgp mam


nextTick/nextFrame

 Issue by nevir
Friday Jun 13, 2014 at 21:45 GMT
Originally opened as https://github.com/Polymer/polymer-dev/issues/33

Currently, #async (without timeout) fires via RAF, which adds a good bit of potential latency to that call.
There are often cases where being able to defer logic til the next run loop tick is handy (waiting for state to resolve when mutation observers don't make sense, etc), too - which RAF isn't ideal for.
What I'd like to propose is:

Add a nextFrame helper. Makes the contract clearer. (for ex, core-overlay is relying on the RAF behavior - seems dangerous?)
Add a nextTick helper OR:
Keep async with its loose "it'll call asynchronously ...sometime soon" contract, but have it use a lower latency approach. (Backwards incompat, though...)

Note that setImmediate seems tempting, but there's a whole lot of baggage surrounding it.

Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect.


AlreadyAllocated when calling waveInOpen

We are having an issue at our production sites where calling waveInOpen will frequently fail with MMSYSERR_ALLOCATED. As far as I can see, waveInOpen doesn't even have the option to take exclusive access, and we have succeeded in recording in multiple instances of our application simultaneously locally. Therefore my initial inclination is that it's impossible for any bug on our side to block the device and cause this specific problem.
That being said, we are seeing this issue in our software only at multiple sites. This heavily implies to me that there is a problem on our side.
Do you know of any possible causes for MMSYSERR_ALLOCATED other than other applications having exclusive access to the device?

WaveOut is quite good at sharing, but I imagine with WaveIn it could be more tricky to support multiple applications capturing audio simultaneously. It may be simply the driver manufacturer for the specific soundcard. I'd recommend trying with a few alternative audio devices on the problem computer (or updating their device drivers)

We've already determined that WaveIn and our usage of it can support multiple instances of our own application due to a bug where you could create multiple instances and start recording in all of them simultaneously, so that one is out for us ;p

Just as an update, we've asked the customer to uncheck allowing exclusive access to the device, and this has not had any effect. I will forward your advice about updated drivers.


HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

Description of PR
Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853
Cherry-picked https://github.com/apache/hadoop/commit/e62ba16a02f8f325eff06b932de89e986335a5e1 for branch-3.3.5
JIRA - HADOOP-18484
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@adoroszlai - Created PR for branch-3.3.5 as discussed on JIRA. Please help with review. Thanks.

@ashutoshcipher Thanks for your contribution, LGTM.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
4m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3.5 Compile Tests _

+0 :ok:
mvndep
15m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 49s

branch-3.3.5 passed

+1 :green_heart:
compile
18m 39s

branch-3.3.5 passed

+1 :green_heart:
mvnsite
21m 22s

branch-3.3.5 passed

+1 :green_heart:
javadoc
7m 24s

branch-3.3.5 passed

+1 :green_heart:
shadedclient
30m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
27m 25s

the patch passed

+1 :green_heart:
compile
18m 25s

the patch passed

+1 :green_heart:
javac
18m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
21m  7s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
7m  6s

the patch passed

+1 :green_heart:
shadedclient
31m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
691m  7s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
2m 27s

The patch does not generate ASF License warnings.

910m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.TestFileCreation

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAutoQueueCreation

hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5114/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5114

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 8f6846669cd0 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3.5 / 3d4dc467dd7876f5d7292574011d29ffb837f76f

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5114/1/testReport/

Max. process+thread count
3394 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-mapreduce-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5114/1/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Test Failures check -

hadoop.hdfs.tools.TestDFSAdmin

TestDFSAdmin.testPrintTopologyWithStatus
TestDFSAdmin.testListOpenFiles
TestDFSAdmin.testSetBalancerBandwidth
TestDFSAdmin.testCheckNumOfBlocksInReportCommand
TestDFSAdmin.testAllDatanodesReconfig
TestDFSAdmin.testPrintTopology
TestDFSAdmin.testRefreshProxyUser
TestDFSAdmin.testReportCommand

Same failed in my local for 3.3.5 branch without this change as well.
TestFileCreation.testConcurrentFileCreation
TestFileCreation.testFileCreationWithOverwrite
TestFileCreation.testFsCloseAfterClusterShutdown
TestFileCreation.testFileCreationSimulated
TestFileCreation.testFsClose
TestFileCreation.testLeaseExpireHardLimit
TestFileCreation.testFileCreationNamenodeRestart
TestFileCreation.testFileIdMismatch
TestFileCreation.testFileCreationSyncOnClose
TestFileCreation.testServerDefaults
TestFileCreation.testOverwriteOpenForWrite
TestFileCreation.testFileCreationNonRecursive
TestFileCreation.testDFSClientDeath
TestFileCreation.testDeleteOnExit
TestFileCreation.testFileCreationError1
TestFileCreation.testFileCreationError2
TestFileCreation.testFileCreationError3
TestFileCreation.testCreateNonCanonicalPathAndRestartFromUri
TestFileCreation.testCreateNonCanonicalPathAndRestartFromString
TestFileCreation.testFileCreation
TestFileCreation.testCreateNonCanonicalPathAndRestartRpc

Same failed in my local for 3.3.5 branch without this change as well.

TestCapacitySchedulerAutoQueueCreation passing while running multiple times in local.
TestFederationInterceptor passing while running multiple times in local.

This PR should be okay to merge as the failures doesnt look related.
Any suggestion @adoroszlai @steveloughran

Please help in review @adoroszlai @steveloughran. Thanks.

@ashutoshcipher I have already approved, and the same change is already in few other branches.  Since branch-3.3.5 is nearing release (IUC), I wanted to give @steveloughran the chance to take a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3.5 Compile Tests _

+0 :ok:
mvndep
14m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 10s

branch-3.3.5 passed

+1 :green_heart:
compile
18m 12s

branch-3.3.5 passed

+1 :green_heart:
mvnsite
20m 28s

branch-3.3.5 passed

+1 :green_heart:
javadoc
7m 11s

branch-3.3.5 passed

+1 :green_heart:
shadedclient
30m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
25m 52s

the patch passed

+1 :green_heart:
compile
17m 40s

the patch passed

+1 :green_heart:
javac
17m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
20m  1s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
6m 58s

the patch passed

+1 :green_heart:
shadedclient
31m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
690m  7s

root in the patch passed.

+1 :green_heart:
asflicense
2m 44s

The patch does not generate ASF License warnings.

906m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5114/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5114

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 35742aaeef60 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3.5 / 0b2027f505acf9fecf483c320e80226538fda2ae

Default Java
Private Build-1.8.0_352-8u352-ga-1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5114/2/testReport/

Max. process+thread count
4022 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-mapreduce-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5114/2/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hello,
Any ideas on when branch-3.3.5 will be released and where I can subscribe to get notified when it is?
Thank you.

on the hadoop dev list. once mukund gets gpg working and we get a couple of blockers in, i'd like to get an RC0 out this month -which is the time to get testing.


Service Principal created via Pulumi code can't have app proxy settings

Describe what happened
When we create app registration and service principal via Pulumi in Azure we obseve some differences in view and API response from Azure.
For enterprise app we created via Pulumi we get appType:3 but for enterprise app created via Azure portal we get appType:1.
Screenshot shows that app created via Pulumi has missing fileds in UI. So this might exaplain that app created via Pulumi is not same type as from the portal. We suspect that might be also blocking us to setup app proxy over app created via Pulumi.
Is there any API in portal Azure that can control what kind of service princial is being created?
We are using Azure Native 2.* in this project
This one contains less props on Properties, created via Pulumi

This one contains more props on Properties, created via Portal

Sample program
var app = new Application(appRegistrationName, new ApplicationArgs
        {
            DisplayName = appRegistrationName,
            Web = new ApplicationWebArgs()
            {
                LogoutUrl = "https://url.company.org/?appproxy=logout",
                RedirectUris = new[] { "https://url.company.org/" }
            }
        });`

var servicePrincipal = new ServicePrincipal(appRegistrationName, new ServicePrincipalArgs
        {
            AppRoleAssignmentRequired = true,
            ClientId = app.ClientId.Apply(id => id),
            AccountEnabled = true,
            LoginUrl = "https://url.company.org/",
            Tags = new[]
            {
                "WindowsAzureActiveDirectoryIntegratedApp",
                "WindowsAzureActiveDirectoryOnPremApp"
            },
        });

Log output
No response
Affected Resource(s)
No response
Output of pulumi about
`Extracting package 'M:\Octopus\Packages\Spaces-1\feeds-builtin\Komplett.CaaS\Komplett.CaaS.2.5.52.zip' to 'C:\Octopus\Work\20240822104358-477856-536\Komplett.CaaS'
August 22nd 2024 12:44:15Info
CLI
August 22nd 2024 12:44:15Info
Version      3.111.1
August 22nd 2024 12:44:15Info
Go Version   go1.22.1
August 22nd 2024 12:44:15Info
Go Compiler  gc
August 22nd 2024 12:44:15Info
Host
August 22nd 2024 12:44:15Info
OS       Microsoft Windows Server 2019 Datacenter
August 22nd 2024 12:44:15Info
Version  10.0.17763 Build 17763
August 22nd 2024 12:44:15Info
Arch     x86_64
August 22nd 2024 12:44:15Info
Pulumi locates its logs in C:\windows\TEMP by default

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @asiqq23 this will need to be implemented in the upstream terraform-provider-azuread provider then will be made available in this Pulumi provider in the subsequent release.
It looks like what you're asking for might be the same as this existing issue if you want to upvote that one:

https://github.com/hashicorp/terraform-provider-azuread/issues/7


What is the correct way to void envelopes?

I tried to void envelopes with the following code provided on this blog post.
let envelope = new docusign.Envelope()
envelope.status = 'voided'
envelope.voidedReason = reason
await this.envelopeApi.update(this.accountId, envelopeUUID, envelope)

The code always runs without errors but after I retrieve the current envelope status from the API the state never changes to voided.
Then I changed the .update call as specified here on the api docs
await this.envelopeApi.update(this.accountId, envelopeUUID, { envelope })

This way it errors out the following
{"errorCode":"INVALID_REQUEST_PARAMETER","message":"The request contained at least one invalid parameter. Value for 'voidedReason' must be specified when voiding an envelope."}

FYI:

this.envelopeApi is working fine for retrieve and for envelope creation

hi @yharrison-tl
I have just ran the following as was able to successfully void the envelope:
var envelope = new docusign.Envelope();         envelope.status = 'voided';         envelope.voidedReason = 'I am voiding this  because reason';         envelopesApi.update(accountId, 'xxxxxxx-xxxxx-xxxx-xxxx-xxxxxxxx', { envelope: envelope })           .then((data) => {             console.log(data);             envelopesApi.getEnvelope(accountId, 'xxxxxxx-xxxxx-xxxx-xxxx-xxxxxxxx')               .then(envelope => {               console.log(envelope);               //console.log(err);             })           }).catch(err => {             console.log('error')             console.log(err)         });
Could you verify that reason is a string and not null, as well as your SDK version?

Now it works. Probably the package was outdated.
Thank you.


POST sent successfully but reports entity may not be null

Can successfully send a POST packet to REST API but ha-bridge reports that the entity may not be null
My configuration

Attached log
nohup.txt

Can you try putting your content body json in one line with no line breaks, i.e:
{"command":"target","target":75}

No change in behaviour. Packet is still sent successfully and is received but still get:
[qtp13589192-11] WARN  com.bwssystems.HABridge.hue.HueMulator - Change device state, Could not send data for network request: http://localhost/api/printer/bed with Message: Entity may not be null

I'll need more information as I cannot get this to happen. Please set DEBUG for com.bwssystems.HABridge.hue.HueMulator component and post the results for the log.

2016-05-04 08:48:17,827 [qtp13589192-11] DEBUG spark.webserver.MatcherFilter - httpMethod:put, uri: /api/test/lights/1933876554/state
2016-05-04 08:48:17,829 [qtp13589192-11] DEBUG spark.Request - get params
2016-05-04 08:48:17,831 [qtp13589192-11] DEBUG spark.Request - matchedPart: :userid = test
2016-05-04 08:48:17,832 [qtp13589192-11] DEBUG spark.Request - matchedPart: :id =<PHONE_NUMBER>
2016-05-04 08:48:17,833 [qtp13589192-11] DEBUG spark.Request - get splat
2016-05-04 08:48:17,834 [qtp13589192-11] DEBUG com.bwssystems.HABridge.hue.HueMulator - hue state change requested: test from <IP_ADDRESS> body: {"on":true}
2016-05-04 08:48:17,838 [qtp13589192-11] DEBUG com.bwssystems.HABridge.hue.HueMulator - executing HUE api request for network call: http://localhost/api/printer/command
2016-05-04 08:48:17,840 [qtp13589192-11] DEBUG com.bwssystems.HABridge.hue.HueMulator - executing HUE api request to Http POST: http://localhost/api/printer/command
2016-05-04 08:48:17,842 [qtp13589192-11] DEBUG com.bwssystems.HABridge.hue.HueMulator - Making outbound call in doHttpRequest: POST http://localhost/api/printer/command HTTP/1.1
2016-05-04 08:48:17,886 [qtp13589192-11] DEBUG com.bwssystems.HABridge.hue.HueMulator - POST execute on URL responded: 204
2016-05-04 08:48:17,889 [qtp13589192-11] WARN  com.bwssystems.HABridge.hue.HueMulator - Change device state, Could not send data for network request: http://localhost/api/printer/command with Message: Entity may not be null

Could it be an issue with the REST API server existing on the same machine HABridge is running on?

Found it! I'm not checking the response body if it is null before trying to decode it.... this is a bug.

Updated to v2.0.4 from 2.0.3 and I still have the same issue:
2016-05-04 11:14:46,924 [qtp13589192-13] DEBUG com.bwssystems.HABridge.hue.HueMulator - hue state change requested: test from <IP_ADDRESS> body: {"on":true} 2016-05-04 11:14:46,927 [qtp13589192-13] DEBUG com.bwssystems.HABridge.hue.HueMulator - executing HUE api request for network call: http://localhost/api/printer/command 2016-05-04 11:14:46,929 [qtp13589192-13] DEBUG com.bwssystems.HABridge.hue.HueMulator - executing HUE api request to Http POST: http://localhost/api/printer/command 2016-05-04 11:14:46,930 [qtp13589192-13] DEBUG com.bwssystems.HABridge.hue.HueMulator - Making outbound call in doHttpRequest: POST http://localhost/api/printer/command HTTP/1.1 2016-05-04 11:14:46,981 [qtp13589192-13] DEBUG com.bwssystems.HABridge.hue.HueMulator - POST execute on URL responded: 204 2016-05-04 11:14:46,982 [qtp13589192-13] WARN  com.bwssystems.HABridge.hue.HueMulator - Error on calling url to change device state: http://localhost/api/printer/command

The last debug line is cutoff, could you edit the previous comment please?
Thanks

Added attached log.

You can ignore that for now, but I see what happens on the return of the call i'm not setting a success value. It is fine, unless you use the looping construct. It'l be fixed in the next release.

Okay, any work around to report success to the echo?

I'll just rebuild the jar file and repost it as the same version.

new jar uploaded under the 2.0.4 version

@CupricReki - Did the latest version fix this issue?

It did not. I'm still getting successful messages being sent, but HABridge is still reporting an error and the amazon echo believes the device cannot be connected to.
log.txt

Alright, brute force try block around the offending code, it will return success. If you turn on debug, it will show the error but work properly. download 2.0.4 again and try please.

No change, see the 204 response and the same error. I have even been verifying the jar files have different checksums for every 2.0.4 release.
log.txt

Ok, that cannot happen in the last update to the code. Download the latest jar again as this cannot get to that point in the code currently. Turn on  DEBUG for com.bwssystems.HABridge.hue.HueMulator component and post the output as well.

Ok, I checked the state handling, and I do not see any reason in the response that would not make this  proper. Something is happening on the echo side that is preventing this.

Ok one last change to super guarantee this works....


[Langchain_Community]: OpenLLM Client Fixes + Added Timeout Parameter

OpenLLM was using outdated method to get the final text output from openllm client invocation which was raising the error.  Therefore corrected that.
OpenLLM _identifying_params was getting the openllm's client configuration using outdated attributes which was raising error.
Updated the docstring for OpenLLM.
Added timeout parameter to be passed to underlying openllm client.

@baskaryan

@eyurtsev

cc @aarnphm


Refactored Kitura-Net HTTPServerDelegate to ServerDelegate

As the title describes, this is a refactoring / renaming of the HTTPServerDelegate class protocol in Kitura-net to simply ServerDelegate. Changes apply to both Kitura and Kitura-net, both on the master branch.
In relation to #565 - adding FastCGI to Kitura.
Description

Pulled HTTPServerDelegate from the HTTPServer class.
Placed it in it's own file, ServerDelegate.swift in Kitura-net.
Replaced all uses of HTTPServerDelegate with ServerDelegate system wide. This affects both the Kitura-Net and Kitura projects.

Motivation and Context
This class will ultimately be used to provide server protocols other than HTTP and will be used by a forthcoming pull request related to adding a FastCGI server implementation to Kitura. For clarity, this refactor makes it obvious that the ServerDelegate handles more than HTTP and moves it out of the HTTPServer class in the process.
How Has This Been Tested?
Change is relatively trivial in terms of a refactor. Did a full rebuild of current test projects I'm working on and everything builds and runs as always. There is no real code changes here - just renames for the most part.
Checklist:

[x] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

Note that the CI on this pull request will fail until the PR 42 on Kitura-net is accepted (this pull request depends on that one).

@simplepanda You didn't update the tests, which is why the build is failing on your PR.

@shmuelk this one fails because of the API changes to Kitura-net

@shmuelk  and @ianpartridge  - you're both right! :)
i missed the test suite on this PR, so that's an issue that's now fixed with my past commit and push.
This will pass tests once IBM-Swift/Kitura-net#42 is merged and tagged I'll have to update Package.swift to reference the new Kitura-net tag that includes those changes when that happens before this really passes, but after that it should be a-ok.

OK we'll bump the version on Kitura-net once we've merged that PR, then you can push another commit to this PR to pick it up.

There should be no need to bump the version in the Package.swift files. We've already bumped the version of Kitura-net to 0.21.0. The Package.swift file for Kitura already references Kitura-net with a majorVersion of 0 and a minor of 21. Once the PR for Kitura-net is merged and tagged as 0.21.X, this PR should build.

But as this is a breaking API change, shouldn't it be 0.22.0?

@ianpartridge We're early enough in 0.21 that I don't think it matters. Besides 0.22 will be the "release" at the end of this sprint.

@shmuelk @ianpartridge I can push the next PR to IBM-Swift/Kitura-net pretty quickly (going to factor in IBM-Swift/Kitura-net#43 to my code which shouldn't take long to test).
The actual FastCGI code won't break anything in that it's self-contained if IBM-Swift/Kitura-net#42 is already merged.

I guess there is a wider discussion here about how semver plays into our sprints. We're using a mix of time-based versioning and API-based versioning. That's probably OK while we're at 0.x and rapidly releasing new function.

Is there an overall roadmap for Kitura? Something like what's being built towards in terms of a theoretical 1.0 release? I'm enjoying this project and would be happy to get my hands dirty(er) once my FastCGI updates are in place.

We've been starting to discuss informally what 1.0 would mean. No consensus has been reached! We're very interested in hearing any ideas you (or anyone else) has.
My personal view is we need Swift 3 to be released first, but I'm sure there are other requirements too - both functional and non-functional.

I'd agree on Swift 3 (final) and Xcode 8 (final) being pre-requesites. There is already a lot of flux on within the sub-dependencies as far as toolchain requirements (latest BlueSocket needs toolchain 2016-06-20, for example) and many of the issues being opened against Kitura seem directly related to build questions that are almost invariably toolchain version related.
I tend to be pretty minimalist when it comes to my app server frameworks - I want to be able to define code for an endpoint and connect the app server to a larger stack that's handling static content, HTTP routing, load balancing, encryption, etc (hence my FastCGI work). Kitura already satisfies this for the most part so the meat and potatoes are already there as far as I'm concerned. Maybe that's a 1.0?
I do recognize that many people want many things from their frameworks though.


Feature: Use Bicep to develop, build arm templates

See https://github.com/Azure/iotedge-lorawan-starterkit/issues/1884


Add ko-en translation task to eval Korean language task

Add ko-en translation task to eval Korean language task

Fix citation
Explain about dataset source
Make subtasks  ko -> en, en -> ko


Investigate Deref trait

Summary
https://doc.rust-lang.org/std/ops/trait.Deref.html
Used to easier dereferencing process

Given that we are creating our Rust API on top of the bindings the user of this trait won't affect user experience from the higher Rust API
The user isn't expected to use the underlying maliput_sys::ffi object


Dotty 3.0.0-M1 support

Ok tests with all cross scala versions. The indended new version of scala-swing will be 2.2.0.

with a new major version since multiple API changes happen (mostly simplifications).

@Sciss I think this should be 3.0.0 then, not 2.2.0?

Are we not in "old style" semver, like ..? Then wouldn't 2.2.x follow after 2.1.x ? I mean, 1.0.x was never correlated to Scala 1.

In general in the Scala modules we use major.minor.patch. Bump patch if bugfix only; bump minor when adding a feature; bump major when breaking bincompat.
So yeah, I would prefer we call it 3.0.0 unless you have a strong opinion otherwise.

Oh, alright. Then I will just edit the README.


Photo(s) of identity card

Avoid duplicates

[ ] This enhancement request has not already been raised before
[ ] Enhancement request is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
[ ] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

Suggested Enhancement

Only once I was asked for my identity card to show with my certificate. That was no problem for me. But my partner forgot his card.
So it would be a nice idea to be able to take a photo of both sides of the identity card and safe it with the certificate.
Expected Benefits

You have both together. Identity card and certificate.

Internal Tracking ID: EXPOSUREAPP-10778

Hi @ChrisR69. thanks for your feature request. We have moved this issue to the cwa-wishlist repository, as it is not an iOS specific feature request (thanks @Ein-Tim for pointing out). In addition, we have created an internal ticket for it.
Internal Tracking ID: EXPOSUREAPP-10778

Corona-Warn-App Open Source Team

If this gets implemented despite the potential data protection complications, it would be nice to only be able to add the ID card by scanning it via NFC, unlocking it with our ID's PIN. This would make it harder to just make a photo of an ID of someone who looks similar to me.


Fix Alias for user mode

Fixes #479

Will there be an alias prefix for regular pool mode? and does alias prefix only work on your local?


(BadMapError) expected a map, got: "string"

Hi there, super interested in trying this out, but I'm getting an error for the spec I'm using it with. Any help would be much appreciated, thank you!
Spec:
https://github.com/webflow/openapi-spec/blob/main/openapi/v2.yml
Error:
mix api.gen default ./v2.yml

10:50:18.864 [debug] Beginning code generation
Profile: "default"
Files: [
  "./v2.yml"
]

10:50:18.868 [debug] Reading file ./v2.yml
** (BadMapError) expected a map, got: "string"
    (elixir 1.17.1) lib/map.ex:535: Map.get("string", "title", nil)
    (oapi_generator 0.1.1) lib/open_api/spec/schema.ex:152: OpenAPI.Spec.Schema.decode/2
    (oapi_generator 0.1.1) lib/open_api/reader/state.ex:180: OpenAPI.Reader.State.with_schema_ref/3
    (oapi_generator 0.1.1) lib/open_api/reader/state.ex:111: OpenAPI.Reader.State.with_path/4
    (oapi_generator 0.1.1) lib/open_api/spec/schema.ex:292: anonymous fn/2 in OpenAPI.Spec.Schema.decode_properties/2
    (stdlib 6.0) maps.erl:860: :maps.fold_1/4
    (oapi_generator 0.1.1) lib/open_api/reader/state.ex:111: OpenAPI.Reader.State.with_path/4
    (oapi_generator 0.1.1) lib/open_api/spec/schema.ex:143: OpenAPI.Spec.Schema.decode/2

Repo to reproduce:
https://github.com/cspags/ex_webflow_api_client

Hi @cspags, thanks for reporting this.
I spent some time looking into what's causing this, and the spec has an interesting pattern in it:
- properties:
    code:
      type: string
      description: Error code
      enum:
        - missing_scopes
    type: string

As a human reading this, I interpret it to mean that the parent object has a property code and can have additional properties with any name and string values. Normally in this situation I would see something like this:
- properties:
    code:
      type: string
      description: Error code
      enum:
        - missing_scopes
  additionalProperties:
    type: string

This is done elsewhere in the spec, so it's interesting that they don't do it here. It's also possible that they want to specify a property called type with string values, which would normally look like this:
- properties:
    code:
      type: string
      description: Error code
      enum:
        - missing_scopes
    type: string

I'm not sure if you have a way to ask questions of the spec authors, but it may be worth reaching out if so. While it's definitely possible for me to modify the reader to look for type: _ as a property and treat it as a generic additional property, this could have the potential side affect of not allowing specs with a property called type.

Thanks @aj-foster for taking the time to look into this, I appreciate it. I agree it looks like an issue with the spec. I will reach out to them and see what I can learn. Feel free to close this issue as I think you're right that it's not worth accounting for this due to the potential for side effects.
Thank you!

Hope you get some resolution. As you learn more about their intent, I'd love to hear about it! ❤


[New Challenge] Crack image captcha using Padding Oracle Attack

This pull request is a work-in-progress, and for now lacks tests to make it a regular challenge.
I would like to hear your thoughts on this type of challenges. I plan to use the modification for my classes on Web Application Security.
Description
Currently, the image captcha is returned to the user together with the answer. To make it more realistic and to
enable stateless verification, we could encrypt the answer (as verifier) and had it send back together with the user's answer.
If the decrypted verifier matches the user's answer, it is all good.
However, the verification might fail for two reasons:

the decryption works, but the original answer does not match the user's answer (Wrong answer...)
the decryption fails, because the ciphertext (or IV) has been altered and now it does not produce a correct padding (Something went wrong...)

This means that the verification endpoint (/rest/user/data-export) might work as a padding oracle, where "Something went wrong" means that the padding is incorrect, while "Wrong answer..." means that the padding is CORRECT but the decrypted verifier does not match the answer.
In the current implementation we use AES256 in CBC mode with a static key and PKCS#5 padding scheme (default for Node's Crypto library). If the user alters the verifier (IV and ciphertext separted by a colon) it might result in wrong padding.
Padding Oracle
Due to the construction of CBC mode, by controlling next to the last block of ciphertext and having a padding oracle we can determine the internal state of the last block. It means sending a modified ciphertext (together with IV) and observing the output. With this attack, the whole internal state of the decipher might be reconstructed and the plaintext message might be recovered. Padding Oracle Attack also allows to ENCRYPTING an arbitrary method with an unknown key.
The original idea comes from: J. Rizzo, T. Duong, "Practical Padding Oracle Attacks", 4th USENIX Workshop on Offensive Technologies (WOOT 10), 2010, URL: https://www.cs.umd.edu/~jkatz/security/downloads/padding-oracle-attacks.pdf
Affirmation

[x] My code follows the CONTRIBUTING.md guidelines

I like the idea of making the CAPTCHA more realistic and also harder to solve. Also, the data export actually doesn't have any challenge built around its CAPTCHA yet, so adding one would be really great! From the top of my head I could only think about a timing challenge simular to the Bypass CAPTCHA challenge against the feedback form, where you're supposed to leave a lot of comments in a short amount of time that requires automation (or a really annoying Browser tab preparation 😁) ... if we did the same here, it could become something like exporting the data of 5 different users in a certain amount of time, and it could be set up something like this maybe?
-
  name: 'DLP Failure'
  category: 'Broken Anti Automation'
  tags:
    - Brute Force
  description: 'Retrieve a data export for 5 or more users within 60 seconds.'
  difficulty: 6
  hint: 'You need to combine automation and cryptoanalysis skills for this one, unless you are really good at manually solving image CAPTCHAs fast.'
  hintUrl: 'https://pwning.owasp-juice.shop/part2/broken-anti-automation.html#retrieve-a-data-export-for-5-or-more-users-within-60-seconds'
  mitigationUrl: ~
  key: dlpFailureChallenge

Just an idea that might be relatively easy to track by internally counting data exports with timestamps and check if the condition of 5 different users in 60sec was met at the end of each successful export.


Use serviceID's in IBMCloud for testing

/area testing
Currently, we are using personal API keys for running tests on IBM cloud pipelines, we will replace it with the service IDs API key so that we don't have to use personal API keys for any operations.

Acceptance Criteria

update IBMcloud Pipeline jobs with service ID apikey
Update scripts to use service ID(only affects OpenShift tests)


Need help with 10.0.22621.608

termsrv.zip
Need help with 10.0.22621.608
The dll file I attached here

The same problem here:

https://github.com/sebaxakerhtc/rdpwrap.ini/commit/76ea2582c8c509f0689afeff9b9abcbe210da662

It works fine with update!
Thank you

Thanks @sashaqwert , works for me!

I just upgraded windows to this version, adopted this new ini file, but then I noticed that the rdpwrap mod is no longer present in the system, and I can't install it any more due to 'access is denied' error, even if in elevated powershell or cmd.
What should I do.

@xinstein

but then I noticed that the rdpwrap mod is no longer present in the system, and I can't install it

See https://github.com/stascorp/rdpwrap/issues/1883

@xinstein

but then I noticed that the rdpwrap mod is no longer present in the system, and I can't install it

See #1883

Turns out windows defender re-blocked the install.bat, manually allowing it fixed my problem

不支持远程，

I downloaded a new ini file and did the following:
Download RDP Wrapper 1.6.2 and extract this to any directory.
Place rdpwrap.ini in the same directory.
Open CMD as administrator
Execute this commands

cd C:\path\to\directory
rdpwinst -u -k

rdpwinst -i

RDPConf.exe

after that, I can still open only one RDP session.
What else can I do?

Occasionally RDPWrapper needs to be reinstalled following an update. I have bat files for that. Remove the .txt from the end of each file name.
Run the uninstall first then the install. Use update to update the ini file after successful install. Edit the update file to copy from the correct location.
RDPWinst_uninstall.bat.txt
RDPWinst_install.bat.txt
rdpwrap_update.bat.txt

I'm doing all the previous procedures and it's giving me an "Access Denied" error
Can anybody help me ?

it's giving me an "Access Denied" error

You need to add your RDP users to the Remote desktop users group or Administrators.

I redid the users, but even so it gives me the same error.
But the error, it presents me even before putting a user or password to make the connection
Attached is a print of the error and the RDP
Error Access Denied

RDPConfig.Exe

sebaxakerhtc/rdpwrap.ini@76ea258

thx!!!

这个termsrv.dll是怎么用的

这个termsrv.dll是怎么用的
How is this termsrv.dll used

See http://www.youtube.com/watch?v=FiD86tmRBtk


Automatic Deletion of Unprotected branches on PR merge with toggleable switch

Gitea version (or commit ref): 1.14.0+dev-208-g6280af032
Git version: 2.29.0
Operating system: Linux Ubuntu 16.04
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No (not a bug.)

Log gist:

Description

Toggleable switch at project level for use
if an unprotected branch is merged while switch is set to true, that branch gets deleted
protected branches are unaffected

Screenshots

similar  #3905

I think merge option will get to overloaded, should we make this a user and/or repo setting?

Yes I intended it to be togglable in the repo's own settings. I don't user repos that often, I considered one at organization level, because I will be personally enabling them in most of our projects but figured it would be too annoying to have 3 options of 'organization default', on, off

Assume the situations:

[ ] The branch is a default branch on the same repository.
[ ] The branch is a default branch on the forked repository.
[ ] The branch on forked repository has also been sent to another upstream.
[ ] There are some PRs sent to the branch.

@lunny Can't forked repositories change the fork repo settings? I would have thought so…

@delvh You can, but if you have many forks, you may have to change every repository. Since the fork repositories is your copy of original repositories, so the settings depends on your personal usage habit.

A checkbox like this on the merge form could already be an easy win. Even if it would be disabled by default, at least it saves you from scrolling down to the bottom of the page, clicking the delete branch button and the confirmation dialog. And it serves as a reminder too.

A checkbox like this on the merge form could already be an easy win. Even if it would be disabled by default, at least it saves you from scrolling down to the bottom of the page, clicking the delete branch button and the confirmation dialog. And it serves as a reminder too.

Maybe the text could be Delete head branch if not protected or default.

I would prefere @jpraet way but hide it if the branch is protected ...

Or disable the checkbox and display the reason


Closes #165: Implement Cookie Consent

 Description
Implement basic cookie notice. Content was taken from Scrumlr V1.
TODO:

[ ] Get approval of content
[ ] Get design
[ ] Do Not Track - Header Funktion hinzufügen

Blocked -> Waiting for design


[SCB-1204] acceptance test with consul

We need update the License file version at the same time.

Ok, I will remind you after I change it.


[8.x] Add a mergeToTop() method

Hi,
I created a PR with a new mergeToTop() method for collections.
This allows users to merge a collection, but append it to the top.
An example:
$collection = collect(['Apple', 'Banana']);

$collection->mergeToTop(['Pineapple']); // ['Pineapple', 'Apple', 'Banana']

Thanks! Jeroen

Would it make sense to call this unshift instead? Would that closer match the php equivalent of array_unshift

Maybe, but I don't think so as it uses the array_merge() function, and is built on top of the merge() method.

Just turn the thing you want to merge to the top into a college and then ->merge the other collection into it. 👍

@taylorotwell that's true, but not if you first want to do other things on the collection, for example:
collect(['Banana', 'Apple', 'Pear', 'Orange'])
    ->each(fn($fruit) => strtoupper($fruit))
    ->shuffle()
    ->take(3)
    ->mergeToTop(['Pineapple', 'Mango']); // ['Pineapple', 'Mango', 'APPLE', 'ORANGE', 'PEAR', 'BANANA']

Yes, you could do it this way:
$fruits = collect(['Banana', 'Apple', 'Pear', 'Orange'])
    ->each(fn($fruit) => strtoupper($fruit))
    ->shuffle()
    ->take(3);

collect(['Pineapple'])
    ->merge($fuits); // ['Pineapple', 'Mango', 'APPLE', 'ORANGE', 'PEAR', 'BANANA']

But in my eyes the first example is a lot cleaner.


@push('meta') doesn't work correctly

Pushing description and og:description to the meta stack doesn't work the way it should -- since there is <meta property="og:description" content="{{ $page->siteDescription }}" /> above, it takes precedence.
Also this should be fixed in the master layout:
-<meta name="description" content="{{ $page->meta_description ?? $page->siteDescription }}">
+<meta name="description" content="{{ $page->description ?? $page->siteDescription }}">

The og:description can be fixed by making this change to the master layout:
-<meta property="og:description" content="{{ $page->siteDescription }}" />
+<meta property="og:description" content="{{ $page->description ?? $page->siteDescription }}" />

And the og:url can be removed from the post layout, since it's the same in the master layout.
I can create a PR fixing this.
However, I'm not sure how the og:type should be overwritten:
master:
<meta property="og:type" content="website" />

post:
<meta property="og:type" content="article" />

The type should probably come from some $page property or method.

I think we should probably remove the @push('meta') sections from the pages that they're on now (since they're causing duplication, as you say), and just use page variables where necessary. So we can update the meta block in master to read:
...
<meta name="description" content="{{ $page->description ?? $page->siteDescription }}">

<meta property="og:title" content="{{ $page->title ? $page->title . ' | ' : '' }}{{ $page->siteName }}"/>
<meta property="og:type" content="{{ $page->type ?? 'website' }}" />
<meta property="og:url" content="{{ $page->getUrl() }}"/>
<meta property="og:description" content="{{ $page->description ?? $page->siteDescription }}" />

...

...then, on top-level templates (like about, blog, contact), use variables to set descriptions where desired:
---
description: A little bit about the site
---

@extends('_layouts.master')
...

In the case of _layouts/post.blade.php, though, we'd have to set $page->type in a @php block; that template is extended by the individual posts, so we can't add YAML front matter to it. But this would set type to article for all pages that extend post.blade.php:
@extends('_layouts.master')

@php
    $page->type = 'article';
@endphp

...


[Snyk] Security upgrade node from 14 to 18.19.1

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to node:18.19.1, as this image has only 170 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

829
Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
Mature

829
Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
Mature

829
Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
Mature

829
Out-of-bounds Write SNYK-DEBIAN10-LIBWEBP-5893093
Mature

829
Resource Exhaustion SNYK-DEBIAN10-NGHTTP2-5953390
Mature

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

Checkmarx One – Scan Summary & Details – dfbd978a-a5db-4c12-8e1c-d9a1b6652a30
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2024-28176
Npm-jose-4.13.1
Vulnerable Package

CVE-2024-28849
Npm-follow-redirects-1.15.4
Vulnerable Package

CVE-2024-28849
Npm-follow-redirects-1.14.8
Vulnerable Package

Healthcheck Instruction Missing
/Dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Image Pull Policy Of The Container Is Not Set To Always
/deployment.yaml: 1
Image Pull Policy of the container must be defined and set to Always

Multiple RUN, ADD, COPY, Instructions Listed
/Dockerfile: 16
Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.

Multiple RUN, ADD, COPY, Instructions Listed
/Dockerfile: 10
Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.

Fixed Issues

Severity
Issue
Source File / Package

Healthcheck Instruction Missing
/Dockerfile: 1

Invalid Image Tag
/deployment.yaml: 1

Multiple RUN, ADD, COPY, Instructions Listed
/Dockerfile: 16

Multiple RUN, ADD, COPY, Instructions Listed
/Dockerfile: 10


Investigate how to autoscale Github self-hosted Azure VMs

It's been a while the community has discussed if it should be adopted Github Actions plus self-hosted runners for e2e CI, instead of sticking with current Jenkins-centric approach taken by heritage from Kata Containers.
Based on the last discussions, and that's my opinion, I believe we will end up embracing the Github approach. If so, we will need to figure out how to manage self-hosted bare-metal and VM  runners.
While Github clearly states security risks of using self-hosted runners with public repositories, it also suggests some mitigations that can be taken, being one way of hardening security is to use ephemeral VMs.
Recently it was stated that we could have some funding from Microsoft to leverage Azure resources on CI. I don't know if we will have access to bare-metal machines on Azure, but certainly to VMs.
I glanced at Github's docs and I found that there some runners autoscalers recommend but none seem to support Azure VMs. So, for me, it is still an open question how we gonna manage those ephemeral VM runners.
Therefore, I am opening this issue to use for discussions and record any findings.
Related to: https://github.com/confidential-containers/community/issues/67

There's https://github.com/cloudbase/garm too


sources and detectors could not be aligned to an Atlas

Hello,

I am doing image reconstructions and trying to align my concentration data to atlas. I use AtlasViewer <IP_ADDRESS> and find it could not successfully load probe from my converted .snirf data (see the result). I am doing a temporal scanning while all of the probes are in vertical shape and do not align with the surface. Any functions that are related my probe will result in errors like:
Error using *
Incorrect dimensions for matrix multiplication. Check that the number of columns in the first
matrix matches the number of rows in the second matrix. To operate on each element of the
matrix individually, use TIMES (.*) for elementwise multiplication.
Error in registerProbe2Head (line 21)
probe.optpos_reg = optpos*T;
Error in AtlasViewerGUI>pushbuttonRegisterProbeToSurface_Callback (line 679)
probe = registerProbe2Head(probe, headvol, refpts);
Error in gui_mainfcn (line 95)
feval(varargin{:});
Error in AtlasViewerGUI (line 19)
gui_mainfcn(gui_State, varargin{:});
Error in matlab.graphics.internal.figfile.FigFile/read>@(hObject,eventdata)AtlasViewerGUI('pushbuttonRegisterProbeToSurface_Callback',hObject,eventdata,guidata(hObject))
Related documentation
Error while evaluating UIControl Callback.
I am wondering is it the problem of the AtlasViewer or our data?
Please check my data here if need:
https://gocuhk-my.sharepoint.com/:u:/g/personal/siqigao_cuhk_edu_hk/EX0GbQ61qkdPvrVCUY_t6hIByOZ1MtThGuDaq5Kxdx3aOQ?e=arBA3l
You can find the bug by using the code below to convert the .lufr into .snirf by lumomat (ver.1.8.0)and call out the AtlasViewerGUI (ver.<IP_ADDRESS>) in the command line immediately.
data = LumoData('testA.lufr');
snirf = data.write_SNIRF('testA.snirf', 'time', 'explicit');

Hello @labteng. Unfortunately, I don't get the error when I load your data using your setup. Can you show me the exact steps that you take in AltasViewer?
The steps that I followed: open the GUI and then choose Tools->Probe->Load in AV. After selecting a SNIRF file, it loads the data with a prompt asking about the registration marks. I get a warning below, but I do not get your error.
WARNING: Loaded probe lacks registration data. In order to register it
to head surface you need to add registration data. You can manually add
registration data using SDgui application.

The warning can be fixed by either adding the registration data using SDgui or registering to head size on AtlasViewerGUI. We recommend you seek the AtlasViewer documentation for this.

Hi @nidadu, would you please try setting the current working directory to the data location, and then directly call out AtlasViewerGUI from matlab command line? After AtlasViewer loads the data automatically, you might see my bug.
I also try your method. The probes' distribution changes however, the location of every probe went a bit down and away from brain. Can you also check your result for that?

Hi @labteng. Thanks for confirming.
I repeated your steps of setting the working directory to the data file location and calling AtlasViewer from the command line. I did not get any errors, and the optode positions were successfully loaded on the atlas. The positions were not aligned correctly, but that can be expected. The result was similar to that obtained with the method I described previously. As I mentioned above, one way to adjust the optode positions is to add the registration data.
As I can't find anything wrong with lumomat in this case, I will close this issue. I would recommend reading through the AtlasViewer documentation to learn how to adjust the location of the probes on their software, or seek help through their appropriate channels. Alternatively, you could email Gowerlabs to ask for research support.

Thank you @nidadu.
About the registration data, I do have issues to follow up. Please see the new po I just created.


Transform, Basis, Quat changes in Mono implementation

(Since GodotSharp has effectively been moved here, I'm moving this issue here too.)
There's been compatibility breaking changes/fixed in these classes in Godot, so corresponding C# code will also need to be updated.

Yes, I'm in the process of updating all those files and once I'm done I will rename them to PascalCase and add the summary comments from the docs.

@neikeq I'm don't know how far along you're with this but if you haven't made changes in those specific classes, I can update them

OK, done: I fixed the ones I found in #11899.

This is fixed by #11899. These classes are still incomplete but the behavior of the implemented functions should be correct now


ESHIP

Updated ESHIP Token details in json file and logo including some corrections. Please check. Thank you very much!
Token Name: EliteShipperToken
Token Symbol: ESHIP
Smart Contract Address: 0x06bead2ead661b51307b646f7419d5284330c135

请删除 erc20/$template.json 文件修改。


jax.nn.one_hot should not allow float inputs

Description
Currently, jax.nn.one_hot() fails silently on float inputs:
>>> jax.nn.one_hot(jnp.array(0.0, jnp.float32), 4)
Array([1., 0., 0., 0.], dtype=float32)

>>> jax.nn.one_hot(jnp.array(0.5, jnp.float32), 4)
Array([0., 0., 0., 0.], dtype=float32)

>>> jax.nn.one_hot(jnp.array(1.9999999, jnp.float32), 4)
Array([0., 0., 0., 0.], dtype=float32)

>>> jax.nn.one_hot(jnp.array(1.99999999, jnp.float32), 4)
Array([0., 0., 1., 0.], dtype=float32)

JAX should probably assert that the input is an integer type.
Would have prevented a subtle bug in our case 🙂
System info (python version, jaxlib version, accelerator, etc.)
N/A

Thanks for the report! Yeah it looks like we assume the input is integer, but never check that. I think my preferred fix here would be to error if the input array is not integer-typed. An alternative would be to cast float inputs to integer type. What do you think?

Agreed, raising an error seems better.
The case where a float is passed intentionally seems less common (and warrants explicit casting) than the case where it's an accident on the user side and should complain loudly.

There are use cases when you might want one hot structure in an array using floats.  Would it be best to default to ints unless a dtype is provided specifically stating that yes you want a float etc.

If you have floats, you can always cast them to int before one-hot encoding them.


test: add pagination tests

Pull Request Test Coverage Report for Build 58

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 74.746%

Totals

Change from base Build 52:
0.7%

Covered Lines:
1098

Relevant Lines:
1400

💛  - Coveralls


python311Packages.publicsuffixlist: <IP_ADDRESS>40127 -> <IP_ADDRESS>40201

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285525 run on x86_64-linux 1

13 packages built:

parsedmarc (python311Packages.parsedmarc)
parsedmarc.dist (python311Packages.parsedmarc.dist)
pretalx
pretalx.dist
pretalx.static
python311Packages.checkdmarc
python311Packages.checkdmarc.dist
python311Packages.publicsuffixlist
python311Packages.publicsuffixlist.dist
python312Packages.publicsuffixlist
python312Packages.publicsuffixlist.dist
trustymail
trustymail.dist


Mimic reCaptcha in procaptcha bundle

reCaptcha

[x] Use site key
[x] Automatically append data to form data
[x] Render on all elements of certain class name

Procaptcha

[x] Convert calls to contract into wrapQuery to surface errors
[ ] Confirm ownership of site key by sending signed proof from server side

Confirm ownership of site key by sending signed proof from server side

This is pointless as the server could be called from anywhere. Need an alternative approach.


Recommended Products have no order

We can see ranking on Recommended products in Dashboard only.
There are no ordering on Product detail page.
Oscar master, Django 1.8

To implement this we need something like https://github.com/gregmuellegger/django-sortedm2m

Apart from that, noticed formset styling issues locally, recommended product dropdowns have different width and not aligned:

And initially dropdown is too narrow:

Did you experience that too locally @dimka665 @mvantellingen @john-parton ?

@sasha0 I don't use the recommend products feature, so I really don't know.
I actually search my elasticsearch backend with a "more like this" query.


Ameerul / FEQ-2453 Show a message if the user is banned from using P2P

Added flows for Permission Denied, perm banned user, cashier is locked, system maintenance
Added new custom hook useIsP2PBlocked
Updated content in BlockedScenarios

https://github.com/deriv-com/p2p/assets/103412909/0a19542e-662d-4879-936a-64852e05f68b
https://github.com/deriv-com/p2p/assets/103412909/3c3adee0-046c-46ec-82d9-31ac99986372
https://github.com/deriv-com/p2p/assets/103412909/1dafa2a5-b13d-4fbe-b370-0690eba2c9f8
https://github.com/deriv-com/p2p/assets/103412909/1d17ca07-bca0-49d8-858a-829a075d2135
https://github.com/deriv-com/p2p/assets/103412909/259defa7-d2c2-4c25-a479-2967a0b207a7

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

34 of 34 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 85.567%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
5474

Relevant Lines:
5948

💛  - Coveralls


Include paper abstracts (e.g Arxiv, APS)

Someone should scrape abstracts (perhaps full papers, but that may get too long + converting whole papers to text might be an issue) from data sources such as:

Arxiv
https://journals.aps.org/

we can then include them in a separate chromadb database and have it query relevant abstracts. We have some of the work done for this already, just need someone to be in charge of seeing it through.
Question:
{text}
Thinking:
{text}
Answer:
{text}
Relevant Papers:
{text}
Shot Logs:
{text}

https://w3.pppl.gov/~jchen/index.html <-- has some textbooks

Jeff suggests APS abstracts (and can maybe associate with peoples' names)
Charlie and Sterling recommend grabbing publications from GA tracker
Ricardo and Neal recommend OSTI


Does not compile for 3v3 Pro Micro

I keep getting errors compiling for the 3.3V Pro Micro board. I am running Windows 10, with the latest versions of FastLed, and the CLP library.
Here are the errors I get, which make me think there could be something wrong with the boards declarations:

It works when I use the 5V one (and I uploaded the sketch to the 5V board and it works as expected).

Oh, yes looks like the line https://github.com/Legion2/CorsairLightingProtocolBoards/blob/master/avr/boards.txt#L59 is wrong.


⚠ Bofrost.lu has degraded performance

In c18d463, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2540 ms

Resolved: Bofrost.lu performance has improved in 53226cb after 46 minutes.


add havoc

Description
Added havoc, one of the first, if not the first, fully functional terminal native to wayland.
Checklist
I have:

[x] 🤳 made sure that what I am adding is an app for end users, not a developer tool / library (no "wl-clipboard-rs")
[x] 🔗 checked that the link I am using refers to the root of the project (example, https://mpv.io) or GitHub repo if the first is not available
[x] 🤓 checked BOTH the name and the casing of the project(s) I am adding ("GNOME Terminal" and not "gnome-terminal", "bemenu" and not "Bemenu", etc.)
[x] 💣 checked that I am using spaces for indentation and that my levels are correct (no tabs!)
[x] ✋ checked that my section has the correct casing ("My section", and not "My Section")
[x] 📝 checked that the projects and / or the section are alphabetically sorted ("Clipboard manager" then "Color picker", "bemenu" then "Fuzzel")

Thx!


p2p peer review

An issue to discuss implementation details of p2p peer review. I've documented some of my thoughts on what a p2p review process might look like (see https://github.com/lukeburns/peer-review) fwiw.
My initial thoughts on an implementation are to create modules in the hyper* ecosystem that include mechanisms for publishing feeds under a "publishing feed" that includes identity metadata and a collection of feeds (Would multifeed or dat-pki be helpful?) of publications and forwarded publications that would benefit from review, plus linking between feeds so that one can find reviews of a given feed (hyperdb?).
 Yes that sounds very close to what I've been thinking!
dat-pki in general is the plan for authenticated distributed group membership for feed creation and subscription, and an iterative peer review system is a particular way of structuring linked feeds with permissions and group membership.
Late here but I'll read your repo tomorrow and write up my thoughts.

@lukeburns what do you think about extending your model beyond pre-publication?
While one common entry point would be authors requesting peer reviews before publishing another could be someone deciding to review already published work or work that is available on preprint datasources.

Sure! I see two approaches: linking to external sources or, better, replicating the external publication on the network as a static hyperdrive. The latter option is nice because it doesn't require the author to publish on the network for the paper to be reviewed and it helps ensure the availability of content by distributing it across peers.

@lukeburns, do I understand correctly that you propose the following workflow for a review?

Reviewer or author copies publication to a new review hyperdrive
Creator of the review hyperdrive shares it with the target audience (e.g. author, reviewer group, publisher)
Reviewer adds comments to the hyperdrive alongside the publication
Author comments on reviews / updates publication
Optionally: The review hyperdrive creator makes it public and links the hyperdrive to the updated/released publication so people can see the review process

@lukeburns the P2P process is very interesting compared to the traditional process!
@Igro as I understand @lukeburns proposal, it is more or less like you say, but it is a more open and transparent process.
In step 2 the Author forwards to selected peers he/she knows, and should be involved
Then there would be a step 2a where these peers in turn find other peers (and maybe they also forward again) that are valuable reviewers
In this way scientific work would become available to a larger group sooner, which in turn might lead to quicker validation and better feedback.

One other thing to consider:
I don't have much experience with scientific review processes in particular, but I've worked a lot with cms'es in a SaaS environment where you have e.g. content review processes.
Here we never had just one review type. We had many:

each tenant had their own review process
some tenants used multiple review processes (selected manually or automatically based on content attributes)
processes contained parallel as well as sequential flows
processes that were very simple, e.g. parallel content review + (unanimous or consensus) approval
or much more complex, e.g. content approval + brand compliance approval + regulatory approval + corporate approval
we had review processes depending on other review process (content depending on other draft content)
we had altogether different processes than review acting on content
etcetera

We used state machines (for the simple cases) and workflow engines (for the complex ones) to implement this.
Now in no way am I recommending you to include a workflow engine. Just saying you should think carefully what processes you are gonna support, now and in the future, and design accordingly so that adaptation and extension do not introduce too many breaking changes.

@aschrijver that 2a step you are mentioning, would you envision that as a restart of the whole process, starting again at 1 with a replication of the publication? I am sceptical about if/how it would be feasible to let non-owners extend the visibility of an encrypted hyperdrive, based on the dat-pki.
(Thanks all for demonstrating that a lower-case L is a really bad choice for my username. Also sorry @igro for the confusion.)

First of all, this was my interpretation of how things work, you'll have to ask @lukeburns to be sure.
But ya, that's basically what it boils down to, I guess.
But not sure, because when allowing the review to spread out on an organically growing network of peers (which you don't control as original author) this raises the question how you know that all the vital reviewers are done reviewing (those that are required to participate, not the nice-to-haves)

Some more analysis based on my previous observation..
A review could be addressed to:

a boundless number of peers (public review)
boundless but with a bounded set of required reviewers (public + internal review)
restricted to a set of required reviewers (internal review)

A review process could stop when:

never, will collect validation indefinitely (not a good idea)
cancelled by the author (if the paper was inaccurate or bad)
cancelled by some other authority (the institution?)
when the required set of reviewers has finished
at a specific moment in time, or after a fixed timespan
when a threshold is reached (consensus, no. of reviews, etc.)

This raises the follow-up question: How do you stop a review process, avoid people wasting time?
All these choices have (potentially significant) design impact and lead to further questions.

@lgro a minimal and fairly generic implementation might be a hypercore-archiver + a feed of the keys in the archive:

each peer in a review network has a hypercore "replication" feed consisting of hyperdrive keys that they think would benefit from review by their peers and replicates these feeds.
each peer follows the replication feeds of chosen peers.
upon learning of a new hyperdrive from a peer's feed, each peer has a choice of (1) ignoring it, (2) appending it to their replication feed, or (3) publishing a review feed/hyperdrive and appending it to their replication feed, which is then filtered / reviewed like a normal publication.
at anytime, a peer can publish a hyperdrive (say an original article, as a live hyperdrive, that undergoes revisions, or an external article that they think needs review, as a static hyperdrive) and append it to their replication feed.

this says nothing about the structure of reviews (maybe comments on a hypercore feed or a hyperdrive with latex files). it also says nothing about how peers find each other, so it could work for open or closed review networks.
there are a couple issues with this proposal.
the propagation of reviews through the network might be too slow if it has to go through the same filtering process that publications do (through steps 1, 2, 3). one way around this might be to have all peers auto-replicate reviews. they could even auto-replicate publications if filtering is not necessary for the size of the network.
additionally, while it's important that peers be able to have filtration control, peers with no followers are unheard. one could implement a process by which to "push" messages to new peers (e.g. https://github.com/jayrbolton/dat-pki/issues/7), so that a reviewer can push a review onto the network, whether or not they are followed by other peers, or to send "follow requests." otherwise, a peer needs to find a "champion" who is already connected to other peers somehow and convince them to replicate their publication / review, which might be all one needs in a small review network (e.g. an undergrad student researcher on a network consisting of collaborators on a research program has a review replicated by their advisor).
a beefier implementation might use dat-pki and allow for selective sharing with groups or individual peers. i think this is a good first step that works with minimal dependencies.

@LGro so to actually answer your question, the key differences between what you said and what i'm imagining are how publications are shared and filtered and the structure of reviews (which i'm not settled on yet):

peer (author or reviewer) publishes new hyperdrive, appends to their replication feed (i.e "submits a review request" to their peers), and optionally shares directly with off-network peers
their peers either (1) ignore, (2) forward to their peers, or (3) goes to step 1 to publish a response
(optional) publication or review hyperdrives are cited off-network

@lukeburns I think it depends on who you see as your audience.
If you would like eventual adoption by academics, I think it would be best/easiest to start with 'traditional' peer review, where articles are submitted/reviewed and then eventually accepted by a 'journal'. Then, in addition to that there can be 'free for all' review anyway afterwards or before ppl could ask for input on work in progress like for example researchgate also offers. The reason for this is, that for the foreseeable future, people need to show that they have certain acceptable publications, such as when applying for jobs or just generally to establish credentials. This is easiest if a 'journal' curated by a group of specific individuals can build reputation and then I can show I published there. OTOH, if I would have to say 'well, 10 peers whoever they are,  reviewed my work' without knowing who they are or not knowing their credentials, it's worthless for this purpose.
I realise this doesn't address everything mentioned above or not in as much detail, but maybe sth to keep in mind.

@step21 the above proposal isn't free for all review, although you could do that. it works for arbitrary networks of peers, so you could easily put together a closed group of reviewers / editors for a journal using this. you could even do more interesting things like e.g. build a trusted network of reviewers underlying a consortium of overlay journals, so that the overlay journals have a consistent and reliable source of reviewers to tap into.

Sure. @lukeburns thanks for the clarification. That sounds really great. In general I just think that a lot of what I hear from #openscience or movement of 'against publishers etc' is just very much like 'free everything' without a replacement, or a very disorganized one. If projects like sciencefair actually want to include academics and give them a platform, I think it is important to consider these things. Like how best to include them, things like that. Also because if I am just a random Tech Guy with an opinion or something, I would just use a blog ;)


[master][clang-format] Re-format cc. .h. .cu files; cond.

Description
This pull-request contains clang-format changes.
Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.


Refactor tile component

Context
To support linking cards in the performance dashboard, the AnchorLinkComponent was created. However, it may be more elegant to allow the TileComponent to accept an href param, which if present, links the card.
And, with the possibility of a card having a link, we can then style linked cards properly, giving them hover and focused states, too.
Changes proposed in this pull request

Add href param to SupportInterface::TileComponent
Add app-card__link styles
Update performance dashboard page to use new param on this component value instead of using separate SupportInterface::AnchorLinkComponent
Remove SupportInterface::AnchorLinkComponent

Guidance to review
Is there a better way of writing the component rather than having to rely on this somewhat ugly code:
<%= href ? "".html_safe : '' %>
  …
<%= href ? "".html_safe : '' %>

Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

@paulrobertlloyd can you also extend https://github.com/DFE-Digital/apply-for-teacher-training/blob/master/spec/components/previews/support_interface/tile_component_preview.rb to include an example of a component using a link please.

@despo Added a test for a linked card in 85fcd0de0c60b03fa6e340d391fc5be8696dbc39. Is this correct?

@paulrobertlloyd have you seen the component previews? You can access them locally and makes reviewing a lot easier as we can see how the component behaves on the heroku review app. e.g.  https://apply-for-te-refactor-t-auuc6g.herokuapp.com/rails/view_components/support_interface/tile_component

@paulrobertlloyd have you seen the component previews?

I had, but never thought to investigate how they are generated. I found out! So here’s a preview of a linked tile: https://apply-for-te-refactor-t-auuc6g.herokuapp.com/rails/view_components/support_interface/tile_component/linked_tile


allow calling raise without arguments

sometimes I just want to raise to stop execution or do something stupid / debug ... would be nice if that worked
... not sure about the test location ... and was unable to run with 0.19.2
bin/crystal spec spec/std/exception_spec.cr
cc: error: /app/src/ext/libcrystal.a: No such file or directory
Error: execution of command failed with code: 1: `cc -o "/root/.cache/crystal/crystal-run-spec.tmp" "${@}"  -rdynamic  -lxml2 -lpcre -lm -lgc -lpthread /app/src/ext/libcrystal.a -levent -lrt -ldl -L/usr/lib -L/usr/local/lib`

@grosser can you try running make std_spec instead of using bin/crystal? I think running make deps would fix the error, but it's recommended to use make when developing the crystal compiler.

I prefer the behavior that raise inside a rescue block would reraise the current exception. IThis is similar to many other languages. Calling raise without a current exception being handled would be a wrong usage, and we could raise some exception type for this. (Calling throw; in C++ when there is no current exception simply aborts the current program)

@lbguilherme well I really don't think that this is enough trouble to warrant a language feature:
begin
  raise "ex"
rescue ex
  raise ex if ...
end

@lbguilherme +1, see #3181. Unfortunately, it'd require messing with the global state which is a no-no, especially after 0.19, where globals are gone for good.

yeah did not think about re-raise ... raise without argument just working would be confusing / lead people to believe that it re-raised ... so ideally it should fail and say "Raising without argument is not supported, please pass a message or the exception you want to re-raise" ... not sure if that is easy to add ... closing this for now since I think it would make things worse.

One approach would be to take the Ruby route and allow raises without arguments both inside and outside exception handlers, but with different behaviours - raise outside simply raises, whereas inside it will default to the exception being handled.

You only need local state for that - noone would expect raise in a method called from the exception handler to magically know where it was called from.