Attachable API not working

I was trying to upload a PDF attachment to a Bill, and got the following error..
File "/opt/SERVER_NAME/libraries/quickbooksV0_6_1/objects/attachable.py", line 61, in save
json_data = qb.create_object(self.qbo_object_name, self.to_json(), _file_path=self._FilePath)
File "/opt/SERVER_NAME/libraries/quickbooksV0_6_1/client.py", line 337, in create_object
results = self.make_request("POST", url, request_body, file_path=_file_path)
File "/opt/SERVER_NAME/libraries/quickbooksV0_6_1/client.py", line 290, in make_request
headers=headers, params=params, data=request_body)
File "/usr/local/lib/python2.7/dist-packages/rauth/session.py", line 210, in request
return super(OAuth1Session, self).request(method, url, **req_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 502, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 612, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 440, in send
timeout=timeout
File "/usr/local/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 601, in urlopen
chunked=chunked)
File "/usr/local/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 357, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib/python2.7/httplib.py", line 1017, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.7/httplib.py", line 1051, in _send_request
self.endheaders(body)
File "/usr/lib/python2.7/httplib.py", line 1013, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 868, in _send_output
self.send(message_body)
File "/usr/lib/python2.7/httplib.py", line 840, in send
self.sock.sendall(data)
File "/usr/local/lib/python2.7/dist-packages/urllib3/contrib/pyopenssl.py", line 316, in sendall
sent = self._send_until_done(data[total_sent:total_sent + SSL_WRITE_BLOCKSIZE])
File "/usr/local/lib/python2.7/dist-packages/urllib3/contrib/pyopenssl.py", line 304, in _send_until_done
return self.connection.send(data)
File "/usr/local/lib/python2.7/dist-packages/OpenSSL/SSL.py", line 1540, in send
self._raise_ssl_error(self._ssl, result)
File "/usr/local/lib/python2.7/dist-packages/OpenSSL/SSL.py", line 1456, in _raise_ssl_error
_raise_current_error()
File "/usr/local/lib/python2.7/dist-packages/OpenSSL/_util.py", line 54, in exception_from_error_queue
raise exception_type(errors)
Error: [('SSL routines', 'SSL3_WRITE_PENDING', 'bad write retry')]
This error occurs randomly for different attachments. But it fails for the same attachments only, and on the same server. It works on other server.
The library versions on server are as follows --
Lib - Request --> 2.18.2
Lib - urllib3 --> 1.22
Can you please look into it?

If everything works on the other server, this is likely a problem with your server, or library dependencies. I assume the libraries you posted are on the failing server; what version do you have installed on the server that works?

There were about 20 attachments (all pdfs), out of which 8 failed. This was tried on server A. But when I tried uploading one of the failed ones through server B it worked. (Failing server - server A, Which only failed for some attachments)
Initially we thought it was related to library , so we tried upgrading the library versions of server A to latest, 2.18.2 and 1.22. But it still failed.
Initial library versions (which are still there on server B) are 2.18.1 for requests and 1.21.1 for urllib3.

After doing a little more poking around, it appears this is probably related to shazow/urllib3#855. There is an open pull request that addresses this issue (#91), and specifically for Python 2.7. This might work for your needs; however, it doesn't explain the differing behavior between the two servers.
Are you using the same OpenSSL versions on both of them?

pyOpenSSL (17.3.0)
Is it possible that Server A talks to production server of QBO, and server B talks to sandbox of QBO, might have something to do with this issue ?

It could, though that would be odd.
What version of openssl are you running on each server? pyOpenSSL is a thin wrapper for the underlying openssl executable; you could be encountering a bug at the executable level

OpenSSL version on both server - 1.0.1f
ubuntu 14.04.5 LTS on both servers.

Hmm, that should be just fine. The only other thing I can think of is that you are running afoul of the file upload limit; perhaps it isn't strictly enforced on the Sandbox, but would be for production. Are the 8 files less than 100MB?
Otherwise, there could be an issue with how the request body is being created. That error appears when you move the memory location of the buffer that OpenSSL is writing from. In Python 2.7, if you try to pass a unicode buffer to pyOpenSSL, the error is raised. pyOpenSSL does try to workaround it, but it may not be a perfect solution. There would be warnings raised if this were the case, are you seeing it on your side?
Lastly, try downgrading the python-quickbooks version to 0.6.0. There was a commit that may have caused this problem added in 0.6.1

Yes the 8 files are less than 100MB, one of them is 46KB.
I didn't see any warnings like that. But to note, the same issue occurred on my windows machine in PyCharm. I remember it distinctly because it had the same error "SSL3_WRITE_PENDING". But it worked on our pre-prod server (server B), and later on worked on the windows machine as well.
Will work on 0.6.0 and let you know if anything changes.
Thank you

Did changing the library versions end up fixing your problem?

Upgrade fixed the problem


when pre-building custom docker image inside docker container cross uses weird path

Checklist

[X] I've looked through the issues and pull requests for similar reports

Describe your issue
When building with CROSS_CONTAINER_IN_CONTAINER=true pre-building uses weird path e.g.:
docker build --label 'org.cross-rs.for-cross-target=aarch64-unknown-linux-gnu' --label 'org.cross-rs.workspace_root=/mount/core' --tag cross-custom-core:aarch64-unknown-linux-gnu-2ed18-pre-build --build-arg 'CROSS_CMD=dpkg --add-architecture arm64 && apt-get update && apt-get install -y libc6:arm64 openssl libudev-dev:arm64 pkg-config-aarch64-linux-gnu && alias pkg-config=aarch64-linux-gnu-pkg-config' --build-arg 'CROSS_DEB_ARCH=arm64' --file /mount/core/target/aarch64-unknown-linux-gnu/Dockerfile.aarch64-unknown-linux-gnu-custom /run/desktop/mnt/host/d/repos/work/core`

While CROSS_CONTAINER_IN_CONTAINER=false would avoid this problem using file system inside docker as it is, in my case it is /mount/core, but it makes me unable to build due to missing cargo, not sure why exactly:
sh: 1: cargo: not found

The way I start docker image:
docker run --rm --network host --name docker-desktop -v <my repo>:/mount -v //var/run/docker.sock:/var/run/docker.sock --privileged -it <image name>

It seems it only happens because I mounted this directory, but this is honestly not good idea.
It should use mounted folder, not trying to pick source by inspecting docker contaier and checking the mount
It is probably not going to be a problem inside github actions where I intend to use it, but this is basically unusable when I do local test
What target(s) are you cross-compiling for?
aarch64-unknown-linux-gnu
Which operating system is the host (e.g computer cross is on) running?

[ ] macOS
[X] Windows
[ ] Linux / BSD
[ ] other OS (specify in description)

What architecture is the host?

[X] x86_64 / AMD64
[ ] arm32
[ ] arm64 (including Mac M1)

What container engine is cross using?

[X] docker
[ ] podman
[ ] other container engine (specify in description)

cross version
cross 0.2.4 (4645d93 2022-07-10)
Example
No response
Additional information / notes
No response

Hi!
Are you sure you need container in container? Sounds to me like you don't need it.
The container that cross is invoked in with CROSS_CONTAINER_IN_CONTAINER needs to have rust installed via rustup. It won't use the hosts rust installation. So, the solution would be to install rust in your docker image.
This could be a XY problem, what are you trying to do?

So I build custom docker image containing both rust and flutter.
Due to cross-compilation need, we use cross to build for arm64.
So I thought I have to use CROSS_CONTAINER_IN_CONTAINER=true because I invoke cross from within running container.
But it seems I'm wrong?
So my docker image includes:

rustup with image's host toolchain installed
flutter
cross binary

I have to build rust part using cross with following cross config:
16:52 $ cat .\core\Cross.toml
[build.env]
passthrough = [
    "PAYBOX_CLIENT_VERSION",
    "RUSTFLAGS"
]

[target.aarch64-unknown-linux-gnu]
pre-build = ["dpkg --add-architecture arm64 && apt-get update && apt-get install -y libc6:arm64 openssl libudev-dev:arm64 pkg-config-aarch64-linux-gnu && alias pkg-config=aarch64-linux-gnu-pkg-config"]

[target.aarch64-unknown-linux-gnu.env]
passthrough = [
    "PAYBOX_CLIENT_VERSION",
    "RUSTFLAGS"
]
volumes = [
    "DARTFILES_DIR",
]

are the rust binaries added to PATH in the image?
i.e, can you yourself run cargo -V inside the image?

Yes I can

Btw, I noticed I had added --force-non-host because I used musl toolchain previously, but could it be a problem?

you only need to rustup install with --force-non-host if the host (in this case the container/image) is not the same architecture (i.e, x86_64-linux in most cases). cross will automatically install the needed toolchain (which is x86_64-unknown-linux-gnu unless you use newer features in current main, image.toolchain )
I think I know the issue though, we're not correctly identifying/pathing the target folder, should be an easy fix

Here is docker image that I use:
FROM ubuntu:22.04 as build

USER root

ARG FLUTTER_VERSION="3.0.5"
ENV CARGO_HOME=/usr/local/cargo
ENV FLUTTER_HOME=/usr/local/flutter
ENV RUSTUP_HOME=/usr/local/rustup \
    FLUTTER_SDK_HOME=$FLUTTER_HOME \
    PATH=$CARGO_HOME/bin:$FLUTTER_HOME/bin:$PATH \
    RUST_VERSION=stable \
    CROSS_CONTAINER_IN_CONTAINER=true \
    DEBIAN_FRONTEND=noninteractive \
    DEBCONF_NONINTERACTIVE_SEEN=true \
    TZ=Asia/Tokyo

# Keep this as single RUN to reduce image size
RUN set -eux; \
    echo ">>>Prepare time zone settings" ;\
    ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone ;\
    echo ">>>Install system packages" ;\
    apt-get update ;\
    apt-get install -y make curl file git unzip xz-utils zip wget docker tar binutils ;\
    wget -q https://download.docker.com/linux/ubuntu/dists/jammy/pool/stable/amd64/docker-ce-cli_20.10.17~3-0~ubuntu-jammy_amd64.deb ;\
    dpkg -i docker-ce-cli_20.10.17~3-0~ubuntu-jammy_amd64.deb && rm docker-ce-cli_20.10.17~3-0~ubuntu-jammy_amd64.deb ;\
    apt-get clean; \
    rm -rf /var/lib/apt/lists/*; \
    echo ">>>Install Rust" ;\
    curl https://sh.rustup.rs -sSf | sh -s -- -y --no-modify-path --profile minimal --default-toolchain $RUST_VERSION ;\
    wget -q https://github.com/cross-rs/cross/releases/download/v0.2.4/cross-x86_64-unknown-linux-musl.tar.gz ;\
    tar -xf cross-x86_64-unknown-linux-musl.tar.gz && mv cross $CARGO_HOME/bin && rm -rf cross-*;\
    wget -q https://raw.githubusercontent.com/ardera/flutter-engine-binaries-for-arm/37f9852034729e0ab0f52bf913294e833ff1ec55/arm64/gen_snapshot_linux_x64_release ;\
    mv gen_snapshot_linux_x64_release $CARGO_HOME/bin ;\
    chmod -R a+w+x $RUSTUP_HOME $CARGO_HOME; \
    rm -rf $CARGO_HOME/registry ;\
    echo ">>>Install flutter" ;\
    wget -q https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_$FLUTTER_VERSION-stable.tar.xz ;\
    tar xf flutter_linux_$FLUTTER_VERSION-stable.tar.xz ;\
    mv flutter $FLUTTER_HOME && rm flutter_linux_$FLUTTER_VERSION-stable.tar.xz ;\
    git config --global --add safe.directory $FLUTTER_HOME ;\
    $FLUTTER_HOME/bin/dart --disable-analytics ;\
    $FLUTTER_HOME/bin/flutter config --no-analytics --enable-linux-desktop ;\
    $FLUTTER_HOME/bin/flutter precache --universal --linux ;\
    find $RUSTUP_HOME -type f -executable -exec strip --strip-unneeded {} \; && find $RUSTUP_HOME -name *.so -exec strip --strip-unneeded {} \; && find $RUSTUP_HOME -name *.rlib -exec strip -d {} \; && find $RUSTUP_HOME -name *.a -exec strip -d {} \;

WORKDIR /
CMD [ "/bin/bash" ]

It is a bit of mess, but you can see that I copy cross  into $CARGO_HOME/bin so they are both in the same place

unsure why cargo is not found
so what should be a correct way to invoke cross when running within container?

I think I used it fine without CROSS_CONTAINER_IN_CONTAINER=true in github actions, but unfortunately locally I seem unable to test it

Enable verbose I noticed how it runs image:
/usr/bin/docker run --userns host <options...> -t ghcr.io/cross-rs/aarch64-unknown-linux-gnu:main sh -c 'PATH=$PATH:/rust/bin cargo --verbose build --target=aarch64-unknown-linux-gnu --release'

PATH=$PATH:/rust/bin cargo --verbose build --target=aarch64-unknown-linux-gnu --release
It seems to execute cargo within ghcr.io/cross-rs/aarch64-unknown-linux-gnu
But it doesn't actually have cargo

Yes, because we mount rust and family inside this container. That's how cross works.

yes, it does mount -v /usr/local/cargo:/cargo:Z
Which on my docker image is:
root@docker-desktop:/mount# ls /usr/local/cargo
bin  env  git  registry

but it doesn't use /cargo/bin in PATH=$PATH:/rust/bin
So I looked up how it mounts /rust: -v /usr/local/rustup/toolchains/stable-x86_64-unknown-linux-gnu:/rust:Z,ro
its content:
root@docker-desktop:/mount# ls /usr/local/rustup/toolchains/stable-x86_64-unknown-linux-gnu
bin  etc  lib  libexec  share
root@docker-desktop:/mount# ls /usr/local/rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin
cargo  rust-gdb  rust-gdbgui  rust-lldb  rustc  rustdoc

can you try using this attached binary for cross
cross-x86_64-unknown-linux-gnu.zip
it's from the artifacts here: https://github.com/cross-rs/cross/actions/runs/2831450427#artifacts on pr #994

@Emilgardis with your PR and CROSS_CONTAINER_IN_CONTAINER=true it starts building

awesome!

I assume we can disregard case of CROSS_CONTAINER_IN_CONTAINER=false not working since it is not intended for use within docker container?

Yes, I think so, it could be a real issue but for now it should be fine.

Ok, thank you.
I hope you can release it soon as I'd prefer to use proper cross version 😄

the cargo not found issue is #728, we're not able to fix it easily

Hm in my case I don't run docker within WSL, but I do use WSL as backend though so maybe it is related


Use IndexVersion for version control

What changes were proposed in this pull request?
Use a IndexVersion class to represent different index reader/writer.
How was this patch tested?
Current test pass.

@adrian-wang
Please help review this PR.
This is a sub pr of index compression + index backwards compatible


MAS passing less rows to apex than validate soql says it will

Summary

I have this query in MAS:
select Id, field, accountId, createdDate, newValue, oldValue from AccountHistory
where createdDate = TODAY
When i validate it returns 4 rows, which is what i expect from my sandbox given the data in it.
Ie, 4 edits have occurred to an account.
Rows returned are 3 rows with new value populated and 1 row with newvalue blanked out (or set to null)
However when I run the MAS and pass result to an invocable apex method, then only 3 rows are being passed in.   The row that has the newValue set to null is not being passed to my apex invocable method and it needs to be.
Version of Mass Action Scheduler

Version 2.2
Steps To Reproduce

Edit some account records and set some fields to non-blank and then to blank values.
Run history report to check rows are correctly reported.
Validate SOQL in MAS to check same number of rows are reported.
Run MAS with above soql and pass to an invocable method
Display results received by invocable method.
In my case the rows that have newvlaue set to blank are being ommitted.

List steps that cause the issue
see above

Screen shots are also helpful

Expected Behavior

Rows passed to invocable method should = rows reported by validate SOQL
Actual Result

History rows that have newvlaue set to blank are being ommitted.
Source Type

[ ] Reports
[ ] List Views
[X] SOQL Queries

Action Type

[ ] Process Builder & Flows
[ ] Workflow Rules
[ ] Email Alerts
[ ] Quick Actions
[X] Apex

Does your configuration use Named Credentials?
No, it does not

Thanks for the detailed report @GeorgeP01.
To help me troubleshoot, could you share the definitions of your @InvocableMethod and @InvocableVariable fields of the class your calling?
I'll try to reproduce on my end, too.

Do you notice the same behavior when using a Report as the data source instead of SOQL?

Hi Douglas
the invocable methods is this:
@InvocableMethod(label='Link and Unlink Contract Accounts'   description='This is used to manage the linking or unlinking of contract accounts that have moved out or in')
public static List LinkUnlinkContractAccounts(List sourceRecordsBatch) {
The invocable variables are as follows:
public class accountHistoryRecords {
@InvocableVariable(Label = 'History Row Id' required=true)
public String Id;
	@InvocableVariable(Label = 'History Field' required=true)
	public String field;

	@InvocableVariable(Label = 'Account Id' required=true)
	public String accountId;

	@InvocableVariable(Label = 'New Value' required=true)
	public String newValue;
}

The MAS screen looks like this

The filed mapping is this:

I just tried again with 2 history records, 1 where the new value field has a value and one where it is blank, ie value removed.    Only the non-blank record is passed to my apex class from the MAS soql query.
I will try with a report as well for a data source.
kind regards
George

Here is the query

Thanks @GeorgeP01, this is very helpful.
From what I can tell, you’re doing everything correctly. I’ll dig into it.

Here is what I found in the debug log so far.

The correct number of records is passed to invocableMethod TestRunInvocable

CALLOUT_REQUEST [996]|System.HttpRequest[Endpoint=https://force-ability-9922-dev-ed.cs85.my.salesforce.com/services/data/v45.0/actions/custom/apex/TestRunInvocable, Method=POST]

API returns 200 OK

CALLOUT_RESPONSE [996]|System.HttpResponse[Status=OK, StatusCode=200]

In the subsequent user debug log, it seems the newValue field is required/mandatory for whatever reason.

USER_DEBUG [999]|DEBUG|[{"actionName":"TestRunInvocable","errors":[{"statusCode":"REQUIRED_FIELD_MISSING","message":"Missing required input parameter: newValue","fields":[]}],"isSuccess":false,"outputValues":null},{"actionName":"TestRunInvocable","errors":[{"statusCode":"REQUIRED_FIELD_MISSING","message":"Missing required input parameter: newValue",&q

Thanks @xixiao007 for investigating and the follow up. I hadn’t had time to dig in yet.
I agree with your assessment. The invocable variable for newValue should not be required as a field could have had its value set to null/blank. The required attribute means that the value passed to it must not be null/blank, but that’s actually a valid value for field history tracking.
@GeorgeP01, please try this change and let us know how it goes. I’m pretty sure this is the fix.
Thanks


Retain scroll position after switching to other screens - Inefficient App Flow

Steps to reproduce:

Reload the page
Scroll down to last meow
Click on user options (Profile Picture)
Close the menu

Now, the scroll position is lost and the user has to scroll again to the bottom. Maybe try storing the scroll position in the Indexed DB

Thanks!
Working on it...


fix: List formatting for models

These weren't formatting as a list but the raw Markdown suggested that was what was wanted - if I'm mistaken feel free to close this

@stevsmit could you confirm?

I previewed the change here: https://github.com/nathan-weinberg/.github/tree/list/profile
looks good!


[libra-swarm] moving libra swarm to testsuite/

libra-swarm is only used for testing.
It makes sense to keep it in the testsuite/ folder.

Is there a particular reason why you think this needs to be moved? While this is used only for testing inside of our codebase I know that there have been a number of external folks who have used this in the past as an easy way to locally setup a cluster to test sending move transactions so I see this as being valuable for more than just testing.

While this is used only for testing inside of our codebase I know that there have been a number of external folks who have used this in the past as an easy way to locally setup a cluster to test sending move transactions

:D?

+1 to this PR. I always thought it was weird to have libra-swarm outside of the testsuite! Hopefully this won't break any external deps though :(

:hourglass: Testing commit 450cee752ec76eb4245ec88a2e1ad560b5bb20e6 with merge 7db0e0423d24cdc96a3e4e7e5e38216e65a3dc92...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: metajack
Pushing 7db0e0423d24cdc96a3e4e7e5e38216e65a3dc92 to master...


Why is pubspec.lock included in git?

https://github.com/saibotma/jitsi_meet_wrapper/blob/6d7a0b12dcf48119ba2b39bc4bf2ea3b6f979833/.gitignore#L29
pubspec.lock is already in .gitignore, also with the reason why we should not commit it for library packages (👍) - is there a reason why pubspec.lock is out-comment?

Thanks for the hint. Did not know this fact. Will be removed in 0.0.5.

Thanks ❤


感谢你的工作，它正是我需要的，但是我出现了如下错误，请求你的帮助

Traceback (most recent call last):
File "/data/server03/Zhaozikai/Clip/train.py", line 170, in
model   = CLIP(**config)
File "/data/server03/Zhaozikai/Clip/nets/clip.py", line 57, in init
self.tokenizer          = BertTokenizer.from_pretrained(kwargs['huggingface_model_name'])
File "/home/server03/anaconda3/envs/Zhao_project926/lib/python3.10/site-packages/transformers/tokenization_utils_base.py", line 2192, in from_pretrained
raise EnvironmentError(
OSError: Can't load tokenizer for 'bert-base-chinese'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'bert-base-chinese' is the correct path to a directory containing all relevant files for a BertTokenizer tokenizer.

我解决了上面的问题
我在flickr8k数据集上训练的结果如下：

为什么训练的效果还不如不训练？


Focus back on editor after clicking evaluate

Fix for #210.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks!


chore: update dependency versions and bump version

Updates the dependencies to use the version containing the latest fix and also bumps the version number up.
This should fix issue https://github.com/Hyundai-Kia-Connect/kia_uvo/issues/668

Thanks for doing this.   I'm not by a pc or would.  Could you remove the version change? Our release code does that automatically.  After that I can merge it.

Not a problem! Version change has been removed :)


Updating node-inspector

I was having issues installing v8-debug.  Updating node-inspector updates v8-debug to a much more recent version which works.

Hi @badave Thanks for your contribution! Just one note, I would like to avoid dependencies with "^" as had issue with certain version of portscanner (I think it was just one after 1.0.0, newer may work fine tho). So I chose to pin the exact version number so it can be fully tested.
Would you consider updating your changes and pin them to the versions you tested with?

Also since I setup automatic release you can bump the version to next minor, then it will be automatically updated on npm.

This update is essential for my environment.
As a consumer of Nodev, my two cents are that I would prefer having "^" dependencies that pull in the latest minor version. And this IS the standard dependency setting for dev tools. For example, I wouldn't even need this patchset if we were already using "^" since I would have installed the latest 0.13.x automatically.

Alright, I will take this feedback then.

Sweet, akamensky & badave. This is a fantastic package.


Support for contexts

I am having some difficulty dealing with propogating deadlines and handling timeouts (due to unhealthy cluster etc) at the application level. It would be great if there was a rados API that took a go context as the first parameter so that operations can express deadlines and do cancellations more cleanly.
This issue is a request for comments, I am willing to do the work and do a PR but I am not familiar enough with rados to know if this lines up with how it is used in other languages or if it would be clean to implement. Any suggestions?

@immesys is this still relevant? i'm a little confused about what information you want to propagate to where. I'm probably just confused because I'm unaware of any deadline features in the rados API. Could you say a bit more about what you want to accomplish?

Hello, I'm automatically closing all issues filed prior to 2018 that have not been commented on recently. If this issue is still relevant to you please reopen the issue and restart the discussion. Thank you for your understanding.


Ignore already escaped | when building markdown table

Fix CodeQL issue https://github.com/microsoft/typespec/security/code-scanning/13

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3281/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3281/


Algorithm Strings solution in JAVA

Solved issue #538
In Language- JAVA

[x] Updated README Link
[x] Added code with comments

Please resolve conflicts

: )


[20.09] chromium: 89.0.4389.90 -> 89.0.4389.114

Motivation for this change
Backport of #118133. If someone has the time/resources to build nixosTests.chromium that would be welcome (my build host is currently running a few other time-consuming builds).
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

❯ nix-build -j1 nixos/tests/chromium.nix
error: Package ‘chromium-beta-90.0.4430.51’ in /home/hexa/git/nixos/master/pkgs/applications/networking/browsers/chromium/browser.nix:72 is marked as broken, refusing to evaluate.

Fails reproducibly for me.
configuring
Done. Made 15864 targets from 2665 files in 10714ms
building
ninja: Entering directory `out/Release'
[1717/1717] LINK ./mksnapshot.stampstampassembler.o[Kn.o.ooKKK)fault)
ninja: Entering directory `out/Release'
[3/3] LINK ./chrome_sandboxome_sandbox/sandbox.o_linux.o
ninja: Entering directory `out/Release'
[6429/44266] CXX obj/third_party/angle/libANGLE_base/MemoryProgramCache.otogen.oltins.o[Klt)efault)lt)lt)[Kt)[K[Ke:default)[Kt)ult)model-legacy.js
../../third_party/angle/src/libANGLE/MemoryProgramCache.cpp:24:9: warning: 'USE_SYSTEM_ZLIB' macro redefined [-Wmacro-redefined]
#define USE_SYSTEM_ZLIB
        ^
<command line>:48:9: note: previous definition is here
#define USE_SYSTEM_ZLIB 1
        ^
1 warning generated.
[6522/44266] CXX obj/third_party/angle/src/libANGLE/renderer/vulkan/angle_vulkan_backend/vk_internal_shaders_autogen.oain/linux/unbundle:default)efault)
../../third_party/angle/src/libANGLE/renderer/vulkan/vk_internal_shaders_autogen.cpp:13:9: warning: 'USE_SYSTEM_ZLIB' macro redefined [-Wmacro-redefined]
#define USE_SYSTEM_ZLIB
        ^
<command line>:38:9: note: previous definition is here
#define USE_SYSTEM_ZLIB 1
        ^
1 warning generated.
[6595/44266] CC obj/third_party/fontconfig/fontconfig/fcxml.od/theme_support:theme_support-typescript(//build/toolchain/linux/unbundle:default)[K)
../../third_party/fontconfig/src/src/fcxml.c:3609:6: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
            strerror_r (errno_, ebuf, BUFSIZ);
            ^~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
client_loop: send disconnect: Broken pipe
error: unexpected end-of-file
builder for '/nix/store/mwj5jx4nimybx00hq7vhqmi7ldkrmmfl-chromium-unwrapped-89.0.4389.114.drv' failed with exit code 1
cannot build derivation '/nix/store/zfbrsfz1fxqdhk8diyx74nvwp3zv4yk4-chromium-89.0.4389.114.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vdz323f2l5lhw6f58pj8y9ivcc4nd4gd-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d2ghc972s3rhvrh3rxvwwz8776w4ihdy-nixos-system-machine-20.09pre-git.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dyypk3x8hg27hjqj87s1ymk889f66fya-nixos-vm.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mgfjnrrbqb1mpnyrzh6h23wz7igh4glw-nixos-test-driver-chromium-stable.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7pjib5ydzbyrbb21vndyx0glycbqz213-vm-test-run-chromium-stable.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7pjib5ydzbyrbb21vndyx0glycbqz213-vm-test-run-chromium-stable.drv' failed

That's unfortunate but error: unexpected end-of-file is hopefully due to disk-space or inode limits (e.g. an issue when building with /tmp on tmpfs, IIRC). Anyway, huge thanks for trying to build it.

Oh, that may well be. I can extend the disk space right now.

Ok, strange :o Maybe I can try to reproduce it in a few hours / tomorrow. I also missed the client_loop: send disconnect: Broken pipe which is strange as well (IIRC I've only/mostly seen this for SSH disconnects).

nixosTests.chromium succeeded on my test system:
# i5-6500 CPU
real    595m53.702s
user    2213m56.490s
sys     73m33.081s

/nix/store/jsbbhwx2rnnv22d1ks0xw7bqg0d0wn4s-vm-test-run-chromium-stable

Yup, built it locally on my build host and that worked.


Benchmark and document startup times for the images on the SMCE

Seems slow at times, is this expected, or is there a problem?

SMCE is aware of this.  Nothing else we need to do.


Speeding up the first phase of Index Building

Identified the writing of Triple elements to hash maps for deduplication as a bottleneck.

Speed this up by writing to multiple hash maps at once and merging them afterwards

Also concurrently pipelined all the other steps in the first index building phase.

That way the TurtleParsing now becomes the bottleneck (Teaser: This can be sped up by 30% using
compile time regexes, so this might become even faster in a later PR).

This was done by Implementing an abstract, templated BatchedPipeline that abstracts
over the creation and transformation of values in a pipeline that allows to control
the degree of concurrency used on each level and between the different levels.

This pipeline infrastructure was heavily unit-tested to ensure its correctness since it internally
uses quite some template magic.

This Commit also introduces the absl::flat_hash_map that is faster than the dense_hash_map used before.
But in doubt I can also revert this change since in the meantime the parallelism is what helps us more
than the faster hash maps. But I have thought, that we wanted to try out those anyway.

This can already be reviewed, especially the BatchedPipeline.h file. Before merging I would suggest merging
the Unicode PR, because there is some merging work to be done (but not too much) between those PRs.

@joka921 That sounds amazing! I have a few questions:

Did you already try it? What is the speedup?

Can you describe in a little more detail what you mean by "writing to multiple hash maps at once". We are talking about hash maps from strings (names) to IDs, right? How many hash maps? And how do you decide which hash map to use for a particular element?

Can you describe in a littel more detail, which operations you pipeline? You mention "values" and "levels", what are those when you use your abstract class for building the index?

Does the absl::flat_hash_map have any disadvantages compared to Google's dense_hash_map?

Ok, so for each triple we have to do the following steps:

Parse it from Turtle
Convert each of subject, predicate, object to an internal representation (e.g. string normalization, special handling of numeric or date literals etc.)
Assign each of subject, predicate, object an ID (lookup in a hash map if this element already has an ID, then reuse it, otherwise assign the next available ID and store it in the hash map).
Append the Triple's Ids to a large external vector that stores all the triples.

In a pipeline this looks as follows:

Parse a batch of Triples and pass this batch to the next level. Immediately continue with next batch.
Take a batch of Triples from level 1 and convert each element to the representation, then pass this
converted batch to level 3. Immediately continue with next batch
The first 25% of each batch of Triples get Ids from the first hash map, the second 25% from the second....
get all the Ids from the different hashMaps and store the Id Triples.

Trick a) all of those levels happen at the same time for different batches (pipeline principle)
Trick b) We make sure that the hashMaps hand out disjoint sets of Ids (this is easy because we know  the maximum number of triples we deal with at once in this whole process.
After we are finished, we have the problem, that some words may have multiple Ids (if they occured in different triples that were assigned to different hash maps). Unifying these to one Id and updating the triple after we are done
is again relatively simple and can be done concurrently for each partial vocabulary.
The speed up is s.t. the parser becomes the bottle neck. It is about 40 Million triples per Minute so
we should be able to deal with 1 Billion triples in about 4 -5 hours vs 10-12 before. My personal target is 3, but this requires more work on the parser.
The only thing the abls::flat_hash_map does not have is a bucket interface (access to linked lists for chained hashing). This gains speed but does not conform to the C++ standard for unordered_map. But since nobody uses this, especially not us this is not a disadvantage. Concerning memory consumption both are rather expensive (optimized for speed) but since we currently use only relatively small hash maps (in my case they are even temporary and only used in the IndexBuild) this is not an issue for us.

@joka921 Thanks for the explanation!
You write that "We make sure that the hashMaps hand out disjoint sets of Ids (this is easy because we know the maximum number of triples we deal with at once in this whole process.)". Does this mean that with this PR there are gaps in the ID space? Or do these gaps vanish in the ID unification process.
I am slightly worried about code complexity and maintainability. Do I understand you correctly that all the complexity is hidden in the BatchedPipeline class? Is the code outside that class reasonably simple. For example, if someone else wants to extend the parser in some (not overly dramatic way), will they be able to do it without understanding the intricacies of your batched pipeline?

No, we will not have Gaps in the Id space. The procedure described above does merge the Ids in a gap free way. Additionally it only creates a partial vocabulary. Those are merged after the complete parsing of the whole knowledge base is done. Only there the Ids are really finalized in a gap free way.
Anything else would be very wrong since the Id of a string must be its index in the vocabulary vector when we are completely finished.

Using the batched pipeline is really really simple, and I have written quite some documentation.
The Parser implementation is completely independent, as long as the parser can give us triples
and signal when the file is finished and there are more triples.

The interface of the pipeline is basically setupPipeline(one Lambda per Step)
You can look at it yourself, or we can meet some time soon and discuss on how to comment this
best and make the actual usage readable in the best possible way.

   {
      auto p = ad_pipeline::setupParallelPipeline<1, NUM_PARALLEL_ITEM_MAPS>(
          _parserBatchSize,
          [parserPtr = &parser, i = 0ull, linesPerPartial,
           &parserExhausted]() mutable -> std::optional<Triple> {
            if (i >= linesPerPartial) {
              return std::nullopt;
            }
            Triple t;
            if (parserPtr->getLine(t)) {
              i++;
              return std::optional(std::move(t));
            } else {
              parserExhausted = true;
              return std::nullopt;
            }
          },
          [this](Triple&& t) {
            return tripleToInternalRepresentation(std::move(t));
          },
          std::move(itemMapLambdaTuple));

      while (auto opt = p.getNextValue()) {
        i++;
        for (const auto& innerOpt : opt.value()) {
          if (innerOpt) {
            actualCurrentPartialSize++;
            localWriter << innerOpt.value();
          }
        }

@niklas88 The Travis build says that it has passed when I click on the Details link, But
on this site the yellow light remains. Does the CI pipeline have a hickup again?

@niklas88 The Travis build says that it has passed when I click on the Details link, But
on this site the yellow light remains. Does the CI pipeline have a hickup again?

I just reran the build and this time its propagated correctly. So yeaah looks like a Travis hickup. I'll look into this in more detail soon but it already sounds pretty amazing!

I just tried to build a version of the current master (includes the unicode upgrade) with this PR merged locally and encountered this error while building the docker container:
CMake Error at CMakeLists.txt:60 (add_subdirectory):
  The source directory

    /app/third_party/abseil-cpp

  does not contain a CMakeLists.txt file.

git submodule init
git submodule update
should Download abseil.
Did the merge Work without conflicts?
Hannah Bast<EMAIL_ADDRESS>schrieb am Sa., 11. Jan. 2020, 09:12:

I just tried to build a version of the current master (includes the
unicode upgrade) with this PR merged locally and encountered this error
while building the docker container:
CMake Error at CMakeLists.txt:60 (add_subdirectory):
The source directory
/app/third_party/abseil-cpp

does not contain a CMakeLists.txt file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ad-freiburg/QLever/pull/302?email_source=notifications&email_token=ADS6SASFZKCKQ663O6WA5I3Q5F5QDA5CNFSM4KEKWXE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIV4M2Q#issuecomment-573294186,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADS6SATV2RHIZOSOTKB57W3Q5F5QDANCNFSM4KEKWXEQ
.

@joka921 In fact, it didn't, sorry for the confusion. Below you the see the list of the conflicting files. So I will wait until you have modified this pull request to be mergeable with the current master.
bast@galera:QLever$ git merge master
Auto-merging test/VocabularyGeneratorTest.cpp
CONFLICT (content): Merge conflict in test/VocabularyGeneratorTest.cpp
Auto-merging test/CMakeLists.txt
CONFLICT (content): Merge conflict in test/CMakeLists.txt
Auto-merging src/index/VocabularyGeneratorImpl.h
CONFLICT (content): Merge conflict in src/index/VocabularyGeneratorImpl.h
Auto-merging src/index/VocabularyGenerator.h
CONFLICT (content): Merge conflict in src/index/VocabularyGenerator.h
Auto-merging src/index/Index.h
CONFLICT (content): Merge conflict in src/index/Index.h
Auto-merging src/index/Index.cpp
CONFLICT (content): Merge conflict in src/index/Index.cpp
Auto-merging src/index/CMakeLists.txt
CONFLICT (content): Merge conflict in src/index/CMakeLists.txt
Auto-merging CMakeLists.txt
Automatic merge failed; fix conflicts and then commit the result.

Awesome, I have started a build with this code at 9:39 h today, see my WA message. Fingers crossed

@joka921 A minor detail: can you please call the intermediate files
...partial-vocabulary-012 instead of ...partial-vocabulary12
...partial-ids-mmap-018 instead of ...partial-ids-mmap18
...compression-index... instead of ...compression_index...
Note that this entails three changes: (1) a dash before the final number, (2) fixed-width formatting of the number, so that the lexicographic order makes more sense when seeing them in a directory listing, (3) a dash instead of an underscore. If you feel that a fixed width of three is not enough, you can also make it four.

I will make this optionally. Without Level 5 there can be literals that
compare equal but are different. This leads to Index builds that behave
equally, but Producer different Indices in Case two of those equal literals
are sorted in a different Order in the vocabulary. I Wang to have
reproducible Index builds at least optionally as a Check dir Changes in the
Index builder. Thema I can simply Run cmp in the Index Files to See If I
have broken anything.
Hannah Bast<EMAIL_ADDRESS>schrieb am So., 12. Jan. 2020, 10:02:

@hannahbast commented on this pull request.
Didn't we say earlier that using the QUATERNARY level is enough and that
using the IDENTICAL level would affect the performance negatively, or am I
confusing something here? Here is the corresponding quote from the ICU
documentation, which Niklas included in his comments on this PR on
2020-01-02 13:57, highlights added by me:
"Identical Level: When all other levels are equal, the identical level is
used as a tiebreaker. The Unicode code point values of the NFD form of each
string are compared at this level, just in case there is no difference at
levels 1-4 . For example, Hebrew cantillation marks are only distinguished
at this level. This level should be used sparingly, as only code point
values differences between two strings is an extremely rare occurrence. Using
this level substantially decreases the performance for both incremental
comparison and sort key generation (as well as increasing the sort key
length). It is also known as level 5 strength."
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ad-freiburg/QLever/pull/302?email_source=notifications&email_token=ADS6SAV7WWX4M767IKFJMATQ5LMDJA5CNFSM4KEKWXE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRN5FSY#pullrequestreview-341562059,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADS6SAQT3BQEIPAP7LUTHBLQ5LMDJANCNFSM4KEKWXEQ
.


[question] Do copilot.el send feedback to Github?

I would like to know if copilot.el sends data to Github about suggestion acceptance or any other data they need.
It is OK for me, in fact I would even be happy if my data can be used to feed.

Yes. You can search these keywords in copilot.el to learn more:

'notifyShown
'notifyRejected
'notifyAccepted
'setEditorInfo


Credentialissuer spec api

Creating this now so we can run the integration tests in CI, but it's still in progress.
cc #617

We should deduplicate our host:port parsing code with the new stuff in the LDAP package.


Get Zenodo working again

I've tried to get Zenodo working again by inspecting the API responses from

https://zenodo.org/api/records/3242074
https://zenodo.org/api/records/3242074/files

Closes https://github.com/jupyterhub/repo2docker/issues/1314

Merging given the tests pass. Thanks for putting work into this, @manics


Automatically add leaf_cycle from species:wikidata

Description
Wikidata approved a new property for plant taxa - foliage type (P10906)
Any taxon can have one of the following meanings:

evergreen plant
semi-evergreen plant
semi-deciduous plant
deciduous plant

I propose that for natural=tree we do an auto-substitution from Wikidata of this parameter.
Screenshots
No response

Is it common for mappers to be able to identify the species of a tree before they identify the foliage type? leaf_cycle is already present on 77% of the features tagged species:wikidata, so I’m not sure that automatically tagging leaf_cycle in response to species:wikidata would yield much additional data.

I would use this as I often add tree species without foliage type - my city maintains a public domain database of nearly every street tree and its species, but not foliage type. I have been meaning to add these details but this would make it easier, especially for some less common species.
For example, it is not that hard to figure out that this one is broadleaved https://www.openstreetmap.org/node/9686799342#map=19/39.31142/-76.64069
but for the hundreds of trees I have added like this it would be quite time consuming. (I do line these up with aerial imagery and filter the data based on the notes about their condition so that I'm not adding trees that are likely to have been cut down or fallen over recently so it's not quite blind importing. Verifying that the city surveyors got the species right is something I'll worry about once these are Wikidata'd and I'm more competent at working out that sort of thing.)
Also, living somewhere where nearly all the trees are broadleaved I do worry about absent-mindedly marking a tree that isn't as broadleaved (and wouldn't be surprised if I accidentally did this before). They definitely aren't non-existent, but you can miss them if you're not paying attention. I realize I should clarify I'm usually doing this on the train or bus so it's easier to make these mistakes when they disappear so quickly.

This is maybe a more obscure use case, but trees are one of the only objects I've found reason to use planned tags on, and often the species is decided beforehand if the municipality has a specific plan for where to put it. There's a note in this one explaining that the city replaced a dead silver linden with a black oak for example, where the fact that a black oak was going to go there likely would have been mappable had I been reading about this sort of thing in 2018: https://www.openstreetmap.org/node/9704388552
Here, they are going to cut this one down this year and not replace it with anything (they want there to be a clearer field of vision in the park). It seemed useful to indicate that in OSM otherwise I would never remember that this one is going to get cut down. https://www.openstreetmap.org/node/9662102748 (This is also one of those evergreen trees that does exist surrounded by broadleaved ones - I would not have noticed it even walking by though had I not read about the removal plan for it.) If they were to replace it with a particular species though, that would another situation besides surveyed databases where you might add the species without knowing the leaf cycle.

To be clear, I’m not arguing against tagging leaf_cycle or for removing the existing Leaf Cycle field. This issue specifically requests automatically copying that information from the Wikidata item about the species tagged in species:wikidata. The operative word is automatically; you can already click the ↗ button in the Wikidata field to jump to the item where this information would be present and decide for yourself whether OSM should state the same fact. That said, if you’re tagging trees en masse, a MapRoulette challenge or find-and-replace in JOSM would be a lot more efficient, except maybe if you’re micromapping an arboretum where no two trees are alike.
There have been previous suggestions to automatically copy details from a linked Wikidata item to the selected feature: #6975 #8028. Frankly, any such feature would face overall skepticism about this approach to tagging, justified or not.

It seems to me that the statement "pine is an evergreen" or "linden is a deciduous plant" is information more suitable for a wikidata than for a cartographic database. And now it turns out that with each description of a pine specimen, it is necessary to re-do the great biological discovery that this pine specimen does not shed its needles)))
I have read the skepticism about import from Wikidata. But now auto-substitution of an article from Wikipedia works when specifying the wikidata key (Wikidata key → Wikipedia link). Information about the deciduousness of taxa, as it seems to me, is the same trivial knowledge, and the correspondence is the wikidata key - a link to the Wikipedia article.
At least I took the first 30 most popular species:wikidata key values (https://taginfo.openstreetmap.org/keys/species:wikidata#values ) and listed the deciduousness values in Wikidata without using commercial sources.


Convert the source to RST

I'm not sure Docs Italia will support Markdown, the guide (Italian) mentions only RST.
We should convert the Markdown files to RST, just to be sure.
cc @AgostinoPurificato

cc @Clou-dia

this issue can be closed I guess


enable/disabled menu item, option to stop resize icon/title when activating tab

When the menu defined on the xml has the "enabled" property set to false, alpha is set to 0.4 and the click functions are disabled.
When you call mBottomBar.noResizeIconOnChange(), the icon and text won't change when the tab becomes selected.

@ckarumoreira when i read the enable flag i think that the tab will not be able to be selected what so ever is that what you want to achieve? and if so, there is a new functionality in version 2.2.0 that can get the same behavior, closing this.


Colour change on upgrades

Is it  possible to have this as on option or Hwyla gui setting as the colours appearing on the drawers completely messes up the style of many builds

I don't get your problem, could you append screenshots?

this is what i mean with the colours changing when you apply upgrades.
instead of the actual drawer colour changing would it be possible to have it as a Hwyla gui setting to shoow which upgrade is applied?

The HWYLA bit should be easy to solve as there is an api for the mod.
The changeable borders are definitely possible, but will require require a rewrite of the border system the mod has.


[help wanted]cmake failed by vcpkg

System Info:
Edition	Windows 10 IoT Enterprise LTSC
Version	21H2
Installed on	3/17/2023
OS build	19044.1288
Experience	Windows Feature Experience Pack 120.2212.3920.0

Procedure：
git clone https://github.com/minio/minio-cpp
cd minio-cpp
wget --quiet -O vcpkg-master.zip https://github.com/microsoft/vcpkg/archive/refs/heads/master.zip
unzip -qq vcpkg-master.zip
 ./vcpkg-master/bootstrap-vcpkg.sh
./vcpkg-master/vcpkg integrate install
cmake -B ./build -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE=./vcpkg-master/scripts/buildsystems/vcpkg.cmake
Output Logs:
-- Running vcpkg install
-- Running vcpkg install - failed
CMake Error at vcpkg-master/scripts/buildsystems/vcpkg.cmake:892 (message):
vcpkg install failed.  See logs for more information:
/tmp/minio-cpp/build/vcpkg-manifest-install.log
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:16 (project)
CMake Warning (dev) in vcpkg-master/scripts/buildsystems/vcpkg.cmake:
Policy CMP0011 is not set: Included scripts do automatic cmake_policy PUSH
and POP.  Run "cmake --help-policy CMP0011" for policy details.  Use the
cmake_policy command to set the policy and suppress this warning.
The included script
/tmp/minio-cpp/vcpkg-master/scripts/buildsystems/vcpkg.cmake
affects policy settings.  CMake is implying the NO_POLICY_SCOPE option for
compatibility, so the effects are applied to the including context.
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:16 (project)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

MS Windows is not fully supported yet.

why not support CMakeLists without vcpkg to compile ?

Actually I had solved it finally a few days ago by modified your CMakeLists.

But I recur this issue on my new work PC ,So I opened this issue for possible help.

Feel free to send a PR

Solution:
 sudo apt-get install pkg-config -y


Use Function Constructor Instead of Eval

Please describe the changes this PR makes and why it should be merged:

Use of the with statement is not recommended, as it may be the source of confusing bugs and compatibility issues. See the "Ambiguity Contra" paragraph in the "Description" section below for details.

Warning: Executing JavaScript from a string is an enormous security risk. It is far too easy for a bad actor to run arbitrary code when you use eval(). See Never use eval()!, below.

Those are both from MDN so I removed the usage of eval and with and instead used a Function constructor.
Status

[x] Code changes have been tested against eslint, or there are no code changes (assuming yes because eslint isn't in the project)
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the library's interface (methods or parameters added)
[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR only includes non-code changes, like changes to documentation, README, etc

This does not fit any of the above. This is more of a performance and security patch.

[x] This PR only contains bug fixes, security patches, or performance patches. (I would recommend you add this to the PR template)

Thanks so much for the PR - tried implementing the same thing but couldn't figure it out.
I'm looking for collaborators - would you be willing to hop on board the repo?

Actually having some issues with this, when trying to compute something, return value is function () { [native code] }. Adding
return new Function(returnable ? `return ${expression}` : expression).bind(_)();

seems to work but does not expose properties as variables, like the previous implementation.

Actually having some issues with this, when trying to compute something, return value is function () { [native code] }. Adding
return new Function(returnable ? `return ${expression}` : expression).bind(_)();

seems to work but does not expose properties as variables, like the previous implementation.
However, this.whatever seems to work

Yeah, that was my bad. Either we revert back or we publish it as a breaking change.

We could also just use the with statement though that is not recommended.


Super

You can give just a config for /etc/tmux.conf
Without additional code for your application?

Hello @foxmeyson  👋
I'm sorry I don't understand your question 🤷♂


Clarify the Submission ID value

In the paragraph https://docs.microsoft.com/en-us/microsoft-365/security/office-365-security/admin-submission?view=o365-worldwide#view-admin-submissions, we have the notion of Submission ID, which is a selectable criteria for admins to search user submissions.
From where is the Submission ID taken exactly? Where does this value come from?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 162f11ad-8add-952e-fd64-488e8e3f3b14
Version Independent ID: addf14d5-f1c1-662d-9844-6888df0349bd
Content: Admin submissions - Office 365
Content Source: microsoft-365/security/office-365-security/admin-submission.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@Alex-Catalin, apparently, Submission ID is a GUID value that's assigned to every submission. I added this description in a couple of places in the topic.
Thanks for the feedback.
Closing


Fix DownwardMetrics MemoryAllocatedToVirtualServers and add missing ResourceProcessorLimit metrics

What this PR does / why we need it:
As part of the SAP certification effort, the DownwardMetrics should be aligned with https://sourcegraph.com/src.fedoraproject.org/rpms/vhostmd/-/blob/vhostmd.conf.
It changes the current state of the DownwardMetrics from:
<metrics>
...
  <metric type="uint64" context="host" unit="KiB">
    <name>AllocatedToVirtualServers</name>
    <value>3649456</value>
  </metric>
...
</metrics>

to:
<metrics>
...
  <metric type="uint64" context="host" unit="KiB">
    <name>MemoryAllocatedToVirtualServers</name>
    <value>3649456</value>
  </metric>
...
  <metric type="uint64" context="vm">
    <name>ResourceProcessorLimit</name>
    <value>2</value>
  </metric>
...
<metrics>

Please note, this change request has been raised by SAP in: https://github.com/kubevirt/kubevirt/pull/9673#issuecomment-1562550439
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

DownwardMetrics: Rename AllocatedToVirtualServers metric to AllocatedToVirtualServers and add ResourceProcessorLimit metric

/cc @germag

/test pull-kubevirt-unit-test

/retest-required

Removed commit hack: Add the KubeVirt directory as a safe git directory because it was just a temporary hackaround to prevent CI failures. Please refer to https://github.com/kubevirt/kubevirt/issues/9806 for further details.

/retest-required

@0xFelix Thanks for your reviews :)

/retest-required

/cc @rmohr could you please take a look?

/approve

@rmohr Many thanks for your time! :blush:


Fix proposal for issue #160

Fix proposal for issue #160 LMS_Open() not returning an error when opening default device and no device available.
If the original behavior of not returning an error was on purpose, for example to be able to run some unit tests without an actual hardware connected, I propose to create a specific lms_info_str_t info dedicated for that purpose.

Closing this PR as well as bug #160 as fixed in commit c02f4358b6eb3a83f333e8951419f34b18667dde so this PR became obsolete


Detect touch devices as touchscreen

The Goodix Capacitive TouchScreen on the pinephone was being detected as
a joystick instead of a touchscreen. This patch correctly marks it as a
touchscreen and allows it to work out of the box with libinput

@illiliti Are there more objections to this patch?

Merged, thanks


Instantly closes

When I try opening it, it instantly closes. I tried unblocking the zip before extracting as well. GPU is NVIDIA GeForce GTX 1050.

Can you try running it from the command line and see if any errors show up?

I assume the latest build should now work, but if it doesn't you can re open this issue.


allow drag and drop from explorer

Is your feature request related to a problem?
no
Describe the solution
as titled
Describe alternatives you've considered
none
Additional comment
https://user-images.githubusercontent.com/39104740/112202674-b21db480-8c22-11eb-855b-a22252b8dee8.mp4

Thanks for this report. Could you check if you can drop the file on the sidebar or the navigation bar of Files?

Merging with #4130.

oh this is actually a bug, i see
to reproduce it, you need to open the same directory in both Files and explorer
i don't see how this is similar to #4130, because there he cannot d&d at aloo

Could you check if you can drop the file on the sidebar or the navigation bar of Files?

i met a lot of weird bugs after i tried this, trying to isolate and summarize them


adds(test): unit tests for merging

Adds two files merge test
Adds three files merge test

Not relevant due to changes implemented


Add test harness to support XAML hot reload

Update the native embedding app by adding a test harness project that enables you to use XAML hot reload to iterate on the .NET MAUI UI.

WinUI projects failed to build. Double checking.

WinUI projects now build fine in VS, just not in AzDO. So merging.


grilo-plugins fails to build

grilo-plugins fails to build due to missing libgdata headers.
Apparently this is a regression caused by c2de086b17379492bae278f62911f4fc83a782db
Interestingly,
libgdata_dep = dependency('libgdata', version: '>= 0.9.1', required: false)
libsoup_dep = dependency('libsoup-2.4', required: false)
warning('libsoup: @0@, libgdata @1@'.format(libsoup_dep.found(), libgdata_dep.found()))

prints WARNING: libsoup: false, libgdata true, even though libsoup is in Requires.
which is incongruous with the way pkg-config sees the package:
pkg-config --cflags libgdata
Package libsoup-2.4 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsoup-2.4.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libsoup-2.4', required by 'libgdata', not found

Originally posted by @jtojnar in https://github.com/NixOS/nixpkgs/pull/59765#issuecomment-484220957

We probably ought to propagate libsoup from libgdata, I only added it to buildInputs in https://github.com/NixOS/nixpkgs/pull/59793 since it is also a direct dependency of another plug-in.
Also this behaviour by meson is questionable.

Yeah, let's propagate it.


Introduce MVVM or MVP?

Overview
Nowadays a bunch of Android developers are eager to discuss what kind of architecture we should adopt. I think this is the good timing to introduce MVVM or MVP to this app :D
The diff will be so huge, hence it might be better to create new architecture branch and work on it.
I have no strong opinion for MVP and MVVM...what do you think @konifar ?

Good issue 👍
In my opinion, MVVM is better because Android have DataBinding now.
Android DataBinding is really similar to XAML on Microsoft. It fit well to MVVM architecture.
So I'll try it on architecture branch 😃

Here we go!!!!!!!!!!!

Sounds great!
I came from .NET/Xamarin world.
I strongly believe MVVM is best solution for mobile(Android / iOS / Win) apps design.
I made sample apps that is adopting MVVM pattern and using Rx.

Android Data Binding + MVVMパターンのサンプルを書いてみた - Qiita

Please check it!

@amay077 @konifar I created the brunch, here we go!!!!!!!!
https://github.com/konifar/droidkaigi2016/tree/mvvm

Let me close this issue since it's been a long time.

Thanks! We'll try MVVM on 2017 app

Yep.
I hope contribute to 2017 app 👍

Here we go!


Forbid specifying an extension of same type more than once

How to categorize this PR?

/area quality
/kind bug
What this PR does / why we need it:
This PR enhances shoot validation to forbid specifying an extension of the same type more than once.
For more details - https://github.com/gardener/gardener/issues/8446
Which issue(s) this PR fixes:
Fixes https://github.com/gardener/gardener/issues/8446
Special notes for your reviewer:
Release note:

A bug has been fixed which was allowing users to specify an extension of the same type in `.spec.extensions[].type` more than once in the `Shoot` API.

/retest

/retest

/lgtm

Although mentioning the extensions twice is a mistake since we allowed it in the past, Is there a chance that this could break some shoot creation setups of users? Should we also call this function in PrepareForCreate for a few releases, similar to removeFinalizersOnCreation function?

Probably not If somebody would have done it consciously then it is wrong from the user's end and they should adapt it ASAP and the gardener should not clean it silently.

I agree it's wrong, but it could still be breaking for them. WDYT @rfranzke ?

I understand the concerns, but I'm fine with both approaches. If @acumino as author prefers to not include it in PrepareForCreate (whilst arguing that such Shoot resources should be fixed ASAP to prevent misconfiguration), I think it's fair to proceed like this as this issue is probably rather theoretical (I don't expect many affected shoots). It would be a different story if we changed validation for a more prominent field.
So, should we proceed then @shafeeqes ?

Thanks!
/lgtm
/approve


Apache Commons Logging missing

With
        <plugin>
          <groupId>org.patrodyne.jvnet</groupId>
          <artifactId>hisrc-higherjaxb40-maven-plugin</artifactId>
          <version>2.1.1</version>
          <dependencies>
            <dependency>
              <groupId>org.patrodyne.jvnet</groupId>
              <artifactId>hisrc-basicjaxb-plugins</artifactId>
              <version>2.1.1</version>
            </dependency>
          </dependencies>
          <executions>
            <execution>
              <id>jaxb-xjc</id>
              <goals>
                <goal>generate</goal>
              </goals>
              <configuration>
                <extension>true</extension>
                <args>
                  <arg>-Xsimplify</arg>
                  <arg>-Xsetters</arg>
                  <arg>-Xsetters-mode=direct</arg>
                </args>
                <schemaDirectory>src/main/resources/xsd</schemaDirectory>
                <generateDirectory>${project.build.directory}/generated-sources</generateDirectory>
              </configuration>
            </execution>
          </executions>
        </plugin>

on Maven 3.9.4 I get
Execution jaxb-xjc of goal org.patrodyne.jvnet:hisrc-higherjaxb40-maven-plugin:2.1.1:generate failed: A required class was missing while executing org.patrodyne.jvnet:hisrc-higherjaxb40-maven-plugin:2.1.1:generate: org/apache/commons/logging/LogFactory

Try <artifactId>hisrc-higherjaxb-maven-plugin</artifactId>, it is the current JAXB spec (which at this time is higherjaxb40) but includes the missing jcl-over-slf4j dependency.

I've determined that the jcl-over-slf4j dependency is missing from hisrc-higherjaxb40-maven-plugin (and higherjaxb23, higherjaxb30). The issue occurs when a parameterized option like setters-mode=direct is used. The issue is triggered by a call to org.apache.commons.beanutils.ConvertUtilsBean. I'll add the missing dependency. Until the next release, you can add the following to the higherjaxb40 plugin dependencies in your POM.
<dependency>
    <groupId>org.slf4j</groupId>
    <artifactId>jcl-over-slf4j</artifactId>
    <version>2.0.7</version>
</dependency>

The fix for hisrc-higherjaxb40-maven-plugin (and higherjaxb23, higherjaxb30) is available in HiSrc BasicJAXB Release 2.2.0.


Unable to connect to Kubernetes Dashboard

Hi. I'm following the guidelines in :
https://github.com/open-ness/specs/blob/master/doc/getting-started/network-edge/controller-edge-node-setup.md#installing-kubernetes-dashboard
When I follow the steps, the UI is inaccessible via the https (as it appears to only be listening on localhost).

Deploy dashboard
Grep pods/namespaces (not sure why this is necessary?)
Create service account
Apply admin user
Change type to NodePort
Note port on which dashboard is exposed

[root@mec-ctl ~]# kubectl -n kubernetes-dashboard get service kubernetes-dashboard
NAME                   TYPE       CLUSTER-IP      EXTERNAL-IP   PORT(S)         AGE
kubernetes-dashboard   NodePort   <IP_ADDRESS>   <none>        443:30417/TCP   19m

Connect via https
It appears to only be listening on localhost meaning that I cannot connect to the UI.

I believe that it should be listening on either the interface to default gateway for the controller host (in my case <IP_ADDRESS>) or maybe even the configured ip from inventory.ini (in my case <IP_ADDRESS>)

I have completely redeployed controller and edge node, but have the same issue.
I install the dashboard as per instructions:
[root@mec-ctl ~]# kubectl apply -f https://raw.githubusercontent.com/kubernetes/dashboard/v2.0.0-beta4/aio/deploy/recommended.yaml namespace/kubernetes-dashboard created serviceaccount/kubernetes-dashboard created service/kubernetes-dashboard created secret/kubernetes-dashboard-certs created secret/kubernetes-dashboard-csrf created secret/kubernetes-dashboard-key-holder created configmap/kubernetes-dashboard-settings created role.rbac.authorization.k8s.io/kubernetes-dashboard created clusterrole.rbac.authorization.k8s.io/kubernetes-dashboard created rolebinding.rbac.authorization.k8s.io/kubernetes-dashboard created clusterrolebinding.rbac.authorization.k8s.io/kubernetes-dashboard created deployment.apps/kubernetes-dashboard created service/dashboard-metrics-scraper created deployment.apps/dashboard-metrics-scraper created
Next I query the pods (not sure what the point of this step is)
[root@mec-ctl ~]# kubectl get pods -o wide --all-namespaces NAMESPACE              NAME                                         READY   STATUS             RESTARTS   AGE     IP              NODE      NOMINATED NODE   READINESS GATES cdi                    cdi-operator-7796c886c5-xpv55                0/1     CrashLoopBackOff   9          63m     <IP_ADDRESS>       mec-n86   <none>           <none> kube-ovn               kube-ovn-cni-cxk85                           1/1     Running            0          77m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-ovn               kube-ovn-cni-rrrl9                           1/1     Running            8          54m     <IP_ADDRESS>   mec-n86   <none>           <none> kube-ovn               kube-ovn-controller-578786b499-nxtmd         1/1     Running            0          49m     <IP_ADDRESS>   mec-n86   <none>           <none> kube-ovn               kube-ovn-controller-578786b499-t7zdw         1/1     Running            0          77m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-ovn               ovn-central-5f456db89f-csn48                 1/1     Running            0          77m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-ovn               ovs-ovn-ch54q                                1/1     Running            3          77m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-ovn               ovs-ovn-d8t5f                                1/1     Running            0          54m     <IP_ADDRESS>   mec-n86   <none>           <none> kube-system            coredns-6955765f44-z5hfs                     1/1     Running            0          94m     <IP_ADDRESS>       mec-ctl   <none>           <none> kube-system            coredns-6955765f44-z9bfc                     1/1     Running            0          94m     <IP_ADDRESS>       mec-ctl   <none>           <none> kube-system            etcd-mec-ctl                                 1/1     Running            0          93m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-system            kube-apiserver-mec-ctl                       1/1     Running            0          93m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-system            kube-controller-manager-mec-ctl              1/1     Running            0          93m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-system            kube-proxy-dmv8n                             1/1     Running            0          94m     <IP_ADDRESS>   mec-ctl   <none>           <none> kube-system            kube-proxy-dwcxc                             1/1     Running            0          54m     <IP_ADDRESS>   mec-n86   <none>           <none> kube-system            kube-scheduler-mec-ctl                       1/1     Running            0          93m     <IP_ADDRESS>   mec-ctl   <none>           <none> kubernetes-dashboard   dashboard-metrics-scraper-566cddb686-t2qns   1/1     Running            0          2m55s   <IP_ADDRESS>      mec-n86   <none>           <none> kubernetes-dashboard   kubernetes-dashboard-7b5bf5d559-jcp6l        0/1     CrashLoopBackOff   2          2m55s   <IP_ADDRESS>      mec-n86   <none>           <none> kubevirt               virt-operator-c5cbfb9ff-h6mtl                0/1     Running            9          64m     <IP_ADDRESS>       mec-n86   <none>           <none> kubevirt               virt-operator-c5cbfb9ff-r4c9g                0/1     CrashLoopBackOff   8          64m     <IP_ADDRESS>       mec-n86   <none>           <none> openness               eaa-78b89b4757-8pgln                         1/1     Running            0          20m     <IP_ADDRESS>      mec-n86   <none>           <none> openness               edgedns-zvtnr                                1/1     Running            0          20m     <IP_ADDRESS>       mec-n86   <none>           <none> openness               interfaceservice-f44q2                       1/1     Running            0          20m     <IP_ADDRESS>      mec-n86   <none>           <none> openness               nfd-master-png8b                             1/1     Running            0          62m     <IP_ADDRESS>       mec-ctl   <none>           <none> openness               nfd-worker-6fvtg                             0/1     CrashLoopBackOff   13         49m     <IP_ADDRESS>   mec-n86   <none>           <none> openness               syslog-master-gxfcb                          1/1     Running            0          71m     <IP_ADDRESS>       mec-ctl   <none>           <none>
openness               syslog-ng-8sv7r                              1/1     Running            0          49m     <IP_ADDRESS>      mec-n86
I then created dashboard-admin-user.yaml exactly as per the instructions I then edited kubernetes-dashboard to change type to Node Port I then queried for the port...[root@mec-ctl ~]# kubectl -n kubernetes-dashboard get service kubernetes-dashboard
NAME                   TYPE       CLUSTER-IP      EXTERNAL-IP   PORT(S)         AGE
kubernetes-dashboard   NodePort   <IP_ADDRESS>           443:30035/TCP   8m41s
unfortunately it doesn't appear to be listening on anything other than localhost. #It only appears to be listening on localhost
[root@mec-ctl ~]# ss -ltn | grep 30035
LISTEN     0      128         :::30035                   :::*
`
This means that it is not possible to connect to the dashboard via any of it's IP addresses.

Hi @higginse-id.
I see there is a mistake at step 7, the IP to be put in the browser should be the worker-ip.
You may grep the node where the dashboard is deployed through this command
$ kubectl get pods -A -o wide | grep dashboard
kubernetes-dashboard   dashboard-metrics-scraper-566cddb686-rxvbb    1/1     Running            0          26m     <IP_ADDRESS>       worker01   <none>           <none>
kubernetes-dashboard   kubernetes-dashboard-7b5bf5d559-2qh87         1/1     Running            0          26m     <IP_ADDRESS>       worker01   <none>           <none>

NOTE: you should try using Firefox browser.
Please let me know if this solved your problem, so that I raise a known-issue in regards.

Hi @higginse-id, please let me know if this problem is solved. Thank you.

Closing this issue due to inactivity..


Technology <-> Framework recommendation map

Possibly map out recommended technology stack for a framework. What are the tools and recommended metrics to collect

@narmathabala - this issue has been stale for a while, is it still relevant with an active plan or should it be closed

Closing for now, will be added as needed


add k8s pod namespace to dns suffix

What this PR does / why we need it:
This PR adds kubernetes pod's namespace to dns suffix on Windows platform so that service name can be resolved by kube-dns.

Related PR in acs-engine https://github.com/Azure/acs-engine/pull/3180
Issue in acs-engine https://github.com/Azure/acs-engine/issues/3143


Unable to install custom schema

Hi 🙂, i have some problem with SDK (pod 'PrimerSDK', '= 2.3.0')
Unable to set custom schema, because schema is injected into dependency container in PrimerSettings, but gets according to the protocol PrimerThemeProtocol. As a result, it always initializes an empty schema and adds dependencies to the package.
I have some fix for this bug
`public func configure(settings: PrimerSettings? = nil, delegate: PrimerDelegate? = nil) {
    DependencyContainer.register((settings ?? PrimerSettings()) as PrimerSettingsProtocol)
    DependencyContainer.register((settings ?? PrimerSettings()).uiOptions.theme as PrimerThemeProtocol)
    self.delegate = delegate
}`

Thanks for the proposed change @LeshaKaras-lang. I believe we also have a PR open, addressing the same issue.
We are in the process of releasing a planned update of our SDK.
We will evaluate and include a fix for this issue in the next release plan.


Rufio Machine port is ignored

Expected Behaviour
Expected that Rufio used the port defined in the Machine manifest.
Current Behaviour
The port is ignored, and the default IPMI and Redfish ports are unexpectedly tried.

Possible Solution
Fix the problem in the source code, I guess.
Steps to Reproduce (for bugs)

- apiVersion: bmc.tinkerbell.org/v1alpha1
  kind: Machine
  spec:
    connection:
      authSecretRef:
        name: t1-bmc
        namespace: tink-system
      host: <IP_ADDRESS>
      insecureTLS: true
      port: 8070

Context

Rufio logs:
{"level":"info","ts":1683560746.0520737,"logger":"controller.Job","msg":"Reconciling Job","Job":"tink-system/t1"}
{"level":"error","ts":1683560798.2673254,"logger":"controller.Machine","msg":"BMC connection failed","Machine":"tink-system/t1","host":"<IP_ADDRESS>","error":"failed to open connection to BMC: 5 errors occurred:\n\
t* provider: gofish: Get \"https://<IP_ADDRESS>/redfish/v1/\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider: ipmitool: Error: Unable to establish IPMI v2 / RMCP+ session: exit status 1\n\t* pro
vider: *asrockrack.ASRockRack: Error logging in: Post \"https://<IP_ADDRESS>/api/session\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider: idrac9: Post \"https://<IP_ADDRESS>/sysmgmt/2015/bmc/sessi
on\": net/http: invalid header field value \"\\\"admin\\n\\\"\" for key User\n\t* no Opener implementations found\n\n","stacktrace":"github.com/tinkerbell/rufio/controllers.(*MachineReconciler).Reconcile\n\t/wor
<EMAIL_ADDRESS>r.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:311\nsigs.k8s.io/contro
ller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal
/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":1683560798.2675514,"logger":"controller.task","msg":"BMC connection failed","reconciler group":"bmc.tinkerbell.org","reconciler kind":"Task","name":"t1-task-0","namespace":"tink-system","ho
st":"<IP_ADDRESS>","error":"failed to open connection to BMC: 5 errors occurred:\n\t* provider: gofish: Get \"https://<IP_ADDRESS>/redfish/v1/\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider: ipmi
tool: Error: Unable to establish IPMI v2 / RMCP+ session: exit status 1\n\t* provider: *asrockrack.ASRockRack: Error logging in: Post \"https://<IP_ADDRESS>/api/session\": dial tcp <IP_ADDRESS>:443: connect: connectio
n refused\n\t* provider: idrac9: Post \"https://<IP_ADDRESS>/sysmgmt/2015/bmc/session\": net/http: invalid header field value \"\\\"admin\\n\\\"\" for key User\n\t* no Opener implementations found\n\n","stacktrace"
:"github.com/tinkerbell/rufio/controllers.(*TaskReconciler).Reconcile\n\t/workspace/controllers/task_controller.go:86\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mo
d/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-run
time<EMAIL_ADDRESS>/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":1683560798.2914627,"logger":"controller.machine","msg":"Reconciler error","reconciler group":"bmc.tinkerbell.org","reconciler kind":"Machine","name":"t1","namespace":"tink-system","error":"
failed to open connection to BMC: 5 errors occurred:\n\t* provider: gofish: Get \"https://<IP_ADDRESS>/redfish/v1/\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider: ipmitool: Error: Unable to es
tablish IPMI v2 / RMCP+ session: exit status 1\n\t* provider: *asrockrack.ASRockRack: Error logging in: Post \"https://<IP_ADDRESS>/api/session\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider:
idrac9: Post \"https://<IP_ADDRESS>/sysmgmt/2015/bmc/session\": net/http: invalid header field value \"\\\"admin\\n\\\"\" for key User\n\t* no Opener implementations found\n\n","stacktrace":"sigs.k8s.io/controller-
runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/cont
roller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227"}
{"level":"info","ts":1683560798.291582,"logger":"controller.Machine","msg":"Reconciling Machine","Machine":"tink-system/t1"}
{"level":"error","ts":1683560798.2984927,"logger":"controller.task","msg":"Reconciler error","reconciler group":"bmc.tinkerbell.org","reconciler kind":"Task","name":"t1-task-0","namespace":"tink-system","error":
"failed to open connection to BMC: 5 errors occurred:\n\t* provider: gofish: Get \"https://<IP_ADDRESS>/redfish/v1/\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider: ipmitool: Error: Unable to e
stablish IPMI v2 / RMCP+ session: exit status 1\n\t* provider: *asrockrack.ASRockRack: Error logging in: Post \"https://<IP_ADDRESS>/api/session\": dial tcp <IP_ADDRESS>:443: connect: connection refused\n\t* provider:
 idrac9: Post \"https://<IP_ADDRESS>/sysmgmt/2015/bmc/session\": net/http: invalid header field value \"\\\"admin\\n\\\"\" for key User\n\t* no Opener implementations found\n\n","stacktrace":"sigs.k8s.io/controller
-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/con
troller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227"}

Your Environment

Operating System and version (e.g. Linux, Windows, MacOS): n/a

How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

I'm using vagrant with emulated bmc (vbmc) from https://github.com/rgl/terraform-provider-vbmc.

Link to your project or a code example to reproduce issue:

Hey @rgl, thanks for the report. Unfortunately, this has been outstanding for some time. This bmclib PR https://github.com/bmc-toolbox/bmclib/pull/326 will enable port setting to actually be implemented. Once it lands, we'll get it in Rufio.

Update: the machine CRD has been updated to handle per provider options. I'm working on implementing it in the controller now. Once that is done this functionality will be available and functioning.


Fixing links to sample and source code

What changes to the docs does this PR provide?
links to the sample and source were incorrect and received a 404 when clicking on them

Docs Build status updates of commit 23af6d5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/behaviors/setfocusonentrycompletedbehavior.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thank you for catching this @alexkblount !


Activate message always shows at startup in Insiders

[x] I'm sure this issue is not a duplicate?

I just switched to the insiders versions. The version is the following:
Version 1.15.0-insider (1.15.0-insider)
ae73f8ee6f8ddb87b5e30d31655d9f55a53f4a95
2017-07-26T07:33:29.308Z

Overtime I start the editor, I have the informations message asking me if I want to activate the extension:

Whatever I click, the message does not disappear. The same if I uninstall and reinstall.
I also tried to set the following parameters to false:
"vsicons.dontShowNewVersionMessage": true,
"vsicons.dontShowConfigManuallyChangedMessage": true

The cause is a crash when vscode is trying to determine the version of the extension.
The actual error is :

Activating extension robertohuertasm.vscode-icons failed:  Invalid Version: 0

I know exactly what is going on and I'll provide a fix soon.

This issue returned for me after upgrading to 7.13.0.

@ostrgard May you create a new issue please? I cannot reproduce.


Latency with cueing motif

my running suspicion is it is because I am using the sonic pi macro "define" to make a named function and then making a named thread that calls that function. The original implementation was for multiple motifs to be cue-able at a time. But since only one motif is cueable at a time, we can simplify this by just spinning the thread, and not defining the function.
Why we still need the thread:
loop / stop, and just piece of mind about code independence. We do not want the execution of a sonic-pi thread to block syncing beats or anything else.

So the define to eval isn't really that laggy. It is probably the sonic pi <-> audio drivers that are laggy.

Any sense of how uniformly laggy it is? Both across and within units? Seems important for sync ability.

On Jul 21, 2015, at 5:22 PM, Matthew Ahrens<EMAIL_ADDRESS>wrote:
So the define to eval isn't really that laggy. It is probably the sonic pi <-> audio drivers that are laggy.
—
Reply to this email directly or view it on GitHub.

Nope, that is my dev goal for tomorrow morning. The I'll see how syncing goes and if they "all lag together"

So, since they "all lag together" (we syncronized 8 units today) I am going to close the bug version of this. But I think we should consider a low-latency alternative or investigation as further enhancement.

Very cool! Did you sync with the kids?
On Thu, Jul 23, 2015, at 07:27 PM, Matthew Ahrens wrote:

So, since they "all lag together" (we syncronized 8 units today) I am
going to close the bug version of this. But I think we should consider
a low-latency alternative or investigation as further enhancement.

— Reply to this email directly or view it on GitHub[1].

Links:

https://github.com/tufts-LPC/blockytalky_elixir/issues/12#issuecomment-124266356

yep! all of the kids' units played in time with each other! it was pretty neat.


formulae: use full names

Redo of #477, which will be reverted by #479 as Dependency and FormulaConflict do not have a full_name method (Dependency#name and FormulaConflict#name already return the full name)

Is this good to merge?

formula.full_name is used a few lines down so I'm 99.9% confident


UTF8 should write BOM (optional) (FileTarget)

When you add encoding="utf-8" on a file target, encoding of the result file is a UTF-8 encoding but the preamble (Binary Object Mark) is not present at the start of the file then some tools that use this BOM not recognize the encoding as UTF-8...
In https://github.com/jkowalski/NLog/blob/master/src/NLog/Targets/FileTarget.cs source file
I suggest to add preamble bytes as below:
Method "WriteToFile", line 964

 private void WriteToFile(string fileName, byte[] bytes, bool justData)
 {
     if (this.ReplaceFileContentsOnEachWrite)
     {
         using (FileStream fs = File.Create(fileName))
         {
             //get preamble bytes
             byte[] preambleBytes = this.Encoding.GetPreamble();
             byte[] headerBytes = this.GetHeaderBytes();
             byte[] footerBytes = this.GetFooterBytes();
             //write preamble bytes
             if (preambleBytes != null)
             {
                 fs.Write(preambleBytes, 0, preambleBytes.Length);
             }
             if (headerBytes != null)
             {
                 fs.Write(headerBytes, 0, headerBytes.Length);
             }
             fs.Write(bytes, 0, bytes.Length);
             if (footerBytes != null)
             {
                 fs.Write(footerBytes, 0, footerBytes.Length);
             }
         }
         return;
     }

     /* some source code ... */
     if (writeHeader && !justData)
     {
         //get preamble bytes
         byte[] preambleBytes = this.Encoding.GetPreamble();
         //write preamble bytes
         if (preambleBytes != null)
         {
             appenderToWrite.Write(preambleBytes);
         }
         byte[] headerBytes = this.GetHeaderBytes();
         if (headerBytes != null)
         {
             appenderToWrite.Write(headerBytes);
         }
     }
     /* end of method */
 }

Moved from http://nlog.codeplex.com/workitem/6831

BOM is no bug, as it is valid to the specs of UTF-8

Have been fixed #629

No it isn't. The PR is changed for only Webservice, because it seemed the same problem, but it wasn't.

Sorry, you're of course correct

NP! I understand the confusion :)

Sorry, I am the initial author of the issue on codeplex. I add this message to be notified by github :)

after 5 years this is done  O:)

Thanks for the velocity ;-)


Via port inconsistency

In trying to instantiate a ring_double_heater I noticed that naming of returned ports is different if the function is supplied a via_stack specification or a via_stack_slot specification. via_stack results in electrical ports e1 and e2 whereas via_stack_slot gets suffixes resulting in ports such as e1e4 and e2e4
It seems like this has something to do with the difference in how the functions call the compass component, but I'm not exactly sure. I would expect that both via specifications should just result in e1 and e2 as electrical ports

Thank  you for reporting this!
is seems to be a bug on c.auto_rename_ports()
there is a quick fix of removing on ring_double_heater.py
c.auto_rename_ports()

Here is the code to reproduce
    from gdsfactory.components import ring_double_heater

    c1 = ring_double_heater(via_stack="via_stack")
    c1.pprint_ports()

    c2 = ring_double_heater(via_stack="via_stack_slot")
    c2.pprint_ports()

Im trying to understand why this is happening

the issue is that one had ports of type 'placement' and the other one 'electrical' and the auto_rename ports was not renaming the ports with type placement


Removed unused modules & f-strings with no placeholders

Hi 👋
This pull request comes with a few commits which:

Remove unused imported modules
Convert f-strings with no placeholders to normal strings.

/azp run

Thanks @alaabenfatma for your contribution!


Update CHANGELOG.md for 0.52.0 release, add scripts/ instructions for ASF releases

Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1423
This is the first release that will be officially voted / approved by the Apache voting process and this PR

Updates the version to 0.52.0
Adds the necessary scripts for making a release (based off what is in the datafusion repo)
Adds instructions in dev/release/README.md

Draft until:

[x] https://github.com/apache/datafusion-sqlparser-rs/pull/1502
[x] https://github.com/apache/datafusion-sqlparser-rs/pull/1503
[x] Port the tarball creation scripts
[x] Test it out for the first time

Following the directions results in this:
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/sqlparser-rs$ GITHUB_TOKEN=FOO ./dev/release/create-tarball.sh 0.52.0 2
Attempting to create  from tag v0.52.0-rc2
Draft email for<EMAIL_ADDRESS>mailing list

---------------------------------------------------------
To<EMAIL_ADDRESS>Subject: [VOTE] Release Apache DataFusion sqlparser-rs 0.52.0 RC2
Hi,

I would like to propose a release of Apache DataFusion sqlparser-rs version 0.52.0.

This release candidate is based on commit: 6b491c659ab8a350ee333f489251c7ce446af729 [1]
The proposed release tarball and signatures are hosted at [2].
The changelog is located at [3].

Please download, verify checksums and signatures, run the unit tests, and vote
on the release. The vote will be open for at least 72 hours.

Only votes from PMC members are binding, but all members of the community are
encouraged to test the release and vote with "(non-binding)".

The standard verification procedure is documented at https://github.com/apache/datafusion-sqlparser-rs/blob/main/dev/release/README.md#verifying-release-candidates.

[ ] +1 Release this as Apache DataFusion sqlparser-rs 0.52.0
[ ] +0
[ ] -1 Do not release this as Apache DataFusion sqlparser-rs 0.52.0 because...

Here is my vote:

+1

[1]: https://github.com/apache/datafusion-sqlparser-rs/tree/6b491c659ab8a350ee333f489251c7ce446af729
[2]: https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-sqlparser-rs-0.52.0-rc2
[3]: https://github.com/apache/datafusion-sqlparser-rs/blob/6b491c659ab8a350ee333f489251c7ce446af729/CHANGELOG.md

You can actually check out a release candidate I made here:

https://github.com/apache/datafusion-sqlparser-rs/tree/6b491c659ab8a350ee333f489251c7ce446af729
https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-sqlparser-rs-0.52.0-rc2
Changelog: https://github.com/apache/datafusion-sqlparser-rs/blob/6b491c659ab8a350ee333f489251c7ce446af729/CHANGELOG.md

Thanks @iffyio  -- Let's get this in and give making a release a try!

🚀