Incorrect inference of arrow function with intersected mapped type argument under strictFunctionTypes

TypeScript Version:  3.6.0-dev.20190801

Search Terms: inference intersection type strictFunctionTypes
Code
type MappedIntersection<T extends {}> = { [P in keyof T]: string } & {};
type MappedRaw<T extends {}> = { [P in keyof T]: string };

// Case 1: Intersection + no arrow = succeed
type ToInferNoArrowIntersection<T extends {}> = {
    fn(params: MappedIntersection<T>): void;
};

type NoArrowIntersection<T extends ToInferNoArrowIntersection<any>> = void;
declare const case1: NoArrowIntersection<{
    fn: (params: MappedIntersection<{a: 1}>) => string,
}>;

// Case 2: No intersection + arrow = succeed
type ToInferArrowNoIntersection<T extends {}> = {
    fn: (params: MappedRaw<T>) => void;
};

type ArrowNoIntersection<T extends ToInferArrowNoIntersection<any>> = void;
declare const case2: ArrowNoIntersection<{
    fn: (params: MappedRaw<{a: 1}>) => void,
}>;

// Case 3: Intersection + arrow = fail
type ToInferArrowIntersection<T extends {}> = {
    fn: (params: MappedIntersection<T>) => void;
};

type ArrowIntersection<T extends ToInferArrowIntersection<any>> = void;
declare const case3: ArrowIntersection<{ // Fails here
    fn: (params: MappedIntersection<{a: 1}>) => void,
}>;

Expected behavior:
Expected case 3 to succeed.
Actual behavior:
Case 3 produces:
 Type '{ fn: (params: { a: string; }) => void; }' does not satisfy the constraint 'ToInferArrowIntersection<any>'.
  Types of property 'fn' are incompatible.
    Type '(params: { a: string; }) => void' is not assignable to type '(params: { [x: string]: string; }) => void'.
      Types of parameters 'params' and 'params' are incompatible.
        Property 'a' is missing in type '{ [x: string]: string; }' but required in type '{ a: string; }'.

Seems relevant that compilation succeeds without strictFunctionTypes
Playground Link: Playground
Related Issues:
https://github.com/microsoft/TypeScript/issues/29123#issuecomment-453884098
https://github.com/microsoft/TypeScript/issues/31081

Case 1 correctly produces no error because fn is a method and therefore related by bivariantly.
Case 3 should produce an error because under strict function types the function inputs are related in reverse, and a string indexer is not related to the object with property a.
declare const x: { [x: string]: string; };
const b: { a: string } = x; // error

It appears to be Case 2 that is questionable, and is most likely due to variance measurements. I can correctly synthesise the error by using identical but distinct type aliases.
type MappedIntersection<T extends {}> = { [P in keyof T]: string } & {};
type MappedRaw1<T extends {}> = { [P in keyof T]: string };
type MappedRaw2<T extends {}> = { [P in keyof T]: string };

// Case 2: No intersection + arrow = succeed
type ToInferArrowNoIntersection<T extends {}> = {
    fn: (params: MappedRaw1<T>) => void;
};

type ArrowNoIntersection<T extends ToInferArrowNoIntersection<any>> = void;
declare const case2: ArrowNoIntersection<{
    fn: (params: MappedRaw2<{a: 1}>) => void, // error
}>;

So what seems to be going on is that in Case 2 the params arguments are being related by their type parameters: this succeeds because any is related to everything. In Case 3 it appears that the intersection causes variance checking to be skipped and a structural check is used instead, which correctly detects the error.

Minimal repro:
declare const a: MappedIntersection<any>;
declare const b: MappedRaw1<any>;
const zMeasure: MappedRaw1<{x: string}> = b; // no error
const zStructural: MappedRaw2<{x: string}> = b; // error
const zDifferent: MappedRaw2<{x: string}> = a; // error

Does https://github.com/microsoft/TypeScript/pull/32225 fix the issue, I wonder?

Yeah I wasn't sure if that was merged, but it seems to target the problem!

I might be wrong somewhere, but aren't Case 1 and Case 3 supposed to be identical?
I was under impression that fn(): void and fn: () => void describe the same thing.

Sorta. Outside strict, yes, but within strict mode the method syntax is used as a hint for looser typechecking.

Does it means that by design third case will always fail?
Does that also mean that sometime in the future first case will also be failing?
I have trouble understanding why describing same underlying JS might fail or succeed based on a choice of syntax.

@weswigham Seems to be an issue with unreliable markers rather than unmeasurable, if my understanding is correct. Optionality modifiers work ok, but readonly (or none) do not.
type MappedRaw1RO<T extends {}> = { readonly [P in keyof T]: string };
type MappedRaw2RO<T extends {}> = { readonly [P in keyof T]: string };

declare const b: MappedRaw1RO<any>;
const zMeasure: MappedRaw1RO<{x: string}> = b; // ***no error***
const zStructural: MappedRaw2RO<{x: string}> = b; // ***error***

type MappedRaw1OPT<T extends {}> = { [P in keyof T]-?: string };
type MappedRaw2OPT<T extends {}> = { [P in keyof T]-?: string };

declare const b2: MappedRaw1OPT<any>;
const zMeasure2: MappedRaw1OPT<{x: string}> = b; // ***error***
const zStructural2: MappedRaw2OPT<{x: string}> = b; // ***error***

@jack-williams, if Case 3 indeed should produce an error, check out the case where type MappedIntersection<T extends {}> = MappedRaw<T> & {}; in initial submission. Because this gets Case 3 to compile successfully.

@smoogly The only fully typesafe way to relate two functions is to relate their parameters contravariantly, i.e. function A is assignable to function type B if all of B's parameters are assignable to A's.  This is because the parameters represent data that flows in the opposite direction over the =: assignment typically moves data right to left, but calling the aliased function will send the arguments left to right over that same assignment.  --strictFunctionTypes enforces this for functions and lambdas, but not methods.
Methods are related bivariantly as a tradeoff, because much of the public JS API (especially the DOM API) have fundamentally unsound designs that would become very difficult to use if the "correct" variance were enforced for methods.  For example, Array should be invariant to be fully typesafe, but in practice is covariant because that reflects the way idiomatic JS code is written.

@smoogly That compiles for the same reason case two compiles: the use of the alias enables variance measurements. The type MappedRaw is never expanded and the checker just ensures that the type arguments are related.

Gentlemen, thank you for setting my mind straight about assignability.
My expectation was wrong about Case 3 based on habit of use in<EMAIL_ADDRESS>

#32225 doesn't fix this :(

@weswigham What do unreliable markers do? From a quick glance it seems that they have no affect and only unmeasurable is guaranteed to prevent variance measurements being used.
In the most conservative case any use of keyof should discard variance measurements because it's not an order-preserving function, but that is a drastic action to avoid a few pathological cases (usually involving any or something with a string indexer).
interface KeyOf<T> {
  key_of: keyof T;
}

const x: KeyOf<{ [x: string]: number }> = { key_of: "random" } // also works with KeyOf<any>
const y: KeyOf<{ x: number }> = x;
const xKey: "x" = y.key_of;

Aside from ignoring variance when the type parameter is instantiated with a degenerate case like any is there anything that can reasonbly be done here?

Unreliable is supposed to be "fallback to structural if varianced-based check fails" while Unmeasurable is "don't use the variance result at all". It was a bit of a compromise to continue to allow some things that checked with variance but not by structure, so the change would break less, iirc. In theory the only thing that would change by converting all Unreliable into Unmeasurable is performance, in practice I'm not sure that's the case.

So Unreliable can allow things to typecheck successfully that would fail a structural check?  That seems like a footgun: I would expect the structural result to be the canonical source of truth.

I would, too, but as it turns out a Readonly<any> isn't structurally compatible with a Readonly<{x: number}> because of how any feeds into mapped types...


WIP (Do not merge)

We need to run tests on this with the CI/CD system; nothing to see here.

... and this one.

This hasn't been updated since August so I'm closing it.


TabView item drag does not adapt to DPI change

Describe the bug
The visual / tooltip shown when dragging a TabViewItem is not per monitor dpi aware.
#8442 is for WinUI2. Same issue here for WinUI3.
Steps to reproduce the bug

Open WinUi3 Gallery, go to TabView page
Drag a TagViewItem to another monitor with a different dpi

The font size and visual size are not changing
Expected behavior
No response
Screenshots

NuGet package version
WinUI 3 - Windows App SDK 1.5.4: 1.5.240607001
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

I believe this is an OS issue, making the underlying cause/fix the same as #8442. Let's track through that one issue. I added a comment in that issue to note the issue also applies to WinUI3.


Check compatibility with 'Designator shapes'

For it to work, one has to select a 'filled rectangle'.


HTTP status codes different than 200 can throw OaipmhException

When an OAI-PMH error is returned with an HTTP status code different than 200, the library throws an HttpException instead of a more meaningful OaipmhException. The pull request fixes this behaviour by also checking the response body of an HttpException for OAI-PMH errors.

Thanks @scheb .  I'll review this.  My only concern would be if HTTP protocol errors are conflated with OAI-PMH protocol errors.  I would like to keep them separate if possible, relying on the HTTP transport library (e.g. Guzzle) to handle transmission errors, while this library handles any OAI-PMH response body errors.

Some OAI interfaces return HTTP error code in addition to an OAI XML error message in the body. This behaviour is optional by definition, but some APIs have implemented it.
E.g. take a look at:
http://www.pubmedcentral.nih.gov/oai/oai.cgi?verb=ListRecords&metadataPrefix=bad
HTTP error code 404 and a valid OAI XML error in the body. I'd expect the library to throw a OaipmhException with error code "cannotDisseminateFormat" in that case, but instead a HttpException is thrown.
I've changes the bahaviour to check the body, when a HttpException is thrown. If a OAI XML error is present, a OaipmhException is thrown. If not, the HttpException.

@scheb After looking at this thoroughly, I agree with your interpretation of how OAI-PMH errors are thrown, and I will merge this.  New release later today.\


Add favicon.ico

I noticed there is no icon when i was on the website
I downloaded the square brackets emoji and converted it to ".ico"

Thank you


Chicken Geiser is abysmally slow with large environments

The following code reproduces the issue:
(use (prefix allegro al:)
     (prefix opengl-glew gl:)
     (prefix gl-utils gl:))

(time
 (geiser-autodoc #f '((ap) (li) (fo))))

(time
 (geiser-symbol-documentation #f 'apropos))

Basically, on my test system, the geiser-autodoc call takes about 1.2 seconds. You can imagine what this is like to code with. :smile:

Happily, it scales linearly with the length of the symbol list.

Both make calls to apropos, and testing what it would be like....
> (time (apropos (regexp "^([^#]+#)*ap")))
0.527s CPU time, 182731/2646 mutations (total/tracked), 0/1251 GCs (major/minor)

Not using a regexp speeds it up by about 50%. Hmm, maybe I'll have to do some post-processing.

I've got code with an order of magnitude speed increase in geiser-completions...

Sadly, apropos itself is a huge afront to speed


Update references EIP4844 to Deneb

https://github.com/ethereum/consensus-specs/pull/3215

As a note, this will be reopened if the c-kzg-4844 library is renamed


[Automation] Generate Fluent Lite from recoveryservicesbackup#package-2023-04

[Automation] Generate Fluent Lite from recoveryservicesbackup#package-2023-04

/azp run java - recoveryservicesbackup - mgmt - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-recoveryservicesbackup

Close due to breaking changes.


Best practice to decorate both IRequest and IAsyncRequest

public class CacheHandlerAsync < TRequest, TResponse > :
 IAsyncRequestHandler <TRequest, TResponse> , IRequestHandler < TRequest, TResponse >
 where TRequest: BaseCommand <TResponse> {
  private readonly IRequestHandler <TRequest,TResponse> _inner;
  private readonly IAsyncRequestHandler <TRequest,TResponse> _innerAsync;

  async Task <TResponse> IAsyncRequestHandler <TRequest,TResponse> .Handle(TRequest request) {}
  public TResponse Handle(TRequest request) {}
 }

I have to write two methods. Is there better way ?

Yes. If you only create async handlers, you only need to create the one wrapper. For handlers marked as async but don't actually need it, you can just do:
public class FooHandler : IAsyncRequestHandler<Foo, Bar> {
public Task<Bar> Handle(Foo request) {
   var bar = BuildBar(request);

   return Task.FromResult(bar);
}
}

You only would add the async/await keywords if you were actually awaiting something.

We're moving to just IAsyncRequestHandler everywhere by default as we've found it similar to just think about one type of request. Any overhead around Task should be trivial.

This will be taken care of more easily with pipelines too now. They will support all request types.


BUG: TWAP bot shows no tokens. Just keep spinning.

What is happening?

Section description
Provide as much context as you can. Give as much context as you can to make it easier for the developers to figure what is happening.

BUG: TWAP bot shows no tokens. Just keep spinning.
How to reproduce?

Section description
Please write detailed steps of what you were doing for this bug to appear.

https://www.curvebot.fi/curve-twap/ and connect wallet.
What is the expected behaviour?

Section description
If you know, please write down what is the expected behaviour. If you don't know, that's ok. We can have a discussion in comments.

Tokens are listed.

This might be related https://volume-x3.sentry.io/issues/3965070840/?alert_rule_id=13483462&alert_timestamp=1698914185818&alert_type=email&environment=production&notification_uuid=a79a7090-1bd6-446c-a119-002f0c88a8c4&project=6380489&referrer=alert_email

https://github.com/palomachain/paloma-nest-service/pull/70


error throwing on expectede behaviour

Removing Errors of expected behavior in the following two scenarios:
Removing a non-existent member throws an error. Non-existence is expected because members unsubscribe regularly from an audience. Should log the info but not throw an error. The final state is the same.
Adding a member who already is part of the audience throws an error. You often have multiple ways users can signup to an audience. Firebase auth is only one of them. Should log the into but not throw an error. The final state is the same.

PR made : https://github.com/firebase/extensions/pull/600

Thanks @FredCoen. I've added this to our tracker for review.

Closing in favour of https://github.com/mailchimp/Firebase/issues/33.
This extension is now maintained in the official Mailchimp Github organisation.


[BUG] Extended Advertisement records leaked with Thread devices

Reproduction steps

Factory reset a BLE+Thread device that A) uses extended advertising and B) clears its Thread credentials when there are no more fabrics
Pair the device e.g. with chip-tool
Remove all fabrics
Examine the mdns advertisements for this device, there should be none but there is one

Bug prevalence
always
GitHub hash of the SDK that was being used
e059202613e91da78884aec4e1041d76da0af9bf
Platform
nrf
Platform Version(s)
All
Anything else?
With Extended Discovery enabled, when removing the last fabric the SDK immediately begins extended advertising. In case of a spec compliant BLE+Thread device that clears its Thread credentials when there are no more fabrics this results in a leaked/dangling advertisement that does not correspond to any device. This advertisement sticks around for 2 hours.
Should be fixed at SDK level to avoid manufacturer workarounds.

It sounds like we need to order the "begins extended advertising" to after the Thread credentials have been cleared....  Where does that "begins extended advertising" code live if you happen to know @bluebin14 ?

is handled entirely by the SDK,

Yes, but I was asking where.

if there was some doNotStartExtendedAdvertisingAfterLastFabricIsRemoved setting

What's the point of extended advertising, then?  Put another way: why is this device enabling the extended advertising at all?

The code is in Dnssd.cpp. The extended advertising is an Amazon Works with Alexa requirement/recommendation.  I agree it conflicts with this scenario and the requirement should be removed. Nevertheless it would still be applicable while there is at least one fabric present.


Identity Server 5.1.0 release date

Is there any tentative date for IDentity Server 5.1.0 release?

I am wondering this too.

When you guys are going to release the GA?. It's more than 8 months now without any update. At least can we expect a Beta 2 anytime soon??

Hi @tapas4java,
Identity Server 5.1.0 RC will be released within this year. Currently there ain't any plans for Beta 2.
Thanks

Thanks @darshanasbg


MTL-1613 new metal ipxe

Summary and Scope

Fixes CASMINST-3789 MTL-1613
Relates to CASMTRIAGE-2793

Issue Type

Bugfix Pull Request

This reverts commit 5303a8bea5fb7160936043b17da2171e448eeada, ceasing DHCPing on every NIC. Instead the xname issue from CASMINST-3789 by removing an ambiguous variable in the iPXE script.
Prior to CASMTRIAGE-2793 the netX variable was reliably relaying the current, active DHCP interface. This behavior broke after CASMTRIAGE-2793, the netX variable actually refers to the current open interface which is all of them. Thus we have to specifically select the interface that truly succeed DHCP, instead of relying on the short-cut variable.
This change removes the null setting, to prevent retries from erasing the xname as well.
Prerequisites

[ ] I have included documentation in my PR (or it is not required)
[x] I tested this on internal system (x) (if yes, please include results or a description of the test)

redbull

All NCNs reported xnames in their /proc/cmdline files.

Idempotency

Risks and Mitigations
What is less risky, or more risky now - or if your mod fails is there a new risk?
On PXE failures the xname will still be set, despite DHCP packet information being lost. This is because we set it the first time it exists, instead of every time we DHCP. See line 16 of script.ipxe for this explanation in code.

This PR won't build until the LiveCD finishes.
This PR includes metal-ipxe and a LiveCD with that metal-ipxe.


targets: delete CFlags

According to
https://github.com/google/syzkaller/pull/1732#issuecomment-627809865,
they have been unused since 3aa3800.
Signed-off-by: Alexander Potapenko<EMAIL_ADDRESS>
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

Does it make sense to change CrossCFlags to CFlags after this change? I guess they are not only used when cross compiling...

CI shows diff:
diff --git a/sys/targets/targets.go b/sys/targets/targets.go
index d8cdc54..5fbd904 100644
--- a/sys/targets/targets.go
+++ b/sys/targets/targets.go
@@ -182,8 +182,8 @@ var List = map[string]map[string]*Target{
 			KernelHeaderArch: "mips",
 		},
 		"ppc64le": {
-			PtrSize:  8,
-			PageSize: 4 << 10,
+			PtrSize:          8,
+			PageSize:         4 << 10,
 			CrossCFlags:      []string{"-D__powerpc64__", "-static"},
 			CCompilerPrefix:  "powerpc64le-linux-gnu-",
 			KernelArch:       "powerpc",
-e
Some files are not formatted/regenerated (include them into commit):
sys/targets/targets.go

(But it did not fail; I fixed it in https://github.com/google/syzkaller/commit/9a6d42fb404b4433fa780d4258e394df8c96748d).

Does it make sense to change CrossCFlags to CFlags after this change? I guess they are not only used when cross compiling...

Absolutely. And remove Cross from BrokenCrossCompiler. Everything in Target is about Cross now.

Absolutely. And remove Cross from BrokenCrossCompiler. Everything in Target is about Cross now.

Done

Nice! Some sanity in sys/targets.


Fix CI: remove link.xml* from the foundation nuspec, it is auto generated

This change fixes CI by removing link.xml and link.xml.meta from MixedReality.Toolkit.Foundation.nuspec

/azp run


High CPU load when using Jupyter and LiveShare simultaneously

Issue Type: Bug
Extension Name: jupyter
Extension Version: 2021.5.702919634
OS Version: Windows_NT x64 10.0.19042
VS Code version: 1.55.0

High CPU loads when utilizing Jypyter and LiveShare simultaneously.
Any tips on how to fix that?
ms-python.python-unresponsive.cpuprofile.txt
{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 305,
		"activateCallTime": 8,
		"activateResolvedTime": 411,
		"activationReason": {
			"startup": false,
			"extensionId": {
				"value": "ms-toolsai.jupyter",
				"_lower": "ms-toolsai.jupyter"
			},
			"activationEvent": "onLanguage:python"
		}
	},
	"runtimeErrors": []
}

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


Bug fix/refactor read write locks

opening on behalf of @mpoeter

Are there any performances benchmarks on these locks ?

This PR contains new implementations of ReadWriteLock and ReadWriteSpinLock. The new ReadWriteLock strictly perfers writers (similar to the old version), but tries to avoid acquiring the mutex where possible. In addition it introduces an additional condition_variable to have separate notifications for readers and writers. The new ReadWriteSpinLock is almost identical to the ReadWriteLock except that it keeps spinning instead of waiting for a CV.
To compare the performance of the implementations I ran a number of synthetic benchmarks for different scenarios (varying number of threads, reader/writer ratio and time a lock is held) on 4 different machines with up to 4 sockets and 160 hardware threads. Over all scenarios, the mean throughput of new ReadWriteLock was ~7% higher; a paired Wilcoxon test also confirmed that the throughput of the new implementation is significantly higher (p = 2.502e-06). The mean throughput of the new ReadWriteSpinLock was slightly higher (~2%), but not significantly. However, the memory requirements of the new implementation are significantly lower (4 bytes vs 8360 bytes with the default of 64 stripes). I understand that the stripes were introduced to reduce cache collisions, but at least in my tests they did not show a significant advantage.
The new implementations should provide slightly better or at least comparable performance compared to the old version, but they are by no means perfect. Depending on your requirements I could contribute some more specialized locks, e.g., with respect to fairness, NUMA awareness etc.
However, my long term plan would be to remove some of the locks in favor of concurrent data structures anyway.

Can you share your benchmarking code with us ? I am about 95% certain that the spinning lock design used to be very similar to yours, until we changed it to optimize for some graph traversal benchmarks

Sure: https://gist.github.com/mpoeter/fe6c925604f4c552b7f0a722d5938202
To simulate varying times the lock is held I replaced the yield with the commented sleep with a random sleep time. Another (optional) sleep can be used to simulate reduced contention due to other work outside the lock. In case the sleeps are activated the throughput is significantly lower, so you have to change the code to measure ops/sec instead.

For reference - the performance blogpost and the source of the tests that @graetzer referenced; Where its very important that we don't get slower at.

I will try to setup the benchmark on my machine and provide the results for both implementations.

I ran the specified benchmark for the RocksDB engine on 2 different machines.
Machine 1

Intel Core i5-6500 (4 cores),
16GB memory
Linux 4.13.0-39-generic Ubuntu SMP Thu Apr 5 14:25:01 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Machine 2

8x Intel Xeon E7- 8850 (80 cores, 2x SMT)
1TB memory
Linux 4.7.0-1-amd64 SMP Debian 4.7.6-1 (2016-10-07) x86_64 GNU/Linux

Benchmark
old1
new1
new1/old1
old2
new2
new2/old2

shortest
948,70
938,05
0,9888
595,65
589,4
0,9895

neighbors
199,75
199,25
0,9975
420,4
414,75
0,9866

neighbors2
2530,70
2504,85
0,9898
1751,95
1747,55
0,9975

singleRead
11288,75
11438,05
1,0132
44371
43074,9
0,9708

singleWrite
14619,25
14529,90
0,9939
63041,75
62715,8
0,9948

singleWriteSync
47343,90
46401,00
0,9801
107913,1
107775,5
0,9987

aggregation
833,30
814,95
0,9780
2939,4
2655,6
0,9034

neighbors2data
3335,75
3332,85
0,9991
10268,75
10288,85
1,0020

The results show a small speedup with the new implementation on both machines in almost all scenarios.

Pulled from @mpoeter  and started http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/409/


Unhandled exception. Silk.NET.Core.Loader.SymbolLoadingException: Native symbol not found (Symbol: vkCreateDebugUtilsMessengerEXT)

Summary
Hello,
I am trying to setup vulkan in F# with Silk.Net. So far everything works as expect but somehow I am not able to setup a debug messenger. Here is my code line which fails:
 debugUtils.CreateDebugUtilsMessenger(state.instance, &createInfo, NativeInterop.NativePtr.nullPtr, &state.debugMessenger)
I think that somehow Sill.net isnt using the Vulkan Version which I expect. Maybe you have a idea on how to fix it and which vulkan sdk should work.
Steps to reproduce

Platform: Windows/Desktop
Framework Version: .NET 7,
API: Vulkan
API Version: Vulkan 1.3

Executable Info
Exe Directory | C:/VulkanSDK/<IP_ADDRESS>/Bin
Current Directory | C:/Users/...
App Version | Version 1.3
Vulkan API Version | 1.3.250
Byte Format | 64-bit

Vulkan Runtimes
Runtimes In Registry | SOFTWARE/Microsoft/Windows/CurrentVersion/Uninstall |
  | [0] | <IP_ADDRESS>  [Install Count = 1]
Runtimes in System Folder | C:/WINDOWS/system32/ |
DLL 0 | vulkan-1-1-0-65-1.dll | Version <IP_ADDRESS>.
DLL 1 | vulkan-1-999-0-0-0.dll | Version <IP_ADDRESS>.
DLL 2 | vulkan-1.dll | Version <IP_ADDRESS>.
Runtime Used by App | C:/Windows/System32/vulkan-1.dll | <IP_ADDRESS>.

Full Error output:
Starting demo application. loading window...  Yes, we have validation Layer support!!! Unhandled exception. Silk.NET.Core.Loader.SymbolLoadingException: Native symbol not found (Symbol: vkCreateDebugUtilsMessengerEXT)    at Silk.NET.Core.Contexts.LamdaNativeContext.<GetProcAddress>g__Throw|4_0(String proc)    at Silk.NET.Core.Contexts.LamdaNativeContext.GetProcAddress(String proc, Nullable1 slot)
at Silk.NET.Vulkan.Extensions.EXT.ExtDebugUtils._B.get__KJM()
at Silk.NET.Vulkan.Extensions.EXT.ExtDebugUtils.CreateDebugUtilsMessenger(Instance instance, DebugUtilsMessengerCreateInfoEXT& pCreateInfo, AllocationCallbacks* pAllocator, DebugUtilsMessengerEXT& pMessenger)
at VulkanStuff.VulkanModule.setupDebugMessenger(VulkanState state) in C:...\VulkanSetup-IntoFunctional\refactored.fs:line 265
The vulkan instance created without a problem. I can also pick a phyiscal device and create the logical device without a problem.
Vulkan setup as:
EDIT:
Theseare my used packages.
"Silk.NET.Core" Version="2.18.0"
"Silk.NET.GLFW" Version="2.18.0"
"Silk.NET.Input" Version="2.18.0"
"Silk.NET.Input.Glfw" Version="2.18.0"
"Silk.NET.Maths" Version="2.18.0"
"Silk.NET.Vulkan" Version="2.18.0"
"Silk.NET.Vulkan.Extensions.EXT" Version="2.18.0"
"Silk.NET.Vulkan.Extensions.KHR" Version="2.18.0"
"Silk.NET.Windowing" Version="2.18.0"
"Silk.NET.Windowing.Glfw" Version="2.18.0"
vulkaninfoSDK Outut
Vulkan Instance Version: 1.3.241
Instance Extensions: count = 15
    VK_EXT_debug_report                    : extension revision 10
    VK_EXT_debug_utils                     : extension revision 2
    VK_EXT_swapchain_colorspace            : extension revision 4
    VK_KHR_device_group_creation           : extension revision 1
    VK_KHR_external_fence_capabilities     : extension revision 1
    VK_KHR_external_memory_capabilities    : extension revision 1
    VK_KHR_external_semaphore_capabilities : extension revision 1
    VK_KHR_get_physical_device_properties2 : extension revision 2
    VK_KHR_get_surface_capabilities2       : extension revision 1
    VK_KHR_portability_enumeration         : extension revision 1
    VK_KHR_surface                         : extension revision 25
    VK_KHR_surface_protected_capabilities  : extension revision 1
    VK_KHR_win32_surface                   : extension revision 6
    VK_LUNARG_direct_driver_loading        : extension revision 1
    VK_NV_external_memory_capabilities     : extension revision 1

Layers: count = 15
PS:
I just rebuild the c++ version from vulkan-tutorial c++

        let setupDebugMessenger (state: VulkanState): InitResult<VulkanState> = // (debugMessenger: DebugUtilsMessengerEXT byref)
            match state.enableValidationLayers with
            | true ->

                let mutable createInfo = createPopulateDebugMessengerCreateInfo

                let mutable debugUtils: ExtDebugUtils = Unchecked.defaultof<ExtDebugUtils>
                let mutable debugMessenger: DebugUtilsMessengerEXT = Unchecked.defaultof<DebugUtilsMessengerEXT>

                match (optionValueVkFromVulkanState state).TryGetInstanceExtension(state.instance, &debugUtils) with
                    | true ->   match debugUtils.CreateDebugUtilsMessenger(state.instance, &createInfo, NativeInterop.NativePtr.nullPtr, &state.debugMessenger) with
                                | Result.Success ->  Success { state with debugMessenger = debugMessenger }
                                | _ ->  Failure "Failed to set up debug messenger - couldn't create CreateDebugUtilsMessenger!"
                    | false -> Failure "Failed to set up debug messenger - couldnt get debugUtils extension!"

            | false -> Success state // nothing to do

Have you enabled the extension when creating your instance?
Also, manually using validation layers is not recommended anymore, the new industry-preferred way of using validation layers is the vkconfig tool that comes with the Vulkan SDK - this allows you to inject layers without changing code.

Working with the vkconfig works just like a charm and i will ditch my codebase for setting this up on my own.
Thank you for your quick response!
For future ppl who will run into a similiar error: I think my codebase where i setup the debug utils ist just wrong at some point. I think a pointer was just not in the right spot or had the right type.


ALM-743 Fallback to generated uuidv4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 98.883%

Files with Coverage Reduction
New Missed Lines
%

lib/config/index.js
1
94.87%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
110

Relevant Lines:
111

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.1%) to 98.883%

Files with Coverage Reduction
New Missed Lines
%

lib/config/index.js
1
94.87%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
110

Relevant Lines:
111

💛  - Coveralls


GH729: Add support for NUnit Output Format

Adding support for NUnit report for XUnit2 Runner and created associated
tests.

@phillipsj rebased and merged here: https://github.com/cake-build/cake/commit/66e02584db82f48b617f8a864cbaaefbf28ea5f1 Thank you for your contribution!


Have mute and fullscreen change listener?

Have mute and fullscreen change listener?

Mute and fullscreen listeners will depend on the player library that is being used. There is not enough support across the libraries (I’m not sure any of them even have listeners?) to add support for this to ReactPlayer.


Point IREE submodule to IREE instead of SHARK-Runtime

mmperf uses SHARK-Runtime (a fork of IREE) as its IREE submodule. This PR modifies the IREE submodule to point to IREE proper and checks out the same SHA used by the workflow.

Wait that was a "approved, but please fix these things". Right now this isn't actually checking out the IREE commit it fetches. It will just always be testing whatever version of IREE is in the docker container

Sorry I didn't see the new comments. I'll create a new PR with the changes.


[Suggestion] Adding a rotation option for line mode

Objects like NoParkingStripingDecal02 will be lined in the wrong direction in the current version, it's hard to know which direction players want to line objects, so please add an option for it.

Implemented in the full Line Tool.


I solved the jquery not working in chrome issue

The following steps will fix the issue:

open a command prompt
cd to the directory with chrome.exe, it was (C:\Program Files (x86)\Google\Chrome\Application) for me
run the following command: .\chrome.exe --allow-file-access-from-files
restart all instances of chrome
run the html file that uses jquery and it will work!

The only issue is you will have to do this every time you restart your computer.... so I suggest we just use Chrome

http://stackoverflow.com/questions/10752055/cross-origin-requests-are-only-supported-for-http-error-when-loading-a-local
That link explains what the issue is (we are running the jquery from our file system and not a web server)

Yeah that makes a lot more sense now.


About Dockerfile from Hands on Lab Tutorial

Thanks for the hands-on lab. It is very helpful.
https://github.com/oracle/weblogic-kubernetes-operator/tree/master/kubernetes/hands-on-lab
Can you share the Dockerfile of  "iad.ocir.io/weblogick8s/weblogic-operator-tutorial-store:1.0"?
It would be helpful that we can understand how we add artefacts.
Thank you

The related Dockerfile can be found on
https://github.com/nagypeter/weblogic-operator-tutorial/blob/master/Dockerfile.create
https://github.com/nagypeter/weblogic-operator-tutorial/tree/master/scripts


Cuda 12.1 - Fails to Build Here

exllama/exllama_ext/q4v2_matmul.cu(116): error: no instance of overloaded function "atomicAdd" matches the argument list
            argument types are: (half *, half)
      atomicAdd(out_.item_ptr(x_row, w_column), result);

Are you sure you're on CUDA 12.1? Half-precision atomicAdd is supported by compute 7.x and up.
What output do you get from nvcc --version?

Ah, my 1080ti may be too old to use it? I'm moderately new to this...
Was going to compare this to oobabooga with the current standard llama...with Wizard-Vicuna-13B-Uncensored-GPTQ and my 1080ti I'm getting around 16-17 tokens/s.

Well, that version of nvcc should work, but Torch will still compile the extension for the compute capability of detected cards. And it looks like the 1080-Ti only supports compute 6.1, so it won't work with FP16.
At some point I do plan to add support for older hardware, but I'm not sure when I'll get to it.

I've run into a similar issue with a different repo on my Pascal based Tesla P40 cards, which also have SM6.1. ( https://github.com/oobabooga/text-generation-webui/issues/1884#issuecomment-1541051291 )
The problem there was also the atomic add instruction for FP16.
The maintainer fixed it in the following commit: https://github.com/iwalton3/GPTQ-for-LLaMa/commit/59b71733af0f14ba9f3a7a81eb4e08a2cc772264
I'm not great with cpp / Cuda but with minimal changes this same code seems to make this project work on older cards as well. All code credit goes to @iwalton3
Added the following code to the top of exllama_ext/q4v2_matmul.cu (probably the wrong place but I just added it to the file that produced the error)
#ifdef __CUDA_ARCH__
#if __CUDA_ARCH__ < 700
__device__ __forceinline__ void atomicAdd(half* address, half val) {
    unsigned int * address_as_ui =
      (unsigned int *) ((char *)address - ((size_t)address & 2));
    unsigned int old = *address_as_ui;
    unsigned int assumed;

  do {
    assumed = old;
    __half_raw hsum;
    hsum.x = (size_t)address & 2 ? (old >> 16) : (old & 0xffff);
    half tmpres = __hadd(hsum, val);
    hsum = __half_raw(tmpres);
    old = (size_t)address & 2 ? (old & 0xffff) | (hsum.x << 16) : (old & 0xffff0000) | hsum.x;
    old = atomicCAS(address_as_ui, assumed, old);
   } while (assumed != old);
}
#endif
#endif

Thanks! I pushed an update.
It's in a separate header and I refactored so I could test it on my 4090, though I still can't say if it will compile on a 1080 or if there are other compatibility issues. At least I can say it's doing a correct atomic addition.
I've also only optimized for newer GPUs with way more cores and cache, so no idea what the performance will be like if it does work. At some point I do plan to test on and optimize for some older GPUs but I'm all out of PCIe slots right now. ;)

It seems to work on my setup (also Cuda 12.1) so hopefully it also solves it for @ilikenwf !
As for the performance, it seems to be about the same, maybe a bit slower than the Cuda branch of GPTQ, though this is mainly because I'm heavily single-core CPU bound + as you said, probably don't benefit much from improvements aimed at newer GPU architectures either.
I could open a new issue on the CPU-bottleneck problem if you feel like looking into it, though the same thing happens with every other LLaMA code-base as well.

Yeah, there's definitely a CPU bottleneck, most likely due to Python being quite slow, and due to Torch not actually being that efficient with small tensors. It looks like it trades a lot of overhead for the ability to deal efficiently with very large matmuls as you'd mostly encounter in training, but then during generation the hidden state ends up being a single row vector and the overhead per operation starts to matter.
I haven't actually profiled it to make sure, but if it's correct then the solution is to fuse more operations together, which I'm already working on.

I've tried a few random things before (mostly torch ENV variables) but couldn't really track down the issue, glad you got some ideas for it!

This does appear to build and run now!

-- Loading model
 -- Tokenizer: ../text-generation-webui/models/TheBloke_Wizard-Vicuna-13B-Uncensored-GPTQ/tokenizer.model
 -- Model config: ../text-generation-webui/models/TheBloke_Wizard-Vicuna-13B-Uncensored-GPTQ/config.json
 -- Model: ../text-generation-webui/models/TheBloke_Wizard-Vicuna-13B-Uncensored-GPTQ/Wizard-Vicuna-13B-Uncensored-GPTQ-4bit-128g.compat.no-act-order.safetensors
 -- Sequence length: 2048
 -- Options: ['attention: pytorch_scaled_dp', 'matmul: switched']
 ** Time, Load model: 12.58 seconds
 -- Groupsize (inferred): 128
 -- Act-order (inferred): no
 ** VRAM, Model: [cuda:0] 6,996.23 MB

Chatbot throws an error, lol...

exllama/cuda_ext.py", line 211, in llama_rms_norm
    rms_norm(x, w, output, scratch, epsilon)
RuntimeError: w must be a half tensor

Yes, I've not had time to test it with every GPTQ model out there, and there are some that use different datatypes in places because the format has been changing so much. A big part of the motivation for this project is to create something a little more stable to build on, after I got fed up with the constant, breaking changes to GPTQ-for-LLaMa. :)
Anyway, I'll have a look at that particular conversion of Vicuna later today, but in the meantime you could try changing line 386 of model.py from this:
    self.weight = tensors[key]

To this:
    self.weight = tensors[key].half()

Which should force all layer norm weights to the correct datatype.

@turboderp I cannot build the exllama cuda code for Pascal GPUs (Compute capability 6.0/6.2) because it cannot distinguish the half2 overload. Do you know a solution for this?
FAILED: /home/user/exllama/build/temp.linux-x86_64-cpython-311/exllama_ext/cuda_func/q4v2_matmul.o
/opt/cuda/bin/nvcc  -I/home/user/exllama/venv/lib/python3.11/site-packages/torch/include -I/home/user/exllama/venv/lib/python3.11/site-packages/torch/include/torch/csrc/api/include -I/home/user/exllama/venv/lib/python3.11/site-packages/torch/include/TH -I/home/user/exllama/venv/lib/p
ython3.11/site-packages/torch/include/THC -I/opt/cuda/include -I/home/user/exllama/venv/include -I/usr/include/python3.11 -c -c /home/user/exllama/exllama_ext/cuda_func/q4v2_matmul.cu -o /home/user/exllama/build/temp.linux-x86_64-cpython-311/exllama_ext/cuda_func/q4v2_matmul.o -D__CU
DA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options ''"'"'-fPIC'"'"'' -O3 -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"'
'-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=exllama_ext -D_GLIBCXX_USE_CXX11_ABI=0 -gencode=arch=compute_60,code=sm_60 -gencode=arch=compute_61,code=sm_61 -gencode=arch=compute_86,code=compute_86 -gencode=arch=compute_86,code=sm_86 -std=c++17
/home/user/exllama/exllama_ext/cuda_func/../cuda_compat.cuh(48): error: cannot overload functions distinguished by return type alone
  __attribute__((device)) __inline__ __attribute__((always_inline)) void atomicAdd(half2* address, half2 val) { atomicAdd_half2(address, val); }

Python 3.11, CUDA 12.1

I need to do a little bit more research to figure out exactly what's supported on the various, many compute versions. But for now, you can try changing the line:
#if __CUDA_ARCH__ < 700

To something else, like:
#if CUDA_ARCH < 600
In exllama_ext/cuda_compat.cuh.

I'm confused. So it provides atomicAdd() for half2 but not for half?

No, my guess is it can't distinguish between half and half2, so the compiler can't overload the function like you did here. I got it to work by replacing the calls to atomicAdd with explicit atomicAdd_half and half2 calls. Not yet sure why this is happening.

Hey there, glad to see others face the same problem. Adding .half() into model line 386 didn't help(i found it on line 240), but adding the following two things helped:

I need to do a little bit more research to figure out exactly what's supported on the various, many compute versions. But for now, you can try changing the line:
#if __CUDA_ARCH__ < 700

To something else, like:
#if CUDA_ARCH < 600
In exllama_ext/cuda_compat.cuh.

And this one:

I've run into a similar issue with a different repo on my Pascal based Tesla P40 cards, which also have SM_61. ( oobabooga/text-generation-webui#1884 (comment) ) The problem there was also the atomic add instruction for FP16.
The maintainer fixed it in the following commit: iwalton3/GPTQ-for-LLaMa@59b7173
I'm not great with cpp / Cuda but with minimal changes this same code seems to make this project work on older cards as well. All code credit goes to @iwalton3
Added the following code to the top of exllama_ext/q4v2_matmul.cu (probably the wrong place but I just added it to the file that produced the error)
#ifdef __CUDA_ARCH__
#if __CUDA_ARCH__ < 700
__device__ __forceinline__ void atomicAdd(half* address, half val) {
    unsigned int * address_as_ui =
      (unsigned int *) ((char *)address - ((size_t)address & 2));
    unsigned int old = *address_as_ui;
    unsigned int assumed;

  do {
    assumed = old;
    __half_raw hsum;
    hsum.x = (size_t)address & 2 ? (old >> 16) : (old & 0xffff);
    half tmpres = __hadd(hsum, val);
    hsum = __half_raw(tmpres);
    old = (size_t)address & 2 ? (old & 0xffff) | (hsum.x << 16) : (old & 0xffff0000) | hsum.x;
    old = atomicCAS(address_as_ui, assumed, old);
   } while (assumed != old);
}
#endif
#endif

I have a 1080ti and a 3080ti, but this seems to be only running on the 3080ti, but maybe it gets confused with the 1080ti in the system. I wonder if i can force it to run on 1080ti? I also played around with the driver before so that could also cause an issue but other programs like llama.ccp with cublas worked without a problem.

I've added a new option so you can run it without using half2s anywhere. I'm not sure if that helps on the 1080, but you can try -nh2 to see what happens. It might still give compilation errors, but it shouldn't care if you replace atomicAdd_half2 with a dummy function. Something to experiment with, at least, idk. :)

I managed to work around the compile issue like this. Not a real fix, but it works for now.

Yep, the same -gencode=arch=compute_61,code=sm_61 -gencode=arch=compute_86,code=compute_86 -gencode=arch=compute_86,code=sm_86

In my case setting CUDA_VISIBLE_DEVICES to not show Pascal worked.

I don't know what to make of that, but it clearly thinks is still needs to generate code for Pascal. Maybe it suggests there's something up with your env that could also help to explain the half2 stuff?

I will go through the code sooner or later any try to figure it out. If others have no problem, it's probably my env messed up. For the meantime I will just unplug my pascal card.

I'll consider this resolved for now, just to get some issues closed, but feel free to reopen if necessary.


Introduce Split curve

Split is a curve that progresses according to beginCurve until split, then according to endCurve.
This curve is used with bottom sheets to allow linear finger dragging and non-linear enter/exit animations. This PR cleans up a previously private class I introduced and replaces it with the more customisable Split.
Fixes https://github.com/flutter/flutter/issues/51627
Diagram to be added with https://github.com/flutter/assets-for-api-docs/pull/239
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

In google3, there are only 2 instances of an existing Split class, both in third_party:

In the DevTools app
In a codelab example

So I'm leaning towards keeping this simple name, which matches the naming convention of all other curves.

In google3, there are only 2 instances of an existing Split class, both in third_party:

In the DevTools app
In a codelab example

So I'm leaning towards keeping this simple name, which matches the naming convention of all other curves.

Sorry, reviewed prematurely: I didn't realize this was still in Draft mode.  Did you have more to add here?

Sorry, reviewed prematurely: I didn't realize this was still in Draft mode. Did you have more to add here?

Thanks! No, I will just have it drafted until I update conflicting class names elsewhere.


Respect files.refactoring.autoSave for move to file

Type: Bug
With files.refactoring.autoSave: true (the default), files should be saved automatically after a cross file refactoring is performed
This currently doesn't seem to happen, which causes all changed files to be opened as editor tabs
Extension version: 2023.23.13391009
VS Code version: Code - Insiders 1.85.0-insider (Universal) (af28b32d7e553898b2a91af498b1fb666fdebe0c, 2023-12-06T11:18:22.866Z)
OS version: Darwin arm64 23.1.0
Modes:

System Info

Item
Value

CPUs
Apple M2 Max (12 x 24)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: unavailable_software

Load (avg)
3, 3, 3

Memory (System)
64.00GB (6.08GB free)

Process Argv
--crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda

Screen Reader
no

VM
0%

I'm unable to repro this. Can you provide repro steps?
Also, it's not clear to me how this would be caused by a language server. We're not involved with saving files as far as I know.

There's an isRefactoring option that you should set on workspace edits: https://github.com/microsoft/vscode/blob/d5307c5afa4d00360308af47146311e652e4f5ee/src/vscode-dts/vscode.d.ts#L3888
Simple repo:
def foo():
    pass

def bar():
    pass

Run move symbol to new file on either def

:bug:
Unsaved files are opened

It's not currently possible to set isRefactoring to true from LSP. I submitted a PR for that though -- https://github.com/microsoft/vscode-languageserver-node/pull/1390

vscode-languageserver-node change has been merged. Waiting on a new release.

This issue has been fixed in prerelease version 2024.3.101, which we've just released. You can find the changelog here: CHANGELOG.md


Your 1.5B model

Seeing as open AI released theirs, and those other researchers did prior. I would like to see yours for research and comparison. Thank you.

Yea sorry I forgot about this. It is now downloadable.

Ty brother


revert package source update

Revert the package source update since it didn't make any difference on the official build.

test failure not related to change


Hidden no download

I Log me in With the Authentification. Sry for Bad English.
but the Loader dont load any Pics of this URL.

Two things:

could you retry the download with the newest release? I've silently updated it three days ago because someone else posted the same on my website, and if you've downloaded TumblThree earlier or somewhere else, it might already have been fixed.
Please post the blogs url otherwise I cannot fix it if it's still broken.

Have download past 3 hours Version <IP_ADDRESS> the newest
Am 29.09.2017 09:04 schrieb Johannes Meyer zum Alten Borgloh<EMAIL_ADDRESS>Two things:

could you retry the download with the newest releasehttps://github.com/johanneszab/TumblThree/releases/download/v<IP_ADDRESS>/TumblThree-v<IP_ADDRESS>.zip? I've silently updated it three days ago because someone else posted the same on my websitehttps://www.jzab.de/comment/3907#comment-3907, and if you've downloaded TumblThree earlier or somewhere else, it might already have been fixed.
Please post the blogs url otherwise I cannot fix it if it's still broken.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/johanneszab/TumblThree/issues/145#issuecomment-333047950, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APn0wAtHH4aSQF63rqTYBEILqjc-lP6xks5snJZwgaJpZM4PoQjf.

Können auch Deutsch reden wenn du Deutsch kannst laut deinem Namen :d

You didn't answer my second point. I still need the url/name of the blog, otherwise I cannot reproduce the error. If I cannot reproduce the error, I cannot fix the code, thus having created this issue is kinda senseless.
I don't even have time to keep up with the development and fixing the all the issues that stack up here. Thus I certainly won't start now and download several hundreds of blogs to check if the code indeed does not work for downloading all of the hidden tumblrs since I'm sure TumblThree does indeed download (some) hidden blogs.
In essence, always state what exactly you did to trigger the issue.

https://illegalbeautyus.tumblr.com/
Can it be that the user is deleted or all is deleted ?

app do now if i add with clipboard 3 or more posts, no reactions and quit

Kakashi82, this is not a hidden blog, but an offline (deleted) blog, which means that it's impossible to download anything from it. In new versions they are for some reason called hidden and they are not marked in red, this probably led you astray.

Ah ok I understand
Am 02.10.2017 08:20 schrieb Taranchuk<EMAIL_ADDRESS>Kakashi82, this is not a hidden blog, but an offline (deleted) blog, which means that it's impossible to download anything from it. In new versions they are for some reason called hidden and they are not marked in red, this probably led you astray.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/johanneszab/TumblThree/issues/145#issuecomment-333449522, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APn0wHVHHrxzG7YXBOPLI5In85gf415Fks5soIDHgaJpZM4PoQjf.


Build is failing

When forking the repository and adding it to Travis, building the master does not succeed. It fails with
$ sudo apt-get --force-yes -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=17.05.0~ce-0~ubuntu-trusty
E: Unable to correct problems, you have held broken packages.
The command "sudo apt-get --force-yes -qqy -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install docker-engine=17.05.0~ce-0~ubuntu-trusty" failed and exited with 100 during .

Dear All,
I have tried the fix build process (#320) on ubuntu 16.04 using ( Docker version 18.06.0-ce, build 0ffa825 and docker-compose version 1.23.1, build b02f1306) and on ubuntu 18.04 with latest docker and compose version but at the end same error
vue_unit_test_1_e19e091a3846 | npm ERR! code ELIFECYCLE
vue_unit_test_1_e19e091a3846 | npm ERR! errno 1
vue_unit_test_1_e19e091a3846 | npm ERR<EMAIL_ADDRESS>unit:test: NODE_PATH=src nyc ava
vue_unit_test_1_e19e091a3846 | npm ERR! Exit status 1
vue_unit_test_1_e19e091a3846 | npm ERR!
vue_unit_test_1_e19e091a3846 | npm ERR! Failed at the<EMAIL_ADDRESS>unit:test script.
vue_unit_test_1_e19e091a3846 | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
vue_unit_test_1_e19e091a3846 |
vue_unit_test_1_e19e091a3846 | npm ERR! A complete log of this run can be found in:
vue_unit_test_1_e19e091a3846 | npm ERR! /root/.npm/_logs/2019-12-10T07_31_10_443Z-debug.log
vue_unit_test_1_e19e091a3846 |
vue_unit_test_1_e19e091a3846 | ><EMAIL_ADDRESS>unit:coverage /app
vue_unit_test_1_e19e091a3846 | > nyc report --reporter=html
vue_unit_test_1_e19e091a3846 |
concept-to-clinic-master_vue_unit_test_1_e19e091a3846 exited with code 0
Can anyone guide me where i am wrong please.


Drop max_length from deconstruct() and remove CharField

makemigrations checks new_field.deconstruct() and old_field.deconstruct()  to determine if a change needs to be made. These are showing up different no matter how many makemigrations are done.
master of django-cryptographic-fields makes assumptions about the max_length and updates based on the encryption. However, the underlying encryptor can take arbitrary length so a max_length is really just for front end validation.
dropping 'max_length' from the deconstruct() kwargs fixes this issue. However, I do not know how this impacts the charfield.
No field should really be a char field, in postgres a textfield has the same performance so the only real difference is performance when searching but these can't be searched.

Note that this should address issue #11

Also, note that this would obsolete issue #1

Any update on merging this?

@mrname no update yet but we are working to get this merged.

@mrname merged into master


Make profile page responsive

Currently the profile page doesn't adapt correctly to the size of the content in the cards. We should make this responsive using Bootstrap.

I am working on it right now. I just created a new branch and plan on committing my updated profile page/css.

Just fixed the sizes of the cards so that they can hold all of our information

Finished improving the layout of the profile page to adapt with the new map.


remove multiplex enabled from db

FRONTEND PULL REQUEST
Related Issue

Resolves #6348

Changes Proposed

Delete multiplexEnabled row in the DB

Additional Information

The last two commits are the only changes in this PR. The other changes are just from the previous PRs related to #6348 for frontend and backend
https://github.com/CDCgov/prime-simplereport/pull/6606/files/712673dbf1cb7dfc49e971a83c16bca2dacb0769..8cd5ecbca2cfeca64cfd507dece417123234f745

Testing

Screenshots / Demos

LGTM! can we split backend and frontend changes? that way there wont be a chance for multiplex to be turned off for people who are still using the old frontend.

looking at commit history, looks like you already did that, not sure why github is showing frontend and backend changes in the diff still


Is the nixos/gui folder still alive?

It looks like it hasn't been touched in over a year

I think you should use nixui now: https://github.com/matejc/nixui
On Feb 6, 2015 10:47 PM, "Daniel Peebles"<EMAIL_ADDRESS>wrote:

It looks like it hasn't been touched in over a year
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/6207.

No this was an early attempt that I made while we were still using the svn repository.  It depends on an old version of xulrunner, and as we did not had any JSON output at the time, I made it such that it parse the xml output of nixos-option (which was made for it).
It used to worked, but I failed at communicating about it:
http://old.nabble.com/NixOS%3A-Graphical-User-Interface-td31467386.html
http://nbp.name/img/nixos-gui.png

I see. TBC, I'm asking more from the angle of "is this dead code in the repo that we could remove" than "what should I do instead"?

Yes, this is dead code.
And if you don't mind I will remove it ;)

:+1:

:+1:

Done

Thanks!


WA - Incorrect Specimen Collection Date

Describe the bug
23d1852c-cc3f-4b78-8ac3-76ab7de9b44b
Specimen collection date is in 2021 but we received the result on 2/10/2022.
f8fcfb1c-9633-4b14-9233-ed394d095f8b
Specimen collection date is in 2020 but we received the result on 1/15/2022.
Can you review these results and confirm the specimen collection dates? If the specimen collection dates on these are incorrect, please have the facilities send the corrected results.

It appears these dates were entered intentionally by the user. The following dates/times were provided by Metabase.
23d1852c-cc3f-4b78-8ac3-76ab7de9b44b
created at February 10, 2022, 5:37 PM
backtested to January 31, 2021, 5:37 PM
https://prime-simple-report-prod-metabase.azurewebsites.net/question#eyJkYXRhc2V0X3F1ZXJ5Ijp7ImRhdGFiYXNlIj[…]Zpc3VhbGl6YXRpb25fc2V0dGluZ3MiOnt9fQ==
f8fcfb1c-9633-4b14-9233-ed394d095f8b
created at January 14, 2022, 7:58 PM
backtested to January 10, 2020, 7:57 PM
https://prime-simple-report-prod-metabase.azurewebsites.net/question#eyJkYXRhc2V0X3F1ZXJ5Ijp7InR5cGUiOiJxdW[…]Zpc3VhbGl6YXRpb25fc2V0dGluZ3MiOnt9fQ==
During the WA/USDS Check in (ReportStream/SimpleReport) Meeting on 9 MAY 2022 Washington requested that SimpleReport follow up with the facilities in question to verify that the dates were entered intentionally.

SR team will follow up with user to confirm intent of the date updates
cc: @jayna-SkylightDigital
Closing in RS queue

Test result ID: f8fcfb1c-9633-4b14-9233-ed394d095f8b
Created at January 14, 2022, 7:58 PM
Back-dated to January 10, 2020, 7:57 PM
Tue, May 17, 2022 at 2:08 PM: Email sent to Larson, Charissa<EMAIL_ADDRESS>Tue 5/17/2022 5:16 PM: Response received from Larson, Charissa<EMAIL_ADDRESS>
Yes, that was a mistake. The true date should have been January 10th 2022.
Thank you

--
Test result ID: 3ada02ce-daff-4023-a555-1fe4d94f6012
Created at February 11, 2022
Back-dated to January 18, 2021
Mon 5/23/2022 5:26 PM: Email sent to Ben Swartsel<EMAIL_ADDRESS>Tue 5/24/2022 9:55 AM: Response received from Ben Swartsel<EMAIL_ADDRESS>
Thank you for your attention in this matter.  Please change the year on this entry to 2022.  Have a  great day.
Ben Swartsel, Rn
School Nurse
Paschal Sherman Indian School
509-422-7704

--
Test result ID: 23d1852c-cc3f-4b78-8ac3-76ab7de9b44b
Created at February 10, 2022, 5:37 PM
Back-dated to January 31, 2021, 5:37 PM
Tue 5/17/2022 5:07 PM: Email sent to Madelynn Wheeler<EMAIL_ADDRESS>Tue 5/17/2022 6:01 PM:  Response received from Madelynn Wheeler<EMAIL_ADDRESS>
Hi,
That was actually a test result for myself that I was back entering, the date I tested positive was 12/31/2021. I've just gone back in and fixed it.
-Maddie Wheeler

--
Thu 5/26/2022 3:24 PM: Request for correction was sent via email on May 26, 2022 to: Charissa Larson, Ben Swartsel, & Madelynn Wheeler.
Content of email is below.

Caroline Thomas at the Washington Department of Health has requested that you resend the result for test ID: f8fcfb1c-9633-4b14-9233-ed394d095f8b with the corrected date.
You can find instructions on how to correct a previous test result here:
https://www.simplereport.gov/using-simplereport/manage-results/correct-a-previous-test-result/
If you have additional questions, please reach out to Caroline Thomas<EMAIL_ADDRESS>
--
A ticket has been added to the SimpleReport backlog to alert users if attempting to add a backdate more than 6 months in the past.
Conduct Test: Add warning when user attempts to back-date more than 6 months
https://app.zenhub.com/workspaces/simplereport-growth--engagement-605b43a6ceb92c000f86279a/issues/cdcgov/prime-simplereport/3792


Tidal album saved as Favorite, not able to start it via MQTT

Hello,
I am facing the issue, that I have saved a lot of albums in the Sonos App linked with Tidal, so the entries are in the Favorites section in the Sonos App listed under „Albums“.
Unfortunately I am not able to get the Albums URI to convince my Sonos play to start the playing, I am always getting some reply like:
{"command":"setavtransporturi","error":{"Action":"SetAVTransportURI","FaultCode":"s:Client","Fault":"UPnPError","UpnpErrorCode":714,"UpnpErrorDescription":"Illegal MIME-Type","name":"SonosError"}}
Has anybody succeeded to start a linked Tidal album?
I have tried this one out of the Favorites-listing: x-rincon-cpcontainer:1004206calbum%2f97375617?sid=174&flags=8300&sn=2
Thanks for your support.

To be able so support Tidal, I need an account. Anyone wants support for Tidal, sponsor me some amount enough to buy a subscription and send me a message.

Give me a PM with details of PayPal.

Is tidal similar to Spotify? Or do you only have radio stations?
And can you describe exactly what you want to do?

start single track / add track to queue
start tidal playlist on Sonos
start stream station (no playback control), is this available?

You can just sponsor me through Github


Fix some private and public variables

I don't believe python has true "private" variables, the standard is to prepend dangerous variables with and underscore to signal it is not meant to be publicly accessed. I believe you have seen this aswell, from looking at the code, closing.


Make several tweaks to get the project to compile and run on windows (Visual Studio 15)

Hello Benny,
I have tried to compile and run this new project on my windows system and have encountered a few problems, so I figured I might as well volunteer to solve the problems, so I went ahead and did that, and here is the detailed explanation of every change in this contribution:

I had a problem related to the default directory structure of SDL2: When I installed SDL2 on my systemn, the default structure  was something like %SDL2_ROOT_DIR%/include/*.h. I need to move everything under %SDL2_ROOT_DIR%/include/SDL2/*.h for everything to work smoothly. I thought it may help someone so I went ahead and added a warning about that in the README.

I moved the initialisation of static const floats in genericMath.cpp file rather than having them in the hpp file, which would not let me compile. (https://stackoverflow.com/a/2454082/3909725)

Under indexedModel.cpp in the createVertexArray method, some element of the elements Array was empty, which made the program crash at runtime. I added an if statement to eliminate those empty elements. I don't know if that was the right solution to the problem, but hey, at least it made it work.

__attribute__ ((always_inline)) does not work and results in horrible unreadable compilation errors under MSVC, I added a small test to only set FORCEINLINE to this macro on GNU based systems, and just default to simple inline on all other cases.

I could not get the program to compile with the "normal" main prototype on my windows machine; seemed like the only way to get it to work was by replacing main with wmain. I added a snippet of preprocessor code to choose the proper declaration at compile time. I know it's kind of a hack, but I couldn't find a better way to get it to work, and at least it's generic.

In genericMemory.hpp, the memswap function used  to declare a  char temp_data[size] which would not compile on my system because the size argument is dynamic and only known at runtime. I replaced the temp_data array with a dynamic array which is destroyed at the end of the function call.

The swizzle method in sseVecmath.hpp would not compile on my system, with the compiler raising a "C20557: expected constant expression" error. Since the method is not used for the moment and since I could not figure out the reason for this error, I just commented it for the moment, hoping that you would know how to solve the issue :)

With these few tweaks, I was able to run the project using MSVC and Visual Studio Community 15 2017.
I hope I have not broken anything for the other environments/platforms, and I hope you'll be able to integrate my fixes to the project.
Please feel free to tell me if anything looks off or needs to be changed around a bit before integrating to the project.
Sincerely,

Hey Thundzz, thanks for the pull request! It's much appreciated. You've discovered a lot of good things here.
That said, I've elected to fix these issues (except one!) slightly differently than how you've proposed, so the changes are in a new commit rather than a pull request merge.
Most importantly, note that I did NOT implement the wmain change because while that may work and it's good to know that works, it's almost certainly the wrong solution to whatever issue you had. I'd appreciate it if you could try running this again and tell me more about the issue with the regular main method, the more details, the better.
As for my alternate solutions, here's specifically what I've done:

SDL2 Includes: Although I think it's rather strange that SDL2 didn't put it's includes in the SDL2 directory, I added the note to the readme anyways. Good catch!

Generic Math Constants: This is the second time someone's had an issue with the way I did the GenericMath constants, so I've simply taken them out and replaced them with macros. Much simpler, much fewer places for something to go wrong.

createVertexArray: Turns out, this was the result of a subtle bug in the way I implemented that method. It was only supposed to iterate through the loop once for each vertex element, not once for every element in the array (because that array includes both vertex elements AND elements of instanced data, hence the "0" issue because I hadn't specifed any instanced data but the empty array was still there). All fixed, shouldn't cause any more issues.

FORCEINLINE: Good catch! This is actually something I'd meant to do, but had forgotten about. On windows, there is a keyword for this, __forceinline, so I've taken your solution and used that instead to still get the proper effect.

GenericMemory Swap: Another good catch, but since I'd prefer not to needlessly allocate and deallocate memory in such a simple helper method, I opted to fix this a little differently and swap one element at a time for larger arrays. That way no dynamic memory allocation is needed.

Vector Swizzle: Another good catch on the swizzle method! That method is something I'd done early on before I realized that SSE intrinsics won't let you wrap swizzling in a method. I was instead using macros (which you can see at the top of the file), but had forgotten to remove the original method (hence why it wasn't used anywhere). It's now gone, thanks for pointing it out!

Thanks again for all your help, I very much appreciate all of this! If you're willing, I'd appreciate it if you could try the new version and see if this works for you. I suspect whatever issue can be dodged by using wmain is still there, but hopefully everything else should be fixed.

Hello Benny,
I'm happy that you found my contribution useful! The ways you decided to fix the problems I addressed in my pull request are indeed more elegant than the way I suggested!
I have checked out the new code and it seems that your changes mostly fix the problems I had.
There is still a small issue with the platform detection and FORCEINLINE thing. The OPERATING_SYSTEM_WINDOWS macro defined (or not defined) in platform.hpp is used in common/common.hpp to decide which keyword to use for FORCEINLINE. But since platform/platform.hpp is not included in common/common.hpp the macro is never defined, and the linux version is always used.
In common/common.hpp, I just added the following to fix the problem:
#include "platform/platform.hpp"

The "main function" saga
As for the main thing, as you suspected the problem is still there. The original error I get when compiling is this:

Severity
Code
Description
Project
File
Line
Suppression State

Error
LNK2019
unresolved external symbol _main referenced in function "int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ)
CGFX5
C:\Users\thundzz\Desktop\CGFX5\build\MSVCRTD.lib(exe_main.obj)
1

It seemed like the root cause of this problem is related to the redinition of the main function in the SDL library. Apparently, SDL redefines the main function, wrapping the one we provide inside of another function that does some initializing and redirecting of the standard buffers.
The first (quite hackish solution) is to simply short-circuit the SDL2main library and  all of its redefinitions by adding the following in the main.cpp file:
#ifdef main
#undef main
#endif

It works, but since I didn't really like this solution, I dug a bit deeper and found out some more problems:

The SDL_main.lib file is not properly added in the dependencies by our CMake build configuration: In cmake/FindSDL2.cmake, in the FIND_LIBRARY calls, the NAMES argument is trying to find ONE of the names provided. Providing several names does not result in several libraries being added. (https://stackoverflow.com/a/15212241/3909725)
This can be fixed by the following snippets of code:

# cmake/FindSDL2.cmake
FIND_LIBRARY(SDL2MAIN_LIBRARY
	NAMES
		SDL2main
	PATHS
		${SDL2_SEARCH_PATHS}
	PATH_SUFFIXES
		lib
		lib64
		lib/x86
		lib/x64
	DOC
		"The SDL2main library"
)

# CMakeLists.txt
target_link_libraries( CGFX5
	${OPENGL_LIBRARIES}
	${GLEW_LIBRARIES}
	${SDL2_LIBRARY}
	${SDL2MAIN_LIBRARY}
	${ASSIMP_LIBRARIES}
)

Please note that the problem is also present for GLEW, but strangely enough, the fact that for example glew32s.lib is not linked does not seem to break my build.

Now that SDL2main.lib is correctly added to the linker configuration, I encountered a new error!

Severity
Code
Description
Project
File
Line
Suppression State

Error
LNK2019
unresolved external symbol __imp____iob_func referenced in function _ShowError
CGFX5
C:\Users\thundzz\Desktop\CGFX5\build\SDL2main.lib(SDL_windows_main.obj)
1

Error
LNK1120
1 unresolved externals
CGFX5
C:\Users\thundzz\Desktop\CGFX5\build\Debug\CGFX5.exe
1

Fortunately, after a quick googling of the problem, I found the reason for it ! Visual Studio 2015 changed the way stdin, stdout and stderr are defined ...
Now... the clean solution would be to build SDL2 with VS2015 and link the output .obj file instead of the one currently provided, but that would break the build for  users of previous versions.
The other solution (which was proposed by someone on the stackoverflow thread above) is to redeclare the previously used symbols:
extern "C" { FILE __iob_func[3] = { *stdin,*stdout,*stderr }; }

I don't really like this solution either, but it looks to me like it is the least worst solution of solving the issue.
Sorry for dumping such huge walls of text, but I felt the need to explain how I came to these conclusions instead of just throwing the final thing at you.
I thought I'd start by sharing all of this before trying to propose any new pull request. If you want me to commit the changes on another branch and submit a new pull request, please tell me!

Thanks again for being so thorough! It's really helpful, and has made this much easier to resolve. As far as the platform include, easy fix was just an oversight on my part as you suspected.
As for the libraries, that's an impressive depth of understanding you've developed for the project's dependencies, and I'm pleased you've discovered many things that could be a big issue if they weren't intentional. However, as odd as this may seem, what you're describing is actually by design. glew32s.lib isn't supposed to be linked, because it's the same as glew32.lib, just a static version. Since the project is already using the dynamically linked glew32.lib, there's no need do "double link" a second version of glew. None of the extra SDL libraries are linked because the only thing that should be needed is the primary SDL2 library. Which once again brings us back to the bizarre issue with the main function.
I've read through the SDL2 source code on this part. Here's what I've discovered:

On all platforms except Windows and game consoles (i.e. phones, Linux, and Mac), the main redefinition does nothing.

On Windows, if you're building a command line app (i.e. what this is doing), it also does nothing. However, if you're building a windowed app using the Windows API, then it does some sorcery to get the "command line parameters" and tries to pretend you're running a command line app.

On game consoles, it tries to do whatever is necessary to appease the game console's application requirements and then still pretend it's actually a command line app.

I think it's noteable that in all 3 cases, what SDL is doing is NOT what you want.

If you're deliberately making a command line app, there's no reason to have that wrapped in a needless function. Thus, SDL2's wrapper is undesirable.

If you're deliberately using the Windows API, then obviously, you're NOT trying to make a command line app, so you probably shouldn't be pretending it's a command line app. Thus, SDL2's wrapper is undesirable.

If you're making an app for the game console, then all the console-specific technology is part of the appeal, and you'll almost certainly need to take advantage of it to some point to get your program working as expected. Silently appeasing and ignoring it is probably not what you want, and you almost certainly don't want to pretend it's another command line app. Thus, SDL2's wrapper is undesirable.

Given this, as hackish as it may appear at first, I believe that undefing main is the correct solution. What you really want is control over your programs entry point, and what SDL does with it simply isn't useful as far as I can tell. So I've added the undef main trick as the solution.
If you could give it one more run to see if all works as expected, I'd appreciate it! If no more issues crop up, I think we can safely close this. Thanks again for all your help, it's much appreciated!

Thank you for all the explanations! Now that I understand better, it sounds like the solution you implemented is actually the most relevant for this use case.
I just re-cloned the project and now everything builds and runs smoothly!
As you said, we can now safely close this... so I'm doing that right now. 😄


pip out of sync with python

Hello @geerlingguy,
First of all, thank you for providing these
I have issues with pip being out of sync with python when using this image.  Consider the following sequence of events:
$ docker pull geerlingguy/docker-debian10-ansible
Using default tag: latest
latest: Pulling from geerlingguy/docker-debian10-ansible
Digest: sha256:f4e500bfc2e2ade59a04c9fea428c038f3643b6396e4615604236e2a1e3b31b8
Status: Image is up to date for geerlingguy/docker-debian10-ansible:latest
docker.io/geerlingguy/docker-debian10-ansible:latest
(ansible-role-docker) jeremy_frasier@lemmy ~/cisagov/ansible-role-docker $ docker run -it geerlingguy/docker-debian10-ansible /bin/bash
root@1385a153bee9:/# apt-get update && apt-get install python-pip python3-pip
Get:1 http://deb.debian.org/debian buster InRelease [122 kB]
Get:2 http://deb.debian.org/debian buster-updates InRelease [49.3 kB]
Get:3 http://deb.debian.org/debian buster/main amd64 Packages [7907 kB]
Get:4 http://deb.debian.org/debian buster-updates/main amd64 Packages [7380 B]
Get:5 http://security-cdn.debian.org/debian-security buster/updates InRelease [65.4 kB]
Get:6 http://security-cdn.debian.org/debian-security buster/updates/main amd64 Packages [181 kB]
Fetched 8331 kB in 2s (4460 kB/s)
Reading package lists... Done
Reading package lists... Done
Building dependency tree
Reading state information... Done
python3-pip is already the newest version (18.1-5).
The following additional packages will be installed:
  dbus gir1.2-glib-2.0 javascript-common libdbus-1-3 libgirepository-1.0-1 libglib2.0-0 libglib2.0-data libicu63 libjs-jquery libjs-sphinxdoc libjs-underscore libpython-all-dev libpython-dev libpython-stdlib libpython2-dev
  libpython2-stdlib libpython2.7 libpython2.7-dev libpython2.7-minimal libpython2.7-stdlib libxml2 python python-all python-all-dev python-asn1crypto python-cffi-backend python-configparser python-crypto python-cryptography python-dbus
  python-dev python-entrypoints python-enum34 python-gi python-ipaddress python-keyring python-keyrings.alt python-minimal python-pkg-resources python-secretstorage python-setuptools python-six python-wheel python-xdg python2
  python2-dev python2-minimal python2.7 python2.7-dev python2.7-minimal shared-mime-info xdg-user-dirs
Suggested packages:
  default-dbus-session-bus | dbus-session-bus apache2 | lighttpd | httpd python-doc python-tk python-crypto-doc python-cryptography-doc python-cryptography-vectors python-dbus-dbg python-dbus-doc python-enum34-doc python-gi-cairo
  gnome-keyring libkf5wallet-bin gir1.2-gnomekeyring-1.0 python-gdata python-keyczar python-secretstorage-doc python-setuptools-doc python2-doc python2.7-doc binfmt-support
The following NEW packages will be installed:
  dbus gir1.2-glib-2.0 javascript-common libdbus-1-3 libgirepository-1.0-1 libglib2.0-0 libglib2.0-data libicu63 libjs-jquery libjs-sphinxdoc libjs-underscore libpython-all-dev libpython-dev libpython-stdlib libpython2-dev
  libpython2-stdlib libpython2.7 libpython2.7-dev libpython2.7-minimal libpython2.7-stdlib libxml2 python python-all python-all-dev python-asn1crypto python-cffi-backend python-configparser python-crypto python-cryptography python-dbus
  python-dev python-entrypoints python-enum34 python-gi python-ipaddress python-keyring python-keyrings.alt python-minimal python-pip python-pkg-resources python-secretstorage python-setuptools python-six python-wheel python-xdg python2
  python2-dev python2-minimal python2.7 python2.7-dev python2.7-minimal shared-mime-info xdg-user-dirs
0 upgraded, 53 newly installed, 0 to remove and 8 not upgraded.
Need to get 52.5 MB of archives.
After this operation, 140 MB of additional disk space will be used.
Do you want to continue? [Y/n] Y

<snip> (successful install)

root@1385a153bee9:/# python --version
Python 2.7.16
root@1385a153bee9:/# pip --version
pip 20.0.2 from /usr/local/lib/python3.7/dist-packages/pip (python 3.7)

The problem seems to be these lines where you are running python3 get-pip.py even though you have already installed the package python3-pip a few lines above.
What is the rationale for running get-pip.py after you have already installed the python3-pip package?  Can we drop the extra step, since it results in:

pip3 being the default pip while python2 is still the default python
pip3 and pip2 being different versions

It probably makes sense to remove the same two lines in geerlingguy/docker-debian9-ansible as well, in order to keep pip2 and pip3 at the same version.

Oh, uh... I didn't even realize I'm installing it twice, whoops!

Thanks for the quick fix!


vscode client side tests

vscode tests as discussed in Zulip
It remains only to add npm test to https://github.com/rust-analyzer/rust-analyzer/blob/3dfc461f1e44ee7cebee672cac02d56ba5523f67/.github/workflows/ci.yaml#L116-L120
Do not want to modify CI files myself.
A draft because I want to check how draft pull requests work :) Does bors check them or not?

@Veetaha thanks for the review :)
I'll apply all suggestions in a single commit.

It is better to merge this only after #4548, adding tests for --features argument

Could you also add CI changes in this PR, to make sure it actually does work on CI? :)
Sure, I'll check.

Looks like now all works fine. Though there is one moment that caught my attention:
The Circular dependencies warning: windows, ubuntu, mac
The same exists in old builds without my changes: Fix tests, apply code review proposals, even already merged Merge #4578
I'm new to TypeScript\node.js and do not know is it important or not.
@matklad @Veetaha can you comment on this?

I'm new to TypeScript\node.js and do not know is it important or not.

It should be fine I think.

If there are cyclic deps in TypeScript there will be a problem, when the cycle bottoms-out the imported module will be undefined which may blow at runtime, I would joke with this...

This is a rollup -c output.
In fact I did not find where out\src\commands\on_enter.js reference out\src\commands\index.js

It's here
https://github.com/rust-analyzer/rust-analyzer/blob/f4f5fca10175b8d5fdfa36563c103f81b2b0acd3/editors/code/src/commands/on_enter.ts#L5
I've added two log lines to demonstrate:
import { applySnippetWorkspaceEdit } from '.';

+vscode.window.showInformationMessage(`Right away: ${typeof applySnippetWorkspaceEdit}`);

async function handleKeypress(ctx: Ctx) {
+    vscode.window.showInformationMessage(`In handler:${typeof applySnippetWorkspaceEdit}`);

and here is the result:

It work's right now because typescript transpiles
import { a } from "b"
exort function fn() {
    a();
}

to
const _1 = require("b");
module.exports.fn = function() {
    b.a() // notice the b prefix
}

So typescript doesn't import the function reference value, but rather it holds a reference to the module and accesses the function thru that reference which works when not accessed right away, but deferred inside other function call. This is a hard topic which I myself already forgetting about....

@Veetaha thanks for the explanations!


Optimize main.js

This Pull Request optimizes the functions used in /docs/_spec/public/scripts/main.js.
Changes made:

currentChapter() function was simplified using split() and pop() instead of lastIndexOf() and substring().
Used template literals for string interpolation.
Simplified the heading function by reducing repetitive code and improving readability.
Changed .removeClass() and .addClass() to .toggleClass() for toggling the class based on condition.
General cleanup and optimization for better readability and performance.

why remove comments?

why remove comments?

My code prettier automatically removes them, I can add them back if you'd like?

Sure, I'll add them back later today. I've also fixed my minifier settings, sorry.

Comments have been added

Sorry for the long wait. The changes look good, I just have a few nitpicks.

No problem! Take your time!


use relative path for logo import

Overview

PR Checklist
see convo - https://github.com/codecademy-engineering/Codecademy/pull/21360

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60021914d3f5ac0e9f5066bb--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://60021914d3f5ac0e9f5066bb--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60021c662227c414745148f4--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://60021c662227c414745148f4--gamut-preview.netlify.appDeploy Logs


Yc/new upd w adv

After #914 I am starting a new PR for advective updraft w.

@yairchn I see you already increased the reference counter in regression tests. Do you remember which cases were falgged as different?

After #914 I am starting a new PR for advective updraft w.

Does it mean https://github.com/CliMA/ClimaAtmos.jl/pull/902 should be closed?

@yairchn I see you already increased the reference counter in regression tests. Do you remember which cases were falgged as different?

The biggest difference I can spot is in the buoyancy for the convective cases (Bomex and TRMM):
Before / after compressible Bomex

Before / after: anelastic TRMM:

@yairchn I see you already increased the reference counter in regression tests. Do you remember which cases were falgged as different?

opps, I shouldn't have done it yet. can I undo it ? @charleskawczynski ?

After #914 I am starting a new PR for advective updraft w.

Does it mean #902 should be closed?

yes!

opps, I shouldn't have done it yet. can I undo it ? @charleskawczynski ?

Yes, I'm fine with doing whatever is needed!

@trontrytel thanks for the comparison - I haven't got to compare that yet, I am trying to resolve the issue I commented o n with deciding and multiplying by area fraction of the pressure term.

@trontrytel thanks for the comparison - I haven't got to compare that yet, I am trying to resolve the issue I commented o n with deciding and multiplying by area fraction of the pressure term.

Sounds good. I'll take another look at the plots when you are done with the pressure then. But for the (limited) number of single column cases we have here nothing bad really stands out. So I think this looks great

Bors r+


Formatter: Don't reorder parameters in function calls

Currently, we format
f(a=b, *args, **kwargs)

as
f(*args, a=b, **kwargs)

Instead, we should preserve the function order.

Why do you think that's better?  The original order was contentious when we implemented PEP 448.  And there's one good reason to do the reorder:
def g():
    print("g")
    return range(2)
def h():
    print("h")
    return 1

def f(*args, **kwargs):
    pass

f(a=h(), *g(), **{})  # Prints g then h!

Positional arguments are evaluated first.
``

I believe we do warn when keyword arguments are provided in such an order: https://beta.ruff.rs/docs/rules/star-arg-unpacking-after-keyword-arg/ (but it's unconditional)

@charliermarsh My mistake, I tested it but forgot to enable all the rules 😄
@MichaReiser Fair enough, sorry for the noise!

I honestly didn't realize that the evaluation order was independent of the literal order. I should update that rule documentation to include this, it's interesting.

Good idea.
It's one of the few places I think.  Really glad to see you have rule B026.  Definitely an important one for preventing bugs.
Do you have statistics on how often your various rules are hit in public code?  If this rule is hit very rarely, we may be able to convince the Python people to syntax-warn, and eventually deprecate this form.


Lipodystrophy, Familial Partial, Type 2 - Associated w/ hypercholesterolemia?

GARD received an inquiry from a person who would like to see the HPO Class Hypercholesterolemia (HP:0003124) associated with the disease entry Lipodystrophy, Familial Partial, Type 2 (HP:0000349). Although hypercholesterolemia is not a finding in all patients with familial partial lipodystrophy type 2, hypercholesterolemia does seem to occur in some people with the genetic disorder. The inquirer was told by a doctor at NIH (no additional details given) that hypercholesterolemia is a finding for the disease.
We found the following references for this inquiry:

Valerio CM, de Almeida JS, Moreira RO, et al. Dipeptidyl peptidase-4 levels are increased and partially related to body fat distribution in patients with familial partial lipodystrophy type 2. Diabetol Metab Syndr. 2017; 9: 26; https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5404683 The authors found a slight increase in total cholesterol. – “We also observed higher levels of triglycerides (224.8 ± 85.9 mg/dL) (Fig. 1b), but no changes in LDL cholesterol levels (131 ± 51.6 mg/dL) (Fig. 1d). We observed a slight increase in total cholesterol (203.4 ± 61.0 mg/dL) (Fig. 1c), followed by reduction of HDL cholesterol (33.2 ± 7.3 mg/dL) (Fig. 1e).

Park JY, Javor ED, Cochran EK, DePaoli AM, Gorden P. Long-term efficacy of leptin replacement in patients with Dunnigan-type familial partial lipodystrophy. Metabolism. 2007 Apr;56(4):508-16; https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2595136 They found that “total cholesterol and LDL were modestly elevated.”

Maria
@GARDInfoCenter
https://orcid.org/0000-0002-6548-5200

Hi Maria (@GARDInfoCenter) - do you mean you would like a phenotype for Hypercholesterolemia (HP:0003124) annotation on the disease Lipodystrophy, Familial Partial, Type 2  (https://www.omim.org/entry/151660)?
cc @pnrobinson

Yes, exactly.

@pnrobinson - I am having trouble with PhenoteFX, it will not open any files. :(

@GARDInfoCenter sorry for the super long delay, I added this annotation to this disease.


Considerations for the support timeline for SpringDoc 2.x

Question

SpringDoc switched GAV information in a major version change in 2.x to support Jakarta EE namespaces.  Refer to https://github.com/springdoc/springdoc-openapi/issues/1284.  For Knife4j which is currently in SpringDoc 1.x, is this piece not considered, or will there be a predetermined module to distribute additionally?

Should we consider releasing two different packages to support SpringDoc 1.x and SpringDoc 2.x respectively, or should we consider SpringDoc 2.x after SpringDoc 1.x support is dropped at some point in the future?  The roadmap for Knife4j V4 does not reflect this for Jakarta EE namespace support.🤔

Thanks for your suggestion, I see that the springdoc2.x version has not yet released a stable version.
So for Knife4j, the main work:

Adapt the enhanced functions provided by Knife4j to the springdoc1.x version, including the Openapi3 specification in the ui part, and provide a Spring boot starter that is easy for developers to use

After the release of 4.0, enterprise developers can gradually use the OpenAPI3 specification, which requires an excessive process. At present, as far as I know, many developers are still using springfox2.x or springfox3.0 version, although springfox3.0 provides correct Openapi3 specification support, but in my opinion, the support is still not good enough

After the stable version of springdoc2.x is released later, knife4j will keep up with the adaptation and support Jarkarta EE.

Thank you for your answer.😃 Since this is unmanageable work at this stage, I will close this issue.


Update Manual.md

bytes -> 16-bit addresses

This PR was based on a misunderstanding which has been sorted out on a separate channel. The documentation as currently written is accurate: each :pointer statement produces two bytes in a compiled ROM.


Flakey e2e test - "dataLossPrevention=true" - Numaflow Vertex Pods stuck in Pending state

Describe the bug
Happened here and here

Message from the maintainers:
Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

trying to add more debugging here


Add pad_size_to for struct types

pad_size_to on a struct should be able to reference import, temp variables, and generated fields.
Added StructGenerator::wrap_pad_size and smaller BinWrite implementation
3 new unit tests that check reading, one for write

I tried to update this PR to include enum but don’t have the bandwidth. It is confusing only to apply this to struct when enum is the same thing. Any chance you can make this change?

Other feedback based on my trying to include enum: Being able to use a field from inside a struct to define the struct size is convenient for formats where the object size is stored that way, but also somewhat problematic because it violates some notion of scoping rules. As a result, code has to be emitted from a place where the field variables are available and can’t be done just once somewhere closer to generate.

Any update on this? This functionality would be very useful in making the definitions a lot clearer.

A volunteer is needed to handle the enum case.


Adding expires returnExpiredItems property

Summary:
This PR adds a new schema property to the expires object, returnExpiredItems.
Code sample:
Schema
const tokenSchema = new dynamoose.Schema({
	id: {
		type: String,
		required: true
	}
}, {
	timestamps: true,
	expires: {
		ttl: 3 * 60 * 60,
		attribute: 'ttl',
		returnExpiredItems: false // will not return expired items if false (default: true)
	}
});

Type (select 1):

[ ] Bug fix
[x] Feature implementation
[ ] Documentation improvement
[ ] Testing improvement
[ ] Test added to report bug (GitHub issue #--- @---)
[ ] Something not listed here

Is this a breaking change? (select 1):

[ ] 🚨 YES 🚨
[x] No
[ ] I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

[x] Yes
[ ] No

Are all the tests currently passing on this PR? (select 1):

[x] Yes
[ ] No

Other:

[x] I have searched through the GitHub pull requests to ensure this PR has not already been submitted
[x] I have updated the Dynamoose documentation (if required) given the changes I made
[x] I have added/updated the Dynamoose test cases (if required) given the changes I made
[x] I have run npm test from the root of the project directory to ensure all tests continue to pass
[x] I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
[x] All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
[x] I have confirmed that all my code changes are indented properly using 2 spaces
[x] I have filled out all fields above

Pull Request Test Coverage Report for Build 620

3 of 5 (60.0%)  changed or added relevant lines in 2 files are covered.
85 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.1%) to 84.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Model.js
2
3
66.67%

lib/Schema.js
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

lib/Schema.js
3
89.81%

lib/Query.js
7
83.37%

lib/Scan.js
21
85.38%

lib/Model.js
54
82.49%

Totals

Change from base Build 613:
-0.1%

Covered Lines:
1539

Relevant Lines:
1775

💛  - Coveralls


[REEF-409] Pass the rackName from the runtime to the top of REEF stack

This work bubbles up the rack information from the runtime (after the resource is allocated) towards the evaluators allocation handlers.
The ResourceAllocationEvent interface now includes an optional rack name, which is populated by the respective runtimes when the resource is allocated.
The ProcessContainer is created with a null rack for now, it ends up using the default.
Added a unit test that tests the whole cycle, checking if the default rack is the one retrieved.
JIRA:
[REEF-409] (https://issues.apache.org/jira/browse/REEF-409)
This closes

Simple commit to "modularize" the change. Next steps are to pass the available racks to the ContainerManager in the local runtime. Lastly, we will define the API of how users will express their preferences regarding racks, nodes, and relax locality.

@nachocano I did a pass.

Added undesired code. Closing this and creating a new one


Create coding standards for IEF

What: Documented and agreed upon coding standards for IEF development.
Why: So we can ensure code quality is maintained and have a bar for accepting contributions.
DoD
[ ] Either selected existing or creating our own set of coding standards.
[ ] Coding standards should guide contributors on expectations for test coverage, documentation, file/folder structure, code re-use.
[ ] Issues created to fix inconsistencies in the existing code base and the selected coding standard.

We've created something to begin with here: https://github.com/Green-Software-Foundation/ief/blob/dev/CONTRIBUTING.md will expand on that are we go along.


UWP Support ?

Would be wonderful to have Universal Windows support !

I am also looking for UWP support, please let me know if it is available.

Inspired by this library I created a .NET Standard based Segmented Control library that also supports UWP Plugin Segmented Control for .NET Standard
@alexrainman I first tried to create a PR for this library, but I was unable to make the git clone work. Not sure why, but I VS 2017 was unable to open the solution in any workable state. Hence I chose to be inspired instead. Feel free to back port whateven I've done to make UWP work to this library if you want.


Filter by language Spanish

Thank you for the new and fantastic update that allows us to filter by language, to our Spanish community makes us a great job, both for Debrid and free users. If it would be possible to add more sources of Spanish content (not latin) we would be very grateful, some good options are “Wolfmax4k” and “TorrenFlix”.
Thanks for everything, this addon is becoming one of the most complete ones.

We have added the Wolfmax4k in the mediafusion public jackett instance

We have added the Wolfmax4k in the mediafusion public jackett instance

WooW, I didn't expect that, thank you very much for taking our community into account, we are really many users who consume content in Spanish. Once again thank you for this magnificent Addon 💪🏼.


Update app-objects-and-service-principals.md to call out Managed identities don't have a backing app registration

Related Incident: Unable to find application registration for enterprise application with app id: e68e6c32-1ade-4df2-8880-827b53d4251f
Related bug: Bug 3115117: Update docs to call out that Managed identities don't have a backing app registration

@rwike77
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team