_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 8dfa0b0b401c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 56dd3eba81

Max. process+thread count
50 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/1/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Anyway, if you think this is useful then let's try it.

It's been useful for me. I don't know if it's useful to other release managers. I don't want to add unused code to our repository, so if there isn't another release manager who thinks this will be helpful, let's not merge it.

Just one question, after launching the VM, we will call a release script diectly, or we still need to use docker based release script instead the VM?

I run the docker-based release script inside of this VM. I mention this at the very end of the README.md file, but maybe this information should be stated earlier, in a kind of summary usage statement.
I'll wait for other RM's to chime in.

FYI @ndimiduk
$ vagrant up
Bringing machine 'rmvm' up with 'virtualbox' provider...
==> rmvm: Checking if box 'ubuntu/bionic64' version '20201207.0.0' is up to date...
==> rmvm: Clearing any previously set forwarded ports...
==> rmvm: Clearing any previously set network interfaces...
==> rmvm: Preparing network interfaces based on configuration...
    rmvm: Adapter 1: nat
==> rmvm: Forwarding ports...
    rmvm: 22 (guest) => 2222 (host) (adapter 1)
==> rmvm: Running 'pre-boot' VM customizations...
==> rmvm: Booting VM...
There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["startvm", "e3d1d940-168e-4eb4-9fc8-ff4e46d02203", "--type", "headless"]

Stderr: VBoxManage: error: The virtual machine 'rmvm' has terminated unexpectedly during startup with exit code 1 (0x1)
VBoxManage: error: Details: code NS_ERROR_FAILURE (0x80004005), component MachineWrap, interface IMachine

I'd started virtualbox ...
I updated it, and got this:
$ vagrant up
The provider 'virtualbox' that was requested to back the machine
'rmvm' is reporting that it isn't usable on this system. The
reason is shown below:
Vagrant has detected that you have a version of VirtualBox installed
that is not supported by this version of Vagrant. Please install one of
the supported versions listed below to use Vagrant:
4.0, 4.1, 4.2, 4.3, 5.0, 5.1, 5.2, 6.0
A Vagrant update may also be available that adds support for the version
you specified. Please check www.vagrantup.com/downloads.html to download
the latest version.
(I'd started it and see the rmvm as stopped in listing of machines).
Updated vagrant... brew upgrade vagrant. 2.2.4 to 2.2.14.
Then it did this again...
There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["startvm", "e3d1d940-168e-4eb4-9fc8-ff4e46d02203", "--type", "headless"]

Stderr: VBoxManage: error: The virtual machine 'rmvm' has terminated unexpectedly during startup with exit code 1 (0x1)
VBoxManage: error: Details: code NS_ERROR_FAILURE (0x80004005), component MachineWrap, interface IMachine

Reinstalled (because net says might work...)
brew reinstall virtualbox
... hmm... still same complaint.
This is enough comment for one text box.

VirtualBox is really painful to use. It doesn't help that Vagrant and VirtualBox don't always update together. If it helps at all, the vm is working for my with this version pair,
$ VBoxManage --version
6.1.16r140961
$ vagrant --version
Vagrant 2.2.14

Oh, one other idea: sometimes VirtualBox gets stuck in such a way that the only way to resolve it is by launching it's GUI and clicking through whatever error messages it displays. Sometimes I have to delete a VM from the GUI and then resend vagrant in order to get state cleared out of both systems.

On another host (my build machine as it happens), it seems to just work. Trying test build...
Looked like this when I logged in...
$ vagrant ssh
Welcome to Ubuntu 18.04.3 LTS (GNU/Linux 4.15.0-72-generic x86_64)

 * Documentation:  https://help.ubuntu.com
 * Management:     https://landscape.canonical.com
 * Support:        https://ubuntu.com/advantage

  System information as of Wed Dec  9 19:47:22 UTC 2020

  System load:  0.22              Processes:              110
  Usage of /:   29.8% of 9.63GB   Users logged in:        0
  Memory usage: 7%                IP address for enp0s3:  <IP_ADDRESS>
  Swap usage:   0%                IP address for docker0: XXX.17.0.1

168 packages can be updated.
121 updates are security updates.

New release '20.04.1 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

*** System restart required ***

Seemed good bug gpg was not present in env.... so closed down... cleaned that up and then on restart got this.
stack:release-env stack$ vagrant up
Bringing machine 'rmvm' up with 'virtualbox' provider...
==> rmvm: Checking if box 'ubuntu/bionic64' version '20191218.0.0' is up to date...
==> rmvm: Machine already provisioned. Run `vagrant provision` or use the `--provision`
==> rmvm: flag to force provisioning. Provisioners marked to run always will still run.
==> rmvm: Running provisioner: puppet...
==> rmvm: Running Puppet with environment production...
==> rmvm: Info: Loading facts
==> rmvm: Info: Loading facts
==> rmvm: Info: Loading facts
==> rmvm: Info: Loading facts
==> rmvm: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
==> rmvm:    (file: /etc/puppet/hiera.yaml)
==> rmvm: Notice: VersionRanges will always be strict when using non-vendored SemanticPuppet gem, version 1.0.2
==> rmvm: Warning: The function 'hiera_array' is deprecated in favor of using 'lookup'. See https://docs.puppet.com/puppet/5.4/reference/deprecated_language.html\n   (file & line not available)
==> rmvm: Warning: The function 'hiera_hash' is deprecated in favor of using 'lookup'. See https://docs.puppet.com/puppet/5.4/reference/deprecated_language.html\n   (file & line not available)
==> rmvm: Notice: Compiled catalog for rmvm.apple.com in environment production in 2.01 seconds
==> rmvm: Info: Applying configuration version '1607545060'
==> rmvm: Notice: /Stage[main]/Main/Node[rmvm]/Vcsrepo[/home/vagrant/repos/hbase]/ensure: Updating to latest 'master' revision
==> rmvm: Error: Execution of '/usr/bin/git stash pop' returned 1: No stash entries found.
==> rmvm: Error: /Stage[main]/Main/Node[rmvm]/Vcsrepo[/home/vagrant/repos/hbase]/ensure: change from 'present' to 'latest' failed: Execution of '/usr/bin/git stash pop' returned 1: No stash entries found.
==> rmvm: Notice: Applied catalog in 10.30 seconds
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 54e3523ac62d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/2/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Build fails for me because no gpg key in vagrant env...
$ gpg --sign repos/hbase/pom.xml
gpg: no default secret key: No secret key
gpg: signing failed: No secret key
When I run vagrant, there is a gpg-agent up that works.. has cached key...
Vagrant supposed to hoist it up into the vm (the key may not have registered in agent when I did 'vagrant up'... maybe it has to be then?)

Ok. Sorted out the virtualbox and vagrant stuff... Thats all good. Just stuck now on the gpg secret passing bit (Nick has been helping me out offline).

I think this project has bit-rot since I used it last (which has been several months). My current best guess is that gpg version miss-match is preventing agent forwarding to work. My host machine has gpg 2.2.20 while the guest bionic vm install gpg 2.2.4. According to packages.u.o, I can get gpg 2.2.19 if I upgrade the vm to Ubuntu focal (20.04LTS).
The alternative is to downgrade the gpg version running on the host OS. I don't think that's a good long-term solution though.

Head's up though -- if the issue here is indeed gpg agent version mismatch, create-release in docker mode will have the same problems because it's also using an ubuntu bionic base for it's agent forwarding tests...

On Mac its $ gpg --version
gpg (GnuPG) 2.2.25
Trying later ubuntu...

Tried upping the vagrantfile ubuntu... removed the old image first.
vagrant@rmvm:~$ more /etc/issue
Ubuntu 20.04.1 LTS \n \l
vagrant@rmvm:~$ gpg --sign repos/hbase/pom.xml
gpg: no default secret key: No secret key
gpg: signing failed: No secret key
vagrant@rmvm:~$ ps auxwww|grep gpg-agent
vagrant    21315  0.0  0.0  82948  3496 ?        SLs  05:08   0:00 /usr/bin/gpg-agent --supervised
I didn't check to see if the gpg-agent process was present before I went about my business.

Upgrading this VM to 20.04 (focal) gives me gpg 2.2.19 on the VM side. with this, and 2.2.26 on the mac side, i’m able to forward my agent and ssh -T<EMAIL_ADDRESS>run from the vm passes through my credentials.

Upgrading this VM to 20.04 (focal) gives me gpg 2.2.19 on the VM side. with this, and 2.2.26 on the mac side, i’m able to forward my agent and ssh -T<EMAIL_ADDRESS>run from the vm passes through my credentials.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

_ Other Tests _

1m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests

uname
Linux 942aa663bddc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 90ff550000

Max. process+thread count
53 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
yamllint
0m  1s
yamllint was not available.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
yamllint
0m  1s
yamllint was not available.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 2b4f93eac127 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 90ff550000

Max. process+thread count
43 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/4/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Latest commit fixes ssh configurations and outlines basic steps to verify the agent forwarding in the readme. "works for me".

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 0da00d4d1078 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 90ff550000

Max. process+thread count
44 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/5/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 38d403479362 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

Max. process+thread count
44 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/6/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

2m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 38d403479362 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

Max. process+thread count
44 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/6/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I've updated the readme based on @saintstack 's comments.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 55700f4dc07c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

Max. process+thread count
42 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/7/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux 55700f4dc07c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

Max. process+thread count
42 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/7/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Maybe some other release managers could take another look here? Maybe someone is feeling ambitious and would like to add box definitions for public clouds (i.e., via vagrant-google or vagrant-aws). In theory this is trivial, assuming an equivalent base box to the one used with the  VirtualBox provider.

Maybe some other release managers could take another look here? Maybe someone is feeling ambitious and would like to add box definitions for public clouds (i.e., via vagrant-google or vagrant-aws). In theory this is trivial, assuming an equivalent base box to the one used with the  VirtualBox provider.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

3m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux b1db0c8e0b00 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

Max. process+thread count
42 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/8/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+0 :ok:
yamllint
0m  0s
yamllint was not available.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
yamllint
0m  1s
yamllint was not available.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

4m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux c938f713b205 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2444d26890

Max. process+thread count
43 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/9/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+0 :ok:
yamllint
0m  1s
yamllint was not available.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for patch

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

4m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2754

Optional Tests
dupname asflicense shellcheck shelldocs yamllint markdownlint

uname
Linux c938f713b205 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2444d26890

Max. process+thread count
43 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2754/9/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Left some advocacy for this addition up on the JIRA

Left some advocacy for this addition up on the JIRA

Thanks for giving it a proper spin, @saintstack . Given that it has meaningful utility beyond myself, I'm good with merging this patch. It also provides a reference point for diagnosing what's slow on docker vs. the vm with the same hardware.

Thanks for giving it a proper spin, @saintstack . Given that it has meaningful utility beyond myself, I'm good with merging this patch. It also provides a reference point for diagnosing what's slow on docker vs. the vm with the same hardware.

@Apache9 do you have any further comments before merge? Hopefully the readme is more clear.

@Apache9 do you have any further comments before merge? Hopefully the readme is more clear.

This is merged. Thanks for taking time with it!
@Apache9 I included a signed-off-by line with your name on it because you did approve an early version of this. If you get back to this ticket and have some reservations, let me know and I'll revert the commit and continue the discussion.

This is merged. Thanks for taking time with it!
@Apache9 I included a signed-off-by line with your name on it because you did approve an early version of this. If you get back to this ticket and have some reservations, let me know and I'll revert the commit and continue the discussion.

No problem. Just go ahead.
Thanks.

No problem. Just go ahead.
Thanks.


Fix eslint errors in Storefront branch

These eslint errors must be fixed before merging into develop
Breadcrumb.jsx

44:24  error  Elements with ARIA roles must use a valid, non-abstract ARIA role  jsx-a11y/aria-role
53:22  error  Elements with ARIA roles must use a valid, non-abstract ARIA role  jsx-a11y/aria-role
96:46  error  Elements with ARIA roles must use a valid, non-abstract ARIA role  jsx-a11y/aria-role

Card.test.jsx

85:11  warning  A control must be associated with a text label  jsx-a11y/control-has-associated-label

TopBar.test.jsx

47:11  warning  A control must be associated with a text label  jsx-a11y/control-has-associated-label

Is this OK @vnys ?

Deprecated


[folding] Add a setting to expand folded regions by clicking anywhere on the collapsed line (roll back to the old behavior)

In the previous VSC version, it was possible to expand a folded region by clicking anywhere on the collapsed line.
But this was changed recently (https://github.com/microsoft/vscode/issues/53886), and now you have to click specifically on the ... icon.
I, for one, find this very inconvenient. It would be great to have a setting to switch to the old behavior.

/duplicate of #88522


updated_at ambiguous on using delete() on hasManyThrough relation with softDeletes

Laravel Version: 5.1.45
PHP Version: 7.0.1
Database Driver & Version:
Mysql

Description:
You receive an error that the updated_at field is ambiguous while running a delete() function on a hasManyThrough relationship having softDelete.
Steps To Reproduce:
Create a hasManyThrough relationship on a model. For eg.
Make a function in the model User.php
public function commuteDistances() {
return $this->hasManyThrough('App\Models\CommuteDistance','App\UserPropertyListing','user_id','user_property_listing_id','id');
}
Try running
$user->commuteDistances()->delete();
The query generated is
update commute_distances inner join user_property_listings on user_property_listings.id = commute_distances.user_property_listing_id set commute_distances.deleted_at = 2016-10-07 15:33:41, updated_at = 2016-10-07 15:33:41 where commute_distances.deleted_at is null and user_property_listings.deleted_at is null and user_property_listings.user_id = 3
Error
SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'updated_at' in field list is ambiguous

Duplicate of https://github.com/laravel/framework/issues/13909


Failed to unpack, error code '19'

d:\php-sdk\phpmaster\vc14\x64\php-src-php-7.0.14
$ phpsdk_deps --update --branch master

Configuration: master-vc14-x64-staging

Processing package apache-2.4.23-vc14-x64.zip
Processing package c-client-2007f-vc14-x64.zip
Processing package dirent-20080629-vc14-x64.zip
Processing package fbclient-2.5-nocrt-x64.zip
Processing package freetype-2.7.0-vc14-x64.zip
Processing package glib-2.49.4-vc14-x64.zip
Processing package ICU-57.1-vc14-x64.zip

Fatal error: Uncaught SDK\Exception: Failed to unpack, error code '19' in D:\php-sdk\lib\php\libsdk\SDK\Dependency\Package.php:54
Stack trace:
#0 D:\php-sdk\lib\php\libsdk\SDK\Dependency\Manager.php(68): SDK\Dependency\Package->unpack('D:\\php-sdk\\.tmp...')
#1 D:\php-sdk\bin\phpsdk_deps.php(185): SDK\Dependency\Manager->performUpdate(NULL)
#2 {main}
  thrown in D:\php-sdk\lib\php\libsdk\SDK\Dependency\Package.php on line 54

Thanks for the report. First guess - possibly a network issue, so the corresponding package was broken. Otherwise, is this reproducable in some way?
Thanks.

Yes. it relate to network issue. i force redownload. then working correct.


MudTable load more data from server when scroll to end of table

Hi. I think title is clear. I have some huge table and I show a little preview to client. but I need when client scroll to end of table, more data load from server. for now I am using paging option to show more data to client. but this is not what exactly fix the problem.
This feature is very common specially in database manger programs like sql developer or sql server management system.

We may continue to discuss on discussions section. I hope you will find a good solution 🙂


Brackets!!

Olá boa noite,eu gostaria que o editor Brackets fosse multi browsers,ou seja a renderização deveria ser para todos os navegadores modernos.

Hi @Adriano87,
if I understood you correctly (through Google Translate), you can already use the Live Preview feature in Brackets with any browser.

It (Multibrowser live preview) can be enabled by setting livedev.multibrowser preference to true. If enabled, it will launch the page in your default browser when clicking on the Live Preview icon as it works today. You should then also be able to copy and paste the URL from that browser into any other browser, live edits will then update all connected browsers at once.

Closing as answered. Please feel free to reopen this if you issue is not resolved.


Visual Studio 2022 Lost Support for .NET 7 & 8 in 4.3

Tested versions
Reproducible in 4.3 Dev 6 Mono when launching Visual Studio 2022 through the editor interface.
Not reproducible in 4.3 Dev 6 when launching Visual Studio Code through the editor interface.
Not reproducible in 4.2.1 and 4.2.2.
System information
Windows 11, Godot 4.3 Dev 6 Mono
Issue description
When attempting to open a script in Visual Studio 2022 via the interface editor in 4.3 Dev 6, you are only able to launch if you have .NET 6.  If you have .NET 7 or 8, but not 6, you are unable to launch Visual Studio 2022.
You are able to launch Visual Studio Code with only .NET 7 and 8.  This is only an issue with Visual Studio 2022.
I appear to have found the location of the issue.  The generated file "Godot_v4.3-dev6_mono_win64\GodotSharp\Tools\GodotTools.OpenVisualStudio.runtimeconfig.json" contains the following:
{
"runtimeOptions": {
"tfm": "net6.0",
"framework": {
"name": "Microsoft.NETCore.App",
"version": "6.0.0"
},
"configProperties": {
"System.Reflection.Metadata.MetadataUpdater.IsSupported": false
}
}
}
This file appears to be forcing users of Visual Studio to use .net 6.  If you manually edit the "6" to your version of .NET ("8" for example), it will fix the issue for me.
Steps to reproduce
Attempt to open a script using visual studio without .NET 6.
Minimal reproduction project (MRP)
Download 4.3 Dev 6, create any script, and attempt to open it with Visual Studio 2022.

I cant find where to implement this, but if you made the below edit using "rollForward", it should fix the issue.
{
"runtimeOptions": {
"tfm": "net6.0",
"framework": {
"name": "Microsoft.NETCore.App",
"version": "6.0.0"
},
"rollForward": "Major",
"configProperties": {
"System.Reflection.Metadata.MetadataUpdater.IsSupported": false
}
}
}


[Feature Request]: Add privateEndpoint support in the recoveryservicesvault module

Description
Add privateEndpoint support in the recoveryservicesvault module

Subset of #890


pickling greykite model

Hi again,
Thanks for the package!
I was having trouble pickling the results.model object, I guess there isn't any particular way to do that yet?
I tried using the dump_obj utility I found but got the following error:

Best,
George

Hi George, it looks like you are running on windows. Seems like windows has different file system and we haven't specifically put efforts in this area. We will investigate into this. Meanwhile if you could try this on linux (such as a vm) the problem should be gone!
Best,
Kaixu

Hi Kaixu,
Thanks for the tip, I will try on a Linux box.
Best,
George


I Can't compile the Readium successfully.

@danielweck When I operate as you wrrite  in  https://github.com/readium/readium-sdk/issues/168
I Can't compile the Readium successfully.Some errors occured as follow:

How can I correct it?

@zxz1989 hello, I am closing this issue and will reply in the original discussion:
https://github.com/readium/readium-sdk/issues/168


cherry pick websocket binary fix changes from main

Codecov Report

Merging #1041 (4515a64) into zio-series/2.x (b9527a4) will increase coverage by 0.84%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           zio-series/2.x    #1041      +/-   ##
==================================================
+ Coverage           55.72%   56.57%   +0.84%
==================================================
  Files                  71       71
  Lines                2243     2243
  Branches               58       58
==================================================
+ Hits                 1250     1269      +19
+ Misses                993      974      -19

Impacted Files
Coverage Δ

...p/src/main/scala/zhttp/socket/WebSocketFrame.scala
35.48% <100.00%> (+22.58%)
:arrow_up:

zio-http/src/main/scala/zhttp/socket/Socket.scala
52.94% <0.00%> (+2.94%)
:arrow_up:

...o-http/src/main/scala/zhttp/socket/SocketApp.scala
37.14% <0.00%> (+11.42%)
:arrow_up:

...main/scala/zhttp/service/WebSocketAppHandler.scala
56.00% <0.00%> (+28.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9527a4...4515a64. Read the comment docs.


Dockerfile-ann build fail

This environment is externally managed
 > [ 8/14] RUN python3 -m ensurepip:
2.505 error: externally-managed-environment
2.505
2.505 × This environment is externally managed
2.505 ╰─>
2.505     The system-wide python installation should be maintained using the system
2.505     package manager (apk) only.
2.505
2.505     If the package in question is not packaged already (and hence installable via
2.505     "apk add py3-somepackage"), please consider installing it inside a virtual
2.505     environment, e.g.:
2.505
2.505     python3 -m venv /path/to/venv
2.505     . /path/to/venv/bin/activate
2.505     pip install mypackage
2.505
2.505     To exit the virtual environment, run:
2.505
2.505     deactivate
2.505
2.505     The virtual environment is not deleted, and can be re-entered by re-sourcing
2.505     the activate file.
2.505
2.505     To automatically manage virtual environments, consider using pipx (from the
2.505     pipx package).
2.505
2.505 note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.

The Dockerfile with updated benchmarker does not have this issue anymore (and is written in go instead).


Regenerated holidays ruby files from yaml to reflect recent changes.

Coverage decreased (-1.16%) to 82.69% when pulling e185fddeb0602b7506018fb4de7525938bec6d7e on martinsabo:master into 4b1ef021bf1929a4ed8020fe5b7bb3f1530ac257 on alexdunae:master.

Regenerated changes are already part of different pull request (https://github.com/alexdunae/holidays/pull/122). Closing.


Fix the issue with special characters - Changed the default charset to UTF-8 to support special characters

Changed the default charset to UTF-8 to support special characters

This is to address the below reported issue
https://github.com/spring-cloud/spring-cloud-aws/issues/645#issue-683832969

Thanks @chsraju for contribution! Is it possible to also add a test that verifies this change?


[$500] Fab - Hidden not displayed on chat header & LHN when creating an IOU

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.43-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Click on FAB > Request money > enter amount
Select a new user that has ND account > Click on 'Request' button

Expected Result:
Hidden should be displayed in LHN & report header
Actual Result:
Hidden is not displayed in LHN & report header
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/e8d0e519-b58c-4d9b-8b4a-c405c8cc22f8
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015ea497aa7819e170
Upwork Job ID:<PHONE_NUMBER>634163200
Last Price Increase: 2024-02-20

We think that this bug might be related to #vip-bills
CC @davidcardoza

@greg-schroeder @DylanDylann are you able to reproduce? I am unable. I think something is missing from repro steps @kbecciv ?

Expected Result:
Hidden should be displayed in LHN & report header

I don't even get that -- @kbecciv can you share a screenshot of the expected outcome please? 😕

I've noticed a discrepancy in behavior between production and staging. In production, the avatar of a user whom I've never chatted with before, but who has an ND account, is displayed in the header. However, in staging, the user's avatar is displayed as a skeleton in both the header and LHN.
Production
https://github.com/Expensify/App/assets/93399543/fddd6dfb-0969-4584-8718-cb5a2117a13d
Staging
https://github.com/Expensify/App/assets/93399543/50bd6a25-44f9-4ae4-b6b5-973b85bf8ff5

@dukenv0307 Do you suggest applying isOptimisticReport to report or reportAction? It seems your permalink taking us to success data of reportAction

But your permalink linked to success data or report action

@dukenv0307 Could you reproduce this issue on latest main?

@chiragsalian @flodnv  we can't reproduce the original issue anymore, so I think we should remove deployBlocker label in this issue. And we also should consider to fix above bug that is mentioned by @dukenv0307

@chiragsalian Reported bug here. Let's close this one


[HOLD for payment 2024-11-11] [$250] Invoices - Invoice preview sender appears and disappears when sending invoices consecutively

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5102388
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to FAB > Send invoices.
Send an invoice to anyone.
In the invoice chat, click + > Send invoice.
Send another invoice.

Expected Result:
The invoice preview sender will not appear and disappear when sending invoices consecutively.
Actual Result:
The invoice preview sender appears then disappears when sending invoices consecutively.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e4d15c1c-5317-4af3-8558-2308e62cc7cf

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021848369344890325291
Upwork Job ID:<PHONE_NUMBER>890325291
Last Price Increase: 2024-10-21
Automatic offers:

hoangzinh | Reviewer | 104579791
NJ-2020 | Contributor | 104579793

Issue OwnerCurrent Issue Owner: @slafortune

@slafortune  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

LGTM, feel free to create the PR @NJ-2020

PAYMENT SUMMARY FOR OCT 11

Fix: @NJ-2020 [$250, if no regressions] offer
PR Review: @hoangzinh [$250, if no regressions] offer
please complete the checklist in above comment

@hoangzinh I'm not assigned this GH. But, I will go ahead and process payment for you

payments sent and contracted ended


Mouse in X10 mode is sending wrong coordinates

That one or the other one, I can not remember, but one is failing.

Fixed, the state was not properly reset.


use travis homebrew addon for reliability

[X] I've read, understood, and done my best to follow the CONTRIBUTING guidelines.

This pull request includes (pick all that apply):

[ ] Bugfixes
[ ] New features
[ ] Breaking changes
[ ] Documentation updates
[ ] Unit tests
[X] Other

Summary
use travis homebrew addon for reliability. travis homebrew addon uses a specific rvm maintained by travis that should provide the best compatibility with homebrew. prevents some breakages that have happened in the past due to underlying rvm changes in homebrew
Implementation
minor changes to .travis.yml
Test Plan
covered by travis

Hello @stephengroat -- thank you for your contribution! I wasn't aware that this addon existed. This should speed up Conduit builds a bit.
Could you add a bit more detail to the Summary section? We like to aim for high-verbosity for historical purposes.
Lastly, if you don't mind me asking -- could you inform me a little bit on the background / what sparked this change? Thanks!

@johnhammerlund no worries, made a minor update in the summary section, let me know if more verbosity would be helpful
major reason i made the change is i'm using the library in a new project, wanted to make a slight modification. to build locally, i always look at the .travis.yml file and saw that this improvement could be made.


Is the account api backend public?

First of all cool project. And I know its a side project and there is not a lot of uptime to expected but I decided to still ask.
I was not able to reach https://craft.michaelfogleman.com/ using my browser nor to connect via
$ ./craft michaelfogleman.com
connect: Connection refused
$ ./craft craft.michaelfogleman.com
connect: Connection refused

And running python server.py worked fine and I was able to play there but it feels like it is not fully replacing https://craft.michaelfogleman.com/api/1/ is there a way to host a server where users can register accounts in the case of craft.michaelfogleman.com being down?

Hi. Yes, I recently took down craft.michaelfogleman.com after many years.
You can try running your own login server:
https://github.com/fogleman/LoginServer

Awesome! Maybe that repository could be mentioned in the readme?

It would be nice if you could start your server again but if you do not want to it would probably better to replace the url  https://craft.michaelfogleman.com in the readme with https://github.com/fogleman/LoginServer and then this issue can be closed I guess.


Implement output types

[ ] CSV type
[ ] Wide-form CSV
[x] JSONLINES (default)

JSONLINES implemented in 607d17b59151fa60c6c3a8c842308aa64c7cf725

It might be beneficial to move some of this to the core library for serialization/deserialization and conversion from json to csv to save time in JS.

csv crate will be useful here as well.

I believe the wide-form-csv option may be out of scope here as it attempts to perform some analytical preparation/manipulation that is not fundamental to the tool's functionality.
This would be better served in a post-tool analytical pipeline with pandas or something similar.


Upgraded alexa-app and alexa-app-server to 3.0.0.

Don't get left behind!

Warnings

:warning:
Did you forget to update CHANGELOG.md?

  Generated by :no_entry_sign: dangerJS

Coverage increased (+1.0%) to 84.5% when pulling b7e05c61edcdc1c4391d2ecb3f7278b06c6c5b8c on dblock:upgraded-alexa-app into 961d8c091296ac4f3873e4072b1467d0717278fe on artsy:master.


isort seems to be affected by the environment. (ex: os, virtualenv)

I don't think this problem is completely fixed. #725
My local (mac os + pipenv) and jenkins ci's isort works differently.
It also works differently inside and outside pipenv on the same mac local.
Can you confirm this?
If I run isort outside of pipenv in local, the files are fixed.

If I work inside pipenv shell after running isort outside pipenv, the file is fixed again.

I have the same issue.
Isort sorts differently on different machines despite haveing the same version (4.3.4) and config:
Diff produced:
 from datetime import datetime
 from tempfile import TemporaryFile

-import ffmpeg
 import uuid
 from django.core.exceptions import ValidationError
 from django.core.files import File
 from django.db import models
 from django.forms import model_to_dict

+import ffmpeg
 from myapp.constants import EXPIRATION_DAYS, EXPIRATION_REPEAT, MP3_HEADERS
 from myproj.constants import A, B
 from myproj.settings import BASE_DIR, LOCAL

.isort.cfg
[settings]
line_length=160
multi_line_output=1
skip_glob=**/migrations/**.py
known_django = django
order_by_type = True
known_standard_library= datetime, pytz, json, re, string, time, unittest,
known_third_party=django, rest_framework, raven, celery, model_mommy, uuid, request, pdfkit, pandas, matplotlib
known_first_party=myapp, myapp1,...

@schumannd Are the Python versions the same?

Generally, this is simply because the virtual env is different. Which was an intentional bit of magic (detect if something is third party based on if it is installed in virtual env).

This should be fixed for the 5.0.0 release in spirit via this ticket: https://github.com/timothycrosley/isort/issues/1147

Having same issue, using nox vs. not using nox to run isort

@ryan-faculty I'm having the same problem. Were you able to fix it?


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_6f26cyj_2r/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_6f26cyj_2r/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
Errors were found


App crashing when on data connection.

Actual Behaviour

When the snackbar appears, if instead of clicking yes we click on any track then app getting crashed.

Expected Behaviour
App should not crash.
@the-dagger sending the PR. Please review.

@harshitagupta30
didnt get any error as such. would be better if you elaborate.

@arp95 If instead of following the regular process i.e. clicking on yes, you click on any track or in any other fragment then the app is getting crashed because the cursor is returning zero value which you can see from the log. If we can add check on cursor if it's null or not it's not crashing. Shall I add screen recording as well?

@harshitagupta30
actually i am not getting this snackbar even on data connection. anyways got what you are referring to.

As mentioned in line 212:41 in MainActivity.java if you're not connected to wi-fi then a snackbar will pop out! :+1:

@harshitagupta30  I am not getting any such error. Can you explain it.

@harshitagupta30 I have also faced similar issue and this issue needs. @amitiwary999 If you'll try to open any track before the app updates the schedule, a null pointer exception is created, since the database containing list of tracks is not updated and is empty. Maybe try once more and make sure you are on Data connection


Concrete doc of this project

Hi, is there a concrete documentation of the architecture or implementation of the project? Thank you.

Hi @frankxyy Sorry, we are currently concentrating our limited resources on Colossal-AI. You can check the examples and source code of EnergonAI for details. Thanks.


checkmarx import failed because of bad char

Hello,
Some import of checkmarx scan fail because of bad char encoding.
See : https://github.com/DefectDojo/django-DefectDojo/issues/1369
When submitting a pull request, please make sure you have completed the following checklist:

[x] Your code is flake8 compliant

nice! thanx for the PR.


Autorest Regen Preview to 3.0.0-alpha.20230803.1 by Dapeng Zhang from refs/pull/3483/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/3483

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.ChangeAnalysis


Suggestion: Mention Azurite in the page

Hey folks,
Since the azure function host needs the local storage emulator (see issue in azure-functions-host 5087) do you think it would be a good idea to mention Azurite in the Run the function locally section.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40b416d5-6ea5-39a5-9a2c-ab188d00a686
Version Independent ID: 855c85f7-53b3-59a2-3f42-fbccbba07d32
Content: Create a function in Azure that responds to HTTP requests
Content Source: articles/azure-functions/functions-create-first-azure-function-azure-cli.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@davinci26 Thanks for the question! We're investigating this and will get back to you shortly.

@brettsam Any thoughts on this ?

@brettsam Just following up again in case missed the previous communication.

@davinci26 I have assigned this to content author for further review and update as appropriate.


[Typed throws] Add upcoming feature FullTypedThrows

Introduce the upcoming feature FullTypedThrows. When enabled, infer the error type of a throw statement based on its original type, instead of always being any Error. This is technically a source-breaking change, hence the upcoming feature flag.

@swift-ci please smoke test


Tighten verification check for Expm1Op

Currently the ODS accepts all element types, but there is no verification to only allow floating-point and complex types.

Closing this since it is already enforced by the ODS
https://github.com/openxla/stablehlo/blob/e9cacdccbb73b8b03b4de6e8be110eec94dd3d31/stablehlo/dialect/StablehloOps.td#L322-L323


feat: add sealed_header to HeaderProvider for single headers

motivated by #2707
ref #2769
Adds a sealed_header method for retrieving just a single sealed header from the db.

whoops missed an impl I think? fixing tests


Activating Open Collective

This pull request adds backers and sponsors from your Open Collective https://opencollective.com/xcproj ❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

Thank you very much @asood123 accepting xcproj as part of open collective. The changes looks good to me 👍, thanks for adding them to the repository 😛


Stuff <3

So first of all I wanted to say that I love your mod, really good stuff, basically Tinker's Construct without all the complicated stuff (it got even worse in 3.0), my main complain is that mod's progression goes only up to getting the modular workbench, no smeltery, no further progression, no nothing, it would be nice if modular workbench was a multi block, requiring bit more work, maybe even locking some stuff behind higher tiers, or forcing player to wait for their tool to process determined on how difficult is their tool, kinda like Tetra, but instead of having to find the workbench structure (which is a common complaint that I have seen) you could have it wherever you desire, also something related to armour design, having more options would definitely be nice, yes I know it's early stages of the mod, not only that, but if I want to add something there's separate API allowing this kind of stuff, but it's something that would be nice, more designs would be great, similar to arsenal, but that's just a thought I wanted to share, it's really a minor stuff and regardless of future plans and changes I still find this project extremely cool, I have to say I was bit surprised there's no cactus armour ([it seemed obvious] correct me if I'm wrong), but other than that I love this mod, really great stuff, keep it up pal.
Cheers.

Well, thanks for the feedback, this kinda fell under the radar after the release, sorry for the late answer.
Overall, while some sort of progression would be cool, we wont add that nativly to Truly Modular and its 3 current addons.
BUT - we have already system in places for different ways of locking and hiding options inside the gui and there are plans for addons who would focus on progression overall, but those are still a bit away. ( The system in place can detect player inv, surrounding of the workbench or other stuff about the player like advancements).
Yeah, cactus armor sounds really obvious lol, probably gonna add that xD, the armory and archery are fairly bare bones at this stage in the development, but we have some plans to expand them. At the moment the main focus is to fix issues and compatiblity with other mods, so huge content updates might take a bit.


Update README.md

Link to pull request - https://github.com/NixOS/nix/pull/4052

Other typo no longer present https://github.com/NixOS/nix/blob/master/src/libfetchers/registry.cc#L181


GH doesn't respect restriction=only_right_turn?

Hi,
https://graphhopper.com/maps/?point=53.589197%2C10.057624&point=53.590502%2C10.058069&locale=en-US&layer=Lyrk
And there is a restriction: http://www.openstreetmap.org/relation/51157

The speed mode does not support turn restrictions at the moment. Or do you mean that this does not work for the flexibility mode?

You mean https://graphhopper.com/maps/ use speed model by default?
Can I turn of speed model on https://graphhopper.com/maps/ ?

Good question, currently it should work to perform normal algorithms on prepared graph, but it won't work here and also the graph has no turn restrictions collected while import.

Please reopen if you need such a feature.


Re: Allow tasks to run commands regardless of their output

VS Code Version: 1.54.1
OS Version: Windows 10

Steps to Reproduce:
I refer to #97161: I am experiencing exactly the same issue with error messages
"Cannot substitute command variable '<command variable>' because command did not return a result of type string.".
This is quite unexpected behaviour.

Duplicate of https://github.com/microsoft/vscode/issues/97161

It's a little confusing that all issue reports on this subject are being closed directly,
since this appears to be an unresolved bug, doesn't it?

It's a little confusing that all issue reports on this subject are being closed directly,
since this appears to be a bug, doesn't it?


Kube-prometheus etcd ServiceMonitor not working

What did you do?
Deploy kube-prometheus in with the kube-etcd exporter (Service and ServiceMonitor)
What did you expect to see?
Green alerts in prometheus dashboard for kube-etc related metrics.
What did you see instead? Under which circumstances?
InsufficientMembers is not passing.
up{job="kube-etcd"} query on Prometheus returns 0 for all kube-etcd servers.

Prometheus Operator version:
quay.io/coreos/prometheus-operator@sha256:88cd66e273db8f96cfcce2eec03c04b04f0821f3f8d440396af2b5510667472d

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.5", GitCommit:"32ac1c9073b132b8ba18aa830f46b77dcceb0723", GitTreeState:"clean", BuildDate:"2018-06-21T11:46:00Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.6", GitCommit:"a21fdbd78dde8f5447f5f6c331f7eb6f80bd684e", GitTreeState:"clean", BuildDate:"2018-07-26T10:04:08Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
Kops cluster, Version 1.10.0 (git-8b52ea6d1)

Manifests:

Service Monitor (created by kube-prometheus Chart)
Name:         kube-prometheus-exporter-kube-etcd
Namespace:    monitoring
Labels:       app=exporter-kube-etcd
              chart=exporter-kube-etcd-0.1.15
              component=kube-etcd
              heritage=Tiller
              prometheus=kube-prometheus
              release=kube-prometheus
Annotations:  <none>
API Version:  monitoring.coreos.com/v1
Kind:         ServiceMonitor
Metadata:
  Cluster Name:
  Creation Timestamp:  2018-12-01T18:19:18Z
  Generation:          1
  Resource Version:    25504678
  Self Link:           /apis/monitoring.coreos.com/v1/namespaces/monitoring/servicemonitors/kube-prometheus-exporter-kube-etcd
  UID:                 9e4eaaed-f595-11e8-b63f-027656b86196
Spec:
  Endpoints:
    Bearer Token File:  /var/run/secrets/kubernetes.io/serviceaccount/token
    Interval:           15s
    Port:               http-metrics
  Job Label:            component
  Namespace Selector:
    Match Names:
      kube-system
  Selector:
    Match Labels:
      App:        exporter-kube-etcd
      Component:  kube-etcd
Events:           <none>

Service (created by kube-prometheus Chart)
Name:              kube-prometheus-exporter-kube-etcd
Namespace:         kube-system
Labels:            app=exporter-kube-etcd
                   chart=exporter-kube-etcd-0.1.15
                   component=kube-etcd
                   heritage=Tiller
                   release=kube-prometheus
Annotations:       <none>
Selector:          k8s-app=etcd-server
Type:              ClusterIP
IP:                None
Port:              http-metrics  4001/TCP
TargetPort:        4001/TCP
Endpoints:         <redacted>:4001,<redacted>:4001,<redacted>:4001
Session Affinity:  None
Events:            <none>

Etcd server pod labels (Created by Kops)
Labels:       k8s-app=etcd-server

Prometheus Operator Logs:
Not sure if these are relevant. Restarted the Pod to get logs different than "sync alertmanager" and "sync prometheus", which are the only logs after a few hours of runtime.

evel=info ts=2018-12-09T06:41:48.028636972Z caller=operator.go:292 component=prometheusoperator msg="connection established" cluster-version=v1.10.6
level=info ts=2018-12-09T06:41:48.031017419Z caller=operator.go:172 component=alertmanageroperator msg="connection established" cluster-version=v1.10.6
level=info ts=2018-12-09T06:41:48.16309026Z caller=operator.go:560 component=alertmanageroperator msg="CRD updated" crd=Alertmanager
level=info ts=2018-12-09T06:41:48.165255387Z caller=operator.go:1132 component=prometheusoperator msg="CRD updated" crd=Prometheus
level=info ts=2018-12-09T06:41:48.174046849Z caller=operator.go:1132 component=prometheusoperator msg="CRD updated" crd=ServiceMonitor
level=info ts=2018-12-09T06:41:48.183440145Z caller=operator.go:1132 component=prometheusoperator msg="CRD updated" crd=PrometheusRule
level=info ts=2018-12-09T06:41:51.170636266Z caller=operator.go:186 component=alertmanageroperator msg="CRD API endpoints ready"
level=info ts=2018-12-09T06:41:51.173120069Z caller=operator.go:396 component=alertmanageroperator msg="sync alertmanager" key=monitoring/kube-prometheus
E1209 06:41:51.204133       1 operator.go:272] Sync "monitoring/kube-prometheus" failed: creating statefulset failed: statefulsets.apps "alertmanager-kube-prometheus" already exists
level=info ts=2018-12-09T06:41:51.204934663Z caller=operator.go:396 component=alertmanageroperator msg="sync alertmanager" key=monitoring/kube-prometheus
level=info ts=2018-12-09T06:41:51.220686111Z caller=operator.go:396 component=alertmanageroperator msg="sync alertmanager" key=monitoring/kube-prometheus
level=info ts=2018-12-09T06:41:57.208163155Z caller=operator.go:306 component=prometheusoperator msg="CRD API endpoints ready"
level=info ts=2018-12-09T06:41:57.216490069Z caller=operator.go:731 component=prometheusoperator msg="sync prometheus" key=monitoring/kube-prometheus
level=info ts=2018-12-09T06:41:57.457037411Z caller=operator.go:731 component=prometheusoperator msg="sync prometheus" key=monitoring/kube-prometheus
level=info ts=2018-12-09T06:41:57.682665364Z caller=operator.go:731 component=prometheusoperator msg="sync prometheus" key=monitoring/kube-prometheus
level=info ts=2018-12-09T06:41:57.73801164Z caller=operator.go:731 component=prometheusoperator msg="sync prometheus" key=monitoring/kube-prometheus

I'm also fighting here to correctly configure a ServiceMonitor to scrape etcd. The first thing you have to check here is if you etcd cluster has TLS Enabled. in kops it is enabled with the spec in the cluster     enableEtcdTLS: true. In my case I have TLS enabled and I can't scrape because of an issue with the cert. I get:
Get https://<IP_ADDRESS>:4001/metrics: x509: certificate is valid for <IP_ADDRESS>, not <IP_ADDRESS>

I succeed to make it work. simply I had to create the Secret to load to Prometheus correctly by passing the client etcd cert and key. Not sure if this could help

@mazzy89 sorry to bother you. But what did you put in the secret? I am facing the same issue

@mazzy89 How did you manage to get it work exactly?
I added the option enableEtcdTLS: true to kops cluster config but I don't see any secret created for etcd in Kubernetes.
Moreover I tried to create the Secret, the prometheus Pod start but there is no metric available for etcd in Grafana

You need to manually create an etcd Secret and then reference the created secret in the prometheus-operator.
You need to grab the certs from any master machine.

@mazzy89
I've kops 1.12 and it looks like they completely changed the way etcd is deployed, they use etcd-manager now.
I see etcd-manager has etcd-client certs in its pods but unfortunately it seems that the ports used by prometheus-operator are no longer valid.

ok then it's up to you how you want to run it. I do run kops in Legacy mode because I don't like at all the idea of having etcd-manager. so kops in Legacy works for me.

I do run kops in Legacy mode because I don't like at all the idea of having etcd-manager. so kops in Legacy works for me.
That's for sure, but I suppose that Legacy also means that sooner or later kops is not going to use it anymore.

Ok I managed to get etcd scrape working with etcd-manager.
You can create the Secret needed for the operator to start properly like this:
podname=$(kubectl get pods -o=jsonpath='{.items[0].metadata.name}' -l k8s-app=kube-apiserver -n kube-system)

kubectl create secret generic etcd-certs -nmonitoring \
  --from-literal=ca.crt="$(kubectl exec $podname -nkube-system -- cat /etc/kubernetes/pki/kube-apiserver/etcd-ca.crt)" \
  --from-literal=client.crt="$(kubectl exec $podname -nkube-system -- cat /etc/kubernetes/pki/kube-apiserver/etcd-client.crt)" \
--from-literal=client.key="$(kubectl exec $podname -nkube-system -- cat /etc/kubernetes/pki/kube-apiserver/etcd-client.key)"

Once you have the Secret you can install the operator with the following values.xml snipped (only etcd relevant part included):
kubeEtcd:
  service:
    port: 4001
    targetPort: 4001
    selector:
     "k8s-app": "etcd-manager-main"
  serviceMonitor:
    scheme: https
    insecureSkipVerify: true
    caFile:   /etc/prometheus/secrets/etcd-certs/ca.crt
    certFile: /etc/prometheus/secrets/etcd-certs/client.crt
    keyFile:  /etc/prometheus/secrets/etcd-certs/client.key

Last but not least, you have to update the service prometheus-prometheus-oper-kube-etcd which the operator creates to monitor etcd removing the selector component: etcd so that its spec looks this way:
spec:
  clusterIP: None
  ports:
  - name: http-metrics
    port: 4001
    protocol: TCP
    targetPort: 4001
  selector:
    k8s-app: etcd-manager-main
  sessionAffinity: None
  type: ClusterIP

This ends up with etcd scraping working for me

Same way to configure the Legacy mode.

Glad to hear it's the same.
Apart from grabbing the Secret from the masters I couldn't find any hint about changing the service selectors, the service default ports and removing the additional component: etcd label so I thought a recap would have been useful for everyone

Thank you @irizzant, worked for me too on kops 1.12 and with prometheus-operator-5.12.4 helm chart. I would like to extend it a bit.
We also need to add the generated etcd-certs secret to the prometheus-operators values.yaml and we can remove in advance the component: etcd from the generated service by adding component: null
prometheus:
  prometheusSpec:
    secrets:
    - etcd-certs

kubeEtcd:
  service:
    port: 4001
    targetPort: 4001
    selector:
     component: null
     k8s-app: "etcd-manager-main"
  serviceMonitor:
    scheme: https
    insecureSkipVerify: true
    caFile:   /etc/prometheus/secrets/etcd-certs/ca.crt
    certFile: /etc/prometheus/secrets/etcd-certs/client.crt
    keyFile:  /etc/prometheus/secrets/etcd-certs/client.key

Thank you @tkozma for your solution, but with kops 1.12.1 and helm chart 5.12.4 i get this scraping error: "Get https://<IP_ADDRESS>:4001/metrics: context deadline exceeded".
Do you have any idea? certs are available. ServiceMonitor looks like this:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    app: prometheus-operator-kube-etcd
    chart: prometheus-operator-5.12.4
    heritage: Tiller
    release: prometheus
  name: prometheus-prometheus-oper-kube-etcd
  namespace: monitoring
spec:
  endpoints:
  - bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
    port: http-metrics
    scheme: https
    tlsConfig:
      caFile: /etc/prometheus/secrets/etcd-certs/ca.crt
      certFile: /etc/prometheus/secrets/etcd-certs/client.crt
      insecureSkipVerify: true
      keyFile: /etc/prometheus/secrets/etcd-certs/client.key
  jobLabel: jobLabel
  namespaceSelector:
    matchNames:
    - kube-system
  selector:
    matchLabels:
      app: prometheus-operator-kube-etcd
      release: prometheus

@mediaimprove I didn't encounter that error, your ServiceMonitor looks good. I only have a couple of ideas you to check.
First I think you should check, if you can poll the etcd metrics endpoint on the master instance.
This command executed on a master instance should return the etcd metrics.
$ curl https://localhost:4001/metrics -k \
   --cert /etc/kubernetes/pki/etcd-manager-main/etcd-clients-ca.crt \
   --key /etc/kubernetes/pki/etcd-manager-main/etcd-clients-ca.key

You can also check the scraped service:
$ kubectl get service -n kube-system -o=yaml \
  -l app=prometheus-operator-kube-etcd,release=prometheus

Look for the selectors:
  spec:
    clusterIP: None
    ports:
    - name: http-metrics
      port: 4001
      protocol: TCP
      targetPort: 4001
    selector:
      k8s-app: etcd-manager-main
    sessionAffinity: None
    type: ClusterIP
  status:
    loadBalancer: {}

With the selectors check the pods:
$ kubectl get pods -n kube-system -l k8s-app=etcd-manager-main

With describe check the endpoints of the service:
$ kubectl describe service -n kube-system \
   -l app=prometheus-operator-kube-etcd,release=prometheus

@mediaimprove - Were you able to solve your issue?
I was able to follow the setup provided in this issue, and do have 2/3 targets scraping correctly.  My third instance however shows that same Get https://#.#.#.#:4001/metrics: context deadline exceeded error.  My general understanding of this specific error is that some sort of SSL/TLS error has occurred, but I cannot understand why only one of my etcd instances would throw this error while the other two work fine.
I'm able to manually target the failing instance via curl without issue:
curl https://localhost:4001/metrics -k \    --cert /etc/kubernetes/pki/etcd-manager-main/etcd-clients-ca.crt \    --key /etc/kubernetes/pki/etcd-manager-main/etcd-clients-ca.key from the node itself.

@mediaimprove @jesse-welch kops doesn't allow nodes to access the masters on port 4001 (etcd client port) for security reasons, see your EC2 security group for the masters.

@mfrister - This was odd.  I had been successfully scraping from 2 etcd instances (see screenshot below).  However, when I checked my security group, I did find that 4001 was in fact not allowed.  I updated the security group, and suddenly all 3 etcd instances are being scraped.  Was very confident that this would not be the issue, given the success on 2/3.  Thanks for the tip.

after adding 4001 to the security group:

@jesse-welch also working on my installation now. thought too much about details rather than checking basics... thanks @mfrister

I have a question about creating etcd-certs automatically. Is it possible that kops itself generates etcd-certs or prom-operator can do it?

kops could publish something like this, but it's more intricate than that. Ideally you would want a distinct identity for prometheus and use etcd's authorization capabilities to allow prometheus' identity to do nothing but request metrics. Plus you would want to make sure to use the separate metrics port of etcd to request.

@stale Still interested in a better solution for this.

@irizzant @tkozma
Thanks for the solution, it worked for me on Kops version 1.14 and etcd 3.3+.

Anybody knows how to allow traffic from nodes to masters on port 4001 using kops?

kube-prometheus project moved out from this repository to https://github.com/coreos/kube-prometheus and with that this issue is no longer valid. If this is still happening please open a new issue in https://github.com/coreos/kube-prometheus repository.

same on v1.18.6 ubuntu


update ui plotting to date range

min max x axis = 2 plot request

@Bobfrat can you review and merge pls

:+1:


Jest react native SyntaxError: Unexpected identifier when using pnpm package installer

Description
Jest tests runs successfully after installing the dependencies using npm install but fails after using pnpm install .
Full error message :
/node_modules/.pnpm/@react-native+polyfills@2.0.0/node_modules/@react-native/polyfills/error-guard.js:14
    type ErrorHandler = (error: mixed, isFatal: boolean) => void;
         ^^^^^^^^^^^^
    SyntaxError: Unexpected identifier

Project structure :

package.json :
{
  "name": "MyApp",
  "scripts": {
    "test": "jest"
  },
  "dependencies": {
    "react": "18.2.0",
    "react-native": "^0.71.5"
  },
  "devDependencies": {
    "@types/jest": "^29.2.1",
    "@types/react": "^18.0.24",
    "@types/react-test-renderer": "^18.0.0",
    "jest": "^29.2.1",
    "react-test-renderer": "18.2.0"
  },
  "jest": {
    "preset": "react-native"
  }
}

babel.config.js :
module.exports = {
  presets: ["module:metro-react-native-babel-preset"],
};

app.test.js :
import App from "../App";
import renderer from "react-test-renderer";

it("renders correctly", () => {
  renderer.create(<App />);
  expect(1).toEqual(1);
});

React Native Version
0.71.5
Output of npx react-native info
System:
    OS: macOS 13.1
    CPU: (8) x64 Apple M1
    Memory: 39.25 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: Not Found
    npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.3 - /Users/mehdi/.rvm/rubies/ruby-2.7.6/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
    Android SDK:
      API Levels: 28, 29, 30, 31, 32, 33
      Build Tools: 28.0.3, 29.0.2, 30.0.2, 30.0.3, 31.0.0
      System Images: android-29 | Google APIs ARM 64 v8a, android-29 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.3 AI-213.7172.25.2113.9123335
    Xcode: 14.2/14C18 - /usr/bin/xcodebuild
  Languages:
    Java: 15.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^18.2.0 => 18.2.0
    react-native: ^0.71.5 => 0.71.5
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
pnpm install
pnpm run test
Snack, code example, screenshot, or link to a repository
Stackoverflow

Jest tests runs successfully after installing the dependencies using npm install but fails after using pnpm install .

Just a heads up that we don't fully support pnpm. This is due to Metro limitations with symlink support. We're looking into it so hopefully we will be able to relax this requirement soon

@1mehdifaraji Please try this on your package.json.
https://docs.expo.dev/develop/unit-testing/
  "jest": {
    "preset": "jest-expo",
    "transformIgnorePatterns": [
      "node_modules/(?!(?:.pnpm/)?((jest-)?react-native|@react-native(-community)?|expo(nent)?|@expo(nent)?/.*|@expo-google-fonts/.*|react-navigation|@react-navigation/.*|@unimodules/.*|unimodules|sentry-expo|native-base|react-native-svg))"
    ]
  },

This looks like a very similar issue to https://github.com/facebook/react-native/issues/33426 - both swc/jest and pnpm struggle/fail with the flow file pretending to be js.
It's weird that https://github.com/facebook/react-native/blob/main/packages/polyfills/error-guard.js has flow type annotations, while it's sibling https://github.com/facebook/react-native/blob/main/packages/polyfills/console.js has none.
Would it be an option to remove the flow types from polyfills/error-guard.js?

@waganse I don't think the change is a correct change. The paths aren't matching the right format, and changing it to that is basically the same as setting transformIgnorePatterns: [] (which also works btw - just a bit heavier).
The pattern that pnpm (and npm) uses for node_modules is roughly this:

pnpm: <root>/node_modules/.pnpm/<isolation-context>/node_modules/<module>
npm: <root>/node_modules/.store/<isolation-context>/node_modules/<module>

<module> is just the module name, which is what this pattern should match on.
<isolation-context> can be a single module, or group of modules (not sure how this is calculated). E.g.

<EMAIL_ADDRESS><EMAIL_ADDRESS>expo@50.0.0-preview.6_@babel+core@7.20.2_<EMAIL_ADDRESS>(copied from a test project)

We must filter out the "starting" node_modules/(?:\.pnpm|\.store)/<isolation-context> part from the current pattern. If we can match this before the original pattern matches, I think that should work. But no idea yet how we can do this.


Overdue Action Item Email Notification

Hi Team can we enable email notification for overdue action items for the respective member?

did you solve this ? thank you

hey @wasimdf ı did this property for 4minitz. if you want to how contact me.


[Question] Error in model.fit() when just 'import keras', not 'from tensorflow import keras'

Hi again!
I tried to run my code on gpu, and found, that it doesn't run because of I importing keras from tensorflow, not pure keras.
When I imported pure keras, my custom model class started to throw errors like this:
model.fit(X_train, y_train, x_validate=X_test, y_validate=y_test, batch_size=64, epochs = 2, callbacks=callbacks_list)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-40-3cc79a45c3fe> in <module>
----> 1 model.fit(X_train, y_train, x_validate=X_test, y_validate=y_test, batch_size=64, epochs = 2, callbacks=callbacks_list)

/usr/local/lib/python3.7/site-packages/kashgari/tasks/base_model.py in fit(self, x_train, y_train, x_validate, y_validate, batch_size, epochs, callbacks, fit_kwargs)
    255
    256         """
--> 257         self.build_model(x_train, y_train, x_validate, y_validate)
    258         train_generator = self.get_data_generator(x_train,
    259                                                   y_train,

/usr/local/lib/python3.7/site-packages/kashgari/tasks/base_model.py in build_model(self, x_train, y_train, x_validate, y_validate)
    112
    113         if self.tf_model is None:
--> 114             self.build_model_arc()
    115             self.compile_model()
    116

<ipython-input-38-e647835b68e1> in build_model_arc(self)
     41
     42         # Init model
---> 43         self.tf_model = keras.Model(embed_model.inputs, output_tensor)

/usr/local/lib/python3.7/site-packages/keras/legacy/interfaces.py in wrapper(*args, **kwargs)
     89                 warnings.warn('Update your `' + object_name + '` call to the ' +
     90                               'Keras 2 API: ' + signature, stacklevel=2)
---> 91             return func(*args, **kwargs)
     92         wrapper._original_function = func
     93         return wrapper

/usr/local/lib/python3.7/site-packages/keras/engine/network.py in __init__(self, *args, **kwargs)
     91                 'inputs' in kwargs and 'outputs' in kwargs):
     92             # Graph network
---> 93             self._init_graph_network(*args, **kwargs)
     94         else:
     95             # Subclassed network

/usr/local/lib/python3.7/site-packages/keras/engine/network.py in _init_graph_network(self, inputs, outputs, name)
    229         # Keep track of the network's nodes and layers.
    230         nodes, nodes_by_depth, layers, layers_by_depth = _map_graph_network(
--> 231             self.inputs, self.outputs)
    232         self._network_nodes = nodes
    233         self._nodes_by_depth = nodes_by_depth

/usr/local/lib/python3.7/site-packages/keras/engine/network.py in _map_graph_network(inputs, outputs)
   1364                   layer=layer,
   1365                   node_index=node_index,
-> 1366                   tensor_index=tensor_index)
   1367
   1368     for node in reversed(nodes_in_decreasing_depth):

/usr/local/lib/python3.7/site-packages/keras/engine/network.py in build_map(tensor, finished_nodes, nodes_in_progress, layer, node_index, tensor_index)
   1345
   1346         # Propagate to all previous tensors connected to this node.
-> 1347         for i in range(len(node.inbound_layers)):
   1348             x = node.input_tensors[i]
   1349             layer = node.inbound_layers[i]

TypeError: object of type 'LSTM' has no len()

Befor they have never arisen.
What can you advise me? And I really don't understand difference about pure keras and tensorflow keras.
Code of the class is like this at the moment:
class LSTM_Dropout_Dense_Model(BaseClassificationModel):
    """LSTM Dropout Dense over Embedding Model for Classification Task (as a Language Model)"""

    @classmethod
    def get_default_hyper_parameters(cls) -> Dict[str, Dict[str, Any]]:
        return {
            'layer_lstm': {
                'units': 150,
                'return_sequences': False #True
            },

         #   'layer_dropout': {
         #       'rate': 0.1
         #   },

            'layer_dense': {
                'activation': 'softmax'
            }
        }

    def build_model_arc(self):
        """
        build model architectural
        """
        output_dim = len(self.pre_processor.label2idx)
        config = self.hyper_parameters
        embed_model = self.embedding.embed_model

        # Define layers
        layer_lstm = L.LSTM(**config['layer_lstm'])

        #layer_dropout = L.Dropout(**config['layer_dropout'],
        #                          name='layer_dropout')

        layer_dense = L.Dense(output_dim, **config['layer_dense'])

        # Define tensor flow
        tensor = layer_lstm(embed_model.output)
        #tensor = layer_dropout(tensor)
        output_tensor = layer_dense(tensor)

        # Init model
        self.tf_model = keras.Model(embed_model.inputs, output_tensor)

Use tf.keras instead of keras, they provide some API but have a different internal implementation, so you can't use tf.keras layers with keras model.

Do you know how in tf.keras say to use gpu?

I mean, my main problem is that I know only how to say to pure keras use gpu, and I can't find in google how to say it to tf.keras

Yep, uninstall tensorflow, and install tensorflow-gpu.
You can test GPU status by this line of code.
tf.test.is_gpu_available()

I mean, my main problem is that I know only how to say to pure keras use gpu, and I can't find in google how to say it to tf.keras

If you installed tf-gpu, and tf.test.is_gpu_available(), which will return True when GPU driver and CUDA installed properly. tf.keras will use GPU automatically.

yep, I've read it and did it, but actually for unknown reason it doesn't work

I thought that the problem is that in code I need to use keras from tensorflow, not pure. But after your words I start thinking that it's not. And don't know what else

yep, I've read it and did it, but actually for unknown reason it doesn't work

Try this, in the terminal, start a python console by typing python3 Then. run those two line's of code.
import tensorflow as tf
print(tf.test.is_gpu_available())

Tensorflow will give you a detailed log about why you can't use GPU. When you using jupyter, you may miss the log.

I think it is not the problem of tf.keras or Keras, you need to just check the tensorflow-gpu. Tensorflow 1.14.0 requires CUDA10.

I have this version of CUDA, and this is strange. Please, don't close the issue for now, I'll try to google some things, when I solve this, I will write here experience and close issue by myself. Ok?

I have this version of CUDA, and this is strange. Please, don't close the issue for now, I'll try to google some things, when I solve this, I will write here experience and close issue by myself. Ok?

No worries, I will keep this issue open.

The problem for some still unknown reason arised only on one particular computer. On gpu cluster it works very fine.


[API] Using polling strategy for startCopyFromURL

Might need to merge startCopy and abortCopy in one API.

Proposed changes
Updates API in BlobAsyncClient and BlobClient to use azure-core's Poller<T>.
public Mono<String> startCopyFromURL(URL url);

to:
class BlobAsyncClient {
    Poller<BlobCopyOperation> beginCopyFromUrl(URL url);
}

@Immutable
class BlobCopyOperation {
    // Identifier for the copy operation
    String getId();

    // Gets the url of the destination blob.
    String getTargetUrl();

    // Gets the source url of the blob we are copying contents from.
    String getSourceUrl();

    // Gets the current status of the copy operation.
    CopyStatusType getStatus();

    // Gets any error description associated with the copy.
    String getError();
}

Example
public static void main(String[] args) {
    BlobAsyncClient client = getBlobClient("https://myaccount.blob.core.windows.net/mycontainer/destinationBlob");
    URL sourceUrl = new URL("https://myaccount.blob.core.windows.net/mycontainer/sourceBlob");
    Poller<BlobCopyOperation> blobCopyOperation = client.beginCopyFromUrl(sourceUrl);

    blobCopyOperation.poll().subscribe(polled -> {
        System.out.println("Poller status: " + polled.getStatus());
        System.out.println("Blob copy status: " + polled.getValue().getStatus());
    }, error -> {
        System.err.println("Error occurred: " + error);
    });
}

This looks fine to me. I think abortCopy needs to be included for cancelling the Poller, though

@rickle-msft Yup! Poller supports cancelOperation(), which will call abortCopy underneath the covers. :D.


Add support for multiple input files

Add support for multiple input files per DITA-OT process.
Interface changes
In the CLI, add support for multiple --input arguments.
$ dita -i maps/content.ditamap -i maps/keys.ditamap …

For project files, add support for multiple input fields.
contexts:
- input:
  - maps/content.ditamap
  - maps/keys.ditamap
…

Add args.inputs Ant property:
<pathconvert property="args.inputs">
  <pathelement location="maps/content.ditamap"/>
  <pathelement location="maps/keys.ditamap"/>
</pathconvert>

@robander args.input can be either system path or a URI, relative or absolute. I'd prefer to make args.inputs (notice the plural) always be absolute, to make things more simple. If a API in front of the Ant API allows relative paths, then it's up to that layer to resolve those to absolute paths.
However, because Ant doesn't have support for array types, do we want to use properties to be begin with for args.inputs? We could make it a resource collection instead, because Ant resources can be either files or e.g. URLs. But, I'm worried it will be too difficult to use and unnecessarily binds use to Ant.

@jelovirt Thinking about how I'm most likely to use this in our larger environment, I think URIs would be OK as long as it can take the absolute path:
/test/inputone.ditamap /test/bad%20name.ditamap
I think over time more and more people interact with the command through editors or build scripts, which should be able to hide or translate the values appropriately. Basically, adding that layer ahead of the build to translate paths in a more friendly way.
I'm also thinking about this (for now) as a more complex usage, where it seems more acceptable to enforce stricter rules about the input - maybe others would see it differently?

This could resolve #1697

Dropping from 3.4 release due to lack of interest. Maybe in 4.0


Docs for default value of options.errorStack do not match code

Docs in README say default value for options.errorStack is true but no code ever sets the value to true. The default value of options.errorStack is actually undefined, a falsly value, meaning utils.sanitizeError() will strip the stack trace by default.

One solution is to update the docs to reflect the actual behaviour. The second is to change the behaviour so the stack trace is included by default. My preference is the latter.

Good point. I'll update docs and leave current behaviour, at least for now, because:

I don't want to introduce breaking change
It is safer to remove stack by default to prevent accidental leak of sensitive data

I can understand your second point, but since Lambda logs exceptions by default (as do most other libraries/frameworks I know of) it would be nice to have that behaviour as well. It would probably help many developers debugging their code and would barely introduce any privacy issues because 1) the programmer should already have the responsibility of not logging anything sensitive and 2) the stacktrace goes to CloudWatch and not everyone usually has access to that. If the programmer doesn't want that then he can always disable the stack trace here. Just my 2 cents.

@zommerfelds It is not about logging. It removes stack trace from unhandled rejections before returning them to a user.

By user you mean the caller of lambda-handler-as-promised? Wouldn't that be AWS Lambda? When we go check our logs on CloudWatch we get an empty stack trace ([]).
We use it as:
module.exports.handler= lambdaHandler((event, context) => {
  // stuff
});

Yes user = caller, but caller is not AWS Lambda. Caller is a whatever system that uses your lambda. If you actually need stack trace, just set errorStack to true.

I see, you are probably talking about what data the Lambda instance returns. Most of our Lambdas are called by AWS or asynchronously (e.g. Kinesis, S3), so we don't use the return data. Anyway, I'm just saying that by using this default setting we get no stack traces in our logs, so we're gonna have to set errorStack to true on all our Lambdas.

Maybe a good trade-off would be to log the stack trace in the default error hook, but return the sanitized  (without stack trace) version to the caller?

lambda-handler-as-promised does not log anything as this can introduce way more serious security issues. You, as a developer, can define whatever behaviour you need by overriding config values and/or providing hooks.

AWS Lambda logs exception to CloudWatch by default, so I was just using that as a reference. But I get your point. Thanks for the comments :)


Code Blocks in Markdown Preview Don't Sync with Theme

Does this issue occur when all extensions are disabled?: Yes (But without extensions we cannot find this issue)

VS Code Version: 1.90.0 (Universal)
OS Version: Darwin x64 23.4.0

Steps to Reproduce:

Select the GitHub Theme as the Color Theme

Open *.md and paste the code in the below:
int n;

buffer = n;             // each can hold one item
semaphore mutex = 1;
semaphore empty = n;
semaphore full = 0;

It happened, the code blocks in Markdown preview don't sync with GitHub Theme

In the Markdown Preview, no matter how I change the Color Theme in VSCode, the code blocks in the Markdown Preview do not reflect the selected theme. I have tried various themes, including GitHub and Nord, but the preview colors remain in the default scheme.
Could you please advise on how to make the code blocks in Markdown Preview sync with the chosen Color Theme? This would greatly improve the experience of writing Markdown, as currently, I have two different syntax color schemes on my screen.
Screenshots:

related: #174090
Thanks a lot !!!

Duplicate of #91279 (from already linked issue)


Simplify ProtoFieldDecoder.

Fixes #112.

Does encoding support that right now? ProtobufVisitor currently doesn't make a distinction between required and optional fields, and I don't see anything in ProtobufDebugDescription that tries to distinguish either.


F #3272: Add presave postsave prerestore postrestore tm actions [not completed] [need help]

Signed-off-by: kvaps<EMAIL_ADDRESS>

Related to #3270. We'll address both at the same time

I am closing #3270 and #3271 in favour of #3272 because this solution could be implemented faster and at the moment with a configuration change that does not violate the OpenNebula Polices.


website: twif 1-5-15

Signed-off-by: Dominic Serio<EMAIL_ADDRESS>

Ping @titanous @danielsiders

LGTM